blob: de2ab576077f50c5dace98cebba8498d373cd361 [file] [log] [blame]
iannucci@chromium.org405b87e2015-11-12 18:08:34 +00001#!/usr/bin/env python
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02002# Copyright (c) 2013 The Chromium Authors. All rights reserved.
maruel@chromium.org725f1c32011-04-01 20:24:54 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006# Copyright (C) 2008 Evan Martin <martine@danga.com>
7
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00008"""A git-command for integrating reviews on Gerrit."""
maruel@chromium.org725f1c32011-04-01 20:24:54 +00009
vapiera7fbd5a2016-06-16 09:17:49 -070010from __future__ import print_function
11
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +000012from distutils.version import LooseVersion
calamity@chromium.orgffde55c2015-03-12 00:44:17 +000013from multiprocessing.pool import ThreadPool
thakis@chromium.org3421c992014-11-02 02:20:32 +000014import base64
rmistry@google.com2dd99862015-06-22 12:22:18 +000015import collections
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +010016import contextlib
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010017import datetime
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +010018import fnmatch
sheyang@google.com6ebaf782015-05-12 19:17:54 +000019import httplib
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +010020import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000021import json
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000022import logging
calamity@chromium.orgcf197482016-04-29 20:15:53 +000023import multiprocessing
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000024import optparse
25import os
26import re
Andrii Shyshkalov353637c2017-03-14 16:52:18 +010027import shutil
ukai@chromium.org78c4b982012-02-14 02:20:26 +000028import stat
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000029import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070030import tempfile
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000031import textwrap
Edward Lemurfec80c42018-11-01 23:14:14 +000032import time
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000033import urllib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000034import urllib2
maruel@chromium.org967c0a82013-06-17 22:52:24 +000035import urlparse
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000036import uuid
thestig@chromium.org00858c82013-12-02 23:08:03 +000037import webbrowser
thakis@chromium.org3421c992014-11-02 02:20:32 +000038import zlib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000039
40try:
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -080041 import readline # pylint: disable=import-error,W0611
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000042except ImportError:
43 pass
44
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000045from third_party import colorama
sheyang@google.com6ebaf782015-05-12 19:17:54 +000046from third_party import httplib2
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000047import auth
skobes6468b902016-10-24 08:45:10 -070048import checkout
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +000049import clang_format
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +000050import dart_format
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +000051import setup_color
maruel@chromium.org6f09cd92011-04-01 16:38:12 +000052import fix_encoding
maruel@chromium.org0e0436a2011-10-25 13:32:41 +000053import gclient_utils
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +000054import gerrit_util
szager@chromium.org151ebcf2016-03-09 01:08:25 +000055import git_cache
iannucci@chromium.org9e849272014-04-04 00:31:55 +000056import git_common
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +000057import git_footers
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000058import metrics
Edward Lesmes93277a72018-10-18 22:04:26 +000059import metrics_utils
piman@chromium.org336f9122014-09-04 02:16:55 +000060import owners
iannucci@chromium.org9e849272014-04-04 00:31:55 +000061import owners_finder
maruel@chromium.org2a74d372011-03-29 19:05:50 +000062import presubmit_support
63import scm
Francois Dorayd42c6812017-05-30 15:10:20 -040064import split_cl
maruel@chromium.org0633fb42013-08-16 20:06:14 +000065import subcommand
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +000066import subprocess2
maruel@chromium.org2a74d372011-03-29 19:05:50 +000067import watchlists
68
tandrii7400cf02016-06-21 08:48:07 -070069__version__ = '2.0'
maruel@chromium.org2a74d372011-03-29 19:05:50 +000070
tandrii9d2c7a32016-06-22 03:42:45 -070071COMMIT_BOT_EMAIL = 'commit-bot@chromium.org'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -080072POSTUPSTREAM_HOOK = '.git/hooks/post-cl-land'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000073DESCRIPTION_BACKUP_FILE = '~/.git_cl_description_backup'
rmistry@google.comc68112d2015-03-03 12:48:06 +000074REFS_THAT_ALIAS_TO_OTHER_REFS = {
75 'refs/remotes/origin/lkgr': 'refs/remotes/origin/master',
76 'refs/remotes/origin/lkcr': 'refs/remotes/origin/master',
77}
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000078
thestig@chromium.org44202a22014-03-11 19:22:18 +000079# Valid extensions for files we want to lint.
80DEFAULT_LINT_REGEX = r"(.*\.cpp|.*\.cc|.*\.h)"
81DEFAULT_LINT_IGNORE_REGEX = r"$^"
82
Aiden Bennerc08566e2018-10-03 17:52:42 +000083# File name for yapf style config files.
84YAPF_CONFIG_FILENAME = '.style.yapf'
85
borenet6c0efe62016-10-19 08:13:29 -070086# Buildbucket master name prefix.
87MASTER_PREFIX = 'master.'
88
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000089# Shortcut since it quickly becomes redundant.
90Fore = colorama.Fore
maruel@chromium.org90541732011-04-01 17:54:18 +000091
maruel@chromium.orgddd59412011-11-30 14:20:38 +000092# Initialized in main()
93settings = None
94
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +010095# Used by tests/git_cl_test.py to add extra logging.
96# Inside the weirdly failing test, add this:
97# >>> self.mock(git_cl, '_IS_BEING_TESTED', True)
Quinten Yearsley0c62da92017-05-31 13:39:42 -070098# And scroll up to see the stack trace printed.
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +010099_IS_BEING_TESTED = False
100
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000101
Christopher Lamf732cd52017-01-24 12:40:11 +1100102def DieWithError(message, change_desc=None):
103 if change_desc:
104 SaveDescriptionBackup(change_desc)
105
vapiera7fbd5a2016-06-16 09:17:49 -0700106 print(message, file=sys.stderr)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000107 sys.exit(1)
108
109
Christopher Lamf732cd52017-01-24 12:40:11 +1100110def SaveDescriptionBackup(change_desc):
111 backup_path = os.path.expanduser(DESCRIPTION_BACKUP_FILE)
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000112 print('\nsaving CL description to %s\n' % backup_path)
Christopher Lamf732cd52017-01-24 12:40:11 +1100113 backup_file = open(backup_path, 'w')
114 backup_file.write(change_desc.description)
115 backup_file.close()
116
117
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000118def GetNoGitPagerEnv():
119 env = os.environ.copy()
120 # 'cat' is a magical git string that disables pagers on all platforms.
121 env['GIT_PAGER'] = 'cat'
122 return env
123
vadimsh@chromium.org566a02a2014-08-22 01:34:13 +0000124
bsep@chromium.org627d9002016-04-29 00:00:52 +0000125def RunCommand(args, error_ok=False, error_message=None, shell=False, **kwargs):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000126 try:
bsep@chromium.org627d9002016-04-29 00:00:52 +0000127 return subprocess2.check_output(args, shell=shell, **kwargs)
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000128 except subprocess2.CalledProcessError as e:
129 logging.debug('Failed running %s', args)
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000130 if not error_ok:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000131 DieWithError(
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000132 'Command "%s" failed.\n%s' % (
133 ' '.join(args), error_message or e.stdout or ''))
134 return e.stdout
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000135
136
137def RunGit(args, **kwargs):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000138 """Returns stdout."""
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000139 return RunCommand(['git'] + args, **kwargs)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000140
141
enne@chromium.org3b7e15c2014-01-21 17:44:47 +0000142def RunGitWithCode(args, suppress_stderr=False):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000143 """Returns return code and stdout."""
tandrii5d48c322016-08-18 16:19:37 -0700144 if suppress_stderr:
145 stderr = subprocess2.VOID
146 else:
147 stderr = sys.stderr
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000148 try:
tandrii5d48c322016-08-18 16:19:37 -0700149 (out, _), code = subprocess2.communicate(['git'] + args,
150 env=GetNoGitPagerEnv(),
151 stdout=subprocess2.PIPE,
152 stderr=stderr)
153 return code, out
154 except subprocess2.CalledProcessError as e:
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +0900155 logging.debug('Failed running %s', ['git'] + args)
tandrii5d48c322016-08-18 16:19:37 -0700156 return e.returncode, e.stdout
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000157
158
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000159def RunGitSilent(args):
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000160 """Returns stdout, suppresses stderr and ignores the return code."""
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000161 return RunGitWithCode(args, suppress_stderr=True)[1]
162
163
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000164def IsGitVersionAtLeast(min_version):
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000165 prefix = 'git version '
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000166 version = RunGit(['--version']).strip()
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000167 return (version.startswith(prefix) and
168 LooseVersion(version[len(prefix):]) >= LooseVersion(min_version))
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000169
170
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000171def BranchExists(branch):
172 """Return True if specified branch exists."""
173 code, _ = RunGitWithCode(['rev-parse', '--verify', branch],
174 suppress_stderr=True)
175 return not code
176
177
tandrii2a16b952016-10-19 07:09:44 -0700178def time_sleep(seconds):
179 # Use this so that it can be mocked in tests without interfering with python
180 # system machinery.
tandrii2a16b952016-10-19 07:09:44 -0700181 return time.sleep(seconds)
182
183
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000184def time_time():
185 # Use this so that it can be mocked in tests without interfering with python
186 # system machinery.
187 return time.time()
188
189
maruel@chromium.org90541732011-04-01 17:54:18 +0000190def ask_for_data(prompt):
191 try:
192 return raw_input(prompt)
193 except KeyboardInterrupt:
194 # Hide the exception.
195 sys.exit(1)
196
197
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100198def confirm_or_exit(prefix='', action='confirm'):
199 """Asks user to press enter to continue or press Ctrl+C to abort."""
200 if not prefix or prefix.endswith('\n'):
201 mid = 'Press'
Andrii Shyshkalov353637c2017-03-14 16:52:18 +0100202 elif prefix.endswith('.') or prefix.endswith('?'):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100203 mid = ' Press'
204 elif prefix.endswith(' '):
205 mid = 'press'
206 else:
207 mid = ' press'
208 ask_for_data('%s%s Enter to %s, or Ctrl+C to abort' % (prefix, mid, action))
209
210
211def ask_for_explicit_yes(prompt):
212 """Returns whether user typed 'y' or 'yes' to confirm the given prompt"""
213 result = ask_for_data(prompt + ' [Yes/No]: ').lower()
214 while True:
215 if 'yes'.startswith(result):
216 return True
217 if 'no'.startswith(result):
218 return False
219 result = ask_for_data('Please, type yes or no: ').lower()
220
221
tandrii5d48c322016-08-18 16:19:37 -0700222def _git_branch_config_key(branch, key):
223 """Helper method to return Git config key for a branch."""
224 assert branch, 'branch name is required to set git config for it'
225 return 'branch.%s.%s' % (branch, key)
226
227
228def _git_get_branch_config_value(key, default=None, value_type=str,
229 branch=False):
230 """Returns git config value of given or current branch if any.
231
232 Returns default in all other cases.
233 """
234 assert value_type in (int, str, bool)
235 if branch is False: # Distinguishing default arg value from None.
236 branch = GetCurrentBranch()
237
rogerta@chromium.orgcaa16552013-03-18 20:45:05 +0000238 if not branch:
tandrii5d48c322016-08-18 16:19:37 -0700239 return default
rogerta@chromium.orgcaa16552013-03-18 20:45:05 +0000240
tandrii5d48c322016-08-18 16:19:37 -0700241 args = ['config']
tandrii33a46ff2016-08-23 05:53:40 -0700242 if value_type == bool:
tandrii5d48c322016-08-18 16:19:37 -0700243 args.append('--bool')
tandrii33a46ff2016-08-23 05:53:40 -0700244 # git config also has --int, but apparently git config suffers from integer
245 # overflows (http://crbug.com/640115), so don't use it.
tandrii5d48c322016-08-18 16:19:37 -0700246 args.append(_git_branch_config_key(branch, key))
247 code, out = RunGitWithCode(args)
248 if code == 0:
249 value = out.strip()
250 if value_type == int:
251 return int(value)
252 if value_type == bool:
253 return bool(value.lower() == 'true')
254 return value
iannucci@chromium.org79540052012-10-19 23:15:26 +0000255 return default
256
257
tandrii5d48c322016-08-18 16:19:37 -0700258def _git_set_branch_config_value(key, value, branch=None, **kwargs):
259 """Sets the value or unsets if it's None of a git branch config.
260
261 Valid, though not necessarily existing, branch must be provided,
262 otherwise currently checked out branch is used.
263 """
264 if not branch:
265 branch = GetCurrentBranch()
266 assert branch, 'a branch name OR currently checked out branch is required'
267 args = ['config']
qyearsley12fa6ff2016-08-24 09:18:40 -0700268 # Check for boolean first, because bool is int, but int is not bool.
tandrii5d48c322016-08-18 16:19:37 -0700269 if value is None:
270 args.append('--unset')
271 elif isinstance(value, bool):
272 args.append('--bool')
273 value = str(value).lower()
tandrii5d48c322016-08-18 16:19:37 -0700274 else:
tandrii33a46ff2016-08-23 05:53:40 -0700275 # git config also has --int, but apparently git config suffers from integer
276 # overflows (http://crbug.com/640115), so don't use it.
tandrii5d48c322016-08-18 16:19:37 -0700277 value = str(value)
278 args.append(_git_branch_config_key(branch, key))
279 if value is not None:
280 args.append(value)
281 RunGit(args, **kwargs)
282
283
Andrii Shyshkalova6695812016-12-06 17:47:09 +0100284def _get_committer_timestamp(commit):
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700285 """Returns Unix timestamp as integer of a committer in a commit.
Andrii Shyshkalova6695812016-12-06 17:47:09 +0100286
287 Commit can be whatever git show would recognize, such as HEAD, sha1 or ref.
288 """
289 # Git also stores timezone offset, but it only affects visual display,
290 # actual point in time is defined by this timestamp only.
291 return int(RunGit(['show', '-s', '--format=%ct', commit]).strip())
292
293
294def _git_amend_head(message, committer_timestamp):
295 """Amends commit with new message and desired committer_timestamp.
296
297 Sets committer timezone to UTC.
298 """
299 env = os.environ.copy()
300 env['GIT_COMMITTER_DATE'] = '%d+0000' % committer_timestamp
301 return RunGit(['commit', '--amend', '-m', message], env=env)
302
303
machenbach@chromium.org45453142015-09-15 08:45:22 +0000304def _get_properties_from_options(options):
305 properties = dict(x.split('=', 1) for x in options.properties)
306 for key, val in properties.iteritems():
307 try:
308 properties[key] = json.loads(val)
309 except ValueError:
310 pass # If a value couldn't be evaluated, treat it as a string.
311 return properties
312
313
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000314def _prefix_master(master):
315 """Convert user-specified master name to full master name.
316
317 Buildbucket uses full master name(master.tryserver.chromium.linux) as bucket
318 name, while the developers always use shortened master name
319 (tryserver.chromium.linux) by stripping off the prefix 'master.'. This
320 function does the conversion for buildbucket migration.
321 """
borenet6c0efe62016-10-19 08:13:29 -0700322 if master.startswith(MASTER_PREFIX):
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000323 return master
borenet6c0efe62016-10-19 08:13:29 -0700324 return '%s%s' % (MASTER_PREFIX, master)
325
326
327def _unprefix_master(bucket):
328 """Convert bucket name to shortened master name.
329
330 Buildbucket uses full master name(master.tryserver.chromium.linux) as bucket
331 name, while the developers always use shortened master name
332 (tryserver.chromium.linux) by stripping off the prefix 'master.'. This
333 function does the conversion for buildbucket migration.
334 """
335 if bucket.startswith(MASTER_PREFIX):
336 return bucket[len(MASTER_PREFIX):]
337 return bucket
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000338
339
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000340def _buildbucket_retry(operation_name, http, *args, **kwargs):
341 """Retries requests to buildbucket service and returns parsed json content."""
342 try_count = 0
343 while True:
344 response, content = http.request(*args, **kwargs)
345 try:
346 content_json = json.loads(content)
347 except ValueError:
348 content_json = None
349
350 # Buildbucket could return an error even if status==200.
351 if content_json and content_json.get('error'):
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000352 error = content_json.get('error')
353 if error.get('code') == 403:
354 raise BuildbucketResponseException(
355 'Access denied: %s' % error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000356 msg = 'Error in response. Reason: %s. Message: %s.' % (
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000357 error.get('reason', ''), error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000358 raise BuildbucketResponseException(msg)
359
360 if response.status == 200:
Nodir Turakulov23d75d22018-06-04 12:37:32 -0700361 if content_json is None:
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000362 raise BuildbucketResponseException(
363 'Buildbucket returns invalid json content: %s.\n'
Nodir Turakulov9ac59792018-06-04 12:34:14 -0700364 'Please file bugs at http://crbug.com, '
365 'component "Infra>Platform>BuildBucket".' %
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000366 content)
367 return content_json
368 if response.status < 500 or try_count >= 2:
369 raise httplib2.HttpLib2Error(content)
370
371 # status >= 500 means transient failures.
372 logging.debug('Transient errors when %s. Will retry.', operation_name)
tandrii2a16b952016-10-19 07:09:44 -0700373 time_sleep(0.5 + 1.5*try_count)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000374 try_count += 1
375 assert False, 'unreachable'
376
377
qyearsley1fdfcb62016-10-24 13:22:03 -0700378def _get_bucket_map(changelist, options, option_parser):
qyearsleydd49f942016-10-28 11:57:22 -0700379 """Returns a dict mapping bucket names to builders and tests,
380 for triggering try jobs.
qyearsley1fdfcb62016-10-24 13:22:03 -0700381 """
qyearsleydd49f942016-10-28 11:57:22 -0700382 # If no bots are listed, we try to get a set of builders and tests based
383 # on GetPreferredTryMasters functions in PRESUBMIT.py files.
qyearsley1fdfcb62016-10-24 13:22:03 -0700384 if not options.bot:
385 change = changelist.GetChange(
386 changelist.GetCommonAncestorWithUpstream(), None)
qyearsley136b49f2016-10-31 09:02:26 -0700387 # Get try masters from PRESUBMIT.py files.
nodire4f0fe02016-11-04 16:23:30 -0700388 masters = presubmit_support.DoGetTryMasters(
qyearsley1fdfcb62016-10-24 13:22:03 -0700389 change=change,
390 changed_files=change.LocalPaths(),
391 repository_root=settings.GetRoot(),
392 default_presubmit=None,
393 project=None,
394 verbose=options.verbose,
395 output_stream=sys.stdout)
nodire4f0fe02016-11-04 16:23:30 -0700396 if masters is None:
397 return None
Sergiy Byelozyorov935b93f2016-11-28 20:41:56 +0100398 return {_prefix_master(m): b for m, b in masters.iteritems()}
qyearsley1fdfcb62016-10-24 13:22:03 -0700399
qyearsley1fdfcb62016-10-24 13:22:03 -0700400 if options.bucket:
401 return {options.bucket: {b: [] for b in options.bot}}
qyearsleydd49f942016-10-28 11:57:22 -0700402 if options.master:
403 return {_prefix_master(options.master): {b: [] for b in options.bot}}
qyearsley1fdfcb62016-10-24 13:22:03 -0700404
qyearsleydd49f942016-10-28 11:57:22 -0700405 # If bots are listed but no master or bucket, then we need to find out
406 # the corresponding master for each bot.
407 bucket_map, error_message = _get_bucket_map_for_builders(options.bot)
408 if error_message:
409 option_parser.error(
410 'Tryserver master cannot be found because: %s\n'
411 'Please manually specify the tryserver master, e.g. '
412 '"-m tryserver.chromium.linux".' % error_message)
413 return bucket_map
qyearsley1fdfcb62016-10-24 13:22:03 -0700414
415
qyearsley123a4682016-10-26 09:12:17 -0700416def _get_bucket_map_for_builders(builders):
417 """Returns a map of buckets to builders for the given builders."""
qyearsley1fdfcb62016-10-24 13:22:03 -0700418 map_url = 'https://builders-map.appspot.com/'
419 try:
qyearsley123a4682016-10-26 09:12:17 -0700420 builders_map = json.load(urllib2.urlopen(map_url))
qyearsley1fdfcb62016-10-24 13:22:03 -0700421 except urllib2.URLError as e:
422 return None, ('Failed to fetch builder-to-master map from %s. Error: %s.' %
423 (map_url, e))
424 except ValueError as e:
425 return None, ('Invalid json string from %s. Error: %s.' % (map_url, e))
qyearsley123a4682016-10-26 09:12:17 -0700426 if not builders_map:
qyearsley1fdfcb62016-10-24 13:22:03 -0700427 return None, 'Failed to build master map.'
428
qyearsley123a4682016-10-26 09:12:17 -0700429 bucket_map = {}
430 for builder in builders:
Nodir Turakulovb422e682018-02-20 22:51:30 -0800431 bucket = builders_map.get(builder, {}).get('bucket')
432 if bucket:
433 bucket_map.setdefault(bucket, {})[builder] = []
qyearsley123a4682016-10-26 09:12:17 -0700434 return bucket_map, None
qyearsley1fdfcb62016-10-24 13:22:03 -0700435
436
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -0800437def _trigger_try_jobs(auth_config, changelist, buckets, options, patchset):
qyearsley1fdfcb62016-10-24 13:22:03 -0700438 """Sends a request to Buildbucket to trigger try jobs for a changelist.
439
440 Args:
Aaron Gablefb28d482018-04-02 13:08:06 -0700441 auth_config: AuthConfig for Buildbucket.
qyearsley1fdfcb62016-10-24 13:22:03 -0700442 changelist: Changelist that the try jobs are associated with.
443 buckets: A nested dict mapping bucket names to builders to tests.
444 options: Command-line options.
445 """
tandriide281ae2016-10-12 06:02:30 -0700446 assert changelist.GetIssue(), 'CL must be uploaded first'
447 codereview_url = changelist.GetCodereviewServer()
448 assert codereview_url, 'CL must be uploaded first'
449 patchset = patchset or changelist.GetMostRecentPatchset()
450 assert patchset, 'CL must be uploaded first'
451
452 codereview_host = urlparse.urlparse(codereview_url).hostname
Aaron Gablefb28d482018-04-02 13:08:06 -0700453 # Cache the buildbucket credentials under the codereview host key, so that
454 # users can use different credentials for different buckets.
tandriide281ae2016-10-12 06:02:30 -0700455 authenticator = auth.get_authenticator_for_host(codereview_host, auth_config)
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000456 http = authenticator.authorize(httplib2.Http())
457 http.force_exception_to_status_code = True
tandriide281ae2016-10-12 06:02:30 -0700458
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000459 buildbucket_put_url = (
460 'https://{hostname}/_ah/api/buildbucket/v1/builds/batch'.format(
sheyang@chromium.orgdb375572015-08-17 19:22:23 +0000461 hostname=options.buildbucket_host))
Andrii Shyshkalov03da1502018-10-15 03:42:34 +0000462 buildset = 'patch/gerrit/{hostname}/{issue}/{patch}'.format(
tandriide281ae2016-10-12 06:02:30 -0700463 hostname=codereview_host,
464 issue=changelist.GetIssue(),
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000465 patch=patchset)
tandrii8c5a3532016-11-04 07:52:02 -0700466
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700467 shared_parameters_properties = changelist.GetTryJobProperties(patchset)
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -0800468 shared_parameters_properties['category'] = options.category
tandrii8c5a3532016-11-04 07:52:02 -0700469 if options.clobber:
470 shared_parameters_properties['clobber'] = True
tandriide281ae2016-10-12 06:02:30 -0700471 extra_properties = _get_properties_from_options(options)
tandrii8c5a3532016-11-04 07:52:02 -0700472 if extra_properties:
473 shared_parameters_properties.update(extra_properties)
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000474
475 batch_req_body = {'builds': []}
476 print_text = []
477 print_text.append('Tried jobs on:')
borenet6c0efe62016-10-19 08:13:29 -0700478 for bucket, builders_and_tests in sorted(buckets.iteritems()):
479 print_text.append('Bucket: %s' % bucket)
480 master = None
481 if bucket.startswith(MASTER_PREFIX):
482 master = _unprefix_master(bucket)
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000483 for builder, tests in sorted(builders_and_tests.iteritems()):
484 print_text.append(' %s: %s' % (builder, tests))
485 parameters = {
486 'builder_name': builder,
nodir@chromium.orgd2217312015-09-21 15:51:21 +0000487 'changes': [{
Andrii Shyshkaloveadad922017-01-26 09:38:30 +0100488 'author': {'email': changelist.GetIssueOwner()},
nodir@chromium.orgd2217312015-09-21 15:51:21 +0000489 'revision': options.revision,
490 }],
tandrii8c5a3532016-11-04 07:52:02 -0700491 'properties': shared_parameters_properties.copy(),
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000492 }
machenbach@chromium.org2403e802016-04-29 12:34:42 +0000493 if 'presubmit' in builder.lower():
494 parameters['properties']['dry_run'] = 'true'
tandrii@chromium.org3764fa22015-10-21 16:40:40 +0000495 if tests:
496 parameters['properties']['testfilter'] = tests
borenet6c0efe62016-10-19 08:13:29 -0700497
498 tags = [
499 'builder:%s' % builder,
500 'buildset:%s' % buildset,
501 'user_agent:git_cl_try',
502 ]
503 if master:
504 parameters['properties']['master'] = master
505 tags.append('master:%s' % master)
506
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000507 batch_req_body['builds'].append(
508 {
509 'bucket': bucket,
510 'parameters_json': json.dumps(parameters),
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000511 'client_operation_id': str(uuid.uuid4()),
borenet6c0efe62016-10-19 08:13:29 -0700512 'tags': tags,
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000513 }
514 )
515
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000516 _buildbucket_retry(
qyearsleyeab3c042016-08-24 09:18:28 -0700517 'triggering try jobs',
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000518 http,
519 buildbucket_put_url,
520 'PUT',
521 body=json.dumps(batch_req_body),
522 headers={'Content-Type': 'application/json'}
523 )
tandrii@chromium.org35c61452016-02-26 15:24:57 +0000524 print_text.append('To see results here, run: git cl try-results')
525 print_text.append('To see results in browser, run: git cl web')
vapiera7fbd5a2016-06-16 09:17:49 -0700526 print('\n'.join(print_text))
kjellander@chromium.org44424542015-06-02 18:35:29 +0000527
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000528
tandrii221ab252016-10-06 08:12:04 -0700529def fetch_try_jobs(auth_config, changelist, buildbucket_host,
530 patchset=None):
qyearsleyeab3c042016-08-24 09:18:28 -0700531 """Fetches try jobs from buildbucket.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000532
qyearsley53f48a12016-09-01 10:45:13 -0700533 Returns a map from build id to build info as a dictionary.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000534 """
tandrii221ab252016-10-06 08:12:04 -0700535 assert buildbucket_host
536 assert changelist.GetIssue(), 'CL must be uploaded first'
537 assert changelist.GetCodereviewServer(), 'CL must be uploaded first'
538 patchset = patchset or changelist.GetMostRecentPatchset()
539 assert patchset, 'CL must be uploaded first'
540
541 codereview_url = changelist.GetCodereviewServer()
542 codereview_host = urlparse.urlparse(codereview_url).hostname
543 authenticator = auth.get_authenticator_for_host(codereview_host, auth_config)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000544 if authenticator.has_cached_credentials():
545 http = authenticator.authorize(httplib2.Http())
546 else:
vapiera7fbd5a2016-06-16 09:17:49 -0700547 print('Warning: Some results might be missing because %s' %
548 # Get the message on how to login.
tandrii221ab252016-10-06 08:12:04 -0700549 (auth.LoginRequiredError(codereview_host).message,))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000550 http = httplib2.Http()
551
552 http.force_exception_to_status_code = True
553
Andrii Shyshkalov03da1502018-10-15 03:42:34 +0000554 buildset = 'patch/gerrit/{hostname}/{issue}/{patch}'.format(
tandrii221ab252016-10-06 08:12:04 -0700555 hostname=codereview_host,
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000556 issue=changelist.GetIssue(),
tandrii221ab252016-10-06 08:12:04 -0700557 patch=patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000558 params = {'tag': 'buildset:%s' % buildset}
559
560 builds = {}
561 while True:
562 url = 'https://{hostname}/_ah/api/buildbucket/v1/search?{params}'.format(
tandrii221ab252016-10-06 08:12:04 -0700563 hostname=buildbucket_host,
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000564 params=urllib.urlencode(params))
qyearsleyeab3c042016-08-24 09:18:28 -0700565 content = _buildbucket_retry('fetching try jobs', http, url, 'GET')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000566 for build in content.get('builds', []):
567 builds[build['id']] = build
568 if 'next_cursor' in content:
569 params['start_cursor'] = content['next_cursor']
570 else:
571 break
572 return builds
573
574
qyearsleyeab3c042016-08-24 09:18:28 -0700575def print_try_jobs(options, builds):
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000576 """Prints nicely result of fetch_try_jobs."""
577 if not builds:
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700578 print('No try jobs scheduled.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000579 return
580
581 # Make a copy, because we'll be modifying builds dictionary.
582 builds = builds.copy()
583 builder_names_cache = {}
584
585 def get_builder(b):
586 try:
587 return builder_names_cache[b['id']]
588 except KeyError:
589 try:
590 parameters = json.loads(b['parameters_json'])
591 name = parameters['builder_name']
592 except (ValueError, KeyError) as error:
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700593 print('WARNING: Failed to get builder name for build %s: %s' % (
vapiera7fbd5a2016-06-16 09:17:49 -0700594 b['id'], error))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000595 name = None
596 builder_names_cache[b['id']] = name
597 return name
598
599 def get_bucket(b):
600 bucket = b['bucket']
601 if bucket.startswith('master.'):
602 return bucket[len('master.'):]
603 return bucket
604
605 if options.print_master:
606 name_fmt = '%%-%ds %%-%ds' % (
607 max(len(str(get_bucket(b))) for b in builds.itervalues()),
608 max(len(str(get_builder(b))) for b in builds.itervalues()))
609 def get_name(b):
610 return name_fmt % (get_bucket(b), get_builder(b))
611 else:
612 name_fmt = '%%-%ds' % (
613 max(len(str(get_builder(b))) for b in builds.itervalues()))
614 def get_name(b):
615 return name_fmt % get_builder(b)
616
617 def sort_key(b):
618 return b['status'], b.get('result'), get_name(b), b.get('url')
619
620 def pop(title, f, color=None, **kwargs):
621 """Pop matching builds from `builds` dict and print them."""
622
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +0000623 if not options.color or color is None:
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000624 colorize = str
625 else:
626 colorize = lambda x: '%s%s%s' % (color, x, Fore.RESET)
627
628 result = []
629 for b in builds.values():
630 if all(b.get(k) == v for k, v in kwargs.iteritems()):
631 builds.pop(b['id'])
632 result.append(b)
633 if result:
vapiera7fbd5a2016-06-16 09:17:49 -0700634 print(colorize(title))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000635 for b in sorted(result, key=sort_key):
vapiera7fbd5a2016-06-16 09:17:49 -0700636 print(' ', colorize('\t'.join(map(str, f(b)))))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000637
638 total = len(builds)
639 pop(status='COMPLETED', result='SUCCESS',
640 title='Successes:', color=Fore.GREEN,
641 f=lambda b: (get_name(b), b.get('url')))
642 pop(status='COMPLETED', result='FAILURE', failure_reason='INFRA_FAILURE',
643 title='Infra Failures:', color=Fore.MAGENTA,
644 f=lambda b: (get_name(b), b.get('url')))
645 pop(status='COMPLETED', result='FAILURE', failure_reason='BUILD_FAILURE',
646 title='Failures:', color=Fore.RED,
647 f=lambda b: (get_name(b), b.get('url')))
648 pop(status='COMPLETED', result='CANCELED',
649 title='Canceled:', color=Fore.MAGENTA,
650 f=lambda b: (get_name(b),))
651 pop(status='COMPLETED', result='FAILURE',
652 failure_reason='INVALID_BUILD_DEFINITION',
653 title='Wrong master/builder name:', color=Fore.MAGENTA,
654 f=lambda b: (get_name(b),))
655 pop(status='COMPLETED', result='FAILURE',
656 title='Other failures:',
657 f=lambda b: (get_name(b), b.get('failure_reason'), b.get('url')))
658 pop(status='COMPLETED',
659 title='Other finished:',
660 f=lambda b: (get_name(b), b.get('result'), b.get('url')))
661 pop(status='STARTED',
662 title='Started:', color=Fore.YELLOW,
663 f=lambda b: (get_name(b), b.get('url')))
664 pop(status='SCHEDULED',
665 title='Scheduled:',
666 f=lambda b: (get_name(b), 'id=%s' % b['id']))
667 # The last section is just in case buildbucket API changes OR there is a bug.
668 pop(title='Other:',
669 f=lambda b: (get_name(b), 'id=%s' % b['id']))
670 assert len(builds) == 0
qyearsleyeab3c042016-08-24 09:18:28 -0700671 print('Total: %d try jobs' % total)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000672
673
Aiden Bennerc08566e2018-10-03 17:52:42 +0000674def _ComputeDiffLineRanges(files, upstream_commit):
675 """Gets the changed line ranges for each file since upstream_commit.
676
677 Parses a git diff on provided files and returns a dict that maps a file name
678 to an ordered list of range tuples in the form (start_line, count).
679 Ranges are in the same format as a git diff.
680 """
681 # If files is empty then diff_output will be a full diff.
682 if len(files) == 0:
683 return {}
684
Aiden Benner6c18a1a2018-11-23 20:18:23 +0000685 # Take the git diff and find the line ranges where there are changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000686 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, files, allow_prefix=True)
687 diff_output = RunGit(diff_cmd)
688
689 pattern = r'(?:^diff --git a/(?:.*) b/(.*))|(?:^@@.*\+(.*) @@)'
690 # 2 capture groups
691 # 0 == fname of diff file
692 # 1 == 'diff_start,diff_count' or 'diff_start'
693 # will match each of
694 # diff --git a/foo.foo b/foo.py
695 # @@ -12,2 +14,3 @@
696 # @@ -12,2 +17 @@
697 # running re.findall on the above string with pattern will give
698 # [('foo.py', ''), ('', '14,3'), ('', '17')]
699
700 curr_file = None
701 line_diffs = {}
702 for match in re.findall(pattern, diff_output, flags=re.MULTILINE):
703 if match[0] != '':
704 # Will match the second filename in diff --git a/a.py b/b.py.
705 curr_file = match[0]
706 line_diffs[curr_file] = []
707 else:
708 # Matches +14,3
709 if ',' in match[1]:
710 diff_start, diff_count = match[1].split(',')
711 else:
712 # Single line changes are of the form +12 instead of +12,1.
713 diff_start = match[1]
714 diff_count = 1
715
716 diff_start = int(diff_start)
717 diff_count = int(diff_count)
718
719 # If diff_count == 0 this is a removal we can ignore.
720 line_diffs[curr_file].append((diff_start, diff_count))
721
722 return line_diffs
723
724
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000725def _FindYapfConfigFile(fpath, yapf_config_cache, top_dir=None):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000726 """Checks if a yapf file is in any parent directory of fpath until top_dir.
727
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000728 Recursively checks parent directories to find yapf file and if no yapf file
729 is found returns None. Uses yapf_config_cache as a cache for
730 previously found configs.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000731 """
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000732 fpath = os.path.abspath(fpath)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000733 # Return result if we've already computed it.
734 if fpath in yapf_config_cache:
735 return yapf_config_cache[fpath]
736
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000737 parent_dir = os.path.dirname(fpath)
738 if os.path.isfile(fpath):
739 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000740 else:
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000741 # Otherwise fpath is a directory
742 yapf_file = os.path.join(fpath, YAPF_CONFIG_FILENAME)
743 if os.path.isfile(yapf_file):
744 ret = yapf_file
745 elif fpath == top_dir or parent_dir == fpath:
746 # If we're at the top level directory, or if we're at root
747 # there is no provided style.
748 ret = None
749 else:
750 # Otherwise recurse on the current directory.
751 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000752 yapf_config_cache[fpath] = ret
753 return ret
754
755
qyearsley53f48a12016-09-01 10:45:13 -0700756def write_try_results_json(output_file, builds):
757 """Writes a subset of the data from fetch_try_jobs to a file as JSON.
758
759 The input |builds| dict is assumed to be generated by Buildbucket.
760 Buildbucket documentation: http://goo.gl/G0s101
761 """
762
763 def convert_build_dict(build):
Quinten Yearsleya563d722017-12-11 16:36:54 -0800764 """Extracts some of the information from one build dict."""
765 parameters = json.loads(build.get('parameters_json', '{}')) or {}
qyearsley53f48a12016-09-01 10:45:13 -0700766 return {
767 'buildbucket_id': build.get('id'),
qyearsley53f48a12016-09-01 10:45:13 -0700768 'bucket': build.get('bucket'),
Quinten Yearsleya563d722017-12-11 16:36:54 -0800769 'builder_name': parameters.get('builder_name'),
770 'created_ts': build.get('created_ts'),
771 'experimental': build.get('experimental'),
qyearsley53f48a12016-09-01 10:45:13 -0700772 'failure_reason': build.get('failure_reason'),
Quinten Yearsleya563d722017-12-11 16:36:54 -0800773 'result': build.get('result'),
774 'status': build.get('status'),
775 'tags': build.get('tags'),
qyearsley53f48a12016-09-01 10:45:13 -0700776 'url': build.get('url'),
777 }
778
779 converted = []
780 for _, build in sorted(builds.items()):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000781 converted.append(convert_build_dict(build))
qyearsley53f48a12016-09-01 10:45:13 -0700782 write_json(output_file, converted)
783
784
Aaron Gable13101a62018-02-09 13:20:41 -0800785def print_stats(args):
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000786 """Prints statistics about the change to the user."""
787 # --no-ext-diff is broken in some versions of Git, so try to work around
788 # this by overriding the environment (but there is still a problem if the
789 # git config key "diff.external" is used).
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000790 env = GetNoGitPagerEnv()
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000791 if 'GIT_EXTERNAL_DIFF' in env:
792 del env['GIT_EXTERNAL_DIFF']
iannucci@chromium.org79540052012-10-19 23:15:26 +0000793
szager@chromium.orgd057f9a2014-05-29 21:09:36 +0000794 try:
795 stdout = sys.stdout.fileno()
796 except AttributeError:
797 stdout = None
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000798 return subprocess2.call(
Aaron Gable13101a62018-02-09 13:20:41 -0800799 ['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] + args,
szager@chromium.orgd057f9a2014-05-29 21:09:36 +0000800 stdout=stdout, env=env)
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000801
802
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000803class BuildbucketResponseException(Exception):
804 pass
805
806
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000807class Settings(object):
808 def __init__(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000809 self.cc = None
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000810 self.root = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000811 self.tree_status_url = None
812 self.viewvc_url = None
813 self.updated = False
ukai@chromium.orge8077812012-02-03 03:41:46 +0000814 self.is_gerrit = None
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000815 self.squash_gerrit_uploads = None
tandrii@chromium.org28253532016-04-14 13:46:56 +0000816 self.gerrit_skip_ensure_authenticated = None
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000817 self.git_editor = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000818
819 def LazyUpdateIfNeeded(self):
820 """Updates the settings from a codereview.settings file, if available."""
821 if not self.updated:
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000822 # The only value that actually changes the behavior is
823 # autoupdate = "false". Everything else means "true".
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +0000824 autoupdate = RunGit(['config', 'rietveld.autoupdate'],
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000825 error_ok=True
826 ).strip().lower()
827
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000828 cr_settings_file = FindCodereviewSettingsFile()
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000829 if autoupdate != 'false' and cr_settings_file:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000830 LoadCodereviewSettingsFromFile(cr_settings_file)
831 self.updated = True
832
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000833 @staticmethod
834 def GetRelativeRoot():
835 return RunGit(['rev-parse', '--show-cdup']).strip()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000836
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000837 def GetRoot(self):
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000838 if self.root is None:
839 self.root = os.path.abspath(self.GetRelativeRoot())
840 return self.root
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000841
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000842 def GetTreeStatusUrl(self, error_ok=False):
843 if not self.tree_status_url:
844 error_message = ('You must configure your tree status URL by running '
845 '"git cl config".')
Edward Lemur61ea3072018-12-01 00:34:36 +0000846 self.tree_status_url = self._GetConfig(
847 'rietveld.tree-status-url', error_ok=error_ok,
848 error_message=error_message)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000849 return self.tree_status_url
850
851 def GetViewVCUrl(self):
852 if not self.viewvc_url:
Edward Lemur61ea3072018-12-01 00:34:36 +0000853 self.viewvc_url = self._GetConfig('rietveld.viewvc-url', error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000854 return self.viewvc_url
855
rmistry@google.com90752582014-01-14 21:04:50 +0000856 def GetBugPrefix(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000857 return self._GetConfig('rietveld.bug-prefix', error_ok=True)
rmistry@google.com78948ed2015-07-08 23:09:57 +0000858
rmistry@google.com5626a922015-02-26 14:03:30 +0000859 def GetRunPostUploadHook(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000860 run_post_upload_hook = self._GetConfig(
861 'rietveld.run-post-upload-hook', error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +0000862 return run_post_upload_hook == "True"
863
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000864 def GetDefaultCCList(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000865 return self._GetConfig('rietveld.cc', error_ok=True)
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000866
ukai@chromium.orge8077812012-02-03 03:41:46 +0000867 def GetIsGerrit(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700868 """Return true if this repo is associated with gerrit code review system."""
ukai@chromium.orge8077812012-02-03 03:41:46 +0000869 if self.is_gerrit is None:
Aaron Gable9b465272017-05-12 10:53:51 -0700870 self.is_gerrit = (
871 self._GetConfig('gerrit.host', error_ok=True).lower() == 'true')
ukai@chromium.orge8077812012-02-03 03:41:46 +0000872 return self.is_gerrit
873
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000874 def GetSquashGerritUploads(self):
875 """Return true if uploads to Gerrit should be squashed by default."""
876 if self.squash_gerrit_uploads is None:
tandriia60502f2016-06-20 02:01:53 -0700877 self.squash_gerrit_uploads = self.GetSquashGerritUploadsOverride()
878 if self.squash_gerrit_uploads is None:
879 # Default is squash now (http://crbug.com/611892#c23).
880 self.squash_gerrit_uploads = not (
881 RunGit(['config', '--bool', 'gerrit.squash-uploads'],
882 error_ok=True).strip() == 'false')
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000883 return self.squash_gerrit_uploads
884
tandriia60502f2016-06-20 02:01:53 -0700885 def GetSquashGerritUploadsOverride(self):
886 """Return True or False if codereview.settings should be overridden.
887
888 Returns None if no override has been defined.
889 """
890 # See also http://crbug.com/611892#c23
891 result = RunGit(['config', '--bool', 'gerrit.override-squash-uploads'],
892 error_ok=True).strip()
893 if result == 'true':
894 return True
895 if result == 'false':
896 return False
897 return None
898
tandrii@chromium.org28253532016-04-14 13:46:56 +0000899 def GetGerritSkipEnsureAuthenticated(self):
900 """Return True if EnsureAuthenticated should not be done for Gerrit
901 uploads."""
902 if self.gerrit_skip_ensure_authenticated is None:
903 self.gerrit_skip_ensure_authenticated = (
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000904 RunGit(['config', '--bool', 'gerrit.skip-ensure-authenticated'],
tandrii@chromium.org28253532016-04-14 13:46:56 +0000905 error_ok=True).strip() == 'true')
906 return self.gerrit_skip_ensure_authenticated
907
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000908 def GetGitEditor(self):
909 """Return the editor specified in the git config, or None if none is."""
910 if self.git_editor is None:
Raul Tambre5a525872019-02-12 19:08:08 +0000911 # Git requires single quotes for paths with spaces. We need to replace
912 # them with double quotes for Windows to treat such paths as a single
913 # path.
914 self.git_editor = self._GetConfig(
915 'core.editor', error_ok=True).replace('\'', '"')
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000916 return self.git_editor or None
917
thestig@chromium.org44202a22014-03-11 19:22:18 +0000918 def GetLintRegex(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000919 return (self._GetConfig('rietveld.cpplint-regex', error_ok=True) or
thestig@chromium.org44202a22014-03-11 19:22:18 +0000920 DEFAULT_LINT_REGEX)
921
922 def GetLintIgnoreRegex(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000923 return (self._GetConfig('rietveld.cpplint-ignore-regex', error_ok=True) or
thestig@chromium.org44202a22014-03-11 19:22:18 +0000924 DEFAULT_LINT_IGNORE_REGEX)
925
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000926 def _GetConfig(self, param, **kwargs):
927 self.LazyUpdateIfNeeded()
928 return RunGit(['config', param], **kwargs).strip()
929
930
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100931@contextlib.contextmanager
932def _get_gerrit_project_config_file(remote_url):
933 """Context manager to fetch and store Gerrit's project.config from
934 refs/meta/config branch and store it in temp file.
935
936 Provides a temporary filename or None if there was error.
937 """
938 error, _ = RunGitWithCode([
939 'fetch', remote_url,
940 '+refs/meta/config:refs/git_cl/meta/config'])
941 if error:
942 # Ref doesn't exist or isn't accessible to current user.
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700943 print('WARNING: Failed to fetch project config for %s: %s' %
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100944 (remote_url, error))
945 yield None
946 return
947
948 error, project_config_data = RunGitWithCode(
949 ['show', 'refs/git_cl/meta/config:project.config'])
950 if error:
951 print('WARNING: project.config file not found')
952 yield None
953 return
954
955 with gclient_utils.temporary_directory() as tempdir:
956 project_config_file = os.path.join(tempdir, 'project.config')
957 gclient_utils.FileWrite(project_config_file, project_config_data)
958 yield project_config_file
959
960
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000961def ShortBranchName(branch):
962 """Convert a name like 'refs/heads/foo' to just 'foo'."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000963 return branch.replace('refs/heads/', '', 1)
964
965
966def GetCurrentBranchRef():
967 """Returns branch ref (e.g., refs/heads/master) or None."""
968 return RunGit(['symbolic-ref', 'HEAD'],
969 stderr=subprocess2.VOID, error_ok=True).strip() or None
970
971
972def GetCurrentBranch():
973 """Returns current branch or None.
974
975 For refs/heads/* branches, returns just last part. For others, full ref.
976 """
977 branchref = GetCurrentBranchRef()
978 if branchref:
979 return ShortBranchName(branchref)
980 return None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000981
982
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000983class _CQState(object):
984 """Enum for states of CL with respect to Commit Queue."""
985 NONE = 'none'
986 DRY_RUN = 'dry_run'
987 COMMIT = 'commit'
988
989 ALL_STATES = [NONE, DRY_RUN, COMMIT]
990
991
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000992class _ParsedIssueNumberArgument(object):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200993 def __init__(self, issue=None, patchset=None, hostname=None, codereview=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000994 self.issue = issue
995 self.patchset = patchset
996 self.hostname = hostname
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000997 assert codereview in (None, 'gerrit', 'rietveld')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200998 self.codereview = codereview
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000999
1000 @property
1001 def valid(self):
1002 return self.issue is not None
1003
1004
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001005def ParseIssueNumberArgument(arg, codereview=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001006 """Parses the issue argument and returns _ParsedIssueNumberArgument."""
1007 fail_result = _ParsedIssueNumberArgument()
1008
1009 if arg.isdigit():
Aaron Gableaee6c852017-06-26 12:49:01 -07001010 return _ParsedIssueNumberArgument(issue=int(arg), codereview=codereview)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001011 if not arg.startswith('http'):
1012 return fail_result
Aaron Gableaee6c852017-06-26 12:49:01 -07001013
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001014 url = gclient_utils.UpgradeToHttps(arg)
1015 try:
1016 parsed_url = urlparse.urlparse(url)
1017 except ValueError:
1018 return fail_result
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02001019
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001020 if codereview is not None:
1021 parsed = _CODEREVIEW_IMPLEMENTATIONS[codereview].ParseIssueURL(parsed_url)
1022 return parsed or fail_result
1023
Andrii Shyshkalov0a264d82018-11-21 00:36:16 +00001024 return _GerritChangelistImpl.ParseIssueURL(parsed_url) or fail_result
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001025
1026
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00001027def _create_description_from_log(args):
1028 """Pulls out the commit log to use as a base for the CL description."""
1029 log_args = []
1030 if len(args) == 1 and not args[0].endswith('.'):
1031 log_args = [args[0] + '..']
1032 elif len(args) == 1 and args[0].endswith('...'):
1033 log_args = [args[0][:-1]]
1034 elif len(args) == 2:
1035 log_args = [args[0] + '..' + args[1]]
1036 else:
1037 log_args = args[:] # Hope for the best!
1038 return RunGit(['log', '--pretty=format:%s\n\n%b'] + log_args)
1039
1040
Aaron Gablea45ee112016-11-22 15:14:38 -08001041class GerritChangeNotExists(Exception):
tandriic2405f52016-10-10 08:13:15 -07001042 def __init__(self, issue, url):
1043 self.issue = issue
1044 self.url = url
Aaron Gablea45ee112016-11-22 15:14:38 -08001045 super(GerritChangeNotExists, self).__init__()
tandriic2405f52016-10-10 08:13:15 -07001046
1047 def __str__(self):
Aaron Gablea45ee112016-11-22 15:14:38 -08001048 return 'change %s at %s does not exist or you have no access to it' % (
tandriic2405f52016-10-10 08:13:15 -07001049 self.issue, self.url)
1050
1051
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001052_CommentSummary = collections.namedtuple(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001053 '_CommentSummary', ['date', 'message', 'sender', 'autogenerated',
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001054 # TODO(tandrii): these two aren't known in Gerrit.
1055 'approval', 'disapproval'])
1056
1057
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001058class Changelist(object):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001059 """Changelist works with one changelist in local branch.
1060
1061 Supports two codereview backends: Rietveld or Gerrit, selected at object
1062 creation.
1063
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00001064 Notes:
1065 * Not safe for concurrent multi-{thread,process} use.
1066 * Caches values from current branch. Therefore, re-use after branch change
tandrii5d48c322016-08-18 16:19:37 -07001067 with great care.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001068 """
1069
1070 def __init__(self, branchref=None, issue=None, codereview=None, **kwargs):
1071 """Create a new ChangeList instance.
1072
1073 If issue is given, the codereview must be given too.
1074
1075 If `codereview` is given, it must be 'rietveld' or 'gerrit'.
1076 Otherwise, it's decided based on current configuration of the local branch,
1077 with default being 'rietveld' for backwards compatibility.
1078 See _load_codereview_impl for more details.
1079
1080 **kwargs will be passed directly to codereview implementation.
1081 """
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001082 # Poke settings so we get the "configure your server" message if necessary.
maruel@chromium.org379d07a2011-11-30 14:58:10 +00001083 global settings
1084 if not settings:
1085 # Happens when git_cl.py is used as a utility library.
1086 settings = Settings()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001087
1088 if issue:
1089 assert codereview, 'codereview must be known, if issue is known'
1090
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001091 self.branchref = branchref
1092 if self.branchref:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00001093 assert branchref.startswith('refs/heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001094 self.branch = ShortBranchName(self.branchref)
1095 else:
1096 self.branch = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001097 self.upstream_branch = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001098 self.lookedup_issue = False
1099 self.issue = issue or None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001100 self.has_description = False
1101 self.description = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001102 self.lookedup_patchset = False
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001103 self.patchset = None
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001104 self.cc = None
Daniel Cheng7227d212017-11-17 08:12:37 -08001105 self.more_cc = []
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001106 self._remote = None
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001107 self._cached_remote_url = (False, None) # (is_cached, value)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001108
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001109 self._codereview_impl = None
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001110 self._codereview = None
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001111 self._load_codereview_impl(codereview, **kwargs)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001112 assert self._codereview_impl
1113 assert self._codereview in _CODEREVIEW_IMPLEMENTATIONS
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001114
1115 def _load_codereview_impl(self, codereview=None, **kwargs):
1116 if codereview:
Joe Masond87b0962018-12-03 21:04:46 +00001117 assert codereview in _CODEREVIEW_IMPLEMENTATIONS, (
1118 'codereview {} not in {}'.format(codereview,
1119 _CODEREVIEW_IMPLEMENTATIONS))
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001120 cls = _CODEREVIEW_IMPLEMENTATIONS[codereview]
1121 self._codereview = codereview
1122 self._codereview_impl = cls(self, **kwargs)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001123 return
1124
1125 # Automatic selection based on issue number set for a current branch.
1126 # Rietveld takes precedence over Gerrit.
1127 assert not self.issue
1128 # Whether we find issue or not, we are doing the lookup.
1129 self.lookedup_issue = True
tandrii5d48c322016-08-18 16:19:37 -07001130 if self.GetBranch():
1131 for codereview, cls in _CODEREVIEW_IMPLEMENTATIONS.iteritems():
1132 issue = _git_get_branch_config_value(
1133 cls.IssueConfigKey(), value_type=int, branch=self.GetBranch())
1134 if issue:
1135 self._codereview = codereview
1136 self._codereview_impl = cls(self, **kwargs)
1137 self.issue = int(issue)
1138 return
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001139
Bryce Thomascfc97122018-12-13 20:21:47 +00001140 # No issue is set for this branch, so default to gerrit.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001141 return self._load_codereview_impl(
Bryce Thomascfc97122018-12-13 20:21:47 +00001142 codereview='gerrit',
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001143 **kwargs)
1144
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001145 def IsGerrit(self):
1146 return self._codereview == 'gerrit'
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001147
1148 def GetCCList(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001149 """Returns the users cc'd on this CL.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001150
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001151 The return value is a string suitable for passing to git cl with the --cc
1152 flag.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001153 """
1154 if self.cc is None:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001155 base_cc = settings.GetDefaultCCList()
Daniel Cheng7227d212017-11-17 08:12:37 -08001156 more_cc = ','.join(self.more_cc)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001157 self.cc = ','.join(filter(None, (base_cc, more_cc))) or ''
1158 return self.cc
1159
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001160 def GetCCListWithoutDefault(self):
1161 """Return the users cc'd on this CL excluding default ones."""
1162 if self.cc is None:
Daniel Cheng7227d212017-11-17 08:12:37 -08001163 self.cc = ','.join(self.more_cc)
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001164 return self.cc
1165
Daniel Cheng7227d212017-11-17 08:12:37 -08001166 def ExtendCC(self, more_cc):
1167 """Extends the list of users to cc on this CL based on the changed files."""
1168 self.more_cc.extend(more_cc)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001169
1170 def GetBranch(self):
1171 """Returns the short branch name, e.g. 'master'."""
1172 if not self.branch:
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001173 branchref = GetCurrentBranchRef()
szager@chromium.orgd62c61f2014-10-20 22:33:21 +00001174 if not branchref:
1175 return None
1176 self.branchref = branchref
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001177 self.branch = ShortBranchName(self.branchref)
1178 return self.branch
1179
1180 def GetBranchRef(self):
1181 """Returns the full branch name, e.g. 'refs/heads/master'."""
1182 self.GetBranch() # Poke the lazy loader.
1183 return self.branchref
1184
tandrii@chromium.org534f67a2016-04-07 18:47:05 +00001185 def ClearBranch(self):
1186 """Clears cached branch data of this object."""
1187 self.branch = self.branchref = None
1188
tandrii5d48c322016-08-18 16:19:37 -07001189 def _GitGetBranchConfigValue(self, key, default=None, **kwargs):
1190 assert 'branch' not in kwargs, 'this CL branch is used automatically'
1191 kwargs['branch'] = self.GetBranch()
1192 return _git_get_branch_config_value(key, default, **kwargs)
1193
1194 def _GitSetBranchConfigValue(self, key, value, **kwargs):
1195 assert 'branch' not in kwargs, 'this CL branch is used automatically'
1196 assert self.GetBranch(), (
1197 'this CL must have an associated branch to %sset %s%s' %
1198 ('un' if value is None else '',
1199 key,
1200 '' if value is None else ' to %r' % value))
1201 kwargs['branch'] = self.GetBranch()
1202 return _git_set_branch_config_value(key, value, **kwargs)
1203
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001204 @staticmethod
1205 def FetchUpstreamTuple(branch):
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001206 """Returns a tuple containing remote and remote ref,
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001207 e.g. 'origin', 'refs/heads/master'
1208 """
1209 remote = '.'
tandrii5d48c322016-08-18 16:19:37 -07001210 upstream_branch = _git_get_branch_config_value('merge', branch=branch)
1211
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001212 if upstream_branch:
tandrii5d48c322016-08-18 16:19:37 -07001213 remote = _git_get_branch_config_value('remote', branch=branch)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001214 else:
bauerb@chromium.orgade368c2011-03-01 08:57:50 +00001215 upstream_branch = RunGit(['config', 'rietveld.upstream-branch'],
1216 error_ok=True).strip()
1217 if upstream_branch:
1218 remote = RunGit(['config', 'rietveld.upstream-remote']).strip()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001219 else:
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001220 # Else, try to guess the origin remote.
1221 remote_branches = RunGit(['branch', '-r']).split()
1222 if 'origin/master' in remote_branches:
1223 # Fall back on origin/master if it exits.
1224 remote = 'origin'
1225 upstream_branch = 'refs/heads/master'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001226 else:
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001227 DieWithError(
1228 'Unable to determine default branch to diff against.\n'
1229 'Either pass complete "git diff"-style arguments, like\n'
1230 ' git cl upload origin/master\n'
1231 'or verify this branch is set up to track another \n'
1232 '(via the --track argument to "git checkout -b ...").')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001233
1234 return remote, upstream_branch
1235
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001236 def GetCommonAncestorWithUpstream(self):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001237 upstream_branch = self.GetUpstreamBranch()
1238 if not BranchExists(upstream_branch):
1239 DieWithError('The upstream for the current branch (%s) does not exist '
1240 'anymore.\nPlease fix it and try again.' % self.GetBranch())
iannucci@chromium.org9e849272014-04-04 00:31:55 +00001241 return git_common.get_or_create_merge_base(self.GetBranch(),
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001242 upstream_branch)
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001243
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001244 def GetUpstreamBranch(self):
1245 if self.upstream_branch is None:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001246 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001247 if remote is not '.':
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001248 upstream_branch = upstream_branch.replace('refs/heads/',
1249 'refs/remotes/%s/' % remote)
1250 upstream_branch = upstream_branch.replace('refs/branch-heads/',
1251 'refs/remotes/branch-heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001252 self.upstream_branch = upstream_branch
1253 return self.upstream_branch
1254
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001255 def GetRemoteBranch(self):
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001256 if not self._remote:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001257 remote, branch = None, self.GetBranch()
1258 seen_branches = set()
1259 while branch not in seen_branches:
1260 seen_branches.add(branch)
1261 remote, branch = self.FetchUpstreamTuple(branch)
1262 branch = ShortBranchName(branch)
1263 if remote != '.' or branch.startswith('refs/remotes'):
1264 break
1265 else:
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001266 remotes = RunGit(['remote'], error_ok=True).split()
1267 if len(remotes) == 1:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001268 remote, = remotes
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001269 elif 'origin' in remotes:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001270 remote = 'origin'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001271 logging.warn('Could not determine which remote this change is '
1272 'associated with, so defaulting to "%s".' % self._remote)
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001273 else:
1274 logging.warn('Could not determine which remote this change is '
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001275 'associated with.')
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001276 branch = 'HEAD'
1277 if branch.startswith('refs/remotes'):
1278 self._remote = (remote, branch)
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001279 elif branch.startswith('refs/branch-heads/'):
1280 self._remote = (remote, branch.replace('refs/', 'refs/remotes/'))
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001281 else:
1282 self._remote = (remote, 'refs/remotes/%s/%s' % (remote, branch))
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001283 return self._remote
1284
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001285 def GitSanityChecks(self, upstream_git_obj):
1286 """Checks git repo status and ensures diff is from local commits."""
1287
sbc@chromium.org79706062015-01-14 21:18:12 +00001288 if upstream_git_obj is None:
1289 if self.GetBranch() is None:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001290 print('ERROR: Unable to determine current branch (detached HEAD?)',
vapiera7fbd5a2016-06-16 09:17:49 -07001291 file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001292 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001293 print('ERROR: No upstream branch.', file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001294 return False
1295
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001296 # Verify the commit we're diffing against is in our current branch.
1297 upstream_sha = RunGit(['rev-parse', '--verify', upstream_git_obj]).strip()
1298 common_ancestor = RunGit(['merge-base', upstream_sha, 'HEAD']).strip()
1299 if upstream_sha != common_ancestor:
vapiera7fbd5a2016-06-16 09:17:49 -07001300 print('ERROR: %s is not in the current branch. You may need to rebase '
1301 'your tracking branch' % upstream_sha, file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001302 return False
1303
1304 # List the commits inside the diff, and verify they are all local.
1305 commits_in_diff = RunGit(
1306 ['rev-list', '^%s' % upstream_sha, 'HEAD']).splitlines()
1307 code, remote_branch = RunGitWithCode(['config', 'gitcl.remotebranch'])
1308 remote_branch = remote_branch.strip()
1309 if code != 0:
1310 _, remote_branch = self.GetRemoteBranch()
1311
1312 commits_in_remote = RunGit(
1313 ['rev-list', '^%s' % upstream_sha, remote_branch]).splitlines()
1314
1315 common_commits = set(commits_in_diff) & set(commits_in_remote)
1316 if common_commits:
vapiera7fbd5a2016-06-16 09:17:49 -07001317 print('ERROR: Your diff contains %d commits already in %s.\n'
1318 'Run "git log --oneline %s..HEAD" to get a list of commits in '
1319 'the diff. If you are using a custom git flow, you can override'
1320 ' the reference used for this check with "git config '
1321 'gitcl.remotebranch <git-ref>".' % (
1322 len(common_commits), remote_branch, upstream_git_obj),
1323 file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001324 return False
1325 return True
1326
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001327 def GetGitBaseUrlFromConfig(self):
sheyang@chromium.orga656e702014-05-15 20:43:05 +00001328 """Return the configured base URL from branch.<branchname>.baseurl.
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001329
1330 Returns None if it is not set.
1331 """
tandrii5d48c322016-08-18 16:19:37 -07001332 return self._GitGetBranchConfigValue('base-url')
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001333
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001334 def GetRemoteUrl(self):
1335 """Return the configured remote URL, e.g. 'git://example.org/foo.git/'.
1336
1337 Returns None if there is no remote.
1338 """
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001339 is_cached, value = self._cached_remote_url
1340 if is_cached:
1341 return value
1342
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001343 remote, _ = self.GetRemoteBranch()
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001344 url = RunGit(['config', 'remote.%s.url' % remote], error_ok=True).strip()
1345
Edward Lemur298f2cf2019-02-22 21:40:39 +00001346 # Check if the remote url can be parsed as an URL.
1347 host = urlparse.urlparse(url).netloc
1348 if host:
1349 self._cached_remote_url = (True, url)
1350 return url
1351
1352 # If it cannot be parsed as an url, assume it is a local directory, probably
1353 # a git cache.
1354 logging.warning('"%s" doesn\'t appear to point to a git host. '
1355 'Interpreting it as a local directory.', url)
1356 if not os.path.isdir(url):
1357 logging.error(
1358 'Remote "%s" for branch "%s" points to "%s", but it doesn\'t exist.',
1359 remote, url, self.GetBranch())
1360 return None
1361
1362 cache_path = url
1363 url = RunGit(['config', 'remote.%s.url' % remote],
1364 error_ok=True,
1365 cwd=url).strip()
1366
1367 host = urlparse.urlparse(url).netloc
1368 if not host:
1369 logging.error(
1370 'Remote "%(remote)s" for branch "%(branch)s" points to '
1371 '"%(cache_path)s", but it is misconfigured.\n'
1372 '"%(cache_path)s" must be a git repo and must have a remote named '
1373 '"%(remote)s" pointing to the git host.', {
1374 'remote': remote,
1375 'cache_path': cache_path,
1376 'branch': self.GetBranch()})
1377 return None
1378
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001379 self._cached_remote_url = (True, url)
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001380 return url
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001381
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001382 def GetIssue(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001383 """Returns the issue number as a int or None if not set."""
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001384 if self.issue is None and not self.lookedup_issue:
tandrii5d48c322016-08-18 16:19:37 -07001385 self.issue = self._GitGetBranchConfigValue(
1386 self._codereview_impl.IssueConfigKey(), value_type=int)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001387 self.lookedup_issue = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001388 return self.issue
1389
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001390 def GetIssueURL(self):
1391 """Get the URL for a particular issue."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001392 issue = self.GetIssue()
1393 if not issue:
dbeam@chromium.org015fd3d2013-06-18 19:02:50 +00001394 return None
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001395 return '%s/%s' % (self._codereview_impl.GetCodereviewServer(), issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001396
Andrii Shyshkalov31863012017-02-08 11:35:12 +01001397 def GetDescription(self, pretty=False, force=False):
1398 if not self.has_description or force:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001399 if self.GetIssue():
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001400 self.description = self._codereview_impl.FetchDescription(force=force)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001401 self.has_description = True
1402 if pretty:
Asanka Herath7c61dcb2016-12-14 13:01:58 -05001403 # Set width to 72 columns + 2 space indent.
1404 wrapper = textwrap.TextWrapper(width=74, replace_whitespace=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001405 wrapper.initial_indent = wrapper.subsequent_indent = ' '
Asanka Herath7c61dcb2016-12-14 13:01:58 -05001406 lines = self.description.splitlines()
1407 return '\n'.join([wrapper.fill(line) for line in lines])
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001408 return self.description
1409
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001410 def GetDescriptionFooters(self):
1411 """Returns (non_footer_lines, footers) for the commit message.
1412
1413 Returns:
1414 non_footer_lines (list(str)) - Simple list of description lines without
1415 any footer. The lines do not contain newlines, nor does the list contain
1416 the empty line between the message and the footers.
1417 footers (list(tuple(KEY, VALUE))) - List of parsed footers, e.g.
1418 [("Change-Id", "Ideadbeef...."), ...]
1419 """
1420 raw_description = self.GetDescription()
1421 msg_lines, _, footers = git_footers.split_footers(raw_description)
1422 if footers:
1423 msg_lines = msg_lines[:len(msg_lines)-1]
1424 return msg_lines, footers
1425
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001426 def GetPatchset(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001427 """Returns the patchset number as a int or None if not set."""
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001428 if self.patchset is None and not self.lookedup_patchset:
tandrii5d48c322016-08-18 16:19:37 -07001429 self.patchset = self._GitGetBranchConfigValue(
1430 self._codereview_impl.PatchsetConfigKey(), value_type=int)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001431 self.lookedup_patchset = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001432 return self.patchset
1433
1434 def SetPatchset(self, patchset):
tandrii5d48c322016-08-18 16:19:37 -07001435 """Set this branch's patchset. If patchset=0, clears the patchset."""
1436 assert self.GetBranch()
1437 if not patchset:
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001438 self.patchset = None
tandrii5d48c322016-08-18 16:19:37 -07001439 else:
1440 self.patchset = int(patchset)
1441 self._GitSetBranchConfigValue(
1442 self._codereview_impl.PatchsetConfigKey(), self.patchset)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001443
tandrii@chromium.orga342c922016-03-16 07:08:25 +00001444 def SetIssue(self, issue=None):
tandrii5d48c322016-08-18 16:19:37 -07001445 """Set this branch's issue. If issue isn't given, clears the issue."""
1446 assert self.GetBranch()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001447 if issue:
tandrii5d48c322016-08-18 16:19:37 -07001448 issue = int(issue)
1449 self._GitSetBranchConfigValue(
1450 self._codereview_impl.IssueConfigKey(), issue)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001451 self.issue = issue
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001452 codereview_server = self._codereview_impl.GetCodereviewServer()
1453 if codereview_server:
tandrii5d48c322016-08-18 16:19:37 -07001454 self._GitSetBranchConfigValue(
1455 self._codereview_impl.CodereviewServerConfigKey(),
1456 codereview_server)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001457 else:
tandrii5d48c322016-08-18 16:19:37 -07001458 # Reset all of these just to be clean.
1459 reset_suffixes = [
1460 'last-upload-hash',
1461 self._codereview_impl.IssueConfigKey(),
1462 self._codereview_impl.PatchsetConfigKey(),
1463 self._codereview_impl.CodereviewServerConfigKey(),
1464 ] + self._PostUnsetIssueProperties()
1465 for prop in reset_suffixes:
1466 self._GitSetBranchConfigValue(prop, None, error_ok=True)
Aaron Gableca01e2c2017-07-19 11:16:02 -07001467 msg = RunGit(['log', '-1', '--format=%B']).strip()
1468 if msg and git_footers.get_footer_change_id(msg):
1469 print('WARNING: The change patched into this branch has a Change-Id. '
1470 'Removing it.')
1471 RunGit(['commit', '--amend', '-m',
1472 git_footers.remove_footer(msg, 'Change-Id')])
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001473 self.issue = None
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001474 self.patchset = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001475
dnjba1b0f32016-09-02 12:37:42 -07001476 def GetChange(self, upstream_branch, author, local_description=False):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001477 if not self.GitSanityChecks(upstream_branch):
1478 DieWithError('\nGit sanity check failure')
1479
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001480 root = settings.GetRelativeRoot()
bratell@opera.comf267b0e2013-05-02 09:11:43 +00001481 if not root:
1482 root = '.'
bauerb@chromium.org512f1ef2011-04-20 15:17:57 +00001483 absroot = os.path.abspath(root)
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001484
1485 # We use the sha1 of HEAD as a name of this change.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001486 name = RunGitWithCode(['rev-parse', 'HEAD'])[1].strip()
bauerb@chromium.org512f1ef2011-04-20 15:17:57 +00001487 # Need to pass a relative path for msysgit.
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001488 try:
maruel@chromium.org80a9ef12011-12-13 20:44:10 +00001489 files = scm.GIT.CaptureStatus([root], '.', upstream_branch)
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001490 except subprocess2.CalledProcessError:
1491 DieWithError(
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001492 ('\nFailed to diff against upstream branch %s\n\n'
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001493 'This branch probably doesn\'t exist anymore. To reset the\n'
1494 'tracking branch, please run\n'
stip7a3dd352016-09-22 17:32:28 -07001495 ' git branch --set-upstream-to origin/master %s\n'
1496 'or replace origin/master with the relevant branch') %
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001497 (upstream_branch, self.GetBranch()))
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001498
maruel@chromium.org52424302012-08-29 15:14:30 +00001499 issue = self.GetIssue()
1500 patchset = self.GetPatchset()
dnjba1b0f32016-09-02 12:37:42 -07001501 if issue and not local_description:
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001502 description = self.GetDescription()
1503 else:
1504 # If the change was never uploaded, use the log messages of all commits
1505 # up to the branch point, as git cl upload will prefill the description
1506 # with these log messages.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001507 args = ['log', '--pretty=format:%s%n%n%b', '%s...' % (upstream_branch)]
1508 description = RunGitWithCode(args)[1].strip()
maruel@chromium.org03b3bdc2011-06-14 13:04:12 +00001509
1510 if not author:
maruel@chromium.org13f623c2011-07-22 16:02:23 +00001511 author = RunGit(['config', 'user.email']).strip() or None
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001512 return presubmit_support.GitChange(
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001513 name,
1514 description,
1515 absroot,
1516 files,
1517 issue,
1518 patchset,
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001519 author,
1520 upstream=upstream_branch)
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001521
dsansomee2d6fd92016-09-08 00:10:47 -07001522 def UpdateDescription(self, description, force=False):
Andrii Shyshkalov83051152017-02-07 23:47:29 +01001523 self._codereview_impl.UpdateDescriptionRemote(description, force=force)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001524 self.description = description
Andrii Shyshkalov83051152017-02-07 23:47:29 +01001525 self.has_description = True
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001526
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001527 def UpdateDescriptionFooters(self, description_lines, footers, force=False):
1528 """Sets the description for this CL remotely.
1529
1530 You can get description_lines and footers with GetDescriptionFooters.
1531
1532 Args:
1533 description_lines (list(str)) - List of CL description lines without
1534 newline characters.
1535 footers (list(tuple(KEY, VALUE))) - List of footers, as returned by
1536 GetDescriptionFooters. Key must conform to the git footers format (i.e.
1537 `List-Of-Tokens`). It will be case-normalized so that each token is
1538 title-cased.
1539 """
1540 new_description = '\n'.join(description_lines)
1541 if footers:
1542 new_description += '\n'
1543 for k, v in footers:
1544 foot = '%s: %s' % (git_footers.normalize_name(k), v)
1545 if not git_footers.FOOTER_PATTERN.match(foot):
1546 raise ValueError('Invalid footer %r' % foot)
1547 new_description += foot + '\n'
1548 self.UpdateDescription(new_description, force)
1549
Edward Lesmes8e282792018-04-03 18:50:29 -04001550 def RunHook(self, committing, may_prompt, verbose, change, parallel):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001551 """Calls sys.exit() if the hook fails; returns a HookResults otherwise."""
1552 try:
1553 return presubmit_support.DoPresubmitChecks(change, committing,
1554 verbose=verbose, output_stream=sys.stdout, input_stream=sys.stdin,
1555 default_presubmit=None, may_prompt=may_prompt,
Edward Lesmes8e282792018-04-03 18:50:29 -04001556 gerrit_obj=self._codereview_impl.GetGerritObjForPresubmit(),
1557 parallel=parallel)
vapierfd77ac72016-06-16 08:33:57 -07001558 except presubmit_support.PresubmitFailure as e:
Aaron Gable5d5f22c2018-02-02 09:12:41 -08001559 DieWithError('%s\nMaybe your depot_tools is out of date?' % e)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001560
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001561 def CMDPatchIssue(self, issue_arg, reject, nocommit, directory):
1562 """Fetches and applies the issue patch from codereview to local branch."""
tandrii@chromium.orgef7c68c2016-04-07 09:39:39 +00001563 if isinstance(issue_arg, (int, long)) or issue_arg.isdigit():
1564 parsed_issue_arg = _ParsedIssueNumberArgument(int(issue_arg))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001565 else:
1566 # Assume url.
1567 parsed_issue_arg = self._codereview_impl.ParseIssueURL(
1568 urlparse.urlparse(issue_arg))
1569 if not parsed_issue_arg or not parsed_issue_arg.valid:
1570 DieWithError('Failed to parse issue argument "%s". '
1571 'Must be an issue number or a valid URL.' % issue_arg)
1572 return self._codereview_impl.CMDPatchWithParsedIssue(
Aaron Gable62619a32017-06-16 08:22:09 -07001573 parsed_issue_arg, reject, nocommit, directory, False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001574
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001575 def CMDUpload(self, options, git_diff_args, orig_args):
1576 """Uploads a change to codereview."""
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00001577 assert self.IsGerrit()
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001578 custom_cl_base = None
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001579 if git_diff_args:
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001580 custom_cl_base = base_branch = git_diff_args[0]
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001581 else:
1582 if self.GetBranch() is None:
1583 DieWithError('Can\'t upload from detached HEAD state. Get on a branch!')
1584
1585 # Default to diffing against common ancestor of upstream branch
1586 base_branch = self.GetCommonAncestorWithUpstream()
1587 git_diff_args = [base_branch, 'HEAD']
1588
Aaron Gablec4c40d12017-05-22 11:49:53 -07001589
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001590 # Fast best-effort checks to abort before running potentially
1591 # expensive hooks if uploading is likely to fail anyway. Passing these
1592 # checks does not guarantee that uploading will not fail.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001593 self._codereview_impl.EnsureAuthenticated(force=options.force)
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001594 self._codereview_impl.EnsureCanUploadPatchset(force=options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001595
1596 # Apply watchlists on upload.
1597 change = self.GetChange(base_branch, None)
1598 watchlist = watchlists.Watchlists(change.RepositoryRoot())
1599 files = [f.LocalPath() for f in change.AffectedFiles()]
1600 if not options.bypass_watchlists:
Daniel Cheng7227d212017-11-17 08:12:37 -08001601 self.ExtendCC(watchlist.GetWatchersForPaths(files))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001602
1603 if not options.bypass_hooks:
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001604 if options.reviewers or options.tbrs or options.add_owners_to:
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001605 # Set the reviewer list now so that presubmit checks can access it.
1606 change_description = ChangeDescription(change.FullDescriptionText())
1607 change_description.update_reviewers(options.reviewers,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001608 options.tbrs,
Robert Iannuccif2708bd2017-04-17 15:49:02 -07001609 options.add_owners_to,
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001610 change)
1611 change.SetDescriptionText(change_description.description)
1612 hook_results = self.RunHook(committing=False,
Edward Lesmes8e282792018-04-03 18:50:29 -04001613 may_prompt=not options.force,
1614 verbose=options.verbose,
1615 change=change, parallel=options.parallel)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001616 if not hook_results.should_continue():
1617 return 1
1618 if not options.reviewers and hook_results.reviewers:
1619 options.reviewers = hook_results.reviewers.split(',')
Daniel Cheng7227d212017-11-17 08:12:37 -08001620 self.ExtendCC(hook_results.more_cc)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001621
Aaron Gable13101a62018-02-09 13:20:41 -08001622 print_stats(git_diff_args)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001623 ret = self.CMDUploadChange(options, git_diff_args, custom_cl_base, change)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001624 if not ret:
tandrii5d48c322016-08-18 16:19:37 -07001625 _git_set_branch_config_value('last-upload-hash',
1626 RunGit(['rev-parse', 'HEAD']).strip())
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001627 # Run post upload hooks, if specified.
1628 if settings.GetRunPostUploadHook():
1629 presubmit_support.DoPostUploadExecuter(
1630 change,
1631 self,
1632 settings.GetRoot(),
1633 options.verbose,
1634 sys.stdout)
1635
1636 # Upload all dependencies if specified.
1637 if options.dependencies:
vapiera7fbd5a2016-06-16 09:17:49 -07001638 print()
1639 print('--dependencies has been specified.')
1640 print('All dependent local branches will be re-uploaded.')
1641 print()
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001642 # Remove the dependencies flag from args so that we do not end up in a
1643 # loop.
1644 orig_args.remove('--dependencies')
1645 ret = upload_branch_deps(self, orig_args)
1646 return ret
1647
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001648 def SetCQState(self, new_state):
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001649 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001650
1651 Issue must have been already uploaded and known.
1652 """
1653 assert new_state in _CQState.ALL_STATES
1654 assert self.GetIssue()
qyearsley1fdfcb62016-10-24 13:22:03 -07001655 try:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001656 self._codereview_impl.SetCQState(new_state)
qyearsley1fdfcb62016-10-24 13:22:03 -07001657 return 0
1658 except KeyboardInterrupt:
1659 raise
1660 except:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001661 print('WARNING: Failed to %s.\n'
qyearsley1fdfcb62016-10-24 13:22:03 -07001662 'Either:\n'
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001663 ' * Your project has no CQ,\n'
1664 ' * You don\'t have permission to change the CQ state,\n'
1665 ' * There\'s a bug in this code (see stack trace below).\n'
1666 'Consider specifying which bots to trigger manually or asking your '
1667 'project owners for permissions or contacting Chrome Infra at:\n'
1668 'https://www.chromium.org/infra\n\n' %
1669 ('cancel CQ' if new_state == _CQState.NONE else 'trigger CQ'))
qyearsley1fdfcb62016-10-24 13:22:03 -07001670 # Still raise exception so that stack trace is printed.
1671 raise
1672
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001673 # Forward methods to codereview specific implementation.
1674
Aaron Gable636b13f2017-07-14 10:42:48 -07001675 def AddComment(self, message, publish=None):
1676 return self._codereview_impl.AddComment(message, publish=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001677
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001678 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001679 """Returns list of _CommentSummary for each comment.
1680
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001681 args:
1682 readable: determines whether the output is designed for a human or a machine
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001683 """
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001684 return self._codereview_impl.GetCommentsSummary(readable)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001685
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001686 def CloseIssue(self):
1687 return self._codereview_impl.CloseIssue()
1688
1689 def GetStatus(self):
1690 return self._codereview_impl.GetStatus()
1691
1692 def GetCodereviewServer(self):
1693 return self._codereview_impl.GetCodereviewServer()
1694
tandriide281ae2016-10-12 06:02:30 -07001695 def GetIssueOwner(self):
1696 """Get owner from codereview, which may differ from this checkout."""
1697 return self._codereview_impl.GetIssueOwner()
1698
Edward Lemur707d70b2018-02-07 00:50:14 +01001699 def GetReviewers(self):
1700 return self._codereview_impl.GetReviewers()
1701
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001702 def GetMostRecentPatchset(self):
1703 return self._codereview_impl.GetMostRecentPatchset()
1704
tandriide281ae2016-10-12 06:02:30 -07001705 def CannotTriggerTryJobReason(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001706 """Returns reason (str) if unable trigger try jobs on this CL or None."""
tandriide281ae2016-10-12 06:02:30 -07001707 return self._codereview_impl.CannotTriggerTryJobReason()
1708
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001709 def GetTryJobProperties(self, patchset=None):
1710 """Returns dictionary of properties to launch try job."""
1711 return self._codereview_impl.GetTryJobProperties(patchset=patchset)
tandrii8c5a3532016-11-04 07:52:02 -07001712
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001713 def __getattr__(self, attr):
1714 # This is because lots of untested code accesses Rietveld-specific stuff
1715 # directly, and it's hard to fix for sure. So, just let it work, and fix
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00001716 # on a case by case basis.
tandrii4d895502016-08-18 08:26:19 -07001717 # Note that child method defines __getattr__ as well, and forwards it here,
1718 # because _RietveldChangelistImpl is not cleaned up yet, and given
1719 # deprecation of Rietveld, it should probably be just removed.
1720 # Until that time, avoid infinite recursion by bypassing __getattr__
1721 # of implementation class.
1722 return self._codereview_impl.__getattribute__(attr)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001723
1724
1725class _ChangelistCodereviewBase(object):
1726 """Abstract base class encapsulating codereview specifics of a changelist."""
1727 def __init__(self, changelist):
1728 self._changelist = changelist # instance of Changelist
1729
1730 def __getattr__(self, attr):
1731 # Forward methods to changelist.
1732 # TODO(tandrii): maybe clean up _GerritChangelistImpl and
1733 # _RietveldChangelistImpl to avoid this hack?
1734 return getattr(self._changelist, attr)
1735
1736 def GetStatus(self):
1737 """Apply a rough heuristic to give a simple summary of an issue's review
1738 or CQ status, assuming adherence to a common workflow.
1739
1740 Returns None if no issue for this branch, or specific string keywords.
1741 """
1742 raise NotImplementedError()
1743
1744 def GetCodereviewServer(self):
1745 """Returns server URL without end slash, like "https://codereview.com"."""
1746 raise NotImplementedError()
1747
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001748 def FetchDescription(self, force=False):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001749 """Fetches and returns description from the codereview server."""
1750 raise NotImplementedError()
1751
tandrii5d48c322016-08-18 16:19:37 -07001752 @classmethod
1753 def IssueConfigKey(cls):
1754 """Returns branch setting storing issue number."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001755 raise NotImplementedError()
1756
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001757 @classmethod
tandrii5d48c322016-08-18 16:19:37 -07001758 def PatchsetConfigKey(cls):
1759 """Returns branch setting storing patchset number."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001760 raise NotImplementedError()
1761
tandrii5d48c322016-08-18 16:19:37 -07001762 @classmethod
1763 def CodereviewServerConfigKey(cls):
1764 """Returns branch setting storing codereview server."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001765 raise NotImplementedError()
1766
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001767 def _PostUnsetIssueProperties(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001768 """Which branch-specific properties to erase when unsetting issue."""
tandrii5d48c322016-08-18 16:19:37 -07001769 return []
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001770
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001771 def GetGerritObjForPresubmit(self):
1772 # None is valid return value, otherwise presubmit_support.GerritAccessor.
1773 return None
1774
dsansomee2d6fd92016-09-08 00:10:47 -07001775 def UpdateDescriptionRemote(self, description, force=False):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001776 """Update the description on codereview site."""
1777 raise NotImplementedError()
1778
Aaron Gable636b13f2017-07-14 10:42:48 -07001779 def AddComment(self, message, publish=None):
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001780 """Posts a comment to the codereview site."""
1781 raise NotImplementedError()
1782
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001783 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001784 raise NotImplementedError()
1785
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001786 def CloseIssue(self):
1787 """Closes the issue."""
1788 raise NotImplementedError()
1789
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001790 def GetMostRecentPatchset(self):
1791 """Returns the most recent patchset number from the codereview site."""
1792 raise NotImplementedError()
1793
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001794 def CMDPatchWithParsedIssue(self, parsed_issue_arg, reject, nocommit,
Aaron Gable62619a32017-06-16 08:22:09 -07001795 directory, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001796 """Fetches and applies the issue.
1797
1798 Arguments:
1799 parsed_issue_arg: instance of _ParsedIssueNumberArgument.
1800 reject: if True, reject the failed patch instead of switching to 3-way
1801 merge. Rietveld only.
1802 nocommit: do not commit the patch, thus leave the tree dirty. Rietveld
1803 only.
1804 directory: switch to directory before applying the patch. Rietveld only.
Aaron Gable62619a32017-06-16 08:22:09 -07001805 force: if true, overwrites existing local state.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001806 """
1807 raise NotImplementedError()
1808
1809 @staticmethod
1810 def ParseIssueURL(parsed_url):
1811 """Parses url and returns instance of _ParsedIssueNumberArgument or None if
1812 failed."""
1813 raise NotImplementedError()
1814
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001815 def EnsureAuthenticated(self, force, refresh=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001816 """Best effort check that user is authenticated with codereview server.
1817
1818 Arguments:
1819 force: whether to skip confirmation questions.
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001820 refresh: whether to attempt to refresh credentials. Ignored if not
1821 applicable.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001822 """
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001823 raise NotImplementedError()
1824
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001825 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001826 """Best effort check that uploading isn't supposed to fail for predictable
1827 reasons.
1828
1829 This method should raise informative exception if uploading shouldn't
1830 proceed.
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001831
1832 Arguments:
1833 force: whether to skip confirmation questions.
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001834 """
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001835 raise NotImplementedError()
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001836
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001837 def CMDUploadChange(self, options, git_diff_args, custom_cl_base, change):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00001838 """Uploads a change to codereview."""
1839 raise NotImplementedError()
1840
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001841 def SetCQState(self, new_state):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001842 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001843
1844 Issue must have been already uploaded and known.
1845 """
1846 raise NotImplementedError()
1847
tandriie113dfd2016-10-11 10:20:12 -07001848 def CannotTriggerTryJobReason(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001849 """Returns reason (str) if unable trigger try jobs on this CL or None."""
tandriie113dfd2016-10-11 10:20:12 -07001850 raise NotImplementedError()
1851
tandriide281ae2016-10-12 06:02:30 -07001852 def GetIssueOwner(self):
1853 raise NotImplementedError()
1854
Edward Lemur707d70b2018-02-07 00:50:14 +01001855 def GetReviewers(self):
1856 raise NotImplementedError()
1857
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001858 def GetTryJobProperties(self, patchset=None):
tandriide281ae2016-10-12 06:02:30 -07001859 raise NotImplementedError()
1860
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001861
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001862class _GerritChangelistImpl(_ChangelistCodereviewBase):
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001863 def __init__(self, changelist, auth_config=None, codereview_host=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001864 # auth_config is Rietveld thing, kept here to preserve interface only.
1865 super(_GerritChangelistImpl, self).__init__(changelist)
1866 self._change_id = None
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001867 # Lazily cached values.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001868 self._gerrit_host = None # e.g. chromium-review.googlesource.com
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001869 self._gerrit_server = None # e.g. https://chromium-review.googlesource.com
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001870 # Map from change number (issue) to its detail cache.
1871 self._detail_cache = {}
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001872
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001873 if codereview_host is not None:
1874 assert not codereview_host.startswith('https://'), codereview_host
1875 self._gerrit_host = codereview_host
1876 self._gerrit_server = 'https://%s' % codereview_host
1877
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001878 def _GetGerritHost(self):
1879 # Lazy load of configs.
1880 self.GetCodereviewServer()
tandriie32e3ea2016-06-22 02:52:48 -07001881 if self._gerrit_host and '.' not in self._gerrit_host:
1882 # Abbreviated domain like "chromium" instead of chromium.googlesource.com.
1883 # This happens for internal stuff http://crbug.com/614312.
1884 parsed = urlparse.urlparse(self.GetRemoteUrl())
1885 if parsed.scheme == 'sso':
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001886 print('WARNING: using non-https URLs for remote is likely broken\n'
tandriie32e3ea2016-06-22 02:52:48 -07001887 ' Your current remote is: %s' % self.GetRemoteUrl())
1888 self._gerrit_host = '%s.googlesource.com' % self._gerrit_host
1889 self._gerrit_server = 'https://%s' % self._gerrit_host
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001890 return self._gerrit_host
1891
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001892 def _GetGitHost(self):
1893 """Returns git host to be used when uploading change to Gerrit."""
Edward Lemur298f2cf2019-02-22 21:40:39 +00001894 remote_url = self.GetRemoteUrl()
1895 if not remote_url:
1896 return None
1897 return urlparse.urlparse(remote_url).netloc
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001898
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001899 def GetCodereviewServer(self):
1900 if not self._gerrit_server:
1901 # If we're on a branch then get the server potentially associated
1902 # with that branch.
1903 if self.GetIssue():
tandrii5d48c322016-08-18 16:19:37 -07001904 self._gerrit_server = self._GitGetBranchConfigValue(
1905 self.CodereviewServerConfigKey())
1906 if self._gerrit_server:
1907 self._gerrit_host = urlparse.urlparse(self._gerrit_server).netloc
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001908 if not self._gerrit_server:
1909 # We assume repo to be hosted on Gerrit, and hence Gerrit server
1910 # has "-review" suffix for lowest level subdomain.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001911 parts = self._GetGitHost().split('.')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001912 parts[0] = parts[0] + '-review'
1913 self._gerrit_host = '.'.join(parts)
1914 self._gerrit_server = 'https://%s' % self._gerrit_host
1915 return self._gerrit_server
1916
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001917 def _GetGerritProject(self):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001918 """Returns Gerrit project name based on remote git URL."""
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001919 remote_url = self.GetRemoteUrl()
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001920 if remote_url is None:
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001921 logging.warn('can\'t detect Gerrit project.')
1922 return None
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001923 project = urlparse.urlparse(remote_url).path.strip('/')
1924 if project.endswith('.git'):
1925 project = project[:-len('.git')]
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001926 # *.googlesource.com hosts ensure that Git/Gerrit projects don't start with
1927 # 'a/' prefix, because 'a/' prefix is used to force authentication in
1928 # gitiles/git-over-https protocol. E.g.,
1929 # https://chromium.googlesource.com/a/v8/v8 refers to the same repo/project
1930 # as
1931 # https://chromium.googlesource.com/v8/v8
1932 if project.startswith('a/'):
1933 project = project[len('a/'):]
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001934 return project
1935
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001936 def _GerritChangeIdentifier(self):
1937 """Handy method for gerrit_util.ChangeIdentifier for a given CL.
1938
1939 Not to be confused by value of "Change-Id:" footer.
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001940 If Gerrit project can be determined, this will speed up Gerrit HTTP API RPC.
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001941 """
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001942 project = self._GetGerritProject()
1943 if project:
1944 return gerrit_util.ChangeIdentifier(project, self.GetIssue())
1945 # Fall back on still unique, but less efficient change number.
1946 return str(self.GetIssue())
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001947
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001948 @classmethod
tandrii5d48c322016-08-18 16:19:37 -07001949 def IssueConfigKey(cls):
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001950 return 'gerritissue'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001951
tandrii5d48c322016-08-18 16:19:37 -07001952 @classmethod
1953 def PatchsetConfigKey(cls):
1954 return 'gerritpatchset'
1955
1956 @classmethod
1957 def CodereviewServerConfigKey(cls):
1958 return 'gerritserver'
1959
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001960 def EnsureAuthenticated(self, force, refresh=None):
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001961 """Best effort check that user is authenticated with Gerrit server."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001962 if settings.GetGerritSkipEnsureAuthenticated():
1963 # For projects with unusual authentication schemes.
1964 # See http://crbug.com/603378.
1965 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001966
1967 # Check presence of cookies only if using cookies-based auth method.
1968 cookie_auth = gerrit_util.Authenticator.get()
1969 if not isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001970 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001971
1972 # Lazy-loader to identify Gerrit and Git hosts.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001973 self.GetCodereviewServer()
1974 git_host = self._GetGitHost()
Edward Lemur298f2cf2019-02-22 21:40:39 +00001975 assert self._gerrit_server and self._gerrit_host and git_host
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001976
1977 gerrit_auth = cookie_auth.get_auth_header(self._gerrit_host)
1978 git_auth = cookie_auth.get_auth_header(git_host)
1979 if gerrit_auth and git_auth:
1980 if gerrit_auth == git_auth:
1981 return
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001982 all_gsrc = cookie_auth.get_auth_header('d0esN0tEx1st.googlesource.com')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001983 print((
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001984 'WARNING: You have different credentials for Gerrit and git hosts:\n'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001985 ' %s\n'
1986 ' %s\n'
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001987 ' Consider running the following command:\n'
1988 ' git cl creds-check\n'
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001989 ' %s\n'
Andrii Shyshkalov8e4576f2017-05-10 15:46:53 +02001990 ' %s') %
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001991 (git_host, self._gerrit_host,
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001992 ('Hint: delete creds for .googlesource.com' if all_gsrc else ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001993 cookie_auth.get_new_password_message(git_host)))
1994 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001995 confirm_or_exit('If you know what you are doing', action='continue')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001996 return
1997 else:
1998 missing = (
Anna Henningsen4e891442017-07-06 21:40:58 +02001999 ([] if gerrit_auth else [self._gerrit_host]) +
2000 ([] if git_auth else [git_host]))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002001 DieWithError('Credentials for the following hosts are required:\n'
2002 ' %s\n'
2003 'These are read from %s (or legacy %s)\n'
2004 '%s' % (
2005 '\n '.join(missing),
2006 cookie_auth.get_gitcookies_path(),
2007 cookie_auth.get_netrc_path(),
2008 cookie_auth.get_new_password_message(git_host)))
2009
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002010 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01002011 if not self.GetIssue():
2012 return
2013
2014 # Warm change details cache now to avoid RPCs later, reducing latency for
2015 # developers.
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002016 self._GetChangeDetail(
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +00002017 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS'])
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01002018
2019 status = self._GetChangeDetail()['status']
2020 if status in ('MERGED', 'ABANDONED'):
2021 DieWithError('Change %s has been %s, new uploads are not allowed' %
2022 (self.GetIssueURL(),
2023 'submitted' if status == 'MERGED' else 'abandoned'))
2024
Vadim Shtayurab250ec12018-10-04 00:21:08 +00002025 # TODO(vadimsh): For some reason the chunk of code below was skipped if
2026 # 'is_gce' is True. I'm just refactoring it to be 'skip if not cookies'.
2027 # Apparently this check is not very important? Otherwise get_auth_email
2028 # could have been added to other implementations of Authenticator.
2029 cookies_auth = gerrit_util.Authenticator.get()
2030 if not isinstance(cookies_auth, gerrit_util.CookiesAuthenticator):
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002031 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00002032
2033 cookies_user = cookies_auth.get_auth_email(self._GetGerritHost())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002034 if self.GetIssueOwner() == cookies_user:
2035 return
2036 logging.debug('change %s owner is %s, cookies user is %s',
2037 self.GetIssue(), self.GetIssueOwner(), cookies_user)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002038 # Maybe user has linked accounts or something like that,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002039 # so ask what Gerrit thinks of this user.
2040 details = gerrit_util.GetAccountDetails(self._GetGerritHost(), 'self')
2041 if details['email'] == self.GetIssueOwner():
2042 return
2043 if not force:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002044 print('WARNING: Change %s is owned by %s, but you authenticate to Gerrit '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002045 'as %s.\n'
2046 'Uploading may fail due to lack of permissions.' %
2047 (self.GetIssue(), self.GetIssueOwner(), details['email']))
2048 confirm_or_exit(action='upload')
2049
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002050 def _PostUnsetIssueProperties(self):
2051 """Which branch-specific properties to erase when unsetting issue."""
tandrii5d48c322016-08-18 16:19:37 -07002052 return ['gerritsquashhash']
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002053
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00002054 def GetGerritObjForPresubmit(self):
2055 return presubmit_support.GerritAccessor(self._GetGerritHost())
2056
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002057 def GetStatus(self):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002058 """Apply a rough heuristic to give a simple summary of an issue's review
2059 or CQ status, assuming adherence to a common workflow.
2060
2061 Returns None if no issue for this branch, or one of the following keywords:
Aaron Gable9ab38c62017-04-06 14:36:33 -07002062 * 'error' - error from review tool (including deleted issues)
2063 * 'unsent' - no reviewers added
2064 * 'waiting' - waiting for review
2065 * 'reply' - waiting for uploader to reply to review
2066 * 'lgtm' - Code-Review label has been set
Andrii Shyshkalov3c830222019-04-02 06:19:27 +00002067 * 'dry-run' - dry-running in the commit queue
Aaron Gable9ab38c62017-04-06 14:36:33 -07002068 * 'commit' - in the commit queue
2069 * 'closed' - successfully submitted or abandoned
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002070 """
2071 if not self.GetIssue():
2072 return None
2073
2074 try:
Aaron Gable9ab38c62017-04-06 14:36:33 -07002075 data = self._GetChangeDetail([
2076 'DETAILED_LABELS', 'CURRENT_REVISION', 'SUBMITTABLE'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002077 except (httplib.HTTPException, GerritChangeNotExists):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002078 return 'error'
2079
tandrii@chromium.org5e1bf382016-05-17 08:43:24 +00002080 if data['status'] in ('ABANDONED', 'MERGED'):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002081 return 'closed'
2082
Andrii Shyshkalov3c830222019-04-02 06:19:27 +00002083 cq_label = data['labels'].get('Commit-Queue', {})
2084 if cq_label.get('value') == 1:
2085 return 'dry-run'
2086 if cq_label.get('value') == 2:
Aaron Gable9ab38c62017-04-06 14:36:33 -07002087 return 'commit'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002088
Aaron Gable9ab38c62017-04-06 14:36:33 -07002089 if data['labels'].get('Code-Review', {}).get('approved'):
2090 return 'lgtm'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002091
2092 if not data.get('reviewers', {}).get('REVIEWER', []):
2093 return 'unsent'
2094
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01002095 owner = data['owner'].get('_account_id')
Aaron Gable9ab38c62017-04-06 14:36:33 -07002096 messages = sorted(data.get('messages', []), key=lambda m: m.get('updated'))
2097 last_message_author = messages.pop().get('author', {})
2098 while last_message_author:
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01002099 if last_message_author.get('email') == COMMIT_BOT_EMAIL:
2100 # Ignore replies from CQ.
Aaron Gable9ab38c62017-04-06 14:36:33 -07002101 last_message_author = messages.pop().get('author', {})
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01002102 continue
Aaron Gable9ab38c62017-04-06 14:36:33 -07002103 if last_message_author.get('_account_id') == owner:
2104 # Most recent message was by owner.
2105 return 'waiting'
2106 else:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002107 # Some reply from non-owner.
2108 return 'reply'
Aaron Gable9ab38c62017-04-06 14:36:33 -07002109
2110 # Somehow there are no messages even though there are reviewers.
2111 return 'unsent'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002112
2113 def GetMostRecentPatchset(self):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002114 data = self._GetChangeDetail(['CURRENT_REVISION'])
Aaron Gablee8856ee2017-12-07 12:41:46 -08002115 patchset = data['revisions'][data['current_revision']]['_number']
2116 self.SetPatchset(patchset)
2117 return patchset
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002118
Kenneth Russell61e2ed42017-02-15 11:47:13 -08002119 def FetchDescription(self, force=False):
2120 data = self._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'],
2121 no_cache=force)
tandrii@chromium.org2d3da632016-04-25 19:23:27 +00002122 current_rev = data['current_revision']
Dan Beamcf6df902018-11-08 01:48:37 +00002123 return data['revisions'][current_rev]['commit']['message'].encode(
2124 'utf-8', 'ignore')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002125
dsansomee2d6fd92016-09-08 00:10:47 -07002126 def UpdateDescriptionRemote(self, description, force=False):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002127 if gerrit_util.HasPendingChangeEdit(
2128 self._GetGerritHost(), self._GerritChangeIdentifier()):
dsansomee2d6fd92016-09-08 00:10:47 -07002129 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002130 confirm_or_exit(
dsansomee2d6fd92016-09-08 00:10:47 -07002131 'The description cannot be modified while the issue has a pending '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002132 'unpublished edit. Either publish the edit in the Gerrit web UI '
2133 'or delete it.\n\n', action='delete the unpublished edit')
dsansomee2d6fd92016-09-08 00:10:47 -07002134
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002135 gerrit_util.DeletePendingChangeEdit(
2136 self._GetGerritHost(), self._GerritChangeIdentifier())
2137 gerrit_util.SetCommitMessage(
2138 self._GetGerritHost(), self._GerritChangeIdentifier(),
2139 description, notify='NONE')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002140
Aaron Gable636b13f2017-07-14 10:42:48 -07002141 def AddComment(self, message, publish=None):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002142 gerrit_util.SetReview(
2143 self._GetGerritHost(), self._GerritChangeIdentifier(),
2144 msg=message, ready=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002145
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002146 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002147 # DETAILED_ACCOUNTS is to get emails in accounts.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002148 # CURRENT_REVISION is included to get the latest patchset so that
2149 # only the robot comments from the latest patchset can be shown.
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002150 messages = self._GetChangeDetail(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002151 options=['MESSAGES', 'DETAILED_ACCOUNTS',
2152 'CURRENT_REVISION']).get('messages', [])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002153 file_comments = gerrit_util.GetChangeComments(
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002154 self._GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002155 robot_file_comments = gerrit_util.GetChangeRobotComments(
2156 self._GetGerritHost(), self._GerritChangeIdentifier())
2157
2158 # Add the robot comments onto the list of comments, but only
2159 # keep those that are from the latest pachset.
2160 latest_patch_set = self.GetMostRecentPatchset()
2161 for path, robot_comments in robot_file_comments.iteritems():
2162 line_comments = file_comments.setdefault(path, [])
2163 line_comments.extend(
2164 [c for c in robot_comments if c['patch_set'] == latest_patch_set])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002165
2166 # Build dictionary of file comments for easy access and sorting later.
2167 # {author+date: {path: {patchset: {line: url+message}}}}
2168 comments = collections.defaultdict(
2169 lambda: collections.defaultdict(lambda: collections.defaultdict(dict)))
2170 for path, line_comments in file_comments.iteritems():
2171 for comment in line_comments:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002172 tag = comment.get('tag', '')
2173 if tag.startswith('autogenerated') and 'robot_id' not in comment:
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002174 continue
2175 key = (comment['author']['email'], comment['updated'])
2176 if comment.get('side', 'REVISION') == 'PARENT':
2177 patchset = 'Base'
2178 else:
2179 patchset = 'PS%d' % comment['patch_set']
2180 line = comment.get('line', 0)
2181 url = ('https://%s/c/%s/%s/%s#%s%s' %
2182 (self._GetGerritHost(), self.GetIssue(), comment['patch_set'], path,
2183 'b' if comment.get('side') == 'PARENT' else '',
2184 str(line) if line else ''))
2185 comments[key][path][patchset][line] = (url, comment['message'])
2186
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002187 summaries = []
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002188 for msg in messages:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002189 summary = self._BuildCommentSummary(msg, comments, readable)
2190 if summary:
2191 summaries.append(summary)
2192 return summaries
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002193
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002194 @staticmethod
2195 def _BuildCommentSummary(msg, comments, readable):
2196 key = (msg['author']['email'], msg['date'])
2197 # Don't bother showing autogenerated messages that don't have associated
2198 # file or line comments. this will filter out most autogenerated
2199 # messages, but will keep robot comments like those from Tricium.
2200 is_autogenerated = msg.get('tag', '').startswith('autogenerated')
2201 if is_autogenerated and not comments.get(key):
2202 return None
2203 message = msg['message']
2204 # Gerrit spits out nanoseconds.
2205 assert len(msg['date'].split('.')[-1]) == 9
2206 date = datetime.datetime.strptime(msg['date'][:-3],
2207 '%Y-%m-%d %H:%M:%S.%f')
2208 if key in comments:
2209 message += '\n'
2210 for path, patchsets in sorted(comments.get(key, {}).items()):
2211 if readable:
2212 message += '\n%s' % path
2213 for patchset, lines in sorted(patchsets.items()):
2214 for line, (url, content) in sorted(lines.items()):
2215 if line:
2216 line_str = 'Line %d' % line
2217 path_str = '%s:%d:' % (path, line)
2218 else:
2219 line_str = 'File comment'
2220 path_str = '%s:0:' % path
2221 if readable:
2222 message += '\n %s, %s: %s' % (patchset, line_str, url)
2223 message += '\n %s\n' % content
2224 else:
2225 message += '\n%s ' % path_str
2226 message += '\n%s\n' % content
2227
2228 return _CommentSummary(
2229 date=date,
2230 message=message,
2231 sender=msg['author']['email'],
2232 autogenerated=is_autogenerated,
2233 # These could be inferred from the text messages and correlated with
2234 # Code-Review label maximum, however this is not reliable.
2235 # Leaving as is until the need arises.
2236 approval=False,
2237 disapproval=False,
2238 )
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01002239
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002240 def CloseIssue(self):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002241 gerrit_util.AbandonChange(
2242 self._GetGerritHost(), self._GerritChangeIdentifier(), msg='')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002243
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002244 def SubmitIssue(self, wait_for_merge=True):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002245 gerrit_util.SubmitChange(
2246 self._GetGerritHost(), self._GerritChangeIdentifier(),
2247 wait_for_merge=wait_for_merge)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002248
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002249 def _GetChangeDetail(self, options=None, no_cache=False):
2250 """Returns details of associated Gerrit change and caching results.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002251
2252 If fresh data is needed, set no_cache=True which will clear cache and
2253 thus new data will be fetched from Gerrit.
2254 """
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002255 options = options or []
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002256 assert self.GetIssue(), 'issue is required to query Gerrit'
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002257
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002258 # Optimization to avoid multiple RPCs:
2259 if (('CURRENT_REVISION' in options or 'ALL_REVISIONS' in options) and
2260 'CURRENT_COMMIT' not in options):
2261 options.append('CURRENT_COMMIT')
2262
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002263 # Normalize issue and options for consistent keys in cache.
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002264 cache_key = str(self.GetIssue())
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002265 options = [o.upper() for o in options]
2266
2267 # Check in cache first unless no_cache is True.
2268 if no_cache:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002269 self._detail_cache.pop(cache_key, None)
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002270 else:
2271 options_set = frozenset(options)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002272 for cached_options_set, data in self._detail_cache.get(cache_key, []):
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002273 # Assumption: data fetched before with extra options is suitable
2274 # for return for a smaller set of options.
2275 # For example, if we cached data for
2276 # options=[CURRENT_REVISION, DETAILED_FOOTERS]
2277 # and request is for options=[CURRENT_REVISION],
2278 # THEN we can return prior cached data.
2279 if options_set.issubset(cached_options_set):
2280 return data
2281
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002282 try:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002283 data = gerrit_util.GetChangeDetail(
2284 self._GetGerritHost(), self._GerritChangeIdentifier(), options)
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002285 except gerrit_util.GerritError as e:
2286 if e.http_status == 404:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002287 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002288 raise
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002289
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002290 self._detail_cache.setdefault(cache_key, []).append(
2291 (frozenset(options), data))
tandriic2405f52016-10-10 08:13:15 -07002292 return data
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002293
Andrii Shyshkalovcc5f17e2018-08-22 23:35:59 +00002294 def _GetChangeCommit(self):
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002295 assert self.GetIssue(), 'issue must be set to query Gerrit'
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002296 try:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002297 data = gerrit_util.GetChangeCommit(
2298 self._GetGerritHost(), self._GerritChangeIdentifier())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002299 except gerrit_util.GerritError as e:
2300 if e.http_status == 404:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002301 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002302 raise
agable32978d92016-11-01 12:55:02 -07002303 return data
2304
Karen Qian40c19422019-03-13 21:28:29 +00002305 def _IsCqConfigured(self):
2306 detail = self._GetChangeDetail(['LABELS'])
2307 if not u'Commit-Queue' in detail.get('labels', {}):
2308 return False
2309 # TODO(crbug/753213): Remove temporary hack
2310 if ('https://chromium.googlesource.com/chromium/src' ==
2311 self._changelist.GetRemoteUrl() and
2312 detail['branch'].startswith('refs/branch-heads/')):
2313 return False
2314 return True
2315
Olivier Robin75ee7252018-04-13 10:02:56 +02002316 def CMDLand(self, force, bypass_hooks, verbose, parallel):
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002317 if git_common.is_dirty_git_tree('land'):
2318 return 1
Karen Qian40c19422019-03-13 21:28:29 +00002319
tandriid60367b2016-06-22 05:25:12 -07002320 detail = self._GetChangeDetail(['CURRENT_REVISION', 'LABELS'])
Karen Qian40c19422019-03-13 21:28:29 +00002321 if not force and self._IsCqConfigured():
2322 confirm_or_exit('\nIt seems this repository has a Commit Queue, '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002323 'which can test and land changes for you. '
2324 'Are you sure you wish to bypass it?\n',
2325 action='bypass CQ')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002326 differs = True
tandriic4344b52016-08-29 06:04:54 -07002327 last_upload = self._GitGetBranchConfigValue('gerritsquashhash')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002328 # Note: git diff outputs nothing if there is no diff.
2329 if not last_upload or RunGit(['diff', last_upload]).strip():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002330 print('WARNING: Some changes from local branch haven\'t been uploaded.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002331 else:
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002332 if detail['current_revision'] == last_upload:
2333 differs = False
2334 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002335 print('WARNING: Local branch contents differ from latest uploaded '
2336 'patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002337 if differs:
2338 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002339 confirm_or_exit(
2340 'Do you want to submit latest Gerrit patchset and bypass hooks?\n',
2341 action='submit')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002342 print('WARNING: Bypassing hooks and submitting latest uploaded patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002343 elif not bypass_hooks:
2344 hook_results = self.RunHook(
2345 committing=True,
2346 may_prompt=not force,
2347 verbose=verbose,
Olivier Robin75ee7252018-04-13 10:02:56 +02002348 change=self.GetChange(self.GetCommonAncestorWithUpstream(), None),
2349 parallel=parallel)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002350 if not hook_results.should_continue():
2351 return 1
2352
2353 self.SubmitIssue(wait_for_merge=True)
2354 print('Issue %s has been submitted.' % self.GetIssueURL())
agable32978d92016-11-01 12:55:02 -07002355 links = self._GetChangeCommit().get('web_links', [])
2356 for link in links:
Aaron Gable02cdbb42016-12-13 16:24:25 -08002357 if link.get('name') == 'gitiles' and link.get('url'):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002358 print('Landed as: %s' % link.get('url'))
agable32978d92016-11-01 12:55:02 -07002359 break
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002360 return 0
2361
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002362 def CMDPatchWithParsedIssue(self, parsed_issue_arg, reject, nocommit,
Aaron Gable62619a32017-06-16 08:22:09 -07002363 directory, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002364 assert not reject
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002365 assert not directory
2366 assert parsed_issue_arg.valid
2367
2368 self._changelist.issue = parsed_issue_arg.issue
2369
2370 if parsed_issue_arg.hostname:
2371 self._gerrit_host = parsed_issue_arg.hostname
2372 self._gerrit_server = 'https://%s' % self._gerrit_host
2373
tandriic2405f52016-10-10 08:13:15 -07002374 try:
2375 detail = self._GetChangeDetail(['ALL_REVISIONS'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002376 except GerritChangeNotExists as e:
tandriic2405f52016-10-10 08:13:15 -07002377 DieWithError(str(e))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002378
2379 if not parsed_issue_arg.patchset:
2380 # Use current revision by default.
2381 revision_info = detail['revisions'][detail['current_revision']]
2382 patchset = int(revision_info['_number'])
2383 else:
2384 patchset = parsed_issue_arg.patchset
2385 for revision_info in detail['revisions'].itervalues():
2386 if int(revision_info['_number']) == parsed_issue_arg.patchset:
2387 break
2388 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08002389 DieWithError('Couldn\'t find patchset %i in change %i' %
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002390 (parsed_issue_arg.patchset, self.GetIssue()))
2391
Aaron Gable697a91b2018-01-19 15:20:15 -08002392 remote_url = self._changelist.GetRemoteUrl()
2393 if remote_url.endswith('.git'):
2394 remote_url = remote_url[:-len('.git')]
erikchen0d14d0d2018-08-28 18:57:09 +00002395 remote_url = remote_url.rstrip('/')
2396
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002397 fetch_info = revision_info['fetch']['http']
erikchen0d14d0d2018-08-28 18:57:09 +00002398 fetch_info['url'] = fetch_info['url'].rstrip('/')
Aaron Gable697a91b2018-01-19 15:20:15 -08002399
2400 if remote_url != fetch_info['url']:
2401 DieWithError('Trying to patch a change from %s but this repo appears '
2402 'to be %s.' % (fetch_info['url'], remote_url))
2403
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002404 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
Aaron Gable9387b4f2017-06-08 10:50:03 -07002405
Aaron Gable62619a32017-06-16 08:22:09 -07002406 if force:
2407 RunGit(['reset', '--hard', 'FETCH_HEAD'])
2408 print('Checked out commit for change %i patchset %i locally' %
2409 (parsed_issue_arg.issue, patchset))
Stefan Zager2d5f0392017-10-10 15:17:53 -07002410 elif nocommit:
2411 RunGit(['cherry-pick', '--no-commit', 'FETCH_HEAD'])
2412 print('Patch applied to index.')
Aaron Gable62619a32017-06-16 08:22:09 -07002413 else:
Aaron Gable9387b4f2017-06-08 10:50:03 -07002414 RunGit(['cherry-pick', 'FETCH_HEAD'])
2415 print('Committed patch for change %i patchset %i locally.' %
Aaron Gable62619a32017-06-16 08:22:09 -07002416 (parsed_issue_arg.issue, patchset))
2417 print('Note: this created a local commit which does not have '
2418 'the same hash as the one uploaded for review. This will make '
2419 'uploading changes based on top of this branch difficult.\n'
2420 'If you want to do that, use "git cl patch --force" instead.')
2421
Stefan Zagerd08043c2017-10-12 12:07:02 -07002422 if self.GetBranch():
2423 self.SetIssue(parsed_issue_arg.issue)
2424 self.SetPatchset(patchset)
2425 fetched_hash = RunGit(['rev-parse', 'FETCH_HEAD']).strip()
2426 self._GitSetBranchConfigValue('last-upload-hash', fetched_hash)
2427 self._GitSetBranchConfigValue('gerritsquashhash', fetched_hash)
2428 else:
2429 print('WARNING: You are in detached HEAD state.\n'
2430 'The patch has been applied to your checkout, but you will not be '
2431 'able to upload a new patch set to the gerrit issue.\n'
2432 'Try using the \'-b\' option if you would like to work on a '
2433 'branch and/or upload a new patch set.')
2434
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002435 return 0
2436
2437 @staticmethod
2438 def ParseIssueURL(parsed_url):
2439 if not parsed_url.scheme or not parsed_url.scheme.startswith('http'):
2440 return None
Aaron Gable01b91062017-08-24 17:48:40 -07002441 # Gerrit's new UI is https://domain/c/project/+/<issue_number>[/[patchset]]
2442 # But old GWT UI is https://domain/#/c/project/+/<issue_number>[/[patchset]]
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002443 # Short urls like https://domain/<issue_number> can be used, but don't allow
2444 # specifying the patchset (you'd 404), but we allow that here.
2445 if parsed_url.path == '/':
2446 part = parsed_url.fragment
2447 else:
2448 part = parsed_url.path
Aaron Gable01b91062017-08-24 17:48:40 -07002449 match = re.match('(/c(/.*/\+)?)?/(\d+)(/(\d+)?/?)?$', part)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002450 if match:
2451 return _ParsedIssueNumberArgument(
Aaron Gable01b91062017-08-24 17:48:40 -07002452 issue=int(match.group(3)),
2453 patchset=int(match.group(5)) if match.group(5) else None,
Andrii Shyshkalov90f31922017-04-10 16:10:21 +02002454 hostname=parsed_url.netloc,
2455 codereview='gerrit')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002456 return None
2457
tandrii16e0b4e2016-06-07 10:34:28 -07002458 def _GerritCommitMsgHookCheck(self, offer_removal):
2459 hook = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
2460 if not os.path.exists(hook):
2461 return
2462 # Crude attempt to distinguish Gerrit Codereview hook from potentially
2463 # custom developer made one.
2464 data = gclient_utils.FileRead(hook)
2465 if not('From Gerrit Code Review' in data and 'add_ChangeId()' in data):
2466 return
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002467 print('WARNING: You have Gerrit commit-msg hook installed.\n'
qyearsley12fa6ff2016-08-24 09:18:40 -07002468 'It is not necessary for uploading with git cl in squash mode, '
tandrii16e0b4e2016-06-07 10:34:28 -07002469 'and may interfere with it in subtle ways.\n'
2470 'We recommend you remove the commit-msg hook.')
2471 if offer_removal:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002472 if ask_for_explicit_yes('Do you want to remove it now?'):
tandrii16e0b4e2016-06-07 10:34:28 -07002473 gclient_utils.rm_file_or_tree(hook)
2474 print('Gerrit commit-msg hook removed.')
2475 else:
2476 print('OK, will keep Gerrit commit-msg hook in place.')
2477
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002478 def CMDUploadChange(self, options, git_diff_args, custom_cl_base, change):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002479 """Upload the current branch to Gerrit."""
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00002480 if options.squash and options.no_squash:
2481 DieWithError('Can only use one of --squash or --no-squash')
tandriia60502f2016-06-20 02:01:53 -07002482
2483 if not options.squash and not options.no_squash:
2484 # Load default for user, repo, squash=true, in this order.
2485 options.squash = settings.GetSquashGerritUploads()
2486 elif options.no_squash:
2487 options.squash = False
tandrii26f3e4e2016-06-10 08:37:04 -07002488
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002489 remote, remote_branch = self.GetRemoteBranch()
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01002490 branch = GetTargetRef(remote, remote_branch, options.target_branch)
Aaron Gableb56ad332017-01-06 15:24:31 -08002491 # This may be None; default fallback value is determined in logic below.
2492 title = options.title
2493
Dominic Battre7d1c4842017-10-27 09:17:28 +02002494 # Extract bug number from branch name.
2495 bug = options.bug
2496 match = re.match(r'(?:bug|fix)[_-]?(\d+)', self.GetBranch())
2497 if not bug and match:
2498 bug = match.group(1)
2499
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002500 if options.squash:
tandrii16e0b4e2016-06-07 10:34:28 -07002501 self._GerritCommitMsgHookCheck(offer_removal=not options.force)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002502 if self.GetIssue():
2503 # Try to get the message from a previous upload.
2504 message = self.GetDescription()
2505 if not message:
2506 DieWithError(
Aaron Gablea45ee112016-11-22 15:14:38 -08002507 'failed to fetch description from current Gerrit change %d\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002508 '%s' % (self.GetIssue(), self.GetIssueURL()))
Aaron Gableb56ad332017-01-06 15:24:31 -08002509 if not title:
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002510 if options.message:
Aaron Gable7303dcb2017-06-07 14:17:32 -07002511 # When uploading a subsequent patchset, -m|--message is taken
2512 # as the patchset title if --title was not provided.
2513 title = options.message.strip()
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002514 else:
2515 default_title = RunGit(
2516 ['show', '-s', '--format=%s', 'HEAD']).strip()
Aaron Gable7303dcb2017-06-07 14:17:32 -07002517 if options.force:
2518 title = default_title
2519 else:
2520 title = ask_for_data(
2521 'Title for patchset [%s]: ' % default_title) or default_title
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002522 change_id = self._GetChangeDetail()['change_id']
2523 while True:
2524 footer_change_ids = git_footers.get_footer_change_id(message)
2525 if footer_change_ids == [change_id]:
2526 break
2527 if not footer_change_ids:
2528 message = git_footers.add_footer_change_id(message, change_id)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002529 print('WARNING: appended missing Change-Id to change description.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002530 continue
2531 # There is already a valid footer but with different or several ids.
2532 # Doing this automatically is non-trivial as we don't want to lose
2533 # existing other footers, yet we want to append just 1 desired
2534 # Change-Id. Thus, just create a new footer, but let user verify the
2535 # new description.
2536 message = '%s\n\nChange-Id: %s' % (message, change_id)
2537 print(
Aaron Gablea45ee112016-11-22 15:14:38 -08002538 'WARNING: change %s has Change-Id footer(s):\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002539 ' %s\n'
Aaron Gablea45ee112016-11-22 15:14:38 -08002540 'but change has Change-Id %s, according to Gerrit.\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002541 'Please, check the proposed correction to the description, '
2542 'and edit it if necessary but keep the "Change-Id: %s" footer\n'
2543 % (self.GetIssue(), '\n '.join(footer_change_ids), change_id,
2544 change_id))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002545 confirm_or_exit(action='edit')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002546 if not options.force:
2547 change_desc = ChangeDescription(message)
Dominic Battre7d1c4842017-10-27 09:17:28 +02002548 change_desc.prompt(bug=bug)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002549 message = change_desc.description
2550 if not message:
2551 DieWithError("Description is empty. Aborting...")
2552 # Continue the while loop.
2553 # Sanity check of this code - we should end up with proper message
2554 # footer.
2555 assert [change_id] == git_footers.get_footer_change_id(message)
2556 change_desc = ChangeDescription(message)
Aaron Gableb56ad332017-01-06 15:24:31 -08002557 else: # if not self.GetIssue()
2558 if options.message:
2559 message = options.message
2560 else:
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002561 message = _create_description_from_log(git_diff_args)
Aaron Gableb56ad332017-01-06 15:24:31 -08002562 if options.title:
2563 message = options.title + '\n\n' + message
2564 change_desc = ChangeDescription(message)
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002565
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002566 if not options.force:
Dominic Battre7d1c4842017-10-27 09:17:28 +02002567 change_desc.prompt(bug=bug)
Aaron Gableb56ad332017-01-06 15:24:31 -08002568 # On first upload, patchset title is always this string, while
2569 # --title flag gets converted to first line of message.
2570 title = 'Initial upload'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002571 if not change_desc.description:
2572 DieWithError("Description is empty. Aborting...")
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002573 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002574 if len(change_ids) > 1:
2575 DieWithError('too many Change-Id footers, at most 1 allowed.')
2576 if not change_ids:
2577 # Generate the Change-Id automatically.
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002578 change_desc.set_description(git_footers.add_footer_change_id(
2579 change_desc.description,
2580 GenerateGerritChangeId(change_desc.description)))
2581 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002582 assert len(change_ids) == 1
2583 change_id = change_ids[0]
2584
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002585 if options.reviewers or options.tbrs or options.add_owners_to:
2586 change_desc.update_reviewers(options.reviewers, options.tbrs,
2587 options.add_owners_to, change)
2588
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002589 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002590 parent = self._ComputeParent(remote, upstream_branch, custom_cl_base,
2591 options.force, change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002592 tree = RunGit(['rev-parse', 'HEAD:']).strip()
Aaron Gable9a03ae02017-11-03 11:31:07 -07002593 with tempfile.NamedTemporaryFile(delete=False) as desc_tempfile:
2594 desc_tempfile.write(change_desc.description)
2595 desc_tempfile.close()
2596 ref_to_push = RunGit(['commit-tree', tree, '-p', parent,
2597 '-F', desc_tempfile.name]).strip()
2598 os.remove(desc_tempfile.name)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002599 else:
2600 change_desc = ChangeDescription(
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002601 options.message or _create_description_from_log(git_diff_args))
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002602 if not change_desc.description:
2603 DieWithError("Description is empty. Aborting...")
2604
2605 if not git_footers.get_footer_change_id(change_desc.description):
2606 DownloadGerritHook(False)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002607 change_desc.set_description(
2608 self._AddChangeIdToCommitMessage(options, git_diff_args))
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002609 if options.reviewers or options.tbrs or options.add_owners_to:
2610 change_desc.update_reviewers(options.reviewers, options.tbrs,
2611 options.add_owners_to, change)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002612 ref_to_push = 'HEAD'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002613 # For no-squash mode, we assume the remote called "origin" is the one we
2614 # want. It is not worthwhile to support different workflows for
2615 # no-squash mode.
2616 parent = 'origin/%s' % branch
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002617 change_id = git_footers.get_footer_change_id(change_desc.description)[0]
2618
2619 assert change_desc
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00002620 SaveDescriptionBackup(change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002621 commits = RunGitSilent(['rev-list', '%s..%s' % (parent,
2622 ref_to_push)]).splitlines()
2623 if len(commits) > 1:
2624 print('WARNING: This will upload %d commits. Run the following command '
2625 'to see which commits will be uploaded: ' % len(commits))
2626 print('git log %s..%s' % (parent, ref_to_push))
2627 print('You can also use `git squash-branch` to squash these into a '
2628 'single commit.')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002629 confirm_or_exit(action='upload')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002630
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002631 if options.reviewers or options.tbrs or options.add_owners_to:
2632 change_desc.update_reviewers(options.reviewers, options.tbrs,
2633 options.add_owners_to, change)
2634
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002635 reviewers = sorted(change_desc.get_reviewers())
2636 # Add cc's from the CC_LIST and --cc flag (if any).
2637 if not options.private and not options.no_autocc:
2638 cc = self.GetCCList().split(',')
2639 else:
2640 cc = []
2641 if options.cc:
2642 cc.extend(options.cc)
2643 cc = filter(None, [email.strip() for email in cc])
2644 if change_desc.get_cced():
2645 cc.extend(change_desc.get_cced())
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00002646 if self._GetGerritHost() == 'chromium-review.googlesource.com':
2647 valid_accounts = set(reviewers + cc)
2648 # TODO(crbug/877717): relax this for all hosts.
2649 else:
2650 valid_accounts = gerrit_util.ValidAccounts(
2651 self._GetGerritHost(), reviewers + cc)
Andrii Shyshkalovf170af42018-10-30 07:00:44 +00002652 logging.info('accounts %s are recognized, %s invalid',
2653 sorted(valid_accounts),
2654 set(reviewers + cc).difference(set(valid_accounts)))
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002655
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002656 # Extra options that can be specified at push time. Doc:
2657 # https://gerrit-review.googlesource.com/Documentation/user-upload.html
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002658 refspec_opts = []
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002659
Aaron Gable844cf292017-06-28 11:32:59 -07002660 # By default, new changes are started in WIP mode, and subsequent patchsets
2661 # don't send email. At any time, passing --send-mail will mark the change
2662 # ready and send email for that particular patch.
Aaron Gableafd52772017-06-27 16:40:10 -07002663 if options.send_mail:
2664 refspec_opts.append('ready')
Aaron Gable844cf292017-06-28 11:32:59 -07002665 refspec_opts.append('notify=ALL')
Jamie Madill276da0b2018-04-27 14:41:20 -04002666 elif not self.GetIssue() and options.squash:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002667 refspec_opts.append('wip')
Aaron Gableafd52772017-06-27 16:40:10 -07002668 else:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002669 refspec_opts.append('notify=NONE')
Aaron Gable70f4e242017-06-26 10:45:59 -07002670
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002671 # TODO(tandrii): options.message should be posted as a comment
Aaron Gablee5adf612017-07-14 10:43:58 -07002672 # if --send-mail is set on non-initial upload as Rietveld used to do it.
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002673
Aaron Gable9b713dd2016-12-14 16:04:21 -08002674 if title:
Nick Carter8692b182017-11-06 16:30:38 -08002675 # Punctuation and whitespace in |title| must be percent-encoded.
2676 refspec_opts.append('m=' + gerrit_util.PercentEncodeForGitRef(title))
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002677
agablec6787972016-09-09 16:13:34 -07002678 if options.private:
Aaron Gableb02daf02017-05-23 11:53:46 -07002679 refspec_opts.append('private')
agablec6787972016-09-09 16:13:34 -07002680
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002681 for r in sorted(reviewers):
2682 if r in valid_accounts:
2683 refspec_opts.append('r=%s' % r)
2684 reviewers.remove(r)
2685 else:
2686 # TODO(tandrii): this should probably be a hard failure.
2687 print('WARNING: reviewer %s doesn\'t have a Gerrit account, skipping'
2688 % r)
2689 for c in sorted(cc):
2690 # refspec option will be rejected if cc doesn't correspond to an
2691 # account, even though REST call to add such arbitrary cc may succeed.
2692 if c in valid_accounts:
2693 refspec_opts.append('cc=%s' % c)
2694 cc.remove(c)
2695
rmistry9eadede2016-09-19 11:22:43 -07002696 if options.topic:
2697 # Documentation on Gerrit topics is here:
2698 # https://gerrit-review.googlesource.com/Documentation/user-upload.html#topic
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002699 refspec_opts.append('topic=%s' % options.topic)
rmistry9eadede2016-09-19 11:22:43 -07002700
Edward Lemur687ca902018-12-05 02:30:30 +00002701 if options.enable_auto_submit:
2702 refspec_opts.append('l=Auto-Submit+1')
2703 if options.use_commit_queue:
2704 refspec_opts.append('l=Commit-Queue+2')
2705 elif options.cq_dry_run:
2706 refspec_opts.append('l=Commit-Queue+1')
2707
2708 if change_desc.get_reviewers(tbr_only=True):
2709 score = gerrit_util.GetCodeReviewTbrScore(
2710 self._GetGerritHost(),
2711 self._GetGerritProject())
2712 refspec_opts.append('l=Code-Review+%s' % score)
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00002713
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002714 # Gerrit sorts hashtags, so order is not important.
Nodir Turakulov23b82142017-11-16 11:04:25 -08002715 hashtags = {change_desc.sanitize_hash_tag(t) for t in options.hashtags}
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002716 if not self.GetIssue():
Nodir Turakulov23b82142017-11-16 11:04:25 -08002717 hashtags.update(change_desc.get_hash_tags())
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002718 refspec_opts += ['hashtag=%s' % t for t in sorted(hashtags)]
2719
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002720 refspec_suffix = ''
2721 if refspec_opts:
2722 refspec_suffix = '%' + ','.join(refspec_opts)
2723 assert ' ' not in refspec_suffix, (
2724 'spaces not allowed in refspec: "%s"' % refspec_suffix)
2725 refspec = '%s:refs/for/%s%s' % (ref_to_push, branch, refspec_suffix)
2726
Andrii Shyshkalov7d518832016-12-15 20:48:21 +01002727 try:
Raul Tambreba35c7f2019-03-24 06:11:18 +00002728 push_returncode = 0
Edward Lemur01f4a4f2018-11-03 00:40:38 +00002729 before_push = time_time()
Andrii Shyshkalov7d518832016-12-15 20:48:21 +01002730 push_stdout = gclient_utils.CheckCallAndFilter(
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002731 ['git', 'push', self.GetRemoteUrl(), refspec],
Edward Lemuredcefdc2018-11-08 14:41:42 +00002732 print_stdout=True,
Edward Lemur49c8eaf2018-11-07 22:13:12 +00002733 # Flush after every line: useful for seeing progress when running as
2734 # recipe.
2735 filter_fn=lambda _: sys.stdout.flush())
Edward Lemurfec80c42018-11-01 23:14:14 +00002736 except subprocess2.CalledProcessError as e:
2737 push_returncode = e.returncode
Andrii Shyshkalov7d518832016-12-15 20:48:21 +01002738 DieWithError('Failed to create a change. Please examine output above '
Andrii Shyshkalov9d932212017-04-10 14:28:23 +02002739 'for the reason of the failure.\n'
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002740 'Hint: run command below to diagnose common Git/Gerrit '
Andrii Shyshkalov9d932212017-04-10 14:28:23 +02002741 'credential problems:\n'
2742 ' git cl creds-check\n',
2743 change_desc)
Edward Lemurfec80c42018-11-01 23:14:14 +00002744 finally:
2745 metrics.collector.add_repeated('sub_commands', {
2746 'command': 'git push',
Edward Lemur01f4a4f2018-11-03 00:40:38 +00002747 'execution_time': time_time() - before_push,
Edward Lemurfec80c42018-11-01 23:14:14 +00002748 'exit_code': push_returncode,
2749 'arguments': metrics_utils.extract_known_subcommand_args(refspec_opts),
2750 })
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002751
2752 if options.squash:
Aaron Gable289b4312017-09-13 14:06:16 -07002753 regex = re.compile(r'remote:\s+https?://[\w\-\.\+\/#]*/(\d+)\s.*')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002754 change_numbers = [m.group(1)
2755 for m in map(regex.match, push_stdout.splitlines())
2756 if m]
2757 if len(change_numbers) != 1:
2758 DieWithError(
2759 ('Created|Updated %d issues on Gerrit, but only 1 expected.\n'
Christopher Lamf732cd52017-01-24 12:40:11 +11002760 'Change-Id: %s') % (len(change_numbers), change_id), change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002761 self.SetIssue(change_numbers[0])
tandrii5d48c322016-08-18 16:19:37 -07002762 self._GitSetBranchConfigValue('gerritsquashhash', ref_to_push)
tandrii88189772016-09-29 04:29:57 -07002763
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002764 if self.GetIssue() and (reviewers or cc):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002765 # GetIssue() is not set in case of non-squash uploads according to tests.
2766 # TODO(agable): non-squash uploads in git cl should be removed.
2767 gerrit_util.AddReviewers(
2768 self._GetGerritHost(),
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00002769 self._GerritChangeIdentifier(),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002770 reviewers, cc,
2771 notify=bool(options.send_mail))
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002772
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002773 return 0
2774
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002775 def _ComputeParent(self, remote, upstream_branch, custom_cl_base, force,
2776 change_desc):
2777 """Computes parent of the generated commit to be uploaded to Gerrit.
2778
2779 Returns revision or a ref name.
2780 """
2781 if custom_cl_base:
2782 # Try to avoid creating additional unintended CLs when uploading, unless
2783 # user wants to take this risk.
2784 local_ref_of_target_remote = self.GetRemoteBranch()[1]
2785 code, _ = RunGitWithCode(['merge-base', '--is-ancestor', custom_cl_base,
2786 local_ref_of_target_remote])
2787 if code == 1:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002788 print('\nWARNING: Manually specified base of this CL `%s` '
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002789 'doesn\'t seem to belong to target remote branch `%s`.\n\n'
2790 'If you proceed with upload, more than 1 CL may be created by '
2791 'Gerrit as a result, in turn confusing or crashing git cl.\n\n'
2792 'If you are certain that specified base `%s` has already been '
2793 'uploaded to Gerrit as another CL, you may proceed.\n' %
2794 (custom_cl_base, local_ref_of_target_remote, custom_cl_base))
2795 if not force:
2796 confirm_or_exit(
2797 'Do you take responsibility for cleaning up potential mess '
2798 'resulting from proceeding with upload?',
2799 action='upload')
2800 return custom_cl_base
2801
Aaron Gablef97e33d2017-03-30 15:44:27 -07002802 if remote != '.':
2803 return self.GetCommonAncestorWithUpstream()
2804
2805 # If our upstream branch is local, we base our squashed commit on its
2806 # squashed version.
2807 upstream_branch_name = scm.GIT.ShortBranchName(upstream_branch)
2808
Aaron Gablef97e33d2017-03-30 15:44:27 -07002809 if upstream_branch_name == 'master':
Aaron Gable0bbd1c22017-05-08 14:37:08 -07002810 return self.GetCommonAncestorWithUpstream()
Aaron Gablef97e33d2017-03-30 15:44:27 -07002811
2812 # Check the squashed hash of the parent.
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002813 # TODO(tandrii): consider checking parent change in Gerrit and using its
2814 # hash if tree hash of latest parent revision (patchset) in Gerrit matches
2815 # the tree hash of the parent branch. The upside is less likely bogus
2816 # requests to reupload parent change just because it's uploadhash is
2817 # missing, yet the downside likely exists, too (albeit unknown to me yet).
Aaron Gablef97e33d2017-03-30 15:44:27 -07002818 parent = RunGit(['config',
2819 'branch.%s.gerritsquashhash' % upstream_branch_name],
2820 error_ok=True).strip()
2821 # Verify that the upstream branch has been uploaded too, otherwise
2822 # Gerrit will create additional CLs when uploading.
2823 if not parent or (RunGitSilent(['rev-parse', upstream_branch + ':']) !=
2824 RunGitSilent(['rev-parse', parent + ':'])):
2825 DieWithError(
2826 '\nUpload upstream branch %s first.\n'
2827 'It is likely that this branch has been rebased since its last '
2828 'upload, so you just need to upload it again.\n'
2829 '(If you uploaded it with --no-squash, then branch dependencies '
2830 'are not supported, and you should reupload with --squash.)'
2831 % upstream_branch_name,
2832 change_desc)
2833 return parent
2834
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002835 def _AddChangeIdToCommitMessage(self, options, args):
2836 """Re-commits using the current message, assumes the commit hook is in
2837 place.
2838 """
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002839 log_desc = options.message or _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002840 git_command = ['commit', '--amend', '-m', log_desc]
2841 RunGit(git_command)
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002842 new_log_desc = _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002843 if git_footers.get_footer_change_id(new_log_desc):
vapiera7fbd5a2016-06-16 09:17:49 -07002844 print('git-cl: Added Change-Id to commit message.')
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002845 return new_log_desc
2846 else:
tandrii@chromium.orgb067ec52016-05-31 15:24:44 +00002847 DieWithError('ERROR: Gerrit commit-msg hook not installed.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002848
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002849 def SetCQState(self, new_state):
2850 """Sets the Commit-Queue label assuming canonical CQ config for Gerrit."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002851 vote_map = {
2852 _CQState.NONE: 0,
2853 _CQState.DRY_RUN: 1,
Andrii Shyshkalov18975322017-01-25 16:44:13 +01002854 _CQState.COMMIT: 2,
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002855 }
Aaron Gablefc62f762017-07-17 11:12:07 -07002856 labels = {'Commit-Queue': vote_map[new_state]}
2857 notify = False if new_state == _CQState.DRY_RUN else None
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002858 gerrit_util.SetReview(
2859 self._GetGerritHost(), self._GerritChangeIdentifier(),
2860 labels=labels, notify=notify)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002861
tandriie113dfd2016-10-11 10:20:12 -07002862 def CannotTriggerTryJobReason(self):
tandrii8c5a3532016-11-04 07:52:02 -07002863 try:
2864 data = self._GetChangeDetail()
Aaron Gablea45ee112016-11-22 15:14:38 -08002865 except GerritChangeNotExists:
2866 return 'Gerrit doesn\'t know about your change %s' % self.GetIssue()
tandrii8c5a3532016-11-04 07:52:02 -07002867
2868 if data['status'] in ('ABANDONED', 'MERGED'):
2869 return 'CL %s is closed' % self.GetIssue()
2870
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002871 def GetTryJobProperties(self, patchset=None):
2872 """Returns dictionary of properties to launch try job."""
tandrii8c5a3532016-11-04 07:52:02 -07002873 data = self._GetChangeDetail(['ALL_REVISIONS'])
2874 patchset = int(patchset or self.GetPatchset())
2875 assert patchset
2876 revision_data = None # Pylint wants it to be defined.
2877 for revision_data in data['revisions'].itervalues():
2878 if int(revision_data['_number']) == patchset:
2879 break
2880 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08002881 raise Exception('Patchset %d is not known in Gerrit change %d' %
tandrii8c5a3532016-11-04 07:52:02 -07002882 (patchset, self.GetIssue()))
2883 return {
2884 'patch_issue': self.GetIssue(),
2885 'patch_set': patchset or self.GetPatchset(),
2886 'patch_project': data['project'],
2887 'patch_storage': 'gerrit',
2888 'patch_ref': revision_data['fetch']['http']['ref'],
2889 'patch_repository_url': revision_data['fetch']['http']['url'],
2890 'patch_gerrit_url': self.GetCodereviewServer(),
2891 }
tandriie113dfd2016-10-11 10:20:12 -07002892
tandriide281ae2016-10-12 06:02:30 -07002893 def GetIssueOwner(self):
tandrii8c5a3532016-11-04 07:52:02 -07002894 return self._GetChangeDetail(['DETAILED_ACCOUNTS'])['owner']['email']
tandriide281ae2016-10-12 06:02:30 -07002895
Edward Lemur707d70b2018-02-07 00:50:14 +01002896 def GetReviewers(self):
2897 details = self._GetChangeDetail(['DETAILED_ACCOUNTS'])
Mohamed Heikal171c0742018-11-09 20:38:51 +00002898 return [r['email'] for r in details['reviewers'].get('REVIEWER', [])]
Edward Lemur707d70b2018-02-07 00:50:14 +01002899
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002900
2901_CODEREVIEW_IMPLEMENTATIONS = {
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002902 'gerrit': _GerritChangelistImpl,
2903}
2904
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002905
iannuccie53c9352016-08-17 14:40:40 -07002906def _add_codereview_issue_select_options(parser, extra=""):
2907 _add_codereview_select_options(parser)
2908
2909 text = ('Operate on this issue number instead of the current branch\'s '
2910 'implicit issue.')
2911 if extra:
2912 text += ' '+extra
2913 parser.add_option('-i', '--issue', type=int, help=text)
2914
2915
2916def _process_codereview_issue_select_options(parser, options):
2917 _process_codereview_select_options(parser, options)
2918 if options.issue is not None and not options.forced_codereview:
2919 parser.error('--issue must be specified with either --rietveld or --gerrit')
2920
2921
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002922def _add_codereview_select_options(parser):
2923 """Appends --gerrit and --rietveld options to force specific codereview."""
2924 parser.codereview_group = optparse.OptionGroup(
2925 parser, 'EXPERIMENTAL! Codereview override options')
2926 parser.add_option_group(parser.codereview_group)
2927 parser.codereview_group.add_option(
2928 '--gerrit', action='store_true',
2929 help='Force the use of Gerrit for codereview')
2930 parser.codereview_group.add_option(
2931 '--rietveld', action='store_true',
2932 help='Force the use of Rietveld for codereview')
2933
2934
2935def _process_codereview_select_options(parser, options):
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002936 if options.rietveld:
2937 parser.error('--rietveld is no longer supported')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002938 options.forced_codereview = None
2939 if options.gerrit:
2940 options.forced_codereview = 'gerrit'
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002941
2942
tandriif9aefb72016-07-01 09:06:51 -07002943def _get_bug_line_values(default_project, bugs):
2944 """Given default_project and comma separated list of bugs, yields bug line
2945 values.
2946
2947 Each bug can be either:
2948 * a number, which is combined with default_project
2949 * string, which is left as is.
2950
2951 This function may produce more than one line, because bugdroid expects one
2952 project per line.
2953
2954 >>> list(_get_bug_line_values('v8', '123,chromium:789'))
2955 ['v8:123', 'chromium:789']
2956 """
2957 default_bugs = []
2958 others = []
2959 for bug in bugs.split(','):
2960 bug = bug.strip()
2961 if bug:
2962 try:
2963 default_bugs.append(int(bug))
2964 except ValueError:
2965 others.append(bug)
2966
2967 if default_bugs:
2968 default_bugs = ','.join(map(str, default_bugs))
2969 if default_project:
2970 yield '%s:%s' % (default_project, default_bugs)
2971 else:
2972 yield default_bugs
2973 for other in sorted(others):
2974 # Don't bother finding common prefixes, CLs with >2 bugs are very very rare.
2975 yield other
2976
2977
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002978class ChangeDescription(object):
2979 """Contains a parsed form of the change description."""
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00002980 R_LINE = r'^[ \t]*(TBR|R)[ \t]*=[ \t]*(.*?)[ \t]*$'
bradnelsond975b302016-10-23 12:20:23 -07002981 CC_LINE = r'^[ \t]*(CC)[ \t]*=[ \t]*(.*?)[ \t]*$'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002982 BUG_LINE = r'^[ \t]*(?:(BUG)[ \t]*=|Bug:)[ \t]*(.*?)[ \t]*$'
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002983 CHERRY_PICK_LINE = r'^\(cherry picked from commit [a-fA-F0-9]{40}\)$'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002984 STRIP_HASH_TAG_PREFIX = r'^(\s*(revert|reland)( "|:)?\s*)*'
2985 BRACKET_HASH_TAG = r'\s*\[([^\[\]]+)\]'
2986 COLON_SEPARATED_HASH_TAG = r'^([a-zA-Z0-9_\- ]+):'
2987 BAD_HASH_TAG_CHUNK = r'[^a-zA-Z0-9]+'
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002988
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002989 def __init__(self, description):
agable@chromium.org42c20792013-09-12 17:34:49 +00002990 self._description_lines = (description or '').strip().splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002991
agable@chromium.org42c20792013-09-12 17:34:49 +00002992 @property # www.logilab.org/ticket/89786
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08002993 def description(self): # pylint: disable=method-hidden
agable@chromium.org42c20792013-09-12 17:34:49 +00002994 return '\n'.join(self._description_lines)
2995
2996 def set_description(self, desc):
2997 if isinstance(desc, basestring):
2998 lines = desc.splitlines()
2999 else:
3000 lines = [line.rstrip() for line in desc]
3001 while lines and not lines[0]:
3002 lines.pop(0)
3003 while lines and not lines[-1]:
3004 lines.pop(-1)
3005 self._description_lines = lines
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003006
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003007 def update_reviewers(self, reviewers, tbrs, add_owners_to=None, change=None):
3008 """Rewrites the R=/TBR= line(s) as a single line each.
3009
3010 Args:
3011 reviewers (list(str)) - list of additional emails to use for reviewers.
3012 tbrs (list(str)) - list of additional emails to use for TBRs.
3013 add_owners_to (None|'R'|'TBR') - Pass to do an OWNERS lookup for files in
3014 the change that are missing OWNER coverage. If this is not None, you
3015 must also pass a value for `change`.
3016 change (Change) - The Change that should be used for OWNERS lookups.
3017 """
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003018 assert isinstance(reviewers, list), reviewers
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003019 assert isinstance(tbrs, list), tbrs
3020
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003021 assert add_owners_to in (None, 'TBR', 'R'), add_owners_to
Robert Iannuccia28592e2017-04-18 13:14:49 -07003022 assert not add_owners_to or change, add_owners_to
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003023
3024 if not reviewers and not tbrs and not add_owners_to:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003025 return
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003026
3027 reviewers = set(reviewers)
3028 tbrs = set(tbrs)
3029 LOOKUP = {
3030 'TBR': tbrs,
3031 'R': reviewers,
3032 }
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003033
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003034 # Get the set of R= and TBR= lines and remove them from the description.
agable@chromium.org42c20792013-09-12 17:34:49 +00003035 regexp = re.compile(self.R_LINE)
3036 matches = [regexp.match(line) for line in self._description_lines]
3037 new_desc = [l for i, l in enumerate(self._description_lines)
3038 if not matches[i]]
3039 self.set_description(new_desc)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003040
agable@chromium.org42c20792013-09-12 17:34:49 +00003041 # Construct new unified R= and TBR= lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003042
3043 # First, update tbrs/reviewers with names from the R=/TBR= lines (if any).
agable@chromium.org42c20792013-09-12 17:34:49 +00003044 for match in matches:
3045 if not match:
3046 continue
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003047 LOOKUP[match.group(1)].update(cleanup_list([match.group(2).strip()]))
3048
3049 # Next, maybe fill in OWNERS coverage gaps to either tbrs/reviewers.
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003050 if add_owners_to:
piman@chromium.org336f9122014-09-04 02:16:55 +00003051 owners_db = owners.Database(change.RepositoryRoot(),
Jochen Eisinger72606f82017-04-04 10:44:18 +02003052 fopen=file, os_path=os.path)
piman@chromium.org336f9122014-09-04 02:16:55 +00003053 missing_files = owners_db.files_not_covered_by(change.LocalPaths(),
Robert Iannucci100aa212017-04-18 17:28:26 -07003054 (tbrs | reviewers))
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003055 LOOKUP[add_owners_to].update(
3056 owners_db.reviewers_for(missing_files, change.author_email))
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003057
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003058 # If any folks ended up in both groups, remove them from tbrs.
3059 tbrs -= reviewers
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003060
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003061 new_r_line = 'R=' + ', '.join(sorted(reviewers)) if reviewers else None
3062 new_tbr_line = 'TBR=' + ', '.join(sorted(tbrs)) if tbrs else None
agable@chromium.org42c20792013-09-12 17:34:49 +00003063
3064 # Put the new lines in the description where the old first R= line was.
3065 line_loc = next((i for i, match in enumerate(matches) if match), -1)
3066 if 0 <= line_loc < len(self._description_lines):
3067 if new_tbr_line:
3068 self._description_lines.insert(line_loc, new_tbr_line)
3069 if new_r_line:
3070 self._description_lines.insert(line_loc, new_r_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003071 else:
agable@chromium.org42c20792013-09-12 17:34:49 +00003072 if new_r_line:
3073 self.append_footer(new_r_line)
3074 if new_tbr_line:
3075 self.append_footer(new_tbr_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003076
Aaron Gable3a16ed12017-03-23 10:51:55 -07003077 def prompt(self, bug=None, git_footer=True):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003078 """Asks the user to update the description."""
agable@chromium.org42c20792013-09-12 17:34:49 +00003079 self.set_description([
3080 '# Enter a description of the change.',
3081 '# This will be displayed on the codereview site.',
3082 '# The first line will also be used as the subject of the review.',
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +00003083 '#--------------------This line is 72 characters long'
agable@chromium.org42c20792013-09-12 17:34:49 +00003084 '--------------------',
3085 ] + self._description_lines)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003086
agable@chromium.org42c20792013-09-12 17:34:49 +00003087 regexp = re.compile(self.BUG_LINE)
Jonas Termansend0f79112019-03-22 15:28:26 +00003088 prefix = settings.GetBugPrefix()
agable@chromium.org42c20792013-09-12 17:34:49 +00003089 if not any((regexp.match(line) for line in self._description_lines)):
tandriif9aefb72016-07-01 09:06:51 -07003090 values = list(_get_bug_line_values(prefix, bug or '')) or [prefix]
Aaron Gable3a16ed12017-03-23 10:51:55 -07003091 if git_footer:
3092 self.append_footer('Bug: %s' % ', '.join(values))
3093 else:
3094 for value in values:
3095 self.append_footer('BUG=%s' % value)
tandriif9aefb72016-07-01 09:06:51 -07003096
agable@chromium.org42c20792013-09-12 17:34:49 +00003097 content = gclient_utils.RunEditor(self.description, True,
jbroman@chromium.org615a2622013-05-03 13:20:14 +00003098 git_editor=settings.GetGitEditor())
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00003099 if not content:
3100 DieWithError('Running editor failed')
agable@chromium.org42c20792013-09-12 17:34:49 +00003101 lines = content.splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003102
Bruce Dawson2377b012018-01-11 16:46:49 -08003103 # Strip off comments and default inserted "Bug:" line.
3104 clean_lines = [line.rstrip() for line in lines if not
Jonas Termansend0f79112019-03-22 15:28:26 +00003105 (line.startswith('#') or
3106 line.rstrip() == "Bug:" or
3107 line.rstrip() == "Bug: " + prefix)]
agable@chromium.org42c20792013-09-12 17:34:49 +00003108 if not clean_lines:
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00003109 DieWithError('No CL description, aborting')
agable@chromium.org42c20792013-09-12 17:34:49 +00003110 self.set_description(clean_lines)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003111
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003112 def append_footer(self, line):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00003113 """Adds a footer line to the description.
3114
3115 Differentiates legacy "KEY=xxx" footers (used to be called tags) and
3116 Gerrit's footers in the form of "Footer-Key: footer any value" and ensures
3117 that Gerrit footers are always at the end.
3118 """
3119 parsed_footer_line = git_footers.parse_footer(line)
3120 if parsed_footer_line:
3121 # Line is a gerrit footer in the form: Footer-Key: any value.
3122 # Thus, must be appended observing Gerrit footer rules.
3123 self.set_description(
3124 git_footers.add_footer(self.description,
3125 key=parsed_footer_line[0],
3126 value=parsed_footer_line[1]))
3127 return
3128
3129 if not self._description_lines:
3130 self._description_lines.append(line)
3131 return
3132
3133 top_lines, gerrit_footers, _ = git_footers.split_footers(self.description)
3134 if gerrit_footers:
3135 # git_footers.split_footers ensures that there is an empty line before
3136 # actual (gerrit) footers, if any. We have to keep it that way.
3137 assert top_lines and top_lines[-1] == ''
3138 top_lines, separator = top_lines[:-1], top_lines[-1:]
3139 else:
3140 separator = [] # No need for separator if there are no gerrit_footers.
3141
3142 prev_line = top_lines[-1] if top_lines else ''
3143 if (not presubmit_support.Change.TAG_LINE_RE.match(prev_line) or
3144 not presubmit_support.Change.TAG_LINE_RE.match(line)):
3145 top_lines.append('')
3146 top_lines.append(line)
3147 self._description_lines = top_lines + separator + gerrit_footers
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003148
tandrii99a72f22016-08-17 14:33:24 -07003149 def get_reviewers(self, tbr_only=False):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003150 """Retrieves the list of reviewers."""
agable@chromium.org42c20792013-09-12 17:34:49 +00003151 matches = [re.match(self.R_LINE, line) for line in self._description_lines]
tandrii99a72f22016-08-17 14:33:24 -07003152 reviewers = [match.group(2).strip()
3153 for match in matches
3154 if match and (not tbr_only or match.group(1).upper() == 'TBR')]
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003155 return cleanup_list(reviewers)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003156
bradnelsond975b302016-10-23 12:20:23 -07003157 def get_cced(self):
3158 """Retrieves the list of reviewers."""
3159 matches = [re.match(self.CC_LINE, line) for line in self._description_lines]
3160 cced = [match.group(2).strip() for match in matches if match]
3161 return cleanup_list(cced)
3162
Nodir Turakulov23b82142017-11-16 11:04:25 -08003163 def get_hash_tags(self):
3164 """Extracts and sanitizes a list of Gerrit hashtags."""
3165 subject = (self._description_lines or ('',))[0]
3166 subject = re.sub(
3167 self.STRIP_HASH_TAG_PREFIX, '', subject, flags=re.IGNORECASE)
3168
3169 tags = []
3170 start = 0
3171 bracket_exp = re.compile(self.BRACKET_HASH_TAG)
3172 while True:
3173 m = bracket_exp.match(subject, start)
3174 if not m:
3175 break
3176 tags.append(self.sanitize_hash_tag(m.group(1)))
3177 start = m.end()
3178
3179 if not tags:
3180 # Try "Tag: " prefix.
3181 m = re.match(self.COLON_SEPARATED_HASH_TAG, subject)
3182 if m:
3183 tags.append(self.sanitize_hash_tag(m.group(1)))
3184 return tags
3185
3186 @classmethod
3187 def sanitize_hash_tag(cls, tag):
3188 """Returns a sanitized Gerrit hash tag.
3189
3190 A sanitized hashtag can be used as a git push refspec parameter value.
3191 """
3192 return re.sub(cls.BAD_HASH_TAG_CHUNK, '-', tag).strip('-').lower()
3193
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003194 def update_with_git_number_footers(self, parent_hash, parent_msg, dest_ref):
3195 """Updates this commit description given the parent.
3196
3197 This is essentially what Gnumbd used to do.
3198 Consult https://goo.gl/WMmpDe for more details.
3199 """
3200 assert parent_msg # No, orphan branch creation isn't supported.
3201 assert parent_hash
3202 assert dest_ref
3203 parent_footer_map = git_footers.parse_footers(parent_msg)
3204 # This will also happily parse svn-position, which GnumbD is no longer
3205 # supporting. While we'd generate correct footers, the verifier plugin
3206 # installed in Gerrit will block such commit (ie git push below will fail).
3207 parent_position = git_footers.get_position(parent_footer_map)
3208
3209 # Cherry-picks may have last line obscuring their prior footers,
3210 # from git_footers perspective. This is also what Gnumbd did.
3211 cp_line = None
3212 if (self._description_lines and
3213 re.match(self.CHERRY_PICK_LINE, self._description_lines[-1])):
3214 cp_line = self._description_lines.pop()
3215
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003216 top_lines, footer_lines, _ = git_footers.split_footers(self.description)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003217
3218 # Original-ify all Cr- footers, to avoid re-lands, cherry-picks, or just
3219 # user interference with actual footers we'd insert below.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003220 for i, line in enumerate(footer_lines):
3221 k, v = git_footers.parse_footer(line) or (None, None)
3222 if k and k.startswith('Cr-'):
3223 footer_lines[i] = '%s: %s' % ('Cr-Original-' + k[len('Cr-'):], v)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003224
3225 # Add Position and Lineage footers based on the parent.
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +01003226 lineage = list(reversed(parent_footer_map.get('Cr-Branched-From', [])))
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003227 if parent_position[0] == dest_ref:
3228 # Same branch as parent.
3229 number = int(parent_position[1]) + 1
3230 else:
3231 number = 1 # New branch, and extra lineage.
3232 lineage.insert(0, '%s-%s@{#%d}' % (parent_hash, parent_position[0],
3233 int(parent_position[1])))
3234
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003235 footer_lines.append('Cr-Commit-Position: %s@{#%d}' % (dest_ref, number))
3236 footer_lines.extend('Cr-Branched-From: %s' % v for v in lineage)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003237
3238 self._description_lines = top_lines
3239 if cp_line:
3240 self._description_lines.append(cp_line)
3241 if self._description_lines[-1] != '':
3242 self._description_lines.append('') # Ensure footer separator.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003243 self._description_lines.extend(footer_lines)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003244
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003245
Aaron Gablea1bab272017-04-11 16:38:18 -07003246def get_approving_reviewers(props, disapproval=False):
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003247 """Retrieves the reviewers that approved a CL from the issue properties with
3248 messages.
3249
3250 Note that the list may contain reviewers that are not committer, thus are not
3251 considered by the CQ.
Aaron Gablea1bab272017-04-11 16:38:18 -07003252
3253 If disapproval is True, instead returns reviewers who 'not lgtm'd the CL.
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003254 """
Aaron Gablea1bab272017-04-11 16:38:18 -07003255 approval_type = 'disapproval' if disapproval else 'approval'
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003256 return sorted(
3257 set(
3258 message['sender']
3259 for message in props['messages']
Aaron Gablea1bab272017-04-11 16:38:18 -07003260 if message[approval_type] and message['sender'] in props['reviewers']
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003261 )
3262 )
3263
3264
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003265def FindCodereviewSettingsFile(filename='codereview.settings'):
3266 """Finds the given file starting in the cwd and going up.
3267
3268 Only looks up to the top of the repository unless an
3269 'inherit-review-settings-ok' file exists in the root of the repository.
3270 """
3271 inherit_ok_file = 'inherit-review-settings-ok'
3272 cwd = os.getcwd()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00003273 root = settings.GetRoot()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003274 if os.path.isfile(os.path.join(root, inherit_ok_file)):
3275 root = '/'
3276 while True:
3277 if filename in os.listdir(cwd):
3278 if os.path.isfile(os.path.join(cwd, filename)):
3279 return open(os.path.join(cwd, filename))
3280 if cwd == root:
3281 break
3282 cwd = os.path.dirname(cwd)
3283
3284
3285def LoadCodereviewSettingsFromFile(fileobj):
3286 """Parse a codereview.settings file and updates hooks."""
maruel@chromium.org99ac1c52012-01-16 14:52:12 +00003287 keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003288
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003289 def SetProperty(name, setting, unset_error_ok=False):
3290 fullname = 'rietveld.' + name
3291 if setting in keyvals:
3292 RunGit(['config', fullname, keyvals[setting]])
3293 else:
3294 RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok)
3295
tandrii48df5812016-10-17 03:55:37 -07003296 if not keyvals.get('GERRIT_HOST', False):
3297 SetProperty('server', 'CODE_REVIEW_SERVER')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003298 # Only server setting is required. Other settings can be absent.
3299 # In that case, we ignore errors raised during option deletion attempt.
3300 SetProperty('cc', 'CC_LIST', unset_error_ok=True)
3301 SetProperty('tree-status-url', 'STATUS', unset_error_ok=True)
3302 SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True)
rmistry@google.com90752582014-01-14 21:04:50 +00003303 SetProperty('bug-prefix', 'BUG_PREFIX', unset_error_ok=True)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003304 SetProperty('cpplint-regex', 'LINT_REGEX', unset_error_ok=True)
3305 SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +00003306 SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK',
3307 unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003308
ukai@chromium.org7044efc2013-11-28 01:51:21 +00003309 if 'GERRIT_HOST' in keyvals:
ukai@chromium.orge8077812012-02-03 03:41:46 +00003310 RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']])
ukai@chromium.orge8077812012-02-03 03:41:46 +00003311
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003312 if 'GERRIT_SQUASH_UPLOADS' in keyvals:
tandrii8dd81ea2016-06-16 13:24:23 -07003313 RunGit(['config', 'gerrit.squash-uploads',
3314 keyvals['GERRIT_SQUASH_UPLOADS']])
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003315
tandrii@chromium.org28253532016-04-14 13:46:56 +00003316 if 'GERRIT_SKIP_ENSURE_AUTHENTICATED' in keyvals:
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00003317 RunGit(['config', 'gerrit.skip-ensure-authenticated',
tandrii@chromium.org28253532016-04-14 13:46:56 +00003318 keyvals['GERRIT_SKIP_ENSURE_AUTHENTICATED']])
3319
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003320 if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01003321 # should be of the form
3322 # PUSH_URL_CONFIG: url.ssh://gitrw.chromium.org.pushinsteadof
3323 # ORIGIN_URL_CONFIG: http://src.chromium.org/git
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003324 RunGit(['config', keyvals['PUSH_URL_CONFIG'],
3325 keyvals['ORIGIN_URL_CONFIG']])
3326
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003327
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003328def urlretrieve(source, destination):
3329 """urllib is broken for SSL connections via a proxy therefore we
3330 can't use urllib.urlretrieve()."""
3331 with open(destination, 'w') as f:
3332 f.write(urllib2.urlopen(source).read())
3333
3334
ukai@chromium.org712d6102013-11-27 00:52:58 +00003335def hasSheBang(fname):
3336 """Checks fname is a #! script."""
3337 with open(fname) as f:
3338 return f.read(2).startswith('#!')
3339
3340
bpastene@chromium.org917f0ff2016-04-05 00:45:30 +00003341# TODO(bpastene) Remove once a cleaner fix to crbug.com/600473 presents itself.
3342def DownloadHooks(*args, **kwargs):
3343 pass
3344
3345
tandrii@chromium.org18630d62016-03-04 12:06:02 +00003346def DownloadGerritHook(force):
3347 """Download and install Gerrit commit-msg hook.
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003348
3349 Args:
3350 force: True to update hooks. False to install hooks if not present.
3351 """
3352 if not settings.GetIsGerrit():
3353 return
ukai@chromium.org712d6102013-11-27 00:52:58 +00003354 src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg'
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003355 dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
3356 if not os.access(dst, os.X_OK):
3357 if os.path.exists(dst):
3358 if not force:
3359 return
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003360 try:
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003361 urlretrieve(src, dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003362 if not hasSheBang(dst):
3363 DieWithError('Not a script: %s\n'
3364 'You need to download from\n%s\n'
3365 'into .git/hooks/commit-msg and '
3366 'chmod +x .git/hooks/commit-msg' % (dst, src))
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003367 os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
3368 except Exception:
3369 if os.path.exists(dst):
3370 os.remove(dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003371 DieWithError('\nFailed to download hooks.\n'
3372 'You need to download from\n%s\n'
3373 'into .git/hooks/commit-msg and '
3374 'chmod +x .git/hooks/commit-msg' % src)
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003375
3376
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003377class _GitCookiesChecker(object):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003378 """Provides facilities for validating and suggesting fixes to .gitcookies."""
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003379
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003380 _GOOGLESOURCE = 'googlesource.com'
3381
3382 def __init__(self):
3383 # Cached list of [host, identity, source], where source is either
3384 # .gitcookies or .netrc.
3385 self._all_hosts = None
3386
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003387 def ensure_configured_gitcookies(self):
3388 """Runs checks and suggests fixes to make git use .gitcookies from default
3389 path."""
3390 default = gerrit_util.CookiesAuthenticator.get_gitcookies_path()
3391 configured_path = RunGitSilent(
3392 ['config', '--global', 'http.cookiefile']).strip()
Andrii Shyshkalov1e250cd2017-05-10 15:39:31 +02003393 configured_path = os.path.expanduser(configured_path)
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003394 if configured_path:
3395 self._ensure_default_gitcookies_path(configured_path, default)
3396 else:
3397 self._configure_gitcookies_path(default)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003398
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003399 @staticmethod
3400 def _ensure_default_gitcookies_path(configured_path, default_path):
3401 assert configured_path
3402 if configured_path == default_path:
3403 print('git is already configured to use your .gitcookies from %s' %
3404 configured_path)
3405 return
3406
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003407 print('WARNING: You have configured custom path to .gitcookies: %s\n'
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003408 'Gerrit and other depot_tools expect .gitcookies at %s\n' %
3409 (configured_path, default_path))
3410
3411 if not os.path.exists(configured_path):
3412 print('However, your configured .gitcookies file is missing.')
3413 confirm_or_exit('Reconfigure git to use default .gitcookies?',
3414 action='reconfigure')
3415 RunGit(['config', '--global', 'http.cookiefile', default_path])
3416 return
3417
3418 if os.path.exists(default_path):
3419 print('WARNING: default .gitcookies file already exists %s' %
3420 default_path)
3421 DieWithError('Please delete %s manually and re-run git cl creds-check' %
3422 default_path)
3423
3424 confirm_or_exit('Move existing .gitcookies to default location?',
3425 action='move')
3426 shutil.move(configured_path, default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003427 RunGit(['config', '--global', 'http.cookiefile', default_path])
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003428 print('Moved and reconfigured git to use .gitcookies from %s' %
3429 default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003430
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003431 @staticmethod
3432 def _configure_gitcookies_path(default_path):
3433 netrc_path = gerrit_util.CookiesAuthenticator.get_netrc_path()
3434 if os.path.exists(netrc_path):
3435 print('You seem to be using outdated .netrc for git credentials: %s' %
3436 netrc_path)
3437 print('This tool will guide you through setting up recommended '
3438 '.gitcookies store for git credentials.\n'
3439 '\n'
3440 'IMPORTANT: If something goes wrong and you decide to go back, do:\n'
3441 ' git config --global --unset http.cookiefile\n'
3442 ' mv %s %s.backup\n\n' % (default_path, default_path))
3443 confirm_or_exit(action='setup .gitcookies')
3444 RunGit(['config', '--global', 'http.cookiefile', default_path])
3445 print('Configured git to use .gitcookies from %s' % default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003446
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003447 def get_hosts_with_creds(self, include_netrc=False):
3448 if self._all_hosts is None:
3449 a = gerrit_util.CookiesAuthenticator()
3450 self._all_hosts = [
3451 (h, u, s)
3452 for h, u, s in itertools.chain(
3453 ((h, u, '.netrc') for h, (u, _, _) in a.netrc.hosts.iteritems()),
3454 ((h, u, '.gitcookies') for h, (u, _) in a.gitcookies.iteritems())
3455 )
3456 if h.endswith(self._GOOGLESOURCE)
3457 ]
3458
3459 if include_netrc:
3460 return self._all_hosts
3461 return [(h, u, s) for h, u, s in self._all_hosts if s != '.netrc']
3462
3463 def print_current_creds(self, include_netrc=False):
3464 hosts = sorted(self.get_hosts_with_creds(include_netrc=include_netrc))
3465 if not hosts:
3466 print('No Git/Gerrit credentials found')
3467 return
3468 lengths = [max(map(len, (row[i] for row in hosts))) for i in xrange(3)]
3469 header = [('Host', 'User', 'Which file'),
3470 ['=' * l for l in lengths]]
3471 for row in (header + hosts):
3472 print('\t'.join((('%%+%ds' % l) % s)
3473 for l, s in zip(lengths, row)))
3474
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003475 @staticmethod
3476 def _parse_identity(identity):
Lei Zhangd3f769a2017-12-15 15:16:14 -08003477 """Parses identity "git-<username>.domain" into <username> and domain."""
3478 # Special case: usernames that contain ".", which are generally not
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02003479 # distinguishable from sub-domains. But we do know typical domains:
3480 if identity.endswith('.chromium.org'):
3481 domain = 'chromium.org'
3482 username = identity[:-len('.chromium.org')]
3483 else:
3484 username, domain = identity.split('.', 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003485 if username.startswith('git-'):
3486 username = username[len('git-'):]
3487 return username, domain
3488
3489 def _get_usernames_of_domain(self, domain):
3490 """Returns list of usernames referenced by .gitcookies in a given domain."""
3491 identities_by_domain = {}
3492 for _, identity, _ in self.get_hosts_with_creds():
3493 username, domain = self._parse_identity(identity)
3494 identities_by_domain.setdefault(domain, []).append(username)
3495 return identities_by_domain.get(domain)
3496
3497 def _canonical_git_googlesource_host(self, host):
3498 """Normalizes Gerrit hosts (with '-review') to Git host."""
3499 assert host.endswith(self._GOOGLESOURCE)
3500 # Prefix doesn't include '.' at the end.
3501 prefix = host[:-(1 + len(self._GOOGLESOURCE))]
3502 if prefix.endswith('-review'):
3503 prefix = prefix[:-len('-review')]
3504 return prefix + '.' + self._GOOGLESOURCE
3505
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003506 def _canonical_gerrit_googlesource_host(self, host):
3507 git_host = self._canonical_git_googlesource_host(host)
3508 prefix = git_host.split('.', 1)[0]
3509 return prefix + '-review.' + self._GOOGLESOURCE
3510
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003511 def _get_counterpart_host(self, host):
3512 assert host.endswith(self._GOOGLESOURCE)
3513 git = self._canonical_git_googlesource_host(host)
3514 gerrit = self._canonical_gerrit_googlesource_host(git)
3515 return git if gerrit == host else gerrit
3516
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003517 def has_generic_host(self):
3518 """Returns whether generic .googlesource.com has been configured.
3519
3520 Chrome Infra recommends to use explicit ${host}.googlesource.com instead.
3521 """
3522 for host, _, _ in self.get_hosts_with_creds(include_netrc=False):
3523 if host == '.' + self._GOOGLESOURCE:
3524 return True
3525 return False
3526
3527 def _get_git_gerrit_identity_pairs(self):
3528 """Returns map from canonic host to pair of identities (Git, Gerrit).
3529
3530 One of identities might be None, meaning not configured.
3531 """
3532 host_to_identity_pairs = {}
3533 for host, identity, _ in self.get_hosts_with_creds():
3534 canonical = self._canonical_git_googlesource_host(host)
3535 pair = host_to_identity_pairs.setdefault(canonical, [None, None])
3536 idx = 0 if canonical == host else 1
3537 pair[idx] = identity
3538 return host_to_identity_pairs
3539
3540 def get_partially_configured_hosts(self):
3541 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003542 (host if i1 else self._canonical_gerrit_googlesource_host(host))
3543 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().iteritems()
3544 if None in (i1, i2) and host != '.' + self._GOOGLESOURCE)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003545
3546 def get_conflicting_hosts(self):
3547 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003548 host
3549 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().iteritems()
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003550 if None not in (i1, i2) and i1 != i2)
3551
3552 def get_duplicated_hosts(self):
3553 counters = collections.Counter(h for h, _, _ in self.get_hosts_with_creds())
3554 return set(host for host, count in counters.iteritems() if count > 1)
3555
3556 _EXPECTED_HOST_IDENTITY_DOMAINS = {
3557 'chromium.googlesource.com': 'chromium.org',
3558 'chrome-internal.googlesource.com': 'google.com',
3559 }
3560
3561 def get_hosts_with_wrong_identities(self):
3562 """Finds hosts which **likely** reference wrong identities.
3563
3564 Note: skips hosts which have conflicting identities for Git and Gerrit.
3565 """
3566 hosts = set()
3567 for host, expected in self._EXPECTED_HOST_IDENTITY_DOMAINS.iteritems():
3568 pair = self._get_git_gerrit_identity_pairs().get(host)
3569 if pair and pair[0] == pair[1]:
3570 _, domain = self._parse_identity(pair[0])
3571 if domain != expected:
3572 hosts.add(host)
3573 return hosts
3574
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003575 @staticmethod
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003576 def _format_hosts(hosts, extra_column_func=None):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003577 hosts = sorted(hosts)
3578 assert hosts
3579 if extra_column_func is None:
3580 extras = [''] * len(hosts)
3581 else:
3582 extras = [extra_column_func(host) for host in hosts]
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003583 tmpl = '%%-%ds %%-%ds' % (max(map(len, hosts)), max(map(len, extras)))
3584 lines = []
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003585 for he in zip(hosts, extras):
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003586 lines.append(tmpl % he)
3587 return lines
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003588
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003589 def _find_problems(self):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003590 if self.has_generic_host():
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003591 yield ('.googlesource.com wildcard record detected',
3592 ['Chrome Infrastructure team recommends to list full host names '
3593 'explicitly.'],
3594 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003595
3596 dups = self.get_duplicated_hosts()
3597 if dups:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003598 yield ('The following hosts were defined twice',
3599 self._format_hosts(dups),
3600 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003601
3602 partial = self.get_partially_configured_hosts()
3603 if partial:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003604 yield ('Credentials should come in pairs for Git and Gerrit hosts. '
3605 'These hosts are missing',
3606 self._format_hosts(partial, lambda host: 'but %s defined' %
3607 self._get_counterpart_host(host)),
3608 partial)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003609
3610 conflicting = self.get_conflicting_hosts()
3611 if conflicting:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003612 yield ('The following Git hosts have differing credentials from their '
3613 'Gerrit counterparts',
3614 self._format_hosts(conflicting, lambda host: '%s vs %s' %
3615 tuple(self._get_git_gerrit_identity_pairs()[host])),
3616 conflicting)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003617
3618 wrong = self.get_hosts_with_wrong_identities()
3619 if wrong:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003620 yield ('These hosts likely use wrong identity',
3621 self._format_hosts(wrong, lambda host: '%s but %s recommended' %
3622 (self._get_git_gerrit_identity_pairs()[host][0],
3623 self._EXPECTED_HOST_IDENTITY_DOMAINS[host])),
3624 wrong)
3625
3626 def find_and_report_problems(self):
3627 """Returns True if there was at least one problem, else False."""
3628 found = False
3629 bad_hosts = set()
3630 for title, sublines, hosts in self._find_problems():
3631 if not found:
3632 found = True
3633 print('\n\n.gitcookies problem report:\n')
3634 bad_hosts.update(hosts or [])
3635 print(' %s%s' % (title , (':' if sublines else '')))
3636 if sublines:
3637 print()
3638 print(' %s' % '\n '.join(sublines))
3639 print()
3640
3641 if bad_hosts:
3642 assert found
3643 print(' You can manually remove corresponding lines in your %s file and '
3644 'visit the following URLs with correct account to generate '
3645 'correct credential lines:\n' %
3646 gerrit_util.CookiesAuthenticator.get_gitcookies_path())
3647 print(' %s' % '\n '.join(sorted(set(
3648 gerrit_util.CookiesAuthenticator().get_new_password_url(
3649 self._canonical_git_googlesource_host(host))
3650 for host in bad_hosts
3651 ))))
3652 return found
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003653
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003654
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003655@metrics.collector.collect_metrics('git cl creds-check')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003656def CMDcreds_check(parser, args):
3657 """Checks credentials and suggests changes."""
3658 _, _ = parser.parse_args(args)
3659
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003660 # Code below checks .gitcookies. Abort if using something else.
3661 authn = gerrit_util.Authenticator.get()
3662 if not isinstance(authn, gerrit_util.CookiesAuthenticator):
3663 if isinstance(authn, gerrit_util.GceAuthenticator):
3664 DieWithError(
3665 'This command is not designed for GCE, are you on a bot?\n'
3666 'If you need to run this on GCE, export SKIP_GCE_AUTH_FOR_GIT=1 '
3667 'in your env.')
Aaron Gabled10ca0e2017-09-11 11:24:10 -07003668 DieWithError(
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003669 'This command is not designed for bot environment. It checks '
3670 '~/.gitcookies file not generally used on bots.')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003671
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003672 checker = _GitCookiesChecker()
3673 checker.ensure_configured_gitcookies()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003674
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003675 print('Your .netrc and .gitcookies have credentials for these hosts:')
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003676 checker.print_current_creds(include_netrc=True)
3677
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003678 if not checker.find_and_report_problems():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003679 print('\nNo problems detected in your .gitcookies file.')
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003680 return 0
3681 return 1
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003682
3683
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003684@metrics.collector.collect_metrics('git cl baseurl')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003685def CMDbaseurl(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003686 """Gets or sets base-url for this branch."""
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003687 branchref = RunGit(['symbolic-ref', 'HEAD']).strip()
3688 branch = ShortBranchName(branchref)
3689 _, args = parser.parse_args(args)
3690 if not args:
vapiera7fbd5a2016-06-16 09:17:49 -07003691 print('Current base-url:')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003692 return RunGit(['config', 'branch.%s.base-url' % branch],
3693 error_ok=False).strip()
3694 else:
vapiera7fbd5a2016-06-16 09:17:49 -07003695 print('Setting base-url to %s' % args[0])
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003696 return RunGit(['config', 'branch.%s.base-url' % branch, args[0]],
3697 error_ok=False).strip()
3698
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003699def color_for_status(status):
3700 """Maps a Changelist status to color, for CMDstatus and other tools."""
3701 return {
Aaron Gable9ab38c62017-04-06 14:36:33 -07003702 'unsent': Fore.YELLOW,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003703 'waiting': Fore.BLUE,
3704 'reply': Fore.YELLOW,
Aaron Gable9ab38c62017-04-06 14:36:33 -07003705 'not lgtm': Fore.RED,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003706 'lgtm': Fore.GREEN,
3707 'commit': Fore.MAGENTA,
3708 'closed': Fore.CYAN,
3709 'error': Fore.WHITE,
3710 }.get(status, Fore.WHITE)
3711
tandrii@chromium.org04ea8462016-04-25 19:51:21 +00003712
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003713def get_cl_statuses(changes, fine_grained, max_processes=None):
3714 """Returns a blocking iterable of (cl, status) for given branches.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003715
3716 If fine_grained is true, this will fetch CL statuses from the server.
3717 Otherwise, simply indicate if there's a matching url for the given branches.
3718
3719 If max_processes is specified, it is used as the maximum number of processes
3720 to spawn to fetch CL status from the server. Otherwise 1 process per branch is
3721 spawned.
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003722
3723 See GetStatus() for a list of possible statuses.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003724 """
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003725 if not changes:
3726 raise StopIteration()
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003727
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003728 if not fine_grained:
3729 # Fast path which doesn't involve querying codereview servers.
Aaron Gablea1bab272017-04-11 16:38:18 -07003730 # Do not use get_approving_reviewers(), since it requires an HTTP request.
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003731 for cl in changes:
3732 yield (cl, 'waiting' if cl.GetIssueURL() else 'error')
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003733 return
3734
3735 # First, sort out authentication issues.
3736 logging.debug('ensuring credentials exist')
3737 for cl in changes:
3738 cl.EnsureAuthenticated(force=False, refresh=True)
3739
3740 def fetch(cl):
3741 try:
3742 return (cl, cl.GetStatus())
3743 except:
3744 # See http://crbug.com/629863.
Andrii Shyshkalov98824232018-04-19 11:37:15 -07003745 logging.exception('failed to fetch status for cl %s:', cl.GetIssue())
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003746 raise
3747
3748 threads_count = len(changes)
3749 if max_processes:
3750 threads_count = max(1, min(threads_count, max_processes))
3751 logging.debug('querying %d CLs using %d threads', len(changes), threads_count)
3752
3753 pool = ThreadPool(threads_count)
3754 fetched_cls = set()
3755 try:
3756 it = pool.imap_unordered(fetch, changes).__iter__()
3757 while True:
3758 try:
3759 cl, status = it.next(timeout=5)
3760 except multiprocessing.TimeoutError:
3761 break
3762 fetched_cls.add(cl)
3763 yield cl, status
3764 finally:
3765 pool.close()
3766
3767 # Add any branches that failed to fetch.
3768 for cl in set(changes) - fetched_cls:
3769 yield (cl, 'error')
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003770
rmistry@google.com2dd99862015-06-22 12:22:18 +00003771
3772def upload_branch_deps(cl, args):
3773 """Uploads CLs of local branches that are dependents of the current branch.
3774
3775 If the local branch dependency tree looks like:
3776 test1 -> test2.1 -> test3.1
3777 -> test3.2
3778 -> test2.2 -> test3.3
3779
3780 and you run "git cl upload --dependencies" from test1 then "git cl upload" is
3781 run on the dependent branches in this order:
3782 test2.1, test3.1, test3.2, test2.2, test3.3
3783
3784 Note: This function does not rebase your local dependent branches. Use it when
3785 you make a change to the parent branch that will not conflict with its
3786 dependent branches, and you would like their dependencies updated in
3787 Rietveld.
3788 """
3789 if git_common.is_dirty_git_tree('upload-branch-deps'):
3790 return 1
3791
3792 root_branch = cl.GetBranch()
3793 if root_branch is None:
3794 DieWithError('Can\'t find dependent branches from detached HEAD state. '
3795 'Get on a branch!')
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00003796 if not cl.GetIssue():
rmistry@google.com2dd99862015-06-22 12:22:18 +00003797 DieWithError('Current branch does not have an uploaded CL. We cannot set '
3798 'patchset dependencies without an uploaded CL.')
3799
3800 branches = RunGit(['for-each-ref',
3801 '--format=%(refname:short) %(upstream:short)',
3802 'refs/heads'])
3803 if not branches:
3804 print('No local branches found.')
3805 return 0
3806
3807 # Create a dictionary of all local branches to the branches that are dependent
3808 # on it.
3809 tracked_to_dependents = collections.defaultdict(list)
3810 for b in branches.splitlines():
3811 tokens = b.split()
3812 if len(tokens) == 2:
3813 branch_name, tracked = tokens
3814 tracked_to_dependents[tracked].append(branch_name)
3815
vapiera7fbd5a2016-06-16 09:17:49 -07003816 print()
3817 print('The dependent local branches of %s are:' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003818 dependents = []
3819 def traverse_dependents_preorder(branch, padding=''):
3820 dependents_to_process = tracked_to_dependents.get(branch, [])
3821 padding += ' '
3822 for dependent in dependents_to_process:
vapiera7fbd5a2016-06-16 09:17:49 -07003823 print('%s%s' % (padding, dependent))
rmistry@google.com2dd99862015-06-22 12:22:18 +00003824 dependents.append(dependent)
3825 traverse_dependents_preorder(dependent, padding)
3826 traverse_dependents_preorder(root_branch)
vapiera7fbd5a2016-06-16 09:17:49 -07003827 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003828
3829 if not dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003830 print('There are no dependent local branches for %s' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003831 return 0
3832
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01003833 confirm_or_exit('This command will checkout all dependent branches and run '
3834 '"git cl upload".', action='continue')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003835
rmistry@google.com2dd99862015-06-22 12:22:18 +00003836 # Record all dependents that failed to upload.
3837 failures = {}
3838 # Go through all dependents, checkout the branch and upload.
3839 try:
3840 for dependent_branch in dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003841 print()
3842 print('--------------------------------------')
3843 print('Running "git cl upload" from %s:' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003844 RunGit(['checkout', '-q', dependent_branch])
vapiera7fbd5a2016-06-16 09:17:49 -07003845 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003846 try:
3847 if CMDupload(OptionParser(), args) != 0:
vapiera7fbd5a2016-06-16 09:17:49 -07003848 print('Upload failed for %s!' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003849 failures[dependent_branch] = 1
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003850 except: # pylint: disable=bare-except
rmistry@google.com2dd99862015-06-22 12:22:18 +00003851 failures[dependent_branch] = 1
vapiera7fbd5a2016-06-16 09:17:49 -07003852 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003853 finally:
3854 # Swap back to the original root branch.
3855 RunGit(['checkout', '-q', root_branch])
3856
vapiera7fbd5a2016-06-16 09:17:49 -07003857 print()
3858 print('Upload complete for dependent branches!')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003859 for dependent_branch in dependents:
3860 upload_status = 'failed' if failures.get(dependent_branch) else 'succeeded'
vapiera7fbd5a2016-06-16 09:17:49 -07003861 print(' %s : %s' % (dependent_branch, upload_status))
3862 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003863
3864 return 0
3865
3866
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003867@metrics.collector.collect_metrics('git cl archive')
kmarshall3bff56b2016-06-06 18:31:47 -07003868def CMDarchive(parser, args):
3869 """Archives and deletes branches associated with closed changelists."""
3870 parser.add_option(
3871 '-j', '--maxjobs', action='store', type=int,
kmarshall9249e012016-08-23 12:02:16 -07003872 help='The maximum number of jobs to use when retrieving review status.')
kmarshall3bff56b2016-06-06 18:31:47 -07003873 parser.add_option(
3874 '-f', '--force', action='store_true',
3875 help='Bypasses the confirmation prompt.')
kmarshall9249e012016-08-23 12:02:16 -07003876 parser.add_option(
3877 '-d', '--dry-run', action='store_true',
3878 help='Skip the branch tagging and removal steps.')
3879 parser.add_option(
3880 '-t', '--notags', action='store_true',
3881 help='Do not tag archived branches. '
3882 'Note: local commit history may be lost.')
kmarshall3bff56b2016-06-06 18:31:47 -07003883
3884 auth.add_auth_options(parser)
3885 options, args = parser.parse_args(args)
3886 if args:
3887 parser.error('Unsupported args: %s' % ' '.join(args))
3888 auth_config = auth.extract_auth_config_from_options(options)
3889
3890 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
3891 if not branches:
3892 return 0
3893
vapiera7fbd5a2016-06-16 09:17:49 -07003894 print('Finding all branches associated with closed issues...')
kmarshall3bff56b2016-06-06 18:31:47 -07003895 changes = [Changelist(branchref=b, auth_config=auth_config)
3896 for b in branches.splitlines()]
3897 alignment = max(5, max(len(c.GetBranch()) for c in changes))
3898 statuses = get_cl_statuses(changes,
3899 fine_grained=True,
3900 max_processes=options.maxjobs)
3901 proposal = [(cl.GetBranch(),
3902 'git-cl-archived-%s-%s' % (cl.GetIssue(), cl.GetBranch()))
3903 for cl, status in statuses
Andrii Shyshkalov51bdf8c2018-10-18 01:07:58 +00003904 if status in ('closed', 'rietveld-not-supported')]
kmarshall3bff56b2016-06-06 18:31:47 -07003905 proposal.sort()
3906
3907 if not proposal:
vapiera7fbd5a2016-06-16 09:17:49 -07003908 print('No branches with closed codereview issues found.')
kmarshall3bff56b2016-06-06 18:31:47 -07003909 return 0
3910
3911 current_branch = GetCurrentBranch()
3912
vapiera7fbd5a2016-06-16 09:17:49 -07003913 print('\nBranches with closed issues that will be archived:\n')
kmarshall9249e012016-08-23 12:02:16 -07003914 if options.notags:
3915 for next_item in proposal:
3916 print(' ' + next_item[0])
3917 else:
3918 print('%*s | %s' % (alignment, 'Branch name', 'Archival tag name'))
3919 for next_item in proposal:
3920 print('%*s %s' % (alignment, next_item[0], next_item[1]))
kmarshall3bff56b2016-06-06 18:31:47 -07003921
kmarshall9249e012016-08-23 12:02:16 -07003922 # Quit now on precondition failure or if instructed by the user, either
3923 # via an interactive prompt or by command line flags.
3924 if options.dry_run:
3925 print('\nNo changes were made (dry run).\n')
3926 return 0
3927 elif any(branch == current_branch for branch, _ in proposal):
kmarshall3bff56b2016-06-06 18:31:47 -07003928 print('You are currently on a branch \'%s\' which is associated with a '
3929 'closed codereview issue, so archive cannot proceed. Please '
3930 'checkout another branch and run this command again.' %
3931 current_branch)
3932 return 1
kmarshall9249e012016-08-23 12:02:16 -07003933 elif not options.force:
sergiyb4a5ecbe2016-06-20 09:46:00 -07003934 answer = ask_for_data('\nProceed with deletion (Y/n)? ').lower()
3935 if answer not in ('y', ''):
vapiera7fbd5a2016-06-16 09:17:49 -07003936 print('Aborted.')
kmarshall3bff56b2016-06-06 18:31:47 -07003937 return 1
3938
3939 for branch, tagname in proposal:
kmarshall9249e012016-08-23 12:02:16 -07003940 if not options.notags:
3941 RunGit(['tag', tagname, branch])
kmarshall3bff56b2016-06-06 18:31:47 -07003942 RunGit(['branch', '-D', branch])
kmarshall9249e012016-08-23 12:02:16 -07003943
vapiera7fbd5a2016-06-16 09:17:49 -07003944 print('\nJob\'s done!')
kmarshall3bff56b2016-06-06 18:31:47 -07003945
3946 return 0
3947
3948
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003949@metrics.collector.collect_metrics('git cl status')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003950def CMDstatus(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003951 """Show status of changelists.
3952
3953 Colors are used to tell the state of the CL unless --fast is used:
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003954 - Blue waiting for review
Aaron Gable9ab38c62017-04-06 14:36:33 -07003955 - Yellow waiting for you to reply to review, or not yet sent
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003956 - Green LGTM'ed
Aaron Gable9ab38c62017-04-06 14:36:33 -07003957 - Red 'not LGTM'ed
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003958 - Magenta in the commit queue
3959 - Cyan was committed, branch can be deleted
Aaron Gable9ab38c62017-04-06 14:36:33 -07003960 - White error, or unknown status
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003961
3962 Also see 'git cl comments'.
3963 """
Alan Cuttera3be9a52019-03-04 18:50:33 +00003964 parser.add_option(
3965 '--no-branch-color',
3966 action='store_true',
3967 help='Disable colorized branch names')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003968 parser.add_option('--field',
phajdan.jr289d03e2016-08-16 08:21:06 -07003969 help='print only specific field (desc|id|patch|status|url)')
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003970 parser.add_option('-f', '--fast', action='store_true',
3971 help='Do not retrieve review status')
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003972 parser.add_option(
3973 '-j', '--maxjobs', action='store', type=int,
3974 help='The maximum number of jobs to use when retrieving review status')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003975
3976 auth.add_auth_options(parser)
iannuccie53c9352016-08-17 14:40:40 -07003977 _add_codereview_issue_select_options(
3978 parser, 'Must be in conjunction with --field.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003979 options, args = parser.parse_args(args)
iannuccie53c9352016-08-17 14:40:40 -07003980 _process_codereview_issue_select_options(parser, options)
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003981 if args:
3982 parser.error('Unsupported args: %s' % args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003983 auth_config = auth.extract_auth_config_from_options(options)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003984
iannuccie53c9352016-08-17 14:40:40 -07003985 if options.issue is not None and not options.field:
3986 parser.error('--field must be specified with --issue')
iannucci3c972b92016-08-17 13:24:10 -07003987
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003988 if options.field:
iannucci3c972b92016-08-17 13:24:10 -07003989 cl = Changelist(auth_config=auth_config, issue=options.issue,
3990 codereview=options.forced_codereview)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003991 if options.field.startswith('desc'):
vapiera7fbd5a2016-06-16 09:17:49 -07003992 print(cl.GetDescription())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003993 elif options.field == 'id':
3994 issueid = cl.GetIssue()
3995 if issueid:
vapiera7fbd5a2016-06-16 09:17:49 -07003996 print(issueid)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003997 elif options.field == 'patch':
Aaron Gablee8856ee2017-12-07 12:41:46 -08003998 patchset = cl.GetMostRecentPatchset()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003999 if patchset:
vapiera7fbd5a2016-06-16 09:17:49 -07004000 print(patchset)
phajdan.jr289d03e2016-08-16 08:21:06 -07004001 elif options.field == 'status':
4002 print(cl.GetStatus())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004003 elif options.field == 'url':
4004 url = cl.GetIssueURL()
4005 if url:
vapiera7fbd5a2016-06-16 09:17:49 -07004006 print(url)
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00004007 return 0
4008
4009 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
4010 if not branches:
4011 print('No local branch found.')
4012 return 0
4013
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004014 changes = [
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004015 Changelist(branchref=b, auth_config=auth_config)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004016 for b in branches.splitlines()]
vapiera7fbd5a2016-06-16 09:17:49 -07004017 print('Branches associated with reviews:')
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004018 output = get_cl_statuses(changes,
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004019 fine_grained=not options.fast,
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004020 max_processes=options.maxjobs)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00004021
Daniel McArdlea23bf592019-02-12 00:25:12 +00004022 current_branch = GetCurrentBranch()
4023
4024 def FormatBranchName(branch, colorize=False):
4025 """Simulates 'git branch' behavior. Colorizes and prefixes branch name with
4026 an asterisk when it is the current branch."""
4027
4028 asterisk = ""
4029 color = Fore.RESET
4030 if branch == current_branch:
4031 asterisk = "* "
4032 color = Fore.GREEN
4033 branch_name = ShortBranchName(branch)
4034
4035 if colorize:
4036 return asterisk + color + branch_name + Fore.RESET
Daniel McArdle452a49f2019-02-14 17:28:31 +00004037 return asterisk + branch_name
4038
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004039 branch_statuses = {}
Daniel McArdlea23bf592019-02-12 00:25:12 +00004040
4041 alignment = max(5, max(len(FormatBranchName(c.GetBranch())) for c in changes))
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004042 for cl in sorted(changes, key=lambda c: c.GetBranch()):
4043 branch = cl.GetBranch()
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004044 while branch not in branch_statuses:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004045 c, status = output.next()
4046 branch_statuses[c.GetBranch()] = status
4047 status = branch_statuses.pop(branch)
4048 url = cl.GetIssueURL()
4049 if url and (not status or status == 'error'):
4050 # The issue probably doesn't exist anymore.
4051 url += ' (broken)'
4052
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00004053 color = color_for_status(status)
maruel@chromium.org885f6512013-07-27 02:17:26 +00004054 reset = Fore.RESET
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00004055 if not setup_color.IS_TTY:
maruel@chromium.org885f6512013-07-27 02:17:26 +00004056 color = ''
4057 reset = ''
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00004058 status_str = '(%s)' % status if status else ''
Daniel McArdle452a49f2019-02-14 17:28:31 +00004059
Alan Cuttera3be9a52019-03-04 18:50:33 +00004060 branch_display = FormatBranchName(branch)
4061 padding = ' ' * (alignment - len(branch_display))
4062 if not options.no_branch_color:
4063 branch_display = FormatBranchName(branch, colorize=True)
Daniel McArdle452a49f2019-02-14 17:28:31 +00004064
Alan Cuttera3be9a52019-03-04 18:50:33 +00004065 print(' %s : %s%s %s%s' % (padding + branch_display, color, url,
4066 status_str, reset))
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01004067
vapiera7fbd5a2016-06-16 09:17:49 -07004068 print()
Daniel McArdlea23bf592019-02-12 00:25:12 +00004069 print('Current branch: %s' % current_branch)
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01004070 for cl in changes:
Daniel McArdlea23bf592019-02-12 00:25:12 +00004071 if cl.GetBranch() == current_branch:
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01004072 break
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00004073 if not cl.GetIssue():
vapiera7fbd5a2016-06-16 09:17:49 -07004074 print('No issue assigned.')
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00004075 return 0
vapiera7fbd5a2016-06-16 09:17:49 -07004076 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
maruel@chromium.org85616e02014-07-28 15:37:55 +00004077 if not options.fast:
vapiera7fbd5a2016-06-16 09:17:49 -07004078 print('Issue description:')
4079 print(cl.GetDescription(pretty=True))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004080 return 0
4081
4082
maruel@chromium.org39c0b222013-08-17 16:57:01 +00004083def colorize_CMDstatus_doc():
4084 """To be called once in main() to add colors to git cl status help."""
4085 colors = [i for i in dir(Fore) if i[0].isupper()]
4086
4087 def colorize_line(line):
4088 for color in colors:
4089 if color in line.upper():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004090 # Extract whitespace first and the leading '-'.
maruel@chromium.org39c0b222013-08-17 16:57:01 +00004091 indent = len(line) - len(line.lstrip(' ')) + 1
4092 return line[:indent] + getattr(Fore, color) + line[indent:] + Fore.RESET
4093 return line
4094
4095 lines = CMDstatus.__doc__.splitlines()
4096 CMDstatus.__doc__ = '\n'.join(colorize_line(l) for l in lines)
4097
4098
phajdan.jre328cf92016-08-22 04:12:17 -07004099def write_json(path, contents):
Stefan Zager1306bd02017-06-22 19:26:46 -07004100 if path == '-':
4101 json.dump(contents, sys.stdout)
4102 else:
4103 with open(path, 'w') as f:
4104 json.dump(contents, f)
phajdan.jre328cf92016-08-22 04:12:17 -07004105
4106
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004107@subcommand.usage('[issue_number]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004108@metrics.collector.collect_metrics('git cl issue')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004109def CMDissue(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004110 """Sets or displays the current code review issue number.
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004111
4112 Pass issue number 0 to clear the current issue.
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004113 """
dnj@chromium.org406c4402015-03-03 17:22:28 +00004114 parser.add_option('-r', '--reverse', action='store_true',
4115 help='Lookup the branch(es) for the specified issues. If '
4116 'no issues are specified, all branches with mapped '
4117 'issues will be listed.')
Stefan Zager1306bd02017-06-22 19:26:46 -07004118 parser.add_option('--json',
4119 help='Path to JSON output file, or "-" for stdout.')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004120 _add_codereview_select_options(parser)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004121 options, args = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004122 _process_codereview_select_options(parser, options)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004123
dnj@chromium.org406c4402015-03-03 17:22:28 +00004124 if options.reverse:
4125 branches = RunGit(['for-each-ref', 'refs/heads',
Aaron Gablead64abd2017-12-04 09:49:13 -08004126 '--format=%(refname)']).splitlines()
dnj@chromium.org406c4402015-03-03 17:22:28 +00004127 # Reverse issue lookup.
4128 issue_branch_map = {}
Daniel Bratellb56a43a2018-09-06 15:49:03 +00004129
4130 git_config = {}
4131 for config in RunGit(['config', '--get-regexp',
4132 r'branch\..*issue']).splitlines():
4133 name, _space, val = config.partition(' ')
4134 git_config[name] = val
4135
dnj@chromium.org406c4402015-03-03 17:22:28 +00004136 for branch in branches:
Daniel Bratellb56a43a2018-09-06 15:49:03 +00004137 for cls in _CODEREVIEW_IMPLEMENTATIONS.values():
4138 config_key = _git_branch_config_key(ShortBranchName(branch),
4139 cls.IssueConfigKey())
4140 issue = git_config.get(config_key)
4141 if issue:
4142 issue_branch_map.setdefault(int(issue), []).append(branch)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004143 if not args:
4144 args = sorted(issue_branch_map.iterkeys())
phajdan.jre328cf92016-08-22 04:12:17 -07004145 result = {}
dnj@chromium.org406c4402015-03-03 17:22:28 +00004146 for issue in args:
Lei Zhang5a368d42019-03-25 23:18:19 +00004147 try:
4148 issue_num = int(issue)
4149 except ValueError:
4150 print('ERROR cannot parse issue number: %s' % issue, file=sys.stderr)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004151 continue
Lei Zhang5a368d42019-03-25 23:18:19 +00004152 result[issue_num] = issue_branch_map.get(issue_num)
vapiera7fbd5a2016-06-16 09:17:49 -07004153 print('Branch for issue number %s: %s' % (
Lei Zhang5a368d42019-03-25 23:18:19 +00004154 issue, ', '.join(issue_branch_map.get(issue_num) or ('None',))))
phajdan.jre328cf92016-08-22 04:12:17 -07004155 if options.json:
4156 write_json(options.json, result)
Aaron Gable78753da2017-06-15 10:35:49 -07004157 return 0
4158
4159 if len(args) > 0:
4160 issue = ParseIssueNumberArgument(args[0], options.forced_codereview)
4161 if not issue.valid:
4162 DieWithError('Pass a url or number to set the issue, 0 to unset it, '
4163 'or no argument to list it.\n'
4164 'Maybe you want to run git cl status?')
4165 cl = Changelist(codereview=issue.codereview)
4166 cl.SetIssue(issue.issue)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004167 else:
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004168 cl = Changelist(codereview=options.forced_codereview)
Aaron Gable78753da2017-06-15 10:35:49 -07004169 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
4170 if options.json:
4171 write_json(options.json, {
4172 'issue': cl.GetIssue(),
4173 'issue_url': cl.GetIssueURL(),
4174 })
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004175 return 0
4176
4177
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004178@metrics.collector.collect_metrics('git cl comments')
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004179def CMDcomments(parser, args):
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004180 """Shows or posts review comments for any changelist."""
4181 parser.add_option('-a', '--add-comment', dest='comment',
4182 help='comment to add to an issue')
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00004183 parser.add_option('-p', '--publish', action='store_true',
4184 help='marks CL as ready and sends comment to reviewers')
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01004185 parser.add_option('-i', '--issue', dest='issue',
4186 help='review issue id (defaults to current issue). '
4187 'If given, requires --rietveld or --gerrit')
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07004188 parser.add_option('-m', '--machine-readable', dest='readable',
4189 action='store_false', default=True,
4190 help='output comments in a format compatible with '
4191 'editor parsing')
smut@google.comc85ac942015-09-15 16:34:43 +00004192 parser.add_option('-j', '--json-file',
Stefan Zager1306bd02017-06-22 19:26:46 -07004193 help='File to write JSON summary to, or "-" for stdout')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004194 auth.add_auth_options(parser)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004195 _add_codereview_select_options(parser)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004196 options, args = parser.parse_args(args)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004197 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004198 auth_config = auth.extract_auth_config_from_options(options)
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004199
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004200 issue = None
4201 if options.issue:
4202 try:
4203 issue = int(options.issue)
4204 except ValueError:
4205 DieWithError('A review issue id is expected to be a number')
4206
Andrii Shyshkalov642641d2018-10-16 05:54:41 +00004207 cl = Changelist(issue=issue, codereview='gerrit', auth_config=auth_config)
4208
4209 if not cl.IsGerrit():
4210 parser.error('rietveld is not supported')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004211
4212 if options.comment:
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00004213 cl.AddComment(options.comment, options.publish)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004214 return 0
4215
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07004216 summary = sorted(cl.GetCommentsSummary(readable=options.readable),
4217 key=lambda c: c.date)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004218 for comment in summary:
4219 if comment.disapproval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004220 color = Fore.RED
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004221 elif comment.approval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004222 color = Fore.GREEN
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004223 elif comment.sender == cl.GetIssueOwner():
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004224 color = Fore.MAGENTA
Quinten Yearsley0e617c02019-02-20 00:37:03 +00004225 elif comment.autogenerated:
4226 color = Fore.CYAN
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004227 else:
4228 color = Fore.BLUE
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004229 print('\n%s%s %s%s\n%s' % (
4230 color,
4231 comment.date.strftime('%Y-%m-%d %H:%M:%S UTC'),
4232 comment.sender,
4233 Fore.RESET,
4234 '\n'.join(' ' + l for l in comment.message.strip().splitlines())))
4235
smut@google.comc85ac942015-09-15 16:34:43 +00004236 if options.json_file:
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004237 def pre_serialize(c):
4238 dct = c.__dict__.copy()
4239 dct['date'] = dct['date'].strftime('%Y-%m-%d %H:%M:%S.%f')
4240 return dct
Leszek Swirski45b20c42018-09-17 17:05:26 +00004241 write_json(options.json_file, map(pre_serialize, summary))
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004242 return 0
4243
4244
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004245@subcommand.usage('[codereview url or issue id]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004246@metrics.collector.collect_metrics('git cl description')
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004247def CMDdescription(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004248 """Brings up the editor for the current CL's description."""
smut@google.com34fb6b12015-07-13 20:03:26 +00004249 parser.add_option('-d', '--display', action='store_true',
4250 help='Display the description instead of opening an editor')
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004251 parser.add_option('-n', '--new-description',
dnjba1b0f32016-09-02 12:37:42 -07004252 help='New description to set for this issue (- for stdin, '
4253 '+ to load from local commit HEAD)')
dsansomee2d6fd92016-09-08 00:10:47 -07004254 parser.add_option('-f', '--force', action='store_true',
4255 help='Delete any unpublished Gerrit edits for this issue '
4256 'without prompting')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004257
4258 _add_codereview_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004259 auth.add_auth_options(parser)
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004260 options, args = parser.parse_args(args)
4261 _process_codereview_select_options(parser, options)
4262
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004263 target_issue_arg = None
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004264 if len(args) > 0:
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004265 target_issue_arg = ParseIssueNumberArgument(args[0],
4266 options.forced_codereview)
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004267 if not target_issue_arg.valid:
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02004268 parser.error('invalid codereview url or CL id')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004269
martiniss6eda05f2016-06-30 10:18:35 -07004270 kwargs = {
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00004271 'auth_config': auth.extract_auth_config_from_options(options),
4272 'codereview': options.forced_codereview,
martiniss6eda05f2016-06-30 10:18:35 -07004273 }
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004274 detected_codereview_from_url = False
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004275 if target_issue_arg:
4276 kwargs['issue'] = target_issue_arg.issue
4277 kwargs['codereview_host'] = target_issue_arg.hostname
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004278 if target_issue_arg.codereview and not options.forced_codereview:
4279 detected_codereview_from_url = True
4280 kwargs['codereview'] = target_issue_arg.codereview
martiniss6eda05f2016-06-30 10:18:35 -07004281
4282 cl = Changelist(**kwargs)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004283 if not cl.GetIssue():
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004284 assert not detected_codereview_from_url
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004285 DieWithError('This branch has no associated changelist.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004286
4287 if detected_codereview_from_url:
4288 logging.info('canonical issue/change URL: %s (type: %s)\n',
4289 cl.GetIssueURL(), target_issue_arg.codereview)
4290
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004291 description = ChangeDescription(cl.GetDescription())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004292
smut@google.com34fb6b12015-07-13 20:03:26 +00004293 if options.display:
vapiera7fbd5a2016-06-16 09:17:49 -07004294 print(description.description)
smut@google.com34fb6b12015-07-13 20:03:26 +00004295 return 0
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004296
4297 if options.new_description:
4298 text = options.new_description
4299 if text == '-':
4300 text = '\n'.join(l.rstrip() for l in sys.stdin)
dnjba1b0f32016-09-02 12:37:42 -07004301 elif text == '+':
4302 base_branch = cl.GetCommonAncestorWithUpstream()
4303 change = cl.GetChange(base_branch, None, local_description=True)
4304 text = change.FullDescriptionText()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004305
4306 description.set_description(text)
4307 else:
Aaron Gable3a16ed12017-03-23 10:51:55 -07004308 description.prompt(git_footer=cl.IsGerrit())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004309
Andrii Shyshkalov680253d2017-03-15 21:07:36 +01004310 if cl.GetDescription().strip() != description.description:
dsansomee2d6fd92016-09-08 00:10:47 -07004311 cl.UpdateDescription(description.description, force=options.force)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004312 return 0
4313
4314
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004315@metrics.collector.collect_metrics('git cl lint')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004316def CMDlint(parser, args):
4317 """Runs cpplint on the current changelist."""
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004318 parser.add_option('--filter', action='append', metavar='-x,+y',
4319 help='Comma-separated list of cpplint\'s category-filters')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004320 auth.add_auth_options(parser)
4321 options, args = parser.parse_args(args)
4322 auth_config = auth.extract_auth_config_from_options(options)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004323
4324 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08004325 # pylint: disable=protected-access
thestig@chromium.org44202a22014-03-11 19:22:18 +00004326 try:
4327 import cpplint
4328 import cpplint_chromium
4329 except ImportError:
vapiera7fbd5a2016-06-16 09:17:49 -07004330 print('Your depot_tools is missing cpplint.py and/or cpplint_chromium.py.')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004331 return 1
4332
4333 # Change the current working directory before calling lint so that it
4334 # shows the correct base.
4335 previous_cwd = os.getcwd()
4336 os.chdir(settings.GetRoot())
4337 try:
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004338 cl = Changelist(auth_config=auth_config)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004339 change = cl.GetChange(cl.GetCommonAncestorWithUpstream(), None)
4340 files = [f.LocalPath() for f in change.AffectedFiles()]
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004341 if not files:
vapiera7fbd5a2016-06-16 09:17:49 -07004342 print('Cannot lint an empty CL')
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004343 return 1
thestig@chromium.org44202a22014-03-11 19:22:18 +00004344
4345 # Process cpplints arguments if any.
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004346 command = args + files
4347 if options.filter:
4348 command = ['--filter=' + ','.join(options.filter)] + command
4349 filenames = cpplint.ParseArguments(command)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004350
4351 white_regex = re.compile(settings.GetLintRegex())
4352 black_regex = re.compile(settings.GetLintIgnoreRegex())
4353 extra_check_functions = [cpplint_chromium.CheckPointerDeclarationWhitespace]
4354 for filename in filenames:
4355 if white_regex.match(filename):
4356 if black_regex.match(filename):
vapiera7fbd5a2016-06-16 09:17:49 -07004357 print('Ignoring file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004358 else:
4359 cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level,
4360 extra_check_functions)
4361 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004362 print('Skipping file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004363 finally:
4364 os.chdir(previous_cwd)
vapiera7fbd5a2016-06-16 09:17:49 -07004365 print('Total errors found: %d\n' % cpplint._cpplint_state.error_count)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004366 if cpplint._cpplint_state.error_count != 0:
4367 return 1
4368 return 0
4369
4370
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004371@metrics.collector.collect_metrics('git cl presubmit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004372def CMDpresubmit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004373 """Runs presubmit tests on the current changelist."""
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004374 parser.add_option('-u', '--upload', action='store_true',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004375 help='Run upload hook instead of the push hook')
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004376 parser.add_option('-f', '--force', action='store_true',
sbc@chromium.org495ad152012-09-04 23:07:42 +00004377 help='Run checks even if tree is dirty')
Aaron Gable8076c282017-11-29 14:39:41 -08004378 parser.add_option('--all', action='store_true',
4379 help='Run checks against all files, not just modified ones')
Edward Lesmes8e282792018-04-03 18:50:29 -04004380 parser.add_option('--parallel', action='store_true',
4381 help='Run all tests specified by input_api.RunTests in all '
4382 'PRESUBMIT files in parallel.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004383 auth.add_auth_options(parser)
4384 options, args = parser.parse_args(args)
4385 auth_config = auth.extract_auth_config_from_options(options)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004386
sbc@chromium.org71437c02015-04-09 19:29:40 +00004387 if not options.force and git_common.is_dirty_git_tree('presubmit'):
vapiera7fbd5a2016-06-16 09:17:49 -07004388 print('use --force to check even if tree is dirty.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004389 return 1
4390
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004391 cl = Changelist(auth_config=auth_config)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004392 if args:
4393 base_branch = args[0]
4394 else:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00004395 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004396 base_branch = cl.GetCommonAncestorWithUpstream()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004397
Aaron Gable8076c282017-11-29 14:39:41 -08004398 if options.all:
4399 base_change = cl.GetChange(base_branch, None)
4400 files = [('M', f) for f in base_change.AllFiles()]
4401 change = presubmit_support.GitChange(
4402 base_change.Name(),
4403 base_change.FullDescriptionText(),
4404 base_change.RepositoryRoot(),
4405 files,
4406 base_change.issue,
4407 base_change.patchset,
4408 base_change.author_email,
4409 base_change._upstream)
4410 else:
4411 change = cl.GetChange(base_branch, None)
4412
ilevy@chromium.org051ad0e2013-03-04 21:57:34 +00004413 cl.RunHook(
4414 committing=not options.upload,
4415 may_prompt=False,
4416 verbose=options.verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04004417 change=change,
4418 parallel=options.parallel)
dpranke@chromium.org0a2bb372011-03-25 01:16:22 +00004419 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004420
4421
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004422def GenerateGerritChangeId(message):
4423 """Returns Ixxxxxx...xxx change id.
4424
4425 Works the same way as
4426 https://gerrit-review.googlesource.com/tools/hooks/commit-msg
4427 but can be called on demand on all platforms.
4428
4429 The basic idea is to generate git hash of a state of the tree, original commit
4430 message, author/committer info and timestamps.
4431 """
4432 lines = []
4433 tree_hash = RunGitSilent(['write-tree'])
4434 lines.append('tree %s' % tree_hash.strip())
4435 code, parent = RunGitWithCode(['rev-parse', 'HEAD~0'], suppress_stderr=False)
4436 if code == 0:
4437 lines.append('parent %s' % parent.strip())
4438 author = RunGitSilent(['var', 'GIT_AUTHOR_IDENT'])
4439 lines.append('author %s' % author.strip())
4440 committer = RunGitSilent(['var', 'GIT_COMMITTER_IDENT'])
4441 lines.append('committer %s' % committer.strip())
4442 lines.append('')
4443 # Note: Gerrit's commit-hook actually cleans message of some lines and
4444 # whitespace. This code is not doing this, but it clearly won't decrease
4445 # entropy.
4446 lines.append(message)
4447 change_hash = RunCommand(['git', 'hash-object', '-t', 'commit', '--stdin'],
Raul Tambreb946b232019-03-26 14:48:46 +00004448 stdin=('\n'.join(lines)).encode())
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004449 return 'I%s' % change_hash.strip()
4450
4451
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01004452def GetTargetRef(remote, remote_branch, target_branch):
wittman@chromium.org455dc922015-01-26 20:15:50 +00004453 """Computes the remote branch ref to use for the CL.
4454
4455 Args:
4456 remote (str): The git remote for the CL.
4457 remote_branch (str): The git remote branch for the CL.
4458 target_branch (str): The target branch specified by the user.
wittman@chromium.org455dc922015-01-26 20:15:50 +00004459 """
4460 if not (remote and remote_branch):
4461 return None
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004462
wittman@chromium.org455dc922015-01-26 20:15:50 +00004463 if target_branch:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004464 # Canonicalize branch references to the equivalent local full symbolic
wittman@chromium.org455dc922015-01-26 20:15:50 +00004465 # refs, which are then translated into the remote full symbolic refs
4466 # below.
4467 if '/' not in target_branch:
4468 remote_branch = 'refs/remotes/%s/%s' % (remote, target_branch)
4469 else:
4470 prefix_replacements = (
4471 ('^((refs/)?remotes/)?branch-heads/', 'refs/remotes/branch-heads/'),
4472 ('^((refs/)?remotes/)?%s/' % remote, 'refs/remotes/%s/' % remote),
4473 ('^(refs/)?heads/', 'refs/remotes/%s/' % remote),
4474 )
4475 match = None
4476 for regex, replacement in prefix_replacements:
4477 match = re.search(regex, target_branch)
4478 if match:
4479 remote_branch = target_branch.replace(match.group(0), replacement)
4480 break
4481 if not match:
4482 # This is a branch path but not one we recognize; use as-is.
4483 remote_branch = target_branch
rmistry@google.comc68112d2015-03-03 12:48:06 +00004484 elif remote_branch in REFS_THAT_ALIAS_TO_OTHER_REFS:
4485 # Handle the refs that need to land in different refs.
4486 remote_branch = REFS_THAT_ALIAS_TO_OTHER_REFS[remote_branch]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004487
wittman@chromium.org455dc922015-01-26 20:15:50 +00004488 # Create the true path to the remote branch.
4489 # Does the following translation:
4490 # * refs/remotes/origin/refs/diff/test -> refs/diff/test
4491 # * refs/remotes/origin/master -> refs/heads/master
4492 # * refs/remotes/branch-heads/test -> refs/branch-heads/test
4493 if remote_branch.startswith('refs/remotes/%s/refs/' % remote):
4494 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, '')
4495 elif remote_branch.startswith('refs/remotes/%s/' % remote):
4496 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote,
4497 'refs/heads/')
4498 elif remote_branch.startswith('refs/remotes/branch-heads'):
4499 remote_branch = remote_branch.replace('refs/remotes/', 'refs/')
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01004500
wittman@chromium.org455dc922015-01-26 20:15:50 +00004501 return remote_branch
4502
4503
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004504def cleanup_list(l):
4505 """Fixes a list so that comma separated items are put as individual items.
4506
4507 So that "--reviewers joe@c,john@c --reviewers joa@c" results in
4508 options.reviewers == sorted(['joe@c', 'john@c', 'joa@c']).
4509 """
4510 items = sum((i.split(',') for i in l), [])
4511 stripped_items = (i.strip() for i in items)
4512 return sorted(filter(None, stripped_items))
4513
4514
Aaron Gable4db38df2017-11-03 14:59:07 -07004515@subcommand.usage('[flags]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004516@metrics.collector.collect_metrics('git cl upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004517def CMDupload(parser, args):
rmistry@google.com78948ed2015-07-08 23:09:57 +00004518 """Uploads the current changelist to codereview.
4519
4520 Can skip dependency patchset uploads for a branch by running:
4521 git config branch.branch_name.skip-deps-uploads True
4522 To unset run:
4523 git config --unset branch.branch_name.skip-deps-uploads
4524 Can also set the above globally by using the --global flag.
Dominic Battre7d1c4842017-10-27 09:17:28 +02004525
4526 If the name of the checked out branch starts with "bug-" or "fix-" followed by
4527 a bug number, this bug number is automatically populated in the CL
4528 description.
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004529
4530 If subject contains text in square brackets or has "<text>: " prefix, such
4531 text(s) is treated as Gerrit hashtags. For example, CLs with subjects
4532 [git-cl] add support for hashtags
4533 Foo bar: implement foo
4534 will be hashtagged with "git-cl" and "foo-bar" respectively.
rmistry@google.com78948ed2015-07-08 23:09:57 +00004535 """
ukai@chromium.orge8077812012-02-03 03:41:46 +00004536 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4537 help='bypass upload presubmit hook')
brettw@chromium.orgb65c43c2013-06-10 22:04:49 +00004538 parser.add_option('--bypass-watchlists', action='store_true',
4539 dest='bypass_watchlists',
4540 help='bypass watchlists auto CC-ing reviewers')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004541 parser.add_option('-f', '--force', action='store_true', dest='force',
ukai@chromium.orge8077812012-02-03 03:41:46 +00004542 help="force yes to questions (don't prompt)")
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004543 parser.add_option('--message', '-m', dest='message',
4544 help='message for patchset')
tandriif9aefb72016-07-01 09:06:51 -07004545 parser.add_option('-b', '--bug',
4546 help='pre-populate the bug number(s) for this issue. '
4547 'If several, separate with commas')
tandriib80458a2016-06-23 12:20:07 -07004548 parser.add_option('--message-file', dest='message_file',
4549 help='file which contains message for patchset')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004550 parser.add_option('--title', '-t', dest='title',
4551 help='title for patchset')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004552 parser.add_option('-r', '--reviewers',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004553 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004554 help='reviewer email addresses')
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004555 parser.add_option('--tbrs',
4556 action='append', default=[],
4557 help='TBR email addresses')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004558 parser.add_option('--cc',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004559 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004560 help='cc email addresses')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004561 parser.add_option('--hashtag', dest='hashtags',
4562 action='append', default=[],
4563 help=('Gerrit hashtag for new CL; '
4564 'can be applied multiple times'))
adamk@chromium.org36f47302013-04-05 01:08:31 +00004565 parser.add_option('-s', '--send-mail', action='store_true',
Aaron Gable59f48512017-01-12 10:54:46 -08004566 help='send email to reviewer(s) and cc(s) immediately')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004567 parser.add_option('-c', '--use-commit-queue', action='store_true',
Aaron Gableedbc4132017-09-11 13:22:28 -07004568 help='tell the commit queue to commit this patchset; '
4569 'implies --send-mail')
ukai@chromium.org8ef7ab22012-11-28 04:24:52 +00004570 parser.add_option('--target_branch',
pgervais@chromium.orgb9f27512014-08-08 15:52:33 +00004571 '--target-branch',
wittman@chromium.org455dc922015-01-26 20:15:50 +00004572 metavar='TARGET',
4573 help='Apply CL to remote ref TARGET. ' +
4574 'Default: remote branch head, or master')
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004575 parser.add_option('--squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004576 help='Squash multiple commits into one')
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00004577 parser.add_option('--no-squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004578 help='Don\'t squash multiple commits into one')
rmistry9eadede2016-09-19 11:22:43 -07004579 parser.add_option('--topic', default=None,
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004580 help='Topic to specify when uploading')
Robert Iannuccif2708bd2017-04-17 15:49:02 -07004581 parser.add_option('--tbr-owners', dest='add_owners_to', action='store_const',
4582 const='TBR', help='add a set of OWNERS to TBR')
4583 parser.add_option('--r-owners', dest='add_owners_to', action='store_const',
4584 const='R', help='add a set of OWNERS to R')
tandrii@chromium.orgd50452a2015-11-23 16:38:15 +00004585 parser.add_option('-d', '--cq-dry-run', dest='cq_dry_run',
4586 action='store_true',
rmistry@google.comef966222015-04-07 11:15:01 +00004587 help='Send the patchset to do a CQ dry run right after '
4588 'upload.')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004589 parser.add_option('--dependencies', action='store_true',
4590 help='Uploads CLs of all the local branches that depend on '
4591 'the current branch')
Ravi Mistry31e7d562018-04-02 12:53:57 -04004592 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4593 help='Sends your change to the CQ after an approval. Only '
4594 'works on repos that have the Auto-Submit label '
4595 'enabled')
Edward Lesmes8e282792018-04-03 18:50:29 -04004596 parser.add_option('--parallel', action='store_true',
4597 help='Run all tests specified by input_api.RunTests in all '
4598 'PRESUBMIT files in parallel.')
pgervais@chromium.org91141372014-01-09 23:27:20 +00004599
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004600 parser.add_option('--no-autocc', action='store_true',
4601 help='Disables automatic addition of CC emails')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004602 parser.add_option('--private', action='store_true',
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004603 help='Set the review private. This implies --no-autocc.')
4604
rmistry@google.com2dd99862015-06-22 12:22:18 +00004605 orig_args = args
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004606 auth.add_auth_options(parser)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004607 _add_codereview_select_options(parser)
ukai@chromium.orge8077812012-02-03 03:41:46 +00004608 (options, args) = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004609 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004610 auth_config = auth.extract_auth_config_from_options(options)
ukai@chromium.orge8077812012-02-03 03:41:46 +00004611
sbc@chromium.org71437c02015-04-09 19:29:40 +00004612 if git_common.is_dirty_git_tree('upload'):
ukai@chromium.orge8077812012-02-03 03:41:46 +00004613 return 1
4614
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004615 options.reviewers = cleanup_list(options.reviewers)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004616 options.tbrs = cleanup_list(options.tbrs)
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004617 options.cc = cleanup_list(options.cc)
4618
tandriib80458a2016-06-23 12:20:07 -07004619 if options.message_file:
4620 if options.message:
4621 parser.error('only one of --message and --message-file allowed.')
4622 options.message = gclient_utils.FileRead(options.message_file)
4623 options.message_file = None
4624
tandrii4d0545a2016-07-06 03:56:49 -07004625 if options.cq_dry_run and options.use_commit_queue:
4626 parser.error('only one of --use-commit-queue and --cq-dry-run allowed.')
4627
Aaron Gableedbc4132017-09-11 13:22:28 -07004628 if options.use_commit_queue:
4629 options.send_mail = True
4630
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00004631 # For sanity of test expectations, do this otherwise lazy-loading *now*.
4632 settings.GetIsGerrit()
4633
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004634 cl = Changelist(auth_config=auth_config, codereview=options.forced_codereview)
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00004635 if not cl.IsGerrit():
4636 # Error out with instructions for repos not yet configured for Gerrit.
4637 print('=====================================')
4638 print('NOTICE: Rietveld is no longer supported. '
4639 'You can upload changes to Gerrit with')
4640 print(' git cl upload --gerrit')
4641 print('or set Gerrit to be your default code review tool with')
4642 print(' git config gerrit.host true')
4643 print('=====================================')
4644 return 1
4645
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00004646 return cl.CMDUpload(options, args, orig_args)
ukai@chromium.orge8077812012-02-03 03:41:46 +00004647
4648
Francois Dorayd42c6812017-05-30 15:10:20 -04004649@subcommand.usage('--description=<description file>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004650@metrics.collector.collect_metrics('git cl split')
Francois Dorayd42c6812017-05-30 15:10:20 -04004651def CMDsplit(parser, args):
4652 """Splits a branch into smaller branches and uploads CLs.
4653
4654 Creates a branch and uploads a CL for each group of files modified in the
4655 current branch that share a common OWNERS file. In the CL description and
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004656 comment, the string '$directory', is replaced with the directory containing
Francois Dorayd42c6812017-05-30 15:10:20 -04004657 the shared OWNERS file.
4658 """
4659 parser.add_option("-d", "--description", dest="description_file",
Gabriel Charette02b5ee82017-11-08 16:36:05 -05004660 help="A text file containing a CL description in which "
4661 "$directory will be replaced by each CL's directory.")
Francois Dorayd42c6812017-05-30 15:10:20 -04004662 parser.add_option("-c", "--comment", dest="comment_file",
4663 help="A text file containing a CL comment.")
Chris Watkinsba28e462017-12-13 11:22:17 +11004664 parser.add_option("-n", "--dry-run", dest="dry_run", action='store_true',
4665 default=False,
4666 help="List the files and reviewers for each CL that would "
4667 "be created, but don't create branches or CLs.")
Stephen Martiniscb326682018-08-29 21:06:30 +00004668 parser.add_option("--cq-dry-run", action='store_true',
4669 help="If set, will do a cq dry run for each uploaded CL. "
4670 "Please be careful when doing this; more than ~10 CLs "
4671 "has the potential to overload our build "
4672 "infrastructure. Try to upload these not during high "
4673 "load times (usually 11-3 Mountain View time). Email "
4674 "infra-dev@chromium.org with any questions.")
Takuto Ikuta51eca592019-02-14 19:40:52 +00004675 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4676 default=True,
4677 help='Sends your change to the CQ after an approval. Only '
4678 'works on repos that have the Auto-Submit label '
4679 'enabled')
Francois Dorayd42c6812017-05-30 15:10:20 -04004680 options, _ = parser.parse_args(args)
4681
4682 if not options.description_file:
4683 parser.error('No --description flag specified.')
4684
4685 def WrappedCMDupload(args):
4686 return CMDupload(OptionParser(), args)
4687
4688 return split_cl.SplitCl(options.description_file, options.comment_file,
Stephen Martiniscb326682018-08-29 21:06:30 +00004689 Changelist, WrappedCMDupload, options.dry_run,
Takuto Ikuta51eca592019-02-14 19:40:52 +00004690 options.cq_dry_run, options.enable_auto_submit)
Francois Dorayd42c6812017-05-30 15:10:20 -04004691
4692
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004693@subcommand.usage('DEPRECATED')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004694@metrics.collector.collect_metrics('git cl commit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004695def CMDdcommit(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004696 """DEPRECATED: Used to commit the current changelist via git-svn."""
4697 message = ('git-cl no longer supports committing to SVN repositories via '
4698 'git-svn. You probably want to use `git cl land` instead.')
4699 print(message)
4700 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004701
4702
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01004703# Two special branches used by git cl land.
4704MERGE_BRANCH = 'git-cl-commit'
4705CHERRY_PICK_BRANCH = 'git-cl-cherry-pick'
4706
4707
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004708@subcommand.usage('[upstream branch to apply against]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004709@metrics.collector.collect_metrics('git cl land')
pgervais@chromium.orgcee6dc42014-05-07 17:04:03 +00004710def CMDland(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004711 """Commits the current changelist via git.
4712
4713 In case of Gerrit, uses Gerrit REST api to "submit" the issue, which pushes
4714 upstream and closes the issue automatically and atomically.
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004715 """
4716 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4717 help='bypass upload presubmit hook')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004718 parser.add_option('-f', '--force', action='store_true', dest='force',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004719 help="force yes to questions (don't prompt)")
Edward Lesmes67b3faa2018-04-13 17:50:52 -04004720 parser.add_option('--parallel', action='store_true',
4721 help='Run all tests specified by input_api.RunTests in all '
4722 'PRESUBMIT files in parallel.')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004723 auth.add_auth_options(parser)
4724 (options, args) = parser.parse_args(args)
4725 auth_config = auth.extract_auth_config_from_options(options)
4726
4727 cl = Changelist(auth_config=auth_config)
4728
Robert Iannucci2e73d432018-03-14 01:10:47 -07004729 if not cl.IsGerrit():
4730 parser.error('rietveld is not supported')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004731
Robert Iannucci2e73d432018-03-14 01:10:47 -07004732 if not cl.GetIssue():
4733 DieWithError('You must upload the change first to Gerrit.\n'
4734 ' If you would rather have `git cl land` upload '
4735 'automatically for you, see http://crbug.com/642759')
4736 return cl._codereview_impl.CMDLand(options.force, options.bypass_hooks,
Olivier Robin75ee7252018-04-13 10:02:56 +02004737 options.verbose, options.parallel)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004738
4739
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004740@subcommand.usage('<patch url or issue id or issue url>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004741@metrics.collector.collect_metrics('git cl patch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004742def CMDpatch(parser, args):
marq@chromium.orge5e59002013-10-02 23:21:25 +00004743 """Patches in a code review."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004744 parser.add_option('-b', dest='newbranch',
4745 help='create a new branch off trunk for the patch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00004746 parser.add_option('-f', '--force', action='store_true',
Aaron Gable62619a32017-06-16 08:22:09 -07004747 help='overwrite state on the current or chosen branch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00004748 parser.add_option('-d', '--directory', action='store', metavar='DIR',
Aaron Gable62619a32017-06-16 08:22:09 -07004749 help='change to the directory DIR immediately, '
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004750 'before doing anything else. Rietveld only.')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00004751 parser.add_option('--reject', action='store_true',
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +00004752 help='failed patches spew .rej files rather than '
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004753 'attempting a 3-way merge. Rietveld only.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004754 parser.add_option('-n', '--no-commit', action='store_true', dest='nocommit',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004755 help='don\'t commit after patch applies. Rietveld only.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004756
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004757
4758 group = optparse.OptionGroup(
4759 parser,
4760 'Options for continuing work on the current issue uploaded from a '
4761 'different clone (e.g. different machine). Must be used independently '
4762 'from the other options. No issue number should be specified, and the '
4763 'branch must have an issue number associated with it')
4764 group.add_option('--reapply', action='store_true', dest='reapply',
4765 help='Reset the branch and reapply the issue.\n'
4766 'CAUTION: This will undo any local changes in this '
4767 'branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004768
4769 group.add_option('--pull', action='store_true', dest='pull',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004770 help='Performs a pull before reapplying.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004771 parser.add_option_group(group)
4772
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004773 auth.add_auth_options(parser)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004774 _add_codereview_select_options(parser)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004775 (options, args) = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004776 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004777 auth_config = auth.extract_auth_config_from_options(options)
4778
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004779 if options.reapply:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004780 if options.newbranch:
4781 parser.error('--reapply works on the current branch only')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004782 if len(args) > 0:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004783 parser.error('--reapply implies no additional arguments')
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004784
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004785 cl = Changelist(auth_config=auth_config,
4786 codereview=options.forced_codereview)
4787 if not cl.GetIssue():
4788 parser.error('current branch must have an associated issue')
4789
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004790 upstream = cl.GetUpstreamBranch()
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004791 if upstream is None:
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004792 parser.error('No upstream branch specified. Cannot reset branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004793
4794 RunGit(['reset', '--hard', upstream])
4795 if options.pull:
4796 RunGit(['pull'])
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004797
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004798 return cl.CMDPatchIssue(cl.GetIssue(), options.reject, options.nocommit,
4799 options.directory)
4800
4801 if len(args) != 1 or not args[0]:
4802 parser.error('Must specify issue number or url')
4803
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004804 target_issue_arg = ParseIssueNumberArgument(args[0],
4805 options.forced_codereview)
4806 if not target_issue_arg.valid:
4807 parser.error('invalid codereview url or CL id')
4808
4809 cl_kwargs = {
4810 'auth_config': auth_config,
4811 'codereview_host': target_issue_arg.hostname,
4812 'codereview': options.forced_codereview,
4813 }
4814 detected_codereview_from_url = False
4815 if target_issue_arg.codereview and not options.forced_codereview:
4816 detected_codereview_from_url = True
4817 cl_kwargs['codereview'] = target_issue_arg.codereview
4818 cl_kwargs['issue'] = target_issue_arg.issue
4819
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004820 # We don't want uncommitted changes mixed up with the patch.
4821 if git_common.is_dirty_git_tree('patch'):
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004822 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004823
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004824 if options.newbranch:
4825 if options.force:
4826 RunGit(['branch', '-D', options.newbranch],
4827 stderr=subprocess2.PIPE, error_ok=True)
4828 RunGit(['new-branch', options.newbranch])
4829
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004830 cl = Changelist(**cl_kwargs)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004831
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004832 if cl.IsGerrit():
4833 if options.reject:
4834 parser.error('--reject is not supported with Gerrit codereview.')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004835 if options.directory:
4836 parser.error('--directory is not supported with Gerrit codereview.')
4837
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004838 if detected_codereview_from_url:
4839 print('canonical issue/change URL: %s (type: %s)\n' %
4840 (cl.GetIssueURL(), target_issue_arg.codereview))
4841
4842 return cl.CMDPatchWithParsedIssue(target_issue_arg, options.reject,
Aaron Gable62619a32017-06-16 08:22:09 -07004843 options.nocommit, options.directory,
4844 options.force)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004845
4846
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004847def GetTreeStatus(url=None):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004848 """Fetches the tree status and returns either 'open', 'closed',
4849 'unknown' or 'unset'."""
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004850 url = url or settings.GetTreeStatusUrl(error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004851 if url:
4852 status = urllib2.urlopen(url).read().lower()
4853 if status.find('closed') != -1 or status == '0':
4854 return 'closed'
4855 elif status.find('open') != -1 or status == '1':
4856 return 'open'
4857 return 'unknown'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004858 return 'unset'
4859
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004860
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004861def GetTreeStatusReason():
4862 """Fetches the tree status from a json url and returns the message
4863 with the reason for the tree to be opened or closed."""
msb@chromium.orgbf1a7ba2011-02-01 16:21:46 +00004864 url = settings.GetTreeStatusUrl()
4865 json_url = urlparse.urljoin(url, '/current?format=json')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004866 connection = urllib2.urlopen(json_url)
4867 status = json.loads(connection.read())
4868 connection.close()
4869 return status['message']
4870
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004871
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004872@metrics.collector.collect_metrics('git cl tree')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004873def CMDtree(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004874 """Shows the status of the tree."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004875 _, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004876 status = GetTreeStatus()
4877 if 'unset' == status:
vapiera7fbd5a2016-06-16 09:17:49 -07004878 print('You must configure your tree status URL by running "git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004879 return 2
4880
vapiera7fbd5a2016-06-16 09:17:49 -07004881 print('The tree is %s' % status)
4882 print()
4883 print(GetTreeStatusReason())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004884 if status != 'open':
4885 return 1
4886 return 0
4887
4888
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004889@metrics.collector.collect_metrics('git cl try')
maruel@chromium.org15192402012-09-06 12:38:29 +00004890def CMDtry(parser, args):
qyearsley1fdfcb62016-10-24 13:22:03 -07004891 """Triggers try jobs using either BuildBucket or CQ dry run."""
tandrii1838bad2016-10-06 00:10:52 -07004892 group = optparse.OptionGroup(parser, 'Try job options')
maruel@chromium.org15192402012-09-06 12:38:29 +00004893 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004894 '-b', '--bot', action='append',
4895 help=('IMPORTANT: specify ONE builder per --bot flag. Use it multiple '
4896 'times to specify multiple builders. ex: '
4897 '"-b win_rel -b win_layout". See '
4898 'the try server waterfall for the builders name and the tests '
4899 'available.'))
maruel@chromium.org15192402012-09-06 12:38:29 +00004900 group.add_option(
borenet6c0efe62016-10-19 08:13:29 -07004901 '-B', '--bucket', default='',
4902 help=('Buildbucket bucket to send the try requests.'))
4903 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004904 '-m', '--master', default='',
Nodir Turakulovf6929a12017-10-09 12:34:44 -07004905 help=('DEPRECATED, use -B. The try master where to run the builds.'))
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00004906 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004907 '-r', '--revision',
tandriif7b29d42016-10-07 08:45:41 -07004908 help='Revision to use for the try job; default: the revision will '
4909 'be determined by the try recipe that builder runs, which usually '
4910 'defaults to HEAD of origin/master')
maruel@chromium.org15192402012-09-06 12:38:29 +00004911 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004912 '-c', '--clobber', action='store_true', default=False,
tandriif7b29d42016-10-07 08:45:41 -07004913 help='Force a clobber before building; that is don\'t do an '
tandrii1838bad2016-10-06 00:10:52 -07004914 'incremental build')
maruel@chromium.org15192402012-09-06 12:38:29 +00004915 group.add_option(
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08004916 '--category', default='git_cl_try', help='Specify custom build category.')
4917 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004918 '--project',
4919 help='Override which project to use. Projects are defined '
tandriif7b29d42016-10-07 08:45:41 -07004920 'in recipe to determine to which repository or directory to '
4921 'apply the patch')
maruel@chromium.org15192402012-09-06 12:38:29 +00004922 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004923 '-p', '--property', dest='properties', action='append', default=[],
4924 help='Specify generic properties in the form -p key1=value1 -p '
tandriif7b29d42016-10-07 08:45:41 -07004925 'key2=value2 etc. The value will be treated as '
4926 'json if decodable, or as string otherwise. '
4927 'NOTE: using this may make your try job not usable for CQ, '
4928 'which will then schedule another try job with default properties')
sheyang@chromium.orgdb375572015-08-17 19:22:23 +00004929 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004930 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4931 help='Host of buildbucket. The default host is %default.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004932 parser.add_option_group(group)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004933 auth.add_auth_options(parser)
Koji Ishii31c14782018-01-08 17:17:33 +09004934 _add_codereview_issue_select_options(parser)
maruel@chromium.org15192402012-09-06 12:38:29 +00004935 options, args = parser.parse_args(args)
Koji Ishii31c14782018-01-08 17:17:33 +09004936 _process_codereview_issue_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004937 auth_config = auth.extract_auth_config_from_options(options)
maruel@chromium.org15192402012-09-06 12:38:29 +00004938
Nodir Turakulovf6929a12017-10-09 12:34:44 -07004939 if options.master and options.master.startswith('luci.'):
4940 parser.error(
4941 '-m option does not support LUCI. Please pass -B %s' % options.master)
machenbach@chromium.org45453142015-09-15 08:45:22 +00004942 # Make sure that all properties are prop=value pairs.
4943 bad_params = [x for x in options.properties if '=' not in x]
4944 if bad_params:
4945 parser.error('Got properties with missing "=": %s' % bad_params)
4946
maruel@chromium.org15192402012-09-06 12:38:29 +00004947 if args:
4948 parser.error('Unknown arguments: %s' % args)
4949
Koji Ishii31c14782018-01-08 17:17:33 +09004950 cl = Changelist(auth_config=auth_config, issue=options.issue,
4951 codereview=options.forced_codereview)
maruel@chromium.org15192402012-09-06 12:38:29 +00004952 if not cl.GetIssue():
4953 parser.error('Need to upload first')
4954
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01004955 if cl.IsGerrit():
4956 # HACK: warm up Gerrit change detail cache to save on RPCs.
4957 cl._codereview_impl._GetChangeDetail(['DETAILED_ACCOUNTS', 'ALL_REVISIONS'])
4958
tandriie113dfd2016-10-11 10:20:12 -07004959 error_message = cl.CannotTriggerTryJobReason()
4960 if error_message:
qyearsley99e2cdf2016-10-23 12:51:41 -07004961 parser.error('Can\'t trigger try jobs: %s' % error_message)
jrobbins@chromium.org16f10f72014-06-24 22:14:36 +00004962
borenet6c0efe62016-10-19 08:13:29 -07004963 if options.bucket and options.master:
4964 parser.error('Only one of --bucket and --master may be used.')
4965
qyearsley1fdfcb62016-10-24 13:22:03 -07004966 buckets = _get_bucket_map(cl, options, parser)
phajdan.jr@chromium.org8da7f272014-03-14 01:28:39 +00004967
qyearsleydd49f942016-10-28 11:57:22 -07004968 # If no bots are listed and we couldn't get a list based on PRESUBMIT files,
4969 # then we default to triggering a CQ dry run (see http://crbug.com/625697).
qyearsley1fdfcb62016-10-24 13:22:03 -07004970 if not buckets:
qyearsley1fdfcb62016-10-24 13:22:03 -07004971 if options.verbose:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07004972 print('git cl try with no bots now defaults to CQ dry run.')
4973 print('Scheduling CQ dry run on: %s' % cl.GetIssueURL())
4974 return cl.SetCQState(_CQState.DRY_RUN)
stip@chromium.org43064fd2013-12-18 20:07:44 +00004975
borenet6c0efe62016-10-19 08:13:29 -07004976 for builders in buckets.itervalues():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00004977 if any('triggered' in b for b in builders):
vapiera7fbd5a2016-06-16 09:17:49 -07004978 print('ERROR You are trying to send a job to a triggered bot. This type '
tandriide281ae2016-10-12 06:02:30 -07004979 'of bot requires an initial job from a parent (usually a builder). '
4980 'Instead send your job to the parent.\n'
vapiera7fbd5a2016-06-16 09:17:49 -07004981 'Bot list: %s' % builders, file=sys.stderr)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00004982 return 1
ilevy@chromium.orgf3b21232012-09-24 20:48:55 +00004983
ilevy@chromium.org36e420b2013-08-06 23:21:12 +00004984 patchset = cl.GetMostRecentPatchset()
tandrii568043b2016-10-11 07:49:18 -07004985 try:
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08004986 _trigger_try_jobs(auth_config, cl, buckets, options, patchset)
tandrii568043b2016-10-11 07:49:18 -07004987 except BuildbucketResponseException as ex:
4988 print('ERROR: %s' % ex)
4989 return 1
maruel@chromium.org15192402012-09-06 12:38:29 +00004990 return 0
4991
4992
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004993@metrics.collector.collect_metrics('git cl try-results')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004994def CMDtry_results(parser, args):
tandrii1838bad2016-10-06 00:10:52 -07004995 """Prints info about try jobs associated with current CL."""
4996 group = optparse.OptionGroup(parser, 'Try job results options')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004997 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004998 '-p', '--patchset', type=int, help='patchset number if not current.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004999 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005000 '--print-master', action='store_true', help='print master name as well.')
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +00005001 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005002 '--color', action='store_true', default=setup_color.IS_TTY,
5003 help='force color output, useful when piping output.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005004 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005005 '--buildbucket-host', default='cr-buildbucket.appspot.com',
5006 help='Host of buildbucket. The default host is %default.')
qyearsley53f48a12016-09-01 10:45:13 -07005007 group.add_option(
Stefan Zager1306bd02017-06-22 19:26:46 -07005008 '--json', help=('Path of JSON output file to write try job results to,'
5009 'or "-" for stdout.'))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005010 parser.add_option_group(group)
5011 auth.add_auth_options(parser)
Stefan Zager27db3f22017-10-10 15:15:01 -07005012 _add_codereview_issue_select_options(parser)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005013 options, args = parser.parse_args(args)
Stefan Zager27db3f22017-10-10 15:15:01 -07005014 _process_codereview_issue_select_options(parser, options)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005015 if args:
5016 parser.error('Unrecognized args: %s' % ' '.join(args))
5017
5018 auth_config = auth.extract_auth_config_from_options(options)
Stefan Zager27db3f22017-10-10 15:15:01 -07005019 cl = Changelist(
5020 issue=options.issue, codereview=options.forced_codereview,
5021 auth_config=auth_config)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005022 if not cl.GetIssue():
5023 parser.error('Need to upload first')
5024
tandrii221ab252016-10-06 08:12:04 -07005025 patchset = options.patchset
5026 if not patchset:
5027 patchset = cl.GetMostRecentPatchset()
5028 if not patchset:
5029 parser.error('Codereview doesn\'t know about issue %s. '
5030 'No access to issue or wrong issue number?\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01005031 'Either upload first, or pass --patchset explicitly' %
tandrii221ab252016-10-06 08:12:04 -07005032 cl.GetIssue())
5033
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005034 try:
tandrii221ab252016-10-06 08:12:04 -07005035 jobs = fetch_try_jobs(auth_config, cl, options.buildbucket_host, patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005036 except BuildbucketResponseException as ex:
vapiera7fbd5a2016-06-16 09:17:49 -07005037 print('Buildbucket error: %s' % ex)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005038 return 1
qyearsley53f48a12016-09-01 10:45:13 -07005039 if options.json:
5040 write_try_results_json(options.json, jobs)
5041 else:
5042 print_try_jobs(options, jobs)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005043 return 0
5044
5045
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005046@subcommand.usage('[new upstream branch]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005047@metrics.collector.collect_metrics('git cl upstream')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005048def CMDupstream(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005049 """Prints or sets the name of the upstream branch, if any."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00005050 _, args = parser.parse_args(args)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005051 if len(args) > 1:
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005052 parser.error('Unrecognized args: %s' % ' '.join(args))
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005053
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005054 cl = Changelist()
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005055 if args:
5056 # One arg means set upstream branch.
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00005057 branch = cl.GetBranch()
stip7a3dd352016-09-22 17:32:28 -07005058 RunGit(['branch', '--set-upstream-to', args[0], branch])
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005059 cl = Changelist()
vapiera7fbd5a2016-06-16 09:17:49 -07005060 print('Upstream branch set to %s' % (cl.GetUpstreamBranch(),))
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00005061
5062 # Clear configured merge-base, if there is one.
5063 git_common.remove_merge_base(branch)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005064 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005065 print(cl.GetUpstreamBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005066 return 0
5067
5068
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005069@metrics.collector.collect_metrics('git cl web')
thestig@chromium.org00858c82013-12-02 23:08:03 +00005070def CMDweb(parser, args):
5071 """Opens the current CL in the web browser."""
5072 _, args = parser.parse_args(args)
5073 if args:
5074 parser.error('Unrecognized args: %s' % ' '.join(args))
5075
5076 issue_url = Changelist().GetIssueURL()
5077 if not issue_url:
vapiera7fbd5a2016-06-16 09:17:49 -07005078 print('ERROR No issue to open', file=sys.stderr)
thestig@chromium.org00858c82013-12-02 23:08:03 +00005079 return 1
5080
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00005081 # Redirect I/O before invoking browser to hide its output. For example, this
5082 # allows to hide "Created new window in existing browser session." message
5083 # from Chrome. Based on https://stackoverflow.com/a/2323563.
5084 saved_stdout = os.dup(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00005085 saved_stderr = os.dup(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00005086 os.close(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00005087 os.close(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00005088 os.open(os.devnull, os.O_RDWR)
5089 try:
5090 webbrowser.open(issue_url)
5091 finally:
5092 os.dup2(saved_stdout, 1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00005093 os.dup2(saved_stderr, 2)
thestig@chromium.org00858c82013-12-02 23:08:03 +00005094 return 0
5095
5096
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005097@metrics.collector.collect_metrics('git cl set-commit')
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005098def CMDset_commit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005099 """Sets the commit bit to trigger the Commit Queue."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005100 parser.add_option('-d', '--dry-run', action='store_true',
5101 help='trigger in dry run mode')
5102 parser.add_option('-c', '--clear', action='store_true',
5103 help='stop CQ run, if any')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005104 auth.add_auth_options(parser)
iannuccie53c9352016-08-17 14:40:40 -07005105 _add_codereview_issue_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005106 options, args = parser.parse_args(args)
iannuccie53c9352016-08-17 14:40:40 -07005107 _process_codereview_issue_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005108 auth_config = auth.extract_auth_config_from_options(options)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005109 if args:
5110 parser.error('Unrecognized args: %s' % ' '.join(args))
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005111 if options.dry_run and options.clear:
5112 parser.error('Make up your mind: both --dry-run and --clear not allowed')
5113
iannuccie53c9352016-08-17 14:40:40 -07005114 cl = Changelist(auth_config=auth_config, issue=options.issue,
5115 codereview=options.forced_codereview)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005116 if options.clear:
tandriid9e5ce52016-07-13 02:32:59 -07005117 state = _CQState.NONE
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005118 elif options.dry_run:
5119 state = _CQState.DRY_RUN
5120 else:
5121 state = _CQState.COMMIT
5122 if not cl.GetIssue():
5123 parser.error('Must upload the issue first')
tandrii9de9ec62016-07-13 03:01:59 -07005124 cl.SetCQState(state)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005125 return 0
5126
5127
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005128@metrics.collector.collect_metrics('git cl set-close')
groby@chromium.org411034a2013-02-26 15:12:01 +00005129def CMDset_close(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005130 """Closes the issue."""
iannuccie53c9352016-08-17 14:40:40 -07005131 _add_codereview_issue_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005132 auth.add_auth_options(parser)
5133 options, args = parser.parse_args(args)
iannuccie53c9352016-08-17 14:40:40 -07005134 _process_codereview_issue_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005135 auth_config = auth.extract_auth_config_from_options(options)
groby@chromium.org411034a2013-02-26 15:12:01 +00005136 if args:
5137 parser.error('Unrecognized args: %s' % ' '.join(args))
iannuccie53c9352016-08-17 14:40:40 -07005138 cl = Changelist(auth_config=auth_config, issue=options.issue,
5139 codereview=options.forced_codereview)
groby@chromium.org411034a2013-02-26 15:12:01 +00005140 # Ensure there actually is an issue to close.
Aaron Gable7139a4e2017-09-05 17:53:09 -07005141 if not cl.GetIssue():
5142 DieWithError('ERROR No issue to close')
groby@chromium.org411034a2013-02-26 15:12:01 +00005143 cl.CloseIssue()
5144 return 0
5145
5146
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005147@metrics.collector.collect_metrics('git cl diff')
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005148def CMDdiff(parser, args):
wychen@chromium.org37b2ec02015-04-03 00:49:15 +00005149 """Shows differences between local tree and last upload."""
thomasanderson074beb22016-08-29 14:03:20 -07005150 parser.add_option(
5151 '--stat',
5152 action='store_true',
5153 dest='stat',
5154 help='Generate a diffstat')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005155 auth.add_auth_options(parser)
5156 options, args = parser.parse_args(args)
5157 auth_config = auth.extract_auth_config_from_options(options)
5158 if args:
5159 parser.error('Unrecognized args: %s' % ' '.join(args))
wychen@chromium.org46309bf2015-04-03 21:04:49 +00005160
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005161 cl = Changelist(auth_config=auth_config)
sbc@chromium.org78dc9842013-11-25 18:43:44 +00005162 issue = cl.GetIssue()
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005163 branch = cl.GetBranch()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00005164 if not issue:
5165 DieWithError('No issue found for current branch (%s)' % branch)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005166
Aaron Gablea718c3e2017-08-28 17:47:28 -07005167 base = cl._GitGetBranchConfigValue('last-upload-hash')
5168 if not base:
5169 base = cl._GitGetBranchConfigValue('gerritsquashhash')
5170 if not base:
5171 detail = cl._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
5172 revision_info = detail['revisions'][detail['current_revision']]
5173 fetch_info = revision_info['fetch']['http']
5174 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
5175 base = 'FETCH_HEAD'
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005176
Aaron Gablea718c3e2017-08-28 17:47:28 -07005177 cmd = ['git', 'diff']
5178 if options.stat:
5179 cmd.append('--stat')
5180 cmd.append(base)
5181 subprocess2.check_call(cmd)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005182
5183 return 0
5184
5185
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005186@metrics.collector.collect_metrics('git cl owners')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005187def CMDowners(parser, args):
Dirk Prankebf980882017-09-02 15:08:00 -07005188 """Finds potential owners for reviewing."""
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005189 parser.add_option(
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00005190 '--ignore-current',
5191 action='store_true',
5192 help='Ignore the CL\'s current reviewers and start from scratch.')
5193 parser.add_option(
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00005194 '--ignore-self',
5195 action='store_true',
5196 help='Do not consider CL\'s author as an owners.')
5197 parser.add_option(
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005198 '--no-color',
5199 action='store_true',
5200 help='Use this option to disable color output')
Dirk Prankebf980882017-09-02 15:08:00 -07005201 parser.add_option(
5202 '--batch',
5203 action='store_true',
5204 help='Do not run interactively, just suggest some')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005205 auth.add_auth_options(parser)
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005206 options, args = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005207 auth_config = auth.extract_auth_config_from_options(options)
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005208
5209 author = RunGit(['config', 'user.email']).strip() or None
5210
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005211 cl = Changelist(auth_config=auth_config)
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005212
5213 if args:
5214 if len(args) > 1:
5215 parser.error('Unknown args')
5216 base_branch = args[0]
5217 else:
5218 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005219 base_branch = cl.GetCommonAncestorWithUpstream()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005220
5221 change = cl.GetChange(base_branch, None)
Dirk Prankebf980882017-09-02 15:08:00 -07005222 affected_files = [f.LocalPath() for f in change.AffectedFiles()]
5223
5224 if options.batch:
5225 db = owners.Database(change.RepositoryRoot(), file, os.path)
5226 print('\n'.join(db.reviewers_for(affected_files, author)))
5227 return 0
5228
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005229 return owners_finder.OwnersFinder(
Dirk Prankebf980882017-09-02 15:08:00 -07005230 affected_files,
Jochen Eisinger72606f82017-04-04 10:44:18 +02005231 change.RepositoryRoot(),
Edward Lemur707d70b2018-02-07 00:50:14 +01005232 author,
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00005233 [] if options.ignore_current else cl.GetReviewers(),
Edward Lemur707d70b2018-02-07 00:50:14 +01005234 fopen=file, os_path=os.path,
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02005235 disable_color=options.no_color,
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00005236 override_files=change.OriginalOwnersFiles(),
5237 ignore_author=options.ignore_self).run()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005238
5239
Aiden Bennerc08566e2018-10-03 17:52:42 +00005240def BuildGitDiffCmd(diff_type, upstream_commit, args, allow_prefix=False):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005241 """Generates a diff command."""
5242 # Generate diff for the current branch's changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +00005243 diff_cmd = ['-c', 'core.quotePath=false', 'diff', '--no-ext-diff']
5244
Aiden Benner6c18a1a2018-11-23 20:18:23 +00005245 if allow_prefix:
5246 # explicitly setting --src-prefix and --dst-prefix is necessary in the
5247 # case that diff.noprefix is set in the user's git config.
5248 diff_cmd += ['--src-prefix=a/', '--dst-prefix=b/']
5249 else:
Aiden Bennerc08566e2018-10-03 17:52:42 +00005250 diff_cmd += ['--no-prefix']
5251
5252 diff_cmd += [diff_type, upstream_commit, '--']
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005253
5254 if args:
5255 for arg in args:
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005256 if os.path.isdir(arg) or os.path.isfile(arg):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005257 diff_cmd.append(arg)
5258 else:
5259 DieWithError('Argument "%s" is not a file or a directory' % arg)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005260
5261 return diff_cmd
5262
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005263
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005264def MatchingFileType(file_name, extensions):
5265 """Returns true if the file name ends with one of the given extensions."""
5266 return bool([ext for ext in extensions if file_name.lower().endswith(ext)])
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005267
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005268
enne@chromium.org555cfe42014-01-29 18:21:39 +00005269@subcommand.usage('[files or directories to diff]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005270@metrics.collector.collect_metrics('git cl format')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005271def CMDformat(parser, args):
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005272 """Runs auto-formatting tools (clang-format etc.) on the diff."""
Christopher Lamc5ba6922017-01-24 11:19:14 +11005273 CLANG_EXTS = ['.cc', '.cpp', '.h', '.m', '.mm', '.proto', '.java']
kylechar58edce22016-06-17 06:07:51 -07005274 GN_EXTS = ['.gn', '.gni', '.typemap']
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00005275 parser.add_option('--full', action='store_true',
5276 help='Reformat the full content of all touched files')
5277 parser.add_option('--dry-run', action='store_true',
5278 help='Don\'t modify any file on disk.')
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005279 parser.add_option(
5280 '--python',
5281 action='store_true',
5282 default=None,
5283 help='Enables python formatting on all python files.')
5284 parser.add_option(
5285 '--no-python',
5286 action='store_true',
5287 dest='python',
5288 help='Disables python formatting on all python files. '
5289 'Takes precedence over --python. '
5290 'If neither --python or --no-python are set, python '
5291 'files that have a .style.yapf file in an ancestor '
5292 'directory will be formatted.')
Christopher Lamc5ba6922017-01-24 11:19:14 +11005293 parser.add_option('--js', action='store_true',
5294 help='Format javascript code with clang-format.')
wittman@chromium.org04d5a222014-03-07 18:30:42 +00005295 parser.add_option('--diff', action='store_true',
5296 help='Print diff to stdout rather than modifying files.')
Ilya Shermane081cbe2017-08-15 17:51:04 -07005297 parser.add_option('--presubmit', action='store_true',
5298 help='Used when running the script from a presubmit.')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005299 opts, args = parser.parse_args(args)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005300
Daniel Chengc55eecf2016-12-30 03:11:02 -08005301 # Normalize any remaining args against the current path, so paths relative to
5302 # the current directory are still resolved as expected.
5303 args = [os.path.join(os.getcwd(), arg) for arg in args]
5304
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005305 # git diff generates paths against the root of the repository. Change
5306 # to that directory so clang-format can find files even within subdirs.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005307 rel_base_path = settings.GetRelativeRoot()
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005308 if rel_base_path:
5309 os.chdir(rel_base_path)
5310
digit@chromium.org29e47272013-05-17 17:01:46 +00005311 # Grab the merge-base commit, i.e. the upstream commit of the current
5312 # branch when it was created or the last time it was rebased. This is
5313 # to cover the case where the user may have called "git fetch origin",
5314 # moving the origin branch to a newer commit, but hasn't rebased yet.
5315 upstream_commit = None
5316 cl = Changelist()
5317 upstream_branch = cl.GetUpstreamBranch()
5318 if upstream_branch:
5319 upstream_commit = RunGit(['merge-base', 'HEAD', upstream_branch])
5320 upstream_commit = upstream_commit.strip()
5321
5322 if not upstream_commit:
5323 DieWithError('Could not find base commit for this branch. '
5324 'Are you in detached state?')
5325
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005326 changed_files_cmd = BuildGitDiffCmd('--name-only', upstream_commit, args)
5327 diff_output = RunGit(changed_files_cmd)
5328 diff_files = diff_output.splitlines()
jkarlin@chromium.orgad21b922016-01-28 17:48:42 +00005329 # Filter out files deleted by this CL
5330 diff_files = [x for x in diff_files if os.path.isfile(x)]
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005331
Christopher Lamc5ba6922017-01-24 11:19:14 +11005332 if opts.js:
Deepanjan Roy605dd312018-07-02 17:48:54 +00005333 CLANG_EXTS.extend(['.js', '.ts'])
Christopher Lamc5ba6922017-01-24 11:19:14 +11005334
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005335 clang_diff_files = [x for x in diff_files if MatchingFileType(x, CLANG_EXTS)]
5336 python_diff_files = [x for x in diff_files if MatchingFileType(x, ['.py'])]
5337 dart_diff_files = [x for x in diff_files if MatchingFileType(x, ['.dart'])]
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005338 gn_diff_files = [x for x in diff_files if MatchingFileType(x, GN_EXTS)]
digit@chromium.org29e47272013-05-17 17:01:46 +00005339
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +00005340 top_dir = os.path.normpath(
5341 RunGit(["rev-parse", "--show-toplevel"]).rstrip('\n'))
5342
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005343 # Set to 2 to signal to CheckPatchFormatted() that this patch isn't
5344 # formatted. This is used to block during the presubmit.
5345 return_value = 0
5346
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005347 if clang_diff_files:
techtonik@gmail.com5573df12016-04-12 18:34:10 +00005348 # Locate the clang-format binary in the checkout
5349 try:
5350 clang_format_tool = clang_format.FindClangFormatToolInChromiumTree()
vapierfd77ac72016-06-16 08:33:57 -07005351 except clang_format.NotFoundError as e:
techtonik@gmail.com5573df12016-04-12 18:34:10 +00005352 DieWithError(e)
5353
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005354 if opts.full:
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005355 cmd = [clang_format_tool]
5356 if not opts.dry_run and not opts.diff:
5357 cmd.append('-i')
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005358 stdout = RunCommand(cmd + clang_diff_files, cwd=top_dir)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005359 if opts.diff:
5360 sys.stdout.write(stdout)
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005361 else:
5362 env = os.environ.copy()
5363 env['PATH'] = str(os.path.dirname(clang_format_tool))
5364 try:
5365 script = clang_format.FindClangFormatScriptInChromiumTree(
5366 'clang-format-diff.py')
vapierfd77ac72016-06-16 08:33:57 -07005367 except clang_format.NotFoundError as e:
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005368 DieWithError(e)
digit@chromium.orgd6ddc1c2013-10-25 15:36:32 +00005369
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005370 cmd = [sys.executable, script, '-p0']
5371 if not opts.dry_run and not opts.diff:
5372 cmd.append('-i')
digit@chromium.orgd6ddc1c2013-10-25 15:36:32 +00005373
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005374 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, clang_diff_files)
5375 diff_output = RunGit(diff_cmd)
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005376
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005377 stdout = RunCommand(cmd, stdin=diff_output, cwd=top_dir, env=env)
5378 if opts.diff:
5379 sys.stdout.write(stdout)
5380 if opts.dry_run and len(stdout) > 0:
5381 return_value = 2
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005382
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005383 # Similar code to above, but using yapf on .py files rather than clang-format
5384 # on C/C++ files
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005385 py_explicitly_disabled = opts.python is not None and not opts.python
5386 if python_diff_files and not py_explicitly_disabled:
Aiden Bennere47ac152018-11-20 16:44:03 +00005387 depot_tools_path = os.path.dirname(os.path.abspath(__file__))
5388 yapf_tool = os.path.join(depot_tools_path, 'yapf')
5389 if sys.platform.startswith('win'):
5390 yapf_tool += '.bat'
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005391
Aiden Bennerc08566e2018-10-03 17:52:42 +00005392 # If we couldn't find a yapf file we'll default to the chromium style
5393 # specified in depot_tools.
Aiden Bennerc08566e2018-10-03 17:52:42 +00005394 chromium_default_yapf_style = os.path.join(depot_tools_path,
5395 YAPF_CONFIG_FILENAME)
Aiden Bennerc08566e2018-10-03 17:52:42 +00005396 # Used for caching.
5397 yapf_configs = {}
5398 for f in python_diff_files:
5399 # Find the yapf style config for the current file, defaults to depot
5400 # tools default.
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005401 _FindYapfConfigFile(f, yapf_configs, top_dir)
5402
5403 # Turn on python formatting by default if a yapf config is specified.
5404 # This breaks in the case of this repo though since the specified
5405 # style file is also the global default.
5406 if opts.python is None:
5407 filtered_py_files = []
5408 for f in python_diff_files:
5409 if _FindYapfConfigFile(f, yapf_configs, top_dir) is not None:
5410 filtered_py_files.append(f)
5411 else:
5412 filtered_py_files = python_diff_files
5413
5414 # Note: yapf still seems to fix indentation of the entire file
5415 # even if line ranges are specified.
5416 # See https://github.com/google/yapf/issues/499
5417 if not opts.full and filtered_py_files:
5418 py_line_diffs = _ComputeDiffLineRanges(filtered_py_files, upstream_commit)
5419
5420 for f in filtered_py_files:
5421 yapf_config = _FindYapfConfigFile(f, yapf_configs, top_dir)
5422 if yapf_config is None:
5423 yapf_config = chromium_default_yapf_style
Aiden Bennerc08566e2018-10-03 17:52:42 +00005424
5425 cmd = [yapf_tool, '--style', yapf_config, f]
5426
5427 has_formattable_lines = False
5428 if not opts.full:
5429 # Only run yapf over changed line ranges.
5430 for diff_start, diff_len in py_line_diffs[f]:
5431 diff_end = diff_start + diff_len - 1
5432 # Yapf errors out if diff_end < diff_start but this
5433 # is a valid line range diff for a removal.
5434 if diff_end >= diff_start:
5435 has_formattable_lines = True
5436 cmd += ['-l', '{}-{}'.format(diff_start, diff_end)]
5437 # If all line diffs were removals we have nothing to format.
5438 if not has_formattable_lines:
5439 continue
5440
5441 if opts.diff or opts.dry_run:
5442 cmd += ['--diff']
5443 # Will return non-zero exit code if non-empty diff.
5444 stdout = RunCommand(cmd, error_ok=True, cwd=top_dir)
5445 if opts.diff:
5446 sys.stdout.write(stdout)
5447 elif len(stdout) > 0:
5448 return_value = 2
5449 else:
5450 cmd += ['-i']
5451 RunCommand(cmd, cwd=top_dir)
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005452
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005453 # Dart's formatter does not have the nice property of only operating on
5454 # modified chunks, so hard code full.
5455 if dart_diff_files:
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005456 try:
5457 command = [dart_format.FindDartFmtToolInChromiumTree()]
5458 if not opts.dry_run and not opts.diff:
5459 command.append('-w')
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005460 command.extend(dart_diff_files)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005461
ppi@chromium.org6593d932016-03-03 15:41:15 +00005462 stdout = RunCommand(command, cwd=top_dir)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005463 if opts.dry_run and stdout:
5464 return_value = 2
5465 except dart_format.NotFoundError as e:
vapiera7fbd5a2016-06-16 09:17:49 -07005466 print('Warning: Unable to check Dart code formatting. Dart SDK not '
5467 'found in this checkout. Files in other languages are still '
5468 'formatted.')
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005469
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005470 # Format GN build files. Always run on full build files for canonical form.
5471 if gn_diff_files:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005472 cmd = ['gn', 'format']
brettw4b8ed592016-08-05 16:19:12 -07005473 if opts.dry_run or opts.diff:
5474 cmd.append('--dry-run')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005475 for gn_diff_file in gn_diff_files:
brettw4b8ed592016-08-05 16:19:12 -07005476 gn_ret = subprocess2.call(cmd + [gn_diff_file],
5477 shell=sys.platform == 'win32',
5478 cwd=top_dir)
5479 if opts.dry_run and gn_ret == 2:
5480 return_value = 2 # Not formatted.
5481 elif opts.diff and gn_ret == 2:
5482 # TODO this should compute and print the actual diff.
5483 print("This change has GN build file diff for " + gn_diff_file)
5484 elif gn_ret != 0:
5485 # For non-dry run cases (and non-2 return values for dry-run), a
5486 # nonzero error code indicates a failure, probably because the file
5487 # doesn't parse.
5488 DieWithError("gn format failed on " + gn_diff_file +
5489 "\nTry running 'gn format' on this file manually.")
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005490
Ilya Shermane081cbe2017-08-15 17:51:04 -07005491 # Skip the metrics formatting from the global presubmit hook. These files have
5492 # a separate presubmit hook that issues an error if the files need formatting,
5493 # whereas the top-level presubmit script merely issues a warning. Formatting
5494 # these files is somewhat slow, so it's important not to duplicate the work.
5495 if not opts.presubmit:
5496 for xml_dir in GetDirtyMetricsDirs(diff_files):
5497 tool_dir = os.path.join(top_dir, xml_dir)
5498 cmd = [os.path.join(tool_dir, 'pretty_print.py'), '--non-interactive']
5499 if opts.dry_run or opts.diff:
5500 cmd.append('--diff')
Ilya Sherman235b70d2017-08-22 17:46:38 -07005501 stdout = RunCommand(cmd, cwd=top_dir)
Ilya Shermane081cbe2017-08-15 17:51:04 -07005502 if opts.diff:
5503 sys.stdout.write(stdout)
5504 if opts.dry_run and stdout:
5505 return_value = 2 # Not formatted.
Alexei Svitkinef3cac412017-02-06 11:08:50 -05005506
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005507 return return_value
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005508
Steven Holte2e664bf2017-04-21 13:10:47 -07005509def GetDirtyMetricsDirs(diff_files):
5510 xml_diff_files = [x for x in diff_files if MatchingFileType(x, ['.xml'])]
5511 metrics_xml_dirs = [
5512 os.path.join('tools', 'metrics', 'actions'),
5513 os.path.join('tools', 'metrics', 'histograms'),
5514 os.path.join('tools', 'metrics', 'rappor'),
5515 os.path.join('tools', 'metrics', 'ukm')]
5516 for xml_dir in metrics_xml_dirs:
5517 if any(file.startswith(xml_dir) for file in xml_diff_files):
5518 yield xml_dir
5519
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005520
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005521@subcommand.usage('<codereview url or issue id>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005522@metrics.collector.collect_metrics('git cl checkout')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005523def CMDcheckout(parser, args):
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005524 """Checks out a branch associated with a given Rietveld or Gerrit issue."""
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005525 _, args = parser.parse_args(args)
5526
5527 if len(args) != 1:
5528 parser.print_help()
5529 return 1
5530
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005531 issue_arg = ParseIssueNumberArgument(args[0])
tandrii@chromium.orgde6c9a12016-04-11 15:33:53 +00005532 if not issue_arg.valid:
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02005533 parser.error('invalid codereview url or CL id')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005534
tandrii@chromium.orgabd27e52016-04-11 15:43:32 +00005535 target_issue = str(issue_arg.issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005536
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005537 def find_issues(issueprefix):
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00005538 output = RunGit(['config', '--local', '--get-regexp',
5539 r'branch\..*\.%s' % issueprefix],
5540 error_ok=True)
5541 for key, issue in [x.split() for x in output.splitlines()]:
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005542 if issue == target_issue:
5543 yield re.sub(r'branch\.(.*)\.%s' % issueprefix, r'\1', key)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005544
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005545 branches = []
5546 for cls in _CODEREVIEW_IMPLEMENTATIONS.values():
tandrii5d48c322016-08-18 16:19:37 -07005547 branches.extend(find_issues(cls.IssueConfigKey()))
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005548 if len(branches) == 0:
vapiera7fbd5a2016-06-16 09:17:49 -07005549 print('No branch found for issue %s.' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005550 return 1
5551 if len(branches) == 1:
5552 RunGit(['checkout', branches[0]])
5553 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005554 print('Multiple branches match issue %s:' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005555 for i in range(len(branches)):
vapiera7fbd5a2016-06-16 09:17:49 -07005556 print('%d: %s' % (i, branches[i]))
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005557 which = raw_input('Choose by index: ')
5558 try:
5559 RunGit(['checkout', branches[int(which)]])
5560 except (IndexError, ValueError):
vapiera7fbd5a2016-06-16 09:17:49 -07005561 print('Invalid selection, not checking out any branch.')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005562 return 1
5563
5564 return 0
5565
5566
maruel@chromium.org29404b52014-09-08 22:58:00 +00005567def CMDlol(parser, args):
5568 # This command is intentionally undocumented.
vapiera7fbd5a2016-06-16 09:17:49 -07005569 print(zlib.decompress(base64.b64decode(
thakis@chromium.org3421c992014-11-02 02:20:32 +00005570 'eNptkLEOwyAMRHe+wupCIqW57v0Vq84WqWtXyrcXnCBsmgMJ+/SSAxMZgRB6NzE'
5571 'E2ObgCKJooYdu4uAQVffUEoE1sRQLxAcqzd7uK2gmStrll1ucV3uZyaY5sXyDd9'
5572 'JAnN+lAXsOMJ90GANAi43mq5/VeeacylKVgi8o6F1SC63FxnagHfJUTfUYdCR/W'
vapiera7fbd5a2016-06-16 09:17:49 -07005573 'Ofe+0dHL7PicpytKP750Fh1q2qnLVof4w8OZWNY')))
maruel@chromium.org29404b52014-09-08 22:58:00 +00005574 return 0
5575
5576
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005577class OptionParser(optparse.OptionParser):
5578 """Creates the option parse and add --verbose support."""
5579 def __init__(self, *args, **kwargs):
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005580 optparse.OptionParser.__init__(
5581 self, *args, prog='git cl', version=__version__, **kwargs)
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005582 self.add_option(
5583 '-v', '--verbose', action='count', default=0,
5584 help='Use 2 times for more debugging info')
5585
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005586 def parse_args(self, args=None, _values=None):
Andrii Shyshkalov46f20cd2018-10-30 06:42:54 +00005587 try:
5588 return self._parse_args(args)
5589 finally:
5590 # Regardless of success or failure of args parsing, we want to report
5591 # metrics, but only after logging has been initialized (if parsing
5592 # succeeded).
5593 global settings
5594 settings = Settings()
5595
5596 if not metrics.DISABLE_METRICS_COLLECTION:
5597 # GetViewVCUrl ultimately calls logging method.
5598 project_url = settings.GetViewVCUrl().strip('/+')
5599 if project_url in metrics_utils.KNOWN_PROJECT_URLS:
5600 metrics.collector.add('project_urls', [project_url])
5601
5602 def _parse_args(self, args=None):
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005603 # Create an optparse.Values object that will store only the actual passed
5604 # options, without the defaults.
5605 actual_options = optparse.Values()
5606 _, args = optparse.OptionParser.parse_args(self, args, actual_options)
5607 # Create an optparse.Values object with the default options.
5608 options = optparse.Values(self.get_default_values().__dict__)
5609 # Update it with the options passed by the user.
5610 options._update_careful(actual_options.__dict__)
5611 # Store the options passed by the user in an _actual_options attribute.
5612 # We store only the keys, and not the values, since the values can contain
5613 # arbitrary information, which might be PII.
5614 metrics.collector.add('arguments', actual_options.__dict__.keys())
5615
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005616 levels = [logging.WARNING, logging.INFO, logging.DEBUG]
Andrii Shyshkalov5b04a572017-01-23 17:44:41 +01005617 logging.basicConfig(
5618 level=levels[min(options.verbose, len(levels) - 1)],
5619 format='[%(levelname).1s%(asctime)s %(process)d %(thread)d '
5620 '%(filename)s] %(message)s')
Edward Lemur83bd7f42018-10-10 00:14:21 +00005621
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005622 return options, args
5623
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005624
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005625def main(argv):
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005626 if sys.hexversion < 0x02060000:
vapiera7fbd5a2016-06-16 09:17:49 -07005627 print('\nYour python version %s is unsupported, please upgrade.\n' %
5628 (sys.version.split(' ', 1)[0],), file=sys.stderr)
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005629 return 2
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00005630
maruel@chromium.org39c0b222013-08-17 16:57:01 +00005631 colorize_CMDstatus_doc()
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005632 dispatcher = subcommand.CommandDispatcher(__name__)
5633 try:
5634 return dispatcher.execute(OptionParser(), argv)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +00005635 except auth.AuthenticationError as e:
5636 DieWithError(str(e))
vapierfd77ac72016-06-16 08:33:57 -07005637 except urllib2.HTTPError as e:
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005638 if e.code != 500:
5639 raise
5640 DieWithError(
5641 ('AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
5642 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
sbc@chromium.org013731e2015-02-26 18:28:43 +00005643 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005644
5645
5646if __name__ == '__main__':
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00005647 # These affect sys.stdout so do it outside of main() to simplify mocks in
5648 # unit testing.
maruel@chromium.org6f09cd92011-04-01 16:38:12 +00005649 fix_encoding.fix_encoding()
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00005650 setup_color.init()
Edward Lemur6f812e12018-07-31 22:45:57 +00005651 with metrics.collector.print_notice_and_exit():
sbc@chromium.org013731e2015-02-26 18:28:43 +00005652 sys.exit(main(sys.argv[1:]))