blob: 9fc56f1dba1431bc441b433b3dae17520e467997 [file] [log] [blame]
Edward Lemur1f3bafb2019-10-08 17:56:33 +00001#!/usr/bin/env vpython
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02002# Copyright (c) 2013 The Chromium Authors. All rights reserved.
maruel@chromium.org725f1c32011-04-01 20:24:54 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006# Copyright (C) 2008 Evan Martin <martine@danga.com>
7
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00008"""A git-command for integrating reviews on Gerrit."""
maruel@chromium.org725f1c32011-04-01 20:24:54 +00009
vapiera7fbd5a2016-06-16 09:17:49 -070010from __future__ import print_function
11
thakis@chromium.org3421c992014-11-02 02:20:32 +000012import base64
rmistry@google.com2dd99862015-06-22 12:22:18 +000013import collections
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010014import datetime
Brian Sheedyb4307d52019-12-02 19:18:17 +000015import fnmatch
Edward Lemur202c5592019-10-21 22:44:52 +000016import httplib2
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +010017import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000018import json
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000019import logging
calamity@chromium.orgcf197482016-04-29 20:15:53 +000020import multiprocessing
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000021import optparse
22import os
23import re
Andrii Shyshkalov353637c2017-03-14 16:52:18 +010024import shutil
ukai@chromium.org78c4b982012-02-14 02:20:26 +000025import stat
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000026import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070027import tempfile
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000028import textwrap
Edward Lemurfec80c42018-11-01 23:14:14 +000029import time
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000030import uuid
thestig@chromium.org00858c82013-12-02 23:08:03 +000031import webbrowser
thakis@chromium.org3421c992014-11-02 02:20:32 +000032import zlib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000033
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000034from third_party import colorama
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000035import auth
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +000036import clang_format
maruel@chromium.org6f09cd92011-04-01 16:38:12 +000037import fix_encoding
maruel@chromium.org0e0436a2011-10-25 13:32:41 +000038import gclient_utils
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +000039import gerrit_util
iannucci@chromium.org9e849272014-04-04 00:31:55 +000040import git_common
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +000041import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000042import git_new_branch
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000043import metrics
Edward Lesmes93277a72018-10-18 22:04:26 +000044import metrics_utils
Edward Lesmesb34cd6d2021-01-07 01:05:41 +000045import owners
Edward Lesmeseeca9c62020-11-20 00:00:17 +000046import owners_client
iannucci@chromium.org9e849272014-04-04 00:31:55 +000047import owners_finder
Lei Zhangb8c62cf2020-07-15 20:09:37 +000048import presubmit_canned_checks
maruel@chromium.org2a74d372011-03-29 19:05:50 +000049import presubmit_support
50import scm
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000051import setup_color
Francois Dorayd42c6812017-05-30 15:10:20 -040052import split_cl
maruel@chromium.org0633fb42013-08-16 20:06:14 +000053import subcommand
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +000054import subprocess2
maruel@chromium.org2a74d372011-03-29 19:05:50 +000055import watchlists
56
Edward Lemur79d4f992019-11-11 23:49:02 +000057from third_party import six
58from six.moves import urllib
59
60
61if sys.version_info.major == 3:
62 basestring = (str,) # pylint: disable=redefined-builtin
63
Edward Lemurb9830242019-10-30 22:19:20 +000064
tandrii7400cf02016-06-21 08:48:07 -070065__version__ = '2.0'
maruel@chromium.org2a74d372011-03-29 19:05:50 +000066
Edward Lemur0f58ae42019-04-30 17:24:12 +000067# Traces for git push will be stored in a traces directory inside the
68# depot_tools checkout.
69DEPOT_TOOLS = os.path.dirname(os.path.abspath(__file__))
70TRACES_DIR = os.path.join(DEPOT_TOOLS, 'traces')
Edward Lemur227d5102020-02-25 23:45:35 +000071PRESUBMIT_SUPPORT = os.path.join(DEPOT_TOOLS, 'presubmit_support.py')
Edward Lemur0f58ae42019-04-30 17:24:12 +000072
73# When collecting traces, Git hashes will be reduced to 6 characters to reduce
74# the size after compression.
75GIT_HASH_RE = re.compile(r'\b([a-f0-9]{6})[a-f0-9]{34}\b', flags=re.I)
76# Used to redact the cookies from the gitcookies file.
77GITCOOKIES_REDACT_RE = re.compile(r'1/.*')
78
Edward Lemurd4d1ba42019-09-20 21:46:37 +000079MAX_ATTEMPTS = 3
80
Edward Lemur1b52d872019-05-09 21:12:12 +000081# The maximum number of traces we will keep. Multiplied by 3 since we store
82# 3 files per trace.
83MAX_TRACES = 3 * 10
Edward Lemur5737f022019-05-17 01:24:00 +000084# Message to be displayed to the user to inform where to find the traces for a
85# git-cl upload execution.
Edward Lemur0f58ae42019-04-30 17:24:12 +000086TRACES_MESSAGE = (
Edward Lemur1b52d872019-05-09 21:12:12 +000087'\n'
Edward Lemur5737f022019-05-17 01:24:00 +000088'The traces of this git-cl execution have been recorded at:\n'
Edward Lemur1b52d872019-05-09 21:12:12 +000089' %(trace_name)s-traces.zip\n'
Edward Lemur5737f022019-05-17 01:24:00 +000090'Copies of your gitcookies file and git config have been recorded at:\n'
91' %(trace_name)s-git-info.zip\n')
Edward Lemur1b52d872019-05-09 21:12:12 +000092# Format of the message to be stored as part of the traces to give developers a
93# better context when they go through traces.
94TRACES_README_FORMAT = (
95'Date: %(now)s\n'
96'\n'
97'Change: https://%(gerrit_host)s/q/%(change_id)s\n'
98'Title: %(title)s\n'
99'\n'
100'%(description)s\n'
101'\n'
102'Execution time: %(execution_time)s\n'
103'Exit code: %(exit_code)s\n') + TRACES_MESSAGE
Edward Lemur0f58ae42019-04-30 17:24:12 +0000104
Aaron Gable1bc7bfe2016-12-19 10:08:14 -0800105POSTUPSTREAM_HOOK = '.git/hooks/post-cl-land'
Henrique Ferreiroff249622019-11-28 23:19:29 +0000106DESCRIPTION_BACKUP_FILE = '.git_cl_description_backup'
rmistry@google.comc68112d2015-03-03 12:48:06 +0000107REFS_THAT_ALIAS_TO_OTHER_REFS = {
108 'refs/remotes/origin/lkgr': 'refs/remotes/origin/master',
109 'refs/remotes/origin/lkcr': 'refs/remotes/origin/master',
110}
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000111
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000112DEFAULT_OLD_BRANCH = 'refs/remotes/origin/master'
113DEFAULT_NEW_BRANCH = 'refs/remotes/origin/main'
114
thestig@chromium.org44202a22014-03-11 19:22:18 +0000115# Valid extensions for files we want to lint.
116DEFAULT_LINT_REGEX = r"(.*\.cpp|.*\.cc|.*\.h)"
117DEFAULT_LINT_IGNORE_REGEX = r"$^"
118
Aiden Bennerc08566e2018-10-03 17:52:42 +0000119# File name for yapf style config files.
120YAPF_CONFIG_FILENAME = '.style.yapf'
121
Edward Lesmes50da7702020-03-30 19:23:43 +0000122# The issue, patchset and codereview server are stored on git config for each
123# branch under branch.<branch-name>.<config-key>.
124ISSUE_CONFIG_KEY = 'gerritissue'
125PATCHSET_CONFIG_KEY = 'gerritpatchset'
126CODEREVIEW_SERVER_CONFIG_KEY = 'gerritserver'
127
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000128# Shortcut since it quickly becomes repetitive.
maruel@chromium.org2e23ce32013-05-07 12:42:28 +0000129Fore = colorama.Fore
maruel@chromium.org90541732011-04-01 17:54:18 +0000130
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000131# Initialized in main()
132settings = None
133
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100134# Used by tests/git_cl_test.py to add extra logging.
135# Inside the weirdly failing test, add this:
136# >>> self.mock(git_cl, '_IS_BEING_TESTED', True)
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700137# And scroll up to see the stack trace printed.
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100138_IS_BEING_TESTED = False
139
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000140
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000141_KNOWN_GERRIT_TO_SHORT_URLS = {
142 'https://chrome-internal-review.googlesource.com': 'https://crrev.com/i',
143 'https://chromium-review.googlesource.com': 'https://crrev.com/c',
144}
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000145assert len(_KNOWN_GERRIT_TO_SHORT_URLS) == len(
146 set(_KNOWN_GERRIT_TO_SHORT_URLS.values())), 'must have unique values'
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000147
148
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000149class GitPushError(Exception):
150 pass
151
152
Christopher Lamf732cd52017-01-24 12:40:11 +1100153def DieWithError(message, change_desc=None):
154 if change_desc:
155 SaveDescriptionBackup(change_desc)
Josip Sokcevic953278a2020-02-28 19:46:36 +0000156 print('\n ** Content of CL description **\n' +
157 '='*72 + '\n' +
158 change_desc.description + '\n' +
159 '='*72 + '\n')
Christopher Lamf732cd52017-01-24 12:40:11 +1100160
vapiera7fbd5a2016-06-16 09:17:49 -0700161 print(message, file=sys.stderr)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000162 sys.exit(1)
163
164
Christopher Lamf732cd52017-01-24 12:40:11 +1100165def SaveDescriptionBackup(change_desc):
Henrique Ferreiro5ae48172019-11-29 16:14:42 +0000166 backup_path = os.path.join(DEPOT_TOOLS, DESCRIPTION_BACKUP_FILE)
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000167 print('\nsaving CL description to %s\n' % backup_path)
Josip906bfde2020-01-31 22:38:49 +0000168 with open(backup_path, 'w') as backup_file:
169 backup_file.write(change_desc.description)
Christopher Lamf732cd52017-01-24 12:40:11 +1100170
171
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000172def GetNoGitPagerEnv():
173 env = os.environ.copy()
174 # 'cat' is a magical git string that disables pagers on all platforms.
175 env['GIT_PAGER'] = 'cat'
176 return env
177
vadimsh@chromium.org566a02a2014-08-22 01:34:13 +0000178
bsep@chromium.org627d9002016-04-29 00:00:52 +0000179def RunCommand(args, error_ok=False, error_message=None, shell=False, **kwargs):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000180 try:
Edward Lemur79d4f992019-11-11 23:49:02 +0000181 stdout = subprocess2.check_output(args, shell=shell, **kwargs)
182 return stdout.decode('utf-8', 'replace')
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000183 except subprocess2.CalledProcessError as e:
184 logging.debug('Failed running %s', args)
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000185 if not error_ok:
Alan Cutter594fd332020-07-21 23:55:27 +0000186 message = error_message or e.stdout.decode('utf-8', 'replace') or ''
187 DieWithError('Command "%s" failed.\n%s' % (' '.join(args), message))
Edward Lemur79d4f992019-11-11 23:49:02 +0000188 return e.stdout.decode('utf-8', 'replace')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000189
190
191def RunGit(args, **kwargs):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000192 """Returns stdout."""
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000193 return RunCommand(['git'] + args, **kwargs)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000194
195
enne@chromium.org3b7e15c2014-01-21 17:44:47 +0000196def RunGitWithCode(args, suppress_stderr=False):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000197 """Returns return code and stdout."""
tandrii5d48c322016-08-18 16:19:37 -0700198 if suppress_stderr:
Edward Lesmescf06cad2020-12-14 22:03:23 +0000199 stderr = subprocess2.DEVNULL
tandrii5d48c322016-08-18 16:19:37 -0700200 else:
201 stderr = sys.stderr
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000202 try:
tandrii5d48c322016-08-18 16:19:37 -0700203 (out, _), code = subprocess2.communicate(['git'] + args,
204 env=GetNoGitPagerEnv(),
205 stdout=subprocess2.PIPE,
206 stderr=stderr)
Edward Lemur79d4f992019-11-11 23:49:02 +0000207 return code, out.decode('utf-8', 'replace')
tandrii5d48c322016-08-18 16:19:37 -0700208 except subprocess2.CalledProcessError as e:
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +0900209 logging.debug('Failed running %s', ['git'] + args)
Edward Lemur79d4f992019-11-11 23:49:02 +0000210 return e.returncode, e.stdout.decode('utf-8', 'replace')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000211
212
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000213def RunGitSilent(args):
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000214 """Returns stdout, suppresses stderr and ignores the return code."""
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000215 return RunGitWithCode(args, suppress_stderr=True)[1]
216
217
tandrii2a16b952016-10-19 07:09:44 -0700218def time_sleep(seconds):
219 # Use this so that it can be mocked in tests without interfering with python
220 # system machinery.
tandrii2a16b952016-10-19 07:09:44 -0700221 return time.sleep(seconds)
222
223
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000224def time_time():
225 # Use this so that it can be mocked in tests without interfering with python
226 # system machinery.
227 return time.time()
228
229
Edward Lemur1b52d872019-05-09 21:12:12 +0000230def datetime_now():
231 # Use this so that it can be mocked in tests without interfering with python
232 # system machinery.
233 return datetime.datetime.now()
234
235
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100236def confirm_or_exit(prefix='', action='confirm'):
237 """Asks user to press enter to continue or press Ctrl+C to abort."""
238 if not prefix or prefix.endswith('\n'):
239 mid = 'Press'
Andrii Shyshkalov353637c2017-03-14 16:52:18 +0100240 elif prefix.endswith('.') or prefix.endswith('?'):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100241 mid = ' Press'
242 elif prefix.endswith(' '):
243 mid = 'press'
244 else:
245 mid = ' press'
Edward Lesmesae3586b2020-03-23 21:21:14 +0000246 gclient_utils.AskForData(
247 '%s%s Enter to %s, or Ctrl+C to abort' % (prefix, mid, action))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100248
249
250def ask_for_explicit_yes(prompt):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000251 """Returns whether user typed 'y' or 'yes' to confirm the given prompt."""
Edward Lesmesae3586b2020-03-23 21:21:14 +0000252 result = gclient_utils.AskForData(prompt + ' [Yes/No]: ').lower()
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100253 while True:
254 if 'yes'.startswith(result):
255 return True
256 if 'no'.startswith(result):
257 return False
Edward Lesmesae3586b2020-03-23 21:21:14 +0000258 result = gclient_utils.AskForData('Please, type yes or no: ').lower()
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100259
260
machenbach@chromium.org45453142015-09-15 08:45:22 +0000261def _get_properties_from_options(options):
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000262 prop_list = getattr(options, 'properties', [])
263 properties = dict(x.split('=', 1) for x in prop_list)
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000264 for key, val in properties.items():
machenbach@chromium.org45453142015-09-15 08:45:22 +0000265 try:
266 properties[key] = json.loads(val)
267 except ValueError:
268 pass # If a value couldn't be evaluated, treat it as a string.
269 return properties
270
271
Edward Lemur4c707a22019-09-24 21:13:43 +0000272def _call_buildbucket(http, buildbucket_host, method, request):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000273 """Calls a buildbucket v2 method and returns the parsed json response."""
274 headers = {
275 'Accept': 'application/json',
276 'Content-Type': 'application/json',
277 }
278 request = json.dumps(request)
279 url = 'https://%s/prpc/buildbucket.v2.Builds/%s' % (buildbucket_host, method)
280
281 logging.info('POST %s with %s' % (url, request))
282
283 attempts = 1
284 time_to_sleep = 1
285 while True:
286 response, content = http.request(url, 'POST', body=request, headers=headers)
287 if response.status == 200:
288 return json.loads(content[4:])
289 if attempts >= MAX_ATTEMPTS or 400 <= response.status < 500:
290 msg = '%s error when calling POST %s with %s: %s' % (
291 response.status, url, request, content)
292 raise BuildbucketResponseException(msg)
293 logging.debug(
294 '%s error when calling POST %s with %s. '
295 'Sleeping for %d seconds and retrying...' % (
296 response.status, url, request, time_to_sleep))
297 time.sleep(time_to_sleep)
298 time_to_sleep *= 2
299 attempts += 1
300
301 assert False, 'unreachable'
302
303
Edward Lemur6215c792019-10-03 21:59:05 +0000304def _parse_bucket(raw_bucket):
305 legacy = True
306 project = bucket = None
307 if '/' in raw_bucket:
308 legacy = False
309 project, bucket = raw_bucket.split('/', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000310 # Assume luci.<project>.<bucket>.
Edward Lemur6215c792019-10-03 21:59:05 +0000311 elif raw_bucket.startswith('luci.'):
312 project, bucket = raw_bucket[len('luci.'):].split('.', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000313 # Otherwise, assume prefix is also the project name.
Edward Lemur6215c792019-10-03 21:59:05 +0000314 elif '.' in raw_bucket:
315 project = raw_bucket.split('.')[0]
316 bucket = raw_bucket
317 # Legacy buckets.
Edward Lemur45768512020-03-02 19:03:14 +0000318 if legacy and project and bucket:
Edward Lemur6215c792019-10-03 21:59:05 +0000319 print('WARNING Please use %s/%s to specify the bucket.' % (project, bucket))
320 return project, bucket
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000321
322
Quinten Yearsley777660f2020-03-04 23:37:06 +0000323def _trigger_tryjobs(changelist, jobs, options, patchset):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000324 """Sends a request to Buildbucket to trigger tryjobs for a changelist.
qyearsley1fdfcb62016-10-24 13:22:03 -0700325
326 Args:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000327 changelist: Changelist that the tryjobs are associated with.
Edward Lemur45768512020-03-02 19:03:14 +0000328 jobs: A list of (project, bucket, builder).
qyearsley1fdfcb62016-10-24 13:22:03 -0700329 options: Command-line options.
330 """
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000331 print('Scheduling jobs on:')
Edward Lemur45768512020-03-02 19:03:14 +0000332 for project, bucket, builder in jobs:
333 print(' %s/%s: %s' % (project, bucket, builder))
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000334 print('To see results here, run: git cl try-results')
335 print('To see results in browser, run: git cl web')
tandriide281ae2016-10-12 06:02:30 -0700336
Quinten Yearsley777660f2020-03-04 23:37:06 +0000337 requests = _make_tryjob_schedule_requests(changelist, jobs, options, patchset)
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000338 if not requests:
339 return
340
Edward Lemur5b929a42019-10-21 17:57:39 +0000341 http = auth.Authenticator().authorize(httplib2.Http())
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000342 http.force_exception_to_status_code = True
343
344 batch_request = {'requests': requests}
345 batch_response = _call_buildbucket(
346 http, options.buildbucket_host, 'Batch', batch_request)
347
348 errors = [
349 ' ' + response['error']['message']
350 for response in batch_response.get('responses', [])
351 if 'error' in response
352 ]
353 if errors:
354 raise BuildbucketResponseException(
355 'Failed to schedule builds for some bots:\n%s' % '\n'.join(errors))
356
357
Quinten Yearsley777660f2020-03-04 23:37:06 +0000358def _make_tryjob_schedule_requests(changelist, jobs, options, patchset):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000359 """Constructs requests for Buildbucket to trigger tryjobs."""
Edward Lemurf0faf482019-09-25 20:40:17 +0000360 gerrit_changes = [changelist.GetGerritChange(patchset)]
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000361 shared_properties = {
362 'category': options.ensure_value('category', 'git_cl_try')
363 }
364 if options.ensure_value('clobber', False):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000365 shared_properties['clobber'] = True
366 shared_properties.update(_get_properties_from_options(options) or {})
367
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000368 shared_tags = [{'key': 'user_agent', 'value': 'git_cl_try'}]
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000369 if options.ensure_value('retry_failed', False):
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000370 shared_tags.append({'key': 'retry_failed',
371 'value': '1'})
372
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000373 requests = []
Edward Lemur45768512020-03-02 19:03:14 +0000374 for (project, bucket, builder) in jobs:
375 properties = shared_properties.copy()
376 if 'presubmit' in builder.lower():
377 properties['dry_run'] = 'true'
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000378
Edward Lemur45768512020-03-02 19:03:14 +0000379 requests.append({
380 'scheduleBuild': {
381 'requestId': str(uuid.uuid4()),
382 'builder': {
383 'project': getattr(options, 'project', None) or project,
384 'bucket': bucket,
385 'builder': builder,
386 },
387 'gerritChanges': gerrit_changes,
388 'properties': properties,
389 'tags': [
390 {'key': 'builder', 'value': builder},
391 ] + shared_tags,
392 }
393 })
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000394
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000395 if options.ensure_value('revision', None):
Edward Lemur45768512020-03-02 19:03:14 +0000396 requests[-1]['scheduleBuild']['gitilesCommit'] = {
397 'host': gerrit_changes[0]['host'],
398 'project': gerrit_changes[0]['project'],
399 'id': options.revision
400 }
Anthony Polito1a5fe232020-01-24 23:17:52 +0000401
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000402 return requests
kjellander@chromium.org44424542015-06-02 18:35:29 +0000403
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000404
Quinten Yearsley777660f2020-03-04 23:37:06 +0000405def _fetch_tryjobs(changelist, buildbucket_host, patchset=None):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000406 """Fetches tryjobs from buildbucket.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000407
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000408 Returns list of buildbucket.v2.Build with the try jobs for the changelist.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000409 """
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000410 fields = ['id', 'builder', 'status', 'createTime', 'tags']
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000411 request = {
412 'predicate': {
413 'gerritChanges': [changelist.GetGerritChange(patchset)],
414 },
415 'fields': ','.join('builds.*.' + field for field in fields),
416 }
tandrii221ab252016-10-06 08:12:04 -0700417
Edward Lemur5b929a42019-10-21 17:57:39 +0000418 authenticator = auth.Authenticator()
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000419 if authenticator.has_cached_credentials():
420 http = authenticator.authorize(httplib2.Http())
421 else:
vapiera7fbd5a2016-06-16 09:17:49 -0700422 print('Warning: Some results might be missing because %s' %
423 # Get the message on how to login.
Edward Lemurba5bc992019-09-23 22:59:17 +0000424 (auth.LoginRequiredError().message,))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000425 http = httplib2.Http()
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000426 http.force_exception_to_status_code = True
427
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000428 response = _call_buildbucket(http, buildbucket_host, 'SearchBuilds', request)
429 return response.get('builds', [])
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000430
Edward Lemur45768512020-03-02 19:03:14 +0000431
Edward Lemur5b929a42019-10-21 17:57:39 +0000432def _fetch_latest_builds(changelist, buildbucket_host, latest_patchset=None):
Quinten Yearsley983111f2019-09-26 17:18:48 +0000433 """Fetches builds from the latest patchset that has builds (within
434 the last few patchsets).
435
436 Args:
Quinten Yearsley983111f2019-09-26 17:18:48 +0000437 changelist (Changelist): The CL to fetch builds for
438 buildbucket_host (str): Buildbucket host, e.g. "cr-buildbucket.appspot.com"
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +0000439 lastest_patchset(int|NoneType): the patchset to start fetching builds from.
440 If None (default), starts with the latest available patchset.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000441 Returns:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000442 A tuple (builds, patchset) where builds is a list of buildbucket.v2.Build,
443 and patchset is the patchset number where those builds came from.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000444 """
445 assert buildbucket_host
446 assert changelist.GetIssue(), 'CL must be uploaded first'
447 assert changelist.GetCodereviewServer(), 'CL must be uploaded first'
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +0000448 if latest_patchset is None:
449 assert changelist.GetMostRecentPatchset()
450 ps = changelist.GetMostRecentPatchset()
451 else:
452 assert latest_patchset > 0, latest_patchset
453 ps = latest_patchset
454
Quinten Yearsley983111f2019-09-26 17:18:48 +0000455 min_ps = max(1, ps - 5)
456 while ps >= min_ps:
Quinten Yearsley777660f2020-03-04 23:37:06 +0000457 builds = _fetch_tryjobs(changelist, buildbucket_host, patchset=ps)
Quinten Yearsley983111f2019-09-26 17:18:48 +0000458 if len(builds):
459 return builds, ps
460 ps -= 1
461 return [], 0
462
463
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000464def _filter_failed_for_retry(all_builds):
465 """Returns a list of buckets/builders that are worth retrying.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000466
467 Args:
Quinten Yearsley777660f2020-03-04 23:37:06 +0000468 all_builds (list): Builds, in the format returned by _fetch_tryjobs,
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000469 i.e. a list of buildbucket.v2.Builds which includes status and builder
470 info.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000471
472 Returns:
Edward Lemur45768512020-03-02 19:03:14 +0000473 A dict {(proj, bucket): [builders]}. This is the same format accepted by
Quinten Yearsley777660f2020-03-04 23:37:06 +0000474 _trigger_tryjobs.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000475 """
Edward Lemur45768512020-03-02 19:03:14 +0000476 grouped = {}
477 for build in all_builds:
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000478 builder = build['builder']
Edward Lemur45768512020-03-02 19:03:14 +0000479 key = (builder['project'], builder['bucket'], builder['builder'])
480 grouped.setdefault(key, []).append(build)
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000481
Edward Lemur45768512020-03-02 19:03:14 +0000482 jobs = []
483 for (project, bucket, builder), builds in grouped.items():
484 if 'triggered' in builder:
485 print('WARNING: Not scheduling %s. Triggered bots require an initial job '
486 'from a parent. Please schedule a manual job for the parent '
487 'instead.')
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000488 continue
489 if any(b['status'] in ('STARTED', 'SCHEDULED') for b in builds):
490 # Don't retry if any are running.
491 continue
Edward Lemur45768512020-03-02 19:03:14 +0000492 # If builder had several builds, retry only if the last one failed.
493 # This is a bit different from CQ, which would re-use *any* SUCCESS-full
494 # build, but in case of retrying failed jobs retrying a flaky one makes
495 # sense.
496 builds = sorted(builds, key=lambda b: b['createTime'])
497 if builds[-1]['status'] not in ('FAILURE', 'INFRA_FAILURE'):
498 continue
499 # Don't retry experimental build previously triggered by CQ.
500 if any(t['key'] == 'cq_experimental' and t['value'] == 'true'
501 for t in builds[-1]['tags']):
502 continue
503 jobs.append((project, bucket, builder))
504
505 # Sort the jobs to make testing easier.
506 return sorted(jobs)
Quinten Yearsley983111f2019-09-26 17:18:48 +0000507
508
Quinten Yearsley777660f2020-03-04 23:37:06 +0000509def _print_tryjobs(options, builds):
510 """Prints nicely result of _fetch_tryjobs."""
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000511 if not builds:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000512 print('No tryjobs scheduled.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000513 return
514
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000515 longest_builder = max(len(b['builder']['builder']) for b in builds)
516 name_fmt = '{builder:<%d}' % longest_builder
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000517 if options.print_master:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000518 longest_bucket = max(len(b['builder']['bucket']) for b in builds)
519 name_fmt = ('{bucket:>%d} ' % longest_bucket) + name_fmt
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000520
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000521 builds_by_status = {}
522 for b in builds:
523 builds_by_status.setdefault(b['status'], []).append({
524 'id': b['id'],
525 'name': name_fmt.format(
526 builder=b['builder']['builder'], bucket=b['builder']['bucket']),
527 })
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000528
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000529 sort_key = lambda b: (b['name'], b['id'])
530
531 def print_builds(title, builds, fmt=None, color=None):
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000532 """Pop matching builds from `builds` dict and print them."""
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000533 if not builds:
534 return
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000535
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000536 fmt = fmt or '{name} https://ci.chromium.org/b/{id}'
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +0000537 if not options.color or color is None:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000538 colorize = lambda x: x
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000539 else:
540 colorize = lambda x: '%s%s%s' % (color, x, Fore.RESET)
541
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000542 print(colorize(title))
543 for b in sorted(builds, key=sort_key):
544 print(' ', colorize(fmt.format(**b)))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000545
546 total = len(builds)
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000547 print_builds(
548 'Successes:', builds_by_status.pop('SUCCESS', []), color=Fore.GREEN)
549 print_builds(
550 'Infra Failures:', builds_by_status.pop('INFRA_FAILURE', []),
551 color=Fore.MAGENTA)
552 print_builds('Failures:', builds_by_status.pop('FAILURE', []), color=Fore.RED)
553 print_builds('Canceled:', builds_by_status.pop('CANCELED', []), fmt='{name}',
554 color=Fore.MAGENTA)
Andrii Shyshkalov792630c2020-10-19 16:47:44 +0000555 print_builds('Started:', builds_by_status.pop('STARTED', []),
556 color=Fore.YELLOW)
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000557 print_builds(
558 'Scheduled:', builds_by_status.pop('SCHEDULED', []), fmt='{name} id={id}')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000559 # The last section is just in case buildbucket API changes OR there is a bug.
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000560 print_builds(
561 'Other:', sum(builds_by_status.values(), []), fmt='{name} id={id}')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000562 print('Total: %d tryjobs' % total)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000563
564
Aiden Bennerc08566e2018-10-03 17:52:42 +0000565def _ComputeDiffLineRanges(files, upstream_commit):
566 """Gets the changed line ranges for each file since upstream_commit.
567
568 Parses a git diff on provided files and returns a dict that maps a file name
569 to an ordered list of range tuples in the form (start_line, count).
570 Ranges are in the same format as a git diff.
571 """
572 # If files is empty then diff_output will be a full diff.
573 if len(files) == 0:
574 return {}
575
Aiden Benner6c18a1a2018-11-23 20:18:23 +0000576 # Take the git diff and find the line ranges where there are changes.
Jamie Madill3671a6a2019-10-24 15:13:21 +0000577 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, files, allow_prefix=True)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000578 diff_output = RunGit(diff_cmd)
579
580 pattern = r'(?:^diff --git a/(?:.*) b/(.*))|(?:^@@.*\+(.*) @@)'
581 # 2 capture groups
582 # 0 == fname of diff file
583 # 1 == 'diff_start,diff_count' or 'diff_start'
584 # will match each of
585 # diff --git a/foo.foo b/foo.py
586 # @@ -12,2 +14,3 @@
587 # @@ -12,2 +17 @@
588 # running re.findall on the above string with pattern will give
589 # [('foo.py', ''), ('', '14,3'), ('', '17')]
590
591 curr_file = None
592 line_diffs = {}
593 for match in re.findall(pattern, diff_output, flags=re.MULTILINE):
594 if match[0] != '':
595 # Will match the second filename in diff --git a/a.py b/b.py.
596 curr_file = match[0]
597 line_diffs[curr_file] = []
598 else:
599 # Matches +14,3
600 if ',' in match[1]:
601 diff_start, diff_count = match[1].split(',')
602 else:
603 # Single line changes are of the form +12 instead of +12,1.
604 diff_start = match[1]
605 diff_count = 1
606
607 diff_start = int(diff_start)
608 diff_count = int(diff_count)
609
610 # If diff_count == 0 this is a removal we can ignore.
611 line_diffs[curr_file].append((diff_start, diff_count))
612
613 return line_diffs
614
615
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000616def _FindYapfConfigFile(fpath, yapf_config_cache, top_dir=None):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000617 """Checks if a yapf file is in any parent directory of fpath until top_dir.
618
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000619 Recursively checks parent directories to find yapf file and if no yapf file
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000620 is found returns None. Uses yapf_config_cache as a cache for previously found
621 configs.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000622 """
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000623 fpath = os.path.abspath(fpath)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000624 # Return result if we've already computed it.
625 if fpath in yapf_config_cache:
626 return yapf_config_cache[fpath]
627
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000628 parent_dir = os.path.dirname(fpath)
629 if os.path.isfile(fpath):
630 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000631 else:
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000632 # Otherwise fpath is a directory
633 yapf_file = os.path.join(fpath, YAPF_CONFIG_FILENAME)
634 if os.path.isfile(yapf_file):
635 ret = yapf_file
636 elif fpath == top_dir or parent_dir == fpath:
637 # If we're at the top level directory, or if we're at root
638 # there is no provided style.
639 ret = None
640 else:
641 # Otherwise recurse on the current directory.
642 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000643 yapf_config_cache[fpath] = ret
644 return ret
645
646
Brian Sheedyb4307d52019-12-02 19:18:17 +0000647def _GetYapfIgnorePatterns(top_dir):
648 """Returns all patterns in the .yapfignore file.
Brian Sheedy59b06a82019-10-14 17:03:29 +0000649
650 yapf is supposed to handle the ignoring of files listed in .yapfignore itself,
651 but this functionality appears to break when explicitly passing files to
652 yapf for formatting. According to
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000653 https://github.com/google/yapf/blob/HEAD/README.rst#excluding-files-from-formatting-yapfignore,
Brian Sheedy59b06a82019-10-14 17:03:29 +0000654 the .yapfignore file should be in the directory that yapf is invoked from,
655 which we assume to be the top level directory in this case.
656
657 Args:
658 top_dir: The top level directory for the repository being formatted.
659
660 Returns:
Brian Sheedyb4307d52019-12-02 19:18:17 +0000661 A set of all fnmatch patterns to be ignored.
Brian Sheedy59b06a82019-10-14 17:03:29 +0000662 """
663 yapfignore_file = os.path.join(top_dir, '.yapfignore')
Brian Sheedyb4307d52019-12-02 19:18:17 +0000664 ignore_patterns = set()
Brian Sheedy59b06a82019-10-14 17:03:29 +0000665 if not os.path.exists(yapfignore_file):
Brian Sheedyb4307d52019-12-02 19:18:17 +0000666 return ignore_patterns
Brian Sheedy59b06a82019-10-14 17:03:29 +0000667
Brian Sheedyb4307d52019-12-02 19:18:17 +0000668 with open(yapfignore_file) as f:
669 for line in f.readlines():
670 stripped_line = line.strip()
671 # Comments and blank lines should be ignored.
672 if stripped_line.startswith('#') or stripped_line == '':
673 continue
674 ignore_patterns.add(stripped_line)
675 return ignore_patterns
676
677
678def _FilterYapfIgnoredFiles(filepaths, patterns):
679 """Filters out any filepaths that match any of the given patterns.
680
681 Args:
682 filepaths: An iterable of strings containing filepaths to filter.
683 patterns: An iterable of strings containing fnmatch patterns to filter on.
684
685 Returns:
686 A list of strings containing all the elements of |filepaths| that did not
687 match any of the patterns in |patterns|.
688 """
689 # Not inlined so that tests can use the same implementation.
690 return [f for f in filepaths
691 if not any(fnmatch.fnmatch(f, p) for p in patterns)]
Brian Sheedy59b06a82019-10-14 17:03:29 +0000692
693
Aaron Gable13101a62018-02-09 13:20:41 -0800694def print_stats(args):
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000695 """Prints statistics about the change to the user."""
696 # --no-ext-diff is broken in some versions of Git, so try to work around
697 # this by overriding the environment (but there is still a problem if the
698 # git config key "diff.external" is used).
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000699 env = GetNoGitPagerEnv()
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000700 if 'GIT_EXTERNAL_DIFF' in env:
701 del env['GIT_EXTERNAL_DIFF']
iannucci@chromium.org79540052012-10-19 23:15:26 +0000702
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000703 return subprocess2.call(
Aaron Gable13101a62018-02-09 13:20:41 -0800704 ['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] + args,
Edward Lemur0db01f02019-11-12 22:01:51 +0000705 env=env)
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000706
707
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000708class BuildbucketResponseException(Exception):
709 pass
710
711
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000712class Settings(object):
713 def __init__(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000714 self.cc = None
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000715 self.root = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000716 self.tree_status_url = None
717 self.viewvc_url = None
718 self.updated = False
ukai@chromium.orge8077812012-02-03 03:41:46 +0000719 self.is_gerrit = None
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000720 self.squash_gerrit_uploads = None
tandrii@chromium.org28253532016-04-14 13:46:56 +0000721 self.gerrit_skip_ensure_authenticated = None
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000722 self.git_editor = None
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000723 self.format_full_by_default = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000724
Edward Lemur26964072020-02-19 19:18:51 +0000725 def _LazyUpdateIfNeeded(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000726 """Updates the settings from a codereview.settings file, if available."""
Edward Lemur26964072020-02-19 19:18:51 +0000727 if self.updated:
728 return
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000729
Edward Lemur26964072020-02-19 19:18:51 +0000730 # The only value that actually changes the behavior is
731 # autoupdate = "false". Everything else means "true".
732 autoupdate = (
733 scm.GIT.GetConfig(self.GetRoot(), 'rietveld.autoupdate', '').lower())
734
735 cr_settings_file = FindCodereviewSettingsFile()
736 if autoupdate != 'false' and cr_settings_file:
737 LoadCodereviewSettingsFromFile(cr_settings_file)
738 cr_settings_file.close()
739
740 self.updated = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000741
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000742 @staticmethod
743 def GetRelativeRoot():
Edward Lesmes50da7702020-03-30 19:23:43 +0000744 return scm.GIT.GetCheckoutRoot('.')
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000745
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000746 def GetRoot(self):
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000747 if self.root is None:
748 self.root = os.path.abspath(self.GetRelativeRoot())
749 return self.root
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000750
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000751 def GetTreeStatusUrl(self, error_ok=False):
752 if not self.tree_status_url:
Edward Lemur26964072020-02-19 19:18:51 +0000753 self.tree_status_url = self._GetConfig('rietveld.tree-status-url')
754 if self.tree_status_url is None and not error_ok:
755 DieWithError(
756 'You must configure your tree status URL by running '
757 '"git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000758 return self.tree_status_url
759
760 def GetViewVCUrl(self):
761 if not self.viewvc_url:
Edward Lemur26964072020-02-19 19:18:51 +0000762 self.viewvc_url = self._GetConfig('rietveld.viewvc-url')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000763 return self.viewvc_url
764
rmistry@google.com90752582014-01-14 21:04:50 +0000765 def GetBugPrefix(self):
Edward Lemur26964072020-02-19 19:18:51 +0000766 return self._GetConfig('rietveld.bug-prefix')
rmistry@google.com78948ed2015-07-08 23:09:57 +0000767
rmistry@google.com5626a922015-02-26 14:03:30 +0000768 def GetRunPostUploadHook(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000769 run_post_upload_hook = self._GetConfig(
Edward Lemur26964072020-02-19 19:18:51 +0000770 'rietveld.run-post-upload-hook')
rmistry@google.com5626a922015-02-26 14:03:30 +0000771 return run_post_upload_hook == "True"
772
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000773 def GetDefaultCCList(self):
Edward Lemur26964072020-02-19 19:18:51 +0000774 return self._GetConfig('rietveld.cc')
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000775
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000776 def GetSquashGerritUploads(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000777 """Returns True if uploads to Gerrit should be squashed by default."""
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000778 if self.squash_gerrit_uploads is None:
Edward Lesmes4de54132020-05-05 19:41:33 +0000779 self.squash_gerrit_uploads = self.GetSquashGerritUploadsOverride()
780 if self.squash_gerrit_uploads is None:
Edward Lemur26964072020-02-19 19:18:51 +0000781 # Default is squash now (http://crbug.com/611892#c23).
782 self.squash_gerrit_uploads = self._GetConfig(
783 'gerrit.squash-uploads').lower() != 'false'
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000784 return self.squash_gerrit_uploads
785
Edward Lesmes4de54132020-05-05 19:41:33 +0000786 def GetSquashGerritUploadsOverride(self):
787 """Return True or False if codereview.settings should be overridden.
788
789 Returns None if no override has been defined.
790 """
791 # See also http://crbug.com/611892#c23
792 result = self._GetConfig('gerrit.override-squash-uploads').lower()
793 if result == 'true':
794 return True
795 if result == 'false':
796 return False
797 return None
798
tandrii@chromium.org28253532016-04-14 13:46:56 +0000799 def GetGerritSkipEnsureAuthenticated(self):
800 """Return True if EnsureAuthenticated should not be done for Gerrit
801 uploads."""
802 if self.gerrit_skip_ensure_authenticated is None:
Edward Lemur26964072020-02-19 19:18:51 +0000803 self.gerrit_skip_ensure_authenticated = self._GetConfig(
804 'gerrit.skip-ensure-authenticated').lower() == 'true'
tandrii@chromium.org28253532016-04-14 13:46:56 +0000805 return self.gerrit_skip_ensure_authenticated
806
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000807 def GetGitEditor(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000808 """Returns the editor specified in the git config, or None if none is."""
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000809 if self.git_editor is None:
Raul Tambre5a525872019-02-12 19:08:08 +0000810 # Git requires single quotes for paths with spaces. We need to replace
811 # them with double quotes for Windows to treat such paths as a single
812 # path.
Edward Lemur26964072020-02-19 19:18:51 +0000813 self.git_editor = self._GetConfig('core.editor').replace('\'', '"')
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000814 return self.git_editor or None
815
thestig@chromium.org44202a22014-03-11 19:22:18 +0000816 def GetLintRegex(self):
Edward Lemur26964072020-02-19 19:18:51 +0000817 return self._GetConfig('rietveld.cpplint-regex', DEFAULT_LINT_REGEX)
thestig@chromium.org44202a22014-03-11 19:22:18 +0000818
819 def GetLintIgnoreRegex(self):
Edward Lemur26964072020-02-19 19:18:51 +0000820 return self._GetConfig(
821 'rietveld.cpplint-ignore-regex', DEFAULT_LINT_IGNORE_REGEX)
thestig@chromium.org44202a22014-03-11 19:22:18 +0000822
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000823 def GetFormatFullByDefault(self):
824 if self.format_full_by_default is None:
825 result = (
826 RunGit(['config', '--bool', 'rietveld.format-full-by-default'],
827 error_ok=True).strip())
828 self.format_full_by_default = (result == 'true')
829 return self.format_full_by_default
830
Edward Lemur26964072020-02-19 19:18:51 +0000831 def _GetConfig(self, key, default=''):
832 self._LazyUpdateIfNeeded()
833 return scm.GIT.GetConfig(self.GetRoot(), key, default)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000834
835
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000836class _CQState(object):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +0000837 """Enum for states of CL with respect to CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000838 NONE = 'none'
839 DRY_RUN = 'dry_run'
840 COMMIT = 'commit'
841
842 ALL_STATES = [NONE, DRY_RUN, COMMIT]
843
844
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000845class _ParsedIssueNumberArgument(object):
Edward Lemurf38bc172019-09-03 21:02:13 +0000846 def __init__(self, issue=None, patchset=None, hostname=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000847 self.issue = issue
848 self.patchset = patchset
849 self.hostname = hostname
850
851 @property
852 def valid(self):
853 return self.issue is not None
854
855
Edward Lemurf38bc172019-09-03 21:02:13 +0000856def ParseIssueNumberArgument(arg):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000857 """Parses the issue argument and returns _ParsedIssueNumberArgument."""
858 fail_result = _ParsedIssueNumberArgument()
859
Edward Lemur678a6842019-10-03 22:25:05 +0000860 if isinstance(arg, int):
861 return _ParsedIssueNumberArgument(issue=arg)
862 if not isinstance(arg, basestring):
863 return fail_result
864
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000865 if arg.isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +0000866 return _ParsedIssueNumberArgument(issue=int(arg))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000867 if not arg.startswith('http'):
868 return fail_result
Aaron Gableaee6c852017-06-26 12:49:01 -0700869
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000870 url = gclient_utils.UpgradeToHttps(arg)
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000871 for gerrit_url, short_url in _KNOWN_GERRIT_TO_SHORT_URLS.items():
872 if url.startswith(short_url):
873 url = gerrit_url + url[len(short_url):]
874 break
875
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000876 try:
Edward Lemur79d4f992019-11-11 23:49:02 +0000877 parsed_url = urllib.parse.urlparse(url)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000878 except ValueError:
879 return fail_result
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +0200880
Edward Lemur678a6842019-10-03 22:25:05 +0000881 # Gerrit's new UI is https://domain/c/project/+/<issue_number>[/[patchset]]
882 # But old GWT UI is https://domain/#/c/project/+/<issue_number>[/[patchset]]
883 # Short urls like https://domain/<issue_number> can be used, but don't allow
884 # specifying the patchset (you'd 404), but we allow that here.
885 if parsed_url.path == '/':
886 part = parsed_url.fragment
887 else:
888 part = parsed_url.path
889
890 match = re.match(
891 r'(/c(/.*/\+)?)?/(?P<issue>\d+)(/(?P<patchset>\d+)?/?)?$', part)
892 if not match:
893 return fail_result
894
895 issue = int(match.group('issue'))
896 patchset = match.group('patchset')
897 return _ParsedIssueNumberArgument(
898 issue=issue,
899 patchset=int(patchset) if patchset else None,
900 hostname=parsed_url.netloc)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000901
902
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +0000903def _create_description_from_log(args):
904 """Pulls out the commit log to use as a base for the CL description."""
905 log_args = []
906 if len(args) == 1 and not args[0].endswith('.'):
907 log_args = [args[0] + '..']
908 elif len(args) == 1 and args[0].endswith('...'):
909 log_args = [args[0][:-1]]
910 elif len(args) == 2:
911 log_args = [args[0] + '..' + args[1]]
912 else:
913 log_args = args[:] # Hope for the best!
Manh Nguyene3644862020-08-05 18:25:46 +0000914 return RunGit(['log', '--pretty=format:%B%n'] + log_args)
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +0000915
916
Aaron Gablea45ee112016-11-22 15:14:38 -0800917class GerritChangeNotExists(Exception):
tandriic2405f52016-10-10 08:13:15 -0700918 def __init__(self, issue, url):
919 self.issue = issue
920 self.url = url
Aaron Gablea45ee112016-11-22 15:14:38 -0800921 super(GerritChangeNotExists, self).__init__()
tandriic2405f52016-10-10 08:13:15 -0700922
923 def __str__(self):
Aaron Gablea45ee112016-11-22 15:14:38 -0800924 return 'change %s at %s does not exist or you have no access to it' % (
tandriic2405f52016-10-10 08:13:15 -0700925 self.issue, self.url)
926
927
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +0100928_CommentSummary = collections.namedtuple(
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000929 '_CommentSummary', ['date', 'message', 'sender', 'autogenerated',
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +0100930 # TODO(tandrii): these two aren't known in Gerrit.
931 'approval', 'disapproval'])
932
933
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000934class Changelist(object):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000935 """Changelist works with one changelist in local branch.
936
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +0000937 Notes:
938 * Not safe for concurrent multi-{thread,process} use.
939 * Caches values from current branch. Therefore, re-use after branch change
tandrii5d48c322016-08-18 16:19:37 -0700940 with great care.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000941 """
942
Sigurd Schneider9abde8c2020-11-17 08:44:52 +0000943 def __init__(self,
944 branchref=None,
945 issue=None,
946 codereview_host=None,
947 commit_date=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000948 """Create a new ChangeList instance.
949
Edward Lemurf38bc172019-09-03 21:02:13 +0000950 **kwargs will be passed directly to Gerrit implementation.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000951 """
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000952 # Poke settings so we get the "configure your server" message if necessary.
maruel@chromium.org379d07a2011-11-30 14:58:10 +0000953 global settings
954 if not settings:
955 # Happens when git_cl.py is used as a utility library.
956 settings = Settings()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000957
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000958 self.branchref = branchref
959 if self.branchref:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000960 assert branchref.startswith('refs/heads/')
Edward Lemur85153282020-02-14 22:06:29 +0000961 self.branch = scm.GIT.ShortBranchName(self.branchref)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000962 else:
963 self.branch = None
Sigurd Schneider9abde8c2020-11-17 08:44:52 +0000964 self.commit_date = commit_date
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000965 self.upstream_branch = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +0000966 self.lookedup_issue = False
967 self.issue = issue or None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000968 self.description = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +0000969 self.lookedup_patchset = False
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000970 self.patchset = None
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000971 self.cc = None
Daniel Cheng7227d212017-11-17 08:12:37 -0800972 self.more_cc = []
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +0000973 self._remote = None
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +0000974 self._cached_remote_url = (False, None) # (is_cached, value)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +0000975
Edward Lemur125d60a2019-09-13 18:25:41 +0000976 # Lazily cached values.
977 self._gerrit_host = None # e.g. chromium-review.googlesource.com
978 self._gerrit_server = None # e.g. https://chromium-review.googlesource.com
979 # Map from change number (issue) to its detail cache.
980 self._detail_cache = {}
981
982 if codereview_host is not None:
983 assert not codereview_host.startswith('https://'), codereview_host
984 self._gerrit_host = codereview_host
985 self._gerrit_server = 'https://%s' % codereview_host
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000986
987 def GetCCList(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700988 """Returns the users cc'd on this CL.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000989
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700990 The return value is a string suitable for passing to git cl with the --cc
991 flag.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000992 """
993 if self.cc is None:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +0000994 base_cc = settings.GetDefaultCCList()
Daniel Cheng7227d212017-11-17 08:12:37 -0800995 more_cc = ','.join(self.more_cc)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000996 self.cc = ','.join(filter(None, (base_cc, more_cc))) or ''
997 return self.cc
998
Daniel Cheng7227d212017-11-17 08:12:37 -0800999 def ExtendCC(self, more_cc):
1000 """Extends the list of users to cc on this CL based on the changed files."""
1001 self.more_cc.extend(more_cc)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001002
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00001003 def GetCommitDate(self):
1004 """Returns the commit date as provided in the constructor"""
1005 return self.commit_date
1006
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001007 def GetBranch(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001008 """Returns the short branch name, e.g. 'main'."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001009 if not self.branch:
Edward Lemur85153282020-02-14 22:06:29 +00001010 branchref = scm.GIT.GetBranchRef(settings.GetRoot())
szager@chromium.orgd62c61f2014-10-20 22:33:21 +00001011 if not branchref:
1012 return None
1013 self.branchref = branchref
Edward Lemur85153282020-02-14 22:06:29 +00001014 self.branch = scm.GIT.ShortBranchName(self.branchref)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001015 return self.branch
1016
1017 def GetBranchRef(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001018 """Returns the full branch name, e.g. 'refs/heads/main'."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001019 self.GetBranch() # Poke the lazy loader.
1020 return self.branchref
1021
Edward Lemur85153282020-02-14 22:06:29 +00001022 def _GitGetBranchConfigValue(self, key, default=None):
1023 return scm.GIT.GetBranchConfig(
1024 settings.GetRoot(), self.GetBranch(), key, default)
tandrii5d48c322016-08-18 16:19:37 -07001025
Edward Lemur85153282020-02-14 22:06:29 +00001026 def _GitSetBranchConfigValue(self, key, value):
1027 action = 'set %s to %r' % (key, value)
1028 if not value:
1029 action = 'unset %s' % key
1030 assert self.GetBranch(), 'a branch is needed to ' + action
1031 return scm.GIT.SetBranchConfig(
1032 settings.GetRoot(), self.GetBranch(), key, value)
tandrii5d48c322016-08-18 16:19:37 -07001033
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001034 @staticmethod
1035 def FetchUpstreamTuple(branch):
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001036 """Returns a tuple containing remote and remote ref,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001037 e.g. 'origin', 'refs/heads/main'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001038 """
Edward Lemur15a9b8c2020-02-13 00:52:30 +00001039 remote, upstream_branch = scm.GIT.FetchUpstreamTuple(
1040 settings.GetRoot(), branch)
1041 if not remote or not upstream_branch:
1042 DieWithError(
1043 'Unable to determine default branch to diff against.\n'
Josip Sokcevicb038f722021-01-06 18:28:11 +00001044 'Verify this branch is set up to track another \n'
1045 '(via the --track argument to "git checkout -b ..."). \n'
1046 'or pass complete "git diff"-style arguments if supported, like\n'
1047 ' git cl upload origin/main\n')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001048
1049 return remote, upstream_branch
1050
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001051 def GetCommonAncestorWithUpstream(self):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001052 upstream_branch = self.GetUpstreamBranch()
Edward Lesmes50da7702020-03-30 19:23:43 +00001053 if not scm.GIT.IsValidRevision(settings.GetRoot(), upstream_branch):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001054 DieWithError('The upstream for the current branch (%s) does not exist '
1055 'anymore.\nPlease fix it and try again.' % self.GetBranch())
iannucci@chromium.org9e849272014-04-04 00:31:55 +00001056 return git_common.get_or_create_merge_base(self.GetBranch(),
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001057 upstream_branch)
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001058
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001059 def GetUpstreamBranch(self):
1060 if self.upstream_branch is None:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001061 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Raul Tambrefe1dbe12019-05-02 04:43:57 +00001062 if remote != '.':
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001063 upstream_branch = upstream_branch.replace('refs/heads/',
1064 'refs/remotes/%s/' % remote)
1065 upstream_branch = upstream_branch.replace('refs/branch-heads/',
1066 'refs/remotes/branch-heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001067 self.upstream_branch = upstream_branch
1068 return self.upstream_branch
1069
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001070 def GetRemoteBranch(self):
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001071 if not self._remote:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001072 remote, branch = None, self.GetBranch()
1073 seen_branches = set()
1074 while branch not in seen_branches:
1075 seen_branches.add(branch)
1076 remote, branch = self.FetchUpstreamTuple(branch)
Edward Lemur85153282020-02-14 22:06:29 +00001077 branch = scm.GIT.ShortBranchName(branch)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001078 if remote != '.' or branch.startswith('refs/remotes'):
1079 break
1080 else:
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001081 remotes = RunGit(['remote'], error_ok=True).split()
1082 if len(remotes) == 1:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001083 remote, = remotes
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001084 elif 'origin' in remotes:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001085 remote = 'origin'
Gavin Make6a62332020-12-04 21:57:10 +00001086 logging.warning('Could not determine which remote this change is '
1087 'associated with, so defaulting to "%s".' %
1088 self._remote)
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001089 else:
Gavin Make6a62332020-12-04 21:57:10 +00001090 logging.warning('Could not determine which remote this change is '
1091 'associated with.')
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001092 branch = 'HEAD'
1093 if branch.startswith('refs/remotes'):
1094 self._remote = (remote, branch)
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001095 elif branch.startswith('refs/branch-heads/'):
1096 self._remote = (remote, branch.replace('refs/', 'refs/remotes/'))
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001097 else:
1098 self._remote = (remote, 'refs/remotes/%s/%s' % (remote, branch))
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001099 return self._remote
1100
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001101 def GetRemoteUrl(self):
1102 """Return the configured remote URL, e.g. 'git://example.org/foo.git/'.
1103
1104 Returns None if there is no remote.
1105 """
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001106 is_cached, value = self._cached_remote_url
1107 if is_cached:
1108 return value
1109
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001110 remote, _ = self.GetRemoteBranch()
Edward Lemur26964072020-02-19 19:18:51 +00001111 url = scm.GIT.GetConfig(settings.GetRoot(), 'remote.%s.url' % remote, '')
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001112
Edward Lemur298f2cf2019-02-22 21:40:39 +00001113 # Check if the remote url can be parsed as an URL.
Edward Lemur79d4f992019-11-11 23:49:02 +00001114 host = urllib.parse.urlparse(url).netloc
Edward Lemur298f2cf2019-02-22 21:40:39 +00001115 if host:
1116 self._cached_remote_url = (True, url)
1117 return url
1118
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001119 # If it cannot be parsed as an url, assume it is a local directory,
1120 # probably a git cache.
Edward Lemur298f2cf2019-02-22 21:40:39 +00001121 logging.warning('"%s" doesn\'t appear to point to a git host. '
1122 'Interpreting it as a local directory.', url)
1123 if not os.path.isdir(url):
1124 logging.error(
Josip906bfde2020-01-31 22:38:49 +00001125 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
1126 'but it doesn\'t exist.',
1127 {'remote': remote, 'branch': self.GetBranch(), 'url': url})
Edward Lemur298f2cf2019-02-22 21:40:39 +00001128 return None
1129
1130 cache_path = url
Edward Lemur26964072020-02-19 19:18:51 +00001131 url = scm.GIT.GetConfig(url, 'remote.%s.url' % remote, '')
Edward Lemur298f2cf2019-02-22 21:40:39 +00001132
Edward Lemur79d4f992019-11-11 23:49:02 +00001133 host = urllib.parse.urlparse(url).netloc
Edward Lemur298f2cf2019-02-22 21:40:39 +00001134 if not host:
1135 logging.error(
1136 'Remote "%(remote)s" for branch "%(branch)s" points to '
1137 '"%(cache_path)s", but it is misconfigured.\n'
1138 '"%(cache_path)s" must be a git repo and must have a remote named '
1139 '"%(remote)s" pointing to the git host.', {
1140 'remote': remote,
1141 'cache_path': cache_path,
1142 'branch': self.GetBranch()})
1143 return None
1144
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001145 self._cached_remote_url = (True, url)
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001146 return url
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001147
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001148 def GetIssue(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001149 """Returns the issue number as a int or None if not set."""
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001150 if self.issue is None and not self.lookedup_issue:
Edward Lesmes50da7702020-03-30 19:23:43 +00001151 self.issue = self._GitGetBranchConfigValue(ISSUE_CONFIG_KEY)
Edward Lemur85153282020-02-14 22:06:29 +00001152 if self.issue is not None:
1153 self.issue = int(self.issue)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001154 self.lookedup_issue = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001155 return self.issue
1156
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00001157 def GetIssueURL(self, short=False):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001158 """Get the URL for a particular issue."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001159 issue = self.GetIssue()
1160 if not issue:
dbeam@chromium.org015fd3d2013-06-18 19:02:50 +00001161 return None
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00001162 server = self.GetCodereviewServer()
1163 if short:
1164 server = _KNOWN_GERRIT_TO_SHORT_URLS.get(server, server)
1165 return '%s/%s' % (server, issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001166
Edward Lemur6c6827c2020-02-06 21:15:18 +00001167 def FetchDescription(self, pretty=False):
1168 assert self.GetIssue(), 'issue is required to query Gerrit'
1169
Edward Lemur9aa1a962020-02-25 00:58:38 +00001170 if self.description is None:
Edward Lemur6c6827c2020-02-06 21:15:18 +00001171 data = self._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
1172 current_rev = data['current_revision']
1173 self.description = data['revisions'][current_rev]['commit']['message']
Edward Lemur6c6827c2020-02-06 21:15:18 +00001174
1175 if not pretty:
1176 return self.description
1177
1178 # Set width to 72 columns + 2 space indent.
1179 wrapper = textwrap.TextWrapper(width=74, replace_whitespace=True)
1180 wrapper.initial_indent = wrapper.subsequent_indent = ' '
1181 lines = self.description.splitlines()
1182 return '\n'.join([wrapper.fill(line) for line in lines])
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001183
1184 def GetPatchset(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001185 """Returns the patchset number as a int or None if not set."""
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001186 if self.patchset is None and not self.lookedup_patchset:
Edward Lesmes50da7702020-03-30 19:23:43 +00001187 self.patchset = self._GitGetBranchConfigValue(PATCHSET_CONFIG_KEY)
Edward Lemur85153282020-02-14 22:06:29 +00001188 if self.patchset is not None:
1189 self.patchset = int(self.patchset)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001190 self.lookedup_patchset = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001191 return self.patchset
1192
Edward Lemur9aa1a962020-02-25 00:58:38 +00001193 def GetAuthor(self):
1194 return scm.GIT.GetConfig(settings.GetRoot(), 'user.email')
1195
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001196 def SetPatchset(self, patchset):
tandrii5d48c322016-08-18 16:19:37 -07001197 """Set this branch's patchset. If patchset=0, clears the patchset."""
1198 assert self.GetBranch()
1199 if not patchset:
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001200 self.patchset = None
tandrii5d48c322016-08-18 16:19:37 -07001201 else:
1202 self.patchset = int(patchset)
Edward Lesmes50da7702020-03-30 19:23:43 +00001203 self._GitSetBranchConfigValue(PATCHSET_CONFIG_KEY, str(self.patchset))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001204
tandrii@chromium.orga342c922016-03-16 07:08:25 +00001205 def SetIssue(self, issue=None):
tandrii5d48c322016-08-18 16:19:37 -07001206 """Set this branch's issue. If issue isn't given, clears the issue."""
1207 assert self.GetBranch()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001208 if issue:
tandrii5d48c322016-08-18 16:19:37 -07001209 issue = int(issue)
Edward Lesmes50da7702020-03-30 19:23:43 +00001210 self._GitSetBranchConfigValue(ISSUE_CONFIG_KEY, str(issue))
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001211 self.issue = issue
Edward Lemur125d60a2019-09-13 18:25:41 +00001212 codereview_server = self.GetCodereviewServer()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001213 if codereview_server:
tandrii5d48c322016-08-18 16:19:37 -07001214 self._GitSetBranchConfigValue(
Edward Lesmes50da7702020-03-30 19:23:43 +00001215 CODEREVIEW_SERVER_CONFIG_KEY, codereview_server)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001216 else:
tandrii5d48c322016-08-18 16:19:37 -07001217 # Reset all of these just to be clean.
1218 reset_suffixes = [
1219 'last-upload-hash',
Edward Lesmes50da7702020-03-30 19:23:43 +00001220 ISSUE_CONFIG_KEY,
1221 PATCHSET_CONFIG_KEY,
1222 CODEREVIEW_SERVER_CONFIG_KEY,
1223 'gerritsquashhash',
1224 ]
tandrii5d48c322016-08-18 16:19:37 -07001225 for prop in reset_suffixes:
Edward Lemur85153282020-02-14 22:06:29 +00001226 try:
1227 self._GitSetBranchConfigValue(prop, None)
1228 except subprocess2.CalledProcessError:
1229 pass
Aaron Gableca01e2c2017-07-19 11:16:02 -07001230 msg = RunGit(['log', '-1', '--format=%B']).strip()
1231 if msg and git_footers.get_footer_change_id(msg):
1232 print('WARNING: The change patched into this branch has a Change-Id. '
1233 'Removing it.')
1234 RunGit(['commit', '--amend', '-m',
1235 git_footers.remove_footer(msg, 'Change-Id')])
Edward Lemurf38bc172019-09-03 21:02:13 +00001236 self.lookedup_issue = True
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001237 self.issue = None
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001238 self.patchset = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001239
Edward Lemur2c62b332020-03-12 22:12:33 +00001240 def GetAffectedFiles(self, upstream):
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001241 try:
Edward Lemur2c62b332020-03-12 22:12:33 +00001242 return [f for _, f in scm.GIT.CaptureStatus(settings.GetRoot(), upstream)]
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001243 except subprocess2.CalledProcessError:
1244 DieWithError(
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001245 ('\nFailed to diff against upstream branch %s\n\n'
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001246 'This branch probably doesn\'t exist anymore. To reset the\n'
1247 'tracking branch, please run\n'
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001248 ' git branch --set-upstream-to origin/main %s\n'
1249 'or replace origin/main with the relevant branch') %
Edward Lemur2c62b332020-03-12 22:12:33 +00001250 (upstream, self.GetBranch()))
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001251
dsansomee2d6fd92016-09-08 00:10:47 -07001252 def UpdateDescription(self, description, force=False):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001253 assert self.GetIssue(), 'issue is required to update description'
1254
1255 if gerrit_util.HasPendingChangeEdit(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001256 self.GetGerritHost(), self._GerritChangeIdentifier()):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001257 if not force:
1258 confirm_or_exit(
1259 'The description cannot be modified while the issue has a pending '
1260 'unpublished edit. Either publish the edit in the Gerrit web UI '
1261 'or delete it.\n\n', action='delete the unpublished edit')
1262
1263 gerrit_util.DeletePendingChangeEdit(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001264 self.GetGerritHost(), self._GerritChangeIdentifier())
Edward Lemur6c6827c2020-02-06 21:15:18 +00001265 gerrit_util.SetCommitMessage(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001266 self.GetGerritHost(), self._GerritChangeIdentifier(),
Edward Lemur6c6827c2020-02-06 21:15:18 +00001267 description, notify='NONE')
1268
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001269 self.description = description
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001270
Edward Lemur75526302020-02-27 22:31:05 +00001271 def _GetCommonPresubmitArgs(self, verbose, upstream):
Edward Lemur227d5102020-02-25 23:45:35 +00001272 args = [
Edward Lemur227d5102020-02-25 23:45:35 +00001273 '--root', settings.GetRoot(),
1274 '--upstream', upstream,
1275 ]
1276
1277 args.extend(['--verbose'] * verbose)
1278
Edward Lemur99df04e2020-03-05 19:39:43 +00001279 author = self.GetAuthor()
1280 gerrit_url = self.GetCodereviewServer()
Edward Lemur227d5102020-02-25 23:45:35 +00001281 issue = self.GetIssue()
1282 patchset = self.GetPatchset()
Edward Lemur99df04e2020-03-05 19:39:43 +00001283 if author:
1284 args.extend(['--author', author])
1285 if gerrit_url:
1286 args.extend(['--gerrit_url', gerrit_url])
Edward Lemur227d5102020-02-25 23:45:35 +00001287 if issue:
1288 args.extend(['--issue', str(issue)])
1289 if patchset:
1290 args.extend(['--patchset', str(patchset)])
Edward Lemur227d5102020-02-25 23:45:35 +00001291
Edward Lemur75526302020-02-27 22:31:05 +00001292 return args
1293
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001294 def RunHook(self, committing, may_prompt, verbose, parallel, upstream,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001295 description, all_files, resultdb=False, realm=None):
Edward Lemur75526302020-02-27 22:31:05 +00001296 """Calls sys.exit() if the hook fails; returns a HookResults otherwise."""
1297 args = self._GetCommonPresubmitArgs(verbose, upstream)
1298 args.append('--commit' if committing else '--upload')
Edward Lemur227d5102020-02-25 23:45:35 +00001299 if may_prompt:
1300 args.append('--may_prompt')
1301 if parallel:
1302 args.append('--parallel')
1303 if all_files:
1304 args.append('--all_files')
1305
1306 with gclient_utils.temporary_file() as description_file:
1307 with gclient_utils.temporary_file() as json_output:
Edward Lemur1a83da12020-03-04 21:18:36 +00001308
1309 gclient_utils.FileWrite(description_file, description)
Edward Lemur227d5102020-02-25 23:45:35 +00001310 args.extend(['--json_output', json_output])
1311 args.extend(['--description_file', description_file])
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001312 args.extend(['--gerrit_project', self.GetGerritProject()])
Edward Lemur227d5102020-02-25 23:45:35 +00001313
1314 start = time_time()
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001315 cmd = ['vpython', PRESUBMIT_SUPPORT] + args
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001316 if resultdb and realm:
1317 cmd = ['rdb', 'stream', '-new', '-realm', realm, '--'] + cmd
1318 elif resultdb:
1319 # TODO (crbug.com/1113463): store realm somewhere and look it up so
1320 # it is not required to pass the realm flag
1321 print('Note: ResultDB reporting will NOT be performed because --realm'
1322 ' was not specified. To enable ResultDB, please run the command'
1323 ' again with the --realm argument to specify the LUCI realm.')
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001324
1325 p = subprocess2.Popen(cmd)
Edward Lemur227d5102020-02-25 23:45:35 +00001326 exit_code = p.wait()
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001327
Edward Lemur227d5102020-02-25 23:45:35 +00001328 metrics.collector.add_repeated('sub_commands', {
1329 'command': 'presubmit',
1330 'execution_time': time_time() - start,
1331 'exit_code': exit_code,
1332 })
1333
1334 if exit_code:
1335 sys.exit(exit_code)
1336
1337 json_results = gclient_utils.FileRead(json_output)
1338 return json.loads(json_results)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001339
Edward Lemur75526302020-02-27 22:31:05 +00001340 def RunPostUploadHook(self, verbose, upstream, description):
1341 args = self._GetCommonPresubmitArgs(verbose, upstream)
1342 args.append('--post_upload')
1343
1344 with gclient_utils.temporary_file() as description_file:
Edward Lemur1a83da12020-03-04 21:18:36 +00001345 gclient_utils.FileWrite(description_file, description)
Edward Lemur75526302020-02-27 22:31:05 +00001346 args.extend(['--description_file', description_file])
1347 p = subprocess2.Popen(['vpython', PRESUBMIT_SUPPORT] + args)
1348 p.wait()
1349
Edward Lemur5a644f82020-03-18 16:44:57 +00001350 def _GetDescriptionForUpload(self, options, git_diff_args, files):
1351 # Get description message for upload.
1352 if self.GetIssue():
1353 description = self.FetchDescription()
1354 elif options.message:
1355 description = options.message
1356 else:
1357 description = _create_description_from_log(git_diff_args)
1358 if options.title and options.squash:
Edward Lesmes0dd54822020-03-26 18:24:25 +00001359 description = options.title + '\n\n' + description
Edward Lemur5a644f82020-03-18 16:44:57 +00001360
1361 # Extract bug number from branch name.
1362 bug = options.bug
1363 fixed = options.fixed
1364 match = re.match(r'(?P<type>bug|fix(?:e[sd])?)[_-]?(?P<bugnum>\d+)',
1365 self.GetBranch())
1366 if not bug and not fixed and match:
1367 if match.group('type') == 'bug':
1368 bug = match.group('bugnum')
1369 else:
1370 fixed = match.group('bugnum')
1371
1372 change_description = ChangeDescription(description, bug, fixed)
1373
1374 # Set the reviewer list now so that presubmit checks can access it.
1375 if options.reviewers or options.tbrs or options.add_owners_to:
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001376 add_owners = []
1377 if options.add_owners_to:
1378 # Fill gaps in OWNERS coverage to tbrs/reviewers if requested.
Edward Lesmesb34cd6d2021-01-07 01:05:41 +00001379 project = self.GetGerritProject()
1380 branch = self.GetCommonAncestorWithUpstream()
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001381 client = owners_client.DepotToolsClient(
Edward Lesmesb34cd6d2021-01-07 01:05:41 +00001382 host=self.GetGerritHost(),
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001383 root=settings.GetRoot(),
Edward Lesmesb34cd6d2021-01-07 01:05:41 +00001384 branch=branch)
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001385 status = client.GetFilesApprovalStatus(
Edward Lesmesb34cd6d2021-01-07 01:05:41 +00001386 project, branch, files, [], options.tbrs + options.reviewers)
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001387 missing_files = [
1388 f for f in files
1389 if status[f] == owners_client.INSUFFICIENT_REVIEWERS
1390 ]
Edward Lesmesb34cd6d2021-01-07 01:05:41 +00001391 add_owners = client.SuggestOwners(project, branch, missing_files)
Edward Lemur5a644f82020-03-18 16:44:57 +00001392 change_description.update_reviewers(
Edward Lesmes968b1fe2020-12-04 00:45:01 +00001393 options.reviewers, options.tbrs, options.add_owners_to, add_owners)
Edward Lemur5a644f82020-03-18 16:44:57 +00001394
1395 return change_description
1396
1397 def _GetTitleForUpload(self, options):
1398 # When not squashing, just return options.title.
1399 if not options.squash:
1400 return options.title
1401
1402 # On first upload, patchset title is always this string, while options.title
1403 # gets converted to first line of message.
1404 if not self.GetIssue():
1405 return 'Initial upload'
1406
1407 # When uploading subsequent patchsets, options.message is taken as the title
1408 # if options.title is not provided.
1409 if options.title:
1410 return options.title
1411 if options.message:
1412 return options.message.strip()
1413
1414 # Use the subject of the last commit as title by default.
Edward Lesmes50da7702020-03-30 19:23:43 +00001415 title = RunGit(['show', '-s', '--format=%s', 'HEAD']).strip()
Mario Bianuccicebfb4e2020-07-22 23:08:16 +00001416 if options.force or options.skip_title:
Edward Lemur5a644f82020-03-18 16:44:57 +00001417 return title
Edward Lesmesae3586b2020-03-23 21:21:14 +00001418 user_title = gclient_utils.AskForData('Title for patchset [%s]: ' % title)
1419 return user_title or title
Edward Lemur5a644f82020-03-18 16:44:57 +00001420
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001421 def CMDUpload(self, options, git_diff_args, orig_args):
1422 """Uploads a change to codereview."""
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001423 custom_cl_base = None
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001424 if git_diff_args:
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001425 custom_cl_base = base_branch = git_diff_args[0]
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001426 else:
1427 if self.GetBranch() is None:
1428 DieWithError('Can\'t upload from detached HEAD state. Get on a branch!')
1429
1430 # Default to diffing against common ancestor of upstream branch
1431 base_branch = self.GetCommonAncestorWithUpstream()
1432 git_diff_args = [base_branch, 'HEAD']
1433
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001434 # Fast best-effort checks to abort before running potentially expensive
1435 # hooks if uploading is likely to fail anyway. Passing these checks does
1436 # not guarantee that uploading will not fail.
Edward Lemur125d60a2019-09-13 18:25:41 +00001437 self.EnsureAuthenticated(force=options.force)
1438 self.EnsureCanUploadPatchset(force=options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001439
1440 # Apply watchlists on upload.
Edward Lemur2c62b332020-03-12 22:12:33 +00001441 watchlist = watchlists.Watchlists(settings.GetRoot())
1442 files = self.GetAffectedFiles(base_branch)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001443 if not options.bypass_watchlists:
Daniel Cheng7227d212017-11-17 08:12:37 -08001444 self.ExtendCC(watchlist.GetWatchersForPaths(files))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001445
Edward Lemur5a644f82020-03-18 16:44:57 +00001446 change_desc = self._GetDescriptionForUpload(options, git_diff_args, files)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001447 if not options.bypass_hooks:
Edward Lemur2c62b332020-03-12 22:12:33 +00001448 hook_results = self.RunHook(
1449 committing=False,
1450 may_prompt=not options.force,
1451 verbose=options.verbose,
1452 parallel=options.parallel,
1453 upstream=base_branch,
Edward Lemur5a644f82020-03-18 16:44:57 +00001454 description=change_desc.description,
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001455 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001456 resultdb=options.resultdb,
1457 realm=options.realm)
Edward Lemur227d5102020-02-25 23:45:35 +00001458 self.ExtendCC(hook_results['more_cc'])
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001459
Aaron Gable13101a62018-02-09 13:20:41 -08001460 print_stats(git_diff_args)
Edward Lemura12175c2020-03-09 16:58:26 +00001461 ret = self.CMDUploadChange(
Edward Lemur5a644f82020-03-18 16:44:57 +00001462 options, git_diff_args, custom_cl_base, change_desc)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001463 if not ret:
Edward Lemur85153282020-02-14 22:06:29 +00001464 self._GitSetBranchConfigValue(
Edward Lesmes50da7702020-03-30 19:23:43 +00001465 'last-upload-hash', scm.GIT.ResolveCommit(settings.GetRoot(), 'HEAD'))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001466 # Run post upload hooks, if specified.
1467 if settings.GetRunPostUploadHook():
Edward Lemur5a644f82020-03-18 16:44:57 +00001468 self.RunPostUploadHook(
1469 options.verbose, base_branch, change_desc.description)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001470
1471 # Upload all dependencies if specified.
1472 if options.dependencies:
vapiera7fbd5a2016-06-16 09:17:49 -07001473 print()
1474 print('--dependencies has been specified.')
1475 print('All dependent local branches will be re-uploaded.')
1476 print()
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001477 # Remove the dependencies flag from args so that we do not end up in a
1478 # loop.
1479 orig_args.remove('--dependencies')
Jose Lopes3863fc52020-04-07 17:00:25 +00001480 ret = upload_branch_deps(self, orig_args, options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001481 return ret
1482
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001483 def SetCQState(self, new_state):
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001484 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001485
1486 Issue must have been already uploaded and known.
1487 """
1488 assert new_state in _CQState.ALL_STATES
1489 assert self.GetIssue()
qyearsley1fdfcb62016-10-24 13:22:03 -07001490 try:
Edward Lemur125d60a2019-09-13 18:25:41 +00001491 vote_map = {
1492 _CQState.NONE: 0,
1493 _CQState.DRY_RUN: 1,
1494 _CQState.COMMIT: 2,
1495 }
1496 labels = {'Commit-Queue': vote_map[new_state]}
1497 notify = False if new_state == _CQState.DRY_RUN else None
1498 gerrit_util.SetReview(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001499 self.GetGerritHost(), self._GerritChangeIdentifier(),
Edward Lemur125d60a2019-09-13 18:25:41 +00001500 labels=labels, notify=notify)
qyearsley1fdfcb62016-10-24 13:22:03 -07001501 return 0
1502 except KeyboardInterrupt:
1503 raise
1504 except:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001505 print('WARNING: Failed to %s.\n'
qyearsley1fdfcb62016-10-24 13:22:03 -07001506 'Either:\n'
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001507 ' * Your project has no CQ,\n'
1508 ' * You don\'t have permission to change the CQ state,\n'
1509 ' * There\'s a bug in this code (see stack trace below).\n'
1510 'Consider specifying which bots to trigger manually or asking your '
1511 'project owners for permissions or contacting Chrome Infra at:\n'
1512 'https://www.chromium.org/infra\n\n' %
1513 ('cancel CQ' if new_state == _CQState.NONE else 'trigger CQ'))
qyearsley1fdfcb62016-10-24 13:22:03 -07001514 # Still raise exception so that stack trace is printed.
1515 raise
1516
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001517 def GetGerritHost(self):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001518 # Lazy load of configs.
1519 self.GetCodereviewServer()
tandriie32e3ea2016-06-22 02:52:48 -07001520 if self._gerrit_host and '.' not in self._gerrit_host:
1521 # Abbreviated domain like "chromium" instead of chromium.googlesource.com.
1522 # This happens for internal stuff http://crbug.com/614312.
Edward Lemur79d4f992019-11-11 23:49:02 +00001523 parsed = urllib.parse.urlparse(self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001524 if parsed.scheme == 'sso':
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001525 print('WARNING: using non-https URLs for remote is likely broken\n'
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001526 ' Your current remote is: %s' % self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001527 self._gerrit_host = '%s.googlesource.com' % self._gerrit_host
1528 self._gerrit_server = 'https://%s' % self._gerrit_host
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001529 return self._gerrit_host
1530
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001531 def _GetGitHost(self):
1532 """Returns git host to be used when uploading change to Gerrit."""
Edward Lemur298f2cf2019-02-22 21:40:39 +00001533 remote_url = self.GetRemoteUrl()
1534 if not remote_url:
1535 return None
Edward Lemur79d4f992019-11-11 23:49:02 +00001536 return urllib.parse.urlparse(remote_url).netloc
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001537
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001538 def GetCodereviewServer(self):
1539 if not self._gerrit_server:
1540 # If we're on a branch then get the server potentially associated
1541 # with that branch.
Edward Lemur85153282020-02-14 22:06:29 +00001542 if self.GetIssue() and self.GetBranch():
tandrii5d48c322016-08-18 16:19:37 -07001543 self._gerrit_server = self._GitGetBranchConfigValue(
Edward Lesmes50da7702020-03-30 19:23:43 +00001544 CODEREVIEW_SERVER_CONFIG_KEY)
tandrii5d48c322016-08-18 16:19:37 -07001545 if self._gerrit_server:
Edward Lemur79d4f992019-11-11 23:49:02 +00001546 self._gerrit_host = urllib.parse.urlparse(self._gerrit_server).netloc
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001547 if not self._gerrit_server:
1548 # We assume repo to be hosted on Gerrit, and hence Gerrit server
1549 # has "-review" suffix for lowest level subdomain.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001550 parts = self._GetGitHost().split('.')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001551 parts[0] = parts[0] + '-review'
1552 self._gerrit_host = '.'.join(parts)
1553 self._gerrit_server = 'https://%s' % self._gerrit_host
1554 return self._gerrit_server
1555
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001556 def GetGerritProject(self):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001557 """Returns Gerrit project name based on remote git URL."""
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001558 remote_url = self.GetRemoteUrl()
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001559 if remote_url is None:
Josip906bfde2020-01-31 22:38:49 +00001560 logging.warning('can\'t detect Gerrit project.')
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001561 return None
Edward Lemur79d4f992019-11-11 23:49:02 +00001562 project = urllib.parse.urlparse(remote_url).path.strip('/')
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001563 if project.endswith('.git'):
1564 project = project[:-len('.git')]
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001565 # *.googlesource.com hosts ensure that Git/Gerrit projects don't start with
1566 # 'a/' prefix, because 'a/' prefix is used to force authentication in
1567 # gitiles/git-over-https protocol. E.g.,
1568 # https://chromium.googlesource.com/a/v8/v8 refers to the same repo/project
1569 # as
1570 # https://chromium.googlesource.com/v8/v8
1571 if project.startswith('a/'):
1572 project = project[len('a/'):]
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001573 return project
1574
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001575 def _GerritChangeIdentifier(self):
1576 """Handy method for gerrit_util.ChangeIdentifier for a given CL.
1577
1578 Not to be confused by value of "Change-Id:" footer.
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001579 If Gerrit project can be determined, this will speed up Gerrit HTTP API RPC.
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001580 """
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001581 project = self.GetGerritProject()
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001582 if project:
1583 return gerrit_util.ChangeIdentifier(project, self.GetIssue())
1584 # Fall back on still unique, but less efficient change number.
1585 return str(self.GetIssue())
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001586
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001587 def EnsureAuthenticated(self, force, refresh=None):
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001588 """Best effort check that user is authenticated with Gerrit server."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001589 if settings.GetGerritSkipEnsureAuthenticated():
1590 # For projects with unusual authentication schemes.
1591 # See http://crbug.com/603378.
1592 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001593
1594 # Check presence of cookies only if using cookies-based auth method.
1595 cookie_auth = gerrit_util.Authenticator.get()
1596 if not isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001597 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001598
Florian Mayerae510e82020-01-30 21:04:48 +00001599 remote_url = self.GetRemoteUrl()
1600 if remote_url is None:
Josip906bfde2020-01-31 22:38:49 +00001601 logging.warning('invalid remote')
Florian Mayerae510e82020-01-30 21:04:48 +00001602 return
1603 if urllib.parse.urlparse(remote_url).scheme != 'https':
Josip906bfde2020-01-31 22:38:49 +00001604 logging.warning('Ignoring branch %(branch)s with non-https remote '
1605 '%(remote)s', {
1606 'branch': self.branch,
1607 'remote': self.GetRemoteUrl()
1608 })
Daniel Chengcf6269b2019-05-18 01:02:12 +00001609 return
1610
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001611 # Lazy-loader to identify Gerrit and Git hosts.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001612 self.GetCodereviewServer()
1613 git_host = self._GetGitHost()
Edward Lemur298f2cf2019-02-22 21:40:39 +00001614 assert self._gerrit_server and self._gerrit_host and git_host
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001615
1616 gerrit_auth = cookie_auth.get_auth_header(self._gerrit_host)
1617 git_auth = cookie_auth.get_auth_header(git_host)
1618 if gerrit_auth and git_auth:
1619 if gerrit_auth == git_auth:
1620 return
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001621 all_gsrc = cookie_auth.get_auth_header('d0esN0tEx1st.googlesource.com')
Raul Tambre80ee78e2019-05-06 22:41:05 +00001622 print(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001623 'WARNING: You have different credentials for Gerrit and git hosts:\n'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001624 ' %s\n'
1625 ' %s\n'
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001626 ' Consider running the following command:\n'
1627 ' git cl creds-check\n'
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001628 ' %s\n'
Raul Tambre80ee78e2019-05-06 22:41:05 +00001629 ' %s' %
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001630 (git_host, self._gerrit_host,
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001631 ('Hint: delete creds for .googlesource.com' if all_gsrc else ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001632 cookie_auth.get_new_password_message(git_host)))
1633 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001634 confirm_or_exit('If you know what you are doing', action='continue')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001635 return
1636 else:
1637 missing = (
Anna Henningsen4e891442017-07-06 21:40:58 +02001638 ([] if gerrit_auth else [self._gerrit_host]) +
1639 ([] if git_auth else [git_host]))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001640 DieWithError('Credentials for the following hosts are required:\n'
1641 ' %s\n'
1642 'These are read from %s (or legacy %s)\n'
1643 '%s' % (
1644 '\n '.join(missing),
1645 cookie_auth.get_gitcookies_path(),
1646 cookie_auth.get_netrc_path(),
1647 cookie_auth.get_new_password_message(git_host)))
1648
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001649 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001650 if not self.GetIssue():
1651 return
1652
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001653 status = self._GetChangeDetail()['status']
1654 if status in ('MERGED', 'ABANDONED'):
1655 DieWithError('Change %s has been %s, new uploads are not allowed' %
1656 (self.GetIssueURL(),
1657 'submitted' if status == 'MERGED' else 'abandoned'))
1658
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001659 # TODO(vadimsh): For some reason the chunk of code below was skipped if
1660 # 'is_gce' is True. I'm just refactoring it to be 'skip if not cookies'.
1661 # Apparently this check is not very important? Otherwise get_auth_email
1662 # could have been added to other implementations of Authenticator.
1663 cookies_auth = gerrit_util.Authenticator.get()
1664 if not isinstance(cookies_auth, gerrit_util.CookiesAuthenticator):
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001665 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001666
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001667 cookies_user = cookies_auth.get_auth_email(self.GetGerritHost())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001668 if self.GetIssueOwner() == cookies_user:
1669 return
1670 logging.debug('change %s owner is %s, cookies user is %s',
1671 self.GetIssue(), self.GetIssueOwner(), cookies_user)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001672 # Maybe user has linked accounts or something like that,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001673 # so ask what Gerrit thinks of this user.
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001674 details = gerrit_util.GetAccountDetails(self.GetGerritHost(), 'self')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001675 if details['email'] == self.GetIssueOwner():
1676 return
1677 if not force:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001678 print('WARNING: Change %s is owned by %s, but you authenticate to Gerrit '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001679 'as %s.\n'
1680 'Uploading may fail due to lack of permissions.' %
1681 (self.GetIssue(), self.GetIssueOwner(), details['email']))
1682 confirm_or_exit(action='upload')
1683
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001684 def GetStatus(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001685 """Applies a rough heuristic to give a simple summary of an issue's review
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001686 or CQ status, assuming adherence to a common workflow.
1687
1688 Returns None if no issue for this branch, or one of the following keywords:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001689 * 'error' - error from review tool (including deleted issues)
1690 * 'unsent' - no reviewers added
1691 * 'waiting' - waiting for review
1692 * 'reply' - waiting for uploader to reply to review
1693 * 'lgtm' - Code-Review label has been set
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00001694 * 'dry-run' - dry-running in the CQ
1695 * 'commit' - in the CQ
Aaron Gable9ab38c62017-04-06 14:36:33 -07001696 * 'closed' - successfully submitted or abandoned
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001697 """
1698 if not self.GetIssue():
1699 return None
1700
1701 try:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001702 data = self._GetChangeDetail([
1703 'DETAILED_LABELS', 'CURRENT_REVISION', 'SUBMITTABLE'])
Edward Lemur79d4f992019-11-11 23:49:02 +00001704 except GerritChangeNotExists:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001705 return 'error'
1706
tandrii@chromium.org5e1bf382016-05-17 08:43:24 +00001707 if data['status'] in ('ABANDONED', 'MERGED'):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001708 return 'closed'
1709
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001710 cq_label = data['labels'].get('Commit-Queue', {})
1711 max_cq_vote = 0
1712 for vote in cq_label.get('all', []):
1713 max_cq_vote = max(max_cq_vote, vote.get('value', 0))
1714 if max_cq_vote == 2:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001715 return 'commit'
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001716 if max_cq_vote == 1:
1717 return 'dry-run'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001718
Aaron Gable9ab38c62017-04-06 14:36:33 -07001719 if data['labels'].get('Code-Review', {}).get('approved'):
1720 return 'lgtm'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001721
1722 if not data.get('reviewers', {}).get('REVIEWER', []):
1723 return 'unsent'
1724
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001725 owner = data['owner'].get('_account_id')
Edward Lemur79d4f992019-11-11 23:49:02 +00001726 messages = sorted(data.get('messages', []), key=lambda m: m.get('date'))
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00001727 while messages:
1728 m = messages.pop()
1729 if m.get('tag', '').startswith('autogenerated:cq:'):
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001730 # Ignore replies from CQ.
1731 continue
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00001732 if m.get('author', {}).get('_account_id') == owner:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001733 # Most recent message was by owner.
1734 return 'waiting'
1735 else:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001736 # Some reply from non-owner.
1737 return 'reply'
Aaron Gable9ab38c62017-04-06 14:36:33 -07001738
1739 # Somehow there are no messages even though there are reviewers.
1740 return 'unsent'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001741
1742 def GetMostRecentPatchset(self):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001743 if not self.GetIssue():
1744 return None
1745
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001746 data = self._GetChangeDetail(['CURRENT_REVISION'])
Aaron Gablee8856ee2017-12-07 12:41:46 -08001747 patchset = data['revisions'][data['current_revision']]['_number']
1748 self.SetPatchset(patchset)
1749 return patchset
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001750
Gavin Make61ccc52020-11-13 00:12:57 +00001751 def GetMostRecentDryRunPatchset(self):
1752 """Get patchsets equivalent to the most recent patchset and return
1753 the patchset with the latest dry run. If none have been dry run, return
1754 the latest patchset."""
1755 if not self.GetIssue():
1756 return None
1757
1758 data = self._GetChangeDetail(['ALL_REVISIONS'])
1759 patchset = data['revisions'][data['current_revision']]['_number']
1760 dry_run = set([int(m['_revision_number'])
1761 for m in data.get('messages', [])
1762 if m.get('tag', '').endswith('dry-run')])
1763
1764 for revision_info in sorted(data.get('revisions', {}).values(),
1765 key=lambda c: c['_number'], reverse=True):
1766 if revision_info['_number'] in dry_run:
1767 patchset = revision_info['_number']
1768 break
1769 if revision_info.get('kind', '') not in \
1770 ('NO_CHANGE', 'NO_CODE_CHANGE', 'TRIVIAL_REBASE'):
1771 break
1772 self.SetPatchset(patchset)
1773 return patchset
1774
Aaron Gable636b13f2017-07-14 10:42:48 -07001775 def AddComment(self, message, publish=None):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001776 gerrit_util.SetReview(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001777 self.GetGerritHost(), self._GerritChangeIdentifier(),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001778 msg=message, ready=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001779
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001780 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01001781 # DETAILED_ACCOUNTS is to get emails in accounts.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001782 # CURRENT_REVISION is included to get the latest patchset so that
1783 # only the robot comments from the latest patchset can be shown.
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001784 messages = self._GetChangeDetail(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001785 options=['MESSAGES', 'DETAILED_ACCOUNTS',
1786 'CURRENT_REVISION']).get('messages', [])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001787 file_comments = gerrit_util.GetChangeComments(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001788 self.GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001789 robot_file_comments = gerrit_util.GetChangeRobotComments(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001790 self.GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001791
1792 # Add the robot comments onto the list of comments, but only
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00001793 # keep those that are from the latest patchset.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001794 latest_patch_set = self.GetMostRecentPatchset()
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001795 for path, robot_comments in robot_file_comments.items():
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001796 line_comments = file_comments.setdefault(path, [])
1797 line_comments.extend(
1798 [c for c in robot_comments if c['patch_set'] == latest_patch_set])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001799
1800 # Build dictionary of file comments for easy access and sorting later.
1801 # {author+date: {path: {patchset: {line: url+message}}}}
1802 comments = collections.defaultdict(
1803 lambda: collections.defaultdict(lambda: collections.defaultdict(dict)))
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00001804
1805 server = self.GetCodereviewServer()
1806 if server in _KNOWN_GERRIT_TO_SHORT_URLS:
1807 # /c/ is automatically added by short URL server.
1808 url_prefix = '%s/%s' % (_KNOWN_GERRIT_TO_SHORT_URLS[server],
1809 self.GetIssue())
1810 else:
1811 url_prefix = '%s/c/%s' % (server, self.GetIssue())
1812
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001813 for path, line_comments in file_comments.items():
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001814 for comment in line_comments:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001815 tag = comment.get('tag', '')
1816 if tag.startswith('autogenerated') and 'robot_id' not in comment:
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001817 continue
1818 key = (comment['author']['email'], comment['updated'])
1819 if comment.get('side', 'REVISION') == 'PARENT':
1820 patchset = 'Base'
1821 else:
1822 patchset = 'PS%d' % comment['patch_set']
1823 line = comment.get('line', 0)
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00001824 url = ('%s/%s/%s#%s%s' %
1825 (url_prefix, comment['patch_set'], path,
1826 'b' if comment.get('side') == 'PARENT' else '',
1827 str(line) if line else ''))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001828 comments[key][path][patchset][line] = (url, comment['message'])
1829
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001830 summaries = []
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001831 for msg in messages:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001832 summary = self._BuildCommentSummary(msg, comments, readable)
1833 if summary:
1834 summaries.append(summary)
1835 return summaries
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001836
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001837 @staticmethod
1838 def _BuildCommentSummary(msg, comments, readable):
1839 key = (msg['author']['email'], msg['date'])
1840 # Don't bother showing autogenerated messages that don't have associated
1841 # file or line comments. this will filter out most autogenerated
1842 # messages, but will keep robot comments like those from Tricium.
1843 is_autogenerated = msg.get('tag', '').startswith('autogenerated')
1844 if is_autogenerated and not comments.get(key):
1845 return None
1846 message = msg['message']
1847 # Gerrit spits out nanoseconds.
1848 assert len(msg['date'].split('.')[-1]) == 9
1849 date = datetime.datetime.strptime(msg['date'][:-3],
1850 '%Y-%m-%d %H:%M:%S.%f')
1851 if key in comments:
1852 message += '\n'
1853 for path, patchsets in sorted(comments.get(key, {}).items()):
1854 if readable:
1855 message += '\n%s' % path
1856 for patchset, lines in sorted(patchsets.items()):
1857 for line, (url, content) in sorted(lines.items()):
1858 if line:
1859 line_str = 'Line %d' % line
1860 path_str = '%s:%d:' % (path, line)
1861 else:
1862 line_str = 'File comment'
1863 path_str = '%s:0:' % path
1864 if readable:
1865 message += '\n %s, %s: %s' % (patchset, line_str, url)
1866 message += '\n %s\n' % content
1867 else:
1868 message += '\n%s ' % path_str
1869 message += '\n%s\n' % content
1870
1871 return _CommentSummary(
1872 date=date,
1873 message=message,
1874 sender=msg['author']['email'],
1875 autogenerated=is_autogenerated,
1876 # These could be inferred from the text messages and correlated with
1877 # Code-Review label maximum, however this is not reliable.
1878 # Leaving as is until the need arises.
1879 approval=False,
1880 disapproval=False,
1881 )
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001882
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001883 def CloseIssue(self):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001884 gerrit_util.AbandonChange(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001885 self.GetGerritHost(), self._GerritChangeIdentifier(), msg='')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001886
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001887 def SubmitIssue(self, wait_for_merge=True):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001888 gerrit_util.SubmitChange(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001889 self.GetGerritHost(), self._GerritChangeIdentifier(),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001890 wait_for_merge=wait_for_merge)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001891
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001892 def _GetChangeDetail(self, options=None):
1893 """Returns details of associated Gerrit change and caching results."""
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00001894 options = options or []
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001895 assert self.GetIssue(), 'issue is required to query Gerrit'
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001896
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001897 # Optimization to avoid multiple RPCs:
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001898 if 'CURRENT_REVISION' in options or 'ALL_REVISIONS' in options:
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001899 options.append('CURRENT_COMMIT')
1900
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001901 # Normalize issue and options for consistent keys in cache.
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001902 cache_key = str(self.GetIssue())
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001903 options_set = frozenset(o.upper() for o in options)
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001904
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001905 for cached_options_set, data in self._detail_cache.get(cache_key, []):
1906 # Assumption: data fetched before with extra options is suitable
1907 # for return for a smaller set of options.
1908 # For example, if we cached data for
1909 # options=[CURRENT_REVISION, DETAILED_FOOTERS]
1910 # and request is for options=[CURRENT_REVISION],
1911 # THEN we can return prior cached data.
1912 if options_set.issubset(cached_options_set):
1913 return data
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001914
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001915 try:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001916 data = gerrit_util.GetChangeDetail(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001917 self.GetGerritHost(), self._GerritChangeIdentifier(), options_set)
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001918 except gerrit_util.GerritError as e:
1919 if e.http_status == 404:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001920 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001921 raise
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001922
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001923 self._detail_cache.setdefault(cache_key, []).append((options_set, data))
tandriic2405f52016-10-10 08:13:15 -07001924 return data
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001925
Andrii Shyshkalovcc5f17e2018-08-22 23:35:59 +00001926 def _GetChangeCommit(self):
Andrii Shyshkalove2633162018-08-27 23:50:31 +00001927 assert self.GetIssue(), 'issue must be set to query Gerrit'
Aaron Gable6f5a8d92017-04-18 14:49:05 -07001928 try:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00001929 data = gerrit_util.GetChangeCommit(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001930 self.GetGerritHost(), self._GerritChangeIdentifier())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07001931 except gerrit_util.GerritError as e:
1932 if e.http_status == 404:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00001933 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07001934 raise
agable32978d92016-11-01 12:55:02 -07001935 return data
1936
Karen Qian40c19422019-03-13 21:28:29 +00001937 def _IsCqConfigured(self):
1938 detail = self._GetChangeDetail(['LABELS'])
Andrii Shyshkalov8effa4d2020-01-21 13:23:36 +00001939 return u'Commit-Queue' in detail.get('labels', {})
Karen Qian40c19422019-03-13 21:28:29 +00001940
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001941 def CMDLand(self, force, bypass_hooks, verbose, parallel, resultdb, realm):
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001942 if git_common.is_dirty_git_tree('land'):
1943 return 1
Karen Qian40c19422019-03-13 21:28:29 +00001944
tandriid60367b2016-06-22 05:25:12 -07001945 detail = self._GetChangeDetail(['CURRENT_REVISION', 'LABELS'])
Karen Qian40c19422019-03-13 21:28:29 +00001946 if not force and self._IsCqConfigured():
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00001947 confirm_or_exit('\nIt seems this repository has a CQ, '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001948 'which can test and land changes for you. '
1949 'Are you sure you wish to bypass it?\n',
1950 action='bypass CQ')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001951 differs = True
tandriic4344b52016-08-29 06:04:54 -07001952 last_upload = self._GitGetBranchConfigValue('gerritsquashhash')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001953 # Note: git diff outputs nothing if there is no diff.
1954 if not last_upload or RunGit(['diff', last_upload]).strip():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001955 print('WARNING: Some changes from local branch haven\'t been uploaded.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001956 else:
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001957 if detail['current_revision'] == last_upload:
1958 differs = False
1959 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001960 print('WARNING: Local branch contents differ from latest uploaded '
1961 'patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001962 if differs:
1963 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001964 confirm_or_exit(
1965 'Do you want to submit latest Gerrit patchset and bypass hooks?\n',
1966 action='submit')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001967 print('WARNING: Bypassing hooks and submitting latest uploaded patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001968 elif not bypass_hooks:
Edward Lemur227d5102020-02-25 23:45:35 +00001969 upstream = self.GetCommonAncestorWithUpstream()
1970 if self.GetIssue():
1971 description = self.FetchDescription()
1972 else:
Edward Lemura12175c2020-03-09 16:58:26 +00001973 description = _create_description_from_log([upstream])
Edward Lemur227d5102020-02-25 23:45:35 +00001974 self.RunHook(
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001975 committing=True,
1976 may_prompt=not force,
1977 verbose=verbose,
Edward Lemur227d5102020-02-25 23:45:35 +00001978 parallel=parallel,
1979 upstream=upstream,
1980 description=description,
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001981 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001982 resultdb=resultdb,
1983 realm=realm)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001984
1985 self.SubmitIssue(wait_for_merge=True)
1986 print('Issue %s has been submitted.' % self.GetIssueURL())
agable32978d92016-11-01 12:55:02 -07001987 links = self._GetChangeCommit().get('web_links', [])
1988 for link in links:
Aaron Gable02cdbb42016-12-13 16:24:25 -08001989 if link.get('name') == 'gitiles' and link.get('url'):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001990 print('Landed as: %s' % link.get('url'))
agable32978d92016-11-01 12:55:02 -07001991 break
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001992 return 0
1993
Edward Lemurf38bc172019-09-03 21:02:13 +00001994 def CMDPatchWithParsedIssue(self, parsed_issue_arg, nocommit, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001995 assert parsed_issue_arg.valid
1996
Edward Lemur125d60a2019-09-13 18:25:41 +00001997 self.issue = parsed_issue_arg.issue
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001998
1999 if parsed_issue_arg.hostname:
2000 self._gerrit_host = parsed_issue_arg.hostname
2001 self._gerrit_server = 'https://%s' % self._gerrit_host
2002
tandriic2405f52016-10-10 08:13:15 -07002003 try:
2004 detail = self._GetChangeDetail(['ALL_REVISIONS'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002005 except GerritChangeNotExists as e:
tandriic2405f52016-10-10 08:13:15 -07002006 DieWithError(str(e))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002007
2008 if not parsed_issue_arg.patchset:
2009 # Use current revision by default.
2010 revision_info = detail['revisions'][detail['current_revision']]
2011 patchset = int(revision_info['_number'])
2012 else:
2013 patchset = parsed_issue_arg.patchset
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002014 for revision_info in detail['revisions'].values():
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002015 if int(revision_info['_number']) == parsed_issue_arg.patchset:
2016 break
2017 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08002018 DieWithError('Couldn\'t find patchset %i in change %i' %
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002019 (parsed_issue_arg.patchset, self.GetIssue()))
2020
Edward Lemur125d60a2019-09-13 18:25:41 +00002021 remote_url = self.GetRemoteUrl()
Aaron Gable697a91b2018-01-19 15:20:15 -08002022 if remote_url.endswith('.git'):
2023 remote_url = remote_url[:-len('.git')]
erikchen0d14d0d2018-08-28 18:57:09 +00002024 remote_url = remote_url.rstrip('/')
2025
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002026 fetch_info = revision_info['fetch']['http']
erikchen0d14d0d2018-08-28 18:57:09 +00002027 fetch_info['url'] = fetch_info['url'].rstrip('/')
Aaron Gable697a91b2018-01-19 15:20:15 -08002028
2029 if remote_url != fetch_info['url']:
2030 DieWithError('Trying to patch a change from %s but this repo appears '
2031 'to be %s.' % (fetch_info['url'], remote_url))
2032
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002033 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
Aaron Gable9387b4f2017-06-08 10:50:03 -07002034
Aaron Gable62619a32017-06-16 08:22:09 -07002035 if force:
2036 RunGit(['reset', '--hard', 'FETCH_HEAD'])
2037 print('Checked out commit for change %i patchset %i locally' %
2038 (parsed_issue_arg.issue, patchset))
Stefan Zager2d5f0392017-10-10 15:17:53 -07002039 elif nocommit:
2040 RunGit(['cherry-pick', '--no-commit', 'FETCH_HEAD'])
2041 print('Patch applied to index.')
Aaron Gable62619a32017-06-16 08:22:09 -07002042 else:
Aaron Gable9387b4f2017-06-08 10:50:03 -07002043 RunGit(['cherry-pick', 'FETCH_HEAD'])
2044 print('Committed patch for change %i patchset %i locally.' %
Aaron Gable62619a32017-06-16 08:22:09 -07002045 (parsed_issue_arg.issue, patchset))
2046 print('Note: this created a local commit which does not have '
2047 'the same hash as the one uploaded for review. This will make '
2048 'uploading changes based on top of this branch difficult.\n'
2049 'If you want to do that, use "git cl patch --force" instead.')
2050
Stefan Zagerd08043c2017-10-12 12:07:02 -07002051 if self.GetBranch():
2052 self.SetIssue(parsed_issue_arg.issue)
2053 self.SetPatchset(patchset)
Edward Lesmes50da7702020-03-30 19:23:43 +00002054 fetched_hash = scm.GIT.ResolveCommit(settings.GetRoot(), 'FETCH_HEAD')
Stefan Zagerd08043c2017-10-12 12:07:02 -07002055 self._GitSetBranchConfigValue('last-upload-hash', fetched_hash)
2056 self._GitSetBranchConfigValue('gerritsquashhash', fetched_hash)
2057 else:
2058 print('WARNING: You are in detached HEAD state.\n'
2059 'The patch has been applied to your checkout, but you will not be '
2060 'able to upload a new patch set to the gerrit issue.\n'
2061 'Try using the \'-b\' option if you would like to work on a '
2062 'branch and/or upload a new patch set.')
2063
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002064 return 0
2065
tandrii16e0b4e2016-06-07 10:34:28 -07002066 def _GerritCommitMsgHookCheck(self, offer_removal):
2067 hook = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
2068 if not os.path.exists(hook):
2069 return
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002070 # Crude attempt to distinguish Gerrit Codereview hook from a potentially
2071 # custom developer-made one.
tandrii16e0b4e2016-06-07 10:34:28 -07002072 data = gclient_utils.FileRead(hook)
2073 if not('From Gerrit Code Review' in data and 'add_ChangeId()' in data):
2074 return
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002075 print('WARNING: You have Gerrit commit-msg hook installed.\n'
qyearsley12fa6ff2016-08-24 09:18:40 -07002076 'It is not necessary for uploading with git cl in squash mode, '
tandrii16e0b4e2016-06-07 10:34:28 -07002077 'and may interfere with it in subtle ways.\n'
2078 'We recommend you remove the commit-msg hook.')
2079 if offer_removal:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002080 if ask_for_explicit_yes('Do you want to remove it now?'):
tandrii16e0b4e2016-06-07 10:34:28 -07002081 gclient_utils.rm_file_or_tree(hook)
2082 print('Gerrit commit-msg hook removed.')
2083 else:
2084 print('OK, will keep Gerrit commit-msg hook in place.')
2085
Edward Lemur1b52d872019-05-09 21:12:12 +00002086 def _CleanUpOldTraces(self):
2087 """Keep only the last |MAX_TRACES| traces."""
2088 try:
2089 traces = sorted([
2090 os.path.join(TRACES_DIR, f)
2091 for f in os.listdir(TRACES_DIR)
2092 if (os.path.isfile(os.path.join(TRACES_DIR, f))
2093 and not f.startswith('tmp'))
2094 ])
2095 traces_to_delete = traces[:-MAX_TRACES]
2096 for trace in traces_to_delete:
Daniel Chengcf6269b2019-05-18 01:02:12 +00002097 os.remove(trace)
Edward Lemur1b52d872019-05-09 21:12:12 +00002098 except OSError:
2099 print('WARNING: Failed to remove old git traces from\n'
2100 ' %s'
2101 'Consider removing them manually.' % TRACES_DIR)
Edward Lemurdc8e23d2019-05-07 00:45:48 +00002102
Edward Lemur5737f022019-05-17 01:24:00 +00002103 def _WriteGitPushTraces(self, trace_name, traces_dir, git_push_metadata):
Edward Lemur1b52d872019-05-09 21:12:12 +00002104 """Zip and write the git push traces stored in traces_dir."""
2105 gclient_utils.safe_makedirs(TRACES_DIR)
Edward Lemur1b52d872019-05-09 21:12:12 +00002106 traces_zip = trace_name + '-traces'
2107 traces_readme = trace_name + '-README'
Michael Mosse7f0b4c2019-05-08 04:36:24 +00002108 # Create a temporary dir to store git config and gitcookies in. It will be
2109 # compressed and stored next to the traces.
2110 git_info_dir = tempfile.mkdtemp()
Edward Lemur1b52d872019-05-09 21:12:12 +00002111 git_info_zip = trace_name + '-git-info'
2112
Josip Sokcevic5e18b602020-04-23 21:47:00 +00002113 git_push_metadata['now'] = datetime_now().strftime('%Y-%m-%dT%H:%M:%S.%f')
sangwoo.ko7a614332019-05-22 02:46:19 +00002114
Edward Lemur1b52d872019-05-09 21:12:12 +00002115 git_push_metadata['trace_name'] = trace_name
2116 gclient_utils.FileWrite(
2117 traces_readme, TRACES_README_FORMAT % git_push_metadata)
2118
2119 # Keep only the first 6 characters of the git hashes on the packet
2120 # trace. This greatly decreases size after compression.
2121 packet_traces = os.path.join(traces_dir, 'trace-packet')
2122 if os.path.isfile(packet_traces):
2123 contents = gclient_utils.FileRead(packet_traces)
2124 gclient_utils.FileWrite(
2125 packet_traces, GIT_HASH_RE.sub(r'\1', contents))
2126 shutil.make_archive(traces_zip, 'zip', traces_dir)
2127
2128 # Collect and compress the git config and gitcookies.
2129 git_config = RunGit(['config', '-l'])
2130 gclient_utils.FileWrite(
2131 os.path.join(git_info_dir, 'git-config'),
2132 git_config)
2133
2134 cookie_auth = gerrit_util.Authenticator.get()
2135 if isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
2136 gitcookies_path = cookie_auth.get_gitcookies_path()
2137 if os.path.isfile(gitcookies_path):
2138 gitcookies = gclient_utils.FileRead(gitcookies_path)
2139 gclient_utils.FileWrite(
2140 os.path.join(git_info_dir, 'gitcookies'),
2141 GITCOOKIES_REDACT_RE.sub('REDACTED', gitcookies))
2142 shutil.make_archive(git_info_zip, 'zip', git_info_dir)
2143
Edward Lemur1b52d872019-05-09 21:12:12 +00002144 gclient_utils.rmtree(git_info_dir)
2145
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002146 def _RunGitPushWithTraces(self, refspec, refspec_opts, git_push_metadata):
Edward Lemur1b52d872019-05-09 21:12:12 +00002147 """Run git push and collect the traces resulting from the execution."""
2148 # Create a temporary directory to store traces in. Traces will be compressed
2149 # and stored in a 'traces' dir inside depot_tools.
2150 traces_dir = tempfile.mkdtemp()
Edward Lemur5737f022019-05-17 01:24:00 +00002151 trace_name = os.path.join(
2152 TRACES_DIR, datetime_now().strftime('%Y%m%dT%H%M%S.%f'))
Edward Lemur0f58ae42019-04-30 17:24:12 +00002153
2154 env = os.environ.copy()
2155 env['GIT_REDACT_COOKIES'] = 'o,SSO,GSSO_Uberproxy'
2156 env['GIT_TR2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Jonathan Nieder9779b142019-05-29 23:19:29 +00002157 env['GIT_TRACE2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002158 env['GIT_TRACE_CURL'] = os.path.join(traces_dir, 'trace-curl')
2159 env['GIT_TRACE_CURL_NO_DATA'] = '1'
2160 env['GIT_TRACE_PACKET'] = os.path.join(traces_dir, 'trace-packet')
2161
2162 try:
2163 push_returncode = 0
Edward Lemur1b52d872019-05-09 21:12:12 +00002164 remote_url = self.GetRemoteUrl()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002165 before_push = time_time()
2166 push_stdout = gclient_utils.CheckCallAndFilter(
Edward Lemur1b52d872019-05-09 21:12:12 +00002167 ['git', 'push', remote_url, refspec],
Edward Lemur0f58ae42019-04-30 17:24:12 +00002168 env=env,
2169 print_stdout=True,
2170 # Flush after every line: useful for seeing progress when running as
2171 # recipe.
2172 filter_fn=lambda _: sys.stdout.flush())
Edward Lemur79d4f992019-11-11 23:49:02 +00002173 push_stdout = push_stdout.decode('utf-8', 'replace')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002174 except subprocess2.CalledProcessError as e:
2175 push_returncode = e.returncode
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002176 raise GitPushError(
2177 'Failed to create a change. Please examine output above for the '
2178 'reason of the failure.\n'
2179 'Hint: run command below to diagnose common Git/Gerrit '
2180 'credential problems:\n'
2181 ' git cl creds-check\n'
2182 '\n'
2183 'If git-cl is not working correctly, file a bug under the Infra>SDK '
2184 'component including the files below.\n'
2185 'Review the files before upload, since they might contain sensitive '
2186 'information.\n'
2187 'Set the Restrict-View-Google label so that they are not publicly '
2188 'accessible.\n' + TRACES_MESSAGE % {'trace_name': trace_name})
Edward Lemur0f58ae42019-04-30 17:24:12 +00002189 finally:
2190 execution_time = time_time() - before_push
2191 metrics.collector.add_repeated('sub_commands', {
2192 'command': 'git push',
2193 'execution_time': execution_time,
2194 'exit_code': push_returncode,
2195 'arguments': metrics_utils.extract_known_subcommand_args(refspec_opts),
2196 })
2197
Edward Lemur1b52d872019-05-09 21:12:12 +00002198 git_push_metadata['execution_time'] = execution_time
2199 git_push_metadata['exit_code'] = push_returncode
Edward Lemur5737f022019-05-17 01:24:00 +00002200 self._WriteGitPushTraces(trace_name, traces_dir, git_push_metadata)
Edward Lemur0f58ae42019-04-30 17:24:12 +00002201
Edward Lemur1b52d872019-05-09 21:12:12 +00002202 self._CleanUpOldTraces()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002203 gclient_utils.rmtree(traces_dir)
2204
2205 return push_stdout
2206
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002207 def CMDUploadChange(self, options, git_diff_args, custom_cl_base,
2208 change_desc):
2209 """Upload the current branch to Gerrit, retry if new remote HEAD is
2210 found. options and change_desc may be mutated."""
Josip Sokcevicb631a882021-01-06 18:18:10 +00002211 remote, remote_branch = self.GetRemoteBranch()
2212 branch = GetTargetRef(remote, remote_branch, options.target_branch)
2213
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002214 try:
2215 return self._CMDUploadChange(options, git_diff_args, custom_cl_base,
Josip Sokcevicb631a882021-01-06 18:18:10 +00002216 change_desc, branch)
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002217 except GitPushError as e:
Josip Sokcevicb631a882021-01-06 18:18:10 +00002218 # Repository might be in the middle of transition to main branch as
2219 # default, and uploads to old default might be blocked.
2220 if remote_branch not in [DEFAULT_OLD_BRANCH, DEFAULT_NEW_BRANCH]:
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002221 DieWithError(str(e), change_desc)
2222
Josip Sokcevicb631a882021-01-06 18:18:10 +00002223 project_head = gerrit_util.GetProjectHead(self._gerrit_host,
2224 self.GetGerritProject())
2225 if project_head == branch:
2226 DieWithError(str(e), change_desc)
2227 branch = project_head
2228
2229 print("WARNING: Fetching remote state and retrying upload to default "
2230 "branch...")
2231 RunGit(['fetch', '--prune', remote])
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002232 options.edit_description = False
2233 options.force = True
2234 try:
Josip Sokcevicb631a882021-01-06 18:18:10 +00002235 self._CMDUploadChange(options, git_diff_args, custom_cl_base,
2236 change_desc, branch)
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002237 except GitPushError as e:
2238 DieWithError(str(e), change_desc)
2239
2240 def _CMDUploadChange(self, options, git_diff_args, custom_cl_base,
Josip Sokcevicb631a882021-01-06 18:18:10 +00002241 change_desc, branch):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002242 """Upload the current branch to Gerrit."""
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002243 if options.squash:
tandrii16e0b4e2016-06-07 10:34:28 -07002244 self._GerritCommitMsgHookCheck(offer_removal=not options.force)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002245 if self.GetIssue():
Josipe827b0f2020-01-30 00:07:20 +00002246 # User requested to change description
2247 if options.edit_description:
Josipe827b0f2020-01-30 00:07:20 +00002248 change_desc.prompt()
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002249 change_id = self._GetChangeDetail()['change_id']
Edward Lemur5a644f82020-03-18 16:44:57 +00002250 change_desc.ensure_change_id(change_id)
Aaron Gableb56ad332017-01-06 15:24:31 -08002251 else: # if not self.GetIssue()
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002252 if not options.force:
Anthony Polito8b955342019-09-24 19:01:36 +00002253 change_desc.prompt()
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002254 change_ids = git_footers.get_footer_change_id(change_desc.description)
Edward Lemur5a644f82020-03-18 16:44:57 +00002255 if len(change_ids) == 1:
2256 change_id = change_ids[0]
2257 else:
2258 change_id = GenerateGerritChangeId(change_desc.description)
2259 change_desc.ensure_change_id(change_id)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002260
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002261 if options.preserve_tryjobs:
2262 change_desc.set_preserve_tryjobs()
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002263
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002264 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Edward Lemur5a644f82020-03-18 16:44:57 +00002265 parent = self._ComputeParent(
2266 remote, upstream_branch, custom_cl_base, options.force, change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002267 tree = RunGit(['rev-parse', 'HEAD:']).strip()
Edward Lemur1773f372020-02-22 00:27:14 +00002268 with gclient_utils.temporary_file() as desc_tempfile:
2269 gclient_utils.FileWrite(desc_tempfile, change_desc.description)
2270 ref_to_push = RunGit(
2271 ['commit-tree', tree, '-p', parent, '-F', desc_tempfile]).strip()
Anthony Polito8b955342019-09-24 19:01:36 +00002272 else: # if not options.squash
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002273 if not git_footers.get_footer_change_id(change_desc.description):
2274 DownloadGerritHook(False)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002275 change_desc.set_description(
Edward Lemur5a644f82020-03-18 16:44:57 +00002276 self._AddChangeIdToCommitMessage(
2277 change_desc.description, git_diff_args))
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002278 ref_to_push = 'HEAD'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002279 # For no-squash mode, we assume the remote called "origin" is the one we
2280 # want. It is not worthwhile to support different workflows for
2281 # no-squash mode.
2282 parent = 'origin/%s' % branch
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002283 change_id = git_footers.get_footer_change_id(change_desc.description)[0]
2284
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00002285 SaveDescriptionBackup(change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002286 commits = RunGitSilent(['rev-list', '%s..%s' % (parent,
2287 ref_to_push)]).splitlines()
2288 if len(commits) > 1:
2289 print('WARNING: This will upload %d commits. Run the following command '
2290 'to see which commits will be uploaded: ' % len(commits))
2291 print('git log %s..%s' % (parent, ref_to_push))
2292 print('You can also use `git squash-branch` to squash these into a '
2293 'single commit.')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002294 confirm_or_exit(action='upload')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002295
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002296 reviewers = sorted(change_desc.get_reviewers())
Edward Lemur4508b422019-10-03 21:56:35 +00002297 cc = []
2298 # Add CCs from WATCHLISTS and rietveld.cc git config unless this is
2299 # the initial upload, the CL is private, or auto-CCing has ben disabled.
2300 if not (self.GetIssue() or options.private or options.no_autocc):
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002301 cc = self.GetCCList().split(',')
Edward Lemur4508b422019-10-03 21:56:35 +00002302 # Add cc's from the --cc flag.
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002303 if options.cc:
2304 cc.extend(options.cc)
Edward Lemur79d4f992019-11-11 23:49:02 +00002305 cc = [email.strip() for email in cc if email.strip()]
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002306 if change_desc.get_cced():
2307 cc.extend(change_desc.get_cced())
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002308 if self.GetGerritHost() == 'chromium-review.googlesource.com':
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00002309 valid_accounts = set(reviewers + cc)
2310 # TODO(crbug/877717): relax this for all hosts.
2311 else:
2312 valid_accounts = gerrit_util.ValidAccounts(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002313 self.GetGerritHost(), reviewers + cc)
Andrii Shyshkalovf170af42018-10-30 07:00:44 +00002314 logging.info('accounts %s are recognized, %s invalid',
2315 sorted(valid_accounts),
2316 set(reviewers + cc).difference(set(valid_accounts)))
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002317
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002318 # Extra options that can be specified at push time. Doc:
2319 # https://gerrit-review.googlesource.com/Documentation/user-upload.html
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002320 refspec_opts = []
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002321
Aaron Gable844cf292017-06-28 11:32:59 -07002322 # By default, new changes are started in WIP mode, and subsequent patchsets
2323 # don't send email. At any time, passing --send-mail will mark the change
2324 # ready and send email for that particular patch.
Aaron Gableafd52772017-06-27 16:40:10 -07002325 if options.send_mail:
2326 refspec_opts.append('ready')
Aaron Gable844cf292017-06-28 11:32:59 -07002327 refspec_opts.append('notify=ALL')
Jamie Madill276da0b2018-04-27 14:41:20 -04002328 elif not self.GetIssue() and options.squash:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002329 refspec_opts.append('wip')
Aaron Gableafd52772017-06-27 16:40:10 -07002330 else:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002331 refspec_opts.append('notify=NONE')
Aaron Gable70f4e242017-06-26 10:45:59 -07002332
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002333 # TODO(tandrii): options.message should be posted as a comment
Aaron Gablee5adf612017-07-14 10:43:58 -07002334 # if --send-mail is set on non-initial upload as Rietveld used to do it.
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002335
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002336 # Set options.title in case user was prompted in _GetTitleForUpload and
2337 # _CMDUploadChange needs to be called again.
2338 options.title = self._GetTitleForUpload(options)
2339 if options.title:
Nick Carter8692b182017-11-06 16:30:38 -08002340 # Punctuation and whitespace in |title| must be percent-encoded.
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002341 refspec_opts.append(
2342 'm=' + gerrit_util.PercentEncodeForGitRef(options.title))
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002343
agablec6787972016-09-09 16:13:34 -07002344 if options.private:
Aaron Gableb02daf02017-05-23 11:53:46 -07002345 refspec_opts.append('private')
agablec6787972016-09-09 16:13:34 -07002346
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002347 for r in sorted(reviewers):
2348 if r in valid_accounts:
2349 refspec_opts.append('r=%s' % r)
2350 reviewers.remove(r)
2351 else:
2352 # TODO(tandrii): this should probably be a hard failure.
2353 print('WARNING: reviewer %s doesn\'t have a Gerrit account, skipping'
2354 % r)
2355 for c in sorted(cc):
2356 # refspec option will be rejected if cc doesn't correspond to an
2357 # account, even though REST call to add such arbitrary cc may succeed.
2358 if c in valid_accounts:
2359 refspec_opts.append('cc=%s' % c)
2360 cc.remove(c)
2361
rmistry9eadede2016-09-19 11:22:43 -07002362 if options.topic:
2363 # Documentation on Gerrit topics is here:
2364 # https://gerrit-review.googlesource.com/Documentation/user-upload.html#topic
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002365 refspec_opts.append('topic=%s' % options.topic)
rmistry9eadede2016-09-19 11:22:43 -07002366
Edward Lemur687ca902018-12-05 02:30:30 +00002367 if options.enable_auto_submit:
2368 refspec_opts.append('l=Auto-Submit+1')
2369 if options.use_commit_queue:
2370 refspec_opts.append('l=Commit-Queue+2')
2371 elif options.cq_dry_run:
2372 refspec_opts.append('l=Commit-Queue+1')
2373
2374 if change_desc.get_reviewers(tbr_only=True):
2375 score = gerrit_util.GetCodeReviewTbrScore(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002376 self.GetGerritHost(),
2377 self.GetGerritProject())
Edward Lemur687ca902018-12-05 02:30:30 +00002378 refspec_opts.append('l=Code-Review+%s' % score)
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00002379
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002380 # Gerrit sorts hashtags, so order is not important.
Nodir Turakulov23b82142017-11-16 11:04:25 -08002381 hashtags = {change_desc.sanitize_hash_tag(t) for t in options.hashtags}
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002382 if not self.GetIssue():
Nodir Turakulov23b82142017-11-16 11:04:25 -08002383 hashtags.update(change_desc.get_hash_tags())
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002384 refspec_opts += ['hashtag=%s' % t for t in sorted(hashtags)]
2385
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002386 refspec_suffix = ''
2387 if refspec_opts:
2388 refspec_suffix = '%' + ','.join(refspec_opts)
2389 assert ' ' not in refspec_suffix, (
2390 'spaces not allowed in refspec: "%s"' % refspec_suffix)
2391 refspec = '%s:refs/for/%s%s' % (ref_to_push, branch, refspec_suffix)
2392
Edward Lemur1b52d872019-05-09 21:12:12 +00002393 git_push_metadata = {
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002394 'gerrit_host': self.GetGerritHost(),
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002395 'title': options.title or '<untitled>',
Edward Lemur1b52d872019-05-09 21:12:12 +00002396 'change_id': change_id,
2397 'description': change_desc.description,
2398 }
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002399 push_stdout = self._RunGitPushWithTraces(refspec, refspec_opts,
2400 git_push_metadata)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002401
2402 if options.squash:
Aaron Gable289b4312017-09-13 14:06:16 -07002403 regex = re.compile(r'remote:\s+https?://[\w\-\.\+\/#]*/(\d+)\s.*')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002404 change_numbers = [m.group(1)
2405 for m in map(regex.match, push_stdout.splitlines())
2406 if m]
2407 if len(change_numbers) != 1:
2408 DieWithError(
2409 ('Created|Updated %d issues on Gerrit, but only 1 expected.\n'
Christopher Lamf732cd52017-01-24 12:40:11 +11002410 'Change-Id: %s') % (len(change_numbers), change_id), change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002411 self.SetIssue(change_numbers[0])
tandrii5d48c322016-08-18 16:19:37 -07002412 self._GitSetBranchConfigValue('gerritsquashhash', ref_to_push)
tandrii88189772016-09-29 04:29:57 -07002413
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002414 if self.GetIssue() and (reviewers or cc):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002415 # GetIssue() is not set in case of non-squash uploads according to tests.
Aaron Gable6e7ddb62020-05-27 22:23:29 +00002416 # TODO(crbug.com/751901): non-squash uploads in git cl should be removed.
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002417 gerrit_util.AddReviewers(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002418 self.GetGerritHost(),
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00002419 self._GerritChangeIdentifier(),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002420 reviewers, cc,
2421 notify=bool(options.send_mail))
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002422
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002423 return 0
2424
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002425 def _ComputeParent(self, remote, upstream_branch, custom_cl_base, force,
2426 change_desc):
2427 """Computes parent of the generated commit to be uploaded to Gerrit.
2428
2429 Returns revision or a ref name.
2430 """
2431 if custom_cl_base:
2432 # Try to avoid creating additional unintended CLs when uploading, unless
2433 # user wants to take this risk.
2434 local_ref_of_target_remote = self.GetRemoteBranch()[1]
2435 code, _ = RunGitWithCode(['merge-base', '--is-ancestor', custom_cl_base,
2436 local_ref_of_target_remote])
2437 if code == 1:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002438 print('\nWARNING: Manually specified base of this CL `%s` '
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002439 'doesn\'t seem to belong to target remote branch `%s`.\n\n'
2440 'If you proceed with upload, more than 1 CL may be created by '
2441 'Gerrit as a result, in turn confusing or crashing git cl.\n\n'
2442 'If you are certain that specified base `%s` has already been '
2443 'uploaded to Gerrit as another CL, you may proceed.\n' %
2444 (custom_cl_base, local_ref_of_target_remote, custom_cl_base))
2445 if not force:
2446 confirm_or_exit(
2447 'Do you take responsibility for cleaning up potential mess '
2448 'resulting from proceeding with upload?',
2449 action='upload')
2450 return custom_cl_base
2451
Aaron Gablef97e33d2017-03-30 15:44:27 -07002452 if remote != '.':
2453 return self.GetCommonAncestorWithUpstream()
2454
2455 # If our upstream branch is local, we base our squashed commit on its
2456 # squashed version.
2457 upstream_branch_name = scm.GIT.ShortBranchName(upstream_branch)
2458
Aaron Gablef97e33d2017-03-30 15:44:27 -07002459 if upstream_branch_name == 'master':
Aaron Gable0bbd1c22017-05-08 14:37:08 -07002460 return self.GetCommonAncestorWithUpstream()
Glen Robertson7d98e222020-08-27 17:53:11 +00002461 if upstream_branch_name == 'main':
2462 return self.GetCommonAncestorWithUpstream()
Aaron Gablef97e33d2017-03-30 15:44:27 -07002463
2464 # Check the squashed hash of the parent.
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002465 # TODO(tandrii): consider checking parent change in Gerrit and using its
2466 # hash if tree hash of latest parent revision (patchset) in Gerrit matches
2467 # the tree hash of the parent branch. The upside is less likely bogus
2468 # requests to reupload parent change just because it's uploadhash is
2469 # missing, yet the downside likely exists, too (albeit unknown to me yet).
Edward Lesmesa680c232020-03-31 18:26:44 +00002470 parent = scm.GIT.GetBranchConfig(
2471 settings.GetRoot(), upstream_branch_name, 'gerritsquashhash')
Aaron Gablef97e33d2017-03-30 15:44:27 -07002472 # Verify that the upstream branch has been uploaded too, otherwise
2473 # Gerrit will create additional CLs when uploading.
2474 if not parent or (RunGitSilent(['rev-parse', upstream_branch + ':']) !=
2475 RunGitSilent(['rev-parse', parent + ':'])):
2476 DieWithError(
2477 '\nUpload upstream branch %s first.\n'
2478 'It is likely that this branch has been rebased since its last '
2479 'upload, so you just need to upload it again.\n'
2480 '(If you uploaded it with --no-squash, then branch dependencies '
2481 'are not supported, and you should reupload with --squash.)'
2482 % upstream_branch_name,
2483 change_desc)
2484 return parent
2485
Edward Lemura12175c2020-03-09 16:58:26 +00002486 def _AddChangeIdToCommitMessage(self, log_desc, args):
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002487 """Re-commits using the current message, assumes the commit hook is in
2488 place.
2489 """
Edward Lemura12175c2020-03-09 16:58:26 +00002490 RunGit(['commit', '--amend', '-m', log_desc])
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002491 new_log_desc = _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002492 if git_footers.get_footer_change_id(new_log_desc):
vapiera7fbd5a2016-06-16 09:17:49 -07002493 print('git-cl: Added Change-Id to commit message.')
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002494 return new_log_desc
2495 else:
tandrii@chromium.orgb067ec52016-05-31 15:24:44 +00002496 DieWithError('ERROR: Gerrit commit-msg hook not installed.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002497
tandriie113dfd2016-10-11 10:20:12 -07002498 def CannotTriggerTryJobReason(self):
tandrii8c5a3532016-11-04 07:52:02 -07002499 try:
2500 data = self._GetChangeDetail()
Aaron Gablea45ee112016-11-22 15:14:38 -08002501 except GerritChangeNotExists:
2502 return 'Gerrit doesn\'t know about your change %s' % self.GetIssue()
tandrii8c5a3532016-11-04 07:52:02 -07002503
2504 if data['status'] in ('ABANDONED', 'MERGED'):
2505 return 'CL %s is closed' % self.GetIssue()
2506
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002507 def GetGerritChange(self, patchset=None):
2508 """Returns a buildbucket.v2.GerritChange message for the current issue."""
Edward Lemur79d4f992019-11-11 23:49:02 +00002509 host = urllib.parse.urlparse(self.GetCodereviewServer()).hostname
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002510 issue = self.GetIssue()
Edward Lemur2c210a42019-09-16 23:58:35 +00002511 patchset = int(patchset or self.GetPatchset())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002512 data = self._GetChangeDetail(['ALL_REVISIONS'])
2513
2514 assert host and issue and patchset, 'CL must be uploaded first'
2515
2516 has_patchset = any(
2517 int(revision_data['_number']) == patchset
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002518 for revision_data in data['revisions'].values())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002519 if not has_patchset:
Aaron Gablea45ee112016-11-22 15:14:38 -08002520 raise Exception('Patchset %d is not known in Gerrit change %d' %
tandrii8c5a3532016-11-04 07:52:02 -07002521 (patchset, self.GetIssue()))
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002522
tandrii8c5a3532016-11-04 07:52:02 -07002523 return {
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002524 'host': host,
2525 'change': issue,
2526 'project': data['project'],
2527 'patchset': patchset,
tandrii8c5a3532016-11-04 07:52:02 -07002528 }
tandriie113dfd2016-10-11 10:20:12 -07002529
tandriide281ae2016-10-12 06:02:30 -07002530 def GetIssueOwner(self):
tandrii8c5a3532016-11-04 07:52:02 -07002531 return self._GetChangeDetail(['DETAILED_ACCOUNTS'])['owner']['email']
tandriide281ae2016-10-12 06:02:30 -07002532
Edward Lemur707d70b2018-02-07 00:50:14 +01002533 def GetReviewers(self):
2534 details = self._GetChangeDetail(['DETAILED_ACCOUNTS'])
Mohamed Heikal171c0742018-11-09 20:38:51 +00002535 return [r['email'] for r in details['reviewers'].get('REVIEWER', [])]
Edward Lemur707d70b2018-02-07 00:50:14 +01002536
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002537
Lei Zhang8a0efc12020-08-05 19:58:45 +00002538def _get_bug_line_values(default_project_prefix, bugs):
2539 """Given default_project_prefix and comma separated list of bugs, yields bug
2540 line values.
tandriif9aefb72016-07-01 09:06:51 -07002541
2542 Each bug can be either:
Lei Zhang8a0efc12020-08-05 19:58:45 +00002543 * a number, which is combined with default_project_prefix
tandriif9aefb72016-07-01 09:06:51 -07002544 * string, which is left as is.
2545
2546 This function may produce more than one line, because bugdroid expects one
2547 project per line.
2548
Lei Zhang8a0efc12020-08-05 19:58:45 +00002549 >>> list(_get_bug_line_values('v8:', '123,chromium:789'))
tandriif9aefb72016-07-01 09:06:51 -07002550 ['v8:123', 'chromium:789']
2551 """
2552 default_bugs = []
2553 others = []
2554 for bug in bugs.split(','):
2555 bug = bug.strip()
2556 if bug:
2557 try:
2558 default_bugs.append(int(bug))
2559 except ValueError:
2560 others.append(bug)
2561
2562 if default_bugs:
2563 default_bugs = ','.join(map(str, default_bugs))
Lei Zhang8a0efc12020-08-05 19:58:45 +00002564 if default_project_prefix:
2565 if not default_project_prefix.endswith(':'):
2566 default_project_prefix += ':'
2567 yield '%s%s' % (default_project_prefix, default_bugs)
tandriif9aefb72016-07-01 09:06:51 -07002568 else:
2569 yield default_bugs
2570 for other in sorted(others):
2571 # Don't bother finding common prefixes, CLs with >2 bugs are very very rare.
2572 yield other
2573
2574
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002575class ChangeDescription(object):
2576 """Contains a parsed form of the change description."""
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00002577 R_LINE = r'^[ \t]*(TBR|R)[ \t]*=[ \t]*(.*?)[ \t]*$'
bradnelsond975b302016-10-23 12:20:23 -07002578 CC_LINE = r'^[ \t]*(CC)[ \t]*=[ \t]*(.*?)[ \t]*$'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002579 BUG_LINE = r'^[ \t]*(?:(BUG)[ \t]*=|Bug:)[ \t]*(.*?)[ \t]*$'
Dan Beamd8b04ca2019-10-10 21:23:26 +00002580 FIXED_LINE = r'^[ \t]*Fixed[ \t]*:[ \t]*(.*?)[ \t]*$'
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002581 CHERRY_PICK_LINE = r'^\(cherry picked from commit [a-fA-F0-9]{40}\)$'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002582 STRIP_HASH_TAG_PREFIX = r'^(\s*(revert|reland)( "|:)?\s*)*'
2583 BRACKET_HASH_TAG = r'\s*\[([^\[\]]+)\]'
Anthony Polito02b5af32019-12-02 19:49:47 +00002584 COLON_SEPARATED_HASH_TAG = r'^([a-zA-Z0-9_\- ]+):($|[^:])'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002585 BAD_HASH_TAG_CHUNK = r'[^a-zA-Z0-9]+'
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002586
Dan Beamd8b04ca2019-10-10 21:23:26 +00002587 def __init__(self, description, bug=None, fixed=None):
agable@chromium.org42c20792013-09-12 17:34:49 +00002588 self._description_lines = (description or '').strip().splitlines()
Anthony Polito8b955342019-09-24 19:01:36 +00002589 if bug:
2590 regexp = re.compile(self.BUG_LINE)
2591 prefix = settings.GetBugPrefix()
2592 if not any((regexp.match(line) for line in self._description_lines)):
2593 values = list(_get_bug_line_values(prefix, bug))
2594 self.append_footer('Bug: %s' % ', '.join(values))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002595 if fixed:
2596 regexp = re.compile(self.FIXED_LINE)
2597 prefix = settings.GetBugPrefix()
2598 if not any((regexp.match(line) for line in self._description_lines)):
2599 values = list(_get_bug_line_values(prefix, fixed))
2600 self.append_footer('Fixed: %s' % ', '.join(values))
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002601
agable@chromium.org42c20792013-09-12 17:34:49 +00002602 @property # www.logilab.org/ticket/89786
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08002603 def description(self): # pylint: disable=method-hidden
agable@chromium.org42c20792013-09-12 17:34:49 +00002604 return '\n'.join(self._description_lines)
2605
2606 def set_description(self, desc):
2607 if isinstance(desc, basestring):
2608 lines = desc.splitlines()
2609 else:
2610 lines = [line.rstrip() for line in desc]
2611 while lines and not lines[0]:
2612 lines.pop(0)
2613 while lines and not lines[-1]:
2614 lines.pop(-1)
2615 self._description_lines = lines
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002616
Edward Lemur5a644f82020-03-18 16:44:57 +00002617 def ensure_change_id(self, change_id):
2618 description = self.description
2619 footer_change_ids = git_footers.get_footer_change_id(description)
2620 # Make sure that the Change-Id in the description matches the given one.
2621 if footer_change_ids != [change_id]:
2622 if footer_change_ids:
2623 # Remove any existing Change-Id footers since they don't match the
2624 # expected change_id footer.
2625 description = git_footers.remove_footer(description, 'Change-Id')
2626 print('WARNING: Change-Id has been set to %s. Use `git cl issue 0` '
2627 'if you want to set a new one.')
2628 # Add the expected Change-Id footer.
2629 description = git_footers.add_footer_change_id(description, change_id)
2630 self.set_description(description)
2631
Edward Lesmes968b1fe2020-12-04 00:45:01 +00002632 def update_reviewers(self, reviewers, tbrs, add_owners_to, add_owners):
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002633 """Rewrites the R=/TBR= line(s) as a single line each.
2634
2635 Args:
2636 reviewers (list(str)) - list of additional emails to use for reviewers.
2637 tbrs (list(str)) - list of additional emails to use for TBRs.
2638 add_owners_to (None|'R'|'TBR') - Pass to do an OWNERS lookup for files in
2639 the change that are missing OWNER coverage. If this is not None, you
Edward Lesmes968b1fe2020-12-04 00:45:01 +00002640 must also pass a value for `add_owners`.
2641 add_owners (list(str)) - Owners to add to R or TBR if requested.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002642 """
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002643 assert isinstance(reviewers, list), reviewers
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002644 assert isinstance(tbrs, list), tbrs
2645
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002646 assert add_owners_to in (None, 'TBR', 'R'), add_owners_to
Edward Lesmes968b1fe2020-12-04 00:45:01 +00002647 assert not add_owners_to or add_owners, add_owners_to
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002648
2649 if not reviewers and not tbrs and not add_owners_to:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002650 return
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002651
2652 reviewers = set(reviewers)
2653 tbrs = set(tbrs)
2654 LOOKUP = {
2655 'TBR': tbrs,
2656 'R': reviewers,
2657 }
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002658
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002659 # Get the set of R= and TBR= lines and remove them from the description.
agable@chromium.org42c20792013-09-12 17:34:49 +00002660 regexp = re.compile(self.R_LINE)
2661 matches = [regexp.match(line) for line in self._description_lines]
2662 new_desc = [l for i, l in enumerate(self._description_lines)
2663 if not matches[i]]
2664 self.set_description(new_desc)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002665
agable@chromium.org42c20792013-09-12 17:34:49 +00002666 # Construct new unified R= and TBR= lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002667
2668 # First, update tbrs/reviewers with names from the R=/TBR= lines (if any).
agable@chromium.org42c20792013-09-12 17:34:49 +00002669 for match in matches:
2670 if not match:
2671 continue
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002672 LOOKUP[match.group(1)].update(cleanup_list([match.group(2).strip()]))
2673
2674 # Next, maybe fill in OWNERS coverage gaps to either tbrs/reviewers.
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002675 if add_owners_to:
Edward Lesmes968b1fe2020-12-04 00:45:01 +00002676 LOOKUP[add_owners_to].update(add_owners)
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002677
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002678 # If any folks ended up in both groups, remove them from tbrs.
2679 tbrs -= reviewers
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002680
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002681 new_r_line = 'R=' + ', '.join(sorted(reviewers)) if reviewers else None
2682 new_tbr_line = 'TBR=' + ', '.join(sorted(tbrs)) if tbrs else None
agable@chromium.org42c20792013-09-12 17:34:49 +00002683
2684 # Put the new lines in the description where the old first R= line was.
2685 line_loc = next((i for i, match in enumerate(matches) if match), -1)
2686 if 0 <= line_loc < len(self._description_lines):
2687 if new_tbr_line:
2688 self._description_lines.insert(line_loc, new_tbr_line)
2689 if new_r_line:
2690 self._description_lines.insert(line_loc, new_r_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002691 else:
agable@chromium.org42c20792013-09-12 17:34:49 +00002692 if new_r_line:
2693 self.append_footer(new_r_line)
2694 if new_tbr_line:
2695 self.append_footer(new_tbr_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002696
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002697 def set_preserve_tryjobs(self):
2698 """Ensures description footer contains 'Cq-Do-Not-Cancel-Tryjobs: true'."""
2699 footers = git_footers.parse_footers(self.description)
2700 for v in footers.get('Cq-Do-Not-Cancel-Tryjobs', []):
2701 if v.lower() == 'true':
2702 return
2703 self.append_footer('Cq-Do-Not-Cancel-Tryjobs: true')
2704
Anthony Polito8b955342019-09-24 19:01:36 +00002705 def prompt(self):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002706 """Asks the user to update the description."""
agable@chromium.org42c20792013-09-12 17:34:49 +00002707 self.set_description([
2708 '# Enter a description of the change.',
2709 '# This will be displayed on the codereview site.',
2710 '# The first line will also be used as the subject of the review.',
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +00002711 '#--------------------This line is 72 characters long'
agable@chromium.org42c20792013-09-12 17:34:49 +00002712 '--------------------',
2713 ] + self._description_lines)
Dan Beamd8b04ca2019-10-10 21:23:26 +00002714 bug_regexp = re.compile(self.BUG_LINE)
2715 fixed_regexp = re.compile(self.FIXED_LINE)
Jonas Termansend0f79112019-03-22 15:28:26 +00002716 prefix = settings.GetBugPrefix()
Sigurd Schneider8630bb12020-11-11 14:02:49 +00002717 has_issue = lambda l: bug_regexp.match(l) or fixed_regexp.match(l)
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00002718
Dan Beamd8b04ca2019-10-10 21:23:26 +00002719 if not any((has_issue(line) for line in self._description_lines)):
Anthony Polito8b955342019-09-24 19:01:36 +00002720 self.append_footer('Bug: %s' % prefix)
tandriif9aefb72016-07-01 09:06:51 -07002721
Bruce Dawsonfc487042020-10-27 19:11:37 +00002722 print('Waiting for editor...')
agable@chromium.org42c20792013-09-12 17:34:49 +00002723 content = gclient_utils.RunEditor(self.description, True,
Edward Lemur79d4f992019-11-11 23:49:02 +00002724 git_editor=settings.GetGitEditor())
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00002725 if not content:
2726 DieWithError('Running editor failed')
agable@chromium.org42c20792013-09-12 17:34:49 +00002727 lines = content.splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002728
Bruce Dawson2377b012018-01-11 16:46:49 -08002729 # Strip off comments and default inserted "Bug:" line.
2730 clean_lines = [line.rstrip() for line in lines if not
Jonas Termansend0f79112019-03-22 15:28:26 +00002731 (line.startswith('#') or
2732 line.rstrip() == "Bug:" or
2733 line.rstrip() == "Bug: " + prefix)]
agable@chromium.org42c20792013-09-12 17:34:49 +00002734 if not clean_lines:
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00002735 DieWithError('No CL description, aborting')
agable@chromium.org42c20792013-09-12 17:34:49 +00002736 self.set_description(clean_lines)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002737
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002738 def append_footer(self, line):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002739 """Adds a footer line to the description.
2740
2741 Differentiates legacy "KEY=xxx" footers (used to be called tags) and
2742 Gerrit's footers in the form of "Footer-Key: footer any value" and ensures
2743 that Gerrit footers are always at the end.
2744 """
2745 parsed_footer_line = git_footers.parse_footer(line)
2746 if parsed_footer_line:
2747 # Line is a gerrit footer in the form: Footer-Key: any value.
2748 # Thus, must be appended observing Gerrit footer rules.
2749 self.set_description(
2750 git_footers.add_footer(self.description,
2751 key=parsed_footer_line[0],
2752 value=parsed_footer_line[1]))
2753 return
2754
2755 if not self._description_lines:
2756 self._description_lines.append(line)
2757 return
2758
2759 top_lines, gerrit_footers, _ = git_footers.split_footers(self.description)
2760 if gerrit_footers:
2761 # git_footers.split_footers ensures that there is an empty line before
2762 # actual (gerrit) footers, if any. We have to keep it that way.
2763 assert top_lines and top_lines[-1] == ''
2764 top_lines, separator = top_lines[:-1], top_lines[-1:]
2765 else:
2766 separator = [] # No need for separator if there are no gerrit_footers.
2767
2768 prev_line = top_lines[-1] if top_lines else ''
2769 if (not presubmit_support.Change.TAG_LINE_RE.match(prev_line) or
2770 not presubmit_support.Change.TAG_LINE_RE.match(line)):
2771 top_lines.append('')
2772 top_lines.append(line)
2773 self._description_lines = top_lines + separator + gerrit_footers
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002774
tandrii99a72f22016-08-17 14:33:24 -07002775 def get_reviewers(self, tbr_only=False):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002776 """Retrieves the list of reviewers."""
agable@chromium.org42c20792013-09-12 17:34:49 +00002777 matches = [re.match(self.R_LINE, line) for line in self._description_lines]
tandrii99a72f22016-08-17 14:33:24 -07002778 reviewers = [match.group(2).strip()
2779 for match in matches
2780 if match and (not tbr_only or match.group(1).upper() == 'TBR')]
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002781 return cleanup_list(reviewers)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002782
bradnelsond975b302016-10-23 12:20:23 -07002783 def get_cced(self):
2784 """Retrieves the list of reviewers."""
2785 matches = [re.match(self.CC_LINE, line) for line in self._description_lines]
2786 cced = [match.group(2).strip() for match in matches if match]
2787 return cleanup_list(cced)
2788
Nodir Turakulov23b82142017-11-16 11:04:25 -08002789 def get_hash_tags(self):
2790 """Extracts and sanitizes a list of Gerrit hashtags."""
2791 subject = (self._description_lines or ('',))[0]
2792 subject = re.sub(
2793 self.STRIP_HASH_TAG_PREFIX, '', subject, flags=re.IGNORECASE)
2794
2795 tags = []
2796 start = 0
2797 bracket_exp = re.compile(self.BRACKET_HASH_TAG)
2798 while True:
2799 m = bracket_exp.match(subject, start)
2800 if not m:
2801 break
2802 tags.append(self.sanitize_hash_tag(m.group(1)))
2803 start = m.end()
2804
2805 if not tags:
2806 # Try "Tag: " prefix.
2807 m = re.match(self.COLON_SEPARATED_HASH_TAG, subject)
2808 if m:
2809 tags.append(self.sanitize_hash_tag(m.group(1)))
2810 return tags
2811
2812 @classmethod
2813 def sanitize_hash_tag(cls, tag):
2814 """Returns a sanitized Gerrit hash tag.
2815
2816 A sanitized hashtag can be used as a git push refspec parameter value.
2817 """
2818 return re.sub(cls.BAD_HASH_TAG_CHUNK, '-', tag).strip('-').lower()
2819
maruel@chromium.orge52678e2013-04-26 18:34:44 +00002820
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002821def FindCodereviewSettingsFile(filename='codereview.settings'):
2822 """Finds the given file starting in the cwd and going up.
2823
2824 Only looks up to the top of the repository unless an
2825 'inherit-review-settings-ok' file exists in the root of the repository.
2826 """
2827 inherit_ok_file = 'inherit-review-settings-ok'
2828 cwd = os.getcwd()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00002829 root = settings.GetRoot()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002830 if os.path.isfile(os.path.join(root, inherit_ok_file)):
2831 root = '/'
2832 while True:
2833 if filename in os.listdir(cwd):
2834 if os.path.isfile(os.path.join(cwd, filename)):
2835 return open(os.path.join(cwd, filename))
2836 if cwd == root:
2837 break
2838 cwd = os.path.dirname(cwd)
2839
2840
2841def LoadCodereviewSettingsFromFile(fileobj):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002842 """Parses a codereview.settings file and updates hooks."""
maruel@chromium.org99ac1c52012-01-16 14:52:12 +00002843 keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002844
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002845 def SetProperty(name, setting, unset_error_ok=False):
2846 fullname = 'rietveld.' + name
2847 if setting in keyvals:
2848 RunGit(['config', fullname, keyvals[setting]])
2849 else:
2850 RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok)
2851
tandrii48df5812016-10-17 03:55:37 -07002852 if not keyvals.get('GERRIT_HOST', False):
2853 SetProperty('server', 'CODE_REVIEW_SERVER')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002854 # Only server setting is required. Other settings can be absent.
2855 # In that case, we ignore errors raised during option deletion attempt.
2856 SetProperty('cc', 'CC_LIST', unset_error_ok=True)
2857 SetProperty('tree-status-url', 'STATUS', unset_error_ok=True)
2858 SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True)
rmistry@google.com90752582014-01-14 21:04:50 +00002859 SetProperty('bug-prefix', 'BUG_PREFIX', unset_error_ok=True)
thestig@chromium.org44202a22014-03-11 19:22:18 +00002860 SetProperty('cpplint-regex', 'LINT_REGEX', unset_error_ok=True)
2861 SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +00002862 SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK',
2863 unset_error_ok=True)
Jamie Madilldc4d19e2019-10-24 21:50:02 +00002864 SetProperty(
2865 'format-full-by-default', 'FORMAT_FULL_BY_DEFAULT', unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002866
ukai@chromium.org7044efc2013-11-28 01:51:21 +00002867 if 'GERRIT_HOST' in keyvals:
ukai@chromium.orge8077812012-02-03 03:41:46 +00002868 RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']])
ukai@chromium.orge8077812012-02-03 03:41:46 +00002869
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00002870 if 'GERRIT_SQUASH_UPLOADS' in keyvals:
Edward Lesmes4de54132020-05-05 19:41:33 +00002871 RunGit(['config', 'gerrit.squash-uploads',
2872 keyvals['GERRIT_SQUASH_UPLOADS']])
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00002873
tandrii@chromium.org28253532016-04-14 13:46:56 +00002874 if 'GERRIT_SKIP_ENSURE_AUTHENTICATED' in keyvals:
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00002875 RunGit(['config', 'gerrit.skip-ensure-authenticated',
tandrii@chromium.org28253532016-04-14 13:46:56 +00002876 keyvals['GERRIT_SKIP_ENSURE_AUTHENTICATED']])
2877
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002878 if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01002879 # should be of the form
2880 # PUSH_URL_CONFIG: url.ssh://gitrw.chromium.org.pushinsteadof
2881 # ORIGIN_URL_CONFIG: http://src.chromium.org/git
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002882 RunGit(['config', keyvals['PUSH_URL_CONFIG'],
2883 keyvals['ORIGIN_URL_CONFIG']])
2884
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002885
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00002886def urlretrieve(source, destination):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002887 """Downloads a network object to a local file, like urllib.urlretrieve.
2888
2889 This is necessary because urllib is broken for SSL connections via a proxy.
2890 """
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00002891 with open(destination, 'w') as f:
Edward Lemur79d4f992019-11-11 23:49:02 +00002892 f.write(urllib.request.urlopen(source).read())
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00002893
2894
ukai@chromium.org712d6102013-11-27 00:52:58 +00002895def hasSheBang(fname):
2896 """Checks fname is a #! script."""
2897 with open(fname) as f:
2898 return f.read(2).startswith('#!')
2899
2900
tandrii@chromium.org18630d62016-03-04 12:06:02 +00002901def DownloadGerritHook(force):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002902 """Downloads and installs a Gerrit commit-msg hook.
ukai@chromium.org78c4b982012-02-14 02:20:26 +00002903
2904 Args:
2905 force: True to update hooks. False to install hooks if not present.
2906 """
ukai@chromium.org712d6102013-11-27 00:52:58 +00002907 src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg'
ukai@chromium.org78c4b982012-02-14 02:20:26 +00002908 dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
2909 if not os.access(dst, os.X_OK):
2910 if os.path.exists(dst):
2911 if not force:
2912 return
ukai@chromium.org78c4b982012-02-14 02:20:26 +00002913 try:
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00002914 urlretrieve(src, dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00002915 if not hasSheBang(dst):
2916 DieWithError('Not a script: %s\n'
2917 'You need to download from\n%s\n'
2918 'into .git/hooks/commit-msg and '
2919 'chmod +x .git/hooks/commit-msg' % (dst, src))
ukai@chromium.org78c4b982012-02-14 02:20:26 +00002920 os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
2921 except Exception:
2922 if os.path.exists(dst):
2923 os.remove(dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00002924 DieWithError('\nFailed to download hooks.\n'
2925 'You need to download from\n%s\n'
2926 'into .git/hooks/commit-msg and '
2927 'chmod +x .git/hooks/commit-msg' % src)
ukai@chromium.org78c4b982012-02-14 02:20:26 +00002928
2929
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01002930class _GitCookiesChecker(object):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002931 """Provides facilities for validating and suggesting fixes to .gitcookies."""
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002932
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002933 _GOOGLESOURCE = 'googlesource.com'
2934
2935 def __init__(self):
2936 # Cached list of [host, identity, source], where source is either
2937 # .gitcookies or .netrc.
2938 self._all_hosts = None
2939
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01002940 def ensure_configured_gitcookies(self):
2941 """Runs checks and suggests fixes to make git use .gitcookies from default
2942 path."""
2943 default = gerrit_util.CookiesAuthenticator.get_gitcookies_path()
2944 configured_path = RunGitSilent(
2945 ['config', '--global', 'http.cookiefile']).strip()
Andrii Shyshkalov1e250cd2017-05-10 15:39:31 +02002946 configured_path = os.path.expanduser(configured_path)
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01002947 if configured_path:
2948 self._ensure_default_gitcookies_path(configured_path, default)
2949 else:
2950 self._configure_gitcookies_path(default)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002951
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01002952 @staticmethod
2953 def _ensure_default_gitcookies_path(configured_path, default_path):
2954 assert configured_path
2955 if configured_path == default_path:
2956 print('git is already configured to use your .gitcookies from %s' %
2957 configured_path)
2958 return
2959
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002960 print('WARNING: You have configured custom path to .gitcookies: %s\n'
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01002961 'Gerrit and other depot_tools expect .gitcookies at %s\n' %
2962 (configured_path, default_path))
2963
2964 if not os.path.exists(configured_path):
2965 print('However, your configured .gitcookies file is missing.')
2966 confirm_or_exit('Reconfigure git to use default .gitcookies?',
2967 action='reconfigure')
2968 RunGit(['config', '--global', 'http.cookiefile', default_path])
2969 return
2970
2971 if os.path.exists(default_path):
2972 print('WARNING: default .gitcookies file already exists %s' %
2973 default_path)
2974 DieWithError('Please delete %s manually and re-run git cl creds-check' %
2975 default_path)
2976
2977 confirm_or_exit('Move existing .gitcookies to default location?',
2978 action='move')
2979 shutil.move(configured_path, default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002980 RunGit(['config', '--global', 'http.cookiefile', default_path])
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01002981 print('Moved and reconfigured git to use .gitcookies from %s' %
2982 default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002983
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01002984 @staticmethod
2985 def _configure_gitcookies_path(default_path):
2986 netrc_path = gerrit_util.CookiesAuthenticator.get_netrc_path()
2987 if os.path.exists(netrc_path):
2988 print('You seem to be using outdated .netrc for git credentials: %s' %
2989 netrc_path)
2990 print('This tool will guide you through setting up recommended '
2991 '.gitcookies store for git credentials.\n'
2992 '\n'
2993 'IMPORTANT: If something goes wrong and you decide to go back, do:\n'
2994 ' git config --global --unset http.cookiefile\n'
2995 ' mv %s %s.backup\n\n' % (default_path, default_path))
2996 confirm_or_exit(action='setup .gitcookies')
2997 RunGit(['config', '--global', 'http.cookiefile', default_path])
2998 print('Configured git to use .gitcookies from %s' % default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002999
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003000 def get_hosts_with_creds(self, include_netrc=False):
3001 if self._all_hosts is None:
3002 a = gerrit_util.CookiesAuthenticator()
3003 self._all_hosts = [
3004 (h, u, s)
3005 for h, u, s in itertools.chain(
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003006 ((h, u, '.netrc') for h, (u, _, _) in a.netrc.hosts.items()),
3007 ((h, u, '.gitcookies') for h, (u, _) in a.gitcookies.items())
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003008 )
3009 if h.endswith(self._GOOGLESOURCE)
3010 ]
3011
3012 if include_netrc:
3013 return self._all_hosts
3014 return [(h, u, s) for h, u, s in self._all_hosts if s != '.netrc']
3015
3016 def print_current_creds(self, include_netrc=False):
3017 hosts = sorted(self.get_hosts_with_creds(include_netrc=include_netrc))
3018 if not hosts:
3019 print('No Git/Gerrit credentials found')
3020 return
Edward Lemur79d4f992019-11-11 23:49:02 +00003021 lengths = [max(map(len, (row[i] for row in hosts))) for i in range(3)]
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003022 header = [('Host', 'User', 'Which file'),
3023 ['=' * l for l in lengths]]
3024 for row in (header + hosts):
3025 print('\t'.join((('%%+%ds' % l) % s)
3026 for l, s in zip(lengths, row)))
3027
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003028 @staticmethod
3029 def _parse_identity(identity):
Lei Zhangd3f769a2017-12-15 15:16:14 -08003030 """Parses identity "git-<username>.domain" into <username> and domain."""
3031 # Special case: usernames that contain ".", which are generally not
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02003032 # distinguishable from sub-domains. But we do know typical domains:
3033 if identity.endswith('.chromium.org'):
3034 domain = 'chromium.org'
3035 username = identity[:-len('.chromium.org')]
3036 else:
3037 username, domain = identity.split('.', 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003038 if username.startswith('git-'):
3039 username = username[len('git-'):]
3040 return username, domain
3041
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003042 def _canonical_git_googlesource_host(self, host):
3043 """Normalizes Gerrit hosts (with '-review') to Git host."""
3044 assert host.endswith(self._GOOGLESOURCE)
3045 # Prefix doesn't include '.' at the end.
3046 prefix = host[:-(1 + len(self._GOOGLESOURCE))]
3047 if prefix.endswith('-review'):
3048 prefix = prefix[:-len('-review')]
3049 return prefix + '.' + self._GOOGLESOURCE
3050
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003051 def _canonical_gerrit_googlesource_host(self, host):
3052 git_host = self._canonical_git_googlesource_host(host)
3053 prefix = git_host.split('.', 1)[0]
3054 return prefix + '-review.' + self._GOOGLESOURCE
3055
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003056 def _get_counterpart_host(self, host):
3057 assert host.endswith(self._GOOGLESOURCE)
3058 git = self._canonical_git_googlesource_host(host)
3059 gerrit = self._canonical_gerrit_googlesource_host(git)
3060 return git if gerrit == host else gerrit
3061
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003062 def has_generic_host(self):
3063 """Returns whether generic .googlesource.com has been configured.
3064
3065 Chrome Infra recommends to use explicit ${host}.googlesource.com instead.
3066 """
3067 for host, _, _ in self.get_hosts_with_creds(include_netrc=False):
3068 if host == '.' + self._GOOGLESOURCE:
3069 return True
3070 return False
3071
3072 def _get_git_gerrit_identity_pairs(self):
3073 """Returns map from canonic host to pair of identities (Git, Gerrit).
3074
3075 One of identities might be None, meaning not configured.
3076 """
3077 host_to_identity_pairs = {}
3078 for host, identity, _ in self.get_hosts_with_creds():
3079 canonical = self._canonical_git_googlesource_host(host)
3080 pair = host_to_identity_pairs.setdefault(canonical, [None, None])
3081 idx = 0 if canonical == host else 1
3082 pair[idx] = identity
3083 return host_to_identity_pairs
3084
3085 def get_partially_configured_hosts(self):
3086 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003087 (host if i1 else self._canonical_gerrit_googlesource_host(host))
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003088 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().items()
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003089 if None in (i1, i2) and host != '.' + self._GOOGLESOURCE)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003090
3091 def get_conflicting_hosts(self):
3092 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003093 host
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003094 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().items()
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003095 if None not in (i1, i2) and i1 != i2)
3096
3097 def get_duplicated_hosts(self):
3098 counters = collections.Counter(h for h, _, _ in self.get_hosts_with_creds())
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003099 return set(host for host, count in counters.items() if count > 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003100
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003101
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003102 @staticmethod
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003103 def _format_hosts(hosts, extra_column_func=None):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003104 hosts = sorted(hosts)
3105 assert hosts
3106 if extra_column_func is None:
3107 extras = [''] * len(hosts)
3108 else:
3109 extras = [extra_column_func(host) for host in hosts]
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003110 tmpl = '%%-%ds %%-%ds' % (max(map(len, hosts)), max(map(len, extras)))
3111 lines = []
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003112 for he in zip(hosts, extras):
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003113 lines.append(tmpl % he)
3114 return lines
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003115
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003116 def _find_problems(self):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003117 if self.has_generic_host():
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003118 yield ('.googlesource.com wildcard record detected',
3119 ['Chrome Infrastructure team recommends to list full host names '
3120 'explicitly.'],
3121 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003122
3123 dups = self.get_duplicated_hosts()
3124 if dups:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003125 yield ('The following hosts were defined twice',
3126 self._format_hosts(dups),
3127 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003128
3129 partial = self.get_partially_configured_hosts()
3130 if partial:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003131 yield ('Credentials should come in pairs for Git and Gerrit hosts. '
3132 'These hosts are missing',
3133 self._format_hosts(partial, lambda host: 'but %s defined' %
3134 self._get_counterpart_host(host)),
3135 partial)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003136
3137 conflicting = self.get_conflicting_hosts()
3138 if conflicting:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003139 yield ('The following Git hosts have differing credentials from their '
3140 'Gerrit counterparts',
3141 self._format_hosts(conflicting, lambda host: '%s vs %s' %
3142 tuple(self._get_git_gerrit_identity_pairs()[host])),
3143 conflicting)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003144
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003145 def find_and_report_problems(self):
3146 """Returns True if there was at least one problem, else False."""
3147 found = False
3148 bad_hosts = set()
3149 for title, sublines, hosts in self._find_problems():
3150 if not found:
3151 found = True
3152 print('\n\n.gitcookies problem report:\n')
3153 bad_hosts.update(hosts or [])
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003154 print(' %s%s' % (title, (':' if sublines else '')))
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003155 if sublines:
3156 print()
3157 print(' %s' % '\n '.join(sublines))
3158 print()
3159
3160 if bad_hosts:
3161 assert found
3162 print(' You can manually remove corresponding lines in your %s file and '
3163 'visit the following URLs with correct account to generate '
3164 'correct credential lines:\n' %
3165 gerrit_util.CookiesAuthenticator.get_gitcookies_path())
3166 print(' %s' % '\n '.join(sorted(set(
3167 gerrit_util.CookiesAuthenticator().get_new_password_url(
3168 self._canonical_git_googlesource_host(host))
3169 for host in bad_hosts
3170 ))))
3171 return found
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003172
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003173
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003174@metrics.collector.collect_metrics('git cl creds-check')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003175def CMDcreds_check(parser, args):
3176 """Checks credentials and suggests changes."""
3177 _, _ = parser.parse_args(args)
3178
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003179 # Code below checks .gitcookies. Abort if using something else.
3180 authn = gerrit_util.Authenticator.get()
3181 if not isinstance(authn, gerrit_util.CookiesAuthenticator):
Edward Lemur57d47422020-03-06 20:43:07 +00003182 message = (
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003183 'This command is not designed for bot environment. It checks '
3184 '~/.gitcookies file not generally used on bots.')
Edward Lemur57d47422020-03-06 20:43:07 +00003185 # TODO(crbug.com/1059384): Automatically detect when running on cloudtop.
3186 if isinstance(authn, gerrit_util.GceAuthenticator):
3187 message += (
3188 '\n'
3189 'If you need to run this on GCE or a cloudtop instance, '
3190 'export SKIP_GCE_AUTH_FOR_GIT=1 in your env.')
3191 DieWithError(message)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003192
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003193 checker = _GitCookiesChecker()
3194 checker.ensure_configured_gitcookies()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003195
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003196 print('Your .netrc and .gitcookies have credentials for these hosts:')
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003197 checker.print_current_creds(include_netrc=True)
3198
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003199 if not checker.find_and_report_problems():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003200 print('\nNo problems detected in your .gitcookies file.')
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003201 return 0
3202 return 1
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003203
3204
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003205@metrics.collector.collect_metrics('git cl baseurl')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003206def CMDbaseurl(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003207 """Gets or sets base-url for this branch."""
Edward Lesmes50da7702020-03-30 19:23:43 +00003208 branchref = scm.GIT.GetBranchRef(settings.GetRoot())
Edward Lemur85153282020-02-14 22:06:29 +00003209 branch = scm.GIT.ShortBranchName(branchref)
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003210 _, args = parser.parse_args(args)
3211 if not args:
vapiera7fbd5a2016-06-16 09:17:49 -07003212 print('Current base-url:')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003213 return RunGit(['config', 'branch.%s.base-url' % branch],
3214 error_ok=False).strip()
3215 else:
vapiera7fbd5a2016-06-16 09:17:49 -07003216 print('Setting base-url to %s' % args[0])
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003217 return RunGit(['config', 'branch.%s.base-url' % branch, args[0]],
3218 error_ok=False).strip()
3219
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003220
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003221def color_for_status(status):
3222 """Maps a Changelist status to color, for CMDstatus and other tools."""
Bruce Dawsonb73f8a92020-03-27 22:03:08 +00003223 BOLD = '\033[1m'
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003224 return {
Bruce Dawsonb73f8a92020-03-27 22:03:08 +00003225 'unsent': BOLD + Fore.YELLOW,
3226 'waiting': BOLD + Fore.RED,
3227 'reply': BOLD + Fore.YELLOW,
3228 'not lgtm': BOLD + Fore.RED,
3229 'lgtm': BOLD + Fore.GREEN,
3230 'commit': BOLD + Fore.MAGENTA,
3231 'closed': BOLD + Fore.CYAN,
3232 'error': BOLD + Fore.WHITE,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003233 }.get(status, Fore.WHITE)
3234
tandrii@chromium.org04ea8462016-04-25 19:51:21 +00003235
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003236def get_cl_statuses(changes, fine_grained, max_processes=None):
3237 """Returns a blocking iterable of (cl, status) for given branches.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003238
3239 If fine_grained is true, this will fetch CL statuses from the server.
3240 Otherwise, simply indicate if there's a matching url for the given branches.
3241
3242 If max_processes is specified, it is used as the maximum number of processes
3243 to spawn to fetch CL status from the server. Otherwise 1 process per branch is
3244 spawned.
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003245
3246 See GetStatus() for a list of possible statuses.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003247 """
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003248 if not changes:
Edward Lemur61bf4172020-02-24 23:22:37 +00003249 return
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003250
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003251 if not fine_grained:
3252 # Fast path which doesn't involve querying codereview servers.
Aaron Gablea1bab272017-04-11 16:38:18 -07003253 # Do not use get_approving_reviewers(), since it requires an HTTP request.
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003254 for cl in changes:
3255 yield (cl, 'waiting' if cl.GetIssueURL() else 'error')
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003256 return
3257
3258 # First, sort out authentication issues.
3259 logging.debug('ensuring credentials exist')
3260 for cl in changes:
3261 cl.EnsureAuthenticated(force=False, refresh=True)
3262
3263 def fetch(cl):
3264 try:
3265 return (cl, cl.GetStatus())
3266 except:
3267 # See http://crbug.com/629863.
Andrii Shyshkalov98824232018-04-19 11:37:15 -07003268 logging.exception('failed to fetch status for cl %s:', cl.GetIssue())
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003269 raise
3270
3271 threads_count = len(changes)
3272 if max_processes:
3273 threads_count = max(1, min(threads_count, max_processes))
3274 logging.debug('querying %d CLs using %d threads', len(changes), threads_count)
3275
Edward Lemur61bf4172020-02-24 23:22:37 +00003276 pool = multiprocessing.pool.ThreadPool(threads_count)
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003277 fetched_cls = set()
3278 try:
3279 it = pool.imap_unordered(fetch, changes).__iter__()
3280 while True:
3281 try:
3282 cl, status = it.next(timeout=5)
Edward Lemur61bf4172020-02-24 23:22:37 +00003283 except (multiprocessing.TimeoutError, StopIteration):
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003284 break
3285 fetched_cls.add(cl)
3286 yield cl, status
3287 finally:
3288 pool.close()
3289
3290 # Add any branches that failed to fetch.
3291 for cl in set(changes) - fetched_cls:
3292 yield (cl, 'error')
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003293
rmistry@google.com2dd99862015-06-22 12:22:18 +00003294
Jose Lopes3863fc52020-04-07 17:00:25 +00003295def upload_branch_deps(cl, args, force=False):
rmistry@google.com2dd99862015-06-22 12:22:18 +00003296 """Uploads CLs of local branches that are dependents of the current branch.
3297
3298 If the local branch dependency tree looks like:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003299
3300 test1 -> test2.1 -> test3.1
3301 -> test3.2
3302 -> test2.2 -> test3.3
rmistry@google.com2dd99862015-06-22 12:22:18 +00003303
3304 and you run "git cl upload --dependencies" from test1 then "git cl upload" is
3305 run on the dependent branches in this order:
3306 test2.1, test3.1, test3.2, test2.2, test3.3
3307
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003308 Note: This function does not rebase your local dependent branches. Use it
3309 when you make a change to the parent branch that will not conflict
3310 with its dependent branches, and you would like their dependencies
3311 updated in Rietveld.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003312 """
3313 if git_common.is_dirty_git_tree('upload-branch-deps'):
3314 return 1
3315
3316 root_branch = cl.GetBranch()
3317 if root_branch is None:
3318 DieWithError('Can\'t find dependent branches from detached HEAD state. '
3319 'Get on a branch!')
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00003320 if not cl.GetIssue():
rmistry@google.com2dd99862015-06-22 12:22:18 +00003321 DieWithError('Current branch does not have an uploaded CL. We cannot set '
3322 'patchset dependencies without an uploaded CL.')
3323
3324 branches = RunGit(['for-each-ref',
3325 '--format=%(refname:short) %(upstream:short)',
3326 'refs/heads'])
3327 if not branches:
3328 print('No local branches found.')
3329 return 0
3330
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003331 # Create a dictionary of all local branches to the branches that are
3332 # dependent on it.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003333 tracked_to_dependents = collections.defaultdict(list)
3334 for b in branches.splitlines():
3335 tokens = b.split()
3336 if len(tokens) == 2:
3337 branch_name, tracked = tokens
3338 tracked_to_dependents[tracked].append(branch_name)
3339
vapiera7fbd5a2016-06-16 09:17:49 -07003340 print()
3341 print('The dependent local branches of %s are:' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003342 dependents = []
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003343
rmistry@google.com2dd99862015-06-22 12:22:18 +00003344 def traverse_dependents_preorder(branch, padding=''):
3345 dependents_to_process = tracked_to_dependents.get(branch, [])
3346 padding += ' '
3347 for dependent in dependents_to_process:
vapiera7fbd5a2016-06-16 09:17:49 -07003348 print('%s%s' % (padding, dependent))
rmistry@google.com2dd99862015-06-22 12:22:18 +00003349 dependents.append(dependent)
3350 traverse_dependents_preorder(dependent, padding)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003351
rmistry@google.com2dd99862015-06-22 12:22:18 +00003352 traverse_dependents_preorder(root_branch)
vapiera7fbd5a2016-06-16 09:17:49 -07003353 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003354
3355 if not dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003356 print('There are no dependent local branches for %s' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003357 return 0
3358
Jose Lopes3863fc52020-04-07 17:00:25 +00003359 if not force:
3360 confirm_or_exit('This command will checkout all dependent branches and run '
3361 '"git cl upload".', action='continue')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003362
rmistry@google.com2dd99862015-06-22 12:22:18 +00003363 # Record all dependents that failed to upload.
3364 failures = {}
3365 # Go through all dependents, checkout the branch and upload.
3366 try:
3367 for dependent_branch in dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003368 print()
3369 print('--------------------------------------')
3370 print('Running "git cl upload" from %s:' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003371 RunGit(['checkout', '-q', dependent_branch])
vapiera7fbd5a2016-06-16 09:17:49 -07003372 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003373 try:
3374 if CMDupload(OptionParser(), args) != 0:
vapiera7fbd5a2016-06-16 09:17:49 -07003375 print('Upload failed for %s!' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003376 failures[dependent_branch] = 1
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003377 except: # pylint: disable=bare-except
rmistry@google.com2dd99862015-06-22 12:22:18 +00003378 failures[dependent_branch] = 1
vapiera7fbd5a2016-06-16 09:17:49 -07003379 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003380 finally:
3381 # Swap back to the original root branch.
3382 RunGit(['checkout', '-q', root_branch])
3383
vapiera7fbd5a2016-06-16 09:17:49 -07003384 print()
3385 print('Upload complete for dependent branches!')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003386 for dependent_branch in dependents:
3387 upload_status = 'failed' if failures.get(dependent_branch) else 'succeeded'
vapiera7fbd5a2016-06-16 09:17:49 -07003388 print(' %s : %s' % (dependent_branch, upload_status))
3389 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003390
3391 return 0
3392
3393
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003394def GetArchiveTagForBranch(issue_num, branch_name, existing_tags, pattern):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003395 """Given a proposed tag name, returns a tag name that is guaranteed to be
3396 unique. If 'foo' is proposed but already exists, then 'foo-2' is used,
3397 or 'foo-3', and so on."""
3398
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003399 proposed_tag = pattern.format(**{'issue': issue_num, 'branch': branch_name})
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003400 for suffix_num in itertools.count(1):
3401 if suffix_num == 1:
3402 to_check = proposed_tag
3403 else:
3404 to_check = '%s-%d' % (proposed_tag, suffix_num)
3405
3406 if to_check not in existing_tags:
3407 return to_check
3408
3409
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003410@metrics.collector.collect_metrics('git cl archive')
kmarshall3bff56b2016-06-06 18:31:47 -07003411def CMDarchive(parser, args):
3412 """Archives and deletes branches associated with closed changelists."""
3413 parser.add_option(
3414 '-j', '--maxjobs', action='store', type=int,
kmarshall9249e012016-08-23 12:02:16 -07003415 help='The maximum number of jobs to use when retrieving review status.')
kmarshall3bff56b2016-06-06 18:31:47 -07003416 parser.add_option(
3417 '-f', '--force', action='store_true',
3418 help='Bypasses the confirmation prompt.')
kmarshall9249e012016-08-23 12:02:16 -07003419 parser.add_option(
3420 '-d', '--dry-run', action='store_true',
3421 help='Skip the branch tagging and removal steps.')
3422 parser.add_option(
3423 '-t', '--notags', action='store_true',
3424 help='Do not tag archived branches. '
3425 'Note: local commit history may be lost.')
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003426 parser.add_option(
3427 '-p',
3428 '--pattern',
3429 default='git-cl-archived-{issue}-{branch}',
3430 help='Format string for archive tags. '
3431 'E.g. \'archived-{issue}-{branch}\'.')
kmarshall3bff56b2016-06-06 18:31:47 -07003432
kmarshall3bff56b2016-06-06 18:31:47 -07003433 options, args = parser.parse_args(args)
3434 if args:
3435 parser.error('Unsupported args: %s' % ' '.join(args))
kmarshall3bff56b2016-06-06 18:31:47 -07003436
3437 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
3438 if not branches:
3439 return 0
3440
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003441 tags = RunGit(['for-each-ref', '--format=%(refname)',
3442 'refs/tags']).splitlines() or []
3443 tags = [t.split('/')[-1] for t in tags]
3444
vapiera7fbd5a2016-06-16 09:17:49 -07003445 print('Finding all branches associated with closed issues...')
Edward Lemur934836a2019-09-09 20:16:54 +00003446 changes = [Changelist(branchref=b)
3447 for b in branches.splitlines()]
kmarshall3bff56b2016-06-06 18:31:47 -07003448 alignment = max(5, max(len(c.GetBranch()) for c in changes))
3449 statuses = get_cl_statuses(changes,
3450 fine_grained=True,
3451 max_processes=options.maxjobs)
3452 proposal = [(cl.GetBranch(),
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003453 GetArchiveTagForBranch(cl.GetIssue(), cl.GetBranch(), tags,
3454 options.pattern))
kmarshall3bff56b2016-06-06 18:31:47 -07003455 for cl, status in statuses
Andrii Shyshkalov51bdf8c2018-10-18 01:07:58 +00003456 if status in ('closed', 'rietveld-not-supported')]
kmarshall3bff56b2016-06-06 18:31:47 -07003457 proposal.sort()
3458
3459 if not proposal:
vapiera7fbd5a2016-06-16 09:17:49 -07003460 print('No branches with closed codereview issues found.')
kmarshall3bff56b2016-06-06 18:31:47 -07003461 return 0
3462
Edward Lemur85153282020-02-14 22:06:29 +00003463 current_branch = scm.GIT.GetBranch(settings.GetRoot())
kmarshall3bff56b2016-06-06 18:31:47 -07003464
vapiera7fbd5a2016-06-16 09:17:49 -07003465 print('\nBranches with closed issues that will be archived:\n')
kmarshall9249e012016-08-23 12:02:16 -07003466 if options.notags:
3467 for next_item in proposal:
3468 print(' ' + next_item[0])
3469 else:
3470 print('%*s | %s' % (alignment, 'Branch name', 'Archival tag name'))
3471 for next_item in proposal:
3472 print('%*s %s' % (alignment, next_item[0], next_item[1]))
kmarshall3bff56b2016-06-06 18:31:47 -07003473
kmarshall9249e012016-08-23 12:02:16 -07003474 # Quit now on precondition failure or if instructed by the user, either
3475 # via an interactive prompt or by command line flags.
3476 if options.dry_run:
3477 print('\nNo changes were made (dry run).\n')
3478 return 0
3479 elif any(branch == current_branch for branch, _ in proposal):
kmarshall3bff56b2016-06-06 18:31:47 -07003480 print('You are currently on a branch \'%s\' which is associated with a '
3481 'closed codereview issue, so archive cannot proceed. Please '
3482 'checkout another branch and run this command again.' %
3483 current_branch)
3484 return 1
kmarshall9249e012016-08-23 12:02:16 -07003485 elif not options.force:
Edward Lesmesae3586b2020-03-23 21:21:14 +00003486 answer = gclient_utils.AskForData('\nProceed with deletion (Y/n)? ').lower()
sergiyb4a5ecbe2016-06-20 09:46:00 -07003487 if answer not in ('y', ''):
vapiera7fbd5a2016-06-16 09:17:49 -07003488 print('Aborted.')
kmarshall3bff56b2016-06-06 18:31:47 -07003489 return 1
3490
3491 for branch, tagname in proposal:
kmarshall9249e012016-08-23 12:02:16 -07003492 if not options.notags:
3493 RunGit(['tag', tagname, branch])
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003494
3495 if RunGitWithCode(['branch', '-D', branch])[0] != 0:
3496 # Clean up the tag if we failed to delete the branch.
3497 RunGit(['tag', '-d', tagname])
kmarshall9249e012016-08-23 12:02:16 -07003498
vapiera7fbd5a2016-06-16 09:17:49 -07003499 print('\nJob\'s done!')
kmarshall3bff56b2016-06-06 18:31:47 -07003500
3501 return 0
3502
3503
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003504@metrics.collector.collect_metrics('git cl status')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003505def CMDstatus(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003506 """Show status of changelists.
3507
3508 Colors are used to tell the state of the CL unless --fast is used:
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003509 - Blue waiting for review
Aaron Gable9ab38c62017-04-06 14:36:33 -07003510 - Yellow waiting for you to reply to review, or not yet sent
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003511 - Green LGTM'ed
Aaron Gable9ab38c62017-04-06 14:36:33 -07003512 - Red 'not LGTM'ed
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00003513 - Magenta in the CQ
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003514 - Cyan was committed, branch can be deleted
Aaron Gable9ab38c62017-04-06 14:36:33 -07003515 - White error, or unknown status
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003516
3517 Also see 'git cl comments'.
3518 """
Alan Cuttera3be9a52019-03-04 18:50:33 +00003519 parser.add_option(
3520 '--no-branch-color',
3521 action='store_true',
3522 help='Disable colorized branch names')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003523 parser.add_option('--field',
phajdan.jr289d03e2016-08-16 08:21:06 -07003524 help='print only specific field (desc|id|patch|status|url)')
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003525 parser.add_option('-f', '--fast', action='store_true',
3526 help='Do not retrieve review status')
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003527 parser.add_option(
3528 '-j', '--maxjobs', action='store', type=int,
3529 help='The maximum number of jobs to use when retrieving review status')
Edward Lemur52969c92020-02-06 18:15:28 +00003530 parser.add_option(
3531 '-i', '--issue', type=int,
3532 help='Operate on this issue instead of the current branch\'s implicit '
3533 'issue. Requires --field to be set.')
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003534 parser.add_option('-d',
3535 '--date-order',
3536 action='store_true',
3537 help='Order branches by committer date.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003538 options, args = parser.parse_args(args)
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003539 if args:
3540 parser.error('Unsupported args: %s' % args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003541
iannuccie53c9352016-08-17 14:40:40 -07003542 if options.issue is not None and not options.field:
Edward Lemur6c6827c2020-02-06 21:15:18 +00003543 parser.error('--field must be given when --issue is set.')
iannucci3c972b92016-08-17 13:24:10 -07003544
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003545 if options.field:
Edward Lemur934836a2019-09-09 20:16:54 +00003546 cl = Changelist(issue=options.issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003547 if options.field.startswith('desc'):
Edward Lemur6c6827c2020-02-06 21:15:18 +00003548 if cl.GetIssue():
3549 print(cl.FetchDescription())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003550 elif options.field == 'id':
3551 issueid = cl.GetIssue()
3552 if issueid:
vapiera7fbd5a2016-06-16 09:17:49 -07003553 print(issueid)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003554 elif options.field == 'patch':
Aaron Gablee8856ee2017-12-07 12:41:46 -08003555 patchset = cl.GetMostRecentPatchset()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003556 if patchset:
vapiera7fbd5a2016-06-16 09:17:49 -07003557 print(patchset)
phajdan.jr289d03e2016-08-16 08:21:06 -07003558 elif options.field == 'status':
3559 print(cl.GetStatus())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003560 elif options.field == 'url':
3561 url = cl.GetIssueURL()
3562 if url:
vapiera7fbd5a2016-06-16 09:17:49 -07003563 print(url)
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00003564 return 0
3565
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003566 branches = RunGit([
3567 'for-each-ref', '--format=%(refname) %(committerdate:unix)', 'refs/heads'
3568 ])
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00003569 if not branches:
3570 print('No local branch found.')
3571 return 0
3572
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003573 changes = [
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003574 Changelist(branchref=b, commit_date=ct)
3575 for b, ct in map(lambda line: line.split(' '), branches.splitlines())
3576 ]
vapiera7fbd5a2016-06-16 09:17:49 -07003577 print('Branches associated with reviews:')
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003578 output = get_cl_statuses(changes,
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003579 fine_grained=not options.fast,
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003580 max_processes=options.maxjobs)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003581
Edward Lemur85153282020-02-14 22:06:29 +00003582 current_branch = scm.GIT.GetBranch(settings.GetRoot())
Daniel McArdlea23bf592019-02-12 00:25:12 +00003583
3584 def FormatBranchName(branch, colorize=False):
3585 """Simulates 'git branch' behavior. Colorizes and prefixes branch name with
3586 an asterisk when it is the current branch."""
3587
3588 asterisk = ""
3589 color = Fore.RESET
3590 if branch == current_branch:
3591 asterisk = "* "
3592 color = Fore.GREEN
Edward Lemur85153282020-02-14 22:06:29 +00003593 branch_name = scm.GIT.ShortBranchName(branch)
Daniel McArdlea23bf592019-02-12 00:25:12 +00003594
3595 if colorize:
3596 return asterisk + color + branch_name + Fore.RESET
Daniel McArdle452a49f2019-02-14 17:28:31 +00003597 return asterisk + branch_name
3598
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003599 branch_statuses = {}
Daniel McArdlea23bf592019-02-12 00:25:12 +00003600
3601 alignment = max(5, max(len(FormatBranchName(c.GetBranch())) for c in changes))
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003602 if options.date_order:
3603 sorted_changes = sorted(changes,
3604 key=lambda c: c.GetCommitDate(),
3605 reverse=True)
3606 else:
3607 sorted_changes = sorted(changes, key=lambda c: c.GetBranch())
3608 for cl in sorted_changes:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003609 branch = cl.GetBranch()
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003610 while branch not in branch_statuses:
Edward Lemur79d4f992019-11-11 23:49:02 +00003611 c, status = next(output)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003612 branch_statuses[c.GetBranch()] = status
3613 status = branch_statuses.pop(branch)
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00003614 url = cl.GetIssueURL(short=True)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003615 if url and (not status or status == 'error'):
3616 # The issue probably doesn't exist anymore.
3617 url += ' (broken)'
3618
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003619 color = color_for_status(status)
Bruce Dawsonb73f8a92020-03-27 22:03:08 +00003620 # Turn off bold as well as colors.
3621 END = '\033[0m'
3622 reset = Fore.RESET + END
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00003623 if not setup_color.IS_TTY:
maruel@chromium.org885f6512013-07-27 02:17:26 +00003624 color = ''
3625 reset = ''
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003626 status_str = '(%s)' % status if status else ''
Daniel McArdle452a49f2019-02-14 17:28:31 +00003627
Alan Cuttera3be9a52019-03-04 18:50:33 +00003628 branch_display = FormatBranchName(branch)
3629 padding = ' ' * (alignment - len(branch_display))
3630 if not options.no_branch_color:
3631 branch_display = FormatBranchName(branch, colorize=True)
Daniel McArdle452a49f2019-02-14 17:28:31 +00003632
Alan Cuttera3be9a52019-03-04 18:50:33 +00003633 print(' %s : %s%s %s%s' % (padding + branch_display, color, url,
3634 status_str, reset))
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003635
vapiera7fbd5a2016-06-16 09:17:49 -07003636 print()
Daniel McArdlea23bf592019-02-12 00:25:12 +00003637 print('Current branch: %s' % current_branch)
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003638 for cl in changes:
Daniel McArdlea23bf592019-02-12 00:25:12 +00003639 if cl.GetBranch() == current_branch:
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003640 break
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003641 if not cl.GetIssue():
vapiera7fbd5a2016-06-16 09:17:49 -07003642 print('No issue assigned.')
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003643 return 0
vapiera7fbd5a2016-06-16 09:17:49 -07003644 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
maruel@chromium.org85616e02014-07-28 15:37:55 +00003645 if not options.fast:
vapiera7fbd5a2016-06-16 09:17:49 -07003646 print('Issue description:')
Edward Lemur6c6827c2020-02-06 21:15:18 +00003647 print(cl.FetchDescription(pretty=True))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003648 return 0
3649
3650
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003651def colorize_CMDstatus_doc():
3652 """To be called once in main() to add colors to git cl status help."""
3653 colors = [i for i in dir(Fore) if i[0].isupper()]
3654
3655 def colorize_line(line):
3656 for color in colors:
3657 if color in line.upper():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003658 # Extract whitespace first and the leading '-'.
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003659 indent = len(line) - len(line.lstrip(' ')) + 1
3660 return line[:indent] + getattr(Fore, color) + line[indent:] + Fore.RESET
3661 return line
3662
3663 lines = CMDstatus.__doc__.splitlines()
3664 CMDstatus.__doc__ = '\n'.join(colorize_line(l) for l in lines)
3665
3666
phajdan.jre328cf92016-08-22 04:12:17 -07003667def write_json(path, contents):
Stefan Zager1306bd02017-06-22 19:26:46 -07003668 if path == '-':
3669 json.dump(contents, sys.stdout)
3670 else:
3671 with open(path, 'w') as f:
3672 json.dump(contents, f)
phajdan.jre328cf92016-08-22 04:12:17 -07003673
3674
maruel@chromium.org0633fb42013-08-16 20:06:14 +00003675@subcommand.usage('[issue_number]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003676@metrics.collector.collect_metrics('git cl issue')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003677def CMDissue(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003678 """Sets or displays the current code review issue number.
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003679
3680 Pass issue number 0 to clear the current issue.
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003681 """
dnj@chromium.org406c4402015-03-03 17:22:28 +00003682 parser.add_option('-r', '--reverse', action='store_true',
3683 help='Lookup the branch(es) for the specified issues. If '
3684 'no issues are specified, all branches with mapped '
3685 'issues will be listed.')
Stefan Zager1306bd02017-06-22 19:26:46 -07003686 parser.add_option('--json',
3687 help='Path to JSON output file, or "-" for stdout.')
dnj@chromium.org406c4402015-03-03 17:22:28 +00003688 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003689
dnj@chromium.org406c4402015-03-03 17:22:28 +00003690 if options.reverse:
3691 branches = RunGit(['for-each-ref', 'refs/heads',
Aaron Gablead64abd2017-12-04 09:49:13 -08003692 '--format=%(refname)']).splitlines()
dnj@chromium.org406c4402015-03-03 17:22:28 +00003693 # Reverse issue lookup.
3694 issue_branch_map = {}
Daniel Bratellb56a43a2018-09-06 15:49:03 +00003695
3696 git_config = {}
3697 for config in RunGit(['config', '--get-regexp',
3698 r'branch\..*issue']).splitlines():
3699 name, _space, val = config.partition(' ')
3700 git_config[name] = val
3701
dnj@chromium.org406c4402015-03-03 17:22:28 +00003702 for branch in branches:
Edward Lesmes50da7702020-03-30 19:23:43 +00003703 issue = git_config.get(
3704 'branch.%s.%s' % (scm.GIT.ShortBranchName(branch), ISSUE_CONFIG_KEY))
Edward Lemur52969c92020-02-06 18:15:28 +00003705 if issue:
3706 issue_branch_map.setdefault(int(issue), []).append(branch)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003707 if not args:
Carlos Caballero81923d62020-07-06 18:22:27 +00003708 args = sorted(issue_branch_map.keys())
phajdan.jre328cf92016-08-22 04:12:17 -07003709 result = {}
dnj@chromium.org406c4402015-03-03 17:22:28 +00003710 for issue in args:
Lei Zhang5a368d42019-03-25 23:18:19 +00003711 try:
3712 issue_num = int(issue)
3713 except ValueError:
3714 print('ERROR cannot parse issue number: %s' % issue, file=sys.stderr)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003715 continue
Lei Zhang5a368d42019-03-25 23:18:19 +00003716 result[issue_num] = issue_branch_map.get(issue_num)
vapiera7fbd5a2016-06-16 09:17:49 -07003717 print('Branch for issue number %s: %s' % (
Lei Zhang5a368d42019-03-25 23:18:19 +00003718 issue, ', '.join(issue_branch_map.get(issue_num) or ('None',))))
phajdan.jre328cf92016-08-22 04:12:17 -07003719 if options.json:
3720 write_json(options.json, result)
Aaron Gable78753da2017-06-15 10:35:49 -07003721 return 0
3722
3723 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00003724 issue = ParseIssueNumberArgument(args[0])
Aaron Gable78753da2017-06-15 10:35:49 -07003725 if not issue.valid:
3726 DieWithError('Pass a url or number to set the issue, 0 to unset it, '
3727 'or no argument to list it.\n'
3728 'Maybe you want to run git cl status?')
Edward Lemurf38bc172019-09-03 21:02:13 +00003729 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07003730 cl.SetIssue(issue.issue)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003731 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00003732 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07003733 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
3734 if options.json:
3735 write_json(options.json, {
3736 'issue': cl.GetIssue(),
3737 'issue_url': cl.GetIssueURL(),
3738 })
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003739 return 0
3740
3741
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003742@metrics.collector.collect_metrics('git cl comments')
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003743def CMDcomments(parser, args):
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003744 """Shows or posts review comments for any changelist."""
3745 parser.add_option('-a', '--add-comment', dest='comment',
3746 help='comment to add to an issue')
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00003747 parser.add_option('-p', '--publish', action='store_true',
3748 help='marks CL as ready and sends comment to reviewers')
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01003749 parser.add_option('-i', '--issue', dest='issue',
Edward Lemurf38bc172019-09-03 21:02:13 +00003750 help='review issue id (defaults to current issue).')
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003751 parser.add_option('-m', '--machine-readable', dest='readable',
3752 action='store_false', default=True,
3753 help='output comments in a format compatible with '
3754 'editor parsing')
smut@google.comc85ac942015-09-15 16:34:43 +00003755 parser.add_option('-j', '--json-file',
Stefan Zager1306bd02017-06-22 19:26:46 -07003756 help='File to write JSON summary to, or "-" for stdout')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003757 options, args = parser.parse_args(args)
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003758
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003759 issue = None
3760 if options.issue:
3761 try:
3762 issue = int(options.issue)
3763 except ValueError:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00003764 DieWithError('A review issue ID is expected to be a number.')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003765
Edward Lemur934836a2019-09-09 20:16:54 +00003766 cl = Changelist(issue=issue)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003767
3768 if options.comment:
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00003769 cl.AddComment(options.comment, options.publish)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003770 return 0
3771
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003772 summary = sorted(cl.GetCommentsSummary(readable=options.readable),
3773 key=lambda c: c.date)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003774 for comment in summary:
3775 if comment.disapproval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003776 color = Fore.RED
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003777 elif comment.approval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003778 color = Fore.GREEN
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003779 elif comment.sender == cl.GetIssueOwner():
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003780 color = Fore.MAGENTA
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003781 elif comment.autogenerated:
3782 color = Fore.CYAN
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003783 else:
3784 color = Fore.BLUE
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003785 print('\n%s%s %s%s\n%s' % (
3786 color,
3787 comment.date.strftime('%Y-%m-%d %H:%M:%S UTC'),
3788 comment.sender,
3789 Fore.RESET,
3790 '\n'.join(' ' + l for l in comment.message.strip().splitlines())))
3791
smut@google.comc85ac942015-09-15 16:34:43 +00003792 if options.json_file:
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003793 def pre_serialize(c):
Edward Lemur79d4f992019-11-11 23:49:02 +00003794 dct = c._asdict().copy()
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003795 dct['date'] = dct['date'].strftime('%Y-%m-%d %H:%M:%S.%f')
3796 return dct
Edward Lemur79d4f992019-11-11 23:49:02 +00003797 write_json(options.json_file, [pre_serialize(x) for x in summary])
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003798 return 0
3799
3800
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003801@subcommand.usage('[codereview url or issue id]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003802@metrics.collector.collect_metrics('git cl description')
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00003803def CMDdescription(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003804 """Brings up the editor for the current CL's description."""
smut@google.com34fb6b12015-07-13 20:03:26 +00003805 parser.add_option('-d', '--display', action='store_true',
3806 help='Display the description instead of opening an editor')
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003807 parser.add_option('-n', '--new-description',
dnjba1b0f32016-09-02 12:37:42 -07003808 help='New description to set for this issue (- for stdin, '
3809 '+ to load from local commit HEAD)')
dsansomee2d6fd92016-09-08 00:10:47 -07003810 parser.add_option('-f', '--force', action='store_true',
3811 help='Delete any unpublished Gerrit edits for this issue '
3812 'without prompting')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003813
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003814 options, args = parser.parse_args(args)
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003815
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003816 target_issue_arg = None
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003817 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00003818 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003819 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00003820 parser.error('Invalid issue ID or URL.')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003821
Edward Lemur934836a2019-09-09 20:16:54 +00003822 kwargs = {}
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003823 if target_issue_arg:
3824 kwargs['issue'] = target_issue_arg.issue
3825 kwargs['codereview_host'] = target_issue_arg.hostname
martiniss6eda05f2016-06-30 10:18:35 -07003826
3827 cl = Changelist(**kwargs)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00003828 if not cl.GetIssue():
3829 DieWithError('This branch has no associated changelist.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02003830
Edward Lemur678a6842019-10-03 22:25:05 +00003831 if args and not args[0].isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00003832 logging.info('canonical issue/change URL: %s\n', cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02003833
Edward Lemur6c6827c2020-02-06 21:15:18 +00003834 description = ChangeDescription(cl.FetchDescription())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003835
smut@google.com34fb6b12015-07-13 20:03:26 +00003836 if options.display:
vapiera7fbd5a2016-06-16 09:17:49 -07003837 print(description.description)
smut@google.com34fb6b12015-07-13 20:03:26 +00003838 return 0
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003839
3840 if options.new_description:
3841 text = options.new_description
3842 if text == '-':
3843 text = '\n'.join(l.rstrip() for l in sys.stdin)
dnjba1b0f32016-09-02 12:37:42 -07003844 elif text == '+':
3845 base_branch = cl.GetCommonAncestorWithUpstream()
Edward Lemura12175c2020-03-09 16:58:26 +00003846 text = _create_description_from_log([base_branch])
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003847
3848 description.set_description(text)
3849 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00003850 description.prompt()
Edward Lemur6c6827c2020-02-06 21:15:18 +00003851 if cl.FetchDescription().strip() != description.description:
dsansomee2d6fd92016-09-08 00:10:47 -07003852 cl.UpdateDescription(description.description, force=options.force)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00003853 return 0
3854
3855
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003856@metrics.collector.collect_metrics('git cl lint')
thestig@chromium.org44202a22014-03-11 19:22:18 +00003857def CMDlint(parser, args):
3858 """Runs cpplint on the current changelist."""
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00003859 parser.add_option('--filter', action='append', metavar='-x,+y',
3860 help='Comma-separated list of cpplint\'s category-filters')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003861 options, args = parser.parse_args(args)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003862
3863 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003864 # pylint: disable=protected-access
thestig@chromium.org44202a22014-03-11 19:22:18 +00003865 try:
3866 import cpplint
3867 import cpplint_chromium
3868 except ImportError:
vapiera7fbd5a2016-06-16 09:17:49 -07003869 print('Your depot_tools is missing cpplint.py and/or cpplint_chromium.py.')
thestig@chromium.org44202a22014-03-11 19:22:18 +00003870 return 1
3871
3872 # Change the current working directory before calling lint so that it
3873 # shows the correct base.
3874 previous_cwd = os.getcwd()
3875 os.chdir(settings.GetRoot())
3876 try:
Edward Lemur934836a2019-09-09 20:16:54 +00003877 cl = Changelist()
Edward Lemur2c62b332020-03-12 22:12:33 +00003878 files = cl.GetAffectedFiles(cl.GetCommonAncestorWithUpstream())
thestig@chromium.org5839eb52014-05-30 16:20:51 +00003879 if not files:
vapiera7fbd5a2016-06-16 09:17:49 -07003880 print('Cannot lint an empty CL')
thestig@chromium.org5839eb52014-05-30 16:20:51 +00003881 return 1
thestig@chromium.org44202a22014-03-11 19:22:18 +00003882
Lei Zhangb8c62cf2020-07-15 20:09:37 +00003883 # Process cpplint arguments, if any.
3884 filters = presubmit_canned_checks.GetCppLintFilters(options.filter)
3885 command = ['--filter=' + ','.join(filters)] + args + files
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00003886 filenames = cpplint.ParseArguments(command)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003887
Lei Zhang379d1ad2020-07-15 19:40:06 +00003888 include_regex = re.compile(settings.GetLintRegex())
3889 ignore_regex = re.compile(settings.GetLintIgnoreRegex())
thestig@chromium.org44202a22014-03-11 19:22:18 +00003890 extra_check_functions = [cpplint_chromium.CheckPointerDeclarationWhitespace]
3891 for filename in filenames:
Lei Zhang379d1ad2020-07-15 19:40:06 +00003892 if not include_regex.match(filename):
vapiera7fbd5a2016-06-16 09:17:49 -07003893 print('Skipping file %s' % filename)
Lei Zhang379d1ad2020-07-15 19:40:06 +00003894 continue
3895
3896 if ignore_regex.match(filename):
3897 print('Ignoring file %s' % filename)
3898 continue
3899
3900 cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level,
3901 extra_check_functions)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003902 finally:
3903 os.chdir(previous_cwd)
vapiera7fbd5a2016-06-16 09:17:49 -07003904 print('Total errors found: %d\n' % cpplint._cpplint_state.error_count)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003905 if cpplint._cpplint_state.error_count != 0:
3906 return 1
3907 return 0
3908
3909
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003910@metrics.collector.collect_metrics('git cl presubmit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003911def CMDpresubmit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003912 """Runs presubmit tests on the current changelist."""
ilevy@chromium.org375a9022013-01-07 01:12:05 +00003913 parser.add_option('-u', '--upload', action='store_true',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08003914 help='Run upload hook instead of the push hook')
ilevy@chromium.org375a9022013-01-07 01:12:05 +00003915 parser.add_option('-f', '--force', action='store_true',
sbc@chromium.org495ad152012-09-04 23:07:42 +00003916 help='Run checks even if tree is dirty')
Aaron Gable8076c282017-11-29 14:39:41 -08003917 parser.add_option('--all', action='store_true',
3918 help='Run checks against all files, not just modified ones')
Edward Lesmes8e282792018-04-03 18:50:29 -04003919 parser.add_option('--parallel', action='store_true',
3920 help='Run all tests specified by input_api.RunTests in all '
3921 'PRESUBMIT files in parallel.')
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003922 parser.add_option('--resultdb', action='store_true',
3923 help='Run presubmit checks in the ResultSink environment '
3924 'and send results to the ResultDB database.')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003925 parser.add_option('--realm', help='LUCI realm if reporting to ResultDB')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003926 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003927
sbc@chromium.org71437c02015-04-09 19:29:40 +00003928 if not options.force and git_common.is_dirty_git_tree('presubmit'):
vapiera7fbd5a2016-06-16 09:17:49 -07003929 print('use --force to check even if tree is dirty.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003930 return 1
3931
Edward Lemur934836a2019-09-09 20:16:54 +00003932 cl = Changelist()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003933 if args:
3934 base_branch = args[0]
3935 else:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00003936 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00003937 base_branch = cl.GetCommonAncestorWithUpstream()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003938
Gregory Nisbet29d5cf82020-02-27 08:16:58 +00003939 if cl.GetIssue():
3940 description = cl.FetchDescription()
Aaron Gable8076c282017-11-29 14:39:41 -08003941 else:
Edward Lemura12175c2020-03-09 16:58:26 +00003942 description = _create_description_from_log([base_branch])
Aaron Gable8076c282017-11-29 14:39:41 -08003943
ilevy@chromium.org051ad0e2013-03-04 21:57:34 +00003944 cl.RunHook(
3945 committing=not options.upload,
3946 may_prompt=False,
3947 verbose=options.verbose,
Edward Lemur227d5102020-02-25 23:45:35 +00003948 parallel=options.parallel,
3949 upstream=base_branch,
3950 description=description,
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003951 all_files=options.all,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003952 resultdb=options.resultdb,
3953 realm=options.realm)
dpranke@chromium.org0a2bb372011-03-25 01:16:22 +00003954 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003955
3956
tandrii@chromium.org65874e12016-03-04 12:03:02 +00003957def GenerateGerritChangeId(message):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003958 """Returns the Change ID footer value (Ixxxxxx...xxx).
tandrii@chromium.org65874e12016-03-04 12:03:02 +00003959
3960 Works the same way as
3961 https://gerrit-review.googlesource.com/tools/hooks/commit-msg
3962 but can be called on demand on all platforms.
3963
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003964 The basic idea is to generate git hash of a state of the tree, original
3965 commit message, author/committer info and timestamps.
tandrii@chromium.org65874e12016-03-04 12:03:02 +00003966 """
3967 lines = []
3968 tree_hash = RunGitSilent(['write-tree'])
3969 lines.append('tree %s' % tree_hash.strip())
3970 code, parent = RunGitWithCode(['rev-parse', 'HEAD~0'], suppress_stderr=False)
3971 if code == 0:
3972 lines.append('parent %s' % parent.strip())
3973 author = RunGitSilent(['var', 'GIT_AUTHOR_IDENT'])
3974 lines.append('author %s' % author.strip())
3975 committer = RunGitSilent(['var', 'GIT_COMMITTER_IDENT'])
3976 lines.append('committer %s' % committer.strip())
3977 lines.append('')
3978 # Note: Gerrit's commit-hook actually cleans message of some lines and
3979 # whitespace. This code is not doing this, but it clearly won't decrease
3980 # entropy.
3981 lines.append(message)
3982 change_hash = RunCommand(['git', 'hash-object', '-t', 'commit', '--stdin'],
Raul Tambreb946b232019-03-26 14:48:46 +00003983 stdin=('\n'.join(lines)).encode())
tandrii@chromium.org65874e12016-03-04 12:03:02 +00003984 return 'I%s' % change_hash.strip()
3985
3986
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01003987def GetTargetRef(remote, remote_branch, target_branch):
wittman@chromium.org455dc922015-01-26 20:15:50 +00003988 """Computes the remote branch ref to use for the CL.
3989
3990 Args:
3991 remote (str): The git remote for the CL.
3992 remote_branch (str): The git remote branch for the CL.
3993 target_branch (str): The target branch specified by the user.
wittman@chromium.org455dc922015-01-26 20:15:50 +00003994 """
3995 if not (remote and remote_branch):
3996 return None
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00003997
wittman@chromium.org455dc922015-01-26 20:15:50 +00003998 if target_branch:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003999 # Canonicalize branch references to the equivalent local full symbolic
wittman@chromium.org455dc922015-01-26 20:15:50 +00004000 # refs, which are then translated into the remote full symbolic refs
4001 # below.
4002 if '/' not in target_branch:
4003 remote_branch = 'refs/remotes/%s/%s' % (remote, target_branch)
4004 else:
4005 prefix_replacements = (
4006 ('^((refs/)?remotes/)?branch-heads/', 'refs/remotes/branch-heads/'),
4007 ('^((refs/)?remotes/)?%s/' % remote, 'refs/remotes/%s/' % remote),
4008 ('^(refs/)?heads/', 'refs/remotes/%s/' % remote),
4009 )
4010 match = None
4011 for regex, replacement in prefix_replacements:
4012 match = re.search(regex, target_branch)
4013 if match:
4014 remote_branch = target_branch.replace(match.group(0), replacement)
4015 break
4016 if not match:
4017 # This is a branch path but not one we recognize; use as-is.
4018 remote_branch = target_branch
rmistry@google.comc68112d2015-03-03 12:48:06 +00004019 elif remote_branch in REFS_THAT_ALIAS_TO_OTHER_REFS:
4020 # Handle the refs that need to land in different refs.
4021 remote_branch = REFS_THAT_ALIAS_TO_OTHER_REFS[remote_branch]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004022
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004023 # Migration to new default branch, only if available on remote.
4024 allow_push_on_master = bool(os.environ.get("ALLOW_PUSH_TO_MASTER", None))
4025 if remote_branch == DEFAULT_OLD_BRANCH and not allow_push_on_master:
4026 if RunGit(['show-branch', DEFAULT_NEW_BRANCH], error_ok=True,
4027 stderr=subprocess2.PIPE):
4028 # TODO(crbug.com/ID): Print location to local git migration script.
4029 print("WARNING: Using new branch name %s instead of %s" % (
4030 DEFAULT_NEW_BRANCH, DEFAULT_OLD_BRANCH))
4031 remote_branch = DEFAULT_NEW_BRANCH
4032
wittman@chromium.org455dc922015-01-26 20:15:50 +00004033 # Create the true path to the remote branch.
4034 # Does the following translation:
4035 # * refs/remotes/origin/refs/diff/test -> refs/diff/test
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004036 # * refs/remotes/origin/main -> refs/heads/main
wittman@chromium.org455dc922015-01-26 20:15:50 +00004037 # * refs/remotes/branch-heads/test -> refs/branch-heads/test
4038 if remote_branch.startswith('refs/remotes/%s/refs/' % remote):
4039 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, '')
4040 elif remote_branch.startswith('refs/remotes/%s/' % remote):
4041 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote,
4042 'refs/heads/')
4043 elif remote_branch.startswith('refs/remotes/branch-heads'):
4044 remote_branch = remote_branch.replace('refs/remotes/', 'refs/')
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01004045
wittman@chromium.org455dc922015-01-26 20:15:50 +00004046 return remote_branch
4047
4048
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004049def cleanup_list(l):
4050 """Fixes a list so that comma separated items are put as individual items.
4051
4052 So that "--reviewers joe@c,john@c --reviewers joa@c" results in
4053 options.reviewers == sorted(['joe@c', 'john@c', 'joa@c']).
4054 """
4055 items = sum((i.split(',') for i in l), [])
4056 stripped_items = (i.strip() for i in items)
4057 return sorted(filter(None, stripped_items))
4058
4059
Aaron Gable4db38df2017-11-03 14:59:07 -07004060@subcommand.usage('[flags]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004061@metrics.collector.collect_metrics('git cl upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004062def CMDupload(parser, args):
rmistry@google.com78948ed2015-07-08 23:09:57 +00004063 """Uploads the current changelist to codereview.
4064
4065 Can skip dependency patchset uploads for a branch by running:
4066 git config branch.branch_name.skip-deps-uploads True
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004067 To unset, run:
rmistry@google.com78948ed2015-07-08 23:09:57 +00004068 git config --unset branch.branch_name.skip-deps-uploads
4069 Can also set the above globally by using the --global flag.
Dominic Battre7d1c4842017-10-27 09:17:28 +02004070
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004071 If the name of the checked out branch starts with "bug-" or "fix-" followed
4072 by a bug number, this bug number is automatically populated in the CL
Dominic Battre7d1c4842017-10-27 09:17:28 +02004073 description.
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004074
4075 If subject contains text in square brackets or has "<text>: " prefix, such
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004076 text(s) is treated as Gerrit hashtags. For example, CLs with subjects:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004077 [git-cl] add support for hashtags
4078 Foo bar: implement foo
4079 will be hashtagged with "git-cl" and "foo-bar" respectively.
rmistry@google.com78948ed2015-07-08 23:09:57 +00004080 """
ukai@chromium.orge8077812012-02-03 03:41:46 +00004081 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4082 help='bypass upload presubmit hook')
brettw@chromium.orgb65c43c2013-06-10 22:04:49 +00004083 parser.add_option('--bypass-watchlists', action='store_true',
4084 dest='bypass_watchlists',
4085 help='bypass watchlists auto CC-ing reviewers')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004086 parser.add_option('-f', '--force', action='store_true', dest='force',
ukai@chromium.orge8077812012-02-03 03:41:46 +00004087 help="force yes to questions (don't prompt)")
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004088 parser.add_option('--message', '-m', dest='message',
4089 help='message for patchset')
tandriif9aefb72016-07-01 09:06:51 -07004090 parser.add_option('-b', '--bug',
4091 help='pre-populate the bug number(s) for this issue. '
4092 'If several, separate with commas')
tandriib80458a2016-06-23 12:20:07 -07004093 parser.add_option('--message-file', dest='message_file',
4094 help='file which contains message for patchset')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004095 parser.add_option('--title', '-t', dest='title',
4096 help='title for patchset')
Mario Bianuccicebfb4e2020-07-22 23:08:16 +00004097 parser.add_option('-T', '--skip-title', action='store_true',
4098 dest='skip_title',
4099 help='Use the most recent commit message as the title of '
4100 'the patchset')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004101 parser.add_option('-r', '--reviewers',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004102 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004103 help='reviewer email addresses')
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004104 parser.add_option('--tbrs',
4105 action='append', default=[],
4106 help='TBR email addresses')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004107 parser.add_option('--cc',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004108 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004109 help='cc email addresses')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004110 parser.add_option('--hashtag', dest='hashtags',
4111 action='append', default=[],
4112 help=('Gerrit hashtag for new CL; '
4113 'can be applied multiple times'))
adamk@chromium.org36f47302013-04-05 01:08:31 +00004114 parser.add_option('-s', '--send-mail', action='store_true',
Aaron Gable59f48512017-01-12 10:54:46 -08004115 help='send email to reviewer(s) and cc(s) immediately')
ukai@chromium.org8ef7ab22012-11-28 04:24:52 +00004116 parser.add_option('--target_branch',
pgervais@chromium.orgb9f27512014-08-08 15:52:33 +00004117 '--target-branch',
wittman@chromium.org455dc922015-01-26 20:15:50 +00004118 metavar='TARGET',
4119 help='Apply CL to remote ref TARGET. ' +
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004120 'Default: remote branch head, or main')
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004121 parser.add_option('--squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004122 help='Squash multiple commits into one')
Mike Frysingera989d552019-08-14 20:51:23 +00004123 parser.add_option('--no-squash', action='store_false', dest='squash',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004124 help='Don\'t squash multiple commits into one')
rmistry9eadede2016-09-19 11:22:43 -07004125 parser.add_option('--topic', default=None,
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004126 help='Topic to specify when uploading')
Robert Iannuccif2708bd2017-04-17 15:49:02 -07004127 parser.add_option('--tbr-owners', dest='add_owners_to', action='store_const',
4128 const='TBR', help='add a set of OWNERS to TBR')
4129 parser.add_option('--r-owners', dest='add_owners_to', action='store_const',
4130 const='R', help='add a set of OWNERS to R')
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004131 parser.add_option('-c', '--use-commit-queue', action='store_true',
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004132 default=False,
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004133 help='tell the CQ to commit this patchset; '
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004134 'implies --send-mail')
4135 parser.add_option('-d', '--cq-dry-run',
4136 action='store_true', default=False,
rmistry@google.comef966222015-04-07 11:15:01 +00004137 help='Send the patchset to do a CQ dry run right after '
4138 'upload.')
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00004139 parser.add_option('--preserve-tryjobs', action='store_true',
4140 help='instruct the CQ to let tryjobs running even after '
4141 'new patchsets are uploaded instead of canceling '
4142 'prior patchset\' tryjobs')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004143 parser.add_option('--dependencies', action='store_true',
4144 help='Uploads CLs of all the local branches that depend on '
4145 'the current branch')
Ravi Mistry31e7d562018-04-02 12:53:57 -04004146 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4147 help='Sends your change to the CQ after an approval. Only '
4148 'works on repos that have the Auto-Submit label '
4149 'enabled')
Edward Lesmes8e282792018-04-03 18:50:29 -04004150 parser.add_option('--parallel', action='store_true',
4151 help='Run all tests specified by input_api.RunTests in all '
4152 'PRESUBMIT files in parallel.')
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004153 parser.add_option('--no-autocc', action='store_true',
4154 help='Disables automatic addition of CC emails')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004155 parser.add_option('--private', action='store_true',
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004156 help='Set the review private. This implies --no-autocc.')
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004157 parser.add_option('-R', '--retry-failed', action='store_true',
4158 help='Retry failed tryjobs from old patchset immediately '
4159 'after uploading new patchset. Cannot be used with '
4160 '--use-commit-queue or --cq-dry-run.')
4161 parser.add_option('--buildbucket-host', default='cr-buildbucket.appspot.com',
4162 help='Host of buildbucket. The default host is %default.')
Dan Beamd8b04ca2019-10-10 21:23:26 +00004163 parser.add_option('--fixed', '-x',
4164 help='List of bugs that will be commented on and marked '
4165 'fixed (pre-populates "Fixed:" tag). Same format as '
4166 '-b option / "Bug:" tag. If fixing several issues, '
4167 'separate with commas.')
Josipe827b0f2020-01-30 00:07:20 +00004168 parser.add_option('--edit-description', action='store_true', default=False,
4169 help='Modify description before upload. Cannot be used '
4170 'with --force. It is a noop when --no-squash is set '
4171 'or a new commit is created.')
Ng Zhi Ancdaf0be2020-05-27 20:57:28 +00004172 parser.add_option('--git-completion-helper', action="store_true",
4173 help=optparse.SUPPRESS_HELP)
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00004174 parser.add_option('--resultdb', action='store_true',
4175 help='Run presubmit checks in the ResultSink environment '
4176 'and send results to the ResultDB database.')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004177 parser.add_option('--realm', help='LUCI realm if reporting to ResultDB')
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004178
rmistry@google.com2dd99862015-06-22 12:22:18 +00004179 orig_args = args
ukai@chromium.orge8077812012-02-03 03:41:46 +00004180 (options, args) = parser.parse_args(args)
4181
Ng Zhi Ancdaf0be2020-05-27 20:57:28 +00004182 if options.git_completion_helper:
Edward Lesmesb7db1832020-06-22 20:22:27 +00004183 print(' '.join(opt.get_opt_string() for opt in parser.option_list
4184 if opt.help != optparse.SUPPRESS_HELP))
4185 return
Ng Zhi Ancdaf0be2020-05-27 20:57:28 +00004186
sbc@chromium.org71437c02015-04-09 19:29:40 +00004187 if git_common.is_dirty_git_tree('upload'):
ukai@chromium.orge8077812012-02-03 03:41:46 +00004188 return 1
4189
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004190 options.reviewers = cleanup_list(options.reviewers)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004191 options.tbrs = cleanup_list(options.tbrs)
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004192 options.cc = cleanup_list(options.cc)
4193
Josipe827b0f2020-01-30 00:07:20 +00004194 if options.edit_description and options.force:
4195 parser.error('Only one of --force and --edit-description allowed')
4196
tandriib80458a2016-06-23 12:20:07 -07004197 if options.message_file:
4198 if options.message:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004199 parser.error('Only one of --message and --message-file allowed.')
tandriib80458a2016-06-23 12:20:07 -07004200 options.message = gclient_utils.FileRead(options.message_file)
4201 options.message_file = None
4202
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004203 if ([options.cq_dry_run,
4204 options.use_commit_queue,
4205 options.retry_failed].count(True) > 1):
4206 parser.error('Only one of --use-commit-queue, --cq-dry-run, or '
4207 '--retry-failed is allowed.')
tandrii4d0545a2016-07-06 03:56:49 -07004208
Mario Bianuccicebfb4e2020-07-22 23:08:16 +00004209 if options.skip_title and options.title:
4210 parser.error('Only one of --title and --skip-title allowed.')
4211
Aaron Gableedbc4132017-09-11 13:22:28 -07004212 if options.use_commit_queue:
4213 options.send_mail = True
4214
Edward Lesmes0dd54822020-03-26 18:24:25 +00004215 if options.squash is None:
4216 # Load default for user, repo, squash=true, in this order.
4217 options.squash = settings.GetSquashGerritUploads()
4218
Edward Lemur934836a2019-09-09 20:16:54 +00004219 cl = Changelist()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00004220 # Warm change details cache now to avoid RPCs later, reducing latency for
4221 # developers.
4222 if cl.GetIssue():
4223 cl._GetChangeDetail(
4224 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS'])
4225
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004226 if options.retry_failed and not cl.GetIssue():
4227 print('No previous patchsets, so --retry-failed has no effect.')
4228 options.retry_failed = False
Edward Lesmes7677e5c2020-02-19 20:39:03 +00004229
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004230 # cl.GetMostRecentPatchset uses cached information, and can return the last
4231 # patchset before upload. Calling it here makes it clear that it's the
4232 # last patchset before upload. Note that GetMostRecentPatchset will fail
4233 # if no CL has been uploaded yet.
4234 if options.retry_failed:
4235 patchset = cl.GetMostRecentPatchset()
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00004236
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004237 ret = cl.CMDUpload(options, args, orig_args)
4238
4239 if options.retry_failed:
4240 if ret != 0:
4241 print('Upload failed, so --retry-failed has no effect.')
4242 return ret
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00004243 builds, _ = _fetch_latest_builds(
Edward Lemur5b929a42019-10-21 17:57:39 +00004244 cl, options.buildbucket_host, latest_patchset=patchset)
Edward Lemur45768512020-03-02 19:03:14 +00004245 jobs = _filter_failed_for_retry(builds)
4246 if len(jobs) == 0:
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004247 print('No failed tryjobs, so --retry-failed has no effect.')
4248 return ret
Quinten Yearsley777660f2020-03-04 23:37:06 +00004249 _trigger_tryjobs(cl, jobs, options, patchset + 1)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004250
4251 return ret
ukai@chromium.orge8077812012-02-03 03:41:46 +00004252
4253
Francois Dorayd42c6812017-05-30 15:10:20 -04004254@subcommand.usage('--description=<description file>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004255@metrics.collector.collect_metrics('git cl split')
Francois Dorayd42c6812017-05-30 15:10:20 -04004256def CMDsplit(parser, args):
4257 """Splits a branch into smaller branches and uploads CLs.
4258
4259 Creates a branch and uploads a CL for each group of files modified in the
4260 current branch that share a common OWNERS file. In the CL description and
Edward Lemurac5c55f2020-02-29 00:17:16 +00004261 comment, the string '$directory', is replaced with the directory containing
4262 the shared OWNERS file.
Francois Dorayd42c6812017-05-30 15:10:20 -04004263 """
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004264 parser.add_option('-d', '--description', dest='description_file',
4265 help='A text file containing a CL description in which '
4266 '$directory will be replaced by each CL\'s directory.')
4267 parser.add_option('-c', '--comment', dest='comment_file',
4268 help='A text file containing a CL comment.')
4269 parser.add_option('-n', '--dry-run', dest='dry_run', action='store_true',
Chris Watkinsba28e462017-12-13 11:22:17 +11004270 default=False,
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004271 help='List the files and reviewers for each CL that would '
4272 'be created, but don\'t create branches or CLs.')
4273 parser.add_option('--cq-dry-run', action='store_true',
4274 help='If set, will do a cq dry run for each uploaded CL. '
4275 'Please be careful when doing this; more than ~10 CLs '
4276 'has the potential to overload our build '
4277 'infrastructure. Try to upload these not during high '
4278 'load times (usually 11-3 Mountain View time). Email '
4279 'infra-dev@chromium.org with any questions.')
Takuto Ikuta51eca592019-02-14 19:40:52 +00004280 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4281 default=True,
4282 help='Sends your change to the CQ after an approval. Only '
4283 'works on repos that have the Auto-Submit label '
4284 'enabled')
Francois Dorayd42c6812017-05-30 15:10:20 -04004285 options, _ = parser.parse_args(args)
4286
4287 if not options.description_file:
4288 parser.error('No --description flag specified.')
4289
4290 def WrappedCMDupload(args):
4291 return CMDupload(OptionParser(), args)
4292
Edward Lemur2c62b332020-03-12 22:12:33 +00004293 return split_cl.SplitCl(
4294 options.description_file, options.comment_file, Changelist,
4295 WrappedCMDupload, options.dry_run, options.cq_dry_run,
4296 options.enable_auto_submit, settings.GetRoot())
Francois Dorayd42c6812017-05-30 15:10:20 -04004297
4298
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004299@subcommand.usage('DEPRECATED')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004300@metrics.collector.collect_metrics('git cl commit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004301def CMDdcommit(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004302 """DEPRECATED: Used to commit the current changelist via git-svn."""
4303 message = ('git-cl no longer supports committing to SVN repositories via '
4304 'git-svn. You probably want to use `git cl land` instead.')
4305 print(message)
4306 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004307
4308
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004309@subcommand.usage('[upstream branch to apply against]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004310@metrics.collector.collect_metrics('git cl land')
pgervais@chromium.orgcee6dc42014-05-07 17:04:03 +00004311def CMDland(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004312 """Commits the current changelist via git.
4313
4314 In case of Gerrit, uses Gerrit REST api to "submit" the issue, which pushes
4315 upstream and closes the issue automatically and atomically.
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004316 """
4317 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4318 help='bypass upload presubmit hook')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004319 parser.add_option('-f', '--force', action='store_true', dest='force',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004320 help="force yes to questions (don't prompt)")
Edward Lesmes67b3faa2018-04-13 17:50:52 -04004321 parser.add_option('--parallel', action='store_true',
4322 help='Run all tests specified by input_api.RunTests in all '
4323 'PRESUBMIT files in parallel.')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004324 parser.add_option('--resultdb', action='store_true',
4325 help='Run presubmit checks in the ResultSink environment '
4326 'and send results to the ResultDB database.')
4327 parser.add_option('--realm', help='LUCI realm if reporting to ResultDB')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004328 (options, args) = parser.parse_args(args)
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004329
Edward Lemur934836a2019-09-09 20:16:54 +00004330 cl = Changelist()
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004331
Robert Iannucci2e73d432018-03-14 01:10:47 -07004332 if not cl.GetIssue():
4333 DieWithError('You must upload the change first to Gerrit.\n'
4334 ' If you would rather have `git cl land` upload '
4335 'automatically for you, see http://crbug.com/642759')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004336 return cl.CMDLand(options.force, options.bypass_hooks, options.verbose,
4337 options.parallel, options.resultdb, options.realm)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004338
4339
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004340@subcommand.usage('<patch url or issue id or issue url>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004341@metrics.collector.collect_metrics('git cl patch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004342def CMDpatch(parser, args):
marq@chromium.orge5e59002013-10-02 23:21:25 +00004343 """Patches in a code review."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004344 parser.add_option('-b', dest='newbranch',
4345 help='create a new branch off trunk for the patch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00004346 parser.add_option('-f', '--force', action='store_true',
Aaron Gable62619a32017-06-16 08:22:09 -07004347 help='overwrite state on the current or chosen branch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004348 parser.add_option('-n', '--no-commit', action='store_true', dest='nocommit',
Edward Lemurf38bc172019-09-03 21:02:13 +00004349 help='don\'t commit after patch applies.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004350
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004351 group = optparse.OptionGroup(
4352 parser,
4353 'Options for continuing work on the current issue uploaded from a '
4354 'different clone (e.g. different machine). Must be used independently '
4355 'from the other options. No issue number should be specified, and the '
4356 'branch must have an issue number associated with it')
4357 group.add_option('--reapply', action='store_true', dest='reapply',
4358 help='Reset the branch and reapply the issue.\n'
4359 'CAUTION: This will undo any local changes in this '
4360 'branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004361
4362 group.add_option('--pull', action='store_true', dest='pull',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004363 help='Performs a pull before reapplying.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004364 parser.add_option_group(group)
4365
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004366 (options, args) = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004367
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004368 if options.reapply:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004369 if options.newbranch:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004370 parser.error('--reapply works on the current branch only.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004371 if len(args) > 0:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004372 parser.error('--reapply implies no additional arguments.')
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004373
Edward Lemur934836a2019-09-09 20:16:54 +00004374 cl = Changelist()
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004375 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004376 parser.error('Current branch must have an associated issue.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004377
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004378 upstream = cl.GetUpstreamBranch()
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004379 if upstream is None:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004380 parser.error('No upstream branch specified. Cannot reset branch.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004381
4382 RunGit(['reset', '--hard', upstream])
4383 if options.pull:
4384 RunGit(['pull'])
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004385
Edward Lemur678a6842019-10-03 22:25:05 +00004386 target_issue_arg = ParseIssueNumberArgument(cl.GetIssue())
4387 return cl.CMDPatchWithParsedIssue(target_issue_arg, options.nocommit, False)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004388
4389 if len(args) != 1 or not args[0]:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004390 parser.error('Must specify issue number or URL.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004391
Edward Lemurf38bc172019-09-03 21:02:13 +00004392 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004393 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004394 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004395
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004396 # We don't want uncommitted changes mixed up with the patch.
4397 if git_common.is_dirty_git_tree('patch'):
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004398 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004399
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004400 if options.newbranch:
4401 if options.force:
4402 RunGit(['branch', '-D', options.newbranch],
4403 stderr=subprocess2.PIPE, error_ok=True)
Edward Lemur84101642020-02-21 21:40:34 +00004404 git_new_branch.create_new_branch(options.newbranch)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004405
Edward Lemur678a6842019-10-03 22:25:05 +00004406 cl = Changelist(
4407 codereview_host=target_issue_arg.hostname, issue=target_issue_arg.issue)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004408
Edward Lemur678a6842019-10-03 22:25:05 +00004409 if not args[0].isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00004410 print('canonical issue/change URL: %s\n' % cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004411
Edward Lemurf38bc172019-09-03 21:02:13 +00004412 return cl.CMDPatchWithParsedIssue(
4413 target_issue_arg, options.nocommit, options.force)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004414
4415
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004416def GetTreeStatus(url=None):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004417 """Fetches the tree status and returns either 'open', 'closed',
4418 'unknown' or 'unset'."""
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004419 url = url or settings.GetTreeStatusUrl(error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004420 if url:
Daniel McArdle8b4eeff2020-07-20 17:02:47 +00004421 status = str(urllib.request.urlopen(url).read().lower())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004422 if status.find('closed') != -1 or status == '0':
4423 return 'closed'
4424 elif status.find('open') != -1 or status == '1':
4425 return 'open'
4426 return 'unknown'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004427 return 'unset'
4428
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004429
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004430def GetTreeStatusReason():
4431 """Fetches the tree status from a json url and returns the message
4432 with the reason for the tree to be opened or closed."""
msb@chromium.orgbf1a7ba2011-02-01 16:21:46 +00004433 url = settings.GetTreeStatusUrl()
Daniel McArdle8b4eeff2020-07-20 17:02:47 +00004434 json_url = urllib.parse.urljoin(url, '/current?format=json')
Edward Lemur79d4f992019-11-11 23:49:02 +00004435 connection = urllib.request.urlopen(json_url)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004436 status = json.loads(connection.read())
4437 connection.close()
4438 return status['message']
4439
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004440
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004441@metrics.collector.collect_metrics('git cl tree')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004442def CMDtree(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004443 """Shows the status of the tree."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004444 _, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004445 status = GetTreeStatus()
4446 if 'unset' == status:
vapiera7fbd5a2016-06-16 09:17:49 -07004447 print('You must configure your tree status URL by running "git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004448 return 2
4449
vapiera7fbd5a2016-06-16 09:17:49 -07004450 print('The tree is %s' % status)
4451 print()
4452 print(GetTreeStatusReason())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004453 if status != 'open':
4454 return 1
4455 return 0
4456
4457
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004458@metrics.collector.collect_metrics('git cl try')
maruel@chromium.org15192402012-09-06 12:38:29 +00004459def CMDtry(parser, args):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004460 """Triggers tryjobs using either Buildbucket or CQ dry run."""
4461 group = optparse.OptionGroup(parser, 'Tryjob options')
maruel@chromium.org15192402012-09-06 12:38:29 +00004462 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004463 '-b', '--bot', action='append',
4464 help=('IMPORTANT: specify ONE builder per --bot flag. Use it multiple '
4465 'times to specify multiple builders. ex: '
4466 '"-b win_rel -b win_layout". See '
4467 'the try server waterfall for the builders name and the tests '
4468 'available.'))
maruel@chromium.org15192402012-09-06 12:38:29 +00004469 group.add_option(
borenet6c0efe62016-10-19 08:13:29 -07004470 '-B', '--bucket', default='',
4471 help=('Buildbucket bucket to send the try requests.'))
4472 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004473 '-r', '--revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004474 help='Revision to use for the tryjob; default: the revision will '
tandriif7b29d42016-10-07 08:45:41 -07004475 'be determined by the try recipe that builder runs, which usually '
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004476 'defaults to HEAD of origin/master or origin/main')
maruel@chromium.org15192402012-09-06 12:38:29 +00004477 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004478 '-c', '--clobber', action='store_true', default=False,
tandriif7b29d42016-10-07 08:45:41 -07004479 help='Force a clobber before building; that is don\'t do an '
tandrii1838bad2016-10-06 00:10:52 -07004480 'incremental build')
maruel@chromium.org15192402012-09-06 12:38:29 +00004481 group.add_option(
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08004482 '--category', default='git_cl_try', help='Specify custom build category.')
4483 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004484 '--project',
4485 help='Override which project to use. Projects are defined '
tandriif7b29d42016-10-07 08:45:41 -07004486 'in recipe to determine to which repository or directory to '
4487 'apply the patch')
maruel@chromium.org15192402012-09-06 12:38:29 +00004488 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004489 '-p', '--property', dest='properties', action='append', default=[],
4490 help='Specify generic properties in the form -p key1=value1 -p '
tandriif7b29d42016-10-07 08:45:41 -07004491 'key2=value2 etc. The value will be treated as '
4492 'json if decodable, or as string otherwise. '
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004493 'NOTE: using this may make your tryjob not usable for CQ, '
4494 'which will then schedule another tryjob with default properties')
sheyang@chromium.orgdb375572015-08-17 19:22:23 +00004495 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004496 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4497 help='Host of buildbucket. The default host is %default.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004498 parser.add_option_group(group)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004499 parser.add_option(
4500 '-R', '--retry-failed', action='store_true', default=False,
4501 help='Retry failed jobs from the latest set of tryjobs. '
4502 'Not allowed with --bucket and --bot options.')
Edward Lemur52969c92020-02-06 18:15:28 +00004503 parser.add_option(
4504 '-i', '--issue', type=int,
4505 help='Operate on this issue instead of the current branch\'s implicit '
4506 'issue.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004507 options, args = parser.parse_args(args)
4508
machenbach@chromium.org45453142015-09-15 08:45:22 +00004509 # Make sure that all properties are prop=value pairs.
4510 bad_params = [x for x in options.properties if '=' not in x]
4511 if bad_params:
4512 parser.error('Got properties with missing "=": %s' % bad_params)
4513
maruel@chromium.org15192402012-09-06 12:38:29 +00004514 if args:
4515 parser.error('Unknown arguments: %s' % args)
4516
Edward Lemur934836a2019-09-09 20:16:54 +00004517 cl = Changelist(issue=options.issue)
maruel@chromium.org15192402012-09-06 12:38:29 +00004518 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004519 parser.error('Need to upload first.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004520
Edward Lemurf38bc172019-09-03 21:02:13 +00004521 # HACK: warm up Gerrit change detail cache to save on RPCs.
Edward Lemur125d60a2019-09-13 18:25:41 +00004522 cl._GetChangeDetail(['DETAILED_ACCOUNTS', 'ALL_REVISIONS'])
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01004523
tandriie113dfd2016-10-11 10:20:12 -07004524 error_message = cl.CannotTriggerTryJobReason()
4525 if error_message:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004526 parser.error('Can\'t trigger tryjobs: %s' % error_message)
jrobbins@chromium.org16f10f72014-06-24 22:14:36 +00004527
Edward Lemur45768512020-03-02 19:03:14 +00004528 if options.bot:
4529 if options.retry_failed:
4530 parser.error('--bot is not compatible with --retry-failed.')
4531 if not options.bucket:
4532 parser.error('A bucket (e.g. "chromium/try") is required.')
4533
4534 triggered = [b for b in options.bot if 'triggered' in b]
4535 if triggered:
4536 parser.error(
4537 'Cannot schedule builds on triggered bots: %s.\n'
4538 'This type of bot requires an initial job from a parent (usually a '
4539 'builder). Schedule a job on the parent instead.\n' % triggered)
4540
4541 if options.bucket.startswith('.master'):
4542 parser.error('Buildbot masters are not supported.')
4543
4544 project, bucket = _parse_bucket(options.bucket)
4545 if project is None or bucket is None:
4546 parser.error('Invalid bucket: %s.' % options.bucket)
4547 jobs = sorted((project, bucket, bot) for bot in options.bot)
4548 elif options.retry_failed:
Quinten Yearsley983111f2019-09-26 17:18:48 +00004549 print('Searching for failed tryjobs...')
Edward Lemur5b929a42019-10-21 17:57:39 +00004550 builds, patchset = _fetch_latest_builds(cl, options.buildbucket_host)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004551 if options.verbose:
4552 print('Got %d builds in patchset #%d' % (len(builds), patchset))
Edward Lemur45768512020-03-02 19:03:14 +00004553 jobs = _filter_failed_for_retry(builds)
4554 if not jobs:
Quinten Yearsley983111f2019-09-26 17:18:48 +00004555 print('There are no failed jobs in the latest set of jobs '
4556 '(patchset #%d), doing nothing.' % patchset)
4557 return 0
Edward Lemur45768512020-03-02 19:03:14 +00004558 num_builders = len(jobs)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004559 if num_builders > 10:
4560 confirm_or_exit('There are %d builders with failed builds.'
4561 % num_builders, action='continue')
4562 else:
qyearsley1fdfcb62016-10-24 13:22:03 -07004563 if options.verbose:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07004564 print('git cl try with no bots now defaults to CQ dry run.')
4565 print('Scheduling CQ dry run on: %s' % cl.GetIssueURL())
4566 return cl.SetCQState(_CQState.DRY_RUN)
stip@chromium.org43064fd2013-12-18 20:07:44 +00004567
ilevy@chromium.org36e420b2013-08-06 23:21:12 +00004568 patchset = cl.GetMostRecentPatchset()
Edward Lemur2c210a42019-09-16 23:58:35 +00004569 try:
Quinten Yearsley777660f2020-03-04 23:37:06 +00004570 _trigger_tryjobs(cl, jobs, options, patchset)
Edward Lemur2c210a42019-09-16 23:58:35 +00004571 except BuildbucketResponseException as ex:
4572 print('ERROR: %s' % ex)
4573 return 1
4574 return 0
maruel@chromium.org15192402012-09-06 12:38:29 +00004575
4576
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004577@metrics.collector.collect_metrics('git cl try-results')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004578def CMDtry_results(parser, args):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00004579 """Prints info about results for tryjobs associated with the current CL."""
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004580 group = optparse.OptionGroup(parser, 'Tryjob results options')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004581 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004582 '-p', '--patchset', type=int, help='patchset number if not current.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004583 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004584 '--print-master', action='store_true', help='print master name as well.')
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +00004585 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004586 '--color', action='store_true', default=setup_color.IS_TTY,
4587 help='force color output, useful when piping output.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004588 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004589 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4590 help='Host of buildbucket. The default host is %default.')
qyearsley53f48a12016-09-01 10:45:13 -07004591 group.add_option(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004592 '--json', help=('Path of JSON output file to write tryjob results to,'
Stefan Zager1306bd02017-06-22 19:26:46 -07004593 'or "-" for stdout.'))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004594 parser.add_option_group(group)
Edward Lemur52969c92020-02-06 18:15:28 +00004595 parser.add_option(
4596 '-i', '--issue', type=int,
4597 help='Operate on this issue instead of the current branch\'s implicit '
4598 'issue.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004599 options, args = parser.parse_args(args)
4600 if args:
4601 parser.error('Unrecognized args: %s' % ' '.join(args))
4602
Edward Lemur934836a2019-09-09 20:16:54 +00004603 cl = Changelist(issue=options.issue)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004604 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004605 parser.error('Need to upload first.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004606
tandrii221ab252016-10-06 08:12:04 -07004607 patchset = options.patchset
4608 if not patchset:
Gavin Make61ccc52020-11-13 00:12:57 +00004609 patchset = cl.GetMostRecentDryRunPatchset()
tandrii221ab252016-10-06 08:12:04 -07004610 if not patchset:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004611 parser.error('Code review host doesn\'t know about issue %s. '
tandrii221ab252016-10-06 08:12:04 -07004612 'No access to issue or wrong issue number?\n'
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004613 'Either upload first, or pass --patchset explicitly.' %
tandrii221ab252016-10-06 08:12:04 -07004614 cl.GetIssue())
4615
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004616 try:
Quinten Yearsley777660f2020-03-04 23:37:06 +00004617 jobs = _fetch_tryjobs(cl, options.buildbucket_host, patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004618 except BuildbucketResponseException as ex:
vapiera7fbd5a2016-06-16 09:17:49 -07004619 print('Buildbucket error: %s' % ex)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004620 return 1
qyearsley53f48a12016-09-01 10:45:13 -07004621 if options.json:
Edward Lemurbaaf6be2019-10-09 18:00:44 +00004622 write_json(options.json, jobs)
qyearsley53f48a12016-09-01 10:45:13 -07004623 else:
Quinten Yearsley777660f2020-03-04 23:37:06 +00004624 _print_tryjobs(options, jobs)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004625 return 0
4626
4627
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004628@subcommand.usage('[new upstream branch]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004629@metrics.collector.collect_metrics('git cl upstream')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004630def CMDupstream(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004631 """Prints or sets the name of the upstream branch, if any."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004632 _, args = parser.parse_args(args)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004633 if len(args) > 1:
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004634 parser.error('Unrecognized args: %s' % ' '.join(args))
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004635
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004636 cl = Changelist()
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004637 if args:
4638 # One arg means set upstream branch.
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004639 branch = cl.GetBranch()
stip7a3dd352016-09-22 17:32:28 -07004640 RunGit(['branch', '--set-upstream-to', args[0], branch])
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004641 cl = Changelist()
vapiera7fbd5a2016-06-16 09:17:49 -07004642 print('Upstream branch set to %s' % (cl.GetUpstreamBranch(),))
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004643
4644 # Clear configured merge-base, if there is one.
4645 git_common.remove_merge_base(branch)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004646 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004647 print(cl.GetUpstreamBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004648 return 0
4649
4650
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004651@metrics.collector.collect_metrics('git cl web')
thestig@chromium.org00858c82013-12-02 23:08:03 +00004652def CMDweb(parser, args):
4653 """Opens the current CL in the web browser."""
4654 _, args = parser.parse_args(args)
4655 if args:
4656 parser.error('Unrecognized args: %s' % ' '.join(args))
4657
4658 issue_url = Changelist().GetIssueURL()
4659 if not issue_url:
vapiera7fbd5a2016-06-16 09:17:49 -07004660 print('ERROR No issue to open', file=sys.stderr)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004661 return 1
4662
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004663 # Redirect I/O before invoking browser to hide its output. For example, this
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004664 # allows us to hide the "Created new window in existing browser session."
4665 # message from Chrome. Based on https://stackoverflow.com/a/2323563.
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004666 saved_stdout = os.dup(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004667 saved_stderr = os.dup(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004668 os.close(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004669 os.close(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004670 os.open(os.devnull, os.O_RDWR)
4671 try:
4672 webbrowser.open(issue_url)
4673 finally:
4674 os.dup2(saved_stdout, 1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004675 os.dup2(saved_stderr, 2)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004676 return 0
4677
4678
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004679@metrics.collector.collect_metrics('git cl set-commit')
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004680def CMDset_commit(parser, args):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004681 """Sets the commit bit to trigger the CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004682 parser.add_option('-d', '--dry-run', action='store_true',
4683 help='trigger in dry run mode')
4684 parser.add_option('-c', '--clear', action='store_true',
4685 help='stop CQ run, if any')
Edward Lemur52969c92020-02-06 18:15:28 +00004686 parser.add_option(
4687 '-i', '--issue', type=int,
4688 help='Operate on this issue instead of the current branch\'s implicit '
4689 'issue.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004690 options, args = parser.parse_args(args)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004691 if args:
4692 parser.error('Unrecognized args: %s' % ' '.join(args))
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004693 if options.dry_run and options.clear:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004694 parser.error('Only one of --dry-run and --clear are allowed.')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004695
Edward Lemur934836a2019-09-09 20:16:54 +00004696 cl = Changelist(issue=options.issue)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004697 if options.clear:
tandriid9e5ce52016-07-13 02:32:59 -07004698 state = _CQState.NONE
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004699 elif options.dry_run:
4700 state = _CQState.DRY_RUN
4701 else:
4702 state = _CQState.COMMIT
4703 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004704 parser.error('Must upload the issue first.')
tandrii9de9ec62016-07-13 03:01:59 -07004705 cl.SetCQState(state)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004706 return 0
4707
4708
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004709@metrics.collector.collect_metrics('git cl set-close')
groby@chromium.org411034a2013-02-26 15:12:01 +00004710def CMDset_close(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004711 """Closes the issue."""
Edward Lemur52969c92020-02-06 18:15:28 +00004712 parser.add_option(
4713 '-i', '--issue', type=int,
4714 help='Operate on this issue instead of the current branch\'s implicit '
4715 'issue.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004716 options, args = parser.parse_args(args)
groby@chromium.org411034a2013-02-26 15:12:01 +00004717 if args:
4718 parser.error('Unrecognized args: %s' % ' '.join(args))
Edward Lemur934836a2019-09-09 20:16:54 +00004719 cl = Changelist(issue=options.issue)
groby@chromium.org411034a2013-02-26 15:12:01 +00004720 # Ensure there actually is an issue to close.
Aaron Gable7139a4e2017-09-05 17:53:09 -07004721 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004722 DieWithError('ERROR: No issue to close.')
groby@chromium.org411034a2013-02-26 15:12:01 +00004723 cl.CloseIssue()
4724 return 0
4725
4726
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004727@metrics.collector.collect_metrics('git cl diff')
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004728def CMDdiff(parser, args):
wychen@chromium.org37b2ec02015-04-03 00:49:15 +00004729 """Shows differences between local tree and last upload."""
thomasanderson074beb22016-08-29 14:03:20 -07004730 parser.add_option(
4731 '--stat',
4732 action='store_true',
4733 dest='stat',
4734 help='Generate a diffstat')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004735 options, args = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004736 if args:
4737 parser.error('Unrecognized args: %s' % ' '.join(args))
wychen@chromium.org46309bf2015-04-03 21:04:49 +00004738
Edward Lemur934836a2019-09-09 20:16:54 +00004739 cl = Changelist()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00004740 issue = cl.GetIssue()
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004741 branch = cl.GetBranch()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00004742 if not issue:
4743 DieWithError('No issue found for current branch (%s)' % branch)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004744
Aaron Gablea718c3e2017-08-28 17:47:28 -07004745 base = cl._GitGetBranchConfigValue('last-upload-hash')
4746 if not base:
4747 base = cl._GitGetBranchConfigValue('gerritsquashhash')
4748 if not base:
4749 detail = cl._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
4750 revision_info = detail['revisions'][detail['current_revision']]
4751 fetch_info = revision_info['fetch']['http']
4752 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
4753 base = 'FETCH_HEAD'
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004754
Aaron Gablea718c3e2017-08-28 17:47:28 -07004755 cmd = ['git', 'diff']
4756 if options.stat:
4757 cmd.append('--stat')
4758 cmd.append(base)
4759 subprocess2.check_call(cmd)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004760
4761 return 0
4762
4763
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004764@metrics.collector.collect_metrics('git cl owners')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004765def CMDowners(parser, args):
Dirk Prankebf980882017-09-02 15:08:00 -07004766 """Finds potential owners for reviewing."""
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004767 parser.add_option(
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00004768 '--ignore-current',
4769 action='store_true',
4770 help='Ignore the CL\'s current reviewers and start from scratch.')
4771 parser.add_option(
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00004772 '--ignore-self',
4773 action='store_true',
4774 help='Do not consider CL\'s author as an owners.')
4775 parser.add_option(
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004776 '--no-color',
4777 action='store_true',
4778 help='Use this option to disable color output')
Dirk Prankebf980882017-09-02 15:08:00 -07004779 parser.add_option(
4780 '--batch',
4781 action='store_true',
4782 help='Do not run interactively, just suggest some')
Yang Guo6e269a02019-06-26 11:17:02 +00004783 # TODO: Consider moving this to another command, since other
4784 # git-cl owners commands deal with owners for a given CL.
4785 parser.add_option(
4786 '--show-all',
4787 action='store_true',
4788 help='Show all owners for a particular file')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004789 options, args = parser.parse_args(args)
4790
Edward Lemur934836a2019-09-09 20:16:54 +00004791 cl = Changelist()
Edward Lesmes50da7702020-03-30 19:23:43 +00004792 author = cl.GetAuthor()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004793
Yang Guo6e269a02019-06-26 11:17:02 +00004794 if options.show_all:
Bruce Dawson97ed44a2020-05-06 17:04:03 +00004795 if len(args) == 0:
4796 print('No files specified for --show-all. Nothing to do.')
4797 return 0
Edward Lesmesb34cd6d2021-01-07 01:05:41 +00004798 project = cl.GetGerritProject()
4799 branch = cl.GetCommonAncestorWithUpstream()
Edward Lesmeseeca9c62020-11-20 00:00:17 +00004800 client = owners_client.DepotToolsClient(
Edward Lesmesb34cd6d2021-01-07 01:05:41 +00004801 host=cl.GetGerritHost(),
Edward Lesmeseeca9c62020-11-20 00:00:17 +00004802 root=settings.GetRoot(),
Edward Lesmesb34cd6d2021-01-07 01:05:41 +00004803 branch=branch)
4804 for arg in args:
4805 print('Owners for %s:' % arg)
4806 for owner in client.ListOwnersForFile(project, branch, arg):
4807 print(' - %s' % owner)
Yang Guo6e269a02019-06-26 11:17:02 +00004808 return 0
4809
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004810 if args:
4811 if len(args) > 1:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004812 parser.error('Unknown args.')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004813 base_branch = args[0]
4814 else:
4815 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004816 base_branch = cl.GetCommonAncestorWithUpstream()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004817
Edward Lemur2c62b332020-03-12 22:12:33 +00004818 root = settings.GetRoot()
4819 affected_files = cl.GetAffectedFiles(base_branch)
Dirk Prankebf980882017-09-02 15:08:00 -07004820
4821 if options.batch:
Edward Lesmesb34cd6d2021-01-07 01:05:41 +00004822 project = cl.GetGerritProject()
4823 branch = cl.GetCommonAncestorWithUpstream()
Edward Lesmes8a791e72020-12-02 18:33:18 +00004824 client = owners_client.DepotToolsClient(
Edward Lesmesb34cd6d2021-01-07 01:05:41 +00004825 host=cl.GetGerritHost(),
Edward Lesmes8a791e72020-12-02 18:33:18 +00004826 root=settings.GetRoot(),
Edward Lesmesb34cd6d2021-01-07 01:05:41 +00004827 branch=branch)
4828 print('\n'.join(client.SuggestOwners(project, branch, affected_files)))
Dirk Prankebf980882017-09-02 15:08:00 -07004829 return 0
4830
Edward Lemur2c62b332020-03-12 22:12:33 +00004831 owner_files = [f for f in affected_files if 'OWNERS' in os.path.basename(f)]
4832 original_owner_files = {
4833 f: scm.GIT.GetOldContents(root, f, base_branch).splitlines()
4834 for f in owner_files}
4835
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004836 return owners_finder.OwnersFinder(
Dirk Prankebf980882017-09-02 15:08:00 -07004837 affected_files,
Edward Lemur2c62b332020-03-12 22:12:33 +00004838 root,
Edward Lemur707d70b2018-02-07 00:50:14 +01004839 author,
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00004840 [] if options.ignore_current else cl.GetReviewers(),
Edward Lemur2c62b332020-03-12 22:12:33 +00004841 fopen=open,
4842 os_path=os.path,
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02004843 disable_color=options.no_color,
Edward Lemur2c62b332020-03-12 22:12:33 +00004844 override_files=original_owner_files,
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00004845 ignore_author=options.ignore_self).run()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004846
4847
Aiden Bennerc08566e2018-10-03 17:52:42 +00004848def BuildGitDiffCmd(diff_type, upstream_commit, args, allow_prefix=False):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004849 """Generates a diff command."""
4850 # Generate diff for the current branch's changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +00004851 diff_cmd = ['-c', 'core.quotePath=false', 'diff', '--no-ext-diff']
4852
Aiden Benner6c18a1a2018-11-23 20:18:23 +00004853 if allow_prefix:
4854 # explicitly setting --src-prefix and --dst-prefix is necessary in the
4855 # case that diff.noprefix is set in the user's git config.
4856 diff_cmd += ['--src-prefix=a/', '--dst-prefix=b/']
4857 else:
Aiden Bennerc08566e2018-10-03 17:52:42 +00004858 diff_cmd += ['--no-prefix']
4859
4860 diff_cmd += [diff_type, upstream_commit, '--']
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004861
4862 if args:
4863 for arg in args:
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00004864 if os.path.isdir(arg) or os.path.isfile(arg):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004865 diff_cmd.append(arg)
4866 else:
4867 DieWithError('Argument "%s" is not a file or a directory' % arg)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004868
4869 return diff_cmd
4870
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004871
Jamie Madill5e96ad12020-01-13 16:08:35 +00004872def _RunClangFormatDiff(opts, clang_diff_files, top_dir, upstream_commit):
4873 """Runs clang-format-diff and sets a return value if necessary."""
4874
4875 if not clang_diff_files:
4876 return 0
4877
4878 # Set to 2 to signal to CheckPatchFormatted() that this patch isn't
4879 # formatted. This is used to block during the presubmit.
4880 return_value = 0
4881
4882 # Locate the clang-format binary in the checkout
4883 try:
4884 clang_format_tool = clang_format.FindClangFormatToolInChromiumTree()
4885 except clang_format.NotFoundError as e:
4886 DieWithError(e)
4887
4888 if opts.full or settings.GetFormatFullByDefault():
4889 cmd = [clang_format_tool]
4890 if not opts.dry_run and not opts.diff:
4891 cmd.append('-i')
4892 if opts.dry_run:
4893 for diff_file in clang_diff_files:
4894 with open(diff_file, 'r') as myfile:
4895 code = myfile.read().replace('\r\n', '\n')
4896 stdout = RunCommand(cmd + [diff_file], cwd=top_dir)
4897 stdout = stdout.replace('\r\n', '\n')
4898 if opts.diff:
4899 sys.stdout.write(stdout)
4900 if code != stdout:
4901 return_value = 2
4902 else:
4903 stdout = RunCommand(cmd + clang_diff_files, cwd=top_dir)
4904 if opts.diff:
4905 sys.stdout.write(stdout)
4906 else:
Jamie Madill5e96ad12020-01-13 16:08:35 +00004907 try:
4908 script = clang_format.FindClangFormatScriptInChromiumTree(
4909 'clang-format-diff.py')
4910 except clang_format.NotFoundError as e:
4911 DieWithError(e)
4912
Edward Lesmes89624cd2020-04-06 17:51:56 +00004913 cmd = ['vpython', script, '-p0']
Jamie Madill5e96ad12020-01-13 16:08:35 +00004914 if not opts.dry_run and not opts.diff:
4915 cmd.append('-i')
4916
4917 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, clang_diff_files)
Edward Lemur1a83da12020-03-04 21:18:36 +00004918 diff_output = RunGit(diff_cmd).encode('utf-8')
Jamie Madill5e96ad12020-01-13 16:08:35 +00004919
Edward Lesmes89624cd2020-04-06 17:51:56 +00004920 env = os.environ.copy()
4921 env['PATH'] = (
4922 str(os.path.dirname(clang_format_tool)) + os.pathsep + env['PATH'])
4923 stdout = RunCommand(
4924 cmd, stdin=diff_output, cwd=top_dir, env=env,
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00004925 shell=sys.platform.startswith('win32'))
Jamie Madill5e96ad12020-01-13 16:08:35 +00004926 if opts.diff:
4927 sys.stdout.write(stdout)
4928 if opts.dry_run and len(stdout) > 0:
4929 return_value = 2
4930
4931 return return_value
4932
4933
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00004934def MatchingFileType(file_name, extensions):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00004935 """Returns True if the file name ends with one of the given extensions."""
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00004936 return bool([ext for ext in extensions if file_name.lower().endswith(ext)])
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004937
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004938
enne@chromium.org555cfe42014-01-29 18:21:39 +00004939@subcommand.usage('[files or directories to diff]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004940@metrics.collector.collect_metrics('git cl format')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00004941def CMDformat(parser, args):
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00004942 """Runs auto-formatting tools (clang-format etc.) on the diff."""
Christopher Lamc5ba6922017-01-24 11:19:14 +11004943 CLANG_EXTS = ['.cc', '.cpp', '.h', '.m', '.mm', '.proto', '.java']
kylechar58edce22016-06-17 06:07:51 -07004944 GN_EXTS = ['.gn', '.gni', '.typemap']
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00004945 parser.add_option('--full', action='store_true',
4946 help='Reformat the full content of all touched files')
4947 parser.add_option('--dry-run', action='store_true',
4948 help='Don\'t modify any file on disk.')
Aiden Benner99b0ccb2018-11-20 19:53:31 +00004949 parser.add_option(
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00004950 '--no-clang-format',
4951 dest='clang_format',
4952 action='store_false',
4953 default=True,
4954 help='Disables formatting of various file types using clang-format.')
4955 parser.add_option(
Aiden Benner99b0ccb2018-11-20 19:53:31 +00004956 '--python',
4957 action='store_true',
4958 default=None,
4959 help='Enables python formatting on all python files.')
4960 parser.add_option(
4961 '--no-python',
4962 action='store_true',
Garrett Beaty91a6f332020-01-06 16:57:24 +00004963 default=False,
Aiden Benner99b0ccb2018-11-20 19:53:31 +00004964 help='Disables python formatting on all python files. '
Garrett Beaty91a6f332020-01-06 16:57:24 +00004965 'If neither --python or --no-python are set, python files that have a '
4966 '.style.yapf file in an ancestor directory will be formatted. '
4967 'It is an error to set both.')
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00004968 parser.add_option(
4969 '--js',
4970 action='store_true',
4971 help='Format javascript code with clang-format. '
4972 'Has no effect if --no-clang-format is set.')
wittman@chromium.org04d5a222014-03-07 18:30:42 +00004973 parser.add_option('--diff', action='store_true',
4974 help='Print diff to stdout rather than modifying files.')
Ilya Shermane081cbe2017-08-15 17:51:04 -07004975 parser.add_option('--presubmit', action='store_true',
4976 help='Used when running the script from a presubmit.')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00004977 opts, args = parser.parse_args(args)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00004978
Garrett Beaty91a6f332020-01-06 16:57:24 +00004979 if opts.python is not None and opts.no_python:
4980 raise parser.error('Cannot set both --python and --no-python')
4981 if opts.no_python:
4982 opts.python = False
4983
Daniel Chengc55eecf2016-12-30 03:11:02 -08004984 # Normalize any remaining args against the current path, so paths relative to
4985 # the current directory are still resolved as expected.
4986 args = [os.path.join(os.getcwd(), arg) for arg in args]
4987
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00004988 # git diff generates paths against the root of the repository. Change
4989 # to that directory so clang-format can find files even within subdirs.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004990 rel_base_path = settings.GetRelativeRoot()
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00004991 if rel_base_path:
4992 os.chdir(rel_base_path)
4993
digit@chromium.org29e47272013-05-17 17:01:46 +00004994 # Grab the merge-base commit, i.e. the upstream commit of the current
4995 # branch when it was created or the last time it was rebased. This is
4996 # to cover the case where the user may have called "git fetch origin",
4997 # moving the origin branch to a newer commit, but hasn't rebased yet.
4998 upstream_commit = None
4999 cl = Changelist()
5000 upstream_branch = cl.GetUpstreamBranch()
5001 if upstream_branch:
5002 upstream_commit = RunGit(['merge-base', 'HEAD', upstream_branch])
5003 upstream_commit = upstream_commit.strip()
5004
5005 if not upstream_commit:
5006 DieWithError('Could not find base commit for this branch. '
5007 'Are you in detached state?')
5008
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005009 changed_files_cmd = BuildGitDiffCmd('--name-only', upstream_commit, args)
5010 diff_output = RunGit(changed_files_cmd)
5011 diff_files = diff_output.splitlines()
jkarlin@chromium.orgad21b922016-01-28 17:48:42 +00005012 # Filter out files deleted by this CL
5013 diff_files = [x for x in diff_files if os.path.isfile(x)]
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005014
Andreas Haas417d89c2020-02-06 10:24:27 +00005015 if opts.js:
Deepanjan Roy605dd312018-07-02 17:48:54 +00005016 CLANG_EXTS.extend(['.js', '.ts'])
Christopher Lamc5ba6922017-01-24 11:19:14 +11005017
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005018 clang_diff_files = []
5019 if opts.clang_format:
5020 clang_diff_files = [
5021 x for x in diff_files if MatchingFileType(x, CLANG_EXTS)
5022 ]
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005023 python_diff_files = [x for x in diff_files if MatchingFileType(x, ['.py'])]
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005024 gn_diff_files = [x for x in diff_files if MatchingFileType(x, GN_EXTS)]
digit@chromium.org29e47272013-05-17 17:01:46 +00005025
Edward Lesmes50da7702020-03-30 19:23:43 +00005026 top_dir = settings.GetRoot()
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +00005027
Jamie Madill5e96ad12020-01-13 16:08:35 +00005028 return_value = _RunClangFormatDiff(opts, clang_diff_files, top_dir,
5029 upstream_commit)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005030
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005031 # Similar code to above, but using yapf on .py files rather than clang-format
5032 # on C/C++ files
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005033 py_explicitly_disabled = opts.python is not None and not opts.python
5034 if python_diff_files and not py_explicitly_disabled:
Aiden Bennere47ac152018-11-20 16:44:03 +00005035 depot_tools_path = os.path.dirname(os.path.abspath(__file__))
5036 yapf_tool = os.path.join(depot_tools_path, 'yapf')
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005037
Aiden Bennerc08566e2018-10-03 17:52:42 +00005038 # Used for caching.
5039 yapf_configs = {}
5040 for f in python_diff_files:
5041 # Find the yapf style config for the current file, defaults to depot
5042 # tools default.
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005043 _FindYapfConfigFile(f, yapf_configs, top_dir)
5044
5045 # Turn on python formatting by default if a yapf config is specified.
5046 # This breaks in the case of this repo though since the specified
5047 # style file is also the global default.
5048 if opts.python is None:
5049 filtered_py_files = []
5050 for f in python_diff_files:
5051 if _FindYapfConfigFile(f, yapf_configs, top_dir) is not None:
5052 filtered_py_files.append(f)
5053 else:
5054 filtered_py_files = python_diff_files
5055
5056 # Note: yapf still seems to fix indentation of the entire file
5057 # even if line ranges are specified.
5058 # See https://github.com/google/yapf/issues/499
5059 if not opts.full and filtered_py_files:
5060 py_line_diffs = _ComputeDiffLineRanges(filtered_py_files, upstream_commit)
5061
Brian Sheedyb4307d52019-12-02 19:18:17 +00005062 yapfignore_patterns = _GetYapfIgnorePatterns(top_dir)
5063 filtered_py_files = _FilterYapfIgnoredFiles(filtered_py_files,
5064 yapfignore_patterns)
Brian Sheedy59b06a82019-10-14 17:03:29 +00005065
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005066 for f in filtered_py_files:
Andrew Grievefa40bfa2020-01-07 02:32:57 +00005067 yapf_style = _FindYapfConfigFile(f, yapf_configs, top_dir)
5068 # Default to pep8 if not .style.yapf is found.
5069 if not yapf_style:
5070 yapf_style = 'pep8'
Aiden Bennerc08566e2018-10-03 17:52:42 +00005071
Peter Wend9399922020-06-17 17:33:49 +00005072 with open(f, 'r') as py_f:
5073 if 'python3' in py_f.readline():
5074 vpython_script = 'vpython3'
5075 else:
5076 vpython_script = 'vpython'
5077
5078 cmd = [vpython_script, yapf_tool, '--style', yapf_style, f]
Aiden Bennerc08566e2018-10-03 17:52:42 +00005079
5080 has_formattable_lines = False
5081 if not opts.full:
5082 # Only run yapf over changed line ranges.
5083 for diff_start, diff_len in py_line_diffs[f]:
5084 diff_end = diff_start + diff_len - 1
5085 # Yapf errors out if diff_end < diff_start but this
5086 # is a valid line range diff for a removal.
5087 if diff_end >= diff_start:
5088 has_formattable_lines = True
5089 cmd += ['-l', '{}-{}'.format(diff_start, diff_end)]
5090 # If all line diffs were removals we have nothing to format.
5091 if not has_formattable_lines:
5092 continue
5093
5094 if opts.diff or opts.dry_run:
5095 cmd += ['--diff']
5096 # Will return non-zero exit code if non-empty diff.
Edward Lesmesb7db1832020-06-22 20:22:27 +00005097 stdout = RunCommand(cmd,
5098 error_ok=True,
5099 cwd=top_dir,
5100 shell=sys.platform.startswith('win32'))
Aiden Bennerc08566e2018-10-03 17:52:42 +00005101 if opts.diff:
5102 sys.stdout.write(stdout)
5103 elif len(stdout) > 0:
5104 return_value = 2
5105 else:
5106 cmd += ['-i']
Edward Lesmesb7db1832020-06-22 20:22:27 +00005107 RunCommand(cmd, cwd=top_dir, shell=sys.platform.startswith('win32'))
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005108
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005109 # Format GN build files. Always run on full build files for canonical form.
5110 if gn_diff_files:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005111 cmd = ['gn', 'format']
brettw4b8ed592016-08-05 16:19:12 -07005112 if opts.dry_run or opts.diff:
5113 cmd.append('--dry-run')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005114 for gn_diff_file in gn_diff_files:
brettw4b8ed592016-08-05 16:19:12 -07005115 gn_ret = subprocess2.call(cmd + [gn_diff_file],
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005116 shell=sys.platform.startswith('win'),
brettw4b8ed592016-08-05 16:19:12 -07005117 cwd=top_dir)
5118 if opts.dry_run and gn_ret == 2:
5119 return_value = 2 # Not formatted.
5120 elif opts.diff and gn_ret == 2:
5121 # TODO this should compute and print the actual diff.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005122 print('This change has GN build file diff for ' + gn_diff_file)
brettw4b8ed592016-08-05 16:19:12 -07005123 elif gn_ret != 0:
5124 # For non-dry run cases (and non-2 return values for dry-run), a
5125 # nonzero error code indicates a failure, probably because the file
5126 # doesn't parse.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005127 DieWithError('gn format failed on ' + gn_diff_file +
5128 '\nTry running `gn format` on this file manually.')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005129
Ilya Shermane081cbe2017-08-15 17:51:04 -07005130 # Skip the metrics formatting from the global presubmit hook. These files have
5131 # a separate presubmit hook that issues an error if the files need formatting,
5132 # whereas the top-level presubmit script merely issues a warning. Formatting
5133 # these files is somewhat slow, so it's important not to duplicate the work.
5134 if not opts.presubmit:
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005135 for diff_xml in GetDiffXMLs(diff_files):
5136 xml_dir = GetMetricsDir(diff_xml)
5137 if not xml_dir:
5138 continue
5139
Ilya Shermane081cbe2017-08-15 17:51:04 -07005140 tool_dir = os.path.join(top_dir, xml_dir)
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005141 pretty_print_tool = os.path.join(tool_dir, 'pretty_print.py')
5142 cmd = ['vpython', pretty_print_tool, '--non-interactive']
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005143
5144 # If the XML file is histograms.xml or enums.xml, add the xml path to the
5145 # command as histograms/pretty_print.py now needs a relative path argument
5146 # after splitting the histograms into multiple directories.
5147 # For example, in tools/metrics/ukm, pretty-print could be run using:
5148 # $ python pretty_print.py
5149 # But in tools/metrics/histogrmas, pretty-print should be run with an
5150 # additional relative path argument, like:
5151 # $ python pretty_print.py histograms_xml/UMA/histograms.xml
5152 # $ python pretty_print.py enums.xml
5153
5154 # TODO (crbug/1116488): Remove this check after ensuring that the updated
5155 # version of histograms/pretty_print.py is released.
5156 filepath_required = os.path.exists(
5157 os.path.join(tool_dir, 'validate_prefix.py'))
5158
Weilun Shib92c4b72020-08-27 17:45:11 +00005159 if (diff_xml.endswith('histograms.xml') or diff_xml.endswith('enums.xml')
5160 or diff_xml.endswith('histogram_suffixes_list.xml')
5161 ) and filepath_required:
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005162 cmd.append(diff_xml)
5163
Ilya Shermane081cbe2017-08-15 17:51:04 -07005164 if opts.dry_run or opts.diff:
5165 cmd.append('--diff')
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005166
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005167 # TODO(isherman): Once this file runs only on Python 3.3+, drop the
5168 # `shell` param and instead replace `'vpython'` with
5169 # `shutil.which('frob')` above: https://stackoverflow.com/a/32799942
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005170 stdout = RunCommand(cmd,
5171 cwd=top_dir,
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005172 shell=sys.platform.startswith('win32'))
Ilya Shermane081cbe2017-08-15 17:51:04 -07005173 if opts.diff:
5174 sys.stdout.write(stdout)
5175 if opts.dry_run and stdout:
5176 return_value = 2 # Not formatted.
Alexei Svitkinef3cac412017-02-06 11:08:50 -05005177
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005178 return return_value
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005179
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005180
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005181def GetDiffXMLs(diff_files):
5182 return [
5183 os.path.normpath(x) for x in diff_files if MatchingFileType(x, ['.xml'])
5184 ]
5185
5186
5187def GetMetricsDir(diff_xml):
Steven Holte2e664bf2017-04-21 13:10:47 -07005188 metrics_xml_dirs = [
5189 os.path.join('tools', 'metrics', 'actions'),
5190 os.path.join('tools', 'metrics', 'histograms'),
5191 os.path.join('tools', 'metrics', 'rappor'),
Ilya Shermanb67e60c2020-05-20 22:27:03 +00005192 os.path.join('tools', 'metrics', 'structured'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005193 os.path.join('tools', 'metrics', 'ukm'),
5194 ]
Steven Holte2e664bf2017-04-21 13:10:47 -07005195 for xml_dir in metrics_xml_dirs:
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005196 if diff_xml.startswith(xml_dir):
5197 return xml_dir
5198 return None
Steven Holte2e664bf2017-04-21 13:10:47 -07005199
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005200
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005201@subcommand.usage('<codereview url or issue id>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005202@metrics.collector.collect_metrics('git cl checkout')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005203def CMDcheckout(parser, args):
Edward Lemurf38bc172019-09-03 21:02:13 +00005204 """Checks out a branch associated with a given Gerrit issue."""
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005205 _, args = parser.parse_args(args)
5206
5207 if len(args) != 1:
5208 parser.print_help()
5209 return 1
5210
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005211 issue_arg = ParseIssueNumberArgument(args[0])
tandrii@chromium.orgde6c9a12016-04-11 15:33:53 +00005212 if not issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005213 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005214
tandrii@chromium.orgabd27e52016-04-11 15:43:32 +00005215 target_issue = str(issue_arg.issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005216
Edward Lemur52969c92020-02-06 18:15:28 +00005217 output = RunGit(['config', '--local', '--get-regexp',
Edward Lesmes50da7702020-03-30 19:23:43 +00005218 r'branch\..*\.' + ISSUE_CONFIG_KEY],
Edward Lemur52969c92020-02-06 18:15:28 +00005219 error_ok=True)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005220
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005221 branches = []
Edward Lemur52969c92020-02-06 18:15:28 +00005222 for key, issue in [x.split() for x in output.splitlines()]:
5223 if issue == target_issue:
Edward Lesmes50da7702020-03-30 19:23:43 +00005224 branches.append(re.sub(r'branch\.(.*)\.' + ISSUE_CONFIG_KEY, r'\1', key))
Edward Lemur52969c92020-02-06 18:15:28 +00005225
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005226 if len(branches) == 0:
vapiera7fbd5a2016-06-16 09:17:49 -07005227 print('No branch found for issue %s.' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005228 return 1
5229 if len(branches) == 1:
5230 RunGit(['checkout', branches[0]])
5231 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005232 print('Multiple branches match issue %s:' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005233 for i in range(len(branches)):
vapiera7fbd5a2016-06-16 09:17:49 -07005234 print('%d: %s' % (i, branches[i]))
Edward Lesmesae3586b2020-03-23 21:21:14 +00005235 which = gclient_utils.AskForData('Choose by index: ')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005236 try:
5237 RunGit(['checkout', branches[int(which)]])
5238 except (IndexError, ValueError):
vapiera7fbd5a2016-06-16 09:17:49 -07005239 print('Invalid selection, not checking out any branch.')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005240 return 1
5241
5242 return 0
5243
5244
maruel@chromium.org29404b52014-09-08 22:58:00 +00005245def CMDlol(parser, args):
5246 # This command is intentionally undocumented.
vapiera7fbd5a2016-06-16 09:17:49 -07005247 print(zlib.decompress(base64.b64decode(
thakis@chromium.org3421c992014-11-02 02:20:32 +00005248 'eNptkLEOwyAMRHe+wupCIqW57v0Vq84WqWtXyrcXnCBsmgMJ+/SSAxMZgRB6NzE'
5249 'E2ObgCKJooYdu4uAQVffUEoE1sRQLxAcqzd7uK2gmStrll1ucV3uZyaY5sXyDd9'
5250 'JAnN+lAXsOMJ90GANAi43mq5/VeeacylKVgi8o6F1SC63FxnagHfJUTfUYdCR/W'
Gavin Mak18f45d22020-12-04 21:45:10 +00005251 'Ofe+0dHL7PicpytKP750Fh1q2qnLVof4w8OZWNY')).decode('utf-8'))
maruel@chromium.org29404b52014-09-08 22:58:00 +00005252 return 0
5253
5254
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005255class OptionParser(optparse.OptionParser):
5256 """Creates the option parse and add --verbose support."""
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00005257
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005258 def __init__(self, *args, **kwargs):
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005259 optparse.OptionParser.__init__(
5260 self, *args, prog='git cl', version=__version__, **kwargs)
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005261 self.add_option(
5262 '-v', '--verbose', action='count', default=0,
5263 help='Use 2 times for more debugging info')
5264
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005265 def parse_args(self, args=None, _values=None):
Andrii Shyshkalov46f20cd2018-10-30 06:42:54 +00005266 try:
5267 return self._parse_args(args)
5268 finally:
5269 # Regardless of success or failure of args parsing, we want to report
5270 # metrics, but only after logging has been initialized (if parsing
5271 # succeeded).
5272 global settings
5273 settings = Settings()
5274
5275 if not metrics.DISABLE_METRICS_COLLECTION:
5276 # GetViewVCUrl ultimately calls logging method.
5277 project_url = settings.GetViewVCUrl().strip('/+')
5278 if project_url in metrics_utils.KNOWN_PROJECT_URLS:
5279 metrics.collector.add('project_urls', [project_url])
5280
5281 def _parse_args(self, args=None):
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005282 # Create an optparse.Values object that will store only the actual passed
5283 # options, without the defaults.
5284 actual_options = optparse.Values()
5285 _, args = optparse.OptionParser.parse_args(self, args, actual_options)
5286 # Create an optparse.Values object with the default options.
5287 options = optparse.Values(self.get_default_values().__dict__)
5288 # Update it with the options passed by the user.
5289 options._update_careful(actual_options.__dict__)
5290 # Store the options passed by the user in an _actual_options attribute.
5291 # We store only the keys, and not the values, since the values can contain
5292 # arbitrary information, which might be PII.
Edward Lemur79d4f992019-11-11 23:49:02 +00005293 metrics.collector.add('arguments', list(actual_options.__dict__.keys()))
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005294
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005295 levels = [logging.WARNING, logging.INFO, logging.DEBUG]
Andrii Shyshkalov5b04a572017-01-23 17:44:41 +01005296 logging.basicConfig(
5297 level=levels[min(options.verbose, len(levels) - 1)],
5298 format='[%(levelname).1s%(asctime)s %(process)d %(thread)d '
5299 '%(filename)s] %(message)s')
Edward Lemur83bd7f42018-10-10 00:14:21 +00005300
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005301 return options, args
5302
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005303
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005304def main(argv):
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005305 if sys.hexversion < 0x02060000:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005306 print('\nYour Python version %s is unsupported, please upgrade.\n' %
vapiera7fbd5a2016-06-16 09:17:49 -07005307 (sys.version.split(' ', 1)[0],), file=sys.stderr)
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005308 return 2
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00005309
maruel@chromium.org39c0b222013-08-17 16:57:01 +00005310 colorize_CMDstatus_doc()
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005311 dispatcher = subcommand.CommandDispatcher(__name__)
5312 try:
5313 return dispatcher.execute(OptionParser(), argv)
Edward Lemur5b929a42019-10-21 17:57:39 +00005314 except auth.LoginRequiredError as e:
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +00005315 DieWithError(str(e))
Edward Lemur79d4f992019-11-11 23:49:02 +00005316 except urllib.error.HTTPError as e:
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005317 if e.code != 500:
5318 raise
5319 DieWithError(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005320 ('App Engine is misbehaving and returned HTTP %d, again. Keep faith '
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005321 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
sbc@chromium.org013731e2015-02-26 18:28:43 +00005322 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005323
5324
5325if __name__ == '__main__':
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005326 # These affect sys.stdout, so do it outside of main() to simplify mocks in
5327 # the unit tests.
maruel@chromium.org6f09cd92011-04-01 16:38:12 +00005328 fix_encoding.fix_encoding()
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00005329 setup_color.init()
Edward Lemur6f812e12018-07-31 22:45:57 +00005330 with metrics.collector.print_notice_and_exit():
sbc@chromium.org013731e2015-02-26 18:28:43 +00005331 sys.exit(main(sys.argv[1:]))