blob: 89bad12ce4feb7612712fdd5c85f77cfb6aca103 [file] [log] [blame]
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00001/*
phoglund@webrtc.org78088c22012-02-07 14:56:45 +00002 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00003 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
kwiberg84be5112016-04-27 01:19:58 -070011#include <memory>
danilchapb8b6fbb2015-12-10 05:05:27 -080012#include <vector>
13
Karl Wiberg918f50c2018-07-05 11:40:33 +020014#include "absl/memory/memory.h"
Erik Språngf93eda12019-01-16 17:10:57 +010015#include "api/video/video_codec_constants.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020016#include "api/video/video_timing.h"
Elad Alon4a87e1c2017-10-03 16:11:34 +020017#include "logging/rtc_event_log/events/rtc_event.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020018#include "logging/rtc_event_log/mock/mock_rtc_event_log.h"
19#include "modules/rtp_rtcp/include/rtp_cvo.h"
20#include "modules/rtp_rtcp/include/rtp_header_extension_map.h"
21#include "modules/rtp_rtcp/include/rtp_header_parser.h"
22#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
23#include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
24#include "modules/rtp_rtcp/source/rtp_format_video_generic.h"
philipelb3e42a42018-09-13 10:57:14 +020025#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor.h"
26#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor_extension.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020027#include "modules/rtp_rtcp/source/rtp_header_extensions.h"
28#include "modules/rtp_rtcp/source/rtp_packet_received.h"
29#include "modules/rtp_rtcp/source/rtp_packet_to_send.h"
30#include "modules/rtp_rtcp/source/rtp_sender.h"
31#include "modules/rtp_rtcp/source/rtp_sender_video.h"
32#include "modules/rtp_rtcp/source/rtp_utility.h"
33#include "rtc_base/arraysize.h"
34#include "rtc_base/buffer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020035#include "rtc_base/rate_limiter.h"
36#include "test/field_trial.h"
37#include "test/gmock.h"
38#include "test/gtest.h"
39#include "test/mock_transport.h"
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +000040
41namespace webrtc {
42
andrew@webrtc.org8a442592011-12-16 21:24:30 +000043namespace {
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +000044const int kTransmissionTimeOffsetExtensionId = 1;
45const int kAbsoluteSendTimeExtensionId = 14;
sprang@webrtc.org30933902015-03-17 14:33:12 +000046const int kTransportSequenceNumberExtensionId = 13;
ilnik04f4d122017-06-19 07:18:55 -070047const int kVideoTimingExtensionId = 12;
Steve Anton296a0ce2018-03-22 15:17:27 -070048const int kMidExtensionId = 11;
Amit Hilbuch77938e62018-12-21 09:23:38 -080049const int kGenericDescriptorId = 10;
50const int kAudioLevelExtensionId = 9;
51const int kRidExtensionId = 8;
52const int kRepairedRidExtensionId = 7;
53const int kVideoRotationExtensionId = 5;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000054const int kPayload = 100;
Shao Changbine62202f2015-04-21 20:24:50 +080055const int kRtxPayload = 98;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000056const uint32_t kTimestamp = 10;
57const uint16_t kSeqNum = 33;
brandtr9dfff292016-11-14 05:14:50 -080058const uint32_t kSsrc = 725242;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000059const int kMaxPacketLength = 1500;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000060const uint8_t kAudioLevel = 0x5a;
sprang@webrtc.org30933902015-03-17 14:33:12 +000061const uint16_t kTransportSequenceNumber = 0xaabbu;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000062const int kAudioPayload = 103;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +000063const uint64_t kStartTime = 123456789;
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +000064const size_t kMaxPaddingSize = 224u;
Stefan Holmera246cfb2016-08-23 17:51:42 +020065const size_t kGenericHeaderLength = 1;
66const uint8_t kPayloadData[] = {47, 11, 32, 93, 89};
spranga8ae6f22017-09-04 07:23:56 -070067const int64_t kDefaultExpectedRetransmissionTimeMs = 125;
Amit Hilbuch77938e62018-12-21 09:23:38 -080068const char kNoRid[] = "";
69const char kNoMid[] = "";
andrew@webrtc.org8a442592011-12-16 21:24:30 +000070
Danil Chapovalov5e57b172016-09-02 19:15:59 +020071using ::testing::_;
philipelb3e42a42018-09-13 10:57:14 +020072using ::testing::ElementsAre;
Danil Chapovalov5e57b172016-09-02 19:15:59 +020073using ::testing::ElementsAreArray;
sprang168794c2017-07-06 04:38:06 -070074using ::testing::Invoke;
Danil Chapovalov84ffb352018-09-25 18:59:09 +020075using ::testing::SizeIs;
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +000076
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000077uint64_t ConvertMsToAbsSendTime(int64_t time_ms) {
Stefan Holmer0a87ffc2015-10-21 13:41:48 +020078 return (((time_ms << 18) + 500) / 1000) & 0x00ffffff;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000079}
80
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +000081class LoopbackTransportTest : public webrtc::Transport {
82 public:
Petter Strandmark26bc6692018-05-29 08:43:35 +020083 LoopbackTransportTest() : total_bytes_sent_(0) {
danilchap12ba1862016-10-26 02:41:55 -070084 receivers_extensions_.Register(kRtpExtensionTransmissionTimeOffset,
85 kTransmissionTimeOffsetExtensionId);
86 receivers_extensions_.Register(kRtpExtensionAbsoluteSendTime,
87 kAbsoluteSendTimeExtensionId);
88 receivers_extensions_.Register(kRtpExtensionTransportSequenceNumber,
89 kTransportSequenceNumberExtensionId);
90 receivers_extensions_.Register(kRtpExtensionVideoRotation,
91 kVideoRotationExtensionId);
92 receivers_extensions_.Register(kRtpExtensionAudioLevel,
93 kAudioLevelExtensionId);
ilnik04f4d122017-06-19 07:18:55 -070094 receivers_extensions_.Register(kRtpExtensionVideoTiming,
95 kVideoTimingExtensionId);
Steve Anton296a0ce2018-03-22 15:17:27 -070096 receivers_extensions_.Register(kRtpExtensionMid, kMidExtensionId);
philipelb3e42a42018-09-13 10:57:14 +020097 receivers_extensions_.Register(kRtpExtensionGenericFrameDescriptor,
98 kGenericDescriptorId);
Amit Hilbuch77938e62018-12-21 09:23:38 -080099 receivers_extensions_.Register(kRtpExtensionRtpStreamId, kRidExtensionId);
100 receivers_extensions_.Register(kRtpExtensionRepairedRtpStreamId,
101 kRepairedRidExtensionId);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000102 }
danilchap12ba1862016-10-26 02:41:55 -0700103
stefan1d8a5062015-10-02 03:39:33 -0700104 bool SendRtp(const uint8_t* data,
105 size_t len,
106 const PacketOptions& options) override {
Petter Strandmark26bc6692018-05-29 08:43:35 +0200107 last_options_ = options;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000108 total_bytes_sent_ += len;
danilchap12ba1862016-10-26 02:41:55 -0700109 sent_packets_.push_back(RtpPacketReceived(&receivers_extensions_));
110 EXPECT_TRUE(sent_packets_.back().Parse(data, len));
pbos2d566682015-09-28 09:59:31 -0700111 return true;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000112 }
danilchap162abd32015-12-10 02:39:40 -0800113 bool SendRtcp(const uint8_t* data, size_t len) override { return false; }
danilchap12ba1862016-10-26 02:41:55 -0700114 const RtpPacketReceived& last_sent_packet() { return sent_packets_.back(); }
115 int packets_sent() { return sent_packets_.size(); }
116
pbos@webrtc.org72491b92014-07-10 16:24:54 +0000117 size_t total_bytes_sent_;
Petter Strandmark26bc6692018-05-29 08:43:35 +0200118 PacketOptions last_options_;
danilchap12ba1862016-10-26 02:41:55 -0700119 std::vector<RtpPacketReceived> sent_packets_;
120
121 private:
122 RtpHeaderExtensionMap receivers_extensions_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000123};
124
Elad Alon4a87e1c2017-10-03 16:11:34 +0200125MATCHER_P(SameRtcEventTypeAs, value, "") {
126 return value == arg->GetType();
127}
128
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000129} // namespace
130
sprangebbf8a82015-09-21 15:11:14 -0700131class MockRtpPacketSender : public RtpPacketSender {
132 public:
133 MockRtpPacketSender() {}
134 virtual ~MockRtpPacketSender() {}
135
Peter Boströme23e7372015-10-08 11:44:14 +0200136 MOCK_METHOD6(InsertPacket,
137 void(Priority priority,
sprangebbf8a82015-09-21 15:11:14 -0700138 uint32_t ssrc,
139 uint16_t sequence_number,
140 int64_t capture_time_ms,
141 size_t bytes,
142 bool retransmission));
143};
144
Stefan Holmerf5dca482016-01-27 12:58:51 +0100145class MockTransportSequenceNumberAllocator
146 : public TransportSequenceNumberAllocator {
147 public:
148 MOCK_METHOD0(AllocateSequenceNumber, uint16_t());
149};
150
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200151class MockSendSideDelayObserver : public SendSideDelayObserver {
152 public:
153 MOCK_METHOD3(SendSideDelayUpdated, void(int, int, uint32_t));
154};
155
asapersson35151f32016-05-02 23:44:01 -0700156class MockSendPacketObserver : public SendPacketObserver {
157 public:
158 MOCK_METHOD3(OnSendPacket, void(uint16_t, int64_t, uint32_t));
159};
160
Stefan Holmera246cfb2016-08-23 17:51:42 +0200161class MockTransportFeedbackObserver : public TransportFeedbackObserver {
162 public:
elad.alond12a8e12017-03-23 11:04:48 -0700163 MOCK_METHOD4(AddPacket,
164 void(uint32_t, uint16_t, size_t, const PacedPacketInfo&));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200165 MOCK_METHOD1(OnTransportFeedback, void(const rtcp::TransportFeedback&));
elad.alonf9490002017-03-06 05:32:21 -0800166 MOCK_CONST_METHOD0(GetTransportFeedbackVector, std::vector<PacketFeedback>());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200167};
168
minyue3a407ee2017-04-03 01:10:33 -0700169class MockOverheadObserver : public OverheadObserver {
170 public:
171 MOCK_METHOD1(OnOverheadChanged, void(size_t overhead_bytes_per_packet));
172};
173
174class RtpSenderTest : public ::testing::TestWithParam<bool> {
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000175 protected:
176 RtpSenderTest()
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000177 : fake_clock_(kStartTime),
terelius429c3452016-01-21 05:42:04 -0800178 mock_rtc_event_log_(),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000179 mock_paced_sender_(),
sprangcd349d92016-07-13 09:11:28 -0700180 retransmission_rate_limiter_(&fake_clock_, 1000),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000181 rtp_sender_(),
182 payload_(kPayload),
183 transport_(),
minyue3a407ee2017-04-03 01:10:33 -0700184 kMarkerBit(true),
185 field_trials_(GetParam() ? "WebRTC-SendSideBwe-WithOverhead/Enabled/"
186 : "") {}
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000187
Erik Språng7b52f102018-02-07 14:37:37 +0100188 void SetUp() override { SetUpRtpSender(true, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200189
Erik Språng7b52f102018-02-07 14:37:37 +0100190 void SetUpRtpSender(bool pacer, bool populate_network2) {
asapersson35151f32016-05-02 23:44:01 -0700191 rtp_sender_.reset(new RTPSender(
192 false, &fake_clock_, &transport_, pacer ? &mock_paced_sender_ : nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -0800193 nullptr, &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
sprangcd349d92016-07-13 09:11:28 -0700194 &mock_rtc_event_log_, &send_packet_observer_,
Benjamin Wright192eeec2018-10-17 17:27:25 -0700195 &retransmission_rate_limiter_, nullptr, populate_network2, nullptr,
Johannes Kron9190b822018-10-29 11:22:05 +0100196 false, false));
brandtr9dfff292016-11-14 05:14:50 -0800197 rtp_sender_->SetSequenceNumber(kSeqNum);
danilchap71fead22016-08-18 02:01:49 -0700198 rtp_sender_->SetTimestampOffset(0);
brandtr9dfff292016-11-14 05:14:50 -0800199 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000200 }
201
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000202 SimulatedClock fake_clock_;
stefana23fc622016-07-28 07:56:38 -0700203 testing::NiceMock<MockRtcEventLog> mock_rtc_event_log_;
sprangebbf8a82015-09-21 15:11:14 -0700204 MockRtpPacketSender mock_paced_sender_;
stefana23fc622016-07-28 07:56:38 -0700205 testing::StrictMock<MockTransportSequenceNumberAllocator> seq_num_allocator_;
206 testing::StrictMock<MockSendPacketObserver> send_packet_observer_;
Stefan Holmera246cfb2016-08-23 17:51:42 +0200207 testing::StrictMock<MockTransportFeedbackObserver> feedback_observer_;
sprangcd349d92016-07-13 09:11:28 -0700208 RateLimiter retransmission_rate_limiter_;
kwiberg84be5112016-04-27 01:19:58 -0700209 std::unique_ptr<RTPSender> rtp_sender_;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000210 int payload_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000211 LoopbackTransportTest transport_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000212 const bool kMarkerBit;
minyue3a407ee2017-04-03 01:10:33 -0700213 test::ScopedFieldTrials field_trials_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000214
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000215 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header) {
danilchapd9e62f52016-01-14 14:55:19 -0800216 VerifyRTPHeaderCommon(rtp_header, kMarkerBit, 0);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000217 }
218
219 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header, bool marker_bit) {
danilchapd9e62f52016-01-14 14:55:19 -0800220 VerifyRTPHeaderCommon(rtp_header, marker_bit, 0);
221 }
222
223 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header,
224 bool marker_bit,
225 uint8_t number_of_csrcs) {
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000226 EXPECT_EQ(marker_bit, rtp_header.markerBit);
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000227 EXPECT_EQ(payload_, rtp_header.payloadType);
228 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
229 EXPECT_EQ(kTimestamp, rtp_header.timestamp);
230 EXPECT_EQ(rtp_sender_->SSRC(), rtp_header.ssrc);
danilchapd9e62f52016-01-14 14:55:19 -0800231 EXPECT_EQ(number_of_csrcs, rtp_header.numCSRCs);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000232 EXPECT_EQ(0U, rtp_header.paddingLength);
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000233 }
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000234
danilchapb6f1fb52016-10-19 06:11:39 -0700235 std::unique_ptr<RtpPacketToSend> BuildRtpPacket(int payload_type,
236 bool marker_bit,
237 uint32_t timestamp,
238 int64_t capture_time_ms) {
239 auto packet = rtp_sender_->AllocatePacket();
240 packet->SetPayloadType(payload_type);
241 packet->SetMarker(marker_bit);
242 packet->SetTimestamp(timestamp);
243 packet->set_capture_time_ms(capture_time_ms);
244 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
245 return packet;
246 }
247
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000248 void SendPacket(int64_t capture_time_ms, int payload_length) {
249 uint32_t timestamp = capture_time_ms * 90;
danilchapb6f1fb52016-10-19 06:11:39 -0700250 auto packet =
251 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
252 packet->AllocatePayload(payload_length);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000253
254 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700255 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
256 kAllowRetransmission,
257 RtpPacketSender::kNormalPriority));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000258 }
asapersson35151f32016-05-02 23:44:01 -0700259
260 void SendGenericPayload() {
asapersson35151f32016-05-02 23:44:01 -0700261 const uint32_t kTimestamp = 1234;
262 const uint8_t kPayloadType = 127;
263 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
264 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
265 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
266 0, 1500));
267
Sami Kalliomäki426a80c2018-08-08 11:37:59 +0200268 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700269 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
Stefan Holmera246cfb2016-08-23 17:51:42 +0200270 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +0200271 sizeof(kPayloadData), nullptr, &video_header, nullptr,
spranga8ae6f22017-09-04 07:23:56 -0700272 kDefaultExpectedRetransmissionTimeMs));
asapersson35151f32016-05-02 23:44:01 -0700273 }
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000274};
275
Peter Boströme23e7372015-10-08 11:44:14 +0200276// TODO(pbos): Move tests over from WithoutPacer to RtpSenderTest as this is our
277// default code path.
278class RtpSenderTestWithoutPacer : public RtpSenderTest {
279 public:
Erik Språng7b52f102018-02-07 14:37:37 +0100280 void SetUp() override { SetUpRtpSender(false, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200281};
282
spranga8ae6f22017-09-04 07:23:56 -0700283class TestRtpSenderVideo : public RTPSenderVideo {
284 public:
285 TestRtpSenderVideo(Clock* clock,
286 RTPSender* rtp_sender,
287 FlexfecSender* flexfec_sender)
Benjamin Wright192eeec2018-10-17 17:27:25 -0700288 : RTPSenderVideo(clock, rtp_sender, flexfec_sender, nullptr, false) {}
spranga8ae6f22017-09-04 07:23:56 -0700289 ~TestRtpSenderVideo() override {}
290
291 StorageType GetStorageType(const RTPVideoHeader& header,
292 int32_t retransmission_settings,
293 int64_t expected_retransmission_time_ms) {
294 return RTPSenderVideo::GetStorageType(GetTemporalId(header),
295 retransmission_settings,
296 expected_retransmission_time_ms);
297 }
298};
299
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000300class RtpSenderVideoTest : public RtpSenderTest {
301 protected:
danilchap162abd32015-12-10 02:39:40 -0800302 void SetUp() override {
Peter Boströme23e7372015-10-08 11:44:14 +0200303 // TODO(pbos): Set up to use pacer.
Erik Språng7b52f102018-02-07 14:37:37 +0100304 SetUpRtpSender(false, false);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000305 rtp_sender_video_.reset(
spranga8ae6f22017-09-04 07:23:56 -0700306 new TestRtpSenderVideo(&fake_clock_, rtp_sender_.get(), nullptr));
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000307 }
spranga8ae6f22017-09-04 07:23:56 -0700308 std::unique_ptr<TestRtpSenderVideo> rtp_sender_video_;
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000309};
310
minyue3a407ee2017-04-03 01:10:33 -0700311TEST_P(RtpSenderTestWithoutPacer, AllocatePacketSetCsrc) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200312 // Configure rtp_sender with csrc.
313 std::vector<uint32_t> csrcs;
314 csrcs.push_back(0x23456789);
315 rtp_sender_->SetCsrcs(csrcs);
316
317 auto packet = rtp_sender_->AllocatePacket();
318
319 ASSERT_TRUE(packet);
320 EXPECT_EQ(rtp_sender_->SSRC(), packet->Ssrc());
321 EXPECT_EQ(csrcs, packet->Csrcs());
322}
323
minyue3a407ee2017-04-03 01:10:33 -0700324TEST_P(RtpSenderTestWithoutPacer, AllocatePacketReserveExtensions) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200325 // Configure rtp_sender with extensions.
326 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
327 kRtpExtensionTransmissionTimeOffset,
328 kTransmissionTimeOffsetExtensionId));
329 ASSERT_EQ(
330 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
331 kAbsoluteSendTimeExtensionId));
332 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
333 kAudioLevelExtensionId));
334 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
335 kRtpExtensionTransportSequenceNumber,
336 kTransportSequenceNumberExtensionId));
337 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
338 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
339
340 auto packet = rtp_sender_->AllocatePacket();
341
342 ASSERT_TRUE(packet);
343 // Preallocate BWE extensions RtpSender set itself.
344 EXPECT_TRUE(packet->HasExtension<TransmissionOffset>());
345 EXPECT_TRUE(packet->HasExtension<AbsoluteSendTime>());
346 EXPECT_TRUE(packet->HasExtension<TransportSequenceNumber>());
347 // Do not allocate media specific extensions.
348 EXPECT_FALSE(packet->HasExtension<AudioLevel>());
349 EXPECT_FALSE(packet->HasExtension<VideoOrientation>());
350}
351
minyue3a407ee2017-04-03 01:10:33 -0700352TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberAdvanceSequenceNumber) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200353 auto packet = rtp_sender_->AllocatePacket();
354 ASSERT_TRUE(packet);
355 const uint16_t sequence_number = rtp_sender_->SequenceNumber();
356
357 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
358
359 EXPECT_EQ(sequence_number, packet->SequenceNumber());
360 EXPECT_EQ(sequence_number + 1, rtp_sender_->SequenceNumber());
361}
362
minyue3a407ee2017-04-03 01:10:33 -0700363TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberFailsOnNotSending) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200364 auto packet = rtp_sender_->AllocatePacket();
365 ASSERT_TRUE(packet);
366
367 rtp_sender_->SetSendingMediaStatus(false);
368 EXPECT_FALSE(rtp_sender_->AssignSequenceNumber(packet.get()));
369}
370
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100371TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberMayAllowPaddingOnVideo) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200372 constexpr size_t kPaddingSize = 100;
373 auto packet = rtp_sender_->AllocatePacket();
374 ASSERT_TRUE(packet);
375
philipel8aadd502017-02-23 02:56:13 -0800376 ASSERT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200377 packet->SetMarker(false);
378 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100379 // Packet without marker bit doesn't allow padding on video stream.
philipel8aadd502017-02-23 02:56:13 -0800380 EXPECT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200381
382 packet->SetMarker(true);
383 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
384 // Packet with marker bit allows send padding.
philipel8aadd502017-02-23 02:56:13 -0800385 EXPECT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200386}
387
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100388TEST_P(RtpSenderTest, AssignSequenceNumberAllowsPaddingOnAudio) {
389 MockTransport transport;
390 const bool kEnableAudio = true;
391 rtp_sender_.reset(new RTPSender(
392 kEnableAudio, &fake_clock_, &transport, &mock_paced_sender_, nullptr,
393 nullptr, nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Johannes Kron9190b822018-10-29 11:22:05 +0100394 nullptr, &retransmission_rate_limiter_, nullptr, false, nullptr, false,
395 false));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100396 rtp_sender_->SetTimestampOffset(0);
397 rtp_sender_->SetSSRC(kSsrc);
398
399 std::unique_ptr<RtpPacketToSend> audio_packet = rtp_sender_->AllocatePacket();
400 // Padding on audio stream allowed regardless of marker in the last packet.
401 audio_packet->SetMarker(false);
402 audio_packet->SetPayloadType(kPayload);
403 rtp_sender_->AssignSequenceNumber(audio_packet.get());
404
405 const size_t kPaddingSize = 59;
406 EXPECT_CALL(transport, SendRtp(_, kPaddingSize + kRtpHeaderSize, _))
407 .WillOnce(testing::Return(true));
408 EXPECT_EQ(kPaddingSize,
409 rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
410
411 // Requested padding size is too small, will send a larger one.
412 const size_t kMinPaddingSize = 50;
413 EXPECT_CALL(transport, SendRtp(_, kMinPaddingSize + kRtpHeaderSize, _))
414 .WillOnce(testing::Return(true));
Yves Gerey665174f2018-06-19 15:03:05 +0200415 EXPECT_EQ(kMinPaddingSize, rtp_sender_->TimeToSendPadding(kMinPaddingSize - 5,
416 PacedPacketInfo()));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100417}
418
minyue3a407ee2017-04-03 01:10:33 -0700419TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberSetPaddingTimestamps) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200420 constexpr size_t kPaddingSize = 100;
421 auto packet = rtp_sender_->AllocatePacket();
422 ASSERT_TRUE(packet);
423 packet->SetMarker(true);
424 packet->SetTimestamp(kTimestamp);
425
426 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
philipel8aadd502017-02-23 02:56:13 -0800427 ASSERT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200428
429 ASSERT_EQ(1u, transport_.sent_packets_.size());
danilchap12ba1862016-10-26 02:41:55 -0700430 // Verify padding packet timestamp.
431 EXPECT_EQ(kTimestamp, transport_.last_sent_packet().Timestamp());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200432}
433
minyue3a407ee2017-04-03 01:10:33 -0700434TEST_P(RtpSenderTestWithoutPacer,
435 TransportFeedbackObserverGetsCorrectByteCount) {
436 constexpr int kRtpOverheadBytesPerPacket = 12 + 8;
437 testing::NiceMock<MockOverheadObserver> mock_overhead_observer;
438 rtp_sender_.reset(new RTPSender(
439 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
440 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Benjamin Wright192eeec2018-10-17 17:27:25 -0700441 nullptr, &retransmission_rate_limiter_, &mock_overhead_observer, false,
Johannes Kron9190b822018-10-29 11:22:05 +0100442 nullptr, false, false));
minyue3a407ee2017-04-03 01:10:33 -0700443 rtp_sender_->SetSSRC(kSsrc);
444 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
445 kRtpExtensionTransportSequenceNumber,
446 kTransportSequenceNumberExtensionId));
447 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
448 .WillOnce(testing::Return(kTransportSequenceNumber));
449
450 const size_t expected_bytes =
451 GetParam() ? sizeof(kPayloadData) + kGenericHeaderLength +
452 kRtpOverheadBytesPerPacket
453 : sizeof(kPayloadData) + kGenericHeaderLength;
454
455 EXPECT_CALL(feedback_observer_,
456 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber,
457 expected_bytes, PacedPacketInfo()))
458 .Times(1);
459 EXPECT_CALL(mock_overhead_observer,
460 OnOverheadChanged(kRtpOverheadBytesPerPacket))
461 .Times(1);
462 SendGenericPayload();
463}
464
465TEST_P(RtpSenderTestWithoutPacer, SendsPacketsWithTransportSequenceNumber) {
Stefan Holmera246cfb2016-08-23 17:51:42 +0200466 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800467 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
468 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Benjamin Wright192eeec2018-10-17 17:27:25 -0700469 &send_packet_observer_, &retransmission_rate_limiter_, nullptr, false,
Johannes Kron9190b822018-10-29 11:22:05 +0100470 nullptr, false, false));
nisse7d59f6b2017-02-21 03:40:24 -0800471 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100472 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
473 kRtpExtensionTransportSequenceNumber,
474 kTransportSequenceNumberExtensionId));
475
Stefan Holmerf5dca482016-01-27 12:58:51 +0100476 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
477 .WillOnce(testing::Return(kTransportSequenceNumber));
asapersson35151f32016-05-02 23:44:01 -0700478 EXPECT_CALL(send_packet_observer_,
479 OnSendPacket(kTransportSequenceNumber, _, _))
480 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700481
482 EXPECT_CALL(feedback_observer_,
483 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
484 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200485 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700486
487 SendGenericPayload();
Stefan Holmerf5dca482016-01-27 12:58:51 +0100488
danilchap12ba1862016-10-26 02:41:55 -0700489 const auto& packet = transport_.last_sent_packet();
490 uint16_t transport_seq_no;
491 ASSERT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
492 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200493 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200494 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200495}
496
497TEST_P(RtpSenderTestWithoutPacer, PacketOptionsNoRetransmission) {
498 rtp_sender_.reset(new RTPSender(
499 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
500 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Benjamin Wright192eeec2018-10-17 17:27:25 -0700501 &send_packet_observer_, &retransmission_rate_limiter_, nullptr, false,
Johannes Kron9190b822018-10-29 11:22:05 +0100502 nullptr, false, false));
Petter Strandmark26bc6692018-05-29 08:43:35 +0200503 rtp_sender_->SetSSRC(kSsrc);
504
505 SendGenericPayload();
506
507 EXPECT_FALSE(transport_.last_options_.is_retransmit);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100508}
509
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200510TEST_P(RtpSenderTestWithoutPacer,
511 SetsIncludedInFeedbackWhenTransportSequenceNumberExtensionIsRegistered) {
512 SetUpRtpSender(false, false);
513 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber,
514 kTransportSequenceNumberExtensionId);
515 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
516 .WillOnce(testing::Return(kTransportSequenceNumber));
517 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
stefana23fc622016-07-28 07:56:38 -0700518 SendGenericPayload();
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200519 EXPECT_TRUE(transport_.last_options_.included_in_feedback);
520}
521
522TEST_P(
523 RtpSenderTestWithoutPacer,
524 SetsIncludedInAllocationWhenTransportSequenceNumberExtensionIsRegistered) {
525 SetUpRtpSender(false, false);
526 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber,
527 kTransportSequenceNumberExtensionId);
528 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
529 .WillOnce(testing::Return(kTransportSequenceNumber));
530 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
531 SendGenericPayload();
532 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
533}
534
535TEST_P(RtpSenderTestWithoutPacer,
536 SetsIncludedInAllocationWhenForcedAsPartOfAllocation) {
537 SetUpRtpSender(false, false);
538 rtp_sender_->SetAsPartOfAllocation(true);
539 SendGenericPayload();
540 EXPECT_FALSE(transport_.last_options_.included_in_feedback);
541 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
542}
543
544TEST_P(RtpSenderTestWithoutPacer, DoesnSetIncludedInAllocationByDefault) {
545 SetUpRtpSender(false, false);
546 SendGenericPayload();
547 EXPECT_FALSE(transport_.last_options_.included_in_feedback);
548 EXPECT_FALSE(transport_.last_options_.included_in_allocation);
stefana23fc622016-07-28 07:56:38 -0700549}
asapersson35151f32016-05-02 23:44:01 -0700550
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200551TEST_P(RtpSenderTestWithoutPacer, OnSendSideDelayUpdated) {
552 testing::StrictMock<MockSendSideDelayObserver> send_side_delay_observer_;
Benjamin Wright192eeec2018-10-17 17:27:25 -0700553 rtp_sender_.reset(new RTPSender(
554 false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
555 nullptr, nullptr, &send_side_delay_observer_, &mock_rtc_event_log_,
Johannes Kron9190b822018-10-29 11:22:05 +0100556 nullptr, nullptr, nullptr, false, nullptr, false, false));
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200557 rtp_sender_->SetSSRC(kSsrc);
558
559 const uint8_t kPayloadType = 127;
560 const uint32_t kCaptureTimeMsToRtpTimestamp = 90; // 90 kHz clock
561 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
562 RTPVideoHeader video_header;
563 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType,
564 1000 * kCaptureTimeMsToRtpTimestamp,
565 0, 1500));
566
567 // Send packet with 10 ms send-side delay. The average and max should be 10
568 // ms.
569 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(10, 10, kSsrc))
570 .Times(1);
571 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
572 fake_clock_.AdvanceTimeMilliseconds(10);
573 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
574 kVideoFrameKey, kPayloadType,
575 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
576 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
577 kDefaultExpectedRetransmissionTimeMs));
578
579 // Send another packet with 20 ms delay. The average
580 // and max should be 15 and 20 ms respectively.
581 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(15, 20, kSsrc))
582 .Times(1);
583 fake_clock_.AdvanceTimeMilliseconds(10);
584 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
585 kVideoFrameKey, kPayloadType,
586 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
587 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
588 kDefaultExpectedRetransmissionTimeMs));
589
590 // Send another packet at the same time, which replaces the last packet.
591 // Since this packet has 0 ms delay, the average is now 5 ms and max is 10 ms.
592 // TODO(terelius): Is is not clear that this is the right behavior.
593 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(5, 10, kSsrc))
594 .Times(1);
595 capture_time_ms = fake_clock_.TimeInMilliseconds();
596 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
597 kVideoFrameKey, kPayloadType,
598 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
599 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
600 kDefaultExpectedRetransmissionTimeMs));
601
602 // Send a packet 1 second later. The earlier packets should have timed
603 // out, so both max and average should be the delay of this packet.
604 fake_clock_.AdvanceTimeMilliseconds(1000);
605 capture_time_ms = fake_clock_.TimeInMilliseconds();
606 fake_clock_.AdvanceTimeMilliseconds(1);
607 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(1, 1, kSsrc))
608 .Times(1);
609 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
610 kVideoFrameKey, kPayloadType,
611 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
612 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
613 kDefaultExpectedRetransmissionTimeMs));
614}
615
minyue3a407ee2017-04-03 01:10:33 -0700616TEST_P(RtpSenderTestWithoutPacer, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700617 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
618 kRtpExtensionTransportSequenceNumber,
619 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700620 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
621 .WillOnce(testing::Return(kTransportSequenceNumber));
622 EXPECT_CALL(send_packet_observer_,
623 OnSendPacket(kTransportSequenceNumber, _, _))
624 .Times(1);
625
626 SendGenericPayload();
627}
628
minyue3a407ee2017-04-03 01:10:33 -0700629TEST_P(RtpSenderTest, SendsPacketsWithTransportSequenceNumber) {
michaelt4da30442016-11-17 01:38:43 -0800630 rtp_sender_.reset(new RTPSender(
631 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
632 &seq_num_allocator_, &feedback_observer_, nullptr, nullptr, nullptr,
633 &mock_rtc_event_log_, &send_packet_observer_,
Johannes Kron9190b822018-10-29 11:22:05 +0100634 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
brandtr9dfff292016-11-14 05:14:50 -0800635 rtp_sender_->SetSequenceNumber(kSeqNum);
636 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200637 rtp_sender_->SetStorePacketsStatus(true, 10);
638 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
639 kRtpExtensionTransportSequenceNumber,
640 kTransportSequenceNumberExtensionId));
641
brandtr9dfff292016-11-14 05:14:50 -0800642 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200643 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
644 .WillOnce(testing::Return(kTransportSequenceNumber));
645 EXPECT_CALL(send_packet_observer_,
646 OnSendPacket(kTransportSequenceNumber, _, _))
647 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700648 EXPECT_CALL(feedback_observer_,
649 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
650 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200651 .Times(1);
652
653 SendGenericPayload();
philipel8aadd502017-02-23 02:56:13 -0800654 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
655 fake_clock_.TimeInMilliseconds(), false,
656 PacedPacketInfo());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200657
danilchap12ba1862016-10-26 02:41:55 -0700658 const auto& packet = transport_.last_sent_packet();
659 uint16_t transport_seq_no;
660 EXPECT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
661 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200662 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200663}
664
Erik Språng7b52f102018-02-07 14:37:37 +0100665TEST_P(RtpSenderTest, WritesPacerExitToTimingExtension) {
ilnik04f4d122017-06-19 07:18:55 -0700666 rtp_sender_->SetStorePacketsStatus(true, 10);
667 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
668 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
669 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
670 auto packet = rtp_sender_->AllocatePacket();
671 packet->SetPayloadType(kPayload);
672 packet->SetMarker(true);
673 packet->SetTimestamp(kTimestamp);
674 packet->set_capture_time_ms(capture_time_ms);
ilnik2edc6842017-07-06 03:06:50 -0700675 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
ilnik04f4d122017-06-19 07:18:55 -0700676 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
677 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
678 size_t packet_size = packet->size();
ilnik04f4d122017-06-19 07:18:55 -0700679
680 const int kStoredTimeInMs = 100;
Erik Språng7b52f102018-02-07 14:37:37 +0100681 {
682 EXPECT_CALL(
683 mock_paced_sender_,
684 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _));
685 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
686 kAllowRetransmission,
687 RtpPacketSender::kNormalPriority));
688 }
ilnik04f4d122017-06-19 07:18:55 -0700689 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
Erik Språng7b52f102018-02-07 14:37:37 +0100690 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
691 PacedPacketInfo());
ilnik04f4d122017-06-19 07:18:55 -0700692 EXPECT_EQ(1, transport_.packets_sent());
693 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
694
danilchapce251812017-09-11 12:24:41 -0700695 VideoSendTiming video_timing;
696 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
697 &video_timing));
698 EXPECT_EQ(kStoredTimeInMs, video_timing.pacer_exit_delta_ms);
Erik Språng7b52f102018-02-07 14:37:37 +0100699}
ilnik04f4d122017-06-19 07:18:55 -0700700
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100701TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtensionWithPacer) {
702 SetUpRtpSender(/*pacer=*/true, /*populate_network2=*/true);
Erik Språng7b52f102018-02-07 14:37:37 +0100703 rtp_sender_->SetStorePacketsStatus(true, 10);
704 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
705 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
706 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
707 auto packet = rtp_sender_->AllocatePacket();
708 packet->SetPayloadType(kPayload);
709 packet->SetMarker(true);
710 packet->SetTimestamp(kTimestamp);
711 packet->set_capture_time_ms(capture_time_ms);
712 const uint16_t kPacerExitMs = 1234u;
713 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, kPacerExitMs, 0u, 0u, true};
714 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
715 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
716 size_t packet_size = packet->size();
717
718 const int kStoredTimeInMs = 100;
719 {
720 EXPECT_CALL(
721 mock_paced_sender_,
722 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _));
723 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
724 kAllowRetransmission,
725 RtpPacketSender::kNormalPriority));
726 }
ilnik04f4d122017-06-19 07:18:55 -0700727 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
728 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
729 PacedPacketInfo());
Erik Språng7b52f102018-02-07 14:37:37 +0100730 EXPECT_EQ(1, transport_.packets_sent());
ilnik04f4d122017-06-19 07:18:55 -0700731 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
732
Erik Språng7b52f102018-02-07 14:37:37 +0100733 VideoSendTiming video_timing;
danilchapce251812017-09-11 12:24:41 -0700734 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
735 &video_timing));
Erik Språng7b52f102018-02-07 14:37:37 +0100736 EXPECT_EQ(kStoredTimeInMs, video_timing.network2_timestamp_delta_ms);
737 EXPECT_EQ(kPacerExitMs, video_timing.pacer_exit_delta_ms);
ilnik04f4d122017-06-19 07:18:55 -0700738}
739
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100740TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtensionWithoutPacer) {
741 SetUpRtpSender(/*pacer=*/false, /*populate_network2=*/true);
742 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
743 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
744 auto packet = rtp_sender_->AllocatePacket();
745 packet->SetMarker(true);
746 packet->set_capture_time_ms(fake_clock_.TimeInMilliseconds());
747 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
748 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
749 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
750
751 const int kPropagateTimeMs = 10;
752 fake_clock_.AdvanceTimeMilliseconds(kPropagateTimeMs);
753
754 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
755 kAllowRetransmission,
756 RtpPacketSender::kNormalPriority));
757
758 EXPECT_EQ(1, transport_.packets_sent());
759 absl::optional<VideoSendTiming> video_timing =
760 transport_.last_sent_packet().GetExtension<VideoTimingExtension>();
761 ASSERT_TRUE(video_timing);
762 EXPECT_EQ(kPropagateTimeMs, video_timing->network2_timestamp_delta_ms);
763}
764
minyue3a407ee2017-04-03 01:10:33 -0700765TEST_P(RtpSenderTest, TrafficSmoothingWithExtensions) {
Peter Boströme23e7372015-10-08 11:44:14 +0200766 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800767 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200768 EXPECT_CALL(mock_rtc_event_log_,
769 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000770
pwestin@webrtc.orgc66e8b32012-11-07 17:01:04 +0000771 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000772 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800773 kRtpExtensionTransmissionTimeOffset,
774 kTransmissionTimeOffsetExtensionId));
775 EXPECT_EQ(
776 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
777 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000778 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700779 auto packet =
780 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
781 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000782
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000783 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700784 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
785 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700786 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000787
danilchap12ba1862016-10-26 02:41:55 -0700788 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000789
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000790 const int kStoredTimeInMs = 100;
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000791 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000792
brandtr9dfff292016-11-14 05:14:50 -0800793 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800794 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000795
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000796 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700797 EXPECT_EQ(1, transport_.packets_sent());
798 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
799
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000800 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700801 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000802
803 // Verify transmission time offset.
804 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000805 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000806 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000807 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000808}
809
minyue3a407ee2017-04-03 01:10:33 -0700810TEST_P(RtpSenderTest, TrafficSmoothingRetransmits) {
Peter Boströme23e7372015-10-08 11:44:14 +0200811 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800812 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200813 EXPECT_CALL(mock_rtc_event_log_,
814 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000815
816 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000817 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800818 kRtpExtensionTransmissionTimeOffset,
819 kTransmissionTimeOffsetExtensionId));
820 EXPECT_EQ(
821 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
822 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000823 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700824 auto packet =
825 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
826 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000827
828 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700829 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
830 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700831 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000832
danilchap12ba1862016-10-26 02:41:55 -0700833 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000834
terelius5d332ac2016-01-14 14:37:39 -0800835 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800836 kSsrc, kSeqNum, _, _, _));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000837
838 const int kStoredTimeInMs = 100;
839 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
840
danilchapb6f1fb52016-10-19 06:11:39 -0700841 EXPECT_EQ(static_cast<int>(packet_size), rtp_sender_->ReSendPacket(kSeqNum));
danilchap12ba1862016-10-26 02:41:55 -0700842 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000843
brandtr9dfff292016-11-14 05:14:50 -0800844 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800845 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000846
847 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700848 EXPECT_EQ(1, transport_.packets_sent());
849 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000850
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000851 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700852 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000853
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000854 // Verify transmission time offset.
855 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000856 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000857 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
858 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
859}
860
861// This test sends 1 regular video packet, then 4 padding packets, and then
862// 1 more regular packet.
minyue3a407ee2017-04-03 01:10:33 -0700863TEST_P(RtpSenderTest, SendPadding) {
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000864 // Make all (non-padding) packets go to send queue.
terelius5d332ac2016-01-14 14:37:39 -0800865 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800866 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200867 EXPECT_CALL(mock_rtc_event_log_,
868 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
869 .Times(1 + 4 + 1);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000870
871 uint16_t seq_num = kSeqNum;
872 uint32_t timestamp = kTimestamp;
873 rtp_sender_->SetStorePacketsStatus(true, 10);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000874 size_t rtp_header_len = kRtpHeaderSize;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000875 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800876 kRtpExtensionTransmissionTimeOffset,
877 kTransmissionTimeOffsetExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000878 rtp_header_len += 4; // 4 bytes extension.
danilchap162abd32015-12-10 02:39:40 -0800879 EXPECT_EQ(
880 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
881 kAbsoluteSendTimeExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000882 rtp_header_len += 4; // 4 bytes extension.
883 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
884
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000885 webrtc::RTPHeader rtp_header;
886
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000887 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700888 auto packet =
889 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200890 const uint32_t media_packet_timestamp = timestamp;
danilchapb6f1fb52016-10-19 06:11:39 -0700891 size_t packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000892
893 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700894 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
895 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700896 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000897
898 int total_packets_sent = 0;
danilchap12ba1862016-10-26 02:41:55 -0700899 EXPECT_EQ(total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000900
901 const int kStoredTimeInMs = 100;
902 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
brandtr9dfff292016-11-14 05:14:50 -0800903 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800904 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000905 // Packet should now be sent. This test doesn't verify the regular video
906 // packet, since it is tested in another test.
danilchap12ba1862016-10-26 02:41:55 -0700907 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000908 timestamp += 90 * kStoredTimeInMs;
909
910 // Send padding 4 times, waiting 50 ms between each.
911 for (int i = 0; i < 4; ++i) {
912 const int kPaddingPeriodMs = 50;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000913 const size_t kPaddingBytes = 100;
914 const size_t kMaxPaddingLength = 224; // Value taken from rtp_sender.cc.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000915 // Padding will be forced to full packets.
philipelc7bf32a2017-02-17 03:59:43 -0800916 EXPECT_EQ(kMaxPaddingLength,
philipel8aadd502017-02-23 02:56:13 -0800917 rtp_sender_->TimeToSendPadding(kPaddingBytes, PacedPacketInfo()));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000918
919 // Process send bucket. Padding should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700920 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000921 EXPECT_EQ(kMaxPaddingLength + rtp_header_len,
danilchap12ba1862016-10-26 02:41:55 -0700922 transport_.last_sent_packet().size());
923
924 transport_.last_sent_packet().GetHeader(&rtp_header);
pbosbd2522a2015-07-01 05:35:53 -0700925 EXPECT_EQ(kMaxPaddingLength, rtp_header.paddingLength);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000926
Stefan Holmer586b19b2015-09-18 11:14:31 +0200927 // Verify sequence number and timestamp. The timestamp should be the same
928 // as the last media packet.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000929 EXPECT_EQ(seq_num++, rtp_header.sequenceNumber);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200930 EXPECT_EQ(media_packet_timestamp, rtp_header.timestamp);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000931 // Verify transmission time offset.
Stefan Holmer586b19b2015-09-18 11:14:31 +0200932 int offset = timestamp - media_packet_timestamp;
933 EXPECT_EQ(offset, rtp_header.extension.transmissionTimeOffset);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000934 uint64_t expected_send_time =
935 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
936 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
937 fake_clock_.AdvanceTimeMilliseconds(kPaddingPeriodMs);
938 timestamp += 90 * kPaddingPeriodMs;
939 }
940
941 // Send a regular video packet again.
942 capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700943 packet = BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
944 packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000945
brandtr9dfff292016-11-14 05:14:50 -0800946 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
947 kSsrc, seq_num, _, _, _));
terelius5d332ac2016-01-14 14:37:39 -0800948
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000949 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700950 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
951 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700952 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000953
brandtr9dfff292016-11-14 05:14:50 -0800954 rtp_sender_->TimeToSendPacket(kSsrc, seq_num, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800955 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000956 // Process send bucket.
danilchap12ba1862016-10-26 02:41:55 -0700957 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
958 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
959 transport_.last_sent_packet().GetHeader(&rtp_header);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000960
961 // Verify sequence number and timestamp.
962 EXPECT_EQ(seq_num, rtp_header.sequenceNumber);
963 EXPECT_EQ(timestamp, rtp_header.timestamp);
964 // Verify transmission time offset. This packet is sent without delay.
965 EXPECT_EQ(0, rtp_header.extension.transmissionTimeOffset);
966 uint64_t expected_send_time =
967 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000968 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000969}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000970
minyue3a407ee2017-04-03 01:10:33 -0700971TEST_P(RtpSenderTest, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700972 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
973 kRtpExtensionTransportSequenceNumber,
974 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700975 rtp_sender_->SetStorePacketsStatus(true, 10);
976
977 EXPECT_CALL(send_packet_observer_,
978 OnSendPacket(kTransportSequenceNumber, _, _))
979 .Times(1);
980 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
981 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800982 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
983 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700984
985 SendGenericPayload(); // Packet passed to pacer.
986 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -0800987 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
988 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800989 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700990 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700991}
992
minyue3a407ee2017-04-03 01:10:33 -0700993TEST_P(RtpSenderTest, OnSendPacketNotUpdatedForRetransmits) {
stefana23fc622016-07-28 07:56:38 -0700994 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
995 kRtpExtensionTransportSequenceNumber,
996 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700997 rtp_sender_->SetStorePacketsStatus(true, 10);
998
999 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
1000 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
1001 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -08001002 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
1003 .Times(1);
asapersson35151f32016-05-02 23:44:01 -07001004
1005 SendGenericPayload(); // Packet passed to pacer.
1006 const bool kIsRetransmit = true;
brandtr9dfff292016-11-14 05:14:50 -08001007 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
1008 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -08001009 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -07001010 EXPECT_EQ(1, transport_.packets_sent());
Petter Strandmark26bc6692018-05-29 08:43:35 +02001011 EXPECT_TRUE(transport_.last_options_.is_retransmit);
asapersson35151f32016-05-02 23:44:01 -07001012}
1013
minyue3a407ee2017-04-03 01:10:33 -07001014TEST_P(RtpSenderTest, OnSendPacketNotUpdatedWithoutSeqNumAllocator) {
asapersson35151f32016-05-02 23:44:01 -07001015 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -08001016 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
asapersson35151f32016-05-02 23:44:01 -07001017 nullptr /* TransportSequenceNumberAllocator */, nullptr, nullptr, nullptr,
michaelt4da30442016-11-17 01:38:43 -08001018 nullptr, nullptr, &send_packet_observer_, &retransmission_rate_limiter_,
Johannes Kron9190b822018-10-29 11:22:05 +01001019 nullptr, false, nullptr, false, false));
brandtr9dfff292016-11-14 05:14:50 -08001020 rtp_sender_->SetSequenceNumber(kSeqNum);
1021 rtp_sender_->SetSSRC(kSsrc);
stefana23fc622016-07-28 07:56:38 -07001022 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1023 kRtpExtensionTransportSequenceNumber,
1024 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -07001025 rtp_sender_->SetSequenceNumber(kSeqNum);
1026 rtp_sender_->SetStorePacketsStatus(true, 10);
1027
1028 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
brandtr9dfff292016-11-14 05:14:50 -08001029 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
1030 .Times(1);
asapersson35151f32016-05-02 23:44:01 -07001031
1032 SendGenericPayload(); // Packet passed to pacer.
1033 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -08001034 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
1035 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -08001036 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -07001037 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -07001038}
1039
minyue3a407ee2017-04-03 01:10:33 -07001040TEST_P(RtpSenderTest, SendRedundantPayloads) {
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001041 MockTransport transport;
terelius429c3452016-01-21 05:42:04 -08001042 rtp_sender_.reset(new RTPSender(
asapersson35151f32016-05-02 23:44:01 -07001043 false, &fake_clock_, &transport, &mock_paced_sender_, nullptr, nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -08001044 nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_, nullptr,
Johannes Kron9190b822018-10-29 11:22:05 +01001045 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001046 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr9dfff292016-11-14 05:14:50 -08001047 rtp_sender_->SetSSRC(kSsrc);
Shao Changbine62202f2015-04-21 20:24:50 +08001048 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001049
1050 uint16_t seq_num = kSeqNum;
1051 rtp_sender_->SetStorePacketsStatus(true, 10);
wu@webrtc.orgebdb0e32014-03-06 23:49:08 +00001052 int32_t rtp_header_len = kRtpHeaderSize;
danilchap162abd32015-12-10 02:39:40 -08001053 EXPECT_EQ(
1054 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
1055 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001056 rtp_header_len += 4; // 4 bytes extension.
1057 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
1058
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +00001059 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
stefan@webrtc.orgef927552014-06-05 08:25:29 +00001060 rtp_sender_->SetRtxSsrc(1234);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001061
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001062 const size_t kNumPayloadSizes = 10;
danilchap162abd32015-12-10 02:39:40 -08001063 const size_t kPayloadSizes[kNumPayloadSizes] = {500, 550, 600, 650, 700,
1064 750, 800, 850, 900, 950};
terelius5d332ac2016-01-14 14:37:39 -08001065 // Expect all packets go through the pacer.
1066 EXPECT_CALL(mock_paced_sender_,
brandtr9dfff292016-11-14 05:14:50 -08001067 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _))
terelius5d332ac2016-01-14 14:37:39 -08001068 .Times(kNumPayloadSizes);
Elad Alon4a87e1c2017-10-03 16:11:34 +02001069 EXPECT_CALL(mock_rtc_event_log_,
1070 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -08001071 .Times(kNumPayloadSizes);
1072
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001073 // Send 10 packets of increasing size.
1074 for (size_t i = 0; i < kNumPayloadSizes; ++i) {
1075 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
stefan1d8a5062015-10-02 03:39:33 -07001076 EXPECT_CALL(transport, SendRtp(_, _, _)).WillOnce(testing::Return(true));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001077 SendPacket(capture_time_ms, kPayloadSizes[i]);
brandtr9dfff292016-11-14 05:14:50 -08001078 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -08001079 PacedPacketInfo());
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001080 fake_clock_.AdvanceTimeMilliseconds(33);
1081 }
terelius429c3452016-01-21 05:42:04 -08001082
Elad Alon4a87e1c2017-10-03 16:11:34 +02001083 EXPECT_CALL(mock_rtc_event_log_,
1084 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -08001085 .Times(::testing::AtLeast(4));
1086
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001087 // The amount of padding to send it too small to send a payload packet.
stefan1d8a5062015-10-02 03:39:33 -07001088 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
pbos2d566682015-09-28 09:59:31 -07001089 .WillOnce(testing::Return(true));
philipela1ed0b32016-06-01 06:31:17 -07001090 EXPECT_EQ(kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -08001091 rtp_sender_->TimeToSendPadding(49, PacedPacketInfo()));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001092
Petter Strandmark26bc6692018-05-29 08:43:35 +02001093 PacketOptions options;
Peter Boströmac547a62015-09-17 23:03:57 +02001094 EXPECT_CALL(transport,
stefan1d8a5062015-10-02 03:39:33 -07001095 SendRtp(_, kPayloadSizes[0] + rtp_header_len + kRtxHeaderSize, _))
Yves Gerey665174f2018-06-19 15:03:05 +02001096 .WillOnce(
1097 testing::DoAll(testing::SaveArg<2>(&options), testing::Return(true)));
philipela1ed0b32016-06-01 06:31:17 -07001098 EXPECT_EQ(kPayloadSizes[0],
philipel8aadd502017-02-23 02:56:13 -08001099 rtp_sender_->TimeToSendPadding(500, PacedPacketInfo()));
Petter Strandmark26bc6692018-05-29 08:43:35 +02001100 EXPECT_TRUE(options.is_retransmit);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001101
Yves Gerey665174f2018-06-19 15:03:05 +02001102 EXPECT_CALL(transport, SendRtp(_,
1103 kPayloadSizes[kNumPayloadSizes - 1] +
1104 rtp_header_len + kRtxHeaderSize,
stefan1d8a5062015-10-02 03:39:33 -07001105 _))
pbos2d566682015-09-28 09:59:31 -07001106 .WillOnce(testing::Return(true));
Petter Strandmark26bc6692018-05-29 08:43:35 +02001107
1108 options.is_retransmit = false;
stefan1d8a5062015-10-02 03:39:33 -07001109 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
Yves Gerey665174f2018-06-19 15:03:05 +02001110 .WillOnce(
1111 testing::DoAll(testing::SaveArg<2>(&options), testing::Return(true)));
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001112 EXPECT_EQ(kPayloadSizes[kNumPayloadSizes - 1] + kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -08001113 rtp_sender_->TimeToSendPadding(999, PacedPacketInfo()));
Petter Strandmark26bc6692018-05-29 08:43:35 +02001114 EXPECT_FALSE(options.is_retransmit);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001115}
1116
minyue3a407ee2017-04-03 01:10:33 -07001117TEST_P(RtpSenderTestWithoutPacer, SendGenericVideo) {
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001118 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1119 const uint8_t payload_type = 127;
1120 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1121 0, 1500));
1122 uint8_t payload[] = {47, 11, 32, 93, 89};
1123
1124 // Send keyframe
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001125 RTPVideoHeader video_header;
spranga8ae6f22017-09-04 07:23:56 -07001126 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1127 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001128 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001129
danilchap96c15872016-11-21 01:35:29 -08001130 auto sent_payload = transport_.last_sent_packet().payload();
1131 uint8_t generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001132 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
1133 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -08001134 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001135
1136 // Send delta frame
1137 payload[0] = 13;
1138 payload[1] = 42;
1139 payload[4] = 13;
1140
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001141 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1142 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001143 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001144
danilchap96c15872016-11-21 01:35:29 -08001145 sent_payload = transport_.last_sent_packet().payload();
1146 generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001147 EXPECT_FALSE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
1148 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -08001149 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001150}
1151
minyue3a407ee2017-04-03 01:10:33 -07001152TEST_P(RtpSenderTest, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -08001153 constexpr int kMediaPayloadType = 127;
1154 constexpr int kFlexfecPayloadType = 118;
1155 constexpr uint32_t kMediaSsrc = 1234;
1156 constexpr uint32_t kFlexfecSsrc = 5678;
1157 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001158 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -08001159 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001160 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001161 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001162
1163 // Reset |rtp_sender_| to use FlexFEC.
michaelt4da30442016-11-17 01:38:43 -08001164 rtp_sender_.reset(new RTPSender(
1165 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1166 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1167 &mock_rtc_event_log_, &send_packet_observer_,
Johannes Kron9190b822018-10-29 11:22:05 +01001168 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
brandtrdbdb3f12016-11-10 05:04:48 -08001169 rtp_sender_->SetSSRC(kMediaSsrc);
1170 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001171 rtp_sender_->SetStorePacketsStatus(true, 10);
1172
1173 // Parameters selected to generate a single FEC packet per media packet.
1174 FecProtectionParams params;
1175 params.fec_rate = 15;
1176 params.max_fec_frames = 1;
1177 params.fec_mask_type = kFecMaskRandom;
1178 rtp_sender_->SetFecParameters(params, params);
1179
brandtr9dfff292016-11-14 05:14:50 -08001180 EXPECT_CALL(mock_paced_sender_,
1181 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
1182 _, _, false));
1183 uint16_t flexfec_seq_num;
brandtrdbdb3f12016-11-10 05:04:48 -08001184 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
brandtr9dfff292016-11-14 05:14:50 -08001185 kFlexfecSsrc, _, _, _, false))
1186 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
brandtrdbdb3f12016-11-10 05:04:48 -08001187 SendGenericPayload();
Elad Alon4a87e1c2017-10-03 16:11:34 +02001188 EXPECT_CALL(mock_rtc_event_log_,
1189 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1190 .Times(2);
philipel8aadd502017-02-23 02:56:13 -08001191 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
1192 fake_clock_.TimeInMilliseconds(),
1193 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -08001194 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
1195 fake_clock_.TimeInMilliseconds(),
philipel8aadd502017-02-23 02:56:13 -08001196 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -08001197 ASSERT_EQ(2, transport_.packets_sent());
brandtrdbdb3f12016-11-10 05:04:48 -08001198 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1199 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
brandtr9dfff292016-11-14 05:14:50 -08001200 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
brandtrdbdb3f12016-11-10 05:04:48 -08001201 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
brandtr9dfff292016-11-14 05:14:50 -08001202 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1203 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1204 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1205 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001206}
1207
ilnik10894992017-06-21 08:23:19 -07001208// TODO(ilnik): because of webrtc:7859. Once FEC moved below pacer, this test
1209// should be removed.
1210TEST_P(RtpSenderTest, NoFlexfecForTimingFrames) {
1211 constexpr int kMediaPayloadType = 127;
1212 constexpr int kFlexfecPayloadType = 118;
1213 constexpr uint32_t kMediaSsrc = 1234;
1214 constexpr uint32_t kFlexfecSsrc = 5678;
1215 const std::vector<RtpExtension> kNoRtpExtensions;
1216 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
ilnike4350192017-06-29 02:27:44 -07001217
ilnik10894992017-06-21 08:23:19 -07001218 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001219 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
ilnik10894992017-06-21 08:23:19 -07001220 nullptr /* rtp_state */, &fake_clock_);
1221
1222 // Reset |rtp_sender_| to use FlexFEC.
1223 rtp_sender_.reset(new RTPSender(
1224 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1225 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1226 &mock_rtc_event_log_, &send_packet_observer_,
Johannes Kron9190b822018-10-29 11:22:05 +01001227 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
ilnik10894992017-06-21 08:23:19 -07001228 rtp_sender_->SetSSRC(kMediaSsrc);
1229 rtp_sender_->SetSequenceNumber(kSeqNum);
ilnik10894992017-06-21 08:23:19 -07001230 rtp_sender_->SetStorePacketsStatus(true, 10);
1231
ilnike4350192017-06-29 02:27:44 -07001232 // Need extension to be registered for timing frames to be sent.
1233 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1234 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1235
ilnik10894992017-06-21 08:23:19 -07001236 // Parameters selected to generate a single FEC packet per media packet.
1237 FecProtectionParams params;
1238 params.fec_rate = 15;
1239 params.max_fec_frames = 1;
1240 params.fec_mask_type = kFecMaskRandom;
1241 rtp_sender_->SetFecParameters(params, params);
1242
1243 EXPECT_CALL(mock_paced_sender_,
1244 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
1245 _, _, false));
1246 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1247 kFlexfecSsrc, _, _, _, false))
1248 .Times(0); // Not called because packet should not be protected.
1249
1250 const uint32_t kTimestamp = 1234;
1251 const uint8_t kPayloadType = 127;
1252 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
1253 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1254 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
1255 0, 1500));
1256 RTPVideoHeader video_header;
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001257 video_header.video_timing.flags = VideoSendTiming::kTriggeredByTimer;
ilnik10894992017-06-21 08:23:19 -07001258 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1259 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
spranga8ae6f22017-09-04 07:23:56 -07001260 sizeof(kPayloadData), nullptr, &video_header, nullptr,
1261 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001262
Elad Alon4a87e1c2017-10-03 16:11:34 +02001263 EXPECT_CALL(mock_rtc_event_log_,
1264 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1265 .Times(1);
ilnik10894992017-06-21 08:23:19 -07001266 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
1267 fake_clock_.TimeInMilliseconds(),
1268 false, PacedPacketInfo()));
1269 ASSERT_EQ(1, transport_.packets_sent());
1270 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1271 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1272 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
1273 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1274
1275 // Now try to send not a timing frame.
1276 uint16_t flexfec_seq_num;
1277 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1278 kFlexfecSsrc, _, _, _, false))
1279 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
1280 EXPECT_CALL(mock_paced_sender_,
1281 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc,
1282 kSeqNum + 1, _, _, false));
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001283 video_header.video_timing.flags = VideoSendTiming::kInvalid;
ilnik10894992017-06-21 08:23:19 -07001284 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1285 kVideoFrameKey, kPayloadType, kTimestamp + 1, kCaptureTimeMs + 1,
spranga8ae6f22017-09-04 07:23:56 -07001286 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
1287 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001288
Elad Alon4a87e1c2017-10-03 16:11:34 +02001289 EXPECT_CALL(mock_rtc_event_log_,
1290 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1291 .Times(2);
ilnik10894992017-06-21 08:23:19 -07001292 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum + 1,
1293 fake_clock_.TimeInMilliseconds(),
1294 false, PacedPacketInfo()));
1295 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
1296 fake_clock_.TimeInMilliseconds(),
1297 false, PacedPacketInfo()));
1298 ASSERT_EQ(3, transport_.packets_sent());
1299 const RtpPacketReceived& media_packet2 = transport_.sent_packets_[1];
1300 EXPECT_EQ(kMediaPayloadType, media_packet2.PayloadType());
1301 EXPECT_EQ(kSeqNum + 1, media_packet2.SequenceNumber());
1302 EXPECT_EQ(kMediaSsrc, media_packet2.Ssrc());
1303 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[2];
1304 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1305 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1306 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1307}
1308
minyue3a407ee2017-04-03 01:10:33 -07001309TEST_P(RtpSenderTestWithoutPacer, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -08001310 constexpr int kMediaPayloadType = 127;
1311 constexpr int kFlexfecPayloadType = 118;
1312 constexpr uint32_t kMediaSsrc = 1234;
1313 constexpr uint32_t kFlexfecSsrc = 5678;
1314 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001315 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -08001316 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001317 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001318 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001319
1320 // Reset |rtp_sender_| to use FlexFEC.
Benjamin Wright192eeec2018-10-17 17:27:25 -07001321 rtp_sender_.reset(new RTPSender(
1322 false, &fake_clock_, &transport_, nullptr, &flexfec_sender,
1323 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1324 &mock_rtc_event_log_, &send_packet_observer_,
Johannes Kron9190b822018-10-29 11:22:05 +01001325 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
brandtrdbdb3f12016-11-10 05:04:48 -08001326 rtp_sender_->SetSSRC(kMediaSsrc);
1327 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001328
1329 // Parameters selected to generate a single FEC packet per media packet.
1330 FecProtectionParams params;
1331 params.fec_rate = 15;
1332 params.max_fec_frames = 1;
1333 params.fec_mask_type = kFecMaskRandom;
1334 rtp_sender_->SetFecParameters(params, params);
1335
Elad Alon4a87e1c2017-10-03 16:11:34 +02001336 EXPECT_CALL(mock_rtc_event_log_,
1337 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1338 .Times(2);
brandtrdbdb3f12016-11-10 05:04:48 -08001339 SendGenericPayload();
1340 ASSERT_EQ(2, transport_.packets_sent());
1341 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1342 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1343 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1344 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1345 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1346 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1347}
1348
Steve Anton296a0ce2018-03-22 15:17:27 -07001349// Test that the MID header extension is included on sent packets when
1350// configured.
1351TEST_P(RtpSenderTestWithoutPacer, MidIncludedOnSentPackets) {
1352 const char kMid[] = "mid";
1353
1354 // Register MID header extension and set the MID for the RTPSender.
1355 rtp_sender_->SetSendingMediaStatus(false);
1356 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionMid, kMidExtensionId);
1357 rtp_sender_->SetMid(kMid);
1358 rtp_sender_->SetSendingMediaStatus(true);
1359
1360 // Send a couple packets.
1361 SendGenericPayload();
1362 SendGenericPayload();
1363
1364 // Expect both packets to have the MID set.
1365 ASSERT_EQ(2u, transport_.sent_packets_.size());
1366 for (const RtpPacketReceived& packet : transport_.sent_packets_) {
1367 std::string mid;
1368 ASSERT_TRUE(packet.GetExtension<RtpMid>(&mid));
1369 EXPECT_EQ(kMid, mid);
1370 }
1371}
1372
Amit Hilbuch77938e62018-12-21 09:23:38 -08001373TEST_P(RtpSenderTestWithoutPacer, RidIncludedOnSentPackets) {
1374 const char kRid[] = "f";
1375
1376 rtp_sender_->SetSendingMediaStatus(false);
1377 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionRtpStreamId,
1378 kRidExtensionId);
1379 rtp_sender_->SetRid(kRid);
1380 rtp_sender_->SetSendingMediaStatus(true);
1381
1382 SendGenericPayload();
1383
1384 ASSERT_EQ(1u, transport_.sent_packets_.size());
1385 const RtpPacketReceived& packet = transport_.sent_packets_[0];
1386 std::string rid;
1387 ASSERT_TRUE(packet.GetExtension<RtpStreamId>(&rid));
1388 EXPECT_EQ(kRid, rid);
1389}
1390
1391TEST_P(RtpSenderTestWithoutPacer, RidIncludedOnRtxSentPackets) {
1392 const char kRid[] = "f";
1393 const uint8_t kPayloadType = 127;
1394
1395 rtp_sender_->SetSendingMediaStatus(false);
1396 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionRtpStreamId,
1397 kRidExtensionId);
1398 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionRepairedRtpStreamId,
1399 kRepairedRidExtensionId);
1400 rtp_sender_->SetRid(kRid);
1401 rtp_sender_->SetSendingMediaStatus(true);
1402
1403 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
1404 rtp_sender_->SetRtxSsrc(1234);
1405 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayloadType);
1406
1407 rtp_sender_->SetStorePacketsStatus(true, 10);
1408
1409 SendGenericPayload();
1410 ASSERT_EQ(1u, transport_.sent_packets_.size());
1411 const RtpPacketReceived& packet = transport_.sent_packets_[0];
1412 std::string rid;
1413 ASSERT_TRUE(packet.GetExtension<RtpStreamId>(&rid));
1414 EXPECT_EQ(kRid, rid);
1415 rid = kNoRid;
1416 EXPECT_FALSE(packet.GetExtension<RepairedRtpStreamId>(&rid));
1417
1418 uint16_t packet_id = packet.SequenceNumber();
1419 rtp_sender_->ReSendPacket(packet_id);
1420 ASSERT_EQ(2u, transport_.sent_packets_.size());
1421 const RtpPacketReceived& rtx_packet = transport_.sent_packets_[1];
1422 ASSERT_TRUE(rtx_packet.GetExtension<RepairedRtpStreamId>(&rid));
1423 EXPECT_EQ(kRid, rid);
1424 EXPECT_FALSE(rtx_packet.HasExtension<RtpStreamId>());
1425}
1426
minyue3a407ee2017-04-03 01:10:33 -07001427TEST_P(RtpSenderTest, FecOverheadRate) {
brandtr81eab612017-01-24 04:06:09 -08001428 constexpr int kFlexfecPayloadType = 118;
1429 constexpr uint32_t kMediaSsrc = 1234;
1430 constexpr uint32_t kFlexfecSsrc = 5678;
1431 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001432 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtr81eab612017-01-24 04:06:09 -08001433 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001434 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001435 nullptr /* rtp_state */, &fake_clock_);
brandtr81eab612017-01-24 04:06:09 -08001436
1437 // Reset |rtp_sender_| to use FlexFEC.
1438 rtp_sender_.reset(new RTPSender(
1439 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1440 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1441 &mock_rtc_event_log_, &send_packet_observer_,
Johannes Kron9190b822018-10-29 11:22:05 +01001442 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
brandtr81eab612017-01-24 04:06:09 -08001443 rtp_sender_->SetSSRC(kMediaSsrc);
1444 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr81eab612017-01-24 04:06:09 -08001445
1446 // Parameters selected to generate a single FEC packet per media packet.
1447 FecProtectionParams params;
1448 params.fec_rate = 15;
1449 params.max_fec_frames = 1;
1450 params.fec_mask_type = kFecMaskRandom;
1451 rtp_sender_->SetFecParameters(params, params);
1452
1453 constexpr size_t kNumMediaPackets = 10;
1454 constexpr size_t kNumFecPackets = kNumMediaPackets;
1455 constexpr int64_t kTimeBetweenPacketsMs = 10;
1456 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, false))
1457 .Times(kNumMediaPackets + kNumFecPackets);
1458 for (size_t i = 0; i < kNumMediaPackets; ++i) {
1459 SendGenericPayload();
1460 fake_clock_.AdvanceTimeMilliseconds(kTimeBetweenPacketsMs);
1461 }
1462 constexpr size_t kRtpHeaderLength = 12;
1463 constexpr size_t kFlexfecHeaderLength = 20;
1464 constexpr size_t kGenericCodecHeaderLength = 1;
1465 constexpr size_t kPayloadLength = sizeof(kPayloadData);
1466 constexpr size_t kPacketLength = kRtpHeaderLength + kFlexfecHeaderLength +
1467 kGenericCodecHeaderLength + kPayloadLength;
1468 EXPECT_NEAR(kNumFecPackets * kPacketLength * 8 /
1469 (kNumFecPackets * kTimeBetweenPacketsMs / 1000.0f),
1470 rtp_sender_->FecOverheadRate(), 500);
1471}
1472
minyue3a407ee2017-04-03 01:10:33 -07001473TEST_P(RtpSenderTest, FrameCountCallbacks) {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001474 class TestCallback : public FrameCountObserver {
1475 public:
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001476 TestCallback() : FrameCountObserver(), num_calls_(0), ssrc_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001477 ~TestCallback() override = default;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001478
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001479 void FrameCountUpdated(const FrameCounts& frame_counts,
1480 uint32_t ssrc) override {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001481 ++num_calls_;
1482 ssrc_ = ssrc;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001483 frame_counts_ = frame_counts;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001484 }
1485
1486 uint32_t num_calls_;
1487 uint32_t ssrc_;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001488 FrameCounts frame_counts_;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001489 } callback;
1490
Erik Språng7b52f102018-02-07 14:37:37 +01001491 rtp_sender_.reset(new RTPSender(
1492 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr, nullptr,
1493 nullptr, nullptr, &callback, nullptr, nullptr, nullptr,
Johannes Kron9190b822018-10-29 11:22:05 +01001494 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
nisse7d59f6b2017-02-21 03:40:24 -08001495 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001496 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1497 const uint8_t payload_type = 127;
1498 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1499 0, 1500));
1500 uint8_t payload[] = {47, 11, 32, 93, 89};
1501 rtp_sender_->SetStorePacketsStatus(true, 1);
1502 uint32_t ssrc = rtp_sender_->SSRC();
1503
terelius5d332ac2016-01-14 14:37:39 -08001504 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, _))
1505 .Times(::testing::AtLeast(2));
1506
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001507 RTPVideoHeader video_header;
spranga8ae6f22017-09-04 07:23:56 -07001508 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1509 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001510 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001511
1512 EXPECT_EQ(1U, callback.num_calls_);
1513 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001514 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1515 EXPECT_EQ(0, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001516
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001517 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1518 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001519 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001520
1521 EXPECT_EQ(2U, callback.num_calls_);
1522 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001523 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1524 EXPECT_EQ(1, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001525
andresp@webrtc.org8f151212014-07-10 09:39:23 +00001526 rtp_sender_.reset();
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001527}
1528
minyue3a407ee2017-04-03 01:10:33 -07001529TEST_P(RtpSenderTest, BitrateCallbacks) {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001530 class TestCallback : public BitrateStatisticsObserver {
1531 public:
sprangcd349d92016-07-13 09:11:28 -07001532 TestCallback()
1533 : BitrateStatisticsObserver(),
1534 num_calls_(0),
1535 ssrc_(0),
1536 total_bitrate_(0),
1537 retransmit_bitrate_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001538 ~TestCallback() override = default;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001539
sprangcd349d92016-07-13 09:11:28 -07001540 void Notify(uint32_t total_bitrate,
1541 uint32_t retransmit_bitrate,
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001542 uint32_t ssrc) override {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001543 ++num_calls_;
1544 ssrc_ = ssrc;
sprangcd349d92016-07-13 09:11:28 -07001545 total_bitrate_ = total_bitrate;
1546 retransmit_bitrate_ = retransmit_bitrate;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001547 }
1548
1549 uint32_t num_calls_;
1550 uint32_t ssrc_;
sprangcd349d92016-07-13 09:11:28 -07001551 uint32_t total_bitrate_;
1552 uint32_t retransmit_bitrate_;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001553 } callback;
Benjamin Wright192eeec2018-10-17 17:27:25 -07001554 rtp_sender_.reset(new RTPSender(
1555 false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
1556 &callback, nullptr, nullptr, nullptr, nullptr,
Johannes Kron9190b822018-10-29 11:22:05 +01001557 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
nisse7d59f6b2017-02-21 03:40:24 -08001558 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001559
sprangcd349d92016-07-13 09:11:28 -07001560 // Simulate kNumPackets sent with kPacketInterval ms intervals, with the
1561 // number of packets selected so that we fill (but don't overflow) the one
1562 // second averaging window.
1563 const uint32_t kWindowSizeMs = 1000;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001564 const uint32_t kPacketInterval = 20;
sprangcd349d92016-07-13 09:11:28 -07001565 const uint32_t kNumPackets =
1566 (kWindowSizeMs - kPacketInterval) / kPacketInterval;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001567 // Overhead = 12 bytes RTP header + 1 byte generic header.
1568 const uint32_t kPacketOverhead = 13;
1569
1570 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1571 const uint8_t payload_type = 127;
danilchap162abd32015-12-10 02:39:40 -08001572 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1573 0, 1500));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001574 uint8_t payload[] = {47, 11, 32, 93, 89};
1575 rtp_sender_->SetStorePacketsStatus(true, 1);
1576 uint32_t ssrc = rtp_sender_->SSRC();
1577
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001578 // Initial process call so we get a new time window.
1579 rtp_sender_->ProcessBitrate();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001580
1581 // Send a few frames.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001582 RTPVideoHeader video_header;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001583 for (uint32_t i = 0; i < kNumPackets; ++i) {
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001584 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1585 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001586 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001587 fake_clock_.AdvanceTimeMilliseconds(kPacketInterval);
1588 }
1589
1590 rtp_sender_->ProcessBitrate();
1591
stefan@webrtc.org0bae1fa2014-11-05 14:05:29 +00001592 // We get one call for every stats updated, thus two calls since both the
1593 // stream stats and the retransmit stats are updated once.
1594 EXPECT_EQ(2u, callback.num_calls_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001595 EXPECT_EQ(ssrc, callback.ssrc_);
sprangcd349d92016-07-13 09:11:28 -07001596 const uint32_t kTotalPacketSize = kPacketOverhead + sizeof(payload);
1597 // Bitrate measured over delta between last and first timestamp, plus one.
1598 const uint32_t kExpectedWindowMs = kNumPackets * kPacketInterval + 1;
1599 const uint32_t kExpectedBitsAccumulated = kTotalPacketSize * kNumPackets * 8;
1600 const uint32_t kExpectedRateBps =
1601 (kExpectedBitsAccumulated * 1000 + (kExpectedWindowMs / 2)) /
1602 kExpectedWindowMs;
1603 EXPECT_EQ(kExpectedRateBps, callback.total_bitrate_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001604
andresp@webrtc.orgd11bec42014-07-08 14:32:58 +00001605 rtp_sender_.reset();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001606}
1607
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001608class RtpSenderAudioTest : public RtpSenderTest {
1609 protected:
1610 RtpSenderAudioTest() {}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001611
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001612 void SetUp() override {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001613 payload_ = kAudioPayload;
Benjamin Wright192eeec2018-10-17 17:27:25 -07001614 rtp_sender_.reset(new RTPSender(
1615 true, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
1616 nullptr, nullptr, nullptr, nullptr, nullptr,
Johannes Kron9190b822018-10-29 11:22:05 +01001617 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
nisse7d59f6b2017-02-21 03:40:24 -08001618 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001619 rtp_sender_->SetSequenceNumber(kSeqNum);
1620 }
1621};
1622
minyue3a407ee2017-04-03 01:10:33 -07001623TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacks) {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001624 class TestCallback : public StreamDataCountersCallback {
1625 public:
danilchap162abd32015-12-10 02:39:40 -08001626 TestCallback() : StreamDataCountersCallback(), ssrc_(0), counters_() {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001627 ~TestCallback() override = default;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001628
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001629 void DataCountersUpdated(const StreamDataCounters& counters,
1630 uint32_t ssrc) override {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001631 ssrc_ = ssrc;
1632 counters_ = counters;
1633 }
1634
1635 uint32_t ssrc_;
1636 StreamDataCounters counters_;
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001637
1638 void MatchPacketCounter(const RtpPacketCounter& expected,
1639 const RtpPacketCounter& actual) {
1640 EXPECT_EQ(expected.payload_bytes, actual.payload_bytes);
1641 EXPECT_EQ(expected.header_bytes, actual.header_bytes);
1642 EXPECT_EQ(expected.padding_bytes, actual.padding_bytes);
1643 EXPECT_EQ(expected.packets, actual.packets);
1644 }
1645
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001646 void Matches(uint32_t ssrc, const StreamDataCounters& counters) {
1647 EXPECT_EQ(ssrc, ssrc_);
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001648 MatchPacketCounter(counters.transmitted, counters_.transmitted);
1649 MatchPacketCounter(counters.retransmitted, counters_.retransmitted);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001650 EXPECT_EQ(counters.fec.packets, counters_.fec.packets);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001651 }
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001652 } callback;
1653
1654 const uint8_t kRedPayloadType = 96;
1655 const uint8_t kUlpfecPayloadType = 97;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001656 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1657 const uint8_t payload_type = 127;
1658 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1659 0, 1500));
1660 uint8_t payload[] = {47, 11, 32, 93, 89};
1661 rtp_sender_->SetStorePacketsStatus(true, 1);
1662 uint32_t ssrc = rtp_sender_->SSRC();
1663
1664 rtp_sender_->RegisterRtpStatisticsCallback(&callback);
1665
1666 // Send a frame.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001667 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001668 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001669 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001670 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001671 StreamDataCounters expected;
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001672 expected.transmitted.payload_bytes = 6;
1673 expected.transmitted.header_bytes = 12;
1674 expected.transmitted.padding_bytes = 0;
1675 expected.transmitted.packets = 1;
1676 expected.retransmitted.payload_bytes = 0;
1677 expected.retransmitted.header_bytes = 0;
1678 expected.retransmitted.padding_bytes = 0;
1679 expected.retransmitted.packets = 0;
1680 expected.fec.packets = 0;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001681 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001682
1683 // Retransmit a frame.
1684 uint16_t seqno = rtp_sender_->SequenceNumber() - 1;
Erik Språnga12b1d62018-03-14 12:39:24 +01001685 rtp_sender_->ReSendPacket(seqno);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001686 expected.transmitted.payload_bytes = 12;
1687 expected.transmitted.header_bytes = 24;
1688 expected.transmitted.packets = 2;
1689 expected.retransmitted.payload_bytes = 6;
1690 expected.retransmitted.header_bytes = 12;
1691 expected.retransmitted.padding_bytes = 0;
1692 expected.retransmitted.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001693 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001694
1695 // Send padding.
philipel8aadd502017-02-23 02:56:13 -08001696 rtp_sender_->TimeToSendPadding(kMaxPaddingSize, PacedPacketInfo());
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001697 expected.transmitted.payload_bytes = 12;
1698 expected.transmitted.header_bytes = 36;
1699 expected.transmitted.padding_bytes = kMaxPaddingSize;
1700 expected.transmitted.packets = 3;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001701 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001702
brandtrf1bb4762016-11-07 03:05:06 -08001703 // Send ULPFEC.
1704 rtp_sender_->SetUlpfecConfig(kRedPayloadType, kUlpfecPayloadType);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001705 FecProtectionParams fec_params;
1706 fec_params.fec_mask_type = kFecMaskRandom;
1707 fec_params.fec_rate = 1;
1708 fec_params.max_fec_frames = 1;
brandtr1743a192016-11-07 03:36:05 -08001709 rtp_sender_->SetFecParameters(fec_params, fec_params);
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001710 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001711 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001712 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001713 expected.transmitted.payload_bytes = 40;
1714 expected.transmitted.header_bytes = 60;
1715 expected.transmitted.packets = 5;
1716 expected.fec.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001717 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001718
sprang867fb522015-08-03 04:38:41 -07001719 rtp_sender_->RegisterRtpStatisticsCallback(nullptr);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001720}
1721
minyue3a407ee2017-04-03 01:10:33 -07001722TEST_P(RtpSenderAudioTest, SendAudio) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001723 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1724 const uint8_t payload_type = 127;
1725 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1726 0, 1500));
1727 uint8_t payload[] = {47, 11, 32, 93, 89};
1728
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001729 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001730 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001731 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001732 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001733
danilchap96c15872016-11-21 01:35:29 -08001734 auto sent_payload = transport_.last_sent_packet().payload();
1735 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001736}
1737
minyue3a407ee2017-04-03 01:10:33 -07001738TEST_P(RtpSenderAudioTest, SendAudioWithAudioLevelExtension) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001739 EXPECT_EQ(0, rtp_sender_->SetAudioLevel(kAudioLevel));
danilchap162abd32015-12-10 02:39:40 -08001740 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
1741 kAudioLevelExtensionId));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001742
1743 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1744 const uint8_t payload_type = 127;
1745 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1746 0, 1500));
1747 uint8_t payload[] = {47, 11, 32, 93, 89};
1748
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001749 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001750 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001751 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001752 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001753
danilchap96c15872016-11-21 01:35:29 -08001754 auto sent_payload = transport_.last_sent_packet().payload();
1755 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
danilchap12ba1862016-10-26 02:41:55 -07001756 // Verify AudioLevel extension.
1757 bool voice_activity;
1758 uint8_t audio_level;
1759 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<AudioLevel>(
1760 &voice_activity, &audio_level));
1761 EXPECT_EQ(kAudioLevel, audio_level);
1762 EXPECT_FALSE(voice_activity);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001763}
1764
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001765// As RFC4733, named telephone events are carried as part of the audio stream
1766// and must use the same sequence number and timestamp base as the regular
1767// audio channel.
1768// This test checks the marker bit for the first packet and the consequent
1769// packets of the same telephone event. Since it is specifically for DTMF
pbos22993e12015-10-19 02:39:06 -07001770// events, ignoring audio packets and sending kEmptyFrame instead of those.
minyue3a407ee2017-04-03 01:10:33 -07001771TEST_P(RtpSenderAudioTest, CheckMarkerBitForTelephoneEvents) {
solenbergffbbcac2016-11-17 05:25:37 -08001772 const char* kDtmfPayloadName = "telephone-event";
1773 const uint32_t kPayloadFrequency = 8000;
1774 const uint8_t kPayloadType = 126;
1775 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kDtmfPayloadName, kPayloadType,
1776 kPayloadFrequency, 0, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001777 // For Telephone events, payload is not added to the registered payload list,
1778 // it will register only the payload used for audio stream.
1779 // Registering the payload again for audio stream with different payload name.
solenbergffbbcac2016-11-17 05:25:37 -08001780 const char* kPayloadName = "payload_name";
1781 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType,
1782 kPayloadFrequency, 1, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001783 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
1784 // DTMF event key=9, duration=500 and attenuationdB=10
1785 rtp_sender_->SendTelephoneEvent(9, 500, 10);
1786 // During start, it takes the starting timestamp as last sent timestamp.
1787 // The duration is calculated as the difference of current and last sent
1788 // timestamp. So for first call it will skip since the duration is zero.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001789 RTPVideoHeader video_header;
spranga8ae6f22017-09-04 07:23:56 -07001790 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1791 kEmptyFrame, kPayloadType, capture_time_ms, 0, nullptr, 0, nullptr,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001792 &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001793 // DTMF Sample Length is (Frequency/1000) * Duration.
1794 // So in this case, it is (8000/1000) * 500 = 4000.
1795 // Sending it as two packets.
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001796 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001797 kEmptyFrame, kPayloadType, capture_time_ms + 2000, 0, nullptr, 0, nullptr,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001798 &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
danilchap12ba1862016-10-26 02:41:55 -07001799
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001800 // Marker Bit should be set to 1 for first packet.
danilchap12ba1862016-10-26 02:41:55 -07001801 EXPECT_TRUE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001802
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001803 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001804 kEmptyFrame, kPayloadType, capture_time_ms + 4000, 0, nullptr, 0, nullptr,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001805 &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001806 // Marker Bit should be set to 0 for rest of the packets.
danilchap12ba1862016-10-26 02:41:55 -07001807 EXPECT_FALSE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001808}
1809
minyue3a407ee2017-04-03 01:10:33 -07001810TEST_P(RtpSenderTestWithoutPacer, BytesReportedCorrectly) {
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001811 const char* kPayloadName = "GENERIC";
1812 const uint8_t kPayloadType = 127;
1813 rtp_sender_->SetSSRC(1234);
1814 rtp_sender_->SetRtxSsrc(4321);
Shao Changbine62202f2015-04-21 20:24:50 +08001815 rtp_sender_->SetRtxPayloadType(kPayloadType - 1, kPayloadType);
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +00001816 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001817
danilchap162abd32015-12-10 02:39:40 -08001818 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType, 90000,
1819 0, 1500));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001820 uint8_t payload[] = {47, 11, 32, 93, 89};
1821
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001822 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001823 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001824 kVideoFrameKey, kPayloadType, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001825 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001826
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001827 // Will send 2 full-size padding packets.
philipel8aadd502017-02-23 02:56:13 -08001828 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
1829 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001830
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001831 StreamDataCounters rtp_stats;
1832 StreamDataCounters rtx_stats;
1833 rtp_sender_->GetDataCounters(&rtp_stats, &rtx_stats);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001834
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001835 // Payload + 1-byte generic header.
asapersson@webrtc.orgd08d3892014-12-16 12:03:11 +00001836 EXPECT_GT(rtp_stats.first_packet_time_ms, -1);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001837 EXPECT_EQ(rtp_stats.transmitted.payload_bytes, sizeof(payload) + 1);
1838 EXPECT_EQ(rtp_stats.transmitted.header_bytes, 12u);
1839 EXPECT_EQ(rtp_stats.transmitted.padding_bytes, 0u);
1840 EXPECT_EQ(rtx_stats.transmitted.payload_bytes, 0u);
1841 EXPECT_EQ(rtx_stats.transmitted.header_bytes, 24u);
1842 EXPECT_EQ(rtx_stats.transmitted.padding_bytes, 2 * kMaxPaddingSize);
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001843
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001844 EXPECT_EQ(rtp_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001845 rtp_stats.transmitted.payload_bytes +
1846 rtp_stats.transmitted.header_bytes +
1847 rtp_stats.transmitted.padding_bytes);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001848 EXPECT_EQ(rtx_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001849 rtx_stats.transmitted.payload_bytes +
1850 rtx_stats.transmitted.header_bytes +
1851 rtx_stats.transmitted.padding_bytes);
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001852
danilchap162abd32015-12-10 02:39:40 -08001853 EXPECT_EQ(
1854 transport_.total_bytes_sent_,
1855 rtp_stats.transmitted.TotalBytes() + rtx_stats.transmitted.TotalBytes());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001856}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001857
minyue3a407ee2017-04-03 01:10:33 -07001858TEST_P(RtpSenderTestWithoutPacer, RespectsNackBitrateLimit) {
sprang38778b02015-09-29 09:48:22 -07001859 const int32_t kPacketSize = 1400;
1860 const int32_t kNumPackets = 30;
1861
sprangcd349d92016-07-13 09:11:28 -07001862 retransmission_rate_limiter_.SetMaxRate(kPacketSize * kNumPackets * 8);
1863
sprang38778b02015-09-29 09:48:22 -07001864 rtp_sender_->SetStorePacketsStatus(true, kNumPackets);
sprang38778b02015-09-29 09:48:22 -07001865 const uint16_t kStartSequenceNumber = rtp_sender_->SequenceNumber();
Danil Chapovalov2800d742016-08-26 18:48:46 +02001866 std::vector<uint16_t> sequence_numbers;
sprang38778b02015-09-29 09:48:22 -07001867 for (int32_t i = 0; i < kNumPackets; ++i) {
1868 sequence_numbers.push_back(kStartSequenceNumber + i);
1869 fake_clock_.AdvanceTimeMilliseconds(1);
1870 SendPacket(fake_clock_.TimeInMilliseconds(), kPacketSize);
1871 }
danilchap12ba1862016-10-26 02:41:55 -07001872 EXPECT_EQ(kNumPackets, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001873
1874 fake_clock_.AdvanceTimeMilliseconds(1000 - kNumPackets);
1875
1876 // Resending should work - brings the bandwidth up to the limit.
1877 // NACK bitrate is capped to the same bitrate as the encoder, since the max
1878 // protection overhead is 50% (see MediaOptimization::SetTargetRates).
Danil Chapovalov2800d742016-08-26 18:48:46 +02001879 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001880 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001881
sprangcd349d92016-07-13 09:11:28 -07001882 // Must be at least 5ms in between retransmission attempts.
1883 fake_clock_.AdvanceTimeMilliseconds(5);
1884
sprang38778b02015-09-29 09:48:22 -07001885 // Resending should not work, bandwidth exceeded.
Danil Chapovalov2800d742016-08-26 18:48:46 +02001886 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001887 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001888}
1889
minyue3a407ee2017-04-03 01:10:33 -07001890TEST_P(RtpSenderVideoTest, KeyFrameHasCVO) {
danilchapb6f1fb52016-10-19 06:11:39 -07001891 uint8_t kFrame[kMaxPacketLength];
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001892 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1893 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001894
philipel1a4746a2018-07-09 15:52:29 +02001895 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001896 hdr.rotation = kVideoRotation_0;
Artem Titov81d4bf72019-01-24 12:01:59 +00001897 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameKey, kPayload,
1898 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
1899 &hdr, kDefaultExpectedRetransmissionTimeMs);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001900
danilchapc1600c52016-10-26 03:33:11 -07001901 VideoRotation rotation;
1902 EXPECT_TRUE(
1903 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1904 EXPECT_EQ(kVideoRotation_0, rotation);
1905}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001906
ilnik04f4d122017-06-19 07:18:55 -07001907TEST_P(RtpSenderVideoTest, TimingFrameHasPacketizationTimstampSet) {
1908 uint8_t kFrame[kMaxPacketLength];
1909 const int64_t kPacketizationTimeMs = 100;
1910 const int64_t kEncodeStartDeltaMs = 10;
1911 const int64_t kEncodeFinishDeltaMs = 50;
1912 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1913 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1914
1915 const int64_t kCaptureTimestamp = fake_clock_.TimeInMilliseconds();
1916
philipel1a4746a2018-07-09 15:52:29 +02001917 RTPVideoHeader hdr;
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001918 hdr.video_timing.flags = VideoSendTiming::kTriggeredByTimer;
ilnik04f4d122017-06-19 07:18:55 -07001919 hdr.video_timing.encode_start_delta_ms = kEncodeStartDeltaMs;
1920 hdr.video_timing.encode_finish_delta_ms = kEncodeFinishDeltaMs;
1921
1922 fake_clock_.AdvanceTimeMilliseconds(kPacketizationTimeMs);
Artem Titov81d4bf72019-01-24 12:01:59 +00001923 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameKey, kPayload,
1924 kTimestamp, kCaptureTimestamp, kFrame,
1925 sizeof(kFrame), nullptr, &hdr,
1926 kDefaultExpectedRetransmissionTimeMs);
ilnik2edc6842017-07-06 03:06:50 -07001927 VideoSendTiming timing;
ilnik04f4d122017-06-19 07:18:55 -07001928 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
1929 &timing));
1930 EXPECT_EQ(kPacketizationTimeMs, timing.packetization_finish_delta_ms);
1931 EXPECT_EQ(kEncodeStartDeltaMs, timing.encode_start_delta_ms);
1932 EXPECT_EQ(kEncodeFinishDeltaMs, timing.encode_finish_delta_ms);
1933}
1934
minyue3a407ee2017-04-03 01:10:33 -07001935TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenChanged) {
danilchapc1600c52016-10-26 03:33:11 -07001936 uint8_t kFrame[kMaxPacketLength];
1937 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1938 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1939
philipel1a4746a2018-07-09 15:52:29 +02001940 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001941 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001942 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Artem Titov81d4bf72019-01-24 12:01:59 +00001943 kVideoCodecGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
1944 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001945
1946 hdr.rotation = kVideoRotation_0;
spranga8ae6f22017-09-04 07:23:56 -07001947 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Artem Titov81d4bf72019-01-24 12:01:59 +00001948 kVideoCodecGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
1949 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001950
1951 VideoRotation rotation;
1952 EXPECT_TRUE(
1953 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1954 EXPECT_EQ(kVideoRotation_0, rotation);
1955}
1956
minyue3a407ee2017-04-03 01:10:33 -07001957TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenNonZero) {
danilchapc1600c52016-10-26 03:33:11 -07001958 uint8_t kFrame[kMaxPacketLength];
1959 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1960 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1961
philipel1a4746a2018-07-09 15:52:29 +02001962 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001963 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001964 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Artem Titov81d4bf72019-01-24 12:01:59 +00001965 kVideoCodecGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
1966 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001967
spranga8ae6f22017-09-04 07:23:56 -07001968 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Artem Titov81d4bf72019-01-24 12:01:59 +00001969 kVideoCodecGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
1970 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001971
1972 VideoRotation rotation;
1973 EXPECT_TRUE(
1974 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1975 EXPECT_EQ(kVideoRotation_90, rotation);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001976}
magjed71eb61c2016-09-08 03:24:58 -07001977
1978// Make sure rotation is parsed correctly when the Camera (C) and Flip (F) bits
1979// are set in the CVO byte.
minyue3a407ee2017-04-03 01:10:33 -07001980TEST_P(RtpSenderVideoTest, SendVideoWithCameraAndFlipCVO) {
magjed71eb61c2016-09-08 03:24:58 -07001981 // Test extracting rotation when Camera (C) and Flip (F) bits are zero.
1982 EXPECT_EQ(kVideoRotation_0, ConvertCVOByteToVideoRotation(0));
1983 EXPECT_EQ(kVideoRotation_90, ConvertCVOByteToVideoRotation(1));
1984 EXPECT_EQ(kVideoRotation_180, ConvertCVOByteToVideoRotation(2));
1985 EXPECT_EQ(kVideoRotation_270, ConvertCVOByteToVideoRotation(3));
1986 // Test extracting rotation when Camera (C) and Flip (F) bits are set.
1987 const int flip_bit = 1 << 2;
1988 const int camera_bit = 1 << 3;
1989 EXPECT_EQ(kVideoRotation_0,
1990 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 0));
1991 EXPECT_EQ(kVideoRotation_90,
1992 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 1));
1993 EXPECT_EQ(kVideoRotation_180,
1994 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 2));
1995 EXPECT_EQ(kVideoRotation_270,
1996 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 3));
1997}
1998
spranga8ae6f22017-09-04 07:23:56 -07001999TEST_P(RtpSenderVideoTest, RetransmissionTypesGeneric) {
2000 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02002001 header.codec = kVideoCodecGeneric;
spranga8ae6f22017-09-04 07:23:56 -07002002
2003 EXPECT_EQ(kDontRetransmit,
2004 rtp_sender_video_->GetStorageType(
2005 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
2006 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2007 header, kRetransmitBaseLayer,
2008 kDefaultExpectedRetransmissionTimeMs));
2009 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2010 header, kRetransmitHigherLayers,
2011 kDefaultExpectedRetransmissionTimeMs));
2012 EXPECT_EQ(kAllowRetransmission,
2013 rtp_sender_video_->GetStorageType(
2014 header, kConditionallyRetransmitHigherLayers,
2015 kDefaultExpectedRetransmissionTimeMs));
2016 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2017 header, kRetransmitAllPackets,
2018 kDefaultExpectedRetransmissionTimeMs));
2019}
2020
2021TEST_P(RtpSenderVideoTest, RetransmissionTypesH264) {
2022 RTPVideoHeader header;
philipel7d745e52018-08-02 14:03:53 +02002023 header.video_type_header.emplace<RTPVideoHeaderH264>().packetization_mode =
2024 H264PacketizationMode::NonInterleaved;
Niels Möller520ca4e2018-06-04 11:14:38 +02002025 header.codec = kVideoCodecH264;
spranga8ae6f22017-09-04 07:23:56 -07002026
2027 EXPECT_EQ(kDontRetransmit,
2028 rtp_sender_video_->GetStorageType(
2029 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
2030 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2031 header, kRetransmitBaseLayer,
2032 kDefaultExpectedRetransmissionTimeMs));
2033 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2034 header, kRetransmitHigherLayers,
2035 kDefaultExpectedRetransmissionTimeMs));
2036 EXPECT_EQ(kAllowRetransmission,
2037 rtp_sender_video_->GetStorageType(
2038 header, kConditionallyRetransmitHigherLayers,
2039 kDefaultExpectedRetransmissionTimeMs));
2040 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2041 header, kRetransmitAllPackets,
2042 kDefaultExpectedRetransmissionTimeMs));
2043}
2044
2045TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8BaseLayer) {
2046 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02002047 header.codec = kVideoCodecVP8;
Philip Eliassond52a1a62018-09-07 13:03:55 +00002048 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
2049 vp8_header.temporalIdx = 0;
spranga8ae6f22017-09-04 07:23:56 -07002050
2051 EXPECT_EQ(kDontRetransmit,
2052 rtp_sender_video_->GetStorageType(
2053 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
2054 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2055 header, kRetransmitBaseLayer,
2056 kDefaultExpectedRetransmissionTimeMs));
2057 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
2058 header, kRetransmitHigherLayers,
2059 kDefaultExpectedRetransmissionTimeMs));
2060 EXPECT_EQ(kAllowRetransmission,
2061 rtp_sender_video_->GetStorageType(
2062 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
2063 kDefaultExpectedRetransmissionTimeMs));
2064 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
2065 header, kConditionallyRetransmitHigherLayers,
2066 kDefaultExpectedRetransmissionTimeMs));
2067 EXPECT_EQ(
2068 kAllowRetransmission,
2069 rtp_sender_video_->GetStorageType(
2070 header, kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers,
2071 kDefaultExpectedRetransmissionTimeMs));
2072 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2073 header, kRetransmitAllPackets,
2074 kDefaultExpectedRetransmissionTimeMs));
2075}
2076
2077TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8HigherLayers) {
2078 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02002079 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07002080
Philip Eliassond52a1a62018-09-07 13:03:55 +00002081 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
spranga8ae6f22017-09-04 07:23:56 -07002082 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
Philip Eliassond52a1a62018-09-07 13:03:55 +00002083 vp8_header.temporalIdx = tid;
spranga8ae6f22017-09-04 07:23:56 -07002084
2085 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
2086 header, kRetransmitOff,
2087 kDefaultExpectedRetransmissionTimeMs));
2088 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
2089 header, kRetransmitBaseLayer,
2090 kDefaultExpectedRetransmissionTimeMs));
2091 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2092 header, kRetransmitHigherLayers,
2093 kDefaultExpectedRetransmissionTimeMs));
2094 EXPECT_EQ(kAllowRetransmission,
2095 rtp_sender_video_->GetStorageType(
2096 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
2097 kDefaultExpectedRetransmissionTimeMs));
2098 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2099 header, kRetransmitAllPackets,
2100 kDefaultExpectedRetransmissionTimeMs));
2101 }
2102}
2103
2104TEST_P(RtpSenderVideoTest, RetransmissionTypesVP9) {
2105 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02002106 header.codec = kVideoCodecVP9;
spranga8ae6f22017-09-04 07:23:56 -07002107
philipel29d88462018-08-08 14:26:00 +02002108 auto& vp9_header = header.video_type_header.emplace<RTPVideoHeaderVP9>();
spranga8ae6f22017-09-04 07:23:56 -07002109 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
philipel29d88462018-08-08 14:26:00 +02002110 vp9_header.temporal_idx = tid;
spranga8ae6f22017-09-04 07:23:56 -07002111
2112 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
2113 header, kRetransmitOff,
2114 kDefaultExpectedRetransmissionTimeMs));
2115 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
2116 header, kRetransmitBaseLayer,
2117 kDefaultExpectedRetransmissionTimeMs));
2118 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2119 header, kRetransmitHigherLayers,
2120 kDefaultExpectedRetransmissionTimeMs));
2121 EXPECT_EQ(kAllowRetransmission,
2122 rtp_sender_video_->GetStorageType(
2123 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
2124 kDefaultExpectedRetransmissionTimeMs));
2125 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2126 header, kRetransmitAllPackets,
2127 kDefaultExpectedRetransmissionTimeMs));
2128 }
2129}
2130
2131TEST_P(RtpSenderVideoTest, ConditionalRetransmit) {
2132 const int64_t kFrameIntervalMs = 33;
2133 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
2134 const uint8_t kSettings =
2135 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
2136
2137 // Insert VP8 frames for all temporal layers, but stop before the final index.
2138 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02002139 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07002140
2141 // Fill averaging window to prevent rounding errors.
2142 constexpr int kNumRepetitions =
2143 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
2144 kFrameIntervalMs;
2145 constexpr int kPattern[] = {0, 2, 1, 2};
Philip Eliassond52a1a62018-09-07 13:03:55 +00002146 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
spranga8ae6f22017-09-04 07:23:56 -07002147 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
Philip Eliassond52a1a62018-09-07 13:03:55 +00002148 vp8_header.temporalIdx = kPattern[i % arraysize(kPattern)];
spranga8ae6f22017-09-04 07:23:56 -07002149 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
2150 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2151 }
2152
2153 // Since we're at the start of the pattern, the next expected frame in TL0 is
2154 // right now. We will wait at most one expected retransmission time before
2155 // acknowledging that it did not arrive, which means this frame and the next
2156 // will not be retransmitted.
Philip Eliassond52a1a62018-09-07 13:03:55 +00002157 vp8_header.temporalIdx = 1;
spranga8ae6f22017-09-04 07:23:56 -07002158 EXPECT_EQ(StorageType::kDontRetransmit,
2159 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2160 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2161 EXPECT_EQ(StorageType::kDontRetransmit,
2162 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2163 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2164
2165 // The TL0 frame did not arrive. So allow retransmission.
2166 EXPECT_EQ(StorageType::kAllowRetransmission,
2167 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2168 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2169
2170 // Insert a frame for TL2. We just had frame in TL1, so the next one there is
2171 // in three frames away. TL0 is still too far in the past. So, allow
2172 // retransmission.
Philip Eliassond52a1a62018-09-07 13:03:55 +00002173 vp8_header.temporalIdx = 2;
spranga8ae6f22017-09-04 07:23:56 -07002174 EXPECT_EQ(StorageType::kAllowRetransmission,
2175 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2176 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2177
2178 // Another TL2, next in TL1 is two frames away. Allow again.
2179 EXPECT_EQ(StorageType::kAllowRetransmission,
2180 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2181 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2182
2183 // Yet another TL2, next in TL1 is now only one frame away, so don't store
2184 // for retransmission.
2185 EXPECT_EQ(StorageType::kDontRetransmit,
2186 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2187}
2188
2189TEST_P(RtpSenderVideoTest, ConditionalRetransmitLimit) {
2190 const int64_t kFrameIntervalMs = 200;
2191 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
2192 const int32_t kSettings =
2193 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
2194
2195 // Insert VP8 frames for all temporal layers, but stop before the final index.
2196 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02002197 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07002198
2199 // Fill averaging window to prevent rounding errors.
2200 constexpr int kNumRepetitions =
2201 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
2202 kFrameIntervalMs;
2203 constexpr int kPattern[] = {0, 2, 2, 2};
Philip Eliassond52a1a62018-09-07 13:03:55 +00002204 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
spranga8ae6f22017-09-04 07:23:56 -07002205 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
Philip Eliassond52a1a62018-09-07 13:03:55 +00002206 vp8_header.temporalIdx = kPattern[i % arraysize(kPattern)];
spranga8ae6f22017-09-04 07:23:56 -07002207
2208 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
2209 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2210 }
2211
2212 // Since we're at the start of the pattern, the next expected frame will be
2213 // right now in TL0. Put it in TL1 instead. Regular rules would dictate that
2214 // we don't store for retransmission because we expect a frame in a lower
2215 // layer, but that last frame in TL1 was a long time ago in absolute terms,
2216 // so allow retransmission anyway.
Philip Eliassond52a1a62018-09-07 13:03:55 +00002217 vp8_header.temporalIdx = 1;
spranga8ae6f22017-09-04 07:23:56 -07002218 EXPECT_EQ(StorageType::kAllowRetransmission,
2219 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2220}
2221
philipelb3e42a42018-09-13 10:57:14 +02002222TEST_P(RtpSenderVideoTest, PopulateGenericFrameDescriptor) {
2223 const int64_t kFrameId = 100000;
2224 uint8_t kFrame[100];
2225 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2226 kRtpExtensionGenericFrameDescriptor, kGenericDescriptorId));
2227
2228 RTPVideoHeader hdr;
2229 RTPVideoHeader::GenericDescriptorInfo& generic = hdr.generic.emplace();
2230 generic.frame_id = kFrameId;
2231 generic.temporal_index = 3;
2232 generic.spatial_index = 2;
2233 generic.higher_spatial_layers.push_back(4);
2234 generic.dependencies.push_back(kFrameId - 1);
2235 generic.dependencies.push_back(kFrameId - 500);
Artem Titov81d4bf72019-01-24 12:01:59 +00002236 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameDelta, kPayload,
2237 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
2238 &hdr, kDefaultExpectedRetransmissionTimeMs);
philipelb3e42a42018-09-13 10:57:14 +02002239
2240 RtpGenericFrameDescriptor descriptor_wire;
2241 EXPECT_EQ(1U, transport_.sent_packets_.size());
2242 EXPECT_TRUE(
2243 transport_.last_sent_packet()
2244 .GetExtension<RtpGenericFrameDescriptorExtension>(&descriptor_wire));
2245 EXPECT_EQ(static_cast<uint16_t>(generic.frame_id), descriptor_wire.FrameId());
2246 EXPECT_EQ(generic.temporal_index, descriptor_wire.TemporalLayer());
2247 EXPECT_THAT(descriptor_wire.FrameDependenciesDiffs(), ElementsAre(1, 500));
2248 uint8_t spatial_bitmask = 0x14;
2249 EXPECT_EQ(spatial_bitmask, descriptor_wire.SpatialLayersBitmask());
2250}
2251
Danil Chapovalov84ffb352018-09-25 18:59:09 +02002252TEST_P(RtpSenderVideoTest,
2253 UsesMinimalVp8DescriptorWhenGenericFrameDescriptorExtensionIsUsed) {
2254 const int64_t kFrameId = 100000;
2255 const size_t kFrameSize = 100;
2256 uint8_t kFrame[kFrameSize];
2257 ASSERT_TRUE(rtp_sender_->RegisterRtpHeaderExtension(
2258 RtpGenericFrameDescriptorExtension::kUri, kGenericDescriptorId));
2259
2260 RTPVideoHeader hdr;
2261 hdr.codec = kVideoCodecVP8;
2262 RTPVideoHeaderVP8& vp8 = hdr.video_type_header.emplace<RTPVideoHeaderVP8>();
2263 vp8.pictureId = kFrameId % 0X7FFF;
2264 vp8.tl0PicIdx = 13;
2265 vp8.temporalIdx = 1;
2266 vp8.keyIdx = 2;
2267 RTPVideoHeader::GenericDescriptorInfo& generic = hdr.generic.emplace();
2268 generic.frame_id = kFrameId;
Artem Titov81d4bf72019-01-24 12:01:59 +00002269 rtp_sender_video_->SendVideo(kVideoCodecVP8, kVideoFrameDelta, kPayload,
2270 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
2271 &hdr, kDefaultExpectedRetransmissionTimeMs);
Danil Chapovalov84ffb352018-09-25 18:59:09 +02002272
2273 ASSERT_THAT(transport_.sent_packets_, SizeIs(1));
2274 // Expect only minimal 1-byte vp8 descriptor was generated.
2275 EXPECT_THAT(transport_.sent_packets_[0].payload_size(), 1 + kFrameSize);
2276}
2277
minyue3a407ee2017-04-03 01:10:33 -07002278TEST_P(RtpSenderTest, OnOverheadChanged) {
michaelt4da30442016-11-17 01:38:43 -08002279 MockOverheadObserver mock_overhead_observer;
Benjamin Wright192eeec2018-10-17 17:27:25 -07002280 rtp_sender_.reset(
2281 new RTPSender(false, &fake_clock_, &transport_, nullptr, nullptr, nullptr,
2282 nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
2283 &retransmission_rate_limiter_, &mock_overhead_observer,
Johannes Kron9190b822018-10-29 11:22:05 +01002284 false, nullptr, false, false));
nisse7d59f6b2017-02-21 03:40:24 -08002285 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08002286
michaelt4da30442016-11-17 01:38:43 -08002287 // RTP overhead is 12B.
nisse284542b2017-01-10 08:58:32 -08002288 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(12)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002289 SendGenericPayload();
2290
2291 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
2292 kTransmissionTimeOffsetExtensionId);
2293
2294 // TransmissionTimeOffset extension has a size of 8B.
nisse284542b2017-01-10 08:58:32 -08002295 // 12B + 8B = 20B
2296 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(20)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002297 SendGenericPayload();
2298}
2299
minyue3a407ee2017-04-03 01:10:33 -07002300TEST_P(RtpSenderTest, DoesNotUpdateOverheadOnEqualSize) {
michaelt4da30442016-11-17 01:38:43 -08002301 MockOverheadObserver mock_overhead_observer;
Benjamin Wright192eeec2018-10-17 17:27:25 -07002302 rtp_sender_.reset(
2303 new RTPSender(false, &fake_clock_, &transport_, nullptr, nullptr, nullptr,
2304 nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
2305 &retransmission_rate_limiter_, &mock_overhead_observer,
Johannes Kron9190b822018-10-29 11:22:05 +01002306 false, nullptr, false, false));
nisse7d59f6b2017-02-21 03:40:24 -08002307 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08002308
2309 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(_)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002310 SendGenericPayload();
2311 SendGenericPayload();
2312}
2313
sprang168794c2017-07-06 04:38:06 -07002314TEST_P(RtpSenderTest, SendsKeepAlive) {
2315 MockTransport transport;
Benjamin Wright192eeec2018-10-17 17:27:25 -07002316 rtp_sender_.reset(new RTPSender(
2317 false, &fake_clock_, &transport, nullptr, nullptr, nullptr, nullptr,
2318 nullptr, nullptr, nullptr, &mock_rtc_event_log_, nullptr,
Johannes Kron9190b822018-10-29 11:22:05 +01002319 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
sprang168794c2017-07-06 04:38:06 -07002320 rtp_sender_->SetSequenceNumber(kSeqNum);
2321 rtp_sender_->SetTimestampOffset(0);
2322 rtp_sender_->SetSSRC(kSsrc);
2323
2324 const uint8_t kKeepalivePayloadType = 20;
2325 RTC_CHECK_NE(kKeepalivePayloadType, kPayload);
2326
2327 EXPECT_CALL(transport, SendRtp(_, _, _))
2328 .WillOnce(
2329 Invoke([&kKeepalivePayloadType](const uint8_t* packet, size_t len,
2330 const PacketOptions& options) {
2331 webrtc::RTPHeader rtp_header;
2332 RtpUtility::RtpHeaderParser parser(packet, len);
2333 EXPECT_TRUE(parser.Parse(&rtp_header, nullptr));
2334 EXPECT_FALSE(rtp_header.markerBit);
2335 EXPECT_EQ(0U, rtp_header.paddingLength);
2336 EXPECT_EQ(kKeepalivePayloadType, rtp_header.payloadType);
2337 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
2338 EXPECT_EQ(kSsrc, rtp_header.ssrc);
2339 EXPECT_EQ(0u, len - rtp_header.headerLength);
2340 return true;
2341 }));
2342
2343 rtp_sender_->SendKeepAlive(kKeepalivePayloadType);
2344 EXPECT_EQ(kSeqNum + 1, rtp_sender_->SequenceNumber());
2345}
2346
minyue3a407ee2017-04-03 01:10:33 -07002347INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2348 RtpSenderTest,
2349 ::testing::Bool());
2350INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2351 RtpSenderTestWithoutPacer,
2352 ::testing::Bool());
2353INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2354 RtpSenderVideoTest,
2355 ::testing::Bool());
2356INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2357 RtpSenderAudioTest,
2358 ::testing::Bool());
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00002359} // namespace webrtc