blob: f30b383e499e299bc56f4e0214a79893827aef03 [file] [log] [blame]
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00001/*
phoglund@webrtc.org78088c22012-02-07 14:56:45 +00002 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00003 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
kwiberg84be5112016-04-27 01:19:58 -070011#include <memory>
danilchapb8b6fbb2015-12-10 05:05:27 -080012#include <vector>
13
Karl Wiberg918f50c2018-07-05 11:40:33 +020014#include "absl/memory/memory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020015#include "api/video/video_timing.h"
Elad Alon4a87e1c2017-10-03 16:11:34 +020016#include "logging/rtc_event_log/events/rtc_event.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020017#include "logging/rtc_event_log/mock/mock_rtc_event_log.h"
18#include "modules/rtp_rtcp/include/rtp_cvo.h"
19#include "modules/rtp_rtcp/include/rtp_header_extension_map.h"
20#include "modules/rtp_rtcp/include/rtp_header_parser.h"
21#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
22#include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
23#include "modules/rtp_rtcp/source/rtp_format_video_generic.h"
philipelb3e42a42018-09-13 10:57:14 +020024#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor.h"
25#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor_extension.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020026#include "modules/rtp_rtcp/source/rtp_header_extensions.h"
27#include "modules/rtp_rtcp/source/rtp_packet_received.h"
28#include "modules/rtp_rtcp/source/rtp_packet_to_send.h"
29#include "modules/rtp_rtcp/source/rtp_sender.h"
30#include "modules/rtp_rtcp/source/rtp_sender_video.h"
31#include "modules/rtp_rtcp/source/rtp_utility.h"
32#include "rtc_base/arraysize.h"
33#include "rtc_base/buffer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020034#include "rtc_base/rate_limiter.h"
35#include "test/field_trial.h"
36#include "test/gmock.h"
37#include "test/gtest.h"
38#include "test/mock_transport.h"
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +000039
40namespace webrtc {
41
andrew@webrtc.org8a442592011-12-16 21:24:30 +000042namespace {
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +000043const int kTransmissionTimeOffsetExtensionId = 1;
44const int kAbsoluteSendTimeExtensionId = 14;
sprang@webrtc.org30933902015-03-17 14:33:12 +000045const int kTransportSequenceNumberExtensionId = 13;
ilnik04f4d122017-06-19 07:18:55 -070046const int kVideoTimingExtensionId = 12;
Steve Anton296a0ce2018-03-22 15:17:27 -070047const int kMidExtensionId = 11;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000048const int kPayload = 100;
Shao Changbine62202f2015-04-21 20:24:50 +080049const int kRtxPayload = 98;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000050const uint32_t kTimestamp = 10;
51const uint16_t kSeqNum = 33;
brandtr9dfff292016-11-14 05:14:50 -080052const uint32_t kSsrc = 725242;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000053const int kMaxPacketLength = 1500;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000054const uint8_t kAudioLevel = 0x5a;
sprang@webrtc.org30933902015-03-17 14:33:12 +000055const uint16_t kTransportSequenceNumber = 0xaabbu;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000056const uint8_t kAudioLevelExtensionId = 9;
57const int kAudioPayload = 103;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +000058const uint64_t kStartTime = 123456789;
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +000059const size_t kMaxPaddingSize = 224u;
guoweis@webrtc.org45362892015-03-04 22:55:15 +000060const int kVideoRotationExtensionId = 5;
Stefan Holmera246cfb2016-08-23 17:51:42 +020061const size_t kGenericHeaderLength = 1;
62const uint8_t kPayloadData[] = {47, 11, 32, 93, 89};
spranga8ae6f22017-09-04 07:23:56 -070063const int64_t kDefaultExpectedRetransmissionTimeMs = 125;
philipelb3e42a42018-09-13 10:57:14 +020064const int kGenericDescriptorId = 10;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000065
Danil Chapovalov5e57b172016-09-02 19:15:59 +020066using ::testing::_;
philipelb3e42a42018-09-13 10:57:14 +020067using ::testing::ElementsAre;
Danil Chapovalov5e57b172016-09-02 19:15:59 +020068using ::testing::ElementsAreArray;
sprang168794c2017-07-06 04:38:06 -070069using ::testing::Invoke;
Danil Chapovalov84ffb352018-09-25 18:59:09 +020070using ::testing::SizeIs;
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +000071
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000072uint64_t ConvertMsToAbsSendTime(int64_t time_ms) {
Stefan Holmer0a87ffc2015-10-21 13:41:48 +020073 return (((time_ms << 18) + 500) / 1000) & 0x00ffffff;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000074}
75
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +000076class LoopbackTransportTest : public webrtc::Transport {
77 public:
Petter Strandmark26bc6692018-05-29 08:43:35 +020078 LoopbackTransportTest() : total_bytes_sent_(0) {
danilchap12ba1862016-10-26 02:41:55 -070079 receivers_extensions_.Register(kRtpExtensionTransmissionTimeOffset,
80 kTransmissionTimeOffsetExtensionId);
81 receivers_extensions_.Register(kRtpExtensionAbsoluteSendTime,
82 kAbsoluteSendTimeExtensionId);
83 receivers_extensions_.Register(kRtpExtensionTransportSequenceNumber,
84 kTransportSequenceNumberExtensionId);
85 receivers_extensions_.Register(kRtpExtensionVideoRotation,
86 kVideoRotationExtensionId);
87 receivers_extensions_.Register(kRtpExtensionAudioLevel,
88 kAudioLevelExtensionId);
ilnik04f4d122017-06-19 07:18:55 -070089 receivers_extensions_.Register(kRtpExtensionVideoTiming,
90 kVideoTimingExtensionId);
Steve Anton296a0ce2018-03-22 15:17:27 -070091 receivers_extensions_.Register(kRtpExtensionMid, kMidExtensionId);
philipelb3e42a42018-09-13 10:57:14 +020092 receivers_extensions_.Register(kRtpExtensionGenericFrameDescriptor,
93 kGenericDescriptorId);
guoweis@webrtc.org45362892015-03-04 22:55:15 +000094 }
danilchap12ba1862016-10-26 02:41:55 -070095
stefan1d8a5062015-10-02 03:39:33 -070096 bool SendRtp(const uint8_t* data,
97 size_t len,
98 const PacketOptions& options) override {
Petter Strandmark26bc6692018-05-29 08:43:35 +020099 last_options_ = options;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000100 total_bytes_sent_ += len;
danilchap12ba1862016-10-26 02:41:55 -0700101 sent_packets_.push_back(RtpPacketReceived(&receivers_extensions_));
102 EXPECT_TRUE(sent_packets_.back().Parse(data, len));
pbos2d566682015-09-28 09:59:31 -0700103 return true;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000104 }
danilchap162abd32015-12-10 02:39:40 -0800105 bool SendRtcp(const uint8_t* data, size_t len) override { return false; }
danilchap12ba1862016-10-26 02:41:55 -0700106 const RtpPacketReceived& last_sent_packet() { return sent_packets_.back(); }
107 int packets_sent() { return sent_packets_.size(); }
108
pbos@webrtc.org72491b92014-07-10 16:24:54 +0000109 size_t total_bytes_sent_;
Petter Strandmark26bc6692018-05-29 08:43:35 +0200110 PacketOptions last_options_;
danilchap12ba1862016-10-26 02:41:55 -0700111 std::vector<RtpPacketReceived> sent_packets_;
112
113 private:
114 RtpHeaderExtensionMap receivers_extensions_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000115};
116
Elad Alon4a87e1c2017-10-03 16:11:34 +0200117MATCHER_P(SameRtcEventTypeAs, value, "") {
118 return value == arg->GetType();
119}
120
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000121} // namespace
122
sprangebbf8a82015-09-21 15:11:14 -0700123class MockRtpPacketSender : public RtpPacketSender {
124 public:
125 MockRtpPacketSender() {}
126 virtual ~MockRtpPacketSender() {}
127
Peter Boströme23e7372015-10-08 11:44:14 +0200128 MOCK_METHOD6(InsertPacket,
129 void(Priority priority,
sprangebbf8a82015-09-21 15:11:14 -0700130 uint32_t ssrc,
131 uint16_t sequence_number,
132 int64_t capture_time_ms,
133 size_t bytes,
134 bool retransmission));
135};
136
Stefan Holmerf5dca482016-01-27 12:58:51 +0100137class MockTransportSequenceNumberAllocator
138 : public TransportSequenceNumberAllocator {
139 public:
140 MOCK_METHOD0(AllocateSequenceNumber, uint16_t());
141};
142
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200143class MockSendSideDelayObserver : public SendSideDelayObserver {
144 public:
145 MOCK_METHOD3(SendSideDelayUpdated, void(int, int, uint32_t));
146};
147
asapersson35151f32016-05-02 23:44:01 -0700148class MockSendPacketObserver : public SendPacketObserver {
149 public:
150 MOCK_METHOD3(OnSendPacket, void(uint16_t, int64_t, uint32_t));
151};
152
Stefan Holmera246cfb2016-08-23 17:51:42 +0200153class MockTransportFeedbackObserver : public TransportFeedbackObserver {
154 public:
elad.alond12a8e12017-03-23 11:04:48 -0700155 MOCK_METHOD4(AddPacket,
156 void(uint32_t, uint16_t, size_t, const PacedPacketInfo&));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200157 MOCK_METHOD1(OnTransportFeedback, void(const rtcp::TransportFeedback&));
elad.alonf9490002017-03-06 05:32:21 -0800158 MOCK_CONST_METHOD0(GetTransportFeedbackVector, std::vector<PacketFeedback>());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200159};
160
minyue3a407ee2017-04-03 01:10:33 -0700161class MockOverheadObserver : public OverheadObserver {
162 public:
163 MOCK_METHOD1(OnOverheadChanged, void(size_t overhead_bytes_per_packet));
164};
165
166class RtpSenderTest : public ::testing::TestWithParam<bool> {
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000167 protected:
168 RtpSenderTest()
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000169 : fake_clock_(kStartTime),
terelius429c3452016-01-21 05:42:04 -0800170 mock_rtc_event_log_(),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000171 mock_paced_sender_(),
sprangcd349d92016-07-13 09:11:28 -0700172 retransmission_rate_limiter_(&fake_clock_, 1000),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000173 rtp_sender_(),
174 payload_(kPayload),
175 transport_(),
minyue3a407ee2017-04-03 01:10:33 -0700176 kMarkerBit(true),
177 field_trials_(GetParam() ? "WebRTC-SendSideBwe-WithOverhead/Enabled/"
178 : "") {}
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000179
Erik Språng7b52f102018-02-07 14:37:37 +0100180 void SetUp() override { SetUpRtpSender(true, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200181
Erik Språng7b52f102018-02-07 14:37:37 +0100182 void SetUpRtpSender(bool pacer, bool populate_network2) {
asapersson35151f32016-05-02 23:44:01 -0700183 rtp_sender_.reset(new RTPSender(
184 false, &fake_clock_, &transport_, pacer ? &mock_paced_sender_ : nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -0800185 nullptr, &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
sprangcd349d92016-07-13 09:11:28 -0700186 &mock_rtc_event_log_, &send_packet_observer_,
Benjamin Wright192eeec2018-10-17 17:27:25 -0700187 &retransmission_rate_limiter_, nullptr, populate_network2, nullptr,
Johannes Kron9190b822018-10-29 11:22:05 +0100188 false, false));
brandtr9dfff292016-11-14 05:14:50 -0800189 rtp_sender_->SetSequenceNumber(kSeqNum);
danilchap71fead22016-08-18 02:01:49 -0700190 rtp_sender_->SetTimestampOffset(0);
brandtr9dfff292016-11-14 05:14:50 -0800191 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000192 }
193
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000194 SimulatedClock fake_clock_;
stefana23fc622016-07-28 07:56:38 -0700195 testing::NiceMock<MockRtcEventLog> mock_rtc_event_log_;
sprangebbf8a82015-09-21 15:11:14 -0700196 MockRtpPacketSender mock_paced_sender_;
stefana23fc622016-07-28 07:56:38 -0700197 testing::StrictMock<MockTransportSequenceNumberAllocator> seq_num_allocator_;
198 testing::StrictMock<MockSendPacketObserver> send_packet_observer_;
Stefan Holmera246cfb2016-08-23 17:51:42 +0200199 testing::StrictMock<MockTransportFeedbackObserver> feedback_observer_;
sprangcd349d92016-07-13 09:11:28 -0700200 RateLimiter retransmission_rate_limiter_;
kwiberg84be5112016-04-27 01:19:58 -0700201 std::unique_ptr<RTPSender> rtp_sender_;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000202 int payload_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000203 LoopbackTransportTest transport_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000204 const bool kMarkerBit;
minyue3a407ee2017-04-03 01:10:33 -0700205 test::ScopedFieldTrials field_trials_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000206
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000207 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header) {
danilchapd9e62f52016-01-14 14:55:19 -0800208 VerifyRTPHeaderCommon(rtp_header, kMarkerBit, 0);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000209 }
210
211 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header, bool marker_bit) {
danilchapd9e62f52016-01-14 14:55:19 -0800212 VerifyRTPHeaderCommon(rtp_header, marker_bit, 0);
213 }
214
215 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header,
216 bool marker_bit,
217 uint8_t number_of_csrcs) {
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000218 EXPECT_EQ(marker_bit, rtp_header.markerBit);
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000219 EXPECT_EQ(payload_, rtp_header.payloadType);
220 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
221 EXPECT_EQ(kTimestamp, rtp_header.timestamp);
222 EXPECT_EQ(rtp_sender_->SSRC(), rtp_header.ssrc);
danilchapd9e62f52016-01-14 14:55:19 -0800223 EXPECT_EQ(number_of_csrcs, rtp_header.numCSRCs);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000224 EXPECT_EQ(0U, rtp_header.paddingLength);
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000225 }
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000226
danilchapb6f1fb52016-10-19 06:11:39 -0700227 std::unique_ptr<RtpPacketToSend> BuildRtpPacket(int payload_type,
228 bool marker_bit,
229 uint32_t timestamp,
230 int64_t capture_time_ms) {
231 auto packet = rtp_sender_->AllocatePacket();
232 packet->SetPayloadType(payload_type);
233 packet->SetMarker(marker_bit);
234 packet->SetTimestamp(timestamp);
235 packet->set_capture_time_ms(capture_time_ms);
236 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
237 return packet;
238 }
239
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000240 void SendPacket(int64_t capture_time_ms, int payload_length) {
241 uint32_t timestamp = capture_time_ms * 90;
danilchapb6f1fb52016-10-19 06:11:39 -0700242 auto packet =
243 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
244 packet->AllocatePayload(payload_length);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000245
246 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700247 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
248 kAllowRetransmission,
249 RtpPacketSender::kNormalPriority));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000250 }
asapersson35151f32016-05-02 23:44:01 -0700251
252 void SendGenericPayload() {
asapersson35151f32016-05-02 23:44:01 -0700253 const uint32_t kTimestamp = 1234;
254 const uint8_t kPayloadType = 127;
255 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
256 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
257 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
258 0, 1500));
259
Sami Kalliomäki426a80c2018-08-08 11:37:59 +0200260 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700261 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
Stefan Holmera246cfb2016-08-23 17:51:42 +0200262 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +0200263 sizeof(kPayloadData), nullptr, &video_header, nullptr,
spranga8ae6f22017-09-04 07:23:56 -0700264 kDefaultExpectedRetransmissionTimeMs));
asapersson35151f32016-05-02 23:44:01 -0700265 }
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000266};
267
Peter Boströme23e7372015-10-08 11:44:14 +0200268// TODO(pbos): Move tests over from WithoutPacer to RtpSenderTest as this is our
269// default code path.
270class RtpSenderTestWithoutPacer : public RtpSenderTest {
271 public:
Erik Språng7b52f102018-02-07 14:37:37 +0100272 void SetUp() override { SetUpRtpSender(false, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200273};
274
spranga8ae6f22017-09-04 07:23:56 -0700275class TestRtpSenderVideo : public RTPSenderVideo {
276 public:
277 TestRtpSenderVideo(Clock* clock,
278 RTPSender* rtp_sender,
279 FlexfecSender* flexfec_sender)
Benjamin Wright192eeec2018-10-17 17:27:25 -0700280 : RTPSenderVideo(clock, rtp_sender, flexfec_sender, nullptr, false) {}
spranga8ae6f22017-09-04 07:23:56 -0700281 ~TestRtpSenderVideo() override {}
282
283 StorageType GetStorageType(const RTPVideoHeader& header,
284 int32_t retransmission_settings,
285 int64_t expected_retransmission_time_ms) {
286 return RTPSenderVideo::GetStorageType(GetTemporalId(header),
287 retransmission_settings,
288 expected_retransmission_time_ms);
289 }
290};
291
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000292class RtpSenderVideoTest : public RtpSenderTest {
293 protected:
danilchap162abd32015-12-10 02:39:40 -0800294 void SetUp() override {
Peter Boströme23e7372015-10-08 11:44:14 +0200295 // TODO(pbos): Set up to use pacer.
Erik Språng7b52f102018-02-07 14:37:37 +0100296 SetUpRtpSender(false, false);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000297 rtp_sender_video_.reset(
spranga8ae6f22017-09-04 07:23:56 -0700298 new TestRtpSenderVideo(&fake_clock_, rtp_sender_.get(), nullptr));
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000299 }
spranga8ae6f22017-09-04 07:23:56 -0700300 std::unique_ptr<TestRtpSenderVideo> rtp_sender_video_;
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000301};
302
minyue3a407ee2017-04-03 01:10:33 -0700303TEST_P(RtpSenderTestWithoutPacer, AllocatePacketSetCsrc) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200304 // Configure rtp_sender with csrc.
305 std::vector<uint32_t> csrcs;
306 csrcs.push_back(0x23456789);
307 rtp_sender_->SetCsrcs(csrcs);
308
309 auto packet = rtp_sender_->AllocatePacket();
310
311 ASSERT_TRUE(packet);
312 EXPECT_EQ(rtp_sender_->SSRC(), packet->Ssrc());
313 EXPECT_EQ(csrcs, packet->Csrcs());
314}
315
minyue3a407ee2017-04-03 01:10:33 -0700316TEST_P(RtpSenderTestWithoutPacer, AllocatePacketReserveExtensions) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200317 // Configure rtp_sender with extensions.
318 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
319 kRtpExtensionTransmissionTimeOffset,
320 kTransmissionTimeOffsetExtensionId));
321 ASSERT_EQ(
322 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
323 kAbsoluteSendTimeExtensionId));
324 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
325 kAudioLevelExtensionId));
326 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
327 kRtpExtensionTransportSequenceNumber,
328 kTransportSequenceNumberExtensionId));
329 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
330 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
331
332 auto packet = rtp_sender_->AllocatePacket();
333
334 ASSERT_TRUE(packet);
335 // Preallocate BWE extensions RtpSender set itself.
336 EXPECT_TRUE(packet->HasExtension<TransmissionOffset>());
337 EXPECT_TRUE(packet->HasExtension<AbsoluteSendTime>());
338 EXPECT_TRUE(packet->HasExtension<TransportSequenceNumber>());
339 // Do not allocate media specific extensions.
340 EXPECT_FALSE(packet->HasExtension<AudioLevel>());
341 EXPECT_FALSE(packet->HasExtension<VideoOrientation>());
342}
343
minyue3a407ee2017-04-03 01:10:33 -0700344TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberAdvanceSequenceNumber) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200345 auto packet = rtp_sender_->AllocatePacket();
346 ASSERT_TRUE(packet);
347 const uint16_t sequence_number = rtp_sender_->SequenceNumber();
348
349 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
350
351 EXPECT_EQ(sequence_number, packet->SequenceNumber());
352 EXPECT_EQ(sequence_number + 1, rtp_sender_->SequenceNumber());
353}
354
minyue3a407ee2017-04-03 01:10:33 -0700355TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberFailsOnNotSending) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200356 auto packet = rtp_sender_->AllocatePacket();
357 ASSERT_TRUE(packet);
358
359 rtp_sender_->SetSendingMediaStatus(false);
360 EXPECT_FALSE(rtp_sender_->AssignSequenceNumber(packet.get()));
361}
362
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100363TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberMayAllowPaddingOnVideo) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200364 constexpr size_t kPaddingSize = 100;
365 auto packet = rtp_sender_->AllocatePacket();
366 ASSERT_TRUE(packet);
367
philipel8aadd502017-02-23 02:56:13 -0800368 ASSERT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200369 packet->SetMarker(false);
370 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100371 // Packet without marker bit doesn't allow padding on video stream.
philipel8aadd502017-02-23 02:56:13 -0800372 EXPECT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200373
374 packet->SetMarker(true);
375 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
376 // Packet with marker bit allows send padding.
philipel8aadd502017-02-23 02:56:13 -0800377 EXPECT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200378}
379
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100380TEST_P(RtpSenderTest, AssignSequenceNumberAllowsPaddingOnAudio) {
381 MockTransport transport;
382 const bool kEnableAudio = true;
383 rtp_sender_.reset(new RTPSender(
384 kEnableAudio, &fake_clock_, &transport, &mock_paced_sender_, nullptr,
385 nullptr, nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Johannes Kron9190b822018-10-29 11:22:05 +0100386 nullptr, &retransmission_rate_limiter_, nullptr, false, nullptr, false,
387 false));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100388 rtp_sender_->SetTimestampOffset(0);
389 rtp_sender_->SetSSRC(kSsrc);
390
391 std::unique_ptr<RtpPacketToSend> audio_packet = rtp_sender_->AllocatePacket();
392 // Padding on audio stream allowed regardless of marker in the last packet.
393 audio_packet->SetMarker(false);
394 audio_packet->SetPayloadType(kPayload);
395 rtp_sender_->AssignSequenceNumber(audio_packet.get());
396
397 const size_t kPaddingSize = 59;
398 EXPECT_CALL(transport, SendRtp(_, kPaddingSize + kRtpHeaderSize, _))
399 .WillOnce(testing::Return(true));
400 EXPECT_EQ(kPaddingSize,
401 rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
402
403 // Requested padding size is too small, will send a larger one.
404 const size_t kMinPaddingSize = 50;
405 EXPECT_CALL(transport, SendRtp(_, kMinPaddingSize + kRtpHeaderSize, _))
406 .WillOnce(testing::Return(true));
Yves Gerey665174f2018-06-19 15:03:05 +0200407 EXPECT_EQ(kMinPaddingSize, rtp_sender_->TimeToSendPadding(kMinPaddingSize - 5,
408 PacedPacketInfo()));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100409}
410
minyue3a407ee2017-04-03 01:10:33 -0700411TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberSetPaddingTimestamps) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200412 constexpr size_t kPaddingSize = 100;
413 auto packet = rtp_sender_->AllocatePacket();
414 ASSERT_TRUE(packet);
415 packet->SetMarker(true);
416 packet->SetTimestamp(kTimestamp);
417
418 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
philipel8aadd502017-02-23 02:56:13 -0800419 ASSERT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200420
421 ASSERT_EQ(1u, transport_.sent_packets_.size());
danilchap12ba1862016-10-26 02:41:55 -0700422 // Verify padding packet timestamp.
423 EXPECT_EQ(kTimestamp, transport_.last_sent_packet().Timestamp());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200424}
425
minyue3a407ee2017-04-03 01:10:33 -0700426TEST_P(RtpSenderTestWithoutPacer,
427 TransportFeedbackObserverGetsCorrectByteCount) {
428 constexpr int kRtpOverheadBytesPerPacket = 12 + 8;
429 testing::NiceMock<MockOverheadObserver> mock_overhead_observer;
430 rtp_sender_.reset(new RTPSender(
431 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
432 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Benjamin Wright192eeec2018-10-17 17:27:25 -0700433 nullptr, &retransmission_rate_limiter_, &mock_overhead_observer, false,
Johannes Kron9190b822018-10-29 11:22:05 +0100434 nullptr, false, false));
minyue3a407ee2017-04-03 01:10:33 -0700435 rtp_sender_->SetSSRC(kSsrc);
436 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
437 kRtpExtensionTransportSequenceNumber,
438 kTransportSequenceNumberExtensionId));
439 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
440 .WillOnce(testing::Return(kTransportSequenceNumber));
441
442 const size_t expected_bytes =
443 GetParam() ? sizeof(kPayloadData) + kGenericHeaderLength +
444 kRtpOverheadBytesPerPacket
445 : sizeof(kPayloadData) + kGenericHeaderLength;
446
447 EXPECT_CALL(feedback_observer_,
448 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber,
449 expected_bytes, PacedPacketInfo()))
450 .Times(1);
451 EXPECT_CALL(mock_overhead_observer,
452 OnOverheadChanged(kRtpOverheadBytesPerPacket))
453 .Times(1);
454 SendGenericPayload();
455}
456
457TEST_P(RtpSenderTestWithoutPacer, SendsPacketsWithTransportSequenceNumber) {
Stefan Holmera246cfb2016-08-23 17:51:42 +0200458 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800459 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
460 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Benjamin Wright192eeec2018-10-17 17:27:25 -0700461 &send_packet_observer_, &retransmission_rate_limiter_, nullptr, false,
Johannes Kron9190b822018-10-29 11:22:05 +0100462 nullptr, false, false));
nisse7d59f6b2017-02-21 03:40:24 -0800463 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100464 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
465 kRtpExtensionTransportSequenceNumber,
466 kTransportSequenceNumberExtensionId));
467
Stefan Holmerf5dca482016-01-27 12:58:51 +0100468 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
469 .WillOnce(testing::Return(kTransportSequenceNumber));
asapersson35151f32016-05-02 23:44:01 -0700470 EXPECT_CALL(send_packet_observer_,
471 OnSendPacket(kTransportSequenceNumber, _, _))
472 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700473
474 EXPECT_CALL(feedback_observer_,
475 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
476 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200477 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700478
479 SendGenericPayload();
Stefan Holmerf5dca482016-01-27 12:58:51 +0100480
danilchap12ba1862016-10-26 02:41:55 -0700481 const auto& packet = transport_.last_sent_packet();
482 uint16_t transport_seq_no;
483 ASSERT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
484 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200485 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200486 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200487}
488
489TEST_P(RtpSenderTestWithoutPacer, PacketOptionsNoRetransmission) {
490 rtp_sender_.reset(new RTPSender(
491 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
492 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Benjamin Wright192eeec2018-10-17 17:27:25 -0700493 &send_packet_observer_, &retransmission_rate_limiter_, nullptr, false,
Johannes Kron9190b822018-10-29 11:22:05 +0100494 nullptr, false, false));
Petter Strandmark26bc6692018-05-29 08:43:35 +0200495 rtp_sender_->SetSSRC(kSsrc);
496
497 SendGenericPayload();
498
499 EXPECT_FALSE(transport_.last_options_.is_retransmit);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100500}
501
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200502TEST_P(RtpSenderTestWithoutPacer,
503 SetsIncludedInFeedbackWhenTransportSequenceNumberExtensionIsRegistered) {
504 SetUpRtpSender(false, false);
505 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber,
506 kTransportSequenceNumberExtensionId);
507 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
508 .WillOnce(testing::Return(kTransportSequenceNumber));
509 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
stefana23fc622016-07-28 07:56:38 -0700510 SendGenericPayload();
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200511 EXPECT_TRUE(transport_.last_options_.included_in_feedback);
512}
513
514TEST_P(
515 RtpSenderTestWithoutPacer,
516 SetsIncludedInAllocationWhenTransportSequenceNumberExtensionIsRegistered) {
517 SetUpRtpSender(false, false);
518 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber,
519 kTransportSequenceNumberExtensionId);
520 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
521 .WillOnce(testing::Return(kTransportSequenceNumber));
522 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
523 SendGenericPayload();
524 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
525}
526
527TEST_P(RtpSenderTestWithoutPacer,
528 SetsIncludedInAllocationWhenForcedAsPartOfAllocation) {
529 SetUpRtpSender(false, false);
530 rtp_sender_->SetAsPartOfAllocation(true);
531 SendGenericPayload();
532 EXPECT_FALSE(transport_.last_options_.included_in_feedback);
533 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
534}
535
536TEST_P(RtpSenderTestWithoutPacer, DoesnSetIncludedInAllocationByDefault) {
537 SetUpRtpSender(false, false);
538 SendGenericPayload();
539 EXPECT_FALSE(transport_.last_options_.included_in_feedback);
540 EXPECT_FALSE(transport_.last_options_.included_in_allocation);
stefana23fc622016-07-28 07:56:38 -0700541}
asapersson35151f32016-05-02 23:44:01 -0700542
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200543TEST_P(RtpSenderTestWithoutPacer, OnSendSideDelayUpdated) {
544 testing::StrictMock<MockSendSideDelayObserver> send_side_delay_observer_;
Benjamin Wright192eeec2018-10-17 17:27:25 -0700545 rtp_sender_.reset(new RTPSender(
546 false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
547 nullptr, nullptr, &send_side_delay_observer_, &mock_rtc_event_log_,
Johannes Kron9190b822018-10-29 11:22:05 +0100548 nullptr, nullptr, nullptr, false, nullptr, false, false));
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200549 rtp_sender_->SetSSRC(kSsrc);
550
551 const uint8_t kPayloadType = 127;
552 const uint32_t kCaptureTimeMsToRtpTimestamp = 90; // 90 kHz clock
553 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
554 RTPVideoHeader video_header;
555 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType,
556 1000 * kCaptureTimeMsToRtpTimestamp,
557 0, 1500));
558
559 // Send packet with 10 ms send-side delay. The average and max should be 10
560 // ms.
561 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(10, 10, kSsrc))
562 .Times(1);
563 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
564 fake_clock_.AdvanceTimeMilliseconds(10);
565 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
566 kVideoFrameKey, kPayloadType,
567 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
568 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
569 kDefaultExpectedRetransmissionTimeMs));
570
571 // Send another packet with 20 ms delay. The average
572 // and max should be 15 and 20 ms respectively.
573 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(15, 20, kSsrc))
574 .Times(1);
575 fake_clock_.AdvanceTimeMilliseconds(10);
576 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
577 kVideoFrameKey, kPayloadType,
578 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
579 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
580 kDefaultExpectedRetransmissionTimeMs));
581
582 // Send another packet at the same time, which replaces the last packet.
583 // Since this packet has 0 ms delay, the average is now 5 ms and max is 10 ms.
584 // TODO(terelius): Is is not clear that this is the right behavior.
585 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(5, 10, kSsrc))
586 .Times(1);
587 capture_time_ms = fake_clock_.TimeInMilliseconds();
588 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
589 kVideoFrameKey, kPayloadType,
590 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
591 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
592 kDefaultExpectedRetransmissionTimeMs));
593
594 // Send a packet 1 second later. The earlier packets should have timed
595 // out, so both max and average should be the delay of this packet.
596 fake_clock_.AdvanceTimeMilliseconds(1000);
597 capture_time_ms = fake_clock_.TimeInMilliseconds();
598 fake_clock_.AdvanceTimeMilliseconds(1);
599 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(1, 1, kSsrc))
600 .Times(1);
601 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
602 kVideoFrameKey, kPayloadType,
603 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
604 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
605 kDefaultExpectedRetransmissionTimeMs));
606}
607
minyue3a407ee2017-04-03 01:10:33 -0700608TEST_P(RtpSenderTestWithoutPacer, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700609 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
610 kRtpExtensionTransportSequenceNumber,
611 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700612 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
613 .WillOnce(testing::Return(kTransportSequenceNumber));
614 EXPECT_CALL(send_packet_observer_,
615 OnSendPacket(kTransportSequenceNumber, _, _))
616 .Times(1);
617
618 SendGenericPayload();
619}
620
minyue3a407ee2017-04-03 01:10:33 -0700621TEST_P(RtpSenderTest, SendsPacketsWithTransportSequenceNumber) {
michaelt4da30442016-11-17 01:38:43 -0800622 rtp_sender_.reset(new RTPSender(
623 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
624 &seq_num_allocator_, &feedback_observer_, nullptr, nullptr, nullptr,
625 &mock_rtc_event_log_, &send_packet_observer_,
Johannes Kron9190b822018-10-29 11:22:05 +0100626 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
brandtr9dfff292016-11-14 05:14:50 -0800627 rtp_sender_->SetSequenceNumber(kSeqNum);
628 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200629 rtp_sender_->SetStorePacketsStatus(true, 10);
630 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
631 kRtpExtensionTransportSequenceNumber,
632 kTransportSequenceNumberExtensionId));
633
brandtr9dfff292016-11-14 05:14:50 -0800634 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200635 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
636 .WillOnce(testing::Return(kTransportSequenceNumber));
637 EXPECT_CALL(send_packet_observer_,
638 OnSendPacket(kTransportSequenceNumber, _, _))
639 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700640 EXPECT_CALL(feedback_observer_,
641 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
642 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200643 .Times(1);
644
645 SendGenericPayload();
philipel8aadd502017-02-23 02:56:13 -0800646 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
647 fake_clock_.TimeInMilliseconds(), false,
648 PacedPacketInfo());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200649
danilchap12ba1862016-10-26 02:41:55 -0700650 const auto& packet = transport_.last_sent_packet();
651 uint16_t transport_seq_no;
652 EXPECT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
653 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200654 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200655}
656
Erik Språng7b52f102018-02-07 14:37:37 +0100657TEST_P(RtpSenderTest, WritesPacerExitToTimingExtension) {
ilnik04f4d122017-06-19 07:18:55 -0700658 rtp_sender_->SetStorePacketsStatus(true, 10);
659 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
660 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
661 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
662 auto packet = rtp_sender_->AllocatePacket();
663 packet->SetPayloadType(kPayload);
664 packet->SetMarker(true);
665 packet->SetTimestamp(kTimestamp);
666 packet->set_capture_time_ms(capture_time_ms);
ilnik2edc6842017-07-06 03:06:50 -0700667 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
ilnik04f4d122017-06-19 07:18:55 -0700668 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
669 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
670 size_t packet_size = packet->size();
ilnik04f4d122017-06-19 07:18:55 -0700671
672 const int kStoredTimeInMs = 100;
Erik Språng7b52f102018-02-07 14:37:37 +0100673 {
674 EXPECT_CALL(
675 mock_paced_sender_,
676 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _));
677 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
678 kAllowRetransmission,
679 RtpPacketSender::kNormalPriority));
680 }
ilnik04f4d122017-06-19 07:18:55 -0700681 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
Erik Språng7b52f102018-02-07 14:37:37 +0100682 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
683 PacedPacketInfo());
ilnik04f4d122017-06-19 07:18:55 -0700684 EXPECT_EQ(1, transport_.packets_sent());
685 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
686
danilchapce251812017-09-11 12:24:41 -0700687 VideoSendTiming video_timing;
688 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
689 &video_timing));
690 EXPECT_EQ(kStoredTimeInMs, video_timing.pacer_exit_delta_ms);
Erik Språng7b52f102018-02-07 14:37:37 +0100691}
ilnik04f4d122017-06-19 07:18:55 -0700692
Erik Språng7b52f102018-02-07 14:37:37 +0100693TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtension) {
694 SetUpRtpSender(true, true);
695 rtp_sender_->SetStorePacketsStatus(true, 10);
696 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
697 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
698 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
699 auto packet = rtp_sender_->AllocatePacket();
700 packet->SetPayloadType(kPayload);
701 packet->SetMarker(true);
702 packet->SetTimestamp(kTimestamp);
703 packet->set_capture_time_ms(capture_time_ms);
704 const uint16_t kPacerExitMs = 1234u;
705 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, kPacerExitMs, 0u, 0u, true};
706 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
707 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
708 size_t packet_size = packet->size();
709
710 const int kStoredTimeInMs = 100;
711 {
712 EXPECT_CALL(
713 mock_paced_sender_,
714 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _));
715 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
716 kAllowRetransmission,
717 RtpPacketSender::kNormalPriority));
718 }
ilnik04f4d122017-06-19 07:18:55 -0700719 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
720 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
721 PacedPacketInfo());
Erik Språng7b52f102018-02-07 14:37:37 +0100722 EXPECT_EQ(1, transport_.packets_sent());
ilnik04f4d122017-06-19 07:18:55 -0700723 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
724
Erik Språng7b52f102018-02-07 14:37:37 +0100725 VideoSendTiming video_timing;
danilchapce251812017-09-11 12:24:41 -0700726 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
727 &video_timing));
Erik Språng7b52f102018-02-07 14:37:37 +0100728 EXPECT_EQ(kStoredTimeInMs, video_timing.network2_timestamp_delta_ms);
729 EXPECT_EQ(kPacerExitMs, video_timing.pacer_exit_delta_ms);
ilnik04f4d122017-06-19 07:18:55 -0700730}
731
minyue3a407ee2017-04-03 01:10:33 -0700732TEST_P(RtpSenderTest, TrafficSmoothingWithExtensions) {
Peter Boströme23e7372015-10-08 11:44:14 +0200733 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800734 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200735 EXPECT_CALL(mock_rtc_event_log_,
736 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000737
pwestin@webrtc.orgc66e8b32012-11-07 17:01:04 +0000738 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000739 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800740 kRtpExtensionTransmissionTimeOffset,
741 kTransmissionTimeOffsetExtensionId));
742 EXPECT_EQ(
743 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
744 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000745 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700746 auto packet =
747 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
748 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000749
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000750 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700751 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
752 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700753 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000754
danilchap12ba1862016-10-26 02:41:55 -0700755 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000756
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000757 const int kStoredTimeInMs = 100;
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000758 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000759
brandtr9dfff292016-11-14 05:14:50 -0800760 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800761 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000762
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000763 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700764 EXPECT_EQ(1, transport_.packets_sent());
765 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
766
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000767 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700768 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000769
770 // Verify transmission time offset.
771 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000772 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000773 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000774 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000775}
776
minyue3a407ee2017-04-03 01:10:33 -0700777TEST_P(RtpSenderTest, TrafficSmoothingRetransmits) {
Peter Boströme23e7372015-10-08 11:44:14 +0200778 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800779 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200780 EXPECT_CALL(mock_rtc_event_log_,
781 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000782
783 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000784 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800785 kRtpExtensionTransmissionTimeOffset,
786 kTransmissionTimeOffsetExtensionId));
787 EXPECT_EQ(
788 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
789 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000790 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700791 auto packet =
792 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
793 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000794
795 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700796 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
797 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700798 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000799
danilchap12ba1862016-10-26 02:41:55 -0700800 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000801
terelius5d332ac2016-01-14 14:37:39 -0800802 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800803 kSsrc, kSeqNum, _, _, _));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000804
805 const int kStoredTimeInMs = 100;
806 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
807
danilchapb6f1fb52016-10-19 06:11:39 -0700808 EXPECT_EQ(static_cast<int>(packet_size), rtp_sender_->ReSendPacket(kSeqNum));
danilchap12ba1862016-10-26 02:41:55 -0700809 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000810
brandtr9dfff292016-11-14 05:14:50 -0800811 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800812 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000813
814 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700815 EXPECT_EQ(1, transport_.packets_sent());
816 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000817
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000818 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700819 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000820
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000821 // Verify transmission time offset.
822 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000823 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000824 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
825 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
826}
827
828// This test sends 1 regular video packet, then 4 padding packets, and then
829// 1 more regular packet.
minyue3a407ee2017-04-03 01:10:33 -0700830TEST_P(RtpSenderTest, SendPadding) {
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000831 // Make all (non-padding) packets go to send queue.
terelius5d332ac2016-01-14 14:37:39 -0800832 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800833 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200834 EXPECT_CALL(mock_rtc_event_log_,
835 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
836 .Times(1 + 4 + 1);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000837
838 uint16_t seq_num = kSeqNum;
839 uint32_t timestamp = kTimestamp;
840 rtp_sender_->SetStorePacketsStatus(true, 10);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000841 size_t rtp_header_len = kRtpHeaderSize;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000842 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800843 kRtpExtensionTransmissionTimeOffset,
844 kTransmissionTimeOffsetExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000845 rtp_header_len += 4; // 4 bytes extension.
danilchap162abd32015-12-10 02:39:40 -0800846 EXPECT_EQ(
847 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
848 kAbsoluteSendTimeExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000849 rtp_header_len += 4; // 4 bytes extension.
850 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
851
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000852 webrtc::RTPHeader rtp_header;
853
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000854 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700855 auto packet =
856 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200857 const uint32_t media_packet_timestamp = timestamp;
danilchapb6f1fb52016-10-19 06:11:39 -0700858 size_t packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000859
860 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700861 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
862 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700863 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000864
865 int total_packets_sent = 0;
danilchap12ba1862016-10-26 02:41:55 -0700866 EXPECT_EQ(total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000867
868 const int kStoredTimeInMs = 100;
869 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
brandtr9dfff292016-11-14 05:14:50 -0800870 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800871 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000872 // Packet should now be sent. This test doesn't verify the regular video
873 // packet, since it is tested in another test.
danilchap12ba1862016-10-26 02:41:55 -0700874 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000875 timestamp += 90 * kStoredTimeInMs;
876
877 // Send padding 4 times, waiting 50 ms between each.
878 for (int i = 0; i < 4; ++i) {
879 const int kPaddingPeriodMs = 50;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000880 const size_t kPaddingBytes = 100;
881 const size_t kMaxPaddingLength = 224; // Value taken from rtp_sender.cc.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000882 // Padding will be forced to full packets.
philipelc7bf32a2017-02-17 03:59:43 -0800883 EXPECT_EQ(kMaxPaddingLength,
philipel8aadd502017-02-23 02:56:13 -0800884 rtp_sender_->TimeToSendPadding(kPaddingBytes, PacedPacketInfo()));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000885
886 // Process send bucket. Padding should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700887 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000888 EXPECT_EQ(kMaxPaddingLength + rtp_header_len,
danilchap12ba1862016-10-26 02:41:55 -0700889 transport_.last_sent_packet().size());
890
891 transport_.last_sent_packet().GetHeader(&rtp_header);
pbosbd2522a2015-07-01 05:35:53 -0700892 EXPECT_EQ(kMaxPaddingLength, rtp_header.paddingLength);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000893
Stefan Holmer586b19b2015-09-18 11:14:31 +0200894 // Verify sequence number and timestamp. The timestamp should be the same
895 // as the last media packet.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000896 EXPECT_EQ(seq_num++, rtp_header.sequenceNumber);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200897 EXPECT_EQ(media_packet_timestamp, rtp_header.timestamp);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000898 // Verify transmission time offset.
Stefan Holmer586b19b2015-09-18 11:14:31 +0200899 int offset = timestamp - media_packet_timestamp;
900 EXPECT_EQ(offset, rtp_header.extension.transmissionTimeOffset);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000901 uint64_t expected_send_time =
902 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
903 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
904 fake_clock_.AdvanceTimeMilliseconds(kPaddingPeriodMs);
905 timestamp += 90 * kPaddingPeriodMs;
906 }
907
908 // Send a regular video packet again.
909 capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700910 packet = BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
911 packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000912
brandtr9dfff292016-11-14 05:14:50 -0800913 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
914 kSsrc, seq_num, _, _, _));
terelius5d332ac2016-01-14 14:37:39 -0800915
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000916 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700917 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
918 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700919 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000920
brandtr9dfff292016-11-14 05:14:50 -0800921 rtp_sender_->TimeToSendPacket(kSsrc, seq_num, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800922 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000923 // Process send bucket.
danilchap12ba1862016-10-26 02:41:55 -0700924 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
925 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
926 transport_.last_sent_packet().GetHeader(&rtp_header);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000927
928 // Verify sequence number and timestamp.
929 EXPECT_EQ(seq_num, rtp_header.sequenceNumber);
930 EXPECT_EQ(timestamp, rtp_header.timestamp);
931 // Verify transmission time offset. This packet is sent without delay.
932 EXPECT_EQ(0, rtp_header.extension.transmissionTimeOffset);
933 uint64_t expected_send_time =
934 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000935 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000936}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000937
minyue3a407ee2017-04-03 01:10:33 -0700938TEST_P(RtpSenderTest, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700939 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
940 kRtpExtensionTransportSequenceNumber,
941 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700942 rtp_sender_->SetStorePacketsStatus(true, 10);
943
944 EXPECT_CALL(send_packet_observer_,
945 OnSendPacket(kTransportSequenceNumber, _, _))
946 .Times(1);
947 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
948 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800949 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
950 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700951
952 SendGenericPayload(); // Packet passed to pacer.
953 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -0800954 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
955 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800956 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700957 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700958}
959
minyue3a407ee2017-04-03 01:10:33 -0700960TEST_P(RtpSenderTest, OnSendPacketNotUpdatedForRetransmits) {
stefana23fc622016-07-28 07:56:38 -0700961 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
962 kRtpExtensionTransportSequenceNumber,
963 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700964 rtp_sender_->SetStorePacketsStatus(true, 10);
965
966 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
967 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
968 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800969 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
970 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700971
972 SendGenericPayload(); // Packet passed to pacer.
973 const bool kIsRetransmit = true;
brandtr9dfff292016-11-14 05:14:50 -0800974 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
975 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800976 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700977 EXPECT_EQ(1, transport_.packets_sent());
Petter Strandmark26bc6692018-05-29 08:43:35 +0200978 EXPECT_TRUE(transport_.last_options_.is_retransmit);
asapersson35151f32016-05-02 23:44:01 -0700979}
980
minyue3a407ee2017-04-03 01:10:33 -0700981TEST_P(RtpSenderTest, OnSendPacketNotUpdatedWithoutSeqNumAllocator) {
asapersson35151f32016-05-02 23:44:01 -0700982 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800983 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
asapersson35151f32016-05-02 23:44:01 -0700984 nullptr /* TransportSequenceNumberAllocator */, nullptr, nullptr, nullptr,
michaelt4da30442016-11-17 01:38:43 -0800985 nullptr, nullptr, &send_packet_observer_, &retransmission_rate_limiter_,
Johannes Kron9190b822018-10-29 11:22:05 +0100986 nullptr, false, nullptr, false, false));
brandtr9dfff292016-11-14 05:14:50 -0800987 rtp_sender_->SetSequenceNumber(kSeqNum);
988 rtp_sender_->SetSSRC(kSsrc);
stefana23fc622016-07-28 07:56:38 -0700989 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
990 kRtpExtensionTransportSequenceNumber,
991 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700992 rtp_sender_->SetSequenceNumber(kSeqNum);
993 rtp_sender_->SetStorePacketsStatus(true, 10);
994
995 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
brandtr9dfff292016-11-14 05:14:50 -0800996 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
997 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700998
999 SendGenericPayload(); // Packet passed to pacer.
1000 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -08001001 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
1002 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -08001003 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -07001004 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -07001005}
1006
minyue3a407ee2017-04-03 01:10:33 -07001007TEST_P(RtpSenderTest, SendRedundantPayloads) {
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001008 MockTransport transport;
terelius429c3452016-01-21 05:42:04 -08001009 rtp_sender_.reset(new RTPSender(
asapersson35151f32016-05-02 23:44:01 -07001010 false, &fake_clock_, &transport, &mock_paced_sender_, nullptr, nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -08001011 nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_, nullptr,
Johannes Kron9190b822018-10-29 11:22:05 +01001012 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001013 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr9dfff292016-11-14 05:14:50 -08001014 rtp_sender_->SetSSRC(kSsrc);
Shao Changbine62202f2015-04-21 20:24:50 +08001015 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001016
1017 uint16_t seq_num = kSeqNum;
1018 rtp_sender_->SetStorePacketsStatus(true, 10);
wu@webrtc.orgebdb0e32014-03-06 23:49:08 +00001019 int32_t rtp_header_len = kRtpHeaderSize;
danilchap162abd32015-12-10 02:39:40 -08001020 EXPECT_EQ(
1021 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
1022 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001023 rtp_header_len += 4; // 4 bytes extension.
1024 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
1025
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +00001026 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
stefan@webrtc.orgef927552014-06-05 08:25:29 +00001027 rtp_sender_->SetRtxSsrc(1234);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001028
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001029 const size_t kNumPayloadSizes = 10;
danilchap162abd32015-12-10 02:39:40 -08001030 const size_t kPayloadSizes[kNumPayloadSizes] = {500, 550, 600, 650, 700,
1031 750, 800, 850, 900, 950};
terelius5d332ac2016-01-14 14:37:39 -08001032 // Expect all packets go through the pacer.
1033 EXPECT_CALL(mock_paced_sender_,
brandtr9dfff292016-11-14 05:14:50 -08001034 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _))
terelius5d332ac2016-01-14 14:37:39 -08001035 .Times(kNumPayloadSizes);
Elad Alon4a87e1c2017-10-03 16:11:34 +02001036 EXPECT_CALL(mock_rtc_event_log_,
1037 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -08001038 .Times(kNumPayloadSizes);
1039
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001040 // Send 10 packets of increasing size.
1041 for (size_t i = 0; i < kNumPayloadSizes; ++i) {
1042 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
stefan1d8a5062015-10-02 03:39:33 -07001043 EXPECT_CALL(transport, SendRtp(_, _, _)).WillOnce(testing::Return(true));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001044 SendPacket(capture_time_ms, kPayloadSizes[i]);
brandtr9dfff292016-11-14 05:14:50 -08001045 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -08001046 PacedPacketInfo());
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001047 fake_clock_.AdvanceTimeMilliseconds(33);
1048 }
terelius429c3452016-01-21 05:42:04 -08001049
Elad Alon4a87e1c2017-10-03 16:11:34 +02001050 EXPECT_CALL(mock_rtc_event_log_,
1051 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -08001052 .Times(::testing::AtLeast(4));
1053
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001054 // The amount of padding to send it too small to send a payload packet.
stefan1d8a5062015-10-02 03:39:33 -07001055 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
pbos2d566682015-09-28 09:59:31 -07001056 .WillOnce(testing::Return(true));
philipela1ed0b32016-06-01 06:31:17 -07001057 EXPECT_EQ(kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -08001058 rtp_sender_->TimeToSendPadding(49, PacedPacketInfo()));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001059
Petter Strandmark26bc6692018-05-29 08:43:35 +02001060 PacketOptions options;
Peter Boströmac547a62015-09-17 23:03:57 +02001061 EXPECT_CALL(transport,
stefan1d8a5062015-10-02 03:39:33 -07001062 SendRtp(_, kPayloadSizes[0] + rtp_header_len + kRtxHeaderSize, _))
Yves Gerey665174f2018-06-19 15:03:05 +02001063 .WillOnce(
1064 testing::DoAll(testing::SaveArg<2>(&options), testing::Return(true)));
philipela1ed0b32016-06-01 06:31:17 -07001065 EXPECT_EQ(kPayloadSizes[0],
philipel8aadd502017-02-23 02:56:13 -08001066 rtp_sender_->TimeToSendPadding(500, PacedPacketInfo()));
Petter Strandmark26bc6692018-05-29 08:43:35 +02001067 EXPECT_TRUE(options.is_retransmit);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001068
Yves Gerey665174f2018-06-19 15:03:05 +02001069 EXPECT_CALL(transport, SendRtp(_,
1070 kPayloadSizes[kNumPayloadSizes - 1] +
1071 rtp_header_len + kRtxHeaderSize,
stefan1d8a5062015-10-02 03:39:33 -07001072 _))
pbos2d566682015-09-28 09:59:31 -07001073 .WillOnce(testing::Return(true));
Petter Strandmark26bc6692018-05-29 08:43:35 +02001074
1075 options.is_retransmit = false;
stefan1d8a5062015-10-02 03:39:33 -07001076 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
Yves Gerey665174f2018-06-19 15:03:05 +02001077 .WillOnce(
1078 testing::DoAll(testing::SaveArg<2>(&options), testing::Return(true)));
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001079 EXPECT_EQ(kPayloadSizes[kNumPayloadSizes - 1] + kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -08001080 rtp_sender_->TimeToSendPadding(999, PacedPacketInfo()));
Petter Strandmark26bc6692018-05-29 08:43:35 +02001081 EXPECT_FALSE(options.is_retransmit);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001082}
1083
minyue3a407ee2017-04-03 01:10:33 -07001084TEST_P(RtpSenderTestWithoutPacer, SendGenericVideo) {
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001085 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1086 const uint8_t payload_type = 127;
1087 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1088 0, 1500));
1089 uint8_t payload[] = {47, 11, 32, 93, 89};
1090
1091 // Send keyframe
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001092 RTPVideoHeader video_header;
spranga8ae6f22017-09-04 07:23:56 -07001093 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1094 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001095 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001096
danilchap96c15872016-11-21 01:35:29 -08001097 auto sent_payload = transport_.last_sent_packet().payload();
1098 uint8_t generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001099 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
1100 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -08001101 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001102
1103 // Send delta frame
1104 payload[0] = 13;
1105 payload[1] = 42;
1106 payload[4] = 13;
1107
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001108 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1109 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001110 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001111
danilchap96c15872016-11-21 01:35:29 -08001112 sent_payload = transport_.last_sent_packet().payload();
1113 generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001114 EXPECT_FALSE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
1115 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -08001116 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001117}
1118
minyue3a407ee2017-04-03 01:10:33 -07001119TEST_P(RtpSenderTest, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -08001120 constexpr int kMediaPayloadType = 127;
1121 constexpr int kFlexfecPayloadType = 118;
1122 constexpr uint32_t kMediaSsrc = 1234;
1123 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001124 const char kNoMid[] = "";
brandtrdbdb3f12016-11-10 05:04:48 -08001125 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001126 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -08001127 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001128 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001129 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001130
1131 // Reset |rtp_sender_| to use FlexFEC.
michaelt4da30442016-11-17 01:38:43 -08001132 rtp_sender_.reset(new RTPSender(
1133 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1134 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1135 &mock_rtc_event_log_, &send_packet_observer_,
Johannes Kron9190b822018-10-29 11:22:05 +01001136 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
brandtrdbdb3f12016-11-10 05:04:48 -08001137 rtp_sender_->SetSSRC(kMediaSsrc);
1138 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001139 rtp_sender_->SetStorePacketsStatus(true, 10);
1140
1141 // Parameters selected to generate a single FEC packet per media packet.
1142 FecProtectionParams params;
1143 params.fec_rate = 15;
1144 params.max_fec_frames = 1;
1145 params.fec_mask_type = kFecMaskRandom;
1146 rtp_sender_->SetFecParameters(params, params);
1147
brandtr9dfff292016-11-14 05:14:50 -08001148 EXPECT_CALL(mock_paced_sender_,
1149 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
1150 _, _, false));
1151 uint16_t flexfec_seq_num;
brandtrdbdb3f12016-11-10 05:04:48 -08001152 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
brandtr9dfff292016-11-14 05:14:50 -08001153 kFlexfecSsrc, _, _, _, false))
1154 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
brandtrdbdb3f12016-11-10 05:04:48 -08001155 SendGenericPayload();
Elad Alon4a87e1c2017-10-03 16:11:34 +02001156 EXPECT_CALL(mock_rtc_event_log_,
1157 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1158 .Times(2);
philipel8aadd502017-02-23 02:56:13 -08001159 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
1160 fake_clock_.TimeInMilliseconds(),
1161 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -08001162 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
1163 fake_clock_.TimeInMilliseconds(),
philipel8aadd502017-02-23 02:56:13 -08001164 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -08001165 ASSERT_EQ(2, transport_.packets_sent());
brandtrdbdb3f12016-11-10 05:04:48 -08001166 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1167 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
brandtr9dfff292016-11-14 05:14:50 -08001168 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
brandtrdbdb3f12016-11-10 05:04:48 -08001169 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
brandtr9dfff292016-11-14 05:14:50 -08001170 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1171 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1172 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1173 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001174}
1175
ilnik10894992017-06-21 08:23:19 -07001176// TODO(ilnik): because of webrtc:7859. Once FEC moved below pacer, this test
1177// should be removed.
1178TEST_P(RtpSenderTest, NoFlexfecForTimingFrames) {
1179 constexpr int kMediaPayloadType = 127;
1180 constexpr int kFlexfecPayloadType = 118;
1181 constexpr uint32_t kMediaSsrc = 1234;
1182 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001183 const char kNoMid[] = "";
ilnik10894992017-06-21 08:23:19 -07001184 const std::vector<RtpExtension> kNoRtpExtensions;
1185 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
ilnike4350192017-06-29 02:27:44 -07001186
ilnik10894992017-06-21 08:23:19 -07001187 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001188 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
ilnik10894992017-06-21 08:23:19 -07001189 nullptr /* rtp_state */, &fake_clock_);
1190
1191 // Reset |rtp_sender_| to use FlexFEC.
1192 rtp_sender_.reset(new RTPSender(
1193 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1194 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1195 &mock_rtc_event_log_, &send_packet_observer_,
Johannes Kron9190b822018-10-29 11:22:05 +01001196 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
ilnik10894992017-06-21 08:23:19 -07001197 rtp_sender_->SetSSRC(kMediaSsrc);
1198 rtp_sender_->SetSequenceNumber(kSeqNum);
ilnik10894992017-06-21 08:23:19 -07001199 rtp_sender_->SetStorePacketsStatus(true, 10);
1200
ilnike4350192017-06-29 02:27:44 -07001201 // Need extension to be registered for timing frames to be sent.
1202 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1203 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1204
ilnik10894992017-06-21 08:23:19 -07001205 // Parameters selected to generate a single FEC packet per media packet.
1206 FecProtectionParams params;
1207 params.fec_rate = 15;
1208 params.max_fec_frames = 1;
1209 params.fec_mask_type = kFecMaskRandom;
1210 rtp_sender_->SetFecParameters(params, params);
1211
1212 EXPECT_CALL(mock_paced_sender_,
1213 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
1214 _, _, false));
1215 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1216 kFlexfecSsrc, _, _, _, false))
1217 .Times(0); // Not called because packet should not be protected.
1218
1219 const uint32_t kTimestamp = 1234;
1220 const uint8_t kPayloadType = 127;
1221 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
1222 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1223 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
1224 0, 1500));
1225 RTPVideoHeader video_header;
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001226 video_header.video_timing.flags = VideoSendTiming::kTriggeredByTimer;
ilnik10894992017-06-21 08:23:19 -07001227 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1228 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
spranga8ae6f22017-09-04 07:23:56 -07001229 sizeof(kPayloadData), nullptr, &video_header, nullptr,
1230 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001231
Elad Alon4a87e1c2017-10-03 16:11:34 +02001232 EXPECT_CALL(mock_rtc_event_log_,
1233 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1234 .Times(1);
ilnik10894992017-06-21 08:23:19 -07001235 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
1236 fake_clock_.TimeInMilliseconds(),
1237 false, PacedPacketInfo()));
1238 ASSERT_EQ(1, transport_.packets_sent());
1239 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1240 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1241 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
1242 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1243
1244 // Now try to send not a timing frame.
1245 uint16_t flexfec_seq_num;
1246 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1247 kFlexfecSsrc, _, _, _, false))
1248 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
1249 EXPECT_CALL(mock_paced_sender_,
1250 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc,
1251 kSeqNum + 1, _, _, false));
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001252 video_header.video_timing.flags = VideoSendTiming::kInvalid;
ilnik10894992017-06-21 08:23:19 -07001253 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1254 kVideoFrameKey, kPayloadType, kTimestamp + 1, kCaptureTimeMs + 1,
spranga8ae6f22017-09-04 07:23:56 -07001255 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
1256 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001257
Elad Alon4a87e1c2017-10-03 16:11:34 +02001258 EXPECT_CALL(mock_rtc_event_log_,
1259 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1260 .Times(2);
ilnik10894992017-06-21 08:23:19 -07001261 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum + 1,
1262 fake_clock_.TimeInMilliseconds(),
1263 false, PacedPacketInfo()));
1264 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
1265 fake_clock_.TimeInMilliseconds(),
1266 false, PacedPacketInfo()));
1267 ASSERT_EQ(3, transport_.packets_sent());
1268 const RtpPacketReceived& media_packet2 = transport_.sent_packets_[1];
1269 EXPECT_EQ(kMediaPayloadType, media_packet2.PayloadType());
1270 EXPECT_EQ(kSeqNum + 1, media_packet2.SequenceNumber());
1271 EXPECT_EQ(kMediaSsrc, media_packet2.Ssrc());
1272 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[2];
1273 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1274 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1275 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1276}
1277
minyue3a407ee2017-04-03 01:10:33 -07001278TEST_P(RtpSenderTestWithoutPacer, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -08001279 constexpr int kMediaPayloadType = 127;
1280 constexpr int kFlexfecPayloadType = 118;
1281 constexpr uint32_t kMediaSsrc = 1234;
1282 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001283 const char kNoMid[] = "";
brandtrdbdb3f12016-11-10 05:04:48 -08001284 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001285 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -08001286 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001287 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001288 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001289
1290 // Reset |rtp_sender_| to use FlexFEC.
Benjamin Wright192eeec2018-10-17 17:27:25 -07001291 rtp_sender_.reset(new RTPSender(
1292 false, &fake_clock_, &transport_, nullptr, &flexfec_sender,
1293 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1294 &mock_rtc_event_log_, &send_packet_observer_,
Johannes Kron9190b822018-10-29 11:22:05 +01001295 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
brandtrdbdb3f12016-11-10 05:04:48 -08001296 rtp_sender_->SetSSRC(kMediaSsrc);
1297 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001298
1299 // Parameters selected to generate a single FEC packet per media packet.
1300 FecProtectionParams params;
1301 params.fec_rate = 15;
1302 params.max_fec_frames = 1;
1303 params.fec_mask_type = kFecMaskRandom;
1304 rtp_sender_->SetFecParameters(params, params);
1305
Elad Alon4a87e1c2017-10-03 16:11:34 +02001306 EXPECT_CALL(mock_rtc_event_log_,
1307 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1308 .Times(2);
brandtrdbdb3f12016-11-10 05:04:48 -08001309 SendGenericPayload();
1310 ASSERT_EQ(2, transport_.packets_sent());
1311 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1312 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1313 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1314 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1315 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1316 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1317}
1318
Steve Anton296a0ce2018-03-22 15:17:27 -07001319// Test that the MID header extension is included on sent packets when
1320// configured.
1321TEST_P(RtpSenderTestWithoutPacer, MidIncludedOnSentPackets) {
1322 const char kMid[] = "mid";
1323
1324 // Register MID header extension and set the MID for the RTPSender.
1325 rtp_sender_->SetSendingMediaStatus(false);
1326 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionMid, kMidExtensionId);
1327 rtp_sender_->SetMid(kMid);
1328 rtp_sender_->SetSendingMediaStatus(true);
1329
1330 // Send a couple packets.
1331 SendGenericPayload();
1332 SendGenericPayload();
1333
1334 // Expect both packets to have the MID set.
1335 ASSERT_EQ(2u, transport_.sent_packets_.size());
1336 for (const RtpPacketReceived& packet : transport_.sent_packets_) {
1337 std::string mid;
1338 ASSERT_TRUE(packet.GetExtension<RtpMid>(&mid));
1339 EXPECT_EQ(kMid, mid);
1340 }
1341}
1342
minyue3a407ee2017-04-03 01:10:33 -07001343TEST_P(RtpSenderTest, FecOverheadRate) {
brandtr81eab612017-01-24 04:06:09 -08001344 constexpr int kFlexfecPayloadType = 118;
1345 constexpr uint32_t kMediaSsrc = 1234;
1346 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001347 const char kNoMid[] = "";
brandtr81eab612017-01-24 04:06:09 -08001348 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001349 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtr81eab612017-01-24 04:06:09 -08001350 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001351 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001352 nullptr /* rtp_state */, &fake_clock_);
brandtr81eab612017-01-24 04:06:09 -08001353
1354 // Reset |rtp_sender_| to use FlexFEC.
1355 rtp_sender_.reset(new RTPSender(
1356 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1357 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1358 &mock_rtc_event_log_, &send_packet_observer_,
Johannes Kron9190b822018-10-29 11:22:05 +01001359 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
brandtr81eab612017-01-24 04:06:09 -08001360 rtp_sender_->SetSSRC(kMediaSsrc);
1361 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr81eab612017-01-24 04:06:09 -08001362
1363 // Parameters selected to generate a single FEC packet per media packet.
1364 FecProtectionParams params;
1365 params.fec_rate = 15;
1366 params.max_fec_frames = 1;
1367 params.fec_mask_type = kFecMaskRandom;
1368 rtp_sender_->SetFecParameters(params, params);
1369
1370 constexpr size_t kNumMediaPackets = 10;
1371 constexpr size_t kNumFecPackets = kNumMediaPackets;
1372 constexpr int64_t kTimeBetweenPacketsMs = 10;
1373 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, false))
1374 .Times(kNumMediaPackets + kNumFecPackets);
1375 for (size_t i = 0; i < kNumMediaPackets; ++i) {
1376 SendGenericPayload();
1377 fake_clock_.AdvanceTimeMilliseconds(kTimeBetweenPacketsMs);
1378 }
1379 constexpr size_t kRtpHeaderLength = 12;
1380 constexpr size_t kFlexfecHeaderLength = 20;
1381 constexpr size_t kGenericCodecHeaderLength = 1;
1382 constexpr size_t kPayloadLength = sizeof(kPayloadData);
1383 constexpr size_t kPacketLength = kRtpHeaderLength + kFlexfecHeaderLength +
1384 kGenericCodecHeaderLength + kPayloadLength;
1385 EXPECT_NEAR(kNumFecPackets * kPacketLength * 8 /
1386 (kNumFecPackets * kTimeBetweenPacketsMs / 1000.0f),
1387 rtp_sender_->FecOverheadRate(), 500);
1388}
1389
minyue3a407ee2017-04-03 01:10:33 -07001390TEST_P(RtpSenderTest, FrameCountCallbacks) {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001391 class TestCallback : public FrameCountObserver {
1392 public:
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001393 TestCallback() : FrameCountObserver(), num_calls_(0), ssrc_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001394 ~TestCallback() override = default;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001395
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001396 void FrameCountUpdated(const FrameCounts& frame_counts,
1397 uint32_t ssrc) override {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001398 ++num_calls_;
1399 ssrc_ = ssrc;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001400 frame_counts_ = frame_counts;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001401 }
1402
1403 uint32_t num_calls_;
1404 uint32_t ssrc_;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001405 FrameCounts frame_counts_;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001406 } callback;
1407
Erik Språng7b52f102018-02-07 14:37:37 +01001408 rtp_sender_.reset(new RTPSender(
1409 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr, nullptr,
1410 nullptr, nullptr, &callback, nullptr, nullptr, nullptr,
Johannes Kron9190b822018-10-29 11:22:05 +01001411 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
nisse7d59f6b2017-02-21 03:40:24 -08001412 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001413 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1414 const uint8_t payload_type = 127;
1415 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1416 0, 1500));
1417 uint8_t payload[] = {47, 11, 32, 93, 89};
1418 rtp_sender_->SetStorePacketsStatus(true, 1);
1419 uint32_t ssrc = rtp_sender_->SSRC();
1420
terelius5d332ac2016-01-14 14:37:39 -08001421 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, _))
1422 .Times(::testing::AtLeast(2));
1423
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001424 RTPVideoHeader video_header;
spranga8ae6f22017-09-04 07:23:56 -07001425 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1426 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001427 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001428
1429 EXPECT_EQ(1U, callback.num_calls_);
1430 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001431 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1432 EXPECT_EQ(0, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001433
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001434 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1435 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001436 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001437
1438 EXPECT_EQ(2U, callback.num_calls_);
1439 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001440 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1441 EXPECT_EQ(1, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001442
andresp@webrtc.org8f151212014-07-10 09:39:23 +00001443 rtp_sender_.reset();
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001444}
1445
minyue3a407ee2017-04-03 01:10:33 -07001446TEST_P(RtpSenderTest, BitrateCallbacks) {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001447 class TestCallback : public BitrateStatisticsObserver {
1448 public:
sprangcd349d92016-07-13 09:11:28 -07001449 TestCallback()
1450 : BitrateStatisticsObserver(),
1451 num_calls_(0),
1452 ssrc_(0),
1453 total_bitrate_(0),
1454 retransmit_bitrate_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001455 ~TestCallback() override = default;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001456
sprangcd349d92016-07-13 09:11:28 -07001457 void Notify(uint32_t total_bitrate,
1458 uint32_t retransmit_bitrate,
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001459 uint32_t ssrc) override {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001460 ++num_calls_;
1461 ssrc_ = ssrc;
sprangcd349d92016-07-13 09:11:28 -07001462 total_bitrate_ = total_bitrate;
1463 retransmit_bitrate_ = retransmit_bitrate;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001464 }
1465
1466 uint32_t num_calls_;
1467 uint32_t ssrc_;
sprangcd349d92016-07-13 09:11:28 -07001468 uint32_t total_bitrate_;
1469 uint32_t retransmit_bitrate_;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001470 } callback;
Benjamin Wright192eeec2018-10-17 17:27:25 -07001471 rtp_sender_.reset(new RTPSender(
1472 false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
1473 &callback, nullptr, nullptr, nullptr, nullptr,
Johannes Kron9190b822018-10-29 11:22:05 +01001474 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
nisse7d59f6b2017-02-21 03:40:24 -08001475 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001476
sprangcd349d92016-07-13 09:11:28 -07001477 // Simulate kNumPackets sent with kPacketInterval ms intervals, with the
1478 // number of packets selected so that we fill (but don't overflow) the one
1479 // second averaging window.
1480 const uint32_t kWindowSizeMs = 1000;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001481 const uint32_t kPacketInterval = 20;
sprangcd349d92016-07-13 09:11:28 -07001482 const uint32_t kNumPackets =
1483 (kWindowSizeMs - kPacketInterval) / kPacketInterval;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001484 // Overhead = 12 bytes RTP header + 1 byte generic header.
1485 const uint32_t kPacketOverhead = 13;
1486
1487 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1488 const uint8_t payload_type = 127;
danilchap162abd32015-12-10 02:39:40 -08001489 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1490 0, 1500));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001491 uint8_t payload[] = {47, 11, 32, 93, 89};
1492 rtp_sender_->SetStorePacketsStatus(true, 1);
1493 uint32_t ssrc = rtp_sender_->SSRC();
1494
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001495 // Initial process call so we get a new time window.
1496 rtp_sender_->ProcessBitrate();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001497
1498 // Send a few frames.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001499 RTPVideoHeader video_header;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001500 for (uint32_t i = 0; i < kNumPackets; ++i) {
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001501 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1502 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001503 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001504 fake_clock_.AdvanceTimeMilliseconds(kPacketInterval);
1505 }
1506
1507 rtp_sender_->ProcessBitrate();
1508
stefan@webrtc.org0bae1fa2014-11-05 14:05:29 +00001509 // We get one call for every stats updated, thus two calls since both the
1510 // stream stats and the retransmit stats are updated once.
1511 EXPECT_EQ(2u, callback.num_calls_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001512 EXPECT_EQ(ssrc, callback.ssrc_);
sprangcd349d92016-07-13 09:11:28 -07001513 const uint32_t kTotalPacketSize = kPacketOverhead + sizeof(payload);
1514 // Bitrate measured over delta between last and first timestamp, plus one.
1515 const uint32_t kExpectedWindowMs = kNumPackets * kPacketInterval + 1;
1516 const uint32_t kExpectedBitsAccumulated = kTotalPacketSize * kNumPackets * 8;
1517 const uint32_t kExpectedRateBps =
1518 (kExpectedBitsAccumulated * 1000 + (kExpectedWindowMs / 2)) /
1519 kExpectedWindowMs;
1520 EXPECT_EQ(kExpectedRateBps, callback.total_bitrate_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001521
andresp@webrtc.orgd11bec42014-07-08 14:32:58 +00001522 rtp_sender_.reset();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001523}
1524
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001525class RtpSenderAudioTest : public RtpSenderTest {
1526 protected:
1527 RtpSenderAudioTest() {}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001528
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001529 void SetUp() override {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001530 payload_ = kAudioPayload;
Benjamin Wright192eeec2018-10-17 17:27:25 -07001531 rtp_sender_.reset(new RTPSender(
1532 true, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
1533 nullptr, nullptr, nullptr, nullptr, nullptr,
Johannes Kron9190b822018-10-29 11:22:05 +01001534 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
nisse7d59f6b2017-02-21 03:40:24 -08001535 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001536 rtp_sender_->SetSequenceNumber(kSeqNum);
1537 }
1538};
1539
minyue3a407ee2017-04-03 01:10:33 -07001540TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacks) {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001541 class TestCallback : public StreamDataCountersCallback {
1542 public:
danilchap162abd32015-12-10 02:39:40 -08001543 TestCallback() : StreamDataCountersCallback(), ssrc_(0), counters_() {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001544 ~TestCallback() override = default;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001545
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001546 void DataCountersUpdated(const StreamDataCounters& counters,
1547 uint32_t ssrc) override {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001548 ssrc_ = ssrc;
1549 counters_ = counters;
1550 }
1551
1552 uint32_t ssrc_;
1553 StreamDataCounters counters_;
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001554
1555 void MatchPacketCounter(const RtpPacketCounter& expected,
1556 const RtpPacketCounter& actual) {
1557 EXPECT_EQ(expected.payload_bytes, actual.payload_bytes);
1558 EXPECT_EQ(expected.header_bytes, actual.header_bytes);
1559 EXPECT_EQ(expected.padding_bytes, actual.padding_bytes);
1560 EXPECT_EQ(expected.packets, actual.packets);
1561 }
1562
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001563 void Matches(uint32_t ssrc, const StreamDataCounters& counters) {
1564 EXPECT_EQ(ssrc, ssrc_);
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001565 MatchPacketCounter(counters.transmitted, counters_.transmitted);
1566 MatchPacketCounter(counters.retransmitted, counters_.retransmitted);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001567 EXPECT_EQ(counters.fec.packets, counters_.fec.packets);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001568 }
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001569 } callback;
1570
1571 const uint8_t kRedPayloadType = 96;
1572 const uint8_t kUlpfecPayloadType = 97;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001573 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1574 const uint8_t payload_type = 127;
1575 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1576 0, 1500));
1577 uint8_t payload[] = {47, 11, 32, 93, 89};
1578 rtp_sender_->SetStorePacketsStatus(true, 1);
1579 uint32_t ssrc = rtp_sender_->SSRC();
1580
1581 rtp_sender_->RegisterRtpStatisticsCallback(&callback);
1582
1583 // Send a frame.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001584 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001585 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001586 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001587 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001588 StreamDataCounters expected;
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001589 expected.transmitted.payload_bytes = 6;
1590 expected.transmitted.header_bytes = 12;
1591 expected.transmitted.padding_bytes = 0;
1592 expected.transmitted.packets = 1;
1593 expected.retransmitted.payload_bytes = 0;
1594 expected.retransmitted.header_bytes = 0;
1595 expected.retransmitted.padding_bytes = 0;
1596 expected.retransmitted.packets = 0;
1597 expected.fec.packets = 0;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001598 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001599
1600 // Retransmit a frame.
1601 uint16_t seqno = rtp_sender_->SequenceNumber() - 1;
Erik Språnga12b1d62018-03-14 12:39:24 +01001602 rtp_sender_->ReSendPacket(seqno);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001603 expected.transmitted.payload_bytes = 12;
1604 expected.transmitted.header_bytes = 24;
1605 expected.transmitted.packets = 2;
1606 expected.retransmitted.payload_bytes = 6;
1607 expected.retransmitted.header_bytes = 12;
1608 expected.retransmitted.padding_bytes = 0;
1609 expected.retransmitted.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001610 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001611
1612 // Send padding.
philipel8aadd502017-02-23 02:56:13 -08001613 rtp_sender_->TimeToSendPadding(kMaxPaddingSize, PacedPacketInfo());
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001614 expected.transmitted.payload_bytes = 12;
1615 expected.transmitted.header_bytes = 36;
1616 expected.transmitted.padding_bytes = kMaxPaddingSize;
1617 expected.transmitted.packets = 3;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001618 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001619
brandtrf1bb4762016-11-07 03:05:06 -08001620 // Send ULPFEC.
1621 rtp_sender_->SetUlpfecConfig(kRedPayloadType, kUlpfecPayloadType);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001622 FecProtectionParams fec_params;
1623 fec_params.fec_mask_type = kFecMaskRandom;
1624 fec_params.fec_rate = 1;
1625 fec_params.max_fec_frames = 1;
brandtr1743a192016-11-07 03:36:05 -08001626 rtp_sender_->SetFecParameters(fec_params, fec_params);
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001627 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001628 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001629 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001630 expected.transmitted.payload_bytes = 40;
1631 expected.transmitted.header_bytes = 60;
1632 expected.transmitted.packets = 5;
1633 expected.fec.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001634 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001635
sprang867fb522015-08-03 04:38:41 -07001636 rtp_sender_->RegisterRtpStatisticsCallback(nullptr);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001637}
1638
minyue3a407ee2017-04-03 01:10:33 -07001639TEST_P(RtpSenderAudioTest, SendAudio) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001640 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1641 const uint8_t payload_type = 127;
1642 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1643 0, 1500));
1644 uint8_t payload[] = {47, 11, 32, 93, 89};
1645
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001646 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001647 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001648 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001649 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001650
danilchap96c15872016-11-21 01:35:29 -08001651 auto sent_payload = transport_.last_sent_packet().payload();
1652 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001653}
1654
minyue3a407ee2017-04-03 01:10:33 -07001655TEST_P(RtpSenderAudioTest, SendAudioWithAudioLevelExtension) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001656 EXPECT_EQ(0, rtp_sender_->SetAudioLevel(kAudioLevel));
danilchap162abd32015-12-10 02:39:40 -08001657 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
1658 kAudioLevelExtensionId));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001659
1660 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1661 const uint8_t payload_type = 127;
1662 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1663 0, 1500));
1664 uint8_t payload[] = {47, 11, 32, 93, 89};
1665
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001666 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001667 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001668 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001669 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001670
danilchap96c15872016-11-21 01:35:29 -08001671 auto sent_payload = transport_.last_sent_packet().payload();
1672 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
danilchap12ba1862016-10-26 02:41:55 -07001673 // Verify AudioLevel extension.
1674 bool voice_activity;
1675 uint8_t audio_level;
1676 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<AudioLevel>(
1677 &voice_activity, &audio_level));
1678 EXPECT_EQ(kAudioLevel, audio_level);
1679 EXPECT_FALSE(voice_activity);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001680}
1681
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001682// As RFC4733, named telephone events are carried as part of the audio stream
1683// and must use the same sequence number and timestamp base as the regular
1684// audio channel.
1685// This test checks the marker bit for the first packet and the consequent
1686// packets of the same telephone event. Since it is specifically for DTMF
pbos22993e12015-10-19 02:39:06 -07001687// events, ignoring audio packets and sending kEmptyFrame instead of those.
minyue3a407ee2017-04-03 01:10:33 -07001688TEST_P(RtpSenderAudioTest, CheckMarkerBitForTelephoneEvents) {
solenbergffbbcac2016-11-17 05:25:37 -08001689 const char* kDtmfPayloadName = "telephone-event";
1690 const uint32_t kPayloadFrequency = 8000;
1691 const uint8_t kPayloadType = 126;
1692 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kDtmfPayloadName, kPayloadType,
1693 kPayloadFrequency, 0, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001694 // For Telephone events, payload is not added to the registered payload list,
1695 // it will register only the payload used for audio stream.
1696 // Registering the payload again for audio stream with different payload name.
solenbergffbbcac2016-11-17 05:25:37 -08001697 const char* kPayloadName = "payload_name";
1698 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType,
1699 kPayloadFrequency, 1, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001700 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
1701 // DTMF event key=9, duration=500 and attenuationdB=10
1702 rtp_sender_->SendTelephoneEvent(9, 500, 10);
1703 // During start, it takes the starting timestamp as last sent timestamp.
1704 // The duration is calculated as the difference of current and last sent
1705 // timestamp. So for first call it will skip since the duration is zero.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001706 RTPVideoHeader video_header;
spranga8ae6f22017-09-04 07:23:56 -07001707 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1708 kEmptyFrame, kPayloadType, capture_time_ms, 0, nullptr, 0, nullptr,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001709 &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001710 // DTMF Sample Length is (Frequency/1000) * Duration.
1711 // So in this case, it is (8000/1000) * 500 = 4000.
1712 // Sending it as two packets.
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001713 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001714 kEmptyFrame, kPayloadType, capture_time_ms + 2000, 0, nullptr, 0, nullptr,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001715 &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
danilchap12ba1862016-10-26 02:41:55 -07001716
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001717 // Marker Bit should be set to 1 for first packet.
danilchap12ba1862016-10-26 02:41:55 -07001718 EXPECT_TRUE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001719
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001720 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001721 kEmptyFrame, kPayloadType, capture_time_ms + 4000, 0, nullptr, 0, nullptr,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001722 &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001723 // Marker Bit should be set to 0 for rest of the packets.
danilchap12ba1862016-10-26 02:41:55 -07001724 EXPECT_FALSE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001725}
1726
minyue3a407ee2017-04-03 01:10:33 -07001727TEST_P(RtpSenderTestWithoutPacer, BytesReportedCorrectly) {
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001728 const char* kPayloadName = "GENERIC";
1729 const uint8_t kPayloadType = 127;
1730 rtp_sender_->SetSSRC(1234);
1731 rtp_sender_->SetRtxSsrc(4321);
Shao Changbine62202f2015-04-21 20:24:50 +08001732 rtp_sender_->SetRtxPayloadType(kPayloadType - 1, kPayloadType);
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +00001733 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001734
danilchap162abd32015-12-10 02:39:40 -08001735 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType, 90000,
1736 0, 1500));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001737 uint8_t payload[] = {47, 11, 32, 93, 89};
1738
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001739 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001740 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001741 kVideoFrameKey, kPayloadType, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001742 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001743
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001744 // Will send 2 full-size padding packets.
philipel8aadd502017-02-23 02:56:13 -08001745 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
1746 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001747
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001748 StreamDataCounters rtp_stats;
1749 StreamDataCounters rtx_stats;
1750 rtp_sender_->GetDataCounters(&rtp_stats, &rtx_stats);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001751
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001752 // Payload + 1-byte generic header.
asapersson@webrtc.orgd08d3892014-12-16 12:03:11 +00001753 EXPECT_GT(rtp_stats.first_packet_time_ms, -1);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001754 EXPECT_EQ(rtp_stats.transmitted.payload_bytes, sizeof(payload) + 1);
1755 EXPECT_EQ(rtp_stats.transmitted.header_bytes, 12u);
1756 EXPECT_EQ(rtp_stats.transmitted.padding_bytes, 0u);
1757 EXPECT_EQ(rtx_stats.transmitted.payload_bytes, 0u);
1758 EXPECT_EQ(rtx_stats.transmitted.header_bytes, 24u);
1759 EXPECT_EQ(rtx_stats.transmitted.padding_bytes, 2 * kMaxPaddingSize);
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001760
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001761 EXPECT_EQ(rtp_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001762 rtp_stats.transmitted.payload_bytes +
1763 rtp_stats.transmitted.header_bytes +
1764 rtp_stats.transmitted.padding_bytes);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001765 EXPECT_EQ(rtx_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001766 rtx_stats.transmitted.payload_bytes +
1767 rtx_stats.transmitted.header_bytes +
1768 rtx_stats.transmitted.padding_bytes);
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001769
danilchap162abd32015-12-10 02:39:40 -08001770 EXPECT_EQ(
1771 transport_.total_bytes_sent_,
1772 rtp_stats.transmitted.TotalBytes() + rtx_stats.transmitted.TotalBytes());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001773}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001774
minyue3a407ee2017-04-03 01:10:33 -07001775TEST_P(RtpSenderTestWithoutPacer, RespectsNackBitrateLimit) {
sprang38778b02015-09-29 09:48:22 -07001776 const int32_t kPacketSize = 1400;
1777 const int32_t kNumPackets = 30;
1778
sprangcd349d92016-07-13 09:11:28 -07001779 retransmission_rate_limiter_.SetMaxRate(kPacketSize * kNumPackets * 8);
1780
sprang38778b02015-09-29 09:48:22 -07001781 rtp_sender_->SetStorePacketsStatus(true, kNumPackets);
sprang38778b02015-09-29 09:48:22 -07001782 const uint16_t kStartSequenceNumber = rtp_sender_->SequenceNumber();
Danil Chapovalov2800d742016-08-26 18:48:46 +02001783 std::vector<uint16_t> sequence_numbers;
sprang38778b02015-09-29 09:48:22 -07001784 for (int32_t i = 0; i < kNumPackets; ++i) {
1785 sequence_numbers.push_back(kStartSequenceNumber + i);
1786 fake_clock_.AdvanceTimeMilliseconds(1);
1787 SendPacket(fake_clock_.TimeInMilliseconds(), kPacketSize);
1788 }
danilchap12ba1862016-10-26 02:41:55 -07001789 EXPECT_EQ(kNumPackets, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001790
1791 fake_clock_.AdvanceTimeMilliseconds(1000 - kNumPackets);
1792
1793 // Resending should work - brings the bandwidth up to the limit.
1794 // NACK bitrate is capped to the same bitrate as the encoder, since the max
1795 // protection overhead is 50% (see MediaOptimization::SetTargetRates).
Danil Chapovalov2800d742016-08-26 18:48:46 +02001796 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001797 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001798
sprangcd349d92016-07-13 09:11:28 -07001799 // Must be at least 5ms in between retransmission attempts.
1800 fake_clock_.AdvanceTimeMilliseconds(5);
1801
sprang38778b02015-09-29 09:48:22 -07001802 // Resending should not work, bandwidth exceeded.
Danil Chapovalov2800d742016-08-26 18:48:46 +02001803 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001804 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001805}
1806
minyue3a407ee2017-04-03 01:10:33 -07001807TEST_P(RtpSenderVideoTest, KeyFrameHasCVO) {
danilchapb6f1fb52016-10-19 06:11:39 -07001808 uint8_t kFrame[kMaxPacketLength];
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001809 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1810 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001811
philipel1a4746a2018-07-09 15:52:29 +02001812 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001813 hdr.rotation = kVideoRotation_0;
Niels Möller520ca4e2018-06-04 11:14:38 +02001814 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameKey, kPayload,
danilchapb6f1fb52016-10-19 06:11:39 -07001815 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
spranga8ae6f22017-09-04 07:23:56 -07001816 &hdr, kDefaultExpectedRetransmissionTimeMs);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001817
danilchapc1600c52016-10-26 03:33:11 -07001818 VideoRotation rotation;
1819 EXPECT_TRUE(
1820 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1821 EXPECT_EQ(kVideoRotation_0, rotation);
1822}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001823
ilnik04f4d122017-06-19 07:18:55 -07001824TEST_P(RtpSenderVideoTest, TimingFrameHasPacketizationTimstampSet) {
1825 uint8_t kFrame[kMaxPacketLength];
1826 const int64_t kPacketizationTimeMs = 100;
1827 const int64_t kEncodeStartDeltaMs = 10;
1828 const int64_t kEncodeFinishDeltaMs = 50;
1829 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1830 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1831
1832 const int64_t kCaptureTimestamp = fake_clock_.TimeInMilliseconds();
1833
philipel1a4746a2018-07-09 15:52:29 +02001834 RTPVideoHeader hdr;
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001835 hdr.video_timing.flags = VideoSendTiming::kTriggeredByTimer;
ilnik04f4d122017-06-19 07:18:55 -07001836 hdr.video_timing.encode_start_delta_ms = kEncodeStartDeltaMs;
1837 hdr.video_timing.encode_finish_delta_ms = kEncodeFinishDeltaMs;
1838
1839 fake_clock_.AdvanceTimeMilliseconds(kPacketizationTimeMs);
Niels Möller520ca4e2018-06-04 11:14:38 +02001840 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameKey, kPayload,
ilnik04f4d122017-06-19 07:18:55 -07001841 kTimestamp, kCaptureTimestamp, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001842 sizeof(kFrame), nullptr, &hdr,
1843 kDefaultExpectedRetransmissionTimeMs);
ilnik2edc6842017-07-06 03:06:50 -07001844 VideoSendTiming timing;
ilnik04f4d122017-06-19 07:18:55 -07001845 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
1846 &timing));
1847 EXPECT_EQ(kPacketizationTimeMs, timing.packetization_finish_delta_ms);
1848 EXPECT_EQ(kEncodeStartDeltaMs, timing.encode_start_delta_ms);
1849 EXPECT_EQ(kEncodeFinishDeltaMs, timing.encode_finish_delta_ms);
1850}
1851
minyue3a407ee2017-04-03 01:10:33 -07001852TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenChanged) {
danilchapc1600c52016-10-26 03:33:11 -07001853 uint8_t kFrame[kMaxPacketLength];
1854 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1855 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1856
philipel1a4746a2018-07-09 15:52:29 +02001857 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001858 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001859 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001860 kVideoCodecGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001861 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001862
1863 hdr.rotation = kVideoRotation_0;
spranga8ae6f22017-09-04 07:23:56 -07001864 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001865 kVideoCodecGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001866 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001867
1868 VideoRotation rotation;
1869 EXPECT_TRUE(
1870 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1871 EXPECT_EQ(kVideoRotation_0, rotation);
1872}
1873
minyue3a407ee2017-04-03 01:10:33 -07001874TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenNonZero) {
danilchapc1600c52016-10-26 03:33:11 -07001875 uint8_t kFrame[kMaxPacketLength];
1876 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1877 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1878
philipel1a4746a2018-07-09 15:52:29 +02001879 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001880 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001881 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001882 kVideoCodecGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001883 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001884
spranga8ae6f22017-09-04 07:23:56 -07001885 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001886 kVideoCodecGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001887 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001888
1889 VideoRotation rotation;
1890 EXPECT_TRUE(
1891 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1892 EXPECT_EQ(kVideoRotation_90, rotation);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001893}
magjed71eb61c2016-09-08 03:24:58 -07001894
1895// Make sure rotation is parsed correctly when the Camera (C) and Flip (F) bits
1896// are set in the CVO byte.
minyue3a407ee2017-04-03 01:10:33 -07001897TEST_P(RtpSenderVideoTest, SendVideoWithCameraAndFlipCVO) {
magjed71eb61c2016-09-08 03:24:58 -07001898 // Test extracting rotation when Camera (C) and Flip (F) bits are zero.
1899 EXPECT_EQ(kVideoRotation_0, ConvertCVOByteToVideoRotation(0));
1900 EXPECT_EQ(kVideoRotation_90, ConvertCVOByteToVideoRotation(1));
1901 EXPECT_EQ(kVideoRotation_180, ConvertCVOByteToVideoRotation(2));
1902 EXPECT_EQ(kVideoRotation_270, ConvertCVOByteToVideoRotation(3));
1903 // Test extracting rotation when Camera (C) and Flip (F) bits are set.
1904 const int flip_bit = 1 << 2;
1905 const int camera_bit = 1 << 3;
1906 EXPECT_EQ(kVideoRotation_0,
1907 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 0));
1908 EXPECT_EQ(kVideoRotation_90,
1909 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 1));
1910 EXPECT_EQ(kVideoRotation_180,
1911 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 2));
1912 EXPECT_EQ(kVideoRotation_270,
1913 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 3));
1914}
1915
spranga8ae6f22017-09-04 07:23:56 -07001916TEST_P(RtpSenderVideoTest, RetransmissionTypesGeneric) {
1917 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001918 header.codec = kVideoCodecGeneric;
spranga8ae6f22017-09-04 07:23:56 -07001919
1920 EXPECT_EQ(kDontRetransmit,
1921 rtp_sender_video_->GetStorageType(
1922 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1923 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1924 header, kRetransmitBaseLayer,
1925 kDefaultExpectedRetransmissionTimeMs));
1926 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1927 header, kRetransmitHigherLayers,
1928 kDefaultExpectedRetransmissionTimeMs));
1929 EXPECT_EQ(kAllowRetransmission,
1930 rtp_sender_video_->GetStorageType(
1931 header, kConditionallyRetransmitHigherLayers,
1932 kDefaultExpectedRetransmissionTimeMs));
1933 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1934 header, kRetransmitAllPackets,
1935 kDefaultExpectedRetransmissionTimeMs));
1936}
1937
1938TEST_P(RtpSenderVideoTest, RetransmissionTypesH264) {
1939 RTPVideoHeader header;
philipel7d745e52018-08-02 14:03:53 +02001940 header.video_type_header.emplace<RTPVideoHeaderH264>().packetization_mode =
1941 H264PacketizationMode::NonInterleaved;
Niels Möller520ca4e2018-06-04 11:14:38 +02001942 header.codec = kVideoCodecH264;
spranga8ae6f22017-09-04 07:23:56 -07001943
1944 EXPECT_EQ(kDontRetransmit,
1945 rtp_sender_video_->GetStorageType(
1946 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1947 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1948 header, kRetransmitBaseLayer,
1949 kDefaultExpectedRetransmissionTimeMs));
1950 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1951 header, kRetransmitHigherLayers,
1952 kDefaultExpectedRetransmissionTimeMs));
1953 EXPECT_EQ(kAllowRetransmission,
1954 rtp_sender_video_->GetStorageType(
1955 header, kConditionallyRetransmitHigherLayers,
1956 kDefaultExpectedRetransmissionTimeMs));
1957 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1958 header, kRetransmitAllPackets,
1959 kDefaultExpectedRetransmissionTimeMs));
1960}
1961
1962TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8BaseLayer) {
1963 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001964 header.codec = kVideoCodecVP8;
Philip Eliassond52a1a62018-09-07 13:03:55 +00001965 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
1966 vp8_header.temporalIdx = 0;
spranga8ae6f22017-09-04 07:23:56 -07001967
1968 EXPECT_EQ(kDontRetransmit,
1969 rtp_sender_video_->GetStorageType(
1970 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1971 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1972 header, kRetransmitBaseLayer,
1973 kDefaultExpectedRetransmissionTimeMs));
1974 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1975 header, kRetransmitHigherLayers,
1976 kDefaultExpectedRetransmissionTimeMs));
1977 EXPECT_EQ(kAllowRetransmission,
1978 rtp_sender_video_->GetStorageType(
1979 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1980 kDefaultExpectedRetransmissionTimeMs));
1981 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1982 header, kConditionallyRetransmitHigherLayers,
1983 kDefaultExpectedRetransmissionTimeMs));
1984 EXPECT_EQ(
1985 kAllowRetransmission,
1986 rtp_sender_video_->GetStorageType(
1987 header, kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers,
1988 kDefaultExpectedRetransmissionTimeMs));
1989 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1990 header, kRetransmitAllPackets,
1991 kDefaultExpectedRetransmissionTimeMs));
1992}
1993
1994TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8HigherLayers) {
1995 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001996 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07001997
Philip Eliassond52a1a62018-09-07 13:03:55 +00001998 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
spranga8ae6f22017-09-04 07:23:56 -07001999 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
Philip Eliassond52a1a62018-09-07 13:03:55 +00002000 vp8_header.temporalIdx = tid;
spranga8ae6f22017-09-04 07:23:56 -07002001
2002 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
2003 header, kRetransmitOff,
2004 kDefaultExpectedRetransmissionTimeMs));
2005 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
2006 header, kRetransmitBaseLayer,
2007 kDefaultExpectedRetransmissionTimeMs));
2008 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2009 header, kRetransmitHigherLayers,
2010 kDefaultExpectedRetransmissionTimeMs));
2011 EXPECT_EQ(kAllowRetransmission,
2012 rtp_sender_video_->GetStorageType(
2013 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
2014 kDefaultExpectedRetransmissionTimeMs));
2015 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2016 header, kRetransmitAllPackets,
2017 kDefaultExpectedRetransmissionTimeMs));
2018 }
2019}
2020
2021TEST_P(RtpSenderVideoTest, RetransmissionTypesVP9) {
2022 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02002023 header.codec = kVideoCodecVP9;
spranga8ae6f22017-09-04 07:23:56 -07002024
philipel29d88462018-08-08 14:26:00 +02002025 auto& vp9_header = header.video_type_header.emplace<RTPVideoHeaderVP9>();
spranga8ae6f22017-09-04 07:23:56 -07002026 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
philipel29d88462018-08-08 14:26:00 +02002027 vp9_header.temporal_idx = tid;
spranga8ae6f22017-09-04 07:23:56 -07002028
2029 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
2030 header, kRetransmitOff,
2031 kDefaultExpectedRetransmissionTimeMs));
2032 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
2033 header, kRetransmitBaseLayer,
2034 kDefaultExpectedRetransmissionTimeMs));
2035 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2036 header, kRetransmitHigherLayers,
2037 kDefaultExpectedRetransmissionTimeMs));
2038 EXPECT_EQ(kAllowRetransmission,
2039 rtp_sender_video_->GetStorageType(
2040 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
2041 kDefaultExpectedRetransmissionTimeMs));
2042 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2043 header, kRetransmitAllPackets,
2044 kDefaultExpectedRetransmissionTimeMs));
2045 }
2046}
2047
2048TEST_P(RtpSenderVideoTest, ConditionalRetransmit) {
2049 const int64_t kFrameIntervalMs = 33;
2050 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
2051 const uint8_t kSettings =
2052 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
2053
2054 // Insert VP8 frames for all temporal layers, but stop before the final index.
2055 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02002056 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07002057
2058 // Fill averaging window to prevent rounding errors.
2059 constexpr int kNumRepetitions =
2060 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
2061 kFrameIntervalMs;
2062 constexpr int kPattern[] = {0, 2, 1, 2};
Philip Eliassond52a1a62018-09-07 13:03:55 +00002063 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
spranga8ae6f22017-09-04 07:23:56 -07002064 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
Philip Eliassond52a1a62018-09-07 13:03:55 +00002065 vp8_header.temporalIdx = kPattern[i % arraysize(kPattern)];
spranga8ae6f22017-09-04 07:23:56 -07002066 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
2067 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2068 }
2069
2070 // Since we're at the start of the pattern, the next expected frame in TL0 is
2071 // right now. We will wait at most one expected retransmission time before
2072 // acknowledging that it did not arrive, which means this frame and the next
2073 // will not be retransmitted.
Philip Eliassond52a1a62018-09-07 13:03:55 +00002074 vp8_header.temporalIdx = 1;
spranga8ae6f22017-09-04 07:23:56 -07002075 EXPECT_EQ(StorageType::kDontRetransmit,
2076 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2077 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2078 EXPECT_EQ(StorageType::kDontRetransmit,
2079 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2080 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2081
2082 // The TL0 frame did not arrive. So allow retransmission.
2083 EXPECT_EQ(StorageType::kAllowRetransmission,
2084 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2085 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2086
2087 // Insert a frame for TL2. We just had frame in TL1, so the next one there is
2088 // in three frames away. TL0 is still too far in the past. So, allow
2089 // retransmission.
Philip Eliassond52a1a62018-09-07 13:03:55 +00002090 vp8_header.temporalIdx = 2;
spranga8ae6f22017-09-04 07:23:56 -07002091 EXPECT_EQ(StorageType::kAllowRetransmission,
2092 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2093 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2094
2095 // Another TL2, next in TL1 is two frames away. Allow again.
2096 EXPECT_EQ(StorageType::kAllowRetransmission,
2097 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2098 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2099
2100 // Yet another TL2, next in TL1 is now only one frame away, so don't store
2101 // for retransmission.
2102 EXPECT_EQ(StorageType::kDontRetransmit,
2103 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2104}
2105
2106TEST_P(RtpSenderVideoTest, ConditionalRetransmitLimit) {
2107 const int64_t kFrameIntervalMs = 200;
2108 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
2109 const int32_t kSettings =
2110 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
2111
2112 // Insert VP8 frames for all temporal layers, but stop before the final index.
2113 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02002114 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07002115
2116 // Fill averaging window to prevent rounding errors.
2117 constexpr int kNumRepetitions =
2118 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
2119 kFrameIntervalMs;
2120 constexpr int kPattern[] = {0, 2, 2, 2};
Philip Eliassond52a1a62018-09-07 13:03:55 +00002121 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
spranga8ae6f22017-09-04 07:23:56 -07002122 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
Philip Eliassond52a1a62018-09-07 13:03:55 +00002123 vp8_header.temporalIdx = kPattern[i % arraysize(kPattern)];
spranga8ae6f22017-09-04 07:23:56 -07002124
2125 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
2126 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2127 }
2128
2129 // Since we're at the start of the pattern, the next expected frame will be
2130 // right now in TL0. Put it in TL1 instead. Regular rules would dictate that
2131 // we don't store for retransmission because we expect a frame in a lower
2132 // layer, but that last frame in TL1 was a long time ago in absolute terms,
2133 // so allow retransmission anyway.
Philip Eliassond52a1a62018-09-07 13:03:55 +00002134 vp8_header.temporalIdx = 1;
spranga8ae6f22017-09-04 07:23:56 -07002135 EXPECT_EQ(StorageType::kAllowRetransmission,
2136 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2137}
2138
philipelb3e42a42018-09-13 10:57:14 +02002139TEST_P(RtpSenderVideoTest, PopulateGenericFrameDescriptor) {
2140 const int64_t kFrameId = 100000;
2141 uint8_t kFrame[100];
2142 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2143 kRtpExtensionGenericFrameDescriptor, kGenericDescriptorId));
2144
2145 RTPVideoHeader hdr;
2146 RTPVideoHeader::GenericDescriptorInfo& generic = hdr.generic.emplace();
2147 generic.frame_id = kFrameId;
2148 generic.temporal_index = 3;
2149 generic.spatial_index = 2;
2150 generic.higher_spatial_layers.push_back(4);
2151 generic.dependencies.push_back(kFrameId - 1);
2152 generic.dependencies.push_back(kFrameId - 500);
2153 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameDelta, kPayload,
2154 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
2155 &hdr, kDefaultExpectedRetransmissionTimeMs);
2156
2157 RtpGenericFrameDescriptor descriptor_wire;
2158 EXPECT_EQ(1U, transport_.sent_packets_.size());
2159 EXPECT_TRUE(
2160 transport_.last_sent_packet()
2161 .GetExtension<RtpGenericFrameDescriptorExtension>(&descriptor_wire));
2162 EXPECT_EQ(static_cast<uint16_t>(generic.frame_id), descriptor_wire.FrameId());
2163 EXPECT_EQ(generic.temporal_index, descriptor_wire.TemporalLayer());
2164 EXPECT_THAT(descriptor_wire.FrameDependenciesDiffs(), ElementsAre(1, 500));
2165 uint8_t spatial_bitmask = 0x14;
2166 EXPECT_EQ(spatial_bitmask, descriptor_wire.SpatialLayersBitmask());
2167}
2168
Danil Chapovalov84ffb352018-09-25 18:59:09 +02002169TEST_P(RtpSenderVideoTest,
2170 UsesMinimalVp8DescriptorWhenGenericFrameDescriptorExtensionIsUsed) {
2171 const int64_t kFrameId = 100000;
2172 const size_t kFrameSize = 100;
2173 uint8_t kFrame[kFrameSize];
2174 ASSERT_TRUE(rtp_sender_->RegisterRtpHeaderExtension(
2175 RtpGenericFrameDescriptorExtension::kUri, kGenericDescriptorId));
2176
2177 RTPVideoHeader hdr;
2178 hdr.codec = kVideoCodecVP8;
2179 RTPVideoHeaderVP8& vp8 = hdr.video_type_header.emplace<RTPVideoHeaderVP8>();
2180 vp8.pictureId = kFrameId % 0X7FFF;
2181 vp8.tl0PicIdx = 13;
2182 vp8.temporalIdx = 1;
2183 vp8.keyIdx = 2;
2184 RTPVideoHeader::GenericDescriptorInfo& generic = hdr.generic.emplace();
2185 generic.frame_id = kFrameId;
2186 rtp_sender_video_->SendVideo(kVideoCodecVP8, kVideoFrameDelta, kPayload,
2187 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
2188 &hdr, kDefaultExpectedRetransmissionTimeMs);
2189
2190 ASSERT_THAT(transport_.sent_packets_, SizeIs(1));
2191 // Expect only minimal 1-byte vp8 descriptor was generated.
2192 EXPECT_THAT(transport_.sent_packets_[0].payload_size(), 1 + kFrameSize);
2193}
2194
minyue3a407ee2017-04-03 01:10:33 -07002195TEST_P(RtpSenderTest, OnOverheadChanged) {
michaelt4da30442016-11-17 01:38:43 -08002196 MockOverheadObserver mock_overhead_observer;
Benjamin Wright192eeec2018-10-17 17:27:25 -07002197 rtp_sender_.reset(
2198 new RTPSender(false, &fake_clock_, &transport_, nullptr, nullptr, nullptr,
2199 nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
2200 &retransmission_rate_limiter_, &mock_overhead_observer,
Johannes Kron9190b822018-10-29 11:22:05 +01002201 false, nullptr, false, false));
nisse7d59f6b2017-02-21 03:40:24 -08002202 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08002203
michaelt4da30442016-11-17 01:38:43 -08002204 // RTP overhead is 12B.
nisse284542b2017-01-10 08:58:32 -08002205 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(12)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002206 SendGenericPayload();
2207
2208 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
2209 kTransmissionTimeOffsetExtensionId);
2210
2211 // TransmissionTimeOffset extension has a size of 8B.
nisse284542b2017-01-10 08:58:32 -08002212 // 12B + 8B = 20B
2213 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(20)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002214 SendGenericPayload();
2215}
2216
minyue3a407ee2017-04-03 01:10:33 -07002217TEST_P(RtpSenderTest, DoesNotUpdateOverheadOnEqualSize) {
michaelt4da30442016-11-17 01:38:43 -08002218 MockOverheadObserver mock_overhead_observer;
Benjamin Wright192eeec2018-10-17 17:27:25 -07002219 rtp_sender_.reset(
2220 new RTPSender(false, &fake_clock_, &transport_, nullptr, nullptr, nullptr,
2221 nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
2222 &retransmission_rate_limiter_, &mock_overhead_observer,
Johannes Kron9190b822018-10-29 11:22:05 +01002223 false, nullptr, false, false));
nisse7d59f6b2017-02-21 03:40:24 -08002224 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08002225
2226 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(_)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002227 SendGenericPayload();
2228 SendGenericPayload();
2229}
2230
sprang168794c2017-07-06 04:38:06 -07002231TEST_P(RtpSenderTest, SendsKeepAlive) {
2232 MockTransport transport;
Benjamin Wright192eeec2018-10-17 17:27:25 -07002233 rtp_sender_.reset(new RTPSender(
2234 false, &fake_clock_, &transport, nullptr, nullptr, nullptr, nullptr,
2235 nullptr, nullptr, nullptr, &mock_rtc_event_log_, nullptr,
Johannes Kron9190b822018-10-29 11:22:05 +01002236 &retransmission_rate_limiter_, nullptr, false, nullptr, false, false));
sprang168794c2017-07-06 04:38:06 -07002237 rtp_sender_->SetSequenceNumber(kSeqNum);
2238 rtp_sender_->SetTimestampOffset(0);
2239 rtp_sender_->SetSSRC(kSsrc);
2240
2241 const uint8_t kKeepalivePayloadType = 20;
2242 RTC_CHECK_NE(kKeepalivePayloadType, kPayload);
2243
2244 EXPECT_CALL(transport, SendRtp(_, _, _))
2245 .WillOnce(
2246 Invoke([&kKeepalivePayloadType](const uint8_t* packet, size_t len,
2247 const PacketOptions& options) {
2248 webrtc::RTPHeader rtp_header;
2249 RtpUtility::RtpHeaderParser parser(packet, len);
2250 EXPECT_TRUE(parser.Parse(&rtp_header, nullptr));
2251 EXPECT_FALSE(rtp_header.markerBit);
2252 EXPECT_EQ(0U, rtp_header.paddingLength);
2253 EXPECT_EQ(kKeepalivePayloadType, rtp_header.payloadType);
2254 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
2255 EXPECT_EQ(kSsrc, rtp_header.ssrc);
2256 EXPECT_EQ(0u, len - rtp_header.headerLength);
2257 return true;
2258 }));
2259
2260 rtp_sender_->SendKeepAlive(kKeepalivePayloadType);
2261 EXPECT_EQ(kSeqNum + 1, rtp_sender_->SequenceNumber());
2262}
2263
minyue3a407ee2017-04-03 01:10:33 -07002264INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2265 RtpSenderTest,
2266 ::testing::Bool());
2267INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2268 RtpSenderTestWithoutPacer,
2269 ::testing::Bool());
2270INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2271 RtpSenderVideoTest,
2272 ::testing::Bool());
2273INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2274 RtpSenderAudioTest,
2275 ::testing::Bool());
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00002276} // namespace webrtc