blob: ace34ff07a6b9db05239af967c92168e07aa04d9 [file] [log] [blame]
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00001/*
phoglund@webrtc.org78088c22012-02-07 14:56:45 +00002 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00003 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
kwiberg84be5112016-04-27 01:19:58 -070011#include <memory>
danilchapb8b6fbb2015-12-10 05:05:27 -080012#include <vector>
13
Karl Wiberg918f50c2018-07-05 11:40:33 +020014#include "absl/memory/memory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020015#include "api/video/video_timing.h"
Elad Alon4a87e1c2017-10-03 16:11:34 +020016#include "logging/rtc_event_log/events/rtc_event.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020017#include "logging/rtc_event_log/mock/mock_rtc_event_log.h"
18#include "modules/rtp_rtcp/include/rtp_cvo.h"
19#include "modules/rtp_rtcp/include/rtp_header_extension_map.h"
20#include "modules/rtp_rtcp/include/rtp_header_parser.h"
21#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
22#include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
23#include "modules/rtp_rtcp/source/rtp_format_video_generic.h"
philipelb3e42a42018-09-13 10:57:14 +020024#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor.h"
25#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor_extension.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020026#include "modules/rtp_rtcp/source/rtp_header_extensions.h"
27#include "modules/rtp_rtcp/source/rtp_packet_received.h"
28#include "modules/rtp_rtcp/source/rtp_packet_to_send.h"
29#include "modules/rtp_rtcp/source/rtp_sender.h"
30#include "modules/rtp_rtcp/source/rtp_sender_video.h"
31#include "modules/rtp_rtcp/source/rtp_utility.h"
32#include "rtc_base/arraysize.h"
33#include "rtc_base/buffer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020034#include "rtc_base/rate_limiter.h"
35#include "test/field_trial.h"
36#include "test/gmock.h"
37#include "test/gtest.h"
38#include "test/mock_transport.h"
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +000039
40namespace webrtc {
41
andrew@webrtc.org8a442592011-12-16 21:24:30 +000042namespace {
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +000043const int kTransmissionTimeOffsetExtensionId = 1;
44const int kAbsoluteSendTimeExtensionId = 14;
sprang@webrtc.org30933902015-03-17 14:33:12 +000045const int kTransportSequenceNumberExtensionId = 13;
ilnik04f4d122017-06-19 07:18:55 -070046const int kVideoTimingExtensionId = 12;
Steve Anton296a0ce2018-03-22 15:17:27 -070047const int kMidExtensionId = 11;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000048const int kPayload = 100;
Shao Changbine62202f2015-04-21 20:24:50 +080049const int kRtxPayload = 98;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000050const uint32_t kTimestamp = 10;
51const uint16_t kSeqNum = 33;
brandtr9dfff292016-11-14 05:14:50 -080052const uint32_t kSsrc = 725242;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000053const int kMaxPacketLength = 1500;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000054const uint8_t kAudioLevel = 0x5a;
sprang@webrtc.org30933902015-03-17 14:33:12 +000055const uint16_t kTransportSequenceNumber = 0xaabbu;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000056const uint8_t kAudioLevelExtensionId = 9;
57const int kAudioPayload = 103;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +000058const uint64_t kStartTime = 123456789;
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +000059const size_t kMaxPaddingSize = 224u;
guoweis@webrtc.org45362892015-03-04 22:55:15 +000060const int kVideoRotationExtensionId = 5;
Stefan Holmera246cfb2016-08-23 17:51:42 +020061const size_t kGenericHeaderLength = 1;
62const uint8_t kPayloadData[] = {47, 11, 32, 93, 89};
spranga8ae6f22017-09-04 07:23:56 -070063const int64_t kDefaultExpectedRetransmissionTimeMs = 125;
philipelb3e42a42018-09-13 10:57:14 +020064const int kGenericDescriptorId = 10;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000065
Danil Chapovalov5e57b172016-09-02 19:15:59 +020066using ::testing::_;
philipelb3e42a42018-09-13 10:57:14 +020067using ::testing::ElementsAre;
Danil Chapovalov5e57b172016-09-02 19:15:59 +020068using ::testing::ElementsAreArray;
sprang168794c2017-07-06 04:38:06 -070069using ::testing::Invoke;
Danil Chapovalov84ffb352018-09-25 18:59:09 +020070using ::testing::SizeIs;
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +000071
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000072uint64_t ConvertMsToAbsSendTime(int64_t time_ms) {
Stefan Holmer0a87ffc2015-10-21 13:41:48 +020073 return (((time_ms << 18) + 500) / 1000) & 0x00ffffff;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000074}
75
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +000076class LoopbackTransportTest : public webrtc::Transport {
77 public:
Petter Strandmark26bc6692018-05-29 08:43:35 +020078 LoopbackTransportTest() : total_bytes_sent_(0) {
danilchap12ba1862016-10-26 02:41:55 -070079 receivers_extensions_.Register(kRtpExtensionTransmissionTimeOffset,
80 kTransmissionTimeOffsetExtensionId);
81 receivers_extensions_.Register(kRtpExtensionAbsoluteSendTime,
82 kAbsoluteSendTimeExtensionId);
83 receivers_extensions_.Register(kRtpExtensionTransportSequenceNumber,
84 kTransportSequenceNumberExtensionId);
85 receivers_extensions_.Register(kRtpExtensionVideoRotation,
86 kVideoRotationExtensionId);
87 receivers_extensions_.Register(kRtpExtensionAudioLevel,
88 kAudioLevelExtensionId);
ilnik04f4d122017-06-19 07:18:55 -070089 receivers_extensions_.Register(kRtpExtensionVideoTiming,
90 kVideoTimingExtensionId);
Steve Anton296a0ce2018-03-22 15:17:27 -070091 receivers_extensions_.Register(kRtpExtensionMid, kMidExtensionId);
philipelb3e42a42018-09-13 10:57:14 +020092 receivers_extensions_.Register(kRtpExtensionGenericFrameDescriptor,
93 kGenericDescriptorId);
guoweis@webrtc.org45362892015-03-04 22:55:15 +000094 }
danilchap12ba1862016-10-26 02:41:55 -070095
stefan1d8a5062015-10-02 03:39:33 -070096 bool SendRtp(const uint8_t* data,
97 size_t len,
98 const PacketOptions& options) override {
Petter Strandmark26bc6692018-05-29 08:43:35 +020099 last_options_ = options;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000100 total_bytes_sent_ += len;
danilchap12ba1862016-10-26 02:41:55 -0700101 sent_packets_.push_back(RtpPacketReceived(&receivers_extensions_));
102 EXPECT_TRUE(sent_packets_.back().Parse(data, len));
pbos2d566682015-09-28 09:59:31 -0700103 return true;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000104 }
danilchap162abd32015-12-10 02:39:40 -0800105 bool SendRtcp(const uint8_t* data, size_t len) override { return false; }
danilchap12ba1862016-10-26 02:41:55 -0700106 const RtpPacketReceived& last_sent_packet() { return sent_packets_.back(); }
107 int packets_sent() { return sent_packets_.size(); }
108
pbos@webrtc.org72491b92014-07-10 16:24:54 +0000109 size_t total_bytes_sent_;
Petter Strandmark26bc6692018-05-29 08:43:35 +0200110 PacketOptions last_options_;
danilchap12ba1862016-10-26 02:41:55 -0700111 std::vector<RtpPacketReceived> sent_packets_;
112
113 private:
114 RtpHeaderExtensionMap receivers_extensions_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000115};
116
Elad Alon4a87e1c2017-10-03 16:11:34 +0200117MATCHER_P(SameRtcEventTypeAs, value, "") {
118 return value == arg->GetType();
119}
120
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000121} // namespace
122
sprangebbf8a82015-09-21 15:11:14 -0700123class MockRtpPacketSender : public RtpPacketSender {
124 public:
125 MockRtpPacketSender() {}
126 virtual ~MockRtpPacketSender() {}
127
Peter Boströme23e7372015-10-08 11:44:14 +0200128 MOCK_METHOD6(InsertPacket,
129 void(Priority priority,
sprangebbf8a82015-09-21 15:11:14 -0700130 uint32_t ssrc,
131 uint16_t sequence_number,
132 int64_t capture_time_ms,
133 size_t bytes,
134 bool retransmission));
135};
136
Stefan Holmerf5dca482016-01-27 12:58:51 +0100137class MockTransportSequenceNumberAllocator
138 : public TransportSequenceNumberAllocator {
139 public:
140 MOCK_METHOD0(AllocateSequenceNumber, uint16_t());
141};
142
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200143class MockSendSideDelayObserver : public SendSideDelayObserver {
144 public:
145 MOCK_METHOD3(SendSideDelayUpdated, void(int, int, uint32_t));
146};
147
asapersson35151f32016-05-02 23:44:01 -0700148class MockSendPacketObserver : public SendPacketObserver {
149 public:
150 MOCK_METHOD3(OnSendPacket, void(uint16_t, int64_t, uint32_t));
151};
152
Stefan Holmera246cfb2016-08-23 17:51:42 +0200153class MockTransportFeedbackObserver : public TransportFeedbackObserver {
154 public:
elad.alond12a8e12017-03-23 11:04:48 -0700155 MOCK_METHOD4(AddPacket,
156 void(uint32_t, uint16_t, size_t, const PacedPacketInfo&));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200157 MOCK_METHOD1(OnTransportFeedback, void(const rtcp::TransportFeedback&));
elad.alonf9490002017-03-06 05:32:21 -0800158 MOCK_CONST_METHOD0(GetTransportFeedbackVector, std::vector<PacketFeedback>());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200159};
160
minyue3a407ee2017-04-03 01:10:33 -0700161class MockOverheadObserver : public OverheadObserver {
162 public:
163 MOCK_METHOD1(OnOverheadChanged, void(size_t overhead_bytes_per_packet));
164};
165
166class RtpSenderTest : public ::testing::TestWithParam<bool> {
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000167 protected:
168 RtpSenderTest()
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000169 : fake_clock_(kStartTime),
terelius429c3452016-01-21 05:42:04 -0800170 mock_rtc_event_log_(),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000171 mock_paced_sender_(),
sprangcd349d92016-07-13 09:11:28 -0700172 retransmission_rate_limiter_(&fake_clock_, 1000),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000173 rtp_sender_(),
174 payload_(kPayload),
175 transport_(),
minyue3a407ee2017-04-03 01:10:33 -0700176 kMarkerBit(true),
177 field_trials_(GetParam() ? "WebRTC-SendSideBwe-WithOverhead/Enabled/"
178 : "") {}
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000179
Erik Språng7b52f102018-02-07 14:37:37 +0100180 void SetUp() override { SetUpRtpSender(true, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200181
Erik Språng7b52f102018-02-07 14:37:37 +0100182 void SetUpRtpSender(bool pacer, bool populate_network2) {
asapersson35151f32016-05-02 23:44:01 -0700183 rtp_sender_.reset(new RTPSender(
184 false, &fake_clock_, &transport_, pacer ? &mock_paced_sender_ : nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -0800185 nullptr, &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
sprangcd349d92016-07-13 09:11:28 -0700186 &mock_rtc_event_log_, &send_packet_observer_,
Benjamin Wright192eeec2018-10-17 17:27:25 -0700187 &retransmission_rate_limiter_, nullptr, populate_network2, nullptr,
188 false));
brandtr9dfff292016-11-14 05:14:50 -0800189 rtp_sender_->SetSequenceNumber(kSeqNum);
danilchap71fead22016-08-18 02:01:49 -0700190 rtp_sender_->SetTimestampOffset(0);
brandtr9dfff292016-11-14 05:14:50 -0800191 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000192 }
193
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000194 SimulatedClock fake_clock_;
stefana23fc622016-07-28 07:56:38 -0700195 testing::NiceMock<MockRtcEventLog> mock_rtc_event_log_;
sprangebbf8a82015-09-21 15:11:14 -0700196 MockRtpPacketSender mock_paced_sender_;
stefana23fc622016-07-28 07:56:38 -0700197 testing::StrictMock<MockTransportSequenceNumberAllocator> seq_num_allocator_;
198 testing::StrictMock<MockSendPacketObserver> send_packet_observer_;
Stefan Holmera246cfb2016-08-23 17:51:42 +0200199 testing::StrictMock<MockTransportFeedbackObserver> feedback_observer_;
sprangcd349d92016-07-13 09:11:28 -0700200 RateLimiter retransmission_rate_limiter_;
kwiberg84be5112016-04-27 01:19:58 -0700201 std::unique_ptr<RTPSender> rtp_sender_;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000202 int payload_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000203 LoopbackTransportTest transport_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000204 const bool kMarkerBit;
minyue3a407ee2017-04-03 01:10:33 -0700205 test::ScopedFieldTrials field_trials_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000206
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000207 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header) {
danilchapd9e62f52016-01-14 14:55:19 -0800208 VerifyRTPHeaderCommon(rtp_header, kMarkerBit, 0);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000209 }
210
211 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header, bool marker_bit) {
danilchapd9e62f52016-01-14 14:55:19 -0800212 VerifyRTPHeaderCommon(rtp_header, marker_bit, 0);
213 }
214
215 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header,
216 bool marker_bit,
217 uint8_t number_of_csrcs) {
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000218 EXPECT_EQ(marker_bit, rtp_header.markerBit);
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000219 EXPECT_EQ(payload_, rtp_header.payloadType);
220 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
221 EXPECT_EQ(kTimestamp, rtp_header.timestamp);
222 EXPECT_EQ(rtp_sender_->SSRC(), rtp_header.ssrc);
danilchapd9e62f52016-01-14 14:55:19 -0800223 EXPECT_EQ(number_of_csrcs, rtp_header.numCSRCs);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000224 EXPECT_EQ(0U, rtp_header.paddingLength);
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000225 }
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000226
danilchapb6f1fb52016-10-19 06:11:39 -0700227 std::unique_ptr<RtpPacketToSend> BuildRtpPacket(int payload_type,
228 bool marker_bit,
229 uint32_t timestamp,
230 int64_t capture_time_ms) {
231 auto packet = rtp_sender_->AllocatePacket();
232 packet->SetPayloadType(payload_type);
233 packet->SetMarker(marker_bit);
234 packet->SetTimestamp(timestamp);
235 packet->set_capture_time_ms(capture_time_ms);
236 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
237 return packet;
238 }
239
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000240 void SendPacket(int64_t capture_time_ms, int payload_length) {
241 uint32_t timestamp = capture_time_ms * 90;
danilchapb6f1fb52016-10-19 06:11:39 -0700242 auto packet =
243 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
244 packet->AllocatePayload(payload_length);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000245
246 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700247 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
248 kAllowRetransmission,
249 RtpPacketSender::kNormalPriority));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000250 }
asapersson35151f32016-05-02 23:44:01 -0700251
252 void SendGenericPayload() {
asapersson35151f32016-05-02 23:44:01 -0700253 const uint32_t kTimestamp = 1234;
254 const uint8_t kPayloadType = 127;
255 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
256 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
257 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
258 0, 1500));
259
Sami Kalliomäki426a80c2018-08-08 11:37:59 +0200260 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700261 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
Stefan Holmera246cfb2016-08-23 17:51:42 +0200262 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +0200263 sizeof(kPayloadData), nullptr, &video_header, nullptr,
spranga8ae6f22017-09-04 07:23:56 -0700264 kDefaultExpectedRetransmissionTimeMs));
asapersson35151f32016-05-02 23:44:01 -0700265 }
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000266};
267
Peter Boströme23e7372015-10-08 11:44:14 +0200268// TODO(pbos): Move tests over from WithoutPacer to RtpSenderTest as this is our
269// default code path.
270class RtpSenderTestWithoutPacer : public RtpSenderTest {
271 public:
Erik Språng7b52f102018-02-07 14:37:37 +0100272 void SetUp() override { SetUpRtpSender(false, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200273};
274
spranga8ae6f22017-09-04 07:23:56 -0700275class TestRtpSenderVideo : public RTPSenderVideo {
276 public:
277 TestRtpSenderVideo(Clock* clock,
278 RTPSender* rtp_sender,
279 FlexfecSender* flexfec_sender)
Benjamin Wright192eeec2018-10-17 17:27:25 -0700280 : RTPSenderVideo(clock, rtp_sender, flexfec_sender, nullptr, false) {}
spranga8ae6f22017-09-04 07:23:56 -0700281 ~TestRtpSenderVideo() override {}
282
283 StorageType GetStorageType(const RTPVideoHeader& header,
284 int32_t retransmission_settings,
285 int64_t expected_retransmission_time_ms) {
286 return RTPSenderVideo::GetStorageType(GetTemporalId(header),
287 retransmission_settings,
288 expected_retransmission_time_ms);
289 }
290};
291
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000292class RtpSenderVideoTest : public RtpSenderTest {
293 protected:
danilchap162abd32015-12-10 02:39:40 -0800294 void SetUp() override {
Peter Boströme23e7372015-10-08 11:44:14 +0200295 // TODO(pbos): Set up to use pacer.
Erik Språng7b52f102018-02-07 14:37:37 +0100296 SetUpRtpSender(false, false);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000297 rtp_sender_video_.reset(
spranga8ae6f22017-09-04 07:23:56 -0700298 new TestRtpSenderVideo(&fake_clock_, rtp_sender_.get(), nullptr));
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000299 }
spranga8ae6f22017-09-04 07:23:56 -0700300 std::unique_ptr<TestRtpSenderVideo> rtp_sender_video_;
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000301};
302
minyue3a407ee2017-04-03 01:10:33 -0700303TEST_P(RtpSenderTestWithoutPacer, AllocatePacketSetCsrc) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200304 // Configure rtp_sender with csrc.
305 std::vector<uint32_t> csrcs;
306 csrcs.push_back(0x23456789);
307 rtp_sender_->SetCsrcs(csrcs);
308
309 auto packet = rtp_sender_->AllocatePacket();
310
311 ASSERT_TRUE(packet);
312 EXPECT_EQ(rtp_sender_->SSRC(), packet->Ssrc());
313 EXPECT_EQ(csrcs, packet->Csrcs());
314}
315
minyue3a407ee2017-04-03 01:10:33 -0700316TEST_P(RtpSenderTestWithoutPacer, AllocatePacketReserveExtensions) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200317 // Configure rtp_sender with extensions.
318 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
319 kRtpExtensionTransmissionTimeOffset,
320 kTransmissionTimeOffsetExtensionId));
321 ASSERT_EQ(
322 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
323 kAbsoluteSendTimeExtensionId));
324 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
325 kAudioLevelExtensionId));
326 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
327 kRtpExtensionTransportSequenceNumber,
328 kTransportSequenceNumberExtensionId));
329 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
330 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
331
332 auto packet = rtp_sender_->AllocatePacket();
333
334 ASSERT_TRUE(packet);
335 // Preallocate BWE extensions RtpSender set itself.
336 EXPECT_TRUE(packet->HasExtension<TransmissionOffset>());
337 EXPECT_TRUE(packet->HasExtension<AbsoluteSendTime>());
338 EXPECT_TRUE(packet->HasExtension<TransportSequenceNumber>());
339 // Do not allocate media specific extensions.
340 EXPECT_FALSE(packet->HasExtension<AudioLevel>());
341 EXPECT_FALSE(packet->HasExtension<VideoOrientation>());
342}
343
minyue3a407ee2017-04-03 01:10:33 -0700344TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberAdvanceSequenceNumber) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200345 auto packet = rtp_sender_->AllocatePacket();
346 ASSERT_TRUE(packet);
347 const uint16_t sequence_number = rtp_sender_->SequenceNumber();
348
349 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
350
351 EXPECT_EQ(sequence_number, packet->SequenceNumber());
352 EXPECT_EQ(sequence_number + 1, rtp_sender_->SequenceNumber());
353}
354
minyue3a407ee2017-04-03 01:10:33 -0700355TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberFailsOnNotSending) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200356 auto packet = rtp_sender_->AllocatePacket();
357 ASSERT_TRUE(packet);
358
359 rtp_sender_->SetSendingMediaStatus(false);
360 EXPECT_FALSE(rtp_sender_->AssignSequenceNumber(packet.get()));
361}
362
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100363TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberMayAllowPaddingOnVideo) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200364 constexpr size_t kPaddingSize = 100;
365 auto packet = rtp_sender_->AllocatePacket();
366 ASSERT_TRUE(packet);
367
philipel8aadd502017-02-23 02:56:13 -0800368 ASSERT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200369 packet->SetMarker(false);
370 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100371 // Packet without marker bit doesn't allow padding on video stream.
philipel8aadd502017-02-23 02:56:13 -0800372 EXPECT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200373
374 packet->SetMarker(true);
375 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
376 // Packet with marker bit allows send padding.
philipel8aadd502017-02-23 02:56:13 -0800377 EXPECT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200378}
379
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100380TEST_P(RtpSenderTest, AssignSequenceNumberAllowsPaddingOnAudio) {
381 MockTransport transport;
382 const bool kEnableAudio = true;
383 rtp_sender_.reset(new RTPSender(
384 kEnableAudio, &fake_clock_, &transport, &mock_paced_sender_, nullptr,
385 nullptr, nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Benjamin Wright192eeec2018-10-17 17:27:25 -0700386 nullptr, &retransmission_rate_limiter_, nullptr, false, nullptr, false));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100387 rtp_sender_->SetTimestampOffset(0);
388 rtp_sender_->SetSSRC(kSsrc);
389
390 std::unique_ptr<RtpPacketToSend> audio_packet = rtp_sender_->AllocatePacket();
391 // Padding on audio stream allowed regardless of marker in the last packet.
392 audio_packet->SetMarker(false);
393 audio_packet->SetPayloadType(kPayload);
394 rtp_sender_->AssignSequenceNumber(audio_packet.get());
395
396 const size_t kPaddingSize = 59;
397 EXPECT_CALL(transport, SendRtp(_, kPaddingSize + kRtpHeaderSize, _))
398 .WillOnce(testing::Return(true));
399 EXPECT_EQ(kPaddingSize,
400 rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
401
402 // Requested padding size is too small, will send a larger one.
403 const size_t kMinPaddingSize = 50;
404 EXPECT_CALL(transport, SendRtp(_, kMinPaddingSize + kRtpHeaderSize, _))
405 .WillOnce(testing::Return(true));
Yves Gerey665174f2018-06-19 15:03:05 +0200406 EXPECT_EQ(kMinPaddingSize, rtp_sender_->TimeToSendPadding(kMinPaddingSize - 5,
407 PacedPacketInfo()));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100408}
409
minyue3a407ee2017-04-03 01:10:33 -0700410TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberSetPaddingTimestamps) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200411 constexpr size_t kPaddingSize = 100;
412 auto packet = rtp_sender_->AllocatePacket();
413 ASSERT_TRUE(packet);
414 packet->SetMarker(true);
415 packet->SetTimestamp(kTimestamp);
416
417 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
philipel8aadd502017-02-23 02:56:13 -0800418 ASSERT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200419
420 ASSERT_EQ(1u, transport_.sent_packets_.size());
danilchap12ba1862016-10-26 02:41:55 -0700421 // Verify padding packet timestamp.
422 EXPECT_EQ(kTimestamp, transport_.last_sent_packet().Timestamp());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200423}
424
minyue3a407ee2017-04-03 01:10:33 -0700425TEST_P(RtpSenderTestWithoutPacer,
426 TransportFeedbackObserverGetsCorrectByteCount) {
427 constexpr int kRtpOverheadBytesPerPacket = 12 + 8;
428 testing::NiceMock<MockOverheadObserver> mock_overhead_observer;
429 rtp_sender_.reset(new RTPSender(
430 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
431 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Benjamin Wright192eeec2018-10-17 17:27:25 -0700432 nullptr, &retransmission_rate_limiter_, &mock_overhead_observer, false,
433 nullptr, false));
minyue3a407ee2017-04-03 01:10:33 -0700434 rtp_sender_->SetSSRC(kSsrc);
435 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
436 kRtpExtensionTransportSequenceNumber,
437 kTransportSequenceNumberExtensionId));
438 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
439 .WillOnce(testing::Return(kTransportSequenceNumber));
440
441 const size_t expected_bytes =
442 GetParam() ? sizeof(kPayloadData) + kGenericHeaderLength +
443 kRtpOverheadBytesPerPacket
444 : sizeof(kPayloadData) + kGenericHeaderLength;
445
446 EXPECT_CALL(feedback_observer_,
447 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber,
448 expected_bytes, PacedPacketInfo()))
449 .Times(1);
450 EXPECT_CALL(mock_overhead_observer,
451 OnOverheadChanged(kRtpOverheadBytesPerPacket))
452 .Times(1);
453 SendGenericPayload();
454}
455
456TEST_P(RtpSenderTestWithoutPacer, SendsPacketsWithTransportSequenceNumber) {
Stefan Holmera246cfb2016-08-23 17:51:42 +0200457 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800458 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
459 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Benjamin Wright192eeec2018-10-17 17:27:25 -0700460 &send_packet_observer_, &retransmission_rate_limiter_, nullptr, false,
461 nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -0800462 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100463 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
464 kRtpExtensionTransportSequenceNumber,
465 kTransportSequenceNumberExtensionId));
466
Stefan Holmerf5dca482016-01-27 12:58:51 +0100467 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
468 .WillOnce(testing::Return(kTransportSequenceNumber));
asapersson35151f32016-05-02 23:44:01 -0700469 EXPECT_CALL(send_packet_observer_,
470 OnSendPacket(kTransportSequenceNumber, _, _))
471 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700472
473 EXPECT_CALL(feedback_observer_,
474 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
475 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200476 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700477
478 SendGenericPayload();
Stefan Holmerf5dca482016-01-27 12:58:51 +0100479
danilchap12ba1862016-10-26 02:41:55 -0700480 const auto& packet = transport_.last_sent_packet();
481 uint16_t transport_seq_no;
482 ASSERT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
483 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200484 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200485 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200486}
487
488TEST_P(RtpSenderTestWithoutPacer, PacketOptionsNoRetransmission) {
489 rtp_sender_.reset(new RTPSender(
490 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
491 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
Benjamin Wright192eeec2018-10-17 17:27:25 -0700492 &send_packet_observer_, &retransmission_rate_limiter_, nullptr, false,
493 nullptr, false));
Petter Strandmark26bc6692018-05-29 08:43:35 +0200494 rtp_sender_->SetSSRC(kSsrc);
495
496 SendGenericPayload();
497
498 EXPECT_FALSE(transport_.last_options_.is_retransmit);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100499}
500
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200501TEST_P(RtpSenderTestWithoutPacer,
502 SetsIncludedInFeedbackWhenTransportSequenceNumberExtensionIsRegistered) {
503 SetUpRtpSender(false, false);
504 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber,
505 kTransportSequenceNumberExtensionId);
506 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
507 .WillOnce(testing::Return(kTransportSequenceNumber));
508 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
stefana23fc622016-07-28 07:56:38 -0700509 SendGenericPayload();
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200510 EXPECT_TRUE(transport_.last_options_.included_in_feedback);
511}
512
513TEST_P(
514 RtpSenderTestWithoutPacer,
515 SetsIncludedInAllocationWhenTransportSequenceNumberExtensionIsRegistered) {
516 SetUpRtpSender(false, false);
517 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber,
518 kTransportSequenceNumberExtensionId);
519 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
520 .WillOnce(testing::Return(kTransportSequenceNumber));
521 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
522 SendGenericPayload();
523 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
524}
525
526TEST_P(RtpSenderTestWithoutPacer,
527 SetsIncludedInAllocationWhenForcedAsPartOfAllocation) {
528 SetUpRtpSender(false, false);
529 rtp_sender_->SetAsPartOfAllocation(true);
530 SendGenericPayload();
531 EXPECT_FALSE(transport_.last_options_.included_in_feedback);
532 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
533}
534
535TEST_P(RtpSenderTestWithoutPacer, DoesnSetIncludedInAllocationByDefault) {
536 SetUpRtpSender(false, false);
537 SendGenericPayload();
538 EXPECT_FALSE(transport_.last_options_.included_in_feedback);
539 EXPECT_FALSE(transport_.last_options_.included_in_allocation);
stefana23fc622016-07-28 07:56:38 -0700540}
asapersson35151f32016-05-02 23:44:01 -0700541
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200542TEST_P(RtpSenderTestWithoutPacer, OnSendSideDelayUpdated) {
543 testing::StrictMock<MockSendSideDelayObserver> send_side_delay_observer_;
Benjamin Wright192eeec2018-10-17 17:27:25 -0700544 rtp_sender_.reset(new RTPSender(
545 false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
546 nullptr, nullptr, &send_side_delay_observer_, &mock_rtc_event_log_,
547 nullptr, nullptr, nullptr, false, nullptr, false));
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200548 rtp_sender_->SetSSRC(kSsrc);
549
550 const uint8_t kPayloadType = 127;
551 const uint32_t kCaptureTimeMsToRtpTimestamp = 90; // 90 kHz clock
552 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
553 RTPVideoHeader video_header;
554 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType,
555 1000 * kCaptureTimeMsToRtpTimestamp,
556 0, 1500));
557
558 // Send packet with 10 ms send-side delay. The average and max should be 10
559 // ms.
560 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(10, 10, kSsrc))
561 .Times(1);
562 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
563 fake_clock_.AdvanceTimeMilliseconds(10);
564 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
565 kVideoFrameKey, kPayloadType,
566 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
567 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
568 kDefaultExpectedRetransmissionTimeMs));
569
570 // Send another packet with 20 ms delay. The average
571 // and max should be 15 and 20 ms respectively.
572 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(15, 20, kSsrc))
573 .Times(1);
574 fake_clock_.AdvanceTimeMilliseconds(10);
575 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
576 kVideoFrameKey, kPayloadType,
577 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
578 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
579 kDefaultExpectedRetransmissionTimeMs));
580
581 // Send another packet at the same time, which replaces the last packet.
582 // Since this packet has 0 ms delay, the average is now 5 ms and max is 10 ms.
583 // TODO(terelius): Is is not clear that this is the right behavior.
584 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(5, 10, kSsrc))
585 .Times(1);
586 capture_time_ms = fake_clock_.TimeInMilliseconds();
587 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
588 kVideoFrameKey, kPayloadType,
589 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
590 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
591 kDefaultExpectedRetransmissionTimeMs));
592
593 // Send a packet 1 second later. The earlier packets should have timed
594 // out, so both max and average should be the delay of this packet.
595 fake_clock_.AdvanceTimeMilliseconds(1000);
596 capture_time_ms = fake_clock_.TimeInMilliseconds();
597 fake_clock_.AdvanceTimeMilliseconds(1);
598 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(1, 1, kSsrc))
599 .Times(1);
600 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
601 kVideoFrameKey, kPayloadType,
602 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
603 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
604 kDefaultExpectedRetransmissionTimeMs));
605}
606
minyue3a407ee2017-04-03 01:10:33 -0700607TEST_P(RtpSenderTestWithoutPacer, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700608 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
609 kRtpExtensionTransportSequenceNumber,
610 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700611 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
612 .WillOnce(testing::Return(kTransportSequenceNumber));
613 EXPECT_CALL(send_packet_observer_,
614 OnSendPacket(kTransportSequenceNumber, _, _))
615 .Times(1);
616
617 SendGenericPayload();
618}
619
minyue3a407ee2017-04-03 01:10:33 -0700620TEST_P(RtpSenderTest, SendsPacketsWithTransportSequenceNumber) {
michaelt4da30442016-11-17 01:38:43 -0800621 rtp_sender_.reset(new RTPSender(
622 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
623 &seq_num_allocator_, &feedback_observer_, nullptr, nullptr, nullptr,
624 &mock_rtc_event_log_, &send_packet_observer_,
Benjamin Wright192eeec2018-10-17 17:27:25 -0700625 &retransmission_rate_limiter_, nullptr, false, nullptr, false));
brandtr9dfff292016-11-14 05:14:50 -0800626 rtp_sender_->SetSequenceNumber(kSeqNum);
627 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200628 rtp_sender_->SetStorePacketsStatus(true, 10);
629 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
630 kRtpExtensionTransportSequenceNumber,
631 kTransportSequenceNumberExtensionId));
632
brandtr9dfff292016-11-14 05:14:50 -0800633 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200634 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
635 .WillOnce(testing::Return(kTransportSequenceNumber));
636 EXPECT_CALL(send_packet_observer_,
637 OnSendPacket(kTransportSequenceNumber, _, _))
638 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700639 EXPECT_CALL(feedback_observer_,
640 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
641 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200642 .Times(1);
643
644 SendGenericPayload();
philipel8aadd502017-02-23 02:56:13 -0800645 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
646 fake_clock_.TimeInMilliseconds(), false,
647 PacedPacketInfo());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200648
danilchap12ba1862016-10-26 02:41:55 -0700649 const auto& packet = transport_.last_sent_packet();
650 uint16_t transport_seq_no;
651 EXPECT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
652 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200653 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200654}
655
Erik Språng7b52f102018-02-07 14:37:37 +0100656TEST_P(RtpSenderTest, WritesPacerExitToTimingExtension) {
ilnik04f4d122017-06-19 07:18:55 -0700657 rtp_sender_->SetStorePacketsStatus(true, 10);
658 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
659 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
660 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
661 auto packet = rtp_sender_->AllocatePacket();
662 packet->SetPayloadType(kPayload);
663 packet->SetMarker(true);
664 packet->SetTimestamp(kTimestamp);
665 packet->set_capture_time_ms(capture_time_ms);
ilnik2edc6842017-07-06 03:06:50 -0700666 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
ilnik04f4d122017-06-19 07:18:55 -0700667 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
668 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
669 size_t packet_size = packet->size();
ilnik04f4d122017-06-19 07:18:55 -0700670
671 const int kStoredTimeInMs = 100;
Erik Språng7b52f102018-02-07 14:37:37 +0100672 {
673 EXPECT_CALL(
674 mock_paced_sender_,
675 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _));
676 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
677 kAllowRetransmission,
678 RtpPacketSender::kNormalPriority));
679 }
ilnik04f4d122017-06-19 07:18:55 -0700680 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
Erik Språng7b52f102018-02-07 14:37:37 +0100681 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
682 PacedPacketInfo());
ilnik04f4d122017-06-19 07:18:55 -0700683 EXPECT_EQ(1, transport_.packets_sent());
684 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
685
danilchapce251812017-09-11 12:24:41 -0700686 VideoSendTiming video_timing;
687 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
688 &video_timing));
689 EXPECT_EQ(kStoredTimeInMs, video_timing.pacer_exit_delta_ms);
Erik Språng7b52f102018-02-07 14:37:37 +0100690}
ilnik04f4d122017-06-19 07:18:55 -0700691
Erik Språng7b52f102018-02-07 14:37:37 +0100692TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtension) {
693 SetUpRtpSender(true, true);
694 rtp_sender_->SetStorePacketsStatus(true, 10);
695 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
696 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
697 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
698 auto packet = rtp_sender_->AllocatePacket();
699 packet->SetPayloadType(kPayload);
700 packet->SetMarker(true);
701 packet->SetTimestamp(kTimestamp);
702 packet->set_capture_time_ms(capture_time_ms);
703 const uint16_t kPacerExitMs = 1234u;
704 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, kPacerExitMs, 0u, 0u, true};
705 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
706 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
707 size_t packet_size = packet->size();
708
709 const int kStoredTimeInMs = 100;
710 {
711 EXPECT_CALL(
712 mock_paced_sender_,
713 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _));
714 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
715 kAllowRetransmission,
716 RtpPacketSender::kNormalPriority));
717 }
ilnik04f4d122017-06-19 07:18:55 -0700718 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
719 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
720 PacedPacketInfo());
Erik Språng7b52f102018-02-07 14:37:37 +0100721 EXPECT_EQ(1, transport_.packets_sent());
ilnik04f4d122017-06-19 07:18:55 -0700722 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
723
Erik Språng7b52f102018-02-07 14:37:37 +0100724 VideoSendTiming video_timing;
danilchapce251812017-09-11 12:24:41 -0700725 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
726 &video_timing));
Erik Språng7b52f102018-02-07 14:37:37 +0100727 EXPECT_EQ(kStoredTimeInMs, video_timing.network2_timestamp_delta_ms);
728 EXPECT_EQ(kPacerExitMs, video_timing.pacer_exit_delta_ms);
ilnik04f4d122017-06-19 07:18:55 -0700729}
730
minyue3a407ee2017-04-03 01:10:33 -0700731TEST_P(RtpSenderTest, TrafficSmoothingWithExtensions) {
Peter Boströme23e7372015-10-08 11:44:14 +0200732 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800733 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200734 EXPECT_CALL(mock_rtc_event_log_,
735 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000736
pwestin@webrtc.orgc66e8b32012-11-07 17:01:04 +0000737 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000738 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800739 kRtpExtensionTransmissionTimeOffset,
740 kTransmissionTimeOffsetExtensionId));
741 EXPECT_EQ(
742 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
743 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000744 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700745 auto packet =
746 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
747 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000748
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000749 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700750 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
751 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700752 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000753
danilchap12ba1862016-10-26 02:41:55 -0700754 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000755
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000756 const int kStoredTimeInMs = 100;
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000757 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000758
brandtr9dfff292016-11-14 05:14:50 -0800759 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800760 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000761
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000762 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700763 EXPECT_EQ(1, transport_.packets_sent());
764 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
765
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000766 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700767 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000768
769 // Verify transmission time offset.
770 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000771 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000772 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000773 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000774}
775
minyue3a407ee2017-04-03 01:10:33 -0700776TEST_P(RtpSenderTest, TrafficSmoothingRetransmits) {
Peter Boströme23e7372015-10-08 11:44:14 +0200777 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800778 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200779 EXPECT_CALL(mock_rtc_event_log_,
780 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000781
782 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000783 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800784 kRtpExtensionTransmissionTimeOffset,
785 kTransmissionTimeOffsetExtensionId));
786 EXPECT_EQ(
787 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
788 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000789 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700790 auto packet =
791 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
792 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000793
794 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700795 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
796 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700797 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000798
danilchap12ba1862016-10-26 02:41:55 -0700799 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000800
terelius5d332ac2016-01-14 14:37:39 -0800801 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800802 kSsrc, kSeqNum, _, _, _));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000803
804 const int kStoredTimeInMs = 100;
805 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
806
danilchapb6f1fb52016-10-19 06:11:39 -0700807 EXPECT_EQ(static_cast<int>(packet_size), rtp_sender_->ReSendPacket(kSeqNum));
danilchap12ba1862016-10-26 02:41:55 -0700808 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000809
brandtr9dfff292016-11-14 05:14:50 -0800810 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800811 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000812
813 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700814 EXPECT_EQ(1, transport_.packets_sent());
815 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000816
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000817 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700818 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000819
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000820 // Verify transmission time offset.
821 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000822 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000823 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
824 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
825}
826
827// This test sends 1 regular video packet, then 4 padding packets, and then
828// 1 more regular packet.
minyue3a407ee2017-04-03 01:10:33 -0700829TEST_P(RtpSenderTest, SendPadding) {
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000830 // Make all (non-padding) packets go to send queue.
terelius5d332ac2016-01-14 14:37:39 -0800831 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800832 kSsrc, kSeqNum, _, _, _));
Elad Alon4a87e1c2017-10-03 16:11:34 +0200833 EXPECT_CALL(mock_rtc_event_log_,
834 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
835 .Times(1 + 4 + 1);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000836
837 uint16_t seq_num = kSeqNum;
838 uint32_t timestamp = kTimestamp;
839 rtp_sender_->SetStorePacketsStatus(true, 10);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000840 size_t rtp_header_len = kRtpHeaderSize;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000841 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800842 kRtpExtensionTransmissionTimeOffset,
843 kTransmissionTimeOffsetExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000844 rtp_header_len += 4; // 4 bytes extension.
danilchap162abd32015-12-10 02:39:40 -0800845 EXPECT_EQ(
846 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
847 kAbsoluteSendTimeExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000848 rtp_header_len += 4; // 4 bytes extension.
849 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
850
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000851 webrtc::RTPHeader rtp_header;
852
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000853 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700854 auto packet =
855 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200856 const uint32_t media_packet_timestamp = timestamp;
danilchapb6f1fb52016-10-19 06:11:39 -0700857 size_t packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000858
859 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700860 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
861 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700862 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000863
864 int total_packets_sent = 0;
danilchap12ba1862016-10-26 02:41:55 -0700865 EXPECT_EQ(total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000866
867 const int kStoredTimeInMs = 100;
868 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
brandtr9dfff292016-11-14 05:14:50 -0800869 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800870 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000871 // Packet should now be sent. This test doesn't verify the regular video
872 // packet, since it is tested in another test.
danilchap12ba1862016-10-26 02:41:55 -0700873 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000874 timestamp += 90 * kStoredTimeInMs;
875
876 // Send padding 4 times, waiting 50 ms between each.
877 for (int i = 0; i < 4; ++i) {
878 const int kPaddingPeriodMs = 50;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000879 const size_t kPaddingBytes = 100;
880 const size_t kMaxPaddingLength = 224; // Value taken from rtp_sender.cc.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000881 // Padding will be forced to full packets.
philipelc7bf32a2017-02-17 03:59:43 -0800882 EXPECT_EQ(kMaxPaddingLength,
philipel8aadd502017-02-23 02:56:13 -0800883 rtp_sender_->TimeToSendPadding(kPaddingBytes, PacedPacketInfo()));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000884
885 // Process send bucket. Padding should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700886 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000887 EXPECT_EQ(kMaxPaddingLength + rtp_header_len,
danilchap12ba1862016-10-26 02:41:55 -0700888 transport_.last_sent_packet().size());
889
890 transport_.last_sent_packet().GetHeader(&rtp_header);
pbosbd2522a2015-07-01 05:35:53 -0700891 EXPECT_EQ(kMaxPaddingLength, rtp_header.paddingLength);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000892
Stefan Holmer586b19b2015-09-18 11:14:31 +0200893 // Verify sequence number and timestamp. The timestamp should be the same
894 // as the last media packet.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000895 EXPECT_EQ(seq_num++, rtp_header.sequenceNumber);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200896 EXPECT_EQ(media_packet_timestamp, rtp_header.timestamp);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000897 // Verify transmission time offset.
Stefan Holmer586b19b2015-09-18 11:14:31 +0200898 int offset = timestamp - media_packet_timestamp;
899 EXPECT_EQ(offset, rtp_header.extension.transmissionTimeOffset);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000900 uint64_t expected_send_time =
901 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
902 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
903 fake_clock_.AdvanceTimeMilliseconds(kPaddingPeriodMs);
904 timestamp += 90 * kPaddingPeriodMs;
905 }
906
907 // Send a regular video packet again.
908 capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700909 packet = BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
910 packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000911
brandtr9dfff292016-11-14 05:14:50 -0800912 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
913 kSsrc, seq_num, _, _, _));
terelius5d332ac2016-01-14 14:37:39 -0800914
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000915 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700916 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
917 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700918 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000919
brandtr9dfff292016-11-14 05:14:50 -0800920 rtp_sender_->TimeToSendPacket(kSsrc, seq_num, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800921 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000922 // Process send bucket.
danilchap12ba1862016-10-26 02:41:55 -0700923 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
924 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
925 transport_.last_sent_packet().GetHeader(&rtp_header);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000926
927 // Verify sequence number and timestamp.
928 EXPECT_EQ(seq_num, rtp_header.sequenceNumber);
929 EXPECT_EQ(timestamp, rtp_header.timestamp);
930 // Verify transmission time offset. This packet is sent without delay.
931 EXPECT_EQ(0, rtp_header.extension.transmissionTimeOffset);
932 uint64_t expected_send_time =
933 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000934 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000935}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000936
minyue3a407ee2017-04-03 01:10:33 -0700937TEST_P(RtpSenderTest, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700938 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
939 kRtpExtensionTransportSequenceNumber,
940 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700941 rtp_sender_->SetStorePacketsStatus(true, 10);
942
943 EXPECT_CALL(send_packet_observer_,
944 OnSendPacket(kTransportSequenceNumber, _, _))
945 .Times(1);
946 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
947 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800948 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
949 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700950
951 SendGenericPayload(); // Packet passed to pacer.
952 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -0800953 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
954 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800955 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700956 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700957}
958
minyue3a407ee2017-04-03 01:10:33 -0700959TEST_P(RtpSenderTest, OnSendPacketNotUpdatedForRetransmits) {
stefana23fc622016-07-28 07:56:38 -0700960 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
961 kRtpExtensionTransportSequenceNumber,
962 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700963 rtp_sender_->SetStorePacketsStatus(true, 10);
964
965 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
966 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
967 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800968 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
969 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700970
971 SendGenericPayload(); // Packet passed to pacer.
972 const bool kIsRetransmit = true;
brandtr9dfff292016-11-14 05:14:50 -0800973 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
974 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800975 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700976 EXPECT_EQ(1, transport_.packets_sent());
Petter Strandmark26bc6692018-05-29 08:43:35 +0200977 EXPECT_TRUE(transport_.last_options_.is_retransmit);
asapersson35151f32016-05-02 23:44:01 -0700978}
979
minyue3a407ee2017-04-03 01:10:33 -0700980TEST_P(RtpSenderTest, OnSendPacketNotUpdatedWithoutSeqNumAllocator) {
asapersson35151f32016-05-02 23:44:01 -0700981 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800982 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
asapersson35151f32016-05-02 23:44:01 -0700983 nullptr /* TransportSequenceNumberAllocator */, nullptr, nullptr, nullptr,
michaelt4da30442016-11-17 01:38:43 -0800984 nullptr, nullptr, &send_packet_observer_, &retransmission_rate_limiter_,
Benjamin Wright192eeec2018-10-17 17:27:25 -0700985 nullptr, false, nullptr, false));
brandtr9dfff292016-11-14 05:14:50 -0800986 rtp_sender_->SetSequenceNumber(kSeqNum);
987 rtp_sender_->SetSSRC(kSsrc);
stefana23fc622016-07-28 07:56:38 -0700988 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
989 kRtpExtensionTransportSequenceNumber,
990 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700991 rtp_sender_->SetSequenceNumber(kSeqNum);
992 rtp_sender_->SetStorePacketsStatus(true, 10);
993
994 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
brandtr9dfff292016-11-14 05:14:50 -0800995 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
996 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700997
998 SendGenericPayload(); // Packet passed to pacer.
999 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -08001000 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
1001 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -08001002 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -07001003 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -07001004}
1005
minyue3a407ee2017-04-03 01:10:33 -07001006TEST_P(RtpSenderTest, SendRedundantPayloads) {
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001007 MockTransport transport;
terelius429c3452016-01-21 05:42:04 -08001008 rtp_sender_.reset(new RTPSender(
asapersson35151f32016-05-02 23:44:01 -07001009 false, &fake_clock_, &transport, &mock_paced_sender_, nullptr, nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -08001010 nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_, nullptr,
Benjamin Wright192eeec2018-10-17 17:27:25 -07001011 &retransmission_rate_limiter_, nullptr, false, nullptr, false));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001012 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr9dfff292016-11-14 05:14:50 -08001013 rtp_sender_->SetSSRC(kSsrc);
Shao Changbine62202f2015-04-21 20:24:50 +08001014 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001015
1016 uint16_t seq_num = kSeqNum;
1017 rtp_sender_->SetStorePacketsStatus(true, 10);
wu@webrtc.orgebdb0e32014-03-06 23:49:08 +00001018 int32_t rtp_header_len = kRtpHeaderSize;
danilchap162abd32015-12-10 02:39:40 -08001019 EXPECT_EQ(
1020 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
1021 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001022 rtp_header_len += 4; // 4 bytes extension.
1023 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
1024
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +00001025 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
stefan@webrtc.orgef927552014-06-05 08:25:29 +00001026 rtp_sender_->SetRtxSsrc(1234);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001027
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001028 const size_t kNumPayloadSizes = 10;
danilchap162abd32015-12-10 02:39:40 -08001029 const size_t kPayloadSizes[kNumPayloadSizes] = {500, 550, 600, 650, 700,
1030 750, 800, 850, 900, 950};
terelius5d332ac2016-01-14 14:37:39 -08001031 // Expect all packets go through the pacer.
1032 EXPECT_CALL(mock_paced_sender_,
brandtr9dfff292016-11-14 05:14:50 -08001033 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _))
terelius5d332ac2016-01-14 14:37:39 -08001034 .Times(kNumPayloadSizes);
Elad Alon4a87e1c2017-10-03 16:11:34 +02001035 EXPECT_CALL(mock_rtc_event_log_,
1036 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -08001037 .Times(kNumPayloadSizes);
1038
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001039 // Send 10 packets of increasing size.
1040 for (size_t i = 0; i < kNumPayloadSizes; ++i) {
1041 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
stefan1d8a5062015-10-02 03:39:33 -07001042 EXPECT_CALL(transport, SendRtp(_, _, _)).WillOnce(testing::Return(true));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001043 SendPacket(capture_time_ms, kPayloadSizes[i]);
brandtr9dfff292016-11-14 05:14:50 -08001044 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -08001045 PacedPacketInfo());
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001046 fake_clock_.AdvanceTimeMilliseconds(33);
1047 }
terelius429c3452016-01-21 05:42:04 -08001048
Elad Alon4a87e1c2017-10-03 16:11:34 +02001049 EXPECT_CALL(mock_rtc_event_log_,
1050 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
terelius429c3452016-01-21 05:42:04 -08001051 .Times(::testing::AtLeast(4));
1052
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001053 // The amount of padding to send it too small to send a payload packet.
stefan1d8a5062015-10-02 03:39:33 -07001054 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
pbos2d566682015-09-28 09:59:31 -07001055 .WillOnce(testing::Return(true));
philipela1ed0b32016-06-01 06:31:17 -07001056 EXPECT_EQ(kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -08001057 rtp_sender_->TimeToSendPadding(49, PacedPacketInfo()));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001058
Petter Strandmark26bc6692018-05-29 08:43:35 +02001059 PacketOptions options;
Peter Boströmac547a62015-09-17 23:03:57 +02001060 EXPECT_CALL(transport,
stefan1d8a5062015-10-02 03:39:33 -07001061 SendRtp(_, kPayloadSizes[0] + rtp_header_len + kRtxHeaderSize, _))
Yves Gerey665174f2018-06-19 15:03:05 +02001062 .WillOnce(
1063 testing::DoAll(testing::SaveArg<2>(&options), testing::Return(true)));
philipela1ed0b32016-06-01 06:31:17 -07001064 EXPECT_EQ(kPayloadSizes[0],
philipel8aadd502017-02-23 02:56:13 -08001065 rtp_sender_->TimeToSendPadding(500, PacedPacketInfo()));
Petter Strandmark26bc6692018-05-29 08:43:35 +02001066 EXPECT_TRUE(options.is_retransmit);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001067
Yves Gerey665174f2018-06-19 15:03:05 +02001068 EXPECT_CALL(transport, SendRtp(_,
1069 kPayloadSizes[kNumPayloadSizes - 1] +
1070 rtp_header_len + kRtxHeaderSize,
stefan1d8a5062015-10-02 03:39:33 -07001071 _))
pbos2d566682015-09-28 09:59:31 -07001072 .WillOnce(testing::Return(true));
Petter Strandmark26bc6692018-05-29 08:43:35 +02001073
1074 options.is_retransmit = false;
stefan1d8a5062015-10-02 03:39:33 -07001075 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
Yves Gerey665174f2018-06-19 15:03:05 +02001076 .WillOnce(
1077 testing::DoAll(testing::SaveArg<2>(&options), testing::Return(true)));
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001078 EXPECT_EQ(kPayloadSizes[kNumPayloadSizes - 1] + kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -08001079 rtp_sender_->TimeToSendPadding(999, PacedPacketInfo()));
Petter Strandmark26bc6692018-05-29 08:43:35 +02001080 EXPECT_FALSE(options.is_retransmit);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +00001081}
1082
minyue3a407ee2017-04-03 01:10:33 -07001083TEST_P(RtpSenderTestWithoutPacer, SendGenericVideo) {
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001084 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1085 const uint8_t payload_type = 127;
1086 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1087 0, 1500));
1088 uint8_t payload[] = {47, 11, 32, 93, 89};
1089
1090 // Send keyframe
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001091 RTPVideoHeader video_header;
spranga8ae6f22017-09-04 07:23:56 -07001092 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1093 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001094 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001095
danilchap96c15872016-11-21 01:35:29 -08001096 auto sent_payload = transport_.last_sent_packet().payload();
1097 uint8_t generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001098 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
1099 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -08001100 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001101
1102 // Send delta frame
1103 payload[0] = 13;
1104 payload[1] = 42;
1105 payload[4] = 13;
1106
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001107 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1108 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001109 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001110
danilchap96c15872016-11-21 01:35:29 -08001111 sent_payload = transport_.last_sent_packet().payload();
1112 generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001113 EXPECT_FALSE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
1114 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -08001115 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001116}
1117
minyue3a407ee2017-04-03 01:10:33 -07001118TEST_P(RtpSenderTest, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -08001119 constexpr int kMediaPayloadType = 127;
1120 constexpr int kFlexfecPayloadType = 118;
1121 constexpr uint32_t kMediaSsrc = 1234;
1122 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001123 const char kNoMid[] = "";
brandtrdbdb3f12016-11-10 05:04:48 -08001124 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001125 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -08001126 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001127 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001128 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001129
1130 // Reset |rtp_sender_| to use FlexFEC.
michaelt4da30442016-11-17 01:38:43 -08001131 rtp_sender_.reset(new RTPSender(
1132 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1133 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1134 &mock_rtc_event_log_, &send_packet_observer_,
Benjamin Wright192eeec2018-10-17 17:27:25 -07001135 &retransmission_rate_limiter_, nullptr, false, nullptr, false));
brandtrdbdb3f12016-11-10 05:04:48 -08001136 rtp_sender_->SetSSRC(kMediaSsrc);
1137 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001138 rtp_sender_->SetStorePacketsStatus(true, 10);
1139
1140 // Parameters selected to generate a single FEC packet per media packet.
1141 FecProtectionParams params;
1142 params.fec_rate = 15;
1143 params.max_fec_frames = 1;
1144 params.fec_mask_type = kFecMaskRandom;
1145 rtp_sender_->SetFecParameters(params, params);
1146
brandtr9dfff292016-11-14 05:14:50 -08001147 EXPECT_CALL(mock_paced_sender_,
1148 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
1149 _, _, false));
1150 uint16_t flexfec_seq_num;
brandtrdbdb3f12016-11-10 05:04:48 -08001151 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
brandtr9dfff292016-11-14 05:14:50 -08001152 kFlexfecSsrc, _, _, _, false))
1153 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
brandtrdbdb3f12016-11-10 05:04:48 -08001154 SendGenericPayload();
Elad Alon4a87e1c2017-10-03 16:11:34 +02001155 EXPECT_CALL(mock_rtc_event_log_,
1156 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1157 .Times(2);
philipel8aadd502017-02-23 02:56:13 -08001158 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
1159 fake_clock_.TimeInMilliseconds(),
1160 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -08001161 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
1162 fake_clock_.TimeInMilliseconds(),
philipel8aadd502017-02-23 02:56:13 -08001163 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -08001164 ASSERT_EQ(2, transport_.packets_sent());
brandtrdbdb3f12016-11-10 05:04:48 -08001165 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1166 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
brandtr9dfff292016-11-14 05:14:50 -08001167 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
brandtrdbdb3f12016-11-10 05:04:48 -08001168 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
brandtr9dfff292016-11-14 05:14:50 -08001169 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1170 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1171 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1172 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001173}
1174
ilnik10894992017-06-21 08:23:19 -07001175// TODO(ilnik): because of webrtc:7859. Once FEC moved below pacer, this test
1176// should be removed.
1177TEST_P(RtpSenderTest, NoFlexfecForTimingFrames) {
1178 constexpr int kMediaPayloadType = 127;
1179 constexpr int kFlexfecPayloadType = 118;
1180 constexpr uint32_t kMediaSsrc = 1234;
1181 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001182 const char kNoMid[] = "";
ilnik10894992017-06-21 08:23:19 -07001183 const std::vector<RtpExtension> kNoRtpExtensions;
1184 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
ilnike4350192017-06-29 02:27:44 -07001185
ilnik10894992017-06-21 08:23:19 -07001186 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001187 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
ilnik10894992017-06-21 08:23:19 -07001188 nullptr /* rtp_state */, &fake_clock_);
1189
1190 // Reset |rtp_sender_| to use FlexFEC.
1191 rtp_sender_.reset(new RTPSender(
1192 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1193 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1194 &mock_rtc_event_log_, &send_packet_observer_,
Benjamin Wright192eeec2018-10-17 17:27:25 -07001195 &retransmission_rate_limiter_, nullptr, false, nullptr, false));
ilnik10894992017-06-21 08:23:19 -07001196 rtp_sender_->SetSSRC(kMediaSsrc);
1197 rtp_sender_->SetSequenceNumber(kSeqNum);
ilnik10894992017-06-21 08:23:19 -07001198 rtp_sender_->SetStorePacketsStatus(true, 10);
1199
ilnike4350192017-06-29 02:27:44 -07001200 // Need extension to be registered for timing frames to be sent.
1201 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1202 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1203
ilnik10894992017-06-21 08:23:19 -07001204 // Parameters selected to generate a single FEC packet per media packet.
1205 FecProtectionParams params;
1206 params.fec_rate = 15;
1207 params.max_fec_frames = 1;
1208 params.fec_mask_type = kFecMaskRandom;
1209 rtp_sender_->SetFecParameters(params, params);
1210
1211 EXPECT_CALL(mock_paced_sender_,
1212 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
1213 _, _, false));
1214 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1215 kFlexfecSsrc, _, _, _, false))
1216 .Times(0); // Not called because packet should not be protected.
1217
1218 const uint32_t kTimestamp = 1234;
1219 const uint8_t kPayloadType = 127;
1220 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
1221 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1222 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
1223 0, 1500));
1224 RTPVideoHeader video_header;
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001225 video_header.video_timing.flags = VideoSendTiming::kTriggeredByTimer;
ilnik10894992017-06-21 08:23:19 -07001226 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1227 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
spranga8ae6f22017-09-04 07:23:56 -07001228 sizeof(kPayloadData), nullptr, &video_header, nullptr,
1229 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001230
Elad Alon4a87e1c2017-10-03 16:11:34 +02001231 EXPECT_CALL(mock_rtc_event_log_,
1232 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1233 .Times(1);
ilnik10894992017-06-21 08:23:19 -07001234 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
1235 fake_clock_.TimeInMilliseconds(),
1236 false, PacedPacketInfo()));
1237 ASSERT_EQ(1, transport_.packets_sent());
1238 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1239 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1240 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
1241 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1242
1243 // Now try to send not a timing frame.
1244 uint16_t flexfec_seq_num;
1245 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1246 kFlexfecSsrc, _, _, _, false))
1247 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
1248 EXPECT_CALL(mock_paced_sender_,
1249 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc,
1250 kSeqNum + 1, _, _, false));
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001251 video_header.video_timing.flags = VideoSendTiming::kInvalid;
ilnik10894992017-06-21 08:23:19 -07001252 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1253 kVideoFrameKey, kPayloadType, kTimestamp + 1, kCaptureTimeMs + 1,
spranga8ae6f22017-09-04 07:23:56 -07001254 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
1255 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001256
Elad Alon4a87e1c2017-10-03 16:11:34 +02001257 EXPECT_CALL(mock_rtc_event_log_,
1258 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1259 .Times(2);
ilnik10894992017-06-21 08:23:19 -07001260 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum + 1,
1261 fake_clock_.TimeInMilliseconds(),
1262 false, PacedPacketInfo()));
1263 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
1264 fake_clock_.TimeInMilliseconds(),
1265 false, PacedPacketInfo()));
1266 ASSERT_EQ(3, transport_.packets_sent());
1267 const RtpPacketReceived& media_packet2 = transport_.sent_packets_[1];
1268 EXPECT_EQ(kMediaPayloadType, media_packet2.PayloadType());
1269 EXPECT_EQ(kSeqNum + 1, media_packet2.SequenceNumber());
1270 EXPECT_EQ(kMediaSsrc, media_packet2.Ssrc());
1271 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[2];
1272 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1273 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1274 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1275}
1276
minyue3a407ee2017-04-03 01:10:33 -07001277TEST_P(RtpSenderTestWithoutPacer, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -08001278 constexpr int kMediaPayloadType = 127;
1279 constexpr int kFlexfecPayloadType = 118;
1280 constexpr uint32_t kMediaSsrc = 1234;
1281 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001282 const char kNoMid[] = "";
brandtrdbdb3f12016-11-10 05:04:48 -08001283 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001284 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -08001285 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001286 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001287 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001288
1289 // Reset |rtp_sender_| to use FlexFEC.
Benjamin Wright192eeec2018-10-17 17:27:25 -07001290 rtp_sender_.reset(new RTPSender(
1291 false, &fake_clock_, &transport_, nullptr, &flexfec_sender,
1292 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1293 &mock_rtc_event_log_, &send_packet_observer_,
1294 &retransmission_rate_limiter_, nullptr, false, nullptr, false));
brandtrdbdb3f12016-11-10 05:04:48 -08001295 rtp_sender_->SetSSRC(kMediaSsrc);
1296 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001297
1298 // Parameters selected to generate a single FEC packet per media packet.
1299 FecProtectionParams params;
1300 params.fec_rate = 15;
1301 params.max_fec_frames = 1;
1302 params.fec_mask_type = kFecMaskRandom;
1303 rtp_sender_->SetFecParameters(params, params);
1304
Elad Alon4a87e1c2017-10-03 16:11:34 +02001305 EXPECT_CALL(mock_rtc_event_log_,
1306 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1307 .Times(2);
brandtrdbdb3f12016-11-10 05:04:48 -08001308 SendGenericPayload();
1309 ASSERT_EQ(2, transport_.packets_sent());
1310 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1311 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1312 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1313 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1314 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1315 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1316}
1317
Steve Anton296a0ce2018-03-22 15:17:27 -07001318// Test that the MID header extension is included on sent packets when
1319// configured.
1320TEST_P(RtpSenderTestWithoutPacer, MidIncludedOnSentPackets) {
1321 const char kMid[] = "mid";
1322
1323 // Register MID header extension and set the MID for the RTPSender.
1324 rtp_sender_->SetSendingMediaStatus(false);
1325 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionMid, kMidExtensionId);
1326 rtp_sender_->SetMid(kMid);
1327 rtp_sender_->SetSendingMediaStatus(true);
1328
1329 // Send a couple packets.
1330 SendGenericPayload();
1331 SendGenericPayload();
1332
1333 // Expect both packets to have the MID set.
1334 ASSERT_EQ(2u, transport_.sent_packets_.size());
1335 for (const RtpPacketReceived& packet : transport_.sent_packets_) {
1336 std::string mid;
1337 ASSERT_TRUE(packet.GetExtension<RtpMid>(&mid));
1338 EXPECT_EQ(kMid, mid);
1339 }
1340}
1341
minyue3a407ee2017-04-03 01:10:33 -07001342TEST_P(RtpSenderTest, FecOverheadRate) {
brandtr81eab612017-01-24 04:06:09 -08001343 constexpr int kFlexfecPayloadType = 118;
1344 constexpr uint32_t kMediaSsrc = 1234;
1345 constexpr uint32_t kFlexfecSsrc = 5678;
Steve Antonf0482ea2018-04-09 13:33:52 -07001346 const char kNoMid[] = "";
brandtr81eab612017-01-24 04:06:09 -08001347 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001348 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtr81eab612017-01-24 04:06:09 -08001349 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
Steve Antonf0482ea2018-04-09 13:33:52 -07001350 kNoMid, kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001351 nullptr /* rtp_state */, &fake_clock_);
brandtr81eab612017-01-24 04:06:09 -08001352
1353 // Reset |rtp_sender_| to use FlexFEC.
1354 rtp_sender_.reset(new RTPSender(
1355 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1356 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1357 &mock_rtc_event_log_, &send_packet_observer_,
Benjamin Wright192eeec2018-10-17 17:27:25 -07001358 &retransmission_rate_limiter_, nullptr, false, nullptr, false));
brandtr81eab612017-01-24 04:06:09 -08001359 rtp_sender_->SetSSRC(kMediaSsrc);
1360 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr81eab612017-01-24 04:06:09 -08001361
1362 // Parameters selected to generate a single FEC packet per media packet.
1363 FecProtectionParams params;
1364 params.fec_rate = 15;
1365 params.max_fec_frames = 1;
1366 params.fec_mask_type = kFecMaskRandom;
1367 rtp_sender_->SetFecParameters(params, params);
1368
1369 constexpr size_t kNumMediaPackets = 10;
1370 constexpr size_t kNumFecPackets = kNumMediaPackets;
1371 constexpr int64_t kTimeBetweenPacketsMs = 10;
1372 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, false))
1373 .Times(kNumMediaPackets + kNumFecPackets);
1374 for (size_t i = 0; i < kNumMediaPackets; ++i) {
1375 SendGenericPayload();
1376 fake_clock_.AdvanceTimeMilliseconds(kTimeBetweenPacketsMs);
1377 }
1378 constexpr size_t kRtpHeaderLength = 12;
1379 constexpr size_t kFlexfecHeaderLength = 20;
1380 constexpr size_t kGenericCodecHeaderLength = 1;
1381 constexpr size_t kPayloadLength = sizeof(kPayloadData);
1382 constexpr size_t kPacketLength = kRtpHeaderLength + kFlexfecHeaderLength +
1383 kGenericCodecHeaderLength + kPayloadLength;
1384 EXPECT_NEAR(kNumFecPackets * kPacketLength * 8 /
1385 (kNumFecPackets * kTimeBetweenPacketsMs / 1000.0f),
1386 rtp_sender_->FecOverheadRate(), 500);
1387}
1388
minyue3a407ee2017-04-03 01:10:33 -07001389TEST_P(RtpSenderTest, FrameCountCallbacks) {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001390 class TestCallback : public FrameCountObserver {
1391 public:
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001392 TestCallback() : FrameCountObserver(), num_calls_(0), ssrc_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001393 ~TestCallback() override = default;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001394
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001395 void FrameCountUpdated(const FrameCounts& frame_counts,
1396 uint32_t ssrc) override {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001397 ++num_calls_;
1398 ssrc_ = ssrc;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001399 frame_counts_ = frame_counts;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001400 }
1401
1402 uint32_t num_calls_;
1403 uint32_t ssrc_;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001404 FrameCounts frame_counts_;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001405 } callback;
1406
Erik Språng7b52f102018-02-07 14:37:37 +01001407 rtp_sender_.reset(new RTPSender(
1408 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr, nullptr,
1409 nullptr, nullptr, &callback, nullptr, nullptr, nullptr,
Benjamin Wright192eeec2018-10-17 17:27:25 -07001410 &retransmission_rate_limiter_, nullptr, false, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001411 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001412 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1413 const uint8_t payload_type = 127;
1414 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1415 0, 1500));
1416 uint8_t payload[] = {47, 11, 32, 93, 89};
1417 rtp_sender_->SetStorePacketsStatus(true, 1);
1418 uint32_t ssrc = rtp_sender_->SSRC();
1419
terelius5d332ac2016-01-14 14:37:39 -08001420 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, _))
1421 .Times(::testing::AtLeast(2));
1422
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001423 RTPVideoHeader video_header;
spranga8ae6f22017-09-04 07:23:56 -07001424 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1425 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001426 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001427
1428 EXPECT_EQ(1U, callback.num_calls_);
1429 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001430 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1431 EXPECT_EQ(0, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001432
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001433 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1434 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001435 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001436
1437 EXPECT_EQ(2U, callback.num_calls_);
1438 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001439 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1440 EXPECT_EQ(1, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001441
andresp@webrtc.org8f151212014-07-10 09:39:23 +00001442 rtp_sender_.reset();
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001443}
1444
minyue3a407ee2017-04-03 01:10:33 -07001445TEST_P(RtpSenderTest, BitrateCallbacks) {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001446 class TestCallback : public BitrateStatisticsObserver {
1447 public:
sprangcd349d92016-07-13 09:11:28 -07001448 TestCallback()
1449 : BitrateStatisticsObserver(),
1450 num_calls_(0),
1451 ssrc_(0),
1452 total_bitrate_(0),
1453 retransmit_bitrate_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001454 ~TestCallback() override = default;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001455
sprangcd349d92016-07-13 09:11:28 -07001456 void Notify(uint32_t total_bitrate,
1457 uint32_t retransmit_bitrate,
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001458 uint32_t ssrc) override {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001459 ++num_calls_;
1460 ssrc_ = ssrc;
sprangcd349d92016-07-13 09:11:28 -07001461 total_bitrate_ = total_bitrate;
1462 retransmit_bitrate_ = retransmit_bitrate;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001463 }
1464
1465 uint32_t num_calls_;
1466 uint32_t ssrc_;
sprangcd349d92016-07-13 09:11:28 -07001467 uint32_t total_bitrate_;
1468 uint32_t retransmit_bitrate_;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001469 } callback;
Benjamin Wright192eeec2018-10-17 17:27:25 -07001470 rtp_sender_.reset(new RTPSender(
1471 false, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
1472 &callback, nullptr, nullptr, nullptr, nullptr,
1473 &retransmission_rate_limiter_, nullptr, false, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001474 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001475
sprangcd349d92016-07-13 09:11:28 -07001476 // Simulate kNumPackets sent with kPacketInterval ms intervals, with the
1477 // number of packets selected so that we fill (but don't overflow) the one
1478 // second averaging window.
1479 const uint32_t kWindowSizeMs = 1000;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001480 const uint32_t kPacketInterval = 20;
sprangcd349d92016-07-13 09:11:28 -07001481 const uint32_t kNumPackets =
1482 (kWindowSizeMs - kPacketInterval) / kPacketInterval;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001483 // Overhead = 12 bytes RTP header + 1 byte generic header.
1484 const uint32_t kPacketOverhead = 13;
1485
1486 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1487 const uint8_t payload_type = 127;
danilchap162abd32015-12-10 02:39:40 -08001488 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1489 0, 1500));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001490 uint8_t payload[] = {47, 11, 32, 93, 89};
1491 rtp_sender_->SetStorePacketsStatus(true, 1);
1492 uint32_t ssrc = rtp_sender_->SSRC();
1493
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001494 // Initial process call so we get a new time window.
1495 rtp_sender_->ProcessBitrate();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001496
1497 // Send a few frames.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001498 RTPVideoHeader video_header;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001499 for (uint32_t i = 0; i < kNumPackets; ++i) {
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001500 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1501 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001502 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001503 fake_clock_.AdvanceTimeMilliseconds(kPacketInterval);
1504 }
1505
1506 rtp_sender_->ProcessBitrate();
1507
stefan@webrtc.org0bae1fa2014-11-05 14:05:29 +00001508 // We get one call for every stats updated, thus two calls since both the
1509 // stream stats and the retransmit stats are updated once.
1510 EXPECT_EQ(2u, callback.num_calls_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001511 EXPECT_EQ(ssrc, callback.ssrc_);
sprangcd349d92016-07-13 09:11:28 -07001512 const uint32_t kTotalPacketSize = kPacketOverhead + sizeof(payload);
1513 // Bitrate measured over delta between last and first timestamp, plus one.
1514 const uint32_t kExpectedWindowMs = kNumPackets * kPacketInterval + 1;
1515 const uint32_t kExpectedBitsAccumulated = kTotalPacketSize * kNumPackets * 8;
1516 const uint32_t kExpectedRateBps =
1517 (kExpectedBitsAccumulated * 1000 + (kExpectedWindowMs / 2)) /
1518 kExpectedWindowMs;
1519 EXPECT_EQ(kExpectedRateBps, callback.total_bitrate_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001520
andresp@webrtc.orgd11bec42014-07-08 14:32:58 +00001521 rtp_sender_.reset();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001522}
1523
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001524class RtpSenderAudioTest : public RtpSenderTest {
1525 protected:
1526 RtpSenderAudioTest() {}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001527
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001528 void SetUp() override {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001529 payload_ = kAudioPayload;
Benjamin Wright192eeec2018-10-17 17:27:25 -07001530 rtp_sender_.reset(new RTPSender(
1531 true, &fake_clock_, &transport_, nullptr, nullptr, nullptr, nullptr,
1532 nullptr, nullptr, nullptr, nullptr, nullptr,
1533 &retransmission_rate_limiter_, nullptr, false, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08001534 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001535 rtp_sender_->SetSequenceNumber(kSeqNum);
1536 }
1537};
1538
minyue3a407ee2017-04-03 01:10:33 -07001539TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacks) {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001540 class TestCallback : public StreamDataCountersCallback {
1541 public:
danilchap162abd32015-12-10 02:39:40 -08001542 TestCallback() : StreamDataCountersCallback(), ssrc_(0), counters_() {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001543 ~TestCallback() override = default;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001544
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001545 void DataCountersUpdated(const StreamDataCounters& counters,
1546 uint32_t ssrc) override {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001547 ssrc_ = ssrc;
1548 counters_ = counters;
1549 }
1550
1551 uint32_t ssrc_;
1552 StreamDataCounters counters_;
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001553
1554 void MatchPacketCounter(const RtpPacketCounter& expected,
1555 const RtpPacketCounter& actual) {
1556 EXPECT_EQ(expected.payload_bytes, actual.payload_bytes);
1557 EXPECT_EQ(expected.header_bytes, actual.header_bytes);
1558 EXPECT_EQ(expected.padding_bytes, actual.padding_bytes);
1559 EXPECT_EQ(expected.packets, actual.packets);
1560 }
1561
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001562 void Matches(uint32_t ssrc, const StreamDataCounters& counters) {
1563 EXPECT_EQ(ssrc, ssrc_);
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001564 MatchPacketCounter(counters.transmitted, counters_.transmitted);
1565 MatchPacketCounter(counters.retransmitted, counters_.retransmitted);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001566 EXPECT_EQ(counters.fec.packets, counters_.fec.packets);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001567 }
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001568 } callback;
1569
1570 const uint8_t kRedPayloadType = 96;
1571 const uint8_t kUlpfecPayloadType = 97;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001572 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1573 const uint8_t payload_type = 127;
1574 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1575 0, 1500));
1576 uint8_t payload[] = {47, 11, 32, 93, 89};
1577 rtp_sender_->SetStorePacketsStatus(true, 1);
1578 uint32_t ssrc = rtp_sender_->SSRC();
1579
1580 rtp_sender_->RegisterRtpStatisticsCallback(&callback);
1581
1582 // Send a frame.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001583 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001584 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001585 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001586 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001587 StreamDataCounters expected;
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001588 expected.transmitted.payload_bytes = 6;
1589 expected.transmitted.header_bytes = 12;
1590 expected.transmitted.padding_bytes = 0;
1591 expected.transmitted.packets = 1;
1592 expected.retransmitted.payload_bytes = 0;
1593 expected.retransmitted.header_bytes = 0;
1594 expected.retransmitted.padding_bytes = 0;
1595 expected.retransmitted.packets = 0;
1596 expected.fec.packets = 0;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001597 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001598
1599 // Retransmit a frame.
1600 uint16_t seqno = rtp_sender_->SequenceNumber() - 1;
Erik Språnga12b1d62018-03-14 12:39:24 +01001601 rtp_sender_->ReSendPacket(seqno);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001602 expected.transmitted.payload_bytes = 12;
1603 expected.transmitted.header_bytes = 24;
1604 expected.transmitted.packets = 2;
1605 expected.retransmitted.payload_bytes = 6;
1606 expected.retransmitted.header_bytes = 12;
1607 expected.retransmitted.padding_bytes = 0;
1608 expected.retransmitted.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001609 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001610
1611 // Send padding.
philipel8aadd502017-02-23 02:56:13 -08001612 rtp_sender_->TimeToSendPadding(kMaxPaddingSize, PacedPacketInfo());
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001613 expected.transmitted.payload_bytes = 12;
1614 expected.transmitted.header_bytes = 36;
1615 expected.transmitted.padding_bytes = kMaxPaddingSize;
1616 expected.transmitted.packets = 3;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001617 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001618
brandtrf1bb4762016-11-07 03:05:06 -08001619 // Send ULPFEC.
1620 rtp_sender_->SetUlpfecConfig(kRedPayloadType, kUlpfecPayloadType);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001621 FecProtectionParams fec_params;
1622 fec_params.fec_mask_type = kFecMaskRandom;
1623 fec_params.fec_rate = 1;
1624 fec_params.max_fec_frames = 1;
brandtr1743a192016-11-07 03:36:05 -08001625 rtp_sender_->SetFecParameters(fec_params, fec_params);
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001626 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001627 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001628 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001629 expected.transmitted.payload_bytes = 40;
1630 expected.transmitted.header_bytes = 60;
1631 expected.transmitted.packets = 5;
1632 expected.fec.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001633 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001634
sprang867fb522015-08-03 04:38:41 -07001635 rtp_sender_->RegisterRtpStatisticsCallback(nullptr);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001636}
1637
minyue3a407ee2017-04-03 01:10:33 -07001638TEST_P(RtpSenderAudioTest, SendAudio) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001639 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1640 const uint8_t payload_type = 127;
1641 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1642 0, 1500));
1643 uint8_t payload[] = {47, 11, 32, 93, 89};
1644
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001645 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001646 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001647 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001648 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001649
danilchap96c15872016-11-21 01:35:29 -08001650 auto sent_payload = transport_.last_sent_packet().payload();
1651 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001652}
1653
minyue3a407ee2017-04-03 01:10:33 -07001654TEST_P(RtpSenderAudioTest, SendAudioWithAudioLevelExtension) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001655 EXPECT_EQ(0, rtp_sender_->SetAudioLevel(kAudioLevel));
danilchap162abd32015-12-10 02:39:40 -08001656 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
1657 kAudioLevelExtensionId));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001658
1659 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1660 const uint8_t payload_type = 127;
1661 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1662 0, 1500));
1663 uint8_t payload[] = {47, 11, 32, 93, 89};
1664
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001665 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001666 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001667 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001668 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001669
danilchap96c15872016-11-21 01:35:29 -08001670 auto sent_payload = transport_.last_sent_packet().payload();
1671 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
danilchap12ba1862016-10-26 02:41:55 -07001672 // Verify AudioLevel extension.
1673 bool voice_activity;
1674 uint8_t audio_level;
1675 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<AudioLevel>(
1676 &voice_activity, &audio_level));
1677 EXPECT_EQ(kAudioLevel, audio_level);
1678 EXPECT_FALSE(voice_activity);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001679}
1680
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001681// As RFC4733, named telephone events are carried as part of the audio stream
1682// and must use the same sequence number and timestamp base as the regular
1683// audio channel.
1684// This test checks the marker bit for the first packet and the consequent
1685// packets of the same telephone event. Since it is specifically for DTMF
pbos22993e12015-10-19 02:39:06 -07001686// events, ignoring audio packets and sending kEmptyFrame instead of those.
minyue3a407ee2017-04-03 01:10:33 -07001687TEST_P(RtpSenderAudioTest, CheckMarkerBitForTelephoneEvents) {
solenbergffbbcac2016-11-17 05:25:37 -08001688 const char* kDtmfPayloadName = "telephone-event";
1689 const uint32_t kPayloadFrequency = 8000;
1690 const uint8_t kPayloadType = 126;
1691 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kDtmfPayloadName, kPayloadType,
1692 kPayloadFrequency, 0, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001693 // For Telephone events, payload is not added to the registered payload list,
1694 // it will register only the payload used for audio stream.
1695 // Registering the payload again for audio stream with different payload name.
solenbergffbbcac2016-11-17 05:25:37 -08001696 const char* kPayloadName = "payload_name";
1697 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType,
1698 kPayloadFrequency, 1, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001699 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
1700 // DTMF event key=9, duration=500 and attenuationdB=10
1701 rtp_sender_->SendTelephoneEvent(9, 500, 10);
1702 // During start, it takes the starting timestamp as last sent timestamp.
1703 // The duration is calculated as the difference of current and last sent
1704 // timestamp. So for first call it will skip since the duration is zero.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001705 RTPVideoHeader video_header;
spranga8ae6f22017-09-04 07:23:56 -07001706 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1707 kEmptyFrame, kPayloadType, capture_time_ms, 0, nullptr, 0, nullptr,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001708 &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001709 // DTMF Sample Length is (Frequency/1000) * Duration.
1710 // So in this case, it is (8000/1000) * 500 = 4000.
1711 // Sending it as two packets.
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001712 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001713 kEmptyFrame, kPayloadType, capture_time_ms + 2000, 0, nullptr, 0, nullptr,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001714 &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
danilchap12ba1862016-10-26 02:41:55 -07001715
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001716 // Marker Bit should be set to 1 for first packet.
danilchap12ba1862016-10-26 02:41:55 -07001717 EXPECT_TRUE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001718
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001719 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001720 kEmptyFrame, kPayloadType, capture_time_ms + 4000, 0, nullptr, 0, nullptr,
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001721 &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001722 // Marker Bit should be set to 0 for rest of the packets.
danilchap12ba1862016-10-26 02:41:55 -07001723 EXPECT_FALSE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001724}
1725
minyue3a407ee2017-04-03 01:10:33 -07001726TEST_P(RtpSenderTestWithoutPacer, BytesReportedCorrectly) {
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001727 const char* kPayloadName = "GENERIC";
1728 const uint8_t kPayloadType = 127;
1729 rtp_sender_->SetSSRC(1234);
1730 rtp_sender_->SetRtxSsrc(4321);
Shao Changbine62202f2015-04-21 20:24:50 +08001731 rtp_sender_->SetRtxPayloadType(kPayloadType - 1, kPayloadType);
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +00001732 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001733
danilchap162abd32015-12-10 02:39:40 -08001734 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType, 90000,
1735 0, 1500));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001736 uint8_t payload[] = {47, 11, 32, 93, 89};
1737
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001738 RTPVideoHeader video_header;
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001739 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001740 kVideoFrameKey, kPayloadType, 1234, 4321, payload, sizeof(payload),
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001741 nullptr, &video_header, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001742
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001743 // Will send 2 full-size padding packets.
philipel8aadd502017-02-23 02:56:13 -08001744 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
1745 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001746
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001747 StreamDataCounters rtp_stats;
1748 StreamDataCounters rtx_stats;
1749 rtp_sender_->GetDataCounters(&rtp_stats, &rtx_stats);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001750
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001751 // Payload + 1-byte generic header.
asapersson@webrtc.orgd08d3892014-12-16 12:03:11 +00001752 EXPECT_GT(rtp_stats.first_packet_time_ms, -1);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001753 EXPECT_EQ(rtp_stats.transmitted.payload_bytes, sizeof(payload) + 1);
1754 EXPECT_EQ(rtp_stats.transmitted.header_bytes, 12u);
1755 EXPECT_EQ(rtp_stats.transmitted.padding_bytes, 0u);
1756 EXPECT_EQ(rtx_stats.transmitted.payload_bytes, 0u);
1757 EXPECT_EQ(rtx_stats.transmitted.header_bytes, 24u);
1758 EXPECT_EQ(rtx_stats.transmitted.padding_bytes, 2 * kMaxPaddingSize);
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001759
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001760 EXPECT_EQ(rtp_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001761 rtp_stats.transmitted.payload_bytes +
1762 rtp_stats.transmitted.header_bytes +
1763 rtp_stats.transmitted.padding_bytes);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001764 EXPECT_EQ(rtx_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001765 rtx_stats.transmitted.payload_bytes +
1766 rtx_stats.transmitted.header_bytes +
1767 rtx_stats.transmitted.padding_bytes);
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001768
danilchap162abd32015-12-10 02:39:40 -08001769 EXPECT_EQ(
1770 transport_.total_bytes_sent_,
1771 rtp_stats.transmitted.TotalBytes() + rtx_stats.transmitted.TotalBytes());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001772}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001773
minyue3a407ee2017-04-03 01:10:33 -07001774TEST_P(RtpSenderTestWithoutPacer, RespectsNackBitrateLimit) {
sprang38778b02015-09-29 09:48:22 -07001775 const int32_t kPacketSize = 1400;
1776 const int32_t kNumPackets = 30;
1777
sprangcd349d92016-07-13 09:11:28 -07001778 retransmission_rate_limiter_.SetMaxRate(kPacketSize * kNumPackets * 8);
1779
sprang38778b02015-09-29 09:48:22 -07001780 rtp_sender_->SetStorePacketsStatus(true, kNumPackets);
sprang38778b02015-09-29 09:48:22 -07001781 const uint16_t kStartSequenceNumber = rtp_sender_->SequenceNumber();
Danil Chapovalov2800d742016-08-26 18:48:46 +02001782 std::vector<uint16_t> sequence_numbers;
sprang38778b02015-09-29 09:48:22 -07001783 for (int32_t i = 0; i < kNumPackets; ++i) {
1784 sequence_numbers.push_back(kStartSequenceNumber + i);
1785 fake_clock_.AdvanceTimeMilliseconds(1);
1786 SendPacket(fake_clock_.TimeInMilliseconds(), kPacketSize);
1787 }
danilchap12ba1862016-10-26 02:41:55 -07001788 EXPECT_EQ(kNumPackets, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001789
1790 fake_clock_.AdvanceTimeMilliseconds(1000 - kNumPackets);
1791
1792 // Resending should work - brings the bandwidth up to the limit.
1793 // NACK bitrate is capped to the same bitrate as the encoder, since the max
1794 // protection overhead is 50% (see MediaOptimization::SetTargetRates).
Danil Chapovalov2800d742016-08-26 18:48:46 +02001795 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001796 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001797
sprangcd349d92016-07-13 09:11:28 -07001798 // Must be at least 5ms in between retransmission attempts.
1799 fake_clock_.AdvanceTimeMilliseconds(5);
1800
sprang38778b02015-09-29 09:48:22 -07001801 // Resending should not work, bandwidth exceeded.
Danil Chapovalov2800d742016-08-26 18:48:46 +02001802 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001803 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001804}
1805
minyue3a407ee2017-04-03 01:10:33 -07001806TEST_P(RtpSenderVideoTest, KeyFrameHasCVO) {
danilchapb6f1fb52016-10-19 06:11:39 -07001807 uint8_t kFrame[kMaxPacketLength];
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001808 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1809 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001810
philipel1a4746a2018-07-09 15:52:29 +02001811 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001812 hdr.rotation = kVideoRotation_0;
Niels Möller520ca4e2018-06-04 11:14:38 +02001813 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameKey, kPayload,
danilchapb6f1fb52016-10-19 06:11:39 -07001814 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
spranga8ae6f22017-09-04 07:23:56 -07001815 &hdr, kDefaultExpectedRetransmissionTimeMs);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001816
danilchapc1600c52016-10-26 03:33:11 -07001817 VideoRotation rotation;
1818 EXPECT_TRUE(
1819 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1820 EXPECT_EQ(kVideoRotation_0, rotation);
1821}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001822
ilnik04f4d122017-06-19 07:18:55 -07001823TEST_P(RtpSenderVideoTest, TimingFrameHasPacketizationTimstampSet) {
1824 uint8_t kFrame[kMaxPacketLength];
1825 const int64_t kPacketizationTimeMs = 100;
1826 const int64_t kEncodeStartDeltaMs = 10;
1827 const int64_t kEncodeFinishDeltaMs = 50;
1828 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1829 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1830
1831 const int64_t kCaptureTimestamp = fake_clock_.TimeInMilliseconds();
1832
philipel1a4746a2018-07-09 15:52:29 +02001833 RTPVideoHeader hdr;
Ilya Nikolaevskiyb6c462d2018-06-05 15:21:32 +02001834 hdr.video_timing.flags = VideoSendTiming::kTriggeredByTimer;
ilnik04f4d122017-06-19 07:18:55 -07001835 hdr.video_timing.encode_start_delta_ms = kEncodeStartDeltaMs;
1836 hdr.video_timing.encode_finish_delta_ms = kEncodeFinishDeltaMs;
1837
1838 fake_clock_.AdvanceTimeMilliseconds(kPacketizationTimeMs);
Niels Möller520ca4e2018-06-04 11:14:38 +02001839 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameKey, kPayload,
ilnik04f4d122017-06-19 07:18:55 -07001840 kTimestamp, kCaptureTimestamp, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001841 sizeof(kFrame), nullptr, &hdr,
1842 kDefaultExpectedRetransmissionTimeMs);
ilnik2edc6842017-07-06 03:06:50 -07001843 VideoSendTiming timing;
ilnik04f4d122017-06-19 07:18:55 -07001844 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
1845 &timing));
1846 EXPECT_EQ(kPacketizationTimeMs, timing.packetization_finish_delta_ms);
1847 EXPECT_EQ(kEncodeStartDeltaMs, timing.encode_start_delta_ms);
1848 EXPECT_EQ(kEncodeFinishDeltaMs, timing.encode_finish_delta_ms);
1849}
1850
minyue3a407ee2017-04-03 01:10:33 -07001851TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenChanged) {
danilchapc1600c52016-10-26 03:33:11 -07001852 uint8_t kFrame[kMaxPacketLength];
1853 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1854 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1855
philipel1a4746a2018-07-09 15:52:29 +02001856 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001857 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001858 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001859 kVideoCodecGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001860 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001861
1862 hdr.rotation = kVideoRotation_0;
spranga8ae6f22017-09-04 07:23:56 -07001863 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001864 kVideoCodecGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001865 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001866
1867 VideoRotation rotation;
1868 EXPECT_TRUE(
1869 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1870 EXPECT_EQ(kVideoRotation_0, rotation);
1871}
1872
minyue3a407ee2017-04-03 01:10:33 -07001873TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenNonZero) {
danilchapc1600c52016-10-26 03:33:11 -07001874 uint8_t kFrame[kMaxPacketLength];
1875 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1876 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1877
philipel1a4746a2018-07-09 15:52:29 +02001878 RTPVideoHeader hdr;
danilchapc1600c52016-10-26 03:33:11 -07001879 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001880 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001881 kVideoCodecGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001882 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001883
spranga8ae6f22017-09-04 07:23:56 -07001884 EXPECT_TRUE(rtp_sender_video_->SendVideo(
Niels Möller520ca4e2018-06-04 11:14:38 +02001885 kVideoCodecGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001886 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001887
1888 VideoRotation rotation;
1889 EXPECT_TRUE(
1890 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1891 EXPECT_EQ(kVideoRotation_90, rotation);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001892}
magjed71eb61c2016-09-08 03:24:58 -07001893
1894// Make sure rotation is parsed correctly when the Camera (C) and Flip (F) bits
1895// are set in the CVO byte.
minyue3a407ee2017-04-03 01:10:33 -07001896TEST_P(RtpSenderVideoTest, SendVideoWithCameraAndFlipCVO) {
magjed71eb61c2016-09-08 03:24:58 -07001897 // Test extracting rotation when Camera (C) and Flip (F) bits are zero.
1898 EXPECT_EQ(kVideoRotation_0, ConvertCVOByteToVideoRotation(0));
1899 EXPECT_EQ(kVideoRotation_90, ConvertCVOByteToVideoRotation(1));
1900 EXPECT_EQ(kVideoRotation_180, ConvertCVOByteToVideoRotation(2));
1901 EXPECT_EQ(kVideoRotation_270, ConvertCVOByteToVideoRotation(3));
1902 // Test extracting rotation when Camera (C) and Flip (F) bits are set.
1903 const int flip_bit = 1 << 2;
1904 const int camera_bit = 1 << 3;
1905 EXPECT_EQ(kVideoRotation_0,
1906 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 0));
1907 EXPECT_EQ(kVideoRotation_90,
1908 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 1));
1909 EXPECT_EQ(kVideoRotation_180,
1910 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 2));
1911 EXPECT_EQ(kVideoRotation_270,
1912 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 3));
1913}
1914
spranga8ae6f22017-09-04 07:23:56 -07001915TEST_P(RtpSenderVideoTest, RetransmissionTypesGeneric) {
1916 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001917 header.codec = kVideoCodecGeneric;
spranga8ae6f22017-09-04 07:23:56 -07001918
1919 EXPECT_EQ(kDontRetransmit,
1920 rtp_sender_video_->GetStorageType(
1921 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1922 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1923 header, kRetransmitBaseLayer,
1924 kDefaultExpectedRetransmissionTimeMs));
1925 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1926 header, kRetransmitHigherLayers,
1927 kDefaultExpectedRetransmissionTimeMs));
1928 EXPECT_EQ(kAllowRetransmission,
1929 rtp_sender_video_->GetStorageType(
1930 header, kConditionallyRetransmitHigherLayers,
1931 kDefaultExpectedRetransmissionTimeMs));
1932 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1933 header, kRetransmitAllPackets,
1934 kDefaultExpectedRetransmissionTimeMs));
1935}
1936
1937TEST_P(RtpSenderVideoTest, RetransmissionTypesH264) {
1938 RTPVideoHeader header;
philipel7d745e52018-08-02 14:03:53 +02001939 header.video_type_header.emplace<RTPVideoHeaderH264>().packetization_mode =
1940 H264PacketizationMode::NonInterleaved;
Niels Möller520ca4e2018-06-04 11:14:38 +02001941 header.codec = kVideoCodecH264;
spranga8ae6f22017-09-04 07:23:56 -07001942
1943 EXPECT_EQ(kDontRetransmit,
1944 rtp_sender_video_->GetStorageType(
1945 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1946 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1947 header, kRetransmitBaseLayer,
1948 kDefaultExpectedRetransmissionTimeMs));
1949 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1950 header, kRetransmitHigherLayers,
1951 kDefaultExpectedRetransmissionTimeMs));
1952 EXPECT_EQ(kAllowRetransmission,
1953 rtp_sender_video_->GetStorageType(
1954 header, kConditionallyRetransmitHigherLayers,
1955 kDefaultExpectedRetransmissionTimeMs));
1956 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1957 header, kRetransmitAllPackets,
1958 kDefaultExpectedRetransmissionTimeMs));
1959}
1960
1961TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8BaseLayer) {
1962 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001963 header.codec = kVideoCodecVP8;
Philip Eliassond52a1a62018-09-07 13:03:55 +00001964 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
1965 vp8_header.temporalIdx = 0;
spranga8ae6f22017-09-04 07:23:56 -07001966
1967 EXPECT_EQ(kDontRetransmit,
1968 rtp_sender_video_->GetStorageType(
1969 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1970 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1971 header, kRetransmitBaseLayer,
1972 kDefaultExpectedRetransmissionTimeMs));
1973 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1974 header, kRetransmitHigherLayers,
1975 kDefaultExpectedRetransmissionTimeMs));
1976 EXPECT_EQ(kAllowRetransmission,
1977 rtp_sender_video_->GetStorageType(
1978 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1979 kDefaultExpectedRetransmissionTimeMs));
1980 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1981 header, kConditionallyRetransmitHigherLayers,
1982 kDefaultExpectedRetransmissionTimeMs));
1983 EXPECT_EQ(
1984 kAllowRetransmission,
1985 rtp_sender_video_->GetStorageType(
1986 header, kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers,
1987 kDefaultExpectedRetransmissionTimeMs));
1988 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1989 header, kRetransmitAllPackets,
1990 kDefaultExpectedRetransmissionTimeMs));
1991}
1992
1993TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8HigherLayers) {
1994 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02001995 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07001996
Philip Eliassond52a1a62018-09-07 13:03:55 +00001997 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
spranga8ae6f22017-09-04 07:23:56 -07001998 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
Philip Eliassond52a1a62018-09-07 13:03:55 +00001999 vp8_header.temporalIdx = tid;
spranga8ae6f22017-09-04 07:23:56 -07002000
2001 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
2002 header, kRetransmitOff,
2003 kDefaultExpectedRetransmissionTimeMs));
2004 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
2005 header, kRetransmitBaseLayer,
2006 kDefaultExpectedRetransmissionTimeMs));
2007 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2008 header, kRetransmitHigherLayers,
2009 kDefaultExpectedRetransmissionTimeMs));
2010 EXPECT_EQ(kAllowRetransmission,
2011 rtp_sender_video_->GetStorageType(
2012 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
2013 kDefaultExpectedRetransmissionTimeMs));
2014 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2015 header, kRetransmitAllPackets,
2016 kDefaultExpectedRetransmissionTimeMs));
2017 }
2018}
2019
2020TEST_P(RtpSenderVideoTest, RetransmissionTypesVP9) {
2021 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02002022 header.codec = kVideoCodecVP9;
spranga8ae6f22017-09-04 07:23:56 -07002023
philipel29d88462018-08-08 14:26:00 +02002024 auto& vp9_header = header.video_type_header.emplace<RTPVideoHeaderVP9>();
spranga8ae6f22017-09-04 07:23:56 -07002025 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
philipel29d88462018-08-08 14:26:00 +02002026 vp9_header.temporal_idx = tid;
spranga8ae6f22017-09-04 07:23:56 -07002027
2028 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
2029 header, kRetransmitOff,
2030 kDefaultExpectedRetransmissionTimeMs));
2031 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
2032 header, kRetransmitBaseLayer,
2033 kDefaultExpectedRetransmissionTimeMs));
2034 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2035 header, kRetransmitHigherLayers,
2036 kDefaultExpectedRetransmissionTimeMs));
2037 EXPECT_EQ(kAllowRetransmission,
2038 rtp_sender_video_->GetStorageType(
2039 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
2040 kDefaultExpectedRetransmissionTimeMs));
2041 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
2042 header, kRetransmitAllPackets,
2043 kDefaultExpectedRetransmissionTimeMs));
2044 }
2045}
2046
2047TEST_P(RtpSenderVideoTest, ConditionalRetransmit) {
2048 const int64_t kFrameIntervalMs = 33;
2049 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
2050 const uint8_t kSettings =
2051 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
2052
2053 // Insert VP8 frames for all temporal layers, but stop before the final index.
2054 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02002055 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07002056
2057 // Fill averaging window to prevent rounding errors.
2058 constexpr int kNumRepetitions =
2059 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
2060 kFrameIntervalMs;
2061 constexpr int kPattern[] = {0, 2, 1, 2};
Philip Eliassond52a1a62018-09-07 13:03:55 +00002062 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
spranga8ae6f22017-09-04 07:23:56 -07002063 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
Philip Eliassond52a1a62018-09-07 13:03:55 +00002064 vp8_header.temporalIdx = kPattern[i % arraysize(kPattern)];
spranga8ae6f22017-09-04 07:23:56 -07002065 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
2066 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2067 }
2068
2069 // Since we're at the start of the pattern, the next expected frame in TL0 is
2070 // right now. We will wait at most one expected retransmission time before
2071 // acknowledging that it did not arrive, which means this frame and the next
2072 // will not be retransmitted.
Philip Eliassond52a1a62018-09-07 13:03:55 +00002073 vp8_header.temporalIdx = 1;
spranga8ae6f22017-09-04 07:23:56 -07002074 EXPECT_EQ(StorageType::kDontRetransmit,
2075 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2076 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2077 EXPECT_EQ(StorageType::kDontRetransmit,
2078 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2079 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2080
2081 // The TL0 frame did not arrive. So allow retransmission.
2082 EXPECT_EQ(StorageType::kAllowRetransmission,
2083 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2084 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2085
2086 // Insert a frame for TL2. We just had frame in TL1, so the next one there is
2087 // in three frames away. TL0 is still too far in the past. So, allow
2088 // retransmission.
Philip Eliassond52a1a62018-09-07 13:03:55 +00002089 vp8_header.temporalIdx = 2;
spranga8ae6f22017-09-04 07:23:56 -07002090 EXPECT_EQ(StorageType::kAllowRetransmission,
2091 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2092 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2093
2094 // Another TL2, next in TL1 is two frames away. Allow again.
2095 EXPECT_EQ(StorageType::kAllowRetransmission,
2096 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2097 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2098
2099 // Yet another TL2, next in TL1 is now only one frame away, so don't store
2100 // for retransmission.
2101 EXPECT_EQ(StorageType::kDontRetransmit,
2102 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2103}
2104
2105TEST_P(RtpSenderVideoTest, ConditionalRetransmitLimit) {
2106 const int64_t kFrameIntervalMs = 200;
2107 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
2108 const int32_t kSettings =
2109 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
2110
2111 // Insert VP8 frames for all temporal layers, but stop before the final index.
2112 RTPVideoHeader header;
Niels Möller520ca4e2018-06-04 11:14:38 +02002113 header.codec = kVideoCodecVP8;
spranga8ae6f22017-09-04 07:23:56 -07002114
2115 // Fill averaging window to prevent rounding errors.
2116 constexpr int kNumRepetitions =
2117 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
2118 kFrameIntervalMs;
2119 constexpr int kPattern[] = {0, 2, 2, 2};
Philip Eliassond52a1a62018-09-07 13:03:55 +00002120 auto& vp8_header = header.video_type_header.emplace<RTPVideoHeaderVP8>();
spranga8ae6f22017-09-04 07:23:56 -07002121 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
Philip Eliassond52a1a62018-09-07 13:03:55 +00002122 vp8_header.temporalIdx = kPattern[i % arraysize(kPattern)];
spranga8ae6f22017-09-04 07:23:56 -07002123
2124 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
2125 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
2126 }
2127
2128 // Since we're at the start of the pattern, the next expected frame will be
2129 // right now in TL0. Put it in TL1 instead. Regular rules would dictate that
2130 // we don't store for retransmission because we expect a frame in a lower
2131 // layer, but that last frame in TL1 was a long time ago in absolute terms,
2132 // so allow retransmission anyway.
Philip Eliassond52a1a62018-09-07 13:03:55 +00002133 vp8_header.temporalIdx = 1;
spranga8ae6f22017-09-04 07:23:56 -07002134 EXPECT_EQ(StorageType::kAllowRetransmission,
2135 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
2136}
2137
philipelb3e42a42018-09-13 10:57:14 +02002138TEST_P(RtpSenderVideoTest, PopulateGenericFrameDescriptor) {
2139 const int64_t kFrameId = 100000;
2140 uint8_t kFrame[100];
2141 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2142 kRtpExtensionGenericFrameDescriptor, kGenericDescriptorId));
2143
2144 RTPVideoHeader hdr;
2145 RTPVideoHeader::GenericDescriptorInfo& generic = hdr.generic.emplace();
2146 generic.frame_id = kFrameId;
2147 generic.temporal_index = 3;
2148 generic.spatial_index = 2;
2149 generic.higher_spatial_layers.push_back(4);
2150 generic.dependencies.push_back(kFrameId - 1);
2151 generic.dependencies.push_back(kFrameId - 500);
2152 rtp_sender_video_->SendVideo(kVideoCodecGeneric, kVideoFrameDelta, kPayload,
2153 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
2154 &hdr, kDefaultExpectedRetransmissionTimeMs);
2155
2156 RtpGenericFrameDescriptor descriptor_wire;
2157 EXPECT_EQ(1U, transport_.sent_packets_.size());
2158 EXPECT_TRUE(
2159 transport_.last_sent_packet()
2160 .GetExtension<RtpGenericFrameDescriptorExtension>(&descriptor_wire));
2161 EXPECT_EQ(static_cast<uint16_t>(generic.frame_id), descriptor_wire.FrameId());
2162 EXPECT_EQ(generic.temporal_index, descriptor_wire.TemporalLayer());
2163 EXPECT_THAT(descriptor_wire.FrameDependenciesDiffs(), ElementsAre(1, 500));
2164 uint8_t spatial_bitmask = 0x14;
2165 EXPECT_EQ(spatial_bitmask, descriptor_wire.SpatialLayersBitmask());
2166}
2167
Danil Chapovalov84ffb352018-09-25 18:59:09 +02002168TEST_P(RtpSenderVideoTest,
2169 UsesMinimalVp8DescriptorWhenGenericFrameDescriptorExtensionIsUsed) {
2170 const int64_t kFrameId = 100000;
2171 const size_t kFrameSize = 100;
2172 uint8_t kFrame[kFrameSize];
2173 ASSERT_TRUE(rtp_sender_->RegisterRtpHeaderExtension(
2174 RtpGenericFrameDescriptorExtension::kUri, kGenericDescriptorId));
2175
2176 RTPVideoHeader hdr;
2177 hdr.codec = kVideoCodecVP8;
2178 RTPVideoHeaderVP8& vp8 = hdr.video_type_header.emplace<RTPVideoHeaderVP8>();
2179 vp8.pictureId = kFrameId % 0X7FFF;
2180 vp8.tl0PicIdx = 13;
2181 vp8.temporalIdx = 1;
2182 vp8.keyIdx = 2;
2183 RTPVideoHeader::GenericDescriptorInfo& generic = hdr.generic.emplace();
2184 generic.frame_id = kFrameId;
2185 rtp_sender_video_->SendVideo(kVideoCodecVP8, kVideoFrameDelta, kPayload,
2186 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
2187 &hdr, kDefaultExpectedRetransmissionTimeMs);
2188
2189 ASSERT_THAT(transport_.sent_packets_, SizeIs(1));
2190 // Expect only minimal 1-byte vp8 descriptor was generated.
2191 EXPECT_THAT(transport_.sent_packets_[0].payload_size(), 1 + kFrameSize);
2192}
2193
minyue3a407ee2017-04-03 01:10:33 -07002194TEST_P(RtpSenderTest, OnOverheadChanged) {
michaelt4da30442016-11-17 01:38:43 -08002195 MockOverheadObserver mock_overhead_observer;
Benjamin Wright192eeec2018-10-17 17:27:25 -07002196 rtp_sender_.reset(
2197 new RTPSender(false, &fake_clock_, &transport_, nullptr, nullptr, nullptr,
2198 nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
2199 &retransmission_rate_limiter_, &mock_overhead_observer,
2200 false, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08002201 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08002202
michaelt4da30442016-11-17 01:38:43 -08002203 // RTP overhead is 12B.
nisse284542b2017-01-10 08:58:32 -08002204 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(12)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002205 SendGenericPayload();
2206
2207 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
2208 kTransmissionTimeOffsetExtensionId);
2209
2210 // TransmissionTimeOffset extension has a size of 8B.
nisse284542b2017-01-10 08:58:32 -08002211 // 12B + 8B = 20B
2212 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(20)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002213 SendGenericPayload();
2214}
2215
minyue3a407ee2017-04-03 01:10:33 -07002216TEST_P(RtpSenderTest, DoesNotUpdateOverheadOnEqualSize) {
michaelt4da30442016-11-17 01:38:43 -08002217 MockOverheadObserver mock_overhead_observer;
Benjamin Wright192eeec2018-10-17 17:27:25 -07002218 rtp_sender_.reset(
2219 new RTPSender(false, &fake_clock_, &transport_, nullptr, nullptr, nullptr,
2220 nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
2221 &retransmission_rate_limiter_, &mock_overhead_observer,
2222 false, nullptr, false));
nisse7d59f6b2017-02-21 03:40:24 -08002223 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08002224
2225 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(_)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08002226 SendGenericPayload();
2227 SendGenericPayload();
2228}
2229
sprang168794c2017-07-06 04:38:06 -07002230TEST_P(RtpSenderTest, SendsKeepAlive) {
2231 MockTransport transport;
Benjamin Wright192eeec2018-10-17 17:27:25 -07002232 rtp_sender_.reset(new RTPSender(
2233 false, &fake_clock_, &transport, nullptr, nullptr, nullptr, nullptr,
2234 nullptr, nullptr, nullptr, &mock_rtc_event_log_, nullptr,
2235 &retransmission_rate_limiter_, nullptr, false, nullptr, false));
sprang168794c2017-07-06 04:38:06 -07002236 rtp_sender_->SetSequenceNumber(kSeqNum);
2237 rtp_sender_->SetTimestampOffset(0);
2238 rtp_sender_->SetSSRC(kSsrc);
2239
2240 const uint8_t kKeepalivePayloadType = 20;
2241 RTC_CHECK_NE(kKeepalivePayloadType, kPayload);
2242
2243 EXPECT_CALL(transport, SendRtp(_, _, _))
2244 .WillOnce(
2245 Invoke([&kKeepalivePayloadType](const uint8_t* packet, size_t len,
2246 const PacketOptions& options) {
2247 webrtc::RTPHeader rtp_header;
2248 RtpUtility::RtpHeaderParser parser(packet, len);
2249 EXPECT_TRUE(parser.Parse(&rtp_header, nullptr));
2250 EXPECT_FALSE(rtp_header.markerBit);
2251 EXPECT_EQ(0U, rtp_header.paddingLength);
2252 EXPECT_EQ(kKeepalivePayloadType, rtp_header.payloadType);
2253 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
2254 EXPECT_EQ(kSsrc, rtp_header.ssrc);
2255 EXPECT_EQ(0u, len - rtp_header.headerLength);
2256 return true;
2257 }));
2258
2259 rtp_sender_->SendKeepAlive(kKeepalivePayloadType);
2260 EXPECT_EQ(kSeqNum + 1, rtp_sender_->SequenceNumber());
2261}
2262
minyue3a407ee2017-04-03 01:10:33 -07002263INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2264 RtpSenderTest,
2265 ::testing::Bool());
2266INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2267 RtpSenderTestWithoutPacer,
2268 ::testing::Bool());
2269INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2270 RtpSenderVideoTest,
2271 ::testing::Bool());
2272INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
2273 RtpSenderAudioTest,
2274 ::testing::Bool());
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00002275} // namespace webrtc