blob: d4213ff268c7cb13a45baa04eb7be8b5a6abdff5 [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +000011#include <algorithm>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000012#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080013#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070014#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000015#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000016
Niels Möller039743e2018-10-23 10:07:25 +020017#include "absl/strings/match.h"
Seth Hampson24722b32017-12-22 09:36:42 -080018#include "api/rtpparameters.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080019#include "api/test/mock_video_bitrate_allocator.h"
20#include "api/test/mock_video_bitrate_allocator_factory.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070021#include "api/test/mock_video_decoder_factory.h"
22#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020023#include "api/units/time_delta.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080024#include "api/video/builtin_video_bitrate_allocator_factory.h"
Åsa Persson23eba222018-10-02 14:47:06 +020025#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020026#include "api/video_codecs/builtin_video_decoder_factory.h"
27#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020028#include "api/video_codecs/sdp_video_format.h"
29#include "api/video_codecs/video_decoder_factory.h"
30#include "api/video_codecs/video_encoder.h"
31#include "api/video_codecs/video_encoder_factory.h"
32#include "call/flexfec_receive_stream.h"
33#include "common_video/h264/profile_level_id.h"
34#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller6557d0c2018-04-11 15:18:34 +020035#include "media/base/fakenetworkinterface.h"
36#include "media/base/fakevideocapturer.h"
37#include "media/base/fakevideorenderer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020038#include "media/base/mediaconstants.h"
39#include "media/base/rtputils.h"
40#include "media/base/testutils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020041#include "media/engine/constants.h"
42#include "media/engine/fakewebrtccall.h"
43#include "media/engine/fakewebrtcvideoengine.h"
44#include "media/engine/simulcast.h"
45#include "media/engine/webrtcvideoengine.h"
46#include "media/engine/webrtcvoiceengine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020047#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020048#include "rtc_base/arraysize.h"
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +020049#include "rtc_base/fakeclock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020050#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020051#include "rtc_base/numerics/safe_conversions.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020052#include "rtc_base/stringutils.h"
53#include "test/field_trial.h"
54#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000055
Tommi85959932018-02-07 19:26:06 +010056using cricket::FakeVideoCapturerWithTaskQueue;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010057using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070058using webrtc::RtpExtension;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010059using testing::Field;
isheriff6f8d6862016-05-26 11:24:55 -070060
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000061namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000062static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000063
noahricd10a68e2015-07-10 11:27:55 -070064static const uint8_t kRedRtxPayloadType = 125;
65
Niels Möller6557d0c2018-04-11 15:18:34 +020066static const uint32_t kTimeout = 5000U;
67static const uint32_t kDefaultReceiveSsrc = 0;
68static const uint32_t kSsrc = 1234u;
69static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
70static const int kVideoWidth = 640;
71static const int kVideoHeight = 360;
72static const int kFramerate = 30;
73
Peter Boström0c4e06b2015-10-07 12:23:21 +020074static const uint32_t kSsrcs1[] = {1};
75static const uint32_t kSsrcs3[] = {1, 2, 3};
76static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080077static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020078static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080079static const uint32_t kDefaultRecvSsrc = 0;
80
pbos@webrtc.org3c107582014-07-20 15:27:35 +000081static const char kUnsupportedExtensionName[] =
82 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000083
magjed509e4fe2016-11-18 01:34:11 -080084cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
85 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020086 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080087}
88
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000089void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
90 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
91 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
92 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
93 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
94 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
95 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
96 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -080097 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
98 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000099 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
100}
101
magjed725e4842016-11-16 00:48:13 -0800102// Return true if any codec in |codecs| is an RTX codec with associated payload
103// type |payload_type|.
104bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
105 int payload_type) {
106 for (const cricket::VideoCodec& codec : codecs) {
107 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200108 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800109 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
110 &associated_payload_type) &&
111 associated_payload_type == payload_type) {
112 return true;
113 }
114 }
115 return false;
116}
117
nisseca5706d2017-09-11 02:32:16 -0700118// TODO(nisse): Duplicated in call.cc.
119const int* FindKeyByValue(const std::map<int, int>& m, int v) {
120 for (const auto& kv : m) {
121 if (kv.second == v)
122 return &kv.first;
123 }
124 return nullptr;
125}
126
Yves Gerey665174f2018-06-19 15:03:05 +0200127bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
128 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700129 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
130 payload_type) != nullptr;
131}
132
133// Check that there's an Rtx payload type for each decoder.
134bool VerifyRtxReceiveAssociations(
135 const webrtc::VideoReceiveStream::Config& config) {
136 for (const auto& decoder : config.decoders) {
137 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
138 return false;
139 }
140 return true;
141}
142
brandtrffc61182016-11-28 06:02:22 -0800143rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700144 int width,
145 int height) {
146 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
147 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800148 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700149 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000150}
151
Shao Changbine62202f2015-04-21 20:24:50 +0800152void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
153 const std::map<int, int>& rtx_types) {
154 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200155 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800156 EXPECT_TRUE(it != rtx_types.end() &&
157 it->second == config.rtp.rtx.payload_type);
158
brandtrb5f2c3f2016-10-04 23:28:39 -0700159 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
160 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800161 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700162 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800163 }
164}
kthelgason2bc68642017-02-07 07:02:22 -0800165
166cricket::MediaConfig GetMediaConfig() {
167 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100168 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800169 return media_config;
170}
nisse26e3abb2017-08-25 04:44:25 -0700171
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200172// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
173int GetMaxDefaultBitrateBps(size_t width, size_t height) {
174 if (width * height <= 320 * 240) {
175 return 600000;
176 } else if (width * height <= 640 * 480) {
177 return 1700000;
178 } else if (width * height <= 960 * 540) {
179 return 2000000;
180 } else {
181 return 2500000;
182 }
183}
184
Niels Möller731a2c22018-07-30 15:08:07 +0200185class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
186 public:
187 MOCK_METHOD2(AddOrUpdateSink,
188 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
189 const rtc::VideoSinkWants& wants));
190 MOCK_METHOD1(RemoveSink,
191 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
192};
193
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000194} // namespace
195
Yves Gerey665174f2018-06-19 15:03:05 +0200196#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200197 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200198 EXPECT_EQ((w), renderer_.width()); \
199 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200200 EXPECT_EQ(0, renderer_.errors());
201
Yves Gerey665174f2018-06-19 15:03:05 +0200202#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200203 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200204 EXPECT_EQ((w), (r).width()); \
205 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200206 EXPECT_EQ(0, (r).errors());
207
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000208namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700209class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000210 public:
eladalonf1841382017-06-12 01:16:46 -0700211 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
212 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700213 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700214 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200215 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
216 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +0200217 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200218 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200219 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jiawei Ouc2ebe212018-11-08 10:02:56 -0800220 decoder_factory_),
221 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()) {
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200222 // Ensure fake clock doesn't return 0, which will cause some initializations
223 // fail inside RTP senders.
224 fake_clock_.AdvanceTimeMicros(1);
225 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000226
227 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200228 void AssignDefaultAptRtxTypes();
229 void AssignDefaultCodec();
230
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100231 // Find the index of the codec in the engine with the given name. The codec
232 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100233 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100234
magjed509e4fe2016-11-18 01:34:11 -0800235 // Find the codec in the engine with the given name. The codec must be
236 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100237 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800238
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200239 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000240
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200241 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000242 const std::vector<VideoCodec>& codecs);
243
Peter Boströme4499152016-02-05 11:13:28 +0100244 void TestExtendedEncoderOveruse(bool use_external_encoder);
245
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200246 // Has to be the first one, so it is initialized before the call or there is a
247 // race condition in the clock access.
248 rtc::ScopedFakeClock fake_clock_;
stefanc1aeaf02015-10-15 07:26:07 -0700249 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700250 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700251 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000252 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800253 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200254 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
255 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -0700256 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000257 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800258 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000259};
260
eladalonf1841382017-06-12 01:16:46 -0700261TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200262 encoder_factory_->AddSupportedVideoCodecType("VP8");
263 AssignDefaultCodec();
264
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000265 std::vector<VideoCodec> engine_codecs = engine_.codecs();
266 for (size_t i = 0; i < engine_codecs.size(); ++i) {
267 if (engine_codecs[i].name != kRtxCodecName)
268 continue;
269 int associated_payload_type;
270 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000271 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000272 EXPECT_EQ(default_codec_.id, associated_payload_type);
273 return;
274 }
275 FAIL() << "No RTX codec found among default codecs.";
276}
277
eladalonf1841382017-06-12 01:16:46 -0700278TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100279 RtpCapabilities capabilities = engine_.GetCapabilities();
Johannes Krond0b69a82018-12-03 14:18:53 +0100280 EXPECT_THAT(
281 capabilities.header_extensions,
282 testing::Contains(RtpExtension(RtpExtension::kTimestampOffsetUri,
283 RtpExtension::kTimestampOffsetDefaultId)));
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000284}
285
eladalonf1841382017-06-12 01:16:46 -0700286TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100287 RtpCapabilities capabilities = engine_.GetCapabilities();
Johannes Krond0b69a82018-12-03 14:18:53 +0100288 EXPECT_THAT(
289 capabilities.header_extensions,
290 testing::Contains(RtpExtension(RtpExtension::kAbsSendTimeUri,
291 RtpExtension::kAbsSendTimeDefaultId)));
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000292}
293
eladalonf1841382017-06-12 01:16:46 -0700294TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100295 RtpCapabilities capabilities = engine_.GetCapabilities();
Johannes Krond0b69a82018-12-03 14:18:53 +0100296 EXPECT_THAT(capabilities.header_extensions,
297 testing::Contains(RtpExtension(
298 RtpExtension::kTransportSequenceNumberUri,
299 RtpExtension::kTransportSequenceNumberDefaultId)));
stefanc1aeaf02015-10-15 07:26:07 -0700300}
301
eladalonf1841382017-06-12 01:16:46 -0700302TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100303 RtpCapabilities capabilities = engine_.GetCapabilities();
Johannes Krond0b69a82018-12-03 14:18:53 +0100304 EXPECT_THAT(
305 capabilities.header_extensions,
306 testing::Contains(RtpExtension(RtpExtension::kVideoRotationUri,
307 RtpExtension::kVideoRotationDefaultId)));
308}
309
310TEST_F(WebRtcVideoEngineTest, SupportsColorSpaceHeaderExtension) {
311 RtpCapabilities capabilities = engine_.GetCapabilities();
312 EXPECT_THAT(
313 capabilities.header_extensions,
314 testing::Contains(RtpExtension(RtpExtension::kColorSpaceUri,
315 RtpExtension::kColorSpaceDefaultId)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700316}
317
philipel1e054862018-10-08 16:13:53 +0200318class WebRtcVideoEngineTestWithGenericDescriptor
319 : public WebRtcVideoEngineTest {
320 public:
321 WebRtcVideoEngineTestWithGenericDescriptor()
322 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
323};
324
325TEST_F(WebRtcVideoEngineTestWithGenericDescriptor, AdvertiseGenericDescriptor) {
326 RtpCapabilities capabilities = engine_.GetCapabilities();
327 ASSERT_FALSE(capabilities.header_extensions.empty());
328 for (const RtpExtension& extension : capabilities.header_extensions) {
329 if (extension.uri == RtpExtension::kGenericFrameDescriptorUri) {
330 EXPECT_EQ(RtpExtension::kGenericFrameDescriptorDefaultId, extension.id);
331 return;
332 }
333 }
334 FAIL() << "Generic descriptor extension not in header-extension list.";
335}
336
eladalonf1841382017-06-12 01:16:46 -0700337TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200338 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700339 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200340 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700341
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200342 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700343
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200344 std::unique_ptr<VideoMediaChannel> channel(
345 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700346 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
347
348 // Add CVO extension.
349 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800350 cricket::VideoSendParameters parameters;
351 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200352 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700353 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200354 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700355
Niels Möller731a2c22018-07-30 15:08:07 +0200356 EXPECT_CALL(
357 video_source,
358 AddOrUpdateSink(testing::_,
359 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700360 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200361 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700362
363 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200364 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700365
366 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200367 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200368 EXPECT_CALL(
369 video_source,
370 AddOrUpdateSink(testing::_,
371 Field(&rtc::VideoSinkWants::rotation_applied, true)));
372
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200373 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700374}
375
eladalonf1841382017-06-12 01:16:46 -0700376TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200377 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800378 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200379 testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800380
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200381 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800382
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200383 std::unique_ptr<VideoMediaChannel> channel(
384 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800385 // Add CVO extension.
386 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800387 cricket::VideoSendParameters parameters;
388 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800389 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700390 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800391 EXPECT_TRUE(channel->SetSendParameters(parameters));
392 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
393
Niels Möller731a2c22018-07-30 15:08:07 +0200394 // Set source.
395 EXPECT_CALL(
396 video_source,
397 AddOrUpdateSink(testing::_,
398 Field(&rtc::VideoSinkWants::rotation_applied, false)));
399 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800400}
401
eladalonf1841382017-06-12 01:16:46 -0700402TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200403 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700404
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200405 encoder_factory_->AddSupportedVideoCodecType("VP8");
406 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700407
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200408 std::unique_ptr<VideoMediaChannel> channel(
409 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700410 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
411
412 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200413 EXPECT_CALL(
414 video_source,
415 AddOrUpdateSink(testing::_,
416 Field(&rtc::VideoSinkWants::rotation_applied, true)));
417 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700418
perkjcaafdba2016-03-20 07:34:29 -0700419 // Verify capturer has turned on applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200420 testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700421
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700422 // Add CVO extension.
423 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800424 cricket::VideoSendParameters parameters;
425 parameters.codecs.push_back(GetEngineCodec("VP8"));
426 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200427 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700428 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700429 // Also remove the first codec to trigger a codec change as well.
430 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200431 EXPECT_CALL(
432 video_source,
433 AddOrUpdateSink(testing::_,
434 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200435 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700436
437 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200438 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700439
440 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200441 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200442 EXPECT_CALL(
443 video_source,
444 AddOrUpdateSink(testing::_,
445 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200446 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700447}
448
eladalonf1841382017-06-12 01:16:46 -0700449TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200450 encoder_factory_->AddSupportedVideoCodecType("VP8");
451
Sebastian Jansson84848f22018-11-16 10:40:36 +0100452 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700453 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000454
455 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
456
457 EXPECT_FALSE(channel->SetSend(true))
458 << "Channel should not start without codecs.";
459 EXPECT_TRUE(channel->SetSend(false))
460 << "Channel should be stoppable even without set codecs.";
461}
462
eladalonf1841382017-06-12 01:16:46 -0700463TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200464 encoder_factory_->AddSupportedVideoCodecType("VP8");
465
Sebastian Jansson84848f22018-11-16 10:40:36 +0100466 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700467 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000468 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
469 VideoMediaInfo info;
470 channel->GetStats(&info);
471}
472
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200473TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200474 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000475
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200476 std::unique_ptr<VideoMediaChannel> channel(
477 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800478 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000479
480 EXPECT_TRUE(
481 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200482 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000483 EXPECT_TRUE(channel->SetSend(true));
Tommi85959932018-02-07 19:26:06 +0100484 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200485 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000486 EXPECT_EQ(cricket::CS_RUNNING,
487 capturer.Start(capturer.GetSupportedFormats()->front()));
488 EXPECT_TRUE(capturer.CaptureFrame());
Per21d45d22016-10-30 21:37:57 +0100489 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200490 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
491 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000492 kTimeout);
493
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200494 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100495 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000496
497 // Setting codecs of the same type should not reallocate any encoders
498 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800499 cricket::VideoSendParameters parameters;
500 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200501 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200502 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000503
504 // Remove stream previously added to free the external encoder instance.
505 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200506 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000507}
508
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200509// Test that when an encoder factory supports H264, we add an RTX
510// codec for it.
511// TODO(deadbeef): This test should be updated if/when we start
512// adding RTX codecs for unrecognized codec names.
513TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800514 using webrtc::H264::ProfileLevelIdToString;
515 using webrtc::H264::ProfileLevelId;
516 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200517 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
518 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800519 *ProfileLevelIdToString(
520 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200521 webrtc::SdpVideoFormat h264_constrained_high("H264");
522 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800523 *ProfileLevelIdToString(
524 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200525 webrtc::SdpVideoFormat h264_high("H264");
526 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800527 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
528
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200529 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
530 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
531 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700532
magjed725e4842016-11-16 00:48:13 -0800533 // First figure out what payload types the test codecs got assigned.
534 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800535 // Now search for RTX codecs for them. Expect that they all have associated
536 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800537 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200538 codecs,
539 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
540 ->id));
magjed725e4842016-11-16 00:48:13 -0800541 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200542 codecs,
543 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
544 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800545 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200546 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700547}
548
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100549#if defined(RTC_ENABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700550TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200551 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100552
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200553 std::unique_ptr<VideoMediaChannel> channel(
554 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100555
556 EXPECT_TRUE(
557 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
558}
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100559#endif // defined(RTC_ENABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100560
eladalonf1841382017-06-12 01:16:46 -0700561TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200562 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100563 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200564 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200565 std::unique_ptr<VideoMediaChannel> channel(
566 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700567
568 EXPECT_TRUE(
569 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
570
Tommi85959932018-02-07 19:26:06 +0100571 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200572 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
qiangchenc27d89f2015-07-16 10:27:16 -0700573 capturer.Start(cricket::VideoFormat(1280, 720,
574 cricket::VideoFormat::FpsToInterval(60),
575 cricket::FOURCC_I420));
576 channel->SetSend(true);
577
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200578 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700579
580 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700581 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700582 for (int i = 0; i < 10; i++) {
583 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700584 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700585 int64_t interval = timestamp - last_timestamp;
586
587 // Precision changes from nanosecond to millisecond.
588 // Allow error to be no more than 1.
589 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
590
591 last_timestamp = timestamp;
592 }
593
594 capturer.Start(cricket::VideoFormat(1280, 720,
595 cricket::VideoFormat::FpsToInterval(30),
596 cricket::FOURCC_I420));
597
598 EXPECT_TRUE(capturer.CaptureFrame());
599 last_timestamp = stream->GetLastTimestamp();
600 for (int i = 0; i < 10; i++) {
601 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700602 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700603 int64_t interval = timestamp - last_timestamp;
604
605 // Precision changes from nanosecond to millisecond.
606 // Allow error to be no more than 1.
607 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
608
609 last_timestamp = timestamp;
610 }
611
612 // Remove stream previously added to free the external encoder instance.
613 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
614}
615
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200616void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
617 std::vector<VideoCodec> engine_codecs = engine_.codecs();
618 RTC_DCHECK(!engine_codecs.empty());
619 for (const cricket::VideoCodec& codec : engine_codecs) {
620 if (codec.name == "rtx") {
621 int associated_payload_type;
622 if (codec.GetParam(kCodecParamAssociatedPayloadType,
623 &associated_payload_type)) {
624 default_apt_rtx_types_[associated_payload_type] = codec.id;
625 }
626 }
627 }
628}
629
630void WebRtcVideoEngineTest::AssignDefaultCodec() {
631 std::vector<VideoCodec> engine_codecs = engine_.codecs();
632 RTC_DCHECK(!engine_codecs.empty());
633 bool codec_set = false;
634 for (const cricket::VideoCodec& codec : engine_codecs) {
635 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
636 codec.name != "ulpfec") {
637 default_codec_ = codec;
638 codec_set = true;
639 }
640 }
641
642 RTC_DCHECK(codec_set);
643}
644
Oleh Prypina40f8242017-12-21 13:32:23 +0100645size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
646 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100647 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
648 for (size_t i = 0; i < codecs.size(); ++i) {
649 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200650 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200651 continue;
652 // The tests only use H264 Constrained Baseline. Make sure we don't return
653 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200654 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200655 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200656 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
657 if (profile_level_id->profile !=
658 webrtc::H264::kProfileConstrainedBaseline) {
659 continue;
660 }
661 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100662 return i;
magjed509e4fe2016-11-18 01:34:11 -0800663 }
664 // This point should never be reached.
665 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100666 return -1;
667}
668
669cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
670 const std::string& name) const {
671 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800672}
673
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200674VideoMediaChannel*
675WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100676 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700677 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200678 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800679 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200680 for (const webrtc::SdpVideoFormat& format :
681 encoder_factory_->GetSupportedFormats()) {
682 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
683 if (std::find(parameters.codecs.begin(), parameters.codecs.end(),
684 engine_codec) == parameters.codecs.end()) {
685 parameters.codecs.push_back(engine_codec);
686 }
687 }
magjed509e4fe2016-11-18 01:34:11 -0800688
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200689 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000690
691 return channel;
692}
693
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200694VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000695 const std::vector<VideoCodec>& codecs) {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100696 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700697 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200698 cricket::VideoRecvParameters parameters;
699 parameters.codecs = codecs;
700 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000701
702 return channel;
703}
704
eladalonf1841382017-06-12 01:16:46 -0700705TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200706 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000707
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200708 std::unique_ptr<VideoMediaChannel> channel(
709 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000710
Peter Boström0c4e06b2015-10-07 12:23:21 +0200711 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000712
Yves Gerey665174f2018-06-19 15:03:05 +0200713 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000714 EXPECT_TRUE(channel->SetSend(true));
715
Tommi85959932018-02-07 19:26:06 +0100716 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200717 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000718 EXPECT_EQ(cricket::CS_RUNNING,
719 capturer.Start(capturer.GetSupportedFormats()->front()));
720 EXPECT_TRUE(capturer.CaptureFrame());
721
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200722 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000723
724 // Verify that encoders are configured for simulcast through adapter
725 // (increasing resolution and only configured to send one stream each).
726 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200727 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
728 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000729 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200730 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000731 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
732 EXPECT_GT(codec_settings.width, prev_width);
733 prev_width = codec_settings.width;
734 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000735
Niels Möllerff40b142018-04-09 08:49:14 +0200736 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000737
738 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200739 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000740}
741
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200742TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
743 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200744 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000745
Niels Möller4db138e2018-04-19 09:04:13 +0200746 // Set capturer.
747 FakeVideoCapturerWithTaskQueue capturer;
748 EXPECT_EQ(cricket::CS_RUNNING,
749 capturer.Start(capturer.GetSupportedFormats()->front()));
750
Sebastian Jansson84848f22018-11-16 10:40:36 +0100751 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700752 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200753 cricket::VideoSendParameters parameters;
754 parameters.codecs.push_back(GetEngineCodec("H264"));
755 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000756
757 EXPECT_TRUE(
758 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller4db138e2018-04-19 09:04:13 +0200759 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
760 // Sending one frame will have allocate the encoder.
761 EXPECT_TRUE(capturer.CaptureFrame());
762
763 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000764
Anders Carlsson67537952018-05-03 11:28:29 +0200765 cricket::VideoSendParameters new_parameters;
766 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
767 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200768
769 // Sending one frame will switch encoder.
770 EXPECT_TRUE(capturer.CaptureFrame());
771
Anders Carlsson8a150d92018-05-14 12:40:04 +0200772 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000773}
774
eladalonf1841382017-06-12 01:16:46 -0700775TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000776 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200777 encoder_factory_->AddSupportedVideoCodecType("VP8");
778 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000779
Sebastian Jansson84848f22018-11-16 10:40:36 +0100780 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700781 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800782 cricket::VideoSendParameters parameters;
783 parameters.codecs.push_back(GetEngineCodec("VP8"));
784 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000785
Peter Boström0c4e06b2015-10-07 12:23:21 +0200786 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000787
Yves Gerey665174f2018-06-19 15:03:05 +0200788 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000789 EXPECT_TRUE(channel->SetSend(true));
790
791 // Send a fake frame, or else the media engine will configure the simulcast
792 // encoder adapter at a low-enough size that it'll only create a single
793 // encoder layer.
Tommi85959932018-02-07 19:26:06 +0100794 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200795 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000796 EXPECT_EQ(cricket::CS_RUNNING,
797 capturer.Start(capturer.GetSupportedFormats()->front()));
798 EXPECT_TRUE(capturer.CaptureFrame());
799
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200800 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
801 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000802 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200803 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000804
805 channel.reset();
806 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200807 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000808}
809
eladalonf1841382017-06-12 01:16:46 -0700810TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000811 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200812 encoder_factory_->AddSupportedVideoCodecType("VP8");
813 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000814
Sebastian Jansson84848f22018-11-16 10:40:36 +0100815 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700816 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800817 cricket::VideoSendParameters parameters;
818 parameters.codecs.push_back(GetEngineCodec("H264"));
819 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000820
821 EXPECT_TRUE(
822 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100823
824 // Send a frame of 720p. This should trigger a "real" encoder initialization.
825 cricket::VideoFormat format(
826 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100827 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200828 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Per21d45d22016-10-30 21:37:57 +0100829 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
830 EXPECT_TRUE(capturer.CaptureFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200831 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
832 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200833 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000834 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200835 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000836
837 channel.reset();
838 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200839 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000840}
841
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200842TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
843 webrtc::test::ScopedFieldTrials override_field_trials_(
844 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200845 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700846
Sebastian Jansson84848f22018-11-16 10:40:36 +0100847 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700848 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200849 cricket::VideoSendParameters parameters;
850 parameters.codecs.push_back(GetEngineCodec("H264"));
851 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700852
Peter Boström0c4e06b2015-10-07 12:23:21 +0200853 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700854 EXPECT_TRUE(
855 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100856
857 // Send a frame of 720p. This should trigger a "real" encoder initialization.
noahricfdac5162015-08-27 01:59:29 -0700858 cricket::VideoFormat format(
859 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100860 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200861 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &capturer));
Peter Boströmce23bee2016-02-02 14:14:30 +0100862 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
863 EXPECT_TRUE(capturer.CaptureFrame());
864
Niels Möller4db138e2018-04-19 09:04:13 +0200865 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200866 ASSERT_EQ(1u, encoder_factory_->encoders().size());
867 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
868 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700869 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200870 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200871 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700872}
873
brandtrffc61182016-11-28 06:02:22 -0800874// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700875// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800876//
877// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700878TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800879 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200880 encoder_factory_->AddSupportedVideoCodecType("VP8");
881
brandtrffc61182016-11-28 06:02:22 -0800882 auto is_flexfec = [](const VideoCodec& codec) {
883 if (codec.name == "flexfec-03")
884 return true;
885 return false;
886 };
887
888 // FlexFEC is not active without field trial.
brandtrffc61182016-11-28 06:02:22 -0800889 const std::vector<VideoCodec> codecs_before = engine_.codecs();
890 EXPECT_EQ(codecs_before.end(), std::find_if(codecs_before.begin(),
891 codecs_before.end(), is_flexfec));
892
893 // FlexFEC is active with field trial.
894 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800895 "WebRTC-FlexFEC-03-Advertised/Enabled/");
brandtrffc61182016-11-28 06:02:22 -0800896 const std::vector<VideoCodec> codecs_after = engine_.codecs();
897 EXPECT_NE(codecs_after.end(),
898 std::find_if(codecs_after.begin(), codecs_after.end(), is_flexfec));
899}
900
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200901// Test that codecs are added in the order they are reported from the factory.
902TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
903 encoder_factory_->AddSupportedVideoCodecType("VP8");
904 const char* kFakeCodecName = "FakeCodec";
905 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000906
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200907 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100908 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200909 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
910 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000911}
912
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200913// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800914// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200915TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100916 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
917 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100918
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100919 // Set up external encoder factory with first codec, and initialize engine.
920 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
921
brandtrffc61182016-11-28 06:02:22 -0800922 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800923
924 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100925 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800926 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200927 // The codec itself and RTX should have been added.
928 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100929
930 // Check that both fake codecs are present and that the second fake codec
931 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100932 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
933 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100934 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800935}
936
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200937TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
938 const char* kFakeCodecName = "FakeCodec";
939 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
940
941 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
942 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
943}
944
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200945TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
946 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200947 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200948 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800949 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000950
kwiberg686a8ef2016-02-26 03:00:35 -0800951 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200952 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000953
954 EXPECT_TRUE(
955 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200956 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000957
958 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200959 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200960 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000961
962 // Remove stream previously added to free the external decoder instance.
963 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200964 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000965}
966
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200967// Verifies that we can set up decoders.
968TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000969 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
970 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
971 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
972 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200973 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +0200974 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000975 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800976 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000977
kwiberg686a8ef2016-02-26 03:00:35 -0800978 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200979 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000980
981 EXPECT_TRUE(
982 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200983 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000984}
985
Jonas Oreland49ac5952018-09-26 16:04:32 +0200986// Tests when GetSources is called with non-existing ssrc, it will return an
987// empty list of RtpSource without crashing.
988TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
989 // Setup an recv stream with |kSsrc|.
990 encoder_factory_->AddSupportedVideoCodecType("VP8");
991 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
992 cricket::VideoRecvParameters parameters;
993 parameters.codecs.push_back(GetEngineCodec("VP8"));
994 std::unique_ptr<VideoMediaChannel> channel(
995 SetRecvParamsWithSupportedCodecs(parameters.codecs));
996
997 EXPECT_TRUE(
998 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
999
1000 // Call GetSources with |kSsrc + 1| which doesn't exist.
1001 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1002 EXPECT_EQ(0u, sources.size());
1003}
1004
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001005TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1006 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1007 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001008 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory> rate_allocator_factory;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001009 WebRtcVideoEngine engine(std::move(encoder_factory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001010 std::move(decoder_factory),
1011 std::move(rate_allocator_factory));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001012 EXPECT_EQ(0u, engine.codecs().size());
1013}
1014
1015TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1016 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001017 webrtc::MockVideoEncoderFactory* encoder_factory =
1018 new webrtc::MockVideoEncoderFactory();
1019 webrtc::MockVideoDecoderFactory* decoder_factory =
1020 new webrtc::MockVideoDecoderFactory();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001021 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1022 new webrtc::MockVideoBitrateAllocatorFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001023 WebRtcVideoEngine engine(
1024 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001025 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1026 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1027 rate_allocator_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001028 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1029 EXPECT_EQ(0u, engine.codecs().size());
1030 EXPECT_CALL(*encoder_factory, Die());
1031 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001032 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001033}
1034
1035// Test full behavior in the video engine when video codec factories of the new
1036// type are injected supporting the single codec Vp8. Check the returned codecs
1037// from the engine and that we will create a Vp8 encoder and decoder using the
1038// new factories.
1039TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1040 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001041 webrtc::MockVideoEncoderFactory* encoder_factory =
1042 new webrtc::MockVideoEncoderFactory();
1043 webrtc::MockVideoDecoderFactory* decoder_factory =
1044 new webrtc::MockVideoDecoderFactory();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001045 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1046 new webrtc::MockVideoBitrateAllocatorFactory();
1047 EXPECT_CALL(*rate_allocator_factory,
1048 CreateVideoBitrateAllocatorProxy(Field(
1049 &webrtc::VideoCodec::codecType, webrtc::kVideoCodecVP8)))
1050 .WillOnce(testing::Return(new webrtc::MockVideoBitrateAllocator()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001051 WebRtcVideoEngine engine(
1052 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001053 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1054 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1055 rate_allocator_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001056 const webrtc::SdpVideoFormat vp8_format("VP8");
1057 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1058 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1059 .WillRepeatedly(testing::Return(supported_formats));
1060
1061 // Verify the codecs from the engine.
1062 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001063 // Verify default codecs has been added correctly.
1064 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001065 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001066
1067 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001068 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001069 int vp8_associated_payload;
1070 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1071 &vp8_associated_payload));
1072 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1073
1074 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1075
1076 // RTX codec for RED.
1077 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1078 int red_associated_payload;
1079 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1080 &red_associated_payload));
1081 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1082
1083 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1084
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001085 int associated_payload_type;
1086 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1087 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1088 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1089 // Verify default parameters has been added to the VP8 codec.
1090 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
1091
1092 // Mock encoder creation. |engine| take ownership of the encoder.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001093 const webrtc::SdpVideoFormat format("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +02001094 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möllerc572ff32018-11-07 08:43:50 +01001095 rtc::Event encoder_created;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001096 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001097 .WillOnce(
1098 ::testing::DoAll(::testing::InvokeWithoutArgs(
1099 [&encoder_created]() { encoder_created.Set(); }),
1100 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001101
1102 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001103 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001104 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
1105 .WillOnce(testing::Return(decoder));
1106
1107 // Create a call.
1108 webrtc::RtcEventLogNullImpl event_log;
1109 std::unique_ptr<webrtc::Call> call(
1110 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1111
1112 // Create send channel.
1113 const int send_ssrc = 123;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001114 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001115 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001116 cricket::VideoSendParameters send_parameters;
1117 send_parameters.codecs.push_back(engine_codecs.at(0));
1118 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1119 send_channel->OnReadyToSend(true);
1120 EXPECT_TRUE(
1121 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1122 EXPECT_TRUE(send_channel->SetSend(true));
1123
Niels Möller4db138e2018-04-19 09:04:13 +02001124 // Set capturer.
1125 FakeVideoCapturerWithTaskQueue capturer;
1126 EXPECT_EQ(cricket::CS_RUNNING,
1127 capturer.Start(capturer.GetSupportedFormats()->front()));
1128 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &capturer));
1129 // Sending one frame will allocate the encoder.
1130 EXPECT_TRUE(capturer.CaptureFrame());
1131 encoder_created.Wait(kTimeout);
1132
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001133 // Create recv channel.
1134 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001135 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001136 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001137 cricket::VideoRecvParameters recv_parameters;
1138 recv_parameters.codecs.push_back(engine_codecs.at(0));
1139 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1140 EXPECT_TRUE(recv_channel->AddRecvStream(
1141 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1142
1143 // Remove streams previously added to free the encoder and decoder instance.
1144 EXPECT_CALL(*encoder_factory, Die());
1145 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001146 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001147 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1148 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1149}
1150
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001151// Test behavior when decoder factory fails to create a decoder (returns null).
1152TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1153 // |engine| take ownership of the factories.
1154 webrtc::MockVideoEncoderFactory* encoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001155 new webrtc::MockVideoEncoderFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001156 webrtc::MockVideoDecoderFactory* decoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001157 new webrtc::MockVideoDecoderFactory();
1158 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1159 new webrtc::MockVideoBitrateAllocatorFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001160 WebRtcVideoEngine engine(
1161 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001162 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1163 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1164 rate_allocator_factory)));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001165 const webrtc::SdpVideoFormat vp8_format("VP8");
1166 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1167 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1168 .WillRepeatedly(testing::Return(supported_formats));
1169
1170 // Decoder creation fails.
1171 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(testing::_))
1172 .WillOnce(testing::Return(nullptr));
1173
1174 // Create a call.
1175 webrtc::RtcEventLogNullImpl event_log;
1176 std::unique_ptr<webrtc::Call> call(
1177 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1178
1179 // Create recv channel.
1180 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001181 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001182 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001183 cricket::VideoRecvParameters recv_parameters;
1184 recv_parameters.codecs.push_back(engine.codecs().front());
1185 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1186 EXPECT_TRUE(recv_channel->AddRecvStream(
1187 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1188
1189 // Remove streams previously added to free the encoder and decoder instance.
1190 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1191}
1192
eladalonf1841382017-06-12 01:16:46 -07001193TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001194 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001195 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001196 std::unique_ptr<VideoMediaChannel> channel(
1197 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001198 ASSERT_TRUE(
1199 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1200 cricket::VideoCodec codec = GetEngineCodec("VP8");
1201 cricket::VideoSendParameters parameters;
1202 parameters.codecs.push_back(codec);
1203 channel->OnReadyToSend(true);
1204 channel->SetSend(true);
1205 ASSERT_TRUE(channel->SetSendParameters(parameters));
1206
Tommi85959932018-02-07 19:26:06 +01001207 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08001208 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02001209 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001210
1211 EXPECT_EQ(cricket::CS_RUNNING,
1212 capturer.Start(capturer.GetSupportedFormats()->front()));
1213 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001214 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001215 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001216 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001217
Niels Möllerff40b142018-04-09 08:49:14 +02001218 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001219 EXPECT_TRUE(capturer.CaptureFrame());
1220 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001221 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001222
1223 options.is_screencast.emplace(true);
Niels Möllerff40b142018-04-09 08:49:14 +02001224 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001225 EXPECT_TRUE(capturer.CaptureFrame());
1226 // Change to screen content, recreate encoder. For the simulcast encoder
1227 // adapter case, this will result in two calls since InitEncode triggers a
1228 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001229 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001230 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001231 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001232
Niels Möllerff40b142018-04-09 08:49:14 +02001233 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001234 EXPECT_TRUE(capturer.CaptureFrame());
1235 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001236 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001237
1238 options.is_screencast.emplace(false);
1239 options.video_noise_reduction.emplace(false);
Niels Möllerff40b142018-04-09 08:49:14 +02001240 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001241 // Change back to regular video content, update encoder. Also change
1242 // a non |is_screencast| option just to verify it doesn't affect recreation.
1243 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001244 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001245 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001246 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001247
1248 // Remove stream previously added to free the external encoder instance.
1249 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001250 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001251}
1252
Niels Möller6557d0c2018-04-11 15:18:34 +02001253class WebRtcVideoChannelBaseTest : public testing::Test {
1254 protected:
1255 WebRtcVideoChannelBaseTest()
Jonas Oreland49ac5952018-09-26 16:04:32 +02001256 : engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001257 webrtc::CreateBuiltinVideoDecoderFactory(),
1258 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001259
1260 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001261 // One testcase calls SetUp in a loop, only create call_ once.
1262 if (!call_) {
1263 call_.reset(webrtc::Call::Create(webrtc::Call::Config(&event_log_)));
1264 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001265 cricket::MediaConfig media_config;
1266 // Disabling cpu overuse detection actually disables quality scaling too; it
1267 // implies DegradationPreference kMaintainResolution. Automatic scaling
1268 // needs to be disabled, otherwise, tests which check the size of received
1269 // frames become flaky.
1270 media_config.video.enable_cpu_adaptation = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001271 channel_.reset(
1272 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
1273 call_.get(), media_config, cricket::VideoOptions(),
1274 webrtc::CryptoOptions())));
Niels Möller6557d0c2018-04-11 15:18:34 +02001275 channel_->OnReadyToSend(true);
1276 EXPECT_TRUE(channel_.get() != NULL);
1277 network_interface_.SetDestination(channel_.get());
Anton Sukhanov98a462c2018-10-17 13:15:42 -07001278 channel_->SetInterface(&network_interface_, /*media_transport=*/nullptr);
Niels Möller6557d0c2018-04-11 15:18:34 +02001279 cricket::VideoRecvParameters parameters;
1280 parameters.codecs = engine_.codecs();
1281 channel_->SetRecvParameters(parameters);
1282 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
1283 video_capturer_.reset(CreateFakeVideoCapturer());
1284 cricket::VideoFormat format(640, 480,
1285 cricket::VideoFormat::FpsToInterval(kFramerate),
1286 cricket::FOURCC_I420);
1287 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001288 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001289 }
1290
1291 virtual cricket::FakeVideoCapturerWithTaskQueue* CreateFakeVideoCapturer() {
1292 return new cricket::FakeVideoCapturerWithTaskQueue();
1293 }
1294
1295 // Utility method to setup an additional stream to send and receive video.
1296 // Used to test send and recv between two streams.
1297 void SetUpSecondStream() {
1298 SetUpSecondStreamWithNoRecv();
1299 // Setup recv for second stream.
1300 EXPECT_TRUE(channel_->AddRecvStream(
1301 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1302 // Make the second renderer available for use by a new stream.
1303 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1304 }
1305 // Setup an additional stream just to send video. Defer add recv stream.
1306 // This is required if you want to test unsignalled recv of video rtp packets.
1307 void SetUpSecondStreamWithNoRecv() {
1308 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001309 EXPECT_TRUE(
1310 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001311 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001312 EXPECT_FALSE(
1313 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001314 EXPECT_TRUE(channel_->AddSendStream(
1315 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1316 // We dont add recv for the second stream.
1317
1318 // Setup the receive and renderer for second stream after send.
1319 video_capturer_2_.reset(CreateFakeVideoCapturer());
1320 cricket::VideoFormat format(640, 480,
1321 cricket::VideoFormat::FpsToInterval(kFramerate),
1322 cricket::FOURCC_I420);
1323 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(format));
1324
Yves Gerey665174f2018-06-19 15:03:05 +02001325 EXPECT_TRUE(
1326 channel_->SetVideoSend(kSsrc + 2, nullptr, video_capturer_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001327 }
Yves Gerey665174f2018-06-19 15:03:05 +02001328 virtual void TearDown() { channel_.reset(); }
1329 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001330
1331 bool SetOneCodec(const cricket::VideoCodec& codec) {
1332 cricket::VideoFormat capture_format(
1333 kVideoWidth, kVideoHeight,
1334 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1335
1336 if (video_capturer_) {
1337 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(capture_format));
1338 }
1339 if (video_capturer_2_) {
1340 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(capture_format));
1341 }
1342
1343 bool sending = channel_->sending();
1344 bool success = SetSend(false);
1345 if (success) {
1346 cricket::VideoSendParameters parameters;
1347 parameters.codecs.push_back(codec);
1348 success = channel_->SetSendParameters(parameters);
1349 }
1350 if (success) {
1351 success = SetSend(sending);
1352 }
1353 return success;
1354 }
Yves Gerey665174f2018-06-19 15:03:05 +02001355 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001356 bool SendFrame() {
1357 if (video_capturer_2_) {
1358 video_capturer_2_->CaptureFrame();
1359 }
1360 return video_capturer_.get() && video_capturer_->CaptureFrame();
1361 }
1362 bool WaitAndSendFrame(int wait_ms) {
1363 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
1364 ret &= SendFrame();
1365 return ret;
1366 }
Yves Gerey665174f2018-06-19 15:03:05 +02001367 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001368 int NumRtpBytes(uint32_t ssrc) {
1369 return network_interface_.NumRtpBytes(ssrc);
1370 }
Yves Gerey665174f2018-06-19 15:03:05 +02001371 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001372 int NumRtpPackets(uint32_t ssrc) {
1373 return network_interface_.NumRtpPackets(ssrc);
1374 }
Yves Gerey665174f2018-06-19 15:03:05 +02001375 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001376 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1377 return network_interface_.GetRtpPacket(index);
1378 }
1379 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001380 webrtc::RTPHeader header;
1381 EXPECT_TRUE(ParseRtpPacket(p, &header));
1382 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001383 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001384
Niels Möller6557d0c2018-04-11 15:18:34 +02001385 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001386 webrtc::RTPHeader* header) {
1387 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1388 webrtc::RtpHeaderParser::Create());
1389 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001390 }
1391
1392 // Tests that we can send and receive frames.
1393 void SendAndReceive(const cricket::VideoCodec& codec) {
1394 EXPECT_TRUE(SetOneCodec(codec));
1395 EXPECT_TRUE(SetSend(true));
1396 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1397 EXPECT_EQ(0, renderer_.num_rendered_frames());
1398 EXPECT_TRUE(SendFrame());
1399 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1400 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1401 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1402 }
1403
1404 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001405 int duration_sec,
1406 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001407 EXPECT_TRUE(SetOneCodec(codec));
1408 EXPECT_TRUE(SetSend(true));
1409 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1410 EXPECT_EQ(0, renderer_.num_rendered_frames());
1411 for (int i = 0; i < duration_sec; ++i) {
1412 for (int frame = 1; frame <= fps; ++frame) {
1413 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1414 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1415 }
1416 }
1417 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1418 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1419 }
1420
Niels Möller6557d0c2018-04-11 15:18:34 +02001421 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1422 cricket::VideoMediaInfo info;
1423 EXPECT_TRUE(channel_->GetStats(&info));
1424 return info.senders[i];
1425 }
1426
1427 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1428 cricket::VideoMediaInfo info;
1429 EXPECT_TRUE(channel_->GetStats(&info));
1430 return info.receivers[i];
1431 }
1432
1433 // Two streams one channel tests.
1434
1435 // Tests that we can send and receive frames.
1436 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1437 SetUpSecondStream();
1438 // Test sending and receiving on first stream.
1439 SendAndReceive(codec);
1440 // Test sending and receiving on second stream.
1441 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1442 EXPECT_GT(NumRtpPackets(), 0);
1443 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1444 }
1445
1446 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1447 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001448 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001449 return engine_codec;
1450 }
1451 // This point should never be reached.
1452 ADD_FAILURE() << "Unrecognized codec name: " << name;
1453 return cricket::VideoCodec();
1454 }
1455
1456 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1457
1458 cricket::StreamParams DefaultSendStreamParams() {
1459 return cricket::StreamParams::CreateLegacy(kSsrc);
1460 }
1461
1462 webrtc::RtcEventLogNullImpl event_log_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001463 std::unique_ptr<webrtc::Call> call_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001464 WebRtcVideoEngine engine_;
1465 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_;
1466 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_2_;
1467 std::unique_ptr<WebRtcVideoChannel> channel_;
1468 cricket::FakeNetworkInterface network_interface_;
1469 cricket::FakeVideoRenderer renderer_;
1470
1471 // Used by test cases where 2 streams are run on the same channel.
1472 cricket::FakeVideoRenderer renderer2_;
1473};
1474
1475// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001476TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001477 EXPECT_FALSE(channel_->sending());
Yves Gerey665174f2018-06-19 15:03:05 +02001478 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001479 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1480 EXPECT_FALSE(channel_->sending());
1481 EXPECT_TRUE(SetSend(true));
1482 EXPECT_TRUE(channel_->sending());
1483 EXPECT_TRUE(SendFrame());
1484 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1485 EXPECT_TRUE(SetSend(false));
1486 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001487}
Niels Möller6557d0c2018-04-11 15:18:34 +02001488
1489// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001490TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001491 EXPECT_FALSE(channel_->sending());
1492 EXPECT_FALSE(SetSend(true));
1493 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001494}
Niels Möller6557d0c2018-04-11 15:18:34 +02001495
1496// Test that we properly set the send and recv buffer sizes by the time
1497// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001498TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001499 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1500 EXPECT_TRUE(SetSend(true));
1501 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001502 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001503}
1504
Niels Möller6557d0c2018-04-11 15:18:34 +02001505// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001506TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001507 const int kDurationSec = 3;
1508 const int kFps = 10;
1509 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1510
1511 cricket::VideoMediaInfo info;
1512 EXPECT_TRUE(channel_->GetStats(&info));
1513
1514 ASSERT_EQ(1U, info.senders.size());
1515 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1516 // For webrtc, bytes_sent does not include the RTP header length.
1517 EXPECT_GT(info.senders[0].bytes_sent, 0);
1518 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1519 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1520 ASSERT_TRUE(info.senders[0].codec_payload_type);
1521 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1522 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1523 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1524 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1525 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1526 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1527 EXPECT_GT(info.senders[0].framerate_input, 0);
1528 EXPECT_GT(info.senders[0].framerate_sent, 0);
1529
1530 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1531 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1532 info.send_codecs[DefaultCodec().id]);
1533
1534 ASSERT_EQ(1U, info.receivers.size());
1535 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1536 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1537 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1538 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1539 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1540 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1541 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1542 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1543 EXPECT_EQ(0, info.receivers[0].packets_lost);
1544 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1545 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1546 EXPECT_EQ(0, info.receivers[0].firs_sent);
1547 EXPECT_EQ(0, info.receivers[0].plis_sent);
1548 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1549 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1550 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1551 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1552 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1553 EXPECT_GT(info.receivers[0].framerate_output, 0);
1554
1555 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1556 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1557 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001558}
Niels Möller6557d0c2018-04-11 15:18:34 +02001559
1560// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001561TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001562 cricket::FakeVideoRenderer renderer1, renderer2;
1563 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1564 cricket::VideoSendParameters parameters;
1565 parameters.codecs.push_back(DefaultCodec());
1566 parameters.conference_mode = true;
1567 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1568 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001569 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1570 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001571 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1572 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1573 EXPECT_EQ(0, renderer1.num_rendered_frames());
1574 EXPECT_EQ(0, renderer2.num_rendered_frames());
1575 std::vector<uint32_t> ssrcs;
1576 ssrcs.push_back(1);
1577 ssrcs.push_back(2);
1578 network_interface_.SetConferenceMode(true, ssrcs);
1579 EXPECT_TRUE(SendFrame());
1580 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1581 kTimeout);
1582 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1583 kTimeout);
1584
1585 EXPECT_TRUE(channel_->SetSend(false));
1586
1587 cricket::VideoMediaInfo info;
1588 EXPECT_TRUE(channel_->GetStats(&info));
1589 ASSERT_EQ(1U, info.senders.size());
1590 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1591 // For webrtc, bytes_sent does not include the RTP header length.
1592 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1593 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1594 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1595 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1596
1597 ASSERT_EQ(2U, info.receivers.size());
1598 for (size_t i = 0; i < info.receivers.size(); ++i) {
1599 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1600 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1601 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001602 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001603 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1604 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1605 }
srtee0c2eea2017-12-15 17:44:33 +01001606}
Niels Möller6557d0c2018-04-11 15:18:34 +02001607
1608// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001609TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001610 // Normal setup; note that we set the SSRC explicitly to ensure that
1611 // it will come first in the senders map.
1612 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1613 cricket::VideoSendParameters parameters;
1614 parameters.codecs.push_back(DefaultCodec());
1615 parameters.conference_mode = true;
1616 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001617 EXPECT_TRUE(
1618 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001619 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1620 EXPECT_TRUE(SetSend(true));
1621 EXPECT_TRUE(SendFrame());
1622 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1623 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1624
1625 // Add an additional capturer, and hook up a renderer to receive it.
1626 cricket::FakeVideoRenderer renderer2;
1627 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1628 CreateFakeVideoCapturer());
1629 const int kTestWidth = 160;
1630 const int kTestHeight = 120;
1631 cricket::VideoFormat format(kTestWidth, kTestHeight,
1632 cricket::VideoFormat::FpsToInterval(5),
1633 cricket::FOURCC_I420);
1634 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001635 EXPECT_TRUE(
1636 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001637 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, capturer.get()));
Yves Gerey665174f2018-06-19 15:03:05 +02001638 EXPECT_TRUE(
1639 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001640 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
1641 EXPECT_TRUE(capturer->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001642 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1643 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001644
1645 // Get stats, and make sure they are correct for two senders. We wait until
1646 // the number of expected packets have been sent to avoid races where we
1647 // check stats before it has been updated.
1648 cricket::VideoMediaInfo info;
1649 for (uint32_t i = 0; i < kTimeout; ++i) {
1650 rtc::Thread::Current()->ProcessMessages(1);
1651 EXPECT_TRUE(channel_->GetStats(&info));
1652 ASSERT_EQ(2U, info.senders.size());
1653 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1654 NumRtpPackets()) {
1655 // Stats have been updated for both sent frames, expectations can be
1656 // checked now.
1657 break;
1658 }
1659 }
1660 EXPECT_EQ(NumRtpPackets(),
1661 info.senders[0].packets_sent + info.senders[1].packets_sent)
1662 << "Timed out while waiting for packet counts for all sent packets.";
1663 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1664 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1665 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1666 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1667 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1668 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1669 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1670 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1671 // The capturer must be unregistered here as it runs out of it's scope next.
1672 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001673}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001674
Niels Möller6557d0c2018-04-11 15:18:34 +02001675// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001676TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001677 cricket::VideoSendParameters parameters;
1678 parameters.codecs.push_back(DefaultCodec());
1679 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1680 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1681 parameters.max_bandwidth_bps = 128 * 1024;
1682 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001683}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001684
Niels Möller6557d0c2018-04-11 15:18:34 +02001685// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001686TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001687 EXPECT_TRUE(SetDefaultCodec());
1688 EXPECT_TRUE(SetSend(true));
1689 EXPECT_TRUE(SendFrame());
1690 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001691 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001692 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001693 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1694 EXPECT_EQ(kSsrc, header.ssrc);
1695
Niels Möller6557d0c2018-04-11 15:18:34 +02001696 // Packets are being paced out, so these can mismatch between the first and
1697 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001698 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1699 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001700 EXPECT_EQ(1, NumSentSsrcs());
1701 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1702 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001703}
Niels Möller6557d0c2018-04-11 15:18:34 +02001704
1705// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001706TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001707 // Remove stream added in Setup.
1708 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1709 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001710 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001711 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
1712 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001713 EXPECT_TRUE(SetSend(true));
1714 EXPECT_TRUE(WaitAndSendFrame(0));
1715 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001716 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001717 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001718 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1719 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001720 // Packets are being paced out, so these can mismatch between the first and
1721 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001722 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1723 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001724 EXPECT_EQ(1, NumSentSsrcs());
1725 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1726 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001727}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001728
Niels Möller6557d0c2018-04-11 15:18:34 +02001729// Test that we can set the default video renderer before and after
1730// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001731TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001732 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1733 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001734
1735 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1736 rtc::SetBE32(packet1.data() + 8, kSsrc);
1737 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1738 EXPECT_TRUE(SetDefaultCodec());
1739 EXPECT_TRUE(SetSend(true));
1740 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möllere6933812018-11-05 13:01:41 +01001741 channel_->OnPacketReceived(&packet1, /* packet_time_us */ -1);
Niels Möller6557d0c2018-04-11 15:18:34 +02001742 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1743 EXPECT_TRUE(SendFrame());
1744 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001745}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001746
Niels Möller6557d0c2018-04-11 15:18:34 +02001747// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001748TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001749 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1750 EXPECT_TRUE(SetSend(true));
1751 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1752 EXPECT_TRUE(SendFrame());
1753 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1754 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001755 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001756 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001757 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1758 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001759 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1760 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001761
1762 // Remove the send stream that was added during Setup.
1763 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1764 int rtp_packets = NumRtpPackets();
1765
Niels Möller6557d0c2018-04-11 15:18:34 +02001766 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001767 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
1768 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001769 EXPECT_EQ(rtp_packets, NumRtpPackets());
1770 // Wait 30ms to guarantee the engine does not drop the frame.
1771 EXPECT_TRUE(WaitAndSendFrame(30));
1772 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1773
1774 last_packet = NumRtpPackets() - 1;
1775 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001776 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1777 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001778}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001779
Niels Möller6557d0c2018-04-11 15:18:34 +02001780// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001781TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001782 cricket::FakeVideoRenderer renderer1, renderer2;
1783 EXPECT_TRUE(SetDefaultCodec());
1784 cricket::VideoSendParameters parameters;
1785 parameters.codecs.push_back(DefaultCodec());
1786 parameters.conference_mode = true;
1787 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1788 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001789 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1790 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001791 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1792 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1793 EXPECT_EQ(0, renderer1.num_rendered_frames());
1794 EXPECT_EQ(0, renderer2.num_rendered_frames());
1795 std::vector<uint32_t> ssrcs;
1796 ssrcs.push_back(1);
1797 ssrcs.push_back(2);
1798 network_interface_.SetConferenceMode(true, ssrcs);
1799 EXPECT_TRUE(SendFrame());
1800 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1801 kTimeout);
1802 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1803 kTimeout);
1804
1805 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1806 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1807 EXPECT_EQ(kVideoWidth, renderer1.width());
1808 EXPECT_EQ(kVideoHeight, renderer1.height());
1809 EXPECT_EQ(kVideoWidth, renderer2.width());
1810 EXPECT_EQ(kVideoHeight, renderer2.height());
1811 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1812 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001813}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001814
Niels Möller6557d0c2018-04-11 15:18:34 +02001815// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001816TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001817 using cricket::VideoCodec;
1818 using cricket::VideoOptions;
1819 using cricket::VideoFormat;
1820 using cricket::FOURCC_I420;
1821
1822 VideoCodec codec = DefaultCodec();
1823 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1824 EXPECT_TRUE(SetOneCodec(codec));
1825 EXPECT_TRUE(SetSend(true));
1826 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1827 EXPECT_EQ(0, renderer_.num_rendered_frames());
1828 EXPECT_TRUE(SendFrame());
1829 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1830 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1831 CreateFakeVideoCapturer());
1832
1833 // TODO(nisse): This testcase fails if we don't configure
1834 // screencast. It's unclear why, I see nothing obvious in this
1835 // test which is related to screencast logic.
1836 VideoOptions video_options;
1837 video_options.is_screencast = true;
1838 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1839
1840 VideoFormat format(480, 360, VideoFormat::FpsToInterval(30), FOURCC_I420);
1841 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
1842 // All capturers start generating frames with the same timestamp. ViE does
1843 // not allow the same timestamp to be used. Capture one frame before
1844 // associating the capturer with the channel.
1845 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1846
1847 int captured_frames = 1;
1848 for (int iterations = 0; iterations < 2; ++iterations) {
1849 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, capturer.get()));
1850 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
1851 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1852 ++captured_frames;
1853 // Wait until frame of right size is captured.
1854 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001855 format.width == renderer_.width() &&
1856 format.height == renderer_.height() &&
1857 !renderer_.black_frame(),
1858 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001859 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1860 EXPECT_EQ(format.width, renderer_.width());
1861 EXPECT_EQ(format.height, renderer_.height());
1862 captured_frames = renderer_.num_rendered_frames() + 1;
1863 EXPECT_FALSE(renderer_.black_frame());
1864 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1865 // Make sure a black frame is generated within the specified timeout.
1866 // The black frame should be the resolution of the previous frame to
1867 // prevent expensive encoder reconfigurations.
1868 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001869 format.width == renderer_.width() &&
1870 format.height == renderer_.height() &&
1871 renderer_.black_frame(),
1872 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001873 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1874 EXPECT_EQ(format.width, renderer_.width());
1875 EXPECT_EQ(format.height, renderer_.height());
1876 EXPECT_TRUE(renderer_.black_frame());
1877
1878 // The black frame has the same timestamp as the next frame since it's
1879 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1880 // not render a frame with the same timestamp so capture another frame
1881 // with the frame capturer to increment the next frame's timestamp.
1882 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1883 }
srtee0c2eea2017-12-15 17:44:33 +01001884}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001885
Niels Möller6557d0c2018-04-11 15:18:34 +02001886// Tests that if SetVideoSend is called with a NULL capturer after the
1887// capturer was already removed, the application doesn't crash (and no black
1888// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001889TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001890 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1891 EXPECT_TRUE(SetSend(true));
1892 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1893 EXPECT_EQ(0, renderer_.num_rendered_frames());
1894 EXPECT_TRUE(SendFrame());
1895 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1896 // Wait for one frame so they don't get dropped because we send frames too
1897 // tightly.
1898 rtc::Thread::Current()->ProcessMessages(30);
1899 // Remove the capturer.
1900 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1901
1902 // No capturer was added, so this SetVideoSend shouldn't do anything.
1903 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1904 rtc::Thread::Current()->ProcessMessages(300);
1905 // Verify no more frames were sent.
1906 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001907}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001908
Niels Möller6557d0c2018-04-11 15:18:34 +02001909// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001910TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001911 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1912 // interval time to avoid that.
1913 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1914 // interval time to avoid that.
1915 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001916 EXPECT_TRUE(
1917 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001918 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1919 cricket::VideoFormat capture_format(
1920 kVideoWidth, kVideoHeight,
1921 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1922 // Set up additional stream 1.
1923 cricket::FakeVideoRenderer renderer1;
1924 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001925 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001926 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001927 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001928 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer1(
1929 CreateFakeVideoCapturer());
1930 EXPECT_EQ(cricket::CS_RUNNING, capturer1->Start(capture_format));
1931 // Set up additional stream 2.
1932 cricket::FakeVideoRenderer renderer2;
1933 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001934 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001935 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001936 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001937 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer2(
1938 CreateFakeVideoCapturer());
1939 EXPECT_EQ(cricket::CS_RUNNING, capturer2->Start(capture_format));
1940 // State for all the streams.
1941 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1942 // A limitation in the lmi implementation requires that SetVideoSend() is
1943 // called after SetOneCodec().
1944 // TODO(hellner): this seems like an unnecessary constraint, fix it.
1945 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, capturer1.get()));
1946 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, capturer2.get()));
1947 EXPECT_TRUE(SetSend(true));
1948 // Test capturer associated with engine.
1949 const int kTestWidth = 160;
1950 const int kTestHeight = 120;
1951 EXPECT_TRUE(capturer1->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001952 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
1953 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001954 // Capture a frame with additional capturer2, frames should be received
1955 EXPECT_TRUE(capturer2->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001956 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1957 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001958 // Successfully remove the capturer.
1959 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1960 // The capturers must be unregistered here as it runs out of it's scope
1961 // next.
1962 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
1963 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01001964}
Niels Möller6557d0c2018-04-11 15:18:34 +02001965
1966// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01001967TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001968 // Remove the send stream that was added during Setup.
1969 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1970
1971 cricket::StreamParams empty;
1972 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02001973 EXPECT_TRUE(
1974 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01001975}
Niels Möller6557d0c2018-04-11 15:18:34 +02001976
1977// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01001978TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001979 // Remove stream added in Setup. I.e. remove stream corresponding to default
1980 // channel.
1981 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02001982 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02001983 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
1984 EXPECT_TRUE(channel_->AddSendStream(
1985 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
1986 }
1987 // Delete one of the non default channel streams, let the destructor delete
1988 // the remaining ones.
1989 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
1990 // Stream should already be deleted.
1991 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01001992}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00001993
eladalonf1841382017-06-12 01:16:46 -07001994TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08001995 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001996}
1997
eladalonf1841382017-06-12 01:16:46 -07001998TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08001999 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002000}
2001
eladalonf1841382017-06-12 01:16:46 -07002002TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002003 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002004}
2005
eladalonf1841382017-06-12 01:16:46 -07002006TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002007 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2008 // bitrates. This currently happens at <250k, and two streams sharing 300k
2009 // initially will use QVGA instead of VGA.
2010 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2011 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002012 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002013 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002014 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002015}
2016
eladalonf1841382017-06-12 01:16:46 -07002017class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002018 public:
eladalonf1841382017-06-12 01:16:46 -07002019 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2020 explicit WebRtcVideoChannelTest(const char* field_trials)
2021 : WebRtcVideoEngineTest(field_trials), last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002022 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002023 encoder_factory_->AddSupportedVideoCodecType("VP8");
2024 encoder_factory_->AddSupportedVideoCodecType("VP9");
2025#if defined(WEBRTC_USE_H264)
2026 encoder_factory_->AddSupportedVideoCodecType("H264");
2027#endif
2028
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002029 fake_call_.reset(new FakeCall());
Sebastian Jansson84848f22018-11-16 10:40:36 +01002030 channel_.reset(engine_.CreateMediaChannel(fake_call_.get(),
2031 GetMediaConfig(), VideoOptions(),
2032 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002033 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002034 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002035 send_parameters_.codecs = engine_.codecs();
2036 recv_parameters_.codecs = engine_.codecs();
2037 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002038 }
2039
2040 protected:
2041 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002042 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002043 }
2044
2045 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002046 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002047 EXPECT_TRUE(channel_->AddSendStream(sp));
2048 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002049 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002050 EXPECT_EQ(num_streams + 1, streams.size());
2051 return streams[streams.size() - 1];
2052 }
2053
2054 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002055 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002056 }
2057
2058 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002059 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002060 }
2061
2062 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002063 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002064 EXPECT_TRUE(channel_->AddRecvStream(sp));
2065 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002066 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002067 EXPECT_EQ(num_streams + 1, streams.size());
2068 return streams[streams.size() - 1];
2069 }
2070
pbos@webrtc.org00873182014-11-25 14:03:34 +00002071 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2072 int expected_min_bitrate_bps,
2073 const char* start_bitrate_kbps,
2074 int expected_start_bitrate_bps,
2075 const char* max_bitrate_kbps,
2076 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002077 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2078 expected_start_bitrate_bps,
2079 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002080 auto& codecs = send_parameters_.codecs;
2081 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002082 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002083 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2084 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2085 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002086 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002087 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002088
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002089 void ExpectSetBitrateParameters(int min_bitrate_bps,
2090 int start_bitrate_bps,
2091 int max_bitrate_bps) {
2092 EXPECT_CALL(
2093 *fake_call_->GetMockTransportControllerSend(),
2094 SetSdpBitrateParameters(AllOf(
2095 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2096 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2097 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2098 }
2099
2100 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2101 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2102 SetSdpBitrateParameters(Field(
2103 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002104 }
2105
Johannes Kron9190b822018-10-29 11:22:05 +01002106 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2107 // For a caller, the answer will be applied in set remote description
2108 // where SetSendParameters() is called.
2109 EXPECT_TRUE(
2110 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2111 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2112 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2113 const webrtc::VideoSendStream::Config& config =
2114 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2115 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2116 }
2117
2118 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2119 // For a callee, the answer will be applied in set local description
2120 // where SetExtmapAllowMixed() and AddSendStream() are called.
2121 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2122 EXPECT_TRUE(
2123 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2124 const webrtc::VideoSendStream::Config& config =
2125 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2126 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2127 }
2128
isheriff6f8d6862016-05-26 11:24:55 -07002129 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002130 // Enable extension.
2131 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002132 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002133 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002134 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002135 FakeVideoSendStream* send_stream =
2136 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2137
2138 // Verify the send extension id.
2139 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2140 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002141 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002142 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002143 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002144 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2145 // receivers.
2146 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2147 ->GetConfig()
2148 .rtp.extensions.empty());
2149
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002150 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002151 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002152 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2153 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002154 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2155
2156 // Verify that adding receive RTP header extensions adds them for existing
2157 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002158 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002159 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002160 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2161 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002162 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002163 }
2164
isheriff6f8d6862016-05-26 11:24:55 -07002165 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002166 // Enable extension.
2167 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002168 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002169 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002170 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002171
2172 FakeVideoReceiveStream* recv_stream =
2173 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2174
2175 // Verify the recv extension id.
2176 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2177 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002178 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002179 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002180 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002181
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002182 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2183 // senders.
2184 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2185 ->GetConfig()
2186 .rtp.extensions.empty());
2187
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002188 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002189 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002190 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2191 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002192 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2193
2194 // Verify that adding receive RTP header extensions adds them for existing
2195 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002196 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002197 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002198 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2199 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002200 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002201 }
2202
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002203 void TestExtensionFilter(const std::vector<std::string>& extensions,
2204 const std::string& expected_extension) {
2205 cricket::VideoSendParameters parameters = send_parameters_;
2206 int expected_id = -1;
2207 int id = 1;
2208 for (const std::string& extension : extensions) {
2209 if (extension == expected_extension)
2210 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002211 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002212 }
2213 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2214 FakeVideoSendStream* send_stream =
2215 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2216
2217 // Verify that only one of them has been set, and that it is the one with
2218 // highest priority (transport sequence number).
2219 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2220 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2221 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002222 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002223 }
2224
asapersson3c81a1a2017-06-14 05:52:21 -07002225 void TestDegradationPreference(bool resolution_scaling_enabled,
2226 bool fps_scaling_enabled);
2227
Erik Språngefbde372015-04-29 16:21:28 +02002228 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002229 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002230 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2231 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002232
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002233 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002234 uint32_t ssrc,
Tommi85959932018-02-07 19:26:06 +01002235 FakeVideoCapturerWithTaskQueue* capturer,
nisse0db023a2016-03-01 04:29:59 -08002236 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002237 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002238 options.video_noise_reduction = enabled;
Niels Möllerff40b142018-04-09 08:49:14 +02002239 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, capturer));
nisse0db023a2016-03-01 04:29:59 -08002240 // Options only take effect on the next frame.
2241 EXPECT_TRUE(capturer->CaptureFrame());
2242
Erik Språng143cec12015-04-28 10:01:41 +02002243 return fake_call_->GetVideoSendStreams().back();
2244 }
2245
Peter Boström2feafdb2015-09-09 14:32:14 +02002246 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2247 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002248 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002249 std::vector<uint32_t> ssrcs;
2250 std::vector<uint32_t> rtx_ssrcs;
2251 uint32_t num_streams = enabled ? 3 : 1;
2252 for (uint32_t i = 0; i < num_streams; ++i) {
2253 uint32_t ssrc = last_ssrc_ + i;
2254 ssrcs.push_back(ssrc);
2255 if (with_rtx) {
2256 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2257 }
Erik Språng143cec12015-04-28 10:01:41 +02002258 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002259 if (with_rtx) {
2260 return AddSendStream(
2261 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2262 }
2263 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002264 }
2265
perkjfa10b552016-10-02 23:45:26 -07002266 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002267 std::vector<FakeVideoSendStream*> streams =
2268 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002269 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002270 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002271 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002272 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002273 }
2274
perkjfa10b552016-10-02 23:45:26 -07002275 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002276 int stream_max,
2277 int expected_encoder_bitrate) {
2278 VideoSendParameters limited_send_params = send_parameters_;
2279 limited_send_params.max_bandwidth_bps = global_max;
2280 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002281 webrtc::RtpParameters parameters =
2282 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002283 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002284 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002285 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002286 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002287 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002288 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002289 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002290 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002291 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002292 }
2293
Åsa Persson55659812018-06-18 17:51:32 +02002294 // Values from kSimulcastConfigs in simulcast.cc.
2295 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2296 std::vector<webrtc::VideoStream> layers(3);
2297 layers[0].min_bitrate_bps = 30000;
2298 layers[0].target_bitrate_bps = 150000;
2299 layers[0].max_bitrate_bps = 200000;
2300 layers[1].min_bitrate_bps = 150000;
2301 layers[1].target_bitrate_bps = 500000;
2302 layers[1].max_bitrate_bps = 700000;
2303 layers[2].min_bitrate_bps = 600000;
2304 layers[2].target_bitrate_bps = 2500000;
2305 layers[2].max_bitrate_bps = 2500000;
2306 return layers;
2307 }
2308
kwiberg686a8ef2016-02-26 03:00:35 -08002309 std::unique_ptr<FakeCall> fake_call_;
2310 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002311 cricket::VideoSendParameters send_parameters_;
2312 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002313 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002314};
2315
eladalonf1841382017-06-12 01:16:46 -07002316TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002317 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002318 const std::string kSyncLabel = "AvSyncLabel";
2319
2320 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002321 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002322 EXPECT_TRUE(channel_->AddRecvStream(sp));
2323
Mirko Bonadeif859e552018-05-30 15:31:29 +02002324 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002325 EXPECT_EQ(kSyncLabel,
2326 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2327 << "SyncGroup should be set based on sync_label";
2328}
2329
eladalonf1841382017-06-12 01:16:46 -07002330TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002331 cricket::VideoSendParameters parameters;
2332 parameters.codecs = engine_.codecs();
2333 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002334 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002335 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002336 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002337
2338 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002339 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2340 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002341 FakeVideoSendStream* send_stream = AddSendStream(
2342 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2343
2344 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2345 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2346 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2347
2348 // Receiver side.
2349 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2350 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002351 EXPECT_FALSE(
2352 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002353 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002354 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002355 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002356 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002357 << "RTX should be mapped for the RED payload type";
2358
brandtr14742122017-01-27 04:53:07 -08002359 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002360}
2361
eladalonf1841382017-06-12 01:16:46 -07002362TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002363 // Setup one channel with an associated RTX stream.
2364 cricket::StreamParams params =
2365 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2366 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2367 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002368 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002369
2370 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2371 << "RTX should be mapped for all decoders/payload types.";
2372 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002373 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002374 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002375}
2376
eladalonf1841382017-06-12 01:16:46 -07002377TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002378 // Setup one channel without an associated RTX stream.
2379 cricket::StreamParams params =
2380 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2381 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002382 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002383}
2384
Johannes Kron9190b822018-10-29 11:22:05 +01002385// Test propagation of extmap allow mixed setting.
2386TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2387 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2388}
2389TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2390 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2391}
2392TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2393 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2394}
2395TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2396 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2397}
2398
eladalonf1841382017-06-12 01:16:46 -07002399TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002400 FakeVideoSendStream* send_stream =
2401 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2402 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2403
2404 FakeVideoReceiveStream* recv_stream =
2405 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2406 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002407}
2408
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002409// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002410TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002411 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002412}
isheriff6f8d6862016-05-26 11:24:55 -07002413
eladalonf1841382017-06-12 01:16:46 -07002414TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002415 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002416}
2417
2418// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002419TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002420 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002421}
isheriff6f8d6862016-05-26 11:24:55 -07002422
eladalonf1841382017-06-12 01:16:46 -07002423TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002424 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002425}
2426
eladalonf1841382017-06-12 01:16:46 -07002427TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002428 // Enable three redundant extensions.
2429 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002430 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2431 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2432 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2433 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002434}
2435
eladalonf1841382017-06-12 01:16:46 -07002436TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002437 // Enable two redundant extensions.
2438 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002439 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2440 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2441 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002442}
2443
stefanc1aeaf02015-10-15 07:26:07 -07002444// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002445TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002446 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002447}
eladalonf1841382017-06-12 01:16:46 -07002448TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002449 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002450}
2451
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002452// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002453TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002454 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002455}
eladalonf1841382017-06-12 01:16:46 -07002456TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002457 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002458}
2459
eladalonf1841382017-06-12 01:16:46 -07002460TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002461 const int kAbsSendTimeId = 1;
2462 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002463 send_parameters_.extensions.push_back(
2464 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2465 send_parameters_.extensions.push_back(
2466 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002467
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002468 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002469 FakeVideoSendStream* send_stream =
2470 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2471
2472 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002473 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002474
2475 // Setting the same extensions (even if in different order) shouldn't
2476 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002477 std::reverse(send_parameters_.extensions.begin(),
2478 send_parameters_.extensions.end());
2479 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002480
2481 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2482
2483 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002484 send_parameters_.extensions.resize(1);
2485 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002486
2487 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2488}
2489
eladalonf1841382017-06-12 01:16:46 -07002490TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002491 const int kTOffsetId = 1;
2492 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002493 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002494 recv_parameters_.extensions.push_back(
2495 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2496 recv_parameters_.extensions.push_back(
2497 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2498 recv_parameters_.extensions.push_back(
2499 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002500
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002501 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002502 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002503 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2504
2505 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002506 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002507
2508 // Setting the same extensions (even if in different order) shouldn't
2509 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002510 std::reverse(recv_parameters_.extensions.begin(),
2511 recv_parameters_.extensions.end());
2512 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002513
2514 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2515
2516 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002517 recv_parameters_.extensions.resize(1);
2518 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002519
2520 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2521}
2522
eladalonf1841382017-06-12 01:16:46 -07002523TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002524 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002525 const int kUnsupportedId = 1;
2526 const int kTOffsetId = 2;
2527
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002528 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002529 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002530 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002531 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002532 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002533 FakeVideoSendStream* send_stream =
2534 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2535
2536 // Only timestamp offset extension is set to send stream,
2537 // unsupported rtp extension is ignored.
2538 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002539 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2540 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002541}
2542
eladalonf1841382017-06-12 01:16:46 -07002543TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002544 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002545 const int kUnsupportedId = 1;
2546 const int kTOffsetId = 2;
2547
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002548 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002549 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002550 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002551 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002552 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002553 FakeVideoReceiveStream* recv_stream =
2554 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2555
2556 // Only timestamp offset extension is set to receive stream,
2557 // unsupported rtp extension is ignored.
2558 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002559 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2560 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002561}
2562
eladalonf1841382017-06-12 01:16:46 -07002563TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002564 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002565 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002566 send_parameters_.extensions.push_back(
2567 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002568 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002569 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2570 }
2571}
2572
eladalonf1841382017-06-12 01:16:46 -07002573TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002574 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002575 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002576 recv_parameters_.extensions.push_back(
2577 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002578 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002579 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2580 }
2581}
2582
eladalonf1841382017-06-12 01:16:46 -07002583TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002584 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002585 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002586 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002587 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002588 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002589 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002590
2591 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002592 send_parameters_.extensions.clear();
2593 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002594 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002595 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2596 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002597}
2598
eladalonf1841382017-06-12 01:16:46 -07002599TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002600 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002601 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002602 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002603 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002604 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002605 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002606
2607 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002608 recv_parameters_.extensions.clear();
2609 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002610 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002611 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2612 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002613}
2614
eladalonf1841382017-06-12 01:16:46 -07002615TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002616 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002617 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002618}
2619
eladalonf1841382017-06-12 01:16:46 -07002620TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002621 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002622 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002623}
2624
eladalonf1841382017-06-12 01:16:46 -07002625TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002626 FakeVideoReceiveStream* stream = AddRecvStream();
2627 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002628}
2629
eladalonf1841382017-06-12 01:16:46 -07002630TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002631 FakeVideoReceiveStream* stream = AddRecvStream();
2632 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2633}
2634
eladalonf1841382017-06-12 01:16:46 -07002635TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002636 FakeVideoReceiveStream* stream = AddRecvStream();
2637 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2638
Peter Boström126c03e2015-05-11 12:48:12 +02002639 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002640 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002641 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002642 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2643 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002644 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002645 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2646
2647 // Verify that REMB is turned on when setting default codecs since the
2648 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002649 parameters.codecs = engine_.codecs();
2650 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002651 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002652 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002653}
2654
eladalonf1841382017-06-12 01:16:46 -07002655TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002656 FakeVideoReceiveStream* stream = AddRecvStream();
2657 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2658
2659 // Verify that transport cc feedback is turned off when send(!) codecs without
2660 // transport cc feedback are set.
2661 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002662 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002663 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2664 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2665 stream = fake_call_->GetVideoReceiveStreams()[0];
2666 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2667
2668 // Verify that transport cc feedback is turned on when setting default codecs
2669 // since the default codecs have transport cc feedback enabled.
2670 parameters.codecs = engine_.codecs();
2671 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2672 stream = fake_call_->GetVideoReceiveStreams()[0];
2673 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2674}
2675
eladalonf1841382017-06-12 01:16:46 -07002676TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002677 AssignDefaultCodec();
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002678 VerifyCodecHasDefaultFeedbackParams(default_codec_);
2679
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002680 cricket::VideoSendParameters parameters;
2681 parameters.codecs = engine_.codecs();
2682 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002683 EXPECT_TRUE(channel_->SetSend(true));
2684
2685 // Send side.
2686 FakeVideoSendStream* send_stream =
2687 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2688 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2689
2690 // Receiver side.
2691 FakeVideoReceiveStream* recv_stream =
2692 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2693 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2694
2695 // Nack history size should match between sender and receiver.
2696 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2697 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002698}
2699
eladalonf1841382017-06-12 01:16:46 -07002700TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002701 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002702 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002703
2704 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2705 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2706
2707 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002708 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002709 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002710 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2711 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002712 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2713 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2714 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002715 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2716
Peter Boström67c9df72015-05-11 14:34:58 +02002717 // Verify that NACK is turned on when setting default codecs since the
2718 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002719 parameters.codecs = engine_.codecs();
2720 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002721 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2722 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2723 send_stream = fake_call_->GetVideoSendStreams()[0];
2724 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002725}
2726
Peter Boströme7ba0862016-03-12 00:02:28 +01002727// This test verifies that new frame sizes reconfigures encoders even though not
2728// (yet) sending. The purpose of this is to permit encoding as quickly as
2729// possible once we start sending. Likely the frames being input are from the
2730// same source that will be sent later, which just means that we're ready
2731// earlier.
eladalonf1841382017-06-12 01:16:46 -07002732TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002733 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002734 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002735 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2736 channel_->SetSend(false);
2737
2738 FakeVideoSendStream* stream = AddSendStream();
2739
perkjfa10b552016-10-02 23:45:26 -07002740 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002741 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002742 EXPECT_EQ(0u, streams[0].width);
2743 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002744
Tommi85959932018-02-07 19:26:06 +01002745 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002746 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj26752742016-10-24 01:21:16 -07002747 VideoFormat capture_format = capturer.GetSupportedFormats()->front();
2748 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
Peter Boströme7ba0862016-03-12 00:02:28 +01002749 EXPECT_TRUE(capturer.CaptureFrame());
2750
2751 // Frame entered, should be reconfigured to new dimensions.
2752 streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002753 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.width), streams[0].width);
2754 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.height),
2755 streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002756
Niels Möllerff40b142018-04-09 08:49:14 +02002757 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002758}
2759
eladalonf1841382017-06-12 01:16:46 -07002760TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002761 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002762 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002763 cricket::VideoSendParameters parameters;
2764 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002765 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002766 AddSendStream();
2767
Tommi85959932018-02-07 19:26:06 +01002768 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07002769 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002770 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Yves Gerey665174f2018-06-19 15:03:05 +02002771 EXPECT_TRUE(
2772 channel_->SetVideoSend(last_ssrc_, &min_bitrate_options, &capturer));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002773 cricket::VideoFormat capture_format_hd =
2774 capturer.GetSupportedFormats()->front();
2775 EXPECT_EQ(1280, capture_format_hd.width);
2776 EXPECT_EQ(720, capture_format_hd.height);
2777 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2778
2779 EXPECT_TRUE(channel_->SetSend(true));
2780
2781 EXPECT_TRUE(capturer.CaptureFrame());
2782 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2783 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2784
2785 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2786
2787 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002788 webrtc::VideoEncoderConfig encoder_config =
2789 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002790 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002791 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002792 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002793 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2794 streams.front().width);
2795 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2796 streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002797 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2798 << "Non-screenshare shouldn't use min-transmit bitrate.";
2799
Niels Möllerff40b142018-04-09 08:49:14 +02002800 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002801 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002802 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002803 screencast_options.is_screencast = true;
deadbeef5a4a75a2016-06-02 16:23:38 -07002804 EXPECT_TRUE(
Niels Möllerff40b142018-04-09 08:49:14 +02002805 channel_->SetVideoSend(last_ssrc_, &screencast_options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08002806 EXPECT_TRUE(capturer.CaptureFrame());
sprangf24a0642017-02-28 13:23:26 -08002807 // Send stream recreated after option change.
2808 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2809 send_stream = fake_call_->GetVideoSendStreams().front();
2810 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002811
2812 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002813 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002814 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002815 encoder_config.content_type);
2816 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2817 encoder_config.min_transmit_bitrate_bps);
2818
perkjfa10b552016-10-02 23:45:26 -07002819 streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002820 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2821 streams.front().width);
2822 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2823 streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002824 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002825 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002826}
2827
eladalonf1841382017-06-12 01:16:46 -07002828TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002829 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002830 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002831 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002832 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002833
2834 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002835 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002836 options.is_screencast = true;
Tommi85959932018-02-07 19:26:06 +01002837 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002838 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002839 cricket::VideoFormat capture_format_hd =
2840 capturer.GetSupportedFormats()->front();
2841 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2842
2843 EXPECT_TRUE(channel_->SetSend(true));
2844
2845 EXPECT_TRUE(capturer.CaptureFrame());
2846 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2847 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2848
perkj26091b12016-09-01 01:17:40 -07002849 webrtc::VideoEncoderConfig encoder_config =
2850 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002851
2852 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002853 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002854 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002855 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002856
2857 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2858 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002859 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002860 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002861 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002862
Niels Möllerff40b142018-04-09 08:49:14 +02002863 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002864}
2865
eladalonf1841382017-06-12 01:16:46 -07002866TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002867 FakeVideoSendStream* stream = AddSendStream();
2868 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2869}
2870
eladalonf1841382017-06-12 01:16:46 -07002871TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002872 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002873 media_config.video.suspend_below_min_bitrate = true;
2874
Sebastian Jansson84848f22018-11-16 10:40:36 +01002875 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002876 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002877 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002878
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002879 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002880
2881 FakeVideoSendStream* stream = AddSendStream();
2882 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2883
nisse0db023a2016-03-01 04:29:59 -08002884 media_config.video.suspend_below_min_bitrate = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01002885 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002886 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002887 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002888
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002889 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002890
nisse0db023a2016-03-01 04:29:59 -08002891 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002892 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2893}
2894
eladalonf1841382017-06-12 01:16:46 -07002895TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002896 FakeVideoSendStream* stream = AddSendStream();
2897 webrtc::VideoCodecVP8 vp8_settings;
2898 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2899 EXPECT_TRUE(vp8_settings.denoisingOn);
2900}
2901
eladalonf1841382017-06-12 01:16:46 -07002902TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002903 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002904 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002905 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002906
Peter Boström2feafdb2015-09-09 14:32:14 +02002907 // Single-stream settings should apply with RTX as well (verifies that we
2908 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2909 // both RTX and regular SSRCs).
2910 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002911
Tommi85959932018-02-07 19:26:06 +01002912 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002913 EXPECT_EQ(cricket::CS_RUNNING,
2914 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002915 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002916 channel_->SetSend(true);
2917
2918 EXPECT_TRUE(capturer.CaptureFrame());
2919
pbos4cba4eb2015-10-26 11:18:18 -07002920 webrtc::VideoCodecVP8 vp8_settings;
2921 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2922 EXPECT_TRUE(vp8_settings.denoisingOn)
2923 << "VP8 denoising should be on by default.";
2924
nisse05103312016-03-16 02:22:50 -07002925 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002926
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002927 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2928 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002929 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2930 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002931
nisse05103312016-03-16 02:22:50 -07002932 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002933
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002934 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2935 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002936 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2937 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2938
Niels Möllerff40b142018-04-09 08:49:14 +02002939 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002940 stream = SetUpSimulcast(true, false);
Niels Möllerff40b142018-04-09 08:49:14 +02002941 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002942 channel_->SetSend(true);
2943 EXPECT_TRUE(capturer.CaptureFrame());
2944
Mirko Bonadeif859e552018-05-30 15:31:29 +02002945 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002946 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2947 // Autmatic resize off when using simulcast.
2948 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2949 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2950
2951 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002952 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002953 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002954 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
Niels Möller60653ba2016-03-02 11:41:36 +01002955
nisse05103312016-03-16 02:22:50 -07002956 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002957
Mirko Bonadeif859e552018-05-30 15:31:29 +02002958 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002959 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2960 EXPECT_FALSE(vp8_settings.denoisingOn);
2961 // Resizing and frame dropping always off for screen sharing.
2962 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2963 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2964
nisse05103312016-03-16 02:22:50 -07002965 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02002966
2967 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2968 EXPECT_FALSE(vp8_settings.denoisingOn);
2969 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2970 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2971
Niels Möllerff40b142018-04-09 08:49:14 +02002972 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02002973}
2974
deadbeef119760a2016-04-04 11:43:27 -07002975// Test that setting the same options doesn't result in the encoder being
2976// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07002977TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07002978 VideoOptions options;
Tommi85959932018-02-07 19:26:06 +01002979 FakeVideoCapturerWithTaskQueue capturer;
deadbeef119760a2016-04-04 11:43:27 -07002980
perkjfa10b552016-10-02 23:45:26 -07002981 AddSendStream();
deadbeef119760a2016-04-04 11:43:27 -07002982 EXPECT_EQ(cricket::CS_RUNNING,
2983 capturer.Start(capturer.GetSupportedFormats()->front()));
perkjfa10b552016-10-02 23:45:26 -07002984 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002985 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07002986 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2987 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2988
Niels Möllerff40b142018-04-09 08:49:14 +02002989 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
2990 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002991 EXPECT_TRUE(capturer.CaptureFrame());
perkjfa10b552016-10-02 23:45:26 -07002992 // Expect 1 reconfigurations at this point from the initial configuration.
2993 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07002994
2995 // Set the options one more time and expect no additional reconfigurations.
Niels Möllerff40b142018-04-09 08:49:14 +02002996 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkjfa10b552016-10-02 23:45:26 -07002997 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
2998
2999 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01003000 options.video_noise_reduction = true;
Niels Möllerff40b142018-04-09 08:49:14 +02003001 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07003002 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
3003
Niels Möllerff40b142018-04-09 08:49:14 +02003004 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07003005}
3006
eladalonf1841382017-06-12 01:16:46 -07003007class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02003008 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07003009 Vp9SettingsTest() : Vp9SettingsTest("") {}
3010 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07003011 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02003012 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003013 }
3014 virtual ~Vp9SettingsTest() {}
3015
3016 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003017 void TearDown() override {
3018 // Remove references to encoder_factory_ since this will be destroyed
3019 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003020 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003021 }
Erik Språng143cec12015-04-28 10:01:41 +02003022};
3023
3024TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003025 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003026 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003027 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003028
Peter Boström2feafdb2015-09-09 14:32:14 +02003029 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003030
Tommi85959932018-02-07 19:26:06 +01003031 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02003032 EXPECT_EQ(cricket::CS_RUNNING,
3033 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003034 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02003035 channel_->SetSend(true);
3036
3037 EXPECT_TRUE(capturer.CaptureFrame());
3038
pbos4cba4eb2015-10-26 11:18:18 -07003039 webrtc::VideoCodecVP9 vp9_settings;
3040 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003041 EXPECT_TRUE(vp9_settings.denoisingOn)
3042 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003043
nisse05103312016-03-16 02:22:50 -07003044 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003045
Erik Språng143cec12015-04-28 10:01:41 +02003046 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3047 EXPECT_FALSE(vp9_settings.denoisingOn);
3048 // Frame dropping always on for real time video.
3049 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3050
nisse05103312016-03-16 02:22:50 -07003051 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02003052
3053 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3054 EXPECT_TRUE(vp9_settings.denoisingOn);
3055 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3056
3057 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003058 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003059 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02003060 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003061
nisse05103312016-03-16 02:22:50 -07003062 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003063
3064 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3065 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003066 // Frame dropping always on for screen sharing.
3067 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003068
nisse05103312016-03-16 02:22:50 -07003069 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003070
3071 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3072 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003073 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003074
Niels Möllerff40b142018-04-09 08:49:14 +02003075 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003076}
3077
Sergey Silkinf18072e2018-03-14 10:35:35 +01003078TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3079 cricket::VideoSendParameters parameters;
3080 parameters.codecs.push_back(GetEngineCodec("VP9"));
3081 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3082
3083 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3084
3085 FakeVideoSendStream* stream =
3086 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3087
3088 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3089 EXPECT_EQ(ssrcs.size(), config.rtp.ssrcs.size());
3090
3091 FakeVideoCapturerWithTaskQueue capturer;
3092 EXPECT_EQ(cricket::CS_RUNNING,
3093 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003094 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &capturer));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003095 channel_->SetSend(true);
3096
3097 EXPECT_TRUE(capturer.CaptureFrame());
3098
3099 webrtc::VideoCodecVP9 vp9_settings;
3100 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3101
3102 const size_t kNumSpatialLayers = ssrcs.size();
3103 const size_t kNumTemporalLayers = 3;
3104 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3105 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3106
Niels Möllerff40b142018-04-09 08:49:14 +02003107 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003108}
3109
asaperssonc5dabdd2016-03-21 04:15:50 -07003110class Vp9SettingsTestWithFieldTrial : public Vp9SettingsTest {
3111 public:
brandtr468da7c2016-11-22 02:16:47 -08003112 explicit Vp9SettingsTestWithFieldTrial(const char* field_trials)
asaperssonc5dabdd2016-03-21 04:15:50 -07003113 : Vp9SettingsTest(field_trials) {}
3114
3115 protected:
3116 void VerifySettings(int num_spatial_layers, int num_temporal_layers) {
3117 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003118 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003119 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3120
3121 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3122
Tommi85959932018-02-07 19:26:06 +01003123 FakeVideoCapturerWithTaskQueue capturer;
asaperssonc5dabdd2016-03-21 04:15:50 -07003124 EXPECT_EQ(cricket::CS_RUNNING,
3125 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003126 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
asaperssonc5dabdd2016-03-21 04:15:50 -07003127 channel_->SetSend(true);
3128
3129 EXPECT_TRUE(capturer.CaptureFrame());
3130
3131 webrtc::VideoCodecVP9 vp9_settings;
3132 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3133 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3134 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
3135
Niels Möllerff40b142018-04-09 08:49:14 +02003136 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003137 }
3138};
3139
3140class Vp9SettingsTestWithNoFlag : public Vp9SettingsTestWithFieldTrial {
3141 public:
3142 Vp9SettingsTestWithNoFlag() : Vp9SettingsTestWithFieldTrial("") {}
3143};
3144
3145TEST_F(Vp9SettingsTestWithNoFlag, VerifySettings) {
3146 const int kNumSpatialLayers = 1;
3147 const int kNumTemporalLayers = 1;
3148 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3149}
3150
3151class Vp9SettingsTestWithInvalidFlag : public Vp9SettingsTestWithFieldTrial {
3152 public:
3153 Vp9SettingsTestWithInvalidFlag()
3154 : Vp9SettingsTestWithFieldTrial("WebRTC-SupportVP9SVC/Default/") {}
3155};
3156
3157TEST_F(Vp9SettingsTestWithInvalidFlag, VerifySettings) {
3158 const int kNumSpatialLayers = 1;
3159 const int kNumTemporalLayers = 1;
3160 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3161}
3162
3163class Vp9SettingsTestWith2SL3TLFlag : public Vp9SettingsTestWithFieldTrial {
3164 public:
3165 Vp9SettingsTestWith2SL3TLFlag()
3166 : Vp9SettingsTestWithFieldTrial(
3167 "WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/") {}
3168};
3169
3170TEST_F(Vp9SettingsTestWith2SL3TLFlag, VerifySettings) {
3171 const int kNumSpatialLayers = 2;
3172 const int kNumTemporalLayers = 3;
3173 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3174}
3175
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003176TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3177 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3178 ASSERT_EQ(1u, streams.size());
3179 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3180}
3181
3182TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
3183 webrtc::test::ScopedFieldTrials override_field_trials_(
3184 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3185 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3186 ASSERT_EQ(1u, streams.size());
3187 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3188}
3189
asapersson3c81a1a2017-06-14 05:52:21 -07003190TEST_F(WebRtcVideoChannelTest,
3191 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
3192 webrtc::test::ScopedFieldTrials override_field_trials_(
3193 "WebRTC-Video-BalancedDegradation/Disabled/");
3194 const bool kResolutionScalingEnabled = true;
3195 const bool kFpsScalingEnabled = false;
3196 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3197}
3198
3199TEST_F(WebRtcVideoChannelTest,
3200 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
3201 webrtc::test::ScopedFieldTrials override_field_trials_(
3202 "WebRTC-Video-BalancedDegradation/Enabled/");
3203 const bool kResolutionScalingEnabled = true;
3204 const bool kFpsScalingEnabled = true;
3205 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3206}
3207
eladalonf1841382017-06-12 01:16:46 -07003208TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003209 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003210}
3211
eladalonf1841382017-06-12 01:16:46 -07003212TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003213 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003214}
3215
eladalonf1841382017-06-12 01:16:46 -07003216TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003217 TestCpuAdaptation(true, true);
3218}
3219
eladalonf1841382017-06-12 01:16:46 -07003220TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruseAndChangeResolution) {
magjed509e4fe2016-11-18 01:34:11 -08003221 cricket::VideoCodec codec = GetEngineCodec("VP8");
perkj2d5f0912016-02-29 00:04:41 -08003222 cricket::VideoSendParameters parameters;
3223 parameters.codecs.push_back(codec);
3224
kthelgason2bc68642017-02-07 07:02:22 -08003225 MediaConfig media_config = GetMediaConfig();
Sebastian Jansson84848f22018-11-16 10:40:36 +01003226 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003227 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003228 channel_->OnReadyToSend(true);
perkj2d5f0912016-02-29 00:04:41 -08003229 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3230
3231 AddSendStream();
3232
Tommi85959932018-02-07 19:26:06 +01003233 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003234 ASSERT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003235 ASSERT_EQ(cricket::CS_RUNNING,
3236 capturer.Start(capturer.GetSupportedFormats()->front()));
3237 ASSERT_TRUE(channel_->SetSend(true));
3238
3239 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3240 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003241
Niels Möllera6cc0f92018-02-12 17:14:55 +01003242 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003243 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3244 EXPECT_EQ(1280, send_stream->GetLastWidth());
3245 EXPECT_EQ(720, send_stream->GetLastHeight());
3246
3247 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003248 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003249 wants.max_pixel_count =
3250 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003251 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003252 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003253 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3254 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3255 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3256
3257 // Trigger overuse again.
sprangc5d62e22017-04-02 23:53:04 -07003258 wants.max_pixel_count =
3259 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003260 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003261 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003262 EXPECT_EQ(3, send_stream->GetNumberOfSwappedFrames());
3263 EXPECT_EQ(1280 * 2 / 4, send_stream->GetLastWidth());
3264 EXPECT_EQ(720 * 2 / 4, send_stream->GetLastHeight());
3265
3266 // Change input resolution.
Niels Möllera6cc0f92018-02-12 17:14:55 +01003267 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003268 EXPECT_EQ(4, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003269 EXPECT_EQ(1284 / 2, send_stream->GetLastWidth());
3270 EXPECT_EQ(724 / 2, send_stream->GetLastHeight());
3271
3272 // Trigger underuse which should go back up in resolution.
sprang84a37592017-02-10 07:04:27 -08003273 int current_pixel_count =
3274 send_stream->GetLastWidth() * send_stream->GetLastHeight();
3275 // Cap the max to 4x the pixel count (assuming max 1/2 x 1/2 scale downs)
3276 // of the current stream, so we don't take too large steps.
sprangc5d62e22017-04-02 23:53:04 -07003277 wants.max_pixel_count = current_pixel_count * 4;
sprang84a37592017-02-10 07:04:27 -08003278 // Default step down is 3/5 pixel count, so go up by 5/3.
Oskar Sundbom78807582017-11-16 11:09:55 +01003279 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003280 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003281 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003282 EXPECT_EQ(5, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003283 EXPECT_EQ(1284 * 3 / 4, send_stream->GetLastWidth());
3284 EXPECT_EQ(724 * 3 / 4, send_stream->GetLastHeight());
3285
sprang84a37592017-02-10 07:04:27 -08003286 // Trigger underuse again, should go back up to full resolution.
3287 current_pixel_count =
3288 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003289 wants.max_pixel_count = current_pixel_count * 4;
Oskar Sundbom78807582017-11-16 11:09:55 +01003290 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003291 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003292 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003293 EXPECT_EQ(6, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003294 EXPECT_EQ(1284, send_stream->GetLastWidth());
3295 EXPECT_EQ(724, send_stream->GetLastHeight());
3296
Niels Möllerff40b142018-04-09 08:49:14 +02003297 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003298}
3299
eladalonf1841382017-06-12 01:16:46 -07003300TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003301 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003302 cricket::VideoSendParameters parameters;
3303 parameters.codecs.push_back(codec);
3304
kthelgason2bc68642017-02-07 07:02:22 -08003305 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003306 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003307 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003308 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003309 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003310 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3311
3312 AddSendStream();
3313
Tommi85959932018-02-07 19:26:06 +01003314 FakeVideoCapturerWithTaskQueue capturer;
Per766ad3b2016-04-05 15:23:49 +02003315 ASSERT_EQ(cricket::CS_RUNNING,
3316 capturer.Start(capturer.GetSupportedFormats()->front()));
3317 ASSERT_TRUE(channel_->SetSend(true));
3318 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003319 camera_options.is_screencast = false;
Yves Gerey665174f2018-06-19 15:03:05 +02003320 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
Per766ad3b2016-04-05 15:23:49 +02003321
3322 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3323 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003324
Niels Möllera6cc0f92018-02-12 17:14:55 +01003325 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003326 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3327 EXPECT_EQ(1280, send_stream->GetLastWidth());
3328 EXPECT_EQ(720, send_stream->GetLastHeight());
3329
3330 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003331 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003332 wants.max_pixel_count =
3333 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003334 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003335 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003336 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3337 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3338 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3339
3340 // Switch to screen share. Expect no CPU adaptation.
Tommi85959932018-02-07 19:26:06 +01003341 FakeVideoCapturerWithTaskQueue screen_share(true);
Per766ad3b2016-04-05 15:23:49 +02003342 ASSERT_EQ(cricket::CS_RUNNING,
3343 screen_share.Start(screen_share.GetSupportedFormats()->front()));
Per766ad3b2016-04-05 15:23:49 +02003344 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003345 screenshare_options.is_screencast = true;
Yves Gerey665174f2018-06-19 15:03:05 +02003346 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &screen_share);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003347 EXPECT_TRUE(screen_share.CaptureCustomFrame(1284, 724));
sprangf24a0642017-02-28 13:23:26 -08003348 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3349 send_stream = fake_call_->GetVideoSendStreams().front();
3350 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003351 EXPECT_EQ(1284, send_stream->GetLastWidth());
3352 EXPECT_EQ(724, send_stream->GetLastHeight());
3353
3354 // Switch back to the normal capturer. Expect the frame to be CPU adapted.
Yves Gerey665174f2018-06-19 15:03:05 +02003355 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
sprangf24a0642017-02-28 13:23:26 -08003356 send_stream = fake_call_->GetVideoSendStreams().front();
3357 // We have a new fake send stream, so it doesn't remember the old sink wants.
3358 // In practice, it will be populated from
mflodmancc3d4422017-08-03 08:27:51 -07003359 // VideoStreamEncoder::VideoSourceProxy::SetSource(), so simulate that here.
sprangf24a0642017-02-28 13:23:26 -08003360 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003361 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
sprangf24a0642017-02-28 13:23:26 -08003362 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3363 send_stream = fake_call_->GetVideoSendStreams().front();
3364 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003365 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3366 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3367
Niels Möllerff40b142018-04-09 08:49:14 +02003368 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003369}
3370
asapersson3c81a1a2017-06-14 05:52:21 -07003371// TODO(asapersson): Remove this test when the balanced field trial is removed.
3372void WebRtcVideoChannelTest::TestDegradationPreference(
3373 bool resolution_scaling_enabled,
3374 bool fps_scaling_enabled) {
3375 cricket::VideoCodec codec = GetEngineCodec("VP8");
3376 cricket::VideoSendParameters parameters;
3377 parameters.codecs.push_back(codec);
3378
3379 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003380 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003381 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003382 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
asapersson3c81a1a2017-06-14 05:52:21 -07003383 channel_->OnReadyToSend(true);
3384
3385 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3386
3387 AddSendStream();
3388
Tommi85959932018-02-07 19:26:06 +01003389 FakeVideoCapturerWithTaskQueue capturer;
asapersson3c81a1a2017-06-14 05:52:21 -07003390 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02003391 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
asapersson3c81a1a2017-06-14 05:52:21 -07003392 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
3393 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
3394
3395 EXPECT_TRUE(channel_->SetSend(true));
3396
3397 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3398 EXPECT_EQ(resolution_scaling_enabled,
3399 send_stream->resolution_scaling_enabled());
3400 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3401
Niels Möllerff40b142018-04-09 08:49:14 +02003402 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003403}
3404
eladalonf1841382017-06-12 01:16:46 -07003405void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3406 bool is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003407 const int kDefaultFps = 30;
magjed509e4fe2016-11-18 01:34:11 -08003408 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003409 cricket::VideoSendParameters parameters;
3410 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003411
kthelgason2bc68642017-02-07 07:02:22 -08003412 MediaConfig media_config = GetMediaConfig();
3413 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003414 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003415 }
Sebastian Jansson84848f22018-11-16 10:40:36 +01003416 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003417 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003418 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003419
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003420 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003421
3422 AddSendStream();
3423
Tommi85959932018-02-07 19:26:06 +01003424 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07003425 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003426 options.is_screencast = is_screenshare;
Niels Möllerff40b142018-04-09 08:49:14 +02003427 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj26752742016-10-24 01:21:16 -07003428 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
sprangc5d62e22017-04-02 23:53:04 -07003429 capture_format.interval = rtc::kNumNanosecsPerSec / kDefaultFps;
perkj26752742016-10-24 01:21:16 -07003430 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003431
3432 EXPECT_TRUE(channel_->SetSend(true));
3433
solenberge5269742015-09-08 05:13:22 -07003434 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003435
sprangc5d62e22017-04-02 23:53:04 -07003436 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003437 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003438 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3439 EXPECT_EQ(is_screenshare, send_stream->framerate_scaling_enabled());
perkj2d5f0912016-02-29 00:04:41 -08003440
3441 EXPECT_TRUE(capturer.CaptureFrame());
3442 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3443
perkj26752742016-10-24 01:21:16 -07003444 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3445 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
perkj2d5f0912016-02-29 00:04:41 -08003446
Niels Möllerff40b142018-04-09 08:49:14 +02003447 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003448 return;
3449 }
3450
sprangc5d62e22017-04-02 23:53:04 -07003451 if (is_screenshare) {
3452 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3453 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3454 } else {
3455 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3456 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3457 }
3458
perkj803d97f2016-11-01 11:45:46 -07003459 // Trigger overuse.
3460 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3461
3462 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003463 if (is_screenshare) {
3464 wants.max_framerate_fps = (kDefaultFps * 2) / 3;
3465 } else {
3466 wants.max_pixel_count = capture_format.width * capture_format.height - 1;
3467 }
perkj803d97f2016-11-01 11:45:46 -07003468 send_stream->InjectVideoSinkWants(wants);
3469
sprangc5d62e22017-04-02 23:53:04 -07003470 for (int i = 0; i < kDefaultFps; ++i)
3471 EXPECT_TRUE(capturer.CaptureFrame());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003472
sprangc5d62e22017-04-02 23:53:04 -07003473 if (is_screenshare) {
3474 // Drops every third frame.
3475 EXPECT_EQ(kDefaultFps * 2 / 3, send_stream->GetNumberOfSwappedFrames());
3476 EXPECT_EQ(send_stream->GetLastWidth(), capture_format.width);
3477 EXPECT_EQ(send_stream->GetLastHeight(), capture_format.height);
3478 } else {
3479 EXPECT_EQ(kDefaultFps, send_stream->GetNumberOfSwappedFrames());
3480 EXPECT_LT(send_stream->GetLastWidth(), capture_format.width);
3481 EXPECT_LT(send_stream->GetLastHeight(), capture_format.height);
3482 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003483
3484 // Trigger underuse which should go back to normal resolution.
sprang84a37592017-02-10 07:04:27 -08003485 int last_pixel_count =
3486 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003487 if (is_screenshare) {
3488 wants.max_framerate_fps = kDefaultFps;
3489 } else {
3490 wants.max_pixel_count = last_pixel_count * 4;
3491 wants.target_pixel_count.emplace((last_pixel_count * 5) / 3);
3492 }
perkj803d97f2016-11-01 11:45:46 -07003493 send_stream->InjectVideoSinkWants(wants);
3494
sprangc5d62e22017-04-02 23:53:04 -07003495 for (int i = 0; i < kDefaultFps; ++i)
3496 EXPECT_TRUE(capturer.CaptureFrame());
3497
3498 if (is_screenshare) {
3499 EXPECT_EQ(kDefaultFps + (kDefaultFps * 2 / 3),
3500 send_stream->GetNumberOfSwappedFrames());
3501 } else {
3502 EXPECT_EQ(kDefaultFps * 2, send_stream->GetNumberOfSwappedFrames());
3503 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003504
perkj26752742016-10-24 01:21:16 -07003505 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3506 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003507
Niels Möllerff40b142018-04-09 08:49:14 +02003508 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003509}
3510
eladalonf1841382017-06-12 01:16:46 -07003511TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003512 // Start at last timestamp to verify that wraparounds are estimated correctly.
3513 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3514 static const int64_t kInitialNtpTimeMs = 1247891230;
3515 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003516 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003517
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003518 FakeVideoReceiveStream* stream = AddRecvStream();
3519 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003520 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003521
nisse64ec8f82016-09-27 00:17:25 -07003522 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4),
3523 kInitialTimestamp, 0,
3524 webrtc::kVideoRotation_0);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003525 // Initial NTP time is not available on the first frame, but should still be
3526 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003527 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003528
3529 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003530
3531 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3532 // triggers a constant-overflow warning, hence we're calculating it explicitly
3533 // here.
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +02003534 fake_clock_.AdvanceTimeMicros(kFrameOffsetMs * rtc::kNumMicrosecsPerMillisec);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003535 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3536 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003537 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003538
3539 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003540
3541 // Verify that NTP time has been correctly deduced.
3542 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003543 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003544 ASSERT_EQ(1u, info.receivers.size());
3545 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003546}
3547
eladalonf1841382017-06-12 01:16:46 -07003548TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003549 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003550 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003551
3552 VideoCodec codec;
3553 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003554 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003555
3556 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003557 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3558 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003559 FakeVideoSendStream* stream = AddSendStream(
3560 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003561 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003562
3563 // Make sure NACK and FEC are enabled on the correct payload types.
3564 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003565 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3566 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003567
3568 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3569 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003570 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003571 // TODO(juberti): Check RTCP, PLI, TMMBR.
3572}
3573
brandtr31bd2242017-05-19 05:47:46 -07003574// The following four tests ensures that FlexFEC is not activated by default
3575// when the field trials are not enabled.
3576// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3577// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003578TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003579 FakeVideoSendStream* stream = AddSendStream();
3580 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3581
brandtr3d200bd2017-01-16 06:59:19 -08003582 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003583 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3584 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003585}
3586
eladalonf1841382017-06-12 01:16:46 -07003587TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003588 FakeVideoSendStream* stream = AddSendStream(
3589 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3590 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3591
brandtr3d200bd2017-01-16 06:59:19 -08003592 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003593 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3594 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3595}
3596
Yves Gerey665174f2018-06-19 15:03:05 +02003597TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003598 AddRecvStream();
3599
3600 const std::vector<FakeFlexfecReceiveStream*>& streams =
3601 fake_call_->GetFlexfecReceiveStreams();
3602 EXPECT_TRUE(streams.empty());
3603}
3604
eladalonf1841382017-06-12 01:16:46 -07003605TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003606 AddRecvStream(
3607 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3608
3609 const std::vector<FakeFlexfecReceiveStream*>& streams =
3610 fake_call_->GetFlexfecReceiveStreams();
3611 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003612}
3613
3614// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3615// tests that use this test fixture into the corresponding "non-field trial"
3616// tests.
eladalonf1841382017-06-12 01:16:46 -07003617class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003618 public:
eladalonf1841382017-06-12 01:16:46 -07003619 WebRtcVideoChannelFlexfecRecvTest()
3620 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003621};
3622
eladalonf1841382017-06-12 01:16:46 -07003623TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003624 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3625 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3626 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3627}
3628
eladalonf1841382017-06-12 01:16:46 -07003629TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003630 AddRecvStream();
3631
3632 const std::vector<FakeFlexfecReceiveStream*>& streams =
3633 fake_call_->GetFlexfecReceiveStreams();
3634 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003635
3636 const std::vector<FakeVideoReceiveStream*>& video_streams =
3637 fake_call_->GetVideoReceiveStreams();
3638 ASSERT_EQ(1U, video_streams.size());
3639 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3640 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3641 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003642}
3643
eladalonf1841382017-06-12 01:16:46 -07003644TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003645 AddRecvStream(
3646 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3647
3648 const std::vector<FakeFlexfecReceiveStream*>& streams =
3649 fake_call_->GetFlexfecReceiveStreams();
3650 ASSERT_EQ(1U, streams.size());
3651 const FakeFlexfecReceiveStream* stream = streams.front();
3652 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3653 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3654 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3655 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3656 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003657
3658 const std::vector<FakeVideoReceiveStream*>& video_streams =
3659 fake_call_->GetVideoReceiveStreams();
3660 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003661 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3662 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003663 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003664 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003665 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003666}
3667
eladalonf1841382017-06-12 01:16:46 -07003668TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003669 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3670 cricket::VideoRecvParameters recv_parameters;
3671 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3672 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3673
3674 AddRecvStream(
3675 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3676 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003677 const std::vector<FakeVideoReceiveStream*>& video_streams =
3678 fake_call_->GetVideoReceiveStreams();
3679 ASSERT_EQ(1U, video_streams.size());
3680 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3681 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3682 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003683
3684 // Enable FlexFEC.
3685 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3686 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3687 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3688 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3689 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3690 << "Enabling FlexFEC should not create VideoReceiveStream.";
3691 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3692 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003693 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3694 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003695}
3696
eladalonf1841382017-06-12 01:16:46 -07003697TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003698 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3699 cricket::VideoRecvParameters recv_parameters;
3700 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3701 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3702 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3703
3704 AddRecvStream(
3705 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3706 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003707 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003708 const std::vector<FakeVideoReceiveStream*>& video_streams =
3709 fake_call_->GetVideoReceiveStreams();
3710 ASSERT_EQ(1U, video_streams.size());
3711 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3712 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3713 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003714
3715 // Disable FlexFEC.
3716 recv_parameters.codecs.clear();
3717 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3718 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3719 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3720 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3721 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3722 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3723 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3724 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003725 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3726 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003727}
3728
brandtr31bd2242017-05-19 05:47:46 -07003729// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3730// tests that use this test fixture into the corresponding "non-field trial"
3731// tests.
eladalonf1841382017-06-12 01:16:46 -07003732class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003733 public:
eladalonf1841382017-06-12 01:16:46 -07003734 WebRtcVideoChannelFlexfecSendRecvTest()
3735 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003736 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3737 }
3738};
3739
Yves Gerey665174f2018-06-19 15:03:05 +02003740TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003741 FakeVideoSendStream* stream = AddSendStream();
3742 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3743
brandtr3d200bd2017-01-16 06:59:19 -08003744 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3745 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3746 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003747}
3748
eladalonf1841382017-06-12 01:16:46 -07003749TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003750 FakeVideoSendStream* stream = AddSendStream(
3751 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3752 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3753
brandtr3d200bd2017-01-16 06:59:19 -08003754 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3755 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3756 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3757 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003758}
3759
eladalonf1841382017-06-12 01:16:46 -07003760TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003761 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003762 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003763 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003764
3765 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003766 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003767
brandtrb5f2c3f2016-10-04 23:28:39 -07003768 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3769 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003770}
3771
eladalonf1841382017-06-12 01:16:46 -07003772TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003773 cricket::VideoSendParameters parameters;
3774 parameters.codecs.push_back(GetEngineCodec("VP8"));
3775 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3776
3777 FakeVideoSendStream* stream = AddSendStream();
3778 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3779
brandtr3d200bd2017-01-16 06:59:19 -08003780 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003781}
3782
eladalonf1841382017-06-12 01:16:46 -07003783TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003784 AddRecvStream(
3785 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003786
3787 cricket::VideoRecvParameters recv_parameters;
3788 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3789 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3790 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003791
3792 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3793 fake_call_->GetFlexfecReceiveStreams();
3794 ASSERT_EQ(1U, flexfec_streams.size());
3795 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3796 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3797 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003798 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003799 flexfec_stream_config.payload_type);
3800 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3801 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3802 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3803 const std::vector<FakeVideoReceiveStream*>& video_streams =
3804 fake_call_->GetVideoReceiveStreams();
3805 const FakeVideoReceiveStream* video_stream = video_streams.front();
3806 const webrtc::VideoReceiveStream::Config& video_stream_config =
3807 video_stream->GetConfig();
3808 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3809 flexfec_stream_config.local_ssrc);
3810 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3811 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3812 flexfec_stream_config.rtcp_send_transport);
3813 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3814 // spec-compliant way.
3815 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3816 flexfec_stream_config.transport_cc);
3817 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3818 EXPECT_EQ(video_stream_config.rtp.extensions,
3819 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003820}
3821
brandtr31bd2242017-05-19 05:47:46 -07003822// We should not send FlexFEC, even if we advertise it, unless the right
3823// field trial is set.
3824// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003825TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003826 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3827 cricket::VideoSendParameters parameters;
3828 parameters.codecs.push_back(GetEngineCodec("VP8"));
3829 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3830 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3831
3832 FakeVideoSendStream* stream = AddSendStream();
3833 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3834
3835 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003836 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003837 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3838}
3839
eladalonf1841382017-06-12 01:16:46 -07003840TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003841 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3842 cricket::VideoSendParameters parameters;
3843 parameters.codecs.push_back(GetEngineCodec("VP8"));
3844 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3845 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3846
3847 FakeVideoSendStream* stream = AddSendStream(
3848 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3849 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3850
3851 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003852 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003853 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3854}
3855
eladalonf1841382017-06-12 01:16:46 -07003856TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003857 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003858 const int kUnusedPayloadType = 127;
3859 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3860
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003861 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003862 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003863 parameters.codecs.push_back(rtx_codec);
3864 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003865 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003866}
3867
eladalonf1841382017-06-12 01:16:46 -07003868TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003869 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003870 const int kUnusedPayloadType1 = 126;
3871 const int kUnusedPayloadType2 = 127;
3872 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3873 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3874 {
3875 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3876 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3877 cricket::VideoSendParameters parameters;
3878 parameters.codecs.push_back(GetEngineCodec("VP8"));
3879 parameters.codecs.push_back(rtx_codec);
3880 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3881 }
3882 {
3883 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3884 kUnusedPayloadType1, kUnusedPayloadType2);
3885 cricket::VideoSendParameters parameters;
3886 parameters.codecs.push_back(GetEngineCodec("VP8"));
3887 parameters.codecs.push_back(rtx_codec);
3888 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3889 << "RTX without matching video codec should be rejected.";
3890 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003891}
3892
eladalonf1841382017-06-12 01:16:46 -07003893TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003894 const int kUnusedPayloadType1 = 126;
3895 const int kUnusedPayloadType2 = 127;
3896 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3897 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3898
3899 // SSRCs for RTX.
3900 cricket::StreamParams params =
3901 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3902 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3903 AddSendStream(params);
3904
3905 // Original payload type for RTX.
3906 cricket::VideoSendParameters parameters;
3907 parameters.codecs.push_back(GetEngineCodec("VP8"));
3908 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3909 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3910 parameters.codecs.push_back(rtx_codec);
3911 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3912 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3913 const webrtc::VideoSendStream::Config& config_before =
3914 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3915 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3916 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3917 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3918
3919 // Change payload type for RTX.
3920 parameters.codecs[1].id = kUnusedPayloadType2;
3921 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3922 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3923 const webrtc::VideoSendStream::Config& config_after =
3924 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3925 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3926 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3927 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3928}
3929
eladalonf1841382017-06-12 01:16:46 -07003930TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003931 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003932 parameters.codecs.push_back(GetEngineCodec("VP8"));
3933 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003934 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003935
3936 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003937 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003938
magjed509e4fe2016-11-18 01:34:11 -08003939 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003940
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003941 parameters.codecs.pop_back();
3942 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003943 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003944 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003945 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003946 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003947 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3948}
3949
eladalonf1841382017-06-12 01:16:46 -07003950TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003951 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003952 cricket::VideoSendParameters parameters;
3953 parameters.codecs.push_back(GetEngineCodec("VP8"));
3954 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3955 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3956
3957 FakeVideoSendStream* stream = AddSendStream(
3958 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3959 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3960
brandtr3d200bd2017-01-16 06:59:19 -08003961 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3962 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003963 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3964 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
3965
3966 parameters.codecs.pop_back();
3967 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3968 stream = fake_call_->GetVideoSendStreams()[0];
3969 ASSERT_TRUE(stream != nullptr);
3970 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08003971 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003972 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003973}
3974
eladalonf1841382017-06-12 01:16:46 -07003975TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003976 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07003977 cricket::VideoCodec codec(100, "VP8");
3978 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
3979 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07003980
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003981 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003982 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003983
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003984 FakeVideoSendStream* stream = AddSendStream();
Tommi85959932018-02-07 19:26:06 +01003985 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003986 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003987
3988 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003989 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003990
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003991 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07003992 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
3993 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003994 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003995 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003996 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02003997 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003998}
3999
eladalonf1841382017-06-12 01:16:46 -07004000TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004001 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4002 200000);
4003}
4004
eladalonf1841382017-06-12 01:16:46 -07004005TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00004006 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
4007 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
4008 ASSERT_EQ(1u, streams.size());
4009 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
4010}
4011
eladalonf1841382017-06-12 01:16:46 -07004012TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00004013 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004014 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00004015}
4016
eladalonf1841382017-06-12 01:16:46 -07004017TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004018 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004019}
4020
eladalonf1841382017-06-12 01:16:46 -07004021TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004022 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
4023 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
4024 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004025}
4026
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004027// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4028// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07004029TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004030 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4031 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4032 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4033 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004034 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004035 ExpectSetBitrateParameters(100000, 200000, 400000);
4036 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4037 // Since the codec isn't changing, start_bitrate_bps should be -1.
4038 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004039
4040 // Decrease max_bandwidth_bps.
4041 send_parameters_.max_bandwidth_bps = 350000;
4042 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004043
4044 // Now try again with the values flipped around.
4045 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4046 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004047 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004048 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004049
4050 // If we change the codec max, max_bandwidth_bps should still apply.
4051 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004052 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004053 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004054}
4055
Yves Gerey665174f2018-06-19 15:03:05 +02004056TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004057 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4058 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004059 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004060 // Setting max bitrate should keep previous min bitrate.
4061 // Setting max bitrate should not reset start bitrate.
4062 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004063 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004064}
4065
eladalonf1841382017-06-12 01:16:46 -07004066TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004067 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004068 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004069 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004070 // -1 means to disable max bitrate (set infinite).
4071 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004072 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004073 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004074}
4075
eladalonf1841382017-06-12 01:16:46 -07004076TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004077 send_parameters_.max_bandwidth_bps = 99999;
4078 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004079 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004080 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004081 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4082 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4083 stream->GetVideoStreams()[0].max_bitrate_bps);
4084
4085 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004086 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004087 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4088 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004089 stream->GetVideoStreams()[0].max_bitrate_bps);
4090}
4091
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004092// Tests that when the codec specific max bitrate and VideoSendParameters
4093// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4094// appropriately.
4095TEST_F(WebRtcVideoChannelTest,
4096 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4097 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4098 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4099 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4100 send_parameters_.max_bandwidth_bps = -1;
4101 AddSendStream();
4102 ExpectSetMaxBitrate(300000);
4103 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4104
4105 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4106 ASSERT_EQ(1u, video_send_streams.size());
4107 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4108 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4109 // First the max bitrate is set based upon the codec param.
4110 EXPECT_EQ(300000,
4111 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4112
4113 // The VideoSendParameters max bitrate overrides the codec's.
4114 send_parameters_.max_bandwidth_bps = 500000;
4115 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4116 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4117 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4118 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4119}
4120
4121// Tests that when the codec specific max bitrate and RtpParameters
4122// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4123// appropriately.
4124TEST_F(WebRtcVideoChannelTest,
4125 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4126 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4127 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4128 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4129 send_parameters_.max_bandwidth_bps = -1;
4130 AddSendStream();
4131 ExpectSetMaxBitrate(300000);
4132 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4133
4134 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4135 ASSERT_EQ(1u, video_send_streams.size());
4136 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4137 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4138 // First the max bitrate is set based upon the codec param.
4139 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4140
4141 // The RtpParameter max bitrate overrides the codec's.
4142 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4143 ASSERT_EQ(1u, parameters.encodings.size());
4144 parameters.encodings[0].max_bitrate_bps = 500000;
4145 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4146 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4147 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4148 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4149}
4150
Åsa Persson55659812018-06-18 17:51:32 +02004151TEST_F(WebRtcVideoChannelTest,
4152 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4153 send_parameters_.max_bandwidth_bps = 99999;
4154 FakeVideoSendStream* stream = AddSendStream();
4155 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4156 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4157 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4158 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4159 stream->GetVideoStreams()[0].max_bitrate_bps);
4160
4161 // Get and set the rtp encoding parameters.
4162 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4163 EXPECT_EQ(1u, parameters.encodings.size());
4164
4165 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4166 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4167 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4168 stream->GetVideoStreams()[0].max_bitrate_bps);
4169
4170 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4171 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4172 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4173 stream->GetVideoStreams()[0].max_bitrate_bps);
4174}
4175
eladalonf1841382017-06-12 01:16:46 -07004176TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004177 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004178 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004179 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004180 channel_->SetSend(true);
4181
4182 FakeVideoSendStream* stream = AddSendStream();
4183
Tommi85959932018-02-07 19:26:06 +01004184 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004185 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Peter Boström3afc8c42016-01-27 16:45:21 +01004186 EXPECT_EQ(cricket::CS_RUNNING,
4187 capturer.Start(capturer.GetSupportedFormats()->front()));
4188
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004189 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4190 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4191 EXPECT_GT(initial_max_bitrate_bps, 0);
4192
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004193 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4194 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004195 // Insert a frame to update the encoder config.
4196 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004197 streams = stream->GetVideoStreams();
4198 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004199 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004200}
4201
eladalonf1841382017-06-12 01:16:46 -07004202TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004203 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004204 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004205 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004206 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004207 channel_->SetSend(true);
4208
4209 FakeVideoSendStream* stream = AddSendStream(
4210 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4211
4212 // Send a frame to make sure this scales up to >1 stream (simulcast).
Tommi85959932018-02-07 19:26:06 +01004213 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004214 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &capturer));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004215 EXPECT_EQ(cricket::CS_RUNNING,
4216 capturer.Start(capturer.GetSupportedFormats()->front()));
4217 EXPECT_TRUE(capturer.CaptureFrame());
4218
4219 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4220 ASSERT_GT(streams.size(), 1u)
4221 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004222 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004223 EXPECT_GT(initial_max_bitrate_bps, 0);
4224
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004225 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4226 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004227 // Insert a frame to update the encoder config.
4228 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004229 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004230 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004231 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4232
Niels Möllerff40b142018-04-09 08:49:14 +02004233 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004234}
4235
eladalonf1841382017-06-12 01:16:46 -07004236TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004237 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004238 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004239 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004240 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4241 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004242 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004243 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004244
4245 VideoCodec codec;
4246 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4247 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4248}
4249
eladalonf1841382017-06-12 01:16:46 -07004250TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004251 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004252 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004253 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004254 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004255 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004256 parameters.codecs[0].id = kIncorrectPayloads[i];
4257 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004258 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004259 }
4260}
4261
eladalonf1841382017-06-12 01:16:46 -07004262TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004263 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004264 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004265 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004266 parameters.codecs[0].id = payload_type;
4267 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004268 << "Payload type '" << payload_type << "' rejected.";
4269 }
4270}
4271
deadbeef67cf2c12016-04-13 10:07:16 -07004272// Test that setting the a different set of codecs but with an identical front
4273// codec doesn't result in the stream being recreated.
4274// This may happen when a subsequent negotiation includes fewer codecs, as a
4275// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004276TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004277 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4278 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004279 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4280 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004281 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4282
4283 AddSendStream();
4284 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4285
4286 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004287 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004288 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4289 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4290}
4291
eladalonf1841382017-06-12 01:16:46 -07004292TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004293 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004294 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004295 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004296}
4297
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004298// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004299TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004300 const int kUnusedPayloadType1 = 126;
4301 const int kUnusedPayloadType2 = 127;
4302 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4303 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4304
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004305 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004306 parameters.codecs.push_back(GetEngineCodec("VP8"));
4307 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004308 parameters.codecs.push_back(rtx_codec);
4309 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004310 << "RTX codec without associated payload should be rejected.";
4311
magjed509e4fe2016-11-18 01:34:11 -08004312 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004313 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004314 << "RTX codec with invalid associated payload type should be rejected.";
4315
magjed509e4fe2016-11-18 01:34:11 -08004316 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004317 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004318
magjed509e4fe2016-11-18 01:34:11 -08004319 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004320 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004321 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004322
Yves Gerey665174f2018-06-19 15:03:05 +02004323 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4324 << "RTX codec with another RTX as associated payload type should be "
4325 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004326}
4327
eladalonf1841382017-06-12 01:16:46 -07004328TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004329 const int kUnusedPayloadType1 = 126;
4330 const int kUnusedPayloadType2 = 127;
4331 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4332 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4333
4334 // SSRCs for RTX.
4335 cricket::StreamParams params =
4336 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4337 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4338 AddRecvStream(params);
4339
4340 // Original payload type for RTX.
4341 cricket::VideoRecvParameters parameters;
4342 parameters.codecs.push_back(GetEngineCodec("VP8"));
4343 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4344 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4345 parameters.codecs.push_back(rtx_codec);
4346 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4347 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4348 const webrtc::VideoReceiveStream::Config& config_before =
4349 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004350 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4351 const int* payload_type_before = FindKeyByValue(
4352 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4353 ASSERT_NE(payload_type_before, nullptr);
4354 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004355 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4356
4357 // Change payload type for RTX.
4358 parameters.codecs[1].id = kUnusedPayloadType2;
4359 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4360 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4361 const webrtc::VideoReceiveStream::Config& config_after =
4362 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004363 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4364 const int* payload_type_after = FindKeyByValue(
4365 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4366 ASSERT_NE(payload_type_after, nullptr);
4367 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004368 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4369}
4370
eladalonf1841382017-06-12 01:16:46 -07004371TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004372 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004373 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004374 parameters.codecs[0].id = 99;
4375 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004376}
4377
eladalonf1841382017-06-12 01:16:46 -07004378TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004379 cricket::VideoRecvParameters parameters;
4380 parameters.codecs = engine_.codecs();
4381 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004382
4383 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004384 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004385 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004386 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004387}
4388
eladalonf1841382017-06-12 01:16:46 -07004389TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004390 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004391 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004392 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004393 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004394}
4395
eladalonf1841382017-06-12 01:16:46 -07004396TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004397 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004398 parameters.codecs.push_back(GetEngineCodec("VP8"));
4399 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004400 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004401}
4402
eladalonf1841382017-06-12 01:16:46 -07004403TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004404 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004405 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4406 send_parameters.codecs.push_back(GetEngineCodec("red"));
4407 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004408 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004409
4410 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004411
magjed509e4fe2016-11-18 01:34:11 -08004412 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004413 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004414
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004415 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004416 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004417 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004418 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004419 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004420 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004421 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4422}
4423
eladalonf1841382017-06-12 01:16:46 -07004424TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004425 AddRecvStream(
4426 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004427 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004428 fake_call_->GetFlexfecReceiveStreams();
4429
4430 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004431 const FakeFlexfecReceiveStream* stream = streams.front();
4432 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4433 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4434 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4435 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004436
4437 cricket::VideoRecvParameters recv_parameters;
4438 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4439 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4440 EXPECT_TRUE(streams.empty())
4441 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004442}
4443
eladalonf1841382017-06-12 01:16:46 -07004444TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004445 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004446 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004447 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004448
4449 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004450 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4451 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4452 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004453 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4454 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004455 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004456 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004457 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004458 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004459
4460 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004461 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4462 send_parameters.codecs.push_back(GetEngineCodec("red"));
4463 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004464 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4465 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004466 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004467 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004468 << "ULPFEC should be enabled on the receive stream.";
4469}
4470
eladalonf1841382017-06-12 01:16:46 -07004471TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004472 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004473 AddRecvStream(
4474 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004475 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004476 fake_call_->GetFlexfecReceiveStreams();
4477
4478 cricket::VideoRecvParameters recv_parameters;
4479 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4480 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4481 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4482 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004483 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004484 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004485 stream_with_recv_params->GetConfig().payload_type);
4486 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004487 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004488 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004489 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004490 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004491
4492 cricket::VideoSendParameters send_parameters;
4493 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4494 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4495 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4496 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004497 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004498 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004499 stream_with_send_params->GetConfig().payload_type);
4500 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004501 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004502 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004503 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004504 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004505}
4506
eladalonf1841382017-06-12 01:16:46 -07004507TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004508 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004509 parameters.codecs.push_back(GetEngineCodec("VP8"));
4510 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004511 parameters.codecs[1].id = parameters.codecs[0].id;
4512 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004513}
4514
eladalonf1841382017-06-12 01:16:46 -07004515TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004516 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004517 cricket::VideoRecvParameters parameters;
4518 parameters.codecs.push_back(GetEngineCodec("VP8"));
4519 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4520 parameters.codecs[1].id = parameters.codecs[0].id;
4521 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4522}
4523
eladalonf1841382017-06-12 01:16:46 -07004524TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004525 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004526 parameters.codecs.push_back(GetEngineCodec("VP8"));
4527 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004528 parameters.codecs[1].id = parameters.codecs[0].id;
4529 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004530}
4531
eladalonf1841382017-06-12 01:16:46 -07004532TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004533 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004534 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004535 parameters.codecs.push_back(GetEngineCodec("VP8"));
4536 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004537 parameters.codecs[1].id += 1;
4538 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004539}
4540
deadbeef67cf2c12016-04-13 10:07:16 -07004541// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004542// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004543TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004544 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004545 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004546 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4547 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004548 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004549
4550 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4551 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4552
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004553 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004554 parameters2.codecs.push_back(GetEngineCodec("red"));
4555 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004556 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004557 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4558}
4559
eladalonf1841382017-06-12 01:16:46 -07004560TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004561 EXPECT_FALSE(AddSendStream()->IsSending());
4562}
4563
eladalonf1841382017-06-12 01:16:46 -07004564TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004565 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004566}
4567
eladalonf1841382017-06-12 01:16:46 -07004568TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004569 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004570 EXPECT_FALSE(stream->IsSending());
4571
4572 // false->true
4573 EXPECT_TRUE(channel_->SetSend(true));
4574 EXPECT_TRUE(stream->IsSending());
4575 // true->true
4576 EXPECT_TRUE(channel_->SetSend(true));
4577 EXPECT_TRUE(stream->IsSending());
4578 // true->false
4579 EXPECT_TRUE(channel_->SetSend(false));
4580 EXPECT_FALSE(stream->IsSending());
4581 // false->false
4582 EXPECT_TRUE(channel_->SetSend(false));
4583 EXPECT_FALSE(stream->IsSending());
4584
4585 EXPECT_TRUE(channel_->SetSend(true));
4586 FakeVideoSendStream* new_stream = AddSendStream();
4587 EXPECT_TRUE(new_stream->IsSending())
4588 << "Send stream created after SetSend(true) not sending initially.";
4589}
4590
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004591// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004592TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004593 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004594 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004595 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004596 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004597 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004598
Sebastian Jansson84848f22018-11-16 10:40:36 +01004599 channel.reset(
4600 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4601 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004602 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004603 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004604 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004605
Tim Haloun648d28a2018-10-18 16:52:22 -07004606 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4607 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004608 config.enable_dscp = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004609 channel.reset(
4610 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4611 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004612 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
Tim Haloun648d28a2018-10-18 16:52:22 -07004613 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4614
4615 // Create a send stream to configure
4616 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4617 parameters = channel->GetRtpSendParameters(kSsrc);
4618 ASSERT_FALSE(parameters.encodings.empty());
4619
4620 // Various priorities map to various dscp values.
4621 parameters.encodings[0].network_priority = 4.0;
4622 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004623 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004624 parameters.encodings[0].network_priority = 0.5;
4625 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4626 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4627
4628 // A bad priority does not change the dscp value.
4629 parameters.encodings[0].network_priority = 0.0;
4630 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4631 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004632
Tim Haloun6ca98362018-09-17 17:06:08 -07004633 // Packets should also self-identify their dscp in PacketOptions.
4634 const uint8_t kData[10] = {0};
4635 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4636 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004637 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004638
nisse51542be2016-02-12 02:27:06 -08004639 // Verify that setting the option to false resets the
4640 // DiffServCodePoint.
4641 config.enable_dscp = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004642 channel.reset(
4643 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4644 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004645 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004646 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004647}
4648
deadbeef13871492015-12-09 12:37:51 -08004649// This test verifies that the RTCP reduced size mode is properly applied to
4650// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004651TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004652 // Create stream, expecting that default mode is "compound".
4653 FakeVideoSendStream* stream1 = AddSendStream();
4654 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004655 webrtc::RtpParameters rtp_parameters =
4656 channel_->GetRtpSendParameters(last_ssrc_);
4657 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004658
4659 // Now enable reduced size mode.
4660 send_parameters_.rtcp.reduced_size = true;
4661 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4662 stream1 = fake_call_->GetVideoSendStreams()[0];
4663 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004664 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4665 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004666
4667 // Create a new stream and ensure it picks up the reduced size mode.
4668 FakeVideoSendStream* stream2 = AddSendStream();
4669 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4670}
4671
4672// This test verifies that the RTCP reduced size mode is properly applied to
4673// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004674TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004675 // Create stream, expecting that default mode is "compound".
4676 FakeVideoReceiveStream* stream1 = AddRecvStream();
4677 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4678
4679 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004680 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4681 // the reduced_size flag should come from that.
4682 send_parameters_.rtcp.reduced_size = true;
4683 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004684 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4685 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4686
4687 // Create a new stream and ensure it picks up the reduced size mode.
4688 FakeVideoReceiveStream* stream2 = AddRecvStream();
4689 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4690}
4691
eladalonf1841382017-06-12 01:16:46 -07004692TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004693 EXPECT_EQ(webrtc::kNetworkUp,
4694 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4695 EXPECT_EQ(webrtc::kNetworkUp,
4696 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004697
4698 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004699 EXPECT_EQ(webrtc::kNetworkDown,
4700 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4701 EXPECT_EQ(webrtc::kNetworkUp,
4702 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004703
4704 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004705 EXPECT_EQ(webrtc::kNetworkUp,
4706 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4707 EXPECT_EQ(webrtc::kNetworkUp,
4708 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004709}
4710
eladalonf1841382017-06-12 01:16:46 -07004711TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004712 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004713 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004714 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004715
4716 AddSendStream();
4717
4718 cricket::VideoMediaInfo info;
4719 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004720 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004721}
4722
eladalonf1841382017-06-12 01:16:46 -07004723TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004724 FakeVideoSendStream* stream = AddSendStream();
4725 webrtc::VideoSendStream::Stats stats;
4726 stats.encoder_implementation_name = "encoder_implementation_name";
4727 stream->SetStats(stats);
4728
4729 cricket::VideoMediaInfo info;
4730 ASSERT_TRUE(channel_->GetStats(&info));
4731 EXPECT_EQ(stats.encoder_implementation_name,
4732 info.senders[0].encoder_implementation_name);
4733}
4734
eladalonf1841382017-06-12 01:16:46 -07004735TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004736 FakeVideoSendStream* stream = AddSendStream();
4737 webrtc::VideoSendStream::Stats stats;
4738 stats.avg_encode_time_ms = 13;
4739 stats.encode_usage_percent = 42;
4740 stream->SetStats(stats);
4741
4742 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004743 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004744 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4745 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4746}
4747
eladalonf1841382017-06-12 01:16:46 -07004748TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004749 FakeVideoSendStream* stream = AddSendStream();
4750 webrtc::VideoSendStream::Stats stats;
4751 stats.frames_encoded = 13;
4752 stream->SetStats(stats);
4753
4754 cricket::VideoMediaInfo info;
4755 ASSERT_TRUE(channel_->GetStats(&info));
4756 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4757}
4758
eladalonf1841382017-06-12 01:16:46 -07004759TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004760 FakeVideoSendStream* stream = AddSendStream();
4761 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004762 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004763 stream->SetStats(stats);
4764
4765 cricket::VideoMediaInfo info;
4766 ASSERT_TRUE(channel_->GetStats(&info));
4767 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4768}
4769
eladalonf1841382017-06-12 01:16:46 -07004770TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004771 FakeVideoSendStream* stream = AddSendStream();
4772 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004773 stats.substreams[17].width = 123;
4774 stats.substreams[17].height = 40;
4775 stats.substreams[42].width = 80;
4776 stats.substreams[42].height = 31;
4777 stats.substreams[11].width = 20;
4778 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004779 stream->SetStats(stats);
4780
4781 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004782 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004783 ASSERT_EQ(1u, info.senders.size());
4784 EXPECT_EQ(123, info.senders[0].send_frame_width);
4785 EXPECT_EQ(90, info.senders[0].send_frame_height);
4786}
4787
eladalonf1841382017-06-12 01:16:46 -07004788TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004789 FakeVideoSendStream* stream = AddSendStream();
4790 webrtc::VideoSendStream::Stats stats;
4791 stats.number_of_cpu_adapt_changes = 2;
4792 stats.cpu_limited_resolution = true;
4793 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004794
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004795 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004796 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004797 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004798 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004799 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004800}
4801
eladalonf1841382017-06-12 01:16:46 -07004802TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004803 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004804 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004805 stats.number_of_cpu_adapt_changes = 2;
4806 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004807 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004808 stream->SetStats(stats);
4809
4810 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004811 EXPECT_TRUE(channel_->GetStats(&info));
4812 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004813 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4814 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004815 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004816 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004817}
4818
eladalonf1841382017-06-12 01:16:46 -07004819TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004820 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4821 FakeVideoSendStream* stream = AddSendStream();
4822 webrtc::VideoSendStream::Stats stats;
4823 stats.bw_limited_resolution = true;
4824 stream->SetStats(stats);
4825
4826 cricket::VideoMediaInfo info;
4827 EXPECT_TRUE(channel_->GetStats(&info));
4828 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004829 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004830 info.senders[0].adapt_reason);
4831}
4832
Yves Gerey665174f2018-06-19 15:03:05 +02004833TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004834 FakeVideoSendStream* stream = AddSendStream();
4835 webrtc::VideoSendStream::Stats stats;
4836 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4837 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4838 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4839
4840 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4841 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4842 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4843
4844 stream->SetStats(stats);
4845
4846 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004847 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004848 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4849 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4850 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4851}
4852
eladalonf1841382017-06-12 01:16:46 -07004853TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004854 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4855 FakeVideoReceiveStream* stream = AddRecvStream();
4856 webrtc::VideoReceiveStream::Stats stats;
4857 stats.rtcp_packet_type_counts.fir_packets = 2;
4858 stats.rtcp_packet_type_counts.nack_packets = 3;
4859 stats.rtcp_packet_type_counts.pli_packets = 4;
4860 stream->SetStats(stats);
4861
4862 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004863 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004864 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004865 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004866 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004867 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004868 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004869 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004870}
4871
eladalonf1841382017-06-12 01:16:46 -07004872TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004873 FakeVideoReceiveStream* stream = AddRecvStream();
4874 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004875 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004876 stats.decode_ms = 2;
4877 stats.max_decode_ms = 3;
4878 stats.current_delay_ms = 4;
4879 stats.target_delay_ms = 5;
4880 stats.jitter_buffer_ms = 6;
4881 stats.min_playout_delay_ms = 7;
4882 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07004883 stats.width = 9;
4884 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08004885 stats.frame_counts.key_frames = 11;
4886 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08004887 stats.frames_rendered = 13;
4888 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01004889 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004890 stream->SetStats(stats);
4891
4892 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004893 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01004894 EXPECT_EQ(stats.decoder_implementation_name,
4895 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004896 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
4897 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
4898 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
4899 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
4900 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
4901 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
4902 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07004903 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
4904 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004905 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
4906 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08004907 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08004908 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07004909 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08004910 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004911}
4912
eladalonf1841382017-06-12 01:16:46 -07004913TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02004914 FakeVideoReceiveStream* stream = AddRecvStream();
4915 webrtc::VideoReceiveStream::Stats stats;
4916 stats.rtp_stats.transmitted.payload_bytes = 2;
4917 stats.rtp_stats.transmitted.header_bytes = 3;
4918 stats.rtp_stats.transmitted.padding_bytes = 4;
4919 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07004920 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02004921 stats.rtcp_stats.fraction_lost = 7;
4922 stream->SetStats(stats);
4923
4924 cricket::VideoMediaInfo info;
4925 ASSERT_TRUE(channel_->GetStats(&info));
4926 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
4927 stats.rtp_stats.transmitted.header_bytes +
4928 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004929 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02004930 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004931 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07004932 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004933 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02004934 info.receivers[0].fraction_lost);
4935}
4936
eladalonf1841382017-06-12 01:16:46 -07004937TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004938 AddSendStream();
4939 AddSendStream();
4940 webrtc::Call::Stats stats;
4941 stats.rtt_ms = 123;
4942 fake_call_->SetStats(stats);
4943
4944 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004945 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004946 ASSERT_EQ(2u, info.senders.size());
4947 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
4948 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
4949}
4950
eladalonf1841382017-06-12 01:16:46 -07004951TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004952 FakeVideoSendStream* stream = AddSendStream();
4953 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004954 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004955 stats.media_bitrate_bps = 123;
4956 stats.substreams[17].total_bitrate_bps = 1;
4957 stats.substreams[17].retransmit_bitrate_bps = 2;
4958 stats.substreams[42].total_bitrate_bps = 3;
4959 stats.substreams[42].retransmit_bitrate_bps = 4;
4960 stream->SetStats(stats);
4961
4962 FakeVideoSendStream* stream2 = AddSendStream();
4963 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004964 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004965 stats2.media_bitrate_bps = 321;
4966 stats2.substreams[13].total_bitrate_bps = 5;
4967 stats2.substreams[13].retransmit_bitrate_bps = 6;
4968 stats2.substreams[21].total_bitrate_bps = 7;
4969 stats2.substreams[21].retransmit_bitrate_bps = 8;
4970 stream2->SetStats(stats2);
4971
4972 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004973 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004974 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07004975 BandwidthEstimationInfo bwe_info;
4976 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004977 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
4978 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
4979 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
4980 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004981 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004982 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004983 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004984 bwe_info.actual_enc_bitrate);
4985 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004986 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07004987 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004988 << "Bandwidth stats should take all streams into account.";
4989}
4990
eladalonf1841382017-06-12 01:16:46 -07004991TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004992 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004993
Peter Boström0c4e06b2015-10-07 12:23:21 +02004994 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4995 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004996
4997 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4998 const size_t kDataLength = 12;
4999 uint8_t data[kDataLength];
5000 memset(data, 0, sizeof(data));
5001 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07005002 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01005003 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005004
5005 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5006 << "No default receive stream created.";
5007 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08005008 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005009 << "Default receive stream should not have configured RTX";
5010
5011 EXPECT_TRUE(channel_->AddRecvStream(
5012 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
5013 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08005014 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005015 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07005016 EXPECT_FALSE(
5017 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07005018 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02005019 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07005020 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02005021 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07005022 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08005023 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005024}
5025
eladalonf1841382017-06-12 01:16:46 -07005026TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005027 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01005028
Peter Boström0c4e06b2015-10-07 12:23:21 +02005029 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5030 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01005031
5032 StreamParams sp =
5033 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5034 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
5035
5036 EXPECT_FALSE(channel_->AddSendStream(sp));
5037 EXPECT_FALSE(channel_->AddRecvStream(sp));
5038}
5039
eladalonf1841382017-06-12 01:16:46 -07005040TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005041 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005042
Peter Boström0c4e06b2015-10-07 12:23:21 +02005043 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5044 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005045
5046 StreamParams sp =
5047 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5048
5049 EXPECT_TRUE(channel_->AddSendStream(sp));
5050 EXPECT_TRUE(channel_->AddRecvStream(sp));
5051
5052 // The RTX SSRC is already used in previous streams, using it should fail.
5053 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5054 EXPECT_FALSE(channel_->AddSendStream(sp));
5055 EXPECT_FALSE(channel_->AddRecvStream(sp));
5056
5057 // After removing the original stream this should be fine to add (makes sure
5058 // that RTX ssrcs are not forever taken).
5059 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5060 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5061 EXPECT_TRUE(channel_->AddSendStream(sp));
5062 EXPECT_TRUE(channel_->AddRecvStream(sp));
5063}
5064
eladalonf1841382017-06-12 01:16:46 -07005065TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005066 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005067 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5068 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005069 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005070
Peter Boströmd6f4c252015-03-26 16:23:04 +01005071 StreamParams sp =
5072 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5073
5074 EXPECT_TRUE(channel_->AddSendStream(sp));
5075 EXPECT_TRUE(channel_->AddRecvStream(sp));
5076
5077 // One of the SSRCs is already used in previous streams, using it should fail.
5078 sp = cricket::CreateSimStreamParams("cname",
5079 MAKE_VECTOR(kOverlappingStreamSsrcs));
5080 EXPECT_FALSE(channel_->AddSendStream(sp));
5081 EXPECT_FALSE(channel_->AddRecvStream(sp));
5082
5083 // After removing the original stream this should be fine to add (makes sure
5084 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005085 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5086 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005087 EXPECT_TRUE(channel_->AddSendStream(sp));
5088 EXPECT_TRUE(channel_->AddRecvStream(sp));
5089}
5090
eladalonf1841382017-06-12 01:16:46 -07005091TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005092 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005093
5094 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5095 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5096
5097 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5098 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5099
5100 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5101
5102 static const uint32_t kReceiverSsrcs[] = {3};
5103 static const uint32_t kReceiverRtxSsrcs[] = {2};
5104
5105 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5106 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5107 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5108
5109 cricket::VideoMediaInfo info;
5110 ASSERT_TRUE(channel_->GetStats(&info));
5111
5112 ASSERT_EQ(1u, info.senders.size());
5113 ASSERT_EQ(1u, info.receivers.size());
5114
5115 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5116 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5117 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5118}
5119
eladalonf1841382017-06-12 01:16:46 -07005120TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005121 FakeVideoReceiveStream* stream = AddRecvStream();
5122 webrtc::VideoReceiveStream::Stats stats;
5123 cricket::VideoMediaInfo info;
5124
5125 // Report no codec name before receiving.
5126 stream->SetStats(stats);
5127 ASSERT_TRUE(channel_->GetStats(&info));
5128 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5129
5130 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005131 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005132 stream->SetStats(stats);
5133 ASSERT_TRUE(channel_->GetStats(&info));
5134 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5135
5136 // Report no codec name for unknown playload types.
5137 stats.current_payload_type = 3;
5138 stream->SetStats(stats);
5139 ASSERT_TRUE(channel_->GetStats(&info));
5140 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5141}
5142
Seth Hampson5897a6e2018-04-03 11:16:33 -07005143// Tests that when we add a stream without SSRCs, but contains a stream_id
5144// that it is stored and its stream id is later used when the first packet
5145// arrives to properly create a receive stream with a sync label.
5146TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5147 const char kSyncLabel[] = "sync_label";
5148 cricket::StreamParams unsignaled_stream;
5149 unsignaled_stream.set_stream_ids({kSyncLabel});
5150 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5151 // The stream shouldn't have been created at this point because it doesn't
5152 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005153 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005154
5155 // Create and deliver packet.
5156 const size_t kDataLength = 12;
5157 uint8_t data[kDataLength];
5158 memset(data, 0, sizeof(data));
5159 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5160 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01005161 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005162
5163 // The stream should now be created with the appropriate sync label.
5164 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5165 EXPECT_EQ(kSyncLabel,
5166 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5167
5168 // Removing the unsignaled stream should clear the cache. This time when
5169 // a default video receive stream is created it won't have a sync_group.
5170 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5171 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5172 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5173
Niels Möllere6933812018-11-05 13:01:41 +01005174 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005175 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5176 EXPECT_TRUE(
5177 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5178}
5179
eladalonf1841382017-06-12 01:16:46 -07005180void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005181 uint8_t payload_type,
5182 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005183 // kRedRtxPayloadType must currently be unused.
5184 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5185
noahricd10a68e2015-07-10 11:27:55 -07005186 // Add a RED RTX codec.
5187 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005188 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005189 recv_parameters_.codecs.push_back(red_rtx_codec);
5190 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005191
5192 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5193 const size_t kDataLength = 12;
5194 uint8_t data[kDataLength];
5195 memset(data, 0, sizeof(data));
5196
5197 rtc::Set8(data, 1, payload_type);
5198 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005199 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01005200 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
noahricd10a68e2015-07-10 11:27:55 -07005201
5202 if (expect_created_receive_stream) {
5203 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5204 << "Should have created a receive stream for payload type: "
5205 << payload_type;
5206 } else {
5207 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5208 << "Shouldn't have created a receive stream for payload type: "
5209 << payload_type;
5210 }
5211}
5212
Åsa Persson2c7149b2018-10-15 09:36:10 +02005213class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5214 public:
5215 WebRtcVideoChannelDiscardUnknownSsrcTest()
5216 : WebRtcVideoChannelTest(
5217 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5218};
5219
5220TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5221 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5222 false /* expect_created_receive_stream */);
5223}
5224
eladalonf1841382017-06-12 01:16:46 -07005225TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005226 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5227 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005228}
5229
eladalonf1841382017-06-12 01:16:46 -07005230TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005231 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5232 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005233}
5234
eladalonf1841382017-06-12 01:16:46 -07005235TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005236 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005237 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5238 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5239 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5240 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005241}
5242
eladalonf1841382017-06-12 01:16:46 -07005243TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005244 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5245 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005246}
5247
eladalonf1841382017-06-12 01:16:46 -07005248TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005249 FlexfecPacketDoesntCreateUnsignalledStream) {
5250 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5251 false /* expect_created_receive_stream */);
5252}
5253
eladalonf1841382017-06-12 01:16:46 -07005254TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005255 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5256 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005257}
5258
mzanaty8a855d62017-02-17 15:46:43 -08005259// Test that receiving any unsignalled SSRC works even if it changes.
5260// The first unsignalled SSRC received will create a default receive stream.
5261// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005262TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005263 // Allow receiving VP8, VP9, H264 (if enabled).
5264 cricket::VideoRecvParameters parameters;
5265 parameters.codecs.push_back(GetEngineCodec("VP8"));
5266 parameters.codecs.push_back(GetEngineCodec("VP9"));
5267
5268#if defined(WEBRTC_USE_H264)
5269 cricket::VideoCodec H264codec(126, "H264");
5270 parameters.codecs.push_back(H264codec);
5271#endif
5272
5273 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5274 // No receive streams yet.
5275 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5276 cricket::FakeVideoRenderer renderer;
5277 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5278
5279 // Receive VP8 packet on first SSRC.
5280 uint8_t data[kMinRtpPacketLen];
5281 cricket::RtpHeader rtpHeader;
5282 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5283 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005284 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005285 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5286 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005287 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005288 // VP8 packet should create default receive stream.
5289 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005290 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005291 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5292 // Verify that the receive stream sinks to a renderer.
5293 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4), 100, 0,
5294 webrtc::kVideoRotation_0);
5295 recv_stream->InjectFrame(video_frame);
5296 EXPECT_EQ(1, renderer.num_rendered_frames());
5297
5298 // Receive VP9 packet on second SSRC.
5299 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005300 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005301 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5302 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005303 channel_->OnPacketReceived(&packet2, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005304 // VP9 packet should replace the default receive SSRC.
5305 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5306 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5307 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5308 // Verify that the receive stream sinks to a renderer.
5309 webrtc::VideoFrame video_frame2(CreateBlackFrameBuffer(4, 4), 200, 0,
ilnik00d802b2017-04-11 10:34:31 -07005310 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005311 recv_stream->InjectFrame(video_frame2);
5312 EXPECT_EQ(2, renderer.num_rendered_frames());
5313
5314#if defined(WEBRTC_USE_H264)
5315 // Receive H264 packet on third SSRC.
5316 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005317 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005318 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5319 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005320 channel_->OnPacketReceived(&packet3, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005321 // H264 packet should replace the default receive SSRC.
5322 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5323 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5324 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5325 // Verify that the receive stream sinks to a renderer.
5326 webrtc::VideoFrame video_frame3(CreateBlackFrameBuffer(4, 4), 300, 0,
ilnik00d802b2017-04-11 10:34:31 -07005327 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005328 recv_stream->InjectFrame(video_frame3);
5329 EXPECT_EQ(3, renderer.num_rendered_frames());
5330#endif
5331}
5332
brandtr0dc57ea2017-05-29 23:33:31 -07005333// This test verifies that when a new default stream is created for a new
5334// unsignaled SSRC, the new stream does not overwrite any old stream that had
5335// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005336TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005337 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5338 cricket::VideoRecvParameters parameters;
5339 parameters.codecs.push_back(GetEngineCodec("VP8"));
5340 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5341
5342 // No streams signaled and no packets received, so we should not have any
5343 // stream objects created yet.
5344 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5345
5346 // Receive packet on an unsignaled SSRC.
5347 uint8_t data[kMinRtpPacketLen];
5348 cricket::RtpHeader rtp_header;
5349 rtp_header.payload_type = GetEngineCodec("VP8").id;
5350 rtp_header.seq_num = rtp_header.timestamp = 0;
5351 rtp_header.ssrc = kSsrcs3[0];
5352 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5353 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005354 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005355 // Default receive stream should be created.
5356 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5357 FakeVideoReceiveStream* recv_stream0 =
5358 fake_call_->GetVideoReceiveStreams()[0];
5359 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5360
5361 // Signal the SSRC.
5362 EXPECT_TRUE(
5363 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5364 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5365 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5366 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5367
5368 // Receive packet on a different unsignaled SSRC.
5369 rtp_header.ssrc = kSsrcs3[1];
5370 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5371 packet.SetData(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005372 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005373 // New default receive stream should be created, but old stream should remain.
5374 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5375 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5376 FakeVideoReceiveStream* recv_stream1 =
5377 fake_call_->GetVideoReceiveStreams()[1];
5378 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5379}
5380
Seth Hampson7c682e02018-05-04 16:28:15 -07005381TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005382 AddSendStream();
5383
Tommi85959932018-02-07 19:26:06 +01005384 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02005385 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
skvladdc1c62c2016-03-16 19:07:43 -07005386 cricket::VideoFormat capture_format_hd =
5387 capturer.GetSupportedFormats()->front();
5388 EXPECT_EQ(1280, capture_format_hd.width);
5389 EXPECT_EQ(720, capture_format_hd.height);
5390 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
5391 EXPECT_TRUE(channel_->SetSend(true));
perkjfa10b552016-10-02 23:45:26 -07005392 capturer.CaptureFrame();
skvladdc1c62c2016-03-16 19:07:43 -07005393
perkjfa10b552016-10-02 23:45:26 -07005394 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005395 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005396
5397 // TODO(skvlad): Resolve the inconsistency between the interpretation
5398 // of the global bitrate limit for audio and video:
5399 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5400 // max_bandwidth_bps = -1 - remove the bandwidth limit
5401 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005402 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005403
perkjfa10b552016-10-02 23:45:26 -07005404 SetAndExpectMaxBitrate(1000, 0, 1000);
5405 SetAndExpectMaxBitrate(1000, 800, 800);
5406 SetAndExpectMaxBitrate(600, 800, 600);
5407 SetAndExpectMaxBitrate(0, 800, 800);
5408 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005409
Niels Möllerff40b142018-04-09 08:49:14 +02005410 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005411}
5412
eladalonf1841382017-06-12 01:16:46 -07005413TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005414 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005415 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005416 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005417
5418 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005419 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005420 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005421}
5422
eladalonf1841382017-06-12 01:16:46 -07005423TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005424 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005425 FakeVideoSendStream* stream = AddSendStream();
5426
Seth Hampson7c682e02018-05-04 16:28:15 -07005427 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5428 EXPECT_EQ(1UL, parameters.encodings.size());
5429 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5430 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5431
5432 // Note that this is testing the behavior of the FakeVideoSendStream, which
5433 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5434 // we are just testing the behavior of
5435 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005436 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5437 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005438
5439 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5440 // by this amount.
5441 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5442 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5443 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5444 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5445
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005446 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5447 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5448 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5449}
5450
5451TEST_F(WebRtcVideoChannelTest,
5452 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5453 FakeVideoSendStream* stream = AddSendStream();
5454
5455 // Note that this is testing the behavior of the FakeVideoSendStream, which
5456 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5457 // we are just testing the behavior of
5458 // EncoderStreamFactory::CreateEncoderStreams.
5459 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5460 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5461
5462 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5463 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5464 EXPECT_EQ(1UL, parameters.encodings.size());
5465 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5466 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5467
5468 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5469 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5470 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5471}
5472
5473TEST_F(WebRtcVideoChannelTest,
5474 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5475 send_parameters_.max_bandwidth_bps = 99999;
5476 FakeVideoSendStream* stream = AddSendStream();
5477 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5478 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5479 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5480 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5481 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5482 stream->GetVideoStreams()[0].max_bitrate_bps);
5483
5484 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5485 // adjusted down.
5486 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5487 EXPECT_EQ(1UL, parameters.encodings.size());
5488 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5489 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5490 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5491 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5492 stream->GetVideoStreams()[0].min_bitrate_bps);
5493 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5494 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005495}
5496
Åsa Persson8c1bf952018-09-13 10:42:19 +02005497TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5498 FakeVideoSendStream* stream = AddSendStream();
5499
5500 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5501 EXPECT_EQ(1UL, parameters.encodings.size());
5502 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5503 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5504
5505 // Note that this is testing the behavior of the FakeVideoSendStream, which
5506 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5507 // we are just testing the behavior of
5508 // EncoderStreamFactory::CreateEncoderStreams.
5509 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5510 EXPECT_EQ(kDefaultVideoMaxFramerate,
5511 stream->GetVideoStreams()[0].max_framerate);
5512
5513 // Set max framerate and check that VideoStream.max_framerate is set.
5514 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5515 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5516 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5517 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5518
5519 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5520 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5521}
5522
Åsa Persson23eba222018-10-02 14:47:06 +02005523TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5524 FakeVideoSendStream* stream = AddSendStream();
5525
5526 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5527 EXPECT_EQ(1UL, parameters.encodings.size());
5528 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5529 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5530
5531 // Note that this is testing the behavior of the FakeVideoSendStream, which
5532 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5533 // we are just testing the behavior of
5534 // EncoderStreamFactory::CreateEncoderStreams.
5535 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5536 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5537
5538 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5539 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5540 parameters.encodings[0].num_temporal_layers = 2;
5541 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5542
5543 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5544 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5545}
5546
Seth Hampson7c682e02018-05-04 16:28:15 -07005547TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005548 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005549 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005550 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005551 // Two or more encodings should result in failure.
5552 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005553 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005554 // Zero encodings should also fail.
5555 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005556 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005557}
5558
Zach Stein3ca452b2018-01-18 10:01:24 -08005559TEST_F(WebRtcVideoChannelTest,
5560 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5561 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5562 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5563 AddSendStream(sp);
5564
5565 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5566
5567 // Additional encodings should result in failure.
5568 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005569 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005570 // Zero encodings should also fail.
5571 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005572 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005573}
5574
deadbeeffb2aced2017-01-06 23:05:37 -08005575// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005576TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005577 AddSendStream();
5578 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005579 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005580 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005581}
5582
Seth Hampson24722b32017-12-22 09:36:42 -08005583// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5584// a value <= 0, setting the parameters returns false.
5585TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5586 AddSendStream();
5587 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5588 EXPECT_EQ(1UL, parameters.encodings.size());
5589 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5590 parameters.encodings[0].bitrate_priority);
5591
5592 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005593 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005594 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005595 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005596}
5597
5598// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5599// properly on the VideoChannel and propogates down to the video encoder.
5600TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5601 AddSendStream();
5602 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5603 EXPECT_EQ(1UL, parameters.encodings.size());
5604 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5605 parameters.encodings[0].bitrate_priority);
5606
5607 // Change the value and set it on the VideoChannel.
5608 double new_bitrate_priority = 2.0;
5609 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005610 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005611
5612 // Verify that the encoding parameters bitrate_priority is set for the
5613 // VideoChannel.
5614 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5615 EXPECT_EQ(1UL, parameters.encodings.size());
5616 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5617
5618 // Verify that the new value propagated down to the encoder.
5619 std::vector<FakeVideoSendStream*> video_send_streams =
5620 fake_call_->GetVideoSendStreams();
5621 EXPECT_EQ(1UL, video_send_streams.size());
5622 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5623 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5624 // appropriately.
5625 EXPECT_EQ(new_bitrate_priority,
5626 video_send_stream->GetEncoderConfig().bitrate_priority);
5627 // Check that the vector of VideoStreams also was propagated correctly. Note
5628 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5629 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005630 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005631 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5632}
5633
5634// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5635// VideoChannel and the value propogates to the video encoder with all simulcast
5636// streams.
5637TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5638 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005639 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005640 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5641 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5642 AddSendStream(stream_params);
5643 uint32_t primary_ssrc = stream_params.first_ssrc();
5644
Tommi85959932018-02-07 19:26:06 +01005645 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
5646 // frame. This creates multiple VideoStreams for all simulcast layers when
5647 // reconfiguring, and allows us to test this behavior.
5648 FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson24722b32017-12-22 09:36:42 -08005649 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02005650 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson24722b32017-12-22 09:36:42 -08005651 EXPECT_EQ(cricket::CS_RUNNING,
5652 capturer.Start(cricket::VideoFormat(
5653 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
5654 cricket::FOURCC_I420)));
5655 channel_->SetSend(true);
5656 EXPECT_TRUE(capturer.CaptureFrame());
5657 // Get and set the rtp encoding parameters.
5658 webrtc::RtpParameters parameters =
5659 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005660 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005661 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5662 parameters.encodings[0].bitrate_priority);
5663 // Change the value and set it on the VideoChannel.
5664 double new_bitrate_priority = 2.0;
5665 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005666 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005667
5668 // Verify that the encoding parameters priority is set on the VideoChannel.
5669 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005670 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005671 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5672
5673 // Verify that the new value propagated down to the encoder.
5674 std::vector<FakeVideoSendStream*> video_send_streams =
5675 fake_call_->GetVideoSendStreams();
5676 EXPECT_EQ(1UL, video_send_streams.size());
5677 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5678 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5679 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005680 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005681 video_send_stream->GetEncoderConfig().number_of_streams);
5682 EXPECT_EQ(new_bitrate_priority,
5683 video_send_stream->GetEncoderConfig().bitrate_priority);
5684 // Check that the vector of VideoStreams also propagated correctly. The
5685 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5686 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005687 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005688 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005689 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5690 // Since we are only setting bitrate priority per-sender, the other
5691 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005692 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005693 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005694 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005695 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005696 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005697}
5698
Tim Haloun648d28a2018-10-18 16:52:22 -07005699// RTCRtpEncodingParameters.network_priority must be one of a few values
5700// derived from the default priority, corresponding to very-low, low, medium,
5701// or high.
5702TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
5703 AddSendStream();
5704 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5705 EXPECT_EQ(1UL, parameters.encodings.size());
5706 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5707 parameters.encodings[0].network_priority);
5708
5709 double good_values[] = {0.5, 1.0, 2.0, 4.0};
5710 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
5711 for (auto it : good_values) {
5712 parameters.encodings[0].network_priority = it;
5713 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5714 }
5715 for (auto it : bad_values) {
5716 parameters.encodings[0].network_priority = it;
5717 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5718 }
5719}
5720
Åsa Persson8c1bf952018-09-13 10:42:19 +02005721TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
5722 const size_t kNumSimulcastStreams = 3;
5723 SetUpSimulcast(true, false);
5724
5725 // Get and set the rtp encoding parameters.
5726 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5727 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5728 for (const auto& encoding : parameters.encodings) {
5729 EXPECT_FALSE(encoding.max_framerate);
5730 }
5731
5732 // Change the value and set it on the VideoChannel.
5733 parameters.encodings[0].max_framerate = 10;
5734 parameters.encodings[1].max_framerate = 20;
5735 parameters.encodings[2].max_framerate = 25;
5736 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5737
5738 // Verify that the bitrates are set on the VideoChannel.
5739 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5740 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5741 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
5742 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
5743 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
5744}
5745
Åsa Persson23eba222018-10-02 14:47:06 +02005746TEST_F(WebRtcVideoChannelTest,
5747 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
5748 const size_t kNumSimulcastStreams = 3;
5749 SetUpSimulcast(true, false);
5750
5751 // Get and set the rtp encoding parameters.
5752 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5753 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5754
5755 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
5756 parameters.encodings[0].num_temporal_layers = 0;
5757 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5758 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5759 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
5760 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5761 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5762}
5763
5764TEST_F(WebRtcVideoChannelTest,
5765 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
5766 const size_t kNumSimulcastStreams = 3;
5767 SetUpSimulcast(true, false);
5768
5769 // Get and set the rtp encoding parameters.
5770 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5771 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5772
5773 // No/all layers should be set.
5774 parameters.encodings[0].num_temporal_layers = 1;
5775 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5776 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5777
5778 // Different values not supported.
5779 parameters.encodings[0].num_temporal_layers = 1;
5780 parameters.encodings[1].num_temporal_layers = 2;
5781 parameters.encodings[2].num_temporal_layers = 2;
5782 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5783 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5784}
5785
5786TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
5787 const size_t kNumSimulcastStreams = 3;
5788 SetUpSimulcast(true, false);
5789
5790 // Get and set the rtp encoding parameters.
5791 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5792 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5793 for (const auto& encoding : parameters.encodings)
5794 EXPECT_FALSE(encoding.num_temporal_layers);
5795
5796 // Change the value and set it on the VideoChannel.
5797 parameters.encodings[0].num_temporal_layers = 3;
5798 parameters.encodings[1].num_temporal_layers = 3;
5799 parameters.encodings[2].num_temporal_layers = 3;
5800 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5801
5802 // Verify that the number of temporal layers are set on the VideoChannel.
5803 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5804 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5805 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
5806 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
5807 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
5808}
5809
5810TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
5811 const size_t kNumSimulcastStreams = 3;
5812 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5813
5814 // Send a full size frame so all simulcast layers are used when reconfiguring.
5815 FakeVideoCapturerWithTaskQueue capturer;
5816 VideoOptions options;
5817 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5818 EXPECT_EQ(cricket::CS_RUNNING,
5819 capturer.Start(capturer.GetSupportedFormats()->front()));
5820 channel_->SetSend(true);
5821 EXPECT_TRUE(capturer.CaptureFrame());
5822
5823 // Get and set the rtp encoding parameters.
5824 // Change the value and set it on the VideoChannel.
5825 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5826 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5827 parameters.encodings[0].num_temporal_layers = 2;
5828 parameters.encodings[1].num_temporal_layers = 2;
5829 parameters.encodings[2].num_temporal_layers = 2;
5830 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5831
5832 // Verify that the new value is propagated down to the encoder.
5833 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5834 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5835 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5836 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5837 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5838 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
5839 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
5840 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
5841
5842 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5843 // VideoStreams are created appropriately for the simulcast case.
5844 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5845 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5846 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
5847 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
5848
5849 // No parameter changed, encoder should not be reconfigured.
5850 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5851 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5852
5853 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5854}
5855
5856TEST_F(WebRtcVideoChannelTest,
5857 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
5858 const size_t kDefaultNumTemporalLayers = 3;
5859 const size_t kNumSimulcastStreams = 3;
5860 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5861
5862 // Send a full size frame so all simulcast layers are used when reconfiguring.
5863 FakeVideoCapturerWithTaskQueue capturer;
5864 VideoOptions options;
5865 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5866 EXPECT_EQ(cricket::CS_RUNNING,
5867 capturer.Start(capturer.GetSupportedFormats()->front()));
5868 channel_->SetSend(true);
5869 EXPECT_TRUE(capturer.CaptureFrame());
5870
5871 // Change rtp encoding parameters, num_temporal_layers not changed.
5872 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5873 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5874 parameters.encodings[0].min_bitrate_bps = 33000;
5875 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5876
5877 // Verify that no value is propagated down to the encoder.
5878 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5879 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5880 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5881 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
5882 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
5883 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
5884
5885 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5886 // VideoStreams are created appropriately for the simulcast case.
5887 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5888 EXPECT_EQ(kDefaultNumTemporalLayers,
5889 stream->GetVideoStreams()[0].num_temporal_layers);
5890 EXPECT_EQ(kDefaultNumTemporalLayers,
5891 stream->GetVideoStreams()[1].num_temporal_layers);
5892 EXPECT_EQ(kDefaultNumTemporalLayers,
5893 stream->GetVideoStreams()[2].num_temporal_layers);
5894
5895 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5896}
5897
Åsa Persson8c1bf952018-09-13 10:42:19 +02005898TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
5899 const size_t kNumSimulcastStreams = 3;
5900 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5901
5902 // Send a full size frame so all simulcast layers are used when reconfiguring.
5903 FakeVideoCapturerWithTaskQueue capturer;
5904 VideoOptions options;
5905 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5906 EXPECT_EQ(cricket::CS_RUNNING,
5907 capturer.Start(capturer.GetSupportedFormats()->front()));
5908 channel_->SetSend(true);
5909 EXPECT_TRUE(capturer.CaptureFrame());
5910
5911 // Get and set the rtp encoding parameters.
5912 // Change the value and set it on the VideoChannel.
5913 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5914 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5915 parameters.encodings[0].max_framerate = 15;
5916 parameters.encodings[1].max_framerate = 25;
5917 parameters.encodings[2].max_framerate = 20;
5918 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5919
5920 // Verify that the new value propagated down to the encoder.
5921 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5922 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5923 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5924 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5925 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5926 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5927 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
5928 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5929
5930 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5931 // VideoStreams are created appropriately for the simulcast case.
5932 // Currently the maximum |max_framerate| is used.
5933 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5934 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
5935 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
5936 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
5937
5938 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5939}
5940
5941TEST_F(WebRtcVideoChannelTest,
5942 DefaultValuePropagatedToEncoderForUnsetFramerate) {
5943 const size_t kNumSimulcastStreams = 3;
5944 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5945 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5946
5947 // Send a full size frame so all simulcast layers are used when reconfiguring.
5948 FakeVideoCapturerWithTaskQueue capturer;
5949 VideoOptions options;
5950 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5951 EXPECT_EQ(cricket::CS_RUNNING,
5952 capturer.Start(capturer.GetSupportedFormats()->front()));
5953 channel_->SetSend(true);
5954 EXPECT_TRUE(capturer.CaptureFrame());
5955
5956 // Get and set the rtp encoding parameters.
5957 // Change the value and set it on the VideoChannel.
5958 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5959 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5960 parameters.encodings[0].max_framerate = 15;
5961 parameters.encodings[2].max_framerate = 20;
5962 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5963
5964 // Verify that the new value propagated down to the encoder.
5965 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5966 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5967 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5968 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5969 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5970 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
5971 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5972
5973 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5974 // VideoStreams are created appropriately for the simulcast case.
5975 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
5976 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5977 EXPECT_EQ(kDefaultVideoMaxFramerate,
5978 stream->GetVideoStreams()[0].max_framerate);
5979 EXPECT_EQ(kDefaultVideoMaxFramerate,
5980 stream->GetVideoStreams()[1].max_framerate);
5981 EXPECT_EQ(kDefaultVideoMaxFramerate,
5982 stream->GetVideoStreams()[2].max_framerate);
5983
5984 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5985}
5986
Åsa Persson55659812018-06-18 17:51:32 +02005987TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
5988 const size_t kNumSimulcastStreams = 3;
5989 SetUpSimulcast(true, false);
5990
5991 // Get and set the rtp encoding parameters.
5992 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5993 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5994 for (const auto& encoding : parameters.encodings) {
5995 EXPECT_FALSE(encoding.min_bitrate_bps);
5996 EXPECT_FALSE(encoding.max_bitrate_bps);
5997 }
5998
5999 // Change the value and set it on the VideoChannel.
6000 parameters.encodings[0].min_bitrate_bps = 100000;
6001 parameters.encodings[0].max_bitrate_bps = 200000;
6002 parameters.encodings[1].min_bitrate_bps = 300000;
6003 parameters.encodings[1].max_bitrate_bps = 400000;
6004 parameters.encodings[2].min_bitrate_bps = 500000;
6005 parameters.encodings[2].max_bitrate_bps = 600000;
6006 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6007
6008 // Verify that the bitrates are set on the VideoChannel.
6009 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6010 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6011 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6012 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6013 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6014 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6015 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6016 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6017}
6018
6019TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6020 const size_t kNumSimulcastStreams = 3;
6021 SetUpSimulcast(true, false);
6022
6023 // Get and set the rtp encoding parameters.
6024 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6025 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6026
6027 // Max bitrate lower than min bitrate should fail.
6028 parameters.encodings[2].min_bitrate_bps = 100000;
6029 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6030 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6031 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6032}
6033
6034// Test that min and max bitrate values set via RtpParameters are correctly
6035// propagated to the underlying encoder, and that the target is set to 3/4 of
6036// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6037// that are used if no min/max are specified).
6038TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6039 const size_t kNumSimulcastStreams = 3;
6040 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6041
6042 // Send a full size frame so all simulcast layers are used when reconfiguring.
6043 FakeVideoCapturerWithTaskQueue capturer;
6044 VideoOptions options;
6045 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6046 EXPECT_EQ(cricket::CS_RUNNING,
6047 capturer.Start(capturer.GetSupportedFormats()->front()));
6048 channel_->SetSend(true);
6049 EXPECT_TRUE(capturer.CaptureFrame());
6050
6051 // Get and set the rtp encoding parameters.
6052 // Change the value and set it on the VideoChannel.
6053 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6054 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6055 parameters.encodings[0].min_bitrate_bps = 100000;
6056 parameters.encodings[0].max_bitrate_bps = 200000;
6057 parameters.encodings[1].min_bitrate_bps = 300000;
6058 parameters.encodings[1].max_bitrate_bps = 400000;
6059 parameters.encodings[2].min_bitrate_bps = 500000;
6060 parameters.encodings[2].max_bitrate_bps = 600000;
6061 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6062
6063 // Verify that the new value propagated down to the encoder.
6064 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6065 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6066 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6067 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6068 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6069 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6070 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6071 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6072 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6073 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6074 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6075
6076 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6077 // VideoStreams are created appropriately for the simulcast case.
6078 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6079 // Target bitrate: 200000 * 3 / 4 = 150000.
6080 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6081 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6082 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6083 // Target bitrate: 400000 * 3 / 4 = 300000.
6084 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6085 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6086 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6087 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6088 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6089 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6090 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6091
6092 // No parameter changed, encoder should not be reconfigured.
6093 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6094 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6095
6096 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6097}
6098
6099// Test to only specify the min or max bitrate value for a layer via
6100// RtpParameters. The unspecified min/max and target value should be set to the
6101// simulcast default that is used if no min/max are specified.
6102TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6103 const size_t kNumSimulcastStreams = 3;
6104 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6105 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6106
6107 // Send a full size frame so all simulcast layers are used when reconfiguring.
6108 FakeVideoCapturerWithTaskQueue capturer;
6109 VideoOptions options;
6110 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6111 EXPECT_EQ(cricket::CS_RUNNING,
6112 capturer.Start(capturer.GetSupportedFormats()->front()));
6113 channel_->SetSend(true);
6114 EXPECT_TRUE(capturer.CaptureFrame());
6115
6116 // Get and set the rtp encoding parameters.
6117 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6118 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6119
6120 // Change the value and set it on the VideoChannel.
6121 // Layer 0: only configure min bitrate.
6122 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6123 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6124 // Layer 1: only configure max bitrate.
6125 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6126 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6127 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6128
6129 // Verify that the new value propagated down to the encoder.
6130 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6131 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6132 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6133 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6134 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6135 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6136 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6137 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6138 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6139 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6140
6141 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6142 // VideoStreams are created appropriately for the simulcast case.
6143 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6144 // Layer 0: min configured bitrate should overwrite min default.
6145 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6146 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6147 stream->GetVideoStreams()[0].target_bitrate_bps);
6148 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6149 stream->GetVideoStreams()[0].max_bitrate_bps);
6150 // Layer 1: max configured bitrate should overwrite max default.
6151 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6152 stream->GetVideoStreams()[1].min_bitrate_bps);
6153 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6154 stream->GetVideoStreams()[1].target_bitrate_bps);
6155 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6156 // Layer 2: min and max bitrate not configured, default expected.
6157 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6158 stream->GetVideoStreams()[2].min_bitrate_bps);
6159 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6160 stream->GetVideoStreams()[2].target_bitrate_bps);
6161 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6162 stream->GetVideoStreams()[2].max_bitrate_bps);
6163
6164 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6165}
6166
6167// Test that specifying the min (or max) bitrate value for a layer via
6168// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6169// unspecified values accordingly.
6170TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6171 const size_t kNumSimulcastStreams = 3;
6172 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6173 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6174
6175 // Send a full size frame so all simulcast layers are used when reconfiguring.
6176 FakeVideoCapturerWithTaskQueue capturer;
6177 VideoOptions options;
6178 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6179 EXPECT_EQ(cricket::CS_RUNNING,
6180 capturer.Start(capturer.GetSupportedFormats()->front()));
6181 channel_->SetSend(true);
6182 EXPECT_TRUE(capturer.CaptureFrame());
6183
6184 // Get and set the rtp encoding parameters.
6185 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6186 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6187
6188 // Change the value and set it on the VideoChannel.
6189 // For layer 0, set the min bitrate above the default max.
6190 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6191 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6192 // For layer 1, set the max bitrate below the default min.
6193 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6194 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6195 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6196
6197 // Verify that the new value propagated down to the encoder.
6198 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6199 // VideoStreams are created appropriately for the simulcast case.
6200 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6201 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6202 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6203 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6204 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6205 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6206 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6207 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6208 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6209 // Layer 2: min and max bitrate not configured, default expected.
6210 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6211 stream->GetVideoStreams()[2].min_bitrate_bps);
6212 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6213 stream->GetVideoStreams()[2].target_bitrate_bps);
6214 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6215 stream->GetVideoStreams()[2].max_bitrate_bps);
6216
6217 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6218}
6219
6220TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6221 const size_t kNumSimulcastStreams = 3;
6222 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6223 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6224
6225 // Send a full size frame so all simulcast layers are used when reconfiguring.
6226 FakeVideoCapturerWithTaskQueue capturer;
6227 VideoOptions options;
6228 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6229 EXPECT_EQ(cricket::CS_RUNNING,
6230 capturer.Start(capturer.GetSupportedFormats()->front()));
6231 channel_->SetSend(true);
6232 EXPECT_TRUE(capturer.CaptureFrame());
6233
6234 // Set max bitrate for all but the highest layer.
6235 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6236 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6237 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6238 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6239 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6240
6241 // Set max bandwidth equal to total max bitrate.
6242 send_parameters_.max_bandwidth_bps =
6243 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6244 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6245 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6246
6247 // No bitrate above the total max to give to the highest layer.
6248 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6249 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6250 stream->GetVideoStreams()[2].max_bitrate_bps);
6251
6252 // Set max bandwidth above the total max bitrate.
6253 send_parameters_.max_bandwidth_bps =
6254 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6255 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6256 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6257
6258 // The highest layer has no max bitrate set -> the bitrate above the total
6259 // max should be given to the highest layer.
6260 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6261 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6262 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6263 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6264 stream->GetVideoStreams()[2].max_bitrate_bps);
6265
6266 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6267}
6268
6269TEST_F(WebRtcVideoChannelTest,
6270 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6271 const size_t kNumSimulcastStreams = 3;
6272 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6273 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6274 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6275
6276 // Send a full size frame so all simulcast layers are used when reconfiguring.
6277 FakeVideoCapturerWithTaskQueue capturer;
6278 VideoOptions options;
6279 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6280 EXPECT_EQ(cricket::CS_RUNNING,
6281 capturer.Start(capturer.GetSupportedFormats()->front()));
6282 channel_->SetSend(true);
6283 EXPECT_TRUE(capturer.CaptureFrame());
6284
6285 // Set max bitrate for the highest layer.
6286 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6287 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6288 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6289 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6290
6291 // Set max bandwidth above the total max bitrate.
6292 send_parameters_.max_bandwidth_bps =
6293 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6294 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6295 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6296
6297 // The highest layer has the max bitrate set -> the bitrate above the total
6298 // max should not be given to the highest layer.
6299 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6300 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6301 stream->GetVideoStreams()[2].max_bitrate_bps);
6302
6303 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6304}
6305
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006306// Test that min and max bitrate values set via RtpParameters are correctly
6307// propagated to the underlying encoder for a single stream.
6308TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6309 FakeVideoSendStream* stream = AddSendStream();
6310 EXPECT_TRUE(channel_->SetSend(true));
6311 EXPECT_TRUE(stream->IsSending());
6312
6313 // Set min and max bitrate.
6314 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6315 EXPECT_EQ(1u, parameters.encodings.size());
6316 parameters.encodings[0].min_bitrate_bps = 80000;
6317 parameters.encodings[0].max_bitrate_bps = 150000;
6318 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6319
6320 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6321 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6322 EXPECT_EQ(1u, encoder_config.number_of_streams);
6323 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6324 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6325 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6326
6327 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6328 // VideoStreams are created appropriately.
6329 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6330 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6331 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6332 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6333}
6334
6335// Test the default min and max bitrate value are correctly propagated to the
6336// underlying encoder for a single stream (when the values are not set via
6337// RtpParameters).
6338TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6339 FakeVideoSendStream* stream = AddSendStream();
6340 EXPECT_TRUE(channel_->SetSend(true));
6341 EXPECT_TRUE(stream->IsSending());
6342
6343 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6344 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6345 EXPECT_EQ(1u, encoder_config.number_of_streams);
6346 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6347 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6348 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6349
6350 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6351 // VideoStreams are created appropriately.
6352 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6353 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6354 stream->GetVideoStreams()[0].min_bitrate_bps);
6355 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6356 stream->GetVideoStreams()[0].min_bitrate_bps);
6357 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6358 stream->GetVideoStreams()[0].target_bitrate_bps);
6359}
6360
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006361// Test that a stream will not be sending if its encoding is made inactive
6362// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006363TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006364 FakeVideoSendStream* stream = AddSendStream();
6365 EXPECT_TRUE(channel_->SetSend(true));
6366 EXPECT_TRUE(stream->IsSending());
6367
6368 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006369 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006370 ASSERT_EQ(1u, parameters.encodings.size());
6371 ASSERT_TRUE(parameters.encodings[0].active);
6372 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006373 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006374 EXPECT_FALSE(stream->IsSending());
6375
6376 // Now change it back to active and verify we resume sending.
6377 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006378 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006379 EXPECT_TRUE(stream->IsSending());
6380}
6381
Seth Hampson8234ead2018-02-02 15:16:24 -08006382// Tests that when active is updated for any simulcast layer then the send
6383// stream's sending state will be updated and it will be reconfigured with the
6384// new appropriate active simulcast streams.
6385TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6386 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006387 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006388 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6389 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6390 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6391 uint32_t primary_ssrc = stream_params.first_ssrc();
6392
Tommi85959932018-02-07 19:26:06 +01006393 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
6394 // frame. This allows us to test that ReconfigureEncoder is called
6395 // appropriately.
6396 cricket::FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson8234ead2018-02-02 15:16:24 -08006397 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02006398 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson8234ead2018-02-02 15:16:24 -08006399 EXPECT_EQ(cricket::CS_RUNNING,
6400 capturer.Start(cricket::VideoFormat(
6401 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
6402 cricket::FOURCC_I420)));
6403 channel_->SetSend(true);
6404 EXPECT_TRUE(capturer.CaptureFrame());
6405
6406 // Check that all encodings are initially active.
6407 webrtc::RtpParameters parameters =
6408 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006409 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006410 EXPECT_TRUE(parameters.encodings[0].active);
6411 EXPECT_TRUE(parameters.encodings[1].active);
6412 EXPECT_TRUE(parameters.encodings[2].active);
6413 EXPECT_TRUE(fake_video_send_stream->IsSending());
6414
6415 // Only turn on only the middle stream.
6416 parameters.encodings[0].active = false;
6417 parameters.encodings[1].active = true;
6418 parameters.encodings[2].active = false;
6419 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6420 // Verify that the active fields are set on the VideoChannel.
6421 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006422 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006423 EXPECT_FALSE(parameters.encodings[0].active);
6424 EXPECT_TRUE(parameters.encodings[1].active);
6425 EXPECT_FALSE(parameters.encodings[2].active);
6426 // Check that the VideoSendStream is updated appropriately. This means its
6427 // send state was updated and it was reconfigured.
6428 EXPECT_TRUE(fake_video_send_stream->IsSending());
6429 std::vector<webrtc::VideoStream> simulcast_streams =
6430 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006431 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006432 EXPECT_FALSE(simulcast_streams[0].active);
6433 EXPECT_TRUE(simulcast_streams[1].active);
6434 EXPECT_FALSE(simulcast_streams[2].active);
6435
6436 // Turn off all streams.
6437 parameters.encodings[0].active = false;
6438 parameters.encodings[1].active = false;
6439 parameters.encodings[2].active = false;
6440 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6441 // Verify that the active fields are set on the VideoChannel.
6442 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006443 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006444 EXPECT_FALSE(parameters.encodings[0].active);
6445 EXPECT_FALSE(parameters.encodings[1].active);
6446 EXPECT_FALSE(parameters.encodings[2].active);
6447 // Check that the VideoSendStream is off.
6448 EXPECT_FALSE(fake_video_send_stream->IsSending());
6449 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006450 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006451 EXPECT_FALSE(simulcast_streams[0].active);
6452 EXPECT_FALSE(simulcast_streams[1].active);
6453 EXPECT_FALSE(simulcast_streams[2].active);
6454
Niels Möllerff40b142018-04-09 08:49:14 +02006455 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08006456}
6457
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006458// Test that if a stream is reconfigured (due to a codec change or other
6459// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07006460TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006461 InactiveStreamDoesntStartSendingWhenReconfigured) {
6462 // Set an initial codec list, which will be modified later.
6463 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08006464 parameters1.codecs.push_back(GetEngineCodec("VP8"));
6465 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006466 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
6467
6468 FakeVideoSendStream* stream = AddSendStream();
6469 EXPECT_TRUE(channel_->SetSend(true));
6470 EXPECT_TRUE(stream->IsSending());
6471
6472 // Get current parameters and change "active" to false.
6473 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6474 ASSERT_EQ(1u, parameters.encodings.size());
6475 ASSERT_TRUE(parameters.encodings[0].active);
6476 parameters.encodings[0].active = false;
6477 EXPECT_EQ(1u, GetFakeSendStreams().size());
6478 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08006479 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006480 EXPECT_FALSE(stream->IsSending());
6481
6482 // Reorder the codec list, causing the stream to be reconfigured.
6483 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08006484 parameters2.codecs.push_back(GetEngineCodec("VP9"));
6485 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006486 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
6487 auto new_streams = GetFakeSendStreams();
6488 // Assert that a new underlying stream was created due to the codec change.
6489 // Otherwise, this test isn't testing what it set out to test.
6490 EXPECT_EQ(1u, GetFakeSendStreams().size());
6491 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
6492
6493 // Verify that we still are not sending anything, due to the inactive
6494 // encoding.
6495 EXPECT_FALSE(new_streams[0]->IsSending());
6496}
6497
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006498// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006499TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006500 AddSendStream();
6501 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006502 parameters.codecs.push_back(GetEngineCodec("VP8"));
6503 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006504 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6505
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006506 webrtc::RtpParameters rtp_parameters =
6507 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006508 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006509 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6510 rtp_parameters.codecs[0]);
6511 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6512 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006513}
6514
Florent Castellidacec712018-05-24 16:24:21 +02006515// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
6516TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
6517 StreamParams params = StreamParams::CreateLegacy(kSsrc);
6518 params.cname = "rtcpcname";
6519 AddSendStream(params);
6520
6521 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
6522 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
6523}
6524
deadbeeffb2aced2017-01-06 23:05:37 -08006525// Test that RtpParameters for send stream has one encoding and it has
6526// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006527TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08006528 AddSendStream();
6529
6530 webrtc::RtpParameters rtp_parameters =
6531 channel_->GetRtpSendParameters(last_ssrc_);
6532 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006533 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08006534}
6535
Florent Castelliabe301f2018-06-12 18:33:49 +02006536TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
6537 AddSendStream();
6538
6539 webrtc::RtpParameters rtp_parameters =
6540 channel_->GetRtpSendParameters(last_ssrc_);
6541 rtp_parameters.header_extensions.emplace_back();
6542
6543 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
6544
6545 webrtc::RTCError result =
6546 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6547 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
6548}
6549
Florent Castelli87b3c512018-07-18 16:00:28 +02006550TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
6551 AddSendStream();
6552
6553 FakeVideoCapturerWithTaskQueue capturer;
6554 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
6555
6556 webrtc::RtpParameters rtp_parameters =
6557 channel_->GetRtpSendParameters(last_ssrc_);
6558 EXPECT_EQ(rtp_parameters.degradation_preference,
6559 webrtc::DegradationPreference::BALANCED);
6560 rtp_parameters.degradation_preference =
6561 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
6562
6563 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
6564
6565 webrtc::RtpParameters updated_rtp_parameters =
6566 channel_->GetRtpSendParameters(last_ssrc_);
6567 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
6568 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
6569
6570 // Remove the source since it will be destroyed before the channel
6571 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6572}
6573
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006574// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006575TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006576 AddSendStream();
6577 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006578 parameters.codecs.push_back(GetEngineCodec("VP8"));
6579 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006580 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6581
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006582 webrtc::RtpParameters initial_params =
6583 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006584
6585 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08006586 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006587
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006588 // ... And this shouldn't change the params returned by GetRtpSendParameters.
6589 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
6590}
6591
6592// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006593TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006594 AddRecvStream();
6595 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006596 parameters.codecs.push_back(GetEngineCodec("VP8"));
6597 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006598 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6599
6600 webrtc::RtpParameters rtp_parameters =
6601 channel_->GetRtpReceiveParameters(last_ssrc_);
6602 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006603 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6604 rtp_parameters.codecs[0]);
6605 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6606 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006607}
6608
johan073ece42016-08-26 02:59:47 -07006609#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07006610TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006611#else
eladalonf1841382017-06-12 01:16:46 -07006612TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006613#endif
johan3859c892016-08-05 09:19:25 -07006614 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07006615 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08006616 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07006617 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07006618 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08006619 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07006620 parameters.codecs.push_back(kH264sprop2);
6621 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6622
6623 FakeVideoReceiveStream* recv_stream = AddRecvStream();
6624 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
6625 webrtc::RtpParameters rtp_parameters =
6626 channel_->GetRtpReceiveParameters(last_ssrc_);
6627 ASSERT_EQ(2u, rtp_parameters.codecs.size());
6628 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
6629 ASSERT_EQ(2u, cfg.decoders.size());
6630 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006631 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006632 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006633 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
6634 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006635 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07006636
6637 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006638 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006639 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006640 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
6641 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006642 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07006643}
6644
sakal1fd95952016-06-22 00:46:15 -07006645// Test that RtpParameters for receive stream has one encoding and it has
6646// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006647TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07006648 AddRecvStream();
6649
6650 webrtc::RtpParameters rtp_parameters =
6651 channel_->GetRtpReceiveParameters(last_ssrc_);
6652 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006653 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07006654}
6655
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006656// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006657TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006658 AddRecvStream();
6659 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006660 parameters.codecs.push_back(GetEngineCodec("VP8"));
6661 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006662 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6663
6664 webrtc::RtpParameters initial_params =
6665 channel_->GetRtpReceiveParameters(last_ssrc_);
6666
6667 // We should be able to set the params we just got.
6668 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
6669
6670 // ... And this shouldn't change the params returned by
6671 // GetRtpReceiveParameters.
6672 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006673}
6674
deadbeef3bc15102017-04-20 19:25:07 -07006675// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
6676// aren't signaled. It should always return an empty "RtpEncodingParameters",
6677// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07006678TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07006679 // Call necessary methods to configure receiving a default stream as
6680 // soon as it arrives.
6681 cricket::VideoRecvParameters parameters;
6682 parameters.codecs.push_back(GetEngineCodec("VP8"));
6683 parameters.codecs.push_back(GetEngineCodec("VP9"));
6684 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6685
6686 // Call GetRtpReceiveParameters before configured to receive an unsignaled
6687 // stream. Should return nothing.
6688 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
6689
6690 // Set a sink for an unsignaled stream.
6691 cricket::FakeVideoRenderer renderer;
6692 // Value of "0" means "unsignaled stream".
6693 EXPECT_TRUE(channel_->SetSink(0, &renderer));
6694
6695 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
6696 // in this method means "unsignaled stream".
6697 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
6698 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6699 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6700
6701 // Receive VP8 packet.
6702 uint8_t data[kMinRtpPacketLen];
6703 cricket::RtpHeader rtpHeader;
6704 rtpHeader.payload_type = GetEngineCodec("VP8").id;
6705 rtpHeader.seq_num = rtpHeader.timestamp = 0;
6706 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
6707 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
6708 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01006709 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
deadbeef3bc15102017-04-20 19:25:07 -07006710
6711 // The |ssrc| member should still be unset.
6712 rtp_parameters = channel_->GetRtpReceiveParameters(0);
6713 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6714 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6715}
6716
eladalonf1841382017-06-12 01:16:46 -07006717void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02006718 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006719 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02006720
6721 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02006722 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02006723 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02006724 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02006725
6726 if (receiver_first) {
6727 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6728 std::vector<FakeVideoReceiveStream*> receive_streams =
6729 fake_call_->GetVideoReceiveStreams();
6730 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02006731 // Default local SSRC when we have no sender.
6732 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6733 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006734 }
6735 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
6736 if (!receiver_first)
6737 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6738 std::vector<FakeVideoReceiveStream*> receive_streams =
6739 fake_call_->GetVideoReceiveStreams();
6740 ASSERT_EQ(1u, receive_streams.size());
6741 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02006742
6743 // Removing first sender should fall back to another (in this case the second)
6744 // local send stream's SSRC.
6745 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
6746 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006747 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006748 ASSERT_EQ(1u, receive_streams.size());
6749 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
6750
6751 // Removing the last sender should fall back to default local SSRC.
6752 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006753 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006754 ASSERT_EQ(1u, receive_streams.size());
6755 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6756 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006757}
6758
eladalonf1841382017-06-12 01:16:46 -07006759TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02006760 TestReceiverLocalSsrcConfiguration(false);
6761}
6762
eladalonf1841382017-06-12 01:16:46 -07006763TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02006764 TestReceiverLocalSsrcConfiguration(true);
6765}
6766
eladalonf1841382017-06-12 01:16:46 -07006767class WebRtcVideoChannelSimulcastTest : public testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006768 public:
eladalonf1841382017-06-12 01:16:46 -07006769 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01006770 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006771 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
6772 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08006773 mock_rate_allocator_factory_(
6774 new webrtc::MockVideoBitrateAllocatorFactory),
Anders Carlsson67537952018-05-03 11:28:29 +02006775 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006776 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02006777 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jiawei Ouc2ebe212018-11-08 10:02:56 -08006778 decoder_factory_),
6779 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
6780 mock_rate_allocator_factory_)),
magjed2475ae22017-09-12 04:42:15 -07006781 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006782
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00006783 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02006784 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson84848f22018-11-16 10:40:36 +01006785 channel_.reset(engine_.CreateMediaChannel(&fake_call_, GetMediaConfig(),
6786 VideoOptions(),
6787 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08006788 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006789 last_ssrc_ = 123;
6790 }
6791
6792 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006793 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07006794 int capture_width,
6795 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006796 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08006797 size_t expected_num_streams,
6798 bool screenshare,
6799 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006800 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006801 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08006802 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006803 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006804
Peter Boström0c4e06b2015-10-07 12:23:21 +02006805 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07006806 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006807 ssrcs.resize(num_configured_streams);
6808
sprangf24a0642017-02-28 13:23:26 -08006809 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006810 // Send a full-size frame to trigger a stream reconfiguration to use all
6811 // expected simulcast layers.
Tommi85959932018-02-07 19:26:06 +01006812 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08006813 VideoOptions options;
6814 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01006815 options.is_screencast = screenshare;
Yves Gerey665174f2018-06-19 15:03:05 +02006816 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08006817 // Fetch the latest stream since SetVideoSend() may recreate it if the
6818 // screen content setting is changed.
6819 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006820 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(cricket::VideoFormat(
perkj26752742016-10-24 01:21:16 -07006821 capture_width, capture_height,
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006822 cricket::VideoFormat::FpsToInterval(30),
6823 cricket::FOURCC_I420)));
6824 channel_->SetSend(true);
6825 EXPECT_TRUE(capturer.CaptureFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006826
Zach Stein3ca452b2018-01-18 10:01:24 -08006827 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
6828 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
6829
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006830 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6831 ASSERT_EQ(expected_num_streams, video_streams.size());
6832
sprang429600d2017-01-26 06:12:26 -08006833 std::vector<webrtc::VideoStream> expected_streams;
6834 if (conference_mode) {
6835 expected_streams = GetSimulcastConfig(
6836 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08006837 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02006838 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08006839 if (screenshare) {
6840 for (const webrtc::VideoStream& stream : expected_streams) {
6841 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00006842 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
6843 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08006844 }
6845 }
sprang429600d2017-01-26 06:12:26 -08006846 } else {
6847 webrtc::VideoStream stream;
6848 stream.width = capture_width;
6849 stream.height = capture_height;
6850 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01006851 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08006852 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006853 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08006854 stream.max_qp = kDefaultQpMax;
6855 expected_streams.push_back(stream);
6856 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006857
6858 ASSERT_EQ(expected_streams.size(), video_streams.size());
6859
6860 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006861 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006862 for (size_t i = 0; i < num_streams; ++i) {
6863 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
6864 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
6865
6866 EXPECT_GT(video_streams[i].max_framerate, 0);
6867 EXPECT_EQ(expected_streams[i].max_framerate,
6868 video_streams[i].max_framerate);
6869
6870 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
6871 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
6872 video_streams[i].min_bitrate_bps);
6873
6874 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
6875 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
6876 video_streams[i].target_bitrate_bps);
6877
6878 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
6879 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
6880 video_streams[i].max_bitrate_bps);
6881
6882 EXPECT_GT(video_streams[i].max_qp, 0);
6883 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
6884
Sergey Silkina796a7e2018-03-01 15:11:29 +01006885 EXPECT_EQ(conference_mode,
6886 expected_streams[i].num_temporal_layers.has_value());
6887
6888 if (conference_mode) {
6889 EXPECT_EQ(expected_streams[i].num_temporal_layers,
6890 video_streams[i].num_temporal_layers);
6891 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006892
6893 if (i == num_streams - 1) {
6894 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
6895 } else {
6896 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
6897 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006898 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006899
Niels Möllerff40b142018-04-09 08:49:14 +02006900 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006901 }
6902
6903 FakeVideoSendStream* AddSendStream() {
6904 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
6905 }
6906
6907 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006908 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006909 EXPECT_TRUE(channel_->AddSendStream(sp));
6910 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006911 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006912 EXPECT_EQ(num_streams + 1, streams.size());
6913 return streams[streams.size() - 1];
6914 }
6915
6916 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006917 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006918 }
6919
6920 FakeVideoReceiveStream* AddRecvStream() {
6921 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
6922 }
6923
6924 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006925 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006926 EXPECT_TRUE(channel_->AddRecvStream(sp));
6927 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006928 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006929 EXPECT_EQ(num_streams + 1, streams.size());
6930 return streams[streams.size() - 1];
6931 }
6932
skvlad11a9cbf2016-10-07 11:53:05 -07006933 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006934 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006935 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
6936 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jiawei Ouc2ebe212018-11-08 10:02:56 -08006937 webrtc::MockVideoBitrateAllocatorFactory* mock_rate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -07006938 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08006939 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02006940 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006941};
6942
eladalonf1841382017-06-12 01:16:46 -07006943TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006944 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
6945 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006946}
6947
eladalonf1841382017-06-12 01:16:46 -07006948TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006949 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
6950 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006951}
6952
6953// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07006954TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08006955 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
6956 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006957}
sprang429600d2017-01-26 06:12:26 -08006958
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006959TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006960 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6961 false);
6962}
6963
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006964TEST_F(WebRtcVideoChannelSimulcastTest,
6965 SetSendCodecsForConferenceModeScreenshare) {
Erik Språng72e52ee2018-11-29 11:41:53 +01006966 webrtc::test::ScopedFieldTrials field_trials(
6967 "WebRTC-SimulcastScreenshare/Disabled/");
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006968 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6969 true);
6970}
6971
eladalonf1841382017-06-12 01:16:46 -07006972TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08006973 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
6974 true);
6975}
6976
eladalonf1841382017-06-12 01:16:46 -07006977TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07006978 NoSimulcastScreenshareWithoutConference) {
sprangfe627f32017-03-29 08:24:59 -07006979 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6980 false);
6981}
6982
Yves Gereyb6a89422018-10-08 10:08:32 +02006983class WebRtcVideoFakeClock {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006984 public:
Yves Gereyb6a89422018-10-08 10:08:32 +02006985 WebRtcVideoFakeClock() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006986 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1)); // avoid time=0
6987 }
6988 rtc::ScopedFakeClock fake_clock_;
6989};
6990
Yves Gereyb6a89422018-10-08 10:08:32 +02006991// The fake clock needs to be initialized before the call, and not
6992// destroyed until after all threads spawned by the test have been stopped.
6993// This mixin ensures that.
6994class WebRtcVideoChannelTestWithClock : public WebRtcVideoFakeClock,
6995 public WebRtcVideoChannelBaseTest {};
6996
Jonas Oreland49ac5952018-09-26 16:04:32 +02006997TEST_F(WebRtcVideoChannelTestWithClock, GetSources) {
6998 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
6999 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7000
7001 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7002
7003 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7004 rtc::SetBE32(packet1.data() + 8, kSsrc);
7005 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7006 EXPECT_TRUE(SetDefaultCodec());
7007 EXPECT_TRUE(SetSend(true));
7008 EXPECT_EQ(0, renderer_.num_rendered_frames());
7009 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
7010
7011 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7012 EXPECT_EQ(1u, sources.size());
7013 EXPECT_EQ(webrtc::RtpSourceType::SSRC, sources[0].source_type());
7014 int64_t timestamp1 = sources[0].timestamp_ms();
7015
7016 // a new packet.
7017 int64_t timeDeltaMs = 1;
7018 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
7019 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
7020 int64_t timestamp2 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7021 EXPECT_EQ(timestamp2, timestamp1 + timeDeltaMs);
7022
7023 // It only keeps 10s of history.
7024 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7025 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7026 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7027}
7028
7029TEST_F(WebRtcVideoChannelTestWithClock, GetContributingSources) {
7030 uint8_t data1[] = {0x81, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
7031 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7032
7033 uint32_t kCsrc = 4321u;
7034 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7035 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7036
7037 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7038 rtc::SetBE32(packet1.data() + 8, kSsrc);
7039 rtc::SetBE32(packet1.data() + 12, kCsrc);
7040 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7041 EXPECT_TRUE(SetDefaultCodec());
7042 EXPECT_TRUE(SetSend(true));
7043 EXPECT_EQ(0, renderer_.num_rendered_frames());
7044 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
7045
7046 {
7047 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7048 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7049 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7050 EXPECT_EQ(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7051 // 1 SSRC and 1 CSRC.
7052 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7053 [](const webrtc::RtpSource& source) {
7054 return source.source_type() ==
7055 webrtc::RtpSourceType::SSRC;
7056 }));
7057 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7058 [](const webrtc::RtpSource& source) {
7059 return source.source_type() ==
7060 webrtc::RtpSourceType::CSRC;
7061 }));
7062 }
7063 int64_t timestamp1 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7064
7065 // a new packet with only ssrc (i.e no csrc).
7066 uint8_t data2[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7067 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7068 rtc::CopyOnWriteBuffer packet2(data2, sizeof(data2));
7069 rtc::SetBE32(packet2.data() + 8, kSsrc);
7070
7071 int64_t timeDeltaMs = 1;
7072 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
7073 channel_->OnPacketReceived(&packet2, rtc::PacketTime());
7074
7075 {
7076 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7077 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7078 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7079 EXPECT_NE(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7080 // 1 SSRC and 1 CSRC.
7081 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7082 [](const webrtc::RtpSource& source) {
7083 return source.source_type() ==
7084 webrtc::RtpSourceType::SSRC;
7085 }));
7086 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7087 [](const webrtc::RtpSource& source) {
7088 return source.source_type() ==
7089 webrtc::RtpSourceType::CSRC;
7090 }));
7091 auto ssrcSource = std::find_if(
7092 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7093 return source.source_type() == webrtc::RtpSourceType::SSRC;
7094 });
7095 auto csrcSource = std::find_if(
7096 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7097 return source.source_type() == webrtc::RtpSourceType::CSRC;
7098 });
7099
7100 EXPECT_EQ(ssrcSource->timestamp_ms(), timestamp1 + timeDeltaMs);
7101 EXPECT_EQ(csrcSource->timestamp_ms(), timestamp1);
7102 }
7103
7104 // It only keeps 10s of history.
7105 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7106
7107 {
7108 ASSERT_EQ(1u, channel_->GetSources(kSsrc).size());
7109 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7110 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7111 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7112 [](const webrtc::RtpSource& source) {
7113 return source.source_type() ==
7114 webrtc::RtpSourceType::SSRC;
7115 }));
7116 EXPECT_EQ(0, std::count_if(sources.begin(), sources.end(),
7117 [](const webrtc::RtpSource& source) {
7118 return source.source_type() ==
7119 webrtc::RtpSourceType::CSRC;
7120 }));
7121 }
7122
7123 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7124 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7125 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7126}
7127
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007128} // namespace cricket