blob: 7c252ea5961df5e6ede4fa0eab4109e524c84cf5 [file] [log] [blame]
Mike Frysinger4f994402019-09-13 17:40:45 -04001#!/usr/bin/env python3
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002# -*- coding: utf-8 -*-
Jon Salz98255932012-08-18 14:48:02 +08003# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
Mike Frysingerae409522014-02-01 03:16:11 -05007"""Presubmit checks to run when doing `repo upload`.
8
Tom Hughes40bdce52020-08-25 08:57:03 -07009You can add new checks by adding a function to the HOOKS constants.
Mike Frysingerae409522014-02-01 03:16:11 -050010"""
11
Mike Frysinger09d6a3d2013-10-08 22:21:03 -040012from __future__ import print_function
13
Keigo Okadd908822019-06-04 11:30:25 +090014import argparse
Alex Deymo643ac4c2015-09-03 10:40:50 -070015import collections
Mike Frysingerf252cfc2019-12-09 17:34:28 -050016import configparser
Keigo Oka7e880ac2019-07-03 15:03:43 +090017import datetime
Daniel Erate3ea3fc2015-02-13 15:27:52 -070018import fnmatch
Jon Salz3ee59de2012-08-18 13:54:22 +080019import functools
Dale Curtis2975c432011-05-03 17:25:20 -070020import json
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070021import os
Ryan Cuiec4d6332011-05-02 14:15:25 -070022import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070023import sys
Peter Ammon811f6702014-06-12 15:45:38 -070024import stat
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -050025import subprocess
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070026
Ryan Cui1562fb82011-05-09 11:01:31 -070027from errors import (VerifyException, HookFailure, PrintErrorForProject,
28 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070029
Mike Frysinger919c7032019-09-13 17:48:08 -040030if __name__ in ('__builtin__', 'builtins'):
Mike Frysinger653cd262019-09-20 14:05:02 -040031 # If repo imports us, the __name__ will be __builtin__, and the cwd will be in
32 # the top level of the checkout (i.e. $CHROMEOS_CHECKOUT). chromite will be
33 # in that directory, so add it to our path. This works whether we're running
34 # the repo in $CHROMEOS_CHECKOUT/.repo/repo/ or a custom version in a
35 # completely different tree.
36 # TODO(vapier): Python 2 used "__builtin__" while Python 3 uses "builtins".
Mike Frysinger6850d512018-05-21 12:12:14 -040037 sys.path.insert(0, os.getcwd())
38
Mike Frysinger653cd262019-09-20 14:05:02 -040039elif __name__ == '__main__':
40 # If we're run directly, we'll find chromite relative to the repohooks dir in
41 # $CHROMEOS_CHECKOUT/src/repohooks, so go up two dirs.
David Jamesc3b68b32013-04-03 09:17:03 -070042 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
43
Mike Frysingerfd481ce2019-09-13 18:14:48 -040044# The sys.path monkey patching confuses the linter.
45# pylint: disable=wrong-import-position
Mike Frysinger66142932014-12-18 14:55:57 -050046from chromite.lib import commandline
Rahul Chaudhry0e515342015-08-07 12:00:43 -070047from chromite.lib import cros_build_lib
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050048from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070049from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070050from chromite.lib import patch
Mike Frysingered1b95a2019-12-12 19:04:51 -050051from chromite.lib import terminal
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040052from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070053
Mike Frysingerff4768e2020-02-27 18:48:13 -050054
55assert sys.version_info >= (3, 6), 'This module requires Python 3.6+'
56
57
Vadim Bendebury2b62d742014-06-22 13:14:51 -070058PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070059
Mike Frysingered9b2a02019-12-12 18:52:32 -050060
61# Link to commit message documentation for users.
62DOC_COMMIT_MSG_URL = ('https://chromium.googlesource.com/chromiumos/docs/+/HEAD'
63 '/contributing.md#commit-messages')
64
65
Ryan Cuiec4d6332011-05-02 14:15:25 -070066COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050067 # C++ and friends
Mike Frysinger24dd3c52019-08-17 14:22:48 -040068 r'.*\.c$', r'.*\.cc$', r'.*\.cpp$', r'.*\.h$', r'.*\.m$', r'.*\.mm$',
69 r'.*\.inl$', r'.*\.asm$', r'.*\.hxx$', r'.*\.hpp$', r'.*\.s$', r'.*\.S$',
Mike Frysingerae409522014-02-01 03:16:11 -050070 # Scripts
Mike Frysinger24dd3c52019-08-17 14:22:48 -040071 r'.*\.js$', r'.*\.py$', r'.*\.sh$', r'.*\.rb$', r'.*\.pl$', r'.*\.pm$',
Mike Frysingerae409522014-02-01 03:16:11 -050072 # No extension at all, note that ALL CAPS files are black listed in
73 # COMMON_EXCLUDED_LIST below.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040074 r'(^|.*[\\\/])[^.]+$',
Mike Frysingerae409522014-02-01 03:16:11 -050075 # Other
Mike Frysinger24dd3c52019-08-17 14:22:48 -040076 r'.*\.java$', r'.*\.mk$', r'.*\.am$',
77 r'.*\.policy$', r'.*\.conf$', r'.*\.go$',
78 r'(^OWNERS|/OWNERS)',
Ryan Cuiec4d6332011-05-02 14:15:25 -070079]
80
Ryan Cui1562fb82011-05-09 11:01:31 -070081
Ryan Cuiec4d6332011-05-02 14:15:25 -070082COMMON_EXCLUDED_PATHS = [
Daniel Erate3ea3fc2015-02-13 15:27:52 -070083 # For ebuild trees, ignore any caches and manifest data.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040084 r'.*/Manifest$',
85 r'.*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$',
Doug Anderson5bfb6792011-10-25 16:45:41 -070086
Daniel Erate3ea3fc2015-02-13 15:27:52 -070087 # Ignore profiles data (like overlay-tegra2/profiles).
Mike Frysinger24dd3c52019-08-17 14:22:48 -040088 r'(^|.*/)overlay-.*/profiles/.*',
89 r'^profiles/.*$',
Mike Frysinger98638102014-08-28 00:15:08 -040090
C Shapiro8f90e9b2017-06-28 09:54:50 -060091 # Ignore config files in ebuild setup.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040092 r'(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*',
93 r'^chromeos-base/chromeos-bsp.*/files/.*',
C Shapiro8f90e9b2017-06-28 09:54:50 -060094
Daniel Erate3ea3fc2015-02-13 15:27:52 -070095 # Ignore minified js and jquery.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040096 r'.*\.min\.js',
97 r'.*jquery.*\.js',
Mike Frysinger33a458d2014-03-03 17:00:51 -050098
99 # Ignore license files as the content is often taken verbatim.
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400100 r'.*/licenses/.*',
Alex Klein619c0912019-01-30 17:13:23 -0700101
Mike Frysinger13650402019-07-31 14:31:46 -0400102 # Exclude generated protobuf bindings.
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400103 r'.*_pb2\.py$',
104 r'.*\.pb\.go$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700105]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700106
Ken Turnerd07564b2018-02-08 17:57:59 +1100107LICENSE_EXCLUDED_PATHS = [
LaMont Jones775c2b32020-02-19 17:32:54 -0700108 r'^(.*/)?OWNERS(\..*)?$',
Ken Turnerd07564b2018-02-08 17:57:59 +1100109]
Ryan Cui1562fb82011-05-09 11:01:31 -0700110
Ryan Cui9b651632011-05-11 11:38:58 -0700111_CONFIG_FILE = 'PRESUBMIT.cfg'
112
113
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700114# File containing wildcards, one per line, matching files that should be
115# excluded from presubmit checks. Lines beginning with '#' are ignored.
116_IGNORE_FILE = '.presubmitignore'
117
Cheng Yuehb707c522020-01-02 14:06:59 +0800118
119TEST_FIELD_RE = r'\nTEST=\S+'
120
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700121BLOCKED_TERMS_FILE = 'blocked_terms.txt'
122UNBLOCKED_TERMS_FILE = 'unblocked_terms.txt'
123
Doug Anderson44a644f2011-11-02 10:37:37 -0700124# Exceptions
125
126
127class BadInvocation(Exception):
128 """An Exception indicating a bad invocation of the program."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700129
130
Ryan Cui1562fb82011-05-09 11:01:31 -0700131# General Helpers
132
Sean Paulba01d402011-05-05 11:36:23 -0400133
Mike Frysingerb2496652019-09-12 23:35:46 -0400134class Cache(object):
135 """General helper for caching git content."""
136
137 def __init__(self):
138 self._cache = {}
139
140 def get_subcache(self, scope):
141 return self._cache.setdefault(scope, {})
142
143 def clear(self):
144 self._cache.clear()
145
146CACHE = Cache()
147
148
Alex Deymo643ac4c2015-09-03 10:40:50 -0700149Project = collections.namedtuple('Project', ['name', 'dir', 'remote'])
150
151
Mike Frysinger526a5f82019-09-13 18:05:30 -0400152def _run_command(cmd, **kwargs):
Doug Anderson44a644f2011-11-02 10:37:37 -0700153 """Executes the passed in command and returns raw stdout output.
154
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400155 This is a convenience func to set some run defaults differently.
Mike Frysinger526a5f82019-09-13 18:05:30 -0400156
Doug Anderson44a644f2011-11-02 10:37:37 -0700157 Args:
158 cmd: The command to run; should be a list of strings.
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400159 **kwargs: Same as cros_build_lib.run.
Doug Anderson44a644f2011-11-02 10:37:37 -0700160
161 Returns:
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700162 The stdout from the process (discards stderr and returncode).
Doug Anderson44a644f2011-11-02 10:37:37 -0700163 """
Mike Frysinger526a5f82019-09-13 18:05:30 -0400164 kwargs.setdefault('print_cmd', False)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400165 kwargs.setdefault('stdout', True)
166 kwargs.setdefault('check', False)
Mike Frysinger054c1592019-11-18 03:51:54 -0500167 result = cros_build_lib.run(cmd, **kwargs)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400168 # NB: We decode this directly rather than through kwargs as our tests rely
169 # on this post-processing behavior currently.
Mike Frysinger71e643e2019-09-13 17:26:39 -0400170 return result.output.decode('utf-8', 'replace')
Ryan Cui72834d12011-05-05 14:51:33 -0700171
Ryan Cui1562fb82011-05-09 11:01:31 -0700172
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700173def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700174 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700175 if __name__ == '__main__':
176 # Works when file is run on its own (__file__ is defined)...
177 return os.path.abspath(os.path.dirname(__file__))
178 else:
179 # We need to do this when we're run through repo. Since repo executes
180 # us with execfile(), we don't get __file__ defined.
181 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
182 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700183
Ryan Cui1562fb82011-05-09 11:01:31 -0700184
Ryan Cuiec4d6332011-05-02 14:15:25 -0700185def _match_regex_list(subject, expressions):
186 """Try to match a list of regular expressions to a string.
187
188 Args:
189 subject: The string to match regexes on
190 expressions: A list of regular expressions to check for matches with.
191
192 Returns:
193 Whether the passed in subject matches any of the passed in regexes.
194 """
195 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500196 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700197 return True
198 return False
199
Ryan Cui1562fb82011-05-09 11:01:31 -0700200
Mike Frysingerae409522014-02-01 03:16:11 -0500201def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700202 """Filter out files based on the conditions passed in.
203
204 Args:
205 files: list of filepaths to filter
206 include_list: list of regex that when matched with a file path will cause it
207 to be added to the output list unless the file is also matched with a
208 regex in the exclude_list.
209 exclude_list: list of regex that when matched with a file will prevent it
210 from being added to the output list, even if it is also matched with a
211 regex in the include_list.
212
213 Returns:
214 A list of filepaths that contain files matched in the include_list and not
215 in the exclude_list.
216 """
217 filtered = []
218 for f in files:
219 if (_match_regex_list(f, include_list) and
220 not _match_regex_list(f, exclude_list)):
221 filtered.append(f)
222 return filtered
223
Ryan Cuiec4d6332011-05-02 14:15:25 -0700224
225# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700226
227
Ryan Cui4725d952011-05-05 15:41:19 -0700228def _get_upstream_branch():
229 """Returns the upstream tracking branch of the current branch.
230
231 Raises:
232 Error if there is no tracking branch
233 """
234 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
235 current_branch = current_branch.replace('refs/heads/', '')
236 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700237 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700238
239 cfg_option = 'branch.' + current_branch + '.%s'
240 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
241 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
242 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700243 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700244
245 return full_upstream.replace('heads', 'remotes/' + remote)
246
Ryan Cui1562fb82011-05-09 11:01:31 -0700247
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700248def _get_patch(commit):
249 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700250 if commit == PRE_SUBMIT:
251 return _run_command(['git', 'diff', '--cached', 'HEAD'])
252 else:
253 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700254
Ryan Cui1562fb82011-05-09 11:01:31 -0700255
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500256def _get_file_content(path, commit):
257 """Returns the content of a file at a specific commit.
258
259 We can't rely on the file as it exists in the filesystem as people might be
260 uploading a series of changes which modifies the file multiple times.
261
262 Note: The "content" of a symlink is just the target. So if you're expecting
263 a full file, you should check that first. One way to detect is that the
264 content will not have any newlines.
265 """
Mike Frysingerb2496652019-09-12 23:35:46 -0400266 # Make sure people don't accidentally pass in full paths which will never
267 # work. You need to use relative=True with _get_affected_files.
268 if path.startswith('/'):
269 raise ValueError('_get_file_content must be called with relative paths: %s'
270 % (path,))
271
272 # {<commit>: {<path1>: <content>, <path2>: <content>}}
273 cache = CACHE.get_subcache('get_file_content')
274 if path in cache:
275 return cache[path]
276
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700277 if commit == PRE_SUBMIT:
Mike Frysingerb2496652019-09-12 23:35:46 -0400278 content = _run_command(['git', 'diff', 'HEAD', path])
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700279 else:
Mike Frysingerb2496652019-09-12 23:35:46 -0400280 content = _run_command(['git', 'show', '%s:%s' % (commit, path)])
281 cache[path] = content
282 return content
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500283
284
Mike Frysingerae409522014-02-01 03:16:11 -0500285def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700286 """Returns a list of (linenum, lines) tuples that the commit touched."""
Mike Frysingerb2496652019-09-12 23:35:46 -0400287 # {<commit>: {<path1>: <content>, <path2>: <content>}}
288 cache = CACHE.get_subcache('get_file_diff')
289 if path in cache:
290 return cache[path]
291
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700292 if commit == PRE_SUBMIT:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800293 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD',
294 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700295 else:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800296 command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit,
297 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700298 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700299
300 new_lines = []
301 line_num = 0
302 for line in output.splitlines():
303 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
304 if m:
305 line_num = int(m.groups(1)[0])
306 continue
307 if line.startswith('+') and not line.startswith('++'):
Mike Frysinger71e643e2019-09-13 17:26:39 -0400308 new_lines.append((line_num, line[1:]))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700309 if not line.startswith('-'):
310 line_num += 1
Mike Frysingerb2496652019-09-12 23:35:46 -0400311 cache[path] = new_lines
Ryan Cuiec4d6332011-05-02 14:15:25 -0700312 return new_lines
313
Ryan Cui1562fb82011-05-09 11:01:31 -0700314
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700315def _get_ignore_wildcards(directory, cache):
316 """Get wildcards listed in a directory's _IGNORE_FILE.
317
318 Args:
319 directory: A string containing a directory path.
320 cache: A dictionary (opaque to caller) caching previously-read wildcards.
321
322 Returns:
323 A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE
324 wasn't present.
325 """
326 # In the cache, keys are directories and values are lists of wildcards from
327 # _IGNORE_FILE within those directories (and empty if no file was present).
328 if directory not in cache:
329 wildcards = []
330 dotfile_path = os.path.join(directory, _IGNORE_FILE)
331 if os.path.exists(dotfile_path):
332 # TODO(derat): Consider using _get_file_content() to get the file as of
333 # this commit instead of the on-disk version. This may have a noticeable
334 # performance impact, as each call to _get_file_content() runs git.
335 with open(dotfile_path, 'r') as dotfile:
336 for line in dotfile.readlines():
337 line = line.strip()
338 if line.startswith('#'):
339 continue
340 if line.endswith('/'):
341 line += '*'
342 wildcards.append(line)
343 cache[directory] = wildcards
344
345 return cache[directory]
346
347
348def _path_is_ignored(path, cache):
349 """Check whether a path is ignored by _IGNORE_FILE.
350
351 Args:
352 path: A string containing a path.
353 cache: A dictionary (opaque to caller) caching previously-read wildcards.
354
355 Returns:
356 True if a file named _IGNORE_FILE in one of the passed-in path's parent
357 directories contains a wildcard matching the path.
358 """
359 # Skip ignore files.
360 if os.path.basename(path) == _IGNORE_FILE:
361 return True
362
363 path = os.path.abspath(path)
364 base = os.getcwd()
365
366 prefix = os.path.dirname(path)
367 while prefix.startswith(base):
368 rel_path = path[len(prefix) + 1:]
369 for wildcard in _get_ignore_wildcards(prefix, cache):
370 if fnmatch.fnmatch(rel_path, wildcard):
371 return True
372 prefix = os.path.dirname(prefix)
373
374 return False
375
376
Mike Frysinger292b45d2014-11-25 01:17:10 -0500377def _get_affected_files(commit, include_deletes=False, relative=False,
378 include_symlinks=False, include_adds=True,
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700379 full_details=False, use_ignore_files=True):
Peter Ammon811f6702014-06-12 15:45:38 -0700380 """Returns list of file paths that were modified/added, excluding symlinks.
381
382 Args:
383 commit: The commit
384 include_deletes: If true, we'll include deleted files in the result
385 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500386 include_symlinks: If true, we'll include symlinks in the result
387 include_adds: If true, we'll include new files in the result
388 full_details: If False, return filenames, else return structured results.
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700389 use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files.
Peter Ammon811f6702014-06-12 15:45:38 -0700390
391 Returns:
392 A list of modified/added (and perhaps deleted) files
393 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500394 if not relative and full_details:
395 raise ValueError('full_details only supports relative paths currently')
396
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700397 if commit == PRE_SUBMIT:
398 return _run_command(['git', 'diff-index', '--cached',
399 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500400
401 path = os.getcwd()
Mike Frysingerb2496652019-09-12 23:35:46 -0400402 # {<commit>: {<path1>: <content>, <path2>: <content>}}
403 cache = CACHE.get_subcache('get_affected_files')
404 if path not in cache:
405 cache[path] = git.RawDiff(path, '%s^!' % commit)
406 files = cache[path]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500407
408 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500409 if not include_symlinks:
410 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500411
412 if not include_deletes:
413 files = [x for x in files if x.status != 'D']
414
Mike Frysinger292b45d2014-11-25 01:17:10 -0500415 if not include_adds:
416 files = [x for x in files if x.status != 'A']
417
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700418 if use_ignore_files:
419 cache = {}
420 is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache)
421 files = [x for x in files if not is_ignored(x)]
422
Mike Frysinger292b45d2014-11-25 01:17:10 -0500423 if full_details:
424 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500425 return files
426 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500427 # Caller only cares about filenames.
428 files = [x.dst_file if x.dst_file else x.src_file for x in files]
429 if relative:
430 return files
431 else:
432 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700433
434
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700435def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700436 """Returns a list of commits for this review."""
Mike Frysingere300c7d2019-09-12 23:33:52 -0400437 cmd = ['git', 'log', '--no-merges', '--format=%H',
438 '%s..' % _get_upstream_branch()]
Ryan Cui72834d12011-05-05 14:51:33 -0700439 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700440
Ryan Cui1562fb82011-05-09 11:01:31 -0700441
Ryan Cuiec4d6332011-05-02 14:15:25 -0700442def _get_commit_desc(commit):
443 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700444 if commit == PRE_SUBMIT:
445 return ''
Mike Frysingerb2496652019-09-12 23:35:46 -0400446
447 # {<commit>: <content>}
448 cache = CACHE.get_subcache('get_commit_desc')
449 if commit not in cache:
Mike Frysinger4efdee72019-11-04 10:57:01 -0500450 cache[commit] = _run_command(['git', 'log', '--format=%B',
Mike Frysingerb2496652019-09-12 23:35:46 -0400451 commit + '^!'])
452 return cache[commit]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700453
454
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800455def _check_lines_in_diff(commit, files, check_callable, error_description):
456 """Checks given file for errors via the given check.
457
458 This is a convenience function for common per-line checks. It goes through all
459 files and returns a HookFailure with the error description listing all the
460 failures.
461
462 Args:
463 commit: The commit we're working on.
464 files: The files to check.
465 check_callable: A callable that takes a line and returns True if this line
466 _fails_ the check.
467 error_description: A string describing the error.
468 """
469 errors = []
470 for afile in files:
471 for line_num, line in _get_file_diff(afile, commit):
Bernie Thompson8e26f742020-07-23 14:32:31 -0700472 result = check_callable(line)
473 if result:
474 msg = f'{afile}, line {line_num}'
475 if isinstance(result, str):
476 msg += f': {result}'
477 errors.append(msg)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800478 if errors:
479 return HookFailure(error_description, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400480 return None
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800481
482
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900483def _parse_common_inclusion_options(options):
484 """Parses common hook options for including/excluding files.
485
486 Args:
487 options: Option string list.
488
489 Returns:
490 (included, excluded) where each one is a list of regex strings.
491 """
492 parser = argparse.ArgumentParser()
493 parser.add_argument('--exclude_regex', action='append')
494 parser.add_argument('--include_regex', action='append')
495 opts = parser.parse_args(options)
496 included = opts.include_regex or []
497 excluded = opts.exclude_regex or []
498 return included, excluded
499
500
Ryan Cuiec4d6332011-05-02 14:15:25 -0700501# Common Hooks
502
Ryan Cui1562fb82011-05-09 11:01:31 -0700503
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900504def _check_no_long_lines(_project, commit, options=()):
Mike Frysinger55f85b52014-12-18 14:45:21 -0500505 """Checks there are no lines longer than MAX_LEN in any of the text files."""
Keigo Oka9732e382019-06-28 17:44:59 +0900506 LONG_LINE_OK_PATHS = [
507 # Go has no line length limit.
508 # https://golang.org/doc/effective_go.html#formatting
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400509 r'.*\.go$',
Mike Frysingerf8961942020-05-15 00:36:31 -0400510 # Python does its own long line checks via pylint.
511 r'.*\.py$',
Keigo Oka9732e382019-06-28 17:44:59 +0900512 ]
Mike Frysinger55f85b52014-12-18 14:45:21 -0500513
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900514 DEFAULT_MAX_LENGTHS = [
515 # Java's line length limit is 100 chars.
516 # https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md
517 (r'.*\.java$', 100),
Mike Frysingerf8961942020-05-15 00:36:31 -0400518 # Rust's line length limit is 100 chars.
519 (r'.*\.rs$', 100),
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900520 ]
521
Ryan Cuiec4d6332011-05-02 14:15:25 -0700522 MAX_LEN = 80
523
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900524 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700525 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900526 included + COMMON_INCLUDED_PATHS,
Keigo Oka9732e382019-06-28 17:44:59 +0900527 excluded + COMMON_EXCLUDED_PATHS + LONG_LINE_OK_PATHS)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700528
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900529 errors = []
Ryan Cuiec4d6332011-05-02 14:15:25 -0700530 for afile in files:
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700531 skip_regexps = (
532 r'https?://',
533 r'^#\s*(define|include|import|pragma|if|ifndef|endif)\b',
534 )
535
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900536 max_len = MAX_LEN
537
538 for expr, length in DEFAULT_MAX_LENGTHS:
539 if re.search(expr, afile):
540 max_len = length
541 break
542
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700543 if os.path.basename(afile).startswith('OWNERS'):
544 # File paths can get long, and there's no way to break them up into
545 # multiple lines.
546 skip_regexps += (
547 r'^include\b',
548 r'file:',
549 )
550
551 skip_regexps = [re.compile(x) for x in skip_regexps]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700552 for line_num, line in _get_file_diff(afile, commit):
553 # Allow certain lines to exceed the maxlen rule.
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900554 if len(line) <= max_len or any(x.search(line) for x in skip_regexps):
Jon Salz98255932012-08-18 14:48:02 +0800555 continue
556
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900557 errors.append('%s, line %s, %s chars, over %s chars' %
558 (afile, line_num, len(line), max_len))
Jon Salz98255932012-08-18 14:48:02 +0800559 if len(errors) == 5: # Just show the first 5 errors.
560 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700561
562 if errors:
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900563 msg = 'Found lines longer than the limit (first 5 shown):'
Ryan Cui1562fb82011-05-09 11:01:31 -0700564 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400565 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700566
Ryan Cuiec4d6332011-05-02 14:15:25 -0700567
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900568def _check_no_stray_whitespace(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700569 """Checks that there is no stray whitespace at source lines end."""
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900570 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700571 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900572 included + COMMON_INCLUDED_PATHS,
573 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800574 return _check_lines_in_diff(commit, files,
575 lambda line: line.rstrip() != line,
576 'Found line ending with white space in:')
Ryan Cui1562fb82011-05-09 11:01:31 -0700577
Ryan Cuiec4d6332011-05-02 14:15:25 -0700578
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900579def _check_no_tabs(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700580 """Checks there are no unexpanded tabs."""
Mike Frysingercd134512017-10-26 04:36:33 -0400581 # Don't add entire repos here. Update the PRESUBMIT.cfg in each repo instead.
582 # We only whitelist known specific filetypes here that show up in all repos.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700583 TAB_OK_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400584 r'.*\.ebuild$',
585 r'.*\.eclass$',
586 r'.*\.go$',
587 r'.*/[M|m]akefile$',
588 r'.*\.mk$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700589 ]
590
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900591 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700592 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900593 included + COMMON_INCLUDED_PATHS,
594 excluded + COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800595 return _check_lines_in_diff(commit, files,
596 lambda line: '\t' in line,
597 'Found a tab character in:')
Ryan Cuiec4d6332011-05-02 14:15:25 -0700598
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800599
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700600def _read_terms_file(terms_file):
601 """Read list of words from file, skipping comments and blank lines."""
602 file_terms = set()
603 for line in osutils.ReadFile(terms_file).splitlines():
604 # Allow comment and blank lines.
605 line = line.split('#', 1)[0]
606 if not line:
607 continue
608 file_terms.add(line)
609 return file_terms
610
611
Bernie Thompson8e26f742020-07-23 14:32:31 -0700612def _check_keywords(_project, commit, options=()):
613 """Checks there are no blocked keywords in commit content."""
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700614 # Read options from override list.
Bernie Thompson8e26f742020-07-23 14:32:31 -0700615 parser = argparse.ArgumentParser()
616 parser.add_argument('--exclude_regex', action='append', default=[])
617 parser.add_argument('--include_regex', action='append', default=[])
618 parser.add_argument('--block', action='append', default=[])
619 parser.add_argument('--unblock', action='append', default=[])
620 opts = parser.parse_args(options)
621
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700622 # Read blocked word list.
623 blocked_terms_file = os.path.join(_get_hooks_dir(), BLOCKED_TERMS_FILE)
624 common_keywords = _read_terms_file(blocked_terms_file)
625
626 # Read unblocked word list. Global list is skipped if local list exists.
627 unblocked_terms_file = os.path.join(_get_hooks_dir(), UNBLOCKED_TERMS_FILE)
628 if os.path.isfile(os.path.join(_project.dir, UNBLOCKED_TERMS_FILE)):
629 unblocked_terms_file = os.path.join(_project.dir, UNBLOCKED_TERMS_FILE)
630 unblocked_words = _read_terms_file(unblocked_terms_file)
631 unblocked_words.update(opts.unblock)
632
Bernie Thompson8e26f742020-07-23 14:32:31 -0700633 keywords = set(common_keywords | set(opts.block))
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700634 keywords = sorted(keywords - unblocked_words)
Bernie Thompson8e26f742020-07-23 14:32:31 -0700635 files = _filter_files(_get_affected_files(commit),
636 opts.include_regex + COMMON_INCLUDED_PATHS,
637 opts.exclude_regex + COMMON_EXCLUDED_PATHS)
638 errors = []
639
640 def _check_line(line):
641 for word in keywords:
642 m = re.search(word, line, flags=re.I)
643 if m:
Bernie Thompson4e362922020-09-02 16:17:50 -0700644 matched = True
645 # The unblock values supercede blocked values, so if any unblock
646 # regex matches a term found by the block list, we ignore it.
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700647 for unblocked in unblocked_words:
Bernie Thompson4e362922020-09-02 16:17:50 -0700648 if re.search(unblocked, m.group(0)):
649 matched = False
650 break
651 if matched:
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700652 return f'Matched "{m[0]}" with regex of "{word}"'
Bernie Thompson8e26f742020-07-23 14:32:31 -0700653 return False
654
655 diff_errors = _check_lines_in_diff(commit, files, _check_line,
656 'Found a blocked keyword in:')
657 if diff_errors:
658 errors.append(diff_errors)
659
660 line_num = 1
661 commit_desc_errors = []
662 for line in _get_commit_desc(commit).splitlines():
663 result = _check_line(line)
664 if result:
665 commit_desc_errors.append('Commit message, line %s: %s' %
666 (line_num, result))
667 line_num += 1
668 if commit_desc_errors:
669 errors.append(HookFailure('Found a blocked keyword in:',
670 commit_desc_errors))
671 return errors
672
673
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900674def _check_tabbed_indents(_project, commit, options=()):
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800675 """Checks that indents use tabs only."""
676 TABS_REQUIRED_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400677 r'.*\.ebuild$',
678 r'.*\.eclass$',
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800679 ]
680 LEADING_SPACE_RE = re.compile('[\t]* ')
681
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900682 included, excluded = _parse_common_inclusion_options(options)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800683 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900684 included + TABS_REQUIRED_PATHS,
685 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800686 return _check_lines_in_diff(
687 commit, files,
688 lambda line: LEADING_SPACE_RE.match(line) is not None,
689 'Found a space in indentation (must be all tabs):')
Ryan Cui1562fb82011-05-09 11:01:31 -0700690
Ryan Cuiec4d6332011-05-02 14:15:25 -0700691
LaMont Jones872fe762020-02-10 15:36:14 -0700692def _check_gofmt(_project, commit, options=()):
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700693 """Checks that Go files are formatted with gofmt."""
LaMont Jones872fe762020-02-10 15:36:14 -0700694 included, excluded = _parse_common_inclusion_options(options)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700695 errors = []
696 files = _filter_files(_get_affected_files(commit, relative=True),
LaMont Jones872fe762020-02-10 15:36:14 -0700697 included + [r'\.go$'],
698 excluded)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700699
700 for gofile in files:
701 contents = _get_file_content(gofile, commit)
Mike Frysingeraa7dc942019-09-25 00:07:24 -0400702 output = _run_command(cmd=['gofmt', '-l'], input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500703 stderr=subprocess.STDOUT)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700704 if output:
705 errors.append(gofile)
706 if errors:
707 return HookFailure('Files not formatted with gofmt:', errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400708 return None
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700709
710
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600711def _check_rustfmt(_project, commit):
712 """Checks that Rust files are formatted with rustfmt."""
713 errors = []
714 files = _filter_files(_get_affected_files(commit, relative=True),
715 [r'\.rs$'])
716
717 for rustfile in files:
718 contents = _get_file_content(rustfile, commit)
Chirantan Ekbote1da56d52020-07-13 17:35:35 +0900719 output = _run_command(cmd=['rustfmt', '--edition', '2018'],
720 input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500721 stderr=subprocess.STDOUT)
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600722 if output != contents:
723 errors.append(rustfile)
724 if errors:
725 return HookFailure('Files not formatted with rustfmt: '
726 "(run 'cargo fmt' to fix)", errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400727 return None
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600728
729
Keiichi Watanabe6ab73fd2020-07-14 23:42:02 +0900730class CargoClippyArgumentParserError(Exception):
731 """An exception indicating an invalid check_cargo_clippy option."""
732
733
734class CargoClippyArgumentParser(argparse.ArgumentParser):
735 """A argument parser for check_cargo_clippy."""
736
737 def error(self, message):
738 raise CargoClippyArgumentParserError(message)
739
740
741# A cargo project in which clippy runs.
742ClippyProject = collections.namedtuple('ClippyProject', ('root', 'script'))
743
744
745class _AddClippyProjectAction(argparse.Action):
746 """A callback that adds a cargo clippy setting.
747
748 It accepts a value which is in the form of "ROOT[:SCRIPT]".
749 """
750
751 def __call__(self, parser, namespace, values, option_string=None):
752 if getattr(namespace, self.dest, None) is None:
753 setattr(namespace, self.dest, [])
754 spec = values.split(':', 1)
755 if len(spec) == 1:
756 spec += [None]
757
758 if spec[0].startswith('/'):
759 raise CargoClippyArgumentParserError('root path must not start with "/"'
760 f' but "{spec[0]}"')
761
762 clippy = ClippyProject(root=spec[0], script=spec[1])
763 getattr(namespace, self.dest).append(clippy)
764
765
766def _get_cargo_clippy_parser():
767 """Creates a parser for check_cargo_clippy options."""
768
769 parser = CargoClippyArgumentParser()
770 parser.add_argument('--project', action=_AddClippyProjectAction, default=[])
771
772 return parser
773
774
775def _check_cargo_clippy(project, commit, options=()):
776 """Checks that a change doesn't produce cargo-clippy errors."""
777
778 options = list(options)
779 if not options:
780 return []
781 parser = _get_cargo_clippy_parser()
782
783 try:
784 opts = parser.parse_args(options)
785 except CargoClippyArgumentParserError as e:
786 return [HookFailure('invalid check_cargo_clippy option is given.'
787 f' Please check PRESUBMIT.cfg is correct: {e}')]
788 files = _get_affected_files(commit)
789
790 errors = []
791 for clippy in opts.project:
792 root = os.path.normpath(os.path.join(project.dir, clippy.root))
793
794 # Check if any file under `root` was modified.
795 modified = False
796 for f in files:
797 if f.startswith(root):
798 modified = True
799 break
800 if not modified:
801 continue
802
803 # Clean cargo's cache when we run clippy for this `root` for the first time.
804 # We don't want to clean the cache between commits to save time when
805 # multiple commits are checked.
806 if root not in _check_cargo_clippy.cleaned_root:
807 _run_command(['cargo', 'clean',
808 f'--manifest-path={root}/Cargo.toml'],
809 stderr=subprocess.STDOUT)
810 _check_cargo_clippy.cleaned_root.add(root)
811
812 cmd = ['cargo', 'clippy', '--all-features', '--all-targets',
813 f'--manifest-path={root}/Cargo.toml',
814 '--', '-D', 'warnings']
815 # Overwrite the clippy command if a project-specific script is specified.
816 if clippy.script:
817 cmd = [os.path.join(project.dir, clippy.script)]
818
819 output = _run_command(cmd, stderr=subprocess.STDOUT)
820 error = re.search(r'^error: ', output, flags=re.MULTILINE)
821 if error:
822 msg = output[error.start():]
823 errors.append(HookFailure(msg))
824
825 return errors
826
827
828# Stores cargo projects in which `cargo clean` ran.
829_check_cargo_clippy.cleaned_root = set()
830
831
Mike Frysingerae409522014-02-01 03:16:11 -0500832def _check_change_has_test_field(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700833 """Check for a non-empty 'TEST=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500834 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700835
Cheng Yuehb707c522020-01-02 14:06:59 +0800836 if not re.search(TEST_FIELD_RE, _get_commit_desc(commit)):
Mike Frysingered9b2a02019-12-12 18:52:32 -0500837 msg = ('Changelist description needs TEST field (after first line)\n%s' %
838 (SEE_ALSO,))
Ryan Cui1562fb82011-05-09 11:01:31 -0700839 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400840 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700841
Ryan Cuiec4d6332011-05-02 14:15:25 -0700842
Mike Frysingerae409522014-02-01 03:16:11 -0500843def _check_change_has_valid_cq_depend(_project, commit):
Jason D. Clinton299e3222019-05-23 09:42:03 -0600844 """Check for a correctly formatted Cq-Depend field in the commit message."""
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700845 desc = _get_commit_desc(commit)
Jason D. Clinton299e3222019-05-23 09:42:03 -0600846 msg = 'Changelist has invalid Cq-Depend target.'
847 example = 'Example: Cq-Depend: chromium:1234, chrome-internal:2345'
David Jamesc3b68b32013-04-03 09:17:03 -0700848 try:
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700849 patch.GetPaladinDeps(desc)
David Jamesc3b68b32013-04-03 09:17:03 -0700850 except ValueError as ex:
851 return HookFailure(msg, [example, str(ex)])
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700852 # Check that Cq-Depend is in the same paragraph as Change-Id.
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500853 msg = 'Cq-Depend is not in the same paragraph as Change-Id.'
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700854 paragraphs = desc.split('\n\n')
855 for paragraph in paragraphs:
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500856 if (re.search(r'^Cq-Depend:', paragraph, re.M) and not
857 re.search('^Change-Id:', paragraph, re.M)):
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700858 return HookFailure(msg)
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500859
860 # We no longer support CQ-DEPEND= lines.
861 if re.search(r'^CQ-DEPEND[=:]', desc, re.M):
862 return HookFailure(
863 'CQ-DEPEND= is no longer supported. Please see:\n'
864 'https://chromium.googlesource.com/chromiumos/docs/+/HEAD/'
865 'contributing.md#CQ-DEPEND')
866
Mike Frysinger8cf80812019-09-16 23:49:29 -0400867 return None
David Jamesc3b68b32013-04-03 09:17:03 -0700868
869
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800870def _check_change_is_contribution(_project, commit):
871 """Check that the change is a contribution."""
872 NO_CONTRIB = 'not a contribution'
873 if NO_CONTRIB in _get_commit_desc(commit).lower():
874 msg = ('Changelist is not a contribution, this cannot be accepted.\n'
875 'Please remove the "%s" text from the commit message.') % NO_CONTRIB
876 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400877 return None
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800878
879
Alex Deymo643ac4c2015-09-03 10:40:50 -0700880def _check_change_has_bug_field(project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700881 """Check for a correctly formatted 'BUG=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500882 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
883
David James5c0073d2013-04-03 08:48:52 -0700884 OLD_BUG_RE = r'\nBUG=.*chromium-os'
885 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
886 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
887 'the chromium tracker in your BUG= line now.')
888 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700889
Alex Deymo643ac4c2015-09-03 10:40:50 -0700890 # Android internal and external projects use "Bug: " to track bugs in
891 # buganizer.
892 BUG_COLON_REMOTES = (
893 'aosp',
894 'goog',
895 )
896 if project.remote in BUG_COLON_REMOTES:
897 BUG_RE = r'\nBug: ?([Nn]one|\d+)'
898 if not re.search(BUG_RE, _get_commit_desc(commit)):
899 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500900 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700901 'Bug: 9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500902 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700903 return HookFailure(msg)
904 else:
Jorge Lucangeli Obesdce214e2017-10-25 15:04:39 -0400905 BUG_RE = r'\nBUG=([Nn]one|(chromium|b):\d+)'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700906 if not re.search(BUG_RE, _get_commit_desc(commit)):
907 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500908 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700909 'BUG=chromium:9999 (for public tracker)\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700910 'BUG=b:9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500911 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700912 return HookFailure(msg)
Ryan Cui1562fb82011-05-09 11:01:31 -0700913
Cheng Yuehb707c522020-01-02 14:06:59 +0800914 TEST_BEFORE_BUG_RE = TEST_FIELD_RE + r'.*' + BUG_RE
915
916 if re.search(TEST_BEFORE_BUG_RE, _get_commit_desc(commit), re.DOTALL):
917 msg = ('The BUG field must come before the TEST field.\n%s' %
918 (SEE_ALSO,))
919 return HookFailure(msg)
920
Mike Frysinger8cf80812019-09-16 23:49:29 -0400921 return None
922
Ryan Cuiec4d6332011-05-02 14:15:25 -0700923
Jack Neus8edbf642019-07-10 16:08:31 -0600924def _check_change_no_include_oem(project, commit):
925 """Check that the change does not reference OEMs."""
926 ALLOWLIST = {
927 'chromiumos/platform/ec',
928 # Used by unit tests.
929 'project',
930 }
931 if project.name not in ALLOWLIST:
932 return None
933
Mike Frysingerbb34a222019-07-31 14:40:46 -0400934 TAGS = {
Jack Neus8edbf642019-07-10 16:08:31 -0600935 'Reviewed-on',
936 'Reviewed-by',
937 'Signed-off-by',
938 'Commit-Ready',
939 'Tested-by',
940 'Commit-Queue',
Jack Neus8edbf642019-07-10 16:08:31 -0600941 'Acked-by',
942 'Modified-by',
943 'CC',
944 'Suggested-by',
945 'Reported-by',
946 'Acked-for-chrome-by',
LaMont Jones237f3ef2020-01-22 10:40:52 -0700947 'Cq-Cl-Tag',
LaMont Jonesfb5e8bf2020-03-03 12:50:06 -0700948 'Cq-Include-Trybots',
Mike Frysingerbb34a222019-07-31 14:40:46 -0400949 }
Jack Neus8edbf642019-07-10 16:08:31 -0600950
951 # Ignore tags, which could reasonably contain OEM names
952 # (e.g. Reviewed-by: foo@oem.corp-partner.google.com).
Jack Neus8edbf642019-07-10 16:08:31 -0600953 commit_message = ' '.join(
Mike Frysingerbb34a222019-07-31 14:40:46 -0400954 x for x in _get_commit_desc(commit).splitlines()
955 if ':' not in x or x.split(':', 1)[0] not in TAGS)
956
Jack Neus8edbf642019-07-10 16:08:31 -0600957 commit_message = re.sub(r'[\s_-]+', ' ', commit_message)
958
959 # Exercise caution when expanding these lists. Adding a name
960 # could indicate a new relationship with a company!
961 OEMS = ['hp', 'hewlett packard', 'dell', 'lenovo', 'acer', 'asus', 'samsung']
962 ODMS = [
963 'bitland', 'compal', 'haier', 'huaqin', 'inventec', 'lg', 'pegatron',
964 'pegatron(ems)', 'quanta', 'samsung', 'wistron'
965 ]
966
967 for name_type, name_list in [('OEM', OEMS), ('ODM', ODMS)]:
968 # Construct regex
969 name_re = r'\b(%s)\b' % '|'.join([re.escape(x) for x in name_list])
970 matches = [x[0] for x in re.findall(name_re, commit_message, re.IGNORECASE)]
Mike Frysingere52b1bc2019-09-16 23:45:41 -0400971 if matches:
Jack Neus8edbf642019-07-10 16:08:31 -0600972 # If there's a match, throw an error.
973 error_msg = ('Changelist description contains the name of an'
974 ' %s: "%s".' % (name_type, '","'.join(matches)))
975 return HookFailure(error_msg)
976
Mike Frysinger8cf80812019-09-16 23:49:29 -0400977 return None
978
Jack Neus8edbf642019-07-10 16:08:31 -0600979
Mike Frysinger292b45d2014-11-25 01:17:10 -0500980def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -0700981 """Check that we're not missing a revbump of an ebuild in the given commit.
982
983 If the given commit touches files in a directory that has ebuilds somewhere
984 up the directory hierarchy, it's very likely that we need an ebuild revbump
985 in order for those changes to take effect.
986
987 It's not totally trivial to detect a revbump, so at least detect that an
988 ebuild with a revision number in it was touched. This should handle the
989 common case where we use a symlink to do the revbump.
990
991 TODO: it would be nice to enhance this hook to:
992 * Handle cases where people revbump with a slightly different syntax. I see
993 one ebuild (puppy) that revbumps with _pN. This is a false positive.
994 * Catches cases where people aren't using symlinks for revbumps. If they
995 edit a revisioned file directly (and are expected to rename it for revbump)
996 we'll miss that. Perhaps we could detect that the file touched is a
997 symlink?
998
999 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
1000 still better off than without this check.
1001
1002 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001003 project: The Project to look at
Doug Anderson42b8a052013-06-26 10:45:36 -07001004 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -05001005 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -07001006
1007 Returns:
1008 A HookFailure or None.
1009 """
Mike Frysinger011af942014-01-17 16:12:22 -05001010 # If this is the portage-stable overlay, then ignore the check. It's rare
1011 # that we're doing anything other than importing files from upstream, so
1012 # forcing a rev bump makes no sense.
1013 whitelist = (
1014 'chromiumos/overlays/portage-stable',
1015 )
Alex Deymo643ac4c2015-09-03 10:40:50 -07001016 if project.name in whitelist:
Mike Frysinger011af942014-01-17 16:12:22 -05001017 return None
1018
Mike Frysinger292b45d2014-11-25 01:17:10 -05001019 def FinalName(obj):
1020 # If the file is being deleted, then the dst_file is not set.
1021 if obj.dst_file is None:
1022 return obj.src_file
1023 else:
1024 return obj.dst_file
1025
1026 affected_path_objs = _get_affected_files(
1027 commit, include_deletes=True, include_symlinks=True, relative=True,
1028 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -07001029
1030 # Don't yell about changes to whitelisted files...
Mike Frysinger550c05c2019-12-09 18:16:36 -05001031 whitelist = {'ChangeLog', 'Manifest', 'metadata.xml'}
Mike Frysinger292b45d2014-11-25 01:17:10 -05001032 affected_path_objs = [x for x in affected_path_objs
1033 if os.path.basename(FinalName(x)) not in whitelist]
1034 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -07001035 return None
1036
1037 # If we've touched any file named with a -rN.ebuild then we'll say we're
1038 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -05001039 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
1040 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -07001041 if touched_revved_ebuild:
1042 return None
1043
Mike Frysinger292b45d2014-11-25 01:17:10 -05001044 # If we're creating new ebuilds from scratch, then we don't need an uprev.
1045 # Find all the dirs that new ebuilds and ignore their files/.
1046 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
1047 if FinalName(x).endswith('.ebuild') and x.status == 'A']
1048 affected_path_objs = [obj for obj in affected_path_objs
1049 if not any(FinalName(obj).startswith(x)
1050 for x in ebuild_dirs)]
1051 if not affected_path_objs:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001052 return None
Mike Frysinger292b45d2014-11-25 01:17:10 -05001053
Doug Anderson42b8a052013-06-26 10:45:36 -07001054 # We want to examine the current contents of all directories that are parents
1055 # of files that were touched (up to the top of the project).
1056 #
1057 # ...note: we use the current directory contents even though it may have
1058 # changed since the commit we're looking at. This is just a heuristic after
1059 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -05001060 if project_top is None:
1061 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -07001062 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -05001063 for obj in affected_path_objs:
1064 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -07001065 while os.path.exists(path) and not os.path.samefile(path, project_top):
1066 dirs_to_check.add(path)
1067 path = os.path.dirname(path)
1068
1069 # Look through each directory. If it's got an ebuild in it then we'll
1070 # consider this as a case when we need a revbump.
Gwendal Grignoua3086c32014-12-09 11:17:22 -08001071 affected_paths = set(os.path.join(project_top, FinalName(x))
1072 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -07001073 for dir_path in dirs_to_check:
1074 contents = os.listdir(dir_path)
1075 ebuilds = [os.path.join(dir_path, path)
1076 for path in contents if path.endswith('.ebuild')]
1077 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
1078
C Shapiroae157ae2017-09-18 16:24:03 -06001079 affected_paths_under_9999_ebuilds = set()
1080 for affected_path in affected_paths:
1081 for ebuild_9999 in ebuilds_9999:
1082 ebuild_dir = os.path.dirname(ebuild_9999)
1083 if affected_path.startswith(ebuild_dir):
1084 affected_paths_under_9999_ebuilds.add(affected_path)
1085
1086 # If every file changed exists under a 9999 ebuild, then skip
1087 if len(affected_paths_under_9999_ebuilds) == len(affected_paths):
1088 continue
1089
Doug Anderson42b8a052013-06-26 10:45:36 -07001090 # If the -9999.ebuild file was touched the bot will uprev for us.
1091 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -05001092 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -07001093 continue
1094
1095 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -05001096 return HookFailure('Changelist probably needs a revbump of an ebuild, '
1097 'or a -r1.ebuild symlink if this is a new ebuild:\n'
1098 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -07001099
1100 return None
1101
1102
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001103def _check_ebuild_eapi(project, commit):
Mike Frysinger948284a2018-02-01 15:22:56 -05001104 """Make sure we have people use EAPI=5 or newer with custom ebuilds.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001105
1106 We want to get away from older EAPI's as it makes life confusing and they
1107 have less builtin error checking.
1108
1109 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001110 project: The Project to look at
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001111 commit: The commit to look at
1112
1113 Returns:
1114 A HookFailure or None.
1115 """
1116 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -05001117 # that we're doing anything other than importing files from upstream, and
1118 # we shouldn't be rewriting things fundamentally anyways.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001119 whitelist = (
1120 'chromiumos/overlays/portage-stable',
1121 )
Alex Deymo643ac4c2015-09-03 10:40:50 -07001122 if project.name in whitelist:
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001123 return None
1124
Mike Frysinger948284a2018-02-01 15:22:56 -05001125 BAD_EAPIS = ('0', '1', '2', '3', '4')
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001126
1127 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
1128
1129 ebuilds_re = [r'\.ebuild$']
1130 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1131 ebuilds_re)
1132 bad_ebuilds = []
1133
1134 for ebuild in ebuilds:
1135 # If the ebuild does not specify an EAPI, it defaults to 0.
1136 eapi = '0'
1137
1138 lines = _get_file_content(ebuild, commit).splitlines()
1139 if len(lines) == 1:
1140 # This is most likely a symlink, so skip it entirely.
1141 continue
1142
1143 for line in lines:
1144 m = get_eapi.match(line)
1145 if m:
1146 # Once we hit the first EAPI line in this ebuild, stop processing.
1147 # The spec requires that there only be one and it be first, so
1148 # checking all possible values is pointless. We also assume that
1149 # it's "the" EAPI line and not something in the middle of a heredoc.
1150 eapi = m.group(1)
1151 break
1152
1153 if eapi in BAD_EAPIS:
1154 bad_ebuilds.append((ebuild, eapi))
1155
1156 if bad_ebuilds:
1157 # pylint: disable=C0301
Mike Frysingerc6114f42020-05-15 00:55:05 -04001158 url = 'https://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001159 # pylint: enable=C0301
1160 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -05001161 'These ebuilds are using old EAPIs. If these are imported from\n'
1162 'Gentoo, then you may ignore and upload once with the --no-verify\n'
Mike Frysingerc6114f42020-05-15 00:55:05 -04001163 'flag. Otherwise, please update to 7 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001164 '\t%s\n'
1165 'See this guide for more details:\n%s\n' %
1166 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
1167
Mike Frysinger8cf80812019-09-16 23:49:29 -04001168 return None
1169
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001170
Mike Frysinger89bdb852014-02-01 05:26:26 -05001171def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -05001172 """Make sure we use the new style KEYWORDS when possible in ebuilds.
1173
1174 If an ebuild generally does not care about the arch it is running on, then
1175 ebuilds should flag it with one of:
1176 KEYWORDS="*" # A stable ebuild.
1177 KEYWORDS="~*" # An unstable ebuild.
1178 KEYWORDS="-* ..." # Is known to only work on specific arches.
1179
1180 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001181 project: The Project to look at
Mike Frysingerc51ece72014-01-17 16:23:40 -05001182 commit: The commit to look at
1183
1184 Returns:
1185 A HookFailure or None.
1186 """
1187 WHITELIST = set(('*', '-*', '~*'))
1188
1189 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
1190
Mike Frysinger89bdb852014-02-01 05:26:26 -05001191 ebuilds_re = [r'\.ebuild$']
1192 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1193 ebuilds_re)
1194
Mike Frysinger8d42d742014-09-22 15:50:21 -04001195 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -05001196 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -04001197 # We get the full content rather than a diff as the latter does not work
1198 # on new files (like when adding new ebuilds).
1199 lines = _get_file_content(ebuild, commit).splitlines()
1200 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -05001201 m = get_keywords.match(line)
1202 if m:
1203 keywords = set(m.group(1).split())
1204 if not keywords or WHITELIST - keywords != WHITELIST:
1205 continue
1206
Mike Frysinger8d42d742014-09-22 15:50:21 -04001207 bad_ebuilds.append(ebuild)
1208
1209 if bad_ebuilds:
1210 return HookFailure(
1211 '%s\n'
1212 'Please update KEYWORDS to use a glob:\n'
1213 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
1214 ' KEYWORDS="*"\n'
1215 'If the ebuild should be marked unstable (normal for '
1216 'cros-workon / 9999 ebuilds):\n'
1217 ' KEYWORDS="~*"\n'
Mike Frysingerde8efea2015-05-17 03:42:26 -04001218 'If the ebuild needs to be marked for only specific arches, '
Mike Frysinger8d42d742014-09-22 15:50:21 -04001219 'then use -* like so:\n'
1220 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -05001221
Mike Frysinger8cf80812019-09-16 23:49:29 -04001222 return None
1223
Mike Frysingerc51ece72014-01-17 16:23:40 -05001224
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001225def _check_ebuild_licenses(_project, commit):
1226 """Check if the LICENSE field in the ebuild is correct."""
Brian Norris7a610e82016-02-17 12:24:54 -08001227 affected_paths = _get_affected_files(commit, relative=True)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001228 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
1229
1230 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -08001231 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001232
1233 for ebuild in touched_ebuilds:
1234 # Skip virutal packages.
1235 if ebuild.split('/')[-3] == 'virtual':
1236 continue
1237
Alex Kleinb5953522018-08-03 11:44:21 -06001238 # e.g. path/to/overlay/category/package/package.ebuild -> path/to/overlay
1239 overlay_path = os.sep.join(ebuild.split(os.sep)[:-3])
1240
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001241 try:
Brian Norris7a610e82016-02-17 12:24:54 -08001242 ebuild_content = _get_file_content(ebuild, commit)
Alex Kleinb5953522018-08-03 11:44:21 -06001243 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content,
1244 overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001245 except ValueError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001246 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001247
1248 # Also ignore licenses ending with '?'
1249 for license_type in [x for x in license_types
1250 if x not in LICENSES_IGNORE and not x.endswith('?')]:
1251 try:
Alex Kleinb5953522018-08-03 11:44:21 -06001252 licenses_lib.Licensing.FindLicenseType(license_type,
1253 overlay_path=overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001254 except AssertionError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001255 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001256
Mike Frysinger8cf80812019-09-16 23:49:29 -04001257 return None
1258
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001259
Mike Frysingercd363c82014-02-01 05:20:18 -05001260def _check_ebuild_virtual_pv(project, commit):
1261 """Enforce the virtual PV policies."""
1262 # If this is the portage-stable overlay, then ignore the check.
1263 # We want to import virtuals as-is from upstream Gentoo.
1264 whitelist = (
1265 'chromiumos/overlays/portage-stable',
1266 )
Alex Deymo643ac4c2015-09-03 10:40:50 -07001267 if project.name in whitelist:
Mike Frysingercd363c82014-02-01 05:20:18 -05001268 return None
1269
1270 # We assume the repo name is the same as the dir name on disk.
1271 # It would be dumb to not have them match though.
Alex Deymo643ac4c2015-09-03 10:40:50 -07001272 project_base = os.path.basename(project.name)
Mike Frysingercd363c82014-02-01 05:20:18 -05001273
1274 is_variant = lambda x: x.startswith('overlay-variant-')
1275 is_board = lambda x: x.startswith('overlay-')
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001276 is_baseboard = lambda x: x.startswith('baseboard-')
1277 is_chipset = lambda x: x.startswith('chipset-')
1278 is_project = lambda x: x.startswith('project-')
Mike Frysingercd363c82014-02-01 05:20:18 -05001279 is_private = lambda x: x.endswith('-private')
1280
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001281 is_special_overlay = lambda x: (is_board(x) or is_chipset(x) or
1282 is_baseboard(x) or is_project(x))
1283
Mike Frysingercd363c82014-02-01 05:20:18 -05001284 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
1285
1286 ebuilds_re = [r'\.ebuild$']
1287 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1288 ebuilds_re)
1289 bad_ebuilds = []
1290
1291 for ebuild in ebuilds:
1292 m = get_pv.match(ebuild)
1293 if m:
1294 overlay = m.group(1)
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001295 if not overlay or not is_special_overlay(overlay):
Alex Deymo643ac4c2015-09-03 10:40:50 -07001296 overlay = project_base
Mike Frysingercd363c82014-02-01 05:20:18 -05001297
1298 pv = m.group(3).split('-', 1)[0]
1299
Bernie Thompsone5ee1822016-01-12 14:22:23 -08001300 # Virtual versions >= 4 are special cases used above the standard
1301 # versioning structure, e.g. if one has a board inheriting a board.
Julius Werner0299a2b2020-07-31 18:20:43 -07001302 if pv[0] >= '4':
Bernie Thompsone5ee1822016-01-12 14:22:23 -08001303 want_pv = pv
Mike Frysingercd363c82014-02-01 05:20:18 -05001304 elif is_board(overlay):
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001305 if is_private(overlay):
1306 want_pv = '3.5' if is_variant(overlay) else '3'
1307 elif is_board(overlay):
1308 want_pv = '2.5' if is_variant(overlay) else '2'
1309 elif is_baseboard(overlay):
Julius Werner0299a2b2020-07-31 18:20:43 -07001310 want_pv = '1.9.5' if is_private(overlay) else '1.9'
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001311 elif is_chipset(overlay):
Julius Werner0299a2b2020-07-31 18:20:43 -07001312 want_pv = '1.8.5' if is_private(overlay) else '1.8'
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001313 elif is_project(overlay):
1314 want_pv = '1.7' if is_private(overlay) else '1.5'
Mike Frysingercd363c82014-02-01 05:20:18 -05001315 else:
1316 want_pv = '1'
1317
1318 if pv != want_pv:
1319 bad_ebuilds.append((ebuild, pv, want_pv))
1320
1321 if bad_ebuilds:
1322 # pylint: disable=C0301
1323 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
1324 # pylint: enable=C0301
1325 return HookFailure(
1326 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
1327 '\t%s\n'
1328 'If this is an upstream Gentoo virtual, then you may ignore this\n'
1329 'check (and re-run w/--no-verify). Otherwise, please see this\n'
1330 'page for more details:\n%s\n' %
1331 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
1332 for x in bad_ebuilds]), url))
1333
Mike Frysinger8cf80812019-09-16 23:49:29 -04001334 return None
1335
Mike Frysingercd363c82014-02-01 05:20:18 -05001336
Daniel Erat9d203ff2015-02-17 10:12:21 -07001337def _check_portage_make_use_var(_project, commit):
1338 """Verify that $USE is set correctly in make.conf and make.defaults."""
1339 files = _filter_files(_get_affected_files(commit, relative=True),
1340 [r'(^|/)make.(conf|defaults)$'])
1341
1342 errors = []
1343 for path in files:
1344 basename = os.path.basename(path)
1345
1346 # Has a USE= line already been encountered in this file?
1347 saw_use = False
1348
1349 for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1):
1350 if not line.startswith('USE='):
1351 continue
1352
1353 preserves_use = '${USE}' in line or '$USE' in line
1354
1355 if (basename == 'make.conf' or
1356 (basename == 'make.defaults' and saw_use)) and not preserves_use:
1357 errors.append('%s:%d: missing ${USE}' % (path, i))
1358 elif basename == 'make.defaults' and not saw_use and preserves_use:
1359 errors.append('%s:%d: ${USE} referenced in initial declaration' %
1360 (path, i))
1361
1362 saw_use = True
1363
1364 if errors:
1365 return HookFailure(
1366 'One or more Portage make files appear to set USE incorrectly.\n'
1367 '\n'
1368 'All USE assignments in make.conf and all assignments after the\n'
1369 'initial declaration in make.defaults should contain "${USE}" to\n'
1370 'preserve previously-set flags.\n'
1371 '\n'
1372 'The initial USE declaration in make.defaults should not contain\n'
1373 '"${USE}".\n',
1374 errors)
1375
Mike Frysinger8cf80812019-09-16 23:49:29 -04001376 return None
1377
Daniel Erat9d203ff2015-02-17 10:12:21 -07001378
Mike Frysingerae409522014-02-01 03:16:11 -05001379def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001380 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001381 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001382 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001383 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001384 if not m:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001385 return HookFailure('Last paragraph of description must include Change-Id.')
Ryan Cui1562fb82011-05-09 11:01:31 -07001386
LaMont Jonesfb5e8bf2020-03-03 12:50:06 -07001387 # S-o-b and some other tags always allowed to follow Change-ID in the footer.
1388 allowed_tags = ['Signed-off-by', 'Cq-Cl-Tag', 'Cq-Include-Trybots']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001389
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001390 end = desc[m.end():].strip().splitlines()
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001391 cherry_pick_marker = 'cherry picked from commit'
1392
1393 if end and cherry_pick_marker in end[-1]:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001394 # Cherry picked patches allow more tags in the last paragraph.
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001395 allowed_tags += ['Commit-Queue', 'Commit-Ready', 'Reviewed-by',
1396 'Reviewed-on', 'Tested-by']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001397 end = end[:-1]
1398
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001399 # Note that descriptions could have multiple cherry pick markers.
1400 tag_search = r'^(%s:|\(%s) ' % (':|'.join(allowed_tags), cherry_pick_marker)
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001401
1402 if [x for x in end if not re.search(tag_search, x)]:
1403 return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' %
1404 ':", "'.join(allowed_tags))
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001405
Mike Frysinger8cf80812019-09-16 23:49:29 -04001406 return None
1407
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001408
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001409def _check_commit_message_style(_project, commit):
1410 """Verify that the commit message matches our style.
1411
1412 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
1413 commit hooks.
1414 """
Mike Frysingered9b2a02019-12-12 18:52:32 -05001415 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Mike Frysinger4efdee72019-11-04 10:57:01 -05001416
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001417 desc = _get_commit_desc(commit)
1418
1419 # The first line should be by itself.
1420 lines = desc.splitlines()
1421 if len(lines) > 1 and lines[1]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001422 return HookFailure('The second line of the commit message must be blank.'
1423 '\n%s' % (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001424
1425 # The first line should be one sentence.
1426 if '. ' in lines[0]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001427 return HookFailure('The first line cannot be more than one sentence.\n%s' %
1428 (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001429
1430 # The first line cannot be too long.
1431 MAX_FIRST_LINE_LEN = 100
1432 if len(lines[0]) > MAX_FIRST_LINE_LEN:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001433 return HookFailure('The first line must be less than %i chars.\n%s' %
1434 (MAX_FIRST_LINE_LEN, SEE_ALSO))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001435
Mike Frysinger8cf80812019-09-16 23:49:29 -04001436 return None
1437
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001438
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001439def _check_cros_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001440 """Verifies the Chromium OS license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -07001441
Mike Frysinger98638102014-08-28 00:15:08 -04001442 Should be following the spec:
1443 http://dev.chromium.org/developers/coding-style#TOC-File-headers
1444 """
1445 # For older years, be a bit more flexible as our policy says leave them be.
1446 LICENSE_HEADER = (
Keigo Oka7e880ac2019-07-03 15:03:43 +09001447 r'.*Copyright(?: \(c\))? (20[0-9]{2})(?:-20[0-9]{2})? The Chromium OS '
1448 r'Authors\. All rights reserved\.\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001449 r'.*Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001450 r'be\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001451 r'.*found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -05001452 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001453 )
1454 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1455
1456 # For newer years, be stricter.
Keigo Oka7e880ac2019-07-03 15:03:43 +09001457 BAD_COPYRIGHT_LINE = (
Brian Norris68838dd2018-09-26 18:30:24 -07001458 r'.*Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001459 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001460 )
Keigo Oka7e880ac2019-07-03 15:03:43 +09001461 bad_copyright_re = re.compile(BAD_COPYRIGHT_LINE)
Mike Frysinger98638102014-08-28 00:15:08 -04001462
Shuhei Takahashiabc20f32017-07-10 19:35:45 +09001463 included, excluded = _parse_common_inclusion_options(options)
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001464
Mike Frysinger98638102014-08-28 00:15:08 -04001465 bad_files = []
1466 bad_copyright_files = []
Keigo Oka7e880ac2019-07-03 15:03:43 +09001467 bad_year_files = []
1468
Ken Turnerd07564b2018-02-08 17:57:59 +11001469 files = _filter_files(
1470 _get_affected_files(commit, relative=True),
1471 included + COMMON_INCLUDED_PATHS,
1472 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001473 existing_files = set(_get_affected_files(commit, relative=True,
1474 include_adds=False))
Mike Frysinger98638102014-08-28 00:15:08 -04001475
Keigo Oka7e880ac2019-07-03 15:03:43 +09001476 current_year = str(datetime.datetime.now().year)
Mike Frysinger98638102014-08-28 00:15:08 -04001477 for f in files:
1478 contents = _get_file_content(f, commit)
1479 if not contents:
1480 # Ignore empty files.
1481 continue
1482
Keigo Oka7e880ac2019-07-03 15:03:43 +09001483 m = license_re.search(contents)
1484 if not m:
Mike Frysinger98638102014-08-28 00:15:08 -04001485 bad_files.append(f)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001486 elif bad_copyright_re.search(contents):
Mike Frysinger98638102014-08-28 00:15:08 -04001487 bad_copyright_files.append(f)
1488
Keigo Oka7e880ac2019-07-03 15:03:43 +09001489 if m and f not in existing_files:
1490 year = m.group(1)
1491 if year != current_year:
1492 bad_year_files.append(f)
1493
1494 errors = []
Mike Frysinger98638102014-08-28 00:15:08 -04001495 if bad_files:
1496 msg = '%s:\n%s\n%s' % (
1497 'License must match', license_re.pattern,
1498 'Found a bad header in these files:')
Keigo Oka7e880ac2019-07-03 15:03:43 +09001499 errors.append(HookFailure(msg, bad_files))
Mike Frysinger98638102014-08-28 00:15:08 -04001500 if bad_copyright_files:
1501 msg = 'Do not use (c) in copyright headers in new files:'
Keigo Oka7e880ac2019-07-03 15:03:43 +09001502 errors.append(HookFailure(msg, bad_copyright_files))
1503 if bad_year_files:
1504 msg = 'Use current year (%s) in copyright headers in new files:' % (
1505 current_year)
1506 errors.append(HookFailure(msg, bad_year_files))
Ryan Cuiec4d6332011-05-02 14:15:25 -07001507
Keigo Oka7e880ac2019-07-03 15:03:43 +09001508 return errors
Ryan Cuiec4d6332011-05-02 14:15:25 -07001509
Mike Frysinger8cf80812019-09-16 23:49:29 -04001510
Amin Hassani391efa92018-01-26 17:58:05 -08001511def _check_aosp_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001512 """Verifies the AOSP license/copyright header.
1513
1514 AOSP uses the Apache2 License:
1515 https://source.android.com/source/licenses.html
1516 """
1517 LICENSE_HEADER = (
1518 r"""^[#/\*]*
1519[#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project
1520[#/\*]* ?
1521[#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\);
1522[#/\*]* ?you may not use this file except in compliance with the License\.
1523[#/\*]* ?You may obtain a copy of the License at
1524[#/\*]* ?
1525[#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0
1526[#/\*]* ?
1527[#/\*]* ?Unless required by applicable law or agreed to in writing, software
1528[#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS,
1529[#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """
1530 r"""implied\.
1531[#/\*]* ?See the License for the specific language governing permissions and
1532[#/\*]* ?limitations under the License\.
1533[#/\*]*$
1534"""
1535 )
1536 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1537
Amin Hassani391efa92018-01-26 17:58:05 -08001538 included, excluded = _parse_common_inclusion_options(options)
1539
Ken Turnerd07564b2018-02-08 17:57:59 +11001540 files = _filter_files(
1541 _get_affected_files(commit, relative=True),
1542 included + COMMON_INCLUDED_PATHS,
1543 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Alex Deymof5792ce2015-08-24 22:50:08 -07001544
1545 bad_files = []
1546 for f in files:
1547 contents = _get_file_content(f, commit)
1548 if not contents:
1549 # Ignore empty files.
1550 continue
1551
1552 if not license_re.search(contents):
1553 bad_files.append(f)
1554
1555 if bad_files:
1556 msg = ('License must match:\n%s\nFound a bad header in these files:' %
1557 license_re.pattern)
1558 return HookFailure(msg, bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001559 return None
Alex Deymof5792ce2015-08-24 22:50:08 -07001560
1561
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001562def _check_layout_conf(_project, commit):
1563 """Verifies the metadata/layout.conf file."""
1564 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001565 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001566 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001567 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001568
Mike Frysinger94a670c2014-09-19 12:46:26 -04001569 # Handle multiple overlays in a single commit (like the public tree).
1570 for f in _get_affected_files(commit, relative=True):
1571 if f.endswith(repo_name):
1572 repo_names.append(f)
1573 elif f.endswith(layout_path):
1574 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001575
1576 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -04001577 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001578 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -04001579 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001580
Mike Frysinger94a670c2014-09-19 12:46:26 -04001581 # Gather all the errors in one pass so we show one full message.
1582 all_errors = {}
1583 for layout_path in layout_paths:
1584 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001585
Mike Frysinger94a670c2014-09-19 12:46:26 -04001586 # Make sure the config file is sorted.
1587 data = [x for x in _get_file_content(layout_path, commit).splitlines()
1588 if x and x[0] != '#']
1589 if sorted(data) != data:
1590 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001591
Mike Frysinger94a670c2014-09-19 12:46:26 -04001592 # Require people to set specific values all the time.
1593 settings = (
1594 # TODO: Enable this for everyone. http://crbug.com/408038
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001595 # ('fast caching', 'cache-format = md5-dict'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001596 ('fast manifests', 'thin-manifests = true'),
Mike Frysingerd7734522015-02-26 16:12:43 -05001597 ('extra features', 'profile-formats = portage-2 profile-default-eapi'),
1598 ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001599 )
1600 for reason, line in settings:
1601 if line not in data:
1602 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001603
Mike Frysinger94a670c2014-09-19 12:46:26 -04001604 # Require one of these settings.
Mike Frysinger5fae62d2015-11-11 20:12:15 -05001605 if 'use-manifests = strict' not in data:
1606 errors += ['enable file checking with: use-manifests = strict']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001607
Mike Frysinger94a670c2014-09-19 12:46:26 -04001608 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -04001609 for line in data:
1610 if line.startswith('repo-name = '):
1611 break
1612 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -04001613 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001614
Mike Frysinger94a670c2014-09-19 12:46:26 -04001615 # Summarize all the errors we saw (if any).
1616 lines = ''
1617 for layout_path, errors in all_errors.items():
1618 if errors:
1619 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
1620 if lines:
1621 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
1622 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001623
Mike Frysinger8cf80812019-09-16 23:49:29 -04001624 return None
1625
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001626
Keigo Oka4a09bd92019-05-07 14:01:00 +09001627def _check_no_new_gyp(_project, commit):
1628 """Verifies no project starts to use GYP."""
Keigo Oka4a09bd92019-05-07 14:01:00 +09001629 gypfiles = _filter_files(
1630 _get_affected_files(commit, include_symlinks=True, relative=True),
1631 [r'\.gyp$'])
1632
1633 if gypfiles:
1634 return HookFailure('GYP is deprecated and not allowed in a new project:',
1635 gypfiles)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001636 return None
Keigo Oka4a09bd92019-05-07 14:01:00 +09001637
1638
Ryan Cuiec4d6332011-05-02 14:15:25 -07001639# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001640
Ryan Cui1562fb82011-05-09 11:01:31 -07001641
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001642def _check_clang_format(_project, commit, options=()):
1643 """Runs clang-format on the given project"""
1644 hooks_dir = _get_hooks_dir()
1645 options = list(options)
1646 if commit == PRE_SUBMIT:
1647 options.append('--commit=HEAD')
1648 else:
1649 options.extend(['--commit', commit])
Brian Norris0c62a142018-12-11 13:24:29 -08001650 cmd = [os.path.join(hooks_dir, 'clang-format.py')] + options
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001651 cmd_result = cros_build_lib.run(cmd,
1652 print_cmd=False,
1653 stdout=True,
1654 encoding='utf-8',
1655 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001656 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001657 check=False)
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001658 if cmd_result.returncode:
1659 return HookFailure('clang-format.py errors/warnings\n\n' +
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001660 cmd_result.stdout)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001661 return None
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001662
1663
Mike Frysingerae409522014-02-01 03:16:11 -05001664def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001665 """Runs checkpatch.pl on the given project"""
1666 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001667 options = list(options)
Brian Norris4cee0502020-06-12 17:02:56 -07001668 if options and options[0].startswith('./') and os.path.exists(options[0]):
1669 cmdpath = options.pop(0)
1670 else:
1671 cmdpath = os.path.join(hooks_dir, 'checkpatch.pl')
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001672 if commit == PRE_SUBMIT:
1673 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
1674 # this case.
1675 options.append('--ignore=MISSING_SIGN_OFF')
Filipe Brandenburger28d48d62015-10-07 09:48:54 -07001676 # Always ignore the check for the MAINTAINERS file. We do not track that
1677 # information on that file in our source trees, so let's suppress the
1678 # warning.
1679 options.append('--ignore=FILE_PATH_CHANGES')
Filipe Brandenburgerce978322015-10-09 10:04:15 -07001680 # Do not complain about the Change-Id: fields, since we use Gerrit.
1681 # Upstream does not want those lines (since they do not use Gerrit), but
1682 # we always do, so disable the check globally.
Daisuke Nojiri4844f892015-10-08 09:54:33 -07001683 options.append('--ignore=GERRIT_CHANGE_ID')
Brian Norris4cee0502020-06-12 17:02:56 -07001684 cmd = [cmdpath] + options + ['-']
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001685 cmd_result = cros_build_lib.run(
1686 cmd, print_cmd=False, input=_get_patch(commit).encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001687 stdout=True, stderr=subprocess.STDOUT, check=False, encoding='utf-8',
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001688 errors='replace')
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001689 if cmd_result.returncode:
Brian Norris4cee0502020-06-12 17:02:56 -07001690 return HookFailure('%s errors/warnings\n\n%s' %
1691 (cmdpath, cmd_result.stdout))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001692 return None
Ryan Cuiec4d6332011-05-02 14:15:25 -07001693
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001694
Brian Norris23c62e92018-11-14 12:25:51 -08001695def _run_kerneldoc(_project, commit, options=()):
1696 """Runs kernel-doc validator on the given project"""
1697 included, excluded = _parse_common_inclusion_options(options)
1698 files = _filter_files(_get_affected_files(commit, relative=True),
1699 included, excluded)
1700 if files:
1701 hooks_dir = _get_hooks_dir()
Brian Norris0c62a142018-12-11 13:24:29 -08001702 cmd = [os.path.join(hooks_dir, 'kernel-doc'), '-none'] + files
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001703 output = _run_command(cmd, stderr=subprocess.STDOUT)
Brian Norris23c62e92018-11-14 12:25:51 -08001704 if output:
Brian Norris0c62a142018-12-11 13:24:29 -08001705 return HookFailure('kernel-doc errors/warnings:',
1706 items=output.splitlines())
Mike Frysinger8cf80812019-09-16 23:49:29 -04001707 return None
Brian Norris23c62e92018-11-14 12:25:51 -08001708
1709
Mike Frysingerae409522014-02-01 03:16:11 -05001710def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -07001711 """Makes sure kernel config changes are not mixed with code changes"""
1712 files = _get_affected_files(commit)
Mike Frysingerf252cfc2019-12-09 17:34:28 -05001713 if len(_filter_files(files, [r'chromeos/config'])) not in [0, len(files)]:
Olof Johanssona96810f2012-09-04 16:20:03 -07001714 return HookFailure('Changes to chromeos/config/ and regular files must '
1715 'be in separate commits:\n%s' % '\n'.join(files))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001716 return None
Anton Staaf815d6852011-08-22 10:08:45 -07001717
Mike Frysingerae409522014-02-01 03:16:11 -05001718
1719def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -07001720 """Checks that all JSON files are syntactically valid."""
Mike Frysinger908be682018-01-04 02:21:50 -05001721 ret = []
1722
1723 files = _filter_files(_get_affected_files(commit, relative=True),
1724 [r'.*\.json$'])
1725 for f in files:
1726 data = _get_file_content(f, commit)
Dale Curtis2975c432011-05-03 17:25:20 -07001727 try:
Mike Frysinger908be682018-01-04 02:21:50 -05001728 json.loads(data)
1729 except Exception as e:
1730 ret.append('%s: Invalid JSON: %s' % (f, e))
1731
1732 if ret:
1733 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001734 return None
Dale Curtis2975c432011-05-03 17:25:20 -07001735
1736
Mike Frysingerae409522014-02-01 03:16:11 -05001737def _check_manifests(_project, commit):
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001738 """Make sure Manifest files only have comments & DIST lines."""
1739 ret = []
Mike Frysinger52b537e2013-08-22 22:59:53 -04001740
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001741 manifests = _filter_files(_get_affected_files(commit, relative=True),
1742 [r'.*/Manifest$'])
1743 for path in manifests:
1744 data = _get_file_content(path, commit)
1745
1746 # Disallow blank files.
1747 if not data.strip():
1748 ret.append('%s: delete empty file' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001749 continue
1750
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001751 # Make sure the last newline isn't omitted.
1752 if data[-1] != '\n':
1753 ret.append('%s: missing trailing newline' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001754
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001755 # Do not allow leading or trailing blank lines.
1756 lines = data.splitlines()
1757 if not lines[0]:
1758 ret.append('%s: delete leading blank lines' % (path,))
1759 if not lines[-1]:
1760 ret.append('%s: delete trailing blank lines' % (path,))
1761
1762 for line in lines:
1763 # Disallow leading/trailing whitespace.
1764 if line != line.strip():
1765 ret.append('%s: remove leading/trailing whitespace: %s' % (path, line))
1766
1767 # Allow blank lines & comments.
1768 line = line.split('#', 1)[0]
1769 if not line:
1770 continue
1771
1772 # All other linse should start with DIST.
1773 if not line.startswith('DIST '):
1774 ret.append('%s: remove non-DIST lines: %s' % (path, line))
1775 break
1776
1777 if ret:
1778 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001779 return None
Mike Frysinger52b537e2013-08-22 22:59:53 -04001780
1781
Mike Frysingerae409522014-02-01 03:16:11 -05001782def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001783 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001784 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001785 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001786 BRANCH_RE = r'\nBRANCH=\S+'
1787
1788 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
1789 msg = ('Changelist description needs BRANCH field (after first line)\n'
1790 'E.g. BRANCH=none or BRANCH=link,snow')
1791 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001792 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001793
1794
Mike Frysinger45334bd2019-11-04 10:42:33 -05001795def _check_change_has_no_branch_field(_project, commit):
1796 """Verify 'BRANCH=' field does not exist in the commit message."""
1797 if commit == PRE_SUBMIT:
1798 return None
1799 BRANCH_RE = r'\nBRANCH=\S+'
1800
1801 if re.search(BRANCH_RE, _get_commit_desc(commit)):
1802 msg = 'This checkout does not use BRANCH= fields. Delete them.'
1803 return HookFailure(msg)
1804 return None
1805
1806
Mike Frysingerae409522014-02-01 03:16:11 -05001807def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001808 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001809 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001810 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001811 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1812
1813 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1814 msg = ('Changelist description needs Signed-off-by: field\n'
1815 'E.g. Signed-off-by: My Name <me@chromium.org>')
1816 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001817 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001818
1819
Mike Frysinger9ab64b12019-11-04 10:53:08 -05001820def _check_change_has_no_signoff_field(_project, commit):
1821 """Verify 'Signed-off-by:' field does not exist in the commit message."""
1822 if commit == PRE_SUBMIT:
1823 return None
1824 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1825
1826 if re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1827 msg = 'This checkout does not use Signed-off-by: tags. Delete them.'
1828 return HookFailure(msg)
1829 return None
1830
1831
Jon Salz3ee59de2012-08-18 13:54:22 +08001832def _run_project_hook_script(script, project, commit):
1833 """Runs a project hook script.
1834
1835 The script is run with the following environment variables set:
1836 PRESUBMIT_PROJECT: The affected project
1837 PRESUBMIT_COMMIT: The affected commit
1838 PRESUBMIT_FILES: A newline-separated list of affected files
1839
1840 The script is considered to fail if the exit code is non-zero. It should
1841 write an error message to stdout.
1842 """
1843 env = dict(os.environ)
Alex Deymo643ac4c2015-09-03 10:40:50 -07001844 env['PRESUBMIT_PROJECT'] = project.name
Jon Salz3ee59de2012-08-18 13:54:22 +08001845 env['PRESUBMIT_COMMIT'] = commit
1846
1847 # Put affected files in an environment variable
1848 files = _get_affected_files(commit)
1849 env['PRESUBMIT_FILES'] = '\n'.join(files)
1850
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001851 cmd_result = cros_build_lib.run(cmd=script,
1852 env=env,
1853 shell=True,
1854 print_cmd=False,
1855 input=os.devnull,
1856 stdout=True,
1857 encoding='utf-8',
1858 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001859 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001860 check=False)
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001861 if cmd_result.returncode:
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001862 stdout = cmd_result.stdout
Jon Salz7b618af2012-08-31 06:03:16 +08001863 if stdout:
1864 stdout = re.sub('(?m)^', ' ', stdout)
1865 return HookFailure('Hook script "%s" failed with code %d%s' %
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001866 (script, cmd_result.returncode,
Jon Salz3ee59de2012-08-18 13:54:22 +08001867 ':\n' + stdout if stdout else ''))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001868 return None
Jon Salz3ee59de2012-08-18 13:54:22 +08001869
1870
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001871def _check_project_prefix(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -05001872 """Require the commit message have a project specific prefix as needed."""
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001873
Brian Norris77608e12018-04-06 10:38:43 -07001874 files = _get_affected_files(commit, include_deletes=True, relative=True)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001875 prefix = os.path.commonprefix(files)
1876 prefix = os.path.dirname(prefix)
1877
1878 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07001879 if not prefix:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001880 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001881
1882 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07001883
1884 # The common files may all be within a subdirectory of the main project
1885 # directory, so walk up the tree until we find an alias file.
1886 # _get_affected_files() should return relative paths, but check against '/' to
1887 # ensure that this loop terminates even if it receives an absolute path.
1888 while prefix and prefix != '/':
1889 alias_file = os.path.join(prefix, '.project_alias')
1890
1891 # If an alias exists, use it.
1892 if os.path.isfile(alias_file):
1893 project_name = osutils.ReadFile(alias_file).strip()
1894
1895 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001896
1897 if not _get_commit_desc(commit).startswith(project_name + ': '):
1898 return HookFailure('The commit title for changes affecting only %s'
1899 ' should start with \"%s: \"'
1900 % (project_name, project_name))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001901 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001902
1903
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001904def _check_filepath_chartype(_project, commit):
1905 """Checks that FilePath::CharType stuff is not used."""
1906
1907 FILEPATH_REGEXP = re.compile('|'.join(
1908 [r'(?:base::)?FilePath::(?:Char|String|StringPiece)Type',
Satoru Takabayashi4ca37922018-08-08 10:16:38 +09001909 r'(?:base::)?FilePath::FromUTF8Unsafe',
1910 r'AsUTF8Unsafe',
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001911 r'FILE_PATH_LITERAL']))
1912 files = _filter_files(_get_affected_files(commit, relative=True),
1913 [r'.*\.(cc|h)$'])
1914
1915 errors = []
1916 for afile in files:
1917 for line_num, line in _get_file_diff(afile, commit):
1918 m = re.search(FILEPATH_REGEXP, line)
1919 if m:
1920 errors.append('%s, line %s has %s' % (afile, line_num, m.group(0)))
1921
1922 if errors:
1923 msg = 'Please assume FilePath::CharType is char (crbug.com/870621):'
1924 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001925 return None
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001926
1927
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001928def _check_exec_files(_project, commit):
1929 """Make +x bits on files."""
1930 # List of files that should never be +x.
1931 NO_EXEC = (
1932 'ChangeLog*',
1933 'COPYING',
1934 'make.conf',
1935 'make.defaults',
1936 'Manifest',
1937 'OWNERS',
1938 'package.use',
1939 'package.keywords',
1940 'package.mask',
1941 'parent',
1942 'README',
1943 'TODO',
1944 '.gitignore',
1945 '*.[achly]',
1946 '*.[ch]xx',
1947 '*.boto',
1948 '*.cc',
1949 '*.cfg',
1950 '*.conf',
1951 '*.config',
1952 '*.cpp',
1953 '*.css',
1954 '*.ebuild',
1955 '*.eclass',
Tatsuhisa Yamaguchi3b053632019-01-10 14:45:14 +09001956 '*.gn',
1957 '*.gni',
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001958 '*.gyp',
1959 '*.gypi',
1960 '*.htm',
1961 '*.html',
1962 '*.ini',
1963 '*.js',
1964 '*.json',
1965 '*.md',
1966 '*.mk',
1967 '*.patch',
1968 '*.policy',
1969 '*.proto',
1970 '*.raw',
1971 '*.rules',
1972 '*.service',
1973 '*.target',
1974 '*.txt',
1975 '*.xml',
1976 '*.yaml',
1977 )
1978
1979 def FinalName(obj):
1980 # If the file is being deleted, then the dst_file is not set.
1981 if obj.dst_file is None:
1982 return obj.src_file
1983 else:
1984 return obj.dst_file
1985
1986 bad_files = []
1987 files = _get_affected_files(commit, relative=True, full_details=True)
1988 for f in files:
1989 mode = int(f.dst_mode, 8)
1990 if not mode & 0o111:
1991 continue
1992 name = FinalName(f)
1993 for no_exec in NO_EXEC:
1994 if fnmatch.fnmatch(name, no_exec):
1995 bad_files.append(name)
1996 break
1997
1998 if bad_files:
1999 return HookFailure('These files should not be executable. '
2000 'Please `chmod -x` them.', bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04002001 return None
Mike Frysingerf9d41b32017-02-23 15:20:04 -05002002
2003
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002004# Base
2005
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002006# A list of hooks which are not project specific and check patch description
2007# (as opposed to patch body).
2008_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07002009 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07002010 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07002011 _check_change_has_test_field,
2012 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04002013 _check_commit_message_style,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08002014 _check_change_is_contribution,
Jack Neus8edbf642019-07-10 16:08:31 -06002015 _check_change_no_include_oem,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002016]
2017
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002018# A list of hooks that are not project-specific
2019_COMMON_HOOKS = [
Keiichi Watanabe6ab73fd2020-07-14 23:42:02 +09002020 _check_cargo_clippy,
Aviv Keshet5ac59522017-01-31 14:28:27 -08002021 _check_cros_license,
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05002022 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05002023 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08002024 _check_ebuild_licenses,
Mike Frysingercd363c82014-02-01 05:20:18 -05002025 _check_ebuild_virtual_pv,
Mike Frysingerf9d41b32017-02-23 15:20:04 -05002026 _check_exec_files,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002027 _check_for_uprev,
Rahul Chaudhry09f61372015-07-31 17:14:26 -07002028 _check_gofmt,
Bernie Thompson8e26f742020-07-23 14:32:31 -07002029 _check_keywords,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04002030 _check_layout_conf,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002031 _check_no_long_lines,
Keigo Oka4a09bd92019-05-07 14:01:00 +09002032 _check_no_new_gyp,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002033 _check_no_stray_whitespace,
Ryan Cui9b651632011-05-11 11:38:58 -07002034 _check_no_tabs,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002035 _check_portage_make_use_var,
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -06002036 _check_rustfmt,
Aviv Keshet5ac59522017-01-31 14:28:27 -08002037 _check_tabbed_indents,
Ryan Cui9b651632011-05-11 11:38:58 -07002038]
Ryan Cuiec4d6332011-05-02 14:15:25 -07002039
Ryan Cui1562fb82011-05-09 11:01:31 -07002040
Ryan Cui9b651632011-05-11 11:38:58 -07002041# A dictionary of project-specific hooks(callbacks), indexed by project name.
2042# dict[project] = [callback1, callback2]
2043_PROJECT_SPECIFIC_HOOKS = {
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002044 'chromiumos/third_party/kernel': [_kernel_configcheck],
2045 'chromiumos/third_party/kernel-next': [_kernel_configcheck],
Ryan Cui9b651632011-05-11 11:38:58 -07002046}
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002047
Ryan Cui1562fb82011-05-09 11:01:31 -07002048
Ryan Cui9b651632011-05-11 11:38:58 -07002049# A dictionary of flags (keys) that can appear in the config file, and the hook
Mike Frysinger3554bc92015-03-11 04:59:21 -04002050# that the flag controls (value).
2051_HOOK_FLAGS = {
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07002052 'clang_format_check': _check_clang_format,
Mike Frysingera7642f52015-03-25 18:31:42 -04002053 'checkpatch_check': _run_checkpatch,
Brian Norris23c62e92018-11-14 12:25:51 -08002054 'kerneldoc_check': _run_kerneldoc,
Ryan Cui9b651632011-05-11 11:38:58 -07002055 'stray_whitespace_check': _check_no_stray_whitespace,
Mike Frysingerff6c7d62015-03-24 13:49:46 -04002056 'json_check': _run_json_check,
Ryan Cui9b651632011-05-11 11:38:58 -07002057 'long_line_check': _check_no_long_lines,
Alex Deymof5792ce2015-08-24 22:50:08 -07002058 'cros_license_check': _check_cros_license,
2059 'aosp_license_check': _check_aosp_license,
LaMont Jones872fe762020-02-10 15:36:14 -07002060 'gofmt_check': _check_gofmt,
Bernie Thompson8e26f742020-07-23 14:32:31 -07002061 'keyword_check': _check_keywords,
Ryan Cui9b651632011-05-11 11:38:58 -07002062 'tab_check': _check_no_tabs,
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08002063 'tabbed_indent_required_check': _check_tabbed_indents,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07002064 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08002065 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07002066 'bug_field_check': _check_change_has_bug_field,
2067 'test_field_check': _check_change_has_test_field,
Steve Fung49ec7e92015-03-23 16:07:12 -07002068 'manifest_check': _check_manifests,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08002069 'contribution_check': _check_change_is_contribution,
Mike Frysinger47bd1252018-06-11 12:12:20 -04002070 'project_prefix_check': _check_project_prefix,
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09002071 'filepath_chartype_check': _check_filepath_chartype,
Keiichi Watanabe6ab73fd2020-07-14 23:42:02 +09002072 'cargo_clippy_check': _check_cargo_clippy,
Julius Werner291d8602020-07-31 17:34:02 -07002073 'exec_files_check': _check_exec_files,
Ryan Cui9b651632011-05-11 11:38:58 -07002074}
2075
2076
Mike Frysinger3554bc92015-03-11 04:59:21 -04002077def _get_override_hooks(config):
2078 """Returns a set of hooks controlled by the current project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07002079
2080 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08002081
2082 Args:
2083 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07002084 """
2085 SECTION = 'Hook Overrides'
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002086 SECTION_OPTIONS = 'Hook Overrides Options'
Ryan Cui9b651632011-05-11 11:38:58 -07002087
Mike Frysinger56e8de02019-07-31 14:40:14 -04002088 valid_keys = set(_HOOK_FLAGS.keys())
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002089 hooks = _HOOK_FLAGS.copy()
Mike Frysinger180ecd62020-08-19 00:41:51 -04002090 hook_overrides = set(
2091 config.options(SECTION) if config.has_section(SECTION) else [])
2092
2093 unknown_keys = hook_overrides - valid_keys
2094 if unknown_keys:
2095 raise ValueError(f'{_CONFIG_FILE}: [{SECTION}]: unknown keys: '
2096 f'{unknown_keys}')
Mike Frysinger3554bc92015-03-11 04:59:21 -04002097
2098 enable_flags = []
Ryan Cui9b651632011-05-11 11:38:58 -07002099 disable_flags = []
Mike Frysinger180ecd62020-08-19 00:41:51 -04002100 for flag in valid_keys:
2101 if flag in hook_overrides:
2102 try:
2103 enabled = config.getboolean(SECTION, flag)
2104 except ValueError as e:
2105 raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' %
2106 (flag, _CONFIG_FILE, e))
2107 elif hooks[flag] in _COMMON_HOOKS:
2108 # Enable common hooks by default so we process custom options below.
2109 enabled = True
2110 else:
2111 # All other hooks we left as a tristate. We use this below for a few
2112 # hooks to control default behavior.
2113 enabled = None
Mike Frysinger3554bc92015-03-11 04:59:21 -04002114
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002115 if enabled:
2116 enable_flags.append(flag)
Mike Frysinger180ecd62020-08-19 00:41:51 -04002117 elif enabled is not None:
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002118 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07002119
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002120 # See if this hook has custom options.
2121 if enabled:
2122 try:
2123 options = config.get(SECTION_OPTIONS, flag)
2124 hooks[flag] = functools.partial(hooks[flag], options=options.split())
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002125 hooks[flag].__name__ = flag
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04002126 except (configparser.NoOptionError, configparser.NoSectionError):
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002127 pass
2128
2129 enabled_hooks = set(hooks[x] for x in enable_flags)
2130 disabled_hooks = set(hooks[x] for x in disable_flags)
Mike Frysinger45334bd2019-11-04 10:42:33 -05002131
Mike Frysinger9ab64b12019-11-04 10:53:08 -05002132 if _check_change_has_signoff_field not in enabled_hooks:
Drew Davenport85848e52020-01-15 14:40:29 -07002133 if _check_change_has_signoff_field not in disabled_hooks:
2134 enabled_hooks.add(_check_change_has_no_signoff_field)
Mike Frysinger45334bd2019-11-04 10:42:33 -05002135 if _check_change_has_branch_field not in enabled_hooks:
2136 enabled_hooks.add(_check_change_has_no_branch_field)
2137
Mike Frysinger3554bc92015-03-11 04:59:21 -04002138 return enabled_hooks, disabled_hooks
Ryan Cui9b651632011-05-11 11:38:58 -07002139
2140
Jon Salz3ee59de2012-08-18 13:54:22 +08002141def _get_project_hook_scripts(config):
2142 """Returns a list of project-specific hook scripts.
2143
2144 Args:
2145 config: A ConfigParser for the project's config file.
2146 """
2147 SECTION = 'Hook Scripts'
2148 if not config.has_section(SECTION):
2149 return []
2150
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002151 return config.items(SECTION)
Jon Salz3ee59de2012-08-18 13:54:22 +08002152
2153
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002154def _get_project_hooks(project, presubmit, config_file=None):
Ryan Cui9b651632011-05-11 11:38:58 -07002155 """Returns a list of hooks that need to be run for a project.
2156
2157 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002158
2159 Args:
2160 project: A string, name of the project.
2161 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002162 config_file: A string, the config file. Defaults to _CONFIG_FILE.
Ryan Cui9b651632011-05-11 11:38:58 -07002163 """
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04002164 config = configparser.RawConfigParser()
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002165 if config_file is None:
2166 config_file = _CONFIG_FILE
2167 if not os.path.exists(config_file):
Jon Salz3ee59de2012-08-18 13:54:22 +08002168 # Just use an empty config file
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04002169 config = configparser.RawConfigParser()
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09002170 else:
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002171 config.read(config_file)
Jon Salz3ee59de2012-08-18 13:54:22 +08002172
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002173 if presubmit:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07002174 hooks = _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002175 else:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07002176 hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002177
Mike Frysinger3554bc92015-03-11 04:59:21 -04002178 enabled_hooks, disabled_hooks = _get_override_hooks(config)
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07002179 hooks = [hook for hook in hooks if hook not in disabled_hooks]
2180
2181 # If a list is both in _COMMON_HOOKS and also enabled explicitly through an
2182 # override, keep the override only. Note that the override may end up being
2183 # a functools.partial, in which case we need to extract the .func to compare
2184 # it to the common hooks.
2185 unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks]
2186 hooks = [hook for hook in hooks if hook not in unwrapped_hooks]
2187
2188 hooks = list(enabled_hooks) + hooks
Ryan Cui9b651632011-05-11 11:38:58 -07002189
2190 if project in _PROJECT_SPECIFIC_HOOKS:
Puneet Kumarc80e3f62012-08-13 19:01:18 -07002191 hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project]
2192 if hook not in disabled_hooks)
Ryan Cui9b651632011-05-11 11:38:58 -07002193
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002194 for name, script in _get_project_hook_scripts(config):
2195 func = functools.partial(_run_project_hook_script, script)
2196 func.__name__ = name
2197 hooks.append(func)
Jon Salz3ee59de2012-08-18 13:54:22 +08002198
Ryan Cui9b651632011-05-11 11:38:58 -07002199 return hooks
2200
2201
Alex Deymo643ac4c2015-09-03 10:40:50 -07002202def _run_project_hooks(project_name, proj_dir=None,
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002203 commit_list=None, presubmit=False,
2204 config_file=None):
Ryan Cui1562fb82011-05-09 11:01:31 -07002205 """For each project run its project specific hook from the hooks dictionary.
2206
2207 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002208 project_name: The name of project to run hooks for.
Doug Anderson44a644f2011-11-02 10:37:37 -07002209 proj_dir: If non-None, this is the directory the project is in. If None,
2210 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07002211 commit_list: A list of commits to run hooks against. If None or empty list
2212 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002213 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002214 config_file: A string, the presubmit config file. If not specified,
2215 defaults to PRESUBMIT.cfg in the project directory.
Ryan Cui1562fb82011-05-09 11:01:31 -07002216
2217 Returns:
2218 Boolean value of whether any errors were ecountered while running the hooks.
2219 """
Doug Anderson44a644f2011-11-02 10:37:37 -07002220 if proj_dir is None:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002221 proj_dirs = _run_command(
2222 ['repo', 'forall', project_name, '-c', 'pwd']).split()
Mike Frysingere52b1bc2019-09-16 23:45:41 -04002223 if not proj_dirs:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002224 print('%s cannot be found.' % project_name, file=sys.stderr)
David James2edd9002013-10-11 14:09:19 -07002225 print('Please specify a valid project.', file=sys.stderr)
2226 return True
2227 if len(proj_dirs) > 1:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002228 print('%s is associated with multiple directories.' % project_name,
David James2edd9002013-10-11 14:09:19 -07002229 file=sys.stderr)
2230 print('Please specify a directory to help disambiguate.', file=sys.stderr)
2231 return True
2232 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07002233
Ryan Cuiec4d6332011-05-02 14:15:25 -07002234 pwd = os.getcwd()
2235 # hooks assume they are run from the root of the project
2236 os.chdir(proj_dir)
2237
Mike Frysingered1b95a2019-12-12 19:04:51 -05002238 color = terminal.Color()
2239
Alex Deymo643ac4c2015-09-03 10:40:50 -07002240 remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref',
2241 '--symbolic-full-name', '@{u}']).strip()
2242 if not remote_branch:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002243 print("Your project %s doesn't track any remote repo." % project_name,
Alex Deymo643ac4c2015-09-03 10:40:50 -07002244 file=sys.stderr)
2245 remote = None
2246 else:
Josh Pratt15d13ab2018-08-13 11:52:48 +10002247 branch_items = remote_branch.split('/', 1)
2248 if len(branch_items) != 2:
2249 PrintErrorForProject(
2250 project_name,
2251 HookFailure(
2252 'Cannot get remote and branch name (%s)' % remote_branch))
2253 os.chdir(pwd)
2254 return True
2255 remote, _branch = branch_items
Alex Deymo643ac4c2015-09-03 10:40:50 -07002256
2257 project = Project(name=project_name, dir=proj_dir, remote=remote)
2258
Doug Anderson14749562013-06-26 13:38:29 -07002259 if not commit_list:
2260 try:
2261 commit_list = _get_commits()
2262 except VerifyException as e:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002263 PrintErrorForProject(project.name, HookFailure(str(e)))
Doug Anderson14749562013-06-26 13:38:29 -07002264 os.chdir(pwd)
2265 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07002266
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002267 hooks = _get_project_hooks(project.name, presubmit, config_file)
Ryan Cui1562fb82011-05-09 11:01:31 -07002268 error_found = False
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002269 commit_count = len(commit_list)
Mike Frysingerb99b3772019-08-17 14:19:44 -04002270 hook_count = len(hooks)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002271 for i, commit in enumerate(commit_list):
Mike Frysingerb2496652019-09-12 23:35:46 -04002272 CACHE.clear()
2273
LaMont Jones69d3e182020-03-11 15:00:53 -06002274 # If run with --pre-submit, then commit is PRE_SUBMIT, and not a commit.
2275 # Use that as the description.
2276 desc = commit if commit == PRE_SUBMIT else _get_commit_desc(commit)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002277 print('[%s %i/%i %s] %s' %
2278 (color.Color(color.CYAN, 'COMMIT'), i + 1, commit_count, commit[0:12],
2279 desc.splitlines()[0]))
2280
Mike Frysingerb99b3772019-08-17 14:19:44 -04002281 for h, hook in enumerate(hooks):
Mike Frysingered1b95a2019-12-12 19:04:51 -05002282 output = ('[%s %i/%i PRESUBMIT.cfg] %s' %
2283 (color.Color(color.YELLOW, 'RUNNING'), h + 1, hook_count,
2284 hook.__name__))
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002285 print(output, end='\r')
2286 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002287 hook_error = hook(project, commit)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002288 print(' ' * len(output), end='\r')
2289 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002290 if hook_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002291 if not isinstance(hook_error, list):
2292 hook_error = [hook_error]
2293 PrintErrorsForCommit(color, hook, project.name, hook_error)
Ryan Cui1562fb82011-05-09 11:01:31 -07002294 error_found = True
Don Garrettdba548a2011-05-05 15:17:14 -07002295
Ryan Cuiec4d6332011-05-02 14:15:25 -07002296 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07002297 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002298
Mike Frysingerae409522014-02-01 03:16:11 -05002299
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002300# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002301
Ryan Cui1562fb82011-05-09 11:01:31 -07002302
Mike Frysingerae409522014-02-01 03:16:11 -05002303def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08002304 """Main function invoked directly by repo.
2305
2306 This function will exit directly upon error so that repo doesn't print some
2307 obscure error message.
2308
2309 Args:
2310 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07002311 worktree_list: A list of directories. It should be the same length as
2312 project_list, so that each entry in project_list matches with a directory
2313 in worktree_list. If None, we will attempt to calculate the directories
2314 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08002315 kwargs: Leave this here for forward-compatibility.
2316 """
Mike Frysingered1b95a2019-12-12 19:04:51 -05002317 start_time = datetime.datetime.now()
Ryan Cui1562fb82011-05-09 11:01:31 -07002318 found_error = False
David James2edd9002013-10-11 14:09:19 -07002319 if not worktree_list:
2320 worktree_list = [None] * len(project_list)
2321 for project, worktree in zip(project_list, worktree_list):
2322 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07002323 found_error = True
2324
Mike Frysingered1b95a2019-12-12 19:04:51 -05002325 end_time = datetime.datetime.now()
2326 color = terminal.Color()
Mike Frysingerae409522014-02-01 03:16:11 -05002327 if found_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002328 msg = ('%s: Preupload failed due to above error(s).\n'
Ryan Cui9b651632011-05-11 11:38:58 -07002329 '- To disable some source style checks, and for other hints, see '
Mike Frysingered1b95a2019-12-12 19:04:51 -05002330 '<checkout_dir>/src/repohooks/README.md\n'
2331 "- To upload only current project, run 'repo upload .'" %
2332 (color.Color(color.RED, 'FATAL'),))
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04002333 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07002334 sys.exit(1)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002335 else:
2336 msg = ('[%s] repohooks passed in %s' %
2337 (color.Color(color.GREEN, 'PASSED'), end_time - start_time))
2338 print(msg)
Anush Elangovan63afad72011-03-23 00:41:27 -07002339
Ryan Cui1562fb82011-05-09 11:01:31 -07002340
Doug Anderson44a644f2011-11-02 10:37:37 -07002341def _identify_project(path):
2342 """Identify the repo project associated with the given path.
2343
2344 Returns:
2345 A string indicating what project is associated with the path passed in or
2346 a blank string upon failure.
2347 """
2348 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002349 stderr=True, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002350
2351
Mike Frysinger55f85b52014-12-18 14:45:21 -05002352def direct_main(argv):
Doug Anderson44a644f2011-11-02 10:37:37 -07002353 """Run hooks directly (outside of the context of repo).
2354
Doug Anderson44a644f2011-11-02 10:37:37 -07002355 Args:
Mike Frysinger55f85b52014-12-18 14:45:21 -05002356 argv: The command line args to process
Doug Anderson44a644f2011-11-02 10:37:37 -07002357
2358 Returns:
2359 0 if no pre-upload failures, 1 if failures.
2360
2361 Raises:
2362 BadInvocation: On some types of invocation errors.
2363 """
Mike Frysinger66142932014-12-18 14:55:57 -05002364 parser = commandline.ArgumentParser(description=__doc__)
2365 parser.add_argument('--dir', default=None,
2366 help='The directory that the project lives in. If not '
2367 'specified, use the git project root based on the cwd.')
2368 parser.add_argument('--project', default=None,
2369 help='The project repo path; this can affect how the '
2370 'hooks get run, since some hooks are project-specific. '
2371 'For chromite this is chromiumos/chromite. If not '
2372 'specified, the repo tool will be used to figure this '
2373 'out based on the dir.')
2374 parser.add_argument('--rerun-since', default=None,
Vadim Bendebury75447b92018-01-10 12:06:01 -08002375 help='Rerun hooks on old commits since some point '
2376 'in the past. The argument could be a date (should '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002377 "match git log's concept of a date, e.g. 2012-06-20), "
Vadim Bendebury75447b92018-01-10 12:06:01 -08002378 'or a SHA1, or just a number of commits to check (from 1 '
2379 'to 99). This option is mutually exclusive with '
2380 '--pre-submit.')
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002381 parser.add_argument('--pre-submit', action='store_true',
Mike Frysinger66142932014-12-18 14:55:57 -05002382 help='Run the check against the pending commit. '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002383 "This option should be used at the 'git commit' "
2384 "phase as opposed to 'repo upload'. This option "
Mike Frysinger66142932014-12-18 14:55:57 -05002385 'is mutually exclusive with --rerun-since.')
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002386 parser.add_argument('--presubmit-config',
2387 help='Specify presubmit config file to be used.')
Mike Frysinger66142932014-12-18 14:55:57 -05002388 parser.add_argument('commits', nargs='*',
2389 help='Check specific commits')
2390 opts = parser.parse_args(argv)
Doug Anderson44a644f2011-11-02 10:37:37 -07002391
Doug Anderson14749562013-06-26 13:38:29 -07002392 if opts.rerun_since:
Mike Frysinger66142932014-12-18 14:55:57 -05002393 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002394 raise BadInvocation("Can't pass commits and use rerun-since: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002395 ' '.join(opts.commits))
Doug Anderson14749562013-06-26 13:38:29 -07002396
Vadim Bendebury75447b92018-01-10 12:06:01 -08002397 if len(opts.rerun_since) < 3 and opts.rerun_since.isdigit():
2398 # This must be the number of commits to check. We don't expect the user
2399 # to want to check more than 99 commits.
2400 limit = '-n%s' % opts.rerun_since
2401 elif git.IsSHA1(opts.rerun_since, False):
2402 limit = '%s..' % opts.rerun_since
2403 else:
2404 # This better be a date.
2405 limit = '--since=%s' % opts.rerun_since
2406 cmd = ['git', 'log', limit, '--pretty=%H']
Doug Anderson14749562013-06-26 13:38:29 -07002407 all_commits = _run_command(cmd).splitlines()
2408 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
2409
2410 # Eliminate chrome-bot commits but keep ordering the same...
2411 bot_commits = set(bot_commits)
Mike Frysinger66142932014-12-18 14:55:57 -05002412 opts.commits = [c for c in all_commits if c not in bot_commits]
Doug Anderson14749562013-06-26 13:38:29 -07002413
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002414 if opts.pre_submit:
2415 raise BadInvocation('rerun-since and pre-submit can not be '
2416 'used together')
2417 if opts.pre_submit:
Mike Frysinger66142932014-12-18 14:55:57 -05002418 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002419 raise BadInvocation("Can't pass commits and use pre-submit: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002420 ' '.join(opts.commits))
2421 opts.commits = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07002422
2423 # Check/normlaize git dir; if unspecified, we'll use the root of the git
2424 # project from CWD
2425 if opts.dir is None:
2426 git_dir = _run_command(['git', 'rev-parse', '--git-dir'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002427 stderr=True).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002428 if not git_dir:
2429 raise BadInvocation('The current directory is not part of a git project.')
2430 opts.dir = os.path.dirname(os.path.abspath(git_dir))
2431 elif not os.path.isdir(opts.dir):
2432 raise BadInvocation('Invalid dir: %s' % opts.dir)
2433 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
2434 raise BadInvocation('Not a git directory: %s' % opts.dir)
2435
2436 # Identify the project if it wasn't specified; this _requires_ the repo
2437 # tool to be installed and for the project to be part of a repo checkout.
2438 if not opts.project:
2439 opts.project = _identify_project(opts.dir)
2440 if not opts.project:
2441 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
2442
Doug Anderson14749562013-06-26 13:38:29 -07002443 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Mike Frysinger66142932014-12-18 14:55:57 -05002444 commit_list=opts.commits,
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002445 presubmit=opts.pre_submit,
2446 config_file=opts.presubmit_config)
Doug Anderson44a644f2011-11-02 10:37:37 -07002447 if found_error:
2448 return 1
2449 return 0
2450
2451
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002452if __name__ == '__main__':
Mike Frysinger55f85b52014-12-18 14:45:21 -05002453 sys.exit(direct_main(sys.argv[1:]))