blob: 0b0275077715fab31aa8792b991d31606a28ef5b [file] [log] [blame]
Mike Frysinger4f994402019-09-13 17:40:45 -04001#!/usr/bin/env python3
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002# -*- coding: utf-8 -*-
Jon Salz98255932012-08-18 14:48:02 +08003# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
Mike Frysingerae409522014-02-01 03:16:11 -05007"""Presubmit checks to run when doing `repo upload`.
8
Tom Hughes40bdce52020-08-25 08:57:03 -07009You can add new checks by adding a function to the HOOKS constants.
Mike Frysingerae409522014-02-01 03:16:11 -050010"""
11
Mike Frysinger09d6a3d2013-10-08 22:21:03 -040012from __future__ import print_function
13
Keigo Okadd908822019-06-04 11:30:25 +090014import argparse
Alex Deymo643ac4c2015-09-03 10:40:50 -070015import collections
Mike Frysingerf252cfc2019-12-09 17:34:28 -050016import configparser
Keigo Oka7e880ac2019-07-03 15:03:43 +090017import datetime
Daniel Erate3ea3fc2015-02-13 15:27:52 -070018import fnmatch
Jon Salz3ee59de2012-08-18 13:54:22 +080019import functools
Dale Curtis2975c432011-05-03 17:25:20 -070020import json
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070021import os
Ryan Cuiec4d6332011-05-02 14:15:25 -070022import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070023import sys
Peter Ammon811f6702014-06-12 15:45:38 -070024import stat
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -050025import subprocess
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070026
Ryan Cui1562fb82011-05-09 11:01:31 -070027from errors import (VerifyException, HookFailure, PrintErrorForProject,
28 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070029
Mike Frysinger919c7032019-09-13 17:48:08 -040030if __name__ in ('__builtin__', 'builtins'):
Mike Frysinger653cd262019-09-20 14:05:02 -040031 # If repo imports us, the __name__ will be __builtin__, and the cwd will be in
32 # the top level of the checkout (i.e. $CHROMEOS_CHECKOUT). chromite will be
33 # in that directory, so add it to our path. This works whether we're running
34 # the repo in $CHROMEOS_CHECKOUT/.repo/repo/ or a custom version in a
35 # completely different tree.
36 # TODO(vapier): Python 2 used "__builtin__" while Python 3 uses "builtins".
Mike Frysinger6850d512018-05-21 12:12:14 -040037 sys.path.insert(0, os.getcwd())
38
Mike Frysinger653cd262019-09-20 14:05:02 -040039elif __name__ == '__main__':
40 # If we're run directly, we'll find chromite relative to the repohooks dir in
41 # $CHROMEOS_CHECKOUT/src/repohooks, so go up two dirs.
David Jamesc3b68b32013-04-03 09:17:03 -070042 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
43
Mike Frysingerfd481ce2019-09-13 18:14:48 -040044# The sys.path monkey patching confuses the linter.
45# pylint: disable=wrong-import-position
Mike Frysinger66142932014-12-18 14:55:57 -050046from chromite.lib import commandline
Rahul Chaudhry0e515342015-08-07 12:00:43 -070047from chromite.lib import cros_build_lib
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050048from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070049from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070050from chromite.lib import patch
Mike Frysingered1b95a2019-12-12 19:04:51 -050051from chromite.lib import terminal
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040052from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070053
Mike Frysingerff4768e2020-02-27 18:48:13 -050054
55assert sys.version_info >= (3, 6), 'This module requires Python 3.6+'
56
57
Vadim Bendebury2b62d742014-06-22 13:14:51 -070058PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070059
Mike Frysingered9b2a02019-12-12 18:52:32 -050060
61# Link to commit message documentation for users.
62DOC_COMMIT_MSG_URL = ('https://chromium.googlesource.com/chromiumos/docs/+/HEAD'
63 '/contributing.md#commit-messages')
64
65
Ryan Cuiec4d6332011-05-02 14:15:25 -070066COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050067 # C++ and friends
Mike Frysinger24dd3c52019-08-17 14:22:48 -040068 r'.*\.c$', r'.*\.cc$', r'.*\.cpp$', r'.*\.h$', r'.*\.m$', r'.*\.mm$',
69 r'.*\.inl$', r'.*\.asm$', r'.*\.hxx$', r'.*\.hpp$', r'.*\.s$', r'.*\.S$',
Mike Frysingerae409522014-02-01 03:16:11 -050070 # Scripts
Mike Frysinger24dd3c52019-08-17 14:22:48 -040071 r'.*\.js$', r'.*\.py$', r'.*\.sh$', r'.*\.rb$', r'.*\.pl$', r'.*\.pm$',
Mike Frysingerae409522014-02-01 03:16:11 -050072 # No extension at all, note that ALL CAPS files are black listed in
73 # COMMON_EXCLUDED_LIST below.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040074 r'(^|.*[\\\/])[^.]+$',
Mike Frysingerae409522014-02-01 03:16:11 -050075 # Other
Mike Frysinger24dd3c52019-08-17 14:22:48 -040076 r'.*\.java$', r'.*\.mk$', r'.*\.am$',
77 r'.*\.policy$', r'.*\.conf$', r'.*\.go$',
78 r'(^OWNERS|/OWNERS)',
Ryan Cuiec4d6332011-05-02 14:15:25 -070079]
80
Ryan Cui1562fb82011-05-09 11:01:31 -070081
Ryan Cuiec4d6332011-05-02 14:15:25 -070082COMMON_EXCLUDED_PATHS = [
Daniel Erate3ea3fc2015-02-13 15:27:52 -070083 # For ebuild trees, ignore any caches and manifest data.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040084 r'.*/Manifest$',
85 r'.*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$',
Doug Anderson5bfb6792011-10-25 16:45:41 -070086
Daniel Erate3ea3fc2015-02-13 15:27:52 -070087 # Ignore profiles data (like overlay-tegra2/profiles).
Mike Frysinger24dd3c52019-08-17 14:22:48 -040088 r'(^|.*/)overlay-.*/profiles/.*',
89 r'^profiles/.*$',
Mike Frysinger98638102014-08-28 00:15:08 -040090
C Shapiro8f90e9b2017-06-28 09:54:50 -060091 # Ignore config files in ebuild setup.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040092 r'(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*',
93 r'^chromeos-base/chromeos-bsp.*/files/.*',
C Shapiro8f90e9b2017-06-28 09:54:50 -060094
Daniel Erate3ea3fc2015-02-13 15:27:52 -070095 # Ignore minified js and jquery.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040096 r'.*\.min\.js',
97 r'.*jquery.*\.js',
Mike Frysinger33a458d2014-03-03 17:00:51 -050098
99 # Ignore license files as the content is often taken verbatim.
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400100 r'.*/licenses/.*',
Alex Klein619c0912019-01-30 17:13:23 -0700101
Mike Frysinger13650402019-07-31 14:31:46 -0400102 # Exclude generated protobuf bindings.
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400103 r'.*_pb2\.py$',
104 r'.*\.pb\.go$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700105]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700106
Ken Turnerd07564b2018-02-08 17:57:59 +1100107LICENSE_EXCLUDED_PATHS = [
LaMont Jones775c2b32020-02-19 17:32:54 -0700108 r'^(.*/)?OWNERS(\..*)?$',
Ken Turnerd07564b2018-02-08 17:57:59 +1100109]
Ryan Cui1562fb82011-05-09 11:01:31 -0700110
Ryan Cui9b651632011-05-11 11:38:58 -0700111_CONFIG_FILE = 'PRESUBMIT.cfg'
112
113
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700114# File containing wildcards, one per line, matching files that should be
115# excluded from presubmit checks. Lines beginning with '#' are ignored.
116_IGNORE_FILE = '.presubmitignore'
117
Cheng Yuehb707c522020-01-02 14:06:59 +0800118
119TEST_FIELD_RE = r'\nTEST=\S+'
120
Doug Anderson44a644f2011-11-02 10:37:37 -0700121# Exceptions
122
123
124class BadInvocation(Exception):
125 """An Exception indicating a bad invocation of the program."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700126
127
Ryan Cui1562fb82011-05-09 11:01:31 -0700128# General Helpers
129
Sean Paulba01d402011-05-05 11:36:23 -0400130
Mike Frysingerb2496652019-09-12 23:35:46 -0400131class Cache(object):
132 """General helper for caching git content."""
133
134 def __init__(self):
135 self._cache = {}
136
137 def get_subcache(self, scope):
138 return self._cache.setdefault(scope, {})
139
140 def clear(self):
141 self._cache.clear()
142
143CACHE = Cache()
144
145
Alex Deymo643ac4c2015-09-03 10:40:50 -0700146Project = collections.namedtuple('Project', ['name', 'dir', 'remote'])
147
148
Mike Frysinger526a5f82019-09-13 18:05:30 -0400149def _run_command(cmd, **kwargs):
Doug Anderson44a644f2011-11-02 10:37:37 -0700150 """Executes the passed in command and returns raw stdout output.
151
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400152 This is a convenience func to set some run defaults differently.
Mike Frysinger526a5f82019-09-13 18:05:30 -0400153
Doug Anderson44a644f2011-11-02 10:37:37 -0700154 Args:
155 cmd: The command to run; should be a list of strings.
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400156 **kwargs: Same as cros_build_lib.run.
Doug Anderson44a644f2011-11-02 10:37:37 -0700157
158 Returns:
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700159 The stdout from the process (discards stderr and returncode).
Doug Anderson44a644f2011-11-02 10:37:37 -0700160 """
Mike Frysinger526a5f82019-09-13 18:05:30 -0400161 kwargs.setdefault('print_cmd', False)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400162 kwargs.setdefault('stdout', True)
163 kwargs.setdefault('check', False)
Mike Frysinger054c1592019-11-18 03:51:54 -0500164 result = cros_build_lib.run(cmd, **kwargs)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400165 # NB: We decode this directly rather than through kwargs as our tests rely
166 # on this post-processing behavior currently.
Mike Frysinger71e643e2019-09-13 17:26:39 -0400167 return result.output.decode('utf-8', 'replace')
Ryan Cui72834d12011-05-05 14:51:33 -0700168
Ryan Cui1562fb82011-05-09 11:01:31 -0700169
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700170def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700171 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700172 if __name__ == '__main__':
173 # Works when file is run on its own (__file__ is defined)...
174 return os.path.abspath(os.path.dirname(__file__))
175 else:
176 # We need to do this when we're run through repo. Since repo executes
177 # us with execfile(), we don't get __file__ defined.
178 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
179 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700180
Ryan Cui1562fb82011-05-09 11:01:31 -0700181
Ryan Cuiec4d6332011-05-02 14:15:25 -0700182def _match_regex_list(subject, expressions):
183 """Try to match a list of regular expressions to a string.
184
185 Args:
186 subject: The string to match regexes on
187 expressions: A list of regular expressions to check for matches with.
188
189 Returns:
190 Whether the passed in subject matches any of the passed in regexes.
191 """
192 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500193 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700194 return True
195 return False
196
Ryan Cui1562fb82011-05-09 11:01:31 -0700197
Mike Frysingerae409522014-02-01 03:16:11 -0500198def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700199 """Filter out files based on the conditions passed in.
200
201 Args:
202 files: list of filepaths to filter
203 include_list: list of regex that when matched with a file path will cause it
204 to be added to the output list unless the file is also matched with a
205 regex in the exclude_list.
206 exclude_list: list of regex that when matched with a file will prevent it
207 from being added to the output list, even if it is also matched with a
208 regex in the include_list.
209
210 Returns:
211 A list of filepaths that contain files matched in the include_list and not
212 in the exclude_list.
213 """
214 filtered = []
215 for f in files:
216 if (_match_regex_list(f, include_list) and
217 not _match_regex_list(f, exclude_list)):
218 filtered.append(f)
219 return filtered
220
Ryan Cuiec4d6332011-05-02 14:15:25 -0700221
222# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700223
224
Ryan Cui4725d952011-05-05 15:41:19 -0700225def _get_upstream_branch():
226 """Returns the upstream tracking branch of the current branch.
227
228 Raises:
229 Error if there is no tracking branch
230 """
231 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
232 current_branch = current_branch.replace('refs/heads/', '')
233 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700234 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700235
236 cfg_option = 'branch.' + current_branch + '.%s'
237 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
238 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
239 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700240 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700241
242 return full_upstream.replace('heads', 'remotes/' + remote)
243
Ryan Cui1562fb82011-05-09 11:01:31 -0700244
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700245def _get_patch(commit):
246 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700247 if commit == PRE_SUBMIT:
248 return _run_command(['git', 'diff', '--cached', 'HEAD'])
249 else:
250 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700251
Ryan Cui1562fb82011-05-09 11:01:31 -0700252
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500253def _get_file_content(path, commit):
254 """Returns the content of a file at a specific commit.
255
256 We can't rely on the file as it exists in the filesystem as people might be
257 uploading a series of changes which modifies the file multiple times.
258
259 Note: The "content" of a symlink is just the target. So if you're expecting
260 a full file, you should check that first. One way to detect is that the
261 content will not have any newlines.
262 """
Mike Frysingerb2496652019-09-12 23:35:46 -0400263 # Make sure people don't accidentally pass in full paths which will never
264 # work. You need to use relative=True with _get_affected_files.
265 if path.startswith('/'):
266 raise ValueError('_get_file_content must be called with relative paths: %s'
267 % (path,))
268
269 # {<commit>: {<path1>: <content>, <path2>: <content>}}
270 cache = CACHE.get_subcache('get_file_content')
271 if path in cache:
272 return cache[path]
273
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700274 if commit == PRE_SUBMIT:
Mike Frysingerb2496652019-09-12 23:35:46 -0400275 content = _run_command(['git', 'diff', 'HEAD', path])
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700276 else:
Mike Frysingerb2496652019-09-12 23:35:46 -0400277 content = _run_command(['git', 'show', '%s:%s' % (commit, path)])
278 cache[path] = content
279 return content
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500280
281
Mike Frysingerae409522014-02-01 03:16:11 -0500282def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700283 """Returns a list of (linenum, lines) tuples that the commit touched."""
Mike Frysingerb2496652019-09-12 23:35:46 -0400284 # {<commit>: {<path1>: <content>, <path2>: <content>}}
285 cache = CACHE.get_subcache('get_file_diff')
286 if path in cache:
287 return cache[path]
288
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700289 if commit == PRE_SUBMIT:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800290 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD',
291 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700292 else:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800293 command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit,
294 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700295 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700296
297 new_lines = []
298 line_num = 0
299 for line in output.splitlines():
300 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
301 if m:
302 line_num = int(m.groups(1)[0])
303 continue
304 if line.startswith('+') and not line.startswith('++'):
Mike Frysinger71e643e2019-09-13 17:26:39 -0400305 new_lines.append((line_num, line[1:]))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700306 if not line.startswith('-'):
307 line_num += 1
Mike Frysingerb2496652019-09-12 23:35:46 -0400308 cache[path] = new_lines
Ryan Cuiec4d6332011-05-02 14:15:25 -0700309 return new_lines
310
Ryan Cui1562fb82011-05-09 11:01:31 -0700311
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700312def _get_ignore_wildcards(directory, cache):
313 """Get wildcards listed in a directory's _IGNORE_FILE.
314
315 Args:
316 directory: A string containing a directory path.
317 cache: A dictionary (opaque to caller) caching previously-read wildcards.
318
319 Returns:
320 A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE
321 wasn't present.
322 """
323 # In the cache, keys are directories and values are lists of wildcards from
324 # _IGNORE_FILE within those directories (and empty if no file was present).
325 if directory not in cache:
326 wildcards = []
327 dotfile_path = os.path.join(directory, _IGNORE_FILE)
328 if os.path.exists(dotfile_path):
329 # TODO(derat): Consider using _get_file_content() to get the file as of
330 # this commit instead of the on-disk version. This may have a noticeable
331 # performance impact, as each call to _get_file_content() runs git.
332 with open(dotfile_path, 'r') as dotfile:
333 for line in dotfile.readlines():
334 line = line.strip()
335 if line.startswith('#'):
336 continue
337 if line.endswith('/'):
338 line += '*'
339 wildcards.append(line)
340 cache[directory] = wildcards
341
342 return cache[directory]
343
344
345def _path_is_ignored(path, cache):
346 """Check whether a path is ignored by _IGNORE_FILE.
347
348 Args:
349 path: A string containing a path.
350 cache: A dictionary (opaque to caller) caching previously-read wildcards.
351
352 Returns:
353 True if a file named _IGNORE_FILE in one of the passed-in path's parent
354 directories contains a wildcard matching the path.
355 """
356 # Skip ignore files.
357 if os.path.basename(path) == _IGNORE_FILE:
358 return True
359
360 path = os.path.abspath(path)
361 base = os.getcwd()
362
363 prefix = os.path.dirname(path)
364 while prefix.startswith(base):
365 rel_path = path[len(prefix) + 1:]
366 for wildcard in _get_ignore_wildcards(prefix, cache):
367 if fnmatch.fnmatch(rel_path, wildcard):
368 return True
369 prefix = os.path.dirname(prefix)
370
371 return False
372
373
Mike Frysinger292b45d2014-11-25 01:17:10 -0500374def _get_affected_files(commit, include_deletes=False, relative=False,
375 include_symlinks=False, include_adds=True,
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700376 full_details=False, use_ignore_files=True):
Peter Ammon811f6702014-06-12 15:45:38 -0700377 """Returns list of file paths that were modified/added, excluding symlinks.
378
379 Args:
380 commit: The commit
381 include_deletes: If true, we'll include deleted files in the result
382 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500383 include_symlinks: If true, we'll include symlinks in the result
384 include_adds: If true, we'll include new files in the result
385 full_details: If False, return filenames, else return structured results.
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700386 use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files.
Peter Ammon811f6702014-06-12 15:45:38 -0700387
388 Returns:
389 A list of modified/added (and perhaps deleted) files
390 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500391 if not relative and full_details:
392 raise ValueError('full_details only supports relative paths currently')
393
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700394 if commit == PRE_SUBMIT:
395 return _run_command(['git', 'diff-index', '--cached',
396 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500397
398 path = os.getcwd()
Mike Frysingerb2496652019-09-12 23:35:46 -0400399 # {<commit>: {<path1>: <content>, <path2>: <content>}}
400 cache = CACHE.get_subcache('get_affected_files')
401 if path not in cache:
402 cache[path] = git.RawDiff(path, '%s^!' % commit)
403 files = cache[path]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500404
405 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500406 if not include_symlinks:
407 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500408
409 if not include_deletes:
410 files = [x for x in files if x.status != 'D']
411
Mike Frysinger292b45d2014-11-25 01:17:10 -0500412 if not include_adds:
413 files = [x for x in files if x.status != 'A']
414
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700415 if use_ignore_files:
416 cache = {}
417 is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache)
418 files = [x for x in files if not is_ignored(x)]
419
Mike Frysinger292b45d2014-11-25 01:17:10 -0500420 if full_details:
421 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500422 return files
423 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500424 # Caller only cares about filenames.
425 files = [x.dst_file if x.dst_file else x.src_file for x in files]
426 if relative:
427 return files
428 else:
429 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700430
431
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700432def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700433 """Returns a list of commits for this review."""
Mike Frysingere300c7d2019-09-12 23:33:52 -0400434 cmd = ['git', 'log', '--no-merges', '--format=%H',
435 '%s..' % _get_upstream_branch()]
Ryan Cui72834d12011-05-05 14:51:33 -0700436 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700437
Ryan Cui1562fb82011-05-09 11:01:31 -0700438
Ryan Cuiec4d6332011-05-02 14:15:25 -0700439def _get_commit_desc(commit):
440 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700441 if commit == PRE_SUBMIT:
442 return ''
Mike Frysingerb2496652019-09-12 23:35:46 -0400443
444 # {<commit>: <content>}
445 cache = CACHE.get_subcache('get_commit_desc')
446 if commit not in cache:
Mike Frysinger4efdee72019-11-04 10:57:01 -0500447 cache[commit] = _run_command(['git', 'log', '--format=%B',
Mike Frysingerb2496652019-09-12 23:35:46 -0400448 commit + '^!'])
449 return cache[commit]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700450
451
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800452def _check_lines_in_diff(commit, files, check_callable, error_description):
453 """Checks given file for errors via the given check.
454
455 This is a convenience function for common per-line checks. It goes through all
456 files and returns a HookFailure with the error description listing all the
457 failures.
458
459 Args:
460 commit: The commit we're working on.
461 files: The files to check.
462 check_callable: A callable that takes a line and returns True if this line
463 _fails_ the check.
464 error_description: A string describing the error.
465 """
466 errors = []
467 for afile in files:
468 for line_num, line in _get_file_diff(afile, commit):
Bernie Thompson8e26f742020-07-23 14:32:31 -0700469 result = check_callable(line)
470 if result:
471 msg = f'{afile}, line {line_num}'
472 if isinstance(result, str):
473 msg += f': {result}'
474 errors.append(msg)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800475 if errors:
476 return HookFailure(error_description, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400477 return None
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800478
479
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900480def _parse_common_inclusion_options(options):
481 """Parses common hook options for including/excluding files.
482
483 Args:
484 options: Option string list.
485
486 Returns:
487 (included, excluded) where each one is a list of regex strings.
488 """
489 parser = argparse.ArgumentParser()
490 parser.add_argument('--exclude_regex', action='append')
491 parser.add_argument('--include_regex', action='append')
492 opts = parser.parse_args(options)
493 included = opts.include_regex or []
494 excluded = opts.exclude_regex or []
495 return included, excluded
496
497
Ryan Cuiec4d6332011-05-02 14:15:25 -0700498# Common Hooks
499
Ryan Cui1562fb82011-05-09 11:01:31 -0700500
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900501def _check_no_long_lines(_project, commit, options=()):
Mike Frysinger55f85b52014-12-18 14:45:21 -0500502 """Checks there are no lines longer than MAX_LEN in any of the text files."""
Keigo Oka9732e382019-06-28 17:44:59 +0900503 LONG_LINE_OK_PATHS = [
504 # Go has no line length limit.
505 # https://golang.org/doc/effective_go.html#formatting
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400506 r'.*\.go$',
Mike Frysingerf8961942020-05-15 00:36:31 -0400507 # Python does its own long line checks via pylint.
508 r'.*\.py$',
Keigo Oka9732e382019-06-28 17:44:59 +0900509 ]
Mike Frysinger55f85b52014-12-18 14:45:21 -0500510
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900511 DEFAULT_MAX_LENGTHS = [
512 # Java's line length limit is 100 chars.
513 # https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md
514 (r'.*\.java$', 100),
Mike Frysingerf8961942020-05-15 00:36:31 -0400515 # Rust's line length limit is 100 chars.
516 (r'.*\.rs$', 100),
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900517 ]
518
Ryan Cuiec4d6332011-05-02 14:15:25 -0700519 MAX_LEN = 80
520
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900521 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700522 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900523 included + COMMON_INCLUDED_PATHS,
Keigo Oka9732e382019-06-28 17:44:59 +0900524 excluded + COMMON_EXCLUDED_PATHS + LONG_LINE_OK_PATHS)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700525
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900526 errors = []
Ryan Cuiec4d6332011-05-02 14:15:25 -0700527 for afile in files:
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700528 skip_regexps = (
529 r'https?://',
530 r'^#\s*(define|include|import|pragma|if|ifndef|endif)\b',
531 )
532
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900533 max_len = MAX_LEN
534
535 for expr, length in DEFAULT_MAX_LENGTHS:
536 if re.search(expr, afile):
537 max_len = length
538 break
539
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700540 if os.path.basename(afile).startswith('OWNERS'):
541 # File paths can get long, and there's no way to break them up into
542 # multiple lines.
543 skip_regexps += (
544 r'^include\b',
545 r'file:',
546 )
547
548 skip_regexps = [re.compile(x) for x in skip_regexps]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700549 for line_num, line in _get_file_diff(afile, commit):
550 # Allow certain lines to exceed the maxlen rule.
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900551 if len(line) <= max_len or any(x.search(line) for x in skip_regexps):
Jon Salz98255932012-08-18 14:48:02 +0800552 continue
553
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900554 errors.append('%s, line %s, %s chars, over %s chars' %
555 (afile, line_num, len(line), max_len))
Jon Salz98255932012-08-18 14:48:02 +0800556 if len(errors) == 5: # Just show the first 5 errors.
557 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700558
559 if errors:
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900560 msg = 'Found lines longer than the limit (first 5 shown):'
Ryan Cui1562fb82011-05-09 11:01:31 -0700561 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400562 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700563
Ryan Cuiec4d6332011-05-02 14:15:25 -0700564
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900565def _check_no_stray_whitespace(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700566 """Checks that there is no stray whitespace at source lines end."""
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900567 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700568 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900569 included + COMMON_INCLUDED_PATHS,
570 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800571 return _check_lines_in_diff(commit, files,
572 lambda line: line.rstrip() != line,
573 'Found line ending with white space in:')
Ryan Cui1562fb82011-05-09 11:01:31 -0700574
Ryan Cuiec4d6332011-05-02 14:15:25 -0700575
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900576def _check_no_tabs(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700577 """Checks there are no unexpanded tabs."""
Mike Frysingercd134512017-10-26 04:36:33 -0400578 # Don't add entire repos here. Update the PRESUBMIT.cfg in each repo instead.
579 # We only whitelist known specific filetypes here that show up in all repos.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700580 TAB_OK_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400581 r'.*\.ebuild$',
582 r'.*\.eclass$',
583 r'.*\.go$',
584 r'.*/[M|m]akefile$',
585 r'.*\.mk$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700586 ]
587
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900588 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700589 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900590 included + COMMON_INCLUDED_PATHS,
591 excluded + COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800592 return _check_lines_in_diff(commit, files,
593 lambda line: '\t' in line,
594 'Found a tab character in:')
Ryan Cuiec4d6332011-05-02 14:15:25 -0700595
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800596
Bernie Thompson8e26f742020-07-23 14:32:31 -0700597def _check_keywords(_project, commit, options=()):
598 """Checks there are no blocked keywords in commit content."""
599 blocked_terms_file = os.path.join(_get_hooks_dir(), 'blocked_terms.txt')
600 common_keywords = set(osutils.ReadFile(blocked_terms_file).splitlines())
601 parser = argparse.ArgumentParser()
602 parser.add_argument('--exclude_regex', action='append', default=[])
603 parser.add_argument('--include_regex', action='append', default=[])
604 parser.add_argument('--block', action='append', default=[])
605 parser.add_argument('--unblock', action='append', default=[])
606 opts = parser.parse_args(options)
607
608 keywords = set(common_keywords | set(opts.block))
609 keywords = sorted(keywords - set(opts.unblock))
610 files = _filter_files(_get_affected_files(commit),
611 opts.include_regex + COMMON_INCLUDED_PATHS,
612 opts.exclude_regex + COMMON_EXCLUDED_PATHS)
613 errors = []
614
615 def _check_line(line):
616 for word in keywords:
617 m = re.search(word, line, flags=re.I)
618 if m:
Bernie Thompson4e362922020-09-02 16:17:50 -0700619 matched = True
620 # The unblock values supercede blocked values, so if any unblock
621 # regex matches a term found by the block list, we ignore it.
622 for unblocked in opts.unblock:
623 if re.search(unblocked, m.group(0)):
624 matched = False
625 break
626 if matched:
Bernie Thompson8e26f742020-07-23 14:32:31 -0700627 return 'Matched ' + word
628 return False
629
630 diff_errors = _check_lines_in_diff(commit, files, _check_line,
631 'Found a blocked keyword in:')
632 if diff_errors:
633 errors.append(diff_errors)
634
635 line_num = 1
636 commit_desc_errors = []
637 for line in _get_commit_desc(commit).splitlines():
638 result = _check_line(line)
639 if result:
640 commit_desc_errors.append('Commit message, line %s: %s' %
641 (line_num, result))
642 line_num += 1
643 if commit_desc_errors:
644 errors.append(HookFailure('Found a blocked keyword in:',
645 commit_desc_errors))
646 return errors
647
648
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900649def _check_tabbed_indents(_project, commit, options=()):
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800650 """Checks that indents use tabs only."""
651 TABS_REQUIRED_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400652 r'.*\.ebuild$',
653 r'.*\.eclass$',
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800654 ]
655 LEADING_SPACE_RE = re.compile('[\t]* ')
656
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900657 included, excluded = _parse_common_inclusion_options(options)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800658 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900659 included + TABS_REQUIRED_PATHS,
660 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800661 return _check_lines_in_diff(
662 commit, files,
663 lambda line: LEADING_SPACE_RE.match(line) is not None,
664 'Found a space in indentation (must be all tabs):')
Ryan Cui1562fb82011-05-09 11:01:31 -0700665
Ryan Cuiec4d6332011-05-02 14:15:25 -0700666
LaMont Jones872fe762020-02-10 15:36:14 -0700667def _check_gofmt(_project, commit, options=()):
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700668 """Checks that Go files are formatted with gofmt."""
LaMont Jones872fe762020-02-10 15:36:14 -0700669 included, excluded = _parse_common_inclusion_options(options)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700670 errors = []
671 files = _filter_files(_get_affected_files(commit, relative=True),
LaMont Jones872fe762020-02-10 15:36:14 -0700672 included + [r'\.go$'],
673 excluded)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700674
675 for gofile in files:
676 contents = _get_file_content(gofile, commit)
Mike Frysingeraa7dc942019-09-25 00:07:24 -0400677 output = _run_command(cmd=['gofmt', '-l'], input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500678 stderr=subprocess.STDOUT)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700679 if output:
680 errors.append(gofile)
681 if errors:
682 return HookFailure('Files not formatted with gofmt:', errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400683 return None
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700684
685
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600686def _check_rustfmt(_project, commit):
687 """Checks that Rust files are formatted with rustfmt."""
688 errors = []
689 files = _filter_files(_get_affected_files(commit, relative=True),
690 [r'\.rs$'])
691
692 for rustfile in files:
693 contents = _get_file_content(rustfile, commit)
Chirantan Ekbote1da56d52020-07-13 17:35:35 +0900694 output = _run_command(cmd=['rustfmt', '--edition', '2018'],
695 input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500696 stderr=subprocess.STDOUT)
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600697 if output != contents:
698 errors.append(rustfile)
699 if errors:
700 return HookFailure('Files not formatted with rustfmt: '
701 "(run 'cargo fmt' to fix)", errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400702 return None
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600703
704
Keiichi Watanabe6ab73fd2020-07-14 23:42:02 +0900705class CargoClippyArgumentParserError(Exception):
706 """An exception indicating an invalid check_cargo_clippy option."""
707
708
709class CargoClippyArgumentParser(argparse.ArgumentParser):
710 """A argument parser for check_cargo_clippy."""
711
712 def error(self, message):
713 raise CargoClippyArgumentParserError(message)
714
715
716# A cargo project in which clippy runs.
717ClippyProject = collections.namedtuple('ClippyProject', ('root', 'script'))
718
719
720class _AddClippyProjectAction(argparse.Action):
721 """A callback that adds a cargo clippy setting.
722
723 It accepts a value which is in the form of "ROOT[:SCRIPT]".
724 """
725
726 def __call__(self, parser, namespace, values, option_string=None):
727 if getattr(namespace, self.dest, None) is None:
728 setattr(namespace, self.dest, [])
729 spec = values.split(':', 1)
730 if len(spec) == 1:
731 spec += [None]
732
733 if spec[0].startswith('/'):
734 raise CargoClippyArgumentParserError('root path must not start with "/"'
735 f' but "{spec[0]}"')
736
737 clippy = ClippyProject(root=spec[0], script=spec[1])
738 getattr(namespace, self.dest).append(clippy)
739
740
741def _get_cargo_clippy_parser():
742 """Creates a parser for check_cargo_clippy options."""
743
744 parser = CargoClippyArgumentParser()
745 parser.add_argument('--project', action=_AddClippyProjectAction, default=[])
746
747 return parser
748
749
750def _check_cargo_clippy(project, commit, options=()):
751 """Checks that a change doesn't produce cargo-clippy errors."""
752
753 options = list(options)
754 if not options:
755 return []
756 parser = _get_cargo_clippy_parser()
757
758 try:
759 opts = parser.parse_args(options)
760 except CargoClippyArgumentParserError as e:
761 return [HookFailure('invalid check_cargo_clippy option is given.'
762 f' Please check PRESUBMIT.cfg is correct: {e}')]
763 files = _get_affected_files(commit)
764
765 errors = []
766 for clippy in opts.project:
767 root = os.path.normpath(os.path.join(project.dir, clippy.root))
768
769 # Check if any file under `root` was modified.
770 modified = False
771 for f in files:
772 if f.startswith(root):
773 modified = True
774 break
775 if not modified:
776 continue
777
778 # Clean cargo's cache when we run clippy for this `root` for the first time.
779 # We don't want to clean the cache between commits to save time when
780 # multiple commits are checked.
781 if root not in _check_cargo_clippy.cleaned_root:
782 _run_command(['cargo', 'clean',
783 f'--manifest-path={root}/Cargo.toml'],
784 stderr=subprocess.STDOUT)
785 _check_cargo_clippy.cleaned_root.add(root)
786
787 cmd = ['cargo', 'clippy', '--all-features', '--all-targets',
788 f'--manifest-path={root}/Cargo.toml',
789 '--', '-D', 'warnings']
790 # Overwrite the clippy command if a project-specific script is specified.
791 if clippy.script:
792 cmd = [os.path.join(project.dir, clippy.script)]
793
794 output = _run_command(cmd, stderr=subprocess.STDOUT)
795 error = re.search(r'^error: ', output, flags=re.MULTILINE)
796 if error:
797 msg = output[error.start():]
798 errors.append(HookFailure(msg))
799
800 return errors
801
802
803# Stores cargo projects in which `cargo clean` ran.
804_check_cargo_clippy.cleaned_root = set()
805
806
Mike Frysingerae409522014-02-01 03:16:11 -0500807def _check_change_has_test_field(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700808 """Check for a non-empty 'TEST=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500809 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700810
Cheng Yuehb707c522020-01-02 14:06:59 +0800811 if not re.search(TEST_FIELD_RE, _get_commit_desc(commit)):
Mike Frysingered9b2a02019-12-12 18:52:32 -0500812 msg = ('Changelist description needs TEST field (after first line)\n%s' %
813 (SEE_ALSO,))
Ryan Cui1562fb82011-05-09 11:01:31 -0700814 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400815 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700816
Ryan Cuiec4d6332011-05-02 14:15:25 -0700817
Mike Frysingerae409522014-02-01 03:16:11 -0500818def _check_change_has_valid_cq_depend(_project, commit):
Jason D. Clinton299e3222019-05-23 09:42:03 -0600819 """Check for a correctly formatted Cq-Depend field in the commit message."""
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700820 desc = _get_commit_desc(commit)
Jason D. Clinton299e3222019-05-23 09:42:03 -0600821 msg = 'Changelist has invalid Cq-Depend target.'
822 example = 'Example: Cq-Depend: chromium:1234, chrome-internal:2345'
David Jamesc3b68b32013-04-03 09:17:03 -0700823 try:
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700824 patch.GetPaladinDeps(desc)
David Jamesc3b68b32013-04-03 09:17:03 -0700825 except ValueError as ex:
826 return HookFailure(msg, [example, str(ex)])
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700827 # Check that Cq-Depend is in the same paragraph as Change-Id.
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500828 msg = 'Cq-Depend is not in the same paragraph as Change-Id.'
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700829 paragraphs = desc.split('\n\n')
830 for paragraph in paragraphs:
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500831 if (re.search(r'^Cq-Depend:', paragraph, re.M) and not
832 re.search('^Change-Id:', paragraph, re.M)):
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700833 return HookFailure(msg)
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500834
835 # We no longer support CQ-DEPEND= lines.
836 if re.search(r'^CQ-DEPEND[=:]', desc, re.M):
837 return HookFailure(
838 'CQ-DEPEND= is no longer supported. Please see:\n'
839 'https://chromium.googlesource.com/chromiumos/docs/+/HEAD/'
840 'contributing.md#CQ-DEPEND')
841
Mike Frysinger8cf80812019-09-16 23:49:29 -0400842 return None
David Jamesc3b68b32013-04-03 09:17:03 -0700843
844
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800845def _check_change_is_contribution(_project, commit):
846 """Check that the change is a contribution."""
847 NO_CONTRIB = 'not a contribution'
848 if NO_CONTRIB in _get_commit_desc(commit).lower():
849 msg = ('Changelist is not a contribution, this cannot be accepted.\n'
850 'Please remove the "%s" text from the commit message.') % NO_CONTRIB
851 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400852 return None
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800853
854
Alex Deymo643ac4c2015-09-03 10:40:50 -0700855def _check_change_has_bug_field(project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700856 """Check for a correctly formatted 'BUG=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500857 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
858
David James5c0073d2013-04-03 08:48:52 -0700859 OLD_BUG_RE = r'\nBUG=.*chromium-os'
860 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
861 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
862 'the chromium tracker in your BUG= line now.')
863 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700864
Alex Deymo643ac4c2015-09-03 10:40:50 -0700865 # Android internal and external projects use "Bug: " to track bugs in
866 # buganizer.
867 BUG_COLON_REMOTES = (
868 'aosp',
869 'goog',
870 )
871 if project.remote in BUG_COLON_REMOTES:
872 BUG_RE = r'\nBug: ?([Nn]one|\d+)'
873 if not re.search(BUG_RE, _get_commit_desc(commit)):
874 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500875 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700876 'Bug: 9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500877 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700878 return HookFailure(msg)
879 else:
Jorge Lucangeli Obesdce214e2017-10-25 15:04:39 -0400880 BUG_RE = r'\nBUG=([Nn]one|(chromium|b):\d+)'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700881 if not re.search(BUG_RE, _get_commit_desc(commit)):
882 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500883 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700884 'BUG=chromium:9999 (for public tracker)\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700885 'BUG=b:9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500886 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700887 return HookFailure(msg)
Ryan Cui1562fb82011-05-09 11:01:31 -0700888
Cheng Yuehb707c522020-01-02 14:06:59 +0800889 TEST_BEFORE_BUG_RE = TEST_FIELD_RE + r'.*' + BUG_RE
890
891 if re.search(TEST_BEFORE_BUG_RE, _get_commit_desc(commit), re.DOTALL):
892 msg = ('The BUG field must come before the TEST field.\n%s' %
893 (SEE_ALSO,))
894 return HookFailure(msg)
895
Mike Frysinger8cf80812019-09-16 23:49:29 -0400896 return None
897
Ryan Cuiec4d6332011-05-02 14:15:25 -0700898
Jack Neus8edbf642019-07-10 16:08:31 -0600899def _check_change_no_include_oem(project, commit):
900 """Check that the change does not reference OEMs."""
901 ALLOWLIST = {
902 'chromiumos/platform/ec',
903 # Used by unit tests.
904 'project',
905 }
906 if project.name not in ALLOWLIST:
907 return None
908
Mike Frysingerbb34a222019-07-31 14:40:46 -0400909 TAGS = {
Jack Neus8edbf642019-07-10 16:08:31 -0600910 'Reviewed-on',
911 'Reviewed-by',
912 'Signed-off-by',
913 'Commit-Ready',
914 'Tested-by',
915 'Commit-Queue',
Jack Neus8edbf642019-07-10 16:08:31 -0600916 'Acked-by',
917 'Modified-by',
918 'CC',
919 'Suggested-by',
920 'Reported-by',
921 'Acked-for-chrome-by',
LaMont Jones237f3ef2020-01-22 10:40:52 -0700922 'Cq-Cl-Tag',
LaMont Jonesfb5e8bf2020-03-03 12:50:06 -0700923 'Cq-Include-Trybots',
Mike Frysingerbb34a222019-07-31 14:40:46 -0400924 }
Jack Neus8edbf642019-07-10 16:08:31 -0600925
926 # Ignore tags, which could reasonably contain OEM names
927 # (e.g. Reviewed-by: foo@oem.corp-partner.google.com).
Jack Neus8edbf642019-07-10 16:08:31 -0600928 commit_message = ' '.join(
Mike Frysingerbb34a222019-07-31 14:40:46 -0400929 x for x in _get_commit_desc(commit).splitlines()
930 if ':' not in x or x.split(':', 1)[0] not in TAGS)
931
Jack Neus8edbf642019-07-10 16:08:31 -0600932 commit_message = re.sub(r'[\s_-]+', ' ', commit_message)
933
934 # Exercise caution when expanding these lists. Adding a name
935 # could indicate a new relationship with a company!
936 OEMS = ['hp', 'hewlett packard', 'dell', 'lenovo', 'acer', 'asus', 'samsung']
937 ODMS = [
938 'bitland', 'compal', 'haier', 'huaqin', 'inventec', 'lg', 'pegatron',
939 'pegatron(ems)', 'quanta', 'samsung', 'wistron'
940 ]
941
942 for name_type, name_list in [('OEM', OEMS), ('ODM', ODMS)]:
943 # Construct regex
944 name_re = r'\b(%s)\b' % '|'.join([re.escape(x) for x in name_list])
945 matches = [x[0] for x in re.findall(name_re, commit_message, re.IGNORECASE)]
Mike Frysingere52b1bc2019-09-16 23:45:41 -0400946 if matches:
Jack Neus8edbf642019-07-10 16:08:31 -0600947 # If there's a match, throw an error.
948 error_msg = ('Changelist description contains the name of an'
949 ' %s: "%s".' % (name_type, '","'.join(matches)))
950 return HookFailure(error_msg)
951
Mike Frysinger8cf80812019-09-16 23:49:29 -0400952 return None
953
Jack Neus8edbf642019-07-10 16:08:31 -0600954
Mike Frysinger292b45d2014-11-25 01:17:10 -0500955def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -0700956 """Check that we're not missing a revbump of an ebuild in the given commit.
957
958 If the given commit touches files in a directory that has ebuilds somewhere
959 up the directory hierarchy, it's very likely that we need an ebuild revbump
960 in order for those changes to take effect.
961
962 It's not totally trivial to detect a revbump, so at least detect that an
963 ebuild with a revision number in it was touched. This should handle the
964 common case where we use a symlink to do the revbump.
965
966 TODO: it would be nice to enhance this hook to:
967 * Handle cases where people revbump with a slightly different syntax. I see
968 one ebuild (puppy) that revbumps with _pN. This is a false positive.
969 * Catches cases where people aren't using symlinks for revbumps. If they
970 edit a revisioned file directly (and are expected to rename it for revbump)
971 we'll miss that. Perhaps we could detect that the file touched is a
972 symlink?
973
974 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
975 still better off than without this check.
976
977 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700978 project: The Project to look at
Doug Anderson42b8a052013-06-26 10:45:36 -0700979 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -0500980 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -0700981
982 Returns:
983 A HookFailure or None.
984 """
Mike Frysinger011af942014-01-17 16:12:22 -0500985 # If this is the portage-stable overlay, then ignore the check. It's rare
986 # that we're doing anything other than importing files from upstream, so
987 # forcing a rev bump makes no sense.
988 whitelist = (
989 'chromiumos/overlays/portage-stable',
990 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700991 if project.name in whitelist:
Mike Frysinger011af942014-01-17 16:12:22 -0500992 return None
993
Mike Frysinger292b45d2014-11-25 01:17:10 -0500994 def FinalName(obj):
995 # If the file is being deleted, then the dst_file is not set.
996 if obj.dst_file is None:
997 return obj.src_file
998 else:
999 return obj.dst_file
1000
1001 affected_path_objs = _get_affected_files(
1002 commit, include_deletes=True, include_symlinks=True, relative=True,
1003 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -07001004
1005 # Don't yell about changes to whitelisted files...
Mike Frysinger550c05c2019-12-09 18:16:36 -05001006 whitelist = {'ChangeLog', 'Manifest', 'metadata.xml'}
Mike Frysinger292b45d2014-11-25 01:17:10 -05001007 affected_path_objs = [x for x in affected_path_objs
1008 if os.path.basename(FinalName(x)) not in whitelist]
1009 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -07001010 return None
1011
1012 # If we've touched any file named with a -rN.ebuild then we'll say we're
1013 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -05001014 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
1015 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -07001016 if touched_revved_ebuild:
1017 return None
1018
Mike Frysinger292b45d2014-11-25 01:17:10 -05001019 # If we're creating new ebuilds from scratch, then we don't need an uprev.
1020 # Find all the dirs that new ebuilds and ignore their files/.
1021 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
1022 if FinalName(x).endswith('.ebuild') and x.status == 'A']
1023 affected_path_objs = [obj for obj in affected_path_objs
1024 if not any(FinalName(obj).startswith(x)
1025 for x in ebuild_dirs)]
1026 if not affected_path_objs:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001027 return None
Mike Frysinger292b45d2014-11-25 01:17:10 -05001028
Doug Anderson42b8a052013-06-26 10:45:36 -07001029 # We want to examine the current contents of all directories that are parents
1030 # of files that were touched (up to the top of the project).
1031 #
1032 # ...note: we use the current directory contents even though it may have
1033 # changed since the commit we're looking at. This is just a heuristic after
1034 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -05001035 if project_top is None:
1036 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -07001037 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -05001038 for obj in affected_path_objs:
1039 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -07001040 while os.path.exists(path) and not os.path.samefile(path, project_top):
1041 dirs_to_check.add(path)
1042 path = os.path.dirname(path)
1043
1044 # Look through each directory. If it's got an ebuild in it then we'll
1045 # consider this as a case when we need a revbump.
Gwendal Grignoua3086c32014-12-09 11:17:22 -08001046 affected_paths = set(os.path.join(project_top, FinalName(x))
1047 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -07001048 for dir_path in dirs_to_check:
1049 contents = os.listdir(dir_path)
1050 ebuilds = [os.path.join(dir_path, path)
1051 for path in contents if path.endswith('.ebuild')]
1052 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
1053
C Shapiroae157ae2017-09-18 16:24:03 -06001054 affected_paths_under_9999_ebuilds = set()
1055 for affected_path in affected_paths:
1056 for ebuild_9999 in ebuilds_9999:
1057 ebuild_dir = os.path.dirname(ebuild_9999)
1058 if affected_path.startswith(ebuild_dir):
1059 affected_paths_under_9999_ebuilds.add(affected_path)
1060
1061 # If every file changed exists under a 9999 ebuild, then skip
1062 if len(affected_paths_under_9999_ebuilds) == len(affected_paths):
1063 continue
1064
Doug Anderson42b8a052013-06-26 10:45:36 -07001065 # If the -9999.ebuild file was touched the bot will uprev for us.
1066 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -05001067 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -07001068 continue
1069
1070 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -05001071 return HookFailure('Changelist probably needs a revbump of an ebuild, '
1072 'or a -r1.ebuild symlink if this is a new ebuild:\n'
1073 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -07001074
1075 return None
1076
1077
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001078def _check_ebuild_eapi(project, commit):
Mike Frysinger948284a2018-02-01 15:22:56 -05001079 """Make sure we have people use EAPI=5 or newer with custom ebuilds.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001080
1081 We want to get away from older EAPI's as it makes life confusing and they
1082 have less builtin error checking.
1083
1084 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001085 project: The Project to look at
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001086 commit: The commit to look at
1087
1088 Returns:
1089 A HookFailure or None.
1090 """
1091 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -05001092 # that we're doing anything other than importing files from upstream, and
1093 # we shouldn't be rewriting things fundamentally anyways.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001094 whitelist = (
1095 'chromiumos/overlays/portage-stable',
1096 )
Alex Deymo643ac4c2015-09-03 10:40:50 -07001097 if project.name in whitelist:
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001098 return None
1099
Mike Frysinger948284a2018-02-01 15:22:56 -05001100 BAD_EAPIS = ('0', '1', '2', '3', '4')
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001101
1102 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
1103
1104 ebuilds_re = [r'\.ebuild$']
1105 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1106 ebuilds_re)
1107 bad_ebuilds = []
1108
1109 for ebuild in ebuilds:
1110 # If the ebuild does not specify an EAPI, it defaults to 0.
1111 eapi = '0'
1112
1113 lines = _get_file_content(ebuild, commit).splitlines()
1114 if len(lines) == 1:
1115 # This is most likely a symlink, so skip it entirely.
1116 continue
1117
1118 for line in lines:
1119 m = get_eapi.match(line)
1120 if m:
1121 # Once we hit the first EAPI line in this ebuild, stop processing.
1122 # The spec requires that there only be one and it be first, so
1123 # checking all possible values is pointless. We also assume that
1124 # it's "the" EAPI line and not something in the middle of a heredoc.
1125 eapi = m.group(1)
1126 break
1127
1128 if eapi in BAD_EAPIS:
1129 bad_ebuilds.append((ebuild, eapi))
1130
1131 if bad_ebuilds:
1132 # pylint: disable=C0301
Mike Frysingerc6114f42020-05-15 00:55:05 -04001133 url = 'https://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001134 # pylint: enable=C0301
1135 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -05001136 'These ebuilds are using old EAPIs. If these are imported from\n'
1137 'Gentoo, then you may ignore and upload once with the --no-verify\n'
Mike Frysingerc6114f42020-05-15 00:55:05 -04001138 'flag. Otherwise, please update to 7 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001139 '\t%s\n'
1140 'See this guide for more details:\n%s\n' %
1141 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
1142
Mike Frysinger8cf80812019-09-16 23:49:29 -04001143 return None
1144
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001145
Mike Frysinger89bdb852014-02-01 05:26:26 -05001146def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -05001147 """Make sure we use the new style KEYWORDS when possible in ebuilds.
1148
1149 If an ebuild generally does not care about the arch it is running on, then
1150 ebuilds should flag it with one of:
1151 KEYWORDS="*" # A stable ebuild.
1152 KEYWORDS="~*" # An unstable ebuild.
1153 KEYWORDS="-* ..." # Is known to only work on specific arches.
1154
1155 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001156 project: The Project to look at
Mike Frysingerc51ece72014-01-17 16:23:40 -05001157 commit: The commit to look at
1158
1159 Returns:
1160 A HookFailure or None.
1161 """
1162 WHITELIST = set(('*', '-*', '~*'))
1163
1164 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
1165
Mike Frysinger89bdb852014-02-01 05:26:26 -05001166 ebuilds_re = [r'\.ebuild$']
1167 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1168 ebuilds_re)
1169
Mike Frysinger8d42d742014-09-22 15:50:21 -04001170 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -05001171 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -04001172 # We get the full content rather than a diff as the latter does not work
1173 # on new files (like when adding new ebuilds).
1174 lines = _get_file_content(ebuild, commit).splitlines()
1175 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -05001176 m = get_keywords.match(line)
1177 if m:
1178 keywords = set(m.group(1).split())
1179 if not keywords or WHITELIST - keywords != WHITELIST:
1180 continue
1181
Mike Frysinger8d42d742014-09-22 15:50:21 -04001182 bad_ebuilds.append(ebuild)
1183
1184 if bad_ebuilds:
1185 return HookFailure(
1186 '%s\n'
1187 'Please update KEYWORDS to use a glob:\n'
1188 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
1189 ' KEYWORDS="*"\n'
1190 'If the ebuild should be marked unstable (normal for '
1191 'cros-workon / 9999 ebuilds):\n'
1192 ' KEYWORDS="~*"\n'
Mike Frysingerde8efea2015-05-17 03:42:26 -04001193 'If the ebuild needs to be marked for only specific arches, '
Mike Frysinger8d42d742014-09-22 15:50:21 -04001194 'then use -* like so:\n'
1195 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -05001196
Mike Frysinger8cf80812019-09-16 23:49:29 -04001197 return None
1198
Mike Frysingerc51ece72014-01-17 16:23:40 -05001199
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001200def _check_ebuild_licenses(_project, commit):
1201 """Check if the LICENSE field in the ebuild is correct."""
Brian Norris7a610e82016-02-17 12:24:54 -08001202 affected_paths = _get_affected_files(commit, relative=True)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001203 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
1204
1205 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -08001206 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001207
1208 for ebuild in touched_ebuilds:
1209 # Skip virutal packages.
1210 if ebuild.split('/')[-3] == 'virtual':
1211 continue
1212
Alex Kleinb5953522018-08-03 11:44:21 -06001213 # e.g. path/to/overlay/category/package/package.ebuild -> path/to/overlay
1214 overlay_path = os.sep.join(ebuild.split(os.sep)[:-3])
1215
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001216 try:
Brian Norris7a610e82016-02-17 12:24:54 -08001217 ebuild_content = _get_file_content(ebuild, commit)
Alex Kleinb5953522018-08-03 11:44:21 -06001218 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content,
1219 overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001220 except ValueError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001221 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001222
1223 # Also ignore licenses ending with '?'
1224 for license_type in [x for x in license_types
1225 if x not in LICENSES_IGNORE and not x.endswith('?')]:
1226 try:
Alex Kleinb5953522018-08-03 11:44:21 -06001227 licenses_lib.Licensing.FindLicenseType(license_type,
1228 overlay_path=overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001229 except AssertionError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001230 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001231
Mike Frysinger8cf80812019-09-16 23:49:29 -04001232 return None
1233
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001234
Mike Frysingercd363c82014-02-01 05:20:18 -05001235def _check_ebuild_virtual_pv(project, commit):
1236 """Enforce the virtual PV policies."""
1237 # If this is the portage-stable overlay, then ignore the check.
1238 # We want to import virtuals as-is from upstream Gentoo.
1239 whitelist = (
1240 'chromiumos/overlays/portage-stable',
1241 )
Alex Deymo643ac4c2015-09-03 10:40:50 -07001242 if project.name in whitelist:
Mike Frysingercd363c82014-02-01 05:20:18 -05001243 return None
1244
1245 # We assume the repo name is the same as the dir name on disk.
1246 # It would be dumb to not have them match though.
Alex Deymo643ac4c2015-09-03 10:40:50 -07001247 project_base = os.path.basename(project.name)
Mike Frysingercd363c82014-02-01 05:20:18 -05001248
1249 is_variant = lambda x: x.startswith('overlay-variant-')
1250 is_board = lambda x: x.startswith('overlay-')
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001251 is_baseboard = lambda x: x.startswith('baseboard-')
1252 is_chipset = lambda x: x.startswith('chipset-')
1253 is_project = lambda x: x.startswith('project-')
Mike Frysingercd363c82014-02-01 05:20:18 -05001254 is_private = lambda x: x.endswith('-private')
1255
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001256 is_special_overlay = lambda x: (is_board(x) or is_chipset(x) or
1257 is_baseboard(x) or is_project(x))
1258
Mike Frysingercd363c82014-02-01 05:20:18 -05001259 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
1260
1261 ebuilds_re = [r'\.ebuild$']
1262 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1263 ebuilds_re)
1264 bad_ebuilds = []
1265
1266 for ebuild in ebuilds:
1267 m = get_pv.match(ebuild)
1268 if m:
1269 overlay = m.group(1)
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001270 if not overlay or not is_special_overlay(overlay):
Alex Deymo643ac4c2015-09-03 10:40:50 -07001271 overlay = project_base
Mike Frysingercd363c82014-02-01 05:20:18 -05001272
1273 pv = m.group(3).split('-', 1)[0]
1274
Bernie Thompsone5ee1822016-01-12 14:22:23 -08001275 # Virtual versions >= 4 are special cases used above the standard
1276 # versioning structure, e.g. if one has a board inheriting a board.
Julius Werner0299a2b2020-07-31 18:20:43 -07001277 if pv[0] >= '4':
Bernie Thompsone5ee1822016-01-12 14:22:23 -08001278 want_pv = pv
Mike Frysingercd363c82014-02-01 05:20:18 -05001279 elif is_board(overlay):
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001280 if is_private(overlay):
1281 want_pv = '3.5' if is_variant(overlay) else '3'
1282 elif is_board(overlay):
1283 want_pv = '2.5' if is_variant(overlay) else '2'
1284 elif is_baseboard(overlay):
Julius Werner0299a2b2020-07-31 18:20:43 -07001285 want_pv = '1.9.5' if is_private(overlay) else '1.9'
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001286 elif is_chipset(overlay):
Julius Werner0299a2b2020-07-31 18:20:43 -07001287 want_pv = '1.8.5' if is_private(overlay) else '1.8'
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001288 elif is_project(overlay):
1289 want_pv = '1.7' if is_private(overlay) else '1.5'
Mike Frysingercd363c82014-02-01 05:20:18 -05001290 else:
1291 want_pv = '1'
1292
1293 if pv != want_pv:
1294 bad_ebuilds.append((ebuild, pv, want_pv))
1295
1296 if bad_ebuilds:
1297 # pylint: disable=C0301
1298 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
1299 # pylint: enable=C0301
1300 return HookFailure(
1301 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
1302 '\t%s\n'
1303 'If this is an upstream Gentoo virtual, then you may ignore this\n'
1304 'check (and re-run w/--no-verify). Otherwise, please see this\n'
1305 'page for more details:\n%s\n' %
1306 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
1307 for x in bad_ebuilds]), url))
1308
Mike Frysinger8cf80812019-09-16 23:49:29 -04001309 return None
1310
Mike Frysingercd363c82014-02-01 05:20:18 -05001311
Daniel Erat9d203ff2015-02-17 10:12:21 -07001312def _check_portage_make_use_var(_project, commit):
1313 """Verify that $USE is set correctly in make.conf and make.defaults."""
1314 files = _filter_files(_get_affected_files(commit, relative=True),
1315 [r'(^|/)make.(conf|defaults)$'])
1316
1317 errors = []
1318 for path in files:
1319 basename = os.path.basename(path)
1320
1321 # Has a USE= line already been encountered in this file?
1322 saw_use = False
1323
1324 for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1):
1325 if not line.startswith('USE='):
1326 continue
1327
1328 preserves_use = '${USE}' in line or '$USE' in line
1329
1330 if (basename == 'make.conf' or
1331 (basename == 'make.defaults' and saw_use)) and not preserves_use:
1332 errors.append('%s:%d: missing ${USE}' % (path, i))
1333 elif basename == 'make.defaults' and not saw_use and preserves_use:
1334 errors.append('%s:%d: ${USE} referenced in initial declaration' %
1335 (path, i))
1336
1337 saw_use = True
1338
1339 if errors:
1340 return HookFailure(
1341 'One or more Portage make files appear to set USE incorrectly.\n'
1342 '\n'
1343 'All USE assignments in make.conf and all assignments after the\n'
1344 'initial declaration in make.defaults should contain "${USE}" to\n'
1345 'preserve previously-set flags.\n'
1346 '\n'
1347 'The initial USE declaration in make.defaults should not contain\n'
1348 '"${USE}".\n',
1349 errors)
1350
Mike Frysinger8cf80812019-09-16 23:49:29 -04001351 return None
1352
Daniel Erat9d203ff2015-02-17 10:12:21 -07001353
Mike Frysingerae409522014-02-01 03:16:11 -05001354def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001355 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001356 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001357 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001358 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001359 if not m:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001360 return HookFailure('Last paragraph of description must include Change-Id.')
Ryan Cui1562fb82011-05-09 11:01:31 -07001361
LaMont Jonesfb5e8bf2020-03-03 12:50:06 -07001362 # S-o-b and some other tags always allowed to follow Change-ID in the footer.
1363 allowed_tags = ['Signed-off-by', 'Cq-Cl-Tag', 'Cq-Include-Trybots']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001364
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001365 end = desc[m.end():].strip().splitlines()
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001366 cherry_pick_marker = 'cherry picked from commit'
1367
1368 if end and cherry_pick_marker in end[-1]:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001369 # Cherry picked patches allow more tags in the last paragraph.
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001370 allowed_tags += ['Commit-Queue', 'Commit-Ready', 'Reviewed-by',
1371 'Reviewed-on', 'Tested-by']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001372 end = end[:-1]
1373
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001374 # Note that descriptions could have multiple cherry pick markers.
1375 tag_search = r'^(%s:|\(%s) ' % (':|'.join(allowed_tags), cherry_pick_marker)
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001376
1377 if [x for x in end if not re.search(tag_search, x)]:
1378 return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' %
1379 ':", "'.join(allowed_tags))
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001380
Mike Frysinger8cf80812019-09-16 23:49:29 -04001381 return None
1382
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001383
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001384def _check_commit_message_style(_project, commit):
1385 """Verify that the commit message matches our style.
1386
1387 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
1388 commit hooks.
1389 """
Mike Frysingered9b2a02019-12-12 18:52:32 -05001390 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Mike Frysinger4efdee72019-11-04 10:57:01 -05001391
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001392 desc = _get_commit_desc(commit)
1393
1394 # The first line should be by itself.
1395 lines = desc.splitlines()
1396 if len(lines) > 1 and lines[1]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001397 return HookFailure('The second line of the commit message must be blank.'
1398 '\n%s' % (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001399
1400 # The first line should be one sentence.
1401 if '. ' in lines[0]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001402 return HookFailure('The first line cannot be more than one sentence.\n%s' %
1403 (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001404
1405 # The first line cannot be too long.
1406 MAX_FIRST_LINE_LEN = 100
1407 if len(lines[0]) > MAX_FIRST_LINE_LEN:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001408 return HookFailure('The first line must be less than %i chars.\n%s' %
1409 (MAX_FIRST_LINE_LEN, SEE_ALSO))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001410
Mike Frysinger8cf80812019-09-16 23:49:29 -04001411 return None
1412
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001413
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001414def _check_cros_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001415 """Verifies the Chromium OS license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -07001416
Mike Frysinger98638102014-08-28 00:15:08 -04001417 Should be following the spec:
1418 http://dev.chromium.org/developers/coding-style#TOC-File-headers
1419 """
1420 # For older years, be a bit more flexible as our policy says leave them be.
1421 LICENSE_HEADER = (
Keigo Oka7e880ac2019-07-03 15:03:43 +09001422 r'.*Copyright(?: \(c\))? (20[0-9]{2})(?:-20[0-9]{2})? The Chromium OS '
1423 r'Authors\. All rights reserved\.\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001424 r'.*Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001425 r'be\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001426 r'.*found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -05001427 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001428 )
1429 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1430
1431 # For newer years, be stricter.
Keigo Oka7e880ac2019-07-03 15:03:43 +09001432 BAD_COPYRIGHT_LINE = (
Brian Norris68838dd2018-09-26 18:30:24 -07001433 r'.*Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001434 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001435 )
Keigo Oka7e880ac2019-07-03 15:03:43 +09001436 bad_copyright_re = re.compile(BAD_COPYRIGHT_LINE)
Mike Frysinger98638102014-08-28 00:15:08 -04001437
Shuhei Takahashiabc20f32017-07-10 19:35:45 +09001438 included, excluded = _parse_common_inclusion_options(options)
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001439
Mike Frysinger98638102014-08-28 00:15:08 -04001440 bad_files = []
1441 bad_copyright_files = []
Keigo Oka7e880ac2019-07-03 15:03:43 +09001442 bad_year_files = []
1443
Ken Turnerd07564b2018-02-08 17:57:59 +11001444 files = _filter_files(
1445 _get_affected_files(commit, relative=True),
1446 included + COMMON_INCLUDED_PATHS,
1447 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001448 existing_files = set(_get_affected_files(commit, relative=True,
1449 include_adds=False))
Mike Frysinger98638102014-08-28 00:15:08 -04001450
Keigo Oka7e880ac2019-07-03 15:03:43 +09001451 current_year = str(datetime.datetime.now().year)
Mike Frysinger98638102014-08-28 00:15:08 -04001452 for f in files:
1453 contents = _get_file_content(f, commit)
1454 if not contents:
1455 # Ignore empty files.
1456 continue
1457
Keigo Oka7e880ac2019-07-03 15:03:43 +09001458 m = license_re.search(contents)
1459 if not m:
Mike Frysinger98638102014-08-28 00:15:08 -04001460 bad_files.append(f)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001461 elif bad_copyright_re.search(contents):
Mike Frysinger98638102014-08-28 00:15:08 -04001462 bad_copyright_files.append(f)
1463
Keigo Oka7e880ac2019-07-03 15:03:43 +09001464 if m and f not in existing_files:
1465 year = m.group(1)
1466 if year != current_year:
1467 bad_year_files.append(f)
1468
1469 errors = []
Mike Frysinger98638102014-08-28 00:15:08 -04001470 if bad_files:
1471 msg = '%s:\n%s\n%s' % (
1472 'License must match', license_re.pattern,
1473 'Found a bad header in these files:')
Keigo Oka7e880ac2019-07-03 15:03:43 +09001474 errors.append(HookFailure(msg, bad_files))
Mike Frysinger98638102014-08-28 00:15:08 -04001475 if bad_copyright_files:
1476 msg = 'Do not use (c) in copyright headers in new files:'
Keigo Oka7e880ac2019-07-03 15:03:43 +09001477 errors.append(HookFailure(msg, bad_copyright_files))
1478 if bad_year_files:
1479 msg = 'Use current year (%s) in copyright headers in new files:' % (
1480 current_year)
1481 errors.append(HookFailure(msg, bad_year_files))
Ryan Cuiec4d6332011-05-02 14:15:25 -07001482
Keigo Oka7e880ac2019-07-03 15:03:43 +09001483 return errors
Ryan Cuiec4d6332011-05-02 14:15:25 -07001484
Mike Frysinger8cf80812019-09-16 23:49:29 -04001485
Amin Hassani391efa92018-01-26 17:58:05 -08001486def _check_aosp_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001487 """Verifies the AOSP license/copyright header.
1488
1489 AOSP uses the Apache2 License:
1490 https://source.android.com/source/licenses.html
1491 """
1492 LICENSE_HEADER = (
1493 r"""^[#/\*]*
1494[#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project
1495[#/\*]* ?
1496[#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\);
1497[#/\*]* ?you may not use this file except in compliance with the License\.
1498[#/\*]* ?You may obtain a copy of the License at
1499[#/\*]* ?
1500[#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0
1501[#/\*]* ?
1502[#/\*]* ?Unless required by applicable law or agreed to in writing, software
1503[#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS,
1504[#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """
1505 r"""implied\.
1506[#/\*]* ?See the License for the specific language governing permissions and
1507[#/\*]* ?limitations under the License\.
1508[#/\*]*$
1509"""
1510 )
1511 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1512
Amin Hassani391efa92018-01-26 17:58:05 -08001513 included, excluded = _parse_common_inclusion_options(options)
1514
Ken Turnerd07564b2018-02-08 17:57:59 +11001515 files = _filter_files(
1516 _get_affected_files(commit, relative=True),
1517 included + COMMON_INCLUDED_PATHS,
1518 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Alex Deymof5792ce2015-08-24 22:50:08 -07001519
1520 bad_files = []
1521 for f in files:
1522 contents = _get_file_content(f, commit)
1523 if not contents:
1524 # Ignore empty files.
1525 continue
1526
1527 if not license_re.search(contents):
1528 bad_files.append(f)
1529
1530 if bad_files:
1531 msg = ('License must match:\n%s\nFound a bad header in these files:' %
1532 license_re.pattern)
1533 return HookFailure(msg, bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001534 return None
Alex Deymof5792ce2015-08-24 22:50:08 -07001535
1536
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001537def _check_layout_conf(_project, commit):
1538 """Verifies the metadata/layout.conf file."""
1539 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001540 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001541 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001542 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001543
Mike Frysinger94a670c2014-09-19 12:46:26 -04001544 # Handle multiple overlays in a single commit (like the public tree).
1545 for f in _get_affected_files(commit, relative=True):
1546 if f.endswith(repo_name):
1547 repo_names.append(f)
1548 elif f.endswith(layout_path):
1549 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001550
1551 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -04001552 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001553 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -04001554 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001555
Mike Frysinger94a670c2014-09-19 12:46:26 -04001556 # Gather all the errors in one pass so we show one full message.
1557 all_errors = {}
1558 for layout_path in layout_paths:
1559 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001560
Mike Frysinger94a670c2014-09-19 12:46:26 -04001561 # Make sure the config file is sorted.
1562 data = [x for x in _get_file_content(layout_path, commit).splitlines()
1563 if x and x[0] != '#']
1564 if sorted(data) != data:
1565 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001566
Mike Frysinger94a670c2014-09-19 12:46:26 -04001567 # Require people to set specific values all the time.
1568 settings = (
1569 # TODO: Enable this for everyone. http://crbug.com/408038
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001570 # ('fast caching', 'cache-format = md5-dict'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001571 ('fast manifests', 'thin-manifests = true'),
Mike Frysingerd7734522015-02-26 16:12:43 -05001572 ('extra features', 'profile-formats = portage-2 profile-default-eapi'),
1573 ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001574 )
1575 for reason, line in settings:
1576 if line not in data:
1577 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001578
Mike Frysinger94a670c2014-09-19 12:46:26 -04001579 # Require one of these settings.
Mike Frysinger5fae62d2015-11-11 20:12:15 -05001580 if 'use-manifests = strict' not in data:
1581 errors += ['enable file checking with: use-manifests = strict']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001582
Mike Frysinger94a670c2014-09-19 12:46:26 -04001583 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -04001584 for line in data:
1585 if line.startswith('repo-name = '):
1586 break
1587 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -04001588 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001589
Mike Frysinger94a670c2014-09-19 12:46:26 -04001590 # Summarize all the errors we saw (if any).
1591 lines = ''
1592 for layout_path, errors in all_errors.items():
1593 if errors:
1594 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
1595 if lines:
1596 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
1597 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001598
Mike Frysinger8cf80812019-09-16 23:49:29 -04001599 return None
1600
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001601
Keigo Oka4a09bd92019-05-07 14:01:00 +09001602def _check_no_new_gyp(_project, commit):
1603 """Verifies no project starts to use GYP."""
Keigo Oka4a09bd92019-05-07 14:01:00 +09001604 gypfiles = _filter_files(
1605 _get_affected_files(commit, include_symlinks=True, relative=True),
1606 [r'\.gyp$'])
1607
1608 if gypfiles:
1609 return HookFailure('GYP is deprecated and not allowed in a new project:',
1610 gypfiles)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001611 return None
Keigo Oka4a09bd92019-05-07 14:01:00 +09001612
1613
Ryan Cuiec4d6332011-05-02 14:15:25 -07001614# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001615
Ryan Cui1562fb82011-05-09 11:01:31 -07001616
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001617def _check_clang_format(_project, commit, options=()):
1618 """Runs clang-format on the given project"""
1619 hooks_dir = _get_hooks_dir()
1620 options = list(options)
1621 if commit == PRE_SUBMIT:
1622 options.append('--commit=HEAD')
1623 else:
1624 options.extend(['--commit', commit])
Brian Norris0c62a142018-12-11 13:24:29 -08001625 cmd = [os.path.join(hooks_dir, 'clang-format.py')] + options
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001626 cmd_result = cros_build_lib.run(cmd,
1627 print_cmd=False,
1628 stdout=True,
1629 encoding='utf-8',
1630 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001631 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001632 check=False)
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001633 if cmd_result.returncode:
1634 return HookFailure('clang-format.py errors/warnings\n\n' +
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001635 cmd_result.stdout)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001636 return None
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001637
1638
Mike Frysingerae409522014-02-01 03:16:11 -05001639def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001640 """Runs checkpatch.pl on the given project"""
1641 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001642 options = list(options)
Brian Norris4cee0502020-06-12 17:02:56 -07001643 if options and options[0].startswith('./') and os.path.exists(options[0]):
1644 cmdpath = options.pop(0)
1645 else:
1646 cmdpath = os.path.join(hooks_dir, 'checkpatch.pl')
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001647 if commit == PRE_SUBMIT:
1648 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
1649 # this case.
1650 options.append('--ignore=MISSING_SIGN_OFF')
Filipe Brandenburger28d48d62015-10-07 09:48:54 -07001651 # Always ignore the check for the MAINTAINERS file. We do not track that
1652 # information on that file in our source trees, so let's suppress the
1653 # warning.
1654 options.append('--ignore=FILE_PATH_CHANGES')
Filipe Brandenburgerce978322015-10-09 10:04:15 -07001655 # Do not complain about the Change-Id: fields, since we use Gerrit.
1656 # Upstream does not want those lines (since they do not use Gerrit), but
1657 # we always do, so disable the check globally.
Daisuke Nojiri4844f892015-10-08 09:54:33 -07001658 options.append('--ignore=GERRIT_CHANGE_ID')
Brian Norris4cee0502020-06-12 17:02:56 -07001659 cmd = [cmdpath] + options + ['-']
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001660 cmd_result = cros_build_lib.run(
1661 cmd, print_cmd=False, input=_get_patch(commit).encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001662 stdout=True, stderr=subprocess.STDOUT, check=False, encoding='utf-8',
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001663 errors='replace')
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001664 if cmd_result.returncode:
Brian Norris4cee0502020-06-12 17:02:56 -07001665 return HookFailure('%s errors/warnings\n\n%s' %
1666 (cmdpath, cmd_result.stdout))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001667 return None
Ryan Cuiec4d6332011-05-02 14:15:25 -07001668
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001669
Brian Norris23c62e92018-11-14 12:25:51 -08001670def _run_kerneldoc(_project, commit, options=()):
1671 """Runs kernel-doc validator on the given project"""
1672 included, excluded = _parse_common_inclusion_options(options)
1673 files = _filter_files(_get_affected_files(commit, relative=True),
1674 included, excluded)
1675 if files:
1676 hooks_dir = _get_hooks_dir()
Brian Norris0c62a142018-12-11 13:24:29 -08001677 cmd = [os.path.join(hooks_dir, 'kernel-doc'), '-none'] + files
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001678 output = _run_command(cmd, stderr=subprocess.STDOUT)
Brian Norris23c62e92018-11-14 12:25:51 -08001679 if output:
Brian Norris0c62a142018-12-11 13:24:29 -08001680 return HookFailure('kernel-doc errors/warnings:',
1681 items=output.splitlines())
Mike Frysinger8cf80812019-09-16 23:49:29 -04001682 return None
Brian Norris23c62e92018-11-14 12:25:51 -08001683
1684
Mike Frysingerae409522014-02-01 03:16:11 -05001685def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -07001686 """Makes sure kernel config changes are not mixed with code changes"""
1687 files = _get_affected_files(commit)
Mike Frysingerf252cfc2019-12-09 17:34:28 -05001688 if len(_filter_files(files, [r'chromeos/config'])) not in [0, len(files)]:
Olof Johanssona96810f2012-09-04 16:20:03 -07001689 return HookFailure('Changes to chromeos/config/ and regular files must '
1690 'be in separate commits:\n%s' % '\n'.join(files))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001691 return None
Anton Staaf815d6852011-08-22 10:08:45 -07001692
Mike Frysingerae409522014-02-01 03:16:11 -05001693
1694def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -07001695 """Checks that all JSON files are syntactically valid."""
Mike Frysinger908be682018-01-04 02:21:50 -05001696 ret = []
1697
1698 files = _filter_files(_get_affected_files(commit, relative=True),
1699 [r'.*\.json$'])
1700 for f in files:
1701 data = _get_file_content(f, commit)
Dale Curtis2975c432011-05-03 17:25:20 -07001702 try:
Mike Frysinger908be682018-01-04 02:21:50 -05001703 json.loads(data)
1704 except Exception as e:
1705 ret.append('%s: Invalid JSON: %s' % (f, e))
1706
1707 if ret:
1708 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001709 return None
Dale Curtis2975c432011-05-03 17:25:20 -07001710
1711
Mike Frysingerae409522014-02-01 03:16:11 -05001712def _check_manifests(_project, commit):
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001713 """Make sure Manifest files only have comments & DIST lines."""
1714 ret = []
Mike Frysinger52b537e2013-08-22 22:59:53 -04001715
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001716 manifests = _filter_files(_get_affected_files(commit, relative=True),
1717 [r'.*/Manifest$'])
1718 for path in manifests:
1719 data = _get_file_content(path, commit)
1720
1721 # Disallow blank files.
1722 if not data.strip():
1723 ret.append('%s: delete empty file' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001724 continue
1725
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001726 # Make sure the last newline isn't omitted.
1727 if data[-1] != '\n':
1728 ret.append('%s: missing trailing newline' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001729
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001730 # Do not allow leading or trailing blank lines.
1731 lines = data.splitlines()
1732 if not lines[0]:
1733 ret.append('%s: delete leading blank lines' % (path,))
1734 if not lines[-1]:
1735 ret.append('%s: delete trailing blank lines' % (path,))
1736
1737 for line in lines:
1738 # Disallow leading/trailing whitespace.
1739 if line != line.strip():
1740 ret.append('%s: remove leading/trailing whitespace: %s' % (path, line))
1741
1742 # Allow blank lines & comments.
1743 line = line.split('#', 1)[0]
1744 if not line:
1745 continue
1746
1747 # All other linse should start with DIST.
1748 if not line.startswith('DIST '):
1749 ret.append('%s: remove non-DIST lines: %s' % (path, line))
1750 break
1751
1752 if ret:
1753 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001754 return None
Mike Frysinger52b537e2013-08-22 22:59:53 -04001755
1756
Mike Frysingerae409522014-02-01 03:16:11 -05001757def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001758 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001759 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001760 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001761 BRANCH_RE = r'\nBRANCH=\S+'
1762
1763 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
1764 msg = ('Changelist description needs BRANCH field (after first line)\n'
1765 'E.g. BRANCH=none or BRANCH=link,snow')
1766 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001767 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001768
1769
Mike Frysinger45334bd2019-11-04 10:42:33 -05001770def _check_change_has_no_branch_field(_project, commit):
1771 """Verify 'BRANCH=' field does not exist in the commit message."""
1772 if commit == PRE_SUBMIT:
1773 return None
1774 BRANCH_RE = r'\nBRANCH=\S+'
1775
1776 if re.search(BRANCH_RE, _get_commit_desc(commit)):
1777 msg = 'This checkout does not use BRANCH= fields. Delete them.'
1778 return HookFailure(msg)
1779 return None
1780
1781
Mike Frysingerae409522014-02-01 03:16:11 -05001782def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001783 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001784 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001785 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001786 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1787
1788 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1789 msg = ('Changelist description needs Signed-off-by: field\n'
1790 'E.g. Signed-off-by: My Name <me@chromium.org>')
1791 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001792 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001793
1794
Mike Frysinger9ab64b12019-11-04 10:53:08 -05001795def _check_change_has_no_signoff_field(_project, commit):
1796 """Verify 'Signed-off-by:' field does not exist in the commit message."""
1797 if commit == PRE_SUBMIT:
1798 return None
1799 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1800
1801 if re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1802 msg = 'This checkout does not use Signed-off-by: tags. Delete them.'
1803 return HookFailure(msg)
1804 return None
1805
1806
Jon Salz3ee59de2012-08-18 13:54:22 +08001807def _run_project_hook_script(script, project, commit):
1808 """Runs a project hook script.
1809
1810 The script is run with the following environment variables set:
1811 PRESUBMIT_PROJECT: The affected project
1812 PRESUBMIT_COMMIT: The affected commit
1813 PRESUBMIT_FILES: A newline-separated list of affected files
1814
1815 The script is considered to fail if the exit code is non-zero. It should
1816 write an error message to stdout.
1817 """
1818 env = dict(os.environ)
Alex Deymo643ac4c2015-09-03 10:40:50 -07001819 env['PRESUBMIT_PROJECT'] = project.name
Jon Salz3ee59de2012-08-18 13:54:22 +08001820 env['PRESUBMIT_COMMIT'] = commit
1821
1822 # Put affected files in an environment variable
1823 files = _get_affected_files(commit)
1824 env['PRESUBMIT_FILES'] = '\n'.join(files)
1825
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001826 cmd_result = cros_build_lib.run(cmd=script,
1827 env=env,
1828 shell=True,
1829 print_cmd=False,
1830 input=os.devnull,
1831 stdout=True,
1832 encoding='utf-8',
1833 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001834 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001835 check=False)
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001836 if cmd_result.returncode:
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001837 stdout = cmd_result.stdout
Jon Salz7b618af2012-08-31 06:03:16 +08001838 if stdout:
1839 stdout = re.sub('(?m)^', ' ', stdout)
1840 return HookFailure('Hook script "%s" failed with code %d%s' %
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001841 (script, cmd_result.returncode,
Jon Salz3ee59de2012-08-18 13:54:22 +08001842 ':\n' + stdout if stdout else ''))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001843 return None
Jon Salz3ee59de2012-08-18 13:54:22 +08001844
1845
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001846def _check_project_prefix(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -05001847 """Require the commit message have a project specific prefix as needed."""
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001848
Brian Norris77608e12018-04-06 10:38:43 -07001849 files = _get_affected_files(commit, include_deletes=True, relative=True)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001850 prefix = os.path.commonprefix(files)
1851 prefix = os.path.dirname(prefix)
1852
1853 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07001854 if not prefix:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001855 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001856
1857 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07001858
1859 # The common files may all be within a subdirectory of the main project
1860 # directory, so walk up the tree until we find an alias file.
1861 # _get_affected_files() should return relative paths, but check against '/' to
1862 # ensure that this loop terminates even if it receives an absolute path.
1863 while prefix and prefix != '/':
1864 alias_file = os.path.join(prefix, '.project_alias')
1865
1866 # If an alias exists, use it.
1867 if os.path.isfile(alias_file):
1868 project_name = osutils.ReadFile(alias_file).strip()
1869
1870 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001871
1872 if not _get_commit_desc(commit).startswith(project_name + ': '):
1873 return HookFailure('The commit title for changes affecting only %s'
1874 ' should start with \"%s: \"'
1875 % (project_name, project_name))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001876 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001877
1878
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001879def _check_filepath_chartype(_project, commit):
1880 """Checks that FilePath::CharType stuff is not used."""
1881
1882 FILEPATH_REGEXP = re.compile('|'.join(
1883 [r'(?:base::)?FilePath::(?:Char|String|StringPiece)Type',
Satoru Takabayashi4ca37922018-08-08 10:16:38 +09001884 r'(?:base::)?FilePath::FromUTF8Unsafe',
1885 r'AsUTF8Unsafe',
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001886 r'FILE_PATH_LITERAL']))
1887 files = _filter_files(_get_affected_files(commit, relative=True),
1888 [r'.*\.(cc|h)$'])
1889
1890 errors = []
1891 for afile in files:
1892 for line_num, line in _get_file_diff(afile, commit):
1893 m = re.search(FILEPATH_REGEXP, line)
1894 if m:
1895 errors.append('%s, line %s has %s' % (afile, line_num, m.group(0)))
1896
1897 if errors:
1898 msg = 'Please assume FilePath::CharType is char (crbug.com/870621):'
1899 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001900 return None
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001901
1902
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001903def _check_exec_files(_project, commit):
1904 """Make +x bits on files."""
1905 # List of files that should never be +x.
1906 NO_EXEC = (
1907 'ChangeLog*',
1908 'COPYING',
1909 'make.conf',
1910 'make.defaults',
1911 'Manifest',
1912 'OWNERS',
1913 'package.use',
1914 'package.keywords',
1915 'package.mask',
1916 'parent',
1917 'README',
1918 'TODO',
1919 '.gitignore',
1920 '*.[achly]',
1921 '*.[ch]xx',
1922 '*.boto',
1923 '*.cc',
1924 '*.cfg',
1925 '*.conf',
1926 '*.config',
1927 '*.cpp',
1928 '*.css',
1929 '*.ebuild',
1930 '*.eclass',
Tatsuhisa Yamaguchi3b053632019-01-10 14:45:14 +09001931 '*.gn',
1932 '*.gni',
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001933 '*.gyp',
1934 '*.gypi',
1935 '*.htm',
1936 '*.html',
1937 '*.ini',
1938 '*.js',
1939 '*.json',
1940 '*.md',
1941 '*.mk',
1942 '*.patch',
1943 '*.policy',
1944 '*.proto',
1945 '*.raw',
1946 '*.rules',
1947 '*.service',
1948 '*.target',
1949 '*.txt',
1950 '*.xml',
1951 '*.yaml',
1952 )
1953
1954 def FinalName(obj):
1955 # If the file is being deleted, then the dst_file is not set.
1956 if obj.dst_file is None:
1957 return obj.src_file
1958 else:
1959 return obj.dst_file
1960
1961 bad_files = []
1962 files = _get_affected_files(commit, relative=True, full_details=True)
1963 for f in files:
1964 mode = int(f.dst_mode, 8)
1965 if not mode & 0o111:
1966 continue
1967 name = FinalName(f)
1968 for no_exec in NO_EXEC:
1969 if fnmatch.fnmatch(name, no_exec):
1970 bad_files.append(name)
1971 break
1972
1973 if bad_files:
1974 return HookFailure('These files should not be executable. '
1975 'Please `chmod -x` them.', bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001976 return None
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001977
1978
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001979# Base
1980
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001981# A list of hooks which are not project specific and check patch description
1982# (as opposed to patch body).
1983_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07001984 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07001985 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07001986 _check_change_has_test_field,
1987 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001988 _check_commit_message_style,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001989 _check_change_is_contribution,
Jack Neus8edbf642019-07-10 16:08:31 -06001990 _check_change_no_include_oem,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001991]
1992
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001993# A list of hooks that are not project-specific
1994_COMMON_HOOKS = [
Keiichi Watanabe6ab73fd2020-07-14 23:42:02 +09001995 _check_cargo_clippy,
Aviv Keshet5ac59522017-01-31 14:28:27 -08001996 _check_cros_license,
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001997 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05001998 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001999 _check_ebuild_licenses,
Mike Frysingercd363c82014-02-01 05:20:18 -05002000 _check_ebuild_virtual_pv,
Mike Frysingerf9d41b32017-02-23 15:20:04 -05002001 _check_exec_files,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002002 _check_for_uprev,
Rahul Chaudhry09f61372015-07-31 17:14:26 -07002003 _check_gofmt,
Bernie Thompson8e26f742020-07-23 14:32:31 -07002004 _check_keywords,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04002005 _check_layout_conf,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002006 _check_no_long_lines,
Keigo Oka4a09bd92019-05-07 14:01:00 +09002007 _check_no_new_gyp,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002008 _check_no_stray_whitespace,
Ryan Cui9b651632011-05-11 11:38:58 -07002009 _check_no_tabs,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002010 _check_portage_make_use_var,
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -06002011 _check_rustfmt,
Aviv Keshet5ac59522017-01-31 14:28:27 -08002012 _check_tabbed_indents,
Ryan Cui9b651632011-05-11 11:38:58 -07002013]
Ryan Cuiec4d6332011-05-02 14:15:25 -07002014
Ryan Cui1562fb82011-05-09 11:01:31 -07002015
Ryan Cui9b651632011-05-11 11:38:58 -07002016# A dictionary of project-specific hooks(callbacks), indexed by project name.
2017# dict[project] = [callback1, callback2]
2018_PROJECT_SPECIFIC_HOOKS = {
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002019 'chromiumos/third_party/kernel': [_kernel_configcheck],
2020 'chromiumos/third_party/kernel-next': [_kernel_configcheck],
Ryan Cui9b651632011-05-11 11:38:58 -07002021}
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002022
Ryan Cui1562fb82011-05-09 11:01:31 -07002023
Ryan Cui9b651632011-05-11 11:38:58 -07002024# A dictionary of flags (keys) that can appear in the config file, and the hook
Mike Frysinger3554bc92015-03-11 04:59:21 -04002025# that the flag controls (value).
2026_HOOK_FLAGS = {
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07002027 'clang_format_check': _check_clang_format,
Mike Frysingera7642f52015-03-25 18:31:42 -04002028 'checkpatch_check': _run_checkpatch,
Brian Norris23c62e92018-11-14 12:25:51 -08002029 'kerneldoc_check': _run_kerneldoc,
Ryan Cui9b651632011-05-11 11:38:58 -07002030 'stray_whitespace_check': _check_no_stray_whitespace,
Mike Frysingerff6c7d62015-03-24 13:49:46 -04002031 'json_check': _run_json_check,
Ryan Cui9b651632011-05-11 11:38:58 -07002032 'long_line_check': _check_no_long_lines,
Alex Deymof5792ce2015-08-24 22:50:08 -07002033 'cros_license_check': _check_cros_license,
2034 'aosp_license_check': _check_aosp_license,
LaMont Jones872fe762020-02-10 15:36:14 -07002035 'gofmt_check': _check_gofmt,
Bernie Thompson8e26f742020-07-23 14:32:31 -07002036 'keyword_check': _check_keywords,
Ryan Cui9b651632011-05-11 11:38:58 -07002037 'tab_check': _check_no_tabs,
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08002038 'tabbed_indent_required_check': _check_tabbed_indents,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07002039 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08002040 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07002041 'bug_field_check': _check_change_has_bug_field,
2042 'test_field_check': _check_change_has_test_field,
Steve Fung49ec7e92015-03-23 16:07:12 -07002043 'manifest_check': _check_manifests,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08002044 'contribution_check': _check_change_is_contribution,
Mike Frysinger47bd1252018-06-11 12:12:20 -04002045 'project_prefix_check': _check_project_prefix,
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09002046 'filepath_chartype_check': _check_filepath_chartype,
Keiichi Watanabe6ab73fd2020-07-14 23:42:02 +09002047 'cargo_clippy_check': _check_cargo_clippy,
Julius Werner291d8602020-07-31 17:34:02 -07002048 'exec_files_check': _check_exec_files,
Ryan Cui9b651632011-05-11 11:38:58 -07002049}
2050
2051
Mike Frysinger3554bc92015-03-11 04:59:21 -04002052def _get_override_hooks(config):
2053 """Returns a set of hooks controlled by the current project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07002054
2055 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08002056
2057 Args:
2058 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07002059 """
2060 SECTION = 'Hook Overrides'
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002061 SECTION_OPTIONS = 'Hook Overrides Options'
Ryan Cui9b651632011-05-11 11:38:58 -07002062
Mike Frysinger56e8de02019-07-31 14:40:14 -04002063 valid_keys = set(_HOOK_FLAGS.keys())
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002064 hooks = _HOOK_FLAGS.copy()
Mike Frysinger180ecd62020-08-19 00:41:51 -04002065 hook_overrides = set(
2066 config.options(SECTION) if config.has_section(SECTION) else [])
2067
2068 unknown_keys = hook_overrides - valid_keys
2069 if unknown_keys:
2070 raise ValueError(f'{_CONFIG_FILE}: [{SECTION}]: unknown keys: '
2071 f'{unknown_keys}')
Mike Frysinger3554bc92015-03-11 04:59:21 -04002072
2073 enable_flags = []
Ryan Cui9b651632011-05-11 11:38:58 -07002074 disable_flags = []
Mike Frysinger180ecd62020-08-19 00:41:51 -04002075 for flag in valid_keys:
2076 if flag in hook_overrides:
2077 try:
2078 enabled = config.getboolean(SECTION, flag)
2079 except ValueError as e:
2080 raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' %
2081 (flag, _CONFIG_FILE, e))
2082 elif hooks[flag] in _COMMON_HOOKS:
2083 # Enable common hooks by default so we process custom options below.
2084 enabled = True
2085 else:
2086 # All other hooks we left as a tristate. We use this below for a few
2087 # hooks to control default behavior.
2088 enabled = None
Mike Frysinger3554bc92015-03-11 04:59:21 -04002089
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002090 if enabled:
2091 enable_flags.append(flag)
Mike Frysinger180ecd62020-08-19 00:41:51 -04002092 elif enabled is not None:
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002093 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07002094
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002095 # See if this hook has custom options.
2096 if enabled:
2097 try:
2098 options = config.get(SECTION_OPTIONS, flag)
2099 hooks[flag] = functools.partial(hooks[flag], options=options.split())
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002100 hooks[flag].__name__ = flag
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04002101 except (configparser.NoOptionError, configparser.NoSectionError):
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002102 pass
2103
2104 enabled_hooks = set(hooks[x] for x in enable_flags)
2105 disabled_hooks = set(hooks[x] for x in disable_flags)
Mike Frysinger45334bd2019-11-04 10:42:33 -05002106
Mike Frysinger9ab64b12019-11-04 10:53:08 -05002107 if _check_change_has_signoff_field not in enabled_hooks:
Drew Davenport85848e52020-01-15 14:40:29 -07002108 if _check_change_has_signoff_field not in disabled_hooks:
2109 enabled_hooks.add(_check_change_has_no_signoff_field)
Mike Frysinger45334bd2019-11-04 10:42:33 -05002110 if _check_change_has_branch_field not in enabled_hooks:
2111 enabled_hooks.add(_check_change_has_no_branch_field)
2112
Mike Frysinger3554bc92015-03-11 04:59:21 -04002113 return enabled_hooks, disabled_hooks
Ryan Cui9b651632011-05-11 11:38:58 -07002114
2115
Jon Salz3ee59de2012-08-18 13:54:22 +08002116def _get_project_hook_scripts(config):
2117 """Returns a list of project-specific hook scripts.
2118
2119 Args:
2120 config: A ConfigParser for the project's config file.
2121 """
2122 SECTION = 'Hook Scripts'
2123 if not config.has_section(SECTION):
2124 return []
2125
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002126 return config.items(SECTION)
Jon Salz3ee59de2012-08-18 13:54:22 +08002127
2128
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002129def _get_project_hooks(project, presubmit, config_file=None):
Ryan Cui9b651632011-05-11 11:38:58 -07002130 """Returns a list of hooks that need to be run for a project.
2131
2132 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002133
2134 Args:
2135 project: A string, name of the project.
2136 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002137 config_file: A string, the config file. Defaults to _CONFIG_FILE.
Ryan Cui9b651632011-05-11 11:38:58 -07002138 """
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04002139 config = configparser.RawConfigParser()
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002140 if config_file is None:
2141 config_file = _CONFIG_FILE
2142 if not os.path.exists(config_file):
Jon Salz3ee59de2012-08-18 13:54:22 +08002143 # Just use an empty config file
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04002144 config = configparser.RawConfigParser()
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09002145 else:
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002146 config.read(config_file)
Jon Salz3ee59de2012-08-18 13:54:22 +08002147
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002148 if presubmit:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07002149 hooks = _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002150 else:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07002151 hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002152
Mike Frysinger3554bc92015-03-11 04:59:21 -04002153 enabled_hooks, disabled_hooks = _get_override_hooks(config)
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07002154 hooks = [hook for hook in hooks if hook not in disabled_hooks]
2155
2156 # If a list is both in _COMMON_HOOKS and also enabled explicitly through an
2157 # override, keep the override only. Note that the override may end up being
2158 # a functools.partial, in which case we need to extract the .func to compare
2159 # it to the common hooks.
2160 unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks]
2161 hooks = [hook for hook in hooks if hook not in unwrapped_hooks]
2162
2163 hooks = list(enabled_hooks) + hooks
Ryan Cui9b651632011-05-11 11:38:58 -07002164
2165 if project in _PROJECT_SPECIFIC_HOOKS:
Puneet Kumarc80e3f62012-08-13 19:01:18 -07002166 hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project]
2167 if hook not in disabled_hooks)
Ryan Cui9b651632011-05-11 11:38:58 -07002168
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002169 for name, script in _get_project_hook_scripts(config):
2170 func = functools.partial(_run_project_hook_script, script)
2171 func.__name__ = name
2172 hooks.append(func)
Jon Salz3ee59de2012-08-18 13:54:22 +08002173
Ryan Cui9b651632011-05-11 11:38:58 -07002174 return hooks
2175
2176
Alex Deymo643ac4c2015-09-03 10:40:50 -07002177def _run_project_hooks(project_name, proj_dir=None,
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002178 commit_list=None, presubmit=False,
2179 config_file=None):
Ryan Cui1562fb82011-05-09 11:01:31 -07002180 """For each project run its project specific hook from the hooks dictionary.
2181
2182 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002183 project_name: The name of project to run hooks for.
Doug Anderson44a644f2011-11-02 10:37:37 -07002184 proj_dir: If non-None, this is the directory the project is in. If None,
2185 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07002186 commit_list: A list of commits to run hooks against. If None or empty list
2187 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002188 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002189 config_file: A string, the presubmit config file. If not specified,
2190 defaults to PRESUBMIT.cfg in the project directory.
Ryan Cui1562fb82011-05-09 11:01:31 -07002191
2192 Returns:
2193 Boolean value of whether any errors were ecountered while running the hooks.
2194 """
Doug Anderson44a644f2011-11-02 10:37:37 -07002195 if proj_dir is None:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002196 proj_dirs = _run_command(
2197 ['repo', 'forall', project_name, '-c', 'pwd']).split()
Mike Frysingere52b1bc2019-09-16 23:45:41 -04002198 if not proj_dirs:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002199 print('%s cannot be found.' % project_name, file=sys.stderr)
David James2edd9002013-10-11 14:09:19 -07002200 print('Please specify a valid project.', file=sys.stderr)
2201 return True
2202 if len(proj_dirs) > 1:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002203 print('%s is associated with multiple directories.' % project_name,
David James2edd9002013-10-11 14:09:19 -07002204 file=sys.stderr)
2205 print('Please specify a directory to help disambiguate.', file=sys.stderr)
2206 return True
2207 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07002208
Ryan Cuiec4d6332011-05-02 14:15:25 -07002209 pwd = os.getcwd()
2210 # hooks assume they are run from the root of the project
2211 os.chdir(proj_dir)
2212
Mike Frysingered1b95a2019-12-12 19:04:51 -05002213 color = terminal.Color()
2214
Alex Deymo643ac4c2015-09-03 10:40:50 -07002215 remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref',
2216 '--symbolic-full-name', '@{u}']).strip()
2217 if not remote_branch:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002218 print("Your project %s doesn't track any remote repo." % project_name,
Alex Deymo643ac4c2015-09-03 10:40:50 -07002219 file=sys.stderr)
2220 remote = None
2221 else:
Josh Pratt15d13ab2018-08-13 11:52:48 +10002222 branch_items = remote_branch.split('/', 1)
2223 if len(branch_items) != 2:
2224 PrintErrorForProject(
2225 project_name,
2226 HookFailure(
2227 'Cannot get remote and branch name (%s)' % remote_branch))
2228 os.chdir(pwd)
2229 return True
2230 remote, _branch = branch_items
Alex Deymo643ac4c2015-09-03 10:40:50 -07002231
2232 project = Project(name=project_name, dir=proj_dir, remote=remote)
2233
Doug Anderson14749562013-06-26 13:38:29 -07002234 if not commit_list:
2235 try:
2236 commit_list = _get_commits()
2237 except VerifyException as e:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002238 PrintErrorForProject(project.name, HookFailure(str(e)))
Doug Anderson14749562013-06-26 13:38:29 -07002239 os.chdir(pwd)
2240 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07002241
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002242 hooks = _get_project_hooks(project.name, presubmit, config_file)
Ryan Cui1562fb82011-05-09 11:01:31 -07002243 error_found = False
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002244 commit_count = len(commit_list)
Mike Frysingerb99b3772019-08-17 14:19:44 -04002245 hook_count = len(hooks)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002246 for i, commit in enumerate(commit_list):
Mike Frysingerb2496652019-09-12 23:35:46 -04002247 CACHE.clear()
2248
LaMont Jones69d3e182020-03-11 15:00:53 -06002249 # If run with --pre-submit, then commit is PRE_SUBMIT, and not a commit.
2250 # Use that as the description.
2251 desc = commit if commit == PRE_SUBMIT else _get_commit_desc(commit)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002252 print('[%s %i/%i %s] %s' %
2253 (color.Color(color.CYAN, 'COMMIT'), i + 1, commit_count, commit[0:12],
2254 desc.splitlines()[0]))
2255
Mike Frysingerb99b3772019-08-17 14:19:44 -04002256 for h, hook in enumerate(hooks):
Mike Frysingered1b95a2019-12-12 19:04:51 -05002257 output = ('[%s %i/%i PRESUBMIT.cfg] %s' %
2258 (color.Color(color.YELLOW, 'RUNNING'), h + 1, hook_count,
2259 hook.__name__))
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002260 print(output, end='\r')
2261 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002262 hook_error = hook(project, commit)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002263 print(' ' * len(output), end='\r')
2264 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002265 if hook_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002266 if not isinstance(hook_error, list):
2267 hook_error = [hook_error]
2268 PrintErrorsForCommit(color, hook, project.name, hook_error)
Ryan Cui1562fb82011-05-09 11:01:31 -07002269 error_found = True
Don Garrettdba548a2011-05-05 15:17:14 -07002270
Ryan Cuiec4d6332011-05-02 14:15:25 -07002271 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07002272 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002273
Mike Frysingerae409522014-02-01 03:16:11 -05002274
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002275# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002276
Ryan Cui1562fb82011-05-09 11:01:31 -07002277
Mike Frysingerae409522014-02-01 03:16:11 -05002278def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08002279 """Main function invoked directly by repo.
2280
2281 This function will exit directly upon error so that repo doesn't print some
2282 obscure error message.
2283
2284 Args:
2285 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07002286 worktree_list: A list of directories. It should be the same length as
2287 project_list, so that each entry in project_list matches with a directory
2288 in worktree_list. If None, we will attempt to calculate the directories
2289 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08002290 kwargs: Leave this here for forward-compatibility.
2291 """
Mike Frysingered1b95a2019-12-12 19:04:51 -05002292 start_time = datetime.datetime.now()
Ryan Cui1562fb82011-05-09 11:01:31 -07002293 found_error = False
David James2edd9002013-10-11 14:09:19 -07002294 if not worktree_list:
2295 worktree_list = [None] * len(project_list)
2296 for project, worktree in zip(project_list, worktree_list):
2297 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07002298 found_error = True
2299
Mike Frysingered1b95a2019-12-12 19:04:51 -05002300 end_time = datetime.datetime.now()
2301 color = terminal.Color()
Mike Frysingerae409522014-02-01 03:16:11 -05002302 if found_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002303 msg = ('%s: Preupload failed due to above error(s).\n'
Ryan Cui9b651632011-05-11 11:38:58 -07002304 '- To disable some source style checks, and for other hints, see '
Mike Frysingered1b95a2019-12-12 19:04:51 -05002305 '<checkout_dir>/src/repohooks/README.md\n'
2306 "- To upload only current project, run 'repo upload .'" %
2307 (color.Color(color.RED, 'FATAL'),))
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04002308 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07002309 sys.exit(1)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002310 else:
2311 msg = ('[%s] repohooks passed in %s' %
2312 (color.Color(color.GREEN, 'PASSED'), end_time - start_time))
2313 print(msg)
Anush Elangovan63afad72011-03-23 00:41:27 -07002314
Ryan Cui1562fb82011-05-09 11:01:31 -07002315
Doug Anderson44a644f2011-11-02 10:37:37 -07002316def _identify_project(path):
2317 """Identify the repo project associated with the given path.
2318
2319 Returns:
2320 A string indicating what project is associated with the path passed in or
2321 a blank string upon failure.
2322 """
2323 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002324 stderr=True, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002325
2326
Mike Frysinger55f85b52014-12-18 14:45:21 -05002327def direct_main(argv):
Doug Anderson44a644f2011-11-02 10:37:37 -07002328 """Run hooks directly (outside of the context of repo).
2329
Doug Anderson44a644f2011-11-02 10:37:37 -07002330 Args:
Mike Frysinger55f85b52014-12-18 14:45:21 -05002331 argv: The command line args to process
Doug Anderson44a644f2011-11-02 10:37:37 -07002332
2333 Returns:
2334 0 if no pre-upload failures, 1 if failures.
2335
2336 Raises:
2337 BadInvocation: On some types of invocation errors.
2338 """
Mike Frysinger66142932014-12-18 14:55:57 -05002339 parser = commandline.ArgumentParser(description=__doc__)
2340 parser.add_argument('--dir', default=None,
2341 help='The directory that the project lives in. If not '
2342 'specified, use the git project root based on the cwd.')
2343 parser.add_argument('--project', default=None,
2344 help='The project repo path; this can affect how the '
2345 'hooks get run, since some hooks are project-specific. '
2346 'For chromite this is chromiumos/chromite. If not '
2347 'specified, the repo tool will be used to figure this '
2348 'out based on the dir.')
2349 parser.add_argument('--rerun-since', default=None,
Vadim Bendebury75447b92018-01-10 12:06:01 -08002350 help='Rerun hooks on old commits since some point '
2351 'in the past. The argument could be a date (should '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002352 "match git log's concept of a date, e.g. 2012-06-20), "
Vadim Bendebury75447b92018-01-10 12:06:01 -08002353 'or a SHA1, or just a number of commits to check (from 1 '
2354 'to 99). This option is mutually exclusive with '
2355 '--pre-submit.')
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002356 parser.add_argument('--pre-submit', action='store_true',
Mike Frysinger66142932014-12-18 14:55:57 -05002357 help='Run the check against the pending commit. '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002358 "This option should be used at the 'git commit' "
2359 "phase as opposed to 'repo upload'. This option "
Mike Frysinger66142932014-12-18 14:55:57 -05002360 'is mutually exclusive with --rerun-since.')
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002361 parser.add_argument('--presubmit-config',
2362 help='Specify presubmit config file to be used.')
Mike Frysinger66142932014-12-18 14:55:57 -05002363 parser.add_argument('commits', nargs='*',
2364 help='Check specific commits')
2365 opts = parser.parse_args(argv)
Doug Anderson44a644f2011-11-02 10:37:37 -07002366
Doug Anderson14749562013-06-26 13:38:29 -07002367 if opts.rerun_since:
Mike Frysinger66142932014-12-18 14:55:57 -05002368 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002369 raise BadInvocation("Can't pass commits and use rerun-since: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002370 ' '.join(opts.commits))
Doug Anderson14749562013-06-26 13:38:29 -07002371
Vadim Bendebury75447b92018-01-10 12:06:01 -08002372 if len(opts.rerun_since) < 3 and opts.rerun_since.isdigit():
2373 # This must be the number of commits to check. We don't expect the user
2374 # to want to check more than 99 commits.
2375 limit = '-n%s' % opts.rerun_since
2376 elif git.IsSHA1(opts.rerun_since, False):
2377 limit = '%s..' % opts.rerun_since
2378 else:
2379 # This better be a date.
2380 limit = '--since=%s' % opts.rerun_since
2381 cmd = ['git', 'log', limit, '--pretty=%H']
Doug Anderson14749562013-06-26 13:38:29 -07002382 all_commits = _run_command(cmd).splitlines()
2383 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
2384
2385 # Eliminate chrome-bot commits but keep ordering the same...
2386 bot_commits = set(bot_commits)
Mike Frysinger66142932014-12-18 14:55:57 -05002387 opts.commits = [c for c in all_commits if c not in bot_commits]
Doug Anderson14749562013-06-26 13:38:29 -07002388
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002389 if opts.pre_submit:
2390 raise BadInvocation('rerun-since and pre-submit can not be '
2391 'used together')
2392 if opts.pre_submit:
Mike Frysinger66142932014-12-18 14:55:57 -05002393 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002394 raise BadInvocation("Can't pass commits and use pre-submit: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002395 ' '.join(opts.commits))
2396 opts.commits = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07002397
2398 # Check/normlaize git dir; if unspecified, we'll use the root of the git
2399 # project from CWD
2400 if opts.dir is None:
2401 git_dir = _run_command(['git', 'rev-parse', '--git-dir'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002402 stderr=True).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002403 if not git_dir:
2404 raise BadInvocation('The current directory is not part of a git project.')
2405 opts.dir = os.path.dirname(os.path.abspath(git_dir))
2406 elif not os.path.isdir(opts.dir):
2407 raise BadInvocation('Invalid dir: %s' % opts.dir)
2408 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
2409 raise BadInvocation('Not a git directory: %s' % opts.dir)
2410
2411 # Identify the project if it wasn't specified; this _requires_ the repo
2412 # tool to be installed and for the project to be part of a repo checkout.
2413 if not opts.project:
2414 opts.project = _identify_project(opts.dir)
2415 if not opts.project:
2416 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
2417
Doug Anderson14749562013-06-26 13:38:29 -07002418 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Mike Frysinger66142932014-12-18 14:55:57 -05002419 commit_list=opts.commits,
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002420 presubmit=opts.pre_submit,
2421 config_file=opts.presubmit_config)
Doug Anderson44a644f2011-11-02 10:37:37 -07002422 if found_error:
2423 return 1
2424 return 0
2425
2426
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002427if __name__ == '__main__':
Mike Frysinger55f85b52014-12-18 14:45:21 -05002428 sys.exit(direct_main(sys.argv[1:]))