blob: 4220d1441172ad1514d0294c37dd6a7c8280ad99 [file] [log] [blame]
Mike Frysinger4f994402019-09-13 17:40:45 -04001#!/usr/bin/env python3
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002# -*- coding: utf-8 -*-
Jon Salz98255932012-08-18 14:48:02 +08003# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
Mike Frysingerae409522014-02-01 03:16:11 -05007"""Presubmit checks to run when doing `repo upload`.
8
9You can add new checks by adding a functions to the HOOKS constants.
10"""
11
Mike Frysinger09d6a3d2013-10-08 22:21:03 -040012from __future__ import print_function
13
Keigo Okadd908822019-06-04 11:30:25 +090014import argparse
Alex Deymo643ac4c2015-09-03 10:40:50 -070015import collections
Mike Frysingerf252cfc2019-12-09 17:34:28 -050016import configparser
Keigo Oka7e880ac2019-07-03 15:03:43 +090017import datetime
Daniel Erate3ea3fc2015-02-13 15:27:52 -070018import fnmatch
Jon Salz3ee59de2012-08-18 13:54:22 +080019import functools
Dale Curtis2975c432011-05-03 17:25:20 -070020import json
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070021import os
Ryan Cuiec4d6332011-05-02 14:15:25 -070022import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070023import sys
Peter Ammon811f6702014-06-12 15:45:38 -070024import stat
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -050025import subprocess
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070026
Ryan Cui1562fb82011-05-09 11:01:31 -070027from errors import (VerifyException, HookFailure, PrintErrorForProject,
28 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070029
Mike Frysinger919c7032019-09-13 17:48:08 -040030if __name__ in ('__builtin__', 'builtins'):
Mike Frysinger653cd262019-09-20 14:05:02 -040031 # If repo imports us, the __name__ will be __builtin__, and the cwd will be in
32 # the top level of the checkout (i.e. $CHROMEOS_CHECKOUT). chromite will be
33 # in that directory, so add it to our path. This works whether we're running
34 # the repo in $CHROMEOS_CHECKOUT/.repo/repo/ or a custom version in a
35 # completely different tree.
36 # TODO(vapier): Python 2 used "__builtin__" while Python 3 uses "builtins".
Mike Frysinger6850d512018-05-21 12:12:14 -040037 sys.path.insert(0, os.getcwd())
38
Mike Frysinger653cd262019-09-20 14:05:02 -040039elif __name__ == '__main__':
40 # If we're run directly, we'll find chromite relative to the repohooks dir in
41 # $CHROMEOS_CHECKOUT/src/repohooks, so go up two dirs.
David Jamesc3b68b32013-04-03 09:17:03 -070042 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
43
Mike Frysingerfd481ce2019-09-13 18:14:48 -040044# The sys.path monkey patching confuses the linter.
45# pylint: disable=wrong-import-position
Mike Frysinger66142932014-12-18 14:55:57 -050046from chromite.lib import commandline
Rahul Chaudhry0e515342015-08-07 12:00:43 -070047from chromite.lib import cros_build_lib
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050048from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070049from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070050from chromite.lib import patch
Mike Frysingered1b95a2019-12-12 19:04:51 -050051from chromite.lib import terminal
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040052from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070053
Vadim Bendebury2b62d742014-06-22 13:14:51 -070054PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070055
Mike Frysingered9b2a02019-12-12 18:52:32 -050056
57# Link to commit message documentation for users.
58DOC_COMMIT_MSG_URL = ('https://chromium.googlesource.com/chromiumos/docs/+/HEAD'
59 '/contributing.md#commit-messages')
60
61
Ryan Cuiec4d6332011-05-02 14:15:25 -070062COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050063 # C++ and friends
Mike Frysinger24dd3c52019-08-17 14:22:48 -040064 r'.*\.c$', r'.*\.cc$', r'.*\.cpp$', r'.*\.h$', r'.*\.m$', r'.*\.mm$',
65 r'.*\.inl$', r'.*\.asm$', r'.*\.hxx$', r'.*\.hpp$', r'.*\.s$', r'.*\.S$',
Mike Frysingerae409522014-02-01 03:16:11 -050066 # Scripts
Mike Frysinger24dd3c52019-08-17 14:22:48 -040067 r'.*\.js$', r'.*\.py$', r'.*\.sh$', r'.*\.rb$', r'.*\.pl$', r'.*\.pm$',
Mike Frysingerae409522014-02-01 03:16:11 -050068 # No extension at all, note that ALL CAPS files are black listed in
69 # COMMON_EXCLUDED_LIST below.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040070 r'(^|.*[\\\/])[^.]+$',
Mike Frysingerae409522014-02-01 03:16:11 -050071 # Other
Mike Frysinger24dd3c52019-08-17 14:22:48 -040072 r'.*\.java$', r'.*\.mk$', r'.*\.am$',
73 r'.*\.policy$', r'.*\.conf$', r'.*\.go$',
74 r'(^OWNERS|/OWNERS)',
Ryan Cuiec4d6332011-05-02 14:15:25 -070075]
76
Ryan Cui1562fb82011-05-09 11:01:31 -070077
Ryan Cuiec4d6332011-05-02 14:15:25 -070078COMMON_EXCLUDED_PATHS = [
Daniel Erate3ea3fc2015-02-13 15:27:52 -070079 # For ebuild trees, ignore any caches and manifest data.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040080 r'.*/Manifest$',
81 r'.*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$',
Doug Anderson5bfb6792011-10-25 16:45:41 -070082
Daniel Erate3ea3fc2015-02-13 15:27:52 -070083 # Ignore profiles data (like overlay-tegra2/profiles).
Mike Frysinger24dd3c52019-08-17 14:22:48 -040084 r'(^|.*/)overlay-.*/profiles/.*',
85 r'^profiles/.*$',
Mike Frysinger98638102014-08-28 00:15:08 -040086
C Shapiro8f90e9b2017-06-28 09:54:50 -060087 # Ignore config files in ebuild setup.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040088 r'(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*',
89 r'^chromeos-base/chromeos-bsp.*/files/.*',
C Shapiro8f90e9b2017-06-28 09:54:50 -060090
Daniel Erate3ea3fc2015-02-13 15:27:52 -070091 # Ignore minified js and jquery.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040092 r'.*\.min\.js',
93 r'.*jquery.*\.js',
Mike Frysinger33a458d2014-03-03 17:00:51 -050094
95 # Ignore license files as the content is often taken verbatim.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040096 r'.*/licenses/.*',
Alex Klein619c0912019-01-30 17:13:23 -070097
Mike Frysinger13650402019-07-31 14:31:46 -040098 # Exclude generated protobuf bindings.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040099 r'.*_pb2\.py$',
100 r'.*\.pb\.go$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700101]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700102
Ken Turnerd07564b2018-02-08 17:57:59 +1100103LICENSE_EXCLUDED_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400104 r'^(.*/)?OWNERS$',
Ken Turnerd07564b2018-02-08 17:57:59 +1100105]
Ryan Cui1562fb82011-05-09 11:01:31 -0700106
Ryan Cui9b651632011-05-11 11:38:58 -0700107_CONFIG_FILE = 'PRESUBMIT.cfg'
108
109
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700110# File containing wildcards, one per line, matching files that should be
111# excluded from presubmit checks. Lines beginning with '#' are ignored.
112_IGNORE_FILE = '.presubmitignore'
113
Cheng Yuehb707c522020-01-02 14:06:59 +0800114
115TEST_FIELD_RE = r'\nTEST=\S+'
116
Doug Anderson44a644f2011-11-02 10:37:37 -0700117# Exceptions
118
119
120class BadInvocation(Exception):
121 """An Exception indicating a bad invocation of the program."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700122
123
Ryan Cui1562fb82011-05-09 11:01:31 -0700124# General Helpers
125
Sean Paulba01d402011-05-05 11:36:23 -0400126
Mike Frysingerb2496652019-09-12 23:35:46 -0400127class Cache(object):
128 """General helper for caching git content."""
129
130 def __init__(self):
131 self._cache = {}
132
133 def get_subcache(self, scope):
134 return self._cache.setdefault(scope, {})
135
136 def clear(self):
137 self._cache.clear()
138
139CACHE = Cache()
140
141
Alex Deymo643ac4c2015-09-03 10:40:50 -0700142Project = collections.namedtuple('Project', ['name', 'dir', 'remote'])
143
144
Mike Frysinger526a5f82019-09-13 18:05:30 -0400145def _run_command(cmd, **kwargs):
Doug Anderson44a644f2011-11-02 10:37:37 -0700146 """Executes the passed in command and returns raw stdout output.
147
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400148 This is a convenience func to set some run defaults differently.
Mike Frysinger526a5f82019-09-13 18:05:30 -0400149
Doug Anderson44a644f2011-11-02 10:37:37 -0700150 Args:
151 cmd: The command to run; should be a list of strings.
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400152 **kwargs: Same as cros_build_lib.run.
Doug Anderson44a644f2011-11-02 10:37:37 -0700153
154 Returns:
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700155 The stdout from the process (discards stderr and returncode).
Doug Anderson44a644f2011-11-02 10:37:37 -0700156 """
Mike Frysinger526a5f82019-09-13 18:05:30 -0400157 kwargs.setdefault('print_cmd', False)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400158 kwargs.setdefault('stdout', True)
159 kwargs.setdefault('check', False)
Mike Frysinger054c1592019-11-18 03:51:54 -0500160 result = cros_build_lib.run(cmd, **kwargs)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400161 # NB: We decode this directly rather than through kwargs as our tests rely
162 # on this post-processing behavior currently.
Mike Frysinger71e643e2019-09-13 17:26:39 -0400163 return result.output.decode('utf-8', 'replace')
Ryan Cui72834d12011-05-05 14:51:33 -0700164
Ryan Cui1562fb82011-05-09 11:01:31 -0700165
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700166def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700167 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700168 if __name__ == '__main__':
169 # Works when file is run on its own (__file__ is defined)...
170 return os.path.abspath(os.path.dirname(__file__))
171 else:
172 # We need to do this when we're run through repo. Since repo executes
173 # us with execfile(), we don't get __file__ defined.
174 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
175 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700176
Ryan Cui1562fb82011-05-09 11:01:31 -0700177
Ryan Cuiec4d6332011-05-02 14:15:25 -0700178def _match_regex_list(subject, expressions):
179 """Try to match a list of regular expressions to a string.
180
181 Args:
182 subject: The string to match regexes on
183 expressions: A list of regular expressions to check for matches with.
184
185 Returns:
186 Whether the passed in subject matches any of the passed in regexes.
187 """
188 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500189 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700190 return True
191 return False
192
Ryan Cui1562fb82011-05-09 11:01:31 -0700193
Mike Frysingerae409522014-02-01 03:16:11 -0500194def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700195 """Filter out files based on the conditions passed in.
196
197 Args:
198 files: list of filepaths to filter
199 include_list: list of regex that when matched with a file path will cause it
200 to be added to the output list unless the file is also matched with a
201 regex in the exclude_list.
202 exclude_list: list of regex that when matched with a file will prevent it
203 from being added to the output list, even if it is also matched with a
204 regex in the include_list.
205
206 Returns:
207 A list of filepaths that contain files matched in the include_list and not
208 in the exclude_list.
209 """
210 filtered = []
211 for f in files:
212 if (_match_regex_list(f, include_list) and
213 not _match_regex_list(f, exclude_list)):
214 filtered.append(f)
215 return filtered
216
Ryan Cuiec4d6332011-05-02 14:15:25 -0700217
218# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700219
220
Ryan Cui4725d952011-05-05 15:41:19 -0700221def _get_upstream_branch():
222 """Returns the upstream tracking branch of the current branch.
223
224 Raises:
225 Error if there is no tracking branch
226 """
227 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
228 current_branch = current_branch.replace('refs/heads/', '')
229 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700230 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700231
232 cfg_option = 'branch.' + current_branch + '.%s'
233 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
234 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
235 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700236 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700237
238 return full_upstream.replace('heads', 'remotes/' + remote)
239
Ryan Cui1562fb82011-05-09 11:01:31 -0700240
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700241def _get_patch(commit):
242 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700243 if commit == PRE_SUBMIT:
244 return _run_command(['git', 'diff', '--cached', 'HEAD'])
245 else:
246 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700247
Ryan Cui1562fb82011-05-09 11:01:31 -0700248
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500249def _get_file_content(path, commit):
250 """Returns the content of a file at a specific commit.
251
252 We can't rely on the file as it exists in the filesystem as people might be
253 uploading a series of changes which modifies the file multiple times.
254
255 Note: The "content" of a symlink is just the target. So if you're expecting
256 a full file, you should check that first. One way to detect is that the
257 content will not have any newlines.
258 """
Mike Frysingerb2496652019-09-12 23:35:46 -0400259 # Make sure people don't accidentally pass in full paths which will never
260 # work. You need to use relative=True with _get_affected_files.
261 if path.startswith('/'):
262 raise ValueError('_get_file_content must be called with relative paths: %s'
263 % (path,))
264
265 # {<commit>: {<path1>: <content>, <path2>: <content>}}
266 cache = CACHE.get_subcache('get_file_content')
267 if path in cache:
268 return cache[path]
269
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700270 if commit == PRE_SUBMIT:
Mike Frysingerb2496652019-09-12 23:35:46 -0400271 content = _run_command(['git', 'diff', 'HEAD', path])
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700272 else:
Mike Frysingerb2496652019-09-12 23:35:46 -0400273 content = _run_command(['git', 'show', '%s:%s' % (commit, path)])
274 cache[path] = content
275 return content
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500276
277
Mike Frysingerae409522014-02-01 03:16:11 -0500278def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700279 """Returns a list of (linenum, lines) tuples that the commit touched."""
Mike Frysingerb2496652019-09-12 23:35:46 -0400280 # {<commit>: {<path1>: <content>, <path2>: <content>}}
281 cache = CACHE.get_subcache('get_file_diff')
282 if path in cache:
283 return cache[path]
284
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700285 if commit == PRE_SUBMIT:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800286 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD',
287 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700288 else:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800289 command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit,
290 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700291 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700292
293 new_lines = []
294 line_num = 0
295 for line in output.splitlines():
296 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
297 if m:
298 line_num = int(m.groups(1)[0])
299 continue
300 if line.startswith('+') and not line.startswith('++'):
Mike Frysinger71e643e2019-09-13 17:26:39 -0400301 new_lines.append((line_num, line[1:]))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700302 if not line.startswith('-'):
303 line_num += 1
Mike Frysingerb2496652019-09-12 23:35:46 -0400304 cache[path] = new_lines
Ryan Cuiec4d6332011-05-02 14:15:25 -0700305 return new_lines
306
Ryan Cui1562fb82011-05-09 11:01:31 -0700307
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700308def _get_ignore_wildcards(directory, cache):
309 """Get wildcards listed in a directory's _IGNORE_FILE.
310
311 Args:
312 directory: A string containing a directory path.
313 cache: A dictionary (opaque to caller) caching previously-read wildcards.
314
315 Returns:
316 A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE
317 wasn't present.
318 """
319 # In the cache, keys are directories and values are lists of wildcards from
320 # _IGNORE_FILE within those directories (and empty if no file was present).
321 if directory not in cache:
322 wildcards = []
323 dotfile_path = os.path.join(directory, _IGNORE_FILE)
324 if os.path.exists(dotfile_path):
325 # TODO(derat): Consider using _get_file_content() to get the file as of
326 # this commit instead of the on-disk version. This may have a noticeable
327 # performance impact, as each call to _get_file_content() runs git.
328 with open(dotfile_path, 'r') as dotfile:
329 for line in dotfile.readlines():
330 line = line.strip()
331 if line.startswith('#'):
332 continue
333 if line.endswith('/'):
334 line += '*'
335 wildcards.append(line)
336 cache[directory] = wildcards
337
338 return cache[directory]
339
340
341def _path_is_ignored(path, cache):
342 """Check whether a path is ignored by _IGNORE_FILE.
343
344 Args:
345 path: A string containing a path.
346 cache: A dictionary (opaque to caller) caching previously-read wildcards.
347
348 Returns:
349 True if a file named _IGNORE_FILE in one of the passed-in path's parent
350 directories contains a wildcard matching the path.
351 """
352 # Skip ignore files.
353 if os.path.basename(path) == _IGNORE_FILE:
354 return True
355
356 path = os.path.abspath(path)
357 base = os.getcwd()
358
359 prefix = os.path.dirname(path)
360 while prefix.startswith(base):
361 rel_path = path[len(prefix) + 1:]
362 for wildcard in _get_ignore_wildcards(prefix, cache):
363 if fnmatch.fnmatch(rel_path, wildcard):
364 return True
365 prefix = os.path.dirname(prefix)
366
367 return False
368
369
Mike Frysinger292b45d2014-11-25 01:17:10 -0500370def _get_affected_files(commit, include_deletes=False, relative=False,
371 include_symlinks=False, include_adds=True,
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700372 full_details=False, use_ignore_files=True):
Peter Ammon811f6702014-06-12 15:45:38 -0700373 """Returns list of file paths that were modified/added, excluding symlinks.
374
375 Args:
376 commit: The commit
377 include_deletes: If true, we'll include deleted files in the result
378 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500379 include_symlinks: If true, we'll include symlinks in the result
380 include_adds: If true, we'll include new files in the result
381 full_details: If False, return filenames, else return structured results.
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700382 use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files.
Peter Ammon811f6702014-06-12 15:45:38 -0700383
384 Returns:
385 A list of modified/added (and perhaps deleted) files
386 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500387 if not relative and full_details:
388 raise ValueError('full_details only supports relative paths currently')
389
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700390 if commit == PRE_SUBMIT:
391 return _run_command(['git', 'diff-index', '--cached',
392 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500393
394 path = os.getcwd()
Mike Frysingerb2496652019-09-12 23:35:46 -0400395 # {<commit>: {<path1>: <content>, <path2>: <content>}}
396 cache = CACHE.get_subcache('get_affected_files')
397 if path not in cache:
398 cache[path] = git.RawDiff(path, '%s^!' % commit)
399 files = cache[path]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500400
401 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500402 if not include_symlinks:
403 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500404
405 if not include_deletes:
406 files = [x for x in files if x.status != 'D']
407
Mike Frysinger292b45d2014-11-25 01:17:10 -0500408 if not include_adds:
409 files = [x for x in files if x.status != 'A']
410
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700411 if use_ignore_files:
412 cache = {}
413 is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache)
414 files = [x for x in files if not is_ignored(x)]
415
Mike Frysinger292b45d2014-11-25 01:17:10 -0500416 if full_details:
417 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500418 return files
419 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500420 # Caller only cares about filenames.
421 files = [x.dst_file if x.dst_file else x.src_file for x in files]
422 if relative:
423 return files
424 else:
425 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700426
427
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700428def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700429 """Returns a list of commits for this review."""
Mike Frysingere300c7d2019-09-12 23:33:52 -0400430 cmd = ['git', 'log', '--no-merges', '--format=%H',
431 '%s..' % _get_upstream_branch()]
Ryan Cui72834d12011-05-05 14:51:33 -0700432 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700433
Ryan Cui1562fb82011-05-09 11:01:31 -0700434
Ryan Cuiec4d6332011-05-02 14:15:25 -0700435def _get_commit_desc(commit):
436 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700437 if commit == PRE_SUBMIT:
438 return ''
Mike Frysingerb2496652019-09-12 23:35:46 -0400439
440 # {<commit>: <content>}
441 cache = CACHE.get_subcache('get_commit_desc')
442 if commit not in cache:
Mike Frysinger4efdee72019-11-04 10:57:01 -0500443 cache[commit] = _run_command(['git', 'log', '--format=%B',
Mike Frysingerb2496652019-09-12 23:35:46 -0400444 commit + '^!'])
445 return cache[commit]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700446
447
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800448def _check_lines_in_diff(commit, files, check_callable, error_description):
449 """Checks given file for errors via the given check.
450
451 This is a convenience function for common per-line checks. It goes through all
452 files and returns a HookFailure with the error description listing all the
453 failures.
454
455 Args:
456 commit: The commit we're working on.
457 files: The files to check.
458 check_callable: A callable that takes a line and returns True if this line
459 _fails_ the check.
460 error_description: A string describing the error.
461 """
462 errors = []
463 for afile in files:
464 for line_num, line in _get_file_diff(afile, commit):
465 if check_callable(line):
466 errors.append('%s, line %s' % (afile, line_num))
467 if errors:
468 return HookFailure(error_description, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400469 return None
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800470
471
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900472def _parse_common_inclusion_options(options):
473 """Parses common hook options for including/excluding files.
474
475 Args:
476 options: Option string list.
477
478 Returns:
479 (included, excluded) where each one is a list of regex strings.
480 """
481 parser = argparse.ArgumentParser()
482 parser.add_argument('--exclude_regex', action='append')
483 parser.add_argument('--include_regex', action='append')
484 opts = parser.parse_args(options)
485 included = opts.include_regex or []
486 excluded = opts.exclude_regex or []
487 return included, excluded
488
489
Ryan Cuiec4d6332011-05-02 14:15:25 -0700490# Common Hooks
491
Ryan Cui1562fb82011-05-09 11:01:31 -0700492
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900493def _check_no_long_lines(_project, commit, options=()):
Mike Frysinger55f85b52014-12-18 14:45:21 -0500494 """Checks there are no lines longer than MAX_LEN in any of the text files."""
Keigo Oka9732e382019-06-28 17:44:59 +0900495 LONG_LINE_OK_PATHS = [
496 # Go has no line length limit.
497 # https://golang.org/doc/effective_go.html#formatting
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400498 r'.*\.go$',
Keigo Oka9732e382019-06-28 17:44:59 +0900499 ]
Mike Frysinger55f85b52014-12-18 14:45:21 -0500500
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900501 DEFAULT_MAX_LENGTHS = [
502 # Java's line length limit is 100 chars.
503 # https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md
504 (r'.*\.java$', 100),
505 ]
506
Ryan Cuiec4d6332011-05-02 14:15:25 -0700507 MAX_LEN = 80
508
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900509 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700510 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900511 included + COMMON_INCLUDED_PATHS,
Keigo Oka9732e382019-06-28 17:44:59 +0900512 excluded + COMMON_EXCLUDED_PATHS + LONG_LINE_OK_PATHS)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700513
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900514 errors = []
Ryan Cuiec4d6332011-05-02 14:15:25 -0700515 for afile in files:
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700516 skip_regexps = (
517 r'https?://',
518 r'^#\s*(define|include|import|pragma|if|ifndef|endif)\b',
519 )
520
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900521 max_len = MAX_LEN
522
523 for expr, length in DEFAULT_MAX_LENGTHS:
524 if re.search(expr, afile):
525 max_len = length
526 break
527
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700528 if os.path.basename(afile).startswith('OWNERS'):
529 # File paths can get long, and there's no way to break them up into
530 # multiple lines.
531 skip_regexps += (
532 r'^include\b',
533 r'file:',
534 )
535
536 skip_regexps = [re.compile(x) for x in skip_regexps]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700537 for line_num, line in _get_file_diff(afile, commit):
538 # Allow certain lines to exceed the maxlen rule.
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900539 if len(line) <= max_len or any(x.search(line) for x in skip_regexps):
Jon Salz98255932012-08-18 14:48:02 +0800540 continue
541
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900542 errors.append('%s, line %s, %s chars, over %s chars' %
543 (afile, line_num, len(line), max_len))
Jon Salz98255932012-08-18 14:48:02 +0800544 if len(errors) == 5: # Just show the first 5 errors.
545 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700546
547 if errors:
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900548 msg = 'Found lines longer than the limit (first 5 shown):'
Ryan Cui1562fb82011-05-09 11:01:31 -0700549 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400550 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700551
Ryan Cuiec4d6332011-05-02 14:15:25 -0700552
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900553def _check_no_stray_whitespace(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700554 """Checks that there is no stray whitespace at source lines end."""
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900555 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700556 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900557 included + COMMON_INCLUDED_PATHS,
558 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800559 return _check_lines_in_diff(commit, files,
560 lambda line: line.rstrip() != line,
561 'Found line ending with white space in:')
Ryan Cui1562fb82011-05-09 11:01:31 -0700562
Ryan Cuiec4d6332011-05-02 14:15:25 -0700563
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900564def _check_no_tabs(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700565 """Checks there are no unexpanded tabs."""
Mike Frysingercd134512017-10-26 04:36:33 -0400566 # Don't add entire repos here. Update the PRESUBMIT.cfg in each repo instead.
567 # We only whitelist known specific filetypes here that show up in all repos.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700568 TAB_OK_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400569 r'.*\.ebuild$',
570 r'.*\.eclass$',
571 r'.*\.go$',
572 r'.*/[M|m]akefile$',
573 r'.*\.mk$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700574 ]
575
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900576 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700577 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900578 included + COMMON_INCLUDED_PATHS,
579 excluded + COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800580 return _check_lines_in_diff(commit, files,
581 lambda line: '\t' in line,
582 'Found a tab character in:')
Ryan Cuiec4d6332011-05-02 14:15:25 -0700583
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800584
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900585def _check_tabbed_indents(_project, commit, options=()):
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800586 """Checks that indents use tabs only."""
587 TABS_REQUIRED_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400588 r'.*\.ebuild$',
589 r'.*\.eclass$',
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800590 ]
591 LEADING_SPACE_RE = re.compile('[\t]* ')
592
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900593 included, excluded = _parse_common_inclusion_options(options)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800594 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900595 included + TABS_REQUIRED_PATHS,
596 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800597 return _check_lines_in_diff(
598 commit, files,
599 lambda line: LEADING_SPACE_RE.match(line) is not None,
600 'Found a space in indentation (must be all tabs):')
Ryan Cui1562fb82011-05-09 11:01:31 -0700601
Ryan Cuiec4d6332011-05-02 14:15:25 -0700602
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700603def _check_gofmt(_project, commit):
604 """Checks that Go files are formatted with gofmt."""
605 errors = []
606 files = _filter_files(_get_affected_files(commit, relative=True),
607 [r'\.go$'])
608
609 for gofile in files:
610 contents = _get_file_content(gofile, commit)
Mike Frysingeraa7dc942019-09-25 00:07:24 -0400611 output = _run_command(cmd=['gofmt', '-l'], input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500612 stderr=subprocess.STDOUT)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700613 if output:
614 errors.append(gofile)
615 if errors:
616 return HookFailure('Files not formatted with gofmt:', errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400617 return None
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700618
619
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600620def _check_rustfmt(_project, commit):
621 """Checks that Rust files are formatted with rustfmt."""
622 errors = []
623 files = _filter_files(_get_affected_files(commit, relative=True),
624 [r'\.rs$'])
625
626 for rustfile in files:
627 contents = _get_file_content(rustfile, commit)
Mike Frysingeraa7dc942019-09-25 00:07:24 -0400628 output = _run_command(cmd=['rustfmt'], input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500629 stderr=subprocess.STDOUT)
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600630 if output != contents:
631 errors.append(rustfile)
632 if errors:
633 return HookFailure('Files not formatted with rustfmt: '
634 "(run 'cargo fmt' to fix)", errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400635 return None
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600636
637
Mike Frysingerae409522014-02-01 03:16:11 -0500638def _check_change_has_test_field(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700639 """Check for a non-empty 'TEST=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500640 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700641
Cheng Yuehb707c522020-01-02 14:06:59 +0800642 if not re.search(TEST_FIELD_RE, _get_commit_desc(commit)):
Mike Frysingered9b2a02019-12-12 18:52:32 -0500643 msg = ('Changelist description needs TEST field (after first line)\n%s' %
644 (SEE_ALSO,))
Ryan Cui1562fb82011-05-09 11:01:31 -0700645 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400646 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700647
Ryan Cuiec4d6332011-05-02 14:15:25 -0700648
Mike Frysingerae409522014-02-01 03:16:11 -0500649def _check_change_has_valid_cq_depend(_project, commit):
Jason D. Clinton299e3222019-05-23 09:42:03 -0600650 """Check for a correctly formatted Cq-Depend field in the commit message."""
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700651 desc = _get_commit_desc(commit)
Jason D. Clinton299e3222019-05-23 09:42:03 -0600652 msg = 'Changelist has invalid Cq-Depend target.'
653 example = 'Example: Cq-Depend: chromium:1234, chrome-internal:2345'
David Jamesc3b68b32013-04-03 09:17:03 -0700654 try:
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700655 patch.GetPaladinDeps(desc)
David Jamesc3b68b32013-04-03 09:17:03 -0700656 except ValueError as ex:
657 return HookFailure(msg, [example, str(ex)])
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700658 # Check that Cq-Depend is in the same paragraph as Change-Id.
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500659 msg = 'Cq-Depend is not in the same paragraph as Change-Id.'
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700660 paragraphs = desc.split('\n\n')
661 for paragraph in paragraphs:
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500662 if (re.search(r'^Cq-Depend:', paragraph, re.M) and not
663 re.search('^Change-Id:', paragraph, re.M)):
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700664 return HookFailure(msg)
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500665
666 # We no longer support CQ-DEPEND= lines.
667 if re.search(r'^CQ-DEPEND[=:]', desc, re.M):
668 return HookFailure(
669 'CQ-DEPEND= is no longer supported. Please see:\n'
670 'https://chromium.googlesource.com/chromiumos/docs/+/HEAD/'
671 'contributing.md#CQ-DEPEND')
672
Mike Frysinger8cf80812019-09-16 23:49:29 -0400673 return None
David Jamesc3b68b32013-04-03 09:17:03 -0700674
675
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800676def _check_change_is_contribution(_project, commit):
677 """Check that the change is a contribution."""
678 NO_CONTRIB = 'not a contribution'
679 if NO_CONTRIB in _get_commit_desc(commit).lower():
680 msg = ('Changelist is not a contribution, this cannot be accepted.\n'
681 'Please remove the "%s" text from the commit message.') % NO_CONTRIB
682 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400683 return None
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800684
685
Alex Deymo643ac4c2015-09-03 10:40:50 -0700686def _check_change_has_bug_field(project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700687 """Check for a correctly formatted 'BUG=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500688 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
689
David James5c0073d2013-04-03 08:48:52 -0700690 OLD_BUG_RE = r'\nBUG=.*chromium-os'
691 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
692 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
693 'the chromium tracker in your BUG= line now.')
694 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700695
Alex Deymo643ac4c2015-09-03 10:40:50 -0700696 # Android internal and external projects use "Bug: " to track bugs in
697 # buganizer.
698 BUG_COLON_REMOTES = (
699 'aosp',
700 'goog',
701 )
702 if project.remote in BUG_COLON_REMOTES:
703 BUG_RE = r'\nBug: ?([Nn]one|\d+)'
704 if not re.search(BUG_RE, _get_commit_desc(commit)):
705 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500706 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700707 'Bug: 9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500708 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700709 return HookFailure(msg)
710 else:
Jorge Lucangeli Obesdce214e2017-10-25 15:04:39 -0400711 BUG_RE = r'\nBUG=([Nn]one|(chromium|b):\d+)'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700712 if not re.search(BUG_RE, _get_commit_desc(commit)):
713 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500714 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700715 'BUG=chromium:9999 (for public tracker)\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700716 'BUG=b:9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500717 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700718 return HookFailure(msg)
Ryan Cui1562fb82011-05-09 11:01:31 -0700719
Cheng Yuehb707c522020-01-02 14:06:59 +0800720 TEST_BEFORE_BUG_RE = TEST_FIELD_RE + r'.*' + BUG_RE
721
722 if re.search(TEST_BEFORE_BUG_RE, _get_commit_desc(commit), re.DOTALL):
723 msg = ('The BUG field must come before the TEST field.\n%s' %
724 (SEE_ALSO,))
725 return HookFailure(msg)
726
Mike Frysinger8cf80812019-09-16 23:49:29 -0400727 return None
728
Ryan Cuiec4d6332011-05-02 14:15:25 -0700729
Jack Neus8edbf642019-07-10 16:08:31 -0600730def _check_change_no_include_oem(project, commit):
731 """Check that the change does not reference OEMs."""
732 ALLOWLIST = {
733 'chromiumos/platform/ec',
734 # Used by unit tests.
735 'project',
736 }
737 if project.name not in ALLOWLIST:
738 return None
739
Mike Frysingerbb34a222019-07-31 14:40:46 -0400740 TAGS = {
Jack Neus8edbf642019-07-10 16:08:31 -0600741 'Reviewed-on',
742 'Reviewed-by',
743 'Signed-off-by',
744 'Commit-Ready',
745 'Tested-by',
746 'Commit-Queue',
Jack Neus8edbf642019-07-10 16:08:31 -0600747 'Acked-by',
748 'Modified-by',
749 'CC',
750 'Suggested-by',
751 'Reported-by',
752 'Acked-for-chrome-by',
LaMont Jones237f3ef2020-01-22 10:40:52 -0700753 'Cq-Cl-Tag',
Mike Frysingerbb34a222019-07-31 14:40:46 -0400754 }
Jack Neus8edbf642019-07-10 16:08:31 -0600755
756 # Ignore tags, which could reasonably contain OEM names
757 # (e.g. Reviewed-by: foo@oem.corp-partner.google.com).
Jack Neus8edbf642019-07-10 16:08:31 -0600758 commit_message = ' '.join(
Mike Frysingerbb34a222019-07-31 14:40:46 -0400759 x for x in _get_commit_desc(commit).splitlines()
760 if ':' not in x or x.split(':', 1)[0] not in TAGS)
761
Jack Neus8edbf642019-07-10 16:08:31 -0600762 commit_message = re.sub(r'[\s_-]+', ' ', commit_message)
763
764 # Exercise caution when expanding these lists. Adding a name
765 # could indicate a new relationship with a company!
766 OEMS = ['hp', 'hewlett packard', 'dell', 'lenovo', 'acer', 'asus', 'samsung']
767 ODMS = [
768 'bitland', 'compal', 'haier', 'huaqin', 'inventec', 'lg', 'pegatron',
769 'pegatron(ems)', 'quanta', 'samsung', 'wistron'
770 ]
771
772 for name_type, name_list in [('OEM', OEMS), ('ODM', ODMS)]:
773 # Construct regex
774 name_re = r'\b(%s)\b' % '|'.join([re.escape(x) for x in name_list])
775 matches = [x[0] for x in re.findall(name_re, commit_message, re.IGNORECASE)]
Mike Frysingere52b1bc2019-09-16 23:45:41 -0400776 if matches:
Jack Neus8edbf642019-07-10 16:08:31 -0600777 # If there's a match, throw an error.
778 error_msg = ('Changelist description contains the name of an'
779 ' %s: "%s".' % (name_type, '","'.join(matches)))
780 return HookFailure(error_msg)
781
Mike Frysinger8cf80812019-09-16 23:49:29 -0400782 return None
783
Jack Neus8edbf642019-07-10 16:08:31 -0600784
Mike Frysinger292b45d2014-11-25 01:17:10 -0500785def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -0700786 """Check that we're not missing a revbump of an ebuild in the given commit.
787
788 If the given commit touches files in a directory that has ebuilds somewhere
789 up the directory hierarchy, it's very likely that we need an ebuild revbump
790 in order for those changes to take effect.
791
792 It's not totally trivial to detect a revbump, so at least detect that an
793 ebuild with a revision number in it was touched. This should handle the
794 common case where we use a symlink to do the revbump.
795
796 TODO: it would be nice to enhance this hook to:
797 * Handle cases where people revbump with a slightly different syntax. I see
798 one ebuild (puppy) that revbumps with _pN. This is a false positive.
799 * Catches cases where people aren't using symlinks for revbumps. If they
800 edit a revisioned file directly (and are expected to rename it for revbump)
801 we'll miss that. Perhaps we could detect that the file touched is a
802 symlink?
803
804 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
805 still better off than without this check.
806
807 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700808 project: The Project to look at
Doug Anderson42b8a052013-06-26 10:45:36 -0700809 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -0500810 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -0700811
812 Returns:
813 A HookFailure or None.
814 """
Mike Frysinger011af942014-01-17 16:12:22 -0500815 # If this is the portage-stable overlay, then ignore the check. It's rare
816 # that we're doing anything other than importing files from upstream, so
817 # forcing a rev bump makes no sense.
818 whitelist = (
819 'chromiumos/overlays/portage-stable',
820 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700821 if project.name in whitelist:
Mike Frysinger011af942014-01-17 16:12:22 -0500822 return None
823
Mike Frysinger292b45d2014-11-25 01:17:10 -0500824 def FinalName(obj):
825 # If the file is being deleted, then the dst_file is not set.
826 if obj.dst_file is None:
827 return obj.src_file
828 else:
829 return obj.dst_file
830
831 affected_path_objs = _get_affected_files(
832 commit, include_deletes=True, include_symlinks=True, relative=True,
833 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -0700834
835 # Don't yell about changes to whitelisted files...
Mike Frysinger550c05c2019-12-09 18:16:36 -0500836 whitelist = {'ChangeLog', 'Manifest', 'metadata.xml'}
Mike Frysinger292b45d2014-11-25 01:17:10 -0500837 affected_path_objs = [x for x in affected_path_objs
838 if os.path.basename(FinalName(x)) not in whitelist]
839 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -0700840 return None
841
842 # If we've touched any file named with a -rN.ebuild then we'll say we're
843 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500844 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
845 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700846 if touched_revved_ebuild:
847 return None
848
Mike Frysinger292b45d2014-11-25 01:17:10 -0500849 # If we're creating new ebuilds from scratch, then we don't need an uprev.
850 # Find all the dirs that new ebuilds and ignore their files/.
851 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
852 if FinalName(x).endswith('.ebuild') and x.status == 'A']
853 affected_path_objs = [obj for obj in affected_path_objs
854 if not any(FinalName(obj).startswith(x)
855 for x in ebuild_dirs)]
856 if not affected_path_objs:
Mike Frysinger8cf80812019-09-16 23:49:29 -0400857 return None
Mike Frysinger292b45d2014-11-25 01:17:10 -0500858
Doug Anderson42b8a052013-06-26 10:45:36 -0700859 # We want to examine the current contents of all directories that are parents
860 # of files that were touched (up to the top of the project).
861 #
862 # ...note: we use the current directory contents even though it may have
863 # changed since the commit we're looking at. This is just a heuristic after
864 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500865 if project_top is None:
866 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -0700867 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -0500868 for obj in affected_path_objs:
869 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -0700870 while os.path.exists(path) and not os.path.samefile(path, project_top):
871 dirs_to_check.add(path)
872 path = os.path.dirname(path)
873
874 # Look through each directory. If it's got an ebuild in it then we'll
875 # consider this as a case when we need a revbump.
Gwendal Grignoua3086c32014-12-09 11:17:22 -0800876 affected_paths = set(os.path.join(project_top, FinalName(x))
877 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700878 for dir_path in dirs_to_check:
879 contents = os.listdir(dir_path)
880 ebuilds = [os.path.join(dir_path, path)
881 for path in contents if path.endswith('.ebuild')]
882 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
883
C Shapiroae157ae2017-09-18 16:24:03 -0600884 affected_paths_under_9999_ebuilds = set()
885 for affected_path in affected_paths:
886 for ebuild_9999 in ebuilds_9999:
887 ebuild_dir = os.path.dirname(ebuild_9999)
888 if affected_path.startswith(ebuild_dir):
889 affected_paths_under_9999_ebuilds.add(affected_path)
890
891 # If every file changed exists under a 9999 ebuild, then skip
892 if len(affected_paths_under_9999_ebuilds) == len(affected_paths):
893 continue
894
Doug Anderson42b8a052013-06-26 10:45:36 -0700895 # If the -9999.ebuild file was touched the bot will uprev for us.
896 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -0500897 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -0700898 continue
899
900 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500901 return HookFailure('Changelist probably needs a revbump of an ebuild, '
902 'or a -r1.ebuild symlink if this is a new ebuild:\n'
903 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -0700904
905 return None
906
907
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500908def _check_ebuild_eapi(project, commit):
Mike Frysinger948284a2018-02-01 15:22:56 -0500909 """Make sure we have people use EAPI=5 or newer with custom ebuilds.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500910
911 We want to get away from older EAPI's as it makes life confusing and they
912 have less builtin error checking.
913
914 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700915 project: The Project to look at
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500916 commit: The commit to look at
917
918 Returns:
919 A HookFailure or None.
920 """
921 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500922 # that we're doing anything other than importing files from upstream, and
923 # we shouldn't be rewriting things fundamentally anyways.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500924 whitelist = (
925 'chromiumos/overlays/portage-stable',
926 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700927 if project.name in whitelist:
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500928 return None
929
Mike Frysinger948284a2018-02-01 15:22:56 -0500930 BAD_EAPIS = ('0', '1', '2', '3', '4')
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500931
932 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
933
934 ebuilds_re = [r'\.ebuild$']
935 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
936 ebuilds_re)
937 bad_ebuilds = []
938
939 for ebuild in ebuilds:
940 # If the ebuild does not specify an EAPI, it defaults to 0.
941 eapi = '0'
942
943 lines = _get_file_content(ebuild, commit).splitlines()
944 if len(lines) == 1:
945 # This is most likely a symlink, so skip it entirely.
946 continue
947
948 for line in lines:
949 m = get_eapi.match(line)
950 if m:
951 # Once we hit the first EAPI line in this ebuild, stop processing.
952 # The spec requires that there only be one and it be first, so
953 # checking all possible values is pointless. We also assume that
954 # it's "the" EAPI line and not something in the middle of a heredoc.
955 eapi = m.group(1)
956 break
957
958 if eapi in BAD_EAPIS:
959 bad_ebuilds.append((ebuild, eapi))
960
961 if bad_ebuilds:
962 # pylint: disable=C0301
963 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
964 # pylint: enable=C0301
965 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500966 'These ebuilds are using old EAPIs. If these are imported from\n'
967 'Gentoo, then you may ignore and upload once with the --no-verify\n'
Mike Frysinger948284a2018-02-01 15:22:56 -0500968 'flag. Otherwise, please update to 5 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500969 '\t%s\n'
970 'See this guide for more details:\n%s\n' %
971 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
972
Mike Frysinger8cf80812019-09-16 23:49:29 -0400973 return None
974
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500975
Mike Frysinger89bdb852014-02-01 05:26:26 -0500976def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -0500977 """Make sure we use the new style KEYWORDS when possible in ebuilds.
978
979 If an ebuild generally does not care about the arch it is running on, then
980 ebuilds should flag it with one of:
981 KEYWORDS="*" # A stable ebuild.
982 KEYWORDS="~*" # An unstable ebuild.
983 KEYWORDS="-* ..." # Is known to only work on specific arches.
984
985 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700986 project: The Project to look at
Mike Frysingerc51ece72014-01-17 16:23:40 -0500987 commit: The commit to look at
988
989 Returns:
990 A HookFailure or None.
991 """
992 WHITELIST = set(('*', '-*', '~*'))
993
994 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
995
Mike Frysinger89bdb852014-02-01 05:26:26 -0500996 ebuilds_re = [r'\.ebuild$']
997 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
998 ebuilds_re)
999
Mike Frysinger8d42d742014-09-22 15:50:21 -04001000 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -05001001 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -04001002 # We get the full content rather than a diff as the latter does not work
1003 # on new files (like when adding new ebuilds).
1004 lines = _get_file_content(ebuild, commit).splitlines()
1005 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -05001006 m = get_keywords.match(line)
1007 if m:
1008 keywords = set(m.group(1).split())
1009 if not keywords or WHITELIST - keywords != WHITELIST:
1010 continue
1011
Mike Frysinger8d42d742014-09-22 15:50:21 -04001012 bad_ebuilds.append(ebuild)
1013
1014 if bad_ebuilds:
1015 return HookFailure(
1016 '%s\n'
1017 'Please update KEYWORDS to use a glob:\n'
1018 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
1019 ' KEYWORDS="*"\n'
1020 'If the ebuild should be marked unstable (normal for '
1021 'cros-workon / 9999 ebuilds):\n'
1022 ' KEYWORDS="~*"\n'
Mike Frysingerde8efea2015-05-17 03:42:26 -04001023 'If the ebuild needs to be marked for only specific arches, '
Mike Frysinger8d42d742014-09-22 15:50:21 -04001024 'then use -* like so:\n'
1025 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -05001026
Mike Frysinger8cf80812019-09-16 23:49:29 -04001027 return None
1028
Mike Frysingerc51ece72014-01-17 16:23:40 -05001029
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001030def _check_ebuild_licenses(_project, commit):
1031 """Check if the LICENSE field in the ebuild is correct."""
Brian Norris7a610e82016-02-17 12:24:54 -08001032 affected_paths = _get_affected_files(commit, relative=True)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001033 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
1034
1035 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -08001036 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001037
1038 for ebuild in touched_ebuilds:
1039 # Skip virutal packages.
1040 if ebuild.split('/')[-3] == 'virtual':
1041 continue
1042
Alex Kleinb5953522018-08-03 11:44:21 -06001043 # e.g. path/to/overlay/category/package/package.ebuild -> path/to/overlay
1044 overlay_path = os.sep.join(ebuild.split(os.sep)[:-3])
1045
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001046 try:
Brian Norris7a610e82016-02-17 12:24:54 -08001047 ebuild_content = _get_file_content(ebuild, commit)
Alex Kleinb5953522018-08-03 11:44:21 -06001048 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content,
1049 overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001050 except ValueError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001051 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001052
1053 # Also ignore licenses ending with '?'
1054 for license_type in [x for x in license_types
1055 if x not in LICENSES_IGNORE and not x.endswith('?')]:
1056 try:
Alex Kleinb5953522018-08-03 11:44:21 -06001057 licenses_lib.Licensing.FindLicenseType(license_type,
1058 overlay_path=overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001059 except AssertionError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001060 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001061
Mike Frysinger8cf80812019-09-16 23:49:29 -04001062 return None
1063
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001064
Mike Frysingercd363c82014-02-01 05:20:18 -05001065def _check_ebuild_virtual_pv(project, commit):
1066 """Enforce the virtual PV policies."""
1067 # If this is the portage-stable overlay, then ignore the check.
1068 # We want to import virtuals as-is from upstream Gentoo.
1069 whitelist = (
1070 'chromiumos/overlays/portage-stable',
1071 )
Alex Deymo643ac4c2015-09-03 10:40:50 -07001072 if project.name in whitelist:
Mike Frysingercd363c82014-02-01 05:20:18 -05001073 return None
1074
1075 # We assume the repo name is the same as the dir name on disk.
1076 # It would be dumb to not have them match though.
Alex Deymo643ac4c2015-09-03 10:40:50 -07001077 project_base = os.path.basename(project.name)
Mike Frysingercd363c82014-02-01 05:20:18 -05001078
1079 is_variant = lambda x: x.startswith('overlay-variant-')
1080 is_board = lambda x: x.startswith('overlay-')
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001081 is_baseboard = lambda x: x.startswith('baseboard-')
1082 is_chipset = lambda x: x.startswith('chipset-')
1083 is_project = lambda x: x.startswith('project-')
Mike Frysingercd363c82014-02-01 05:20:18 -05001084 is_private = lambda x: x.endswith('-private')
1085
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001086 is_special_overlay = lambda x: (is_board(x) or is_chipset(x) or
1087 is_baseboard(x) or is_project(x))
1088
Mike Frysingercd363c82014-02-01 05:20:18 -05001089 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
1090
1091 ebuilds_re = [r'\.ebuild$']
1092 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1093 ebuilds_re)
1094 bad_ebuilds = []
1095
1096 for ebuild in ebuilds:
1097 m = get_pv.match(ebuild)
1098 if m:
1099 overlay = m.group(1)
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001100 if not overlay or not is_special_overlay(overlay):
Alex Deymo643ac4c2015-09-03 10:40:50 -07001101 overlay = project_base
Mike Frysingercd363c82014-02-01 05:20:18 -05001102
1103 pv = m.group(3).split('-', 1)[0]
1104
Bernie Thompsone5ee1822016-01-12 14:22:23 -08001105 # Virtual versions >= 4 are special cases used above the standard
1106 # versioning structure, e.g. if one has a board inheriting a board.
1107 if float(pv) >= 4:
1108 want_pv = pv
Mike Frysingercd363c82014-02-01 05:20:18 -05001109 elif is_board(overlay):
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001110 if is_private(overlay):
1111 want_pv = '3.5' if is_variant(overlay) else '3'
1112 elif is_board(overlay):
1113 want_pv = '2.5' if is_variant(overlay) else '2'
1114 elif is_baseboard(overlay):
1115 want_pv = '1.9'
1116 elif is_chipset(overlay):
1117 want_pv = '1.8'
1118 elif is_project(overlay):
1119 want_pv = '1.7' if is_private(overlay) else '1.5'
Mike Frysingercd363c82014-02-01 05:20:18 -05001120 else:
1121 want_pv = '1'
1122
1123 if pv != want_pv:
1124 bad_ebuilds.append((ebuild, pv, want_pv))
1125
1126 if bad_ebuilds:
1127 # pylint: disable=C0301
1128 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
1129 # pylint: enable=C0301
1130 return HookFailure(
1131 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
1132 '\t%s\n'
1133 'If this is an upstream Gentoo virtual, then you may ignore this\n'
1134 'check (and re-run w/--no-verify). Otherwise, please see this\n'
1135 'page for more details:\n%s\n' %
1136 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
1137 for x in bad_ebuilds]), url))
1138
Mike Frysinger8cf80812019-09-16 23:49:29 -04001139 return None
1140
Mike Frysingercd363c82014-02-01 05:20:18 -05001141
Daniel Erat9d203ff2015-02-17 10:12:21 -07001142def _check_portage_make_use_var(_project, commit):
1143 """Verify that $USE is set correctly in make.conf and make.defaults."""
1144 files = _filter_files(_get_affected_files(commit, relative=True),
1145 [r'(^|/)make.(conf|defaults)$'])
1146
1147 errors = []
1148 for path in files:
1149 basename = os.path.basename(path)
1150
1151 # Has a USE= line already been encountered in this file?
1152 saw_use = False
1153
1154 for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1):
1155 if not line.startswith('USE='):
1156 continue
1157
1158 preserves_use = '${USE}' in line or '$USE' in line
1159
1160 if (basename == 'make.conf' or
1161 (basename == 'make.defaults' and saw_use)) and not preserves_use:
1162 errors.append('%s:%d: missing ${USE}' % (path, i))
1163 elif basename == 'make.defaults' and not saw_use and preserves_use:
1164 errors.append('%s:%d: ${USE} referenced in initial declaration' %
1165 (path, i))
1166
1167 saw_use = True
1168
1169 if errors:
1170 return HookFailure(
1171 'One or more Portage make files appear to set USE incorrectly.\n'
1172 '\n'
1173 'All USE assignments in make.conf and all assignments after the\n'
1174 'initial declaration in make.defaults should contain "${USE}" to\n'
1175 'preserve previously-set flags.\n'
1176 '\n'
1177 'The initial USE declaration in make.defaults should not contain\n'
1178 '"${USE}".\n',
1179 errors)
1180
Mike Frysinger8cf80812019-09-16 23:49:29 -04001181 return None
1182
Daniel Erat9d203ff2015-02-17 10:12:21 -07001183
Mike Frysingerae409522014-02-01 03:16:11 -05001184def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001185 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001186 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001187 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001188 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001189 if not m:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001190 return HookFailure('Last paragraph of description must include Change-Id.')
Ryan Cui1562fb82011-05-09 11:01:31 -07001191
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001192 # S-o-b tags always allowed to follow Change-ID.
LaMont Jones237f3ef2020-01-22 10:40:52 -07001193 allowed_tags = ['Signed-off-by', 'Cq-Cl-Tag']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001194
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001195 end = desc[m.end():].strip().splitlines()
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001196 cherry_pick_marker = 'cherry picked from commit'
1197
1198 if end and cherry_pick_marker in end[-1]:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001199 # Cherry picked patches allow more tags in the last paragraph.
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001200 allowed_tags += ['Commit-Queue', 'Commit-Ready', 'Reviewed-by',
1201 'Reviewed-on', 'Tested-by']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001202 end = end[:-1]
1203
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001204 # Note that descriptions could have multiple cherry pick markers.
1205 tag_search = r'^(%s:|\(%s) ' % (':|'.join(allowed_tags), cherry_pick_marker)
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001206
1207 if [x for x in end if not re.search(tag_search, x)]:
1208 return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' %
1209 ':", "'.join(allowed_tags))
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001210
Mike Frysinger8cf80812019-09-16 23:49:29 -04001211 return None
1212
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001213
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001214def _check_commit_message_style(_project, commit):
1215 """Verify that the commit message matches our style.
1216
1217 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
1218 commit hooks.
1219 """
Mike Frysingered9b2a02019-12-12 18:52:32 -05001220 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Mike Frysinger4efdee72019-11-04 10:57:01 -05001221
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001222 desc = _get_commit_desc(commit)
1223
1224 # The first line should be by itself.
1225 lines = desc.splitlines()
1226 if len(lines) > 1 and lines[1]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001227 return HookFailure('The second line of the commit message must be blank.'
1228 '\n%s' % (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001229
1230 # The first line should be one sentence.
1231 if '. ' in lines[0]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001232 return HookFailure('The first line cannot be more than one sentence.\n%s' %
1233 (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001234
1235 # The first line cannot be too long.
1236 MAX_FIRST_LINE_LEN = 100
1237 if len(lines[0]) > MAX_FIRST_LINE_LEN:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001238 return HookFailure('The first line must be less than %i chars.\n%s' %
1239 (MAX_FIRST_LINE_LEN, SEE_ALSO))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001240
Mike Frysinger8cf80812019-09-16 23:49:29 -04001241 return None
1242
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001243
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001244def _check_cros_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001245 """Verifies the Chromium OS license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -07001246
Mike Frysinger98638102014-08-28 00:15:08 -04001247 Should be following the spec:
1248 http://dev.chromium.org/developers/coding-style#TOC-File-headers
1249 """
1250 # For older years, be a bit more flexible as our policy says leave them be.
1251 LICENSE_HEADER = (
Keigo Oka7e880ac2019-07-03 15:03:43 +09001252 r'.*Copyright(?: \(c\))? (20[0-9]{2})(?:-20[0-9]{2})? The Chromium OS '
1253 r'Authors\. All rights reserved\.\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001254 r'.*Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001255 r'be\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001256 r'.*found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -05001257 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001258 )
1259 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1260
1261 # For newer years, be stricter.
Keigo Oka7e880ac2019-07-03 15:03:43 +09001262 BAD_COPYRIGHT_LINE = (
Brian Norris68838dd2018-09-26 18:30:24 -07001263 r'.*Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001264 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001265 )
Keigo Oka7e880ac2019-07-03 15:03:43 +09001266 bad_copyright_re = re.compile(BAD_COPYRIGHT_LINE)
Mike Frysinger98638102014-08-28 00:15:08 -04001267
Shuhei Takahashiabc20f32017-07-10 19:35:45 +09001268 included, excluded = _parse_common_inclusion_options(options)
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001269
Mike Frysinger98638102014-08-28 00:15:08 -04001270 bad_files = []
1271 bad_copyright_files = []
Keigo Oka7e880ac2019-07-03 15:03:43 +09001272 bad_year_files = []
1273
Ken Turnerd07564b2018-02-08 17:57:59 +11001274 files = _filter_files(
1275 _get_affected_files(commit, relative=True),
1276 included + COMMON_INCLUDED_PATHS,
1277 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001278 existing_files = set(_get_affected_files(commit, relative=True,
1279 include_adds=False))
Mike Frysinger98638102014-08-28 00:15:08 -04001280
Keigo Oka7e880ac2019-07-03 15:03:43 +09001281 current_year = str(datetime.datetime.now().year)
Mike Frysinger98638102014-08-28 00:15:08 -04001282 for f in files:
1283 contents = _get_file_content(f, commit)
1284 if not contents:
1285 # Ignore empty files.
1286 continue
1287
Keigo Oka7e880ac2019-07-03 15:03:43 +09001288 m = license_re.search(contents)
1289 if not m:
Mike Frysinger98638102014-08-28 00:15:08 -04001290 bad_files.append(f)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001291 elif bad_copyright_re.search(contents):
Mike Frysinger98638102014-08-28 00:15:08 -04001292 bad_copyright_files.append(f)
1293
Keigo Oka7e880ac2019-07-03 15:03:43 +09001294 if m and f not in existing_files:
1295 year = m.group(1)
1296 if year != current_year:
1297 bad_year_files.append(f)
1298
1299 errors = []
Mike Frysinger98638102014-08-28 00:15:08 -04001300 if bad_files:
1301 msg = '%s:\n%s\n%s' % (
1302 'License must match', license_re.pattern,
1303 'Found a bad header in these files:')
Keigo Oka7e880ac2019-07-03 15:03:43 +09001304 errors.append(HookFailure(msg, bad_files))
Mike Frysinger98638102014-08-28 00:15:08 -04001305 if bad_copyright_files:
1306 msg = 'Do not use (c) in copyright headers in new files:'
Keigo Oka7e880ac2019-07-03 15:03:43 +09001307 errors.append(HookFailure(msg, bad_copyright_files))
1308 if bad_year_files:
1309 msg = 'Use current year (%s) in copyright headers in new files:' % (
1310 current_year)
1311 errors.append(HookFailure(msg, bad_year_files))
Ryan Cuiec4d6332011-05-02 14:15:25 -07001312
Keigo Oka7e880ac2019-07-03 15:03:43 +09001313 return errors
Ryan Cuiec4d6332011-05-02 14:15:25 -07001314
Mike Frysinger8cf80812019-09-16 23:49:29 -04001315
Amin Hassani391efa92018-01-26 17:58:05 -08001316def _check_aosp_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001317 """Verifies the AOSP license/copyright header.
1318
1319 AOSP uses the Apache2 License:
1320 https://source.android.com/source/licenses.html
1321 """
1322 LICENSE_HEADER = (
1323 r"""^[#/\*]*
1324[#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project
1325[#/\*]* ?
1326[#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\);
1327[#/\*]* ?you may not use this file except in compliance with the License\.
1328[#/\*]* ?You may obtain a copy of the License at
1329[#/\*]* ?
1330[#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0
1331[#/\*]* ?
1332[#/\*]* ?Unless required by applicable law or agreed to in writing, software
1333[#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS,
1334[#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """
1335 r"""implied\.
1336[#/\*]* ?See the License for the specific language governing permissions and
1337[#/\*]* ?limitations under the License\.
1338[#/\*]*$
1339"""
1340 )
1341 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1342
Amin Hassani391efa92018-01-26 17:58:05 -08001343 included, excluded = _parse_common_inclusion_options(options)
1344
Ken Turnerd07564b2018-02-08 17:57:59 +11001345 files = _filter_files(
1346 _get_affected_files(commit, relative=True),
1347 included + COMMON_INCLUDED_PATHS,
1348 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Alex Deymof5792ce2015-08-24 22:50:08 -07001349
1350 bad_files = []
1351 for f in files:
1352 contents = _get_file_content(f, commit)
1353 if not contents:
1354 # Ignore empty files.
1355 continue
1356
1357 if not license_re.search(contents):
1358 bad_files.append(f)
1359
1360 if bad_files:
1361 msg = ('License must match:\n%s\nFound a bad header in these files:' %
1362 license_re.pattern)
1363 return HookFailure(msg, bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001364 return None
Alex Deymof5792ce2015-08-24 22:50:08 -07001365
1366
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001367def _check_layout_conf(_project, commit):
1368 """Verifies the metadata/layout.conf file."""
1369 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001370 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001371 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001372 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001373
Mike Frysinger94a670c2014-09-19 12:46:26 -04001374 # Handle multiple overlays in a single commit (like the public tree).
1375 for f in _get_affected_files(commit, relative=True):
1376 if f.endswith(repo_name):
1377 repo_names.append(f)
1378 elif f.endswith(layout_path):
1379 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001380
1381 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -04001382 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001383 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -04001384 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001385
Mike Frysinger94a670c2014-09-19 12:46:26 -04001386 # Gather all the errors in one pass so we show one full message.
1387 all_errors = {}
1388 for layout_path in layout_paths:
1389 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001390
Mike Frysinger94a670c2014-09-19 12:46:26 -04001391 # Make sure the config file is sorted.
1392 data = [x for x in _get_file_content(layout_path, commit).splitlines()
1393 if x and x[0] != '#']
1394 if sorted(data) != data:
1395 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001396
Mike Frysinger94a670c2014-09-19 12:46:26 -04001397 # Require people to set specific values all the time.
1398 settings = (
1399 # TODO: Enable this for everyone. http://crbug.com/408038
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001400 # ('fast caching', 'cache-format = md5-dict'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001401 ('fast manifests', 'thin-manifests = true'),
Mike Frysingerd7734522015-02-26 16:12:43 -05001402 ('extra features', 'profile-formats = portage-2 profile-default-eapi'),
1403 ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001404 )
1405 for reason, line in settings:
1406 if line not in data:
1407 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001408
Mike Frysinger94a670c2014-09-19 12:46:26 -04001409 # Require one of these settings.
Mike Frysinger5fae62d2015-11-11 20:12:15 -05001410 if 'use-manifests = strict' not in data:
1411 errors += ['enable file checking with: use-manifests = strict']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001412
Mike Frysinger94a670c2014-09-19 12:46:26 -04001413 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -04001414 for line in data:
1415 if line.startswith('repo-name = '):
1416 break
1417 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -04001418 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001419
Mike Frysinger94a670c2014-09-19 12:46:26 -04001420 # Summarize all the errors we saw (if any).
1421 lines = ''
1422 for layout_path, errors in all_errors.items():
1423 if errors:
1424 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
1425 if lines:
1426 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
1427 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001428
Mike Frysinger8cf80812019-09-16 23:49:29 -04001429 return None
1430
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001431
Keigo Oka4a09bd92019-05-07 14:01:00 +09001432def _check_no_new_gyp(_project, commit):
1433 """Verifies no project starts to use GYP."""
1434 whitelist = [
Keigo Oka4a09bd92019-05-07 14:01:00 +09001435 'chromeos/ap',
1436 'chromeos/ap-daemons',
Keigo Oka150a6fd2019-06-04 11:30:25 +09001437 'chromeos/ap/security',
1438 'chromeos/ap/wireless',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001439 'chromeos/platform/actions',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001440 'chromeos/platform/drivefs-google3',
1441 'chromeos/platform/experimental-touch-fw',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001442 'chromeos/thermald',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001443 'chromiumos/platform2',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001444 'weave/libweave',
1445 ]
1446 if _project.name in whitelist:
1447 return None
1448
1449 gypfiles = _filter_files(
1450 _get_affected_files(commit, include_symlinks=True, relative=True),
1451 [r'\.gyp$'])
1452
1453 if gypfiles:
1454 return HookFailure('GYP is deprecated and not allowed in a new project:',
1455 gypfiles)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001456 return None
Keigo Oka4a09bd92019-05-07 14:01:00 +09001457
1458
Ryan Cuiec4d6332011-05-02 14:15:25 -07001459# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001460
Ryan Cui1562fb82011-05-09 11:01:31 -07001461
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001462def _check_clang_format(_project, commit, options=()):
1463 """Runs clang-format on the given project"""
1464 hooks_dir = _get_hooks_dir()
1465 options = list(options)
1466 if commit == PRE_SUBMIT:
1467 options.append('--commit=HEAD')
1468 else:
1469 options.extend(['--commit', commit])
Brian Norris0c62a142018-12-11 13:24:29 -08001470 cmd = [os.path.join(hooks_dir, 'clang-format.py')] + options
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001471 cmd_result = cros_build_lib.run(cmd,
1472 print_cmd=False,
1473 stdout=True,
1474 encoding='utf-8',
1475 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001476 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001477 check=False)
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001478 if cmd_result.returncode:
1479 return HookFailure('clang-format.py errors/warnings\n\n' +
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001480 cmd_result.stdout)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001481 return None
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001482
1483
Mike Frysingerae409522014-02-01 03:16:11 -05001484def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001485 """Runs checkpatch.pl on the given project"""
1486 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001487 options = list(options)
1488 if commit == PRE_SUBMIT:
1489 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
1490 # this case.
1491 options.append('--ignore=MISSING_SIGN_OFF')
Filipe Brandenburger28d48d62015-10-07 09:48:54 -07001492 # Always ignore the check for the MAINTAINERS file. We do not track that
1493 # information on that file in our source trees, so let's suppress the
1494 # warning.
1495 options.append('--ignore=FILE_PATH_CHANGES')
Filipe Brandenburgerce978322015-10-09 10:04:15 -07001496 # Do not complain about the Change-Id: fields, since we use Gerrit.
1497 # Upstream does not want those lines (since they do not use Gerrit), but
1498 # we always do, so disable the check globally.
Daisuke Nojiri4844f892015-10-08 09:54:33 -07001499 options.append('--ignore=GERRIT_CHANGE_ID')
Brian Norris0c62a142018-12-11 13:24:29 -08001500 cmd = [os.path.join(hooks_dir, 'checkpatch.pl')] + options + ['-']
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001501 cmd_result = cros_build_lib.run(
1502 cmd, print_cmd=False, input=_get_patch(commit).encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001503 stdout=True, stderr=subprocess.STDOUT, check=False, encoding='utf-8',
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001504 errors='replace')
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001505 if cmd_result.returncode:
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001506 return HookFailure('checkpatch.pl errors/warnings\n\n' + cmd_result.stdout)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001507 return None
Ryan Cuiec4d6332011-05-02 14:15:25 -07001508
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001509
Brian Norris23c62e92018-11-14 12:25:51 -08001510def _run_kerneldoc(_project, commit, options=()):
1511 """Runs kernel-doc validator on the given project"""
1512 included, excluded = _parse_common_inclusion_options(options)
1513 files = _filter_files(_get_affected_files(commit, relative=True),
1514 included, excluded)
1515 if files:
1516 hooks_dir = _get_hooks_dir()
Brian Norris0c62a142018-12-11 13:24:29 -08001517 cmd = [os.path.join(hooks_dir, 'kernel-doc'), '-none'] + files
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001518 output = _run_command(cmd, stderr=subprocess.STDOUT)
Brian Norris23c62e92018-11-14 12:25:51 -08001519 if output:
Brian Norris0c62a142018-12-11 13:24:29 -08001520 return HookFailure('kernel-doc errors/warnings:',
1521 items=output.splitlines())
Mike Frysinger8cf80812019-09-16 23:49:29 -04001522 return None
Brian Norris23c62e92018-11-14 12:25:51 -08001523
1524
Mike Frysingerae409522014-02-01 03:16:11 -05001525def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -07001526 """Makes sure kernel config changes are not mixed with code changes"""
1527 files = _get_affected_files(commit)
Mike Frysingerf252cfc2019-12-09 17:34:28 -05001528 if len(_filter_files(files, [r'chromeos/config'])) not in [0, len(files)]:
Olof Johanssona96810f2012-09-04 16:20:03 -07001529 return HookFailure('Changes to chromeos/config/ and regular files must '
1530 'be in separate commits:\n%s' % '\n'.join(files))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001531 return None
Anton Staaf815d6852011-08-22 10:08:45 -07001532
Mike Frysingerae409522014-02-01 03:16:11 -05001533
1534def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -07001535 """Checks that all JSON files are syntactically valid."""
Mike Frysinger908be682018-01-04 02:21:50 -05001536 ret = []
1537
1538 files = _filter_files(_get_affected_files(commit, relative=True),
1539 [r'.*\.json$'])
1540 for f in files:
1541 data = _get_file_content(f, commit)
Dale Curtis2975c432011-05-03 17:25:20 -07001542 try:
Mike Frysinger908be682018-01-04 02:21:50 -05001543 json.loads(data)
1544 except Exception as e:
1545 ret.append('%s: Invalid JSON: %s' % (f, e))
1546
1547 if ret:
1548 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001549 return None
Dale Curtis2975c432011-05-03 17:25:20 -07001550
1551
Mike Frysingerae409522014-02-01 03:16:11 -05001552def _check_manifests(_project, commit):
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001553 """Make sure Manifest files only have comments & DIST lines."""
1554 ret = []
Mike Frysinger52b537e2013-08-22 22:59:53 -04001555
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001556 manifests = _filter_files(_get_affected_files(commit, relative=True),
1557 [r'.*/Manifest$'])
1558 for path in manifests:
1559 data = _get_file_content(path, commit)
1560
1561 # Disallow blank files.
1562 if not data.strip():
1563 ret.append('%s: delete empty file' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001564 continue
1565
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001566 # Make sure the last newline isn't omitted.
1567 if data[-1] != '\n':
1568 ret.append('%s: missing trailing newline' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001569
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001570 # Do not allow leading or trailing blank lines.
1571 lines = data.splitlines()
1572 if not lines[0]:
1573 ret.append('%s: delete leading blank lines' % (path,))
1574 if not lines[-1]:
1575 ret.append('%s: delete trailing blank lines' % (path,))
1576
1577 for line in lines:
1578 # Disallow leading/trailing whitespace.
1579 if line != line.strip():
1580 ret.append('%s: remove leading/trailing whitespace: %s' % (path, line))
1581
1582 # Allow blank lines & comments.
1583 line = line.split('#', 1)[0]
1584 if not line:
1585 continue
1586
1587 # All other linse should start with DIST.
1588 if not line.startswith('DIST '):
1589 ret.append('%s: remove non-DIST lines: %s' % (path, line))
1590 break
1591
1592 if ret:
1593 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001594 return None
Mike Frysinger52b537e2013-08-22 22:59:53 -04001595
1596
Mike Frysingerae409522014-02-01 03:16:11 -05001597def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001598 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001599 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001600 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001601 BRANCH_RE = r'\nBRANCH=\S+'
1602
1603 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
1604 msg = ('Changelist description needs BRANCH field (after first line)\n'
1605 'E.g. BRANCH=none or BRANCH=link,snow')
1606 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001607 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001608
1609
Mike Frysinger45334bd2019-11-04 10:42:33 -05001610def _check_change_has_no_branch_field(_project, commit):
1611 """Verify 'BRANCH=' field does not exist in the commit message."""
1612 if commit == PRE_SUBMIT:
1613 return None
1614 BRANCH_RE = r'\nBRANCH=\S+'
1615
1616 if re.search(BRANCH_RE, _get_commit_desc(commit)):
1617 msg = 'This checkout does not use BRANCH= fields. Delete them.'
1618 return HookFailure(msg)
1619 return None
1620
1621
Mike Frysingerae409522014-02-01 03:16:11 -05001622def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001623 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001624 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001625 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001626 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1627
1628 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1629 msg = ('Changelist description needs Signed-off-by: field\n'
1630 'E.g. Signed-off-by: My Name <me@chromium.org>')
1631 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001632 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001633
1634
Mike Frysinger9ab64b12019-11-04 10:53:08 -05001635def _check_change_has_no_signoff_field(_project, commit):
1636 """Verify 'Signed-off-by:' field does not exist in the commit message."""
1637 if commit == PRE_SUBMIT:
1638 return None
1639 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1640
1641 if re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1642 msg = 'This checkout does not use Signed-off-by: tags. Delete them.'
1643 return HookFailure(msg)
1644 return None
1645
1646
Jon Salz3ee59de2012-08-18 13:54:22 +08001647def _run_project_hook_script(script, project, commit):
1648 """Runs a project hook script.
1649
1650 The script is run with the following environment variables set:
1651 PRESUBMIT_PROJECT: The affected project
1652 PRESUBMIT_COMMIT: The affected commit
1653 PRESUBMIT_FILES: A newline-separated list of affected files
1654
1655 The script is considered to fail if the exit code is non-zero. It should
1656 write an error message to stdout.
1657 """
1658 env = dict(os.environ)
Alex Deymo643ac4c2015-09-03 10:40:50 -07001659 env['PRESUBMIT_PROJECT'] = project.name
Jon Salz3ee59de2012-08-18 13:54:22 +08001660 env['PRESUBMIT_COMMIT'] = commit
1661
1662 # Put affected files in an environment variable
1663 files = _get_affected_files(commit)
1664 env['PRESUBMIT_FILES'] = '\n'.join(files)
1665
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001666 cmd_result = cros_build_lib.run(cmd=script,
1667 env=env,
1668 shell=True,
1669 print_cmd=False,
1670 input=os.devnull,
1671 stdout=True,
1672 encoding='utf-8',
1673 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001674 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001675 check=False)
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001676 if cmd_result.returncode:
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001677 stdout = cmd_result.stdout
Jon Salz7b618af2012-08-31 06:03:16 +08001678 if stdout:
1679 stdout = re.sub('(?m)^', ' ', stdout)
1680 return HookFailure('Hook script "%s" failed with code %d%s' %
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001681 (script, cmd_result.returncode,
Jon Salz3ee59de2012-08-18 13:54:22 +08001682 ':\n' + stdout if stdout else ''))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001683 return None
Jon Salz3ee59de2012-08-18 13:54:22 +08001684
1685
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001686def _check_project_prefix(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -05001687 """Require the commit message have a project specific prefix as needed."""
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001688
Brian Norris77608e12018-04-06 10:38:43 -07001689 files = _get_affected_files(commit, include_deletes=True, relative=True)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001690 prefix = os.path.commonprefix(files)
1691 prefix = os.path.dirname(prefix)
1692
1693 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07001694 if not prefix:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001695 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001696
1697 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07001698
1699 # The common files may all be within a subdirectory of the main project
1700 # directory, so walk up the tree until we find an alias file.
1701 # _get_affected_files() should return relative paths, but check against '/' to
1702 # ensure that this loop terminates even if it receives an absolute path.
1703 while prefix and prefix != '/':
1704 alias_file = os.path.join(prefix, '.project_alias')
1705
1706 # If an alias exists, use it.
1707 if os.path.isfile(alias_file):
1708 project_name = osutils.ReadFile(alias_file).strip()
1709
1710 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001711
1712 if not _get_commit_desc(commit).startswith(project_name + ': '):
1713 return HookFailure('The commit title for changes affecting only %s'
1714 ' should start with \"%s: \"'
1715 % (project_name, project_name))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001716 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001717
1718
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001719def _check_filepath_chartype(_project, commit):
1720 """Checks that FilePath::CharType stuff is not used."""
1721
1722 FILEPATH_REGEXP = re.compile('|'.join(
1723 [r'(?:base::)?FilePath::(?:Char|String|StringPiece)Type',
Satoru Takabayashi4ca37922018-08-08 10:16:38 +09001724 r'(?:base::)?FilePath::FromUTF8Unsafe',
1725 r'AsUTF8Unsafe',
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001726 r'FILE_PATH_LITERAL']))
1727 files = _filter_files(_get_affected_files(commit, relative=True),
1728 [r'.*\.(cc|h)$'])
1729
1730 errors = []
1731 for afile in files:
1732 for line_num, line in _get_file_diff(afile, commit):
1733 m = re.search(FILEPATH_REGEXP, line)
1734 if m:
1735 errors.append('%s, line %s has %s' % (afile, line_num, m.group(0)))
1736
1737 if errors:
1738 msg = 'Please assume FilePath::CharType is char (crbug.com/870621):'
1739 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001740 return None
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001741
1742
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001743def _check_exec_files(_project, commit):
1744 """Make +x bits on files."""
1745 # List of files that should never be +x.
1746 NO_EXEC = (
1747 'ChangeLog*',
1748 'COPYING',
1749 'make.conf',
1750 'make.defaults',
1751 'Manifest',
1752 'OWNERS',
1753 'package.use',
1754 'package.keywords',
1755 'package.mask',
1756 'parent',
1757 'README',
1758 'TODO',
1759 '.gitignore',
1760 '*.[achly]',
1761 '*.[ch]xx',
1762 '*.boto',
1763 '*.cc',
1764 '*.cfg',
1765 '*.conf',
1766 '*.config',
1767 '*.cpp',
1768 '*.css',
1769 '*.ebuild',
1770 '*.eclass',
Tatsuhisa Yamaguchi3b053632019-01-10 14:45:14 +09001771 '*.gn',
1772 '*.gni',
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001773 '*.gyp',
1774 '*.gypi',
1775 '*.htm',
1776 '*.html',
1777 '*.ini',
1778 '*.js',
1779 '*.json',
1780 '*.md',
1781 '*.mk',
1782 '*.patch',
1783 '*.policy',
1784 '*.proto',
1785 '*.raw',
1786 '*.rules',
1787 '*.service',
1788 '*.target',
1789 '*.txt',
1790 '*.xml',
1791 '*.yaml',
1792 )
1793
1794 def FinalName(obj):
1795 # If the file is being deleted, then the dst_file is not set.
1796 if obj.dst_file is None:
1797 return obj.src_file
1798 else:
1799 return obj.dst_file
1800
1801 bad_files = []
1802 files = _get_affected_files(commit, relative=True, full_details=True)
1803 for f in files:
1804 mode = int(f.dst_mode, 8)
1805 if not mode & 0o111:
1806 continue
1807 name = FinalName(f)
1808 for no_exec in NO_EXEC:
1809 if fnmatch.fnmatch(name, no_exec):
1810 bad_files.append(name)
1811 break
1812
1813 if bad_files:
1814 return HookFailure('These files should not be executable. '
1815 'Please `chmod -x` them.', bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001816 return None
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001817
1818
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001819# Base
1820
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001821# A list of hooks which are not project specific and check patch description
1822# (as opposed to patch body).
1823_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07001824 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07001825 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07001826 _check_change_has_test_field,
1827 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001828 _check_commit_message_style,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001829 _check_change_is_contribution,
Jack Neus8edbf642019-07-10 16:08:31 -06001830 _check_change_no_include_oem,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001831]
1832
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001833# A list of hooks that are not project-specific
1834_COMMON_HOOKS = [
Aviv Keshet5ac59522017-01-31 14:28:27 -08001835 _check_cros_license,
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001836 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05001837 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001838 _check_ebuild_licenses,
Mike Frysingercd363c82014-02-01 05:20:18 -05001839 _check_ebuild_virtual_pv,
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001840 _check_exec_files,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001841 _check_for_uprev,
Rahul Chaudhry09f61372015-07-31 17:14:26 -07001842 _check_gofmt,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001843 _check_layout_conf,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001844 _check_no_long_lines,
Keigo Oka4a09bd92019-05-07 14:01:00 +09001845 _check_no_new_gyp,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001846 _check_no_stray_whitespace,
Ryan Cui9b651632011-05-11 11:38:58 -07001847 _check_no_tabs,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001848 _check_portage_make_use_var,
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -06001849 _check_rustfmt,
Aviv Keshet5ac59522017-01-31 14:28:27 -08001850 _check_tabbed_indents,
Ryan Cui9b651632011-05-11 11:38:58 -07001851]
Ryan Cuiec4d6332011-05-02 14:15:25 -07001852
Ryan Cui1562fb82011-05-09 11:01:31 -07001853
Ryan Cui9b651632011-05-11 11:38:58 -07001854# A dictionary of project-specific hooks(callbacks), indexed by project name.
1855# dict[project] = [callback1, callback2]
1856_PROJECT_SPECIFIC_HOOKS = {
Mike Frysinger24dd3c52019-08-17 14:22:48 -04001857 'chromiumos/third_party/kernel': [_kernel_configcheck],
1858 'chromiumos/third_party/kernel-next': [_kernel_configcheck],
Ryan Cui9b651632011-05-11 11:38:58 -07001859}
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001860
Ryan Cui1562fb82011-05-09 11:01:31 -07001861
Ryan Cui9b651632011-05-11 11:38:58 -07001862# A dictionary of flags (keys) that can appear in the config file, and the hook
Mike Frysinger3554bc92015-03-11 04:59:21 -04001863# that the flag controls (value).
1864_HOOK_FLAGS = {
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001865 'clang_format_check': _check_clang_format,
Mike Frysingera7642f52015-03-25 18:31:42 -04001866 'checkpatch_check': _run_checkpatch,
Brian Norris23c62e92018-11-14 12:25:51 -08001867 'kerneldoc_check': _run_kerneldoc,
Ryan Cui9b651632011-05-11 11:38:58 -07001868 'stray_whitespace_check': _check_no_stray_whitespace,
Mike Frysingerff6c7d62015-03-24 13:49:46 -04001869 'json_check': _run_json_check,
Ryan Cui9b651632011-05-11 11:38:58 -07001870 'long_line_check': _check_no_long_lines,
Alex Deymof5792ce2015-08-24 22:50:08 -07001871 'cros_license_check': _check_cros_license,
1872 'aosp_license_check': _check_aosp_license,
Ryan Cui9b651632011-05-11 11:38:58 -07001873 'tab_check': _check_no_tabs,
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08001874 'tabbed_indent_required_check': _check_tabbed_indents,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001875 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001876 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07001877 'bug_field_check': _check_change_has_bug_field,
1878 'test_field_check': _check_change_has_test_field,
Steve Fung49ec7e92015-03-23 16:07:12 -07001879 'manifest_check': _check_manifests,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001880 'contribution_check': _check_change_is_contribution,
Mike Frysinger47bd1252018-06-11 12:12:20 -04001881 'project_prefix_check': _check_project_prefix,
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001882 'filepath_chartype_check': _check_filepath_chartype,
Ryan Cui9b651632011-05-11 11:38:58 -07001883}
1884
1885
Mike Frysinger3554bc92015-03-11 04:59:21 -04001886def _get_override_hooks(config):
1887 """Returns a set of hooks controlled by the current project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001888
1889 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08001890
1891 Args:
1892 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001893 """
1894 SECTION = 'Hook Overrides'
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001895 SECTION_OPTIONS = 'Hook Overrides Options'
Ryan Cui9b651632011-05-11 11:38:58 -07001896
Mike Frysinger56e8de02019-07-31 14:40:14 -04001897 valid_keys = set(_HOOK_FLAGS.keys())
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001898 hooks = _HOOK_FLAGS.copy()
Mike Frysinger380592f2020-02-03 15:27:16 -05001899 options = config.options(SECTION) if config.has_section(SECTION) else []
Mike Frysinger3554bc92015-03-11 04:59:21 -04001900
1901 enable_flags = []
Ryan Cui9b651632011-05-11 11:38:58 -07001902 disable_flags = []
Mike Frysinger380592f2020-02-03 15:27:16 -05001903 for flag in options:
Mike Frysinger3554bc92015-03-11 04:59:21 -04001904 if flag not in valid_keys:
1905 raise ValueError('Error: unknown key "%s" in hook section of "%s"' %
1906 (flag, _CONFIG_FILE))
1907
Ryan Cui9b651632011-05-11 11:38:58 -07001908 try:
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001909 enabled = config.getboolean(SECTION, flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001910 except ValueError as e:
Mike Frysinger3554bc92015-03-11 04:59:21 -04001911 raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' %
1912 (flag, _CONFIG_FILE, e))
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001913 if enabled:
1914 enable_flags.append(flag)
1915 else:
1916 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001917
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001918 # See if this hook has custom options.
1919 if enabled:
1920 try:
1921 options = config.get(SECTION_OPTIONS, flag)
1922 hooks[flag] = functools.partial(hooks[flag], options=options.split())
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001923 hooks[flag].__name__ = flag
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04001924 except (configparser.NoOptionError, configparser.NoSectionError):
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001925 pass
1926
1927 enabled_hooks = set(hooks[x] for x in enable_flags)
1928 disabled_hooks = set(hooks[x] for x in disable_flags)
Mike Frysinger45334bd2019-11-04 10:42:33 -05001929
Mike Frysinger9ab64b12019-11-04 10:53:08 -05001930 if _check_change_has_signoff_field not in enabled_hooks:
1931 enabled_hooks.add(_check_change_has_no_signoff_field)
Mike Frysinger45334bd2019-11-04 10:42:33 -05001932 if _check_change_has_branch_field not in enabled_hooks:
1933 enabled_hooks.add(_check_change_has_no_branch_field)
1934
Mike Frysinger3554bc92015-03-11 04:59:21 -04001935 return enabled_hooks, disabled_hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001936
1937
Jon Salz3ee59de2012-08-18 13:54:22 +08001938def _get_project_hook_scripts(config):
1939 """Returns a list of project-specific hook scripts.
1940
1941 Args:
1942 config: A ConfigParser for the project's config file.
1943 """
1944 SECTION = 'Hook Scripts'
1945 if not config.has_section(SECTION):
1946 return []
1947
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001948 return config.items(SECTION)
Jon Salz3ee59de2012-08-18 13:54:22 +08001949
1950
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001951def _get_project_hooks(project, presubmit):
Ryan Cui9b651632011-05-11 11:38:58 -07001952 """Returns a list of hooks that need to be run for a project.
1953
1954 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001955
1956 Args:
1957 project: A string, name of the project.
1958 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui9b651632011-05-11 11:38:58 -07001959 """
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04001960 config = configparser.RawConfigParser()
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001961 if not os.path.exists(_CONFIG_FILE):
Jon Salz3ee59de2012-08-18 13:54:22 +08001962 # Just use an empty config file
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04001963 config = configparser.RawConfigParser()
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001964 else:
1965 config.read(_CONFIG_FILE)
Jon Salz3ee59de2012-08-18 13:54:22 +08001966
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001967 if presubmit:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001968 hooks = _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001969 else:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001970 hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001971
Mike Frysinger3554bc92015-03-11 04:59:21 -04001972 enabled_hooks, disabled_hooks = _get_override_hooks(config)
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001973 hooks = [hook for hook in hooks if hook not in disabled_hooks]
1974
1975 # If a list is both in _COMMON_HOOKS and also enabled explicitly through an
1976 # override, keep the override only. Note that the override may end up being
1977 # a functools.partial, in which case we need to extract the .func to compare
1978 # it to the common hooks.
1979 unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks]
1980 hooks = [hook for hook in hooks if hook not in unwrapped_hooks]
1981
1982 hooks = list(enabled_hooks) + hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001983
1984 if project in _PROJECT_SPECIFIC_HOOKS:
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001985 hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project]
1986 if hook not in disabled_hooks)
Ryan Cui9b651632011-05-11 11:38:58 -07001987
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001988 for name, script in _get_project_hook_scripts(config):
1989 func = functools.partial(_run_project_hook_script, script)
1990 func.__name__ = name
1991 hooks.append(func)
Jon Salz3ee59de2012-08-18 13:54:22 +08001992
Ryan Cui9b651632011-05-11 11:38:58 -07001993 return hooks
1994
1995
Alex Deymo643ac4c2015-09-03 10:40:50 -07001996def _run_project_hooks(project_name, proj_dir=None,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001997 commit_list=None, presubmit=False):
Ryan Cui1562fb82011-05-09 11:01:31 -07001998 """For each project run its project specific hook from the hooks dictionary.
1999
2000 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002001 project_name: The name of project to run hooks for.
Doug Anderson44a644f2011-11-02 10:37:37 -07002002 proj_dir: If non-None, this is the directory the project is in. If None,
2003 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07002004 commit_list: A list of commits to run hooks against. If None or empty list
2005 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002006 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui1562fb82011-05-09 11:01:31 -07002007
2008 Returns:
2009 Boolean value of whether any errors were ecountered while running the hooks.
2010 """
Doug Anderson44a644f2011-11-02 10:37:37 -07002011 if proj_dir is None:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002012 proj_dirs = _run_command(
2013 ['repo', 'forall', project_name, '-c', 'pwd']).split()
Mike Frysingere52b1bc2019-09-16 23:45:41 -04002014 if not proj_dirs:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002015 print('%s cannot be found.' % project_name, file=sys.stderr)
David James2edd9002013-10-11 14:09:19 -07002016 print('Please specify a valid project.', file=sys.stderr)
2017 return True
2018 if len(proj_dirs) > 1:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002019 print('%s is associated with multiple directories.' % project_name,
David James2edd9002013-10-11 14:09:19 -07002020 file=sys.stderr)
2021 print('Please specify a directory to help disambiguate.', file=sys.stderr)
2022 return True
2023 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07002024
Ryan Cuiec4d6332011-05-02 14:15:25 -07002025 pwd = os.getcwd()
2026 # hooks assume they are run from the root of the project
2027 os.chdir(proj_dir)
2028
Mike Frysingered1b95a2019-12-12 19:04:51 -05002029 color = terminal.Color()
2030
Alex Deymo643ac4c2015-09-03 10:40:50 -07002031 remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref',
2032 '--symbolic-full-name', '@{u}']).strip()
2033 if not remote_branch:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002034 print("Your project %s doesn't track any remote repo." % project_name,
Alex Deymo643ac4c2015-09-03 10:40:50 -07002035 file=sys.stderr)
2036 remote = None
2037 else:
Josh Pratt15d13ab2018-08-13 11:52:48 +10002038 branch_items = remote_branch.split('/', 1)
2039 if len(branch_items) != 2:
2040 PrintErrorForProject(
2041 project_name,
2042 HookFailure(
2043 'Cannot get remote and branch name (%s)' % remote_branch))
2044 os.chdir(pwd)
2045 return True
2046 remote, _branch = branch_items
Alex Deymo643ac4c2015-09-03 10:40:50 -07002047
2048 project = Project(name=project_name, dir=proj_dir, remote=remote)
2049
Doug Anderson14749562013-06-26 13:38:29 -07002050 if not commit_list:
2051 try:
2052 commit_list = _get_commits()
2053 except VerifyException as e:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002054 PrintErrorForProject(project.name, HookFailure(str(e)))
Doug Anderson14749562013-06-26 13:38:29 -07002055 os.chdir(pwd)
2056 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07002057
Alex Deymo643ac4c2015-09-03 10:40:50 -07002058 hooks = _get_project_hooks(project.name, presubmit)
Ryan Cui1562fb82011-05-09 11:01:31 -07002059 error_found = False
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002060 commit_count = len(commit_list)
Mike Frysingerb99b3772019-08-17 14:19:44 -04002061 hook_count = len(hooks)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002062 for i, commit in enumerate(commit_list):
Mike Frysingerb2496652019-09-12 23:35:46 -04002063 CACHE.clear()
2064
Mike Frysingered1b95a2019-12-12 19:04:51 -05002065 desc = _get_commit_desc(commit)
2066 print('[%s %i/%i %s] %s' %
2067 (color.Color(color.CYAN, 'COMMIT'), i + 1, commit_count, commit[0:12],
2068 desc.splitlines()[0]))
2069
Mike Frysingerb99b3772019-08-17 14:19:44 -04002070 for h, hook in enumerate(hooks):
Mike Frysingered1b95a2019-12-12 19:04:51 -05002071 output = ('[%s %i/%i PRESUBMIT.cfg] %s' %
2072 (color.Color(color.YELLOW, 'RUNNING'), h + 1, hook_count,
2073 hook.__name__))
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002074 print(output, end='\r')
2075 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002076 hook_error = hook(project, commit)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002077 print(' ' * len(output), end='\r')
2078 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002079 if hook_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002080 if not isinstance(hook_error, list):
2081 hook_error = [hook_error]
2082 PrintErrorsForCommit(color, hook, project.name, hook_error)
Ryan Cui1562fb82011-05-09 11:01:31 -07002083 error_found = True
Don Garrettdba548a2011-05-05 15:17:14 -07002084
Ryan Cuiec4d6332011-05-02 14:15:25 -07002085 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07002086 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002087
Mike Frysingerae409522014-02-01 03:16:11 -05002088
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002089# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002090
Ryan Cui1562fb82011-05-09 11:01:31 -07002091
Mike Frysingerae409522014-02-01 03:16:11 -05002092def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08002093 """Main function invoked directly by repo.
2094
2095 This function will exit directly upon error so that repo doesn't print some
2096 obscure error message.
2097
2098 Args:
2099 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07002100 worktree_list: A list of directories. It should be the same length as
2101 project_list, so that each entry in project_list matches with a directory
2102 in worktree_list. If None, we will attempt to calculate the directories
2103 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08002104 kwargs: Leave this here for forward-compatibility.
2105 """
Mike Frysingered1b95a2019-12-12 19:04:51 -05002106 start_time = datetime.datetime.now()
Ryan Cui1562fb82011-05-09 11:01:31 -07002107 found_error = False
David James2edd9002013-10-11 14:09:19 -07002108 if not worktree_list:
2109 worktree_list = [None] * len(project_list)
2110 for project, worktree in zip(project_list, worktree_list):
2111 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07002112 found_error = True
2113
Mike Frysingered1b95a2019-12-12 19:04:51 -05002114 end_time = datetime.datetime.now()
2115 color = terminal.Color()
Mike Frysingerae409522014-02-01 03:16:11 -05002116 if found_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002117 msg = ('%s: Preupload failed due to above error(s).\n'
Ryan Cui9b651632011-05-11 11:38:58 -07002118 '- To disable some source style checks, and for other hints, see '
Mike Frysingered1b95a2019-12-12 19:04:51 -05002119 '<checkout_dir>/src/repohooks/README.md\n'
2120 "- To upload only current project, run 'repo upload .'" %
2121 (color.Color(color.RED, 'FATAL'),))
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04002122 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07002123 sys.exit(1)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002124 else:
2125 msg = ('[%s] repohooks passed in %s' %
2126 (color.Color(color.GREEN, 'PASSED'), end_time - start_time))
2127 print(msg)
Anush Elangovan63afad72011-03-23 00:41:27 -07002128
Ryan Cui1562fb82011-05-09 11:01:31 -07002129
Doug Anderson44a644f2011-11-02 10:37:37 -07002130def _identify_project(path):
2131 """Identify the repo project associated with the given path.
2132
2133 Returns:
2134 A string indicating what project is associated with the path passed in or
2135 a blank string upon failure.
2136 """
2137 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002138 stderr=True, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002139
2140
Mike Frysinger55f85b52014-12-18 14:45:21 -05002141def direct_main(argv):
Doug Anderson44a644f2011-11-02 10:37:37 -07002142 """Run hooks directly (outside of the context of repo).
2143
Doug Anderson44a644f2011-11-02 10:37:37 -07002144 Args:
Mike Frysinger55f85b52014-12-18 14:45:21 -05002145 argv: The command line args to process
Doug Anderson44a644f2011-11-02 10:37:37 -07002146
2147 Returns:
2148 0 if no pre-upload failures, 1 if failures.
2149
2150 Raises:
2151 BadInvocation: On some types of invocation errors.
2152 """
Mike Frysinger66142932014-12-18 14:55:57 -05002153 parser = commandline.ArgumentParser(description=__doc__)
2154 parser.add_argument('--dir', default=None,
2155 help='The directory that the project lives in. If not '
2156 'specified, use the git project root based on the cwd.')
2157 parser.add_argument('--project', default=None,
2158 help='The project repo path; this can affect how the '
2159 'hooks get run, since some hooks are project-specific. '
2160 'For chromite this is chromiumos/chromite. If not '
2161 'specified, the repo tool will be used to figure this '
2162 'out based on the dir.')
2163 parser.add_argument('--rerun-since', default=None,
Vadim Bendebury75447b92018-01-10 12:06:01 -08002164 help='Rerun hooks on old commits since some point '
2165 'in the past. The argument could be a date (should '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002166 "match git log's concept of a date, e.g. 2012-06-20), "
Vadim Bendebury75447b92018-01-10 12:06:01 -08002167 'or a SHA1, or just a number of commits to check (from 1 '
2168 'to 99). This option is mutually exclusive with '
2169 '--pre-submit.')
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002170 parser.add_argument('--pre-submit', action='store_true',
Mike Frysinger66142932014-12-18 14:55:57 -05002171 help='Run the check against the pending commit. '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002172 "This option should be used at the 'git commit' "
2173 "phase as opposed to 'repo upload'. This option "
Mike Frysinger66142932014-12-18 14:55:57 -05002174 'is mutually exclusive with --rerun-since.')
2175 parser.add_argument('commits', nargs='*',
2176 help='Check specific commits')
2177 opts = parser.parse_args(argv)
Doug Anderson44a644f2011-11-02 10:37:37 -07002178
Doug Anderson14749562013-06-26 13:38:29 -07002179 if opts.rerun_since:
Mike Frysinger66142932014-12-18 14:55:57 -05002180 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002181 raise BadInvocation("Can't pass commits and use rerun-since: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002182 ' '.join(opts.commits))
Doug Anderson14749562013-06-26 13:38:29 -07002183
Vadim Bendebury75447b92018-01-10 12:06:01 -08002184 if len(opts.rerun_since) < 3 and opts.rerun_since.isdigit():
2185 # This must be the number of commits to check. We don't expect the user
2186 # to want to check more than 99 commits.
2187 limit = '-n%s' % opts.rerun_since
2188 elif git.IsSHA1(opts.rerun_since, False):
2189 limit = '%s..' % opts.rerun_since
2190 else:
2191 # This better be a date.
2192 limit = '--since=%s' % opts.rerun_since
2193 cmd = ['git', 'log', limit, '--pretty=%H']
Doug Anderson14749562013-06-26 13:38:29 -07002194 all_commits = _run_command(cmd).splitlines()
2195 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
2196
2197 # Eliminate chrome-bot commits but keep ordering the same...
2198 bot_commits = set(bot_commits)
Mike Frysinger66142932014-12-18 14:55:57 -05002199 opts.commits = [c for c in all_commits if c not in bot_commits]
Doug Anderson14749562013-06-26 13:38:29 -07002200
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002201 if opts.pre_submit:
2202 raise BadInvocation('rerun-since and pre-submit can not be '
2203 'used together')
2204 if opts.pre_submit:
Mike Frysinger66142932014-12-18 14:55:57 -05002205 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002206 raise BadInvocation("Can't pass commits and use pre-submit: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002207 ' '.join(opts.commits))
2208 opts.commits = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07002209
2210 # Check/normlaize git dir; if unspecified, we'll use the root of the git
2211 # project from CWD
2212 if opts.dir is None:
2213 git_dir = _run_command(['git', 'rev-parse', '--git-dir'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002214 stderr=True).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002215 if not git_dir:
2216 raise BadInvocation('The current directory is not part of a git project.')
2217 opts.dir = os.path.dirname(os.path.abspath(git_dir))
2218 elif not os.path.isdir(opts.dir):
2219 raise BadInvocation('Invalid dir: %s' % opts.dir)
2220 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
2221 raise BadInvocation('Not a git directory: %s' % opts.dir)
2222
2223 # Identify the project if it wasn't specified; this _requires_ the repo
2224 # tool to be installed and for the project to be part of a repo checkout.
2225 if not opts.project:
2226 opts.project = _identify_project(opts.dir)
2227 if not opts.project:
2228 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
2229
Doug Anderson14749562013-06-26 13:38:29 -07002230 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Mike Frysinger66142932014-12-18 14:55:57 -05002231 commit_list=opts.commits,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002232 presubmit=opts.pre_submit)
Doug Anderson44a644f2011-11-02 10:37:37 -07002233 if found_error:
2234 return 1
2235 return 0
2236
2237
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002238if __name__ == '__main__':
Mike Frysinger55f85b52014-12-18 14:45:21 -05002239 sys.exit(direct_main(sys.argv[1:]))