blob: 4c6b783ca94dc2d765e5714fbdcfa53037672175 [file] [log] [blame]
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08001#!/usr/bin/env python2
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002# -*- coding: utf-8 -*-
Jon Salz98255932012-08-18 14:48:02 +08003# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
Mike Frysingerae409522014-02-01 03:16:11 -05007"""Presubmit checks to run when doing `repo upload`.
8
9You can add new checks by adding a functions to the HOOKS constants.
10"""
11
Mike Frysinger09d6a3d2013-10-08 22:21:03 -040012from __future__ import print_function
13
Filipe Brandenburger4b542b12015-10-09 12:46:31 -070014import argparse
Alex Deymo643ac4c2015-09-03 10:40:50 -070015import collections
Ryan Cui9b651632011-05-11 11:38:58 -070016import ConfigParser
Daniel Erate3ea3fc2015-02-13 15:27:52 -070017import fnmatch
Jon Salz3ee59de2012-08-18 13:54:22 +080018import functools
Dale Curtis2975c432011-05-03 17:25:20 -070019import json
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070020import os
Ryan Cuiec4d6332011-05-02 14:15:25 -070021import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070022import sys
Peter Ammon811f6702014-06-12 15:45:38 -070023import stat
Aviv Keshet5ac59522017-01-31 14:28:27 -080024import StringIO
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070025
Ryan Cui1562fb82011-05-09 11:01:31 -070026from errors import (VerifyException, HookFailure, PrintErrorForProject,
27 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070028
Mike Frysinger6850d512018-05-21 12:12:14 -040029# If repo imports us, the __name__ will be __builtin__, and the cwd will be in
30# the top level of the checkout (i.e. $CHROMEOS_CHECKOUT). chromite will be in
31# that directory, so add it to our path. This works whether we're running the
32# repo in $CHROMEOS_CHECKOUT/.repo/repo/ or a custom version in a completely
33# different tree.
34if __name__ == '__builtin__':
35 sys.path.insert(0, os.getcwd())
36
37# If we're run directly, we'll find chromite relative to the repohooks dir in
38# $CHROMEOS_CHECKOUT/src/repohooks, so go up two dirs.
39if __name__ == '__main__':
David Jamesc3b68b32013-04-03 09:17:03 -070040 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
41
Mike Frysinger66142932014-12-18 14:55:57 -050042from chromite.lib import commandline
Aviv Keshet5ac59522017-01-31 14:28:27 -080043from chromite.lib import constants
Rahul Chaudhry0e515342015-08-07 12:00:43 -070044from chromite.lib import cros_build_lib
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050045from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070046from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070047from chromite.lib import patch
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040048from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070049
Vadim Bendebury2b62d742014-06-22 13:14:51 -070050PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070051
52COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050053 # C++ and friends
54 r".*\.c$", r".*\.cc$", r".*\.cpp$", r".*\.h$", r".*\.m$", r".*\.mm$",
55 r".*\.inl$", r".*\.asm$", r".*\.hxx$", r".*\.hpp$", r".*\.s$", r".*\.S$",
56 # Scripts
57 r".*\.js$", r".*\.py$", r".*\.sh$", r".*\.rb$", r".*\.pl$", r".*\.pm$",
58 # No extension at all, note that ALL CAPS files are black listed in
59 # COMMON_EXCLUDED_LIST below.
60 r"(^|.*[\\\/])[^.]+$",
61 # Other
62 r".*\.java$", r".*\.mk$", r".*\.am$",
Brian Norrisfdbac8e2016-06-16 11:09:05 -070063 r".*\.policy$", r".*\.conf$",
Ryan Cuiec4d6332011-05-02 14:15:25 -070064]
65
Ryan Cui1562fb82011-05-09 11:01:31 -070066
Ryan Cuiec4d6332011-05-02 14:15:25 -070067COMMON_EXCLUDED_PATHS = [
Daniel Erate3ea3fc2015-02-13 15:27:52 -070068 # For ebuild trees, ignore any caches and manifest data.
Mike Frysingerae409522014-02-01 03:16:11 -050069 r".*/Manifest$",
70 r".*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$",
Doug Anderson5bfb6792011-10-25 16:45:41 -070071
Daniel Erate3ea3fc2015-02-13 15:27:52 -070072 # Ignore profiles data (like overlay-tegra2/profiles).
Mike Frysinger94a670c2014-09-19 12:46:26 -040073 r"(^|.*/)overlay-.*/profiles/.*",
Mike Frysinger98638102014-08-28 00:15:08 -040074 r"^profiles/.*$",
75
C Shapiro8f90e9b2017-06-28 09:54:50 -060076 # Ignore config files in ebuild setup.
77 r"(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*",
78 r"^chromeos-base/chromeos-bsp.*/files/.*",
79
Daniel Erate3ea3fc2015-02-13 15:27:52 -070080 # Ignore minified js and jquery.
Mike Frysingerae409522014-02-01 03:16:11 -050081 r".*\.min\.js",
82 r".*jquery.*\.js",
Mike Frysinger33a458d2014-03-03 17:00:51 -050083
84 # Ignore license files as the content is often taken verbatim.
Daniel Erate3ea3fc2015-02-13 15:27:52 -070085 r".*/licenses/.*",
Ryan Cuiec4d6332011-05-02 14:15:25 -070086]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070087
Ken Turnerd07564b2018-02-08 17:57:59 +110088LICENSE_EXCLUDED_PATHS = [
89 r".*/OWNERS$",
90]
Ryan Cui1562fb82011-05-09 11:01:31 -070091
Ryan Cui9b651632011-05-11 11:38:58 -070092_CONFIG_FILE = 'PRESUBMIT.cfg'
93
94
Daniel Erate3ea3fc2015-02-13 15:27:52 -070095# File containing wildcards, one per line, matching files that should be
96# excluded from presubmit checks. Lines beginning with '#' are ignored.
97_IGNORE_FILE = '.presubmitignore'
98
99
Doug Anderson44a644f2011-11-02 10:37:37 -0700100# Exceptions
101
102
103class BadInvocation(Exception):
104 """An Exception indicating a bad invocation of the program."""
105 pass
106
107
Ryan Cui1562fb82011-05-09 11:01:31 -0700108# General Helpers
109
Sean Paulba01d402011-05-05 11:36:23 -0400110
Alex Deymo643ac4c2015-09-03 10:40:50 -0700111Project = collections.namedtuple('Project', ['name', 'dir', 'remote'])
112
113
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700114# pylint: disable=redefined-builtin
115def _run_command(cmd, cwd=None, input=None,
116 redirect_stderr=False, combine_stdout_stderr=False):
Doug Anderson44a644f2011-11-02 10:37:37 -0700117 """Executes the passed in command and returns raw stdout output.
118
119 Args:
120 cmd: The command to run; should be a list of strings.
121 cwd: The directory to switch to for running the command.
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700122 input: The data to pipe into this command through stdin. If a file object
123 or file descriptor, stdin will be connected directly to that.
124 redirect_stderr: Redirect stderr away from console.
125 combine_stdout_stderr: Combines stdout and stderr streams into stdout.
Doug Anderson44a644f2011-11-02 10:37:37 -0700126
127 Returns:
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700128 The stdout from the process (discards stderr and returncode).
Doug Anderson44a644f2011-11-02 10:37:37 -0700129 """
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700130 return cros_build_lib.RunCommand(cmd=cmd,
131 cwd=cwd,
132 print_cmd=False,
133 input=input,
134 stdout_to_pipe=True,
135 redirect_stderr=redirect_stderr,
136 combine_stdout_stderr=combine_stdout_stderr,
137 error_code_ok=True).output
138# pylint: enable=redefined-builtin
Ryan Cui72834d12011-05-05 14:51:33 -0700139
Ryan Cui1562fb82011-05-09 11:01:31 -0700140
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700141def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700142 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700143 if __name__ == '__main__':
144 # Works when file is run on its own (__file__ is defined)...
145 return os.path.abspath(os.path.dirname(__file__))
146 else:
147 # We need to do this when we're run through repo. Since repo executes
148 # us with execfile(), we don't get __file__ defined.
149 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
150 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700151
Ryan Cui1562fb82011-05-09 11:01:31 -0700152
Ryan Cuiec4d6332011-05-02 14:15:25 -0700153def _match_regex_list(subject, expressions):
154 """Try to match a list of regular expressions to a string.
155
156 Args:
157 subject: The string to match regexes on
158 expressions: A list of regular expressions to check for matches with.
159
160 Returns:
161 Whether the passed in subject matches any of the passed in regexes.
162 """
163 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500164 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700165 return True
166 return False
167
Ryan Cui1562fb82011-05-09 11:01:31 -0700168
Mike Frysingerae409522014-02-01 03:16:11 -0500169def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700170 """Filter out files based on the conditions passed in.
171
172 Args:
173 files: list of filepaths to filter
174 include_list: list of regex that when matched with a file path will cause it
175 to be added to the output list unless the file is also matched with a
176 regex in the exclude_list.
177 exclude_list: list of regex that when matched with a file will prevent it
178 from being added to the output list, even if it is also matched with a
179 regex in the include_list.
180
181 Returns:
182 A list of filepaths that contain files matched in the include_list and not
183 in the exclude_list.
184 """
185 filtered = []
186 for f in files:
187 if (_match_regex_list(f, include_list) and
188 not _match_regex_list(f, exclude_list)):
189 filtered.append(f)
190 return filtered
191
Ryan Cuiec4d6332011-05-02 14:15:25 -0700192
193# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700194
195
Ryan Cui4725d952011-05-05 15:41:19 -0700196def _get_upstream_branch():
197 """Returns the upstream tracking branch of the current branch.
198
199 Raises:
200 Error if there is no tracking branch
201 """
202 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
203 current_branch = current_branch.replace('refs/heads/', '')
204 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700205 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700206
207 cfg_option = 'branch.' + current_branch + '.%s'
208 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
209 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
210 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700211 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700212
213 return full_upstream.replace('heads', 'remotes/' + remote)
214
Ryan Cui1562fb82011-05-09 11:01:31 -0700215
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700216def _get_patch(commit):
217 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700218 if commit == PRE_SUBMIT:
219 return _run_command(['git', 'diff', '--cached', 'HEAD'])
220 else:
221 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700222
Ryan Cui1562fb82011-05-09 11:01:31 -0700223
Jon Salz98255932012-08-18 14:48:02 +0800224def _try_utf8_decode(data):
225 """Attempts to decode a string as UTF-8.
226
227 Returns:
228 The decoded Unicode object, or the original string if parsing fails.
229 """
230 try:
231 return unicode(data, 'utf-8', 'strict')
232 except UnicodeDecodeError:
233 return data
234
235
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500236def _get_file_content(path, commit):
237 """Returns the content of a file at a specific commit.
238
239 We can't rely on the file as it exists in the filesystem as people might be
240 uploading a series of changes which modifies the file multiple times.
241
242 Note: The "content" of a symlink is just the target. So if you're expecting
243 a full file, you should check that first. One way to detect is that the
244 content will not have any newlines.
245 """
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700246 if commit == PRE_SUBMIT:
247 return _run_command(['git', 'diff', 'HEAD', path])
248 else:
Mike Frysingerd0523442018-01-03 17:05:29 -0500249 # Make sure people don't accidentally pass in full paths which will never
250 # work. You need to use relative=True with _get_affected_files.
251 if path.startswith('/'):
252 raise ValueError('_get_file_content must be called with relative paths: '
253 + path)
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700254 return _run_command(['git', 'show', '%s:%s' % (commit, path)])
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500255
256
Mike Frysingerae409522014-02-01 03:16:11 -0500257def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700258 """Returns a list of (linenum, lines) tuples that the commit touched."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700259 if commit == PRE_SUBMIT:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800260 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD',
261 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700262 else:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800263 command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit,
264 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700265 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700266
267 new_lines = []
268 line_num = 0
269 for line in output.splitlines():
270 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
271 if m:
272 line_num = int(m.groups(1)[0])
273 continue
274 if line.startswith('+') and not line.startswith('++'):
Jon Salz98255932012-08-18 14:48:02 +0800275 new_lines.append((line_num, _try_utf8_decode(line[1:])))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700276 if not line.startswith('-'):
277 line_num += 1
278 return new_lines
279
Ryan Cui1562fb82011-05-09 11:01:31 -0700280
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700281def _get_ignore_wildcards(directory, cache):
282 """Get wildcards listed in a directory's _IGNORE_FILE.
283
284 Args:
285 directory: A string containing a directory path.
286 cache: A dictionary (opaque to caller) caching previously-read wildcards.
287
288 Returns:
289 A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE
290 wasn't present.
291 """
292 # In the cache, keys are directories and values are lists of wildcards from
293 # _IGNORE_FILE within those directories (and empty if no file was present).
294 if directory not in cache:
295 wildcards = []
296 dotfile_path = os.path.join(directory, _IGNORE_FILE)
297 if os.path.exists(dotfile_path):
298 # TODO(derat): Consider using _get_file_content() to get the file as of
299 # this commit instead of the on-disk version. This may have a noticeable
300 # performance impact, as each call to _get_file_content() runs git.
301 with open(dotfile_path, 'r') as dotfile:
302 for line in dotfile.readlines():
303 line = line.strip()
304 if line.startswith('#'):
305 continue
306 if line.endswith('/'):
307 line += '*'
308 wildcards.append(line)
309 cache[directory] = wildcards
310
311 return cache[directory]
312
313
314def _path_is_ignored(path, cache):
315 """Check whether a path is ignored by _IGNORE_FILE.
316
317 Args:
318 path: A string containing a path.
319 cache: A dictionary (opaque to caller) caching previously-read wildcards.
320
321 Returns:
322 True if a file named _IGNORE_FILE in one of the passed-in path's parent
323 directories contains a wildcard matching the path.
324 """
325 # Skip ignore files.
326 if os.path.basename(path) == _IGNORE_FILE:
327 return True
328
329 path = os.path.abspath(path)
330 base = os.getcwd()
331
332 prefix = os.path.dirname(path)
333 while prefix.startswith(base):
334 rel_path = path[len(prefix) + 1:]
335 for wildcard in _get_ignore_wildcards(prefix, cache):
336 if fnmatch.fnmatch(rel_path, wildcard):
337 return True
338 prefix = os.path.dirname(prefix)
339
340 return False
341
342
Mike Frysinger292b45d2014-11-25 01:17:10 -0500343def _get_affected_files(commit, include_deletes=False, relative=False,
344 include_symlinks=False, include_adds=True,
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700345 full_details=False, use_ignore_files=True):
Peter Ammon811f6702014-06-12 15:45:38 -0700346 """Returns list of file paths that were modified/added, excluding symlinks.
347
348 Args:
349 commit: The commit
350 include_deletes: If true, we'll include deleted files in the result
351 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500352 include_symlinks: If true, we'll include symlinks in the result
353 include_adds: If true, we'll include new files in the result
354 full_details: If False, return filenames, else return structured results.
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700355 use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files.
Peter Ammon811f6702014-06-12 15:45:38 -0700356
357 Returns:
358 A list of modified/added (and perhaps deleted) files
359 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500360 if not relative and full_details:
361 raise ValueError('full_details only supports relative paths currently')
362
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700363 if commit == PRE_SUBMIT:
364 return _run_command(['git', 'diff-index', '--cached',
365 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500366
367 path = os.getcwd()
368 files = git.RawDiff(path, '%s^!' % commit)
369
370 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500371 if not include_symlinks:
372 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500373
374 if not include_deletes:
375 files = [x for x in files if x.status != 'D']
376
Mike Frysinger292b45d2014-11-25 01:17:10 -0500377 if not include_adds:
378 files = [x for x in files if x.status != 'A']
379
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700380 if use_ignore_files:
381 cache = {}
382 is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache)
383 files = [x for x in files if not is_ignored(x)]
384
Mike Frysinger292b45d2014-11-25 01:17:10 -0500385 if full_details:
386 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500387 return files
388 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500389 # Caller only cares about filenames.
390 files = [x.dst_file if x.dst_file else x.src_file for x in files]
391 if relative:
392 return files
393 else:
394 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700395
396
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700397def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700398 """Returns a list of commits for this review."""
Ryan Cui4725d952011-05-05 15:41:19 -0700399 cmd = ['git', 'log', '%s..' % _get_upstream_branch(), '--format=%H']
Ryan Cui72834d12011-05-05 14:51:33 -0700400 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700401
Ryan Cui1562fb82011-05-09 11:01:31 -0700402
Ryan Cuiec4d6332011-05-02 14:15:25 -0700403def _get_commit_desc(commit):
404 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700405 if commit == PRE_SUBMIT:
406 return ''
Sean Paul23a2c582011-05-06 13:10:44 -0400407 return _run_command(['git', 'log', '--format=%s%n%n%b', commit + '^!'])
Ryan Cuiec4d6332011-05-02 14:15:25 -0700408
409
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800410def _check_lines_in_diff(commit, files, check_callable, error_description):
411 """Checks given file for errors via the given check.
412
413 This is a convenience function for common per-line checks. It goes through all
414 files and returns a HookFailure with the error description listing all the
415 failures.
416
417 Args:
418 commit: The commit we're working on.
419 files: The files to check.
420 check_callable: A callable that takes a line and returns True if this line
421 _fails_ the check.
422 error_description: A string describing the error.
423 """
424 errors = []
425 for afile in files:
426 for line_num, line in _get_file_diff(afile, commit):
427 if check_callable(line):
428 errors.append('%s, line %s' % (afile, line_num))
429 if errors:
430 return HookFailure(error_description, errors)
431
432
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900433def _parse_common_inclusion_options(options):
434 """Parses common hook options for including/excluding files.
435
436 Args:
437 options: Option string list.
438
439 Returns:
440 (included, excluded) where each one is a list of regex strings.
441 """
442 parser = argparse.ArgumentParser()
443 parser.add_argument('--exclude_regex', action='append')
444 parser.add_argument('--include_regex', action='append')
445 opts = parser.parse_args(options)
446 included = opts.include_regex or []
447 excluded = opts.exclude_regex or []
448 return included, excluded
449
450
Ryan Cuiec4d6332011-05-02 14:15:25 -0700451# Common Hooks
452
Ryan Cui1562fb82011-05-09 11:01:31 -0700453
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900454def _check_no_long_lines(_project, commit, options=()):
Mike Frysinger55f85b52014-12-18 14:45:21 -0500455 """Checks there are no lines longer than MAX_LEN in any of the text files."""
456
Ryan Cuiec4d6332011-05-02 14:15:25 -0700457 MAX_LEN = 80
Jon Salz98255932012-08-18 14:48:02 +0800458 SKIP_REGEXP = re.compile('|'.join([
459 r'https?://',
460 r'^#\s*(define|include|import|pragma|if|endif)\b']))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700461
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900462 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700463 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900464 included + COMMON_INCLUDED_PATHS,
465 excluded + COMMON_EXCLUDED_PATHS)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700466
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900467 errors = []
Ryan Cuiec4d6332011-05-02 14:15:25 -0700468 for afile in files:
469 for line_num, line in _get_file_diff(afile, commit):
470 # Allow certain lines to exceed the maxlen rule.
Mike Frysingerae409522014-02-01 03:16:11 -0500471 if len(line) <= MAX_LEN or SKIP_REGEXP.search(line):
Jon Salz98255932012-08-18 14:48:02 +0800472 continue
473
474 errors.append('%s, line %s, %s chars' % (afile, line_num, len(line)))
475 if len(errors) == 5: # Just show the first 5 errors.
476 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700477
478 if errors:
479 msg = 'Found lines longer than %s characters (first 5 shown):' % MAX_LEN
Ryan Cui1562fb82011-05-09 11:01:31 -0700480 return HookFailure(msg, errors)
481
Ryan Cuiec4d6332011-05-02 14:15:25 -0700482
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900483def _check_no_stray_whitespace(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700484 """Checks that there is no stray whitespace at source lines end."""
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900485 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700486 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900487 included + COMMON_INCLUDED_PATHS,
488 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800489 return _check_lines_in_diff(commit, files,
490 lambda line: line.rstrip() != line,
491 'Found line ending with white space in:')
Ryan Cui1562fb82011-05-09 11:01:31 -0700492
Ryan Cuiec4d6332011-05-02 14:15:25 -0700493
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900494def _check_no_tabs(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700495 """Checks there are no unexpanded tabs."""
Mike Frysingercd134512017-10-26 04:36:33 -0400496 # Don't add entire repos here. Update the PRESUBMIT.cfg in each repo instead.
497 # We only whitelist known specific filetypes here that show up in all repos.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700498 TAB_OK_PATHS = [
Ryan Cuiec4d6332011-05-02 14:15:25 -0700499 r".*\.ebuild$",
500 r".*\.eclass$",
Elly Jones5ab34192011-11-15 14:57:06 -0500501 r".*/[M|m]akefile$",
502 r".*\.mk$"
Ryan Cuiec4d6332011-05-02 14:15:25 -0700503 ]
504
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900505 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700506 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900507 included + COMMON_INCLUDED_PATHS,
508 excluded + COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800509 return _check_lines_in_diff(commit, files,
510 lambda line: '\t' in line,
511 'Found a tab character in:')
Ryan Cuiec4d6332011-05-02 14:15:25 -0700512
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800513
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900514def _check_tabbed_indents(_project, commit, options=()):
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800515 """Checks that indents use tabs only."""
516 TABS_REQUIRED_PATHS = [
517 r".*\.ebuild$",
518 r".*\.eclass$",
519 ]
520 LEADING_SPACE_RE = re.compile('[\t]* ')
521
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900522 included, excluded = _parse_common_inclusion_options(options)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800523 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900524 included + TABS_REQUIRED_PATHS,
525 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800526 return _check_lines_in_diff(
527 commit, files,
528 lambda line: LEADING_SPACE_RE.match(line) is not None,
529 'Found a space in indentation (must be all tabs):')
Ryan Cui1562fb82011-05-09 11:01:31 -0700530
Ryan Cuiec4d6332011-05-02 14:15:25 -0700531
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700532def _check_gofmt(_project, commit):
533 """Checks that Go files are formatted with gofmt."""
534 errors = []
535 files = _filter_files(_get_affected_files(commit, relative=True),
536 [r'\.go$'])
537
538 for gofile in files:
539 contents = _get_file_content(gofile, commit)
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700540 output = _run_command(cmd=['gofmt', '-l'], input=contents,
541 combine_stdout_stderr=True)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700542 if output:
543 errors.append(gofile)
544 if errors:
545 return HookFailure('Files not formatted with gofmt:', errors)
546
547
Mike Frysingerae409522014-02-01 03:16:11 -0500548def _check_change_has_test_field(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700549 """Check for a non-empty 'TEST=' field in the commit message."""
David McMahon8f6553e2011-06-10 15:46:36 -0700550 TEST_RE = r'\nTEST=\S+'
Ryan Cuiec4d6332011-05-02 14:15:25 -0700551
Mandeep Singh Baines96a53be2011-05-03 11:10:25 -0700552 if not re.search(TEST_RE, _get_commit_desc(commit)):
Ryan Cui1562fb82011-05-09 11:01:31 -0700553 msg = 'Changelist description needs TEST field (after first line)'
554 return HookFailure(msg)
555
Ryan Cuiec4d6332011-05-02 14:15:25 -0700556
Mike Frysingerae409522014-02-01 03:16:11 -0500557def _check_change_has_valid_cq_depend(_project, commit):
David Jamesc3b68b32013-04-03 09:17:03 -0700558 """Check for a correctly formatted CQ-DEPEND field in the commit message."""
559 msg = 'Changelist has invalid CQ-DEPEND target.'
560 example = 'Example: CQ-DEPEND=CL:1234, CL:2345'
561 try:
562 patch.GetPaladinDeps(_get_commit_desc(commit))
563 except ValueError as ex:
564 return HookFailure(msg, [example, str(ex)])
565
566
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800567def _check_change_is_contribution(_project, commit):
568 """Check that the change is a contribution."""
569 NO_CONTRIB = 'not a contribution'
570 if NO_CONTRIB in _get_commit_desc(commit).lower():
571 msg = ('Changelist is not a contribution, this cannot be accepted.\n'
572 'Please remove the "%s" text from the commit message.') % NO_CONTRIB
573 return HookFailure(msg)
574
575
Alex Deymo643ac4c2015-09-03 10:40:50 -0700576def _check_change_has_bug_field(project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700577 """Check for a correctly formatted 'BUG=' field in the commit message."""
David James5c0073d2013-04-03 08:48:52 -0700578 OLD_BUG_RE = r'\nBUG=.*chromium-os'
579 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
580 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
581 'the chromium tracker in your BUG= line now.')
582 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700583
Alex Deymo643ac4c2015-09-03 10:40:50 -0700584 # Android internal and external projects use "Bug: " to track bugs in
585 # buganizer.
586 BUG_COLON_REMOTES = (
587 'aosp',
588 'goog',
589 )
590 if project.remote in BUG_COLON_REMOTES:
591 BUG_RE = r'\nBug: ?([Nn]one|\d+)'
592 if not re.search(BUG_RE, _get_commit_desc(commit)):
593 msg = ('Changelist description needs BUG field (after first line):\n'
594 'Bug: 9999 (for buganizer)\n'
595 'BUG=None')
596 return HookFailure(msg)
597 else:
Jorge Lucangeli Obesdce214e2017-10-25 15:04:39 -0400598 BUG_RE = r'\nBUG=([Nn]one|(chromium|b):\d+)'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700599 if not re.search(BUG_RE, _get_commit_desc(commit)):
600 msg = ('Changelist description needs BUG field (after first line):\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700601 'BUG=chromium:9999 (for public tracker)\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700602 'BUG=b:9999 (for buganizer)\n'
603 'BUG=None')
604 return HookFailure(msg)
Ryan Cui1562fb82011-05-09 11:01:31 -0700605
Ryan Cuiec4d6332011-05-02 14:15:25 -0700606
Mike Frysinger292b45d2014-11-25 01:17:10 -0500607def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -0700608 """Check that we're not missing a revbump of an ebuild in the given commit.
609
610 If the given commit touches files in a directory that has ebuilds somewhere
611 up the directory hierarchy, it's very likely that we need an ebuild revbump
612 in order for those changes to take effect.
613
614 It's not totally trivial to detect a revbump, so at least detect that an
615 ebuild with a revision number in it was touched. This should handle the
616 common case where we use a symlink to do the revbump.
617
618 TODO: it would be nice to enhance this hook to:
619 * Handle cases where people revbump with a slightly different syntax. I see
620 one ebuild (puppy) that revbumps with _pN. This is a false positive.
621 * Catches cases where people aren't using symlinks for revbumps. If they
622 edit a revisioned file directly (and are expected to rename it for revbump)
623 we'll miss that. Perhaps we could detect that the file touched is a
624 symlink?
625
626 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
627 still better off than without this check.
628
629 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700630 project: The Project to look at
Doug Anderson42b8a052013-06-26 10:45:36 -0700631 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -0500632 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -0700633
634 Returns:
635 A HookFailure or None.
636 """
Mike Frysinger011af942014-01-17 16:12:22 -0500637 # If this is the portage-stable overlay, then ignore the check. It's rare
638 # that we're doing anything other than importing files from upstream, so
639 # forcing a rev bump makes no sense.
640 whitelist = (
641 'chromiumos/overlays/portage-stable',
642 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700643 if project.name in whitelist:
Mike Frysinger011af942014-01-17 16:12:22 -0500644 return None
645
Mike Frysinger292b45d2014-11-25 01:17:10 -0500646 def FinalName(obj):
647 # If the file is being deleted, then the dst_file is not set.
648 if obj.dst_file is None:
649 return obj.src_file
650 else:
651 return obj.dst_file
652
653 affected_path_objs = _get_affected_files(
654 commit, include_deletes=True, include_symlinks=True, relative=True,
655 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -0700656
657 # Don't yell about changes to whitelisted files...
Aviv Keshet272f2e52016-04-25 14:49:44 -0700658 whitelist = ('ChangeLog', 'Manifest', 'metadata.xml', 'COMMIT-QUEUE.ini')
Mike Frysinger292b45d2014-11-25 01:17:10 -0500659 affected_path_objs = [x for x in affected_path_objs
660 if os.path.basename(FinalName(x)) not in whitelist]
661 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -0700662 return None
663
664 # If we've touched any file named with a -rN.ebuild then we'll say we're
665 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500666 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
667 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700668 if touched_revved_ebuild:
669 return None
670
Mike Frysinger292b45d2014-11-25 01:17:10 -0500671 # If we're creating new ebuilds from scratch, then we don't need an uprev.
672 # Find all the dirs that new ebuilds and ignore their files/.
673 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
674 if FinalName(x).endswith('.ebuild') and x.status == 'A']
675 affected_path_objs = [obj for obj in affected_path_objs
676 if not any(FinalName(obj).startswith(x)
677 for x in ebuild_dirs)]
678 if not affected_path_objs:
679 return
680
Doug Anderson42b8a052013-06-26 10:45:36 -0700681 # We want to examine the current contents of all directories that are parents
682 # of files that were touched (up to the top of the project).
683 #
684 # ...note: we use the current directory contents even though it may have
685 # changed since the commit we're looking at. This is just a heuristic after
686 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500687 if project_top is None:
688 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -0700689 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -0500690 for obj in affected_path_objs:
691 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -0700692 while os.path.exists(path) and not os.path.samefile(path, project_top):
693 dirs_to_check.add(path)
694 path = os.path.dirname(path)
695
696 # Look through each directory. If it's got an ebuild in it then we'll
697 # consider this as a case when we need a revbump.
Gwendal Grignoua3086c32014-12-09 11:17:22 -0800698 affected_paths = set(os.path.join(project_top, FinalName(x))
699 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700700 for dir_path in dirs_to_check:
701 contents = os.listdir(dir_path)
702 ebuilds = [os.path.join(dir_path, path)
703 for path in contents if path.endswith('.ebuild')]
704 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
705
C Shapiroae157ae2017-09-18 16:24:03 -0600706 affected_paths_under_9999_ebuilds = set()
707 for affected_path in affected_paths:
708 for ebuild_9999 in ebuilds_9999:
709 ebuild_dir = os.path.dirname(ebuild_9999)
710 if affected_path.startswith(ebuild_dir):
711 affected_paths_under_9999_ebuilds.add(affected_path)
712
713 # If every file changed exists under a 9999 ebuild, then skip
714 if len(affected_paths_under_9999_ebuilds) == len(affected_paths):
715 continue
716
Doug Anderson42b8a052013-06-26 10:45:36 -0700717 # If the -9999.ebuild file was touched the bot will uprev for us.
718 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -0500719 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -0700720 continue
721
722 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500723 return HookFailure('Changelist probably needs a revbump of an ebuild, '
724 'or a -r1.ebuild symlink if this is a new ebuild:\n'
725 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -0700726
727 return None
728
729
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500730def _check_ebuild_eapi(project, commit):
Mike Frysinger948284a2018-02-01 15:22:56 -0500731 """Make sure we have people use EAPI=5 or newer with custom ebuilds.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500732
733 We want to get away from older EAPI's as it makes life confusing and they
734 have less builtin error checking.
735
736 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700737 project: The Project to look at
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500738 commit: The commit to look at
739
740 Returns:
741 A HookFailure or None.
742 """
743 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500744 # that we're doing anything other than importing files from upstream, and
745 # we shouldn't be rewriting things fundamentally anyways.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500746 whitelist = (
747 'chromiumos/overlays/portage-stable',
748 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700749 if project.name in whitelist:
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500750 return None
751
Mike Frysinger948284a2018-02-01 15:22:56 -0500752 BAD_EAPIS = ('0', '1', '2', '3', '4')
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500753
754 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
755
756 ebuilds_re = [r'\.ebuild$']
757 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
758 ebuilds_re)
759 bad_ebuilds = []
760
761 for ebuild in ebuilds:
762 # If the ebuild does not specify an EAPI, it defaults to 0.
763 eapi = '0'
764
765 lines = _get_file_content(ebuild, commit).splitlines()
766 if len(lines) == 1:
767 # This is most likely a symlink, so skip it entirely.
768 continue
769
770 for line in lines:
771 m = get_eapi.match(line)
772 if m:
773 # Once we hit the first EAPI line in this ebuild, stop processing.
774 # The spec requires that there only be one and it be first, so
775 # checking all possible values is pointless. We also assume that
776 # it's "the" EAPI line and not something in the middle of a heredoc.
777 eapi = m.group(1)
778 break
779
780 if eapi in BAD_EAPIS:
781 bad_ebuilds.append((ebuild, eapi))
782
783 if bad_ebuilds:
784 # pylint: disable=C0301
785 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
786 # pylint: enable=C0301
787 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500788 'These ebuilds are using old EAPIs. If these are imported from\n'
789 'Gentoo, then you may ignore and upload once with the --no-verify\n'
Mike Frysinger948284a2018-02-01 15:22:56 -0500790 'flag. Otherwise, please update to 5 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500791 '\t%s\n'
792 'See this guide for more details:\n%s\n' %
793 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
794
795
Mike Frysinger89bdb852014-02-01 05:26:26 -0500796def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -0500797 """Make sure we use the new style KEYWORDS when possible in ebuilds.
798
799 If an ebuild generally does not care about the arch it is running on, then
800 ebuilds should flag it with one of:
801 KEYWORDS="*" # A stable ebuild.
802 KEYWORDS="~*" # An unstable ebuild.
803 KEYWORDS="-* ..." # Is known to only work on specific arches.
804
805 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700806 project: The Project to look at
Mike Frysingerc51ece72014-01-17 16:23:40 -0500807 commit: The commit to look at
808
809 Returns:
810 A HookFailure or None.
811 """
812 WHITELIST = set(('*', '-*', '~*'))
813
814 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
815
Mike Frysinger89bdb852014-02-01 05:26:26 -0500816 ebuilds_re = [r'\.ebuild$']
817 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
818 ebuilds_re)
819
Mike Frysinger8d42d742014-09-22 15:50:21 -0400820 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -0500821 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -0400822 # We get the full content rather than a diff as the latter does not work
823 # on new files (like when adding new ebuilds).
824 lines = _get_file_content(ebuild, commit).splitlines()
825 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -0500826 m = get_keywords.match(line)
827 if m:
828 keywords = set(m.group(1).split())
829 if not keywords or WHITELIST - keywords != WHITELIST:
830 continue
831
Mike Frysinger8d42d742014-09-22 15:50:21 -0400832 bad_ebuilds.append(ebuild)
833
834 if bad_ebuilds:
835 return HookFailure(
836 '%s\n'
837 'Please update KEYWORDS to use a glob:\n'
838 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
839 ' KEYWORDS="*"\n'
840 'If the ebuild should be marked unstable (normal for '
841 'cros-workon / 9999 ebuilds):\n'
842 ' KEYWORDS="~*"\n'
Mike Frysingerde8efea2015-05-17 03:42:26 -0400843 'If the ebuild needs to be marked for only specific arches, '
Mike Frysinger8d42d742014-09-22 15:50:21 -0400844 'then use -* like so:\n'
845 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -0500846
847
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800848def _check_ebuild_licenses(_project, commit):
849 """Check if the LICENSE field in the ebuild is correct."""
Brian Norris7a610e82016-02-17 12:24:54 -0800850 affected_paths = _get_affected_files(commit, relative=True)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800851 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
852
853 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -0800854 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800855
856 for ebuild in touched_ebuilds:
857 # Skip virutal packages.
858 if ebuild.split('/')[-3] == 'virtual':
859 continue
860
861 try:
Brian Norris7a610e82016-02-17 12:24:54 -0800862 ebuild_content = _get_file_content(ebuild, commit)
863 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800864 except ValueError as e:
865 return HookFailure(e.message, [ebuild])
866
867 # Also ignore licenses ending with '?'
868 for license_type in [x for x in license_types
869 if x not in LICENSES_IGNORE and not x.endswith('?')]:
870 try:
Mike Frysinger2ec70ed2014-08-17 19:28:34 -0400871 licenses_lib.Licensing.FindLicenseType(license_type)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800872 except AssertionError as e:
873 return HookFailure(e.message, [ebuild])
874
875
Mike Frysingercd363c82014-02-01 05:20:18 -0500876def _check_ebuild_virtual_pv(project, commit):
877 """Enforce the virtual PV policies."""
878 # If this is the portage-stable overlay, then ignore the check.
879 # We want to import virtuals as-is from upstream Gentoo.
880 whitelist = (
881 'chromiumos/overlays/portage-stable',
882 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700883 if project.name in whitelist:
Mike Frysingercd363c82014-02-01 05:20:18 -0500884 return None
885
886 # We assume the repo name is the same as the dir name on disk.
887 # It would be dumb to not have them match though.
Alex Deymo643ac4c2015-09-03 10:40:50 -0700888 project_base = os.path.basename(project.name)
Mike Frysingercd363c82014-02-01 05:20:18 -0500889
890 is_variant = lambda x: x.startswith('overlay-variant-')
891 is_board = lambda x: x.startswith('overlay-')
892 is_private = lambda x: x.endswith('-private')
893
894 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
895
896 ebuilds_re = [r'\.ebuild$']
897 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
898 ebuilds_re)
899 bad_ebuilds = []
900
901 for ebuild in ebuilds:
902 m = get_pv.match(ebuild)
903 if m:
904 overlay = m.group(1)
905 if not overlay or not is_board(overlay):
Alex Deymo643ac4c2015-09-03 10:40:50 -0700906 overlay = project_base
Mike Frysingercd363c82014-02-01 05:20:18 -0500907
908 pv = m.group(3).split('-', 1)[0]
909
Bernie Thompsone5ee1822016-01-12 14:22:23 -0800910 # Virtual versions >= 4 are special cases used above the standard
911 # versioning structure, e.g. if one has a board inheriting a board.
912 if float(pv) >= 4:
913 want_pv = pv
914 elif is_private(overlay):
Mike Frysingercd363c82014-02-01 05:20:18 -0500915 want_pv = '3.5' if is_variant(overlay) else '3'
916 elif is_board(overlay):
917 want_pv = '2.5' if is_variant(overlay) else '2'
918 else:
919 want_pv = '1'
920
921 if pv != want_pv:
922 bad_ebuilds.append((ebuild, pv, want_pv))
923
924 if bad_ebuilds:
925 # pylint: disable=C0301
926 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
927 # pylint: enable=C0301
928 return HookFailure(
929 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
930 '\t%s\n'
931 'If this is an upstream Gentoo virtual, then you may ignore this\n'
932 'check (and re-run w/--no-verify). Otherwise, please see this\n'
933 'page for more details:\n%s\n' %
934 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
935 for x in bad_ebuilds]), url))
936
937
Daniel Erat9d203ff2015-02-17 10:12:21 -0700938def _check_portage_make_use_var(_project, commit):
939 """Verify that $USE is set correctly in make.conf and make.defaults."""
940 files = _filter_files(_get_affected_files(commit, relative=True),
941 [r'(^|/)make.(conf|defaults)$'])
942
943 errors = []
944 for path in files:
945 basename = os.path.basename(path)
946
947 # Has a USE= line already been encountered in this file?
948 saw_use = False
949
950 for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1):
951 if not line.startswith('USE='):
952 continue
953
954 preserves_use = '${USE}' in line or '$USE' in line
955
956 if (basename == 'make.conf' or
957 (basename == 'make.defaults' and saw_use)) and not preserves_use:
958 errors.append('%s:%d: missing ${USE}' % (path, i))
959 elif basename == 'make.defaults' and not saw_use and preserves_use:
960 errors.append('%s:%d: ${USE} referenced in initial declaration' %
961 (path, i))
962
963 saw_use = True
964
965 if errors:
966 return HookFailure(
967 'One or more Portage make files appear to set USE incorrectly.\n'
968 '\n'
969 'All USE assignments in make.conf and all assignments after the\n'
970 'initial declaration in make.defaults should contain "${USE}" to\n'
971 'preserve previously-set flags.\n'
972 '\n'
973 'The initial USE declaration in make.defaults should not contain\n'
974 '"${USE}".\n',
975 errors)
976
977
Mike Frysingerae409522014-02-01 03:16:11 -0500978def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -0700979 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -0400980 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -0700981 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -0400982 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -0500983 if not m:
Vadim Bendebury20532ba2017-05-23 17:26:15 -0700984 return HookFailure('Last paragraph of description must include Change-Id.')
Ryan Cui1562fb82011-05-09 11:01:31 -0700985
Vadim Bendebury20532ba2017-05-23 17:26:15 -0700986 # S-o-b tags always allowed to follow Change-ID.
987 allowed_tags = ['Signed-off-by']
988
Mike Frysinger02b88bd2014-11-21 00:29:38 -0500989 end = desc[m.end():].strip().splitlines()
Vadim Bendebury6504aea2017-09-13 18:35:49 -0700990 cherry_pick_marker = 'cherry picked from commit'
991
992 if end and cherry_pick_marker in end[-1]:
Vadim Bendebury20532ba2017-05-23 17:26:15 -0700993 # Cherry picked patches allow more tags in the last paragraph.
Vadim Bendebury6504aea2017-09-13 18:35:49 -0700994 allowed_tags += ['Commit-Queue', 'Commit-Ready', 'Reviewed-by',
995 'Reviewed-on', 'Tested-by']
Vadim Bendebury20532ba2017-05-23 17:26:15 -0700996 end = end[:-1]
997
Vadim Bendebury6504aea2017-09-13 18:35:49 -0700998 # Note that descriptions could have multiple cherry pick markers.
999 tag_search = r'^(%s:|\(%s) ' % (':|'.join(allowed_tags), cherry_pick_marker)
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001000
1001 if [x for x in end if not re.search(tag_search, x)]:
1002 return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' %
1003 ':", "'.join(allowed_tags))
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001004
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001005
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001006def _check_commit_message_style(_project, commit):
1007 """Verify that the commit message matches our style.
1008
1009 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
1010 commit hooks.
1011 """
1012 desc = _get_commit_desc(commit)
1013
1014 # The first line should be by itself.
1015 lines = desc.splitlines()
1016 if len(lines) > 1 and lines[1]:
1017 return HookFailure('The second line of the commit message must be blank.')
1018
1019 # The first line should be one sentence.
1020 if '. ' in lines[0]:
1021 return HookFailure('The first line cannot be more than one sentence.')
1022
1023 # The first line cannot be too long.
1024 MAX_FIRST_LINE_LEN = 100
1025 if len(lines[0]) > MAX_FIRST_LINE_LEN:
1026 return HookFailure('The first line must be less than %i chars.' %
1027 MAX_FIRST_LINE_LEN)
1028
1029
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001030def _check_cros_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001031 """Verifies the Chromium OS license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -07001032
Mike Frysinger98638102014-08-28 00:15:08 -04001033 Should be following the spec:
1034 http://dev.chromium.org/developers/coding-style#TOC-File-headers
1035 """
1036 # For older years, be a bit more flexible as our policy says leave them be.
1037 LICENSE_HEADER = (
1038 r'.* Copyright( \(c\))? 20[-0-9]{2,7} The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001039 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001040 r'.* Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001041 r'be\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001042 r'.* found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -05001043 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001044 )
1045 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1046
1047 # For newer years, be stricter.
1048 COPYRIGHT_LINE = (
1049 r'.* Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001050 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001051 )
1052 copyright_re = re.compile(COPYRIGHT_LINE)
1053
Shuhei Takahashiabc20f32017-07-10 19:35:45 +09001054 included, excluded = _parse_common_inclusion_options(options)
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001055
Mike Frysinger98638102014-08-28 00:15:08 -04001056 bad_files = []
1057 bad_copyright_files = []
Ken Turnerd07564b2018-02-08 17:57:59 +11001058 files = _filter_files(
1059 _get_affected_files(commit, relative=True),
1060 included + COMMON_INCLUDED_PATHS,
1061 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Mike Frysinger98638102014-08-28 00:15:08 -04001062
1063 for f in files:
1064 contents = _get_file_content(f, commit)
1065 if not contents:
1066 # Ignore empty files.
1067 continue
1068
1069 if not license_re.search(contents):
1070 bad_files.append(f)
1071 elif copyright_re.search(contents):
1072 bad_copyright_files.append(f)
1073
1074 if bad_files:
1075 msg = '%s:\n%s\n%s' % (
1076 'License must match', license_re.pattern,
1077 'Found a bad header in these files:')
1078 return HookFailure(msg, bad_files)
1079
1080 if bad_copyright_files:
1081 msg = 'Do not use (c) in copyright headers in new files:'
1082 return HookFailure(msg, bad_copyright_files)
Ryan Cuiec4d6332011-05-02 14:15:25 -07001083
1084
Amin Hassani391efa92018-01-26 17:58:05 -08001085def _check_aosp_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001086 """Verifies the AOSP license/copyright header.
1087
1088 AOSP uses the Apache2 License:
1089 https://source.android.com/source/licenses.html
1090 """
1091 LICENSE_HEADER = (
1092 r"""^[#/\*]*
1093[#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project
1094[#/\*]* ?
1095[#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\);
1096[#/\*]* ?you may not use this file except in compliance with the License\.
1097[#/\*]* ?You may obtain a copy of the License at
1098[#/\*]* ?
1099[#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0
1100[#/\*]* ?
1101[#/\*]* ?Unless required by applicable law or agreed to in writing, software
1102[#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS,
1103[#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """
1104 r"""implied\.
1105[#/\*]* ?See the License for the specific language governing permissions and
1106[#/\*]* ?limitations under the License\.
1107[#/\*]*$
1108"""
1109 )
1110 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1111
Amin Hassani391efa92018-01-26 17:58:05 -08001112 included, excluded = _parse_common_inclusion_options(options)
1113
Ken Turnerd07564b2018-02-08 17:57:59 +11001114 files = _filter_files(
1115 _get_affected_files(commit, relative=True),
1116 included + COMMON_INCLUDED_PATHS,
1117 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Alex Deymof5792ce2015-08-24 22:50:08 -07001118
1119 bad_files = []
1120 for f in files:
1121 contents = _get_file_content(f, commit)
1122 if not contents:
1123 # Ignore empty files.
1124 continue
1125
1126 if not license_re.search(contents):
1127 bad_files.append(f)
1128
1129 if bad_files:
1130 msg = ('License must match:\n%s\nFound a bad header in these files:' %
1131 license_re.pattern)
1132 return HookFailure(msg, bad_files)
1133
1134
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001135def _check_layout_conf(_project, commit):
1136 """Verifies the metadata/layout.conf file."""
1137 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001138 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001139 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001140 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001141
Mike Frysinger94a670c2014-09-19 12:46:26 -04001142 # Handle multiple overlays in a single commit (like the public tree).
1143 for f in _get_affected_files(commit, relative=True):
1144 if f.endswith(repo_name):
1145 repo_names.append(f)
1146 elif f.endswith(layout_path):
1147 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001148
1149 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -04001150 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001151 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -04001152 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001153
Mike Frysinger94a670c2014-09-19 12:46:26 -04001154 # Gather all the errors in one pass so we show one full message.
1155 all_errors = {}
1156 for layout_path in layout_paths:
1157 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001158
Mike Frysinger94a670c2014-09-19 12:46:26 -04001159 # Make sure the config file is sorted.
1160 data = [x for x in _get_file_content(layout_path, commit).splitlines()
1161 if x and x[0] != '#']
1162 if sorted(data) != data:
1163 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001164
Mike Frysinger94a670c2014-09-19 12:46:26 -04001165 # Require people to set specific values all the time.
1166 settings = (
1167 # TODO: Enable this for everyone. http://crbug.com/408038
1168 #('fast caching', 'cache-format = md5-dict'),
1169 ('fast manifests', 'thin-manifests = true'),
Mike Frysingerd7734522015-02-26 16:12:43 -05001170 ('extra features', 'profile-formats = portage-2 profile-default-eapi'),
1171 ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001172 )
1173 for reason, line in settings:
1174 if line not in data:
1175 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001176
Mike Frysinger94a670c2014-09-19 12:46:26 -04001177 # Require one of these settings.
Mike Frysinger5fae62d2015-11-11 20:12:15 -05001178 if 'use-manifests = strict' not in data:
1179 errors += ['enable file checking with: use-manifests = strict']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001180
Mike Frysinger94a670c2014-09-19 12:46:26 -04001181 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -04001182 for line in data:
1183 if line.startswith('repo-name = '):
1184 break
1185 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -04001186 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001187
Mike Frysinger94a670c2014-09-19 12:46:26 -04001188 # Summarize all the errors we saw (if any).
1189 lines = ''
1190 for layout_path, errors in all_errors.items():
1191 if errors:
1192 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
1193 if lines:
1194 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
1195 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001196
1197
Ryan Cuiec4d6332011-05-02 14:15:25 -07001198# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001199
Ryan Cui1562fb82011-05-09 11:01:31 -07001200
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001201def _check_clang_format(_project, commit, options=()):
1202 """Runs clang-format on the given project"""
1203 hooks_dir = _get_hooks_dir()
1204 options = list(options)
1205 if commit == PRE_SUBMIT:
1206 options.append('--commit=HEAD')
1207 else:
1208 options.extend(['--commit', commit])
1209 cmd = ['%s/clang-format.py' % hooks_dir] + options
1210 cmd_result = cros_build_lib.RunCommand(cmd=cmd,
1211 print_cmd=False,
1212 input=_get_patch(commit),
1213 stdout_to_pipe=True,
1214 combine_stdout_stderr=True,
1215 error_code_ok=True)
1216 if cmd_result.returncode:
1217 return HookFailure('clang-format.py errors/warnings\n\n' +
1218 cmd_result.output)
1219
1220
Mike Frysingerae409522014-02-01 03:16:11 -05001221def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001222 """Runs checkpatch.pl on the given project"""
1223 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001224 options = list(options)
1225 if commit == PRE_SUBMIT:
1226 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
1227 # this case.
1228 options.append('--ignore=MISSING_SIGN_OFF')
Filipe Brandenburger28d48d62015-10-07 09:48:54 -07001229 # Always ignore the check for the MAINTAINERS file. We do not track that
1230 # information on that file in our source trees, so let's suppress the
1231 # warning.
1232 options.append('--ignore=FILE_PATH_CHANGES')
Filipe Brandenburgerce978322015-10-09 10:04:15 -07001233 # Do not complain about the Change-Id: fields, since we use Gerrit.
1234 # Upstream does not want those lines (since they do not use Gerrit), but
1235 # we always do, so disable the check globally.
Daisuke Nojiri4844f892015-10-08 09:54:33 -07001236 options.append('--ignore=GERRIT_CHANGE_ID')
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001237 cmd = ['%s/checkpatch.pl' % hooks_dir] + options + ['-']
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001238 cmd_result = cros_build_lib.RunCommand(cmd=cmd,
1239 print_cmd=False,
1240 input=_get_patch(commit),
1241 stdout_to_pipe=True,
1242 combine_stdout_stderr=True,
1243 error_code_ok=True)
1244 if cmd_result.returncode:
1245 return HookFailure('checkpatch.pl errors/warnings\n\n' + cmd_result.output)
Ryan Cuiec4d6332011-05-02 14:15:25 -07001246
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001247
Mike Frysingerae409522014-02-01 03:16:11 -05001248def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -07001249 """Makes sure kernel config changes are not mixed with code changes"""
1250 files = _get_affected_files(commit)
1251 if not len(_filter_files(files, [r'chromeos/config'])) in [0, len(files)]:
1252 return HookFailure('Changes to chromeos/config/ and regular files must '
1253 'be in separate commits:\n%s' % '\n'.join(files))
Anton Staaf815d6852011-08-22 10:08:45 -07001254
Mike Frysingerae409522014-02-01 03:16:11 -05001255
1256def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -07001257 """Checks that all JSON files are syntactically valid."""
Mike Frysinger908be682018-01-04 02:21:50 -05001258 ret = []
1259
1260 files = _filter_files(_get_affected_files(commit, relative=True),
1261 [r'.*\.json$'])
1262 for f in files:
1263 data = _get_file_content(f, commit)
Dale Curtis2975c432011-05-03 17:25:20 -07001264 try:
Mike Frysinger908be682018-01-04 02:21:50 -05001265 json.loads(data)
1266 except Exception as e:
1267 ret.append('%s: Invalid JSON: %s' % (f, e))
1268
1269 if ret:
1270 return HookFailure('\n'.join(ret))
Dale Curtis2975c432011-05-03 17:25:20 -07001271
1272
Mike Frysingerae409522014-02-01 03:16:11 -05001273def _check_manifests(_project, commit):
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001274 """Make sure Manifest files only have comments & DIST lines."""
1275 ret = []
Mike Frysinger52b537e2013-08-22 22:59:53 -04001276
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001277 manifests = _filter_files(_get_affected_files(commit, relative=True),
1278 [r'.*/Manifest$'])
1279 for path in manifests:
1280 data = _get_file_content(path, commit)
1281
1282 # Disallow blank files.
1283 if not data.strip():
1284 ret.append('%s: delete empty file' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001285 continue
1286
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001287 # Make sure the last newline isn't omitted.
1288 if data[-1] != '\n':
1289 ret.append('%s: missing trailing newline' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001290
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001291 # Do not allow leading or trailing blank lines.
1292 lines = data.splitlines()
1293 if not lines[0]:
1294 ret.append('%s: delete leading blank lines' % (path,))
1295 if not lines[-1]:
1296 ret.append('%s: delete trailing blank lines' % (path,))
1297
1298 for line in lines:
1299 # Disallow leading/trailing whitespace.
1300 if line != line.strip():
1301 ret.append('%s: remove leading/trailing whitespace: %s' % (path, line))
1302
1303 # Allow blank lines & comments.
1304 line = line.split('#', 1)[0]
1305 if not line:
1306 continue
1307
1308 # All other linse should start with DIST.
1309 if not line.startswith('DIST '):
1310 ret.append('%s: remove non-DIST lines: %s' % (path, line))
1311 break
1312
1313 if ret:
1314 return HookFailure('\n'.join(ret))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001315
1316
Mike Frysingerae409522014-02-01 03:16:11 -05001317def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001318 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001319 if commit == PRE_SUBMIT:
1320 return
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001321 BRANCH_RE = r'\nBRANCH=\S+'
1322
1323 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
1324 msg = ('Changelist description needs BRANCH field (after first line)\n'
1325 'E.g. BRANCH=none or BRANCH=link,snow')
1326 return HookFailure(msg)
1327
1328
Mike Frysingerae409522014-02-01 03:16:11 -05001329def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001330 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001331 if commit == PRE_SUBMIT:
1332 return
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001333 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1334
1335 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1336 msg = ('Changelist description needs Signed-off-by: field\n'
1337 'E.g. Signed-off-by: My Name <me@chromium.org>')
1338 return HookFailure(msg)
1339
1340
Aviv Keshet5ac59522017-01-31 14:28:27 -08001341def _check_cq_ini_well_formed(_project, commit):
1342 """Check that any modified COMMIT-QUEUE.ini files are well formed."""
1343 pattern = '.*' + constants.CQ_CONFIG_FILENAME
Mike Frysingerd0523442018-01-03 17:05:29 -05001344 files = _filter_files(_get_affected_files(commit, relative=True), (pattern,))
Aviv Keshet5ac59522017-01-31 14:28:27 -08001345
1346 # TODO(akeshet): Check not only that the file is parseable, but that all the
1347 # pre-cq configs it requests are existing ones.
1348 for f in files:
1349 try:
1350 parser = ConfigParser.SafeConfigParser()
1351 # Prior to python3, ConfigParser has no read_string method, so we must
1352 # pass it either a file path or file like object. And we must use
1353 # _get_file_content to fetch file contents to ensure we are examining the
1354 # commit diff, rather than whatever's on disk.
1355 contents = _get_file_content(f, commit)
1356 parser.readfp(StringIO.StringIO(contents))
1357 except ConfigParser.Error as e:
1358 msg = ('Unable to parse COMMIT-QUEUE.ini file at %s due to %s.' %
1359 (f, e))
1360 return HookFailure(msg)
1361
1362
Jon Salz3ee59de2012-08-18 13:54:22 +08001363def _run_project_hook_script(script, project, commit):
1364 """Runs a project hook script.
1365
1366 The script is run with the following environment variables set:
1367 PRESUBMIT_PROJECT: The affected project
1368 PRESUBMIT_COMMIT: The affected commit
1369 PRESUBMIT_FILES: A newline-separated list of affected files
1370
1371 The script is considered to fail if the exit code is non-zero. It should
1372 write an error message to stdout.
1373 """
1374 env = dict(os.environ)
Alex Deymo643ac4c2015-09-03 10:40:50 -07001375 env['PRESUBMIT_PROJECT'] = project.name
Jon Salz3ee59de2012-08-18 13:54:22 +08001376 env['PRESUBMIT_COMMIT'] = commit
1377
1378 # Put affected files in an environment variable
1379 files = _get_affected_files(commit)
1380 env['PRESUBMIT_FILES'] = '\n'.join(files)
1381
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001382 cmd_result = cros_build_lib.RunCommand(cmd=script,
1383 env=env,
1384 shell=True,
1385 print_cmd=False,
1386 input=os.devnull,
1387 stdout_to_pipe=True,
1388 combine_stdout_stderr=True,
1389 error_code_ok=True)
1390 if cmd_result.returncode:
1391 stdout = cmd_result.output
Jon Salz7b618af2012-08-31 06:03:16 +08001392 if stdout:
1393 stdout = re.sub('(?m)^', ' ', stdout)
1394 return HookFailure('Hook script "%s" failed with code %d%s' %
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001395 (script, cmd_result.returncode,
Jon Salz3ee59de2012-08-18 13:54:22 +08001396 ':\n' + stdout if stdout else ''))
1397
1398
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001399def _check_project_prefix(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -05001400 """Require the commit message have a project specific prefix as needed."""
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001401
Brian Norris77608e12018-04-06 10:38:43 -07001402 files = _get_affected_files(commit, include_deletes=True, relative=True)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001403 prefix = os.path.commonprefix(files)
1404 prefix = os.path.dirname(prefix)
1405
1406 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07001407 if not prefix:
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001408 return
1409
1410 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07001411
1412 # The common files may all be within a subdirectory of the main project
1413 # directory, so walk up the tree until we find an alias file.
1414 # _get_affected_files() should return relative paths, but check against '/' to
1415 # ensure that this loop terminates even if it receives an absolute path.
1416 while prefix and prefix != '/':
1417 alias_file = os.path.join(prefix, '.project_alias')
1418
1419 # If an alias exists, use it.
1420 if os.path.isfile(alias_file):
1421 project_name = osutils.ReadFile(alias_file).strip()
1422
1423 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001424
1425 if not _get_commit_desc(commit).startswith(project_name + ': '):
1426 return HookFailure('The commit title for changes affecting only %s'
1427 ' should start with \"%s: \"'
1428 % (project_name, project_name))
1429
1430
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001431def _check_exec_files(_project, commit):
1432 """Make +x bits on files."""
1433 # List of files that should never be +x.
1434 NO_EXEC = (
1435 'ChangeLog*',
1436 'COPYING',
1437 'make.conf',
1438 'make.defaults',
1439 'Manifest',
1440 'OWNERS',
1441 'package.use',
1442 'package.keywords',
1443 'package.mask',
1444 'parent',
1445 'README',
1446 'TODO',
1447 '.gitignore',
1448 '*.[achly]',
1449 '*.[ch]xx',
1450 '*.boto',
1451 '*.cc',
1452 '*.cfg',
1453 '*.conf',
1454 '*.config',
1455 '*.cpp',
1456 '*.css',
1457 '*.ebuild',
1458 '*.eclass',
1459 '*.gyp',
1460 '*.gypi',
1461 '*.htm',
1462 '*.html',
1463 '*.ini',
1464 '*.js',
1465 '*.json',
1466 '*.md',
1467 '*.mk',
1468 '*.patch',
1469 '*.policy',
1470 '*.proto',
1471 '*.raw',
1472 '*.rules',
1473 '*.service',
1474 '*.target',
1475 '*.txt',
1476 '*.xml',
1477 '*.yaml',
1478 )
1479
1480 def FinalName(obj):
1481 # If the file is being deleted, then the dst_file is not set.
1482 if obj.dst_file is None:
1483 return obj.src_file
1484 else:
1485 return obj.dst_file
1486
1487 bad_files = []
1488 files = _get_affected_files(commit, relative=True, full_details=True)
1489 for f in files:
1490 mode = int(f.dst_mode, 8)
1491 if not mode & 0o111:
1492 continue
1493 name = FinalName(f)
1494 for no_exec in NO_EXEC:
1495 if fnmatch.fnmatch(name, no_exec):
1496 bad_files.append(name)
1497 break
1498
1499 if bad_files:
1500 return HookFailure('These files should not be executable. '
1501 'Please `chmod -x` them.', bad_files)
1502
1503
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001504# Base
1505
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001506# A list of hooks which are not project specific and check patch description
1507# (as opposed to patch body).
1508_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07001509 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07001510 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07001511 _check_change_has_test_field,
1512 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001513 _check_commit_message_style,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001514 _check_change_is_contribution,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001515]
1516
1517
1518# A list of hooks that are not project-specific
1519_COMMON_HOOKS = [
Aviv Keshet5ac59522017-01-31 14:28:27 -08001520 _check_cq_ini_well_formed,
1521 _check_cros_license,
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001522 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05001523 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001524 _check_ebuild_licenses,
Mike Frysingercd363c82014-02-01 05:20:18 -05001525 _check_ebuild_virtual_pv,
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001526 _check_exec_files,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001527 _check_for_uprev,
Rahul Chaudhry09f61372015-07-31 17:14:26 -07001528 _check_gofmt,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001529 _check_layout_conf,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001530 _check_no_long_lines,
1531 _check_no_stray_whitespace,
Ryan Cui9b651632011-05-11 11:38:58 -07001532 _check_no_tabs,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001533 _check_portage_make_use_var,
Aviv Keshet5ac59522017-01-31 14:28:27 -08001534 _check_tabbed_indents,
Ryan Cui9b651632011-05-11 11:38:58 -07001535]
Ryan Cuiec4d6332011-05-02 14:15:25 -07001536
Ryan Cui1562fb82011-05-09 11:01:31 -07001537
Ryan Cui9b651632011-05-11 11:38:58 -07001538# A dictionary of project-specific hooks(callbacks), indexed by project name.
1539# dict[project] = [callback1, callback2]
1540_PROJECT_SPECIFIC_HOOKS = {
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001541 "chromiumos/platform2": [_check_project_prefix],
Mike Frysingeraf891292015-03-25 19:46:53 -04001542 "chromiumos/third_party/kernel": [_kernel_configcheck],
1543 "chromiumos/third_party/kernel-next": [_kernel_configcheck],
Ryan Cui9b651632011-05-11 11:38:58 -07001544}
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001545
Ryan Cui1562fb82011-05-09 11:01:31 -07001546
Ryan Cui9b651632011-05-11 11:38:58 -07001547# A dictionary of flags (keys) that can appear in the config file, and the hook
Mike Frysinger3554bc92015-03-11 04:59:21 -04001548# that the flag controls (value).
1549_HOOK_FLAGS = {
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001550 'clang_format_check': _check_clang_format,
Mike Frysingera7642f52015-03-25 18:31:42 -04001551 'checkpatch_check': _run_checkpatch,
Ryan Cui9b651632011-05-11 11:38:58 -07001552 'stray_whitespace_check': _check_no_stray_whitespace,
Mike Frysingerff6c7d62015-03-24 13:49:46 -04001553 'json_check': _run_json_check,
Ryan Cui9b651632011-05-11 11:38:58 -07001554 'long_line_check': _check_no_long_lines,
Alex Deymof5792ce2015-08-24 22:50:08 -07001555 'cros_license_check': _check_cros_license,
1556 'aosp_license_check': _check_aosp_license,
Ryan Cui9b651632011-05-11 11:38:58 -07001557 'tab_check': _check_no_tabs,
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08001558 'tabbed_indent_required_check': _check_tabbed_indents,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001559 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001560 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07001561 'bug_field_check': _check_change_has_bug_field,
1562 'test_field_check': _check_change_has_test_field,
Steve Fung49ec7e92015-03-23 16:07:12 -07001563 'manifest_check': _check_manifests,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001564 'contribution_check': _check_change_is_contribution,
Ryan Cui9b651632011-05-11 11:38:58 -07001565}
1566
1567
Mike Frysinger3554bc92015-03-11 04:59:21 -04001568def _get_override_hooks(config):
1569 """Returns a set of hooks controlled by the current project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001570
1571 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08001572
1573 Args:
1574 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001575 """
1576 SECTION = 'Hook Overrides'
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001577 SECTION_OPTIONS = 'Hook Overrides Options'
Jon Salz3ee59de2012-08-18 13:54:22 +08001578 if not config.has_section(SECTION):
Mike Frysinger3554bc92015-03-11 04:59:21 -04001579 return set(), set()
Ryan Cui9b651632011-05-11 11:38:58 -07001580
Mike Frysinger3554bc92015-03-11 04:59:21 -04001581 valid_keys = set(_HOOK_FLAGS.iterkeys())
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001582 hooks = _HOOK_FLAGS.copy()
Mike Frysinger3554bc92015-03-11 04:59:21 -04001583
1584 enable_flags = []
Ryan Cui9b651632011-05-11 11:38:58 -07001585 disable_flags = []
Jon Salz3ee59de2012-08-18 13:54:22 +08001586 for flag in config.options(SECTION):
Mike Frysinger3554bc92015-03-11 04:59:21 -04001587 if flag not in valid_keys:
1588 raise ValueError('Error: unknown key "%s" in hook section of "%s"' %
1589 (flag, _CONFIG_FILE))
1590
Ryan Cui9b651632011-05-11 11:38:58 -07001591 try:
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001592 enabled = config.getboolean(SECTION, flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001593 except ValueError as e:
Mike Frysinger3554bc92015-03-11 04:59:21 -04001594 raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' %
1595 (flag, _CONFIG_FILE, e))
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001596 if enabled:
1597 enable_flags.append(flag)
1598 else:
1599 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001600
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001601 # See if this hook has custom options.
1602 if enabled:
1603 try:
1604 options = config.get(SECTION_OPTIONS, flag)
1605 hooks[flag] = functools.partial(hooks[flag], options=options.split())
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001606 hooks[flag].__name__ = flag
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001607 except (ConfigParser.NoOptionError, ConfigParser.NoSectionError):
1608 pass
1609
1610 enabled_hooks = set(hooks[x] for x in enable_flags)
1611 disabled_hooks = set(hooks[x] for x in disable_flags)
Mike Frysinger3554bc92015-03-11 04:59:21 -04001612 return enabled_hooks, disabled_hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001613
1614
Jon Salz3ee59de2012-08-18 13:54:22 +08001615def _get_project_hook_scripts(config):
1616 """Returns a list of project-specific hook scripts.
1617
1618 Args:
1619 config: A ConfigParser for the project's config file.
1620 """
1621 SECTION = 'Hook Scripts'
1622 if not config.has_section(SECTION):
1623 return []
1624
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001625 return config.items(SECTION)
Jon Salz3ee59de2012-08-18 13:54:22 +08001626
1627
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001628def _get_project_hooks(project, presubmit):
Ryan Cui9b651632011-05-11 11:38:58 -07001629 """Returns a list of hooks that need to be run for a project.
1630
1631 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001632
1633 Args:
1634 project: A string, name of the project.
1635 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui9b651632011-05-11 11:38:58 -07001636 """
Jon Salz3ee59de2012-08-18 13:54:22 +08001637 config = ConfigParser.RawConfigParser()
1638 try:
1639 config.read(_CONFIG_FILE)
1640 except ConfigParser.Error:
1641 # Just use an empty config file
1642 config = ConfigParser.RawConfigParser()
1643
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001644 if presubmit:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001645 hooks = _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001646 else:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001647 hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001648
Mike Frysinger3554bc92015-03-11 04:59:21 -04001649 enabled_hooks, disabled_hooks = _get_override_hooks(config)
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001650 hooks = [hook for hook in hooks if hook not in disabled_hooks]
1651
1652 # If a list is both in _COMMON_HOOKS and also enabled explicitly through an
1653 # override, keep the override only. Note that the override may end up being
1654 # a functools.partial, in which case we need to extract the .func to compare
1655 # it to the common hooks.
1656 unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks]
1657 hooks = [hook for hook in hooks if hook not in unwrapped_hooks]
1658
1659 hooks = list(enabled_hooks) + hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001660
1661 if project in _PROJECT_SPECIFIC_HOOKS:
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001662 hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project]
1663 if hook not in disabled_hooks)
Ryan Cui9b651632011-05-11 11:38:58 -07001664
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001665 for name, script in _get_project_hook_scripts(config):
1666 func = functools.partial(_run_project_hook_script, script)
1667 func.__name__ = name
1668 hooks.append(func)
Jon Salz3ee59de2012-08-18 13:54:22 +08001669
Ryan Cui9b651632011-05-11 11:38:58 -07001670 return hooks
1671
1672
Alex Deymo643ac4c2015-09-03 10:40:50 -07001673def _run_project_hooks(project_name, proj_dir=None,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001674 commit_list=None, presubmit=False):
Ryan Cui1562fb82011-05-09 11:01:31 -07001675 """For each project run its project specific hook from the hooks dictionary.
1676
1677 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001678 project_name: The name of project to run hooks for.
Doug Anderson44a644f2011-11-02 10:37:37 -07001679 proj_dir: If non-None, this is the directory the project is in. If None,
1680 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07001681 commit_list: A list of commits to run hooks against. If None or empty list
1682 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001683 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui1562fb82011-05-09 11:01:31 -07001684
1685 Returns:
1686 Boolean value of whether any errors were ecountered while running the hooks.
1687 """
Doug Anderson44a644f2011-11-02 10:37:37 -07001688 if proj_dir is None:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001689 proj_dirs = _run_command(
1690 ['repo', 'forall', project_name, '-c', 'pwd']).split()
David James2edd9002013-10-11 14:09:19 -07001691 if len(proj_dirs) == 0:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001692 print('%s cannot be found.' % project_name, file=sys.stderr)
David James2edd9002013-10-11 14:09:19 -07001693 print('Please specify a valid project.', file=sys.stderr)
1694 return True
1695 if len(proj_dirs) > 1:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001696 print('%s is associated with multiple directories.' % project_name,
David James2edd9002013-10-11 14:09:19 -07001697 file=sys.stderr)
1698 print('Please specify a directory to help disambiguate.', file=sys.stderr)
1699 return True
1700 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07001701
Ryan Cuiec4d6332011-05-02 14:15:25 -07001702 pwd = os.getcwd()
1703 # hooks assume they are run from the root of the project
1704 os.chdir(proj_dir)
1705
Alex Deymo643ac4c2015-09-03 10:40:50 -07001706 remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref',
1707 '--symbolic-full-name', '@{u}']).strip()
1708 if not remote_branch:
1709 print('Your project %s doesn\'t track any remote repo.' % project_name,
1710 file=sys.stderr)
1711 remote = None
1712 else:
1713 remote, _branch = remote_branch.split('/', 1)
1714
1715 project = Project(name=project_name, dir=proj_dir, remote=remote)
1716
Doug Anderson14749562013-06-26 13:38:29 -07001717 if not commit_list:
1718 try:
1719 commit_list = _get_commits()
1720 except VerifyException as e:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001721 PrintErrorForProject(project.name, HookFailure(str(e)))
Doug Anderson14749562013-06-26 13:38:29 -07001722 os.chdir(pwd)
1723 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07001724
Alex Deymo643ac4c2015-09-03 10:40:50 -07001725 hooks = _get_project_hooks(project.name, presubmit)
Ryan Cui1562fb82011-05-09 11:01:31 -07001726 error_found = False
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001727 commit_count = len(commit_list)
1728 for i, commit in enumerate(commit_list):
Ryan Cui1562fb82011-05-09 11:01:31 -07001729 error_list = []
Ryan Cui9b651632011-05-11 11:38:58 -07001730 for hook in hooks:
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001731 output = ('PRESUBMIT.cfg: [%i/%i]: %s: Running %s' %
1732 (i + 1, commit_count, commit, hook.__name__))
1733 print(output, end='\r')
1734 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07001735 hook_error = hook(project, commit)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001736 print(' ' * len(output), end='\r')
1737 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07001738 if hook_error:
1739 error_list.append(hook_error)
1740 error_found = True
1741 if error_list:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001742 PrintErrorsForCommit(project.name, commit, _get_commit_desc(commit),
Ryan Cui1562fb82011-05-09 11:01:31 -07001743 error_list)
Don Garrettdba548a2011-05-05 15:17:14 -07001744
Ryan Cuiec4d6332011-05-02 14:15:25 -07001745 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07001746 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001747
Mike Frysingerae409522014-02-01 03:16:11 -05001748
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001749# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07001750
Ryan Cui1562fb82011-05-09 11:01:31 -07001751
Mike Frysingerae409522014-02-01 03:16:11 -05001752def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08001753 """Main function invoked directly by repo.
1754
1755 This function will exit directly upon error so that repo doesn't print some
1756 obscure error message.
1757
1758 Args:
1759 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07001760 worktree_list: A list of directories. It should be the same length as
1761 project_list, so that each entry in project_list matches with a directory
1762 in worktree_list. If None, we will attempt to calculate the directories
1763 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08001764 kwargs: Leave this here for forward-compatibility.
1765 """
Ryan Cui1562fb82011-05-09 11:01:31 -07001766 found_error = False
David James2edd9002013-10-11 14:09:19 -07001767 if not worktree_list:
1768 worktree_list = [None] * len(project_list)
1769 for project, worktree in zip(project_list, worktree_list):
1770 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07001771 found_error = True
1772
Mike Frysingerae409522014-02-01 03:16:11 -05001773 if found_error:
Ryan Cui1562fb82011-05-09 11:01:31 -07001774 msg = ('Preupload failed due to errors in project(s). HINTS:\n'
Ryan Cui9b651632011-05-11 11:38:58 -07001775 '- To disable some source style checks, and for other hints, see '
1776 '<checkout_dir>/src/repohooks/README\n'
1777 '- To upload only current project, run \'repo upload .\'')
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04001778 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07001779 sys.exit(1)
Anush Elangovan63afad72011-03-23 00:41:27 -07001780
Ryan Cui1562fb82011-05-09 11:01:31 -07001781
Doug Anderson44a644f2011-11-02 10:37:37 -07001782def _identify_project(path):
1783 """Identify the repo project associated with the given path.
1784
1785 Returns:
1786 A string indicating what project is associated with the path passed in or
1787 a blank string upon failure.
1788 """
1789 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001790 redirect_stderr=True, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07001791
1792
Mike Frysinger55f85b52014-12-18 14:45:21 -05001793def direct_main(argv):
Doug Anderson44a644f2011-11-02 10:37:37 -07001794 """Run hooks directly (outside of the context of repo).
1795
Doug Anderson44a644f2011-11-02 10:37:37 -07001796 Args:
Mike Frysinger55f85b52014-12-18 14:45:21 -05001797 argv: The command line args to process
Doug Anderson44a644f2011-11-02 10:37:37 -07001798
1799 Returns:
1800 0 if no pre-upload failures, 1 if failures.
1801
1802 Raises:
1803 BadInvocation: On some types of invocation errors.
1804 """
Mike Frysinger66142932014-12-18 14:55:57 -05001805 parser = commandline.ArgumentParser(description=__doc__)
1806 parser.add_argument('--dir', default=None,
1807 help='The directory that the project lives in. If not '
1808 'specified, use the git project root based on the cwd.')
1809 parser.add_argument('--project', default=None,
1810 help='The project repo path; this can affect how the '
1811 'hooks get run, since some hooks are project-specific. '
1812 'For chromite this is chromiumos/chromite. If not '
1813 'specified, the repo tool will be used to figure this '
1814 'out based on the dir.')
1815 parser.add_argument('--rerun-since', default=None,
Vadim Bendebury75447b92018-01-10 12:06:01 -08001816 help='Rerun hooks on old commits since some point '
1817 'in the past. The argument could be a date (should '
1818 'match git log\'s concept of a date, e.g. 2012-06-20), '
1819 'or a SHA1, or just a number of commits to check (from 1 '
1820 'to 99). This option is mutually exclusive with '
1821 '--pre-submit.')
Mike Frysinger66142932014-12-18 14:55:57 -05001822 parser.add_argument('--pre-submit', action="store_true",
1823 help='Run the check against the pending commit. '
1824 'This option should be used at the \'git commit\' '
1825 'phase as opposed to \'repo upload\'. This option '
1826 'is mutually exclusive with --rerun-since.')
1827 parser.add_argument('commits', nargs='*',
1828 help='Check specific commits')
1829 opts = parser.parse_args(argv)
Doug Anderson44a644f2011-11-02 10:37:37 -07001830
Doug Anderson14749562013-06-26 13:38:29 -07001831 if opts.rerun_since:
Mike Frysinger66142932014-12-18 14:55:57 -05001832 if opts.commits:
Doug Anderson14749562013-06-26 13:38:29 -07001833 raise BadInvocation('Can\'t pass commits and use rerun-since: %s' %
Mike Frysinger66142932014-12-18 14:55:57 -05001834 ' '.join(opts.commits))
Doug Anderson14749562013-06-26 13:38:29 -07001835
Vadim Bendebury75447b92018-01-10 12:06:01 -08001836 if len(opts.rerun_since) < 3 and opts.rerun_since.isdigit():
1837 # This must be the number of commits to check. We don't expect the user
1838 # to want to check more than 99 commits.
1839 limit = '-n%s' % opts.rerun_since
1840 elif git.IsSHA1(opts.rerun_since, False):
1841 limit = '%s..' % opts.rerun_since
1842 else:
1843 # This better be a date.
1844 limit = '--since=%s' % opts.rerun_since
1845 cmd = ['git', 'log', limit, '--pretty=%H']
Doug Anderson14749562013-06-26 13:38:29 -07001846 all_commits = _run_command(cmd).splitlines()
1847 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
1848
1849 # Eliminate chrome-bot commits but keep ordering the same...
1850 bot_commits = set(bot_commits)
Mike Frysinger66142932014-12-18 14:55:57 -05001851 opts.commits = [c for c in all_commits if c not in bot_commits]
Doug Anderson14749562013-06-26 13:38:29 -07001852
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001853 if opts.pre_submit:
1854 raise BadInvocation('rerun-since and pre-submit can not be '
1855 'used together')
1856 if opts.pre_submit:
Mike Frysinger66142932014-12-18 14:55:57 -05001857 if opts.commits:
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001858 raise BadInvocation('Can\'t pass commits and use pre-submit: %s' %
Mike Frysinger66142932014-12-18 14:55:57 -05001859 ' '.join(opts.commits))
1860 opts.commits = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07001861
1862 # Check/normlaize git dir; if unspecified, we'll use the root of the git
1863 # project from CWD
1864 if opts.dir is None:
1865 git_dir = _run_command(['git', 'rev-parse', '--git-dir'],
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001866 redirect_stderr=True).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07001867 if not git_dir:
1868 raise BadInvocation('The current directory is not part of a git project.')
1869 opts.dir = os.path.dirname(os.path.abspath(git_dir))
1870 elif not os.path.isdir(opts.dir):
1871 raise BadInvocation('Invalid dir: %s' % opts.dir)
1872 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
1873 raise BadInvocation('Not a git directory: %s' % opts.dir)
1874
1875 # Identify the project if it wasn't specified; this _requires_ the repo
1876 # tool to be installed and for the project to be part of a repo checkout.
1877 if not opts.project:
1878 opts.project = _identify_project(opts.dir)
1879 if not opts.project:
1880 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
1881
Doug Anderson14749562013-06-26 13:38:29 -07001882 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Mike Frysinger66142932014-12-18 14:55:57 -05001883 commit_list=opts.commits,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001884 presubmit=opts.pre_submit)
Doug Anderson44a644f2011-11-02 10:37:37 -07001885 if found_error:
1886 return 1
1887 return 0
1888
1889
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07001890if __name__ == '__main__':
Mike Frysinger55f85b52014-12-18 14:45:21 -05001891 sys.exit(direct_main(sys.argv[1:]))