blob: 7db459e5d41c3f731f7f76ca1c2dc409a19f16ba [file] [log] [blame]
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08001#!/usr/bin/env python2
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002# -*- coding: utf-8 -*-
Jon Salz98255932012-08-18 14:48:02 +08003# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
Mike Frysingerae409522014-02-01 03:16:11 -05007"""Presubmit checks to run when doing `repo upload`.
8
9You can add new checks by adding a functions to the HOOKS constants.
10"""
11
Mike Frysinger09d6a3d2013-10-08 22:21:03 -040012from __future__ import print_function
13
Filipe Brandenburger4b542b12015-10-09 12:46:31 -070014import argparse
Alex Deymo643ac4c2015-09-03 10:40:50 -070015import collections
Ryan Cui9b651632011-05-11 11:38:58 -070016import ConfigParser
Daniel Erate3ea3fc2015-02-13 15:27:52 -070017import fnmatch
Jon Salz3ee59de2012-08-18 13:54:22 +080018import functools
Dale Curtis2975c432011-05-03 17:25:20 -070019import json
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070020import os
Ryan Cuiec4d6332011-05-02 14:15:25 -070021import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070022import sys
Peter Ammon811f6702014-06-12 15:45:38 -070023import stat
Aviv Keshet5ac59522017-01-31 14:28:27 -080024import StringIO
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070025
Ryan Cui1562fb82011-05-09 11:01:31 -070026from errors import (VerifyException, HookFailure, PrintErrorForProject,
27 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070028
David Jamesc3b68b32013-04-03 09:17:03 -070029# If repo imports us, the __name__ will be __builtin__, and the wrapper will
30# be in $CHROMEOS_CHECKOUT/.repo/repo/main.py, so we need to go two directories
31# up. The same logic also happens to work if we're executed directly.
32if __name__ in ('__builtin__', '__main__'):
33 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
34
Mike Frysinger66142932014-12-18 14:55:57 -050035from chromite.lib import commandline
Aviv Keshet5ac59522017-01-31 14:28:27 -080036from chromite.lib import constants
Rahul Chaudhry0e515342015-08-07 12:00:43 -070037from chromite.lib import cros_build_lib
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050038from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070039from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070040from chromite.lib import patch
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040041from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070042
Vadim Bendebury2b62d742014-06-22 13:14:51 -070043PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070044
45COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050046 # C++ and friends
47 r".*\.c$", r".*\.cc$", r".*\.cpp$", r".*\.h$", r".*\.m$", r".*\.mm$",
48 r".*\.inl$", r".*\.asm$", r".*\.hxx$", r".*\.hpp$", r".*\.s$", r".*\.S$",
49 # Scripts
50 r".*\.js$", r".*\.py$", r".*\.sh$", r".*\.rb$", r".*\.pl$", r".*\.pm$",
51 # No extension at all, note that ALL CAPS files are black listed in
52 # COMMON_EXCLUDED_LIST below.
53 r"(^|.*[\\\/])[^.]+$",
54 # Other
55 r".*\.java$", r".*\.mk$", r".*\.am$",
Brian Norrisfdbac8e2016-06-16 11:09:05 -070056 r".*\.policy$", r".*\.conf$",
Ryan Cuiec4d6332011-05-02 14:15:25 -070057]
58
Ryan Cui1562fb82011-05-09 11:01:31 -070059
Ryan Cuiec4d6332011-05-02 14:15:25 -070060COMMON_EXCLUDED_PATHS = [
Daniel Erate3ea3fc2015-02-13 15:27:52 -070061 # For ebuild trees, ignore any caches and manifest data.
Mike Frysingerae409522014-02-01 03:16:11 -050062 r".*/Manifest$",
63 r".*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$",
Doug Anderson5bfb6792011-10-25 16:45:41 -070064
Daniel Erate3ea3fc2015-02-13 15:27:52 -070065 # Ignore profiles data (like overlay-tegra2/profiles).
Mike Frysinger94a670c2014-09-19 12:46:26 -040066 r"(^|.*/)overlay-.*/profiles/.*",
Mike Frysinger98638102014-08-28 00:15:08 -040067 r"^profiles/.*$",
68
C Shapiro8f90e9b2017-06-28 09:54:50 -060069 # Ignore config files in ebuild setup.
70 r"(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*",
71 r"^chromeos-base/chromeos-bsp.*/files/.*",
72
Daniel Erate3ea3fc2015-02-13 15:27:52 -070073 # Ignore minified js and jquery.
Mike Frysingerae409522014-02-01 03:16:11 -050074 r".*\.min\.js",
75 r".*jquery.*\.js",
Mike Frysinger33a458d2014-03-03 17:00:51 -050076
77 # Ignore license files as the content is often taken verbatim.
Daniel Erate3ea3fc2015-02-13 15:27:52 -070078 r".*/licenses/.*",
Ryan Cuiec4d6332011-05-02 14:15:25 -070079]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070080
Ryan Cui1562fb82011-05-09 11:01:31 -070081
Ryan Cui9b651632011-05-11 11:38:58 -070082_CONFIG_FILE = 'PRESUBMIT.cfg'
83
84
Daniel Erate3ea3fc2015-02-13 15:27:52 -070085# File containing wildcards, one per line, matching files that should be
86# excluded from presubmit checks. Lines beginning with '#' are ignored.
87_IGNORE_FILE = '.presubmitignore'
88
89
Doug Anderson44a644f2011-11-02 10:37:37 -070090# Exceptions
91
92
93class BadInvocation(Exception):
94 """An Exception indicating a bad invocation of the program."""
95 pass
96
97
Ryan Cui1562fb82011-05-09 11:01:31 -070098# General Helpers
99
Sean Paulba01d402011-05-05 11:36:23 -0400100
Alex Deymo643ac4c2015-09-03 10:40:50 -0700101Project = collections.namedtuple('Project', ['name', 'dir', 'remote'])
102
103
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700104# pylint: disable=redefined-builtin
105def _run_command(cmd, cwd=None, input=None,
106 redirect_stderr=False, combine_stdout_stderr=False):
Doug Anderson44a644f2011-11-02 10:37:37 -0700107 """Executes the passed in command and returns raw stdout output.
108
109 Args:
110 cmd: The command to run; should be a list of strings.
111 cwd: The directory to switch to for running the command.
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700112 input: The data to pipe into this command through stdin. If a file object
113 or file descriptor, stdin will be connected directly to that.
114 redirect_stderr: Redirect stderr away from console.
115 combine_stdout_stderr: Combines stdout and stderr streams into stdout.
Doug Anderson44a644f2011-11-02 10:37:37 -0700116
117 Returns:
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700118 The stdout from the process (discards stderr and returncode).
Doug Anderson44a644f2011-11-02 10:37:37 -0700119 """
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700120 return cros_build_lib.RunCommand(cmd=cmd,
121 cwd=cwd,
122 print_cmd=False,
123 input=input,
124 stdout_to_pipe=True,
125 redirect_stderr=redirect_stderr,
126 combine_stdout_stderr=combine_stdout_stderr,
127 error_code_ok=True).output
128# pylint: enable=redefined-builtin
Ryan Cui72834d12011-05-05 14:51:33 -0700129
Ryan Cui1562fb82011-05-09 11:01:31 -0700130
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700131def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700132 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700133 if __name__ == '__main__':
134 # Works when file is run on its own (__file__ is defined)...
135 return os.path.abspath(os.path.dirname(__file__))
136 else:
137 # We need to do this when we're run through repo. Since repo executes
138 # us with execfile(), we don't get __file__ defined.
139 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
140 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700141
Ryan Cui1562fb82011-05-09 11:01:31 -0700142
Ryan Cuiec4d6332011-05-02 14:15:25 -0700143def _match_regex_list(subject, expressions):
144 """Try to match a list of regular expressions to a string.
145
146 Args:
147 subject: The string to match regexes on
148 expressions: A list of regular expressions to check for matches with.
149
150 Returns:
151 Whether the passed in subject matches any of the passed in regexes.
152 """
153 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500154 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700155 return True
156 return False
157
Ryan Cui1562fb82011-05-09 11:01:31 -0700158
Mike Frysingerae409522014-02-01 03:16:11 -0500159def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700160 """Filter out files based on the conditions passed in.
161
162 Args:
163 files: list of filepaths to filter
164 include_list: list of regex that when matched with a file path will cause it
165 to be added to the output list unless the file is also matched with a
166 regex in the exclude_list.
167 exclude_list: list of regex that when matched with a file will prevent it
168 from being added to the output list, even if it is also matched with a
169 regex in the include_list.
170
171 Returns:
172 A list of filepaths that contain files matched in the include_list and not
173 in the exclude_list.
174 """
175 filtered = []
176 for f in files:
177 if (_match_regex_list(f, include_list) and
178 not _match_regex_list(f, exclude_list)):
179 filtered.append(f)
180 return filtered
181
Ryan Cuiec4d6332011-05-02 14:15:25 -0700182
183# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700184
185
Ryan Cui4725d952011-05-05 15:41:19 -0700186def _get_upstream_branch():
187 """Returns the upstream tracking branch of the current branch.
188
189 Raises:
190 Error if there is no tracking branch
191 """
192 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
193 current_branch = current_branch.replace('refs/heads/', '')
194 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700195 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700196
197 cfg_option = 'branch.' + current_branch + '.%s'
198 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
199 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
200 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700201 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700202
203 return full_upstream.replace('heads', 'remotes/' + remote)
204
Ryan Cui1562fb82011-05-09 11:01:31 -0700205
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700206def _get_patch(commit):
207 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700208 if commit == PRE_SUBMIT:
209 return _run_command(['git', 'diff', '--cached', 'HEAD'])
210 else:
211 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700212
Ryan Cui1562fb82011-05-09 11:01:31 -0700213
Jon Salz98255932012-08-18 14:48:02 +0800214def _try_utf8_decode(data):
215 """Attempts to decode a string as UTF-8.
216
217 Returns:
218 The decoded Unicode object, or the original string if parsing fails.
219 """
220 try:
221 return unicode(data, 'utf-8', 'strict')
222 except UnicodeDecodeError:
223 return data
224
225
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500226def _get_file_content(path, commit):
227 """Returns the content of a file at a specific commit.
228
229 We can't rely on the file as it exists in the filesystem as people might be
230 uploading a series of changes which modifies the file multiple times.
231
232 Note: The "content" of a symlink is just the target. So if you're expecting
233 a full file, you should check that first. One way to detect is that the
234 content will not have any newlines.
235 """
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700236 if commit == PRE_SUBMIT:
237 return _run_command(['git', 'diff', 'HEAD', path])
238 else:
Mike Frysingerd0523442018-01-03 17:05:29 -0500239 # Make sure people don't accidentally pass in full paths which will never
240 # work. You need to use relative=True with _get_affected_files.
241 if path.startswith('/'):
242 raise ValueError('_get_file_content must be called with relative paths: '
243 + path)
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700244 return _run_command(['git', 'show', '%s:%s' % (commit, path)])
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500245
246
Mike Frysingerae409522014-02-01 03:16:11 -0500247def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700248 """Returns a list of (linenum, lines) tuples that the commit touched."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700249 if commit == PRE_SUBMIT:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800250 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD',
251 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700252 else:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800253 command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit,
254 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700255 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700256
257 new_lines = []
258 line_num = 0
259 for line in output.splitlines():
260 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
261 if m:
262 line_num = int(m.groups(1)[0])
263 continue
264 if line.startswith('+') and not line.startswith('++'):
Jon Salz98255932012-08-18 14:48:02 +0800265 new_lines.append((line_num, _try_utf8_decode(line[1:])))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700266 if not line.startswith('-'):
267 line_num += 1
268 return new_lines
269
Ryan Cui1562fb82011-05-09 11:01:31 -0700270
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700271def _get_ignore_wildcards(directory, cache):
272 """Get wildcards listed in a directory's _IGNORE_FILE.
273
274 Args:
275 directory: A string containing a directory path.
276 cache: A dictionary (opaque to caller) caching previously-read wildcards.
277
278 Returns:
279 A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE
280 wasn't present.
281 """
282 # In the cache, keys are directories and values are lists of wildcards from
283 # _IGNORE_FILE within those directories (and empty if no file was present).
284 if directory not in cache:
285 wildcards = []
286 dotfile_path = os.path.join(directory, _IGNORE_FILE)
287 if os.path.exists(dotfile_path):
288 # TODO(derat): Consider using _get_file_content() to get the file as of
289 # this commit instead of the on-disk version. This may have a noticeable
290 # performance impact, as each call to _get_file_content() runs git.
291 with open(dotfile_path, 'r') as dotfile:
292 for line in dotfile.readlines():
293 line = line.strip()
294 if line.startswith('#'):
295 continue
296 if line.endswith('/'):
297 line += '*'
298 wildcards.append(line)
299 cache[directory] = wildcards
300
301 return cache[directory]
302
303
304def _path_is_ignored(path, cache):
305 """Check whether a path is ignored by _IGNORE_FILE.
306
307 Args:
308 path: A string containing a path.
309 cache: A dictionary (opaque to caller) caching previously-read wildcards.
310
311 Returns:
312 True if a file named _IGNORE_FILE in one of the passed-in path's parent
313 directories contains a wildcard matching the path.
314 """
315 # Skip ignore files.
316 if os.path.basename(path) == _IGNORE_FILE:
317 return True
318
319 path = os.path.abspath(path)
320 base = os.getcwd()
321
322 prefix = os.path.dirname(path)
323 while prefix.startswith(base):
324 rel_path = path[len(prefix) + 1:]
325 for wildcard in _get_ignore_wildcards(prefix, cache):
326 if fnmatch.fnmatch(rel_path, wildcard):
327 return True
328 prefix = os.path.dirname(prefix)
329
330 return False
331
332
Mike Frysinger292b45d2014-11-25 01:17:10 -0500333def _get_affected_files(commit, include_deletes=False, relative=False,
334 include_symlinks=False, include_adds=True,
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700335 full_details=False, use_ignore_files=True):
Peter Ammon811f6702014-06-12 15:45:38 -0700336 """Returns list of file paths that were modified/added, excluding symlinks.
337
338 Args:
339 commit: The commit
340 include_deletes: If true, we'll include deleted files in the result
341 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500342 include_symlinks: If true, we'll include symlinks in the result
343 include_adds: If true, we'll include new files in the result
344 full_details: If False, return filenames, else return structured results.
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700345 use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files.
Peter Ammon811f6702014-06-12 15:45:38 -0700346
347 Returns:
348 A list of modified/added (and perhaps deleted) files
349 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500350 if not relative and full_details:
351 raise ValueError('full_details only supports relative paths currently')
352
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700353 if commit == PRE_SUBMIT:
354 return _run_command(['git', 'diff-index', '--cached',
355 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500356
357 path = os.getcwd()
358 files = git.RawDiff(path, '%s^!' % commit)
359
360 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500361 if not include_symlinks:
362 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500363
364 if not include_deletes:
365 files = [x for x in files if x.status != 'D']
366
Mike Frysinger292b45d2014-11-25 01:17:10 -0500367 if not include_adds:
368 files = [x for x in files if x.status != 'A']
369
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700370 if use_ignore_files:
371 cache = {}
372 is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache)
373 files = [x for x in files if not is_ignored(x)]
374
Mike Frysinger292b45d2014-11-25 01:17:10 -0500375 if full_details:
376 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500377 return files
378 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500379 # Caller only cares about filenames.
380 files = [x.dst_file if x.dst_file else x.src_file for x in files]
381 if relative:
382 return files
383 else:
384 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700385
386
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700387def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700388 """Returns a list of commits for this review."""
Ryan Cui4725d952011-05-05 15:41:19 -0700389 cmd = ['git', 'log', '%s..' % _get_upstream_branch(), '--format=%H']
Ryan Cui72834d12011-05-05 14:51:33 -0700390 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700391
Ryan Cui1562fb82011-05-09 11:01:31 -0700392
Ryan Cuiec4d6332011-05-02 14:15:25 -0700393def _get_commit_desc(commit):
394 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700395 if commit == PRE_SUBMIT:
396 return ''
Sean Paul23a2c582011-05-06 13:10:44 -0400397 return _run_command(['git', 'log', '--format=%s%n%n%b', commit + '^!'])
Ryan Cuiec4d6332011-05-02 14:15:25 -0700398
399
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800400def _check_lines_in_diff(commit, files, check_callable, error_description):
401 """Checks given file for errors via the given check.
402
403 This is a convenience function for common per-line checks. It goes through all
404 files and returns a HookFailure with the error description listing all the
405 failures.
406
407 Args:
408 commit: The commit we're working on.
409 files: The files to check.
410 check_callable: A callable that takes a line and returns True if this line
411 _fails_ the check.
412 error_description: A string describing the error.
413 """
414 errors = []
415 for afile in files:
416 for line_num, line in _get_file_diff(afile, commit):
417 if check_callable(line):
418 errors.append('%s, line %s' % (afile, line_num))
419 if errors:
420 return HookFailure(error_description, errors)
421
422
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900423def _parse_common_inclusion_options(options):
424 """Parses common hook options for including/excluding files.
425
426 Args:
427 options: Option string list.
428
429 Returns:
430 (included, excluded) where each one is a list of regex strings.
431 """
432 parser = argparse.ArgumentParser()
433 parser.add_argument('--exclude_regex', action='append')
434 parser.add_argument('--include_regex', action='append')
435 opts = parser.parse_args(options)
436 included = opts.include_regex or []
437 excluded = opts.exclude_regex or []
438 return included, excluded
439
440
Ryan Cuiec4d6332011-05-02 14:15:25 -0700441# Common Hooks
442
Ryan Cui1562fb82011-05-09 11:01:31 -0700443
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900444def _check_no_long_lines(_project, commit, options=()):
Mike Frysinger55f85b52014-12-18 14:45:21 -0500445 """Checks there are no lines longer than MAX_LEN in any of the text files."""
446
Ryan Cuiec4d6332011-05-02 14:15:25 -0700447 MAX_LEN = 80
Jon Salz98255932012-08-18 14:48:02 +0800448 SKIP_REGEXP = re.compile('|'.join([
449 r'https?://',
450 r'^#\s*(define|include|import|pragma|if|endif)\b']))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700451
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900452 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700453 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900454 included + COMMON_INCLUDED_PATHS,
455 excluded + COMMON_EXCLUDED_PATHS)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700456
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900457 errors = []
Ryan Cuiec4d6332011-05-02 14:15:25 -0700458 for afile in files:
459 for line_num, line in _get_file_diff(afile, commit):
460 # Allow certain lines to exceed the maxlen rule.
Mike Frysingerae409522014-02-01 03:16:11 -0500461 if len(line) <= MAX_LEN or SKIP_REGEXP.search(line):
Jon Salz98255932012-08-18 14:48:02 +0800462 continue
463
464 errors.append('%s, line %s, %s chars' % (afile, line_num, len(line)))
465 if len(errors) == 5: # Just show the first 5 errors.
466 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700467
468 if errors:
469 msg = 'Found lines longer than %s characters (first 5 shown):' % MAX_LEN
Ryan Cui1562fb82011-05-09 11:01:31 -0700470 return HookFailure(msg, errors)
471
Ryan Cuiec4d6332011-05-02 14:15:25 -0700472
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900473def _check_no_stray_whitespace(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700474 """Checks that there is no stray whitespace at source lines end."""
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900475 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700476 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900477 included + COMMON_INCLUDED_PATHS,
478 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800479 return _check_lines_in_diff(commit, files,
480 lambda line: line.rstrip() != line,
481 'Found line ending with white space in:')
Ryan Cui1562fb82011-05-09 11:01:31 -0700482
Ryan Cuiec4d6332011-05-02 14:15:25 -0700483
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900484def _check_no_tabs(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700485 """Checks there are no unexpanded tabs."""
Mike Frysingercd134512017-10-26 04:36:33 -0400486 # Don't add entire repos here. Update the PRESUBMIT.cfg in each repo instead.
487 # We only whitelist known specific filetypes here that show up in all repos.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700488 TAB_OK_PATHS = [
Ryan Cuiec4d6332011-05-02 14:15:25 -0700489 r".*\.ebuild$",
490 r".*\.eclass$",
Elly Jones5ab34192011-11-15 14:57:06 -0500491 r".*/[M|m]akefile$",
492 r".*\.mk$"
Ryan Cuiec4d6332011-05-02 14:15:25 -0700493 ]
494
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900495 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700496 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900497 included + COMMON_INCLUDED_PATHS,
498 excluded + COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800499 return _check_lines_in_diff(commit, files,
500 lambda line: '\t' in line,
501 'Found a tab character in:')
Ryan Cuiec4d6332011-05-02 14:15:25 -0700502
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800503
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900504def _check_tabbed_indents(_project, commit, options=()):
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800505 """Checks that indents use tabs only."""
506 TABS_REQUIRED_PATHS = [
507 r".*\.ebuild$",
508 r".*\.eclass$",
509 ]
510 LEADING_SPACE_RE = re.compile('[\t]* ')
511
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900512 included, excluded = _parse_common_inclusion_options(options)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800513 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900514 included + TABS_REQUIRED_PATHS,
515 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800516 return _check_lines_in_diff(
517 commit, files,
518 lambda line: LEADING_SPACE_RE.match(line) is not None,
519 'Found a space in indentation (must be all tabs):')
Ryan Cui1562fb82011-05-09 11:01:31 -0700520
Ryan Cuiec4d6332011-05-02 14:15:25 -0700521
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700522def _check_gofmt(_project, commit):
523 """Checks that Go files are formatted with gofmt."""
524 errors = []
525 files = _filter_files(_get_affected_files(commit, relative=True),
526 [r'\.go$'])
527
528 for gofile in files:
529 contents = _get_file_content(gofile, commit)
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700530 output = _run_command(cmd=['gofmt', '-l'], input=contents,
531 combine_stdout_stderr=True)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700532 if output:
533 errors.append(gofile)
534 if errors:
535 return HookFailure('Files not formatted with gofmt:', errors)
536
537
Mike Frysingerae409522014-02-01 03:16:11 -0500538def _check_change_has_test_field(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700539 """Check for a non-empty 'TEST=' field in the commit message."""
David McMahon8f6553e2011-06-10 15:46:36 -0700540 TEST_RE = r'\nTEST=\S+'
Ryan Cuiec4d6332011-05-02 14:15:25 -0700541
Mandeep Singh Baines96a53be2011-05-03 11:10:25 -0700542 if not re.search(TEST_RE, _get_commit_desc(commit)):
Ryan Cui1562fb82011-05-09 11:01:31 -0700543 msg = 'Changelist description needs TEST field (after first line)'
544 return HookFailure(msg)
545
Ryan Cuiec4d6332011-05-02 14:15:25 -0700546
Mike Frysingerae409522014-02-01 03:16:11 -0500547def _check_change_has_valid_cq_depend(_project, commit):
David Jamesc3b68b32013-04-03 09:17:03 -0700548 """Check for a correctly formatted CQ-DEPEND field in the commit message."""
549 msg = 'Changelist has invalid CQ-DEPEND target.'
550 example = 'Example: CQ-DEPEND=CL:1234, CL:2345'
551 try:
552 patch.GetPaladinDeps(_get_commit_desc(commit))
553 except ValueError as ex:
554 return HookFailure(msg, [example, str(ex)])
555
556
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800557def _check_change_is_contribution(_project, commit):
558 """Check that the change is a contribution."""
559 NO_CONTRIB = 'not a contribution'
560 if NO_CONTRIB in _get_commit_desc(commit).lower():
561 msg = ('Changelist is not a contribution, this cannot be accepted.\n'
562 'Please remove the "%s" text from the commit message.') % NO_CONTRIB
563 return HookFailure(msg)
564
565
Alex Deymo643ac4c2015-09-03 10:40:50 -0700566def _check_change_has_bug_field(project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700567 """Check for a correctly formatted 'BUG=' field in the commit message."""
David James5c0073d2013-04-03 08:48:52 -0700568 OLD_BUG_RE = r'\nBUG=.*chromium-os'
569 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
570 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
571 'the chromium tracker in your BUG= line now.')
572 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700573
Alex Deymo643ac4c2015-09-03 10:40:50 -0700574 # Android internal and external projects use "Bug: " to track bugs in
575 # buganizer.
576 BUG_COLON_REMOTES = (
577 'aosp',
578 'goog',
579 )
580 if project.remote in BUG_COLON_REMOTES:
581 BUG_RE = r'\nBug: ?([Nn]one|\d+)'
582 if not re.search(BUG_RE, _get_commit_desc(commit)):
583 msg = ('Changelist description needs BUG field (after first line):\n'
584 'Bug: 9999 (for buganizer)\n'
585 'BUG=None')
586 return HookFailure(msg)
587 else:
Jorge Lucangeli Obesdce214e2017-10-25 15:04:39 -0400588 BUG_RE = r'\nBUG=([Nn]one|(chromium|b):\d+)'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700589 if not re.search(BUG_RE, _get_commit_desc(commit)):
590 msg = ('Changelist description needs BUG field (after first line):\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700591 'BUG=chromium:9999 (for public tracker)\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700592 'BUG=b:9999 (for buganizer)\n'
593 'BUG=None')
594 return HookFailure(msg)
Ryan Cui1562fb82011-05-09 11:01:31 -0700595
Ryan Cuiec4d6332011-05-02 14:15:25 -0700596
Mike Frysinger292b45d2014-11-25 01:17:10 -0500597def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -0700598 """Check that we're not missing a revbump of an ebuild in the given commit.
599
600 If the given commit touches files in a directory that has ebuilds somewhere
601 up the directory hierarchy, it's very likely that we need an ebuild revbump
602 in order for those changes to take effect.
603
604 It's not totally trivial to detect a revbump, so at least detect that an
605 ebuild with a revision number in it was touched. This should handle the
606 common case where we use a symlink to do the revbump.
607
608 TODO: it would be nice to enhance this hook to:
609 * Handle cases where people revbump with a slightly different syntax. I see
610 one ebuild (puppy) that revbumps with _pN. This is a false positive.
611 * Catches cases where people aren't using symlinks for revbumps. If they
612 edit a revisioned file directly (and are expected to rename it for revbump)
613 we'll miss that. Perhaps we could detect that the file touched is a
614 symlink?
615
616 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
617 still better off than without this check.
618
619 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700620 project: The Project to look at
Doug Anderson42b8a052013-06-26 10:45:36 -0700621 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -0500622 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -0700623
624 Returns:
625 A HookFailure or None.
626 """
Mike Frysinger011af942014-01-17 16:12:22 -0500627 # If this is the portage-stable overlay, then ignore the check. It's rare
628 # that we're doing anything other than importing files from upstream, so
629 # forcing a rev bump makes no sense.
630 whitelist = (
631 'chromiumos/overlays/portage-stable',
632 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700633 if project.name in whitelist:
Mike Frysinger011af942014-01-17 16:12:22 -0500634 return None
635
Mike Frysinger292b45d2014-11-25 01:17:10 -0500636 def FinalName(obj):
637 # If the file is being deleted, then the dst_file is not set.
638 if obj.dst_file is None:
639 return obj.src_file
640 else:
641 return obj.dst_file
642
643 affected_path_objs = _get_affected_files(
644 commit, include_deletes=True, include_symlinks=True, relative=True,
645 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -0700646
647 # Don't yell about changes to whitelisted files...
Aviv Keshet272f2e52016-04-25 14:49:44 -0700648 whitelist = ('ChangeLog', 'Manifest', 'metadata.xml', 'COMMIT-QUEUE.ini')
Mike Frysinger292b45d2014-11-25 01:17:10 -0500649 affected_path_objs = [x for x in affected_path_objs
650 if os.path.basename(FinalName(x)) not in whitelist]
651 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -0700652 return None
653
654 # If we've touched any file named with a -rN.ebuild then we'll say we're
655 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500656 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
657 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700658 if touched_revved_ebuild:
659 return None
660
Mike Frysinger292b45d2014-11-25 01:17:10 -0500661 # If we're creating new ebuilds from scratch, then we don't need an uprev.
662 # Find all the dirs that new ebuilds and ignore their files/.
663 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
664 if FinalName(x).endswith('.ebuild') and x.status == 'A']
665 affected_path_objs = [obj for obj in affected_path_objs
666 if not any(FinalName(obj).startswith(x)
667 for x in ebuild_dirs)]
668 if not affected_path_objs:
669 return
670
Doug Anderson42b8a052013-06-26 10:45:36 -0700671 # We want to examine the current contents of all directories that are parents
672 # of files that were touched (up to the top of the project).
673 #
674 # ...note: we use the current directory contents even though it may have
675 # changed since the commit we're looking at. This is just a heuristic after
676 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500677 if project_top is None:
678 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -0700679 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -0500680 for obj in affected_path_objs:
681 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -0700682 while os.path.exists(path) and not os.path.samefile(path, project_top):
683 dirs_to_check.add(path)
684 path = os.path.dirname(path)
685
686 # Look through each directory. If it's got an ebuild in it then we'll
687 # consider this as a case when we need a revbump.
Gwendal Grignoua3086c32014-12-09 11:17:22 -0800688 affected_paths = set(os.path.join(project_top, FinalName(x))
689 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700690 for dir_path in dirs_to_check:
691 contents = os.listdir(dir_path)
692 ebuilds = [os.path.join(dir_path, path)
693 for path in contents if path.endswith('.ebuild')]
694 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
695
C Shapiroae157ae2017-09-18 16:24:03 -0600696 affected_paths_under_9999_ebuilds = set()
697 for affected_path in affected_paths:
698 for ebuild_9999 in ebuilds_9999:
699 ebuild_dir = os.path.dirname(ebuild_9999)
700 if affected_path.startswith(ebuild_dir):
701 affected_paths_under_9999_ebuilds.add(affected_path)
702
703 # If every file changed exists under a 9999 ebuild, then skip
704 if len(affected_paths_under_9999_ebuilds) == len(affected_paths):
705 continue
706
Doug Anderson42b8a052013-06-26 10:45:36 -0700707 # If the -9999.ebuild file was touched the bot will uprev for us.
708 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -0500709 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -0700710 continue
711
712 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500713 return HookFailure('Changelist probably needs a revbump of an ebuild, '
714 'or a -r1.ebuild symlink if this is a new ebuild:\n'
715 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -0700716
717 return None
718
719
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500720def _check_ebuild_eapi(project, commit):
721 """Make sure we have people use EAPI=4 or newer with custom ebuilds.
722
723 We want to get away from older EAPI's as it makes life confusing and they
724 have less builtin error checking.
725
726 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700727 project: The Project to look at
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500728 commit: The commit to look at
729
730 Returns:
731 A HookFailure or None.
732 """
733 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500734 # that we're doing anything other than importing files from upstream, and
735 # we shouldn't be rewriting things fundamentally anyways.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500736 whitelist = (
737 'chromiumos/overlays/portage-stable',
738 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700739 if project.name in whitelist:
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500740 return None
741
742 BAD_EAPIS = ('0', '1', '2', '3')
743
744 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
745
746 ebuilds_re = [r'\.ebuild$']
747 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
748 ebuilds_re)
749 bad_ebuilds = []
750
751 for ebuild in ebuilds:
752 # If the ebuild does not specify an EAPI, it defaults to 0.
753 eapi = '0'
754
755 lines = _get_file_content(ebuild, commit).splitlines()
756 if len(lines) == 1:
757 # This is most likely a symlink, so skip it entirely.
758 continue
759
760 for line in lines:
761 m = get_eapi.match(line)
762 if m:
763 # Once we hit the first EAPI line in this ebuild, stop processing.
764 # The spec requires that there only be one and it be first, so
765 # checking all possible values is pointless. We also assume that
766 # it's "the" EAPI line and not something in the middle of a heredoc.
767 eapi = m.group(1)
768 break
769
770 if eapi in BAD_EAPIS:
771 bad_ebuilds.append((ebuild, eapi))
772
773 if bad_ebuilds:
774 # pylint: disable=C0301
775 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
776 # pylint: enable=C0301
777 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500778 'These ebuilds are using old EAPIs. If these are imported from\n'
779 'Gentoo, then you may ignore and upload once with the --no-verify\n'
780 'flag. Otherwise, please update to 4 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500781 '\t%s\n'
782 'See this guide for more details:\n%s\n' %
783 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
784
785
Mike Frysinger89bdb852014-02-01 05:26:26 -0500786def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -0500787 """Make sure we use the new style KEYWORDS when possible in ebuilds.
788
789 If an ebuild generally does not care about the arch it is running on, then
790 ebuilds should flag it with one of:
791 KEYWORDS="*" # A stable ebuild.
792 KEYWORDS="~*" # An unstable ebuild.
793 KEYWORDS="-* ..." # Is known to only work on specific arches.
794
795 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700796 project: The Project to look at
Mike Frysingerc51ece72014-01-17 16:23:40 -0500797 commit: The commit to look at
798
799 Returns:
800 A HookFailure or None.
801 """
802 WHITELIST = set(('*', '-*', '~*'))
803
804 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
805
Mike Frysinger89bdb852014-02-01 05:26:26 -0500806 ebuilds_re = [r'\.ebuild$']
807 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
808 ebuilds_re)
809
Mike Frysinger8d42d742014-09-22 15:50:21 -0400810 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -0500811 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -0400812 # We get the full content rather than a diff as the latter does not work
813 # on new files (like when adding new ebuilds).
814 lines = _get_file_content(ebuild, commit).splitlines()
815 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -0500816 m = get_keywords.match(line)
817 if m:
818 keywords = set(m.group(1).split())
819 if not keywords or WHITELIST - keywords != WHITELIST:
820 continue
821
Mike Frysinger8d42d742014-09-22 15:50:21 -0400822 bad_ebuilds.append(ebuild)
823
824 if bad_ebuilds:
825 return HookFailure(
826 '%s\n'
827 'Please update KEYWORDS to use a glob:\n'
828 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
829 ' KEYWORDS="*"\n'
830 'If the ebuild should be marked unstable (normal for '
831 'cros-workon / 9999 ebuilds):\n'
832 ' KEYWORDS="~*"\n'
Mike Frysingerde8efea2015-05-17 03:42:26 -0400833 'If the ebuild needs to be marked for only specific arches, '
Mike Frysinger8d42d742014-09-22 15:50:21 -0400834 'then use -* like so:\n'
835 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -0500836
837
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800838def _check_ebuild_licenses(_project, commit):
839 """Check if the LICENSE field in the ebuild is correct."""
Brian Norris7a610e82016-02-17 12:24:54 -0800840 affected_paths = _get_affected_files(commit, relative=True)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800841 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
842
843 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -0800844 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800845
846 for ebuild in touched_ebuilds:
847 # Skip virutal packages.
848 if ebuild.split('/')[-3] == 'virtual':
849 continue
850
851 try:
Brian Norris7a610e82016-02-17 12:24:54 -0800852 ebuild_content = _get_file_content(ebuild, commit)
853 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800854 except ValueError as e:
855 return HookFailure(e.message, [ebuild])
856
857 # Also ignore licenses ending with '?'
858 for license_type in [x for x in license_types
859 if x not in LICENSES_IGNORE and not x.endswith('?')]:
860 try:
Mike Frysinger2ec70ed2014-08-17 19:28:34 -0400861 licenses_lib.Licensing.FindLicenseType(license_type)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800862 except AssertionError as e:
863 return HookFailure(e.message, [ebuild])
864
865
Mike Frysingercd363c82014-02-01 05:20:18 -0500866def _check_ebuild_virtual_pv(project, commit):
867 """Enforce the virtual PV policies."""
868 # If this is the portage-stable overlay, then ignore the check.
869 # We want to import virtuals as-is from upstream Gentoo.
870 whitelist = (
871 'chromiumos/overlays/portage-stable',
872 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700873 if project.name in whitelist:
Mike Frysingercd363c82014-02-01 05:20:18 -0500874 return None
875
876 # We assume the repo name is the same as the dir name on disk.
877 # It would be dumb to not have them match though.
Alex Deymo643ac4c2015-09-03 10:40:50 -0700878 project_base = os.path.basename(project.name)
Mike Frysingercd363c82014-02-01 05:20:18 -0500879
880 is_variant = lambda x: x.startswith('overlay-variant-')
881 is_board = lambda x: x.startswith('overlay-')
882 is_private = lambda x: x.endswith('-private')
883
884 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
885
886 ebuilds_re = [r'\.ebuild$']
887 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
888 ebuilds_re)
889 bad_ebuilds = []
890
891 for ebuild in ebuilds:
892 m = get_pv.match(ebuild)
893 if m:
894 overlay = m.group(1)
895 if not overlay or not is_board(overlay):
Alex Deymo643ac4c2015-09-03 10:40:50 -0700896 overlay = project_base
Mike Frysingercd363c82014-02-01 05:20:18 -0500897
898 pv = m.group(3).split('-', 1)[0]
899
Bernie Thompsone5ee1822016-01-12 14:22:23 -0800900 # Virtual versions >= 4 are special cases used above the standard
901 # versioning structure, e.g. if one has a board inheriting a board.
902 if float(pv) >= 4:
903 want_pv = pv
904 elif is_private(overlay):
Mike Frysingercd363c82014-02-01 05:20:18 -0500905 want_pv = '3.5' if is_variant(overlay) else '3'
906 elif is_board(overlay):
907 want_pv = '2.5' if is_variant(overlay) else '2'
908 else:
909 want_pv = '1'
910
911 if pv != want_pv:
912 bad_ebuilds.append((ebuild, pv, want_pv))
913
914 if bad_ebuilds:
915 # pylint: disable=C0301
916 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
917 # pylint: enable=C0301
918 return HookFailure(
919 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
920 '\t%s\n'
921 'If this is an upstream Gentoo virtual, then you may ignore this\n'
922 'check (and re-run w/--no-verify). Otherwise, please see this\n'
923 'page for more details:\n%s\n' %
924 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
925 for x in bad_ebuilds]), url))
926
927
Daniel Erat9d203ff2015-02-17 10:12:21 -0700928def _check_portage_make_use_var(_project, commit):
929 """Verify that $USE is set correctly in make.conf and make.defaults."""
930 files = _filter_files(_get_affected_files(commit, relative=True),
931 [r'(^|/)make.(conf|defaults)$'])
932
933 errors = []
934 for path in files:
935 basename = os.path.basename(path)
936
937 # Has a USE= line already been encountered in this file?
938 saw_use = False
939
940 for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1):
941 if not line.startswith('USE='):
942 continue
943
944 preserves_use = '${USE}' in line or '$USE' in line
945
946 if (basename == 'make.conf' or
947 (basename == 'make.defaults' and saw_use)) and not preserves_use:
948 errors.append('%s:%d: missing ${USE}' % (path, i))
949 elif basename == 'make.defaults' and not saw_use and preserves_use:
950 errors.append('%s:%d: ${USE} referenced in initial declaration' %
951 (path, i))
952
953 saw_use = True
954
955 if errors:
956 return HookFailure(
957 'One or more Portage make files appear to set USE incorrectly.\n'
958 '\n'
959 'All USE assignments in make.conf and all assignments after the\n'
960 'initial declaration in make.defaults should contain "${USE}" to\n'
961 'preserve previously-set flags.\n'
962 '\n'
963 'The initial USE declaration in make.defaults should not contain\n'
964 '"${USE}".\n',
965 errors)
966
967
Mike Frysingerae409522014-02-01 03:16:11 -0500968def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -0700969 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -0400970 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -0700971 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -0400972 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -0500973 if not m:
Vadim Bendebury20532ba2017-05-23 17:26:15 -0700974 return HookFailure('Last paragraph of description must include Change-Id.')
Ryan Cui1562fb82011-05-09 11:01:31 -0700975
Vadim Bendebury20532ba2017-05-23 17:26:15 -0700976 # S-o-b tags always allowed to follow Change-ID.
977 allowed_tags = ['Signed-off-by']
978
Mike Frysinger02b88bd2014-11-21 00:29:38 -0500979 end = desc[m.end():].strip().splitlines()
Vadim Bendebury6504aea2017-09-13 18:35:49 -0700980 cherry_pick_marker = 'cherry picked from commit'
981
982 if end and cherry_pick_marker in end[-1]:
Vadim Bendebury20532ba2017-05-23 17:26:15 -0700983 # Cherry picked patches allow more tags in the last paragraph.
Vadim Bendebury6504aea2017-09-13 18:35:49 -0700984 allowed_tags += ['Commit-Queue', 'Commit-Ready', 'Reviewed-by',
985 'Reviewed-on', 'Tested-by']
Vadim Bendebury20532ba2017-05-23 17:26:15 -0700986 end = end[:-1]
987
Vadim Bendebury6504aea2017-09-13 18:35:49 -0700988 # Note that descriptions could have multiple cherry pick markers.
989 tag_search = r'^(%s:|\(%s) ' % (':|'.join(allowed_tags), cherry_pick_marker)
Vadim Bendebury20532ba2017-05-23 17:26:15 -0700990
991 if [x for x in end if not re.search(tag_search, x)]:
992 return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' %
993 ':", "'.join(allowed_tags))
Mike Frysinger02b88bd2014-11-21 00:29:38 -0500994
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -0700995
Mike Frysinger36b2ebc2014-10-31 14:02:03 -0400996def _check_commit_message_style(_project, commit):
997 """Verify that the commit message matches our style.
998
999 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
1000 commit hooks.
1001 """
1002 desc = _get_commit_desc(commit)
1003
1004 # The first line should be by itself.
1005 lines = desc.splitlines()
1006 if len(lines) > 1 and lines[1]:
1007 return HookFailure('The second line of the commit message must be blank.')
1008
1009 # The first line should be one sentence.
1010 if '. ' in lines[0]:
1011 return HookFailure('The first line cannot be more than one sentence.')
1012
1013 # The first line cannot be too long.
1014 MAX_FIRST_LINE_LEN = 100
1015 if len(lines[0]) > MAX_FIRST_LINE_LEN:
1016 return HookFailure('The first line must be less than %i chars.' %
1017 MAX_FIRST_LINE_LEN)
1018
1019
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001020def _check_cros_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001021 """Verifies the Chromium OS license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -07001022
Mike Frysinger98638102014-08-28 00:15:08 -04001023 Should be following the spec:
1024 http://dev.chromium.org/developers/coding-style#TOC-File-headers
1025 """
1026 # For older years, be a bit more flexible as our policy says leave them be.
1027 LICENSE_HEADER = (
1028 r'.* Copyright( \(c\))? 20[-0-9]{2,7} The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001029 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001030 r'.* Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001031 r'be\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001032 r'.* found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -05001033 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001034 )
1035 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1036
1037 # For newer years, be stricter.
1038 COPYRIGHT_LINE = (
1039 r'.* Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001040 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001041 )
1042 copyright_re = re.compile(COPYRIGHT_LINE)
1043
Shuhei Takahashiabc20f32017-07-10 19:35:45 +09001044 included, excluded = _parse_common_inclusion_options(options)
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001045
Mike Frysinger98638102014-08-28 00:15:08 -04001046 bad_files = []
1047 bad_copyright_files = []
1048 files = _filter_files(_get_affected_files(commit, relative=True),
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001049 included + COMMON_INCLUDED_PATHS,
1050 excluded + COMMON_EXCLUDED_PATHS)
Mike Frysinger98638102014-08-28 00:15:08 -04001051
1052 for f in files:
1053 contents = _get_file_content(f, commit)
1054 if not contents:
1055 # Ignore empty files.
1056 continue
1057
1058 if not license_re.search(contents):
1059 bad_files.append(f)
1060 elif copyright_re.search(contents):
1061 bad_copyright_files.append(f)
1062
1063 if bad_files:
1064 msg = '%s:\n%s\n%s' % (
1065 'License must match', license_re.pattern,
1066 'Found a bad header in these files:')
1067 return HookFailure(msg, bad_files)
1068
1069 if bad_copyright_files:
1070 msg = 'Do not use (c) in copyright headers in new files:'
1071 return HookFailure(msg, bad_copyright_files)
Ryan Cuiec4d6332011-05-02 14:15:25 -07001072
1073
Alex Deymof5792ce2015-08-24 22:50:08 -07001074def _check_aosp_license(_project, commit):
1075 """Verifies the AOSP license/copyright header.
1076
1077 AOSP uses the Apache2 License:
1078 https://source.android.com/source/licenses.html
1079 """
1080 LICENSE_HEADER = (
1081 r"""^[#/\*]*
1082[#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project
1083[#/\*]* ?
1084[#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\);
1085[#/\*]* ?you may not use this file except in compliance with the License\.
1086[#/\*]* ?You may obtain a copy of the License at
1087[#/\*]* ?
1088[#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0
1089[#/\*]* ?
1090[#/\*]* ?Unless required by applicable law or agreed to in writing, software
1091[#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS,
1092[#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """
1093 r"""implied\.
1094[#/\*]* ?See the License for the specific language governing permissions and
1095[#/\*]* ?limitations under the License\.
1096[#/\*]*$
1097"""
1098 )
1099 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1100
1101 files = _filter_files(_get_affected_files(commit, relative=True),
1102 COMMON_INCLUDED_PATHS,
1103 COMMON_EXCLUDED_PATHS)
1104
1105 bad_files = []
1106 for f in files:
1107 contents = _get_file_content(f, commit)
1108 if not contents:
1109 # Ignore empty files.
1110 continue
1111
1112 if not license_re.search(contents):
1113 bad_files.append(f)
1114
1115 if bad_files:
1116 msg = ('License must match:\n%s\nFound a bad header in these files:' %
1117 license_re.pattern)
1118 return HookFailure(msg, bad_files)
1119
1120
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001121def _check_layout_conf(_project, commit):
1122 """Verifies the metadata/layout.conf file."""
1123 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001124 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001125 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001126 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001127
Mike Frysinger94a670c2014-09-19 12:46:26 -04001128 # Handle multiple overlays in a single commit (like the public tree).
1129 for f in _get_affected_files(commit, relative=True):
1130 if f.endswith(repo_name):
1131 repo_names.append(f)
1132 elif f.endswith(layout_path):
1133 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001134
1135 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -04001136 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001137 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -04001138 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001139
Mike Frysinger94a670c2014-09-19 12:46:26 -04001140 # Gather all the errors in one pass so we show one full message.
1141 all_errors = {}
1142 for layout_path in layout_paths:
1143 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001144
Mike Frysinger94a670c2014-09-19 12:46:26 -04001145 # Make sure the config file is sorted.
1146 data = [x for x in _get_file_content(layout_path, commit).splitlines()
1147 if x and x[0] != '#']
1148 if sorted(data) != data:
1149 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001150
Mike Frysinger94a670c2014-09-19 12:46:26 -04001151 # Require people to set specific values all the time.
1152 settings = (
1153 # TODO: Enable this for everyone. http://crbug.com/408038
1154 #('fast caching', 'cache-format = md5-dict'),
1155 ('fast manifests', 'thin-manifests = true'),
Mike Frysingerd7734522015-02-26 16:12:43 -05001156 ('extra features', 'profile-formats = portage-2 profile-default-eapi'),
1157 ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001158 )
1159 for reason, line in settings:
1160 if line not in data:
1161 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001162
Mike Frysinger94a670c2014-09-19 12:46:26 -04001163 # Require one of these settings.
Mike Frysinger5fae62d2015-11-11 20:12:15 -05001164 if 'use-manifests = strict' not in data:
1165 errors += ['enable file checking with: use-manifests = strict']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001166
Mike Frysinger94a670c2014-09-19 12:46:26 -04001167 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -04001168 for line in data:
1169 if line.startswith('repo-name = '):
1170 break
1171 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -04001172 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001173
Mike Frysinger94a670c2014-09-19 12:46:26 -04001174 # Summarize all the errors we saw (if any).
1175 lines = ''
1176 for layout_path, errors in all_errors.items():
1177 if errors:
1178 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
1179 if lines:
1180 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
1181 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001182
1183
Ryan Cuiec4d6332011-05-02 14:15:25 -07001184# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001185
Ryan Cui1562fb82011-05-09 11:01:31 -07001186
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001187def _check_clang_format(_project, commit, options=()):
1188 """Runs clang-format on the given project"""
1189 hooks_dir = _get_hooks_dir()
1190 options = list(options)
1191 if commit == PRE_SUBMIT:
1192 options.append('--commit=HEAD')
1193 else:
1194 options.extend(['--commit', commit])
1195 cmd = ['%s/clang-format.py' % hooks_dir] + options
1196 cmd_result = cros_build_lib.RunCommand(cmd=cmd,
1197 print_cmd=False,
1198 input=_get_patch(commit),
1199 stdout_to_pipe=True,
1200 combine_stdout_stderr=True,
1201 error_code_ok=True)
1202 if cmd_result.returncode:
1203 return HookFailure('clang-format.py errors/warnings\n\n' +
1204 cmd_result.output)
1205
1206
Mike Frysingerae409522014-02-01 03:16:11 -05001207def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001208 """Runs checkpatch.pl on the given project"""
1209 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001210 options = list(options)
1211 if commit == PRE_SUBMIT:
1212 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
1213 # this case.
1214 options.append('--ignore=MISSING_SIGN_OFF')
Filipe Brandenburger28d48d62015-10-07 09:48:54 -07001215 # Always ignore the check for the MAINTAINERS file. We do not track that
1216 # information on that file in our source trees, so let's suppress the
1217 # warning.
1218 options.append('--ignore=FILE_PATH_CHANGES')
Filipe Brandenburgerce978322015-10-09 10:04:15 -07001219 # Do not complain about the Change-Id: fields, since we use Gerrit.
1220 # Upstream does not want those lines (since they do not use Gerrit), but
1221 # we always do, so disable the check globally.
Daisuke Nojiri4844f892015-10-08 09:54:33 -07001222 options.append('--ignore=GERRIT_CHANGE_ID')
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001223 cmd = ['%s/checkpatch.pl' % hooks_dir] + options + ['-']
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001224 cmd_result = cros_build_lib.RunCommand(cmd=cmd,
1225 print_cmd=False,
1226 input=_get_patch(commit),
1227 stdout_to_pipe=True,
1228 combine_stdout_stderr=True,
1229 error_code_ok=True)
1230 if cmd_result.returncode:
1231 return HookFailure('checkpatch.pl errors/warnings\n\n' + cmd_result.output)
Ryan Cuiec4d6332011-05-02 14:15:25 -07001232
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001233
Mike Frysingerae409522014-02-01 03:16:11 -05001234def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -07001235 """Makes sure kernel config changes are not mixed with code changes"""
1236 files = _get_affected_files(commit)
1237 if not len(_filter_files(files, [r'chromeos/config'])) in [0, len(files)]:
1238 return HookFailure('Changes to chromeos/config/ and regular files must '
1239 'be in separate commits:\n%s' % '\n'.join(files))
Anton Staaf815d6852011-08-22 10:08:45 -07001240
Mike Frysingerae409522014-02-01 03:16:11 -05001241
1242def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -07001243 """Checks that all JSON files are syntactically valid."""
Dale Curtisa039cfd2011-05-04 12:01:05 -07001244 for f in _filter_files(_get_affected_files(commit), [r'.*\.json']):
Dale Curtis2975c432011-05-03 17:25:20 -07001245 try:
1246 json.load(open(f))
1247 except Exception, e:
Ryan Cui1562fb82011-05-09 11:01:31 -07001248 return HookFailure('Invalid JSON in %s: %s' % (f, e))
Dale Curtis2975c432011-05-03 17:25:20 -07001249
1250
Mike Frysingerae409522014-02-01 03:16:11 -05001251def _check_manifests(_project, commit):
Mike Frysinger52b537e2013-08-22 22:59:53 -04001252 """Make sure Manifest files only have DIST lines"""
1253 paths = []
1254
1255 for path in _get_affected_files(commit):
1256 if os.path.basename(path) != 'Manifest':
1257 continue
1258 if not os.path.exists(path):
1259 continue
1260
1261 with open(path, 'r') as f:
1262 for line in f.readlines():
1263 if not line.startswith('DIST '):
1264 paths.append(path)
1265 break
1266
1267 if paths:
1268 return HookFailure('Please remove lines that do not start with DIST:\n%s' %
1269 ('\n'.join(paths),))
1270
1271
Mike Frysingerae409522014-02-01 03:16:11 -05001272def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001273 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001274 if commit == PRE_SUBMIT:
1275 return
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001276 BRANCH_RE = r'\nBRANCH=\S+'
1277
1278 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
1279 msg = ('Changelist description needs BRANCH field (after first line)\n'
1280 'E.g. BRANCH=none or BRANCH=link,snow')
1281 return HookFailure(msg)
1282
1283
Mike Frysingerae409522014-02-01 03:16:11 -05001284def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001285 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001286 if commit == PRE_SUBMIT:
1287 return
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001288 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1289
1290 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1291 msg = ('Changelist description needs Signed-off-by: field\n'
1292 'E.g. Signed-off-by: My Name <me@chromium.org>')
1293 return HookFailure(msg)
1294
1295
Aviv Keshet5ac59522017-01-31 14:28:27 -08001296def _check_cq_ini_well_formed(_project, commit):
1297 """Check that any modified COMMIT-QUEUE.ini files are well formed."""
1298 pattern = '.*' + constants.CQ_CONFIG_FILENAME
Mike Frysingerd0523442018-01-03 17:05:29 -05001299 files = _filter_files(_get_affected_files(commit, relative=True), (pattern,))
Aviv Keshet5ac59522017-01-31 14:28:27 -08001300
1301 # TODO(akeshet): Check not only that the file is parseable, but that all the
1302 # pre-cq configs it requests are existing ones.
1303 for f in files:
1304 try:
1305 parser = ConfigParser.SafeConfigParser()
1306 # Prior to python3, ConfigParser has no read_string method, so we must
1307 # pass it either a file path or file like object. And we must use
1308 # _get_file_content to fetch file contents to ensure we are examining the
1309 # commit diff, rather than whatever's on disk.
1310 contents = _get_file_content(f, commit)
1311 parser.readfp(StringIO.StringIO(contents))
1312 except ConfigParser.Error as e:
1313 msg = ('Unable to parse COMMIT-QUEUE.ini file at %s due to %s.' %
1314 (f, e))
1315 return HookFailure(msg)
1316
1317
Jon Salz3ee59de2012-08-18 13:54:22 +08001318def _run_project_hook_script(script, project, commit):
1319 """Runs a project hook script.
1320
1321 The script is run with the following environment variables set:
1322 PRESUBMIT_PROJECT: The affected project
1323 PRESUBMIT_COMMIT: The affected commit
1324 PRESUBMIT_FILES: A newline-separated list of affected files
1325
1326 The script is considered to fail if the exit code is non-zero. It should
1327 write an error message to stdout.
1328 """
1329 env = dict(os.environ)
Alex Deymo643ac4c2015-09-03 10:40:50 -07001330 env['PRESUBMIT_PROJECT'] = project.name
Jon Salz3ee59de2012-08-18 13:54:22 +08001331 env['PRESUBMIT_COMMIT'] = commit
1332
1333 # Put affected files in an environment variable
1334 files = _get_affected_files(commit)
1335 env['PRESUBMIT_FILES'] = '\n'.join(files)
1336
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001337 cmd_result = cros_build_lib.RunCommand(cmd=script,
1338 env=env,
1339 shell=True,
1340 print_cmd=False,
1341 input=os.devnull,
1342 stdout_to_pipe=True,
1343 combine_stdout_stderr=True,
1344 error_code_ok=True)
1345 if cmd_result.returncode:
1346 stdout = cmd_result.output
Jon Salz7b618af2012-08-31 06:03:16 +08001347 if stdout:
1348 stdout = re.sub('(?m)^', ' ', stdout)
1349 return HookFailure('Hook script "%s" failed with code %d%s' %
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001350 (script, cmd_result.returncode,
Jon Salz3ee59de2012-08-18 13:54:22 +08001351 ':\n' + stdout if stdout else ''))
1352
1353
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001354def _check_project_prefix(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -05001355 """Require the commit message have a project specific prefix as needed."""
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001356
1357 files = _get_affected_files(commit, relative=True)
1358 prefix = os.path.commonprefix(files)
1359 prefix = os.path.dirname(prefix)
1360
1361 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07001362 if not prefix:
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001363 return
1364
1365 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07001366
1367 # The common files may all be within a subdirectory of the main project
1368 # directory, so walk up the tree until we find an alias file.
1369 # _get_affected_files() should return relative paths, but check against '/' to
1370 # ensure that this loop terminates even if it receives an absolute path.
1371 while prefix and prefix != '/':
1372 alias_file = os.path.join(prefix, '.project_alias')
1373
1374 # If an alias exists, use it.
1375 if os.path.isfile(alias_file):
1376 project_name = osutils.ReadFile(alias_file).strip()
1377
1378 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001379
1380 if not _get_commit_desc(commit).startswith(project_name + ': '):
1381 return HookFailure('The commit title for changes affecting only %s'
1382 ' should start with \"%s: \"'
1383 % (project_name, project_name))
1384
1385
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001386def _check_exec_files(_project, commit):
1387 """Make +x bits on files."""
1388 # List of files that should never be +x.
1389 NO_EXEC = (
1390 'ChangeLog*',
1391 'COPYING',
1392 'make.conf',
1393 'make.defaults',
1394 'Manifest',
1395 'OWNERS',
1396 'package.use',
1397 'package.keywords',
1398 'package.mask',
1399 'parent',
1400 'README',
1401 'TODO',
1402 '.gitignore',
1403 '*.[achly]',
1404 '*.[ch]xx',
1405 '*.boto',
1406 '*.cc',
1407 '*.cfg',
1408 '*.conf',
1409 '*.config',
1410 '*.cpp',
1411 '*.css',
1412 '*.ebuild',
1413 '*.eclass',
1414 '*.gyp',
1415 '*.gypi',
1416 '*.htm',
1417 '*.html',
1418 '*.ini',
1419 '*.js',
1420 '*.json',
1421 '*.md',
1422 '*.mk',
1423 '*.patch',
1424 '*.policy',
1425 '*.proto',
1426 '*.raw',
1427 '*.rules',
1428 '*.service',
1429 '*.target',
1430 '*.txt',
1431 '*.xml',
1432 '*.yaml',
1433 )
1434
1435 def FinalName(obj):
1436 # If the file is being deleted, then the dst_file is not set.
1437 if obj.dst_file is None:
1438 return obj.src_file
1439 else:
1440 return obj.dst_file
1441
1442 bad_files = []
1443 files = _get_affected_files(commit, relative=True, full_details=True)
1444 for f in files:
1445 mode = int(f.dst_mode, 8)
1446 if not mode & 0o111:
1447 continue
1448 name = FinalName(f)
1449 for no_exec in NO_EXEC:
1450 if fnmatch.fnmatch(name, no_exec):
1451 bad_files.append(name)
1452 break
1453
1454 if bad_files:
1455 return HookFailure('These files should not be executable. '
1456 'Please `chmod -x` them.', bad_files)
1457
1458
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001459# Base
1460
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001461# A list of hooks which are not project specific and check patch description
1462# (as opposed to patch body).
1463_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07001464 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07001465 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07001466 _check_change_has_test_field,
1467 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001468 _check_commit_message_style,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001469 _check_change_is_contribution,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001470]
1471
1472
1473# A list of hooks that are not project-specific
1474_COMMON_HOOKS = [
Aviv Keshet5ac59522017-01-31 14:28:27 -08001475 _check_cq_ini_well_formed,
1476 _check_cros_license,
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001477 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05001478 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001479 _check_ebuild_licenses,
Mike Frysingercd363c82014-02-01 05:20:18 -05001480 _check_ebuild_virtual_pv,
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001481 _check_exec_files,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001482 _check_for_uprev,
Rahul Chaudhry09f61372015-07-31 17:14:26 -07001483 _check_gofmt,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001484 _check_layout_conf,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001485 _check_no_long_lines,
1486 _check_no_stray_whitespace,
Ryan Cui9b651632011-05-11 11:38:58 -07001487 _check_no_tabs,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001488 _check_portage_make_use_var,
Aviv Keshet5ac59522017-01-31 14:28:27 -08001489 _check_tabbed_indents,
Ryan Cui9b651632011-05-11 11:38:58 -07001490]
Ryan Cuiec4d6332011-05-02 14:15:25 -07001491
Ryan Cui1562fb82011-05-09 11:01:31 -07001492
Ryan Cui9b651632011-05-11 11:38:58 -07001493# A dictionary of project-specific hooks(callbacks), indexed by project name.
1494# dict[project] = [callback1, callback2]
1495_PROJECT_SPECIFIC_HOOKS = {
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001496 "chromiumos/platform2": [_check_project_prefix],
Mike Frysingeraf891292015-03-25 19:46:53 -04001497 "chromiumos/third_party/kernel": [_kernel_configcheck],
1498 "chromiumos/third_party/kernel-next": [_kernel_configcheck],
Ryan Cui9b651632011-05-11 11:38:58 -07001499}
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001500
Ryan Cui1562fb82011-05-09 11:01:31 -07001501
Ryan Cui9b651632011-05-11 11:38:58 -07001502# A dictionary of flags (keys) that can appear in the config file, and the hook
Mike Frysinger3554bc92015-03-11 04:59:21 -04001503# that the flag controls (value).
1504_HOOK_FLAGS = {
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001505 'clang_format_check': _check_clang_format,
Mike Frysingera7642f52015-03-25 18:31:42 -04001506 'checkpatch_check': _run_checkpatch,
Ryan Cui9b651632011-05-11 11:38:58 -07001507 'stray_whitespace_check': _check_no_stray_whitespace,
Mike Frysingerff6c7d62015-03-24 13:49:46 -04001508 'json_check': _run_json_check,
Ryan Cui9b651632011-05-11 11:38:58 -07001509 'long_line_check': _check_no_long_lines,
Alex Deymof5792ce2015-08-24 22:50:08 -07001510 'cros_license_check': _check_cros_license,
1511 'aosp_license_check': _check_aosp_license,
Ryan Cui9b651632011-05-11 11:38:58 -07001512 'tab_check': _check_no_tabs,
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08001513 'tabbed_indent_required_check': _check_tabbed_indents,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001514 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001515 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07001516 'bug_field_check': _check_change_has_bug_field,
1517 'test_field_check': _check_change_has_test_field,
Steve Fung49ec7e92015-03-23 16:07:12 -07001518 'manifest_check': _check_manifests,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001519 'contribution_check': _check_change_is_contribution,
Ryan Cui9b651632011-05-11 11:38:58 -07001520}
1521
1522
Mike Frysinger3554bc92015-03-11 04:59:21 -04001523def _get_override_hooks(config):
1524 """Returns a set of hooks controlled by the current project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001525
1526 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08001527
1528 Args:
1529 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001530 """
1531 SECTION = 'Hook Overrides'
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001532 SECTION_OPTIONS = 'Hook Overrides Options'
Jon Salz3ee59de2012-08-18 13:54:22 +08001533 if not config.has_section(SECTION):
Mike Frysinger3554bc92015-03-11 04:59:21 -04001534 return set(), set()
Ryan Cui9b651632011-05-11 11:38:58 -07001535
Mike Frysinger3554bc92015-03-11 04:59:21 -04001536 valid_keys = set(_HOOK_FLAGS.iterkeys())
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001537 hooks = _HOOK_FLAGS.copy()
Mike Frysinger3554bc92015-03-11 04:59:21 -04001538
1539 enable_flags = []
Ryan Cui9b651632011-05-11 11:38:58 -07001540 disable_flags = []
Jon Salz3ee59de2012-08-18 13:54:22 +08001541 for flag in config.options(SECTION):
Mike Frysinger3554bc92015-03-11 04:59:21 -04001542 if flag not in valid_keys:
1543 raise ValueError('Error: unknown key "%s" in hook section of "%s"' %
1544 (flag, _CONFIG_FILE))
1545
Ryan Cui9b651632011-05-11 11:38:58 -07001546 try:
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001547 enabled = config.getboolean(SECTION, flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001548 except ValueError as e:
Mike Frysinger3554bc92015-03-11 04:59:21 -04001549 raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' %
1550 (flag, _CONFIG_FILE, e))
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001551 if enabled:
1552 enable_flags.append(flag)
1553 else:
1554 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001555
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001556 # See if this hook has custom options.
1557 if enabled:
1558 try:
1559 options = config.get(SECTION_OPTIONS, flag)
1560 hooks[flag] = functools.partial(hooks[flag], options=options.split())
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001561 hooks[flag].__name__ = flag
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001562 except (ConfigParser.NoOptionError, ConfigParser.NoSectionError):
1563 pass
1564
1565 enabled_hooks = set(hooks[x] for x in enable_flags)
1566 disabled_hooks = set(hooks[x] for x in disable_flags)
Mike Frysinger3554bc92015-03-11 04:59:21 -04001567 return enabled_hooks, disabled_hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001568
1569
Jon Salz3ee59de2012-08-18 13:54:22 +08001570def _get_project_hook_scripts(config):
1571 """Returns a list of project-specific hook scripts.
1572
1573 Args:
1574 config: A ConfigParser for the project's config file.
1575 """
1576 SECTION = 'Hook Scripts'
1577 if not config.has_section(SECTION):
1578 return []
1579
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001580 return config.items(SECTION)
Jon Salz3ee59de2012-08-18 13:54:22 +08001581
1582
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001583def _get_project_hooks(project, presubmit):
Ryan Cui9b651632011-05-11 11:38:58 -07001584 """Returns a list of hooks that need to be run for a project.
1585
1586 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001587
1588 Args:
1589 project: A string, name of the project.
1590 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui9b651632011-05-11 11:38:58 -07001591 """
Jon Salz3ee59de2012-08-18 13:54:22 +08001592 config = ConfigParser.RawConfigParser()
1593 try:
1594 config.read(_CONFIG_FILE)
1595 except ConfigParser.Error:
1596 # Just use an empty config file
1597 config = ConfigParser.RawConfigParser()
1598
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001599 if presubmit:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001600 hooks = _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001601 else:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001602 hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001603
Mike Frysinger3554bc92015-03-11 04:59:21 -04001604 enabled_hooks, disabled_hooks = _get_override_hooks(config)
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001605 hooks = [hook for hook in hooks if hook not in disabled_hooks]
1606
1607 # If a list is both in _COMMON_HOOKS and also enabled explicitly through an
1608 # override, keep the override only. Note that the override may end up being
1609 # a functools.partial, in which case we need to extract the .func to compare
1610 # it to the common hooks.
1611 unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks]
1612 hooks = [hook for hook in hooks if hook not in unwrapped_hooks]
1613
1614 hooks = list(enabled_hooks) + hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001615
1616 if project in _PROJECT_SPECIFIC_HOOKS:
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001617 hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project]
1618 if hook not in disabled_hooks)
Ryan Cui9b651632011-05-11 11:38:58 -07001619
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001620 for name, script in _get_project_hook_scripts(config):
1621 func = functools.partial(_run_project_hook_script, script)
1622 func.__name__ = name
1623 hooks.append(func)
Jon Salz3ee59de2012-08-18 13:54:22 +08001624
Ryan Cui9b651632011-05-11 11:38:58 -07001625 return hooks
1626
1627
Alex Deymo643ac4c2015-09-03 10:40:50 -07001628def _run_project_hooks(project_name, proj_dir=None,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001629 commit_list=None, presubmit=False):
Ryan Cui1562fb82011-05-09 11:01:31 -07001630 """For each project run its project specific hook from the hooks dictionary.
1631
1632 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001633 project_name: The name of project to run hooks for.
Doug Anderson44a644f2011-11-02 10:37:37 -07001634 proj_dir: If non-None, this is the directory the project is in. If None,
1635 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07001636 commit_list: A list of commits to run hooks against. If None or empty list
1637 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001638 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui1562fb82011-05-09 11:01:31 -07001639
1640 Returns:
1641 Boolean value of whether any errors were ecountered while running the hooks.
1642 """
Doug Anderson44a644f2011-11-02 10:37:37 -07001643 if proj_dir is None:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001644 proj_dirs = _run_command(
1645 ['repo', 'forall', project_name, '-c', 'pwd']).split()
David James2edd9002013-10-11 14:09:19 -07001646 if len(proj_dirs) == 0:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001647 print('%s cannot be found.' % project_name, file=sys.stderr)
David James2edd9002013-10-11 14:09:19 -07001648 print('Please specify a valid project.', file=sys.stderr)
1649 return True
1650 if len(proj_dirs) > 1:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001651 print('%s is associated with multiple directories.' % project_name,
David James2edd9002013-10-11 14:09:19 -07001652 file=sys.stderr)
1653 print('Please specify a directory to help disambiguate.', file=sys.stderr)
1654 return True
1655 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07001656
Ryan Cuiec4d6332011-05-02 14:15:25 -07001657 pwd = os.getcwd()
1658 # hooks assume they are run from the root of the project
1659 os.chdir(proj_dir)
1660
Alex Deymo643ac4c2015-09-03 10:40:50 -07001661 remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref',
1662 '--symbolic-full-name', '@{u}']).strip()
1663 if not remote_branch:
1664 print('Your project %s doesn\'t track any remote repo.' % project_name,
1665 file=sys.stderr)
1666 remote = None
1667 else:
1668 remote, _branch = remote_branch.split('/', 1)
1669
1670 project = Project(name=project_name, dir=proj_dir, remote=remote)
1671
Doug Anderson14749562013-06-26 13:38:29 -07001672 if not commit_list:
1673 try:
1674 commit_list = _get_commits()
1675 except VerifyException as e:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001676 PrintErrorForProject(project.name, HookFailure(str(e)))
Doug Anderson14749562013-06-26 13:38:29 -07001677 os.chdir(pwd)
1678 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07001679
Alex Deymo643ac4c2015-09-03 10:40:50 -07001680 hooks = _get_project_hooks(project.name, presubmit)
Ryan Cui1562fb82011-05-09 11:01:31 -07001681 error_found = False
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001682 commit_count = len(commit_list)
1683 for i, commit in enumerate(commit_list):
Ryan Cui1562fb82011-05-09 11:01:31 -07001684 error_list = []
Ryan Cui9b651632011-05-11 11:38:58 -07001685 for hook in hooks:
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001686 output = ('PRESUBMIT.cfg: [%i/%i]: %s: Running %s' %
1687 (i + 1, commit_count, commit, hook.__name__))
1688 print(output, end='\r')
1689 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07001690 hook_error = hook(project, commit)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001691 print(' ' * len(output), end='\r')
1692 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07001693 if hook_error:
1694 error_list.append(hook_error)
1695 error_found = True
1696 if error_list:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001697 PrintErrorsForCommit(project.name, commit, _get_commit_desc(commit),
Ryan Cui1562fb82011-05-09 11:01:31 -07001698 error_list)
Don Garrettdba548a2011-05-05 15:17:14 -07001699
Ryan Cuiec4d6332011-05-02 14:15:25 -07001700 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07001701 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001702
Mike Frysingerae409522014-02-01 03:16:11 -05001703
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001704# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07001705
Ryan Cui1562fb82011-05-09 11:01:31 -07001706
Mike Frysingerae409522014-02-01 03:16:11 -05001707def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08001708 """Main function invoked directly by repo.
1709
1710 This function will exit directly upon error so that repo doesn't print some
1711 obscure error message.
1712
1713 Args:
1714 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07001715 worktree_list: A list of directories. It should be the same length as
1716 project_list, so that each entry in project_list matches with a directory
1717 in worktree_list. If None, we will attempt to calculate the directories
1718 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08001719 kwargs: Leave this here for forward-compatibility.
1720 """
Ryan Cui1562fb82011-05-09 11:01:31 -07001721 found_error = False
David James2edd9002013-10-11 14:09:19 -07001722 if not worktree_list:
1723 worktree_list = [None] * len(project_list)
1724 for project, worktree in zip(project_list, worktree_list):
1725 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07001726 found_error = True
1727
Mike Frysingerae409522014-02-01 03:16:11 -05001728 if found_error:
Ryan Cui1562fb82011-05-09 11:01:31 -07001729 msg = ('Preupload failed due to errors in project(s). HINTS:\n'
Ryan Cui9b651632011-05-11 11:38:58 -07001730 '- To disable some source style checks, and for other hints, see '
1731 '<checkout_dir>/src/repohooks/README\n'
1732 '- To upload only current project, run \'repo upload .\'')
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04001733 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07001734 sys.exit(1)
Anush Elangovan63afad72011-03-23 00:41:27 -07001735
Ryan Cui1562fb82011-05-09 11:01:31 -07001736
Doug Anderson44a644f2011-11-02 10:37:37 -07001737def _identify_project(path):
1738 """Identify the repo project associated with the given path.
1739
1740 Returns:
1741 A string indicating what project is associated with the path passed in or
1742 a blank string upon failure.
1743 """
1744 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001745 redirect_stderr=True, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07001746
1747
Mike Frysinger55f85b52014-12-18 14:45:21 -05001748def direct_main(argv):
Doug Anderson44a644f2011-11-02 10:37:37 -07001749 """Run hooks directly (outside of the context of repo).
1750
Doug Anderson44a644f2011-11-02 10:37:37 -07001751 Args:
Mike Frysinger55f85b52014-12-18 14:45:21 -05001752 argv: The command line args to process
Doug Anderson44a644f2011-11-02 10:37:37 -07001753
1754 Returns:
1755 0 if no pre-upload failures, 1 if failures.
1756
1757 Raises:
1758 BadInvocation: On some types of invocation errors.
1759 """
Mike Frysinger66142932014-12-18 14:55:57 -05001760 parser = commandline.ArgumentParser(description=__doc__)
1761 parser.add_argument('--dir', default=None,
1762 help='The directory that the project lives in. If not '
1763 'specified, use the git project root based on the cwd.')
1764 parser.add_argument('--project', default=None,
1765 help='The project repo path; this can affect how the '
1766 'hooks get run, since some hooks are project-specific. '
1767 'For chromite this is chromiumos/chromite. If not '
1768 'specified, the repo tool will be used to figure this '
1769 'out based on the dir.')
1770 parser.add_argument('--rerun-since', default=None,
1771 help='Rerun hooks on old commits since the given date. '
1772 'The date should match git log\'s concept of a date. '
1773 'e.g. 2012-06-20. This option is mutually exclusive '
1774 'with --pre-submit.')
1775 parser.add_argument('--pre-submit', action="store_true",
1776 help='Run the check against the pending commit. '
1777 'This option should be used at the \'git commit\' '
1778 'phase as opposed to \'repo upload\'. This option '
1779 'is mutually exclusive with --rerun-since.')
1780 parser.add_argument('commits', nargs='*',
1781 help='Check specific commits')
1782 opts = parser.parse_args(argv)
Doug Anderson44a644f2011-11-02 10:37:37 -07001783
Doug Anderson14749562013-06-26 13:38:29 -07001784 if opts.rerun_since:
Mike Frysinger66142932014-12-18 14:55:57 -05001785 if opts.commits:
Doug Anderson14749562013-06-26 13:38:29 -07001786 raise BadInvocation('Can\'t pass commits and use rerun-since: %s' %
Mike Frysinger66142932014-12-18 14:55:57 -05001787 ' '.join(opts.commits))
Doug Anderson14749562013-06-26 13:38:29 -07001788
1789 cmd = ['git', 'log', '--since="%s"' % opts.rerun_since, '--pretty=%H']
1790 all_commits = _run_command(cmd).splitlines()
1791 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
1792
1793 # Eliminate chrome-bot commits but keep ordering the same...
1794 bot_commits = set(bot_commits)
Mike Frysinger66142932014-12-18 14:55:57 -05001795 opts.commits = [c for c in all_commits if c not in bot_commits]
Doug Anderson14749562013-06-26 13:38:29 -07001796
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001797 if opts.pre_submit:
1798 raise BadInvocation('rerun-since and pre-submit can not be '
1799 'used together')
1800 if opts.pre_submit:
Mike Frysinger66142932014-12-18 14:55:57 -05001801 if opts.commits:
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001802 raise BadInvocation('Can\'t pass commits and use pre-submit: %s' %
Mike Frysinger66142932014-12-18 14:55:57 -05001803 ' '.join(opts.commits))
1804 opts.commits = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07001805
1806 # Check/normlaize git dir; if unspecified, we'll use the root of the git
1807 # project from CWD
1808 if opts.dir is None:
1809 git_dir = _run_command(['git', 'rev-parse', '--git-dir'],
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001810 redirect_stderr=True).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07001811 if not git_dir:
1812 raise BadInvocation('The current directory is not part of a git project.')
1813 opts.dir = os.path.dirname(os.path.abspath(git_dir))
1814 elif not os.path.isdir(opts.dir):
1815 raise BadInvocation('Invalid dir: %s' % opts.dir)
1816 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
1817 raise BadInvocation('Not a git directory: %s' % opts.dir)
1818
1819 # Identify the project if it wasn't specified; this _requires_ the repo
1820 # tool to be installed and for the project to be part of a repo checkout.
1821 if not opts.project:
1822 opts.project = _identify_project(opts.dir)
1823 if not opts.project:
1824 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
1825
Doug Anderson14749562013-06-26 13:38:29 -07001826 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Mike Frysinger66142932014-12-18 14:55:57 -05001827 commit_list=opts.commits,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001828 presubmit=opts.pre_submit)
Doug Anderson44a644f2011-11-02 10:37:37 -07001829 if found_error:
1830 return 1
1831 return 0
1832
1833
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07001834if __name__ == '__main__':
Mike Frysinger55f85b52014-12-18 14:45:21 -05001835 sys.exit(direct_main(sys.argv[1:]))