blob: e7339823fd7d21094e4503e16a76585c4f6f5cbf [file] [log] [blame]
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08001#!/usr/bin/env python2
Jon Salz98255932012-08-18 14:48:02 +08002# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
Mike Frysingerae409522014-02-01 03:16:11 -05006"""Presubmit checks to run when doing `repo upload`.
7
8You can add new checks by adding a functions to the HOOKS constants.
9"""
10
Mike Frysinger09d6a3d2013-10-08 22:21:03 -040011from __future__ import print_function
12
Filipe Brandenburger4b542b12015-10-09 12:46:31 -070013import argparse
Alex Deymo643ac4c2015-09-03 10:40:50 -070014import collections
Ryan Cui9b651632011-05-11 11:38:58 -070015import ConfigParser
Daniel Erate3ea3fc2015-02-13 15:27:52 -070016import fnmatch
Jon Salz3ee59de2012-08-18 13:54:22 +080017import functools
Dale Curtis2975c432011-05-03 17:25:20 -070018import json
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070019import os
Ryan Cuiec4d6332011-05-02 14:15:25 -070020import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070021import sys
Peter Ammon811f6702014-06-12 15:45:38 -070022import stat
Aviv Keshet5ac59522017-01-31 14:28:27 -080023import StringIO
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070024
Ryan Cui1562fb82011-05-09 11:01:31 -070025from errors import (VerifyException, HookFailure, PrintErrorForProject,
26 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070027
David Jamesc3b68b32013-04-03 09:17:03 -070028# If repo imports us, the __name__ will be __builtin__, and the wrapper will
29# be in $CHROMEOS_CHECKOUT/.repo/repo/main.py, so we need to go two directories
30# up. The same logic also happens to work if we're executed directly.
31if __name__ in ('__builtin__', '__main__'):
32 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
33
Mike Frysinger66142932014-12-18 14:55:57 -050034from chromite.lib import commandline
Aviv Keshet5ac59522017-01-31 14:28:27 -080035from chromite.lib import constants
Rahul Chaudhry0e515342015-08-07 12:00:43 -070036from chromite.lib import cros_build_lib
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050037from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070038from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070039from chromite.lib import patch
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040040from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070041
Vadim Bendebury2b62d742014-06-22 13:14:51 -070042PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070043
44COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050045 # C++ and friends
46 r".*\.c$", r".*\.cc$", r".*\.cpp$", r".*\.h$", r".*\.m$", r".*\.mm$",
47 r".*\.inl$", r".*\.asm$", r".*\.hxx$", r".*\.hpp$", r".*\.s$", r".*\.S$",
48 # Scripts
49 r".*\.js$", r".*\.py$", r".*\.sh$", r".*\.rb$", r".*\.pl$", r".*\.pm$",
50 # No extension at all, note that ALL CAPS files are black listed in
51 # COMMON_EXCLUDED_LIST below.
52 r"(^|.*[\\\/])[^.]+$",
53 # Other
54 r".*\.java$", r".*\.mk$", r".*\.am$",
Brian Norrisfdbac8e2016-06-16 11:09:05 -070055 r".*\.policy$", r".*\.conf$",
Ryan Cuiec4d6332011-05-02 14:15:25 -070056]
57
Ryan Cui1562fb82011-05-09 11:01:31 -070058
Ryan Cuiec4d6332011-05-02 14:15:25 -070059COMMON_EXCLUDED_PATHS = [
Daniel Erate3ea3fc2015-02-13 15:27:52 -070060 # Avoid doing source file checks for kernel.
Mike Frysingerae409522014-02-01 03:16:11 -050061 r"/src/third_party/kernel/",
62 r"/src/third_party/kernel-next/",
63 r"/src/third_party/ktop/",
64 r"/src/third_party/punybench/",
65 r".*\bexperimental[\\\/].*",
66 r".*\b[A-Z0-9_]{2,}$",
67 r".*[\\\/]debian[\\\/]rules$",
Daniel Erate3ea3fc2015-02-13 15:27:52 -070068
69 # For ebuild trees, ignore any caches and manifest data.
Mike Frysingerae409522014-02-01 03:16:11 -050070 r".*/Manifest$",
71 r".*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$",
Doug Anderson5bfb6792011-10-25 16:45:41 -070072
Daniel Erate3ea3fc2015-02-13 15:27:52 -070073 # Ignore profiles data (like overlay-tegra2/profiles).
Mike Frysinger94a670c2014-09-19 12:46:26 -040074 r"(^|.*/)overlay-.*/profiles/.*",
Mike Frysinger98638102014-08-28 00:15:08 -040075 r"^profiles/.*$",
76
C Shapiro8f90e9b2017-06-28 09:54:50 -060077 # Ignore config files in ebuild setup.
78 r"(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*",
79 r"^chromeos-base/chromeos-bsp.*/files/.*",
80
Daniel Erate3ea3fc2015-02-13 15:27:52 -070081 # Ignore minified js and jquery.
Mike Frysingerae409522014-02-01 03:16:11 -050082 r".*\.min\.js",
83 r".*jquery.*\.js",
Mike Frysinger33a458d2014-03-03 17:00:51 -050084
85 # Ignore license files as the content is often taken verbatim.
Daniel Erate3ea3fc2015-02-13 15:27:52 -070086 r".*/licenses/.*",
Ryan Cuiec4d6332011-05-02 14:15:25 -070087]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070088
Ryan Cui1562fb82011-05-09 11:01:31 -070089
Ryan Cui9b651632011-05-11 11:38:58 -070090_CONFIG_FILE = 'PRESUBMIT.cfg'
91
92
Daniel Erate3ea3fc2015-02-13 15:27:52 -070093# File containing wildcards, one per line, matching files that should be
94# excluded from presubmit checks. Lines beginning with '#' are ignored.
95_IGNORE_FILE = '.presubmitignore'
96
97
Doug Anderson44a644f2011-11-02 10:37:37 -070098# Exceptions
99
100
101class BadInvocation(Exception):
102 """An Exception indicating a bad invocation of the program."""
103 pass
104
105
Ryan Cui1562fb82011-05-09 11:01:31 -0700106# General Helpers
107
Sean Paulba01d402011-05-05 11:36:23 -0400108
Alex Deymo643ac4c2015-09-03 10:40:50 -0700109Project = collections.namedtuple('Project', ['name', 'dir', 'remote'])
110
111
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700112# pylint: disable=redefined-builtin
113def _run_command(cmd, cwd=None, input=None,
114 redirect_stderr=False, combine_stdout_stderr=False):
Doug Anderson44a644f2011-11-02 10:37:37 -0700115 """Executes the passed in command and returns raw stdout output.
116
117 Args:
118 cmd: The command to run; should be a list of strings.
119 cwd: The directory to switch to for running the command.
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700120 input: The data to pipe into this command through stdin. If a file object
121 or file descriptor, stdin will be connected directly to that.
122 redirect_stderr: Redirect stderr away from console.
123 combine_stdout_stderr: Combines stdout and stderr streams into stdout.
Doug Anderson44a644f2011-11-02 10:37:37 -0700124
125 Returns:
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700126 The stdout from the process (discards stderr and returncode).
Doug Anderson44a644f2011-11-02 10:37:37 -0700127 """
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700128 return cros_build_lib.RunCommand(cmd=cmd,
129 cwd=cwd,
130 print_cmd=False,
131 input=input,
132 stdout_to_pipe=True,
133 redirect_stderr=redirect_stderr,
134 combine_stdout_stderr=combine_stdout_stderr,
135 error_code_ok=True).output
136# pylint: enable=redefined-builtin
Ryan Cui72834d12011-05-05 14:51:33 -0700137
Ryan Cui1562fb82011-05-09 11:01:31 -0700138
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700139def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700140 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700141 if __name__ == '__main__':
142 # Works when file is run on its own (__file__ is defined)...
143 return os.path.abspath(os.path.dirname(__file__))
144 else:
145 # We need to do this when we're run through repo. Since repo executes
146 # us with execfile(), we don't get __file__ defined.
147 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
148 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700149
Ryan Cui1562fb82011-05-09 11:01:31 -0700150
Ryan Cuiec4d6332011-05-02 14:15:25 -0700151def _match_regex_list(subject, expressions):
152 """Try to match a list of regular expressions to a string.
153
154 Args:
155 subject: The string to match regexes on
156 expressions: A list of regular expressions to check for matches with.
157
158 Returns:
159 Whether the passed in subject matches any of the passed in regexes.
160 """
161 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500162 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700163 return True
164 return False
165
Ryan Cui1562fb82011-05-09 11:01:31 -0700166
Mike Frysingerae409522014-02-01 03:16:11 -0500167def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700168 """Filter out files based on the conditions passed in.
169
170 Args:
171 files: list of filepaths to filter
172 include_list: list of regex that when matched with a file path will cause it
173 to be added to the output list unless the file is also matched with a
174 regex in the exclude_list.
175 exclude_list: list of regex that when matched with a file will prevent it
176 from being added to the output list, even if it is also matched with a
177 regex in the include_list.
178
179 Returns:
180 A list of filepaths that contain files matched in the include_list and not
181 in the exclude_list.
182 """
183 filtered = []
184 for f in files:
185 if (_match_regex_list(f, include_list) and
186 not _match_regex_list(f, exclude_list)):
187 filtered.append(f)
188 return filtered
189
Ryan Cuiec4d6332011-05-02 14:15:25 -0700190
191# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700192
193
Ryan Cui4725d952011-05-05 15:41:19 -0700194def _get_upstream_branch():
195 """Returns the upstream tracking branch of the current branch.
196
197 Raises:
198 Error if there is no tracking branch
199 """
200 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
201 current_branch = current_branch.replace('refs/heads/', '')
202 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700203 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700204
205 cfg_option = 'branch.' + current_branch + '.%s'
206 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
207 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
208 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700209 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700210
211 return full_upstream.replace('heads', 'remotes/' + remote)
212
Ryan Cui1562fb82011-05-09 11:01:31 -0700213
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700214def _get_patch(commit):
215 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700216 if commit == PRE_SUBMIT:
217 return _run_command(['git', 'diff', '--cached', 'HEAD'])
218 else:
219 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700220
Ryan Cui1562fb82011-05-09 11:01:31 -0700221
Jon Salz98255932012-08-18 14:48:02 +0800222def _try_utf8_decode(data):
223 """Attempts to decode a string as UTF-8.
224
225 Returns:
226 The decoded Unicode object, or the original string if parsing fails.
227 """
228 try:
229 return unicode(data, 'utf-8', 'strict')
230 except UnicodeDecodeError:
231 return data
232
233
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500234def _get_file_content(path, commit):
235 """Returns the content of a file at a specific commit.
236
237 We can't rely on the file as it exists in the filesystem as people might be
238 uploading a series of changes which modifies the file multiple times.
239
240 Note: The "content" of a symlink is just the target. So if you're expecting
241 a full file, you should check that first. One way to detect is that the
242 content will not have any newlines.
243 """
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700244 if commit == PRE_SUBMIT:
245 return _run_command(['git', 'diff', 'HEAD', path])
246 else:
247 return _run_command(['git', 'show', '%s:%s' % (commit, path)])
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500248
249
Mike Frysingerae409522014-02-01 03:16:11 -0500250def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700251 """Returns a list of (linenum, lines) tuples that the commit touched."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700252 if commit == PRE_SUBMIT:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800253 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD',
254 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700255 else:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800256 command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit,
257 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700258 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700259
260 new_lines = []
261 line_num = 0
262 for line in output.splitlines():
263 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
264 if m:
265 line_num = int(m.groups(1)[0])
266 continue
267 if line.startswith('+') and not line.startswith('++'):
Jon Salz98255932012-08-18 14:48:02 +0800268 new_lines.append((line_num, _try_utf8_decode(line[1:])))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700269 if not line.startswith('-'):
270 line_num += 1
271 return new_lines
272
Ryan Cui1562fb82011-05-09 11:01:31 -0700273
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700274def _get_ignore_wildcards(directory, cache):
275 """Get wildcards listed in a directory's _IGNORE_FILE.
276
277 Args:
278 directory: A string containing a directory path.
279 cache: A dictionary (opaque to caller) caching previously-read wildcards.
280
281 Returns:
282 A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE
283 wasn't present.
284 """
285 # In the cache, keys are directories and values are lists of wildcards from
286 # _IGNORE_FILE within those directories (and empty if no file was present).
287 if directory not in cache:
288 wildcards = []
289 dotfile_path = os.path.join(directory, _IGNORE_FILE)
290 if os.path.exists(dotfile_path):
291 # TODO(derat): Consider using _get_file_content() to get the file as of
292 # this commit instead of the on-disk version. This may have a noticeable
293 # performance impact, as each call to _get_file_content() runs git.
294 with open(dotfile_path, 'r') as dotfile:
295 for line in dotfile.readlines():
296 line = line.strip()
297 if line.startswith('#'):
298 continue
299 if line.endswith('/'):
300 line += '*'
301 wildcards.append(line)
302 cache[directory] = wildcards
303
304 return cache[directory]
305
306
307def _path_is_ignored(path, cache):
308 """Check whether a path is ignored by _IGNORE_FILE.
309
310 Args:
311 path: A string containing a path.
312 cache: A dictionary (opaque to caller) caching previously-read wildcards.
313
314 Returns:
315 True if a file named _IGNORE_FILE in one of the passed-in path's parent
316 directories contains a wildcard matching the path.
317 """
318 # Skip ignore files.
319 if os.path.basename(path) == _IGNORE_FILE:
320 return True
321
322 path = os.path.abspath(path)
323 base = os.getcwd()
324
325 prefix = os.path.dirname(path)
326 while prefix.startswith(base):
327 rel_path = path[len(prefix) + 1:]
328 for wildcard in _get_ignore_wildcards(prefix, cache):
329 if fnmatch.fnmatch(rel_path, wildcard):
330 return True
331 prefix = os.path.dirname(prefix)
332
333 return False
334
335
Mike Frysinger292b45d2014-11-25 01:17:10 -0500336def _get_affected_files(commit, include_deletes=False, relative=False,
337 include_symlinks=False, include_adds=True,
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700338 full_details=False, use_ignore_files=True):
Peter Ammon811f6702014-06-12 15:45:38 -0700339 """Returns list of file paths that were modified/added, excluding symlinks.
340
341 Args:
342 commit: The commit
343 include_deletes: If true, we'll include deleted files in the result
344 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500345 include_symlinks: If true, we'll include symlinks in the result
346 include_adds: If true, we'll include new files in the result
347 full_details: If False, return filenames, else return structured results.
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700348 use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files.
Peter Ammon811f6702014-06-12 15:45:38 -0700349
350 Returns:
351 A list of modified/added (and perhaps deleted) files
352 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500353 if not relative and full_details:
354 raise ValueError('full_details only supports relative paths currently')
355
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700356 if commit == PRE_SUBMIT:
357 return _run_command(['git', 'diff-index', '--cached',
358 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500359
360 path = os.getcwd()
361 files = git.RawDiff(path, '%s^!' % commit)
362
363 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500364 if not include_symlinks:
365 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500366
367 if not include_deletes:
368 files = [x for x in files if x.status != 'D']
369
Mike Frysinger292b45d2014-11-25 01:17:10 -0500370 if not include_adds:
371 files = [x for x in files if x.status != 'A']
372
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700373 if use_ignore_files:
374 cache = {}
375 is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache)
376 files = [x for x in files if not is_ignored(x)]
377
Mike Frysinger292b45d2014-11-25 01:17:10 -0500378 if full_details:
379 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500380 return files
381 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500382 # Caller only cares about filenames.
383 files = [x.dst_file if x.dst_file else x.src_file for x in files]
384 if relative:
385 return files
386 else:
387 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700388
389
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700390def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700391 """Returns a list of commits for this review."""
Ryan Cui4725d952011-05-05 15:41:19 -0700392 cmd = ['git', 'log', '%s..' % _get_upstream_branch(), '--format=%H']
Ryan Cui72834d12011-05-05 14:51:33 -0700393 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700394
Ryan Cui1562fb82011-05-09 11:01:31 -0700395
Ryan Cuiec4d6332011-05-02 14:15:25 -0700396def _get_commit_desc(commit):
397 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700398 if commit == PRE_SUBMIT:
399 return ''
Sean Paul23a2c582011-05-06 13:10:44 -0400400 return _run_command(['git', 'log', '--format=%s%n%n%b', commit + '^!'])
Ryan Cuiec4d6332011-05-02 14:15:25 -0700401
402
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800403def _check_lines_in_diff(commit, files, check_callable, error_description):
404 """Checks given file for errors via the given check.
405
406 This is a convenience function for common per-line checks. It goes through all
407 files and returns a HookFailure with the error description listing all the
408 failures.
409
410 Args:
411 commit: The commit we're working on.
412 files: The files to check.
413 check_callable: A callable that takes a line and returns True if this line
414 _fails_ the check.
415 error_description: A string describing the error.
416 """
417 errors = []
418 for afile in files:
419 for line_num, line in _get_file_diff(afile, commit):
420 if check_callable(line):
421 errors.append('%s, line %s' % (afile, line_num))
422 if errors:
423 return HookFailure(error_description, errors)
424
425
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900426def _parse_common_inclusion_options(options):
427 """Parses common hook options for including/excluding files.
428
429 Args:
430 options: Option string list.
431
432 Returns:
433 (included, excluded) where each one is a list of regex strings.
434 """
435 parser = argparse.ArgumentParser()
436 parser.add_argument('--exclude_regex', action='append')
437 parser.add_argument('--include_regex', action='append')
438 opts = parser.parse_args(options)
439 included = opts.include_regex or []
440 excluded = opts.exclude_regex or []
441 return included, excluded
442
443
Ryan Cuiec4d6332011-05-02 14:15:25 -0700444# Common Hooks
445
Ryan Cui1562fb82011-05-09 11:01:31 -0700446
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900447def _check_no_long_lines(_project, commit, options=()):
Mike Frysinger55f85b52014-12-18 14:45:21 -0500448 """Checks there are no lines longer than MAX_LEN in any of the text files."""
449
Ryan Cuiec4d6332011-05-02 14:15:25 -0700450 MAX_LEN = 80
Jon Salz98255932012-08-18 14:48:02 +0800451 SKIP_REGEXP = re.compile('|'.join([
452 r'https?://',
453 r'^#\s*(define|include|import|pragma|if|endif)\b']))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700454
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900455 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700456 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900457 included + COMMON_INCLUDED_PATHS,
458 excluded + COMMON_EXCLUDED_PATHS)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700459
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900460 errors = []
Ryan Cuiec4d6332011-05-02 14:15:25 -0700461 for afile in files:
462 for line_num, line in _get_file_diff(afile, commit):
463 # Allow certain lines to exceed the maxlen rule.
Mike Frysingerae409522014-02-01 03:16:11 -0500464 if len(line) <= MAX_LEN or SKIP_REGEXP.search(line):
Jon Salz98255932012-08-18 14:48:02 +0800465 continue
466
467 errors.append('%s, line %s, %s chars' % (afile, line_num, len(line)))
468 if len(errors) == 5: # Just show the first 5 errors.
469 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700470
471 if errors:
472 msg = 'Found lines longer than %s characters (first 5 shown):' % MAX_LEN
Ryan Cui1562fb82011-05-09 11:01:31 -0700473 return HookFailure(msg, errors)
474
Ryan Cuiec4d6332011-05-02 14:15:25 -0700475
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900476def _check_no_stray_whitespace(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700477 """Checks that there is no stray whitespace at source lines end."""
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900478 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700479 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900480 included + COMMON_INCLUDED_PATHS,
481 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800482 return _check_lines_in_diff(commit, files,
483 lambda line: line.rstrip() != line,
484 'Found line ending with white space in:')
Ryan Cui1562fb82011-05-09 11:01:31 -0700485
Ryan Cuiec4d6332011-05-02 14:15:25 -0700486
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900487def _check_no_tabs(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700488 """Checks there are no unexpanded tabs."""
Mike Frysingercd134512017-10-26 04:36:33 -0400489 # Don't add entire repos here. Update the PRESUBMIT.cfg in each repo instead.
490 # We only whitelist known specific filetypes here that show up in all repos.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700491 TAB_OK_PATHS = [
Ryan Cuiec4d6332011-05-02 14:15:25 -0700492 r".*\.ebuild$",
493 r".*\.eclass$",
Elly Jones5ab34192011-11-15 14:57:06 -0500494 r".*/[M|m]akefile$",
495 r".*\.mk$"
Ryan Cuiec4d6332011-05-02 14:15:25 -0700496 ]
497
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900498 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700499 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900500 included + COMMON_INCLUDED_PATHS,
501 excluded + COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800502 return _check_lines_in_diff(commit, files,
503 lambda line: '\t' in line,
504 'Found a tab character in:')
Ryan Cuiec4d6332011-05-02 14:15:25 -0700505
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800506
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900507def _check_tabbed_indents(_project, commit, options=()):
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800508 """Checks that indents use tabs only."""
509 TABS_REQUIRED_PATHS = [
510 r".*\.ebuild$",
511 r".*\.eclass$",
512 ]
513 LEADING_SPACE_RE = re.compile('[\t]* ')
514
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900515 included, excluded = _parse_common_inclusion_options(options)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800516 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900517 included + TABS_REQUIRED_PATHS,
518 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800519 return _check_lines_in_diff(
520 commit, files,
521 lambda line: LEADING_SPACE_RE.match(line) is not None,
522 'Found a space in indentation (must be all tabs):')
Ryan Cui1562fb82011-05-09 11:01:31 -0700523
Ryan Cuiec4d6332011-05-02 14:15:25 -0700524
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700525def _check_gofmt(_project, commit):
526 """Checks that Go files are formatted with gofmt."""
527 errors = []
528 files = _filter_files(_get_affected_files(commit, relative=True),
529 [r'\.go$'])
530
531 for gofile in files:
532 contents = _get_file_content(gofile, commit)
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700533 output = _run_command(cmd=['gofmt', '-l'], input=contents,
534 combine_stdout_stderr=True)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700535 if output:
536 errors.append(gofile)
537 if errors:
538 return HookFailure('Files not formatted with gofmt:', errors)
539
540
Mike Frysingerae409522014-02-01 03:16:11 -0500541def _check_change_has_test_field(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700542 """Check for a non-empty 'TEST=' field in the commit message."""
David McMahon8f6553e2011-06-10 15:46:36 -0700543 TEST_RE = r'\nTEST=\S+'
Ryan Cuiec4d6332011-05-02 14:15:25 -0700544
Mandeep Singh Baines96a53be2011-05-03 11:10:25 -0700545 if not re.search(TEST_RE, _get_commit_desc(commit)):
Ryan Cui1562fb82011-05-09 11:01:31 -0700546 msg = 'Changelist description needs TEST field (after first line)'
547 return HookFailure(msg)
548
Ryan Cuiec4d6332011-05-02 14:15:25 -0700549
Mike Frysingerae409522014-02-01 03:16:11 -0500550def _check_change_has_valid_cq_depend(_project, commit):
David Jamesc3b68b32013-04-03 09:17:03 -0700551 """Check for a correctly formatted CQ-DEPEND field in the commit message."""
552 msg = 'Changelist has invalid CQ-DEPEND target.'
553 example = 'Example: CQ-DEPEND=CL:1234, CL:2345'
554 try:
555 patch.GetPaladinDeps(_get_commit_desc(commit))
556 except ValueError as ex:
557 return HookFailure(msg, [example, str(ex)])
558
559
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800560def _check_change_is_contribution(_project, commit):
561 """Check that the change is a contribution."""
562 NO_CONTRIB = 'not a contribution'
563 if NO_CONTRIB in _get_commit_desc(commit).lower():
564 msg = ('Changelist is not a contribution, this cannot be accepted.\n'
565 'Please remove the "%s" text from the commit message.') % NO_CONTRIB
566 return HookFailure(msg)
567
568
Alex Deymo643ac4c2015-09-03 10:40:50 -0700569def _check_change_has_bug_field(project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700570 """Check for a correctly formatted 'BUG=' field in the commit message."""
David James5c0073d2013-04-03 08:48:52 -0700571 OLD_BUG_RE = r'\nBUG=.*chromium-os'
572 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
573 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
574 'the chromium tracker in your BUG= line now.')
575 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700576
Alex Deymo643ac4c2015-09-03 10:40:50 -0700577 # Android internal and external projects use "Bug: " to track bugs in
578 # buganizer.
579 BUG_COLON_REMOTES = (
580 'aosp',
581 'goog',
582 )
583 if project.remote in BUG_COLON_REMOTES:
584 BUG_RE = r'\nBug: ?([Nn]one|\d+)'
585 if not re.search(BUG_RE, _get_commit_desc(commit)):
586 msg = ('Changelist description needs BUG field (after first line):\n'
587 'Bug: 9999 (for buganizer)\n'
588 'BUG=None')
589 return HookFailure(msg)
590 else:
Jorge Lucangeli Obesdce214e2017-10-25 15:04:39 -0400591 BUG_RE = r'\nBUG=([Nn]one|(chromium|b):\d+)'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700592 if not re.search(BUG_RE, _get_commit_desc(commit)):
593 msg = ('Changelist description needs BUG field (after first line):\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700594 'BUG=chromium:9999 (for public tracker)\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700595 'BUG=b:9999 (for buganizer)\n'
596 'BUG=None')
597 return HookFailure(msg)
Ryan Cui1562fb82011-05-09 11:01:31 -0700598
Ryan Cuiec4d6332011-05-02 14:15:25 -0700599
Mike Frysinger292b45d2014-11-25 01:17:10 -0500600def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -0700601 """Check that we're not missing a revbump of an ebuild in the given commit.
602
603 If the given commit touches files in a directory that has ebuilds somewhere
604 up the directory hierarchy, it's very likely that we need an ebuild revbump
605 in order for those changes to take effect.
606
607 It's not totally trivial to detect a revbump, so at least detect that an
608 ebuild with a revision number in it was touched. This should handle the
609 common case where we use a symlink to do the revbump.
610
611 TODO: it would be nice to enhance this hook to:
612 * Handle cases where people revbump with a slightly different syntax. I see
613 one ebuild (puppy) that revbumps with _pN. This is a false positive.
614 * Catches cases where people aren't using symlinks for revbumps. If they
615 edit a revisioned file directly (and are expected to rename it for revbump)
616 we'll miss that. Perhaps we could detect that the file touched is a
617 symlink?
618
619 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
620 still better off than without this check.
621
622 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700623 project: The Project to look at
Doug Anderson42b8a052013-06-26 10:45:36 -0700624 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -0500625 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -0700626
627 Returns:
628 A HookFailure or None.
629 """
Mike Frysinger011af942014-01-17 16:12:22 -0500630 # If this is the portage-stable overlay, then ignore the check. It's rare
631 # that we're doing anything other than importing files from upstream, so
632 # forcing a rev bump makes no sense.
633 whitelist = (
634 'chromiumos/overlays/portage-stable',
635 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700636 if project.name in whitelist:
Mike Frysinger011af942014-01-17 16:12:22 -0500637 return None
638
Mike Frysinger292b45d2014-11-25 01:17:10 -0500639 def FinalName(obj):
640 # If the file is being deleted, then the dst_file is not set.
641 if obj.dst_file is None:
642 return obj.src_file
643 else:
644 return obj.dst_file
645
646 affected_path_objs = _get_affected_files(
647 commit, include_deletes=True, include_symlinks=True, relative=True,
648 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -0700649
650 # Don't yell about changes to whitelisted files...
Aviv Keshet272f2e52016-04-25 14:49:44 -0700651 whitelist = ('ChangeLog', 'Manifest', 'metadata.xml', 'COMMIT-QUEUE.ini')
Mike Frysinger292b45d2014-11-25 01:17:10 -0500652 affected_path_objs = [x for x in affected_path_objs
653 if os.path.basename(FinalName(x)) not in whitelist]
654 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -0700655 return None
656
657 # If we've touched any file named with a -rN.ebuild then we'll say we're
658 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500659 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
660 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700661 if touched_revved_ebuild:
662 return None
663
Mike Frysinger292b45d2014-11-25 01:17:10 -0500664 # If we're creating new ebuilds from scratch, then we don't need an uprev.
665 # Find all the dirs that new ebuilds and ignore their files/.
666 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
667 if FinalName(x).endswith('.ebuild') and x.status == 'A']
668 affected_path_objs = [obj for obj in affected_path_objs
669 if not any(FinalName(obj).startswith(x)
670 for x in ebuild_dirs)]
671 if not affected_path_objs:
672 return
673
Doug Anderson42b8a052013-06-26 10:45:36 -0700674 # We want to examine the current contents of all directories that are parents
675 # of files that were touched (up to the top of the project).
676 #
677 # ...note: we use the current directory contents even though it may have
678 # changed since the commit we're looking at. This is just a heuristic after
679 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500680 if project_top is None:
681 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -0700682 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -0500683 for obj in affected_path_objs:
684 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -0700685 while os.path.exists(path) and not os.path.samefile(path, project_top):
686 dirs_to_check.add(path)
687 path = os.path.dirname(path)
688
689 # Look through each directory. If it's got an ebuild in it then we'll
690 # consider this as a case when we need a revbump.
Gwendal Grignoua3086c32014-12-09 11:17:22 -0800691 affected_paths = set(os.path.join(project_top, FinalName(x))
692 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700693 for dir_path in dirs_to_check:
694 contents = os.listdir(dir_path)
695 ebuilds = [os.path.join(dir_path, path)
696 for path in contents if path.endswith('.ebuild')]
697 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
698
C Shapiroae157ae2017-09-18 16:24:03 -0600699 affected_paths_under_9999_ebuilds = set()
700 for affected_path in affected_paths:
701 for ebuild_9999 in ebuilds_9999:
702 ebuild_dir = os.path.dirname(ebuild_9999)
703 if affected_path.startswith(ebuild_dir):
704 affected_paths_under_9999_ebuilds.add(affected_path)
705
706 # If every file changed exists under a 9999 ebuild, then skip
707 if len(affected_paths_under_9999_ebuilds) == len(affected_paths):
708 continue
709
Doug Anderson42b8a052013-06-26 10:45:36 -0700710 # If the -9999.ebuild file was touched the bot will uprev for us.
711 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -0500712 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -0700713 continue
714
715 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500716 return HookFailure('Changelist probably needs a revbump of an ebuild, '
717 'or a -r1.ebuild symlink if this is a new ebuild:\n'
718 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -0700719
720 return None
721
722
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500723def _check_ebuild_eapi(project, commit):
724 """Make sure we have people use EAPI=4 or newer with custom ebuilds.
725
726 We want to get away from older EAPI's as it makes life confusing and they
727 have less builtin error checking.
728
729 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700730 project: The Project to look at
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500731 commit: The commit to look at
732
733 Returns:
734 A HookFailure or None.
735 """
736 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500737 # that we're doing anything other than importing files from upstream, and
738 # we shouldn't be rewriting things fundamentally anyways.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500739 whitelist = (
740 'chromiumos/overlays/portage-stable',
741 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700742 if project.name in whitelist:
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500743 return None
744
745 BAD_EAPIS = ('0', '1', '2', '3')
746
747 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
748
749 ebuilds_re = [r'\.ebuild$']
750 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
751 ebuilds_re)
752 bad_ebuilds = []
753
754 for ebuild in ebuilds:
755 # If the ebuild does not specify an EAPI, it defaults to 0.
756 eapi = '0'
757
758 lines = _get_file_content(ebuild, commit).splitlines()
759 if len(lines) == 1:
760 # This is most likely a symlink, so skip it entirely.
761 continue
762
763 for line in lines:
764 m = get_eapi.match(line)
765 if m:
766 # Once we hit the first EAPI line in this ebuild, stop processing.
767 # The spec requires that there only be one and it be first, so
768 # checking all possible values is pointless. We also assume that
769 # it's "the" EAPI line and not something in the middle of a heredoc.
770 eapi = m.group(1)
771 break
772
773 if eapi in BAD_EAPIS:
774 bad_ebuilds.append((ebuild, eapi))
775
776 if bad_ebuilds:
777 # pylint: disable=C0301
778 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
779 # pylint: enable=C0301
780 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500781 'These ebuilds are using old EAPIs. If these are imported from\n'
782 'Gentoo, then you may ignore and upload once with the --no-verify\n'
783 'flag. Otherwise, please update to 4 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500784 '\t%s\n'
785 'See this guide for more details:\n%s\n' %
786 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
787
788
Mike Frysinger89bdb852014-02-01 05:26:26 -0500789def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -0500790 """Make sure we use the new style KEYWORDS when possible in ebuilds.
791
792 If an ebuild generally does not care about the arch it is running on, then
793 ebuilds should flag it with one of:
794 KEYWORDS="*" # A stable ebuild.
795 KEYWORDS="~*" # An unstable ebuild.
796 KEYWORDS="-* ..." # Is known to only work on specific arches.
797
798 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700799 project: The Project to look at
Mike Frysingerc51ece72014-01-17 16:23:40 -0500800 commit: The commit to look at
801
802 Returns:
803 A HookFailure or None.
804 """
805 WHITELIST = set(('*', '-*', '~*'))
806
807 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
808
Mike Frysinger89bdb852014-02-01 05:26:26 -0500809 ebuilds_re = [r'\.ebuild$']
810 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
811 ebuilds_re)
812
Mike Frysinger8d42d742014-09-22 15:50:21 -0400813 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -0500814 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -0400815 # We get the full content rather than a diff as the latter does not work
816 # on new files (like when adding new ebuilds).
817 lines = _get_file_content(ebuild, commit).splitlines()
818 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -0500819 m = get_keywords.match(line)
820 if m:
821 keywords = set(m.group(1).split())
822 if not keywords or WHITELIST - keywords != WHITELIST:
823 continue
824
Mike Frysinger8d42d742014-09-22 15:50:21 -0400825 bad_ebuilds.append(ebuild)
826
827 if bad_ebuilds:
828 return HookFailure(
829 '%s\n'
830 'Please update KEYWORDS to use a glob:\n'
831 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
832 ' KEYWORDS="*"\n'
833 'If the ebuild should be marked unstable (normal for '
834 'cros-workon / 9999 ebuilds):\n'
835 ' KEYWORDS="~*"\n'
Mike Frysingerde8efea2015-05-17 03:42:26 -0400836 'If the ebuild needs to be marked for only specific arches, '
Mike Frysinger8d42d742014-09-22 15:50:21 -0400837 'then use -* like so:\n'
838 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -0500839
840
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800841def _check_ebuild_licenses(_project, commit):
842 """Check if the LICENSE field in the ebuild is correct."""
Brian Norris7a610e82016-02-17 12:24:54 -0800843 affected_paths = _get_affected_files(commit, relative=True)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800844 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
845
846 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -0800847 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800848
849 for ebuild in touched_ebuilds:
850 # Skip virutal packages.
851 if ebuild.split('/')[-3] == 'virtual':
852 continue
853
854 try:
Brian Norris7a610e82016-02-17 12:24:54 -0800855 ebuild_content = _get_file_content(ebuild, commit)
856 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800857 except ValueError as e:
858 return HookFailure(e.message, [ebuild])
859
860 # Also ignore licenses ending with '?'
861 for license_type in [x for x in license_types
862 if x not in LICENSES_IGNORE and not x.endswith('?')]:
863 try:
Mike Frysinger2ec70ed2014-08-17 19:28:34 -0400864 licenses_lib.Licensing.FindLicenseType(license_type)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -0800865 except AssertionError as e:
866 return HookFailure(e.message, [ebuild])
867
868
Mike Frysingercd363c82014-02-01 05:20:18 -0500869def _check_ebuild_virtual_pv(project, commit):
870 """Enforce the virtual PV policies."""
871 # If this is the portage-stable overlay, then ignore the check.
872 # We want to import virtuals as-is from upstream Gentoo.
873 whitelist = (
874 'chromiumos/overlays/portage-stable',
875 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700876 if project.name in whitelist:
Mike Frysingercd363c82014-02-01 05:20:18 -0500877 return None
878
879 # We assume the repo name is the same as the dir name on disk.
880 # It would be dumb to not have them match though.
Alex Deymo643ac4c2015-09-03 10:40:50 -0700881 project_base = os.path.basename(project.name)
Mike Frysingercd363c82014-02-01 05:20:18 -0500882
883 is_variant = lambda x: x.startswith('overlay-variant-')
884 is_board = lambda x: x.startswith('overlay-')
885 is_private = lambda x: x.endswith('-private')
886
887 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
888
889 ebuilds_re = [r'\.ebuild$']
890 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
891 ebuilds_re)
892 bad_ebuilds = []
893
894 for ebuild in ebuilds:
895 m = get_pv.match(ebuild)
896 if m:
897 overlay = m.group(1)
898 if not overlay or not is_board(overlay):
Alex Deymo643ac4c2015-09-03 10:40:50 -0700899 overlay = project_base
Mike Frysingercd363c82014-02-01 05:20:18 -0500900
901 pv = m.group(3).split('-', 1)[0]
902
Bernie Thompsone5ee1822016-01-12 14:22:23 -0800903 # Virtual versions >= 4 are special cases used above the standard
904 # versioning structure, e.g. if one has a board inheriting a board.
905 if float(pv) >= 4:
906 want_pv = pv
907 elif is_private(overlay):
Mike Frysingercd363c82014-02-01 05:20:18 -0500908 want_pv = '3.5' if is_variant(overlay) else '3'
909 elif is_board(overlay):
910 want_pv = '2.5' if is_variant(overlay) else '2'
911 else:
912 want_pv = '1'
913
914 if pv != want_pv:
915 bad_ebuilds.append((ebuild, pv, want_pv))
916
917 if bad_ebuilds:
918 # pylint: disable=C0301
919 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
920 # pylint: enable=C0301
921 return HookFailure(
922 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
923 '\t%s\n'
924 'If this is an upstream Gentoo virtual, then you may ignore this\n'
925 'check (and re-run w/--no-verify). Otherwise, please see this\n'
926 'page for more details:\n%s\n' %
927 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
928 for x in bad_ebuilds]), url))
929
930
Daniel Erat9d203ff2015-02-17 10:12:21 -0700931def _check_portage_make_use_var(_project, commit):
932 """Verify that $USE is set correctly in make.conf and make.defaults."""
933 files = _filter_files(_get_affected_files(commit, relative=True),
934 [r'(^|/)make.(conf|defaults)$'])
935
936 errors = []
937 for path in files:
938 basename = os.path.basename(path)
939
940 # Has a USE= line already been encountered in this file?
941 saw_use = False
942
943 for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1):
944 if not line.startswith('USE='):
945 continue
946
947 preserves_use = '${USE}' in line or '$USE' in line
948
949 if (basename == 'make.conf' or
950 (basename == 'make.defaults' and saw_use)) and not preserves_use:
951 errors.append('%s:%d: missing ${USE}' % (path, i))
952 elif basename == 'make.defaults' and not saw_use and preserves_use:
953 errors.append('%s:%d: ${USE} referenced in initial declaration' %
954 (path, i))
955
956 saw_use = True
957
958 if errors:
959 return HookFailure(
960 'One or more Portage make files appear to set USE incorrectly.\n'
961 '\n'
962 'All USE assignments in make.conf and all assignments after the\n'
963 'initial declaration in make.defaults should contain "${USE}" to\n'
964 'preserve previously-set flags.\n'
965 '\n'
966 'The initial USE declaration in make.defaults should not contain\n'
967 '"${USE}".\n',
968 errors)
969
970
Mike Frysingerae409522014-02-01 03:16:11 -0500971def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -0700972 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -0400973 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -0700974 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -0400975 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -0500976 if not m:
Vadim Bendebury20532ba2017-05-23 17:26:15 -0700977 return HookFailure('Last paragraph of description must include Change-Id.')
Ryan Cui1562fb82011-05-09 11:01:31 -0700978
Vadim Bendebury20532ba2017-05-23 17:26:15 -0700979 # S-o-b tags always allowed to follow Change-ID.
980 allowed_tags = ['Signed-off-by']
981
Mike Frysinger02b88bd2014-11-21 00:29:38 -0500982 end = desc[m.end():].strip().splitlines()
Vadim Bendebury6504aea2017-09-13 18:35:49 -0700983 cherry_pick_marker = 'cherry picked from commit'
984
985 if end and cherry_pick_marker in end[-1]:
Vadim Bendebury20532ba2017-05-23 17:26:15 -0700986 # Cherry picked patches allow more tags in the last paragraph.
Vadim Bendebury6504aea2017-09-13 18:35:49 -0700987 allowed_tags += ['Commit-Queue', 'Commit-Ready', 'Reviewed-by',
988 'Reviewed-on', 'Tested-by']
Vadim Bendebury20532ba2017-05-23 17:26:15 -0700989 end = end[:-1]
990
Vadim Bendebury6504aea2017-09-13 18:35:49 -0700991 # Note that descriptions could have multiple cherry pick markers.
992 tag_search = r'^(%s:|\(%s) ' % (':|'.join(allowed_tags), cherry_pick_marker)
Vadim Bendebury20532ba2017-05-23 17:26:15 -0700993
994 if [x for x in end if not re.search(tag_search, x)]:
995 return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' %
996 ':", "'.join(allowed_tags))
Mike Frysinger02b88bd2014-11-21 00:29:38 -0500997
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -0700998
Mike Frysinger36b2ebc2014-10-31 14:02:03 -0400999def _check_commit_message_style(_project, commit):
1000 """Verify that the commit message matches our style.
1001
1002 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
1003 commit hooks.
1004 """
1005 desc = _get_commit_desc(commit)
1006
1007 # The first line should be by itself.
1008 lines = desc.splitlines()
1009 if len(lines) > 1 and lines[1]:
1010 return HookFailure('The second line of the commit message must be blank.')
1011
1012 # The first line should be one sentence.
1013 if '. ' in lines[0]:
1014 return HookFailure('The first line cannot be more than one sentence.')
1015
1016 # The first line cannot be too long.
1017 MAX_FIRST_LINE_LEN = 100
1018 if len(lines[0]) > MAX_FIRST_LINE_LEN:
1019 return HookFailure('The first line must be less than %i chars.' %
1020 MAX_FIRST_LINE_LEN)
1021
1022
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001023def _check_cros_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001024 """Verifies the Chromium OS license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -07001025
Mike Frysinger98638102014-08-28 00:15:08 -04001026 Should be following the spec:
1027 http://dev.chromium.org/developers/coding-style#TOC-File-headers
1028 """
1029 # For older years, be a bit more flexible as our policy says leave them be.
1030 LICENSE_HEADER = (
1031 r'.* Copyright( \(c\))? 20[-0-9]{2,7} The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001032 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001033 r'.* Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001034 r'be\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001035 r'.* found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -05001036 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001037 )
1038 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1039
1040 # For newer years, be stricter.
1041 COPYRIGHT_LINE = (
1042 r'.* Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001043 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001044 )
1045 copyright_re = re.compile(COPYRIGHT_LINE)
1046
Shuhei Takahashiabc20f32017-07-10 19:35:45 +09001047 included, excluded = _parse_common_inclusion_options(options)
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001048
Mike Frysinger98638102014-08-28 00:15:08 -04001049 bad_files = []
1050 bad_copyright_files = []
1051 files = _filter_files(_get_affected_files(commit, relative=True),
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001052 included + COMMON_INCLUDED_PATHS,
1053 excluded + COMMON_EXCLUDED_PATHS)
Mike Frysinger98638102014-08-28 00:15:08 -04001054
1055 for f in files:
1056 contents = _get_file_content(f, commit)
1057 if not contents:
1058 # Ignore empty files.
1059 continue
1060
1061 if not license_re.search(contents):
1062 bad_files.append(f)
1063 elif copyright_re.search(contents):
1064 bad_copyright_files.append(f)
1065
1066 if bad_files:
1067 msg = '%s:\n%s\n%s' % (
1068 'License must match', license_re.pattern,
1069 'Found a bad header in these files:')
1070 return HookFailure(msg, bad_files)
1071
1072 if bad_copyright_files:
1073 msg = 'Do not use (c) in copyright headers in new files:'
1074 return HookFailure(msg, bad_copyright_files)
Ryan Cuiec4d6332011-05-02 14:15:25 -07001075
1076
Alex Deymof5792ce2015-08-24 22:50:08 -07001077def _check_aosp_license(_project, commit):
1078 """Verifies the AOSP license/copyright header.
1079
1080 AOSP uses the Apache2 License:
1081 https://source.android.com/source/licenses.html
1082 """
1083 LICENSE_HEADER = (
1084 r"""^[#/\*]*
1085[#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project
1086[#/\*]* ?
1087[#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\);
1088[#/\*]* ?you may not use this file except in compliance with the License\.
1089[#/\*]* ?You may obtain a copy of the License at
1090[#/\*]* ?
1091[#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0
1092[#/\*]* ?
1093[#/\*]* ?Unless required by applicable law or agreed to in writing, software
1094[#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS,
1095[#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """
1096 r"""implied\.
1097[#/\*]* ?See the License for the specific language governing permissions and
1098[#/\*]* ?limitations under the License\.
1099[#/\*]*$
1100"""
1101 )
1102 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1103
1104 files = _filter_files(_get_affected_files(commit, relative=True),
1105 COMMON_INCLUDED_PATHS,
1106 COMMON_EXCLUDED_PATHS)
1107
1108 bad_files = []
1109 for f in files:
1110 contents = _get_file_content(f, commit)
1111 if not contents:
1112 # Ignore empty files.
1113 continue
1114
1115 if not license_re.search(contents):
1116 bad_files.append(f)
1117
1118 if bad_files:
1119 msg = ('License must match:\n%s\nFound a bad header in these files:' %
1120 license_re.pattern)
1121 return HookFailure(msg, bad_files)
1122
1123
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001124def _check_layout_conf(_project, commit):
1125 """Verifies the metadata/layout.conf file."""
1126 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001127 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001128 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001129 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001130
Mike Frysinger94a670c2014-09-19 12:46:26 -04001131 # Handle multiple overlays in a single commit (like the public tree).
1132 for f in _get_affected_files(commit, relative=True):
1133 if f.endswith(repo_name):
1134 repo_names.append(f)
1135 elif f.endswith(layout_path):
1136 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001137
1138 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -04001139 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001140 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -04001141 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001142
Mike Frysinger94a670c2014-09-19 12:46:26 -04001143 # Gather all the errors in one pass so we show one full message.
1144 all_errors = {}
1145 for layout_path in layout_paths:
1146 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001147
Mike Frysinger94a670c2014-09-19 12:46:26 -04001148 # Make sure the config file is sorted.
1149 data = [x for x in _get_file_content(layout_path, commit).splitlines()
1150 if x and x[0] != '#']
1151 if sorted(data) != data:
1152 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001153
Mike Frysinger94a670c2014-09-19 12:46:26 -04001154 # Require people to set specific values all the time.
1155 settings = (
1156 # TODO: Enable this for everyone. http://crbug.com/408038
1157 #('fast caching', 'cache-format = md5-dict'),
1158 ('fast manifests', 'thin-manifests = true'),
Mike Frysingerd7734522015-02-26 16:12:43 -05001159 ('extra features', 'profile-formats = portage-2 profile-default-eapi'),
1160 ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001161 )
1162 for reason, line in settings:
1163 if line not in data:
1164 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001165
Mike Frysinger94a670c2014-09-19 12:46:26 -04001166 # Require one of these settings.
Mike Frysinger5fae62d2015-11-11 20:12:15 -05001167 if 'use-manifests = strict' not in data:
1168 errors += ['enable file checking with: use-manifests = strict']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001169
Mike Frysinger94a670c2014-09-19 12:46:26 -04001170 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -04001171 for line in data:
1172 if line.startswith('repo-name = '):
1173 break
1174 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -04001175 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001176
Mike Frysinger94a670c2014-09-19 12:46:26 -04001177 # Summarize all the errors we saw (if any).
1178 lines = ''
1179 for layout_path, errors in all_errors.items():
1180 if errors:
1181 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
1182 if lines:
1183 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
1184 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001185
1186
Ryan Cuiec4d6332011-05-02 14:15:25 -07001187# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001188
Ryan Cui1562fb82011-05-09 11:01:31 -07001189
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001190def _check_clang_format(_project, commit, options=()):
1191 """Runs clang-format on the given project"""
1192 hooks_dir = _get_hooks_dir()
1193 options = list(options)
1194 if commit == PRE_SUBMIT:
1195 options.append('--commit=HEAD')
1196 else:
1197 options.extend(['--commit', commit])
1198 cmd = ['%s/clang-format.py' % hooks_dir] + options
1199 cmd_result = cros_build_lib.RunCommand(cmd=cmd,
1200 print_cmd=False,
1201 input=_get_patch(commit),
1202 stdout_to_pipe=True,
1203 combine_stdout_stderr=True,
1204 error_code_ok=True)
1205 if cmd_result.returncode:
1206 return HookFailure('clang-format.py errors/warnings\n\n' +
1207 cmd_result.output)
1208
1209
Mike Frysingerae409522014-02-01 03:16:11 -05001210def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001211 """Runs checkpatch.pl on the given project"""
1212 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001213 options = list(options)
1214 if commit == PRE_SUBMIT:
1215 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
1216 # this case.
1217 options.append('--ignore=MISSING_SIGN_OFF')
Filipe Brandenburger28d48d62015-10-07 09:48:54 -07001218 # Always ignore the check for the MAINTAINERS file. We do not track that
1219 # information on that file in our source trees, so let's suppress the
1220 # warning.
1221 options.append('--ignore=FILE_PATH_CHANGES')
Filipe Brandenburgerce978322015-10-09 10:04:15 -07001222 # Do not complain about the Change-Id: fields, since we use Gerrit.
1223 # Upstream does not want those lines (since they do not use Gerrit), but
1224 # we always do, so disable the check globally.
Daisuke Nojiri4844f892015-10-08 09:54:33 -07001225 options.append('--ignore=GERRIT_CHANGE_ID')
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001226 cmd = ['%s/checkpatch.pl' % hooks_dir] + options + ['-']
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001227 cmd_result = cros_build_lib.RunCommand(cmd=cmd,
1228 print_cmd=False,
1229 input=_get_patch(commit),
1230 stdout_to_pipe=True,
1231 combine_stdout_stderr=True,
1232 error_code_ok=True)
1233 if cmd_result.returncode:
1234 return HookFailure('checkpatch.pl errors/warnings\n\n' + cmd_result.output)
Ryan Cuiec4d6332011-05-02 14:15:25 -07001235
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001236
Mike Frysingerae409522014-02-01 03:16:11 -05001237def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -07001238 """Makes sure kernel config changes are not mixed with code changes"""
1239 files = _get_affected_files(commit)
1240 if not len(_filter_files(files, [r'chromeos/config'])) in [0, len(files)]:
1241 return HookFailure('Changes to chromeos/config/ and regular files must '
1242 'be in separate commits:\n%s' % '\n'.join(files))
Anton Staaf815d6852011-08-22 10:08:45 -07001243
Mike Frysingerae409522014-02-01 03:16:11 -05001244
1245def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -07001246 """Checks that all JSON files are syntactically valid."""
Dale Curtisa039cfd2011-05-04 12:01:05 -07001247 for f in _filter_files(_get_affected_files(commit), [r'.*\.json']):
Dale Curtis2975c432011-05-03 17:25:20 -07001248 try:
1249 json.load(open(f))
1250 except Exception, e:
Ryan Cui1562fb82011-05-09 11:01:31 -07001251 return HookFailure('Invalid JSON in %s: %s' % (f, e))
Dale Curtis2975c432011-05-03 17:25:20 -07001252
1253
Mike Frysingerae409522014-02-01 03:16:11 -05001254def _check_manifests(_project, commit):
Mike Frysinger52b537e2013-08-22 22:59:53 -04001255 """Make sure Manifest files only have DIST lines"""
1256 paths = []
1257
1258 for path in _get_affected_files(commit):
1259 if os.path.basename(path) != 'Manifest':
1260 continue
1261 if not os.path.exists(path):
1262 continue
1263
1264 with open(path, 'r') as f:
1265 for line in f.readlines():
1266 if not line.startswith('DIST '):
1267 paths.append(path)
1268 break
1269
1270 if paths:
1271 return HookFailure('Please remove lines that do not start with DIST:\n%s' %
1272 ('\n'.join(paths),))
1273
1274
Mike Frysingerae409522014-02-01 03:16:11 -05001275def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001276 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001277 if commit == PRE_SUBMIT:
1278 return
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001279 BRANCH_RE = r'\nBRANCH=\S+'
1280
1281 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
1282 msg = ('Changelist description needs BRANCH field (after first line)\n'
1283 'E.g. BRANCH=none or BRANCH=link,snow')
1284 return HookFailure(msg)
1285
1286
Mike Frysingerae409522014-02-01 03:16:11 -05001287def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001288 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001289 if commit == PRE_SUBMIT:
1290 return
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001291 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1292
1293 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1294 msg = ('Changelist description needs Signed-off-by: field\n'
1295 'E.g. Signed-off-by: My Name <me@chromium.org>')
1296 return HookFailure(msg)
1297
1298
Aviv Keshet5ac59522017-01-31 14:28:27 -08001299def _check_cq_ini_well_formed(_project, commit):
1300 """Check that any modified COMMIT-QUEUE.ini files are well formed."""
1301 pattern = '.*' + constants.CQ_CONFIG_FILENAME
1302 files = _filter_files(_get_affected_files(commit), (pattern,))
1303
1304 # TODO(akeshet): Check not only that the file is parseable, but that all the
1305 # pre-cq configs it requests are existing ones.
1306 for f in files:
1307 try:
1308 parser = ConfigParser.SafeConfigParser()
1309 # Prior to python3, ConfigParser has no read_string method, so we must
1310 # pass it either a file path or file like object. And we must use
1311 # _get_file_content to fetch file contents to ensure we are examining the
1312 # commit diff, rather than whatever's on disk.
1313 contents = _get_file_content(f, commit)
1314 parser.readfp(StringIO.StringIO(contents))
1315 except ConfigParser.Error as e:
1316 msg = ('Unable to parse COMMIT-QUEUE.ini file at %s due to %s.' %
1317 (f, e))
1318 return HookFailure(msg)
1319
1320
Jon Salz3ee59de2012-08-18 13:54:22 +08001321def _run_project_hook_script(script, project, commit):
1322 """Runs a project hook script.
1323
1324 The script is run with the following environment variables set:
1325 PRESUBMIT_PROJECT: The affected project
1326 PRESUBMIT_COMMIT: The affected commit
1327 PRESUBMIT_FILES: A newline-separated list of affected files
1328
1329 The script is considered to fail if the exit code is non-zero. It should
1330 write an error message to stdout.
1331 """
1332 env = dict(os.environ)
Alex Deymo643ac4c2015-09-03 10:40:50 -07001333 env['PRESUBMIT_PROJECT'] = project.name
Jon Salz3ee59de2012-08-18 13:54:22 +08001334 env['PRESUBMIT_COMMIT'] = commit
1335
1336 # Put affected files in an environment variable
1337 files = _get_affected_files(commit)
1338 env['PRESUBMIT_FILES'] = '\n'.join(files)
1339
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001340 cmd_result = cros_build_lib.RunCommand(cmd=script,
1341 env=env,
1342 shell=True,
1343 print_cmd=False,
1344 input=os.devnull,
1345 stdout_to_pipe=True,
1346 combine_stdout_stderr=True,
1347 error_code_ok=True)
1348 if cmd_result.returncode:
1349 stdout = cmd_result.output
Jon Salz7b618af2012-08-31 06:03:16 +08001350 if stdout:
1351 stdout = re.sub('(?m)^', ' ', stdout)
1352 return HookFailure('Hook script "%s" failed with code %d%s' %
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001353 (script, cmd_result.returncode,
Jon Salz3ee59de2012-08-18 13:54:22 +08001354 ':\n' + stdout if stdout else ''))
1355
1356
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001357def _check_project_prefix(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -05001358 """Require the commit message have a project specific prefix as needed."""
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001359
1360 files = _get_affected_files(commit, relative=True)
1361 prefix = os.path.commonprefix(files)
1362 prefix = os.path.dirname(prefix)
1363
1364 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07001365 if not prefix:
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001366 return
1367
1368 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07001369
1370 # The common files may all be within a subdirectory of the main project
1371 # directory, so walk up the tree until we find an alias file.
1372 # _get_affected_files() should return relative paths, but check against '/' to
1373 # ensure that this loop terminates even if it receives an absolute path.
1374 while prefix and prefix != '/':
1375 alias_file = os.path.join(prefix, '.project_alias')
1376
1377 # If an alias exists, use it.
1378 if os.path.isfile(alias_file):
1379 project_name = osutils.ReadFile(alias_file).strip()
1380
1381 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001382
1383 if not _get_commit_desc(commit).startswith(project_name + ': '):
1384 return HookFailure('The commit title for changes affecting only %s'
1385 ' should start with \"%s: \"'
1386 % (project_name, project_name))
1387
1388
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001389def _check_exec_files(_project, commit):
1390 """Make +x bits on files."""
1391 # List of files that should never be +x.
1392 NO_EXEC = (
1393 'ChangeLog*',
1394 'COPYING',
1395 'make.conf',
1396 'make.defaults',
1397 'Manifest',
1398 'OWNERS',
1399 'package.use',
1400 'package.keywords',
1401 'package.mask',
1402 'parent',
1403 'README',
1404 'TODO',
1405 '.gitignore',
1406 '*.[achly]',
1407 '*.[ch]xx',
1408 '*.boto',
1409 '*.cc',
1410 '*.cfg',
1411 '*.conf',
1412 '*.config',
1413 '*.cpp',
1414 '*.css',
1415 '*.ebuild',
1416 '*.eclass',
1417 '*.gyp',
1418 '*.gypi',
1419 '*.htm',
1420 '*.html',
1421 '*.ini',
1422 '*.js',
1423 '*.json',
1424 '*.md',
1425 '*.mk',
1426 '*.patch',
1427 '*.policy',
1428 '*.proto',
1429 '*.raw',
1430 '*.rules',
1431 '*.service',
1432 '*.target',
1433 '*.txt',
1434 '*.xml',
1435 '*.yaml',
1436 )
1437
1438 def FinalName(obj):
1439 # If the file is being deleted, then the dst_file is not set.
1440 if obj.dst_file is None:
1441 return obj.src_file
1442 else:
1443 return obj.dst_file
1444
1445 bad_files = []
1446 files = _get_affected_files(commit, relative=True, full_details=True)
1447 for f in files:
1448 mode = int(f.dst_mode, 8)
1449 if not mode & 0o111:
1450 continue
1451 name = FinalName(f)
1452 for no_exec in NO_EXEC:
1453 if fnmatch.fnmatch(name, no_exec):
1454 bad_files.append(name)
1455 break
1456
1457 if bad_files:
1458 return HookFailure('These files should not be executable. '
1459 'Please `chmod -x` them.', bad_files)
1460
1461
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001462# Base
1463
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001464# A list of hooks which are not project specific and check patch description
1465# (as opposed to patch body).
1466_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07001467 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07001468 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07001469 _check_change_has_test_field,
1470 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001471 _check_commit_message_style,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001472 _check_change_is_contribution,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001473]
1474
1475
1476# A list of hooks that are not project-specific
1477_COMMON_HOOKS = [
Aviv Keshet5ac59522017-01-31 14:28:27 -08001478 _check_cq_ini_well_formed,
1479 _check_cros_license,
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001480 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05001481 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001482 _check_ebuild_licenses,
Mike Frysingercd363c82014-02-01 05:20:18 -05001483 _check_ebuild_virtual_pv,
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001484 _check_exec_files,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001485 _check_for_uprev,
Rahul Chaudhry09f61372015-07-31 17:14:26 -07001486 _check_gofmt,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001487 _check_layout_conf,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001488 _check_no_long_lines,
1489 _check_no_stray_whitespace,
Ryan Cui9b651632011-05-11 11:38:58 -07001490 _check_no_tabs,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001491 _check_portage_make_use_var,
Aviv Keshet5ac59522017-01-31 14:28:27 -08001492 _check_tabbed_indents,
Ryan Cui9b651632011-05-11 11:38:58 -07001493]
Ryan Cuiec4d6332011-05-02 14:15:25 -07001494
Ryan Cui1562fb82011-05-09 11:01:31 -07001495
Ryan Cui9b651632011-05-11 11:38:58 -07001496# A dictionary of project-specific hooks(callbacks), indexed by project name.
1497# dict[project] = [callback1, callback2]
1498_PROJECT_SPECIFIC_HOOKS = {
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001499 "chromiumos/platform2": [_check_project_prefix],
Mike Frysingeraf891292015-03-25 19:46:53 -04001500 "chromiumos/third_party/kernel": [_kernel_configcheck],
1501 "chromiumos/third_party/kernel-next": [_kernel_configcheck],
Ryan Cui9b651632011-05-11 11:38:58 -07001502}
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001503
Ryan Cui1562fb82011-05-09 11:01:31 -07001504
Ryan Cui9b651632011-05-11 11:38:58 -07001505# A dictionary of flags (keys) that can appear in the config file, and the hook
Mike Frysinger3554bc92015-03-11 04:59:21 -04001506# that the flag controls (value).
1507_HOOK_FLAGS = {
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001508 'clang_format_check': _check_clang_format,
Mike Frysingera7642f52015-03-25 18:31:42 -04001509 'checkpatch_check': _run_checkpatch,
Ryan Cui9b651632011-05-11 11:38:58 -07001510 'stray_whitespace_check': _check_no_stray_whitespace,
Mike Frysingerff6c7d62015-03-24 13:49:46 -04001511 'json_check': _run_json_check,
Ryan Cui9b651632011-05-11 11:38:58 -07001512 'long_line_check': _check_no_long_lines,
Alex Deymof5792ce2015-08-24 22:50:08 -07001513 'cros_license_check': _check_cros_license,
1514 'aosp_license_check': _check_aosp_license,
Ryan Cui9b651632011-05-11 11:38:58 -07001515 'tab_check': _check_no_tabs,
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08001516 'tabbed_indent_required_check': _check_tabbed_indents,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001517 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001518 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07001519 'bug_field_check': _check_change_has_bug_field,
1520 'test_field_check': _check_change_has_test_field,
Steve Fung49ec7e92015-03-23 16:07:12 -07001521 'manifest_check': _check_manifests,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001522 'contribution_check': _check_change_is_contribution,
Ryan Cui9b651632011-05-11 11:38:58 -07001523}
1524
1525
Mike Frysinger3554bc92015-03-11 04:59:21 -04001526def _get_override_hooks(config):
1527 """Returns a set of hooks controlled by the current project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001528
1529 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08001530
1531 Args:
1532 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001533 """
1534 SECTION = 'Hook Overrides'
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001535 SECTION_OPTIONS = 'Hook Overrides Options'
Jon Salz3ee59de2012-08-18 13:54:22 +08001536 if not config.has_section(SECTION):
Mike Frysinger3554bc92015-03-11 04:59:21 -04001537 return set(), set()
Ryan Cui9b651632011-05-11 11:38:58 -07001538
Mike Frysinger3554bc92015-03-11 04:59:21 -04001539 valid_keys = set(_HOOK_FLAGS.iterkeys())
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001540 hooks = _HOOK_FLAGS.copy()
Mike Frysinger3554bc92015-03-11 04:59:21 -04001541
1542 enable_flags = []
Ryan Cui9b651632011-05-11 11:38:58 -07001543 disable_flags = []
Jon Salz3ee59de2012-08-18 13:54:22 +08001544 for flag in config.options(SECTION):
Mike Frysinger3554bc92015-03-11 04:59:21 -04001545 if flag not in valid_keys:
1546 raise ValueError('Error: unknown key "%s" in hook section of "%s"' %
1547 (flag, _CONFIG_FILE))
1548
Ryan Cui9b651632011-05-11 11:38:58 -07001549 try:
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001550 enabled = config.getboolean(SECTION, flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001551 except ValueError as e:
Mike Frysinger3554bc92015-03-11 04:59:21 -04001552 raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' %
1553 (flag, _CONFIG_FILE, e))
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001554 if enabled:
1555 enable_flags.append(flag)
1556 else:
1557 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001558
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001559 # See if this hook has custom options.
1560 if enabled:
1561 try:
1562 options = config.get(SECTION_OPTIONS, flag)
1563 hooks[flag] = functools.partial(hooks[flag], options=options.split())
1564 except (ConfigParser.NoOptionError, ConfigParser.NoSectionError):
1565 pass
1566
1567 enabled_hooks = set(hooks[x] for x in enable_flags)
1568 disabled_hooks = set(hooks[x] for x in disable_flags)
Mike Frysinger3554bc92015-03-11 04:59:21 -04001569 return enabled_hooks, disabled_hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001570
1571
Jon Salz3ee59de2012-08-18 13:54:22 +08001572def _get_project_hook_scripts(config):
1573 """Returns a list of project-specific hook scripts.
1574
1575 Args:
1576 config: A ConfigParser for the project's config file.
1577 """
1578 SECTION = 'Hook Scripts'
1579 if not config.has_section(SECTION):
1580 return []
1581
1582 hook_names_values = config.items(SECTION)
1583 hook_names_values.sort(key=lambda x: x[0])
1584 return [x[1] for x in hook_names_values]
1585
1586
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001587def _get_project_hooks(project, presubmit):
Ryan Cui9b651632011-05-11 11:38:58 -07001588 """Returns a list of hooks that need to be run for a project.
1589
1590 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001591
1592 Args:
1593 project: A string, name of the project.
1594 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui9b651632011-05-11 11:38:58 -07001595 """
Jon Salz3ee59de2012-08-18 13:54:22 +08001596 config = ConfigParser.RawConfigParser()
1597 try:
1598 config.read(_CONFIG_FILE)
1599 except ConfigParser.Error:
1600 # Just use an empty config file
1601 config = ConfigParser.RawConfigParser()
1602
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001603 if presubmit:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001604 hooks = _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001605 else:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001606 hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001607
Mike Frysinger3554bc92015-03-11 04:59:21 -04001608 enabled_hooks, disabled_hooks = _get_override_hooks(config)
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001609 hooks = [hook for hook in hooks if hook not in disabled_hooks]
1610
1611 # If a list is both in _COMMON_HOOKS and also enabled explicitly through an
1612 # override, keep the override only. Note that the override may end up being
1613 # a functools.partial, in which case we need to extract the .func to compare
1614 # it to the common hooks.
1615 unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks]
1616 hooks = [hook for hook in hooks if hook not in unwrapped_hooks]
1617
1618 hooks = list(enabled_hooks) + hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001619
1620 if project in _PROJECT_SPECIFIC_HOOKS:
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001621 hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project]
1622 if hook not in disabled_hooks)
Ryan Cui9b651632011-05-11 11:38:58 -07001623
Jon Salz3ee59de2012-08-18 13:54:22 +08001624 for script in _get_project_hook_scripts(config):
1625 hooks.append(functools.partial(_run_project_hook_script, script))
1626
Ryan Cui9b651632011-05-11 11:38:58 -07001627 return hooks
1628
1629
Alex Deymo643ac4c2015-09-03 10:40:50 -07001630def _run_project_hooks(project_name, proj_dir=None,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001631 commit_list=None, presubmit=False):
Ryan Cui1562fb82011-05-09 11:01:31 -07001632 """For each project run its project specific hook from the hooks dictionary.
1633
1634 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001635 project_name: The name of project to run hooks for.
Doug Anderson44a644f2011-11-02 10:37:37 -07001636 proj_dir: If non-None, this is the directory the project is in. If None,
1637 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07001638 commit_list: A list of commits to run hooks against. If None or empty list
1639 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001640 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui1562fb82011-05-09 11:01:31 -07001641
1642 Returns:
1643 Boolean value of whether any errors were ecountered while running the hooks.
1644 """
Doug Anderson44a644f2011-11-02 10:37:37 -07001645 if proj_dir is None:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001646 proj_dirs = _run_command(
1647 ['repo', 'forall', project_name, '-c', 'pwd']).split()
David James2edd9002013-10-11 14:09:19 -07001648 if len(proj_dirs) == 0:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001649 print('%s cannot be found.' % project_name, file=sys.stderr)
David James2edd9002013-10-11 14:09:19 -07001650 print('Please specify a valid project.', file=sys.stderr)
1651 return True
1652 if len(proj_dirs) > 1:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001653 print('%s is associated with multiple directories.' % project_name,
David James2edd9002013-10-11 14:09:19 -07001654 file=sys.stderr)
1655 print('Please specify a directory to help disambiguate.', file=sys.stderr)
1656 return True
1657 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07001658
Ryan Cuiec4d6332011-05-02 14:15:25 -07001659 pwd = os.getcwd()
1660 # hooks assume they are run from the root of the project
1661 os.chdir(proj_dir)
1662
Alex Deymo643ac4c2015-09-03 10:40:50 -07001663 remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref',
1664 '--symbolic-full-name', '@{u}']).strip()
1665 if not remote_branch:
1666 print('Your project %s doesn\'t track any remote repo.' % project_name,
1667 file=sys.stderr)
1668 remote = None
1669 else:
1670 remote, _branch = remote_branch.split('/', 1)
1671
1672 project = Project(name=project_name, dir=proj_dir, remote=remote)
1673
Doug Anderson14749562013-06-26 13:38:29 -07001674 if not commit_list:
1675 try:
1676 commit_list = _get_commits()
1677 except VerifyException as e:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001678 PrintErrorForProject(project.name, HookFailure(str(e)))
Doug Anderson14749562013-06-26 13:38:29 -07001679 os.chdir(pwd)
1680 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07001681
Alex Deymo643ac4c2015-09-03 10:40:50 -07001682 hooks = _get_project_hooks(project.name, presubmit)
Ryan Cui1562fb82011-05-09 11:01:31 -07001683 error_found = False
Ryan Cuifa55df52011-05-06 11:16:55 -07001684 for commit in commit_list:
Ryan Cui1562fb82011-05-09 11:01:31 -07001685 error_list = []
Ryan Cui9b651632011-05-11 11:38:58 -07001686 for hook in hooks:
Ryan Cui1562fb82011-05-09 11:01:31 -07001687 hook_error = hook(project, commit)
1688 if hook_error:
1689 error_list.append(hook_error)
1690 error_found = True
1691 if error_list:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001692 PrintErrorsForCommit(project.name, commit, _get_commit_desc(commit),
Ryan Cui1562fb82011-05-09 11:01:31 -07001693 error_list)
Don Garrettdba548a2011-05-05 15:17:14 -07001694
Ryan Cuiec4d6332011-05-02 14:15:25 -07001695 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07001696 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001697
Mike Frysingerae409522014-02-01 03:16:11 -05001698
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001699# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07001700
Ryan Cui1562fb82011-05-09 11:01:31 -07001701
Mike Frysingerae409522014-02-01 03:16:11 -05001702def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08001703 """Main function invoked directly by repo.
1704
1705 This function will exit directly upon error so that repo doesn't print some
1706 obscure error message.
1707
1708 Args:
1709 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07001710 worktree_list: A list of directories. It should be the same length as
1711 project_list, so that each entry in project_list matches with a directory
1712 in worktree_list. If None, we will attempt to calculate the directories
1713 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08001714 kwargs: Leave this here for forward-compatibility.
1715 """
Ryan Cui1562fb82011-05-09 11:01:31 -07001716 found_error = False
David James2edd9002013-10-11 14:09:19 -07001717 if not worktree_list:
1718 worktree_list = [None] * len(project_list)
1719 for project, worktree in zip(project_list, worktree_list):
1720 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07001721 found_error = True
1722
Mike Frysingerae409522014-02-01 03:16:11 -05001723 if found_error:
Ryan Cui1562fb82011-05-09 11:01:31 -07001724 msg = ('Preupload failed due to errors in project(s). HINTS:\n'
Ryan Cui9b651632011-05-11 11:38:58 -07001725 '- To disable some source style checks, and for other hints, see '
1726 '<checkout_dir>/src/repohooks/README\n'
1727 '- To upload only current project, run \'repo upload .\'')
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04001728 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07001729 sys.exit(1)
Anush Elangovan63afad72011-03-23 00:41:27 -07001730
Ryan Cui1562fb82011-05-09 11:01:31 -07001731
Doug Anderson44a644f2011-11-02 10:37:37 -07001732def _identify_project(path):
1733 """Identify the repo project associated with the given path.
1734
1735 Returns:
1736 A string indicating what project is associated with the path passed in or
1737 a blank string upon failure.
1738 """
1739 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001740 redirect_stderr=True, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07001741
1742
Mike Frysinger55f85b52014-12-18 14:45:21 -05001743def direct_main(argv):
Doug Anderson44a644f2011-11-02 10:37:37 -07001744 """Run hooks directly (outside of the context of repo).
1745
Doug Anderson44a644f2011-11-02 10:37:37 -07001746 Args:
Mike Frysinger55f85b52014-12-18 14:45:21 -05001747 argv: The command line args to process
Doug Anderson44a644f2011-11-02 10:37:37 -07001748
1749 Returns:
1750 0 if no pre-upload failures, 1 if failures.
1751
1752 Raises:
1753 BadInvocation: On some types of invocation errors.
1754 """
Mike Frysinger66142932014-12-18 14:55:57 -05001755 parser = commandline.ArgumentParser(description=__doc__)
1756 parser.add_argument('--dir', default=None,
1757 help='The directory that the project lives in. If not '
1758 'specified, use the git project root based on the cwd.')
1759 parser.add_argument('--project', default=None,
1760 help='The project repo path; this can affect how the '
1761 'hooks get run, since some hooks are project-specific. '
1762 'For chromite this is chromiumos/chromite. If not '
1763 'specified, the repo tool will be used to figure this '
1764 'out based on the dir.')
1765 parser.add_argument('--rerun-since', default=None,
1766 help='Rerun hooks on old commits since the given date. '
1767 'The date should match git log\'s concept of a date. '
1768 'e.g. 2012-06-20. This option is mutually exclusive '
1769 'with --pre-submit.')
1770 parser.add_argument('--pre-submit', action="store_true",
1771 help='Run the check against the pending commit. '
1772 'This option should be used at the \'git commit\' '
1773 'phase as opposed to \'repo upload\'. This option '
1774 'is mutually exclusive with --rerun-since.')
1775 parser.add_argument('commits', nargs='*',
1776 help='Check specific commits')
1777 opts = parser.parse_args(argv)
Doug Anderson44a644f2011-11-02 10:37:37 -07001778
Doug Anderson14749562013-06-26 13:38:29 -07001779 if opts.rerun_since:
Mike Frysinger66142932014-12-18 14:55:57 -05001780 if opts.commits:
Doug Anderson14749562013-06-26 13:38:29 -07001781 raise BadInvocation('Can\'t pass commits and use rerun-since: %s' %
Mike Frysinger66142932014-12-18 14:55:57 -05001782 ' '.join(opts.commits))
Doug Anderson14749562013-06-26 13:38:29 -07001783
1784 cmd = ['git', 'log', '--since="%s"' % opts.rerun_since, '--pretty=%H']
1785 all_commits = _run_command(cmd).splitlines()
1786 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
1787
1788 # Eliminate chrome-bot commits but keep ordering the same...
1789 bot_commits = set(bot_commits)
Mike Frysinger66142932014-12-18 14:55:57 -05001790 opts.commits = [c for c in all_commits if c not in bot_commits]
Doug Anderson14749562013-06-26 13:38:29 -07001791
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001792 if opts.pre_submit:
1793 raise BadInvocation('rerun-since and pre-submit can not be '
1794 'used together')
1795 if opts.pre_submit:
Mike Frysinger66142932014-12-18 14:55:57 -05001796 if opts.commits:
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001797 raise BadInvocation('Can\'t pass commits and use pre-submit: %s' %
Mike Frysinger66142932014-12-18 14:55:57 -05001798 ' '.join(opts.commits))
1799 opts.commits = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07001800
1801 # Check/normlaize git dir; if unspecified, we'll use the root of the git
1802 # project from CWD
1803 if opts.dir is None:
1804 git_dir = _run_command(['git', 'rev-parse', '--git-dir'],
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001805 redirect_stderr=True).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07001806 if not git_dir:
1807 raise BadInvocation('The current directory is not part of a git project.')
1808 opts.dir = os.path.dirname(os.path.abspath(git_dir))
1809 elif not os.path.isdir(opts.dir):
1810 raise BadInvocation('Invalid dir: %s' % opts.dir)
1811 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
1812 raise BadInvocation('Not a git directory: %s' % opts.dir)
1813
1814 # Identify the project if it wasn't specified; this _requires_ the repo
1815 # tool to be installed and for the project to be part of a repo checkout.
1816 if not opts.project:
1817 opts.project = _identify_project(opts.dir)
1818 if not opts.project:
1819 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
1820
Doug Anderson14749562013-06-26 13:38:29 -07001821 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Mike Frysinger66142932014-12-18 14:55:57 -05001822 commit_list=opts.commits,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001823 presubmit=opts.pre_submit)
Doug Anderson44a644f2011-11-02 10:37:37 -07001824 if found_error:
1825 return 1
1826 return 0
1827
1828
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07001829if __name__ == '__main__':
Mike Frysinger55f85b52014-12-18 14:45:21 -05001830 sys.exit(direct_main(sys.argv[1:]))