blob: 6807c486f8a05d2154567eaf88bccbb4fdb85e9d [file] [log] [blame]
Mike Frysinger4f994402019-09-13 17:40:45 -04001#!/usr/bin/env python3
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002# -*- coding: utf-8 -*-
Jon Salz98255932012-08-18 14:48:02 +08003# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
Mike Frysingerae409522014-02-01 03:16:11 -05007"""Presubmit checks to run when doing `repo upload`.
8
9You can add new checks by adding a functions to the HOOKS constants.
10"""
11
Mike Frysinger09d6a3d2013-10-08 22:21:03 -040012from __future__ import print_function
13
Keigo Okadd908822019-06-04 11:30:25 +090014import argparse
Alex Deymo643ac4c2015-09-03 10:40:50 -070015import collections
Mike Frysingerf252cfc2019-12-09 17:34:28 -050016import configparser
Keigo Oka7e880ac2019-07-03 15:03:43 +090017import datetime
Daniel Erate3ea3fc2015-02-13 15:27:52 -070018import fnmatch
Jon Salz3ee59de2012-08-18 13:54:22 +080019import functools
Dale Curtis2975c432011-05-03 17:25:20 -070020import json
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070021import os
Ryan Cuiec4d6332011-05-02 14:15:25 -070022import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070023import sys
Peter Ammon811f6702014-06-12 15:45:38 -070024import stat
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -050025import subprocess
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070026
Ryan Cui1562fb82011-05-09 11:01:31 -070027from errors import (VerifyException, HookFailure, PrintErrorForProject,
28 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070029
Mike Frysinger919c7032019-09-13 17:48:08 -040030if __name__ in ('__builtin__', 'builtins'):
Mike Frysinger653cd262019-09-20 14:05:02 -040031 # If repo imports us, the __name__ will be __builtin__, and the cwd will be in
32 # the top level of the checkout (i.e. $CHROMEOS_CHECKOUT). chromite will be
33 # in that directory, so add it to our path. This works whether we're running
34 # the repo in $CHROMEOS_CHECKOUT/.repo/repo/ or a custom version in a
35 # completely different tree.
36 # TODO(vapier): Python 2 used "__builtin__" while Python 3 uses "builtins".
Mike Frysinger6850d512018-05-21 12:12:14 -040037 sys.path.insert(0, os.getcwd())
38
Mike Frysinger653cd262019-09-20 14:05:02 -040039elif __name__ == '__main__':
40 # If we're run directly, we'll find chromite relative to the repohooks dir in
41 # $CHROMEOS_CHECKOUT/src/repohooks, so go up two dirs.
David Jamesc3b68b32013-04-03 09:17:03 -070042 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
43
Mike Frysingerfd481ce2019-09-13 18:14:48 -040044# The sys.path monkey patching confuses the linter.
45# pylint: disable=wrong-import-position
Mike Frysinger66142932014-12-18 14:55:57 -050046from chromite.lib import commandline
Rahul Chaudhry0e515342015-08-07 12:00:43 -070047from chromite.lib import cros_build_lib
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050048from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070049from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070050from chromite.lib import patch
Mike Frysingered1b95a2019-12-12 19:04:51 -050051from chromite.lib import terminal
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040052from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070053
Mike Frysingerff4768e2020-02-27 18:48:13 -050054
55assert sys.version_info >= (3, 6), 'This module requires Python 3.6+'
56
57
Vadim Bendebury2b62d742014-06-22 13:14:51 -070058PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070059
Mike Frysingered9b2a02019-12-12 18:52:32 -050060
61# Link to commit message documentation for users.
62DOC_COMMIT_MSG_URL = ('https://chromium.googlesource.com/chromiumos/docs/+/HEAD'
63 '/contributing.md#commit-messages')
64
65
Ryan Cuiec4d6332011-05-02 14:15:25 -070066COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050067 # C++ and friends
Mike Frysinger24dd3c52019-08-17 14:22:48 -040068 r'.*\.c$', r'.*\.cc$', r'.*\.cpp$', r'.*\.h$', r'.*\.m$', r'.*\.mm$',
69 r'.*\.inl$', r'.*\.asm$', r'.*\.hxx$', r'.*\.hpp$', r'.*\.s$', r'.*\.S$',
Mike Frysingerae409522014-02-01 03:16:11 -050070 # Scripts
Mike Frysinger24dd3c52019-08-17 14:22:48 -040071 r'.*\.js$', r'.*\.py$', r'.*\.sh$', r'.*\.rb$', r'.*\.pl$', r'.*\.pm$',
Mike Frysingerae409522014-02-01 03:16:11 -050072 # No extension at all, note that ALL CAPS files are black listed in
73 # COMMON_EXCLUDED_LIST below.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040074 r'(^|.*[\\\/])[^.]+$',
Mike Frysingerae409522014-02-01 03:16:11 -050075 # Other
Mike Frysinger24dd3c52019-08-17 14:22:48 -040076 r'.*\.java$', r'.*\.mk$', r'.*\.am$',
77 r'.*\.policy$', r'.*\.conf$', r'.*\.go$',
78 r'(^OWNERS|/OWNERS)',
Ryan Cuiec4d6332011-05-02 14:15:25 -070079]
80
Ryan Cui1562fb82011-05-09 11:01:31 -070081
Ryan Cuiec4d6332011-05-02 14:15:25 -070082COMMON_EXCLUDED_PATHS = [
Daniel Erate3ea3fc2015-02-13 15:27:52 -070083 # For ebuild trees, ignore any caches and manifest data.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040084 r'.*/Manifest$',
85 r'.*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$',
Doug Anderson5bfb6792011-10-25 16:45:41 -070086
Daniel Erate3ea3fc2015-02-13 15:27:52 -070087 # Ignore profiles data (like overlay-tegra2/profiles).
Mike Frysinger24dd3c52019-08-17 14:22:48 -040088 r'(^|.*/)overlay-.*/profiles/.*',
89 r'^profiles/.*$',
Mike Frysinger98638102014-08-28 00:15:08 -040090
C Shapiro8f90e9b2017-06-28 09:54:50 -060091 # Ignore config files in ebuild setup.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040092 r'(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*',
93 r'^chromeos-base/chromeos-bsp.*/files/.*',
C Shapiro8f90e9b2017-06-28 09:54:50 -060094
Daniel Erate3ea3fc2015-02-13 15:27:52 -070095 # Ignore minified js and jquery.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040096 r'.*\.min\.js',
97 r'.*jquery.*\.js',
Mike Frysinger33a458d2014-03-03 17:00:51 -050098
99 # Ignore license files as the content is often taken verbatim.
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400100 r'.*/licenses/.*',
Alex Klein619c0912019-01-30 17:13:23 -0700101
Mike Frysinger13650402019-07-31 14:31:46 -0400102 # Exclude generated protobuf bindings.
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400103 r'.*_pb2\.py$',
104 r'.*\.pb\.go$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700105]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700106
Ken Turnerd07564b2018-02-08 17:57:59 +1100107LICENSE_EXCLUDED_PATHS = [
LaMont Jones775c2b32020-02-19 17:32:54 -0700108 r'^(.*/)?OWNERS(\..*)?$',
Ken Turnerd07564b2018-02-08 17:57:59 +1100109]
Ryan Cui1562fb82011-05-09 11:01:31 -0700110
Ryan Cui9b651632011-05-11 11:38:58 -0700111_CONFIG_FILE = 'PRESUBMIT.cfg'
112
113
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700114# File containing wildcards, one per line, matching files that should be
115# excluded from presubmit checks. Lines beginning with '#' are ignored.
116_IGNORE_FILE = '.presubmitignore'
117
Cheng Yuehb707c522020-01-02 14:06:59 +0800118
119TEST_FIELD_RE = r'\nTEST=\S+'
120
Doug Anderson44a644f2011-11-02 10:37:37 -0700121# Exceptions
122
123
124class BadInvocation(Exception):
125 """An Exception indicating a bad invocation of the program."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700126
127
Ryan Cui1562fb82011-05-09 11:01:31 -0700128# General Helpers
129
Sean Paulba01d402011-05-05 11:36:23 -0400130
Mike Frysingerb2496652019-09-12 23:35:46 -0400131class Cache(object):
132 """General helper for caching git content."""
133
134 def __init__(self):
135 self._cache = {}
136
137 def get_subcache(self, scope):
138 return self._cache.setdefault(scope, {})
139
140 def clear(self):
141 self._cache.clear()
142
143CACHE = Cache()
144
145
Alex Deymo643ac4c2015-09-03 10:40:50 -0700146Project = collections.namedtuple('Project', ['name', 'dir', 'remote'])
147
148
Mike Frysinger526a5f82019-09-13 18:05:30 -0400149def _run_command(cmd, **kwargs):
Doug Anderson44a644f2011-11-02 10:37:37 -0700150 """Executes the passed in command and returns raw stdout output.
151
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400152 This is a convenience func to set some run defaults differently.
Mike Frysinger526a5f82019-09-13 18:05:30 -0400153
Doug Anderson44a644f2011-11-02 10:37:37 -0700154 Args:
155 cmd: The command to run; should be a list of strings.
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400156 **kwargs: Same as cros_build_lib.run.
Doug Anderson44a644f2011-11-02 10:37:37 -0700157
158 Returns:
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700159 The stdout from the process (discards stderr and returncode).
Doug Anderson44a644f2011-11-02 10:37:37 -0700160 """
Mike Frysinger526a5f82019-09-13 18:05:30 -0400161 kwargs.setdefault('print_cmd', False)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400162 kwargs.setdefault('stdout', True)
163 kwargs.setdefault('check', False)
Mike Frysinger054c1592019-11-18 03:51:54 -0500164 result = cros_build_lib.run(cmd, **kwargs)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400165 # NB: We decode this directly rather than through kwargs as our tests rely
166 # on this post-processing behavior currently.
Mike Frysinger71e643e2019-09-13 17:26:39 -0400167 return result.output.decode('utf-8', 'replace')
Ryan Cui72834d12011-05-05 14:51:33 -0700168
Ryan Cui1562fb82011-05-09 11:01:31 -0700169
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700170def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700171 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700172 if __name__ == '__main__':
173 # Works when file is run on its own (__file__ is defined)...
174 return os.path.abspath(os.path.dirname(__file__))
175 else:
176 # We need to do this when we're run through repo. Since repo executes
177 # us with execfile(), we don't get __file__ defined.
178 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
179 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700180
Ryan Cui1562fb82011-05-09 11:01:31 -0700181
Ryan Cuiec4d6332011-05-02 14:15:25 -0700182def _match_regex_list(subject, expressions):
183 """Try to match a list of regular expressions to a string.
184
185 Args:
186 subject: The string to match regexes on
187 expressions: A list of regular expressions to check for matches with.
188
189 Returns:
190 Whether the passed in subject matches any of the passed in regexes.
191 """
192 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500193 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700194 return True
195 return False
196
Ryan Cui1562fb82011-05-09 11:01:31 -0700197
Mike Frysingerae409522014-02-01 03:16:11 -0500198def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700199 """Filter out files based on the conditions passed in.
200
201 Args:
202 files: list of filepaths to filter
203 include_list: list of regex that when matched with a file path will cause it
204 to be added to the output list unless the file is also matched with a
205 regex in the exclude_list.
206 exclude_list: list of regex that when matched with a file will prevent it
207 from being added to the output list, even if it is also matched with a
208 regex in the include_list.
209
210 Returns:
211 A list of filepaths that contain files matched in the include_list and not
212 in the exclude_list.
213 """
214 filtered = []
215 for f in files:
216 if (_match_regex_list(f, include_list) and
217 not _match_regex_list(f, exclude_list)):
218 filtered.append(f)
219 return filtered
220
Ryan Cuiec4d6332011-05-02 14:15:25 -0700221
222# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700223
224
Ryan Cui4725d952011-05-05 15:41:19 -0700225def _get_upstream_branch():
226 """Returns the upstream tracking branch of the current branch.
227
228 Raises:
229 Error if there is no tracking branch
230 """
231 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
232 current_branch = current_branch.replace('refs/heads/', '')
233 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700234 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700235
236 cfg_option = 'branch.' + current_branch + '.%s'
237 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
238 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
239 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700240 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700241
242 return full_upstream.replace('heads', 'remotes/' + remote)
243
Ryan Cui1562fb82011-05-09 11:01:31 -0700244
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700245def _get_patch(commit):
246 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700247 if commit == PRE_SUBMIT:
248 return _run_command(['git', 'diff', '--cached', 'HEAD'])
249 else:
250 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700251
Ryan Cui1562fb82011-05-09 11:01:31 -0700252
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500253def _get_file_content(path, commit):
254 """Returns the content of a file at a specific commit.
255
256 We can't rely on the file as it exists in the filesystem as people might be
257 uploading a series of changes which modifies the file multiple times.
258
259 Note: The "content" of a symlink is just the target. So if you're expecting
260 a full file, you should check that first. One way to detect is that the
261 content will not have any newlines.
262 """
Mike Frysingerb2496652019-09-12 23:35:46 -0400263 # Make sure people don't accidentally pass in full paths which will never
264 # work. You need to use relative=True with _get_affected_files.
265 if path.startswith('/'):
266 raise ValueError('_get_file_content must be called with relative paths: %s'
267 % (path,))
268
269 # {<commit>: {<path1>: <content>, <path2>: <content>}}
270 cache = CACHE.get_subcache('get_file_content')
271 if path in cache:
272 return cache[path]
273
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700274 if commit == PRE_SUBMIT:
Mike Frysingerb2496652019-09-12 23:35:46 -0400275 content = _run_command(['git', 'diff', 'HEAD', path])
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700276 else:
Mike Frysingerb2496652019-09-12 23:35:46 -0400277 content = _run_command(['git', 'show', '%s:%s' % (commit, path)])
278 cache[path] = content
279 return content
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500280
281
Mike Frysingerae409522014-02-01 03:16:11 -0500282def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700283 """Returns a list of (linenum, lines) tuples that the commit touched."""
Mike Frysingerb2496652019-09-12 23:35:46 -0400284 # {<commit>: {<path1>: <content>, <path2>: <content>}}
285 cache = CACHE.get_subcache('get_file_diff')
286 if path in cache:
287 return cache[path]
288
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700289 if commit == PRE_SUBMIT:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800290 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD',
291 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700292 else:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800293 command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit,
294 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700295 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700296
297 new_lines = []
298 line_num = 0
299 for line in output.splitlines():
300 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
301 if m:
302 line_num = int(m.groups(1)[0])
303 continue
304 if line.startswith('+') and not line.startswith('++'):
Mike Frysinger71e643e2019-09-13 17:26:39 -0400305 new_lines.append((line_num, line[1:]))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700306 if not line.startswith('-'):
307 line_num += 1
Mike Frysingerb2496652019-09-12 23:35:46 -0400308 cache[path] = new_lines
Ryan Cuiec4d6332011-05-02 14:15:25 -0700309 return new_lines
310
Ryan Cui1562fb82011-05-09 11:01:31 -0700311
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700312def _get_ignore_wildcards(directory, cache):
313 """Get wildcards listed in a directory's _IGNORE_FILE.
314
315 Args:
316 directory: A string containing a directory path.
317 cache: A dictionary (opaque to caller) caching previously-read wildcards.
318
319 Returns:
320 A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE
321 wasn't present.
322 """
323 # In the cache, keys are directories and values are lists of wildcards from
324 # _IGNORE_FILE within those directories (and empty if no file was present).
325 if directory not in cache:
326 wildcards = []
327 dotfile_path = os.path.join(directory, _IGNORE_FILE)
328 if os.path.exists(dotfile_path):
329 # TODO(derat): Consider using _get_file_content() to get the file as of
330 # this commit instead of the on-disk version. This may have a noticeable
331 # performance impact, as each call to _get_file_content() runs git.
332 with open(dotfile_path, 'r') as dotfile:
333 for line in dotfile.readlines():
334 line = line.strip()
335 if line.startswith('#'):
336 continue
337 if line.endswith('/'):
338 line += '*'
339 wildcards.append(line)
340 cache[directory] = wildcards
341
342 return cache[directory]
343
344
345def _path_is_ignored(path, cache):
346 """Check whether a path is ignored by _IGNORE_FILE.
347
348 Args:
349 path: A string containing a path.
350 cache: A dictionary (opaque to caller) caching previously-read wildcards.
351
352 Returns:
353 True if a file named _IGNORE_FILE in one of the passed-in path's parent
354 directories contains a wildcard matching the path.
355 """
356 # Skip ignore files.
357 if os.path.basename(path) == _IGNORE_FILE:
358 return True
359
360 path = os.path.abspath(path)
361 base = os.getcwd()
362
363 prefix = os.path.dirname(path)
364 while prefix.startswith(base):
365 rel_path = path[len(prefix) + 1:]
366 for wildcard in _get_ignore_wildcards(prefix, cache):
367 if fnmatch.fnmatch(rel_path, wildcard):
368 return True
369 prefix = os.path.dirname(prefix)
370
371 return False
372
373
Mike Frysinger292b45d2014-11-25 01:17:10 -0500374def _get_affected_files(commit, include_deletes=False, relative=False,
375 include_symlinks=False, include_adds=True,
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700376 full_details=False, use_ignore_files=True):
Peter Ammon811f6702014-06-12 15:45:38 -0700377 """Returns list of file paths that were modified/added, excluding symlinks.
378
379 Args:
380 commit: The commit
381 include_deletes: If true, we'll include deleted files in the result
382 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500383 include_symlinks: If true, we'll include symlinks in the result
384 include_adds: If true, we'll include new files in the result
385 full_details: If False, return filenames, else return structured results.
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700386 use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files.
Peter Ammon811f6702014-06-12 15:45:38 -0700387
388 Returns:
389 A list of modified/added (and perhaps deleted) files
390 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500391 if not relative and full_details:
392 raise ValueError('full_details only supports relative paths currently')
393
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700394 if commit == PRE_SUBMIT:
395 return _run_command(['git', 'diff-index', '--cached',
396 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500397
398 path = os.getcwd()
Mike Frysingerb2496652019-09-12 23:35:46 -0400399 # {<commit>: {<path1>: <content>, <path2>: <content>}}
400 cache = CACHE.get_subcache('get_affected_files')
401 if path not in cache:
402 cache[path] = git.RawDiff(path, '%s^!' % commit)
403 files = cache[path]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500404
405 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500406 if not include_symlinks:
407 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500408
409 if not include_deletes:
410 files = [x for x in files if x.status != 'D']
411
Mike Frysinger292b45d2014-11-25 01:17:10 -0500412 if not include_adds:
413 files = [x for x in files if x.status != 'A']
414
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700415 if use_ignore_files:
416 cache = {}
417 is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache)
418 files = [x for x in files if not is_ignored(x)]
419
Mike Frysinger292b45d2014-11-25 01:17:10 -0500420 if full_details:
421 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500422 return files
423 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500424 # Caller only cares about filenames.
425 files = [x.dst_file if x.dst_file else x.src_file for x in files]
426 if relative:
427 return files
428 else:
429 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700430
431
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700432def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700433 """Returns a list of commits for this review."""
Mike Frysingere300c7d2019-09-12 23:33:52 -0400434 cmd = ['git', 'log', '--no-merges', '--format=%H',
435 '%s..' % _get_upstream_branch()]
Ryan Cui72834d12011-05-05 14:51:33 -0700436 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700437
Ryan Cui1562fb82011-05-09 11:01:31 -0700438
Ryan Cuiec4d6332011-05-02 14:15:25 -0700439def _get_commit_desc(commit):
440 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700441 if commit == PRE_SUBMIT:
442 return ''
Mike Frysingerb2496652019-09-12 23:35:46 -0400443
444 # {<commit>: <content>}
445 cache = CACHE.get_subcache('get_commit_desc')
446 if commit not in cache:
Mike Frysinger4efdee72019-11-04 10:57:01 -0500447 cache[commit] = _run_command(['git', 'log', '--format=%B',
Mike Frysingerb2496652019-09-12 23:35:46 -0400448 commit + '^!'])
449 return cache[commit]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700450
451
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800452def _check_lines_in_diff(commit, files, check_callable, error_description):
453 """Checks given file for errors via the given check.
454
455 This is a convenience function for common per-line checks. It goes through all
456 files and returns a HookFailure with the error description listing all the
457 failures.
458
459 Args:
460 commit: The commit we're working on.
461 files: The files to check.
462 check_callable: A callable that takes a line and returns True if this line
463 _fails_ the check.
464 error_description: A string describing the error.
465 """
466 errors = []
467 for afile in files:
468 for line_num, line in _get_file_diff(afile, commit):
469 if check_callable(line):
470 errors.append('%s, line %s' % (afile, line_num))
471 if errors:
472 return HookFailure(error_description, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400473 return None
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800474
475
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900476def _parse_common_inclusion_options(options):
477 """Parses common hook options for including/excluding files.
478
479 Args:
480 options: Option string list.
481
482 Returns:
483 (included, excluded) where each one is a list of regex strings.
484 """
485 parser = argparse.ArgumentParser()
486 parser.add_argument('--exclude_regex', action='append')
487 parser.add_argument('--include_regex', action='append')
488 opts = parser.parse_args(options)
489 included = opts.include_regex or []
490 excluded = opts.exclude_regex or []
491 return included, excluded
492
493
Ryan Cuiec4d6332011-05-02 14:15:25 -0700494# Common Hooks
495
Ryan Cui1562fb82011-05-09 11:01:31 -0700496
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900497def _check_no_long_lines(_project, commit, options=()):
Mike Frysinger55f85b52014-12-18 14:45:21 -0500498 """Checks there are no lines longer than MAX_LEN in any of the text files."""
Keigo Oka9732e382019-06-28 17:44:59 +0900499 LONG_LINE_OK_PATHS = [
500 # Go has no line length limit.
501 # https://golang.org/doc/effective_go.html#formatting
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400502 r'.*\.go$',
Mike Frysingerf8961942020-05-15 00:36:31 -0400503 # Python does its own long line checks via pylint.
504 r'.*\.py$',
Keigo Oka9732e382019-06-28 17:44:59 +0900505 ]
Mike Frysinger55f85b52014-12-18 14:45:21 -0500506
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900507 DEFAULT_MAX_LENGTHS = [
508 # Java's line length limit is 100 chars.
509 # https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md
510 (r'.*\.java$', 100),
Mike Frysingerf8961942020-05-15 00:36:31 -0400511 # Rust's line length limit is 100 chars.
512 (r'.*\.rs$', 100),
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900513 ]
514
Ryan Cuiec4d6332011-05-02 14:15:25 -0700515 MAX_LEN = 80
516
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900517 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700518 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900519 included + COMMON_INCLUDED_PATHS,
Keigo Oka9732e382019-06-28 17:44:59 +0900520 excluded + COMMON_EXCLUDED_PATHS + LONG_LINE_OK_PATHS)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700521
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900522 errors = []
Ryan Cuiec4d6332011-05-02 14:15:25 -0700523 for afile in files:
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700524 skip_regexps = (
525 r'https?://',
526 r'^#\s*(define|include|import|pragma|if|ifndef|endif)\b',
527 )
528
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900529 max_len = MAX_LEN
530
531 for expr, length in DEFAULT_MAX_LENGTHS:
532 if re.search(expr, afile):
533 max_len = length
534 break
535
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700536 if os.path.basename(afile).startswith('OWNERS'):
537 # File paths can get long, and there's no way to break them up into
538 # multiple lines.
539 skip_regexps += (
540 r'^include\b',
541 r'file:',
542 )
543
544 skip_regexps = [re.compile(x) for x in skip_regexps]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700545 for line_num, line in _get_file_diff(afile, commit):
546 # Allow certain lines to exceed the maxlen rule.
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900547 if len(line) <= max_len or any(x.search(line) for x in skip_regexps):
Jon Salz98255932012-08-18 14:48:02 +0800548 continue
549
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900550 errors.append('%s, line %s, %s chars, over %s chars' %
551 (afile, line_num, len(line), max_len))
Jon Salz98255932012-08-18 14:48:02 +0800552 if len(errors) == 5: # Just show the first 5 errors.
553 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700554
555 if errors:
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900556 msg = 'Found lines longer than the limit (first 5 shown):'
Ryan Cui1562fb82011-05-09 11:01:31 -0700557 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400558 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700559
Ryan Cuiec4d6332011-05-02 14:15:25 -0700560
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900561def _check_no_stray_whitespace(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700562 """Checks that there is no stray whitespace at source lines end."""
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900563 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700564 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900565 included + COMMON_INCLUDED_PATHS,
566 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800567 return _check_lines_in_diff(commit, files,
568 lambda line: line.rstrip() != line,
569 'Found line ending with white space in:')
Ryan Cui1562fb82011-05-09 11:01:31 -0700570
Ryan Cuiec4d6332011-05-02 14:15:25 -0700571
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900572def _check_no_tabs(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700573 """Checks there are no unexpanded tabs."""
Mike Frysingercd134512017-10-26 04:36:33 -0400574 # Don't add entire repos here. Update the PRESUBMIT.cfg in each repo instead.
575 # We only whitelist known specific filetypes here that show up in all repos.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700576 TAB_OK_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400577 r'.*\.ebuild$',
578 r'.*\.eclass$',
579 r'.*\.go$',
580 r'.*/[M|m]akefile$',
581 r'.*\.mk$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700582 ]
583
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900584 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700585 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900586 included + COMMON_INCLUDED_PATHS,
587 excluded + COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800588 return _check_lines_in_diff(commit, files,
589 lambda line: '\t' in line,
590 'Found a tab character in:')
Ryan Cuiec4d6332011-05-02 14:15:25 -0700591
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800592
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900593def _check_tabbed_indents(_project, commit, options=()):
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800594 """Checks that indents use tabs only."""
595 TABS_REQUIRED_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400596 r'.*\.ebuild$',
597 r'.*\.eclass$',
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800598 ]
599 LEADING_SPACE_RE = re.compile('[\t]* ')
600
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900601 included, excluded = _parse_common_inclusion_options(options)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800602 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900603 included + TABS_REQUIRED_PATHS,
604 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800605 return _check_lines_in_diff(
606 commit, files,
607 lambda line: LEADING_SPACE_RE.match(line) is not None,
608 'Found a space in indentation (must be all tabs):')
Ryan Cui1562fb82011-05-09 11:01:31 -0700609
Ryan Cuiec4d6332011-05-02 14:15:25 -0700610
LaMont Jones872fe762020-02-10 15:36:14 -0700611def _check_gofmt(_project, commit, options=()):
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700612 """Checks that Go files are formatted with gofmt."""
LaMont Jones872fe762020-02-10 15:36:14 -0700613 included, excluded = _parse_common_inclusion_options(options)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700614 errors = []
615 files = _filter_files(_get_affected_files(commit, relative=True),
LaMont Jones872fe762020-02-10 15:36:14 -0700616 included + [r'\.go$'],
617 excluded)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700618
619 for gofile in files:
620 contents = _get_file_content(gofile, commit)
Mike Frysingeraa7dc942019-09-25 00:07:24 -0400621 output = _run_command(cmd=['gofmt', '-l'], input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500622 stderr=subprocess.STDOUT)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700623 if output:
624 errors.append(gofile)
625 if errors:
626 return HookFailure('Files not formatted with gofmt:', errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400627 return None
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700628
629
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600630def _check_rustfmt(_project, commit):
631 """Checks that Rust files are formatted with rustfmt."""
632 errors = []
633 files = _filter_files(_get_affected_files(commit, relative=True),
634 [r'\.rs$'])
635
636 for rustfile in files:
637 contents = _get_file_content(rustfile, commit)
Mike Frysingeraa7dc942019-09-25 00:07:24 -0400638 output = _run_command(cmd=['rustfmt'], input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500639 stderr=subprocess.STDOUT)
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600640 if output != contents:
641 errors.append(rustfile)
642 if errors:
643 return HookFailure('Files not formatted with rustfmt: '
644 "(run 'cargo fmt' to fix)", errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400645 return None
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600646
647
Mike Frysingerae409522014-02-01 03:16:11 -0500648def _check_change_has_test_field(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700649 """Check for a non-empty 'TEST=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500650 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700651
Cheng Yuehb707c522020-01-02 14:06:59 +0800652 if not re.search(TEST_FIELD_RE, _get_commit_desc(commit)):
Mike Frysingered9b2a02019-12-12 18:52:32 -0500653 msg = ('Changelist description needs TEST field (after first line)\n%s' %
654 (SEE_ALSO,))
Ryan Cui1562fb82011-05-09 11:01:31 -0700655 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400656 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700657
Ryan Cuiec4d6332011-05-02 14:15:25 -0700658
Mike Frysingerae409522014-02-01 03:16:11 -0500659def _check_change_has_valid_cq_depend(_project, commit):
Jason D. Clinton299e3222019-05-23 09:42:03 -0600660 """Check for a correctly formatted Cq-Depend field in the commit message."""
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700661 desc = _get_commit_desc(commit)
Jason D. Clinton299e3222019-05-23 09:42:03 -0600662 msg = 'Changelist has invalid Cq-Depend target.'
663 example = 'Example: Cq-Depend: chromium:1234, chrome-internal:2345'
David Jamesc3b68b32013-04-03 09:17:03 -0700664 try:
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700665 patch.GetPaladinDeps(desc)
David Jamesc3b68b32013-04-03 09:17:03 -0700666 except ValueError as ex:
667 return HookFailure(msg, [example, str(ex)])
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700668 # Check that Cq-Depend is in the same paragraph as Change-Id.
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500669 msg = 'Cq-Depend is not in the same paragraph as Change-Id.'
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700670 paragraphs = desc.split('\n\n')
671 for paragraph in paragraphs:
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500672 if (re.search(r'^Cq-Depend:', paragraph, re.M) and not
673 re.search('^Change-Id:', paragraph, re.M)):
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700674 return HookFailure(msg)
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500675
676 # We no longer support CQ-DEPEND= lines.
677 if re.search(r'^CQ-DEPEND[=:]', desc, re.M):
678 return HookFailure(
679 'CQ-DEPEND= is no longer supported. Please see:\n'
680 'https://chromium.googlesource.com/chromiumos/docs/+/HEAD/'
681 'contributing.md#CQ-DEPEND')
682
Mike Frysinger8cf80812019-09-16 23:49:29 -0400683 return None
David Jamesc3b68b32013-04-03 09:17:03 -0700684
685
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800686def _check_change_is_contribution(_project, commit):
687 """Check that the change is a contribution."""
688 NO_CONTRIB = 'not a contribution'
689 if NO_CONTRIB in _get_commit_desc(commit).lower():
690 msg = ('Changelist is not a contribution, this cannot be accepted.\n'
691 'Please remove the "%s" text from the commit message.') % NO_CONTRIB
692 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400693 return None
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800694
695
Alex Deymo643ac4c2015-09-03 10:40:50 -0700696def _check_change_has_bug_field(project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700697 """Check for a correctly formatted 'BUG=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500698 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
699
David James5c0073d2013-04-03 08:48:52 -0700700 OLD_BUG_RE = r'\nBUG=.*chromium-os'
701 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
702 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
703 'the chromium tracker in your BUG= line now.')
704 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700705
Alex Deymo643ac4c2015-09-03 10:40:50 -0700706 # Android internal and external projects use "Bug: " to track bugs in
707 # buganizer.
708 BUG_COLON_REMOTES = (
709 'aosp',
710 'goog',
711 )
712 if project.remote in BUG_COLON_REMOTES:
713 BUG_RE = r'\nBug: ?([Nn]one|\d+)'
714 if not re.search(BUG_RE, _get_commit_desc(commit)):
715 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500716 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700717 'Bug: 9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500718 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700719 return HookFailure(msg)
720 else:
Jorge Lucangeli Obesdce214e2017-10-25 15:04:39 -0400721 BUG_RE = r'\nBUG=([Nn]one|(chromium|b):\d+)'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700722 if not re.search(BUG_RE, _get_commit_desc(commit)):
723 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500724 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700725 'BUG=chromium:9999 (for public tracker)\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700726 'BUG=b:9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500727 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700728 return HookFailure(msg)
Ryan Cui1562fb82011-05-09 11:01:31 -0700729
Cheng Yuehb707c522020-01-02 14:06:59 +0800730 TEST_BEFORE_BUG_RE = TEST_FIELD_RE + r'.*' + BUG_RE
731
732 if re.search(TEST_BEFORE_BUG_RE, _get_commit_desc(commit), re.DOTALL):
733 msg = ('The BUG field must come before the TEST field.\n%s' %
734 (SEE_ALSO,))
735 return HookFailure(msg)
736
Mike Frysinger8cf80812019-09-16 23:49:29 -0400737 return None
738
Ryan Cuiec4d6332011-05-02 14:15:25 -0700739
Jack Neus8edbf642019-07-10 16:08:31 -0600740def _check_change_no_include_oem(project, commit):
741 """Check that the change does not reference OEMs."""
742 ALLOWLIST = {
743 'chromiumos/platform/ec',
744 # Used by unit tests.
745 'project',
746 }
747 if project.name not in ALLOWLIST:
748 return None
749
Mike Frysingerbb34a222019-07-31 14:40:46 -0400750 TAGS = {
Jack Neus8edbf642019-07-10 16:08:31 -0600751 'Reviewed-on',
752 'Reviewed-by',
753 'Signed-off-by',
754 'Commit-Ready',
755 'Tested-by',
756 'Commit-Queue',
Jack Neus8edbf642019-07-10 16:08:31 -0600757 'Acked-by',
758 'Modified-by',
759 'CC',
760 'Suggested-by',
761 'Reported-by',
762 'Acked-for-chrome-by',
LaMont Jones237f3ef2020-01-22 10:40:52 -0700763 'Cq-Cl-Tag',
LaMont Jonesfb5e8bf2020-03-03 12:50:06 -0700764 'Cq-Include-Trybots',
Mike Frysingerbb34a222019-07-31 14:40:46 -0400765 }
Jack Neus8edbf642019-07-10 16:08:31 -0600766
767 # Ignore tags, which could reasonably contain OEM names
768 # (e.g. Reviewed-by: foo@oem.corp-partner.google.com).
Jack Neus8edbf642019-07-10 16:08:31 -0600769 commit_message = ' '.join(
Mike Frysingerbb34a222019-07-31 14:40:46 -0400770 x for x in _get_commit_desc(commit).splitlines()
771 if ':' not in x or x.split(':', 1)[0] not in TAGS)
772
Jack Neus8edbf642019-07-10 16:08:31 -0600773 commit_message = re.sub(r'[\s_-]+', ' ', commit_message)
774
775 # Exercise caution when expanding these lists. Adding a name
776 # could indicate a new relationship with a company!
777 OEMS = ['hp', 'hewlett packard', 'dell', 'lenovo', 'acer', 'asus', 'samsung']
778 ODMS = [
779 'bitland', 'compal', 'haier', 'huaqin', 'inventec', 'lg', 'pegatron',
780 'pegatron(ems)', 'quanta', 'samsung', 'wistron'
781 ]
782
783 for name_type, name_list in [('OEM', OEMS), ('ODM', ODMS)]:
784 # Construct regex
785 name_re = r'\b(%s)\b' % '|'.join([re.escape(x) for x in name_list])
786 matches = [x[0] for x in re.findall(name_re, commit_message, re.IGNORECASE)]
Mike Frysingere52b1bc2019-09-16 23:45:41 -0400787 if matches:
Jack Neus8edbf642019-07-10 16:08:31 -0600788 # If there's a match, throw an error.
789 error_msg = ('Changelist description contains the name of an'
790 ' %s: "%s".' % (name_type, '","'.join(matches)))
791 return HookFailure(error_msg)
792
Mike Frysinger8cf80812019-09-16 23:49:29 -0400793 return None
794
Jack Neus8edbf642019-07-10 16:08:31 -0600795
Mike Frysinger292b45d2014-11-25 01:17:10 -0500796def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -0700797 """Check that we're not missing a revbump of an ebuild in the given commit.
798
799 If the given commit touches files in a directory that has ebuilds somewhere
800 up the directory hierarchy, it's very likely that we need an ebuild revbump
801 in order for those changes to take effect.
802
803 It's not totally trivial to detect a revbump, so at least detect that an
804 ebuild with a revision number in it was touched. This should handle the
805 common case where we use a symlink to do the revbump.
806
807 TODO: it would be nice to enhance this hook to:
808 * Handle cases where people revbump with a slightly different syntax. I see
809 one ebuild (puppy) that revbumps with _pN. This is a false positive.
810 * Catches cases where people aren't using symlinks for revbumps. If they
811 edit a revisioned file directly (and are expected to rename it for revbump)
812 we'll miss that. Perhaps we could detect that the file touched is a
813 symlink?
814
815 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
816 still better off than without this check.
817
818 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700819 project: The Project to look at
Doug Anderson42b8a052013-06-26 10:45:36 -0700820 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -0500821 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -0700822
823 Returns:
824 A HookFailure or None.
825 """
Mike Frysinger011af942014-01-17 16:12:22 -0500826 # If this is the portage-stable overlay, then ignore the check. It's rare
827 # that we're doing anything other than importing files from upstream, so
828 # forcing a rev bump makes no sense.
829 whitelist = (
830 'chromiumos/overlays/portage-stable',
831 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700832 if project.name in whitelist:
Mike Frysinger011af942014-01-17 16:12:22 -0500833 return None
834
Mike Frysinger292b45d2014-11-25 01:17:10 -0500835 def FinalName(obj):
836 # If the file is being deleted, then the dst_file is not set.
837 if obj.dst_file is None:
838 return obj.src_file
839 else:
840 return obj.dst_file
841
842 affected_path_objs = _get_affected_files(
843 commit, include_deletes=True, include_symlinks=True, relative=True,
844 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -0700845
846 # Don't yell about changes to whitelisted files...
Mike Frysinger550c05c2019-12-09 18:16:36 -0500847 whitelist = {'ChangeLog', 'Manifest', 'metadata.xml'}
Mike Frysinger292b45d2014-11-25 01:17:10 -0500848 affected_path_objs = [x for x in affected_path_objs
849 if os.path.basename(FinalName(x)) not in whitelist]
850 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -0700851 return None
852
853 # If we've touched any file named with a -rN.ebuild then we'll say we're
854 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500855 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
856 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700857 if touched_revved_ebuild:
858 return None
859
Mike Frysinger292b45d2014-11-25 01:17:10 -0500860 # If we're creating new ebuilds from scratch, then we don't need an uprev.
861 # Find all the dirs that new ebuilds and ignore their files/.
862 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
863 if FinalName(x).endswith('.ebuild') and x.status == 'A']
864 affected_path_objs = [obj for obj in affected_path_objs
865 if not any(FinalName(obj).startswith(x)
866 for x in ebuild_dirs)]
867 if not affected_path_objs:
Mike Frysinger8cf80812019-09-16 23:49:29 -0400868 return None
Mike Frysinger292b45d2014-11-25 01:17:10 -0500869
Doug Anderson42b8a052013-06-26 10:45:36 -0700870 # We want to examine the current contents of all directories that are parents
871 # of files that were touched (up to the top of the project).
872 #
873 # ...note: we use the current directory contents even though it may have
874 # changed since the commit we're looking at. This is just a heuristic after
875 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500876 if project_top is None:
877 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -0700878 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -0500879 for obj in affected_path_objs:
880 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -0700881 while os.path.exists(path) and not os.path.samefile(path, project_top):
882 dirs_to_check.add(path)
883 path = os.path.dirname(path)
884
885 # Look through each directory. If it's got an ebuild in it then we'll
886 # consider this as a case when we need a revbump.
Gwendal Grignoua3086c32014-12-09 11:17:22 -0800887 affected_paths = set(os.path.join(project_top, FinalName(x))
888 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700889 for dir_path in dirs_to_check:
890 contents = os.listdir(dir_path)
891 ebuilds = [os.path.join(dir_path, path)
892 for path in contents if path.endswith('.ebuild')]
893 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
894
C Shapiroae157ae2017-09-18 16:24:03 -0600895 affected_paths_under_9999_ebuilds = set()
896 for affected_path in affected_paths:
897 for ebuild_9999 in ebuilds_9999:
898 ebuild_dir = os.path.dirname(ebuild_9999)
899 if affected_path.startswith(ebuild_dir):
900 affected_paths_under_9999_ebuilds.add(affected_path)
901
902 # If every file changed exists under a 9999 ebuild, then skip
903 if len(affected_paths_under_9999_ebuilds) == len(affected_paths):
904 continue
905
Doug Anderson42b8a052013-06-26 10:45:36 -0700906 # If the -9999.ebuild file was touched the bot will uprev for us.
907 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -0500908 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -0700909 continue
910
911 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500912 return HookFailure('Changelist probably needs a revbump of an ebuild, '
913 'or a -r1.ebuild symlink if this is a new ebuild:\n'
914 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -0700915
916 return None
917
918
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500919def _check_ebuild_eapi(project, commit):
Mike Frysinger948284a2018-02-01 15:22:56 -0500920 """Make sure we have people use EAPI=5 or newer with custom ebuilds.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500921
922 We want to get away from older EAPI's as it makes life confusing and they
923 have less builtin error checking.
924
925 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700926 project: The Project to look at
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500927 commit: The commit to look at
928
929 Returns:
930 A HookFailure or None.
931 """
932 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500933 # that we're doing anything other than importing files from upstream, and
934 # we shouldn't be rewriting things fundamentally anyways.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500935 whitelist = (
936 'chromiumos/overlays/portage-stable',
937 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700938 if project.name in whitelist:
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500939 return None
940
Mike Frysinger948284a2018-02-01 15:22:56 -0500941 BAD_EAPIS = ('0', '1', '2', '3', '4')
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500942
943 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
944
945 ebuilds_re = [r'\.ebuild$']
946 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
947 ebuilds_re)
948 bad_ebuilds = []
949
950 for ebuild in ebuilds:
951 # If the ebuild does not specify an EAPI, it defaults to 0.
952 eapi = '0'
953
954 lines = _get_file_content(ebuild, commit).splitlines()
955 if len(lines) == 1:
956 # This is most likely a symlink, so skip it entirely.
957 continue
958
959 for line in lines:
960 m = get_eapi.match(line)
961 if m:
962 # Once we hit the first EAPI line in this ebuild, stop processing.
963 # The spec requires that there only be one and it be first, so
964 # checking all possible values is pointless. We also assume that
965 # it's "the" EAPI line and not something in the middle of a heredoc.
966 eapi = m.group(1)
967 break
968
969 if eapi in BAD_EAPIS:
970 bad_ebuilds.append((ebuild, eapi))
971
972 if bad_ebuilds:
973 # pylint: disable=C0301
Mike Frysingerc6114f42020-05-15 00:55:05 -0400974 url = 'https://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500975 # pylint: enable=C0301
976 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500977 'These ebuilds are using old EAPIs. If these are imported from\n'
978 'Gentoo, then you may ignore and upload once with the --no-verify\n'
Mike Frysingerc6114f42020-05-15 00:55:05 -0400979 'flag. Otherwise, please update to 7 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500980 '\t%s\n'
981 'See this guide for more details:\n%s\n' %
982 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
983
Mike Frysinger8cf80812019-09-16 23:49:29 -0400984 return None
985
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500986
Mike Frysinger89bdb852014-02-01 05:26:26 -0500987def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -0500988 """Make sure we use the new style KEYWORDS when possible in ebuilds.
989
990 If an ebuild generally does not care about the arch it is running on, then
991 ebuilds should flag it with one of:
992 KEYWORDS="*" # A stable ebuild.
993 KEYWORDS="~*" # An unstable ebuild.
994 KEYWORDS="-* ..." # Is known to only work on specific arches.
995
996 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700997 project: The Project to look at
Mike Frysingerc51ece72014-01-17 16:23:40 -0500998 commit: The commit to look at
999
1000 Returns:
1001 A HookFailure or None.
1002 """
1003 WHITELIST = set(('*', '-*', '~*'))
1004
1005 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
1006
Mike Frysinger89bdb852014-02-01 05:26:26 -05001007 ebuilds_re = [r'\.ebuild$']
1008 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1009 ebuilds_re)
1010
Mike Frysinger8d42d742014-09-22 15:50:21 -04001011 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -05001012 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -04001013 # We get the full content rather than a diff as the latter does not work
1014 # on new files (like when adding new ebuilds).
1015 lines = _get_file_content(ebuild, commit).splitlines()
1016 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -05001017 m = get_keywords.match(line)
1018 if m:
1019 keywords = set(m.group(1).split())
1020 if not keywords or WHITELIST - keywords != WHITELIST:
1021 continue
1022
Mike Frysinger8d42d742014-09-22 15:50:21 -04001023 bad_ebuilds.append(ebuild)
1024
1025 if bad_ebuilds:
1026 return HookFailure(
1027 '%s\n'
1028 'Please update KEYWORDS to use a glob:\n'
1029 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
1030 ' KEYWORDS="*"\n'
1031 'If the ebuild should be marked unstable (normal for '
1032 'cros-workon / 9999 ebuilds):\n'
1033 ' KEYWORDS="~*"\n'
Mike Frysingerde8efea2015-05-17 03:42:26 -04001034 'If the ebuild needs to be marked for only specific arches, '
Mike Frysinger8d42d742014-09-22 15:50:21 -04001035 'then use -* like so:\n'
1036 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -05001037
Mike Frysinger8cf80812019-09-16 23:49:29 -04001038 return None
1039
Mike Frysingerc51ece72014-01-17 16:23:40 -05001040
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001041def _check_ebuild_licenses(_project, commit):
1042 """Check if the LICENSE field in the ebuild is correct."""
Brian Norris7a610e82016-02-17 12:24:54 -08001043 affected_paths = _get_affected_files(commit, relative=True)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001044 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
1045
1046 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -08001047 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001048
1049 for ebuild in touched_ebuilds:
1050 # Skip virutal packages.
1051 if ebuild.split('/')[-3] == 'virtual':
1052 continue
1053
Alex Kleinb5953522018-08-03 11:44:21 -06001054 # e.g. path/to/overlay/category/package/package.ebuild -> path/to/overlay
1055 overlay_path = os.sep.join(ebuild.split(os.sep)[:-3])
1056
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001057 try:
Brian Norris7a610e82016-02-17 12:24:54 -08001058 ebuild_content = _get_file_content(ebuild, commit)
Alex Kleinb5953522018-08-03 11:44:21 -06001059 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content,
1060 overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001061 except ValueError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001062 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001063
1064 # Also ignore licenses ending with '?'
1065 for license_type in [x for x in license_types
1066 if x not in LICENSES_IGNORE and not x.endswith('?')]:
1067 try:
Alex Kleinb5953522018-08-03 11:44:21 -06001068 licenses_lib.Licensing.FindLicenseType(license_type,
1069 overlay_path=overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001070 except AssertionError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001071 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001072
Mike Frysinger8cf80812019-09-16 23:49:29 -04001073 return None
1074
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001075
Mike Frysingercd363c82014-02-01 05:20:18 -05001076def _check_ebuild_virtual_pv(project, commit):
1077 """Enforce the virtual PV policies."""
1078 # If this is the portage-stable overlay, then ignore the check.
1079 # We want to import virtuals as-is from upstream Gentoo.
1080 whitelist = (
1081 'chromiumos/overlays/portage-stable',
1082 )
Alex Deymo643ac4c2015-09-03 10:40:50 -07001083 if project.name in whitelist:
Mike Frysingercd363c82014-02-01 05:20:18 -05001084 return None
1085
1086 # We assume the repo name is the same as the dir name on disk.
1087 # It would be dumb to not have them match though.
Alex Deymo643ac4c2015-09-03 10:40:50 -07001088 project_base = os.path.basename(project.name)
Mike Frysingercd363c82014-02-01 05:20:18 -05001089
1090 is_variant = lambda x: x.startswith('overlay-variant-')
1091 is_board = lambda x: x.startswith('overlay-')
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001092 is_baseboard = lambda x: x.startswith('baseboard-')
1093 is_chipset = lambda x: x.startswith('chipset-')
1094 is_project = lambda x: x.startswith('project-')
Mike Frysingercd363c82014-02-01 05:20:18 -05001095 is_private = lambda x: x.endswith('-private')
1096
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001097 is_special_overlay = lambda x: (is_board(x) or is_chipset(x) or
1098 is_baseboard(x) or is_project(x))
1099
Mike Frysingercd363c82014-02-01 05:20:18 -05001100 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
1101
1102 ebuilds_re = [r'\.ebuild$']
1103 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1104 ebuilds_re)
1105 bad_ebuilds = []
1106
1107 for ebuild in ebuilds:
1108 m = get_pv.match(ebuild)
1109 if m:
1110 overlay = m.group(1)
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001111 if not overlay or not is_special_overlay(overlay):
Alex Deymo643ac4c2015-09-03 10:40:50 -07001112 overlay = project_base
Mike Frysingercd363c82014-02-01 05:20:18 -05001113
1114 pv = m.group(3).split('-', 1)[0]
1115
Bernie Thompsone5ee1822016-01-12 14:22:23 -08001116 # Virtual versions >= 4 are special cases used above the standard
1117 # versioning structure, e.g. if one has a board inheriting a board.
1118 if float(pv) >= 4:
1119 want_pv = pv
Mike Frysingercd363c82014-02-01 05:20:18 -05001120 elif is_board(overlay):
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001121 if is_private(overlay):
1122 want_pv = '3.5' if is_variant(overlay) else '3'
1123 elif is_board(overlay):
1124 want_pv = '2.5' if is_variant(overlay) else '2'
1125 elif is_baseboard(overlay):
1126 want_pv = '1.9'
1127 elif is_chipset(overlay):
1128 want_pv = '1.8'
1129 elif is_project(overlay):
1130 want_pv = '1.7' if is_private(overlay) else '1.5'
Mike Frysingercd363c82014-02-01 05:20:18 -05001131 else:
1132 want_pv = '1'
1133
1134 if pv != want_pv:
1135 bad_ebuilds.append((ebuild, pv, want_pv))
1136
1137 if bad_ebuilds:
1138 # pylint: disable=C0301
1139 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
1140 # pylint: enable=C0301
1141 return HookFailure(
1142 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
1143 '\t%s\n'
1144 'If this is an upstream Gentoo virtual, then you may ignore this\n'
1145 'check (and re-run w/--no-verify). Otherwise, please see this\n'
1146 'page for more details:\n%s\n' %
1147 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
1148 for x in bad_ebuilds]), url))
1149
Mike Frysinger8cf80812019-09-16 23:49:29 -04001150 return None
1151
Mike Frysingercd363c82014-02-01 05:20:18 -05001152
Daniel Erat9d203ff2015-02-17 10:12:21 -07001153def _check_portage_make_use_var(_project, commit):
1154 """Verify that $USE is set correctly in make.conf and make.defaults."""
1155 files = _filter_files(_get_affected_files(commit, relative=True),
1156 [r'(^|/)make.(conf|defaults)$'])
1157
1158 errors = []
1159 for path in files:
1160 basename = os.path.basename(path)
1161
1162 # Has a USE= line already been encountered in this file?
1163 saw_use = False
1164
1165 for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1):
1166 if not line.startswith('USE='):
1167 continue
1168
1169 preserves_use = '${USE}' in line or '$USE' in line
1170
1171 if (basename == 'make.conf' or
1172 (basename == 'make.defaults' and saw_use)) and not preserves_use:
1173 errors.append('%s:%d: missing ${USE}' % (path, i))
1174 elif basename == 'make.defaults' and not saw_use and preserves_use:
1175 errors.append('%s:%d: ${USE} referenced in initial declaration' %
1176 (path, i))
1177
1178 saw_use = True
1179
1180 if errors:
1181 return HookFailure(
1182 'One or more Portage make files appear to set USE incorrectly.\n'
1183 '\n'
1184 'All USE assignments in make.conf and all assignments after the\n'
1185 'initial declaration in make.defaults should contain "${USE}" to\n'
1186 'preserve previously-set flags.\n'
1187 '\n'
1188 'The initial USE declaration in make.defaults should not contain\n'
1189 '"${USE}".\n',
1190 errors)
1191
Mike Frysinger8cf80812019-09-16 23:49:29 -04001192 return None
1193
Daniel Erat9d203ff2015-02-17 10:12:21 -07001194
Mike Frysingerae409522014-02-01 03:16:11 -05001195def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001196 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001197 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001198 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001199 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001200 if not m:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001201 return HookFailure('Last paragraph of description must include Change-Id.')
Ryan Cui1562fb82011-05-09 11:01:31 -07001202
LaMont Jonesfb5e8bf2020-03-03 12:50:06 -07001203 # S-o-b and some other tags always allowed to follow Change-ID in the footer.
1204 allowed_tags = ['Signed-off-by', 'Cq-Cl-Tag', 'Cq-Include-Trybots']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001205
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001206 end = desc[m.end():].strip().splitlines()
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001207 cherry_pick_marker = 'cherry picked from commit'
1208
1209 if end and cherry_pick_marker in end[-1]:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001210 # Cherry picked patches allow more tags in the last paragraph.
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001211 allowed_tags += ['Commit-Queue', 'Commit-Ready', 'Reviewed-by',
1212 'Reviewed-on', 'Tested-by']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001213 end = end[:-1]
1214
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001215 # Note that descriptions could have multiple cherry pick markers.
1216 tag_search = r'^(%s:|\(%s) ' % (':|'.join(allowed_tags), cherry_pick_marker)
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001217
1218 if [x for x in end if not re.search(tag_search, x)]:
1219 return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' %
1220 ':", "'.join(allowed_tags))
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001221
Mike Frysinger8cf80812019-09-16 23:49:29 -04001222 return None
1223
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001224
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001225def _check_commit_message_style(_project, commit):
1226 """Verify that the commit message matches our style.
1227
1228 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
1229 commit hooks.
1230 """
Mike Frysingered9b2a02019-12-12 18:52:32 -05001231 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Mike Frysinger4efdee72019-11-04 10:57:01 -05001232
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001233 desc = _get_commit_desc(commit)
1234
1235 # The first line should be by itself.
1236 lines = desc.splitlines()
1237 if len(lines) > 1 and lines[1]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001238 return HookFailure('The second line of the commit message must be blank.'
1239 '\n%s' % (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001240
1241 # The first line should be one sentence.
1242 if '. ' in lines[0]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001243 return HookFailure('The first line cannot be more than one sentence.\n%s' %
1244 (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001245
1246 # The first line cannot be too long.
1247 MAX_FIRST_LINE_LEN = 100
1248 if len(lines[0]) > MAX_FIRST_LINE_LEN:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001249 return HookFailure('The first line must be less than %i chars.\n%s' %
1250 (MAX_FIRST_LINE_LEN, SEE_ALSO))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001251
Mike Frysinger8cf80812019-09-16 23:49:29 -04001252 return None
1253
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001254
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001255def _check_cros_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001256 """Verifies the Chromium OS license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -07001257
Mike Frysinger98638102014-08-28 00:15:08 -04001258 Should be following the spec:
1259 http://dev.chromium.org/developers/coding-style#TOC-File-headers
1260 """
1261 # For older years, be a bit more flexible as our policy says leave them be.
1262 LICENSE_HEADER = (
Keigo Oka7e880ac2019-07-03 15:03:43 +09001263 r'.*Copyright(?: \(c\))? (20[0-9]{2})(?:-20[0-9]{2})? The Chromium OS '
1264 r'Authors\. All rights reserved\.\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001265 r'.*Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001266 r'be\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001267 r'.*found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -05001268 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001269 )
1270 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1271
1272 # For newer years, be stricter.
Keigo Oka7e880ac2019-07-03 15:03:43 +09001273 BAD_COPYRIGHT_LINE = (
Brian Norris68838dd2018-09-26 18:30:24 -07001274 r'.*Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001275 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001276 )
Keigo Oka7e880ac2019-07-03 15:03:43 +09001277 bad_copyright_re = re.compile(BAD_COPYRIGHT_LINE)
Mike Frysinger98638102014-08-28 00:15:08 -04001278
Shuhei Takahashiabc20f32017-07-10 19:35:45 +09001279 included, excluded = _parse_common_inclusion_options(options)
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001280
Mike Frysinger98638102014-08-28 00:15:08 -04001281 bad_files = []
1282 bad_copyright_files = []
Keigo Oka7e880ac2019-07-03 15:03:43 +09001283 bad_year_files = []
1284
Ken Turnerd07564b2018-02-08 17:57:59 +11001285 files = _filter_files(
1286 _get_affected_files(commit, relative=True),
1287 included + COMMON_INCLUDED_PATHS,
1288 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001289 existing_files = set(_get_affected_files(commit, relative=True,
1290 include_adds=False))
Mike Frysinger98638102014-08-28 00:15:08 -04001291
Keigo Oka7e880ac2019-07-03 15:03:43 +09001292 current_year = str(datetime.datetime.now().year)
Mike Frysinger98638102014-08-28 00:15:08 -04001293 for f in files:
1294 contents = _get_file_content(f, commit)
1295 if not contents:
1296 # Ignore empty files.
1297 continue
1298
Keigo Oka7e880ac2019-07-03 15:03:43 +09001299 m = license_re.search(contents)
1300 if not m:
Mike Frysinger98638102014-08-28 00:15:08 -04001301 bad_files.append(f)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001302 elif bad_copyright_re.search(contents):
Mike Frysinger98638102014-08-28 00:15:08 -04001303 bad_copyright_files.append(f)
1304
Keigo Oka7e880ac2019-07-03 15:03:43 +09001305 if m and f not in existing_files:
1306 year = m.group(1)
1307 if year != current_year:
1308 bad_year_files.append(f)
1309
1310 errors = []
Mike Frysinger98638102014-08-28 00:15:08 -04001311 if bad_files:
1312 msg = '%s:\n%s\n%s' % (
1313 'License must match', license_re.pattern,
1314 'Found a bad header in these files:')
Keigo Oka7e880ac2019-07-03 15:03:43 +09001315 errors.append(HookFailure(msg, bad_files))
Mike Frysinger98638102014-08-28 00:15:08 -04001316 if bad_copyright_files:
1317 msg = 'Do not use (c) in copyright headers in new files:'
Keigo Oka7e880ac2019-07-03 15:03:43 +09001318 errors.append(HookFailure(msg, bad_copyright_files))
1319 if bad_year_files:
1320 msg = 'Use current year (%s) in copyright headers in new files:' % (
1321 current_year)
1322 errors.append(HookFailure(msg, bad_year_files))
Ryan Cuiec4d6332011-05-02 14:15:25 -07001323
Keigo Oka7e880ac2019-07-03 15:03:43 +09001324 return errors
Ryan Cuiec4d6332011-05-02 14:15:25 -07001325
Mike Frysinger8cf80812019-09-16 23:49:29 -04001326
Amin Hassani391efa92018-01-26 17:58:05 -08001327def _check_aosp_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001328 """Verifies the AOSP license/copyright header.
1329
1330 AOSP uses the Apache2 License:
1331 https://source.android.com/source/licenses.html
1332 """
1333 LICENSE_HEADER = (
1334 r"""^[#/\*]*
1335[#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project
1336[#/\*]* ?
1337[#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\);
1338[#/\*]* ?you may not use this file except in compliance with the License\.
1339[#/\*]* ?You may obtain a copy of the License at
1340[#/\*]* ?
1341[#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0
1342[#/\*]* ?
1343[#/\*]* ?Unless required by applicable law or agreed to in writing, software
1344[#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS,
1345[#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """
1346 r"""implied\.
1347[#/\*]* ?See the License for the specific language governing permissions and
1348[#/\*]* ?limitations under the License\.
1349[#/\*]*$
1350"""
1351 )
1352 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1353
Amin Hassani391efa92018-01-26 17:58:05 -08001354 included, excluded = _parse_common_inclusion_options(options)
1355
Ken Turnerd07564b2018-02-08 17:57:59 +11001356 files = _filter_files(
1357 _get_affected_files(commit, relative=True),
1358 included + COMMON_INCLUDED_PATHS,
1359 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Alex Deymof5792ce2015-08-24 22:50:08 -07001360
1361 bad_files = []
1362 for f in files:
1363 contents = _get_file_content(f, commit)
1364 if not contents:
1365 # Ignore empty files.
1366 continue
1367
1368 if not license_re.search(contents):
1369 bad_files.append(f)
1370
1371 if bad_files:
1372 msg = ('License must match:\n%s\nFound a bad header in these files:' %
1373 license_re.pattern)
1374 return HookFailure(msg, bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001375 return None
Alex Deymof5792ce2015-08-24 22:50:08 -07001376
1377
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001378def _check_layout_conf(_project, commit):
1379 """Verifies the metadata/layout.conf file."""
1380 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001381 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001382 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001383 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001384
Mike Frysinger94a670c2014-09-19 12:46:26 -04001385 # Handle multiple overlays in a single commit (like the public tree).
1386 for f in _get_affected_files(commit, relative=True):
1387 if f.endswith(repo_name):
1388 repo_names.append(f)
1389 elif f.endswith(layout_path):
1390 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001391
1392 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -04001393 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001394 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -04001395 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001396
Mike Frysinger94a670c2014-09-19 12:46:26 -04001397 # Gather all the errors in one pass so we show one full message.
1398 all_errors = {}
1399 for layout_path in layout_paths:
1400 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001401
Mike Frysinger94a670c2014-09-19 12:46:26 -04001402 # Make sure the config file is sorted.
1403 data = [x for x in _get_file_content(layout_path, commit).splitlines()
1404 if x and x[0] != '#']
1405 if sorted(data) != data:
1406 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001407
Mike Frysinger94a670c2014-09-19 12:46:26 -04001408 # Require people to set specific values all the time.
1409 settings = (
1410 # TODO: Enable this for everyone. http://crbug.com/408038
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001411 # ('fast caching', 'cache-format = md5-dict'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001412 ('fast manifests', 'thin-manifests = true'),
Mike Frysingerd7734522015-02-26 16:12:43 -05001413 ('extra features', 'profile-formats = portage-2 profile-default-eapi'),
1414 ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001415 )
1416 for reason, line in settings:
1417 if line not in data:
1418 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001419
Mike Frysinger94a670c2014-09-19 12:46:26 -04001420 # Require one of these settings.
Mike Frysinger5fae62d2015-11-11 20:12:15 -05001421 if 'use-manifests = strict' not in data:
1422 errors += ['enable file checking with: use-manifests = strict']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001423
Mike Frysinger94a670c2014-09-19 12:46:26 -04001424 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -04001425 for line in data:
1426 if line.startswith('repo-name = '):
1427 break
1428 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -04001429 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001430
Mike Frysinger94a670c2014-09-19 12:46:26 -04001431 # Summarize all the errors we saw (if any).
1432 lines = ''
1433 for layout_path, errors in all_errors.items():
1434 if errors:
1435 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
1436 if lines:
1437 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
1438 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001439
Mike Frysinger8cf80812019-09-16 23:49:29 -04001440 return None
1441
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001442
Keigo Oka4a09bd92019-05-07 14:01:00 +09001443def _check_no_new_gyp(_project, commit):
1444 """Verifies no project starts to use GYP."""
1445 whitelist = [
Keigo Oka4a09bd92019-05-07 14:01:00 +09001446 'chromeos/ap',
1447 'chromeos/ap-daemons',
Keigo Oka150a6fd2019-06-04 11:30:25 +09001448 'chromeos/ap/security',
1449 'chromeos/ap/wireless',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001450 'chromeos/platform/actions',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001451 'chromeos/platform/drivefs-google3',
1452 'chromeos/platform/experimental-touch-fw',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001453 'chromeos/thermald',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001454 'chromiumos/platform2',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001455 'weave/libweave',
1456 ]
1457 if _project.name in whitelist:
1458 return None
1459
1460 gypfiles = _filter_files(
1461 _get_affected_files(commit, include_symlinks=True, relative=True),
1462 [r'\.gyp$'])
1463
1464 if gypfiles:
1465 return HookFailure('GYP is deprecated and not allowed in a new project:',
1466 gypfiles)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001467 return None
Keigo Oka4a09bd92019-05-07 14:01:00 +09001468
1469
Ryan Cuiec4d6332011-05-02 14:15:25 -07001470# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001471
Ryan Cui1562fb82011-05-09 11:01:31 -07001472
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001473def _check_clang_format(_project, commit, options=()):
1474 """Runs clang-format on the given project"""
1475 hooks_dir = _get_hooks_dir()
1476 options = list(options)
1477 if commit == PRE_SUBMIT:
1478 options.append('--commit=HEAD')
1479 else:
1480 options.extend(['--commit', commit])
Brian Norris0c62a142018-12-11 13:24:29 -08001481 cmd = [os.path.join(hooks_dir, 'clang-format.py')] + options
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001482 cmd_result = cros_build_lib.run(cmd,
1483 print_cmd=False,
1484 stdout=True,
1485 encoding='utf-8',
1486 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001487 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001488 check=False)
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001489 if cmd_result.returncode:
1490 return HookFailure('clang-format.py errors/warnings\n\n' +
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001491 cmd_result.stdout)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001492 return None
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001493
1494
Mike Frysingerae409522014-02-01 03:16:11 -05001495def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001496 """Runs checkpatch.pl on the given project"""
1497 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001498 options = list(options)
1499 if commit == PRE_SUBMIT:
1500 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
1501 # this case.
1502 options.append('--ignore=MISSING_SIGN_OFF')
Filipe Brandenburger28d48d62015-10-07 09:48:54 -07001503 # Always ignore the check for the MAINTAINERS file. We do not track that
1504 # information on that file in our source trees, so let's suppress the
1505 # warning.
1506 options.append('--ignore=FILE_PATH_CHANGES')
Filipe Brandenburgerce978322015-10-09 10:04:15 -07001507 # Do not complain about the Change-Id: fields, since we use Gerrit.
1508 # Upstream does not want those lines (since they do not use Gerrit), but
1509 # we always do, so disable the check globally.
Daisuke Nojiri4844f892015-10-08 09:54:33 -07001510 options.append('--ignore=GERRIT_CHANGE_ID')
Brian Norris0c62a142018-12-11 13:24:29 -08001511 cmd = [os.path.join(hooks_dir, 'checkpatch.pl')] + options + ['-']
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001512 cmd_result = cros_build_lib.run(
1513 cmd, print_cmd=False, input=_get_patch(commit).encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001514 stdout=True, stderr=subprocess.STDOUT, check=False, encoding='utf-8',
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001515 errors='replace')
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001516 if cmd_result.returncode:
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001517 return HookFailure('checkpatch.pl errors/warnings\n\n' + cmd_result.stdout)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001518 return None
Ryan Cuiec4d6332011-05-02 14:15:25 -07001519
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001520
Brian Norris23c62e92018-11-14 12:25:51 -08001521def _run_kerneldoc(_project, commit, options=()):
1522 """Runs kernel-doc validator on the given project"""
1523 included, excluded = _parse_common_inclusion_options(options)
1524 files = _filter_files(_get_affected_files(commit, relative=True),
1525 included, excluded)
1526 if files:
1527 hooks_dir = _get_hooks_dir()
Brian Norris0c62a142018-12-11 13:24:29 -08001528 cmd = [os.path.join(hooks_dir, 'kernel-doc'), '-none'] + files
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001529 output = _run_command(cmd, stderr=subprocess.STDOUT)
Brian Norris23c62e92018-11-14 12:25:51 -08001530 if output:
Brian Norris0c62a142018-12-11 13:24:29 -08001531 return HookFailure('kernel-doc errors/warnings:',
1532 items=output.splitlines())
Mike Frysinger8cf80812019-09-16 23:49:29 -04001533 return None
Brian Norris23c62e92018-11-14 12:25:51 -08001534
1535
Mike Frysingerae409522014-02-01 03:16:11 -05001536def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -07001537 """Makes sure kernel config changes are not mixed with code changes"""
1538 files = _get_affected_files(commit)
Mike Frysingerf252cfc2019-12-09 17:34:28 -05001539 if len(_filter_files(files, [r'chromeos/config'])) not in [0, len(files)]:
Olof Johanssona96810f2012-09-04 16:20:03 -07001540 return HookFailure('Changes to chromeos/config/ and regular files must '
1541 'be in separate commits:\n%s' % '\n'.join(files))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001542 return None
Anton Staaf815d6852011-08-22 10:08:45 -07001543
Mike Frysingerae409522014-02-01 03:16:11 -05001544
1545def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -07001546 """Checks that all JSON files are syntactically valid."""
Mike Frysinger908be682018-01-04 02:21:50 -05001547 ret = []
1548
1549 files = _filter_files(_get_affected_files(commit, relative=True),
1550 [r'.*\.json$'])
1551 for f in files:
1552 data = _get_file_content(f, commit)
Dale Curtis2975c432011-05-03 17:25:20 -07001553 try:
Mike Frysinger908be682018-01-04 02:21:50 -05001554 json.loads(data)
1555 except Exception as e:
1556 ret.append('%s: Invalid JSON: %s' % (f, e))
1557
1558 if ret:
1559 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001560 return None
Dale Curtis2975c432011-05-03 17:25:20 -07001561
1562
Mike Frysingerae409522014-02-01 03:16:11 -05001563def _check_manifests(_project, commit):
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001564 """Make sure Manifest files only have comments & DIST lines."""
1565 ret = []
Mike Frysinger52b537e2013-08-22 22:59:53 -04001566
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001567 manifests = _filter_files(_get_affected_files(commit, relative=True),
1568 [r'.*/Manifest$'])
1569 for path in manifests:
1570 data = _get_file_content(path, commit)
1571
1572 # Disallow blank files.
1573 if not data.strip():
1574 ret.append('%s: delete empty file' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001575 continue
1576
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001577 # Make sure the last newline isn't omitted.
1578 if data[-1] != '\n':
1579 ret.append('%s: missing trailing newline' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001580
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001581 # Do not allow leading or trailing blank lines.
1582 lines = data.splitlines()
1583 if not lines[0]:
1584 ret.append('%s: delete leading blank lines' % (path,))
1585 if not lines[-1]:
1586 ret.append('%s: delete trailing blank lines' % (path,))
1587
1588 for line in lines:
1589 # Disallow leading/trailing whitespace.
1590 if line != line.strip():
1591 ret.append('%s: remove leading/trailing whitespace: %s' % (path, line))
1592
1593 # Allow blank lines & comments.
1594 line = line.split('#', 1)[0]
1595 if not line:
1596 continue
1597
1598 # All other linse should start with DIST.
1599 if not line.startswith('DIST '):
1600 ret.append('%s: remove non-DIST lines: %s' % (path, line))
1601 break
1602
1603 if ret:
1604 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001605 return None
Mike Frysinger52b537e2013-08-22 22:59:53 -04001606
1607
Mike Frysingerae409522014-02-01 03:16:11 -05001608def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001609 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001610 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001611 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001612 BRANCH_RE = r'\nBRANCH=\S+'
1613
1614 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
1615 msg = ('Changelist description needs BRANCH field (after first line)\n'
1616 'E.g. BRANCH=none or BRANCH=link,snow')
1617 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001618 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001619
1620
Mike Frysinger45334bd2019-11-04 10:42:33 -05001621def _check_change_has_no_branch_field(_project, commit):
1622 """Verify 'BRANCH=' field does not exist in the commit message."""
1623 if commit == PRE_SUBMIT:
1624 return None
1625 BRANCH_RE = r'\nBRANCH=\S+'
1626
1627 if re.search(BRANCH_RE, _get_commit_desc(commit)):
1628 msg = 'This checkout does not use BRANCH= fields. Delete them.'
1629 return HookFailure(msg)
1630 return None
1631
1632
Mike Frysingerae409522014-02-01 03:16:11 -05001633def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001634 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001635 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001636 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001637 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1638
1639 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1640 msg = ('Changelist description needs Signed-off-by: field\n'
1641 'E.g. Signed-off-by: My Name <me@chromium.org>')
1642 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001643 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001644
1645
Mike Frysinger9ab64b12019-11-04 10:53:08 -05001646def _check_change_has_no_signoff_field(_project, commit):
1647 """Verify 'Signed-off-by:' field does not exist in the commit message."""
1648 if commit == PRE_SUBMIT:
1649 return None
1650 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1651
1652 if re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1653 msg = 'This checkout does not use Signed-off-by: tags. Delete them.'
1654 return HookFailure(msg)
1655 return None
1656
1657
Jon Salz3ee59de2012-08-18 13:54:22 +08001658def _run_project_hook_script(script, project, commit):
1659 """Runs a project hook script.
1660
1661 The script is run with the following environment variables set:
1662 PRESUBMIT_PROJECT: The affected project
1663 PRESUBMIT_COMMIT: The affected commit
1664 PRESUBMIT_FILES: A newline-separated list of affected files
1665
1666 The script is considered to fail if the exit code is non-zero. It should
1667 write an error message to stdout.
1668 """
1669 env = dict(os.environ)
Alex Deymo643ac4c2015-09-03 10:40:50 -07001670 env['PRESUBMIT_PROJECT'] = project.name
Jon Salz3ee59de2012-08-18 13:54:22 +08001671 env['PRESUBMIT_COMMIT'] = commit
1672
1673 # Put affected files in an environment variable
1674 files = _get_affected_files(commit)
1675 env['PRESUBMIT_FILES'] = '\n'.join(files)
1676
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001677 cmd_result = cros_build_lib.run(cmd=script,
1678 env=env,
1679 shell=True,
1680 print_cmd=False,
1681 input=os.devnull,
1682 stdout=True,
1683 encoding='utf-8',
1684 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001685 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001686 check=False)
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001687 if cmd_result.returncode:
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001688 stdout = cmd_result.stdout
Jon Salz7b618af2012-08-31 06:03:16 +08001689 if stdout:
1690 stdout = re.sub('(?m)^', ' ', stdout)
1691 return HookFailure('Hook script "%s" failed with code %d%s' %
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001692 (script, cmd_result.returncode,
Jon Salz3ee59de2012-08-18 13:54:22 +08001693 ':\n' + stdout if stdout else ''))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001694 return None
Jon Salz3ee59de2012-08-18 13:54:22 +08001695
1696
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001697def _check_project_prefix(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -05001698 """Require the commit message have a project specific prefix as needed."""
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001699
Brian Norris77608e12018-04-06 10:38:43 -07001700 files = _get_affected_files(commit, include_deletes=True, relative=True)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001701 prefix = os.path.commonprefix(files)
1702 prefix = os.path.dirname(prefix)
1703
1704 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07001705 if not prefix:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001706 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001707
1708 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07001709
1710 # The common files may all be within a subdirectory of the main project
1711 # directory, so walk up the tree until we find an alias file.
1712 # _get_affected_files() should return relative paths, but check against '/' to
1713 # ensure that this loop terminates even if it receives an absolute path.
1714 while prefix and prefix != '/':
1715 alias_file = os.path.join(prefix, '.project_alias')
1716
1717 # If an alias exists, use it.
1718 if os.path.isfile(alias_file):
1719 project_name = osutils.ReadFile(alias_file).strip()
1720
1721 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001722
1723 if not _get_commit_desc(commit).startswith(project_name + ': '):
1724 return HookFailure('The commit title for changes affecting only %s'
1725 ' should start with \"%s: \"'
1726 % (project_name, project_name))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001727 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001728
1729
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001730def _check_filepath_chartype(_project, commit):
1731 """Checks that FilePath::CharType stuff is not used."""
1732
1733 FILEPATH_REGEXP = re.compile('|'.join(
1734 [r'(?:base::)?FilePath::(?:Char|String|StringPiece)Type',
Satoru Takabayashi4ca37922018-08-08 10:16:38 +09001735 r'(?:base::)?FilePath::FromUTF8Unsafe',
1736 r'AsUTF8Unsafe',
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001737 r'FILE_PATH_LITERAL']))
1738 files = _filter_files(_get_affected_files(commit, relative=True),
1739 [r'.*\.(cc|h)$'])
1740
1741 errors = []
1742 for afile in files:
1743 for line_num, line in _get_file_diff(afile, commit):
1744 m = re.search(FILEPATH_REGEXP, line)
1745 if m:
1746 errors.append('%s, line %s has %s' % (afile, line_num, m.group(0)))
1747
1748 if errors:
1749 msg = 'Please assume FilePath::CharType is char (crbug.com/870621):'
1750 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001751 return None
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001752
1753
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001754def _check_exec_files(_project, commit):
1755 """Make +x bits on files."""
1756 # List of files that should never be +x.
1757 NO_EXEC = (
1758 'ChangeLog*',
1759 'COPYING',
1760 'make.conf',
1761 'make.defaults',
1762 'Manifest',
1763 'OWNERS',
1764 'package.use',
1765 'package.keywords',
1766 'package.mask',
1767 'parent',
1768 'README',
1769 'TODO',
1770 '.gitignore',
1771 '*.[achly]',
1772 '*.[ch]xx',
1773 '*.boto',
1774 '*.cc',
1775 '*.cfg',
1776 '*.conf',
1777 '*.config',
1778 '*.cpp',
1779 '*.css',
1780 '*.ebuild',
1781 '*.eclass',
Tatsuhisa Yamaguchi3b053632019-01-10 14:45:14 +09001782 '*.gn',
1783 '*.gni',
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001784 '*.gyp',
1785 '*.gypi',
1786 '*.htm',
1787 '*.html',
1788 '*.ini',
1789 '*.js',
1790 '*.json',
1791 '*.md',
1792 '*.mk',
1793 '*.patch',
1794 '*.policy',
1795 '*.proto',
1796 '*.raw',
1797 '*.rules',
1798 '*.service',
1799 '*.target',
1800 '*.txt',
1801 '*.xml',
1802 '*.yaml',
1803 )
1804
1805 def FinalName(obj):
1806 # If the file is being deleted, then the dst_file is not set.
1807 if obj.dst_file is None:
1808 return obj.src_file
1809 else:
1810 return obj.dst_file
1811
1812 bad_files = []
1813 files = _get_affected_files(commit, relative=True, full_details=True)
1814 for f in files:
1815 mode = int(f.dst_mode, 8)
1816 if not mode & 0o111:
1817 continue
1818 name = FinalName(f)
1819 for no_exec in NO_EXEC:
1820 if fnmatch.fnmatch(name, no_exec):
1821 bad_files.append(name)
1822 break
1823
1824 if bad_files:
1825 return HookFailure('These files should not be executable. '
1826 'Please `chmod -x` them.', bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001827 return None
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001828
1829
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001830# Base
1831
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001832# A list of hooks which are not project specific and check patch description
1833# (as opposed to patch body).
1834_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07001835 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07001836 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07001837 _check_change_has_test_field,
1838 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001839 _check_commit_message_style,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001840 _check_change_is_contribution,
Jack Neus8edbf642019-07-10 16:08:31 -06001841 _check_change_no_include_oem,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001842]
1843
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001844# A list of hooks that are not project-specific
1845_COMMON_HOOKS = [
Aviv Keshet5ac59522017-01-31 14:28:27 -08001846 _check_cros_license,
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001847 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05001848 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001849 _check_ebuild_licenses,
Mike Frysingercd363c82014-02-01 05:20:18 -05001850 _check_ebuild_virtual_pv,
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001851 _check_exec_files,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001852 _check_for_uprev,
Rahul Chaudhry09f61372015-07-31 17:14:26 -07001853 _check_gofmt,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001854 _check_layout_conf,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001855 _check_no_long_lines,
Keigo Oka4a09bd92019-05-07 14:01:00 +09001856 _check_no_new_gyp,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001857 _check_no_stray_whitespace,
Ryan Cui9b651632011-05-11 11:38:58 -07001858 _check_no_tabs,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001859 _check_portage_make_use_var,
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -06001860 _check_rustfmt,
Aviv Keshet5ac59522017-01-31 14:28:27 -08001861 _check_tabbed_indents,
Ryan Cui9b651632011-05-11 11:38:58 -07001862]
Ryan Cuiec4d6332011-05-02 14:15:25 -07001863
Ryan Cui1562fb82011-05-09 11:01:31 -07001864
Ryan Cui9b651632011-05-11 11:38:58 -07001865# A dictionary of project-specific hooks(callbacks), indexed by project name.
1866# dict[project] = [callback1, callback2]
1867_PROJECT_SPECIFIC_HOOKS = {
Mike Frysinger24dd3c52019-08-17 14:22:48 -04001868 'chromiumos/third_party/kernel': [_kernel_configcheck],
1869 'chromiumos/third_party/kernel-next': [_kernel_configcheck],
Ryan Cui9b651632011-05-11 11:38:58 -07001870}
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001871
Ryan Cui1562fb82011-05-09 11:01:31 -07001872
Ryan Cui9b651632011-05-11 11:38:58 -07001873# A dictionary of flags (keys) that can appear in the config file, and the hook
Mike Frysinger3554bc92015-03-11 04:59:21 -04001874# that the flag controls (value).
1875_HOOK_FLAGS = {
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001876 'clang_format_check': _check_clang_format,
Mike Frysingera7642f52015-03-25 18:31:42 -04001877 'checkpatch_check': _run_checkpatch,
Brian Norris23c62e92018-11-14 12:25:51 -08001878 'kerneldoc_check': _run_kerneldoc,
Ryan Cui9b651632011-05-11 11:38:58 -07001879 'stray_whitespace_check': _check_no_stray_whitespace,
Mike Frysingerff6c7d62015-03-24 13:49:46 -04001880 'json_check': _run_json_check,
Ryan Cui9b651632011-05-11 11:38:58 -07001881 'long_line_check': _check_no_long_lines,
Alex Deymof5792ce2015-08-24 22:50:08 -07001882 'cros_license_check': _check_cros_license,
1883 'aosp_license_check': _check_aosp_license,
LaMont Jones872fe762020-02-10 15:36:14 -07001884 'gofmt_check': _check_gofmt,
Ryan Cui9b651632011-05-11 11:38:58 -07001885 'tab_check': _check_no_tabs,
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08001886 'tabbed_indent_required_check': _check_tabbed_indents,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001887 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001888 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07001889 'bug_field_check': _check_change_has_bug_field,
1890 'test_field_check': _check_change_has_test_field,
Steve Fung49ec7e92015-03-23 16:07:12 -07001891 'manifest_check': _check_manifests,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001892 'contribution_check': _check_change_is_contribution,
Mike Frysinger47bd1252018-06-11 12:12:20 -04001893 'project_prefix_check': _check_project_prefix,
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001894 'filepath_chartype_check': _check_filepath_chartype,
Ryan Cui9b651632011-05-11 11:38:58 -07001895}
1896
1897
Mike Frysinger3554bc92015-03-11 04:59:21 -04001898def _get_override_hooks(config):
1899 """Returns a set of hooks controlled by the current project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001900
1901 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08001902
1903 Args:
1904 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001905 """
1906 SECTION = 'Hook Overrides'
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001907 SECTION_OPTIONS = 'Hook Overrides Options'
Ryan Cui9b651632011-05-11 11:38:58 -07001908
Mike Frysinger56e8de02019-07-31 14:40:14 -04001909 valid_keys = set(_HOOK_FLAGS.keys())
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001910 hooks = _HOOK_FLAGS.copy()
Mike Frysinger380592f2020-02-03 15:27:16 -05001911 options = config.options(SECTION) if config.has_section(SECTION) else []
Mike Frysinger3554bc92015-03-11 04:59:21 -04001912
1913 enable_flags = []
Ryan Cui9b651632011-05-11 11:38:58 -07001914 disable_flags = []
Mike Frysinger380592f2020-02-03 15:27:16 -05001915 for flag in options:
Mike Frysinger3554bc92015-03-11 04:59:21 -04001916 if flag not in valid_keys:
1917 raise ValueError('Error: unknown key "%s" in hook section of "%s"' %
1918 (flag, _CONFIG_FILE))
1919
Ryan Cui9b651632011-05-11 11:38:58 -07001920 try:
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001921 enabled = config.getboolean(SECTION, flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001922 except ValueError as e:
Mike Frysinger3554bc92015-03-11 04:59:21 -04001923 raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' %
1924 (flag, _CONFIG_FILE, e))
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001925 if enabled:
1926 enable_flags.append(flag)
1927 else:
1928 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001929
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001930 # See if this hook has custom options.
1931 if enabled:
1932 try:
1933 options = config.get(SECTION_OPTIONS, flag)
1934 hooks[flag] = functools.partial(hooks[flag], options=options.split())
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001935 hooks[flag].__name__ = flag
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04001936 except (configparser.NoOptionError, configparser.NoSectionError):
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001937 pass
1938
1939 enabled_hooks = set(hooks[x] for x in enable_flags)
1940 disabled_hooks = set(hooks[x] for x in disable_flags)
Mike Frysinger45334bd2019-11-04 10:42:33 -05001941
Mike Frysinger9ab64b12019-11-04 10:53:08 -05001942 if _check_change_has_signoff_field not in enabled_hooks:
1943 enabled_hooks.add(_check_change_has_no_signoff_field)
Mike Frysinger45334bd2019-11-04 10:42:33 -05001944 if _check_change_has_branch_field not in enabled_hooks:
1945 enabled_hooks.add(_check_change_has_no_branch_field)
1946
Mike Frysinger3554bc92015-03-11 04:59:21 -04001947 return enabled_hooks, disabled_hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001948
1949
Jon Salz3ee59de2012-08-18 13:54:22 +08001950def _get_project_hook_scripts(config):
1951 """Returns a list of project-specific hook scripts.
1952
1953 Args:
1954 config: A ConfigParser for the project's config file.
1955 """
1956 SECTION = 'Hook Scripts'
1957 if not config.has_section(SECTION):
1958 return []
1959
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001960 return config.items(SECTION)
Jon Salz3ee59de2012-08-18 13:54:22 +08001961
1962
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001963def _get_project_hooks(project, presubmit):
Ryan Cui9b651632011-05-11 11:38:58 -07001964 """Returns a list of hooks that need to be run for a project.
1965
1966 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001967
1968 Args:
1969 project: A string, name of the project.
1970 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui9b651632011-05-11 11:38:58 -07001971 """
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04001972 config = configparser.RawConfigParser()
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001973 if not os.path.exists(_CONFIG_FILE):
Jon Salz3ee59de2012-08-18 13:54:22 +08001974 # Just use an empty config file
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04001975 config = configparser.RawConfigParser()
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001976 else:
1977 config.read(_CONFIG_FILE)
Jon Salz3ee59de2012-08-18 13:54:22 +08001978
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001979 if presubmit:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001980 hooks = _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001981 else:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001982 hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001983
Mike Frysinger3554bc92015-03-11 04:59:21 -04001984 enabled_hooks, disabled_hooks = _get_override_hooks(config)
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001985 hooks = [hook for hook in hooks if hook not in disabled_hooks]
1986
1987 # If a list is both in _COMMON_HOOKS and also enabled explicitly through an
1988 # override, keep the override only. Note that the override may end up being
1989 # a functools.partial, in which case we need to extract the .func to compare
1990 # it to the common hooks.
1991 unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks]
1992 hooks = [hook for hook in hooks if hook not in unwrapped_hooks]
1993
1994 hooks = list(enabled_hooks) + hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001995
1996 if project in _PROJECT_SPECIFIC_HOOKS:
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001997 hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project]
1998 if hook not in disabled_hooks)
Ryan Cui9b651632011-05-11 11:38:58 -07001999
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002000 for name, script in _get_project_hook_scripts(config):
2001 func = functools.partial(_run_project_hook_script, script)
2002 func.__name__ = name
2003 hooks.append(func)
Jon Salz3ee59de2012-08-18 13:54:22 +08002004
Ryan Cui9b651632011-05-11 11:38:58 -07002005 return hooks
2006
2007
Alex Deymo643ac4c2015-09-03 10:40:50 -07002008def _run_project_hooks(project_name, proj_dir=None,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002009 commit_list=None, presubmit=False):
Ryan Cui1562fb82011-05-09 11:01:31 -07002010 """For each project run its project specific hook from the hooks dictionary.
2011
2012 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002013 project_name: The name of project to run hooks for.
Doug Anderson44a644f2011-11-02 10:37:37 -07002014 proj_dir: If non-None, this is the directory the project is in. If None,
2015 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07002016 commit_list: A list of commits to run hooks against. If None or empty list
2017 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002018 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui1562fb82011-05-09 11:01:31 -07002019
2020 Returns:
2021 Boolean value of whether any errors were ecountered while running the hooks.
2022 """
Doug Anderson44a644f2011-11-02 10:37:37 -07002023 if proj_dir is None:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002024 proj_dirs = _run_command(
2025 ['repo', 'forall', project_name, '-c', 'pwd']).split()
Mike Frysingere52b1bc2019-09-16 23:45:41 -04002026 if not proj_dirs:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002027 print('%s cannot be found.' % project_name, file=sys.stderr)
David James2edd9002013-10-11 14:09:19 -07002028 print('Please specify a valid project.', file=sys.stderr)
2029 return True
2030 if len(proj_dirs) > 1:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002031 print('%s is associated with multiple directories.' % project_name,
David James2edd9002013-10-11 14:09:19 -07002032 file=sys.stderr)
2033 print('Please specify a directory to help disambiguate.', file=sys.stderr)
2034 return True
2035 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07002036
Ryan Cuiec4d6332011-05-02 14:15:25 -07002037 pwd = os.getcwd()
2038 # hooks assume they are run from the root of the project
2039 os.chdir(proj_dir)
2040
Mike Frysingered1b95a2019-12-12 19:04:51 -05002041 color = terminal.Color()
2042
Alex Deymo643ac4c2015-09-03 10:40:50 -07002043 remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref',
2044 '--symbolic-full-name', '@{u}']).strip()
2045 if not remote_branch:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002046 print("Your project %s doesn't track any remote repo." % project_name,
Alex Deymo643ac4c2015-09-03 10:40:50 -07002047 file=sys.stderr)
2048 remote = None
2049 else:
Josh Pratt15d13ab2018-08-13 11:52:48 +10002050 branch_items = remote_branch.split('/', 1)
2051 if len(branch_items) != 2:
2052 PrintErrorForProject(
2053 project_name,
2054 HookFailure(
2055 'Cannot get remote and branch name (%s)' % remote_branch))
2056 os.chdir(pwd)
2057 return True
2058 remote, _branch = branch_items
Alex Deymo643ac4c2015-09-03 10:40:50 -07002059
2060 project = Project(name=project_name, dir=proj_dir, remote=remote)
2061
Doug Anderson14749562013-06-26 13:38:29 -07002062 if not commit_list:
2063 try:
2064 commit_list = _get_commits()
2065 except VerifyException as e:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002066 PrintErrorForProject(project.name, HookFailure(str(e)))
Doug Anderson14749562013-06-26 13:38:29 -07002067 os.chdir(pwd)
2068 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07002069
Alex Deymo643ac4c2015-09-03 10:40:50 -07002070 hooks = _get_project_hooks(project.name, presubmit)
Ryan Cui1562fb82011-05-09 11:01:31 -07002071 error_found = False
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002072 commit_count = len(commit_list)
Mike Frysingerb99b3772019-08-17 14:19:44 -04002073 hook_count = len(hooks)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002074 for i, commit in enumerate(commit_list):
Mike Frysingerb2496652019-09-12 23:35:46 -04002075 CACHE.clear()
2076
LaMont Jones69d3e182020-03-11 15:00:53 -06002077 # If run with --pre-submit, then commit is PRE_SUBMIT, and not a commit.
2078 # Use that as the description.
2079 desc = commit if commit == PRE_SUBMIT else _get_commit_desc(commit)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002080 print('[%s %i/%i %s] %s' %
2081 (color.Color(color.CYAN, 'COMMIT'), i + 1, commit_count, commit[0:12],
2082 desc.splitlines()[0]))
2083
Mike Frysingerb99b3772019-08-17 14:19:44 -04002084 for h, hook in enumerate(hooks):
Mike Frysingered1b95a2019-12-12 19:04:51 -05002085 output = ('[%s %i/%i PRESUBMIT.cfg] %s' %
2086 (color.Color(color.YELLOW, 'RUNNING'), h + 1, hook_count,
2087 hook.__name__))
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002088 print(output, end='\r')
2089 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002090 hook_error = hook(project, commit)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002091 print(' ' * len(output), end='\r')
2092 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002093 if hook_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002094 if not isinstance(hook_error, list):
2095 hook_error = [hook_error]
2096 PrintErrorsForCommit(color, hook, project.name, hook_error)
Ryan Cui1562fb82011-05-09 11:01:31 -07002097 error_found = True
Don Garrettdba548a2011-05-05 15:17:14 -07002098
Ryan Cuiec4d6332011-05-02 14:15:25 -07002099 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07002100 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002101
Mike Frysingerae409522014-02-01 03:16:11 -05002102
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002103# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002104
Ryan Cui1562fb82011-05-09 11:01:31 -07002105
Mike Frysingerae409522014-02-01 03:16:11 -05002106def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08002107 """Main function invoked directly by repo.
2108
2109 This function will exit directly upon error so that repo doesn't print some
2110 obscure error message.
2111
2112 Args:
2113 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07002114 worktree_list: A list of directories. It should be the same length as
2115 project_list, so that each entry in project_list matches with a directory
2116 in worktree_list. If None, we will attempt to calculate the directories
2117 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08002118 kwargs: Leave this here for forward-compatibility.
2119 """
Mike Frysingered1b95a2019-12-12 19:04:51 -05002120 start_time = datetime.datetime.now()
Ryan Cui1562fb82011-05-09 11:01:31 -07002121 found_error = False
David James2edd9002013-10-11 14:09:19 -07002122 if not worktree_list:
2123 worktree_list = [None] * len(project_list)
2124 for project, worktree in zip(project_list, worktree_list):
2125 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07002126 found_error = True
2127
Mike Frysingered1b95a2019-12-12 19:04:51 -05002128 end_time = datetime.datetime.now()
2129 color = terminal.Color()
Mike Frysingerae409522014-02-01 03:16:11 -05002130 if found_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002131 msg = ('%s: Preupload failed due to above error(s).\n'
Ryan Cui9b651632011-05-11 11:38:58 -07002132 '- To disable some source style checks, and for other hints, see '
Mike Frysingered1b95a2019-12-12 19:04:51 -05002133 '<checkout_dir>/src/repohooks/README.md\n'
2134 "- To upload only current project, run 'repo upload .'" %
2135 (color.Color(color.RED, 'FATAL'),))
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04002136 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07002137 sys.exit(1)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002138 else:
2139 msg = ('[%s] repohooks passed in %s' %
2140 (color.Color(color.GREEN, 'PASSED'), end_time - start_time))
2141 print(msg)
Anush Elangovan63afad72011-03-23 00:41:27 -07002142
Ryan Cui1562fb82011-05-09 11:01:31 -07002143
Doug Anderson44a644f2011-11-02 10:37:37 -07002144def _identify_project(path):
2145 """Identify the repo project associated with the given path.
2146
2147 Returns:
2148 A string indicating what project is associated with the path passed in or
2149 a blank string upon failure.
2150 """
2151 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002152 stderr=True, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002153
2154
Mike Frysinger55f85b52014-12-18 14:45:21 -05002155def direct_main(argv):
Doug Anderson44a644f2011-11-02 10:37:37 -07002156 """Run hooks directly (outside of the context of repo).
2157
Doug Anderson44a644f2011-11-02 10:37:37 -07002158 Args:
Mike Frysinger55f85b52014-12-18 14:45:21 -05002159 argv: The command line args to process
Doug Anderson44a644f2011-11-02 10:37:37 -07002160
2161 Returns:
2162 0 if no pre-upload failures, 1 if failures.
2163
2164 Raises:
2165 BadInvocation: On some types of invocation errors.
2166 """
Mike Frysinger66142932014-12-18 14:55:57 -05002167 parser = commandline.ArgumentParser(description=__doc__)
2168 parser.add_argument('--dir', default=None,
2169 help='The directory that the project lives in. If not '
2170 'specified, use the git project root based on the cwd.')
2171 parser.add_argument('--project', default=None,
2172 help='The project repo path; this can affect how the '
2173 'hooks get run, since some hooks are project-specific. '
2174 'For chromite this is chromiumos/chromite. If not '
2175 'specified, the repo tool will be used to figure this '
2176 'out based on the dir.')
2177 parser.add_argument('--rerun-since', default=None,
Vadim Bendebury75447b92018-01-10 12:06:01 -08002178 help='Rerun hooks on old commits since some point '
2179 'in the past. The argument could be a date (should '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002180 "match git log's concept of a date, e.g. 2012-06-20), "
Vadim Bendebury75447b92018-01-10 12:06:01 -08002181 'or a SHA1, or just a number of commits to check (from 1 '
2182 'to 99). This option is mutually exclusive with '
2183 '--pre-submit.')
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002184 parser.add_argument('--pre-submit', action='store_true',
Mike Frysinger66142932014-12-18 14:55:57 -05002185 help='Run the check against the pending commit. '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002186 "This option should be used at the 'git commit' "
2187 "phase as opposed to 'repo upload'. This option "
Mike Frysinger66142932014-12-18 14:55:57 -05002188 'is mutually exclusive with --rerun-since.')
2189 parser.add_argument('commits', nargs='*',
2190 help='Check specific commits')
2191 opts = parser.parse_args(argv)
Doug Anderson44a644f2011-11-02 10:37:37 -07002192
Doug Anderson14749562013-06-26 13:38:29 -07002193 if opts.rerun_since:
Mike Frysinger66142932014-12-18 14:55:57 -05002194 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002195 raise BadInvocation("Can't pass commits and use rerun-since: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002196 ' '.join(opts.commits))
Doug Anderson14749562013-06-26 13:38:29 -07002197
Vadim Bendebury75447b92018-01-10 12:06:01 -08002198 if len(opts.rerun_since) < 3 and opts.rerun_since.isdigit():
2199 # This must be the number of commits to check. We don't expect the user
2200 # to want to check more than 99 commits.
2201 limit = '-n%s' % opts.rerun_since
2202 elif git.IsSHA1(opts.rerun_since, False):
2203 limit = '%s..' % opts.rerun_since
2204 else:
2205 # This better be a date.
2206 limit = '--since=%s' % opts.rerun_since
2207 cmd = ['git', 'log', limit, '--pretty=%H']
Doug Anderson14749562013-06-26 13:38:29 -07002208 all_commits = _run_command(cmd).splitlines()
2209 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
2210
2211 # Eliminate chrome-bot commits but keep ordering the same...
2212 bot_commits = set(bot_commits)
Mike Frysinger66142932014-12-18 14:55:57 -05002213 opts.commits = [c for c in all_commits if c not in bot_commits]
Doug Anderson14749562013-06-26 13:38:29 -07002214
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002215 if opts.pre_submit:
2216 raise BadInvocation('rerun-since and pre-submit can not be '
2217 'used together')
2218 if opts.pre_submit:
Mike Frysinger66142932014-12-18 14:55:57 -05002219 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002220 raise BadInvocation("Can't pass commits and use pre-submit: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002221 ' '.join(opts.commits))
2222 opts.commits = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07002223
2224 # Check/normlaize git dir; if unspecified, we'll use the root of the git
2225 # project from CWD
2226 if opts.dir is None:
2227 git_dir = _run_command(['git', 'rev-parse', '--git-dir'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002228 stderr=True).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002229 if not git_dir:
2230 raise BadInvocation('The current directory is not part of a git project.')
2231 opts.dir = os.path.dirname(os.path.abspath(git_dir))
2232 elif not os.path.isdir(opts.dir):
2233 raise BadInvocation('Invalid dir: %s' % opts.dir)
2234 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
2235 raise BadInvocation('Not a git directory: %s' % opts.dir)
2236
2237 # Identify the project if it wasn't specified; this _requires_ the repo
2238 # tool to be installed and for the project to be part of a repo checkout.
2239 if not opts.project:
2240 opts.project = _identify_project(opts.dir)
2241 if not opts.project:
2242 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
2243
Doug Anderson14749562013-06-26 13:38:29 -07002244 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Mike Frysinger66142932014-12-18 14:55:57 -05002245 commit_list=opts.commits,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002246 presubmit=opts.pre_submit)
Doug Anderson44a644f2011-11-02 10:37:37 -07002247 if found_error:
2248 return 1
2249 return 0
2250
2251
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002252if __name__ == '__main__':
Mike Frysinger55f85b52014-12-18 14:45:21 -05002253 sys.exit(direct_main(sys.argv[1:]))