Mike Frysinger | 4f99440 | 2019-09-13 17:40:45 -0400 | [diff] [blame] | 1 | #!/usr/bin/env python3 |
Mike Frysinger | b7d552e | 2017-11-23 11:50:47 -0500 | [diff] [blame] | 2 | # -*- coding: utf-8 -*- |
Jon Salz | 9825593 | 2012-08-18 14:48:02 +0800 | [diff] [blame] | 3 | # Copyright (c) 2012 The Chromium OS Authors. All rights reserved. |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 4 | # Use of this source code is governed by a BSD-style license that can be |
| 5 | # found in the LICENSE file. |
| 6 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 7 | """Presubmit checks to run when doing `repo upload`. |
| 8 | |
| 9 | You can add new checks by adding a functions to the HOOKS constants. |
| 10 | """ |
| 11 | |
Mike Frysinger | 09d6a3d | 2013-10-08 22:21:03 -0400 | [diff] [blame] | 12 | from __future__ import print_function |
| 13 | |
Keigo Oka | dd90882 | 2019-06-04 11:30:25 +0900 | [diff] [blame] | 14 | import argparse |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 15 | import collections |
Mike Frysinger | f252cfc | 2019-12-09 17:34:28 -0500 | [diff] [blame] | 16 | import configparser |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 17 | import datetime |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 18 | import fnmatch |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 19 | import functools |
Dale Curtis | 2975c43 | 2011-05-03 17:25:20 -0700 | [diff] [blame] | 20 | import json |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 21 | import os |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 22 | import re |
Mandeep Singh Baines | a7ffa4b | 2011-05-03 11:37:02 -0700 | [diff] [blame] | 23 | import sys |
Peter Ammon | 811f670 | 2014-06-12 15:45:38 -0700 | [diff] [blame] | 24 | import stat |
Mike Frysinger | d0c5c8b | 2019-12-17 02:28:26 -0500 | [diff] [blame] | 25 | import subprocess |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 26 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 27 | from errors import (VerifyException, HookFailure, PrintErrorForProject, |
| 28 | PrintErrorsForCommit) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 29 | |
Mike Frysinger | 919c703 | 2019-09-13 17:48:08 -0400 | [diff] [blame] | 30 | if __name__ in ('__builtin__', 'builtins'): |
Mike Frysinger | 653cd26 | 2019-09-20 14:05:02 -0400 | [diff] [blame] | 31 | # If repo imports us, the __name__ will be __builtin__, and the cwd will be in |
| 32 | # the top level of the checkout (i.e. $CHROMEOS_CHECKOUT). chromite will be |
| 33 | # in that directory, so add it to our path. This works whether we're running |
| 34 | # the repo in $CHROMEOS_CHECKOUT/.repo/repo/ or a custom version in a |
| 35 | # completely different tree. |
| 36 | # TODO(vapier): Python 2 used "__builtin__" while Python 3 uses "builtins". |
Mike Frysinger | 6850d51 | 2018-05-21 12:12:14 -0400 | [diff] [blame] | 37 | sys.path.insert(0, os.getcwd()) |
| 38 | |
Mike Frysinger | 653cd26 | 2019-09-20 14:05:02 -0400 | [diff] [blame] | 39 | elif __name__ == '__main__': |
| 40 | # If we're run directly, we'll find chromite relative to the repohooks dir in |
| 41 | # $CHROMEOS_CHECKOUT/src/repohooks, so go up two dirs. |
David James | c3b68b3 | 2013-04-03 09:17:03 -0700 | [diff] [blame] | 42 | sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..')) |
| 43 | |
Mike Frysinger | fd481ce | 2019-09-13 18:14:48 -0400 | [diff] [blame] | 44 | # The sys.path monkey patching confuses the linter. |
| 45 | # pylint: disable=wrong-import-position |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 46 | from chromite.lib import commandline |
Rahul Chaudhry | 0e51534 | 2015-08-07 12:00:43 -0700 | [diff] [blame] | 47 | from chromite.lib import cros_build_lib |
Mike Frysinger | d3bd32c | 2014-11-24 23:34:29 -0500 | [diff] [blame] | 48 | from chromite.lib import git |
Daniel Erat | a350fd3 | 2014-09-29 14:02:34 -0700 | [diff] [blame] | 49 | from chromite.lib import osutils |
David James | c3b68b3 | 2013-04-03 09:17:03 -0700 | [diff] [blame] | 50 | from chromite.lib import patch |
Mike Frysinger | ed1b95a | 2019-12-12 19:04:51 -0500 | [diff] [blame] | 51 | from chromite.lib import terminal |
Mike Frysinger | 2ec70ed | 2014-08-17 19:28:34 -0400 | [diff] [blame] | 52 | from chromite.licensing import licenses_lib |
David James | c3b68b3 | 2013-04-03 09:17:03 -0700 | [diff] [blame] | 53 | |
Mike Frysinger | ff4768e | 2020-02-27 18:48:13 -0500 | [diff] [blame^] | 54 | |
| 55 | assert sys.version_info >= (3, 6), 'This module requires Python 3.6+' |
| 56 | |
| 57 | |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 58 | PRE_SUBMIT = 'pre-submit' |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 59 | |
Mike Frysinger | ed9b2a0 | 2019-12-12 18:52:32 -0500 | [diff] [blame] | 60 | |
| 61 | # Link to commit message documentation for users. |
| 62 | DOC_COMMIT_MSG_URL = ('https://chromium.googlesource.com/chromiumos/docs/+/HEAD' |
| 63 | '/contributing.md#commit-messages') |
| 64 | |
| 65 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 66 | COMMON_INCLUDED_PATHS = [ |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 67 | # C++ and friends |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 68 | r'.*\.c$', r'.*\.cc$', r'.*\.cpp$', r'.*\.h$', r'.*\.m$', r'.*\.mm$', |
| 69 | r'.*\.inl$', r'.*\.asm$', r'.*\.hxx$', r'.*\.hpp$', r'.*\.s$', r'.*\.S$', |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 70 | # Scripts |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 71 | r'.*\.js$', r'.*\.py$', r'.*\.sh$', r'.*\.rb$', r'.*\.pl$', r'.*\.pm$', |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 72 | # No extension at all, note that ALL CAPS files are black listed in |
| 73 | # COMMON_EXCLUDED_LIST below. |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 74 | r'(^|.*[\\\/])[^.]+$', |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 75 | # Other |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 76 | r'.*\.java$', r'.*\.mk$', r'.*\.am$', |
| 77 | r'.*\.policy$', r'.*\.conf$', r'.*\.go$', |
| 78 | r'(^OWNERS|/OWNERS)', |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 79 | ] |
| 80 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 81 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 82 | COMMON_EXCLUDED_PATHS = [ |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 83 | # For ebuild trees, ignore any caches and manifest data. |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 84 | r'.*/Manifest$', |
| 85 | r'.*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$', |
Doug Anderson | 5bfb679 | 2011-10-25 16:45:41 -0700 | [diff] [blame] | 86 | |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 87 | # Ignore profiles data (like overlay-tegra2/profiles). |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 88 | r'(^|.*/)overlay-.*/profiles/.*', |
| 89 | r'^profiles/.*$', |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 90 | |
C Shapiro | 8f90e9b | 2017-06-28 09:54:50 -0600 | [diff] [blame] | 91 | # Ignore config files in ebuild setup. |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 92 | r'(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*', |
| 93 | r'^chromeos-base/chromeos-bsp.*/files/.*', |
C Shapiro | 8f90e9b | 2017-06-28 09:54:50 -0600 | [diff] [blame] | 94 | |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 95 | # Ignore minified js and jquery. |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 96 | r'.*\.min\.js', |
| 97 | r'.*jquery.*\.js', |
Mike Frysinger | 33a458d | 2014-03-03 17:00:51 -0500 | [diff] [blame] | 98 | |
| 99 | # Ignore license files as the content is often taken verbatim. |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 100 | r'.*/licenses/.*', |
Alex Klein | 619c091 | 2019-01-30 17:13:23 -0700 | [diff] [blame] | 101 | |
Mike Frysinger | 1365040 | 2019-07-31 14:31:46 -0400 | [diff] [blame] | 102 | # Exclude generated protobuf bindings. |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 103 | r'.*_pb2\.py$', |
| 104 | r'.*\.pb\.go$', |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 105 | ] |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 106 | |
Ken Turner | d07564b | 2018-02-08 17:57:59 +1100 | [diff] [blame] | 107 | LICENSE_EXCLUDED_PATHS = [ |
LaMont Jones | 775c2b3 | 2020-02-19 17:32:54 -0700 | [diff] [blame] | 108 | r'^(.*/)?OWNERS(\..*)?$', |
Ken Turner | d07564b | 2018-02-08 17:57:59 +1100 | [diff] [blame] | 109 | ] |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 110 | |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 111 | _CONFIG_FILE = 'PRESUBMIT.cfg' |
| 112 | |
| 113 | |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 114 | # File containing wildcards, one per line, matching files that should be |
| 115 | # excluded from presubmit checks. Lines beginning with '#' are ignored. |
| 116 | _IGNORE_FILE = '.presubmitignore' |
| 117 | |
Cheng Yueh | b707c52 | 2020-01-02 14:06:59 +0800 | [diff] [blame] | 118 | |
| 119 | TEST_FIELD_RE = r'\nTEST=\S+' |
| 120 | |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 121 | # Exceptions |
| 122 | |
| 123 | |
| 124 | class BadInvocation(Exception): |
| 125 | """An Exception indicating a bad invocation of the program.""" |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 126 | |
| 127 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 128 | # General Helpers |
| 129 | |
Sean Paul | ba01d40 | 2011-05-05 11:36:23 -0400 | [diff] [blame] | 130 | |
Mike Frysinger | b249665 | 2019-09-12 23:35:46 -0400 | [diff] [blame] | 131 | class Cache(object): |
| 132 | """General helper for caching git content.""" |
| 133 | |
| 134 | def __init__(self): |
| 135 | self._cache = {} |
| 136 | |
| 137 | def get_subcache(self, scope): |
| 138 | return self._cache.setdefault(scope, {}) |
| 139 | |
| 140 | def clear(self): |
| 141 | self._cache.clear() |
| 142 | |
| 143 | CACHE = Cache() |
| 144 | |
| 145 | |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 146 | Project = collections.namedtuple('Project', ['name', 'dir', 'remote']) |
| 147 | |
| 148 | |
Mike Frysinger | 526a5f8 | 2019-09-13 18:05:30 -0400 | [diff] [blame] | 149 | def _run_command(cmd, **kwargs): |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 150 | """Executes the passed in command and returns raw stdout output. |
| 151 | |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 152 | This is a convenience func to set some run defaults differently. |
Mike Frysinger | 526a5f8 | 2019-09-13 18:05:30 -0400 | [diff] [blame] | 153 | |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 154 | Args: |
| 155 | cmd: The command to run; should be a list of strings. |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 156 | **kwargs: Same as cros_build_lib.run. |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 157 | |
| 158 | Returns: |
Rahul Chaudhry | 0e51534 | 2015-08-07 12:00:43 -0700 | [diff] [blame] | 159 | The stdout from the process (discards stderr and returncode). |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 160 | """ |
Mike Frysinger | 526a5f8 | 2019-09-13 18:05:30 -0400 | [diff] [blame] | 161 | kwargs.setdefault('print_cmd', False) |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 162 | kwargs.setdefault('stdout', True) |
| 163 | kwargs.setdefault('check', False) |
Mike Frysinger | 054c159 | 2019-11-18 03:51:54 -0500 | [diff] [blame] | 164 | result = cros_build_lib.run(cmd, **kwargs) |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 165 | # NB: We decode this directly rather than through kwargs as our tests rely |
| 166 | # on this post-processing behavior currently. |
Mike Frysinger | 71e643e | 2019-09-13 17:26:39 -0400 | [diff] [blame] | 167 | return result.output.decode('utf-8', 'replace') |
Ryan Cui | 72834d1 | 2011-05-05 14:51:33 -0700 | [diff] [blame] | 168 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 169 | |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 170 | def _get_hooks_dir(): |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 171 | """Returns the absolute path to the repohooks directory.""" |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 172 | if __name__ == '__main__': |
| 173 | # Works when file is run on its own (__file__ is defined)... |
| 174 | return os.path.abspath(os.path.dirname(__file__)) |
| 175 | else: |
| 176 | # We need to do this when we're run through repo. Since repo executes |
| 177 | # us with execfile(), we don't get __file__ defined. |
| 178 | cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd'] |
| 179 | return _run_command(cmd).strip() |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 180 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 181 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 182 | def _match_regex_list(subject, expressions): |
| 183 | """Try to match a list of regular expressions to a string. |
| 184 | |
| 185 | Args: |
| 186 | subject: The string to match regexes on |
| 187 | expressions: A list of regular expressions to check for matches with. |
| 188 | |
| 189 | Returns: |
| 190 | Whether the passed in subject matches any of the passed in regexes. |
| 191 | """ |
| 192 | for expr in expressions: |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 193 | if re.search(expr, subject): |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 194 | return True |
| 195 | return False |
| 196 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 197 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 198 | def _filter_files(files, include_list, exclude_list=()): |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 199 | """Filter out files based on the conditions passed in. |
| 200 | |
| 201 | Args: |
| 202 | files: list of filepaths to filter |
| 203 | include_list: list of regex that when matched with a file path will cause it |
| 204 | to be added to the output list unless the file is also matched with a |
| 205 | regex in the exclude_list. |
| 206 | exclude_list: list of regex that when matched with a file will prevent it |
| 207 | from being added to the output list, even if it is also matched with a |
| 208 | regex in the include_list. |
| 209 | |
| 210 | Returns: |
| 211 | A list of filepaths that contain files matched in the include_list and not |
| 212 | in the exclude_list. |
| 213 | """ |
| 214 | filtered = [] |
| 215 | for f in files: |
| 216 | if (_match_regex_list(f, include_list) and |
| 217 | not _match_regex_list(f, exclude_list)): |
| 218 | filtered.append(f) |
| 219 | return filtered |
| 220 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 221 | |
| 222 | # Git Helpers |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 223 | |
| 224 | |
Ryan Cui | 4725d95 | 2011-05-05 15:41:19 -0700 | [diff] [blame] | 225 | def _get_upstream_branch(): |
| 226 | """Returns the upstream tracking branch of the current branch. |
| 227 | |
| 228 | Raises: |
| 229 | Error if there is no tracking branch |
| 230 | """ |
| 231 | current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip() |
| 232 | current_branch = current_branch.replace('refs/heads/', '') |
| 233 | if not current_branch: |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 234 | raise VerifyException('Need to be on a tracking branch') |
Ryan Cui | 4725d95 | 2011-05-05 15:41:19 -0700 | [diff] [blame] | 235 | |
| 236 | cfg_option = 'branch.' + current_branch + '.%s' |
| 237 | full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip() |
| 238 | remote = _run_command(['git', 'config', cfg_option % 'remote']).strip() |
| 239 | if not remote or not full_upstream: |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 240 | raise VerifyException('Need to be on a tracking branch') |
Ryan Cui | 4725d95 | 2011-05-05 15:41:19 -0700 | [diff] [blame] | 241 | |
| 242 | return full_upstream.replace('heads', 'remotes/' + remote) |
| 243 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 244 | |
Che-Liang Chiou | 5ce2d7b | 2013-03-22 18:47:55 -0700 | [diff] [blame] | 245 | def _get_patch(commit): |
| 246 | """Returns the patch for this commit.""" |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 247 | if commit == PRE_SUBMIT: |
| 248 | return _run_command(['git', 'diff', '--cached', 'HEAD']) |
| 249 | else: |
| 250 | return _run_command(['git', 'format-patch', '--stdout', '-1', commit]) |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 251 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 252 | |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 253 | def _get_file_content(path, commit): |
| 254 | """Returns the content of a file at a specific commit. |
| 255 | |
| 256 | We can't rely on the file as it exists in the filesystem as people might be |
| 257 | uploading a series of changes which modifies the file multiple times. |
| 258 | |
| 259 | Note: The "content" of a symlink is just the target. So if you're expecting |
| 260 | a full file, you should check that first. One way to detect is that the |
| 261 | content will not have any newlines. |
| 262 | """ |
Mike Frysinger | b249665 | 2019-09-12 23:35:46 -0400 | [diff] [blame] | 263 | # Make sure people don't accidentally pass in full paths which will never |
| 264 | # work. You need to use relative=True with _get_affected_files. |
| 265 | if path.startswith('/'): |
| 266 | raise ValueError('_get_file_content must be called with relative paths: %s' |
| 267 | % (path,)) |
| 268 | |
| 269 | # {<commit>: {<path1>: <content>, <path2>: <content>}} |
| 270 | cache = CACHE.get_subcache('get_file_content') |
| 271 | if path in cache: |
| 272 | return cache[path] |
| 273 | |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 274 | if commit == PRE_SUBMIT: |
Mike Frysinger | b249665 | 2019-09-12 23:35:46 -0400 | [diff] [blame] | 275 | content = _run_command(['git', 'diff', 'HEAD', path]) |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 276 | else: |
Mike Frysinger | b249665 | 2019-09-12 23:35:46 -0400 | [diff] [blame] | 277 | content = _run_command(['git', 'show', '%s:%s' % (commit, path)]) |
| 278 | cache[path] = content |
| 279 | return content |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 280 | |
| 281 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 282 | def _get_file_diff(path, commit): |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 283 | """Returns a list of (linenum, lines) tuples that the commit touched.""" |
Mike Frysinger | b249665 | 2019-09-12 23:35:46 -0400 | [diff] [blame] | 284 | # {<commit>: {<path1>: <content>, <path2>: <content>}} |
| 285 | cache = CACHE.get_subcache('get_file_diff') |
| 286 | if path in cache: |
| 287 | return cache[path] |
| 288 | |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 289 | if commit == PRE_SUBMIT: |
Prathmesh Prabhu | a9de172 | 2016-12-22 14:56:40 -0800 | [diff] [blame] | 290 | command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD', |
| 291 | path] |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 292 | else: |
Prathmesh Prabhu | a9de172 | 2016-12-22 14:56:40 -0800 | [diff] [blame] | 293 | command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit, |
| 294 | path] |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 295 | output = _run_command(command) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 296 | |
| 297 | new_lines = [] |
| 298 | line_num = 0 |
| 299 | for line in output.splitlines(): |
| 300 | m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line) |
| 301 | if m: |
| 302 | line_num = int(m.groups(1)[0]) |
| 303 | continue |
| 304 | if line.startswith('+') and not line.startswith('++'): |
Mike Frysinger | 71e643e | 2019-09-13 17:26:39 -0400 | [diff] [blame] | 305 | new_lines.append((line_num, line[1:])) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 306 | if not line.startswith('-'): |
| 307 | line_num += 1 |
Mike Frysinger | b249665 | 2019-09-12 23:35:46 -0400 | [diff] [blame] | 308 | cache[path] = new_lines |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 309 | return new_lines |
| 310 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 311 | |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 312 | def _get_ignore_wildcards(directory, cache): |
| 313 | """Get wildcards listed in a directory's _IGNORE_FILE. |
| 314 | |
| 315 | Args: |
| 316 | directory: A string containing a directory path. |
| 317 | cache: A dictionary (opaque to caller) caching previously-read wildcards. |
| 318 | |
| 319 | Returns: |
| 320 | A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE |
| 321 | wasn't present. |
| 322 | """ |
| 323 | # In the cache, keys are directories and values are lists of wildcards from |
| 324 | # _IGNORE_FILE within those directories (and empty if no file was present). |
| 325 | if directory not in cache: |
| 326 | wildcards = [] |
| 327 | dotfile_path = os.path.join(directory, _IGNORE_FILE) |
| 328 | if os.path.exists(dotfile_path): |
| 329 | # TODO(derat): Consider using _get_file_content() to get the file as of |
| 330 | # this commit instead of the on-disk version. This may have a noticeable |
| 331 | # performance impact, as each call to _get_file_content() runs git. |
| 332 | with open(dotfile_path, 'r') as dotfile: |
| 333 | for line in dotfile.readlines(): |
| 334 | line = line.strip() |
| 335 | if line.startswith('#'): |
| 336 | continue |
| 337 | if line.endswith('/'): |
| 338 | line += '*' |
| 339 | wildcards.append(line) |
| 340 | cache[directory] = wildcards |
| 341 | |
| 342 | return cache[directory] |
| 343 | |
| 344 | |
| 345 | def _path_is_ignored(path, cache): |
| 346 | """Check whether a path is ignored by _IGNORE_FILE. |
| 347 | |
| 348 | Args: |
| 349 | path: A string containing a path. |
| 350 | cache: A dictionary (opaque to caller) caching previously-read wildcards. |
| 351 | |
| 352 | Returns: |
| 353 | True if a file named _IGNORE_FILE in one of the passed-in path's parent |
| 354 | directories contains a wildcard matching the path. |
| 355 | """ |
| 356 | # Skip ignore files. |
| 357 | if os.path.basename(path) == _IGNORE_FILE: |
| 358 | return True |
| 359 | |
| 360 | path = os.path.abspath(path) |
| 361 | base = os.getcwd() |
| 362 | |
| 363 | prefix = os.path.dirname(path) |
| 364 | while prefix.startswith(base): |
| 365 | rel_path = path[len(prefix) + 1:] |
| 366 | for wildcard in _get_ignore_wildcards(prefix, cache): |
| 367 | if fnmatch.fnmatch(rel_path, wildcard): |
| 368 | return True |
| 369 | prefix = os.path.dirname(prefix) |
| 370 | |
| 371 | return False |
| 372 | |
| 373 | |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 374 | def _get_affected_files(commit, include_deletes=False, relative=False, |
| 375 | include_symlinks=False, include_adds=True, |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 376 | full_details=False, use_ignore_files=True): |
Peter Ammon | 811f670 | 2014-06-12 15:45:38 -0700 | [diff] [blame] | 377 | """Returns list of file paths that were modified/added, excluding symlinks. |
| 378 | |
| 379 | Args: |
| 380 | commit: The commit |
| 381 | include_deletes: If true, we'll include deleted files in the result |
| 382 | relative: Whether to return relative or full paths to files |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 383 | include_symlinks: If true, we'll include symlinks in the result |
| 384 | include_adds: If true, we'll include new files in the result |
| 385 | full_details: If False, return filenames, else return structured results. |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 386 | use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files. |
Peter Ammon | 811f670 | 2014-06-12 15:45:38 -0700 | [diff] [blame] | 387 | |
| 388 | Returns: |
| 389 | A list of modified/added (and perhaps deleted) files |
| 390 | """ |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 391 | if not relative and full_details: |
| 392 | raise ValueError('full_details only supports relative paths currently') |
| 393 | |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 394 | if commit == PRE_SUBMIT: |
| 395 | return _run_command(['git', 'diff-index', '--cached', |
| 396 | '--name-only', 'HEAD']).split() |
Mike Frysinger | d3bd32c | 2014-11-24 23:34:29 -0500 | [diff] [blame] | 397 | |
| 398 | path = os.getcwd() |
Mike Frysinger | b249665 | 2019-09-12 23:35:46 -0400 | [diff] [blame] | 399 | # {<commit>: {<path1>: <content>, <path2>: <content>}} |
| 400 | cache = CACHE.get_subcache('get_affected_files') |
| 401 | if path not in cache: |
| 402 | cache[path] = git.RawDiff(path, '%s^!' % commit) |
| 403 | files = cache[path] |
Mike Frysinger | d3bd32c | 2014-11-24 23:34:29 -0500 | [diff] [blame] | 404 | |
| 405 | # Filter out symlinks. |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 406 | if not include_symlinks: |
| 407 | files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))] |
Mike Frysinger | d3bd32c | 2014-11-24 23:34:29 -0500 | [diff] [blame] | 408 | |
| 409 | if not include_deletes: |
| 410 | files = [x for x in files if x.status != 'D'] |
| 411 | |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 412 | if not include_adds: |
| 413 | files = [x for x in files if x.status != 'A'] |
| 414 | |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 415 | if use_ignore_files: |
| 416 | cache = {} |
| 417 | is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache) |
| 418 | files = [x for x in files if not is_ignored(x)] |
| 419 | |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 420 | if full_details: |
| 421 | # Caller wants the raw objects to parse status/etc... themselves. |
Mike Frysinger | d3bd32c | 2014-11-24 23:34:29 -0500 | [diff] [blame] | 422 | return files |
| 423 | else: |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 424 | # Caller only cares about filenames. |
| 425 | files = [x.dst_file if x.dst_file else x.src_file for x in files] |
| 426 | if relative: |
| 427 | return files |
| 428 | else: |
| 429 | return [os.path.join(path, x) for x in files] |
Peter Ammon | 811f670 | 2014-06-12 15:45:38 -0700 | [diff] [blame] | 430 | |
| 431 | |
Mandeep Singh Baines | b9ed140 | 2011-04-29 15:32:06 -0700 | [diff] [blame] | 432 | def _get_commits(): |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 433 | """Returns a list of commits for this review.""" |
Mike Frysinger | e300c7d | 2019-09-12 23:33:52 -0400 | [diff] [blame] | 434 | cmd = ['git', 'log', '--no-merges', '--format=%H', |
| 435 | '%s..' % _get_upstream_branch()] |
Ryan Cui | 72834d1 | 2011-05-05 14:51:33 -0700 | [diff] [blame] | 436 | return _run_command(cmd).split() |
Mandeep Singh Baines | b9ed140 | 2011-04-29 15:32:06 -0700 | [diff] [blame] | 437 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 438 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 439 | def _get_commit_desc(commit): |
| 440 | """Returns the full commit message of a commit.""" |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 441 | if commit == PRE_SUBMIT: |
| 442 | return '' |
Mike Frysinger | b249665 | 2019-09-12 23:35:46 -0400 | [diff] [blame] | 443 | |
| 444 | # {<commit>: <content>} |
| 445 | cache = CACHE.get_subcache('get_commit_desc') |
| 446 | if commit not in cache: |
Mike Frysinger | 4efdee7 | 2019-11-04 10:57:01 -0500 | [diff] [blame] | 447 | cache[commit] = _run_command(['git', 'log', '--format=%B', |
Mike Frysinger | b249665 | 2019-09-12 23:35:46 -0400 | [diff] [blame] | 448 | commit + '^!']) |
| 449 | return cache[commit] |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 450 | |
| 451 | |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 452 | def _check_lines_in_diff(commit, files, check_callable, error_description): |
| 453 | """Checks given file for errors via the given check. |
| 454 | |
| 455 | This is a convenience function for common per-line checks. It goes through all |
| 456 | files and returns a HookFailure with the error description listing all the |
| 457 | failures. |
| 458 | |
| 459 | Args: |
| 460 | commit: The commit we're working on. |
| 461 | files: The files to check. |
| 462 | check_callable: A callable that takes a line and returns True if this line |
| 463 | _fails_ the check. |
| 464 | error_description: A string describing the error. |
| 465 | """ |
| 466 | errors = [] |
| 467 | for afile in files: |
| 468 | for line_num, line in _get_file_diff(afile, commit): |
| 469 | if check_callable(line): |
| 470 | errors.append('%s, line %s' % (afile, line_num)) |
| 471 | if errors: |
| 472 | return HookFailure(error_description, errors) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 473 | return None |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 474 | |
| 475 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 476 | def _parse_common_inclusion_options(options): |
| 477 | """Parses common hook options for including/excluding files. |
| 478 | |
| 479 | Args: |
| 480 | options: Option string list. |
| 481 | |
| 482 | Returns: |
| 483 | (included, excluded) where each one is a list of regex strings. |
| 484 | """ |
| 485 | parser = argparse.ArgumentParser() |
| 486 | parser.add_argument('--exclude_regex', action='append') |
| 487 | parser.add_argument('--include_regex', action='append') |
| 488 | opts = parser.parse_args(options) |
| 489 | included = opts.include_regex or [] |
| 490 | excluded = opts.exclude_regex or [] |
| 491 | return included, excluded |
| 492 | |
| 493 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 494 | # Common Hooks |
| 495 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 496 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 497 | def _check_no_long_lines(_project, commit, options=()): |
Mike Frysinger | 55f85b5 | 2014-12-18 14:45:21 -0500 | [diff] [blame] | 498 | """Checks there are no lines longer than MAX_LEN in any of the text files.""" |
Keigo Oka | 9732e38 | 2019-06-28 17:44:59 +0900 | [diff] [blame] | 499 | LONG_LINE_OK_PATHS = [ |
| 500 | # Go has no line length limit. |
| 501 | # https://golang.org/doc/effective_go.html#formatting |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 502 | r'.*\.go$', |
Keigo Oka | 9732e38 | 2019-06-28 17:44:59 +0900 | [diff] [blame] | 503 | ] |
Mike Frysinger | 55f85b5 | 2014-12-18 14:45:21 -0500 | [diff] [blame] | 504 | |
Ayato Tokubi | 5aae3f7 | 2020-01-16 17:43:47 +0900 | [diff] [blame] | 505 | DEFAULT_MAX_LENGTHS = [ |
| 506 | # Java's line length limit is 100 chars. |
| 507 | # https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md |
| 508 | (r'.*\.java$', 100), |
| 509 | ] |
| 510 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 511 | MAX_LEN = 80 |
| 512 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 513 | included, excluded = _parse_common_inclusion_options(options) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 514 | files = _filter_files(_get_affected_files(commit), |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 515 | included + COMMON_INCLUDED_PATHS, |
Keigo Oka | 9732e38 | 2019-06-28 17:44:59 +0900 | [diff] [blame] | 516 | excluded + COMMON_EXCLUDED_PATHS + LONG_LINE_OK_PATHS) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 517 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 518 | errors = [] |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 519 | for afile in files: |
George Burgess IV | f9f79eb | 2019-07-09 20:12:55 -0700 | [diff] [blame] | 520 | skip_regexps = ( |
| 521 | r'https?://', |
| 522 | r'^#\s*(define|include|import|pragma|if|ifndef|endif)\b', |
| 523 | ) |
| 524 | |
Ayato Tokubi | 5aae3f7 | 2020-01-16 17:43:47 +0900 | [diff] [blame] | 525 | max_len = MAX_LEN |
| 526 | |
| 527 | for expr, length in DEFAULT_MAX_LENGTHS: |
| 528 | if re.search(expr, afile): |
| 529 | max_len = length |
| 530 | break |
| 531 | |
George Burgess IV | f9f79eb | 2019-07-09 20:12:55 -0700 | [diff] [blame] | 532 | if os.path.basename(afile).startswith('OWNERS'): |
| 533 | # File paths can get long, and there's no way to break them up into |
| 534 | # multiple lines. |
| 535 | skip_regexps += ( |
| 536 | r'^include\b', |
| 537 | r'file:', |
| 538 | ) |
| 539 | |
| 540 | skip_regexps = [re.compile(x) for x in skip_regexps] |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 541 | for line_num, line in _get_file_diff(afile, commit): |
| 542 | # Allow certain lines to exceed the maxlen rule. |
Ayato Tokubi | 5aae3f7 | 2020-01-16 17:43:47 +0900 | [diff] [blame] | 543 | if len(line) <= max_len or any(x.search(line) for x in skip_regexps): |
Jon Salz | 9825593 | 2012-08-18 14:48:02 +0800 | [diff] [blame] | 544 | continue |
| 545 | |
Ayato Tokubi | 5aae3f7 | 2020-01-16 17:43:47 +0900 | [diff] [blame] | 546 | errors.append('%s, line %s, %s chars, over %s chars' % |
| 547 | (afile, line_num, len(line), max_len)) |
Jon Salz | 9825593 | 2012-08-18 14:48:02 +0800 | [diff] [blame] | 548 | if len(errors) == 5: # Just show the first 5 errors. |
| 549 | break |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 550 | |
| 551 | if errors: |
Ayato Tokubi | 5aae3f7 | 2020-01-16 17:43:47 +0900 | [diff] [blame] | 552 | msg = 'Found lines longer than the limit (first 5 shown):' |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 553 | return HookFailure(msg, errors) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 554 | return None |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 555 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 556 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 557 | def _check_no_stray_whitespace(_project, commit, options=()): |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 558 | """Checks that there is no stray whitespace at source lines end.""" |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 559 | included, excluded = _parse_common_inclusion_options(options) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 560 | files = _filter_files(_get_affected_files(commit), |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 561 | included + COMMON_INCLUDED_PATHS, |
| 562 | excluded + COMMON_EXCLUDED_PATHS) |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 563 | return _check_lines_in_diff(commit, files, |
| 564 | lambda line: line.rstrip() != line, |
| 565 | 'Found line ending with white space in:') |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 566 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 567 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 568 | def _check_no_tabs(_project, commit, options=()): |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 569 | """Checks there are no unexpanded tabs.""" |
Mike Frysinger | cd13451 | 2017-10-26 04:36:33 -0400 | [diff] [blame] | 570 | # Don't add entire repos here. Update the PRESUBMIT.cfg in each repo instead. |
| 571 | # We only whitelist known specific filetypes here that show up in all repos. |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 572 | TAB_OK_PATHS = [ |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 573 | r'.*\.ebuild$', |
| 574 | r'.*\.eclass$', |
| 575 | r'.*\.go$', |
| 576 | r'.*/[M|m]akefile$', |
| 577 | r'.*\.mk$', |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 578 | ] |
| 579 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 580 | included, excluded = _parse_common_inclusion_options(options) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 581 | files = _filter_files(_get_affected_files(commit), |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 582 | included + COMMON_INCLUDED_PATHS, |
| 583 | excluded + COMMON_EXCLUDED_PATHS + TAB_OK_PATHS) |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 584 | return _check_lines_in_diff(commit, files, |
| 585 | lambda line: '\t' in line, |
| 586 | 'Found a tab character in:') |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 587 | |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 588 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 589 | def _check_tabbed_indents(_project, commit, options=()): |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 590 | """Checks that indents use tabs only.""" |
| 591 | TABS_REQUIRED_PATHS = [ |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 592 | r'.*\.ebuild$', |
| 593 | r'.*\.eclass$', |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 594 | ] |
| 595 | LEADING_SPACE_RE = re.compile('[\t]* ') |
| 596 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 597 | included, excluded = _parse_common_inclusion_options(options) |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 598 | files = _filter_files(_get_affected_files(commit), |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 599 | included + TABS_REQUIRED_PATHS, |
| 600 | excluded + COMMON_EXCLUDED_PATHS) |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 601 | return _check_lines_in_diff( |
| 602 | commit, files, |
| 603 | lambda line: LEADING_SPACE_RE.match(line) is not None, |
| 604 | 'Found a space in indentation (must be all tabs):') |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 605 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 606 | |
LaMont Jones | 872fe76 | 2020-02-10 15:36:14 -0700 | [diff] [blame] | 607 | def _check_gofmt(_project, commit, options=()): |
Rahul Chaudhry | 09f6137 | 2015-07-31 17:14:26 -0700 | [diff] [blame] | 608 | """Checks that Go files are formatted with gofmt.""" |
LaMont Jones | 872fe76 | 2020-02-10 15:36:14 -0700 | [diff] [blame] | 609 | included, excluded = _parse_common_inclusion_options(options) |
Rahul Chaudhry | 09f6137 | 2015-07-31 17:14:26 -0700 | [diff] [blame] | 610 | errors = [] |
| 611 | files = _filter_files(_get_affected_files(commit, relative=True), |
LaMont Jones | 872fe76 | 2020-02-10 15:36:14 -0700 | [diff] [blame] | 612 | included + [r'\.go$'], |
| 613 | excluded) |
Rahul Chaudhry | 09f6137 | 2015-07-31 17:14:26 -0700 | [diff] [blame] | 614 | |
| 615 | for gofile in files: |
| 616 | contents = _get_file_content(gofile, commit) |
Mike Frysinger | aa7dc94 | 2019-09-25 00:07:24 -0400 | [diff] [blame] | 617 | output = _run_command(cmd=['gofmt', '-l'], input=contents.encode('utf-8'), |
Mike Frysinger | d0c5c8b | 2019-12-17 02:28:26 -0500 | [diff] [blame] | 618 | stderr=subprocess.STDOUT) |
Rahul Chaudhry | 09f6137 | 2015-07-31 17:14:26 -0700 | [diff] [blame] | 619 | if output: |
| 620 | errors.append(gofile) |
| 621 | if errors: |
| 622 | return HookFailure('Files not formatted with gofmt:', errors) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 623 | return None |
Rahul Chaudhry | 09f6137 | 2015-07-31 17:14:26 -0700 | [diff] [blame] | 624 | |
| 625 | |
Fletcher Woodruff | ce1cb1b | 2019-08-16 15:59:32 -0600 | [diff] [blame] | 626 | def _check_rustfmt(_project, commit): |
| 627 | """Checks that Rust files are formatted with rustfmt.""" |
| 628 | errors = [] |
| 629 | files = _filter_files(_get_affected_files(commit, relative=True), |
| 630 | [r'\.rs$']) |
| 631 | |
| 632 | for rustfile in files: |
| 633 | contents = _get_file_content(rustfile, commit) |
Mike Frysinger | aa7dc94 | 2019-09-25 00:07:24 -0400 | [diff] [blame] | 634 | output = _run_command(cmd=['rustfmt'], input=contents.encode('utf-8'), |
Mike Frysinger | d0c5c8b | 2019-12-17 02:28:26 -0500 | [diff] [blame] | 635 | stderr=subprocess.STDOUT) |
Fletcher Woodruff | ce1cb1b | 2019-08-16 15:59:32 -0600 | [diff] [blame] | 636 | if output != contents: |
| 637 | errors.append(rustfile) |
| 638 | if errors: |
| 639 | return HookFailure('Files not formatted with rustfmt: ' |
| 640 | "(run 'cargo fmt' to fix)", errors) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 641 | return None |
Fletcher Woodruff | ce1cb1b | 2019-08-16 15:59:32 -0600 | [diff] [blame] | 642 | |
| 643 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 644 | def _check_change_has_test_field(_project, commit): |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 645 | """Check for a non-empty 'TEST=' field in the commit message.""" |
Mike Frysinger | ed9b2a0 | 2019-12-12 18:52:32 -0500 | [diff] [blame] | 646 | SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 647 | |
Cheng Yueh | b707c52 | 2020-01-02 14:06:59 +0800 | [diff] [blame] | 648 | if not re.search(TEST_FIELD_RE, _get_commit_desc(commit)): |
Mike Frysinger | ed9b2a0 | 2019-12-12 18:52:32 -0500 | [diff] [blame] | 649 | msg = ('Changelist description needs TEST field (after first line)\n%s' % |
| 650 | (SEE_ALSO,)) |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 651 | return HookFailure(msg) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 652 | return None |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 653 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 654 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 655 | def _check_change_has_valid_cq_depend(_project, commit): |
Jason D. Clinton | 299e322 | 2019-05-23 09:42:03 -0600 | [diff] [blame] | 656 | """Check for a correctly formatted Cq-Depend field in the commit message.""" |
Luigi Semenzato | b8c7d7d | 2019-06-03 09:43:21 -0700 | [diff] [blame] | 657 | desc = _get_commit_desc(commit) |
Jason D. Clinton | 299e322 | 2019-05-23 09:42:03 -0600 | [diff] [blame] | 658 | msg = 'Changelist has invalid Cq-Depend target.' |
| 659 | example = 'Example: Cq-Depend: chromium:1234, chrome-internal:2345' |
David James | c3b68b3 | 2013-04-03 09:17:03 -0700 | [diff] [blame] | 660 | try: |
Luigi Semenzato | b8c7d7d | 2019-06-03 09:43:21 -0700 | [diff] [blame] | 661 | patch.GetPaladinDeps(desc) |
David James | c3b68b3 | 2013-04-03 09:17:03 -0700 | [diff] [blame] | 662 | except ValueError as ex: |
| 663 | return HookFailure(msg, [example, str(ex)]) |
Luigi Semenzato | b8c7d7d | 2019-06-03 09:43:21 -0700 | [diff] [blame] | 664 | # Check that Cq-Depend is in the same paragraph as Change-Id. |
Mike Frysinger | e39d0cd | 2019-11-25 13:30:06 -0500 | [diff] [blame] | 665 | msg = 'Cq-Depend is not in the same paragraph as Change-Id.' |
Luigi Semenzato | b8c7d7d | 2019-06-03 09:43:21 -0700 | [diff] [blame] | 666 | paragraphs = desc.split('\n\n') |
| 667 | for paragraph in paragraphs: |
Mike Frysinger | e39d0cd | 2019-11-25 13:30:06 -0500 | [diff] [blame] | 668 | if (re.search(r'^Cq-Depend:', paragraph, re.M) and not |
| 669 | re.search('^Change-Id:', paragraph, re.M)): |
Luigi Semenzato | b8c7d7d | 2019-06-03 09:43:21 -0700 | [diff] [blame] | 670 | return HookFailure(msg) |
Mike Frysinger | e39d0cd | 2019-11-25 13:30:06 -0500 | [diff] [blame] | 671 | |
| 672 | # We no longer support CQ-DEPEND= lines. |
| 673 | if re.search(r'^CQ-DEPEND[=:]', desc, re.M): |
| 674 | return HookFailure( |
| 675 | 'CQ-DEPEND= is no longer supported. Please see:\n' |
| 676 | 'https://chromium.googlesource.com/chromiumos/docs/+/HEAD/' |
| 677 | 'contributing.md#CQ-DEPEND') |
| 678 | |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 679 | return None |
David James | c3b68b3 | 2013-04-03 09:17:03 -0700 | [diff] [blame] | 680 | |
| 681 | |
Bernie Thompson | f8fea99 | 2016-01-14 10:27:18 -0800 | [diff] [blame] | 682 | def _check_change_is_contribution(_project, commit): |
| 683 | """Check that the change is a contribution.""" |
| 684 | NO_CONTRIB = 'not a contribution' |
| 685 | if NO_CONTRIB in _get_commit_desc(commit).lower(): |
| 686 | msg = ('Changelist is not a contribution, this cannot be accepted.\n' |
| 687 | 'Please remove the "%s" text from the commit message.') % NO_CONTRIB |
| 688 | return HookFailure(msg) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 689 | return None |
Bernie Thompson | f8fea99 | 2016-01-14 10:27:18 -0800 | [diff] [blame] | 690 | |
| 691 | |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 692 | def _check_change_has_bug_field(project, commit): |
David McMahon | 8f6553e | 2011-06-10 15:46:36 -0700 | [diff] [blame] | 693 | """Check for a correctly formatted 'BUG=' field in the commit message.""" |
Mike Frysinger | ed9b2a0 | 2019-12-12 18:52:32 -0500 | [diff] [blame] | 694 | SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,) |
| 695 | |
David James | 5c0073d | 2013-04-03 08:48:52 -0700 | [diff] [blame] | 696 | OLD_BUG_RE = r'\nBUG=.*chromium-os' |
| 697 | if re.search(OLD_BUG_RE, _get_commit_desc(commit)): |
| 698 | msg = ('The chromium-os bug tracker is now deprecated. Please use\n' |
| 699 | 'the chromium tracker in your BUG= line now.') |
| 700 | return HookFailure(msg) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 701 | |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 702 | # Android internal and external projects use "Bug: " to track bugs in |
| 703 | # buganizer. |
| 704 | BUG_COLON_REMOTES = ( |
| 705 | 'aosp', |
| 706 | 'goog', |
| 707 | ) |
| 708 | if project.remote in BUG_COLON_REMOTES: |
| 709 | BUG_RE = r'\nBug: ?([Nn]one|\d+)' |
| 710 | if not re.search(BUG_RE, _get_commit_desc(commit)): |
| 711 | msg = ('Changelist description needs BUG field (after first line):\n' |
Mike Frysinger | ed9b2a0 | 2019-12-12 18:52:32 -0500 | [diff] [blame] | 712 | 'Examples:\n' |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 713 | 'Bug: 9999 (for buganizer)\n' |
Mike Frysinger | ed9b2a0 | 2019-12-12 18:52:32 -0500 | [diff] [blame] | 714 | 'BUG=None\n%s' % (SEE_ALSO,)) |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 715 | return HookFailure(msg) |
| 716 | else: |
Jorge Lucangeli Obes | dce214e | 2017-10-25 15:04:39 -0400 | [diff] [blame] | 717 | BUG_RE = r'\nBUG=([Nn]one|(chromium|b):\d+)' |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 718 | if not re.search(BUG_RE, _get_commit_desc(commit)): |
| 719 | msg = ('Changelist description needs BUG field (after first line):\n' |
Mike Frysinger | ed9b2a0 | 2019-12-12 18:52:32 -0500 | [diff] [blame] | 720 | 'Examples:\n' |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 721 | 'BUG=chromium:9999 (for public tracker)\n' |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 722 | 'BUG=b:9999 (for buganizer)\n' |
Mike Frysinger | ed9b2a0 | 2019-12-12 18:52:32 -0500 | [diff] [blame] | 723 | 'BUG=None\n%s' % (SEE_ALSO,)) |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 724 | return HookFailure(msg) |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 725 | |
Cheng Yueh | b707c52 | 2020-01-02 14:06:59 +0800 | [diff] [blame] | 726 | TEST_BEFORE_BUG_RE = TEST_FIELD_RE + r'.*' + BUG_RE |
| 727 | |
| 728 | if re.search(TEST_BEFORE_BUG_RE, _get_commit_desc(commit), re.DOTALL): |
| 729 | msg = ('The BUG field must come before the TEST field.\n%s' % |
| 730 | (SEE_ALSO,)) |
| 731 | return HookFailure(msg) |
| 732 | |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 733 | return None |
| 734 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 735 | |
Jack Neus | 8edbf64 | 2019-07-10 16:08:31 -0600 | [diff] [blame] | 736 | def _check_change_no_include_oem(project, commit): |
| 737 | """Check that the change does not reference OEMs.""" |
| 738 | ALLOWLIST = { |
| 739 | 'chromiumos/platform/ec', |
| 740 | # Used by unit tests. |
| 741 | 'project', |
| 742 | } |
| 743 | if project.name not in ALLOWLIST: |
| 744 | return None |
| 745 | |
Mike Frysinger | bb34a22 | 2019-07-31 14:40:46 -0400 | [diff] [blame] | 746 | TAGS = { |
Jack Neus | 8edbf64 | 2019-07-10 16:08:31 -0600 | [diff] [blame] | 747 | 'Reviewed-on', |
| 748 | 'Reviewed-by', |
| 749 | 'Signed-off-by', |
| 750 | 'Commit-Ready', |
| 751 | 'Tested-by', |
| 752 | 'Commit-Queue', |
Jack Neus | 8edbf64 | 2019-07-10 16:08:31 -0600 | [diff] [blame] | 753 | 'Acked-by', |
| 754 | 'Modified-by', |
| 755 | 'CC', |
| 756 | 'Suggested-by', |
| 757 | 'Reported-by', |
| 758 | 'Acked-for-chrome-by', |
LaMont Jones | 237f3ef | 2020-01-22 10:40:52 -0700 | [diff] [blame] | 759 | 'Cq-Cl-Tag', |
Mike Frysinger | bb34a22 | 2019-07-31 14:40:46 -0400 | [diff] [blame] | 760 | } |
Jack Neus | 8edbf64 | 2019-07-10 16:08:31 -0600 | [diff] [blame] | 761 | |
| 762 | # Ignore tags, which could reasonably contain OEM names |
| 763 | # (e.g. Reviewed-by: foo@oem.corp-partner.google.com). |
Jack Neus | 8edbf64 | 2019-07-10 16:08:31 -0600 | [diff] [blame] | 764 | commit_message = ' '.join( |
Mike Frysinger | bb34a22 | 2019-07-31 14:40:46 -0400 | [diff] [blame] | 765 | x for x in _get_commit_desc(commit).splitlines() |
| 766 | if ':' not in x or x.split(':', 1)[0] not in TAGS) |
| 767 | |
Jack Neus | 8edbf64 | 2019-07-10 16:08:31 -0600 | [diff] [blame] | 768 | commit_message = re.sub(r'[\s_-]+', ' ', commit_message) |
| 769 | |
| 770 | # Exercise caution when expanding these lists. Adding a name |
| 771 | # could indicate a new relationship with a company! |
| 772 | OEMS = ['hp', 'hewlett packard', 'dell', 'lenovo', 'acer', 'asus', 'samsung'] |
| 773 | ODMS = [ |
| 774 | 'bitland', 'compal', 'haier', 'huaqin', 'inventec', 'lg', 'pegatron', |
| 775 | 'pegatron(ems)', 'quanta', 'samsung', 'wistron' |
| 776 | ] |
| 777 | |
| 778 | for name_type, name_list in [('OEM', OEMS), ('ODM', ODMS)]: |
| 779 | # Construct regex |
| 780 | name_re = r'\b(%s)\b' % '|'.join([re.escape(x) for x in name_list]) |
| 781 | matches = [x[0] for x in re.findall(name_re, commit_message, re.IGNORECASE)] |
Mike Frysinger | e52b1bc | 2019-09-16 23:45:41 -0400 | [diff] [blame] | 782 | if matches: |
Jack Neus | 8edbf64 | 2019-07-10 16:08:31 -0600 | [diff] [blame] | 783 | # If there's a match, throw an error. |
| 784 | error_msg = ('Changelist description contains the name of an' |
| 785 | ' %s: "%s".' % (name_type, '","'.join(matches))) |
| 786 | return HookFailure(error_msg) |
| 787 | |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 788 | return None |
| 789 | |
Jack Neus | 8edbf64 | 2019-07-10 16:08:31 -0600 | [diff] [blame] | 790 | |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 791 | def _check_for_uprev(project, commit, project_top=None): |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 792 | """Check that we're not missing a revbump of an ebuild in the given commit. |
| 793 | |
| 794 | If the given commit touches files in a directory that has ebuilds somewhere |
| 795 | up the directory hierarchy, it's very likely that we need an ebuild revbump |
| 796 | in order for those changes to take effect. |
| 797 | |
| 798 | It's not totally trivial to detect a revbump, so at least detect that an |
| 799 | ebuild with a revision number in it was touched. This should handle the |
| 800 | common case where we use a symlink to do the revbump. |
| 801 | |
| 802 | TODO: it would be nice to enhance this hook to: |
| 803 | * Handle cases where people revbump with a slightly different syntax. I see |
| 804 | one ebuild (puppy) that revbumps with _pN. This is a false positive. |
| 805 | * Catches cases where people aren't using symlinks for revbumps. If they |
| 806 | edit a revisioned file directly (and are expected to rename it for revbump) |
| 807 | we'll miss that. Perhaps we could detect that the file touched is a |
| 808 | symlink? |
| 809 | |
| 810 | If a project doesn't use symlinks we'll potentially miss a revbump, but we're |
| 811 | still better off than without this check. |
| 812 | |
| 813 | Args: |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 814 | project: The Project to look at |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 815 | commit: The commit to look at |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 816 | project_top: Top dir to process commits in |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 817 | |
| 818 | Returns: |
| 819 | A HookFailure or None. |
| 820 | """ |
Mike Frysinger | 011af94 | 2014-01-17 16:12:22 -0500 | [diff] [blame] | 821 | # If this is the portage-stable overlay, then ignore the check. It's rare |
| 822 | # that we're doing anything other than importing files from upstream, so |
| 823 | # forcing a rev bump makes no sense. |
| 824 | whitelist = ( |
| 825 | 'chromiumos/overlays/portage-stable', |
| 826 | ) |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 827 | if project.name in whitelist: |
Mike Frysinger | 011af94 | 2014-01-17 16:12:22 -0500 | [diff] [blame] | 828 | return None |
| 829 | |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 830 | def FinalName(obj): |
| 831 | # If the file is being deleted, then the dst_file is not set. |
| 832 | if obj.dst_file is None: |
| 833 | return obj.src_file |
| 834 | else: |
| 835 | return obj.dst_file |
| 836 | |
| 837 | affected_path_objs = _get_affected_files( |
| 838 | commit, include_deletes=True, include_symlinks=True, relative=True, |
| 839 | full_details=True) |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 840 | |
| 841 | # Don't yell about changes to whitelisted files... |
Mike Frysinger | 550c05c | 2019-12-09 18:16:36 -0500 | [diff] [blame] | 842 | whitelist = {'ChangeLog', 'Manifest', 'metadata.xml'} |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 843 | affected_path_objs = [x for x in affected_path_objs |
| 844 | if os.path.basename(FinalName(x)) not in whitelist] |
| 845 | if not affected_path_objs: |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 846 | return None |
| 847 | |
| 848 | # If we've touched any file named with a -rN.ebuild then we'll say we're |
| 849 | # OK right away. See TODO above about enhancing this. |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 850 | touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x)) |
| 851 | for x in affected_path_objs) |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 852 | if touched_revved_ebuild: |
| 853 | return None |
| 854 | |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 855 | # If we're creating new ebuilds from scratch, then we don't need an uprev. |
| 856 | # Find all the dirs that new ebuilds and ignore their files/. |
| 857 | ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs |
| 858 | if FinalName(x).endswith('.ebuild') and x.status == 'A'] |
| 859 | affected_path_objs = [obj for obj in affected_path_objs |
| 860 | if not any(FinalName(obj).startswith(x) |
| 861 | for x in ebuild_dirs)] |
| 862 | if not affected_path_objs: |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 863 | return None |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 864 | |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 865 | # We want to examine the current contents of all directories that are parents |
| 866 | # of files that were touched (up to the top of the project). |
| 867 | # |
| 868 | # ...note: we use the current directory contents even though it may have |
| 869 | # changed since the commit we're looking at. This is just a heuristic after |
| 870 | # all. Worst case we don't flag a missing revbump. |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 871 | if project_top is None: |
| 872 | project_top = os.getcwd() |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 873 | dirs_to_check = set([project_top]) |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 874 | for obj in affected_path_objs: |
| 875 | path = os.path.join(project_top, os.path.dirname(FinalName(obj))) |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 876 | while os.path.exists(path) and not os.path.samefile(path, project_top): |
| 877 | dirs_to_check.add(path) |
| 878 | path = os.path.dirname(path) |
| 879 | |
| 880 | # Look through each directory. If it's got an ebuild in it then we'll |
| 881 | # consider this as a case when we need a revbump. |
Gwendal Grignou | a3086c3 | 2014-12-09 11:17:22 -0800 | [diff] [blame] | 882 | affected_paths = set(os.path.join(project_top, FinalName(x)) |
| 883 | for x in affected_path_objs) |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 884 | for dir_path in dirs_to_check: |
| 885 | contents = os.listdir(dir_path) |
| 886 | ebuilds = [os.path.join(dir_path, path) |
| 887 | for path in contents if path.endswith('.ebuild')] |
| 888 | ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')] |
| 889 | |
C Shapiro | ae157ae | 2017-09-18 16:24:03 -0600 | [diff] [blame] | 890 | affected_paths_under_9999_ebuilds = set() |
| 891 | for affected_path in affected_paths: |
| 892 | for ebuild_9999 in ebuilds_9999: |
| 893 | ebuild_dir = os.path.dirname(ebuild_9999) |
| 894 | if affected_path.startswith(ebuild_dir): |
| 895 | affected_paths_under_9999_ebuilds.add(affected_path) |
| 896 | |
| 897 | # If every file changed exists under a 9999 ebuild, then skip |
| 898 | if len(affected_paths_under_9999_ebuilds) == len(affected_paths): |
| 899 | continue |
| 900 | |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 901 | # If the -9999.ebuild file was touched the bot will uprev for us. |
| 902 | # ...we'll use a simple intersection here as a heuristic... |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 903 | if set(ebuilds_9999) & affected_paths: |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 904 | continue |
| 905 | |
| 906 | if ebuilds: |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 907 | return HookFailure('Changelist probably needs a revbump of an ebuild, ' |
| 908 | 'or a -r1.ebuild symlink if this is a new ebuild:\n' |
| 909 | '%s' % dir_path) |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 910 | |
| 911 | return None |
| 912 | |
| 913 | |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 914 | def _check_ebuild_eapi(project, commit): |
Mike Frysinger | 948284a | 2018-02-01 15:22:56 -0500 | [diff] [blame] | 915 | """Make sure we have people use EAPI=5 or newer with custom ebuilds. |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 916 | |
| 917 | We want to get away from older EAPI's as it makes life confusing and they |
| 918 | have less builtin error checking. |
| 919 | |
| 920 | Args: |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 921 | project: The Project to look at |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 922 | commit: The commit to look at |
| 923 | |
| 924 | Returns: |
| 925 | A HookFailure or None. |
| 926 | """ |
| 927 | # If this is the portage-stable overlay, then ignore the check. It's rare |
Mike Frysinger | cd6adfc | 2014-02-06 01:03:56 -0500 | [diff] [blame] | 928 | # that we're doing anything other than importing files from upstream, and |
| 929 | # we shouldn't be rewriting things fundamentally anyways. |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 930 | whitelist = ( |
| 931 | 'chromiumos/overlays/portage-stable', |
| 932 | ) |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 933 | if project.name in whitelist: |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 934 | return None |
| 935 | |
Mike Frysinger | 948284a | 2018-02-01 15:22:56 -0500 | [diff] [blame] | 936 | BAD_EAPIS = ('0', '1', '2', '3', '4') |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 937 | |
| 938 | get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)') |
| 939 | |
| 940 | ebuilds_re = [r'\.ebuild$'] |
| 941 | ebuilds = _filter_files(_get_affected_files(commit, relative=True), |
| 942 | ebuilds_re) |
| 943 | bad_ebuilds = [] |
| 944 | |
| 945 | for ebuild in ebuilds: |
| 946 | # If the ebuild does not specify an EAPI, it defaults to 0. |
| 947 | eapi = '0' |
| 948 | |
| 949 | lines = _get_file_content(ebuild, commit).splitlines() |
| 950 | if len(lines) == 1: |
| 951 | # This is most likely a symlink, so skip it entirely. |
| 952 | continue |
| 953 | |
| 954 | for line in lines: |
| 955 | m = get_eapi.match(line) |
| 956 | if m: |
| 957 | # Once we hit the first EAPI line in this ebuild, stop processing. |
| 958 | # The spec requires that there only be one and it be first, so |
| 959 | # checking all possible values is pointless. We also assume that |
| 960 | # it's "the" EAPI line and not something in the middle of a heredoc. |
| 961 | eapi = m.group(1) |
| 962 | break |
| 963 | |
| 964 | if eapi in BAD_EAPIS: |
| 965 | bad_ebuilds.append((ebuild, eapi)) |
| 966 | |
| 967 | if bad_ebuilds: |
| 968 | # pylint: disable=C0301 |
| 969 | url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis' |
| 970 | # pylint: enable=C0301 |
| 971 | return HookFailure( |
Mike Frysinger | cd6adfc | 2014-02-06 01:03:56 -0500 | [diff] [blame] | 972 | 'These ebuilds are using old EAPIs. If these are imported from\n' |
| 973 | 'Gentoo, then you may ignore and upload once with the --no-verify\n' |
Mike Frysinger | 948284a | 2018-02-01 15:22:56 -0500 | [diff] [blame] | 974 | 'flag. Otherwise, please update to 5 or newer.\n' |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 975 | '\t%s\n' |
| 976 | 'See this guide for more details:\n%s\n' % |
| 977 | ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url)) |
| 978 | |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 979 | return None |
| 980 | |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 981 | |
Mike Frysinger | 89bdb85 | 2014-02-01 05:26:26 -0500 | [diff] [blame] | 982 | def _check_ebuild_keywords(_project, commit): |
Mike Frysinger | c51ece7 | 2014-01-17 16:23:40 -0500 | [diff] [blame] | 983 | """Make sure we use the new style KEYWORDS when possible in ebuilds. |
| 984 | |
| 985 | If an ebuild generally does not care about the arch it is running on, then |
| 986 | ebuilds should flag it with one of: |
| 987 | KEYWORDS="*" # A stable ebuild. |
| 988 | KEYWORDS="~*" # An unstable ebuild. |
| 989 | KEYWORDS="-* ..." # Is known to only work on specific arches. |
| 990 | |
| 991 | Args: |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 992 | project: The Project to look at |
Mike Frysinger | c51ece7 | 2014-01-17 16:23:40 -0500 | [diff] [blame] | 993 | commit: The commit to look at |
| 994 | |
| 995 | Returns: |
| 996 | A HookFailure or None. |
| 997 | """ |
| 998 | WHITELIST = set(('*', '-*', '~*')) |
| 999 | |
| 1000 | get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"') |
| 1001 | |
Mike Frysinger | 89bdb85 | 2014-02-01 05:26:26 -0500 | [diff] [blame] | 1002 | ebuilds_re = [r'\.ebuild$'] |
| 1003 | ebuilds = _filter_files(_get_affected_files(commit, relative=True), |
| 1004 | ebuilds_re) |
| 1005 | |
Mike Frysinger | 8d42d74 | 2014-09-22 15:50:21 -0400 | [diff] [blame] | 1006 | bad_ebuilds = [] |
Mike Frysinger | c51ece7 | 2014-01-17 16:23:40 -0500 | [diff] [blame] | 1007 | for ebuild in ebuilds: |
Mike Frysinger | 5c9e58d | 2014-09-09 03:32:50 -0400 | [diff] [blame] | 1008 | # We get the full content rather than a diff as the latter does not work |
| 1009 | # on new files (like when adding new ebuilds). |
| 1010 | lines = _get_file_content(ebuild, commit).splitlines() |
| 1011 | for line in lines: |
Mike Frysinger | c51ece7 | 2014-01-17 16:23:40 -0500 | [diff] [blame] | 1012 | m = get_keywords.match(line) |
| 1013 | if m: |
| 1014 | keywords = set(m.group(1).split()) |
| 1015 | if not keywords or WHITELIST - keywords != WHITELIST: |
| 1016 | continue |
| 1017 | |
Mike Frysinger | 8d42d74 | 2014-09-22 15:50:21 -0400 | [diff] [blame] | 1018 | bad_ebuilds.append(ebuild) |
| 1019 | |
| 1020 | if bad_ebuilds: |
| 1021 | return HookFailure( |
| 1022 | '%s\n' |
| 1023 | 'Please update KEYWORDS to use a glob:\n' |
| 1024 | 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n' |
| 1025 | ' KEYWORDS="*"\n' |
| 1026 | 'If the ebuild should be marked unstable (normal for ' |
| 1027 | 'cros-workon / 9999 ebuilds):\n' |
| 1028 | ' KEYWORDS="~*"\n' |
Mike Frysinger | de8efea | 2015-05-17 03:42:26 -0400 | [diff] [blame] | 1029 | 'If the ebuild needs to be marked for only specific arches, ' |
Mike Frysinger | 8d42d74 | 2014-09-22 15:50:21 -0400 | [diff] [blame] | 1030 | 'then use -* like so:\n' |
| 1031 | ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds)) |
Mike Frysinger | c51ece7 | 2014-01-17 16:23:40 -0500 | [diff] [blame] | 1032 | |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1033 | return None |
| 1034 | |
Mike Frysinger | c51ece7 | 2014-01-17 16:23:40 -0500 | [diff] [blame] | 1035 | |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 1036 | def _check_ebuild_licenses(_project, commit): |
| 1037 | """Check if the LICENSE field in the ebuild is correct.""" |
Brian Norris | 7a610e8 | 2016-02-17 12:24:54 -0800 | [diff] [blame] | 1038 | affected_paths = _get_affected_files(commit, relative=True) |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 1039 | touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')] |
| 1040 | |
| 1041 | # A list of licenses to ignore for now. |
Yu-Ju Hong | c0963fa | 2014-03-03 12:36:52 -0800 | [diff] [blame] | 1042 | LICENSES_IGNORE = ['||', '(', ')'] |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 1043 | |
| 1044 | for ebuild in touched_ebuilds: |
| 1045 | # Skip virutal packages. |
| 1046 | if ebuild.split('/')[-3] == 'virtual': |
| 1047 | continue |
| 1048 | |
Alex Klein | b595352 | 2018-08-03 11:44:21 -0600 | [diff] [blame] | 1049 | # e.g. path/to/overlay/category/package/package.ebuild -> path/to/overlay |
| 1050 | overlay_path = os.sep.join(ebuild.split(os.sep)[:-3]) |
| 1051 | |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 1052 | try: |
Brian Norris | 7a610e8 | 2016-02-17 12:24:54 -0800 | [diff] [blame] | 1053 | ebuild_content = _get_file_content(ebuild, commit) |
Alex Klein | b595352 | 2018-08-03 11:44:21 -0600 | [diff] [blame] | 1054 | license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content, |
| 1055 | overlay_path) |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 1056 | except ValueError as e: |
Mike Frysinger | f1ee2bf | 2019-09-16 23:47:33 -0400 | [diff] [blame] | 1057 | return HookFailure(str(e), [ebuild]) |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 1058 | |
| 1059 | # Also ignore licenses ending with '?' |
| 1060 | for license_type in [x for x in license_types |
| 1061 | if x not in LICENSES_IGNORE and not x.endswith('?')]: |
| 1062 | try: |
Alex Klein | b595352 | 2018-08-03 11:44:21 -0600 | [diff] [blame] | 1063 | licenses_lib.Licensing.FindLicenseType(license_type, |
| 1064 | overlay_path=overlay_path) |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 1065 | except AssertionError as e: |
Mike Frysinger | f1ee2bf | 2019-09-16 23:47:33 -0400 | [diff] [blame] | 1066 | return HookFailure(str(e), [ebuild]) |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 1067 | |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1068 | return None |
| 1069 | |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 1070 | |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 1071 | def _check_ebuild_virtual_pv(project, commit): |
| 1072 | """Enforce the virtual PV policies.""" |
| 1073 | # If this is the portage-stable overlay, then ignore the check. |
| 1074 | # We want to import virtuals as-is from upstream Gentoo. |
| 1075 | whitelist = ( |
| 1076 | 'chromiumos/overlays/portage-stable', |
| 1077 | ) |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 1078 | if project.name in whitelist: |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 1079 | return None |
| 1080 | |
| 1081 | # We assume the repo name is the same as the dir name on disk. |
| 1082 | # It would be dumb to not have them match though. |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 1083 | project_base = os.path.basename(project.name) |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 1084 | |
| 1085 | is_variant = lambda x: x.startswith('overlay-variant-') |
| 1086 | is_board = lambda x: x.startswith('overlay-') |
Douglas Anderson | b43df7f | 2018-06-25 13:40:50 -0700 | [diff] [blame] | 1087 | is_baseboard = lambda x: x.startswith('baseboard-') |
| 1088 | is_chipset = lambda x: x.startswith('chipset-') |
| 1089 | is_project = lambda x: x.startswith('project-') |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 1090 | is_private = lambda x: x.endswith('-private') |
| 1091 | |
Douglas Anderson | b43df7f | 2018-06-25 13:40:50 -0700 | [diff] [blame] | 1092 | is_special_overlay = lambda x: (is_board(x) or is_chipset(x) or |
| 1093 | is_baseboard(x) or is_project(x)) |
| 1094 | |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 1095 | get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$') |
| 1096 | |
| 1097 | ebuilds_re = [r'\.ebuild$'] |
| 1098 | ebuilds = _filter_files(_get_affected_files(commit, relative=True), |
| 1099 | ebuilds_re) |
| 1100 | bad_ebuilds = [] |
| 1101 | |
| 1102 | for ebuild in ebuilds: |
| 1103 | m = get_pv.match(ebuild) |
| 1104 | if m: |
| 1105 | overlay = m.group(1) |
Douglas Anderson | b43df7f | 2018-06-25 13:40:50 -0700 | [diff] [blame] | 1106 | if not overlay or not is_special_overlay(overlay): |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 1107 | overlay = project_base |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 1108 | |
| 1109 | pv = m.group(3).split('-', 1)[0] |
| 1110 | |
Bernie Thompson | e5ee182 | 2016-01-12 14:22:23 -0800 | [diff] [blame] | 1111 | # Virtual versions >= 4 are special cases used above the standard |
| 1112 | # versioning structure, e.g. if one has a board inheriting a board. |
| 1113 | if float(pv) >= 4: |
| 1114 | want_pv = pv |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 1115 | elif is_board(overlay): |
Douglas Anderson | b43df7f | 2018-06-25 13:40:50 -0700 | [diff] [blame] | 1116 | if is_private(overlay): |
| 1117 | want_pv = '3.5' if is_variant(overlay) else '3' |
| 1118 | elif is_board(overlay): |
| 1119 | want_pv = '2.5' if is_variant(overlay) else '2' |
| 1120 | elif is_baseboard(overlay): |
| 1121 | want_pv = '1.9' |
| 1122 | elif is_chipset(overlay): |
| 1123 | want_pv = '1.8' |
| 1124 | elif is_project(overlay): |
| 1125 | want_pv = '1.7' if is_private(overlay) else '1.5' |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 1126 | else: |
| 1127 | want_pv = '1' |
| 1128 | |
| 1129 | if pv != want_pv: |
| 1130 | bad_ebuilds.append((ebuild, pv, want_pv)) |
| 1131 | |
| 1132 | if bad_ebuilds: |
| 1133 | # pylint: disable=C0301 |
| 1134 | url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management' |
| 1135 | # pylint: enable=C0301 |
| 1136 | return HookFailure( |
| 1137 | 'These virtuals have incorrect package versions (PVs). Please adjust:\n' |
| 1138 | '\t%s\n' |
| 1139 | 'If this is an upstream Gentoo virtual, then you may ignore this\n' |
| 1140 | 'check (and re-run w/--no-verify). Otherwise, please see this\n' |
| 1141 | 'page for more details:\n%s\n' % |
| 1142 | ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x |
| 1143 | for x in bad_ebuilds]), url)) |
| 1144 | |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1145 | return None |
| 1146 | |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 1147 | |
Daniel Erat | 9d203ff | 2015-02-17 10:12:21 -0700 | [diff] [blame] | 1148 | def _check_portage_make_use_var(_project, commit): |
| 1149 | """Verify that $USE is set correctly in make.conf and make.defaults.""" |
| 1150 | files = _filter_files(_get_affected_files(commit, relative=True), |
| 1151 | [r'(^|/)make.(conf|defaults)$']) |
| 1152 | |
| 1153 | errors = [] |
| 1154 | for path in files: |
| 1155 | basename = os.path.basename(path) |
| 1156 | |
| 1157 | # Has a USE= line already been encountered in this file? |
| 1158 | saw_use = False |
| 1159 | |
| 1160 | for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1): |
| 1161 | if not line.startswith('USE='): |
| 1162 | continue |
| 1163 | |
| 1164 | preserves_use = '${USE}' in line or '$USE' in line |
| 1165 | |
| 1166 | if (basename == 'make.conf' or |
| 1167 | (basename == 'make.defaults' and saw_use)) and not preserves_use: |
| 1168 | errors.append('%s:%d: missing ${USE}' % (path, i)) |
| 1169 | elif basename == 'make.defaults' and not saw_use and preserves_use: |
| 1170 | errors.append('%s:%d: ${USE} referenced in initial declaration' % |
| 1171 | (path, i)) |
| 1172 | |
| 1173 | saw_use = True |
| 1174 | |
| 1175 | if errors: |
| 1176 | return HookFailure( |
| 1177 | 'One or more Portage make files appear to set USE incorrectly.\n' |
| 1178 | '\n' |
| 1179 | 'All USE assignments in make.conf and all assignments after the\n' |
| 1180 | 'initial declaration in make.defaults should contain "${USE}" to\n' |
| 1181 | 'preserve previously-set flags.\n' |
| 1182 | '\n' |
| 1183 | 'The initial USE declaration in make.defaults should not contain\n' |
| 1184 | '"${USE}".\n', |
| 1185 | errors) |
| 1186 | |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1187 | return None |
| 1188 | |
Daniel Erat | 9d203ff | 2015-02-17 10:12:21 -0700 | [diff] [blame] | 1189 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 1190 | def _check_change_has_proper_changeid(_project, commit): |
Mandeep Singh Baines | a23eb5f | 2011-05-04 13:43:25 -0700 | [diff] [blame] | 1191 | """Verify that Change-ID is present in last paragraph of commit message.""" |
Mike Frysinger | 4a22bf0 | 2014-10-31 13:53:35 -0400 | [diff] [blame] | 1192 | CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n' |
Mandeep Singh Baines | a23eb5f | 2011-05-04 13:43:25 -0700 | [diff] [blame] | 1193 | desc = _get_commit_desc(commit) |
Mike Frysinger | 4a22bf0 | 2014-10-31 13:53:35 -0400 | [diff] [blame] | 1194 | m = re.search(CHANGE_ID_RE, desc) |
Mike Frysinger | 02b88bd | 2014-11-21 00:29:38 -0500 | [diff] [blame] | 1195 | if not m: |
Vadim Bendebury | 20532ba | 2017-05-23 17:26:15 -0700 | [diff] [blame] | 1196 | return HookFailure('Last paragraph of description must include Change-Id.') |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 1197 | |
Vadim Bendebury | 20532ba | 2017-05-23 17:26:15 -0700 | [diff] [blame] | 1198 | # S-o-b tags always allowed to follow Change-ID. |
LaMont Jones | 237f3ef | 2020-01-22 10:40:52 -0700 | [diff] [blame] | 1199 | allowed_tags = ['Signed-off-by', 'Cq-Cl-Tag'] |
Vadim Bendebury | 20532ba | 2017-05-23 17:26:15 -0700 | [diff] [blame] | 1200 | |
Mike Frysinger | 02b88bd | 2014-11-21 00:29:38 -0500 | [diff] [blame] | 1201 | end = desc[m.end():].strip().splitlines() |
Vadim Bendebury | 6504aea | 2017-09-13 18:35:49 -0700 | [diff] [blame] | 1202 | cherry_pick_marker = 'cherry picked from commit' |
| 1203 | |
| 1204 | if end and cherry_pick_marker in end[-1]: |
Vadim Bendebury | 20532ba | 2017-05-23 17:26:15 -0700 | [diff] [blame] | 1205 | # Cherry picked patches allow more tags in the last paragraph. |
Vadim Bendebury | 6504aea | 2017-09-13 18:35:49 -0700 | [diff] [blame] | 1206 | allowed_tags += ['Commit-Queue', 'Commit-Ready', 'Reviewed-by', |
| 1207 | 'Reviewed-on', 'Tested-by'] |
Vadim Bendebury | 20532ba | 2017-05-23 17:26:15 -0700 | [diff] [blame] | 1208 | end = end[:-1] |
| 1209 | |
Vadim Bendebury | 6504aea | 2017-09-13 18:35:49 -0700 | [diff] [blame] | 1210 | # Note that descriptions could have multiple cherry pick markers. |
| 1211 | tag_search = r'^(%s:|\(%s) ' % (':|'.join(allowed_tags), cherry_pick_marker) |
Vadim Bendebury | 20532ba | 2017-05-23 17:26:15 -0700 | [diff] [blame] | 1212 | |
| 1213 | if [x for x in end if not re.search(tag_search, x)]: |
| 1214 | return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' % |
| 1215 | ':", "'.join(allowed_tags)) |
Mike Frysinger | 02b88bd | 2014-11-21 00:29:38 -0500 | [diff] [blame] | 1216 | |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1217 | return None |
| 1218 | |
Mandeep Singh Baines | a23eb5f | 2011-05-04 13:43:25 -0700 | [diff] [blame] | 1219 | |
Mike Frysinger | 36b2ebc | 2014-10-31 14:02:03 -0400 | [diff] [blame] | 1220 | def _check_commit_message_style(_project, commit): |
| 1221 | """Verify that the commit message matches our style. |
| 1222 | |
| 1223 | We do not check for BUG=/TEST=/etc... lines here as that is handled by other |
| 1224 | commit hooks. |
| 1225 | """ |
Mike Frysinger | ed9b2a0 | 2019-12-12 18:52:32 -0500 | [diff] [blame] | 1226 | SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,) |
Mike Frysinger | 4efdee7 | 2019-11-04 10:57:01 -0500 | [diff] [blame] | 1227 | |
Mike Frysinger | 36b2ebc | 2014-10-31 14:02:03 -0400 | [diff] [blame] | 1228 | desc = _get_commit_desc(commit) |
| 1229 | |
| 1230 | # The first line should be by itself. |
| 1231 | lines = desc.splitlines() |
| 1232 | if len(lines) > 1 and lines[1]: |
Mike Frysinger | 4efdee7 | 2019-11-04 10:57:01 -0500 | [diff] [blame] | 1233 | return HookFailure('The second line of the commit message must be blank.' |
| 1234 | '\n%s' % (SEE_ALSO,)) |
Mike Frysinger | 36b2ebc | 2014-10-31 14:02:03 -0400 | [diff] [blame] | 1235 | |
| 1236 | # The first line should be one sentence. |
| 1237 | if '. ' in lines[0]: |
Mike Frysinger | 4efdee7 | 2019-11-04 10:57:01 -0500 | [diff] [blame] | 1238 | return HookFailure('The first line cannot be more than one sentence.\n%s' % |
| 1239 | (SEE_ALSO,)) |
Mike Frysinger | 36b2ebc | 2014-10-31 14:02:03 -0400 | [diff] [blame] | 1240 | |
| 1241 | # The first line cannot be too long. |
| 1242 | MAX_FIRST_LINE_LEN = 100 |
| 1243 | if len(lines[0]) > MAX_FIRST_LINE_LEN: |
Mike Frysinger | 4efdee7 | 2019-11-04 10:57:01 -0500 | [diff] [blame] | 1244 | return HookFailure('The first line must be less than %i chars.\n%s' % |
| 1245 | (MAX_FIRST_LINE_LEN, SEE_ALSO)) |
Mike Frysinger | 36b2ebc | 2014-10-31 14:02:03 -0400 | [diff] [blame] | 1246 | |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1247 | return None |
| 1248 | |
Mike Frysinger | 36b2ebc | 2014-10-31 14:02:03 -0400 | [diff] [blame] | 1249 | |
Filipe Brandenburger | 4b542b1 | 2015-10-09 12:46:31 -0700 | [diff] [blame] | 1250 | def _check_cros_license(_project, commit, options=()): |
Alex Deymo | f5792ce | 2015-08-24 22:50:08 -0700 | [diff] [blame] | 1251 | """Verifies the Chromium OS license/copyright header. |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 1252 | |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1253 | Should be following the spec: |
| 1254 | http://dev.chromium.org/developers/coding-style#TOC-File-headers |
| 1255 | """ |
| 1256 | # For older years, be a bit more flexible as our policy says leave them be. |
| 1257 | LICENSE_HEADER = ( |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 1258 | r'.*Copyright(?: \(c\))? (20[0-9]{2})(?:-20[0-9]{2})? The Chromium OS ' |
| 1259 | r'Authors\. All rights reserved\.\n' |
Brian Norris | 68838dd | 2018-09-26 18:30:24 -0700 | [diff] [blame] | 1260 | r'.*Use of this source code is governed by a BSD-style license that can ' |
Mike Frysinger | b81102f | 2014-11-21 00:33:35 -0500 | [diff] [blame] | 1261 | r'be\n' |
Brian Norris | 68838dd | 2018-09-26 18:30:24 -0700 | [diff] [blame] | 1262 | r'.*found in the LICENSE file\.' |
Mike Frysinger | b81102f | 2014-11-21 00:33:35 -0500 | [diff] [blame] | 1263 | r'\n' |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1264 | ) |
| 1265 | license_re = re.compile(LICENSE_HEADER, re.MULTILINE) |
| 1266 | |
| 1267 | # For newer years, be stricter. |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 1268 | BAD_COPYRIGHT_LINE = ( |
Brian Norris | 68838dd | 2018-09-26 18:30:24 -0700 | [diff] [blame] | 1269 | r'.*Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. ' |
Mike Frysinger | b81102f | 2014-11-21 00:33:35 -0500 | [diff] [blame] | 1270 | r'All rights reserved\.' r'\n' |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1271 | ) |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 1272 | bad_copyright_re = re.compile(BAD_COPYRIGHT_LINE) |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1273 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 1274 | included, excluded = _parse_common_inclusion_options(options) |
Filipe Brandenburger | 4b542b1 | 2015-10-09 12:46:31 -0700 | [diff] [blame] | 1275 | |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1276 | bad_files = [] |
| 1277 | bad_copyright_files = [] |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 1278 | bad_year_files = [] |
| 1279 | |
Ken Turner | d07564b | 2018-02-08 17:57:59 +1100 | [diff] [blame] | 1280 | files = _filter_files( |
| 1281 | _get_affected_files(commit, relative=True), |
| 1282 | included + COMMON_INCLUDED_PATHS, |
| 1283 | excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS) |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 1284 | existing_files = set(_get_affected_files(commit, relative=True, |
| 1285 | include_adds=False)) |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1286 | |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 1287 | current_year = str(datetime.datetime.now().year) |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1288 | for f in files: |
| 1289 | contents = _get_file_content(f, commit) |
| 1290 | if not contents: |
| 1291 | # Ignore empty files. |
| 1292 | continue |
| 1293 | |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 1294 | m = license_re.search(contents) |
| 1295 | if not m: |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1296 | bad_files.append(f) |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 1297 | elif bad_copyright_re.search(contents): |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1298 | bad_copyright_files.append(f) |
| 1299 | |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 1300 | if m and f not in existing_files: |
| 1301 | year = m.group(1) |
| 1302 | if year != current_year: |
| 1303 | bad_year_files.append(f) |
| 1304 | |
| 1305 | errors = [] |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1306 | if bad_files: |
| 1307 | msg = '%s:\n%s\n%s' % ( |
| 1308 | 'License must match', license_re.pattern, |
| 1309 | 'Found a bad header in these files:') |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 1310 | errors.append(HookFailure(msg, bad_files)) |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1311 | if bad_copyright_files: |
| 1312 | msg = 'Do not use (c) in copyright headers in new files:' |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 1313 | errors.append(HookFailure(msg, bad_copyright_files)) |
| 1314 | if bad_year_files: |
| 1315 | msg = 'Use current year (%s) in copyright headers in new files:' % ( |
| 1316 | current_year) |
| 1317 | errors.append(HookFailure(msg, bad_year_files)) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 1318 | |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 1319 | return errors |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 1320 | |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1321 | |
Amin Hassani | 391efa9 | 2018-01-26 17:58:05 -0800 | [diff] [blame] | 1322 | def _check_aosp_license(_project, commit, options=()): |
Alex Deymo | f5792ce | 2015-08-24 22:50:08 -0700 | [diff] [blame] | 1323 | """Verifies the AOSP license/copyright header. |
| 1324 | |
| 1325 | AOSP uses the Apache2 License: |
| 1326 | https://source.android.com/source/licenses.html |
| 1327 | """ |
| 1328 | LICENSE_HEADER = ( |
| 1329 | r"""^[#/\*]* |
| 1330 | [#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project |
| 1331 | [#/\*]* ? |
| 1332 | [#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\); |
| 1333 | [#/\*]* ?you may not use this file except in compliance with the License\. |
| 1334 | [#/\*]* ?You may obtain a copy of the License at |
| 1335 | [#/\*]* ? |
| 1336 | [#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0 |
| 1337 | [#/\*]* ? |
| 1338 | [#/\*]* ?Unless required by applicable law or agreed to in writing, software |
| 1339 | [#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS, |
| 1340 | [#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """ |
| 1341 | r"""implied\. |
| 1342 | [#/\*]* ?See the License for the specific language governing permissions and |
| 1343 | [#/\*]* ?limitations under the License\. |
| 1344 | [#/\*]*$ |
| 1345 | """ |
| 1346 | ) |
| 1347 | license_re = re.compile(LICENSE_HEADER, re.MULTILINE) |
| 1348 | |
Amin Hassani | 391efa9 | 2018-01-26 17:58:05 -0800 | [diff] [blame] | 1349 | included, excluded = _parse_common_inclusion_options(options) |
| 1350 | |
Ken Turner | d07564b | 2018-02-08 17:57:59 +1100 | [diff] [blame] | 1351 | files = _filter_files( |
| 1352 | _get_affected_files(commit, relative=True), |
| 1353 | included + COMMON_INCLUDED_PATHS, |
| 1354 | excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS) |
Alex Deymo | f5792ce | 2015-08-24 22:50:08 -0700 | [diff] [blame] | 1355 | |
| 1356 | bad_files = [] |
| 1357 | for f in files: |
| 1358 | contents = _get_file_content(f, commit) |
| 1359 | if not contents: |
| 1360 | # Ignore empty files. |
| 1361 | continue |
| 1362 | |
| 1363 | if not license_re.search(contents): |
| 1364 | bad_files.append(f) |
| 1365 | |
| 1366 | if bad_files: |
| 1367 | msg = ('License must match:\n%s\nFound a bad header in these files:' % |
| 1368 | license_re.pattern) |
| 1369 | return HookFailure(msg, bad_files) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1370 | return None |
Alex Deymo | f5792ce | 2015-08-24 22:50:08 -0700 | [diff] [blame] | 1371 | |
| 1372 | |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1373 | def _check_layout_conf(_project, commit): |
| 1374 | """Verifies the metadata/layout.conf file.""" |
| 1375 | repo_name = 'profiles/repo_name' |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1376 | repo_names = [] |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1377 | layout_path = 'metadata/layout.conf' |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1378 | layout_paths = [] |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1379 | |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1380 | # Handle multiple overlays in a single commit (like the public tree). |
| 1381 | for f in _get_affected_files(commit, relative=True): |
| 1382 | if f.endswith(repo_name): |
| 1383 | repo_names.append(f) |
| 1384 | elif f.endswith(layout_path): |
| 1385 | layout_paths.append(f) |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1386 | |
| 1387 | # Disallow new repos with the repo_name file. |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1388 | if repo_names: |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1389 | return HookFailure('%s: use "repo-name" in %s instead' % |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1390 | (repo_names, layout_path)) |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1391 | |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1392 | # Gather all the errors in one pass so we show one full message. |
| 1393 | all_errors = {} |
| 1394 | for layout_path in layout_paths: |
| 1395 | all_errors[layout_path] = errors = [] |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1396 | |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1397 | # Make sure the config file is sorted. |
| 1398 | data = [x for x in _get_file_content(layout_path, commit).splitlines() |
| 1399 | if x and x[0] != '#'] |
| 1400 | if sorted(data) != data: |
| 1401 | errors += ['keep lines sorted'] |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1402 | |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1403 | # Require people to set specific values all the time. |
| 1404 | settings = ( |
| 1405 | # TODO: Enable this for everyone. http://crbug.com/408038 |
Shuhei Takahashi | 3cbb8dd | 2019-10-29 12:37:11 +0900 | [diff] [blame] | 1406 | # ('fast caching', 'cache-format = md5-dict'), |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1407 | ('fast manifests', 'thin-manifests = true'), |
Mike Frysinger | d773452 | 2015-02-26 16:12:43 -0500 | [diff] [blame] | 1408 | ('extra features', 'profile-formats = portage-2 profile-default-eapi'), |
| 1409 | ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'), |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1410 | ) |
| 1411 | for reason, line in settings: |
| 1412 | if line not in data: |
| 1413 | errors += ['enable %s with: %s' % (reason, line)] |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1414 | |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1415 | # Require one of these settings. |
Mike Frysinger | 5fae62d | 2015-11-11 20:12:15 -0500 | [diff] [blame] | 1416 | if 'use-manifests = strict' not in data: |
| 1417 | errors += ['enable file checking with: use-manifests = strict'] |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1418 | |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1419 | # Require repo-name to be set. |
Mike Frysinger | 324cf68 | 2014-09-22 15:52:50 -0400 | [diff] [blame] | 1420 | for line in data: |
| 1421 | if line.startswith('repo-name = '): |
| 1422 | break |
| 1423 | else: |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1424 | errors += ['set the board name with: repo-name = $BOARD'] |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1425 | |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1426 | # Summarize all the errors we saw (if any). |
| 1427 | lines = '' |
| 1428 | for layout_path, errors in all_errors.items(): |
| 1429 | if errors: |
| 1430 | lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors) |
| 1431 | if lines: |
| 1432 | lines = 'See the portage(5) man page for layout.conf details' + lines + '\n' |
| 1433 | return HookFailure(lines) |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1434 | |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1435 | return None |
| 1436 | |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1437 | |
Keigo Oka | 4a09bd9 | 2019-05-07 14:01:00 +0900 | [diff] [blame] | 1438 | def _check_no_new_gyp(_project, commit): |
| 1439 | """Verifies no project starts to use GYP.""" |
| 1440 | whitelist = [ |
Keigo Oka | 4a09bd9 | 2019-05-07 14:01:00 +0900 | [diff] [blame] | 1441 | 'chromeos/ap', |
| 1442 | 'chromeos/ap-daemons', |
Keigo Oka | 150a6fd | 2019-06-04 11:30:25 +0900 | [diff] [blame] | 1443 | 'chromeos/ap/security', |
| 1444 | 'chromeos/ap/wireless', |
Keigo Oka | 4a09bd9 | 2019-05-07 14:01:00 +0900 | [diff] [blame] | 1445 | 'chromeos/platform/actions', |
Keigo Oka | 4a09bd9 | 2019-05-07 14:01:00 +0900 | [diff] [blame] | 1446 | 'chromeos/platform/drivefs-google3', |
| 1447 | 'chromeos/platform/experimental-touch-fw', |
Keigo Oka | 4a09bd9 | 2019-05-07 14:01:00 +0900 | [diff] [blame] | 1448 | 'chromeos/thermald', |
Keigo Oka | 4a09bd9 | 2019-05-07 14:01:00 +0900 | [diff] [blame] | 1449 | 'chromiumos/platform2', |
Keigo Oka | 4a09bd9 | 2019-05-07 14:01:00 +0900 | [diff] [blame] | 1450 | 'weave/libweave', |
| 1451 | ] |
| 1452 | if _project.name in whitelist: |
| 1453 | return None |
| 1454 | |
| 1455 | gypfiles = _filter_files( |
| 1456 | _get_affected_files(commit, include_symlinks=True, relative=True), |
| 1457 | [r'\.gyp$']) |
| 1458 | |
| 1459 | if gypfiles: |
| 1460 | return HookFailure('GYP is deprecated and not allowed in a new project:', |
| 1461 | gypfiles) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1462 | return None |
Keigo Oka | 4a09bd9 | 2019-05-07 14:01:00 +0900 | [diff] [blame] | 1463 | |
| 1464 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 1465 | # Project-specific hooks |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 1466 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 1467 | |
Luis Hector Chavez | b50391d | 2017-09-26 15:48:15 -0700 | [diff] [blame] | 1468 | def _check_clang_format(_project, commit, options=()): |
| 1469 | """Runs clang-format on the given project""" |
| 1470 | hooks_dir = _get_hooks_dir() |
| 1471 | options = list(options) |
| 1472 | if commit == PRE_SUBMIT: |
| 1473 | options.append('--commit=HEAD') |
| 1474 | else: |
| 1475 | options.extend(['--commit', commit]) |
Brian Norris | 0c62a14 | 2018-12-11 13:24:29 -0800 | [diff] [blame] | 1476 | cmd = [os.path.join(hooks_dir, 'clang-format.py')] + options |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 1477 | cmd_result = cros_build_lib.run(cmd, |
| 1478 | print_cmd=False, |
| 1479 | stdout=True, |
| 1480 | encoding='utf-8', |
| 1481 | errors='replace', |
Mike Frysinger | d0c5c8b | 2019-12-17 02:28:26 -0500 | [diff] [blame] | 1482 | stderr=subprocess.STDOUT, |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 1483 | check=False) |
Luis Hector Chavez | b50391d | 2017-09-26 15:48:15 -0700 | [diff] [blame] | 1484 | if cmd_result.returncode: |
| 1485 | return HookFailure('clang-format.py errors/warnings\n\n' + |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 1486 | cmd_result.stdout) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1487 | return None |
Luis Hector Chavez | b50391d | 2017-09-26 15:48:15 -0700 | [diff] [blame] | 1488 | |
| 1489 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 1490 | def _run_checkpatch(_project, commit, options=()): |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 1491 | """Runs checkpatch.pl on the given project""" |
| 1492 | hooks_dir = _get_hooks_dir() |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1493 | options = list(options) |
| 1494 | if commit == PRE_SUBMIT: |
| 1495 | # The --ignore option must be present and include 'MISSING_SIGN_OFF' in |
| 1496 | # this case. |
| 1497 | options.append('--ignore=MISSING_SIGN_OFF') |
Filipe Brandenburger | 28d48d6 | 2015-10-07 09:48:54 -0700 | [diff] [blame] | 1498 | # Always ignore the check for the MAINTAINERS file. We do not track that |
| 1499 | # information on that file in our source trees, so let's suppress the |
| 1500 | # warning. |
| 1501 | options.append('--ignore=FILE_PATH_CHANGES') |
Filipe Brandenburger | ce97832 | 2015-10-09 10:04:15 -0700 | [diff] [blame] | 1502 | # Do not complain about the Change-Id: fields, since we use Gerrit. |
| 1503 | # Upstream does not want those lines (since they do not use Gerrit), but |
| 1504 | # we always do, so disable the check globally. |
Daisuke Nojiri | 4844f89 | 2015-10-08 09:54:33 -0700 | [diff] [blame] | 1505 | options.append('--ignore=GERRIT_CHANGE_ID') |
Brian Norris | 0c62a14 | 2018-12-11 13:24:29 -0800 | [diff] [blame] | 1506 | cmd = [os.path.join(hooks_dir, 'checkpatch.pl')] + options + ['-'] |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 1507 | cmd_result = cros_build_lib.run( |
| 1508 | cmd, print_cmd=False, input=_get_patch(commit).encode('utf-8'), |
Mike Frysinger | d0c5c8b | 2019-12-17 02:28:26 -0500 | [diff] [blame] | 1509 | stdout=True, stderr=subprocess.STDOUT, check=False, encoding='utf-8', |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 1510 | errors='replace') |
Rahul Chaudhry | 0e51534 | 2015-08-07 12:00:43 -0700 | [diff] [blame] | 1511 | if cmd_result.returncode: |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 1512 | return HookFailure('checkpatch.pl errors/warnings\n\n' + cmd_result.stdout) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1513 | return None |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 1514 | |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 1515 | |
Brian Norris | 23c62e9 | 2018-11-14 12:25:51 -0800 | [diff] [blame] | 1516 | def _run_kerneldoc(_project, commit, options=()): |
| 1517 | """Runs kernel-doc validator on the given project""" |
| 1518 | included, excluded = _parse_common_inclusion_options(options) |
| 1519 | files = _filter_files(_get_affected_files(commit, relative=True), |
| 1520 | included, excluded) |
| 1521 | if files: |
| 1522 | hooks_dir = _get_hooks_dir() |
Brian Norris | 0c62a14 | 2018-12-11 13:24:29 -0800 | [diff] [blame] | 1523 | cmd = [os.path.join(hooks_dir, 'kernel-doc'), '-none'] + files |
Mike Frysinger | d0c5c8b | 2019-12-17 02:28:26 -0500 | [diff] [blame] | 1524 | output = _run_command(cmd, stderr=subprocess.STDOUT) |
Brian Norris | 23c62e9 | 2018-11-14 12:25:51 -0800 | [diff] [blame] | 1525 | if output: |
Brian Norris | 0c62a14 | 2018-12-11 13:24:29 -0800 | [diff] [blame] | 1526 | return HookFailure('kernel-doc errors/warnings:', |
| 1527 | items=output.splitlines()) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1528 | return None |
Brian Norris | 23c62e9 | 2018-11-14 12:25:51 -0800 | [diff] [blame] | 1529 | |
| 1530 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 1531 | def _kernel_configcheck(_project, commit): |
Olof Johansson | a96810f | 2012-09-04 16:20:03 -0700 | [diff] [blame] | 1532 | """Makes sure kernel config changes are not mixed with code changes""" |
| 1533 | files = _get_affected_files(commit) |
Mike Frysinger | f252cfc | 2019-12-09 17:34:28 -0500 | [diff] [blame] | 1534 | if len(_filter_files(files, [r'chromeos/config'])) not in [0, len(files)]: |
Olof Johansson | a96810f | 2012-09-04 16:20:03 -0700 | [diff] [blame] | 1535 | return HookFailure('Changes to chromeos/config/ and regular files must ' |
| 1536 | 'be in separate commits:\n%s' % '\n'.join(files)) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1537 | return None |
Anton Staaf | 815d685 | 2011-08-22 10:08:45 -0700 | [diff] [blame] | 1538 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 1539 | |
| 1540 | def _run_json_check(_project, commit): |
Dale Curtis | 2975c43 | 2011-05-03 17:25:20 -0700 | [diff] [blame] | 1541 | """Checks that all JSON files are syntactically valid.""" |
Mike Frysinger | 908be68 | 2018-01-04 02:21:50 -0500 | [diff] [blame] | 1542 | ret = [] |
| 1543 | |
| 1544 | files = _filter_files(_get_affected_files(commit, relative=True), |
| 1545 | [r'.*\.json$']) |
| 1546 | for f in files: |
| 1547 | data = _get_file_content(f, commit) |
Dale Curtis | 2975c43 | 2011-05-03 17:25:20 -0700 | [diff] [blame] | 1548 | try: |
Mike Frysinger | 908be68 | 2018-01-04 02:21:50 -0500 | [diff] [blame] | 1549 | json.loads(data) |
| 1550 | except Exception as e: |
| 1551 | ret.append('%s: Invalid JSON: %s' % (f, e)) |
| 1552 | |
| 1553 | if ret: |
| 1554 | return HookFailure('\n'.join(ret)) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1555 | return None |
Dale Curtis | 2975c43 | 2011-05-03 17:25:20 -0700 | [diff] [blame] | 1556 | |
| 1557 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 1558 | def _check_manifests(_project, commit): |
Mike Frysinger | aae3cb5 | 2018-01-03 16:49:33 -0500 | [diff] [blame] | 1559 | """Make sure Manifest files only have comments & DIST lines.""" |
| 1560 | ret = [] |
Mike Frysinger | 52b537e | 2013-08-22 22:59:53 -0400 | [diff] [blame] | 1561 | |
Mike Frysinger | aae3cb5 | 2018-01-03 16:49:33 -0500 | [diff] [blame] | 1562 | manifests = _filter_files(_get_affected_files(commit, relative=True), |
| 1563 | [r'.*/Manifest$']) |
| 1564 | for path in manifests: |
| 1565 | data = _get_file_content(path, commit) |
| 1566 | |
| 1567 | # Disallow blank files. |
| 1568 | if not data.strip(): |
| 1569 | ret.append('%s: delete empty file' % (path,)) |
Mike Frysinger | 52b537e | 2013-08-22 22:59:53 -0400 | [diff] [blame] | 1570 | continue |
| 1571 | |
Mike Frysinger | aae3cb5 | 2018-01-03 16:49:33 -0500 | [diff] [blame] | 1572 | # Make sure the last newline isn't omitted. |
| 1573 | if data[-1] != '\n': |
| 1574 | ret.append('%s: missing trailing newline' % (path,)) |
Mike Frysinger | 52b537e | 2013-08-22 22:59:53 -0400 | [diff] [blame] | 1575 | |
Mike Frysinger | aae3cb5 | 2018-01-03 16:49:33 -0500 | [diff] [blame] | 1576 | # Do not allow leading or trailing blank lines. |
| 1577 | lines = data.splitlines() |
| 1578 | if not lines[0]: |
| 1579 | ret.append('%s: delete leading blank lines' % (path,)) |
| 1580 | if not lines[-1]: |
| 1581 | ret.append('%s: delete trailing blank lines' % (path,)) |
| 1582 | |
| 1583 | for line in lines: |
| 1584 | # Disallow leading/trailing whitespace. |
| 1585 | if line != line.strip(): |
| 1586 | ret.append('%s: remove leading/trailing whitespace: %s' % (path, line)) |
| 1587 | |
| 1588 | # Allow blank lines & comments. |
| 1589 | line = line.split('#', 1)[0] |
| 1590 | if not line: |
| 1591 | continue |
| 1592 | |
| 1593 | # All other linse should start with DIST. |
| 1594 | if not line.startswith('DIST '): |
| 1595 | ret.append('%s: remove non-DIST lines: %s' % (path, line)) |
| 1596 | break |
| 1597 | |
| 1598 | if ret: |
| 1599 | return HookFailure('\n'.join(ret)) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1600 | return None |
Mike Frysinger | 52b537e | 2013-08-22 22:59:53 -0400 | [diff] [blame] | 1601 | |
| 1602 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 1603 | def _check_change_has_branch_field(_project, commit): |
Puneet Kumar | c80e3f6 | 2012-08-13 19:01:18 -0700 | [diff] [blame] | 1604 | """Check for a non-empty 'BRANCH=' field in the commit message.""" |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1605 | if commit == PRE_SUBMIT: |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1606 | return None |
Puneet Kumar | c80e3f6 | 2012-08-13 19:01:18 -0700 | [diff] [blame] | 1607 | BRANCH_RE = r'\nBRANCH=\S+' |
| 1608 | |
| 1609 | if not re.search(BRANCH_RE, _get_commit_desc(commit)): |
| 1610 | msg = ('Changelist description needs BRANCH field (after first line)\n' |
| 1611 | 'E.g. BRANCH=none or BRANCH=link,snow') |
| 1612 | return HookFailure(msg) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1613 | return None |
Puneet Kumar | c80e3f6 | 2012-08-13 19:01:18 -0700 | [diff] [blame] | 1614 | |
| 1615 | |
Mike Frysinger | 45334bd | 2019-11-04 10:42:33 -0500 | [diff] [blame] | 1616 | def _check_change_has_no_branch_field(_project, commit): |
| 1617 | """Verify 'BRANCH=' field does not exist in the commit message.""" |
| 1618 | if commit == PRE_SUBMIT: |
| 1619 | return None |
| 1620 | BRANCH_RE = r'\nBRANCH=\S+' |
| 1621 | |
| 1622 | if re.search(BRANCH_RE, _get_commit_desc(commit)): |
| 1623 | msg = 'This checkout does not use BRANCH= fields. Delete them.' |
| 1624 | return HookFailure(msg) |
| 1625 | return None |
| 1626 | |
| 1627 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 1628 | def _check_change_has_signoff_field(_project, commit): |
Shawn Nematbakhsh | 51e16ac | 2014-01-28 15:31:07 -0800 | [diff] [blame] | 1629 | """Check for a non-empty 'Signed-off-by:' field in the commit message.""" |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1630 | if commit == PRE_SUBMIT: |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1631 | return None |
Shawn Nematbakhsh | 51e16ac | 2014-01-28 15:31:07 -0800 | [diff] [blame] | 1632 | SIGNOFF_RE = r'\nSigned-off-by: \S+' |
| 1633 | |
| 1634 | if not re.search(SIGNOFF_RE, _get_commit_desc(commit)): |
| 1635 | msg = ('Changelist description needs Signed-off-by: field\n' |
| 1636 | 'E.g. Signed-off-by: My Name <me@chromium.org>') |
| 1637 | return HookFailure(msg) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1638 | return None |
Shawn Nematbakhsh | 51e16ac | 2014-01-28 15:31:07 -0800 | [diff] [blame] | 1639 | |
| 1640 | |
Mike Frysinger | 9ab64b1 | 2019-11-04 10:53:08 -0500 | [diff] [blame] | 1641 | def _check_change_has_no_signoff_field(_project, commit): |
| 1642 | """Verify 'Signed-off-by:' field does not exist in the commit message.""" |
| 1643 | if commit == PRE_SUBMIT: |
| 1644 | return None |
| 1645 | SIGNOFF_RE = r'\nSigned-off-by: \S+' |
| 1646 | |
| 1647 | if re.search(SIGNOFF_RE, _get_commit_desc(commit)): |
| 1648 | msg = 'This checkout does not use Signed-off-by: tags. Delete them.' |
| 1649 | return HookFailure(msg) |
| 1650 | return None |
| 1651 | |
| 1652 | |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 1653 | def _run_project_hook_script(script, project, commit): |
| 1654 | """Runs a project hook script. |
| 1655 | |
| 1656 | The script is run with the following environment variables set: |
| 1657 | PRESUBMIT_PROJECT: The affected project |
| 1658 | PRESUBMIT_COMMIT: The affected commit |
| 1659 | PRESUBMIT_FILES: A newline-separated list of affected files |
| 1660 | |
| 1661 | The script is considered to fail if the exit code is non-zero. It should |
| 1662 | write an error message to stdout. |
| 1663 | """ |
| 1664 | env = dict(os.environ) |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 1665 | env['PRESUBMIT_PROJECT'] = project.name |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 1666 | env['PRESUBMIT_COMMIT'] = commit |
| 1667 | |
| 1668 | # Put affected files in an environment variable |
| 1669 | files = _get_affected_files(commit) |
| 1670 | env['PRESUBMIT_FILES'] = '\n'.join(files) |
| 1671 | |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 1672 | cmd_result = cros_build_lib.run(cmd=script, |
| 1673 | env=env, |
| 1674 | shell=True, |
| 1675 | print_cmd=False, |
| 1676 | input=os.devnull, |
| 1677 | stdout=True, |
| 1678 | encoding='utf-8', |
| 1679 | errors='replace', |
Mike Frysinger | d0c5c8b | 2019-12-17 02:28:26 -0500 | [diff] [blame] | 1680 | stderr=subprocess.STDOUT, |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 1681 | check=False) |
Rahul Chaudhry | 0e51534 | 2015-08-07 12:00:43 -0700 | [diff] [blame] | 1682 | if cmd_result.returncode: |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 1683 | stdout = cmd_result.stdout |
Jon Salz | 7b618af | 2012-08-31 06:03:16 +0800 | [diff] [blame] | 1684 | if stdout: |
| 1685 | stdout = re.sub('(?m)^', ' ', stdout) |
| 1686 | return HookFailure('Hook script "%s" failed with code %d%s' % |
Rahul Chaudhry | 0e51534 | 2015-08-07 12:00:43 -0700 | [diff] [blame] | 1687 | (script, cmd_result.returncode, |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 1688 | ':\n' + stdout if stdout else '')) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1689 | return None |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 1690 | |
| 1691 | |
Bertrand SIMONNET | 0022fff | 2014-07-07 09:52:15 -0700 | [diff] [blame] | 1692 | def _check_project_prefix(_project, commit): |
Mike Frysinger | 55f85b5 | 2014-12-18 14:45:21 -0500 | [diff] [blame] | 1693 | """Require the commit message have a project specific prefix as needed.""" |
Bertrand SIMONNET | 0022fff | 2014-07-07 09:52:15 -0700 | [diff] [blame] | 1694 | |
Brian Norris | 77608e1 | 2018-04-06 10:38:43 -0700 | [diff] [blame] | 1695 | files = _get_affected_files(commit, include_deletes=True, relative=True) |
Bertrand SIMONNET | 0022fff | 2014-07-07 09:52:15 -0700 | [diff] [blame] | 1696 | prefix = os.path.commonprefix(files) |
| 1697 | prefix = os.path.dirname(prefix) |
| 1698 | |
| 1699 | # If there is no common prefix, the CL span multiple projects. |
Daniel Erat | a350fd3 | 2014-09-29 14:02:34 -0700 | [diff] [blame] | 1700 | if not prefix: |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1701 | return None |
Bertrand SIMONNET | 0022fff | 2014-07-07 09:52:15 -0700 | [diff] [blame] | 1702 | |
| 1703 | project_name = prefix.split('/')[0] |
Daniel Erat | a350fd3 | 2014-09-29 14:02:34 -0700 | [diff] [blame] | 1704 | |
| 1705 | # The common files may all be within a subdirectory of the main project |
| 1706 | # directory, so walk up the tree until we find an alias file. |
| 1707 | # _get_affected_files() should return relative paths, but check against '/' to |
| 1708 | # ensure that this loop terminates even if it receives an absolute path. |
| 1709 | while prefix and prefix != '/': |
| 1710 | alias_file = os.path.join(prefix, '.project_alias') |
| 1711 | |
| 1712 | # If an alias exists, use it. |
| 1713 | if os.path.isfile(alias_file): |
| 1714 | project_name = osutils.ReadFile(alias_file).strip() |
| 1715 | |
| 1716 | prefix = os.path.dirname(prefix) |
Bertrand SIMONNET | 0022fff | 2014-07-07 09:52:15 -0700 | [diff] [blame] | 1717 | |
| 1718 | if not _get_commit_desc(commit).startswith(project_name + ': '): |
| 1719 | return HookFailure('The commit title for changes affecting only %s' |
| 1720 | ' should start with \"%s: \"' |
| 1721 | % (project_name, project_name)) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1722 | return None |
Bertrand SIMONNET | 0022fff | 2014-07-07 09:52:15 -0700 | [diff] [blame] | 1723 | |
| 1724 | |
Satoru Takabayashi | 15d17a5 | 2018-08-06 11:12:15 +0900 | [diff] [blame] | 1725 | def _check_filepath_chartype(_project, commit): |
| 1726 | """Checks that FilePath::CharType stuff is not used.""" |
| 1727 | |
| 1728 | FILEPATH_REGEXP = re.compile('|'.join( |
| 1729 | [r'(?:base::)?FilePath::(?:Char|String|StringPiece)Type', |
Satoru Takabayashi | 4ca3792 | 2018-08-08 10:16:38 +0900 | [diff] [blame] | 1730 | r'(?:base::)?FilePath::FromUTF8Unsafe', |
| 1731 | r'AsUTF8Unsafe', |
Satoru Takabayashi | 15d17a5 | 2018-08-06 11:12:15 +0900 | [diff] [blame] | 1732 | r'FILE_PATH_LITERAL'])) |
| 1733 | files = _filter_files(_get_affected_files(commit, relative=True), |
| 1734 | [r'.*\.(cc|h)$']) |
| 1735 | |
| 1736 | errors = [] |
| 1737 | for afile in files: |
| 1738 | for line_num, line in _get_file_diff(afile, commit): |
| 1739 | m = re.search(FILEPATH_REGEXP, line) |
| 1740 | if m: |
| 1741 | errors.append('%s, line %s has %s' % (afile, line_num, m.group(0))) |
| 1742 | |
| 1743 | if errors: |
| 1744 | msg = 'Please assume FilePath::CharType is char (crbug.com/870621):' |
| 1745 | return HookFailure(msg, errors) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1746 | return None |
Satoru Takabayashi | 15d17a5 | 2018-08-06 11:12:15 +0900 | [diff] [blame] | 1747 | |
| 1748 | |
Mike Frysinger | f9d41b3 | 2017-02-23 15:20:04 -0500 | [diff] [blame] | 1749 | def _check_exec_files(_project, commit): |
| 1750 | """Make +x bits on files.""" |
| 1751 | # List of files that should never be +x. |
| 1752 | NO_EXEC = ( |
| 1753 | 'ChangeLog*', |
| 1754 | 'COPYING', |
| 1755 | 'make.conf', |
| 1756 | 'make.defaults', |
| 1757 | 'Manifest', |
| 1758 | 'OWNERS', |
| 1759 | 'package.use', |
| 1760 | 'package.keywords', |
| 1761 | 'package.mask', |
| 1762 | 'parent', |
| 1763 | 'README', |
| 1764 | 'TODO', |
| 1765 | '.gitignore', |
| 1766 | '*.[achly]', |
| 1767 | '*.[ch]xx', |
| 1768 | '*.boto', |
| 1769 | '*.cc', |
| 1770 | '*.cfg', |
| 1771 | '*.conf', |
| 1772 | '*.config', |
| 1773 | '*.cpp', |
| 1774 | '*.css', |
| 1775 | '*.ebuild', |
| 1776 | '*.eclass', |
Tatsuhisa Yamaguchi | 3b05363 | 2019-01-10 14:45:14 +0900 | [diff] [blame] | 1777 | '*.gn', |
| 1778 | '*.gni', |
Mike Frysinger | f9d41b3 | 2017-02-23 15:20:04 -0500 | [diff] [blame] | 1779 | '*.gyp', |
| 1780 | '*.gypi', |
| 1781 | '*.htm', |
| 1782 | '*.html', |
| 1783 | '*.ini', |
| 1784 | '*.js', |
| 1785 | '*.json', |
| 1786 | '*.md', |
| 1787 | '*.mk', |
| 1788 | '*.patch', |
| 1789 | '*.policy', |
| 1790 | '*.proto', |
| 1791 | '*.raw', |
| 1792 | '*.rules', |
| 1793 | '*.service', |
| 1794 | '*.target', |
| 1795 | '*.txt', |
| 1796 | '*.xml', |
| 1797 | '*.yaml', |
| 1798 | ) |
| 1799 | |
| 1800 | def FinalName(obj): |
| 1801 | # If the file is being deleted, then the dst_file is not set. |
| 1802 | if obj.dst_file is None: |
| 1803 | return obj.src_file |
| 1804 | else: |
| 1805 | return obj.dst_file |
| 1806 | |
| 1807 | bad_files = [] |
| 1808 | files = _get_affected_files(commit, relative=True, full_details=True) |
| 1809 | for f in files: |
| 1810 | mode = int(f.dst_mode, 8) |
| 1811 | if not mode & 0o111: |
| 1812 | continue |
| 1813 | name = FinalName(f) |
| 1814 | for no_exec in NO_EXEC: |
| 1815 | if fnmatch.fnmatch(name, no_exec): |
| 1816 | bad_files.append(name) |
| 1817 | break |
| 1818 | |
| 1819 | if bad_files: |
| 1820 | return HookFailure('These files should not be executable. ' |
| 1821 | 'Please `chmod -x` them.', bad_files) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1822 | return None |
Mike Frysinger | f9d41b3 | 2017-02-23 15:20:04 -0500 | [diff] [blame] | 1823 | |
| 1824 | |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 1825 | # Base |
| 1826 | |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1827 | # A list of hooks which are not project specific and check patch description |
| 1828 | # (as opposed to patch body). |
| 1829 | _PATCH_DESCRIPTION_HOOKS = [ |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1830 | _check_change_has_bug_field, |
David James | c3b68b3 | 2013-04-03 09:17:03 -0700 | [diff] [blame] | 1831 | _check_change_has_valid_cq_depend, |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1832 | _check_change_has_test_field, |
| 1833 | _check_change_has_proper_changeid, |
Mike Frysinger | 36b2ebc | 2014-10-31 14:02:03 -0400 | [diff] [blame] | 1834 | _check_commit_message_style, |
Bernie Thompson | f8fea99 | 2016-01-14 10:27:18 -0800 | [diff] [blame] | 1835 | _check_change_is_contribution, |
Jack Neus | 8edbf64 | 2019-07-10 16:08:31 -0600 | [diff] [blame] | 1836 | _check_change_no_include_oem, |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1837 | ] |
| 1838 | |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1839 | # A list of hooks that are not project-specific |
| 1840 | _COMMON_HOOKS = [ |
Aviv Keshet | 5ac5952 | 2017-01-31 14:28:27 -0800 | [diff] [blame] | 1841 | _check_cros_license, |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 1842 | _check_ebuild_eapi, |
Mike Frysinger | 89bdb85 | 2014-02-01 05:26:26 -0500 | [diff] [blame] | 1843 | _check_ebuild_keywords, |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 1844 | _check_ebuild_licenses, |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 1845 | _check_ebuild_virtual_pv, |
Mike Frysinger | f9d41b3 | 2017-02-23 15:20:04 -0500 | [diff] [blame] | 1846 | _check_exec_files, |
Daniel Erat | 9d203ff | 2015-02-17 10:12:21 -0700 | [diff] [blame] | 1847 | _check_for_uprev, |
Rahul Chaudhry | 09f6137 | 2015-07-31 17:14:26 -0700 | [diff] [blame] | 1848 | _check_gofmt, |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1849 | _check_layout_conf, |
Daniel Erat | 9d203ff | 2015-02-17 10:12:21 -0700 | [diff] [blame] | 1850 | _check_no_long_lines, |
Keigo Oka | 4a09bd9 | 2019-05-07 14:01:00 +0900 | [diff] [blame] | 1851 | _check_no_new_gyp, |
Daniel Erat | 9d203ff | 2015-02-17 10:12:21 -0700 | [diff] [blame] | 1852 | _check_no_stray_whitespace, |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1853 | _check_no_tabs, |
Daniel Erat | 9d203ff | 2015-02-17 10:12:21 -0700 | [diff] [blame] | 1854 | _check_portage_make_use_var, |
Fletcher Woodruff | ce1cb1b | 2019-08-16 15:59:32 -0600 | [diff] [blame] | 1855 | _check_rustfmt, |
Aviv Keshet | 5ac5952 | 2017-01-31 14:28:27 -0800 | [diff] [blame] | 1856 | _check_tabbed_indents, |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1857 | ] |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 1858 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 1859 | |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1860 | # A dictionary of project-specific hooks(callbacks), indexed by project name. |
| 1861 | # dict[project] = [callback1, callback2] |
| 1862 | _PROJECT_SPECIFIC_HOOKS = { |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 1863 | 'chromiumos/third_party/kernel': [_kernel_configcheck], |
| 1864 | 'chromiumos/third_party/kernel-next': [_kernel_configcheck], |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1865 | } |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 1866 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 1867 | |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1868 | # A dictionary of flags (keys) that can appear in the config file, and the hook |
Mike Frysinger | 3554bc9 | 2015-03-11 04:59:21 -0400 | [diff] [blame] | 1869 | # that the flag controls (value). |
| 1870 | _HOOK_FLAGS = { |
Luis Hector Chavez | b50391d | 2017-09-26 15:48:15 -0700 | [diff] [blame] | 1871 | 'clang_format_check': _check_clang_format, |
Mike Frysinger | a7642f5 | 2015-03-25 18:31:42 -0400 | [diff] [blame] | 1872 | 'checkpatch_check': _run_checkpatch, |
Brian Norris | 23c62e9 | 2018-11-14 12:25:51 -0800 | [diff] [blame] | 1873 | 'kerneldoc_check': _run_kerneldoc, |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1874 | 'stray_whitespace_check': _check_no_stray_whitespace, |
Mike Frysinger | ff6c7d6 | 2015-03-24 13:49:46 -0400 | [diff] [blame] | 1875 | 'json_check': _run_json_check, |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1876 | 'long_line_check': _check_no_long_lines, |
Alex Deymo | f5792ce | 2015-08-24 22:50:08 -0700 | [diff] [blame] | 1877 | 'cros_license_check': _check_cros_license, |
| 1878 | 'aosp_license_check': _check_aosp_license, |
LaMont Jones | 872fe76 | 2020-02-10 15:36:14 -0700 | [diff] [blame] | 1879 | 'gofmt_check': _check_gofmt, |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1880 | 'tab_check': _check_no_tabs, |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 1881 | 'tabbed_indent_required_check': _check_tabbed_indents, |
Puneet Kumar | c80e3f6 | 2012-08-13 19:01:18 -0700 | [diff] [blame] | 1882 | 'branch_check': _check_change_has_branch_field, |
Shawn Nematbakhsh | 51e16ac | 2014-01-28 15:31:07 -0800 | [diff] [blame] | 1883 | 'signoff_check': _check_change_has_signoff_field, |
Josh Triplett | 0e8fc7f | 2014-04-23 16:00:00 -0700 | [diff] [blame] | 1884 | 'bug_field_check': _check_change_has_bug_field, |
| 1885 | 'test_field_check': _check_change_has_test_field, |
Steve Fung | 49ec7e9 | 2015-03-23 16:07:12 -0700 | [diff] [blame] | 1886 | 'manifest_check': _check_manifests, |
Bernie Thompson | f8fea99 | 2016-01-14 10:27:18 -0800 | [diff] [blame] | 1887 | 'contribution_check': _check_change_is_contribution, |
Mike Frysinger | 47bd125 | 2018-06-11 12:12:20 -0400 | [diff] [blame] | 1888 | 'project_prefix_check': _check_project_prefix, |
Satoru Takabayashi | 15d17a5 | 2018-08-06 11:12:15 +0900 | [diff] [blame] | 1889 | 'filepath_chartype_check': _check_filepath_chartype, |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1890 | } |
| 1891 | |
| 1892 | |
Mike Frysinger | 3554bc9 | 2015-03-11 04:59:21 -0400 | [diff] [blame] | 1893 | def _get_override_hooks(config): |
| 1894 | """Returns a set of hooks controlled by the current project's config file. |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1895 | |
| 1896 | Expects to be called within the project root. |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 1897 | |
| 1898 | Args: |
| 1899 | config: A ConfigParser for the project's config file. |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1900 | """ |
| 1901 | SECTION = 'Hook Overrides' |
Mike Frysinger | f8ce171 | 2015-03-25 18:32:33 -0400 | [diff] [blame] | 1902 | SECTION_OPTIONS = 'Hook Overrides Options' |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1903 | |
Mike Frysinger | 56e8de0 | 2019-07-31 14:40:14 -0400 | [diff] [blame] | 1904 | valid_keys = set(_HOOK_FLAGS.keys()) |
Mike Frysinger | f8ce171 | 2015-03-25 18:32:33 -0400 | [diff] [blame] | 1905 | hooks = _HOOK_FLAGS.copy() |
Mike Frysinger | 380592f | 2020-02-03 15:27:16 -0500 | [diff] [blame] | 1906 | options = config.options(SECTION) if config.has_section(SECTION) else [] |
Mike Frysinger | 3554bc9 | 2015-03-11 04:59:21 -0400 | [diff] [blame] | 1907 | |
| 1908 | enable_flags = [] |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1909 | disable_flags = [] |
Mike Frysinger | 380592f | 2020-02-03 15:27:16 -0500 | [diff] [blame] | 1910 | for flag in options: |
Mike Frysinger | 3554bc9 | 2015-03-11 04:59:21 -0400 | [diff] [blame] | 1911 | if flag not in valid_keys: |
| 1912 | raise ValueError('Error: unknown key "%s" in hook section of "%s"' % |
| 1913 | (flag, _CONFIG_FILE)) |
| 1914 | |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1915 | try: |
Mike Frysinger | f8ce171 | 2015-03-25 18:32:33 -0400 | [diff] [blame] | 1916 | enabled = config.getboolean(SECTION, flag) |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1917 | except ValueError as e: |
Mike Frysinger | 3554bc9 | 2015-03-11 04:59:21 -0400 | [diff] [blame] | 1918 | raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' % |
| 1919 | (flag, _CONFIG_FILE, e)) |
Mike Frysinger | f8ce171 | 2015-03-25 18:32:33 -0400 | [diff] [blame] | 1920 | if enabled: |
| 1921 | enable_flags.append(flag) |
| 1922 | else: |
| 1923 | disable_flags.append(flag) |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1924 | |
Mike Frysinger | f8ce171 | 2015-03-25 18:32:33 -0400 | [diff] [blame] | 1925 | # See if this hook has custom options. |
| 1926 | if enabled: |
| 1927 | try: |
| 1928 | options = config.get(SECTION_OPTIONS, flag) |
| 1929 | hooks[flag] = functools.partial(hooks[flag], options=options.split()) |
Mike Frysinger | b7d552e | 2017-11-23 11:50:47 -0500 | [diff] [blame] | 1930 | hooks[flag].__name__ = flag |
Mike Frysinger | 7bfc89f | 2019-09-13 15:45:51 -0400 | [diff] [blame] | 1931 | except (configparser.NoOptionError, configparser.NoSectionError): |
Mike Frysinger | f8ce171 | 2015-03-25 18:32:33 -0400 | [diff] [blame] | 1932 | pass |
| 1933 | |
| 1934 | enabled_hooks = set(hooks[x] for x in enable_flags) |
| 1935 | disabled_hooks = set(hooks[x] for x in disable_flags) |
Mike Frysinger | 45334bd | 2019-11-04 10:42:33 -0500 | [diff] [blame] | 1936 | |
Mike Frysinger | 9ab64b1 | 2019-11-04 10:53:08 -0500 | [diff] [blame] | 1937 | if _check_change_has_signoff_field not in enabled_hooks: |
| 1938 | enabled_hooks.add(_check_change_has_no_signoff_field) |
Mike Frysinger | 45334bd | 2019-11-04 10:42:33 -0500 | [diff] [blame] | 1939 | if _check_change_has_branch_field not in enabled_hooks: |
| 1940 | enabled_hooks.add(_check_change_has_no_branch_field) |
| 1941 | |
Mike Frysinger | 3554bc9 | 2015-03-11 04:59:21 -0400 | [diff] [blame] | 1942 | return enabled_hooks, disabled_hooks |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1943 | |
| 1944 | |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 1945 | def _get_project_hook_scripts(config): |
| 1946 | """Returns a list of project-specific hook scripts. |
| 1947 | |
| 1948 | Args: |
| 1949 | config: A ConfigParser for the project's config file. |
| 1950 | """ |
| 1951 | SECTION = 'Hook Scripts' |
| 1952 | if not config.has_section(SECTION): |
| 1953 | return [] |
| 1954 | |
Mike Frysinger | b7d552e | 2017-11-23 11:50:47 -0500 | [diff] [blame] | 1955 | return config.items(SECTION) |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 1956 | |
| 1957 | |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1958 | def _get_project_hooks(project, presubmit): |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1959 | """Returns a list of hooks that need to be run for a project. |
| 1960 | |
| 1961 | Expects to be called from within the project root. |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1962 | |
| 1963 | Args: |
| 1964 | project: A string, name of the project. |
| 1965 | presubmit: A Boolean, True if the check is run as a git pre-submit script. |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1966 | """ |
Mike Frysinger | 7bfc89f | 2019-09-13 15:45:51 -0400 | [diff] [blame] | 1967 | config = configparser.RawConfigParser() |
Shuhei Takahashi | 3cbb8dd | 2019-10-29 12:37:11 +0900 | [diff] [blame] | 1968 | if not os.path.exists(_CONFIG_FILE): |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 1969 | # Just use an empty config file |
Mike Frysinger | 7bfc89f | 2019-09-13 15:45:51 -0400 | [diff] [blame] | 1970 | config = configparser.RawConfigParser() |
Shuhei Takahashi | 3cbb8dd | 2019-10-29 12:37:11 +0900 | [diff] [blame] | 1971 | else: |
| 1972 | config.read(_CONFIG_FILE) |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 1973 | |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1974 | if presubmit: |
Filipe Brandenburger | f70d32c | 2015-10-09 13:35:45 -0700 | [diff] [blame] | 1975 | hooks = _COMMON_HOOKS |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1976 | else: |
Filipe Brandenburger | f70d32c | 2015-10-09 13:35:45 -0700 | [diff] [blame] | 1977 | hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1978 | |
Mike Frysinger | 3554bc9 | 2015-03-11 04:59:21 -0400 | [diff] [blame] | 1979 | enabled_hooks, disabled_hooks = _get_override_hooks(config) |
Filipe Brandenburger | f70d32c | 2015-10-09 13:35:45 -0700 | [diff] [blame] | 1980 | hooks = [hook for hook in hooks if hook not in disabled_hooks] |
| 1981 | |
| 1982 | # If a list is both in _COMMON_HOOKS and also enabled explicitly through an |
| 1983 | # override, keep the override only. Note that the override may end up being |
| 1984 | # a functools.partial, in which case we need to extract the .func to compare |
| 1985 | # it to the common hooks. |
| 1986 | unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks] |
| 1987 | hooks = [hook for hook in hooks if hook not in unwrapped_hooks] |
| 1988 | |
| 1989 | hooks = list(enabled_hooks) + hooks |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1990 | |
| 1991 | if project in _PROJECT_SPECIFIC_HOOKS: |
Puneet Kumar | c80e3f6 | 2012-08-13 19:01:18 -0700 | [diff] [blame] | 1992 | hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project] |
| 1993 | if hook not in disabled_hooks) |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 1994 | |
Mike Frysinger | b7d552e | 2017-11-23 11:50:47 -0500 | [diff] [blame] | 1995 | for name, script in _get_project_hook_scripts(config): |
| 1996 | func = functools.partial(_run_project_hook_script, script) |
| 1997 | func.__name__ = name |
| 1998 | hooks.append(func) |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 1999 | |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 2000 | return hooks |
| 2001 | |
| 2002 | |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 2003 | def _run_project_hooks(project_name, proj_dir=None, |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 2004 | commit_list=None, presubmit=False): |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 2005 | """For each project run its project specific hook from the hooks dictionary. |
| 2006 | |
| 2007 | Args: |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 2008 | project_name: The name of project to run hooks for. |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 2009 | proj_dir: If non-None, this is the directory the project is in. If None, |
| 2010 | we'll ask repo. |
Doug Anderson | 1474956 | 2013-06-26 13:38:29 -0700 | [diff] [blame] | 2011 | commit_list: A list of commits to run hooks against. If None or empty list |
| 2012 | then we'll automatically get the list of commits that would be uploaded. |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 2013 | presubmit: A Boolean, True if the check is run as a git pre-submit script. |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 2014 | |
| 2015 | Returns: |
| 2016 | Boolean value of whether any errors were ecountered while running the hooks. |
| 2017 | """ |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 2018 | if proj_dir is None: |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 2019 | proj_dirs = _run_command( |
| 2020 | ['repo', 'forall', project_name, '-c', 'pwd']).split() |
Mike Frysinger | e52b1bc | 2019-09-16 23:45:41 -0400 | [diff] [blame] | 2021 | if not proj_dirs: |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 2022 | print('%s cannot be found.' % project_name, file=sys.stderr) |
David James | 2edd900 | 2013-10-11 14:09:19 -0700 | [diff] [blame] | 2023 | print('Please specify a valid project.', file=sys.stderr) |
| 2024 | return True |
| 2025 | if len(proj_dirs) > 1: |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 2026 | print('%s is associated with multiple directories.' % project_name, |
David James | 2edd900 | 2013-10-11 14:09:19 -0700 | [diff] [blame] | 2027 | file=sys.stderr) |
| 2028 | print('Please specify a directory to help disambiguate.', file=sys.stderr) |
| 2029 | return True |
| 2030 | proj_dir = proj_dirs[0] |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 2031 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 2032 | pwd = os.getcwd() |
| 2033 | # hooks assume they are run from the root of the project |
| 2034 | os.chdir(proj_dir) |
| 2035 | |
Mike Frysinger | ed1b95a | 2019-12-12 19:04:51 -0500 | [diff] [blame] | 2036 | color = terminal.Color() |
| 2037 | |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 2038 | remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref', |
| 2039 | '--symbolic-full-name', '@{u}']).strip() |
| 2040 | if not remote_branch: |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 2041 | print("Your project %s doesn't track any remote repo." % project_name, |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 2042 | file=sys.stderr) |
| 2043 | remote = None |
| 2044 | else: |
Josh Pratt | 15d13ab | 2018-08-13 11:52:48 +1000 | [diff] [blame] | 2045 | branch_items = remote_branch.split('/', 1) |
| 2046 | if len(branch_items) != 2: |
| 2047 | PrintErrorForProject( |
| 2048 | project_name, |
| 2049 | HookFailure( |
| 2050 | 'Cannot get remote and branch name (%s)' % remote_branch)) |
| 2051 | os.chdir(pwd) |
| 2052 | return True |
| 2053 | remote, _branch = branch_items |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 2054 | |
| 2055 | project = Project(name=project_name, dir=proj_dir, remote=remote) |
| 2056 | |
Doug Anderson | 1474956 | 2013-06-26 13:38:29 -0700 | [diff] [blame] | 2057 | if not commit_list: |
| 2058 | try: |
| 2059 | commit_list = _get_commits() |
| 2060 | except VerifyException as e: |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 2061 | PrintErrorForProject(project.name, HookFailure(str(e))) |
Doug Anderson | 1474956 | 2013-06-26 13:38:29 -0700 | [diff] [blame] | 2062 | os.chdir(pwd) |
| 2063 | return True |
Ryan Cui | fa55df5 | 2011-05-06 11:16:55 -0700 | [diff] [blame] | 2064 | |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 2065 | hooks = _get_project_hooks(project.name, presubmit) |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 2066 | error_found = False |
Mike Frysinger | b7d552e | 2017-11-23 11:50:47 -0500 | [diff] [blame] | 2067 | commit_count = len(commit_list) |
Mike Frysinger | b99b377 | 2019-08-17 14:19:44 -0400 | [diff] [blame] | 2068 | hook_count = len(hooks) |
Mike Frysinger | b7d552e | 2017-11-23 11:50:47 -0500 | [diff] [blame] | 2069 | for i, commit in enumerate(commit_list): |
Mike Frysinger | b249665 | 2019-09-12 23:35:46 -0400 | [diff] [blame] | 2070 | CACHE.clear() |
| 2071 | |
Mike Frysinger | ed1b95a | 2019-12-12 19:04:51 -0500 | [diff] [blame] | 2072 | desc = _get_commit_desc(commit) |
| 2073 | print('[%s %i/%i %s] %s' % |
| 2074 | (color.Color(color.CYAN, 'COMMIT'), i + 1, commit_count, commit[0:12], |
| 2075 | desc.splitlines()[0])) |
| 2076 | |
Mike Frysinger | b99b377 | 2019-08-17 14:19:44 -0400 | [diff] [blame] | 2077 | for h, hook in enumerate(hooks): |
Mike Frysinger | ed1b95a | 2019-12-12 19:04:51 -0500 | [diff] [blame] | 2078 | output = ('[%s %i/%i PRESUBMIT.cfg] %s' % |
| 2079 | (color.Color(color.YELLOW, 'RUNNING'), h + 1, hook_count, |
| 2080 | hook.__name__)) |
Mike Frysinger | b7d552e | 2017-11-23 11:50:47 -0500 | [diff] [blame] | 2081 | print(output, end='\r') |
| 2082 | sys.stdout.flush() |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 2083 | hook_error = hook(project, commit) |
Mike Frysinger | b7d552e | 2017-11-23 11:50:47 -0500 | [diff] [blame] | 2084 | print(' ' * len(output), end='\r') |
| 2085 | sys.stdout.flush() |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 2086 | if hook_error: |
Mike Frysinger | ed1b95a | 2019-12-12 19:04:51 -0500 | [diff] [blame] | 2087 | if not isinstance(hook_error, list): |
| 2088 | hook_error = [hook_error] |
| 2089 | PrintErrorsForCommit(color, hook, project.name, hook_error) |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 2090 | error_found = True |
Don Garrett | dba548a | 2011-05-05 15:17:14 -0700 | [diff] [blame] | 2091 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 2092 | os.chdir(pwd) |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 2093 | return error_found |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 2094 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 2095 | |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 2096 | # Main |
Mandeep Singh Baines | 69e470e | 2011-04-06 10:34:52 -0700 | [diff] [blame] | 2097 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 2098 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 2099 | def main(project_list, worktree_list=None, **_kwargs): |
Doug Anderson | 0645663 | 2012-01-05 11:02:14 -0800 | [diff] [blame] | 2100 | """Main function invoked directly by repo. |
| 2101 | |
| 2102 | This function will exit directly upon error so that repo doesn't print some |
| 2103 | obscure error message. |
| 2104 | |
| 2105 | Args: |
| 2106 | project_list: List of projects to run on. |
David James | 2edd900 | 2013-10-11 14:09:19 -0700 | [diff] [blame] | 2107 | worktree_list: A list of directories. It should be the same length as |
| 2108 | project_list, so that each entry in project_list matches with a directory |
| 2109 | in worktree_list. If None, we will attempt to calculate the directories |
| 2110 | automatically. |
Doug Anderson | 0645663 | 2012-01-05 11:02:14 -0800 | [diff] [blame] | 2111 | kwargs: Leave this here for forward-compatibility. |
| 2112 | """ |
Mike Frysinger | ed1b95a | 2019-12-12 19:04:51 -0500 | [diff] [blame] | 2113 | start_time = datetime.datetime.now() |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 2114 | found_error = False |
David James | 2edd900 | 2013-10-11 14:09:19 -0700 | [diff] [blame] | 2115 | if not worktree_list: |
| 2116 | worktree_list = [None] * len(project_list) |
| 2117 | for project, worktree in zip(project_list, worktree_list): |
| 2118 | if _run_project_hooks(project, proj_dir=worktree): |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 2119 | found_error = True |
| 2120 | |
Mike Frysinger | ed1b95a | 2019-12-12 19:04:51 -0500 | [diff] [blame] | 2121 | end_time = datetime.datetime.now() |
| 2122 | color = terminal.Color() |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 2123 | if found_error: |
Mike Frysinger | ed1b95a | 2019-12-12 19:04:51 -0500 | [diff] [blame] | 2124 | msg = ('%s: Preupload failed due to above error(s).\n' |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 2125 | '- To disable some source style checks, and for other hints, see ' |
Mike Frysinger | ed1b95a | 2019-12-12 19:04:51 -0500 | [diff] [blame] | 2126 | '<checkout_dir>/src/repohooks/README.md\n' |
| 2127 | "- To upload only current project, run 'repo upload .'" % |
| 2128 | (color.Color(color.RED, 'FATAL'),)) |
Mike Frysinger | 09d6a3d | 2013-10-08 22:21:03 -0400 | [diff] [blame] | 2129 | print(msg, file=sys.stderr) |
Don Garrett | dba548a | 2011-05-05 15:17:14 -0700 | [diff] [blame] | 2130 | sys.exit(1) |
Mike Frysinger | ed1b95a | 2019-12-12 19:04:51 -0500 | [diff] [blame] | 2131 | else: |
| 2132 | msg = ('[%s] repohooks passed in %s' % |
| 2133 | (color.Color(color.GREEN, 'PASSED'), end_time - start_time)) |
| 2134 | print(msg) |
Anush Elangovan | 63afad7 | 2011-03-23 00:41:27 -0700 | [diff] [blame] | 2135 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 2136 | |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 2137 | def _identify_project(path): |
| 2138 | """Identify the repo project associated with the given path. |
| 2139 | |
| 2140 | Returns: |
| 2141 | A string indicating what project is associated with the path passed in or |
| 2142 | a blank string upon failure. |
| 2143 | """ |
| 2144 | return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'], |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 2145 | stderr=True, cwd=path).strip() |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 2146 | |
| 2147 | |
Mike Frysinger | 55f85b5 | 2014-12-18 14:45:21 -0500 | [diff] [blame] | 2148 | def direct_main(argv): |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 2149 | """Run hooks directly (outside of the context of repo). |
| 2150 | |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 2151 | Args: |
Mike Frysinger | 55f85b5 | 2014-12-18 14:45:21 -0500 | [diff] [blame] | 2152 | argv: The command line args to process |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 2153 | |
| 2154 | Returns: |
| 2155 | 0 if no pre-upload failures, 1 if failures. |
| 2156 | |
| 2157 | Raises: |
| 2158 | BadInvocation: On some types of invocation errors. |
| 2159 | """ |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 2160 | parser = commandline.ArgumentParser(description=__doc__) |
| 2161 | parser.add_argument('--dir', default=None, |
| 2162 | help='The directory that the project lives in. If not ' |
| 2163 | 'specified, use the git project root based on the cwd.') |
| 2164 | parser.add_argument('--project', default=None, |
| 2165 | help='The project repo path; this can affect how the ' |
| 2166 | 'hooks get run, since some hooks are project-specific. ' |
| 2167 | 'For chromite this is chromiumos/chromite. If not ' |
| 2168 | 'specified, the repo tool will be used to figure this ' |
| 2169 | 'out based on the dir.') |
| 2170 | parser.add_argument('--rerun-since', default=None, |
Vadim Bendebury | 75447b9 | 2018-01-10 12:06:01 -0800 | [diff] [blame] | 2171 | help='Rerun hooks on old commits since some point ' |
| 2172 | 'in the past. The argument could be a date (should ' |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 2173 | "match git log's concept of a date, e.g. 2012-06-20), " |
Vadim Bendebury | 75447b9 | 2018-01-10 12:06:01 -0800 | [diff] [blame] | 2174 | 'or a SHA1, or just a number of commits to check (from 1 ' |
| 2175 | 'to 99). This option is mutually exclusive with ' |
| 2176 | '--pre-submit.') |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 2177 | parser.add_argument('--pre-submit', action='store_true', |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 2178 | help='Run the check against the pending commit. ' |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 2179 | "This option should be used at the 'git commit' " |
| 2180 | "phase as opposed to 'repo upload'. This option " |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 2181 | 'is mutually exclusive with --rerun-since.') |
| 2182 | parser.add_argument('commits', nargs='*', |
| 2183 | help='Check specific commits') |
| 2184 | opts = parser.parse_args(argv) |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 2185 | |
Doug Anderson | 1474956 | 2013-06-26 13:38:29 -0700 | [diff] [blame] | 2186 | if opts.rerun_since: |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 2187 | if opts.commits: |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 2188 | raise BadInvocation("Can't pass commits and use rerun-since: %s" % |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 2189 | ' '.join(opts.commits)) |
Doug Anderson | 1474956 | 2013-06-26 13:38:29 -0700 | [diff] [blame] | 2190 | |
Vadim Bendebury | 75447b9 | 2018-01-10 12:06:01 -0800 | [diff] [blame] | 2191 | if len(opts.rerun_since) < 3 and opts.rerun_since.isdigit(): |
| 2192 | # This must be the number of commits to check. We don't expect the user |
| 2193 | # to want to check more than 99 commits. |
| 2194 | limit = '-n%s' % opts.rerun_since |
| 2195 | elif git.IsSHA1(opts.rerun_since, False): |
| 2196 | limit = '%s..' % opts.rerun_since |
| 2197 | else: |
| 2198 | # This better be a date. |
| 2199 | limit = '--since=%s' % opts.rerun_since |
| 2200 | cmd = ['git', 'log', limit, '--pretty=%H'] |
Doug Anderson | 1474956 | 2013-06-26 13:38:29 -0700 | [diff] [blame] | 2201 | all_commits = _run_command(cmd).splitlines() |
| 2202 | bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines() |
| 2203 | |
| 2204 | # Eliminate chrome-bot commits but keep ordering the same... |
| 2205 | bot_commits = set(bot_commits) |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 2206 | opts.commits = [c for c in all_commits if c not in bot_commits] |
Doug Anderson | 1474956 | 2013-06-26 13:38:29 -0700 | [diff] [blame] | 2207 | |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 2208 | if opts.pre_submit: |
| 2209 | raise BadInvocation('rerun-since and pre-submit can not be ' |
| 2210 | 'used together') |
| 2211 | if opts.pre_submit: |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 2212 | if opts.commits: |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 2213 | raise BadInvocation("Can't pass commits and use pre-submit: %s" % |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 2214 | ' '.join(opts.commits)) |
| 2215 | opts.commits = [PRE_SUBMIT,] |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 2216 | |
| 2217 | # Check/normlaize git dir; if unspecified, we'll use the root of the git |
| 2218 | # project from CWD |
| 2219 | if opts.dir is None: |
| 2220 | git_dir = _run_command(['git', 'rev-parse', '--git-dir'], |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 2221 | stderr=True).strip() |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 2222 | if not git_dir: |
| 2223 | raise BadInvocation('The current directory is not part of a git project.') |
| 2224 | opts.dir = os.path.dirname(os.path.abspath(git_dir)) |
| 2225 | elif not os.path.isdir(opts.dir): |
| 2226 | raise BadInvocation('Invalid dir: %s' % opts.dir) |
| 2227 | elif not os.path.isdir(os.path.join(opts.dir, '.git')): |
| 2228 | raise BadInvocation('Not a git directory: %s' % opts.dir) |
| 2229 | |
| 2230 | # Identify the project if it wasn't specified; this _requires_ the repo |
| 2231 | # tool to be installed and for the project to be part of a repo checkout. |
| 2232 | if not opts.project: |
| 2233 | opts.project = _identify_project(opts.dir) |
| 2234 | if not opts.project: |
| 2235 | raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir) |
| 2236 | |
Doug Anderson | 1474956 | 2013-06-26 13:38:29 -0700 | [diff] [blame] | 2237 | found_error = _run_project_hooks(opts.project, proj_dir=opts.dir, |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 2238 | commit_list=opts.commits, |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 2239 | presubmit=opts.pre_submit) |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 2240 | if found_error: |
| 2241 | return 1 |
| 2242 | return 0 |
| 2243 | |
| 2244 | |
Mandeep Singh Baines | 69e470e | 2011-04-06 10:34:52 -0700 | [diff] [blame] | 2245 | if __name__ == '__main__': |
Mike Frysinger | 55f85b5 | 2014-12-18 14:45:21 -0500 | [diff] [blame] | 2246 | sys.exit(direct_main(sys.argv[1:])) |