blob: 81d1e4238459af7c0e188053b4dc702c6fb243ab [file] [log] [blame]
Mike Frysinger4f994402019-09-13 17:40:45 -04001#!/usr/bin/env python3
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002# -*- coding: utf-8 -*-
Jon Salz98255932012-08-18 14:48:02 +08003# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
Mike Frysingerae409522014-02-01 03:16:11 -05007"""Presubmit checks to run when doing `repo upload`.
8
9You can add new checks by adding a functions to the HOOKS constants.
10"""
11
Mike Frysinger09d6a3d2013-10-08 22:21:03 -040012from __future__ import print_function
13
Keigo Okadd908822019-06-04 11:30:25 +090014import argparse
Alex Deymo643ac4c2015-09-03 10:40:50 -070015import collections
Mike Frysingerf252cfc2019-12-09 17:34:28 -050016import configparser
Keigo Oka7e880ac2019-07-03 15:03:43 +090017import datetime
Daniel Erate3ea3fc2015-02-13 15:27:52 -070018import fnmatch
Jon Salz3ee59de2012-08-18 13:54:22 +080019import functools
Dale Curtis2975c432011-05-03 17:25:20 -070020import json
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070021import os
Ryan Cuiec4d6332011-05-02 14:15:25 -070022import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070023import sys
Peter Ammon811f6702014-06-12 15:45:38 -070024import stat
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -050025import subprocess
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070026
Ryan Cui1562fb82011-05-09 11:01:31 -070027from errors import (VerifyException, HookFailure, PrintErrorForProject,
28 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070029
Mike Frysinger919c7032019-09-13 17:48:08 -040030if __name__ in ('__builtin__', 'builtins'):
Mike Frysinger653cd262019-09-20 14:05:02 -040031 # If repo imports us, the __name__ will be __builtin__, and the cwd will be in
32 # the top level of the checkout (i.e. $CHROMEOS_CHECKOUT). chromite will be
33 # in that directory, so add it to our path. This works whether we're running
34 # the repo in $CHROMEOS_CHECKOUT/.repo/repo/ or a custom version in a
35 # completely different tree.
36 # TODO(vapier): Python 2 used "__builtin__" while Python 3 uses "builtins".
Mike Frysinger6850d512018-05-21 12:12:14 -040037 sys.path.insert(0, os.getcwd())
38
Mike Frysinger653cd262019-09-20 14:05:02 -040039elif __name__ == '__main__':
40 # If we're run directly, we'll find chromite relative to the repohooks dir in
41 # $CHROMEOS_CHECKOUT/src/repohooks, so go up two dirs.
David Jamesc3b68b32013-04-03 09:17:03 -070042 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
43
Mike Frysingerfd481ce2019-09-13 18:14:48 -040044# The sys.path monkey patching confuses the linter.
45# pylint: disable=wrong-import-position
Mike Frysinger66142932014-12-18 14:55:57 -050046from chromite.lib import commandline
Rahul Chaudhry0e515342015-08-07 12:00:43 -070047from chromite.lib import cros_build_lib
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050048from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070049from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070050from chromite.lib import patch
Mike Frysingered1b95a2019-12-12 19:04:51 -050051from chromite.lib import terminal
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040052from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070053
Mike Frysingerff4768e2020-02-27 18:48:13 -050054
55assert sys.version_info >= (3, 6), 'This module requires Python 3.6+'
56
57
Vadim Bendebury2b62d742014-06-22 13:14:51 -070058PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070059
Mike Frysingered9b2a02019-12-12 18:52:32 -050060
61# Link to commit message documentation for users.
62DOC_COMMIT_MSG_URL = ('https://chromium.googlesource.com/chromiumos/docs/+/HEAD'
63 '/contributing.md#commit-messages')
64
65
Ryan Cuiec4d6332011-05-02 14:15:25 -070066COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050067 # C++ and friends
Mike Frysinger24dd3c52019-08-17 14:22:48 -040068 r'.*\.c$', r'.*\.cc$', r'.*\.cpp$', r'.*\.h$', r'.*\.m$', r'.*\.mm$',
69 r'.*\.inl$', r'.*\.asm$', r'.*\.hxx$', r'.*\.hpp$', r'.*\.s$', r'.*\.S$',
Mike Frysingerae409522014-02-01 03:16:11 -050070 # Scripts
Mike Frysinger24dd3c52019-08-17 14:22:48 -040071 r'.*\.js$', r'.*\.py$', r'.*\.sh$', r'.*\.rb$', r'.*\.pl$', r'.*\.pm$',
Mike Frysingerae409522014-02-01 03:16:11 -050072 # No extension at all, note that ALL CAPS files are black listed in
73 # COMMON_EXCLUDED_LIST below.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040074 r'(^|.*[\\\/])[^.]+$',
Mike Frysingerae409522014-02-01 03:16:11 -050075 # Other
Mike Frysinger24dd3c52019-08-17 14:22:48 -040076 r'.*\.java$', r'.*\.mk$', r'.*\.am$',
77 r'.*\.policy$', r'.*\.conf$', r'.*\.go$',
78 r'(^OWNERS|/OWNERS)',
Ryan Cuiec4d6332011-05-02 14:15:25 -070079]
80
Ryan Cui1562fb82011-05-09 11:01:31 -070081
Ryan Cuiec4d6332011-05-02 14:15:25 -070082COMMON_EXCLUDED_PATHS = [
Daniel Erate3ea3fc2015-02-13 15:27:52 -070083 # For ebuild trees, ignore any caches and manifest data.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040084 r'.*/Manifest$',
85 r'.*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$',
Doug Anderson5bfb6792011-10-25 16:45:41 -070086
Daniel Erate3ea3fc2015-02-13 15:27:52 -070087 # Ignore profiles data (like overlay-tegra2/profiles).
Mike Frysinger24dd3c52019-08-17 14:22:48 -040088 r'(^|.*/)overlay-.*/profiles/.*',
89 r'^profiles/.*$',
Mike Frysinger98638102014-08-28 00:15:08 -040090
C Shapiro8f90e9b2017-06-28 09:54:50 -060091 # Ignore config files in ebuild setup.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040092 r'(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*',
93 r'^chromeos-base/chromeos-bsp.*/files/.*',
C Shapiro8f90e9b2017-06-28 09:54:50 -060094
Daniel Erate3ea3fc2015-02-13 15:27:52 -070095 # Ignore minified js and jquery.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040096 r'.*\.min\.js',
97 r'.*jquery.*\.js',
Mike Frysinger33a458d2014-03-03 17:00:51 -050098
99 # Ignore license files as the content is often taken verbatim.
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400100 r'.*/licenses/.*',
Alex Klein619c0912019-01-30 17:13:23 -0700101
Mike Frysinger13650402019-07-31 14:31:46 -0400102 # Exclude generated protobuf bindings.
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400103 r'.*_pb2\.py$',
104 r'.*\.pb\.go$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700105]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700106
Ken Turnerd07564b2018-02-08 17:57:59 +1100107LICENSE_EXCLUDED_PATHS = [
LaMont Jones775c2b32020-02-19 17:32:54 -0700108 r'^(.*/)?OWNERS(\..*)?$',
Ken Turnerd07564b2018-02-08 17:57:59 +1100109]
Ryan Cui1562fb82011-05-09 11:01:31 -0700110
Ryan Cui9b651632011-05-11 11:38:58 -0700111_CONFIG_FILE = 'PRESUBMIT.cfg'
112
113
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700114# File containing wildcards, one per line, matching files that should be
115# excluded from presubmit checks. Lines beginning with '#' are ignored.
116_IGNORE_FILE = '.presubmitignore'
117
Cheng Yuehb707c522020-01-02 14:06:59 +0800118
119TEST_FIELD_RE = r'\nTEST=\S+'
120
Doug Anderson44a644f2011-11-02 10:37:37 -0700121# Exceptions
122
123
124class BadInvocation(Exception):
125 """An Exception indicating a bad invocation of the program."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700126
127
Ryan Cui1562fb82011-05-09 11:01:31 -0700128# General Helpers
129
Sean Paulba01d402011-05-05 11:36:23 -0400130
Mike Frysingerb2496652019-09-12 23:35:46 -0400131class Cache(object):
132 """General helper for caching git content."""
133
134 def __init__(self):
135 self._cache = {}
136
137 def get_subcache(self, scope):
138 return self._cache.setdefault(scope, {})
139
140 def clear(self):
141 self._cache.clear()
142
143CACHE = Cache()
144
145
Alex Deymo643ac4c2015-09-03 10:40:50 -0700146Project = collections.namedtuple('Project', ['name', 'dir', 'remote'])
147
148
Mike Frysinger526a5f82019-09-13 18:05:30 -0400149def _run_command(cmd, **kwargs):
Doug Anderson44a644f2011-11-02 10:37:37 -0700150 """Executes the passed in command and returns raw stdout output.
151
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400152 This is a convenience func to set some run defaults differently.
Mike Frysinger526a5f82019-09-13 18:05:30 -0400153
Doug Anderson44a644f2011-11-02 10:37:37 -0700154 Args:
155 cmd: The command to run; should be a list of strings.
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400156 **kwargs: Same as cros_build_lib.run.
Doug Anderson44a644f2011-11-02 10:37:37 -0700157
158 Returns:
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700159 The stdout from the process (discards stderr and returncode).
Doug Anderson44a644f2011-11-02 10:37:37 -0700160 """
Mike Frysinger526a5f82019-09-13 18:05:30 -0400161 kwargs.setdefault('print_cmd', False)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400162 kwargs.setdefault('stdout', True)
163 kwargs.setdefault('check', False)
Mike Frysinger054c1592019-11-18 03:51:54 -0500164 result = cros_build_lib.run(cmd, **kwargs)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400165 # NB: We decode this directly rather than through kwargs as our tests rely
166 # on this post-processing behavior currently.
Mike Frysinger71e643e2019-09-13 17:26:39 -0400167 return result.output.decode('utf-8', 'replace')
Ryan Cui72834d12011-05-05 14:51:33 -0700168
Ryan Cui1562fb82011-05-09 11:01:31 -0700169
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700170def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700171 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700172 if __name__ == '__main__':
173 # Works when file is run on its own (__file__ is defined)...
174 return os.path.abspath(os.path.dirname(__file__))
175 else:
176 # We need to do this when we're run through repo. Since repo executes
177 # us with execfile(), we don't get __file__ defined.
178 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
179 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700180
Ryan Cui1562fb82011-05-09 11:01:31 -0700181
Ryan Cuiec4d6332011-05-02 14:15:25 -0700182def _match_regex_list(subject, expressions):
183 """Try to match a list of regular expressions to a string.
184
185 Args:
186 subject: The string to match regexes on
187 expressions: A list of regular expressions to check for matches with.
188
189 Returns:
190 Whether the passed in subject matches any of the passed in regexes.
191 """
192 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500193 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700194 return True
195 return False
196
Ryan Cui1562fb82011-05-09 11:01:31 -0700197
Mike Frysingerae409522014-02-01 03:16:11 -0500198def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700199 """Filter out files based on the conditions passed in.
200
201 Args:
202 files: list of filepaths to filter
203 include_list: list of regex that when matched with a file path will cause it
204 to be added to the output list unless the file is also matched with a
205 regex in the exclude_list.
206 exclude_list: list of regex that when matched with a file will prevent it
207 from being added to the output list, even if it is also matched with a
208 regex in the include_list.
209
210 Returns:
211 A list of filepaths that contain files matched in the include_list and not
212 in the exclude_list.
213 """
214 filtered = []
215 for f in files:
216 if (_match_regex_list(f, include_list) and
217 not _match_regex_list(f, exclude_list)):
218 filtered.append(f)
219 return filtered
220
Ryan Cuiec4d6332011-05-02 14:15:25 -0700221
222# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700223
224
Ryan Cui4725d952011-05-05 15:41:19 -0700225def _get_upstream_branch():
226 """Returns the upstream tracking branch of the current branch.
227
228 Raises:
229 Error if there is no tracking branch
230 """
231 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
232 current_branch = current_branch.replace('refs/heads/', '')
233 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700234 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700235
236 cfg_option = 'branch.' + current_branch + '.%s'
237 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
238 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
239 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700240 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700241
242 return full_upstream.replace('heads', 'remotes/' + remote)
243
Ryan Cui1562fb82011-05-09 11:01:31 -0700244
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700245def _get_patch(commit):
246 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700247 if commit == PRE_SUBMIT:
248 return _run_command(['git', 'diff', '--cached', 'HEAD'])
249 else:
250 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700251
Ryan Cui1562fb82011-05-09 11:01:31 -0700252
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500253def _get_file_content(path, commit):
254 """Returns the content of a file at a specific commit.
255
256 We can't rely on the file as it exists in the filesystem as people might be
257 uploading a series of changes which modifies the file multiple times.
258
259 Note: The "content" of a symlink is just the target. So if you're expecting
260 a full file, you should check that first. One way to detect is that the
261 content will not have any newlines.
262 """
Mike Frysingerb2496652019-09-12 23:35:46 -0400263 # Make sure people don't accidentally pass in full paths which will never
264 # work. You need to use relative=True with _get_affected_files.
265 if path.startswith('/'):
266 raise ValueError('_get_file_content must be called with relative paths: %s'
267 % (path,))
268
269 # {<commit>: {<path1>: <content>, <path2>: <content>}}
270 cache = CACHE.get_subcache('get_file_content')
271 if path in cache:
272 return cache[path]
273
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700274 if commit == PRE_SUBMIT:
Mike Frysingerb2496652019-09-12 23:35:46 -0400275 content = _run_command(['git', 'diff', 'HEAD', path])
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700276 else:
Mike Frysingerb2496652019-09-12 23:35:46 -0400277 content = _run_command(['git', 'show', '%s:%s' % (commit, path)])
278 cache[path] = content
279 return content
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500280
281
Mike Frysingerae409522014-02-01 03:16:11 -0500282def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700283 """Returns a list of (linenum, lines) tuples that the commit touched."""
Mike Frysingerb2496652019-09-12 23:35:46 -0400284 # {<commit>: {<path1>: <content>, <path2>: <content>}}
285 cache = CACHE.get_subcache('get_file_diff')
286 if path in cache:
287 return cache[path]
288
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700289 if commit == PRE_SUBMIT:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800290 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD',
291 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700292 else:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800293 command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit,
294 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700295 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700296
297 new_lines = []
298 line_num = 0
299 for line in output.splitlines():
300 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
301 if m:
302 line_num = int(m.groups(1)[0])
303 continue
304 if line.startswith('+') and not line.startswith('++'):
Mike Frysinger71e643e2019-09-13 17:26:39 -0400305 new_lines.append((line_num, line[1:]))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700306 if not line.startswith('-'):
307 line_num += 1
Mike Frysingerb2496652019-09-12 23:35:46 -0400308 cache[path] = new_lines
Ryan Cuiec4d6332011-05-02 14:15:25 -0700309 return new_lines
310
Ryan Cui1562fb82011-05-09 11:01:31 -0700311
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700312def _get_ignore_wildcards(directory, cache):
313 """Get wildcards listed in a directory's _IGNORE_FILE.
314
315 Args:
316 directory: A string containing a directory path.
317 cache: A dictionary (opaque to caller) caching previously-read wildcards.
318
319 Returns:
320 A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE
321 wasn't present.
322 """
323 # In the cache, keys are directories and values are lists of wildcards from
324 # _IGNORE_FILE within those directories (and empty if no file was present).
325 if directory not in cache:
326 wildcards = []
327 dotfile_path = os.path.join(directory, _IGNORE_FILE)
328 if os.path.exists(dotfile_path):
329 # TODO(derat): Consider using _get_file_content() to get the file as of
330 # this commit instead of the on-disk version. This may have a noticeable
331 # performance impact, as each call to _get_file_content() runs git.
332 with open(dotfile_path, 'r') as dotfile:
333 for line in dotfile.readlines():
334 line = line.strip()
335 if line.startswith('#'):
336 continue
337 if line.endswith('/'):
338 line += '*'
339 wildcards.append(line)
340 cache[directory] = wildcards
341
342 return cache[directory]
343
344
345def _path_is_ignored(path, cache):
346 """Check whether a path is ignored by _IGNORE_FILE.
347
348 Args:
349 path: A string containing a path.
350 cache: A dictionary (opaque to caller) caching previously-read wildcards.
351
352 Returns:
353 True if a file named _IGNORE_FILE in one of the passed-in path's parent
354 directories contains a wildcard matching the path.
355 """
356 # Skip ignore files.
357 if os.path.basename(path) == _IGNORE_FILE:
358 return True
359
360 path = os.path.abspath(path)
361 base = os.getcwd()
362
363 prefix = os.path.dirname(path)
364 while prefix.startswith(base):
365 rel_path = path[len(prefix) + 1:]
366 for wildcard in _get_ignore_wildcards(prefix, cache):
367 if fnmatch.fnmatch(rel_path, wildcard):
368 return True
369 prefix = os.path.dirname(prefix)
370
371 return False
372
373
Mike Frysinger292b45d2014-11-25 01:17:10 -0500374def _get_affected_files(commit, include_deletes=False, relative=False,
375 include_symlinks=False, include_adds=True,
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700376 full_details=False, use_ignore_files=True):
Peter Ammon811f6702014-06-12 15:45:38 -0700377 """Returns list of file paths that were modified/added, excluding symlinks.
378
379 Args:
380 commit: The commit
381 include_deletes: If true, we'll include deleted files in the result
382 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500383 include_symlinks: If true, we'll include symlinks in the result
384 include_adds: If true, we'll include new files in the result
385 full_details: If False, return filenames, else return structured results.
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700386 use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files.
Peter Ammon811f6702014-06-12 15:45:38 -0700387
388 Returns:
389 A list of modified/added (and perhaps deleted) files
390 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500391 if not relative and full_details:
392 raise ValueError('full_details only supports relative paths currently')
393
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700394 if commit == PRE_SUBMIT:
395 return _run_command(['git', 'diff-index', '--cached',
396 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500397
398 path = os.getcwd()
Mike Frysingerb2496652019-09-12 23:35:46 -0400399 # {<commit>: {<path1>: <content>, <path2>: <content>}}
400 cache = CACHE.get_subcache('get_affected_files')
401 if path not in cache:
402 cache[path] = git.RawDiff(path, '%s^!' % commit)
403 files = cache[path]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500404
405 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500406 if not include_symlinks:
407 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500408
409 if not include_deletes:
410 files = [x for x in files if x.status != 'D']
411
Mike Frysinger292b45d2014-11-25 01:17:10 -0500412 if not include_adds:
413 files = [x for x in files if x.status != 'A']
414
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700415 if use_ignore_files:
416 cache = {}
417 is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache)
418 files = [x for x in files if not is_ignored(x)]
419
Mike Frysinger292b45d2014-11-25 01:17:10 -0500420 if full_details:
421 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500422 return files
423 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500424 # Caller only cares about filenames.
425 files = [x.dst_file if x.dst_file else x.src_file for x in files]
426 if relative:
427 return files
428 else:
429 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700430
431
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700432def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700433 """Returns a list of commits for this review."""
Mike Frysingere300c7d2019-09-12 23:33:52 -0400434 cmd = ['git', 'log', '--no-merges', '--format=%H',
435 '%s..' % _get_upstream_branch()]
Ryan Cui72834d12011-05-05 14:51:33 -0700436 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700437
Ryan Cui1562fb82011-05-09 11:01:31 -0700438
Ryan Cuiec4d6332011-05-02 14:15:25 -0700439def _get_commit_desc(commit):
440 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700441 if commit == PRE_SUBMIT:
442 return ''
Mike Frysingerb2496652019-09-12 23:35:46 -0400443
444 # {<commit>: <content>}
445 cache = CACHE.get_subcache('get_commit_desc')
446 if commit not in cache:
Mike Frysinger4efdee72019-11-04 10:57:01 -0500447 cache[commit] = _run_command(['git', 'log', '--format=%B',
Mike Frysingerb2496652019-09-12 23:35:46 -0400448 commit + '^!'])
449 return cache[commit]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700450
451
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800452def _check_lines_in_diff(commit, files, check_callable, error_description):
453 """Checks given file for errors via the given check.
454
455 This is a convenience function for common per-line checks. It goes through all
456 files and returns a HookFailure with the error description listing all the
457 failures.
458
459 Args:
460 commit: The commit we're working on.
461 files: The files to check.
462 check_callable: A callable that takes a line and returns True if this line
463 _fails_ the check.
464 error_description: A string describing the error.
465 """
466 errors = []
467 for afile in files:
468 for line_num, line in _get_file_diff(afile, commit):
469 if check_callable(line):
470 errors.append('%s, line %s' % (afile, line_num))
471 if errors:
472 return HookFailure(error_description, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400473 return None
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800474
475
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900476def _parse_common_inclusion_options(options):
477 """Parses common hook options for including/excluding files.
478
479 Args:
480 options: Option string list.
481
482 Returns:
483 (included, excluded) where each one is a list of regex strings.
484 """
485 parser = argparse.ArgumentParser()
486 parser.add_argument('--exclude_regex', action='append')
487 parser.add_argument('--include_regex', action='append')
488 opts = parser.parse_args(options)
489 included = opts.include_regex or []
490 excluded = opts.exclude_regex or []
491 return included, excluded
492
493
Ryan Cuiec4d6332011-05-02 14:15:25 -0700494# Common Hooks
495
Ryan Cui1562fb82011-05-09 11:01:31 -0700496
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900497def _check_no_long_lines(_project, commit, options=()):
Mike Frysinger55f85b52014-12-18 14:45:21 -0500498 """Checks there are no lines longer than MAX_LEN in any of the text files."""
Keigo Oka9732e382019-06-28 17:44:59 +0900499 LONG_LINE_OK_PATHS = [
500 # Go has no line length limit.
501 # https://golang.org/doc/effective_go.html#formatting
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400502 r'.*\.go$',
Keigo Oka9732e382019-06-28 17:44:59 +0900503 ]
Mike Frysinger55f85b52014-12-18 14:45:21 -0500504
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900505 DEFAULT_MAX_LENGTHS = [
506 # Java's line length limit is 100 chars.
507 # https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md
508 (r'.*\.java$', 100),
509 ]
510
Ryan Cuiec4d6332011-05-02 14:15:25 -0700511 MAX_LEN = 80
512
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900513 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700514 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900515 included + COMMON_INCLUDED_PATHS,
Keigo Oka9732e382019-06-28 17:44:59 +0900516 excluded + COMMON_EXCLUDED_PATHS + LONG_LINE_OK_PATHS)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700517
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900518 errors = []
Ryan Cuiec4d6332011-05-02 14:15:25 -0700519 for afile in files:
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700520 skip_regexps = (
521 r'https?://',
522 r'^#\s*(define|include|import|pragma|if|ifndef|endif)\b',
523 )
524
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900525 max_len = MAX_LEN
526
527 for expr, length in DEFAULT_MAX_LENGTHS:
528 if re.search(expr, afile):
529 max_len = length
530 break
531
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700532 if os.path.basename(afile).startswith('OWNERS'):
533 # File paths can get long, and there's no way to break them up into
534 # multiple lines.
535 skip_regexps += (
536 r'^include\b',
537 r'file:',
538 )
539
540 skip_regexps = [re.compile(x) for x in skip_regexps]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700541 for line_num, line in _get_file_diff(afile, commit):
542 # Allow certain lines to exceed the maxlen rule.
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900543 if len(line) <= max_len or any(x.search(line) for x in skip_regexps):
Jon Salz98255932012-08-18 14:48:02 +0800544 continue
545
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900546 errors.append('%s, line %s, %s chars, over %s chars' %
547 (afile, line_num, len(line), max_len))
Jon Salz98255932012-08-18 14:48:02 +0800548 if len(errors) == 5: # Just show the first 5 errors.
549 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700550
551 if errors:
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900552 msg = 'Found lines longer than the limit (first 5 shown):'
Ryan Cui1562fb82011-05-09 11:01:31 -0700553 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400554 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700555
Ryan Cuiec4d6332011-05-02 14:15:25 -0700556
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900557def _check_no_stray_whitespace(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700558 """Checks that there is no stray whitespace at source lines end."""
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900559 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700560 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900561 included + COMMON_INCLUDED_PATHS,
562 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800563 return _check_lines_in_diff(commit, files,
564 lambda line: line.rstrip() != line,
565 'Found line ending with white space in:')
Ryan Cui1562fb82011-05-09 11:01:31 -0700566
Ryan Cuiec4d6332011-05-02 14:15:25 -0700567
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900568def _check_no_tabs(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700569 """Checks there are no unexpanded tabs."""
Mike Frysingercd134512017-10-26 04:36:33 -0400570 # Don't add entire repos here. Update the PRESUBMIT.cfg in each repo instead.
571 # We only whitelist known specific filetypes here that show up in all repos.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700572 TAB_OK_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400573 r'.*\.ebuild$',
574 r'.*\.eclass$',
575 r'.*\.go$',
576 r'.*/[M|m]akefile$',
577 r'.*\.mk$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700578 ]
579
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900580 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700581 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900582 included + COMMON_INCLUDED_PATHS,
583 excluded + COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800584 return _check_lines_in_diff(commit, files,
585 lambda line: '\t' in line,
586 'Found a tab character in:')
Ryan Cuiec4d6332011-05-02 14:15:25 -0700587
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800588
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900589def _check_tabbed_indents(_project, commit, options=()):
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800590 """Checks that indents use tabs only."""
591 TABS_REQUIRED_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400592 r'.*\.ebuild$',
593 r'.*\.eclass$',
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800594 ]
595 LEADING_SPACE_RE = re.compile('[\t]* ')
596
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900597 included, excluded = _parse_common_inclusion_options(options)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800598 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900599 included + TABS_REQUIRED_PATHS,
600 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800601 return _check_lines_in_diff(
602 commit, files,
603 lambda line: LEADING_SPACE_RE.match(line) is not None,
604 'Found a space in indentation (must be all tabs):')
Ryan Cui1562fb82011-05-09 11:01:31 -0700605
Ryan Cuiec4d6332011-05-02 14:15:25 -0700606
LaMont Jones872fe762020-02-10 15:36:14 -0700607def _check_gofmt(_project, commit, options=()):
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700608 """Checks that Go files are formatted with gofmt."""
LaMont Jones872fe762020-02-10 15:36:14 -0700609 included, excluded = _parse_common_inclusion_options(options)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700610 errors = []
611 files = _filter_files(_get_affected_files(commit, relative=True),
LaMont Jones872fe762020-02-10 15:36:14 -0700612 included + [r'\.go$'],
613 excluded)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700614
615 for gofile in files:
616 contents = _get_file_content(gofile, commit)
Mike Frysingeraa7dc942019-09-25 00:07:24 -0400617 output = _run_command(cmd=['gofmt', '-l'], input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500618 stderr=subprocess.STDOUT)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700619 if output:
620 errors.append(gofile)
621 if errors:
622 return HookFailure('Files not formatted with gofmt:', errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400623 return None
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700624
625
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600626def _check_rustfmt(_project, commit):
627 """Checks that Rust files are formatted with rustfmt."""
628 errors = []
629 files = _filter_files(_get_affected_files(commit, relative=True),
630 [r'\.rs$'])
631
632 for rustfile in files:
633 contents = _get_file_content(rustfile, commit)
Mike Frysingeraa7dc942019-09-25 00:07:24 -0400634 output = _run_command(cmd=['rustfmt'], input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500635 stderr=subprocess.STDOUT)
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600636 if output != contents:
637 errors.append(rustfile)
638 if errors:
639 return HookFailure('Files not formatted with rustfmt: '
640 "(run 'cargo fmt' to fix)", errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400641 return None
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600642
643
Mike Frysingerae409522014-02-01 03:16:11 -0500644def _check_change_has_test_field(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700645 """Check for a non-empty 'TEST=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500646 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700647
Cheng Yuehb707c522020-01-02 14:06:59 +0800648 if not re.search(TEST_FIELD_RE, _get_commit_desc(commit)):
Mike Frysingered9b2a02019-12-12 18:52:32 -0500649 msg = ('Changelist description needs TEST field (after first line)\n%s' %
650 (SEE_ALSO,))
Ryan Cui1562fb82011-05-09 11:01:31 -0700651 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400652 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700653
Ryan Cuiec4d6332011-05-02 14:15:25 -0700654
Mike Frysingerae409522014-02-01 03:16:11 -0500655def _check_change_has_valid_cq_depend(_project, commit):
Jason D. Clinton299e3222019-05-23 09:42:03 -0600656 """Check for a correctly formatted Cq-Depend field in the commit message."""
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700657 desc = _get_commit_desc(commit)
Jason D. Clinton299e3222019-05-23 09:42:03 -0600658 msg = 'Changelist has invalid Cq-Depend target.'
659 example = 'Example: Cq-Depend: chromium:1234, chrome-internal:2345'
David Jamesc3b68b32013-04-03 09:17:03 -0700660 try:
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700661 patch.GetPaladinDeps(desc)
David Jamesc3b68b32013-04-03 09:17:03 -0700662 except ValueError as ex:
663 return HookFailure(msg, [example, str(ex)])
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700664 # Check that Cq-Depend is in the same paragraph as Change-Id.
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500665 msg = 'Cq-Depend is not in the same paragraph as Change-Id.'
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700666 paragraphs = desc.split('\n\n')
667 for paragraph in paragraphs:
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500668 if (re.search(r'^Cq-Depend:', paragraph, re.M) and not
669 re.search('^Change-Id:', paragraph, re.M)):
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700670 return HookFailure(msg)
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500671
672 # We no longer support CQ-DEPEND= lines.
673 if re.search(r'^CQ-DEPEND[=:]', desc, re.M):
674 return HookFailure(
675 'CQ-DEPEND= is no longer supported. Please see:\n'
676 'https://chromium.googlesource.com/chromiumos/docs/+/HEAD/'
677 'contributing.md#CQ-DEPEND')
678
Mike Frysinger8cf80812019-09-16 23:49:29 -0400679 return None
David Jamesc3b68b32013-04-03 09:17:03 -0700680
681
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800682def _check_change_is_contribution(_project, commit):
683 """Check that the change is a contribution."""
684 NO_CONTRIB = 'not a contribution'
685 if NO_CONTRIB in _get_commit_desc(commit).lower():
686 msg = ('Changelist is not a contribution, this cannot be accepted.\n'
687 'Please remove the "%s" text from the commit message.') % NO_CONTRIB
688 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400689 return None
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800690
691
Alex Deymo643ac4c2015-09-03 10:40:50 -0700692def _check_change_has_bug_field(project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700693 """Check for a correctly formatted 'BUG=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500694 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
695
David James5c0073d2013-04-03 08:48:52 -0700696 OLD_BUG_RE = r'\nBUG=.*chromium-os'
697 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
698 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
699 'the chromium tracker in your BUG= line now.')
700 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700701
Alex Deymo643ac4c2015-09-03 10:40:50 -0700702 # Android internal and external projects use "Bug: " to track bugs in
703 # buganizer.
704 BUG_COLON_REMOTES = (
705 'aosp',
706 'goog',
707 )
708 if project.remote in BUG_COLON_REMOTES:
709 BUG_RE = r'\nBug: ?([Nn]one|\d+)'
710 if not re.search(BUG_RE, _get_commit_desc(commit)):
711 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500712 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700713 'Bug: 9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500714 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700715 return HookFailure(msg)
716 else:
Jorge Lucangeli Obesdce214e2017-10-25 15:04:39 -0400717 BUG_RE = r'\nBUG=([Nn]one|(chromium|b):\d+)'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700718 if not re.search(BUG_RE, _get_commit_desc(commit)):
719 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500720 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700721 'BUG=chromium:9999 (for public tracker)\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700722 'BUG=b:9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500723 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700724 return HookFailure(msg)
Ryan Cui1562fb82011-05-09 11:01:31 -0700725
Cheng Yuehb707c522020-01-02 14:06:59 +0800726 TEST_BEFORE_BUG_RE = TEST_FIELD_RE + r'.*' + BUG_RE
727
728 if re.search(TEST_BEFORE_BUG_RE, _get_commit_desc(commit), re.DOTALL):
729 msg = ('The BUG field must come before the TEST field.\n%s' %
730 (SEE_ALSO,))
731 return HookFailure(msg)
732
Mike Frysinger8cf80812019-09-16 23:49:29 -0400733 return None
734
Ryan Cuiec4d6332011-05-02 14:15:25 -0700735
Jack Neus8edbf642019-07-10 16:08:31 -0600736def _check_change_no_include_oem(project, commit):
737 """Check that the change does not reference OEMs."""
738 ALLOWLIST = {
739 'chromiumos/platform/ec',
740 # Used by unit tests.
741 'project',
742 }
743 if project.name not in ALLOWLIST:
744 return None
745
Mike Frysingerbb34a222019-07-31 14:40:46 -0400746 TAGS = {
Jack Neus8edbf642019-07-10 16:08:31 -0600747 'Reviewed-on',
748 'Reviewed-by',
749 'Signed-off-by',
750 'Commit-Ready',
751 'Tested-by',
752 'Commit-Queue',
Jack Neus8edbf642019-07-10 16:08:31 -0600753 'Acked-by',
754 'Modified-by',
755 'CC',
756 'Suggested-by',
757 'Reported-by',
758 'Acked-for-chrome-by',
LaMont Jones237f3ef2020-01-22 10:40:52 -0700759 'Cq-Cl-Tag',
Mike Frysingerbb34a222019-07-31 14:40:46 -0400760 }
Jack Neus8edbf642019-07-10 16:08:31 -0600761
762 # Ignore tags, which could reasonably contain OEM names
763 # (e.g. Reviewed-by: foo@oem.corp-partner.google.com).
Jack Neus8edbf642019-07-10 16:08:31 -0600764 commit_message = ' '.join(
Mike Frysingerbb34a222019-07-31 14:40:46 -0400765 x for x in _get_commit_desc(commit).splitlines()
766 if ':' not in x or x.split(':', 1)[0] not in TAGS)
767
Jack Neus8edbf642019-07-10 16:08:31 -0600768 commit_message = re.sub(r'[\s_-]+', ' ', commit_message)
769
770 # Exercise caution when expanding these lists. Adding a name
771 # could indicate a new relationship with a company!
772 OEMS = ['hp', 'hewlett packard', 'dell', 'lenovo', 'acer', 'asus', 'samsung']
773 ODMS = [
774 'bitland', 'compal', 'haier', 'huaqin', 'inventec', 'lg', 'pegatron',
775 'pegatron(ems)', 'quanta', 'samsung', 'wistron'
776 ]
777
778 for name_type, name_list in [('OEM', OEMS), ('ODM', ODMS)]:
779 # Construct regex
780 name_re = r'\b(%s)\b' % '|'.join([re.escape(x) for x in name_list])
781 matches = [x[0] for x in re.findall(name_re, commit_message, re.IGNORECASE)]
Mike Frysingere52b1bc2019-09-16 23:45:41 -0400782 if matches:
Jack Neus8edbf642019-07-10 16:08:31 -0600783 # If there's a match, throw an error.
784 error_msg = ('Changelist description contains the name of an'
785 ' %s: "%s".' % (name_type, '","'.join(matches)))
786 return HookFailure(error_msg)
787
Mike Frysinger8cf80812019-09-16 23:49:29 -0400788 return None
789
Jack Neus8edbf642019-07-10 16:08:31 -0600790
Mike Frysinger292b45d2014-11-25 01:17:10 -0500791def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -0700792 """Check that we're not missing a revbump of an ebuild in the given commit.
793
794 If the given commit touches files in a directory that has ebuilds somewhere
795 up the directory hierarchy, it's very likely that we need an ebuild revbump
796 in order for those changes to take effect.
797
798 It's not totally trivial to detect a revbump, so at least detect that an
799 ebuild with a revision number in it was touched. This should handle the
800 common case where we use a symlink to do the revbump.
801
802 TODO: it would be nice to enhance this hook to:
803 * Handle cases where people revbump with a slightly different syntax. I see
804 one ebuild (puppy) that revbumps with _pN. This is a false positive.
805 * Catches cases where people aren't using symlinks for revbumps. If they
806 edit a revisioned file directly (and are expected to rename it for revbump)
807 we'll miss that. Perhaps we could detect that the file touched is a
808 symlink?
809
810 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
811 still better off than without this check.
812
813 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700814 project: The Project to look at
Doug Anderson42b8a052013-06-26 10:45:36 -0700815 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -0500816 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -0700817
818 Returns:
819 A HookFailure or None.
820 """
Mike Frysinger011af942014-01-17 16:12:22 -0500821 # If this is the portage-stable overlay, then ignore the check. It's rare
822 # that we're doing anything other than importing files from upstream, so
823 # forcing a rev bump makes no sense.
824 whitelist = (
825 'chromiumos/overlays/portage-stable',
826 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700827 if project.name in whitelist:
Mike Frysinger011af942014-01-17 16:12:22 -0500828 return None
829
Mike Frysinger292b45d2014-11-25 01:17:10 -0500830 def FinalName(obj):
831 # If the file is being deleted, then the dst_file is not set.
832 if obj.dst_file is None:
833 return obj.src_file
834 else:
835 return obj.dst_file
836
837 affected_path_objs = _get_affected_files(
838 commit, include_deletes=True, include_symlinks=True, relative=True,
839 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -0700840
841 # Don't yell about changes to whitelisted files...
Mike Frysinger550c05c2019-12-09 18:16:36 -0500842 whitelist = {'ChangeLog', 'Manifest', 'metadata.xml'}
Mike Frysinger292b45d2014-11-25 01:17:10 -0500843 affected_path_objs = [x for x in affected_path_objs
844 if os.path.basename(FinalName(x)) not in whitelist]
845 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -0700846 return None
847
848 # If we've touched any file named with a -rN.ebuild then we'll say we're
849 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500850 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
851 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700852 if touched_revved_ebuild:
853 return None
854
Mike Frysinger292b45d2014-11-25 01:17:10 -0500855 # If we're creating new ebuilds from scratch, then we don't need an uprev.
856 # Find all the dirs that new ebuilds and ignore their files/.
857 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
858 if FinalName(x).endswith('.ebuild') and x.status == 'A']
859 affected_path_objs = [obj for obj in affected_path_objs
860 if not any(FinalName(obj).startswith(x)
861 for x in ebuild_dirs)]
862 if not affected_path_objs:
Mike Frysinger8cf80812019-09-16 23:49:29 -0400863 return None
Mike Frysinger292b45d2014-11-25 01:17:10 -0500864
Doug Anderson42b8a052013-06-26 10:45:36 -0700865 # We want to examine the current contents of all directories that are parents
866 # of files that were touched (up to the top of the project).
867 #
868 # ...note: we use the current directory contents even though it may have
869 # changed since the commit we're looking at. This is just a heuristic after
870 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500871 if project_top is None:
872 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -0700873 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -0500874 for obj in affected_path_objs:
875 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -0700876 while os.path.exists(path) and not os.path.samefile(path, project_top):
877 dirs_to_check.add(path)
878 path = os.path.dirname(path)
879
880 # Look through each directory. If it's got an ebuild in it then we'll
881 # consider this as a case when we need a revbump.
Gwendal Grignoua3086c32014-12-09 11:17:22 -0800882 affected_paths = set(os.path.join(project_top, FinalName(x))
883 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700884 for dir_path in dirs_to_check:
885 contents = os.listdir(dir_path)
886 ebuilds = [os.path.join(dir_path, path)
887 for path in contents if path.endswith('.ebuild')]
888 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
889
C Shapiroae157ae2017-09-18 16:24:03 -0600890 affected_paths_under_9999_ebuilds = set()
891 for affected_path in affected_paths:
892 for ebuild_9999 in ebuilds_9999:
893 ebuild_dir = os.path.dirname(ebuild_9999)
894 if affected_path.startswith(ebuild_dir):
895 affected_paths_under_9999_ebuilds.add(affected_path)
896
897 # If every file changed exists under a 9999 ebuild, then skip
898 if len(affected_paths_under_9999_ebuilds) == len(affected_paths):
899 continue
900
Doug Anderson42b8a052013-06-26 10:45:36 -0700901 # If the -9999.ebuild file was touched the bot will uprev for us.
902 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -0500903 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -0700904 continue
905
906 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500907 return HookFailure('Changelist probably needs a revbump of an ebuild, '
908 'or a -r1.ebuild symlink if this is a new ebuild:\n'
909 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -0700910
911 return None
912
913
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500914def _check_ebuild_eapi(project, commit):
Mike Frysinger948284a2018-02-01 15:22:56 -0500915 """Make sure we have people use EAPI=5 or newer with custom ebuilds.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500916
917 We want to get away from older EAPI's as it makes life confusing and they
918 have less builtin error checking.
919
920 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700921 project: The Project to look at
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500922 commit: The commit to look at
923
924 Returns:
925 A HookFailure or None.
926 """
927 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500928 # that we're doing anything other than importing files from upstream, and
929 # we shouldn't be rewriting things fundamentally anyways.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500930 whitelist = (
931 'chromiumos/overlays/portage-stable',
932 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700933 if project.name in whitelist:
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500934 return None
935
Mike Frysinger948284a2018-02-01 15:22:56 -0500936 BAD_EAPIS = ('0', '1', '2', '3', '4')
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500937
938 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
939
940 ebuilds_re = [r'\.ebuild$']
941 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
942 ebuilds_re)
943 bad_ebuilds = []
944
945 for ebuild in ebuilds:
946 # If the ebuild does not specify an EAPI, it defaults to 0.
947 eapi = '0'
948
949 lines = _get_file_content(ebuild, commit).splitlines()
950 if len(lines) == 1:
951 # This is most likely a symlink, so skip it entirely.
952 continue
953
954 for line in lines:
955 m = get_eapi.match(line)
956 if m:
957 # Once we hit the first EAPI line in this ebuild, stop processing.
958 # The spec requires that there only be one and it be first, so
959 # checking all possible values is pointless. We also assume that
960 # it's "the" EAPI line and not something in the middle of a heredoc.
961 eapi = m.group(1)
962 break
963
964 if eapi in BAD_EAPIS:
965 bad_ebuilds.append((ebuild, eapi))
966
967 if bad_ebuilds:
968 # pylint: disable=C0301
969 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
970 # pylint: enable=C0301
971 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500972 'These ebuilds are using old EAPIs. If these are imported from\n'
973 'Gentoo, then you may ignore and upload once with the --no-verify\n'
Mike Frysinger948284a2018-02-01 15:22:56 -0500974 'flag. Otherwise, please update to 5 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500975 '\t%s\n'
976 'See this guide for more details:\n%s\n' %
977 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
978
Mike Frysinger8cf80812019-09-16 23:49:29 -0400979 return None
980
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500981
Mike Frysinger89bdb852014-02-01 05:26:26 -0500982def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -0500983 """Make sure we use the new style KEYWORDS when possible in ebuilds.
984
985 If an ebuild generally does not care about the arch it is running on, then
986 ebuilds should flag it with one of:
987 KEYWORDS="*" # A stable ebuild.
988 KEYWORDS="~*" # An unstable ebuild.
989 KEYWORDS="-* ..." # Is known to only work on specific arches.
990
991 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700992 project: The Project to look at
Mike Frysingerc51ece72014-01-17 16:23:40 -0500993 commit: The commit to look at
994
995 Returns:
996 A HookFailure or None.
997 """
998 WHITELIST = set(('*', '-*', '~*'))
999
1000 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
1001
Mike Frysinger89bdb852014-02-01 05:26:26 -05001002 ebuilds_re = [r'\.ebuild$']
1003 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1004 ebuilds_re)
1005
Mike Frysinger8d42d742014-09-22 15:50:21 -04001006 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -05001007 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -04001008 # We get the full content rather than a diff as the latter does not work
1009 # on new files (like when adding new ebuilds).
1010 lines = _get_file_content(ebuild, commit).splitlines()
1011 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -05001012 m = get_keywords.match(line)
1013 if m:
1014 keywords = set(m.group(1).split())
1015 if not keywords or WHITELIST - keywords != WHITELIST:
1016 continue
1017
Mike Frysinger8d42d742014-09-22 15:50:21 -04001018 bad_ebuilds.append(ebuild)
1019
1020 if bad_ebuilds:
1021 return HookFailure(
1022 '%s\n'
1023 'Please update KEYWORDS to use a glob:\n'
1024 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
1025 ' KEYWORDS="*"\n'
1026 'If the ebuild should be marked unstable (normal for '
1027 'cros-workon / 9999 ebuilds):\n'
1028 ' KEYWORDS="~*"\n'
Mike Frysingerde8efea2015-05-17 03:42:26 -04001029 'If the ebuild needs to be marked for only specific arches, '
Mike Frysinger8d42d742014-09-22 15:50:21 -04001030 'then use -* like so:\n'
1031 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -05001032
Mike Frysinger8cf80812019-09-16 23:49:29 -04001033 return None
1034
Mike Frysingerc51ece72014-01-17 16:23:40 -05001035
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001036def _check_ebuild_licenses(_project, commit):
1037 """Check if the LICENSE field in the ebuild is correct."""
Brian Norris7a610e82016-02-17 12:24:54 -08001038 affected_paths = _get_affected_files(commit, relative=True)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001039 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
1040
1041 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -08001042 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001043
1044 for ebuild in touched_ebuilds:
1045 # Skip virutal packages.
1046 if ebuild.split('/')[-3] == 'virtual':
1047 continue
1048
Alex Kleinb5953522018-08-03 11:44:21 -06001049 # e.g. path/to/overlay/category/package/package.ebuild -> path/to/overlay
1050 overlay_path = os.sep.join(ebuild.split(os.sep)[:-3])
1051
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001052 try:
Brian Norris7a610e82016-02-17 12:24:54 -08001053 ebuild_content = _get_file_content(ebuild, commit)
Alex Kleinb5953522018-08-03 11:44:21 -06001054 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content,
1055 overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001056 except ValueError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001057 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001058
1059 # Also ignore licenses ending with '?'
1060 for license_type in [x for x in license_types
1061 if x not in LICENSES_IGNORE and not x.endswith('?')]:
1062 try:
Alex Kleinb5953522018-08-03 11:44:21 -06001063 licenses_lib.Licensing.FindLicenseType(license_type,
1064 overlay_path=overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001065 except AssertionError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001066 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001067
Mike Frysinger8cf80812019-09-16 23:49:29 -04001068 return None
1069
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001070
Mike Frysingercd363c82014-02-01 05:20:18 -05001071def _check_ebuild_virtual_pv(project, commit):
1072 """Enforce the virtual PV policies."""
1073 # If this is the portage-stable overlay, then ignore the check.
1074 # We want to import virtuals as-is from upstream Gentoo.
1075 whitelist = (
1076 'chromiumos/overlays/portage-stable',
1077 )
Alex Deymo643ac4c2015-09-03 10:40:50 -07001078 if project.name in whitelist:
Mike Frysingercd363c82014-02-01 05:20:18 -05001079 return None
1080
1081 # We assume the repo name is the same as the dir name on disk.
1082 # It would be dumb to not have them match though.
Alex Deymo643ac4c2015-09-03 10:40:50 -07001083 project_base = os.path.basename(project.name)
Mike Frysingercd363c82014-02-01 05:20:18 -05001084
1085 is_variant = lambda x: x.startswith('overlay-variant-')
1086 is_board = lambda x: x.startswith('overlay-')
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001087 is_baseboard = lambda x: x.startswith('baseboard-')
1088 is_chipset = lambda x: x.startswith('chipset-')
1089 is_project = lambda x: x.startswith('project-')
Mike Frysingercd363c82014-02-01 05:20:18 -05001090 is_private = lambda x: x.endswith('-private')
1091
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001092 is_special_overlay = lambda x: (is_board(x) or is_chipset(x) or
1093 is_baseboard(x) or is_project(x))
1094
Mike Frysingercd363c82014-02-01 05:20:18 -05001095 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
1096
1097 ebuilds_re = [r'\.ebuild$']
1098 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1099 ebuilds_re)
1100 bad_ebuilds = []
1101
1102 for ebuild in ebuilds:
1103 m = get_pv.match(ebuild)
1104 if m:
1105 overlay = m.group(1)
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001106 if not overlay or not is_special_overlay(overlay):
Alex Deymo643ac4c2015-09-03 10:40:50 -07001107 overlay = project_base
Mike Frysingercd363c82014-02-01 05:20:18 -05001108
1109 pv = m.group(3).split('-', 1)[0]
1110
Bernie Thompsone5ee1822016-01-12 14:22:23 -08001111 # Virtual versions >= 4 are special cases used above the standard
1112 # versioning structure, e.g. if one has a board inheriting a board.
1113 if float(pv) >= 4:
1114 want_pv = pv
Mike Frysingercd363c82014-02-01 05:20:18 -05001115 elif is_board(overlay):
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001116 if is_private(overlay):
1117 want_pv = '3.5' if is_variant(overlay) else '3'
1118 elif is_board(overlay):
1119 want_pv = '2.5' if is_variant(overlay) else '2'
1120 elif is_baseboard(overlay):
1121 want_pv = '1.9'
1122 elif is_chipset(overlay):
1123 want_pv = '1.8'
1124 elif is_project(overlay):
1125 want_pv = '1.7' if is_private(overlay) else '1.5'
Mike Frysingercd363c82014-02-01 05:20:18 -05001126 else:
1127 want_pv = '1'
1128
1129 if pv != want_pv:
1130 bad_ebuilds.append((ebuild, pv, want_pv))
1131
1132 if bad_ebuilds:
1133 # pylint: disable=C0301
1134 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
1135 # pylint: enable=C0301
1136 return HookFailure(
1137 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
1138 '\t%s\n'
1139 'If this is an upstream Gentoo virtual, then you may ignore this\n'
1140 'check (and re-run w/--no-verify). Otherwise, please see this\n'
1141 'page for more details:\n%s\n' %
1142 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
1143 for x in bad_ebuilds]), url))
1144
Mike Frysinger8cf80812019-09-16 23:49:29 -04001145 return None
1146
Mike Frysingercd363c82014-02-01 05:20:18 -05001147
Daniel Erat9d203ff2015-02-17 10:12:21 -07001148def _check_portage_make_use_var(_project, commit):
1149 """Verify that $USE is set correctly in make.conf and make.defaults."""
1150 files = _filter_files(_get_affected_files(commit, relative=True),
1151 [r'(^|/)make.(conf|defaults)$'])
1152
1153 errors = []
1154 for path in files:
1155 basename = os.path.basename(path)
1156
1157 # Has a USE= line already been encountered in this file?
1158 saw_use = False
1159
1160 for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1):
1161 if not line.startswith('USE='):
1162 continue
1163
1164 preserves_use = '${USE}' in line or '$USE' in line
1165
1166 if (basename == 'make.conf' or
1167 (basename == 'make.defaults' and saw_use)) and not preserves_use:
1168 errors.append('%s:%d: missing ${USE}' % (path, i))
1169 elif basename == 'make.defaults' and not saw_use and preserves_use:
1170 errors.append('%s:%d: ${USE} referenced in initial declaration' %
1171 (path, i))
1172
1173 saw_use = True
1174
1175 if errors:
1176 return HookFailure(
1177 'One or more Portage make files appear to set USE incorrectly.\n'
1178 '\n'
1179 'All USE assignments in make.conf and all assignments after the\n'
1180 'initial declaration in make.defaults should contain "${USE}" to\n'
1181 'preserve previously-set flags.\n'
1182 '\n'
1183 'The initial USE declaration in make.defaults should not contain\n'
1184 '"${USE}".\n',
1185 errors)
1186
Mike Frysinger8cf80812019-09-16 23:49:29 -04001187 return None
1188
Daniel Erat9d203ff2015-02-17 10:12:21 -07001189
Mike Frysingerae409522014-02-01 03:16:11 -05001190def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001191 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001192 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001193 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001194 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001195 if not m:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001196 return HookFailure('Last paragraph of description must include Change-Id.')
Ryan Cui1562fb82011-05-09 11:01:31 -07001197
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001198 # S-o-b tags always allowed to follow Change-ID.
LaMont Jones237f3ef2020-01-22 10:40:52 -07001199 allowed_tags = ['Signed-off-by', 'Cq-Cl-Tag']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001200
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001201 end = desc[m.end():].strip().splitlines()
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001202 cherry_pick_marker = 'cherry picked from commit'
1203
1204 if end and cherry_pick_marker in end[-1]:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001205 # Cherry picked patches allow more tags in the last paragraph.
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001206 allowed_tags += ['Commit-Queue', 'Commit-Ready', 'Reviewed-by',
1207 'Reviewed-on', 'Tested-by']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001208 end = end[:-1]
1209
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001210 # Note that descriptions could have multiple cherry pick markers.
1211 tag_search = r'^(%s:|\(%s) ' % (':|'.join(allowed_tags), cherry_pick_marker)
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001212
1213 if [x for x in end if not re.search(tag_search, x)]:
1214 return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' %
1215 ':", "'.join(allowed_tags))
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001216
Mike Frysinger8cf80812019-09-16 23:49:29 -04001217 return None
1218
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001219
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001220def _check_commit_message_style(_project, commit):
1221 """Verify that the commit message matches our style.
1222
1223 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
1224 commit hooks.
1225 """
Mike Frysingered9b2a02019-12-12 18:52:32 -05001226 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Mike Frysinger4efdee72019-11-04 10:57:01 -05001227
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001228 desc = _get_commit_desc(commit)
1229
1230 # The first line should be by itself.
1231 lines = desc.splitlines()
1232 if len(lines) > 1 and lines[1]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001233 return HookFailure('The second line of the commit message must be blank.'
1234 '\n%s' % (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001235
1236 # The first line should be one sentence.
1237 if '. ' in lines[0]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001238 return HookFailure('The first line cannot be more than one sentence.\n%s' %
1239 (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001240
1241 # The first line cannot be too long.
1242 MAX_FIRST_LINE_LEN = 100
1243 if len(lines[0]) > MAX_FIRST_LINE_LEN:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001244 return HookFailure('The first line must be less than %i chars.\n%s' %
1245 (MAX_FIRST_LINE_LEN, SEE_ALSO))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001246
Mike Frysinger8cf80812019-09-16 23:49:29 -04001247 return None
1248
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001249
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001250def _check_cros_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001251 """Verifies the Chromium OS license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -07001252
Mike Frysinger98638102014-08-28 00:15:08 -04001253 Should be following the spec:
1254 http://dev.chromium.org/developers/coding-style#TOC-File-headers
1255 """
1256 # For older years, be a bit more flexible as our policy says leave them be.
1257 LICENSE_HEADER = (
Keigo Oka7e880ac2019-07-03 15:03:43 +09001258 r'.*Copyright(?: \(c\))? (20[0-9]{2})(?:-20[0-9]{2})? The Chromium OS '
1259 r'Authors\. All rights reserved\.\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001260 r'.*Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001261 r'be\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001262 r'.*found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -05001263 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001264 )
1265 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1266
1267 # For newer years, be stricter.
Keigo Oka7e880ac2019-07-03 15:03:43 +09001268 BAD_COPYRIGHT_LINE = (
Brian Norris68838dd2018-09-26 18:30:24 -07001269 r'.*Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001270 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001271 )
Keigo Oka7e880ac2019-07-03 15:03:43 +09001272 bad_copyright_re = re.compile(BAD_COPYRIGHT_LINE)
Mike Frysinger98638102014-08-28 00:15:08 -04001273
Shuhei Takahashiabc20f32017-07-10 19:35:45 +09001274 included, excluded = _parse_common_inclusion_options(options)
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001275
Mike Frysinger98638102014-08-28 00:15:08 -04001276 bad_files = []
1277 bad_copyright_files = []
Keigo Oka7e880ac2019-07-03 15:03:43 +09001278 bad_year_files = []
1279
Ken Turnerd07564b2018-02-08 17:57:59 +11001280 files = _filter_files(
1281 _get_affected_files(commit, relative=True),
1282 included + COMMON_INCLUDED_PATHS,
1283 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001284 existing_files = set(_get_affected_files(commit, relative=True,
1285 include_adds=False))
Mike Frysinger98638102014-08-28 00:15:08 -04001286
Keigo Oka7e880ac2019-07-03 15:03:43 +09001287 current_year = str(datetime.datetime.now().year)
Mike Frysinger98638102014-08-28 00:15:08 -04001288 for f in files:
1289 contents = _get_file_content(f, commit)
1290 if not contents:
1291 # Ignore empty files.
1292 continue
1293
Keigo Oka7e880ac2019-07-03 15:03:43 +09001294 m = license_re.search(contents)
1295 if not m:
Mike Frysinger98638102014-08-28 00:15:08 -04001296 bad_files.append(f)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001297 elif bad_copyright_re.search(contents):
Mike Frysinger98638102014-08-28 00:15:08 -04001298 bad_copyright_files.append(f)
1299
Keigo Oka7e880ac2019-07-03 15:03:43 +09001300 if m and f not in existing_files:
1301 year = m.group(1)
1302 if year != current_year:
1303 bad_year_files.append(f)
1304
1305 errors = []
Mike Frysinger98638102014-08-28 00:15:08 -04001306 if bad_files:
1307 msg = '%s:\n%s\n%s' % (
1308 'License must match', license_re.pattern,
1309 'Found a bad header in these files:')
Keigo Oka7e880ac2019-07-03 15:03:43 +09001310 errors.append(HookFailure(msg, bad_files))
Mike Frysinger98638102014-08-28 00:15:08 -04001311 if bad_copyright_files:
1312 msg = 'Do not use (c) in copyright headers in new files:'
Keigo Oka7e880ac2019-07-03 15:03:43 +09001313 errors.append(HookFailure(msg, bad_copyright_files))
1314 if bad_year_files:
1315 msg = 'Use current year (%s) in copyright headers in new files:' % (
1316 current_year)
1317 errors.append(HookFailure(msg, bad_year_files))
Ryan Cuiec4d6332011-05-02 14:15:25 -07001318
Keigo Oka7e880ac2019-07-03 15:03:43 +09001319 return errors
Ryan Cuiec4d6332011-05-02 14:15:25 -07001320
Mike Frysinger8cf80812019-09-16 23:49:29 -04001321
Amin Hassani391efa92018-01-26 17:58:05 -08001322def _check_aosp_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001323 """Verifies the AOSP license/copyright header.
1324
1325 AOSP uses the Apache2 License:
1326 https://source.android.com/source/licenses.html
1327 """
1328 LICENSE_HEADER = (
1329 r"""^[#/\*]*
1330[#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project
1331[#/\*]* ?
1332[#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\);
1333[#/\*]* ?you may not use this file except in compliance with the License\.
1334[#/\*]* ?You may obtain a copy of the License at
1335[#/\*]* ?
1336[#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0
1337[#/\*]* ?
1338[#/\*]* ?Unless required by applicable law or agreed to in writing, software
1339[#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS,
1340[#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """
1341 r"""implied\.
1342[#/\*]* ?See the License for the specific language governing permissions and
1343[#/\*]* ?limitations under the License\.
1344[#/\*]*$
1345"""
1346 )
1347 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1348
Amin Hassani391efa92018-01-26 17:58:05 -08001349 included, excluded = _parse_common_inclusion_options(options)
1350
Ken Turnerd07564b2018-02-08 17:57:59 +11001351 files = _filter_files(
1352 _get_affected_files(commit, relative=True),
1353 included + COMMON_INCLUDED_PATHS,
1354 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Alex Deymof5792ce2015-08-24 22:50:08 -07001355
1356 bad_files = []
1357 for f in files:
1358 contents = _get_file_content(f, commit)
1359 if not contents:
1360 # Ignore empty files.
1361 continue
1362
1363 if not license_re.search(contents):
1364 bad_files.append(f)
1365
1366 if bad_files:
1367 msg = ('License must match:\n%s\nFound a bad header in these files:' %
1368 license_re.pattern)
1369 return HookFailure(msg, bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001370 return None
Alex Deymof5792ce2015-08-24 22:50:08 -07001371
1372
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001373def _check_layout_conf(_project, commit):
1374 """Verifies the metadata/layout.conf file."""
1375 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001376 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001377 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001378 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001379
Mike Frysinger94a670c2014-09-19 12:46:26 -04001380 # Handle multiple overlays in a single commit (like the public tree).
1381 for f in _get_affected_files(commit, relative=True):
1382 if f.endswith(repo_name):
1383 repo_names.append(f)
1384 elif f.endswith(layout_path):
1385 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001386
1387 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -04001388 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001389 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -04001390 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001391
Mike Frysinger94a670c2014-09-19 12:46:26 -04001392 # Gather all the errors in one pass so we show one full message.
1393 all_errors = {}
1394 for layout_path in layout_paths:
1395 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001396
Mike Frysinger94a670c2014-09-19 12:46:26 -04001397 # Make sure the config file is sorted.
1398 data = [x for x in _get_file_content(layout_path, commit).splitlines()
1399 if x and x[0] != '#']
1400 if sorted(data) != data:
1401 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001402
Mike Frysinger94a670c2014-09-19 12:46:26 -04001403 # Require people to set specific values all the time.
1404 settings = (
1405 # TODO: Enable this for everyone. http://crbug.com/408038
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001406 # ('fast caching', 'cache-format = md5-dict'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001407 ('fast manifests', 'thin-manifests = true'),
Mike Frysingerd7734522015-02-26 16:12:43 -05001408 ('extra features', 'profile-formats = portage-2 profile-default-eapi'),
1409 ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001410 )
1411 for reason, line in settings:
1412 if line not in data:
1413 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001414
Mike Frysinger94a670c2014-09-19 12:46:26 -04001415 # Require one of these settings.
Mike Frysinger5fae62d2015-11-11 20:12:15 -05001416 if 'use-manifests = strict' not in data:
1417 errors += ['enable file checking with: use-manifests = strict']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001418
Mike Frysinger94a670c2014-09-19 12:46:26 -04001419 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -04001420 for line in data:
1421 if line.startswith('repo-name = '):
1422 break
1423 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -04001424 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001425
Mike Frysinger94a670c2014-09-19 12:46:26 -04001426 # Summarize all the errors we saw (if any).
1427 lines = ''
1428 for layout_path, errors in all_errors.items():
1429 if errors:
1430 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
1431 if lines:
1432 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
1433 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001434
Mike Frysinger8cf80812019-09-16 23:49:29 -04001435 return None
1436
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001437
Keigo Oka4a09bd92019-05-07 14:01:00 +09001438def _check_no_new_gyp(_project, commit):
1439 """Verifies no project starts to use GYP."""
1440 whitelist = [
Keigo Oka4a09bd92019-05-07 14:01:00 +09001441 'chromeos/ap',
1442 'chromeos/ap-daemons',
Keigo Oka150a6fd2019-06-04 11:30:25 +09001443 'chromeos/ap/security',
1444 'chromeos/ap/wireless',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001445 'chromeos/platform/actions',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001446 'chromeos/platform/drivefs-google3',
1447 'chromeos/platform/experimental-touch-fw',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001448 'chromeos/thermald',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001449 'chromiumos/platform2',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001450 'weave/libweave',
1451 ]
1452 if _project.name in whitelist:
1453 return None
1454
1455 gypfiles = _filter_files(
1456 _get_affected_files(commit, include_symlinks=True, relative=True),
1457 [r'\.gyp$'])
1458
1459 if gypfiles:
1460 return HookFailure('GYP is deprecated and not allowed in a new project:',
1461 gypfiles)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001462 return None
Keigo Oka4a09bd92019-05-07 14:01:00 +09001463
1464
Ryan Cuiec4d6332011-05-02 14:15:25 -07001465# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001466
Ryan Cui1562fb82011-05-09 11:01:31 -07001467
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001468def _check_clang_format(_project, commit, options=()):
1469 """Runs clang-format on the given project"""
1470 hooks_dir = _get_hooks_dir()
1471 options = list(options)
1472 if commit == PRE_SUBMIT:
1473 options.append('--commit=HEAD')
1474 else:
1475 options.extend(['--commit', commit])
Brian Norris0c62a142018-12-11 13:24:29 -08001476 cmd = [os.path.join(hooks_dir, 'clang-format.py')] + options
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001477 cmd_result = cros_build_lib.run(cmd,
1478 print_cmd=False,
1479 stdout=True,
1480 encoding='utf-8',
1481 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001482 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001483 check=False)
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001484 if cmd_result.returncode:
1485 return HookFailure('clang-format.py errors/warnings\n\n' +
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001486 cmd_result.stdout)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001487 return None
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001488
1489
Mike Frysingerae409522014-02-01 03:16:11 -05001490def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001491 """Runs checkpatch.pl on the given project"""
1492 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001493 options = list(options)
1494 if commit == PRE_SUBMIT:
1495 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
1496 # this case.
1497 options.append('--ignore=MISSING_SIGN_OFF')
Filipe Brandenburger28d48d62015-10-07 09:48:54 -07001498 # Always ignore the check for the MAINTAINERS file. We do not track that
1499 # information on that file in our source trees, so let's suppress the
1500 # warning.
1501 options.append('--ignore=FILE_PATH_CHANGES')
Filipe Brandenburgerce978322015-10-09 10:04:15 -07001502 # Do not complain about the Change-Id: fields, since we use Gerrit.
1503 # Upstream does not want those lines (since they do not use Gerrit), but
1504 # we always do, so disable the check globally.
Daisuke Nojiri4844f892015-10-08 09:54:33 -07001505 options.append('--ignore=GERRIT_CHANGE_ID')
Brian Norris0c62a142018-12-11 13:24:29 -08001506 cmd = [os.path.join(hooks_dir, 'checkpatch.pl')] + options + ['-']
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001507 cmd_result = cros_build_lib.run(
1508 cmd, print_cmd=False, input=_get_patch(commit).encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001509 stdout=True, stderr=subprocess.STDOUT, check=False, encoding='utf-8',
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001510 errors='replace')
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001511 if cmd_result.returncode:
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001512 return HookFailure('checkpatch.pl errors/warnings\n\n' + cmd_result.stdout)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001513 return None
Ryan Cuiec4d6332011-05-02 14:15:25 -07001514
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001515
Brian Norris23c62e92018-11-14 12:25:51 -08001516def _run_kerneldoc(_project, commit, options=()):
1517 """Runs kernel-doc validator on the given project"""
1518 included, excluded = _parse_common_inclusion_options(options)
1519 files = _filter_files(_get_affected_files(commit, relative=True),
1520 included, excluded)
1521 if files:
1522 hooks_dir = _get_hooks_dir()
Brian Norris0c62a142018-12-11 13:24:29 -08001523 cmd = [os.path.join(hooks_dir, 'kernel-doc'), '-none'] + files
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001524 output = _run_command(cmd, stderr=subprocess.STDOUT)
Brian Norris23c62e92018-11-14 12:25:51 -08001525 if output:
Brian Norris0c62a142018-12-11 13:24:29 -08001526 return HookFailure('kernel-doc errors/warnings:',
1527 items=output.splitlines())
Mike Frysinger8cf80812019-09-16 23:49:29 -04001528 return None
Brian Norris23c62e92018-11-14 12:25:51 -08001529
1530
Mike Frysingerae409522014-02-01 03:16:11 -05001531def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -07001532 """Makes sure kernel config changes are not mixed with code changes"""
1533 files = _get_affected_files(commit)
Mike Frysingerf252cfc2019-12-09 17:34:28 -05001534 if len(_filter_files(files, [r'chromeos/config'])) not in [0, len(files)]:
Olof Johanssona96810f2012-09-04 16:20:03 -07001535 return HookFailure('Changes to chromeos/config/ and regular files must '
1536 'be in separate commits:\n%s' % '\n'.join(files))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001537 return None
Anton Staaf815d6852011-08-22 10:08:45 -07001538
Mike Frysingerae409522014-02-01 03:16:11 -05001539
1540def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -07001541 """Checks that all JSON files are syntactically valid."""
Mike Frysinger908be682018-01-04 02:21:50 -05001542 ret = []
1543
1544 files = _filter_files(_get_affected_files(commit, relative=True),
1545 [r'.*\.json$'])
1546 for f in files:
1547 data = _get_file_content(f, commit)
Dale Curtis2975c432011-05-03 17:25:20 -07001548 try:
Mike Frysinger908be682018-01-04 02:21:50 -05001549 json.loads(data)
1550 except Exception as e:
1551 ret.append('%s: Invalid JSON: %s' % (f, e))
1552
1553 if ret:
1554 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001555 return None
Dale Curtis2975c432011-05-03 17:25:20 -07001556
1557
Mike Frysingerae409522014-02-01 03:16:11 -05001558def _check_manifests(_project, commit):
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001559 """Make sure Manifest files only have comments & DIST lines."""
1560 ret = []
Mike Frysinger52b537e2013-08-22 22:59:53 -04001561
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001562 manifests = _filter_files(_get_affected_files(commit, relative=True),
1563 [r'.*/Manifest$'])
1564 for path in manifests:
1565 data = _get_file_content(path, commit)
1566
1567 # Disallow blank files.
1568 if not data.strip():
1569 ret.append('%s: delete empty file' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001570 continue
1571
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001572 # Make sure the last newline isn't omitted.
1573 if data[-1] != '\n':
1574 ret.append('%s: missing trailing newline' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001575
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001576 # Do not allow leading or trailing blank lines.
1577 lines = data.splitlines()
1578 if not lines[0]:
1579 ret.append('%s: delete leading blank lines' % (path,))
1580 if not lines[-1]:
1581 ret.append('%s: delete trailing blank lines' % (path,))
1582
1583 for line in lines:
1584 # Disallow leading/trailing whitespace.
1585 if line != line.strip():
1586 ret.append('%s: remove leading/trailing whitespace: %s' % (path, line))
1587
1588 # Allow blank lines & comments.
1589 line = line.split('#', 1)[0]
1590 if not line:
1591 continue
1592
1593 # All other linse should start with DIST.
1594 if not line.startswith('DIST '):
1595 ret.append('%s: remove non-DIST lines: %s' % (path, line))
1596 break
1597
1598 if ret:
1599 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001600 return None
Mike Frysinger52b537e2013-08-22 22:59:53 -04001601
1602
Mike Frysingerae409522014-02-01 03:16:11 -05001603def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001604 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001605 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001606 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001607 BRANCH_RE = r'\nBRANCH=\S+'
1608
1609 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
1610 msg = ('Changelist description needs BRANCH field (after first line)\n'
1611 'E.g. BRANCH=none or BRANCH=link,snow')
1612 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001613 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001614
1615
Mike Frysinger45334bd2019-11-04 10:42:33 -05001616def _check_change_has_no_branch_field(_project, commit):
1617 """Verify 'BRANCH=' field does not exist in the commit message."""
1618 if commit == PRE_SUBMIT:
1619 return None
1620 BRANCH_RE = r'\nBRANCH=\S+'
1621
1622 if re.search(BRANCH_RE, _get_commit_desc(commit)):
1623 msg = 'This checkout does not use BRANCH= fields. Delete them.'
1624 return HookFailure(msg)
1625 return None
1626
1627
Mike Frysingerae409522014-02-01 03:16:11 -05001628def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001629 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001630 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001631 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001632 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1633
1634 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1635 msg = ('Changelist description needs Signed-off-by: field\n'
1636 'E.g. Signed-off-by: My Name <me@chromium.org>')
1637 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001638 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001639
1640
Mike Frysinger9ab64b12019-11-04 10:53:08 -05001641def _check_change_has_no_signoff_field(_project, commit):
1642 """Verify 'Signed-off-by:' field does not exist in the commit message."""
1643 if commit == PRE_SUBMIT:
1644 return None
1645 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1646
1647 if re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1648 msg = 'This checkout does not use Signed-off-by: tags. Delete them.'
1649 return HookFailure(msg)
1650 return None
1651
1652
Jon Salz3ee59de2012-08-18 13:54:22 +08001653def _run_project_hook_script(script, project, commit):
1654 """Runs a project hook script.
1655
1656 The script is run with the following environment variables set:
1657 PRESUBMIT_PROJECT: The affected project
1658 PRESUBMIT_COMMIT: The affected commit
1659 PRESUBMIT_FILES: A newline-separated list of affected files
1660
1661 The script is considered to fail if the exit code is non-zero. It should
1662 write an error message to stdout.
1663 """
1664 env = dict(os.environ)
Alex Deymo643ac4c2015-09-03 10:40:50 -07001665 env['PRESUBMIT_PROJECT'] = project.name
Jon Salz3ee59de2012-08-18 13:54:22 +08001666 env['PRESUBMIT_COMMIT'] = commit
1667
1668 # Put affected files in an environment variable
1669 files = _get_affected_files(commit)
1670 env['PRESUBMIT_FILES'] = '\n'.join(files)
1671
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001672 cmd_result = cros_build_lib.run(cmd=script,
1673 env=env,
1674 shell=True,
1675 print_cmd=False,
1676 input=os.devnull,
1677 stdout=True,
1678 encoding='utf-8',
1679 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001680 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001681 check=False)
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001682 if cmd_result.returncode:
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001683 stdout = cmd_result.stdout
Jon Salz7b618af2012-08-31 06:03:16 +08001684 if stdout:
1685 stdout = re.sub('(?m)^', ' ', stdout)
1686 return HookFailure('Hook script "%s" failed with code %d%s' %
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001687 (script, cmd_result.returncode,
Jon Salz3ee59de2012-08-18 13:54:22 +08001688 ':\n' + stdout if stdout else ''))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001689 return None
Jon Salz3ee59de2012-08-18 13:54:22 +08001690
1691
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001692def _check_project_prefix(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -05001693 """Require the commit message have a project specific prefix as needed."""
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001694
Brian Norris77608e12018-04-06 10:38:43 -07001695 files = _get_affected_files(commit, include_deletes=True, relative=True)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001696 prefix = os.path.commonprefix(files)
1697 prefix = os.path.dirname(prefix)
1698
1699 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07001700 if not prefix:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001701 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001702
1703 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07001704
1705 # The common files may all be within a subdirectory of the main project
1706 # directory, so walk up the tree until we find an alias file.
1707 # _get_affected_files() should return relative paths, but check against '/' to
1708 # ensure that this loop terminates even if it receives an absolute path.
1709 while prefix and prefix != '/':
1710 alias_file = os.path.join(prefix, '.project_alias')
1711
1712 # If an alias exists, use it.
1713 if os.path.isfile(alias_file):
1714 project_name = osutils.ReadFile(alias_file).strip()
1715
1716 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001717
1718 if not _get_commit_desc(commit).startswith(project_name + ': '):
1719 return HookFailure('The commit title for changes affecting only %s'
1720 ' should start with \"%s: \"'
1721 % (project_name, project_name))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001722 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001723
1724
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001725def _check_filepath_chartype(_project, commit):
1726 """Checks that FilePath::CharType stuff is not used."""
1727
1728 FILEPATH_REGEXP = re.compile('|'.join(
1729 [r'(?:base::)?FilePath::(?:Char|String|StringPiece)Type',
Satoru Takabayashi4ca37922018-08-08 10:16:38 +09001730 r'(?:base::)?FilePath::FromUTF8Unsafe',
1731 r'AsUTF8Unsafe',
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001732 r'FILE_PATH_LITERAL']))
1733 files = _filter_files(_get_affected_files(commit, relative=True),
1734 [r'.*\.(cc|h)$'])
1735
1736 errors = []
1737 for afile in files:
1738 for line_num, line in _get_file_diff(afile, commit):
1739 m = re.search(FILEPATH_REGEXP, line)
1740 if m:
1741 errors.append('%s, line %s has %s' % (afile, line_num, m.group(0)))
1742
1743 if errors:
1744 msg = 'Please assume FilePath::CharType is char (crbug.com/870621):'
1745 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001746 return None
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001747
1748
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001749def _check_exec_files(_project, commit):
1750 """Make +x bits on files."""
1751 # List of files that should never be +x.
1752 NO_EXEC = (
1753 'ChangeLog*',
1754 'COPYING',
1755 'make.conf',
1756 'make.defaults',
1757 'Manifest',
1758 'OWNERS',
1759 'package.use',
1760 'package.keywords',
1761 'package.mask',
1762 'parent',
1763 'README',
1764 'TODO',
1765 '.gitignore',
1766 '*.[achly]',
1767 '*.[ch]xx',
1768 '*.boto',
1769 '*.cc',
1770 '*.cfg',
1771 '*.conf',
1772 '*.config',
1773 '*.cpp',
1774 '*.css',
1775 '*.ebuild',
1776 '*.eclass',
Tatsuhisa Yamaguchi3b053632019-01-10 14:45:14 +09001777 '*.gn',
1778 '*.gni',
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001779 '*.gyp',
1780 '*.gypi',
1781 '*.htm',
1782 '*.html',
1783 '*.ini',
1784 '*.js',
1785 '*.json',
1786 '*.md',
1787 '*.mk',
1788 '*.patch',
1789 '*.policy',
1790 '*.proto',
1791 '*.raw',
1792 '*.rules',
1793 '*.service',
1794 '*.target',
1795 '*.txt',
1796 '*.xml',
1797 '*.yaml',
1798 )
1799
1800 def FinalName(obj):
1801 # If the file is being deleted, then the dst_file is not set.
1802 if obj.dst_file is None:
1803 return obj.src_file
1804 else:
1805 return obj.dst_file
1806
1807 bad_files = []
1808 files = _get_affected_files(commit, relative=True, full_details=True)
1809 for f in files:
1810 mode = int(f.dst_mode, 8)
1811 if not mode & 0o111:
1812 continue
1813 name = FinalName(f)
1814 for no_exec in NO_EXEC:
1815 if fnmatch.fnmatch(name, no_exec):
1816 bad_files.append(name)
1817 break
1818
1819 if bad_files:
1820 return HookFailure('These files should not be executable. '
1821 'Please `chmod -x` them.', bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001822 return None
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001823
1824
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001825# Base
1826
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001827# A list of hooks which are not project specific and check patch description
1828# (as opposed to patch body).
1829_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07001830 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07001831 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07001832 _check_change_has_test_field,
1833 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001834 _check_commit_message_style,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001835 _check_change_is_contribution,
Jack Neus8edbf642019-07-10 16:08:31 -06001836 _check_change_no_include_oem,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001837]
1838
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001839# A list of hooks that are not project-specific
1840_COMMON_HOOKS = [
Aviv Keshet5ac59522017-01-31 14:28:27 -08001841 _check_cros_license,
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001842 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05001843 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001844 _check_ebuild_licenses,
Mike Frysingercd363c82014-02-01 05:20:18 -05001845 _check_ebuild_virtual_pv,
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001846 _check_exec_files,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001847 _check_for_uprev,
Rahul Chaudhry09f61372015-07-31 17:14:26 -07001848 _check_gofmt,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001849 _check_layout_conf,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001850 _check_no_long_lines,
Keigo Oka4a09bd92019-05-07 14:01:00 +09001851 _check_no_new_gyp,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001852 _check_no_stray_whitespace,
Ryan Cui9b651632011-05-11 11:38:58 -07001853 _check_no_tabs,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001854 _check_portage_make_use_var,
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -06001855 _check_rustfmt,
Aviv Keshet5ac59522017-01-31 14:28:27 -08001856 _check_tabbed_indents,
Ryan Cui9b651632011-05-11 11:38:58 -07001857]
Ryan Cuiec4d6332011-05-02 14:15:25 -07001858
Ryan Cui1562fb82011-05-09 11:01:31 -07001859
Ryan Cui9b651632011-05-11 11:38:58 -07001860# A dictionary of project-specific hooks(callbacks), indexed by project name.
1861# dict[project] = [callback1, callback2]
1862_PROJECT_SPECIFIC_HOOKS = {
Mike Frysinger24dd3c52019-08-17 14:22:48 -04001863 'chromiumos/third_party/kernel': [_kernel_configcheck],
1864 'chromiumos/third_party/kernel-next': [_kernel_configcheck],
Ryan Cui9b651632011-05-11 11:38:58 -07001865}
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001866
Ryan Cui1562fb82011-05-09 11:01:31 -07001867
Ryan Cui9b651632011-05-11 11:38:58 -07001868# A dictionary of flags (keys) that can appear in the config file, and the hook
Mike Frysinger3554bc92015-03-11 04:59:21 -04001869# that the flag controls (value).
1870_HOOK_FLAGS = {
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001871 'clang_format_check': _check_clang_format,
Mike Frysingera7642f52015-03-25 18:31:42 -04001872 'checkpatch_check': _run_checkpatch,
Brian Norris23c62e92018-11-14 12:25:51 -08001873 'kerneldoc_check': _run_kerneldoc,
Ryan Cui9b651632011-05-11 11:38:58 -07001874 'stray_whitespace_check': _check_no_stray_whitespace,
Mike Frysingerff6c7d62015-03-24 13:49:46 -04001875 'json_check': _run_json_check,
Ryan Cui9b651632011-05-11 11:38:58 -07001876 'long_line_check': _check_no_long_lines,
Alex Deymof5792ce2015-08-24 22:50:08 -07001877 'cros_license_check': _check_cros_license,
1878 'aosp_license_check': _check_aosp_license,
LaMont Jones872fe762020-02-10 15:36:14 -07001879 'gofmt_check': _check_gofmt,
Ryan Cui9b651632011-05-11 11:38:58 -07001880 'tab_check': _check_no_tabs,
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08001881 'tabbed_indent_required_check': _check_tabbed_indents,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001882 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001883 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07001884 'bug_field_check': _check_change_has_bug_field,
1885 'test_field_check': _check_change_has_test_field,
Steve Fung49ec7e92015-03-23 16:07:12 -07001886 'manifest_check': _check_manifests,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001887 'contribution_check': _check_change_is_contribution,
Mike Frysinger47bd1252018-06-11 12:12:20 -04001888 'project_prefix_check': _check_project_prefix,
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001889 'filepath_chartype_check': _check_filepath_chartype,
Ryan Cui9b651632011-05-11 11:38:58 -07001890}
1891
1892
Mike Frysinger3554bc92015-03-11 04:59:21 -04001893def _get_override_hooks(config):
1894 """Returns a set of hooks controlled by the current project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001895
1896 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08001897
1898 Args:
1899 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001900 """
1901 SECTION = 'Hook Overrides'
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001902 SECTION_OPTIONS = 'Hook Overrides Options'
Ryan Cui9b651632011-05-11 11:38:58 -07001903
Mike Frysinger56e8de02019-07-31 14:40:14 -04001904 valid_keys = set(_HOOK_FLAGS.keys())
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001905 hooks = _HOOK_FLAGS.copy()
Mike Frysinger380592f2020-02-03 15:27:16 -05001906 options = config.options(SECTION) if config.has_section(SECTION) else []
Mike Frysinger3554bc92015-03-11 04:59:21 -04001907
1908 enable_flags = []
Ryan Cui9b651632011-05-11 11:38:58 -07001909 disable_flags = []
Mike Frysinger380592f2020-02-03 15:27:16 -05001910 for flag in options:
Mike Frysinger3554bc92015-03-11 04:59:21 -04001911 if flag not in valid_keys:
1912 raise ValueError('Error: unknown key "%s" in hook section of "%s"' %
1913 (flag, _CONFIG_FILE))
1914
Ryan Cui9b651632011-05-11 11:38:58 -07001915 try:
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001916 enabled = config.getboolean(SECTION, flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001917 except ValueError as e:
Mike Frysinger3554bc92015-03-11 04:59:21 -04001918 raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' %
1919 (flag, _CONFIG_FILE, e))
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001920 if enabled:
1921 enable_flags.append(flag)
1922 else:
1923 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001924
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001925 # See if this hook has custom options.
1926 if enabled:
1927 try:
1928 options = config.get(SECTION_OPTIONS, flag)
1929 hooks[flag] = functools.partial(hooks[flag], options=options.split())
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001930 hooks[flag].__name__ = flag
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04001931 except (configparser.NoOptionError, configparser.NoSectionError):
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001932 pass
1933
1934 enabled_hooks = set(hooks[x] for x in enable_flags)
1935 disabled_hooks = set(hooks[x] for x in disable_flags)
Mike Frysinger45334bd2019-11-04 10:42:33 -05001936
Mike Frysinger9ab64b12019-11-04 10:53:08 -05001937 if _check_change_has_signoff_field not in enabled_hooks:
1938 enabled_hooks.add(_check_change_has_no_signoff_field)
Mike Frysinger45334bd2019-11-04 10:42:33 -05001939 if _check_change_has_branch_field not in enabled_hooks:
1940 enabled_hooks.add(_check_change_has_no_branch_field)
1941
Mike Frysinger3554bc92015-03-11 04:59:21 -04001942 return enabled_hooks, disabled_hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001943
1944
Jon Salz3ee59de2012-08-18 13:54:22 +08001945def _get_project_hook_scripts(config):
1946 """Returns a list of project-specific hook scripts.
1947
1948 Args:
1949 config: A ConfigParser for the project's config file.
1950 """
1951 SECTION = 'Hook Scripts'
1952 if not config.has_section(SECTION):
1953 return []
1954
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001955 return config.items(SECTION)
Jon Salz3ee59de2012-08-18 13:54:22 +08001956
1957
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001958def _get_project_hooks(project, presubmit):
Ryan Cui9b651632011-05-11 11:38:58 -07001959 """Returns a list of hooks that need to be run for a project.
1960
1961 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001962
1963 Args:
1964 project: A string, name of the project.
1965 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui9b651632011-05-11 11:38:58 -07001966 """
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04001967 config = configparser.RawConfigParser()
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001968 if not os.path.exists(_CONFIG_FILE):
Jon Salz3ee59de2012-08-18 13:54:22 +08001969 # Just use an empty config file
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04001970 config = configparser.RawConfigParser()
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001971 else:
1972 config.read(_CONFIG_FILE)
Jon Salz3ee59de2012-08-18 13:54:22 +08001973
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001974 if presubmit:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001975 hooks = _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001976 else:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001977 hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001978
Mike Frysinger3554bc92015-03-11 04:59:21 -04001979 enabled_hooks, disabled_hooks = _get_override_hooks(config)
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001980 hooks = [hook for hook in hooks if hook not in disabled_hooks]
1981
1982 # If a list is both in _COMMON_HOOKS and also enabled explicitly through an
1983 # override, keep the override only. Note that the override may end up being
1984 # a functools.partial, in which case we need to extract the .func to compare
1985 # it to the common hooks.
1986 unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks]
1987 hooks = [hook for hook in hooks if hook not in unwrapped_hooks]
1988
1989 hooks = list(enabled_hooks) + hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001990
1991 if project in _PROJECT_SPECIFIC_HOOKS:
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001992 hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project]
1993 if hook not in disabled_hooks)
Ryan Cui9b651632011-05-11 11:38:58 -07001994
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001995 for name, script in _get_project_hook_scripts(config):
1996 func = functools.partial(_run_project_hook_script, script)
1997 func.__name__ = name
1998 hooks.append(func)
Jon Salz3ee59de2012-08-18 13:54:22 +08001999
Ryan Cui9b651632011-05-11 11:38:58 -07002000 return hooks
2001
2002
Alex Deymo643ac4c2015-09-03 10:40:50 -07002003def _run_project_hooks(project_name, proj_dir=None,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002004 commit_list=None, presubmit=False):
Ryan Cui1562fb82011-05-09 11:01:31 -07002005 """For each project run its project specific hook from the hooks dictionary.
2006
2007 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002008 project_name: The name of project to run hooks for.
Doug Anderson44a644f2011-11-02 10:37:37 -07002009 proj_dir: If non-None, this is the directory the project is in. If None,
2010 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07002011 commit_list: A list of commits to run hooks against. If None or empty list
2012 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002013 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui1562fb82011-05-09 11:01:31 -07002014
2015 Returns:
2016 Boolean value of whether any errors were ecountered while running the hooks.
2017 """
Doug Anderson44a644f2011-11-02 10:37:37 -07002018 if proj_dir is None:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002019 proj_dirs = _run_command(
2020 ['repo', 'forall', project_name, '-c', 'pwd']).split()
Mike Frysingere52b1bc2019-09-16 23:45:41 -04002021 if not proj_dirs:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002022 print('%s cannot be found.' % project_name, file=sys.stderr)
David James2edd9002013-10-11 14:09:19 -07002023 print('Please specify a valid project.', file=sys.stderr)
2024 return True
2025 if len(proj_dirs) > 1:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002026 print('%s is associated with multiple directories.' % project_name,
David James2edd9002013-10-11 14:09:19 -07002027 file=sys.stderr)
2028 print('Please specify a directory to help disambiguate.', file=sys.stderr)
2029 return True
2030 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07002031
Ryan Cuiec4d6332011-05-02 14:15:25 -07002032 pwd = os.getcwd()
2033 # hooks assume they are run from the root of the project
2034 os.chdir(proj_dir)
2035
Mike Frysingered1b95a2019-12-12 19:04:51 -05002036 color = terminal.Color()
2037
Alex Deymo643ac4c2015-09-03 10:40:50 -07002038 remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref',
2039 '--symbolic-full-name', '@{u}']).strip()
2040 if not remote_branch:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002041 print("Your project %s doesn't track any remote repo." % project_name,
Alex Deymo643ac4c2015-09-03 10:40:50 -07002042 file=sys.stderr)
2043 remote = None
2044 else:
Josh Pratt15d13ab2018-08-13 11:52:48 +10002045 branch_items = remote_branch.split('/', 1)
2046 if len(branch_items) != 2:
2047 PrintErrorForProject(
2048 project_name,
2049 HookFailure(
2050 'Cannot get remote and branch name (%s)' % remote_branch))
2051 os.chdir(pwd)
2052 return True
2053 remote, _branch = branch_items
Alex Deymo643ac4c2015-09-03 10:40:50 -07002054
2055 project = Project(name=project_name, dir=proj_dir, remote=remote)
2056
Doug Anderson14749562013-06-26 13:38:29 -07002057 if not commit_list:
2058 try:
2059 commit_list = _get_commits()
2060 except VerifyException as e:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002061 PrintErrorForProject(project.name, HookFailure(str(e)))
Doug Anderson14749562013-06-26 13:38:29 -07002062 os.chdir(pwd)
2063 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07002064
Alex Deymo643ac4c2015-09-03 10:40:50 -07002065 hooks = _get_project_hooks(project.name, presubmit)
Ryan Cui1562fb82011-05-09 11:01:31 -07002066 error_found = False
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002067 commit_count = len(commit_list)
Mike Frysingerb99b3772019-08-17 14:19:44 -04002068 hook_count = len(hooks)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002069 for i, commit in enumerate(commit_list):
Mike Frysingerb2496652019-09-12 23:35:46 -04002070 CACHE.clear()
2071
Mike Frysingered1b95a2019-12-12 19:04:51 -05002072 desc = _get_commit_desc(commit)
2073 print('[%s %i/%i %s] %s' %
2074 (color.Color(color.CYAN, 'COMMIT'), i + 1, commit_count, commit[0:12],
2075 desc.splitlines()[0]))
2076
Mike Frysingerb99b3772019-08-17 14:19:44 -04002077 for h, hook in enumerate(hooks):
Mike Frysingered1b95a2019-12-12 19:04:51 -05002078 output = ('[%s %i/%i PRESUBMIT.cfg] %s' %
2079 (color.Color(color.YELLOW, 'RUNNING'), h + 1, hook_count,
2080 hook.__name__))
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002081 print(output, end='\r')
2082 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002083 hook_error = hook(project, commit)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002084 print(' ' * len(output), end='\r')
2085 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002086 if hook_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002087 if not isinstance(hook_error, list):
2088 hook_error = [hook_error]
2089 PrintErrorsForCommit(color, hook, project.name, hook_error)
Ryan Cui1562fb82011-05-09 11:01:31 -07002090 error_found = True
Don Garrettdba548a2011-05-05 15:17:14 -07002091
Ryan Cuiec4d6332011-05-02 14:15:25 -07002092 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07002093 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002094
Mike Frysingerae409522014-02-01 03:16:11 -05002095
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002096# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002097
Ryan Cui1562fb82011-05-09 11:01:31 -07002098
Mike Frysingerae409522014-02-01 03:16:11 -05002099def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08002100 """Main function invoked directly by repo.
2101
2102 This function will exit directly upon error so that repo doesn't print some
2103 obscure error message.
2104
2105 Args:
2106 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07002107 worktree_list: A list of directories. It should be the same length as
2108 project_list, so that each entry in project_list matches with a directory
2109 in worktree_list. If None, we will attempt to calculate the directories
2110 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08002111 kwargs: Leave this here for forward-compatibility.
2112 """
Mike Frysingered1b95a2019-12-12 19:04:51 -05002113 start_time = datetime.datetime.now()
Ryan Cui1562fb82011-05-09 11:01:31 -07002114 found_error = False
David James2edd9002013-10-11 14:09:19 -07002115 if not worktree_list:
2116 worktree_list = [None] * len(project_list)
2117 for project, worktree in zip(project_list, worktree_list):
2118 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07002119 found_error = True
2120
Mike Frysingered1b95a2019-12-12 19:04:51 -05002121 end_time = datetime.datetime.now()
2122 color = terminal.Color()
Mike Frysingerae409522014-02-01 03:16:11 -05002123 if found_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002124 msg = ('%s: Preupload failed due to above error(s).\n'
Ryan Cui9b651632011-05-11 11:38:58 -07002125 '- To disable some source style checks, and for other hints, see '
Mike Frysingered1b95a2019-12-12 19:04:51 -05002126 '<checkout_dir>/src/repohooks/README.md\n'
2127 "- To upload only current project, run 'repo upload .'" %
2128 (color.Color(color.RED, 'FATAL'),))
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04002129 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07002130 sys.exit(1)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002131 else:
2132 msg = ('[%s] repohooks passed in %s' %
2133 (color.Color(color.GREEN, 'PASSED'), end_time - start_time))
2134 print(msg)
Anush Elangovan63afad72011-03-23 00:41:27 -07002135
Ryan Cui1562fb82011-05-09 11:01:31 -07002136
Doug Anderson44a644f2011-11-02 10:37:37 -07002137def _identify_project(path):
2138 """Identify the repo project associated with the given path.
2139
2140 Returns:
2141 A string indicating what project is associated with the path passed in or
2142 a blank string upon failure.
2143 """
2144 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002145 stderr=True, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002146
2147
Mike Frysinger55f85b52014-12-18 14:45:21 -05002148def direct_main(argv):
Doug Anderson44a644f2011-11-02 10:37:37 -07002149 """Run hooks directly (outside of the context of repo).
2150
Doug Anderson44a644f2011-11-02 10:37:37 -07002151 Args:
Mike Frysinger55f85b52014-12-18 14:45:21 -05002152 argv: The command line args to process
Doug Anderson44a644f2011-11-02 10:37:37 -07002153
2154 Returns:
2155 0 if no pre-upload failures, 1 if failures.
2156
2157 Raises:
2158 BadInvocation: On some types of invocation errors.
2159 """
Mike Frysinger66142932014-12-18 14:55:57 -05002160 parser = commandline.ArgumentParser(description=__doc__)
2161 parser.add_argument('--dir', default=None,
2162 help='The directory that the project lives in. If not '
2163 'specified, use the git project root based on the cwd.')
2164 parser.add_argument('--project', default=None,
2165 help='The project repo path; this can affect how the '
2166 'hooks get run, since some hooks are project-specific. '
2167 'For chromite this is chromiumos/chromite. If not '
2168 'specified, the repo tool will be used to figure this '
2169 'out based on the dir.')
2170 parser.add_argument('--rerun-since', default=None,
Vadim Bendebury75447b92018-01-10 12:06:01 -08002171 help='Rerun hooks on old commits since some point '
2172 'in the past. The argument could be a date (should '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002173 "match git log's concept of a date, e.g. 2012-06-20), "
Vadim Bendebury75447b92018-01-10 12:06:01 -08002174 'or a SHA1, or just a number of commits to check (from 1 '
2175 'to 99). This option is mutually exclusive with '
2176 '--pre-submit.')
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002177 parser.add_argument('--pre-submit', action='store_true',
Mike Frysinger66142932014-12-18 14:55:57 -05002178 help='Run the check against the pending commit. '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002179 "This option should be used at the 'git commit' "
2180 "phase as opposed to 'repo upload'. This option "
Mike Frysinger66142932014-12-18 14:55:57 -05002181 'is mutually exclusive with --rerun-since.')
2182 parser.add_argument('commits', nargs='*',
2183 help='Check specific commits')
2184 opts = parser.parse_args(argv)
Doug Anderson44a644f2011-11-02 10:37:37 -07002185
Doug Anderson14749562013-06-26 13:38:29 -07002186 if opts.rerun_since:
Mike Frysinger66142932014-12-18 14:55:57 -05002187 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002188 raise BadInvocation("Can't pass commits and use rerun-since: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002189 ' '.join(opts.commits))
Doug Anderson14749562013-06-26 13:38:29 -07002190
Vadim Bendebury75447b92018-01-10 12:06:01 -08002191 if len(opts.rerun_since) < 3 and opts.rerun_since.isdigit():
2192 # This must be the number of commits to check. We don't expect the user
2193 # to want to check more than 99 commits.
2194 limit = '-n%s' % opts.rerun_since
2195 elif git.IsSHA1(opts.rerun_since, False):
2196 limit = '%s..' % opts.rerun_since
2197 else:
2198 # This better be a date.
2199 limit = '--since=%s' % opts.rerun_since
2200 cmd = ['git', 'log', limit, '--pretty=%H']
Doug Anderson14749562013-06-26 13:38:29 -07002201 all_commits = _run_command(cmd).splitlines()
2202 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
2203
2204 # Eliminate chrome-bot commits but keep ordering the same...
2205 bot_commits = set(bot_commits)
Mike Frysinger66142932014-12-18 14:55:57 -05002206 opts.commits = [c for c in all_commits if c not in bot_commits]
Doug Anderson14749562013-06-26 13:38:29 -07002207
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002208 if opts.pre_submit:
2209 raise BadInvocation('rerun-since and pre-submit can not be '
2210 'used together')
2211 if opts.pre_submit:
Mike Frysinger66142932014-12-18 14:55:57 -05002212 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002213 raise BadInvocation("Can't pass commits and use pre-submit: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002214 ' '.join(opts.commits))
2215 opts.commits = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07002216
2217 # Check/normlaize git dir; if unspecified, we'll use the root of the git
2218 # project from CWD
2219 if opts.dir is None:
2220 git_dir = _run_command(['git', 'rev-parse', '--git-dir'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002221 stderr=True).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002222 if not git_dir:
2223 raise BadInvocation('The current directory is not part of a git project.')
2224 opts.dir = os.path.dirname(os.path.abspath(git_dir))
2225 elif not os.path.isdir(opts.dir):
2226 raise BadInvocation('Invalid dir: %s' % opts.dir)
2227 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
2228 raise BadInvocation('Not a git directory: %s' % opts.dir)
2229
2230 # Identify the project if it wasn't specified; this _requires_ the repo
2231 # tool to be installed and for the project to be part of a repo checkout.
2232 if not opts.project:
2233 opts.project = _identify_project(opts.dir)
2234 if not opts.project:
2235 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
2236
Doug Anderson14749562013-06-26 13:38:29 -07002237 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Mike Frysinger66142932014-12-18 14:55:57 -05002238 commit_list=opts.commits,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002239 presubmit=opts.pre_submit)
Doug Anderson44a644f2011-11-02 10:37:37 -07002240 if found_error:
2241 return 1
2242 return 0
2243
2244
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002245if __name__ == '__main__':
Mike Frysinger55f85b52014-12-18 14:45:21 -05002246 sys.exit(direct_main(sys.argv[1:]))