blob: c0bd20b32b60bd7ab4589e32c99f67bd4387972c [file] [log] [blame]
Mike Frysinger4f994402019-09-13 17:40:45 -04001#!/usr/bin/env python3
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002# -*- coding: utf-8 -*-
Jon Salz98255932012-08-18 14:48:02 +08003# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
Mike Frysingerae409522014-02-01 03:16:11 -05007"""Presubmit checks to run when doing `repo upload`.
8
9You can add new checks by adding a functions to the HOOKS constants.
10"""
11
Mike Frysinger09d6a3d2013-10-08 22:21:03 -040012from __future__ import print_function
13
Keigo Okadd908822019-06-04 11:30:25 +090014import argparse
Alex Deymo643ac4c2015-09-03 10:40:50 -070015import collections
Mike Frysingerf252cfc2019-12-09 17:34:28 -050016import configparser
Keigo Oka7e880ac2019-07-03 15:03:43 +090017import datetime
Daniel Erate3ea3fc2015-02-13 15:27:52 -070018import fnmatch
Jon Salz3ee59de2012-08-18 13:54:22 +080019import functools
Dale Curtis2975c432011-05-03 17:25:20 -070020import json
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070021import os
Ryan Cuiec4d6332011-05-02 14:15:25 -070022import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070023import sys
Peter Ammon811f6702014-06-12 15:45:38 -070024import stat
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -050025import subprocess
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070026
Ryan Cui1562fb82011-05-09 11:01:31 -070027from errors import (VerifyException, HookFailure, PrintErrorForProject,
28 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070029
Mike Frysinger919c7032019-09-13 17:48:08 -040030if __name__ in ('__builtin__', 'builtins'):
Mike Frysinger653cd262019-09-20 14:05:02 -040031 # If repo imports us, the __name__ will be __builtin__, and the cwd will be in
32 # the top level of the checkout (i.e. $CHROMEOS_CHECKOUT). chromite will be
33 # in that directory, so add it to our path. This works whether we're running
34 # the repo in $CHROMEOS_CHECKOUT/.repo/repo/ or a custom version in a
35 # completely different tree.
36 # TODO(vapier): Python 2 used "__builtin__" while Python 3 uses "builtins".
Mike Frysinger6850d512018-05-21 12:12:14 -040037 sys.path.insert(0, os.getcwd())
38
Mike Frysinger653cd262019-09-20 14:05:02 -040039elif __name__ == '__main__':
40 # If we're run directly, we'll find chromite relative to the repohooks dir in
41 # $CHROMEOS_CHECKOUT/src/repohooks, so go up two dirs.
David Jamesc3b68b32013-04-03 09:17:03 -070042 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
43
Mike Frysingerfd481ce2019-09-13 18:14:48 -040044# The sys.path monkey patching confuses the linter.
45# pylint: disable=wrong-import-position
Mike Frysinger66142932014-12-18 14:55:57 -050046from chromite.lib import commandline
Rahul Chaudhry0e515342015-08-07 12:00:43 -070047from chromite.lib import cros_build_lib
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050048from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070049from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070050from chromite.lib import patch
Mike Frysingered1b95a2019-12-12 19:04:51 -050051from chromite.lib import terminal
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040052from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070053
Mike Frysingerff4768e2020-02-27 18:48:13 -050054
55assert sys.version_info >= (3, 6), 'This module requires Python 3.6+'
56
57
Vadim Bendebury2b62d742014-06-22 13:14:51 -070058PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070059
Mike Frysingered9b2a02019-12-12 18:52:32 -050060
61# Link to commit message documentation for users.
62DOC_COMMIT_MSG_URL = ('https://chromium.googlesource.com/chromiumos/docs/+/HEAD'
63 '/contributing.md#commit-messages')
64
65
Ryan Cuiec4d6332011-05-02 14:15:25 -070066COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050067 # C++ and friends
Mike Frysinger24dd3c52019-08-17 14:22:48 -040068 r'.*\.c$', r'.*\.cc$', r'.*\.cpp$', r'.*\.h$', r'.*\.m$', r'.*\.mm$',
69 r'.*\.inl$', r'.*\.asm$', r'.*\.hxx$', r'.*\.hpp$', r'.*\.s$', r'.*\.S$',
Mike Frysingerae409522014-02-01 03:16:11 -050070 # Scripts
Mike Frysinger24dd3c52019-08-17 14:22:48 -040071 r'.*\.js$', r'.*\.py$', r'.*\.sh$', r'.*\.rb$', r'.*\.pl$', r'.*\.pm$',
Mike Frysingerae409522014-02-01 03:16:11 -050072 # No extension at all, note that ALL CAPS files are black listed in
73 # COMMON_EXCLUDED_LIST below.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040074 r'(^|.*[\\\/])[^.]+$',
Mike Frysingerae409522014-02-01 03:16:11 -050075 # Other
Mike Frysinger24dd3c52019-08-17 14:22:48 -040076 r'.*\.java$', r'.*\.mk$', r'.*\.am$',
77 r'.*\.policy$', r'.*\.conf$', r'.*\.go$',
78 r'(^OWNERS|/OWNERS)',
Ryan Cuiec4d6332011-05-02 14:15:25 -070079]
80
Ryan Cui1562fb82011-05-09 11:01:31 -070081
Ryan Cuiec4d6332011-05-02 14:15:25 -070082COMMON_EXCLUDED_PATHS = [
Daniel Erate3ea3fc2015-02-13 15:27:52 -070083 # For ebuild trees, ignore any caches and manifest data.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040084 r'.*/Manifest$',
85 r'.*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$',
Doug Anderson5bfb6792011-10-25 16:45:41 -070086
Daniel Erate3ea3fc2015-02-13 15:27:52 -070087 # Ignore profiles data (like overlay-tegra2/profiles).
Mike Frysinger24dd3c52019-08-17 14:22:48 -040088 r'(^|.*/)overlay-.*/profiles/.*',
89 r'^profiles/.*$',
Mike Frysinger98638102014-08-28 00:15:08 -040090
C Shapiro8f90e9b2017-06-28 09:54:50 -060091 # Ignore config files in ebuild setup.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040092 r'(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*',
93 r'^chromeos-base/chromeos-bsp.*/files/.*',
C Shapiro8f90e9b2017-06-28 09:54:50 -060094
Daniel Erate3ea3fc2015-02-13 15:27:52 -070095 # Ignore minified js and jquery.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040096 r'.*\.min\.js',
97 r'.*jquery.*\.js',
Mike Frysinger33a458d2014-03-03 17:00:51 -050098
99 # Ignore license files as the content is often taken verbatim.
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400100 r'.*/licenses/.*',
Alex Klein619c0912019-01-30 17:13:23 -0700101
Mike Frysinger13650402019-07-31 14:31:46 -0400102 # Exclude generated protobuf bindings.
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400103 r'.*_pb2\.py$',
104 r'.*\.pb\.go$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700105]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700106
Ken Turnerd07564b2018-02-08 17:57:59 +1100107LICENSE_EXCLUDED_PATHS = [
LaMont Jones775c2b32020-02-19 17:32:54 -0700108 r'^(.*/)?OWNERS(\..*)?$',
Ken Turnerd07564b2018-02-08 17:57:59 +1100109]
Ryan Cui1562fb82011-05-09 11:01:31 -0700110
Ryan Cui9b651632011-05-11 11:38:58 -0700111_CONFIG_FILE = 'PRESUBMIT.cfg'
112
113
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700114# File containing wildcards, one per line, matching files that should be
115# excluded from presubmit checks. Lines beginning with '#' are ignored.
116_IGNORE_FILE = '.presubmitignore'
117
Cheng Yuehb707c522020-01-02 14:06:59 +0800118
119TEST_FIELD_RE = r'\nTEST=\S+'
120
Doug Anderson44a644f2011-11-02 10:37:37 -0700121# Exceptions
122
123
124class BadInvocation(Exception):
125 """An Exception indicating a bad invocation of the program."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700126
127
Ryan Cui1562fb82011-05-09 11:01:31 -0700128# General Helpers
129
Sean Paulba01d402011-05-05 11:36:23 -0400130
Mike Frysingerb2496652019-09-12 23:35:46 -0400131class Cache(object):
132 """General helper for caching git content."""
133
134 def __init__(self):
135 self._cache = {}
136
137 def get_subcache(self, scope):
138 return self._cache.setdefault(scope, {})
139
140 def clear(self):
141 self._cache.clear()
142
143CACHE = Cache()
144
145
Alex Deymo643ac4c2015-09-03 10:40:50 -0700146Project = collections.namedtuple('Project', ['name', 'dir', 'remote'])
147
148
Mike Frysinger526a5f82019-09-13 18:05:30 -0400149def _run_command(cmd, **kwargs):
Doug Anderson44a644f2011-11-02 10:37:37 -0700150 """Executes the passed in command and returns raw stdout output.
151
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400152 This is a convenience func to set some run defaults differently.
Mike Frysinger526a5f82019-09-13 18:05:30 -0400153
Doug Anderson44a644f2011-11-02 10:37:37 -0700154 Args:
155 cmd: The command to run; should be a list of strings.
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400156 **kwargs: Same as cros_build_lib.run.
Doug Anderson44a644f2011-11-02 10:37:37 -0700157
158 Returns:
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700159 The stdout from the process (discards stderr and returncode).
Doug Anderson44a644f2011-11-02 10:37:37 -0700160 """
Mike Frysinger526a5f82019-09-13 18:05:30 -0400161 kwargs.setdefault('print_cmd', False)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400162 kwargs.setdefault('stdout', True)
163 kwargs.setdefault('check', False)
Mike Frysinger054c1592019-11-18 03:51:54 -0500164 result = cros_build_lib.run(cmd, **kwargs)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400165 # NB: We decode this directly rather than through kwargs as our tests rely
166 # on this post-processing behavior currently.
Mike Frysinger71e643e2019-09-13 17:26:39 -0400167 return result.output.decode('utf-8', 'replace')
Ryan Cui72834d12011-05-05 14:51:33 -0700168
Ryan Cui1562fb82011-05-09 11:01:31 -0700169
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700170def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700171 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700172 if __name__ == '__main__':
173 # Works when file is run on its own (__file__ is defined)...
174 return os.path.abspath(os.path.dirname(__file__))
175 else:
176 # We need to do this when we're run through repo. Since repo executes
177 # us with execfile(), we don't get __file__ defined.
178 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
179 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700180
Ryan Cui1562fb82011-05-09 11:01:31 -0700181
Ryan Cuiec4d6332011-05-02 14:15:25 -0700182def _match_regex_list(subject, expressions):
183 """Try to match a list of regular expressions to a string.
184
185 Args:
186 subject: The string to match regexes on
187 expressions: A list of regular expressions to check for matches with.
188
189 Returns:
190 Whether the passed in subject matches any of the passed in regexes.
191 """
192 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500193 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700194 return True
195 return False
196
Ryan Cui1562fb82011-05-09 11:01:31 -0700197
Mike Frysingerae409522014-02-01 03:16:11 -0500198def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700199 """Filter out files based on the conditions passed in.
200
201 Args:
202 files: list of filepaths to filter
203 include_list: list of regex that when matched with a file path will cause it
204 to be added to the output list unless the file is also matched with a
205 regex in the exclude_list.
206 exclude_list: list of regex that when matched with a file will prevent it
207 from being added to the output list, even if it is also matched with a
208 regex in the include_list.
209
210 Returns:
211 A list of filepaths that contain files matched in the include_list and not
212 in the exclude_list.
213 """
214 filtered = []
215 for f in files:
216 if (_match_regex_list(f, include_list) and
217 not _match_regex_list(f, exclude_list)):
218 filtered.append(f)
219 return filtered
220
Ryan Cuiec4d6332011-05-02 14:15:25 -0700221
222# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700223
224
Ryan Cui4725d952011-05-05 15:41:19 -0700225def _get_upstream_branch():
226 """Returns the upstream tracking branch of the current branch.
227
228 Raises:
229 Error if there is no tracking branch
230 """
231 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
232 current_branch = current_branch.replace('refs/heads/', '')
233 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700234 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700235
236 cfg_option = 'branch.' + current_branch + '.%s'
237 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
238 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
239 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700240 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700241
242 return full_upstream.replace('heads', 'remotes/' + remote)
243
Ryan Cui1562fb82011-05-09 11:01:31 -0700244
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700245def _get_patch(commit):
246 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700247 if commit == PRE_SUBMIT:
248 return _run_command(['git', 'diff', '--cached', 'HEAD'])
249 else:
250 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700251
Ryan Cui1562fb82011-05-09 11:01:31 -0700252
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500253def _get_file_content(path, commit):
254 """Returns the content of a file at a specific commit.
255
256 We can't rely on the file as it exists in the filesystem as people might be
257 uploading a series of changes which modifies the file multiple times.
258
259 Note: The "content" of a symlink is just the target. So if you're expecting
260 a full file, you should check that first. One way to detect is that the
261 content will not have any newlines.
262 """
Mike Frysingerb2496652019-09-12 23:35:46 -0400263 # Make sure people don't accidentally pass in full paths which will never
264 # work. You need to use relative=True with _get_affected_files.
265 if path.startswith('/'):
266 raise ValueError('_get_file_content must be called with relative paths: %s'
267 % (path,))
268
269 # {<commit>: {<path1>: <content>, <path2>: <content>}}
270 cache = CACHE.get_subcache('get_file_content')
271 if path in cache:
272 return cache[path]
273
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700274 if commit == PRE_SUBMIT:
Mike Frysingerb2496652019-09-12 23:35:46 -0400275 content = _run_command(['git', 'diff', 'HEAD', path])
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700276 else:
Mike Frysingerb2496652019-09-12 23:35:46 -0400277 content = _run_command(['git', 'show', '%s:%s' % (commit, path)])
278 cache[path] = content
279 return content
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500280
281
Mike Frysingerae409522014-02-01 03:16:11 -0500282def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700283 """Returns a list of (linenum, lines) tuples that the commit touched."""
Mike Frysingerb2496652019-09-12 23:35:46 -0400284 # {<commit>: {<path1>: <content>, <path2>: <content>}}
285 cache = CACHE.get_subcache('get_file_diff')
286 if path in cache:
287 return cache[path]
288
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700289 if commit == PRE_SUBMIT:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800290 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD',
291 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700292 else:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800293 command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit,
294 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700295 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700296
297 new_lines = []
298 line_num = 0
299 for line in output.splitlines():
300 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
301 if m:
302 line_num = int(m.groups(1)[0])
303 continue
304 if line.startswith('+') and not line.startswith('++'):
Mike Frysinger71e643e2019-09-13 17:26:39 -0400305 new_lines.append((line_num, line[1:]))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700306 if not line.startswith('-'):
307 line_num += 1
Mike Frysingerb2496652019-09-12 23:35:46 -0400308 cache[path] = new_lines
Ryan Cuiec4d6332011-05-02 14:15:25 -0700309 return new_lines
310
Ryan Cui1562fb82011-05-09 11:01:31 -0700311
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700312def _get_ignore_wildcards(directory, cache):
313 """Get wildcards listed in a directory's _IGNORE_FILE.
314
315 Args:
316 directory: A string containing a directory path.
317 cache: A dictionary (opaque to caller) caching previously-read wildcards.
318
319 Returns:
320 A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE
321 wasn't present.
322 """
323 # In the cache, keys are directories and values are lists of wildcards from
324 # _IGNORE_FILE within those directories (and empty if no file was present).
325 if directory not in cache:
326 wildcards = []
327 dotfile_path = os.path.join(directory, _IGNORE_FILE)
328 if os.path.exists(dotfile_path):
329 # TODO(derat): Consider using _get_file_content() to get the file as of
330 # this commit instead of the on-disk version. This may have a noticeable
331 # performance impact, as each call to _get_file_content() runs git.
332 with open(dotfile_path, 'r') as dotfile:
333 for line in dotfile.readlines():
334 line = line.strip()
335 if line.startswith('#'):
336 continue
337 if line.endswith('/'):
338 line += '*'
339 wildcards.append(line)
340 cache[directory] = wildcards
341
342 return cache[directory]
343
344
345def _path_is_ignored(path, cache):
346 """Check whether a path is ignored by _IGNORE_FILE.
347
348 Args:
349 path: A string containing a path.
350 cache: A dictionary (opaque to caller) caching previously-read wildcards.
351
352 Returns:
353 True if a file named _IGNORE_FILE in one of the passed-in path's parent
354 directories contains a wildcard matching the path.
355 """
356 # Skip ignore files.
357 if os.path.basename(path) == _IGNORE_FILE:
358 return True
359
360 path = os.path.abspath(path)
361 base = os.getcwd()
362
363 prefix = os.path.dirname(path)
364 while prefix.startswith(base):
365 rel_path = path[len(prefix) + 1:]
366 for wildcard in _get_ignore_wildcards(prefix, cache):
367 if fnmatch.fnmatch(rel_path, wildcard):
368 return True
369 prefix = os.path.dirname(prefix)
370
371 return False
372
373
Mike Frysinger292b45d2014-11-25 01:17:10 -0500374def _get_affected_files(commit, include_deletes=False, relative=False,
375 include_symlinks=False, include_adds=True,
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700376 full_details=False, use_ignore_files=True):
Peter Ammon811f6702014-06-12 15:45:38 -0700377 """Returns list of file paths that were modified/added, excluding symlinks.
378
379 Args:
380 commit: The commit
381 include_deletes: If true, we'll include deleted files in the result
382 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500383 include_symlinks: If true, we'll include symlinks in the result
384 include_adds: If true, we'll include new files in the result
385 full_details: If False, return filenames, else return structured results.
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700386 use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files.
Peter Ammon811f6702014-06-12 15:45:38 -0700387
388 Returns:
389 A list of modified/added (and perhaps deleted) files
390 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500391 if not relative and full_details:
392 raise ValueError('full_details only supports relative paths currently')
393
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700394 if commit == PRE_SUBMIT:
395 return _run_command(['git', 'diff-index', '--cached',
396 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500397
398 path = os.getcwd()
Mike Frysingerb2496652019-09-12 23:35:46 -0400399 # {<commit>: {<path1>: <content>, <path2>: <content>}}
400 cache = CACHE.get_subcache('get_affected_files')
401 if path not in cache:
402 cache[path] = git.RawDiff(path, '%s^!' % commit)
403 files = cache[path]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500404
405 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500406 if not include_symlinks:
407 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500408
409 if not include_deletes:
410 files = [x for x in files if x.status != 'D']
411
Mike Frysinger292b45d2014-11-25 01:17:10 -0500412 if not include_adds:
413 files = [x for x in files if x.status != 'A']
414
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700415 if use_ignore_files:
416 cache = {}
417 is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache)
418 files = [x for x in files if not is_ignored(x)]
419
Mike Frysinger292b45d2014-11-25 01:17:10 -0500420 if full_details:
421 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500422 return files
423 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500424 # Caller only cares about filenames.
425 files = [x.dst_file if x.dst_file else x.src_file for x in files]
426 if relative:
427 return files
428 else:
429 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700430
431
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700432def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700433 """Returns a list of commits for this review."""
Mike Frysingere300c7d2019-09-12 23:33:52 -0400434 cmd = ['git', 'log', '--no-merges', '--format=%H',
435 '%s..' % _get_upstream_branch()]
Ryan Cui72834d12011-05-05 14:51:33 -0700436 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700437
Ryan Cui1562fb82011-05-09 11:01:31 -0700438
Ryan Cuiec4d6332011-05-02 14:15:25 -0700439def _get_commit_desc(commit):
440 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700441 if commit == PRE_SUBMIT:
442 return ''
Mike Frysingerb2496652019-09-12 23:35:46 -0400443
444 # {<commit>: <content>}
445 cache = CACHE.get_subcache('get_commit_desc')
446 if commit not in cache:
Mike Frysinger4efdee72019-11-04 10:57:01 -0500447 cache[commit] = _run_command(['git', 'log', '--format=%B',
Mike Frysingerb2496652019-09-12 23:35:46 -0400448 commit + '^!'])
449 return cache[commit]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700450
451
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800452def _check_lines_in_diff(commit, files, check_callable, error_description):
453 """Checks given file for errors via the given check.
454
455 This is a convenience function for common per-line checks. It goes through all
456 files and returns a HookFailure with the error description listing all the
457 failures.
458
459 Args:
460 commit: The commit we're working on.
461 files: The files to check.
462 check_callable: A callable that takes a line and returns True if this line
463 _fails_ the check.
464 error_description: A string describing the error.
465 """
466 errors = []
467 for afile in files:
468 for line_num, line in _get_file_diff(afile, commit):
469 if check_callable(line):
470 errors.append('%s, line %s' % (afile, line_num))
471 if errors:
472 return HookFailure(error_description, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400473 return None
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800474
475
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900476def _parse_common_inclusion_options(options):
477 """Parses common hook options for including/excluding files.
478
479 Args:
480 options: Option string list.
481
482 Returns:
483 (included, excluded) where each one is a list of regex strings.
484 """
485 parser = argparse.ArgumentParser()
486 parser.add_argument('--exclude_regex', action='append')
487 parser.add_argument('--include_regex', action='append')
488 opts = parser.parse_args(options)
489 included = opts.include_regex or []
490 excluded = opts.exclude_regex or []
491 return included, excluded
492
493
Ryan Cuiec4d6332011-05-02 14:15:25 -0700494# Common Hooks
495
Ryan Cui1562fb82011-05-09 11:01:31 -0700496
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900497def _check_no_long_lines(_project, commit, options=()):
Mike Frysinger55f85b52014-12-18 14:45:21 -0500498 """Checks there are no lines longer than MAX_LEN in any of the text files."""
Keigo Oka9732e382019-06-28 17:44:59 +0900499 LONG_LINE_OK_PATHS = [
500 # Go has no line length limit.
501 # https://golang.org/doc/effective_go.html#formatting
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400502 r'.*\.go$',
Keigo Oka9732e382019-06-28 17:44:59 +0900503 ]
Mike Frysinger55f85b52014-12-18 14:45:21 -0500504
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900505 DEFAULT_MAX_LENGTHS = [
506 # Java's line length limit is 100 chars.
507 # https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md
508 (r'.*\.java$', 100),
509 ]
510
Ryan Cuiec4d6332011-05-02 14:15:25 -0700511 MAX_LEN = 80
512
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900513 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700514 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900515 included + COMMON_INCLUDED_PATHS,
Keigo Oka9732e382019-06-28 17:44:59 +0900516 excluded + COMMON_EXCLUDED_PATHS + LONG_LINE_OK_PATHS)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700517
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900518 errors = []
Ryan Cuiec4d6332011-05-02 14:15:25 -0700519 for afile in files:
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700520 skip_regexps = (
521 r'https?://',
522 r'^#\s*(define|include|import|pragma|if|ifndef|endif)\b',
523 )
524
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900525 max_len = MAX_LEN
526
527 for expr, length in DEFAULT_MAX_LENGTHS:
528 if re.search(expr, afile):
529 max_len = length
530 break
531
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700532 if os.path.basename(afile).startswith('OWNERS'):
533 # File paths can get long, and there's no way to break them up into
534 # multiple lines.
535 skip_regexps += (
536 r'^include\b',
537 r'file:',
538 )
539
540 skip_regexps = [re.compile(x) for x in skip_regexps]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700541 for line_num, line in _get_file_diff(afile, commit):
542 # Allow certain lines to exceed the maxlen rule.
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900543 if len(line) <= max_len or any(x.search(line) for x in skip_regexps):
Jon Salz98255932012-08-18 14:48:02 +0800544 continue
545
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900546 errors.append('%s, line %s, %s chars, over %s chars' %
547 (afile, line_num, len(line), max_len))
Jon Salz98255932012-08-18 14:48:02 +0800548 if len(errors) == 5: # Just show the first 5 errors.
549 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700550
551 if errors:
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900552 msg = 'Found lines longer than the limit (first 5 shown):'
Ryan Cui1562fb82011-05-09 11:01:31 -0700553 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400554 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700555
Ryan Cuiec4d6332011-05-02 14:15:25 -0700556
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900557def _check_no_stray_whitespace(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700558 """Checks that there is no stray whitespace at source lines end."""
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900559 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700560 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900561 included + COMMON_INCLUDED_PATHS,
562 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800563 return _check_lines_in_diff(commit, files,
564 lambda line: line.rstrip() != line,
565 'Found line ending with white space in:')
Ryan Cui1562fb82011-05-09 11:01:31 -0700566
Ryan Cuiec4d6332011-05-02 14:15:25 -0700567
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900568def _check_no_tabs(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700569 """Checks there are no unexpanded tabs."""
Mike Frysingercd134512017-10-26 04:36:33 -0400570 # Don't add entire repos here. Update the PRESUBMIT.cfg in each repo instead.
571 # We only whitelist known specific filetypes here that show up in all repos.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700572 TAB_OK_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400573 r'.*\.ebuild$',
574 r'.*\.eclass$',
575 r'.*\.go$',
576 r'.*/[M|m]akefile$',
577 r'.*\.mk$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700578 ]
579
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900580 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700581 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900582 included + COMMON_INCLUDED_PATHS,
583 excluded + COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800584 return _check_lines_in_diff(commit, files,
585 lambda line: '\t' in line,
586 'Found a tab character in:')
Ryan Cuiec4d6332011-05-02 14:15:25 -0700587
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800588
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900589def _check_tabbed_indents(_project, commit, options=()):
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800590 """Checks that indents use tabs only."""
591 TABS_REQUIRED_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400592 r'.*\.ebuild$',
593 r'.*\.eclass$',
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800594 ]
595 LEADING_SPACE_RE = re.compile('[\t]* ')
596
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900597 included, excluded = _parse_common_inclusion_options(options)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800598 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900599 included + TABS_REQUIRED_PATHS,
600 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800601 return _check_lines_in_diff(
602 commit, files,
603 lambda line: LEADING_SPACE_RE.match(line) is not None,
604 'Found a space in indentation (must be all tabs):')
Ryan Cui1562fb82011-05-09 11:01:31 -0700605
Ryan Cuiec4d6332011-05-02 14:15:25 -0700606
LaMont Jones872fe762020-02-10 15:36:14 -0700607def _check_gofmt(_project, commit, options=()):
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700608 """Checks that Go files are formatted with gofmt."""
LaMont Jones872fe762020-02-10 15:36:14 -0700609 included, excluded = _parse_common_inclusion_options(options)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700610 errors = []
611 files = _filter_files(_get_affected_files(commit, relative=True),
LaMont Jones872fe762020-02-10 15:36:14 -0700612 included + [r'\.go$'],
613 excluded)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700614
615 for gofile in files:
616 contents = _get_file_content(gofile, commit)
Mike Frysingeraa7dc942019-09-25 00:07:24 -0400617 output = _run_command(cmd=['gofmt', '-l'], input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500618 stderr=subprocess.STDOUT)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700619 if output:
620 errors.append(gofile)
621 if errors:
622 return HookFailure('Files not formatted with gofmt:', errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400623 return None
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700624
625
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600626def _check_rustfmt(_project, commit):
627 """Checks that Rust files are formatted with rustfmt."""
628 errors = []
629 files = _filter_files(_get_affected_files(commit, relative=True),
630 [r'\.rs$'])
631
632 for rustfile in files:
633 contents = _get_file_content(rustfile, commit)
Mike Frysingeraa7dc942019-09-25 00:07:24 -0400634 output = _run_command(cmd=['rustfmt'], input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500635 stderr=subprocess.STDOUT)
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600636 if output != contents:
637 errors.append(rustfile)
638 if errors:
639 return HookFailure('Files not formatted with rustfmt: '
640 "(run 'cargo fmt' to fix)", errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400641 return None
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600642
643
Mike Frysingerae409522014-02-01 03:16:11 -0500644def _check_change_has_test_field(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700645 """Check for a non-empty 'TEST=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500646 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700647
Cheng Yuehb707c522020-01-02 14:06:59 +0800648 if not re.search(TEST_FIELD_RE, _get_commit_desc(commit)):
Mike Frysingered9b2a02019-12-12 18:52:32 -0500649 msg = ('Changelist description needs TEST field (after first line)\n%s' %
650 (SEE_ALSO,))
Ryan Cui1562fb82011-05-09 11:01:31 -0700651 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400652 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700653
Ryan Cuiec4d6332011-05-02 14:15:25 -0700654
Mike Frysingerae409522014-02-01 03:16:11 -0500655def _check_change_has_valid_cq_depend(_project, commit):
Jason D. Clinton299e3222019-05-23 09:42:03 -0600656 """Check for a correctly formatted Cq-Depend field in the commit message."""
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700657 desc = _get_commit_desc(commit)
Jason D. Clinton299e3222019-05-23 09:42:03 -0600658 msg = 'Changelist has invalid Cq-Depend target.'
659 example = 'Example: Cq-Depend: chromium:1234, chrome-internal:2345'
David Jamesc3b68b32013-04-03 09:17:03 -0700660 try:
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700661 patch.GetPaladinDeps(desc)
David Jamesc3b68b32013-04-03 09:17:03 -0700662 except ValueError as ex:
663 return HookFailure(msg, [example, str(ex)])
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700664 # Check that Cq-Depend is in the same paragraph as Change-Id.
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500665 msg = 'Cq-Depend is not in the same paragraph as Change-Id.'
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700666 paragraphs = desc.split('\n\n')
667 for paragraph in paragraphs:
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500668 if (re.search(r'^Cq-Depend:', paragraph, re.M) and not
669 re.search('^Change-Id:', paragraph, re.M)):
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700670 return HookFailure(msg)
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500671
672 # We no longer support CQ-DEPEND= lines.
673 if re.search(r'^CQ-DEPEND[=:]', desc, re.M):
674 return HookFailure(
675 'CQ-DEPEND= is no longer supported. Please see:\n'
676 'https://chromium.googlesource.com/chromiumos/docs/+/HEAD/'
677 'contributing.md#CQ-DEPEND')
678
Mike Frysinger8cf80812019-09-16 23:49:29 -0400679 return None
David Jamesc3b68b32013-04-03 09:17:03 -0700680
681
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800682def _check_change_is_contribution(_project, commit):
683 """Check that the change is a contribution."""
684 NO_CONTRIB = 'not a contribution'
685 if NO_CONTRIB in _get_commit_desc(commit).lower():
686 msg = ('Changelist is not a contribution, this cannot be accepted.\n'
687 'Please remove the "%s" text from the commit message.') % NO_CONTRIB
688 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400689 return None
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800690
691
Alex Deymo643ac4c2015-09-03 10:40:50 -0700692def _check_change_has_bug_field(project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700693 """Check for a correctly formatted 'BUG=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500694 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
695
David James5c0073d2013-04-03 08:48:52 -0700696 OLD_BUG_RE = r'\nBUG=.*chromium-os'
697 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
698 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
699 'the chromium tracker in your BUG= line now.')
700 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700701
Alex Deymo643ac4c2015-09-03 10:40:50 -0700702 # Android internal and external projects use "Bug: " to track bugs in
703 # buganizer.
704 BUG_COLON_REMOTES = (
705 'aosp',
706 'goog',
707 )
708 if project.remote in BUG_COLON_REMOTES:
709 BUG_RE = r'\nBug: ?([Nn]one|\d+)'
710 if not re.search(BUG_RE, _get_commit_desc(commit)):
711 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500712 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700713 'Bug: 9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500714 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700715 return HookFailure(msg)
716 else:
Jorge Lucangeli Obesdce214e2017-10-25 15:04:39 -0400717 BUG_RE = r'\nBUG=([Nn]one|(chromium|b):\d+)'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700718 if not re.search(BUG_RE, _get_commit_desc(commit)):
719 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500720 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700721 'BUG=chromium:9999 (for public tracker)\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700722 'BUG=b:9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500723 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700724 return HookFailure(msg)
Ryan Cui1562fb82011-05-09 11:01:31 -0700725
Cheng Yuehb707c522020-01-02 14:06:59 +0800726 TEST_BEFORE_BUG_RE = TEST_FIELD_RE + r'.*' + BUG_RE
727
728 if re.search(TEST_BEFORE_BUG_RE, _get_commit_desc(commit), re.DOTALL):
729 msg = ('The BUG field must come before the TEST field.\n%s' %
730 (SEE_ALSO,))
731 return HookFailure(msg)
732
Mike Frysinger8cf80812019-09-16 23:49:29 -0400733 return None
734
Ryan Cuiec4d6332011-05-02 14:15:25 -0700735
Jack Neus8edbf642019-07-10 16:08:31 -0600736def _check_change_no_include_oem(project, commit):
737 """Check that the change does not reference OEMs."""
738 ALLOWLIST = {
739 'chromiumos/platform/ec',
740 # Used by unit tests.
741 'project',
742 }
743 if project.name not in ALLOWLIST:
744 return None
745
Mike Frysingerbb34a222019-07-31 14:40:46 -0400746 TAGS = {
Jack Neus8edbf642019-07-10 16:08:31 -0600747 'Reviewed-on',
748 'Reviewed-by',
749 'Signed-off-by',
750 'Commit-Ready',
751 'Tested-by',
752 'Commit-Queue',
Jack Neus8edbf642019-07-10 16:08:31 -0600753 'Acked-by',
754 'Modified-by',
755 'CC',
756 'Suggested-by',
757 'Reported-by',
758 'Acked-for-chrome-by',
LaMont Jones237f3ef2020-01-22 10:40:52 -0700759 'Cq-Cl-Tag',
LaMont Jonesfb5e8bf2020-03-03 12:50:06 -0700760 'Cq-Include-Trybots',
Mike Frysingerbb34a222019-07-31 14:40:46 -0400761 }
Jack Neus8edbf642019-07-10 16:08:31 -0600762
763 # Ignore tags, which could reasonably contain OEM names
764 # (e.g. Reviewed-by: foo@oem.corp-partner.google.com).
Jack Neus8edbf642019-07-10 16:08:31 -0600765 commit_message = ' '.join(
Mike Frysingerbb34a222019-07-31 14:40:46 -0400766 x for x in _get_commit_desc(commit).splitlines()
767 if ':' not in x or x.split(':', 1)[0] not in TAGS)
768
Jack Neus8edbf642019-07-10 16:08:31 -0600769 commit_message = re.sub(r'[\s_-]+', ' ', commit_message)
770
771 # Exercise caution when expanding these lists. Adding a name
772 # could indicate a new relationship with a company!
773 OEMS = ['hp', 'hewlett packard', 'dell', 'lenovo', 'acer', 'asus', 'samsung']
774 ODMS = [
775 'bitland', 'compal', 'haier', 'huaqin', 'inventec', 'lg', 'pegatron',
776 'pegatron(ems)', 'quanta', 'samsung', 'wistron'
777 ]
778
779 for name_type, name_list in [('OEM', OEMS), ('ODM', ODMS)]:
780 # Construct regex
781 name_re = r'\b(%s)\b' % '|'.join([re.escape(x) for x in name_list])
782 matches = [x[0] for x in re.findall(name_re, commit_message, re.IGNORECASE)]
Mike Frysingere52b1bc2019-09-16 23:45:41 -0400783 if matches:
Jack Neus8edbf642019-07-10 16:08:31 -0600784 # If there's a match, throw an error.
785 error_msg = ('Changelist description contains the name of an'
786 ' %s: "%s".' % (name_type, '","'.join(matches)))
787 return HookFailure(error_msg)
788
Mike Frysinger8cf80812019-09-16 23:49:29 -0400789 return None
790
Jack Neus8edbf642019-07-10 16:08:31 -0600791
Mike Frysinger292b45d2014-11-25 01:17:10 -0500792def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -0700793 """Check that we're not missing a revbump of an ebuild in the given commit.
794
795 If the given commit touches files in a directory that has ebuilds somewhere
796 up the directory hierarchy, it's very likely that we need an ebuild revbump
797 in order for those changes to take effect.
798
799 It's not totally trivial to detect a revbump, so at least detect that an
800 ebuild with a revision number in it was touched. This should handle the
801 common case where we use a symlink to do the revbump.
802
803 TODO: it would be nice to enhance this hook to:
804 * Handle cases where people revbump with a slightly different syntax. I see
805 one ebuild (puppy) that revbumps with _pN. This is a false positive.
806 * Catches cases where people aren't using symlinks for revbumps. If they
807 edit a revisioned file directly (and are expected to rename it for revbump)
808 we'll miss that. Perhaps we could detect that the file touched is a
809 symlink?
810
811 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
812 still better off than without this check.
813
814 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700815 project: The Project to look at
Doug Anderson42b8a052013-06-26 10:45:36 -0700816 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -0500817 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -0700818
819 Returns:
820 A HookFailure or None.
821 """
Mike Frysinger011af942014-01-17 16:12:22 -0500822 # If this is the portage-stable overlay, then ignore the check. It's rare
823 # that we're doing anything other than importing files from upstream, so
824 # forcing a rev bump makes no sense.
825 whitelist = (
826 'chromiumos/overlays/portage-stable',
827 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700828 if project.name in whitelist:
Mike Frysinger011af942014-01-17 16:12:22 -0500829 return None
830
Mike Frysinger292b45d2014-11-25 01:17:10 -0500831 def FinalName(obj):
832 # If the file is being deleted, then the dst_file is not set.
833 if obj.dst_file is None:
834 return obj.src_file
835 else:
836 return obj.dst_file
837
838 affected_path_objs = _get_affected_files(
839 commit, include_deletes=True, include_symlinks=True, relative=True,
840 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -0700841
842 # Don't yell about changes to whitelisted files...
Mike Frysinger550c05c2019-12-09 18:16:36 -0500843 whitelist = {'ChangeLog', 'Manifest', 'metadata.xml'}
Mike Frysinger292b45d2014-11-25 01:17:10 -0500844 affected_path_objs = [x for x in affected_path_objs
845 if os.path.basename(FinalName(x)) not in whitelist]
846 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -0700847 return None
848
849 # If we've touched any file named with a -rN.ebuild then we'll say we're
850 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500851 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
852 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700853 if touched_revved_ebuild:
854 return None
855
Mike Frysinger292b45d2014-11-25 01:17:10 -0500856 # If we're creating new ebuilds from scratch, then we don't need an uprev.
857 # Find all the dirs that new ebuilds and ignore their files/.
858 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
859 if FinalName(x).endswith('.ebuild') and x.status == 'A']
860 affected_path_objs = [obj for obj in affected_path_objs
861 if not any(FinalName(obj).startswith(x)
862 for x in ebuild_dirs)]
863 if not affected_path_objs:
Mike Frysinger8cf80812019-09-16 23:49:29 -0400864 return None
Mike Frysinger292b45d2014-11-25 01:17:10 -0500865
Doug Anderson42b8a052013-06-26 10:45:36 -0700866 # We want to examine the current contents of all directories that are parents
867 # of files that were touched (up to the top of the project).
868 #
869 # ...note: we use the current directory contents even though it may have
870 # changed since the commit we're looking at. This is just a heuristic after
871 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500872 if project_top is None:
873 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -0700874 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -0500875 for obj in affected_path_objs:
876 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -0700877 while os.path.exists(path) and not os.path.samefile(path, project_top):
878 dirs_to_check.add(path)
879 path = os.path.dirname(path)
880
881 # Look through each directory. If it's got an ebuild in it then we'll
882 # consider this as a case when we need a revbump.
Gwendal Grignoua3086c32014-12-09 11:17:22 -0800883 affected_paths = set(os.path.join(project_top, FinalName(x))
884 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700885 for dir_path in dirs_to_check:
886 contents = os.listdir(dir_path)
887 ebuilds = [os.path.join(dir_path, path)
888 for path in contents if path.endswith('.ebuild')]
889 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
890
C Shapiroae157ae2017-09-18 16:24:03 -0600891 affected_paths_under_9999_ebuilds = set()
892 for affected_path in affected_paths:
893 for ebuild_9999 in ebuilds_9999:
894 ebuild_dir = os.path.dirname(ebuild_9999)
895 if affected_path.startswith(ebuild_dir):
896 affected_paths_under_9999_ebuilds.add(affected_path)
897
898 # If every file changed exists under a 9999 ebuild, then skip
899 if len(affected_paths_under_9999_ebuilds) == len(affected_paths):
900 continue
901
Doug Anderson42b8a052013-06-26 10:45:36 -0700902 # If the -9999.ebuild file was touched the bot will uprev for us.
903 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -0500904 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -0700905 continue
906
907 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500908 return HookFailure('Changelist probably needs a revbump of an ebuild, '
909 'or a -r1.ebuild symlink if this is a new ebuild:\n'
910 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -0700911
912 return None
913
914
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500915def _check_ebuild_eapi(project, commit):
Mike Frysinger948284a2018-02-01 15:22:56 -0500916 """Make sure we have people use EAPI=5 or newer with custom ebuilds.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500917
918 We want to get away from older EAPI's as it makes life confusing and they
919 have less builtin error checking.
920
921 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700922 project: The Project to look at
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500923 commit: The commit to look at
924
925 Returns:
926 A HookFailure or None.
927 """
928 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500929 # that we're doing anything other than importing files from upstream, and
930 # we shouldn't be rewriting things fundamentally anyways.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500931 whitelist = (
932 'chromiumos/overlays/portage-stable',
933 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700934 if project.name in whitelist:
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500935 return None
936
Mike Frysinger948284a2018-02-01 15:22:56 -0500937 BAD_EAPIS = ('0', '1', '2', '3', '4')
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500938
939 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
940
941 ebuilds_re = [r'\.ebuild$']
942 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
943 ebuilds_re)
944 bad_ebuilds = []
945
946 for ebuild in ebuilds:
947 # If the ebuild does not specify an EAPI, it defaults to 0.
948 eapi = '0'
949
950 lines = _get_file_content(ebuild, commit).splitlines()
951 if len(lines) == 1:
952 # This is most likely a symlink, so skip it entirely.
953 continue
954
955 for line in lines:
956 m = get_eapi.match(line)
957 if m:
958 # Once we hit the first EAPI line in this ebuild, stop processing.
959 # The spec requires that there only be one and it be first, so
960 # checking all possible values is pointless. We also assume that
961 # it's "the" EAPI line and not something in the middle of a heredoc.
962 eapi = m.group(1)
963 break
964
965 if eapi in BAD_EAPIS:
966 bad_ebuilds.append((ebuild, eapi))
967
968 if bad_ebuilds:
969 # pylint: disable=C0301
970 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
971 # pylint: enable=C0301
972 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500973 'These ebuilds are using old EAPIs. If these are imported from\n'
974 'Gentoo, then you may ignore and upload once with the --no-verify\n'
Mike Frysinger948284a2018-02-01 15:22:56 -0500975 'flag. Otherwise, please update to 5 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500976 '\t%s\n'
977 'See this guide for more details:\n%s\n' %
978 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
979
Mike Frysinger8cf80812019-09-16 23:49:29 -0400980 return None
981
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500982
Mike Frysinger89bdb852014-02-01 05:26:26 -0500983def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -0500984 """Make sure we use the new style KEYWORDS when possible in ebuilds.
985
986 If an ebuild generally does not care about the arch it is running on, then
987 ebuilds should flag it with one of:
988 KEYWORDS="*" # A stable ebuild.
989 KEYWORDS="~*" # An unstable ebuild.
990 KEYWORDS="-* ..." # Is known to only work on specific arches.
991
992 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700993 project: The Project to look at
Mike Frysingerc51ece72014-01-17 16:23:40 -0500994 commit: The commit to look at
995
996 Returns:
997 A HookFailure or None.
998 """
999 WHITELIST = set(('*', '-*', '~*'))
1000
1001 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
1002
Mike Frysinger89bdb852014-02-01 05:26:26 -05001003 ebuilds_re = [r'\.ebuild$']
1004 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1005 ebuilds_re)
1006
Mike Frysinger8d42d742014-09-22 15:50:21 -04001007 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -05001008 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -04001009 # We get the full content rather than a diff as the latter does not work
1010 # on new files (like when adding new ebuilds).
1011 lines = _get_file_content(ebuild, commit).splitlines()
1012 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -05001013 m = get_keywords.match(line)
1014 if m:
1015 keywords = set(m.group(1).split())
1016 if not keywords or WHITELIST - keywords != WHITELIST:
1017 continue
1018
Mike Frysinger8d42d742014-09-22 15:50:21 -04001019 bad_ebuilds.append(ebuild)
1020
1021 if bad_ebuilds:
1022 return HookFailure(
1023 '%s\n'
1024 'Please update KEYWORDS to use a glob:\n'
1025 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
1026 ' KEYWORDS="*"\n'
1027 'If the ebuild should be marked unstable (normal for '
1028 'cros-workon / 9999 ebuilds):\n'
1029 ' KEYWORDS="~*"\n'
Mike Frysingerde8efea2015-05-17 03:42:26 -04001030 'If the ebuild needs to be marked for only specific arches, '
Mike Frysinger8d42d742014-09-22 15:50:21 -04001031 'then use -* like so:\n'
1032 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -05001033
Mike Frysinger8cf80812019-09-16 23:49:29 -04001034 return None
1035
Mike Frysingerc51ece72014-01-17 16:23:40 -05001036
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001037def _check_ebuild_licenses(_project, commit):
1038 """Check if the LICENSE field in the ebuild is correct."""
Brian Norris7a610e82016-02-17 12:24:54 -08001039 affected_paths = _get_affected_files(commit, relative=True)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001040 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
1041
1042 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -08001043 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001044
1045 for ebuild in touched_ebuilds:
1046 # Skip virutal packages.
1047 if ebuild.split('/')[-3] == 'virtual':
1048 continue
1049
Alex Kleinb5953522018-08-03 11:44:21 -06001050 # e.g. path/to/overlay/category/package/package.ebuild -> path/to/overlay
1051 overlay_path = os.sep.join(ebuild.split(os.sep)[:-3])
1052
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001053 try:
Brian Norris7a610e82016-02-17 12:24:54 -08001054 ebuild_content = _get_file_content(ebuild, commit)
Alex Kleinb5953522018-08-03 11:44:21 -06001055 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content,
1056 overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001057 except ValueError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001058 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001059
1060 # Also ignore licenses ending with '?'
1061 for license_type in [x for x in license_types
1062 if x not in LICENSES_IGNORE and not x.endswith('?')]:
1063 try:
Alex Kleinb5953522018-08-03 11:44:21 -06001064 licenses_lib.Licensing.FindLicenseType(license_type,
1065 overlay_path=overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001066 except AssertionError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001067 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001068
Mike Frysinger8cf80812019-09-16 23:49:29 -04001069 return None
1070
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001071
Mike Frysingercd363c82014-02-01 05:20:18 -05001072def _check_ebuild_virtual_pv(project, commit):
1073 """Enforce the virtual PV policies."""
1074 # If this is the portage-stable overlay, then ignore the check.
1075 # We want to import virtuals as-is from upstream Gentoo.
1076 whitelist = (
1077 'chromiumos/overlays/portage-stable',
1078 )
Alex Deymo643ac4c2015-09-03 10:40:50 -07001079 if project.name in whitelist:
Mike Frysingercd363c82014-02-01 05:20:18 -05001080 return None
1081
1082 # We assume the repo name is the same as the dir name on disk.
1083 # It would be dumb to not have them match though.
Alex Deymo643ac4c2015-09-03 10:40:50 -07001084 project_base = os.path.basename(project.name)
Mike Frysingercd363c82014-02-01 05:20:18 -05001085
1086 is_variant = lambda x: x.startswith('overlay-variant-')
1087 is_board = lambda x: x.startswith('overlay-')
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001088 is_baseboard = lambda x: x.startswith('baseboard-')
1089 is_chipset = lambda x: x.startswith('chipset-')
1090 is_project = lambda x: x.startswith('project-')
Mike Frysingercd363c82014-02-01 05:20:18 -05001091 is_private = lambda x: x.endswith('-private')
1092
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001093 is_special_overlay = lambda x: (is_board(x) or is_chipset(x) or
1094 is_baseboard(x) or is_project(x))
1095
Mike Frysingercd363c82014-02-01 05:20:18 -05001096 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
1097
1098 ebuilds_re = [r'\.ebuild$']
1099 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1100 ebuilds_re)
1101 bad_ebuilds = []
1102
1103 for ebuild in ebuilds:
1104 m = get_pv.match(ebuild)
1105 if m:
1106 overlay = m.group(1)
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001107 if not overlay or not is_special_overlay(overlay):
Alex Deymo643ac4c2015-09-03 10:40:50 -07001108 overlay = project_base
Mike Frysingercd363c82014-02-01 05:20:18 -05001109
1110 pv = m.group(3).split('-', 1)[0]
1111
Bernie Thompsone5ee1822016-01-12 14:22:23 -08001112 # Virtual versions >= 4 are special cases used above the standard
1113 # versioning structure, e.g. if one has a board inheriting a board.
1114 if float(pv) >= 4:
1115 want_pv = pv
Mike Frysingercd363c82014-02-01 05:20:18 -05001116 elif is_board(overlay):
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001117 if is_private(overlay):
1118 want_pv = '3.5' if is_variant(overlay) else '3'
1119 elif is_board(overlay):
1120 want_pv = '2.5' if is_variant(overlay) else '2'
1121 elif is_baseboard(overlay):
1122 want_pv = '1.9'
1123 elif is_chipset(overlay):
1124 want_pv = '1.8'
1125 elif is_project(overlay):
1126 want_pv = '1.7' if is_private(overlay) else '1.5'
Mike Frysingercd363c82014-02-01 05:20:18 -05001127 else:
1128 want_pv = '1'
1129
1130 if pv != want_pv:
1131 bad_ebuilds.append((ebuild, pv, want_pv))
1132
1133 if bad_ebuilds:
1134 # pylint: disable=C0301
1135 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
1136 # pylint: enable=C0301
1137 return HookFailure(
1138 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
1139 '\t%s\n'
1140 'If this is an upstream Gentoo virtual, then you may ignore this\n'
1141 'check (and re-run w/--no-verify). Otherwise, please see this\n'
1142 'page for more details:\n%s\n' %
1143 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
1144 for x in bad_ebuilds]), url))
1145
Mike Frysinger8cf80812019-09-16 23:49:29 -04001146 return None
1147
Mike Frysingercd363c82014-02-01 05:20:18 -05001148
Daniel Erat9d203ff2015-02-17 10:12:21 -07001149def _check_portage_make_use_var(_project, commit):
1150 """Verify that $USE is set correctly in make.conf and make.defaults."""
1151 files = _filter_files(_get_affected_files(commit, relative=True),
1152 [r'(^|/)make.(conf|defaults)$'])
1153
1154 errors = []
1155 for path in files:
1156 basename = os.path.basename(path)
1157
1158 # Has a USE= line already been encountered in this file?
1159 saw_use = False
1160
1161 for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1):
1162 if not line.startswith('USE='):
1163 continue
1164
1165 preserves_use = '${USE}' in line or '$USE' in line
1166
1167 if (basename == 'make.conf' or
1168 (basename == 'make.defaults' and saw_use)) and not preserves_use:
1169 errors.append('%s:%d: missing ${USE}' % (path, i))
1170 elif basename == 'make.defaults' and not saw_use and preserves_use:
1171 errors.append('%s:%d: ${USE} referenced in initial declaration' %
1172 (path, i))
1173
1174 saw_use = True
1175
1176 if errors:
1177 return HookFailure(
1178 'One or more Portage make files appear to set USE incorrectly.\n'
1179 '\n'
1180 'All USE assignments in make.conf and all assignments after the\n'
1181 'initial declaration in make.defaults should contain "${USE}" to\n'
1182 'preserve previously-set flags.\n'
1183 '\n'
1184 'The initial USE declaration in make.defaults should not contain\n'
1185 '"${USE}".\n',
1186 errors)
1187
Mike Frysinger8cf80812019-09-16 23:49:29 -04001188 return None
1189
Daniel Erat9d203ff2015-02-17 10:12:21 -07001190
Mike Frysingerae409522014-02-01 03:16:11 -05001191def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001192 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001193 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001194 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001195 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001196 if not m:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001197 return HookFailure('Last paragraph of description must include Change-Id.')
Ryan Cui1562fb82011-05-09 11:01:31 -07001198
LaMont Jonesfb5e8bf2020-03-03 12:50:06 -07001199 # S-o-b and some other tags always allowed to follow Change-ID in the footer.
1200 allowed_tags = ['Signed-off-by', 'Cq-Cl-Tag', 'Cq-Include-Trybots']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001201
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001202 end = desc[m.end():].strip().splitlines()
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001203 cherry_pick_marker = 'cherry picked from commit'
1204
1205 if end and cherry_pick_marker in end[-1]:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001206 # Cherry picked patches allow more tags in the last paragraph.
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001207 allowed_tags += ['Commit-Queue', 'Commit-Ready', 'Reviewed-by',
1208 'Reviewed-on', 'Tested-by']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001209 end = end[:-1]
1210
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001211 # Note that descriptions could have multiple cherry pick markers.
1212 tag_search = r'^(%s:|\(%s) ' % (':|'.join(allowed_tags), cherry_pick_marker)
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001213
1214 if [x for x in end if not re.search(tag_search, x)]:
1215 return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' %
1216 ':", "'.join(allowed_tags))
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001217
Mike Frysinger8cf80812019-09-16 23:49:29 -04001218 return None
1219
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001220
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001221def _check_commit_message_style(_project, commit):
1222 """Verify that the commit message matches our style.
1223
1224 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
1225 commit hooks.
1226 """
Mike Frysingered9b2a02019-12-12 18:52:32 -05001227 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Mike Frysinger4efdee72019-11-04 10:57:01 -05001228
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001229 desc = _get_commit_desc(commit)
1230
1231 # The first line should be by itself.
1232 lines = desc.splitlines()
1233 if len(lines) > 1 and lines[1]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001234 return HookFailure('The second line of the commit message must be blank.'
1235 '\n%s' % (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001236
1237 # The first line should be one sentence.
1238 if '. ' in lines[0]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001239 return HookFailure('The first line cannot be more than one sentence.\n%s' %
1240 (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001241
1242 # The first line cannot be too long.
1243 MAX_FIRST_LINE_LEN = 100
1244 if len(lines[0]) > MAX_FIRST_LINE_LEN:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001245 return HookFailure('The first line must be less than %i chars.\n%s' %
1246 (MAX_FIRST_LINE_LEN, SEE_ALSO))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001247
Mike Frysinger8cf80812019-09-16 23:49:29 -04001248 return None
1249
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001250
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001251def _check_cros_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001252 """Verifies the Chromium OS license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -07001253
Mike Frysinger98638102014-08-28 00:15:08 -04001254 Should be following the spec:
1255 http://dev.chromium.org/developers/coding-style#TOC-File-headers
1256 """
1257 # For older years, be a bit more flexible as our policy says leave them be.
1258 LICENSE_HEADER = (
Keigo Oka7e880ac2019-07-03 15:03:43 +09001259 r'.*Copyright(?: \(c\))? (20[0-9]{2})(?:-20[0-9]{2})? The Chromium OS '
1260 r'Authors\. All rights reserved\.\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001261 r'.*Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001262 r'be\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001263 r'.*found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -05001264 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001265 )
1266 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1267
1268 # For newer years, be stricter.
Keigo Oka7e880ac2019-07-03 15:03:43 +09001269 BAD_COPYRIGHT_LINE = (
Brian Norris68838dd2018-09-26 18:30:24 -07001270 r'.*Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001271 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001272 )
Keigo Oka7e880ac2019-07-03 15:03:43 +09001273 bad_copyright_re = re.compile(BAD_COPYRIGHT_LINE)
Mike Frysinger98638102014-08-28 00:15:08 -04001274
Shuhei Takahashiabc20f32017-07-10 19:35:45 +09001275 included, excluded = _parse_common_inclusion_options(options)
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001276
Mike Frysinger98638102014-08-28 00:15:08 -04001277 bad_files = []
1278 bad_copyright_files = []
Keigo Oka7e880ac2019-07-03 15:03:43 +09001279 bad_year_files = []
1280
Ken Turnerd07564b2018-02-08 17:57:59 +11001281 files = _filter_files(
1282 _get_affected_files(commit, relative=True),
1283 included + COMMON_INCLUDED_PATHS,
1284 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001285 existing_files = set(_get_affected_files(commit, relative=True,
1286 include_adds=False))
Mike Frysinger98638102014-08-28 00:15:08 -04001287
Keigo Oka7e880ac2019-07-03 15:03:43 +09001288 current_year = str(datetime.datetime.now().year)
Mike Frysinger98638102014-08-28 00:15:08 -04001289 for f in files:
1290 contents = _get_file_content(f, commit)
1291 if not contents:
1292 # Ignore empty files.
1293 continue
1294
Keigo Oka7e880ac2019-07-03 15:03:43 +09001295 m = license_re.search(contents)
1296 if not m:
Mike Frysinger98638102014-08-28 00:15:08 -04001297 bad_files.append(f)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001298 elif bad_copyright_re.search(contents):
Mike Frysinger98638102014-08-28 00:15:08 -04001299 bad_copyright_files.append(f)
1300
Keigo Oka7e880ac2019-07-03 15:03:43 +09001301 if m and f not in existing_files:
1302 year = m.group(1)
1303 if year != current_year:
1304 bad_year_files.append(f)
1305
1306 errors = []
Mike Frysinger98638102014-08-28 00:15:08 -04001307 if bad_files:
1308 msg = '%s:\n%s\n%s' % (
1309 'License must match', license_re.pattern,
1310 'Found a bad header in these files:')
Keigo Oka7e880ac2019-07-03 15:03:43 +09001311 errors.append(HookFailure(msg, bad_files))
Mike Frysinger98638102014-08-28 00:15:08 -04001312 if bad_copyright_files:
1313 msg = 'Do not use (c) in copyright headers in new files:'
Keigo Oka7e880ac2019-07-03 15:03:43 +09001314 errors.append(HookFailure(msg, bad_copyright_files))
1315 if bad_year_files:
1316 msg = 'Use current year (%s) in copyright headers in new files:' % (
1317 current_year)
1318 errors.append(HookFailure(msg, bad_year_files))
Ryan Cuiec4d6332011-05-02 14:15:25 -07001319
Keigo Oka7e880ac2019-07-03 15:03:43 +09001320 return errors
Ryan Cuiec4d6332011-05-02 14:15:25 -07001321
Mike Frysinger8cf80812019-09-16 23:49:29 -04001322
Amin Hassani391efa92018-01-26 17:58:05 -08001323def _check_aosp_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001324 """Verifies the AOSP license/copyright header.
1325
1326 AOSP uses the Apache2 License:
1327 https://source.android.com/source/licenses.html
1328 """
1329 LICENSE_HEADER = (
1330 r"""^[#/\*]*
1331[#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project
1332[#/\*]* ?
1333[#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\);
1334[#/\*]* ?you may not use this file except in compliance with the License\.
1335[#/\*]* ?You may obtain a copy of the License at
1336[#/\*]* ?
1337[#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0
1338[#/\*]* ?
1339[#/\*]* ?Unless required by applicable law or agreed to in writing, software
1340[#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS,
1341[#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """
1342 r"""implied\.
1343[#/\*]* ?See the License for the specific language governing permissions and
1344[#/\*]* ?limitations under the License\.
1345[#/\*]*$
1346"""
1347 )
1348 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1349
Amin Hassani391efa92018-01-26 17:58:05 -08001350 included, excluded = _parse_common_inclusion_options(options)
1351
Ken Turnerd07564b2018-02-08 17:57:59 +11001352 files = _filter_files(
1353 _get_affected_files(commit, relative=True),
1354 included + COMMON_INCLUDED_PATHS,
1355 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Alex Deymof5792ce2015-08-24 22:50:08 -07001356
1357 bad_files = []
1358 for f in files:
1359 contents = _get_file_content(f, commit)
1360 if not contents:
1361 # Ignore empty files.
1362 continue
1363
1364 if not license_re.search(contents):
1365 bad_files.append(f)
1366
1367 if bad_files:
1368 msg = ('License must match:\n%s\nFound a bad header in these files:' %
1369 license_re.pattern)
1370 return HookFailure(msg, bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001371 return None
Alex Deymof5792ce2015-08-24 22:50:08 -07001372
1373
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001374def _check_layout_conf(_project, commit):
1375 """Verifies the metadata/layout.conf file."""
1376 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001377 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001378 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001379 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001380
Mike Frysinger94a670c2014-09-19 12:46:26 -04001381 # Handle multiple overlays in a single commit (like the public tree).
1382 for f in _get_affected_files(commit, relative=True):
1383 if f.endswith(repo_name):
1384 repo_names.append(f)
1385 elif f.endswith(layout_path):
1386 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001387
1388 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -04001389 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001390 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -04001391 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001392
Mike Frysinger94a670c2014-09-19 12:46:26 -04001393 # Gather all the errors in one pass so we show one full message.
1394 all_errors = {}
1395 for layout_path in layout_paths:
1396 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001397
Mike Frysinger94a670c2014-09-19 12:46:26 -04001398 # Make sure the config file is sorted.
1399 data = [x for x in _get_file_content(layout_path, commit).splitlines()
1400 if x and x[0] != '#']
1401 if sorted(data) != data:
1402 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001403
Mike Frysinger94a670c2014-09-19 12:46:26 -04001404 # Require people to set specific values all the time.
1405 settings = (
1406 # TODO: Enable this for everyone. http://crbug.com/408038
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001407 # ('fast caching', 'cache-format = md5-dict'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001408 ('fast manifests', 'thin-manifests = true'),
Mike Frysingerd7734522015-02-26 16:12:43 -05001409 ('extra features', 'profile-formats = portage-2 profile-default-eapi'),
1410 ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001411 )
1412 for reason, line in settings:
1413 if line not in data:
1414 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001415
Mike Frysinger94a670c2014-09-19 12:46:26 -04001416 # Require one of these settings.
Mike Frysinger5fae62d2015-11-11 20:12:15 -05001417 if 'use-manifests = strict' not in data:
1418 errors += ['enable file checking with: use-manifests = strict']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001419
Mike Frysinger94a670c2014-09-19 12:46:26 -04001420 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -04001421 for line in data:
1422 if line.startswith('repo-name = '):
1423 break
1424 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -04001425 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001426
Mike Frysinger94a670c2014-09-19 12:46:26 -04001427 # Summarize all the errors we saw (if any).
1428 lines = ''
1429 for layout_path, errors in all_errors.items():
1430 if errors:
1431 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
1432 if lines:
1433 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
1434 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001435
Mike Frysinger8cf80812019-09-16 23:49:29 -04001436 return None
1437
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001438
Keigo Oka4a09bd92019-05-07 14:01:00 +09001439def _check_no_new_gyp(_project, commit):
1440 """Verifies no project starts to use GYP."""
1441 whitelist = [
Keigo Oka4a09bd92019-05-07 14:01:00 +09001442 'chromeos/ap',
1443 'chromeos/ap-daemons',
Keigo Oka150a6fd2019-06-04 11:30:25 +09001444 'chromeos/ap/security',
1445 'chromeos/ap/wireless',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001446 'chromeos/platform/actions',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001447 'chromeos/platform/drivefs-google3',
1448 'chromeos/platform/experimental-touch-fw',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001449 'chromeos/thermald',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001450 'chromiumos/platform2',
Keigo Oka4a09bd92019-05-07 14:01:00 +09001451 'weave/libweave',
1452 ]
1453 if _project.name in whitelist:
1454 return None
1455
1456 gypfiles = _filter_files(
1457 _get_affected_files(commit, include_symlinks=True, relative=True),
1458 [r'\.gyp$'])
1459
1460 if gypfiles:
1461 return HookFailure('GYP is deprecated and not allowed in a new project:',
1462 gypfiles)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001463 return None
Keigo Oka4a09bd92019-05-07 14:01:00 +09001464
1465
Ryan Cuiec4d6332011-05-02 14:15:25 -07001466# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001467
Ryan Cui1562fb82011-05-09 11:01:31 -07001468
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001469def _check_clang_format(_project, commit, options=()):
1470 """Runs clang-format on the given project"""
1471 hooks_dir = _get_hooks_dir()
1472 options = list(options)
1473 if commit == PRE_SUBMIT:
1474 options.append('--commit=HEAD')
1475 else:
1476 options.extend(['--commit', commit])
Brian Norris0c62a142018-12-11 13:24:29 -08001477 cmd = [os.path.join(hooks_dir, 'clang-format.py')] + options
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001478 cmd_result = cros_build_lib.run(cmd,
1479 print_cmd=False,
1480 stdout=True,
1481 encoding='utf-8',
1482 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001483 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001484 check=False)
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001485 if cmd_result.returncode:
1486 return HookFailure('clang-format.py errors/warnings\n\n' +
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001487 cmd_result.stdout)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001488 return None
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001489
1490
Mike Frysingerae409522014-02-01 03:16:11 -05001491def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001492 """Runs checkpatch.pl on the given project"""
1493 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001494 options = list(options)
1495 if commit == PRE_SUBMIT:
1496 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
1497 # this case.
1498 options.append('--ignore=MISSING_SIGN_OFF')
Filipe Brandenburger28d48d62015-10-07 09:48:54 -07001499 # Always ignore the check for the MAINTAINERS file. We do not track that
1500 # information on that file in our source trees, so let's suppress the
1501 # warning.
1502 options.append('--ignore=FILE_PATH_CHANGES')
Filipe Brandenburgerce978322015-10-09 10:04:15 -07001503 # Do not complain about the Change-Id: fields, since we use Gerrit.
1504 # Upstream does not want those lines (since they do not use Gerrit), but
1505 # we always do, so disable the check globally.
Daisuke Nojiri4844f892015-10-08 09:54:33 -07001506 options.append('--ignore=GERRIT_CHANGE_ID')
Brian Norris0c62a142018-12-11 13:24:29 -08001507 cmd = [os.path.join(hooks_dir, 'checkpatch.pl')] + options + ['-']
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001508 cmd_result = cros_build_lib.run(
1509 cmd, print_cmd=False, input=_get_patch(commit).encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001510 stdout=True, stderr=subprocess.STDOUT, check=False, encoding='utf-8',
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001511 errors='replace')
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001512 if cmd_result.returncode:
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001513 return HookFailure('checkpatch.pl errors/warnings\n\n' + cmd_result.stdout)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001514 return None
Ryan Cuiec4d6332011-05-02 14:15:25 -07001515
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001516
Brian Norris23c62e92018-11-14 12:25:51 -08001517def _run_kerneldoc(_project, commit, options=()):
1518 """Runs kernel-doc validator on the given project"""
1519 included, excluded = _parse_common_inclusion_options(options)
1520 files = _filter_files(_get_affected_files(commit, relative=True),
1521 included, excluded)
1522 if files:
1523 hooks_dir = _get_hooks_dir()
Brian Norris0c62a142018-12-11 13:24:29 -08001524 cmd = [os.path.join(hooks_dir, 'kernel-doc'), '-none'] + files
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001525 output = _run_command(cmd, stderr=subprocess.STDOUT)
Brian Norris23c62e92018-11-14 12:25:51 -08001526 if output:
Brian Norris0c62a142018-12-11 13:24:29 -08001527 return HookFailure('kernel-doc errors/warnings:',
1528 items=output.splitlines())
Mike Frysinger8cf80812019-09-16 23:49:29 -04001529 return None
Brian Norris23c62e92018-11-14 12:25:51 -08001530
1531
Mike Frysingerae409522014-02-01 03:16:11 -05001532def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -07001533 """Makes sure kernel config changes are not mixed with code changes"""
1534 files = _get_affected_files(commit)
Mike Frysingerf252cfc2019-12-09 17:34:28 -05001535 if len(_filter_files(files, [r'chromeos/config'])) not in [0, len(files)]:
Olof Johanssona96810f2012-09-04 16:20:03 -07001536 return HookFailure('Changes to chromeos/config/ and regular files must '
1537 'be in separate commits:\n%s' % '\n'.join(files))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001538 return None
Anton Staaf815d6852011-08-22 10:08:45 -07001539
Mike Frysingerae409522014-02-01 03:16:11 -05001540
1541def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -07001542 """Checks that all JSON files are syntactically valid."""
Mike Frysinger908be682018-01-04 02:21:50 -05001543 ret = []
1544
1545 files = _filter_files(_get_affected_files(commit, relative=True),
1546 [r'.*\.json$'])
1547 for f in files:
1548 data = _get_file_content(f, commit)
Dale Curtis2975c432011-05-03 17:25:20 -07001549 try:
Mike Frysinger908be682018-01-04 02:21:50 -05001550 json.loads(data)
1551 except Exception as e:
1552 ret.append('%s: Invalid JSON: %s' % (f, e))
1553
1554 if ret:
1555 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001556 return None
Dale Curtis2975c432011-05-03 17:25:20 -07001557
1558
Mike Frysingerae409522014-02-01 03:16:11 -05001559def _check_manifests(_project, commit):
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001560 """Make sure Manifest files only have comments & DIST lines."""
1561 ret = []
Mike Frysinger52b537e2013-08-22 22:59:53 -04001562
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001563 manifests = _filter_files(_get_affected_files(commit, relative=True),
1564 [r'.*/Manifest$'])
1565 for path in manifests:
1566 data = _get_file_content(path, commit)
1567
1568 # Disallow blank files.
1569 if not data.strip():
1570 ret.append('%s: delete empty file' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001571 continue
1572
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001573 # Make sure the last newline isn't omitted.
1574 if data[-1] != '\n':
1575 ret.append('%s: missing trailing newline' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001576
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001577 # Do not allow leading or trailing blank lines.
1578 lines = data.splitlines()
1579 if not lines[0]:
1580 ret.append('%s: delete leading blank lines' % (path,))
1581 if not lines[-1]:
1582 ret.append('%s: delete trailing blank lines' % (path,))
1583
1584 for line in lines:
1585 # Disallow leading/trailing whitespace.
1586 if line != line.strip():
1587 ret.append('%s: remove leading/trailing whitespace: %s' % (path, line))
1588
1589 # Allow blank lines & comments.
1590 line = line.split('#', 1)[0]
1591 if not line:
1592 continue
1593
1594 # All other linse should start with DIST.
1595 if not line.startswith('DIST '):
1596 ret.append('%s: remove non-DIST lines: %s' % (path, line))
1597 break
1598
1599 if ret:
1600 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001601 return None
Mike Frysinger52b537e2013-08-22 22:59:53 -04001602
1603
Mike Frysingerae409522014-02-01 03:16:11 -05001604def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001605 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001606 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001607 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001608 BRANCH_RE = r'\nBRANCH=\S+'
1609
1610 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
1611 msg = ('Changelist description needs BRANCH field (after first line)\n'
1612 'E.g. BRANCH=none or BRANCH=link,snow')
1613 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001614 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001615
1616
Mike Frysinger45334bd2019-11-04 10:42:33 -05001617def _check_change_has_no_branch_field(_project, commit):
1618 """Verify 'BRANCH=' field does not exist in the commit message."""
1619 if commit == PRE_SUBMIT:
1620 return None
1621 BRANCH_RE = r'\nBRANCH=\S+'
1622
1623 if re.search(BRANCH_RE, _get_commit_desc(commit)):
1624 msg = 'This checkout does not use BRANCH= fields. Delete them.'
1625 return HookFailure(msg)
1626 return None
1627
1628
Mike Frysingerae409522014-02-01 03:16:11 -05001629def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001630 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001631 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001632 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001633 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1634
1635 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1636 msg = ('Changelist description needs Signed-off-by: field\n'
1637 'E.g. Signed-off-by: My Name <me@chromium.org>')
1638 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001639 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001640
1641
Mike Frysinger9ab64b12019-11-04 10:53:08 -05001642def _check_change_has_no_signoff_field(_project, commit):
1643 """Verify 'Signed-off-by:' field does not exist in the commit message."""
1644 if commit == PRE_SUBMIT:
1645 return None
1646 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1647
1648 if re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1649 msg = 'This checkout does not use Signed-off-by: tags. Delete them.'
1650 return HookFailure(msg)
1651 return None
1652
1653
Jon Salz3ee59de2012-08-18 13:54:22 +08001654def _run_project_hook_script(script, project, commit):
1655 """Runs a project hook script.
1656
1657 The script is run with the following environment variables set:
1658 PRESUBMIT_PROJECT: The affected project
1659 PRESUBMIT_COMMIT: The affected commit
1660 PRESUBMIT_FILES: A newline-separated list of affected files
1661
1662 The script is considered to fail if the exit code is non-zero. It should
1663 write an error message to stdout.
1664 """
1665 env = dict(os.environ)
Alex Deymo643ac4c2015-09-03 10:40:50 -07001666 env['PRESUBMIT_PROJECT'] = project.name
Jon Salz3ee59de2012-08-18 13:54:22 +08001667 env['PRESUBMIT_COMMIT'] = commit
1668
1669 # Put affected files in an environment variable
1670 files = _get_affected_files(commit)
1671 env['PRESUBMIT_FILES'] = '\n'.join(files)
1672
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001673 cmd_result = cros_build_lib.run(cmd=script,
1674 env=env,
1675 shell=True,
1676 print_cmd=False,
1677 input=os.devnull,
1678 stdout=True,
1679 encoding='utf-8',
1680 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001681 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001682 check=False)
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001683 if cmd_result.returncode:
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001684 stdout = cmd_result.stdout
Jon Salz7b618af2012-08-31 06:03:16 +08001685 if stdout:
1686 stdout = re.sub('(?m)^', ' ', stdout)
1687 return HookFailure('Hook script "%s" failed with code %d%s' %
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001688 (script, cmd_result.returncode,
Jon Salz3ee59de2012-08-18 13:54:22 +08001689 ':\n' + stdout if stdout else ''))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001690 return None
Jon Salz3ee59de2012-08-18 13:54:22 +08001691
1692
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001693def _check_project_prefix(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -05001694 """Require the commit message have a project specific prefix as needed."""
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001695
Brian Norris77608e12018-04-06 10:38:43 -07001696 files = _get_affected_files(commit, include_deletes=True, relative=True)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001697 prefix = os.path.commonprefix(files)
1698 prefix = os.path.dirname(prefix)
1699
1700 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07001701 if not prefix:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001702 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001703
1704 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07001705
1706 # The common files may all be within a subdirectory of the main project
1707 # directory, so walk up the tree until we find an alias file.
1708 # _get_affected_files() should return relative paths, but check against '/' to
1709 # ensure that this loop terminates even if it receives an absolute path.
1710 while prefix and prefix != '/':
1711 alias_file = os.path.join(prefix, '.project_alias')
1712
1713 # If an alias exists, use it.
1714 if os.path.isfile(alias_file):
1715 project_name = osutils.ReadFile(alias_file).strip()
1716
1717 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001718
1719 if not _get_commit_desc(commit).startswith(project_name + ': '):
1720 return HookFailure('The commit title for changes affecting only %s'
1721 ' should start with \"%s: \"'
1722 % (project_name, project_name))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001723 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001724
1725
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001726def _check_filepath_chartype(_project, commit):
1727 """Checks that FilePath::CharType stuff is not used."""
1728
1729 FILEPATH_REGEXP = re.compile('|'.join(
1730 [r'(?:base::)?FilePath::(?:Char|String|StringPiece)Type',
Satoru Takabayashi4ca37922018-08-08 10:16:38 +09001731 r'(?:base::)?FilePath::FromUTF8Unsafe',
1732 r'AsUTF8Unsafe',
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001733 r'FILE_PATH_LITERAL']))
1734 files = _filter_files(_get_affected_files(commit, relative=True),
1735 [r'.*\.(cc|h)$'])
1736
1737 errors = []
1738 for afile in files:
1739 for line_num, line in _get_file_diff(afile, commit):
1740 m = re.search(FILEPATH_REGEXP, line)
1741 if m:
1742 errors.append('%s, line %s has %s' % (afile, line_num, m.group(0)))
1743
1744 if errors:
1745 msg = 'Please assume FilePath::CharType is char (crbug.com/870621):'
1746 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001747 return None
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001748
1749
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001750def _check_exec_files(_project, commit):
1751 """Make +x bits on files."""
1752 # List of files that should never be +x.
1753 NO_EXEC = (
1754 'ChangeLog*',
1755 'COPYING',
1756 'make.conf',
1757 'make.defaults',
1758 'Manifest',
1759 'OWNERS',
1760 'package.use',
1761 'package.keywords',
1762 'package.mask',
1763 'parent',
1764 'README',
1765 'TODO',
1766 '.gitignore',
1767 '*.[achly]',
1768 '*.[ch]xx',
1769 '*.boto',
1770 '*.cc',
1771 '*.cfg',
1772 '*.conf',
1773 '*.config',
1774 '*.cpp',
1775 '*.css',
1776 '*.ebuild',
1777 '*.eclass',
Tatsuhisa Yamaguchi3b053632019-01-10 14:45:14 +09001778 '*.gn',
1779 '*.gni',
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001780 '*.gyp',
1781 '*.gypi',
1782 '*.htm',
1783 '*.html',
1784 '*.ini',
1785 '*.js',
1786 '*.json',
1787 '*.md',
1788 '*.mk',
1789 '*.patch',
1790 '*.policy',
1791 '*.proto',
1792 '*.raw',
1793 '*.rules',
1794 '*.service',
1795 '*.target',
1796 '*.txt',
1797 '*.xml',
1798 '*.yaml',
1799 )
1800
1801 def FinalName(obj):
1802 # If the file is being deleted, then the dst_file is not set.
1803 if obj.dst_file is None:
1804 return obj.src_file
1805 else:
1806 return obj.dst_file
1807
1808 bad_files = []
1809 files = _get_affected_files(commit, relative=True, full_details=True)
1810 for f in files:
1811 mode = int(f.dst_mode, 8)
1812 if not mode & 0o111:
1813 continue
1814 name = FinalName(f)
1815 for no_exec in NO_EXEC:
1816 if fnmatch.fnmatch(name, no_exec):
1817 bad_files.append(name)
1818 break
1819
1820 if bad_files:
1821 return HookFailure('These files should not be executable. '
1822 'Please `chmod -x` them.', bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001823 return None
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001824
1825
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001826# Base
1827
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001828# A list of hooks which are not project specific and check patch description
1829# (as opposed to patch body).
1830_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07001831 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07001832 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07001833 _check_change_has_test_field,
1834 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001835 _check_commit_message_style,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001836 _check_change_is_contribution,
Jack Neus8edbf642019-07-10 16:08:31 -06001837 _check_change_no_include_oem,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001838]
1839
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001840# A list of hooks that are not project-specific
1841_COMMON_HOOKS = [
Aviv Keshet5ac59522017-01-31 14:28:27 -08001842 _check_cros_license,
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001843 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05001844 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001845 _check_ebuild_licenses,
Mike Frysingercd363c82014-02-01 05:20:18 -05001846 _check_ebuild_virtual_pv,
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001847 _check_exec_files,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001848 _check_for_uprev,
Rahul Chaudhry09f61372015-07-31 17:14:26 -07001849 _check_gofmt,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001850 _check_layout_conf,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001851 _check_no_long_lines,
Keigo Oka4a09bd92019-05-07 14:01:00 +09001852 _check_no_new_gyp,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001853 _check_no_stray_whitespace,
Ryan Cui9b651632011-05-11 11:38:58 -07001854 _check_no_tabs,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001855 _check_portage_make_use_var,
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -06001856 _check_rustfmt,
Aviv Keshet5ac59522017-01-31 14:28:27 -08001857 _check_tabbed_indents,
Ryan Cui9b651632011-05-11 11:38:58 -07001858]
Ryan Cuiec4d6332011-05-02 14:15:25 -07001859
Ryan Cui1562fb82011-05-09 11:01:31 -07001860
Ryan Cui9b651632011-05-11 11:38:58 -07001861# A dictionary of project-specific hooks(callbacks), indexed by project name.
1862# dict[project] = [callback1, callback2]
1863_PROJECT_SPECIFIC_HOOKS = {
Mike Frysinger24dd3c52019-08-17 14:22:48 -04001864 'chromiumos/third_party/kernel': [_kernel_configcheck],
1865 'chromiumos/third_party/kernel-next': [_kernel_configcheck],
Ryan Cui9b651632011-05-11 11:38:58 -07001866}
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001867
Ryan Cui1562fb82011-05-09 11:01:31 -07001868
Ryan Cui9b651632011-05-11 11:38:58 -07001869# A dictionary of flags (keys) that can appear in the config file, and the hook
Mike Frysinger3554bc92015-03-11 04:59:21 -04001870# that the flag controls (value).
1871_HOOK_FLAGS = {
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001872 'clang_format_check': _check_clang_format,
Mike Frysingera7642f52015-03-25 18:31:42 -04001873 'checkpatch_check': _run_checkpatch,
Brian Norris23c62e92018-11-14 12:25:51 -08001874 'kerneldoc_check': _run_kerneldoc,
Ryan Cui9b651632011-05-11 11:38:58 -07001875 'stray_whitespace_check': _check_no_stray_whitespace,
Mike Frysingerff6c7d62015-03-24 13:49:46 -04001876 'json_check': _run_json_check,
Ryan Cui9b651632011-05-11 11:38:58 -07001877 'long_line_check': _check_no_long_lines,
Alex Deymof5792ce2015-08-24 22:50:08 -07001878 'cros_license_check': _check_cros_license,
1879 'aosp_license_check': _check_aosp_license,
LaMont Jones872fe762020-02-10 15:36:14 -07001880 'gofmt_check': _check_gofmt,
Ryan Cui9b651632011-05-11 11:38:58 -07001881 'tab_check': _check_no_tabs,
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08001882 'tabbed_indent_required_check': _check_tabbed_indents,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001883 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001884 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07001885 'bug_field_check': _check_change_has_bug_field,
1886 'test_field_check': _check_change_has_test_field,
Steve Fung49ec7e92015-03-23 16:07:12 -07001887 'manifest_check': _check_manifests,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001888 'contribution_check': _check_change_is_contribution,
Mike Frysinger47bd1252018-06-11 12:12:20 -04001889 'project_prefix_check': _check_project_prefix,
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001890 'filepath_chartype_check': _check_filepath_chartype,
Ryan Cui9b651632011-05-11 11:38:58 -07001891}
1892
1893
Mike Frysinger3554bc92015-03-11 04:59:21 -04001894def _get_override_hooks(config):
1895 """Returns a set of hooks controlled by the current project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001896
1897 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08001898
1899 Args:
1900 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001901 """
1902 SECTION = 'Hook Overrides'
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001903 SECTION_OPTIONS = 'Hook Overrides Options'
Ryan Cui9b651632011-05-11 11:38:58 -07001904
Mike Frysinger56e8de02019-07-31 14:40:14 -04001905 valid_keys = set(_HOOK_FLAGS.keys())
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001906 hooks = _HOOK_FLAGS.copy()
Mike Frysinger380592f2020-02-03 15:27:16 -05001907 options = config.options(SECTION) if config.has_section(SECTION) else []
Mike Frysinger3554bc92015-03-11 04:59:21 -04001908
1909 enable_flags = []
Ryan Cui9b651632011-05-11 11:38:58 -07001910 disable_flags = []
Mike Frysinger380592f2020-02-03 15:27:16 -05001911 for flag in options:
Mike Frysinger3554bc92015-03-11 04:59:21 -04001912 if flag not in valid_keys:
1913 raise ValueError('Error: unknown key "%s" in hook section of "%s"' %
1914 (flag, _CONFIG_FILE))
1915
Ryan Cui9b651632011-05-11 11:38:58 -07001916 try:
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001917 enabled = config.getboolean(SECTION, flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001918 except ValueError as e:
Mike Frysinger3554bc92015-03-11 04:59:21 -04001919 raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' %
1920 (flag, _CONFIG_FILE, e))
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001921 if enabled:
1922 enable_flags.append(flag)
1923 else:
1924 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001925
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001926 # See if this hook has custom options.
1927 if enabled:
1928 try:
1929 options = config.get(SECTION_OPTIONS, flag)
1930 hooks[flag] = functools.partial(hooks[flag], options=options.split())
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001931 hooks[flag].__name__ = flag
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04001932 except (configparser.NoOptionError, configparser.NoSectionError):
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001933 pass
1934
1935 enabled_hooks = set(hooks[x] for x in enable_flags)
1936 disabled_hooks = set(hooks[x] for x in disable_flags)
Mike Frysinger45334bd2019-11-04 10:42:33 -05001937
Mike Frysinger9ab64b12019-11-04 10:53:08 -05001938 if _check_change_has_signoff_field not in enabled_hooks:
1939 enabled_hooks.add(_check_change_has_no_signoff_field)
Mike Frysinger45334bd2019-11-04 10:42:33 -05001940 if _check_change_has_branch_field not in enabled_hooks:
1941 enabled_hooks.add(_check_change_has_no_branch_field)
1942
Mike Frysinger3554bc92015-03-11 04:59:21 -04001943 return enabled_hooks, disabled_hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001944
1945
Jon Salz3ee59de2012-08-18 13:54:22 +08001946def _get_project_hook_scripts(config):
1947 """Returns a list of project-specific hook scripts.
1948
1949 Args:
1950 config: A ConfigParser for the project's config file.
1951 """
1952 SECTION = 'Hook Scripts'
1953 if not config.has_section(SECTION):
1954 return []
1955
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001956 return config.items(SECTION)
Jon Salz3ee59de2012-08-18 13:54:22 +08001957
1958
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001959def _get_project_hooks(project, presubmit):
Ryan Cui9b651632011-05-11 11:38:58 -07001960 """Returns a list of hooks that need to be run for a project.
1961
1962 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001963
1964 Args:
1965 project: A string, name of the project.
1966 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui9b651632011-05-11 11:38:58 -07001967 """
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04001968 config = configparser.RawConfigParser()
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001969 if not os.path.exists(_CONFIG_FILE):
Jon Salz3ee59de2012-08-18 13:54:22 +08001970 # Just use an empty config file
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04001971 config = configparser.RawConfigParser()
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001972 else:
1973 config.read(_CONFIG_FILE)
Jon Salz3ee59de2012-08-18 13:54:22 +08001974
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001975 if presubmit:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001976 hooks = _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001977 else:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001978 hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001979
Mike Frysinger3554bc92015-03-11 04:59:21 -04001980 enabled_hooks, disabled_hooks = _get_override_hooks(config)
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001981 hooks = [hook for hook in hooks if hook not in disabled_hooks]
1982
1983 # If a list is both in _COMMON_HOOKS and also enabled explicitly through an
1984 # override, keep the override only. Note that the override may end up being
1985 # a functools.partial, in which case we need to extract the .func to compare
1986 # it to the common hooks.
1987 unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks]
1988 hooks = [hook for hook in hooks if hook not in unwrapped_hooks]
1989
1990 hooks = list(enabled_hooks) + hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001991
1992 if project in _PROJECT_SPECIFIC_HOOKS:
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001993 hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project]
1994 if hook not in disabled_hooks)
Ryan Cui9b651632011-05-11 11:38:58 -07001995
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001996 for name, script in _get_project_hook_scripts(config):
1997 func = functools.partial(_run_project_hook_script, script)
1998 func.__name__ = name
1999 hooks.append(func)
Jon Salz3ee59de2012-08-18 13:54:22 +08002000
Ryan Cui9b651632011-05-11 11:38:58 -07002001 return hooks
2002
2003
Alex Deymo643ac4c2015-09-03 10:40:50 -07002004def _run_project_hooks(project_name, proj_dir=None,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002005 commit_list=None, presubmit=False):
Ryan Cui1562fb82011-05-09 11:01:31 -07002006 """For each project run its project specific hook from the hooks dictionary.
2007
2008 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002009 project_name: The name of project to run hooks for.
Doug Anderson44a644f2011-11-02 10:37:37 -07002010 proj_dir: If non-None, this is the directory the project is in. If None,
2011 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07002012 commit_list: A list of commits to run hooks against. If None or empty list
2013 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002014 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui1562fb82011-05-09 11:01:31 -07002015
2016 Returns:
2017 Boolean value of whether any errors were ecountered while running the hooks.
2018 """
Doug Anderson44a644f2011-11-02 10:37:37 -07002019 if proj_dir is None:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002020 proj_dirs = _run_command(
2021 ['repo', 'forall', project_name, '-c', 'pwd']).split()
Mike Frysingere52b1bc2019-09-16 23:45:41 -04002022 if not proj_dirs:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002023 print('%s cannot be found.' % project_name, file=sys.stderr)
David James2edd9002013-10-11 14:09:19 -07002024 print('Please specify a valid project.', file=sys.stderr)
2025 return True
2026 if len(proj_dirs) > 1:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002027 print('%s is associated with multiple directories.' % project_name,
David James2edd9002013-10-11 14:09:19 -07002028 file=sys.stderr)
2029 print('Please specify a directory to help disambiguate.', file=sys.stderr)
2030 return True
2031 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07002032
Ryan Cuiec4d6332011-05-02 14:15:25 -07002033 pwd = os.getcwd()
2034 # hooks assume they are run from the root of the project
2035 os.chdir(proj_dir)
2036
Mike Frysingered1b95a2019-12-12 19:04:51 -05002037 color = terminal.Color()
2038
Alex Deymo643ac4c2015-09-03 10:40:50 -07002039 remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref',
2040 '--symbolic-full-name', '@{u}']).strip()
2041 if not remote_branch:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002042 print("Your project %s doesn't track any remote repo." % project_name,
Alex Deymo643ac4c2015-09-03 10:40:50 -07002043 file=sys.stderr)
2044 remote = None
2045 else:
Josh Pratt15d13ab2018-08-13 11:52:48 +10002046 branch_items = remote_branch.split('/', 1)
2047 if len(branch_items) != 2:
2048 PrintErrorForProject(
2049 project_name,
2050 HookFailure(
2051 'Cannot get remote and branch name (%s)' % remote_branch))
2052 os.chdir(pwd)
2053 return True
2054 remote, _branch = branch_items
Alex Deymo643ac4c2015-09-03 10:40:50 -07002055
2056 project = Project(name=project_name, dir=proj_dir, remote=remote)
2057
Doug Anderson14749562013-06-26 13:38:29 -07002058 if not commit_list:
2059 try:
2060 commit_list = _get_commits()
2061 except VerifyException as e:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002062 PrintErrorForProject(project.name, HookFailure(str(e)))
Doug Anderson14749562013-06-26 13:38:29 -07002063 os.chdir(pwd)
2064 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07002065
Alex Deymo643ac4c2015-09-03 10:40:50 -07002066 hooks = _get_project_hooks(project.name, presubmit)
Ryan Cui1562fb82011-05-09 11:01:31 -07002067 error_found = False
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002068 commit_count = len(commit_list)
Mike Frysingerb99b3772019-08-17 14:19:44 -04002069 hook_count = len(hooks)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002070 for i, commit in enumerate(commit_list):
Mike Frysingerb2496652019-09-12 23:35:46 -04002071 CACHE.clear()
2072
Mike Frysingered1b95a2019-12-12 19:04:51 -05002073 desc = _get_commit_desc(commit)
2074 print('[%s %i/%i %s] %s' %
2075 (color.Color(color.CYAN, 'COMMIT'), i + 1, commit_count, commit[0:12],
2076 desc.splitlines()[0]))
2077
Mike Frysingerb99b3772019-08-17 14:19:44 -04002078 for h, hook in enumerate(hooks):
Mike Frysingered1b95a2019-12-12 19:04:51 -05002079 output = ('[%s %i/%i PRESUBMIT.cfg] %s' %
2080 (color.Color(color.YELLOW, 'RUNNING'), h + 1, hook_count,
2081 hook.__name__))
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002082 print(output, end='\r')
2083 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002084 hook_error = hook(project, commit)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002085 print(' ' * len(output), end='\r')
2086 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002087 if hook_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002088 if not isinstance(hook_error, list):
2089 hook_error = [hook_error]
2090 PrintErrorsForCommit(color, hook, project.name, hook_error)
Ryan Cui1562fb82011-05-09 11:01:31 -07002091 error_found = True
Don Garrettdba548a2011-05-05 15:17:14 -07002092
Ryan Cuiec4d6332011-05-02 14:15:25 -07002093 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07002094 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002095
Mike Frysingerae409522014-02-01 03:16:11 -05002096
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002097# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002098
Ryan Cui1562fb82011-05-09 11:01:31 -07002099
Mike Frysingerae409522014-02-01 03:16:11 -05002100def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08002101 """Main function invoked directly by repo.
2102
2103 This function will exit directly upon error so that repo doesn't print some
2104 obscure error message.
2105
2106 Args:
2107 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07002108 worktree_list: A list of directories. It should be the same length as
2109 project_list, so that each entry in project_list matches with a directory
2110 in worktree_list. If None, we will attempt to calculate the directories
2111 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08002112 kwargs: Leave this here for forward-compatibility.
2113 """
Mike Frysingered1b95a2019-12-12 19:04:51 -05002114 start_time = datetime.datetime.now()
Ryan Cui1562fb82011-05-09 11:01:31 -07002115 found_error = False
David James2edd9002013-10-11 14:09:19 -07002116 if not worktree_list:
2117 worktree_list = [None] * len(project_list)
2118 for project, worktree in zip(project_list, worktree_list):
2119 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07002120 found_error = True
2121
Mike Frysingered1b95a2019-12-12 19:04:51 -05002122 end_time = datetime.datetime.now()
2123 color = terminal.Color()
Mike Frysingerae409522014-02-01 03:16:11 -05002124 if found_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002125 msg = ('%s: Preupload failed due to above error(s).\n'
Ryan Cui9b651632011-05-11 11:38:58 -07002126 '- To disable some source style checks, and for other hints, see '
Mike Frysingered1b95a2019-12-12 19:04:51 -05002127 '<checkout_dir>/src/repohooks/README.md\n'
2128 "- To upload only current project, run 'repo upload .'" %
2129 (color.Color(color.RED, 'FATAL'),))
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04002130 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07002131 sys.exit(1)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002132 else:
2133 msg = ('[%s] repohooks passed in %s' %
2134 (color.Color(color.GREEN, 'PASSED'), end_time - start_time))
2135 print(msg)
Anush Elangovan63afad72011-03-23 00:41:27 -07002136
Ryan Cui1562fb82011-05-09 11:01:31 -07002137
Doug Anderson44a644f2011-11-02 10:37:37 -07002138def _identify_project(path):
2139 """Identify the repo project associated with the given path.
2140
2141 Returns:
2142 A string indicating what project is associated with the path passed in or
2143 a blank string upon failure.
2144 """
2145 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002146 stderr=True, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002147
2148
Mike Frysinger55f85b52014-12-18 14:45:21 -05002149def direct_main(argv):
Doug Anderson44a644f2011-11-02 10:37:37 -07002150 """Run hooks directly (outside of the context of repo).
2151
Doug Anderson44a644f2011-11-02 10:37:37 -07002152 Args:
Mike Frysinger55f85b52014-12-18 14:45:21 -05002153 argv: The command line args to process
Doug Anderson44a644f2011-11-02 10:37:37 -07002154
2155 Returns:
2156 0 if no pre-upload failures, 1 if failures.
2157
2158 Raises:
2159 BadInvocation: On some types of invocation errors.
2160 """
Mike Frysinger66142932014-12-18 14:55:57 -05002161 parser = commandline.ArgumentParser(description=__doc__)
2162 parser.add_argument('--dir', default=None,
2163 help='The directory that the project lives in. If not '
2164 'specified, use the git project root based on the cwd.')
2165 parser.add_argument('--project', default=None,
2166 help='The project repo path; this can affect how the '
2167 'hooks get run, since some hooks are project-specific. '
2168 'For chromite this is chromiumos/chromite. If not '
2169 'specified, the repo tool will be used to figure this '
2170 'out based on the dir.')
2171 parser.add_argument('--rerun-since', default=None,
Vadim Bendebury75447b92018-01-10 12:06:01 -08002172 help='Rerun hooks on old commits since some point '
2173 'in the past. The argument could be a date (should '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002174 "match git log's concept of a date, e.g. 2012-06-20), "
Vadim Bendebury75447b92018-01-10 12:06:01 -08002175 'or a SHA1, or just a number of commits to check (from 1 '
2176 'to 99). This option is mutually exclusive with '
2177 '--pre-submit.')
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002178 parser.add_argument('--pre-submit', action='store_true',
Mike Frysinger66142932014-12-18 14:55:57 -05002179 help='Run the check against the pending commit. '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002180 "This option should be used at the 'git commit' "
2181 "phase as opposed to 'repo upload'. This option "
Mike Frysinger66142932014-12-18 14:55:57 -05002182 'is mutually exclusive with --rerun-since.')
2183 parser.add_argument('commits', nargs='*',
2184 help='Check specific commits')
2185 opts = parser.parse_args(argv)
Doug Anderson44a644f2011-11-02 10:37:37 -07002186
Doug Anderson14749562013-06-26 13:38:29 -07002187 if opts.rerun_since:
Mike Frysinger66142932014-12-18 14:55:57 -05002188 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002189 raise BadInvocation("Can't pass commits and use rerun-since: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002190 ' '.join(opts.commits))
Doug Anderson14749562013-06-26 13:38:29 -07002191
Vadim Bendebury75447b92018-01-10 12:06:01 -08002192 if len(opts.rerun_since) < 3 and opts.rerun_since.isdigit():
2193 # This must be the number of commits to check. We don't expect the user
2194 # to want to check more than 99 commits.
2195 limit = '-n%s' % opts.rerun_since
2196 elif git.IsSHA1(opts.rerun_since, False):
2197 limit = '%s..' % opts.rerun_since
2198 else:
2199 # This better be a date.
2200 limit = '--since=%s' % opts.rerun_since
2201 cmd = ['git', 'log', limit, '--pretty=%H']
Doug Anderson14749562013-06-26 13:38:29 -07002202 all_commits = _run_command(cmd).splitlines()
2203 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
2204
2205 # Eliminate chrome-bot commits but keep ordering the same...
2206 bot_commits = set(bot_commits)
Mike Frysinger66142932014-12-18 14:55:57 -05002207 opts.commits = [c for c in all_commits if c not in bot_commits]
Doug Anderson14749562013-06-26 13:38:29 -07002208
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002209 if opts.pre_submit:
2210 raise BadInvocation('rerun-since and pre-submit can not be '
2211 'used together')
2212 if opts.pre_submit:
Mike Frysinger66142932014-12-18 14:55:57 -05002213 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002214 raise BadInvocation("Can't pass commits and use pre-submit: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002215 ' '.join(opts.commits))
2216 opts.commits = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07002217
2218 # Check/normlaize git dir; if unspecified, we'll use the root of the git
2219 # project from CWD
2220 if opts.dir is None:
2221 git_dir = _run_command(['git', 'rev-parse', '--git-dir'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002222 stderr=True).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002223 if not git_dir:
2224 raise BadInvocation('The current directory is not part of a git project.')
2225 opts.dir = os.path.dirname(os.path.abspath(git_dir))
2226 elif not os.path.isdir(opts.dir):
2227 raise BadInvocation('Invalid dir: %s' % opts.dir)
2228 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
2229 raise BadInvocation('Not a git directory: %s' % opts.dir)
2230
2231 # Identify the project if it wasn't specified; this _requires_ the repo
2232 # tool to be installed and for the project to be part of a repo checkout.
2233 if not opts.project:
2234 opts.project = _identify_project(opts.dir)
2235 if not opts.project:
2236 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
2237
Doug Anderson14749562013-06-26 13:38:29 -07002238 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Mike Frysinger66142932014-12-18 14:55:57 -05002239 commit_list=opts.commits,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002240 presubmit=opts.pre_submit)
Doug Anderson44a644f2011-11-02 10:37:37 -07002241 if found_error:
2242 return 1
2243 return 0
2244
2245
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002246if __name__ == '__main__':
Mike Frysinger55f85b52014-12-18 14:45:21 -05002247 sys.exit(direct_main(sys.argv[1:]))