blob: 9199299c3cf5362a6581ef569942b388a1eb4cbd [file] [log] [blame]
Mike Frysinger4f994402019-09-13 17:40:45 -04001#!/usr/bin/env python3
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002# -*- coding: utf-8 -*-
Jon Salz98255932012-08-18 14:48:02 +08003# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
Mike Frysingerae409522014-02-01 03:16:11 -05007"""Presubmit checks to run when doing `repo upload`.
8
Tom Hughes40bdce52020-08-25 08:57:03 -07009You can add new checks by adding a function to the HOOKS constants.
Mike Frysingerae409522014-02-01 03:16:11 -050010"""
11
Mike Frysinger09d6a3d2013-10-08 22:21:03 -040012from __future__ import print_function
13
Keigo Okadd908822019-06-04 11:30:25 +090014import argparse
Alex Deymo643ac4c2015-09-03 10:40:50 -070015import collections
Mike Frysingerf252cfc2019-12-09 17:34:28 -050016import configparser
Keigo Oka7e880ac2019-07-03 15:03:43 +090017import datetime
Daniel Erate3ea3fc2015-02-13 15:27:52 -070018import fnmatch
Jon Salz3ee59de2012-08-18 13:54:22 +080019import functools
Dale Curtis2975c432011-05-03 17:25:20 -070020import json
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070021import os
Ryan Cuiec4d6332011-05-02 14:15:25 -070022import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070023import sys
Peter Ammon811f6702014-06-12 15:45:38 -070024import stat
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -050025import subprocess
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070026
Ryan Cui1562fb82011-05-09 11:01:31 -070027from errors import (VerifyException, HookFailure, PrintErrorForProject,
28 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070029
Mike Frysinger919c7032019-09-13 17:48:08 -040030if __name__ in ('__builtin__', 'builtins'):
Mike Frysinger653cd262019-09-20 14:05:02 -040031 # If repo imports us, the __name__ will be __builtin__, and the cwd will be in
32 # the top level of the checkout (i.e. $CHROMEOS_CHECKOUT). chromite will be
33 # in that directory, so add it to our path. This works whether we're running
34 # the repo in $CHROMEOS_CHECKOUT/.repo/repo/ or a custom version in a
35 # completely different tree.
36 # TODO(vapier): Python 2 used "__builtin__" while Python 3 uses "builtins".
Mike Frysinger6850d512018-05-21 12:12:14 -040037 sys.path.insert(0, os.getcwd())
38
Mike Frysinger653cd262019-09-20 14:05:02 -040039elif __name__ == '__main__':
40 # If we're run directly, we'll find chromite relative to the repohooks dir in
41 # $CHROMEOS_CHECKOUT/src/repohooks, so go up two dirs.
David Jamesc3b68b32013-04-03 09:17:03 -070042 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
43
Mike Frysingerfd481ce2019-09-13 18:14:48 -040044# The sys.path monkey patching confuses the linter.
45# pylint: disable=wrong-import-position
Mike Frysinger66142932014-12-18 14:55:57 -050046from chromite.lib import commandline
Rahul Chaudhry0e515342015-08-07 12:00:43 -070047from chromite.lib import cros_build_lib
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050048from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070049from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070050from chromite.lib import patch
Mike Frysingered1b95a2019-12-12 19:04:51 -050051from chromite.lib import terminal
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040052from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070053
Mike Frysingerff4768e2020-02-27 18:48:13 -050054
55assert sys.version_info >= (3, 6), 'This module requires Python 3.6+'
56
57
Vadim Bendebury2b62d742014-06-22 13:14:51 -070058PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070059
Mike Frysingered9b2a02019-12-12 18:52:32 -050060
61# Link to commit message documentation for users.
62DOC_COMMIT_MSG_URL = ('https://chromium.googlesource.com/chromiumos/docs/+/HEAD'
63 '/contributing.md#commit-messages')
64
65
Ryan Cuiec4d6332011-05-02 14:15:25 -070066COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050067 # C++ and friends
Mike Frysinger24dd3c52019-08-17 14:22:48 -040068 r'.*\.c$', r'.*\.cc$', r'.*\.cpp$', r'.*\.h$', r'.*\.m$', r'.*\.mm$',
69 r'.*\.inl$', r'.*\.asm$', r'.*\.hxx$', r'.*\.hpp$', r'.*\.s$', r'.*\.S$',
Mike Frysingerae409522014-02-01 03:16:11 -050070 # Scripts
Mike Frysinger24dd3c52019-08-17 14:22:48 -040071 r'.*\.js$', r'.*\.py$', r'.*\.sh$', r'.*\.rb$', r'.*\.pl$', r'.*\.pm$',
Mike Frysingerae409522014-02-01 03:16:11 -050072 # No extension at all, note that ALL CAPS files are black listed in
73 # COMMON_EXCLUDED_LIST below.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040074 r'(^|.*[\\\/])[^.]+$',
Mike Frysingerae409522014-02-01 03:16:11 -050075 # Other
Mike Frysinger24dd3c52019-08-17 14:22:48 -040076 r'.*\.java$', r'.*\.mk$', r'.*\.am$',
77 r'.*\.policy$', r'.*\.conf$', r'.*\.go$',
78 r'(^OWNERS|/OWNERS)',
Ryan Cuiec4d6332011-05-02 14:15:25 -070079]
80
Ryan Cui1562fb82011-05-09 11:01:31 -070081
Ryan Cuiec4d6332011-05-02 14:15:25 -070082COMMON_EXCLUDED_PATHS = [
Daniel Erate3ea3fc2015-02-13 15:27:52 -070083 # For ebuild trees, ignore any caches and manifest data.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040084 r'.*/Manifest$',
85 r'.*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$',
Doug Anderson5bfb6792011-10-25 16:45:41 -070086
Daniel Erate3ea3fc2015-02-13 15:27:52 -070087 # Ignore profiles data (like overlay-tegra2/profiles).
Mike Frysinger24dd3c52019-08-17 14:22:48 -040088 r'(^|.*/)overlay-.*/profiles/.*',
89 r'^profiles/.*$',
Mike Frysinger98638102014-08-28 00:15:08 -040090
C Shapiro8f90e9b2017-06-28 09:54:50 -060091 # Ignore config files in ebuild setup.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040092 r'(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*',
93 r'^chromeos-base/chromeos-bsp.*/files/.*',
C Shapiro8f90e9b2017-06-28 09:54:50 -060094
Daniel Erate3ea3fc2015-02-13 15:27:52 -070095 # Ignore minified js and jquery.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040096 r'.*\.min\.js',
97 r'.*jquery.*\.js',
Mike Frysinger33a458d2014-03-03 17:00:51 -050098
99 # Ignore license files as the content is often taken verbatim.
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400100 r'.*/licenses/.*',
Alex Klein619c0912019-01-30 17:13:23 -0700101
Mike Frysinger13650402019-07-31 14:31:46 -0400102 # Exclude generated protobuf bindings.
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400103 r'.*_pb2\.py$',
104 r'.*\.pb\.go$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700105]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700106
Ken Turnerd07564b2018-02-08 17:57:59 +1100107LICENSE_EXCLUDED_PATHS = [
LaMont Jones775c2b32020-02-19 17:32:54 -0700108 r'^(.*/)?OWNERS(\..*)?$',
Ken Turnerd07564b2018-02-08 17:57:59 +1100109]
Ryan Cui1562fb82011-05-09 11:01:31 -0700110
Ryan Cui9b651632011-05-11 11:38:58 -0700111_CONFIG_FILE = 'PRESUBMIT.cfg'
112
113
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700114# File containing wildcards, one per line, matching files that should be
115# excluded from presubmit checks. Lines beginning with '#' are ignored.
116_IGNORE_FILE = '.presubmitignore'
117
Cheng Yuehb707c522020-01-02 14:06:59 +0800118
119TEST_FIELD_RE = r'\nTEST=\S+'
120
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700121BLOCKED_TERMS_FILE = 'blocked_terms.txt'
122UNBLOCKED_TERMS_FILE = 'unblocked_terms.txt'
123
Doug Anderson44a644f2011-11-02 10:37:37 -0700124# Exceptions
125
126
127class BadInvocation(Exception):
128 """An Exception indicating a bad invocation of the program."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700129
130
Ryan Cui1562fb82011-05-09 11:01:31 -0700131# General Helpers
132
Sean Paulba01d402011-05-05 11:36:23 -0400133
Mike Frysingerb2496652019-09-12 23:35:46 -0400134class Cache(object):
135 """General helper for caching git content."""
136
137 def __init__(self):
138 self._cache = {}
139
140 def get_subcache(self, scope):
141 return self._cache.setdefault(scope, {})
142
143 def clear(self):
144 self._cache.clear()
145
146CACHE = Cache()
147
148
Alex Deymo643ac4c2015-09-03 10:40:50 -0700149Project = collections.namedtuple('Project', ['name', 'dir', 'remote'])
150
151
Mike Frysinger526a5f82019-09-13 18:05:30 -0400152def _run_command(cmd, **kwargs):
Doug Anderson44a644f2011-11-02 10:37:37 -0700153 """Executes the passed in command and returns raw stdout output.
154
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400155 This is a convenience func to set some run defaults differently.
Mike Frysinger526a5f82019-09-13 18:05:30 -0400156
Doug Anderson44a644f2011-11-02 10:37:37 -0700157 Args:
158 cmd: The command to run; should be a list of strings.
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400159 **kwargs: Same as cros_build_lib.run.
Doug Anderson44a644f2011-11-02 10:37:37 -0700160
161 Returns:
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700162 The stdout from the process (discards stderr and returncode).
Doug Anderson44a644f2011-11-02 10:37:37 -0700163 """
Mike Frysinger526a5f82019-09-13 18:05:30 -0400164 kwargs.setdefault('print_cmd', False)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400165 kwargs.setdefault('stdout', True)
166 kwargs.setdefault('check', False)
Mike Frysinger054c1592019-11-18 03:51:54 -0500167 result = cros_build_lib.run(cmd, **kwargs)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400168 # NB: We decode this directly rather than through kwargs as our tests rely
169 # on this post-processing behavior currently.
Mike Frysinger71e643e2019-09-13 17:26:39 -0400170 return result.output.decode('utf-8', 'replace')
Ryan Cui72834d12011-05-05 14:51:33 -0700171
Ryan Cui1562fb82011-05-09 11:01:31 -0700172
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700173def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700174 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700175 if __name__ == '__main__':
176 # Works when file is run on its own (__file__ is defined)...
177 return os.path.abspath(os.path.dirname(__file__))
178 else:
179 # We need to do this when we're run through repo. Since repo executes
180 # us with execfile(), we don't get __file__ defined.
181 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
182 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700183
Ryan Cui1562fb82011-05-09 11:01:31 -0700184
Ryan Cuiec4d6332011-05-02 14:15:25 -0700185def _match_regex_list(subject, expressions):
186 """Try to match a list of regular expressions to a string.
187
188 Args:
189 subject: The string to match regexes on
190 expressions: A list of regular expressions to check for matches with.
191
192 Returns:
193 Whether the passed in subject matches any of the passed in regexes.
194 """
195 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500196 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700197 return True
198 return False
199
Ryan Cui1562fb82011-05-09 11:01:31 -0700200
Mike Frysingerae409522014-02-01 03:16:11 -0500201def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700202 """Filter out files based on the conditions passed in.
203
204 Args:
205 files: list of filepaths to filter
206 include_list: list of regex that when matched with a file path will cause it
207 to be added to the output list unless the file is also matched with a
208 regex in the exclude_list.
209 exclude_list: list of regex that when matched with a file will prevent it
210 from being added to the output list, even if it is also matched with a
211 regex in the include_list.
212
213 Returns:
214 A list of filepaths that contain files matched in the include_list and not
215 in the exclude_list.
216 """
217 filtered = []
218 for f in files:
219 if (_match_regex_list(f, include_list) and
220 not _match_regex_list(f, exclude_list)):
221 filtered.append(f)
222 return filtered
223
Ryan Cuiec4d6332011-05-02 14:15:25 -0700224
225# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700226
227
Ryan Cui4725d952011-05-05 15:41:19 -0700228def _get_upstream_branch():
229 """Returns the upstream tracking branch of the current branch.
230
231 Raises:
232 Error if there is no tracking branch
233 """
234 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
235 current_branch = current_branch.replace('refs/heads/', '')
236 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700237 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700238
239 cfg_option = 'branch.' + current_branch + '.%s'
240 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
241 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
242 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700243 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700244
245 return full_upstream.replace('heads', 'remotes/' + remote)
246
Ryan Cui1562fb82011-05-09 11:01:31 -0700247
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700248def _get_patch(commit):
249 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700250 if commit == PRE_SUBMIT:
251 return _run_command(['git', 'diff', '--cached', 'HEAD'])
252 else:
253 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700254
Ryan Cui1562fb82011-05-09 11:01:31 -0700255
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500256def _get_file_content(path, commit):
257 """Returns the content of a file at a specific commit.
258
259 We can't rely on the file as it exists in the filesystem as people might be
260 uploading a series of changes which modifies the file multiple times.
261
262 Note: The "content" of a symlink is just the target. So if you're expecting
263 a full file, you should check that first. One way to detect is that the
264 content will not have any newlines.
265 """
Mike Frysingerb2496652019-09-12 23:35:46 -0400266 # Make sure people don't accidentally pass in full paths which will never
267 # work. You need to use relative=True with _get_affected_files.
268 if path.startswith('/'):
269 raise ValueError('_get_file_content must be called with relative paths: %s'
270 % (path,))
271
272 # {<commit>: {<path1>: <content>, <path2>: <content>}}
273 cache = CACHE.get_subcache('get_file_content')
274 if path in cache:
275 return cache[path]
276
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700277 if commit == PRE_SUBMIT:
Yu-Ping Wue3e47362020-09-22 15:54:40 +0800278 content = _run_command(['git', 'diff', 'HEAD', '--', path])
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700279 else:
Mike Frysingerb2496652019-09-12 23:35:46 -0400280 content = _run_command(['git', 'show', '%s:%s' % (commit, path)])
281 cache[path] = content
282 return content
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500283
284
Mike Frysingerae409522014-02-01 03:16:11 -0500285def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700286 """Returns a list of (linenum, lines) tuples that the commit touched."""
Mike Frysingerb2496652019-09-12 23:35:46 -0400287 # {<commit>: {<path1>: <content>, <path2>: <content>}}
288 cache = CACHE.get_subcache('get_file_diff')
289 if path in cache:
290 return cache[path]
291
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700292 if commit == PRE_SUBMIT:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800293 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD',
Yu-Ping Wue3e47362020-09-22 15:54:40 +0800294 '--', path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700295 else:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800296 command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit,
Yu-Ping Wue3e47362020-09-22 15:54:40 +0800297 '--', path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700298 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700299
300 new_lines = []
301 line_num = 0
302 for line in output.splitlines():
303 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
304 if m:
305 line_num = int(m.groups(1)[0])
306 continue
307 if line.startswith('+') and not line.startswith('++'):
Mike Frysinger71e643e2019-09-13 17:26:39 -0400308 new_lines.append((line_num, line[1:]))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700309 if not line.startswith('-'):
310 line_num += 1
Mike Frysingerb2496652019-09-12 23:35:46 -0400311 cache[path] = new_lines
Ryan Cuiec4d6332011-05-02 14:15:25 -0700312 return new_lines
313
Ryan Cui1562fb82011-05-09 11:01:31 -0700314
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700315def _get_ignore_wildcards(directory, cache):
316 """Get wildcards listed in a directory's _IGNORE_FILE.
317
318 Args:
319 directory: A string containing a directory path.
320 cache: A dictionary (opaque to caller) caching previously-read wildcards.
321
322 Returns:
323 A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE
324 wasn't present.
325 """
326 # In the cache, keys are directories and values are lists of wildcards from
327 # _IGNORE_FILE within those directories (and empty if no file was present).
328 if directory not in cache:
329 wildcards = []
330 dotfile_path = os.path.join(directory, _IGNORE_FILE)
331 if os.path.exists(dotfile_path):
332 # TODO(derat): Consider using _get_file_content() to get the file as of
333 # this commit instead of the on-disk version. This may have a noticeable
334 # performance impact, as each call to _get_file_content() runs git.
335 with open(dotfile_path, 'r') as dotfile:
336 for line in dotfile.readlines():
337 line = line.strip()
338 if line.startswith('#'):
339 continue
340 if line.endswith('/'):
341 line += '*'
342 wildcards.append(line)
343 cache[directory] = wildcards
344
345 return cache[directory]
346
347
348def _path_is_ignored(path, cache):
349 """Check whether a path is ignored by _IGNORE_FILE.
350
351 Args:
352 path: A string containing a path.
353 cache: A dictionary (opaque to caller) caching previously-read wildcards.
354
355 Returns:
356 True if a file named _IGNORE_FILE in one of the passed-in path's parent
357 directories contains a wildcard matching the path.
358 """
359 # Skip ignore files.
360 if os.path.basename(path) == _IGNORE_FILE:
361 return True
362
363 path = os.path.abspath(path)
364 base = os.getcwd()
365
366 prefix = os.path.dirname(path)
367 while prefix.startswith(base):
368 rel_path = path[len(prefix) + 1:]
369 for wildcard in _get_ignore_wildcards(prefix, cache):
370 if fnmatch.fnmatch(rel_path, wildcard):
371 return True
372 prefix = os.path.dirname(prefix)
373
374 return False
375
376
Mike Frysinger292b45d2014-11-25 01:17:10 -0500377def _get_affected_files(commit, include_deletes=False, relative=False,
378 include_symlinks=False, include_adds=True,
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700379 full_details=False, use_ignore_files=True):
Peter Ammon811f6702014-06-12 15:45:38 -0700380 """Returns list of file paths that were modified/added, excluding symlinks.
381
382 Args:
383 commit: The commit
384 include_deletes: If true, we'll include deleted files in the result
385 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500386 include_symlinks: If true, we'll include symlinks in the result
387 include_adds: If true, we'll include new files in the result
388 full_details: If False, return filenames, else return structured results.
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700389 use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files.
Peter Ammon811f6702014-06-12 15:45:38 -0700390
391 Returns:
392 A list of modified/added (and perhaps deleted) files
393 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500394 if not relative and full_details:
395 raise ValueError('full_details only supports relative paths currently')
396
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700397 if commit == PRE_SUBMIT:
398 return _run_command(['git', 'diff-index', '--cached',
399 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500400
401 path = os.getcwd()
Mike Frysingerb2496652019-09-12 23:35:46 -0400402 # {<commit>: {<path1>: <content>, <path2>: <content>}}
403 cache = CACHE.get_subcache('get_affected_files')
404 if path not in cache:
405 cache[path] = git.RawDiff(path, '%s^!' % commit)
406 files = cache[path]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500407
408 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500409 if not include_symlinks:
410 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500411
412 if not include_deletes:
413 files = [x for x in files if x.status != 'D']
414
Mike Frysinger292b45d2014-11-25 01:17:10 -0500415 if not include_adds:
416 files = [x for x in files if x.status != 'A']
417
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700418 if use_ignore_files:
419 cache = {}
420 is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache)
421 files = [x for x in files if not is_ignored(x)]
422
Mike Frysinger292b45d2014-11-25 01:17:10 -0500423 if full_details:
424 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500425 return files
426 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500427 # Caller only cares about filenames.
428 files = [x.dst_file if x.dst_file else x.src_file for x in files]
429 if relative:
430 return files
431 else:
432 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700433
434
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700435def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700436 """Returns a list of commits for this review."""
Mike Frysingere300c7d2019-09-12 23:33:52 -0400437 cmd = ['git', 'log', '--no-merges', '--format=%H',
438 '%s..' % _get_upstream_branch()]
Ryan Cui72834d12011-05-05 14:51:33 -0700439 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700440
Ryan Cui1562fb82011-05-09 11:01:31 -0700441
Ryan Cuiec4d6332011-05-02 14:15:25 -0700442def _get_commit_desc(commit):
443 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700444 if commit == PRE_SUBMIT:
445 return ''
Mike Frysingerb2496652019-09-12 23:35:46 -0400446
447 # {<commit>: <content>}
448 cache = CACHE.get_subcache('get_commit_desc')
449 if commit not in cache:
Mike Frysinger4efdee72019-11-04 10:57:01 -0500450 cache[commit] = _run_command(['git', 'log', '--format=%B',
Mike Frysingerb2496652019-09-12 23:35:46 -0400451 commit + '^!'])
452 return cache[commit]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700453
454
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800455def _check_lines_in_diff(commit, files, check_callable, error_description):
456 """Checks given file for errors via the given check.
457
458 This is a convenience function for common per-line checks. It goes through all
459 files and returns a HookFailure with the error description listing all the
460 failures.
461
462 Args:
463 commit: The commit we're working on.
464 files: The files to check.
465 check_callable: A callable that takes a line and returns True if this line
466 _fails_ the check.
467 error_description: A string describing the error.
468 """
469 errors = []
470 for afile in files:
471 for line_num, line in _get_file_diff(afile, commit):
Bernie Thompson8e26f742020-07-23 14:32:31 -0700472 result = check_callable(line)
473 if result:
474 msg = f'{afile}, line {line_num}'
475 if isinstance(result, str):
476 msg += f': {result}'
477 errors.append(msg)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800478 if errors:
479 return HookFailure(error_description, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400480 return None
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800481
482
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900483def _parse_common_inclusion_options(options):
484 """Parses common hook options for including/excluding files.
485
486 Args:
487 options: Option string list.
488
489 Returns:
490 (included, excluded) where each one is a list of regex strings.
491 """
492 parser = argparse.ArgumentParser()
493 parser.add_argument('--exclude_regex', action='append')
494 parser.add_argument('--include_regex', action='append')
495 opts = parser.parse_args(options)
496 included = opts.include_regex or []
497 excluded = opts.exclude_regex or []
498 return included, excluded
499
500
Ryan Cuiec4d6332011-05-02 14:15:25 -0700501# Common Hooks
502
Ryan Cui1562fb82011-05-09 11:01:31 -0700503
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900504def _check_no_long_lines(_project, commit, options=()):
Mike Frysinger55f85b52014-12-18 14:45:21 -0500505 """Checks there are no lines longer than MAX_LEN in any of the text files."""
Keigo Oka9732e382019-06-28 17:44:59 +0900506 LONG_LINE_OK_PATHS = [
507 # Go has no line length limit.
508 # https://golang.org/doc/effective_go.html#formatting
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400509 r'.*\.go$',
Mike Frysingerf8961942020-05-15 00:36:31 -0400510 # Python does its own long line checks via pylint.
511 r'.*\.py$',
Keigo Oka9732e382019-06-28 17:44:59 +0900512 ]
Mike Frysinger55f85b52014-12-18 14:45:21 -0500513
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900514 DEFAULT_MAX_LENGTHS = [
515 # Java's line length limit is 100 chars.
516 # https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md
517 (r'.*\.java$', 100),
Mike Frysingerf8961942020-05-15 00:36:31 -0400518 # Rust's line length limit is 100 chars.
519 (r'.*\.rs$', 100),
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900520 ]
521
Ryan Cuiec4d6332011-05-02 14:15:25 -0700522 MAX_LEN = 80
523
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900524 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700525 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900526 included + COMMON_INCLUDED_PATHS,
Keigo Oka9732e382019-06-28 17:44:59 +0900527 excluded + COMMON_EXCLUDED_PATHS + LONG_LINE_OK_PATHS)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700528
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900529 errors = []
Ryan Cuiec4d6332011-05-02 14:15:25 -0700530 for afile in files:
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700531 skip_regexps = (
532 r'https?://',
533 r'^#\s*(define|include|import|pragma|if|ifndef|endif)\b',
534 )
535
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900536 max_len = MAX_LEN
537
538 for expr, length in DEFAULT_MAX_LENGTHS:
539 if re.search(expr, afile):
540 max_len = length
541 break
542
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700543 if os.path.basename(afile).startswith('OWNERS'):
544 # File paths can get long, and there's no way to break them up into
545 # multiple lines.
546 skip_regexps += (
547 r'^include\b',
548 r'file:',
549 )
550
551 skip_regexps = [re.compile(x) for x in skip_regexps]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700552 for line_num, line in _get_file_diff(afile, commit):
553 # Allow certain lines to exceed the maxlen rule.
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900554 if len(line) <= max_len or any(x.search(line) for x in skip_regexps):
Jon Salz98255932012-08-18 14:48:02 +0800555 continue
556
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900557 errors.append('%s, line %s, %s chars, over %s chars' %
558 (afile, line_num, len(line), max_len))
Jon Salz98255932012-08-18 14:48:02 +0800559 if len(errors) == 5: # Just show the first 5 errors.
560 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700561
562 if errors:
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900563 msg = 'Found lines longer than the limit (first 5 shown):'
Ryan Cui1562fb82011-05-09 11:01:31 -0700564 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400565 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700566
Ryan Cuiec4d6332011-05-02 14:15:25 -0700567
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900568def _check_no_stray_whitespace(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700569 """Checks that there is no stray whitespace at source lines end."""
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900570 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700571 files = _filter_files(_get_affected_files(commit),
Tomasz Figa375b9622020-09-22 14:25:07 +0000572 included + COMMON_INCLUDED_PATHS + [r'^.*\.md$'],
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900573 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800574 return _check_lines_in_diff(commit, files,
575 lambda line: line.rstrip() != line,
576 'Found line ending with white space in:')
Ryan Cui1562fb82011-05-09 11:01:31 -0700577
Ryan Cuiec4d6332011-05-02 14:15:25 -0700578
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900579def _check_no_tabs(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700580 """Checks there are no unexpanded tabs."""
Mike Frysingercd134512017-10-26 04:36:33 -0400581 # Don't add entire repos here. Update the PRESUBMIT.cfg in each repo instead.
582 # We only whitelist known specific filetypes here that show up in all repos.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700583 TAB_OK_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400584 r'.*\.ebuild$',
585 r'.*\.eclass$',
586 r'.*\.go$',
587 r'.*/[M|m]akefile$',
588 r'.*\.mk$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700589 ]
590
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900591 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700592 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900593 included + COMMON_INCLUDED_PATHS,
594 excluded + COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800595 return _check_lines_in_diff(commit, files,
596 lambda line: '\t' in line,
597 'Found a tab character in:')
Ryan Cuiec4d6332011-05-02 14:15:25 -0700598
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800599
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700600def _read_terms_file(terms_file):
601 """Read list of words from file, skipping comments and blank lines."""
602 file_terms = set()
603 for line in osutils.ReadFile(terms_file).splitlines():
604 # Allow comment and blank lines.
605 line = line.split('#', 1)[0]
606 if not line:
607 continue
608 file_terms.add(line)
609 return file_terms
610
611
Bernie Thompson8e26f742020-07-23 14:32:31 -0700612def _check_keywords(_project, commit, options=()):
613 """Checks there are no blocked keywords in commit content."""
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700614 # Read options from override list.
Bernie Thompson8e26f742020-07-23 14:32:31 -0700615 parser = argparse.ArgumentParser()
616 parser.add_argument('--exclude_regex', action='append', default=[])
617 parser.add_argument('--include_regex', action='append', default=[])
618 parser.add_argument('--block', action='append', default=[])
619 parser.add_argument('--unblock', action='append', default=[])
620 opts = parser.parse_args(options)
621
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700622 # Read blocked word list.
623 blocked_terms_file = os.path.join(_get_hooks_dir(), BLOCKED_TERMS_FILE)
624 common_keywords = _read_terms_file(blocked_terms_file)
625
626 # Read unblocked word list. Global list is skipped if local list exists.
627 unblocked_terms_file = os.path.join(_get_hooks_dir(), UNBLOCKED_TERMS_FILE)
628 if os.path.isfile(os.path.join(_project.dir, UNBLOCKED_TERMS_FILE)):
629 unblocked_terms_file = os.path.join(_project.dir, UNBLOCKED_TERMS_FILE)
630 unblocked_words = _read_terms_file(unblocked_terms_file)
631 unblocked_words.update(opts.unblock)
632
Bernie Thompson8e26f742020-07-23 14:32:31 -0700633 keywords = set(common_keywords | set(opts.block))
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700634 keywords = sorted(keywords - unblocked_words)
Mike Frysinger6140f572020-09-10 04:52:46 -0400635 files = _filter_files(
636 _get_affected_files(commit),
Tomasz Figa375b9622020-09-22 14:25:07 +0000637 opts.include_regex + COMMON_INCLUDED_PATHS + [r'^.*\.md$'],
Mike Frysinger6140f572020-09-10 04:52:46 -0400638 opts.exclude_regex + COMMON_EXCLUDED_PATHS)
Bernie Thompson8e26f742020-07-23 14:32:31 -0700639 errors = []
640
641 def _check_line(line):
642 for word in keywords:
643 m = re.search(word, line, flags=re.I)
644 if m:
Bernie Thompson4e362922020-09-02 16:17:50 -0700645 matched = True
646 # The unblock values supercede blocked values, so if any unblock
647 # regex matches a term found by the block list, we ignore it.
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700648 for unblocked in unblocked_words:
Bernie Thompson4e362922020-09-02 16:17:50 -0700649 if re.search(unblocked, m.group(0)):
650 matched = False
651 break
652 if matched:
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700653 return f'Matched "{m[0]}" with regex of "{word}"'
Bernie Thompson8e26f742020-07-23 14:32:31 -0700654 return False
655
656 diff_errors = _check_lines_in_diff(commit, files, _check_line,
657 'Found a blocked keyword in:')
658 if diff_errors:
659 errors.append(diff_errors)
660
661 line_num = 1
662 commit_desc_errors = []
663 for line in _get_commit_desc(commit).splitlines():
664 result = _check_line(line)
665 if result:
666 commit_desc_errors.append('Commit message, line %s: %s' %
667 (line_num, result))
668 line_num += 1
669 if commit_desc_errors:
670 errors.append(HookFailure('Found a blocked keyword in:',
671 commit_desc_errors))
672 return errors
673
674
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900675def _check_tabbed_indents(_project, commit, options=()):
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800676 """Checks that indents use tabs only."""
677 TABS_REQUIRED_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400678 r'.*\.ebuild$',
679 r'.*\.eclass$',
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800680 ]
681 LEADING_SPACE_RE = re.compile('[\t]* ')
682
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900683 included, excluded = _parse_common_inclusion_options(options)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800684 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900685 included + TABS_REQUIRED_PATHS,
686 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800687 return _check_lines_in_diff(
688 commit, files,
689 lambda line: LEADING_SPACE_RE.match(line) is not None,
690 'Found a space in indentation (must be all tabs):')
Ryan Cui1562fb82011-05-09 11:01:31 -0700691
Ryan Cuiec4d6332011-05-02 14:15:25 -0700692
LaMont Jones872fe762020-02-10 15:36:14 -0700693def _check_gofmt(_project, commit, options=()):
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700694 """Checks that Go files are formatted with gofmt."""
LaMont Jones872fe762020-02-10 15:36:14 -0700695 included, excluded = _parse_common_inclusion_options(options)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700696 errors = []
697 files = _filter_files(_get_affected_files(commit, relative=True),
LaMont Jones872fe762020-02-10 15:36:14 -0700698 included + [r'\.go$'],
699 excluded)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700700
701 for gofile in files:
702 contents = _get_file_content(gofile, commit)
Mike Frysingeraa7dc942019-09-25 00:07:24 -0400703 output = _run_command(cmd=['gofmt', '-l'], input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500704 stderr=subprocess.STDOUT)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700705 if output:
706 errors.append(gofile)
707 if errors:
708 return HookFailure('Files not formatted with gofmt:', errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400709 return None
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700710
711
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600712def _check_rustfmt(_project, commit):
713 """Checks that Rust files are formatted with rustfmt."""
714 errors = []
715 files = _filter_files(_get_affected_files(commit, relative=True),
716 [r'\.rs$'])
717
718 for rustfile in files:
719 contents = _get_file_content(rustfile, commit)
Chirantan Ekbote1da56d52020-07-13 17:35:35 +0900720 output = _run_command(cmd=['rustfmt', '--edition', '2018'],
721 input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500722 stderr=subprocess.STDOUT)
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600723 if output != contents:
724 errors.append(rustfile)
725 if errors:
726 return HookFailure('Files not formatted with rustfmt: '
727 "(run 'cargo fmt' to fix)", errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400728 return None
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600729
730
Keiichi Watanabe6ab73fd2020-07-14 23:42:02 +0900731class CargoClippyArgumentParserError(Exception):
732 """An exception indicating an invalid check_cargo_clippy option."""
733
734
735class CargoClippyArgumentParser(argparse.ArgumentParser):
736 """A argument parser for check_cargo_clippy."""
737
738 def error(self, message):
739 raise CargoClippyArgumentParserError(message)
740
741
742# A cargo project in which clippy runs.
743ClippyProject = collections.namedtuple('ClippyProject', ('root', 'script'))
744
745
746class _AddClippyProjectAction(argparse.Action):
747 """A callback that adds a cargo clippy setting.
748
749 It accepts a value which is in the form of "ROOT[:SCRIPT]".
750 """
751
752 def __call__(self, parser, namespace, values, option_string=None):
753 if getattr(namespace, self.dest, None) is None:
754 setattr(namespace, self.dest, [])
755 spec = values.split(':', 1)
756 if len(spec) == 1:
757 spec += [None]
758
759 if spec[0].startswith('/'):
760 raise CargoClippyArgumentParserError('root path must not start with "/"'
761 f' but "{spec[0]}"')
762
763 clippy = ClippyProject(root=spec[0], script=spec[1])
764 getattr(namespace, self.dest).append(clippy)
765
766
767def _get_cargo_clippy_parser():
768 """Creates a parser for check_cargo_clippy options."""
769
770 parser = CargoClippyArgumentParser()
771 parser.add_argument('--project', action=_AddClippyProjectAction, default=[])
772
773 return parser
774
775
776def _check_cargo_clippy(project, commit, options=()):
777 """Checks that a change doesn't produce cargo-clippy errors."""
778
779 options = list(options)
780 if not options:
781 return []
782 parser = _get_cargo_clippy_parser()
783
784 try:
785 opts = parser.parse_args(options)
786 except CargoClippyArgumentParserError as e:
787 return [HookFailure('invalid check_cargo_clippy option is given.'
788 f' Please check PRESUBMIT.cfg is correct: {e}')]
789 files = _get_affected_files(commit)
790
791 errors = []
792 for clippy in opts.project:
793 root = os.path.normpath(os.path.join(project.dir, clippy.root))
794
795 # Check if any file under `root` was modified.
796 modified = False
797 for f in files:
798 if f.startswith(root):
799 modified = True
800 break
801 if not modified:
802 continue
803
804 # Clean cargo's cache when we run clippy for this `root` for the first time.
805 # We don't want to clean the cache between commits to save time when
806 # multiple commits are checked.
807 if root not in _check_cargo_clippy.cleaned_root:
808 _run_command(['cargo', 'clean',
809 f'--manifest-path={root}/Cargo.toml'],
810 stderr=subprocess.STDOUT)
811 _check_cargo_clippy.cleaned_root.add(root)
812
813 cmd = ['cargo', 'clippy', '--all-features', '--all-targets',
814 f'--manifest-path={root}/Cargo.toml',
815 '--', '-D', 'warnings']
816 # Overwrite the clippy command if a project-specific script is specified.
817 if clippy.script:
818 cmd = [os.path.join(project.dir, clippy.script)]
819
820 output = _run_command(cmd, stderr=subprocess.STDOUT)
821 error = re.search(r'^error: ', output, flags=re.MULTILINE)
822 if error:
823 msg = output[error.start():]
824 errors.append(HookFailure(msg))
825
826 return errors
827
828
829# Stores cargo projects in which `cargo clean` ran.
830_check_cargo_clippy.cleaned_root = set()
831
832
Mike Frysingerae409522014-02-01 03:16:11 -0500833def _check_change_has_test_field(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700834 """Check for a non-empty 'TEST=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500835 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700836
Cheng Yuehb707c522020-01-02 14:06:59 +0800837 if not re.search(TEST_FIELD_RE, _get_commit_desc(commit)):
Mike Frysingered9b2a02019-12-12 18:52:32 -0500838 msg = ('Changelist description needs TEST field (after first line)\n%s' %
839 (SEE_ALSO,))
Ryan Cui1562fb82011-05-09 11:01:31 -0700840 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400841 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700842
Ryan Cuiec4d6332011-05-02 14:15:25 -0700843
Mike Frysingerae409522014-02-01 03:16:11 -0500844def _check_change_has_valid_cq_depend(_project, commit):
Jason D. Clinton299e3222019-05-23 09:42:03 -0600845 """Check for a correctly formatted Cq-Depend field in the commit message."""
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700846 desc = _get_commit_desc(commit)
Jason D. Clinton299e3222019-05-23 09:42:03 -0600847 msg = 'Changelist has invalid Cq-Depend target.'
848 example = 'Example: Cq-Depend: chromium:1234, chrome-internal:2345'
David Jamesc3b68b32013-04-03 09:17:03 -0700849 try:
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700850 patch.GetPaladinDeps(desc)
David Jamesc3b68b32013-04-03 09:17:03 -0700851 except ValueError as ex:
852 return HookFailure(msg, [example, str(ex)])
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700853 # Check that Cq-Depend is in the same paragraph as Change-Id.
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500854 msg = 'Cq-Depend is not in the same paragraph as Change-Id.'
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700855 paragraphs = desc.split('\n\n')
856 for paragraph in paragraphs:
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500857 if (re.search(r'^Cq-Depend:', paragraph, re.M) and not
858 re.search('^Change-Id:', paragraph, re.M)):
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700859 return HookFailure(msg)
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500860
861 # We no longer support CQ-DEPEND= lines.
862 if re.search(r'^CQ-DEPEND[=:]', desc, re.M):
863 return HookFailure(
864 'CQ-DEPEND= is no longer supported. Please see:\n'
865 'https://chromium.googlesource.com/chromiumos/docs/+/HEAD/'
866 'contributing.md#CQ-DEPEND')
867
Mike Frysinger8cf80812019-09-16 23:49:29 -0400868 return None
David Jamesc3b68b32013-04-03 09:17:03 -0700869
870
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800871def _check_change_is_contribution(_project, commit):
872 """Check that the change is a contribution."""
873 NO_CONTRIB = 'not a contribution'
874 if NO_CONTRIB in _get_commit_desc(commit).lower():
875 msg = ('Changelist is not a contribution, this cannot be accepted.\n'
876 'Please remove the "%s" text from the commit message.') % NO_CONTRIB
877 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400878 return None
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800879
880
Alex Deymo643ac4c2015-09-03 10:40:50 -0700881def _check_change_has_bug_field(project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700882 """Check for a correctly formatted 'BUG=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500883 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
884
David James5c0073d2013-04-03 08:48:52 -0700885 OLD_BUG_RE = r'\nBUG=.*chromium-os'
886 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
887 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
888 'the chromium tracker in your BUG= line now.')
889 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700890
Alex Deymo643ac4c2015-09-03 10:40:50 -0700891 # Android internal and external projects use "Bug: " to track bugs in
892 # buganizer.
893 BUG_COLON_REMOTES = (
894 'aosp',
895 'goog',
896 )
897 if project.remote in BUG_COLON_REMOTES:
898 BUG_RE = r'\nBug: ?([Nn]one|\d+)'
899 if not re.search(BUG_RE, _get_commit_desc(commit)):
900 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500901 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700902 'Bug: 9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500903 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700904 return HookFailure(msg)
905 else:
Jorge Lucangeli Obesdce214e2017-10-25 15:04:39 -0400906 BUG_RE = r'\nBUG=([Nn]one|(chromium|b):\d+)'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700907 if not re.search(BUG_RE, _get_commit_desc(commit)):
908 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500909 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700910 'BUG=chromium:9999 (for public tracker)\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700911 'BUG=b:9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500912 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700913 return HookFailure(msg)
Ryan Cui1562fb82011-05-09 11:01:31 -0700914
Cheng Yuehb707c522020-01-02 14:06:59 +0800915 TEST_BEFORE_BUG_RE = TEST_FIELD_RE + r'.*' + BUG_RE
916
917 if re.search(TEST_BEFORE_BUG_RE, _get_commit_desc(commit), re.DOTALL):
918 msg = ('The BUG field must come before the TEST field.\n%s' %
919 (SEE_ALSO,))
920 return HookFailure(msg)
921
Mike Frysinger8cf80812019-09-16 23:49:29 -0400922 return None
923
Ryan Cuiec4d6332011-05-02 14:15:25 -0700924
Jack Neus8edbf642019-07-10 16:08:31 -0600925def _check_change_no_include_oem(project, commit):
926 """Check that the change does not reference OEMs."""
927 ALLOWLIST = {
928 'chromiumos/platform/ec',
929 # Used by unit tests.
930 'project',
931 }
932 if project.name not in ALLOWLIST:
933 return None
934
Mike Frysingerbb34a222019-07-31 14:40:46 -0400935 TAGS = {
Jack Neus8edbf642019-07-10 16:08:31 -0600936 'Reviewed-on',
937 'Reviewed-by',
938 'Signed-off-by',
939 'Commit-Ready',
940 'Tested-by',
941 'Commit-Queue',
Jack Neus8edbf642019-07-10 16:08:31 -0600942 'Acked-by',
943 'Modified-by',
944 'CC',
945 'Suggested-by',
946 'Reported-by',
947 'Acked-for-chrome-by',
LaMont Jones237f3ef2020-01-22 10:40:52 -0700948 'Cq-Cl-Tag',
LaMont Jonesfb5e8bf2020-03-03 12:50:06 -0700949 'Cq-Include-Trybots',
Mike Frysingerbb34a222019-07-31 14:40:46 -0400950 }
Jack Neus8edbf642019-07-10 16:08:31 -0600951
952 # Ignore tags, which could reasonably contain OEM names
953 # (e.g. Reviewed-by: foo@oem.corp-partner.google.com).
Jack Neus8edbf642019-07-10 16:08:31 -0600954 commit_message = ' '.join(
Mike Frysingerbb34a222019-07-31 14:40:46 -0400955 x for x in _get_commit_desc(commit).splitlines()
956 if ':' not in x or x.split(':', 1)[0] not in TAGS)
957
Jack Neus8edbf642019-07-10 16:08:31 -0600958 commit_message = re.sub(r'[\s_-]+', ' ', commit_message)
959
960 # Exercise caution when expanding these lists. Adding a name
961 # could indicate a new relationship with a company!
962 OEMS = ['hp', 'hewlett packard', 'dell', 'lenovo', 'acer', 'asus', 'samsung']
963 ODMS = [
964 'bitland', 'compal', 'haier', 'huaqin', 'inventec', 'lg', 'pegatron',
965 'pegatron(ems)', 'quanta', 'samsung', 'wistron'
966 ]
967
968 for name_type, name_list in [('OEM', OEMS), ('ODM', ODMS)]:
969 # Construct regex
970 name_re = r'\b(%s)\b' % '|'.join([re.escape(x) for x in name_list])
971 matches = [x[0] for x in re.findall(name_re, commit_message, re.IGNORECASE)]
Mike Frysingere52b1bc2019-09-16 23:45:41 -0400972 if matches:
Jack Neus8edbf642019-07-10 16:08:31 -0600973 # If there's a match, throw an error.
974 error_msg = ('Changelist description contains the name of an'
975 ' %s: "%s".' % (name_type, '","'.join(matches)))
976 return HookFailure(error_msg)
977
Mike Frysinger8cf80812019-09-16 23:49:29 -0400978 return None
979
Jack Neus8edbf642019-07-10 16:08:31 -0600980
Mike Frysinger292b45d2014-11-25 01:17:10 -0500981def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -0700982 """Check that we're not missing a revbump of an ebuild in the given commit.
983
984 If the given commit touches files in a directory that has ebuilds somewhere
985 up the directory hierarchy, it's very likely that we need an ebuild revbump
986 in order for those changes to take effect.
987
988 It's not totally trivial to detect a revbump, so at least detect that an
989 ebuild with a revision number in it was touched. This should handle the
990 common case where we use a symlink to do the revbump.
991
992 TODO: it would be nice to enhance this hook to:
993 * Handle cases where people revbump with a slightly different syntax. I see
994 one ebuild (puppy) that revbumps with _pN. This is a false positive.
995 * Catches cases where people aren't using symlinks for revbumps. If they
996 edit a revisioned file directly (and are expected to rename it for revbump)
997 we'll miss that. Perhaps we could detect that the file touched is a
998 symlink?
999
1000 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
1001 still better off than without this check.
1002
1003 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001004 project: The Project to look at
Doug Anderson42b8a052013-06-26 10:45:36 -07001005 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -05001006 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -07001007
1008 Returns:
1009 A HookFailure or None.
1010 """
Mike Frysinger011af942014-01-17 16:12:22 -05001011 # If this is the portage-stable overlay, then ignore the check. It's rare
1012 # that we're doing anything other than importing files from upstream, so
1013 # forcing a rev bump makes no sense.
1014 whitelist = (
1015 'chromiumos/overlays/portage-stable',
1016 )
Alex Deymo643ac4c2015-09-03 10:40:50 -07001017 if project.name in whitelist:
Mike Frysinger011af942014-01-17 16:12:22 -05001018 return None
1019
Mike Frysinger292b45d2014-11-25 01:17:10 -05001020 def FinalName(obj):
1021 # If the file is being deleted, then the dst_file is not set.
1022 if obj.dst_file is None:
1023 return obj.src_file
1024 else:
1025 return obj.dst_file
1026
1027 affected_path_objs = _get_affected_files(
1028 commit, include_deletes=True, include_symlinks=True, relative=True,
1029 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -07001030
1031 # Don't yell about changes to whitelisted files...
Mike Frysinger550c05c2019-12-09 18:16:36 -05001032 whitelist = {'ChangeLog', 'Manifest', 'metadata.xml'}
Mike Frysinger292b45d2014-11-25 01:17:10 -05001033 affected_path_objs = [x for x in affected_path_objs
1034 if os.path.basename(FinalName(x)) not in whitelist]
1035 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -07001036 return None
1037
1038 # If we've touched any file named with a -rN.ebuild then we'll say we're
1039 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -05001040 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
1041 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -07001042 if touched_revved_ebuild:
1043 return None
1044
Mike Frysinger292b45d2014-11-25 01:17:10 -05001045 # If we're creating new ebuilds from scratch, then we don't need an uprev.
1046 # Find all the dirs that new ebuilds and ignore their files/.
1047 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
1048 if FinalName(x).endswith('.ebuild') and x.status == 'A']
1049 affected_path_objs = [obj for obj in affected_path_objs
1050 if not any(FinalName(obj).startswith(x)
1051 for x in ebuild_dirs)]
1052 if not affected_path_objs:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001053 return None
Mike Frysinger292b45d2014-11-25 01:17:10 -05001054
Doug Anderson42b8a052013-06-26 10:45:36 -07001055 # We want to examine the current contents of all directories that are parents
1056 # of files that were touched (up to the top of the project).
1057 #
1058 # ...note: we use the current directory contents even though it may have
1059 # changed since the commit we're looking at. This is just a heuristic after
1060 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -05001061 if project_top is None:
1062 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -07001063 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -05001064 for obj in affected_path_objs:
1065 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -07001066 while os.path.exists(path) and not os.path.samefile(path, project_top):
1067 dirs_to_check.add(path)
1068 path = os.path.dirname(path)
1069
1070 # Look through each directory. If it's got an ebuild in it then we'll
1071 # consider this as a case when we need a revbump.
Gwendal Grignoua3086c32014-12-09 11:17:22 -08001072 affected_paths = set(os.path.join(project_top, FinalName(x))
1073 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -07001074 for dir_path in dirs_to_check:
1075 contents = os.listdir(dir_path)
1076 ebuilds = [os.path.join(dir_path, path)
1077 for path in contents if path.endswith('.ebuild')]
1078 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
1079
C Shapiroae157ae2017-09-18 16:24:03 -06001080 affected_paths_under_9999_ebuilds = set()
1081 for affected_path in affected_paths:
1082 for ebuild_9999 in ebuilds_9999:
1083 ebuild_dir = os.path.dirname(ebuild_9999)
1084 if affected_path.startswith(ebuild_dir):
1085 affected_paths_under_9999_ebuilds.add(affected_path)
1086
1087 # If every file changed exists under a 9999 ebuild, then skip
1088 if len(affected_paths_under_9999_ebuilds) == len(affected_paths):
1089 continue
1090
Doug Anderson42b8a052013-06-26 10:45:36 -07001091 # If the -9999.ebuild file was touched the bot will uprev for us.
1092 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -05001093 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -07001094 continue
1095
1096 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -05001097 return HookFailure('Changelist probably needs a revbump of an ebuild, '
1098 'or a -r1.ebuild symlink if this is a new ebuild:\n'
1099 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -07001100
1101 return None
1102
1103
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001104def _check_ebuild_eapi(project, commit):
Mike Frysinger948284a2018-02-01 15:22:56 -05001105 """Make sure we have people use EAPI=5 or newer with custom ebuilds.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001106
1107 We want to get away from older EAPI's as it makes life confusing and they
1108 have less builtin error checking.
1109
1110 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001111 project: The Project to look at
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001112 commit: The commit to look at
1113
1114 Returns:
1115 A HookFailure or None.
1116 """
1117 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -05001118 # that we're doing anything other than importing files from upstream, and
1119 # we shouldn't be rewriting things fundamentally anyways.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001120 whitelist = (
1121 'chromiumos/overlays/portage-stable',
1122 )
Alex Deymo643ac4c2015-09-03 10:40:50 -07001123 if project.name in whitelist:
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001124 return None
1125
Mike Frysinger948284a2018-02-01 15:22:56 -05001126 BAD_EAPIS = ('0', '1', '2', '3', '4')
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001127
1128 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
1129
1130 ebuilds_re = [r'\.ebuild$']
1131 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1132 ebuilds_re)
1133 bad_ebuilds = []
1134
1135 for ebuild in ebuilds:
1136 # If the ebuild does not specify an EAPI, it defaults to 0.
1137 eapi = '0'
1138
1139 lines = _get_file_content(ebuild, commit).splitlines()
1140 if len(lines) == 1:
1141 # This is most likely a symlink, so skip it entirely.
1142 continue
1143
1144 for line in lines:
1145 m = get_eapi.match(line)
1146 if m:
1147 # Once we hit the first EAPI line in this ebuild, stop processing.
1148 # The spec requires that there only be one and it be first, so
1149 # checking all possible values is pointless. We also assume that
1150 # it's "the" EAPI line and not something in the middle of a heredoc.
1151 eapi = m.group(1)
1152 break
1153
1154 if eapi in BAD_EAPIS:
1155 bad_ebuilds.append((ebuild, eapi))
1156
1157 if bad_ebuilds:
1158 # pylint: disable=C0301
Mike Frysingerc6114f42020-05-15 00:55:05 -04001159 url = 'https://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001160 # pylint: enable=C0301
1161 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -05001162 'These ebuilds are using old EAPIs. If these are imported from\n'
1163 'Gentoo, then you may ignore and upload once with the --no-verify\n'
Mike Frysingerc6114f42020-05-15 00:55:05 -04001164 'flag. Otherwise, please update to 7 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001165 '\t%s\n'
1166 'See this guide for more details:\n%s\n' %
1167 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
1168
Mike Frysinger8cf80812019-09-16 23:49:29 -04001169 return None
1170
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001171
Mike Frysinger89bdb852014-02-01 05:26:26 -05001172def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -05001173 """Make sure we use the new style KEYWORDS when possible in ebuilds.
1174
1175 If an ebuild generally does not care about the arch it is running on, then
1176 ebuilds should flag it with one of:
1177 KEYWORDS="*" # A stable ebuild.
1178 KEYWORDS="~*" # An unstable ebuild.
1179 KEYWORDS="-* ..." # Is known to only work on specific arches.
1180
1181 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001182 project: The Project to look at
Mike Frysingerc51ece72014-01-17 16:23:40 -05001183 commit: The commit to look at
1184
1185 Returns:
1186 A HookFailure or None.
1187 """
1188 WHITELIST = set(('*', '-*', '~*'))
1189
1190 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
1191
Mike Frysinger89bdb852014-02-01 05:26:26 -05001192 ebuilds_re = [r'\.ebuild$']
1193 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1194 ebuilds_re)
1195
Mike Frysinger8d42d742014-09-22 15:50:21 -04001196 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -05001197 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -04001198 # We get the full content rather than a diff as the latter does not work
1199 # on new files (like when adding new ebuilds).
1200 lines = _get_file_content(ebuild, commit).splitlines()
1201 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -05001202 m = get_keywords.match(line)
1203 if m:
1204 keywords = set(m.group(1).split())
1205 if not keywords or WHITELIST - keywords != WHITELIST:
1206 continue
1207
Mike Frysinger8d42d742014-09-22 15:50:21 -04001208 bad_ebuilds.append(ebuild)
1209
1210 if bad_ebuilds:
1211 return HookFailure(
1212 '%s\n'
1213 'Please update KEYWORDS to use a glob:\n'
1214 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
1215 ' KEYWORDS="*"\n'
1216 'If the ebuild should be marked unstable (normal for '
1217 'cros-workon / 9999 ebuilds):\n'
1218 ' KEYWORDS="~*"\n'
Mike Frysingerde8efea2015-05-17 03:42:26 -04001219 'If the ebuild needs to be marked for only specific arches, '
Mike Frysinger8d42d742014-09-22 15:50:21 -04001220 'then use -* like so:\n'
1221 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -05001222
Mike Frysinger8cf80812019-09-16 23:49:29 -04001223 return None
1224
Mike Frysingerc51ece72014-01-17 16:23:40 -05001225
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001226def _check_ebuild_licenses(_project, commit):
1227 """Check if the LICENSE field in the ebuild is correct."""
Brian Norris7a610e82016-02-17 12:24:54 -08001228 affected_paths = _get_affected_files(commit, relative=True)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001229 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
1230
1231 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -08001232 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001233
1234 for ebuild in touched_ebuilds:
1235 # Skip virutal packages.
1236 if ebuild.split('/')[-3] == 'virtual':
1237 continue
1238
Alex Kleinb5953522018-08-03 11:44:21 -06001239 # e.g. path/to/overlay/category/package/package.ebuild -> path/to/overlay
1240 overlay_path = os.sep.join(ebuild.split(os.sep)[:-3])
1241
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001242 try:
Brian Norris7a610e82016-02-17 12:24:54 -08001243 ebuild_content = _get_file_content(ebuild, commit)
Alex Kleinb5953522018-08-03 11:44:21 -06001244 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content,
1245 overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001246 except ValueError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001247 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001248
1249 # Also ignore licenses ending with '?'
1250 for license_type in [x for x in license_types
1251 if x not in LICENSES_IGNORE and not x.endswith('?')]:
1252 try:
Alex Kleinb5953522018-08-03 11:44:21 -06001253 licenses_lib.Licensing.FindLicenseType(license_type,
1254 overlay_path=overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001255 except AssertionError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001256 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001257
Mike Frysinger8cf80812019-09-16 23:49:29 -04001258 return None
1259
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001260
Mike Frysingercd363c82014-02-01 05:20:18 -05001261def _check_ebuild_virtual_pv(project, commit):
1262 """Enforce the virtual PV policies."""
1263 # If this is the portage-stable overlay, then ignore the check.
1264 # We want to import virtuals as-is from upstream Gentoo.
1265 whitelist = (
1266 'chromiumos/overlays/portage-stable',
1267 )
Alex Deymo643ac4c2015-09-03 10:40:50 -07001268 if project.name in whitelist:
Mike Frysingercd363c82014-02-01 05:20:18 -05001269 return None
1270
1271 # We assume the repo name is the same as the dir name on disk.
1272 # It would be dumb to not have them match though.
Alex Deymo643ac4c2015-09-03 10:40:50 -07001273 project_base = os.path.basename(project.name)
Mike Frysingercd363c82014-02-01 05:20:18 -05001274
1275 is_variant = lambda x: x.startswith('overlay-variant-')
1276 is_board = lambda x: x.startswith('overlay-')
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001277 is_baseboard = lambda x: x.startswith('baseboard-')
1278 is_chipset = lambda x: x.startswith('chipset-')
1279 is_project = lambda x: x.startswith('project-')
Mike Frysingercd363c82014-02-01 05:20:18 -05001280 is_private = lambda x: x.endswith('-private')
1281
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001282 is_special_overlay = lambda x: (is_board(x) or is_chipset(x) or
1283 is_baseboard(x) or is_project(x))
1284
Mike Frysingercd363c82014-02-01 05:20:18 -05001285 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
1286
1287 ebuilds_re = [r'\.ebuild$']
1288 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1289 ebuilds_re)
1290 bad_ebuilds = []
1291
1292 for ebuild in ebuilds:
1293 m = get_pv.match(ebuild)
1294 if m:
1295 overlay = m.group(1)
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001296 if not overlay or not is_special_overlay(overlay):
Alex Deymo643ac4c2015-09-03 10:40:50 -07001297 overlay = project_base
Mike Frysingercd363c82014-02-01 05:20:18 -05001298
1299 pv = m.group(3).split('-', 1)[0]
1300
Bernie Thompsone5ee1822016-01-12 14:22:23 -08001301 # Virtual versions >= 4 are special cases used above the standard
1302 # versioning structure, e.g. if one has a board inheriting a board.
Julius Werner0299a2b2020-07-31 18:20:43 -07001303 if pv[0] >= '4':
Bernie Thompsone5ee1822016-01-12 14:22:23 -08001304 want_pv = pv
Mike Frysingercd363c82014-02-01 05:20:18 -05001305 elif is_board(overlay):
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001306 if is_private(overlay):
1307 want_pv = '3.5' if is_variant(overlay) else '3'
1308 elif is_board(overlay):
1309 want_pv = '2.5' if is_variant(overlay) else '2'
1310 elif is_baseboard(overlay):
Julius Werner0299a2b2020-07-31 18:20:43 -07001311 want_pv = '1.9.5' if is_private(overlay) else '1.9'
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001312 elif is_chipset(overlay):
Julius Werner0299a2b2020-07-31 18:20:43 -07001313 want_pv = '1.8.5' if is_private(overlay) else '1.8'
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001314 elif is_project(overlay):
1315 want_pv = '1.7' if is_private(overlay) else '1.5'
Mike Frysingercd363c82014-02-01 05:20:18 -05001316 else:
1317 want_pv = '1'
1318
1319 if pv != want_pv:
1320 bad_ebuilds.append((ebuild, pv, want_pv))
1321
1322 if bad_ebuilds:
1323 # pylint: disable=C0301
1324 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
1325 # pylint: enable=C0301
1326 return HookFailure(
1327 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
1328 '\t%s\n'
1329 'If this is an upstream Gentoo virtual, then you may ignore this\n'
1330 'check (and re-run w/--no-verify). Otherwise, please see this\n'
1331 'page for more details:\n%s\n' %
1332 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
1333 for x in bad_ebuilds]), url))
1334
Mike Frysinger8cf80812019-09-16 23:49:29 -04001335 return None
1336
Mike Frysingercd363c82014-02-01 05:20:18 -05001337
Daniel Erat9d203ff2015-02-17 10:12:21 -07001338def _check_portage_make_use_var(_project, commit):
1339 """Verify that $USE is set correctly in make.conf and make.defaults."""
1340 files = _filter_files(_get_affected_files(commit, relative=True),
1341 [r'(^|/)make.(conf|defaults)$'])
1342
1343 errors = []
1344 for path in files:
1345 basename = os.path.basename(path)
1346
1347 # Has a USE= line already been encountered in this file?
1348 saw_use = False
1349
1350 for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1):
1351 if not line.startswith('USE='):
1352 continue
1353
1354 preserves_use = '${USE}' in line or '$USE' in line
1355
1356 if (basename == 'make.conf' or
1357 (basename == 'make.defaults' and saw_use)) and not preserves_use:
1358 errors.append('%s:%d: missing ${USE}' % (path, i))
1359 elif basename == 'make.defaults' and not saw_use and preserves_use:
1360 errors.append('%s:%d: ${USE} referenced in initial declaration' %
1361 (path, i))
1362
1363 saw_use = True
1364
1365 if errors:
1366 return HookFailure(
1367 'One or more Portage make files appear to set USE incorrectly.\n'
1368 '\n'
1369 'All USE assignments in make.conf and all assignments after the\n'
1370 'initial declaration in make.defaults should contain "${USE}" to\n'
1371 'preserve previously-set flags.\n'
1372 '\n'
1373 'The initial USE declaration in make.defaults should not contain\n'
1374 '"${USE}".\n',
1375 errors)
1376
Mike Frysinger8cf80812019-09-16 23:49:29 -04001377 return None
1378
Daniel Erat9d203ff2015-02-17 10:12:21 -07001379
Mike Frysingerae409522014-02-01 03:16:11 -05001380def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001381 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001382 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001383 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001384 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001385 if not m:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001386 return HookFailure('Last paragraph of description must include Change-Id.')
Ryan Cui1562fb82011-05-09 11:01:31 -07001387
LaMont Jonesfb5e8bf2020-03-03 12:50:06 -07001388 # S-o-b and some other tags always allowed to follow Change-ID in the footer.
1389 allowed_tags = ['Signed-off-by', 'Cq-Cl-Tag', 'Cq-Include-Trybots']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001390
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001391 end = desc[m.end():].strip().splitlines()
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001392 cherry_pick_marker = 'cherry picked from commit'
1393
1394 if end and cherry_pick_marker in end[-1]:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001395 # Cherry picked patches allow more tags in the last paragraph.
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001396 allowed_tags += ['Commit-Queue', 'Commit-Ready', 'Reviewed-by',
1397 'Reviewed-on', 'Tested-by']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001398 end = end[:-1]
1399
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001400 # Note that descriptions could have multiple cherry pick markers.
1401 tag_search = r'^(%s:|\(%s) ' % (':|'.join(allowed_tags), cherry_pick_marker)
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001402
1403 if [x for x in end if not re.search(tag_search, x)]:
1404 return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' %
1405 ':", "'.join(allowed_tags))
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001406
Mike Frysinger8cf80812019-09-16 23:49:29 -04001407 return None
1408
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001409
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001410def _check_commit_message_style(_project, commit):
1411 """Verify that the commit message matches our style.
1412
1413 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
1414 commit hooks.
1415 """
Mike Frysingered9b2a02019-12-12 18:52:32 -05001416 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Mike Frysinger4efdee72019-11-04 10:57:01 -05001417
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001418 desc = _get_commit_desc(commit)
1419
1420 # The first line should be by itself.
1421 lines = desc.splitlines()
1422 if len(lines) > 1 and lines[1]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001423 return HookFailure('The second line of the commit message must be blank.'
1424 '\n%s' % (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001425
1426 # The first line should be one sentence.
1427 if '. ' in lines[0]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001428 return HookFailure('The first line cannot be more than one sentence.\n%s' %
1429 (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001430
1431 # The first line cannot be too long.
1432 MAX_FIRST_LINE_LEN = 100
1433 if len(lines[0]) > MAX_FIRST_LINE_LEN:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001434 return HookFailure('The first line must be less than %i chars.\n%s' %
1435 (MAX_FIRST_LINE_LEN, SEE_ALSO))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001436
Mike Frysinger8cf80812019-09-16 23:49:29 -04001437 return None
1438
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001439
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001440def _check_cros_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001441 """Verifies the Chromium OS license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -07001442
Mike Frysinger98638102014-08-28 00:15:08 -04001443 Should be following the spec:
1444 http://dev.chromium.org/developers/coding-style#TOC-File-headers
1445 """
1446 # For older years, be a bit more flexible as our policy says leave them be.
1447 LICENSE_HEADER = (
Keigo Oka7e880ac2019-07-03 15:03:43 +09001448 r'.*Copyright(?: \(c\))? (20[0-9]{2})(?:-20[0-9]{2})? The Chromium OS '
1449 r'Authors\. All rights reserved\.\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001450 r'.*Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001451 r'be\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001452 r'.*found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -05001453 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001454 )
1455 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1456
1457 # For newer years, be stricter.
Keigo Oka7e880ac2019-07-03 15:03:43 +09001458 BAD_COPYRIGHT_LINE = (
Brian Norris68838dd2018-09-26 18:30:24 -07001459 r'.*Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001460 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001461 )
Keigo Oka7e880ac2019-07-03 15:03:43 +09001462 bad_copyright_re = re.compile(BAD_COPYRIGHT_LINE)
Mike Frysinger98638102014-08-28 00:15:08 -04001463
Shuhei Takahashiabc20f32017-07-10 19:35:45 +09001464 included, excluded = _parse_common_inclusion_options(options)
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001465
Mike Frysinger98638102014-08-28 00:15:08 -04001466 bad_files = []
1467 bad_copyright_files = []
Keigo Oka7e880ac2019-07-03 15:03:43 +09001468 bad_year_files = []
1469
Ken Turnerd07564b2018-02-08 17:57:59 +11001470 files = _filter_files(
1471 _get_affected_files(commit, relative=True),
1472 included + COMMON_INCLUDED_PATHS,
1473 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001474 existing_files = set(_get_affected_files(commit, relative=True,
1475 include_adds=False))
Mike Frysinger98638102014-08-28 00:15:08 -04001476
Keigo Oka7e880ac2019-07-03 15:03:43 +09001477 current_year = str(datetime.datetime.now().year)
Mike Frysinger98638102014-08-28 00:15:08 -04001478 for f in files:
1479 contents = _get_file_content(f, commit)
1480 if not contents:
1481 # Ignore empty files.
1482 continue
1483
Keigo Oka7e880ac2019-07-03 15:03:43 +09001484 m = license_re.search(contents)
1485 if not m:
Mike Frysinger98638102014-08-28 00:15:08 -04001486 bad_files.append(f)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001487 elif bad_copyright_re.search(contents):
Mike Frysinger98638102014-08-28 00:15:08 -04001488 bad_copyright_files.append(f)
1489
Keigo Oka7e880ac2019-07-03 15:03:43 +09001490 if m and f not in existing_files:
1491 year = m.group(1)
1492 if year != current_year:
1493 bad_year_files.append(f)
1494
1495 errors = []
Mike Frysinger98638102014-08-28 00:15:08 -04001496 if bad_files:
1497 msg = '%s:\n%s\n%s' % (
1498 'License must match', license_re.pattern,
1499 'Found a bad header in these files:')
Keigo Oka7e880ac2019-07-03 15:03:43 +09001500 errors.append(HookFailure(msg, bad_files))
Mike Frysinger98638102014-08-28 00:15:08 -04001501 if bad_copyright_files:
1502 msg = 'Do not use (c) in copyright headers in new files:'
Keigo Oka7e880ac2019-07-03 15:03:43 +09001503 errors.append(HookFailure(msg, bad_copyright_files))
1504 if bad_year_files:
1505 msg = 'Use current year (%s) in copyright headers in new files:' % (
1506 current_year)
1507 errors.append(HookFailure(msg, bad_year_files))
Ryan Cuiec4d6332011-05-02 14:15:25 -07001508
Keigo Oka7e880ac2019-07-03 15:03:43 +09001509 return errors
Ryan Cuiec4d6332011-05-02 14:15:25 -07001510
Mike Frysinger8cf80812019-09-16 23:49:29 -04001511
Amin Hassani391efa92018-01-26 17:58:05 -08001512def _check_aosp_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001513 """Verifies the AOSP license/copyright header.
1514
1515 AOSP uses the Apache2 License:
1516 https://source.android.com/source/licenses.html
1517 """
1518 LICENSE_HEADER = (
1519 r"""^[#/\*]*
1520[#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project
1521[#/\*]* ?
1522[#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\);
1523[#/\*]* ?you may not use this file except in compliance with the License\.
1524[#/\*]* ?You may obtain a copy of the License at
1525[#/\*]* ?
1526[#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0
1527[#/\*]* ?
1528[#/\*]* ?Unless required by applicable law or agreed to in writing, software
1529[#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS,
1530[#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """
1531 r"""implied\.
1532[#/\*]* ?See the License for the specific language governing permissions and
1533[#/\*]* ?limitations under the License\.
1534[#/\*]*$
1535"""
1536 )
1537 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1538
Amin Hassani391efa92018-01-26 17:58:05 -08001539 included, excluded = _parse_common_inclusion_options(options)
1540
Ken Turnerd07564b2018-02-08 17:57:59 +11001541 files = _filter_files(
1542 _get_affected_files(commit, relative=True),
1543 included + COMMON_INCLUDED_PATHS,
1544 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Alex Deymof5792ce2015-08-24 22:50:08 -07001545
1546 bad_files = []
1547 for f in files:
1548 contents = _get_file_content(f, commit)
1549 if not contents:
1550 # Ignore empty files.
1551 continue
1552
1553 if not license_re.search(contents):
1554 bad_files.append(f)
1555
1556 if bad_files:
1557 msg = ('License must match:\n%s\nFound a bad header in these files:' %
1558 license_re.pattern)
1559 return HookFailure(msg, bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001560 return None
Alex Deymof5792ce2015-08-24 22:50:08 -07001561
1562
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001563def _check_layout_conf(_project, commit):
1564 """Verifies the metadata/layout.conf file."""
1565 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001566 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001567 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001568 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001569
Mike Frysinger94a670c2014-09-19 12:46:26 -04001570 # Handle multiple overlays in a single commit (like the public tree).
1571 for f in _get_affected_files(commit, relative=True):
1572 if f.endswith(repo_name):
1573 repo_names.append(f)
1574 elif f.endswith(layout_path):
1575 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001576
1577 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -04001578 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001579 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -04001580 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001581
Mike Frysinger94a670c2014-09-19 12:46:26 -04001582 # Gather all the errors in one pass so we show one full message.
1583 all_errors = {}
1584 for layout_path in layout_paths:
1585 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001586
Mike Frysinger94a670c2014-09-19 12:46:26 -04001587 # Make sure the config file is sorted.
1588 data = [x for x in _get_file_content(layout_path, commit).splitlines()
1589 if x and x[0] != '#']
1590 if sorted(data) != data:
1591 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001592
Mike Frysinger94a670c2014-09-19 12:46:26 -04001593 # Require people to set specific values all the time.
1594 settings = (
1595 # TODO: Enable this for everyone. http://crbug.com/408038
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001596 # ('fast caching', 'cache-format = md5-dict'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001597 ('fast manifests', 'thin-manifests = true'),
Mike Frysingerd7734522015-02-26 16:12:43 -05001598 ('extra features', 'profile-formats = portage-2 profile-default-eapi'),
1599 ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001600 )
1601 for reason, line in settings:
1602 if line not in data:
1603 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001604
Mike Frysinger94a670c2014-09-19 12:46:26 -04001605 # Require one of these settings.
Mike Frysinger5fae62d2015-11-11 20:12:15 -05001606 if 'use-manifests = strict' not in data:
1607 errors += ['enable file checking with: use-manifests = strict']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001608
Mike Frysinger94a670c2014-09-19 12:46:26 -04001609 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -04001610 for line in data:
1611 if line.startswith('repo-name = '):
1612 break
1613 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -04001614 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001615
Mike Frysinger94a670c2014-09-19 12:46:26 -04001616 # Summarize all the errors we saw (if any).
1617 lines = ''
1618 for layout_path, errors in all_errors.items():
1619 if errors:
1620 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
1621 if lines:
1622 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
1623 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001624
Mike Frysinger8cf80812019-09-16 23:49:29 -04001625 return None
1626
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001627
Keigo Oka4a09bd92019-05-07 14:01:00 +09001628def _check_no_new_gyp(_project, commit):
1629 """Verifies no project starts to use GYP."""
Keigo Oka4a09bd92019-05-07 14:01:00 +09001630 gypfiles = _filter_files(
1631 _get_affected_files(commit, include_symlinks=True, relative=True),
1632 [r'\.gyp$'])
1633
1634 if gypfiles:
1635 return HookFailure('GYP is deprecated and not allowed in a new project:',
1636 gypfiles)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001637 return None
Keigo Oka4a09bd92019-05-07 14:01:00 +09001638
1639
Ryan Cuiec4d6332011-05-02 14:15:25 -07001640# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001641
Ryan Cui1562fb82011-05-09 11:01:31 -07001642
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001643def _check_clang_format(_project, commit, options=()):
1644 """Runs clang-format on the given project"""
1645 hooks_dir = _get_hooks_dir()
1646 options = list(options)
1647 if commit == PRE_SUBMIT:
1648 options.append('--commit=HEAD')
1649 else:
1650 options.extend(['--commit', commit])
Brian Norris0c62a142018-12-11 13:24:29 -08001651 cmd = [os.path.join(hooks_dir, 'clang-format.py')] + options
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001652 cmd_result = cros_build_lib.run(cmd,
1653 print_cmd=False,
1654 stdout=True,
1655 encoding='utf-8',
1656 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001657 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001658 check=False)
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001659 if cmd_result.returncode:
1660 return HookFailure('clang-format.py errors/warnings\n\n' +
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001661 cmd_result.stdout)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001662 return None
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001663
1664
Mike Frysingerae409522014-02-01 03:16:11 -05001665def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001666 """Runs checkpatch.pl on the given project"""
Tomasz Figabd8faf62020-09-22 14:06:05 +00001667 # Bypass checkpatch for upstream or almost upstream commits, since we do not
1668 # intend to modify the upstream commits when landing them to our branches.
1669 # Any fixes should sent as independent patches.
1670 # The check is retained for FROMLIST and BACKPORT commits, as by definition
1671 # those can be still fixed up.
1672 desc = _get_commit_desc(commit)
1673 if desc.startswith('UPSTREAM:') or desc.startswith('FROMGIT:'):
1674 return None
1675
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001676 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001677 options = list(options)
Brian Norris4cee0502020-06-12 17:02:56 -07001678 if options and options[0].startswith('./') and os.path.exists(options[0]):
1679 cmdpath = options.pop(0)
1680 else:
1681 cmdpath = os.path.join(hooks_dir, 'checkpatch.pl')
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001682 if commit == PRE_SUBMIT:
1683 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
1684 # this case.
1685 options.append('--ignore=MISSING_SIGN_OFF')
Filipe Brandenburger28d48d62015-10-07 09:48:54 -07001686 # Always ignore the check for the MAINTAINERS file. We do not track that
1687 # information on that file in our source trees, so let's suppress the
1688 # warning.
1689 options.append('--ignore=FILE_PATH_CHANGES')
Filipe Brandenburgerce978322015-10-09 10:04:15 -07001690 # Do not complain about the Change-Id: fields, since we use Gerrit.
1691 # Upstream does not want those lines (since they do not use Gerrit), but
1692 # we always do, so disable the check globally.
Daisuke Nojiri4844f892015-10-08 09:54:33 -07001693 options.append('--ignore=GERRIT_CHANGE_ID')
Brian Norris4cee0502020-06-12 17:02:56 -07001694 cmd = [cmdpath] + options + ['-']
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001695 cmd_result = cros_build_lib.run(
1696 cmd, print_cmd=False, input=_get_patch(commit).encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001697 stdout=True, stderr=subprocess.STDOUT, check=False, encoding='utf-8',
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001698 errors='replace')
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001699 if cmd_result.returncode:
Brian Norris4cee0502020-06-12 17:02:56 -07001700 return HookFailure('%s errors/warnings\n\n%s' %
1701 (cmdpath, cmd_result.stdout))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001702 return None
Ryan Cuiec4d6332011-05-02 14:15:25 -07001703
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001704
Brian Norris23c62e92018-11-14 12:25:51 -08001705def _run_kerneldoc(_project, commit, options=()):
1706 """Runs kernel-doc validator on the given project"""
1707 included, excluded = _parse_common_inclusion_options(options)
1708 files = _filter_files(_get_affected_files(commit, relative=True),
1709 included, excluded)
1710 if files:
1711 hooks_dir = _get_hooks_dir()
Brian Norris0c62a142018-12-11 13:24:29 -08001712 cmd = [os.path.join(hooks_dir, 'kernel-doc'), '-none'] + files
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001713 output = _run_command(cmd, stderr=subprocess.STDOUT)
Brian Norris23c62e92018-11-14 12:25:51 -08001714 if output:
Brian Norris0c62a142018-12-11 13:24:29 -08001715 return HookFailure('kernel-doc errors/warnings:',
1716 items=output.splitlines())
Mike Frysinger8cf80812019-09-16 23:49:29 -04001717 return None
Brian Norris23c62e92018-11-14 12:25:51 -08001718
1719
Mike Frysingerae409522014-02-01 03:16:11 -05001720def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -07001721 """Makes sure kernel config changes are not mixed with code changes"""
1722 files = _get_affected_files(commit)
Mike Frysingerf252cfc2019-12-09 17:34:28 -05001723 if len(_filter_files(files, [r'chromeos/config'])) not in [0, len(files)]:
Olof Johanssona96810f2012-09-04 16:20:03 -07001724 return HookFailure('Changes to chromeos/config/ and regular files must '
1725 'be in separate commits:\n%s' % '\n'.join(files))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001726 return None
Anton Staaf815d6852011-08-22 10:08:45 -07001727
Mike Frysingerae409522014-02-01 03:16:11 -05001728
1729def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -07001730 """Checks that all JSON files are syntactically valid."""
Mike Frysinger908be682018-01-04 02:21:50 -05001731 ret = []
1732
1733 files = _filter_files(_get_affected_files(commit, relative=True),
1734 [r'.*\.json$'])
1735 for f in files:
1736 data = _get_file_content(f, commit)
Dale Curtis2975c432011-05-03 17:25:20 -07001737 try:
Mike Frysinger908be682018-01-04 02:21:50 -05001738 json.loads(data)
1739 except Exception as e:
1740 ret.append('%s: Invalid JSON: %s' % (f, e))
1741
1742 if ret:
1743 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001744 return None
Dale Curtis2975c432011-05-03 17:25:20 -07001745
1746
Mike Frysingerae409522014-02-01 03:16:11 -05001747def _check_manifests(_project, commit):
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001748 """Make sure Manifest files only have comments & DIST lines."""
1749 ret = []
Mike Frysinger52b537e2013-08-22 22:59:53 -04001750
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001751 manifests = _filter_files(_get_affected_files(commit, relative=True),
1752 [r'.*/Manifest$'])
1753 for path in manifests:
1754 data = _get_file_content(path, commit)
1755
1756 # Disallow blank files.
1757 if not data.strip():
1758 ret.append('%s: delete empty file' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001759 continue
1760
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001761 # Make sure the last newline isn't omitted.
1762 if data[-1] != '\n':
1763 ret.append('%s: missing trailing newline' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001764
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001765 # Do not allow leading or trailing blank lines.
1766 lines = data.splitlines()
1767 if not lines[0]:
1768 ret.append('%s: delete leading blank lines' % (path,))
1769 if not lines[-1]:
1770 ret.append('%s: delete trailing blank lines' % (path,))
1771
1772 for line in lines:
1773 # Disallow leading/trailing whitespace.
1774 if line != line.strip():
1775 ret.append('%s: remove leading/trailing whitespace: %s' % (path, line))
1776
1777 # Allow blank lines & comments.
1778 line = line.split('#', 1)[0]
1779 if not line:
1780 continue
1781
1782 # All other linse should start with DIST.
1783 if not line.startswith('DIST '):
1784 ret.append('%s: remove non-DIST lines: %s' % (path, line))
1785 break
1786
1787 if ret:
1788 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001789 return None
Mike Frysinger52b537e2013-08-22 22:59:53 -04001790
1791
Mike Frysingerae409522014-02-01 03:16:11 -05001792def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001793 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001794 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001795 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001796 BRANCH_RE = r'\nBRANCH=\S+'
1797
1798 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
1799 msg = ('Changelist description needs BRANCH field (after first line)\n'
1800 'E.g. BRANCH=none or BRANCH=link,snow')
1801 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001802 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001803
1804
Mike Frysinger45334bd2019-11-04 10:42:33 -05001805def _check_change_has_no_branch_field(_project, commit):
1806 """Verify 'BRANCH=' field does not exist in the commit message."""
1807 if commit == PRE_SUBMIT:
1808 return None
1809 BRANCH_RE = r'\nBRANCH=\S+'
1810
1811 if re.search(BRANCH_RE, _get_commit_desc(commit)):
1812 msg = 'This checkout does not use BRANCH= fields. Delete them.'
1813 return HookFailure(msg)
1814 return None
1815
1816
Mike Frysingerae409522014-02-01 03:16:11 -05001817def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001818 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001819 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001820 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001821 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1822
1823 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1824 msg = ('Changelist description needs Signed-off-by: field\n'
1825 'E.g. Signed-off-by: My Name <me@chromium.org>')
1826 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001827 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001828
1829
Mike Frysinger9ab64b12019-11-04 10:53:08 -05001830def _check_change_has_no_signoff_field(_project, commit):
1831 """Verify 'Signed-off-by:' field does not exist in the commit message."""
1832 if commit == PRE_SUBMIT:
1833 return None
1834 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1835
1836 if re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1837 msg = 'This checkout does not use Signed-off-by: tags. Delete them.'
1838 return HookFailure(msg)
1839 return None
1840
1841
Jon Salz3ee59de2012-08-18 13:54:22 +08001842def _run_project_hook_script(script, project, commit):
1843 """Runs a project hook script.
1844
1845 The script is run with the following environment variables set:
1846 PRESUBMIT_PROJECT: The affected project
1847 PRESUBMIT_COMMIT: The affected commit
1848 PRESUBMIT_FILES: A newline-separated list of affected files
1849
1850 The script is considered to fail if the exit code is non-zero. It should
1851 write an error message to stdout.
1852 """
1853 env = dict(os.environ)
Alex Deymo643ac4c2015-09-03 10:40:50 -07001854 env['PRESUBMIT_PROJECT'] = project.name
Jon Salz3ee59de2012-08-18 13:54:22 +08001855 env['PRESUBMIT_COMMIT'] = commit
1856
1857 # Put affected files in an environment variable
1858 files = _get_affected_files(commit)
1859 env['PRESUBMIT_FILES'] = '\n'.join(files)
1860
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001861 cmd_result = cros_build_lib.run(cmd=script,
1862 env=env,
1863 shell=True,
1864 print_cmd=False,
1865 input=os.devnull,
1866 stdout=True,
1867 encoding='utf-8',
1868 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001869 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001870 check=False)
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001871 if cmd_result.returncode:
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001872 stdout = cmd_result.stdout
Jon Salz7b618af2012-08-31 06:03:16 +08001873 if stdout:
1874 stdout = re.sub('(?m)^', ' ', stdout)
1875 return HookFailure('Hook script "%s" failed with code %d%s' %
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001876 (script, cmd_result.returncode,
Jon Salz3ee59de2012-08-18 13:54:22 +08001877 ':\n' + stdout if stdout else ''))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001878 return None
Jon Salz3ee59de2012-08-18 13:54:22 +08001879
1880
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001881def _check_project_prefix(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -05001882 """Require the commit message have a project specific prefix as needed."""
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001883
Brian Norris77608e12018-04-06 10:38:43 -07001884 files = _get_affected_files(commit, include_deletes=True, relative=True)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001885 prefix = os.path.commonprefix(files)
1886 prefix = os.path.dirname(prefix)
1887
1888 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07001889 if not prefix:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001890 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001891
1892 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07001893
1894 # The common files may all be within a subdirectory of the main project
1895 # directory, so walk up the tree until we find an alias file.
1896 # _get_affected_files() should return relative paths, but check against '/' to
1897 # ensure that this loop terminates even if it receives an absolute path.
1898 while prefix and prefix != '/':
1899 alias_file = os.path.join(prefix, '.project_alias')
1900
1901 # If an alias exists, use it.
1902 if os.path.isfile(alias_file):
1903 project_name = osutils.ReadFile(alias_file).strip()
1904
1905 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001906
1907 if not _get_commit_desc(commit).startswith(project_name + ': '):
1908 return HookFailure('The commit title for changes affecting only %s'
1909 ' should start with \"%s: \"'
1910 % (project_name, project_name))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001911 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001912
1913
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001914def _check_filepath_chartype(_project, commit):
1915 """Checks that FilePath::CharType stuff is not used."""
1916
1917 FILEPATH_REGEXP = re.compile('|'.join(
1918 [r'(?:base::)?FilePath::(?:Char|String|StringPiece)Type',
Satoru Takabayashi4ca37922018-08-08 10:16:38 +09001919 r'(?:base::)?FilePath::FromUTF8Unsafe',
1920 r'AsUTF8Unsafe',
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001921 r'FILE_PATH_LITERAL']))
1922 files = _filter_files(_get_affected_files(commit, relative=True),
1923 [r'.*\.(cc|h)$'])
1924
1925 errors = []
1926 for afile in files:
1927 for line_num, line in _get_file_diff(afile, commit):
1928 m = re.search(FILEPATH_REGEXP, line)
1929 if m:
1930 errors.append('%s, line %s has %s' % (afile, line_num, m.group(0)))
1931
1932 if errors:
1933 msg = 'Please assume FilePath::CharType is char (crbug.com/870621):'
1934 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001935 return None
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001936
1937
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001938def _check_exec_files(_project, commit):
1939 """Make +x bits on files."""
1940 # List of files that should never be +x.
1941 NO_EXEC = (
1942 'ChangeLog*',
1943 'COPYING',
1944 'make.conf',
1945 'make.defaults',
1946 'Manifest',
1947 'OWNERS',
1948 'package.use',
1949 'package.keywords',
1950 'package.mask',
1951 'parent',
1952 'README',
1953 'TODO',
1954 '.gitignore',
1955 '*.[achly]',
1956 '*.[ch]xx',
1957 '*.boto',
1958 '*.cc',
1959 '*.cfg',
1960 '*.conf',
1961 '*.config',
1962 '*.cpp',
1963 '*.css',
1964 '*.ebuild',
1965 '*.eclass',
Tatsuhisa Yamaguchi3b053632019-01-10 14:45:14 +09001966 '*.gn',
1967 '*.gni',
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001968 '*.gyp',
1969 '*.gypi',
1970 '*.htm',
1971 '*.html',
1972 '*.ini',
1973 '*.js',
1974 '*.json',
1975 '*.md',
1976 '*.mk',
1977 '*.patch',
1978 '*.policy',
1979 '*.proto',
1980 '*.raw',
1981 '*.rules',
1982 '*.service',
1983 '*.target',
1984 '*.txt',
1985 '*.xml',
1986 '*.yaml',
1987 )
1988
1989 def FinalName(obj):
1990 # If the file is being deleted, then the dst_file is not set.
1991 if obj.dst_file is None:
1992 return obj.src_file
1993 else:
1994 return obj.dst_file
1995
1996 bad_files = []
1997 files = _get_affected_files(commit, relative=True, full_details=True)
1998 for f in files:
1999 mode = int(f.dst_mode, 8)
2000 if not mode & 0o111:
2001 continue
2002 name = FinalName(f)
2003 for no_exec in NO_EXEC:
2004 if fnmatch.fnmatch(name, no_exec):
2005 bad_files.append(name)
2006 break
2007
2008 if bad_files:
2009 return HookFailure('These files should not be executable. '
2010 'Please `chmod -x` them.', bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04002011 return None
Mike Frysingerf9d41b32017-02-23 15:20:04 -05002012
2013
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002014# Base
2015
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002016# A list of hooks which are not project specific and check patch description
2017# (as opposed to patch body).
2018_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07002019 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07002020 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07002021 _check_change_has_test_field,
2022 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04002023 _check_commit_message_style,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08002024 _check_change_is_contribution,
Jack Neus8edbf642019-07-10 16:08:31 -06002025 _check_change_no_include_oem,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002026]
2027
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002028# A list of hooks that are not project-specific
2029_COMMON_HOOKS = [
Keiichi Watanabe6ab73fd2020-07-14 23:42:02 +09002030 _check_cargo_clippy,
Aviv Keshet5ac59522017-01-31 14:28:27 -08002031 _check_cros_license,
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05002032 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05002033 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08002034 _check_ebuild_licenses,
Mike Frysingercd363c82014-02-01 05:20:18 -05002035 _check_ebuild_virtual_pv,
Mike Frysingerf9d41b32017-02-23 15:20:04 -05002036 _check_exec_files,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002037 _check_for_uprev,
Rahul Chaudhry09f61372015-07-31 17:14:26 -07002038 _check_gofmt,
Bernie Thompson8e26f742020-07-23 14:32:31 -07002039 _check_keywords,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04002040 _check_layout_conf,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002041 _check_no_long_lines,
Keigo Oka4a09bd92019-05-07 14:01:00 +09002042 _check_no_new_gyp,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002043 _check_no_stray_whitespace,
Ryan Cui9b651632011-05-11 11:38:58 -07002044 _check_no_tabs,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002045 _check_portage_make_use_var,
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -06002046 _check_rustfmt,
Aviv Keshet5ac59522017-01-31 14:28:27 -08002047 _check_tabbed_indents,
Ryan Cui9b651632011-05-11 11:38:58 -07002048]
Ryan Cuiec4d6332011-05-02 14:15:25 -07002049
Ryan Cui1562fb82011-05-09 11:01:31 -07002050
Ryan Cui9b651632011-05-11 11:38:58 -07002051# A dictionary of project-specific hooks(callbacks), indexed by project name.
2052# dict[project] = [callback1, callback2]
2053_PROJECT_SPECIFIC_HOOKS = {
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002054 'chromiumos/third_party/kernel': [_kernel_configcheck],
2055 'chromiumos/third_party/kernel-next': [_kernel_configcheck],
Ryan Cui9b651632011-05-11 11:38:58 -07002056}
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002057
Ryan Cui1562fb82011-05-09 11:01:31 -07002058
Ryan Cui9b651632011-05-11 11:38:58 -07002059# A dictionary of flags (keys) that can appear in the config file, and the hook
Mike Frysinger3554bc92015-03-11 04:59:21 -04002060# that the flag controls (value).
2061_HOOK_FLAGS = {
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07002062 'clang_format_check': _check_clang_format,
Mike Frysingera7642f52015-03-25 18:31:42 -04002063 'checkpatch_check': _run_checkpatch,
Brian Norris23c62e92018-11-14 12:25:51 -08002064 'kerneldoc_check': _run_kerneldoc,
Ryan Cui9b651632011-05-11 11:38:58 -07002065 'stray_whitespace_check': _check_no_stray_whitespace,
Mike Frysingerff6c7d62015-03-24 13:49:46 -04002066 'json_check': _run_json_check,
Ryan Cui9b651632011-05-11 11:38:58 -07002067 'long_line_check': _check_no_long_lines,
Alex Deymof5792ce2015-08-24 22:50:08 -07002068 'cros_license_check': _check_cros_license,
2069 'aosp_license_check': _check_aosp_license,
LaMont Jones872fe762020-02-10 15:36:14 -07002070 'gofmt_check': _check_gofmt,
Bernie Thompson8e26f742020-07-23 14:32:31 -07002071 'keyword_check': _check_keywords,
Ryan Cui9b651632011-05-11 11:38:58 -07002072 'tab_check': _check_no_tabs,
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08002073 'tabbed_indent_required_check': _check_tabbed_indents,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07002074 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08002075 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07002076 'bug_field_check': _check_change_has_bug_field,
2077 'test_field_check': _check_change_has_test_field,
Steve Fung49ec7e92015-03-23 16:07:12 -07002078 'manifest_check': _check_manifests,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08002079 'contribution_check': _check_change_is_contribution,
Mike Frysinger47bd1252018-06-11 12:12:20 -04002080 'project_prefix_check': _check_project_prefix,
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09002081 'filepath_chartype_check': _check_filepath_chartype,
Keiichi Watanabe6ab73fd2020-07-14 23:42:02 +09002082 'cargo_clippy_check': _check_cargo_clippy,
Julius Werner291d8602020-07-31 17:34:02 -07002083 'exec_files_check': _check_exec_files,
Ryan Cui9b651632011-05-11 11:38:58 -07002084}
2085
2086
Mike Frysinger3554bc92015-03-11 04:59:21 -04002087def _get_override_hooks(config):
2088 """Returns a set of hooks controlled by the current project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07002089
2090 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08002091
2092 Args:
2093 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07002094 """
2095 SECTION = 'Hook Overrides'
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002096 SECTION_OPTIONS = 'Hook Overrides Options'
Ryan Cui9b651632011-05-11 11:38:58 -07002097
Mike Frysinger56e8de02019-07-31 14:40:14 -04002098 valid_keys = set(_HOOK_FLAGS.keys())
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002099 hooks = _HOOK_FLAGS.copy()
Mike Frysinger180ecd62020-08-19 00:41:51 -04002100 hook_overrides = set(
2101 config.options(SECTION) if config.has_section(SECTION) else [])
2102
2103 unknown_keys = hook_overrides - valid_keys
2104 if unknown_keys:
2105 raise ValueError(f'{_CONFIG_FILE}: [{SECTION}]: unknown keys: '
2106 f'{unknown_keys}')
Mike Frysinger3554bc92015-03-11 04:59:21 -04002107
2108 enable_flags = []
Ryan Cui9b651632011-05-11 11:38:58 -07002109 disable_flags = []
Mike Frysinger180ecd62020-08-19 00:41:51 -04002110 for flag in valid_keys:
2111 if flag in hook_overrides:
2112 try:
2113 enabled = config.getboolean(SECTION, flag)
2114 except ValueError as e:
2115 raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' %
2116 (flag, _CONFIG_FILE, e))
2117 elif hooks[flag] in _COMMON_HOOKS:
2118 # Enable common hooks by default so we process custom options below.
2119 enabled = True
2120 else:
2121 # All other hooks we left as a tristate. We use this below for a few
2122 # hooks to control default behavior.
2123 enabled = None
Mike Frysinger3554bc92015-03-11 04:59:21 -04002124
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002125 if enabled:
2126 enable_flags.append(flag)
Mike Frysinger180ecd62020-08-19 00:41:51 -04002127 elif enabled is not None:
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002128 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07002129
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002130 # See if this hook has custom options.
2131 if enabled:
2132 try:
2133 options = config.get(SECTION_OPTIONS, flag)
2134 hooks[flag] = functools.partial(hooks[flag], options=options.split())
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002135 hooks[flag].__name__ = flag
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04002136 except (configparser.NoOptionError, configparser.NoSectionError):
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002137 pass
2138
2139 enabled_hooks = set(hooks[x] for x in enable_flags)
2140 disabled_hooks = set(hooks[x] for x in disable_flags)
Mike Frysinger45334bd2019-11-04 10:42:33 -05002141
Mike Frysinger9ab64b12019-11-04 10:53:08 -05002142 if _check_change_has_signoff_field not in enabled_hooks:
Drew Davenport85848e52020-01-15 14:40:29 -07002143 if _check_change_has_signoff_field not in disabled_hooks:
2144 enabled_hooks.add(_check_change_has_no_signoff_field)
Mike Frysinger45334bd2019-11-04 10:42:33 -05002145 if _check_change_has_branch_field not in enabled_hooks:
2146 enabled_hooks.add(_check_change_has_no_branch_field)
2147
Mike Frysinger3554bc92015-03-11 04:59:21 -04002148 return enabled_hooks, disabled_hooks
Ryan Cui9b651632011-05-11 11:38:58 -07002149
2150
Jon Salz3ee59de2012-08-18 13:54:22 +08002151def _get_project_hook_scripts(config):
2152 """Returns a list of project-specific hook scripts.
2153
2154 Args:
2155 config: A ConfigParser for the project's config file.
2156 """
2157 SECTION = 'Hook Scripts'
2158 if not config.has_section(SECTION):
2159 return []
2160
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002161 return config.items(SECTION)
Jon Salz3ee59de2012-08-18 13:54:22 +08002162
2163
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002164def _get_project_hooks(project, presubmit, config_file=None):
Ryan Cui9b651632011-05-11 11:38:58 -07002165 """Returns a list of hooks that need to be run for a project.
2166
2167 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002168
2169 Args:
2170 project: A string, name of the project.
2171 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002172 config_file: A string, the config file. Defaults to _CONFIG_FILE.
Ryan Cui9b651632011-05-11 11:38:58 -07002173 """
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04002174 config = configparser.RawConfigParser()
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002175 if config_file is None:
2176 config_file = _CONFIG_FILE
2177 if not os.path.exists(config_file):
Jon Salz3ee59de2012-08-18 13:54:22 +08002178 # Just use an empty config file
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04002179 config = configparser.RawConfigParser()
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09002180 else:
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002181 config.read(config_file)
Jon Salz3ee59de2012-08-18 13:54:22 +08002182
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002183 if presubmit:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07002184 hooks = _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002185 else:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07002186 hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002187
Mike Frysinger3554bc92015-03-11 04:59:21 -04002188 enabled_hooks, disabled_hooks = _get_override_hooks(config)
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07002189 hooks = [hook for hook in hooks if hook not in disabled_hooks]
2190
2191 # If a list is both in _COMMON_HOOKS and also enabled explicitly through an
2192 # override, keep the override only. Note that the override may end up being
2193 # a functools.partial, in which case we need to extract the .func to compare
2194 # it to the common hooks.
2195 unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks]
2196 hooks = [hook for hook in hooks if hook not in unwrapped_hooks]
2197
2198 hooks = list(enabled_hooks) + hooks
Ryan Cui9b651632011-05-11 11:38:58 -07002199
2200 if project in _PROJECT_SPECIFIC_HOOKS:
Puneet Kumarc80e3f62012-08-13 19:01:18 -07002201 hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project]
2202 if hook not in disabled_hooks)
Ryan Cui9b651632011-05-11 11:38:58 -07002203
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002204 for name, script in _get_project_hook_scripts(config):
2205 func = functools.partial(_run_project_hook_script, script)
2206 func.__name__ = name
2207 hooks.append(func)
Jon Salz3ee59de2012-08-18 13:54:22 +08002208
Ryan Cui9b651632011-05-11 11:38:58 -07002209 return hooks
2210
2211
Alex Deymo643ac4c2015-09-03 10:40:50 -07002212def _run_project_hooks(project_name, proj_dir=None,
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002213 commit_list=None, presubmit=False,
2214 config_file=None):
Ryan Cui1562fb82011-05-09 11:01:31 -07002215 """For each project run its project specific hook from the hooks dictionary.
2216
2217 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002218 project_name: The name of project to run hooks for.
Doug Anderson44a644f2011-11-02 10:37:37 -07002219 proj_dir: If non-None, this is the directory the project is in. If None,
2220 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07002221 commit_list: A list of commits to run hooks against. If None or empty list
2222 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002223 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002224 config_file: A string, the presubmit config file. If not specified,
2225 defaults to PRESUBMIT.cfg in the project directory.
Ryan Cui1562fb82011-05-09 11:01:31 -07002226
2227 Returns:
2228 Boolean value of whether any errors were ecountered while running the hooks.
2229 """
Doug Anderson44a644f2011-11-02 10:37:37 -07002230 if proj_dir is None:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002231 proj_dirs = _run_command(
2232 ['repo', 'forall', project_name, '-c', 'pwd']).split()
Mike Frysingere52b1bc2019-09-16 23:45:41 -04002233 if not proj_dirs:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002234 print('%s cannot be found.' % project_name, file=sys.stderr)
David James2edd9002013-10-11 14:09:19 -07002235 print('Please specify a valid project.', file=sys.stderr)
2236 return True
2237 if len(proj_dirs) > 1:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002238 print('%s is associated with multiple directories.' % project_name,
David James2edd9002013-10-11 14:09:19 -07002239 file=sys.stderr)
2240 print('Please specify a directory to help disambiguate.', file=sys.stderr)
2241 return True
2242 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07002243
Ryan Cuiec4d6332011-05-02 14:15:25 -07002244 pwd = os.getcwd()
2245 # hooks assume they are run from the root of the project
2246 os.chdir(proj_dir)
2247
Mike Frysingered1b95a2019-12-12 19:04:51 -05002248 color = terminal.Color()
2249
Alex Deymo643ac4c2015-09-03 10:40:50 -07002250 remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref',
2251 '--symbolic-full-name', '@{u}']).strip()
2252 if not remote_branch:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002253 print("Your project %s doesn't track any remote repo." % project_name,
Alex Deymo643ac4c2015-09-03 10:40:50 -07002254 file=sys.stderr)
2255 remote = None
2256 else:
Josh Pratt15d13ab2018-08-13 11:52:48 +10002257 branch_items = remote_branch.split('/', 1)
2258 if len(branch_items) != 2:
2259 PrintErrorForProject(
2260 project_name,
2261 HookFailure(
2262 'Cannot get remote and branch name (%s)' % remote_branch))
2263 os.chdir(pwd)
2264 return True
2265 remote, _branch = branch_items
Alex Deymo643ac4c2015-09-03 10:40:50 -07002266
2267 project = Project(name=project_name, dir=proj_dir, remote=remote)
2268
Doug Anderson14749562013-06-26 13:38:29 -07002269 if not commit_list:
2270 try:
2271 commit_list = _get_commits()
2272 except VerifyException as e:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002273 PrintErrorForProject(project.name, HookFailure(str(e)))
Doug Anderson14749562013-06-26 13:38:29 -07002274 os.chdir(pwd)
2275 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07002276
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002277 hooks = _get_project_hooks(project.name, presubmit, config_file)
Ryan Cui1562fb82011-05-09 11:01:31 -07002278 error_found = False
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002279 commit_count = len(commit_list)
Mike Frysingerb99b3772019-08-17 14:19:44 -04002280 hook_count = len(hooks)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002281 for i, commit in enumerate(commit_list):
Mike Frysingerb2496652019-09-12 23:35:46 -04002282 CACHE.clear()
2283
LaMont Jones69d3e182020-03-11 15:00:53 -06002284 # If run with --pre-submit, then commit is PRE_SUBMIT, and not a commit.
2285 # Use that as the description.
2286 desc = commit if commit == PRE_SUBMIT else _get_commit_desc(commit)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002287 print('[%s %i/%i %s] %s' %
2288 (color.Color(color.CYAN, 'COMMIT'), i + 1, commit_count, commit[0:12],
2289 desc.splitlines()[0]))
2290
Mike Frysingerb99b3772019-08-17 14:19:44 -04002291 for h, hook in enumerate(hooks):
Mike Frysingered1b95a2019-12-12 19:04:51 -05002292 output = ('[%s %i/%i PRESUBMIT.cfg] %s' %
2293 (color.Color(color.YELLOW, 'RUNNING'), h + 1, hook_count,
2294 hook.__name__))
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002295 print(output, end='\r')
2296 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002297 hook_error = hook(project, commit)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002298 print(' ' * len(output), end='\r')
2299 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002300 if hook_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002301 if not isinstance(hook_error, list):
2302 hook_error = [hook_error]
2303 PrintErrorsForCommit(color, hook, project.name, hook_error)
Ryan Cui1562fb82011-05-09 11:01:31 -07002304 error_found = True
Don Garrettdba548a2011-05-05 15:17:14 -07002305
Ryan Cuiec4d6332011-05-02 14:15:25 -07002306 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07002307 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002308
Mike Frysingerae409522014-02-01 03:16:11 -05002309
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002310# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002311
Ryan Cui1562fb82011-05-09 11:01:31 -07002312
Mike Frysingerae409522014-02-01 03:16:11 -05002313def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08002314 """Main function invoked directly by repo.
2315
2316 This function will exit directly upon error so that repo doesn't print some
2317 obscure error message.
2318
2319 Args:
2320 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07002321 worktree_list: A list of directories. It should be the same length as
2322 project_list, so that each entry in project_list matches with a directory
2323 in worktree_list. If None, we will attempt to calculate the directories
2324 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08002325 kwargs: Leave this here for forward-compatibility.
2326 """
Mike Frysingered1b95a2019-12-12 19:04:51 -05002327 start_time = datetime.datetime.now()
Ryan Cui1562fb82011-05-09 11:01:31 -07002328 found_error = False
David James2edd9002013-10-11 14:09:19 -07002329 if not worktree_list:
2330 worktree_list = [None] * len(project_list)
2331 for project, worktree in zip(project_list, worktree_list):
2332 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07002333 found_error = True
2334
Mike Frysingered1b95a2019-12-12 19:04:51 -05002335 end_time = datetime.datetime.now()
2336 color = terminal.Color()
Mike Frysingerae409522014-02-01 03:16:11 -05002337 if found_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002338 msg = ('%s: Preupload failed due to above error(s).\n'
Ryan Cui9b651632011-05-11 11:38:58 -07002339 '- To disable some source style checks, and for other hints, see '
Mike Frysingered1b95a2019-12-12 19:04:51 -05002340 '<checkout_dir>/src/repohooks/README.md\n'
2341 "- To upload only current project, run 'repo upload .'" %
2342 (color.Color(color.RED, 'FATAL'),))
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04002343 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07002344 sys.exit(1)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002345 else:
2346 msg = ('[%s] repohooks passed in %s' %
2347 (color.Color(color.GREEN, 'PASSED'), end_time - start_time))
2348 print(msg)
Anush Elangovan63afad72011-03-23 00:41:27 -07002349
Ryan Cui1562fb82011-05-09 11:01:31 -07002350
Doug Anderson44a644f2011-11-02 10:37:37 -07002351def _identify_project(path):
2352 """Identify the repo project associated with the given path.
2353
2354 Returns:
2355 A string indicating what project is associated with the path passed in or
2356 a blank string upon failure.
2357 """
2358 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002359 stderr=True, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002360
2361
Mike Frysinger55f85b52014-12-18 14:45:21 -05002362def direct_main(argv):
Doug Anderson44a644f2011-11-02 10:37:37 -07002363 """Run hooks directly (outside of the context of repo).
2364
Doug Anderson44a644f2011-11-02 10:37:37 -07002365 Args:
Mike Frysinger55f85b52014-12-18 14:45:21 -05002366 argv: The command line args to process
Doug Anderson44a644f2011-11-02 10:37:37 -07002367
2368 Returns:
2369 0 if no pre-upload failures, 1 if failures.
2370
2371 Raises:
2372 BadInvocation: On some types of invocation errors.
2373 """
Mike Frysinger66142932014-12-18 14:55:57 -05002374 parser = commandline.ArgumentParser(description=__doc__)
2375 parser.add_argument('--dir', default=None,
2376 help='The directory that the project lives in. If not '
2377 'specified, use the git project root based on the cwd.')
2378 parser.add_argument('--project', default=None,
2379 help='The project repo path; this can affect how the '
2380 'hooks get run, since some hooks are project-specific. '
2381 'For chromite this is chromiumos/chromite. If not '
2382 'specified, the repo tool will be used to figure this '
2383 'out based on the dir.')
2384 parser.add_argument('--rerun-since', default=None,
Vadim Bendebury75447b92018-01-10 12:06:01 -08002385 help='Rerun hooks on old commits since some point '
2386 'in the past. The argument could be a date (should '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002387 "match git log's concept of a date, e.g. 2012-06-20), "
Vadim Bendebury75447b92018-01-10 12:06:01 -08002388 'or a SHA1, or just a number of commits to check (from 1 '
2389 'to 99). This option is mutually exclusive with '
2390 '--pre-submit.')
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002391 parser.add_argument('--pre-submit', action='store_true',
Mike Frysinger66142932014-12-18 14:55:57 -05002392 help='Run the check against the pending commit. '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002393 "This option should be used at the 'git commit' "
2394 "phase as opposed to 'repo upload'. This option "
Mike Frysinger66142932014-12-18 14:55:57 -05002395 'is mutually exclusive with --rerun-since.')
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002396 parser.add_argument('--presubmit-config',
2397 help='Specify presubmit config file to be used.')
Mike Frysinger66142932014-12-18 14:55:57 -05002398 parser.add_argument('commits', nargs='*',
2399 help='Check specific commits')
2400 opts = parser.parse_args(argv)
Doug Anderson44a644f2011-11-02 10:37:37 -07002401
Doug Anderson14749562013-06-26 13:38:29 -07002402 if opts.rerun_since:
Mike Frysinger66142932014-12-18 14:55:57 -05002403 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002404 raise BadInvocation("Can't pass commits and use rerun-since: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002405 ' '.join(opts.commits))
Doug Anderson14749562013-06-26 13:38:29 -07002406
Vadim Bendebury75447b92018-01-10 12:06:01 -08002407 if len(opts.rerun_since) < 3 and opts.rerun_since.isdigit():
2408 # This must be the number of commits to check. We don't expect the user
2409 # to want to check more than 99 commits.
2410 limit = '-n%s' % opts.rerun_since
2411 elif git.IsSHA1(opts.rerun_since, False):
2412 limit = '%s..' % opts.rerun_since
2413 else:
2414 # This better be a date.
2415 limit = '--since=%s' % opts.rerun_since
2416 cmd = ['git', 'log', limit, '--pretty=%H']
Doug Anderson14749562013-06-26 13:38:29 -07002417 all_commits = _run_command(cmd).splitlines()
2418 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
2419
2420 # Eliminate chrome-bot commits but keep ordering the same...
2421 bot_commits = set(bot_commits)
Mike Frysinger66142932014-12-18 14:55:57 -05002422 opts.commits = [c for c in all_commits if c not in bot_commits]
Doug Anderson14749562013-06-26 13:38:29 -07002423
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002424 if opts.pre_submit:
2425 raise BadInvocation('rerun-since and pre-submit can not be '
2426 'used together')
2427 if opts.pre_submit:
Mike Frysinger66142932014-12-18 14:55:57 -05002428 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002429 raise BadInvocation("Can't pass commits and use pre-submit: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002430 ' '.join(opts.commits))
2431 opts.commits = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07002432
2433 # Check/normlaize git dir; if unspecified, we'll use the root of the git
2434 # project from CWD
2435 if opts.dir is None:
2436 git_dir = _run_command(['git', 'rev-parse', '--git-dir'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002437 stderr=True).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002438 if not git_dir:
2439 raise BadInvocation('The current directory is not part of a git project.')
2440 opts.dir = os.path.dirname(os.path.abspath(git_dir))
2441 elif not os.path.isdir(opts.dir):
2442 raise BadInvocation('Invalid dir: %s' % opts.dir)
2443 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
2444 raise BadInvocation('Not a git directory: %s' % opts.dir)
2445
2446 # Identify the project if it wasn't specified; this _requires_ the repo
2447 # tool to be installed and for the project to be part of a repo checkout.
2448 if not opts.project:
2449 opts.project = _identify_project(opts.dir)
2450 if not opts.project:
2451 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
2452
Doug Anderson14749562013-06-26 13:38:29 -07002453 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Mike Frysinger66142932014-12-18 14:55:57 -05002454 commit_list=opts.commits,
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002455 presubmit=opts.pre_submit,
2456 config_file=opts.presubmit_config)
Doug Anderson44a644f2011-11-02 10:37:37 -07002457 if found_error:
2458 return 1
2459 return 0
2460
2461
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002462if __name__ == '__main__':
Mike Frysinger55f85b52014-12-18 14:45:21 -05002463 sys.exit(direct_main(sys.argv[1:]))