Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 1 | # Copyright 2019 The Chromium OS Authors. All rights reserved. |
| 2 | # Use of this source code is governed by a BSD-style license that can be |
| 3 | # found in the LICENSE file. |
| 4 | |
| 5 | """packages controller unit tests.""" |
| 6 | |
Mike Frysinger | 166fea0 | 2021-02-12 05:30:33 -0500 | [diff] [blame] | 7 | from unittest import mock |
| 8 | |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 9 | from chromite.api.api_config import ApiConfigMixin |
David Burger | 0f9dd4e | 2019-10-08 12:33:42 -0600 | [diff] [blame] | 10 | from chromite.api.controller import controller_util |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 11 | from chromite.api.controller import packages as packages_controller |
| 12 | from chromite.api.gen.chromite.api import binhost_pb2 |
| 13 | from chromite.api.gen.chromite.api import packages_pb2 |
Mike Frysinger | 1cc8f1f | 2022-04-28 22:40:40 -0400 | [diff] [blame] | 14 | from chromite.api.gen.chromiumos import common_pb2 |
Chris McDonald | 3840911 | 2020-09-24 11:24:51 -0600 | [diff] [blame] | 15 | from chromite.lib import build_target_lib |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 16 | from chromite.lib import constants |
| 17 | from chromite.lib import cros_build_lib |
| 18 | from chromite.lib import cros_test_lib |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 19 | from chromite.lib import portage_util |
Chris McDonald | 3840911 | 2020-09-24 11:24:51 -0600 | [diff] [blame] | 20 | from chromite.lib import uprev_lib |
Alex Klein | 75df179 | 2020-06-11 14:42:49 -0600 | [diff] [blame] | 21 | from chromite.lib.parser import package_info |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 22 | from chromite.service import packages as packages_service |
| 23 | |
| 24 | |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 25 | class UprevTest(cros_test_lib.MockTestCase, ApiConfigMixin): |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 26 | """Uprev tests.""" |
| 27 | |
| 28 | _PUBLIC = binhost_pb2.OVERLAYTYPE_PUBLIC |
| 29 | _PRIVATE = binhost_pb2.OVERLAYTYPE_PRIVATE |
| 30 | _BOTH = binhost_pb2.OVERLAYTYPE_BOTH |
| 31 | _NONE = binhost_pb2.OVERLAYTYPE_NONE |
| 32 | |
| 33 | def setUp(self): |
| 34 | self.uprev_patch = self.PatchObject(packages_service, 'uprev_build_targets') |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 35 | self.response = packages_pb2.UprevPackagesResponse() |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 36 | |
| 37 | def _GetRequest(self, targets=None, overlay_type=None, output_dir=None): |
| 38 | return packages_pb2.UprevPackagesRequest( |
| 39 | build_targets=[{'name': name} for name in targets or []], |
| 40 | overlay_type=overlay_type, |
| 41 | output_dir=output_dir, |
| 42 | ) |
| 43 | |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 44 | def testValidateOnly(self): |
| 45 | """Sanity check that a validate only call does not execute any logic.""" |
| 46 | patch = self.PatchObject(packages_service, 'uprev_build_targets') |
| 47 | |
| 48 | targets = ['foo', 'bar'] |
| 49 | request = self._GetRequest(targets=targets, overlay_type=self._BOTH) |
| 50 | packages_controller.Uprev(request, self.response, self.validate_only_config) |
| 51 | patch.assert_not_called() |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 52 | |
Michael Mortensen | 2677bf6 | 2019-10-29 08:31:25 -0600 | [diff] [blame] | 53 | def testMockCall(self): |
| 54 | """Test that a mock call does not execute logic, returns mocked value.""" |
| 55 | patch = self.PatchObject(packages_service, 'uprev_build_targets') |
| 56 | targets = ['foo', 'bar'] |
| 57 | request = self._GetRequest(targets=targets, overlay_type=self._BOTH) |
| 58 | packages_controller.Uprev(request, self.response, self.mock_call_config) |
| 59 | patch.assert_not_called() |
| 60 | self.assertTrue(self.response.modified_ebuilds) |
| 61 | |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 62 | def testNoOverlayTypeFails(self): |
| 63 | """No overlay type provided should fail.""" |
| 64 | request = self._GetRequest(targets=['foo']) |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 65 | |
| 66 | with self.assertRaises(cros_build_lib.DieSystemExit): |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 67 | packages_controller.Uprev(request, self.response, self.api_config) |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 68 | |
| 69 | def testOverlayTypeNoneFails(self): |
| 70 | """Overlay type none means nothing here and should fail.""" |
| 71 | request = self._GetRequest(targets=['foo'], overlay_type=self._NONE) |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 72 | |
| 73 | with self.assertRaises(cros_build_lib.DieSystemExit): |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 74 | packages_controller.Uprev(request, self.response, self.api_config) |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 75 | |
| 76 | def testSuccess(self): |
| 77 | """Test overall successful argument handling.""" |
| 78 | targets = ['foo', 'bar'] |
| 79 | output_dir = '/tmp/uprev_output_dir' |
Alex Klein | 5dd6b1e | 2019-07-31 15:45:24 -0600 | [diff] [blame] | 80 | changed = ['/ebuild-1.0-r1.ebuild', '/ebuild-1.0-r2.ebuild'] |
Dhanya Ganesh | d03a416 | 2021-08-25 00:21:50 +0000 | [diff] [blame] | 81 | revved_packages = ['cat1/pkg1-1.11', 'cat2/pkg2-1.12'] |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 82 | expected_type = constants.BOTH_OVERLAYS |
| 83 | request = self._GetRequest(targets=targets, overlay_type=self._BOTH, |
| 84 | output_dir=output_dir) |
Alex Klein | 5dd6b1e | 2019-07-31 15:45:24 -0600 | [diff] [blame] | 85 | uprev_patch = self.PatchObject(packages_service, 'uprev_build_targets', |
Dhanya Ganesh | d03a416 | 2021-08-25 00:21:50 +0000 | [diff] [blame] | 86 | return_value=(changed, revved_packages)) |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 87 | |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 88 | packages_controller.Uprev(request, self.response, self.api_config) |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 89 | |
| 90 | # Make sure the type is right, verify build targets after. |
| 91 | uprev_patch.assert_called_once_with(mock.ANY, expected_type, mock.ANY, |
| 92 | output_dir) |
| 93 | # First argument (build targets) of the first (only) call. |
| 94 | call_targets = uprev_patch.call_args[0][0] |
Mike Frysinger | 678735c | 2019-09-28 18:23:28 -0400 | [diff] [blame] | 95 | self.assertCountEqual(targets, [t.name for t in call_targets]) |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 96 | |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 97 | for ebuild in self.response.modified_ebuilds: |
Alex Klein | 5dd6b1e | 2019-07-31 15:45:24 -0600 | [diff] [blame] | 98 | self.assertIn(ebuild.path, changed) |
| 99 | changed.remove(ebuild.path) |
| 100 | self.assertFalse(changed) |
| 101 | |
Dhanya Ganesh | d03a416 | 2021-08-25 00:21:50 +0000 | [diff] [blame] | 102 | for pkg in self.response.packages: |
| 103 | self.assertTrue(pkg.category.startswith('cat')) |
| 104 | self.assertTrue(pkg.package_name.startswith('pkg')) |
| 105 | self.assertTrue(pkg.version.startswith('1.1')) |
| 106 | |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 107 | |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 108 | class UprevVersionedPackageTest(cros_test_lib.MockTestCase, ApiConfigMixin): |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 109 | """UprevVersionedPackage tests.""" |
| 110 | |
| 111 | def setUp(self): |
Yaakov Shaul | 730814a | 2019-09-10 13:58:25 -0600 | [diff] [blame] | 112 | self.response = packages_pb2.UprevVersionedPackageResponse() |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 113 | |
| 114 | def _addVersion(self, request, version): |
| 115 | """Helper method to add a full version message to the request.""" |
| 116 | ref = request.versions.add() |
| 117 | ref.repository = '/some/path' |
Alex Klein | 34afcbc | 2019-08-22 16:14:31 -0600 | [diff] [blame] | 118 | ref.ref = 'refs/tags/%s' % version |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 119 | ref.revision = 'abc123' |
| 120 | |
| 121 | def testValidateOnly(self): |
| 122 | """Sanity check validate only calls are working properly.""" |
| 123 | service = self.PatchObject(packages_service, 'uprev_versioned_package') |
| 124 | |
| 125 | request = packages_pb2.UprevVersionedPackageRequest() |
| 126 | self._addVersion(request, '1.2.3.4') |
| 127 | request.package_info.category = 'chromeos-base' |
| 128 | request.package_info.package_name = 'chromeos-chrome' |
| 129 | |
| 130 | packages_controller.UprevVersionedPackage(request, self.response, |
| 131 | self.validate_only_config) |
| 132 | |
| 133 | service.assert_not_called() |
| 134 | |
Michael Mortensen | 2677bf6 | 2019-10-29 08:31:25 -0600 | [diff] [blame] | 135 | def testMockCall(self): |
| 136 | """Test that a mock call does not execute logic, returns mocked value.""" |
| 137 | patch = self.PatchObject(packages_service, 'uprev_versioned_package') |
| 138 | request = packages_pb2.UprevVersionedPackageRequest() |
| 139 | packages_controller.UprevVersionedPackage(request, self.response, |
| 140 | self.mock_call_config) |
| 141 | patch.assert_not_called() |
| 142 | self.assertTrue(self.response.responses) |
| 143 | self.assertTrue(self.response.responses[0].modified_ebuilds) |
| 144 | |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 145 | def testNoVersions(self): |
| 146 | """Test no versions provided.""" |
| 147 | request = packages_pb2.UprevVersionedPackageRequest() |
| 148 | request.package_info.category = 'chromeos-base' |
| 149 | request.package_info.package_name = 'chromeos-chrome' |
| 150 | |
| 151 | with self.assertRaises(cros_build_lib.DieSystemExit): |
| 152 | packages_controller.UprevVersionedPackage(request, self.response, |
| 153 | self.api_config) |
| 154 | |
| 155 | def testNoPackageName(self): |
| 156 | """Test no package name provided.""" |
| 157 | request = packages_pb2.UprevVersionedPackageRequest() |
| 158 | self._addVersion(request, '1.2.3.4') |
| 159 | request.package_info.category = 'chromeos-base' |
| 160 | |
| 161 | with self.assertRaises(cros_build_lib.DieSystemExit): |
| 162 | packages_controller.UprevVersionedPackage(request, self.response, |
| 163 | self.api_config) |
| 164 | |
| 165 | def testNoCategory(self): |
| 166 | """Test no package category provided.""" |
| 167 | request = packages_pb2.UprevVersionedPackageRequest() |
| 168 | self._addVersion(request, '1.2.3.4') |
| 169 | request.package_info.package_name = 'chromeos-chrome' |
| 170 | |
| 171 | with self.assertRaises(cros_build_lib.DieSystemExit): |
| 172 | packages_controller.UprevVersionedPackage(request, self.response, |
| 173 | self.api_config) |
| 174 | |
| 175 | def testOutputHandling(self): |
| 176 | """Test the modified files are getting correctly added to the output.""" |
Alex Klein | 34afcbc | 2019-08-22 16:14:31 -0600 | [diff] [blame] | 177 | version = '1.2.3.4' |
Chris McDonald | 3840911 | 2020-09-24 11:24:51 -0600 | [diff] [blame] | 178 | result = uprev_lib.UprevVersionedPackageResult().add_result( |
Alex Klein | 34afcbc | 2019-08-22 16:14:31 -0600 | [diff] [blame] | 179 | version, ['/file/one', '/file/two']) |
Yaakov Shaul | 730814a | 2019-09-10 13:58:25 -0600 | [diff] [blame] | 180 | |
Alex Klein | 34afcbc | 2019-08-22 16:14:31 -0600 | [diff] [blame] | 181 | self.PatchObject( |
| 182 | packages_service, 'uprev_versioned_package', return_value=result) |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 183 | |
| 184 | request = packages_pb2.UprevVersionedPackageRequest() |
Alex Klein | 34afcbc | 2019-08-22 16:14:31 -0600 | [diff] [blame] | 185 | self._addVersion(request, version) |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 186 | request.package_info.category = 'chromeos-base' |
| 187 | request.package_info.package_name = 'chromeos-chrome' |
| 188 | |
| 189 | packages_controller.UprevVersionedPackage(request, self.response, |
| 190 | self.api_config) |
| 191 | |
Yaakov Shaul | 730814a | 2019-09-10 13:58:25 -0600 | [diff] [blame] | 192 | for idx, uprev_response in enumerate(self.response.responses): |
| 193 | self.assertEqual(result.modified[idx].new_version, uprev_response.version) |
Mike Frysinger | 678735c | 2019-09-28 18:23:28 -0400 | [diff] [blame] | 194 | self.assertCountEqual( |
Yaakov Shaul | 730814a | 2019-09-10 13:58:25 -0600 | [diff] [blame] | 195 | result.modified[idx].files, |
| 196 | [ebuild.path for ebuild in uprev_response.modified_ebuilds]) |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 197 | |
| 198 | |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 199 | class GetBestVisibleTest(cros_test_lib.MockTestCase, ApiConfigMixin): |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 200 | """GetBestVisible tests.""" |
| 201 | |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 202 | def setUp(self): |
| 203 | self.response = packages_pb2.GetBestVisibleResponse() |
| 204 | |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 205 | def _GetRequest(self, atom=None): |
| 206 | return packages_pb2.GetBestVisibleRequest( |
| 207 | atom=atom, |
| 208 | ) |
| 209 | |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 210 | def testValidateOnly(self): |
| 211 | """Sanity check that a validate only call does not execute any logic.""" |
| 212 | patch = self.PatchObject(packages_service, 'get_best_visible') |
| 213 | |
| 214 | request = self._GetRequest(atom='chromeos-chrome') |
| 215 | packages_controller.GetBestVisible(request, self.response, |
| 216 | self.validate_only_config) |
| 217 | patch.assert_not_called() |
| 218 | |
Michael Mortensen | 2677bf6 | 2019-10-29 08:31:25 -0600 | [diff] [blame] | 219 | def testMockCall(self): |
| 220 | """Test that a mock call does not execute logic, returns mocked value.""" |
| 221 | patch = self.PatchObject(packages_service, 'get_best_visible') |
| 222 | request = self._GetRequest(atom='chromeos-chrome') |
| 223 | packages_controller.GetBestVisible(request, self.response, |
| 224 | self.mock_call_config) |
| 225 | patch.assert_not_called() |
| 226 | self.assertTrue(self.response.package_info) |
| 227 | self.assertTrue(self.response.package_info.category) |
| 228 | self.assertTrue(self.response.package_info.package_name) |
| 229 | self.assertTrue(self.response.package_info.version) |
| 230 | |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 231 | def testNoAtomFails(self): |
| 232 | """No atom provided should fail.""" |
| 233 | request = self._GetRequest() |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 234 | with self.assertRaises(cros_build_lib.DieSystemExit): |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 235 | packages_controller.GetBestVisible(request, self.response, |
| 236 | self.api_config) |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 237 | |
| 238 | def testSuccess(self): |
| 239 | """Test overall success, argument handling, result forwarding.""" |
Alex Klein | 5caab87 | 2021-09-10 11:44:37 -0600 | [diff] [blame] | 240 | pkg = package_info.PackageInfo('category', 'package', '1.2.3.4', 5) |
| 241 | self.PatchObject(packages_service, 'get_best_visible', return_value=pkg) |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 242 | |
Alex Klein | 5caab87 | 2021-09-10 11:44:37 -0600 | [diff] [blame] | 243 | request = self._GetRequest(atom='category/package') |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 244 | |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 245 | packages_controller.GetBestVisible(request, self.response, self.api_config) |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 246 | |
Alex Klein | 75df179 | 2020-06-11 14:42:49 -0600 | [diff] [blame] | 247 | package_info_msg = self.response.package_info |
Alex Klein | 5caab87 | 2021-09-10 11:44:37 -0600 | [diff] [blame] | 248 | self.assertEqual(package_info_msg.category, pkg.category) |
| 249 | self.assertEqual(package_info_msg.package_name, pkg.package) |
| 250 | self.assertEqual(package_info_msg.version, pkg.vr) |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 251 | |
| 252 | |
Michael Mortensen | 68abdb7 | 2019-10-28 09:43:52 -0600 | [diff] [blame] | 253 | class GetChromeVersion(cros_test_lib.MockTestCase, ApiConfigMixin): |
| 254 | """GetChromeVersion tests.""" |
| 255 | |
| 256 | def setUp(self): |
| 257 | self.response = packages_pb2.GetChromeVersionResponse() |
| 258 | |
| 259 | def _GetRequest(self, board=None): |
| 260 | """Helper to build out a request.""" |
| 261 | request = packages_pb2.GetChromeVersionRequest() |
| 262 | |
| 263 | if board: |
| 264 | request.build_target.name = board |
| 265 | |
| 266 | return request |
| 267 | |
| 268 | def testValidateOnly(self): |
| 269 | """Sanity check that a validate only call does not execute any logic.""" |
| 270 | chrome_version = self.PatchObject(packages_service, |
| 271 | 'determine_chrome_version') |
| 272 | request = self._GetRequest(board='betty') |
| 273 | packages_controller.GetChromeVersion(request, self.response, |
| 274 | self.validate_only_config) |
| 275 | chrome_version.assert_not_called() |
| 276 | |
| 277 | def testMockCall(self): |
| 278 | """Test that a mock call does not execute logic, returns mocked value.""" |
| 279 | chrome_version = self.PatchObject(packages_service, |
| 280 | 'determine_chrome_version') |
| 281 | request = self._GetRequest(board='betty') |
| 282 | packages_controller.GetChromeVersion(request, self.response, |
| 283 | self.mock_call_config) |
| 284 | chrome_version.assert_not_called() |
| 285 | self.assertTrue(self.response.version) |
| 286 | |
| 287 | def testGetChromeVersion(self): |
| 288 | """Verify basic return values.""" |
| 289 | chrome_version = '76.0.1.2' |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 290 | chrome_version_mock = self.PatchObject(packages_service, |
| 291 | 'determine_chrome_version', |
| 292 | return_value=chrome_version) |
Michael Mortensen | 68abdb7 | 2019-10-28 09:43:52 -0600 | [diff] [blame] | 293 | request = self._GetRequest(board='betty') |
| 294 | packages_controller.GetChromeVersion(request, self.response, |
| 295 | self.api_config) |
| 296 | self.assertEqual(self.response.version, chrome_version) |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 297 | # Verify call to determine_chrome_version passes a build_target object. |
| 298 | build_target = build_target_lib.BuildTarget('betty') |
| 299 | chrome_version_mock.assert_called_with(build_target) |
Michael Mortensen | 68abdb7 | 2019-10-28 09:43:52 -0600 | [diff] [blame] | 300 | |
Michael Mortensen | 9fe740c | 2019-10-29 14:42:48 -0600 | [diff] [blame] | 301 | def testGetChromeVersionHandleNone(self): |
| 302 | """Verify basic return values.""" |
| 303 | self.PatchObject(packages_service, 'determine_chrome_version', |
| 304 | return_value=None) |
| 305 | request = self._GetRequest(board='betty') |
| 306 | packages_controller.GetChromeVersion(request, self.response, |
| 307 | self.api_config) |
| 308 | self.assertFalse(self.response.version) |
| 309 | |
Michael Mortensen | 68abdb7 | 2019-10-28 09:43:52 -0600 | [diff] [blame] | 310 | |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 311 | class GetTargetVersionsTest(cros_test_lib.MockTestCase, ApiConfigMixin): |
| 312 | """GetTargetVersions tests.""" |
| 313 | |
| 314 | def setUp(self): |
| 315 | self.response = packages_pb2.GetTargetVersionsResponse() |
| 316 | |
| 317 | def _GetRequest(self, board=None): |
| 318 | """Helper to build out a request.""" |
| 319 | request = packages_pb2.GetTargetVersionsRequest() |
| 320 | |
| 321 | if board: |
| 322 | request.build_target.name = board |
| 323 | |
| 324 | return request |
| 325 | |
| 326 | def testValidateOnly(self): |
Alex Klein | 5a00844 | 2021-11-08 11:30:12 -0700 | [diff] [blame] | 327 | """Quick check that a validate only call does not execute any logic.""" |
| 328 | patch_version = self.PatchObject(packages_service, 'get_target_versions') |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 329 | |
| 330 | request = self._GetRequest(board='betty') |
| 331 | packages_controller.GetTargetVersions(request, self.response, |
| 332 | self.validate_only_config) |
| 333 | patch_version.assert_not_called() |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 334 | |
Michael Mortensen | 2677bf6 | 2019-10-29 08:31:25 -0600 | [diff] [blame] | 335 | def testMockCall(self): |
| 336 | """Test that a mock call does not execute logic, returns mocked value.""" |
Alex Klein | 5a00844 | 2021-11-08 11:30:12 -0700 | [diff] [blame] | 337 | patch_version = self.PatchObject(packages_service, 'get_target_versions') |
Michael Mortensen | 2677bf6 | 2019-10-29 08:31:25 -0600 | [diff] [blame] | 338 | |
| 339 | request = self._GetRequest(board='betty') |
| 340 | packages_controller.GetTargetVersions(request, self.response, |
| 341 | self.mock_call_config) |
| 342 | |
| 343 | patch_version.assert_not_called() |
Michael Mortensen | 2677bf6 | 2019-10-29 08:31:25 -0600 | [diff] [blame] | 344 | |
| 345 | self.assertTrue(self.response.android_version) |
| 346 | self.assertTrue(self.response.android_branch_version) |
| 347 | self.assertTrue(self.response.android_target_version) |
| 348 | self.assertTrue(self.response.chrome_version) |
| 349 | self.assertTrue(self.response.platform_version) |
| 350 | self.assertTrue(self.response.milestone_version) |
| 351 | self.assertTrue(self.response.full_version) |
| 352 | |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 353 | def testNoBuildTargetFails(self): |
| 354 | """No build target argument should fail.""" |
| 355 | request = self._GetRequest() |
| 356 | |
| 357 | with self.assertRaises(cros_build_lib.DieSystemExit): |
| 358 | packages_controller.GetTargetVersions(request, self.response, |
| 359 | self.api_config) |
| 360 | |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 361 | def testGetTargetVersions(self): |
| 362 | """Verify basic return values.""" |
Michael Mortensen | 1d2ab0d | 2019-10-17 13:19:25 -0600 | [diff] [blame] | 363 | # Mock that chrome is built and set the chrome_version. |
| 364 | self.PatchObject(packages_service, 'builds', return_value=True) |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 365 | chrome_version = '76.0.1.2' |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 366 | chrome_version_mock = self.PatchObject(packages_service, |
| 367 | 'determine_chrome_version', |
| 368 | return_value=chrome_version) |
Mike Frysinger | 8e1c99a | 2021-03-05 00:58:11 -0500 | [diff] [blame] | 369 | android_package = 'chromeos-base/android-container-pi-10.3' |
| 370 | self.PatchObject(packages_service, 'determine_android_package', |
| 371 | return_value=android_package) |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 372 | android_branch = 'android_test_branch' |
Alex Klein | 5a00844 | 2021-11-08 11:30:12 -0700 | [diff] [blame] | 373 | android_branch_mock = self.PatchObject( |
| 374 | packages_service, |
| 375 | 'determine_android_branch', |
| 376 | return_value=android_branch) |
Michael Mortensen | 9fdb14b | 2019-10-17 11:17:30 -0600 | [diff] [blame] | 377 | platform_version = '12345.1.2' |
| 378 | self.PatchObject(packages_service, 'determine_platform_version', |
| 379 | return_value=platform_version) |
Michael Mortensen | 009cb66 | 2019-10-21 11:38:43 -0600 | [diff] [blame] | 380 | milestone_version = '79' |
| 381 | self.PatchObject(packages_service, 'determine_milestone_version', |
| 382 | return_value=milestone_version) |
| 383 | full_version = 'R79-12345.1.2' |
| 384 | self.PatchObject(packages_service, 'determine_full_version', |
| 385 | return_value=full_version) |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 386 | request = self._GetRequest(board='betty') |
| 387 | packages_controller.GetTargetVersions(request, self.response, |
| 388 | self.api_config) |
Mike Frysinger | 8e1c99a | 2021-03-05 00:58:11 -0500 | [diff] [blame] | 389 | self.assertEqual(self.response.android_version, '10.3') |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 390 | self.assertEqual(self.response.android_branch_version, android_branch) |
Mike Frysinger | 8e1c99a | 2021-03-05 00:58:11 -0500 | [diff] [blame] | 391 | self.assertEqual(self.response.android_target_version, 'cheets') |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 392 | self.assertEqual(self.response.chrome_version, chrome_version) |
Michael Mortensen | 9fdb14b | 2019-10-17 11:17:30 -0600 | [diff] [blame] | 393 | self.assertEqual(self.response.platform_version, platform_version) |
Michael Mortensen | 009cb66 | 2019-10-21 11:38:43 -0600 | [diff] [blame] | 394 | self.assertEqual(self.response.milestone_version, milestone_version) |
| 395 | self.assertEqual(self.response.full_version, full_version) |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 396 | # Verify call to determine_chrome_version passes a build_target object. |
| 397 | build_target = build_target_lib.BuildTarget('betty') |
| 398 | chrome_version_mock.assert_called_with(build_target) |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 399 | # Verify call to determine_android_branch passes a board name. |
Alex Klein | 5a00844 | 2021-11-08 11:30:12 -0700 | [diff] [blame] | 400 | android_branch_mock.assert_called_with('betty') |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 401 | |
Michael Mortensen | 42c330e3 | 2020-09-02 09:59:16 -0600 | [diff] [blame] | 402 | def testGetTargetVersionsWithPackagesSet(self): |
| 403 | """Verify packages pass through and basic return values.""" |
| 404 | # TODO(crbug.com/1124393): Migrate this test to use portage_testables |
| 405 | # rather than mocking the boundary to portage calls such as |
| 406 | # packages_service.builds). |
| 407 | builds_mock = self.PatchObject(packages_service, 'builds', |
| 408 | return_value=True) |
| 409 | # Mock that chrome is built and set the chrome_version. |
| 410 | chrome_version = '76.0.1.2' |
| 411 | self.PatchObject(packages_service, 'determine_chrome_version', |
| 412 | return_value=chrome_version) |
Mike Frysinger | 8e1c99a | 2021-03-05 00:58:11 -0500 | [diff] [blame] | 413 | android_package = 'chromeos-base/android-container-pi-10.3' |
| 414 | self.PatchObject(packages_service, 'determine_android_package', |
| 415 | return_value=android_package) |
Michael Mortensen | 42c330e3 | 2020-09-02 09:59:16 -0600 | [diff] [blame] | 416 | android_branch = 'android_test_branch' |
| 417 | self.PatchObject(packages_service, 'determine_android_branch', |
| 418 | return_value=android_branch) |
Michael Mortensen | 42c330e3 | 2020-09-02 09:59:16 -0600 | [diff] [blame] | 419 | platform_version = '12345.1.2' |
| 420 | self.PatchObject(packages_service, 'determine_platform_version', |
| 421 | return_value=platform_version) |
| 422 | milestone_version = '79' |
| 423 | self.PatchObject(packages_service, 'determine_milestone_version', |
| 424 | return_value=milestone_version) |
| 425 | full_version = 'R79-12345.1.2' |
| 426 | self.PatchObject(packages_service, 'determine_full_version', |
| 427 | return_value=full_version) |
| 428 | request = self._GetRequest(board='betty') |
| 429 | # Add optional packages to the request. |
| 430 | cpv_package_list = [] |
| 431 | package = request.packages.add() |
| 432 | package.package_name = 'test' |
| 433 | package.category = 'chromeos-base' |
| 434 | package.version = '0.0.1-r1' |
| 435 | cpv_package_list.append(controller_util.PackageInfoToCPV(package)) |
| 436 | package = request.packages.add() |
| 437 | package.package_name = 'target-fuzzers' |
| 438 | package.category = 'virtual' |
| 439 | cpv_package_list.append(controller_util.PackageInfoToCPV(package)) |
| 440 | |
| 441 | packages_controller.GetTargetVersions(request, self.response, |
| 442 | self.api_config) |
Mike Frysinger | 8e1c99a | 2021-03-05 00:58:11 -0500 | [diff] [blame] | 443 | self.assertEqual(self.response.android_version, '10.3') |
Michael Mortensen | 42c330e3 | 2020-09-02 09:59:16 -0600 | [diff] [blame] | 444 | self.assertEqual(self.response.android_branch_version, android_branch) |
Mike Frysinger | 8e1c99a | 2021-03-05 00:58:11 -0500 | [diff] [blame] | 445 | self.assertEqual(self.response.android_target_version, 'cheets') |
Michael Mortensen | 42c330e3 | 2020-09-02 09:59:16 -0600 | [diff] [blame] | 446 | self.assertEqual(self.response.chrome_version, chrome_version) |
| 447 | self.assertEqual(self.response.platform_version, platform_version) |
| 448 | self.assertEqual(self.response.milestone_version, milestone_version) |
| 449 | # Verify call to packages.builds passes the package list. |
| 450 | builds_mock.assert_called_with(constants.CHROME_CP, |
| 451 | mock.ANY, # Match the build target object |
| 452 | packages=cpv_package_list) |
| 453 | |
Michael Mortensen | 1d2ab0d | 2019-10-17 13:19:25 -0600 | [diff] [blame] | 454 | def testGetTargetVersionNoAndroidNoChrome(self): |
Michael Mortensen | edf7653 | 2019-10-16 14:22:37 -0600 | [diff] [blame] | 455 | """Verify return values on a board that does not have android.""" |
Michael Mortensen | 9fdb14b | 2019-10-17 11:17:30 -0600 | [diff] [blame] | 456 | platform_version = '12345.1.2' |
| 457 | self.PatchObject(packages_service, 'determine_platform_version', |
| 458 | return_value=platform_version) |
Michael Mortensen | 1d2ab0d | 2019-10-17 13:19:25 -0600 | [diff] [blame] | 459 | self.PatchObject(packages_service, 'builds', return_value=False) |
Mike Frysinger | 8e1c99a | 2021-03-05 00:58:11 -0500 | [diff] [blame] | 460 | self.PatchObject(packages_service, 'determine_android_package', |
Michael Mortensen | edf7653 | 2019-10-16 14:22:37 -0600 | [diff] [blame] | 461 | return_value=None) |
| 462 | request = self._GetRequest(board='betty') |
| 463 | packages_controller.GetTargetVersions(request, self.response, |
| 464 | self.api_config) |
Michael Mortensen | 1d2ab0d | 2019-10-17 13:19:25 -0600 | [diff] [blame] | 465 | self.assertFalse(self.response.chrome_version) |
Michael Mortensen | edf7653 | 2019-10-16 14:22:37 -0600 | [diff] [blame] | 466 | self.assertFalse(self.response.android_version) |
| 467 | self.assertFalse(self.response.android_branch_version) |
| 468 | self.assertFalse(self.response.android_target_version) |
Michael Mortensen | 9fdb14b | 2019-10-17 11:17:30 -0600 | [diff] [blame] | 469 | self.assertEqual(self.response.platform_version, platform_version) |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 470 | |
Michael Mortensen | bfc5639 | 2020-04-30 15:23:47 -0600 | [diff] [blame] | 471 | |
| 472 | class GetBuilderMetadataTest(cros_test_lib.MockTestCase, ApiConfigMixin): |
| 473 | """GetBuilderMetadata tests.""" |
| 474 | |
| 475 | def setUp(self): |
| 476 | self.response = packages_pb2.GetBuilderMetadataResponse() |
| 477 | |
| 478 | def _GetRequest(self, board=None): |
| 479 | """Helper to build out a request.""" |
| 480 | request = packages_pb2.GetBuilderMetadataRequest() |
| 481 | |
| 482 | if board: |
| 483 | request.build_target.name = board |
| 484 | |
| 485 | return request |
| 486 | |
| 487 | def testValidateOnly(self): |
| 488 | """Sanity check that a validate only call does not execute any logic.""" |
| 489 | request = self._GetRequest(board='betty') |
Michael Mortensen | 76e1512 | 2020-06-03 11:07:28 -0600 | [diff] [blame] | 490 | patch_version = self.PatchObject(packages_service, |
| 491 | 'determine_android_version') |
| 492 | patch_branch_version = self.PatchObject(packages_service, |
| 493 | 'determine_android_branch') |
| 494 | patch_fw_versions = self.PatchObject(packages_service, |
| 495 | 'determine_firmware_versions') |
| 496 | patch_fingerprints = self.PatchObject(packages_service, |
| 497 | 'find_fingerprints') |
| 498 | patch_get_models = self.PatchObject(packages_service, |
| 499 | 'get_models') |
Michael Mortensen | bfc5639 | 2020-04-30 15:23:47 -0600 | [diff] [blame] | 500 | packages_controller.GetBuilderMetadata(request, self.response, |
| 501 | self.validate_only_config) |
Michael Mortensen | 76e1512 | 2020-06-03 11:07:28 -0600 | [diff] [blame] | 502 | patch_version.assert_not_called() |
| 503 | patch_branch_version.assert_not_called() |
| 504 | patch_fw_versions.assert_not_called() |
| 505 | patch_fingerprints.assert_not_called() |
| 506 | patch_get_models.assert_not_called() |
Michael Mortensen | bfc5639 | 2020-04-30 15:23:47 -0600 | [diff] [blame] | 507 | |
| 508 | def testMockCall(self): |
| 509 | """Test that a mock call does not execute logic, returns mocked value.""" |
| 510 | request = self._GetRequest(board='betty') |
Michael Mortensen | 76e1512 | 2020-06-03 11:07:28 -0600 | [diff] [blame] | 511 | patch_version = self.PatchObject(packages_service, |
| 512 | 'determine_android_version') |
| 513 | patch_branch_version = self.PatchObject(packages_service, |
| 514 | 'determine_android_branch') |
| 515 | patch_fw_versions = self.PatchObject(packages_service, |
| 516 | 'determine_firmware_versions') |
| 517 | patch_fingerprints = self.PatchObject(packages_service, |
| 518 | 'find_fingerprints') |
| 519 | patch_get_models = self.PatchObject(packages_service, |
| 520 | 'get_models') |
Michael Mortensen | bfc5639 | 2020-04-30 15:23:47 -0600 | [diff] [blame] | 521 | packages_controller.GetBuilderMetadata(request, self.response, |
| 522 | self.mock_call_config) |
Michael Mortensen | 76e1512 | 2020-06-03 11:07:28 -0600 | [diff] [blame] | 523 | patch_version.assert_not_called() |
| 524 | patch_branch_version.assert_not_called() |
| 525 | patch_fw_versions.assert_not_called() |
| 526 | patch_fingerprints.assert_not_called() |
| 527 | patch_get_models.assert_not_called() |
Michael Mortensen | bfc5639 | 2020-04-30 15:23:47 -0600 | [diff] [blame] | 528 | |
| 529 | self.assertEqual(len(self.response.build_target_metadata), 1) |
| 530 | self.assertEqual(self.response.build_target_metadata[0].build_target, |
| 531 | request.build_target.name) |
| 532 | self.assertEqual(len(self.response.model_metadata), 1) |
| 533 | self.assertTrue(self.response.model_metadata[0].model_name) |
| 534 | self.assertTrue(self.response.model_metadata[0].ec_firmware_version) |
| 535 | |
| 536 | def testNoBuildTargetFails(self): |
| 537 | """No build target argument should fail.""" |
| 538 | request = self._GetRequest() |
| 539 | |
| 540 | with self.assertRaises(cros_build_lib.DieSystemExit): |
| 541 | packages_controller.GetBuilderMetadata(request, self.response, |
| 542 | self.api_config) |
| 543 | |
Alex Klein | 2c3f168 | 2022-08-30 16:52:28 -0600 | [diff] [blame^] | 544 | def _patch_all(self, android_version, android_branch, android_target, |
| 545 | fw_versions, fingerprints): |
| 546 | """Patch everything that hasn't been broken out yet.""" |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 547 | android_version_mock = self.PatchObject(packages_service, |
| 548 | 'determine_android_version', |
| 549 | return_value=android_version) |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 550 | android_branch_mock = self.PatchObject(packages_service, |
| 551 | 'determine_android_branch', |
| 552 | return_value=android_branch) |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 553 | android_target_mock = self.PatchObject(packages_service, |
| 554 | 'determine_android_target', |
| 555 | return_value=android_target) |
Michael Mortensen | bbce7e4 | 2020-05-01 15:03:49 -0600 | [diff] [blame] | 556 | self.PatchObject(portage_util, 'GetBoardUseFlags', |
| 557 | return_value=['arc', 'arcvm', 'big_little', 'cheets']) |
Benjamin Shai | 5ce11a2 | 2022-05-06 14:10:53 +0000 | [diff] [blame] | 558 | package_result = ['sys-kernel/linux-headers-4.14-r24', |
| 559 | 'sys-devel/flex-2.6.4-r1', |
| 560 | 'sys-kernel/chromeos-kernel-4_4-4.4.223-r2209'] |
| 561 | self.PatchObject(portage_util, 'GetPackageDependencies', |
Michael Mortensen | fbf2b2d | 2020-05-14 16:33:06 -0600 | [diff] [blame] | 562 | return_value=package_result) |
| 563 | |
Alex Klein | 2c3f168 | 2022-08-30 16:52:28 -0600 | [diff] [blame^] | 564 | self.PatchObject(packages_service, 'get_firmware_versions', |
| 565 | return_value=fw_versions) |
| 566 | self.PatchObject(packages_service, 'find_fingerprints', |
| 567 | return_value=fingerprints) |
| 568 | |
| 569 | return android_version_mock, android_branch_mock, android_target_mock |
| 570 | |
| 571 | def _patch_get_all_firmware(self, all_fw_versions): |
| 572 | """Patch get_all_firmware_versions and related functions.""" |
| 573 | # Patch packages.get_models, packages.get_all_firmware_versions, |
| 574 | # and packages.get_key_id for calls needed by model_metadata. |
| 575 | model_list = list(all_fw_versions.keys()) |
| 576 | self.PatchObject(packages_service, 'get_all_firmware_versions', |
| 577 | return_value=all_fw_versions) |
| 578 | self.PatchObject(packages_service, 'get_models', |
| 579 | return_value=model_list) |
| 580 | self.PatchObject(packages_service, 'get_key_id', |
| 581 | return_value='key') |
| 582 | |
| 583 | def testNoFirmware(self): |
| 584 | """Test no firmware versions handled well.""" |
| 585 | android_version = 'android_test_version' |
| 586 | android_branch = 'android_test_branch' |
| 587 | android_target = 'android_test_target' |
| 588 | fw_versions = packages_service.FirmwareVersions( |
| 589 | None, None, None, None, None) |
| 590 | fingerprints = ['fingerprint1', 'fingerprint2'] |
| 591 | self._patch_all(android_version, android_branch, android_target, |
| 592 | fw_versions, fingerprints) |
| 593 | |
| 594 | all_fw_versions = { |
| 595 | 'pyro': packages_service.FirmwareVersions( |
| 596 | 'pyro', None, None, None, None), |
| 597 | 'reef': packages_service.FirmwareVersions( |
| 598 | 'reef', None, None, None, None), |
| 599 | } |
| 600 | self._patch_get_all_firmware(all_fw_versions) |
| 601 | |
| 602 | request = self._GetRequest(board='betty') |
| 603 | packages_controller.GetBuilderMetadata(request, self.response, |
| 604 | self.api_config) |
| 605 | |
| 606 | self.assertFalse( |
| 607 | self.response.build_target_metadata[0].main_firmware_version) |
| 608 | self.assertFalse( |
| 609 | self.response.build_target_metadata[0].ec_firmware_version) |
| 610 | |
| 611 | self.assertEqual( |
| 612 | self.response.model_metadata[0].model_name, 'pyro') |
| 613 | self.assertFalse( |
| 614 | self.response.model_metadata[0].ec_firmware_version) |
| 615 | self.assertEqual( |
| 616 | self.response.model_metadata[0].firmware_key_id, 'key') |
| 617 | self.assertFalse( |
| 618 | self.response.model_metadata[0].main_readonly_firmware_version) |
| 619 | self.assertFalse( |
| 620 | self.response.model_metadata[0].main_readwrite_firmware_version) |
| 621 | self.assertEqual( |
| 622 | self.response.model_metadata[1].model_name, 'reef') |
| 623 | self.assertFalse( |
| 624 | self.response.model_metadata[1].ec_firmware_version) |
| 625 | self.assertEqual( |
| 626 | self.response.model_metadata[1].firmware_key_id, 'key') |
| 627 | self.assertFalse( |
| 628 | self.response.model_metadata[1].main_readonly_firmware_version) |
| 629 | self.assertFalse( |
| 630 | self.response.model_metadata[1].main_readwrite_firmware_version) |
| 631 | |
| 632 | def testGetBuilderMetadata(self): |
| 633 | """Verify basic return values.""" |
| 634 | android_version = 'android_test_version' |
| 635 | android_branch = 'android_test_branch' |
| 636 | android_target = 'android_test_target' |
Michael Mortensen | a4af79e | 2020-05-06 16:18:48 -0600 | [diff] [blame] | 637 | fw_versions = packages_service.FirmwareVersions( |
| 638 | None, |
| 639 | 'Google_Caroline.7820.263.0', |
| 640 | 'Google_Caroline.7820.286.0', |
| 641 | 'caroline_v1.9.357-ac5c7b4', |
| 642 | 'caroline_v1.9.370-e8b9bd2') |
Michael Mortensen | de716a1 | 2020-05-15 11:27:00 -0600 | [diff] [blame] | 643 | fingerprints = ['fingerprint1', 'fingerprint2'] |
Alex Klein | 2c3f168 | 2022-08-30 16:52:28 -0600 | [diff] [blame^] | 644 | |
| 645 | android_version_mock, android_branch_mock, android_target_mock = ( |
| 646 | self._patch_all(android_version, android_branch, android_target, |
| 647 | fw_versions, fingerprints) |
| 648 | ) |
| 649 | |
Michael Mortensen | 770bc12 | 2020-05-27 17:53:30 -0600 | [diff] [blame] | 650 | all_fw_versions = { |
| 651 | 'pyro': packages_service.FirmwareVersions( |
| 652 | 'pyro', |
| 653 | 'Google_Pyro.9042.87.1', |
| 654 | 'Google_Pyro.9042.110.0', |
| 655 | 'pyro_v1.1.5900-ab1ee51', |
| 656 | 'pyro_v1.1.5909-bd1f0c9'), |
| 657 | 'reef': packages_service.FirmwareVersions( |
| 658 | 'reef', |
| 659 | 'Google_Reef.9042.87.1', |
| 660 | 'Google_Reef.9042.110.0', |
| 661 | 'reef_v1.1.5900-ab1ee51', |
| 662 | 'reef_v1.1.5909-bd1f0c9') |
| 663 | } |
Alex Klein | 2c3f168 | 2022-08-30 16:52:28 -0600 | [diff] [blame^] | 664 | self._patch_get_all_firmware(all_fw_versions) |
Michael Mortensen | 770bc12 | 2020-05-27 17:53:30 -0600 | [diff] [blame] | 665 | |
Michael Mortensen | bbce7e4 | 2020-05-01 15:03:49 -0600 | [diff] [blame] | 666 | request = self._GetRequest(board='betty') |
| 667 | packages_controller.GetBuilderMetadata(request, self.response, |
| 668 | self.api_config) |
| 669 | self.assertEqual( |
| 670 | self.response.build_target_metadata[0].build_target, |
| 671 | 'betty') |
| 672 | self.assertEqual( |
| 673 | self.response.build_target_metadata[0].android_container_version, |
| 674 | android_version) |
| 675 | self.assertEqual( |
| 676 | self.response.build_target_metadata[0].android_container_branch, |
| 677 | android_branch) |
| 678 | self.assertEqual( |
| 679 | self.response.build_target_metadata[0].android_container_target, |
| 680 | android_target) |
| 681 | self.assertEqual( |
| 682 | self.response.build_target_metadata[0].arc_use_set, |
| 683 | True) |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 684 | # Verify call to determine_android_version passes list of the board name. |
Mike Frysinger | b53f182 | 2021-03-05 00:44:50 -0500 | [diff] [blame] | 685 | android_version_mock.assert_called_with('betty') |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 686 | # Verify call to determine_android_branch passes board name. |
| 687 | android_branch_mock.assert_called_with('betty') |
| 688 | # Verify call to determine_android_target passes board name. |
| 689 | android_target_mock.assert_called_with('betty') |
Michael Mortensen | a4af79e | 2020-05-06 16:18:48 -0600 | [diff] [blame] | 690 | self.assertEqual( |
| 691 | self.response.build_target_metadata[0].main_firmware_version, |
| 692 | 'Google_Caroline.7820.286.0') |
| 693 | self.assertEqual( |
| 694 | self.response.build_target_metadata[0].ec_firmware_version, |
| 695 | 'caroline_v1.9.370-e8b9bd2') |
Michael Mortensen | fbf2b2d | 2020-05-14 16:33:06 -0600 | [diff] [blame] | 696 | self.assertEqual( |
| 697 | self.response.build_target_metadata[0].kernel_version, |
| 698 | '4.4.223-r2209') |
Michael Mortensen | de716a1 | 2020-05-15 11:27:00 -0600 | [diff] [blame] | 699 | self.assertEqual( |
| 700 | len(self.response.build_target_metadata[0].fingerprints), |
| 701 | 2) |
| 702 | self.assertEqual( |
| 703 | self.response.build_target_metadata[0].fingerprints, |
| 704 | fingerprints) |
Michael Mortensen | 770bc12 | 2020-05-27 17:53:30 -0600 | [diff] [blame] | 705 | self.assertEqual( |
| 706 | len(self.response.model_metadata), 2) |
| 707 | self.assertEqual( |
| 708 | self.response.model_metadata[0].model_name, 'pyro') |
| 709 | self.assertEqual( |
| 710 | self.response.model_metadata[0].ec_firmware_version, |
| 711 | 'pyro_v1.1.5909-bd1f0c9') |
| 712 | self.assertEqual( |
| 713 | self.response.model_metadata[0].firmware_key_id, 'key') |
| 714 | self.assertEqual( |
| 715 | self.response.model_metadata[0].main_readonly_firmware_version, |
| 716 | 'Google_Pyro.9042.87.1') |
| 717 | self.assertEqual( |
| 718 | self.response.model_metadata[0].main_readwrite_firmware_version, |
| 719 | 'Google_Pyro.9042.110.0') |
| 720 | self.assertEqual( |
| 721 | self.response.model_metadata[1].model_name, 'reef') |
| 722 | self.assertEqual( |
| 723 | self.response.model_metadata[1].ec_firmware_version, |
| 724 | 'reef_v1.1.5909-bd1f0c9') |
| 725 | self.assertEqual( |
| 726 | self.response.model_metadata[1].firmware_key_id, 'key') |
| 727 | self.assertEqual( |
| 728 | self.response.model_metadata[1].main_readonly_firmware_version, |
| 729 | 'Google_Reef.9042.87.1') |
| 730 | self.assertEqual( |
| 731 | self.response.model_metadata[1].main_readwrite_firmware_version, |
| 732 | 'Google_Reef.9042.110.0') |
Michael Mortensen | bbce7e4 | 2020-05-01 15:03:49 -0600 | [diff] [blame] | 733 | |
Michael Mortensen | d81d81e | 2020-06-09 14:20:59 -0600 | [diff] [blame] | 734 | # Test corner case where find_fingerprints returns None. |
| 735 | # Re-patch find_fingerprints to now return None and re-execute |
| 736 | # GetBuilderMetadata to verify behavior. |
| 737 | response = packages_pb2.GetBuilderMetadataResponse() |
| 738 | self.PatchObject(packages_service, 'find_fingerprints', |
| 739 | return_value=[]) |
| 740 | request = self._GetRequest(board='betty') |
| 741 | packages_controller.GetBuilderMetadata(request, response, |
| 742 | self.api_config) |
| 743 | # Verify a non-fingerprint build_target_metdata field was still set. |
| 744 | self.assertEqual( |
| 745 | response.build_target_metadata[0].kernel_version, |
| 746 | '4.4.223-r2209') |
| 747 | # And then verify that fingerprints was empty. |
| 748 | self.assertEqual(response.build_target_metadata[0].fingerprints, []) |
| 749 | |
Michael Mortensen | bbce7e4 | 2020-05-01 15:03:49 -0600 | [diff] [blame] | 750 | |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 751 | class HasChromePrebuiltTest(cros_test_lib.MockTestCase, ApiConfigMixin): |
| 752 | """HasChromePrebuilt tests.""" |
| 753 | |
| 754 | def setUp(self): |
| 755 | self.response = packages_pb2.HasChromePrebuiltResponse() |
| 756 | |
| 757 | def _GetRequest(self, board=None): |
| 758 | """Helper to build out a request.""" |
| 759 | request = packages_pb2.HasChromePrebuiltRequest() |
| 760 | |
| 761 | if board: |
| 762 | request.build_target.name = board |
| 763 | |
| 764 | return request |
| 765 | |
| 766 | def testValidateOnly(self): |
| 767 | """Sanity check that a validate only call does not execute any logic.""" |
| 768 | patch = self.PatchObject(packages_service, 'has_prebuilt') |
| 769 | |
| 770 | request = self._GetRequest(board='betty') |
| 771 | packages_controller.HasChromePrebuilt(request, self.response, |
| 772 | self.validate_only_config) |
| 773 | patch.assert_not_called() |
| 774 | |
Michael Mortensen | 3232ab3 | 2020-01-05 19:14:36 -0700 | [diff] [blame] | 775 | def testMockCall(self): |
| 776 | """Test that a mock call does not execute logic, returns mocked value.""" |
| 777 | patch = self.PatchObject(packages_service, 'has_prebuilt') |
| 778 | |
| 779 | request = self._GetRequest(board='betty') |
| 780 | packages_controller.HasChromePrebuilt(request, self.response, |
| 781 | self.mock_call_config) |
| 782 | patch.assert_not_called() |
| 783 | self.assertTrue(self.response.has_prebuilt) |
| 784 | |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 785 | def testNoBuildTargetFails(self): |
| 786 | """No build target argument should fail.""" |
| 787 | request = self._GetRequest() |
| 788 | |
| 789 | with self.assertRaises(cros_build_lib.DieSystemExit): |
| 790 | packages_controller.HasChromePrebuilt(request, self.response, |
| 791 | self.api_config) |
Alex Klein | 73fb657 | 2019-09-30 16:55:23 -0600 | [diff] [blame] | 792 | |
| 793 | |
| 794 | class BuildsChromeTest(cros_test_lib.MockTestCase, ApiConfigMixin): |
| 795 | """BuildsChrome tests.""" |
| 796 | |
| 797 | def setUp(self): |
| 798 | self.response = packages_pb2.BuildsChromeResponse() |
| 799 | |
David Burger | 0f9dd4e | 2019-10-08 12:33:42 -0600 | [diff] [blame] | 800 | def _GetRequest(self, board=None, packages=None): |
Alex Klein | 73fb657 | 2019-09-30 16:55:23 -0600 | [diff] [blame] | 801 | """Helper to build out a request.""" |
| 802 | request = packages_pb2.BuildsChromeRequest() |
| 803 | |
| 804 | if board: |
| 805 | request.build_target.name = board |
| 806 | |
David Burger | 0f9dd4e | 2019-10-08 12:33:42 -0600 | [diff] [blame] | 807 | if packages: |
| 808 | request.packages.extend(packages) |
| 809 | |
Alex Klein | 73fb657 | 2019-09-30 16:55:23 -0600 | [diff] [blame] | 810 | return request |
| 811 | |
| 812 | def testValidateOnly(self): |
| 813 | """Sanity check that a validate only call does not execute any logic.""" |
Alex Klein | e65131f | 2019-10-03 10:34:01 -0600 | [diff] [blame] | 814 | patch = self.PatchObject(packages_service, 'builds') |
Alex Klein | 73fb657 | 2019-09-30 16:55:23 -0600 | [diff] [blame] | 815 | |
| 816 | request = self._GetRequest(board='betty') |
| 817 | packages_controller.BuildsChrome(request, self.response, |
| 818 | self.validate_only_config) |
| 819 | patch.assert_not_called() |
| 820 | |
| 821 | def testNoBuildTargetFails(self): |
| 822 | """No build target argument should fail.""" |
| 823 | request = self._GetRequest() |
| 824 | |
| 825 | with self.assertRaises(cros_build_lib.DieSystemExit): |
| 826 | packages_controller.BuildsChrome(request, self.response, self.api_config) |
Alex Klein | e65131f | 2019-10-03 10:34:01 -0600 | [diff] [blame] | 827 | |
| 828 | def testBuilds(self): |
| 829 | """Test successful call handling.""" |
| 830 | patch = self.PatchObject(packages_service, 'builds', return_value=True) |
| 831 | |
| 832 | request = self._GetRequest(board='foo') |
| 833 | packages_controller.BuildsChrome(request, self.response, self.api_config) |
| 834 | self.assertTrue(self.response.builds_chrome) |
Alex Klein | 26e472b | 2020-03-10 14:35:01 -0600 | [diff] [blame] | 835 | patch.assert_called_once_with(constants.CHROME_CP, |
| 836 | build_target_lib.BuildTarget('foo'), []) |
David Burger | 0f9dd4e | 2019-10-08 12:33:42 -0600 | [diff] [blame] | 837 | |
| 838 | def testBuildsChromeWithPackages(self): |
| 839 | """Test successful call with packages handling.""" |
| 840 | patch = self.PatchObject(packages_service, 'builds', return_value=True) |
| 841 | |
| 842 | package = common_pb2.PackageInfo( |
| 843 | category='category', |
| 844 | package_name='name', |
| 845 | version='1.01', |
| 846 | ) |
| 847 | request = self._GetRequest(board='foo', packages=[package]) |
| 848 | packages_controller.BuildsChrome(request, self.response, self.api_config) |
| 849 | self.assertTrue(self.response.builds_chrome) |
Alex Klein | 26e472b | 2020-03-10 14:35:01 -0600 | [diff] [blame] | 850 | patch.assert_called_once_with(constants.CHROME_CP, |
| 851 | build_target_lib.BuildTarget('foo'), |
David Burger | 0f9dd4e | 2019-10-08 12:33:42 -0600 | [diff] [blame] | 852 | [controller_util.PackageInfoToCPV(package)]) |
Shao-Chuan Lee | eb834a3 | 2021-05-12 17:10:55 +0900 | [diff] [blame] | 853 | |
| 854 | |
Alex Klein | 9ce3f68 | 2021-06-23 15:06:44 -0600 | [diff] [blame] | 855 | class NeedsChromeSourceTest(cros_test_lib.MockTempDirTestCase, ApiConfigMixin): |
| 856 | """NeedsChromeSource tests.""" |
| 857 | |
| 858 | def setUp(self): |
| 859 | self.response = packages_pb2.NeedsChromeSourceResponse() |
| 860 | |
| 861 | self.board = 'board' |
| 862 | self.sysroot = self.tempdir |
| 863 | |
| 864 | def _GetRequest(self, compile_source=False): |
| 865 | """Helper to build a request.""" |
| 866 | request = packages_pb2.NeedsChromeSourceRequest() |
| 867 | |
Mike Frysinger | 3bb61cb | 2022-04-14 16:07:44 -0400 | [diff] [blame] | 868 | request.install_request.sysroot.path = str(self.sysroot) |
Alex Klein | 9ce3f68 | 2021-06-23 15:06:44 -0600 | [diff] [blame] | 869 | request.install_request.sysroot.build_target.name = self.board |
| 870 | request.install_request.flags.compile_source = compile_source |
| 871 | |
| 872 | return request |
| 873 | |
| 874 | def testAll(self): |
| 875 | """Reason translation test.""" |
| 876 | result = packages_service.NeedsChromeSourceResult( |
| 877 | needs_chrome_source=True, |
| 878 | builds_chrome=True, |
| 879 | packages=[package_info.parse('cat/pkg')], |
| 880 | missing_chrome_prebuilt=True, |
| 881 | missing_follower_prebuilt=True, |
| 882 | local_uprev=True, |
| 883 | ) |
| 884 | self.PatchObject(packages_service, 'needs_chrome_source', |
| 885 | return_value=result) |
| 886 | |
| 887 | packages_controller.NeedsChromeSource(self._GetRequest(compile_source=True), |
| 888 | self.response, |
| 889 | self.api_config) |
| 890 | |
| 891 | self.assertIn(packages_pb2.NeedsChromeSourceResponse.COMPILE_SOURCE, |
| 892 | self.response.reasons) |
| 893 | self.assertIn(packages_pb2.NeedsChromeSourceResponse.LOCAL_UPREV, |
| 894 | self.response.reasons) |
| 895 | self.assertIn(packages_pb2.NeedsChromeSourceResponse.NO_PREBUILT, |
| 896 | self.response.reasons) |
| 897 | self.assertIn( |
| 898 | packages_pb2.NeedsChromeSourceResponse.FOLLOWER_LACKS_PREBUILT, |
| 899 | self.response.reasons) |
| 900 | self.assertIn(packages_pb2.NeedsChromeSourceResponse.COMPILE_SOURCE, |
| 901 | self.response.reasons) |
| 902 | self.assertIn(packages_pb2.NeedsChromeSourceResponse.COMPILE_SOURCE, |
| 903 | self.response.reasons) |
| 904 | |
| 905 | self.assertEqual(1, len(self.response.packages)) |
| 906 | self.assertEqual(('cat', 'pkg'), (self.response.packages[0].category, |
| 907 | self.response.packages[0].package_name)) |
| 908 | |
| 909 | |
Shao-Chuan Lee | eb834a3 | 2021-05-12 17:10:55 +0900 | [diff] [blame] | 910 | class GetAndroidMetadataTest(cros_test_lib.MockTestCase, ApiConfigMixin): |
| 911 | """GetAndroidMetadata tests.""" |
| 912 | |
| 913 | def setUp(self): |
| 914 | self.response = packages_pb2.GetAndroidMetadataResponse() |
| 915 | |
| 916 | def _GetRequest(self, board=None): |
| 917 | """Helper to build out a request.""" |
| 918 | request = packages_pb2.GetAndroidMetadataRequest() |
| 919 | |
| 920 | if board: |
| 921 | request.build_target.name = board |
| 922 | |
| 923 | return request |
| 924 | |
| 925 | def testValidateOnly(self): |
| 926 | """Check that a validate only call does not execute any logic.""" |
| 927 | package_mock = self.PatchObject(packages_service, |
| 928 | 'determine_android_package') |
| 929 | branch_mock = self.PatchObject(packages_service, |
| 930 | 'determine_android_branch') |
| 931 | version_mock = self.PatchObject(packages_service, |
| 932 | 'determine_android_version') |
| 933 | |
| 934 | request = self._GetRequest(board='betty') |
| 935 | packages_controller.GetAndroidMetadata(request, self.response, |
| 936 | self.validate_only_config) |
| 937 | |
| 938 | package_mock.assert_not_called() |
| 939 | branch_mock.assert_not_called() |
| 940 | version_mock.assert_not_called() |
| 941 | |
| 942 | def testMockCall(self): |
| 943 | """Test that a mock call does not execute logic, returns mocked value.""" |
| 944 | package_mock = self.PatchObject(packages_service, |
| 945 | 'determine_android_package') |
| 946 | branch_mock = self.PatchObject(packages_service, |
| 947 | 'determine_android_branch') |
| 948 | version_mock = self.PatchObject(packages_service, |
| 949 | 'determine_android_version') |
| 950 | |
| 951 | request = self._GetRequest(board='betty') |
| 952 | packages_controller.GetAndroidMetadata(request, self.response, |
| 953 | self.mock_call_config) |
| 954 | |
| 955 | package_mock.assert_not_called() |
| 956 | branch_mock.assert_not_called() |
| 957 | version_mock.assert_not_called() |
| 958 | |
| 959 | self.assertTrue(self.response.android_package) |
| 960 | self.assertTrue(self.response.android_branch) |
| 961 | self.assertTrue(self.response.android_version) |
| 962 | |
| 963 | def testNoBuildTargetFails(self): |
| 964 | """No build target argument should fail.""" |
| 965 | request = self._GetRequest() |
| 966 | with self.assertRaises(cros_build_lib.DieSystemExit): |
| 967 | packages_controller.GetAndroidMetadata(request, self.response, |
| 968 | self.api_config) |
| 969 | |
| 970 | def testSuccess(self): |
| 971 | """Test a successful call.""" |
| 972 | board = 'betty' |
| 973 | package = 'android-package' |
| 974 | branch = 'android-branch' |
| 975 | version = '7123456' |
| 976 | full_package = f'chromeos-base/{package}-{version}-r1' |
| 977 | |
| 978 | package_mock = self.PatchObject(packages_service, |
| 979 | 'determine_android_package', |
| 980 | return_value=full_package) |
| 981 | branch_mock = self.PatchObject(packages_service, |
| 982 | 'determine_android_branch', |
| 983 | return_value=branch) |
| 984 | version_mock = self.PatchObject(packages_service, |
| 985 | 'determine_android_version', |
| 986 | return_value=version) |
| 987 | |
| 988 | request = self._GetRequest(board=board) |
| 989 | packages_controller.GetAndroidMetadata(request, self.response, |
| 990 | self.api_config) |
| 991 | |
| 992 | package_mock.assert_called_once_with(board) |
| 993 | branch_mock.assert_called_once_with(board, package=full_package) |
| 994 | version_mock.assert_called_once_with(board, package=full_package) |
| 995 | |
| 996 | self.assertEqual(self.response.android_package, package) |
| 997 | self.assertEqual(self.response.android_branch, branch) |
| 998 | self.assertEqual(self.response.android_version, version) |
| 999 | |
| 1000 | def testNoAndroid(self): |
| 1001 | """Test returns an empty response if given board has no Android.""" |
| 1002 | board = 'betty' |
| 1003 | |
| 1004 | package_mock = self.PatchObject(packages_service, |
| 1005 | 'determine_android_package', |
| 1006 | return_value=None) |
| 1007 | branch_mock = self.PatchObject(packages_service, |
| 1008 | 'determine_android_branch') |
| 1009 | version_mock = self.PatchObject(packages_service, |
| 1010 | 'determine_android_version') |
| 1011 | |
| 1012 | request = self._GetRequest(board=board) |
| 1013 | packages_controller.GetAndroidMetadata(request, self.response, |
| 1014 | self.api_config) |
| 1015 | |
| 1016 | package_mock.assert_called_once_with(board) |
| 1017 | branch_mock.assert_not_called() |
| 1018 | version_mock.assert_not_called() |
| 1019 | |
| 1020 | self.assertFalse(self.response.android_package) |
| 1021 | self.assertFalse(self.response.android_branch) |
| 1022 | self.assertFalse(self.response.android_version) |