Handle android branch/target/version for boards without android.
BUG=chromium:1015034
TEST=manual, run_tests
Change-Id: I83d15ab98fabf7bd1091745c1fbae117d96a40fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1865693
Reviewed-by: Alex Klein <saklein@chromium.org>
Tested-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Michael Mortensen <mmortensen@google.com>
diff --git a/api/controller/packages_unittest.py b/api/controller/packages_unittest.py
index ea51a56..09e64c5 100644
--- a/api/controller/packages_unittest.py
+++ b/api/controller/packages_unittest.py
@@ -294,6 +294,24 @@
self.assertEqual(self.response.android_target_version, android_target)
self.assertEqual(self.response.chrome_version, chrome_version)
+ def testGetTargetVersionNoAndroid(self):
+ """Verify return values on a board that does not have android."""
+ chrome_version = '76.0.1.2'
+ self.PatchObject(packages_service, 'determine_chrome_version',
+ return_value=chrome_version)
+ self.PatchObject(packages_service, 'determine_android_version',
+ return_value=None)
+ self.PatchObject(packages_service, 'determine_android_branch',
+ return_value=None)
+ self.PatchObject(packages_service, 'determine_android_target',
+ return_value=None)
+ request = self._GetRequest(board='betty')
+ packages_controller.GetTargetVersions(request, self.response,
+ self.api_config)
+ self.assertEqual(self.response.chrome_version, chrome_version)
+ self.assertFalse(self.response.android_version)
+ self.assertFalse(self.response.android_branch_version)
+ self.assertFalse(self.response.android_target_version)
class HasChromePrebuiltTest(cros_test_lib.MockTestCase, ApiConfigMixin):
"""HasChromePrebuilt tests."""