commit 5a00844079c49ec046d1837a244760263e9a7788
author Alex Klein <saklein@chromium.org> Mon Nov 08 11:30:12 2021 -0700
committer Commit Bot <commit-bot@chromium.org> Mon Nov 15 23:39:48 2021 +0000
tree cfea94715b3c833703c2d72352b75b4eb3c27ca2
parent 68a2871bcb131e08ebe3fee9b3edd1ce787b5fc9

controller/packages: Simplify GetTargetVersions.

Simplify the controller function to only do input/output
translation, using the new service method instead.

BUG=b:194405049
TEST=run_tests

Change-Id: I83fffe7ac79534df2d474b083681e1783ee55fe8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/3273762
Tested-by: Alex Klein <saklein@chromium.org>
Commit-Queue: Alex Klein <saklein@chromium.org>
Reviewed-by: Sergey Frolov <sfrolov@google.com>

api/controller/packages_unittest.py

diff --git a/api/controller/packages_unittest.py b/api/controller/packages_unittest.py
index 7834b24..42c8434 100644
--- a/api/controller/packages_unittest.py
+++ b/api/controller/packages_unittest.py
@@ -324,67 +324,23 @@
     return request
 
   def testValidateOnly(self):
-    """Sanity check that a validate only call does not execute any logic."""
-    builds_chrome = self.PatchObject(
-        packages_service, 'builds', return_value=True)
-    patch_version = self.PatchObject(packages_service,
-                                     'determine_android_version')
-    patch_branch_version = self.PatchObject(packages_service,
-                                            'determine_android_branch')
-    patch_target_version = self.PatchObject(packages_service,
-                                            'determine_android_target')
-    chrome_version = self.PatchObject(packages_service,
-                                      'determine_chrome_version')
-    platform_version = self.PatchObject(packages_service,
-                                        'determine_platform_version')
-    milestone_version = self.PatchObject(packages_service,
-                                         'determine_milestone_version')
-    full_version = self.PatchObject(packages_service,
-                                    'determine_full_version')
+    """Quick check that a validate only call does not execute any logic."""
+    patch_version = self.PatchObject(packages_service, 'get_target_versions')
 
     request = self._GetRequest(board='betty')
     packages_controller.GetTargetVersions(request, self.response,
                                           self.validate_only_config)
     patch_version.assert_not_called()
-    patch_branch_version.assert_not_called()
-    patch_target_version.assert_not_called()
-    builds_chrome.assert_not_called()
-    chrome_version.assert_not_called()
-    platform_version.assert_not_called()
-    milestone_version.assert_not_called()
-    full_version.assert_not_called()
 
   def testMockCall(self):
     """Test that a mock call does not execute logic, returns mocked value."""
-    builds_chrome = self.PatchObject(
-        packages_service, 'builds', return_value=True)
-    patch_version = self.PatchObject(packages_service,
-                                     'determine_android_version')
-    patch_branch_version = self.PatchObject(packages_service,
-                                            'determine_android_branch')
-    patch_target_version = self.PatchObject(packages_service,
-                                            'determine_android_target')
-    chrome_version = self.PatchObject(packages_service,
-                                      'determine_chrome_version')
-    platform_version = self.PatchObject(packages_service,
-                                        'determine_platform_version')
-    milestone_version = self.PatchObject(packages_service,
-                                         'determine_milestone_version')
-    full_version = self.PatchObject(packages_service,
-                                    'determine_full_version')
+    patch_version = self.PatchObject(packages_service, 'get_target_versions')
 
     request = self._GetRequest(board='betty')
     packages_controller.GetTargetVersions(request, self.response,
                                           self.mock_call_config)
 
     patch_version.assert_not_called()
-    patch_branch_version.assert_not_called()
-    patch_target_version.assert_not_called()
-    builds_chrome.assert_not_called()
-    chrome_version.assert_not_called()
-    platform_version.assert_not_called()
-    milestone_version.assert_not_called()
-    full_version.assert_not_called()
 
     self.assertTrue(self.response.android_version)
     self.assertTrue(self.response.android_branch_version)
@@ -414,9 +370,10 @@
     self.PatchObject(packages_service, 'determine_android_package',
                      return_value=android_package)
     android_branch = 'android_test_branch'
-    android_branch_mock = self.PatchObject(packages_service,
-                                           'determine_android_branch',
-                                           return_value=android_branch)
+    android_branch_mock = self.PatchObject(
+        packages_service,
+        'determine_android_branch',
+        return_value=android_branch)
     platform_version = '12345.1.2'
     self.PatchObject(packages_service, 'determine_platform_version',
                      return_value=platform_version)
@@ -440,7 +397,7 @@
     build_target = build_target_lib.BuildTarget('betty')
     chrome_version_mock.assert_called_with(build_target)
     # Verify call to determine_android_branch passes a board name.
-    android_branch_mock.assert_called_with('betty', package=android_package)
+    android_branch_mock.assert_called_with('betty')
 
   def testGetTargetVersionsWithPackagesSet(self):
     """Verify packages pass through and basic return values."""