commit 76e1512ba3183b0e0ce73ef4a96cfc0d66ee8dc7
author Michael Mortensen <mmortensen@google.com> Wed Jun 03 11:07:28 2020 -0600
committer Commit Bot <commit-bot@chromium.org> Wed Jun 03 18:07:30 2020 +0000
tree b29b91e0faf7485671e2298c6b3903974f3733f5
parent 652a2a7daf55dee6410dfb7b618eb8149b09ca2b

BuildAPI: update packages.testMockCall for GetBuilderMetadata.

BUG=chromium:1071620
TEST=manual, run_tests

Change-Id: I848f5074085697f80d354f65a4b1e5fc47218386
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/2228143
Tested-by: Michael Mortensen <mmortensen@google.com>
Reviewed-by: Alex Klein <saklein@chromium.org>
Commit-Queue: Michael Mortensen <mmortensen@google.com>

api/controller/packages_unittest.py

diff --git a/api/controller/packages_unittest.py b/api/controller/packages_unittest.py
index 2d76a2e..db1571e 100644
--- a/api/controller/packages_unittest.py
+++ b/api/controller/packages_unittest.py
@@ -507,16 +507,44 @@
   def testValidateOnly(self):
     """Sanity check that a validate only call does not execute any logic."""
     request = self._GetRequest(board='betty')
-    # TODO(crbug/1071620): Add/check mock for service layer calls.
+    patch_version = self.PatchObject(packages_service,
+                                     'determine_android_version')
+    patch_branch_version = self.PatchObject(packages_service,
+                                            'determine_android_branch')
+    patch_fw_versions = self.PatchObject(packages_service,
+                                         'determine_firmware_versions')
+    patch_fingerprints = self.PatchObject(packages_service,
+                                          'find_fingerprints')
+    patch_get_models = self.PatchObject(packages_service,
+                                        'get_models')
     packages_controller.GetBuilderMetadata(request, self.response,
                                            self.validate_only_config)
+    patch_version.assert_not_called()
+    patch_branch_version.assert_not_called()
+    patch_fw_versions.assert_not_called()
+    patch_fingerprints.assert_not_called()
+    patch_get_models.assert_not_called()
 
   def testMockCall(self):
     """Test that a mock call does not execute logic, returns mocked value."""
     request = self._GetRequest(board='betty')
-    # TODO(crbug/1071620): Add/check mock for service layer calls.
+    patch_version = self.PatchObject(packages_service,
+                                     'determine_android_version')
+    patch_branch_version = self.PatchObject(packages_service,
+                                            'determine_android_branch')
+    patch_fw_versions = self.PatchObject(packages_service,
+                                         'determine_firmware_versions')
+    patch_fingerprints = self.PatchObject(packages_service,
+                                          'find_fingerprints')
+    patch_get_models = self.PatchObject(packages_service,
+                                        'get_models')
     packages_controller.GetBuilderMetadata(request, self.response,
                                            self.mock_call_config)
+    patch_version.assert_not_called()
+    patch_branch_version.assert_not_called()
+    patch_fw_versions.assert_not_called()
+    patch_fingerprints.assert_not_called()
+    patch_get_models.assert_not_called()
 
     self.assertEqual(len(self.response.build_target_metadata), 1)
     self.assertEqual(self.response.build_target_metadata[0].build_target,