commit 2677bf6cf3de02c9838d3d846abb06cbfd3c27c8
author Michael Mortensen <mmortensen@google.com> Tue Oct 29 08:31:25 2019 -0600
committer Commit Bot <commit-bot@chromium.org> Tue Oct 29 21:50:49 2019 +0000
tree ded2f7d94cb577f05b6b09487886f56d9d65a5ed
parent 417bd662d425c696ce6e6b67331024716c1fbdad

BuildAPI: Finish Package Mock responses.

BUG=chromium:1000854
TEST=run_tests

Change-Id: Ifa23018b44889ab0492602a69378a194d9e8ca43
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1887310
Tested-by: Michael Mortensen <mmortensen@google.com>
Reviewed-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Michael Mortensen <mmortensen@google.com>

api/controller/packages_unittest.py

diff --git a/api/controller/packages_unittest.py b/api/controller/packages_unittest.py
index d89a53f..85fb125 100644
--- a/api/controller/packages_unittest.py
+++ b/api/controller/packages_unittest.py
@@ -51,6 +51,15 @@
     packages_controller.Uprev(request, self.response, self.validate_only_config)
     patch.assert_not_called()
 
+  def testMockCall(self):
+    """Test that a mock call does not execute logic, returns mocked value."""
+    patch = self.PatchObject(packages_service, 'uprev_build_targets')
+    targets = ['foo', 'bar']
+    request = self._GetRequest(targets=targets, overlay_type=self._BOTH)
+    packages_controller.Uprev(request, self.response, self.mock_call_config)
+    patch.assert_not_called()
+    self.assertTrue(self.response.modified_ebuilds)
+
   def testNoOverlayTypeFails(self):
     """No overlay type provided should fail."""
     request = self._GetRequest(targets=['foo'])
@@ -118,6 +127,16 @@
 
     service.assert_not_called()
 
+  def testMockCall(self):
+    """Test that a mock call does not execute logic, returns mocked value."""
+    patch = self.PatchObject(packages_service, 'uprev_versioned_package')
+    request = packages_pb2.UprevVersionedPackageRequest()
+    packages_controller.UprevVersionedPackage(request, self.response,
+                                              self.mock_call_config)
+    patch.assert_not_called()
+    self.assertTrue(self.response.responses)
+    self.assertTrue(self.response.responses[0].modified_ebuilds)
+
   def testNoVersions(self):
     """Test no versions provided."""
     request = packages_pb2.UprevVersionedPackageRequest()
@@ -208,6 +227,18 @@
                                        self.validate_only_config)
     patch.assert_not_called()
 
+  def testMockCall(self):
+    """Test that a mock call does not execute logic, returns mocked value."""
+    patch = self.PatchObject(packages_service, 'get_best_visible')
+    request = self._GetRequest(atom='chromeos-chrome')
+    packages_controller.GetBestVisible(request, self.response,
+                                       self.mock_call_config)
+    patch.assert_not_called()
+    self.assertTrue(self.response.package_info)
+    self.assertTrue(self.response.package_info.category)
+    self.assertTrue(self.response.package_info.package_name)
+    self.assertTrue(self.response.package_info.version)
+
   def testNoAtomFails(self):
     """No atom provided should fail."""
     request = self._GetRequest()
@@ -321,6 +352,46 @@
     milestone_version.assert_not_called()
     full_version.assert_not_called()
 
+  def testMockCall(self):
+    """Test that a mock call does not execute logic, returns mocked value."""
+    builds_chrome = self.PatchObject(
+        packages_service, 'builds', return_value=True)
+    patch_version = self.PatchObject(packages_service,
+                                     'determine_android_version')
+    patch_branch_version = self.PatchObject(packages_service,
+                                            'determine_android_branch')
+    patch_target_version = self.PatchObject(packages_service,
+                                            'determine_android_target')
+    chrome_version = self.PatchObject(packages_service,
+                                      'determine_chrome_version')
+    platform_version = self.PatchObject(packages_service,
+                                        'determine_platform_version')
+    milestone_version = self.PatchObject(packages_service,
+                                         'determine_milestone_version')
+    full_version = self.PatchObject(packages_service,
+                                    'determine_full_version')
+
+    request = self._GetRequest(board='betty')
+    packages_controller.GetTargetVersions(request, self.response,
+                                          self.mock_call_config)
+
+    patch_version.assert_not_called()
+    patch_branch_version.assert_not_called()
+    patch_target_version.assert_not_called()
+    builds_chrome.assert_not_called()
+    chrome_version.assert_not_called()
+    platform_version.assert_not_called()
+    milestone_version.assert_not_called()
+    full_version.assert_not_called()
+
+    self.assertTrue(self.response.android_version)
+    self.assertTrue(self.response.android_branch_version)
+    self.assertTrue(self.response.android_target_version)
+    self.assertTrue(self.response.chrome_version)
+    self.assertTrue(self.response.platform_version)
+    self.assertTrue(self.response.milestone_version)
+    self.assertTrue(self.response.full_version)
+
   def testNoBuildTargetFails(self):
     """No build target argument should fail."""
     request = self._GetRequest()