UprevVersionedPackage: Add new version to output.
BUG=chromium:996890
TEST=run_tests
Change-Id: Ifd4ea7cdc8ff1187b294ccd07d4b7caa92427b32
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1766666
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Evan Hernandez <evanhernandez@chromium.org>
Commit-Queue: Alex Klein <saklein@chromium.org>
diff --git a/api/controller/packages_unittest.py b/api/controller/packages_unittest.py
index 93a547f..56db4ab 100644
--- a/api/controller/packages_unittest.py
+++ b/api/controller/packages_unittest.py
@@ -99,7 +99,7 @@
"""Helper method to add a full version message to the request."""
ref = request.versions.add()
ref.repository = '/some/path'
- ref.ref = version
+ ref.ref = 'refs/tags/%s' % version
ref.revision = 'abc123'
def testValidateOnly(self):
@@ -148,20 +148,24 @@
def testOutputHandling(self):
"""Test the modified files are getting correctly added to the output."""
- result = ['/file/one', '/file/two']
- self.PatchObject(packages_service, 'uprev_versioned_package',
- return_value=result)
+ version = '1.2.3.4'
+ result = packages_service.UprevVersionedPackageResult(
+ version, ['/file/one', '/file/two'])
+ self.PatchObject(
+ packages_service, 'uprev_versioned_package', return_value=result)
request = packages_pb2.UprevVersionedPackageRequest()
- self._addVersion(request, '1.2.3.4')
+ self._addVersion(request, version)
request.package_info.category = 'chromeos-base'
request.package_info.package_name = 'chromeos-chrome'
packages_controller.UprevVersionedPackage(request, self.response,
self.api_config)
+ self.assertEqual(version, self.response.version)
self.assertItemsEqual(
- result, [ebuild.path for ebuild in self.response.modified_ebuilds])
+ result.modified_ebuilds,
+ [ebuild.path for ebuild in self.response.modified_ebuilds])
class GetBestVisibleTest(cros_test_lib.MockTestCase, api_config.ApiConfigMixin):