commit 5dd6b1e0a5eff1b2fb269bac969beac5f461483f
author Alex Klein <saklein@chromium.org> Wed Jul 31 15:45:24 2019 -0600
committer Alex Klein <saklein@chromium.org> Thu Aug 01 15:38:38 2019 +0000
tree 92cf261e684bbc5b787c83e3c9ecb866c4d6def8
parent f275010c435a093aaa7f0cfa2e7a4f9f7fd61d05

PackagesService: Fix uprev output.

BUG=chromium:989722
TEST=run_tests

Change-Id: I8ac2d81065740fde0374659ee83806ec39081105
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1730111
Tested-by: Alex Klein <saklein@chromium.org>
Auto-Submit: Alex Klein <saklein@chromium.org>
Reviewed-by: Evan Hernandez <evanhernandez@chromium.org>

api/controller/packages_unittest.py

diff --git a/api/controller/packages_unittest.py b/api/controller/packages_unittest.py
index 4049f6a..b728712 100644
--- a/api/controller/packages_unittest.py
+++ b/api/controller/packages_unittest.py
@@ -60,11 +60,13 @@
     """Test overall successful argument handling."""
     targets = ['foo', 'bar']
     output_dir = '/tmp/uprev_output_dir'
+    changed = ['/ebuild-1.0-r1.ebuild', '/ebuild-1.0-r2.ebuild']
     expected_type = constants.BOTH_OVERLAYS
     request = self._GetRequest(targets=targets, overlay_type=self._BOTH,
                                output_dir=output_dir)
     response = self._GetResponse()
-    uprev_patch = self.PatchObject(packages_service, 'uprev_build_targets')
+    uprev_patch = self.PatchObject(packages_service, 'uprev_build_targets',
+                                   return_value=changed)
 
     packages_controller.Uprev(request, response)
 
@@ -75,6 +77,11 @@
     call_targets = uprev_patch.call_args[0][0]
     self.assertItemsEqual(targets, [t.name for t in call_targets])
 
+    for ebuild in response.modified_ebuilds:
+      self.assertIn(ebuild.path, changed)
+      changed.remove(ebuild.path)
+    self.assertFalse(changed)
+
 
 class GetBestVisibleTest(cros_test_lib.MockTestCase):
   """GetBestVisible tests."""