blob: a85226f86f0c66ae7f7620ae873514856d67a1ac [file] [log] [blame]
Edward Lesmes98eda3f2019-08-12 21:09:53 +00001#!/usr/bin/env python
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02002# Copyright (c) 2013 The Chromium Authors. All rights reserved.
maruel@chromium.org725f1c32011-04-01 20:24:54 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006# Copyright (C) 2008 Evan Martin <martine@danga.com>
7
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00008"""A git-command for integrating reviews on Gerrit."""
maruel@chromium.org725f1c32011-04-01 20:24:54 +00009
vapiera7fbd5a2016-06-16 09:17:49 -070010from __future__ import print_function
11
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +000012from distutils.version import LooseVersion
calamity@chromium.orgffde55c2015-03-12 00:44:17 +000013from multiprocessing.pool import ThreadPool
thakis@chromium.org3421c992014-11-02 02:20:32 +000014import base64
rmistry@google.com2dd99862015-06-22 12:22:18 +000015import collections
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010016import datetime
sheyang@google.com6ebaf782015-05-12 19:17:54 +000017import httplib
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +010018import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000019import json
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000020import logging
calamity@chromium.orgcf197482016-04-29 20:15:53 +000021import multiprocessing
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000022import optparse
23import os
24import re
Andrii Shyshkalov353637c2017-03-14 16:52:18 +010025import shutil
ukai@chromium.org78c4b982012-02-14 02:20:26 +000026import stat
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000027import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070028import tempfile
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000029import textwrap
Edward Lemurfec80c42018-11-01 23:14:14 +000030import time
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000031import urllib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000032import urllib2
maruel@chromium.org967c0a82013-06-17 22:52:24 +000033import urlparse
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000034import uuid
thestig@chromium.org00858c82013-12-02 23:08:03 +000035import webbrowser
thakis@chromium.org3421c992014-11-02 02:20:32 +000036import zlib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000037
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000038from third_party import colorama
sheyang@google.com6ebaf782015-05-12 19:17:54 +000039from third_party import httplib2
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000040import auth
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +000041import clang_format
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +000042import dart_format
maruel@chromium.org6f09cd92011-04-01 16:38:12 +000043import fix_encoding
maruel@chromium.org0e0436a2011-10-25 13:32:41 +000044import gclient_utils
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +000045import gerrit_util
iannucci@chromium.org9e849272014-04-04 00:31:55 +000046import git_common
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +000047import git_footers
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000048import metrics
Edward Lesmes93277a72018-10-18 22:04:26 +000049import metrics_utils
piman@chromium.org336f9122014-09-04 02:16:55 +000050import owners
iannucci@chromium.org9e849272014-04-04 00:31:55 +000051import owners_finder
maruel@chromium.org2a74d372011-03-29 19:05:50 +000052import presubmit_support
53import scm
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000054import setup_color
Francois Dorayd42c6812017-05-30 15:10:20 -040055import split_cl
maruel@chromium.org0633fb42013-08-16 20:06:14 +000056import subcommand
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +000057import subprocess2
maruel@chromium.org2a74d372011-03-29 19:05:50 +000058import watchlists
59
tandrii7400cf02016-06-21 08:48:07 -070060__version__ = '2.0'
maruel@chromium.org2a74d372011-03-29 19:05:50 +000061
Edward Lemur0f58ae42019-04-30 17:24:12 +000062# Traces for git push will be stored in a traces directory inside the
63# depot_tools checkout.
64DEPOT_TOOLS = os.path.dirname(os.path.abspath(__file__))
65TRACES_DIR = os.path.join(DEPOT_TOOLS, 'traces')
66
67# When collecting traces, Git hashes will be reduced to 6 characters to reduce
68# the size after compression.
69GIT_HASH_RE = re.compile(r'\b([a-f0-9]{6})[a-f0-9]{34}\b', flags=re.I)
70# Used to redact the cookies from the gitcookies file.
71GITCOOKIES_REDACT_RE = re.compile(r'1/.*')
72
Edward Lemurd4d1ba42019-09-20 21:46:37 +000073MAX_ATTEMPTS = 3
74
Edward Lemur1b52d872019-05-09 21:12:12 +000075# The maximum number of traces we will keep. Multiplied by 3 since we store
76# 3 files per trace.
77MAX_TRACES = 3 * 10
Edward Lemur5737f022019-05-17 01:24:00 +000078# Message to be displayed to the user to inform where to find the traces for a
79# git-cl upload execution.
Edward Lemur0f58ae42019-04-30 17:24:12 +000080TRACES_MESSAGE = (
Edward Lemur1b52d872019-05-09 21:12:12 +000081'\n'
Edward Lemur5737f022019-05-17 01:24:00 +000082'The traces of this git-cl execution have been recorded at:\n'
Edward Lemur1b52d872019-05-09 21:12:12 +000083' %(trace_name)s-traces.zip\n'
Edward Lemur5737f022019-05-17 01:24:00 +000084'Copies of your gitcookies file and git config have been recorded at:\n'
85' %(trace_name)s-git-info.zip\n')
Edward Lemur1b52d872019-05-09 21:12:12 +000086# Format of the message to be stored as part of the traces to give developers a
87# better context when they go through traces.
88TRACES_README_FORMAT = (
89'Date: %(now)s\n'
90'\n'
91'Change: https://%(gerrit_host)s/q/%(change_id)s\n'
92'Title: %(title)s\n'
93'\n'
94'%(description)s\n'
95'\n'
96'Execution time: %(execution_time)s\n'
97'Exit code: %(exit_code)s\n') + TRACES_MESSAGE
Edward Lemur0f58ae42019-04-30 17:24:12 +000098
tandrii9d2c7a32016-06-22 03:42:45 -070099COMMIT_BOT_EMAIL = 'commit-bot@chromium.org'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -0800100POSTUPSTREAM_HOOK = '.git/hooks/post-cl-land'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000101DESCRIPTION_BACKUP_FILE = '~/.git_cl_description_backup'
rmistry@google.comc68112d2015-03-03 12:48:06 +0000102REFS_THAT_ALIAS_TO_OTHER_REFS = {
103 'refs/remotes/origin/lkgr': 'refs/remotes/origin/master',
104 'refs/remotes/origin/lkcr': 'refs/remotes/origin/master',
105}
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000106
thestig@chromium.org44202a22014-03-11 19:22:18 +0000107# Valid extensions for files we want to lint.
108DEFAULT_LINT_REGEX = r"(.*\.cpp|.*\.cc|.*\.h)"
109DEFAULT_LINT_IGNORE_REGEX = r"$^"
110
Aiden Bennerc08566e2018-10-03 17:52:42 +0000111# File name for yapf style config files.
112YAPF_CONFIG_FILENAME = '.style.yapf'
113
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000114# Shortcut since it quickly becomes repetitive.
maruel@chromium.org2e23ce32013-05-07 12:42:28 +0000115Fore = colorama.Fore
maruel@chromium.org90541732011-04-01 17:54:18 +0000116
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000117# Initialized in main()
118settings = None
119
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100120# Used by tests/git_cl_test.py to add extra logging.
121# Inside the weirdly failing test, add this:
122# >>> self.mock(git_cl, '_IS_BEING_TESTED', True)
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700123# And scroll up to see the stack trace printed.
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100124_IS_BEING_TESTED = False
125
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000126
Christopher Lamf732cd52017-01-24 12:40:11 +1100127def DieWithError(message, change_desc=None):
128 if change_desc:
129 SaveDescriptionBackup(change_desc)
130
vapiera7fbd5a2016-06-16 09:17:49 -0700131 print(message, file=sys.stderr)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000132 sys.exit(1)
133
134
Christopher Lamf732cd52017-01-24 12:40:11 +1100135def SaveDescriptionBackup(change_desc):
136 backup_path = os.path.expanduser(DESCRIPTION_BACKUP_FILE)
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000137 print('\nsaving CL description to %s\n' % backup_path)
Christopher Lamf732cd52017-01-24 12:40:11 +1100138 backup_file = open(backup_path, 'w')
139 backup_file.write(change_desc.description)
140 backup_file.close()
141
142
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000143def GetNoGitPagerEnv():
144 env = os.environ.copy()
145 # 'cat' is a magical git string that disables pagers on all platforms.
146 env['GIT_PAGER'] = 'cat'
147 return env
148
vadimsh@chromium.org566a02a2014-08-22 01:34:13 +0000149
bsep@chromium.org627d9002016-04-29 00:00:52 +0000150def RunCommand(args, error_ok=False, error_message=None, shell=False, **kwargs):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000151 try:
bsep@chromium.org627d9002016-04-29 00:00:52 +0000152 return subprocess2.check_output(args, shell=shell, **kwargs)
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000153 except subprocess2.CalledProcessError as e:
154 logging.debug('Failed running %s', args)
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000155 if not error_ok:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000156 DieWithError(
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000157 'Command "%s" failed.\n%s' % (
158 ' '.join(args), error_message or e.stdout or ''))
159 return e.stdout
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000160
161
162def RunGit(args, **kwargs):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000163 """Returns stdout."""
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000164 return RunCommand(['git'] + args, **kwargs)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000165
166
enne@chromium.org3b7e15c2014-01-21 17:44:47 +0000167def RunGitWithCode(args, suppress_stderr=False):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000168 """Returns return code and stdout."""
tandrii5d48c322016-08-18 16:19:37 -0700169 if suppress_stderr:
170 stderr = subprocess2.VOID
171 else:
172 stderr = sys.stderr
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000173 try:
tandrii5d48c322016-08-18 16:19:37 -0700174 (out, _), code = subprocess2.communicate(['git'] + args,
175 env=GetNoGitPagerEnv(),
176 stdout=subprocess2.PIPE,
177 stderr=stderr)
178 return code, out
179 except subprocess2.CalledProcessError as e:
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +0900180 logging.debug('Failed running %s', ['git'] + args)
tandrii5d48c322016-08-18 16:19:37 -0700181 return e.returncode, e.stdout
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000182
183
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000184def RunGitSilent(args):
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000185 """Returns stdout, suppresses stderr and ignores the return code."""
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000186 return RunGitWithCode(args, suppress_stderr=True)[1]
187
188
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000189def IsGitVersionAtLeast(min_version):
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000190 prefix = 'git version '
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000191 version = RunGit(['--version']).strip()
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000192 return (version.startswith(prefix) and
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000193 LooseVersion(version[len(prefix):]) >= LooseVersion(min_version))
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000194
195
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000196def BranchExists(branch):
197 """Return True if specified branch exists."""
198 code, _ = RunGitWithCode(['rev-parse', '--verify', branch],
199 suppress_stderr=True)
200 return not code
201
202
tandrii2a16b952016-10-19 07:09:44 -0700203def time_sleep(seconds):
204 # Use this so that it can be mocked in tests without interfering with python
205 # system machinery.
tandrii2a16b952016-10-19 07:09:44 -0700206 return time.sleep(seconds)
207
208
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000209def time_time():
210 # Use this so that it can be mocked in tests without interfering with python
211 # system machinery.
212 return time.time()
213
214
Edward Lemur1b52d872019-05-09 21:12:12 +0000215def datetime_now():
216 # Use this so that it can be mocked in tests without interfering with python
217 # system machinery.
218 return datetime.datetime.now()
219
220
maruel@chromium.org90541732011-04-01 17:54:18 +0000221def ask_for_data(prompt):
222 try:
223 return raw_input(prompt)
224 except KeyboardInterrupt:
225 # Hide the exception.
226 sys.exit(1)
227
228
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100229def confirm_or_exit(prefix='', action='confirm'):
230 """Asks user to press enter to continue or press Ctrl+C to abort."""
231 if not prefix or prefix.endswith('\n'):
232 mid = 'Press'
Andrii Shyshkalov353637c2017-03-14 16:52:18 +0100233 elif prefix.endswith('.') or prefix.endswith('?'):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100234 mid = ' Press'
235 elif prefix.endswith(' '):
236 mid = 'press'
237 else:
238 mid = ' press'
239 ask_for_data('%s%s Enter to %s, or Ctrl+C to abort' % (prefix, mid, action))
240
241
242def ask_for_explicit_yes(prompt):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000243 """Returns whether user typed 'y' or 'yes' to confirm the given prompt."""
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100244 result = ask_for_data(prompt + ' [Yes/No]: ').lower()
245 while True:
246 if 'yes'.startswith(result):
247 return True
248 if 'no'.startswith(result):
249 return False
250 result = ask_for_data('Please, type yes or no: ').lower()
251
252
tandrii5d48c322016-08-18 16:19:37 -0700253def _git_branch_config_key(branch, key):
254 """Helper method to return Git config key for a branch."""
255 assert branch, 'branch name is required to set git config for it'
256 return 'branch.%s.%s' % (branch, key)
257
258
259def _git_get_branch_config_value(key, default=None, value_type=str,
260 branch=False):
261 """Returns git config value of given or current branch if any.
262
263 Returns default in all other cases.
264 """
265 assert value_type in (int, str, bool)
266 if branch is False: # Distinguishing default arg value from None.
267 branch = GetCurrentBranch()
268
rogerta@chromium.orgcaa16552013-03-18 20:45:05 +0000269 if not branch:
tandrii5d48c322016-08-18 16:19:37 -0700270 return default
rogerta@chromium.orgcaa16552013-03-18 20:45:05 +0000271
tandrii5d48c322016-08-18 16:19:37 -0700272 args = ['config']
tandrii33a46ff2016-08-23 05:53:40 -0700273 if value_type == bool:
tandrii5d48c322016-08-18 16:19:37 -0700274 args.append('--bool')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000275 # `git config` also has --int, but apparently git config suffers from integer
tandrii33a46ff2016-08-23 05:53:40 -0700276 # overflows (http://crbug.com/640115), so don't use it.
tandrii5d48c322016-08-18 16:19:37 -0700277 args.append(_git_branch_config_key(branch, key))
278 code, out = RunGitWithCode(args)
279 if code == 0:
280 value = out.strip()
281 if value_type == int:
282 return int(value)
283 if value_type == bool:
284 return bool(value.lower() == 'true')
285 return value
iannucci@chromium.org79540052012-10-19 23:15:26 +0000286 return default
287
288
tandrii5d48c322016-08-18 16:19:37 -0700289def _git_set_branch_config_value(key, value, branch=None, **kwargs):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000290 """Sets or unsets the git branch config value.
tandrii5d48c322016-08-18 16:19:37 -0700291
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000292 If value is None, the key will be unset, otherwise it will be set.
293 If no branch is given, the currently checked out branch is used.
tandrii5d48c322016-08-18 16:19:37 -0700294 """
295 if not branch:
296 branch = GetCurrentBranch()
297 assert branch, 'a branch name OR currently checked out branch is required'
298 args = ['config']
qyearsley12fa6ff2016-08-24 09:18:40 -0700299 # Check for boolean first, because bool is int, but int is not bool.
tandrii5d48c322016-08-18 16:19:37 -0700300 if value is None:
301 args.append('--unset')
302 elif isinstance(value, bool):
303 args.append('--bool')
304 value = str(value).lower()
tandrii5d48c322016-08-18 16:19:37 -0700305 else:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000306 # `git config` also has --int, but apparently git config suffers from
307 # integer overflows (http://crbug.com/640115), so don't use it.
tandrii5d48c322016-08-18 16:19:37 -0700308 value = str(value)
309 args.append(_git_branch_config_key(branch, key))
310 if value is not None:
311 args.append(value)
312 RunGit(args, **kwargs)
313
314
machenbach@chromium.org45453142015-09-15 08:45:22 +0000315def _get_properties_from_options(options):
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000316 prop_list = getattr(options, 'properties', [])
317 properties = dict(x.split('=', 1) for x in prop_list)
machenbach@chromium.org45453142015-09-15 08:45:22 +0000318 for key, val in properties.iteritems():
319 try:
320 properties[key] = json.loads(val)
321 except ValueError:
322 pass # If a value couldn't be evaluated, treat it as a string.
323 return properties
324
325
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000326# TODO(crbug.com/976104): Remove this function once git-cl try-results has
327# migrated to use buildbucket v2
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000328def _buildbucket_retry(operation_name, http, *args, **kwargs):
329 """Retries requests to buildbucket service and returns parsed json content."""
330 try_count = 0
331 while True:
332 response, content = http.request(*args, **kwargs)
333 try:
334 content_json = json.loads(content)
335 except ValueError:
336 content_json = None
337
338 # Buildbucket could return an error even if status==200.
339 if content_json and content_json.get('error'):
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000340 error = content_json.get('error')
341 if error.get('code') == 403:
342 raise BuildbucketResponseException(
343 'Access denied: %s' % error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000344 msg = 'Error in response. Reason: %s. Message: %s.' % (
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000345 error.get('reason', ''), error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000346 raise BuildbucketResponseException(msg)
347
348 if response.status == 200:
Nodir Turakulov23d75d22018-06-04 12:37:32 -0700349 if content_json is None:
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000350 raise BuildbucketResponseException(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000351 'Buildbucket returned invalid JSON content: %s.\n'
Nodir Turakulov9ac59792018-06-04 12:34:14 -0700352 'Please file bugs at http://crbug.com, '
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000353 'component "Infra>Platform>Buildbucket".' %
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000354 content)
355 return content_json
356 if response.status < 500 or try_count >= 2:
357 raise httplib2.HttpLib2Error(content)
358
359 # status >= 500 means transient failures.
360 logging.debug('Transient errors when %s. Will retry.', operation_name)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000361 time_sleep(0.5 + (1.5 * try_count))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000362 try_count += 1
363 assert False, 'unreachable'
364
365
Edward Lemur4c707a22019-09-24 21:13:43 +0000366def _call_buildbucket(http, buildbucket_host, method, request):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000367 """Calls a buildbucket v2 method and returns the parsed json response."""
368 headers = {
369 'Accept': 'application/json',
370 'Content-Type': 'application/json',
371 }
372 request = json.dumps(request)
373 url = 'https://%s/prpc/buildbucket.v2.Builds/%s' % (buildbucket_host, method)
374
375 logging.info('POST %s with %s' % (url, request))
376
377 attempts = 1
378 time_to_sleep = 1
379 while True:
380 response, content = http.request(url, 'POST', body=request, headers=headers)
381 if response.status == 200:
382 return json.loads(content[4:])
383 if attempts >= MAX_ATTEMPTS or 400 <= response.status < 500:
384 msg = '%s error when calling POST %s with %s: %s' % (
385 response.status, url, request, content)
386 raise BuildbucketResponseException(msg)
387 logging.debug(
388 '%s error when calling POST %s with %s. '
389 'Sleeping for %d seconds and retrying...' % (
390 response.status, url, request, time_to_sleep))
391 time.sleep(time_to_sleep)
392 time_to_sleep *= 2
393 attempts += 1
394
395 assert False, 'unreachable'
396
397
qyearsley1fdfcb62016-10-24 13:22:03 -0700398def _get_bucket_map(changelist, options, option_parser):
qyearsleydd49f942016-10-28 11:57:22 -0700399 """Returns a dict mapping bucket names to builders and tests,
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000400 for triggering tryjobs.
qyearsley1fdfcb62016-10-24 13:22:03 -0700401 """
qyearsleydd49f942016-10-28 11:57:22 -0700402 # If no bots are listed, we try to get a set of builders and tests based
403 # on GetPreferredTryMasters functions in PRESUBMIT.py files.
qyearsley1fdfcb62016-10-24 13:22:03 -0700404 if not options.bot:
405 change = changelist.GetChange(
406 changelist.GetCommonAncestorWithUpstream(), None)
qyearsley136b49f2016-10-31 09:02:26 -0700407 # Get try masters from PRESUBMIT.py files.
nodire4f0fe02016-11-04 16:23:30 -0700408 masters = presubmit_support.DoGetTryMasters(
qyearsley1fdfcb62016-10-24 13:22:03 -0700409 change=change,
410 changed_files=change.LocalPaths(),
411 repository_root=settings.GetRoot(),
412 default_presubmit=None,
413 project=None,
414 verbose=options.verbose,
415 output_stream=sys.stdout)
nodire4f0fe02016-11-04 16:23:30 -0700416 if masters is None:
417 return None
Edward Lemurc8b67ed2019-09-12 20:28:58 +0000418 return {m: b for m, b in masters.iteritems()}
qyearsley1fdfcb62016-10-24 13:22:03 -0700419
qyearsley1fdfcb62016-10-24 13:22:03 -0700420 if options.bucket:
421 return {options.bucket: {b: [] for b in options.bot}}
Andrii Shyshkalov75424372019-08-30 22:48:15 +0000422 option_parser.error(
423 'Please specify the bucket, e.g. "-B luci.chromium.try".')
qyearsley1fdfcb62016-10-24 13:22:03 -0700424
425
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000426def _parse_bucket(bucket):
427 if '/' in bucket:
428 return tuple(bucket.split('/', 1))
429 # Legacy buckets.
430 print('WARNING Please specify buckets as <project>/<bucket>.')
431 # Assume luci.<project>.<bucket>.
432 if bucket.startswith('luci.'):
433 return tuple(bucket[len('luci.'):].split('.', 1))
434 # Otherwise, assume prefix is also the project name.
435 if '.' in bucket:
436 project = bucket.split('.')[0]
437 return project, bucket
438 return None, None
439
440
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -0800441def _trigger_try_jobs(auth_config, changelist, buckets, options, patchset):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000442 """Sends a request to Buildbucket to trigger tryjobs for a changelist.
qyearsley1fdfcb62016-10-24 13:22:03 -0700443
444 Args:
Aaron Gablefb28d482018-04-02 13:08:06 -0700445 auth_config: AuthConfig for Buildbucket.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000446 changelist: Changelist that the tryjobs are associated with.
qyearsley1fdfcb62016-10-24 13:22:03 -0700447 buckets: A nested dict mapping bucket names to builders to tests.
448 options: Command-line options.
449 """
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000450 print('Scheduling jobs on:')
451 for bucket, builders_and_tests in sorted(buckets.iteritems()):
452 print('Bucket:', bucket)
453 print('\n'.join(
454 ' %s: %s' % (builder, tests)
455 for builder, tests in sorted(builders_and_tests.iteritems())))
456 print('To see results here, run: git cl try-results')
457 print('To see results in browser, run: git cl web')
tandriide281ae2016-10-12 06:02:30 -0700458
Edward Lemurf0faf482019-09-25 20:40:17 +0000459 gerrit_changes = [changelist.GetGerritChange(patchset)]
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000460 shared_properties = {'category': getattr(options, 'category', 'git_cl_try')}
Edward Lemurf0faf482019-09-25 20:40:17 +0000461 shared_properties.update(changelist.GetLegacyProperties(patchset))
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000462 if getattr(options, 'clobber', False):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000463 shared_properties['clobber'] = True
464 shared_properties.update(_get_properties_from_options(options) or {})
465
466 requests = []
467 for raw_bucket, builders_and_tests in sorted(buckets.iteritems()):
468 project, bucket = _parse_bucket(raw_bucket)
469 if not project or not bucket:
470 print('WARNING Could not parse bucket "%s". Skipping.' % raw_bucket)
471 continue
472
473 for builder, tests in sorted(builders_and_tests.iteritems()):
474 properties = shared_properties.copy()
475 if 'presubmit' in builder.lower():
476 properties['dry_run'] = 'true'
477 if tests:
478 properties['testfilter'] = tests
479
480 requests.append({
481 'scheduleBuild': {
482 'requestId': str(uuid.uuid4()),
483 'builder': {
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000484 'project': getattr(options, 'project', None) or project,
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000485 'bucket': bucket,
486 'builder': builder,
487 },
488 'gerritChanges': gerrit_changes,
489 'properties': properties,
490 'tags': [
491 {'key': 'builder', 'value': builder},
492 {'key': 'user_agent', 'value': 'git_cl_try'},
493 ],
494 }
495 })
496
497 if not requests:
498 return
499
500 codereview_url = changelist.GetCodereviewServer()
Edward Lemur2c210a42019-09-16 23:58:35 +0000501 codereview_host = urlparse.urlparse(codereview_url).hostname
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000502
Edward Lemur2c210a42019-09-16 23:58:35 +0000503 authenticator = auth.get_authenticator_for_host(codereview_host, auth_config)
504 http = authenticator.authorize(httplib2.Http())
505 http.force_exception_to_status_code = True
506
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000507 batch_request = {'requests': requests}
508 batch_response = _call_buildbucket(
Edward Lemur4c707a22019-09-24 21:13:43 +0000509 http, options.buildbucket_host, 'Batch', batch_request)
Edward Lemur2c210a42019-09-16 23:58:35 +0000510
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000511 errors = [
512 ' ' + response['error']['message']
513 for response in batch_response.get('responses', [])
514 if 'error' in response
515 ]
516 if errors:
517 raise BuildbucketResponseException(
518 'Failed to schedule builds for some bots:\n%s' % '\n'.join(errors))
kjellander@chromium.org44424542015-06-02 18:35:29 +0000519
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000520
tandrii221ab252016-10-06 08:12:04 -0700521def fetch_try_jobs(auth_config, changelist, buildbucket_host,
522 patchset=None):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000523 """Fetches tryjobs from buildbucket.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000524
Quinten Yearsley983111f2019-09-26 17:18:48 +0000525 Returns a map from build ID to build info as a dictionary.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000526 """
tandrii221ab252016-10-06 08:12:04 -0700527 assert buildbucket_host
528 assert changelist.GetIssue(), 'CL must be uploaded first'
529 assert changelist.GetCodereviewServer(), 'CL must be uploaded first'
530 patchset = patchset or changelist.GetMostRecentPatchset()
531 assert patchset, 'CL must be uploaded first'
532
533 codereview_url = changelist.GetCodereviewServer()
534 codereview_host = urlparse.urlparse(codereview_url).hostname
535 authenticator = auth.get_authenticator_for_host(codereview_host, auth_config)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000536 if authenticator.has_cached_credentials():
537 http = authenticator.authorize(httplib2.Http())
538 else:
vapiera7fbd5a2016-06-16 09:17:49 -0700539 print('Warning: Some results might be missing because %s' %
540 # Get the message on how to login.
Edward Lemurba5bc992019-09-23 22:59:17 +0000541 (auth.LoginRequiredError().message,))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000542 http = httplib2.Http()
543
544 http.force_exception_to_status_code = True
545
Andrii Shyshkalov03da1502018-10-15 03:42:34 +0000546 buildset = 'patch/gerrit/{hostname}/{issue}/{patch}'.format(
tandrii221ab252016-10-06 08:12:04 -0700547 hostname=codereview_host,
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000548 issue=changelist.GetIssue(),
tandrii221ab252016-10-06 08:12:04 -0700549 patch=patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000550 params = {'tag': 'buildset:%s' % buildset}
551
552 builds = {}
553 while True:
554 url = 'https://{hostname}/_ah/api/buildbucket/v1/search?{params}'.format(
tandrii221ab252016-10-06 08:12:04 -0700555 hostname=buildbucket_host,
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000556 params=urllib.urlencode(params))
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000557 content = _buildbucket_retry('fetching tryjobs', http, url, 'GET')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000558 for build in content.get('builds', []):
559 builds[build['id']] = build
560 if 'next_cursor' in content:
561 params['start_cursor'] = content['next_cursor']
562 else:
563 break
564 return builds
565
566
Quinten Yearsley983111f2019-09-26 17:18:48 +0000567def _fetch_latest_builds(auth_config, changelist, buildbucket_host):
568 """Fetches builds from the latest patchset that has builds (within
569 the last few patchsets).
570
571 Args:
572 auth_config (auth.AuthConfig): Auth info for Buildbucket
573 changelist (Changelist): The CL to fetch builds for
574 buildbucket_host (str): Buildbucket host, e.g. "cr-buildbucket.appspot.com"
575
576 Returns:
577 A tuple (builds, patchset) where builds is a dict mapping from build ID to
578 build info from Buildbucket, and patchset is the patchset number where
579 those builds came from.
580 """
581 assert buildbucket_host
582 assert changelist.GetIssue(), 'CL must be uploaded first'
583 assert changelist.GetCodereviewServer(), 'CL must be uploaded first'
584 assert changelist.GetMostRecentPatchset()
585 ps = changelist.GetMostRecentPatchset()
586 min_ps = max(1, ps - 5)
587 while ps >= min_ps:
588 builds = fetch_try_jobs(
589 auth_config, changelist, buildbucket_host, patchset=ps)
590 if len(builds):
591 return builds, ps
592 ps -= 1
593 return [], 0
594
595
596def _filter_failed(builds):
597 """Returns a list of buckets/builders that had failed builds.
598
599 Args:
600 builds (dict): Builds, in the format returned by fetch_try_jobs,
601 i.e. a dict mapping build ID to build info dict, which includes
602 the keys status, result, bucket, and builder_name.
603
604 Returns:
605 A dict of bucket to builder to tests (empty list). This is the same format
606 accepted by _trigger_try_jobs and returned by _get_bucket_map.
607 """
608 buckets = collections.defaultdict(dict)
609 for build in builds.values():
610 if build['status'] == 'COMPLETED' and build['result'] == 'FAILURE':
611 project = build['project']
612 bucket = build['bucket']
613 if bucket.startswith('luci.'):
614 # Assume legacy bucket name luci.<project>.<bucket>.
615 bucket = bucket.split('.')[2]
616 builder = _get_builder_from_build(build)
617 buckets[project + '/' + bucket][builder] = []
618 return buckets
619
620
qyearsleyeab3c042016-08-24 09:18:28 -0700621def print_try_jobs(options, builds):
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000622 """Prints nicely result of fetch_try_jobs."""
623 if not builds:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000624 print('No tryjobs scheduled.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000625 return
626
627 # Make a copy, because we'll be modifying builds dictionary.
628 builds = builds.copy()
629 builder_names_cache = {}
630
631 def get_builder(b):
632 try:
633 return builder_names_cache[b['id']]
634 except KeyError:
Quinten Yearsley983111f2019-09-26 17:18:48 +0000635 name = _get_builder_from_build(b)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000636 builder_names_cache[b['id']] = name
637 return name
638
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000639 if options.print_master:
640 name_fmt = '%%-%ds %%-%ds' % (
Edward Lemurc8b67ed2019-09-12 20:28:58 +0000641 max(len(str(b['bucket'])) for b in builds.itervalues()),
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000642 max(len(str(get_builder(b))) for b in builds.itervalues()))
643 def get_name(b):
Edward Lemurc8b67ed2019-09-12 20:28:58 +0000644 return name_fmt % (b['bucket'], get_builder(b))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000645 else:
646 name_fmt = '%%-%ds' % (
647 max(len(str(get_builder(b))) for b in builds.itervalues()))
648 def get_name(b):
649 return name_fmt % get_builder(b)
650
651 def sort_key(b):
652 return b['status'], b.get('result'), get_name(b), b.get('url')
653
654 def pop(title, f, color=None, **kwargs):
655 """Pop matching builds from `builds` dict and print them."""
656
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +0000657 if not options.color or color is None:
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000658 colorize = str
659 else:
660 colorize = lambda x: '%s%s%s' % (color, x, Fore.RESET)
661
662 result = []
663 for b in builds.values():
664 if all(b.get(k) == v for k, v in kwargs.iteritems()):
665 builds.pop(b['id'])
666 result.append(b)
667 if result:
vapiera7fbd5a2016-06-16 09:17:49 -0700668 print(colorize(title))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000669 for b in sorted(result, key=sort_key):
vapiera7fbd5a2016-06-16 09:17:49 -0700670 print(' ', colorize('\t'.join(map(str, f(b)))))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000671
672 total = len(builds)
673 pop(status='COMPLETED', result='SUCCESS',
674 title='Successes:', color=Fore.GREEN,
675 f=lambda b: (get_name(b), b.get('url')))
676 pop(status='COMPLETED', result='FAILURE', failure_reason='INFRA_FAILURE',
677 title='Infra Failures:', color=Fore.MAGENTA,
678 f=lambda b: (get_name(b), b.get('url')))
679 pop(status='COMPLETED', result='FAILURE', failure_reason='BUILD_FAILURE',
680 title='Failures:', color=Fore.RED,
681 f=lambda b: (get_name(b), b.get('url')))
682 pop(status='COMPLETED', result='CANCELED',
683 title='Canceled:', color=Fore.MAGENTA,
684 f=lambda b: (get_name(b),))
685 pop(status='COMPLETED', result='FAILURE',
686 failure_reason='INVALID_BUILD_DEFINITION',
687 title='Wrong master/builder name:', color=Fore.MAGENTA,
688 f=lambda b: (get_name(b),))
689 pop(status='COMPLETED', result='FAILURE',
690 title='Other failures:',
691 f=lambda b: (get_name(b), b.get('failure_reason'), b.get('url')))
692 pop(status='COMPLETED',
693 title='Other finished:',
694 f=lambda b: (get_name(b), b.get('result'), b.get('url')))
695 pop(status='STARTED',
696 title='Started:', color=Fore.YELLOW,
697 f=lambda b: (get_name(b), b.get('url')))
698 pop(status='SCHEDULED',
699 title='Scheduled:',
700 f=lambda b: (get_name(b), 'id=%s' % b['id']))
701 # The last section is just in case buildbucket API changes OR there is a bug.
702 pop(title='Other:',
703 f=lambda b: (get_name(b), 'id=%s' % b['id']))
704 assert len(builds) == 0
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000705 print('Total: %d tryjobs' % total)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000706
707
Quinten Yearsley983111f2019-09-26 17:18:48 +0000708def _get_builder_from_build(build):
709 """Returns a builder name from a BB v1 build info dict."""
710 try:
711 parameters = json.loads(build['parameters_json'])
712 name = parameters['builder_name']
713 except (ValueError, KeyError) as error:
714 print('WARNING: Failed to get builder name for build %s: %s' % (
715 build['id'], error))
716 name = None
717 return name
718
719
Aiden Bennerc08566e2018-10-03 17:52:42 +0000720def _ComputeDiffLineRanges(files, upstream_commit):
721 """Gets the changed line ranges for each file since upstream_commit.
722
723 Parses a git diff on provided files and returns a dict that maps a file name
724 to an ordered list of range tuples in the form (start_line, count).
725 Ranges are in the same format as a git diff.
726 """
727 # If files is empty then diff_output will be a full diff.
728 if len(files) == 0:
729 return {}
730
Aiden Benner6c18a1a2018-11-23 20:18:23 +0000731 # Take the git diff and find the line ranges where there are changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000732 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, files, allow_prefix=True)
733 diff_output = RunGit(diff_cmd)
734
735 pattern = r'(?:^diff --git a/(?:.*) b/(.*))|(?:^@@.*\+(.*) @@)'
736 # 2 capture groups
737 # 0 == fname of diff file
738 # 1 == 'diff_start,diff_count' or 'diff_start'
739 # will match each of
740 # diff --git a/foo.foo b/foo.py
741 # @@ -12,2 +14,3 @@
742 # @@ -12,2 +17 @@
743 # running re.findall on the above string with pattern will give
744 # [('foo.py', ''), ('', '14,3'), ('', '17')]
745
746 curr_file = None
747 line_diffs = {}
748 for match in re.findall(pattern, diff_output, flags=re.MULTILINE):
749 if match[0] != '':
750 # Will match the second filename in diff --git a/a.py b/b.py.
751 curr_file = match[0]
752 line_diffs[curr_file] = []
753 else:
754 # Matches +14,3
755 if ',' in match[1]:
756 diff_start, diff_count = match[1].split(',')
757 else:
758 # Single line changes are of the form +12 instead of +12,1.
759 diff_start = match[1]
760 diff_count = 1
761
762 diff_start = int(diff_start)
763 diff_count = int(diff_count)
764
765 # If diff_count == 0 this is a removal we can ignore.
766 line_diffs[curr_file].append((diff_start, diff_count))
767
768 return line_diffs
769
770
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000771def _FindYapfConfigFile(fpath, yapf_config_cache, top_dir=None):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000772 """Checks if a yapf file is in any parent directory of fpath until top_dir.
773
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000774 Recursively checks parent directories to find yapf file and if no yapf file
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000775 is found returns None. Uses yapf_config_cache as a cache for previously found
776 configs.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000777 """
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000778 fpath = os.path.abspath(fpath)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000779 # Return result if we've already computed it.
780 if fpath in yapf_config_cache:
781 return yapf_config_cache[fpath]
782
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000783 parent_dir = os.path.dirname(fpath)
784 if os.path.isfile(fpath):
785 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000786 else:
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000787 # Otherwise fpath is a directory
788 yapf_file = os.path.join(fpath, YAPF_CONFIG_FILENAME)
789 if os.path.isfile(yapf_file):
790 ret = yapf_file
791 elif fpath == top_dir or parent_dir == fpath:
792 # If we're at the top level directory, or if we're at root
793 # there is no provided style.
794 ret = None
795 else:
796 # Otherwise recurse on the current directory.
797 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000798 yapf_config_cache[fpath] = ret
799 return ret
800
801
qyearsley53f48a12016-09-01 10:45:13 -0700802def write_try_results_json(output_file, builds):
803 """Writes a subset of the data from fetch_try_jobs to a file as JSON.
804
805 The input |builds| dict is assumed to be generated by Buildbucket.
806 Buildbucket documentation: http://goo.gl/G0s101
807 """
808
809 def convert_build_dict(build):
Quinten Yearsleya563d722017-12-11 16:36:54 -0800810 """Extracts some of the information from one build dict."""
811 parameters = json.loads(build.get('parameters_json', '{}')) or {}
qyearsley53f48a12016-09-01 10:45:13 -0700812 return {
813 'buildbucket_id': build.get('id'),
qyearsley53f48a12016-09-01 10:45:13 -0700814 'bucket': build.get('bucket'),
Quinten Yearsleya563d722017-12-11 16:36:54 -0800815 'builder_name': parameters.get('builder_name'),
816 'created_ts': build.get('created_ts'),
817 'experimental': build.get('experimental'),
qyearsley53f48a12016-09-01 10:45:13 -0700818 'failure_reason': build.get('failure_reason'),
Quinten Yearsleya563d722017-12-11 16:36:54 -0800819 'result': build.get('result'),
820 'status': build.get('status'),
821 'tags': build.get('tags'),
qyearsley53f48a12016-09-01 10:45:13 -0700822 'url': build.get('url'),
823 }
824
825 converted = []
826 for _, build in sorted(builds.items()):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000827 converted.append(convert_build_dict(build))
qyearsley53f48a12016-09-01 10:45:13 -0700828 write_json(output_file, converted)
829
830
Aaron Gable13101a62018-02-09 13:20:41 -0800831def print_stats(args):
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000832 """Prints statistics about the change to the user."""
833 # --no-ext-diff is broken in some versions of Git, so try to work around
834 # this by overriding the environment (but there is still a problem if the
835 # git config key "diff.external" is used).
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000836 env = GetNoGitPagerEnv()
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000837 if 'GIT_EXTERNAL_DIFF' in env:
838 del env['GIT_EXTERNAL_DIFF']
iannucci@chromium.org79540052012-10-19 23:15:26 +0000839
szager@chromium.orgd057f9a2014-05-29 21:09:36 +0000840 try:
841 stdout = sys.stdout.fileno()
842 except AttributeError:
843 stdout = None
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000844 return subprocess2.call(
Aaron Gable13101a62018-02-09 13:20:41 -0800845 ['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] + args,
szager@chromium.orgd057f9a2014-05-29 21:09:36 +0000846 stdout=stdout, env=env)
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000847
848
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000849class BuildbucketResponseException(Exception):
850 pass
851
852
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000853class Settings(object):
854 def __init__(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000855 self.cc = None
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000856 self.root = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000857 self.tree_status_url = None
858 self.viewvc_url = None
859 self.updated = False
ukai@chromium.orge8077812012-02-03 03:41:46 +0000860 self.is_gerrit = None
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000861 self.squash_gerrit_uploads = None
tandrii@chromium.org28253532016-04-14 13:46:56 +0000862 self.gerrit_skip_ensure_authenticated = None
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000863 self.git_editor = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000864
865 def LazyUpdateIfNeeded(self):
866 """Updates the settings from a codereview.settings file, if available."""
867 if not self.updated:
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000868 # The only value that actually changes the behavior is
869 # autoupdate = "false". Everything else means "true".
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +0000870 autoupdate = RunGit(['config', 'rietveld.autoupdate'],
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000871 error_ok=True
872 ).strip().lower()
873
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000874 cr_settings_file = FindCodereviewSettingsFile()
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000875 if autoupdate != 'false' and cr_settings_file:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000876 LoadCodereviewSettingsFromFile(cr_settings_file)
877 self.updated = True
878
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000879 @staticmethod
880 def GetRelativeRoot():
881 return RunGit(['rev-parse', '--show-cdup']).strip()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000882
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000883 def GetRoot(self):
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000884 if self.root is None:
885 self.root = os.path.abspath(self.GetRelativeRoot())
886 return self.root
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000887
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000888 def GetTreeStatusUrl(self, error_ok=False):
889 if not self.tree_status_url:
890 error_message = ('You must configure your tree status URL by running '
891 '"git cl config".')
Edward Lemur61ea3072018-12-01 00:34:36 +0000892 self.tree_status_url = self._GetConfig(
893 'rietveld.tree-status-url', error_ok=error_ok,
894 error_message=error_message)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000895 return self.tree_status_url
896
897 def GetViewVCUrl(self):
898 if not self.viewvc_url:
Edward Lemur61ea3072018-12-01 00:34:36 +0000899 self.viewvc_url = self._GetConfig('rietveld.viewvc-url', error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000900 return self.viewvc_url
901
rmistry@google.com90752582014-01-14 21:04:50 +0000902 def GetBugPrefix(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000903 return self._GetConfig('rietveld.bug-prefix', error_ok=True)
rmistry@google.com78948ed2015-07-08 23:09:57 +0000904
rmistry@google.com5626a922015-02-26 14:03:30 +0000905 def GetRunPostUploadHook(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000906 run_post_upload_hook = self._GetConfig(
907 'rietveld.run-post-upload-hook', error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +0000908 return run_post_upload_hook == "True"
909
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000910 def GetDefaultCCList(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000911 return self._GetConfig('rietveld.cc', error_ok=True)
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000912
ukai@chromium.orge8077812012-02-03 03:41:46 +0000913 def GetIsGerrit(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000914 """Returns True if this repo is associated with Gerrit."""
ukai@chromium.orge8077812012-02-03 03:41:46 +0000915 if self.is_gerrit is None:
Aaron Gable9b465272017-05-12 10:53:51 -0700916 self.is_gerrit = (
917 self._GetConfig('gerrit.host', error_ok=True).lower() == 'true')
ukai@chromium.orge8077812012-02-03 03:41:46 +0000918 return self.is_gerrit
919
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000920 def GetSquashGerritUploads(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000921 """Returns True if uploads to Gerrit should be squashed by default."""
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000922 if self.squash_gerrit_uploads is None:
tandriia60502f2016-06-20 02:01:53 -0700923 self.squash_gerrit_uploads = self.GetSquashGerritUploadsOverride()
924 if self.squash_gerrit_uploads is None:
925 # Default is squash now (http://crbug.com/611892#c23).
926 self.squash_gerrit_uploads = not (
927 RunGit(['config', '--bool', 'gerrit.squash-uploads'],
928 error_ok=True).strip() == 'false')
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000929 return self.squash_gerrit_uploads
930
tandriia60502f2016-06-20 02:01:53 -0700931 def GetSquashGerritUploadsOverride(self):
932 """Return True or False if codereview.settings should be overridden.
933
934 Returns None if no override has been defined.
935 """
936 # See also http://crbug.com/611892#c23
937 result = RunGit(['config', '--bool', 'gerrit.override-squash-uploads'],
938 error_ok=True).strip()
939 if result == 'true':
940 return True
941 if result == 'false':
942 return False
943 return None
944
tandrii@chromium.org28253532016-04-14 13:46:56 +0000945 def GetGerritSkipEnsureAuthenticated(self):
946 """Return True if EnsureAuthenticated should not be done for Gerrit
947 uploads."""
948 if self.gerrit_skip_ensure_authenticated is None:
949 self.gerrit_skip_ensure_authenticated = (
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000950 RunGit(['config', '--bool', 'gerrit.skip-ensure-authenticated'],
tandrii@chromium.org28253532016-04-14 13:46:56 +0000951 error_ok=True).strip() == 'true')
952 return self.gerrit_skip_ensure_authenticated
953
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000954 def GetGitEditor(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000955 """Returns the editor specified in the git config, or None if none is."""
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000956 if self.git_editor is None:
Raul Tambre5a525872019-02-12 19:08:08 +0000957 # Git requires single quotes for paths with spaces. We need to replace
958 # them with double quotes for Windows to treat such paths as a single
959 # path.
960 self.git_editor = self._GetConfig(
961 'core.editor', error_ok=True).replace('\'', '"')
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000962 return self.git_editor or None
963
thestig@chromium.org44202a22014-03-11 19:22:18 +0000964 def GetLintRegex(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000965 return (self._GetConfig('rietveld.cpplint-regex', error_ok=True) or
thestig@chromium.org44202a22014-03-11 19:22:18 +0000966 DEFAULT_LINT_REGEX)
967
968 def GetLintIgnoreRegex(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000969 return (self._GetConfig('rietveld.cpplint-ignore-regex', error_ok=True) or
thestig@chromium.org44202a22014-03-11 19:22:18 +0000970 DEFAULT_LINT_IGNORE_REGEX)
971
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000972 def _GetConfig(self, param, **kwargs):
973 self.LazyUpdateIfNeeded()
974 return RunGit(['config', param], **kwargs).strip()
975
976
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000977def ShortBranchName(branch):
978 """Convert a name like 'refs/heads/foo' to just 'foo'."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000979 return branch.replace('refs/heads/', '', 1)
980
981
982def GetCurrentBranchRef():
983 """Returns branch ref (e.g., refs/heads/master) or None."""
984 return RunGit(['symbolic-ref', 'HEAD'],
985 stderr=subprocess2.VOID, error_ok=True).strip() or None
986
987
988def GetCurrentBranch():
989 """Returns current branch or None.
990
991 For refs/heads/* branches, returns just last part. For others, full ref.
992 """
993 branchref = GetCurrentBranchRef()
994 if branchref:
995 return ShortBranchName(branchref)
996 return None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000997
998
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000999class _CQState(object):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00001000 """Enum for states of CL with respect to CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001001 NONE = 'none'
1002 DRY_RUN = 'dry_run'
1003 COMMIT = 'commit'
1004
1005 ALL_STATES = [NONE, DRY_RUN, COMMIT]
1006
1007
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001008class _ParsedIssueNumberArgument(object):
Edward Lemurf38bc172019-09-03 21:02:13 +00001009 def __init__(self, issue=None, patchset=None, hostname=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001010 self.issue = issue
1011 self.patchset = patchset
1012 self.hostname = hostname
1013
1014 @property
1015 def valid(self):
1016 return self.issue is not None
1017
1018
Edward Lemurf38bc172019-09-03 21:02:13 +00001019def ParseIssueNumberArgument(arg):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001020 """Parses the issue argument and returns _ParsedIssueNumberArgument."""
1021 fail_result = _ParsedIssueNumberArgument()
1022
1023 if arg.isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00001024 return _ParsedIssueNumberArgument(issue=int(arg))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001025 if not arg.startswith('http'):
1026 return fail_result
Aaron Gableaee6c852017-06-26 12:49:01 -07001027
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001028 url = gclient_utils.UpgradeToHttps(arg)
1029 try:
1030 parsed_url = urlparse.urlparse(url)
1031 except ValueError:
1032 return fail_result
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02001033
Edward Lemur125d60a2019-09-13 18:25:41 +00001034 return Changelist.ParseIssueURL(parsed_url) or fail_result
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001035
1036
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00001037def _create_description_from_log(args):
1038 """Pulls out the commit log to use as a base for the CL description."""
1039 log_args = []
1040 if len(args) == 1 and not args[0].endswith('.'):
1041 log_args = [args[0] + '..']
1042 elif len(args) == 1 and args[0].endswith('...'):
1043 log_args = [args[0][:-1]]
1044 elif len(args) == 2:
1045 log_args = [args[0] + '..' + args[1]]
1046 else:
1047 log_args = args[:] # Hope for the best!
1048 return RunGit(['log', '--pretty=format:%s\n\n%b'] + log_args)
1049
1050
Aaron Gablea45ee112016-11-22 15:14:38 -08001051class GerritChangeNotExists(Exception):
tandriic2405f52016-10-10 08:13:15 -07001052 def __init__(self, issue, url):
1053 self.issue = issue
1054 self.url = url
Aaron Gablea45ee112016-11-22 15:14:38 -08001055 super(GerritChangeNotExists, self).__init__()
tandriic2405f52016-10-10 08:13:15 -07001056
1057 def __str__(self):
Aaron Gablea45ee112016-11-22 15:14:38 -08001058 return 'change %s at %s does not exist or you have no access to it' % (
tandriic2405f52016-10-10 08:13:15 -07001059 self.issue, self.url)
1060
1061
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001062_CommentSummary = collections.namedtuple(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001063 '_CommentSummary', ['date', 'message', 'sender', 'autogenerated',
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001064 # TODO(tandrii): these two aren't known in Gerrit.
1065 'approval', 'disapproval'])
1066
1067
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001068class Changelist(object):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001069 """Changelist works with one changelist in local branch.
1070
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00001071 Notes:
1072 * Not safe for concurrent multi-{thread,process} use.
1073 * Caches values from current branch. Therefore, re-use after branch change
tandrii5d48c322016-08-18 16:19:37 -07001074 with great care.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001075 """
1076
Edward Lemur125d60a2019-09-13 18:25:41 +00001077 def __init__(self, branchref=None, issue=None, codereview_host=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001078 """Create a new ChangeList instance.
1079
Edward Lemurf38bc172019-09-03 21:02:13 +00001080 **kwargs will be passed directly to Gerrit implementation.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001081 """
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001082 # Poke settings so we get the "configure your server" message if necessary.
maruel@chromium.org379d07a2011-11-30 14:58:10 +00001083 global settings
1084 if not settings:
1085 # Happens when git_cl.py is used as a utility library.
1086 settings = Settings()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001087
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001088 self.branchref = branchref
1089 if self.branchref:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00001090 assert branchref.startswith('refs/heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001091 self.branch = ShortBranchName(self.branchref)
1092 else:
1093 self.branch = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001094 self.upstream_branch = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001095 self.lookedup_issue = False
1096 self.issue = issue or None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001097 self.has_description = False
1098 self.description = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001099 self.lookedup_patchset = False
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001100 self.patchset = None
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001101 self.cc = None
Daniel Cheng7227d212017-11-17 08:12:37 -08001102 self.more_cc = []
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001103 self._remote = None
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001104 self._cached_remote_url = (False, None) # (is_cached, value)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001105
Edward Lemur125d60a2019-09-13 18:25:41 +00001106 # Lazily cached values.
1107 self._gerrit_host = None # e.g. chromium-review.googlesource.com
1108 self._gerrit_server = None # e.g. https://chromium-review.googlesource.com
1109 # Map from change number (issue) to its detail cache.
1110 self._detail_cache = {}
1111
1112 if codereview_host is not None:
1113 assert not codereview_host.startswith('https://'), codereview_host
1114 self._gerrit_host = codereview_host
1115 self._gerrit_server = 'https://%s' % codereview_host
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001116
1117 def GetCCList(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001118 """Returns the users cc'd on this CL.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001119
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001120 The return value is a string suitable for passing to git cl with the --cc
1121 flag.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001122 """
1123 if self.cc is None:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001124 base_cc = settings.GetDefaultCCList()
Daniel Cheng7227d212017-11-17 08:12:37 -08001125 more_cc = ','.join(self.more_cc)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001126 self.cc = ','.join(filter(None, (base_cc, more_cc))) or ''
1127 return self.cc
1128
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001129 def GetCCListWithoutDefault(self):
1130 """Return the users cc'd on this CL excluding default ones."""
1131 if self.cc is None:
Daniel Cheng7227d212017-11-17 08:12:37 -08001132 self.cc = ','.join(self.more_cc)
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001133 return self.cc
1134
Daniel Cheng7227d212017-11-17 08:12:37 -08001135 def ExtendCC(self, more_cc):
1136 """Extends the list of users to cc on this CL based on the changed files."""
1137 self.more_cc.extend(more_cc)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001138
1139 def GetBranch(self):
1140 """Returns the short branch name, e.g. 'master'."""
1141 if not self.branch:
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001142 branchref = GetCurrentBranchRef()
szager@chromium.orgd62c61f2014-10-20 22:33:21 +00001143 if not branchref:
1144 return None
1145 self.branchref = branchref
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001146 self.branch = ShortBranchName(self.branchref)
1147 return self.branch
1148
1149 def GetBranchRef(self):
1150 """Returns the full branch name, e.g. 'refs/heads/master'."""
1151 self.GetBranch() # Poke the lazy loader.
1152 return self.branchref
1153
tandrii@chromium.org534f67a2016-04-07 18:47:05 +00001154 def ClearBranch(self):
1155 """Clears cached branch data of this object."""
1156 self.branch = self.branchref = None
1157
tandrii5d48c322016-08-18 16:19:37 -07001158 def _GitGetBranchConfigValue(self, key, default=None, **kwargs):
1159 assert 'branch' not in kwargs, 'this CL branch is used automatically'
1160 kwargs['branch'] = self.GetBranch()
1161 return _git_get_branch_config_value(key, default, **kwargs)
1162
1163 def _GitSetBranchConfigValue(self, key, value, **kwargs):
1164 assert 'branch' not in kwargs, 'this CL branch is used automatically'
1165 assert self.GetBranch(), (
1166 'this CL must have an associated branch to %sset %s%s' %
1167 ('un' if value is None else '',
1168 key,
1169 '' if value is None else ' to %r' % value))
1170 kwargs['branch'] = self.GetBranch()
1171 return _git_set_branch_config_value(key, value, **kwargs)
1172
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001173 @staticmethod
1174 def FetchUpstreamTuple(branch):
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001175 """Returns a tuple containing remote and remote ref,
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001176 e.g. 'origin', 'refs/heads/master'
1177 """
1178 remote = '.'
tandrii5d48c322016-08-18 16:19:37 -07001179 upstream_branch = _git_get_branch_config_value('merge', branch=branch)
1180
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001181 if upstream_branch:
tandrii5d48c322016-08-18 16:19:37 -07001182 remote = _git_get_branch_config_value('remote', branch=branch)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001183 else:
bauerb@chromium.orgade368c2011-03-01 08:57:50 +00001184 upstream_branch = RunGit(['config', 'rietveld.upstream-branch'],
1185 error_ok=True).strip()
1186 if upstream_branch:
1187 remote = RunGit(['config', 'rietveld.upstream-remote']).strip()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001188 else:
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001189 # Else, try to guess the origin remote.
1190 remote_branches = RunGit(['branch', '-r']).split()
1191 if 'origin/master' in remote_branches:
1192 # Fall back on origin/master if it exits.
1193 remote = 'origin'
1194 upstream_branch = 'refs/heads/master'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001195 else:
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001196 DieWithError(
1197 'Unable to determine default branch to diff against.\n'
1198 'Either pass complete "git diff"-style arguments, like\n'
1199 ' git cl upload origin/master\n'
1200 'or verify this branch is set up to track another \n'
1201 '(via the --track argument to "git checkout -b ...").')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001202
1203 return remote, upstream_branch
1204
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001205 def GetCommonAncestorWithUpstream(self):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001206 upstream_branch = self.GetUpstreamBranch()
1207 if not BranchExists(upstream_branch):
1208 DieWithError('The upstream for the current branch (%s) does not exist '
1209 'anymore.\nPlease fix it and try again.' % self.GetBranch())
iannucci@chromium.org9e849272014-04-04 00:31:55 +00001210 return git_common.get_or_create_merge_base(self.GetBranch(),
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001211 upstream_branch)
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001212
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001213 def GetUpstreamBranch(self):
1214 if self.upstream_branch is None:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001215 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Raul Tambrefe1dbe12019-05-02 04:43:57 +00001216 if remote != '.':
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001217 upstream_branch = upstream_branch.replace('refs/heads/',
1218 'refs/remotes/%s/' % remote)
1219 upstream_branch = upstream_branch.replace('refs/branch-heads/',
1220 'refs/remotes/branch-heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001221 self.upstream_branch = upstream_branch
1222 return self.upstream_branch
1223
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001224 def GetRemoteBranch(self):
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001225 if not self._remote:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001226 remote, branch = None, self.GetBranch()
1227 seen_branches = set()
1228 while branch not in seen_branches:
1229 seen_branches.add(branch)
1230 remote, branch = self.FetchUpstreamTuple(branch)
1231 branch = ShortBranchName(branch)
1232 if remote != '.' or branch.startswith('refs/remotes'):
1233 break
1234 else:
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001235 remotes = RunGit(['remote'], error_ok=True).split()
1236 if len(remotes) == 1:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001237 remote, = remotes
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001238 elif 'origin' in remotes:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001239 remote = 'origin'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001240 logging.warn('Could not determine which remote this change is '
1241 'associated with, so defaulting to "%s".' % self._remote)
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001242 else:
1243 logging.warn('Could not determine which remote this change is '
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001244 'associated with.')
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001245 branch = 'HEAD'
1246 if branch.startswith('refs/remotes'):
1247 self._remote = (remote, branch)
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001248 elif branch.startswith('refs/branch-heads/'):
1249 self._remote = (remote, branch.replace('refs/', 'refs/remotes/'))
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001250 else:
1251 self._remote = (remote, 'refs/remotes/%s/%s' % (remote, branch))
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001252 return self._remote
1253
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001254 def GitSanityChecks(self, upstream_git_obj):
1255 """Checks git repo status and ensures diff is from local commits."""
1256
sbc@chromium.org79706062015-01-14 21:18:12 +00001257 if upstream_git_obj is None:
1258 if self.GetBranch() is None:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001259 print('ERROR: Unable to determine current branch (detached HEAD?)',
vapiera7fbd5a2016-06-16 09:17:49 -07001260 file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001261 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001262 print('ERROR: No upstream branch.', file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001263 return False
1264
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001265 # Verify the commit we're diffing against is in our current branch.
1266 upstream_sha = RunGit(['rev-parse', '--verify', upstream_git_obj]).strip()
1267 common_ancestor = RunGit(['merge-base', upstream_sha, 'HEAD']).strip()
1268 if upstream_sha != common_ancestor:
vapiera7fbd5a2016-06-16 09:17:49 -07001269 print('ERROR: %s is not in the current branch. You may need to rebase '
1270 'your tracking branch' % upstream_sha, file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001271 return False
1272
1273 # List the commits inside the diff, and verify they are all local.
1274 commits_in_diff = RunGit(
1275 ['rev-list', '^%s' % upstream_sha, 'HEAD']).splitlines()
1276 code, remote_branch = RunGitWithCode(['config', 'gitcl.remotebranch'])
1277 remote_branch = remote_branch.strip()
1278 if code != 0:
1279 _, remote_branch = self.GetRemoteBranch()
1280
1281 commits_in_remote = RunGit(
1282 ['rev-list', '^%s' % upstream_sha, remote_branch]).splitlines()
1283
1284 common_commits = set(commits_in_diff) & set(commits_in_remote)
1285 if common_commits:
vapiera7fbd5a2016-06-16 09:17:49 -07001286 print('ERROR: Your diff contains %d commits already in %s.\n'
1287 'Run "git log --oneline %s..HEAD" to get a list of commits in '
1288 'the diff. If you are using a custom git flow, you can override'
1289 ' the reference used for this check with "git config '
1290 'gitcl.remotebranch <git-ref>".' % (
1291 len(common_commits), remote_branch, upstream_git_obj),
1292 file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001293 return False
1294 return True
1295
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001296 def GetGitBaseUrlFromConfig(self):
sheyang@chromium.orga656e702014-05-15 20:43:05 +00001297 """Return the configured base URL from branch.<branchname>.baseurl.
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001298
1299 Returns None if it is not set.
1300 """
tandrii5d48c322016-08-18 16:19:37 -07001301 return self._GitGetBranchConfigValue('base-url')
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001302
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001303 def GetRemoteUrl(self):
1304 """Return the configured remote URL, e.g. 'git://example.org/foo.git/'.
1305
1306 Returns None if there is no remote.
1307 """
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001308 is_cached, value = self._cached_remote_url
1309 if is_cached:
1310 return value
1311
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001312 remote, _ = self.GetRemoteBranch()
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001313 url = RunGit(['config', 'remote.%s.url' % remote], error_ok=True).strip()
1314
Edward Lemur298f2cf2019-02-22 21:40:39 +00001315 # Check if the remote url can be parsed as an URL.
1316 host = urlparse.urlparse(url).netloc
1317 if host:
1318 self._cached_remote_url = (True, url)
1319 return url
1320
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001321 # If it cannot be parsed as an url, assume it is a local directory,
1322 # probably a git cache.
Edward Lemur298f2cf2019-02-22 21:40:39 +00001323 logging.warning('"%s" doesn\'t appear to point to a git host. '
1324 'Interpreting it as a local directory.', url)
1325 if not os.path.isdir(url):
1326 logging.error(
1327 'Remote "%s" for branch "%s" points to "%s", but it doesn\'t exist.',
Daniel Bratell4a60db42019-09-16 17:02:52 +00001328 remote, self.GetBranch(), url)
Edward Lemur298f2cf2019-02-22 21:40:39 +00001329 return None
1330
1331 cache_path = url
1332 url = RunGit(['config', 'remote.%s.url' % remote],
1333 error_ok=True,
1334 cwd=url).strip()
1335
1336 host = urlparse.urlparse(url).netloc
1337 if not host:
1338 logging.error(
1339 'Remote "%(remote)s" for branch "%(branch)s" points to '
1340 '"%(cache_path)s", but it is misconfigured.\n'
1341 '"%(cache_path)s" must be a git repo and must have a remote named '
1342 '"%(remote)s" pointing to the git host.', {
1343 'remote': remote,
1344 'cache_path': cache_path,
1345 'branch': self.GetBranch()})
1346 return None
1347
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001348 self._cached_remote_url = (True, url)
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001349 return url
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001350
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001351 def GetIssue(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001352 """Returns the issue number as a int or None if not set."""
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001353 if self.issue is None and not self.lookedup_issue:
tandrii5d48c322016-08-18 16:19:37 -07001354 self.issue = self._GitGetBranchConfigValue(
Edward Lemur125d60a2019-09-13 18:25:41 +00001355 self.IssueConfigKey(), value_type=int)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001356 self.lookedup_issue = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001357 return self.issue
1358
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001359 def GetIssueURL(self):
1360 """Get the URL for a particular issue."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001361 issue = self.GetIssue()
1362 if not issue:
dbeam@chromium.org015fd3d2013-06-18 19:02:50 +00001363 return None
Edward Lemur125d60a2019-09-13 18:25:41 +00001364 return '%s/%s' % (self.GetCodereviewServer(), issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001365
Andrii Shyshkalov31863012017-02-08 11:35:12 +01001366 def GetDescription(self, pretty=False, force=False):
1367 if not self.has_description or force:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001368 if self.GetIssue():
Edward Lemur125d60a2019-09-13 18:25:41 +00001369 self.description = self.FetchDescription(force=force)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001370 self.has_description = True
1371 if pretty:
Asanka Herath7c61dcb2016-12-14 13:01:58 -05001372 # Set width to 72 columns + 2 space indent.
1373 wrapper = textwrap.TextWrapper(width=74, replace_whitespace=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001374 wrapper.initial_indent = wrapper.subsequent_indent = ' '
Asanka Herath7c61dcb2016-12-14 13:01:58 -05001375 lines = self.description.splitlines()
1376 return '\n'.join([wrapper.fill(line) for line in lines])
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001377 return self.description
1378
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001379 def GetDescriptionFooters(self):
1380 """Returns (non_footer_lines, footers) for the commit message.
1381
1382 Returns:
1383 non_footer_lines (list(str)) - Simple list of description lines without
1384 any footer. The lines do not contain newlines, nor does the list contain
1385 the empty line between the message and the footers.
1386 footers (list(tuple(KEY, VALUE))) - List of parsed footers, e.g.
1387 [("Change-Id", "Ideadbeef...."), ...]
1388 """
1389 raw_description = self.GetDescription()
1390 msg_lines, _, footers = git_footers.split_footers(raw_description)
1391 if footers:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001392 msg_lines = msg_lines[:len(msg_lines) - 1]
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001393 return msg_lines, footers
1394
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001395 def GetPatchset(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001396 """Returns the patchset number as a int or None if not set."""
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001397 if self.patchset is None and not self.lookedup_patchset:
tandrii5d48c322016-08-18 16:19:37 -07001398 self.patchset = self._GitGetBranchConfigValue(
Edward Lemur125d60a2019-09-13 18:25:41 +00001399 self.PatchsetConfigKey(), value_type=int)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001400 self.lookedup_patchset = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001401 return self.patchset
1402
1403 def SetPatchset(self, patchset):
tandrii5d48c322016-08-18 16:19:37 -07001404 """Set this branch's patchset. If patchset=0, clears the patchset."""
1405 assert self.GetBranch()
1406 if not patchset:
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001407 self.patchset = None
tandrii5d48c322016-08-18 16:19:37 -07001408 else:
1409 self.patchset = int(patchset)
1410 self._GitSetBranchConfigValue(
Edward Lemur125d60a2019-09-13 18:25:41 +00001411 self.PatchsetConfigKey(), self.patchset)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001412
tandrii@chromium.orga342c922016-03-16 07:08:25 +00001413 def SetIssue(self, issue=None):
tandrii5d48c322016-08-18 16:19:37 -07001414 """Set this branch's issue. If issue isn't given, clears the issue."""
1415 assert self.GetBranch()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001416 if issue:
tandrii5d48c322016-08-18 16:19:37 -07001417 issue = int(issue)
1418 self._GitSetBranchConfigValue(
Edward Lemur125d60a2019-09-13 18:25:41 +00001419 self.IssueConfigKey(), issue)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001420 self.issue = issue
Edward Lemur125d60a2019-09-13 18:25:41 +00001421 codereview_server = self.GetCodereviewServer()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001422 if codereview_server:
tandrii5d48c322016-08-18 16:19:37 -07001423 self._GitSetBranchConfigValue(
Edward Lemur125d60a2019-09-13 18:25:41 +00001424 self.CodereviewServerConfigKey(),
tandrii5d48c322016-08-18 16:19:37 -07001425 codereview_server)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001426 else:
tandrii5d48c322016-08-18 16:19:37 -07001427 # Reset all of these just to be clean.
1428 reset_suffixes = [
1429 'last-upload-hash',
Edward Lemur125d60a2019-09-13 18:25:41 +00001430 self.IssueConfigKey(),
1431 self.PatchsetConfigKey(),
1432 self.CodereviewServerConfigKey(),
tandrii5d48c322016-08-18 16:19:37 -07001433 ] + self._PostUnsetIssueProperties()
1434 for prop in reset_suffixes:
1435 self._GitSetBranchConfigValue(prop, None, error_ok=True)
Aaron Gableca01e2c2017-07-19 11:16:02 -07001436 msg = RunGit(['log', '-1', '--format=%B']).strip()
1437 if msg and git_footers.get_footer_change_id(msg):
1438 print('WARNING: The change patched into this branch has a Change-Id. '
1439 'Removing it.')
1440 RunGit(['commit', '--amend', '-m',
1441 git_footers.remove_footer(msg, 'Change-Id')])
Edward Lemurf38bc172019-09-03 21:02:13 +00001442 self.lookedup_issue = True
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001443 self.issue = None
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001444 self.patchset = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001445
dnjba1b0f32016-09-02 12:37:42 -07001446 def GetChange(self, upstream_branch, author, local_description=False):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001447 if not self.GitSanityChecks(upstream_branch):
1448 DieWithError('\nGit sanity check failure')
1449
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001450 root = settings.GetRelativeRoot()
bratell@opera.comf267b0e2013-05-02 09:11:43 +00001451 if not root:
1452 root = '.'
bauerb@chromium.org512f1ef2011-04-20 15:17:57 +00001453 absroot = os.path.abspath(root)
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001454
1455 # We use the sha1 of HEAD as a name of this change.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001456 name = RunGitWithCode(['rev-parse', 'HEAD'])[1].strip()
bauerb@chromium.org512f1ef2011-04-20 15:17:57 +00001457 # Need to pass a relative path for msysgit.
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001458 try:
maruel@chromium.org80a9ef12011-12-13 20:44:10 +00001459 files = scm.GIT.CaptureStatus([root], '.', upstream_branch)
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001460 except subprocess2.CalledProcessError:
1461 DieWithError(
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001462 ('\nFailed to diff against upstream branch %s\n\n'
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001463 'This branch probably doesn\'t exist anymore. To reset the\n'
1464 'tracking branch, please run\n'
stip7a3dd352016-09-22 17:32:28 -07001465 ' git branch --set-upstream-to origin/master %s\n'
1466 'or replace origin/master with the relevant branch') %
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001467 (upstream_branch, self.GetBranch()))
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001468
maruel@chromium.org52424302012-08-29 15:14:30 +00001469 issue = self.GetIssue()
1470 patchset = self.GetPatchset()
dnjba1b0f32016-09-02 12:37:42 -07001471 if issue and not local_description:
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001472 description = self.GetDescription()
1473 else:
1474 # If the change was never uploaded, use the log messages of all commits
1475 # up to the branch point, as git cl upload will prefill the description
1476 # with these log messages.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001477 args = ['log', '--pretty=format:%s%n%n%b', '%s...' % (upstream_branch)]
1478 description = RunGitWithCode(args)[1].strip()
maruel@chromium.org03b3bdc2011-06-14 13:04:12 +00001479
1480 if not author:
maruel@chromium.org13f623c2011-07-22 16:02:23 +00001481 author = RunGit(['config', 'user.email']).strip() or None
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001482 return presubmit_support.GitChange(
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001483 name,
1484 description,
1485 absroot,
1486 files,
1487 issue,
1488 patchset,
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001489 author,
1490 upstream=upstream_branch)
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001491
dsansomee2d6fd92016-09-08 00:10:47 -07001492 def UpdateDescription(self, description, force=False):
Edward Lemur125d60a2019-09-13 18:25:41 +00001493 self.UpdateDescriptionRemote(description, force=force)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001494 self.description = description
Andrii Shyshkalov83051152017-02-07 23:47:29 +01001495 self.has_description = True
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001496
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001497 def UpdateDescriptionFooters(self, description_lines, footers, force=False):
1498 """Sets the description for this CL remotely.
1499
1500 You can get description_lines and footers with GetDescriptionFooters.
1501
1502 Args:
1503 description_lines (list(str)) - List of CL description lines without
1504 newline characters.
1505 footers (list(tuple(KEY, VALUE))) - List of footers, as returned by
1506 GetDescriptionFooters. Key must conform to the git footers format (i.e.
1507 `List-Of-Tokens`). It will be case-normalized so that each token is
1508 title-cased.
1509 """
1510 new_description = '\n'.join(description_lines)
1511 if footers:
1512 new_description += '\n'
1513 for k, v in footers:
1514 foot = '%s: %s' % (git_footers.normalize_name(k), v)
1515 if not git_footers.FOOTER_PATTERN.match(foot):
1516 raise ValueError('Invalid footer %r' % foot)
1517 new_description += foot + '\n'
1518 self.UpdateDescription(new_description, force)
1519
Edward Lesmes8e282792018-04-03 18:50:29 -04001520 def RunHook(self, committing, may_prompt, verbose, change, parallel):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001521 """Calls sys.exit() if the hook fails; returns a HookResults otherwise."""
1522 try:
Edward Lemur2c48f242019-06-04 16:14:09 +00001523 start = time_time()
1524 result = presubmit_support.DoPresubmitChecks(change, committing,
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001525 verbose=verbose, output_stream=sys.stdout, input_stream=sys.stdin,
1526 default_presubmit=None, may_prompt=may_prompt,
Edward Lemur125d60a2019-09-13 18:25:41 +00001527 gerrit_obj=self.GetGerritObjForPresubmit(),
Edward Lesmes8e282792018-04-03 18:50:29 -04001528 parallel=parallel)
Edward Lemur2c48f242019-06-04 16:14:09 +00001529 metrics.collector.add_repeated('sub_commands', {
1530 'command': 'presubmit',
1531 'execution_time': time_time() - start,
1532 'exit_code': 0 if result.should_continue() else 1,
1533 })
1534 return result
vapierfd77ac72016-06-16 08:33:57 -07001535 except presubmit_support.PresubmitFailure as e:
Aaron Gable5d5f22c2018-02-02 09:12:41 -08001536 DieWithError('%s\nMaybe your depot_tools is out of date?' % e)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001537
Edward Lemurf38bc172019-09-03 21:02:13 +00001538 def CMDPatchIssue(self, issue_arg, nocommit):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001539 """Fetches and applies the issue patch from codereview to local branch."""
tandrii@chromium.orgef7c68c2016-04-07 09:39:39 +00001540 if isinstance(issue_arg, (int, long)) or issue_arg.isdigit():
1541 parsed_issue_arg = _ParsedIssueNumberArgument(int(issue_arg))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001542 else:
1543 # Assume url.
Edward Lemur125d60a2019-09-13 18:25:41 +00001544 parsed_issue_arg = self.ParseIssueURL(
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001545 urlparse.urlparse(issue_arg))
1546 if not parsed_issue_arg or not parsed_issue_arg.valid:
1547 DieWithError('Failed to parse issue argument "%s". '
1548 'Must be an issue number or a valid URL.' % issue_arg)
Edward Lemur125d60a2019-09-13 18:25:41 +00001549 return self.CMDPatchWithParsedIssue(
Edward Lemurf38bc172019-09-03 21:02:13 +00001550 parsed_issue_arg, nocommit, False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001551
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001552 def CMDUpload(self, options, git_diff_args, orig_args):
1553 """Uploads a change to codereview."""
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001554 custom_cl_base = None
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001555 if git_diff_args:
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001556 custom_cl_base = base_branch = git_diff_args[0]
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001557 else:
1558 if self.GetBranch() is None:
1559 DieWithError('Can\'t upload from detached HEAD state. Get on a branch!')
1560
1561 # Default to diffing against common ancestor of upstream branch
1562 base_branch = self.GetCommonAncestorWithUpstream()
1563 git_diff_args = [base_branch, 'HEAD']
1564
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001565 # Fast best-effort checks to abort before running potentially expensive
1566 # hooks if uploading is likely to fail anyway. Passing these checks does
1567 # not guarantee that uploading will not fail.
Edward Lemur125d60a2019-09-13 18:25:41 +00001568 self.EnsureAuthenticated(force=options.force)
1569 self.EnsureCanUploadPatchset(force=options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001570
1571 # Apply watchlists on upload.
1572 change = self.GetChange(base_branch, None)
1573 watchlist = watchlists.Watchlists(change.RepositoryRoot())
1574 files = [f.LocalPath() for f in change.AffectedFiles()]
1575 if not options.bypass_watchlists:
Daniel Cheng7227d212017-11-17 08:12:37 -08001576 self.ExtendCC(watchlist.GetWatchersForPaths(files))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001577
1578 if not options.bypass_hooks:
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001579 if options.reviewers or options.tbrs or options.add_owners_to:
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001580 # Set the reviewer list now so that presubmit checks can access it.
1581 change_description = ChangeDescription(change.FullDescriptionText())
1582 change_description.update_reviewers(options.reviewers,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001583 options.tbrs,
Robert Iannuccif2708bd2017-04-17 15:49:02 -07001584 options.add_owners_to,
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001585 change)
1586 change.SetDescriptionText(change_description.description)
1587 hook_results = self.RunHook(committing=False,
Edward Lesmes8e282792018-04-03 18:50:29 -04001588 may_prompt=not options.force,
1589 verbose=options.verbose,
1590 change=change, parallel=options.parallel)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001591 if not hook_results.should_continue():
1592 return 1
1593 if not options.reviewers and hook_results.reviewers:
1594 options.reviewers = hook_results.reviewers.split(',')
Daniel Cheng7227d212017-11-17 08:12:37 -08001595 self.ExtendCC(hook_results.more_cc)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001596
Aaron Gable13101a62018-02-09 13:20:41 -08001597 print_stats(git_diff_args)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001598 ret = self.CMDUploadChange(options, git_diff_args, custom_cl_base, change)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001599 if not ret:
tandrii5d48c322016-08-18 16:19:37 -07001600 _git_set_branch_config_value('last-upload-hash',
1601 RunGit(['rev-parse', 'HEAD']).strip())
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001602 # Run post upload hooks, if specified.
1603 if settings.GetRunPostUploadHook():
1604 presubmit_support.DoPostUploadExecuter(
1605 change,
1606 self,
1607 settings.GetRoot(),
1608 options.verbose,
1609 sys.stdout)
1610
1611 # Upload all dependencies if specified.
1612 if options.dependencies:
vapiera7fbd5a2016-06-16 09:17:49 -07001613 print()
1614 print('--dependencies has been specified.')
1615 print('All dependent local branches will be re-uploaded.')
1616 print()
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001617 # Remove the dependencies flag from args so that we do not end up in a
1618 # loop.
1619 orig_args.remove('--dependencies')
1620 ret = upload_branch_deps(self, orig_args)
1621 return ret
1622
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001623 def SetCQState(self, new_state):
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001624 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001625
1626 Issue must have been already uploaded and known.
1627 """
1628 assert new_state in _CQState.ALL_STATES
1629 assert self.GetIssue()
qyearsley1fdfcb62016-10-24 13:22:03 -07001630 try:
Edward Lemur125d60a2019-09-13 18:25:41 +00001631 vote_map = {
1632 _CQState.NONE: 0,
1633 _CQState.DRY_RUN: 1,
1634 _CQState.COMMIT: 2,
1635 }
1636 labels = {'Commit-Queue': vote_map[new_state]}
1637 notify = False if new_state == _CQState.DRY_RUN else None
1638 gerrit_util.SetReview(
1639 self._GetGerritHost(), self._GerritChangeIdentifier(),
1640 labels=labels, notify=notify)
qyearsley1fdfcb62016-10-24 13:22:03 -07001641 return 0
1642 except KeyboardInterrupt:
1643 raise
1644 except:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001645 print('WARNING: Failed to %s.\n'
qyearsley1fdfcb62016-10-24 13:22:03 -07001646 'Either:\n'
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001647 ' * Your project has no CQ,\n'
1648 ' * You don\'t have permission to change the CQ state,\n'
1649 ' * There\'s a bug in this code (see stack trace below).\n'
1650 'Consider specifying which bots to trigger manually or asking your '
1651 'project owners for permissions or contacting Chrome Infra at:\n'
1652 'https://www.chromium.org/infra\n\n' %
1653 ('cancel CQ' if new_state == _CQState.NONE else 'trigger CQ'))
qyearsley1fdfcb62016-10-24 13:22:03 -07001654 # Still raise exception so that stack trace is printed.
1655 raise
1656
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001657 def _GetGerritHost(self):
1658 # Lazy load of configs.
1659 self.GetCodereviewServer()
tandriie32e3ea2016-06-22 02:52:48 -07001660 if self._gerrit_host and '.' not in self._gerrit_host:
1661 # Abbreviated domain like "chromium" instead of chromium.googlesource.com.
1662 # This happens for internal stuff http://crbug.com/614312.
1663 parsed = urlparse.urlparse(self.GetRemoteUrl())
1664 if parsed.scheme == 'sso':
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001665 print('WARNING: using non-https URLs for remote is likely broken\n'
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001666 ' Your current remote is: %s' % self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001667 self._gerrit_host = '%s.googlesource.com' % self._gerrit_host
1668 self._gerrit_server = 'https://%s' % self._gerrit_host
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001669 return self._gerrit_host
1670
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001671 def _GetGitHost(self):
1672 """Returns git host to be used when uploading change to Gerrit."""
Edward Lemur298f2cf2019-02-22 21:40:39 +00001673 remote_url = self.GetRemoteUrl()
1674 if not remote_url:
1675 return None
1676 return urlparse.urlparse(remote_url).netloc
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001677
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001678 def GetCodereviewServer(self):
1679 if not self._gerrit_server:
1680 # If we're on a branch then get the server potentially associated
1681 # with that branch.
1682 if self.GetIssue():
tandrii5d48c322016-08-18 16:19:37 -07001683 self._gerrit_server = self._GitGetBranchConfigValue(
1684 self.CodereviewServerConfigKey())
1685 if self._gerrit_server:
1686 self._gerrit_host = urlparse.urlparse(self._gerrit_server).netloc
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001687 if not self._gerrit_server:
1688 # We assume repo to be hosted on Gerrit, and hence Gerrit server
1689 # has "-review" suffix for lowest level subdomain.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001690 parts = self._GetGitHost().split('.')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001691 parts[0] = parts[0] + '-review'
1692 self._gerrit_host = '.'.join(parts)
1693 self._gerrit_server = 'https://%s' % self._gerrit_host
1694 return self._gerrit_server
1695
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001696 def _GetGerritProject(self):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001697 """Returns Gerrit project name based on remote git URL."""
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001698 remote_url = self.GetRemoteUrl()
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001699 if remote_url is None:
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001700 logging.warn('can\'t detect Gerrit project.')
1701 return None
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001702 project = urlparse.urlparse(remote_url).path.strip('/')
1703 if project.endswith('.git'):
1704 project = project[:-len('.git')]
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001705 # *.googlesource.com hosts ensure that Git/Gerrit projects don't start with
1706 # 'a/' prefix, because 'a/' prefix is used to force authentication in
1707 # gitiles/git-over-https protocol. E.g.,
1708 # https://chromium.googlesource.com/a/v8/v8 refers to the same repo/project
1709 # as
1710 # https://chromium.googlesource.com/v8/v8
1711 if project.startswith('a/'):
1712 project = project[len('a/'):]
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001713 return project
1714
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001715 def _GerritChangeIdentifier(self):
1716 """Handy method for gerrit_util.ChangeIdentifier for a given CL.
1717
1718 Not to be confused by value of "Change-Id:" footer.
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001719 If Gerrit project can be determined, this will speed up Gerrit HTTP API RPC.
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001720 """
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001721 project = self._GetGerritProject()
1722 if project:
1723 return gerrit_util.ChangeIdentifier(project, self.GetIssue())
1724 # Fall back on still unique, but less efficient change number.
1725 return str(self.GetIssue())
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001726
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001727 @classmethod
tandrii5d48c322016-08-18 16:19:37 -07001728 def IssueConfigKey(cls):
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001729 return 'gerritissue'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001730
tandrii5d48c322016-08-18 16:19:37 -07001731 @classmethod
1732 def PatchsetConfigKey(cls):
1733 return 'gerritpatchset'
1734
1735 @classmethod
1736 def CodereviewServerConfigKey(cls):
1737 return 'gerritserver'
1738
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001739 def EnsureAuthenticated(self, force, refresh=None):
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001740 """Best effort check that user is authenticated with Gerrit server."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001741 if settings.GetGerritSkipEnsureAuthenticated():
1742 # For projects with unusual authentication schemes.
1743 # See http://crbug.com/603378.
1744 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001745
1746 # Check presence of cookies only if using cookies-based auth method.
1747 cookie_auth = gerrit_util.Authenticator.get()
1748 if not isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001749 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001750
Daniel Chengcf6269b2019-05-18 01:02:12 +00001751 if urlparse.urlparse(self.GetRemoteUrl()).scheme != 'https':
1752 print('WARNING: Ignoring branch %s with non-https remote %s' %
Edward Lemur125d60a2019-09-13 18:25:41 +00001753 (self.branch, self.GetRemoteUrl()))
Daniel Chengcf6269b2019-05-18 01:02:12 +00001754 return
1755
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001756 # Lazy-loader to identify Gerrit and Git hosts.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001757 self.GetCodereviewServer()
1758 git_host = self._GetGitHost()
Edward Lemur298f2cf2019-02-22 21:40:39 +00001759 assert self._gerrit_server and self._gerrit_host and git_host
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001760
1761 gerrit_auth = cookie_auth.get_auth_header(self._gerrit_host)
1762 git_auth = cookie_auth.get_auth_header(git_host)
1763 if gerrit_auth and git_auth:
1764 if gerrit_auth == git_auth:
1765 return
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001766 all_gsrc = cookie_auth.get_auth_header('d0esN0tEx1st.googlesource.com')
Raul Tambre80ee78e2019-05-06 22:41:05 +00001767 print(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001768 'WARNING: You have different credentials for Gerrit and git hosts:\n'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001769 ' %s\n'
1770 ' %s\n'
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001771 ' Consider running the following command:\n'
1772 ' git cl creds-check\n'
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001773 ' %s\n'
Raul Tambre80ee78e2019-05-06 22:41:05 +00001774 ' %s' %
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001775 (git_host, self._gerrit_host,
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001776 ('Hint: delete creds for .googlesource.com' if all_gsrc else ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001777 cookie_auth.get_new_password_message(git_host)))
1778 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001779 confirm_or_exit('If you know what you are doing', action='continue')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001780 return
1781 else:
1782 missing = (
Anna Henningsen4e891442017-07-06 21:40:58 +02001783 ([] if gerrit_auth else [self._gerrit_host]) +
1784 ([] if git_auth else [git_host]))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001785 DieWithError('Credentials for the following hosts are required:\n'
1786 ' %s\n'
1787 'These are read from %s (or legacy %s)\n'
1788 '%s' % (
1789 '\n '.join(missing),
1790 cookie_auth.get_gitcookies_path(),
1791 cookie_auth.get_netrc_path(),
1792 cookie_auth.get_new_password_message(git_host)))
1793
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001794 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001795 if not self.GetIssue():
1796 return
1797
1798 # Warm change details cache now to avoid RPCs later, reducing latency for
1799 # developers.
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001800 self._GetChangeDetail(
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +00001801 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS'])
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001802
1803 status = self._GetChangeDetail()['status']
1804 if status in ('MERGED', 'ABANDONED'):
1805 DieWithError('Change %s has been %s, new uploads are not allowed' %
1806 (self.GetIssueURL(),
1807 'submitted' if status == 'MERGED' else 'abandoned'))
1808
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001809 # TODO(vadimsh): For some reason the chunk of code below was skipped if
1810 # 'is_gce' is True. I'm just refactoring it to be 'skip if not cookies'.
1811 # Apparently this check is not very important? Otherwise get_auth_email
1812 # could have been added to other implementations of Authenticator.
1813 cookies_auth = gerrit_util.Authenticator.get()
1814 if not isinstance(cookies_auth, gerrit_util.CookiesAuthenticator):
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001815 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001816
1817 cookies_user = cookies_auth.get_auth_email(self._GetGerritHost())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001818 if self.GetIssueOwner() == cookies_user:
1819 return
1820 logging.debug('change %s owner is %s, cookies user is %s',
1821 self.GetIssue(), self.GetIssueOwner(), cookies_user)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001822 # Maybe user has linked accounts or something like that,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001823 # so ask what Gerrit thinks of this user.
1824 details = gerrit_util.GetAccountDetails(self._GetGerritHost(), 'self')
1825 if details['email'] == self.GetIssueOwner():
1826 return
1827 if not force:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001828 print('WARNING: Change %s is owned by %s, but you authenticate to Gerrit '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001829 'as %s.\n'
1830 'Uploading may fail due to lack of permissions.' %
1831 (self.GetIssue(), self.GetIssueOwner(), details['email']))
1832 confirm_or_exit(action='upload')
1833
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001834 def _PostUnsetIssueProperties(self):
1835 """Which branch-specific properties to erase when unsetting issue."""
tandrii5d48c322016-08-18 16:19:37 -07001836 return ['gerritsquashhash']
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001837
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001838 def GetGerritObjForPresubmit(self):
1839 return presubmit_support.GerritAccessor(self._GetGerritHost())
1840
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001841 def GetStatus(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001842 """Applies a rough heuristic to give a simple summary of an issue's review
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001843 or CQ status, assuming adherence to a common workflow.
1844
1845 Returns None if no issue for this branch, or one of the following keywords:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001846 * 'error' - error from review tool (including deleted issues)
1847 * 'unsent' - no reviewers added
1848 * 'waiting' - waiting for review
1849 * 'reply' - waiting for uploader to reply to review
1850 * 'lgtm' - Code-Review label has been set
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00001851 * 'dry-run' - dry-running in the CQ
1852 * 'commit' - in the CQ
Aaron Gable9ab38c62017-04-06 14:36:33 -07001853 * 'closed' - successfully submitted or abandoned
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001854 """
1855 if not self.GetIssue():
1856 return None
1857
1858 try:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001859 data = self._GetChangeDetail([
1860 'DETAILED_LABELS', 'CURRENT_REVISION', 'SUBMITTABLE'])
Aaron Gablea45ee112016-11-22 15:14:38 -08001861 except (httplib.HTTPException, GerritChangeNotExists):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001862 return 'error'
1863
tandrii@chromium.org5e1bf382016-05-17 08:43:24 +00001864 if data['status'] in ('ABANDONED', 'MERGED'):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001865 return 'closed'
1866
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001867 cq_label = data['labels'].get('Commit-Queue', {})
1868 max_cq_vote = 0
1869 for vote in cq_label.get('all', []):
1870 max_cq_vote = max(max_cq_vote, vote.get('value', 0))
1871 if max_cq_vote == 2:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001872 return 'commit'
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001873 if max_cq_vote == 1:
1874 return 'dry-run'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001875
Aaron Gable9ab38c62017-04-06 14:36:33 -07001876 if data['labels'].get('Code-Review', {}).get('approved'):
1877 return 'lgtm'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001878
1879 if not data.get('reviewers', {}).get('REVIEWER', []):
1880 return 'unsent'
1881
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001882 owner = data['owner'].get('_account_id')
Aaron Gable9ab38c62017-04-06 14:36:33 -07001883 messages = sorted(data.get('messages', []), key=lambda m: m.get('updated'))
1884 last_message_author = messages.pop().get('author', {})
1885 while last_message_author:
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001886 if last_message_author.get('email') == COMMIT_BOT_EMAIL:
1887 # Ignore replies from CQ.
Aaron Gable9ab38c62017-04-06 14:36:33 -07001888 last_message_author = messages.pop().get('author', {})
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001889 continue
Aaron Gable9ab38c62017-04-06 14:36:33 -07001890 if last_message_author.get('_account_id') == owner:
1891 # Most recent message was by owner.
1892 return 'waiting'
1893 else:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001894 # Some reply from non-owner.
1895 return 'reply'
Aaron Gable9ab38c62017-04-06 14:36:33 -07001896
1897 # Somehow there are no messages even though there are reviewers.
1898 return 'unsent'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001899
1900 def GetMostRecentPatchset(self):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001901 data = self._GetChangeDetail(['CURRENT_REVISION'])
Aaron Gablee8856ee2017-12-07 12:41:46 -08001902 patchset = data['revisions'][data['current_revision']]['_number']
1903 self.SetPatchset(patchset)
1904 return patchset
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001905
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001906 def FetchDescription(self, force=False):
1907 data = self._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'],
1908 no_cache=force)
tandrii@chromium.org2d3da632016-04-25 19:23:27 +00001909 current_rev = data['current_revision']
Dan Beamcf6df902018-11-08 01:48:37 +00001910 return data['revisions'][current_rev]['commit']['message'].encode(
1911 'utf-8', 'ignore')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001912
dsansomee2d6fd92016-09-08 00:10:47 -07001913 def UpdateDescriptionRemote(self, description, force=False):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001914 if gerrit_util.HasPendingChangeEdit(
1915 self._GetGerritHost(), self._GerritChangeIdentifier()):
dsansomee2d6fd92016-09-08 00:10:47 -07001916 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001917 confirm_or_exit(
dsansomee2d6fd92016-09-08 00:10:47 -07001918 'The description cannot be modified while the issue has a pending '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001919 'unpublished edit. Either publish the edit in the Gerrit web UI '
1920 'or delete it.\n\n', action='delete the unpublished edit')
dsansomee2d6fd92016-09-08 00:10:47 -07001921
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001922 gerrit_util.DeletePendingChangeEdit(
1923 self._GetGerritHost(), self._GerritChangeIdentifier())
1924 gerrit_util.SetCommitMessage(
1925 self._GetGerritHost(), self._GerritChangeIdentifier(),
1926 description, notify='NONE')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001927
Aaron Gable636b13f2017-07-14 10:42:48 -07001928 def AddComment(self, message, publish=None):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001929 gerrit_util.SetReview(
1930 self._GetGerritHost(), self._GerritChangeIdentifier(),
1931 msg=message, ready=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001932
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001933 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01001934 # DETAILED_ACCOUNTS is to get emails in accounts.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001935 # CURRENT_REVISION is included to get the latest patchset so that
1936 # only the robot comments from the latest patchset can be shown.
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001937 messages = self._GetChangeDetail(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001938 options=['MESSAGES', 'DETAILED_ACCOUNTS',
1939 'CURRENT_REVISION']).get('messages', [])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001940 file_comments = gerrit_util.GetChangeComments(
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001941 self._GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001942 robot_file_comments = gerrit_util.GetChangeRobotComments(
1943 self._GetGerritHost(), self._GerritChangeIdentifier())
1944
1945 # Add the robot comments onto the list of comments, but only
1946 # keep those that are from the latest pachset.
1947 latest_patch_set = self.GetMostRecentPatchset()
1948 for path, robot_comments in robot_file_comments.iteritems():
1949 line_comments = file_comments.setdefault(path, [])
1950 line_comments.extend(
1951 [c for c in robot_comments if c['patch_set'] == latest_patch_set])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001952
1953 # Build dictionary of file comments for easy access and sorting later.
1954 # {author+date: {path: {patchset: {line: url+message}}}}
1955 comments = collections.defaultdict(
1956 lambda: collections.defaultdict(lambda: collections.defaultdict(dict)))
1957 for path, line_comments in file_comments.iteritems():
1958 for comment in line_comments:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001959 tag = comment.get('tag', '')
1960 if tag.startswith('autogenerated') and 'robot_id' not in comment:
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001961 continue
1962 key = (comment['author']['email'], comment['updated'])
1963 if comment.get('side', 'REVISION') == 'PARENT':
1964 patchset = 'Base'
1965 else:
1966 patchset = 'PS%d' % comment['patch_set']
1967 line = comment.get('line', 0)
1968 url = ('https://%s/c/%s/%s/%s#%s%s' %
1969 (self._GetGerritHost(), self.GetIssue(), comment['patch_set'], path,
1970 'b' if comment.get('side') == 'PARENT' else '',
1971 str(line) if line else ''))
1972 comments[key][path][patchset][line] = (url, comment['message'])
1973
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001974 summaries = []
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001975 for msg in messages:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001976 summary = self._BuildCommentSummary(msg, comments, readable)
1977 if summary:
1978 summaries.append(summary)
1979 return summaries
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001980
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001981 @staticmethod
1982 def _BuildCommentSummary(msg, comments, readable):
1983 key = (msg['author']['email'], msg['date'])
1984 # Don't bother showing autogenerated messages that don't have associated
1985 # file or line comments. this will filter out most autogenerated
1986 # messages, but will keep robot comments like those from Tricium.
1987 is_autogenerated = msg.get('tag', '').startswith('autogenerated')
1988 if is_autogenerated and not comments.get(key):
1989 return None
1990 message = msg['message']
1991 # Gerrit spits out nanoseconds.
1992 assert len(msg['date'].split('.')[-1]) == 9
1993 date = datetime.datetime.strptime(msg['date'][:-3],
1994 '%Y-%m-%d %H:%M:%S.%f')
1995 if key in comments:
1996 message += '\n'
1997 for path, patchsets in sorted(comments.get(key, {}).items()):
1998 if readable:
1999 message += '\n%s' % path
2000 for patchset, lines in sorted(patchsets.items()):
2001 for line, (url, content) in sorted(lines.items()):
2002 if line:
2003 line_str = 'Line %d' % line
2004 path_str = '%s:%d:' % (path, line)
2005 else:
2006 line_str = 'File comment'
2007 path_str = '%s:0:' % path
2008 if readable:
2009 message += '\n %s, %s: %s' % (patchset, line_str, url)
2010 message += '\n %s\n' % content
2011 else:
2012 message += '\n%s ' % path_str
2013 message += '\n%s\n' % content
2014
2015 return _CommentSummary(
2016 date=date,
2017 message=message,
2018 sender=msg['author']['email'],
2019 autogenerated=is_autogenerated,
2020 # These could be inferred from the text messages and correlated with
2021 # Code-Review label maximum, however this is not reliable.
2022 # Leaving as is until the need arises.
2023 approval=False,
2024 disapproval=False,
2025 )
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01002026
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002027 def CloseIssue(self):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002028 gerrit_util.AbandonChange(
2029 self._GetGerritHost(), self._GerritChangeIdentifier(), msg='')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002030
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002031 def SubmitIssue(self, wait_for_merge=True):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002032 gerrit_util.SubmitChange(
2033 self._GetGerritHost(), self._GerritChangeIdentifier(),
2034 wait_for_merge=wait_for_merge)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002035
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002036 def _GetChangeDetail(self, options=None, no_cache=False):
2037 """Returns details of associated Gerrit change and caching results.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002038
2039 If fresh data is needed, set no_cache=True which will clear cache and
2040 thus new data will be fetched from Gerrit.
2041 """
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002042 options = options or []
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002043 assert self.GetIssue(), 'issue is required to query Gerrit'
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002044
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002045 # Optimization to avoid multiple RPCs:
2046 if (('CURRENT_REVISION' in options or 'ALL_REVISIONS' in options) and
2047 'CURRENT_COMMIT' not in options):
2048 options.append('CURRENT_COMMIT')
2049
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002050 # Normalize issue and options for consistent keys in cache.
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002051 cache_key = str(self.GetIssue())
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002052 options = [o.upper() for o in options]
2053
2054 # Check in cache first unless no_cache is True.
2055 if no_cache:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002056 self._detail_cache.pop(cache_key, None)
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002057 else:
2058 options_set = frozenset(options)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002059 for cached_options_set, data in self._detail_cache.get(cache_key, []):
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002060 # Assumption: data fetched before with extra options is suitable
2061 # for return for a smaller set of options.
2062 # For example, if we cached data for
2063 # options=[CURRENT_REVISION, DETAILED_FOOTERS]
2064 # and request is for options=[CURRENT_REVISION],
2065 # THEN we can return prior cached data.
2066 if options_set.issubset(cached_options_set):
2067 return data
2068
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002069 try:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002070 data = gerrit_util.GetChangeDetail(
2071 self._GetGerritHost(), self._GerritChangeIdentifier(), options)
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002072 except gerrit_util.GerritError as e:
2073 if e.http_status == 404:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002074 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002075 raise
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002076
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002077 self._detail_cache.setdefault(cache_key, []).append(
2078 (frozenset(options), data))
tandriic2405f52016-10-10 08:13:15 -07002079 return data
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002080
Andrii Shyshkalovcc5f17e2018-08-22 23:35:59 +00002081 def _GetChangeCommit(self):
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002082 assert self.GetIssue(), 'issue must be set to query Gerrit'
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002083 try:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002084 data = gerrit_util.GetChangeCommit(
2085 self._GetGerritHost(), self._GerritChangeIdentifier())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002086 except gerrit_util.GerritError as e:
2087 if e.http_status == 404:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002088 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002089 raise
agable32978d92016-11-01 12:55:02 -07002090 return data
2091
Karen Qian40c19422019-03-13 21:28:29 +00002092 def _IsCqConfigured(self):
2093 detail = self._GetChangeDetail(['LABELS'])
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002094 if u'Commit-Queue' not in detail.get('labels', {}):
Karen Qian40c19422019-03-13 21:28:29 +00002095 return False
2096 # TODO(crbug/753213): Remove temporary hack
2097 if ('https://chromium.googlesource.com/chromium/src' ==
Edward Lemur125d60a2019-09-13 18:25:41 +00002098 self.GetRemoteUrl() and
Karen Qian40c19422019-03-13 21:28:29 +00002099 detail['branch'].startswith('refs/branch-heads/')):
2100 return False
2101 return True
2102
Olivier Robin75ee7252018-04-13 10:02:56 +02002103 def CMDLand(self, force, bypass_hooks, verbose, parallel):
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002104 if git_common.is_dirty_git_tree('land'):
2105 return 1
Karen Qian40c19422019-03-13 21:28:29 +00002106
tandriid60367b2016-06-22 05:25:12 -07002107 detail = self._GetChangeDetail(['CURRENT_REVISION', 'LABELS'])
Karen Qian40c19422019-03-13 21:28:29 +00002108 if not force and self._IsCqConfigured():
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00002109 confirm_or_exit('\nIt seems this repository has a CQ, '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002110 'which can test and land changes for you. '
2111 'Are you sure you wish to bypass it?\n',
2112 action='bypass CQ')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002113 differs = True
tandriic4344b52016-08-29 06:04:54 -07002114 last_upload = self._GitGetBranchConfigValue('gerritsquashhash')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002115 # Note: git diff outputs nothing if there is no diff.
2116 if not last_upload or RunGit(['diff', last_upload]).strip():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002117 print('WARNING: Some changes from local branch haven\'t been uploaded.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002118 else:
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002119 if detail['current_revision'] == last_upload:
2120 differs = False
2121 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002122 print('WARNING: Local branch contents differ from latest uploaded '
2123 'patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002124 if differs:
2125 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002126 confirm_or_exit(
2127 'Do you want to submit latest Gerrit patchset and bypass hooks?\n',
2128 action='submit')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002129 print('WARNING: Bypassing hooks and submitting latest uploaded patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002130 elif not bypass_hooks:
2131 hook_results = self.RunHook(
2132 committing=True,
2133 may_prompt=not force,
2134 verbose=verbose,
Olivier Robin75ee7252018-04-13 10:02:56 +02002135 change=self.GetChange(self.GetCommonAncestorWithUpstream(), None),
2136 parallel=parallel)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002137 if not hook_results.should_continue():
2138 return 1
2139
2140 self.SubmitIssue(wait_for_merge=True)
2141 print('Issue %s has been submitted.' % self.GetIssueURL())
agable32978d92016-11-01 12:55:02 -07002142 links = self._GetChangeCommit().get('web_links', [])
2143 for link in links:
Aaron Gable02cdbb42016-12-13 16:24:25 -08002144 if link.get('name') == 'gitiles' and link.get('url'):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002145 print('Landed as: %s' % link.get('url'))
agable32978d92016-11-01 12:55:02 -07002146 break
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002147 return 0
2148
Edward Lemurf38bc172019-09-03 21:02:13 +00002149 def CMDPatchWithParsedIssue(self, parsed_issue_arg, nocommit, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002150 assert parsed_issue_arg.valid
2151
Edward Lemur125d60a2019-09-13 18:25:41 +00002152 self.issue = parsed_issue_arg.issue
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002153
2154 if parsed_issue_arg.hostname:
2155 self._gerrit_host = parsed_issue_arg.hostname
2156 self._gerrit_server = 'https://%s' % self._gerrit_host
2157
tandriic2405f52016-10-10 08:13:15 -07002158 try:
2159 detail = self._GetChangeDetail(['ALL_REVISIONS'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002160 except GerritChangeNotExists as e:
tandriic2405f52016-10-10 08:13:15 -07002161 DieWithError(str(e))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002162
2163 if not parsed_issue_arg.patchset:
2164 # Use current revision by default.
2165 revision_info = detail['revisions'][detail['current_revision']]
2166 patchset = int(revision_info['_number'])
2167 else:
2168 patchset = parsed_issue_arg.patchset
2169 for revision_info in detail['revisions'].itervalues():
2170 if int(revision_info['_number']) == parsed_issue_arg.patchset:
2171 break
2172 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08002173 DieWithError('Couldn\'t find patchset %i in change %i' %
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002174 (parsed_issue_arg.patchset, self.GetIssue()))
2175
Edward Lemur125d60a2019-09-13 18:25:41 +00002176 remote_url = self.GetRemoteUrl()
Aaron Gable697a91b2018-01-19 15:20:15 -08002177 if remote_url.endswith('.git'):
2178 remote_url = remote_url[:-len('.git')]
erikchen0d14d0d2018-08-28 18:57:09 +00002179 remote_url = remote_url.rstrip('/')
2180
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002181 fetch_info = revision_info['fetch']['http']
erikchen0d14d0d2018-08-28 18:57:09 +00002182 fetch_info['url'] = fetch_info['url'].rstrip('/')
Aaron Gable697a91b2018-01-19 15:20:15 -08002183
2184 if remote_url != fetch_info['url']:
2185 DieWithError('Trying to patch a change from %s but this repo appears '
2186 'to be %s.' % (fetch_info['url'], remote_url))
2187
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002188 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
Aaron Gable9387b4f2017-06-08 10:50:03 -07002189
Aaron Gable62619a32017-06-16 08:22:09 -07002190 if force:
2191 RunGit(['reset', '--hard', 'FETCH_HEAD'])
2192 print('Checked out commit for change %i patchset %i locally' %
2193 (parsed_issue_arg.issue, patchset))
Stefan Zager2d5f0392017-10-10 15:17:53 -07002194 elif nocommit:
2195 RunGit(['cherry-pick', '--no-commit', 'FETCH_HEAD'])
2196 print('Patch applied to index.')
Aaron Gable62619a32017-06-16 08:22:09 -07002197 else:
Aaron Gable9387b4f2017-06-08 10:50:03 -07002198 RunGit(['cherry-pick', 'FETCH_HEAD'])
2199 print('Committed patch for change %i patchset %i locally.' %
Aaron Gable62619a32017-06-16 08:22:09 -07002200 (parsed_issue_arg.issue, patchset))
2201 print('Note: this created a local commit which does not have '
2202 'the same hash as the one uploaded for review. This will make '
2203 'uploading changes based on top of this branch difficult.\n'
2204 'If you want to do that, use "git cl patch --force" instead.')
2205
Stefan Zagerd08043c2017-10-12 12:07:02 -07002206 if self.GetBranch():
2207 self.SetIssue(parsed_issue_arg.issue)
2208 self.SetPatchset(patchset)
2209 fetched_hash = RunGit(['rev-parse', 'FETCH_HEAD']).strip()
2210 self._GitSetBranchConfigValue('last-upload-hash', fetched_hash)
2211 self._GitSetBranchConfigValue('gerritsquashhash', fetched_hash)
2212 else:
2213 print('WARNING: You are in detached HEAD state.\n'
2214 'The patch has been applied to your checkout, but you will not be '
2215 'able to upload a new patch set to the gerrit issue.\n'
2216 'Try using the \'-b\' option if you would like to work on a '
2217 'branch and/or upload a new patch set.')
2218
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002219 return 0
2220
2221 @staticmethod
2222 def ParseIssueURL(parsed_url):
2223 if not parsed_url.scheme or not parsed_url.scheme.startswith('http'):
2224 return None
Aaron Gable01b91062017-08-24 17:48:40 -07002225 # Gerrit's new UI is https://domain/c/project/+/<issue_number>[/[patchset]]
2226 # But old GWT UI is https://domain/#/c/project/+/<issue_number>[/[patchset]]
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002227 # Short urls like https://domain/<issue_number> can be used, but don't allow
2228 # specifying the patchset (you'd 404), but we allow that here.
2229 if parsed_url.path == '/':
2230 part = parsed_url.fragment
2231 else:
2232 part = parsed_url.path
Bruce Dawson9c062012019-05-02 19:20:28 +00002233 match = re.match(r'(/c(/.*/\+)?)?/(\d+)(/(\d+)?/?)?$', part)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002234 if match:
2235 return _ParsedIssueNumberArgument(
Aaron Gable01b91062017-08-24 17:48:40 -07002236 issue=int(match.group(3)),
2237 patchset=int(match.group(5)) if match.group(5) else None,
Edward Lemurf38bc172019-09-03 21:02:13 +00002238 hostname=parsed_url.netloc)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002239 return None
2240
tandrii16e0b4e2016-06-07 10:34:28 -07002241 def _GerritCommitMsgHookCheck(self, offer_removal):
2242 hook = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
2243 if not os.path.exists(hook):
2244 return
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002245 # Crude attempt to distinguish Gerrit Codereview hook from a potentially
2246 # custom developer-made one.
tandrii16e0b4e2016-06-07 10:34:28 -07002247 data = gclient_utils.FileRead(hook)
2248 if not('From Gerrit Code Review' in data and 'add_ChangeId()' in data):
2249 return
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002250 print('WARNING: You have Gerrit commit-msg hook installed.\n'
qyearsley12fa6ff2016-08-24 09:18:40 -07002251 'It is not necessary for uploading with git cl in squash mode, '
tandrii16e0b4e2016-06-07 10:34:28 -07002252 'and may interfere with it in subtle ways.\n'
2253 'We recommend you remove the commit-msg hook.')
2254 if offer_removal:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002255 if ask_for_explicit_yes('Do you want to remove it now?'):
tandrii16e0b4e2016-06-07 10:34:28 -07002256 gclient_utils.rm_file_or_tree(hook)
2257 print('Gerrit commit-msg hook removed.')
2258 else:
2259 print('OK, will keep Gerrit commit-msg hook in place.')
2260
Edward Lemur1b52d872019-05-09 21:12:12 +00002261 def _CleanUpOldTraces(self):
2262 """Keep only the last |MAX_TRACES| traces."""
2263 try:
2264 traces = sorted([
2265 os.path.join(TRACES_DIR, f)
2266 for f in os.listdir(TRACES_DIR)
2267 if (os.path.isfile(os.path.join(TRACES_DIR, f))
2268 and not f.startswith('tmp'))
2269 ])
2270 traces_to_delete = traces[:-MAX_TRACES]
2271 for trace in traces_to_delete:
Daniel Chengcf6269b2019-05-18 01:02:12 +00002272 os.remove(trace)
Edward Lemur1b52d872019-05-09 21:12:12 +00002273 except OSError:
2274 print('WARNING: Failed to remove old git traces from\n'
2275 ' %s'
2276 'Consider removing them manually.' % TRACES_DIR)
Edward Lemurdc8e23d2019-05-07 00:45:48 +00002277
Edward Lemur5737f022019-05-17 01:24:00 +00002278 def _WriteGitPushTraces(self, trace_name, traces_dir, git_push_metadata):
Edward Lemur1b52d872019-05-09 21:12:12 +00002279 """Zip and write the git push traces stored in traces_dir."""
2280 gclient_utils.safe_makedirs(TRACES_DIR)
Edward Lemur1b52d872019-05-09 21:12:12 +00002281 traces_zip = trace_name + '-traces'
2282 traces_readme = trace_name + '-README'
Michael Mosse7f0b4c2019-05-08 04:36:24 +00002283 # Create a temporary dir to store git config and gitcookies in. It will be
2284 # compressed and stored next to the traces.
2285 git_info_dir = tempfile.mkdtemp()
Edward Lemur1b52d872019-05-09 21:12:12 +00002286 git_info_zip = trace_name + '-git-info'
2287
Edward Lemur5737f022019-05-17 01:24:00 +00002288 git_push_metadata['now'] = datetime_now().strftime('%c')
Eric Boren67c48202019-05-30 16:52:51 +00002289 if sys.stdin.encoding and sys.stdin.encoding != 'utf-8':
sangwoo.ko7a614332019-05-22 02:46:19 +00002290 git_push_metadata['now'] = git_push_metadata['now'].decode(
2291 sys.stdin.encoding)
2292
Edward Lemur1b52d872019-05-09 21:12:12 +00002293 git_push_metadata['trace_name'] = trace_name
2294 gclient_utils.FileWrite(
2295 traces_readme, TRACES_README_FORMAT % git_push_metadata)
2296
2297 # Keep only the first 6 characters of the git hashes on the packet
2298 # trace. This greatly decreases size after compression.
2299 packet_traces = os.path.join(traces_dir, 'trace-packet')
2300 if os.path.isfile(packet_traces):
2301 contents = gclient_utils.FileRead(packet_traces)
2302 gclient_utils.FileWrite(
2303 packet_traces, GIT_HASH_RE.sub(r'\1', contents))
2304 shutil.make_archive(traces_zip, 'zip', traces_dir)
2305
2306 # Collect and compress the git config and gitcookies.
2307 git_config = RunGit(['config', '-l'])
2308 gclient_utils.FileWrite(
2309 os.path.join(git_info_dir, 'git-config'),
2310 git_config)
2311
2312 cookie_auth = gerrit_util.Authenticator.get()
2313 if isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
2314 gitcookies_path = cookie_auth.get_gitcookies_path()
2315 if os.path.isfile(gitcookies_path):
2316 gitcookies = gclient_utils.FileRead(gitcookies_path)
2317 gclient_utils.FileWrite(
2318 os.path.join(git_info_dir, 'gitcookies'),
2319 GITCOOKIES_REDACT_RE.sub('REDACTED', gitcookies))
2320 shutil.make_archive(git_info_zip, 'zip', git_info_dir)
2321
Edward Lemur1b52d872019-05-09 21:12:12 +00002322 gclient_utils.rmtree(git_info_dir)
2323
2324 def _RunGitPushWithTraces(
2325 self, change_desc, refspec, refspec_opts, git_push_metadata):
2326 """Run git push and collect the traces resulting from the execution."""
2327 # Create a temporary directory to store traces in. Traces will be compressed
2328 # and stored in a 'traces' dir inside depot_tools.
2329 traces_dir = tempfile.mkdtemp()
Edward Lemur5737f022019-05-17 01:24:00 +00002330 trace_name = os.path.join(
2331 TRACES_DIR, datetime_now().strftime('%Y%m%dT%H%M%S.%f'))
Edward Lemur0f58ae42019-04-30 17:24:12 +00002332
2333 env = os.environ.copy()
2334 env['GIT_REDACT_COOKIES'] = 'o,SSO,GSSO_Uberproxy'
2335 env['GIT_TR2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Jonathan Nieder9779b142019-05-29 23:19:29 +00002336 env['GIT_TRACE2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002337 env['GIT_TRACE_CURL'] = os.path.join(traces_dir, 'trace-curl')
2338 env['GIT_TRACE_CURL_NO_DATA'] = '1'
2339 env['GIT_TRACE_PACKET'] = os.path.join(traces_dir, 'trace-packet')
2340
2341 try:
2342 push_returncode = 0
Edward Lemur1b52d872019-05-09 21:12:12 +00002343 remote_url = self.GetRemoteUrl()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002344 before_push = time_time()
2345 push_stdout = gclient_utils.CheckCallAndFilter(
Edward Lemur1b52d872019-05-09 21:12:12 +00002346 ['git', 'push', remote_url, refspec],
Edward Lemur0f58ae42019-04-30 17:24:12 +00002347 env=env,
2348 print_stdout=True,
2349 # Flush after every line: useful for seeing progress when running as
2350 # recipe.
2351 filter_fn=lambda _: sys.stdout.flush())
2352 except subprocess2.CalledProcessError as e:
2353 push_returncode = e.returncode
2354 DieWithError('Failed to create a change. Please examine output above '
2355 'for the reason of the failure.\n'
2356 'Hint: run command below to diagnose common Git/Gerrit '
2357 'credential problems:\n'
Edward Lemur5737f022019-05-17 01:24:00 +00002358 ' git cl creds-check\n'
2359 '\n'
2360 'If git-cl is not working correctly, file a bug under the '
2361 'Infra>SDK component including the files below.\n'
2362 'Review the files before upload, since they might contain '
2363 'sensitive information.\n'
2364 'Set the Restrict-View-Google label so that they are not '
2365 'publicly accessible.\n'
2366 + TRACES_MESSAGE % {'trace_name': trace_name},
Edward Lemur0f58ae42019-04-30 17:24:12 +00002367 change_desc)
2368 finally:
2369 execution_time = time_time() - before_push
2370 metrics.collector.add_repeated('sub_commands', {
2371 'command': 'git push',
2372 'execution_time': execution_time,
2373 'exit_code': push_returncode,
2374 'arguments': metrics_utils.extract_known_subcommand_args(refspec_opts),
2375 })
2376
Edward Lemur1b52d872019-05-09 21:12:12 +00002377 git_push_metadata['execution_time'] = execution_time
2378 git_push_metadata['exit_code'] = push_returncode
Edward Lemur5737f022019-05-17 01:24:00 +00002379 self._WriteGitPushTraces(trace_name, traces_dir, git_push_metadata)
Edward Lemur0f58ae42019-04-30 17:24:12 +00002380
Edward Lemur1b52d872019-05-09 21:12:12 +00002381 self._CleanUpOldTraces()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002382 gclient_utils.rmtree(traces_dir)
2383
2384 return push_stdout
2385
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002386 def CMDUploadChange(self, options, git_diff_args, custom_cl_base, change):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002387 """Upload the current branch to Gerrit."""
Mike Frysingera989d552019-08-14 20:51:23 +00002388 if options.squash is None:
tandriia60502f2016-06-20 02:01:53 -07002389 # Load default for user, repo, squash=true, in this order.
2390 options.squash = settings.GetSquashGerritUploads()
tandrii26f3e4e2016-06-10 08:37:04 -07002391
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002392 remote, remote_branch = self.GetRemoteBranch()
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01002393 branch = GetTargetRef(remote, remote_branch, options.target_branch)
Aaron Gableb56ad332017-01-06 15:24:31 -08002394 # This may be None; default fallback value is determined in logic below.
2395 title = options.title
2396
Dominic Battre7d1c4842017-10-27 09:17:28 +02002397 # Extract bug number from branch name.
2398 bug = options.bug
2399 match = re.match(r'(?:bug|fix)[_-]?(\d+)', self.GetBranch())
2400 if not bug and match:
2401 bug = match.group(1)
2402
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002403 if options.squash:
tandrii16e0b4e2016-06-07 10:34:28 -07002404 self._GerritCommitMsgHookCheck(offer_removal=not options.force)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002405 if self.GetIssue():
2406 # Try to get the message from a previous upload.
2407 message = self.GetDescription()
2408 if not message:
2409 DieWithError(
Aaron Gablea45ee112016-11-22 15:14:38 -08002410 'failed to fetch description from current Gerrit change %d\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002411 '%s' % (self.GetIssue(), self.GetIssueURL()))
Aaron Gableb56ad332017-01-06 15:24:31 -08002412 if not title:
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002413 if options.message:
Aaron Gable7303dcb2017-06-07 14:17:32 -07002414 # When uploading a subsequent patchset, -m|--message is taken
2415 # as the patchset title if --title was not provided.
2416 title = options.message.strip()
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002417 else:
2418 default_title = RunGit(
2419 ['show', '-s', '--format=%s', 'HEAD']).strip()
Aaron Gable7303dcb2017-06-07 14:17:32 -07002420 if options.force:
2421 title = default_title
2422 else:
2423 title = ask_for_data(
2424 'Title for patchset [%s]: ' % default_title) or default_title
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002425 change_id = self._GetChangeDetail()['change_id']
2426 while True:
2427 footer_change_ids = git_footers.get_footer_change_id(message)
2428 if footer_change_ids == [change_id]:
2429 break
2430 if not footer_change_ids:
2431 message = git_footers.add_footer_change_id(message, change_id)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002432 print('WARNING: appended missing Change-Id to change description.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002433 continue
2434 # There is already a valid footer but with different or several ids.
2435 # Doing this automatically is non-trivial as we don't want to lose
2436 # existing other footers, yet we want to append just 1 desired
2437 # Change-Id. Thus, just create a new footer, but let user verify the
2438 # new description.
2439 message = '%s\n\nChange-Id: %s' % (message, change_id)
Anthony Polito8b955342019-09-24 19:01:36 +00002440 change_desc = ChangeDescription(message, bug=bug)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002441 if not options.force:
Anthony Polito8b955342019-09-24 19:01:36 +00002442 print(
2443 'WARNING: change %s has Change-Id footer(s):\n'
2444 ' %s\n'
2445 'but change has Change-Id %s, according to Gerrit.\n'
2446 'Please, check the proposed correction to the description, '
2447 'and edit it if necessary but keep the "Change-Id: %s" footer\n'
2448 % (self.GetIssue(), '\n '.join(footer_change_ids), change_id,
2449 change_id))
2450 confirm_or_exit(action='edit')
2451 change_desc.prompt()
2452
2453 message = change_desc.description
2454 if not message:
2455 DieWithError("Description is empty. Aborting...")
2456
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002457 # Continue the while loop.
2458 # Sanity check of this code - we should end up with proper message
2459 # footer.
2460 assert [change_id] == git_footers.get_footer_change_id(message)
Anthony Polito8b955342019-09-24 19:01:36 +00002461 change_desc = ChangeDescription(message, bug=bug)
Aaron Gableb56ad332017-01-06 15:24:31 -08002462 else: # if not self.GetIssue()
2463 if options.message:
2464 message = options.message
2465 else:
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002466 message = _create_description_from_log(git_diff_args)
Aaron Gableb56ad332017-01-06 15:24:31 -08002467 if options.title:
2468 message = options.title + '\n\n' + message
Anthony Polito8b955342019-09-24 19:01:36 +00002469 change_desc = ChangeDescription(message, bug=bug)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002470 if not options.force:
Anthony Polito8b955342019-09-24 19:01:36 +00002471 change_desc.prompt()
2472
Aaron Gableb56ad332017-01-06 15:24:31 -08002473 # On first upload, patchset title is always this string, while
2474 # --title flag gets converted to first line of message.
2475 title = 'Initial upload'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002476 if not change_desc.description:
2477 DieWithError("Description is empty. Aborting...")
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002478 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002479 if len(change_ids) > 1:
2480 DieWithError('too many Change-Id footers, at most 1 allowed.')
2481 if not change_ids:
2482 # Generate the Change-Id automatically.
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002483 change_desc.set_description(git_footers.add_footer_change_id(
2484 change_desc.description,
2485 GenerateGerritChangeId(change_desc.description)))
2486 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002487 assert len(change_ids) == 1
2488 change_id = change_ids[0]
2489
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002490 if options.reviewers or options.tbrs or options.add_owners_to:
2491 change_desc.update_reviewers(options.reviewers, options.tbrs,
2492 options.add_owners_to, change)
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002493 if options.preserve_tryjobs:
2494 change_desc.set_preserve_tryjobs()
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002495
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002496 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002497 parent = self._ComputeParent(remote, upstream_branch, custom_cl_base,
2498 options.force, change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002499 tree = RunGit(['rev-parse', 'HEAD:']).strip()
Aaron Gable9a03ae02017-11-03 11:31:07 -07002500 with tempfile.NamedTemporaryFile(delete=False) as desc_tempfile:
2501 desc_tempfile.write(change_desc.description)
2502 desc_tempfile.close()
2503 ref_to_push = RunGit(['commit-tree', tree, '-p', parent,
2504 '-F', desc_tempfile.name]).strip()
2505 os.remove(desc_tempfile.name)
Anthony Polito8b955342019-09-24 19:01:36 +00002506 else: # if not options.squash
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002507 change_desc = ChangeDescription(
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002508 options.message or _create_description_from_log(git_diff_args))
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002509 if not change_desc.description:
2510 DieWithError("Description is empty. Aborting...")
2511
2512 if not git_footers.get_footer_change_id(change_desc.description):
2513 DownloadGerritHook(False)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002514 change_desc.set_description(
2515 self._AddChangeIdToCommitMessage(options, git_diff_args))
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002516 if options.reviewers or options.tbrs or options.add_owners_to:
2517 change_desc.update_reviewers(options.reviewers, options.tbrs,
2518 options.add_owners_to, change)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002519 ref_to_push = 'HEAD'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002520 # For no-squash mode, we assume the remote called "origin" is the one we
2521 # want. It is not worthwhile to support different workflows for
2522 # no-squash mode.
2523 parent = 'origin/%s' % branch
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002524 change_id = git_footers.get_footer_change_id(change_desc.description)[0]
2525
2526 assert change_desc
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00002527 SaveDescriptionBackup(change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002528 commits = RunGitSilent(['rev-list', '%s..%s' % (parent,
2529 ref_to_push)]).splitlines()
2530 if len(commits) > 1:
2531 print('WARNING: This will upload %d commits. Run the following command '
2532 'to see which commits will be uploaded: ' % len(commits))
2533 print('git log %s..%s' % (parent, ref_to_push))
2534 print('You can also use `git squash-branch` to squash these into a '
2535 'single commit.')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002536 confirm_or_exit(action='upload')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002537
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002538 if options.reviewers or options.tbrs or options.add_owners_to:
2539 change_desc.update_reviewers(options.reviewers, options.tbrs,
2540 options.add_owners_to, change)
2541
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002542 reviewers = sorted(change_desc.get_reviewers())
2543 # Add cc's from the CC_LIST and --cc flag (if any).
2544 if not options.private and not options.no_autocc:
2545 cc = self.GetCCList().split(',')
2546 else:
2547 cc = []
2548 if options.cc:
2549 cc.extend(options.cc)
2550 cc = filter(None, [email.strip() for email in cc])
2551 if change_desc.get_cced():
2552 cc.extend(change_desc.get_cced())
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00002553 if self._GetGerritHost() == 'chromium-review.googlesource.com':
2554 valid_accounts = set(reviewers + cc)
2555 # TODO(crbug/877717): relax this for all hosts.
2556 else:
2557 valid_accounts = gerrit_util.ValidAccounts(
2558 self._GetGerritHost(), reviewers + cc)
Andrii Shyshkalovf170af42018-10-30 07:00:44 +00002559 logging.info('accounts %s are recognized, %s invalid',
2560 sorted(valid_accounts),
2561 set(reviewers + cc).difference(set(valid_accounts)))
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002562
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002563 # Extra options that can be specified at push time. Doc:
2564 # https://gerrit-review.googlesource.com/Documentation/user-upload.html
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002565 refspec_opts = []
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002566
Aaron Gable844cf292017-06-28 11:32:59 -07002567 # By default, new changes are started in WIP mode, and subsequent patchsets
2568 # don't send email. At any time, passing --send-mail will mark the change
2569 # ready and send email for that particular patch.
Aaron Gableafd52772017-06-27 16:40:10 -07002570 if options.send_mail:
2571 refspec_opts.append('ready')
Aaron Gable844cf292017-06-28 11:32:59 -07002572 refspec_opts.append('notify=ALL')
Jamie Madill276da0b2018-04-27 14:41:20 -04002573 elif not self.GetIssue() and options.squash:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002574 refspec_opts.append('wip')
Aaron Gableafd52772017-06-27 16:40:10 -07002575 else:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002576 refspec_opts.append('notify=NONE')
Aaron Gable70f4e242017-06-26 10:45:59 -07002577
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002578 # TODO(tandrii): options.message should be posted as a comment
Aaron Gablee5adf612017-07-14 10:43:58 -07002579 # if --send-mail is set on non-initial upload as Rietveld used to do it.
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002580
Aaron Gable9b713dd2016-12-14 16:04:21 -08002581 if title:
Nick Carter8692b182017-11-06 16:30:38 -08002582 # Punctuation and whitespace in |title| must be percent-encoded.
2583 refspec_opts.append('m=' + gerrit_util.PercentEncodeForGitRef(title))
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002584
agablec6787972016-09-09 16:13:34 -07002585 if options.private:
Aaron Gableb02daf02017-05-23 11:53:46 -07002586 refspec_opts.append('private')
agablec6787972016-09-09 16:13:34 -07002587
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002588 for r in sorted(reviewers):
2589 if r in valid_accounts:
2590 refspec_opts.append('r=%s' % r)
2591 reviewers.remove(r)
2592 else:
2593 # TODO(tandrii): this should probably be a hard failure.
2594 print('WARNING: reviewer %s doesn\'t have a Gerrit account, skipping'
2595 % r)
2596 for c in sorted(cc):
2597 # refspec option will be rejected if cc doesn't correspond to an
2598 # account, even though REST call to add such arbitrary cc may succeed.
2599 if c in valid_accounts:
2600 refspec_opts.append('cc=%s' % c)
2601 cc.remove(c)
2602
rmistry9eadede2016-09-19 11:22:43 -07002603 if options.topic:
2604 # Documentation on Gerrit topics is here:
2605 # https://gerrit-review.googlesource.com/Documentation/user-upload.html#topic
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002606 refspec_opts.append('topic=%s' % options.topic)
rmistry9eadede2016-09-19 11:22:43 -07002607
Edward Lemur687ca902018-12-05 02:30:30 +00002608 if options.enable_auto_submit:
2609 refspec_opts.append('l=Auto-Submit+1')
2610 if options.use_commit_queue:
2611 refspec_opts.append('l=Commit-Queue+2')
2612 elif options.cq_dry_run:
2613 refspec_opts.append('l=Commit-Queue+1')
2614
2615 if change_desc.get_reviewers(tbr_only=True):
2616 score = gerrit_util.GetCodeReviewTbrScore(
2617 self._GetGerritHost(),
2618 self._GetGerritProject())
2619 refspec_opts.append('l=Code-Review+%s' % score)
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00002620
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002621 # Gerrit sorts hashtags, so order is not important.
Nodir Turakulov23b82142017-11-16 11:04:25 -08002622 hashtags = {change_desc.sanitize_hash_tag(t) for t in options.hashtags}
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002623 if not self.GetIssue():
Nodir Turakulov23b82142017-11-16 11:04:25 -08002624 hashtags.update(change_desc.get_hash_tags())
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002625 refspec_opts += ['hashtag=%s' % t for t in sorted(hashtags)]
2626
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002627 refspec_suffix = ''
2628 if refspec_opts:
2629 refspec_suffix = '%' + ','.join(refspec_opts)
2630 assert ' ' not in refspec_suffix, (
2631 'spaces not allowed in refspec: "%s"' % refspec_suffix)
2632 refspec = '%s:refs/for/%s%s' % (ref_to_push, branch, refspec_suffix)
2633
Edward Lemur1b52d872019-05-09 21:12:12 +00002634 git_push_metadata = {
2635 'gerrit_host': self._GetGerritHost(),
2636 'title': title or '<untitled>',
2637 'change_id': change_id,
2638 'description': change_desc.description,
2639 }
2640 push_stdout = self._RunGitPushWithTraces(
2641 change_desc, refspec, refspec_opts, git_push_metadata)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002642
2643 if options.squash:
Aaron Gable289b4312017-09-13 14:06:16 -07002644 regex = re.compile(r'remote:\s+https?://[\w\-\.\+\/#]*/(\d+)\s.*')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002645 change_numbers = [m.group(1)
2646 for m in map(regex.match, push_stdout.splitlines())
2647 if m]
2648 if len(change_numbers) != 1:
2649 DieWithError(
2650 ('Created|Updated %d issues on Gerrit, but only 1 expected.\n'
Christopher Lamf732cd52017-01-24 12:40:11 +11002651 'Change-Id: %s') % (len(change_numbers), change_id), change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002652 self.SetIssue(change_numbers[0])
tandrii5d48c322016-08-18 16:19:37 -07002653 self._GitSetBranchConfigValue('gerritsquashhash', ref_to_push)
tandrii88189772016-09-29 04:29:57 -07002654
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002655 if self.GetIssue() and (reviewers or cc):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002656 # GetIssue() is not set in case of non-squash uploads according to tests.
2657 # TODO(agable): non-squash uploads in git cl should be removed.
2658 gerrit_util.AddReviewers(
2659 self._GetGerritHost(),
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00002660 self._GerritChangeIdentifier(),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002661 reviewers, cc,
2662 notify=bool(options.send_mail))
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002663
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002664 return 0
2665
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002666 def _ComputeParent(self, remote, upstream_branch, custom_cl_base, force,
2667 change_desc):
2668 """Computes parent of the generated commit to be uploaded to Gerrit.
2669
2670 Returns revision or a ref name.
2671 """
2672 if custom_cl_base:
2673 # Try to avoid creating additional unintended CLs when uploading, unless
2674 # user wants to take this risk.
2675 local_ref_of_target_remote = self.GetRemoteBranch()[1]
2676 code, _ = RunGitWithCode(['merge-base', '--is-ancestor', custom_cl_base,
2677 local_ref_of_target_remote])
2678 if code == 1:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002679 print('\nWARNING: Manually specified base of this CL `%s` '
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002680 'doesn\'t seem to belong to target remote branch `%s`.\n\n'
2681 'If you proceed with upload, more than 1 CL may be created by '
2682 'Gerrit as a result, in turn confusing or crashing git cl.\n\n'
2683 'If you are certain that specified base `%s` has already been '
2684 'uploaded to Gerrit as another CL, you may proceed.\n' %
2685 (custom_cl_base, local_ref_of_target_remote, custom_cl_base))
2686 if not force:
2687 confirm_or_exit(
2688 'Do you take responsibility for cleaning up potential mess '
2689 'resulting from proceeding with upload?',
2690 action='upload')
2691 return custom_cl_base
2692
Aaron Gablef97e33d2017-03-30 15:44:27 -07002693 if remote != '.':
2694 return self.GetCommonAncestorWithUpstream()
2695
2696 # If our upstream branch is local, we base our squashed commit on its
2697 # squashed version.
2698 upstream_branch_name = scm.GIT.ShortBranchName(upstream_branch)
2699
Aaron Gablef97e33d2017-03-30 15:44:27 -07002700 if upstream_branch_name == 'master':
Aaron Gable0bbd1c22017-05-08 14:37:08 -07002701 return self.GetCommonAncestorWithUpstream()
Aaron Gablef97e33d2017-03-30 15:44:27 -07002702
2703 # Check the squashed hash of the parent.
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002704 # TODO(tandrii): consider checking parent change in Gerrit and using its
2705 # hash if tree hash of latest parent revision (patchset) in Gerrit matches
2706 # the tree hash of the parent branch. The upside is less likely bogus
2707 # requests to reupload parent change just because it's uploadhash is
2708 # missing, yet the downside likely exists, too (albeit unknown to me yet).
Aaron Gablef97e33d2017-03-30 15:44:27 -07002709 parent = RunGit(['config',
2710 'branch.%s.gerritsquashhash' % upstream_branch_name],
2711 error_ok=True).strip()
2712 # Verify that the upstream branch has been uploaded too, otherwise
2713 # Gerrit will create additional CLs when uploading.
2714 if not parent or (RunGitSilent(['rev-parse', upstream_branch + ':']) !=
2715 RunGitSilent(['rev-parse', parent + ':'])):
2716 DieWithError(
2717 '\nUpload upstream branch %s first.\n'
2718 'It is likely that this branch has been rebased since its last '
2719 'upload, so you just need to upload it again.\n'
2720 '(If you uploaded it with --no-squash, then branch dependencies '
2721 'are not supported, and you should reupload with --squash.)'
2722 % upstream_branch_name,
2723 change_desc)
2724 return parent
2725
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002726 def _AddChangeIdToCommitMessage(self, options, args):
2727 """Re-commits using the current message, assumes the commit hook is in
2728 place.
2729 """
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002730 log_desc = options.message or _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002731 git_command = ['commit', '--amend', '-m', log_desc]
2732 RunGit(git_command)
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002733 new_log_desc = _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002734 if git_footers.get_footer_change_id(new_log_desc):
vapiera7fbd5a2016-06-16 09:17:49 -07002735 print('git-cl: Added Change-Id to commit message.')
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002736 return new_log_desc
2737 else:
tandrii@chromium.orgb067ec52016-05-31 15:24:44 +00002738 DieWithError('ERROR: Gerrit commit-msg hook not installed.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002739
tandriie113dfd2016-10-11 10:20:12 -07002740 def CannotTriggerTryJobReason(self):
tandrii8c5a3532016-11-04 07:52:02 -07002741 try:
2742 data = self._GetChangeDetail()
Aaron Gablea45ee112016-11-22 15:14:38 -08002743 except GerritChangeNotExists:
2744 return 'Gerrit doesn\'t know about your change %s' % self.GetIssue()
tandrii8c5a3532016-11-04 07:52:02 -07002745
2746 if data['status'] in ('ABANDONED', 'MERGED'):
2747 return 'CL %s is closed' % self.GetIssue()
2748
Edward Lemurf0faf482019-09-25 20:40:17 +00002749 # TODO(1004447): Remove on Oct 9th, 2019.
2750 def GetLegacyProperties(self, patchset=None):
2751 host = self.GetCodereviewServer()
2752 issue = self.GetIssue()
2753 patchset = int(patchset or self.GetPatchset())
2754 data = self._GetChangeDetail(['ALL_REVISIONS'])
2755
2756 assert host and issue and patchset, 'CL must be uploaded first'
2757
2758 revision_data = None # Pylint wants it to be defined.
2759 for revision_data in data['revisions'].itervalues():
2760 if int(revision_data['_number']) == patchset:
2761 break
2762 else:
2763 raise Exception('Patchset %d is not known in Gerrit change %d' %
2764 (patchset, issue))
2765
2766 return {
2767 'patch_issue': issue,
2768 'patch_set': patchset,
2769 'patch_project': data['project'],
2770 'patch_storage': 'gerrit',
2771 'patch_ref': revision_data['fetch']['http']['ref'],
2772 'patch_repository_url': revision_data['fetch']['http']['url'],
2773 'patch_gerrit_url': host,
2774 }
2775
2776
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002777 def GetGerritChange(self, patchset=None):
2778 """Returns a buildbucket.v2.GerritChange message for the current issue."""
2779 host = urlparse.urlparse(self.GetCodereviewServer()).hostname
2780 issue = self.GetIssue()
Edward Lemur2c210a42019-09-16 23:58:35 +00002781 patchset = int(patchset or self.GetPatchset())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002782 data = self._GetChangeDetail(['ALL_REVISIONS'])
2783
2784 assert host and issue and patchset, 'CL must be uploaded first'
2785
2786 has_patchset = any(
2787 int(revision_data['_number']) == patchset
2788 for revision_data in data['revisions'].itervalues())
2789 if not has_patchset:
Aaron Gablea45ee112016-11-22 15:14:38 -08002790 raise Exception('Patchset %d is not known in Gerrit change %d' %
tandrii8c5a3532016-11-04 07:52:02 -07002791 (patchset, self.GetIssue()))
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002792
tandrii8c5a3532016-11-04 07:52:02 -07002793 return {
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002794 'host': host,
2795 'change': issue,
2796 'project': data['project'],
2797 'patchset': patchset,
tandrii8c5a3532016-11-04 07:52:02 -07002798 }
tandriie113dfd2016-10-11 10:20:12 -07002799
tandriide281ae2016-10-12 06:02:30 -07002800 def GetIssueOwner(self):
tandrii8c5a3532016-11-04 07:52:02 -07002801 return self._GetChangeDetail(['DETAILED_ACCOUNTS'])['owner']['email']
tandriide281ae2016-10-12 06:02:30 -07002802
Edward Lemur707d70b2018-02-07 00:50:14 +01002803 def GetReviewers(self):
2804 details = self._GetChangeDetail(['DETAILED_ACCOUNTS'])
Mohamed Heikal171c0742018-11-09 20:38:51 +00002805 return [r['email'] for r in details['reviewers'].get('REVIEWER', [])]
Edward Lemur707d70b2018-02-07 00:50:14 +01002806
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002807
2808_CODEREVIEW_IMPLEMENTATIONS = {
Edward Lemur125d60a2019-09-13 18:25:41 +00002809 'gerrit': Changelist,
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002810}
2811
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002812
iannuccie53c9352016-08-17 14:40:40 -07002813def _add_codereview_issue_select_options(parser, extra=""):
2814 _add_codereview_select_options(parser)
2815
2816 text = ('Operate on this issue number instead of the current branch\'s '
2817 'implicit issue.')
2818 if extra:
2819 text += ' '+extra
2820 parser.add_option('-i', '--issue', type=int, help=text)
2821
2822
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002823def _add_codereview_select_options(parser):
Edward Lemurf38bc172019-09-03 21:02:13 +00002824 """Appends --gerrit option to force specific codereview."""
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002825 parser.codereview_group = optparse.OptionGroup(
Edward Lemurf38bc172019-09-03 21:02:13 +00002826 parser, 'DEPRECATED! Codereview override options')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002827 parser.add_option_group(parser.codereview_group)
2828 parser.codereview_group.add_option(
2829 '--gerrit', action='store_true',
Edward Lemurf38bc172019-09-03 21:02:13 +00002830 help='Deprecated. Noop. Do not use.')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002831
2832
2833def _process_codereview_select_options(parser, options):
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002834 options.forced_codereview = None
2835 if options.gerrit:
2836 options.forced_codereview = 'gerrit'
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002837
2838
tandriif9aefb72016-07-01 09:06:51 -07002839def _get_bug_line_values(default_project, bugs):
2840 """Given default_project and comma separated list of bugs, yields bug line
2841 values.
2842
2843 Each bug can be either:
2844 * a number, which is combined with default_project
2845 * string, which is left as is.
2846
2847 This function may produce more than one line, because bugdroid expects one
2848 project per line.
2849
2850 >>> list(_get_bug_line_values('v8', '123,chromium:789'))
2851 ['v8:123', 'chromium:789']
2852 """
2853 default_bugs = []
2854 others = []
2855 for bug in bugs.split(','):
2856 bug = bug.strip()
2857 if bug:
2858 try:
2859 default_bugs.append(int(bug))
2860 except ValueError:
2861 others.append(bug)
2862
2863 if default_bugs:
2864 default_bugs = ','.join(map(str, default_bugs))
2865 if default_project:
2866 yield '%s:%s' % (default_project, default_bugs)
2867 else:
2868 yield default_bugs
2869 for other in sorted(others):
2870 # Don't bother finding common prefixes, CLs with >2 bugs are very very rare.
2871 yield other
2872
2873
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002874class ChangeDescription(object):
2875 """Contains a parsed form of the change description."""
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00002876 R_LINE = r'^[ \t]*(TBR|R)[ \t]*=[ \t]*(.*?)[ \t]*$'
bradnelsond975b302016-10-23 12:20:23 -07002877 CC_LINE = r'^[ \t]*(CC)[ \t]*=[ \t]*(.*?)[ \t]*$'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002878 BUG_LINE = r'^[ \t]*(?:(BUG)[ \t]*=|Bug:)[ \t]*(.*?)[ \t]*$'
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002879 CHERRY_PICK_LINE = r'^\(cherry picked from commit [a-fA-F0-9]{40}\)$'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002880 STRIP_HASH_TAG_PREFIX = r'^(\s*(revert|reland)( "|:)?\s*)*'
2881 BRACKET_HASH_TAG = r'\s*\[([^\[\]]+)\]'
2882 COLON_SEPARATED_HASH_TAG = r'^([a-zA-Z0-9_\- ]+):'
2883 BAD_HASH_TAG_CHUNK = r'[^a-zA-Z0-9]+'
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002884
Anthony Polito8b955342019-09-24 19:01:36 +00002885 def __init__(self, description, bug=None):
agable@chromium.org42c20792013-09-12 17:34:49 +00002886 self._description_lines = (description or '').strip().splitlines()
Anthony Polito8b955342019-09-24 19:01:36 +00002887 if bug:
2888 regexp = re.compile(self.BUG_LINE)
2889 prefix = settings.GetBugPrefix()
2890 if not any((regexp.match(line) for line in self._description_lines)):
2891 values = list(_get_bug_line_values(prefix, bug))
2892 self.append_footer('Bug: %s' % ', '.join(values))
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002893
agable@chromium.org42c20792013-09-12 17:34:49 +00002894 @property # www.logilab.org/ticket/89786
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08002895 def description(self): # pylint: disable=method-hidden
agable@chromium.org42c20792013-09-12 17:34:49 +00002896 return '\n'.join(self._description_lines)
2897
2898 def set_description(self, desc):
2899 if isinstance(desc, basestring):
2900 lines = desc.splitlines()
2901 else:
2902 lines = [line.rstrip() for line in desc]
2903 while lines and not lines[0]:
2904 lines.pop(0)
2905 while lines and not lines[-1]:
2906 lines.pop(-1)
2907 self._description_lines = lines
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002908
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002909 def update_reviewers(self, reviewers, tbrs, add_owners_to=None, change=None):
2910 """Rewrites the R=/TBR= line(s) as a single line each.
2911
2912 Args:
2913 reviewers (list(str)) - list of additional emails to use for reviewers.
2914 tbrs (list(str)) - list of additional emails to use for TBRs.
2915 add_owners_to (None|'R'|'TBR') - Pass to do an OWNERS lookup for files in
2916 the change that are missing OWNER coverage. If this is not None, you
2917 must also pass a value for `change`.
2918 change (Change) - The Change that should be used for OWNERS lookups.
2919 """
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002920 assert isinstance(reviewers, list), reviewers
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002921 assert isinstance(tbrs, list), tbrs
2922
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002923 assert add_owners_to in (None, 'TBR', 'R'), add_owners_to
Robert Iannuccia28592e2017-04-18 13:14:49 -07002924 assert not add_owners_to or change, add_owners_to
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002925
2926 if not reviewers and not tbrs and not add_owners_to:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002927 return
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002928
2929 reviewers = set(reviewers)
2930 tbrs = set(tbrs)
2931 LOOKUP = {
2932 'TBR': tbrs,
2933 'R': reviewers,
2934 }
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002935
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002936 # Get the set of R= and TBR= lines and remove them from the description.
agable@chromium.org42c20792013-09-12 17:34:49 +00002937 regexp = re.compile(self.R_LINE)
2938 matches = [regexp.match(line) for line in self._description_lines]
2939 new_desc = [l for i, l in enumerate(self._description_lines)
2940 if not matches[i]]
2941 self.set_description(new_desc)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002942
agable@chromium.org42c20792013-09-12 17:34:49 +00002943 # Construct new unified R= and TBR= lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002944
2945 # First, update tbrs/reviewers with names from the R=/TBR= lines (if any).
agable@chromium.org42c20792013-09-12 17:34:49 +00002946 for match in matches:
2947 if not match:
2948 continue
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002949 LOOKUP[match.group(1)].update(cleanup_list([match.group(2).strip()]))
2950
2951 # Next, maybe fill in OWNERS coverage gaps to either tbrs/reviewers.
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002952 if add_owners_to:
piman@chromium.org336f9122014-09-04 02:16:55 +00002953 owners_db = owners.Database(change.RepositoryRoot(),
Jochen Eisinger72606f82017-04-04 10:44:18 +02002954 fopen=file, os_path=os.path)
piman@chromium.org336f9122014-09-04 02:16:55 +00002955 missing_files = owners_db.files_not_covered_by(change.LocalPaths(),
Robert Iannucci100aa212017-04-18 17:28:26 -07002956 (tbrs | reviewers))
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002957 LOOKUP[add_owners_to].update(
2958 owners_db.reviewers_for(missing_files, change.author_email))
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002959
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002960 # If any folks ended up in both groups, remove them from tbrs.
2961 tbrs -= reviewers
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002962
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002963 new_r_line = 'R=' + ', '.join(sorted(reviewers)) if reviewers else None
2964 new_tbr_line = 'TBR=' + ', '.join(sorted(tbrs)) if tbrs else None
agable@chromium.org42c20792013-09-12 17:34:49 +00002965
2966 # Put the new lines in the description where the old first R= line was.
2967 line_loc = next((i for i, match in enumerate(matches) if match), -1)
2968 if 0 <= line_loc < len(self._description_lines):
2969 if new_tbr_line:
2970 self._description_lines.insert(line_loc, new_tbr_line)
2971 if new_r_line:
2972 self._description_lines.insert(line_loc, new_r_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002973 else:
agable@chromium.org42c20792013-09-12 17:34:49 +00002974 if new_r_line:
2975 self.append_footer(new_r_line)
2976 if new_tbr_line:
2977 self.append_footer(new_tbr_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002978
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002979 def set_preserve_tryjobs(self):
2980 """Ensures description footer contains 'Cq-Do-Not-Cancel-Tryjobs: true'."""
2981 footers = git_footers.parse_footers(self.description)
2982 for v in footers.get('Cq-Do-Not-Cancel-Tryjobs', []):
2983 if v.lower() == 'true':
2984 return
2985 self.append_footer('Cq-Do-Not-Cancel-Tryjobs: true')
2986
Anthony Polito8b955342019-09-24 19:01:36 +00002987 def prompt(self):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002988 """Asks the user to update the description."""
agable@chromium.org42c20792013-09-12 17:34:49 +00002989 self.set_description([
2990 '# Enter a description of the change.',
2991 '# This will be displayed on the codereview site.',
2992 '# The first line will also be used as the subject of the review.',
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +00002993 '#--------------------This line is 72 characters long'
agable@chromium.org42c20792013-09-12 17:34:49 +00002994 '--------------------',
2995 ] + self._description_lines)
agable@chromium.org42c20792013-09-12 17:34:49 +00002996 regexp = re.compile(self.BUG_LINE)
Jonas Termansend0f79112019-03-22 15:28:26 +00002997 prefix = settings.GetBugPrefix()
agable@chromium.org42c20792013-09-12 17:34:49 +00002998 if not any((regexp.match(line) for line in self._description_lines)):
Anthony Polito8b955342019-09-24 19:01:36 +00002999 self.append_footer('Bug: %s' % prefix)
tandriif9aefb72016-07-01 09:06:51 -07003000
agable@chromium.org42c20792013-09-12 17:34:49 +00003001 content = gclient_utils.RunEditor(self.description, True,
Anthony Polito8b955342019-09-24 19:01:36 +00003002 git_editor=settings.GetGitEditor())
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00003003 if not content:
3004 DieWithError('Running editor failed')
agable@chromium.org42c20792013-09-12 17:34:49 +00003005 lines = content.splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003006
Bruce Dawson2377b012018-01-11 16:46:49 -08003007 # Strip off comments and default inserted "Bug:" line.
3008 clean_lines = [line.rstrip() for line in lines if not
Jonas Termansend0f79112019-03-22 15:28:26 +00003009 (line.startswith('#') or
3010 line.rstrip() == "Bug:" or
3011 line.rstrip() == "Bug: " + prefix)]
agable@chromium.org42c20792013-09-12 17:34:49 +00003012 if not clean_lines:
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00003013 DieWithError('No CL description, aborting')
agable@chromium.org42c20792013-09-12 17:34:49 +00003014 self.set_description(clean_lines)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003015
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003016 def append_footer(self, line):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00003017 """Adds a footer line to the description.
3018
3019 Differentiates legacy "KEY=xxx" footers (used to be called tags) and
3020 Gerrit's footers in the form of "Footer-Key: footer any value" and ensures
3021 that Gerrit footers are always at the end.
3022 """
3023 parsed_footer_line = git_footers.parse_footer(line)
3024 if parsed_footer_line:
3025 # Line is a gerrit footer in the form: Footer-Key: any value.
3026 # Thus, must be appended observing Gerrit footer rules.
3027 self.set_description(
3028 git_footers.add_footer(self.description,
3029 key=parsed_footer_line[0],
3030 value=parsed_footer_line[1]))
3031 return
3032
3033 if not self._description_lines:
3034 self._description_lines.append(line)
3035 return
3036
3037 top_lines, gerrit_footers, _ = git_footers.split_footers(self.description)
3038 if gerrit_footers:
3039 # git_footers.split_footers ensures that there is an empty line before
3040 # actual (gerrit) footers, if any. We have to keep it that way.
3041 assert top_lines and top_lines[-1] == ''
3042 top_lines, separator = top_lines[:-1], top_lines[-1:]
3043 else:
3044 separator = [] # No need for separator if there are no gerrit_footers.
3045
3046 prev_line = top_lines[-1] if top_lines else ''
3047 if (not presubmit_support.Change.TAG_LINE_RE.match(prev_line) or
3048 not presubmit_support.Change.TAG_LINE_RE.match(line)):
3049 top_lines.append('')
3050 top_lines.append(line)
3051 self._description_lines = top_lines + separator + gerrit_footers
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003052
tandrii99a72f22016-08-17 14:33:24 -07003053 def get_reviewers(self, tbr_only=False):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003054 """Retrieves the list of reviewers."""
agable@chromium.org42c20792013-09-12 17:34:49 +00003055 matches = [re.match(self.R_LINE, line) for line in self._description_lines]
tandrii99a72f22016-08-17 14:33:24 -07003056 reviewers = [match.group(2).strip()
3057 for match in matches
3058 if match and (not tbr_only or match.group(1).upper() == 'TBR')]
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003059 return cleanup_list(reviewers)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003060
bradnelsond975b302016-10-23 12:20:23 -07003061 def get_cced(self):
3062 """Retrieves the list of reviewers."""
3063 matches = [re.match(self.CC_LINE, line) for line in self._description_lines]
3064 cced = [match.group(2).strip() for match in matches if match]
3065 return cleanup_list(cced)
3066
Nodir Turakulov23b82142017-11-16 11:04:25 -08003067 def get_hash_tags(self):
3068 """Extracts and sanitizes a list of Gerrit hashtags."""
3069 subject = (self._description_lines or ('',))[0]
3070 subject = re.sub(
3071 self.STRIP_HASH_TAG_PREFIX, '', subject, flags=re.IGNORECASE)
3072
3073 tags = []
3074 start = 0
3075 bracket_exp = re.compile(self.BRACKET_HASH_TAG)
3076 while True:
3077 m = bracket_exp.match(subject, start)
3078 if not m:
3079 break
3080 tags.append(self.sanitize_hash_tag(m.group(1)))
3081 start = m.end()
3082
3083 if not tags:
3084 # Try "Tag: " prefix.
3085 m = re.match(self.COLON_SEPARATED_HASH_TAG, subject)
3086 if m:
3087 tags.append(self.sanitize_hash_tag(m.group(1)))
3088 return tags
3089
3090 @classmethod
3091 def sanitize_hash_tag(cls, tag):
3092 """Returns a sanitized Gerrit hash tag.
3093
3094 A sanitized hashtag can be used as a git push refspec parameter value.
3095 """
3096 return re.sub(cls.BAD_HASH_TAG_CHUNK, '-', tag).strip('-').lower()
3097
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003098 def update_with_git_number_footers(self, parent_hash, parent_msg, dest_ref):
3099 """Updates this commit description given the parent.
3100
3101 This is essentially what Gnumbd used to do.
3102 Consult https://goo.gl/WMmpDe for more details.
3103 """
3104 assert parent_msg # No, orphan branch creation isn't supported.
3105 assert parent_hash
3106 assert dest_ref
3107 parent_footer_map = git_footers.parse_footers(parent_msg)
3108 # This will also happily parse svn-position, which GnumbD is no longer
3109 # supporting. While we'd generate correct footers, the verifier plugin
3110 # installed in Gerrit will block such commit (ie git push below will fail).
3111 parent_position = git_footers.get_position(parent_footer_map)
3112
3113 # Cherry-picks may have last line obscuring their prior footers,
3114 # from git_footers perspective. This is also what Gnumbd did.
3115 cp_line = None
3116 if (self._description_lines and
3117 re.match(self.CHERRY_PICK_LINE, self._description_lines[-1])):
3118 cp_line = self._description_lines.pop()
3119
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003120 top_lines, footer_lines, _ = git_footers.split_footers(self.description)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003121
3122 # Original-ify all Cr- footers, to avoid re-lands, cherry-picks, or just
3123 # user interference with actual footers we'd insert below.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003124 for i, line in enumerate(footer_lines):
3125 k, v = git_footers.parse_footer(line) or (None, None)
3126 if k and k.startswith('Cr-'):
3127 footer_lines[i] = '%s: %s' % ('Cr-Original-' + k[len('Cr-'):], v)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003128
3129 # Add Position and Lineage footers based on the parent.
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +01003130 lineage = list(reversed(parent_footer_map.get('Cr-Branched-From', [])))
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003131 if parent_position[0] == dest_ref:
3132 # Same branch as parent.
3133 number = int(parent_position[1]) + 1
3134 else:
3135 number = 1 # New branch, and extra lineage.
3136 lineage.insert(0, '%s-%s@{#%d}' % (parent_hash, parent_position[0],
3137 int(parent_position[1])))
3138
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003139 footer_lines.append('Cr-Commit-Position: %s@{#%d}' % (dest_ref, number))
3140 footer_lines.extend('Cr-Branched-From: %s' % v for v in lineage)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003141
3142 self._description_lines = top_lines
3143 if cp_line:
3144 self._description_lines.append(cp_line)
3145 if self._description_lines[-1] != '':
3146 self._description_lines.append('') # Ensure footer separator.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003147 self._description_lines.extend(footer_lines)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003148
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003149
Aaron Gablea1bab272017-04-11 16:38:18 -07003150def get_approving_reviewers(props, disapproval=False):
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003151 """Retrieves the reviewers that approved a CL from the issue properties with
3152 messages.
3153
3154 Note that the list may contain reviewers that are not committer, thus are not
3155 considered by the CQ.
Aaron Gablea1bab272017-04-11 16:38:18 -07003156
3157 If disapproval is True, instead returns reviewers who 'not lgtm'd the CL.
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003158 """
Aaron Gablea1bab272017-04-11 16:38:18 -07003159 approval_type = 'disapproval' if disapproval else 'approval'
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003160 return sorted(
3161 set(
3162 message['sender']
3163 for message in props['messages']
Aaron Gablea1bab272017-04-11 16:38:18 -07003164 if message[approval_type] and message['sender'] in props['reviewers']
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003165 )
3166 )
3167
3168
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003169def FindCodereviewSettingsFile(filename='codereview.settings'):
3170 """Finds the given file starting in the cwd and going up.
3171
3172 Only looks up to the top of the repository unless an
3173 'inherit-review-settings-ok' file exists in the root of the repository.
3174 """
3175 inherit_ok_file = 'inherit-review-settings-ok'
3176 cwd = os.getcwd()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00003177 root = settings.GetRoot()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003178 if os.path.isfile(os.path.join(root, inherit_ok_file)):
3179 root = '/'
3180 while True:
3181 if filename in os.listdir(cwd):
3182 if os.path.isfile(os.path.join(cwd, filename)):
3183 return open(os.path.join(cwd, filename))
3184 if cwd == root:
3185 break
3186 cwd = os.path.dirname(cwd)
3187
3188
3189def LoadCodereviewSettingsFromFile(fileobj):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003190 """Parses a codereview.settings file and updates hooks."""
maruel@chromium.org99ac1c52012-01-16 14:52:12 +00003191 keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003192
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003193 def SetProperty(name, setting, unset_error_ok=False):
3194 fullname = 'rietveld.' + name
3195 if setting in keyvals:
3196 RunGit(['config', fullname, keyvals[setting]])
3197 else:
3198 RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok)
3199
tandrii48df5812016-10-17 03:55:37 -07003200 if not keyvals.get('GERRIT_HOST', False):
3201 SetProperty('server', 'CODE_REVIEW_SERVER')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003202 # Only server setting is required. Other settings can be absent.
3203 # In that case, we ignore errors raised during option deletion attempt.
3204 SetProperty('cc', 'CC_LIST', unset_error_ok=True)
3205 SetProperty('tree-status-url', 'STATUS', unset_error_ok=True)
3206 SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True)
rmistry@google.com90752582014-01-14 21:04:50 +00003207 SetProperty('bug-prefix', 'BUG_PREFIX', unset_error_ok=True)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003208 SetProperty('cpplint-regex', 'LINT_REGEX', unset_error_ok=True)
3209 SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +00003210 SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK',
3211 unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003212
ukai@chromium.org7044efc2013-11-28 01:51:21 +00003213 if 'GERRIT_HOST' in keyvals:
ukai@chromium.orge8077812012-02-03 03:41:46 +00003214 RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']])
ukai@chromium.orge8077812012-02-03 03:41:46 +00003215
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003216 if 'GERRIT_SQUASH_UPLOADS' in keyvals:
tandrii8dd81ea2016-06-16 13:24:23 -07003217 RunGit(['config', 'gerrit.squash-uploads',
3218 keyvals['GERRIT_SQUASH_UPLOADS']])
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003219
tandrii@chromium.org28253532016-04-14 13:46:56 +00003220 if 'GERRIT_SKIP_ENSURE_AUTHENTICATED' in keyvals:
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00003221 RunGit(['config', 'gerrit.skip-ensure-authenticated',
tandrii@chromium.org28253532016-04-14 13:46:56 +00003222 keyvals['GERRIT_SKIP_ENSURE_AUTHENTICATED']])
3223
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003224 if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01003225 # should be of the form
3226 # PUSH_URL_CONFIG: url.ssh://gitrw.chromium.org.pushinsteadof
3227 # ORIGIN_URL_CONFIG: http://src.chromium.org/git
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003228 RunGit(['config', keyvals['PUSH_URL_CONFIG'],
3229 keyvals['ORIGIN_URL_CONFIG']])
3230
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003231
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003232def urlretrieve(source, destination):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003233 """Downloads a network object to a local file, like urllib.urlretrieve.
3234
3235 This is necessary because urllib is broken for SSL connections via a proxy.
3236 """
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003237 with open(destination, 'w') as f:
3238 f.write(urllib2.urlopen(source).read())
3239
3240
ukai@chromium.org712d6102013-11-27 00:52:58 +00003241def hasSheBang(fname):
3242 """Checks fname is a #! script."""
3243 with open(fname) as f:
3244 return f.read(2).startswith('#!')
3245
3246
bpastene@chromium.org917f0ff2016-04-05 00:45:30 +00003247# TODO(bpastene) Remove once a cleaner fix to crbug.com/600473 presents itself.
3248def DownloadHooks(*args, **kwargs):
3249 pass
3250
3251
tandrii@chromium.org18630d62016-03-04 12:06:02 +00003252def DownloadGerritHook(force):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003253 """Downloads and installs a Gerrit commit-msg hook.
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003254
3255 Args:
3256 force: True to update hooks. False to install hooks if not present.
3257 """
3258 if not settings.GetIsGerrit():
3259 return
ukai@chromium.org712d6102013-11-27 00:52:58 +00003260 src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg'
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003261 dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
3262 if not os.access(dst, os.X_OK):
3263 if os.path.exists(dst):
3264 if not force:
3265 return
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003266 try:
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003267 urlretrieve(src, dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003268 if not hasSheBang(dst):
3269 DieWithError('Not a script: %s\n'
3270 'You need to download from\n%s\n'
3271 'into .git/hooks/commit-msg and '
3272 'chmod +x .git/hooks/commit-msg' % (dst, src))
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003273 os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
3274 except Exception:
3275 if os.path.exists(dst):
3276 os.remove(dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003277 DieWithError('\nFailed to download hooks.\n'
3278 'You need to download from\n%s\n'
3279 'into .git/hooks/commit-msg and '
3280 'chmod +x .git/hooks/commit-msg' % src)
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003281
3282
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003283class _GitCookiesChecker(object):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003284 """Provides facilities for validating and suggesting fixes to .gitcookies."""
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003285
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003286 _GOOGLESOURCE = 'googlesource.com'
3287
3288 def __init__(self):
3289 # Cached list of [host, identity, source], where source is either
3290 # .gitcookies or .netrc.
3291 self._all_hosts = None
3292
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003293 def ensure_configured_gitcookies(self):
3294 """Runs checks and suggests fixes to make git use .gitcookies from default
3295 path."""
3296 default = gerrit_util.CookiesAuthenticator.get_gitcookies_path()
3297 configured_path = RunGitSilent(
3298 ['config', '--global', 'http.cookiefile']).strip()
Andrii Shyshkalov1e250cd2017-05-10 15:39:31 +02003299 configured_path = os.path.expanduser(configured_path)
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003300 if configured_path:
3301 self._ensure_default_gitcookies_path(configured_path, default)
3302 else:
3303 self._configure_gitcookies_path(default)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003304
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003305 @staticmethod
3306 def _ensure_default_gitcookies_path(configured_path, default_path):
3307 assert configured_path
3308 if configured_path == default_path:
3309 print('git is already configured to use your .gitcookies from %s' %
3310 configured_path)
3311 return
3312
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003313 print('WARNING: You have configured custom path to .gitcookies: %s\n'
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003314 'Gerrit and other depot_tools expect .gitcookies at %s\n' %
3315 (configured_path, default_path))
3316
3317 if not os.path.exists(configured_path):
3318 print('However, your configured .gitcookies file is missing.')
3319 confirm_or_exit('Reconfigure git to use default .gitcookies?',
3320 action='reconfigure')
3321 RunGit(['config', '--global', 'http.cookiefile', default_path])
3322 return
3323
3324 if os.path.exists(default_path):
3325 print('WARNING: default .gitcookies file already exists %s' %
3326 default_path)
3327 DieWithError('Please delete %s manually and re-run git cl creds-check' %
3328 default_path)
3329
3330 confirm_or_exit('Move existing .gitcookies to default location?',
3331 action='move')
3332 shutil.move(configured_path, default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003333 RunGit(['config', '--global', 'http.cookiefile', default_path])
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003334 print('Moved and reconfigured git to use .gitcookies from %s' %
3335 default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003336
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003337 @staticmethod
3338 def _configure_gitcookies_path(default_path):
3339 netrc_path = gerrit_util.CookiesAuthenticator.get_netrc_path()
3340 if os.path.exists(netrc_path):
3341 print('You seem to be using outdated .netrc for git credentials: %s' %
3342 netrc_path)
3343 print('This tool will guide you through setting up recommended '
3344 '.gitcookies store for git credentials.\n'
3345 '\n'
3346 'IMPORTANT: If something goes wrong and you decide to go back, do:\n'
3347 ' git config --global --unset http.cookiefile\n'
3348 ' mv %s %s.backup\n\n' % (default_path, default_path))
3349 confirm_or_exit(action='setup .gitcookies')
3350 RunGit(['config', '--global', 'http.cookiefile', default_path])
3351 print('Configured git to use .gitcookies from %s' % default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003352
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003353 def get_hosts_with_creds(self, include_netrc=False):
3354 if self._all_hosts is None:
3355 a = gerrit_util.CookiesAuthenticator()
3356 self._all_hosts = [
3357 (h, u, s)
3358 for h, u, s in itertools.chain(
3359 ((h, u, '.netrc') for h, (u, _, _) in a.netrc.hosts.iteritems()),
3360 ((h, u, '.gitcookies') for h, (u, _) in a.gitcookies.iteritems())
3361 )
3362 if h.endswith(self._GOOGLESOURCE)
3363 ]
3364
3365 if include_netrc:
3366 return self._all_hosts
3367 return [(h, u, s) for h, u, s in self._all_hosts if s != '.netrc']
3368
3369 def print_current_creds(self, include_netrc=False):
3370 hosts = sorted(self.get_hosts_with_creds(include_netrc=include_netrc))
3371 if not hosts:
3372 print('No Git/Gerrit credentials found')
3373 return
3374 lengths = [max(map(len, (row[i] for row in hosts))) for i in xrange(3)]
3375 header = [('Host', 'User', 'Which file'),
3376 ['=' * l for l in lengths]]
3377 for row in (header + hosts):
3378 print('\t'.join((('%%+%ds' % l) % s)
3379 for l, s in zip(lengths, row)))
3380
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003381 @staticmethod
3382 def _parse_identity(identity):
Lei Zhangd3f769a2017-12-15 15:16:14 -08003383 """Parses identity "git-<username>.domain" into <username> and domain."""
3384 # Special case: usernames that contain ".", which are generally not
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02003385 # distinguishable from sub-domains. But we do know typical domains:
3386 if identity.endswith('.chromium.org'):
3387 domain = 'chromium.org'
3388 username = identity[:-len('.chromium.org')]
3389 else:
3390 username, domain = identity.split('.', 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003391 if username.startswith('git-'):
3392 username = username[len('git-'):]
3393 return username, domain
3394
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003395 def _canonical_git_googlesource_host(self, host):
3396 """Normalizes Gerrit hosts (with '-review') to Git host."""
3397 assert host.endswith(self._GOOGLESOURCE)
3398 # Prefix doesn't include '.' at the end.
3399 prefix = host[:-(1 + len(self._GOOGLESOURCE))]
3400 if prefix.endswith('-review'):
3401 prefix = prefix[:-len('-review')]
3402 return prefix + '.' + self._GOOGLESOURCE
3403
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003404 def _canonical_gerrit_googlesource_host(self, host):
3405 git_host = self._canonical_git_googlesource_host(host)
3406 prefix = git_host.split('.', 1)[0]
3407 return prefix + '-review.' + self._GOOGLESOURCE
3408
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003409 def _get_counterpart_host(self, host):
3410 assert host.endswith(self._GOOGLESOURCE)
3411 git = self._canonical_git_googlesource_host(host)
3412 gerrit = self._canonical_gerrit_googlesource_host(git)
3413 return git if gerrit == host else gerrit
3414
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003415 def has_generic_host(self):
3416 """Returns whether generic .googlesource.com has been configured.
3417
3418 Chrome Infra recommends to use explicit ${host}.googlesource.com instead.
3419 """
3420 for host, _, _ in self.get_hosts_with_creds(include_netrc=False):
3421 if host == '.' + self._GOOGLESOURCE:
3422 return True
3423 return False
3424
3425 def _get_git_gerrit_identity_pairs(self):
3426 """Returns map from canonic host to pair of identities (Git, Gerrit).
3427
3428 One of identities might be None, meaning not configured.
3429 """
3430 host_to_identity_pairs = {}
3431 for host, identity, _ in self.get_hosts_with_creds():
3432 canonical = self._canonical_git_googlesource_host(host)
3433 pair = host_to_identity_pairs.setdefault(canonical, [None, None])
3434 idx = 0 if canonical == host else 1
3435 pair[idx] = identity
3436 return host_to_identity_pairs
3437
3438 def get_partially_configured_hosts(self):
3439 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003440 (host if i1 else self._canonical_gerrit_googlesource_host(host))
3441 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().iteritems()
3442 if None in (i1, i2) and host != '.' + self._GOOGLESOURCE)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003443
3444 def get_conflicting_hosts(self):
3445 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003446 host
3447 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().iteritems()
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003448 if None not in (i1, i2) and i1 != i2)
3449
3450 def get_duplicated_hosts(self):
3451 counters = collections.Counter(h for h, _, _ in self.get_hosts_with_creds())
3452 return set(host for host, count in counters.iteritems() if count > 1)
3453
3454 _EXPECTED_HOST_IDENTITY_DOMAINS = {
3455 'chromium.googlesource.com': 'chromium.org',
3456 'chrome-internal.googlesource.com': 'google.com',
3457 }
3458
3459 def get_hosts_with_wrong_identities(self):
3460 """Finds hosts which **likely** reference wrong identities.
3461
3462 Note: skips hosts which have conflicting identities for Git and Gerrit.
3463 """
3464 hosts = set()
3465 for host, expected in self._EXPECTED_HOST_IDENTITY_DOMAINS.iteritems():
3466 pair = self._get_git_gerrit_identity_pairs().get(host)
3467 if pair and pair[0] == pair[1]:
3468 _, domain = self._parse_identity(pair[0])
3469 if domain != expected:
3470 hosts.add(host)
3471 return hosts
3472
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003473 @staticmethod
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003474 def _format_hosts(hosts, extra_column_func=None):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003475 hosts = sorted(hosts)
3476 assert hosts
3477 if extra_column_func is None:
3478 extras = [''] * len(hosts)
3479 else:
3480 extras = [extra_column_func(host) for host in hosts]
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003481 tmpl = '%%-%ds %%-%ds' % (max(map(len, hosts)), max(map(len, extras)))
3482 lines = []
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003483 for he in zip(hosts, extras):
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003484 lines.append(tmpl % he)
3485 return lines
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003486
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003487 def _find_problems(self):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003488 if self.has_generic_host():
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003489 yield ('.googlesource.com wildcard record detected',
3490 ['Chrome Infrastructure team recommends to list full host names '
3491 'explicitly.'],
3492 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003493
3494 dups = self.get_duplicated_hosts()
3495 if dups:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003496 yield ('The following hosts were defined twice',
3497 self._format_hosts(dups),
3498 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003499
3500 partial = self.get_partially_configured_hosts()
3501 if partial:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003502 yield ('Credentials should come in pairs for Git and Gerrit hosts. '
3503 'These hosts are missing',
3504 self._format_hosts(partial, lambda host: 'but %s defined' %
3505 self._get_counterpart_host(host)),
3506 partial)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003507
3508 conflicting = self.get_conflicting_hosts()
3509 if conflicting:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003510 yield ('The following Git hosts have differing credentials from their '
3511 'Gerrit counterparts',
3512 self._format_hosts(conflicting, lambda host: '%s vs %s' %
3513 tuple(self._get_git_gerrit_identity_pairs()[host])),
3514 conflicting)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003515
3516 wrong = self.get_hosts_with_wrong_identities()
3517 if wrong:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003518 yield ('These hosts likely use wrong identity',
3519 self._format_hosts(wrong, lambda host: '%s but %s recommended' %
3520 (self._get_git_gerrit_identity_pairs()[host][0],
3521 self._EXPECTED_HOST_IDENTITY_DOMAINS[host])),
3522 wrong)
3523
3524 def find_and_report_problems(self):
3525 """Returns True if there was at least one problem, else False."""
3526 found = False
3527 bad_hosts = set()
3528 for title, sublines, hosts in self._find_problems():
3529 if not found:
3530 found = True
3531 print('\n\n.gitcookies problem report:\n')
3532 bad_hosts.update(hosts or [])
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003533 print(' %s%s' % (title, (':' if sublines else '')))
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003534 if sublines:
3535 print()
3536 print(' %s' % '\n '.join(sublines))
3537 print()
3538
3539 if bad_hosts:
3540 assert found
3541 print(' You can manually remove corresponding lines in your %s file and '
3542 'visit the following URLs with correct account to generate '
3543 'correct credential lines:\n' %
3544 gerrit_util.CookiesAuthenticator.get_gitcookies_path())
3545 print(' %s' % '\n '.join(sorted(set(
3546 gerrit_util.CookiesAuthenticator().get_new_password_url(
3547 self._canonical_git_googlesource_host(host))
3548 for host in bad_hosts
3549 ))))
3550 return found
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003551
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003552
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003553@metrics.collector.collect_metrics('git cl creds-check')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003554def CMDcreds_check(parser, args):
3555 """Checks credentials and suggests changes."""
3556 _, _ = parser.parse_args(args)
3557
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003558 # Code below checks .gitcookies. Abort if using something else.
3559 authn = gerrit_util.Authenticator.get()
3560 if not isinstance(authn, gerrit_util.CookiesAuthenticator):
3561 if isinstance(authn, gerrit_util.GceAuthenticator):
3562 DieWithError(
3563 'This command is not designed for GCE, are you on a bot?\n'
3564 'If you need to run this on GCE, export SKIP_GCE_AUTH_FOR_GIT=1 '
3565 'in your env.')
Aaron Gabled10ca0e2017-09-11 11:24:10 -07003566 DieWithError(
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003567 'This command is not designed for bot environment. It checks '
3568 '~/.gitcookies file not generally used on bots.')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003569
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003570 checker = _GitCookiesChecker()
3571 checker.ensure_configured_gitcookies()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003572
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003573 print('Your .netrc and .gitcookies have credentials for these hosts:')
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003574 checker.print_current_creds(include_netrc=True)
3575
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003576 if not checker.find_and_report_problems():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003577 print('\nNo problems detected in your .gitcookies file.')
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003578 return 0
3579 return 1
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003580
3581
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003582@metrics.collector.collect_metrics('git cl baseurl')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003583def CMDbaseurl(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003584 """Gets or sets base-url for this branch."""
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003585 branchref = RunGit(['symbolic-ref', 'HEAD']).strip()
3586 branch = ShortBranchName(branchref)
3587 _, args = parser.parse_args(args)
3588 if not args:
vapiera7fbd5a2016-06-16 09:17:49 -07003589 print('Current base-url:')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003590 return RunGit(['config', 'branch.%s.base-url' % branch],
3591 error_ok=False).strip()
3592 else:
vapiera7fbd5a2016-06-16 09:17:49 -07003593 print('Setting base-url to %s' % args[0])
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003594 return RunGit(['config', 'branch.%s.base-url' % branch, args[0]],
3595 error_ok=False).strip()
3596
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003597
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003598def color_for_status(status):
3599 """Maps a Changelist status to color, for CMDstatus and other tools."""
3600 return {
Aaron Gable9ab38c62017-04-06 14:36:33 -07003601 'unsent': Fore.YELLOW,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003602 'waiting': Fore.BLUE,
3603 'reply': Fore.YELLOW,
Aaron Gable9ab38c62017-04-06 14:36:33 -07003604 'not lgtm': Fore.RED,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003605 'lgtm': Fore.GREEN,
3606 'commit': Fore.MAGENTA,
3607 'closed': Fore.CYAN,
3608 'error': Fore.WHITE,
3609 }.get(status, Fore.WHITE)
3610
tandrii@chromium.org04ea8462016-04-25 19:51:21 +00003611
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003612def get_cl_statuses(changes, fine_grained, max_processes=None):
3613 """Returns a blocking iterable of (cl, status) for given branches.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003614
3615 If fine_grained is true, this will fetch CL statuses from the server.
3616 Otherwise, simply indicate if there's a matching url for the given branches.
3617
3618 If max_processes is specified, it is used as the maximum number of processes
3619 to spawn to fetch CL status from the server. Otherwise 1 process per branch is
3620 spawned.
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003621
3622 See GetStatus() for a list of possible statuses.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003623 """
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003624 if not changes:
3625 raise StopIteration()
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003626
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003627 if not fine_grained:
3628 # Fast path which doesn't involve querying codereview servers.
Aaron Gablea1bab272017-04-11 16:38:18 -07003629 # Do not use get_approving_reviewers(), since it requires an HTTP request.
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003630 for cl in changes:
3631 yield (cl, 'waiting' if cl.GetIssueURL() else 'error')
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003632 return
3633
3634 # First, sort out authentication issues.
3635 logging.debug('ensuring credentials exist')
3636 for cl in changes:
3637 cl.EnsureAuthenticated(force=False, refresh=True)
3638
3639 def fetch(cl):
3640 try:
3641 return (cl, cl.GetStatus())
3642 except:
3643 # See http://crbug.com/629863.
Andrii Shyshkalov98824232018-04-19 11:37:15 -07003644 logging.exception('failed to fetch status for cl %s:', cl.GetIssue())
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003645 raise
3646
3647 threads_count = len(changes)
3648 if max_processes:
3649 threads_count = max(1, min(threads_count, max_processes))
3650 logging.debug('querying %d CLs using %d threads', len(changes), threads_count)
3651
3652 pool = ThreadPool(threads_count)
3653 fetched_cls = set()
3654 try:
3655 it = pool.imap_unordered(fetch, changes).__iter__()
3656 while True:
3657 try:
3658 cl, status = it.next(timeout=5)
3659 except multiprocessing.TimeoutError:
3660 break
3661 fetched_cls.add(cl)
3662 yield cl, status
3663 finally:
3664 pool.close()
3665
3666 # Add any branches that failed to fetch.
3667 for cl in set(changes) - fetched_cls:
3668 yield (cl, 'error')
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003669
rmistry@google.com2dd99862015-06-22 12:22:18 +00003670
3671def upload_branch_deps(cl, args):
3672 """Uploads CLs of local branches that are dependents of the current branch.
3673
3674 If the local branch dependency tree looks like:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003675
3676 test1 -> test2.1 -> test3.1
3677 -> test3.2
3678 -> test2.2 -> test3.3
rmistry@google.com2dd99862015-06-22 12:22:18 +00003679
3680 and you run "git cl upload --dependencies" from test1 then "git cl upload" is
3681 run on the dependent branches in this order:
3682 test2.1, test3.1, test3.2, test2.2, test3.3
3683
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003684 Note: This function does not rebase your local dependent branches. Use it
3685 when you make a change to the parent branch that will not conflict
3686 with its dependent branches, and you would like their dependencies
3687 updated in Rietveld.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003688 """
3689 if git_common.is_dirty_git_tree('upload-branch-deps'):
3690 return 1
3691
3692 root_branch = cl.GetBranch()
3693 if root_branch is None:
3694 DieWithError('Can\'t find dependent branches from detached HEAD state. '
3695 'Get on a branch!')
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00003696 if not cl.GetIssue():
rmistry@google.com2dd99862015-06-22 12:22:18 +00003697 DieWithError('Current branch does not have an uploaded CL. We cannot set '
3698 'patchset dependencies without an uploaded CL.')
3699
3700 branches = RunGit(['for-each-ref',
3701 '--format=%(refname:short) %(upstream:short)',
3702 'refs/heads'])
3703 if not branches:
3704 print('No local branches found.')
3705 return 0
3706
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003707 # Create a dictionary of all local branches to the branches that are
3708 # dependent on it.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003709 tracked_to_dependents = collections.defaultdict(list)
3710 for b in branches.splitlines():
3711 tokens = b.split()
3712 if len(tokens) == 2:
3713 branch_name, tracked = tokens
3714 tracked_to_dependents[tracked].append(branch_name)
3715
vapiera7fbd5a2016-06-16 09:17:49 -07003716 print()
3717 print('The dependent local branches of %s are:' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003718 dependents = []
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003719
rmistry@google.com2dd99862015-06-22 12:22:18 +00003720 def traverse_dependents_preorder(branch, padding=''):
3721 dependents_to_process = tracked_to_dependents.get(branch, [])
3722 padding += ' '
3723 for dependent in dependents_to_process:
vapiera7fbd5a2016-06-16 09:17:49 -07003724 print('%s%s' % (padding, dependent))
rmistry@google.com2dd99862015-06-22 12:22:18 +00003725 dependents.append(dependent)
3726 traverse_dependents_preorder(dependent, padding)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003727
rmistry@google.com2dd99862015-06-22 12:22:18 +00003728 traverse_dependents_preorder(root_branch)
vapiera7fbd5a2016-06-16 09:17:49 -07003729 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003730
3731 if not dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003732 print('There are no dependent local branches for %s' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003733 return 0
3734
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01003735 confirm_or_exit('This command will checkout all dependent branches and run '
3736 '"git cl upload".', action='continue')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003737
rmistry@google.com2dd99862015-06-22 12:22:18 +00003738 # Record all dependents that failed to upload.
3739 failures = {}
3740 # Go through all dependents, checkout the branch and upload.
3741 try:
3742 for dependent_branch in dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003743 print()
3744 print('--------------------------------------')
3745 print('Running "git cl upload" from %s:' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003746 RunGit(['checkout', '-q', dependent_branch])
vapiera7fbd5a2016-06-16 09:17:49 -07003747 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003748 try:
3749 if CMDupload(OptionParser(), args) != 0:
vapiera7fbd5a2016-06-16 09:17:49 -07003750 print('Upload failed for %s!' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003751 failures[dependent_branch] = 1
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003752 except: # pylint: disable=bare-except
rmistry@google.com2dd99862015-06-22 12:22:18 +00003753 failures[dependent_branch] = 1
vapiera7fbd5a2016-06-16 09:17:49 -07003754 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003755 finally:
3756 # Swap back to the original root branch.
3757 RunGit(['checkout', '-q', root_branch])
3758
vapiera7fbd5a2016-06-16 09:17:49 -07003759 print()
3760 print('Upload complete for dependent branches!')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003761 for dependent_branch in dependents:
3762 upload_status = 'failed' if failures.get(dependent_branch) else 'succeeded'
vapiera7fbd5a2016-06-16 09:17:49 -07003763 print(' %s : %s' % (dependent_branch, upload_status))
3764 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003765
3766 return 0
3767
3768
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003769@metrics.collector.collect_metrics('git cl archive')
kmarshall3bff56b2016-06-06 18:31:47 -07003770def CMDarchive(parser, args):
3771 """Archives and deletes branches associated with closed changelists."""
3772 parser.add_option(
3773 '-j', '--maxjobs', action='store', type=int,
kmarshall9249e012016-08-23 12:02:16 -07003774 help='The maximum number of jobs to use when retrieving review status.')
kmarshall3bff56b2016-06-06 18:31:47 -07003775 parser.add_option(
3776 '-f', '--force', action='store_true',
3777 help='Bypasses the confirmation prompt.')
kmarshall9249e012016-08-23 12:02:16 -07003778 parser.add_option(
3779 '-d', '--dry-run', action='store_true',
3780 help='Skip the branch tagging and removal steps.')
3781 parser.add_option(
3782 '-t', '--notags', action='store_true',
3783 help='Do not tag archived branches. '
3784 'Note: local commit history may be lost.')
kmarshall3bff56b2016-06-06 18:31:47 -07003785
kmarshall3bff56b2016-06-06 18:31:47 -07003786 options, args = parser.parse_args(args)
3787 if args:
3788 parser.error('Unsupported args: %s' % ' '.join(args))
kmarshall3bff56b2016-06-06 18:31:47 -07003789
3790 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
3791 if not branches:
3792 return 0
3793
vapiera7fbd5a2016-06-16 09:17:49 -07003794 print('Finding all branches associated with closed issues...')
Edward Lemur934836a2019-09-09 20:16:54 +00003795 changes = [Changelist(branchref=b)
3796 for b in branches.splitlines()]
kmarshall3bff56b2016-06-06 18:31:47 -07003797 alignment = max(5, max(len(c.GetBranch()) for c in changes))
3798 statuses = get_cl_statuses(changes,
3799 fine_grained=True,
3800 max_processes=options.maxjobs)
3801 proposal = [(cl.GetBranch(),
3802 'git-cl-archived-%s-%s' % (cl.GetIssue(), cl.GetBranch()))
3803 for cl, status in statuses
Andrii Shyshkalov51bdf8c2018-10-18 01:07:58 +00003804 if status in ('closed', 'rietveld-not-supported')]
kmarshall3bff56b2016-06-06 18:31:47 -07003805 proposal.sort()
3806
3807 if not proposal:
vapiera7fbd5a2016-06-16 09:17:49 -07003808 print('No branches with closed codereview issues found.')
kmarshall3bff56b2016-06-06 18:31:47 -07003809 return 0
3810
3811 current_branch = GetCurrentBranch()
3812
vapiera7fbd5a2016-06-16 09:17:49 -07003813 print('\nBranches with closed issues that will be archived:\n')
kmarshall9249e012016-08-23 12:02:16 -07003814 if options.notags:
3815 for next_item in proposal:
3816 print(' ' + next_item[0])
3817 else:
3818 print('%*s | %s' % (alignment, 'Branch name', 'Archival tag name'))
3819 for next_item in proposal:
3820 print('%*s %s' % (alignment, next_item[0], next_item[1]))
kmarshall3bff56b2016-06-06 18:31:47 -07003821
kmarshall9249e012016-08-23 12:02:16 -07003822 # Quit now on precondition failure or if instructed by the user, either
3823 # via an interactive prompt or by command line flags.
3824 if options.dry_run:
3825 print('\nNo changes were made (dry run).\n')
3826 return 0
3827 elif any(branch == current_branch for branch, _ in proposal):
kmarshall3bff56b2016-06-06 18:31:47 -07003828 print('You are currently on a branch \'%s\' which is associated with a '
3829 'closed codereview issue, so archive cannot proceed. Please '
3830 'checkout another branch and run this command again.' %
3831 current_branch)
3832 return 1
kmarshall9249e012016-08-23 12:02:16 -07003833 elif not options.force:
sergiyb4a5ecbe2016-06-20 09:46:00 -07003834 answer = ask_for_data('\nProceed with deletion (Y/n)? ').lower()
3835 if answer not in ('y', ''):
vapiera7fbd5a2016-06-16 09:17:49 -07003836 print('Aborted.')
kmarshall3bff56b2016-06-06 18:31:47 -07003837 return 1
3838
3839 for branch, tagname in proposal:
kmarshall9249e012016-08-23 12:02:16 -07003840 if not options.notags:
3841 RunGit(['tag', tagname, branch])
kmarshall3bff56b2016-06-06 18:31:47 -07003842 RunGit(['branch', '-D', branch])
kmarshall9249e012016-08-23 12:02:16 -07003843
vapiera7fbd5a2016-06-16 09:17:49 -07003844 print('\nJob\'s done!')
kmarshall3bff56b2016-06-06 18:31:47 -07003845
3846 return 0
3847
3848
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003849@metrics.collector.collect_metrics('git cl status')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003850def CMDstatus(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003851 """Show status of changelists.
3852
3853 Colors are used to tell the state of the CL unless --fast is used:
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003854 - Blue waiting for review
Aaron Gable9ab38c62017-04-06 14:36:33 -07003855 - Yellow waiting for you to reply to review, or not yet sent
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003856 - Green LGTM'ed
Aaron Gable9ab38c62017-04-06 14:36:33 -07003857 - Red 'not LGTM'ed
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00003858 - Magenta in the CQ
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003859 - Cyan was committed, branch can be deleted
Aaron Gable9ab38c62017-04-06 14:36:33 -07003860 - White error, or unknown status
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003861
3862 Also see 'git cl comments'.
3863 """
Alan Cuttera3be9a52019-03-04 18:50:33 +00003864 parser.add_option(
3865 '--no-branch-color',
3866 action='store_true',
3867 help='Disable colorized branch names')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003868 parser.add_option('--field',
phajdan.jr289d03e2016-08-16 08:21:06 -07003869 help='print only specific field (desc|id|patch|status|url)')
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003870 parser.add_option('-f', '--fast', action='store_true',
3871 help='Do not retrieve review status')
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003872 parser.add_option(
3873 '-j', '--maxjobs', action='store', type=int,
3874 help='The maximum number of jobs to use when retrieving review status')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003875
iannuccie53c9352016-08-17 14:40:40 -07003876 _add_codereview_issue_select_options(
3877 parser, 'Must be in conjunction with --field.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003878 options, args = parser.parse_args(args)
Edward Lemurf38bc172019-09-03 21:02:13 +00003879 _process_codereview_select_options(parser, options)
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003880 if args:
3881 parser.error('Unsupported args: %s' % args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003882
iannuccie53c9352016-08-17 14:40:40 -07003883 if options.issue is not None and not options.field:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00003884 parser.error('--field must be specified with --issue.')
iannucci3c972b92016-08-17 13:24:10 -07003885
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003886 if options.field:
Edward Lemur934836a2019-09-09 20:16:54 +00003887 cl = Changelist(issue=options.issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003888 if options.field.startswith('desc'):
vapiera7fbd5a2016-06-16 09:17:49 -07003889 print(cl.GetDescription())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003890 elif options.field == 'id':
3891 issueid = cl.GetIssue()
3892 if issueid:
vapiera7fbd5a2016-06-16 09:17:49 -07003893 print(issueid)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003894 elif options.field == 'patch':
Aaron Gablee8856ee2017-12-07 12:41:46 -08003895 patchset = cl.GetMostRecentPatchset()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003896 if patchset:
vapiera7fbd5a2016-06-16 09:17:49 -07003897 print(patchset)
phajdan.jr289d03e2016-08-16 08:21:06 -07003898 elif options.field == 'status':
3899 print(cl.GetStatus())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003900 elif options.field == 'url':
3901 url = cl.GetIssueURL()
3902 if url:
vapiera7fbd5a2016-06-16 09:17:49 -07003903 print(url)
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00003904 return 0
3905
3906 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
3907 if not branches:
3908 print('No local branch found.')
3909 return 0
3910
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003911 changes = [
Edward Lemur934836a2019-09-09 20:16:54 +00003912 Changelist(branchref=b)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003913 for b in branches.splitlines()]
vapiera7fbd5a2016-06-16 09:17:49 -07003914 print('Branches associated with reviews:')
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003915 output = get_cl_statuses(changes,
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003916 fine_grained=not options.fast,
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003917 max_processes=options.maxjobs)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003918
Daniel McArdlea23bf592019-02-12 00:25:12 +00003919 current_branch = GetCurrentBranch()
3920
3921 def FormatBranchName(branch, colorize=False):
3922 """Simulates 'git branch' behavior. Colorizes and prefixes branch name with
3923 an asterisk when it is the current branch."""
3924
3925 asterisk = ""
3926 color = Fore.RESET
3927 if branch == current_branch:
3928 asterisk = "* "
3929 color = Fore.GREEN
3930 branch_name = ShortBranchName(branch)
3931
3932 if colorize:
3933 return asterisk + color + branch_name + Fore.RESET
Daniel McArdle452a49f2019-02-14 17:28:31 +00003934 return asterisk + branch_name
3935
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003936 branch_statuses = {}
Daniel McArdlea23bf592019-02-12 00:25:12 +00003937
3938 alignment = max(5, max(len(FormatBranchName(c.GetBranch())) for c in changes))
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003939 for cl in sorted(changes, key=lambda c: c.GetBranch()):
3940 branch = cl.GetBranch()
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003941 while branch not in branch_statuses:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003942 c, status = output.next()
3943 branch_statuses[c.GetBranch()] = status
3944 status = branch_statuses.pop(branch)
3945 url = cl.GetIssueURL()
3946 if url and (not status or status == 'error'):
3947 # The issue probably doesn't exist anymore.
3948 url += ' (broken)'
3949
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003950 color = color_for_status(status)
maruel@chromium.org885f6512013-07-27 02:17:26 +00003951 reset = Fore.RESET
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00003952 if not setup_color.IS_TTY:
maruel@chromium.org885f6512013-07-27 02:17:26 +00003953 color = ''
3954 reset = ''
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003955 status_str = '(%s)' % status if status else ''
Daniel McArdle452a49f2019-02-14 17:28:31 +00003956
Alan Cuttera3be9a52019-03-04 18:50:33 +00003957 branch_display = FormatBranchName(branch)
3958 padding = ' ' * (alignment - len(branch_display))
3959 if not options.no_branch_color:
3960 branch_display = FormatBranchName(branch, colorize=True)
Daniel McArdle452a49f2019-02-14 17:28:31 +00003961
Alan Cuttera3be9a52019-03-04 18:50:33 +00003962 print(' %s : %s%s %s%s' % (padding + branch_display, color, url,
3963 status_str, reset))
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003964
vapiera7fbd5a2016-06-16 09:17:49 -07003965 print()
Daniel McArdlea23bf592019-02-12 00:25:12 +00003966 print('Current branch: %s' % current_branch)
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003967 for cl in changes:
Daniel McArdlea23bf592019-02-12 00:25:12 +00003968 if cl.GetBranch() == current_branch:
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003969 break
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003970 if not cl.GetIssue():
vapiera7fbd5a2016-06-16 09:17:49 -07003971 print('No issue assigned.')
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003972 return 0
vapiera7fbd5a2016-06-16 09:17:49 -07003973 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
maruel@chromium.org85616e02014-07-28 15:37:55 +00003974 if not options.fast:
vapiera7fbd5a2016-06-16 09:17:49 -07003975 print('Issue description:')
3976 print(cl.GetDescription(pretty=True))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003977 return 0
3978
3979
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003980def colorize_CMDstatus_doc():
3981 """To be called once in main() to add colors to git cl status help."""
3982 colors = [i for i in dir(Fore) if i[0].isupper()]
3983
3984 def colorize_line(line):
3985 for color in colors:
3986 if color in line.upper():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003987 # Extract whitespace first and the leading '-'.
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003988 indent = len(line) - len(line.lstrip(' ')) + 1
3989 return line[:indent] + getattr(Fore, color) + line[indent:] + Fore.RESET
3990 return line
3991
3992 lines = CMDstatus.__doc__.splitlines()
3993 CMDstatus.__doc__ = '\n'.join(colorize_line(l) for l in lines)
3994
3995
phajdan.jre328cf92016-08-22 04:12:17 -07003996def write_json(path, contents):
Stefan Zager1306bd02017-06-22 19:26:46 -07003997 if path == '-':
3998 json.dump(contents, sys.stdout)
3999 else:
4000 with open(path, 'w') as f:
4001 json.dump(contents, f)
phajdan.jre328cf92016-08-22 04:12:17 -07004002
4003
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004004@subcommand.usage('[issue_number]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004005@metrics.collector.collect_metrics('git cl issue')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004006def CMDissue(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004007 """Sets or displays the current code review issue number.
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004008
4009 Pass issue number 0 to clear the current issue.
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004010 """
dnj@chromium.org406c4402015-03-03 17:22:28 +00004011 parser.add_option('-r', '--reverse', action='store_true',
4012 help='Lookup the branch(es) for the specified issues. If '
4013 'no issues are specified, all branches with mapped '
4014 'issues will be listed.')
Stefan Zager1306bd02017-06-22 19:26:46 -07004015 parser.add_option('--json',
4016 help='Path to JSON output file, or "-" for stdout.')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004017 _add_codereview_select_options(parser)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004018 options, args = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004019 _process_codereview_select_options(parser, options)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004020
dnj@chromium.org406c4402015-03-03 17:22:28 +00004021 if options.reverse:
4022 branches = RunGit(['for-each-ref', 'refs/heads',
Aaron Gablead64abd2017-12-04 09:49:13 -08004023 '--format=%(refname)']).splitlines()
dnj@chromium.org406c4402015-03-03 17:22:28 +00004024 # Reverse issue lookup.
4025 issue_branch_map = {}
Daniel Bratellb56a43a2018-09-06 15:49:03 +00004026
4027 git_config = {}
4028 for config in RunGit(['config', '--get-regexp',
4029 r'branch\..*issue']).splitlines():
4030 name, _space, val = config.partition(' ')
4031 git_config[name] = val
4032
dnj@chromium.org406c4402015-03-03 17:22:28 +00004033 for branch in branches:
Daniel Bratellb56a43a2018-09-06 15:49:03 +00004034 for cls in _CODEREVIEW_IMPLEMENTATIONS.values():
4035 config_key = _git_branch_config_key(ShortBranchName(branch),
4036 cls.IssueConfigKey())
4037 issue = git_config.get(config_key)
4038 if issue:
4039 issue_branch_map.setdefault(int(issue), []).append(branch)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004040 if not args:
4041 args = sorted(issue_branch_map.iterkeys())
phajdan.jre328cf92016-08-22 04:12:17 -07004042 result = {}
dnj@chromium.org406c4402015-03-03 17:22:28 +00004043 for issue in args:
Lei Zhang5a368d42019-03-25 23:18:19 +00004044 try:
4045 issue_num = int(issue)
4046 except ValueError:
4047 print('ERROR cannot parse issue number: %s' % issue, file=sys.stderr)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004048 continue
Lei Zhang5a368d42019-03-25 23:18:19 +00004049 result[issue_num] = issue_branch_map.get(issue_num)
vapiera7fbd5a2016-06-16 09:17:49 -07004050 print('Branch for issue number %s: %s' % (
Lei Zhang5a368d42019-03-25 23:18:19 +00004051 issue, ', '.join(issue_branch_map.get(issue_num) or ('None',))))
phajdan.jre328cf92016-08-22 04:12:17 -07004052 if options.json:
4053 write_json(options.json, result)
Aaron Gable78753da2017-06-15 10:35:49 -07004054 return 0
4055
4056 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00004057 issue = ParseIssueNumberArgument(args[0])
Aaron Gable78753da2017-06-15 10:35:49 -07004058 if not issue.valid:
4059 DieWithError('Pass a url or number to set the issue, 0 to unset it, '
4060 'or no argument to list it.\n'
4061 'Maybe you want to run git cl status?')
Edward Lemurf38bc172019-09-03 21:02:13 +00004062 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07004063 cl.SetIssue(issue.issue)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004064 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00004065 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07004066 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
4067 if options.json:
4068 write_json(options.json, {
4069 'issue': cl.GetIssue(),
4070 'issue_url': cl.GetIssueURL(),
4071 })
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004072 return 0
4073
4074
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004075@metrics.collector.collect_metrics('git cl comments')
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004076def CMDcomments(parser, args):
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004077 """Shows or posts review comments for any changelist."""
4078 parser.add_option('-a', '--add-comment', dest='comment',
4079 help='comment to add to an issue')
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00004080 parser.add_option('-p', '--publish', action='store_true',
4081 help='marks CL as ready and sends comment to reviewers')
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01004082 parser.add_option('-i', '--issue', dest='issue',
Edward Lemurf38bc172019-09-03 21:02:13 +00004083 help='review issue id (defaults to current issue).')
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07004084 parser.add_option('-m', '--machine-readable', dest='readable',
4085 action='store_false', default=True,
4086 help='output comments in a format compatible with '
4087 'editor parsing')
smut@google.comc85ac942015-09-15 16:34:43 +00004088 parser.add_option('-j', '--json-file',
Stefan Zager1306bd02017-06-22 19:26:46 -07004089 help='File to write JSON summary to, or "-" for stdout')
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004090 _add_codereview_select_options(parser)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004091 options, args = parser.parse_args(args)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004092 _process_codereview_select_options(parser, options)
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004093
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004094 issue = None
4095 if options.issue:
4096 try:
4097 issue = int(options.issue)
4098 except ValueError:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004099 DieWithError('A review issue ID is expected to be a number.')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004100
Edward Lemur934836a2019-09-09 20:16:54 +00004101 cl = Changelist(issue=issue)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004102
4103 if options.comment:
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00004104 cl.AddComment(options.comment, options.publish)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004105 return 0
4106
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07004107 summary = sorted(cl.GetCommentsSummary(readable=options.readable),
4108 key=lambda c: c.date)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004109 for comment in summary:
4110 if comment.disapproval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004111 color = Fore.RED
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004112 elif comment.approval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004113 color = Fore.GREEN
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004114 elif comment.sender == cl.GetIssueOwner():
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004115 color = Fore.MAGENTA
Quinten Yearsley0e617c02019-02-20 00:37:03 +00004116 elif comment.autogenerated:
4117 color = Fore.CYAN
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004118 else:
4119 color = Fore.BLUE
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004120 print('\n%s%s %s%s\n%s' % (
4121 color,
4122 comment.date.strftime('%Y-%m-%d %H:%M:%S UTC'),
4123 comment.sender,
4124 Fore.RESET,
4125 '\n'.join(' ' + l for l in comment.message.strip().splitlines())))
4126
smut@google.comc85ac942015-09-15 16:34:43 +00004127 if options.json_file:
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004128 def pre_serialize(c):
4129 dct = c.__dict__.copy()
4130 dct['date'] = dct['date'].strftime('%Y-%m-%d %H:%M:%S.%f')
4131 return dct
Leszek Swirski45b20c42018-09-17 17:05:26 +00004132 write_json(options.json_file, map(pre_serialize, summary))
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004133 return 0
4134
4135
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004136@subcommand.usage('[codereview url or issue id]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004137@metrics.collector.collect_metrics('git cl description')
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004138def CMDdescription(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004139 """Brings up the editor for the current CL's description."""
smut@google.com34fb6b12015-07-13 20:03:26 +00004140 parser.add_option('-d', '--display', action='store_true',
4141 help='Display the description instead of opening an editor')
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004142 parser.add_option('-n', '--new-description',
dnjba1b0f32016-09-02 12:37:42 -07004143 help='New description to set for this issue (- for stdin, '
4144 '+ to load from local commit HEAD)')
dsansomee2d6fd92016-09-08 00:10:47 -07004145 parser.add_option('-f', '--force', action='store_true',
4146 help='Delete any unpublished Gerrit edits for this issue '
4147 'without prompting')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004148
4149 _add_codereview_select_options(parser)
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004150 options, args = parser.parse_args(args)
4151 _process_codereview_select_options(parser, options)
4152
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004153 target_issue_arg = None
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004154 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00004155 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004156 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004157 parser.error('Invalid issue ID or URL.')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004158
Edward Lemur934836a2019-09-09 20:16:54 +00004159 kwargs = {}
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004160 detected_codereview_from_url = False
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004161 if target_issue_arg:
4162 kwargs['issue'] = target_issue_arg.issue
4163 kwargs['codereview_host'] = target_issue_arg.hostname
Edward Lemurf38bc172019-09-03 21:02:13 +00004164 if not args[0].isdigit() and not options.forced_codereview:
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004165 detected_codereview_from_url = True
martiniss6eda05f2016-06-30 10:18:35 -07004166
4167 cl = Changelist(**kwargs)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004168 if not cl.GetIssue():
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004169 assert not detected_codereview_from_url
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004170 DieWithError('This branch has no associated changelist.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004171
4172 if detected_codereview_from_url:
Edward Lemurf38bc172019-09-03 21:02:13 +00004173 logging.info('canonical issue/change URL: %s\n', cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004174
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004175 description = ChangeDescription(cl.GetDescription())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004176
smut@google.com34fb6b12015-07-13 20:03:26 +00004177 if options.display:
vapiera7fbd5a2016-06-16 09:17:49 -07004178 print(description.description)
smut@google.com34fb6b12015-07-13 20:03:26 +00004179 return 0
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004180
4181 if options.new_description:
4182 text = options.new_description
4183 if text == '-':
4184 text = '\n'.join(l.rstrip() for l in sys.stdin)
dnjba1b0f32016-09-02 12:37:42 -07004185 elif text == '+':
4186 base_branch = cl.GetCommonAncestorWithUpstream()
4187 change = cl.GetChange(base_branch, None, local_description=True)
4188 text = change.FullDescriptionText()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004189
4190 description.set_description(text)
4191 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00004192 description.prompt()
Andrii Shyshkalov680253d2017-03-15 21:07:36 +01004193 if cl.GetDescription().strip() != description.description:
dsansomee2d6fd92016-09-08 00:10:47 -07004194 cl.UpdateDescription(description.description, force=options.force)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004195 return 0
4196
4197
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004198@metrics.collector.collect_metrics('git cl lint')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004199def CMDlint(parser, args):
4200 """Runs cpplint on the current changelist."""
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004201 parser.add_option('--filter', action='append', metavar='-x,+y',
4202 help='Comma-separated list of cpplint\'s category-filters')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004203 options, args = parser.parse_args(args)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004204
4205 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08004206 # pylint: disable=protected-access
thestig@chromium.org44202a22014-03-11 19:22:18 +00004207 try:
4208 import cpplint
4209 import cpplint_chromium
4210 except ImportError:
vapiera7fbd5a2016-06-16 09:17:49 -07004211 print('Your depot_tools is missing cpplint.py and/or cpplint_chromium.py.')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004212 return 1
4213
4214 # Change the current working directory before calling lint so that it
4215 # shows the correct base.
4216 previous_cwd = os.getcwd()
4217 os.chdir(settings.GetRoot())
4218 try:
Edward Lemur934836a2019-09-09 20:16:54 +00004219 cl = Changelist()
thestig@chromium.org44202a22014-03-11 19:22:18 +00004220 change = cl.GetChange(cl.GetCommonAncestorWithUpstream(), None)
4221 files = [f.LocalPath() for f in change.AffectedFiles()]
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004222 if not files:
vapiera7fbd5a2016-06-16 09:17:49 -07004223 print('Cannot lint an empty CL')
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004224 return 1
thestig@chromium.org44202a22014-03-11 19:22:18 +00004225
4226 # Process cpplints arguments if any.
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004227 command = args + files
4228 if options.filter:
4229 command = ['--filter=' + ','.join(options.filter)] + command
4230 filenames = cpplint.ParseArguments(command)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004231
4232 white_regex = re.compile(settings.GetLintRegex())
4233 black_regex = re.compile(settings.GetLintIgnoreRegex())
4234 extra_check_functions = [cpplint_chromium.CheckPointerDeclarationWhitespace]
4235 for filename in filenames:
4236 if white_regex.match(filename):
4237 if black_regex.match(filename):
vapiera7fbd5a2016-06-16 09:17:49 -07004238 print('Ignoring file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004239 else:
4240 cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level,
4241 extra_check_functions)
4242 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004243 print('Skipping file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004244 finally:
4245 os.chdir(previous_cwd)
vapiera7fbd5a2016-06-16 09:17:49 -07004246 print('Total errors found: %d\n' % cpplint._cpplint_state.error_count)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004247 if cpplint._cpplint_state.error_count != 0:
4248 return 1
4249 return 0
4250
4251
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004252@metrics.collector.collect_metrics('git cl presubmit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004253def CMDpresubmit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004254 """Runs presubmit tests on the current changelist."""
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004255 parser.add_option('-u', '--upload', action='store_true',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004256 help='Run upload hook instead of the push hook')
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004257 parser.add_option('-f', '--force', action='store_true',
sbc@chromium.org495ad152012-09-04 23:07:42 +00004258 help='Run checks even if tree is dirty')
Aaron Gable8076c282017-11-29 14:39:41 -08004259 parser.add_option('--all', action='store_true',
4260 help='Run checks against all files, not just modified ones')
Edward Lesmes8e282792018-04-03 18:50:29 -04004261 parser.add_option('--parallel', action='store_true',
4262 help='Run all tests specified by input_api.RunTests in all '
4263 'PRESUBMIT files in parallel.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004264 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004265
sbc@chromium.org71437c02015-04-09 19:29:40 +00004266 if not options.force and git_common.is_dirty_git_tree('presubmit'):
vapiera7fbd5a2016-06-16 09:17:49 -07004267 print('use --force to check even if tree is dirty.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004268 return 1
4269
Edward Lemur934836a2019-09-09 20:16:54 +00004270 cl = Changelist()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004271 if args:
4272 base_branch = args[0]
4273 else:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00004274 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004275 base_branch = cl.GetCommonAncestorWithUpstream()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004276
Aaron Gable8076c282017-11-29 14:39:41 -08004277 if options.all:
4278 base_change = cl.GetChange(base_branch, None)
4279 files = [('M', f) for f in base_change.AllFiles()]
4280 change = presubmit_support.GitChange(
4281 base_change.Name(),
4282 base_change.FullDescriptionText(),
4283 base_change.RepositoryRoot(),
4284 files,
4285 base_change.issue,
4286 base_change.patchset,
4287 base_change.author_email,
4288 base_change._upstream)
4289 else:
4290 change = cl.GetChange(base_branch, None)
4291
ilevy@chromium.org051ad0e2013-03-04 21:57:34 +00004292 cl.RunHook(
4293 committing=not options.upload,
4294 may_prompt=False,
4295 verbose=options.verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04004296 change=change,
4297 parallel=options.parallel)
dpranke@chromium.org0a2bb372011-03-25 01:16:22 +00004298 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004299
4300
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004301def GenerateGerritChangeId(message):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004302 """Returns the Change ID footer value (Ixxxxxx...xxx).
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004303
4304 Works the same way as
4305 https://gerrit-review.googlesource.com/tools/hooks/commit-msg
4306 but can be called on demand on all platforms.
4307
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004308 The basic idea is to generate git hash of a state of the tree, original
4309 commit message, author/committer info and timestamps.
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004310 """
4311 lines = []
4312 tree_hash = RunGitSilent(['write-tree'])
4313 lines.append('tree %s' % tree_hash.strip())
4314 code, parent = RunGitWithCode(['rev-parse', 'HEAD~0'], suppress_stderr=False)
4315 if code == 0:
4316 lines.append('parent %s' % parent.strip())
4317 author = RunGitSilent(['var', 'GIT_AUTHOR_IDENT'])
4318 lines.append('author %s' % author.strip())
4319 committer = RunGitSilent(['var', 'GIT_COMMITTER_IDENT'])
4320 lines.append('committer %s' % committer.strip())
4321 lines.append('')
4322 # Note: Gerrit's commit-hook actually cleans message of some lines and
4323 # whitespace. This code is not doing this, but it clearly won't decrease
4324 # entropy.
4325 lines.append(message)
4326 change_hash = RunCommand(['git', 'hash-object', '-t', 'commit', '--stdin'],
Raul Tambreb946b232019-03-26 14:48:46 +00004327 stdin=('\n'.join(lines)).encode())
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004328 return 'I%s' % change_hash.strip()
4329
4330
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01004331def GetTargetRef(remote, remote_branch, target_branch):
wittman@chromium.org455dc922015-01-26 20:15:50 +00004332 """Computes the remote branch ref to use for the CL.
4333
4334 Args:
4335 remote (str): The git remote for the CL.
4336 remote_branch (str): The git remote branch for the CL.
4337 target_branch (str): The target branch specified by the user.
wittman@chromium.org455dc922015-01-26 20:15:50 +00004338 """
4339 if not (remote and remote_branch):
4340 return None
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004341
wittman@chromium.org455dc922015-01-26 20:15:50 +00004342 if target_branch:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004343 # Canonicalize branch references to the equivalent local full symbolic
wittman@chromium.org455dc922015-01-26 20:15:50 +00004344 # refs, which are then translated into the remote full symbolic refs
4345 # below.
4346 if '/' not in target_branch:
4347 remote_branch = 'refs/remotes/%s/%s' % (remote, target_branch)
4348 else:
4349 prefix_replacements = (
4350 ('^((refs/)?remotes/)?branch-heads/', 'refs/remotes/branch-heads/'),
4351 ('^((refs/)?remotes/)?%s/' % remote, 'refs/remotes/%s/' % remote),
4352 ('^(refs/)?heads/', 'refs/remotes/%s/' % remote),
4353 )
4354 match = None
4355 for regex, replacement in prefix_replacements:
4356 match = re.search(regex, target_branch)
4357 if match:
4358 remote_branch = target_branch.replace(match.group(0), replacement)
4359 break
4360 if not match:
4361 # This is a branch path but not one we recognize; use as-is.
4362 remote_branch = target_branch
rmistry@google.comc68112d2015-03-03 12:48:06 +00004363 elif remote_branch in REFS_THAT_ALIAS_TO_OTHER_REFS:
4364 # Handle the refs that need to land in different refs.
4365 remote_branch = REFS_THAT_ALIAS_TO_OTHER_REFS[remote_branch]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004366
wittman@chromium.org455dc922015-01-26 20:15:50 +00004367 # Create the true path to the remote branch.
4368 # Does the following translation:
4369 # * refs/remotes/origin/refs/diff/test -> refs/diff/test
4370 # * refs/remotes/origin/master -> refs/heads/master
4371 # * refs/remotes/branch-heads/test -> refs/branch-heads/test
4372 if remote_branch.startswith('refs/remotes/%s/refs/' % remote):
4373 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, '')
4374 elif remote_branch.startswith('refs/remotes/%s/' % remote):
4375 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote,
4376 'refs/heads/')
4377 elif remote_branch.startswith('refs/remotes/branch-heads'):
4378 remote_branch = remote_branch.replace('refs/remotes/', 'refs/')
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01004379
wittman@chromium.org455dc922015-01-26 20:15:50 +00004380 return remote_branch
4381
4382
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004383def cleanup_list(l):
4384 """Fixes a list so that comma separated items are put as individual items.
4385
4386 So that "--reviewers joe@c,john@c --reviewers joa@c" results in
4387 options.reviewers == sorted(['joe@c', 'john@c', 'joa@c']).
4388 """
4389 items = sum((i.split(',') for i in l), [])
4390 stripped_items = (i.strip() for i in items)
4391 return sorted(filter(None, stripped_items))
4392
4393
Aaron Gable4db38df2017-11-03 14:59:07 -07004394@subcommand.usage('[flags]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004395@metrics.collector.collect_metrics('git cl upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004396def CMDupload(parser, args):
rmistry@google.com78948ed2015-07-08 23:09:57 +00004397 """Uploads the current changelist to codereview.
4398
4399 Can skip dependency patchset uploads for a branch by running:
4400 git config branch.branch_name.skip-deps-uploads True
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004401 To unset, run:
rmistry@google.com78948ed2015-07-08 23:09:57 +00004402 git config --unset branch.branch_name.skip-deps-uploads
4403 Can also set the above globally by using the --global flag.
Dominic Battre7d1c4842017-10-27 09:17:28 +02004404
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004405 If the name of the checked out branch starts with "bug-" or "fix-" followed
4406 by a bug number, this bug number is automatically populated in the CL
Dominic Battre7d1c4842017-10-27 09:17:28 +02004407 description.
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004408
4409 If subject contains text in square brackets or has "<text>: " prefix, such
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004410 text(s) is treated as Gerrit hashtags. For example, CLs with subjects:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004411 [git-cl] add support for hashtags
4412 Foo bar: implement foo
4413 will be hashtagged with "git-cl" and "foo-bar" respectively.
rmistry@google.com78948ed2015-07-08 23:09:57 +00004414 """
ukai@chromium.orge8077812012-02-03 03:41:46 +00004415 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4416 help='bypass upload presubmit hook')
brettw@chromium.orgb65c43c2013-06-10 22:04:49 +00004417 parser.add_option('--bypass-watchlists', action='store_true',
4418 dest='bypass_watchlists',
4419 help='bypass watchlists auto CC-ing reviewers')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004420 parser.add_option('-f', '--force', action='store_true', dest='force',
ukai@chromium.orge8077812012-02-03 03:41:46 +00004421 help="force yes to questions (don't prompt)")
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004422 parser.add_option('--message', '-m', dest='message',
4423 help='message for patchset')
tandriif9aefb72016-07-01 09:06:51 -07004424 parser.add_option('-b', '--bug',
4425 help='pre-populate the bug number(s) for this issue. '
4426 'If several, separate with commas')
tandriib80458a2016-06-23 12:20:07 -07004427 parser.add_option('--message-file', dest='message_file',
4428 help='file which contains message for patchset')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004429 parser.add_option('--title', '-t', dest='title',
4430 help='title for patchset')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004431 parser.add_option('-r', '--reviewers',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004432 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004433 help='reviewer email addresses')
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004434 parser.add_option('--tbrs',
4435 action='append', default=[],
4436 help='TBR email addresses')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004437 parser.add_option('--cc',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004438 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004439 help='cc email addresses')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004440 parser.add_option('--hashtag', dest='hashtags',
4441 action='append', default=[],
4442 help=('Gerrit hashtag for new CL; '
4443 'can be applied multiple times'))
adamk@chromium.org36f47302013-04-05 01:08:31 +00004444 parser.add_option('-s', '--send-mail', action='store_true',
Aaron Gable59f48512017-01-12 10:54:46 -08004445 help='send email to reviewer(s) and cc(s) immediately')
ukai@chromium.org8ef7ab22012-11-28 04:24:52 +00004446 parser.add_option('--target_branch',
pgervais@chromium.orgb9f27512014-08-08 15:52:33 +00004447 '--target-branch',
wittman@chromium.org455dc922015-01-26 20:15:50 +00004448 metavar='TARGET',
4449 help='Apply CL to remote ref TARGET. ' +
4450 'Default: remote branch head, or master')
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004451 parser.add_option('--squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004452 help='Squash multiple commits into one')
Mike Frysingera989d552019-08-14 20:51:23 +00004453 parser.add_option('--no-squash', action='store_false', dest='squash',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004454 help='Don\'t squash multiple commits into one')
rmistry9eadede2016-09-19 11:22:43 -07004455 parser.add_option('--topic', default=None,
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004456 help='Topic to specify when uploading')
Robert Iannuccif2708bd2017-04-17 15:49:02 -07004457 parser.add_option('--tbr-owners', dest='add_owners_to', action='store_const',
4458 const='TBR', help='add a set of OWNERS to TBR')
4459 parser.add_option('--r-owners', dest='add_owners_to', action='store_const',
4460 const='R', help='add a set of OWNERS to R')
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004461 parser.add_option('-c', '--use-commit-queue', action='store_true',
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004462 default=False,
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004463 help='tell the CQ to commit this patchset; '
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004464 'implies --send-mail')
4465 parser.add_option('-d', '--cq-dry-run',
4466 action='store_true', default=False,
rmistry@google.comef966222015-04-07 11:15:01 +00004467 help='Send the patchset to do a CQ dry run right after '
4468 'upload.')
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00004469 parser.add_option('--preserve-tryjobs', action='store_true',
4470 help='instruct the CQ to let tryjobs running even after '
4471 'new patchsets are uploaded instead of canceling '
4472 'prior patchset\' tryjobs')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004473 parser.add_option('--dependencies', action='store_true',
4474 help='Uploads CLs of all the local branches that depend on '
4475 'the current branch')
Ravi Mistry31e7d562018-04-02 12:53:57 -04004476 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4477 help='Sends your change to the CQ after an approval. Only '
4478 'works on repos that have the Auto-Submit label '
4479 'enabled')
Edward Lesmes8e282792018-04-03 18:50:29 -04004480 parser.add_option('--parallel', action='store_true',
4481 help='Run all tests specified by input_api.RunTests in all '
4482 'PRESUBMIT files in parallel.')
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004483 parser.add_option('--no-autocc', action='store_true',
4484 help='Disables automatic addition of CC emails')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004485 parser.add_option('--private', action='store_true',
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004486 help='Set the review private. This implies --no-autocc.')
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004487 parser.add_option('-R', '--retry-failed', action='store_true',
4488 help='Retry failed tryjobs from old patchset immediately '
4489 'after uploading new patchset. Cannot be used with '
4490 '--use-commit-queue or --cq-dry-run.')
4491 parser.add_option('--buildbucket-host', default='cr-buildbucket.appspot.com',
4492 help='Host of buildbucket. The default host is %default.')
4493 auth.add_auth_options(parser)
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004494
rmistry@google.com2dd99862015-06-22 12:22:18 +00004495 orig_args = args
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004496 _add_codereview_select_options(parser)
ukai@chromium.orge8077812012-02-03 03:41:46 +00004497 (options, args) = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004498 _process_codereview_select_options(parser, options)
ukai@chromium.orge8077812012-02-03 03:41:46 +00004499
sbc@chromium.org71437c02015-04-09 19:29:40 +00004500 if git_common.is_dirty_git_tree('upload'):
ukai@chromium.orge8077812012-02-03 03:41:46 +00004501 return 1
4502
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004503 options.reviewers = cleanup_list(options.reviewers)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004504 options.tbrs = cleanup_list(options.tbrs)
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004505 options.cc = cleanup_list(options.cc)
4506
tandriib80458a2016-06-23 12:20:07 -07004507 if options.message_file:
4508 if options.message:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004509 parser.error('Only one of --message and --message-file allowed.')
tandriib80458a2016-06-23 12:20:07 -07004510 options.message = gclient_utils.FileRead(options.message_file)
4511 options.message_file = None
4512
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004513 if ([options.cq_dry_run,
4514 options.use_commit_queue,
4515 options.retry_failed].count(True) > 1):
4516 parser.error('Only one of --use-commit-queue, --cq-dry-run, or '
4517 '--retry-failed is allowed.')
tandrii4d0545a2016-07-06 03:56:49 -07004518
Aaron Gableedbc4132017-09-11 13:22:28 -07004519 if options.use_commit_queue:
4520 options.send_mail = True
4521
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00004522 # For sanity of test expectations, do this otherwise lazy-loading *now*.
4523 settings.GetIsGerrit()
4524
Edward Lemur934836a2019-09-09 20:16:54 +00004525 cl = Changelist()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004526 if options.retry_failed and not cl.GetIssue():
4527 print('No previous patchsets, so --retry-failed has no effect.')
4528 options.retry_failed = False
4529 # cl.GetMostRecentPatchset uses cached information, and can return the last
4530 # patchset before upload. Calling it here makes it clear that it's the
4531 # last patchset before upload. Note that GetMostRecentPatchset will fail
4532 # if no CL has been uploaded yet.
4533 if options.retry_failed:
4534 patchset = cl.GetMostRecentPatchset()
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00004535
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004536 ret = cl.CMDUpload(options, args, orig_args)
4537
4538 if options.retry_failed:
4539 if ret != 0:
4540 print('Upload failed, so --retry-failed has no effect.')
4541 return ret
4542 auth_config = auth.extract_auth_config_from_options(options)
4543 builds = fetch_try_jobs(
4544 auth_config, cl, options.buildbucket_host, patchset)
4545 buckets = _filter_failed(builds)
4546 if len(buckets) == 0:
4547 print('No failed tryjobs, so --retry-failed has no effect.')
4548 return ret
4549 _trigger_try_jobs(auth_config, cl, buckets, options, patchset + 1)
4550
4551 return ret
ukai@chromium.orge8077812012-02-03 03:41:46 +00004552
4553
Francois Dorayd42c6812017-05-30 15:10:20 -04004554@subcommand.usage('--description=<description file>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004555@metrics.collector.collect_metrics('git cl split')
Francois Dorayd42c6812017-05-30 15:10:20 -04004556def CMDsplit(parser, args):
4557 """Splits a branch into smaller branches and uploads CLs.
4558
4559 Creates a branch and uploads a CL for each group of files modified in the
4560 current branch that share a common OWNERS file. In the CL description and
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004561 comment, the string '$directory', is replaced with the directory containing
Francois Dorayd42c6812017-05-30 15:10:20 -04004562 the shared OWNERS file.
4563 """
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004564 parser.add_option('-d', '--description', dest='description_file',
4565 help='A text file containing a CL description in which '
4566 '$directory will be replaced by each CL\'s directory.')
4567 parser.add_option('-c', '--comment', dest='comment_file',
4568 help='A text file containing a CL comment.')
4569 parser.add_option('-n', '--dry-run', dest='dry_run', action='store_true',
Chris Watkinsba28e462017-12-13 11:22:17 +11004570 default=False,
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004571 help='List the files and reviewers for each CL that would '
4572 'be created, but don\'t create branches or CLs.')
4573 parser.add_option('--cq-dry-run', action='store_true',
4574 help='If set, will do a cq dry run for each uploaded CL. '
4575 'Please be careful when doing this; more than ~10 CLs '
4576 'has the potential to overload our build '
4577 'infrastructure. Try to upload these not during high '
4578 'load times (usually 11-3 Mountain View time). Email '
4579 'infra-dev@chromium.org with any questions.')
Takuto Ikuta51eca592019-02-14 19:40:52 +00004580 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4581 default=True,
4582 help='Sends your change to the CQ after an approval. Only '
4583 'works on repos that have the Auto-Submit label '
4584 'enabled')
Francois Dorayd42c6812017-05-30 15:10:20 -04004585 options, _ = parser.parse_args(args)
4586
4587 if not options.description_file:
4588 parser.error('No --description flag specified.')
4589
4590 def WrappedCMDupload(args):
4591 return CMDupload(OptionParser(), args)
4592
4593 return split_cl.SplitCl(options.description_file, options.comment_file,
Stephen Martiniscb326682018-08-29 21:06:30 +00004594 Changelist, WrappedCMDupload, options.dry_run,
Takuto Ikuta51eca592019-02-14 19:40:52 +00004595 options.cq_dry_run, options.enable_auto_submit)
Francois Dorayd42c6812017-05-30 15:10:20 -04004596
4597
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004598@subcommand.usage('DEPRECATED')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004599@metrics.collector.collect_metrics('git cl commit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004600def CMDdcommit(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004601 """DEPRECATED: Used to commit the current changelist via git-svn."""
4602 message = ('git-cl no longer supports committing to SVN repositories via '
4603 'git-svn. You probably want to use `git cl land` instead.')
4604 print(message)
4605 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004606
4607
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004608@subcommand.usage('[upstream branch to apply against]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004609@metrics.collector.collect_metrics('git cl land')
pgervais@chromium.orgcee6dc42014-05-07 17:04:03 +00004610def CMDland(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004611 """Commits the current changelist via git.
4612
4613 In case of Gerrit, uses Gerrit REST api to "submit" the issue, which pushes
4614 upstream and closes the issue automatically and atomically.
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004615 """
4616 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4617 help='bypass upload presubmit hook')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004618 parser.add_option('-f', '--force', action='store_true', dest='force',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004619 help="force yes to questions (don't prompt)")
Edward Lesmes67b3faa2018-04-13 17:50:52 -04004620 parser.add_option('--parallel', action='store_true',
4621 help='Run all tests specified by input_api.RunTests in all '
4622 'PRESUBMIT files in parallel.')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004623 (options, args) = parser.parse_args(args)
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004624
Edward Lemur934836a2019-09-09 20:16:54 +00004625 cl = Changelist()
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004626
Robert Iannucci2e73d432018-03-14 01:10:47 -07004627 if not cl.GetIssue():
4628 DieWithError('You must upload the change first to Gerrit.\n'
4629 ' If you would rather have `git cl land` upload '
4630 'automatically for you, see http://crbug.com/642759')
Edward Lemur125d60a2019-09-13 18:25:41 +00004631 return cl.CMDLand(options.force, options.bypass_hooks,
Olivier Robin75ee7252018-04-13 10:02:56 +02004632 options.verbose, options.parallel)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004633
4634
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004635@subcommand.usage('<patch url or issue id or issue url>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004636@metrics.collector.collect_metrics('git cl patch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004637def CMDpatch(parser, args):
marq@chromium.orge5e59002013-10-02 23:21:25 +00004638 """Patches in a code review."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004639 parser.add_option('-b', dest='newbranch',
4640 help='create a new branch off trunk for the patch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00004641 parser.add_option('-f', '--force', action='store_true',
Aaron Gable62619a32017-06-16 08:22:09 -07004642 help='overwrite state on the current or chosen branch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004643 parser.add_option('-n', '--no-commit', action='store_true', dest='nocommit',
Edward Lemurf38bc172019-09-03 21:02:13 +00004644 help='don\'t commit after patch applies.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004645
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004646 group = optparse.OptionGroup(
4647 parser,
4648 'Options for continuing work on the current issue uploaded from a '
4649 'different clone (e.g. different machine). Must be used independently '
4650 'from the other options. No issue number should be specified, and the '
4651 'branch must have an issue number associated with it')
4652 group.add_option('--reapply', action='store_true', dest='reapply',
4653 help='Reset the branch and reapply the issue.\n'
4654 'CAUTION: This will undo any local changes in this '
4655 'branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004656
4657 group.add_option('--pull', action='store_true', dest='pull',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004658 help='Performs a pull before reapplying.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004659 parser.add_option_group(group)
4660
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004661 _add_codereview_select_options(parser)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004662 (options, args) = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004663 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004664
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004665 if options.reapply:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004666 if options.newbranch:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004667 parser.error('--reapply works on the current branch only.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004668 if len(args) > 0:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004669 parser.error('--reapply implies no additional arguments.')
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004670
Edward Lemur934836a2019-09-09 20:16:54 +00004671 cl = Changelist()
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004672 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004673 parser.error('Current branch must have an associated issue.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004674
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004675 upstream = cl.GetUpstreamBranch()
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004676 if upstream is None:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004677 parser.error('No upstream branch specified. Cannot reset branch.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004678
4679 RunGit(['reset', '--hard', upstream])
4680 if options.pull:
4681 RunGit(['pull'])
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004682
Edward Lemurf38bc172019-09-03 21:02:13 +00004683 return cl.CMDPatchIssue(cl.GetIssue(), options.nocommit)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004684
4685 if len(args) != 1 or not args[0]:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004686 parser.error('Must specify issue number or URL.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004687
Edward Lemurf38bc172019-09-03 21:02:13 +00004688 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004689 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004690 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004691
4692 cl_kwargs = {
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004693 'codereview_host': target_issue_arg.hostname,
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004694 }
4695 detected_codereview_from_url = False
Edward Lemurf38bc172019-09-03 21:02:13 +00004696 if not args[0].isdigit() and not options.forced_codereview:
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004697 detected_codereview_from_url = True
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004698 cl_kwargs['issue'] = target_issue_arg.issue
4699
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004700 # We don't want uncommitted changes mixed up with the patch.
4701 if git_common.is_dirty_git_tree('patch'):
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004702 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004703
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004704 if options.newbranch:
4705 if options.force:
4706 RunGit(['branch', '-D', options.newbranch],
4707 stderr=subprocess2.PIPE, error_ok=True)
4708 RunGit(['new-branch', options.newbranch])
4709
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004710 cl = Changelist(**cl_kwargs)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004711
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004712 if detected_codereview_from_url:
Edward Lemurf38bc172019-09-03 21:02:13 +00004713 print('canonical issue/change URL: %s\n' % cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004714
Edward Lemurf38bc172019-09-03 21:02:13 +00004715 return cl.CMDPatchWithParsedIssue(
4716 target_issue_arg, options.nocommit, options.force)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004717
4718
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004719def GetTreeStatus(url=None):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004720 """Fetches the tree status and returns either 'open', 'closed',
4721 'unknown' or 'unset'."""
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004722 url = url or settings.GetTreeStatusUrl(error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004723 if url:
4724 status = urllib2.urlopen(url).read().lower()
4725 if status.find('closed') != -1 or status == '0':
4726 return 'closed'
4727 elif status.find('open') != -1 or status == '1':
4728 return 'open'
4729 return 'unknown'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004730 return 'unset'
4731
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004732
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004733def GetTreeStatusReason():
4734 """Fetches the tree status from a json url and returns the message
4735 with the reason for the tree to be opened or closed."""
msb@chromium.orgbf1a7ba2011-02-01 16:21:46 +00004736 url = settings.GetTreeStatusUrl()
4737 json_url = urlparse.urljoin(url, '/current?format=json')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004738 connection = urllib2.urlopen(json_url)
4739 status = json.loads(connection.read())
4740 connection.close()
4741 return status['message']
4742
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004743
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004744@metrics.collector.collect_metrics('git cl tree')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004745def CMDtree(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004746 """Shows the status of the tree."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004747 _, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004748 status = GetTreeStatus()
4749 if 'unset' == status:
vapiera7fbd5a2016-06-16 09:17:49 -07004750 print('You must configure your tree status URL by running "git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004751 return 2
4752
vapiera7fbd5a2016-06-16 09:17:49 -07004753 print('The tree is %s' % status)
4754 print()
4755 print(GetTreeStatusReason())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004756 if status != 'open':
4757 return 1
4758 return 0
4759
4760
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004761@metrics.collector.collect_metrics('git cl try')
maruel@chromium.org15192402012-09-06 12:38:29 +00004762def CMDtry(parser, args):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004763 """Triggers tryjobs using either Buildbucket or CQ dry run."""
4764 group = optparse.OptionGroup(parser, 'Tryjob options')
maruel@chromium.org15192402012-09-06 12:38:29 +00004765 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004766 '-b', '--bot', action='append',
4767 help=('IMPORTANT: specify ONE builder per --bot flag. Use it multiple '
4768 'times to specify multiple builders. ex: '
4769 '"-b win_rel -b win_layout". See '
4770 'the try server waterfall for the builders name and the tests '
4771 'available.'))
maruel@chromium.org15192402012-09-06 12:38:29 +00004772 group.add_option(
borenet6c0efe62016-10-19 08:13:29 -07004773 '-B', '--bucket', default='',
4774 help=('Buildbucket bucket to send the try requests.'))
4775 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004776 '-r', '--revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004777 help='Revision to use for the tryjob; default: the revision will '
tandriif7b29d42016-10-07 08:45:41 -07004778 'be determined by the try recipe that builder runs, which usually '
4779 'defaults to HEAD of origin/master')
maruel@chromium.org15192402012-09-06 12:38:29 +00004780 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004781 '-c', '--clobber', action='store_true', default=False,
tandriif7b29d42016-10-07 08:45:41 -07004782 help='Force a clobber before building; that is don\'t do an '
tandrii1838bad2016-10-06 00:10:52 -07004783 'incremental build')
maruel@chromium.org15192402012-09-06 12:38:29 +00004784 group.add_option(
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08004785 '--category', default='git_cl_try', help='Specify custom build category.')
4786 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004787 '--project',
4788 help='Override which project to use. Projects are defined '
tandriif7b29d42016-10-07 08:45:41 -07004789 'in recipe to determine to which repository or directory to '
4790 'apply the patch')
maruel@chromium.org15192402012-09-06 12:38:29 +00004791 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004792 '-p', '--property', dest='properties', action='append', default=[],
4793 help='Specify generic properties in the form -p key1=value1 -p '
tandriif7b29d42016-10-07 08:45:41 -07004794 'key2=value2 etc. The value will be treated as '
4795 'json if decodable, or as string otherwise. '
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004796 'NOTE: using this may make your tryjob not usable for CQ, '
4797 'which will then schedule another tryjob with default properties')
sheyang@chromium.orgdb375572015-08-17 19:22:23 +00004798 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004799 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4800 help='Host of buildbucket. The default host is %default.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004801 parser.add_option_group(group)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004802 parser.add_option(
4803 '-R', '--retry-failed', action='store_true', default=False,
4804 help='Retry failed jobs from the latest set of tryjobs. '
4805 'Not allowed with --bucket and --bot options.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004806 auth.add_auth_options(parser)
Koji Ishii31c14782018-01-08 17:17:33 +09004807 _add_codereview_issue_select_options(parser)
maruel@chromium.org15192402012-09-06 12:38:29 +00004808 options, args = parser.parse_args(args)
Edward Lemurf38bc172019-09-03 21:02:13 +00004809 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004810 auth_config = auth.extract_auth_config_from_options(options)
maruel@chromium.org15192402012-09-06 12:38:29 +00004811
machenbach@chromium.org45453142015-09-15 08:45:22 +00004812 # Make sure that all properties are prop=value pairs.
4813 bad_params = [x for x in options.properties if '=' not in x]
4814 if bad_params:
4815 parser.error('Got properties with missing "=": %s' % bad_params)
4816
maruel@chromium.org15192402012-09-06 12:38:29 +00004817 if args:
4818 parser.error('Unknown arguments: %s' % args)
4819
Edward Lemur934836a2019-09-09 20:16:54 +00004820 cl = Changelist(issue=options.issue)
maruel@chromium.org15192402012-09-06 12:38:29 +00004821 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004822 parser.error('Need to upload first.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004823
Edward Lemurf38bc172019-09-03 21:02:13 +00004824 # HACK: warm up Gerrit change detail cache to save on RPCs.
Edward Lemur125d60a2019-09-13 18:25:41 +00004825 cl._GetChangeDetail(['DETAILED_ACCOUNTS', 'ALL_REVISIONS'])
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01004826
tandriie113dfd2016-10-11 10:20:12 -07004827 error_message = cl.CannotTriggerTryJobReason()
4828 if error_message:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004829 parser.error('Can\'t trigger tryjobs: %s' % error_message)
jrobbins@chromium.org16f10f72014-06-24 22:14:36 +00004830
Quinten Yearsley983111f2019-09-26 17:18:48 +00004831 if options.retry_failed:
4832 if options.bot or options.bucket:
4833 print('ERROR: The option --retry-failed is not compatible with '
4834 '-B, -b, --bucket, or --bot.', file=sys.stderr)
4835 return 1
4836 print('Searching for failed tryjobs...')
4837 builds, patchset = _fetch_latest_builds(
4838 auth_config, cl, options.buildbucket_host)
4839 if options.verbose:
4840 print('Got %d builds in patchset #%d' % (len(builds), patchset))
4841 buckets = _filter_failed(builds)
4842 if not buckets:
4843 print('There are no failed jobs in the latest set of jobs '
4844 '(patchset #%d), doing nothing.' % patchset)
4845 return 0
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004846 num_builders = sum(map(len, buckets.itervalues()))
Quinten Yearsley983111f2019-09-26 17:18:48 +00004847 if num_builders > 10:
4848 confirm_or_exit('There are %d builders with failed builds.'
4849 % num_builders, action='continue')
4850 else:
4851 buckets = _get_bucket_map(cl, options, parser)
4852 if buckets and any(b.startswith('master.') for b in buckets):
4853 print('ERROR: Buildbot masters are not supported.')
4854 return 1
phajdan.jr@chromium.org8da7f272014-03-14 01:28:39 +00004855
qyearsleydd49f942016-10-28 11:57:22 -07004856 # If no bots are listed and we couldn't get a list based on PRESUBMIT files,
4857 # then we default to triggering a CQ dry run (see http://crbug.com/625697).
qyearsley1fdfcb62016-10-24 13:22:03 -07004858 if not buckets:
qyearsley1fdfcb62016-10-24 13:22:03 -07004859 if options.verbose:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07004860 print('git cl try with no bots now defaults to CQ dry run.')
4861 print('Scheduling CQ dry run on: %s' % cl.GetIssueURL())
4862 return cl.SetCQState(_CQState.DRY_RUN)
stip@chromium.org43064fd2013-12-18 20:07:44 +00004863
borenet6c0efe62016-10-19 08:13:29 -07004864 for builders in buckets.itervalues():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00004865 if any('triggered' in b for b in builders):
vapiera7fbd5a2016-06-16 09:17:49 -07004866 print('ERROR You are trying to send a job to a triggered bot. This type '
tandriide281ae2016-10-12 06:02:30 -07004867 'of bot requires an initial job from a parent (usually a builder). '
4868 'Instead send your job to the parent.\n'
vapiera7fbd5a2016-06-16 09:17:49 -07004869 'Bot list: %s' % builders, file=sys.stderr)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00004870 return 1
ilevy@chromium.orgf3b21232012-09-24 20:48:55 +00004871
ilevy@chromium.org36e420b2013-08-06 23:21:12 +00004872 patchset = cl.GetMostRecentPatchset()
Edward Lemur2c210a42019-09-16 23:58:35 +00004873 try:
4874 _trigger_try_jobs(auth_config, cl, buckets, options, patchset)
4875 except BuildbucketResponseException as ex:
4876 print('ERROR: %s' % ex)
4877 return 1
4878 return 0
maruel@chromium.org15192402012-09-06 12:38:29 +00004879
4880
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004881@metrics.collector.collect_metrics('git cl try-results')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004882def CMDtry_results(parser, args):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00004883 """Prints info about results for tryjobs associated with the current CL."""
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004884 group = optparse.OptionGroup(parser, 'Tryjob results options')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004885 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004886 '-p', '--patchset', type=int, help='patchset number if not current.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004887 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004888 '--print-master', action='store_true', help='print master name as well.')
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +00004889 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004890 '--color', action='store_true', default=setup_color.IS_TTY,
4891 help='force color output, useful when piping output.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004892 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004893 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4894 help='Host of buildbucket. The default host is %default.')
qyearsley53f48a12016-09-01 10:45:13 -07004895 group.add_option(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004896 '--json', help=('Path of JSON output file to write tryjob results to,'
Stefan Zager1306bd02017-06-22 19:26:46 -07004897 'or "-" for stdout.'))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004898 parser.add_option_group(group)
4899 auth.add_auth_options(parser)
Stefan Zager27db3f22017-10-10 15:15:01 -07004900 _add_codereview_issue_select_options(parser)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004901 options, args = parser.parse_args(args)
Edward Lemurf38bc172019-09-03 21:02:13 +00004902 _process_codereview_select_options(parser, options)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004903 if args:
4904 parser.error('Unrecognized args: %s' % ' '.join(args))
4905
4906 auth_config = auth.extract_auth_config_from_options(options)
Edward Lemur934836a2019-09-09 20:16:54 +00004907 cl = Changelist(issue=options.issue)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004908 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004909 parser.error('Need to upload first.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004910
tandrii221ab252016-10-06 08:12:04 -07004911 patchset = options.patchset
4912 if not patchset:
4913 patchset = cl.GetMostRecentPatchset()
4914 if not patchset:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004915 parser.error('Code review host doesn\'t know about issue %s. '
tandrii221ab252016-10-06 08:12:04 -07004916 'No access to issue or wrong issue number?\n'
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004917 'Either upload first, or pass --patchset explicitly.' %
tandrii221ab252016-10-06 08:12:04 -07004918 cl.GetIssue())
4919
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004920 try:
tandrii221ab252016-10-06 08:12:04 -07004921 jobs = fetch_try_jobs(auth_config, cl, options.buildbucket_host, patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004922 except BuildbucketResponseException as ex:
vapiera7fbd5a2016-06-16 09:17:49 -07004923 print('Buildbucket error: %s' % ex)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004924 return 1
qyearsley53f48a12016-09-01 10:45:13 -07004925 if options.json:
4926 write_try_results_json(options.json, jobs)
4927 else:
4928 print_try_jobs(options, jobs)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004929 return 0
4930
4931
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004932@subcommand.usage('[new upstream branch]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004933@metrics.collector.collect_metrics('git cl upstream')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004934def CMDupstream(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004935 """Prints or sets the name of the upstream branch, if any."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004936 _, args = parser.parse_args(args)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004937 if len(args) > 1:
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004938 parser.error('Unrecognized args: %s' % ' '.join(args))
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004939
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004940 cl = Changelist()
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004941 if args:
4942 # One arg means set upstream branch.
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004943 branch = cl.GetBranch()
stip7a3dd352016-09-22 17:32:28 -07004944 RunGit(['branch', '--set-upstream-to', args[0], branch])
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004945 cl = Changelist()
vapiera7fbd5a2016-06-16 09:17:49 -07004946 print('Upstream branch set to %s' % (cl.GetUpstreamBranch(),))
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004947
4948 # Clear configured merge-base, if there is one.
4949 git_common.remove_merge_base(branch)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004950 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004951 print(cl.GetUpstreamBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004952 return 0
4953
4954
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004955@metrics.collector.collect_metrics('git cl web')
thestig@chromium.org00858c82013-12-02 23:08:03 +00004956def CMDweb(parser, args):
4957 """Opens the current CL in the web browser."""
4958 _, args = parser.parse_args(args)
4959 if args:
4960 parser.error('Unrecognized args: %s' % ' '.join(args))
4961
4962 issue_url = Changelist().GetIssueURL()
4963 if not issue_url:
vapiera7fbd5a2016-06-16 09:17:49 -07004964 print('ERROR No issue to open', file=sys.stderr)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004965 return 1
4966
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004967 # Redirect I/O before invoking browser to hide its output. For example, this
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004968 # allows us to hide the "Created new window in existing browser session."
4969 # message from Chrome. Based on https://stackoverflow.com/a/2323563.
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004970 saved_stdout = os.dup(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004971 saved_stderr = os.dup(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004972 os.close(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004973 os.close(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004974 os.open(os.devnull, os.O_RDWR)
4975 try:
4976 webbrowser.open(issue_url)
4977 finally:
4978 os.dup2(saved_stdout, 1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004979 os.dup2(saved_stderr, 2)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004980 return 0
4981
4982
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004983@metrics.collector.collect_metrics('git cl set-commit')
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004984def CMDset_commit(parser, args):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004985 """Sets the commit bit to trigger the CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004986 parser.add_option('-d', '--dry-run', action='store_true',
4987 help='trigger in dry run mode')
4988 parser.add_option('-c', '--clear', action='store_true',
4989 help='stop CQ run, if any')
iannuccie53c9352016-08-17 14:40:40 -07004990 _add_codereview_issue_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004991 options, args = parser.parse_args(args)
Edward Lemurf38bc172019-09-03 21:02:13 +00004992 _process_codereview_select_options(parser, options)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004993 if args:
4994 parser.error('Unrecognized args: %s' % ' '.join(args))
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004995 if options.dry_run and options.clear:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004996 parser.error('Only one of --dry-run and --clear are allowed.')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004997
Edward Lemur934836a2019-09-09 20:16:54 +00004998 cl = Changelist(issue=options.issue)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004999 if options.clear:
tandriid9e5ce52016-07-13 02:32:59 -07005000 state = _CQState.NONE
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005001 elif options.dry_run:
5002 state = _CQState.DRY_RUN
5003 else:
5004 state = _CQState.COMMIT
5005 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005006 parser.error('Must upload the issue first.')
tandrii9de9ec62016-07-13 03:01:59 -07005007 cl.SetCQState(state)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005008 return 0
5009
5010
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005011@metrics.collector.collect_metrics('git cl set-close')
groby@chromium.org411034a2013-02-26 15:12:01 +00005012def CMDset_close(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005013 """Closes the issue."""
iannuccie53c9352016-08-17 14:40:40 -07005014 _add_codereview_issue_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005015 options, args = parser.parse_args(args)
Edward Lemurf38bc172019-09-03 21:02:13 +00005016 _process_codereview_select_options(parser, options)
groby@chromium.org411034a2013-02-26 15:12:01 +00005017 if args:
5018 parser.error('Unrecognized args: %s' % ' '.join(args))
Edward Lemur934836a2019-09-09 20:16:54 +00005019 cl = Changelist(issue=options.issue)
groby@chromium.org411034a2013-02-26 15:12:01 +00005020 # Ensure there actually is an issue to close.
Aaron Gable7139a4e2017-09-05 17:53:09 -07005021 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005022 DieWithError('ERROR: No issue to close.')
groby@chromium.org411034a2013-02-26 15:12:01 +00005023 cl.CloseIssue()
5024 return 0
5025
5026
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005027@metrics.collector.collect_metrics('git cl diff')
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005028def CMDdiff(parser, args):
wychen@chromium.org37b2ec02015-04-03 00:49:15 +00005029 """Shows differences between local tree and last upload."""
thomasanderson074beb22016-08-29 14:03:20 -07005030 parser.add_option(
5031 '--stat',
5032 action='store_true',
5033 dest='stat',
5034 help='Generate a diffstat')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005035 options, args = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005036 if args:
5037 parser.error('Unrecognized args: %s' % ' '.join(args))
wychen@chromium.org46309bf2015-04-03 21:04:49 +00005038
Edward Lemur934836a2019-09-09 20:16:54 +00005039 cl = Changelist()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00005040 issue = cl.GetIssue()
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005041 branch = cl.GetBranch()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00005042 if not issue:
5043 DieWithError('No issue found for current branch (%s)' % branch)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005044
Aaron Gablea718c3e2017-08-28 17:47:28 -07005045 base = cl._GitGetBranchConfigValue('last-upload-hash')
5046 if not base:
5047 base = cl._GitGetBranchConfigValue('gerritsquashhash')
5048 if not base:
5049 detail = cl._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
5050 revision_info = detail['revisions'][detail['current_revision']]
5051 fetch_info = revision_info['fetch']['http']
5052 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
5053 base = 'FETCH_HEAD'
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005054
Aaron Gablea718c3e2017-08-28 17:47:28 -07005055 cmd = ['git', 'diff']
5056 if options.stat:
5057 cmd.append('--stat')
5058 cmd.append(base)
5059 subprocess2.check_call(cmd)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005060
5061 return 0
5062
5063
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005064@metrics.collector.collect_metrics('git cl owners')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005065def CMDowners(parser, args):
Dirk Prankebf980882017-09-02 15:08:00 -07005066 """Finds potential owners for reviewing."""
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005067 parser.add_option(
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00005068 '--ignore-current',
5069 action='store_true',
5070 help='Ignore the CL\'s current reviewers and start from scratch.')
5071 parser.add_option(
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00005072 '--ignore-self',
5073 action='store_true',
5074 help='Do not consider CL\'s author as an owners.')
5075 parser.add_option(
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005076 '--no-color',
5077 action='store_true',
5078 help='Use this option to disable color output')
Dirk Prankebf980882017-09-02 15:08:00 -07005079 parser.add_option(
5080 '--batch',
5081 action='store_true',
5082 help='Do not run interactively, just suggest some')
Yang Guo6e269a02019-06-26 11:17:02 +00005083 # TODO: Consider moving this to another command, since other
5084 # git-cl owners commands deal with owners for a given CL.
5085 parser.add_option(
5086 '--show-all',
5087 action='store_true',
5088 help='Show all owners for a particular file')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005089 options, args = parser.parse_args(args)
5090
5091 author = RunGit(['config', 'user.email']).strip() or None
5092
Edward Lemur934836a2019-09-09 20:16:54 +00005093 cl = Changelist()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005094
Yang Guo6e269a02019-06-26 11:17:02 +00005095 if options.show_all:
5096 for arg in args:
5097 base_branch = cl.GetCommonAncestorWithUpstream()
5098 change = cl.GetChange(base_branch, None)
5099 database = owners.Database(change.RepositoryRoot(), file, os.path)
5100 database.load_data_needed_for([arg])
5101 print('Owners for %s:' % arg)
5102 for owner in sorted(database.all_possible_owners([arg], None)):
5103 print(' - %s' % owner)
5104 return 0
5105
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005106 if args:
5107 if len(args) > 1:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005108 parser.error('Unknown args.')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005109 base_branch = args[0]
5110 else:
5111 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005112 base_branch = cl.GetCommonAncestorWithUpstream()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005113
5114 change = cl.GetChange(base_branch, None)
Dirk Prankebf980882017-09-02 15:08:00 -07005115 affected_files = [f.LocalPath() for f in change.AffectedFiles()]
5116
5117 if options.batch:
5118 db = owners.Database(change.RepositoryRoot(), file, os.path)
5119 print('\n'.join(db.reviewers_for(affected_files, author)))
5120 return 0
5121
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005122 return owners_finder.OwnersFinder(
Dirk Prankebf980882017-09-02 15:08:00 -07005123 affected_files,
Jochen Eisinger72606f82017-04-04 10:44:18 +02005124 change.RepositoryRoot(),
Edward Lemur707d70b2018-02-07 00:50:14 +01005125 author,
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00005126 [] if options.ignore_current else cl.GetReviewers(),
Edward Lemur707d70b2018-02-07 00:50:14 +01005127 fopen=file, os_path=os.path,
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02005128 disable_color=options.no_color,
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00005129 override_files=change.OriginalOwnersFiles(),
5130 ignore_author=options.ignore_self).run()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005131
5132
Aiden Bennerc08566e2018-10-03 17:52:42 +00005133def BuildGitDiffCmd(diff_type, upstream_commit, args, allow_prefix=False):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005134 """Generates a diff command."""
5135 # Generate diff for the current branch's changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +00005136 diff_cmd = ['-c', 'core.quotePath=false', 'diff', '--no-ext-diff']
5137
Aiden Benner6c18a1a2018-11-23 20:18:23 +00005138 if allow_prefix:
5139 # explicitly setting --src-prefix and --dst-prefix is necessary in the
5140 # case that diff.noprefix is set in the user's git config.
5141 diff_cmd += ['--src-prefix=a/', '--dst-prefix=b/']
5142 else:
Aiden Bennerc08566e2018-10-03 17:52:42 +00005143 diff_cmd += ['--no-prefix']
5144
5145 diff_cmd += [diff_type, upstream_commit, '--']
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005146
5147 if args:
5148 for arg in args:
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005149 if os.path.isdir(arg) or os.path.isfile(arg):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005150 diff_cmd.append(arg)
5151 else:
5152 DieWithError('Argument "%s" is not a file or a directory' % arg)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005153
5154 return diff_cmd
5155
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005156
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005157def MatchingFileType(file_name, extensions):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00005158 """Returns True if the file name ends with one of the given extensions."""
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005159 return bool([ext for ext in extensions if file_name.lower().endswith(ext)])
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005160
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005161
enne@chromium.org555cfe42014-01-29 18:21:39 +00005162@subcommand.usage('[files or directories to diff]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005163@metrics.collector.collect_metrics('git cl format')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005164def CMDformat(parser, args):
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005165 """Runs auto-formatting tools (clang-format etc.) on the diff."""
Christopher Lamc5ba6922017-01-24 11:19:14 +11005166 CLANG_EXTS = ['.cc', '.cpp', '.h', '.m', '.mm', '.proto', '.java']
kylechar58edce22016-06-17 06:07:51 -07005167 GN_EXTS = ['.gn', '.gni', '.typemap']
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00005168 parser.add_option('--full', action='store_true',
5169 help='Reformat the full content of all touched files')
5170 parser.add_option('--dry-run', action='store_true',
5171 help='Don\'t modify any file on disk.')
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005172 parser.add_option(
5173 '--python',
5174 action='store_true',
5175 default=None,
5176 help='Enables python formatting on all python files.')
5177 parser.add_option(
5178 '--no-python',
5179 action='store_true',
5180 dest='python',
5181 help='Disables python formatting on all python files. '
5182 'Takes precedence over --python. '
5183 'If neither --python or --no-python are set, python '
5184 'files that have a .style.yapf file in an ancestor '
5185 'directory will be formatted.')
Christopher Lamc5ba6922017-01-24 11:19:14 +11005186 parser.add_option('--js', action='store_true',
5187 help='Format javascript code with clang-format.')
wittman@chromium.org04d5a222014-03-07 18:30:42 +00005188 parser.add_option('--diff', action='store_true',
5189 help='Print diff to stdout rather than modifying files.')
Ilya Shermane081cbe2017-08-15 17:51:04 -07005190 parser.add_option('--presubmit', action='store_true',
5191 help='Used when running the script from a presubmit.')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005192 opts, args = parser.parse_args(args)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005193
Daniel Chengc55eecf2016-12-30 03:11:02 -08005194 # Normalize any remaining args against the current path, so paths relative to
5195 # the current directory are still resolved as expected.
5196 args = [os.path.join(os.getcwd(), arg) for arg in args]
5197
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005198 # git diff generates paths against the root of the repository. Change
5199 # to that directory so clang-format can find files even within subdirs.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005200 rel_base_path = settings.GetRelativeRoot()
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005201 if rel_base_path:
5202 os.chdir(rel_base_path)
5203
digit@chromium.org29e47272013-05-17 17:01:46 +00005204 # Grab the merge-base commit, i.e. the upstream commit of the current
5205 # branch when it was created or the last time it was rebased. This is
5206 # to cover the case where the user may have called "git fetch origin",
5207 # moving the origin branch to a newer commit, but hasn't rebased yet.
5208 upstream_commit = None
5209 cl = Changelist()
5210 upstream_branch = cl.GetUpstreamBranch()
5211 if upstream_branch:
5212 upstream_commit = RunGit(['merge-base', 'HEAD', upstream_branch])
5213 upstream_commit = upstream_commit.strip()
5214
5215 if not upstream_commit:
5216 DieWithError('Could not find base commit for this branch. '
5217 'Are you in detached state?')
5218
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005219 changed_files_cmd = BuildGitDiffCmd('--name-only', upstream_commit, args)
5220 diff_output = RunGit(changed_files_cmd)
5221 diff_files = diff_output.splitlines()
jkarlin@chromium.orgad21b922016-01-28 17:48:42 +00005222 # Filter out files deleted by this CL
5223 diff_files = [x for x in diff_files if os.path.isfile(x)]
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005224
Christopher Lamc5ba6922017-01-24 11:19:14 +11005225 if opts.js:
Deepanjan Roy605dd312018-07-02 17:48:54 +00005226 CLANG_EXTS.extend(['.js', '.ts'])
Christopher Lamc5ba6922017-01-24 11:19:14 +11005227
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005228 clang_diff_files = [x for x in diff_files if MatchingFileType(x, CLANG_EXTS)]
5229 python_diff_files = [x for x in diff_files if MatchingFileType(x, ['.py'])]
5230 dart_diff_files = [x for x in diff_files if MatchingFileType(x, ['.dart'])]
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005231 gn_diff_files = [x for x in diff_files if MatchingFileType(x, GN_EXTS)]
digit@chromium.org29e47272013-05-17 17:01:46 +00005232
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +00005233 top_dir = os.path.normpath(
5234 RunGit(["rev-parse", "--show-toplevel"]).rstrip('\n'))
5235
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005236 # Set to 2 to signal to CheckPatchFormatted() that this patch isn't
5237 # formatted. This is used to block during the presubmit.
5238 return_value = 0
5239
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005240 if clang_diff_files:
techtonik@gmail.com5573df12016-04-12 18:34:10 +00005241 # Locate the clang-format binary in the checkout
5242 try:
5243 clang_format_tool = clang_format.FindClangFormatToolInChromiumTree()
vapierfd77ac72016-06-16 08:33:57 -07005244 except clang_format.NotFoundError as e:
techtonik@gmail.com5573df12016-04-12 18:34:10 +00005245 DieWithError(e)
5246
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005247 if opts.full:
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005248 cmd = [clang_format_tool]
5249 if not opts.dry_run and not opts.diff:
5250 cmd.append('-i')
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005251 stdout = RunCommand(cmd + clang_diff_files, cwd=top_dir)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005252 if opts.diff:
5253 sys.stdout.write(stdout)
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005254 else:
5255 env = os.environ.copy()
5256 env['PATH'] = str(os.path.dirname(clang_format_tool))
5257 try:
5258 script = clang_format.FindClangFormatScriptInChromiumTree(
5259 'clang-format-diff.py')
vapierfd77ac72016-06-16 08:33:57 -07005260 except clang_format.NotFoundError as e:
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005261 DieWithError(e)
digit@chromium.orgd6ddc1c2013-10-25 15:36:32 +00005262
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005263 cmd = [sys.executable, script, '-p0']
5264 if not opts.dry_run and not opts.diff:
5265 cmd.append('-i')
digit@chromium.orgd6ddc1c2013-10-25 15:36:32 +00005266
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005267 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, clang_diff_files)
5268 diff_output = RunGit(diff_cmd)
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005269
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005270 stdout = RunCommand(cmd, stdin=diff_output, cwd=top_dir, env=env)
5271 if opts.diff:
5272 sys.stdout.write(stdout)
5273 if opts.dry_run and len(stdout) > 0:
5274 return_value = 2
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005275
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005276 # Similar code to above, but using yapf on .py files rather than clang-format
5277 # on C/C++ files
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005278 py_explicitly_disabled = opts.python is not None and not opts.python
5279 if python_diff_files and not py_explicitly_disabled:
Aiden Bennere47ac152018-11-20 16:44:03 +00005280 depot_tools_path = os.path.dirname(os.path.abspath(__file__))
5281 yapf_tool = os.path.join(depot_tools_path, 'yapf')
5282 if sys.platform.startswith('win'):
5283 yapf_tool += '.bat'
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005284
Aiden Bennerc08566e2018-10-03 17:52:42 +00005285 # If we couldn't find a yapf file we'll default to the chromium style
5286 # specified in depot_tools.
Aiden Bennerc08566e2018-10-03 17:52:42 +00005287 chromium_default_yapf_style = os.path.join(depot_tools_path,
5288 YAPF_CONFIG_FILENAME)
Aiden Bennerc08566e2018-10-03 17:52:42 +00005289 # Used for caching.
5290 yapf_configs = {}
5291 for f in python_diff_files:
5292 # Find the yapf style config for the current file, defaults to depot
5293 # tools default.
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005294 _FindYapfConfigFile(f, yapf_configs, top_dir)
5295
5296 # Turn on python formatting by default if a yapf config is specified.
5297 # This breaks in the case of this repo though since the specified
5298 # style file is also the global default.
5299 if opts.python is None:
5300 filtered_py_files = []
5301 for f in python_diff_files:
5302 if _FindYapfConfigFile(f, yapf_configs, top_dir) is not None:
5303 filtered_py_files.append(f)
5304 else:
5305 filtered_py_files = python_diff_files
5306
5307 # Note: yapf still seems to fix indentation of the entire file
5308 # even if line ranges are specified.
5309 # See https://github.com/google/yapf/issues/499
5310 if not opts.full and filtered_py_files:
5311 py_line_diffs = _ComputeDiffLineRanges(filtered_py_files, upstream_commit)
5312
5313 for f in filtered_py_files:
5314 yapf_config = _FindYapfConfigFile(f, yapf_configs, top_dir)
5315 if yapf_config is None:
5316 yapf_config = chromium_default_yapf_style
Aiden Bennerc08566e2018-10-03 17:52:42 +00005317
5318 cmd = [yapf_tool, '--style', yapf_config, f]
5319
5320 has_formattable_lines = False
5321 if not opts.full:
5322 # Only run yapf over changed line ranges.
5323 for diff_start, diff_len in py_line_diffs[f]:
5324 diff_end = diff_start + diff_len - 1
5325 # Yapf errors out if diff_end < diff_start but this
5326 # is a valid line range diff for a removal.
5327 if diff_end >= diff_start:
5328 has_formattable_lines = True
5329 cmd += ['-l', '{}-{}'.format(diff_start, diff_end)]
5330 # If all line diffs were removals we have nothing to format.
5331 if not has_formattable_lines:
5332 continue
5333
5334 if opts.diff or opts.dry_run:
5335 cmd += ['--diff']
5336 # Will return non-zero exit code if non-empty diff.
5337 stdout = RunCommand(cmd, error_ok=True, cwd=top_dir)
5338 if opts.diff:
5339 sys.stdout.write(stdout)
5340 elif len(stdout) > 0:
5341 return_value = 2
5342 else:
5343 cmd += ['-i']
5344 RunCommand(cmd, cwd=top_dir)
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005345
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005346 # Dart's formatter does not have the nice property of only operating on
5347 # modified chunks, so hard code full.
5348 if dart_diff_files:
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005349 try:
5350 command = [dart_format.FindDartFmtToolInChromiumTree()]
5351 if not opts.dry_run and not opts.diff:
5352 command.append('-w')
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005353 command.extend(dart_diff_files)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005354
ppi@chromium.org6593d932016-03-03 15:41:15 +00005355 stdout = RunCommand(command, cwd=top_dir)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005356 if opts.dry_run and stdout:
5357 return_value = 2
5358 except dart_format.NotFoundError as e:
vapiera7fbd5a2016-06-16 09:17:49 -07005359 print('Warning: Unable to check Dart code formatting. Dart SDK not '
5360 'found in this checkout. Files in other languages are still '
5361 'formatted.')
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005362
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005363 # Format GN build files. Always run on full build files for canonical form.
5364 if gn_diff_files:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005365 cmd = ['gn', 'format']
brettw4b8ed592016-08-05 16:19:12 -07005366 if opts.dry_run or opts.diff:
5367 cmd.append('--dry-run')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005368 for gn_diff_file in gn_diff_files:
brettw4b8ed592016-08-05 16:19:12 -07005369 gn_ret = subprocess2.call(cmd + [gn_diff_file],
5370 shell=sys.platform == 'win32',
5371 cwd=top_dir)
5372 if opts.dry_run and gn_ret == 2:
5373 return_value = 2 # Not formatted.
5374 elif opts.diff and gn_ret == 2:
5375 # TODO this should compute and print the actual diff.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005376 print('This change has GN build file diff for ' + gn_diff_file)
brettw4b8ed592016-08-05 16:19:12 -07005377 elif gn_ret != 0:
5378 # For non-dry run cases (and non-2 return values for dry-run), a
5379 # nonzero error code indicates a failure, probably because the file
5380 # doesn't parse.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005381 DieWithError('gn format failed on ' + gn_diff_file +
5382 '\nTry running `gn format` on this file manually.')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005383
Ilya Shermane081cbe2017-08-15 17:51:04 -07005384 # Skip the metrics formatting from the global presubmit hook. These files have
5385 # a separate presubmit hook that issues an error if the files need formatting,
5386 # whereas the top-level presubmit script merely issues a warning. Formatting
5387 # these files is somewhat slow, so it's important not to duplicate the work.
5388 if not opts.presubmit:
5389 for xml_dir in GetDirtyMetricsDirs(diff_files):
5390 tool_dir = os.path.join(top_dir, xml_dir)
5391 cmd = [os.path.join(tool_dir, 'pretty_print.py'), '--non-interactive']
5392 if opts.dry_run or opts.diff:
5393 cmd.append('--diff')
Ilya Sherman235b70d2017-08-22 17:46:38 -07005394 stdout = RunCommand(cmd, cwd=top_dir)
Ilya Shermane081cbe2017-08-15 17:51:04 -07005395 if opts.diff:
5396 sys.stdout.write(stdout)
5397 if opts.dry_run and stdout:
5398 return_value = 2 # Not formatted.
Alexei Svitkinef3cac412017-02-06 11:08:50 -05005399
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005400 return return_value
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005401
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005402
Steven Holte2e664bf2017-04-21 13:10:47 -07005403def GetDirtyMetricsDirs(diff_files):
5404 xml_diff_files = [x for x in diff_files if MatchingFileType(x, ['.xml'])]
5405 metrics_xml_dirs = [
5406 os.path.join('tools', 'metrics', 'actions'),
5407 os.path.join('tools', 'metrics', 'histograms'),
5408 os.path.join('tools', 'metrics', 'rappor'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005409 os.path.join('tools', 'metrics', 'ukm'),
5410 ]
Steven Holte2e664bf2017-04-21 13:10:47 -07005411 for xml_dir in metrics_xml_dirs:
5412 if any(file.startswith(xml_dir) for file in xml_diff_files):
5413 yield xml_dir
5414
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005415
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005416@subcommand.usage('<codereview url or issue id>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005417@metrics.collector.collect_metrics('git cl checkout')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005418def CMDcheckout(parser, args):
Edward Lemurf38bc172019-09-03 21:02:13 +00005419 """Checks out a branch associated with a given Gerrit issue."""
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005420 _, args = parser.parse_args(args)
5421
5422 if len(args) != 1:
5423 parser.print_help()
5424 return 1
5425
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005426 issue_arg = ParseIssueNumberArgument(args[0])
tandrii@chromium.orgde6c9a12016-04-11 15:33:53 +00005427 if not issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005428 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005429
tandrii@chromium.orgabd27e52016-04-11 15:43:32 +00005430 target_issue = str(issue_arg.issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005431
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005432 def find_issues(issueprefix):
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00005433 output = RunGit(['config', '--local', '--get-regexp',
5434 r'branch\..*\.%s' % issueprefix],
5435 error_ok=True)
5436 for key, issue in [x.split() for x in output.splitlines()]:
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005437 if issue == target_issue:
5438 yield re.sub(r'branch\.(.*)\.%s' % issueprefix, r'\1', key)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005439
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005440 branches = []
5441 for cls in _CODEREVIEW_IMPLEMENTATIONS.values():
tandrii5d48c322016-08-18 16:19:37 -07005442 branches.extend(find_issues(cls.IssueConfigKey()))
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005443 if len(branches) == 0:
vapiera7fbd5a2016-06-16 09:17:49 -07005444 print('No branch found for issue %s.' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005445 return 1
5446 if len(branches) == 1:
5447 RunGit(['checkout', branches[0]])
5448 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005449 print('Multiple branches match issue %s:' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005450 for i in range(len(branches)):
vapiera7fbd5a2016-06-16 09:17:49 -07005451 print('%d: %s' % (i, branches[i]))
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005452 which = raw_input('Choose by index: ')
5453 try:
5454 RunGit(['checkout', branches[int(which)]])
5455 except (IndexError, ValueError):
vapiera7fbd5a2016-06-16 09:17:49 -07005456 print('Invalid selection, not checking out any branch.')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005457 return 1
5458
5459 return 0
5460
5461
maruel@chromium.org29404b52014-09-08 22:58:00 +00005462def CMDlol(parser, args):
5463 # This command is intentionally undocumented.
vapiera7fbd5a2016-06-16 09:17:49 -07005464 print(zlib.decompress(base64.b64decode(
thakis@chromium.org3421c992014-11-02 02:20:32 +00005465 'eNptkLEOwyAMRHe+wupCIqW57v0Vq84WqWtXyrcXnCBsmgMJ+/SSAxMZgRB6NzE'
5466 'E2ObgCKJooYdu4uAQVffUEoE1sRQLxAcqzd7uK2gmStrll1ucV3uZyaY5sXyDd9'
5467 'JAnN+lAXsOMJ90GANAi43mq5/VeeacylKVgi8o6F1SC63FxnagHfJUTfUYdCR/W'
vapiera7fbd5a2016-06-16 09:17:49 -07005468 'Ofe+0dHL7PicpytKP750Fh1q2qnLVof4w8OZWNY')))
maruel@chromium.org29404b52014-09-08 22:58:00 +00005469 return 0
5470
5471
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005472class OptionParser(optparse.OptionParser):
5473 """Creates the option parse and add --verbose support."""
5474 def __init__(self, *args, **kwargs):
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005475 optparse.OptionParser.__init__(
5476 self, *args, prog='git cl', version=__version__, **kwargs)
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005477 self.add_option(
5478 '-v', '--verbose', action='count', default=0,
5479 help='Use 2 times for more debugging info')
5480
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005481 def parse_args(self, args=None, _values=None):
Andrii Shyshkalov46f20cd2018-10-30 06:42:54 +00005482 try:
5483 return self._parse_args(args)
5484 finally:
5485 # Regardless of success or failure of args parsing, we want to report
5486 # metrics, but only after logging has been initialized (if parsing
5487 # succeeded).
5488 global settings
5489 settings = Settings()
5490
5491 if not metrics.DISABLE_METRICS_COLLECTION:
5492 # GetViewVCUrl ultimately calls logging method.
5493 project_url = settings.GetViewVCUrl().strip('/+')
5494 if project_url in metrics_utils.KNOWN_PROJECT_URLS:
5495 metrics.collector.add('project_urls', [project_url])
5496
5497 def _parse_args(self, args=None):
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005498 # Create an optparse.Values object that will store only the actual passed
5499 # options, without the defaults.
5500 actual_options = optparse.Values()
5501 _, args = optparse.OptionParser.parse_args(self, args, actual_options)
5502 # Create an optparse.Values object with the default options.
5503 options = optparse.Values(self.get_default_values().__dict__)
5504 # Update it with the options passed by the user.
5505 options._update_careful(actual_options.__dict__)
5506 # Store the options passed by the user in an _actual_options attribute.
5507 # We store only the keys, and not the values, since the values can contain
5508 # arbitrary information, which might be PII.
5509 metrics.collector.add('arguments', actual_options.__dict__.keys())
5510
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005511 levels = [logging.WARNING, logging.INFO, logging.DEBUG]
Andrii Shyshkalov5b04a572017-01-23 17:44:41 +01005512 logging.basicConfig(
5513 level=levels[min(options.verbose, len(levels) - 1)],
5514 format='[%(levelname).1s%(asctime)s %(process)d %(thread)d '
5515 '%(filename)s] %(message)s')
Edward Lemur83bd7f42018-10-10 00:14:21 +00005516
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005517 return options, args
5518
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005519
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005520def main(argv):
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005521 if sys.hexversion < 0x02060000:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005522 print('\nYour Python version %s is unsupported, please upgrade.\n' %
vapiera7fbd5a2016-06-16 09:17:49 -07005523 (sys.version.split(' ', 1)[0],), file=sys.stderr)
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005524 return 2
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00005525
maruel@chromium.org39c0b222013-08-17 16:57:01 +00005526 colorize_CMDstatus_doc()
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005527 dispatcher = subcommand.CommandDispatcher(__name__)
5528 try:
5529 return dispatcher.execute(OptionParser(), argv)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +00005530 except auth.AuthenticationError as e:
5531 DieWithError(str(e))
vapierfd77ac72016-06-16 08:33:57 -07005532 except urllib2.HTTPError as e:
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005533 if e.code != 500:
5534 raise
5535 DieWithError(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005536 ('App Engine is misbehaving and returned HTTP %d, again. Keep faith '
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005537 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
sbc@chromium.org013731e2015-02-26 18:28:43 +00005538 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005539
5540
5541if __name__ == '__main__':
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005542 # These affect sys.stdout, so do it outside of main() to simplify mocks in
5543 # the unit tests.
maruel@chromium.org6f09cd92011-04-01 16:38:12 +00005544 fix_encoding.fix_encoding()
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00005545 setup_color.init()
Edward Lemur6f812e12018-07-31 22:45:57 +00005546 with metrics.collector.print_notice_and_exit():
sbc@chromium.org013731e2015-02-26 18:28:43 +00005547 sys.exit(main(sys.argv[1:]))