blob: f4eb62b6d7a6e18db643b78c27cd3d31dfb40a05 [file] [log] [blame]
Edward Lemur1f3bafb2019-10-08 17:56:33 +00001#!/usr/bin/env vpython
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02002# Copyright (c) 2013 The Chromium Authors. All rights reserved.
maruel@chromium.org725f1c32011-04-01 20:24:54 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006# Copyright (C) 2008 Evan Martin <martine@danga.com>
7
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00008"""A git-command for integrating reviews on Gerrit."""
maruel@chromium.org725f1c32011-04-01 20:24:54 +00009
vapiera7fbd5a2016-06-16 09:17:49 -070010from __future__ import print_function
11
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +000012from distutils.version import LooseVersion
calamity@chromium.orgffde55c2015-03-12 00:44:17 +000013from multiprocessing.pool import ThreadPool
thakis@chromium.org3421c992014-11-02 02:20:32 +000014import base64
rmistry@google.com2dd99862015-06-22 12:22:18 +000015import collections
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010016import datetime
Brian Sheedyb4307d52019-12-02 19:18:17 +000017import fnmatch
Edward Lemur202c5592019-10-21 22:44:52 +000018import httplib2
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +010019import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000020import json
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000021import logging
calamity@chromium.orgcf197482016-04-29 20:15:53 +000022import multiprocessing
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000023import optparse
24import os
25import re
Andrii Shyshkalov353637c2017-03-14 16:52:18 +010026import shutil
ukai@chromium.org78c4b982012-02-14 02:20:26 +000027import stat
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000028import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070029import tempfile
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000030import textwrap
Edward Lemurfec80c42018-11-01 23:14:14 +000031import time
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000032import uuid
thestig@chromium.org00858c82013-12-02 23:08:03 +000033import webbrowser
thakis@chromium.org3421c992014-11-02 02:20:32 +000034import zlib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000035
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000036from third_party import colorama
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000037import auth
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +000038import clang_format
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +000039import dart_format
maruel@chromium.org6f09cd92011-04-01 16:38:12 +000040import fix_encoding
maruel@chromium.org0e0436a2011-10-25 13:32:41 +000041import gclient_utils
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +000042import gerrit_util
iannucci@chromium.org9e849272014-04-04 00:31:55 +000043import git_common
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +000044import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000045import git_new_branch
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000046import metrics
Edward Lesmes93277a72018-10-18 22:04:26 +000047import metrics_utils
piman@chromium.org336f9122014-09-04 02:16:55 +000048import owners
iannucci@chromium.org9e849272014-04-04 00:31:55 +000049import owners_finder
maruel@chromium.org2a74d372011-03-29 19:05:50 +000050import presubmit_support
51import scm
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000052import setup_color
Francois Dorayd42c6812017-05-30 15:10:20 -040053import split_cl
maruel@chromium.org0633fb42013-08-16 20:06:14 +000054import subcommand
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +000055import subprocess2
maruel@chromium.org2a74d372011-03-29 19:05:50 +000056import watchlists
57
Edward Lemur79d4f992019-11-11 23:49:02 +000058from third_party import six
59from six.moves import urllib
60
61
62if sys.version_info.major == 3:
63 basestring = (str,) # pylint: disable=redefined-builtin
64
Edward Lemurb9830242019-10-30 22:19:20 +000065
tandrii7400cf02016-06-21 08:48:07 -070066__version__ = '2.0'
maruel@chromium.org2a74d372011-03-29 19:05:50 +000067
Edward Lemur0f58ae42019-04-30 17:24:12 +000068# Traces for git push will be stored in a traces directory inside the
69# depot_tools checkout.
70DEPOT_TOOLS = os.path.dirname(os.path.abspath(__file__))
71TRACES_DIR = os.path.join(DEPOT_TOOLS, 'traces')
72
73# When collecting traces, Git hashes will be reduced to 6 characters to reduce
74# the size after compression.
75GIT_HASH_RE = re.compile(r'\b([a-f0-9]{6})[a-f0-9]{34}\b', flags=re.I)
76# Used to redact the cookies from the gitcookies file.
77GITCOOKIES_REDACT_RE = re.compile(r'1/.*')
78
Edward Lemurd4d1ba42019-09-20 21:46:37 +000079MAX_ATTEMPTS = 3
80
Edward Lemur1b52d872019-05-09 21:12:12 +000081# The maximum number of traces we will keep. Multiplied by 3 since we store
82# 3 files per trace.
83MAX_TRACES = 3 * 10
Edward Lemur5737f022019-05-17 01:24:00 +000084# Message to be displayed to the user to inform where to find the traces for a
85# git-cl upload execution.
Edward Lemur0f58ae42019-04-30 17:24:12 +000086TRACES_MESSAGE = (
Edward Lemur1b52d872019-05-09 21:12:12 +000087'\n'
Edward Lemur5737f022019-05-17 01:24:00 +000088'The traces of this git-cl execution have been recorded at:\n'
Edward Lemur1b52d872019-05-09 21:12:12 +000089' %(trace_name)s-traces.zip\n'
Edward Lemur5737f022019-05-17 01:24:00 +000090'Copies of your gitcookies file and git config have been recorded at:\n'
91' %(trace_name)s-git-info.zip\n')
Edward Lemur1b52d872019-05-09 21:12:12 +000092# Format of the message to be stored as part of the traces to give developers a
93# better context when they go through traces.
94TRACES_README_FORMAT = (
95'Date: %(now)s\n'
96'\n'
97'Change: https://%(gerrit_host)s/q/%(change_id)s\n'
98'Title: %(title)s\n'
99'\n'
100'%(description)s\n'
101'\n'
102'Execution time: %(execution_time)s\n'
103'Exit code: %(exit_code)s\n') + TRACES_MESSAGE
Edward Lemur0f58ae42019-04-30 17:24:12 +0000104
tandrii9d2c7a32016-06-22 03:42:45 -0700105COMMIT_BOT_EMAIL = 'commit-bot@chromium.org'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -0800106POSTUPSTREAM_HOOK = '.git/hooks/post-cl-land'
Henrique Ferreiroff249622019-11-28 23:19:29 +0000107DESCRIPTION_BACKUP_FILE = '.git_cl_description_backup'
rmistry@google.comc68112d2015-03-03 12:48:06 +0000108REFS_THAT_ALIAS_TO_OTHER_REFS = {
109 'refs/remotes/origin/lkgr': 'refs/remotes/origin/master',
110 'refs/remotes/origin/lkcr': 'refs/remotes/origin/master',
111}
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000112
thestig@chromium.org44202a22014-03-11 19:22:18 +0000113# Valid extensions for files we want to lint.
114DEFAULT_LINT_REGEX = r"(.*\.cpp|.*\.cc|.*\.h)"
115DEFAULT_LINT_IGNORE_REGEX = r"$^"
116
Aiden Bennerc08566e2018-10-03 17:52:42 +0000117# File name for yapf style config files.
118YAPF_CONFIG_FILENAME = '.style.yapf'
119
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000120# Shortcut since it quickly becomes repetitive.
maruel@chromium.org2e23ce32013-05-07 12:42:28 +0000121Fore = colorama.Fore
maruel@chromium.org90541732011-04-01 17:54:18 +0000122
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000123# Initialized in main()
124settings = None
125
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100126# Used by tests/git_cl_test.py to add extra logging.
127# Inside the weirdly failing test, add this:
128# >>> self.mock(git_cl, '_IS_BEING_TESTED', True)
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700129# And scroll up to see the stack trace printed.
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100130_IS_BEING_TESTED = False
131
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000132
Christopher Lamf732cd52017-01-24 12:40:11 +1100133def DieWithError(message, change_desc=None):
134 if change_desc:
135 SaveDescriptionBackup(change_desc)
136
vapiera7fbd5a2016-06-16 09:17:49 -0700137 print(message, file=sys.stderr)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000138 sys.exit(1)
139
140
Christopher Lamf732cd52017-01-24 12:40:11 +1100141def SaveDescriptionBackup(change_desc):
Henrique Ferreiro5ae48172019-11-29 16:14:42 +0000142 backup_path = os.path.join(DEPOT_TOOLS, DESCRIPTION_BACKUP_FILE)
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000143 print('\nsaving CL description to %s\n' % backup_path)
Josip906bfde2020-01-31 22:38:49 +0000144 with open(backup_path, 'w') as backup_file:
145 backup_file.write(change_desc.description)
Christopher Lamf732cd52017-01-24 12:40:11 +1100146
147
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000148def GetNoGitPagerEnv():
149 env = os.environ.copy()
150 # 'cat' is a magical git string that disables pagers on all platforms.
151 env['GIT_PAGER'] = 'cat'
152 return env
153
vadimsh@chromium.org566a02a2014-08-22 01:34:13 +0000154
bsep@chromium.org627d9002016-04-29 00:00:52 +0000155def RunCommand(args, error_ok=False, error_message=None, shell=False, **kwargs):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000156 try:
Edward Lemur79d4f992019-11-11 23:49:02 +0000157 stdout = subprocess2.check_output(args, shell=shell, **kwargs)
158 return stdout.decode('utf-8', 'replace')
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000159 except subprocess2.CalledProcessError as e:
160 logging.debug('Failed running %s', args)
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000161 if not error_ok:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000162 DieWithError(
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000163 'Command "%s" failed.\n%s' % (
164 ' '.join(args), error_message or e.stdout or ''))
Edward Lemur79d4f992019-11-11 23:49:02 +0000165 return e.stdout.decode('utf-8', 'replace')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000166
167
168def RunGit(args, **kwargs):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000169 """Returns stdout."""
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000170 return RunCommand(['git'] + args, **kwargs)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000171
172
enne@chromium.org3b7e15c2014-01-21 17:44:47 +0000173def RunGitWithCode(args, suppress_stderr=False):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000174 """Returns return code and stdout."""
tandrii5d48c322016-08-18 16:19:37 -0700175 if suppress_stderr:
176 stderr = subprocess2.VOID
177 else:
178 stderr = sys.stderr
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000179 try:
tandrii5d48c322016-08-18 16:19:37 -0700180 (out, _), code = subprocess2.communicate(['git'] + args,
181 env=GetNoGitPagerEnv(),
182 stdout=subprocess2.PIPE,
183 stderr=stderr)
Edward Lemur79d4f992019-11-11 23:49:02 +0000184 return code, out.decode('utf-8', 'replace')
tandrii5d48c322016-08-18 16:19:37 -0700185 except subprocess2.CalledProcessError as e:
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +0900186 logging.debug('Failed running %s', ['git'] + args)
Edward Lemur79d4f992019-11-11 23:49:02 +0000187 return e.returncode, e.stdout.decode('utf-8', 'replace')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000188
189
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000190def RunGitSilent(args):
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000191 """Returns stdout, suppresses stderr and ignores the return code."""
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000192 return RunGitWithCode(args, suppress_stderr=True)[1]
193
194
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000195def IsGitVersionAtLeast(min_version):
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000196 prefix = 'git version '
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000197 version = RunGit(['--version']).strip()
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000198 return (version.startswith(prefix) and
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000199 LooseVersion(version[len(prefix):]) >= LooseVersion(min_version))
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000200
201
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000202def BranchExists(branch):
203 """Return True if specified branch exists."""
204 code, _ = RunGitWithCode(['rev-parse', '--verify', branch],
205 suppress_stderr=True)
206 return not code
207
208
tandrii2a16b952016-10-19 07:09:44 -0700209def time_sleep(seconds):
210 # Use this so that it can be mocked in tests without interfering with python
211 # system machinery.
tandrii2a16b952016-10-19 07:09:44 -0700212 return time.sleep(seconds)
213
214
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000215def time_time():
216 # Use this so that it can be mocked in tests without interfering with python
217 # system machinery.
218 return time.time()
219
220
Edward Lemur1b52d872019-05-09 21:12:12 +0000221def datetime_now():
222 # Use this so that it can be mocked in tests without interfering with python
223 # system machinery.
224 return datetime.datetime.now()
225
226
maruel@chromium.org90541732011-04-01 17:54:18 +0000227def ask_for_data(prompt):
228 try:
229 return raw_input(prompt)
230 except KeyboardInterrupt:
231 # Hide the exception.
232 sys.exit(1)
233
234
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100235def confirm_or_exit(prefix='', action='confirm'):
236 """Asks user to press enter to continue or press Ctrl+C to abort."""
237 if not prefix or prefix.endswith('\n'):
238 mid = 'Press'
Andrii Shyshkalov353637c2017-03-14 16:52:18 +0100239 elif prefix.endswith('.') or prefix.endswith('?'):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100240 mid = ' Press'
241 elif prefix.endswith(' '):
242 mid = 'press'
243 else:
244 mid = ' press'
245 ask_for_data('%s%s Enter to %s, or Ctrl+C to abort' % (prefix, mid, action))
246
247
248def ask_for_explicit_yes(prompt):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000249 """Returns whether user typed 'y' or 'yes' to confirm the given prompt."""
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100250 result = ask_for_data(prompt + ' [Yes/No]: ').lower()
251 while True:
252 if 'yes'.startswith(result):
253 return True
254 if 'no'.startswith(result):
255 return False
256 result = ask_for_data('Please, type yes or no: ').lower()
257
258
tandrii5d48c322016-08-18 16:19:37 -0700259def _git_branch_config_key(branch, key):
260 """Helper method to return Git config key for a branch."""
261 assert branch, 'branch name is required to set git config for it'
262 return 'branch.%s.%s' % (branch, key)
263
264
machenbach@chromium.org45453142015-09-15 08:45:22 +0000265def _get_properties_from_options(options):
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000266 prop_list = getattr(options, 'properties', [])
267 properties = dict(x.split('=', 1) for x in prop_list)
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000268 for key, val in properties.items():
machenbach@chromium.org45453142015-09-15 08:45:22 +0000269 try:
270 properties[key] = json.loads(val)
271 except ValueError:
272 pass # If a value couldn't be evaluated, treat it as a string.
273 return properties
274
275
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000276# TODO(crbug.com/976104): Remove this function once git-cl try-results has
277# migrated to use buildbucket v2
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000278def _buildbucket_retry(operation_name, http, *args, **kwargs):
279 """Retries requests to buildbucket service and returns parsed json content."""
280 try_count = 0
281 while True:
282 response, content = http.request(*args, **kwargs)
283 try:
284 content_json = json.loads(content)
285 except ValueError:
286 content_json = None
287
288 # Buildbucket could return an error even if status==200.
289 if content_json and content_json.get('error'):
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000290 error = content_json.get('error')
291 if error.get('code') == 403:
292 raise BuildbucketResponseException(
293 'Access denied: %s' % error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000294 msg = 'Error in response. Reason: %s. Message: %s.' % (
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000295 error.get('reason', ''), error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000296 raise BuildbucketResponseException(msg)
297
298 if response.status == 200:
Nodir Turakulov23d75d22018-06-04 12:37:32 -0700299 if content_json is None:
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000300 raise BuildbucketResponseException(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000301 'Buildbucket returned invalid JSON content: %s.\n'
Nodir Turakulov9ac59792018-06-04 12:34:14 -0700302 'Please file bugs at http://crbug.com, '
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000303 'component "Infra>Platform>Buildbucket".' %
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000304 content)
305 return content_json
306 if response.status < 500 or try_count >= 2:
307 raise httplib2.HttpLib2Error(content)
308
309 # status >= 500 means transient failures.
310 logging.debug('Transient errors when %s. Will retry.', operation_name)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000311 time_sleep(0.5 + (1.5 * try_count))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000312 try_count += 1
313 assert False, 'unreachable'
314
315
Edward Lemur4c707a22019-09-24 21:13:43 +0000316def _call_buildbucket(http, buildbucket_host, method, request):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000317 """Calls a buildbucket v2 method and returns the parsed json response."""
318 headers = {
319 'Accept': 'application/json',
320 'Content-Type': 'application/json',
321 }
322 request = json.dumps(request)
323 url = 'https://%s/prpc/buildbucket.v2.Builds/%s' % (buildbucket_host, method)
324
325 logging.info('POST %s with %s' % (url, request))
326
327 attempts = 1
328 time_to_sleep = 1
329 while True:
330 response, content = http.request(url, 'POST', body=request, headers=headers)
331 if response.status == 200:
332 return json.loads(content[4:])
333 if attempts >= MAX_ATTEMPTS or 400 <= response.status < 500:
334 msg = '%s error when calling POST %s with %s: %s' % (
335 response.status, url, request, content)
336 raise BuildbucketResponseException(msg)
337 logging.debug(
338 '%s error when calling POST %s with %s. '
339 'Sleeping for %d seconds and retrying...' % (
340 response.status, url, request, time_to_sleep))
341 time.sleep(time_to_sleep)
342 time_to_sleep *= 2
343 attempts += 1
344
345 assert False, 'unreachable'
346
347
qyearsley1fdfcb62016-10-24 13:22:03 -0700348def _get_bucket_map(changelist, options, option_parser):
qyearsleydd49f942016-10-28 11:57:22 -0700349 """Returns a dict mapping bucket names to builders and tests,
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000350 for triggering tryjobs.
qyearsley1fdfcb62016-10-24 13:22:03 -0700351 """
qyearsleydd49f942016-10-28 11:57:22 -0700352 # If no bots are listed, we try to get a set of builders and tests based
353 # on GetPreferredTryMasters functions in PRESUBMIT.py files.
qyearsley1fdfcb62016-10-24 13:22:03 -0700354 if not options.bot:
Edward Lemur3b8094a2020-02-07 22:34:43 +0000355 change = changelist.GetChange(changelist.GetCommonAncestorWithUpstream())
qyearsley136b49f2016-10-31 09:02:26 -0700356 # Get try masters from PRESUBMIT.py files.
nodire4f0fe02016-11-04 16:23:30 -0700357 masters = presubmit_support.DoGetTryMasters(
qyearsley1fdfcb62016-10-24 13:22:03 -0700358 change=change,
359 changed_files=change.LocalPaths(),
360 repository_root=settings.GetRoot(),
361 default_presubmit=None,
362 project=None,
363 verbose=options.verbose,
364 output_stream=sys.stdout)
nodire4f0fe02016-11-04 16:23:30 -0700365 if masters is None:
366 return None
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000367 return {m: b for m, b in masters.items()}
qyearsley1fdfcb62016-10-24 13:22:03 -0700368
qyearsley1fdfcb62016-10-24 13:22:03 -0700369 if options.bucket:
370 return {options.bucket: {b: [] for b in options.bot}}
Andrii Shyshkalov75424372019-08-30 22:48:15 +0000371 option_parser.error(
Edward Lemur5ef16a32019-11-11 21:13:25 +0000372 'Please specify the bucket, e.g. "-B chromium/try".')
qyearsley1fdfcb62016-10-24 13:22:03 -0700373
374
Edward Lemur6215c792019-10-03 21:59:05 +0000375def _parse_bucket(raw_bucket):
376 legacy = True
377 project = bucket = None
378 if '/' in raw_bucket:
379 legacy = False
380 project, bucket = raw_bucket.split('/', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000381 # Assume luci.<project>.<bucket>.
Edward Lemur6215c792019-10-03 21:59:05 +0000382 elif raw_bucket.startswith('luci.'):
383 project, bucket = raw_bucket[len('luci.'):].split('.', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000384 # Otherwise, assume prefix is also the project name.
Edward Lemur6215c792019-10-03 21:59:05 +0000385 elif '.' in raw_bucket:
386 project = raw_bucket.split('.')[0]
387 bucket = raw_bucket
388 # Legacy buckets.
389 if legacy:
390 print('WARNING Please use %s/%s to specify the bucket.' % (project, bucket))
391 return project, bucket
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000392
393
Edward Lemur5b929a42019-10-21 17:57:39 +0000394def _trigger_try_jobs(changelist, buckets, options, patchset):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000395 """Sends a request to Buildbucket to trigger tryjobs for a changelist.
qyearsley1fdfcb62016-10-24 13:22:03 -0700396
397 Args:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000398 changelist: Changelist that the tryjobs are associated with.
qyearsley1fdfcb62016-10-24 13:22:03 -0700399 buckets: A nested dict mapping bucket names to builders to tests.
400 options: Command-line options.
401 """
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000402 print('Scheduling jobs on:')
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000403 for bucket, builders_and_tests in sorted(buckets.items()):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000404 print('Bucket:', bucket)
405 print('\n'.join(
406 ' %s: %s' % (builder, tests)
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000407 for builder, tests in sorted(builders_and_tests.items())))
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000408 print('To see results here, run: git cl try-results')
409 print('To see results in browser, run: git cl web')
tandriide281ae2016-10-12 06:02:30 -0700410
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000411 requests = _make_try_job_schedule_requests(
412 changelist, buckets, options, patchset)
413 if not requests:
414 return
415
Edward Lemur5b929a42019-10-21 17:57:39 +0000416 http = auth.Authenticator().authorize(httplib2.Http())
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000417 http.force_exception_to_status_code = True
418
419 batch_request = {'requests': requests}
420 batch_response = _call_buildbucket(
421 http, options.buildbucket_host, 'Batch', batch_request)
422
423 errors = [
424 ' ' + response['error']['message']
425 for response in batch_response.get('responses', [])
426 if 'error' in response
427 ]
428 if errors:
429 raise BuildbucketResponseException(
430 'Failed to schedule builds for some bots:\n%s' % '\n'.join(errors))
431
432
433def _make_try_job_schedule_requests(changelist, buckets, options, patchset):
Edward Lemurf0faf482019-09-25 20:40:17 +0000434 gerrit_changes = [changelist.GetGerritChange(patchset)]
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000435 shared_properties = {'category': getattr(options, 'category', 'git_cl_try')}
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000436 if getattr(options, 'clobber', False):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000437 shared_properties['clobber'] = True
438 shared_properties.update(_get_properties_from_options(options) or {})
439
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000440 shared_tags = [{'key': 'user_agent', 'value': 'git_cl_try'}]
441 if options.retry_failed:
442 shared_tags.append({'key': 'retry_failed',
443 'value': '1'})
444
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000445 requests = []
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000446 for raw_bucket, builders_and_tests in sorted(buckets.items()):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000447 project, bucket = _parse_bucket(raw_bucket)
448 if not project or not bucket:
449 print('WARNING Could not parse bucket "%s". Skipping.' % raw_bucket)
450 continue
451
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000452 for builder, tests in sorted(builders_and_tests.items()):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000453 properties = shared_properties.copy()
454 if 'presubmit' in builder.lower():
455 properties['dry_run'] = 'true'
456 if tests:
457 properties['testfilter'] = tests
458
459 requests.append({
460 'scheduleBuild': {
461 'requestId': str(uuid.uuid4()),
462 'builder': {
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000463 'project': getattr(options, 'project', None) or project,
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000464 'bucket': bucket,
465 'builder': builder,
466 },
467 'gerritChanges': gerrit_changes,
468 'properties': properties,
469 'tags': [
470 {'key': 'builder', 'value': builder},
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000471 ] + shared_tags,
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000472 }
473 })
Anthony Polito1a5fe232020-01-24 23:17:52 +0000474
475 if options.revision:
476 requests[-1]['scheduleBuild']['gitilesCommit'] = {
477 'host': gerrit_changes[0]['host'],
478 'project': gerrit_changes[0]['project'],
479 'id': options.revision
480 }
481
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000482 return requests
kjellander@chromium.org44424542015-06-02 18:35:29 +0000483
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000484
Edward Lemur5b929a42019-10-21 17:57:39 +0000485def fetch_try_jobs(changelist, buildbucket_host, patchset=None):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000486 """Fetches tryjobs from buildbucket.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000487
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000488 Returns list of buildbucket.v2.Build with the try jobs for the changelist.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000489 """
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000490 fields = ['id', 'builder', 'status', 'createTime', 'tags']
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000491 request = {
492 'predicate': {
493 'gerritChanges': [changelist.GetGerritChange(patchset)],
494 },
495 'fields': ','.join('builds.*.' + field for field in fields),
496 }
tandrii221ab252016-10-06 08:12:04 -0700497
Edward Lemur5b929a42019-10-21 17:57:39 +0000498 authenticator = auth.Authenticator()
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000499 if authenticator.has_cached_credentials():
500 http = authenticator.authorize(httplib2.Http())
501 else:
vapiera7fbd5a2016-06-16 09:17:49 -0700502 print('Warning: Some results might be missing because %s' %
503 # Get the message on how to login.
Edward Lemurba5bc992019-09-23 22:59:17 +0000504 (auth.LoginRequiredError().message,))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000505 http = httplib2.Http()
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000506 http.force_exception_to_status_code = True
507
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000508 response = _call_buildbucket(http, buildbucket_host, 'SearchBuilds', request)
509 return response.get('builds', [])
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000510
Edward Lemur5b929a42019-10-21 17:57:39 +0000511def _fetch_latest_builds(changelist, buildbucket_host, latest_patchset=None):
Quinten Yearsley983111f2019-09-26 17:18:48 +0000512 """Fetches builds from the latest patchset that has builds (within
513 the last few patchsets).
514
515 Args:
Quinten Yearsley983111f2019-09-26 17:18:48 +0000516 changelist (Changelist): The CL to fetch builds for
517 buildbucket_host (str): Buildbucket host, e.g. "cr-buildbucket.appspot.com"
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +0000518 lastest_patchset(int|NoneType): the patchset to start fetching builds from.
519 If None (default), starts with the latest available patchset.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000520 Returns:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000521 A tuple (builds, patchset) where builds is a list of buildbucket.v2.Build,
522 and patchset is the patchset number where those builds came from.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000523 """
524 assert buildbucket_host
525 assert changelist.GetIssue(), 'CL must be uploaded first'
526 assert changelist.GetCodereviewServer(), 'CL must be uploaded first'
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +0000527 if latest_patchset is None:
528 assert changelist.GetMostRecentPatchset()
529 ps = changelist.GetMostRecentPatchset()
530 else:
531 assert latest_patchset > 0, latest_patchset
532 ps = latest_patchset
533
Quinten Yearsley983111f2019-09-26 17:18:48 +0000534 min_ps = max(1, ps - 5)
535 while ps >= min_ps:
Edward Lemur5b929a42019-10-21 17:57:39 +0000536 builds = fetch_try_jobs(changelist, buildbucket_host, patchset=ps)
Quinten Yearsley983111f2019-09-26 17:18:48 +0000537 if len(builds):
538 return builds, ps
539 ps -= 1
540 return [], 0
541
542
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000543def _filter_failed_for_retry(all_builds):
544 """Returns a list of buckets/builders that are worth retrying.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000545
546 Args:
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000547 all_builds (list): Builds, in the format returned by fetch_try_jobs,
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000548 i.e. a list of buildbucket.v2.Builds which includes status and builder
549 info.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000550
551 Returns:
552 A dict of bucket to builder to tests (empty list). This is the same format
553 accepted by _trigger_try_jobs and returned by _get_bucket_map.
554 """
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000555
556 def _builder_of(build):
557 builder = build['builder']
558 return (builder['project'], builder['bucket'], builder['builder'])
559
560 res = collections.defaultdict(dict)
561 ordered = sorted(all_builds, key=lambda b: (_builder_of(b), b['createTime']))
562 for (proj, buck, bldr), builds in itertools.groupby(ordered, key=_builder_of):
563 # If builder had several builds, retry only if the last one failed.
564 # This is a bit different from CQ, which would re-use *any* SUCCESS-full
565 # build, but in case of retrying failed jobs retrying a flaky one makes
566 # sense.
567 builds = list(builds)
568 if builds[-1]['status'] not in ('FAILURE', 'INFRA_FAILURE'):
569 continue
570 if any(t['key'] == 'cq_experimental' and t['value'] == 'true'
571 for t in builds[-1]['tags']):
572 # Don't retry experimental build previously triggered by CQ.
573 continue
574 if any(b['status'] in ('STARTED', 'SCHEDULED') for b in builds):
575 # Don't retry if any are running.
576 continue
577 res[proj + '/' + buck][bldr] = []
578 return res
Quinten Yearsley983111f2019-09-26 17:18:48 +0000579
580
qyearsleyeab3c042016-08-24 09:18:28 -0700581def print_try_jobs(options, builds):
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000582 """Prints nicely result of fetch_try_jobs."""
583 if not builds:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000584 print('No tryjobs scheduled.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000585 return
586
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000587 longest_builder = max(len(b['builder']['builder']) for b in builds)
588 name_fmt = '{builder:<%d}' % longest_builder
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000589 if options.print_master:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000590 longest_bucket = max(len(b['builder']['bucket']) for b in builds)
591 name_fmt = ('{bucket:>%d} ' % longest_bucket) + name_fmt
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000592
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000593 builds_by_status = {}
594 for b in builds:
595 builds_by_status.setdefault(b['status'], []).append({
596 'id': b['id'],
597 'name': name_fmt.format(
598 builder=b['builder']['builder'], bucket=b['builder']['bucket']),
599 })
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000600
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000601 sort_key = lambda b: (b['name'], b['id'])
602
603 def print_builds(title, builds, fmt=None, color=None):
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000604 """Pop matching builds from `builds` dict and print them."""
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000605 if not builds:
606 return
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000607
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000608 fmt = fmt or '{name} https://ci.chromium.org/b/{id}'
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +0000609 if not options.color or color is None:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000610 colorize = lambda x: x
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000611 else:
612 colorize = lambda x: '%s%s%s' % (color, x, Fore.RESET)
613
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000614 print(colorize(title))
615 for b in sorted(builds, key=sort_key):
616 print(' ', colorize(fmt.format(**b)))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000617
618 total = len(builds)
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000619 print_builds(
620 'Successes:', builds_by_status.pop('SUCCESS', []), color=Fore.GREEN)
621 print_builds(
622 'Infra Failures:', builds_by_status.pop('INFRA_FAILURE', []),
623 color=Fore.MAGENTA)
624 print_builds('Failures:', builds_by_status.pop('FAILURE', []), color=Fore.RED)
625 print_builds('Canceled:', builds_by_status.pop('CANCELED', []), fmt='{name}',
626 color=Fore.MAGENTA)
627 print_builds('Started:', builds_by_status.pop('STARTED', []))
628 print_builds(
629 'Scheduled:', builds_by_status.pop('SCHEDULED', []), fmt='{name} id={id}')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000630 # The last section is just in case buildbucket API changes OR there is a bug.
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000631 print_builds(
632 'Other:', sum(builds_by_status.values(), []), fmt='{name} id={id}')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000633 print('Total: %d tryjobs' % total)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000634
635
Aiden Bennerc08566e2018-10-03 17:52:42 +0000636def _ComputeDiffLineRanges(files, upstream_commit):
637 """Gets the changed line ranges for each file since upstream_commit.
638
639 Parses a git diff on provided files and returns a dict that maps a file name
640 to an ordered list of range tuples in the form (start_line, count).
641 Ranges are in the same format as a git diff.
642 """
643 # If files is empty then diff_output will be a full diff.
644 if len(files) == 0:
645 return {}
646
Aiden Benner6c18a1a2018-11-23 20:18:23 +0000647 # Take the git diff and find the line ranges where there are changes.
Jamie Madill3671a6a2019-10-24 15:13:21 +0000648 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, files, allow_prefix=True)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000649 diff_output = RunGit(diff_cmd)
650
651 pattern = r'(?:^diff --git a/(?:.*) b/(.*))|(?:^@@.*\+(.*) @@)'
652 # 2 capture groups
653 # 0 == fname of diff file
654 # 1 == 'diff_start,diff_count' or 'diff_start'
655 # will match each of
656 # diff --git a/foo.foo b/foo.py
657 # @@ -12,2 +14,3 @@
658 # @@ -12,2 +17 @@
659 # running re.findall on the above string with pattern will give
660 # [('foo.py', ''), ('', '14,3'), ('', '17')]
661
662 curr_file = None
663 line_diffs = {}
664 for match in re.findall(pattern, diff_output, flags=re.MULTILINE):
665 if match[0] != '':
666 # Will match the second filename in diff --git a/a.py b/b.py.
667 curr_file = match[0]
668 line_diffs[curr_file] = []
669 else:
670 # Matches +14,3
671 if ',' in match[1]:
672 diff_start, diff_count = match[1].split(',')
673 else:
674 # Single line changes are of the form +12 instead of +12,1.
675 diff_start = match[1]
676 diff_count = 1
677
678 diff_start = int(diff_start)
679 diff_count = int(diff_count)
680
681 # If diff_count == 0 this is a removal we can ignore.
682 line_diffs[curr_file].append((diff_start, diff_count))
683
684 return line_diffs
685
686
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000687def _FindYapfConfigFile(fpath, yapf_config_cache, top_dir=None):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000688 """Checks if a yapf file is in any parent directory of fpath until top_dir.
689
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000690 Recursively checks parent directories to find yapf file and if no yapf file
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000691 is found returns None. Uses yapf_config_cache as a cache for previously found
692 configs.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000693 """
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000694 fpath = os.path.abspath(fpath)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000695 # Return result if we've already computed it.
696 if fpath in yapf_config_cache:
697 return yapf_config_cache[fpath]
698
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000699 parent_dir = os.path.dirname(fpath)
700 if os.path.isfile(fpath):
701 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000702 else:
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000703 # Otherwise fpath is a directory
704 yapf_file = os.path.join(fpath, YAPF_CONFIG_FILENAME)
705 if os.path.isfile(yapf_file):
706 ret = yapf_file
707 elif fpath == top_dir or parent_dir == fpath:
708 # If we're at the top level directory, or if we're at root
709 # there is no provided style.
710 ret = None
711 else:
712 # Otherwise recurse on the current directory.
713 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000714 yapf_config_cache[fpath] = ret
715 return ret
716
717
Brian Sheedyb4307d52019-12-02 19:18:17 +0000718def _GetYapfIgnorePatterns(top_dir):
719 """Returns all patterns in the .yapfignore file.
Brian Sheedy59b06a82019-10-14 17:03:29 +0000720
721 yapf is supposed to handle the ignoring of files listed in .yapfignore itself,
722 but this functionality appears to break when explicitly passing files to
723 yapf for formatting. According to
724 https://github.com/google/yapf/blob/master/README.rst#excluding-files-from-formatting-yapfignore,
725 the .yapfignore file should be in the directory that yapf is invoked from,
726 which we assume to be the top level directory in this case.
727
728 Args:
729 top_dir: The top level directory for the repository being formatted.
730
731 Returns:
Brian Sheedyb4307d52019-12-02 19:18:17 +0000732 A set of all fnmatch patterns to be ignored.
Brian Sheedy59b06a82019-10-14 17:03:29 +0000733 """
734 yapfignore_file = os.path.join(top_dir, '.yapfignore')
Brian Sheedyb4307d52019-12-02 19:18:17 +0000735 ignore_patterns = set()
Brian Sheedy59b06a82019-10-14 17:03:29 +0000736 if not os.path.exists(yapfignore_file):
Brian Sheedyb4307d52019-12-02 19:18:17 +0000737 return ignore_patterns
Brian Sheedy59b06a82019-10-14 17:03:29 +0000738
Brian Sheedyb4307d52019-12-02 19:18:17 +0000739 with open(yapfignore_file) as f:
740 for line in f.readlines():
741 stripped_line = line.strip()
742 # Comments and blank lines should be ignored.
743 if stripped_line.startswith('#') or stripped_line == '':
744 continue
745 ignore_patterns.add(stripped_line)
746 return ignore_patterns
747
748
749def _FilterYapfIgnoredFiles(filepaths, patterns):
750 """Filters out any filepaths that match any of the given patterns.
751
752 Args:
753 filepaths: An iterable of strings containing filepaths to filter.
754 patterns: An iterable of strings containing fnmatch patterns to filter on.
755
756 Returns:
757 A list of strings containing all the elements of |filepaths| that did not
758 match any of the patterns in |patterns|.
759 """
760 # Not inlined so that tests can use the same implementation.
761 return [f for f in filepaths
762 if not any(fnmatch.fnmatch(f, p) for p in patterns)]
Brian Sheedy59b06a82019-10-14 17:03:29 +0000763
764
Aaron Gable13101a62018-02-09 13:20:41 -0800765def print_stats(args):
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000766 """Prints statistics about the change to the user."""
767 # --no-ext-diff is broken in some versions of Git, so try to work around
768 # this by overriding the environment (but there is still a problem if the
769 # git config key "diff.external" is used).
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000770 env = GetNoGitPagerEnv()
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000771 if 'GIT_EXTERNAL_DIFF' in env:
772 del env['GIT_EXTERNAL_DIFF']
iannucci@chromium.org79540052012-10-19 23:15:26 +0000773
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000774 return subprocess2.call(
Aaron Gable13101a62018-02-09 13:20:41 -0800775 ['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] + args,
Edward Lemur0db01f02019-11-12 22:01:51 +0000776 env=env)
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000777
778
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000779class BuildbucketResponseException(Exception):
780 pass
781
782
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000783class Settings(object):
784 def __init__(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000785 self.cc = None
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000786 self.root = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000787 self.tree_status_url = None
788 self.viewvc_url = None
789 self.updated = False
ukai@chromium.orge8077812012-02-03 03:41:46 +0000790 self.is_gerrit = None
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000791 self.squash_gerrit_uploads = None
tandrii@chromium.org28253532016-04-14 13:46:56 +0000792 self.gerrit_skip_ensure_authenticated = None
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000793 self.git_editor = None
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000794 self.format_full_by_default = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000795
796 def LazyUpdateIfNeeded(self):
797 """Updates the settings from a codereview.settings file, if available."""
798 if not self.updated:
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000799 # The only value that actually changes the behavior is
800 # autoupdate = "false". Everything else means "true".
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +0000801 autoupdate = RunGit(['config', 'rietveld.autoupdate'],
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000802 error_ok=True
803 ).strip().lower()
804
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000805 cr_settings_file = FindCodereviewSettingsFile()
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000806 if autoupdate != 'false' and cr_settings_file:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000807 LoadCodereviewSettingsFromFile(cr_settings_file)
Josip906bfde2020-01-31 22:38:49 +0000808 cr_settings_file.close()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000809 self.updated = True
810
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000811 @staticmethod
812 def GetRelativeRoot():
813 return RunGit(['rev-parse', '--show-cdup']).strip()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000814
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000815 def GetRoot(self):
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000816 if self.root is None:
817 self.root = os.path.abspath(self.GetRelativeRoot())
818 return self.root
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000819
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000820 def GetTreeStatusUrl(self, error_ok=False):
821 if not self.tree_status_url:
822 error_message = ('You must configure your tree status URL by running '
823 '"git cl config".')
Edward Lemur61ea3072018-12-01 00:34:36 +0000824 self.tree_status_url = self._GetConfig(
825 'rietveld.tree-status-url', error_ok=error_ok,
826 error_message=error_message)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000827 return self.tree_status_url
828
829 def GetViewVCUrl(self):
830 if not self.viewvc_url:
Edward Lemur61ea3072018-12-01 00:34:36 +0000831 self.viewvc_url = self._GetConfig('rietveld.viewvc-url', error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000832 return self.viewvc_url
833
rmistry@google.com90752582014-01-14 21:04:50 +0000834 def GetBugPrefix(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000835 return self._GetConfig('rietveld.bug-prefix', error_ok=True)
rmistry@google.com78948ed2015-07-08 23:09:57 +0000836
rmistry@google.com5626a922015-02-26 14:03:30 +0000837 def GetRunPostUploadHook(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000838 run_post_upload_hook = self._GetConfig(
839 'rietveld.run-post-upload-hook', error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +0000840 return run_post_upload_hook == "True"
841
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000842 def GetDefaultCCList(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000843 return self._GetConfig('rietveld.cc', error_ok=True)
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000844
ukai@chromium.orge8077812012-02-03 03:41:46 +0000845 def GetIsGerrit(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000846 """Returns True if this repo is associated with Gerrit."""
ukai@chromium.orge8077812012-02-03 03:41:46 +0000847 if self.is_gerrit is None:
Aaron Gable9b465272017-05-12 10:53:51 -0700848 self.is_gerrit = (
849 self._GetConfig('gerrit.host', error_ok=True).lower() == 'true')
ukai@chromium.orge8077812012-02-03 03:41:46 +0000850 return self.is_gerrit
851
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000852 def GetSquashGerritUploads(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000853 """Returns True if uploads to Gerrit should be squashed by default."""
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000854 if self.squash_gerrit_uploads is None:
tandriia60502f2016-06-20 02:01:53 -0700855 self.squash_gerrit_uploads = self.GetSquashGerritUploadsOverride()
856 if self.squash_gerrit_uploads is None:
857 # Default is squash now (http://crbug.com/611892#c23).
858 self.squash_gerrit_uploads = not (
859 RunGit(['config', '--bool', 'gerrit.squash-uploads'],
860 error_ok=True).strip() == 'false')
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000861 return self.squash_gerrit_uploads
862
tandriia60502f2016-06-20 02:01:53 -0700863 def GetSquashGerritUploadsOverride(self):
864 """Return True or False if codereview.settings should be overridden.
865
866 Returns None if no override has been defined.
867 """
868 # See also http://crbug.com/611892#c23
869 result = RunGit(['config', '--bool', 'gerrit.override-squash-uploads'],
870 error_ok=True).strip()
871 if result == 'true':
872 return True
873 if result == 'false':
874 return False
875 return None
876
tandrii@chromium.org28253532016-04-14 13:46:56 +0000877 def GetGerritSkipEnsureAuthenticated(self):
878 """Return True if EnsureAuthenticated should not be done for Gerrit
879 uploads."""
880 if self.gerrit_skip_ensure_authenticated is None:
881 self.gerrit_skip_ensure_authenticated = (
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000882 RunGit(['config', '--bool', 'gerrit.skip-ensure-authenticated'],
tandrii@chromium.org28253532016-04-14 13:46:56 +0000883 error_ok=True).strip() == 'true')
884 return self.gerrit_skip_ensure_authenticated
885
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000886 def GetGitEditor(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000887 """Returns the editor specified in the git config, or None if none is."""
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000888 if self.git_editor is None:
Raul Tambre5a525872019-02-12 19:08:08 +0000889 # Git requires single quotes for paths with spaces. We need to replace
890 # them with double quotes for Windows to treat such paths as a single
891 # path.
892 self.git_editor = self._GetConfig(
893 'core.editor', error_ok=True).replace('\'', '"')
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000894 return self.git_editor or None
895
thestig@chromium.org44202a22014-03-11 19:22:18 +0000896 def GetLintRegex(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000897 return (self._GetConfig('rietveld.cpplint-regex', error_ok=True) or
thestig@chromium.org44202a22014-03-11 19:22:18 +0000898 DEFAULT_LINT_REGEX)
899
900 def GetLintIgnoreRegex(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000901 return (self._GetConfig('rietveld.cpplint-ignore-regex', error_ok=True) or
thestig@chromium.org44202a22014-03-11 19:22:18 +0000902 DEFAULT_LINT_IGNORE_REGEX)
903
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000904 def GetFormatFullByDefault(self):
905 if self.format_full_by_default is None:
906 result = (
907 RunGit(['config', '--bool', 'rietveld.format-full-by-default'],
908 error_ok=True).strip())
909 self.format_full_by_default = (result == 'true')
910 return self.format_full_by_default
911
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000912 def _GetConfig(self, param, **kwargs):
913 self.LazyUpdateIfNeeded()
914 return RunGit(['config', param], **kwargs).strip()
915
916
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000917class _CQState(object):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +0000918 """Enum for states of CL with respect to CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000919 NONE = 'none'
920 DRY_RUN = 'dry_run'
921 COMMIT = 'commit'
922
923 ALL_STATES = [NONE, DRY_RUN, COMMIT]
924
925
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000926class _ParsedIssueNumberArgument(object):
Edward Lemurf38bc172019-09-03 21:02:13 +0000927 def __init__(self, issue=None, patchset=None, hostname=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000928 self.issue = issue
929 self.patchset = patchset
930 self.hostname = hostname
931
932 @property
933 def valid(self):
934 return self.issue is not None
935
936
Edward Lemurf38bc172019-09-03 21:02:13 +0000937def ParseIssueNumberArgument(arg):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000938 """Parses the issue argument and returns _ParsedIssueNumberArgument."""
939 fail_result = _ParsedIssueNumberArgument()
940
Edward Lemur678a6842019-10-03 22:25:05 +0000941 if isinstance(arg, int):
942 return _ParsedIssueNumberArgument(issue=arg)
943 if not isinstance(arg, basestring):
944 return fail_result
945
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000946 if arg.isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +0000947 return _ParsedIssueNumberArgument(issue=int(arg))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000948 if not arg.startswith('http'):
949 return fail_result
Aaron Gableaee6c852017-06-26 12:49:01 -0700950
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000951 url = gclient_utils.UpgradeToHttps(arg)
952 try:
Edward Lemur79d4f992019-11-11 23:49:02 +0000953 parsed_url = urllib.parse.urlparse(url)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000954 except ValueError:
955 return fail_result
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +0200956
Edward Lemur678a6842019-10-03 22:25:05 +0000957 # Gerrit's new UI is https://domain/c/project/+/<issue_number>[/[patchset]]
958 # But old GWT UI is https://domain/#/c/project/+/<issue_number>[/[patchset]]
959 # Short urls like https://domain/<issue_number> can be used, but don't allow
960 # specifying the patchset (you'd 404), but we allow that here.
961 if parsed_url.path == '/':
962 part = parsed_url.fragment
963 else:
964 part = parsed_url.path
965
966 match = re.match(
967 r'(/c(/.*/\+)?)?/(?P<issue>\d+)(/(?P<patchset>\d+)?/?)?$', part)
968 if not match:
969 return fail_result
970
971 issue = int(match.group('issue'))
972 patchset = match.group('patchset')
973 return _ParsedIssueNumberArgument(
974 issue=issue,
975 patchset=int(patchset) if patchset else None,
976 hostname=parsed_url.netloc)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000977
978
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +0000979def _create_description_from_log(args):
980 """Pulls out the commit log to use as a base for the CL description."""
981 log_args = []
982 if len(args) == 1 and not args[0].endswith('.'):
983 log_args = [args[0] + '..']
984 elif len(args) == 1 and args[0].endswith('...'):
985 log_args = [args[0][:-1]]
986 elif len(args) == 2:
987 log_args = [args[0] + '..' + args[1]]
988 else:
989 log_args = args[:] # Hope for the best!
990 return RunGit(['log', '--pretty=format:%s\n\n%b'] + log_args)
991
992
Aaron Gablea45ee112016-11-22 15:14:38 -0800993class GerritChangeNotExists(Exception):
tandriic2405f52016-10-10 08:13:15 -0700994 def __init__(self, issue, url):
995 self.issue = issue
996 self.url = url
Aaron Gablea45ee112016-11-22 15:14:38 -0800997 super(GerritChangeNotExists, self).__init__()
tandriic2405f52016-10-10 08:13:15 -0700998
999 def __str__(self):
Aaron Gablea45ee112016-11-22 15:14:38 -08001000 return 'change %s at %s does not exist or you have no access to it' % (
tandriic2405f52016-10-10 08:13:15 -07001001 self.issue, self.url)
1002
1003
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001004_CommentSummary = collections.namedtuple(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001005 '_CommentSummary', ['date', 'message', 'sender', 'autogenerated',
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001006 # TODO(tandrii): these two aren't known in Gerrit.
1007 'approval', 'disapproval'])
1008
1009
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001010class Changelist(object):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001011 """Changelist works with one changelist in local branch.
1012
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00001013 Notes:
1014 * Not safe for concurrent multi-{thread,process} use.
1015 * Caches values from current branch. Therefore, re-use after branch change
tandrii5d48c322016-08-18 16:19:37 -07001016 with great care.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001017 """
1018
Edward Lemur125d60a2019-09-13 18:25:41 +00001019 def __init__(self, branchref=None, issue=None, codereview_host=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001020 """Create a new ChangeList instance.
1021
Edward Lemurf38bc172019-09-03 21:02:13 +00001022 **kwargs will be passed directly to Gerrit implementation.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001023 """
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001024 # Poke settings so we get the "configure your server" message if necessary.
maruel@chromium.org379d07a2011-11-30 14:58:10 +00001025 global settings
1026 if not settings:
1027 # Happens when git_cl.py is used as a utility library.
1028 settings = Settings()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001029
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001030 self.branchref = branchref
1031 if self.branchref:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00001032 assert branchref.startswith('refs/heads/')
Edward Lemur85153282020-02-14 22:06:29 +00001033 self.branch = scm.GIT.ShortBranchName(self.branchref)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001034 else:
1035 self.branch = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001036 self.upstream_branch = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001037 self.lookedup_issue = False
1038 self.issue = issue or None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001039 self.has_description = False
1040 self.description = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001041 self.lookedup_patchset = False
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001042 self.patchset = None
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001043 self.cc = None
Daniel Cheng7227d212017-11-17 08:12:37 -08001044 self.more_cc = []
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001045 self._remote = None
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001046 self._cached_remote_url = (False, None) # (is_cached, value)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001047
Edward Lemur125d60a2019-09-13 18:25:41 +00001048 # Lazily cached values.
1049 self._gerrit_host = None # e.g. chromium-review.googlesource.com
1050 self._gerrit_server = None # e.g. https://chromium-review.googlesource.com
1051 # Map from change number (issue) to its detail cache.
1052 self._detail_cache = {}
1053
1054 if codereview_host is not None:
1055 assert not codereview_host.startswith('https://'), codereview_host
1056 self._gerrit_host = codereview_host
1057 self._gerrit_server = 'https://%s' % codereview_host
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001058
1059 def GetCCList(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001060 """Returns the users cc'd on this CL.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001061
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001062 The return value is a string suitable for passing to git cl with the --cc
1063 flag.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001064 """
1065 if self.cc is None:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001066 base_cc = settings.GetDefaultCCList()
Daniel Cheng7227d212017-11-17 08:12:37 -08001067 more_cc = ','.join(self.more_cc)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001068 self.cc = ','.join(filter(None, (base_cc, more_cc))) or ''
1069 return self.cc
1070
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001071 def GetCCListWithoutDefault(self):
1072 """Return the users cc'd on this CL excluding default ones."""
1073 if self.cc is None:
Daniel Cheng7227d212017-11-17 08:12:37 -08001074 self.cc = ','.join(self.more_cc)
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001075 return self.cc
1076
Daniel Cheng7227d212017-11-17 08:12:37 -08001077 def ExtendCC(self, more_cc):
1078 """Extends the list of users to cc on this CL based on the changed files."""
1079 self.more_cc.extend(more_cc)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001080
1081 def GetBranch(self):
1082 """Returns the short branch name, e.g. 'master'."""
1083 if not self.branch:
Edward Lemur85153282020-02-14 22:06:29 +00001084 branchref = scm.GIT.GetBranchRef(settings.GetRoot())
szager@chromium.orgd62c61f2014-10-20 22:33:21 +00001085 if not branchref:
1086 return None
1087 self.branchref = branchref
Edward Lemur85153282020-02-14 22:06:29 +00001088 self.branch = scm.GIT.ShortBranchName(self.branchref)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001089 return self.branch
1090
1091 def GetBranchRef(self):
1092 """Returns the full branch name, e.g. 'refs/heads/master'."""
1093 self.GetBranch() # Poke the lazy loader.
1094 return self.branchref
1095
tandrii@chromium.org534f67a2016-04-07 18:47:05 +00001096 def ClearBranch(self):
1097 """Clears cached branch data of this object."""
1098 self.branch = self.branchref = None
1099
Edward Lemur85153282020-02-14 22:06:29 +00001100 def _GitGetBranchConfigValue(self, key, default=None):
1101 return scm.GIT.GetBranchConfig(
1102 settings.GetRoot(), self.GetBranch(), key, default)
tandrii5d48c322016-08-18 16:19:37 -07001103
Edward Lemur85153282020-02-14 22:06:29 +00001104 def _GitSetBranchConfigValue(self, key, value):
1105 action = 'set %s to %r' % (key, value)
1106 if not value:
1107 action = 'unset %s' % key
1108 assert self.GetBranch(), 'a branch is needed to ' + action
1109 return scm.GIT.SetBranchConfig(
1110 settings.GetRoot(), self.GetBranch(), key, value)
tandrii5d48c322016-08-18 16:19:37 -07001111
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001112 @staticmethod
1113 def FetchUpstreamTuple(branch):
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001114 """Returns a tuple containing remote and remote ref,
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001115 e.g. 'origin', 'refs/heads/master'
1116 """
Edward Lemur15a9b8c2020-02-13 00:52:30 +00001117 remote, upstream_branch = scm.GIT.FetchUpstreamTuple(
1118 settings.GetRoot(), branch)
1119 if not remote or not upstream_branch:
1120 DieWithError(
1121 'Unable to determine default branch to diff against.\n'
1122 'Either pass complete "git diff"-style arguments, like\n'
1123 ' git cl upload origin/master\n'
1124 'or verify this branch is set up to track another \n'
1125 '(via the --track argument to "git checkout -b ...").')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001126
1127 return remote, upstream_branch
1128
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001129 def GetCommonAncestorWithUpstream(self):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001130 upstream_branch = self.GetUpstreamBranch()
1131 if not BranchExists(upstream_branch):
1132 DieWithError('The upstream for the current branch (%s) does not exist '
1133 'anymore.\nPlease fix it and try again.' % self.GetBranch())
iannucci@chromium.org9e849272014-04-04 00:31:55 +00001134 return git_common.get_or_create_merge_base(self.GetBranch(),
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001135 upstream_branch)
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001136
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001137 def GetUpstreamBranch(self):
1138 if self.upstream_branch is None:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001139 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Raul Tambrefe1dbe12019-05-02 04:43:57 +00001140 if remote != '.':
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001141 upstream_branch = upstream_branch.replace('refs/heads/',
1142 'refs/remotes/%s/' % remote)
1143 upstream_branch = upstream_branch.replace('refs/branch-heads/',
1144 'refs/remotes/branch-heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001145 self.upstream_branch = upstream_branch
1146 return self.upstream_branch
1147
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001148 def GetRemoteBranch(self):
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001149 if not self._remote:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001150 remote, branch = None, self.GetBranch()
1151 seen_branches = set()
1152 while branch not in seen_branches:
1153 seen_branches.add(branch)
1154 remote, branch = self.FetchUpstreamTuple(branch)
Edward Lemur85153282020-02-14 22:06:29 +00001155 branch = scm.GIT.ShortBranchName(branch)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001156 if remote != '.' or branch.startswith('refs/remotes'):
1157 break
1158 else:
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001159 remotes = RunGit(['remote'], error_ok=True).split()
1160 if len(remotes) == 1:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001161 remote, = remotes
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001162 elif 'origin' in remotes:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001163 remote = 'origin'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001164 logging.warn('Could not determine which remote this change is '
1165 'associated with, so defaulting to "%s".' % self._remote)
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001166 else:
1167 logging.warn('Could not determine which remote this change is '
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001168 'associated with.')
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001169 branch = 'HEAD'
1170 if branch.startswith('refs/remotes'):
1171 self._remote = (remote, branch)
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001172 elif branch.startswith('refs/branch-heads/'):
1173 self._remote = (remote, branch.replace('refs/', 'refs/remotes/'))
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001174 else:
1175 self._remote = (remote, 'refs/remotes/%s/%s' % (remote, branch))
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001176 return self._remote
1177
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001178 def GitSanityChecks(self, upstream_git_obj):
1179 """Checks git repo status and ensures diff is from local commits."""
1180
sbc@chromium.org79706062015-01-14 21:18:12 +00001181 if upstream_git_obj is None:
1182 if self.GetBranch() is None:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001183 print('ERROR: Unable to determine current branch (detached HEAD?)',
vapiera7fbd5a2016-06-16 09:17:49 -07001184 file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001185 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001186 print('ERROR: No upstream branch.', file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001187 return False
1188
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001189 # Verify the commit we're diffing against is in our current branch.
1190 upstream_sha = RunGit(['rev-parse', '--verify', upstream_git_obj]).strip()
1191 common_ancestor = RunGit(['merge-base', upstream_sha, 'HEAD']).strip()
1192 if upstream_sha != common_ancestor:
vapiera7fbd5a2016-06-16 09:17:49 -07001193 print('ERROR: %s is not in the current branch. You may need to rebase '
1194 'your tracking branch' % upstream_sha, file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001195 return False
1196
1197 # List the commits inside the diff, and verify they are all local.
1198 commits_in_diff = RunGit(
1199 ['rev-list', '^%s' % upstream_sha, 'HEAD']).splitlines()
1200 code, remote_branch = RunGitWithCode(['config', 'gitcl.remotebranch'])
1201 remote_branch = remote_branch.strip()
1202 if code != 0:
1203 _, remote_branch = self.GetRemoteBranch()
1204
1205 commits_in_remote = RunGit(
1206 ['rev-list', '^%s' % upstream_sha, remote_branch]).splitlines()
1207
1208 common_commits = set(commits_in_diff) & set(commits_in_remote)
1209 if common_commits:
vapiera7fbd5a2016-06-16 09:17:49 -07001210 print('ERROR: Your diff contains %d commits already in %s.\n'
1211 'Run "git log --oneline %s..HEAD" to get a list of commits in '
1212 'the diff. If you are using a custom git flow, you can override'
1213 ' the reference used for this check with "git config '
1214 'gitcl.remotebranch <git-ref>".' % (
1215 len(common_commits), remote_branch, upstream_git_obj),
1216 file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001217 return False
1218 return True
1219
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001220 def GetGitBaseUrlFromConfig(self):
sheyang@chromium.orga656e702014-05-15 20:43:05 +00001221 """Return the configured base URL from branch.<branchname>.baseurl.
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001222
1223 Returns None if it is not set.
1224 """
tandrii5d48c322016-08-18 16:19:37 -07001225 return self._GitGetBranchConfigValue('base-url')
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001226
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001227 def GetRemoteUrl(self):
1228 """Return the configured remote URL, e.g. 'git://example.org/foo.git/'.
1229
1230 Returns None if there is no remote.
1231 """
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001232 is_cached, value = self._cached_remote_url
1233 if is_cached:
1234 return value
1235
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001236 remote, _ = self.GetRemoteBranch()
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001237 url = RunGit(['config', 'remote.%s.url' % remote], error_ok=True).strip()
1238
Edward Lemur298f2cf2019-02-22 21:40:39 +00001239 # Check if the remote url can be parsed as an URL.
Edward Lemur79d4f992019-11-11 23:49:02 +00001240 host = urllib.parse.urlparse(url).netloc
Edward Lemur298f2cf2019-02-22 21:40:39 +00001241 if host:
1242 self._cached_remote_url = (True, url)
1243 return url
1244
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001245 # If it cannot be parsed as an url, assume it is a local directory,
1246 # probably a git cache.
Edward Lemur298f2cf2019-02-22 21:40:39 +00001247 logging.warning('"%s" doesn\'t appear to point to a git host. '
1248 'Interpreting it as a local directory.', url)
1249 if not os.path.isdir(url):
1250 logging.error(
Josip906bfde2020-01-31 22:38:49 +00001251 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
1252 'but it doesn\'t exist.',
1253 {'remote': remote, 'branch': self.GetBranch(), 'url': url})
Edward Lemur298f2cf2019-02-22 21:40:39 +00001254 return None
1255
1256 cache_path = url
1257 url = RunGit(['config', 'remote.%s.url' % remote],
1258 error_ok=True,
1259 cwd=url).strip()
1260
Edward Lemur79d4f992019-11-11 23:49:02 +00001261 host = urllib.parse.urlparse(url).netloc
Edward Lemur298f2cf2019-02-22 21:40:39 +00001262 if not host:
1263 logging.error(
1264 'Remote "%(remote)s" for branch "%(branch)s" points to '
1265 '"%(cache_path)s", but it is misconfigured.\n'
1266 '"%(cache_path)s" must be a git repo and must have a remote named '
1267 '"%(remote)s" pointing to the git host.', {
1268 'remote': remote,
1269 'cache_path': cache_path,
1270 'branch': self.GetBranch()})
1271 return None
1272
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001273 self._cached_remote_url = (True, url)
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001274 return url
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001275
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001276 def GetIssue(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001277 """Returns the issue number as a int or None if not set."""
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001278 if self.issue is None and not self.lookedup_issue:
Edward Lemur85153282020-02-14 22:06:29 +00001279 self.issue = self._GitGetBranchConfigValue(self.IssueConfigKey())
1280 if self.issue is not None:
1281 self.issue = int(self.issue)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001282 self.lookedup_issue = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001283 return self.issue
1284
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001285 def GetIssueURL(self):
1286 """Get the URL for a particular issue."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001287 issue = self.GetIssue()
1288 if not issue:
dbeam@chromium.org015fd3d2013-06-18 19:02:50 +00001289 return None
Edward Lemur125d60a2019-09-13 18:25:41 +00001290 return '%s/%s' % (self.GetCodereviewServer(), issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001291
Edward Lemur7f6dec02020-02-06 20:23:58 +00001292 def GetLocalDescription(self, upstream_branch):
1293 """Return the log messages of all commits up to the branch point."""
1294 args = ['log', '--pretty=format:%s%n%n%b', '%s...' % (upstream_branch)]
1295 return RunGitWithCode(args)[1].strip()
1296
Edward Lemur6c6827c2020-02-06 21:15:18 +00001297 def FetchDescription(self, pretty=False):
1298 assert self.GetIssue(), 'issue is required to query Gerrit'
1299
1300 if not self.has_description:
1301 data = self._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
1302 current_rev = data['current_revision']
1303 self.description = data['revisions'][current_rev]['commit']['message']
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001304 self.has_description = True
Edward Lemur6c6827c2020-02-06 21:15:18 +00001305
1306 if not pretty:
1307 return self.description
1308
1309 # Set width to 72 columns + 2 space indent.
1310 wrapper = textwrap.TextWrapper(width=74, replace_whitespace=True)
1311 wrapper.initial_indent = wrapper.subsequent_indent = ' '
1312 lines = self.description.splitlines()
1313 return '\n'.join([wrapper.fill(line) for line in lines])
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001314
1315 def GetPatchset(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001316 """Returns the patchset number as a int or None if not set."""
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001317 if self.patchset is None and not self.lookedup_patchset:
Edward Lemur85153282020-02-14 22:06:29 +00001318 self.patchset = self._GitGetBranchConfigValue(self.PatchsetConfigKey())
1319 if self.patchset is not None:
1320 self.patchset = int(self.patchset)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001321 self.lookedup_patchset = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001322 return self.patchset
1323
1324 def SetPatchset(self, patchset):
tandrii5d48c322016-08-18 16:19:37 -07001325 """Set this branch's patchset. If patchset=0, clears the patchset."""
1326 assert self.GetBranch()
1327 if not patchset:
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001328 self.patchset = None
tandrii5d48c322016-08-18 16:19:37 -07001329 else:
1330 self.patchset = int(patchset)
1331 self._GitSetBranchConfigValue(
Edward Lemur85153282020-02-14 22:06:29 +00001332 self.PatchsetConfigKey(), str(self.patchset))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001333
tandrii@chromium.orga342c922016-03-16 07:08:25 +00001334 def SetIssue(self, issue=None):
tandrii5d48c322016-08-18 16:19:37 -07001335 """Set this branch's issue. If issue isn't given, clears the issue."""
1336 assert self.GetBranch()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001337 if issue:
tandrii5d48c322016-08-18 16:19:37 -07001338 issue = int(issue)
1339 self._GitSetBranchConfigValue(
Edward Lemur85153282020-02-14 22:06:29 +00001340 self.IssueConfigKey(), str(issue))
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001341 self.issue = issue
Edward Lemur125d60a2019-09-13 18:25:41 +00001342 codereview_server = self.GetCodereviewServer()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001343 if codereview_server:
tandrii5d48c322016-08-18 16:19:37 -07001344 self._GitSetBranchConfigValue(
Edward Lemur125d60a2019-09-13 18:25:41 +00001345 self.CodereviewServerConfigKey(),
tandrii5d48c322016-08-18 16:19:37 -07001346 codereview_server)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001347 else:
tandrii5d48c322016-08-18 16:19:37 -07001348 # Reset all of these just to be clean.
1349 reset_suffixes = [
1350 'last-upload-hash',
Edward Lemur125d60a2019-09-13 18:25:41 +00001351 self.IssueConfigKey(),
1352 self.PatchsetConfigKey(),
1353 self.CodereviewServerConfigKey(),
tandrii5d48c322016-08-18 16:19:37 -07001354 ] + self._PostUnsetIssueProperties()
1355 for prop in reset_suffixes:
Edward Lemur85153282020-02-14 22:06:29 +00001356 try:
1357 self._GitSetBranchConfigValue(prop, None)
1358 except subprocess2.CalledProcessError:
1359 pass
Aaron Gableca01e2c2017-07-19 11:16:02 -07001360 msg = RunGit(['log', '-1', '--format=%B']).strip()
1361 if msg and git_footers.get_footer_change_id(msg):
1362 print('WARNING: The change patched into this branch has a Change-Id. '
1363 'Removing it.')
1364 RunGit(['commit', '--amend', '-m',
1365 git_footers.remove_footer(msg, 'Change-Id')])
Edward Lemurf38bc172019-09-03 21:02:13 +00001366 self.lookedup_issue = True
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001367 self.issue = None
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001368 self.patchset = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001369
Edward Lemur7f6dec02020-02-06 20:23:58 +00001370 def GetChange(self, upstream_branch):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001371 if not self.GitSanityChecks(upstream_branch):
1372 DieWithError('\nGit sanity check failure')
1373
Edward Lemur7f6dec02020-02-06 20:23:58 +00001374 root = settings.GetRoot()
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001375 # We use the sha1 of HEAD as a name of this change.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001376 name = RunGitWithCode(['rev-parse', 'HEAD'])[1].strip()
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001377 try:
Edward Lemur7f6dec02020-02-06 20:23:58 +00001378 files = scm.GIT.CaptureStatus(root, upstream_branch)
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001379 except subprocess2.CalledProcessError:
1380 DieWithError(
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001381 ('\nFailed to diff against upstream branch %s\n\n'
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001382 'This branch probably doesn\'t exist anymore. To reset the\n'
1383 'tracking branch, please run\n'
stip7a3dd352016-09-22 17:32:28 -07001384 ' git branch --set-upstream-to origin/master %s\n'
1385 'or replace origin/master with the relevant branch') %
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001386 (upstream_branch, self.GetBranch()))
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001387
maruel@chromium.org52424302012-08-29 15:14:30 +00001388 issue = self.GetIssue()
1389 patchset = self.GetPatchset()
Edward Lemur7f6dec02020-02-06 20:23:58 +00001390 if issue:
Edward Lemur6c6827c2020-02-06 21:15:18 +00001391 description = self.FetchDescription()
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001392 else:
1393 # If the change was never uploaded, use the log messages of all commits
1394 # up to the branch point, as git cl upload will prefill the description
1395 # with these log messages.
Edward Lemur7f6dec02020-02-06 20:23:58 +00001396 description = self.GetLocalDescription(upstream_branch)
maruel@chromium.org03b3bdc2011-06-14 13:04:12 +00001397
Edward Lemur7f6dec02020-02-06 20:23:58 +00001398 author = RunGit(['config', 'user.email']).strip() or None
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001399 return presubmit_support.GitChange(
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001400 name,
1401 description,
Edward Lemur7f6dec02020-02-06 20:23:58 +00001402 root,
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001403 files,
1404 issue,
1405 patchset,
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001406 author,
1407 upstream=upstream_branch)
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001408
dsansomee2d6fd92016-09-08 00:10:47 -07001409 def UpdateDescription(self, description, force=False):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001410 assert self.GetIssue(), 'issue is required to update description'
1411
1412 if gerrit_util.HasPendingChangeEdit(
1413 self._GetGerritHost(), self._GerritChangeIdentifier()):
1414 if not force:
1415 confirm_or_exit(
1416 'The description cannot be modified while the issue has a pending '
1417 'unpublished edit. Either publish the edit in the Gerrit web UI '
1418 'or delete it.\n\n', action='delete the unpublished edit')
1419
1420 gerrit_util.DeletePendingChangeEdit(
1421 self._GetGerritHost(), self._GerritChangeIdentifier())
1422 gerrit_util.SetCommitMessage(
1423 self._GetGerritHost(), self._GerritChangeIdentifier(),
1424 description, notify='NONE')
1425
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001426 self.description = description
Andrii Shyshkalov83051152017-02-07 23:47:29 +01001427 self.has_description = True
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001428
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001429
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001430
Edward Lesmes8e282792018-04-03 18:50:29 -04001431 def RunHook(self, committing, may_prompt, verbose, change, parallel):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001432 """Calls sys.exit() if the hook fails; returns a HookResults otherwise."""
1433 try:
Edward Lemur2c48f242019-06-04 16:14:09 +00001434 start = time_time()
1435 result = presubmit_support.DoPresubmitChecks(change, committing,
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001436 verbose=verbose, output_stream=sys.stdout, input_stream=sys.stdin,
1437 default_presubmit=None, may_prompt=may_prompt,
Edward Lemur125d60a2019-09-13 18:25:41 +00001438 gerrit_obj=self.GetGerritObjForPresubmit(),
Edward Lesmes8e282792018-04-03 18:50:29 -04001439 parallel=parallel)
Edward Lemur2c48f242019-06-04 16:14:09 +00001440 metrics.collector.add_repeated('sub_commands', {
1441 'command': 'presubmit',
1442 'execution_time': time_time() - start,
1443 'exit_code': 0 if result.should_continue() else 1,
1444 })
1445 return result
vapierfd77ac72016-06-16 08:33:57 -07001446 except presubmit_support.PresubmitFailure as e:
Aaron Gable5d5f22c2018-02-02 09:12:41 -08001447 DieWithError('%s\nMaybe your depot_tools is out of date?' % e)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001448
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001449 def CMDUpload(self, options, git_diff_args, orig_args):
1450 """Uploads a change to codereview."""
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001451 custom_cl_base = None
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001452 if git_diff_args:
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001453 custom_cl_base = base_branch = git_diff_args[0]
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001454 else:
1455 if self.GetBranch() is None:
1456 DieWithError('Can\'t upload from detached HEAD state. Get on a branch!')
1457
1458 # Default to diffing against common ancestor of upstream branch
1459 base_branch = self.GetCommonAncestorWithUpstream()
1460 git_diff_args = [base_branch, 'HEAD']
1461
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001462 # Fast best-effort checks to abort before running potentially expensive
1463 # hooks if uploading is likely to fail anyway. Passing these checks does
1464 # not guarantee that uploading will not fail.
Edward Lemur125d60a2019-09-13 18:25:41 +00001465 self.EnsureAuthenticated(force=options.force)
1466 self.EnsureCanUploadPatchset(force=options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001467
1468 # Apply watchlists on upload.
Edward Lemur7f6dec02020-02-06 20:23:58 +00001469 change = self.GetChange(base_branch)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001470 watchlist = watchlists.Watchlists(change.RepositoryRoot())
1471 files = [f.LocalPath() for f in change.AffectedFiles()]
1472 if not options.bypass_watchlists:
Daniel Cheng7227d212017-11-17 08:12:37 -08001473 self.ExtendCC(watchlist.GetWatchersForPaths(files))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001474
1475 if not options.bypass_hooks:
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001476 if options.reviewers or options.tbrs or options.add_owners_to:
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001477 # Set the reviewer list now so that presubmit checks can access it.
1478 change_description = ChangeDescription(change.FullDescriptionText())
1479 change_description.update_reviewers(options.reviewers,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001480 options.tbrs,
Robert Iannuccif2708bd2017-04-17 15:49:02 -07001481 options.add_owners_to,
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001482 change)
1483 change.SetDescriptionText(change_description.description)
1484 hook_results = self.RunHook(committing=False,
Edward Lesmes8e282792018-04-03 18:50:29 -04001485 may_prompt=not options.force,
1486 verbose=options.verbose,
1487 change=change, parallel=options.parallel)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001488 if not hook_results.should_continue():
1489 return 1
1490 if not options.reviewers and hook_results.reviewers:
1491 options.reviewers = hook_results.reviewers.split(',')
Daniel Cheng7227d212017-11-17 08:12:37 -08001492 self.ExtendCC(hook_results.more_cc)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001493
Aaron Gable13101a62018-02-09 13:20:41 -08001494 print_stats(git_diff_args)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001495 ret = self.CMDUploadChange(options, git_diff_args, custom_cl_base, change)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001496 if not ret:
Edward Lemur85153282020-02-14 22:06:29 +00001497 self._GitSetBranchConfigValue(
1498 'last-upload-hash', RunGit(['rev-parse', 'HEAD']).strip())
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001499 # Run post upload hooks, if specified.
1500 if settings.GetRunPostUploadHook():
1501 presubmit_support.DoPostUploadExecuter(
1502 change,
Edward Lemur016a0872020-02-04 22:13:28 +00001503 self.GetGerritObjForPresubmit(),
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001504 settings.GetRoot(),
1505 options.verbose,
1506 sys.stdout)
1507
1508 # Upload all dependencies if specified.
1509 if options.dependencies:
vapiera7fbd5a2016-06-16 09:17:49 -07001510 print()
1511 print('--dependencies has been specified.')
1512 print('All dependent local branches will be re-uploaded.')
1513 print()
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001514 # Remove the dependencies flag from args so that we do not end up in a
1515 # loop.
1516 orig_args.remove('--dependencies')
1517 ret = upload_branch_deps(self, orig_args)
1518 return ret
1519
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001520 def SetCQState(self, new_state):
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001521 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001522
1523 Issue must have been already uploaded and known.
1524 """
1525 assert new_state in _CQState.ALL_STATES
1526 assert self.GetIssue()
qyearsley1fdfcb62016-10-24 13:22:03 -07001527 try:
Edward Lemur125d60a2019-09-13 18:25:41 +00001528 vote_map = {
1529 _CQState.NONE: 0,
1530 _CQState.DRY_RUN: 1,
1531 _CQState.COMMIT: 2,
1532 }
1533 labels = {'Commit-Queue': vote_map[new_state]}
1534 notify = False if new_state == _CQState.DRY_RUN else None
1535 gerrit_util.SetReview(
1536 self._GetGerritHost(), self._GerritChangeIdentifier(),
1537 labels=labels, notify=notify)
qyearsley1fdfcb62016-10-24 13:22:03 -07001538 return 0
1539 except KeyboardInterrupt:
1540 raise
1541 except:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001542 print('WARNING: Failed to %s.\n'
qyearsley1fdfcb62016-10-24 13:22:03 -07001543 'Either:\n'
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001544 ' * Your project has no CQ,\n'
1545 ' * You don\'t have permission to change the CQ state,\n'
1546 ' * There\'s a bug in this code (see stack trace below).\n'
1547 'Consider specifying which bots to trigger manually or asking your '
1548 'project owners for permissions or contacting Chrome Infra at:\n'
1549 'https://www.chromium.org/infra\n\n' %
1550 ('cancel CQ' if new_state == _CQState.NONE else 'trigger CQ'))
qyearsley1fdfcb62016-10-24 13:22:03 -07001551 # Still raise exception so that stack trace is printed.
1552 raise
1553
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001554 def _GetGerritHost(self):
1555 # Lazy load of configs.
1556 self.GetCodereviewServer()
tandriie32e3ea2016-06-22 02:52:48 -07001557 if self._gerrit_host and '.' not in self._gerrit_host:
1558 # Abbreviated domain like "chromium" instead of chromium.googlesource.com.
1559 # This happens for internal stuff http://crbug.com/614312.
Edward Lemur79d4f992019-11-11 23:49:02 +00001560 parsed = urllib.parse.urlparse(self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001561 if parsed.scheme == 'sso':
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001562 print('WARNING: using non-https URLs for remote is likely broken\n'
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001563 ' Your current remote is: %s' % self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001564 self._gerrit_host = '%s.googlesource.com' % self._gerrit_host
1565 self._gerrit_server = 'https://%s' % self._gerrit_host
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001566 return self._gerrit_host
1567
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001568 def _GetGitHost(self):
1569 """Returns git host to be used when uploading change to Gerrit."""
Edward Lemur298f2cf2019-02-22 21:40:39 +00001570 remote_url = self.GetRemoteUrl()
1571 if not remote_url:
1572 return None
Edward Lemur79d4f992019-11-11 23:49:02 +00001573 return urllib.parse.urlparse(remote_url).netloc
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001574
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001575 def GetCodereviewServer(self):
1576 if not self._gerrit_server:
1577 # If we're on a branch then get the server potentially associated
1578 # with that branch.
Edward Lemur85153282020-02-14 22:06:29 +00001579 if self.GetIssue() and self.GetBranch():
tandrii5d48c322016-08-18 16:19:37 -07001580 self._gerrit_server = self._GitGetBranchConfigValue(
1581 self.CodereviewServerConfigKey())
1582 if self._gerrit_server:
Edward Lemur79d4f992019-11-11 23:49:02 +00001583 self._gerrit_host = urllib.parse.urlparse(self._gerrit_server).netloc
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001584 if not self._gerrit_server:
1585 # We assume repo to be hosted on Gerrit, and hence Gerrit server
1586 # has "-review" suffix for lowest level subdomain.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001587 parts = self._GetGitHost().split('.')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001588 parts[0] = parts[0] + '-review'
1589 self._gerrit_host = '.'.join(parts)
1590 self._gerrit_server = 'https://%s' % self._gerrit_host
1591 return self._gerrit_server
1592
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001593 def _GetGerritProject(self):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001594 """Returns Gerrit project name based on remote git URL."""
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001595 remote_url = self.GetRemoteUrl()
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001596 if remote_url is None:
Josip906bfde2020-01-31 22:38:49 +00001597 logging.warning('can\'t detect Gerrit project.')
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001598 return None
Edward Lemur79d4f992019-11-11 23:49:02 +00001599 project = urllib.parse.urlparse(remote_url).path.strip('/')
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001600 if project.endswith('.git'):
1601 project = project[:-len('.git')]
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001602 # *.googlesource.com hosts ensure that Git/Gerrit projects don't start with
1603 # 'a/' prefix, because 'a/' prefix is used to force authentication in
1604 # gitiles/git-over-https protocol. E.g.,
1605 # https://chromium.googlesource.com/a/v8/v8 refers to the same repo/project
1606 # as
1607 # https://chromium.googlesource.com/v8/v8
1608 if project.startswith('a/'):
1609 project = project[len('a/'):]
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001610 return project
1611
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001612 def _GerritChangeIdentifier(self):
1613 """Handy method for gerrit_util.ChangeIdentifier for a given CL.
1614
1615 Not to be confused by value of "Change-Id:" footer.
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001616 If Gerrit project can be determined, this will speed up Gerrit HTTP API RPC.
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001617 """
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001618 project = self._GetGerritProject()
1619 if project:
1620 return gerrit_util.ChangeIdentifier(project, self.GetIssue())
1621 # Fall back on still unique, but less efficient change number.
1622 return str(self.GetIssue())
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001623
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001624 @classmethod
tandrii5d48c322016-08-18 16:19:37 -07001625 def IssueConfigKey(cls):
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001626 return 'gerritissue'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001627
tandrii5d48c322016-08-18 16:19:37 -07001628 @classmethod
1629 def PatchsetConfigKey(cls):
1630 return 'gerritpatchset'
1631
1632 @classmethod
1633 def CodereviewServerConfigKey(cls):
1634 return 'gerritserver'
1635
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001636 def EnsureAuthenticated(self, force, refresh=None):
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001637 """Best effort check that user is authenticated with Gerrit server."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001638 if settings.GetGerritSkipEnsureAuthenticated():
1639 # For projects with unusual authentication schemes.
1640 # See http://crbug.com/603378.
1641 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001642
1643 # Check presence of cookies only if using cookies-based auth method.
1644 cookie_auth = gerrit_util.Authenticator.get()
1645 if not isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001646 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001647
Florian Mayerae510e82020-01-30 21:04:48 +00001648 remote_url = self.GetRemoteUrl()
1649 if remote_url is None:
Josip906bfde2020-01-31 22:38:49 +00001650 logging.warning('invalid remote')
Florian Mayerae510e82020-01-30 21:04:48 +00001651 return
1652 if urllib.parse.urlparse(remote_url).scheme != 'https':
Josip906bfde2020-01-31 22:38:49 +00001653 logging.warning('Ignoring branch %(branch)s with non-https remote '
1654 '%(remote)s', {
1655 'branch': self.branch,
1656 'remote': self.GetRemoteUrl()
1657 })
Daniel Chengcf6269b2019-05-18 01:02:12 +00001658 return
1659
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001660 # Lazy-loader to identify Gerrit and Git hosts.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001661 self.GetCodereviewServer()
1662 git_host = self._GetGitHost()
Edward Lemur298f2cf2019-02-22 21:40:39 +00001663 assert self._gerrit_server and self._gerrit_host and git_host
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001664
1665 gerrit_auth = cookie_auth.get_auth_header(self._gerrit_host)
1666 git_auth = cookie_auth.get_auth_header(git_host)
1667 if gerrit_auth and git_auth:
1668 if gerrit_auth == git_auth:
1669 return
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001670 all_gsrc = cookie_auth.get_auth_header('d0esN0tEx1st.googlesource.com')
Raul Tambre80ee78e2019-05-06 22:41:05 +00001671 print(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001672 'WARNING: You have different credentials for Gerrit and git hosts:\n'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001673 ' %s\n'
1674 ' %s\n'
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001675 ' Consider running the following command:\n'
1676 ' git cl creds-check\n'
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001677 ' %s\n'
Raul Tambre80ee78e2019-05-06 22:41:05 +00001678 ' %s' %
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001679 (git_host, self._gerrit_host,
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001680 ('Hint: delete creds for .googlesource.com' if all_gsrc else ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001681 cookie_auth.get_new_password_message(git_host)))
1682 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001683 confirm_or_exit('If you know what you are doing', action='continue')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001684 return
1685 else:
1686 missing = (
Anna Henningsen4e891442017-07-06 21:40:58 +02001687 ([] if gerrit_auth else [self._gerrit_host]) +
1688 ([] if git_auth else [git_host]))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001689 DieWithError('Credentials for the following hosts are required:\n'
1690 ' %s\n'
1691 'These are read from %s (or legacy %s)\n'
1692 '%s' % (
1693 '\n '.join(missing),
1694 cookie_auth.get_gitcookies_path(),
1695 cookie_auth.get_netrc_path(),
1696 cookie_auth.get_new_password_message(git_host)))
1697
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001698 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001699 if not self.GetIssue():
1700 return
1701
1702 # Warm change details cache now to avoid RPCs later, reducing latency for
1703 # developers.
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001704 self._GetChangeDetail(
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +00001705 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS'])
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001706
1707 status = self._GetChangeDetail()['status']
1708 if status in ('MERGED', 'ABANDONED'):
1709 DieWithError('Change %s has been %s, new uploads are not allowed' %
1710 (self.GetIssueURL(),
1711 'submitted' if status == 'MERGED' else 'abandoned'))
1712
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001713 # TODO(vadimsh): For some reason the chunk of code below was skipped if
1714 # 'is_gce' is True. I'm just refactoring it to be 'skip if not cookies'.
1715 # Apparently this check is not very important? Otherwise get_auth_email
1716 # could have been added to other implementations of Authenticator.
1717 cookies_auth = gerrit_util.Authenticator.get()
1718 if not isinstance(cookies_auth, gerrit_util.CookiesAuthenticator):
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001719 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001720
1721 cookies_user = cookies_auth.get_auth_email(self._GetGerritHost())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001722 if self.GetIssueOwner() == cookies_user:
1723 return
1724 logging.debug('change %s owner is %s, cookies user is %s',
1725 self.GetIssue(), self.GetIssueOwner(), cookies_user)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001726 # Maybe user has linked accounts or something like that,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001727 # so ask what Gerrit thinks of this user.
1728 details = gerrit_util.GetAccountDetails(self._GetGerritHost(), 'self')
1729 if details['email'] == self.GetIssueOwner():
1730 return
1731 if not force:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001732 print('WARNING: Change %s is owned by %s, but you authenticate to Gerrit '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001733 'as %s.\n'
1734 'Uploading may fail due to lack of permissions.' %
1735 (self.GetIssue(), self.GetIssueOwner(), details['email']))
1736 confirm_or_exit(action='upload')
1737
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001738 def _PostUnsetIssueProperties(self):
1739 """Which branch-specific properties to erase when unsetting issue."""
tandrii5d48c322016-08-18 16:19:37 -07001740 return ['gerritsquashhash']
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001741
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001742 def GetGerritObjForPresubmit(self):
1743 return presubmit_support.GerritAccessor(self._GetGerritHost())
1744
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001745 def GetStatus(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001746 """Applies a rough heuristic to give a simple summary of an issue's review
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001747 or CQ status, assuming adherence to a common workflow.
1748
1749 Returns None if no issue for this branch, or one of the following keywords:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001750 * 'error' - error from review tool (including deleted issues)
1751 * 'unsent' - no reviewers added
1752 * 'waiting' - waiting for review
1753 * 'reply' - waiting for uploader to reply to review
1754 * 'lgtm' - Code-Review label has been set
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00001755 * 'dry-run' - dry-running in the CQ
1756 * 'commit' - in the CQ
Aaron Gable9ab38c62017-04-06 14:36:33 -07001757 * 'closed' - successfully submitted or abandoned
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001758 """
1759 if not self.GetIssue():
1760 return None
1761
1762 try:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001763 data = self._GetChangeDetail([
1764 'DETAILED_LABELS', 'CURRENT_REVISION', 'SUBMITTABLE'])
Edward Lemur79d4f992019-11-11 23:49:02 +00001765 except GerritChangeNotExists:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001766 return 'error'
1767
tandrii@chromium.org5e1bf382016-05-17 08:43:24 +00001768 if data['status'] in ('ABANDONED', 'MERGED'):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001769 return 'closed'
1770
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001771 cq_label = data['labels'].get('Commit-Queue', {})
1772 max_cq_vote = 0
1773 for vote in cq_label.get('all', []):
1774 max_cq_vote = max(max_cq_vote, vote.get('value', 0))
1775 if max_cq_vote == 2:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001776 return 'commit'
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001777 if max_cq_vote == 1:
1778 return 'dry-run'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001779
Aaron Gable9ab38c62017-04-06 14:36:33 -07001780 if data['labels'].get('Code-Review', {}).get('approved'):
1781 return 'lgtm'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001782
1783 if not data.get('reviewers', {}).get('REVIEWER', []):
1784 return 'unsent'
1785
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001786 owner = data['owner'].get('_account_id')
Edward Lemur79d4f992019-11-11 23:49:02 +00001787 messages = sorted(data.get('messages', []), key=lambda m: m.get('date'))
Aaron Gable9ab38c62017-04-06 14:36:33 -07001788 last_message_author = messages.pop().get('author', {})
1789 while last_message_author:
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001790 if last_message_author.get('email') == COMMIT_BOT_EMAIL:
1791 # Ignore replies from CQ.
Aaron Gable9ab38c62017-04-06 14:36:33 -07001792 last_message_author = messages.pop().get('author', {})
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001793 continue
Aaron Gable9ab38c62017-04-06 14:36:33 -07001794 if last_message_author.get('_account_id') == owner:
1795 # Most recent message was by owner.
1796 return 'waiting'
1797 else:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001798 # Some reply from non-owner.
1799 return 'reply'
Aaron Gable9ab38c62017-04-06 14:36:33 -07001800
1801 # Somehow there are no messages even though there are reviewers.
1802 return 'unsent'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001803
1804 def GetMostRecentPatchset(self):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001805 if not self.GetIssue():
1806 return None
1807
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001808 data = self._GetChangeDetail(['CURRENT_REVISION'])
Aaron Gablee8856ee2017-12-07 12:41:46 -08001809 patchset = data['revisions'][data['current_revision']]['_number']
1810 self.SetPatchset(patchset)
1811 return patchset
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001812
Aaron Gable636b13f2017-07-14 10:42:48 -07001813 def AddComment(self, message, publish=None):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001814 gerrit_util.SetReview(
1815 self._GetGerritHost(), self._GerritChangeIdentifier(),
1816 msg=message, ready=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001817
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001818 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01001819 # DETAILED_ACCOUNTS is to get emails in accounts.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001820 # CURRENT_REVISION is included to get the latest patchset so that
1821 # only the robot comments from the latest patchset can be shown.
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001822 messages = self._GetChangeDetail(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001823 options=['MESSAGES', 'DETAILED_ACCOUNTS',
1824 'CURRENT_REVISION']).get('messages', [])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001825 file_comments = gerrit_util.GetChangeComments(
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001826 self._GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001827 robot_file_comments = gerrit_util.GetChangeRobotComments(
1828 self._GetGerritHost(), self._GerritChangeIdentifier())
1829
1830 # Add the robot comments onto the list of comments, but only
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00001831 # keep those that are from the latest patchset.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001832 latest_patch_set = self.GetMostRecentPatchset()
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001833 for path, robot_comments in robot_file_comments.items():
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001834 line_comments = file_comments.setdefault(path, [])
1835 line_comments.extend(
1836 [c for c in robot_comments if c['patch_set'] == latest_patch_set])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001837
1838 # Build dictionary of file comments for easy access and sorting later.
1839 # {author+date: {path: {patchset: {line: url+message}}}}
1840 comments = collections.defaultdict(
1841 lambda: collections.defaultdict(lambda: collections.defaultdict(dict)))
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001842 for path, line_comments in file_comments.items():
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001843 for comment in line_comments:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001844 tag = comment.get('tag', '')
1845 if tag.startswith('autogenerated') and 'robot_id' not in comment:
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001846 continue
1847 key = (comment['author']['email'], comment['updated'])
1848 if comment.get('side', 'REVISION') == 'PARENT':
1849 patchset = 'Base'
1850 else:
1851 patchset = 'PS%d' % comment['patch_set']
1852 line = comment.get('line', 0)
1853 url = ('https://%s/c/%s/%s/%s#%s%s' %
1854 (self._GetGerritHost(), self.GetIssue(), comment['patch_set'], path,
1855 'b' if comment.get('side') == 'PARENT' else '',
1856 str(line) if line else ''))
1857 comments[key][path][patchset][line] = (url, comment['message'])
1858
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001859 summaries = []
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001860 for msg in messages:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001861 summary = self._BuildCommentSummary(msg, comments, readable)
1862 if summary:
1863 summaries.append(summary)
1864 return summaries
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001865
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001866 @staticmethod
1867 def _BuildCommentSummary(msg, comments, readable):
1868 key = (msg['author']['email'], msg['date'])
1869 # Don't bother showing autogenerated messages that don't have associated
1870 # file or line comments. this will filter out most autogenerated
1871 # messages, but will keep robot comments like those from Tricium.
1872 is_autogenerated = msg.get('tag', '').startswith('autogenerated')
1873 if is_autogenerated and not comments.get(key):
1874 return None
1875 message = msg['message']
1876 # Gerrit spits out nanoseconds.
1877 assert len(msg['date'].split('.')[-1]) == 9
1878 date = datetime.datetime.strptime(msg['date'][:-3],
1879 '%Y-%m-%d %H:%M:%S.%f')
1880 if key in comments:
1881 message += '\n'
1882 for path, patchsets in sorted(comments.get(key, {}).items()):
1883 if readable:
1884 message += '\n%s' % path
1885 for patchset, lines in sorted(patchsets.items()):
1886 for line, (url, content) in sorted(lines.items()):
1887 if line:
1888 line_str = 'Line %d' % line
1889 path_str = '%s:%d:' % (path, line)
1890 else:
1891 line_str = 'File comment'
1892 path_str = '%s:0:' % path
1893 if readable:
1894 message += '\n %s, %s: %s' % (patchset, line_str, url)
1895 message += '\n %s\n' % content
1896 else:
1897 message += '\n%s ' % path_str
1898 message += '\n%s\n' % content
1899
1900 return _CommentSummary(
1901 date=date,
1902 message=message,
1903 sender=msg['author']['email'],
1904 autogenerated=is_autogenerated,
1905 # These could be inferred from the text messages and correlated with
1906 # Code-Review label maximum, however this is not reliable.
1907 # Leaving as is until the need arises.
1908 approval=False,
1909 disapproval=False,
1910 )
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001911
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001912 def CloseIssue(self):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001913 gerrit_util.AbandonChange(
1914 self._GetGerritHost(), self._GerritChangeIdentifier(), msg='')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001915
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001916 def SubmitIssue(self, wait_for_merge=True):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001917 gerrit_util.SubmitChange(
1918 self._GetGerritHost(), self._GerritChangeIdentifier(),
1919 wait_for_merge=wait_for_merge)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001920
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00001921 def _GetChangeDetail(self, options=None, no_cache=False):
1922 """Returns details of associated Gerrit change and caching results.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001923
1924 If fresh data is needed, set no_cache=True which will clear cache and
1925 thus new data will be fetched from Gerrit.
1926 """
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00001927 options = options or []
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001928 assert self.GetIssue(), 'issue is required to query Gerrit'
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001929
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001930 # Optimization to avoid multiple RPCs:
1931 if (('CURRENT_REVISION' in options or 'ALL_REVISIONS' in options) and
1932 'CURRENT_COMMIT' not in options):
1933 options.append('CURRENT_COMMIT')
1934
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001935 # Normalize issue and options for consistent keys in cache.
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001936 cache_key = str(self.GetIssue())
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001937 options = [o.upper() for o in options]
1938
1939 # Check in cache first unless no_cache is True.
1940 if no_cache:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001941 self._detail_cache.pop(cache_key, None)
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001942 else:
1943 options_set = frozenset(options)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001944 for cached_options_set, data in self._detail_cache.get(cache_key, []):
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001945 # Assumption: data fetched before with extra options is suitable
1946 # for return for a smaller set of options.
1947 # For example, if we cached data for
1948 # options=[CURRENT_REVISION, DETAILED_FOOTERS]
1949 # and request is for options=[CURRENT_REVISION],
1950 # THEN we can return prior cached data.
1951 if options_set.issubset(cached_options_set):
1952 return data
1953
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001954 try:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001955 data = gerrit_util.GetChangeDetail(
1956 self._GetGerritHost(), self._GerritChangeIdentifier(), options)
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001957 except gerrit_util.GerritError as e:
1958 if e.http_status == 404:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001959 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001960 raise
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001961
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001962 self._detail_cache.setdefault(cache_key, []).append(
1963 (frozenset(options), data))
tandriic2405f52016-10-10 08:13:15 -07001964 return data
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001965
Andrii Shyshkalovcc5f17e2018-08-22 23:35:59 +00001966 def _GetChangeCommit(self):
Andrii Shyshkalove2633162018-08-27 23:50:31 +00001967 assert self.GetIssue(), 'issue must be set to query Gerrit'
Aaron Gable6f5a8d92017-04-18 14:49:05 -07001968 try:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00001969 data = gerrit_util.GetChangeCommit(
1970 self._GetGerritHost(), self._GerritChangeIdentifier())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07001971 except gerrit_util.GerritError as e:
1972 if e.http_status == 404:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00001973 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07001974 raise
agable32978d92016-11-01 12:55:02 -07001975 return data
1976
Karen Qian40c19422019-03-13 21:28:29 +00001977 def _IsCqConfigured(self):
1978 detail = self._GetChangeDetail(['LABELS'])
Andrii Shyshkalov8effa4d2020-01-21 13:23:36 +00001979 return u'Commit-Queue' in detail.get('labels', {})
Karen Qian40c19422019-03-13 21:28:29 +00001980
Olivier Robin75ee7252018-04-13 10:02:56 +02001981 def CMDLand(self, force, bypass_hooks, verbose, parallel):
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001982 if git_common.is_dirty_git_tree('land'):
1983 return 1
Karen Qian40c19422019-03-13 21:28:29 +00001984
tandriid60367b2016-06-22 05:25:12 -07001985 detail = self._GetChangeDetail(['CURRENT_REVISION', 'LABELS'])
Karen Qian40c19422019-03-13 21:28:29 +00001986 if not force and self._IsCqConfigured():
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00001987 confirm_or_exit('\nIt seems this repository has a CQ, '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001988 'which can test and land changes for you. '
1989 'Are you sure you wish to bypass it?\n',
1990 action='bypass CQ')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001991 differs = True
tandriic4344b52016-08-29 06:04:54 -07001992 last_upload = self._GitGetBranchConfigValue('gerritsquashhash')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001993 # Note: git diff outputs nothing if there is no diff.
1994 if not last_upload or RunGit(['diff', last_upload]).strip():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001995 print('WARNING: Some changes from local branch haven\'t been uploaded.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001996 else:
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001997 if detail['current_revision'] == last_upload:
1998 differs = False
1999 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002000 print('WARNING: Local branch contents differ from latest uploaded '
2001 'patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002002 if differs:
2003 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002004 confirm_or_exit(
2005 'Do you want to submit latest Gerrit patchset and bypass hooks?\n',
2006 action='submit')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002007 print('WARNING: Bypassing hooks and submitting latest uploaded patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002008 elif not bypass_hooks:
2009 hook_results = self.RunHook(
2010 committing=True,
2011 may_prompt=not force,
2012 verbose=verbose,
Edward Lemur7f6dec02020-02-06 20:23:58 +00002013 change=self.GetChange(self.GetCommonAncestorWithUpstream()),
Olivier Robin75ee7252018-04-13 10:02:56 +02002014 parallel=parallel)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002015 if not hook_results.should_continue():
2016 return 1
2017
2018 self.SubmitIssue(wait_for_merge=True)
2019 print('Issue %s has been submitted.' % self.GetIssueURL())
agable32978d92016-11-01 12:55:02 -07002020 links = self._GetChangeCommit().get('web_links', [])
2021 for link in links:
Aaron Gable02cdbb42016-12-13 16:24:25 -08002022 if link.get('name') == 'gitiles' and link.get('url'):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002023 print('Landed as: %s' % link.get('url'))
agable32978d92016-11-01 12:55:02 -07002024 break
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002025 return 0
2026
Edward Lemurf38bc172019-09-03 21:02:13 +00002027 def CMDPatchWithParsedIssue(self, parsed_issue_arg, nocommit, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002028 assert parsed_issue_arg.valid
2029
Edward Lemur125d60a2019-09-13 18:25:41 +00002030 self.issue = parsed_issue_arg.issue
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002031
2032 if parsed_issue_arg.hostname:
2033 self._gerrit_host = parsed_issue_arg.hostname
2034 self._gerrit_server = 'https://%s' % self._gerrit_host
2035
tandriic2405f52016-10-10 08:13:15 -07002036 try:
2037 detail = self._GetChangeDetail(['ALL_REVISIONS'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002038 except GerritChangeNotExists as e:
tandriic2405f52016-10-10 08:13:15 -07002039 DieWithError(str(e))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002040
2041 if not parsed_issue_arg.patchset:
2042 # Use current revision by default.
2043 revision_info = detail['revisions'][detail['current_revision']]
2044 patchset = int(revision_info['_number'])
2045 else:
2046 patchset = parsed_issue_arg.patchset
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002047 for revision_info in detail['revisions'].values():
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002048 if int(revision_info['_number']) == parsed_issue_arg.patchset:
2049 break
2050 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08002051 DieWithError('Couldn\'t find patchset %i in change %i' %
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002052 (parsed_issue_arg.patchset, self.GetIssue()))
2053
Edward Lemur125d60a2019-09-13 18:25:41 +00002054 remote_url = self.GetRemoteUrl()
Aaron Gable697a91b2018-01-19 15:20:15 -08002055 if remote_url.endswith('.git'):
2056 remote_url = remote_url[:-len('.git')]
erikchen0d14d0d2018-08-28 18:57:09 +00002057 remote_url = remote_url.rstrip('/')
2058
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002059 fetch_info = revision_info['fetch']['http']
erikchen0d14d0d2018-08-28 18:57:09 +00002060 fetch_info['url'] = fetch_info['url'].rstrip('/')
Aaron Gable697a91b2018-01-19 15:20:15 -08002061
2062 if remote_url != fetch_info['url']:
2063 DieWithError('Trying to patch a change from %s but this repo appears '
2064 'to be %s.' % (fetch_info['url'], remote_url))
2065
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002066 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
Aaron Gable9387b4f2017-06-08 10:50:03 -07002067
Aaron Gable62619a32017-06-16 08:22:09 -07002068 if force:
2069 RunGit(['reset', '--hard', 'FETCH_HEAD'])
2070 print('Checked out commit for change %i patchset %i locally' %
2071 (parsed_issue_arg.issue, patchset))
Stefan Zager2d5f0392017-10-10 15:17:53 -07002072 elif nocommit:
2073 RunGit(['cherry-pick', '--no-commit', 'FETCH_HEAD'])
2074 print('Patch applied to index.')
Aaron Gable62619a32017-06-16 08:22:09 -07002075 else:
Aaron Gable9387b4f2017-06-08 10:50:03 -07002076 RunGit(['cherry-pick', 'FETCH_HEAD'])
2077 print('Committed patch for change %i patchset %i locally.' %
Aaron Gable62619a32017-06-16 08:22:09 -07002078 (parsed_issue_arg.issue, patchset))
2079 print('Note: this created a local commit which does not have '
2080 'the same hash as the one uploaded for review. This will make '
2081 'uploading changes based on top of this branch difficult.\n'
2082 'If you want to do that, use "git cl patch --force" instead.')
2083
Stefan Zagerd08043c2017-10-12 12:07:02 -07002084 if self.GetBranch():
2085 self.SetIssue(parsed_issue_arg.issue)
2086 self.SetPatchset(patchset)
2087 fetched_hash = RunGit(['rev-parse', 'FETCH_HEAD']).strip()
2088 self._GitSetBranchConfigValue('last-upload-hash', fetched_hash)
2089 self._GitSetBranchConfigValue('gerritsquashhash', fetched_hash)
2090 else:
2091 print('WARNING: You are in detached HEAD state.\n'
2092 'The patch has been applied to your checkout, but you will not be '
2093 'able to upload a new patch set to the gerrit issue.\n'
2094 'Try using the \'-b\' option if you would like to work on a '
2095 'branch and/or upload a new patch set.')
2096
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002097 return 0
2098
tandrii16e0b4e2016-06-07 10:34:28 -07002099 def _GerritCommitMsgHookCheck(self, offer_removal):
2100 hook = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
2101 if not os.path.exists(hook):
2102 return
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002103 # Crude attempt to distinguish Gerrit Codereview hook from a potentially
2104 # custom developer-made one.
tandrii16e0b4e2016-06-07 10:34:28 -07002105 data = gclient_utils.FileRead(hook)
2106 if not('From Gerrit Code Review' in data and 'add_ChangeId()' in data):
2107 return
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002108 print('WARNING: You have Gerrit commit-msg hook installed.\n'
qyearsley12fa6ff2016-08-24 09:18:40 -07002109 'It is not necessary for uploading with git cl in squash mode, '
tandrii16e0b4e2016-06-07 10:34:28 -07002110 'and may interfere with it in subtle ways.\n'
2111 'We recommend you remove the commit-msg hook.')
2112 if offer_removal:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002113 if ask_for_explicit_yes('Do you want to remove it now?'):
tandrii16e0b4e2016-06-07 10:34:28 -07002114 gclient_utils.rm_file_or_tree(hook)
2115 print('Gerrit commit-msg hook removed.')
2116 else:
2117 print('OK, will keep Gerrit commit-msg hook in place.')
2118
Edward Lemur1b52d872019-05-09 21:12:12 +00002119 def _CleanUpOldTraces(self):
2120 """Keep only the last |MAX_TRACES| traces."""
2121 try:
2122 traces = sorted([
2123 os.path.join(TRACES_DIR, f)
2124 for f in os.listdir(TRACES_DIR)
2125 if (os.path.isfile(os.path.join(TRACES_DIR, f))
2126 and not f.startswith('tmp'))
2127 ])
2128 traces_to_delete = traces[:-MAX_TRACES]
2129 for trace in traces_to_delete:
Daniel Chengcf6269b2019-05-18 01:02:12 +00002130 os.remove(trace)
Edward Lemur1b52d872019-05-09 21:12:12 +00002131 except OSError:
2132 print('WARNING: Failed to remove old git traces from\n'
2133 ' %s'
2134 'Consider removing them manually.' % TRACES_DIR)
Edward Lemurdc8e23d2019-05-07 00:45:48 +00002135
Edward Lemur5737f022019-05-17 01:24:00 +00002136 def _WriteGitPushTraces(self, trace_name, traces_dir, git_push_metadata):
Edward Lemur1b52d872019-05-09 21:12:12 +00002137 """Zip and write the git push traces stored in traces_dir."""
2138 gclient_utils.safe_makedirs(TRACES_DIR)
Edward Lemur1b52d872019-05-09 21:12:12 +00002139 traces_zip = trace_name + '-traces'
2140 traces_readme = trace_name + '-README'
Michael Mosse7f0b4c2019-05-08 04:36:24 +00002141 # Create a temporary dir to store git config and gitcookies in. It will be
2142 # compressed and stored next to the traces.
2143 git_info_dir = tempfile.mkdtemp()
Edward Lemur1b52d872019-05-09 21:12:12 +00002144 git_info_zip = trace_name + '-git-info'
2145
Edward Lemur5737f022019-05-17 01:24:00 +00002146 git_push_metadata['now'] = datetime_now().strftime('%c')
Eric Boren67c48202019-05-30 16:52:51 +00002147 if sys.stdin.encoding and sys.stdin.encoding != 'utf-8':
sangwoo.ko7a614332019-05-22 02:46:19 +00002148 git_push_metadata['now'] = git_push_metadata['now'].decode(
2149 sys.stdin.encoding)
2150
Edward Lemur1b52d872019-05-09 21:12:12 +00002151 git_push_metadata['trace_name'] = trace_name
2152 gclient_utils.FileWrite(
2153 traces_readme, TRACES_README_FORMAT % git_push_metadata)
2154
2155 # Keep only the first 6 characters of the git hashes on the packet
2156 # trace. This greatly decreases size after compression.
2157 packet_traces = os.path.join(traces_dir, 'trace-packet')
2158 if os.path.isfile(packet_traces):
2159 contents = gclient_utils.FileRead(packet_traces)
2160 gclient_utils.FileWrite(
2161 packet_traces, GIT_HASH_RE.sub(r'\1', contents))
2162 shutil.make_archive(traces_zip, 'zip', traces_dir)
2163
2164 # Collect and compress the git config and gitcookies.
2165 git_config = RunGit(['config', '-l'])
2166 gclient_utils.FileWrite(
2167 os.path.join(git_info_dir, 'git-config'),
2168 git_config)
2169
2170 cookie_auth = gerrit_util.Authenticator.get()
2171 if isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
2172 gitcookies_path = cookie_auth.get_gitcookies_path()
2173 if os.path.isfile(gitcookies_path):
2174 gitcookies = gclient_utils.FileRead(gitcookies_path)
2175 gclient_utils.FileWrite(
2176 os.path.join(git_info_dir, 'gitcookies'),
2177 GITCOOKIES_REDACT_RE.sub('REDACTED', gitcookies))
2178 shutil.make_archive(git_info_zip, 'zip', git_info_dir)
2179
Edward Lemur1b52d872019-05-09 21:12:12 +00002180 gclient_utils.rmtree(git_info_dir)
2181
2182 def _RunGitPushWithTraces(
2183 self, change_desc, refspec, refspec_opts, git_push_metadata):
2184 """Run git push and collect the traces resulting from the execution."""
2185 # Create a temporary directory to store traces in. Traces will be compressed
2186 # and stored in a 'traces' dir inside depot_tools.
2187 traces_dir = tempfile.mkdtemp()
Edward Lemur5737f022019-05-17 01:24:00 +00002188 trace_name = os.path.join(
2189 TRACES_DIR, datetime_now().strftime('%Y%m%dT%H%M%S.%f'))
Edward Lemur0f58ae42019-04-30 17:24:12 +00002190
2191 env = os.environ.copy()
2192 env['GIT_REDACT_COOKIES'] = 'o,SSO,GSSO_Uberproxy'
2193 env['GIT_TR2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Jonathan Nieder9779b142019-05-29 23:19:29 +00002194 env['GIT_TRACE2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002195 env['GIT_TRACE_CURL'] = os.path.join(traces_dir, 'trace-curl')
2196 env['GIT_TRACE_CURL_NO_DATA'] = '1'
2197 env['GIT_TRACE_PACKET'] = os.path.join(traces_dir, 'trace-packet')
2198
2199 try:
2200 push_returncode = 0
Edward Lemur1b52d872019-05-09 21:12:12 +00002201 remote_url = self.GetRemoteUrl()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002202 before_push = time_time()
2203 push_stdout = gclient_utils.CheckCallAndFilter(
Edward Lemur1b52d872019-05-09 21:12:12 +00002204 ['git', 'push', remote_url, refspec],
Edward Lemur0f58ae42019-04-30 17:24:12 +00002205 env=env,
2206 print_stdout=True,
2207 # Flush after every line: useful for seeing progress when running as
2208 # recipe.
2209 filter_fn=lambda _: sys.stdout.flush())
Edward Lemur79d4f992019-11-11 23:49:02 +00002210 push_stdout = push_stdout.decode('utf-8', 'replace')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002211 except subprocess2.CalledProcessError as e:
2212 push_returncode = e.returncode
2213 DieWithError('Failed to create a change. Please examine output above '
2214 'for the reason of the failure.\n'
2215 'Hint: run command below to diagnose common Git/Gerrit '
2216 'credential problems:\n'
Edward Lemur5737f022019-05-17 01:24:00 +00002217 ' git cl creds-check\n'
2218 '\n'
2219 'If git-cl is not working correctly, file a bug under the '
2220 'Infra>SDK component including the files below.\n'
2221 'Review the files before upload, since they might contain '
2222 'sensitive information.\n'
2223 'Set the Restrict-View-Google label so that they are not '
2224 'publicly accessible.\n'
2225 + TRACES_MESSAGE % {'trace_name': trace_name},
Edward Lemur0f58ae42019-04-30 17:24:12 +00002226 change_desc)
2227 finally:
2228 execution_time = time_time() - before_push
2229 metrics.collector.add_repeated('sub_commands', {
2230 'command': 'git push',
2231 'execution_time': execution_time,
2232 'exit_code': push_returncode,
2233 'arguments': metrics_utils.extract_known_subcommand_args(refspec_opts),
2234 })
2235
Edward Lemur1b52d872019-05-09 21:12:12 +00002236 git_push_metadata['execution_time'] = execution_time
2237 git_push_metadata['exit_code'] = push_returncode
Edward Lemur5737f022019-05-17 01:24:00 +00002238 self._WriteGitPushTraces(trace_name, traces_dir, git_push_metadata)
Edward Lemur0f58ae42019-04-30 17:24:12 +00002239
Edward Lemur1b52d872019-05-09 21:12:12 +00002240 self._CleanUpOldTraces()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002241 gclient_utils.rmtree(traces_dir)
2242
2243 return push_stdout
2244
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002245 def CMDUploadChange(self, options, git_diff_args, custom_cl_base, change):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002246 """Upload the current branch to Gerrit."""
Mike Frysingera989d552019-08-14 20:51:23 +00002247 if options.squash is None:
tandriia60502f2016-06-20 02:01:53 -07002248 # Load default for user, repo, squash=true, in this order.
2249 options.squash = settings.GetSquashGerritUploads()
tandrii26f3e4e2016-06-10 08:37:04 -07002250
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002251 remote, remote_branch = self.GetRemoteBranch()
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01002252 branch = GetTargetRef(remote, remote_branch, options.target_branch)
Aaron Gableb56ad332017-01-06 15:24:31 -08002253 # This may be None; default fallback value is determined in logic below.
2254 title = options.title
2255
Dominic Battre7d1c4842017-10-27 09:17:28 +02002256 # Extract bug number from branch name.
2257 bug = options.bug
Dan Beamd8b04ca2019-10-10 21:23:26 +00002258 fixed = options.fixed
2259 match = re.match(r'(?P<type>bug|fix(?:e[sd])?)[_-]?(?P<bugnum>\d+)',
2260 self.GetBranch())
2261 if not bug and not fixed and match:
2262 if match.group('type') == 'bug':
2263 bug = match.group('bugnum')
2264 else:
2265 fixed = match.group('bugnum')
Dominic Battre7d1c4842017-10-27 09:17:28 +02002266
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002267 if options.squash:
tandrii16e0b4e2016-06-07 10:34:28 -07002268 self._GerritCommitMsgHookCheck(offer_removal=not options.force)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002269 if self.GetIssue():
2270 # Try to get the message from a previous upload.
Edward Lemur6c6827c2020-02-06 21:15:18 +00002271 message = self.FetchDescription()
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002272 if not message:
2273 DieWithError(
Aaron Gablea45ee112016-11-22 15:14:38 -08002274 'failed to fetch description from current Gerrit change %d\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002275 '%s' % (self.GetIssue(), self.GetIssueURL()))
Aaron Gableb56ad332017-01-06 15:24:31 -08002276 if not title:
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002277 if options.message:
Aaron Gable7303dcb2017-06-07 14:17:32 -07002278 # When uploading a subsequent patchset, -m|--message is taken
2279 # as the patchset title if --title was not provided.
2280 title = options.message.strip()
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002281 else:
2282 default_title = RunGit(
2283 ['show', '-s', '--format=%s', 'HEAD']).strip()
Aaron Gable7303dcb2017-06-07 14:17:32 -07002284 if options.force:
2285 title = default_title
2286 else:
2287 title = ask_for_data(
2288 'Title for patchset [%s]: ' % default_title) or default_title
Josipe827b0f2020-01-30 00:07:20 +00002289
2290 # User requested to change description
2291 if options.edit_description:
2292 change_desc = ChangeDescription(message, bug=bug, fixed=fixed)
2293 change_desc.prompt()
2294 message = change_desc.description
2295
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002296 change_id = self._GetChangeDetail()['change_id']
2297 while True:
2298 footer_change_ids = git_footers.get_footer_change_id(message)
2299 if footer_change_ids == [change_id]:
2300 break
2301 if not footer_change_ids:
2302 message = git_footers.add_footer_change_id(message, change_id)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002303 print('WARNING: appended missing Change-Id to change description.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002304 continue
2305 # There is already a valid footer but with different or several ids.
2306 # Doing this automatically is non-trivial as we don't want to lose
2307 # existing other footers, yet we want to append just 1 desired
2308 # Change-Id. Thus, just create a new footer, but let user verify the
2309 # new description.
2310 message = '%s\n\nChange-Id: %s' % (message, change_id)
Dan Beamd8b04ca2019-10-10 21:23:26 +00002311 change_desc = ChangeDescription(message, bug=bug, fixed=fixed)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002312 if not options.force:
Anthony Polito8b955342019-09-24 19:01:36 +00002313 print(
2314 'WARNING: change %s has Change-Id footer(s):\n'
2315 ' %s\n'
2316 'but change has Change-Id %s, according to Gerrit.\n'
2317 'Please, check the proposed correction to the description, '
2318 'and edit it if necessary but keep the "Change-Id: %s" footer\n'
2319 % (self.GetIssue(), '\n '.join(footer_change_ids), change_id,
2320 change_id))
2321 confirm_or_exit(action='edit')
2322 change_desc.prompt()
2323
2324 message = change_desc.description
2325 if not message:
2326 DieWithError("Description is empty. Aborting...")
2327
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002328 # Continue the while loop.
2329 # Sanity check of this code - we should end up with proper message
2330 # footer.
2331 assert [change_id] == git_footers.get_footer_change_id(message)
Dan Beamd8b04ca2019-10-10 21:23:26 +00002332 change_desc = ChangeDescription(message, bug=bug, fixed=fixed)
Aaron Gableb56ad332017-01-06 15:24:31 -08002333 else: # if not self.GetIssue()
2334 if options.message:
2335 message = options.message
2336 else:
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002337 message = _create_description_from_log(git_diff_args)
Aaron Gableb56ad332017-01-06 15:24:31 -08002338 if options.title:
2339 message = options.title + '\n\n' + message
Dan Beamd8b04ca2019-10-10 21:23:26 +00002340 change_desc = ChangeDescription(message, bug=bug, fixed=fixed)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002341 if not options.force:
Anthony Polito8b955342019-09-24 19:01:36 +00002342 change_desc.prompt()
2343
Aaron Gableb56ad332017-01-06 15:24:31 -08002344 # On first upload, patchset title is always this string, while
2345 # --title flag gets converted to first line of message.
2346 title = 'Initial upload'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002347 if not change_desc.description:
2348 DieWithError("Description is empty. Aborting...")
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002349 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002350 if len(change_ids) > 1:
2351 DieWithError('too many Change-Id footers, at most 1 allowed.')
2352 if not change_ids:
2353 # Generate the Change-Id automatically.
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002354 change_desc.set_description(git_footers.add_footer_change_id(
2355 change_desc.description,
2356 GenerateGerritChangeId(change_desc.description)))
2357 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002358 assert len(change_ids) == 1
2359 change_id = change_ids[0]
2360
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002361 if options.reviewers or options.tbrs or options.add_owners_to:
2362 change_desc.update_reviewers(options.reviewers, options.tbrs,
2363 options.add_owners_to, change)
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002364 if options.preserve_tryjobs:
2365 change_desc.set_preserve_tryjobs()
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002366
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002367 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002368 parent = self._ComputeParent(remote, upstream_branch, custom_cl_base,
2369 options.force, change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002370 tree = RunGit(['rev-parse', 'HEAD:']).strip()
Edward Lesmesf6a22322019-11-04 22:14:39 +00002371 with tempfile.NamedTemporaryFile(delete=False) as desc_tempfile:
Edward Lemur79d4f992019-11-11 23:49:02 +00002372 desc_tempfile.write(change_desc.description.encode('utf-8', 'replace'))
Aaron Gable9a03ae02017-11-03 11:31:07 -07002373 desc_tempfile.close()
2374 ref_to_push = RunGit(['commit-tree', tree, '-p', parent,
2375 '-F', desc_tempfile.name]).strip()
2376 os.remove(desc_tempfile.name)
Anthony Polito8b955342019-09-24 19:01:36 +00002377 else: # if not options.squash
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002378 change_desc = ChangeDescription(
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002379 options.message or _create_description_from_log(git_diff_args))
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002380 if not change_desc.description:
2381 DieWithError("Description is empty. Aborting...")
2382
2383 if not git_footers.get_footer_change_id(change_desc.description):
2384 DownloadGerritHook(False)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002385 change_desc.set_description(
2386 self._AddChangeIdToCommitMessage(options, git_diff_args))
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002387 if options.reviewers or options.tbrs or options.add_owners_to:
2388 change_desc.update_reviewers(options.reviewers, options.tbrs,
2389 options.add_owners_to, change)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002390 ref_to_push = 'HEAD'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002391 # For no-squash mode, we assume the remote called "origin" is the one we
2392 # want. It is not worthwhile to support different workflows for
2393 # no-squash mode.
2394 parent = 'origin/%s' % branch
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002395 change_id = git_footers.get_footer_change_id(change_desc.description)[0]
2396
2397 assert change_desc
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00002398 SaveDescriptionBackup(change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002399 commits = RunGitSilent(['rev-list', '%s..%s' % (parent,
2400 ref_to_push)]).splitlines()
2401 if len(commits) > 1:
2402 print('WARNING: This will upload %d commits. Run the following command '
2403 'to see which commits will be uploaded: ' % len(commits))
2404 print('git log %s..%s' % (parent, ref_to_push))
2405 print('You can also use `git squash-branch` to squash these into a '
2406 'single commit.')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002407 confirm_or_exit(action='upload')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002408
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002409 if options.reviewers or options.tbrs or options.add_owners_to:
2410 change_desc.update_reviewers(options.reviewers, options.tbrs,
2411 options.add_owners_to, change)
2412
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002413 reviewers = sorted(change_desc.get_reviewers())
Edward Lemur4508b422019-10-03 21:56:35 +00002414 cc = []
2415 # Add CCs from WATCHLISTS and rietveld.cc git config unless this is
2416 # the initial upload, the CL is private, or auto-CCing has ben disabled.
2417 if not (self.GetIssue() or options.private or options.no_autocc):
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002418 cc = self.GetCCList().split(',')
Edward Lemur4508b422019-10-03 21:56:35 +00002419 # Add cc's from the --cc flag.
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002420 if options.cc:
2421 cc.extend(options.cc)
Edward Lemur79d4f992019-11-11 23:49:02 +00002422 cc = [email.strip() for email in cc if email.strip()]
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002423 if change_desc.get_cced():
2424 cc.extend(change_desc.get_cced())
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00002425 if self._GetGerritHost() == 'chromium-review.googlesource.com':
2426 valid_accounts = set(reviewers + cc)
2427 # TODO(crbug/877717): relax this for all hosts.
2428 else:
2429 valid_accounts = gerrit_util.ValidAccounts(
2430 self._GetGerritHost(), reviewers + cc)
Andrii Shyshkalovf170af42018-10-30 07:00:44 +00002431 logging.info('accounts %s are recognized, %s invalid',
2432 sorted(valid_accounts),
2433 set(reviewers + cc).difference(set(valid_accounts)))
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002434
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002435 # Extra options that can be specified at push time. Doc:
2436 # https://gerrit-review.googlesource.com/Documentation/user-upload.html
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002437 refspec_opts = []
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002438
Aaron Gable844cf292017-06-28 11:32:59 -07002439 # By default, new changes are started in WIP mode, and subsequent patchsets
2440 # don't send email. At any time, passing --send-mail will mark the change
2441 # ready and send email for that particular patch.
Aaron Gableafd52772017-06-27 16:40:10 -07002442 if options.send_mail:
2443 refspec_opts.append('ready')
Aaron Gable844cf292017-06-28 11:32:59 -07002444 refspec_opts.append('notify=ALL')
Jamie Madill276da0b2018-04-27 14:41:20 -04002445 elif not self.GetIssue() and options.squash:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002446 refspec_opts.append('wip')
Aaron Gableafd52772017-06-27 16:40:10 -07002447 else:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002448 refspec_opts.append('notify=NONE')
Aaron Gable70f4e242017-06-26 10:45:59 -07002449
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002450 # TODO(tandrii): options.message should be posted as a comment
Aaron Gablee5adf612017-07-14 10:43:58 -07002451 # if --send-mail is set on non-initial upload as Rietveld used to do it.
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002452
Aaron Gable9b713dd2016-12-14 16:04:21 -08002453 if title:
Nick Carter8692b182017-11-06 16:30:38 -08002454 # Punctuation and whitespace in |title| must be percent-encoded.
2455 refspec_opts.append('m=' + gerrit_util.PercentEncodeForGitRef(title))
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002456
agablec6787972016-09-09 16:13:34 -07002457 if options.private:
Aaron Gableb02daf02017-05-23 11:53:46 -07002458 refspec_opts.append('private')
agablec6787972016-09-09 16:13:34 -07002459
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002460 for r in sorted(reviewers):
2461 if r in valid_accounts:
2462 refspec_opts.append('r=%s' % r)
2463 reviewers.remove(r)
2464 else:
2465 # TODO(tandrii): this should probably be a hard failure.
2466 print('WARNING: reviewer %s doesn\'t have a Gerrit account, skipping'
2467 % r)
2468 for c in sorted(cc):
2469 # refspec option will be rejected if cc doesn't correspond to an
2470 # account, even though REST call to add such arbitrary cc may succeed.
2471 if c in valid_accounts:
2472 refspec_opts.append('cc=%s' % c)
2473 cc.remove(c)
2474
rmistry9eadede2016-09-19 11:22:43 -07002475 if options.topic:
2476 # Documentation on Gerrit topics is here:
2477 # https://gerrit-review.googlesource.com/Documentation/user-upload.html#topic
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002478 refspec_opts.append('topic=%s' % options.topic)
rmistry9eadede2016-09-19 11:22:43 -07002479
Edward Lemur687ca902018-12-05 02:30:30 +00002480 if options.enable_auto_submit:
2481 refspec_opts.append('l=Auto-Submit+1')
2482 if options.use_commit_queue:
2483 refspec_opts.append('l=Commit-Queue+2')
2484 elif options.cq_dry_run:
2485 refspec_opts.append('l=Commit-Queue+1')
2486
2487 if change_desc.get_reviewers(tbr_only=True):
2488 score = gerrit_util.GetCodeReviewTbrScore(
2489 self._GetGerritHost(),
2490 self._GetGerritProject())
2491 refspec_opts.append('l=Code-Review+%s' % score)
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00002492
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002493 # Gerrit sorts hashtags, so order is not important.
Nodir Turakulov23b82142017-11-16 11:04:25 -08002494 hashtags = {change_desc.sanitize_hash_tag(t) for t in options.hashtags}
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002495 if not self.GetIssue():
Nodir Turakulov23b82142017-11-16 11:04:25 -08002496 hashtags.update(change_desc.get_hash_tags())
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002497 refspec_opts += ['hashtag=%s' % t for t in sorted(hashtags)]
2498
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002499 refspec_suffix = ''
2500 if refspec_opts:
2501 refspec_suffix = '%' + ','.join(refspec_opts)
2502 assert ' ' not in refspec_suffix, (
2503 'spaces not allowed in refspec: "%s"' % refspec_suffix)
2504 refspec = '%s:refs/for/%s%s' % (ref_to_push, branch, refspec_suffix)
2505
Edward Lemur1b52d872019-05-09 21:12:12 +00002506 git_push_metadata = {
2507 'gerrit_host': self._GetGerritHost(),
2508 'title': title or '<untitled>',
2509 'change_id': change_id,
2510 'description': change_desc.description,
2511 }
2512 push_stdout = self._RunGitPushWithTraces(
2513 change_desc, refspec, refspec_opts, git_push_metadata)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002514
2515 if options.squash:
Aaron Gable289b4312017-09-13 14:06:16 -07002516 regex = re.compile(r'remote:\s+https?://[\w\-\.\+\/#]*/(\d+)\s.*')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002517 change_numbers = [m.group(1)
2518 for m in map(regex.match, push_stdout.splitlines())
2519 if m]
2520 if len(change_numbers) != 1:
2521 DieWithError(
2522 ('Created|Updated %d issues on Gerrit, but only 1 expected.\n'
Christopher Lamf732cd52017-01-24 12:40:11 +11002523 'Change-Id: %s') % (len(change_numbers), change_id), change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002524 self.SetIssue(change_numbers[0])
tandrii5d48c322016-08-18 16:19:37 -07002525 self._GitSetBranchConfigValue('gerritsquashhash', ref_to_push)
tandrii88189772016-09-29 04:29:57 -07002526
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002527 if self.GetIssue() and (reviewers or cc):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002528 # GetIssue() is not set in case of non-squash uploads according to tests.
2529 # TODO(agable): non-squash uploads in git cl should be removed.
2530 gerrit_util.AddReviewers(
2531 self._GetGerritHost(),
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00002532 self._GerritChangeIdentifier(),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002533 reviewers, cc,
2534 notify=bool(options.send_mail))
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002535
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002536 return 0
2537
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002538 def _ComputeParent(self, remote, upstream_branch, custom_cl_base, force,
2539 change_desc):
2540 """Computes parent of the generated commit to be uploaded to Gerrit.
2541
2542 Returns revision or a ref name.
2543 """
2544 if custom_cl_base:
2545 # Try to avoid creating additional unintended CLs when uploading, unless
2546 # user wants to take this risk.
2547 local_ref_of_target_remote = self.GetRemoteBranch()[1]
2548 code, _ = RunGitWithCode(['merge-base', '--is-ancestor', custom_cl_base,
2549 local_ref_of_target_remote])
2550 if code == 1:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002551 print('\nWARNING: Manually specified base of this CL `%s` '
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002552 'doesn\'t seem to belong to target remote branch `%s`.\n\n'
2553 'If you proceed with upload, more than 1 CL may be created by '
2554 'Gerrit as a result, in turn confusing or crashing git cl.\n\n'
2555 'If you are certain that specified base `%s` has already been '
2556 'uploaded to Gerrit as another CL, you may proceed.\n' %
2557 (custom_cl_base, local_ref_of_target_remote, custom_cl_base))
2558 if not force:
2559 confirm_or_exit(
2560 'Do you take responsibility for cleaning up potential mess '
2561 'resulting from proceeding with upload?',
2562 action='upload')
2563 return custom_cl_base
2564
Aaron Gablef97e33d2017-03-30 15:44:27 -07002565 if remote != '.':
2566 return self.GetCommonAncestorWithUpstream()
2567
2568 # If our upstream branch is local, we base our squashed commit on its
2569 # squashed version.
2570 upstream_branch_name = scm.GIT.ShortBranchName(upstream_branch)
2571
Aaron Gablef97e33d2017-03-30 15:44:27 -07002572 if upstream_branch_name == 'master':
Aaron Gable0bbd1c22017-05-08 14:37:08 -07002573 return self.GetCommonAncestorWithUpstream()
Aaron Gablef97e33d2017-03-30 15:44:27 -07002574
2575 # Check the squashed hash of the parent.
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002576 # TODO(tandrii): consider checking parent change in Gerrit and using its
2577 # hash if tree hash of latest parent revision (patchset) in Gerrit matches
2578 # the tree hash of the parent branch. The upside is less likely bogus
2579 # requests to reupload parent change just because it's uploadhash is
2580 # missing, yet the downside likely exists, too (albeit unknown to me yet).
Aaron Gablef97e33d2017-03-30 15:44:27 -07002581 parent = RunGit(['config',
2582 'branch.%s.gerritsquashhash' % upstream_branch_name],
2583 error_ok=True).strip()
2584 # Verify that the upstream branch has been uploaded too, otherwise
2585 # Gerrit will create additional CLs when uploading.
2586 if not parent or (RunGitSilent(['rev-parse', upstream_branch + ':']) !=
2587 RunGitSilent(['rev-parse', parent + ':'])):
2588 DieWithError(
2589 '\nUpload upstream branch %s first.\n'
2590 'It is likely that this branch has been rebased since its last '
2591 'upload, so you just need to upload it again.\n'
2592 '(If you uploaded it with --no-squash, then branch dependencies '
2593 'are not supported, and you should reupload with --squash.)'
2594 % upstream_branch_name,
2595 change_desc)
2596 return parent
2597
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002598 def _AddChangeIdToCommitMessage(self, options, args):
2599 """Re-commits using the current message, assumes the commit hook is in
2600 place.
2601 """
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002602 log_desc = options.message or _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002603 git_command = ['commit', '--amend', '-m', log_desc]
2604 RunGit(git_command)
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002605 new_log_desc = _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002606 if git_footers.get_footer_change_id(new_log_desc):
vapiera7fbd5a2016-06-16 09:17:49 -07002607 print('git-cl: Added Change-Id to commit message.')
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002608 return new_log_desc
2609 else:
tandrii@chromium.orgb067ec52016-05-31 15:24:44 +00002610 DieWithError('ERROR: Gerrit commit-msg hook not installed.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002611
tandriie113dfd2016-10-11 10:20:12 -07002612 def CannotTriggerTryJobReason(self):
tandrii8c5a3532016-11-04 07:52:02 -07002613 try:
2614 data = self._GetChangeDetail()
Aaron Gablea45ee112016-11-22 15:14:38 -08002615 except GerritChangeNotExists:
2616 return 'Gerrit doesn\'t know about your change %s' % self.GetIssue()
tandrii8c5a3532016-11-04 07:52:02 -07002617
2618 if data['status'] in ('ABANDONED', 'MERGED'):
2619 return 'CL %s is closed' % self.GetIssue()
2620
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002621 def GetGerritChange(self, patchset=None):
2622 """Returns a buildbucket.v2.GerritChange message for the current issue."""
Edward Lemur79d4f992019-11-11 23:49:02 +00002623 host = urllib.parse.urlparse(self.GetCodereviewServer()).hostname
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002624 issue = self.GetIssue()
Edward Lemur2c210a42019-09-16 23:58:35 +00002625 patchset = int(patchset or self.GetPatchset())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002626 data = self._GetChangeDetail(['ALL_REVISIONS'])
2627
2628 assert host and issue and patchset, 'CL must be uploaded first'
2629
2630 has_patchset = any(
2631 int(revision_data['_number']) == patchset
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002632 for revision_data in data['revisions'].values())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002633 if not has_patchset:
Aaron Gablea45ee112016-11-22 15:14:38 -08002634 raise Exception('Patchset %d is not known in Gerrit change %d' %
tandrii8c5a3532016-11-04 07:52:02 -07002635 (patchset, self.GetIssue()))
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002636
tandrii8c5a3532016-11-04 07:52:02 -07002637 return {
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002638 'host': host,
2639 'change': issue,
2640 'project': data['project'],
2641 'patchset': patchset,
tandrii8c5a3532016-11-04 07:52:02 -07002642 }
tandriie113dfd2016-10-11 10:20:12 -07002643
tandriide281ae2016-10-12 06:02:30 -07002644 def GetIssueOwner(self):
tandrii8c5a3532016-11-04 07:52:02 -07002645 return self._GetChangeDetail(['DETAILED_ACCOUNTS'])['owner']['email']
tandriide281ae2016-10-12 06:02:30 -07002646
Edward Lemur707d70b2018-02-07 00:50:14 +01002647 def GetReviewers(self):
2648 details = self._GetChangeDetail(['DETAILED_ACCOUNTS'])
Mohamed Heikal171c0742018-11-09 20:38:51 +00002649 return [r['email'] for r in details['reviewers'].get('REVIEWER', [])]
Edward Lemur707d70b2018-02-07 00:50:14 +01002650
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002651
tandriif9aefb72016-07-01 09:06:51 -07002652def _get_bug_line_values(default_project, bugs):
2653 """Given default_project and comma separated list of bugs, yields bug line
2654 values.
2655
2656 Each bug can be either:
2657 * a number, which is combined with default_project
2658 * string, which is left as is.
2659
2660 This function may produce more than one line, because bugdroid expects one
2661 project per line.
2662
2663 >>> list(_get_bug_line_values('v8', '123,chromium:789'))
2664 ['v8:123', 'chromium:789']
2665 """
2666 default_bugs = []
2667 others = []
2668 for bug in bugs.split(','):
2669 bug = bug.strip()
2670 if bug:
2671 try:
2672 default_bugs.append(int(bug))
2673 except ValueError:
2674 others.append(bug)
2675
2676 if default_bugs:
2677 default_bugs = ','.join(map(str, default_bugs))
2678 if default_project:
2679 yield '%s:%s' % (default_project, default_bugs)
2680 else:
2681 yield default_bugs
2682 for other in sorted(others):
2683 # Don't bother finding common prefixes, CLs with >2 bugs are very very rare.
2684 yield other
2685
2686
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002687class ChangeDescription(object):
2688 """Contains a parsed form of the change description."""
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00002689 R_LINE = r'^[ \t]*(TBR|R)[ \t]*=[ \t]*(.*?)[ \t]*$'
bradnelsond975b302016-10-23 12:20:23 -07002690 CC_LINE = r'^[ \t]*(CC)[ \t]*=[ \t]*(.*?)[ \t]*$'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002691 BUG_LINE = r'^[ \t]*(?:(BUG)[ \t]*=|Bug:)[ \t]*(.*?)[ \t]*$'
Dan Beamd8b04ca2019-10-10 21:23:26 +00002692 FIXED_LINE = r'^[ \t]*Fixed[ \t]*:[ \t]*(.*?)[ \t]*$'
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002693 CHERRY_PICK_LINE = r'^\(cherry picked from commit [a-fA-F0-9]{40}\)$'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002694 STRIP_HASH_TAG_PREFIX = r'^(\s*(revert|reland)( "|:)?\s*)*'
2695 BRACKET_HASH_TAG = r'\s*\[([^\[\]]+)\]'
Anthony Polito02b5af32019-12-02 19:49:47 +00002696 COLON_SEPARATED_HASH_TAG = r'^([a-zA-Z0-9_\- ]+):($|[^:])'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002697 BAD_HASH_TAG_CHUNK = r'[^a-zA-Z0-9]+'
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002698
Dan Beamd8b04ca2019-10-10 21:23:26 +00002699 def __init__(self, description, bug=None, fixed=None):
agable@chromium.org42c20792013-09-12 17:34:49 +00002700 self._description_lines = (description or '').strip().splitlines()
Anthony Polito8b955342019-09-24 19:01:36 +00002701 if bug:
2702 regexp = re.compile(self.BUG_LINE)
2703 prefix = settings.GetBugPrefix()
2704 if not any((regexp.match(line) for line in self._description_lines)):
2705 values = list(_get_bug_line_values(prefix, bug))
2706 self.append_footer('Bug: %s' % ', '.join(values))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002707 if fixed:
2708 regexp = re.compile(self.FIXED_LINE)
2709 prefix = settings.GetBugPrefix()
2710 if not any((regexp.match(line) for line in self._description_lines)):
2711 values = list(_get_bug_line_values(prefix, fixed))
2712 self.append_footer('Fixed: %s' % ', '.join(values))
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002713
agable@chromium.org42c20792013-09-12 17:34:49 +00002714 @property # www.logilab.org/ticket/89786
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08002715 def description(self): # pylint: disable=method-hidden
agable@chromium.org42c20792013-09-12 17:34:49 +00002716 return '\n'.join(self._description_lines)
2717
2718 def set_description(self, desc):
2719 if isinstance(desc, basestring):
2720 lines = desc.splitlines()
2721 else:
2722 lines = [line.rstrip() for line in desc]
2723 while lines and not lines[0]:
2724 lines.pop(0)
2725 while lines and not lines[-1]:
2726 lines.pop(-1)
2727 self._description_lines = lines
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002728
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002729 def update_reviewers(self, reviewers, tbrs, add_owners_to=None, change=None):
2730 """Rewrites the R=/TBR= line(s) as a single line each.
2731
2732 Args:
2733 reviewers (list(str)) - list of additional emails to use for reviewers.
2734 tbrs (list(str)) - list of additional emails to use for TBRs.
2735 add_owners_to (None|'R'|'TBR') - Pass to do an OWNERS lookup for files in
2736 the change that are missing OWNER coverage. If this is not None, you
2737 must also pass a value for `change`.
2738 change (Change) - The Change that should be used for OWNERS lookups.
2739 """
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002740 assert isinstance(reviewers, list), reviewers
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002741 assert isinstance(tbrs, list), tbrs
2742
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002743 assert add_owners_to in (None, 'TBR', 'R'), add_owners_to
Robert Iannuccia28592e2017-04-18 13:14:49 -07002744 assert not add_owners_to or change, add_owners_to
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002745
2746 if not reviewers and not tbrs and not add_owners_to:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002747 return
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002748
2749 reviewers = set(reviewers)
2750 tbrs = set(tbrs)
2751 LOOKUP = {
2752 'TBR': tbrs,
2753 'R': reviewers,
2754 }
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002755
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002756 # Get the set of R= and TBR= lines and remove them from the description.
agable@chromium.org42c20792013-09-12 17:34:49 +00002757 regexp = re.compile(self.R_LINE)
2758 matches = [regexp.match(line) for line in self._description_lines]
2759 new_desc = [l for i, l in enumerate(self._description_lines)
2760 if not matches[i]]
2761 self.set_description(new_desc)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002762
agable@chromium.org42c20792013-09-12 17:34:49 +00002763 # Construct new unified R= and TBR= lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002764
2765 # First, update tbrs/reviewers with names from the R=/TBR= lines (if any).
agable@chromium.org42c20792013-09-12 17:34:49 +00002766 for match in matches:
2767 if not match:
2768 continue
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002769 LOOKUP[match.group(1)].update(cleanup_list([match.group(2).strip()]))
2770
2771 # Next, maybe fill in OWNERS coverage gaps to either tbrs/reviewers.
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002772 if add_owners_to:
piman@chromium.org336f9122014-09-04 02:16:55 +00002773 owners_db = owners.Database(change.RepositoryRoot(),
Jochen Eisinger72606f82017-04-04 10:44:18 +02002774 fopen=file, os_path=os.path)
piman@chromium.org336f9122014-09-04 02:16:55 +00002775 missing_files = owners_db.files_not_covered_by(change.LocalPaths(),
Robert Iannucci100aa212017-04-18 17:28:26 -07002776 (tbrs | reviewers))
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002777 LOOKUP[add_owners_to].update(
2778 owners_db.reviewers_for(missing_files, change.author_email))
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002779
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002780 # If any folks ended up in both groups, remove them from tbrs.
2781 tbrs -= reviewers
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002782
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002783 new_r_line = 'R=' + ', '.join(sorted(reviewers)) if reviewers else None
2784 new_tbr_line = 'TBR=' + ', '.join(sorted(tbrs)) if tbrs else None
agable@chromium.org42c20792013-09-12 17:34:49 +00002785
2786 # Put the new lines in the description where the old first R= line was.
2787 line_loc = next((i for i, match in enumerate(matches) if match), -1)
2788 if 0 <= line_loc < len(self._description_lines):
2789 if new_tbr_line:
2790 self._description_lines.insert(line_loc, new_tbr_line)
2791 if new_r_line:
2792 self._description_lines.insert(line_loc, new_r_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002793 else:
agable@chromium.org42c20792013-09-12 17:34:49 +00002794 if new_r_line:
2795 self.append_footer(new_r_line)
2796 if new_tbr_line:
2797 self.append_footer(new_tbr_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002798
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002799 def set_preserve_tryjobs(self):
2800 """Ensures description footer contains 'Cq-Do-Not-Cancel-Tryjobs: true'."""
2801 footers = git_footers.parse_footers(self.description)
2802 for v in footers.get('Cq-Do-Not-Cancel-Tryjobs', []):
2803 if v.lower() == 'true':
2804 return
2805 self.append_footer('Cq-Do-Not-Cancel-Tryjobs: true')
2806
Anthony Polito8b955342019-09-24 19:01:36 +00002807 def prompt(self):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002808 """Asks the user to update the description."""
agable@chromium.org42c20792013-09-12 17:34:49 +00002809 self.set_description([
2810 '# Enter a description of the change.',
2811 '# This will be displayed on the codereview site.',
2812 '# The first line will also be used as the subject of the review.',
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +00002813 '#--------------------This line is 72 characters long'
agable@chromium.org42c20792013-09-12 17:34:49 +00002814 '--------------------',
2815 ] + self._description_lines)
Dan Beamd8b04ca2019-10-10 21:23:26 +00002816 bug_regexp = re.compile(self.BUG_LINE)
2817 fixed_regexp = re.compile(self.FIXED_LINE)
Jonas Termansend0f79112019-03-22 15:28:26 +00002818 prefix = settings.GetBugPrefix()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002819 has_issue = lambda l: bug_regexp.match(l) or fixed_regexp.match(l)
2820 if not any((has_issue(line) for line in self._description_lines)):
Anthony Polito8b955342019-09-24 19:01:36 +00002821 self.append_footer('Bug: %s' % prefix)
tandriif9aefb72016-07-01 09:06:51 -07002822
agable@chromium.org42c20792013-09-12 17:34:49 +00002823 content = gclient_utils.RunEditor(self.description, True,
Edward Lemur79d4f992019-11-11 23:49:02 +00002824 git_editor=settings.GetGitEditor())
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00002825 if not content:
2826 DieWithError('Running editor failed')
agable@chromium.org42c20792013-09-12 17:34:49 +00002827 lines = content.splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002828
Bruce Dawson2377b012018-01-11 16:46:49 -08002829 # Strip off comments and default inserted "Bug:" line.
2830 clean_lines = [line.rstrip() for line in lines if not
Jonas Termansend0f79112019-03-22 15:28:26 +00002831 (line.startswith('#') or
2832 line.rstrip() == "Bug:" or
2833 line.rstrip() == "Bug: " + prefix)]
agable@chromium.org42c20792013-09-12 17:34:49 +00002834 if not clean_lines:
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00002835 DieWithError('No CL description, aborting')
agable@chromium.org42c20792013-09-12 17:34:49 +00002836 self.set_description(clean_lines)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002837
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002838 def append_footer(self, line):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002839 """Adds a footer line to the description.
2840
2841 Differentiates legacy "KEY=xxx" footers (used to be called tags) and
2842 Gerrit's footers in the form of "Footer-Key: footer any value" and ensures
2843 that Gerrit footers are always at the end.
2844 """
2845 parsed_footer_line = git_footers.parse_footer(line)
2846 if parsed_footer_line:
2847 # Line is a gerrit footer in the form: Footer-Key: any value.
2848 # Thus, must be appended observing Gerrit footer rules.
2849 self.set_description(
2850 git_footers.add_footer(self.description,
2851 key=parsed_footer_line[0],
2852 value=parsed_footer_line[1]))
2853 return
2854
2855 if not self._description_lines:
2856 self._description_lines.append(line)
2857 return
2858
2859 top_lines, gerrit_footers, _ = git_footers.split_footers(self.description)
2860 if gerrit_footers:
2861 # git_footers.split_footers ensures that there is an empty line before
2862 # actual (gerrit) footers, if any. We have to keep it that way.
2863 assert top_lines and top_lines[-1] == ''
2864 top_lines, separator = top_lines[:-1], top_lines[-1:]
2865 else:
2866 separator = [] # No need for separator if there are no gerrit_footers.
2867
2868 prev_line = top_lines[-1] if top_lines else ''
2869 if (not presubmit_support.Change.TAG_LINE_RE.match(prev_line) or
2870 not presubmit_support.Change.TAG_LINE_RE.match(line)):
2871 top_lines.append('')
2872 top_lines.append(line)
2873 self._description_lines = top_lines + separator + gerrit_footers
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002874
tandrii99a72f22016-08-17 14:33:24 -07002875 def get_reviewers(self, tbr_only=False):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002876 """Retrieves the list of reviewers."""
agable@chromium.org42c20792013-09-12 17:34:49 +00002877 matches = [re.match(self.R_LINE, line) for line in self._description_lines]
tandrii99a72f22016-08-17 14:33:24 -07002878 reviewers = [match.group(2).strip()
2879 for match in matches
2880 if match and (not tbr_only or match.group(1).upper() == 'TBR')]
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002881 return cleanup_list(reviewers)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002882
bradnelsond975b302016-10-23 12:20:23 -07002883 def get_cced(self):
2884 """Retrieves the list of reviewers."""
2885 matches = [re.match(self.CC_LINE, line) for line in self._description_lines]
2886 cced = [match.group(2).strip() for match in matches if match]
2887 return cleanup_list(cced)
2888
Nodir Turakulov23b82142017-11-16 11:04:25 -08002889 def get_hash_tags(self):
2890 """Extracts and sanitizes a list of Gerrit hashtags."""
2891 subject = (self._description_lines or ('',))[0]
2892 subject = re.sub(
2893 self.STRIP_HASH_TAG_PREFIX, '', subject, flags=re.IGNORECASE)
2894
2895 tags = []
2896 start = 0
2897 bracket_exp = re.compile(self.BRACKET_HASH_TAG)
2898 while True:
2899 m = bracket_exp.match(subject, start)
2900 if not m:
2901 break
2902 tags.append(self.sanitize_hash_tag(m.group(1)))
2903 start = m.end()
2904
2905 if not tags:
2906 # Try "Tag: " prefix.
2907 m = re.match(self.COLON_SEPARATED_HASH_TAG, subject)
2908 if m:
2909 tags.append(self.sanitize_hash_tag(m.group(1)))
2910 return tags
2911
2912 @classmethod
2913 def sanitize_hash_tag(cls, tag):
2914 """Returns a sanitized Gerrit hash tag.
2915
2916 A sanitized hashtag can be used as a git push refspec parameter value.
2917 """
2918 return re.sub(cls.BAD_HASH_TAG_CHUNK, '-', tag).strip('-').lower()
2919
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002920 def update_with_git_number_footers(self, parent_hash, parent_msg, dest_ref):
2921 """Updates this commit description given the parent.
2922
2923 This is essentially what Gnumbd used to do.
2924 Consult https://goo.gl/WMmpDe for more details.
2925 """
2926 assert parent_msg # No, orphan branch creation isn't supported.
2927 assert parent_hash
2928 assert dest_ref
2929 parent_footer_map = git_footers.parse_footers(parent_msg)
2930 # This will also happily parse svn-position, which GnumbD is no longer
2931 # supporting. While we'd generate correct footers, the verifier plugin
2932 # installed in Gerrit will block such commit (ie git push below will fail).
2933 parent_position = git_footers.get_position(parent_footer_map)
2934
2935 # Cherry-picks may have last line obscuring their prior footers,
2936 # from git_footers perspective. This is also what Gnumbd did.
2937 cp_line = None
2938 if (self._description_lines and
2939 re.match(self.CHERRY_PICK_LINE, self._description_lines[-1])):
2940 cp_line = self._description_lines.pop()
2941
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02002942 top_lines, footer_lines, _ = git_footers.split_footers(self.description)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002943
2944 # Original-ify all Cr- footers, to avoid re-lands, cherry-picks, or just
2945 # user interference with actual footers we'd insert below.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02002946 for i, line in enumerate(footer_lines):
2947 k, v = git_footers.parse_footer(line) or (None, None)
2948 if k and k.startswith('Cr-'):
2949 footer_lines[i] = '%s: %s' % ('Cr-Original-' + k[len('Cr-'):], v)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002950
2951 # Add Position and Lineage footers based on the parent.
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +01002952 lineage = list(reversed(parent_footer_map.get('Cr-Branched-From', [])))
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002953 if parent_position[0] == dest_ref:
2954 # Same branch as parent.
2955 number = int(parent_position[1]) + 1
2956 else:
2957 number = 1 # New branch, and extra lineage.
2958 lineage.insert(0, '%s-%s@{#%d}' % (parent_hash, parent_position[0],
2959 int(parent_position[1])))
2960
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02002961 footer_lines.append('Cr-Commit-Position: %s@{#%d}' % (dest_ref, number))
2962 footer_lines.extend('Cr-Branched-From: %s' % v for v in lineage)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002963
2964 self._description_lines = top_lines
2965 if cp_line:
2966 self._description_lines.append(cp_line)
2967 if self._description_lines[-1] != '':
2968 self._description_lines.append('') # Ensure footer separator.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02002969 self._description_lines.extend(footer_lines)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002970
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002971
Aaron Gablea1bab272017-04-11 16:38:18 -07002972def get_approving_reviewers(props, disapproval=False):
maruel@chromium.orge52678e2013-04-26 18:34:44 +00002973 """Retrieves the reviewers that approved a CL from the issue properties with
2974 messages.
2975
2976 Note that the list may contain reviewers that are not committer, thus are not
2977 considered by the CQ.
Aaron Gablea1bab272017-04-11 16:38:18 -07002978
2979 If disapproval is True, instead returns reviewers who 'not lgtm'd the CL.
maruel@chromium.orge52678e2013-04-26 18:34:44 +00002980 """
Aaron Gablea1bab272017-04-11 16:38:18 -07002981 approval_type = 'disapproval' if disapproval else 'approval'
maruel@chromium.orge52678e2013-04-26 18:34:44 +00002982 return sorted(
2983 set(
2984 message['sender']
2985 for message in props['messages']
Aaron Gablea1bab272017-04-11 16:38:18 -07002986 if message[approval_type] and message['sender'] in props['reviewers']
maruel@chromium.orge52678e2013-04-26 18:34:44 +00002987 )
2988 )
2989
2990
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002991def FindCodereviewSettingsFile(filename='codereview.settings'):
2992 """Finds the given file starting in the cwd and going up.
2993
2994 Only looks up to the top of the repository unless an
2995 'inherit-review-settings-ok' file exists in the root of the repository.
2996 """
2997 inherit_ok_file = 'inherit-review-settings-ok'
2998 cwd = os.getcwd()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00002999 root = settings.GetRoot()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003000 if os.path.isfile(os.path.join(root, inherit_ok_file)):
3001 root = '/'
3002 while True:
3003 if filename in os.listdir(cwd):
3004 if os.path.isfile(os.path.join(cwd, filename)):
3005 return open(os.path.join(cwd, filename))
3006 if cwd == root:
3007 break
3008 cwd = os.path.dirname(cwd)
3009
3010
3011def LoadCodereviewSettingsFromFile(fileobj):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003012 """Parses a codereview.settings file and updates hooks."""
maruel@chromium.org99ac1c52012-01-16 14:52:12 +00003013 keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003014
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003015 def SetProperty(name, setting, unset_error_ok=False):
3016 fullname = 'rietveld.' + name
3017 if setting in keyvals:
3018 RunGit(['config', fullname, keyvals[setting]])
3019 else:
3020 RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok)
3021
tandrii48df5812016-10-17 03:55:37 -07003022 if not keyvals.get('GERRIT_HOST', False):
3023 SetProperty('server', 'CODE_REVIEW_SERVER')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003024 # Only server setting is required. Other settings can be absent.
3025 # In that case, we ignore errors raised during option deletion attempt.
3026 SetProperty('cc', 'CC_LIST', unset_error_ok=True)
3027 SetProperty('tree-status-url', 'STATUS', unset_error_ok=True)
3028 SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True)
rmistry@google.com90752582014-01-14 21:04:50 +00003029 SetProperty('bug-prefix', 'BUG_PREFIX', unset_error_ok=True)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003030 SetProperty('cpplint-regex', 'LINT_REGEX', unset_error_ok=True)
3031 SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +00003032 SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK',
3033 unset_error_ok=True)
Jamie Madilldc4d19e2019-10-24 21:50:02 +00003034 SetProperty(
3035 'format-full-by-default', 'FORMAT_FULL_BY_DEFAULT', unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003036
ukai@chromium.org7044efc2013-11-28 01:51:21 +00003037 if 'GERRIT_HOST' in keyvals:
ukai@chromium.orge8077812012-02-03 03:41:46 +00003038 RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']])
ukai@chromium.orge8077812012-02-03 03:41:46 +00003039
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003040 if 'GERRIT_SQUASH_UPLOADS' in keyvals:
tandrii8dd81ea2016-06-16 13:24:23 -07003041 RunGit(['config', 'gerrit.squash-uploads',
3042 keyvals['GERRIT_SQUASH_UPLOADS']])
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003043
tandrii@chromium.org28253532016-04-14 13:46:56 +00003044 if 'GERRIT_SKIP_ENSURE_AUTHENTICATED' in keyvals:
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00003045 RunGit(['config', 'gerrit.skip-ensure-authenticated',
tandrii@chromium.org28253532016-04-14 13:46:56 +00003046 keyvals['GERRIT_SKIP_ENSURE_AUTHENTICATED']])
3047
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003048 if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01003049 # should be of the form
3050 # PUSH_URL_CONFIG: url.ssh://gitrw.chromium.org.pushinsteadof
3051 # ORIGIN_URL_CONFIG: http://src.chromium.org/git
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003052 RunGit(['config', keyvals['PUSH_URL_CONFIG'],
3053 keyvals['ORIGIN_URL_CONFIG']])
3054
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003055
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003056def urlretrieve(source, destination):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003057 """Downloads a network object to a local file, like urllib.urlretrieve.
3058
3059 This is necessary because urllib is broken for SSL connections via a proxy.
3060 """
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003061 with open(destination, 'w') as f:
Edward Lemur79d4f992019-11-11 23:49:02 +00003062 f.write(urllib.request.urlopen(source).read())
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003063
3064
ukai@chromium.org712d6102013-11-27 00:52:58 +00003065def hasSheBang(fname):
3066 """Checks fname is a #! script."""
3067 with open(fname) as f:
3068 return f.read(2).startswith('#!')
3069
3070
bpastene@chromium.org917f0ff2016-04-05 00:45:30 +00003071# TODO(bpastene) Remove once a cleaner fix to crbug.com/600473 presents itself.
3072def DownloadHooks(*args, **kwargs):
3073 pass
3074
3075
tandrii@chromium.org18630d62016-03-04 12:06:02 +00003076def DownloadGerritHook(force):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003077 """Downloads and installs a Gerrit commit-msg hook.
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003078
3079 Args:
3080 force: True to update hooks. False to install hooks if not present.
3081 """
3082 if not settings.GetIsGerrit():
3083 return
ukai@chromium.org712d6102013-11-27 00:52:58 +00003084 src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg'
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003085 dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
3086 if not os.access(dst, os.X_OK):
3087 if os.path.exists(dst):
3088 if not force:
3089 return
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003090 try:
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003091 urlretrieve(src, dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003092 if not hasSheBang(dst):
3093 DieWithError('Not a script: %s\n'
3094 'You need to download from\n%s\n'
3095 'into .git/hooks/commit-msg and '
3096 'chmod +x .git/hooks/commit-msg' % (dst, src))
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003097 os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
3098 except Exception:
3099 if os.path.exists(dst):
3100 os.remove(dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003101 DieWithError('\nFailed to download hooks.\n'
3102 'You need to download from\n%s\n'
3103 'into .git/hooks/commit-msg and '
3104 'chmod +x .git/hooks/commit-msg' % src)
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003105
3106
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003107class _GitCookiesChecker(object):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003108 """Provides facilities for validating and suggesting fixes to .gitcookies."""
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003109
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003110 _GOOGLESOURCE = 'googlesource.com'
3111
3112 def __init__(self):
3113 # Cached list of [host, identity, source], where source is either
3114 # .gitcookies or .netrc.
3115 self._all_hosts = None
3116
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003117 def ensure_configured_gitcookies(self):
3118 """Runs checks and suggests fixes to make git use .gitcookies from default
3119 path."""
3120 default = gerrit_util.CookiesAuthenticator.get_gitcookies_path()
3121 configured_path = RunGitSilent(
3122 ['config', '--global', 'http.cookiefile']).strip()
Andrii Shyshkalov1e250cd2017-05-10 15:39:31 +02003123 configured_path = os.path.expanduser(configured_path)
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003124 if configured_path:
3125 self._ensure_default_gitcookies_path(configured_path, default)
3126 else:
3127 self._configure_gitcookies_path(default)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003128
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003129 @staticmethod
3130 def _ensure_default_gitcookies_path(configured_path, default_path):
3131 assert configured_path
3132 if configured_path == default_path:
3133 print('git is already configured to use your .gitcookies from %s' %
3134 configured_path)
3135 return
3136
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003137 print('WARNING: You have configured custom path to .gitcookies: %s\n'
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003138 'Gerrit and other depot_tools expect .gitcookies at %s\n' %
3139 (configured_path, default_path))
3140
3141 if not os.path.exists(configured_path):
3142 print('However, your configured .gitcookies file is missing.')
3143 confirm_or_exit('Reconfigure git to use default .gitcookies?',
3144 action='reconfigure')
3145 RunGit(['config', '--global', 'http.cookiefile', default_path])
3146 return
3147
3148 if os.path.exists(default_path):
3149 print('WARNING: default .gitcookies file already exists %s' %
3150 default_path)
3151 DieWithError('Please delete %s manually and re-run git cl creds-check' %
3152 default_path)
3153
3154 confirm_or_exit('Move existing .gitcookies to default location?',
3155 action='move')
3156 shutil.move(configured_path, default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003157 RunGit(['config', '--global', 'http.cookiefile', default_path])
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003158 print('Moved and reconfigured git to use .gitcookies from %s' %
3159 default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003160
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003161 @staticmethod
3162 def _configure_gitcookies_path(default_path):
3163 netrc_path = gerrit_util.CookiesAuthenticator.get_netrc_path()
3164 if os.path.exists(netrc_path):
3165 print('You seem to be using outdated .netrc for git credentials: %s' %
3166 netrc_path)
3167 print('This tool will guide you through setting up recommended '
3168 '.gitcookies store for git credentials.\n'
3169 '\n'
3170 'IMPORTANT: If something goes wrong and you decide to go back, do:\n'
3171 ' git config --global --unset http.cookiefile\n'
3172 ' mv %s %s.backup\n\n' % (default_path, default_path))
3173 confirm_or_exit(action='setup .gitcookies')
3174 RunGit(['config', '--global', 'http.cookiefile', default_path])
3175 print('Configured git to use .gitcookies from %s' % default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003176
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003177 def get_hosts_with_creds(self, include_netrc=False):
3178 if self._all_hosts is None:
3179 a = gerrit_util.CookiesAuthenticator()
3180 self._all_hosts = [
3181 (h, u, s)
3182 for h, u, s in itertools.chain(
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003183 ((h, u, '.netrc') for h, (u, _, _) in a.netrc.hosts.items()),
3184 ((h, u, '.gitcookies') for h, (u, _) in a.gitcookies.items())
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003185 )
3186 if h.endswith(self._GOOGLESOURCE)
3187 ]
3188
3189 if include_netrc:
3190 return self._all_hosts
3191 return [(h, u, s) for h, u, s in self._all_hosts if s != '.netrc']
3192
3193 def print_current_creds(self, include_netrc=False):
3194 hosts = sorted(self.get_hosts_with_creds(include_netrc=include_netrc))
3195 if not hosts:
3196 print('No Git/Gerrit credentials found')
3197 return
Edward Lemur79d4f992019-11-11 23:49:02 +00003198 lengths = [max(map(len, (row[i] for row in hosts))) for i in range(3)]
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003199 header = [('Host', 'User', 'Which file'),
3200 ['=' * l for l in lengths]]
3201 for row in (header + hosts):
3202 print('\t'.join((('%%+%ds' % l) % s)
3203 for l, s in zip(lengths, row)))
3204
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003205 @staticmethod
3206 def _parse_identity(identity):
Lei Zhangd3f769a2017-12-15 15:16:14 -08003207 """Parses identity "git-<username>.domain" into <username> and domain."""
3208 # Special case: usernames that contain ".", which are generally not
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02003209 # distinguishable from sub-domains. But we do know typical domains:
3210 if identity.endswith('.chromium.org'):
3211 domain = 'chromium.org'
3212 username = identity[:-len('.chromium.org')]
3213 else:
3214 username, domain = identity.split('.', 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003215 if username.startswith('git-'):
3216 username = username[len('git-'):]
3217 return username, domain
3218
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003219 def _canonical_git_googlesource_host(self, host):
3220 """Normalizes Gerrit hosts (with '-review') to Git host."""
3221 assert host.endswith(self._GOOGLESOURCE)
3222 # Prefix doesn't include '.' at the end.
3223 prefix = host[:-(1 + len(self._GOOGLESOURCE))]
3224 if prefix.endswith('-review'):
3225 prefix = prefix[:-len('-review')]
3226 return prefix + '.' + self._GOOGLESOURCE
3227
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003228 def _canonical_gerrit_googlesource_host(self, host):
3229 git_host = self._canonical_git_googlesource_host(host)
3230 prefix = git_host.split('.', 1)[0]
3231 return prefix + '-review.' + self._GOOGLESOURCE
3232
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003233 def _get_counterpart_host(self, host):
3234 assert host.endswith(self._GOOGLESOURCE)
3235 git = self._canonical_git_googlesource_host(host)
3236 gerrit = self._canonical_gerrit_googlesource_host(git)
3237 return git if gerrit == host else gerrit
3238
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003239 def has_generic_host(self):
3240 """Returns whether generic .googlesource.com has been configured.
3241
3242 Chrome Infra recommends to use explicit ${host}.googlesource.com instead.
3243 """
3244 for host, _, _ in self.get_hosts_with_creds(include_netrc=False):
3245 if host == '.' + self._GOOGLESOURCE:
3246 return True
3247 return False
3248
3249 def _get_git_gerrit_identity_pairs(self):
3250 """Returns map from canonic host to pair of identities (Git, Gerrit).
3251
3252 One of identities might be None, meaning not configured.
3253 """
3254 host_to_identity_pairs = {}
3255 for host, identity, _ in self.get_hosts_with_creds():
3256 canonical = self._canonical_git_googlesource_host(host)
3257 pair = host_to_identity_pairs.setdefault(canonical, [None, None])
3258 idx = 0 if canonical == host else 1
3259 pair[idx] = identity
3260 return host_to_identity_pairs
3261
3262 def get_partially_configured_hosts(self):
3263 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003264 (host if i1 else self._canonical_gerrit_googlesource_host(host))
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003265 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().items()
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003266 if None in (i1, i2) and host != '.' + self._GOOGLESOURCE)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003267
3268 def get_conflicting_hosts(self):
3269 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003270 host
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003271 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().items()
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003272 if None not in (i1, i2) and i1 != i2)
3273
3274 def get_duplicated_hosts(self):
3275 counters = collections.Counter(h for h, _, _ in self.get_hosts_with_creds())
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003276 return set(host for host, count in counters.items() if count > 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003277
3278 _EXPECTED_HOST_IDENTITY_DOMAINS = {
3279 'chromium.googlesource.com': 'chromium.org',
3280 'chrome-internal.googlesource.com': 'google.com',
3281 }
3282
3283 def get_hosts_with_wrong_identities(self):
3284 """Finds hosts which **likely** reference wrong identities.
3285
3286 Note: skips hosts which have conflicting identities for Git and Gerrit.
3287 """
3288 hosts = set()
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003289 for host, expected in self._EXPECTED_HOST_IDENTITY_DOMAINS.items():
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003290 pair = self._get_git_gerrit_identity_pairs().get(host)
3291 if pair and pair[0] == pair[1]:
3292 _, domain = self._parse_identity(pair[0])
3293 if domain != expected:
3294 hosts.add(host)
3295 return hosts
3296
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003297 @staticmethod
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003298 def _format_hosts(hosts, extra_column_func=None):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003299 hosts = sorted(hosts)
3300 assert hosts
3301 if extra_column_func is None:
3302 extras = [''] * len(hosts)
3303 else:
3304 extras = [extra_column_func(host) for host in hosts]
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003305 tmpl = '%%-%ds %%-%ds' % (max(map(len, hosts)), max(map(len, extras)))
3306 lines = []
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003307 for he in zip(hosts, extras):
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003308 lines.append(tmpl % he)
3309 return lines
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003310
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003311 def _find_problems(self):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003312 if self.has_generic_host():
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003313 yield ('.googlesource.com wildcard record detected',
3314 ['Chrome Infrastructure team recommends to list full host names '
3315 'explicitly.'],
3316 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003317
3318 dups = self.get_duplicated_hosts()
3319 if dups:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003320 yield ('The following hosts were defined twice',
3321 self._format_hosts(dups),
3322 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003323
3324 partial = self.get_partially_configured_hosts()
3325 if partial:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003326 yield ('Credentials should come in pairs for Git and Gerrit hosts. '
3327 'These hosts are missing',
3328 self._format_hosts(partial, lambda host: 'but %s defined' %
3329 self._get_counterpart_host(host)),
3330 partial)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003331
3332 conflicting = self.get_conflicting_hosts()
3333 if conflicting:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003334 yield ('The following Git hosts have differing credentials from their '
3335 'Gerrit counterparts',
3336 self._format_hosts(conflicting, lambda host: '%s vs %s' %
3337 tuple(self._get_git_gerrit_identity_pairs()[host])),
3338 conflicting)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003339
3340 wrong = self.get_hosts_with_wrong_identities()
3341 if wrong:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003342 yield ('These hosts likely use wrong identity',
3343 self._format_hosts(wrong, lambda host: '%s but %s recommended' %
3344 (self._get_git_gerrit_identity_pairs()[host][0],
3345 self._EXPECTED_HOST_IDENTITY_DOMAINS[host])),
3346 wrong)
3347
3348 def find_and_report_problems(self):
3349 """Returns True if there was at least one problem, else False."""
3350 found = False
3351 bad_hosts = set()
3352 for title, sublines, hosts in self._find_problems():
3353 if not found:
3354 found = True
3355 print('\n\n.gitcookies problem report:\n')
3356 bad_hosts.update(hosts or [])
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003357 print(' %s%s' % (title, (':' if sublines else '')))
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003358 if sublines:
3359 print()
3360 print(' %s' % '\n '.join(sublines))
3361 print()
3362
3363 if bad_hosts:
3364 assert found
3365 print(' You can manually remove corresponding lines in your %s file and '
3366 'visit the following URLs with correct account to generate '
3367 'correct credential lines:\n' %
3368 gerrit_util.CookiesAuthenticator.get_gitcookies_path())
3369 print(' %s' % '\n '.join(sorted(set(
3370 gerrit_util.CookiesAuthenticator().get_new_password_url(
3371 self._canonical_git_googlesource_host(host))
3372 for host in bad_hosts
3373 ))))
3374 return found
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003375
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003376
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003377@metrics.collector.collect_metrics('git cl creds-check')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003378def CMDcreds_check(parser, args):
3379 """Checks credentials and suggests changes."""
3380 _, _ = parser.parse_args(args)
3381
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003382 # Code below checks .gitcookies. Abort if using something else.
3383 authn = gerrit_util.Authenticator.get()
3384 if not isinstance(authn, gerrit_util.CookiesAuthenticator):
3385 if isinstance(authn, gerrit_util.GceAuthenticator):
3386 DieWithError(
3387 'This command is not designed for GCE, are you on a bot?\n'
3388 'If you need to run this on GCE, export SKIP_GCE_AUTH_FOR_GIT=1 '
3389 'in your env.')
Aaron Gabled10ca0e2017-09-11 11:24:10 -07003390 DieWithError(
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003391 'This command is not designed for bot environment. It checks '
3392 '~/.gitcookies file not generally used on bots.')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003393
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003394 checker = _GitCookiesChecker()
3395 checker.ensure_configured_gitcookies()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003396
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003397 print('Your .netrc and .gitcookies have credentials for these hosts:')
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003398 checker.print_current_creds(include_netrc=True)
3399
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003400 if not checker.find_and_report_problems():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003401 print('\nNo problems detected in your .gitcookies file.')
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003402 return 0
3403 return 1
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003404
3405
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003406@metrics.collector.collect_metrics('git cl baseurl')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003407def CMDbaseurl(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003408 """Gets or sets base-url for this branch."""
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003409 branchref = RunGit(['symbolic-ref', 'HEAD']).strip()
Edward Lemur85153282020-02-14 22:06:29 +00003410 branch = scm.GIT.ShortBranchName(branchref)
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003411 _, args = parser.parse_args(args)
3412 if not args:
vapiera7fbd5a2016-06-16 09:17:49 -07003413 print('Current base-url:')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003414 return RunGit(['config', 'branch.%s.base-url' % branch],
3415 error_ok=False).strip()
3416 else:
vapiera7fbd5a2016-06-16 09:17:49 -07003417 print('Setting base-url to %s' % args[0])
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003418 return RunGit(['config', 'branch.%s.base-url' % branch, args[0]],
3419 error_ok=False).strip()
3420
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003421
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003422def color_for_status(status):
3423 """Maps a Changelist status to color, for CMDstatus and other tools."""
3424 return {
Aaron Gable9ab38c62017-04-06 14:36:33 -07003425 'unsent': Fore.YELLOW,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003426 'waiting': Fore.BLUE,
3427 'reply': Fore.YELLOW,
Aaron Gable9ab38c62017-04-06 14:36:33 -07003428 'not lgtm': Fore.RED,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003429 'lgtm': Fore.GREEN,
3430 'commit': Fore.MAGENTA,
3431 'closed': Fore.CYAN,
3432 'error': Fore.WHITE,
3433 }.get(status, Fore.WHITE)
3434
tandrii@chromium.org04ea8462016-04-25 19:51:21 +00003435
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003436def get_cl_statuses(changes, fine_grained, max_processes=None):
3437 """Returns a blocking iterable of (cl, status) for given branches.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003438
3439 If fine_grained is true, this will fetch CL statuses from the server.
3440 Otherwise, simply indicate if there's a matching url for the given branches.
3441
3442 If max_processes is specified, it is used as the maximum number of processes
3443 to spawn to fetch CL status from the server. Otherwise 1 process per branch is
3444 spawned.
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003445
3446 See GetStatus() for a list of possible statuses.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003447 """
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003448 if not changes:
3449 raise StopIteration()
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003450
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003451 if not fine_grained:
3452 # Fast path which doesn't involve querying codereview servers.
Aaron Gablea1bab272017-04-11 16:38:18 -07003453 # Do not use get_approving_reviewers(), since it requires an HTTP request.
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003454 for cl in changes:
3455 yield (cl, 'waiting' if cl.GetIssueURL() else 'error')
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003456 return
3457
3458 # First, sort out authentication issues.
3459 logging.debug('ensuring credentials exist')
3460 for cl in changes:
3461 cl.EnsureAuthenticated(force=False, refresh=True)
3462
3463 def fetch(cl):
3464 try:
3465 return (cl, cl.GetStatus())
3466 except:
3467 # See http://crbug.com/629863.
Andrii Shyshkalov98824232018-04-19 11:37:15 -07003468 logging.exception('failed to fetch status for cl %s:', cl.GetIssue())
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003469 raise
3470
3471 threads_count = len(changes)
3472 if max_processes:
3473 threads_count = max(1, min(threads_count, max_processes))
3474 logging.debug('querying %d CLs using %d threads', len(changes), threads_count)
3475
3476 pool = ThreadPool(threads_count)
3477 fetched_cls = set()
3478 try:
3479 it = pool.imap_unordered(fetch, changes).__iter__()
3480 while True:
3481 try:
3482 cl, status = it.next(timeout=5)
3483 except multiprocessing.TimeoutError:
3484 break
3485 fetched_cls.add(cl)
3486 yield cl, status
3487 finally:
3488 pool.close()
3489
3490 # Add any branches that failed to fetch.
3491 for cl in set(changes) - fetched_cls:
3492 yield (cl, 'error')
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003493
rmistry@google.com2dd99862015-06-22 12:22:18 +00003494
3495def upload_branch_deps(cl, args):
3496 """Uploads CLs of local branches that are dependents of the current branch.
3497
3498 If the local branch dependency tree looks like:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003499
3500 test1 -> test2.1 -> test3.1
3501 -> test3.2
3502 -> test2.2 -> test3.3
rmistry@google.com2dd99862015-06-22 12:22:18 +00003503
3504 and you run "git cl upload --dependencies" from test1 then "git cl upload" is
3505 run on the dependent branches in this order:
3506 test2.1, test3.1, test3.2, test2.2, test3.3
3507
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003508 Note: This function does not rebase your local dependent branches. Use it
3509 when you make a change to the parent branch that will not conflict
3510 with its dependent branches, and you would like their dependencies
3511 updated in Rietveld.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003512 """
3513 if git_common.is_dirty_git_tree('upload-branch-deps'):
3514 return 1
3515
3516 root_branch = cl.GetBranch()
3517 if root_branch is None:
3518 DieWithError('Can\'t find dependent branches from detached HEAD state. '
3519 'Get on a branch!')
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00003520 if not cl.GetIssue():
rmistry@google.com2dd99862015-06-22 12:22:18 +00003521 DieWithError('Current branch does not have an uploaded CL. We cannot set '
3522 'patchset dependencies without an uploaded CL.')
3523
3524 branches = RunGit(['for-each-ref',
3525 '--format=%(refname:short) %(upstream:short)',
3526 'refs/heads'])
3527 if not branches:
3528 print('No local branches found.')
3529 return 0
3530
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003531 # Create a dictionary of all local branches to the branches that are
3532 # dependent on it.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003533 tracked_to_dependents = collections.defaultdict(list)
3534 for b in branches.splitlines():
3535 tokens = b.split()
3536 if len(tokens) == 2:
3537 branch_name, tracked = tokens
3538 tracked_to_dependents[tracked].append(branch_name)
3539
vapiera7fbd5a2016-06-16 09:17:49 -07003540 print()
3541 print('The dependent local branches of %s are:' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003542 dependents = []
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003543
rmistry@google.com2dd99862015-06-22 12:22:18 +00003544 def traverse_dependents_preorder(branch, padding=''):
3545 dependents_to_process = tracked_to_dependents.get(branch, [])
3546 padding += ' '
3547 for dependent in dependents_to_process:
vapiera7fbd5a2016-06-16 09:17:49 -07003548 print('%s%s' % (padding, dependent))
rmistry@google.com2dd99862015-06-22 12:22:18 +00003549 dependents.append(dependent)
3550 traverse_dependents_preorder(dependent, padding)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003551
rmistry@google.com2dd99862015-06-22 12:22:18 +00003552 traverse_dependents_preorder(root_branch)
vapiera7fbd5a2016-06-16 09:17:49 -07003553 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003554
3555 if not dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003556 print('There are no dependent local branches for %s' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003557 return 0
3558
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01003559 confirm_or_exit('This command will checkout all dependent branches and run '
3560 '"git cl upload".', action='continue')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003561
rmistry@google.com2dd99862015-06-22 12:22:18 +00003562 # Record all dependents that failed to upload.
3563 failures = {}
3564 # Go through all dependents, checkout the branch and upload.
3565 try:
3566 for dependent_branch in dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003567 print()
3568 print('--------------------------------------')
3569 print('Running "git cl upload" from %s:' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003570 RunGit(['checkout', '-q', dependent_branch])
vapiera7fbd5a2016-06-16 09:17:49 -07003571 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003572 try:
3573 if CMDupload(OptionParser(), args) != 0:
vapiera7fbd5a2016-06-16 09:17:49 -07003574 print('Upload failed for %s!' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003575 failures[dependent_branch] = 1
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003576 except: # pylint: disable=bare-except
rmistry@google.com2dd99862015-06-22 12:22:18 +00003577 failures[dependent_branch] = 1
vapiera7fbd5a2016-06-16 09:17:49 -07003578 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003579 finally:
3580 # Swap back to the original root branch.
3581 RunGit(['checkout', '-q', root_branch])
3582
vapiera7fbd5a2016-06-16 09:17:49 -07003583 print()
3584 print('Upload complete for dependent branches!')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003585 for dependent_branch in dependents:
3586 upload_status = 'failed' if failures.get(dependent_branch) else 'succeeded'
vapiera7fbd5a2016-06-16 09:17:49 -07003587 print(' %s : %s' % (dependent_branch, upload_status))
3588 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003589
3590 return 0
3591
3592
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003593def GetArchiveTagForBranch(issue_num, branch_name, existing_tags):
3594 """Given a proposed tag name, returns a tag name that is guaranteed to be
3595 unique. If 'foo' is proposed but already exists, then 'foo-2' is used,
3596 or 'foo-3', and so on."""
3597
3598 proposed_tag = 'git-cl-archived-%s-%s' % (issue_num, branch_name)
3599 for suffix_num in itertools.count(1):
3600 if suffix_num == 1:
3601 to_check = proposed_tag
3602 else:
3603 to_check = '%s-%d' % (proposed_tag, suffix_num)
3604
3605 if to_check not in existing_tags:
3606 return to_check
3607
3608
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003609@metrics.collector.collect_metrics('git cl archive')
kmarshall3bff56b2016-06-06 18:31:47 -07003610def CMDarchive(parser, args):
3611 """Archives and deletes branches associated with closed changelists."""
3612 parser.add_option(
3613 '-j', '--maxjobs', action='store', type=int,
kmarshall9249e012016-08-23 12:02:16 -07003614 help='The maximum number of jobs to use when retrieving review status.')
kmarshall3bff56b2016-06-06 18:31:47 -07003615 parser.add_option(
3616 '-f', '--force', action='store_true',
3617 help='Bypasses the confirmation prompt.')
kmarshall9249e012016-08-23 12:02:16 -07003618 parser.add_option(
3619 '-d', '--dry-run', action='store_true',
3620 help='Skip the branch tagging and removal steps.')
3621 parser.add_option(
3622 '-t', '--notags', action='store_true',
3623 help='Do not tag archived branches. '
3624 'Note: local commit history may be lost.')
kmarshall3bff56b2016-06-06 18:31:47 -07003625
kmarshall3bff56b2016-06-06 18:31:47 -07003626 options, args = parser.parse_args(args)
3627 if args:
3628 parser.error('Unsupported args: %s' % ' '.join(args))
kmarshall3bff56b2016-06-06 18:31:47 -07003629
3630 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
3631 if not branches:
3632 return 0
3633
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003634 tags = RunGit(['for-each-ref', '--format=%(refname)',
3635 'refs/tags']).splitlines() or []
3636 tags = [t.split('/')[-1] for t in tags]
3637
vapiera7fbd5a2016-06-16 09:17:49 -07003638 print('Finding all branches associated with closed issues...')
Edward Lemur934836a2019-09-09 20:16:54 +00003639 changes = [Changelist(branchref=b)
3640 for b in branches.splitlines()]
kmarshall3bff56b2016-06-06 18:31:47 -07003641 alignment = max(5, max(len(c.GetBranch()) for c in changes))
3642 statuses = get_cl_statuses(changes,
3643 fine_grained=True,
3644 max_processes=options.maxjobs)
3645 proposal = [(cl.GetBranch(),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003646 GetArchiveTagForBranch(cl.GetIssue(), cl.GetBranch(),
3647 tags))
kmarshall3bff56b2016-06-06 18:31:47 -07003648 for cl, status in statuses
Andrii Shyshkalov51bdf8c2018-10-18 01:07:58 +00003649 if status in ('closed', 'rietveld-not-supported')]
kmarshall3bff56b2016-06-06 18:31:47 -07003650 proposal.sort()
3651
3652 if not proposal:
vapiera7fbd5a2016-06-16 09:17:49 -07003653 print('No branches with closed codereview issues found.')
kmarshall3bff56b2016-06-06 18:31:47 -07003654 return 0
3655
Edward Lemur85153282020-02-14 22:06:29 +00003656 current_branch = scm.GIT.GetBranch(settings.GetRoot())
kmarshall3bff56b2016-06-06 18:31:47 -07003657
vapiera7fbd5a2016-06-16 09:17:49 -07003658 print('\nBranches with closed issues that will be archived:\n')
kmarshall9249e012016-08-23 12:02:16 -07003659 if options.notags:
3660 for next_item in proposal:
3661 print(' ' + next_item[0])
3662 else:
3663 print('%*s | %s' % (alignment, 'Branch name', 'Archival tag name'))
3664 for next_item in proposal:
3665 print('%*s %s' % (alignment, next_item[0], next_item[1]))
kmarshall3bff56b2016-06-06 18:31:47 -07003666
kmarshall9249e012016-08-23 12:02:16 -07003667 # Quit now on precondition failure or if instructed by the user, either
3668 # via an interactive prompt or by command line flags.
3669 if options.dry_run:
3670 print('\nNo changes were made (dry run).\n')
3671 return 0
3672 elif any(branch == current_branch for branch, _ in proposal):
kmarshall3bff56b2016-06-06 18:31:47 -07003673 print('You are currently on a branch \'%s\' which is associated with a '
3674 'closed codereview issue, so archive cannot proceed. Please '
3675 'checkout another branch and run this command again.' %
3676 current_branch)
3677 return 1
kmarshall9249e012016-08-23 12:02:16 -07003678 elif not options.force:
sergiyb4a5ecbe2016-06-20 09:46:00 -07003679 answer = ask_for_data('\nProceed with deletion (Y/n)? ').lower()
3680 if answer not in ('y', ''):
vapiera7fbd5a2016-06-16 09:17:49 -07003681 print('Aborted.')
kmarshall3bff56b2016-06-06 18:31:47 -07003682 return 1
3683
3684 for branch, tagname in proposal:
kmarshall9249e012016-08-23 12:02:16 -07003685 if not options.notags:
3686 RunGit(['tag', tagname, branch])
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003687
3688 if RunGitWithCode(['branch', '-D', branch])[0] != 0:
3689 # Clean up the tag if we failed to delete the branch.
3690 RunGit(['tag', '-d', tagname])
kmarshall9249e012016-08-23 12:02:16 -07003691
vapiera7fbd5a2016-06-16 09:17:49 -07003692 print('\nJob\'s done!')
kmarshall3bff56b2016-06-06 18:31:47 -07003693
3694 return 0
3695
3696
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003697@metrics.collector.collect_metrics('git cl status')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003698def CMDstatus(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003699 """Show status of changelists.
3700
3701 Colors are used to tell the state of the CL unless --fast is used:
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003702 - Blue waiting for review
Aaron Gable9ab38c62017-04-06 14:36:33 -07003703 - Yellow waiting for you to reply to review, or not yet sent
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003704 - Green LGTM'ed
Aaron Gable9ab38c62017-04-06 14:36:33 -07003705 - Red 'not LGTM'ed
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00003706 - Magenta in the CQ
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003707 - Cyan was committed, branch can be deleted
Aaron Gable9ab38c62017-04-06 14:36:33 -07003708 - White error, or unknown status
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003709
3710 Also see 'git cl comments'.
3711 """
Alan Cuttera3be9a52019-03-04 18:50:33 +00003712 parser.add_option(
3713 '--no-branch-color',
3714 action='store_true',
3715 help='Disable colorized branch names')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003716 parser.add_option('--field',
phajdan.jr289d03e2016-08-16 08:21:06 -07003717 help='print only specific field (desc|id|patch|status|url)')
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003718 parser.add_option('-f', '--fast', action='store_true',
3719 help='Do not retrieve review status')
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003720 parser.add_option(
3721 '-j', '--maxjobs', action='store', type=int,
3722 help='The maximum number of jobs to use when retrieving review status')
Edward Lemur52969c92020-02-06 18:15:28 +00003723 parser.add_option(
3724 '-i', '--issue', type=int,
3725 help='Operate on this issue instead of the current branch\'s implicit '
3726 'issue. Requires --field to be set.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003727 options, args = parser.parse_args(args)
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003728 if args:
3729 parser.error('Unsupported args: %s' % args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003730
iannuccie53c9352016-08-17 14:40:40 -07003731 if options.issue is not None and not options.field:
Edward Lemur6c6827c2020-02-06 21:15:18 +00003732 parser.error('--field must be given when --issue is set.')
iannucci3c972b92016-08-17 13:24:10 -07003733
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003734 if options.field:
Edward Lemur934836a2019-09-09 20:16:54 +00003735 cl = Changelist(issue=options.issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003736 if options.field.startswith('desc'):
Edward Lemur6c6827c2020-02-06 21:15:18 +00003737 if cl.GetIssue():
3738 print(cl.FetchDescription())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003739 elif options.field == 'id':
3740 issueid = cl.GetIssue()
3741 if issueid:
vapiera7fbd5a2016-06-16 09:17:49 -07003742 print(issueid)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003743 elif options.field == 'patch':
Aaron Gablee8856ee2017-12-07 12:41:46 -08003744 patchset = cl.GetMostRecentPatchset()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003745 if patchset:
vapiera7fbd5a2016-06-16 09:17:49 -07003746 print(patchset)
phajdan.jr289d03e2016-08-16 08:21:06 -07003747 elif options.field == 'status':
3748 print(cl.GetStatus())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003749 elif options.field == 'url':
3750 url = cl.GetIssueURL()
3751 if url:
vapiera7fbd5a2016-06-16 09:17:49 -07003752 print(url)
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00003753 return 0
3754
3755 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
3756 if not branches:
3757 print('No local branch found.')
3758 return 0
3759
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003760 changes = [
Edward Lemur934836a2019-09-09 20:16:54 +00003761 Changelist(branchref=b)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003762 for b in branches.splitlines()]
vapiera7fbd5a2016-06-16 09:17:49 -07003763 print('Branches associated with reviews:')
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003764 output = get_cl_statuses(changes,
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003765 fine_grained=not options.fast,
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003766 max_processes=options.maxjobs)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003767
Edward Lemur85153282020-02-14 22:06:29 +00003768 current_branch = scm.GIT.GetBranch(settings.GetRoot())
Daniel McArdlea23bf592019-02-12 00:25:12 +00003769
3770 def FormatBranchName(branch, colorize=False):
3771 """Simulates 'git branch' behavior. Colorizes and prefixes branch name with
3772 an asterisk when it is the current branch."""
3773
3774 asterisk = ""
3775 color = Fore.RESET
3776 if branch == current_branch:
3777 asterisk = "* "
3778 color = Fore.GREEN
Edward Lemur85153282020-02-14 22:06:29 +00003779 branch_name = scm.GIT.ShortBranchName(branch)
Daniel McArdlea23bf592019-02-12 00:25:12 +00003780
3781 if colorize:
3782 return asterisk + color + branch_name + Fore.RESET
Daniel McArdle452a49f2019-02-14 17:28:31 +00003783 return asterisk + branch_name
3784
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003785 branch_statuses = {}
Daniel McArdlea23bf592019-02-12 00:25:12 +00003786
3787 alignment = max(5, max(len(FormatBranchName(c.GetBranch())) for c in changes))
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003788 for cl in sorted(changes, key=lambda c: c.GetBranch()):
3789 branch = cl.GetBranch()
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003790 while branch not in branch_statuses:
Edward Lemur79d4f992019-11-11 23:49:02 +00003791 c, status = next(output)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003792 branch_statuses[c.GetBranch()] = status
3793 status = branch_statuses.pop(branch)
3794 url = cl.GetIssueURL()
3795 if url and (not status or status == 'error'):
3796 # The issue probably doesn't exist anymore.
3797 url += ' (broken)'
3798
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003799 color = color_for_status(status)
maruel@chromium.org885f6512013-07-27 02:17:26 +00003800 reset = Fore.RESET
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00003801 if not setup_color.IS_TTY:
maruel@chromium.org885f6512013-07-27 02:17:26 +00003802 color = ''
3803 reset = ''
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003804 status_str = '(%s)' % status if status else ''
Daniel McArdle452a49f2019-02-14 17:28:31 +00003805
Alan Cuttera3be9a52019-03-04 18:50:33 +00003806 branch_display = FormatBranchName(branch)
3807 padding = ' ' * (alignment - len(branch_display))
3808 if not options.no_branch_color:
3809 branch_display = FormatBranchName(branch, colorize=True)
Daniel McArdle452a49f2019-02-14 17:28:31 +00003810
Alan Cuttera3be9a52019-03-04 18:50:33 +00003811 print(' %s : %s%s %s%s' % (padding + branch_display, color, url,
3812 status_str, reset))
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003813
vapiera7fbd5a2016-06-16 09:17:49 -07003814 print()
Daniel McArdlea23bf592019-02-12 00:25:12 +00003815 print('Current branch: %s' % current_branch)
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003816 for cl in changes:
Daniel McArdlea23bf592019-02-12 00:25:12 +00003817 if cl.GetBranch() == current_branch:
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003818 break
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003819 if not cl.GetIssue():
vapiera7fbd5a2016-06-16 09:17:49 -07003820 print('No issue assigned.')
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003821 return 0
vapiera7fbd5a2016-06-16 09:17:49 -07003822 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
maruel@chromium.org85616e02014-07-28 15:37:55 +00003823 if not options.fast:
vapiera7fbd5a2016-06-16 09:17:49 -07003824 print('Issue description:')
Edward Lemur6c6827c2020-02-06 21:15:18 +00003825 print(cl.FetchDescription(pretty=True))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003826 return 0
3827
3828
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003829def colorize_CMDstatus_doc():
3830 """To be called once in main() to add colors to git cl status help."""
3831 colors = [i for i in dir(Fore) if i[0].isupper()]
3832
3833 def colorize_line(line):
3834 for color in colors:
3835 if color in line.upper():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003836 # Extract whitespace first and the leading '-'.
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003837 indent = len(line) - len(line.lstrip(' ')) + 1
3838 return line[:indent] + getattr(Fore, color) + line[indent:] + Fore.RESET
3839 return line
3840
3841 lines = CMDstatus.__doc__.splitlines()
3842 CMDstatus.__doc__ = '\n'.join(colorize_line(l) for l in lines)
3843
3844
phajdan.jre328cf92016-08-22 04:12:17 -07003845def write_json(path, contents):
Stefan Zager1306bd02017-06-22 19:26:46 -07003846 if path == '-':
3847 json.dump(contents, sys.stdout)
3848 else:
3849 with open(path, 'w') as f:
3850 json.dump(contents, f)
phajdan.jre328cf92016-08-22 04:12:17 -07003851
3852
maruel@chromium.org0633fb42013-08-16 20:06:14 +00003853@subcommand.usage('[issue_number]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003854@metrics.collector.collect_metrics('git cl issue')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003855def CMDissue(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003856 """Sets or displays the current code review issue number.
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003857
3858 Pass issue number 0 to clear the current issue.
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003859 """
dnj@chromium.org406c4402015-03-03 17:22:28 +00003860 parser.add_option('-r', '--reverse', action='store_true',
3861 help='Lookup the branch(es) for the specified issues. If '
3862 'no issues are specified, all branches with mapped '
3863 'issues will be listed.')
Stefan Zager1306bd02017-06-22 19:26:46 -07003864 parser.add_option('--json',
3865 help='Path to JSON output file, or "-" for stdout.')
dnj@chromium.org406c4402015-03-03 17:22:28 +00003866 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003867
dnj@chromium.org406c4402015-03-03 17:22:28 +00003868 if options.reverse:
3869 branches = RunGit(['for-each-ref', 'refs/heads',
Aaron Gablead64abd2017-12-04 09:49:13 -08003870 '--format=%(refname)']).splitlines()
dnj@chromium.org406c4402015-03-03 17:22:28 +00003871 # Reverse issue lookup.
3872 issue_branch_map = {}
Daniel Bratellb56a43a2018-09-06 15:49:03 +00003873
3874 git_config = {}
3875 for config in RunGit(['config', '--get-regexp',
3876 r'branch\..*issue']).splitlines():
3877 name, _space, val = config.partition(' ')
3878 git_config[name] = val
3879
dnj@chromium.org406c4402015-03-03 17:22:28 +00003880 for branch in branches:
Edward Lemur85153282020-02-14 22:06:29 +00003881 config_key = _git_branch_config_key(scm.GIT.ShortBranchName(branch),
Edward Lemur52969c92020-02-06 18:15:28 +00003882 Changelist.IssueConfigKey())
3883 issue = git_config.get(config_key)
3884 if issue:
3885 issue_branch_map.setdefault(int(issue), []).append(branch)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003886 if not args:
3887 args = sorted(issue_branch_map.iterkeys())
phajdan.jre328cf92016-08-22 04:12:17 -07003888 result = {}
dnj@chromium.org406c4402015-03-03 17:22:28 +00003889 for issue in args:
Lei Zhang5a368d42019-03-25 23:18:19 +00003890 try:
3891 issue_num = int(issue)
3892 except ValueError:
3893 print('ERROR cannot parse issue number: %s' % issue, file=sys.stderr)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003894 continue
Lei Zhang5a368d42019-03-25 23:18:19 +00003895 result[issue_num] = issue_branch_map.get(issue_num)
vapiera7fbd5a2016-06-16 09:17:49 -07003896 print('Branch for issue number %s: %s' % (
Lei Zhang5a368d42019-03-25 23:18:19 +00003897 issue, ', '.join(issue_branch_map.get(issue_num) or ('None',))))
phajdan.jre328cf92016-08-22 04:12:17 -07003898 if options.json:
3899 write_json(options.json, result)
Aaron Gable78753da2017-06-15 10:35:49 -07003900 return 0
3901
3902 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00003903 issue = ParseIssueNumberArgument(args[0])
Aaron Gable78753da2017-06-15 10:35:49 -07003904 if not issue.valid:
3905 DieWithError('Pass a url or number to set the issue, 0 to unset it, '
3906 'or no argument to list it.\n'
3907 'Maybe you want to run git cl status?')
Edward Lemurf38bc172019-09-03 21:02:13 +00003908 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07003909 cl.SetIssue(issue.issue)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003910 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00003911 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07003912 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
3913 if options.json:
3914 write_json(options.json, {
3915 'issue': cl.GetIssue(),
3916 'issue_url': cl.GetIssueURL(),
3917 })
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003918 return 0
3919
3920
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003921@metrics.collector.collect_metrics('git cl comments')
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003922def CMDcomments(parser, args):
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003923 """Shows or posts review comments for any changelist."""
3924 parser.add_option('-a', '--add-comment', dest='comment',
3925 help='comment to add to an issue')
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00003926 parser.add_option('-p', '--publish', action='store_true',
3927 help='marks CL as ready and sends comment to reviewers')
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01003928 parser.add_option('-i', '--issue', dest='issue',
Edward Lemurf38bc172019-09-03 21:02:13 +00003929 help='review issue id (defaults to current issue).')
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003930 parser.add_option('-m', '--machine-readable', dest='readable',
3931 action='store_false', default=True,
3932 help='output comments in a format compatible with '
3933 'editor parsing')
smut@google.comc85ac942015-09-15 16:34:43 +00003934 parser.add_option('-j', '--json-file',
Stefan Zager1306bd02017-06-22 19:26:46 -07003935 help='File to write JSON summary to, or "-" for stdout')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003936 options, args = parser.parse_args(args)
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003937
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003938 issue = None
3939 if options.issue:
3940 try:
3941 issue = int(options.issue)
3942 except ValueError:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00003943 DieWithError('A review issue ID is expected to be a number.')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003944
Edward Lemur934836a2019-09-09 20:16:54 +00003945 cl = Changelist(issue=issue)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003946
3947 if options.comment:
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00003948 cl.AddComment(options.comment, options.publish)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003949 return 0
3950
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003951 summary = sorted(cl.GetCommentsSummary(readable=options.readable),
3952 key=lambda c: c.date)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003953 for comment in summary:
3954 if comment.disapproval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003955 color = Fore.RED
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003956 elif comment.approval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003957 color = Fore.GREEN
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003958 elif comment.sender == cl.GetIssueOwner():
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003959 color = Fore.MAGENTA
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003960 elif comment.autogenerated:
3961 color = Fore.CYAN
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003962 else:
3963 color = Fore.BLUE
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003964 print('\n%s%s %s%s\n%s' % (
3965 color,
3966 comment.date.strftime('%Y-%m-%d %H:%M:%S UTC'),
3967 comment.sender,
3968 Fore.RESET,
3969 '\n'.join(' ' + l for l in comment.message.strip().splitlines())))
3970
smut@google.comc85ac942015-09-15 16:34:43 +00003971 if options.json_file:
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003972 def pre_serialize(c):
Edward Lemur79d4f992019-11-11 23:49:02 +00003973 dct = c._asdict().copy()
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003974 dct['date'] = dct['date'].strftime('%Y-%m-%d %H:%M:%S.%f')
3975 return dct
Edward Lemur79d4f992019-11-11 23:49:02 +00003976 write_json(options.json_file, [pre_serialize(x) for x in summary])
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003977 return 0
3978
3979
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003980@subcommand.usage('[codereview url or issue id]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003981@metrics.collector.collect_metrics('git cl description')
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00003982def CMDdescription(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003983 """Brings up the editor for the current CL's description."""
smut@google.com34fb6b12015-07-13 20:03:26 +00003984 parser.add_option('-d', '--display', action='store_true',
3985 help='Display the description instead of opening an editor')
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003986 parser.add_option('-n', '--new-description',
dnjba1b0f32016-09-02 12:37:42 -07003987 help='New description to set for this issue (- for stdin, '
3988 '+ to load from local commit HEAD)')
dsansomee2d6fd92016-09-08 00:10:47 -07003989 parser.add_option('-f', '--force', action='store_true',
3990 help='Delete any unpublished Gerrit edits for this issue '
3991 'without prompting')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003992
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003993 options, args = parser.parse_args(args)
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003994
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003995 target_issue_arg = None
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003996 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00003997 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003998 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00003999 parser.error('Invalid issue ID or URL.')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004000
Edward Lemur934836a2019-09-09 20:16:54 +00004001 kwargs = {}
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004002 if target_issue_arg:
4003 kwargs['issue'] = target_issue_arg.issue
4004 kwargs['codereview_host'] = target_issue_arg.hostname
martiniss6eda05f2016-06-30 10:18:35 -07004005
4006 cl = Changelist(**kwargs)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004007 if not cl.GetIssue():
4008 DieWithError('This branch has no associated changelist.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004009
Edward Lemur678a6842019-10-03 22:25:05 +00004010 if args and not args[0].isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00004011 logging.info('canonical issue/change URL: %s\n', cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004012
Edward Lemur6c6827c2020-02-06 21:15:18 +00004013 description = ChangeDescription(cl.FetchDescription())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004014
smut@google.com34fb6b12015-07-13 20:03:26 +00004015 if options.display:
vapiera7fbd5a2016-06-16 09:17:49 -07004016 print(description.description)
smut@google.com34fb6b12015-07-13 20:03:26 +00004017 return 0
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004018
4019 if options.new_description:
4020 text = options.new_description
4021 if text == '-':
4022 text = '\n'.join(l.rstrip() for l in sys.stdin)
dnjba1b0f32016-09-02 12:37:42 -07004023 elif text == '+':
4024 base_branch = cl.GetCommonAncestorWithUpstream()
Edward Lemur7f6dec02020-02-06 20:23:58 +00004025 text = cl.GetLocalDescription(base_branch)
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004026
4027 description.set_description(text)
4028 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00004029 description.prompt()
Edward Lemur6c6827c2020-02-06 21:15:18 +00004030 if cl.FetchDescription().strip() != description.description:
dsansomee2d6fd92016-09-08 00:10:47 -07004031 cl.UpdateDescription(description.description, force=options.force)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004032 return 0
4033
4034
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004035@metrics.collector.collect_metrics('git cl lint')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004036def CMDlint(parser, args):
4037 """Runs cpplint on the current changelist."""
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004038 parser.add_option('--filter', action='append', metavar='-x,+y',
4039 help='Comma-separated list of cpplint\'s category-filters')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004040 options, args = parser.parse_args(args)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004041
4042 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08004043 # pylint: disable=protected-access
thestig@chromium.org44202a22014-03-11 19:22:18 +00004044 try:
4045 import cpplint
4046 import cpplint_chromium
4047 except ImportError:
vapiera7fbd5a2016-06-16 09:17:49 -07004048 print('Your depot_tools is missing cpplint.py and/or cpplint_chromium.py.')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004049 return 1
4050
4051 # Change the current working directory before calling lint so that it
4052 # shows the correct base.
4053 previous_cwd = os.getcwd()
4054 os.chdir(settings.GetRoot())
4055 try:
Edward Lemur934836a2019-09-09 20:16:54 +00004056 cl = Changelist()
Edward Lemur7f6dec02020-02-06 20:23:58 +00004057 change = cl.GetChange(cl.GetCommonAncestorWithUpstream())
thestig@chromium.org44202a22014-03-11 19:22:18 +00004058 files = [f.LocalPath() for f in change.AffectedFiles()]
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004059 if not files:
vapiera7fbd5a2016-06-16 09:17:49 -07004060 print('Cannot lint an empty CL')
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004061 return 1
thestig@chromium.org44202a22014-03-11 19:22:18 +00004062
4063 # Process cpplints arguments if any.
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004064 command = args + files
4065 if options.filter:
4066 command = ['--filter=' + ','.join(options.filter)] + command
4067 filenames = cpplint.ParseArguments(command)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004068
4069 white_regex = re.compile(settings.GetLintRegex())
4070 black_regex = re.compile(settings.GetLintIgnoreRegex())
4071 extra_check_functions = [cpplint_chromium.CheckPointerDeclarationWhitespace]
4072 for filename in filenames:
4073 if white_regex.match(filename):
4074 if black_regex.match(filename):
vapiera7fbd5a2016-06-16 09:17:49 -07004075 print('Ignoring file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004076 else:
4077 cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level,
4078 extra_check_functions)
4079 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004080 print('Skipping file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004081 finally:
4082 os.chdir(previous_cwd)
vapiera7fbd5a2016-06-16 09:17:49 -07004083 print('Total errors found: %d\n' % cpplint._cpplint_state.error_count)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004084 if cpplint._cpplint_state.error_count != 0:
4085 return 1
4086 return 0
4087
4088
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004089@metrics.collector.collect_metrics('git cl presubmit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004090def CMDpresubmit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004091 """Runs presubmit tests on the current changelist."""
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004092 parser.add_option('-u', '--upload', action='store_true',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004093 help='Run upload hook instead of the push hook')
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004094 parser.add_option('-f', '--force', action='store_true',
sbc@chromium.org495ad152012-09-04 23:07:42 +00004095 help='Run checks even if tree is dirty')
Aaron Gable8076c282017-11-29 14:39:41 -08004096 parser.add_option('--all', action='store_true',
4097 help='Run checks against all files, not just modified ones')
Edward Lesmes8e282792018-04-03 18:50:29 -04004098 parser.add_option('--parallel', action='store_true',
4099 help='Run all tests specified by input_api.RunTests in all '
4100 'PRESUBMIT files in parallel.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004101 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004102
sbc@chromium.org71437c02015-04-09 19:29:40 +00004103 if not options.force and git_common.is_dirty_git_tree('presubmit'):
vapiera7fbd5a2016-06-16 09:17:49 -07004104 print('use --force to check even if tree is dirty.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004105 return 1
4106
Edward Lemur934836a2019-09-09 20:16:54 +00004107 cl = Changelist()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004108 if args:
4109 base_branch = args[0]
4110 else:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00004111 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004112 base_branch = cl.GetCommonAncestorWithUpstream()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004113
Aaron Gable8076c282017-11-29 14:39:41 -08004114 if options.all:
Edward Lemur7f6dec02020-02-06 20:23:58 +00004115 base_change = cl.GetChange(base_branch)
Aaron Gable8076c282017-11-29 14:39:41 -08004116 files = [('M', f) for f in base_change.AllFiles()]
4117 change = presubmit_support.GitChange(
4118 base_change.Name(),
4119 base_change.FullDescriptionText(),
4120 base_change.RepositoryRoot(),
4121 files,
4122 base_change.issue,
4123 base_change.patchset,
4124 base_change.author_email,
4125 base_change._upstream)
4126 else:
Edward Lemur7f6dec02020-02-06 20:23:58 +00004127 change = cl.GetChange(base_branch)
Aaron Gable8076c282017-11-29 14:39:41 -08004128
ilevy@chromium.org051ad0e2013-03-04 21:57:34 +00004129 cl.RunHook(
4130 committing=not options.upload,
4131 may_prompt=False,
4132 verbose=options.verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04004133 change=change,
4134 parallel=options.parallel)
dpranke@chromium.org0a2bb372011-03-25 01:16:22 +00004135 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004136
4137
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004138def GenerateGerritChangeId(message):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004139 """Returns the Change ID footer value (Ixxxxxx...xxx).
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004140
4141 Works the same way as
4142 https://gerrit-review.googlesource.com/tools/hooks/commit-msg
4143 but can be called on demand on all platforms.
4144
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004145 The basic idea is to generate git hash of a state of the tree, original
4146 commit message, author/committer info and timestamps.
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004147 """
4148 lines = []
4149 tree_hash = RunGitSilent(['write-tree'])
4150 lines.append('tree %s' % tree_hash.strip())
4151 code, parent = RunGitWithCode(['rev-parse', 'HEAD~0'], suppress_stderr=False)
4152 if code == 0:
4153 lines.append('parent %s' % parent.strip())
4154 author = RunGitSilent(['var', 'GIT_AUTHOR_IDENT'])
4155 lines.append('author %s' % author.strip())
4156 committer = RunGitSilent(['var', 'GIT_COMMITTER_IDENT'])
4157 lines.append('committer %s' % committer.strip())
4158 lines.append('')
4159 # Note: Gerrit's commit-hook actually cleans message of some lines and
4160 # whitespace. This code is not doing this, but it clearly won't decrease
4161 # entropy.
4162 lines.append(message)
4163 change_hash = RunCommand(['git', 'hash-object', '-t', 'commit', '--stdin'],
Raul Tambreb946b232019-03-26 14:48:46 +00004164 stdin=('\n'.join(lines)).encode())
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004165 return 'I%s' % change_hash.strip()
4166
4167
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01004168def GetTargetRef(remote, remote_branch, target_branch):
wittman@chromium.org455dc922015-01-26 20:15:50 +00004169 """Computes the remote branch ref to use for the CL.
4170
4171 Args:
4172 remote (str): The git remote for the CL.
4173 remote_branch (str): The git remote branch for the CL.
4174 target_branch (str): The target branch specified by the user.
wittman@chromium.org455dc922015-01-26 20:15:50 +00004175 """
4176 if not (remote and remote_branch):
4177 return None
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004178
wittman@chromium.org455dc922015-01-26 20:15:50 +00004179 if target_branch:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004180 # Canonicalize branch references to the equivalent local full symbolic
wittman@chromium.org455dc922015-01-26 20:15:50 +00004181 # refs, which are then translated into the remote full symbolic refs
4182 # below.
4183 if '/' not in target_branch:
4184 remote_branch = 'refs/remotes/%s/%s' % (remote, target_branch)
4185 else:
4186 prefix_replacements = (
4187 ('^((refs/)?remotes/)?branch-heads/', 'refs/remotes/branch-heads/'),
4188 ('^((refs/)?remotes/)?%s/' % remote, 'refs/remotes/%s/' % remote),
4189 ('^(refs/)?heads/', 'refs/remotes/%s/' % remote),
4190 )
4191 match = None
4192 for regex, replacement in prefix_replacements:
4193 match = re.search(regex, target_branch)
4194 if match:
4195 remote_branch = target_branch.replace(match.group(0), replacement)
4196 break
4197 if not match:
4198 # This is a branch path but not one we recognize; use as-is.
4199 remote_branch = target_branch
rmistry@google.comc68112d2015-03-03 12:48:06 +00004200 elif remote_branch in REFS_THAT_ALIAS_TO_OTHER_REFS:
4201 # Handle the refs that need to land in different refs.
4202 remote_branch = REFS_THAT_ALIAS_TO_OTHER_REFS[remote_branch]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004203
wittman@chromium.org455dc922015-01-26 20:15:50 +00004204 # Create the true path to the remote branch.
4205 # Does the following translation:
4206 # * refs/remotes/origin/refs/diff/test -> refs/diff/test
4207 # * refs/remotes/origin/master -> refs/heads/master
4208 # * refs/remotes/branch-heads/test -> refs/branch-heads/test
4209 if remote_branch.startswith('refs/remotes/%s/refs/' % remote):
4210 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, '')
4211 elif remote_branch.startswith('refs/remotes/%s/' % remote):
4212 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote,
4213 'refs/heads/')
4214 elif remote_branch.startswith('refs/remotes/branch-heads'):
4215 remote_branch = remote_branch.replace('refs/remotes/', 'refs/')
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01004216
wittman@chromium.org455dc922015-01-26 20:15:50 +00004217 return remote_branch
4218
4219
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004220def cleanup_list(l):
4221 """Fixes a list so that comma separated items are put as individual items.
4222
4223 So that "--reviewers joe@c,john@c --reviewers joa@c" results in
4224 options.reviewers == sorted(['joe@c', 'john@c', 'joa@c']).
4225 """
4226 items = sum((i.split(',') for i in l), [])
4227 stripped_items = (i.strip() for i in items)
4228 return sorted(filter(None, stripped_items))
4229
4230
Aaron Gable4db38df2017-11-03 14:59:07 -07004231@subcommand.usage('[flags]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004232@metrics.collector.collect_metrics('git cl upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004233def CMDupload(parser, args):
rmistry@google.com78948ed2015-07-08 23:09:57 +00004234 """Uploads the current changelist to codereview.
4235
4236 Can skip dependency patchset uploads for a branch by running:
4237 git config branch.branch_name.skip-deps-uploads True
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004238 To unset, run:
rmistry@google.com78948ed2015-07-08 23:09:57 +00004239 git config --unset branch.branch_name.skip-deps-uploads
4240 Can also set the above globally by using the --global flag.
Dominic Battre7d1c4842017-10-27 09:17:28 +02004241
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004242 If the name of the checked out branch starts with "bug-" or "fix-" followed
4243 by a bug number, this bug number is automatically populated in the CL
Dominic Battre7d1c4842017-10-27 09:17:28 +02004244 description.
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004245
4246 If subject contains text in square brackets or has "<text>: " prefix, such
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004247 text(s) is treated as Gerrit hashtags. For example, CLs with subjects:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004248 [git-cl] add support for hashtags
4249 Foo bar: implement foo
4250 will be hashtagged with "git-cl" and "foo-bar" respectively.
rmistry@google.com78948ed2015-07-08 23:09:57 +00004251 """
ukai@chromium.orge8077812012-02-03 03:41:46 +00004252 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4253 help='bypass upload presubmit hook')
brettw@chromium.orgb65c43c2013-06-10 22:04:49 +00004254 parser.add_option('--bypass-watchlists', action='store_true',
4255 dest='bypass_watchlists',
4256 help='bypass watchlists auto CC-ing reviewers')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004257 parser.add_option('-f', '--force', action='store_true', dest='force',
ukai@chromium.orge8077812012-02-03 03:41:46 +00004258 help="force yes to questions (don't prompt)")
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004259 parser.add_option('--message', '-m', dest='message',
4260 help='message for patchset')
tandriif9aefb72016-07-01 09:06:51 -07004261 parser.add_option('-b', '--bug',
4262 help='pre-populate the bug number(s) for this issue. '
4263 'If several, separate with commas')
tandriib80458a2016-06-23 12:20:07 -07004264 parser.add_option('--message-file', dest='message_file',
4265 help='file which contains message for patchset')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004266 parser.add_option('--title', '-t', dest='title',
4267 help='title for patchset')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004268 parser.add_option('-r', '--reviewers',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004269 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004270 help='reviewer email addresses')
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004271 parser.add_option('--tbrs',
4272 action='append', default=[],
4273 help='TBR email addresses')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004274 parser.add_option('--cc',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004275 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004276 help='cc email addresses')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004277 parser.add_option('--hashtag', dest='hashtags',
4278 action='append', default=[],
4279 help=('Gerrit hashtag for new CL; '
4280 'can be applied multiple times'))
adamk@chromium.org36f47302013-04-05 01:08:31 +00004281 parser.add_option('-s', '--send-mail', action='store_true',
Aaron Gable59f48512017-01-12 10:54:46 -08004282 help='send email to reviewer(s) and cc(s) immediately')
ukai@chromium.org8ef7ab22012-11-28 04:24:52 +00004283 parser.add_option('--target_branch',
pgervais@chromium.orgb9f27512014-08-08 15:52:33 +00004284 '--target-branch',
wittman@chromium.org455dc922015-01-26 20:15:50 +00004285 metavar='TARGET',
4286 help='Apply CL to remote ref TARGET. ' +
4287 'Default: remote branch head, or master')
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004288 parser.add_option('--squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004289 help='Squash multiple commits into one')
Mike Frysingera989d552019-08-14 20:51:23 +00004290 parser.add_option('--no-squash', action='store_false', dest='squash',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004291 help='Don\'t squash multiple commits into one')
rmistry9eadede2016-09-19 11:22:43 -07004292 parser.add_option('--topic', default=None,
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004293 help='Topic to specify when uploading')
Robert Iannuccif2708bd2017-04-17 15:49:02 -07004294 parser.add_option('--tbr-owners', dest='add_owners_to', action='store_const',
4295 const='TBR', help='add a set of OWNERS to TBR')
4296 parser.add_option('--r-owners', dest='add_owners_to', action='store_const',
4297 const='R', help='add a set of OWNERS to R')
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004298 parser.add_option('-c', '--use-commit-queue', action='store_true',
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004299 default=False,
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004300 help='tell the CQ to commit this patchset; '
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004301 'implies --send-mail')
4302 parser.add_option('-d', '--cq-dry-run',
4303 action='store_true', default=False,
rmistry@google.comef966222015-04-07 11:15:01 +00004304 help='Send the patchset to do a CQ dry run right after '
4305 'upload.')
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00004306 parser.add_option('--preserve-tryjobs', action='store_true',
4307 help='instruct the CQ to let tryjobs running even after '
4308 'new patchsets are uploaded instead of canceling '
4309 'prior patchset\' tryjobs')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004310 parser.add_option('--dependencies', action='store_true',
4311 help='Uploads CLs of all the local branches that depend on '
4312 'the current branch')
Ravi Mistry31e7d562018-04-02 12:53:57 -04004313 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4314 help='Sends your change to the CQ after an approval. Only '
4315 'works on repos that have the Auto-Submit label '
4316 'enabled')
Edward Lesmes8e282792018-04-03 18:50:29 -04004317 parser.add_option('--parallel', action='store_true',
4318 help='Run all tests specified by input_api.RunTests in all '
4319 'PRESUBMIT files in parallel.')
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004320 parser.add_option('--no-autocc', action='store_true',
4321 help='Disables automatic addition of CC emails')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004322 parser.add_option('--private', action='store_true',
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004323 help='Set the review private. This implies --no-autocc.')
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004324 parser.add_option('-R', '--retry-failed', action='store_true',
4325 help='Retry failed tryjobs from old patchset immediately '
4326 'after uploading new patchset. Cannot be used with '
4327 '--use-commit-queue or --cq-dry-run.')
4328 parser.add_option('--buildbucket-host', default='cr-buildbucket.appspot.com',
4329 help='Host of buildbucket. The default host is %default.')
Dan Beamd8b04ca2019-10-10 21:23:26 +00004330 parser.add_option('--fixed', '-x',
4331 help='List of bugs that will be commented on and marked '
4332 'fixed (pre-populates "Fixed:" tag). Same format as '
4333 '-b option / "Bug:" tag. If fixing several issues, '
4334 'separate with commas.')
Josipe827b0f2020-01-30 00:07:20 +00004335 parser.add_option('--edit-description', action='store_true', default=False,
4336 help='Modify description before upload. Cannot be used '
4337 'with --force. It is a noop when --no-squash is set '
4338 'or a new commit is created.')
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004339
rmistry@google.com2dd99862015-06-22 12:22:18 +00004340 orig_args = args
ukai@chromium.orge8077812012-02-03 03:41:46 +00004341 (options, args) = parser.parse_args(args)
4342
sbc@chromium.org71437c02015-04-09 19:29:40 +00004343 if git_common.is_dirty_git_tree('upload'):
ukai@chromium.orge8077812012-02-03 03:41:46 +00004344 return 1
4345
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004346 options.reviewers = cleanup_list(options.reviewers)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004347 options.tbrs = cleanup_list(options.tbrs)
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004348 options.cc = cleanup_list(options.cc)
4349
Josipe827b0f2020-01-30 00:07:20 +00004350 if options.edit_description and options.force:
4351 parser.error('Only one of --force and --edit-description allowed')
4352
tandriib80458a2016-06-23 12:20:07 -07004353 if options.message_file:
4354 if options.message:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004355 parser.error('Only one of --message and --message-file allowed.')
tandriib80458a2016-06-23 12:20:07 -07004356 options.message = gclient_utils.FileRead(options.message_file)
4357 options.message_file = None
4358
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004359 if ([options.cq_dry_run,
4360 options.use_commit_queue,
4361 options.retry_failed].count(True) > 1):
4362 parser.error('Only one of --use-commit-queue, --cq-dry-run, or '
4363 '--retry-failed is allowed.')
tandrii4d0545a2016-07-06 03:56:49 -07004364
Aaron Gableedbc4132017-09-11 13:22:28 -07004365 if options.use_commit_queue:
4366 options.send_mail = True
4367
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00004368 # For sanity of test expectations, do this otherwise lazy-loading *now*.
4369 settings.GetIsGerrit()
4370
Edward Lemur934836a2019-09-09 20:16:54 +00004371 cl = Changelist()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004372 if options.retry_failed and not cl.GetIssue():
4373 print('No previous patchsets, so --retry-failed has no effect.')
4374 options.retry_failed = False
4375 # cl.GetMostRecentPatchset uses cached information, and can return the last
4376 # patchset before upload. Calling it here makes it clear that it's the
4377 # last patchset before upload. Note that GetMostRecentPatchset will fail
4378 # if no CL has been uploaded yet.
4379 if options.retry_failed:
4380 patchset = cl.GetMostRecentPatchset()
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00004381
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004382 ret = cl.CMDUpload(options, args, orig_args)
4383
4384 if options.retry_failed:
4385 if ret != 0:
4386 print('Upload failed, so --retry-failed has no effect.')
4387 return ret
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00004388 builds, _ = _fetch_latest_builds(
Edward Lemur5b929a42019-10-21 17:57:39 +00004389 cl, options.buildbucket_host, latest_patchset=patchset)
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00004390 buckets = _filter_failed_for_retry(builds)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004391 if len(buckets) == 0:
4392 print('No failed tryjobs, so --retry-failed has no effect.')
4393 return ret
Edward Lemur5b929a42019-10-21 17:57:39 +00004394 _trigger_try_jobs(cl, buckets, options, patchset + 1)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004395
4396 return ret
ukai@chromium.orge8077812012-02-03 03:41:46 +00004397
4398
Francois Dorayd42c6812017-05-30 15:10:20 -04004399@subcommand.usage('--description=<description file>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004400@metrics.collector.collect_metrics('git cl split')
Francois Dorayd42c6812017-05-30 15:10:20 -04004401def CMDsplit(parser, args):
4402 """Splits a branch into smaller branches and uploads CLs.
4403
4404 Creates a branch and uploads a CL for each group of files modified in the
4405 current branch that share a common OWNERS file. In the CL description and
Yannic Bonenberger68409632020-01-23 18:29:01 +00004406 comment, '$directory' is replaced with the directory containing the changes
4407 in this CL, '$cl_index' is replaced with the index of the CL we're currently
4408 sending out, and '$num_cls' is replaced with the total number of CLs that
4409 we're sending out in this split.
Francois Dorayd42c6812017-05-30 15:10:20 -04004410 """
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004411 parser.add_option('-d', '--description', dest='description_file',
4412 help='A text file containing a CL description in which '
4413 '$directory will be replaced by each CL\'s directory.')
4414 parser.add_option('-c', '--comment', dest='comment_file',
4415 help='A text file containing a CL comment.')
4416 parser.add_option('-n', '--dry-run', dest='dry_run', action='store_true',
Chris Watkinsba28e462017-12-13 11:22:17 +11004417 default=False,
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004418 help='List the files and reviewers for each CL that would '
4419 'be created, but don\'t create branches or CLs.')
4420 parser.add_option('--cq-dry-run', action='store_true',
4421 help='If set, will do a cq dry run for each uploaded CL. '
4422 'Please be careful when doing this; more than ~10 CLs '
4423 'has the potential to overload our build '
4424 'infrastructure. Try to upload these not during high '
4425 'load times (usually 11-3 Mountain View time). Email '
4426 'infra-dev@chromium.org with any questions.')
Takuto Ikuta51eca592019-02-14 19:40:52 +00004427 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4428 default=True,
4429 help='Sends your change to the CQ after an approval. Only '
4430 'works on repos that have the Auto-Submit label '
4431 'enabled')
Francois Dorayd42c6812017-05-30 15:10:20 -04004432 options, _ = parser.parse_args(args)
4433
4434 if not options.description_file:
4435 parser.error('No --description flag specified.')
4436
4437 def WrappedCMDupload(args):
4438 return CMDupload(OptionParser(), args)
4439
4440 return split_cl.SplitCl(options.description_file, options.comment_file,
Stephen Martiniscb326682018-08-29 21:06:30 +00004441 Changelist, WrappedCMDupload, options.dry_run,
Takuto Ikuta51eca592019-02-14 19:40:52 +00004442 options.cq_dry_run, options.enable_auto_submit)
Francois Dorayd42c6812017-05-30 15:10:20 -04004443
4444
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004445@subcommand.usage('DEPRECATED')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004446@metrics.collector.collect_metrics('git cl commit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004447def CMDdcommit(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004448 """DEPRECATED: Used to commit the current changelist via git-svn."""
4449 message = ('git-cl no longer supports committing to SVN repositories via '
4450 'git-svn. You probably want to use `git cl land` instead.')
4451 print(message)
4452 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004453
4454
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004455@subcommand.usage('[upstream branch to apply against]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004456@metrics.collector.collect_metrics('git cl land')
pgervais@chromium.orgcee6dc42014-05-07 17:04:03 +00004457def CMDland(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004458 """Commits the current changelist via git.
4459
4460 In case of Gerrit, uses Gerrit REST api to "submit" the issue, which pushes
4461 upstream and closes the issue automatically and atomically.
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004462 """
4463 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4464 help='bypass upload presubmit hook')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004465 parser.add_option('-f', '--force', action='store_true', dest='force',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004466 help="force yes to questions (don't prompt)")
Edward Lesmes67b3faa2018-04-13 17:50:52 -04004467 parser.add_option('--parallel', action='store_true',
4468 help='Run all tests specified by input_api.RunTests in all '
4469 'PRESUBMIT files in parallel.')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004470 (options, args) = parser.parse_args(args)
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004471
Edward Lemur934836a2019-09-09 20:16:54 +00004472 cl = Changelist()
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004473
Robert Iannucci2e73d432018-03-14 01:10:47 -07004474 if not cl.GetIssue():
4475 DieWithError('You must upload the change first to Gerrit.\n'
4476 ' If you would rather have `git cl land` upload '
4477 'automatically for you, see http://crbug.com/642759')
Edward Lemur125d60a2019-09-13 18:25:41 +00004478 return cl.CMDLand(options.force, options.bypass_hooks,
Olivier Robin75ee7252018-04-13 10:02:56 +02004479 options.verbose, options.parallel)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004480
4481
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004482@subcommand.usage('<patch url or issue id or issue url>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004483@metrics.collector.collect_metrics('git cl patch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004484def CMDpatch(parser, args):
marq@chromium.orge5e59002013-10-02 23:21:25 +00004485 """Patches in a code review."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004486 parser.add_option('-b', dest='newbranch',
4487 help='create a new branch off trunk for the patch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00004488 parser.add_option('-f', '--force', action='store_true',
Aaron Gable62619a32017-06-16 08:22:09 -07004489 help='overwrite state on the current or chosen branch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004490 parser.add_option('-n', '--no-commit', action='store_true', dest='nocommit',
Edward Lemurf38bc172019-09-03 21:02:13 +00004491 help='don\'t commit after patch applies.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004492
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004493 group = optparse.OptionGroup(
4494 parser,
4495 'Options for continuing work on the current issue uploaded from a '
4496 'different clone (e.g. different machine). Must be used independently '
4497 'from the other options. No issue number should be specified, and the '
4498 'branch must have an issue number associated with it')
4499 group.add_option('--reapply', action='store_true', dest='reapply',
4500 help='Reset the branch and reapply the issue.\n'
4501 'CAUTION: This will undo any local changes in this '
4502 'branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004503
4504 group.add_option('--pull', action='store_true', dest='pull',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004505 help='Performs a pull before reapplying.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004506 parser.add_option_group(group)
4507
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004508 (options, args) = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004509
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004510 if options.reapply:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004511 if options.newbranch:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004512 parser.error('--reapply works on the current branch only.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004513 if len(args) > 0:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004514 parser.error('--reapply implies no additional arguments.')
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004515
Edward Lemur934836a2019-09-09 20:16:54 +00004516 cl = Changelist()
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004517 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004518 parser.error('Current branch must have an associated issue.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004519
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004520 upstream = cl.GetUpstreamBranch()
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004521 if upstream is None:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004522 parser.error('No upstream branch specified. Cannot reset branch.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004523
4524 RunGit(['reset', '--hard', upstream])
4525 if options.pull:
4526 RunGit(['pull'])
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004527
Edward Lemur678a6842019-10-03 22:25:05 +00004528 target_issue_arg = ParseIssueNumberArgument(cl.GetIssue())
4529 return cl.CMDPatchWithParsedIssue(target_issue_arg, options.nocommit, False)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004530
4531 if len(args) != 1 or not args[0]:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004532 parser.error('Must specify issue number or URL.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004533
Edward Lemurf38bc172019-09-03 21:02:13 +00004534 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004535 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004536 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004537
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004538 # We don't want uncommitted changes mixed up with the patch.
4539 if git_common.is_dirty_git_tree('patch'):
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004540 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004541
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004542 if options.newbranch:
4543 if options.force:
4544 RunGit(['branch', '-D', options.newbranch],
4545 stderr=subprocess2.PIPE, error_ok=True)
Edward Lemur85153282020-02-14 22:06:29 +00004546 git_new_branch.main(options.newbranch)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004547
Edward Lemur678a6842019-10-03 22:25:05 +00004548 cl = Changelist(
4549 codereview_host=target_issue_arg.hostname, issue=target_issue_arg.issue)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004550
Edward Lemur678a6842019-10-03 22:25:05 +00004551 if not args[0].isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00004552 print('canonical issue/change URL: %s\n' % cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004553
Edward Lemurf38bc172019-09-03 21:02:13 +00004554 return cl.CMDPatchWithParsedIssue(
4555 target_issue_arg, options.nocommit, options.force)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004556
4557
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004558def GetTreeStatus(url=None):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004559 """Fetches the tree status and returns either 'open', 'closed',
4560 'unknown' or 'unset'."""
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004561 url = url or settings.GetTreeStatusUrl(error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004562 if url:
Edward Lemur79d4f992019-11-11 23:49:02 +00004563 status = urllib.request.urlopen(url).read().lower()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004564 if status.find('closed') != -1 or status == '0':
4565 return 'closed'
4566 elif status.find('open') != -1 or status == '1':
4567 return 'open'
4568 return 'unknown'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004569 return 'unset'
4570
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004571
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004572def GetTreeStatusReason():
4573 """Fetches the tree status from a json url and returns the message
4574 with the reason for the tree to be opened or closed."""
msb@chromium.orgbf1a7ba2011-02-01 16:21:46 +00004575 url = settings.GetTreeStatusUrl()
4576 json_url = urlparse.urljoin(url, '/current?format=json')
Edward Lemur79d4f992019-11-11 23:49:02 +00004577 connection = urllib.request.urlopen(json_url)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004578 status = json.loads(connection.read())
4579 connection.close()
4580 return status['message']
4581
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004582
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004583@metrics.collector.collect_metrics('git cl tree')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004584def CMDtree(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004585 """Shows the status of the tree."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004586 _, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004587 status = GetTreeStatus()
4588 if 'unset' == status:
vapiera7fbd5a2016-06-16 09:17:49 -07004589 print('You must configure your tree status URL by running "git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004590 return 2
4591
vapiera7fbd5a2016-06-16 09:17:49 -07004592 print('The tree is %s' % status)
4593 print()
4594 print(GetTreeStatusReason())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004595 if status != 'open':
4596 return 1
4597 return 0
4598
4599
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004600@metrics.collector.collect_metrics('git cl try')
maruel@chromium.org15192402012-09-06 12:38:29 +00004601def CMDtry(parser, args):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004602 """Triggers tryjobs using either Buildbucket or CQ dry run."""
4603 group = optparse.OptionGroup(parser, 'Tryjob options')
maruel@chromium.org15192402012-09-06 12:38:29 +00004604 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004605 '-b', '--bot', action='append',
4606 help=('IMPORTANT: specify ONE builder per --bot flag. Use it multiple '
4607 'times to specify multiple builders. ex: '
4608 '"-b win_rel -b win_layout". See '
4609 'the try server waterfall for the builders name and the tests '
4610 'available.'))
maruel@chromium.org15192402012-09-06 12:38:29 +00004611 group.add_option(
borenet6c0efe62016-10-19 08:13:29 -07004612 '-B', '--bucket', default='',
4613 help=('Buildbucket bucket to send the try requests.'))
4614 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004615 '-r', '--revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004616 help='Revision to use for the tryjob; default: the revision will '
tandriif7b29d42016-10-07 08:45:41 -07004617 'be determined by the try recipe that builder runs, which usually '
4618 'defaults to HEAD of origin/master')
maruel@chromium.org15192402012-09-06 12:38:29 +00004619 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004620 '-c', '--clobber', action='store_true', default=False,
tandriif7b29d42016-10-07 08:45:41 -07004621 help='Force a clobber before building; that is don\'t do an '
tandrii1838bad2016-10-06 00:10:52 -07004622 'incremental build')
maruel@chromium.org15192402012-09-06 12:38:29 +00004623 group.add_option(
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08004624 '--category', default='git_cl_try', help='Specify custom build category.')
4625 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004626 '--project',
4627 help='Override which project to use. Projects are defined '
tandriif7b29d42016-10-07 08:45:41 -07004628 'in recipe to determine to which repository or directory to '
4629 'apply the patch')
maruel@chromium.org15192402012-09-06 12:38:29 +00004630 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004631 '-p', '--property', dest='properties', action='append', default=[],
4632 help='Specify generic properties in the form -p key1=value1 -p '
tandriif7b29d42016-10-07 08:45:41 -07004633 'key2=value2 etc. The value will be treated as '
4634 'json if decodable, or as string otherwise. '
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004635 'NOTE: using this may make your tryjob not usable for CQ, '
4636 'which will then schedule another tryjob with default properties')
sheyang@chromium.orgdb375572015-08-17 19:22:23 +00004637 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004638 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4639 help='Host of buildbucket. The default host is %default.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004640 parser.add_option_group(group)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004641 parser.add_option(
4642 '-R', '--retry-failed', action='store_true', default=False,
4643 help='Retry failed jobs from the latest set of tryjobs. '
4644 'Not allowed with --bucket and --bot options.')
Edward Lemur52969c92020-02-06 18:15:28 +00004645 parser.add_option(
4646 '-i', '--issue', type=int,
4647 help='Operate on this issue instead of the current branch\'s implicit '
4648 'issue.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004649 options, args = parser.parse_args(args)
4650
machenbach@chromium.org45453142015-09-15 08:45:22 +00004651 # Make sure that all properties are prop=value pairs.
4652 bad_params = [x for x in options.properties if '=' not in x]
4653 if bad_params:
4654 parser.error('Got properties with missing "=": %s' % bad_params)
4655
maruel@chromium.org15192402012-09-06 12:38:29 +00004656 if args:
4657 parser.error('Unknown arguments: %s' % args)
4658
Edward Lemur934836a2019-09-09 20:16:54 +00004659 cl = Changelist(issue=options.issue)
maruel@chromium.org15192402012-09-06 12:38:29 +00004660 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004661 parser.error('Need to upload first.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004662
Edward Lemurf38bc172019-09-03 21:02:13 +00004663 # HACK: warm up Gerrit change detail cache to save on RPCs.
Edward Lemur125d60a2019-09-13 18:25:41 +00004664 cl._GetChangeDetail(['DETAILED_ACCOUNTS', 'ALL_REVISIONS'])
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01004665
tandriie113dfd2016-10-11 10:20:12 -07004666 error_message = cl.CannotTriggerTryJobReason()
4667 if error_message:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004668 parser.error('Can\'t trigger tryjobs: %s' % error_message)
jrobbins@chromium.org16f10f72014-06-24 22:14:36 +00004669
Quinten Yearsley983111f2019-09-26 17:18:48 +00004670 if options.retry_failed:
4671 if options.bot or options.bucket:
4672 print('ERROR: The option --retry-failed is not compatible with '
4673 '-B, -b, --bucket, or --bot.', file=sys.stderr)
4674 return 1
4675 print('Searching for failed tryjobs...')
Edward Lemur5b929a42019-10-21 17:57:39 +00004676 builds, patchset = _fetch_latest_builds(cl, options.buildbucket_host)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004677 if options.verbose:
4678 print('Got %d builds in patchset #%d' % (len(builds), patchset))
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00004679 buckets = _filter_failed_for_retry(builds)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004680 if not buckets:
4681 print('There are no failed jobs in the latest set of jobs '
4682 '(patchset #%d), doing nothing.' % patchset)
4683 return 0
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00004684 num_builders = sum(map(len, buckets.values()))
Quinten Yearsley983111f2019-09-26 17:18:48 +00004685 if num_builders > 10:
4686 confirm_or_exit('There are %d builders with failed builds.'
4687 % num_builders, action='continue')
4688 else:
4689 buckets = _get_bucket_map(cl, options, parser)
4690 if buckets and any(b.startswith('master.') for b in buckets):
4691 print('ERROR: Buildbot masters are not supported.')
4692 return 1
phajdan.jr@chromium.org8da7f272014-03-14 01:28:39 +00004693
qyearsleydd49f942016-10-28 11:57:22 -07004694 # If no bots are listed and we couldn't get a list based on PRESUBMIT files,
4695 # then we default to triggering a CQ dry run (see http://crbug.com/625697).
qyearsley1fdfcb62016-10-24 13:22:03 -07004696 if not buckets:
qyearsley1fdfcb62016-10-24 13:22:03 -07004697 if options.verbose:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07004698 print('git cl try with no bots now defaults to CQ dry run.')
4699 print('Scheduling CQ dry run on: %s' % cl.GetIssueURL())
4700 return cl.SetCQState(_CQState.DRY_RUN)
stip@chromium.org43064fd2013-12-18 20:07:44 +00004701
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00004702 for builders in buckets.values():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00004703 if any('triggered' in b for b in builders):
vapiera7fbd5a2016-06-16 09:17:49 -07004704 print('ERROR You are trying to send a job to a triggered bot. This type '
tandriide281ae2016-10-12 06:02:30 -07004705 'of bot requires an initial job from a parent (usually a builder). '
4706 'Instead send your job to the parent.\n'
vapiera7fbd5a2016-06-16 09:17:49 -07004707 'Bot list: %s' % builders, file=sys.stderr)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00004708 return 1
ilevy@chromium.orgf3b21232012-09-24 20:48:55 +00004709
ilevy@chromium.org36e420b2013-08-06 23:21:12 +00004710 patchset = cl.GetMostRecentPatchset()
Edward Lemur2c210a42019-09-16 23:58:35 +00004711 try:
Edward Lemur5b929a42019-10-21 17:57:39 +00004712 _trigger_try_jobs(cl, buckets, options, patchset)
Edward Lemur2c210a42019-09-16 23:58:35 +00004713 except BuildbucketResponseException as ex:
4714 print('ERROR: %s' % ex)
4715 return 1
4716 return 0
maruel@chromium.org15192402012-09-06 12:38:29 +00004717
4718
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004719@metrics.collector.collect_metrics('git cl try-results')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004720def CMDtry_results(parser, args):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00004721 """Prints info about results for tryjobs associated with the current CL."""
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004722 group = optparse.OptionGroup(parser, 'Tryjob results options')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004723 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004724 '-p', '--patchset', type=int, help='patchset number if not current.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004725 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004726 '--print-master', action='store_true', help='print master name as well.')
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +00004727 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004728 '--color', action='store_true', default=setup_color.IS_TTY,
4729 help='force color output, useful when piping output.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004730 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004731 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4732 help='Host of buildbucket. The default host is %default.')
qyearsley53f48a12016-09-01 10:45:13 -07004733 group.add_option(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004734 '--json', help=('Path of JSON output file to write tryjob results to,'
Stefan Zager1306bd02017-06-22 19:26:46 -07004735 'or "-" for stdout.'))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004736 parser.add_option_group(group)
Edward Lemur52969c92020-02-06 18:15:28 +00004737 parser.add_option(
4738 '-i', '--issue', type=int,
4739 help='Operate on this issue instead of the current branch\'s implicit '
4740 'issue.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004741 options, args = parser.parse_args(args)
4742 if args:
4743 parser.error('Unrecognized args: %s' % ' '.join(args))
4744
Edward Lemur934836a2019-09-09 20:16:54 +00004745 cl = Changelist(issue=options.issue)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004746 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004747 parser.error('Need to upload first.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004748
tandrii221ab252016-10-06 08:12:04 -07004749 patchset = options.patchset
4750 if not patchset:
4751 patchset = cl.GetMostRecentPatchset()
4752 if not patchset:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004753 parser.error('Code review host doesn\'t know about issue %s. '
tandrii221ab252016-10-06 08:12:04 -07004754 'No access to issue or wrong issue number?\n'
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004755 'Either upload first, or pass --patchset explicitly.' %
tandrii221ab252016-10-06 08:12:04 -07004756 cl.GetIssue())
4757
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004758 try:
Edward Lemur5b929a42019-10-21 17:57:39 +00004759 jobs = fetch_try_jobs(cl, options.buildbucket_host, patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004760 except BuildbucketResponseException as ex:
vapiera7fbd5a2016-06-16 09:17:49 -07004761 print('Buildbucket error: %s' % ex)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004762 return 1
qyearsley53f48a12016-09-01 10:45:13 -07004763 if options.json:
Edward Lemurbaaf6be2019-10-09 18:00:44 +00004764 write_json(options.json, jobs)
qyearsley53f48a12016-09-01 10:45:13 -07004765 else:
4766 print_try_jobs(options, jobs)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004767 return 0
4768
4769
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004770@subcommand.usage('[new upstream branch]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004771@metrics.collector.collect_metrics('git cl upstream')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004772def CMDupstream(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004773 """Prints or sets the name of the upstream branch, if any."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004774 _, args = parser.parse_args(args)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004775 if len(args) > 1:
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004776 parser.error('Unrecognized args: %s' % ' '.join(args))
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004777
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004778 cl = Changelist()
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004779 if args:
4780 # One arg means set upstream branch.
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004781 branch = cl.GetBranch()
stip7a3dd352016-09-22 17:32:28 -07004782 RunGit(['branch', '--set-upstream-to', args[0], branch])
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004783 cl = Changelist()
vapiera7fbd5a2016-06-16 09:17:49 -07004784 print('Upstream branch set to %s' % (cl.GetUpstreamBranch(),))
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004785
4786 # Clear configured merge-base, if there is one.
4787 git_common.remove_merge_base(branch)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004788 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004789 print(cl.GetUpstreamBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004790 return 0
4791
4792
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004793@metrics.collector.collect_metrics('git cl web')
thestig@chromium.org00858c82013-12-02 23:08:03 +00004794def CMDweb(parser, args):
4795 """Opens the current CL in the web browser."""
4796 _, args = parser.parse_args(args)
4797 if args:
4798 parser.error('Unrecognized args: %s' % ' '.join(args))
4799
4800 issue_url = Changelist().GetIssueURL()
4801 if not issue_url:
vapiera7fbd5a2016-06-16 09:17:49 -07004802 print('ERROR No issue to open', file=sys.stderr)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004803 return 1
4804
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004805 # Redirect I/O before invoking browser to hide its output. For example, this
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004806 # allows us to hide the "Created new window in existing browser session."
4807 # message from Chrome. Based on https://stackoverflow.com/a/2323563.
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004808 saved_stdout = os.dup(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004809 saved_stderr = os.dup(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004810 os.close(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004811 os.close(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004812 os.open(os.devnull, os.O_RDWR)
4813 try:
4814 webbrowser.open(issue_url)
4815 finally:
4816 os.dup2(saved_stdout, 1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004817 os.dup2(saved_stderr, 2)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004818 return 0
4819
4820
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004821@metrics.collector.collect_metrics('git cl set-commit')
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004822def CMDset_commit(parser, args):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004823 """Sets the commit bit to trigger the CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004824 parser.add_option('-d', '--dry-run', action='store_true',
4825 help='trigger in dry run mode')
4826 parser.add_option('-c', '--clear', action='store_true',
4827 help='stop CQ run, if any')
Edward Lemur52969c92020-02-06 18:15:28 +00004828 parser.add_option(
4829 '-i', '--issue', type=int,
4830 help='Operate on this issue instead of the current branch\'s implicit '
4831 'issue.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004832 options, args = parser.parse_args(args)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004833 if args:
4834 parser.error('Unrecognized args: %s' % ' '.join(args))
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004835 if options.dry_run and options.clear:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004836 parser.error('Only one of --dry-run and --clear are allowed.')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004837
Edward Lemur934836a2019-09-09 20:16:54 +00004838 cl = Changelist(issue=options.issue)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004839 if options.clear:
tandriid9e5ce52016-07-13 02:32:59 -07004840 state = _CQState.NONE
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004841 elif options.dry_run:
4842 state = _CQState.DRY_RUN
4843 else:
4844 state = _CQState.COMMIT
4845 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004846 parser.error('Must upload the issue first.')
tandrii9de9ec62016-07-13 03:01:59 -07004847 cl.SetCQState(state)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004848 return 0
4849
4850
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004851@metrics.collector.collect_metrics('git cl set-close')
groby@chromium.org411034a2013-02-26 15:12:01 +00004852def CMDset_close(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004853 """Closes the issue."""
Edward Lemur52969c92020-02-06 18:15:28 +00004854 parser.add_option(
4855 '-i', '--issue', type=int,
4856 help='Operate on this issue instead of the current branch\'s implicit '
4857 'issue.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004858 options, args = parser.parse_args(args)
groby@chromium.org411034a2013-02-26 15:12:01 +00004859 if args:
4860 parser.error('Unrecognized args: %s' % ' '.join(args))
Edward Lemur934836a2019-09-09 20:16:54 +00004861 cl = Changelist(issue=options.issue)
groby@chromium.org411034a2013-02-26 15:12:01 +00004862 # Ensure there actually is an issue to close.
Aaron Gable7139a4e2017-09-05 17:53:09 -07004863 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004864 DieWithError('ERROR: No issue to close.')
groby@chromium.org411034a2013-02-26 15:12:01 +00004865 cl.CloseIssue()
4866 return 0
4867
4868
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004869@metrics.collector.collect_metrics('git cl diff')
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004870def CMDdiff(parser, args):
wychen@chromium.org37b2ec02015-04-03 00:49:15 +00004871 """Shows differences between local tree and last upload."""
thomasanderson074beb22016-08-29 14:03:20 -07004872 parser.add_option(
4873 '--stat',
4874 action='store_true',
4875 dest='stat',
4876 help='Generate a diffstat')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004877 options, args = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004878 if args:
4879 parser.error('Unrecognized args: %s' % ' '.join(args))
wychen@chromium.org46309bf2015-04-03 21:04:49 +00004880
Edward Lemur934836a2019-09-09 20:16:54 +00004881 cl = Changelist()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00004882 issue = cl.GetIssue()
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004883 branch = cl.GetBranch()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00004884 if not issue:
4885 DieWithError('No issue found for current branch (%s)' % branch)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004886
Aaron Gablea718c3e2017-08-28 17:47:28 -07004887 base = cl._GitGetBranchConfigValue('last-upload-hash')
4888 if not base:
4889 base = cl._GitGetBranchConfigValue('gerritsquashhash')
4890 if not base:
4891 detail = cl._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
4892 revision_info = detail['revisions'][detail['current_revision']]
4893 fetch_info = revision_info['fetch']['http']
4894 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
4895 base = 'FETCH_HEAD'
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004896
Aaron Gablea718c3e2017-08-28 17:47:28 -07004897 cmd = ['git', 'diff']
4898 if options.stat:
4899 cmd.append('--stat')
4900 cmd.append(base)
4901 subprocess2.check_call(cmd)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004902
4903 return 0
4904
4905
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004906@metrics.collector.collect_metrics('git cl owners')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004907def CMDowners(parser, args):
Dirk Prankebf980882017-09-02 15:08:00 -07004908 """Finds potential owners for reviewing."""
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004909 parser.add_option(
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00004910 '--ignore-current',
4911 action='store_true',
4912 help='Ignore the CL\'s current reviewers and start from scratch.')
4913 parser.add_option(
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00004914 '--ignore-self',
4915 action='store_true',
4916 help='Do not consider CL\'s author as an owners.')
4917 parser.add_option(
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004918 '--no-color',
4919 action='store_true',
4920 help='Use this option to disable color output')
Dirk Prankebf980882017-09-02 15:08:00 -07004921 parser.add_option(
4922 '--batch',
4923 action='store_true',
4924 help='Do not run interactively, just suggest some')
Yang Guo6e269a02019-06-26 11:17:02 +00004925 # TODO: Consider moving this to another command, since other
4926 # git-cl owners commands deal with owners for a given CL.
4927 parser.add_option(
4928 '--show-all',
4929 action='store_true',
4930 help='Show all owners for a particular file')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004931 options, args = parser.parse_args(args)
4932
4933 author = RunGit(['config', 'user.email']).strip() or None
4934
Edward Lemur934836a2019-09-09 20:16:54 +00004935 cl = Changelist()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004936
Yang Guo6e269a02019-06-26 11:17:02 +00004937 if options.show_all:
4938 for arg in args:
4939 base_branch = cl.GetCommonAncestorWithUpstream()
Edward Lemur7f6dec02020-02-06 20:23:58 +00004940 database = owners.Database(settings.GetRoot(), file, os.path)
Yang Guo6e269a02019-06-26 11:17:02 +00004941 database.load_data_needed_for([arg])
4942 print('Owners for %s:' % arg)
4943 for owner in sorted(database.all_possible_owners([arg], None)):
4944 print(' - %s' % owner)
4945 return 0
4946
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004947 if args:
4948 if len(args) > 1:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004949 parser.error('Unknown args.')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004950 base_branch = args[0]
4951 else:
4952 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004953 base_branch = cl.GetCommonAncestorWithUpstream()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004954
Edward Lemur7f6dec02020-02-06 20:23:58 +00004955 change = cl.GetChange(base_branch)
Dirk Prankebf980882017-09-02 15:08:00 -07004956 affected_files = [f.LocalPath() for f in change.AffectedFiles()]
4957
4958 if options.batch:
4959 db = owners.Database(change.RepositoryRoot(), file, os.path)
4960 print('\n'.join(db.reviewers_for(affected_files, author)))
4961 return 0
4962
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004963 return owners_finder.OwnersFinder(
Dirk Prankebf980882017-09-02 15:08:00 -07004964 affected_files,
Jochen Eisinger72606f82017-04-04 10:44:18 +02004965 change.RepositoryRoot(),
Edward Lemur707d70b2018-02-07 00:50:14 +01004966 author,
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00004967 [] if options.ignore_current else cl.GetReviewers(),
Edward Lemur707d70b2018-02-07 00:50:14 +01004968 fopen=file, os_path=os.path,
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02004969 disable_color=options.no_color,
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00004970 override_files=change.OriginalOwnersFiles(),
4971 ignore_author=options.ignore_self).run()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004972
4973
Aiden Bennerc08566e2018-10-03 17:52:42 +00004974def BuildGitDiffCmd(diff_type, upstream_commit, args, allow_prefix=False):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004975 """Generates a diff command."""
4976 # Generate diff for the current branch's changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +00004977 diff_cmd = ['-c', 'core.quotePath=false', 'diff', '--no-ext-diff']
4978
Aiden Benner6c18a1a2018-11-23 20:18:23 +00004979 if allow_prefix:
4980 # explicitly setting --src-prefix and --dst-prefix is necessary in the
4981 # case that diff.noprefix is set in the user's git config.
4982 diff_cmd += ['--src-prefix=a/', '--dst-prefix=b/']
4983 else:
Aiden Bennerc08566e2018-10-03 17:52:42 +00004984 diff_cmd += ['--no-prefix']
4985
4986 diff_cmd += [diff_type, upstream_commit, '--']
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004987
4988 if args:
4989 for arg in args:
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00004990 if os.path.isdir(arg) or os.path.isfile(arg):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004991 diff_cmd.append(arg)
4992 else:
4993 DieWithError('Argument "%s" is not a file or a directory' % arg)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004994
4995 return diff_cmd
4996
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004997
Jamie Madill5e96ad12020-01-13 16:08:35 +00004998def _RunClangFormatDiff(opts, clang_diff_files, top_dir, upstream_commit):
4999 """Runs clang-format-diff and sets a return value if necessary."""
5000
5001 if not clang_diff_files:
5002 return 0
5003
5004 # Set to 2 to signal to CheckPatchFormatted() that this patch isn't
5005 # formatted. This is used to block during the presubmit.
5006 return_value = 0
5007
5008 # Locate the clang-format binary in the checkout
5009 try:
5010 clang_format_tool = clang_format.FindClangFormatToolInChromiumTree()
5011 except clang_format.NotFoundError as e:
5012 DieWithError(e)
5013
5014 if opts.full or settings.GetFormatFullByDefault():
5015 cmd = [clang_format_tool]
5016 if not opts.dry_run and not opts.diff:
5017 cmd.append('-i')
5018 if opts.dry_run:
5019 for diff_file in clang_diff_files:
5020 with open(diff_file, 'r') as myfile:
5021 code = myfile.read().replace('\r\n', '\n')
5022 stdout = RunCommand(cmd + [diff_file], cwd=top_dir)
5023 stdout = stdout.replace('\r\n', '\n')
5024 if opts.diff:
5025 sys.stdout.write(stdout)
5026 if code != stdout:
5027 return_value = 2
5028 else:
5029 stdout = RunCommand(cmd + clang_diff_files, cwd=top_dir)
5030 if opts.diff:
5031 sys.stdout.write(stdout)
5032 else:
5033 env = os.environ.copy()
5034 env['PATH'] = str(os.path.dirname(clang_format_tool))
5035 try:
5036 script = clang_format.FindClangFormatScriptInChromiumTree(
5037 'clang-format-diff.py')
5038 except clang_format.NotFoundError as e:
5039 DieWithError(e)
5040
5041 cmd = [sys.executable, script, '-p0']
5042 if not opts.dry_run and not opts.diff:
5043 cmd.append('-i')
5044
5045 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, clang_diff_files)
5046 diff_output = RunGit(diff_cmd)
5047
5048 stdout = RunCommand(cmd, stdin=diff_output, cwd=top_dir, env=env)
5049 if opts.diff:
5050 sys.stdout.write(stdout)
5051 if opts.dry_run and len(stdout) > 0:
5052 return_value = 2
5053
5054 return return_value
5055
5056
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005057def MatchingFileType(file_name, extensions):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00005058 """Returns True if the file name ends with one of the given extensions."""
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005059 return bool([ext for ext in extensions if file_name.lower().endswith(ext)])
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005060
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005061
enne@chromium.org555cfe42014-01-29 18:21:39 +00005062@subcommand.usage('[files or directories to diff]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005063@metrics.collector.collect_metrics('git cl format')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005064def CMDformat(parser, args):
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005065 """Runs auto-formatting tools (clang-format etc.) on the diff."""
Christopher Lamc5ba6922017-01-24 11:19:14 +11005066 CLANG_EXTS = ['.cc', '.cpp', '.h', '.m', '.mm', '.proto', '.java']
kylechar58edce22016-06-17 06:07:51 -07005067 GN_EXTS = ['.gn', '.gni', '.typemap']
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00005068 parser.add_option('--full', action='store_true',
5069 help='Reformat the full content of all touched files')
5070 parser.add_option('--dry-run', action='store_true',
5071 help='Don\'t modify any file on disk.')
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005072 parser.add_option(
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005073 '--no-clang-format',
5074 dest='clang_format',
5075 action='store_false',
5076 default=True,
5077 help='Disables formatting of various file types using clang-format.')
5078 parser.add_option(
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005079 '--python',
5080 action='store_true',
5081 default=None,
5082 help='Enables python formatting on all python files.')
5083 parser.add_option(
5084 '--no-python',
5085 action='store_true',
Garrett Beaty91a6f332020-01-06 16:57:24 +00005086 default=False,
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005087 help='Disables python formatting on all python files. '
Garrett Beaty91a6f332020-01-06 16:57:24 +00005088 'If neither --python or --no-python are set, python files that have a '
5089 '.style.yapf file in an ancestor directory will be formatted. '
5090 'It is an error to set both.')
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005091 parser.add_option(
5092 '--js',
5093 action='store_true',
5094 help='Format javascript code with clang-format. '
5095 'Has no effect if --no-clang-format is set.')
wittman@chromium.org04d5a222014-03-07 18:30:42 +00005096 parser.add_option('--diff', action='store_true',
5097 help='Print diff to stdout rather than modifying files.')
Ilya Shermane081cbe2017-08-15 17:51:04 -07005098 parser.add_option('--presubmit', action='store_true',
5099 help='Used when running the script from a presubmit.')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005100 opts, args = parser.parse_args(args)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005101
Garrett Beaty91a6f332020-01-06 16:57:24 +00005102 if opts.python is not None and opts.no_python:
5103 raise parser.error('Cannot set both --python and --no-python')
5104 if opts.no_python:
5105 opts.python = False
5106
Daniel Chengc55eecf2016-12-30 03:11:02 -08005107 # Normalize any remaining args against the current path, so paths relative to
5108 # the current directory are still resolved as expected.
5109 args = [os.path.join(os.getcwd(), arg) for arg in args]
5110
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005111 # git diff generates paths against the root of the repository. Change
5112 # to that directory so clang-format can find files even within subdirs.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005113 rel_base_path = settings.GetRelativeRoot()
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005114 if rel_base_path:
5115 os.chdir(rel_base_path)
5116
digit@chromium.org29e47272013-05-17 17:01:46 +00005117 # Grab the merge-base commit, i.e. the upstream commit of the current
5118 # branch when it was created or the last time it was rebased. This is
5119 # to cover the case where the user may have called "git fetch origin",
5120 # moving the origin branch to a newer commit, but hasn't rebased yet.
5121 upstream_commit = None
5122 cl = Changelist()
5123 upstream_branch = cl.GetUpstreamBranch()
5124 if upstream_branch:
5125 upstream_commit = RunGit(['merge-base', 'HEAD', upstream_branch])
5126 upstream_commit = upstream_commit.strip()
5127
5128 if not upstream_commit:
5129 DieWithError('Could not find base commit for this branch. '
5130 'Are you in detached state?')
5131
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005132 changed_files_cmd = BuildGitDiffCmd('--name-only', upstream_commit, args)
5133 diff_output = RunGit(changed_files_cmd)
5134 diff_files = diff_output.splitlines()
jkarlin@chromium.orgad21b922016-01-28 17:48:42 +00005135 # Filter out files deleted by this CL
5136 diff_files = [x for x in diff_files if os.path.isfile(x)]
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005137
Andreas Haas417d89c2020-02-06 10:24:27 +00005138 if opts.js:
Deepanjan Roy605dd312018-07-02 17:48:54 +00005139 CLANG_EXTS.extend(['.js', '.ts'])
Christopher Lamc5ba6922017-01-24 11:19:14 +11005140
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005141 clang_diff_files = []
5142 if opts.clang_format:
5143 clang_diff_files = [
5144 x for x in diff_files if MatchingFileType(x, CLANG_EXTS)
5145 ]
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005146 python_diff_files = [x for x in diff_files if MatchingFileType(x, ['.py'])]
5147 dart_diff_files = [x for x in diff_files if MatchingFileType(x, ['.dart'])]
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005148 gn_diff_files = [x for x in diff_files if MatchingFileType(x, GN_EXTS)]
digit@chromium.org29e47272013-05-17 17:01:46 +00005149
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +00005150 top_dir = os.path.normpath(
5151 RunGit(["rev-parse", "--show-toplevel"]).rstrip('\n'))
5152
Jamie Madill5e96ad12020-01-13 16:08:35 +00005153 return_value = _RunClangFormatDiff(opts, clang_diff_files, top_dir,
5154 upstream_commit)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005155
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005156 # Similar code to above, but using yapf on .py files rather than clang-format
5157 # on C/C++ files
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005158 py_explicitly_disabled = opts.python is not None and not opts.python
5159 if python_diff_files and not py_explicitly_disabled:
Aiden Bennere47ac152018-11-20 16:44:03 +00005160 depot_tools_path = os.path.dirname(os.path.abspath(__file__))
5161 yapf_tool = os.path.join(depot_tools_path, 'yapf')
5162 if sys.platform.startswith('win'):
5163 yapf_tool += '.bat'
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005164
Aiden Bennerc08566e2018-10-03 17:52:42 +00005165 # Used for caching.
5166 yapf_configs = {}
5167 for f in python_diff_files:
5168 # Find the yapf style config for the current file, defaults to depot
5169 # tools default.
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005170 _FindYapfConfigFile(f, yapf_configs, top_dir)
5171
5172 # Turn on python formatting by default if a yapf config is specified.
5173 # This breaks in the case of this repo though since the specified
5174 # style file is also the global default.
5175 if opts.python is None:
5176 filtered_py_files = []
5177 for f in python_diff_files:
5178 if _FindYapfConfigFile(f, yapf_configs, top_dir) is not None:
5179 filtered_py_files.append(f)
5180 else:
5181 filtered_py_files = python_diff_files
5182
5183 # Note: yapf still seems to fix indentation of the entire file
5184 # even if line ranges are specified.
5185 # See https://github.com/google/yapf/issues/499
5186 if not opts.full and filtered_py_files:
5187 py_line_diffs = _ComputeDiffLineRanges(filtered_py_files, upstream_commit)
5188
Brian Sheedyb4307d52019-12-02 19:18:17 +00005189 yapfignore_patterns = _GetYapfIgnorePatterns(top_dir)
5190 filtered_py_files = _FilterYapfIgnoredFiles(filtered_py_files,
5191 yapfignore_patterns)
Brian Sheedy59b06a82019-10-14 17:03:29 +00005192
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005193 for f in filtered_py_files:
Andrew Grievefa40bfa2020-01-07 02:32:57 +00005194 yapf_style = _FindYapfConfigFile(f, yapf_configs, top_dir)
5195 # Default to pep8 if not .style.yapf is found.
5196 if not yapf_style:
5197 yapf_style = 'pep8'
Aiden Bennerc08566e2018-10-03 17:52:42 +00005198
Andrew Grievefa40bfa2020-01-07 02:32:57 +00005199 cmd = [yapf_tool, '--style', yapf_style, f]
Aiden Bennerc08566e2018-10-03 17:52:42 +00005200
5201 has_formattable_lines = False
5202 if not opts.full:
5203 # Only run yapf over changed line ranges.
5204 for diff_start, diff_len in py_line_diffs[f]:
5205 diff_end = diff_start + diff_len - 1
5206 # Yapf errors out if diff_end < diff_start but this
5207 # is a valid line range diff for a removal.
5208 if diff_end >= diff_start:
5209 has_formattable_lines = True
5210 cmd += ['-l', '{}-{}'.format(diff_start, diff_end)]
5211 # If all line diffs were removals we have nothing to format.
5212 if not has_formattable_lines:
5213 continue
5214
5215 if opts.diff or opts.dry_run:
5216 cmd += ['--diff']
5217 # Will return non-zero exit code if non-empty diff.
5218 stdout = RunCommand(cmd, error_ok=True, cwd=top_dir)
5219 if opts.diff:
5220 sys.stdout.write(stdout)
5221 elif len(stdout) > 0:
5222 return_value = 2
5223 else:
5224 cmd += ['-i']
5225 RunCommand(cmd, cwd=top_dir)
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005226
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005227 # Dart's formatter does not have the nice property of only operating on
5228 # modified chunks, so hard code full.
5229 if dart_diff_files:
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005230 try:
5231 command = [dart_format.FindDartFmtToolInChromiumTree()]
5232 if not opts.dry_run and not opts.diff:
5233 command.append('-w')
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005234 command.extend(dart_diff_files)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005235
ppi@chromium.org6593d932016-03-03 15:41:15 +00005236 stdout = RunCommand(command, cwd=top_dir)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005237 if opts.dry_run and stdout:
5238 return_value = 2
Jamie Madill5e96ad12020-01-13 16:08:35 +00005239 except dart_format.NotFoundError:
vapiera7fbd5a2016-06-16 09:17:49 -07005240 print('Warning: Unable to check Dart code formatting. Dart SDK not '
5241 'found in this checkout. Files in other languages are still '
5242 'formatted.')
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005243
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005244 # Format GN build files. Always run on full build files for canonical form.
5245 if gn_diff_files:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005246 cmd = ['gn', 'format']
brettw4b8ed592016-08-05 16:19:12 -07005247 if opts.dry_run or opts.diff:
5248 cmd.append('--dry-run')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005249 for gn_diff_file in gn_diff_files:
brettw4b8ed592016-08-05 16:19:12 -07005250 gn_ret = subprocess2.call(cmd + [gn_diff_file],
5251 shell=sys.platform == 'win32',
5252 cwd=top_dir)
5253 if opts.dry_run and gn_ret == 2:
5254 return_value = 2 # Not formatted.
5255 elif opts.diff and gn_ret == 2:
5256 # TODO this should compute and print the actual diff.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005257 print('This change has GN build file diff for ' + gn_diff_file)
brettw4b8ed592016-08-05 16:19:12 -07005258 elif gn_ret != 0:
5259 # For non-dry run cases (and non-2 return values for dry-run), a
5260 # nonzero error code indicates a failure, probably because the file
5261 # doesn't parse.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005262 DieWithError('gn format failed on ' + gn_diff_file +
5263 '\nTry running `gn format` on this file manually.')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005264
Ilya Shermane081cbe2017-08-15 17:51:04 -07005265 # Skip the metrics formatting from the global presubmit hook. These files have
5266 # a separate presubmit hook that issues an error if the files need formatting,
5267 # whereas the top-level presubmit script merely issues a warning. Formatting
5268 # these files is somewhat slow, so it's important not to duplicate the work.
5269 if not opts.presubmit:
5270 for xml_dir in GetDirtyMetricsDirs(diff_files):
5271 tool_dir = os.path.join(top_dir, xml_dir)
5272 cmd = [os.path.join(tool_dir, 'pretty_print.py'), '--non-interactive']
5273 if opts.dry_run or opts.diff:
5274 cmd.append('--diff')
Ilya Sherman235b70d2017-08-22 17:46:38 -07005275 stdout = RunCommand(cmd, cwd=top_dir)
Ilya Shermane081cbe2017-08-15 17:51:04 -07005276 if opts.diff:
5277 sys.stdout.write(stdout)
5278 if opts.dry_run and stdout:
5279 return_value = 2 # Not formatted.
Alexei Svitkinef3cac412017-02-06 11:08:50 -05005280
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005281 return return_value
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005282
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005283
Steven Holte2e664bf2017-04-21 13:10:47 -07005284def GetDirtyMetricsDirs(diff_files):
5285 xml_diff_files = [x for x in diff_files if MatchingFileType(x, ['.xml'])]
5286 metrics_xml_dirs = [
5287 os.path.join('tools', 'metrics', 'actions'),
5288 os.path.join('tools', 'metrics', 'histograms'),
5289 os.path.join('tools', 'metrics', 'rappor'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005290 os.path.join('tools', 'metrics', 'ukm'),
5291 ]
Steven Holte2e664bf2017-04-21 13:10:47 -07005292 for xml_dir in metrics_xml_dirs:
5293 if any(file.startswith(xml_dir) for file in xml_diff_files):
5294 yield xml_dir
5295
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005296
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005297@subcommand.usage('<codereview url or issue id>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005298@metrics.collector.collect_metrics('git cl checkout')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005299def CMDcheckout(parser, args):
Edward Lemurf38bc172019-09-03 21:02:13 +00005300 """Checks out a branch associated with a given Gerrit issue."""
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005301 _, args = parser.parse_args(args)
5302
5303 if len(args) != 1:
5304 parser.print_help()
5305 return 1
5306
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005307 issue_arg = ParseIssueNumberArgument(args[0])
tandrii@chromium.orgde6c9a12016-04-11 15:33:53 +00005308 if not issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005309 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005310
tandrii@chromium.orgabd27e52016-04-11 15:43:32 +00005311 target_issue = str(issue_arg.issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005312
Edward Lemur52969c92020-02-06 18:15:28 +00005313 issueprefix = Changelist.IssueConfigKey()
5314 output = RunGit(['config', '--local', '--get-regexp',
5315 r'branch\..*\.%s' % issueprefix],
5316 error_ok=True)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005317
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005318 branches = []
Edward Lemur52969c92020-02-06 18:15:28 +00005319 for key, issue in [x.split() for x in output.splitlines()]:
5320 if issue == target_issue:
5321 branches.append(re.sub(r'branch\.(.*)\.%s' % issueprefix, r'\1', key))
5322
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005323 if len(branches) == 0:
vapiera7fbd5a2016-06-16 09:17:49 -07005324 print('No branch found for issue %s.' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005325 return 1
5326 if len(branches) == 1:
5327 RunGit(['checkout', branches[0]])
5328 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005329 print('Multiple branches match issue %s:' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005330 for i in range(len(branches)):
vapiera7fbd5a2016-06-16 09:17:49 -07005331 print('%d: %s' % (i, branches[i]))
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005332 which = raw_input('Choose by index: ')
5333 try:
5334 RunGit(['checkout', branches[int(which)]])
5335 except (IndexError, ValueError):
vapiera7fbd5a2016-06-16 09:17:49 -07005336 print('Invalid selection, not checking out any branch.')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005337 return 1
5338
5339 return 0
5340
5341
maruel@chromium.org29404b52014-09-08 22:58:00 +00005342def CMDlol(parser, args):
5343 # This command is intentionally undocumented.
vapiera7fbd5a2016-06-16 09:17:49 -07005344 print(zlib.decompress(base64.b64decode(
thakis@chromium.org3421c992014-11-02 02:20:32 +00005345 'eNptkLEOwyAMRHe+wupCIqW57v0Vq84WqWtXyrcXnCBsmgMJ+/SSAxMZgRB6NzE'
5346 'E2ObgCKJooYdu4uAQVffUEoE1sRQLxAcqzd7uK2gmStrll1ucV3uZyaY5sXyDd9'
5347 'JAnN+lAXsOMJ90GANAi43mq5/VeeacylKVgi8o6F1SC63FxnagHfJUTfUYdCR/W'
vapiera7fbd5a2016-06-16 09:17:49 -07005348 'Ofe+0dHL7PicpytKP750Fh1q2qnLVof4w8OZWNY')))
maruel@chromium.org29404b52014-09-08 22:58:00 +00005349 return 0
5350
5351
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005352class OptionParser(optparse.OptionParser):
5353 """Creates the option parse and add --verbose support."""
5354 def __init__(self, *args, **kwargs):
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005355 optparse.OptionParser.__init__(
5356 self, *args, prog='git cl', version=__version__, **kwargs)
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005357 self.add_option(
5358 '-v', '--verbose', action='count', default=0,
5359 help='Use 2 times for more debugging info')
5360
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005361 def parse_args(self, args=None, _values=None):
Andrii Shyshkalov46f20cd2018-10-30 06:42:54 +00005362 try:
5363 return self._parse_args(args)
5364 finally:
5365 # Regardless of success or failure of args parsing, we want to report
5366 # metrics, but only after logging has been initialized (if parsing
5367 # succeeded).
5368 global settings
5369 settings = Settings()
5370
5371 if not metrics.DISABLE_METRICS_COLLECTION:
5372 # GetViewVCUrl ultimately calls logging method.
5373 project_url = settings.GetViewVCUrl().strip('/+')
5374 if project_url in metrics_utils.KNOWN_PROJECT_URLS:
5375 metrics.collector.add('project_urls', [project_url])
5376
5377 def _parse_args(self, args=None):
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005378 # Create an optparse.Values object that will store only the actual passed
5379 # options, without the defaults.
5380 actual_options = optparse.Values()
5381 _, args = optparse.OptionParser.parse_args(self, args, actual_options)
5382 # Create an optparse.Values object with the default options.
5383 options = optparse.Values(self.get_default_values().__dict__)
5384 # Update it with the options passed by the user.
5385 options._update_careful(actual_options.__dict__)
5386 # Store the options passed by the user in an _actual_options attribute.
5387 # We store only the keys, and not the values, since the values can contain
5388 # arbitrary information, which might be PII.
Edward Lemur79d4f992019-11-11 23:49:02 +00005389 metrics.collector.add('arguments', list(actual_options.__dict__.keys()))
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005390
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005391 levels = [logging.WARNING, logging.INFO, logging.DEBUG]
Andrii Shyshkalov5b04a572017-01-23 17:44:41 +01005392 logging.basicConfig(
5393 level=levels[min(options.verbose, len(levels) - 1)],
5394 format='[%(levelname).1s%(asctime)s %(process)d %(thread)d '
5395 '%(filename)s] %(message)s')
Edward Lemur83bd7f42018-10-10 00:14:21 +00005396
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005397 return options, args
5398
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005399
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005400def main(argv):
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005401 if sys.hexversion < 0x02060000:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005402 print('\nYour Python version %s is unsupported, please upgrade.\n' %
vapiera7fbd5a2016-06-16 09:17:49 -07005403 (sys.version.split(' ', 1)[0],), file=sys.stderr)
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005404 return 2
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00005405
maruel@chromium.org39c0b222013-08-17 16:57:01 +00005406 colorize_CMDstatus_doc()
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005407 dispatcher = subcommand.CommandDispatcher(__name__)
5408 try:
5409 return dispatcher.execute(OptionParser(), argv)
Edward Lemur5b929a42019-10-21 17:57:39 +00005410 except auth.LoginRequiredError as e:
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +00005411 DieWithError(str(e))
Edward Lemur79d4f992019-11-11 23:49:02 +00005412 except urllib.error.HTTPError as e:
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005413 if e.code != 500:
5414 raise
5415 DieWithError(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005416 ('App Engine is misbehaving and returned HTTP %d, again. Keep faith '
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005417 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
sbc@chromium.org013731e2015-02-26 18:28:43 +00005418 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005419
5420
5421if __name__ == '__main__':
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005422 # These affect sys.stdout, so do it outside of main() to simplify mocks in
5423 # the unit tests.
maruel@chromium.org6f09cd92011-04-01 16:38:12 +00005424 fix_encoding.fix_encoding()
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00005425 setup_color.init()
Edward Lemur6f812e12018-07-31 22:45:57 +00005426 with metrics.collector.print_notice_and_exit():
sbc@chromium.org013731e2015-02-26 18:28:43 +00005427 sys.exit(main(sys.argv[1:]))