blob: 098c454f835abe7a5d7f8efef9eaa5af340670e8 [file] [log] [blame]
Edward Lesmes98eda3f2019-08-12 21:09:53 +00001#!/usr/bin/env python
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02002# Copyright (c) 2013 The Chromium Authors. All rights reserved.
maruel@chromium.org725f1c32011-04-01 20:24:54 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006# Copyright (C) 2008 Evan Martin <martine@danga.com>
7
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00008"""A git-command for integrating reviews on Gerrit."""
maruel@chromium.org725f1c32011-04-01 20:24:54 +00009
vapiera7fbd5a2016-06-16 09:17:49 -070010from __future__ import print_function
11
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +000012from distutils.version import LooseVersion
calamity@chromium.orgffde55c2015-03-12 00:44:17 +000013from multiprocessing.pool import ThreadPool
thakis@chromium.org3421c992014-11-02 02:20:32 +000014import base64
rmistry@google.com2dd99862015-06-22 12:22:18 +000015import collections
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +010016import contextlib
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010017import datetime
sheyang@google.com6ebaf782015-05-12 19:17:54 +000018import httplib
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +010019import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000020import json
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000021import logging
calamity@chromium.orgcf197482016-04-29 20:15:53 +000022import multiprocessing
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000023import optparse
24import os
25import re
Andrii Shyshkalov353637c2017-03-14 16:52:18 +010026import shutil
ukai@chromium.org78c4b982012-02-14 02:20:26 +000027import stat
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000028import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070029import tempfile
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000030import textwrap
Edward Lemurfec80c42018-11-01 23:14:14 +000031import time
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000032import urllib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000033import urllib2
maruel@chromium.org967c0a82013-06-17 22:52:24 +000034import urlparse
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000035import uuid
thestig@chromium.org00858c82013-12-02 23:08:03 +000036import webbrowser
thakis@chromium.org3421c992014-11-02 02:20:32 +000037import zlib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000038
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000039from third_party import colorama
sheyang@google.com6ebaf782015-05-12 19:17:54 +000040from third_party import httplib2
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000041import auth
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +000042import clang_format
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +000043import dart_format
maruel@chromium.org6f09cd92011-04-01 16:38:12 +000044import fix_encoding
maruel@chromium.org0e0436a2011-10-25 13:32:41 +000045import gclient_utils
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +000046import gerrit_util
iannucci@chromium.org9e849272014-04-04 00:31:55 +000047import git_common
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +000048import git_footers
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000049import metrics
Edward Lesmes93277a72018-10-18 22:04:26 +000050import metrics_utils
piman@chromium.org336f9122014-09-04 02:16:55 +000051import owners
iannucci@chromium.org9e849272014-04-04 00:31:55 +000052import owners_finder
maruel@chromium.org2a74d372011-03-29 19:05:50 +000053import presubmit_support
54import scm
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000055import setup_color
Francois Dorayd42c6812017-05-30 15:10:20 -040056import split_cl
maruel@chromium.org0633fb42013-08-16 20:06:14 +000057import subcommand
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +000058import subprocess2
maruel@chromium.org2a74d372011-03-29 19:05:50 +000059import watchlists
60
tandrii7400cf02016-06-21 08:48:07 -070061__version__ = '2.0'
maruel@chromium.org2a74d372011-03-29 19:05:50 +000062
Edward Lemur0f58ae42019-04-30 17:24:12 +000063# Traces for git push will be stored in a traces directory inside the
64# depot_tools checkout.
65DEPOT_TOOLS = os.path.dirname(os.path.abspath(__file__))
66TRACES_DIR = os.path.join(DEPOT_TOOLS, 'traces')
67
68# When collecting traces, Git hashes will be reduced to 6 characters to reduce
69# the size after compression.
70GIT_HASH_RE = re.compile(r'\b([a-f0-9]{6})[a-f0-9]{34}\b', flags=re.I)
71# Used to redact the cookies from the gitcookies file.
72GITCOOKIES_REDACT_RE = re.compile(r'1/.*')
73
Edward Lemur1b52d872019-05-09 21:12:12 +000074# The maximum number of traces we will keep. Multiplied by 3 since we store
75# 3 files per trace.
76MAX_TRACES = 3 * 10
Edward Lemur5737f022019-05-17 01:24:00 +000077# Message to be displayed to the user to inform where to find the traces for a
78# git-cl upload execution.
Edward Lemur0f58ae42019-04-30 17:24:12 +000079TRACES_MESSAGE = (
Edward Lemur1b52d872019-05-09 21:12:12 +000080'\n'
Edward Lemur5737f022019-05-17 01:24:00 +000081'The traces of this git-cl execution have been recorded at:\n'
Edward Lemur1b52d872019-05-09 21:12:12 +000082' %(trace_name)s-traces.zip\n'
Edward Lemur5737f022019-05-17 01:24:00 +000083'Copies of your gitcookies file and git config have been recorded at:\n'
84' %(trace_name)s-git-info.zip\n')
Edward Lemur1b52d872019-05-09 21:12:12 +000085# Format of the message to be stored as part of the traces to give developers a
86# better context when they go through traces.
87TRACES_README_FORMAT = (
88'Date: %(now)s\n'
89'\n'
90'Change: https://%(gerrit_host)s/q/%(change_id)s\n'
91'Title: %(title)s\n'
92'\n'
93'%(description)s\n'
94'\n'
95'Execution time: %(execution_time)s\n'
96'Exit code: %(exit_code)s\n') + TRACES_MESSAGE
Edward Lemur0f58ae42019-04-30 17:24:12 +000097
tandrii9d2c7a32016-06-22 03:42:45 -070098COMMIT_BOT_EMAIL = 'commit-bot@chromium.org'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -080099POSTUPSTREAM_HOOK = '.git/hooks/post-cl-land'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000100DESCRIPTION_BACKUP_FILE = '~/.git_cl_description_backup'
rmistry@google.comc68112d2015-03-03 12:48:06 +0000101REFS_THAT_ALIAS_TO_OTHER_REFS = {
102 'refs/remotes/origin/lkgr': 'refs/remotes/origin/master',
103 'refs/remotes/origin/lkcr': 'refs/remotes/origin/master',
104}
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000105
thestig@chromium.org44202a22014-03-11 19:22:18 +0000106# Valid extensions for files we want to lint.
107DEFAULT_LINT_REGEX = r"(.*\.cpp|.*\.cc|.*\.h)"
108DEFAULT_LINT_IGNORE_REGEX = r"$^"
109
Aiden Bennerc08566e2018-10-03 17:52:42 +0000110# File name for yapf style config files.
111YAPF_CONFIG_FILENAME = '.style.yapf'
112
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000113# Buildbucket master name prefix for Buildbot masters.
borenet6c0efe62016-10-19 08:13:29 -0700114MASTER_PREFIX = 'master.'
115
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000116# Shortcut since it quickly becomes repetitive.
maruel@chromium.org2e23ce32013-05-07 12:42:28 +0000117Fore = colorama.Fore
maruel@chromium.org90541732011-04-01 17:54:18 +0000118
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000119# Initialized in main()
120settings = None
121
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100122# Used by tests/git_cl_test.py to add extra logging.
123# Inside the weirdly failing test, add this:
124# >>> self.mock(git_cl, '_IS_BEING_TESTED', True)
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700125# And scroll up to see the stack trace printed.
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100126_IS_BEING_TESTED = False
127
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000128
Christopher Lamf732cd52017-01-24 12:40:11 +1100129def DieWithError(message, change_desc=None):
130 if change_desc:
131 SaveDescriptionBackup(change_desc)
132
vapiera7fbd5a2016-06-16 09:17:49 -0700133 print(message, file=sys.stderr)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000134 sys.exit(1)
135
136
Christopher Lamf732cd52017-01-24 12:40:11 +1100137def SaveDescriptionBackup(change_desc):
138 backup_path = os.path.expanduser(DESCRIPTION_BACKUP_FILE)
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000139 print('\nsaving CL description to %s\n' % backup_path)
Christopher Lamf732cd52017-01-24 12:40:11 +1100140 backup_file = open(backup_path, 'w')
141 backup_file.write(change_desc.description)
142 backup_file.close()
143
144
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000145def GetNoGitPagerEnv():
146 env = os.environ.copy()
147 # 'cat' is a magical git string that disables pagers on all platforms.
148 env['GIT_PAGER'] = 'cat'
149 return env
150
vadimsh@chromium.org566a02a2014-08-22 01:34:13 +0000151
bsep@chromium.org627d9002016-04-29 00:00:52 +0000152def RunCommand(args, error_ok=False, error_message=None, shell=False, **kwargs):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000153 try:
bsep@chromium.org627d9002016-04-29 00:00:52 +0000154 return subprocess2.check_output(args, shell=shell, **kwargs)
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000155 except subprocess2.CalledProcessError as e:
156 logging.debug('Failed running %s', args)
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000157 if not error_ok:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000158 DieWithError(
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000159 'Command "%s" failed.\n%s' % (
160 ' '.join(args), error_message or e.stdout or ''))
161 return e.stdout
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000162
163
164def RunGit(args, **kwargs):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000165 """Returns stdout."""
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000166 return RunCommand(['git'] + args, **kwargs)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000167
168
enne@chromium.org3b7e15c2014-01-21 17:44:47 +0000169def RunGitWithCode(args, suppress_stderr=False):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000170 """Returns return code and stdout."""
tandrii5d48c322016-08-18 16:19:37 -0700171 if suppress_stderr:
172 stderr = subprocess2.VOID
173 else:
174 stderr = sys.stderr
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000175 try:
tandrii5d48c322016-08-18 16:19:37 -0700176 (out, _), code = subprocess2.communicate(['git'] + args,
177 env=GetNoGitPagerEnv(),
178 stdout=subprocess2.PIPE,
179 stderr=stderr)
180 return code, out
181 except subprocess2.CalledProcessError as e:
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +0900182 logging.debug('Failed running %s', ['git'] + args)
tandrii5d48c322016-08-18 16:19:37 -0700183 return e.returncode, e.stdout
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000184
185
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000186def RunGitSilent(args):
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000187 """Returns stdout, suppresses stderr and ignores the return code."""
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000188 return RunGitWithCode(args, suppress_stderr=True)[1]
189
190
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000191def IsGitVersionAtLeast(min_version):
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000192 prefix = 'git version '
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000193 version = RunGit(['--version']).strip()
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000194 return (version.startswith(prefix) and
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000195 LooseVersion(version[len(prefix):]) >= LooseVersion(min_version))
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000196
197
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000198def BranchExists(branch):
199 """Return True if specified branch exists."""
200 code, _ = RunGitWithCode(['rev-parse', '--verify', branch],
201 suppress_stderr=True)
202 return not code
203
204
tandrii2a16b952016-10-19 07:09:44 -0700205def time_sleep(seconds):
206 # Use this so that it can be mocked in tests without interfering with python
207 # system machinery.
tandrii2a16b952016-10-19 07:09:44 -0700208 return time.sleep(seconds)
209
210
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000211def time_time():
212 # Use this so that it can be mocked in tests without interfering with python
213 # system machinery.
214 return time.time()
215
216
Edward Lemur1b52d872019-05-09 21:12:12 +0000217def datetime_now():
218 # Use this so that it can be mocked in tests without interfering with python
219 # system machinery.
220 return datetime.datetime.now()
221
222
maruel@chromium.org90541732011-04-01 17:54:18 +0000223def ask_for_data(prompt):
224 try:
225 return raw_input(prompt)
226 except KeyboardInterrupt:
227 # Hide the exception.
228 sys.exit(1)
229
230
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100231def confirm_or_exit(prefix='', action='confirm'):
232 """Asks user to press enter to continue or press Ctrl+C to abort."""
233 if not prefix or prefix.endswith('\n'):
234 mid = 'Press'
Andrii Shyshkalov353637c2017-03-14 16:52:18 +0100235 elif prefix.endswith('.') or prefix.endswith('?'):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100236 mid = ' Press'
237 elif prefix.endswith(' '):
238 mid = 'press'
239 else:
240 mid = ' press'
241 ask_for_data('%s%s Enter to %s, or Ctrl+C to abort' % (prefix, mid, action))
242
243
244def ask_for_explicit_yes(prompt):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000245 """Returns whether user typed 'y' or 'yes' to confirm the given prompt."""
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100246 result = ask_for_data(prompt + ' [Yes/No]: ').lower()
247 while True:
248 if 'yes'.startswith(result):
249 return True
250 if 'no'.startswith(result):
251 return False
252 result = ask_for_data('Please, type yes or no: ').lower()
253
254
tandrii5d48c322016-08-18 16:19:37 -0700255def _git_branch_config_key(branch, key):
256 """Helper method to return Git config key for a branch."""
257 assert branch, 'branch name is required to set git config for it'
258 return 'branch.%s.%s' % (branch, key)
259
260
261def _git_get_branch_config_value(key, default=None, value_type=str,
262 branch=False):
263 """Returns git config value of given or current branch if any.
264
265 Returns default in all other cases.
266 """
267 assert value_type in (int, str, bool)
268 if branch is False: # Distinguishing default arg value from None.
269 branch = GetCurrentBranch()
270
rogerta@chromium.orgcaa16552013-03-18 20:45:05 +0000271 if not branch:
tandrii5d48c322016-08-18 16:19:37 -0700272 return default
rogerta@chromium.orgcaa16552013-03-18 20:45:05 +0000273
tandrii5d48c322016-08-18 16:19:37 -0700274 args = ['config']
tandrii33a46ff2016-08-23 05:53:40 -0700275 if value_type == bool:
tandrii5d48c322016-08-18 16:19:37 -0700276 args.append('--bool')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000277 # `git config` also has --int, but apparently git config suffers from integer
tandrii33a46ff2016-08-23 05:53:40 -0700278 # overflows (http://crbug.com/640115), so don't use it.
tandrii5d48c322016-08-18 16:19:37 -0700279 args.append(_git_branch_config_key(branch, key))
280 code, out = RunGitWithCode(args)
281 if code == 0:
282 value = out.strip()
283 if value_type == int:
284 return int(value)
285 if value_type == bool:
286 return bool(value.lower() == 'true')
287 return value
iannucci@chromium.org79540052012-10-19 23:15:26 +0000288 return default
289
290
tandrii5d48c322016-08-18 16:19:37 -0700291def _git_set_branch_config_value(key, value, branch=None, **kwargs):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000292 """Sets or unsets the git branch config value.
tandrii5d48c322016-08-18 16:19:37 -0700293
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000294 If value is None, the key will be unset, otherwise it will be set.
295 If no branch is given, the currently checked out branch is used.
tandrii5d48c322016-08-18 16:19:37 -0700296 """
297 if not branch:
298 branch = GetCurrentBranch()
299 assert branch, 'a branch name OR currently checked out branch is required'
300 args = ['config']
qyearsley12fa6ff2016-08-24 09:18:40 -0700301 # Check for boolean first, because bool is int, but int is not bool.
tandrii5d48c322016-08-18 16:19:37 -0700302 if value is None:
303 args.append('--unset')
304 elif isinstance(value, bool):
305 args.append('--bool')
306 value = str(value).lower()
tandrii5d48c322016-08-18 16:19:37 -0700307 else:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000308 # `git config` also has --int, but apparently git config suffers from
309 # integer overflows (http://crbug.com/640115), so don't use it.
tandrii5d48c322016-08-18 16:19:37 -0700310 value = str(value)
311 args.append(_git_branch_config_key(branch, key))
312 if value is not None:
313 args.append(value)
314 RunGit(args, **kwargs)
315
316
Andrii Shyshkalova6695812016-12-06 17:47:09 +0100317def _get_committer_timestamp(commit):
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700318 """Returns Unix timestamp as integer of a committer in a commit.
Andrii Shyshkalova6695812016-12-06 17:47:09 +0100319
320 Commit can be whatever git show would recognize, such as HEAD, sha1 or ref.
321 """
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000322 # Git also stores timezone offset, but it only affects visual display;
Andrii Shyshkalova6695812016-12-06 17:47:09 +0100323 # actual point in time is defined by this timestamp only.
324 return int(RunGit(['show', '-s', '--format=%ct', commit]).strip())
325
326
327def _git_amend_head(message, committer_timestamp):
328 """Amends commit with new message and desired committer_timestamp.
329
330 Sets committer timezone to UTC.
331 """
332 env = os.environ.copy()
333 env['GIT_COMMITTER_DATE'] = '%d+0000' % committer_timestamp
334 return RunGit(['commit', '--amend', '-m', message], env=env)
335
336
machenbach@chromium.org45453142015-09-15 08:45:22 +0000337def _get_properties_from_options(options):
338 properties = dict(x.split('=', 1) for x in options.properties)
339 for key, val in properties.iteritems():
340 try:
341 properties[key] = json.loads(val)
342 except ValueError:
343 pass # If a value couldn't be evaluated, treat it as a string.
344 return properties
345
346
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000347def _prefix_master(master):
348 """Convert user-specified master name to full master name.
349
350 Buildbucket uses full master name(master.tryserver.chromium.linux) as bucket
351 name, while the developers always use shortened master name
352 (tryserver.chromium.linux) by stripping off the prefix 'master.'. This
353 function does the conversion for buildbucket migration.
354 """
borenet6c0efe62016-10-19 08:13:29 -0700355 if master.startswith(MASTER_PREFIX):
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000356 return master
borenet6c0efe62016-10-19 08:13:29 -0700357 return '%s%s' % (MASTER_PREFIX, master)
358
359
360def _unprefix_master(bucket):
361 """Convert bucket name to shortened master name.
362
363 Buildbucket uses full master name(master.tryserver.chromium.linux) as bucket
364 name, while the developers always use shortened master name
365 (tryserver.chromium.linux) by stripping off the prefix 'master.'. This
366 function does the conversion for buildbucket migration.
367 """
368 if bucket.startswith(MASTER_PREFIX):
369 return bucket[len(MASTER_PREFIX):]
370 return bucket
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000371
372
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000373def _buildbucket_retry(operation_name, http, *args, **kwargs):
374 """Retries requests to buildbucket service and returns parsed json content."""
375 try_count = 0
376 while True:
377 response, content = http.request(*args, **kwargs)
378 try:
379 content_json = json.loads(content)
380 except ValueError:
381 content_json = None
382
383 # Buildbucket could return an error even if status==200.
384 if content_json and content_json.get('error'):
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000385 error = content_json.get('error')
386 if error.get('code') == 403:
387 raise BuildbucketResponseException(
388 'Access denied: %s' % error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000389 msg = 'Error in response. Reason: %s. Message: %s.' % (
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000390 error.get('reason', ''), error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000391 raise BuildbucketResponseException(msg)
392
393 if response.status == 200:
Nodir Turakulov23d75d22018-06-04 12:37:32 -0700394 if content_json is None:
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000395 raise BuildbucketResponseException(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000396 'Buildbucket returned invalid JSON content: %s.\n'
Nodir Turakulov9ac59792018-06-04 12:34:14 -0700397 'Please file bugs at http://crbug.com, '
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000398 'component "Infra>Platform>Buildbucket".' %
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000399 content)
400 return content_json
401 if response.status < 500 or try_count >= 2:
402 raise httplib2.HttpLib2Error(content)
403
404 # status >= 500 means transient failures.
405 logging.debug('Transient errors when %s. Will retry.', operation_name)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000406 time_sleep(0.5 + (1.5 * try_count))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000407 try_count += 1
408 assert False, 'unreachable'
409
410
qyearsley1fdfcb62016-10-24 13:22:03 -0700411def _get_bucket_map(changelist, options, option_parser):
qyearsleydd49f942016-10-28 11:57:22 -0700412 """Returns a dict mapping bucket names to builders and tests,
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000413 for triggering tryjobs.
qyearsley1fdfcb62016-10-24 13:22:03 -0700414 """
qyearsleydd49f942016-10-28 11:57:22 -0700415 # If no bots are listed, we try to get a set of builders and tests based
416 # on GetPreferredTryMasters functions in PRESUBMIT.py files.
qyearsley1fdfcb62016-10-24 13:22:03 -0700417 if not options.bot:
418 change = changelist.GetChange(
419 changelist.GetCommonAncestorWithUpstream(), None)
qyearsley136b49f2016-10-31 09:02:26 -0700420 # Get try masters from PRESUBMIT.py files.
nodire4f0fe02016-11-04 16:23:30 -0700421 masters = presubmit_support.DoGetTryMasters(
qyearsley1fdfcb62016-10-24 13:22:03 -0700422 change=change,
423 changed_files=change.LocalPaths(),
424 repository_root=settings.GetRoot(),
425 default_presubmit=None,
426 project=None,
427 verbose=options.verbose,
428 output_stream=sys.stdout)
nodire4f0fe02016-11-04 16:23:30 -0700429 if masters is None:
430 return None
Sergiy Byelozyorov935b93f2016-11-28 20:41:56 +0100431 return {_prefix_master(m): b for m, b in masters.iteritems()}
qyearsley1fdfcb62016-10-24 13:22:03 -0700432
qyearsley1fdfcb62016-10-24 13:22:03 -0700433 if options.bucket:
434 return {options.bucket: {b: [] for b in options.bot}}
Andrii Shyshkalov75424372019-08-30 22:48:15 +0000435 option_parser.error(
436 'Please specify the bucket, e.g. "-B luci.chromium.try".')
qyearsley1fdfcb62016-10-24 13:22:03 -0700437
438
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -0800439def _trigger_try_jobs(auth_config, changelist, buckets, options, patchset):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000440 """Sends a request to Buildbucket to trigger tryjobs for a changelist.
qyearsley1fdfcb62016-10-24 13:22:03 -0700441
442 Args:
Aaron Gablefb28d482018-04-02 13:08:06 -0700443 auth_config: AuthConfig for Buildbucket.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000444 changelist: Changelist that the tryjobs are associated with.
qyearsley1fdfcb62016-10-24 13:22:03 -0700445 buckets: A nested dict mapping bucket names to builders to tests.
446 options: Command-line options.
447 """
tandriide281ae2016-10-12 06:02:30 -0700448 assert changelist.GetIssue(), 'CL must be uploaded first'
449 codereview_url = changelist.GetCodereviewServer()
450 assert codereview_url, 'CL must be uploaded first'
451 patchset = patchset or changelist.GetMostRecentPatchset()
452 assert patchset, 'CL must be uploaded first'
453
454 codereview_host = urlparse.urlparse(codereview_url).hostname
Aaron Gablefb28d482018-04-02 13:08:06 -0700455 # Cache the buildbucket credentials under the codereview host key, so that
456 # users can use different credentials for different buckets.
tandriide281ae2016-10-12 06:02:30 -0700457 authenticator = auth.get_authenticator_for_host(codereview_host, auth_config)
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000458 http = authenticator.authorize(httplib2.Http())
459 http.force_exception_to_status_code = True
tandriide281ae2016-10-12 06:02:30 -0700460
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000461 buildbucket_put_url = (
462 'https://{hostname}/_ah/api/buildbucket/v1/builds/batch'.format(
sheyang@chromium.orgdb375572015-08-17 19:22:23 +0000463 hostname=options.buildbucket_host))
Andrii Shyshkalov03da1502018-10-15 03:42:34 +0000464 buildset = 'patch/gerrit/{hostname}/{issue}/{patch}'.format(
tandriide281ae2016-10-12 06:02:30 -0700465 hostname=codereview_host,
466 issue=changelist.GetIssue(),
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000467 patch=patchset)
tandrii8c5a3532016-11-04 07:52:02 -0700468
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700469 shared_parameters_properties = changelist.GetTryJobProperties(patchset)
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -0800470 shared_parameters_properties['category'] = options.category
tandrii8c5a3532016-11-04 07:52:02 -0700471 if options.clobber:
472 shared_parameters_properties['clobber'] = True
tandriide281ae2016-10-12 06:02:30 -0700473 extra_properties = _get_properties_from_options(options)
tandrii8c5a3532016-11-04 07:52:02 -0700474 if extra_properties:
475 shared_parameters_properties.update(extra_properties)
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000476
477 batch_req_body = {'builds': []}
478 print_text = []
479 print_text.append('Tried jobs on:')
borenet6c0efe62016-10-19 08:13:29 -0700480 for bucket, builders_and_tests in sorted(buckets.iteritems()):
481 print_text.append('Bucket: %s' % bucket)
482 master = None
483 if bucket.startswith(MASTER_PREFIX):
484 master = _unprefix_master(bucket)
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000485 for builder, tests in sorted(builders_and_tests.iteritems()):
486 print_text.append(' %s: %s' % (builder, tests))
487 parameters = {
488 'builder_name': builder,
nodir@chromium.orgd2217312015-09-21 15:51:21 +0000489 'changes': [{
Andrii Shyshkaloveadad922017-01-26 09:38:30 +0100490 'author': {'email': changelist.GetIssueOwner()},
nodir@chromium.orgd2217312015-09-21 15:51:21 +0000491 'revision': options.revision,
492 }],
tandrii8c5a3532016-11-04 07:52:02 -0700493 'properties': shared_parameters_properties.copy(),
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000494 }
machenbach@chromium.org2403e802016-04-29 12:34:42 +0000495 if 'presubmit' in builder.lower():
496 parameters['properties']['dry_run'] = 'true'
tandrii@chromium.org3764fa22015-10-21 16:40:40 +0000497 if tests:
498 parameters['properties']['testfilter'] = tests
borenet6c0efe62016-10-19 08:13:29 -0700499
500 tags = [
501 'builder:%s' % builder,
502 'buildset:%s' % buildset,
503 'user_agent:git_cl_try',
504 ]
505 if master:
506 parameters['properties']['master'] = master
507 tags.append('master:%s' % master)
508
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000509 batch_req_body['builds'].append(
510 {
511 'bucket': bucket,
512 'parameters_json': json.dumps(parameters),
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000513 'client_operation_id': str(uuid.uuid4()),
borenet6c0efe62016-10-19 08:13:29 -0700514 'tags': tags,
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000515 }
516 )
517
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000518 _buildbucket_retry(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000519 'triggering tryjobs',
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000520 http,
521 buildbucket_put_url,
522 'PUT',
523 body=json.dumps(batch_req_body),
524 headers={'Content-Type': 'application/json'}
525 )
tandrii@chromium.org35c61452016-02-26 15:24:57 +0000526 print_text.append('To see results here, run: git cl try-results')
527 print_text.append('To see results in browser, run: git cl web')
vapiera7fbd5a2016-06-16 09:17:49 -0700528 print('\n'.join(print_text))
kjellander@chromium.org44424542015-06-02 18:35:29 +0000529
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000530
tandrii221ab252016-10-06 08:12:04 -0700531def fetch_try_jobs(auth_config, changelist, buildbucket_host,
532 patchset=None):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000533 """Fetches tryjobs from buildbucket.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000534
qyearsley53f48a12016-09-01 10:45:13 -0700535 Returns a map from build id to build info as a dictionary.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000536 """
tandrii221ab252016-10-06 08:12:04 -0700537 assert buildbucket_host
538 assert changelist.GetIssue(), 'CL must be uploaded first'
539 assert changelist.GetCodereviewServer(), 'CL must be uploaded first'
540 patchset = patchset or changelist.GetMostRecentPatchset()
541 assert patchset, 'CL must be uploaded first'
542
543 codereview_url = changelist.GetCodereviewServer()
544 codereview_host = urlparse.urlparse(codereview_url).hostname
545 authenticator = auth.get_authenticator_for_host(codereview_host, auth_config)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000546 if authenticator.has_cached_credentials():
547 http = authenticator.authorize(httplib2.Http())
548 else:
vapiera7fbd5a2016-06-16 09:17:49 -0700549 print('Warning: Some results might be missing because %s' %
550 # Get the message on how to login.
tandrii221ab252016-10-06 08:12:04 -0700551 (auth.LoginRequiredError(codereview_host).message,))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000552 http = httplib2.Http()
553
554 http.force_exception_to_status_code = True
555
Andrii Shyshkalov03da1502018-10-15 03:42:34 +0000556 buildset = 'patch/gerrit/{hostname}/{issue}/{patch}'.format(
tandrii221ab252016-10-06 08:12:04 -0700557 hostname=codereview_host,
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000558 issue=changelist.GetIssue(),
tandrii221ab252016-10-06 08:12:04 -0700559 patch=patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000560 params = {'tag': 'buildset:%s' % buildset}
561
562 builds = {}
563 while True:
564 url = 'https://{hostname}/_ah/api/buildbucket/v1/search?{params}'.format(
tandrii221ab252016-10-06 08:12:04 -0700565 hostname=buildbucket_host,
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000566 params=urllib.urlencode(params))
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000567 content = _buildbucket_retry('fetching tryjobs', http, url, 'GET')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000568 for build in content.get('builds', []):
569 builds[build['id']] = build
570 if 'next_cursor' in content:
571 params['start_cursor'] = content['next_cursor']
572 else:
573 break
574 return builds
575
576
qyearsleyeab3c042016-08-24 09:18:28 -0700577def print_try_jobs(options, builds):
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000578 """Prints nicely result of fetch_try_jobs."""
579 if not builds:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000580 print('No tryjobs scheduled.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000581 return
582
583 # Make a copy, because we'll be modifying builds dictionary.
584 builds = builds.copy()
585 builder_names_cache = {}
586
587 def get_builder(b):
588 try:
589 return builder_names_cache[b['id']]
590 except KeyError:
591 try:
592 parameters = json.loads(b['parameters_json'])
593 name = parameters['builder_name']
594 except (ValueError, KeyError) as error:
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700595 print('WARNING: Failed to get builder name for build %s: %s' % (
vapiera7fbd5a2016-06-16 09:17:49 -0700596 b['id'], error))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000597 name = None
598 builder_names_cache[b['id']] = name
599 return name
600
601 def get_bucket(b):
602 bucket = b['bucket']
603 if bucket.startswith('master.'):
604 return bucket[len('master.'):]
605 return bucket
606
607 if options.print_master:
608 name_fmt = '%%-%ds %%-%ds' % (
609 max(len(str(get_bucket(b))) for b in builds.itervalues()),
610 max(len(str(get_builder(b))) for b in builds.itervalues()))
611 def get_name(b):
612 return name_fmt % (get_bucket(b), get_builder(b))
613 else:
614 name_fmt = '%%-%ds' % (
615 max(len(str(get_builder(b))) for b in builds.itervalues()))
616 def get_name(b):
617 return name_fmt % get_builder(b)
618
619 def sort_key(b):
620 return b['status'], b.get('result'), get_name(b), b.get('url')
621
622 def pop(title, f, color=None, **kwargs):
623 """Pop matching builds from `builds` dict and print them."""
624
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +0000625 if not options.color or color is None:
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000626 colorize = str
627 else:
628 colorize = lambda x: '%s%s%s' % (color, x, Fore.RESET)
629
630 result = []
631 for b in builds.values():
632 if all(b.get(k) == v for k, v in kwargs.iteritems()):
633 builds.pop(b['id'])
634 result.append(b)
635 if result:
vapiera7fbd5a2016-06-16 09:17:49 -0700636 print(colorize(title))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000637 for b in sorted(result, key=sort_key):
vapiera7fbd5a2016-06-16 09:17:49 -0700638 print(' ', colorize('\t'.join(map(str, f(b)))))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000639
640 total = len(builds)
641 pop(status='COMPLETED', result='SUCCESS',
642 title='Successes:', color=Fore.GREEN,
643 f=lambda b: (get_name(b), b.get('url')))
644 pop(status='COMPLETED', result='FAILURE', failure_reason='INFRA_FAILURE',
645 title='Infra Failures:', color=Fore.MAGENTA,
646 f=lambda b: (get_name(b), b.get('url')))
647 pop(status='COMPLETED', result='FAILURE', failure_reason='BUILD_FAILURE',
648 title='Failures:', color=Fore.RED,
649 f=lambda b: (get_name(b), b.get('url')))
650 pop(status='COMPLETED', result='CANCELED',
651 title='Canceled:', color=Fore.MAGENTA,
652 f=lambda b: (get_name(b),))
653 pop(status='COMPLETED', result='FAILURE',
654 failure_reason='INVALID_BUILD_DEFINITION',
655 title='Wrong master/builder name:', color=Fore.MAGENTA,
656 f=lambda b: (get_name(b),))
657 pop(status='COMPLETED', result='FAILURE',
658 title='Other failures:',
659 f=lambda b: (get_name(b), b.get('failure_reason'), b.get('url')))
660 pop(status='COMPLETED',
661 title='Other finished:',
662 f=lambda b: (get_name(b), b.get('result'), b.get('url')))
663 pop(status='STARTED',
664 title='Started:', color=Fore.YELLOW,
665 f=lambda b: (get_name(b), b.get('url')))
666 pop(status='SCHEDULED',
667 title='Scheduled:',
668 f=lambda b: (get_name(b), 'id=%s' % b['id']))
669 # The last section is just in case buildbucket API changes OR there is a bug.
670 pop(title='Other:',
671 f=lambda b: (get_name(b), 'id=%s' % b['id']))
672 assert len(builds) == 0
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000673 print('Total: %d tryjobs' % total)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000674
675
Aiden Bennerc08566e2018-10-03 17:52:42 +0000676def _ComputeDiffLineRanges(files, upstream_commit):
677 """Gets the changed line ranges for each file since upstream_commit.
678
679 Parses a git diff on provided files and returns a dict that maps a file name
680 to an ordered list of range tuples in the form (start_line, count).
681 Ranges are in the same format as a git diff.
682 """
683 # If files is empty then diff_output will be a full diff.
684 if len(files) == 0:
685 return {}
686
Aiden Benner6c18a1a2018-11-23 20:18:23 +0000687 # Take the git diff and find the line ranges where there are changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000688 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, files, allow_prefix=True)
689 diff_output = RunGit(diff_cmd)
690
691 pattern = r'(?:^diff --git a/(?:.*) b/(.*))|(?:^@@.*\+(.*) @@)'
692 # 2 capture groups
693 # 0 == fname of diff file
694 # 1 == 'diff_start,diff_count' or 'diff_start'
695 # will match each of
696 # diff --git a/foo.foo b/foo.py
697 # @@ -12,2 +14,3 @@
698 # @@ -12,2 +17 @@
699 # running re.findall on the above string with pattern will give
700 # [('foo.py', ''), ('', '14,3'), ('', '17')]
701
702 curr_file = None
703 line_diffs = {}
704 for match in re.findall(pattern, diff_output, flags=re.MULTILINE):
705 if match[0] != '':
706 # Will match the second filename in diff --git a/a.py b/b.py.
707 curr_file = match[0]
708 line_diffs[curr_file] = []
709 else:
710 # Matches +14,3
711 if ',' in match[1]:
712 diff_start, diff_count = match[1].split(',')
713 else:
714 # Single line changes are of the form +12 instead of +12,1.
715 diff_start = match[1]
716 diff_count = 1
717
718 diff_start = int(diff_start)
719 diff_count = int(diff_count)
720
721 # If diff_count == 0 this is a removal we can ignore.
722 line_diffs[curr_file].append((diff_start, diff_count))
723
724 return line_diffs
725
726
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000727def _FindYapfConfigFile(fpath, yapf_config_cache, top_dir=None):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000728 """Checks if a yapf file is in any parent directory of fpath until top_dir.
729
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000730 Recursively checks parent directories to find yapf file and if no yapf file
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000731 is found returns None. Uses yapf_config_cache as a cache for previously found
732 configs.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000733 """
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000734 fpath = os.path.abspath(fpath)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000735 # Return result if we've already computed it.
736 if fpath in yapf_config_cache:
737 return yapf_config_cache[fpath]
738
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000739 parent_dir = os.path.dirname(fpath)
740 if os.path.isfile(fpath):
741 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000742 else:
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000743 # Otherwise fpath is a directory
744 yapf_file = os.path.join(fpath, YAPF_CONFIG_FILENAME)
745 if os.path.isfile(yapf_file):
746 ret = yapf_file
747 elif fpath == top_dir or parent_dir == fpath:
748 # If we're at the top level directory, or if we're at root
749 # there is no provided style.
750 ret = None
751 else:
752 # Otherwise recurse on the current directory.
753 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000754 yapf_config_cache[fpath] = ret
755 return ret
756
757
qyearsley53f48a12016-09-01 10:45:13 -0700758def write_try_results_json(output_file, builds):
759 """Writes a subset of the data from fetch_try_jobs to a file as JSON.
760
761 The input |builds| dict is assumed to be generated by Buildbucket.
762 Buildbucket documentation: http://goo.gl/G0s101
763 """
764
765 def convert_build_dict(build):
Quinten Yearsleya563d722017-12-11 16:36:54 -0800766 """Extracts some of the information from one build dict."""
767 parameters = json.loads(build.get('parameters_json', '{}')) or {}
qyearsley53f48a12016-09-01 10:45:13 -0700768 return {
769 'buildbucket_id': build.get('id'),
qyearsley53f48a12016-09-01 10:45:13 -0700770 'bucket': build.get('bucket'),
Quinten Yearsleya563d722017-12-11 16:36:54 -0800771 'builder_name': parameters.get('builder_name'),
772 'created_ts': build.get('created_ts'),
773 'experimental': build.get('experimental'),
qyearsley53f48a12016-09-01 10:45:13 -0700774 'failure_reason': build.get('failure_reason'),
Quinten Yearsleya563d722017-12-11 16:36:54 -0800775 'result': build.get('result'),
776 'status': build.get('status'),
777 'tags': build.get('tags'),
qyearsley53f48a12016-09-01 10:45:13 -0700778 'url': build.get('url'),
779 }
780
781 converted = []
782 for _, build in sorted(builds.items()):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000783 converted.append(convert_build_dict(build))
qyearsley53f48a12016-09-01 10:45:13 -0700784 write_json(output_file, converted)
785
786
Aaron Gable13101a62018-02-09 13:20:41 -0800787def print_stats(args):
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000788 """Prints statistics about the change to the user."""
789 # --no-ext-diff is broken in some versions of Git, so try to work around
790 # this by overriding the environment (but there is still a problem if the
791 # git config key "diff.external" is used).
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000792 env = GetNoGitPagerEnv()
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000793 if 'GIT_EXTERNAL_DIFF' in env:
794 del env['GIT_EXTERNAL_DIFF']
iannucci@chromium.org79540052012-10-19 23:15:26 +0000795
szager@chromium.orgd057f9a2014-05-29 21:09:36 +0000796 try:
797 stdout = sys.stdout.fileno()
798 except AttributeError:
799 stdout = None
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000800 return subprocess2.call(
Aaron Gable13101a62018-02-09 13:20:41 -0800801 ['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] + args,
szager@chromium.orgd057f9a2014-05-29 21:09:36 +0000802 stdout=stdout, env=env)
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000803
804
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000805class BuildbucketResponseException(Exception):
806 pass
807
808
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000809class Settings(object):
810 def __init__(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000811 self.cc = None
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000812 self.root = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000813 self.tree_status_url = None
814 self.viewvc_url = None
815 self.updated = False
ukai@chromium.orge8077812012-02-03 03:41:46 +0000816 self.is_gerrit = None
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000817 self.squash_gerrit_uploads = None
tandrii@chromium.org28253532016-04-14 13:46:56 +0000818 self.gerrit_skip_ensure_authenticated = None
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000819 self.git_editor = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000820
821 def LazyUpdateIfNeeded(self):
822 """Updates the settings from a codereview.settings file, if available."""
823 if not self.updated:
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000824 # The only value that actually changes the behavior is
825 # autoupdate = "false". Everything else means "true".
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +0000826 autoupdate = RunGit(['config', 'rietveld.autoupdate'],
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000827 error_ok=True
828 ).strip().lower()
829
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000830 cr_settings_file = FindCodereviewSettingsFile()
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000831 if autoupdate != 'false' and cr_settings_file:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000832 LoadCodereviewSettingsFromFile(cr_settings_file)
833 self.updated = True
834
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000835 @staticmethod
836 def GetRelativeRoot():
837 return RunGit(['rev-parse', '--show-cdup']).strip()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000838
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000839 def GetRoot(self):
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000840 if self.root is None:
841 self.root = os.path.abspath(self.GetRelativeRoot())
842 return self.root
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000843
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000844 def GetTreeStatusUrl(self, error_ok=False):
845 if not self.tree_status_url:
846 error_message = ('You must configure your tree status URL by running '
847 '"git cl config".')
Edward Lemur61ea3072018-12-01 00:34:36 +0000848 self.tree_status_url = self._GetConfig(
849 'rietveld.tree-status-url', error_ok=error_ok,
850 error_message=error_message)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000851 return self.tree_status_url
852
853 def GetViewVCUrl(self):
854 if not self.viewvc_url:
Edward Lemur61ea3072018-12-01 00:34:36 +0000855 self.viewvc_url = self._GetConfig('rietveld.viewvc-url', error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000856 return self.viewvc_url
857
rmistry@google.com90752582014-01-14 21:04:50 +0000858 def GetBugPrefix(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000859 return self._GetConfig('rietveld.bug-prefix', error_ok=True)
rmistry@google.com78948ed2015-07-08 23:09:57 +0000860
rmistry@google.com5626a922015-02-26 14:03:30 +0000861 def GetRunPostUploadHook(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000862 run_post_upload_hook = self._GetConfig(
863 'rietveld.run-post-upload-hook', error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +0000864 return run_post_upload_hook == "True"
865
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000866 def GetDefaultCCList(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000867 return self._GetConfig('rietveld.cc', error_ok=True)
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000868
ukai@chromium.orge8077812012-02-03 03:41:46 +0000869 def GetIsGerrit(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000870 """Returns True if this repo is associated with Gerrit."""
ukai@chromium.orge8077812012-02-03 03:41:46 +0000871 if self.is_gerrit is None:
Aaron Gable9b465272017-05-12 10:53:51 -0700872 self.is_gerrit = (
873 self._GetConfig('gerrit.host', error_ok=True).lower() == 'true')
ukai@chromium.orge8077812012-02-03 03:41:46 +0000874 return self.is_gerrit
875
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000876 def GetSquashGerritUploads(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000877 """Returns True if uploads to Gerrit should be squashed by default."""
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000878 if self.squash_gerrit_uploads is None:
tandriia60502f2016-06-20 02:01:53 -0700879 self.squash_gerrit_uploads = self.GetSquashGerritUploadsOverride()
880 if self.squash_gerrit_uploads is None:
881 # Default is squash now (http://crbug.com/611892#c23).
882 self.squash_gerrit_uploads = not (
883 RunGit(['config', '--bool', 'gerrit.squash-uploads'],
884 error_ok=True).strip() == 'false')
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000885 return self.squash_gerrit_uploads
886
tandriia60502f2016-06-20 02:01:53 -0700887 def GetSquashGerritUploadsOverride(self):
888 """Return True or False if codereview.settings should be overridden.
889
890 Returns None if no override has been defined.
891 """
892 # See also http://crbug.com/611892#c23
893 result = RunGit(['config', '--bool', 'gerrit.override-squash-uploads'],
894 error_ok=True).strip()
895 if result == 'true':
896 return True
897 if result == 'false':
898 return False
899 return None
900
tandrii@chromium.org28253532016-04-14 13:46:56 +0000901 def GetGerritSkipEnsureAuthenticated(self):
902 """Return True if EnsureAuthenticated should not be done for Gerrit
903 uploads."""
904 if self.gerrit_skip_ensure_authenticated is None:
905 self.gerrit_skip_ensure_authenticated = (
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000906 RunGit(['config', '--bool', 'gerrit.skip-ensure-authenticated'],
tandrii@chromium.org28253532016-04-14 13:46:56 +0000907 error_ok=True).strip() == 'true')
908 return self.gerrit_skip_ensure_authenticated
909
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000910 def GetGitEditor(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000911 """Returns the editor specified in the git config, or None if none is."""
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000912 if self.git_editor is None:
Raul Tambre5a525872019-02-12 19:08:08 +0000913 # Git requires single quotes for paths with spaces. We need to replace
914 # them with double quotes for Windows to treat such paths as a single
915 # path.
916 self.git_editor = self._GetConfig(
917 'core.editor', error_ok=True).replace('\'', '"')
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000918 return self.git_editor or None
919
thestig@chromium.org44202a22014-03-11 19:22:18 +0000920 def GetLintRegex(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000921 return (self._GetConfig('rietveld.cpplint-regex', error_ok=True) or
thestig@chromium.org44202a22014-03-11 19:22:18 +0000922 DEFAULT_LINT_REGEX)
923
924 def GetLintIgnoreRegex(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000925 return (self._GetConfig('rietveld.cpplint-ignore-regex', error_ok=True) or
thestig@chromium.org44202a22014-03-11 19:22:18 +0000926 DEFAULT_LINT_IGNORE_REGEX)
927
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000928 def _GetConfig(self, param, **kwargs):
929 self.LazyUpdateIfNeeded()
930 return RunGit(['config', param], **kwargs).strip()
931
932
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100933@contextlib.contextmanager
934def _get_gerrit_project_config_file(remote_url):
935 """Context manager to fetch and store Gerrit's project.config from
936 refs/meta/config branch and store it in temp file.
937
938 Provides a temporary filename or None if there was error.
939 """
940 error, _ = RunGitWithCode([
941 'fetch', remote_url,
942 '+refs/meta/config:refs/git_cl/meta/config'])
943 if error:
944 # Ref doesn't exist or isn't accessible to current user.
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700945 print('WARNING: Failed to fetch project config for %s: %s' %
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100946 (remote_url, error))
947 yield None
948 return
949
950 error, project_config_data = RunGitWithCode(
951 ['show', 'refs/git_cl/meta/config:project.config'])
952 if error:
953 print('WARNING: project.config file not found')
954 yield None
955 return
956
957 with gclient_utils.temporary_directory() as tempdir:
958 project_config_file = os.path.join(tempdir, 'project.config')
959 gclient_utils.FileWrite(project_config_file, project_config_data)
960 yield project_config_file
961
962
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000963def ShortBranchName(branch):
964 """Convert a name like 'refs/heads/foo' to just 'foo'."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000965 return branch.replace('refs/heads/', '', 1)
966
967
968def GetCurrentBranchRef():
969 """Returns branch ref (e.g., refs/heads/master) or None."""
970 return RunGit(['symbolic-ref', 'HEAD'],
971 stderr=subprocess2.VOID, error_ok=True).strip() or None
972
973
974def GetCurrentBranch():
975 """Returns current branch or None.
976
977 For refs/heads/* branches, returns just last part. For others, full ref.
978 """
979 branchref = GetCurrentBranchRef()
980 if branchref:
981 return ShortBranchName(branchref)
982 return None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000983
984
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000985class _CQState(object):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +0000986 """Enum for states of CL with respect to CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000987 NONE = 'none'
988 DRY_RUN = 'dry_run'
989 COMMIT = 'commit'
990
991 ALL_STATES = [NONE, DRY_RUN, COMMIT]
992
993
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000994class _ParsedIssueNumberArgument(object):
Edward Lemurf38bc172019-09-03 21:02:13 +0000995 def __init__(self, issue=None, patchset=None, hostname=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000996 self.issue = issue
997 self.patchset = patchset
998 self.hostname = hostname
999
1000 @property
1001 def valid(self):
1002 return self.issue is not None
1003
1004
Edward Lemurf38bc172019-09-03 21:02:13 +00001005def ParseIssueNumberArgument(arg):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001006 """Parses the issue argument and returns _ParsedIssueNumberArgument."""
1007 fail_result = _ParsedIssueNumberArgument()
1008
1009 if arg.isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00001010 return _ParsedIssueNumberArgument(issue=int(arg))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001011 if not arg.startswith('http'):
1012 return fail_result
Aaron Gableaee6c852017-06-26 12:49:01 -07001013
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001014 url = gclient_utils.UpgradeToHttps(arg)
1015 try:
1016 parsed_url = urlparse.urlparse(url)
1017 except ValueError:
1018 return fail_result
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02001019
Andrii Shyshkalov0a264d82018-11-21 00:36:16 +00001020 return _GerritChangelistImpl.ParseIssueURL(parsed_url) or fail_result
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001021
1022
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00001023def _create_description_from_log(args):
1024 """Pulls out the commit log to use as a base for the CL description."""
1025 log_args = []
1026 if len(args) == 1 and not args[0].endswith('.'):
1027 log_args = [args[0] + '..']
1028 elif len(args) == 1 and args[0].endswith('...'):
1029 log_args = [args[0][:-1]]
1030 elif len(args) == 2:
1031 log_args = [args[0] + '..' + args[1]]
1032 else:
1033 log_args = args[:] # Hope for the best!
1034 return RunGit(['log', '--pretty=format:%s\n\n%b'] + log_args)
1035
1036
Aaron Gablea45ee112016-11-22 15:14:38 -08001037class GerritChangeNotExists(Exception):
tandriic2405f52016-10-10 08:13:15 -07001038 def __init__(self, issue, url):
1039 self.issue = issue
1040 self.url = url
Aaron Gablea45ee112016-11-22 15:14:38 -08001041 super(GerritChangeNotExists, self).__init__()
tandriic2405f52016-10-10 08:13:15 -07001042
1043 def __str__(self):
Aaron Gablea45ee112016-11-22 15:14:38 -08001044 return 'change %s at %s does not exist or you have no access to it' % (
tandriic2405f52016-10-10 08:13:15 -07001045 self.issue, self.url)
1046
1047
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001048_CommentSummary = collections.namedtuple(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001049 '_CommentSummary', ['date', 'message', 'sender', 'autogenerated',
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001050 # TODO(tandrii): these two aren't known in Gerrit.
1051 'approval', 'disapproval'])
1052
1053
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001054class Changelist(object):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001055 """Changelist works with one changelist in local branch.
1056
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00001057 Notes:
1058 * Not safe for concurrent multi-{thread,process} use.
1059 * Caches values from current branch. Therefore, re-use after branch change
tandrii5d48c322016-08-18 16:19:37 -07001060 with great care.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001061 """
1062
Edward Lemurf38bc172019-09-03 21:02:13 +00001063 def __init__(self, branchref=None, issue=None, **kwargs):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001064 """Create a new ChangeList instance.
1065
Edward Lemurf38bc172019-09-03 21:02:13 +00001066 **kwargs will be passed directly to Gerrit implementation.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001067 """
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001068 # Poke settings so we get the "configure your server" message if necessary.
maruel@chromium.org379d07a2011-11-30 14:58:10 +00001069 global settings
1070 if not settings:
1071 # Happens when git_cl.py is used as a utility library.
1072 settings = Settings()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001073
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001074 self.branchref = branchref
1075 if self.branchref:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00001076 assert branchref.startswith('refs/heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001077 self.branch = ShortBranchName(self.branchref)
1078 else:
1079 self.branch = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001080 self.upstream_branch = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001081 self.lookedup_issue = False
1082 self.issue = issue or None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001083 self.has_description = False
1084 self.description = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001085 self.lookedup_patchset = False
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001086 self.patchset = None
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001087 self.cc = None
Daniel Cheng7227d212017-11-17 08:12:37 -08001088 self.more_cc = []
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001089 self._remote = None
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001090 self._cached_remote_url = (False, None) # (is_cached, value)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001091
Edward Lemurf38bc172019-09-03 21:02:13 +00001092 self._codereview_impl = _GerritChangelistImpl(self, **kwargs)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001093
1094 def GetCCList(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001095 """Returns the users cc'd on this CL.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001096
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001097 The return value is a string suitable for passing to git cl with the --cc
1098 flag.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001099 """
1100 if self.cc is None:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001101 base_cc = settings.GetDefaultCCList()
Daniel Cheng7227d212017-11-17 08:12:37 -08001102 more_cc = ','.join(self.more_cc)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001103 self.cc = ','.join(filter(None, (base_cc, more_cc))) or ''
1104 return self.cc
1105
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001106 def GetCCListWithoutDefault(self):
1107 """Return the users cc'd on this CL excluding default ones."""
1108 if self.cc is None:
Daniel Cheng7227d212017-11-17 08:12:37 -08001109 self.cc = ','.join(self.more_cc)
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001110 return self.cc
1111
Daniel Cheng7227d212017-11-17 08:12:37 -08001112 def ExtendCC(self, more_cc):
1113 """Extends the list of users to cc on this CL based on the changed files."""
1114 self.more_cc.extend(more_cc)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001115
1116 def GetBranch(self):
1117 """Returns the short branch name, e.g. 'master'."""
1118 if not self.branch:
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001119 branchref = GetCurrentBranchRef()
szager@chromium.orgd62c61f2014-10-20 22:33:21 +00001120 if not branchref:
1121 return None
1122 self.branchref = branchref
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001123 self.branch = ShortBranchName(self.branchref)
1124 return self.branch
1125
1126 def GetBranchRef(self):
1127 """Returns the full branch name, e.g. 'refs/heads/master'."""
1128 self.GetBranch() # Poke the lazy loader.
1129 return self.branchref
1130
tandrii@chromium.org534f67a2016-04-07 18:47:05 +00001131 def ClearBranch(self):
1132 """Clears cached branch data of this object."""
1133 self.branch = self.branchref = None
1134
tandrii5d48c322016-08-18 16:19:37 -07001135 def _GitGetBranchConfigValue(self, key, default=None, **kwargs):
1136 assert 'branch' not in kwargs, 'this CL branch is used automatically'
1137 kwargs['branch'] = self.GetBranch()
1138 return _git_get_branch_config_value(key, default, **kwargs)
1139
1140 def _GitSetBranchConfigValue(self, key, value, **kwargs):
1141 assert 'branch' not in kwargs, 'this CL branch is used automatically'
1142 assert self.GetBranch(), (
1143 'this CL must have an associated branch to %sset %s%s' %
1144 ('un' if value is None else '',
1145 key,
1146 '' if value is None else ' to %r' % value))
1147 kwargs['branch'] = self.GetBranch()
1148 return _git_set_branch_config_value(key, value, **kwargs)
1149
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001150 @staticmethod
1151 def FetchUpstreamTuple(branch):
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001152 """Returns a tuple containing remote and remote ref,
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001153 e.g. 'origin', 'refs/heads/master'
1154 """
1155 remote = '.'
tandrii5d48c322016-08-18 16:19:37 -07001156 upstream_branch = _git_get_branch_config_value('merge', branch=branch)
1157
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001158 if upstream_branch:
tandrii5d48c322016-08-18 16:19:37 -07001159 remote = _git_get_branch_config_value('remote', branch=branch)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001160 else:
bauerb@chromium.orgade368c2011-03-01 08:57:50 +00001161 upstream_branch = RunGit(['config', 'rietveld.upstream-branch'],
1162 error_ok=True).strip()
1163 if upstream_branch:
1164 remote = RunGit(['config', 'rietveld.upstream-remote']).strip()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001165 else:
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001166 # Else, try to guess the origin remote.
1167 remote_branches = RunGit(['branch', '-r']).split()
1168 if 'origin/master' in remote_branches:
1169 # Fall back on origin/master if it exits.
1170 remote = 'origin'
1171 upstream_branch = 'refs/heads/master'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001172 else:
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001173 DieWithError(
1174 'Unable to determine default branch to diff against.\n'
1175 'Either pass complete "git diff"-style arguments, like\n'
1176 ' git cl upload origin/master\n'
1177 'or verify this branch is set up to track another \n'
1178 '(via the --track argument to "git checkout -b ...").')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001179
1180 return remote, upstream_branch
1181
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001182 def GetCommonAncestorWithUpstream(self):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001183 upstream_branch = self.GetUpstreamBranch()
1184 if not BranchExists(upstream_branch):
1185 DieWithError('The upstream for the current branch (%s) does not exist '
1186 'anymore.\nPlease fix it and try again.' % self.GetBranch())
iannucci@chromium.org9e849272014-04-04 00:31:55 +00001187 return git_common.get_or_create_merge_base(self.GetBranch(),
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001188 upstream_branch)
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001189
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001190 def GetUpstreamBranch(self):
1191 if self.upstream_branch is None:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001192 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Raul Tambrefe1dbe12019-05-02 04:43:57 +00001193 if remote != '.':
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001194 upstream_branch = upstream_branch.replace('refs/heads/',
1195 'refs/remotes/%s/' % remote)
1196 upstream_branch = upstream_branch.replace('refs/branch-heads/',
1197 'refs/remotes/branch-heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001198 self.upstream_branch = upstream_branch
1199 return self.upstream_branch
1200
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001201 def GetRemoteBranch(self):
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001202 if not self._remote:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001203 remote, branch = None, self.GetBranch()
1204 seen_branches = set()
1205 while branch not in seen_branches:
1206 seen_branches.add(branch)
1207 remote, branch = self.FetchUpstreamTuple(branch)
1208 branch = ShortBranchName(branch)
1209 if remote != '.' or branch.startswith('refs/remotes'):
1210 break
1211 else:
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001212 remotes = RunGit(['remote'], error_ok=True).split()
1213 if len(remotes) == 1:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001214 remote, = remotes
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001215 elif 'origin' in remotes:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001216 remote = 'origin'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001217 logging.warn('Could not determine which remote this change is '
1218 'associated with, so defaulting to "%s".' % self._remote)
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001219 else:
1220 logging.warn('Could not determine which remote this change is '
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001221 'associated with.')
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001222 branch = 'HEAD'
1223 if branch.startswith('refs/remotes'):
1224 self._remote = (remote, branch)
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001225 elif branch.startswith('refs/branch-heads/'):
1226 self._remote = (remote, branch.replace('refs/', 'refs/remotes/'))
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001227 else:
1228 self._remote = (remote, 'refs/remotes/%s/%s' % (remote, branch))
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001229 return self._remote
1230
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001231 def GitSanityChecks(self, upstream_git_obj):
1232 """Checks git repo status and ensures diff is from local commits."""
1233
sbc@chromium.org79706062015-01-14 21:18:12 +00001234 if upstream_git_obj is None:
1235 if self.GetBranch() is None:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001236 print('ERROR: Unable to determine current branch (detached HEAD?)',
vapiera7fbd5a2016-06-16 09:17:49 -07001237 file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001238 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001239 print('ERROR: No upstream branch.', file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001240 return False
1241
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001242 # Verify the commit we're diffing against is in our current branch.
1243 upstream_sha = RunGit(['rev-parse', '--verify', upstream_git_obj]).strip()
1244 common_ancestor = RunGit(['merge-base', upstream_sha, 'HEAD']).strip()
1245 if upstream_sha != common_ancestor:
vapiera7fbd5a2016-06-16 09:17:49 -07001246 print('ERROR: %s is not in the current branch. You may need to rebase '
1247 'your tracking branch' % upstream_sha, file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001248 return False
1249
1250 # List the commits inside the diff, and verify they are all local.
1251 commits_in_diff = RunGit(
1252 ['rev-list', '^%s' % upstream_sha, 'HEAD']).splitlines()
1253 code, remote_branch = RunGitWithCode(['config', 'gitcl.remotebranch'])
1254 remote_branch = remote_branch.strip()
1255 if code != 0:
1256 _, remote_branch = self.GetRemoteBranch()
1257
1258 commits_in_remote = RunGit(
1259 ['rev-list', '^%s' % upstream_sha, remote_branch]).splitlines()
1260
1261 common_commits = set(commits_in_diff) & set(commits_in_remote)
1262 if common_commits:
vapiera7fbd5a2016-06-16 09:17:49 -07001263 print('ERROR: Your diff contains %d commits already in %s.\n'
1264 'Run "git log --oneline %s..HEAD" to get a list of commits in '
1265 'the diff. If you are using a custom git flow, you can override'
1266 ' the reference used for this check with "git config '
1267 'gitcl.remotebranch <git-ref>".' % (
1268 len(common_commits), remote_branch, upstream_git_obj),
1269 file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001270 return False
1271 return True
1272
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001273 def GetGitBaseUrlFromConfig(self):
sheyang@chromium.orga656e702014-05-15 20:43:05 +00001274 """Return the configured base URL from branch.<branchname>.baseurl.
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001275
1276 Returns None if it is not set.
1277 """
tandrii5d48c322016-08-18 16:19:37 -07001278 return self._GitGetBranchConfigValue('base-url')
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001279
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001280 def GetRemoteUrl(self):
1281 """Return the configured remote URL, e.g. 'git://example.org/foo.git/'.
1282
1283 Returns None if there is no remote.
1284 """
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001285 is_cached, value = self._cached_remote_url
1286 if is_cached:
1287 return value
1288
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001289 remote, _ = self.GetRemoteBranch()
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001290 url = RunGit(['config', 'remote.%s.url' % remote], error_ok=True).strip()
1291
Edward Lemur298f2cf2019-02-22 21:40:39 +00001292 # Check if the remote url can be parsed as an URL.
1293 host = urlparse.urlparse(url).netloc
1294 if host:
1295 self._cached_remote_url = (True, url)
1296 return url
1297
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001298 # If it cannot be parsed as an url, assume it is a local directory,
1299 # probably a git cache.
Edward Lemur298f2cf2019-02-22 21:40:39 +00001300 logging.warning('"%s" doesn\'t appear to point to a git host. '
1301 'Interpreting it as a local directory.', url)
1302 if not os.path.isdir(url):
1303 logging.error(
1304 'Remote "%s" for branch "%s" points to "%s", but it doesn\'t exist.',
1305 remote, url, self.GetBranch())
1306 return None
1307
1308 cache_path = url
1309 url = RunGit(['config', 'remote.%s.url' % remote],
1310 error_ok=True,
1311 cwd=url).strip()
1312
1313 host = urlparse.urlparse(url).netloc
1314 if not host:
1315 logging.error(
1316 'Remote "%(remote)s" for branch "%(branch)s" points to '
1317 '"%(cache_path)s", but it is misconfigured.\n'
1318 '"%(cache_path)s" must be a git repo and must have a remote named '
1319 '"%(remote)s" pointing to the git host.', {
1320 'remote': remote,
1321 'cache_path': cache_path,
1322 'branch': self.GetBranch()})
1323 return None
1324
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001325 self._cached_remote_url = (True, url)
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001326 return url
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001327
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001328 def GetIssue(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001329 """Returns the issue number as a int or None if not set."""
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001330 if self.issue is None and not self.lookedup_issue:
tandrii5d48c322016-08-18 16:19:37 -07001331 self.issue = self._GitGetBranchConfigValue(
1332 self._codereview_impl.IssueConfigKey(), value_type=int)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001333 self.lookedup_issue = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001334 return self.issue
1335
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001336 def GetIssueURL(self):
1337 """Get the URL for a particular issue."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001338 issue = self.GetIssue()
1339 if not issue:
dbeam@chromium.org015fd3d2013-06-18 19:02:50 +00001340 return None
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001341 return '%s/%s' % (self._codereview_impl.GetCodereviewServer(), issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001342
Andrii Shyshkalov31863012017-02-08 11:35:12 +01001343 def GetDescription(self, pretty=False, force=False):
1344 if not self.has_description or force:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001345 if self.GetIssue():
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001346 self.description = self._codereview_impl.FetchDescription(force=force)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001347 self.has_description = True
1348 if pretty:
Asanka Herath7c61dcb2016-12-14 13:01:58 -05001349 # Set width to 72 columns + 2 space indent.
1350 wrapper = textwrap.TextWrapper(width=74, replace_whitespace=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001351 wrapper.initial_indent = wrapper.subsequent_indent = ' '
Asanka Herath7c61dcb2016-12-14 13:01:58 -05001352 lines = self.description.splitlines()
1353 return '\n'.join([wrapper.fill(line) for line in lines])
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001354 return self.description
1355
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001356 def GetDescriptionFooters(self):
1357 """Returns (non_footer_lines, footers) for the commit message.
1358
1359 Returns:
1360 non_footer_lines (list(str)) - Simple list of description lines without
1361 any footer. The lines do not contain newlines, nor does the list contain
1362 the empty line between the message and the footers.
1363 footers (list(tuple(KEY, VALUE))) - List of parsed footers, e.g.
1364 [("Change-Id", "Ideadbeef...."), ...]
1365 """
1366 raw_description = self.GetDescription()
1367 msg_lines, _, footers = git_footers.split_footers(raw_description)
1368 if footers:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001369 msg_lines = msg_lines[:len(msg_lines) - 1]
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001370 return msg_lines, footers
1371
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001372 def GetPatchset(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001373 """Returns the patchset number as a int or None if not set."""
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001374 if self.patchset is None and not self.lookedup_patchset:
tandrii5d48c322016-08-18 16:19:37 -07001375 self.patchset = self._GitGetBranchConfigValue(
1376 self._codereview_impl.PatchsetConfigKey(), value_type=int)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001377 self.lookedup_patchset = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001378 return self.patchset
1379
1380 def SetPatchset(self, patchset):
tandrii5d48c322016-08-18 16:19:37 -07001381 """Set this branch's patchset. If patchset=0, clears the patchset."""
1382 assert self.GetBranch()
1383 if not patchset:
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001384 self.patchset = None
tandrii5d48c322016-08-18 16:19:37 -07001385 else:
1386 self.patchset = int(patchset)
1387 self._GitSetBranchConfigValue(
1388 self._codereview_impl.PatchsetConfigKey(), self.patchset)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001389
tandrii@chromium.orga342c922016-03-16 07:08:25 +00001390 def SetIssue(self, issue=None):
tandrii5d48c322016-08-18 16:19:37 -07001391 """Set this branch's issue. If issue isn't given, clears the issue."""
1392 assert self.GetBranch()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001393 if issue:
tandrii5d48c322016-08-18 16:19:37 -07001394 issue = int(issue)
1395 self._GitSetBranchConfigValue(
1396 self._codereview_impl.IssueConfigKey(), issue)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001397 self.issue = issue
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001398 codereview_server = self._codereview_impl.GetCodereviewServer()
1399 if codereview_server:
tandrii5d48c322016-08-18 16:19:37 -07001400 self._GitSetBranchConfigValue(
1401 self._codereview_impl.CodereviewServerConfigKey(),
1402 codereview_server)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001403 else:
tandrii5d48c322016-08-18 16:19:37 -07001404 # Reset all of these just to be clean.
1405 reset_suffixes = [
1406 'last-upload-hash',
1407 self._codereview_impl.IssueConfigKey(),
1408 self._codereview_impl.PatchsetConfigKey(),
1409 self._codereview_impl.CodereviewServerConfigKey(),
1410 ] + self._PostUnsetIssueProperties()
1411 for prop in reset_suffixes:
1412 self._GitSetBranchConfigValue(prop, None, error_ok=True)
Aaron Gableca01e2c2017-07-19 11:16:02 -07001413 msg = RunGit(['log', '-1', '--format=%B']).strip()
1414 if msg and git_footers.get_footer_change_id(msg):
1415 print('WARNING: The change patched into this branch has a Change-Id. '
1416 'Removing it.')
1417 RunGit(['commit', '--amend', '-m',
1418 git_footers.remove_footer(msg, 'Change-Id')])
Edward Lemurf38bc172019-09-03 21:02:13 +00001419 self.lookedup_issue = True
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001420 self.issue = None
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001421 self.patchset = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001422
dnjba1b0f32016-09-02 12:37:42 -07001423 def GetChange(self, upstream_branch, author, local_description=False):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001424 if not self.GitSanityChecks(upstream_branch):
1425 DieWithError('\nGit sanity check failure')
1426
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001427 root = settings.GetRelativeRoot()
bratell@opera.comf267b0e2013-05-02 09:11:43 +00001428 if not root:
1429 root = '.'
bauerb@chromium.org512f1ef2011-04-20 15:17:57 +00001430 absroot = os.path.abspath(root)
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001431
1432 # We use the sha1 of HEAD as a name of this change.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001433 name = RunGitWithCode(['rev-parse', 'HEAD'])[1].strip()
bauerb@chromium.org512f1ef2011-04-20 15:17:57 +00001434 # Need to pass a relative path for msysgit.
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001435 try:
maruel@chromium.org80a9ef12011-12-13 20:44:10 +00001436 files = scm.GIT.CaptureStatus([root], '.', upstream_branch)
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001437 except subprocess2.CalledProcessError:
1438 DieWithError(
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001439 ('\nFailed to diff against upstream branch %s\n\n'
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001440 'This branch probably doesn\'t exist anymore. To reset the\n'
1441 'tracking branch, please run\n'
stip7a3dd352016-09-22 17:32:28 -07001442 ' git branch --set-upstream-to origin/master %s\n'
1443 'or replace origin/master with the relevant branch') %
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001444 (upstream_branch, self.GetBranch()))
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001445
maruel@chromium.org52424302012-08-29 15:14:30 +00001446 issue = self.GetIssue()
1447 patchset = self.GetPatchset()
dnjba1b0f32016-09-02 12:37:42 -07001448 if issue and not local_description:
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001449 description = self.GetDescription()
1450 else:
1451 # If the change was never uploaded, use the log messages of all commits
1452 # up to the branch point, as git cl upload will prefill the description
1453 # with these log messages.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001454 args = ['log', '--pretty=format:%s%n%n%b', '%s...' % (upstream_branch)]
1455 description = RunGitWithCode(args)[1].strip()
maruel@chromium.org03b3bdc2011-06-14 13:04:12 +00001456
1457 if not author:
maruel@chromium.org13f623c2011-07-22 16:02:23 +00001458 author = RunGit(['config', 'user.email']).strip() or None
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001459 return presubmit_support.GitChange(
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001460 name,
1461 description,
1462 absroot,
1463 files,
1464 issue,
1465 patchset,
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001466 author,
1467 upstream=upstream_branch)
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001468
dsansomee2d6fd92016-09-08 00:10:47 -07001469 def UpdateDescription(self, description, force=False):
Andrii Shyshkalov83051152017-02-07 23:47:29 +01001470 self._codereview_impl.UpdateDescriptionRemote(description, force=force)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001471 self.description = description
Andrii Shyshkalov83051152017-02-07 23:47:29 +01001472 self.has_description = True
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001473
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001474 def UpdateDescriptionFooters(self, description_lines, footers, force=False):
1475 """Sets the description for this CL remotely.
1476
1477 You can get description_lines and footers with GetDescriptionFooters.
1478
1479 Args:
1480 description_lines (list(str)) - List of CL description lines without
1481 newline characters.
1482 footers (list(tuple(KEY, VALUE))) - List of footers, as returned by
1483 GetDescriptionFooters. Key must conform to the git footers format (i.e.
1484 `List-Of-Tokens`). It will be case-normalized so that each token is
1485 title-cased.
1486 """
1487 new_description = '\n'.join(description_lines)
1488 if footers:
1489 new_description += '\n'
1490 for k, v in footers:
1491 foot = '%s: %s' % (git_footers.normalize_name(k), v)
1492 if not git_footers.FOOTER_PATTERN.match(foot):
1493 raise ValueError('Invalid footer %r' % foot)
1494 new_description += foot + '\n'
1495 self.UpdateDescription(new_description, force)
1496
Edward Lesmes8e282792018-04-03 18:50:29 -04001497 def RunHook(self, committing, may_prompt, verbose, change, parallel):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001498 """Calls sys.exit() if the hook fails; returns a HookResults otherwise."""
1499 try:
Edward Lemur2c48f242019-06-04 16:14:09 +00001500 start = time_time()
1501 result = presubmit_support.DoPresubmitChecks(change, committing,
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001502 verbose=verbose, output_stream=sys.stdout, input_stream=sys.stdin,
1503 default_presubmit=None, may_prompt=may_prompt,
Edward Lesmes8e282792018-04-03 18:50:29 -04001504 gerrit_obj=self._codereview_impl.GetGerritObjForPresubmit(),
1505 parallel=parallel)
Edward Lemur2c48f242019-06-04 16:14:09 +00001506 metrics.collector.add_repeated('sub_commands', {
1507 'command': 'presubmit',
1508 'execution_time': time_time() - start,
1509 'exit_code': 0 if result.should_continue() else 1,
1510 })
1511 return result
vapierfd77ac72016-06-16 08:33:57 -07001512 except presubmit_support.PresubmitFailure as e:
Aaron Gable5d5f22c2018-02-02 09:12:41 -08001513 DieWithError('%s\nMaybe your depot_tools is out of date?' % e)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001514
Edward Lemurf38bc172019-09-03 21:02:13 +00001515 def CMDPatchIssue(self, issue_arg, nocommit):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001516 """Fetches and applies the issue patch from codereview to local branch."""
tandrii@chromium.orgef7c68c2016-04-07 09:39:39 +00001517 if isinstance(issue_arg, (int, long)) or issue_arg.isdigit():
1518 parsed_issue_arg = _ParsedIssueNumberArgument(int(issue_arg))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001519 else:
1520 # Assume url.
1521 parsed_issue_arg = self._codereview_impl.ParseIssueURL(
1522 urlparse.urlparse(issue_arg))
1523 if not parsed_issue_arg or not parsed_issue_arg.valid:
1524 DieWithError('Failed to parse issue argument "%s". '
1525 'Must be an issue number or a valid URL.' % issue_arg)
1526 return self._codereview_impl.CMDPatchWithParsedIssue(
Edward Lemurf38bc172019-09-03 21:02:13 +00001527 parsed_issue_arg, nocommit, False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001528
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001529 def CMDUpload(self, options, git_diff_args, orig_args):
1530 """Uploads a change to codereview."""
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001531 custom_cl_base = None
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001532 if git_diff_args:
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001533 custom_cl_base = base_branch = git_diff_args[0]
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001534 else:
1535 if self.GetBranch() is None:
1536 DieWithError('Can\'t upload from detached HEAD state. Get on a branch!')
1537
1538 # Default to diffing against common ancestor of upstream branch
1539 base_branch = self.GetCommonAncestorWithUpstream()
1540 git_diff_args = [base_branch, 'HEAD']
1541
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001542 # Fast best-effort checks to abort before running potentially expensive
1543 # hooks if uploading is likely to fail anyway. Passing these checks does
1544 # not guarantee that uploading will not fail.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001545 self._codereview_impl.EnsureAuthenticated(force=options.force)
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001546 self._codereview_impl.EnsureCanUploadPatchset(force=options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001547
1548 # Apply watchlists on upload.
1549 change = self.GetChange(base_branch, None)
1550 watchlist = watchlists.Watchlists(change.RepositoryRoot())
1551 files = [f.LocalPath() for f in change.AffectedFiles()]
1552 if not options.bypass_watchlists:
Daniel Cheng7227d212017-11-17 08:12:37 -08001553 self.ExtendCC(watchlist.GetWatchersForPaths(files))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001554
1555 if not options.bypass_hooks:
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001556 if options.reviewers or options.tbrs or options.add_owners_to:
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001557 # Set the reviewer list now so that presubmit checks can access it.
1558 change_description = ChangeDescription(change.FullDescriptionText())
1559 change_description.update_reviewers(options.reviewers,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001560 options.tbrs,
Robert Iannuccif2708bd2017-04-17 15:49:02 -07001561 options.add_owners_to,
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001562 change)
1563 change.SetDescriptionText(change_description.description)
1564 hook_results = self.RunHook(committing=False,
Edward Lesmes8e282792018-04-03 18:50:29 -04001565 may_prompt=not options.force,
1566 verbose=options.verbose,
1567 change=change, parallel=options.parallel)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001568 if not hook_results.should_continue():
1569 return 1
1570 if not options.reviewers and hook_results.reviewers:
1571 options.reviewers = hook_results.reviewers.split(',')
Daniel Cheng7227d212017-11-17 08:12:37 -08001572 self.ExtendCC(hook_results.more_cc)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001573
Aaron Gable13101a62018-02-09 13:20:41 -08001574 print_stats(git_diff_args)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001575 ret = self.CMDUploadChange(options, git_diff_args, custom_cl_base, change)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001576 if not ret:
tandrii5d48c322016-08-18 16:19:37 -07001577 _git_set_branch_config_value('last-upload-hash',
1578 RunGit(['rev-parse', 'HEAD']).strip())
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001579 # Run post upload hooks, if specified.
1580 if settings.GetRunPostUploadHook():
1581 presubmit_support.DoPostUploadExecuter(
1582 change,
1583 self,
1584 settings.GetRoot(),
1585 options.verbose,
1586 sys.stdout)
1587
1588 # Upload all dependencies if specified.
1589 if options.dependencies:
vapiera7fbd5a2016-06-16 09:17:49 -07001590 print()
1591 print('--dependencies has been specified.')
1592 print('All dependent local branches will be re-uploaded.')
1593 print()
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001594 # Remove the dependencies flag from args so that we do not end up in a
1595 # loop.
1596 orig_args.remove('--dependencies')
1597 ret = upload_branch_deps(self, orig_args)
1598 return ret
1599
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001600 def SetCQState(self, new_state):
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001601 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001602
1603 Issue must have been already uploaded and known.
1604 """
1605 assert new_state in _CQState.ALL_STATES
1606 assert self.GetIssue()
qyearsley1fdfcb62016-10-24 13:22:03 -07001607 try:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001608 self._codereview_impl.SetCQState(new_state)
qyearsley1fdfcb62016-10-24 13:22:03 -07001609 return 0
1610 except KeyboardInterrupt:
1611 raise
1612 except:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001613 print('WARNING: Failed to %s.\n'
qyearsley1fdfcb62016-10-24 13:22:03 -07001614 'Either:\n'
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001615 ' * Your project has no CQ,\n'
1616 ' * You don\'t have permission to change the CQ state,\n'
1617 ' * There\'s a bug in this code (see stack trace below).\n'
1618 'Consider specifying which bots to trigger manually or asking your '
1619 'project owners for permissions or contacting Chrome Infra at:\n'
1620 'https://www.chromium.org/infra\n\n' %
1621 ('cancel CQ' if new_state == _CQState.NONE else 'trigger CQ'))
qyearsley1fdfcb62016-10-24 13:22:03 -07001622 # Still raise exception so that stack trace is printed.
1623 raise
1624
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001625 # Forward methods to codereview specific implementation.
1626
Aaron Gable636b13f2017-07-14 10:42:48 -07001627 def AddComment(self, message, publish=None):
1628 return self._codereview_impl.AddComment(message, publish=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001629
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001630 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001631 """Returns list of _CommentSummary for each comment.
1632
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001633 args:
1634 readable: determines whether the output is designed for a human or a machine
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001635 """
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001636 return self._codereview_impl.GetCommentsSummary(readable)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001637
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001638 def CloseIssue(self):
1639 return self._codereview_impl.CloseIssue()
1640
1641 def GetStatus(self):
1642 return self._codereview_impl.GetStatus()
1643
1644 def GetCodereviewServer(self):
1645 return self._codereview_impl.GetCodereviewServer()
1646
tandriide281ae2016-10-12 06:02:30 -07001647 def GetIssueOwner(self):
1648 """Get owner from codereview, which may differ from this checkout."""
1649 return self._codereview_impl.GetIssueOwner()
1650
Edward Lemur707d70b2018-02-07 00:50:14 +01001651 def GetReviewers(self):
1652 return self._codereview_impl.GetReviewers()
1653
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001654 def GetMostRecentPatchset(self):
1655 return self._codereview_impl.GetMostRecentPatchset()
1656
tandriide281ae2016-10-12 06:02:30 -07001657 def CannotTriggerTryJobReason(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001658 """Returns reason (str) if unable trigger tryjobs on this CL or None."""
tandriide281ae2016-10-12 06:02:30 -07001659 return self._codereview_impl.CannotTriggerTryJobReason()
1660
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001661 def GetTryJobProperties(self, patchset=None):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001662 """Returns dictionary of properties to launch tryjob."""
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001663 return self._codereview_impl.GetTryJobProperties(patchset=patchset)
tandrii8c5a3532016-11-04 07:52:02 -07001664
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001665 def __getattr__(self, attr):
1666 # This is because lots of untested code accesses Rietveld-specific stuff
1667 # directly, and it's hard to fix for sure. So, just let it work, and fix
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00001668 # on a case by case basis.
tandrii4d895502016-08-18 08:26:19 -07001669 # Note that child method defines __getattr__ as well, and forwards it here,
1670 # because _RietveldChangelistImpl is not cleaned up yet, and given
1671 # deprecation of Rietveld, it should probably be just removed.
1672 # Until that time, avoid infinite recursion by bypassing __getattr__
1673 # of implementation class.
1674 return self._codereview_impl.__getattribute__(attr)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001675
1676
1677class _ChangelistCodereviewBase(object):
1678 """Abstract base class encapsulating codereview specifics of a changelist."""
1679 def __init__(self, changelist):
1680 self._changelist = changelist # instance of Changelist
1681
1682 def __getattr__(self, attr):
1683 # Forward methods to changelist.
1684 # TODO(tandrii): maybe clean up _GerritChangelistImpl and
1685 # _RietveldChangelistImpl to avoid this hack?
1686 return getattr(self._changelist, attr)
1687
1688 def GetStatus(self):
1689 """Apply a rough heuristic to give a simple summary of an issue's review
1690 or CQ status, assuming adherence to a common workflow.
1691
1692 Returns None if no issue for this branch, or specific string keywords.
1693 """
1694 raise NotImplementedError()
1695
1696 def GetCodereviewServer(self):
1697 """Returns server URL without end slash, like "https://codereview.com"."""
1698 raise NotImplementedError()
1699
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001700 def FetchDescription(self, force=False):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001701 """Fetches and returns description from the codereview server."""
1702 raise NotImplementedError()
1703
tandrii5d48c322016-08-18 16:19:37 -07001704 @classmethod
1705 def IssueConfigKey(cls):
1706 """Returns branch setting storing issue number."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001707 raise NotImplementedError()
1708
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001709 @classmethod
tandrii5d48c322016-08-18 16:19:37 -07001710 def PatchsetConfigKey(cls):
1711 """Returns branch setting storing patchset number."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001712 raise NotImplementedError()
1713
tandrii5d48c322016-08-18 16:19:37 -07001714 @classmethod
1715 def CodereviewServerConfigKey(cls):
1716 """Returns branch setting storing codereview server."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001717 raise NotImplementedError()
1718
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001719 def _PostUnsetIssueProperties(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001720 """Which branch-specific properties to erase when unsetting issue."""
tandrii5d48c322016-08-18 16:19:37 -07001721 return []
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001722
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001723 def GetGerritObjForPresubmit(self):
1724 # None is valid return value, otherwise presubmit_support.GerritAccessor.
1725 return None
1726
dsansomee2d6fd92016-09-08 00:10:47 -07001727 def UpdateDescriptionRemote(self, description, force=False):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001728 """Update the description on codereview site."""
1729 raise NotImplementedError()
1730
Aaron Gable636b13f2017-07-14 10:42:48 -07001731 def AddComment(self, message, publish=None):
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001732 """Posts a comment to the codereview site."""
1733 raise NotImplementedError()
1734
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001735 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001736 raise NotImplementedError()
1737
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001738 def CloseIssue(self):
1739 """Closes the issue."""
1740 raise NotImplementedError()
1741
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001742 def GetMostRecentPatchset(self):
1743 """Returns the most recent patchset number from the codereview site."""
1744 raise NotImplementedError()
1745
Edward Lemurf38bc172019-09-03 21:02:13 +00001746 def CMDPatchWithParsedIssue(self, parsed_issue_arg, nocommit, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001747 """Fetches and applies the issue.
1748
1749 Arguments:
1750 parsed_issue_arg: instance of _ParsedIssueNumberArgument.
Edward Lemurf38bc172019-09-03 21:02:13 +00001751 nocommit: do not commit the patch, thus leave the tree dirty.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001752 """
1753 raise NotImplementedError()
1754
1755 @staticmethod
1756 def ParseIssueURL(parsed_url):
1757 """Parses url and returns instance of _ParsedIssueNumberArgument or None if
1758 failed."""
1759 raise NotImplementedError()
1760
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001761 def EnsureAuthenticated(self, force, refresh=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001762 """Best effort check that user is authenticated with codereview server.
1763
1764 Arguments:
1765 force: whether to skip confirmation questions.
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001766 refresh: whether to attempt to refresh credentials. Ignored if not
1767 applicable.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001768 """
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001769 raise NotImplementedError()
1770
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001771 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001772 """Best effort check that uploading isn't supposed to fail for predictable
1773 reasons.
1774
1775 This method should raise informative exception if uploading shouldn't
1776 proceed.
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001777
1778 Arguments:
1779 force: whether to skip confirmation questions.
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001780 """
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001781 raise NotImplementedError()
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001782
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001783 def CMDUploadChange(self, options, git_diff_args, custom_cl_base, change):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00001784 """Uploads a change to codereview."""
1785 raise NotImplementedError()
1786
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001787 def SetCQState(self, new_state):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001788 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001789
1790 Issue must have been already uploaded and known.
1791 """
1792 raise NotImplementedError()
1793
tandriie113dfd2016-10-11 10:20:12 -07001794 def CannotTriggerTryJobReason(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001795 """Returns reason (str) if unable trigger tryjobs on this CL or None."""
tandriie113dfd2016-10-11 10:20:12 -07001796 raise NotImplementedError()
1797
tandriide281ae2016-10-12 06:02:30 -07001798 def GetIssueOwner(self):
1799 raise NotImplementedError()
1800
Edward Lemur707d70b2018-02-07 00:50:14 +01001801 def GetReviewers(self):
1802 raise NotImplementedError()
1803
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001804 def GetTryJobProperties(self, patchset=None):
tandriide281ae2016-10-12 06:02:30 -07001805 raise NotImplementedError()
1806
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001807
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001808class _GerritChangelistImpl(_ChangelistCodereviewBase):
Edward Lemur934836a2019-09-09 20:16:54 +00001809 def __init__(self, changelist, codereview_host=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001810 super(_GerritChangelistImpl, self).__init__(changelist)
1811 self._change_id = None
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001812 # Lazily cached values.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001813 self._gerrit_host = None # e.g. chromium-review.googlesource.com
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001814 self._gerrit_server = None # e.g. https://chromium-review.googlesource.com
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001815 # Map from change number (issue) to its detail cache.
1816 self._detail_cache = {}
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001817
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001818 if codereview_host is not None:
1819 assert not codereview_host.startswith('https://'), codereview_host
1820 self._gerrit_host = codereview_host
1821 self._gerrit_server = 'https://%s' % codereview_host
1822
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001823 def _GetGerritHost(self):
1824 # Lazy load of configs.
1825 self.GetCodereviewServer()
tandriie32e3ea2016-06-22 02:52:48 -07001826 if self._gerrit_host and '.' not in self._gerrit_host:
1827 # Abbreviated domain like "chromium" instead of chromium.googlesource.com.
1828 # This happens for internal stuff http://crbug.com/614312.
1829 parsed = urlparse.urlparse(self.GetRemoteUrl())
1830 if parsed.scheme == 'sso':
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001831 print('WARNING: using non-https URLs for remote is likely broken\n'
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001832 ' Your current remote is: %s' % self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001833 self._gerrit_host = '%s.googlesource.com' % self._gerrit_host
1834 self._gerrit_server = 'https://%s' % self._gerrit_host
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001835 return self._gerrit_host
1836
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001837 def _GetGitHost(self):
1838 """Returns git host to be used when uploading change to Gerrit."""
Edward Lemur298f2cf2019-02-22 21:40:39 +00001839 remote_url = self.GetRemoteUrl()
1840 if not remote_url:
1841 return None
1842 return urlparse.urlparse(remote_url).netloc
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001843
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001844 def GetCodereviewServer(self):
1845 if not self._gerrit_server:
1846 # If we're on a branch then get the server potentially associated
1847 # with that branch.
1848 if self.GetIssue():
tandrii5d48c322016-08-18 16:19:37 -07001849 self._gerrit_server = self._GitGetBranchConfigValue(
1850 self.CodereviewServerConfigKey())
1851 if self._gerrit_server:
1852 self._gerrit_host = urlparse.urlparse(self._gerrit_server).netloc
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001853 if not self._gerrit_server:
1854 # We assume repo to be hosted on Gerrit, and hence Gerrit server
1855 # has "-review" suffix for lowest level subdomain.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001856 parts = self._GetGitHost().split('.')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001857 parts[0] = parts[0] + '-review'
1858 self._gerrit_host = '.'.join(parts)
1859 self._gerrit_server = 'https://%s' % self._gerrit_host
1860 return self._gerrit_server
1861
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001862 def _GetGerritProject(self):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001863 """Returns Gerrit project name based on remote git URL."""
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001864 remote_url = self.GetRemoteUrl()
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001865 if remote_url is None:
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001866 logging.warn('can\'t detect Gerrit project.')
1867 return None
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001868 project = urlparse.urlparse(remote_url).path.strip('/')
1869 if project.endswith('.git'):
1870 project = project[:-len('.git')]
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001871 # *.googlesource.com hosts ensure that Git/Gerrit projects don't start with
1872 # 'a/' prefix, because 'a/' prefix is used to force authentication in
1873 # gitiles/git-over-https protocol. E.g.,
1874 # https://chromium.googlesource.com/a/v8/v8 refers to the same repo/project
1875 # as
1876 # https://chromium.googlesource.com/v8/v8
1877 if project.startswith('a/'):
1878 project = project[len('a/'):]
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001879 return project
1880
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001881 def _GerritChangeIdentifier(self):
1882 """Handy method for gerrit_util.ChangeIdentifier for a given CL.
1883
1884 Not to be confused by value of "Change-Id:" footer.
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001885 If Gerrit project can be determined, this will speed up Gerrit HTTP API RPC.
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001886 """
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001887 project = self._GetGerritProject()
1888 if project:
1889 return gerrit_util.ChangeIdentifier(project, self.GetIssue())
1890 # Fall back on still unique, but less efficient change number.
1891 return str(self.GetIssue())
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001892
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001893 @classmethod
tandrii5d48c322016-08-18 16:19:37 -07001894 def IssueConfigKey(cls):
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001895 return 'gerritissue'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001896
tandrii5d48c322016-08-18 16:19:37 -07001897 @classmethod
1898 def PatchsetConfigKey(cls):
1899 return 'gerritpatchset'
1900
1901 @classmethod
1902 def CodereviewServerConfigKey(cls):
1903 return 'gerritserver'
1904
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001905 def EnsureAuthenticated(self, force, refresh=None):
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001906 """Best effort check that user is authenticated with Gerrit server."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001907 if settings.GetGerritSkipEnsureAuthenticated():
1908 # For projects with unusual authentication schemes.
1909 # See http://crbug.com/603378.
1910 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001911
1912 # Check presence of cookies only if using cookies-based auth method.
1913 cookie_auth = gerrit_util.Authenticator.get()
1914 if not isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001915 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001916
Daniel Chengcf6269b2019-05-18 01:02:12 +00001917 if urlparse.urlparse(self.GetRemoteUrl()).scheme != 'https':
1918 print('WARNING: Ignoring branch %s with non-https remote %s' %
1919 (self._changelist.branch, self.GetRemoteUrl()))
1920 return
1921
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001922 # Lazy-loader to identify Gerrit and Git hosts.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001923 self.GetCodereviewServer()
1924 git_host = self._GetGitHost()
Edward Lemur298f2cf2019-02-22 21:40:39 +00001925 assert self._gerrit_server and self._gerrit_host and git_host
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001926
1927 gerrit_auth = cookie_auth.get_auth_header(self._gerrit_host)
1928 git_auth = cookie_auth.get_auth_header(git_host)
1929 if gerrit_auth and git_auth:
1930 if gerrit_auth == git_auth:
1931 return
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001932 all_gsrc = cookie_auth.get_auth_header('d0esN0tEx1st.googlesource.com')
Raul Tambre80ee78e2019-05-06 22:41:05 +00001933 print(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001934 'WARNING: You have different credentials for Gerrit and git hosts:\n'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001935 ' %s\n'
1936 ' %s\n'
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001937 ' Consider running the following command:\n'
1938 ' git cl creds-check\n'
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001939 ' %s\n'
Raul Tambre80ee78e2019-05-06 22:41:05 +00001940 ' %s' %
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001941 (git_host, self._gerrit_host,
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001942 ('Hint: delete creds for .googlesource.com' if all_gsrc else ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001943 cookie_auth.get_new_password_message(git_host)))
1944 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001945 confirm_or_exit('If you know what you are doing', action='continue')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001946 return
1947 else:
1948 missing = (
Anna Henningsen4e891442017-07-06 21:40:58 +02001949 ([] if gerrit_auth else [self._gerrit_host]) +
1950 ([] if git_auth else [git_host]))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001951 DieWithError('Credentials for the following hosts are required:\n'
1952 ' %s\n'
1953 'These are read from %s (or legacy %s)\n'
1954 '%s' % (
1955 '\n '.join(missing),
1956 cookie_auth.get_gitcookies_path(),
1957 cookie_auth.get_netrc_path(),
1958 cookie_auth.get_new_password_message(git_host)))
1959
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001960 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001961 if not self.GetIssue():
1962 return
1963
1964 # Warm change details cache now to avoid RPCs later, reducing latency for
1965 # developers.
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001966 self._GetChangeDetail(
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +00001967 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS'])
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001968
1969 status = self._GetChangeDetail()['status']
1970 if status in ('MERGED', 'ABANDONED'):
1971 DieWithError('Change %s has been %s, new uploads are not allowed' %
1972 (self.GetIssueURL(),
1973 'submitted' if status == 'MERGED' else 'abandoned'))
1974
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001975 # TODO(vadimsh): For some reason the chunk of code below was skipped if
1976 # 'is_gce' is True. I'm just refactoring it to be 'skip if not cookies'.
1977 # Apparently this check is not very important? Otherwise get_auth_email
1978 # could have been added to other implementations of Authenticator.
1979 cookies_auth = gerrit_util.Authenticator.get()
1980 if not isinstance(cookies_auth, gerrit_util.CookiesAuthenticator):
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001981 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001982
1983 cookies_user = cookies_auth.get_auth_email(self._GetGerritHost())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001984 if self.GetIssueOwner() == cookies_user:
1985 return
1986 logging.debug('change %s owner is %s, cookies user is %s',
1987 self.GetIssue(), self.GetIssueOwner(), cookies_user)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001988 # Maybe user has linked accounts or something like that,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001989 # so ask what Gerrit thinks of this user.
1990 details = gerrit_util.GetAccountDetails(self._GetGerritHost(), 'self')
1991 if details['email'] == self.GetIssueOwner():
1992 return
1993 if not force:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001994 print('WARNING: Change %s is owned by %s, but you authenticate to Gerrit '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001995 'as %s.\n'
1996 'Uploading may fail due to lack of permissions.' %
1997 (self.GetIssue(), self.GetIssueOwner(), details['email']))
1998 confirm_or_exit(action='upload')
1999
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002000 def _PostUnsetIssueProperties(self):
2001 """Which branch-specific properties to erase when unsetting issue."""
tandrii5d48c322016-08-18 16:19:37 -07002002 return ['gerritsquashhash']
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002003
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00002004 def GetGerritObjForPresubmit(self):
2005 return presubmit_support.GerritAccessor(self._GetGerritHost())
2006
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002007 def GetStatus(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002008 """Applies a rough heuristic to give a simple summary of an issue's review
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002009 or CQ status, assuming adherence to a common workflow.
2010
2011 Returns None if no issue for this branch, or one of the following keywords:
Aaron Gable9ab38c62017-04-06 14:36:33 -07002012 * 'error' - error from review tool (including deleted issues)
2013 * 'unsent' - no reviewers added
2014 * 'waiting' - waiting for review
2015 * 'reply' - waiting for uploader to reply to review
2016 * 'lgtm' - Code-Review label has been set
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00002017 * 'dry-run' - dry-running in the CQ
2018 * 'commit' - in the CQ
Aaron Gable9ab38c62017-04-06 14:36:33 -07002019 * 'closed' - successfully submitted or abandoned
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002020 """
2021 if not self.GetIssue():
2022 return None
2023
2024 try:
Aaron Gable9ab38c62017-04-06 14:36:33 -07002025 data = self._GetChangeDetail([
2026 'DETAILED_LABELS', 'CURRENT_REVISION', 'SUBMITTABLE'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002027 except (httplib.HTTPException, GerritChangeNotExists):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002028 return 'error'
2029
tandrii@chromium.org5e1bf382016-05-17 08:43:24 +00002030 if data['status'] in ('ABANDONED', 'MERGED'):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002031 return 'closed'
2032
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00002033 cq_label = data['labels'].get('Commit-Queue', {})
2034 max_cq_vote = 0
2035 for vote in cq_label.get('all', []):
2036 max_cq_vote = max(max_cq_vote, vote.get('value', 0))
2037 if max_cq_vote == 2:
Aaron Gable9ab38c62017-04-06 14:36:33 -07002038 return 'commit'
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00002039 if max_cq_vote == 1:
2040 return 'dry-run'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002041
Aaron Gable9ab38c62017-04-06 14:36:33 -07002042 if data['labels'].get('Code-Review', {}).get('approved'):
2043 return 'lgtm'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002044
2045 if not data.get('reviewers', {}).get('REVIEWER', []):
2046 return 'unsent'
2047
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01002048 owner = data['owner'].get('_account_id')
Aaron Gable9ab38c62017-04-06 14:36:33 -07002049 messages = sorted(data.get('messages', []), key=lambda m: m.get('updated'))
2050 last_message_author = messages.pop().get('author', {})
2051 while last_message_author:
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01002052 if last_message_author.get('email') == COMMIT_BOT_EMAIL:
2053 # Ignore replies from CQ.
Aaron Gable9ab38c62017-04-06 14:36:33 -07002054 last_message_author = messages.pop().get('author', {})
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01002055 continue
Aaron Gable9ab38c62017-04-06 14:36:33 -07002056 if last_message_author.get('_account_id') == owner:
2057 # Most recent message was by owner.
2058 return 'waiting'
2059 else:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002060 # Some reply from non-owner.
2061 return 'reply'
Aaron Gable9ab38c62017-04-06 14:36:33 -07002062
2063 # Somehow there are no messages even though there are reviewers.
2064 return 'unsent'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002065
2066 def GetMostRecentPatchset(self):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002067 data = self._GetChangeDetail(['CURRENT_REVISION'])
Aaron Gablee8856ee2017-12-07 12:41:46 -08002068 patchset = data['revisions'][data['current_revision']]['_number']
2069 self.SetPatchset(patchset)
2070 return patchset
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002071
Kenneth Russell61e2ed42017-02-15 11:47:13 -08002072 def FetchDescription(self, force=False):
2073 data = self._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'],
2074 no_cache=force)
tandrii@chromium.org2d3da632016-04-25 19:23:27 +00002075 current_rev = data['current_revision']
Dan Beamcf6df902018-11-08 01:48:37 +00002076 return data['revisions'][current_rev]['commit']['message'].encode(
2077 'utf-8', 'ignore')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002078
dsansomee2d6fd92016-09-08 00:10:47 -07002079 def UpdateDescriptionRemote(self, description, force=False):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002080 if gerrit_util.HasPendingChangeEdit(
2081 self._GetGerritHost(), self._GerritChangeIdentifier()):
dsansomee2d6fd92016-09-08 00:10:47 -07002082 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002083 confirm_or_exit(
dsansomee2d6fd92016-09-08 00:10:47 -07002084 'The description cannot be modified while the issue has a pending '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002085 'unpublished edit. Either publish the edit in the Gerrit web UI '
2086 'or delete it.\n\n', action='delete the unpublished edit')
dsansomee2d6fd92016-09-08 00:10:47 -07002087
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002088 gerrit_util.DeletePendingChangeEdit(
2089 self._GetGerritHost(), self._GerritChangeIdentifier())
2090 gerrit_util.SetCommitMessage(
2091 self._GetGerritHost(), self._GerritChangeIdentifier(),
2092 description, notify='NONE')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002093
Aaron Gable636b13f2017-07-14 10:42:48 -07002094 def AddComment(self, message, publish=None):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002095 gerrit_util.SetReview(
2096 self._GetGerritHost(), self._GerritChangeIdentifier(),
2097 msg=message, ready=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002098
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002099 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002100 # DETAILED_ACCOUNTS is to get emails in accounts.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002101 # CURRENT_REVISION is included to get the latest patchset so that
2102 # only the robot comments from the latest patchset can be shown.
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002103 messages = self._GetChangeDetail(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002104 options=['MESSAGES', 'DETAILED_ACCOUNTS',
2105 'CURRENT_REVISION']).get('messages', [])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002106 file_comments = gerrit_util.GetChangeComments(
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002107 self._GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002108 robot_file_comments = gerrit_util.GetChangeRobotComments(
2109 self._GetGerritHost(), self._GerritChangeIdentifier())
2110
2111 # Add the robot comments onto the list of comments, but only
2112 # keep those that are from the latest pachset.
2113 latest_patch_set = self.GetMostRecentPatchset()
2114 for path, robot_comments in robot_file_comments.iteritems():
2115 line_comments = file_comments.setdefault(path, [])
2116 line_comments.extend(
2117 [c for c in robot_comments if c['patch_set'] == latest_patch_set])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002118
2119 # Build dictionary of file comments for easy access and sorting later.
2120 # {author+date: {path: {patchset: {line: url+message}}}}
2121 comments = collections.defaultdict(
2122 lambda: collections.defaultdict(lambda: collections.defaultdict(dict)))
2123 for path, line_comments in file_comments.iteritems():
2124 for comment in line_comments:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002125 tag = comment.get('tag', '')
2126 if tag.startswith('autogenerated') and 'robot_id' not in comment:
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002127 continue
2128 key = (comment['author']['email'], comment['updated'])
2129 if comment.get('side', 'REVISION') == 'PARENT':
2130 patchset = 'Base'
2131 else:
2132 patchset = 'PS%d' % comment['patch_set']
2133 line = comment.get('line', 0)
2134 url = ('https://%s/c/%s/%s/%s#%s%s' %
2135 (self._GetGerritHost(), self.GetIssue(), comment['patch_set'], path,
2136 'b' if comment.get('side') == 'PARENT' else '',
2137 str(line) if line else ''))
2138 comments[key][path][patchset][line] = (url, comment['message'])
2139
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002140 summaries = []
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002141 for msg in messages:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002142 summary = self._BuildCommentSummary(msg, comments, readable)
2143 if summary:
2144 summaries.append(summary)
2145 return summaries
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002146
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002147 @staticmethod
2148 def _BuildCommentSummary(msg, comments, readable):
2149 key = (msg['author']['email'], msg['date'])
2150 # Don't bother showing autogenerated messages that don't have associated
2151 # file or line comments. this will filter out most autogenerated
2152 # messages, but will keep robot comments like those from Tricium.
2153 is_autogenerated = msg.get('tag', '').startswith('autogenerated')
2154 if is_autogenerated and not comments.get(key):
2155 return None
2156 message = msg['message']
2157 # Gerrit spits out nanoseconds.
2158 assert len(msg['date'].split('.')[-1]) == 9
2159 date = datetime.datetime.strptime(msg['date'][:-3],
2160 '%Y-%m-%d %H:%M:%S.%f')
2161 if key in comments:
2162 message += '\n'
2163 for path, patchsets in sorted(comments.get(key, {}).items()):
2164 if readable:
2165 message += '\n%s' % path
2166 for patchset, lines in sorted(patchsets.items()):
2167 for line, (url, content) in sorted(lines.items()):
2168 if line:
2169 line_str = 'Line %d' % line
2170 path_str = '%s:%d:' % (path, line)
2171 else:
2172 line_str = 'File comment'
2173 path_str = '%s:0:' % path
2174 if readable:
2175 message += '\n %s, %s: %s' % (patchset, line_str, url)
2176 message += '\n %s\n' % content
2177 else:
2178 message += '\n%s ' % path_str
2179 message += '\n%s\n' % content
2180
2181 return _CommentSummary(
2182 date=date,
2183 message=message,
2184 sender=msg['author']['email'],
2185 autogenerated=is_autogenerated,
2186 # These could be inferred from the text messages and correlated with
2187 # Code-Review label maximum, however this is not reliable.
2188 # Leaving as is until the need arises.
2189 approval=False,
2190 disapproval=False,
2191 )
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01002192
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002193 def CloseIssue(self):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002194 gerrit_util.AbandonChange(
2195 self._GetGerritHost(), self._GerritChangeIdentifier(), msg='')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002196
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002197 def SubmitIssue(self, wait_for_merge=True):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002198 gerrit_util.SubmitChange(
2199 self._GetGerritHost(), self._GerritChangeIdentifier(),
2200 wait_for_merge=wait_for_merge)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002201
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002202 def _GetChangeDetail(self, options=None, no_cache=False):
2203 """Returns details of associated Gerrit change and caching results.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002204
2205 If fresh data is needed, set no_cache=True which will clear cache and
2206 thus new data will be fetched from Gerrit.
2207 """
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002208 options = options or []
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002209 assert self.GetIssue(), 'issue is required to query Gerrit'
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002210
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002211 # Optimization to avoid multiple RPCs:
2212 if (('CURRENT_REVISION' in options or 'ALL_REVISIONS' in options) and
2213 'CURRENT_COMMIT' not in options):
2214 options.append('CURRENT_COMMIT')
2215
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002216 # Normalize issue and options for consistent keys in cache.
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002217 cache_key = str(self.GetIssue())
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002218 options = [o.upper() for o in options]
2219
2220 # Check in cache first unless no_cache is True.
2221 if no_cache:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002222 self._detail_cache.pop(cache_key, None)
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002223 else:
2224 options_set = frozenset(options)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002225 for cached_options_set, data in self._detail_cache.get(cache_key, []):
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002226 # Assumption: data fetched before with extra options is suitable
2227 # for return for a smaller set of options.
2228 # For example, if we cached data for
2229 # options=[CURRENT_REVISION, DETAILED_FOOTERS]
2230 # and request is for options=[CURRENT_REVISION],
2231 # THEN we can return prior cached data.
2232 if options_set.issubset(cached_options_set):
2233 return data
2234
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002235 try:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002236 data = gerrit_util.GetChangeDetail(
2237 self._GetGerritHost(), self._GerritChangeIdentifier(), options)
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002238 except gerrit_util.GerritError as e:
2239 if e.http_status == 404:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002240 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002241 raise
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002242
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002243 self._detail_cache.setdefault(cache_key, []).append(
2244 (frozenset(options), data))
tandriic2405f52016-10-10 08:13:15 -07002245 return data
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002246
Andrii Shyshkalovcc5f17e2018-08-22 23:35:59 +00002247 def _GetChangeCommit(self):
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002248 assert self.GetIssue(), 'issue must be set to query Gerrit'
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002249 try:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002250 data = gerrit_util.GetChangeCommit(
2251 self._GetGerritHost(), self._GerritChangeIdentifier())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002252 except gerrit_util.GerritError as e:
2253 if e.http_status == 404:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002254 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002255 raise
agable32978d92016-11-01 12:55:02 -07002256 return data
2257
Karen Qian40c19422019-03-13 21:28:29 +00002258 def _IsCqConfigured(self):
2259 detail = self._GetChangeDetail(['LABELS'])
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002260 if u'Commit-Queue' not in detail.get('labels', {}):
Karen Qian40c19422019-03-13 21:28:29 +00002261 return False
2262 # TODO(crbug/753213): Remove temporary hack
2263 if ('https://chromium.googlesource.com/chromium/src' ==
2264 self._changelist.GetRemoteUrl() and
2265 detail['branch'].startswith('refs/branch-heads/')):
2266 return False
2267 return True
2268
Olivier Robin75ee7252018-04-13 10:02:56 +02002269 def CMDLand(self, force, bypass_hooks, verbose, parallel):
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002270 if git_common.is_dirty_git_tree('land'):
2271 return 1
Karen Qian40c19422019-03-13 21:28:29 +00002272
tandriid60367b2016-06-22 05:25:12 -07002273 detail = self._GetChangeDetail(['CURRENT_REVISION', 'LABELS'])
Karen Qian40c19422019-03-13 21:28:29 +00002274 if not force and self._IsCqConfigured():
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00002275 confirm_or_exit('\nIt seems this repository has a CQ, '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002276 'which can test and land changes for you. '
2277 'Are you sure you wish to bypass it?\n',
2278 action='bypass CQ')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002279 differs = True
tandriic4344b52016-08-29 06:04:54 -07002280 last_upload = self._GitGetBranchConfigValue('gerritsquashhash')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002281 # Note: git diff outputs nothing if there is no diff.
2282 if not last_upload or RunGit(['diff', last_upload]).strip():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002283 print('WARNING: Some changes from local branch haven\'t been uploaded.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002284 else:
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002285 if detail['current_revision'] == last_upload:
2286 differs = False
2287 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002288 print('WARNING: Local branch contents differ from latest uploaded '
2289 'patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002290 if differs:
2291 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002292 confirm_or_exit(
2293 'Do you want to submit latest Gerrit patchset and bypass hooks?\n',
2294 action='submit')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002295 print('WARNING: Bypassing hooks and submitting latest uploaded patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002296 elif not bypass_hooks:
2297 hook_results = self.RunHook(
2298 committing=True,
2299 may_prompt=not force,
2300 verbose=verbose,
Olivier Robin75ee7252018-04-13 10:02:56 +02002301 change=self.GetChange(self.GetCommonAncestorWithUpstream(), None),
2302 parallel=parallel)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002303 if not hook_results.should_continue():
2304 return 1
2305
2306 self.SubmitIssue(wait_for_merge=True)
2307 print('Issue %s has been submitted.' % self.GetIssueURL())
agable32978d92016-11-01 12:55:02 -07002308 links = self._GetChangeCommit().get('web_links', [])
2309 for link in links:
Aaron Gable02cdbb42016-12-13 16:24:25 -08002310 if link.get('name') == 'gitiles' and link.get('url'):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002311 print('Landed as: %s' % link.get('url'))
agable32978d92016-11-01 12:55:02 -07002312 break
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002313 return 0
2314
Edward Lemurf38bc172019-09-03 21:02:13 +00002315 def CMDPatchWithParsedIssue(self, parsed_issue_arg, nocommit, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002316 assert parsed_issue_arg.valid
2317
2318 self._changelist.issue = parsed_issue_arg.issue
2319
2320 if parsed_issue_arg.hostname:
2321 self._gerrit_host = parsed_issue_arg.hostname
2322 self._gerrit_server = 'https://%s' % self._gerrit_host
2323
tandriic2405f52016-10-10 08:13:15 -07002324 try:
2325 detail = self._GetChangeDetail(['ALL_REVISIONS'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002326 except GerritChangeNotExists as e:
tandriic2405f52016-10-10 08:13:15 -07002327 DieWithError(str(e))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002328
2329 if not parsed_issue_arg.patchset:
2330 # Use current revision by default.
2331 revision_info = detail['revisions'][detail['current_revision']]
2332 patchset = int(revision_info['_number'])
2333 else:
2334 patchset = parsed_issue_arg.patchset
2335 for revision_info in detail['revisions'].itervalues():
2336 if int(revision_info['_number']) == parsed_issue_arg.patchset:
2337 break
2338 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08002339 DieWithError('Couldn\'t find patchset %i in change %i' %
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002340 (parsed_issue_arg.patchset, self.GetIssue()))
2341
Aaron Gable697a91b2018-01-19 15:20:15 -08002342 remote_url = self._changelist.GetRemoteUrl()
2343 if remote_url.endswith('.git'):
2344 remote_url = remote_url[:-len('.git')]
erikchen0d14d0d2018-08-28 18:57:09 +00002345 remote_url = remote_url.rstrip('/')
2346
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002347 fetch_info = revision_info['fetch']['http']
erikchen0d14d0d2018-08-28 18:57:09 +00002348 fetch_info['url'] = fetch_info['url'].rstrip('/')
Aaron Gable697a91b2018-01-19 15:20:15 -08002349
2350 if remote_url != fetch_info['url']:
2351 DieWithError('Trying to patch a change from %s but this repo appears '
2352 'to be %s.' % (fetch_info['url'], remote_url))
2353
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002354 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
Aaron Gable9387b4f2017-06-08 10:50:03 -07002355
Aaron Gable62619a32017-06-16 08:22:09 -07002356 if force:
2357 RunGit(['reset', '--hard', 'FETCH_HEAD'])
2358 print('Checked out commit for change %i patchset %i locally' %
2359 (parsed_issue_arg.issue, patchset))
Stefan Zager2d5f0392017-10-10 15:17:53 -07002360 elif nocommit:
2361 RunGit(['cherry-pick', '--no-commit', 'FETCH_HEAD'])
2362 print('Patch applied to index.')
Aaron Gable62619a32017-06-16 08:22:09 -07002363 else:
Aaron Gable9387b4f2017-06-08 10:50:03 -07002364 RunGit(['cherry-pick', 'FETCH_HEAD'])
2365 print('Committed patch for change %i patchset %i locally.' %
Aaron Gable62619a32017-06-16 08:22:09 -07002366 (parsed_issue_arg.issue, patchset))
2367 print('Note: this created a local commit which does not have '
2368 'the same hash as the one uploaded for review. This will make '
2369 'uploading changes based on top of this branch difficult.\n'
2370 'If you want to do that, use "git cl patch --force" instead.')
2371
Stefan Zagerd08043c2017-10-12 12:07:02 -07002372 if self.GetBranch():
2373 self.SetIssue(parsed_issue_arg.issue)
2374 self.SetPatchset(patchset)
2375 fetched_hash = RunGit(['rev-parse', 'FETCH_HEAD']).strip()
2376 self._GitSetBranchConfigValue('last-upload-hash', fetched_hash)
2377 self._GitSetBranchConfigValue('gerritsquashhash', fetched_hash)
2378 else:
2379 print('WARNING: You are in detached HEAD state.\n'
2380 'The patch has been applied to your checkout, but you will not be '
2381 'able to upload a new patch set to the gerrit issue.\n'
2382 'Try using the \'-b\' option if you would like to work on a '
2383 'branch and/or upload a new patch set.')
2384
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002385 return 0
2386
2387 @staticmethod
2388 def ParseIssueURL(parsed_url):
2389 if not parsed_url.scheme or not parsed_url.scheme.startswith('http'):
2390 return None
Aaron Gable01b91062017-08-24 17:48:40 -07002391 # Gerrit's new UI is https://domain/c/project/+/<issue_number>[/[patchset]]
2392 # But old GWT UI is https://domain/#/c/project/+/<issue_number>[/[patchset]]
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002393 # Short urls like https://domain/<issue_number> can be used, but don't allow
2394 # specifying the patchset (you'd 404), but we allow that here.
2395 if parsed_url.path == '/':
2396 part = parsed_url.fragment
2397 else:
2398 part = parsed_url.path
Bruce Dawson9c062012019-05-02 19:20:28 +00002399 match = re.match(r'(/c(/.*/\+)?)?/(\d+)(/(\d+)?/?)?$', part)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002400 if match:
2401 return _ParsedIssueNumberArgument(
Aaron Gable01b91062017-08-24 17:48:40 -07002402 issue=int(match.group(3)),
2403 patchset=int(match.group(5)) if match.group(5) else None,
Edward Lemurf38bc172019-09-03 21:02:13 +00002404 hostname=parsed_url.netloc)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002405 return None
2406
tandrii16e0b4e2016-06-07 10:34:28 -07002407 def _GerritCommitMsgHookCheck(self, offer_removal):
2408 hook = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
2409 if not os.path.exists(hook):
2410 return
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002411 # Crude attempt to distinguish Gerrit Codereview hook from a potentially
2412 # custom developer-made one.
tandrii16e0b4e2016-06-07 10:34:28 -07002413 data = gclient_utils.FileRead(hook)
2414 if not('From Gerrit Code Review' in data and 'add_ChangeId()' in data):
2415 return
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002416 print('WARNING: You have Gerrit commit-msg hook installed.\n'
qyearsley12fa6ff2016-08-24 09:18:40 -07002417 'It is not necessary for uploading with git cl in squash mode, '
tandrii16e0b4e2016-06-07 10:34:28 -07002418 'and may interfere with it in subtle ways.\n'
2419 'We recommend you remove the commit-msg hook.')
2420 if offer_removal:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002421 if ask_for_explicit_yes('Do you want to remove it now?'):
tandrii16e0b4e2016-06-07 10:34:28 -07002422 gclient_utils.rm_file_or_tree(hook)
2423 print('Gerrit commit-msg hook removed.')
2424 else:
2425 print('OK, will keep Gerrit commit-msg hook in place.')
2426
Edward Lemur1b52d872019-05-09 21:12:12 +00002427 def _CleanUpOldTraces(self):
2428 """Keep only the last |MAX_TRACES| traces."""
2429 try:
2430 traces = sorted([
2431 os.path.join(TRACES_DIR, f)
2432 for f in os.listdir(TRACES_DIR)
2433 if (os.path.isfile(os.path.join(TRACES_DIR, f))
2434 and not f.startswith('tmp'))
2435 ])
2436 traces_to_delete = traces[:-MAX_TRACES]
2437 for trace in traces_to_delete:
Daniel Chengcf6269b2019-05-18 01:02:12 +00002438 os.remove(trace)
Edward Lemur1b52d872019-05-09 21:12:12 +00002439 except OSError:
2440 print('WARNING: Failed to remove old git traces from\n'
2441 ' %s'
2442 'Consider removing them manually.' % TRACES_DIR)
Edward Lemurdc8e23d2019-05-07 00:45:48 +00002443
Edward Lemur5737f022019-05-17 01:24:00 +00002444 def _WriteGitPushTraces(self, trace_name, traces_dir, git_push_metadata):
Edward Lemur1b52d872019-05-09 21:12:12 +00002445 """Zip and write the git push traces stored in traces_dir."""
2446 gclient_utils.safe_makedirs(TRACES_DIR)
Edward Lemur1b52d872019-05-09 21:12:12 +00002447 traces_zip = trace_name + '-traces'
2448 traces_readme = trace_name + '-README'
Michael Mosse7f0b4c2019-05-08 04:36:24 +00002449 # Create a temporary dir to store git config and gitcookies in. It will be
2450 # compressed and stored next to the traces.
2451 git_info_dir = tempfile.mkdtemp()
Edward Lemur1b52d872019-05-09 21:12:12 +00002452 git_info_zip = trace_name + '-git-info'
2453
Edward Lemur5737f022019-05-17 01:24:00 +00002454 git_push_metadata['now'] = datetime_now().strftime('%c')
Eric Boren67c48202019-05-30 16:52:51 +00002455 if sys.stdin.encoding and sys.stdin.encoding != 'utf-8':
sangwoo.ko7a614332019-05-22 02:46:19 +00002456 git_push_metadata['now'] = git_push_metadata['now'].decode(
2457 sys.stdin.encoding)
2458
Edward Lemur1b52d872019-05-09 21:12:12 +00002459 git_push_metadata['trace_name'] = trace_name
2460 gclient_utils.FileWrite(
2461 traces_readme, TRACES_README_FORMAT % git_push_metadata)
2462
2463 # Keep only the first 6 characters of the git hashes on the packet
2464 # trace. This greatly decreases size after compression.
2465 packet_traces = os.path.join(traces_dir, 'trace-packet')
2466 if os.path.isfile(packet_traces):
2467 contents = gclient_utils.FileRead(packet_traces)
2468 gclient_utils.FileWrite(
2469 packet_traces, GIT_HASH_RE.sub(r'\1', contents))
2470 shutil.make_archive(traces_zip, 'zip', traces_dir)
2471
2472 # Collect and compress the git config and gitcookies.
2473 git_config = RunGit(['config', '-l'])
2474 gclient_utils.FileWrite(
2475 os.path.join(git_info_dir, 'git-config'),
2476 git_config)
2477
2478 cookie_auth = gerrit_util.Authenticator.get()
2479 if isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
2480 gitcookies_path = cookie_auth.get_gitcookies_path()
2481 if os.path.isfile(gitcookies_path):
2482 gitcookies = gclient_utils.FileRead(gitcookies_path)
2483 gclient_utils.FileWrite(
2484 os.path.join(git_info_dir, 'gitcookies'),
2485 GITCOOKIES_REDACT_RE.sub('REDACTED', gitcookies))
2486 shutil.make_archive(git_info_zip, 'zip', git_info_dir)
2487
Edward Lemur1b52d872019-05-09 21:12:12 +00002488 gclient_utils.rmtree(git_info_dir)
2489
2490 def _RunGitPushWithTraces(
2491 self, change_desc, refspec, refspec_opts, git_push_metadata):
2492 """Run git push and collect the traces resulting from the execution."""
2493 # Create a temporary directory to store traces in. Traces will be compressed
2494 # and stored in a 'traces' dir inside depot_tools.
2495 traces_dir = tempfile.mkdtemp()
Edward Lemur5737f022019-05-17 01:24:00 +00002496 trace_name = os.path.join(
2497 TRACES_DIR, datetime_now().strftime('%Y%m%dT%H%M%S.%f'))
Edward Lemur0f58ae42019-04-30 17:24:12 +00002498
2499 env = os.environ.copy()
2500 env['GIT_REDACT_COOKIES'] = 'o,SSO,GSSO_Uberproxy'
2501 env['GIT_TR2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Jonathan Nieder9779b142019-05-29 23:19:29 +00002502 env['GIT_TRACE2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002503 env['GIT_TRACE_CURL'] = os.path.join(traces_dir, 'trace-curl')
2504 env['GIT_TRACE_CURL_NO_DATA'] = '1'
2505 env['GIT_TRACE_PACKET'] = os.path.join(traces_dir, 'trace-packet')
2506
2507 try:
2508 push_returncode = 0
Edward Lemur1b52d872019-05-09 21:12:12 +00002509 remote_url = self.GetRemoteUrl()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002510 before_push = time_time()
2511 push_stdout = gclient_utils.CheckCallAndFilter(
Edward Lemur1b52d872019-05-09 21:12:12 +00002512 ['git', 'push', remote_url, refspec],
Edward Lemur0f58ae42019-04-30 17:24:12 +00002513 env=env,
2514 print_stdout=True,
2515 # Flush after every line: useful for seeing progress when running as
2516 # recipe.
2517 filter_fn=lambda _: sys.stdout.flush())
2518 except subprocess2.CalledProcessError as e:
2519 push_returncode = e.returncode
2520 DieWithError('Failed to create a change. Please examine output above '
2521 'for the reason of the failure.\n'
2522 'Hint: run command below to diagnose common Git/Gerrit '
2523 'credential problems:\n'
Edward Lemur5737f022019-05-17 01:24:00 +00002524 ' git cl creds-check\n'
2525 '\n'
2526 'If git-cl is not working correctly, file a bug under the '
2527 'Infra>SDK component including the files below.\n'
2528 'Review the files before upload, since they might contain '
2529 'sensitive information.\n'
2530 'Set the Restrict-View-Google label so that they are not '
2531 'publicly accessible.\n'
2532 + TRACES_MESSAGE % {'trace_name': trace_name},
Edward Lemur0f58ae42019-04-30 17:24:12 +00002533 change_desc)
2534 finally:
2535 execution_time = time_time() - before_push
2536 metrics.collector.add_repeated('sub_commands', {
2537 'command': 'git push',
2538 'execution_time': execution_time,
2539 'exit_code': push_returncode,
2540 'arguments': metrics_utils.extract_known_subcommand_args(refspec_opts),
2541 })
2542
Edward Lemur1b52d872019-05-09 21:12:12 +00002543 git_push_metadata['execution_time'] = execution_time
2544 git_push_metadata['exit_code'] = push_returncode
Edward Lemur5737f022019-05-17 01:24:00 +00002545 self._WriteGitPushTraces(trace_name, traces_dir, git_push_metadata)
Edward Lemur0f58ae42019-04-30 17:24:12 +00002546
Edward Lemur1b52d872019-05-09 21:12:12 +00002547 self._CleanUpOldTraces()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002548 gclient_utils.rmtree(traces_dir)
2549
2550 return push_stdout
2551
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002552 def CMDUploadChange(self, options, git_diff_args, custom_cl_base, change):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002553 """Upload the current branch to Gerrit."""
Mike Frysingera989d552019-08-14 20:51:23 +00002554 if options.squash is None:
tandriia60502f2016-06-20 02:01:53 -07002555 # Load default for user, repo, squash=true, in this order.
2556 options.squash = settings.GetSquashGerritUploads()
tandrii26f3e4e2016-06-10 08:37:04 -07002557
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002558 remote, remote_branch = self.GetRemoteBranch()
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01002559 branch = GetTargetRef(remote, remote_branch, options.target_branch)
Aaron Gableb56ad332017-01-06 15:24:31 -08002560 # This may be None; default fallback value is determined in logic below.
2561 title = options.title
2562
Dominic Battre7d1c4842017-10-27 09:17:28 +02002563 # Extract bug number from branch name.
2564 bug = options.bug
2565 match = re.match(r'(?:bug|fix)[_-]?(\d+)', self.GetBranch())
2566 if not bug and match:
2567 bug = match.group(1)
2568
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002569 if options.squash:
tandrii16e0b4e2016-06-07 10:34:28 -07002570 self._GerritCommitMsgHookCheck(offer_removal=not options.force)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002571 if self.GetIssue():
2572 # Try to get the message from a previous upload.
2573 message = self.GetDescription()
2574 if not message:
2575 DieWithError(
Aaron Gablea45ee112016-11-22 15:14:38 -08002576 'failed to fetch description from current Gerrit change %d\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002577 '%s' % (self.GetIssue(), self.GetIssueURL()))
Aaron Gableb56ad332017-01-06 15:24:31 -08002578 if not title:
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002579 if options.message:
Aaron Gable7303dcb2017-06-07 14:17:32 -07002580 # When uploading a subsequent patchset, -m|--message is taken
2581 # as the patchset title if --title was not provided.
2582 title = options.message.strip()
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002583 else:
2584 default_title = RunGit(
2585 ['show', '-s', '--format=%s', 'HEAD']).strip()
Aaron Gable7303dcb2017-06-07 14:17:32 -07002586 if options.force:
2587 title = default_title
2588 else:
2589 title = ask_for_data(
2590 'Title for patchset [%s]: ' % default_title) or default_title
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002591 change_id = self._GetChangeDetail()['change_id']
2592 while True:
2593 footer_change_ids = git_footers.get_footer_change_id(message)
2594 if footer_change_ids == [change_id]:
2595 break
2596 if not footer_change_ids:
2597 message = git_footers.add_footer_change_id(message, change_id)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002598 print('WARNING: appended missing Change-Id to change description.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002599 continue
2600 # There is already a valid footer but with different or several ids.
2601 # Doing this automatically is non-trivial as we don't want to lose
2602 # existing other footers, yet we want to append just 1 desired
2603 # Change-Id. Thus, just create a new footer, but let user verify the
2604 # new description.
2605 message = '%s\n\nChange-Id: %s' % (message, change_id)
2606 print(
Aaron Gablea45ee112016-11-22 15:14:38 -08002607 'WARNING: change %s has Change-Id footer(s):\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002608 ' %s\n'
Aaron Gablea45ee112016-11-22 15:14:38 -08002609 'but change has Change-Id %s, according to Gerrit.\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002610 'Please, check the proposed correction to the description, '
2611 'and edit it if necessary but keep the "Change-Id: %s" footer\n'
2612 % (self.GetIssue(), '\n '.join(footer_change_ids), change_id,
2613 change_id))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002614 confirm_or_exit(action='edit')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002615 if not options.force:
2616 change_desc = ChangeDescription(message)
Dominic Battre7d1c4842017-10-27 09:17:28 +02002617 change_desc.prompt(bug=bug)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002618 message = change_desc.description
2619 if not message:
2620 DieWithError("Description is empty. Aborting...")
2621 # Continue the while loop.
2622 # Sanity check of this code - we should end up with proper message
2623 # footer.
2624 assert [change_id] == git_footers.get_footer_change_id(message)
2625 change_desc = ChangeDescription(message)
Aaron Gableb56ad332017-01-06 15:24:31 -08002626 else: # if not self.GetIssue()
2627 if options.message:
2628 message = options.message
2629 else:
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002630 message = _create_description_from_log(git_diff_args)
Aaron Gableb56ad332017-01-06 15:24:31 -08002631 if options.title:
2632 message = options.title + '\n\n' + message
2633 change_desc = ChangeDescription(message)
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002634
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002635 if not options.force:
Dominic Battre7d1c4842017-10-27 09:17:28 +02002636 change_desc.prompt(bug=bug)
Aaron Gableb56ad332017-01-06 15:24:31 -08002637 # On first upload, patchset title is always this string, while
2638 # --title flag gets converted to first line of message.
2639 title = 'Initial upload'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002640 if not change_desc.description:
2641 DieWithError("Description is empty. Aborting...")
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002642 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002643 if len(change_ids) > 1:
2644 DieWithError('too many Change-Id footers, at most 1 allowed.')
2645 if not change_ids:
2646 # Generate the Change-Id automatically.
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002647 change_desc.set_description(git_footers.add_footer_change_id(
2648 change_desc.description,
2649 GenerateGerritChangeId(change_desc.description)))
2650 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002651 assert len(change_ids) == 1
2652 change_id = change_ids[0]
2653
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002654 if options.reviewers or options.tbrs or options.add_owners_to:
2655 change_desc.update_reviewers(options.reviewers, options.tbrs,
2656 options.add_owners_to, change)
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002657 if options.preserve_tryjobs:
2658 change_desc.set_preserve_tryjobs()
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002659
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002660 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002661 parent = self._ComputeParent(remote, upstream_branch, custom_cl_base,
2662 options.force, change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002663 tree = RunGit(['rev-parse', 'HEAD:']).strip()
Aaron Gable9a03ae02017-11-03 11:31:07 -07002664 with tempfile.NamedTemporaryFile(delete=False) as desc_tempfile:
2665 desc_tempfile.write(change_desc.description)
2666 desc_tempfile.close()
2667 ref_to_push = RunGit(['commit-tree', tree, '-p', parent,
2668 '-F', desc_tempfile.name]).strip()
2669 os.remove(desc_tempfile.name)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002670 else:
2671 change_desc = ChangeDescription(
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002672 options.message or _create_description_from_log(git_diff_args))
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002673 if not change_desc.description:
2674 DieWithError("Description is empty. Aborting...")
2675
2676 if not git_footers.get_footer_change_id(change_desc.description):
2677 DownloadGerritHook(False)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002678 change_desc.set_description(
2679 self._AddChangeIdToCommitMessage(options, git_diff_args))
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002680 if options.reviewers or options.tbrs or options.add_owners_to:
2681 change_desc.update_reviewers(options.reviewers, options.tbrs,
2682 options.add_owners_to, change)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002683 ref_to_push = 'HEAD'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002684 # For no-squash mode, we assume the remote called "origin" is the one we
2685 # want. It is not worthwhile to support different workflows for
2686 # no-squash mode.
2687 parent = 'origin/%s' % branch
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002688 change_id = git_footers.get_footer_change_id(change_desc.description)[0]
2689
2690 assert change_desc
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00002691 SaveDescriptionBackup(change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002692 commits = RunGitSilent(['rev-list', '%s..%s' % (parent,
2693 ref_to_push)]).splitlines()
2694 if len(commits) > 1:
2695 print('WARNING: This will upload %d commits. Run the following command '
2696 'to see which commits will be uploaded: ' % len(commits))
2697 print('git log %s..%s' % (parent, ref_to_push))
2698 print('You can also use `git squash-branch` to squash these into a '
2699 'single commit.')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002700 confirm_or_exit(action='upload')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002701
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002702 if options.reviewers or options.tbrs or options.add_owners_to:
2703 change_desc.update_reviewers(options.reviewers, options.tbrs,
2704 options.add_owners_to, change)
2705
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002706 reviewers = sorted(change_desc.get_reviewers())
2707 # Add cc's from the CC_LIST and --cc flag (if any).
2708 if not options.private and not options.no_autocc:
2709 cc = self.GetCCList().split(',')
2710 else:
2711 cc = []
2712 if options.cc:
2713 cc.extend(options.cc)
2714 cc = filter(None, [email.strip() for email in cc])
2715 if change_desc.get_cced():
2716 cc.extend(change_desc.get_cced())
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00002717 if self._GetGerritHost() == 'chromium-review.googlesource.com':
2718 valid_accounts = set(reviewers + cc)
2719 # TODO(crbug/877717): relax this for all hosts.
2720 else:
2721 valid_accounts = gerrit_util.ValidAccounts(
2722 self._GetGerritHost(), reviewers + cc)
Andrii Shyshkalovf170af42018-10-30 07:00:44 +00002723 logging.info('accounts %s are recognized, %s invalid',
2724 sorted(valid_accounts),
2725 set(reviewers + cc).difference(set(valid_accounts)))
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002726
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002727 # Extra options that can be specified at push time. Doc:
2728 # https://gerrit-review.googlesource.com/Documentation/user-upload.html
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002729 refspec_opts = []
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002730
Aaron Gable844cf292017-06-28 11:32:59 -07002731 # By default, new changes are started in WIP mode, and subsequent patchsets
2732 # don't send email. At any time, passing --send-mail will mark the change
2733 # ready and send email for that particular patch.
Aaron Gableafd52772017-06-27 16:40:10 -07002734 if options.send_mail:
2735 refspec_opts.append('ready')
Aaron Gable844cf292017-06-28 11:32:59 -07002736 refspec_opts.append('notify=ALL')
Jamie Madill276da0b2018-04-27 14:41:20 -04002737 elif not self.GetIssue() and options.squash:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002738 refspec_opts.append('wip')
Aaron Gableafd52772017-06-27 16:40:10 -07002739 else:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002740 refspec_opts.append('notify=NONE')
Aaron Gable70f4e242017-06-26 10:45:59 -07002741
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002742 # TODO(tandrii): options.message should be posted as a comment
Aaron Gablee5adf612017-07-14 10:43:58 -07002743 # if --send-mail is set on non-initial upload as Rietveld used to do it.
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002744
Aaron Gable9b713dd2016-12-14 16:04:21 -08002745 if title:
Nick Carter8692b182017-11-06 16:30:38 -08002746 # Punctuation and whitespace in |title| must be percent-encoded.
2747 refspec_opts.append('m=' + gerrit_util.PercentEncodeForGitRef(title))
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002748
agablec6787972016-09-09 16:13:34 -07002749 if options.private:
Aaron Gableb02daf02017-05-23 11:53:46 -07002750 refspec_opts.append('private')
agablec6787972016-09-09 16:13:34 -07002751
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002752 for r in sorted(reviewers):
2753 if r in valid_accounts:
2754 refspec_opts.append('r=%s' % r)
2755 reviewers.remove(r)
2756 else:
2757 # TODO(tandrii): this should probably be a hard failure.
2758 print('WARNING: reviewer %s doesn\'t have a Gerrit account, skipping'
2759 % r)
2760 for c in sorted(cc):
2761 # refspec option will be rejected if cc doesn't correspond to an
2762 # account, even though REST call to add such arbitrary cc may succeed.
2763 if c in valid_accounts:
2764 refspec_opts.append('cc=%s' % c)
2765 cc.remove(c)
2766
rmistry9eadede2016-09-19 11:22:43 -07002767 if options.topic:
2768 # Documentation on Gerrit topics is here:
2769 # https://gerrit-review.googlesource.com/Documentation/user-upload.html#topic
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002770 refspec_opts.append('topic=%s' % options.topic)
rmistry9eadede2016-09-19 11:22:43 -07002771
Edward Lemur687ca902018-12-05 02:30:30 +00002772 if options.enable_auto_submit:
2773 refspec_opts.append('l=Auto-Submit+1')
2774 if options.use_commit_queue:
2775 refspec_opts.append('l=Commit-Queue+2')
2776 elif options.cq_dry_run:
2777 refspec_opts.append('l=Commit-Queue+1')
2778
2779 if change_desc.get_reviewers(tbr_only=True):
2780 score = gerrit_util.GetCodeReviewTbrScore(
2781 self._GetGerritHost(),
2782 self._GetGerritProject())
2783 refspec_opts.append('l=Code-Review+%s' % score)
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00002784
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002785 # Gerrit sorts hashtags, so order is not important.
Nodir Turakulov23b82142017-11-16 11:04:25 -08002786 hashtags = {change_desc.sanitize_hash_tag(t) for t in options.hashtags}
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002787 if not self.GetIssue():
Nodir Turakulov23b82142017-11-16 11:04:25 -08002788 hashtags.update(change_desc.get_hash_tags())
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002789 refspec_opts += ['hashtag=%s' % t for t in sorted(hashtags)]
2790
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002791 refspec_suffix = ''
2792 if refspec_opts:
2793 refspec_suffix = '%' + ','.join(refspec_opts)
2794 assert ' ' not in refspec_suffix, (
2795 'spaces not allowed in refspec: "%s"' % refspec_suffix)
2796 refspec = '%s:refs/for/%s%s' % (ref_to_push, branch, refspec_suffix)
2797
Edward Lemur1b52d872019-05-09 21:12:12 +00002798 git_push_metadata = {
2799 'gerrit_host': self._GetGerritHost(),
2800 'title': title or '<untitled>',
2801 'change_id': change_id,
2802 'description': change_desc.description,
2803 }
2804 push_stdout = self._RunGitPushWithTraces(
2805 change_desc, refspec, refspec_opts, git_push_metadata)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002806
2807 if options.squash:
Aaron Gable289b4312017-09-13 14:06:16 -07002808 regex = re.compile(r'remote:\s+https?://[\w\-\.\+\/#]*/(\d+)\s.*')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002809 change_numbers = [m.group(1)
2810 for m in map(regex.match, push_stdout.splitlines())
2811 if m]
2812 if len(change_numbers) != 1:
2813 DieWithError(
2814 ('Created|Updated %d issues on Gerrit, but only 1 expected.\n'
Christopher Lamf732cd52017-01-24 12:40:11 +11002815 'Change-Id: %s') % (len(change_numbers), change_id), change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002816 self.SetIssue(change_numbers[0])
tandrii5d48c322016-08-18 16:19:37 -07002817 self._GitSetBranchConfigValue('gerritsquashhash', ref_to_push)
tandrii88189772016-09-29 04:29:57 -07002818
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002819 if self.GetIssue() and (reviewers or cc):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002820 # GetIssue() is not set in case of non-squash uploads according to tests.
2821 # TODO(agable): non-squash uploads in git cl should be removed.
2822 gerrit_util.AddReviewers(
2823 self._GetGerritHost(),
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00002824 self._GerritChangeIdentifier(),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002825 reviewers, cc,
2826 notify=bool(options.send_mail))
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002827
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002828 return 0
2829
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002830 def _ComputeParent(self, remote, upstream_branch, custom_cl_base, force,
2831 change_desc):
2832 """Computes parent of the generated commit to be uploaded to Gerrit.
2833
2834 Returns revision or a ref name.
2835 """
2836 if custom_cl_base:
2837 # Try to avoid creating additional unintended CLs when uploading, unless
2838 # user wants to take this risk.
2839 local_ref_of_target_remote = self.GetRemoteBranch()[1]
2840 code, _ = RunGitWithCode(['merge-base', '--is-ancestor', custom_cl_base,
2841 local_ref_of_target_remote])
2842 if code == 1:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002843 print('\nWARNING: Manually specified base of this CL `%s` '
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002844 'doesn\'t seem to belong to target remote branch `%s`.\n\n'
2845 'If you proceed with upload, more than 1 CL may be created by '
2846 'Gerrit as a result, in turn confusing or crashing git cl.\n\n'
2847 'If you are certain that specified base `%s` has already been '
2848 'uploaded to Gerrit as another CL, you may proceed.\n' %
2849 (custom_cl_base, local_ref_of_target_remote, custom_cl_base))
2850 if not force:
2851 confirm_or_exit(
2852 'Do you take responsibility for cleaning up potential mess '
2853 'resulting from proceeding with upload?',
2854 action='upload')
2855 return custom_cl_base
2856
Aaron Gablef97e33d2017-03-30 15:44:27 -07002857 if remote != '.':
2858 return self.GetCommonAncestorWithUpstream()
2859
2860 # If our upstream branch is local, we base our squashed commit on its
2861 # squashed version.
2862 upstream_branch_name = scm.GIT.ShortBranchName(upstream_branch)
2863
Aaron Gablef97e33d2017-03-30 15:44:27 -07002864 if upstream_branch_name == 'master':
Aaron Gable0bbd1c22017-05-08 14:37:08 -07002865 return self.GetCommonAncestorWithUpstream()
Aaron Gablef97e33d2017-03-30 15:44:27 -07002866
2867 # Check the squashed hash of the parent.
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002868 # TODO(tandrii): consider checking parent change in Gerrit and using its
2869 # hash if tree hash of latest parent revision (patchset) in Gerrit matches
2870 # the tree hash of the parent branch. The upside is less likely bogus
2871 # requests to reupload parent change just because it's uploadhash is
2872 # missing, yet the downside likely exists, too (albeit unknown to me yet).
Aaron Gablef97e33d2017-03-30 15:44:27 -07002873 parent = RunGit(['config',
2874 'branch.%s.gerritsquashhash' % upstream_branch_name],
2875 error_ok=True).strip()
2876 # Verify that the upstream branch has been uploaded too, otherwise
2877 # Gerrit will create additional CLs when uploading.
2878 if not parent or (RunGitSilent(['rev-parse', upstream_branch + ':']) !=
2879 RunGitSilent(['rev-parse', parent + ':'])):
2880 DieWithError(
2881 '\nUpload upstream branch %s first.\n'
2882 'It is likely that this branch has been rebased since its last '
2883 'upload, so you just need to upload it again.\n'
2884 '(If you uploaded it with --no-squash, then branch dependencies '
2885 'are not supported, and you should reupload with --squash.)'
2886 % upstream_branch_name,
2887 change_desc)
2888 return parent
2889
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002890 def _AddChangeIdToCommitMessage(self, options, args):
2891 """Re-commits using the current message, assumes the commit hook is in
2892 place.
2893 """
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002894 log_desc = options.message or _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002895 git_command = ['commit', '--amend', '-m', log_desc]
2896 RunGit(git_command)
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002897 new_log_desc = _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002898 if git_footers.get_footer_change_id(new_log_desc):
vapiera7fbd5a2016-06-16 09:17:49 -07002899 print('git-cl: Added Change-Id to commit message.')
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002900 return new_log_desc
2901 else:
tandrii@chromium.orgb067ec52016-05-31 15:24:44 +00002902 DieWithError('ERROR: Gerrit commit-msg hook not installed.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002903
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002904 def SetCQState(self, new_state):
2905 """Sets the Commit-Queue label assuming canonical CQ config for Gerrit."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002906 vote_map = {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002907 _CQState.NONE: 0,
2908 _CQState.DRY_RUN: 1,
2909 _CQState.COMMIT: 2,
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002910 }
Aaron Gablefc62f762017-07-17 11:12:07 -07002911 labels = {'Commit-Queue': vote_map[new_state]}
2912 notify = False if new_state == _CQState.DRY_RUN else None
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002913 gerrit_util.SetReview(
2914 self._GetGerritHost(), self._GerritChangeIdentifier(),
2915 labels=labels, notify=notify)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002916
tandriie113dfd2016-10-11 10:20:12 -07002917 def CannotTriggerTryJobReason(self):
tandrii8c5a3532016-11-04 07:52:02 -07002918 try:
2919 data = self._GetChangeDetail()
Aaron Gablea45ee112016-11-22 15:14:38 -08002920 except GerritChangeNotExists:
2921 return 'Gerrit doesn\'t know about your change %s' % self.GetIssue()
tandrii8c5a3532016-11-04 07:52:02 -07002922
2923 if data['status'] in ('ABANDONED', 'MERGED'):
2924 return 'CL %s is closed' % self.GetIssue()
2925
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002926 def GetTryJobProperties(self, patchset=None):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002927 """Returns dictionary of properties to launch a tryjob."""
tandrii8c5a3532016-11-04 07:52:02 -07002928 data = self._GetChangeDetail(['ALL_REVISIONS'])
2929 patchset = int(patchset or self.GetPatchset())
2930 assert patchset
2931 revision_data = None # Pylint wants it to be defined.
2932 for revision_data in data['revisions'].itervalues():
2933 if int(revision_data['_number']) == patchset:
2934 break
2935 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08002936 raise Exception('Patchset %d is not known in Gerrit change %d' %
tandrii8c5a3532016-11-04 07:52:02 -07002937 (patchset, self.GetIssue()))
2938 return {
2939 'patch_issue': self.GetIssue(),
2940 'patch_set': patchset or self.GetPatchset(),
2941 'patch_project': data['project'],
2942 'patch_storage': 'gerrit',
2943 'patch_ref': revision_data['fetch']['http']['ref'],
2944 'patch_repository_url': revision_data['fetch']['http']['url'],
2945 'patch_gerrit_url': self.GetCodereviewServer(),
2946 }
tandriie113dfd2016-10-11 10:20:12 -07002947
tandriide281ae2016-10-12 06:02:30 -07002948 def GetIssueOwner(self):
tandrii8c5a3532016-11-04 07:52:02 -07002949 return self._GetChangeDetail(['DETAILED_ACCOUNTS'])['owner']['email']
tandriide281ae2016-10-12 06:02:30 -07002950
Edward Lemur707d70b2018-02-07 00:50:14 +01002951 def GetReviewers(self):
2952 details = self._GetChangeDetail(['DETAILED_ACCOUNTS'])
Mohamed Heikal171c0742018-11-09 20:38:51 +00002953 return [r['email'] for r in details['reviewers'].get('REVIEWER', [])]
Edward Lemur707d70b2018-02-07 00:50:14 +01002954
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002955
2956_CODEREVIEW_IMPLEMENTATIONS = {
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002957 'gerrit': _GerritChangelistImpl,
2958}
2959
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002960
iannuccie53c9352016-08-17 14:40:40 -07002961def _add_codereview_issue_select_options(parser, extra=""):
2962 _add_codereview_select_options(parser)
2963
2964 text = ('Operate on this issue number instead of the current branch\'s '
2965 'implicit issue.')
2966 if extra:
2967 text += ' '+extra
2968 parser.add_option('-i', '--issue', type=int, help=text)
2969
2970
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002971def _add_codereview_select_options(parser):
Edward Lemurf38bc172019-09-03 21:02:13 +00002972 """Appends --gerrit option to force specific codereview."""
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002973 parser.codereview_group = optparse.OptionGroup(
Edward Lemurf38bc172019-09-03 21:02:13 +00002974 parser, 'DEPRECATED! Codereview override options')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002975 parser.add_option_group(parser.codereview_group)
2976 parser.codereview_group.add_option(
2977 '--gerrit', action='store_true',
Edward Lemurf38bc172019-09-03 21:02:13 +00002978 help='Deprecated. Noop. Do not use.')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002979
2980
2981def _process_codereview_select_options(parser, options):
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002982 options.forced_codereview = None
2983 if options.gerrit:
2984 options.forced_codereview = 'gerrit'
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002985
2986
tandriif9aefb72016-07-01 09:06:51 -07002987def _get_bug_line_values(default_project, bugs):
2988 """Given default_project and comma separated list of bugs, yields bug line
2989 values.
2990
2991 Each bug can be either:
2992 * a number, which is combined with default_project
2993 * string, which is left as is.
2994
2995 This function may produce more than one line, because bugdroid expects one
2996 project per line.
2997
2998 >>> list(_get_bug_line_values('v8', '123,chromium:789'))
2999 ['v8:123', 'chromium:789']
3000 """
3001 default_bugs = []
3002 others = []
3003 for bug in bugs.split(','):
3004 bug = bug.strip()
3005 if bug:
3006 try:
3007 default_bugs.append(int(bug))
3008 except ValueError:
3009 others.append(bug)
3010
3011 if default_bugs:
3012 default_bugs = ','.join(map(str, default_bugs))
3013 if default_project:
3014 yield '%s:%s' % (default_project, default_bugs)
3015 else:
3016 yield default_bugs
3017 for other in sorted(others):
3018 # Don't bother finding common prefixes, CLs with >2 bugs are very very rare.
3019 yield other
3020
3021
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003022class ChangeDescription(object):
3023 """Contains a parsed form of the change description."""
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00003024 R_LINE = r'^[ \t]*(TBR|R)[ \t]*=[ \t]*(.*?)[ \t]*$'
bradnelsond975b302016-10-23 12:20:23 -07003025 CC_LINE = r'^[ \t]*(CC)[ \t]*=[ \t]*(.*?)[ \t]*$'
Aaron Gable3a16ed12017-03-23 10:51:55 -07003026 BUG_LINE = r'^[ \t]*(?:(BUG)[ \t]*=|Bug:)[ \t]*(.*?)[ \t]*$'
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003027 CHERRY_PICK_LINE = r'^\(cherry picked from commit [a-fA-F0-9]{40}\)$'
Nodir Turakulov23b82142017-11-16 11:04:25 -08003028 STRIP_HASH_TAG_PREFIX = r'^(\s*(revert|reland)( "|:)?\s*)*'
3029 BRACKET_HASH_TAG = r'\s*\[([^\[\]]+)\]'
3030 COLON_SEPARATED_HASH_TAG = r'^([a-zA-Z0-9_\- ]+):'
3031 BAD_HASH_TAG_CHUNK = r'[^a-zA-Z0-9]+'
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003032
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003033 def __init__(self, description):
agable@chromium.org42c20792013-09-12 17:34:49 +00003034 self._description_lines = (description or '').strip().splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003035
agable@chromium.org42c20792013-09-12 17:34:49 +00003036 @property # www.logilab.org/ticket/89786
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003037 def description(self): # pylint: disable=method-hidden
agable@chromium.org42c20792013-09-12 17:34:49 +00003038 return '\n'.join(self._description_lines)
3039
3040 def set_description(self, desc):
3041 if isinstance(desc, basestring):
3042 lines = desc.splitlines()
3043 else:
3044 lines = [line.rstrip() for line in desc]
3045 while lines and not lines[0]:
3046 lines.pop(0)
3047 while lines and not lines[-1]:
3048 lines.pop(-1)
3049 self._description_lines = lines
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003050
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003051 def update_reviewers(self, reviewers, tbrs, add_owners_to=None, change=None):
3052 """Rewrites the R=/TBR= line(s) as a single line each.
3053
3054 Args:
3055 reviewers (list(str)) - list of additional emails to use for reviewers.
3056 tbrs (list(str)) - list of additional emails to use for TBRs.
3057 add_owners_to (None|'R'|'TBR') - Pass to do an OWNERS lookup for files in
3058 the change that are missing OWNER coverage. If this is not None, you
3059 must also pass a value for `change`.
3060 change (Change) - The Change that should be used for OWNERS lookups.
3061 """
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003062 assert isinstance(reviewers, list), reviewers
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003063 assert isinstance(tbrs, list), tbrs
3064
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003065 assert add_owners_to in (None, 'TBR', 'R'), add_owners_to
Robert Iannuccia28592e2017-04-18 13:14:49 -07003066 assert not add_owners_to or change, add_owners_to
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003067
3068 if not reviewers and not tbrs and not add_owners_to:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003069 return
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003070
3071 reviewers = set(reviewers)
3072 tbrs = set(tbrs)
3073 LOOKUP = {
3074 'TBR': tbrs,
3075 'R': reviewers,
3076 }
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003077
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003078 # Get the set of R= and TBR= lines and remove them from the description.
agable@chromium.org42c20792013-09-12 17:34:49 +00003079 regexp = re.compile(self.R_LINE)
3080 matches = [regexp.match(line) for line in self._description_lines]
3081 new_desc = [l for i, l in enumerate(self._description_lines)
3082 if not matches[i]]
3083 self.set_description(new_desc)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003084
agable@chromium.org42c20792013-09-12 17:34:49 +00003085 # Construct new unified R= and TBR= lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003086
3087 # First, update tbrs/reviewers with names from the R=/TBR= lines (if any).
agable@chromium.org42c20792013-09-12 17:34:49 +00003088 for match in matches:
3089 if not match:
3090 continue
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003091 LOOKUP[match.group(1)].update(cleanup_list([match.group(2).strip()]))
3092
3093 # Next, maybe fill in OWNERS coverage gaps to either tbrs/reviewers.
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003094 if add_owners_to:
piman@chromium.org336f9122014-09-04 02:16:55 +00003095 owners_db = owners.Database(change.RepositoryRoot(),
Jochen Eisinger72606f82017-04-04 10:44:18 +02003096 fopen=file, os_path=os.path)
piman@chromium.org336f9122014-09-04 02:16:55 +00003097 missing_files = owners_db.files_not_covered_by(change.LocalPaths(),
Robert Iannucci100aa212017-04-18 17:28:26 -07003098 (tbrs | reviewers))
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003099 LOOKUP[add_owners_to].update(
3100 owners_db.reviewers_for(missing_files, change.author_email))
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003101
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003102 # If any folks ended up in both groups, remove them from tbrs.
3103 tbrs -= reviewers
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003104
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003105 new_r_line = 'R=' + ', '.join(sorted(reviewers)) if reviewers else None
3106 new_tbr_line = 'TBR=' + ', '.join(sorted(tbrs)) if tbrs else None
agable@chromium.org42c20792013-09-12 17:34:49 +00003107
3108 # Put the new lines in the description where the old first R= line was.
3109 line_loc = next((i for i, match in enumerate(matches) if match), -1)
3110 if 0 <= line_loc < len(self._description_lines):
3111 if new_tbr_line:
3112 self._description_lines.insert(line_loc, new_tbr_line)
3113 if new_r_line:
3114 self._description_lines.insert(line_loc, new_r_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003115 else:
agable@chromium.org42c20792013-09-12 17:34:49 +00003116 if new_r_line:
3117 self.append_footer(new_r_line)
3118 if new_tbr_line:
3119 self.append_footer(new_tbr_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003120
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00003121 def set_preserve_tryjobs(self):
3122 """Ensures description footer contains 'Cq-Do-Not-Cancel-Tryjobs: true'."""
3123 footers = git_footers.parse_footers(self.description)
3124 for v in footers.get('Cq-Do-Not-Cancel-Tryjobs', []):
3125 if v.lower() == 'true':
3126 return
3127 self.append_footer('Cq-Do-Not-Cancel-Tryjobs: true')
3128
Aaron Gable3a16ed12017-03-23 10:51:55 -07003129 def prompt(self, bug=None, git_footer=True):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003130 """Asks the user to update the description."""
agable@chromium.org42c20792013-09-12 17:34:49 +00003131 self.set_description([
3132 '# Enter a description of the change.',
3133 '# This will be displayed on the codereview site.',
3134 '# The first line will also be used as the subject of the review.',
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +00003135 '#--------------------This line is 72 characters long'
agable@chromium.org42c20792013-09-12 17:34:49 +00003136 '--------------------',
3137 ] + self._description_lines)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003138
agable@chromium.org42c20792013-09-12 17:34:49 +00003139 regexp = re.compile(self.BUG_LINE)
Jonas Termansend0f79112019-03-22 15:28:26 +00003140 prefix = settings.GetBugPrefix()
agable@chromium.org42c20792013-09-12 17:34:49 +00003141 if not any((regexp.match(line) for line in self._description_lines)):
tandriif9aefb72016-07-01 09:06:51 -07003142 values = list(_get_bug_line_values(prefix, bug or '')) or [prefix]
Aaron Gable3a16ed12017-03-23 10:51:55 -07003143 if git_footer:
3144 self.append_footer('Bug: %s' % ', '.join(values))
3145 else:
3146 for value in values:
3147 self.append_footer('BUG=%s' % value)
tandriif9aefb72016-07-01 09:06:51 -07003148
agable@chromium.org42c20792013-09-12 17:34:49 +00003149 content = gclient_utils.RunEditor(self.description, True,
jbroman@chromium.org615a2622013-05-03 13:20:14 +00003150 git_editor=settings.GetGitEditor())
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00003151 if not content:
3152 DieWithError('Running editor failed')
agable@chromium.org42c20792013-09-12 17:34:49 +00003153 lines = content.splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003154
Bruce Dawson2377b012018-01-11 16:46:49 -08003155 # Strip off comments and default inserted "Bug:" line.
3156 clean_lines = [line.rstrip() for line in lines if not
Jonas Termansend0f79112019-03-22 15:28:26 +00003157 (line.startswith('#') or
3158 line.rstrip() == "Bug:" or
3159 line.rstrip() == "Bug: " + prefix)]
agable@chromium.org42c20792013-09-12 17:34:49 +00003160 if not clean_lines:
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00003161 DieWithError('No CL description, aborting')
agable@chromium.org42c20792013-09-12 17:34:49 +00003162 self.set_description(clean_lines)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003163
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003164 def append_footer(self, line):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00003165 """Adds a footer line to the description.
3166
3167 Differentiates legacy "KEY=xxx" footers (used to be called tags) and
3168 Gerrit's footers in the form of "Footer-Key: footer any value" and ensures
3169 that Gerrit footers are always at the end.
3170 """
3171 parsed_footer_line = git_footers.parse_footer(line)
3172 if parsed_footer_line:
3173 # Line is a gerrit footer in the form: Footer-Key: any value.
3174 # Thus, must be appended observing Gerrit footer rules.
3175 self.set_description(
3176 git_footers.add_footer(self.description,
3177 key=parsed_footer_line[0],
3178 value=parsed_footer_line[1]))
3179 return
3180
3181 if not self._description_lines:
3182 self._description_lines.append(line)
3183 return
3184
3185 top_lines, gerrit_footers, _ = git_footers.split_footers(self.description)
3186 if gerrit_footers:
3187 # git_footers.split_footers ensures that there is an empty line before
3188 # actual (gerrit) footers, if any. We have to keep it that way.
3189 assert top_lines and top_lines[-1] == ''
3190 top_lines, separator = top_lines[:-1], top_lines[-1:]
3191 else:
3192 separator = [] # No need for separator if there are no gerrit_footers.
3193
3194 prev_line = top_lines[-1] if top_lines else ''
3195 if (not presubmit_support.Change.TAG_LINE_RE.match(prev_line) or
3196 not presubmit_support.Change.TAG_LINE_RE.match(line)):
3197 top_lines.append('')
3198 top_lines.append(line)
3199 self._description_lines = top_lines + separator + gerrit_footers
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003200
tandrii99a72f22016-08-17 14:33:24 -07003201 def get_reviewers(self, tbr_only=False):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003202 """Retrieves the list of reviewers."""
agable@chromium.org42c20792013-09-12 17:34:49 +00003203 matches = [re.match(self.R_LINE, line) for line in self._description_lines]
tandrii99a72f22016-08-17 14:33:24 -07003204 reviewers = [match.group(2).strip()
3205 for match in matches
3206 if match and (not tbr_only or match.group(1).upper() == 'TBR')]
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003207 return cleanup_list(reviewers)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003208
bradnelsond975b302016-10-23 12:20:23 -07003209 def get_cced(self):
3210 """Retrieves the list of reviewers."""
3211 matches = [re.match(self.CC_LINE, line) for line in self._description_lines]
3212 cced = [match.group(2).strip() for match in matches if match]
3213 return cleanup_list(cced)
3214
Nodir Turakulov23b82142017-11-16 11:04:25 -08003215 def get_hash_tags(self):
3216 """Extracts and sanitizes a list of Gerrit hashtags."""
3217 subject = (self._description_lines or ('',))[0]
3218 subject = re.sub(
3219 self.STRIP_HASH_TAG_PREFIX, '', subject, flags=re.IGNORECASE)
3220
3221 tags = []
3222 start = 0
3223 bracket_exp = re.compile(self.BRACKET_HASH_TAG)
3224 while True:
3225 m = bracket_exp.match(subject, start)
3226 if not m:
3227 break
3228 tags.append(self.sanitize_hash_tag(m.group(1)))
3229 start = m.end()
3230
3231 if not tags:
3232 # Try "Tag: " prefix.
3233 m = re.match(self.COLON_SEPARATED_HASH_TAG, subject)
3234 if m:
3235 tags.append(self.sanitize_hash_tag(m.group(1)))
3236 return tags
3237
3238 @classmethod
3239 def sanitize_hash_tag(cls, tag):
3240 """Returns a sanitized Gerrit hash tag.
3241
3242 A sanitized hashtag can be used as a git push refspec parameter value.
3243 """
3244 return re.sub(cls.BAD_HASH_TAG_CHUNK, '-', tag).strip('-').lower()
3245
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003246 def update_with_git_number_footers(self, parent_hash, parent_msg, dest_ref):
3247 """Updates this commit description given the parent.
3248
3249 This is essentially what Gnumbd used to do.
3250 Consult https://goo.gl/WMmpDe for more details.
3251 """
3252 assert parent_msg # No, orphan branch creation isn't supported.
3253 assert parent_hash
3254 assert dest_ref
3255 parent_footer_map = git_footers.parse_footers(parent_msg)
3256 # This will also happily parse svn-position, which GnumbD is no longer
3257 # supporting. While we'd generate correct footers, the verifier plugin
3258 # installed in Gerrit will block such commit (ie git push below will fail).
3259 parent_position = git_footers.get_position(parent_footer_map)
3260
3261 # Cherry-picks may have last line obscuring their prior footers,
3262 # from git_footers perspective. This is also what Gnumbd did.
3263 cp_line = None
3264 if (self._description_lines and
3265 re.match(self.CHERRY_PICK_LINE, self._description_lines[-1])):
3266 cp_line = self._description_lines.pop()
3267
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003268 top_lines, footer_lines, _ = git_footers.split_footers(self.description)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003269
3270 # Original-ify all Cr- footers, to avoid re-lands, cherry-picks, or just
3271 # user interference with actual footers we'd insert below.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003272 for i, line in enumerate(footer_lines):
3273 k, v = git_footers.parse_footer(line) or (None, None)
3274 if k and k.startswith('Cr-'):
3275 footer_lines[i] = '%s: %s' % ('Cr-Original-' + k[len('Cr-'):], v)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003276
3277 # Add Position and Lineage footers based on the parent.
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +01003278 lineage = list(reversed(parent_footer_map.get('Cr-Branched-From', [])))
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003279 if parent_position[0] == dest_ref:
3280 # Same branch as parent.
3281 number = int(parent_position[1]) + 1
3282 else:
3283 number = 1 # New branch, and extra lineage.
3284 lineage.insert(0, '%s-%s@{#%d}' % (parent_hash, parent_position[0],
3285 int(parent_position[1])))
3286
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003287 footer_lines.append('Cr-Commit-Position: %s@{#%d}' % (dest_ref, number))
3288 footer_lines.extend('Cr-Branched-From: %s' % v for v in lineage)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003289
3290 self._description_lines = top_lines
3291 if cp_line:
3292 self._description_lines.append(cp_line)
3293 if self._description_lines[-1] != '':
3294 self._description_lines.append('') # Ensure footer separator.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003295 self._description_lines.extend(footer_lines)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003296
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003297
Aaron Gablea1bab272017-04-11 16:38:18 -07003298def get_approving_reviewers(props, disapproval=False):
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003299 """Retrieves the reviewers that approved a CL from the issue properties with
3300 messages.
3301
3302 Note that the list may contain reviewers that are not committer, thus are not
3303 considered by the CQ.
Aaron Gablea1bab272017-04-11 16:38:18 -07003304
3305 If disapproval is True, instead returns reviewers who 'not lgtm'd the CL.
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003306 """
Aaron Gablea1bab272017-04-11 16:38:18 -07003307 approval_type = 'disapproval' if disapproval else 'approval'
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003308 return sorted(
3309 set(
3310 message['sender']
3311 for message in props['messages']
Aaron Gablea1bab272017-04-11 16:38:18 -07003312 if message[approval_type] and message['sender'] in props['reviewers']
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003313 )
3314 )
3315
3316
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003317def FindCodereviewSettingsFile(filename='codereview.settings'):
3318 """Finds the given file starting in the cwd and going up.
3319
3320 Only looks up to the top of the repository unless an
3321 'inherit-review-settings-ok' file exists in the root of the repository.
3322 """
3323 inherit_ok_file = 'inherit-review-settings-ok'
3324 cwd = os.getcwd()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00003325 root = settings.GetRoot()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003326 if os.path.isfile(os.path.join(root, inherit_ok_file)):
3327 root = '/'
3328 while True:
3329 if filename in os.listdir(cwd):
3330 if os.path.isfile(os.path.join(cwd, filename)):
3331 return open(os.path.join(cwd, filename))
3332 if cwd == root:
3333 break
3334 cwd = os.path.dirname(cwd)
3335
3336
3337def LoadCodereviewSettingsFromFile(fileobj):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003338 """Parses a codereview.settings file and updates hooks."""
maruel@chromium.org99ac1c52012-01-16 14:52:12 +00003339 keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003340
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003341 def SetProperty(name, setting, unset_error_ok=False):
3342 fullname = 'rietveld.' + name
3343 if setting in keyvals:
3344 RunGit(['config', fullname, keyvals[setting]])
3345 else:
3346 RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok)
3347
tandrii48df5812016-10-17 03:55:37 -07003348 if not keyvals.get('GERRIT_HOST', False):
3349 SetProperty('server', 'CODE_REVIEW_SERVER')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003350 # Only server setting is required. Other settings can be absent.
3351 # In that case, we ignore errors raised during option deletion attempt.
3352 SetProperty('cc', 'CC_LIST', unset_error_ok=True)
3353 SetProperty('tree-status-url', 'STATUS', unset_error_ok=True)
3354 SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True)
rmistry@google.com90752582014-01-14 21:04:50 +00003355 SetProperty('bug-prefix', 'BUG_PREFIX', unset_error_ok=True)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003356 SetProperty('cpplint-regex', 'LINT_REGEX', unset_error_ok=True)
3357 SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +00003358 SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK',
3359 unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003360
ukai@chromium.org7044efc2013-11-28 01:51:21 +00003361 if 'GERRIT_HOST' in keyvals:
ukai@chromium.orge8077812012-02-03 03:41:46 +00003362 RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']])
ukai@chromium.orge8077812012-02-03 03:41:46 +00003363
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003364 if 'GERRIT_SQUASH_UPLOADS' in keyvals:
tandrii8dd81ea2016-06-16 13:24:23 -07003365 RunGit(['config', 'gerrit.squash-uploads',
3366 keyvals['GERRIT_SQUASH_UPLOADS']])
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003367
tandrii@chromium.org28253532016-04-14 13:46:56 +00003368 if 'GERRIT_SKIP_ENSURE_AUTHENTICATED' in keyvals:
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00003369 RunGit(['config', 'gerrit.skip-ensure-authenticated',
tandrii@chromium.org28253532016-04-14 13:46:56 +00003370 keyvals['GERRIT_SKIP_ENSURE_AUTHENTICATED']])
3371
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003372 if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01003373 # should be of the form
3374 # PUSH_URL_CONFIG: url.ssh://gitrw.chromium.org.pushinsteadof
3375 # ORIGIN_URL_CONFIG: http://src.chromium.org/git
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003376 RunGit(['config', keyvals['PUSH_URL_CONFIG'],
3377 keyvals['ORIGIN_URL_CONFIG']])
3378
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003379
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003380def urlretrieve(source, destination):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003381 """Downloads a network object to a local file, like urllib.urlretrieve.
3382
3383 This is necessary because urllib is broken for SSL connections via a proxy.
3384 """
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003385 with open(destination, 'w') as f:
3386 f.write(urllib2.urlopen(source).read())
3387
3388
ukai@chromium.org712d6102013-11-27 00:52:58 +00003389def hasSheBang(fname):
3390 """Checks fname is a #! script."""
3391 with open(fname) as f:
3392 return f.read(2).startswith('#!')
3393
3394
bpastene@chromium.org917f0ff2016-04-05 00:45:30 +00003395# TODO(bpastene) Remove once a cleaner fix to crbug.com/600473 presents itself.
3396def DownloadHooks(*args, **kwargs):
3397 pass
3398
3399
tandrii@chromium.org18630d62016-03-04 12:06:02 +00003400def DownloadGerritHook(force):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003401 """Downloads and installs a Gerrit commit-msg hook.
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003402
3403 Args:
3404 force: True to update hooks. False to install hooks if not present.
3405 """
3406 if not settings.GetIsGerrit():
3407 return
ukai@chromium.org712d6102013-11-27 00:52:58 +00003408 src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg'
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003409 dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
3410 if not os.access(dst, os.X_OK):
3411 if os.path.exists(dst):
3412 if not force:
3413 return
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003414 try:
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003415 urlretrieve(src, dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003416 if not hasSheBang(dst):
3417 DieWithError('Not a script: %s\n'
3418 'You need to download from\n%s\n'
3419 'into .git/hooks/commit-msg and '
3420 'chmod +x .git/hooks/commit-msg' % (dst, src))
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003421 os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
3422 except Exception:
3423 if os.path.exists(dst):
3424 os.remove(dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003425 DieWithError('\nFailed to download hooks.\n'
3426 'You need to download from\n%s\n'
3427 'into .git/hooks/commit-msg and '
3428 'chmod +x .git/hooks/commit-msg' % src)
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003429
3430
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003431class _GitCookiesChecker(object):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003432 """Provides facilities for validating and suggesting fixes to .gitcookies."""
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003433
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003434 _GOOGLESOURCE = 'googlesource.com'
3435
3436 def __init__(self):
3437 # Cached list of [host, identity, source], where source is either
3438 # .gitcookies or .netrc.
3439 self._all_hosts = None
3440
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003441 def ensure_configured_gitcookies(self):
3442 """Runs checks and suggests fixes to make git use .gitcookies from default
3443 path."""
3444 default = gerrit_util.CookiesAuthenticator.get_gitcookies_path()
3445 configured_path = RunGitSilent(
3446 ['config', '--global', 'http.cookiefile']).strip()
Andrii Shyshkalov1e250cd2017-05-10 15:39:31 +02003447 configured_path = os.path.expanduser(configured_path)
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003448 if configured_path:
3449 self._ensure_default_gitcookies_path(configured_path, default)
3450 else:
3451 self._configure_gitcookies_path(default)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003452
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003453 @staticmethod
3454 def _ensure_default_gitcookies_path(configured_path, default_path):
3455 assert configured_path
3456 if configured_path == default_path:
3457 print('git is already configured to use your .gitcookies from %s' %
3458 configured_path)
3459 return
3460
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003461 print('WARNING: You have configured custom path to .gitcookies: %s\n'
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003462 'Gerrit and other depot_tools expect .gitcookies at %s\n' %
3463 (configured_path, default_path))
3464
3465 if not os.path.exists(configured_path):
3466 print('However, your configured .gitcookies file is missing.')
3467 confirm_or_exit('Reconfigure git to use default .gitcookies?',
3468 action='reconfigure')
3469 RunGit(['config', '--global', 'http.cookiefile', default_path])
3470 return
3471
3472 if os.path.exists(default_path):
3473 print('WARNING: default .gitcookies file already exists %s' %
3474 default_path)
3475 DieWithError('Please delete %s manually and re-run git cl creds-check' %
3476 default_path)
3477
3478 confirm_or_exit('Move existing .gitcookies to default location?',
3479 action='move')
3480 shutil.move(configured_path, default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003481 RunGit(['config', '--global', 'http.cookiefile', default_path])
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003482 print('Moved and reconfigured git to use .gitcookies from %s' %
3483 default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003484
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003485 @staticmethod
3486 def _configure_gitcookies_path(default_path):
3487 netrc_path = gerrit_util.CookiesAuthenticator.get_netrc_path()
3488 if os.path.exists(netrc_path):
3489 print('You seem to be using outdated .netrc for git credentials: %s' %
3490 netrc_path)
3491 print('This tool will guide you through setting up recommended '
3492 '.gitcookies store for git credentials.\n'
3493 '\n'
3494 'IMPORTANT: If something goes wrong and you decide to go back, do:\n'
3495 ' git config --global --unset http.cookiefile\n'
3496 ' mv %s %s.backup\n\n' % (default_path, default_path))
3497 confirm_or_exit(action='setup .gitcookies')
3498 RunGit(['config', '--global', 'http.cookiefile', default_path])
3499 print('Configured git to use .gitcookies from %s' % default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003500
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003501 def get_hosts_with_creds(self, include_netrc=False):
3502 if self._all_hosts is None:
3503 a = gerrit_util.CookiesAuthenticator()
3504 self._all_hosts = [
3505 (h, u, s)
3506 for h, u, s in itertools.chain(
3507 ((h, u, '.netrc') for h, (u, _, _) in a.netrc.hosts.iteritems()),
3508 ((h, u, '.gitcookies') for h, (u, _) in a.gitcookies.iteritems())
3509 )
3510 if h.endswith(self._GOOGLESOURCE)
3511 ]
3512
3513 if include_netrc:
3514 return self._all_hosts
3515 return [(h, u, s) for h, u, s in self._all_hosts if s != '.netrc']
3516
3517 def print_current_creds(self, include_netrc=False):
3518 hosts = sorted(self.get_hosts_with_creds(include_netrc=include_netrc))
3519 if not hosts:
3520 print('No Git/Gerrit credentials found')
3521 return
3522 lengths = [max(map(len, (row[i] for row in hosts))) for i in xrange(3)]
3523 header = [('Host', 'User', 'Which file'),
3524 ['=' * l for l in lengths]]
3525 for row in (header + hosts):
3526 print('\t'.join((('%%+%ds' % l) % s)
3527 for l, s in zip(lengths, row)))
3528
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003529 @staticmethod
3530 def _parse_identity(identity):
Lei Zhangd3f769a2017-12-15 15:16:14 -08003531 """Parses identity "git-<username>.domain" into <username> and domain."""
3532 # Special case: usernames that contain ".", which are generally not
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02003533 # distinguishable from sub-domains. But we do know typical domains:
3534 if identity.endswith('.chromium.org'):
3535 domain = 'chromium.org'
3536 username = identity[:-len('.chromium.org')]
3537 else:
3538 username, domain = identity.split('.', 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003539 if username.startswith('git-'):
3540 username = username[len('git-'):]
3541 return username, domain
3542
3543 def _get_usernames_of_domain(self, domain):
3544 """Returns list of usernames referenced by .gitcookies in a given domain."""
3545 identities_by_domain = {}
3546 for _, identity, _ in self.get_hosts_with_creds():
3547 username, domain = self._parse_identity(identity)
3548 identities_by_domain.setdefault(domain, []).append(username)
3549 return identities_by_domain.get(domain)
3550
3551 def _canonical_git_googlesource_host(self, host):
3552 """Normalizes Gerrit hosts (with '-review') to Git host."""
3553 assert host.endswith(self._GOOGLESOURCE)
3554 # Prefix doesn't include '.' at the end.
3555 prefix = host[:-(1 + len(self._GOOGLESOURCE))]
3556 if prefix.endswith('-review'):
3557 prefix = prefix[:-len('-review')]
3558 return prefix + '.' + self._GOOGLESOURCE
3559
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003560 def _canonical_gerrit_googlesource_host(self, host):
3561 git_host = self._canonical_git_googlesource_host(host)
3562 prefix = git_host.split('.', 1)[0]
3563 return prefix + '-review.' + self._GOOGLESOURCE
3564
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003565 def _get_counterpart_host(self, host):
3566 assert host.endswith(self._GOOGLESOURCE)
3567 git = self._canonical_git_googlesource_host(host)
3568 gerrit = self._canonical_gerrit_googlesource_host(git)
3569 return git if gerrit == host else gerrit
3570
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003571 def has_generic_host(self):
3572 """Returns whether generic .googlesource.com has been configured.
3573
3574 Chrome Infra recommends to use explicit ${host}.googlesource.com instead.
3575 """
3576 for host, _, _ in self.get_hosts_with_creds(include_netrc=False):
3577 if host == '.' + self._GOOGLESOURCE:
3578 return True
3579 return False
3580
3581 def _get_git_gerrit_identity_pairs(self):
3582 """Returns map from canonic host to pair of identities (Git, Gerrit).
3583
3584 One of identities might be None, meaning not configured.
3585 """
3586 host_to_identity_pairs = {}
3587 for host, identity, _ in self.get_hosts_with_creds():
3588 canonical = self._canonical_git_googlesource_host(host)
3589 pair = host_to_identity_pairs.setdefault(canonical, [None, None])
3590 idx = 0 if canonical == host else 1
3591 pair[idx] = identity
3592 return host_to_identity_pairs
3593
3594 def get_partially_configured_hosts(self):
3595 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003596 (host if i1 else self._canonical_gerrit_googlesource_host(host))
3597 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().iteritems()
3598 if None in (i1, i2) and host != '.' + self._GOOGLESOURCE)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003599
3600 def get_conflicting_hosts(self):
3601 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003602 host
3603 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().iteritems()
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003604 if None not in (i1, i2) and i1 != i2)
3605
3606 def get_duplicated_hosts(self):
3607 counters = collections.Counter(h for h, _, _ in self.get_hosts_with_creds())
3608 return set(host for host, count in counters.iteritems() if count > 1)
3609
3610 _EXPECTED_HOST_IDENTITY_DOMAINS = {
3611 'chromium.googlesource.com': 'chromium.org',
3612 'chrome-internal.googlesource.com': 'google.com',
3613 }
3614
3615 def get_hosts_with_wrong_identities(self):
3616 """Finds hosts which **likely** reference wrong identities.
3617
3618 Note: skips hosts which have conflicting identities for Git and Gerrit.
3619 """
3620 hosts = set()
3621 for host, expected in self._EXPECTED_HOST_IDENTITY_DOMAINS.iteritems():
3622 pair = self._get_git_gerrit_identity_pairs().get(host)
3623 if pair and pair[0] == pair[1]:
3624 _, domain = self._parse_identity(pair[0])
3625 if domain != expected:
3626 hosts.add(host)
3627 return hosts
3628
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003629 @staticmethod
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003630 def _format_hosts(hosts, extra_column_func=None):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003631 hosts = sorted(hosts)
3632 assert hosts
3633 if extra_column_func is None:
3634 extras = [''] * len(hosts)
3635 else:
3636 extras = [extra_column_func(host) for host in hosts]
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003637 tmpl = '%%-%ds %%-%ds' % (max(map(len, hosts)), max(map(len, extras)))
3638 lines = []
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003639 for he in zip(hosts, extras):
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003640 lines.append(tmpl % he)
3641 return lines
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003642
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003643 def _find_problems(self):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003644 if self.has_generic_host():
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003645 yield ('.googlesource.com wildcard record detected',
3646 ['Chrome Infrastructure team recommends to list full host names '
3647 'explicitly.'],
3648 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003649
3650 dups = self.get_duplicated_hosts()
3651 if dups:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003652 yield ('The following hosts were defined twice',
3653 self._format_hosts(dups),
3654 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003655
3656 partial = self.get_partially_configured_hosts()
3657 if partial:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003658 yield ('Credentials should come in pairs for Git and Gerrit hosts. '
3659 'These hosts are missing',
3660 self._format_hosts(partial, lambda host: 'but %s defined' %
3661 self._get_counterpart_host(host)),
3662 partial)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003663
3664 conflicting = self.get_conflicting_hosts()
3665 if conflicting:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003666 yield ('The following Git hosts have differing credentials from their '
3667 'Gerrit counterparts',
3668 self._format_hosts(conflicting, lambda host: '%s vs %s' %
3669 tuple(self._get_git_gerrit_identity_pairs()[host])),
3670 conflicting)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003671
3672 wrong = self.get_hosts_with_wrong_identities()
3673 if wrong:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003674 yield ('These hosts likely use wrong identity',
3675 self._format_hosts(wrong, lambda host: '%s but %s recommended' %
3676 (self._get_git_gerrit_identity_pairs()[host][0],
3677 self._EXPECTED_HOST_IDENTITY_DOMAINS[host])),
3678 wrong)
3679
3680 def find_and_report_problems(self):
3681 """Returns True if there was at least one problem, else False."""
3682 found = False
3683 bad_hosts = set()
3684 for title, sublines, hosts in self._find_problems():
3685 if not found:
3686 found = True
3687 print('\n\n.gitcookies problem report:\n')
3688 bad_hosts.update(hosts or [])
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003689 print(' %s%s' % (title, (':' if sublines else '')))
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003690 if sublines:
3691 print()
3692 print(' %s' % '\n '.join(sublines))
3693 print()
3694
3695 if bad_hosts:
3696 assert found
3697 print(' You can manually remove corresponding lines in your %s file and '
3698 'visit the following URLs with correct account to generate '
3699 'correct credential lines:\n' %
3700 gerrit_util.CookiesAuthenticator.get_gitcookies_path())
3701 print(' %s' % '\n '.join(sorted(set(
3702 gerrit_util.CookiesAuthenticator().get_new_password_url(
3703 self._canonical_git_googlesource_host(host))
3704 for host in bad_hosts
3705 ))))
3706 return found
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003707
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003708
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003709@metrics.collector.collect_metrics('git cl creds-check')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003710def CMDcreds_check(parser, args):
3711 """Checks credentials and suggests changes."""
3712 _, _ = parser.parse_args(args)
3713
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003714 # Code below checks .gitcookies. Abort if using something else.
3715 authn = gerrit_util.Authenticator.get()
3716 if not isinstance(authn, gerrit_util.CookiesAuthenticator):
3717 if isinstance(authn, gerrit_util.GceAuthenticator):
3718 DieWithError(
3719 'This command is not designed for GCE, are you on a bot?\n'
3720 'If you need to run this on GCE, export SKIP_GCE_AUTH_FOR_GIT=1 '
3721 'in your env.')
Aaron Gabled10ca0e2017-09-11 11:24:10 -07003722 DieWithError(
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003723 'This command is not designed for bot environment. It checks '
3724 '~/.gitcookies file not generally used on bots.')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003725
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003726 checker = _GitCookiesChecker()
3727 checker.ensure_configured_gitcookies()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003728
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003729 print('Your .netrc and .gitcookies have credentials for these hosts:')
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003730 checker.print_current_creds(include_netrc=True)
3731
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003732 if not checker.find_and_report_problems():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003733 print('\nNo problems detected in your .gitcookies file.')
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003734 return 0
3735 return 1
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003736
3737
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003738@metrics.collector.collect_metrics('git cl baseurl')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003739def CMDbaseurl(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003740 """Gets or sets base-url for this branch."""
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003741 branchref = RunGit(['symbolic-ref', 'HEAD']).strip()
3742 branch = ShortBranchName(branchref)
3743 _, args = parser.parse_args(args)
3744 if not args:
vapiera7fbd5a2016-06-16 09:17:49 -07003745 print('Current base-url:')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003746 return RunGit(['config', 'branch.%s.base-url' % branch],
3747 error_ok=False).strip()
3748 else:
vapiera7fbd5a2016-06-16 09:17:49 -07003749 print('Setting base-url to %s' % args[0])
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003750 return RunGit(['config', 'branch.%s.base-url' % branch, args[0]],
3751 error_ok=False).strip()
3752
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003753
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003754def color_for_status(status):
3755 """Maps a Changelist status to color, for CMDstatus and other tools."""
3756 return {
Aaron Gable9ab38c62017-04-06 14:36:33 -07003757 'unsent': Fore.YELLOW,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003758 'waiting': Fore.BLUE,
3759 'reply': Fore.YELLOW,
Aaron Gable9ab38c62017-04-06 14:36:33 -07003760 'not lgtm': Fore.RED,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003761 'lgtm': Fore.GREEN,
3762 'commit': Fore.MAGENTA,
3763 'closed': Fore.CYAN,
3764 'error': Fore.WHITE,
3765 }.get(status, Fore.WHITE)
3766
tandrii@chromium.org04ea8462016-04-25 19:51:21 +00003767
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003768def get_cl_statuses(changes, fine_grained, max_processes=None):
3769 """Returns a blocking iterable of (cl, status) for given branches.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003770
3771 If fine_grained is true, this will fetch CL statuses from the server.
3772 Otherwise, simply indicate if there's a matching url for the given branches.
3773
3774 If max_processes is specified, it is used as the maximum number of processes
3775 to spawn to fetch CL status from the server. Otherwise 1 process per branch is
3776 spawned.
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003777
3778 See GetStatus() for a list of possible statuses.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003779 """
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003780 if not changes:
3781 raise StopIteration()
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003782
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003783 if not fine_grained:
3784 # Fast path which doesn't involve querying codereview servers.
Aaron Gablea1bab272017-04-11 16:38:18 -07003785 # Do not use get_approving_reviewers(), since it requires an HTTP request.
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003786 for cl in changes:
3787 yield (cl, 'waiting' if cl.GetIssueURL() else 'error')
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003788 return
3789
3790 # First, sort out authentication issues.
3791 logging.debug('ensuring credentials exist')
3792 for cl in changes:
3793 cl.EnsureAuthenticated(force=False, refresh=True)
3794
3795 def fetch(cl):
3796 try:
3797 return (cl, cl.GetStatus())
3798 except:
3799 # See http://crbug.com/629863.
Andrii Shyshkalov98824232018-04-19 11:37:15 -07003800 logging.exception('failed to fetch status for cl %s:', cl.GetIssue())
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003801 raise
3802
3803 threads_count = len(changes)
3804 if max_processes:
3805 threads_count = max(1, min(threads_count, max_processes))
3806 logging.debug('querying %d CLs using %d threads', len(changes), threads_count)
3807
3808 pool = ThreadPool(threads_count)
3809 fetched_cls = set()
3810 try:
3811 it = pool.imap_unordered(fetch, changes).__iter__()
3812 while True:
3813 try:
3814 cl, status = it.next(timeout=5)
3815 except multiprocessing.TimeoutError:
3816 break
3817 fetched_cls.add(cl)
3818 yield cl, status
3819 finally:
3820 pool.close()
3821
3822 # Add any branches that failed to fetch.
3823 for cl in set(changes) - fetched_cls:
3824 yield (cl, 'error')
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003825
rmistry@google.com2dd99862015-06-22 12:22:18 +00003826
3827def upload_branch_deps(cl, args):
3828 """Uploads CLs of local branches that are dependents of the current branch.
3829
3830 If the local branch dependency tree looks like:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003831
3832 test1 -> test2.1 -> test3.1
3833 -> test3.2
3834 -> test2.2 -> test3.3
rmistry@google.com2dd99862015-06-22 12:22:18 +00003835
3836 and you run "git cl upload --dependencies" from test1 then "git cl upload" is
3837 run on the dependent branches in this order:
3838 test2.1, test3.1, test3.2, test2.2, test3.3
3839
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003840 Note: This function does not rebase your local dependent branches. Use it
3841 when you make a change to the parent branch that will not conflict
3842 with its dependent branches, and you would like their dependencies
3843 updated in Rietveld.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003844 """
3845 if git_common.is_dirty_git_tree('upload-branch-deps'):
3846 return 1
3847
3848 root_branch = cl.GetBranch()
3849 if root_branch is None:
3850 DieWithError('Can\'t find dependent branches from detached HEAD state. '
3851 'Get on a branch!')
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00003852 if not cl.GetIssue():
rmistry@google.com2dd99862015-06-22 12:22:18 +00003853 DieWithError('Current branch does not have an uploaded CL. We cannot set '
3854 'patchset dependencies without an uploaded CL.')
3855
3856 branches = RunGit(['for-each-ref',
3857 '--format=%(refname:short) %(upstream:short)',
3858 'refs/heads'])
3859 if not branches:
3860 print('No local branches found.')
3861 return 0
3862
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003863 # Create a dictionary of all local branches to the branches that are
3864 # dependent on it.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003865 tracked_to_dependents = collections.defaultdict(list)
3866 for b in branches.splitlines():
3867 tokens = b.split()
3868 if len(tokens) == 2:
3869 branch_name, tracked = tokens
3870 tracked_to_dependents[tracked].append(branch_name)
3871
vapiera7fbd5a2016-06-16 09:17:49 -07003872 print()
3873 print('The dependent local branches of %s are:' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003874 dependents = []
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003875
rmistry@google.com2dd99862015-06-22 12:22:18 +00003876 def traverse_dependents_preorder(branch, padding=''):
3877 dependents_to_process = tracked_to_dependents.get(branch, [])
3878 padding += ' '
3879 for dependent in dependents_to_process:
vapiera7fbd5a2016-06-16 09:17:49 -07003880 print('%s%s' % (padding, dependent))
rmistry@google.com2dd99862015-06-22 12:22:18 +00003881 dependents.append(dependent)
3882 traverse_dependents_preorder(dependent, padding)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003883
rmistry@google.com2dd99862015-06-22 12:22:18 +00003884 traverse_dependents_preorder(root_branch)
vapiera7fbd5a2016-06-16 09:17:49 -07003885 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003886
3887 if not dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003888 print('There are no dependent local branches for %s' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003889 return 0
3890
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01003891 confirm_or_exit('This command will checkout all dependent branches and run '
3892 '"git cl upload".', action='continue')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003893
rmistry@google.com2dd99862015-06-22 12:22:18 +00003894 # Record all dependents that failed to upload.
3895 failures = {}
3896 # Go through all dependents, checkout the branch and upload.
3897 try:
3898 for dependent_branch in dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003899 print()
3900 print('--------------------------------------')
3901 print('Running "git cl upload" from %s:' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003902 RunGit(['checkout', '-q', dependent_branch])
vapiera7fbd5a2016-06-16 09:17:49 -07003903 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003904 try:
3905 if CMDupload(OptionParser(), args) != 0:
vapiera7fbd5a2016-06-16 09:17:49 -07003906 print('Upload failed for %s!' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003907 failures[dependent_branch] = 1
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003908 except: # pylint: disable=bare-except
rmistry@google.com2dd99862015-06-22 12:22:18 +00003909 failures[dependent_branch] = 1
vapiera7fbd5a2016-06-16 09:17:49 -07003910 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003911 finally:
3912 # Swap back to the original root branch.
3913 RunGit(['checkout', '-q', root_branch])
3914
vapiera7fbd5a2016-06-16 09:17:49 -07003915 print()
3916 print('Upload complete for dependent branches!')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003917 for dependent_branch in dependents:
3918 upload_status = 'failed' if failures.get(dependent_branch) else 'succeeded'
vapiera7fbd5a2016-06-16 09:17:49 -07003919 print(' %s : %s' % (dependent_branch, upload_status))
3920 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003921
3922 return 0
3923
3924
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003925@metrics.collector.collect_metrics('git cl archive')
kmarshall3bff56b2016-06-06 18:31:47 -07003926def CMDarchive(parser, args):
3927 """Archives and deletes branches associated with closed changelists."""
3928 parser.add_option(
3929 '-j', '--maxjobs', action='store', type=int,
kmarshall9249e012016-08-23 12:02:16 -07003930 help='The maximum number of jobs to use when retrieving review status.')
kmarshall3bff56b2016-06-06 18:31:47 -07003931 parser.add_option(
3932 '-f', '--force', action='store_true',
3933 help='Bypasses the confirmation prompt.')
kmarshall9249e012016-08-23 12:02:16 -07003934 parser.add_option(
3935 '-d', '--dry-run', action='store_true',
3936 help='Skip the branch tagging and removal steps.')
3937 parser.add_option(
3938 '-t', '--notags', action='store_true',
3939 help='Do not tag archived branches. '
3940 'Note: local commit history may be lost.')
kmarshall3bff56b2016-06-06 18:31:47 -07003941
kmarshall3bff56b2016-06-06 18:31:47 -07003942 options, args = parser.parse_args(args)
3943 if args:
3944 parser.error('Unsupported args: %s' % ' '.join(args))
kmarshall3bff56b2016-06-06 18:31:47 -07003945
3946 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
3947 if not branches:
3948 return 0
3949
vapiera7fbd5a2016-06-16 09:17:49 -07003950 print('Finding all branches associated with closed issues...')
Edward Lemur934836a2019-09-09 20:16:54 +00003951 changes = [Changelist(branchref=b)
3952 for b in branches.splitlines()]
kmarshall3bff56b2016-06-06 18:31:47 -07003953 alignment = max(5, max(len(c.GetBranch()) for c in changes))
3954 statuses = get_cl_statuses(changes,
3955 fine_grained=True,
3956 max_processes=options.maxjobs)
3957 proposal = [(cl.GetBranch(),
3958 'git-cl-archived-%s-%s' % (cl.GetIssue(), cl.GetBranch()))
3959 for cl, status in statuses
Andrii Shyshkalov51bdf8c2018-10-18 01:07:58 +00003960 if status in ('closed', 'rietveld-not-supported')]
kmarshall3bff56b2016-06-06 18:31:47 -07003961 proposal.sort()
3962
3963 if not proposal:
vapiera7fbd5a2016-06-16 09:17:49 -07003964 print('No branches with closed codereview issues found.')
kmarshall3bff56b2016-06-06 18:31:47 -07003965 return 0
3966
3967 current_branch = GetCurrentBranch()
3968
vapiera7fbd5a2016-06-16 09:17:49 -07003969 print('\nBranches with closed issues that will be archived:\n')
kmarshall9249e012016-08-23 12:02:16 -07003970 if options.notags:
3971 for next_item in proposal:
3972 print(' ' + next_item[0])
3973 else:
3974 print('%*s | %s' % (alignment, 'Branch name', 'Archival tag name'))
3975 for next_item in proposal:
3976 print('%*s %s' % (alignment, next_item[0], next_item[1]))
kmarshall3bff56b2016-06-06 18:31:47 -07003977
kmarshall9249e012016-08-23 12:02:16 -07003978 # Quit now on precondition failure or if instructed by the user, either
3979 # via an interactive prompt or by command line flags.
3980 if options.dry_run:
3981 print('\nNo changes were made (dry run).\n')
3982 return 0
3983 elif any(branch == current_branch for branch, _ in proposal):
kmarshall3bff56b2016-06-06 18:31:47 -07003984 print('You are currently on a branch \'%s\' which is associated with a '
3985 'closed codereview issue, so archive cannot proceed. Please '
3986 'checkout another branch and run this command again.' %
3987 current_branch)
3988 return 1
kmarshall9249e012016-08-23 12:02:16 -07003989 elif not options.force:
sergiyb4a5ecbe2016-06-20 09:46:00 -07003990 answer = ask_for_data('\nProceed with deletion (Y/n)? ').lower()
3991 if answer not in ('y', ''):
vapiera7fbd5a2016-06-16 09:17:49 -07003992 print('Aborted.')
kmarshall3bff56b2016-06-06 18:31:47 -07003993 return 1
3994
3995 for branch, tagname in proposal:
kmarshall9249e012016-08-23 12:02:16 -07003996 if not options.notags:
3997 RunGit(['tag', tagname, branch])
kmarshall3bff56b2016-06-06 18:31:47 -07003998 RunGit(['branch', '-D', branch])
kmarshall9249e012016-08-23 12:02:16 -07003999
vapiera7fbd5a2016-06-16 09:17:49 -07004000 print('\nJob\'s done!')
kmarshall3bff56b2016-06-06 18:31:47 -07004001
4002 return 0
4003
4004
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004005@metrics.collector.collect_metrics('git cl status')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004006def CMDstatus(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004007 """Show status of changelists.
4008
4009 Colors are used to tell the state of the CL unless --fast is used:
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00004010 - Blue waiting for review
Aaron Gable9ab38c62017-04-06 14:36:33 -07004011 - Yellow waiting for you to reply to review, or not yet sent
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00004012 - Green LGTM'ed
Aaron Gable9ab38c62017-04-06 14:36:33 -07004013 - Red 'not LGTM'ed
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004014 - Magenta in the CQ
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00004015 - Cyan was committed, branch can be deleted
Aaron Gable9ab38c62017-04-06 14:36:33 -07004016 - White error, or unknown status
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004017
4018 Also see 'git cl comments'.
4019 """
Alan Cuttera3be9a52019-03-04 18:50:33 +00004020 parser.add_option(
4021 '--no-branch-color',
4022 action='store_true',
4023 help='Disable colorized branch names')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004024 parser.add_option('--field',
phajdan.jr289d03e2016-08-16 08:21:06 -07004025 help='print only specific field (desc|id|patch|status|url)')
maruel@chromium.org1033efd2013-07-23 23:25:09 +00004026 parser.add_option('-f', '--fast', action='store_true',
4027 help='Do not retrieve review status')
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004028 parser.add_option(
4029 '-j', '--maxjobs', action='store', type=int,
4030 help='The maximum number of jobs to use when retrieving review status')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004031
iannuccie53c9352016-08-17 14:40:40 -07004032 _add_codereview_issue_select_options(
4033 parser, 'Must be in conjunction with --field.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004034 options, args = parser.parse_args(args)
Edward Lemurf38bc172019-09-03 21:02:13 +00004035 _process_codereview_select_options(parser, options)
maruel@chromium.org39c0b222013-08-17 16:57:01 +00004036 if args:
4037 parser.error('Unsupported args: %s' % args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004038
iannuccie53c9352016-08-17 14:40:40 -07004039 if options.issue is not None and not options.field:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004040 parser.error('--field must be specified with --issue.')
iannucci3c972b92016-08-17 13:24:10 -07004041
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004042 if options.field:
Edward Lemur934836a2019-09-09 20:16:54 +00004043 cl = Changelist(issue=options.issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004044 if options.field.startswith('desc'):
vapiera7fbd5a2016-06-16 09:17:49 -07004045 print(cl.GetDescription())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004046 elif options.field == 'id':
4047 issueid = cl.GetIssue()
4048 if issueid:
vapiera7fbd5a2016-06-16 09:17:49 -07004049 print(issueid)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004050 elif options.field == 'patch':
Aaron Gablee8856ee2017-12-07 12:41:46 -08004051 patchset = cl.GetMostRecentPatchset()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004052 if patchset:
vapiera7fbd5a2016-06-16 09:17:49 -07004053 print(patchset)
phajdan.jr289d03e2016-08-16 08:21:06 -07004054 elif options.field == 'status':
4055 print(cl.GetStatus())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004056 elif options.field == 'url':
4057 url = cl.GetIssueURL()
4058 if url:
vapiera7fbd5a2016-06-16 09:17:49 -07004059 print(url)
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00004060 return 0
4061
4062 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
4063 if not branches:
4064 print('No local branch found.')
4065 return 0
4066
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004067 changes = [
Edward Lemur934836a2019-09-09 20:16:54 +00004068 Changelist(branchref=b)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004069 for b in branches.splitlines()]
vapiera7fbd5a2016-06-16 09:17:49 -07004070 print('Branches associated with reviews:')
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004071 output = get_cl_statuses(changes,
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004072 fine_grained=not options.fast,
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004073 max_processes=options.maxjobs)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00004074
Daniel McArdlea23bf592019-02-12 00:25:12 +00004075 current_branch = GetCurrentBranch()
4076
4077 def FormatBranchName(branch, colorize=False):
4078 """Simulates 'git branch' behavior. Colorizes and prefixes branch name with
4079 an asterisk when it is the current branch."""
4080
4081 asterisk = ""
4082 color = Fore.RESET
4083 if branch == current_branch:
4084 asterisk = "* "
4085 color = Fore.GREEN
4086 branch_name = ShortBranchName(branch)
4087
4088 if colorize:
4089 return asterisk + color + branch_name + Fore.RESET
Daniel McArdle452a49f2019-02-14 17:28:31 +00004090 return asterisk + branch_name
4091
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004092 branch_statuses = {}
Daniel McArdlea23bf592019-02-12 00:25:12 +00004093
4094 alignment = max(5, max(len(FormatBranchName(c.GetBranch())) for c in changes))
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004095 for cl in sorted(changes, key=lambda c: c.GetBranch()):
4096 branch = cl.GetBranch()
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004097 while branch not in branch_statuses:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004098 c, status = output.next()
4099 branch_statuses[c.GetBranch()] = status
4100 status = branch_statuses.pop(branch)
4101 url = cl.GetIssueURL()
4102 if url and (not status or status == 'error'):
4103 # The issue probably doesn't exist anymore.
4104 url += ' (broken)'
4105
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00004106 color = color_for_status(status)
maruel@chromium.org885f6512013-07-27 02:17:26 +00004107 reset = Fore.RESET
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00004108 if not setup_color.IS_TTY:
maruel@chromium.org885f6512013-07-27 02:17:26 +00004109 color = ''
4110 reset = ''
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00004111 status_str = '(%s)' % status if status else ''
Daniel McArdle452a49f2019-02-14 17:28:31 +00004112
Alan Cuttera3be9a52019-03-04 18:50:33 +00004113 branch_display = FormatBranchName(branch)
4114 padding = ' ' * (alignment - len(branch_display))
4115 if not options.no_branch_color:
4116 branch_display = FormatBranchName(branch, colorize=True)
Daniel McArdle452a49f2019-02-14 17:28:31 +00004117
Alan Cuttera3be9a52019-03-04 18:50:33 +00004118 print(' %s : %s%s %s%s' % (padding + branch_display, color, url,
4119 status_str, reset))
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01004120
vapiera7fbd5a2016-06-16 09:17:49 -07004121 print()
Daniel McArdlea23bf592019-02-12 00:25:12 +00004122 print('Current branch: %s' % current_branch)
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01004123 for cl in changes:
Daniel McArdlea23bf592019-02-12 00:25:12 +00004124 if cl.GetBranch() == current_branch:
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01004125 break
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00004126 if not cl.GetIssue():
vapiera7fbd5a2016-06-16 09:17:49 -07004127 print('No issue assigned.')
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00004128 return 0
vapiera7fbd5a2016-06-16 09:17:49 -07004129 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
maruel@chromium.org85616e02014-07-28 15:37:55 +00004130 if not options.fast:
vapiera7fbd5a2016-06-16 09:17:49 -07004131 print('Issue description:')
4132 print(cl.GetDescription(pretty=True))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004133 return 0
4134
4135
maruel@chromium.org39c0b222013-08-17 16:57:01 +00004136def colorize_CMDstatus_doc():
4137 """To be called once in main() to add colors to git cl status help."""
4138 colors = [i for i in dir(Fore) if i[0].isupper()]
4139
4140 def colorize_line(line):
4141 for color in colors:
4142 if color in line.upper():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004143 # Extract whitespace first and the leading '-'.
maruel@chromium.org39c0b222013-08-17 16:57:01 +00004144 indent = len(line) - len(line.lstrip(' ')) + 1
4145 return line[:indent] + getattr(Fore, color) + line[indent:] + Fore.RESET
4146 return line
4147
4148 lines = CMDstatus.__doc__.splitlines()
4149 CMDstatus.__doc__ = '\n'.join(colorize_line(l) for l in lines)
4150
4151
phajdan.jre328cf92016-08-22 04:12:17 -07004152def write_json(path, contents):
Stefan Zager1306bd02017-06-22 19:26:46 -07004153 if path == '-':
4154 json.dump(contents, sys.stdout)
4155 else:
4156 with open(path, 'w') as f:
4157 json.dump(contents, f)
phajdan.jre328cf92016-08-22 04:12:17 -07004158
4159
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004160@subcommand.usage('[issue_number]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004161@metrics.collector.collect_metrics('git cl issue')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004162def CMDissue(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004163 """Sets or displays the current code review issue number.
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004164
4165 Pass issue number 0 to clear the current issue.
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004166 """
dnj@chromium.org406c4402015-03-03 17:22:28 +00004167 parser.add_option('-r', '--reverse', action='store_true',
4168 help='Lookup the branch(es) for the specified issues. If '
4169 'no issues are specified, all branches with mapped '
4170 'issues will be listed.')
Stefan Zager1306bd02017-06-22 19:26:46 -07004171 parser.add_option('--json',
4172 help='Path to JSON output file, or "-" for stdout.')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004173 _add_codereview_select_options(parser)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004174 options, args = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004175 _process_codereview_select_options(parser, options)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004176
dnj@chromium.org406c4402015-03-03 17:22:28 +00004177 if options.reverse:
4178 branches = RunGit(['for-each-ref', 'refs/heads',
Aaron Gablead64abd2017-12-04 09:49:13 -08004179 '--format=%(refname)']).splitlines()
dnj@chromium.org406c4402015-03-03 17:22:28 +00004180 # Reverse issue lookup.
4181 issue_branch_map = {}
Daniel Bratellb56a43a2018-09-06 15:49:03 +00004182
4183 git_config = {}
4184 for config in RunGit(['config', '--get-regexp',
4185 r'branch\..*issue']).splitlines():
4186 name, _space, val = config.partition(' ')
4187 git_config[name] = val
4188
dnj@chromium.org406c4402015-03-03 17:22:28 +00004189 for branch in branches:
Daniel Bratellb56a43a2018-09-06 15:49:03 +00004190 for cls in _CODEREVIEW_IMPLEMENTATIONS.values():
4191 config_key = _git_branch_config_key(ShortBranchName(branch),
4192 cls.IssueConfigKey())
4193 issue = git_config.get(config_key)
4194 if issue:
4195 issue_branch_map.setdefault(int(issue), []).append(branch)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004196 if not args:
4197 args = sorted(issue_branch_map.iterkeys())
phajdan.jre328cf92016-08-22 04:12:17 -07004198 result = {}
dnj@chromium.org406c4402015-03-03 17:22:28 +00004199 for issue in args:
Lei Zhang5a368d42019-03-25 23:18:19 +00004200 try:
4201 issue_num = int(issue)
4202 except ValueError:
4203 print('ERROR cannot parse issue number: %s' % issue, file=sys.stderr)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004204 continue
Lei Zhang5a368d42019-03-25 23:18:19 +00004205 result[issue_num] = issue_branch_map.get(issue_num)
vapiera7fbd5a2016-06-16 09:17:49 -07004206 print('Branch for issue number %s: %s' % (
Lei Zhang5a368d42019-03-25 23:18:19 +00004207 issue, ', '.join(issue_branch_map.get(issue_num) or ('None',))))
phajdan.jre328cf92016-08-22 04:12:17 -07004208 if options.json:
4209 write_json(options.json, result)
Aaron Gable78753da2017-06-15 10:35:49 -07004210 return 0
4211
4212 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00004213 issue = ParseIssueNumberArgument(args[0])
Aaron Gable78753da2017-06-15 10:35:49 -07004214 if not issue.valid:
4215 DieWithError('Pass a url or number to set the issue, 0 to unset it, '
4216 'or no argument to list it.\n'
4217 'Maybe you want to run git cl status?')
Edward Lemurf38bc172019-09-03 21:02:13 +00004218 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07004219 cl.SetIssue(issue.issue)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004220 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00004221 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07004222 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
4223 if options.json:
4224 write_json(options.json, {
4225 'issue': cl.GetIssue(),
4226 'issue_url': cl.GetIssueURL(),
4227 })
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004228 return 0
4229
4230
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004231@metrics.collector.collect_metrics('git cl comments')
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004232def CMDcomments(parser, args):
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004233 """Shows or posts review comments for any changelist."""
4234 parser.add_option('-a', '--add-comment', dest='comment',
4235 help='comment to add to an issue')
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00004236 parser.add_option('-p', '--publish', action='store_true',
4237 help='marks CL as ready and sends comment to reviewers')
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01004238 parser.add_option('-i', '--issue', dest='issue',
Edward Lemurf38bc172019-09-03 21:02:13 +00004239 help='review issue id (defaults to current issue).')
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07004240 parser.add_option('-m', '--machine-readable', dest='readable',
4241 action='store_false', default=True,
4242 help='output comments in a format compatible with '
4243 'editor parsing')
smut@google.comc85ac942015-09-15 16:34:43 +00004244 parser.add_option('-j', '--json-file',
Stefan Zager1306bd02017-06-22 19:26:46 -07004245 help='File to write JSON summary to, or "-" for stdout')
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004246 _add_codereview_select_options(parser)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004247 options, args = parser.parse_args(args)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004248 _process_codereview_select_options(parser, options)
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004249
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004250 issue = None
4251 if options.issue:
4252 try:
4253 issue = int(options.issue)
4254 except ValueError:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004255 DieWithError('A review issue ID is expected to be a number.')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004256
Edward Lemur934836a2019-09-09 20:16:54 +00004257 cl = Changelist(issue=issue)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004258
4259 if options.comment:
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00004260 cl.AddComment(options.comment, options.publish)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004261 return 0
4262
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07004263 summary = sorted(cl.GetCommentsSummary(readable=options.readable),
4264 key=lambda c: c.date)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004265 for comment in summary:
4266 if comment.disapproval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004267 color = Fore.RED
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004268 elif comment.approval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004269 color = Fore.GREEN
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004270 elif comment.sender == cl.GetIssueOwner():
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004271 color = Fore.MAGENTA
Quinten Yearsley0e617c02019-02-20 00:37:03 +00004272 elif comment.autogenerated:
4273 color = Fore.CYAN
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004274 else:
4275 color = Fore.BLUE
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004276 print('\n%s%s %s%s\n%s' % (
4277 color,
4278 comment.date.strftime('%Y-%m-%d %H:%M:%S UTC'),
4279 comment.sender,
4280 Fore.RESET,
4281 '\n'.join(' ' + l for l in comment.message.strip().splitlines())))
4282
smut@google.comc85ac942015-09-15 16:34:43 +00004283 if options.json_file:
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004284 def pre_serialize(c):
4285 dct = c.__dict__.copy()
4286 dct['date'] = dct['date'].strftime('%Y-%m-%d %H:%M:%S.%f')
4287 return dct
Leszek Swirski45b20c42018-09-17 17:05:26 +00004288 write_json(options.json_file, map(pre_serialize, summary))
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004289 return 0
4290
4291
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004292@subcommand.usage('[codereview url or issue id]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004293@metrics.collector.collect_metrics('git cl description')
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004294def CMDdescription(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004295 """Brings up the editor for the current CL's description."""
smut@google.com34fb6b12015-07-13 20:03:26 +00004296 parser.add_option('-d', '--display', action='store_true',
4297 help='Display the description instead of opening an editor')
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004298 parser.add_option('-n', '--new-description',
dnjba1b0f32016-09-02 12:37:42 -07004299 help='New description to set for this issue (- for stdin, '
4300 '+ to load from local commit HEAD)')
dsansomee2d6fd92016-09-08 00:10:47 -07004301 parser.add_option('-f', '--force', action='store_true',
4302 help='Delete any unpublished Gerrit edits for this issue '
4303 'without prompting')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004304
4305 _add_codereview_select_options(parser)
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004306 options, args = parser.parse_args(args)
4307 _process_codereview_select_options(parser, options)
4308
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004309 target_issue_arg = None
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004310 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00004311 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004312 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004313 parser.error('Invalid issue ID or URL.')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004314
Edward Lemur934836a2019-09-09 20:16:54 +00004315 kwargs = {}
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004316 detected_codereview_from_url = False
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004317 if target_issue_arg:
4318 kwargs['issue'] = target_issue_arg.issue
4319 kwargs['codereview_host'] = target_issue_arg.hostname
Edward Lemurf38bc172019-09-03 21:02:13 +00004320 if not args[0].isdigit() and not options.forced_codereview:
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004321 detected_codereview_from_url = True
martiniss6eda05f2016-06-30 10:18:35 -07004322
4323 cl = Changelist(**kwargs)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004324 if not cl.GetIssue():
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004325 assert not detected_codereview_from_url
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004326 DieWithError('This branch has no associated changelist.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004327
4328 if detected_codereview_from_url:
Edward Lemurf38bc172019-09-03 21:02:13 +00004329 logging.info('canonical issue/change URL: %s\n', cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004330
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004331 description = ChangeDescription(cl.GetDescription())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004332
smut@google.com34fb6b12015-07-13 20:03:26 +00004333 if options.display:
vapiera7fbd5a2016-06-16 09:17:49 -07004334 print(description.description)
smut@google.com34fb6b12015-07-13 20:03:26 +00004335 return 0
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004336
4337 if options.new_description:
4338 text = options.new_description
4339 if text == '-':
4340 text = '\n'.join(l.rstrip() for l in sys.stdin)
dnjba1b0f32016-09-02 12:37:42 -07004341 elif text == '+':
4342 base_branch = cl.GetCommonAncestorWithUpstream()
4343 change = cl.GetChange(base_branch, None, local_description=True)
4344 text = change.FullDescriptionText()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004345
4346 description.set_description(text)
4347 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00004348 description.prompt()
Andrii Shyshkalov680253d2017-03-15 21:07:36 +01004349 if cl.GetDescription().strip() != description.description:
dsansomee2d6fd92016-09-08 00:10:47 -07004350 cl.UpdateDescription(description.description, force=options.force)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004351 return 0
4352
4353
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004354@metrics.collector.collect_metrics('git cl lint')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004355def CMDlint(parser, args):
4356 """Runs cpplint on the current changelist."""
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004357 parser.add_option('--filter', action='append', metavar='-x,+y',
4358 help='Comma-separated list of cpplint\'s category-filters')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004359 options, args = parser.parse_args(args)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004360
4361 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08004362 # pylint: disable=protected-access
thestig@chromium.org44202a22014-03-11 19:22:18 +00004363 try:
4364 import cpplint
4365 import cpplint_chromium
4366 except ImportError:
vapiera7fbd5a2016-06-16 09:17:49 -07004367 print('Your depot_tools is missing cpplint.py and/or cpplint_chromium.py.')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004368 return 1
4369
4370 # Change the current working directory before calling lint so that it
4371 # shows the correct base.
4372 previous_cwd = os.getcwd()
4373 os.chdir(settings.GetRoot())
4374 try:
Edward Lemur934836a2019-09-09 20:16:54 +00004375 cl = Changelist()
thestig@chromium.org44202a22014-03-11 19:22:18 +00004376 change = cl.GetChange(cl.GetCommonAncestorWithUpstream(), None)
4377 files = [f.LocalPath() for f in change.AffectedFiles()]
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004378 if not files:
vapiera7fbd5a2016-06-16 09:17:49 -07004379 print('Cannot lint an empty CL')
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004380 return 1
thestig@chromium.org44202a22014-03-11 19:22:18 +00004381
4382 # Process cpplints arguments if any.
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004383 command = args + files
4384 if options.filter:
4385 command = ['--filter=' + ','.join(options.filter)] + command
4386 filenames = cpplint.ParseArguments(command)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004387
4388 white_regex = re.compile(settings.GetLintRegex())
4389 black_regex = re.compile(settings.GetLintIgnoreRegex())
4390 extra_check_functions = [cpplint_chromium.CheckPointerDeclarationWhitespace]
4391 for filename in filenames:
4392 if white_regex.match(filename):
4393 if black_regex.match(filename):
vapiera7fbd5a2016-06-16 09:17:49 -07004394 print('Ignoring file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004395 else:
4396 cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level,
4397 extra_check_functions)
4398 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004399 print('Skipping file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004400 finally:
4401 os.chdir(previous_cwd)
vapiera7fbd5a2016-06-16 09:17:49 -07004402 print('Total errors found: %d\n' % cpplint._cpplint_state.error_count)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004403 if cpplint._cpplint_state.error_count != 0:
4404 return 1
4405 return 0
4406
4407
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004408@metrics.collector.collect_metrics('git cl presubmit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004409def CMDpresubmit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004410 """Runs presubmit tests on the current changelist."""
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004411 parser.add_option('-u', '--upload', action='store_true',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004412 help='Run upload hook instead of the push hook')
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004413 parser.add_option('-f', '--force', action='store_true',
sbc@chromium.org495ad152012-09-04 23:07:42 +00004414 help='Run checks even if tree is dirty')
Aaron Gable8076c282017-11-29 14:39:41 -08004415 parser.add_option('--all', action='store_true',
4416 help='Run checks against all files, not just modified ones')
Edward Lesmes8e282792018-04-03 18:50:29 -04004417 parser.add_option('--parallel', action='store_true',
4418 help='Run all tests specified by input_api.RunTests in all '
4419 'PRESUBMIT files in parallel.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004420 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004421
sbc@chromium.org71437c02015-04-09 19:29:40 +00004422 if not options.force and git_common.is_dirty_git_tree('presubmit'):
vapiera7fbd5a2016-06-16 09:17:49 -07004423 print('use --force to check even if tree is dirty.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004424 return 1
4425
Edward Lemur934836a2019-09-09 20:16:54 +00004426 cl = Changelist()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004427 if args:
4428 base_branch = args[0]
4429 else:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00004430 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004431 base_branch = cl.GetCommonAncestorWithUpstream()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004432
Aaron Gable8076c282017-11-29 14:39:41 -08004433 if options.all:
4434 base_change = cl.GetChange(base_branch, None)
4435 files = [('M', f) for f in base_change.AllFiles()]
4436 change = presubmit_support.GitChange(
4437 base_change.Name(),
4438 base_change.FullDescriptionText(),
4439 base_change.RepositoryRoot(),
4440 files,
4441 base_change.issue,
4442 base_change.patchset,
4443 base_change.author_email,
4444 base_change._upstream)
4445 else:
4446 change = cl.GetChange(base_branch, None)
4447
ilevy@chromium.org051ad0e2013-03-04 21:57:34 +00004448 cl.RunHook(
4449 committing=not options.upload,
4450 may_prompt=False,
4451 verbose=options.verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04004452 change=change,
4453 parallel=options.parallel)
dpranke@chromium.org0a2bb372011-03-25 01:16:22 +00004454 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004455
4456
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004457def GenerateGerritChangeId(message):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004458 """Returns the Change ID footer value (Ixxxxxx...xxx).
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004459
4460 Works the same way as
4461 https://gerrit-review.googlesource.com/tools/hooks/commit-msg
4462 but can be called on demand on all platforms.
4463
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004464 The basic idea is to generate git hash of a state of the tree, original
4465 commit message, author/committer info and timestamps.
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004466 """
4467 lines = []
4468 tree_hash = RunGitSilent(['write-tree'])
4469 lines.append('tree %s' % tree_hash.strip())
4470 code, parent = RunGitWithCode(['rev-parse', 'HEAD~0'], suppress_stderr=False)
4471 if code == 0:
4472 lines.append('parent %s' % parent.strip())
4473 author = RunGitSilent(['var', 'GIT_AUTHOR_IDENT'])
4474 lines.append('author %s' % author.strip())
4475 committer = RunGitSilent(['var', 'GIT_COMMITTER_IDENT'])
4476 lines.append('committer %s' % committer.strip())
4477 lines.append('')
4478 # Note: Gerrit's commit-hook actually cleans message of some lines and
4479 # whitespace. This code is not doing this, but it clearly won't decrease
4480 # entropy.
4481 lines.append(message)
4482 change_hash = RunCommand(['git', 'hash-object', '-t', 'commit', '--stdin'],
Raul Tambreb946b232019-03-26 14:48:46 +00004483 stdin=('\n'.join(lines)).encode())
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004484 return 'I%s' % change_hash.strip()
4485
4486
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01004487def GetTargetRef(remote, remote_branch, target_branch):
wittman@chromium.org455dc922015-01-26 20:15:50 +00004488 """Computes the remote branch ref to use for the CL.
4489
4490 Args:
4491 remote (str): The git remote for the CL.
4492 remote_branch (str): The git remote branch for the CL.
4493 target_branch (str): The target branch specified by the user.
wittman@chromium.org455dc922015-01-26 20:15:50 +00004494 """
4495 if not (remote and remote_branch):
4496 return None
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004497
wittman@chromium.org455dc922015-01-26 20:15:50 +00004498 if target_branch:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004499 # Canonicalize branch references to the equivalent local full symbolic
wittman@chromium.org455dc922015-01-26 20:15:50 +00004500 # refs, which are then translated into the remote full symbolic refs
4501 # below.
4502 if '/' not in target_branch:
4503 remote_branch = 'refs/remotes/%s/%s' % (remote, target_branch)
4504 else:
4505 prefix_replacements = (
4506 ('^((refs/)?remotes/)?branch-heads/', 'refs/remotes/branch-heads/'),
4507 ('^((refs/)?remotes/)?%s/' % remote, 'refs/remotes/%s/' % remote),
4508 ('^(refs/)?heads/', 'refs/remotes/%s/' % remote),
4509 )
4510 match = None
4511 for regex, replacement in prefix_replacements:
4512 match = re.search(regex, target_branch)
4513 if match:
4514 remote_branch = target_branch.replace(match.group(0), replacement)
4515 break
4516 if not match:
4517 # This is a branch path but not one we recognize; use as-is.
4518 remote_branch = target_branch
rmistry@google.comc68112d2015-03-03 12:48:06 +00004519 elif remote_branch in REFS_THAT_ALIAS_TO_OTHER_REFS:
4520 # Handle the refs that need to land in different refs.
4521 remote_branch = REFS_THAT_ALIAS_TO_OTHER_REFS[remote_branch]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004522
wittman@chromium.org455dc922015-01-26 20:15:50 +00004523 # Create the true path to the remote branch.
4524 # Does the following translation:
4525 # * refs/remotes/origin/refs/diff/test -> refs/diff/test
4526 # * refs/remotes/origin/master -> refs/heads/master
4527 # * refs/remotes/branch-heads/test -> refs/branch-heads/test
4528 if remote_branch.startswith('refs/remotes/%s/refs/' % remote):
4529 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, '')
4530 elif remote_branch.startswith('refs/remotes/%s/' % remote):
4531 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote,
4532 'refs/heads/')
4533 elif remote_branch.startswith('refs/remotes/branch-heads'):
4534 remote_branch = remote_branch.replace('refs/remotes/', 'refs/')
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01004535
wittman@chromium.org455dc922015-01-26 20:15:50 +00004536 return remote_branch
4537
4538
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004539def cleanup_list(l):
4540 """Fixes a list so that comma separated items are put as individual items.
4541
4542 So that "--reviewers joe@c,john@c --reviewers joa@c" results in
4543 options.reviewers == sorted(['joe@c', 'john@c', 'joa@c']).
4544 """
4545 items = sum((i.split(',') for i in l), [])
4546 stripped_items = (i.strip() for i in items)
4547 return sorted(filter(None, stripped_items))
4548
4549
Aaron Gable4db38df2017-11-03 14:59:07 -07004550@subcommand.usage('[flags]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004551@metrics.collector.collect_metrics('git cl upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004552def CMDupload(parser, args):
rmistry@google.com78948ed2015-07-08 23:09:57 +00004553 """Uploads the current changelist to codereview.
4554
4555 Can skip dependency patchset uploads for a branch by running:
4556 git config branch.branch_name.skip-deps-uploads True
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004557 To unset, run:
rmistry@google.com78948ed2015-07-08 23:09:57 +00004558 git config --unset branch.branch_name.skip-deps-uploads
4559 Can also set the above globally by using the --global flag.
Dominic Battre7d1c4842017-10-27 09:17:28 +02004560
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004561 If the name of the checked out branch starts with "bug-" or "fix-" followed
4562 by a bug number, this bug number is automatically populated in the CL
Dominic Battre7d1c4842017-10-27 09:17:28 +02004563 description.
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004564
4565 If subject contains text in square brackets or has "<text>: " prefix, such
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004566 text(s) is treated as Gerrit hashtags. For example, CLs with subjects:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004567 [git-cl] add support for hashtags
4568 Foo bar: implement foo
4569 will be hashtagged with "git-cl" and "foo-bar" respectively.
rmistry@google.com78948ed2015-07-08 23:09:57 +00004570 """
ukai@chromium.orge8077812012-02-03 03:41:46 +00004571 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4572 help='bypass upload presubmit hook')
brettw@chromium.orgb65c43c2013-06-10 22:04:49 +00004573 parser.add_option('--bypass-watchlists', action='store_true',
4574 dest='bypass_watchlists',
4575 help='bypass watchlists auto CC-ing reviewers')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004576 parser.add_option('-f', '--force', action='store_true', dest='force',
ukai@chromium.orge8077812012-02-03 03:41:46 +00004577 help="force yes to questions (don't prompt)")
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004578 parser.add_option('--message', '-m', dest='message',
4579 help='message for patchset')
tandriif9aefb72016-07-01 09:06:51 -07004580 parser.add_option('-b', '--bug',
4581 help='pre-populate the bug number(s) for this issue. '
4582 'If several, separate with commas')
tandriib80458a2016-06-23 12:20:07 -07004583 parser.add_option('--message-file', dest='message_file',
4584 help='file which contains message for patchset')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004585 parser.add_option('--title', '-t', dest='title',
4586 help='title for patchset')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004587 parser.add_option('-r', '--reviewers',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004588 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004589 help='reviewer email addresses')
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004590 parser.add_option('--tbrs',
4591 action='append', default=[],
4592 help='TBR email addresses')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004593 parser.add_option('--cc',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004594 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004595 help='cc email addresses')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004596 parser.add_option('--hashtag', dest='hashtags',
4597 action='append', default=[],
4598 help=('Gerrit hashtag for new CL; '
4599 'can be applied multiple times'))
adamk@chromium.org36f47302013-04-05 01:08:31 +00004600 parser.add_option('-s', '--send-mail', action='store_true',
Aaron Gable59f48512017-01-12 10:54:46 -08004601 help='send email to reviewer(s) and cc(s) immediately')
ukai@chromium.org8ef7ab22012-11-28 04:24:52 +00004602 parser.add_option('--target_branch',
pgervais@chromium.orgb9f27512014-08-08 15:52:33 +00004603 '--target-branch',
wittman@chromium.org455dc922015-01-26 20:15:50 +00004604 metavar='TARGET',
4605 help='Apply CL to remote ref TARGET. ' +
4606 'Default: remote branch head, or master')
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004607 parser.add_option('--squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004608 help='Squash multiple commits into one')
Mike Frysingera989d552019-08-14 20:51:23 +00004609 parser.add_option('--no-squash', action='store_false', dest='squash',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004610 help='Don\'t squash multiple commits into one')
rmistry9eadede2016-09-19 11:22:43 -07004611 parser.add_option('--topic', default=None,
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004612 help='Topic to specify when uploading')
Robert Iannuccif2708bd2017-04-17 15:49:02 -07004613 parser.add_option('--tbr-owners', dest='add_owners_to', action='store_const',
4614 const='TBR', help='add a set of OWNERS to TBR')
4615 parser.add_option('--r-owners', dest='add_owners_to', action='store_const',
4616 const='R', help='add a set of OWNERS to R')
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004617 parser.add_option('-c', '--use-commit-queue', action='store_true',
4618 help='tell the CQ to commit this patchset; '
4619 'implies --send-mail')
tandrii@chromium.orgd50452a2015-11-23 16:38:15 +00004620 parser.add_option('-d', '--cq-dry-run', dest='cq_dry_run',
4621 action='store_true',
rmistry@google.comef966222015-04-07 11:15:01 +00004622 help='Send the patchset to do a CQ dry run right after '
4623 'upload.')
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00004624 parser.add_option('--preserve-tryjobs', action='store_true',
4625 help='instruct the CQ to let tryjobs running even after '
4626 'new patchsets are uploaded instead of canceling '
4627 'prior patchset\' tryjobs')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004628 parser.add_option('--dependencies', action='store_true',
4629 help='Uploads CLs of all the local branches that depend on '
4630 'the current branch')
Ravi Mistry31e7d562018-04-02 12:53:57 -04004631 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4632 help='Sends your change to the CQ after an approval. Only '
4633 'works on repos that have the Auto-Submit label '
4634 'enabled')
Edward Lesmes8e282792018-04-03 18:50:29 -04004635 parser.add_option('--parallel', action='store_true',
4636 help='Run all tests specified by input_api.RunTests in all '
4637 'PRESUBMIT files in parallel.')
pgervais@chromium.org91141372014-01-09 23:27:20 +00004638
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004639 parser.add_option('--no-autocc', action='store_true',
4640 help='Disables automatic addition of CC emails')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004641 parser.add_option('--private', action='store_true',
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004642 help='Set the review private. This implies --no-autocc.')
4643
rmistry@google.com2dd99862015-06-22 12:22:18 +00004644 orig_args = args
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004645 _add_codereview_select_options(parser)
ukai@chromium.orge8077812012-02-03 03:41:46 +00004646 (options, args) = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004647 _process_codereview_select_options(parser, options)
ukai@chromium.orge8077812012-02-03 03:41:46 +00004648
sbc@chromium.org71437c02015-04-09 19:29:40 +00004649 if git_common.is_dirty_git_tree('upload'):
ukai@chromium.orge8077812012-02-03 03:41:46 +00004650 return 1
4651
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004652 options.reviewers = cleanup_list(options.reviewers)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004653 options.tbrs = cleanup_list(options.tbrs)
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004654 options.cc = cleanup_list(options.cc)
4655
tandriib80458a2016-06-23 12:20:07 -07004656 if options.message_file:
4657 if options.message:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004658 parser.error('Only one of --message and --message-file allowed.')
tandriib80458a2016-06-23 12:20:07 -07004659 options.message = gclient_utils.FileRead(options.message_file)
4660 options.message_file = None
4661
tandrii4d0545a2016-07-06 03:56:49 -07004662 if options.cq_dry_run and options.use_commit_queue:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004663 parser.error('Only one of --use-commit-queue and --cq-dry-run allowed.')
tandrii4d0545a2016-07-06 03:56:49 -07004664
Aaron Gableedbc4132017-09-11 13:22:28 -07004665 if options.use_commit_queue:
4666 options.send_mail = True
4667
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00004668 # For sanity of test expectations, do this otherwise lazy-loading *now*.
4669 settings.GetIsGerrit()
4670
Edward Lemur934836a2019-09-09 20:16:54 +00004671 cl = Changelist()
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00004672
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00004673 return cl.CMDUpload(options, args, orig_args)
ukai@chromium.orge8077812012-02-03 03:41:46 +00004674
4675
Francois Dorayd42c6812017-05-30 15:10:20 -04004676@subcommand.usage('--description=<description file>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004677@metrics.collector.collect_metrics('git cl split')
Francois Dorayd42c6812017-05-30 15:10:20 -04004678def CMDsplit(parser, args):
4679 """Splits a branch into smaller branches and uploads CLs.
4680
4681 Creates a branch and uploads a CL for each group of files modified in the
4682 current branch that share a common OWNERS file. In the CL description and
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004683 comment, the string '$directory', is replaced with the directory containing
Francois Dorayd42c6812017-05-30 15:10:20 -04004684 the shared OWNERS file.
4685 """
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004686 parser.add_option('-d', '--description', dest='description_file',
4687 help='A text file containing a CL description in which '
4688 '$directory will be replaced by each CL\'s directory.')
4689 parser.add_option('-c', '--comment', dest='comment_file',
4690 help='A text file containing a CL comment.')
4691 parser.add_option('-n', '--dry-run', dest='dry_run', action='store_true',
Chris Watkinsba28e462017-12-13 11:22:17 +11004692 default=False,
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004693 help='List the files and reviewers for each CL that would '
4694 'be created, but don\'t create branches or CLs.')
4695 parser.add_option('--cq-dry-run', action='store_true',
4696 help='If set, will do a cq dry run for each uploaded CL. '
4697 'Please be careful when doing this; more than ~10 CLs '
4698 'has the potential to overload our build '
4699 'infrastructure. Try to upload these not during high '
4700 'load times (usually 11-3 Mountain View time). Email '
4701 'infra-dev@chromium.org with any questions.')
Takuto Ikuta51eca592019-02-14 19:40:52 +00004702 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4703 default=True,
4704 help='Sends your change to the CQ after an approval. Only '
4705 'works on repos that have the Auto-Submit label '
4706 'enabled')
Francois Dorayd42c6812017-05-30 15:10:20 -04004707 options, _ = parser.parse_args(args)
4708
4709 if not options.description_file:
4710 parser.error('No --description flag specified.')
4711
4712 def WrappedCMDupload(args):
4713 return CMDupload(OptionParser(), args)
4714
4715 return split_cl.SplitCl(options.description_file, options.comment_file,
Stephen Martiniscb326682018-08-29 21:06:30 +00004716 Changelist, WrappedCMDupload, options.dry_run,
Takuto Ikuta51eca592019-02-14 19:40:52 +00004717 options.cq_dry_run, options.enable_auto_submit)
Francois Dorayd42c6812017-05-30 15:10:20 -04004718
4719
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004720@subcommand.usage('DEPRECATED')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004721@metrics.collector.collect_metrics('git cl commit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004722def CMDdcommit(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004723 """DEPRECATED: Used to commit the current changelist via git-svn."""
4724 message = ('git-cl no longer supports committing to SVN repositories via '
4725 'git-svn. You probably want to use `git cl land` instead.')
4726 print(message)
4727 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004728
4729
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01004730# Two special branches used by git cl land.
4731MERGE_BRANCH = 'git-cl-commit'
4732CHERRY_PICK_BRANCH = 'git-cl-cherry-pick'
4733
4734
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004735@subcommand.usage('[upstream branch to apply against]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004736@metrics.collector.collect_metrics('git cl land')
pgervais@chromium.orgcee6dc42014-05-07 17:04:03 +00004737def CMDland(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004738 """Commits the current changelist via git.
4739
4740 In case of Gerrit, uses Gerrit REST api to "submit" the issue, which pushes
4741 upstream and closes the issue automatically and atomically.
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004742 """
4743 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4744 help='bypass upload presubmit hook')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004745 parser.add_option('-f', '--force', action='store_true', dest='force',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004746 help="force yes to questions (don't prompt)")
Edward Lesmes67b3faa2018-04-13 17:50:52 -04004747 parser.add_option('--parallel', action='store_true',
4748 help='Run all tests specified by input_api.RunTests in all '
4749 'PRESUBMIT files in parallel.')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004750 (options, args) = parser.parse_args(args)
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004751
Edward Lemur934836a2019-09-09 20:16:54 +00004752 cl = Changelist()
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004753
Robert Iannucci2e73d432018-03-14 01:10:47 -07004754 if not cl.GetIssue():
4755 DieWithError('You must upload the change first to Gerrit.\n'
4756 ' If you would rather have `git cl land` upload '
4757 'automatically for you, see http://crbug.com/642759')
4758 return cl._codereview_impl.CMDLand(options.force, options.bypass_hooks,
Olivier Robin75ee7252018-04-13 10:02:56 +02004759 options.verbose, options.parallel)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004760
4761
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004762@subcommand.usage('<patch url or issue id or issue url>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004763@metrics.collector.collect_metrics('git cl patch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004764def CMDpatch(parser, args):
marq@chromium.orge5e59002013-10-02 23:21:25 +00004765 """Patches in a code review."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004766 parser.add_option('-b', dest='newbranch',
4767 help='create a new branch off trunk for the patch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00004768 parser.add_option('-f', '--force', action='store_true',
Aaron Gable62619a32017-06-16 08:22:09 -07004769 help='overwrite state on the current or chosen branch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004770 parser.add_option('-n', '--no-commit', action='store_true', dest='nocommit',
Edward Lemurf38bc172019-09-03 21:02:13 +00004771 help='don\'t commit after patch applies.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004772
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004773 group = optparse.OptionGroup(
4774 parser,
4775 'Options for continuing work on the current issue uploaded from a '
4776 'different clone (e.g. different machine). Must be used independently '
4777 'from the other options. No issue number should be specified, and the '
4778 'branch must have an issue number associated with it')
4779 group.add_option('--reapply', action='store_true', dest='reapply',
4780 help='Reset the branch and reapply the issue.\n'
4781 'CAUTION: This will undo any local changes in this '
4782 'branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004783
4784 group.add_option('--pull', action='store_true', dest='pull',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004785 help='Performs a pull before reapplying.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004786 parser.add_option_group(group)
4787
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004788 _add_codereview_select_options(parser)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004789 (options, args) = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004790 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004791
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004792 if options.reapply:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004793 if options.newbranch:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004794 parser.error('--reapply works on the current branch only.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004795 if len(args) > 0:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004796 parser.error('--reapply implies no additional arguments.')
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004797
Edward Lemur934836a2019-09-09 20:16:54 +00004798 cl = Changelist()
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004799 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004800 parser.error('Current branch must have an associated issue.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004801
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004802 upstream = cl.GetUpstreamBranch()
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004803 if upstream is None:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004804 parser.error('No upstream branch specified. Cannot reset branch.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004805
4806 RunGit(['reset', '--hard', upstream])
4807 if options.pull:
4808 RunGit(['pull'])
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004809
Edward Lemurf38bc172019-09-03 21:02:13 +00004810 return cl.CMDPatchIssue(cl.GetIssue(), options.nocommit)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004811
4812 if len(args) != 1 or not args[0]:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004813 parser.error('Must specify issue number or URL.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004814
Edward Lemurf38bc172019-09-03 21:02:13 +00004815 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004816 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004817 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004818
4819 cl_kwargs = {
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004820 'codereview_host': target_issue_arg.hostname,
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004821 }
4822 detected_codereview_from_url = False
Edward Lemurf38bc172019-09-03 21:02:13 +00004823 if not args[0].isdigit() and not options.forced_codereview:
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004824 detected_codereview_from_url = True
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004825 cl_kwargs['issue'] = target_issue_arg.issue
4826
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004827 # We don't want uncommitted changes mixed up with the patch.
4828 if git_common.is_dirty_git_tree('patch'):
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004829 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004830
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004831 if options.newbranch:
4832 if options.force:
4833 RunGit(['branch', '-D', options.newbranch],
4834 stderr=subprocess2.PIPE, error_ok=True)
4835 RunGit(['new-branch', options.newbranch])
4836
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004837 cl = Changelist(**cl_kwargs)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004838
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004839 if detected_codereview_from_url:
Edward Lemurf38bc172019-09-03 21:02:13 +00004840 print('canonical issue/change URL: %s\n' % cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004841
Edward Lemurf38bc172019-09-03 21:02:13 +00004842 return cl.CMDPatchWithParsedIssue(
4843 target_issue_arg, options.nocommit, options.force)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004844
4845
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004846def GetTreeStatus(url=None):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004847 """Fetches the tree status and returns either 'open', 'closed',
4848 'unknown' or 'unset'."""
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004849 url = url or settings.GetTreeStatusUrl(error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004850 if url:
4851 status = urllib2.urlopen(url).read().lower()
4852 if status.find('closed') != -1 or status == '0':
4853 return 'closed'
4854 elif status.find('open') != -1 or status == '1':
4855 return 'open'
4856 return 'unknown'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004857 return 'unset'
4858
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004859
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004860def GetTreeStatusReason():
4861 """Fetches the tree status from a json url and returns the message
4862 with the reason for the tree to be opened or closed."""
msb@chromium.orgbf1a7ba2011-02-01 16:21:46 +00004863 url = settings.GetTreeStatusUrl()
4864 json_url = urlparse.urljoin(url, '/current?format=json')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004865 connection = urllib2.urlopen(json_url)
4866 status = json.loads(connection.read())
4867 connection.close()
4868 return status['message']
4869
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004870
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004871@metrics.collector.collect_metrics('git cl tree')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004872def CMDtree(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004873 """Shows the status of the tree."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004874 _, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004875 status = GetTreeStatus()
4876 if 'unset' == status:
vapiera7fbd5a2016-06-16 09:17:49 -07004877 print('You must configure your tree status URL by running "git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004878 return 2
4879
vapiera7fbd5a2016-06-16 09:17:49 -07004880 print('The tree is %s' % status)
4881 print()
4882 print(GetTreeStatusReason())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004883 if status != 'open':
4884 return 1
4885 return 0
4886
4887
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004888@metrics.collector.collect_metrics('git cl try')
maruel@chromium.org15192402012-09-06 12:38:29 +00004889def CMDtry(parser, args):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004890 """Triggers tryjobs using either Buildbucket or CQ dry run."""
4891 group = optparse.OptionGroup(parser, 'Tryjob options')
maruel@chromium.org15192402012-09-06 12:38:29 +00004892 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004893 '-b', '--bot', action='append',
4894 help=('IMPORTANT: specify ONE builder per --bot flag. Use it multiple '
4895 'times to specify multiple builders. ex: '
4896 '"-b win_rel -b win_layout". See '
4897 'the try server waterfall for the builders name and the tests '
4898 'available.'))
maruel@chromium.org15192402012-09-06 12:38:29 +00004899 group.add_option(
borenet6c0efe62016-10-19 08:13:29 -07004900 '-B', '--bucket', default='',
4901 help=('Buildbucket bucket to send the try requests.'))
4902 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004903 '-r', '--revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004904 help='Revision to use for the tryjob; default: the revision will '
tandriif7b29d42016-10-07 08:45:41 -07004905 'be determined by the try recipe that builder runs, which usually '
4906 'defaults to HEAD of origin/master')
maruel@chromium.org15192402012-09-06 12:38:29 +00004907 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004908 '-c', '--clobber', action='store_true', default=False,
tandriif7b29d42016-10-07 08:45:41 -07004909 help='Force a clobber before building; that is don\'t do an '
tandrii1838bad2016-10-06 00:10:52 -07004910 'incremental build')
maruel@chromium.org15192402012-09-06 12:38:29 +00004911 group.add_option(
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08004912 '--category', default='git_cl_try', help='Specify custom build category.')
4913 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004914 '--project',
4915 help='Override which project to use. Projects are defined '
tandriif7b29d42016-10-07 08:45:41 -07004916 'in recipe to determine to which repository or directory to '
4917 'apply the patch')
maruel@chromium.org15192402012-09-06 12:38:29 +00004918 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004919 '-p', '--property', dest='properties', action='append', default=[],
4920 help='Specify generic properties in the form -p key1=value1 -p '
tandriif7b29d42016-10-07 08:45:41 -07004921 'key2=value2 etc. The value will be treated as '
4922 'json if decodable, or as string otherwise. '
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004923 'NOTE: using this may make your tryjob not usable for CQ, '
4924 'which will then schedule another tryjob with default properties')
sheyang@chromium.orgdb375572015-08-17 19:22:23 +00004925 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004926 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4927 help='Host of buildbucket. The default host is %default.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004928 parser.add_option_group(group)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004929 auth.add_auth_options(parser)
Koji Ishii31c14782018-01-08 17:17:33 +09004930 _add_codereview_issue_select_options(parser)
maruel@chromium.org15192402012-09-06 12:38:29 +00004931 options, args = parser.parse_args(args)
Edward Lemurf38bc172019-09-03 21:02:13 +00004932 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004933 auth_config = auth.extract_auth_config_from_options(options)
maruel@chromium.org15192402012-09-06 12:38:29 +00004934
machenbach@chromium.org45453142015-09-15 08:45:22 +00004935 # Make sure that all properties are prop=value pairs.
4936 bad_params = [x for x in options.properties if '=' not in x]
4937 if bad_params:
4938 parser.error('Got properties with missing "=": %s' % bad_params)
4939
maruel@chromium.org15192402012-09-06 12:38:29 +00004940 if args:
4941 parser.error('Unknown arguments: %s' % args)
4942
Edward Lemur934836a2019-09-09 20:16:54 +00004943 cl = Changelist(issue=options.issue)
maruel@chromium.org15192402012-09-06 12:38:29 +00004944 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004945 parser.error('Need to upload first.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004946
Edward Lemurf38bc172019-09-03 21:02:13 +00004947 # HACK: warm up Gerrit change detail cache to save on RPCs.
4948 cl._codereview_impl._GetChangeDetail(['DETAILED_ACCOUNTS', 'ALL_REVISIONS'])
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01004949
tandriie113dfd2016-10-11 10:20:12 -07004950 error_message = cl.CannotTriggerTryJobReason()
4951 if error_message:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004952 parser.error('Can\'t trigger tryjobs: %s' % error_message)
jrobbins@chromium.org16f10f72014-06-24 22:14:36 +00004953
qyearsley1fdfcb62016-10-24 13:22:03 -07004954 buckets = _get_bucket_map(cl, options, parser)
phajdan.jr@chromium.org8da7f272014-03-14 01:28:39 +00004955
qyearsleydd49f942016-10-28 11:57:22 -07004956 # If no bots are listed and we couldn't get a list based on PRESUBMIT files,
4957 # then we default to triggering a CQ dry run (see http://crbug.com/625697).
qyearsley1fdfcb62016-10-24 13:22:03 -07004958 if not buckets:
qyearsley1fdfcb62016-10-24 13:22:03 -07004959 if options.verbose:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07004960 print('git cl try with no bots now defaults to CQ dry run.')
4961 print('Scheduling CQ dry run on: %s' % cl.GetIssueURL())
4962 return cl.SetCQState(_CQState.DRY_RUN)
stip@chromium.org43064fd2013-12-18 20:07:44 +00004963
borenet6c0efe62016-10-19 08:13:29 -07004964 for builders in buckets.itervalues():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00004965 if any('triggered' in b for b in builders):
vapiera7fbd5a2016-06-16 09:17:49 -07004966 print('ERROR You are trying to send a job to a triggered bot. This type '
tandriide281ae2016-10-12 06:02:30 -07004967 'of bot requires an initial job from a parent (usually a builder). '
4968 'Instead send your job to the parent.\n'
vapiera7fbd5a2016-06-16 09:17:49 -07004969 'Bot list: %s' % builders, file=sys.stderr)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00004970 return 1
ilevy@chromium.orgf3b21232012-09-24 20:48:55 +00004971
ilevy@chromium.org36e420b2013-08-06 23:21:12 +00004972 patchset = cl.GetMostRecentPatchset()
tandrii568043b2016-10-11 07:49:18 -07004973 try:
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08004974 _trigger_try_jobs(auth_config, cl, buckets, options, patchset)
tandrii568043b2016-10-11 07:49:18 -07004975 except BuildbucketResponseException as ex:
4976 print('ERROR: %s' % ex)
4977 return 1
maruel@chromium.org15192402012-09-06 12:38:29 +00004978 return 0
4979
4980
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004981@metrics.collector.collect_metrics('git cl try-results')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004982def CMDtry_results(parser, args):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00004983 """Prints info about results for tryjobs associated with the current CL."""
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004984 group = optparse.OptionGroup(parser, 'Tryjob results options')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004985 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004986 '-p', '--patchset', type=int, help='patchset number if not current.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004987 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004988 '--print-master', action='store_true', help='print master name as well.')
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +00004989 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004990 '--color', action='store_true', default=setup_color.IS_TTY,
4991 help='force color output, useful when piping output.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004992 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004993 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4994 help='Host of buildbucket. The default host is %default.')
qyearsley53f48a12016-09-01 10:45:13 -07004995 group.add_option(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004996 '--json', help=('Path of JSON output file to write tryjob results to,'
Stefan Zager1306bd02017-06-22 19:26:46 -07004997 'or "-" for stdout.'))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004998 parser.add_option_group(group)
4999 auth.add_auth_options(parser)
Stefan Zager27db3f22017-10-10 15:15:01 -07005000 _add_codereview_issue_select_options(parser)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005001 options, args = parser.parse_args(args)
Edward Lemurf38bc172019-09-03 21:02:13 +00005002 _process_codereview_select_options(parser, options)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005003 if args:
5004 parser.error('Unrecognized args: %s' % ' '.join(args))
5005
5006 auth_config = auth.extract_auth_config_from_options(options)
Edward Lemur934836a2019-09-09 20:16:54 +00005007 cl = Changelist(issue=options.issue)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005008 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005009 parser.error('Need to upload first.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005010
tandrii221ab252016-10-06 08:12:04 -07005011 patchset = options.patchset
5012 if not patchset:
5013 patchset = cl.GetMostRecentPatchset()
5014 if not patchset:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005015 parser.error('Code review host doesn\'t know about issue %s. '
tandrii221ab252016-10-06 08:12:04 -07005016 'No access to issue or wrong issue number?\n'
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005017 'Either upload first, or pass --patchset explicitly.' %
tandrii221ab252016-10-06 08:12:04 -07005018 cl.GetIssue())
5019
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005020 try:
tandrii221ab252016-10-06 08:12:04 -07005021 jobs = fetch_try_jobs(auth_config, cl, options.buildbucket_host, patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005022 except BuildbucketResponseException as ex:
vapiera7fbd5a2016-06-16 09:17:49 -07005023 print('Buildbucket error: %s' % ex)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005024 return 1
qyearsley53f48a12016-09-01 10:45:13 -07005025 if options.json:
5026 write_try_results_json(options.json, jobs)
5027 else:
5028 print_try_jobs(options, jobs)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005029 return 0
5030
5031
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005032@subcommand.usage('[new upstream branch]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005033@metrics.collector.collect_metrics('git cl upstream')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005034def CMDupstream(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005035 """Prints or sets the name of the upstream branch, if any."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00005036 _, args = parser.parse_args(args)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005037 if len(args) > 1:
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005038 parser.error('Unrecognized args: %s' % ' '.join(args))
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005039
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005040 cl = Changelist()
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005041 if args:
5042 # One arg means set upstream branch.
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00005043 branch = cl.GetBranch()
stip7a3dd352016-09-22 17:32:28 -07005044 RunGit(['branch', '--set-upstream-to', args[0], branch])
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005045 cl = Changelist()
vapiera7fbd5a2016-06-16 09:17:49 -07005046 print('Upstream branch set to %s' % (cl.GetUpstreamBranch(),))
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00005047
5048 # Clear configured merge-base, if there is one.
5049 git_common.remove_merge_base(branch)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005050 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005051 print(cl.GetUpstreamBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005052 return 0
5053
5054
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005055@metrics.collector.collect_metrics('git cl web')
thestig@chromium.org00858c82013-12-02 23:08:03 +00005056def CMDweb(parser, args):
5057 """Opens the current CL in the web browser."""
5058 _, args = parser.parse_args(args)
5059 if args:
5060 parser.error('Unrecognized args: %s' % ' '.join(args))
5061
5062 issue_url = Changelist().GetIssueURL()
5063 if not issue_url:
vapiera7fbd5a2016-06-16 09:17:49 -07005064 print('ERROR No issue to open', file=sys.stderr)
thestig@chromium.org00858c82013-12-02 23:08:03 +00005065 return 1
5066
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00005067 # Redirect I/O before invoking browser to hide its output. For example, this
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005068 # allows us to hide the "Created new window in existing browser session."
5069 # message from Chrome. Based on https://stackoverflow.com/a/2323563.
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00005070 saved_stdout = os.dup(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00005071 saved_stderr = os.dup(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00005072 os.close(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00005073 os.close(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00005074 os.open(os.devnull, os.O_RDWR)
5075 try:
5076 webbrowser.open(issue_url)
5077 finally:
5078 os.dup2(saved_stdout, 1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00005079 os.dup2(saved_stderr, 2)
thestig@chromium.org00858c82013-12-02 23:08:03 +00005080 return 0
5081
5082
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005083@metrics.collector.collect_metrics('git cl set-commit')
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005084def CMDset_commit(parser, args):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00005085 """Sets the commit bit to trigger the CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005086 parser.add_option('-d', '--dry-run', action='store_true',
5087 help='trigger in dry run mode')
5088 parser.add_option('-c', '--clear', action='store_true',
5089 help='stop CQ run, if any')
iannuccie53c9352016-08-17 14:40:40 -07005090 _add_codereview_issue_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005091 options, args = parser.parse_args(args)
Edward Lemurf38bc172019-09-03 21:02:13 +00005092 _process_codereview_select_options(parser, options)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005093 if args:
5094 parser.error('Unrecognized args: %s' % ' '.join(args))
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005095 if options.dry_run and options.clear:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005096 parser.error('Only one of --dry-run and --clear are allowed.')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005097
Edward Lemur934836a2019-09-09 20:16:54 +00005098 cl = Changelist(issue=options.issue)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005099 if options.clear:
tandriid9e5ce52016-07-13 02:32:59 -07005100 state = _CQState.NONE
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005101 elif options.dry_run:
5102 state = _CQState.DRY_RUN
5103 else:
5104 state = _CQState.COMMIT
5105 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005106 parser.error('Must upload the issue first.')
tandrii9de9ec62016-07-13 03:01:59 -07005107 cl.SetCQState(state)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005108 return 0
5109
5110
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005111@metrics.collector.collect_metrics('git cl set-close')
groby@chromium.org411034a2013-02-26 15:12:01 +00005112def CMDset_close(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005113 """Closes the issue."""
iannuccie53c9352016-08-17 14:40:40 -07005114 _add_codereview_issue_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005115 options, args = parser.parse_args(args)
Edward Lemurf38bc172019-09-03 21:02:13 +00005116 _process_codereview_select_options(parser, options)
groby@chromium.org411034a2013-02-26 15:12:01 +00005117 if args:
5118 parser.error('Unrecognized args: %s' % ' '.join(args))
Edward Lemur934836a2019-09-09 20:16:54 +00005119 cl = Changelist(issue=options.issue)
groby@chromium.org411034a2013-02-26 15:12:01 +00005120 # Ensure there actually is an issue to close.
Aaron Gable7139a4e2017-09-05 17:53:09 -07005121 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005122 DieWithError('ERROR: No issue to close.')
groby@chromium.org411034a2013-02-26 15:12:01 +00005123 cl.CloseIssue()
5124 return 0
5125
5126
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005127@metrics.collector.collect_metrics('git cl diff')
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005128def CMDdiff(parser, args):
wychen@chromium.org37b2ec02015-04-03 00:49:15 +00005129 """Shows differences between local tree and last upload."""
thomasanderson074beb22016-08-29 14:03:20 -07005130 parser.add_option(
5131 '--stat',
5132 action='store_true',
5133 dest='stat',
5134 help='Generate a diffstat')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005135 options, args = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005136 if args:
5137 parser.error('Unrecognized args: %s' % ' '.join(args))
wychen@chromium.org46309bf2015-04-03 21:04:49 +00005138
Edward Lemur934836a2019-09-09 20:16:54 +00005139 cl = Changelist()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00005140 issue = cl.GetIssue()
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005141 branch = cl.GetBranch()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00005142 if not issue:
5143 DieWithError('No issue found for current branch (%s)' % branch)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005144
Aaron Gablea718c3e2017-08-28 17:47:28 -07005145 base = cl._GitGetBranchConfigValue('last-upload-hash')
5146 if not base:
5147 base = cl._GitGetBranchConfigValue('gerritsquashhash')
5148 if not base:
5149 detail = cl._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
5150 revision_info = detail['revisions'][detail['current_revision']]
5151 fetch_info = revision_info['fetch']['http']
5152 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
5153 base = 'FETCH_HEAD'
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005154
Aaron Gablea718c3e2017-08-28 17:47:28 -07005155 cmd = ['git', 'diff']
5156 if options.stat:
5157 cmd.append('--stat')
5158 cmd.append(base)
5159 subprocess2.check_call(cmd)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005160
5161 return 0
5162
5163
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005164@metrics.collector.collect_metrics('git cl owners')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005165def CMDowners(parser, args):
Dirk Prankebf980882017-09-02 15:08:00 -07005166 """Finds potential owners for reviewing."""
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005167 parser.add_option(
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00005168 '--ignore-current',
5169 action='store_true',
5170 help='Ignore the CL\'s current reviewers and start from scratch.')
5171 parser.add_option(
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00005172 '--ignore-self',
5173 action='store_true',
5174 help='Do not consider CL\'s author as an owners.')
5175 parser.add_option(
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005176 '--no-color',
5177 action='store_true',
5178 help='Use this option to disable color output')
Dirk Prankebf980882017-09-02 15:08:00 -07005179 parser.add_option(
5180 '--batch',
5181 action='store_true',
5182 help='Do not run interactively, just suggest some')
Yang Guo6e269a02019-06-26 11:17:02 +00005183 # TODO: Consider moving this to another command, since other
5184 # git-cl owners commands deal with owners for a given CL.
5185 parser.add_option(
5186 '--show-all',
5187 action='store_true',
5188 help='Show all owners for a particular file')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005189 options, args = parser.parse_args(args)
5190
5191 author = RunGit(['config', 'user.email']).strip() or None
5192
Edward Lemur934836a2019-09-09 20:16:54 +00005193 cl = Changelist()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005194
Yang Guo6e269a02019-06-26 11:17:02 +00005195 if options.show_all:
5196 for arg in args:
5197 base_branch = cl.GetCommonAncestorWithUpstream()
5198 change = cl.GetChange(base_branch, None)
5199 database = owners.Database(change.RepositoryRoot(), file, os.path)
5200 database.load_data_needed_for([arg])
5201 print('Owners for %s:' % arg)
5202 for owner in sorted(database.all_possible_owners([arg], None)):
5203 print(' - %s' % owner)
5204 return 0
5205
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005206 if args:
5207 if len(args) > 1:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005208 parser.error('Unknown args.')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005209 base_branch = args[0]
5210 else:
5211 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005212 base_branch = cl.GetCommonAncestorWithUpstream()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005213
5214 change = cl.GetChange(base_branch, None)
Dirk Prankebf980882017-09-02 15:08:00 -07005215 affected_files = [f.LocalPath() for f in change.AffectedFiles()]
5216
5217 if options.batch:
5218 db = owners.Database(change.RepositoryRoot(), file, os.path)
5219 print('\n'.join(db.reviewers_for(affected_files, author)))
5220 return 0
5221
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005222 return owners_finder.OwnersFinder(
Dirk Prankebf980882017-09-02 15:08:00 -07005223 affected_files,
Jochen Eisinger72606f82017-04-04 10:44:18 +02005224 change.RepositoryRoot(),
Edward Lemur707d70b2018-02-07 00:50:14 +01005225 author,
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00005226 [] if options.ignore_current else cl.GetReviewers(),
Edward Lemur707d70b2018-02-07 00:50:14 +01005227 fopen=file, os_path=os.path,
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02005228 disable_color=options.no_color,
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00005229 override_files=change.OriginalOwnersFiles(),
5230 ignore_author=options.ignore_self).run()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005231
5232
Aiden Bennerc08566e2018-10-03 17:52:42 +00005233def BuildGitDiffCmd(diff_type, upstream_commit, args, allow_prefix=False):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005234 """Generates a diff command."""
5235 # Generate diff for the current branch's changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +00005236 diff_cmd = ['-c', 'core.quotePath=false', 'diff', '--no-ext-diff']
5237
Aiden Benner6c18a1a2018-11-23 20:18:23 +00005238 if allow_prefix:
5239 # explicitly setting --src-prefix and --dst-prefix is necessary in the
5240 # case that diff.noprefix is set in the user's git config.
5241 diff_cmd += ['--src-prefix=a/', '--dst-prefix=b/']
5242 else:
Aiden Bennerc08566e2018-10-03 17:52:42 +00005243 diff_cmd += ['--no-prefix']
5244
5245 diff_cmd += [diff_type, upstream_commit, '--']
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005246
5247 if args:
5248 for arg in args:
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005249 if os.path.isdir(arg) or os.path.isfile(arg):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005250 diff_cmd.append(arg)
5251 else:
5252 DieWithError('Argument "%s" is not a file or a directory' % arg)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005253
5254 return diff_cmd
5255
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005256
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005257def MatchingFileType(file_name, extensions):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00005258 """Returns True if the file name ends with one of the given extensions."""
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005259 return bool([ext for ext in extensions if file_name.lower().endswith(ext)])
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005260
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005261
enne@chromium.org555cfe42014-01-29 18:21:39 +00005262@subcommand.usage('[files or directories to diff]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005263@metrics.collector.collect_metrics('git cl format')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005264def CMDformat(parser, args):
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005265 """Runs auto-formatting tools (clang-format etc.) on the diff."""
Christopher Lamc5ba6922017-01-24 11:19:14 +11005266 CLANG_EXTS = ['.cc', '.cpp', '.h', '.m', '.mm', '.proto', '.java']
kylechar58edce22016-06-17 06:07:51 -07005267 GN_EXTS = ['.gn', '.gni', '.typemap']
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00005268 parser.add_option('--full', action='store_true',
5269 help='Reformat the full content of all touched files')
5270 parser.add_option('--dry-run', action='store_true',
5271 help='Don\'t modify any file on disk.')
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005272 parser.add_option(
5273 '--python',
5274 action='store_true',
5275 default=None,
5276 help='Enables python formatting on all python files.')
5277 parser.add_option(
5278 '--no-python',
5279 action='store_true',
5280 dest='python',
5281 help='Disables python formatting on all python files. '
5282 'Takes precedence over --python. '
5283 'If neither --python or --no-python are set, python '
5284 'files that have a .style.yapf file in an ancestor '
5285 'directory will be formatted.')
Christopher Lamc5ba6922017-01-24 11:19:14 +11005286 parser.add_option('--js', action='store_true',
5287 help='Format javascript code with clang-format.')
wittman@chromium.org04d5a222014-03-07 18:30:42 +00005288 parser.add_option('--diff', action='store_true',
5289 help='Print diff to stdout rather than modifying files.')
Ilya Shermane081cbe2017-08-15 17:51:04 -07005290 parser.add_option('--presubmit', action='store_true',
5291 help='Used when running the script from a presubmit.')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005292 opts, args = parser.parse_args(args)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005293
Daniel Chengc55eecf2016-12-30 03:11:02 -08005294 # Normalize any remaining args against the current path, so paths relative to
5295 # the current directory are still resolved as expected.
5296 args = [os.path.join(os.getcwd(), arg) for arg in args]
5297
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005298 # git diff generates paths against the root of the repository. Change
5299 # to that directory so clang-format can find files even within subdirs.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005300 rel_base_path = settings.GetRelativeRoot()
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005301 if rel_base_path:
5302 os.chdir(rel_base_path)
5303
digit@chromium.org29e47272013-05-17 17:01:46 +00005304 # Grab the merge-base commit, i.e. the upstream commit of the current
5305 # branch when it was created or the last time it was rebased. This is
5306 # to cover the case where the user may have called "git fetch origin",
5307 # moving the origin branch to a newer commit, but hasn't rebased yet.
5308 upstream_commit = None
5309 cl = Changelist()
5310 upstream_branch = cl.GetUpstreamBranch()
5311 if upstream_branch:
5312 upstream_commit = RunGit(['merge-base', 'HEAD', upstream_branch])
5313 upstream_commit = upstream_commit.strip()
5314
5315 if not upstream_commit:
5316 DieWithError('Could not find base commit for this branch. '
5317 'Are you in detached state?')
5318
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005319 changed_files_cmd = BuildGitDiffCmd('--name-only', upstream_commit, args)
5320 diff_output = RunGit(changed_files_cmd)
5321 diff_files = diff_output.splitlines()
jkarlin@chromium.orgad21b922016-01-28 17:48:42 +00005322 # Filter out files deleted by this CL
5323 diff_files = [x for x in diff_files if os.path.isfile(x)]
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005324
Christopher Lamc5ba6922017-01-24 11:19:14 +11005325 if opts.js:
Deepanjan Roy605dd312018-07-02 17:48:54 +00005326 CLANG_EXTS.extend(['.js', '.ts'])
Christopher Lamc5ba6922017-01-24 11:19:14 +11005327
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005328 clang_diff_files = [x for x in diff_files if MatchingFileType(x, CLANG_EXTS)]
5329 python_diff_files = [x for x in diff_files if MatchingFileType(x, ['.py'])]
5330 dart_diff_files = [x for x in diff_files if MatchingFileType(x, ['.dart'])]
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005331 gn_diff_files = [x for x in diff_files if MatchingFileType(x, GN_EXTS)]
digit@chromium.org29e47272013-05-17 17:01:46 +00005332
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +00005333 top_dir = os.path.normpath(
5334 RunGit(["rev-parse", "--show-toplevel"]).rstrip('\n'))
5335
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005336 # Set to 2 to signal to CheckPatchFormatted() that this patch isn't
5337 # formatted. This is used to block during the presubmit.
5338 return_value = 0
5339
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005340 if clang_diff_files:
techtonik@gmail.com5573df12016-04-12 18:34:10 +00005341 # Locate the clang-format binary in the checkout
5342 try:
5343 clang_format_tool = clang_format.FindClangFormatToolInChromiumTree()
vapierfd77ac72016-06-16 08:33:57 -07005344 except clang_format.NotFoundError as e:
techtonik@gmail.com5573df12016-04-12 18:34:10 +00005345 DieWithError(e)
5346
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005347 if opts.full:
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005348 cmd = [clang_format_tool]
5349 if not opts.dry_run and not opts.diff:
5350 cmd.append('-i')
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005351 stdout = RunCommand(cmd + clang_diff_files, cwd=top_dir)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005352 if opts.diff:
5353 sys.stdout.write(stdout)
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005354 else:
5355 env = os.environ.copy()
5356 env['PATH'] = str(os.path.dirname(clang_format_tool))
5357 try:
5358 script = clang_format.FindClangFormatScriptInChromiumTree(
5359 'clang-format-diff.py')
vapierfd77ac72016-06-16 08:33:57 -07005360 except clang_format.NotFoundError as e:
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005361 DieWithError(e)
digit@chromium.orgd6ddc1c2013-10-25 15:36:32 +00005362
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005363 cmd = [sys.executable, script, '-p0']
5364 if not opts.dry_run and not opts.diff:
5365 cmd.append('-i')
digit@chromium.orgd6ddc1c2013-10-25 15:36:32 +00005366
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005367 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, clang_diff_files)
5368 diff_output = RunGit(diff_cmd)
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005369
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005370 stdout = RunCommand(cmd, stdin=diff_output, cwd=top_dir, env=env)
5371 if opts.diff:
5372 sys.stdout.write(stdout)
5373 if opts.dry_run and len(stdout) > 0:
5374 return_value = 2
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005375
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005376 # Similar code to above, but using yapf on .py files rather than clang-format
5377 # on C/C++ files
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005378 py_explicitly_disabled = opts.python is not None and not opts.python
5379 if python_diff_files and not py_explicitly_disabled:
Aiden Bennere47ac152018-11-20 16:44:03 +00005380 depot_tools_path = os.path.dirname(os.path.abspath(__file__))
5381 yapf_tool = os.path.join(depot_tools_path, 'yapf')
5382 if sys.platform.startswith('win'):
5383 yapf_tool += '.bat'
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005384
Aiden Bennerc08566e2018-10-03 17:52:42 +00005385 # If we couldn't find a yapf file we'll default to the chromium style
5386 # specified in depot_tools.
Aiden Bennerc08566e2018-10-03 17:52:42 +00005387 chromium_default_yapf_style = os.path.join(depot_tools_path,
5388 YAPF_CONFIG_FILENAME)
Aiden Bennerc08566e2018-10-03 17:52:42 +00005389 # Used for caching.
5390 yapf_configs = {}
5391 for f in python_diff_files:
5392 # Find the yapf style config for the current file, defaults to depot
5393 # tools default.
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005394 _FindYapfConfigFile(f, yapf_configs, top_dir)
5395
5396 # Turn on python formatting by default if a yapf config is specified.
5397 # This breaks in the case of this repo though since the specified
5398 # style file is also the global default.
5399 if opts.python is None:
5400 filtered_py_files = []
5401 for f in python_diff_files:
5402 if _FindYapfConfigFile(f, yapf_configs, top_dir) is not None:
5403 filtered_py_files.append(f)
5404 else:
5405 filtered_py_files = python_diff_files
5406
5407 # Note: yapf still seems to fix indentation of the entire file
5408 # even if line ranges are specified.
5409 # See https://github.com/google/yapf/issues/499
5410 if not opts.full and filtered_py_files:
5411 py_line_diffs = _ComputeDiffLineRanges(filtered_py_files, upstream_commit)
5412
5413 for f in filtered_py_files:
5414 yapf_config = _FindYapfConfigFile(f, yapf_configs, top_dir)
5415 if yapf_config is None:
5416 yapf_config = chromium_default_yapf_style
Aiden Bennerc08566e2018-10-03 17:52:42 +00005417
5418 cmd = [yapf_tool, '--style', yapf_config, f]
5419
5420 has_formattable_lines = False
5421 if not opts.full:
5422 # Only run yapf over changed line ranges.
5423 for diff_start, diff_len in py_line_diffs[f]:
5424 diff_end = diff_start + diff_len - 1
5425 # Yapf errors out if diff_end < diff_start but this
5426 # is a valid line range diff for a removal.
5427 if diff_end >= diff_start:
5428 has_formattable_lines = True
5429 cmd += ['-l', '{}-{}'.format(diff_start, diff_end)]
5430 # If all line diffs were removals we have nothing to format.
5431 if not has_formattable_lines:
5432 continue
5433
5434 if opts.diff or opts.dry_run:
5435 cmd += ['--diff']
5436 # Will return non-zero exit code if non-empty diff.
5437 stdout = RunCommand(cmd, error_ok=True, cwd=top_dir)
5438 if opts.diff:
5439 sys.stdout.write(stdout)
5440 elif len(stdout) > 0:
5441 return_value = 2
5442 else:
5443 cmd += ['-i']
5444 RunCommand(cmd, cwd=top_dir)
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005445
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005446 # Dart's formatter does not have the nice property of only operating on
5447 # modified chunks, so hard code full.
5448 if dart_diff_files:
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005449 try:
5450 command = [dart_format.FindDartFmtToolInChromiumTree()]
5451 if not opts.dry_run and not opts.diff:
5452 command.append('-w')
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005453 command.extend(dart_diff_files)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005454
ppi@chromium.org6593d932016-03-03 15:41:15 +00005455 stdout = RunCommand(command, cwd=top_dir)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005456 if opts.dry_run and stdout:
5457 return_value = 2
5458 except dart_format.NotFoundError as e:
vapiera7fbd5a2016-06-16 09:17:49 -07005459 print('Warning: Unable to check Dart code formatting. Dart SDK not '
5460 'found in this checkout. Files in other languages are still '
5461 'formatted.')
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005462
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005463 # Format GN build files. Always run on full build files for canonical form.
5464 if gn_diff_files:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005465 cmd = ['gn', 'format']
brettw4b8ed592016-08-05 16:19:12 -07005466 if opts.dry_run or opts.diff:
5467 cmd.append('--dry-run')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005468 for gn_diff_file in gn_diff_files:
brettw4b8ed592016-08-05 16:19:12 -07005469 gn_ret = subprocess2.call(cmd + [gn_diff_file],
5470 shell=sys.platform == 'win32',
5471 cwd=top_dir)
5472 if opts.dry_run and gn_ret == 2:
5473 return_value = 2 # Not formatted.
5474 elif opts.diff and gn_ret == 2:
5475 # TODO this should compute and print the actual diff.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005476 print('This change has GN build file diff for ' + gn_diff_file)
brettw4b8ed592016-08-05 16:19:12 -07005477 elif gn_ret != 0:
5478 # For non-dry run cases (and non-2 return values for dry-run), a
5479 # nonzero error code indicates a failure, probably because the file
5480 # doesn't parse.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005481 DieWithError('gn format failed on ' + gn_diff_file +
5482 '\nTry running `gn format` on this file manually.')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005483
Ilya Shermane081cbe2017-08-15 17:51:04 -07005484 # Skip the metrics formatting from the global presubmit hook. These files have
5485 # a separate presubmit hook that issues an error if the files need formatting,
5486 # whereas the top-level presubmit script merely issues a warning. Formatting
5487 # these files is somewhat slow, so it's important not to duplicate the work.
5488 if not opts.presubmit:
5489 for xml_dir in GetDirtyMetricsDirs(diff_files):
5490 tool_dir = os.path.join(top_dir, xml_dir)
5491 cmd = [os.path.join(tool_dir, 'pretty_print.py'), '--non-interactive']
5492 if opts.dry_run or opts.diff:
5493 cmd.append('--diff')
Ilya Sherman235b70d2017-08-22 17:46:38 -07005494 stdout = RunCommand(cmd, cwd=top_dir)
Ilya Shermane081cbe2017-08-15 17:51:04 -07005495 if opts.diff:
5496 sys.stdout.write(stdout)
5497 if opts.dry_run and stdout:
5498 return_value = 2 # Not formatted.
Alexei Svitkinef3cac412017-02-06 11:08:50 -05005499
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005500 return return_value
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005501
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005502
Steven Holte2e664bf2017-04-21 13:10:47 -07005503def GetDirtyMetricsDirs(diff_files):
5504 xml_diff_files = [x for x in diff_files if MatchingFileType(x, ['.xml'])]
5505 metrics_xml_dirs = [
5506 os.path.join('tools', 'metrics', 'actions'),
5507 os.path.join('tools', 'metrics', 'histograms'),
5508 os.path.join('tools', 'metrics', 'rappor'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005509 os.path.join('tools', 'metrics', 'ukm'),
5510 ]
Steven Holte2e664bf2017-04-21 13:10:47 -07005511 for xml_dir in metrics_xml_dirs:
5512 if any(file.startswith(xml_dir) for file in xml_diff_files):
5513 yield xml_dir
5514
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005515
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005516@subcommand.usage('<codereview url or issue id>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005517@metrics.collector.collect_metrics('git cl checkout')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005518def CMDcheckout(parser, args):
Edward Lemurf38bc172019-09-03 21:02:13 +00005519 """Checks out a branch associated with a given Gerrit issue."""
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005520 _, args = parser.parse_args(args)
5521
5522 if len(args) != 1:
5523 parser.print_help()
5524 return 1
5525
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005526 issue_arg = ParseIssueNumberArgument(args[0])
tandrii@chromium.orgde6c9a12016-04-11 15:33:53 +00005527 if not issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005528 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005529
tandrii@chromium.orgabd27e52016-04-11 15:43:32 +00005530 target_issue = str(issue_arg.issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005531
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005532 def find_issues(issueprefix):
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00005533 output = RunGit(['config', '--local', '--get-regexp',
5534 r'branch\..*\.%s' % issueprefix],
5535 error_ok=True)
5536 for key, issue in [x.split() for x in output.splitlines()]:
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005537 if issue == target_issue:
5538 yield re.sub(r'branch\.(.*)\.%s' % issueprefix, r'\1', key)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005539
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005540 branches = []
5541 for cls in _CODEREVIEW_IMPLEMENTATIONS.values():
tandrii5d48c322016-08-18 16:19:37 -07005542 branches.extend(find_issues(cls.IssueConfigKey()))
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005543 if len(branches) == 0:
vapiera7fbd5a2016-06-16 09:17:49 -07005544 print('No branch found for issue %s.' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005545 return 1
5546 if len(branches) == 1:
5547 RunGit(['checkout', branches[0]])
5548 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005549 print('Multiple branches match issue %s:' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005550 for i in range(len(branches)):
vapiera7fbd5a2016-06-16 09:17:49 -07005551 print('%d: %s' % (i, branches[i]))
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005552 which = raw_input('Choose by index: ')
5553 try:
5554 RunGit(['checkout', branches[int(which)]])
5555 except (IndexError, ValueError):
vapiera7fbd5a2016-06-16 09:17:49 -07005556 print('Invalid selection, not checking out any branch.')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005557 return 1
5558
5559 return 0
5560
5561
maruel@chromium.org29404b52014-09-08 22:58:00 +00005562def CMDlol(parser, args):
5563 # This command is intentionally undocumented.
vapiera7fbd5a2016-06-16 09:17:49 -07005564 print(zlib.decompress(base64.b64decode(
thakis@chromium.org3421c992014-11-02 02:20:32 +00005565 'eNptkLEOwyAMRHe+wupCIqW57v0Vq84WqWtXyrcXnCBsmgMJ+/SSAxMZgRB6NzE'
5566 'E2ObgCKJooYdu4uAQVffUEoE1sRQLxAcqzd7uK2gmStrll1ucV3uZyaY5sXyDd9'
5567 'JAnN+lAXsOMJ90GANAi43mq5/VeeacylKVgi8o6F1SC63FxnagHfJUTfUYdCR/W'
vapiera7fbd5a2016-06-16 09:17:49 -07005568 'Ofe+0dHL7PicpytKP750Fh1q2qnLVof4w8OZWNY')))
maruel@chromium.org29404b52014-09-08 22:58:00 +00005569 return 0
5570
5571
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005572class OptionParser(optparse.OptionParser):
5573 """Creates the option parse and add --verbose support."""
5574 def __init__(self, *args, **kwargs):
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005575 optparse.OptionParser.__init__(
5576 self, *args, prog='git cl', version=__version__, **kwargs)
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005577 self.add_option(
5578 '-v', '--verbose', action='count', default=0,
5579 help='Use 2 times for more debugging info')
5580
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005581 def parse_args(self, args=None, _values=None):
Andrii Shyshkalov46f20cd2018-10-30 06:42:54 +00005582 try:
5583 return self._parse_args(args)
5584 finally:
5585 # Regardless of success or failure of args parsing, we want to report
5586 # metrics, but only after logging has been initialized (if parsing
5587 # succeeded).
5588 global settings
5589 settings = Settings()
5590
5591 if not metrics.DISABLE_METRICS_COLLECTION:
5592 # GetViewVCUrl ultimately calls logging method.
5593 project_url = settings.GetViewVCUrl().strip('/+')
5594 if project_url in metrics_utils.KNOWN_PROJECT_URLS:
5595 metrics.collector.add('project_urls', [project_url])
5596
5597 def _parse_args(self, args=None):
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005598 # Create an optparse.Values object that will store only the actual passed
5599 # options, without the defaults.
5600 actual_options = optparse.Values()
5601 _, args = optparse.OptionParser.parse_args(self, args, actual_options)
5602 # Create an optparse.Values object with the default options.
5603 options = optparse.Values(self.get_default_values().__dict__)
5604 # Update it with the options passed by the user.
5605 options._update_careful(actual_options.__dict__)
5606 # Store the options passed by the user in an _actual_options attribute.
5607 # We store only the keys, and not the values, since the values can contain
5608 # arbitrary information, which might be PII.
5609 metrics.collector.add('arguments', actual_options.__dict__.keys())
5610
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005611 levels = [logging.WARNING, logging.INFO, logging.DEBUG]
Andrii Shyshkalov5b04a572017-01-23 17:44:41 +01005612 logging.basicConfig(
5613 level=levels[min(options.verbose, len(levels) - 1)],
5614 format='[%(levelname).1s%(asctime)s %(process)d %(thread)d '
5615 '%(filename)s] %(message)s')
Edward Lemur83bd7f42018-10-10 00:14:21 +00005616
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005617 return options, args
5618
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005619
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005620def main(argv):
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005621 if sys.hexversion < 0x02060000:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005622 print('\nYour Python version %s is unsupported, please upgrade.\n' %
vapiera7fbd5a2016-06-16 09:17:49 -07005623 (sys.version.split(' ', 1)[0],), file=sys.stderr)
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005624 return 2
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00005625
maruel@chromium.org39c0b222013-08-17 16:57:01 +00005626 colorize_CMDstatus_doc()
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005627 dispatcher = subcommand.CommandDispatcher(__name__)
5628 try:
5629 return dispatcher.execute(OptionParser(), argv)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +00005630 except auth.AuthenticationError as e:
5631 DieWithError(str(e))
vapierfd77ac72016-06-16 08:33:57 -07005632 except urllib2.HTTPError as e:
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005633 if e.code != 500:
5634 raise
5635 DieWithError(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005636 ('App Engine is misbehaving and returned HTTP %d, again. Keep faith '
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005637 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
sbc@chromium.org013731e2015-02-26 18:28:43 +00005638 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005639
5640
5641if __name__ == '__main__':
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005642 # These affect sys.stdout, so do it outside of main() to simplify mocks in
5643 # the unit tests.
maruel@chromium.org6f09cd92011-04-01 16:38:12 +00005644 fix_encoding.fix_encoding()
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00005645 setup_color.init()
Edward Lemur6f812e12018-07-31 22:45:57 +00005646 with metrics.collector.print_notice_and_exit():
sbc@chromium.org013731e2015-02-26 18:28:43 +00005647 sys.exit(main(sys.argv[1:]))