blob: ceac3f7f7a2a771f1d666b41f505461fad6c79e6 [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +000011#include <algorithm>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000012#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080013#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070014#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000015#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000016
Seth Hampson24722b32017-12-22 09:36:42 -080017#include "api/rtpparameters.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070018#include "api/test/mock_video_decoder_factory.h"
19#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020020#include "api/units/time_delta.h"
Åsa Persson23eba222018-10-02 14:47:06 +020021#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020022#include "api/video_codecs/builtin_video_decoder_factory.h"
23#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020024#include "api/video_codecs/sdp_video_format.h"
25#include "api/video_codecs/video_decoder_factory.h"
26#include "api/video_codecs/video_encoder.h"
27#include "api/video_codecs/video_encoder_factory.h"
28#include "call/flexfec_receive_stream.h"
29#include "common_video/h264/profile_level_id.h"
30#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller6557d0c2018-04-11 15:18:34 +020031#include "media/base/fakenetworkinterface.h"
32#include "media/base/fakevideocapturer.h"
33#include "media/base/fakevideorenderer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020034#include "media/base/mediaconstants.h"
35#include "media/base/rtputils.h"
36#include "media/base/testutils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020037#include "media/engine/constants.h"
38#include "media/engine/fakewebrtccall.h"
39#include "media/engine/fakewebrtcvideoengine.h"
40#include "media/engine/simulcast.h"
41#include "media/engine/webrtcvideoengine.h"
42#include "media/engine/webrtcvoiceengine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020043#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020044#include "rtc_base/arraysize.h"
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +020045#include "rtc_base/fakeclock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020046#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020047#include "rtc_base/numerics/safe_conversions.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020048#include "rtc_base/stringutils.h"
49#include "test/field_trial.h"
50#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000051
Tommi85959932018-02-07 19:26:06 +010052using cricket::FakeVideoCapturerWithTaskQueue;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010053using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070054using webrtc::RtpExtension;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010055using testing::Field;
isheriff6f8d6862016-05-26 11:24:55 -070056
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000057namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000058static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000059
noahricd10a68e2015-07-10 11:27:55 -070060static const uint8_t kRedRtxPayloadType = 125;
61
Niels Möller6557d0c2018-04-11 15:18:34 +020062static const uint32_t kTimeout = 5000U;
63static const uint32_t kDefaultReceiveSsrc = 0;
64static const uint32_t kSsrc = 1234u;
65static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
66static const int kVideoWidth = 640;
67static const int kVideoHeight = 360;
68static const int kFramerate = 30;
69
Peter Boström0c4e06b2015-10-07 12:23:21 +020070static const uint32_t kSsrcs1[] = {1};
71static const uint32_t kSsrcs3[] = {1, 2, 3};
72static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080073static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020074static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080075static const uint32_t kDefaultRecvSsrc = 0;
76
pbos@webrtc.org3c107582014-07-20 15:27:35 +000077static const char kUnsupportedExtensionName[] =
78 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000079
magjed509e4fe2016-11-18 01:34:11 -080080cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
81 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020082 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080083}
84
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000085void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
86 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
87 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
88 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
89 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
90 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
91 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
92 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -080093 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
94 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000095 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
96}
97
magjed725e4842016-11-16 00:48:13 -080098// Return true if any codec in |codecs| is an RTX codec with associated payload
99// type |payload_type|.
100bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
101 int payload_type) {
102 for (const cricket::VideoCodec& codec : codecs) {
103 int associated_payload_type;
Oleh Prypin6e8e2992018-10-23 15:18:23 +0200104 if (cricket::CodecNamesEq(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800105 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
106 &associated_payload_type) &&
107 associated_payload_type == payload_type) {
108 return true;
109 }
110 }
111 return false;
112}
113
nisseca5706d2017-09-11 02:32:16 -0700114// TODO(nisse): Duplicated in call.cc.
115const int* FindKeyByValue(const std::map<int, int>& m, int v) {
116 for (const auto& kv : m) {
117 if (kv.second == v)
118 return &kv.first;
119 }
120 return nullptr;
121}
122
Yves Gerey665174f2018-06-19 15:03:05 +0200123bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
124 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700125 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
126 payload_type) != nullptr;
127}
128
129// Check that there's an Rtx payload type for each decoder.
130bool VerifyRtxReceiveAssociations(
131 const webrtc::VideoReceiveStream::Config& config) {
132 for (const auto& decoder : config.decoders) {
133 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
134 return false;
135 }
136 return true;
137}
138
brandtrffc61182016-11-28 06:02:22 -0800139rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700140 int width,
141 int height) {
142 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
143 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800144 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700145 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000146}
147
Shao Changbine62202f2015-04-21 20:24:50 +0800148void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
149 const std::map<int, int>& rtx_types) {
150 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200151 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800152 EXPECT_TRUE(it != rtx_types.end() &&
153 it->second == config.rtp.rtx.payload_type);
154
brandtrb5f2c3f2016-10-04 23:28:39 -0700155 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
156 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800157 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700158 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800159 }
160}
kthelgason2bc68642017-02-07 07:02:22 -0800161
162cricket::MediaConfig GetMediaConfig() {
163 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100164 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800165 return media_config;
166}
nisse26e3abb2017-08-25 04:44:25 -0700167
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200168// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
169int GetMaxDefaultBitrateBps(size_t width, size_t height) {
170 if (width * height <= 320 * 240) {
171 return 600000;
172 } else if (width * height <= 640 * 480) {
173 return 1700000;
174 } else if (width * height <= 960 * 540) {
175 return 2000000;
176 } else {
177 return 2500000;
178 }
179}
180
Niels Möller731a2c22018-07-30 15:08:07 +0200181class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
182 public:
183 MOCK_METHOD2(AddOrUpdateSink,
184 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
185 const rtc::VideoSinkWants& wants));
186 MOCK_METHOD1(RemoveSink,
187 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
188};
189
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000190} // namespace
191
Yves Gerey665174f2018-06-19 15:03:05 +0200192#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200193 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200194 EXPECT_EQ((w), renderer_.width()); \
195 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200196 EXPECT_EQ(0, renderer_.errors());
197
Yves Gerey665174f2018-06-19 15:03:05 +0200198#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200199 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200200 EXPECT_EQ((w), (r).width()); \
201 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200202 EXPECT_EQ(0, (r).errors());
203
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000204namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700205class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000206 public:
eladalonf1841382017-06-12 01:16:46 -0700207 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
208 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700209 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700210 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200211 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
212 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +0200213 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200214 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200215 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200216 decoder_factory_)) {
217 // Ensure fake clock doesn't return 0, which will cause some initializations
218 // fail inside RTP senders.
219 fake_clock_.AdvanceTimeMicros(1);
220 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000221
222 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200223 void AssignDefaultAptRtxTypes();
224 void AssignDefaultCodec();
225
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100226 // Find the index of the codec in the engine with the given name. The codec
227 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100228 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100229
magjed509e4fe2016-11-18 01:34:11 -0800230 // Find the codec in the engine with the given name. The codec must be
231 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100232 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800233
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200234 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000235
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200236 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000237 const std::vector<VideoCodec>& codecs);
238
Peter Boströme4499152016-02-05 11:13:28 +0100239 void TestExtendedEncoderOveruse(bool use_external_encoder);
240
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200241 // Has to be the first one, so it is initialized before the call or there is a
242 // race condition in the clock access.
243 rtc::ScopedFakeClock fake_clock_;
stefanc1aeaf02015-10-15 07:26:07 -0700244 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700245 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700246 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000247 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800248 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200249 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
250 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -0700251 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000252 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800253 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000254};
255
eladalonf1841382017-06-12 01:16:46 -0700256TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200257 encoder_factory_->AddSupportedVideoCodecType("VP8");
258 AssignDefaultCodec();
259
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000260 std::vector<VideoCodec> engine_codecs = engine_.codecs();
261 for (size_t i = 0; i < engine_codecs.size(); ++i) {
262 if (engine_codecs[i].name != kRtxCodecName)
263 continue;
264 int associated_payload_type;
265 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000266 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000267 EXPECT_EQ(default_codec_.id, associated_payload_type);
268 return;
269 }
270 FAIL() << "No RTX codec found among default codecs.";
271}
272
eladalonf1841382017-06-12 01:16:46 -0700273TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100274 RtpCapabilities capabilities = engine_.GetCapabilities();
275 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700276 for (const RtpExtension& extension : capabilities.header_extensions) {
277 if (extension.uri == RtpExtension::kTimestampOffsetUri) {
278 EXPECT_EQ(RtpExtension::kTimestampOffsetDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000279 return;
280 }
281 }
282 FAIL() << "Timestamp offset extension not in header-extension list.";
283}
284
eladalonf1841382017-06-12 01:16:46 -0700285TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100286 RtpCapabilities capabilities = engine_.GetCapabilities();
287 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700288 for (const RtpExtension& extension : capabilities.header_extensions) {
289 if (extension.uri == RtpExtension::kAbsSendTimeUri) {
290 EXPECT_EQ(RtpExtension::kAbsSendTimeDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000291 return;
292 }
293 }
294 FAIL() << "Absolute Sender Time extension not in header-extension list.";
295}
296
eladalonf1841382017-06-12 01:16:46 -0700297TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100298 RtpCapabilities capabilities = engine_.GetCapabilities();
299 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700300 for (const RtpExtension& extension : capabilities.header_extensions) {
301 if (extension.uri == RtpExtension::kTransportSequenceNumberUri) {
302 EXPECT_EQ(RtpExtension::kTransportSequenceNumberDefaultId, extension.id);
stefanc1aeaf02015-10-15 07:26:07 -0700303 return;
304 }
305 }
306 FAIL() << "Transport sequence number extension not in header-extension list.";
307}
308
eladalonf1841382017-06-12 01:16:46 -0700309TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100310 RtpCapabilities capabilities = engine_.GetCapabilities();
311 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700312 for (const RtpExtension& extension : capabilities.header_extensions) {
313 if (extension.uri == RtpExtension::kVideoRotationUri) {
314 EXPECT_EQ(RtpExtension::kVideoRotationDefaultId, extension.id);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700315 return;
316 }
317 }
318 FAIL() << "Video Rotation extension not in header-extension list.";
319}
320
philipel1e054862018-10-08 16:13:53 +0200321class WebRtcVideoEngineTestWithGenericDescriptor
322 : public WebRtcVideoEngineTest {
323 public:
324 WebRtcVideoEngineTestWithGenericDescriptor()
325 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
326};
327
328TEST_F(WebRtcVideoEngineTestWithGenericDescriptor, AdvertiseGenericDescriptor) {
329 RtpCapabilities capabilities = engine_.GetCapabilities();
330 ASSERT_FALSE(capabilities.header_extensions.empty());
331 for (const RtpExtension& extension : capabilities.header_extensions) {
332 if (extension.uri == RtpExtension::kGenericFrameDescriptorUri) {
333 EXPECT_EQ(RtpExtension::kGenericFrameDescriptorDefaultId, extension.id);
334 return;
335 }
336 }
337 FAIL() << "Generic descriptor extension not in header-extension list.";
338}
339
eladalonf1841382017-06-12 01:16:46 -0700340TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200341 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700342 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200343 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700344
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200345 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700346
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200347 std::unique_ptr<VideoMediaChannel> channel(
348 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700349 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
350
351 // Add CVO extension.
352 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800353 cricket::VideoSendParameters parameters;
354 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200355 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700356 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200357 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700358
Niels Möller731a2c22018-07-30 15:08:07 +0200359 EXPECT_CALL(
360 video_source,
361 AddOrUpdateSink(testing::_,
362 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700363 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200364 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700365
366 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200367 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700368
369 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200370 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200371 EXPECT_CALL(
372 video_source,
373 AddOrUpdateSink(testing::_,
374 Field(&rtc::VideoSinkWants::rotation_applied, true)));
375
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200376 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700377}
378
eladalonf1841382017-06-12 01:16:46 -0700379TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200380 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800381 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200382 testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800383
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200384 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800385
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200386 std::unique_ptr<VideoMediaChannel> channel(
387 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800388 // Add CVO extension.
389 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800390 cricket::VideoSendParameters parameters;
391 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800392 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700393 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800394 EXPECT_TRUE(channel->SetSendParameters(parameters));
395 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
396
Niels Möller731a2c22018-07-30 15:08:07 +0200397 // Set source.
398 EXPECT_CALL(
399 video_source,
400 AddOrUpdateSink(testing::_,
401 Field(&rtc::VideoSinkWants::rotation_applied, false)));
402 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800403}
404
eladalonf1841382017-06-12 01:16:46 -0700405TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200406 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700407
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200408 encoder_factory_->AddSupportedVideoCodecType("VP8");
409 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700410
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200411 std::unique_ptr<VideoMediaChannel> channel(
412 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700413 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
414
415 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200416 EXPECT_CALL(
417 video_source,
418 AddOrUpdateSink(testing::_,
419 Field(&rtc::VideoSinkWants::rotation_applied, true)));
420 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700421
perkjcaafdba2016-03-20 07:34:29 -0700422 // Verify capturer has turned on applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200423 testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700424
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700425 // Add CVO extension.
426 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800427 cricket::VideoSendParameters parameters;
428 parameters.codecs.push_back(GetEngineCodec("VP8"));
429 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200430 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700431 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700432 // Also remove the first codec to trigger a codec change as well.
433 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200434 EXPECT_CALL(
435 video_source,
436 AddOrUpdateSink(testing::_,
437 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200438 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700439
440 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200441 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700442
443 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200444 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200445 EXPECT_CALL(
446 video_source,
447 AddOrUpdateSink(testing::_,
448 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200449 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700450}
451
eladalonf1841382017-06-12 01:16:46 -0700452TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200453 encoder_factory_->AddSupportedVideoCodecType("VP8");
454
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700455 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
456 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000457
458 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
459
460 EXPECT_FALSE(channel->SetSend(true))
461 << "Channel should not start without codecs.";
462 EXPECT_TRUE(channel->SetSend(false))
463 << "Channel should be stoppable even without set codecs.";
464}
465
eladalonf1841382017-06-12 01:16:46 -0700466TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200467 encoder_factory_->AddSupportedVideoCodecType("VP8");
468
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700469 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
470 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000471 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
472 VideoMediaInfo info;
473 channel->GetStats(&info);
474}
475
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200476TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200477 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000478
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200479 std::unique_ptr<VideoMediaChannel> channel(
480 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800481 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000482
483 EXPECT_TRUE(
484 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200485 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000486 EXPECT_TRUE(channel->SetSend(true));
Tommi85959932018-02-07 19:26:06 +0100487 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200488 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000489 EXPECT_EQ(cricket::CS_RUNNING,
490 capturer.Start(capturer.GetSupportedFormats()->front()));
491 EXPECT_TRUE(capturer.CaptureFrame());
Per21d45d22016-10-30 21:37:57 +0100492 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200493 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
494 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000495 kTimeout);
496
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200497 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100498 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000499
500 // Setting codecs of the same type should not reallocate any encoders
501 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800502 cricket::VideoSendParameters parameters;
503 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200504 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200505 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000506
507 // Remove stream previously added to free the external encoder instance.
508 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200509 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000510}
511
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200512// Test that when an encoder factory supports H264, we add an RTX
513// codec for it.
514// TODO(deadbeef): This test should be updated if/when we start
515// adding RTX codecs for unrecognized codec names.
516TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800517 using webrtc::H264::ProfileLevelIdToString;
518 using webrtc::H264::ProfileLevelId;
519 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200520 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
521 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800522 *ProfileLevelIdToString(
523 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200524 webrtc::SdpVideoFormat h264_constrained_high("H264");
525 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800526 *ProfileLevelIdToString(
527 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200528 webrtc::SdpVideoFormat h264_high("H264");
529 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800530 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
531
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200532 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
533 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
534 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700535
magjed725e4842016-11-16 00:48:13 -0800536 // First figure out what payload types the test codecs got assigned.
537 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800538 // Now search for RTX codecs for them. Expect that they all have associated
539 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800540 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200541 codecs,
542 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
543 ->id));
magjed725e4842016-11-16 00:48:13 -0800544 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200545 codecs,
546 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
547 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800548 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200549 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700550}
551
Peter Boström12996152016-05-14 02:03:18 +0200552#if !defined(RTC_DISABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700553TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200554 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100555
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200556 std::unique_ptr<VideoMediaChannel> channel(
557 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100558
559 EXPECT_TRUE(
560 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
561}
Peter Boström12996152016-05-14 02:03:18 +0200562#endif // !defined(RTC_DISABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100563
eladalonf1841382017-06-12 01:16:46 -0700564TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200565 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100566 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200567 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200568 std::unique_ptr<VideoMediaChannel> channel(
569 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700570
571 EXPECT_TRUE(
572 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
573
Tommi85959932018-02-07 19:26:06 +0100574 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200575 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
qiangchenc27d89f2015-07-16 10:27:16 -0700576 capturer.Start(cricket::VideoFormat(1280, 720,
577 cricket::VideoFormat::FpsToInterval(60),
578 cricket::FOURCC_I420));
579 channel->SetSend(true);
580
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200581 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700582
583 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700584 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700585 for (int i = 0; i < 10; i++) {
586 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700587 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700588 int64_t interval = timestamp - last_timestamp;
589
590 // Precision changes from nanosecond to millisecond.
591 // Allow error to be no more than 1.
592 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
593
594 last_timestamp = timestamp;
595 }
596
597 capturer.Start(cricket::VideoFormat(1280, 720,
598 cricket::VideoFormat::FpsToInterval(30),
599 cricket::FOURCC_I420));
600
601 EXPECT_TRUE(capturer.CaptureFrame());
602 last_timestamp = stream->GetLastTimestamp();
603 for (int i = 0; i < 10; i++) {
604 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700605 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700606 int64_t interval = timestamp - last_timestamp;
607
608 // Precision changes from nanosecond to millisecond.
609 // Allow error to be no more than 1.
610 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
611
612 last_timestamp = timestamp;
613 }
614
615 // Remove stream previously added to free the external encoder instance.
616 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
617}
618
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200619void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
620 std::vector<VideoCodec> engine_codecs = engine_.codecs();
621 RTC_DCHECK(!engine_codecs.empty());
622 for (const cricket::VideoCodec& codec : engine_codecs) {
623 if (codec.name == "rtx") {
624 int associated_payload_type;
625 if (codec.GetParam(kCodecParamAssociatedPayloadType,
626 &associated_payload_type)) {
627 default_apt_rtx_types_[associated_payload_type] = codec.id;
628 }
629 }
630 }
631}
632
633void WebRtcVideoEngineTest::AssignDefaultCodec() {
634 std::vector<VideoCodec> engine_codecs = engine_.codecs();
635 RTC_DCHECK(!engine_codecs.empty());
636 bool codec_set = false;
637 for (const cricket::VideoCodec& codec : engine_codecs) {
638 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
639 codec.name != "ulpfec") {
640 default_codec_ = codec;
641 codec_set = true;
642 }
643 }
644
645 RTC_DCHECK(codec_set);
646}
647
Oleh Prypina40f8242017-12-21 13:32:23 +0100648size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
649 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100650 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
651 for (size_t i = 0; i < codecs.size(); ++i) {
652 const cricket::VideoCodec engine_codec = codecs[i];
Oleh Prypin6e8e2992018-10-23 15:18:23 +0200653 if (!CodecNamesEq(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200654 continue;
655 // The tests only use H264 Constrained Baseline. Make sure we don't return
656 // an internal H264 codec from the engine with a different H264 profile.
Oleh Prypin6e8e2992018-10-23 15:18:23 +0200657 if (CodecNamesEq(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200658 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200659 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
660 if (profile_level_id->profile !=
661 webrtc::H264::kProfileConstrainedBaseline) {
662 continue;
663 }
664 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100665 return i;
magjed509e4fe2016-11-18 01:34:11 -0800666 }
667 // This point should never be reached.
668 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100669 return -1;
670}
671
672cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
673 const std::string& name) const {
674 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800675}
676
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200677VideoMediaChannel*
678WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700679 VideoMediaChannel* channel = engine_.CreateChannel(
680 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200681 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800682 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200683 for (const webrtc::SdpVideoFormat& format :
684 encoder_factory_->GetSupportedFormats()) {
685 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
686 if (std::find(parameters.codecs.begin(), parameters.codecs.end(),
687 engine_codec) == parameters.codecs.end()) {
688 parameters.codecs.push_back(engine_codec);
689 }
690 }
magjed509e4fe2016-11-18 01:34:11 -0800691
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200692 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000693
694 return channel;
695}
696
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200697VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000698 const std::vector<VideoCodec>& codecs) {
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700699 VideoMediaChannel* channel = engine_.CreateChannel(
700 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200701 cricket::VideoRecvParameters parameters;
702 parameters.codecs = codecs;
703 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000704
705 return channel;
706}
707
eladalonf1841382017-06-12 01:16:46 -0700708TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200709 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000710
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200711 std::unique_ptr<VideoMediaChannel> channel(
712 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000713
Peter Boström0c4e06b2015-10-07 12:23:21 +0200714 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000715
Yves Gerey665174f2018-06-19 15:03:05 +0200716 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000717 EXPECT_TRUE(channel->SetSend(true));
718
Tommi85959932018-02-07 19:26:06 +0100719 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200720 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000721 EXPECT_EQ(cricket::CS_RUNNING,
722 capturer.Start(capturer.GetSupportedFormats()->front()));
723 EXPECT_TRUE(capturer.CaptureFrame());
724
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200725 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000726
727 // Verify that encoders are configured for simulcast through adapter
728 // (increasing resolution and only configured to send one stream each).
729 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200730 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
731 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000732 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200733 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000734 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
735 EXPECT_GT(codec_settings.width, prev_width);
736 prev_width = codec_settings.width;
737 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000738
Niels Möllerff40b142018-04-09 08:49:14 +0200739 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000740
741 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200742 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000743}
744
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200745TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
746 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200747 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000748
Niels Möller4db138e2018-04-19 09:04:13 +0200749 // Set capturer.
750 FakeVideoCapturerWithTaskQueue capturer;
751 EXPECT_EQ(cricket::CS_RUNNING,
752 capturer.Start(capturer.GetSupportedFormats()->front()));
753
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700754 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
755 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200756 cricket::VideoSendParameters parameters;
757 parameters.codecs.push_back(GetEngineCodec("H264"));
758 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000759
760 EXPECT_TRUE(
761 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller4db138e2018-04-19 09:04:13 +0200762 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
763 // Sending one frame will have allocate the encoder.
764 EXPECT_TRUE(capturer.CaptureFrame());
765
766 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000767
Anders Carlsson67537952018-05-03 11:28:29 +0200768 cricket::VideoSendParameters new_parameters;
769 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
770 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200771
772 // Sending one frame will switch encoder.
773 EXPECT_TRUE(capturer.CaptureFrame());
774
Anders Carlsson8a150d92018-05-14 12:40:04 +0200775 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000776}
777
eladalonf1841382017-06-12 01:16:46 -0700778TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000779 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200780 encoder_factory_->AddSupportedVideoCodecType("VP8");
781 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000782
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700783 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
784 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800785 cricket::VideoSendParameters parameters;
786 parameters.codecs.push_back(GetEngineCodec("VP8"));
787 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000788
Peter Boström0c4e06b2015-10-07 12:23:21 +0200789 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000790
Yves Gerey665174f2018-06-19 15:03:05 +0200791 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000792 EXPECT_TRUE(channel->SetSend(true));
793
794 // Send a fake frame, or else the media engine will configure the simulcast
795 // encoder adapter at a low-enough size that it'll only create a single
796 // encoder layer.
Tommi85959932018-02-07 19:26:06 +0100797 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200798 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000799 EXPECT_EQ(cricket::CS_RUNNING,
800 capturer.Start(capturer.GetSupportedFormats()->front()));
801 EXPECT_TRUE(capturer.CaptureFrame());
802
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200803 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
804 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000805 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200806 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000807
808 channel.reset();
809 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200810 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000811}
812
eladalonf1841382017-06-12 01:16:46 -0700813TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000814 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200815 encoder_factory_->AddSupportedVideoCodecType("VP8");
816 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000817
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700818 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
819 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800820 cricket::VideoSendParameters parameters;
821 parameters.codecs.push_back(GetEngineCodec("H264"));
822 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000823
824 EXPECT_TRUE(
825 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100826
827 // Send a frame of 720p. This should trigger a "real" encoder initialization.
828 cricket::VideoFormat format(
829 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100830 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200831 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Per21d45d22016-10-30 21:37:57 +0100832 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
833 EXPECT_TRUE(capturer.CaptureFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200834 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
835 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200836 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000837 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200838 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000839
840 channel.reset();
841 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200842 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000843}
844
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200845TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
846 webrtc::test::ScopedFieldTrials override_field_trials_(
847 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200848 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700849
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700850 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
851 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200852 cricket::VideoSendParameters parameters;
853 parameters.codecs.push_back(GetEngineCodec("H264"));
854 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700855
Peter Boström0c4e06b2015-10-07 12:23:21 +0200856 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700857 EXPECT_TRUE(
858 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100859
860 // Send a frame of 720p. This should trigger a "real" encoder initialization.
noahricfdac5162015-08-27 01:59:29 -0700861 cricket::VideoFormat format(
862 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100863 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200864 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &capturer));
Peter Boströmce23bee2016-02-02 14:14:30 +0100865 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
866 EXPECT_TRUE(capturer.CaptureFrame());
867
Niels Möller4db138e2018-04-19 09:04:13 +0200868 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200869 ASSERT_EQ(1u, encoder_factory_->encoders().size());
870 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
871 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700872 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200873 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200874 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700875}
876
brandtrffc61182016-11-28 06:02:22 -0800877// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700878// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800879//
880// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700881TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800882 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200883 encoder_factory_->AddSupportedVideoCodecType("VP8");
884
brandtrffc61182016-11-28 06:02:22 -0800885 auto is_flexfec = [](const VideoCodec& codec) {
886 if (codec.name == "flexfec-03")
887 return true;
888 return false;
889 };
890
891 // FlexFEC is not active without field trial.
brandtrffc61182016-11-28 06:02:22 -0800892 const std::vector<VideoCodec> codecs_before = engine_.codecs();
893 EXPECT_EQ(codecs_before.end(), std::find_if(codecs_before.begin(),
894 codecs_before.end(), is_flexfec));
895
896 // FlexFEC is active with field trial.
897 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800898 "WebRTC-FlexFEC-03-Advertised/Enabled/");
brandtrffc61182016-11-28 06:02:22 -0800899 const std::vector<VideoCodec> codecs_after = engine_.codecs();
900 EXPECT_NE(codecs_after.end(),
901 std::find_if(codecs_after.begin(), codecs_after.end(), is_flexfec));
902}
903
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200904// Test that codecs are added in the order they are reported from the factory.
905TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
906 encoder_factory_->AddSupportedVideoCodecType("VP8");
907 const char* kFakeCodecName = "FakeCodec";
908 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000909
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200910 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100911 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200912 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
913 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000914}
915
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200916// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800917// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200918TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100919 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
920 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100921
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100922 // Set up external encoder factory with first codec, and initialize engine.
923 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
924
brandtrffc61182016-11-28 06:02:22 -0800925 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800926
927 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100928 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800929 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200930 // The codec itself and RTX should have been added.
931 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100932
933 // Check that both fake codecs are present and that the second fake codec
934 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100935 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
936 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100937 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800938}
939
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200940TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
941 const char* kFakeCodecName = "FakeCodec";
942 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
943
944 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
945 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
946}
947
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200948TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
949 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200950 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200951 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800952 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000953
kwiberg686a8ef2016-02-26 03:00:35 -0800954 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200955 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000956
957 EXPECT_TRUE(
958 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200959 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000960
961 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200962 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200963 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000964
965 // Remove stream previously added to free the external decoder instance.
966 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200967 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000968}
969
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200970// Verifies that we can set up decoders.
971TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000972 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
973 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
974 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
975 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200976 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +0200977 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000978 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800979 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000980
kwiberg686a8ef2016-02-26 03:00:35 -0800981 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200982 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000983
984 EXPECT_TRUE(
985 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200986 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000987}
988
Jonas Oreland49ac5952018-09-26 16:04:32 +0200989// Tests when GetSources is called with non-existing ssrc, it will return an
990// empty list of RtpSource without crashing.
991TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
992 // Setup an recv stream with |kSsrc|.
993 encoder_factory_->AddSupportedVideoCodecType("VP8");
994 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
995 cricket::VideoRecvParameters parameters;
996 parameters.codecs.push_back(GetEngineCodec("VP8"));
997 std::unique_ptr<VideoMediaChannel> channel(
998 SetRecvParamsWithSupportedCodecs(parameters.codecs));
999
1000 EXPECT_TRUE(
1001 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1002
1003 // Call GetSources with |kSsrc + 1| which doesn't exist.
1004 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1005 EXPECT_EQ(0u, sources.size());
1006}
1007
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001008TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1009 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1010 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
1011 WebRtcVideoEngine engine(std::move(encoder_factory),
1012 std::move(decoder_factory));
1013 EXPECT_EQ(0u, engine.codecs().size());
1014}
1015
1016TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1017 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001018 webrtc::MockVideoEncoderFactory* encoder_factory =
1019 new webrtc::MockVideoEncoderFactory();
1020 webrtc::MockVideoDecoderFactory* decoder_factory =
1021 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001022 WebRtcVideoEngine engine(
1023 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1024 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1025 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1026 EXPECT_EQ(0u, engine.codecs().size());
1027 EXPECT_CALL(*encoder_factory, Die());
1028 EXPECT_CALL(*decoder_factory, Die());
1029}
1030
1031// Test full behavior in the video engine when video codec factories of the new
1032// type are injected supporting the single codec Vp8. Check the returned codecs
1033// from the engine and that we will create a Vp8 encoder and decoder using the
1034// new factories.
1035TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1036 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001037 webrtc::MockVideoEncoderFactory* encoder_factory =
1038 new webrtc::MockVideoEncoderFactory();
1039 webrtc::MockVideoDecoderFactory* decoder_factory =
1040 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001041 WebRtcVideoEngine engine(
1042 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1043 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1044 const webrtc::SdpVideoFormat vp8_format("VP8");
1045 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1046 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1047 .WillRepeatedly(testing::Return(supported_formats));
1048
1049 // Verify the codecs from the engine.
1050 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001051 // Verify default codecs has been added correctly.
1052 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001053 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001054
1055 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001056 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001057 int vp8_associated_payload;
1058 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1059 &vp8_associated_payload));
1060 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1061
1062 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1063
1064 // RTX codec for RED.
1065 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1066 int red_associated_payload;
1067 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1068 &red_associated_payload));
1069 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1070
1071 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1072
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001073 int associated_payload_type;
1074 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1075 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1076 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1077 // Verify default parameters has been added to the VP8 codec.
1078 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
1079
1080 // Mock encoder creation. |engine| take ownership of the encoder.
1081 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1082 codec_info.is_hardware_accelerated = false;
1083 codec_info.has_internal_source = false;
1084 const webrtc::SdpVideoFormat format("VP8");
1085 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
1086 .WillRepeatedly(testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001087 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möller4db138e2018-04-19 09:04:13 +02001088 rtc::Event encoder_created(false, false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001089 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001090 .WillOnce(
1091 ::testing::DoAll(::testing::InvokeWithoutArgs(
1092 [&encoder_created]() { encoder_created.Set(); }),
1093 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001094
1095 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001096 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001097 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
1098 .WillOnce(testing::Return(decoder));
1099
1100 // Create a call.
1101 webrtc::RtcEventLogNullImpl event_log;
1102 std::unique_ptr<webrtc::Call> call(
1103 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1104
1105 // Create send channel.
1106 const int send_ssrc = 123;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001107 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateChannel(
1108 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001109 cricket::VideoSendParameters send_parameters;
1110 send_parameters.codecs.push_back(engine_codecs.at(0));
1111 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1112 send_channel->OnReadyToSend(true);
1113 EXPECT_TRUE(
1114 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1115 EXPECT_TRUE(send_channel->SetSend(true));
1116
Niels Möller4db138e2018-04-19 09:04:13 +02001117 // Set capturer.
1118 FakeVideoCapturerWithTaskQueue capturer;
1119 EXPECT_EQ(cricket::CS_RUNNING,
1120 capturer.Start(capturer.GetSupportedFormats()->front()));
1121 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &capturer));
1122 // Sending one frame will allocate the encoder.
1123 EXPECT_TRUE(capturer.CaptureFrame());
1124 encoder_created.Wait(kTimeout);
1125
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001126 // Create recv channel.
1127 const int recv_ssrc = 321;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001128 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateChannel(
1129 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001130 cricket::VideoRecvParameters recv_parameters;
1131 recv_parameters.codecs.push_back(engine_codecs.at(0));
1132 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1133 EXPECT_TRUE(recv_channel->AddRecvStream(
1134 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1135
1136 // Remove streams previously added to free the encoder and decoder instance.
1137 EXPECT_CALL(*encoder_factory, Die());
1138 EXPECT_CALL(*decoder_factory, Die());
1139 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1140 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1141}
1142
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001143// Test behavior when decoder factory fails to create a decoder (returns null).
1144TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1145 // |engine| take ownership of the factories.
1146 webrtc::MockVideoEncoderFactory* encoder_factory =
1147 new testing::StrictMock<webrtc::MockVideoEncoderFactory>();
1148 webrtc::MockVideoDecoderFactory* decoder_factory =
1149 new testing::StrictMock<webrtc::MockVideoDecoderFactory>();
1150 WebRtcVideoEngine engine(
1151 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1152 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1153 const webrtc::SdpVideoFormat vp8_format("VP8");
1154 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1155 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1156 .WillRepeatedly(testing::Return(supported_formats));
1157
1158 // Decoder creation fails.
1159 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(testing::_))
1160 .WillOnce(testing::Return(nullptr));
1161
1162 // Create a call.
1163 webrtc::RtcEventLogNullImpl event_log;
1164 std::unique_ptr<webrtc::Call> call(
1165 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1166
1167 // Create recv channel.
1168 const int recv_ssrc = 321;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001169 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateChannel(
1170 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001171 cricket::VideoRecvParameters recv_parameters;
1172 recv_parameters.codecs.push_back(engine.codecs().front());
1173 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1174 EXPECT_TRUE(recv_channel->AddRecvStream(
1175 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1176
1177 // Remove streams previously added to free the encoder and decoder instance.
1178 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1179}
1180
eladalonf1841382017-06-12 01:16:46 -07001181TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001182 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001183 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001184 std::unique_ptr<VideoMediaChannel> channel(
1185 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001186 ASSERT_TRUE(
1187 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1188 cricket::VideoCodec codec = GetEngineCodec("VP8");
1189 cricket::VideoSendParameters parameters;
1190 parameters.codecs.push_back(codec);
1191 channel->OnReadyToSend(true);
1192 channel->SetSend(true);
1193 ASSERT_TRUE(channel->SetSendParameters(parameters));
1194
Tommi85959932018-02-07 19:26:06 +01001195 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08001196 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02001197 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001198
1199 EXPECT_EQ(cricket::CS_RUNNING,
1200 capturer.Start(capturer.GetSupportedFormats()->front()));
1201 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001202 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001203 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001204 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001205
Niels Möllerff40b142018-04-09 08:49:14 +02001206 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001207 EXPECT_TRUE(capturer.CaptureFrame());
1208 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001209 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001210
1211 options.is_screencast.emplace(true);
Niels Möllerff40b142018-04-09 08:49:14 +02001212 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001213 EXPECT_TRUE(capturer.CaptureFrame());
1214 // Change to screen content, recreate encoder. For the simulcast encoder
1215 // adapter case, this will result in two calls since InitEncode triggers a
1216 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001217 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001218 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001219 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001220
Niels Möllerff40b142018-04-09 08:49:14 +02001221 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001222 EXPECT_TRUE(capturer.CaptureFrame());
1223 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001224 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001225
1226 options.is_screencast.emplace(false);
1227 options.video_noise_reduction.emplace(false);
Niels Möllerff40b142018-04-09 08:49:14 +02001228 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001229 // Change back to regular video content, update encoder. Also change
1230 // a non |is_screencast| option just to verify it doesn't affect recreation.
1231 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001232 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001233 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001234 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001235
1236 // Remove stream previously added to free the external encoder instance.
1237 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001238 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001239}
1240
Niels Möller6557d0c2018-04-11 15:18:34 +02001241class WebRtcVideoChannelBaseTest : public testing::Test {
1242 protected:
1243 WebRtcVideoChannelBaseTest()
Jonas Oreland49ac5952018-09-26 16:04:32 +02001244 : engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001245 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001246
1247 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001248 // One testcase calls SetUp in a loop, only create call_ once.
1249 if (!call_) {
1250 call_.reset(webrtc::Call::Create(webrtc::Call::Config(&event_log_)));
1251 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001252 cricket::MediaConfig media_config;
1253 // Disabling cpu overuse detection actually disables quality scaling too; it
1254 // implies DegradationPreference kMaintainResolution. Automatic scaling
1255 // needs to be disabled, otherwise, tests which check the size of received
1256 // frames become flaky.
1257 media_config.video.enable_cpu_adaptation = false;
1258 channel_.reset(engine_.CreateChannel(call_.get(), media_config,
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001259 cricket::VideoOptions(),
1260 webrtc::CryptoOptions()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001261 channel_->OnReadyToSend(true);
1262 EXPECT_TRUE(channel_.get() != NULL);
1263 network_interface_.SetDestination(channel_.get());
Anton Sukhanov98a462c2018-10-17 13:15:42 -07001264 channel_->SetInterface(&network_interface_, /*media_transport=*/nullptr);
Niels Möller6557d0c2018-04-11 15:18:34 +02001265 cricket::VideoRecvParameters parameters;
1266 parameters.codecs = engine_.codecs();
1267 channel_->SetRecvParameters(parameters);
1268 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
1269 video_capturer_.reset(CreateFakeVideoCapturer());
1270 cricket::VideoFormat format(640, 480,
1271 cricket::VideoFormat::FpsToInterval(kFramerate),
1272 cricket::FOURCC_I420);
1273 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001274 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001275 }
1276
1277 virtual cricket::FakeVideoCapturerWithTaskQueue* CreateFakeVideoCapturer() {
1278 return new cricket::FakeVideoCapturerWithTaskQueue();
1279 }
1280
1281 // Utility method to setup an additional stream to send and receive video.
1282 // Used to test send and recv between two streams.
1283 void SetUpSecondStream() {
1284 SetUpSecondStreamWithNoRecv();
1285 // Setup recv for second stream.
1286 EXPECT_TRUE(channel_->AddRecvStream(
1287 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1288 // Make the second renderer available for use by a new stream.
1289 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1290 }
1291 // Setup an additional stream just to send video. Defer add recv stream.
1292 // This is required if you want to test unsignalled recv of video rtp packets.
1293 void SetUpSecondStreamWithNoRecv() {
1294 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001295 EXPECT_TRUE(
1296 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001297 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001298 EXPECT_FALSE(
1299 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001300 EXPECT_TRUE(channel_->AddSendStream(
1301 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1302 // We dont add recv for the second stream.
1303
1304 // Setup the receive and renderer for second stream after send.
1305 video_capturer_2_.reset(CreateFakeVideoCapturer());
1306 cricket::VideoFormat format(640, 480,
1307 cricket::VideoFormat::FpsToInterval(kFramerate),
1308 cricket::FOURCC_I420);
1309 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(format));
1310
Yves Gerey665174f2018-06-19 15:03:05 +02001311 EXPECT_TRUE(
1312 channel_->SetVideoSend(kSsrc + 2, nullptr, video_capturer_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001313 }
Yves Gerey665174f2018-06-19 15:03:05 +02001314 virtual void TearDown() { channel_.reset(); }
1315 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001316
1317 bool SetOneCodec(const cricket::VideoCodec& codec) {
1318 cricket::VideoFormat capture_format(
1319 kVideoWidth, kVideoHeight,
1320 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1321
1322 if (video_capturer_) {
1323 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(capture_format));
1324 }
1325 if (video_capturer_2_) {
1326 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(capture_format));
1327 }
1328
1329 bool sending = channel_->sending();
1330 bool success = SetSend(false);
1331 if (success) {
1332 cricket::VideoSendParameters parameters;
1333 parameters.codecs.push_back(codec);
1334 success = channel_->SetSendParameters(parameters);
1335 }
1336 if (success) {
1337 success = SetSend(sending);
1338 }
1339 return success;
1340 }
Yves Gerey665174f2018-06-19 15:03:05 +02001341 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001342 bool SendFrame() {
1343 if (video_capturer_2_) {
1344 video_capturer_2_->CaptureFrame();
1345 }
1346 return video_capturer_.get() && video_capturer_->CaptureFrame();
1347 }
1348 bool WaitAndSendFrame(int wait_ms) {
1349 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
1350 ret &= SendFrame();
1351 return ret;
1352 }
Yves Gerey665174f2018-06-19 15:03:05 +02001353 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001354 int NumRtpBytes(uint32_t ssrc) {
1355 return network_interface_.NumRtpBytes(ssrc);
1356 }
Yves Gerey665174f2018-06-19 15:03:05 +02001357 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001358 int NumRtpPackets(uint32_t ssrc) {
1359 return network_interface_.NumRtpPackets(ssrc);
1360 }
Yves Gerey665174f2018-06-19 15:03:05 +02001361 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001362 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1363 return network_interface_.GetRtpPacket(index);
1364 }
1365 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001366 webrtc::RTPHeader header;
1367 EXPECT_TRUE(ParseRtpPacket(p, &header));
1368 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001369 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001370
Niels Möller6557d0c2018-04-11 15:18:34 +02001371 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001372 webrtc::RTPHeader* header) {
1373 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1374 webrtc::RtpHeaderParser::Create());
1375 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001376 }
1377
1378 // Tests that we can send and receive frames.
1379 void SendAndReceive(const cricket::VideoCodec& codec) {
1380 EXPECT_TRUE(SetOneCodec(codec));
1381 EXPECT_TRUE(SetSend(true));
1382 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1383 EXPECT_EQ(0, renderer_.num_rendered_frames());
1384 EXPECT_TRUE(SendFrame());
1385 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1386 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1387 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1388 }
1389
1390 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001391 int duration_sec,
1392 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001393 EXPECT_TRUE(SetOneCodec(codec));
1394 EXPECT_TRUE(SetSend(true));
1395 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1396 EXPECT_EQ(0, renderer_.num_rendered_frames());
1397 for (int i = 0; i < duration_sec; ++i) {
1398 for (int frame = 1; frame <= fps; ++frame) {
1399 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1400 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1401 }
1402 }
1403 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1404 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1405 }
1406
Niels Möller6557d0c2018-04-11 15:18:34 +02001407 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1408 cricket::VideoMediaInfo info;
1409 EXPECT_TRUE(channel_->GetStats(&info));
1410 return info.senders[i];
1411 }
1412
1413 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1414 cricket::VideoMediaInfo info;
1415 EXPECT_TRUE(channel_->GetStats(&info));
1416 return info.receivers[i];
1417 }
1418
1419 // Two streams one channel tests.
1420
1421 // Tests that we can send and receive frames.
1422 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1423 SetUpSecondStream();
1424 // Test sending and receiving on first stream.
1425 SendAndReceive(codec);
1426 // Test sending and receiving on second stream.
1427 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1428 EXPECT_GT(NumRtpPackets(), 0);
1429 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1430 }
1431
1432 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1433 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Oleh Prypin6e8e2992018-10-23 15:18:23 +02001434 if (CodecNamesEq(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001435 return engine_codec;
1436 }
1437 // This point should never be reached.
1438 ADD_FAILURE() << "Unrecognized codec name: " << name;
1439 return cricket::VideoCodec();
1440 }
1441
1442 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1443
1444 cricket::StreamParams DefaultSendStreamParams() {
1445 return cricket::StreamParams::CreateLegacy(kSsrc);
1446 }
1447
1448 webrtc::RtcEventLogNullImpl event_log_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001449 std::unique_ptr<webrtc::Call> call_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001450 WebRtcVideoEngine engine_;
1451 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_;
1452 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_2_;
1453 std::unique_ptr<WebRtcVideoChannel> channel_;
1454 cricket::FakeNetworkInterface network_interface_;
1455 cricket::FakeVideoRenderer renderer_;
1456
1457 // Used by test cases where 2 streams are run on the same channel.
1458 cricket::FakeVideoRenderer renderer2_;
1459};
1460
1461// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001462TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001463 EXPECT_FALSE(channel_->sending());
Yves Gerey665174f2018-06-19 15:03:05 +02001464 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001465 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1466 EXPECT_FALSE(channel_->sending());
1467 EXPECT_TRUE(SetSend(true));
1468 EXPECT_TRUE(channel_->sending());
1469 EXPECT_TRUE(SendFrame());
1470 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1471 EXPECT_TRUE(SetSend(false));
1472 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001473}
Niels Möller6557d0c2018-04-11 15:18:34 +02001474
1475// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001476TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001477 EXPECT_FALSE(channel_->sending());
1478 EXPECT_FALSE(SetSend(true));
1479 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001480}
Niels Möller6557d0c2018-04-11 15:18:34 +02001481
1482// Test that we properly set the send and recv buffer sizes by the time
1483// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001484TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001485 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1486 EXPECT_TRUE(SetSend(true));
1487 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1488 EXPECT_EQ(64 * 1024, network_interface_.recvbuf_size());
srtee0c2eea2017-12-15 17:44:33 +01001489}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001490
Erik Språng820ebd02018-08-20 17:14:25 +02001491// Test that we properly set the send and recv buffer sizes when overriding
1492// via field trials.
1493TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSize) {
1494 // Set field trial to override the default recv buffer size, and then re-run
1495 // setup where the interface is created and configured.
1496 const int kCustomRecvBufferSize = 123456;
1497 webrtc::test::ScopedFieldTrials field_trial(
1498 "WebRTC-IncreasedReceivebuffers/123456/");
1499 SetUp();
1500
1501 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1502 EXPECT_TRUE(SetSend(true));
1503 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1504 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1505}
1506
1507// Test that we properly set the send and recv buffer sizes when overriding
1508// via field trials with suffix.
1509TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSizeWithSuffix) {
1510 // Set field trial to override the default recv buffer size, and then re-run
1511 // setup where the interface is created and configured.
1512 const int kCustomRecvBufferSize = 123456;
1513 webrtc::test::ScopedFieldTrials field_trial(
1514 "WebRTC-IncreasedReceivebuffers/123456_Dogfood/");
1515 SetUp();
1516
1517 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1518 EXPECT_TRUE(SetSend(true));
1519 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1520 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1521}
1522
1523// Test that we properly set the send and recv buffer sizes when overriding
1524// via field trials that don't make any sense.
1525TEST_F(WebRtcVideoChannelBaseTest, InvalidRecvBufferSize) {
1526 // Set bogus field trial values to override the default recv buffer size, and
1527 // then re-run setup where the interface is created and configured. The
1528 // default value should still be used.
1529
1530 for (std::string group : {" ", "NotANumber", "-1", "0"}) {
1531 std::string field_trial_string = "WebRTC-IncreasedReceivebuffers/";
1532 field_trial_string += group;
1533 field_trial_string += "/";
1534 webrtc::test::ScopedFieldTrials field_trial(field_trial_string);
1535 SetUp();
1536
1537 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1538 EXPECT_TRUE(SetSend(true));
1539 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1540 EXPECT_EQ(64 * 1024, network_interface_.recvbuf_size());
1541 }
1542}
1543
Niels Möller6557d0c2018-04-11 15:18:34 +02001544// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001545TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001546 const int kDurationSec = 3;
1547 const int kFps = 10;
1548 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1549
1550 cricket::VideoMediaInfo info;
1551 EXPECT_TRUE(channel_->GetStats(&info));
1552
1553 ASSERT_EQ(1U, info.senders.size());
1554 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1555 // For webrtc, bytes_sent does not include the RTP header length.
1556 EXPECT_GT(info.senders[0].bytes_sent, 0);
1557 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1558 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1559 ASSERT_TRUE(info.senders[0].codec_payload_type);
1560 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1561 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1562 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1563 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1564 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1565 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1566 EXPECT_GT(info.senders[0].framerate_input, 0);
1567 EXPECT_GT(info.senders[0].framerate_sent, 0);
1568
1569 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1570 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1571 info.send_codecs[DefaultCodec().id]);
1572
1573 ASSERT_EQ(1U, info.receivers.size());
1574 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1575 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1576 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1577 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1578 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1579 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1580 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1581 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1582 EXPECT_EQ(0, info.receivers[0].packets_lost);
1583 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1584 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1585 EXPECT_EQ(0, info.receivers[0].firs_sent);
1586 EXPECT_EQ(0, info.receivers[0].plis_sent);
1587 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1588 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1589 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1590 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1591 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1592 EXPECT_GT(info.receivers[0].framerate_output, 0);
1593
1594 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1595 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1596 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001597}
Niels Möller6557d0c2018-04-11 15:18:34 +02001598
1599// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001600TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001601 cricket::FakeVideoRenderer renderer1, renderer2;
1602 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1603 cricket::VideoSendParameters parameters;
1604 parameters.codecs.push_back(DefaultCodec());
1605 parameters.conference_mode = true;
1606 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1607 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001608 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1609 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001610 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1611 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1612 EXPECT_EQ(0, renderer1.num_rendered_frames());
1613 EXPECT_EQ(0, renderer2.num_rendered_frames());
1614 std::vector<uint32_t> ssrcs;
1615 ssrcs.push_back(1);
1616 ssrcs.push_back(2);
1617 network_interface_.SetConferenceMode(true, ssrcs);
1618 EXPECT_TRUE(SendFrame());
1619 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1620 kTimeout);
1621 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1622 kTimeout);
1623
1624 EXPECT_TRUE(channel_->SetSend(false));
1625
1626 cricket::VideoMediaInfo info;
1627 EXPECT_TRUE(channel_->GetStats(&info));
1628 ASSERT_EQ(1U, info.senders.size());
1629 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1630 // For webrtc, bytes_sent does not include the RTP header length.
1631 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1632 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1633 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1634 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1635
1636 ASSERT_EQ(2U, info.receivers.size());
1637 for (size_t i = 0; i < info.receivers.size(); ++i) {
1638 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1639 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1640 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001641 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001642 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1643 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1644 }
srtee0c2eea2017-12-15 17:44:33 +01001645}
Niels Möller6557d0c2018-04-11 15:18:34 +02001646
1647// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001648TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001649 // Normal setup; note that we set the SSRC explicitly to ensure that
1650 // it will come first in the senders map.
1651 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1652 cricket::VideoSendParameters parameters;
1653 parameters.codecs.push_back(DefaultCodec());
1654 parameters.conference_mode = true;
1655 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001656 EXPECT_TRUE(
1657 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001658 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1659 EXPECT_TRUE(SetSend(true));
1660 EXPECT_TRUE(SendFrame());
1661 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1662 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1663
1664 // Add an additional capturer, and hook up a renderer to receive it.
1665 cricket::FakeVideoRenderer renderer2;
1666 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1667 CreateFakeVideoCapturer());
1668 const int kTestWidth = 160;
1669 const int kTestHeight = 120;
1670 cricket::VideoFormat format(kTestWidth, kTestHeight,
1671 cricket::VideoFormat::FpsToInterval(5),
1672 cricket::FOURCC_I420);
1673 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001674 EXPECT_TRUE(
1675 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001676 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, capturer.get()));
Yves Gerey665174f2018-06-19 15:03:05 +02001677 EXPECT_TRUE(
1678 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001679 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
1680 EXPECT_TRUE(capturer->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001681 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1682 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001683
1684 // Get stats, and make sure they are correct for two senders. We wait until
1685 // the number of expected packets have been sent to avoid races where we
1686 // check stats before it has been updated.
1687 cricket::VideoMediaInfo info;
1688 for (uint32_t i = 0; i < kTimeout; ++i) {
1689 rtc::Thread::Current()->ProcessMessages(1);
1690 EXPECT_TRUE(channel_->GetStats(&info));
1691 ASSERT_EQ(2U, info.senders.size());
1692 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1693 NumRtpPackets()) {
1694 // Stats have been updated for both sent frames, expectations can be
1695 // checked now.
1696 break;
1697 }
1698 }
1699 EXPECT_EQ(NumRtpPackets(),
1700 info.senders[0].packets_sent + info.senders[1].packets_sent)
1701 << "Timed out while waiting for packet counts for all sent packets.";
1702 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1703 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1704 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1705 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1706 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1707 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1708 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1709 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1710 // The capturer must be unregistered here as it runs out of it's scope next.
1711 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001712}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001713
Niels Möller6557d0c2018-04-11 15:18:34 +02001714// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001715TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001716 cricket::VideoSendParameters parameters;
1717 parameters.codecs.push_back(DefaultCodec());
1718 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1719 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1720 parameters.max_bandwidth_bps = 128 * 1024;
1721 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001722}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001723
Niels Möller6557d0c2018-04-11 15:18:34 +02001724// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001725TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001726 EXPECT_TRUE(SetDefaultCodec());
1727 EXPECT_TRUE(SetSend(true));
1728 EXPECT_TRUE(SendFrame());
1729 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001730 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001731 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001732 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1733 EXPECT_EQ(kSsrc, header.ssrc);
1734
Niels Möller6557d0c2018-04-11 15:18:34 +02001735 // Packets are being paced out, so these can mismatch between the first and
1736 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001737 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1738 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001739 EXPECT_EQ(1, NumSentSsrcs());
1740 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1741 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001742}
Niels Möller6557d0c2018-04-11 15:18:34 +02001743
1744// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001745TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001746 // Remove stream added in Setup.
1747 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1748 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001749 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001750 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
1751 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001752 EXPECT_TRUE(SetSend(true));
1753 EXPECT_TRUE(WaitAndSendFrame(0));
1754 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001755 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001756 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001757 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1758 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001759 // Packets are being paced out, so these can mismatch between the first and
1760 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001761 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1762 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001763 EXPECT_EQ(1, NumSentSsrcs());
1764 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1765 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001766}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001767
Niels Möller6557d0c2018-04-11 15:18:34 +02001768// Test that we can set the default video renderer before and after
1769// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001770TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001771 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1772 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001773
1774 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1775 rtc::SetBE32(packet1.data() + 8, kSsrc);
1776 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1777 EXPECT_TRUE(SetDefaultCodec());
1778 EXPECT_TRUE(SetSend(true));
1779 EXPECT_EQ(0, renderer_.num_rendered_frames());
1780 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
1781 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1782 EXPECT_TRUE(SendFrame());
1783 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001784}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001785
Niels Möller6557d0c2018-04-11 15:18:34 +02001786// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001787TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001788 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1789 EXPECT_TRUE(SetSend(true));
1790 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1791 EXPECT_TRUE(SendFrame());
1792 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1793 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001794 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001795 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001796 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1797 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001798 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1799 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001800
1801 // Remove the send stream that was added during Setup.
1802 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1803 int rtp_packets = NumRtpPackets();
1804
Niels Möller6557d0c2018-04-11 15:18:34 +02001805 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001806 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
1807 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001808 EXPECT_EQ(rtp_packets, NumRtpPackets());
1809 // Wait 30ms to guarantee the engine does not drop the frame.
1810 EXPECT_TRUE(WaitAndSendFrame(30));
1811 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1812
1813 last_packet = NumRtpPackets() - 1;
1814 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001815 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1816 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001817}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001818
Niels Möller6557d0c2018-04-11 15:18:34 +02001819// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001820TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001821 cricket::FakeVideoRenderer renderer1, renderer2;
1822 EXPECT_TRUE(SetDefaultCodec());
1823 cricket::VideoSendParameters parameters;
1824 parameters.codecs.push_back(DefaultCodec());
1825 parameters.conference_mode = true;
1826 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1827 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001828 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1829 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001830 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1831 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1832 EXPECT_EQ(0, renderer1.num_rendered_frames());
1833 EXPECT_EQ(0, renderer2.num_rendered_frames());
1834 std::vector<uint32_t> ssrcs;
1835 ssrcs.push_back(1);
1836 ssrcs.push_back(2);
1837 network_interface_.SetConferenceMode(true, ssrcs);
1838 EXPECT_TRUE(SendFrame());
1839 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1840 kTimeout);
1841 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1842 kTimeout);
1843
1844 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1845 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1846 EXPECT_EQ(kVideoWidth, renderer1.width());
1847 EXPECT_EQ(kVideoHeight, renderer1.height());
1848 EXPECT_EQ(kVideoWidth, renderer2.width());
1849 EXPECT_EQ(kVideoHeight, renderer2.height());
1850 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1851 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001852}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001853
Niels Möller6557d0c2018-04-11 15:18:34 +02001854// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001855TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001856 using cricket::VideoCodec;
1857 using cricket::VideoOptions;
1858 using cricket::VideoFormat;
1859 using cricket::FOURCC_I420;
1860
1861 VideoCodec codec = DefaultCodec();
1862 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1863 EXPECT_TRUE(SetOneCodec(codec));
1864 EXPECT_TRUE(SetSend(true));
1865 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1866 EXPECT_EQ(0, renderer_.num_rendered_frames());
1867 EXPECT_TRUE(SendFrame());
1868 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1869 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1870 CreateFakeVideoCapturer());
1871
1872 // TODO(nisse): This testcase fails if we don't configure
1873 // screencast. It's unclear why, I see nothing obvious in this
1874 // test which is related to screencast logic.
1875 VideoOptions video_options;
1876 video_options.is_screencast = true;
1877 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1878
1879 VideoFormat format(480, 360, VideoFormat::FpsToInterval(30), FOURCC_I420);
1880 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
1881 // All capturers start generating frames with the same timestamp. ViE does
1882 // not allow the same timestamp to be used. Capture one frame before
1883 // associating the capturer with the channel.
1884 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1885
1886 int captured_frames = 1;
1887 for (int iterations = 0; iterations < 2; ++iterations) {
1888 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, capturer.get()));
1889 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
1890 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1891 ++captured_frames;
1892 // Wait until frame of right size is captured.
1893 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001894 format.width == renderer_.width() &&
1895 format.height == renderer_.height() &&
1896 !renderer_.black_frame(),
1897 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001898 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1899 EXPECT_EQ(format.width, renderer_.width());
1900 EXPECT_EQ(format.height, renderer_.height());
1901 captured_frames = renderer_.num_rendered_frames() + 1;
1902 EXPECT_FALSE(renderer_.black_frame());
1903 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1904 // Make sure a black frame is generated within the specified timeout.
1905 // The black frame should be the resolution of the previous frame to
1906 // prevent expensive encoder reconfigurations.
1907 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001908 format.width == renderer_.width() &&
1909 format.height == renderer_.height() &&
1910 renderer_.black_frame(),
1911 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001912 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1913 EXPECT_EQ(format.width, renderer_.width());
1914 EXPECT_EQ(format.height, renderer_.height());
1915 EXPECT_TRUE(renderer_.black_frame());
1916
1917 // The black frame has the same timestamp as the next frame since it's
1918 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1919 // not render a frame with the same timestamp so capture another frame
1920 // with the frame capturer to increment the next frame's timestamp.
1921 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1922 }
srtee0c2eea2017-12-15 17:44:33 +01001923}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001924
Niels Möller6557d0c2018-04-11 15:18:34 +02001925// Tests that if SetVideoSend is called with a NULL capturer after the
1926// capturer was already removed, the application doesn't crash (and no black
1927// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001928TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001929 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1930 EXPECT_TRUE(SetSend(true));
1931 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1932 EXPECT_EQ(0, renderer_.num_rendered_frames());
1933 EXPECT_TRUE(SendFrame());
1934 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1935 // Wait for one frame so they don't get dropped because we send frames too
1936 // tightly.
1937 rtc::Thread::Current()->ProcessMessages(30);
1938 // Remove the capturer.
1939 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1940
1941 // No capturer was added, so this SetVideoSend shouldn't do anything.
1942 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1943 rtc::Thread::Current()->ProcessMessages(300);
1944 // Verify no more frames were sent.
1945 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001946}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001947
Niels Möller6557d0c2018-04-11 15:18:34 +02001948// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001949TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001950 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1951 // interval time to avoid that.
1952 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1953 // interval time to avoid that.
1954 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001955 EXPECT_TRUE(
1956 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001957 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1958 cricket::VideoFormat capture_format(
1959 kVideoWidth, kVideoHeight,
1960 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1961 // Set up additional stream 1.
1962 cricket::FakeVideoRenderer renderer1;
1963 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001964 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001965 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001966 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001967 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer1(
1968 CreateFakeVideoCapturer());
1969 EXPECT_EQ(cricket::CS_RUNNING, capturer1->Start(capture_format));
1970 // Set up additional stream 2.
1971 cricket::FakeVideoRenderer renderer2;
1972 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001973 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001974 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001975 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001976 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer2(
1977 CreateFakeVideoCapturer());
1978 EXPECT_EQ(cricket::CS_RUNNING, capturer2->Start(capture_format));
1979 // State for all the streams.
1980 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1981 // A limitation in the lmi implementation requires that SetVideoSend() is
1982 // called after SetOneCodec().
1983 // TODO(hellner): this seems like an unnecessary constraint, fix it.
1984 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, capturer1.get()));
1985 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, capturer2.get()));
1986 EXPECT_TRUE(SetSend(true));
1987 // Test capturer associated with engine.
1988 const int kTestWidth = 160;
1989 const int kTestHeight = 120;
1990 EXPECT_TRUE(capturer1->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001991 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
1992 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001993 // Capture a frame with additional capturer2, frames should be received
1994 EXPECT_TRUE(capturer2->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001995 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1996 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001997 // Successfully remove the capturer.
1998 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1999 // The capturers must be unregistered here as it runs out of it's scope
2000 // next.
2001 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
2002 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01002003}
Niels Möller6557d0c2018-04-11 15:18:34 +02002004
2005// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01002006TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002007 // Remove the send stream that was added during Setup.
2008 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
2009
2010 cricket::StreamParams empty;
2011 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02002012 EXPECT_TRUE(
2013 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01002014}
Niels Möller6557d0c2018-04-11 15:18:34 +02002015
2016// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01002017TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002018 // Remove stream added in Setup. I.e. remove stream corresponding to default
2019 // channel.
2020 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02002021 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02002022 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
2023 EXPECT_TRUE(channel_->AddSendStream(
2024 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
2025 }
2026 // Delete one of the non default channel streams, let the destructor delete
2027 // the remaining ones.
2028 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
2029 // Stream should already be deleted.
2030 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01002031}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00002032
eladalonf1841382017-06-12 01:16:46 -07002033TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08002034 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002035}
2036
eladalonf1841382017-06-12 01:16:46 -07002037TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08002038 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002039}
2040
eladalonf1841382017-06-12 01:16:46 -07002041TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002042 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002043}
2044
eladalonf1841382017-06-12 01:16:46 -07002045TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002046 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2047 // bitrates. This currently happens at <250k, and two streams sharing 300k
2048 // initially will use QVGA instead of VGA.
2049 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2050 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002051 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002052 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002053 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002054}
2055
eladalonf1841382017-06-12 01:16:46 -07002056class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002057 public:
eladalonf1841382017-06-12 01:16:46 -07002058 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2059 explicit WebRtcVideoChannelTest(const char* field_trials)
2060 : WebRtcVideoEngineTest(field_trials), last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002061 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002062 encoder_factory_->AddSupportedVideoCodecType("VP8");
2063 encoder_factory_->AddSupportedVideoCodecType("VP9");
2064#if defined(WEBRTC_USE_H264)
2065 encoder_factory_->AddSupportedVideoCodecType("H264");
2066#endif
2067
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002068 fake_call_.reset(new FakeCall());
kthelgason2bc68642017-02-07 07:02:22 -08002069 channel_.reset(engine_.CreateChannel(fake_call_.get(), GetMediaConfig(),
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002070 VideoOptions(),
2071 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002072 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002073 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002074 send_parameters_.codecs = engine_.codecs();
2075 recv_parameters_.codecs = engine_.codecs();
2076 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002077 }
2078
2079 protected:
2080 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002081 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002082 }
2083
2084 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002085 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002086 EXPECT_TRUE(channel_->AddSendStream(sp));
2087 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002088 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002089 EXPECT_EQ(num_streams + 1, streams.size());
2090 return streams[streams.size() - 1];
2091 }
2092
2093 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002094 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002095 }
2096
2097 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002098 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002099 }
2100
2101 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002102 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002103 EXPECT_TRUE(channel_->AddRecvStream(sp));
2104 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002105 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002106 EXPECT_EQ(num_streams + 1, streams.size());
2107 return streams[streams.size() - 1];
2108 }
2109
pbos@webrtc.org00873182014-11-25 14:03:34 +00002110 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2111 int expected_min_bitrate_bps,
2112 const char* start_bitrate_kbps,
2113 int expected_start_bitrate_bps,
2114 const char* max_bitrate_kbps,
2115 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002116 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2117 expected_start_bitrate_bps,
2118 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002119 auto& codecs = send_parameters_.codecs;
2120 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002121 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002122 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2123 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2124 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002125 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002126 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002127
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002128 void ExpectSetBitrateParameters(int min_bitrate_bps,
2129 int start_bitrate_bps,
2130 int max_bitrate_bps) {
2131 EXPECT_CALL(
2132 *fake_call_->GetMockTransportControllerSend(),
2133 SetSdpBitrateParameters(AllOf(
2134 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2135 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2136 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2137 }
2138
2139 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2140 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2141 SetSdpBitrateParameters(Field(
2142 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002143 }
2144
isheriff6f8d6862016-05-26 11:24:55 -07002145 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002146 // Enable extension.
2147 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002148 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002149 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002150 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002151 FakeVideoSendStream* send_stream =
2152 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2153
2154 // Verify the send extension id.
2155 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2156 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002157 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002158 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002159 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002160 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2161 // receivers.
2162 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2163 ->GetConfig()
2164 .rtp.extensions.empty());
2165
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002166 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002167 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002168 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2169 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002170 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2171
2172 // Verify that adding receive RTP header extensions adds them for existing
2173 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002174 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002175 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002176 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2177 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002178 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002179 }
2180
isheriff6f8d6862016-05-26 11:24:55 -07002181 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002182 // Enable extension.
2183 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002184 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002185 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002186 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002187
2188 FakeVideoReceiveStream* recv_stream =
2189 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2190
2191 // Verify the recv extension id.
2192 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2193 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002194 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002195 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002196 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002197
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002198 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2199 // senders.
2200 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2201 ->GetConfig()
2202 .rtp.extensions.empty());
2203
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002204 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002205 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002206 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2207 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002208 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2209
2210 // Verify that adding receive RTP header extensions adds them for existing
2211 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002212 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002213 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002214 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2215 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002216 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002217 }
2218
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002219 void TestExtensionFilter(const std::vector<std::string>& extensions,
2220 const std::string& expected_extension) {
2221 cricket::VideoSendParameters parameters = send_parameters_;
2222 int expected_id = -1;
2223 int id = 1;
2224 for (const std::string& extension : extensions) {
2225 if (extension == expected_extension)
2226 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002227 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002228 }
2229 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2230 FakeVideoSendStream* send_stream =
2231 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2232
2233 // Verify that only one of them has been set, and that it is the one with
2234 // highest priority (transport sequence number).
2235 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2236 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2237 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002238 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002239 }
2240
asapersson3c81a1a2017-06-14 05:52:21 -07002241 void TestDegradationPreference(bool resolution_scaling_enabled,
2242 bool fps_scaling_enabled);
2243
Erik Språngefbde372015-04-29 16:21:28 +02002244 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002245 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002246 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2247 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002248
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002249 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002250 uint32_t ssrc,
Tommi85959932018-02-07 19:26:06 +01002251 FakeVideoCapturerWithTaskQueue* capturer,
nisse0db023a2016-03-01 04:29:59 -08002252 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002253 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002254 options.video_noise_reduction = enabled;
Niels Möllerff40b142018-04-09 08:49:14 +02002255 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, capturer));
nisse0db023a2016-03-01 04:29:59 -08002256 // Options only take effect on the next frame.
2257 EXPECT_TRUE(capturer->CaptureFrame());
2258
Erik Språng143cec12015-04-28 10:01:41 +02002259 return fake_call_->GetVideoSendStreams().back();
2260 }
2261
Peter Boström2feafdb2015-09-09 14:32:14 +02002262 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2263 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002264 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002265 std::vector<uint32_t> ssrcs;
2266 std::vector<uint32_t> rtx_ssrcs;
2267 uint32_t num_streams = enabled ? 3 : 1;
2268 for (uint32_t i = 0; i < num_streams; ++i) {
2269 uint32_t ssrc = last_ssrc_ + i;
2270 ssrcs.push_back(ssrc);
2271 if (with_rtx) {
2272 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2273 }
Erik Språng143cec12015-04-28 10:01:41 +02002274 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002275 if (with_rtx) {
2276 return AddSendStream(
2277 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2278 }
2279 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002280 }
2281
perkjfa10b552016-10-02 23:45:26 -07002282 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002283 std::vector<FakeVideoSendStream*> streams =
2284 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002285 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002286 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002287 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002288 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002289 }
2290
perkjfa10b552016-10-02 23:45:26 -07002291 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002292 int stream_max,
2293 int expected_encoder_bitrate) {
2294 VideoSendParameters limited_send_params = send_parameters_;
2295 limited_send_params.max_bandwidth_bps = global_max;
2296 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002297 webrtc::RtpParameters parameters =
2298 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002299 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002300 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002301 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002302 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002303 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002304 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002305 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002306 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002307 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002308 }
2309
Åsa Persson55659812018-06-18 17:51:32 +02002310 // Values from kSimulcastConfigs in simulcast.cc.
2311 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2312 std::vector<webrtc::VideoStream> layers(3);
2313 layers[0].min_bitrate_bps = 30000;
2314 layers[0].target_bitrate_bps = 150000;
2315 layers[0].max_bitrate_bps = 200000;
2316 layers[1].min_bitrate_bps = 150000;
2317 layers[1].target_bitrate_bps = 500000;
2318 layers[1].max_bitrate_bps = 700000;
2319 layers[2].min_bitrate_bps = 600000;
2320 layers[2].target_bitrate_bps = 2500000;
2321 layers[2].max_bitrate_bps = 2500000;
2322 return layers;
2323 }
2324
kwiberg686a8ef2016-02-26 03:00:35 -08002325 std::unique_ptr<FakeCall> fake_call_;
2326 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002327 cricket::VideoSendParameters send_parameters_;
2328 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002329 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002330};
2331
eladalonf1841382017-06-12 01:16:46 -07002332TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002333 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002334 const std::string kSyncLabel = "AvSyncLabel";
2335
2336 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002337 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002338 EXPECT_TRUE(channel_->AddRecvStream(sp));
2339
Mirko Bonadeif859e552018-05-30 15:31:29 +02002340 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002341 EXPECT_EQ(kSyncLabel,
2342 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2343 << "SyncGroup should be set based on sync_label";
2344}
2345
eladalonf1841382017-06-12 01:16:46 -07002346TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002347 cricket::VideoSendParameters parameters;
2348 parameters.codecs = engine_.codecs();
2349 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002350 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002351 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002352 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002353
2354 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002355 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2356 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002357 FakeVideoSendStream* send_stream = AddSendStream(
2358 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2359
2360 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2361 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2362 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2363
2364 // Receiver side.
2365 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2366 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002367 EXPECT_FALSE(
2368 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002369 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002370 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002371 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002372 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002373 << "RTX should be mapped for the RED payload type";
2374
brandtr14742122017-01-27 04:53:07 -08002375 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002376}
2377
eladalonf1841382017-06-12 01:16:46 -07002378TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002379 // Setup one channel with an associated RTX stream.
2380 cricket::StreamParams params =
2381 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2382 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2383 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002384 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002385
2386 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2387 << "RTX should be mapped for all decoders/payload types.";
2388 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002389 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002390 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002391}
2392
eladalonf1841382017-06-12 01:16:46 -07002393TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002394 // Setup one channel without an associated RTX stream.
2395 cricket::StreamParams params =
2396 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2397 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002398 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002399}
2400
eladalonf1841382017-06-12 01:16:46 -07002401TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002402 FakeVideoSendStream* send_stream =
2403 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2404 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2405
2406 FakeVideoReceiveStream* recv_stream =
2407 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2408 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002409}
2410
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002411// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002412TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002413 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002414}
isheriff6f8d6862016-05-26 11:24:55 -07002415
eladalonf1841382017-06-12 01:16:46 -07002416TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002417 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002418}
2419
2420// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002421TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002422 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002423}
isheriff6f8d6862016-05-26 11:24:55 -07002424
eladalonf1841382017-06-12 01:16:46 -07002425TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002426 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002427}
2428
eladalonf1841382017-06-12 01:16:46 -07002429TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002430 // Enable three redundant extensions.
2431 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002432 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2433 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2434 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2435 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002436}
2437
eladalonf1841382017-06-12 01:16:46 -07002438TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002439 // Enable two redundant extensions.
2440 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002441 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2442 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2443 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002444}
2445
stefanc1aeaf02015-10-15 07:26:07 -07002446// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002447TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002448 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002449}
eladalonf1841382017-06-12 01:16:46 -07002450TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002451 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002452}
2453
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002454// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002455TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002456 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002457}
eladalonf1841382017-06-12 01:16:46 -07002458TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002459 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002460}
2461
eladalonf1841382017-06-12 01:16:46 -07002462TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002463 const int kAbsSendTimeId = 1;
2464 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002465 send_parameters_.extensions.push_back(
2466 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2467 send_parameters_.extensions.push_back(
2468 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002469
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002470 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002471 FakeVideoSendStream* send_stream =
2472 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2473
2474 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002475 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002476
2477 // Setting the same extensions (even if in different order) shouldn't
2478 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002479 std::reverse(send_parameters_.extensions.begin(),
2480 send_parameters_.extensions.end());
2481 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002482
2483 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2484
2485 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002486 send_parameters_.extensions.resize(1);
2487 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002488
2489 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2490}
2491
eladalonf1841382017-06-12 01:16:46 -07002492TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002493 const int kTOffsetId = 1;
2494 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002495 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002496 recv_parameters_.extensions.push_back(
2497 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2498 recv_parameters_.extensions.push_back(
2499 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2500 recv_parameters_.extensions.push_back(
2501 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002502
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002503 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002504 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002505 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2506
2507 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002508 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002509
2510 // Setting the same extensions (even if in different order) shouldn't
2511 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002512 std::reverse(recv_parameters_.extensions.begin(),
2513 recv_parameters_.extensions.end());
2514 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002515
2516 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2517
2518 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002519 recv_parameters_.extensions.resize(1);
2520 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002521
2522 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2523}
2524
eladalonf1841382017-06-12 01:16:46 -07002525TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002526 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002527 const int kUnsupportedId = 1;
2528 const int kTOffsetId = 2;
2529
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002530 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002531 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002532 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002533 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002534 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002535 FakeVideoSendStream* send_stream =
2536 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2537
2538 // Only timestamp offset extension is set to send stream,
2539 // unsupported rtp extension is ignored.
2540 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002541 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2542 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002543}
2544
eladalonf1841382017-06-12 01:16:46 -07002545TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002546 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002547 const int kUnsupportedId = 1;
2548 const int kTOffsetId = 2;
2549
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002550 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002551 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002552 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002553 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002554 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002555 FakeVideoReceiveStream* recv_stream =
2556 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2557
2558 // Only timestamp offset extension is set to receive stream,
2559 // unsupported rtp extension is ignored.
2560 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002561 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2562 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002563}
2564
eladalonf1841382017-06-12 01:16:46 -07002565TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002566 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002567 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002568 send_parameters_.extensions.push_back(
2569 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002570 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002571 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2572 }
2573}
2574
eladalonf1841382017-06-12 01:16:46 -07002575TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002576 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002577 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002578 recv_parameters_.extensions.push_back(
2579 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002580 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002581 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2582 }
2583}
2584
eladalonf1841382017-06-12 01:16:46 -07002585TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002586 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002587 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002588 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002589 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002590 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002591 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002592
2593 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002594 send_parameters_.extensions.clear();
2595 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002596 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002597 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2598 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002599}
2600
eladalonf1841382017-06-12 01:16:46 -07002601TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002602 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002603 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002604 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002605 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002606 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002607 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002608
2609 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002610 recv_parameters_.extensions.clear();
2611 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002612 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002613 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2614 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002615}
2616
eladalonf1841382017-06-12 01:16:46 -07002617TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002618 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002619 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002620}
2621
eladalonf1841382017-06-12 01:16:46 -07002622TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002623 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002624 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002625}
2626
eladalonf1841382017-06-12 01:16:46 -07002627TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002628 FakeVideoReceiveStream* stream = AddRecvStream();
2629 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002630}
2631
eladalonf1841382017-06-12 01:16:46 -07002632TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002633 FakeVideoReceiveStream* stream = AddRecvStream();
2634 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2635}
2636
eladalonf1841382017-06-12 01:16:46 -07002637TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002638 FakeVideoReceiveStream* stream = AddRecvStream();
2639 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2640
Peter Boström126c03e2015-05-11 12:48:12 +02002641 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002642 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002643 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002644 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2645 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002646 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002647 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2648
2649 // Verify that REMB is turned on when setting default codecs since the
2650 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002651 parameters.codecs = engine_.codecs();
2652 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002653 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002654 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002655}
2656
eladalonf1841382017-06-12 01:16:46 -07002657TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002658 FakeVideoReceiveStream* stream = AddRecvStream();
2659 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2660
2661 // Verify that transport cc feedback is turned off when send(!) codecs without
2662 // transport cc feedback are set.
2663 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002664 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002665 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2666 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2667 stream = fake_call_->GetVideoReceiveStreams()[0];
2668 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2669
2670 // Verify that transport cc feedback is turned on when setting default codecs
2671 // since the default codecs have transport cc feedback enabled.
2672 parameters.codecs = engine_.codecs();
2673 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2674 stream = fake_call_->GetVideoReceiveStreams()[0];
2675 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2676}
2677
eladalonf1841382017-06-12 01:16:46 -07002678TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002679 AssignDefaultCodec();
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002680 VerifyCodecHasDefaultFeedbackParams(default_codec_);
2681
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002682 cricket::VideoSendParameters parameters;
2683 parameters.codecs = engine_.codecs();
2684 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002685 EXPECT_TRUE(channel_->SetSend(true));
2686
2687 // Send side.
2688 FakeVideoSendStream* send_stream =
2689 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2690 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2691
2692 // Receiver side.
2693 FakeVideoReceiveStream* recv_stream =
2694 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2695 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2696
2697 // Nack history size should match between sender and receiver.
2698 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2699 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002700}
2701
eladalonf1841382017-06-12 01:16:46 -07002702TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002703 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002704 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002705
2706 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2707 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2708
2709 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002710 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002711 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002712 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2713 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002714 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2715 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2716 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002717 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2718
Peter Boström67c9df72015-05-11 14:34:58 +02002719 // Verify that NACK is turned on when setting default codecs since the
2720 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002721 parameters.codecs = engine_.codecs();
2722 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002723 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2724 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2725 send_stream = fake_call_->GetVideoSendStreams()[0];
2726 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002727}
2728
Peter Boströme7ba0862016-03-12 00:02:28 +01002729// This test verifies that new frame sizes reconfigures encoders even though not
2730// (yet) sending. The purpose of this is to permit encoding as quickly as
2731// possible once we start sending. Likely the frames being input are from the
2732// same source that will be sent later, which just means that we're ready
2733// earlier.
eladalonf1841382017-06-12 01:16:46 -07002734TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002735 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002736 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002737 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2738 channel_->SetSend(false);
2739
2740 FakeVideoSendStream* stream = AddSendStream();
2741
perkjfa10b552016-10-02 23:45:26 -07002742 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002743 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002744 EXPECT_EQ(0u, streams[0].width);
2745 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002746
Tommi85959932018-02-07 19:26:06 +01002747 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002748 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj26752742016-10-24 01:21:16 -07002749 VideoFormat capture_format = capturer.GetSupportedFormats()->front();
2750 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
Peter Boströme7ba0862016-03-12 00:02:28 +01002751 EXPECT_TRUE(capturer.CaptureFrame());
2752
2753 // Frame entered, should be reconfigured to new dimensions.
2754 streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002755 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.width), streams[0].width);
2756 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.height),
2757 streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002758
Niels Möllerff40b142018-04-09 08:49:14 +02002759 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002760}
2761
eladalonf1841382017-06-12 01:16:46 -07002762TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002763 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002764 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002765 cricket::VideoSendParameters parameters;
2766 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002767 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002768 AddSendStream();
2769
Tommi85959932018-02-07 19:26:06 +01002770 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07002771 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002772 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Yves Gerey665174f2018-06-19 15:03:05 +02002773 EXPECT_TRUE(
2774 channel_->SetVideoSend(last_ssrc_, &min_bitrate_options, &capturer));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002775 cricket::VideoFormat capture_format_hd =
2776 capturer.GetSupportedFormats()->front();
2777 EXPECT_EQ(1280, capture_format_hd.width);
2778 EXPECT_EQ(720, capture_format_hd.height);
2779 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2780
2781 EXPECT_TRUE(channel_->SetSend(true));
2782
2783 EXPECT_TRUE(capturer.CaptureFrame());
2784 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2785 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2786
2787 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2788
2789 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002790 webrtc::VideoEncoderConfig encoder_config =
2791 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002792 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002793 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002794 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002795 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2796 streams.front().width);
2797 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2798 streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002799 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2800 << "Non-screenshare shouldn't use min-transmit bitrate.";
2801
Niels Möllerff40b142018-04-09 08:49:14 +02002802 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002803 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002804 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002805 screencast_options.is_screencast = true;
deadbeef5a4a75a2016-06-02 16:23:38 -07002806 EXPECT_TRUE(
Niels Möllerff40b142018-04-09 08:49:14 +02002807 channel_->SetVideoSend(last_ssrc_, &screencast_options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08002808 EXPECT_TRUE(capturer.CaptureFrame());
sprangf24a0642017-02-28 13:23:26 -08002809 // Send stream recreated after option change.
2810 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2811 send_stream = fake_call_->GetVideoSendStreams().front();
2812 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002813
2814 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002815 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002816 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002817 encoder_config.content_type);
2818 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2819 encoder_config.min_transmit_bitrate_bps);
2820
perkjfa10b552016-10-02 23:45:26 -07002821 streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002822 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2823 streams.front().width);
2824 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2825 streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002826 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002827 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002828}
2829
eladalonf1841382017-06-12 01:16:46 -07002830TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002831 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002832 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002833 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002834 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002835
2836 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002837 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002838 options.is_screencast = true;
Tommi85959932018-02-07 19:26:06 +01002839 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002840 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002841 cricket::VideoFormat capture_format_hd =
2842 capturer.GetSupportedFormats()->front();
2843 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2844
2845 EXPECT_TRUE(channel_->SetSend(true));
2846
2847 EXPECT_TRUE(capturer.CaptureFrame());
2848 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2849 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2850
perkj26091b12016-09-01 01:17:40 -07002851 webrtc::VideoEncoderConfig encoder_config =
2852 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002853
2854 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002855 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002856 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002857 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002858
2859 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2860 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002861 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002862 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002863 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002864
Niels Möllerff40b142018-04-09 08:49:14 +02002865 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002866}
2867
eladalonf1841382017-06-12 01:16:46 -07002868TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002869 FakeVideoSendStream* stream = AddSendStream();
2870 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2871}
2872
eladalonf1841382017-06-12 01:16:46 -07002873TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002874 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002875 media_config.video.suspend_below_min_bitrate = true;
2876
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002877 channel_.reset(engine_.CreateChannel(
2878 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002879 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002880
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002881 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002882
2883 FakeVideoSendStream* stream = AddSendStream();
2884 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2885
nisse0db023a2016-03-01 04:29:59 -08002886 media_config.video.suspend_below_min_bitrate = false;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002887 channel_.reset(engine_.CreateChannel(
2888 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002889 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002890
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002891 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002892
nisse0db023a2016-03-01 04:29:59 -08002893 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002894 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2895}
2896
eladalonf1841382017-06-12 01:16:46 -07002897TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002898 FakeVideoSendStream* stream = AddSendStream();
2899 webrtc::VideoCodecVP8 vp8_settings;
2900 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2901 EXPECT_TRUE(vp8_settings.denoisingOn);
2902}
2903
eladalonf1841382017-06-12 01:16:46 -07002904TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002905 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002906 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002907 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002908
Peter Boström2feafdb2015-09-09 14:32:14 +02002909 // Single-stream settings should apply with RTX as well (verifies that we
2910 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2911 // both RTX and regular SSRCs).
2912 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002913
Tommi85959932018-02-07 19:26:06 +01002914 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002915 EXPECT_EQ(cricket::CS_RUNNING,
2916 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002917 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002918 channel_->SetSend(true);
2919
2920 EXPECT_TRUE(capturer.CaptureFrame());
2921
pbos4cba4eb2015-10-26 11:18:18 -07002922 webrtc::VideoCodecVP8 vp8_settings;
2923 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2924 EXPECT_TRUE(vp8_settings.denoisingOn)
2925 << "VP8 denoising should be on by default.";
2926
nisse05103312016-03-16 02:22:50 -07002927 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002928
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002929 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2930 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002931 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2932 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002933
nisse05103312016-03-16 02:22:50 -07002934 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002935
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002936 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2937 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002938 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2939 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2940
Niels Möllerff40b142018-04-09 08:49:14 +02002941 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002942 stream = SetUpSimulcast(true, false);
Niels Möllerff40b142018-04-09 08:49:14 +02002943 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002944 channel_->SetSend(true);
2945 EXPECT_TRUE(capturer.CaptureFrame());
2946
Mirko Bonadeif859e552018-05-30 15:31:29 +02002947 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002948 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2949 // Autmatic resize off when using simulcast.
2950 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2951 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2952
2953 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002954 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002955 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002956 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
Niels Möller60653ba2016-03-02 11:41:36 +01002957
nisse05103312016-03-16 02:22:50 -07002958 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002959
Mirko Bonadeif859e552018-05-30 15:31:29 +02002960 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002961 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2962 EXPECT_FALSE(vp8_settings.denoisingOn);
2963 // Resizing and frame dropping always off for screen sharing.
2964 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2965 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2966
nisse05103312016-03-16 02:22:50 -07002967 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02002968
2969 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2970 EXPECT_FALSE(vp8_settings.denoisingOn);
2971 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2972 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2973
Niels Möllerff40b142018-04-09 08:49:14 +02002974 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02002975}
2976
deadbeef119760a2016-04-04 11:43:27 -07002977// Test that setting the same options doesn't result in the encoder being
2978// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07002979TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07002980 VideoOptions options;
Tommi85959932018-02-07 19:26:06 +01002981 FakeVideoCapturerWithTaskQueue capturer;
deadbeef119760a2016-04-04 11:43:27 -07002982
perkjfa10b552016-10-02 23:45:26 -07002983 AddSendStream();
deadbeef119760a2016-04-04 11:43:27 -07002984 EXPECT_EQ(cricket::CS_RUNNING,
2985 capturer.Start(capturer.GetSupportedFormats()->front()));
perkjfa10b552016-10-02 23:45:26 -07002986 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002987 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07002988 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2989 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2990
Niels Möllerff40b142018-04-09 08:49:14 +02002991 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
2992 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002993 EXPECT_TRUE(capturer.CaptureFrame());
perkjfa10b552016-10-02 23:45:26 -07002994 // Expect 1 reconfigurations at this point from the initial configuration.
2995 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07002996
2997 // Set the options one more time and expect no additional reconfigurations.
Niels Möllerff40b142018-04-09 08:49:14 +02002998 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkjfa10b552016-10-02 23:45:26 -07002999 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
3000
3001 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01003002 options.video_noise_reduction = true;
Niels Möllerff40b142018-04-09 08:49:14 +02003003 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07003004 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
3005
Niels Möllerff40b142018-04-09 08:49:14 +02003006 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07003007}
3008
eladalonf1841382017-06-12 01:16:46 -07003009class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02003010 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07003011 Vp9SettingsTest() : Vp9SettingsTest("") {}
3012 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07003013 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02003014 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003015 }
3016 virtual ~Vp9SettingsTest() {}
3017
3018 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003019 void TearDown() override {
3020 // Remove references to encoder_factory_ since this will be destroyed
3021 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003022 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003023 }
Erik Språng143cec12015-04-28 10:01:41 +02003024};
3025
3026TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003027 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003028 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003029 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003030
Peter Boström2feafdb2015-09-09 14:32:14 +02003031 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003032
Tommi85959932018-02-07 19:26:06 +01003033 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02003034 EXPECT_EQ(cricket::CS_RUNNING,
3035 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003036 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02003037 channel_->SetSend(true);
3038
3039 EXPECT_TRUE(capturer.CaptureFrame());
3040
pbos4cba4eb2015-10-26 11:18:18 -07003041 webrtc::VideoCodecVP9 vp9_settings;
3042 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003043 EXPECT_TRUE(vp9_settings.denoisingOn)
3044 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003045
nisse05103312016-03-16 02:22:50 -07003046 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003047
Erik Språng143cec12015-04-28 10:01:41 +02003048 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3049 EXPECT_FALSE(vp9_settings.denoisingOn);
3050 // Frame dropping always on for real time video.
3051 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3052
nisse05103312016-03-16 02:22:50 -07003053 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02003054
3055 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3056 EXPECT_TRUE(vp9_settings.denoisingOn);
3057 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3058
3059 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003060 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003061 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02003062 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003063
nisse05103312016-03-16 02:22:50 -07003064 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003065
3066 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3067 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003068 // Frame dropping always on for screen sharing.
3069 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003070
nisse05103312016-03-16 02:22:50 -07003071 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003072
3073 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3074 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003075 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003076
Niels Möllerff40b142018-04-09 08:49:14 +02003077 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003078}
3079
Sergey Silkinf18072e2018-03-14 10:35:35 +01003080TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3081 cricket::VideoSendParameters parameters;
3082 parameters.codecs.push_back(GetEngineCodec("VP9"));
3083 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3084
3085 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3086
3087 FakeVideoSendStream* stream =
3088 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3089
3090 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3091 EXPECT_EQ(ssrcs.size(), config.rtp.ssrcs.size());
3092
3093 FakeVideoCapturerWithTaskQueue capturer;
3094 EXPECT_EQ(cricket::CS_RUNNING,
3095 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003096 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &capturer));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003097 channel_->SetSend(true);
3098
3099 EXPECT_TRUE(capturer.CaptureFrame());
3100
3101 webrtc::VideoCodecVP9 vp9_settings;
3102 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3103
3104 const size_t kNumSpatialLayers = ssrcs.size();
3105 const size_t kNumTemporalLayers = 3;
3106 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3107 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3108
Niels Möllerff40b142018-04-09 08:49:14 +02003109 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003110}
3111
asaperssonc5dabdd2016-03-21 04:15:50 -07003112class Vp9SettingsTestWithFieldTrial : public Vp9SettingsTest {
3113 public:
brandtr468da7c2016-11-22 02:16:47 -08003114 explicit Vp9SettingsTestWithFieldTrial(const char* field_trials)
asaperssonc5dabdd2016-03-21 04:15:50 -07003115 : Vp9SettingsTest(field_trials) {}
3116
3117 protected:
3118 void VerifySettings(int num_spatial_layers, int num_temporal_layers) {
3119 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003120 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003121 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3122
3123 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3124
Tommi85959932018-02-07 19:26:06 +01003125 FakeVideoCapturerWithTaskQueue capturer;
asaperssonc5dabdd2016-03-21 04:15:50 -07003126 EXPECT_EQ(cricket::CS_RUNNING,
3127 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003128 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
asaperssonc5dabdd2016-03-21 04:15:50 -07003129 channel_->SetSend(true);
3130
3131 EXPECT_TRUE(capturer.CaptureFrame());
3132
3133 webrtc::VideoCodecVP9 vp9_settings;
3134 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3135 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3136 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
3137
Niels Möllerff40b142018-04-09 08:49:14 +02003138 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003139 }
3140};
3141
3142class Vp9SettingsTestWithNoFlag : public Vp9SettingsTestWithFieldTrial {
3143 public:
3144 Vp9SettingsTestWithNoFlag() : Vp9SettingsTestWithFieldTrial("") {}
3145};
3146
3147TEST_F(Vp9SettingsTestWithNoFlag, VerifySettings) {
3148 const int kNumSpatialLayers = 1;
3149 const int kNumTemporalLayers = 1;
3150 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3151}
3152
3153class Vp9SettingsTestWithInvalidFlag : public Vp9SettingsTestWithFieldTrial {
3154 public:
3155 Vp9SettingsTestWithInvalidFlag()
3156 : Vp9SettingsTestWithFieldTrial("WebRTC-SupportVP9SVC/Default/") {}
3157};
3158
3159TEST_F(Vp9SettingsTestWithInvalidFlag, VerifySettings) {
3160 const int kNumSpatialLayers = 1;
3161 const int kNumTemporalLayers = 1;
3162 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3163}
3164
3165class Vp9SettingsTestWith2SL3TLFlag : public Vp9SettingsTestWithFieldTrial {
3166 public:
3167 Vp9SettingsTestWith2SL3TLFlag()
3168 : Vp9SettingsTestWithFieldTrial(
3169 "WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/") {}
3170};
3171
3172TEST_F(Vp9SettingsTestWith2SL3TLFlag, VerifySettings) {
3173 const int kNumSpatialLayers = 2;
3174 const int kNumTemporalLayers = 3;
3175 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3176}
3177
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003178TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3179 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3180 ASSERT_EQ(1u, streams.size());
3181 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3182}
3183
3184TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
3185 webrtc::test::ScopedFieldTrials override_field_trials_(
3186 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3187 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3188 ASSERT_EQ(1u, streams.size());
3189 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3190}
3191
asapersson3c81a1a2017-06-14 05:52:21 -07003192TEST_F(WebRtcVideoChannelTest,
3193 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
3194 webrtc::test::ScopedFieldTrials override_field_trials_(
3195 "WebRTC-Video-BalancedDegradation/Disabled/");
3196 const bool kResolutionScalingEnabled = true;
3197 const bool kFpsScalingEnabled = false;
3198 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3199}
3200
3201TEST_F(WebRtcVideoChannelTest,
3202 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
3203 webrtc::test::ScopedFieldTrials override_field_trials_(
3204 "WebRTC-Video-BalancedDegradation/Enabled/");
3205 const bool kResolutionScalingEnabled = true;
3206 const bool kFpsScalingEnabled = true;
3207 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3208}
3209
eladalonf1841382017-06-12 01:16:46 -07003210TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003211 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003212}
3213
eladalonf1841382017-06-12 01:16:46 -07003214TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003215 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003216}
3217
eladalonf1841382017-06-12 01:16:46 -07003218TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003219 TestCpuAdaptation(true, true);
3220}
3221
eladalonf1841382017-06-12 01:16:46 -07003222TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruseAndChangeResolution) {
magjed509e4fe2016-11-18 01:34:11 -08003223 cricket::VideoCodec codec = GetEngineCodec("VP8");
perkj2d5f0912016-02-29 00:04:41 -08003224 cricket::VideoSendParameters parameters;
3225 parameters.codecs.push_back(codec);
3226
kthelgason2bc68642017-02-07 07:02:22 -08003227 MediaConfig media_config = GetMediaConfig();
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003228 channel_.reset(engine_.CreateChannel(
3229 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003230 channel_->OnReadyToSend(true);
perkj2d5f0912016-02-29 00:04:41 -08003231 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3232
3233 AddSendStream();
3234
Tommi85959932018-02-07 19:26:06 +01003235 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003236 ASSERT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003237 ASSERT_EQ(cricket::CS_RUNNING,
3238 capturer.Start(capturer.GetSupportedFormats()->front()));
3239 ASSERT_TRUE(channel_->SetSend(true));
3240
3241 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3242 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003243
Niels Möllera6cc0f92018-02-12 17:14:55 +01003244 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003245 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3246 EXPECT_EQ(1280, send_stream->GetLastWidth());
3247 EXPECT_EQ(720, send_stream->GetLastHeight());
3248
3249 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003250 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003251 wants.max_pixel_count =
3252 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003253 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003254 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003255 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3256 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3257 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3258
3259 // Trigger overuse again.
sprangc5d62e22017-04-02 23:53:04 -07003260 wants.max_pixel_count =
3261 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003262 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003263 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003264 EXPECT_EQ(3, send_stream->GetNumberOfSwappedFrames());
3265 EXPECT_EQ(1280 * 2 / 4, send_stream->GetLastWidth());
3266 EXPECT_EQ(720 * 2 / 4, send_stream->GetLastHeight());
3267
3268 // Change input resolution.
Niels Möllera6cc0f92018-02-12 17:14:55 +01003269 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003270 EXPECT_EQ(4, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003271 EXPECT_EQ(1284 / 2, send_stream->GetLastWidth());
3272 EXPECT_EQ(724 / 2, send_stream->GetLastHeight());
3273
3274 // Trigger underuse which should go back up in resolution.
sprang84a37592017-02-10 07:04:27 -08003275 int current_pixel_count =
3276 send_stream->GetLastWidth() * send_stream->GetLastHeight();
3277 // Cap the max to 4x the pixel count (assuming max 1/2 x 1/2 scale downs)
3278 // of the current stream, so we don't take too large steps.
sprangc5d62e22017-04-02 23:53:04 -07003279 wants.max_pixel_count = current_pixel_count * 4;
sprang84a37592017-02-10 07:04:27 -08003280 // Default step down is 3/5 pixel count, so go up by 5/3.
Oskar Sundbom78807582017-11-16 11:09:55 +01003281 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003282 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003283 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003284 EXPECT_EQ(5, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003285 EXPECT_EQ(1284 * 3 / 4, send_stream->GetLastWidth());
3286 EXPECT_EQ(724 * 3 / 4, send_stream->GetLastHeight());
3287
sprang84a37592017-02-10 07:04:27 -08003288 // Trigger underuse again, should go back up to full resolution.
3289 current_pixel_count =
3290 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003291 wants.max_pixel_count = current_pixel_count * 4;
Oskar Sundbom78807582017-11-16 11:09:55 +01003292 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003293 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003294 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003295 EXPECT_EQ(6, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003296 EXPECT_EQ(1284, send_stream->GetLastWidth());
3297 EXPECT_EQ(724, send_stream->GetLastHeight());
3298
Niels Möllerff40b142018-04-09 08:49:14 +02003299 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003300}
3301
eladalonf1841382017-06-12 01:16:46 -07003302TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003303 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003304 cricket::VideoSendParameters parameters;
3305 parameters.codecs.push_back(codec);
3306
kthelgason2bc68642017-02-07 07:02:22 -08003307 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003308 media_config.video.enable_cpu_adaptation = true;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003309 channel_.reset(engine_.CreateChannel(
3310 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003311 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003312 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3313
3314 AddSendStream();
3315
Tommi85959932018-02-07 19:26:06 +01003316 FakeVideoCapturerWithTaskQueue capturer;
Per766ad3b2016-04-05 15:23:49 +02003317 ASSERT_EQ(cricket::CS_RUNNING,
3318 capturer.Start(capturer.GetSupportedFormats()->front()));
3319 ASSERT_TRUE(channel_->SetSend(true));
3320 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003321 camera_options.is_screencast = false;
Yves Gerey665174f2018-06-19 15:03:05 +02003322 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
Per766ad3b2016-04-05 15:23:49 +02003323
3324 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3325 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003326
Niels Möllera6cc0f92018-02-12 17:14:55 +01003327 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003328 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3329 EXPECT_EQ(1280, send_stream->GetLastWidth());
3330 EXPECT_EQ(720, send_stream->GetLastHeight());
3331
3332 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003333 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003334 wants.max_pixel_count =
3335 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003336 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003337 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003338 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3339 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3340 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3341
3342 // Switch to screen share. Expect no CPU adaptation.
Tommi85959932018-02-07 19:26:06 +01003343 FakeVideoCapturerWithTaskQueue screen_share(true);
Per766ad3b2016-04-05 15:23:49 +02003344 ASSERT_EQ(cricket::CS_RUNNING,
3345 screen_share.Start(screen_share.GetSupportedFormats()->front()));
Per766ad3b2016-04-05 15:23:49 +02003346 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003347 screenshare_options.is_screencast = true;
Yves Gerey665174f2018-06-19 15:03:05 +02003348 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &screen_share);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003349 EXPECT_TRUE(screen_share.CaptureCustomFrame(1284, 724));
sprangf24a0642017-02-28 13:23:26 -08003350 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3351 send_stream = fake_call_->GetVideoSendStreams().front();
3352 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003353 EXPECT_EQ(1284, send_stream->GetLastWidth());
3354 EXPECT_EQ(724, send_stream->GetLastHeight());
3355
3356 // Switch back to the normal capturer. Expect the frame to be CPU adapted.
Yves Gerey665174f2018-06-19 15:03:05 +02003357 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
sprangf24a0642017-02-28 13:23:26 -08003358 send_stream = fake_call_->GetVideoSendStreams().front();
3359 // We have a new fake send stream, so it doesn't remember the old sink wants.
3360 // In practice, it will be populated from
mflodmancc3d4422017-08-03 08:27:51 -07003361 // VideoStreamEncoder::VideoSourceProxy::SetSource(), so simulate that here.
sprangf24a0642017-02-28 13:23:26 -08003362 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003363 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
sprangf24a0642017-02-28 13:23:26 -08003364 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3365 send_stream = fake_call_->GetVideoSendStreams().front();
3366 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003367 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3368 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3369
Niels Möllerff40b142018-04-09 08:49:14 +02003370 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003371}
3372
asapersson3c81a1a2017-06-14 05:52:21 -07003373// TODO(asapersson): Remove this test when the balanced field trial is removed.
3374void WebRtcVideoChannelTest::TestDegradationPreference(
3375 bool resolution_scaling_enabled,
3376 bool fps_scaling_enabled) {
3377 cricket::VideoCodec codec = GetEngineCodec("VP8");
3378 cricket::VideoSendParameters parameters;
3379 parameters.codecs.push_back(codec);
3380
3381 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003382 media_config.video.enable_cpu_adaptation = true;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003383 channel_.reset(engine_.CreateChannel(
3384 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
asapersson3c81a1a2017-06-14 05:52:21 -07003385 channel_->OnReadyToSend(true);
3386
3387 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3388
3389 AddSendStream();
3390
Tommi85959932018-02-07 19:26:06 +01003391 FakeVideoCapturerWithTaskQueue capturer;
asapersson3c81a1a2017-06-14 05:52:21 -07003392 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02003393 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
asapersson3c81a1a2017-06-14 05:52:21 -07003394 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
3395 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
3396
3397 EXPECT_TRUE(channel_->SetSend(true));
3398
3399 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3400 EXPECT_EQ(resolution_scaling_enabled,
3401 send_stream->resolution_scaling_enabled());
3402 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3403
Niels Möllerff40b142018-04-09 08:49:14 +02003404 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003405}
3406
eladalonf1841382017-06-12 01:16:46 -07003407void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3408 bool is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003409 const int kDefaultFps = 30;
magjed509e4fe2016-11-18 01:34:11 -08003410 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003411 cricket::VideoSendParameters parameters;
3412 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003413
kthelgason2bc68642017-02-07 07:02:22 -08003414 MediaConfig media_config = GetMediaConfig();
3415 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003416 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003417 }
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003418 channel_.reset(engine_.CreateChannel(
3419 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003420 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003421
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003422 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003423
3424 AddSendStream();
3425
Tommi85959932018-02-07 19:26:06 +01003426 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07003427 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003428 options.is_screencast = is_screenshare;
Niels Möllerff40b142018-04-09 08:49:14 +02003429 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj26752742016-10-24 01:21:16 -07003430 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
sprangc5d62e22017-04-02 23:53:04 -07003431 capture_format.interval = rtc::kNumNanosecsPerSec / kDefaultFps;
perkj26752742016-10-24 01:21:16 -07003432 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003433
3434 EXPECT_TRUE(channel_->SetSend(true));
3435
solenberge5269742015-09-08 05:13:22 -07003436 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003437
sprangc5d62e22017-04-02 23:53:04 -07003438 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003439 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003440 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3441 EXPECT_EQ(is_screenshare, send_stream->framerate_scaling_enabled());
perkj2d5f0912016-02-29 00:04:41 -08003442
3443 EXPECT_TRUE(capturer.CaptureFrame());
3444 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3445
perkj26752742016-10-24 01:21:16 -07003446 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3447 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
perkj2d5f0912016-02-29 00:04:41 -08003448
Niels Möllerff40b142018-04-09 08:49:14 +02003449 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003450 return;
3451 }
3452
sprangc5d62e22017-04-02 23:53:04 -07003453 if (is_screenshare) {
3454 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3455 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3456 } else {
3457 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3458 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3459 }
3460
perkj803d97f2016-11-01 11:45:46 -07003461 // Trigger overuse.
3462 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3463
3464 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003465 if (is_screenshare) {
3466 wants.max_framerate_fps = (kDefaultFps * 2) / 3;
3467 } else {
3468 wants.max_pixel_count = capture_format.width * capture_format.height - 1;
3469 }
perkj803d97f2016-11-01 11:45:46 -07003470 send_stream->InjectVideoSinkWants(wants);
3471
sprangc5d62e22017-04-02 23:53:04 -07003472 for (int i = 0; i < kDefaultFps; ++i)
3473 EXPECT_TRUE(capturer.CaptureFrame());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003474
sprangc5d62e22017-04-02 23:53:04 -07003475 if (is_screenshare) {
3476 // Drops every third frame.
3477 EXPECT_EQ(kDefaultFps * 2 / 3, send_stream->GetNumberOfSwappedFrames());
3478 EXPECT_EQ(send_stream->GetLastWidth(), capture_format.width);
3479 EXPECT_EQ(send_stream->GetLastHeight(), capture_format.height);
3480 } else {
3481 EXPECT_EQ(kDefaultFps, send_stream->GetNumberOfSwappedFrames());
3482 EXPECT_LT(send_stream->GetLastWidth(), capture_format.width);
3483 EXPECT_LT(send_stream->GetLastHeight(), capture_format.height);
3484 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003485
3486 // Trigger underuse which should go back to normal resolution.
sprang84a37592017-02-10 07:04:27 -08003487 int last_pixel_count =
3488 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003489 if (is_screenshare) {
3490 wants.max_framerate_fps = kDefaultFps;
3491 } else {
3492 wants.max_pixel_count = last_pixel_count * 4;
3493 wants.target_pixel_count.emplace((last_pixel_count * 5) / 3);
3494 }
perkj803d97f2016-11-01 11:45:46 -07003495 send_stream->InjectVideoSinkWants(wants);
3496
sprangc5d62e22017-04-02 23:53:04 -07003497 for (int i = 0; i < kDefaultFps; ++i)
3498 EXPECT_TRUE(capturer.CaptureFrame());
3499
3500 if (is_screenshare) {
3501 EXPECT_EQ(kDefaultFps + (kDefaultFps * 2 / 3),
3502 send_stream->GetNumberOfSwappedFrames());
3503 } else {
3504 EXPECT_EQ(kDefaultFps * 2, send_stream->GetNumberOfSwappedFrames());
3505 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003506
perkj26752742016-10-24 01:21:16 -07003507 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3508 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003509
Niels Möllerff40b142018-04-09 08:49:14 +02003510 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003511}
3512
eladalonf1841382017-06-12 01:16:46 -07003513TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003514 // Start at last timestamp to verify that wraparounds are estimated correctly.
3515 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3516 static const int64_t kInitialNtpTimeMs = 1247891230;
3517 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003518 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003519
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003520 FakeVideoReceiveStream* stream = AddRecvStream();
3521 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003522 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003523
nisse64ec8f82016-09-27 00:17:25 -07003524 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4),
3525 kInitialTimestamp, 0,
3526 webrtc::kVideoRotation_0);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003527 // Initial NTP time is not available on the first frame, but should still be
3528 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003529 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003530
3531 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003532
3533 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3534 // triggers a constant-overflow warning, hence we're calculating it explicitly
3535 // here.
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +02003536 fake_clock_.AdvanceTimeMicros(kFrameOffsetMs * rtc::kNumMicrosecsPerMillisec);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003537 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3538 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003539 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003540
3541 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003542
3543 // Verify that NTP time has been correctly deduced.
3544 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003545 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003546 ASSERT_EQ(1u, info.receivers.size());
3547 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003548}
3549
eladalonf1841382017-06-12 01:16:46 -07003550TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003551 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003552 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003553
3554 VideoCodec codec;
3555 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003556 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003557
3558 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003559 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3560 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003561 FakeVideoSendStream* stream = AddSendStream(
3562 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003563 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003564
3565 // Make sure NACK and FEC are enabled on the correct payload types.
3566 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003567 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3568 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003569
3570 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3571 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003572 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003573 // TODO(juberti): Check RTCP, PLI, TMMBR.
3574}
3575
brandtr31bd2242017-05-19 05:47:46 -07003576// The following four tests ensures that FlexFEC is not activated by default
3577// when the field trials are not enabled.
3578// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3579// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003580TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003581 FakeVideoSendStream* stream = AddSendStream();
3582 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3583
brandtr3d200bd2017-01-16 06:59:19 -08003584 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003585 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3586 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003587}
3588
eladalonf1841382017-06-12 01:16:46 -07003589TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003590 FakeVideoSendStream* stream = AddSendStream(
3591 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3592 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3593
brandtr3d200bd2017-01-16 06:59:19 -08003594 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003595 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3596 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3597}
3598
Yves Gerey665174f2018-06-19 15:03:05 +02003599TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003600 AddRecvStream();
3601
3602 const std::vector<FakeFlexfecReceiveStream*>& streams =
3603 fake_call_->GetFlexfecReceiveStreams();
3604 EXPECT_TRUE(streams.empty());
3605}
3606
eladalonf1841382017-06-12 01:16:46 -07003607TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003608 AddRecvStream(
3609 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3610
3611 const std::vector<FakeFlexfecReceiveStream*>& streams =
3612 fake_call_->GetFlexfecReceiveStreams();
3613 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003614}
3615
3616// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3617// tests that use this test fixture into the corresponding "non-field trial"
3618// tests.
eladalonf1841382017-06-12 01:16:46 -07003619class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003620 public:
eladalonf1841382017-06-12 01:16:46 -07003621 WebRtcVideoChannelFlexfecRecvTest()
3622 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003623};
3624
eladalonf1841382017-06-12 01:16:46 -07003625TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003626 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3627 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3628 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3629}
3630
eladalonf1841382017-06-12 01:16:46 -07003631TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003632 AddRecvStream();
3633
3634 const std::vector<FakeFlexfecReceiveStream*>& streams =
3635 fake_call_->GetFlexfecReceiveStreams();
3636 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003637
3638 const std::vector<FakeVideoReceiveStream*>& video_streams =
3639 fake_call_->GetVideoReceiveStreams();
3640 ASSERT_EQ(1U, video_streams.size());
3641 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3642 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3643 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003644}
3645
eladalonf1841382017-06-12 01:16:46 -07003646TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003647 AddRecvStream(
3648 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3649
3650 const std::vector<FakeFlexfecReceiveStream*>& streams =
3651 fake_call_->GetFlexfecReceiveStreams();
3652 ASSERT_EQ(1U, streams.size());
3653 const FakeFlexfecReceiveStream* stream = streams.front();
3654 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3655 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3656 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3657 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3658 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003659
3660 const std::vector<FakeVideoReceiveStream*>& video_streams =
3661 fake_call_->GetVideoReceiveStreams();
3662 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003663 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3664 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003665 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003666 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003667 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003668}
3669
eladalonf1841382017-06-12 01:16:46 -07003670TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003671 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3672 cricket::VideoRecvParameters recv_parameters;
3673 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3674 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3675
3676 AddRecvStream(
3677 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3678 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003679 const std::vector<FakeVideoReceiveStream*>& video_streams =
3680 fake_call_->GetVideoReceiveStreams();
3681 ASSERT_EQ(1U, video_streams.size());
3682 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3683 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3684 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003685
3686 // Enable FlexFEC.
3687 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3688 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3689 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3690 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3691 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3692 << "Enabling FlexFEC should not create VideoReceiveStream.";
3693 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3694 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003695 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3696 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003697}
3698
eladalonf1841382017-06-12 01:16:46 -07003699TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003700 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3701 cricket::VideoRecvParameters recv_parameters;
3702 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3703 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3704 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3705
3706 AddRecvStream(
3707 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3708 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003709 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003710 const std::vector<FakeVideoReceiveStream*>& video_streams =
3711 fake_call_->GetVideoReceiveStreams();
3712 ASSERT_EQ(1U, video_streams.size());
3713 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3714 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3715 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003716
3717 // Disable FlexFEC.
3718 recv_parameters.codecs.clear();
3719 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3720 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3721 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3722 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3723 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3724 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3725 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3726 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003727 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3728 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003729}
3730
brandtr31bd2242017-05-19 05:47:46 -07003731// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3732// tests that use this test fixture into the corresponding "non-field trial"
3733// tests.
eladalonf1841382017-06-12 01:16:46 -07003734class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003735 public:
eladalonf1841382017-06-12 01:16:46 -07003736 WebRtcVideoChannelFlexfecSendRecvTest()
3737 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003738 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3739 }
3740};
3741
Yves Gerey665174f2018-06-19 15:03:05 +02003742TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003743 FakeVideoSendStream* stream = AddSendStream();
3744 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3745
brandtr3d200bd2017-01-16 06:59:19 -08003746 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3747 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3748 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003749}
3750
eladalonf1841382017-06-12 01:16:46 -07003751TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003752 FakeVideoSendStream* stream = AddSendStream(
3753 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3754 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3755
brandtr3d200bd2017-01-16 06:59:19 -08003756 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3757 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3758 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3759 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003760}
3761
eladalonf1841382017-06-12 01:16:46 -07003762TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003763 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003764 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003765 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003766
3767 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003768 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003769
brandtrb5f2c3f2016-10-04 23:28:39 -07003770 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3771 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003772}
3773
eladalonf1841382017-06-12 01:16:46 -07003774TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003775 cricket::VideoSendParameters parameters;
3776 parameters.codecs.push_back(GetEngineCodec("VP8"));
3777 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3778
3779 FakeVideoSendStream* stream = AddSendStream();
3780 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3781
brandtr3d200bd2017-01-16 06:59:19 -08003782 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003783}
3784
eladalonf1841382017-06-12 01:16:46 -07003785TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003786 AddRecvStream(
3787 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003788
3789 cricket::VideoRecvParameters recv_parameters;
3790 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3791 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3792 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003793
3794 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3795 fake_call_->GetFlexfecReceiveStreams();
3796 ASSERT_EQ(1U, flexfec_streams.size());
3797 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3798 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3799 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003800 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003801 flexfec_stream_config.payload_type);
3802 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3803 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3804 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3805 const std::vector<FakeVideoReceiveStream*>& video_streams =
3806 fake_call_->GetVideoReceiveStreams();
3807 const FakeVideoReceiveStream* video_stream = video_streams.front();
3808 const webrtc::VideoReceiveStream::Config& video_stream_config =
3809 video_stream->GetConfig();
3810 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3811 flexfec_stream_config.local_ssrc);
3812 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3813 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3814 flexfec_stream_config.rtcp_send_transport);
3815 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3816 // spec-compliant way.
3817 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3818 flexfec_stream_config.transport_cc);
3819 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3820 EXPECT_EQ(video_stream_config.rtp.extensions,
3821 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003822}
3823
brandtr31bd2242017-05-19 05:47:46 -07003824// We should not send FlexFEC, even if we advertise it, unless the right
3825// field trial is set.
3826// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003827TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003828 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3829 cricket::VideoSendParameters parameters;
3830 parameters.codecs.push_back(GetEngineCodec("VP8"));
3831 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3832 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3833
3834 FakeVideoSendStream* stream = AddSendStream();
3835 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3836
3837 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003838 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003839 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3840}
3841
eladalonf1841382017-06-12 01:16:46 -07003842TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003843 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3844 cricket::VideoSendParameters parameters;
3845 parameters.codecs.push_back(GetEngineCodec("VP8"));
3846 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3847 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3848
3849 FakeVideoSendStream* stream = AddSendStream(
3850 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3851 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3852
3853 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003854 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003855 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3856}
3857
eladalonf1841382017-06-12 01:16:46 -07003858TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003859 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003860 const int kUnusedPayloadType = 127;
3861 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3862
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003863 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003864 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003865 parameters.codecs.push_back(rtx_codec);
3866 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003867 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003868}
3869
eladalonf1841382017-06-12 01:16:46 -07003870TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003871 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003872 const int kUnusedPayloadType1 = 126;
3873 const int kUnusedPayloadType2 = 127;
3874 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3875 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3876 {
3877 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3878 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3879 cricket::VideoSendParameters parameters;
3880 parameters.codecs.push_back(GetEngineCodec("VP8"));
3881 parameters.codecs.push_back(rtx_codec);
3882 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3883 }
3884 {
3885 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3886 kUnusedPayloadType1, kUnusedPayloadType2);
3887 cricket::VideoSendParameters parameters;
3888 parameters.codecs.push_back(GetEngineCodec("VP8"));
3889 parameters.codecs.push_back(rtx_codec);
3890 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3891 << "RTX without matching video codec should be rejected.";
3892 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003893}
3894
eladalonf1841382017-06-12 01:16:46 -07003895TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003896 const int kUnusedPayloadType1 = 126;
3897 const int kUnusedPayloadType2 = 127;
3898 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3899 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3900
3901 // SSRCs for RTX.
3902 cricket::StreamParams params =
3903 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3904 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3905 AddSendStream(params);
3906
3907 // Original payload type for RTX.
3908 cricket::VideoSendParameters parameters;
3909 parameters.codecs.push_back(GetEngineCodec("VP8"));
3910 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3911 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3912 parameters.codecs.push_back(rtx_codec);
3913 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3914 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3915 const webrtc::VideoSendStream::Config& config_before =
3916 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3917 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3918 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3919 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3920
3921 // Change payload type for RTX.
3922 parameters.codecs[1].id = kUnusedPayloadType2;
3923 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3924 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3925 const webrtc::VideoSendStream::Config& config_after =
3926 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3927 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3928 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3929 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3930}
3931
eladalonf1841382017-06-12 01:16:46 -07003932TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003933 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003934 parameters.codecs.push_back(GetEngineCodec("VP8"));
3935 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003936 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003937
3938 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003939 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003940
magjed509e4fe2016-11-18 01:34:11 -08003941 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003942
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003943 parameters.codecs.pop_back();
3944 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003945 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003946 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003947 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003948 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003949 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3950}
3951
eladalonf1841382017-06-12 01:16:46 -07003952TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003953 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003954 cricket::VideoSendParameters parameters;
3955 parameters.codecs.push_back(GetEngineCodec("VP8"));
3956 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3957 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3958
3959 FakeVideoSendStream* stream = AddSendStream(
3960 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3961 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3962
brandtr3d200bd2017-01-16 06:59:19 -08003963 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3964 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003965 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3966 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
3967
3968 parameters.codecs.pop_back();
3969 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3970 stream = fake_call_->GetVideoSendStreams()[0];
3971 ASSERT_TRUE(stream != nullptr);
3972 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08003973 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003974 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003975}
3976
eladalonf1841382017-06-12 01:16:46 -07003977TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003978 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07003979 cricket::VideoCodec codec(100, "VP8");
3980 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
3981 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07003982
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003983 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003984 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003985
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003986 FakeVideoSendStream* stream = AddSendStream();
Tommi85959932018-02-07 19:26:06 +01003987 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003988 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003989
3990 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003991 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003992
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003993 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07003994 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
3995 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003996 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003997 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003998 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02003999 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004000}
4001
eladalonf1841382017-06-12 01:16:46 -07004002TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004003 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4004 200000);
4005}
4006
eladalonf1841382017-06-12 01:16:46 -07004007TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00004008 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
4009 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
4010 ASSERT_EQ(1u, streams.size());
4011 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
4012}
4013
eladalonf1841382017-06-12 01:16:46 -07004014TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00004015 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004016 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00004017}
4018
eladalonf1841382017-06-12 01:16:46 -07004019TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004020 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004021}
4022
eladalonf1841382017-06-12 01:16:46 -07004023TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004024 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
4025 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
4026 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004027}
4028
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004029// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4030// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07004031TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004032 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4033 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4034 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4035 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004036 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004037 ExpectSetBitrateParameters(100000, 200000, 400000);
4038 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4039 // Since the codec isn't changing, start_bitrate_bps should be -1.
4040 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004041
4042 // Decrease max_bandwidth_bps.
4043 send_parameters_.max_bandwidth_bps = 350000;
4044 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004045
4046 // Now try again with the values flipped around.
4047 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4048 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004049 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004050 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004051
4052 // If we change the codec max, max_bandwidth_bps should still apply.
4053 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004054 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004055 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004056}
4057
Yves Gerey665174f2018-06-19 15:03:05 +02004058TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004059 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4060 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004061 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004062 // Setting max bitrate should keep previous min bitrate.
4063 // Setting max bitrate should not reset start bitrate.
4064 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004065 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004066}
4067
eladalonf1841382017-06-12 01:16:46 -07004068TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004069 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004070 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004071 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004072 // -1 means to disable max bitrate (set infinite).
4073 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004074 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004075 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004076}
4077
eladalonf1841382017-06-12 01:16:46 -07004078TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004079 send_parameters_.max_bandwidth_bps = 99999;
4080 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004081 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004082 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004083 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4084 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4085 stream->GetVideoStreams()[0].max_bitrate_bps);
4086
4087 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004088 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004089 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4090 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004091 stream->GetVideoStreams()[0].max_bitrate_bps);
4092}
4093
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004094// Tests that when the codec specific max bitrate and VideoSendParameters
4095// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4096// appropriately.
4097TEST_F(WebRtcVideoChannelTest,
4098 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4099 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4100 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4101 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4102 send_parameters_.max_bandwidth_bps = -1;
4103 AddSendStream();
4104 ExpectSetMaxBitrate(300000);
4105 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4106
4107 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4108 ASSERT_EQ(1u, video_send_streams.size());
4109 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4110 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4111 // First the max bitrate is set based upon the codec param.
4112 EXPECT_EQ(300000,
4113 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4114
4115 // The VideoSendParameters max bitrate overrides the codec's.
4116 send_parameters_.max_bandwidth_bps = 500000;
4117 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4118 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4119 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4120 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4121}
4122
4123// Tests that when the codec specific max bitrate and RtpParameters
4124// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4125// appropriately.
4126TEST_F(WebRtcVideoChannelTest,
4127 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4128 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4129 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4130 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4131 send_parameters_.max_bandwidth_bps = -1;
4132 AddSendStream();
4133 ExpectSetMaxBitrate(300000);
4134 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4135
4136 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4137 ASSERT_EQ(1u, video_send_streams.size());
4138 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4139 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4140 // First the max bitrate is set based upon the codec param.
4141 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4142
4143 // The RtpParameter max bitrate overrides the codec's.
4144 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4145 ASSERT_EQ(1u, parameters.encodings.size());
4146 parameters.encodings[0].max_bitrate_bps = 500000;
4147 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4148 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4149 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4150 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4151}
4152
Åsa Persson55659812018-06-18 17:51:32 +02004153TEST_F(WebRtcVideoChannelTest,
4154 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4155 send_parameters_.max_bandwidth_bps = 99999;
4156 FakeVideoSendStream* stream = AddSendStream();
4157 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4158 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4159 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4160 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4161 stream->GetVideoStreams()[0].max_bitrate_bps);
4162
4163 // Get and set the rtp encoding parameters.
4164 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4165 EXPECT_EQ(1u, parameters.encodings.size());
4166
4167 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4168 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4169 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4170 stream->GetVideoStreams()[0].max_bitrate_bps);
4171
4172 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4173 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4174 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4175 stream->GetVideoStreams()[0].max_bitrate_bps);
4176}
4177
eladalonf1841382017-06-12 01:16:46 -07004178TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004179 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004180 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004181 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004182 channel_->SetSend(true);
4183
4184 FakeVideoSendStream* stream = AddSendStream();
4185
Tommi85959932018-02-07 19:26:06 +01004186 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004187 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Peter Boström3afc8c42016-01-27 16:45:21 +01004188 EXPECT_EQ(cricket::CS_RUNNING,
4189 capturer.Start(capturer.GetSupportedFormats()->front()));
4190
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004191 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4192 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4193 EXPECT_GT(initial_max_bitrate_bps, 0);
4194
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004195 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4196 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004197 // Insert a frame to update the encoder config.
4198 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004199 streams = stream->GetVideoStreams();
4200 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004201 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004202}
4203
eladalonf1841382017-06-12 01:16:46 -07004204TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004205 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004206 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004207 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004208 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004209 channel_->SetSend(true);
4210
4211 FakeVideoSendStream* stream = AddSendStream(
4212 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4213
4214 // Send a frame to make sure this scales up to >1 stream (simulcast).
Tommi85959932018-02-07 19:26:06 +01004215 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004216 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &capturer));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004217 EXPECT_EQ(cricket::CS_RUNNING,
4218 capturer.Start(capturer.GetSupportedFormats()->front()));
4219 EXPECT_TRUE(capturer.CaptureFrame());
4220
4221 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4222 ASSERT_GT(streams.size(), 1u)
4223 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004224 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004225 EXPECT_GT(initial_max_bitrate_bps, 0);
4226
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004227 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4228 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004229 // Insert a frame to update the encoder config.
4230 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004231 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004232 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004233 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4234
Niels Möllerff40b142018-04-09 08:49:14 +02004235 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004236}
4237
eladalonf1841382017-06-12 01:16:46 -07004238TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004239 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004240 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004241 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004242 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4243 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004244 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004245 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004246
4247 VideoCodec codec;
4248 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4249 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4250}
4251
eladalonf1841382017-06-12 01:16:46 -07004252TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004253 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004254 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004255 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004256 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004257 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004258 parameters.codecs[0].id = kIncorrectPayloads[i];
4259 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004260 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004261 }
4262}
4263
eladalonf1841382017-06-12 01:16:46 -07004264TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004265 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004266 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004267 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004268 parameters.codecs[0].id = payload_type;
4269 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004270 << "Payload type '" << payload_type << "' rejected.";
4271 }
4272}
4273
deadbeef67cf2c12016-04-13 10:07:16 -07004274// Test that setting the a different set of codecs but with an identical front
4275// codec doesn't result in the stream being recreated.
4276// This may happen when a subsequent negotiation includes fewer codecs, as a
4277// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004278TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004279 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4280 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004281 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4282 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004283 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4284
4285 AddSendStream();
4286 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4287
4288 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004289 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004290 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4291 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4292}
4293
eladalonf1841382017-06-12 01:16:46 -07004294TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004295 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004296 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004297 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004298}
4299
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004300// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004301TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004302 const int kUnusedPayloadType1 = 126;
4303 const int kUnusedPayloadType2 = 127;
4304 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4305 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4306
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004307 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004308 parameters.codecs.push_back(GetEngineCodec("VP8"));
4309 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004310 parameters.codecs.push_back(rtx_codec);
4311 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004312 << "RTX codec without associated payload should be rejected.";
4313
magjed509e4fe2016-11-18 01:34:11 -08004314 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004315 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004316 << "RTX codec with invalid associated payload type should be rejected.";
4317
magjed509e4fe2016-11-18 01:34:11 -08004318 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004319 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004320
magjed509e4fe2016-11-18 01:34:11 -08004321 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004322 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004323 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004324
Yves Gerey665174f2018-06-19 15:03:05 +02004325 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4326 << "RTX codec with another RTX as associated payload type should be "
4327 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004328}
4329
eladalonf1841382017-06-12 01:16:46 -07004330TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004331 const int kUnusedPayloadType1 = 126;
4332 const int kUnusedPayloadType2 = 127;
4333 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4334 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4335
4336 // SSRCs for RTX.
4337 cricket::StreamParams params =
4338 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4339 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4340 AddRecvStream(params);
4341
4342 // Original payload type for RTX.
4343 cricket::VideoRecvParameters parameters;
4344 parameters.codecs.push_back(GetEngineCodec("VP8"));
4345 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4346 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4347 parameters.codecs.push_back(rtx_codec);
4348 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4349 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4350 const webrtc::VideoReceiveStream::Config& config_before =
4351 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004352 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4353 const int* payload_type_before = FindKeyByValue(
4354 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4355 ASSERT_NE(payload_type_before, nullptr);
4356 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004357 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4358
4359 // Change payload type for RTX.
4360 parameters.codecs[1].id = kUnusedPayloadType2;
4361 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4362 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4363 const webrtc::VideoReceiveStream::Config& config_after =
4364 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004365 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4366 const int* payload_type_after = FindKeyByValue(
4367 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4368 ASSERT_NE(payload_type_after, nullptr);
4369 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004370 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4371}
4372
eladalonf1841382017-06-12 01:16:46 -07004373TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004374 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004375 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004376 parameters.codecs[0].id = 99;
4377 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004378}
4379
eladalonf1841382017-06-12 01:16:46 -07004380TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004381 cricket::VideoRecvParameters parameters;
4382 parameters.codecs = engine_.codecs();
4383 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004384
4385 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004386 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004387 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004388 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004389}
4390
eladalonf1841382017-06-12 01:16:46 -07004391TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004392 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004393 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004394 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004395 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004396}
4397
eladalonf1841382017-06-12 01:16:46 -07004398TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004399 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004400 parameters.codecs.push_back(GetEngineCodec("VP8"));
4401 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004402 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004403}
4404
eladalonf1841382017-06-12 01:16:46 -07004405TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004406 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004407 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4408 send_parameters.codecs.push_back(GetEngineCodec("red"));
4409 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004410 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004411
4412 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004413
magjed509e4fe2016-11-18 01:34:11 -08004414 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004415 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004416
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004417 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004418 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004419 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004420 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004421 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004422 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004423 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4424}
4425
eladalonf1841382017-06-12 01:16:46 -07004426TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004427 AddRecvStream(
4428 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004429 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004430 fake_call_->GetFlexfecReceiveStreams();
4431
4432 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004433 const FakeFlexfecReceiveStream* stream = streams.front();
4434 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4435 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4436 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4437 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004438
4439 cricket::VideoRecvParameters recv_parameters;
4440 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4441 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4442 EXPECT_TRUE(streams.empty())
4443 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004444}
4445
eladalonf1841382017-06-12 01:16:46 -07004446TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004447 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004448 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004449 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004450
4451 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004452 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4453 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4454 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004455 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4456 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004457 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004458 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004459 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004460 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004461
4462 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004463 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4464 send_parameters.codecs.push_back(GetEngineCodec("red"));
4465 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004466 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4467 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004468 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004469 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004470 << "ULPFEC should be enabled on the receive stream.";
4471}
4472
eladalonf1841382017-06-12 01:16:46 -07004473TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004474 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004475 AddRecvStream(
4476 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004477 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004478 fake_call_->GetFlexfecReceiveStreams();
4479
4480 cricket::VideoRecvParameters recv_parameters;
4481 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4482 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4483 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4484 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004485 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004486 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004487 stream_with_recv_params->GetConfig().payload_type);
4488 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004489 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004490 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004491 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004492 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004493
4494 cricket::VideoSendParameters send_parameters;
4495 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4496 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4497 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4498 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004499 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004500 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004501 stream_with_send_params->GetConfig().payload_type);
4502 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004503 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004504 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004505 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004506 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004507}
4508
eladalonf1841382017-06-12 01:16:46 -07004509TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004510 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004511 parameters.codecs.push_back(GetEngineCodec("VP8"));
4512 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004513 parameters.codecs[1].id = parameters.codecs[0].id;
4514 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004515}
4516
eladalonf1841382017-06-12 01:16:46 -07004517TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004518 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004519 cricket::VideoRecvParameters parameters;
4520 parameters.codecs.push_back(GetEngineCodec("VP8"));
4521 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4522 parameters.codecs[1].id = parameters.codecs[0].id;
4523 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4524}
4525
eladalonf1841382017-06-12 01:16:46 -07004526TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004527 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004528 parameters.codecs.push_back(GetEngineCodec("VP8"));
4529 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004530 parameters.codecs[1].id = parameters.codecs[0].id;
4531 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004532}
4533
eladalonf1841382017-06-12 01:16:46 -07004534TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004535 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004536 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004537 parameters.codecs.push_back(GetEngineCodec("VP8"));
4538 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004539 parameters.codecs[1].id += 1;
4540 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004541}
4542
deadbeef67cf2c12016-04-13 10:07:16 -07004543// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004544// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004545TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004546 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004547 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004548 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4549 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004550 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004551
4552 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4553 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4554
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004555 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004556 parameters2.codecs.push_back(GetEngineCodec("red"));
4557 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004558 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004559 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4560}
4561
eladalonf1841382017-06-12 01:16:46 -07004562TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004563 EXPECT_FALSE(AddSendStream()->IsSending());
4564}
4565
eladalonf1841382017-06-12 01:16:46 -07004566TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004567 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004568}
4569
eladalonf1841382017-06-12 01:16:46 -07004570TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004571 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004572 EXPECT_FALSE(stream->IsSending());
4573
4574 // false->true
4575 EXPECT_TRUE(channel_->SetSend(true));
4576 EXPECT_TRUE(stream->IsSending());
4577 // true->true
4578 EXPECT_TRUE(channel_->SetSend(true));
4579 EXPECT_TRUE(stream->IsSending());
4580 // true->false
4581 EXPECT_TRUE(channel_->SetSend(false));
4582 EXPECT_FALSE(stream->IsSending());
4583 // false->false
4584 EXPECT_TRUE(channel_->SetSend(false));
4585 EXPECT_FALSE(stream->IsSending());
4586
4587 EXPECT_TRUE(channel_->SetSend(true));
4588 FakeVideoSendStream* new_stream = AddSendStream();
4589 EXPECT_TRUE(new_stream->IsSending())
4590 << "Send stream created after SetSend(true) not sending initially.";
4591}
4592
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004593// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004594TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004595 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004596 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004597 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004598 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004599 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004600
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07004601 channel.reset(static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateChannel(
4602 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004603 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004604 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004605 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004606
Tim Haloun648d28a2018-10-18 16:52:22 -07004607 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4608 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004609 config.enable_dscp = true;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07004610 channel.reset(static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateChannel(
4611 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004612 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
Tim Haloun648d28a2018-10-18 16:52:22 -07004613 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4614
4615 // Create a send stream to configure
4616 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4617 parameters = channel->GetRtpSendParameters(kSsrc);
4618 ASSERT_FALSE(parameters.encodings.empty());
4619
4620 // Various priorities map to various dscp values.
4621 parameters.encodings[0].network_priority = 4.0;
4622 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004623 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004624 parameters.encodings[0].network_priority = 0.5;
4625 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4626 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4627
4628 // A bad priority does not change the dscp value.
4629 parameters.encodings[0].network_priority = 0.0;
4630 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4631 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004632
Tim Haloun6ca98362018-09-17 17:06:08 -07004633 // Packets should also self-identify their dscp in PacketOptions.
4634 const uint8_t kData[10] = {0};
4635 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4636 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004637 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004638
nisse51542be2016-02-12 02:27:06 -08004639 // Verify that setting the option to false resets the
4640 // DiffServCodePoint.
4641 config.enable_dscp = false;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07004642 channel.reset(static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateChannel(
4643 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004644 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004645 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004646}
4647
deadbeef13871492015-12-09 12:37:51 -08004648// This test verifies that the RTCP reduced size mode is properly applied to
4649// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004650TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004651 // Create stream, expecting that default mode is "compound".
4652 FakeVideoSendStream* stream1 = AddSendStream();
4653 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004654 webrtc::RtpParameters rtp_parameters =
4655 channel_->GetRtpSendParameters(last_ssrc_);
4656 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004657
4658 // Now enable reduced size mode.
4659 send_parameters_.rtcp.reduced_size = true;
4660 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4661 stream1 = fake_call_->GetVideoSendStreams()[0];
4662 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004663 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4664 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004665
4666 // Create a new stream and ensure it picks up the reduced size mode.
4667 FakeVideoSendStream* stream2 = AddSendStream();
4668 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4669}
4670
4671// This test verifies that the RTCP reduced size mode is properly applied to
4672// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004673TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004674 // Create stream, expecting that default mode is "compound".
4675 FakeVideoReceiveStream* stream1 = AddRecvStream();
4676 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4677
4678 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004679 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4680 // the reduced_size flag should come from that.
4681 send_parameters_.rtcp.reduced_size = true;
4682 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004683 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4684 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4685
4686 // Create a new stream and ensure it picks up the reduced size mode.
4687 FakeVideoReceiveStream* stream2 = AddRecvStream();
4688 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4689}
4690
eladalonf1841382017-06-12 01:16:46 -07004691TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004692 EXPECT_EQ(webrtc::kNetworkUp,
4693 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4694 EXPECT_EQ(webrtc::kNetworkUp,
4695 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004696
4697 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004698 EXPECT_EQ(webrtc::kNetworkDown,
4699 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4700 EXPECT_EQ(webrtc::kNetworkUp,
4701 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004702
4703 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004704 EXPECT_EQ(webrtc::kNetworkUp,
4705 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4706 EXPECT_EQ(webrtc::kNetworkUp,
4707 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004708}
4709
eladalonf1841382017-06-12 01:16:46 -07004710TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004711 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004712 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004713 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004714
4715 AddSendStream();
4716
4717 cricket::VideoMediaInfo info;
4718 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004719 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004720}
4721
eladalonf1841382017-06-12 01:16:46 -07004722TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004723 FakeVideoSendStream* stream = AddSendStream();
4724 webrtc::VideoSendStream::Stats stats;
4725 stats.encoder_implementation_name = "encoder_implementation_name";
4726 stream->SetStats(stats);
4727
4728 cricket::VideoMediaInfo info;
4729 ASSERT_TRUE(channel_->GetStats(&info));
4730 EXPECT_EQ(stats.encoder_implementation_name,
4731 info.senders[0].encoder_implementation_name);
4732}
4733
eladalonf1841382017-06-12 01:16:46 -07004734TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004735 FakeVideoSendStream* stream = AddSendStream();
4736 webrtc::VideoSendStream::Stats stats;
4737 stats.avg_encode_time_ms = 13;
4738 stats.encode_usage_percent = 42;
4739 stream->SetStats(stats);
4740
4741 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004742 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004743 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4744 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4745}
4746
eladalonf1841382017-06-12 01:16:46 -07004747TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004748 FakeVideoSendStream* stream = AddSendStream();
4749 webrtc::VideoSendStream::Stats stats;
4750 stats.frames_encoded = 13;
4751 stream->SetStats(stats);
4752
4753 cricket::VideoMediaInfo info;
4754 ASSERT_TRUE(channel_->GetStats(&info));
4755 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4756}
4757
eladalonf1841382017-06-12 01:16:46 -07004758TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004759 FakeVideoSendStream* stream = AddSendStream();
4760 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004761 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004762 stream->SetStats(stats);
4763
4764 cricket::VideoMediaInfo info;
4765 ASSERT_TRUE(channel_->GetStats(&info));
4766 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4767}
4768
eladalonf1841382017-06-12 01:16:46 -07004769TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004770 FakeVideoSendStream* stream = AddSendStream();
4771 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004772 stats.substreams[17].width = 123;
4773 stats.substreams[17].height = 40;
4774 stats.substreams[42].width = 80;
4775 stats.substreams[42].height = 31;
4776 stats.substreams[11].width = 20;
4777 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004778 stream->SetStats(stats);
4779
4780 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004781 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004782 ASSERT_EQ(1u, info.senders.size());
4783 EXPECT_EQ(123, info.senders[0].send_frame_width);
4784 EXPECT_EQ(90, info.senders[0].send_frame_height);
4785}
4786
eladalonf1841382017-06-12 01:16:46 -07004787TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004788 FakeVideoSendStream* stream = AddSendStream();
4789 webrtc::VideoSendStream::Stats stats;
4790 stats.number_of_cpu_adapt_changes = 2;
4791 stats.cpu_limited_resolution = true;
4792 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004793
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004794 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004795 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004796 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004797 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004798 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004799}
4800
eladalonf1841382017-06-12 01:16:46 -07004801TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004802 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004803 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004804 stats.number_of_cpu_adapt_changes = 2;
4805 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004806 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004807 stream->SetStats(stats);
4808
4809 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004810 EXPECT_TRUE(channel_->GetStats(&info));
4811 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004812 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4813 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004814 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004815 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004816}
4817
eladalonf1841382017-06-12 01:16:46 -07004818TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004819 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4820 FakeVideoSendStream* stream = AddSendStream();
4821 webrtc::VideoSendStream::Stats stats;
4822 stats.bw_limited_resolution = true;
4823 stream->SetStats(stats);
4824
4825 cricket::VideoMediaInfo info;
4826 EXPECT_TRUE(channel_->GetStats(&info));
4827 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004828 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004829 info.senders[0].adapt_reason);
4830}
4831
Yves Gerey665174f2018-06-19 15:03:05 +02004832TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004833 FakeVideoSendStream* stream = AddSendStream();
4834 webrtc::VideoSendStream::Stats stats;
4835 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4836 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4837 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4838
4839 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4840 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4841 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4842
4843 stream->SetStats(stats);
4844
4845 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004846 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004847 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4848 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4849 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4850}
4851
eladalonf1841382017-06-12 01:16:46 -07004852TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004853 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4854 FakeVideoReceiveStream* stream = AddRecvStream();
4855 webrtc::VideoReceiveStream::Stats stats;
4856 stats.rtcp_packet_type_counts.fir_packets = 2;
4857 stats.rtcp_packet_type_counts.nack_packets = 3;
4858 stats.rtcp_packet_type_counts.pli_packets = 4;
4859 stream->SetStats(stats);
4860
4861 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004862 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004863 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004864 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004865 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004866 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004867 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004868 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004869}
4870
eladalonf1841382017-06-12 01:16:46 -07004871TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004872 FakeVideoReceiveStream* stream = AddRecvStream();
4873 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004874 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004875 stats.decode_ms = 2;
4876 stats.max_decode_ms = 3;
4877 stats.current_delay_ms = 4;
4878 stats.target_delay_ms = 5;
4879 stats.jitter_buffer_ms = 6;
4880 stats.min_playout_delay_ms = 7;
4881 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07004882 stats.width = 9;
4883 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08004884 stats.frame_counts.key_frames = 11;
4885 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08004886 stats.frames_rendered = 13;
4887 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01004888 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004889 stream->SetStats(stats);
4890
4891 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004892 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01004893 EXPECT_EQ(stats.decoder_implementation_name,
4894 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004895 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
4896 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
4897 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
4898 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
4899 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
4900 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
4901 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07004902 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
4903 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004904 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
4905 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08004906 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08004907 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07004908 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08004909 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004910}
4911
eladalonf1841382017-06-12 01:16:46 -07004912TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02004913 FakeVideoReceiveStream* stream = AddRecvStream();
4914 webrtc::VideoReceiveStream::Stats stats;
4915 stats.rtp_stats.transmitted.payload_bytes = 2;
4916 stats.rtp_stats.transmitted.header_bytes = 3;
4917 stats.rtp_stats.transmitted.padding_bytes = 4;
4918 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07004919 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02004920 stats.rtcp_stats.fraction_lost = 7;
4921 stream->SetStats(stats);
4922
4923 cricket::VideoMediaInfo info;
4924 ASSERT_TRUE(channel_->GetStats(&info));
4925 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
4926 stats.rtp_stats.transmitted.header_bytes +
4927 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004928 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02004929 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004930 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07004931 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004932 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02004933 info.receivers[0].fraction_lost);
4934}
4935
eladalonf1841382017-06-12 01:16:46 -07004936TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004937 AddSendStream();
4938 AddSendStream();
4939 webrtc::Call::Stats stats;
4940 stats.rtt_ms = 123;
4941 fake_call_->SetStats(stats);
4942
4943 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004944 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004945 ASSERT_EQ(2u, info.senders.size());
4946 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
4947 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
4948}
4949
eladalonf1841382017-06-12 01:16:46 -07004950TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004951 FakeVideoSendStream* stream = AddSendStream();
4952 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004953 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004954 stats.media_bitrate_bps = 123;
4955 stats.substreams[17].total_bitrate_bps = 1;
4956 stats.substreams[17].retransmit_bitrate_bps = 2;
4957 stats.substreams[42].total_bitrate_bps = 3;
4958 stats.substreams[42].retransmit_bitrate_bps = 4;
4959 stream->SetStats(stats);
4960
4961 FakeVideoSendStream* stream2 = AddSendStream();
4962 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004963 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004964 stats2.media_bitrate_bps = 321;
4965 stats2.substreams[13].total_bitrate_bps = 5;
4966 stats2.substreams[13].retransmit_bitrate_bps = 6;
4967 stats2.substreams[21].total_bitrate_bps = 7;
4968 stats2.substreams[21].retransmit_bitrate_bps = 8;
4969 stream2->SetStats(stats2);
4970
4971 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004972 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004973 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07004974 BandwidthEstimationInfo bwe_info;
4975 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004976 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
4977 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
4978 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
4979 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004980 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004981 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004982 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004983 bwe_info.actual_enc_bitrate);
4984 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004985 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07004986 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004987 << "Bandwidth stats should take all streams into account.";
4988}
4989
eladalonf1841382017-06-12 01:16:46 -07004990TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004991 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004992
Peter Boström0c4e06b2015-10-07 12:23:21 +02004993 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4994 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004995
4996 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4997 const size_t kDataLength = 12;
4998 uint8_t data[kDataLength];
4999 memset(data, 0, sizeof(data));
5000 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07005001 rtc::CopyOnWriteBuffer packet(data, kDataLength);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005002 rtc::PacketTime packet_time;
5003 channel_->OnPacketReceived(&packet, packet_time);
5004
5005 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5006 << "No default receive stream created.";
5007 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08005008 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005009 << "Default receive stream should not have configured RTX";
5010
5011 EXPECT_TRUE(channel_->AddRecvStream(
5012 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
5013 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08005014 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005015 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07005016 EXPECT_FALSE(
5017 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07005018 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02005019 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07005020 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02005021 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07005022 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08005023 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005024}
5025
eladalonf1841382017-06-12 01:16:46 -07005026TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005027 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01005028
Peter Boström0c4e06b2015-10-07 12:23:21 +02005029 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5030 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01005031
5032 StreamParams sp =
5033 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5034 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
5035
5036 EXPECT_FALSE(channel_->AddSendStream(sp));
5037 EXPECT_FALSE(channel_->AddRecvStream(sp));
5038}
5039
eladalonf1841382017-06-12 01:16:46 -07005040TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005041 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005042
Peter Boström0c4e06b2015-10-07 12:23:21 +02005043 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5044 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005045
5046 StreamParams sp =
5047 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5048
5049 EXPECT_TRUE(channel_->AddSendStream(sp));
5050 EXPECT_TRUE(channel_->AddRecvStream(sp));
5051
5052 // The RTX SSRC is already used in previous streams, using it should fail.
5053 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5054 EXPECT_FALSE(channel_->AddSendStream(sp));
5055 EXPECT_FALSE(channel_->AddRecvStream(sp));
5056
5057 // After removing the original stream this should be fine to add (makes sure
5058 // that RTX ssrcs are not forever taken).
5059 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5060 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5061 EXPECT_TRUE(channel_->AddSendStream(sp));
5062 EXPECT_TRUE(channel_->AddRecvStream(sp));
5063}
5064
eladalonf1841382017-06-12 01:16:46 -07005065TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005066 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005067 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5068 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005069 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005070
Peter Boströmd6f4c252015-03-26 16:23:04 +01005071 StreamParams sp =
5072 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5073
5074 EXPECT_TRUE(channel_->AddSendStream(sp));
5075 EXPECT_TRUE(channel_->AddRecvStream(sp));
5076
5077 // One of the SSRCs is already used in previous streams, using it should fail.
5078 sp = cricket::CreateSimStreamParams("cname",
5079 MAKE_VECTOR(kOverlappingStreamSsrcs));
5080 EXPECT_FALSE(channel_->AddSendStream(sp));
5081 EXPECT_FALSE(channel_->AddRecvStream(sp));
5082
5083 // After removing the original stream this should be fine to add (makes sure
5084 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005085 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5086 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005087 EXPECT_TRUE(channel_->AddSendStream(sp));
5088 EXPECT_TRUE(channel_->AddRecvStream(sp));
5089}
5090
eladalonf1841382017-06-12 01:16:46 -07005091TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005092 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005093
5094 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5095 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5096
5097 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5098 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5099
5100 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5101
5102 static const uint32_t kReceiverSsrcs[] = {3};
5103 static const uint32_t kReceiverRtxSsrcs[] = {2};
5104
5105 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5106 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5107 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5108
5109 cricket::VideoMediaInfo info;
5110 ASSERT_TRUE(channel_->GetStats(&info));
5111
5112 ASSERT_EQ(1u, info.senders.size());
5113 ASSERT_EQ(1u, info.receivers.size());
5114
5115 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5116 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5117 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5118}
5119
eladalonf1841382017-06-12 01:16:46 -07005120TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005121 FakeVideoReceiveStream* stream = AddRecvStream();
5122 webrtc::VideoReceiveStream::Stats stats;
5123 cricket::VideoMediaInfo info;
5124
5125 // Report no codec name before receiving.
5126 stream->SetStats(stats);
5127 ASSERT_TRUE(channel_->GetStats(&info));
5128 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5129
5130 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005131 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005132 stream->SetStats(stats);
5133 ASSERT_TRUE(channel_->GetStats(&info));
5134 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5135
5136 // Report no codec name for unknown playload types.
5137 stats.current_payload_type = 3;
5138 stream->SetStats(stats);
5139 ASSERT_TRUE(channel_->GetStats(&info));
5140 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5141}
5142
Seth Hampson5897a6e2018-04-03 11:16:33 -07005143// Tests that when we add a stream without SSRCs, but contains a stream_id
5144// that it is stored and its stream id is later used when the first packet
5145// arrives to properly create a receive stream with a sync label.
5146TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5147 const char kSyncLabel[] = "sync_label";
5148 cricket::StreamParams unsignaled_stream;
5149 unsignaled_stream.set_stream_ids({kSyncLabel});
5150 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5151 // The stream shouldn't have been created at this point because it doesn't
5152 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005153 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005154
5155 // Create and deliver packet.
5156 const size_t kDataLength = 12;
5157 uint8_t data[kDataLength];
5158 memset(data, 0, sizeof(data));
5159 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5160 rtc::CopyOnWriteBuffer packet(data, kDataLength);
5161 rtc::PacketTime packet_time;
5162 channel_->OnPacketReceived(&packet, packet_time);
5163
5164 // The stream should now be created with the appropriate sync label.
5165 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5166 EXPECT_EQ(kSyncLabel,
5167 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5168
5169 // Removing the unsignaled stream should clear the cache. This time when
5170 // a default video receive stream is created it won't have a sync_group.
5171 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5172 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5173 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5174
5175 channel_->OnPacketReceived(&packet, packet_time);
5176 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5177 EXPECT_TRUE(
5178 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5179}
5180
eladalonf1841382017-06-12 01:16:46 -07005181void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005182 uint8_t payload_type,
5183 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005184 // kRedRtxPayloadType must currently be unused.
5185 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5186
noahricd10a68e2015-07-10 11:27:55 -07005187 // Add a RED RTX codec.
5188 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005189 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005190 recv_parameters_.codecs.push_back(red_rtx_codec);
5191 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005192
5193 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5194 const size_t kDataLength = 12;
5195 uint8_t data[kDataLength];
5196 memset(data, 0, sizeof(data));
5197
5198 rtc::Set8(data, 1, payload_type);
5199 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005200 rtc::CopyOnWriteBuffer packet(data, kDataLength);
noahricd10a68e2015-07-10 11:27:55 -07005201 rtc::PacketTime packet_time;
5202 channel_->OnPacketReceived(&packet, packet_time);
5203
5204 if (expect_created_receive_stream) {
5205 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5206 << "Should have created a receive stream for payload type: "
5207 << payload_type;
5208 } else {
5209 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5210 << "Shouldn't have created a receive stream for payload type: "
5211 << payload_type;
5212 }
5213}
5214
Åsa Persson2c7149b2018-10-15 09:36:10 +02005215class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5216 public:
5217 WebRtcVideoChannelDiscardUnknownSsrcTest()
5218 : WebRtcVideoChannelTest(
5219 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5220};
5221
5222TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5223 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5224 false /* expect_created_receive_stream */);
5225}
5226
eladalonf1841382017-06-12 01:16:46 -07005227TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005228 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5229 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005230}
5231
eladalonf1841382017-06-12 01:16:46 -07005232TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005233 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5234 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005235}
5236
eladalonf1841382017-06-12 01:16:46 -07005237TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005238 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005239 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5240 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5241 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5242 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005243}
5244
eladalonf1841382017-06-12 01:16:46 -07005245TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005246 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5247 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005248}
5249
eladalonf1841382017-06-12 01:16:46 -07005250TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005251 FlexfecPacketDoesntCreateUnsignalledStream) {
5252 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5253 false /* expect_created_receive_stream */);
5254}
5255
eladalonf1841382017-06-12 01:16:46 -07005256TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005257 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5258 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005259}
5260
mzanaty8a855d62017-02-17 15:46:43 -08005261// Test that receiving any unsignalled SSRC works even if it changes.
5262// The first unsignalled SSRC received will create a default receive stream.
5263// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005264TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005265 // Allow receiving VP8, VP9, H264 (if enabled).
5266 cricket::VideoRecvParameters parameters;
5267 parameters.codecs.push_back(GetEngineCodec("VP8"));
5268 parameters.codecs.push_back(GetEngineCodec("VP9"));
5269
5270#if defined(WEBRTC_USE_H264)
5271 cricket::VideoCodec H264codec(126, "H264");
5272 parameters.codecs.push_back(H264codec);
5273#endif
5274
5275 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5276 // No receive streams yet.
5277 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5278 cricket::FakeVideoRenderer renderer;
5279 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5280
5281 // Receive VP8 packet on first SSRC.
5282 uint8_t data[kMinRtpPacketLen];
5283 cricket::RtpHeader rtpHeader;
5284 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5285 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005286 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005287 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5288 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5289 rtc::PacketTime packet_time;
5290 channel_->OnPacketReceived(&packet, packet_time);
5291 // VP8 packet should create default receive stream.
5292 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005293 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005294 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5295 // Verify that the receive stream sinks to a renderer.
5296 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4), 100, 0,
5297 webrtc::kVideoRotation_0);
5298 recv_stream->InjectFrame(video_frame);
5299 EXPECT_EQ(1, renderer.num_rendered_frames());
5300
5301 // Receive VP9 packet on second SSRC.
5302 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005303 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005304 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5305 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
5306 channel_->OnPacketReceived(&packet2, packet_time);
5307 // VP9 packet should replace the default receive SSRC.
5308 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5309 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5310 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5311 // Verify that the receive stream sinks to a renderer.
5312 webrtc::VideoFrame video_frame2(CreateBlackFrameBuffer(4, 4), 200, 0,
ilnik00d802b2017-04-11 10:34:31 -07005313 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005314 recv_stream->InjectFrame(video_frame2);
5315 EXPECT_EQ(2, renderer.num_rendered_frames());
5316
5317#if defined(WEBRTC_USE_H264)
5318 // Receive H264 packet on third SSRC.
5319 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005320 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005321 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5322 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
5323 channel_->OnPacketReceived(&packet3, packet_time);
5324 // H264 packet should replace the default receive SSRC.
5325 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5326 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5327 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5328 // Verify that the receive stream sinks to a renderer.
5329 webrtc::VideoFrame video_frame3(CreateBlackFrameBuffer(4, 4), 300, 0,
ilnik00d802b2017-04-11 10:34:31 -07005330 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005331 recv_stream->InjectFrame(video_frame3);
5332 EXPECT_EQ(3, renderer.num_rendered_frames());
5333#endif
5334}
5335
brandtr0dc57ea2017-05-29 23:33:31 -07005336// This test verifies that when a new default stream is created for a new
5337// unsignaled SSRC, the new stream does not overwrite any old stream that had
5338// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005339TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005340 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5341 cricket::VideoRecvParameters parameters;
5342 parameters.codecs.push_back(GetEngineCodec("VP8"));
5343 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5344
5345 // No streams signaled and no packets received, so we should not have any
5346 // stream objects created yet.
5347 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5348
5349 // Receive packet on an unsignaled SSRC.
5350 uint8_t data[kMinRtpPacketLen];
5351 cricket::RtpHeader rtp_header;
5352 rtp_header.payload_type = GetEngineCodec("VP8").id;
5353 rtp_header.seq_num = rtp_header.timestamp = 0;
5354 rtp_header.ssrc = kSsrcs3[0];
5355 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5356 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5357 rtc::PacketTime packet_time;
5358 channel_->OnPacketReceived(&packet, packet_time);
5359 // Default receive stream should be created.
5360 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5361 FakeVideoReceiveStream* recv_stream0 =
5362 fake_call_->GetVideoReceiveStreams()[0];
5363 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5364
5365 // Signal the SSRC.
5366 EXPECT_TRUE(
5367 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5368 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5369 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5370 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5371
5372 // Receive packet on a different unsignaled SSRC.
5373 rtp_header.ssrc = kSsrcs3[1];
5374 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5375 packet.SetData(data, sizeof(data));
5376 channel_->OnPacketReceived(&packet, packet_time);
5377 // New default receive stream should be created, but old stream should remain.
5378 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5379 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5380 FakeVideoReceiveStream* recv_stream1 =
5381 fake_call_->GetVideoReceiveStreams()[1];
5382 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5383}
5384
Seth Hampson7c682e02018-05-04 16:28:15 -07005385TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005386 AddSendStream();
5387
Tommi85959932018-02-07 19:26:06 +01005388 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02005389 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
skvladdc1c62c2016-03-16 19:07:43 -07005390 cricket::VideoFormat capture_format_hd =
5391 capturer.GetSupportedFormats()->front();
5392 EXPECT_EQ(1280, capture_format_hd.width);
5393 EXPECT_EQ(720, capture_format_hd.height);
5394 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
5395 EXPECT_TRUE(channel_->SetSend(true));
perkjfa10b552016-10-02 23:45:26 -07005396 capturer.CaptureFrame();
skvladdc1c62c2016-03-16 19:07:43 -07005397
perkjfa10b552016-10-02 23:45:26 -07005398 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005399 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005400
5401 // TODO(skvlad): Resolve the inconsistency between the interpretation
5402 // of the global bitrate limit for audio and video:
5403 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5404 // max_bandwidth_bps = -1 - remove the bandwidth limit
5405 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005406 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005407
perkjfa10b552016-10-02 23:45:26 -07005408 SetAndExpectMaxBitrate(1000, 0, 1000);
5409 SetAndExpectMaxBitrate(1000, 800, 800);
5410 SetAndExpectMaxBitrate(600, 800, 600);
5411 SetAndExpectMaxBitrate(0, 800, 800);
5412 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005413
Niels Möllerff40b142018-04-09 08:49:14 +02005414 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005415}
5416
eladalonf1841382017-06-12 01:16:46 -07005417TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005418 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005419 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005420 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005421
5422 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005423 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005424 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005425}
5426
eladalonf1841382017-06-12 01:16:46 -07005427TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005428 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005429 FakeVideoSendStream* stream = AddSendStream();
5430
Seth Hampson7c682e02018-05-04 16:28:15 -07005431 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5432 EXPECT_EQ(1UL, parameters.encodings.size());
5433 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5434 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5435
5436 // Note that this is testing the behavior of the FakeVideoSendStream, which
5437 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5438 // we are just testing the behavior of
5439 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005440 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5441 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005442
5443 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5444 // by this amount.
5445 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5446 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5447 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5448 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5449
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005450 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5451 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5452 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5453}
5454
5455TEST_F(WebRtcVideoChannelTest,
5456 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5457 FakeVideoSendStream* stream = AddSendStream();
5458
5459 // Note that this is testing the behavior of the FakeVideoSendStream, which
5460 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5461 // we are just testing the behavior of
5462 // EncoderStreamFactory::CreateEncoderStreams.
5463 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5464 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5465
5466 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5467 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5468 EXPECT_EQ(1UL, parameters.encodings.size());
5469 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5470 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5471
5472 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5473 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5474 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5475}
5476
5477TEST_F(WebRtcVideoChannelTest,
5478 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5479 send_parameters_.max_bandwidth_bps = 99999;
5480 FakeVideoSendStream* stream = AddSendStream();
5481 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5482 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5483 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5484 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5485 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5486 stream->GetVideoStreams()[0].max_bitrate_bps);
5487
5488 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5489 // adjusted down.
5490 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5491 EXPECT_EQ(1UL, parameters.encodings.size());
5492 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5493 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5494 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5495 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5496 stream->GetVideoStreams()[0].min_bitrate_bps);
5497 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5498 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005499}
5500
Åsa Persson8c1bf952018-09-13 10:42:19 +02005501TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5502 FakeVideoSendStream* stream = AddSendStream();
5503
5504 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5505 EXPECT_EQ(1UL, parameters.encodings.size());
5506 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5507 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5508
5509 // Note that this is testing the behavior of the FakeVideoSendStream, which
5510 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5511 // we are just testing the behavior of
5512 // EncoderStreamFactory::CreateEncoderStreams.
5513 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5514 EXPECT_EQ(kDefaultVideoMaxFramerate,
5515 stream->GetVideoStreams()[0].max_framerate);
5516
5517 // Set max framerate and check that VideoStream.max_framerate is set.
5518 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5519 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5520 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5521 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5522
5523 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5524 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5525}
5526
Åsa Persson23eba222018-10-02 14:47:06 +02005527TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5528 FakeVideoSendStream* stream = AddSendStream();
5529
5530 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5531 EXPECT_EQ(1UL, parameters.encodings.size());
5532 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5533 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5534
5535 // Note that this is testing the behavior of the FakeVideoSendStream, which
5536 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5537 // we are just testing the behavior of
5538 // EncoderStreamFactory::CreateEncoderStreams.
5539 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5540 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5541
5542 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5543 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5544 parameters.encodings[0].num_temporal_layers = 2;
5545 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5546
5547 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5548 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5549}
5550
Seth Hampson7c682e02018-05-04 16:28:15 -07005551TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005552 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005553 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005554 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005555 // Two or more encodings should result in failure.
5556 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005557 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005558 // Zero encodings should also fail.
5559 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005560 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005561}
5562
Zach Stein3ca452b2018-01-18 10:01:24 -08005563TEST_F(WebRtcVideoChannelTest,
5564 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5565 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5566 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5567 AddSendStream(sp);
5568
5569 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5570
5571 // Additional encodings should result in failure.
5572 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005573 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005574 // Zero encodings should also fail.
5575 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005576 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005577}
5578
deadbeeffb2aced2017-01-06 23:05:37 -08005579// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005580TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005581 AddSendStream();
5582 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005583 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005584 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005585}
5586
Seth Hampson24722b32017-12-22 09:36:42 -08005587// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5588// a value <= 0, setting the parameters returns false.
5589TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5590 AddSendStream();
5591 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5592 EXPECT_EQ(1UL, parameters.encodings.size());
5593 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5594 parameters.encodings[0].bitrate_priority);
5595
5596 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005597 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005598 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005599 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005600}
5601
5602// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5603// properly on the VideoChannel and propogates down to the video encoder.
5604TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5605 AddSendStream();
5606 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5607 EXPECT_EQ(1UL, parameters.encodings.size());
5608 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5609 parameters.encodings[0].bitrate_priority);
5610
5611 // Change the value and set it on the VideoChannel.
5612 double new_bitrate_priority = 2.0;
5613 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005614 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005615
5616 // Verify that the encoding parameters bitrate_priority is set for the
5617 // VideoChannel.
5618 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5619 EXPECT_EQ(1UL, parameters.encodings.size());
5620 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5621
5622 // Verify that the new value propagated down to the encoder.
5623 std::vector<FakeVideoSendStream*> video_send_streams =
5624 fake_call_->GetVideoSendStreams();
5625 EXPECT_EQ(1UL, video_send_streams.size());
5626 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5627 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5628 // appropriately.
5629 EXPECT_EQ(new_bitrate_priority,
5630 video_send_stream->GetEncoderConfig().bitrate_priority);
5631 // Check that the vector of VideoStreams also was propagated correctly. Note
5632 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5633 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005634 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005635 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5636}
5637
5638// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5639// VideoChannel and the value propogates to the video encoder with all simulcast
5640// streams.
5641TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5642 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005643 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005644 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5645 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5646 AddSendStream(stream_params);
5647 uint32_t primary_ssrc = stream_params.first_ssrc();
5648
Tommi85959932018-02-07 19:26:06 +01005649 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
5650 // frame. This creates multiple VideoStreams for all simulcast layers when
5651 // reconfiguring, and allows us to test this behavior.
5652 FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson24722b32017-12-22 09:36:42 -08005653 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02005654 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson24722b32017-12-22 09:36:42 -08005655 EXPECT_EQ(cricket::CS_RUNNING,
5656 capturer.Start(cricket::VideoFormat(
5657 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
5658 cricket::FOURCC_I420)));
5659 channel_->SetSend(true);
5660 EXPECT_TRUE(capturer.CaptureFrame());
5661 // Get and set the rtp encoding parameters.
5662 webrtc::RtpParameters parameters =
5663 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005664 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005665 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5666 parameters.encodings[0].bitrate_priority);
5667 // Change the value and set it on the VideoChannel.
5668 double new_bitrate_priority = 2.0;
5669 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005670 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005671
5672 // Verify that the encoding parameters priority is set on the VideoChannel.
5673 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005674 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005675 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5676
5677 // Verify that the new value propagated down to the encoder.
5678 std::vector<FakeVideoSendStream*> video_send_streams =
5679 fake_call_->GetVideoSendStreams();
5680 EXPECT_EQ(1UL, video_send_streams.size());
5681 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5682 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5683 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005684 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005685 video_send_stream->GetEncoderConfig().number_of_streams);
5686 EXPECT_EQ(new_bitrate_priority,
5687 video_send_stream->GetEncoderConfig().bitrate_priority);
5688 // Check that the vector of VideoStreams also propagated correctly. The
5689 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5690 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005691 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005692 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005693 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5694 // Since we are only setting bitrate priority per-sender, the other
5695 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005696 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005697 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005698 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005699 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005700 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005701}
5702
Tim Haloun648d28a2018-10-18 16:52:22 -07005703// RTCRtpEncodingParameters.network_priority must be one of a few values
5704// derived from the default priority, corresponding to very-low, low, medium,
5705// or high.
5706TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
5707 AddSendStream();
5708 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5709 EXPECT_EQ(1UL, parameters.encodings.size());
5710 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5711 parameters.encodings[0].network_priority);
5712
5713 double good_values[] = {0.5, 1.0, 2.0, 4.0};
5714 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
5715 for (auto it : good_values) {
5716 parameters.encodings[0].network_priority = it;
5717 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5718 }
5719 for (auto it : bad_values) {
5720 parameters.encodings[0].network_priority = it;
5721 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5722 }
5723}
5724
Åsa Persson8c1bf952018-09-13 10:42:19 +02005725TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
5726 const size_t kNumSimulcastStreams = 3;
5727 SetUpSimulcast(true, false);
5728
5729 // Get and set the rtp encoding parameters.
5730 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5731 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5732 for (const auto& encoding : parameters.encodings) {
5733 EXPECT_FALSE(encoding.max_framerate);
5734 }
5735
5736 // Change the value and set it on the VideoChannel.
5737 parameters.encodings[0].max_framerate = 10;
5738 parameters.encodings[1].max_framerate = 20;
5739 parameters.encodings[2].max_framerate = 25;
5740 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5741
5742 // Verify that the bitrates are set on the VideoChannel.
5743 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5744 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5745 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
5746 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
5747 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
5748}
5749
Åsa Persson23eba222018-10-02 14:47:06 +02005750TEST_F(WebRtcVideoChannelTest,
5751 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
5752 const size_t kNumSimulcastStreams = 3;
5753 SetUpSimulcast(true, false);
5754
5755 // Get and set the rtp encoding parameters.
5756 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5757 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5758
5759 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
5760 parameters.encodings[0].num_temporal_layers = 0;
5761 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5762 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5763 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
5764 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5765 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5766}
5767
5768TEST_F(WebRtcVideoChannelTest,
5769 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
5770 const size_t kNumSimulcastStreams = 3;
5771 SetUpSimulcast(true, false);
5772
5773 // Get and set the rtp encoding parameters.
5774 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5775 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5776
5777 // No/all layers should be set.
5778 parameters.encodings[0].num_temporal_layers = 1;
5779 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5780 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5781
5782 // Different values not supported.
5783 parameters.encodings[0].num_temporal_layers = 1;
5784 parameters.encodings[1].num_temporal_layers = 2;
5785 parameters.encodings[2].num_temporal_layers = 2;
5786 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5787 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5788}
5789
5790TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
5791 const size_t kNumSimulcastStreams = 3;
5792 SetUpSimulcast(true, false);
5793
5794 // Get and set the rtp encoding parameters.
5795 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5796 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5797 for (const auto& encoding : parameters.encodings)
5798 EXPECT_FALSE(encoding.num_temporal_layers);
5799
5800 // Change the value and set it on the VideoChannel.
5801 parameters.encodings[0].num_temporal_layers = 3;
5802 parameters.encodings[1].num_temporal_layers = 3;
5803 parameters.encodings[2].num_temporal_layers = 3;
5804 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5805
5806 // Verify that the number of temporal layers are set on the VideoChannel.
5807 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5808 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5809 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
5810 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
5811 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
5812}
5813
5814TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
5815 const size_t kNumSimulcastStreams = 3;
5816 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5817
5818 // Send a full size frame so all simulcast layers are used when reconfiguring.
5819 FakeVideoCapturerWithTaskQueue capturer;
5820 VideoOptions options;
5821 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5822 EXPECT_EQ(cricket::CS_RUNNING,
5823 capturer.Start(capturer.GetSupportedFormats()->front()));
5824 channel_->SetSend(true);
5825 EXPECT_TRUE(capturer.CaptureFrame());
5826
5827 // Get and set the rtp encoding parameters.
5828 // Change the value and set it on the VideoChannel.
5829 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5830 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5831 parameters.encodings[0].num_temporal_layers = 2;
5832 parameters.encodings[1].num_temporal_layers = 2;
5833 parameters.encodings[2].num_temporal_layers = 2;
5834 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5835
5836 // Verify that the new value is propagated down to the encoder.
5837 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5838 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5839 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5840 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5841 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5842 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
5843 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
5844 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
5845
5846 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5847 // VideoStreams are created appropriately for the simulcast case.
5848 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5849 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5850 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
5851 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
5852
5853 // No parameter changed, encoder should not be reconfigured.
5854 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5855 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5856
5857 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5858}
5859
5860TEST_F(WebRtcVideoChannelTest,
5861 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
5862 const size_t kDefaultNumTemporalLayers = 3;
5863 const size_t kNumSimulcastStreams = 3;
5864 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5865
5866 // Send a full size frame so all simulcast layers are used when reconfiguring.
5867 FakeVideoCapturerWithTaskQueue capturer;
5868 VideoOptions options;
5869 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5870 EXPECT_EQ(cricket::CS_RUNNING,
5871 capturer.Start(capturer.GetSupportedFormats()->front()));
5872 channel_->SetSend(true);
5873 EXPECT_TRUE(capturer.CaptureFrame());
5874
5875 // Change rtp encoding parameters, num_temporal_layers not changed.
5876 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5877 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5878 parameters.encodings[0].min_bitrate_bps = 33000;
5879 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5880
5881 // Verify that no value is propagated down to the encoder.
5882 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5883 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5884 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5885 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
5886 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
5887 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
5888
5889 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5890 // VideoStreams are created appropriately for the simulcast case.
5891 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5892 EXPECT_EQ(kDefaultNumTemporalLayers,
5893 stream->GetVideoStreams()[0].num_temporal_layers);
5894 EXPECT_EQ(kDefaultNumTemporalLayers,
5895 stream->GetVideoStreams()[1].num_temporal_layers);
5896 EXPECT_EQ(kDefaultNumTemporalLayers,
5897 stream->GetVideoStreams()[2].num_temporal_layers);
5898
5899 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5900}
5901
Åsa Persson8c1bf952018-09-13 10:42:19 +02005902TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
5903 const size_t kNumSimulcastStreams = 3;
5904 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5905
5906 // Send a full size frame so all simulcast layers are used when reconfiguring.
5907 FakeVideoCapturerWithTaskQueue capturer;
5908 VideoOptions options;
5909 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5910 EXPECT_EQ(cricket::CS_RUNNING,
5911 capturer.Start(capturer.GetSupportedFormats()->front()));
5912 channel_->SetSend(true);
5913 EXPECT_TRUE(capturer.CaptureFrame());
5914
5915 // Get and set the rtp encoding parameters.
5916 // Change the value and set it on the VideoChannel.
5917 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5918 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5919 parameters.encodings[0].max_framerate = 15;
5920 parameters.encodings[1].max_framerate = 25;
5921 parameters.encodings[2].max_framerate = 20;
5922 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5923
5924 // Verify that the new value propagated down to the encoder.
5925 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5926 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5927 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5928 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5929 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5930 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5931 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
5932 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5933
5934 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5935 // VideoStreams are created appropriately for the simulcast case.
5936 // Currently the maximum |max_framerate| is used.
5937 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5938 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
5939 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
5940 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
5941
5942 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5943}
5944
5945TEST_F(WebRtcVideoChannelTest,
5946 DefaultValuePropagatedToEncoderForUnsetFramerate) {
5947 const size_t kNumSimulcastStreams = 3;
5948 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5949 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5950
5951 // Send a full size frame so all simulcast layers are used when reconfiguring.
5952 FakeVideoCapturerWithTaskQueue capturer;
5953 VideoOptions options;
5954 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5955 EXPECT_EQ(cricket::CS_RUNNING,
5956 capturer.Start(capturer.GetSupportedFormats()->front()));
5957 channel_->SetSend(true);
5958 EXPECT_TRUE(capturer.CaptureFrame());
5959
5960 // Get and set the rtp encoding parameters.
5961 // Change the value and set it on the VideoChannel.
5962 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5963 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5964 parameters.encodings[0].max_framerate = 15;
5965 parameters.encodings[2].max_framerate = 20;
5966 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5967
5968 // Verify that the new value propagated down to the encoder.
5969 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5970 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5971 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5972 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5973 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5974 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
5975 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5976
5977 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5978 // VideoStreams are created appropriately for the simulcast case.
5979 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
5980 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5981 EXPECT_EQ(kDefaultVideoMaxFramerate,
5982 stream->GetVideoStreams()[0].max_framerate);
5983 EXPECT_EQ(kDefaultVideoMaxFramerate,
5984 stream->GetVideoStreams()[1].max_framerate);
5985 EXPECT_EQ(kDefaultVideoMaxFramerate,
5986 stream->GetVideoStreams()[2].max_framerate);
5987
5988 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5989}
5990
Åsa Persson55659812018-06-18 17:51:32 +02005991TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
5992 const size_t kNumSimulcastStreams = 3;
5993 SetUpSimulcast(true, false);
5994
5995 // Get and set the rtp encoding parameters.
5996 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5997 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5998 for (const auto& encoding : parameters.encodings) {
5999 EXPECT_FALSE(encoding.min_bitrate_bps);
6000 EXPECT_FALSE(encoding.max_bitrate_bps);
6001 }
6002
6003 // Change the value and set it on the VideoChannel.
6004 parameters.encodings[0].min_bitrate_bps = 100000;
6005 parameters.encodings[0].max_bitrate_bps = 200000;
6006 parameters.encodings[1].min_bitrate_bps = 300000;
6007 parameters.encodings[1].max_bitrate_bps = 400000;
6008 parameters.encodings[2].min_bitrate_bps = 500000;
6009 parameters.encodings[2].max_bitrate_bps = 600000;
6010 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6011
6012 // Verify that the bitrates are set on the VideoChannel.
6013 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6014 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6015 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6016 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6017 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6018 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6019 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6020 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6021}
6022
6023TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6024 const size_t kNumSimulcastStreams = 3;
6025 SetUpSimulcast(true, false);
6026
6027 // Get and set the rtp encoding parameters.
6028 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6029 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6030
6031 // Max bitrate lower than min bitrate should fail.
6032 parameters.encodings[2].min_bitrate_bps = 100000;
6033 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6034 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6035 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6036}
6037
6038// Test that min and max bitrate values set via RtpParameters are correctly
6039// propagated to the underlying encoder, and that the target is set to 3/4 of
6040// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6041// that are used if no min/max are specified).
6042TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6043 const size_t kNumSimulcastStreams = 3;
6044 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6045
6046 // Send a full size frame so all simulcast layers are used when reconfiguring.
6047 FakeVideoCapturerWithTaskQueue capturer;
6048 VideoOptions options;
6049 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6050 EXPECT_EQ(cricket::CS_RUNNING,
6051 capturer.Start(capturer.GetSupportedFormats()->front()));
6052 channel_->SetSend(true);
6053 EXPECT_TRUE(capturer.CaptureFrame());
6054
6055 // Get and set the rtp encoding parameters.
6056 // Change the value and set it on the VideoChannel.
6057 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6058 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6059 parameters.encodings[0].min_bitrate_bps = 100000;
6060 parameters.encodings[0].max_bitrate_bps = 200000;
6061 parameters.encodings[1].min_bitrate_bps = 300000;
6062 parameters.encodings[1].max_bitrate_bps = 400000;
6063 parameters.encodings[2].min_bitrate_bps = 500000;
6064 parameters.encodings[2].max_bitrate_bps = 600000;
6065 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6066
6067 // Verify that the new value propagated down to the encoder.
6068 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6069 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6070 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6071 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6072 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6073 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6074 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6075 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6076 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6077 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6078 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6079
6080 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6081 // VideoStreams are created appropriately for the simulcast case.
6082 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6083 // Target bitrate: 200000 * 3 / 4 = 150000.
6084 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6085 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6086 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6087 // Target bitrate: 400000 * 3 / 4 = 300000.
6088 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6089 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6090 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6091 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6092 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6093 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6094 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6095
6096 // No parameter changed, encoder should not be reconfigured.
6097 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6098 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6099
6100 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6101}
6102
6103// Test to only specify the min or max bitrate value for a layer via
6104// RtpParameters. The unspecified min/max and target value should be set to the
6105// simulcast default that is used if no min/max are specified.
6106TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6107 const size_t kNumSimulcastStreams = 3;
6108 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6109 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6110
6111 // Send a full size frame so all simulcast layers are used when reconfiguring.
6112 FakeVideoCapturerWithTaskQueue capturer;
6113 VideoOptions options;
6114 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6115 EXPECT_EQ(cricket::CS_RUNNING,
6116 capturer.Start(capturer.GetSupportedFormats()->front()));
6117 channel_->SetSend(true);
6118 EXPECT_TRUE(capturer.CaptureFrame());
6119
6120 // Get and set the rtp encoding parameters.
6121 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6122 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6123
6124 // Change the value and set it on the VideoChannel.
6125 // Layer 0: only configure min bitrate.
6126 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6127 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6128 // Layer 1: only configure max bitrate.
6129 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6130 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6131 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6132
6133 // Verify that the new value propagated down to the encoder.
6134 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6135 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6136 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6137 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6138 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6139 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6140 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6141 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6142 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6143 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6144
6145 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6146 // VideoStreams are created appropriately for the simulcast case.
6147 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6148 // Layer 0: min configured bitrate should overwrite min default.
6149 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6150 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6151 stream->GetVideoStreams()[0].target_bitrate_bps);
6152 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6153 stream->GetVideoStreams()[0].max_bitrate_bps);
6154 // Layer 1: max configured bitrate should overwrite max default.
6155 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6156 stream->GetVideoStreams()[1].min_bitrate_bps);
6157 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6158 stream->GetVideoStreams()[1].target_bitrate_bps);
6159 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6160 // Layer 2: min and max bitrate not configured, default expected.
6161 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6162 stream->GetVideoStreams()[2].min_bitrate_bps);
6163 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6164 stream->GetVideoStreams()[2].target_bitrate_bps);
6165 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6166 stream->GetVideoStreams()[2].max_bitrate_bps);
6167
6168 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6169}
6170
6171// Test that specifying the min (or max) bitrate value for a layer via
6172// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6173// unspecified values accordingly.
6174TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6175 const size_t kNumSimulcastStreams = 3;
6176 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6177 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6178
6179 // Send a full size frame so all simulcast layers are used when reconfiguring.
6180 FakeVideoCapturerWithTaskQueue capturer;
6181 VideoOptions options;
6182 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6183 EXPECT_EQ(cricket::CS_RUNNING,
6184 capturer.Start(capturer.GetSupportedFormats()->front()));
6185 channel_->SetSend(true);
6186 EXPECT_TRUE(capturer.CaptureFrame());
6187
6188 // Get and set the rtp encoding parameters.
6189 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6190 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6191
6192 // Change the value and set it on the VideoChannel.
6193 // For layer 0, set the min bitrate above the default max.
6194 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6195 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6196 // For layer 1, set the max bitrate below the default min.
6197 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6198 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6199 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6200
6201 // Verify that the new value propagated down to the encoder.
6202 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6203 // VideoStreams are created appropriately for the simulcast case.
6204 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6205 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6206 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6207 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6208 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6209 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6210 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6211 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6212 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6213 // Layer 2: min and max bitrate not configured, default expected.
6214 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6215 stream->GetVideoStreams()[2].min_bitrate_bps);
6216 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6217 stream->GetVideoStreams()[2].target_bitrate_bps);
6218 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6219 stream->GetVideoStreams()[2].max_bitrate_bps);
6220
6221 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6222}
6223
6224TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6225 const size_t kNumSimulcastStreams = 3;
6226 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6227 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6228
6229 // Send a full size frame so all simulcast layers are used when reconfiguring.
6230 FakeVideoCapturerWithTaskQueue capturer;
6231 VideoOptions options;
6232 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6233 EXPECT_EQ(cricket::CS_RUNNING,
6234 capturer.Start(capturer.GetSupportedFormats()->front()));
6235 channel_->SetSend(true);
6236 EXPECT_TRUE(capturer.CaptureFrame());
6237
6238 // Set max bitrate for all but the highest layer.
6239 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6240 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6241 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6242 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6243 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6244
6245 // Set max bandwidth equal to total max bitrate.
6246 send_parameters_.max_bandwidth_bps =
6247 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6248 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6249 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6250
6251 // No bitrate above the total max to give to the highest layer.
6252 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6253 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6254 stream->GetVideoStreams()[2].max_bitrate_bps);
6255
6256 // Set max bandwidth above the total max bitrate.
6257 send_parameters_.max_bandwidth_bps =
6258 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6259 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6260 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6261
6262 // The highest layer has no max bitrate set -> the bitrate above the total
6263 // max should be given to the highest layer.
6264 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6265 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6266 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6267 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6268 stream->GetVideoStreams()[2].max_bitrate_bps);
6269
6270 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6271}
6272
6273TEST_F(WebRtcVideoChannelTest,
6274 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6275 const size_t kNumSimulcastStreams = 3;
6276 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6277 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6278 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6279
6280 // Send a full size frame so all simulcast layers are used when reconfiguring.
6281 FakeVideoCapturerWithTaskQueue capturer;
6282 VideoOptions options;
6283 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6284 EXPECT_EQ(cricket::CS_RUNNING,
6285 capturer.Start(capturer.GetSupportedFormats()->front()));
6286 channel_->SetSend(true);
6287 EXPECT_TRUE(capturer.CaptureFrame());
6288
6289 // Set max bitrate for the highest layer.
6290 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6291 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6292 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6293 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6294
6295 // Set max bandwidth above the total max bitrate.
6296 send_parameters_.max_bandwidth_bps =
6297 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6298 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6299 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6300
6301 // The highest layer has the max bitrate set -> the bitrate above the total
6302 // max should not be given to the highest layer.
6303 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6304 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6305 stream->GetVideoStreams()[2].max_bitrate_bps);
6306
6307 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6308}
6309
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006310// Test that min and max bitrate values set via RtpParameters are correctly
6311// propagated to the underlying encoder for a single stream.
6312TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6313 FakeVideoSendStream* stream = AddSendStream();
6314 EXPECT_TRUE(channel_->SetSend(true));
6315 EXPECT_TRUE(stream->IsSending());
6316
6317 // Set min and max bitrate.
6318 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6319 EXPECT_EQ(1u, parameters.encodings.size());
6320 parameters.encodings[0].min_bitrate_bps = 80000;
6321 parameters.encodings[0].max_bitrate_bps = 150000;
6322 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6323
6324 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6325 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6326 EXPECT_EQ(1u, encoder_config.number_of_streams);
6327 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6328 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6329 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6330
6331 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6332 // VideoStreams are created appropriately.
6333 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6334 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6335 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6336 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6337}
6338
6339// Test the default min and max bitrate value are correctly propagated to the
6340// underlying encoder for a single stream (when the values are not set via
6341// RtpParameters).
6342TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6343 FakeVideoSendStream* stream = AddSendStream();
6344 EXPECT_TRUE(channel_->SetSend(true));
6345 EXPECT_TRUE(stream->IsSending());
6346
6347 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6348 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6349 EXPECT_EQ(1u, encoder_config.number_of_streams);
6350 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6351 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6352 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6353
6354 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6355 // VideoStreams are created appropriately.
6356 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6357 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6358 stream->GetVideoStreams()[0].min_bitrate_bps);
6359 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6360 stream->GetVideoStreams()[0].min_bitrate_bps);
6361 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6362 stream->GetVideoStreams()[0].target_bitrate_bps);
6363}
6364
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006365// Test that a stream will not be sending if its encoding is made inactive
6366// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006367TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006368 FakeVideoSendStream* stream = AddSendStream();
6369 EXPECT_TRUE(channel_->SetSend(true));
6370 EXPECT_TRUE(stream->IsSending());
6371
6372 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006373 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006374 ASSERT_EQ(1u, parameters.encodings.size());
6375 ASSERT_TRUE(parameters.encodings[0].active);
6376 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006377 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006378 EXPECT_FALSE(stream->IsSending());
6379
6380 // Now change it back to active and verify we resume sending.
6381 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006382 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006383 EXPECT_TRUE(stream->IsSending());
6384}
6385
Seth Hampson8234ead2018-02-02 15:16:24 -08006386// Tests that when active is updated for any simulcast layer then the send
6387// stream's sending state will be updated and it will be reconfigured with the
6388// new appropriate active simulcast streams.
6389TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6390 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006391 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006392 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6393 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6394 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6395 uint32_t primary_ssrc = stream_params.first_ssrc();
6396
Tommi85959932018-02-07 19:26:06 +01006397 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
6398 // frame. This allows us to test that ReconfigureEncoder is called
6399 // appropriately.
6400 cricket::FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson8234ead2018-02-02 15:16:24 -08006401 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02006402 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson8234ead2018-02-02 15:16:24 -08006403 EXPECT_EQ(cricket::CS_RUNNING,
6404 capturer.Start(cricket::VideoFormat(
6405 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
6406 cricket::FOURCC_I420)));
6407 channel_->SetSend(true);
6408 EXPECT_TRUE(capturer.CaptureFrame());
6409
6410 // Check that all encodings are initially active.
6411 webrtc::RtpParameters parameters =
6412 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006413 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006414 EXPECT_TRUE(parameters.encodings[0].active);
6415 EXPECT_TRUE(parameters.encodings[1].active);
6416 EXPECT_TRUE(parameters.encodings[2].active);
6417 EXPECT_TRUE(fake_video_send_stream->IsSending());
6418
6419 // Only turn on only the middle stream.
6420 parameters.encodings[0].active = false;
6421 parameters.encodings[1].active = true;
6422 parameters.encodings[2].active = false;
6423 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6424 // Verify that the active fields are set on the VideoChannel.
6425 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006426 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006427 EXPECT_FALSE(parameters.encodings[0].active);
6428 EXPECT_TRUE(parameters.encodings[1].active);
6429 EXPECT_FALSE(parameters.encodings[2].active);
6430 // Check that the VideoSendStream is updated appropriately. This means its
6431 // send state was updated and it was reconfigured.
6432 EXPECT_TRUE(fake_video_send_stream->IsSending());
6433 std::vector<webrtc::VideoStream> simulcast_streams =
6434 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006435 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006436 EXPECT_FALSE(simulcast_streams[0].active);
6437 EXPECT_TRUE(simulcast_streams[1].active);
6438 EXPECT_FALSE(simulcast_streams[2].active);
6439
6440 // Turn off all streams.
6441 parameters.encodings[0].active = false;
6442 parameters.encodings[1].active = false;
6443 parameters.encodings[2].active = false;
6444 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6445 // Verify that the active fields are set on the VideoChannel.
6446 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006447 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006448 EXPECT_FALSE(parameters.encodings[0].active);
6449 EXPECT_FALSE(parameters.encodings[1].active);
6450 EXPECT_FALSE(parameters.encodings[2].active);
6451 // Check that the VideoSendStream is off.
6452 EXPECT_FALSE(fake_video_send_stream->IsSending());
6453 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006454 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006455 EXPECT_FALSE(simulcast_streams[0].active);
6456 EXPECT_FALSE(simulcast_streams[1].active);
6457 EXPECT_FALSE(simulcast_streams[2].active);
6458
Niels Möllerff40b142018-04-09 08:49:14 +02006459 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08006460}
6461
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006462// Test that if a stream is reconfigured (due to a codec change or other
6463// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07006464TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006465 InactiveStreamDoesntStartSendingWhenReconfigured) {
6466 // Set an initial codec list, which will be modified later.
6467 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08006468 parameters1.codecs.push_back(GetEngineCodec("VP8"));
6469 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006470 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
6471
6472 FakeVideoSendStream* stream = AddSendStream();
6473 EXPECT_TRUE(channel_->SetSend(true));
6474 EXPECT_TRUE(stream->IsSending());
6475
6476 // Get current parameters and change "active" to false.
6477 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6478 ASSERT_EQ(1u, parameters.encodings.size());
6479 ASSERT_TRUE(parameters.encodings[0].active);
6480 parameters.encodings[0].active = false;
6481 EXPECT_EQ(1u, GetFakeSendStreams().size());
6482 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08006483 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006484 EXPECT_FALSE(stream->IsSending());
6485
6486 // Reorder the codec list, causing the stream to be reconfigured.
6487 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08006488 parameters2.codecs.push_back(GetEngineCodec("VP9"));
6489 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006490 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
6491 auto new_streams = GetFakeSendStreams();
6492 // Assert that a new underlying stream was created due to the codec change.
6493 // Otherwise, this test isn't testing what it set out to test.
6494 EXPECT_EQ(1u, GetFakeSendStreams().size());
6495 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
6496
6497 // Verify that we still are not sending anything, due to the inactive
6498 // encoding.
6499 EXPECT_FALSE(new_streams[0]->IsSending());
6500}
6501
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006502// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006503TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006504 AddSendStream();
6505 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006506 parameters.codecs.push_back(GetEngineCodec("VP8"));
6507 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006508 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6509
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006510 webrtc::RtpParameters rtp_parameters =
6511 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006512 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006513 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6514 rtp_parameters.codecs[0]);
6515 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6516 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006517}
6518
Florent Castellidacec712018-05-24 16:24:21 +02006519// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
6520TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
6521 StreamParams params = StreamParams::CreateLegacy(kSsrc);
6522 params.cname = "rtcpcname";
6523 AddSendStream(params);
6524
6525 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
6526 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
6527}
6528
deadbeeffb2aced2017-01-06 23:05:37 -08006529// Test that RtpParameters for send stream has one encoding and it has
6530// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006531TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08006532 AddSendStream();
6533
6534 webrtc::RtpParameters rtp_parameters =
6535 channel_->GetRtpSendParameters(last_ssrc_);
6536 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006537 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08006538}
6539
Florent Castelliabe301f2018-06-12 18:33:49 +02006540TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
6541 AddSendStream();
6542
6543 webrtc::RtpParameters rtp_parameters =
6544 channel_->GetRtpSendParameters(last_ssrc_);
6545 rtp_parameters.header_extensions.emplace_back();
6546
6547 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
6548
6549 webrtc::RTCError result =
6550 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6551 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
6552}
6553
Florent Castelli87b3c512018-07-18 16:00:28 +02006554TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
6555 AddSendStream();
6556
6557 FakeVideoCapturerWithTaskQueue capturer;
6558 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
6559
6560 webrtc::RtpParameters rtp_parameters =
6561 channel_->GetRtpSendParameters(last_ssrc_);
6562 EXPECT_EQ(rtp_parameters.degradation_preference,
6563 webrtc::DegradationPreference::BALANCED);
6564 rtp_parameters.degradation_preference =
6565 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
6566
6567 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
6568
6569 webrtc::RtpParameters updated_rtp_parameters =
6570 channel_->GetRtpSendParameters(last_ssrc_);
6571 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
6572 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
6573
6574 // Remove the source since it will be destroyed before the channel
6575 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6576}
6577
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006578// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006579TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006580 AddSendStream();
6581 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006582 parameters.codecs.push_back(GetEngineCodec("VP8"));
6583 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006584 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6585
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006586 webrtc::RtpParameters initial_params =
6587 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006588
6589 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08006590 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006591
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006592 // ... And this shouldn't change the params returned by GetRtpSendParameters.
6593 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
6594}
6595
6596// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006597TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006598 AddRecvStream();
6599 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006600 parameters.codecs.push_back(GetEngineCodec("VP8"));
6601 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006602 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6603
6604 webrtc::RtpParameters rtp_parameters =
6605 channel_->GetRtpReceiveParameters(last_ssrc_);
6606 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006607 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6608 rtp_parameters.codecs[0]);
6609 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6610 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006611}
6612
johan073ece42016-08-26 02:59:47 -07006613#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07006614TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006615#else
eladalonf1841382017-06-12 01:16:46 -07006616TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006617#endif
johan3859c892016-08-05 09:19:25 -07006618 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07006619 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08006620 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07006621 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07006622 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08006623 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07006624 parameters.codecs.push_back(kH264sprop2);
6625 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6626
6627 FakeVideoReceiveStream* recv_stream = AddRecvStream();
6628 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
6629 webrtc::RtpParameters rtp_parameters =
6630 channel_->GetRtpReceiveParameters(last_ssrc_);
6631 ASSERT_EQ(2u, rtp_parameters.codecs.size());
6632 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
6633 ASSERT_EQ(2u, cfg.decoders.size());
6634 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006635 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006636 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006637 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
6638 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006639 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07006640
6641 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006642 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006643 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006644 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
6645 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006646 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07006647}
6648
sakal1fd95952016-06-22 00:46:15 -07006649// Test that RtpParameters for receive stream has one encoding and it has
6650// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006651TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07006652 AddRecvStream();
6653
6654 webrtc::RtpParameters rtp_parameters =
6655 channel_->GetRtpReceiveParameters(last_ssrc_);
6656 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006657 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07006658}
6659
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006660// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006661TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006662 AddRecvStream();
6663 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006664 parameters.codecs.push_back(GetEngineCodec("VP8"));
6665 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006666 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6667
6668 webrtc::RtpParameters initial_params =
6669 channel_->GetRtpReceiveParameters(last_ssrc_);
6670
6671 // We should be able to set the params we just got.
6672 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
6673
6674 // ... And this shouldn't change the params returned by
6675 // GetRtpReceiveParameters.
6676 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006677}
6678
deadbeef3bc15102017-04-20 19:25:07 -07006679// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
6680// aren't signaled. It should always return an empty "RtpEncodingParameters",
6681// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07006682TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07006683 // Call necessary methods to configure receiving a default stream as
6684 // soon as it arrives.
6685 cricket::VideoRecvParameters parameters;
6686 parameters.codecs.push_back(GetEngineCodec("VP8"));
6687 parameters.codecs.push_back(GetEngineCodec("VP9"));
6688 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6689
6690 // Call GetRtpReceiveParameters before configured to receive an unsignaled
6691 // stream. Should return nothing.
6692 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
6693
6694 // Set a sink for an unsignaled stream.
6695 cricket::FakeVideoRenderer renderer;
6696 // Value of "0" means "unsignaled stream".
6697 EXPECT_TRUE(channel_->SetSink(0, &renderer));
6698
6699 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
6700 // in this method means "unsignaled stream".
6701 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
6702 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6703 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6704
6705 // Receive VP8 packet.
6706 uint8_t data[kMinRtpPacketLen];
6707 cricket::RtpHeader rtpHeader;
6708 rtpHeader.payload_type = GetEngineCodec("VP8").id;
6709 rtpHeader.seq_num = rtpHeader.timestamp = 0;
6710 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
6711 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
6712 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
6713 rtc::PacketTime packet_time;
6714 channel_->OnPacketReceived(&packet, packet_time);
6715
6716 // The |ssrc| member should still be unset.
6717 rtp_parameters = channel_->GetRtpReceiveParameters(0);
6718 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6719 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6720}
6721
eladalonf1841382017-06-12 01:16:46 -07006722void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02006723 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006724 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02006725
6726 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02006727 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02006728 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02006729 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02006730
6731 if (receiver_first) {
6732 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6733 std::vector<FakeVideoReceiveStream*> receive_streams =
6734 fake_call_->GetVideoReceiveStreams();
6735 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02006736 // Default local SSRC when we have no sender.
6737 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6738 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006739 }
6740 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
6741 if (!receiver_first)
6742 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6743 std::vector<FakeVideoReceiveStream*> receive_streams =
6744 fake_call_->GetVideoReceiveStreams();
6745 ASSERT_EQ(1u, receive_streams.size());
6746 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02006747
6748 // Removing first sender should fall back to another (in this case the second)
6749 // local send stream's SSRC.
6750 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
6751 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006752 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006753 ASSERT_EQ(1u, receive_streams.size());
6754 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
6755
6756 // Removing the last sender should fall back to default local SSRC.
6757 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006758 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006759 ASSERT_EQ(1u, receive_streams.size());
6760 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6761 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006762}
6763
eladalonf1841382017-06-12 01:16:46 -07006764TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02006765 TestReceiverLocalSsrcConfiguration(false);
6766}
6767
eladalonf1841382017-06-12 01:16:46 -07006768TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02006769 TestReceiverLocalSsrcConfiguration(true);
6770}
6771
eladalonf1841382017-06-12 01:16:46 -07006772class WebRtcVideoChannelSimulcastTest : public testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006773 public:
eladalonf1841382017-06-12 01:16:46 -07006774 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01006775 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006776 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
6777 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +02006778 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006779 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02006780 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006781 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07006782 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006783
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00006784 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02006785 encoder_factory_->AddSupportedVideoCodecType("VP8");
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07006786 channel_.reset(engine_.CreateChannel(&fake_call_, GetMediaConfig(),
6787 VideoOptions(),
6788 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08006789 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006790 last_ssrc_ = 123;
6791 }
6792
6793 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006794 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07006795 int capture_width,
6796 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006797 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08006798 size_t expected_num_streams,
6799 bool screenshare,
6800 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006801 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006802 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08006803 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006804 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006805
Peter Boström0c4e06b2015-10-07 12:23:21 +02006806 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07006807 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006808 ssrcs.resize(num_configured_streams);
6809
sprangf24a0642017-02-28 13:23:26 -08006810 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006811 // Send a full-size frame to trigger a stream reconfiguration to use all
6812 // expected simulcast layers.
Tommi85959932018-02-07 19:26:06 +01006813 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08006814 VideoOptions options;
6815 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01006816 options.is_screencast = screenshare;
Yves Gerey665174f2018-06-19 15:03:05 +02006817 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08006818 // Fetch the latest stream since SetVideoSend() may recreate it if the
6819 // screen content setting is changed.
6820 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006821 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(cricket::VideoFormat(
perkj26752742016-10-24 01:21:16 -07006822 capture_width, capture_height,
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006823 cricket::VideoFormat::FpsToInterval(30),
6824 cricket::FOURCC_I420)));
6825 channel_->SetSend(true);
6826 EXPECT_TRUE(capturer.CaptureFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006827
Zach Stein3ca452b2018-01-18 10:01:24 -08006828 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
6829 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
6830
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006831 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6832 ASSERT_EQ(expected_num_streams, video_streams.size());
6833
sprang429600d2017-01-26 06:12:26 -08006834 std::vector<webrtc::VideoStream> expected_streams;
6835 if (conference_mode) {
6836 expected_streams = GetSimulcastConfig(
6837 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08006838 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02006839 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08006840 if (screenshare) {
6841 for (const webrtc::VideoStream& stream : expected_streams) {
6842 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00006843 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
6844 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08006845 }
6846 }
sprang429600d2017-01-26 06:12:26 -08006847 } else {
6848 webrtc::VideoStream stream;
6849 stream.width = capture_width;
6850 stream.height = capture_height;
6851 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01006852 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08006853 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006854 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08006855 stream.max_qp = kDefaultQpMax;
6856 expected_streams.push_back(stream);
6857 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006858
6859 ASSERT_EQ(expected_streams.size(), video_streams.size());
6860
6861 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006862 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006863 for (size_t i = 0; i < num_streams; ++i) {
6864 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
6865 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
6866
6867 EXPECT_GT(video_streams[i].max_framerate, 0);
6868 EXPECT_EQ(expected_streams[i].max_framerate,
6869 video_streams[i].max_framerate);
6870
6871 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
6872 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
6873 video_streams[i].min_bitrate_bps);
6874
6875 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
6876 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
6877 video_streams[i].target_bitrate_bps);
6878
6879 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
6880 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
6881 video_streams[i].max_bitrate_bps);
6882
6883 EXPECT_GT(video_streams[i].max_qp, 0);
6884 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
6885
Sergey Silkina796a7e2018-03-01 15:11:29 +01006886 EXPECT_EQ(conference_mode,
6887 expected_streams[i].num_temporal_layers.has_value());
6888
6889 if (conference_mode) {
6890 EXPECT_EQ(expected_streams[i].num_temporal_layers,
6891 video_streams[i].num_temporal_layers);
6892 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006893
6894 if (i == num_streams - 1) {
6895 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
6896 } else {
6897 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
6898 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006899 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006900
Niels Möllerff40b142018-04-09 08:49:14 +02006901 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006902 }
6903
6904 FakeVideoSendStream* AddSendStream() {
6905 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
6906 }
6907
6908 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006909 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006910 EXPECT_TRUE(channel_->AddSendStream(sp));
6911 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006912 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006913 EXPECT_EQ(num_streams + 1, streams.size());
6914 return streams[streams.size() - 1];
6915 }
6916
6917 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006918 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006919 }
6920
6921 FakeVideoReceiveStream* AddRecvStream() {
6922 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
6923 }
6924
6925 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006926 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006927 EXPECT_TRUE(channel_->AddRecvStream(sp));
6928 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006929 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006930 EXPECT_EQ(num_streams + 1, streams.size());
6931 return streams[streams.size() - 1];
6932 }
6933
skvlad11a9cbf2016-10-07 11:53:05 -07006934 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006935 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006936 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
6937 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -07006938 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08006939 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02006940 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006941};
6942
eladalonf1841382017-06-12 01:16:46 -07006943TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006944 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
6945 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006946}
6947
eladalonf1841382017-06-12 01:16:46 -07006948TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006949 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
6950 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006951}
6952
6953// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07006954TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08006955 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
6956 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006957}
sprang429600d2017-01-26 06:12:26 -08006958
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006959TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006960 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6961 false);
6962}
6963
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006964TEST_F(WebRtcVideoChannelSimulcastTest,
6965 SetSendCodecsForConferenceModeScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006966 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6967 true);
6968}
6969
eladalonf1841382017-06-12 01:16:46 -07006970TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
Erik Språngb65aa012018-09-24 11:35:19 +02006971 webrtc::test::ScopedFieldTrials override_field_trials_(
6972 "WebRTC-SimulcastScreenshare/Enabled/");
sprang429600d2017-01-26 06:12:26 -08006973 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
6974 true);
6975}
6976
eladalonf1841382017-06-12 01:16:46 -07006977TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07006978 NoSimulcastScreenshareWithoutConference) {
Erik Språngb65aa012018-09-24 11:35:19 +02006979 webrtc::test::ScopedFieldTrials override_field_trials_(
6980 "WebRTC-SimulcastScreenshare/Enabled/");
sprangfe627f32017-03-29 08:24:59 -07006981 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6982 false);
6983}
6984
Yves Gereyb6a89422018-10-08 10:08:32 +02006985class WebRtcVideoFakeClock {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006986 public:
Yves Gereyb6a89422018-10-08 10:08:32 +02006987 WebRtcVideoFakeClock() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006988 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1)); // avoid time=0
6989 }
6990 rtc::ScopedFakeClock fake_clock_;
6991};
6992
Yves Gereyb6a89422018-10-08 10:08:32 +02006993// The fake clock needs to be initialized before the call, and not
6994// destroyed until after all threads spawned by the test have been stopped.
6995// This mixin ensures that.
6996class WebRtcVideoChannelTestWithClock : public WebRtcVideoFakeClock,
6997 public WebRtcVideoChannelBaseTest {};
6998
Jonas Oreland49ac5952018-09-26 16:04:32 +02006999TEST_F(WebRtcVideoChannelTestWithClock, GetSources) {
7000 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7001 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7002
7003 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7004
7005 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7006 rtc::SetBE32(packet1.data() + 8, kSsrc);
7007 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7008 EXPECT_TRUE(SetDefaultCodec());
7009 EXPECT_TRUE(SetSend(true));
7010 EXPECT_EQ(0, renderer_.num_rendered_frames());
7011 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
7012
7013 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7014 EXPECT_EQ(1u, sources.size());
7015 EXPECT_EQ(webrtc::RtpSourceType::SSRC, sources[0].source_type());
7016 int64_t timestamp1 = sources[0].timestamp_ms();
7017
7018 // a new packet.
7019 int64_t timeDeltaMs = 1;
7020 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
7021 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
7022 int64_t timestamp2 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7023 EXPECT_EQ(timestamp2, timestamp1 + timeDeltaMs);
7024
7025 // It only keeps 10s of history.
7026 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7027 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7028 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7029}
7030
7031TEST_F(WebRtcVideoChannelTestWithClock, GetContributingSources) {
7032 uint8_t data1[] = {0x81, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
7033 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7034
7035 uint32_t kCsrc = 4321u;
7036 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7037 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7038
7039 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7040 rtc::SetBE32(packet1.data() + 8, kSsrc);
7041 rtc::SetBE32(packet1.data() + 12, kCsrc);
7042 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7043 EXPECT_TRUE(SetDefaultCodec());
7044 EXPECT_TRUE(SetSend(true));
7045 EXPECT_EQ(0, renderer_.num_rendered_frames());
7046 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
7047
7048 {
7049 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7050 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7051 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7052 EXPECT_EQ(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7053 // 1 SSRC and 1 CSRC.
7054 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7055 [](const webrtc::RtpSource& source) {
7056 return source.source_type() ==
7057 webrtc::RtpSourceType::SSRC;
7058 }));
7059 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7060 [](const webrtc::RtpSource& source) {
7061 return source.source_type() ==
7062 webrtc::RtpSourceType::CSRC;
7063 }));
7064 }
7065 int64_t timestamp1 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7066
7067 // a new packet with only ssrc (i.e no csrc).
7068 uint8_t data2[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7069 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7070 rtc::CopyOnWriteBuffer packet2(data2, sizeof(data2));
7071 rtc::SetBE32(packet2.data() + 8, kSsrc);
7072
7073 int64_t timeDeltaMs = 1;
7074 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
7075 channel_->OnPacketReceived(&packet2, rtc::PacketTime());
7076
7077 {
7078 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7079 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7080 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7081 EXPECT_NE(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7082 // 1 SSRC and 1 CSRC.
7083 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7084 [](const webrtc::RtpSource& source) {
7085 return source.source_type() ==
7086 webrtc::RtpSourceType::SSRC;
7087 }));
7088 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7089 [](const webrtc::RtpSource& source) {
7090 return source.source_type() ==
7091 webrtc::RtpSourceType::CSRC;
7092 }));
7093 auto ssrcSource = std::find_if(
7094 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7095 return source.source_type() == webrtc::RtpSourceType::SSRC;
7096 });
7097 auto csrcSource = std::find_if(
7098 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7099 return source.source_type() == webrtc::RtpSourceType::CSRC;
7100 });
7101
7102 EXPECT_EQ(ssrcSource->timestamp_ms(), timestamp1 + timeDeltaMs);
7103 EXPECT_EQ(csrcSource->timestamp_ms(), timestamp1);
7104 }
7105
7106 // It only keeps 10s of history.
7107 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7108
7109 {
7110 ASSERT_EQ(1u, channel_->GetSources(kSsrc).size());
7111 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7112 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7113 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7114 [](const webrtc::RtpSource& source) {
7115 return source.source_type() ==
7116 webrtc::RtpSourceType::SSRC;
7117 }));
7118 EXPECT_EQ(0, std::count_if(sources.begin(), sources.end(),
7119 [](const webrtc::RtpSource& source) {
7120 return source.source_type() ==
7121 webrtc::RtpSourceType::CSRC;
7122 }));
7123 }
7124
7125 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7126 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7127 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7128}
7129
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007130} // namespace cricket