blob: 2cb6c97064042bd3f19fcf37711af41a1ab1f66c [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +000011#include <algorithm>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000012#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080013#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070014#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000015#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000016
Niels Möller80cd25b2018-10-23 10:07:25 +020017#include "absl/strings/match.h"
Seth Hampson24722b32017-12-22 09:36:42 -080018#include "api/rtpparameters.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070019#include "api/test/mock_video_decoder_factory.h"
20#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020021#include "api/units/time_delta.h"
Åsa Persson23eba222018-10-02 14:47:06 +020022#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020023#include "api/video_codecs/builtin_video_decoder_factory.h"
24#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020025#include "api/video_codecs/sdp_video_format.h"
26#include "api/video_codecs/video_decoder_factory.h"
27#include "api/video_codecs/video_encoder.h"
28#include "api/video_codecs/video_encoder_factory.h"
29#include "call/flexfec_receive_stream.h"
30#include "common_video/h264/profile_level_id.h"
31#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller6557d0c2018-04-11 15:18:34 +020032#include "media/base/fakenetworkinterface.h"
33#include "media/base/fakevideocapturer.h"
34#include "media/base/fakevideorenderer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020035#include "media/base/mediaconstants.h"
36#include "media/base/rtputils.h"
37#include "media/base/testutils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020038#include "media/engine/constants.h"
39#include "media/engine/fakewebrtccall.h"
40#include "media/engine/fakewebrtcvideoengine.h"
41#include "media/engine/simulcast.h"
42#include "media/engine/webrtcvideoengine.h"
43#include "media/engine/webrtcvoiceengine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020044#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020045#include "rtc_base/arraysize.h"
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +020046#include "rtc_base/fakeclock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020047#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020048#include "rtc_base/numerics/safe_conversions.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020049#include "rtc_base/stringutils.h"
50#include "test/field_trial.h"
51#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000052
Tommi85959932018-02-07 19:26:06 +010053using cricket::FakeVideoCapturerWithTaskQueue;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010054using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070055using webrtc::RtpExtension;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010056using testing::Field;
isheriff6f8d6862016-05-26 11:24:55 -070057
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000058namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000059static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000060
noahricd10a68e2015-07-10 11:27:55 -070061static const uint8_t kRedRtxPayloadType = 125;
62
Niels Möller6557d0c2018-04-11 15:18:34 +020063static const uint32_t kTimeout = 5000U;
64static const uint32_t kDefaultReceiveSsrc = 0;
65static const uint32_t kSsrc = 1234u;
66static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
67static const int kVideoWidth = 640;
68static const int kVideoHeight = 360;
69static const int kFramerate = 30;
70
Peter Boström0c4e06b2015-10-07 12:23:21 +020071static const uint32_t kSsrcs1[] = {1};
72static const uint32_t kSsrcs3[] = {1, 2, 3};
73static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080074static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020075static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080076static const uint32_t kDefaultRecvSsrc = 0;
77
pbos@webrtc.org3c107582014-07-20 15:27:35 +000078static const char kUnsupportedExtensionName[] =
79 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000080
magjed509e4fe2016-11-18 01:34:11 -080081cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
82 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020083 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080084}
85
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000086void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
87 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
88 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
89 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
90 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
91 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
92 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
93 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -080094 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
95 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000096 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
97}
98
magjed725e4842016-11-16 00:48:13 -080099// Return true if any codec in |codecs| is an RTX codec with associated payload
100// type |payload_type|.
101bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
102 int payload_type) {
103 for (const cricket::VideoCodec& codec : codecs) {
104 int associated_payload_type;
Niels Möller80cd25b2018-10-23 10:07:25 +0200105 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800106 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
107 &associated_payload_type) &&
108 associated_payload_type == payload_type) {
109 return true;
110 }
111 }
112 return false;
113}
114
nisseca5706d2017-09-11 02:32:16 -0700115// TODO(nisse): Duplicated in call.cc.
116const int* FindKeyByValue(const std::map<int, int>& m, int v) {
117 for (const auto& kv : m) {
118 if (kv.second == v)
119 return &kv.first;
120 }
121 return nullptr;
122}
123
Yves Gerey665174f2018-06-19 15:03:05 +0200124bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
125 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700126 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
127 payload_type) != nullptr;
128}
129
130// Check that there's an Rtx payload type for each decoder.
131bool VerifyRtxReceiveAssociations(
132 const webrtc::VideoReceiveStream::Config& config) {
133 for (const auto& decoder : config.decoders) {
134 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
135 return false;
136 }
137 return true;
138}
139
brandtrffc61182016-11-28 06:02:22 -0800140rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700141 int width,
142 int height) {
143 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
144 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800145 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700146 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000147}
148
Shao Changbine62202f2015-04-21 20:24:50 +0800149void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
150 const std::map<int, int>& rtx_types) {
151 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200152 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800153 EXPECT_TRUE(it != rtx_types.end() &&
154 it->second == config.rtp.rtx.payload_type);
155
brandtrb5f2c3f2016-10-04 23:28:39 -0700156 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
157 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800158 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700159 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800160 }
161}
kthelgason2bc68642017-02-07 07:02:22 -0800162
163cricket::MediaConfig GetMediaConfig() {
164 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100165 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800166 return media_config;
167}
nisse26e3abb2017-08-25 04:44:25 -0700168
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200169// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
170int GetMaxDefaultBitrateBps(size_t width, size_t height) {
171 if (width * height <= 320 * 240) {
172 return 600000;
173 } else if (width * height <= 640 * 480) {
174 return 1700000;
175 } else if (width * height <= 960 * 540) {
176 return 2000000;
177 } else {
178 return 2500000;
179 }
180}
181
Niels Möller731a2c22018-07-30 15:08:07 +0200182class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
183 public:
184 MOCK_METHOD2(AddOrUpdateSink,
185 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
186 const rtc::VideoSinkWants& wants));
187 MOCK_METHOD1(RemoveSink,
188 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
189};
190
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000191} // namespace
192
Yves Gerey665174f2018-06-19 15:03:05 +0200193#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200194 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200195 EXPECT_EQ((w), renderer_.width()); \
196 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200197 EXPECT_EQ(0, renderer_.errors());
198
Yves Gerey665174f2018-06-19 15:03:05 +0200199#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200200 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200201 EXPECT_EQ((w), (r).width()); \
202 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200203 EXPECT_EQ(0, (r).errors());
204
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000205namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700206class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000207 public:
eladalonf1841382017-06-12 01:16:46 -0700208 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
209 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700210 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700211 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200212 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
213 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +0200214 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200215 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200216 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200217 decoder_factory_)) {
218 // Ensure fake clock doesn't return 0, which will cause some initializations
219 // fail inside RTP senders.
220 fake_clock_.AdvanceTimeMicros(1);
221 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000222
223 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200224 void AssignDefaultAptRtxTypes();
225 void AssignDefaultCodec();
226
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100227 // Find the index of the codec in the engine with the given name. The codec
228 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100229 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100230
magjed509e4fe2016-11-18 01:34:11 -0800231 // Find the codec in the engine with the given name. The codec must be
232 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100233 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800234
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200235 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000236
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200237 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000238 const std::vector<VideoCodec>& codecs);
239
Peter Boströme4499152016-02-05 11:13:28 +0100240 void TestExtendedEncoderOveruse(bool use_external_encoder);
241
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200242 // Has to be the first one, so it is initialized before the call or there is a
243 // race condition in the clock access.
244 rtc::ScopedFakeClock fake_clock_;
stefanc1aeaf02015-10-15 07:26:07 -0700245 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700246 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700247 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000248 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800249 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200250 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
251 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -0700252 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000253 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800254 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000255};
256
eladalonf1841382017-06-12 01:16:46 -0700257TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200258 encoder_factory_->AddSupportedVideoCodecType("VP8");
259 AssignDefaultCodec();
260
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000261 std::vector<VideoCodec> engine_codecs = engine_.codecs();
262 for (size_t i = 0; i < engine_codecs.size(); ++i) {
263 if (engine_codecs[i].name != kRtxCodecName)
264 continue;
265 int associated_payload_type;
266 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000267 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000268 EXPECT_EQ(default_codec_.id, associated_payload_type);
269 return;
270 }
271 FAIL() << "No RTX codec found among default codecs.";
272}
273
eladalonf1841382017-06-12 01:16:46 -0700274TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100275 RtpCapabilities capabilities = engine_.GetCapabilities();
276 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700277 for (const RtpExtension& extension : capabilities.header_extensions) {
278 if (extension.uri == RtpExtension::kTimestampOffsetUri) {
279 EXPECT_EQ(RtpExtension::kTimestampOffsetDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000280 return;
281 }
282 }
283 FAIL() << "Timestamp offset extension not in header-extension list.";
284}
285
eladalonf1841382017-06-12 01:16:46 -0700286TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100287 RtpCapabilities capabilities = engine_.GetCapabilities();
288 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700289 for (const RtpExtension& extension : capabilities.header_extensions) {
290 if (extension.uri == RtpExtension::kAbsSendTimeUri) {
291 EXPECT_EQ(RtpExtension::kAbsSendTimeDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000292 return;
293 }
294 }
295 FAIL() << "Absolute Sender Time extension not in header-extension list.";
296}
297
eladalonf1841382017-06-12 01:16:46 -0700298TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100299 RtpCapabilities capabilities = engine_.GetCapabilities();
300 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700301 for (const RtpExtension& extension : capabilities.header_extensions) {
302 if (extension.uri == RtpExtension::kTransportSequenceNumberUri) {
303 EXPECT_EQ(RtpExtension::kTransportSequenceNumberDefaultId, extension.id);
stefanc1aeaf02015-10-15 07:26:07 -0700304 return;
305 }
306 }
307 FAIL() << "Transport sequence number extension not in header-extension list.";
308}
309
eladalonf1841382017-06-12 01:16:46 -0700310TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100311 RtpCapabilities capabilities = engine_.GetCapabilities();
312 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700313 for (const RtpExtension& extension : capabilities.header_extensions) {
314 if (extension.uri == RtpExtension::kVideoRotationUri) {
315 EXPECT_EQ(RtpExtension::kVideoRotationDefaultId, extension.id);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700316 return;
317 }
318 }
319 FAIL() << "Video Rotation extension not in header-extension list.";
320}
321
philipel1e054862018-10-08 16:13:53 +0200322class WebRtcVideoEngineTestWithGenericDescriptor
323 : public WebRtcVideoEngineTest {
324 public:
325 WebRtcVideoEngineTestWithGenericDescriptor()
326 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
327};
328
329TEST_F(WebRtcVideoEngineTestWithGenericDescriptor, AdvertiseGenericDescriptor) {
330 RtpCapabilities capabilities = engine_.GetCapabilities();
331 ASSERT_FALSE(capabilities.header_extensions.empty());
332 for (const RtpExtension& extension : capabilities.header_extensions) {
333 if (extension.uri == RtpExtension::kGenericFrameDescriptorUri) {
334 EXPECT_EQ(RtpExtension::kGenericFrameDescriptorDefaultId, extension.id);
335 return;
336 }
337 }
338 FAIL() << "Generic descriptor extension not in header-extension list.";
339}
340
eladalonf1841382017-06-12 01:16:46 -0700341TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200342 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700343 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200344 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700345
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200346 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700347
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200348 std::unique_ptr<VideoMediaChannel> channel(
349 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700350 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
351
352 // Add CVO extension.
353 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800354 cricket::VideoSendParameters parameters;
355 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200356 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700357 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200358 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700359
Niels Möller731a2c22018-07-30 15:08:07 +0200360 EXPECT_CALL(
361 video_source,
362 AddOrUpdateSink(testing::_,
363 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700364 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200365 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700366
367 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200368 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700369
370 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200371 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200372 EXPECT_CALL(
373 video_source,
374 AddOrUpdateSink(testing::_,
375 Field(&rtc::VideoSinkWants::rotation_applied, true)));
376
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200377 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700378}
379
eladalonf1841382017-06-12 01:16:46 -0700380TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200381 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800382 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200383 testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800384
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200385 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800386
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200387 std::unique_ptr<VideoMediaChannel> channel(
388 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800389 // Add CVO extension.
390 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800391 cricket::VideoSendParameters parameters;
392 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800393 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700394 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800395 EXPECT_TRUE(channel->SetSendParameters(parameters));
396 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
397
Niels Möller731a2c22018-07-30 15:08:07 +0200398 // Set source.
399 EXPECT_CALL(
400 video_source,
401 AddOrUpdateSink(testing::_,
402 Field(&rtc::VideoSinkWants::rotation_applied, false)));
403 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800404}
405
eladalonf1841382017-06-12 01:16:46 -0700406TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200407 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700408
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200409 encoder_factory_->AddSupportedVideoCodecType("VP8");
410 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700411
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200412 std::unique_ptr<VideoMediaChannel> channel(
413 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700414 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
415
416 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200417 EXPECT_CALL(
418 video_source,
419 AddOrUpdateSink(testing::_,
420 Field(&rtc::VideoSinkWants::rotation_applied, true)));
421 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700422
perkjcaafdba2016-03-20 07:34:29 -0700423 // Verify capturer has turned on applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200424 testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700425
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700426 // Add CVO extension.
427 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800428 cricket::VideoSendParameters parameters;
429 parameters.codecs.push_back(GetEngineCodec("VP8"));
430 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200431 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700432 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700433 // Also remove the first codec to trigger a codec change as well.
434 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200435 EXPECT_CALL(
436 video_source,
437 AddOrUpdateSink(testing::_,
438 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200439 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700440
441 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200442 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700443
444 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200445 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200446 EXPECT_CALL(
447 video_source,
448 AddOrUpdateSink(testing::_,
449 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200450 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700451}
452
eladalonf1841382017-06-12 01:16:46 -0700453TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200454 encoder_factory_->AddSupportedVideoCodecType("VP8");
455
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700456 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
457 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000458
459 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
460
461 EXPECT_FALSE(channel->SetSend(true))
462 << "Channel should not start without codecs.";
463 EXPECT_TRUE(channel->SetSend(false))
464 << "Channel should be stoppable even without set codecs.";
465}
466
eladalonf1841382017-06-12 01:16:46 -0700467TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200468 encoder_factory_->AddSupportedVideoCodecType("VP8");
469
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700470 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
471 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000472 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
473 VideoMediaInfo info;
474 channel->GetStats(&info);
475}
476
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200477TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200478 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000479
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200480 std::unique_ptr<VideoMediaChannel> channel(
481 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800482 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000483
484 EXPECT_TRUE(
485 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200486 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000487 EXPECT_TRUE(channel->SetSend(true));
Tommi85959932018-02-07 19:26:06 +0100488 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200489 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000490 EXPECT_EQ(cricket::CS_RUNNING,
491 capturer.Start(capturer.GetSupportedFormats()->front()));
492 EXPECT_TRUE(capturer.CaptureFrame());
Per21d45d22016-10-30 21:37:57 +0100493 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200494 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
495 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000496 kTimeout);
497
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200498 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100499 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000500
501 // Setting codecs of the same type should not reallocate any encoders
502 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800503 cricket::VideoSendParameters parameters;
504 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200505 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200506 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000507
508 // Remove stream previously added to free the external encoder instance.
509 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200510 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000511}
512
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200513// Test that when an encoder factory supports H264, we add an RTX
514// codec for it.
515// TODO(deadbeef): This test should be updated if/when we start
516// adding RTX codecs for unrecognized codec names.
517TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800518 using webrtc::H264::ProfileLevelIdToString;
519 using webrtc::H264::ProfileLevelId;
520 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200521 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
522 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800523 *ProfileLevelIdToString(
524 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200525 webrtc::SdpVideoFormat h264_constrained_high("H264");
526 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800527 *ProfileLevelIdToString(
528 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200529 webrtc::SdpVideoFormat h264_high("H264");
530 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800531 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
532
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200533 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
534 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
535 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700536
magjed725e4842016-11-16 00:48:13 -0800537 // First figure out what payload types the test codecs got assigned.
538 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800539 // Now search for RTX codecs for them. Expect that they all have associated
540 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800541 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200542 codecs,
543 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
544 ->id));
magjed725e4842016-11-16 00:48:13 -0800545 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200546 codecs,
547 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
548 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800549 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200550 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700551}
552
Peter Boström12996152016-05-14 02:03:18 +0200553#if !defined(RTC_DISABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700554TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200555 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100556
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200557 std::unique_ptr<VideoMediaChannel> channel(
558 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100559
560 EXPECT_TRUE(
561 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
562}
Peter Boström12996152016-05-14 02:03:18 +0200563#endif // !defined(RTC_DISABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100564
eladalonf1841382017-06-12 01:16:46 -0700565TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200566 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100567 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200568 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200569 std::unique_ptr<VideoMediaChannel> channel(
570 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700571
572 EXPECT_TRUE(
573 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
574
Tommi85959932018-02-07 19:26:06 +0100575 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200576 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
qiangchenc27d89f2015-07-16 10:27:16 -0700577 capturer.Start(cricket::VideoFormat(1280, 720,
578 cricket::VideoFormat::FpsToInterval(60),
579 cricket::FOURCC_I420));
580 channel->SetSend(true);
581
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200582 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700583
584 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700585 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700586 for (int i = 0; i < 10; i++) {
587 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700588 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700589 int64_t interval = timestamp - last_timestamp;
590
591 // Precision changes from nanosecond to millisecond.
592 // Allow error to be no more than 1.
593 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
594
595 last_timestamp = timestamp;
596 }
597
598 capturer.Start(cricket::VideoFormat(1280, 720,
599 cricket::VideoFormat::FpsToInterval(30),
600 cricket::FOURCC_I420));
601
602 EXPECT_TRUE(capturer.CaptureFrame());
603 last_timestamp = stream->GetLastTimestamp();
604 for (int i = 0; i < 10; i++) {
605 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700606 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700607 int64_t interval = timestamp - last_timestamp;
608
609 // Precision changes from nanosecond to millisecond.
610 // Allow error to be no more than 1.
611 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
612
613 last_timestamp = timestamp;
614 }
615
616 // Remove stream previously added to free the external encoder instance.
617 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
618}
619
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200620void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
621 std::vector<VideoCodec> engine_codecs = engine_.codecs();
622 RTC_DCHECK(!engine_codecs.empty());
623 for (const cricket::VideoCodec& codec : engine_codecs) {
624 if (codec.name == "rtx") {
625 int associated_payload_type;
626 if (codec.GetParam(kCodecParamAssociatedPayloadType,
627 &associated_payload_type)) {
628 default_apt_rtx_types_[associated_payload_type] = codec.id;
629 }
630 }
631 }
632}
633
634void WebRtcVideoEngineTest::AssignDefaultCodec() {
635 std::vector<VideoCodec> engine_codecs = engine_.codecs();
636 RTC_DCHECK(!engine_codecs.empty());
637 bool codec_set = false;
638 for (const cricket::VideoCodec& codec : engine_codecs) {
639 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
640 codec.name != "ulpfec") {
641 default_codec_ = codec;
642 codec_set = true;
643 }
644 }
645
646 RTC_DCHECK(codec_set);
647}
648
Oleh Prypina40f8242017-12-21 13:32:23 +0100649size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
650 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100651 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
652 for (size_t i = 0; i < codecs.size(); ++i) {
653 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller80cd25b2018-10-23 10:07:25 +0200654 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200655 continue;
656 // The tests only use H264 Constrained Baseline. Make sure we don't return
657 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller80cd25b2018-10-23 10:07:25 +0200658 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200659 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200660 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
661 if (profile_level_id->profile !=
662 webrtc::H264::kProfileConstrainedBaseline) {
663 continue;
664 }
665 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100666 return i;
magjed509e4fe2016-11-18 01:34:11 -0800667 }
668 // This point should never be reached.
669 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100670 return -1;
671}
672
673cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
674 const std::string& name) const {
675 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800676}
677
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200678VideoMediaChannel*
679WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700680 VideoMediaChannel* channel = engine_.CreateChannel(
681 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200682 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800683 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200684 for (const webrtc::SdpVideoFormat& format :
685 encoder_factory_->GetSupportedFormats()) {
686 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
687 if (std::find(parameters.codecs.begin(), parameters.codecs.end(),
688 engine_codec) == parameters.codecs.end()) {
689 parameters.codecs.push_back(engine_codec);
690 }
691 }
magjed509e4fe2016-11-18 01:34:11 -0800692
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200693 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000694
695 return channel;
696}
697
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200698VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000699 const std::vector<VideoCodec>& codecs) {
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700700 VideoMediaChannel* channel = engine_.CreateChannel(
701 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200702 cricket::VideoRecvParameters parameters;
703 parameters.codecs = codecs;
704 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000705
706 return channel;
707}
708
eladalonf1841382017-06-12 01:16:46 -0700709TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200710 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000711
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200712 std::unique_ptr<VideoMediaChannel> channel(
713 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000714
Peter Boström0c4e06b2015-10-07 12:23:21 +0200715 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000716
Yves Gerey665174f2018-06-19 15:03:05 +0200717 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000718 EXPECT_TRUE(channel->SetSend(true));
719
Tommi85959932018-02-07 19:26:06 +0100720 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200721 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000722 EXPECT_EQ(cricket::CS_RUNNING,
723 capturer.Start(capturer.GetSupportedFormats()->front()));
724 EXPECT_TRUE(capturer.CaptureFrame());
725
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200726 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000727
728 // Verify that encoders are configured for simulcast through adapter
729 // (increasing resolution and only configured to send one stream each).
730 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200731 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
732 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000733 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200734 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000735 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
736 EXPECT_GT(codec_settings.width, prev_width);
737 prev_width = codec_settings.width;
738 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000739
Niels Möllerff40b142018-04-09 08:49:14 +0200740 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000741
742 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200743 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000744}
745
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200746TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
747 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200748 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000749
Niels Möller4db138e2018-04-19 09:04:13 +0200750 // Set capturer.
751 FakeVideoCapturerWithTaskQueue capturer;
752 EXPECT_EQ(cricket::CS_RUNNING,
753 capturer.Start(capturer.GetSupportedFormats()->front()));
754
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700755 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
756 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200757 cricket::VideoSendParameters parameters;
758 parameters.codecs.push_back(GetEngineCodec("H264"));
759 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000760
761 EXPECT_TRUE(
762 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller4db138e2018-04-19 09:04:13 +0200763 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
764 // Sending one frame will have allocate the encoder.
765 EXPECT_TRUE(capturer.CaptureFrame());
766
767 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000768
Anders Carlsson67537952018-05-03 11:28:29 +0200769 cricket::VideoSendParameters new_parameters;
770 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
771 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200772
773 // Sending one frame will switch encoder.
774 EXPECT_TRUE(capturer.CaptureFrame());
775
Anders Carlsson8a150d92018-05-14 12:40:04 +0200776 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000777}
778
eladalonf1841382017-06-12 01:16:46 -0700779TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000780 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200781 encoder_factory_->AddSupportedVideoCodecType("VP8");
782 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000783
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700784 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
785 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800786 cricket::VideoSendParameters parameters;
787 parameters.codecs.push_back(GetEngineCodec("VP8"));
788 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000789
Peter Boström0c4e06b2015-10-07 12:23:21 +0200790 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000791
Yves Gerey665174f2018-06-19 15:03:05 +0200792 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000793 EXPECT_TRUE(channel->SetSend(true));
794
795 // Send a fake frame, or else the media engine will configure the simulcast
796 // encoder adapter at a low-enough size that it'll only create a single
797 // encoder layer.
Tommi85959932018-02-07 19:26:06 +0100798 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200799 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000800 EXPECT_EQ(cricket::CS_RUNNING,
801 capturer.Start(capturer.GetSupportedFormats()->front()));
802 EXPECT_TRUE(capturer.CaptureFrame());
803
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200804 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
805 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000806 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200807 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000808
809 channel.reset();
810 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200811 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000812}
813
eladalonf1841382017-06-12 01:16:46 -0700814TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000815 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200816 encoder_factory_->AddSupportedVideoCodecType("VP8");
817 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000818
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700819 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
820 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800821 cricket::VideoSendParameters parameters;
822 parameters.codecs.push_back(GetEngineCodec("H264"));
823 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000824
825 EXPECT_TRUE(
826 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100827
828 // Send a frame of 720p. This should trigger a "real" encoder initialization.
829 cricket::VideoFormat format(
830 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100831 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200832 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Per21d45d22016-10-30 21:37:57 +0100833 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
834 EXPECT_TRUE(capturer.CaptureFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200835 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
836 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200837 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000838 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200839 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000840
841 channel.reset();
842 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200843 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000844}
845
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200846TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
847 webrtc::test::ScopedFieldTrials override_field_trials_(
848 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200849 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700850
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700851 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
852 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200853 cricket::VideoSendParameters parameters;
854 parameters.codecs.push_back(GetEngineCodec("H264"));
855 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700856
Peter Boström0c4e06b2015-10-07 12:23:21 +0200857 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700858 EXPECT_TRUE(
859 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100860
861 // Send a frame of 720p. This should trigger a "real" encoder initialization.
noahricfdac5162015-08-27 01:59:29 -0700862 cricket::VideoFormat format(
863 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100864 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200865 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &capturer));
Peter Boströmce23bee2016-02-02 14:14:30 +0100866 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
867 EXPECT_TRUE(capturer.CaptureFrame());
868
Niels Möller4db138e2018-04-19 09:04:13 +0200869 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200870 ASSERT_EQ(1u, encoder_factory_->encoders().size());
871 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
872 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700873 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200874 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200875 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700876}
877
brandtrffc61182016-11-28 06:02:22 -0800878// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700879// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800880//
881// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700882TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800883 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200884 encoder_factory_->AddSupportedVideoCodecType("VP8");
885
brandtrffc61182016-11-28 06:02:22 -0800886 auto is_flexfec = [](const VideoCodec& codec) {
887 if (codec.name == "flexfec-03")
888 return true;
889 return false;
890 };
891
892 // FlexFEC is not active without field trial.
brandtrffc61182016-11-28 06:02:22 -0800893 const std::vector<VideoCodec> codecs_before = engine_.codecs();
894 EXPECT_EQ(codecs_before.end(), std::find_if(codecs_before.begin(),
895 codecs_before.end(), is_flexfec));
896
897 // FlexFEC is active with field trial.
898 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800899 "WebRTC-FlexFEC-03-Advertised/Enabled/");
brandtrffc61182016-11-28 06:02:22 -0800900 const std::vector<VideoCodec> codecs_after = engine_.codecs();
901 EXPECT_NE(codecs_after.end(),
902 std::find_if(codecs_after.begin(), codecs_after.end(), is_flexfec));
903}
904
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200905// Test that codecs are added in the order they are reported from the factory.
906TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
907 encoder_factory_->AddSupportedVideoCodecType("VP8");
908 const char* kFakeCodecName = "FakeCodec";
909 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000910
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200911 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100912 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200913 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
914 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000915}
916
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200917// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800918// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200919TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100920 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
921 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100922
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100923 // Set up external encoder factory with first codec, and initialize engine.
924 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
925
brandtrffc61182016-11-28 06:02:22 -0800926 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800927
928 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100929 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800930 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200931 // The codec itself and RTX should have been added.
932 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100933
934 // Check that both fake codecs are present and that the second fake codec
935 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100936 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
937 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100938 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800939}
940
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200941TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
942 const char* kFakeCodecName = "FakeCodec";
943 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
944
945 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
946 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
947}
948
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200949TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
950 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200951 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200952 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800953 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000954
kwiberg686a8ef2016-02-26 03:00:35 -0800955 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200956 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000957
958 EXPECT_TRUE(
959 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200960 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000961
962 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200963 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200964 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000965
966 // Remove stream previously added to free the external decoder instance.
967 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200968 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000969}
970
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200971// Verifies that we can set up decoders.
972TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000973 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
974 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
975 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
976 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200977 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +0200978 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000979 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800980 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000981
kwiberg686a8ef2016-02-26 03:00:35 -0800982 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200983 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000984
985 EXPECT_TRUE(
986 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200987 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000988}
989
Jonas Oreland49ac5952018-09-26 16:04:32 +0200990// Tests when GetSources is called with non-existing ssrc, it will return an
991// empty list of RtpSource without crashing.
992TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
993 // Setup an recv stream with |kSsrc|.
994 encoder_factory_->AddSupportedVideoCodecType("VP8");
995 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
996 cricket::VideoRecvParameters parameters;
997 parameters.codecs.push_back(GetEngineCodec("VP8"));
998 std::unique_ptr<VideoMediaChannel> channel(
999 SetRecvParamsWithSupportedCodecs(parameters.codecs));
1000
1001 EXPECT_TRUE(
1002 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1003
1004 // Call GetSources with |kSsrc + 1| which doesn't exist.
1005 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1006 EXPECT_EQ(0u, sources.size());
1007}
1008
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001009TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1010 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1011 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
1012 WebRtcVideoEngine engine(std::move(encoder_factory),
1013 std::move(decoder_factory));
1014 EXPECT_EQ(0u, engine.codecs().size());
1015}
1016
1017TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1018 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001019 webrtc::MockVideoEncoderFactory* encoder_factory =
1020 new webrtc::MockVideoEncoderFactory();
1021 webrtc::MockVideoDecoderFactory* decoder_factory =
1022 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001023 WebRtcVideoEngine engine(
1024 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1025 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1026 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1027 EXPECT_EQ(0u, engine.codecs().size());
1028 EXPECT_CALL(*encoder_factory, Die());
1029 EXPECT_CALL(*decoder_factory, Die());
1030}
1031
1032// Test full behavior in the video engine when video codec factories of the new
1033// type are injected supporting the single codec Vp8. Check the returned codecs
1034// from the engine and that we will create a Vp8 encoder and decoder using the
1035// new factories.
1036TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1037 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001038 webrtc::MockVideoEncoderFactory* encoder_factory =
1039 new webrtc::MockVideoEncoderFactory();
1040 webrtc::MockVideoDecoderFactory* decoder_factory =
1041 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001042 WebRtcVideoEngine engine(
1043 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1044 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1045 const webrtc::SdpVideoFormat vp8_format("VP8");
1046 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1047 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1048 .WillRepeatedly(testing::Return(supported_formats));
1049
1050 // Verify the codecs from the engine.
1051 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001052 // Verify default codecs has been added correctly.
1053 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001054 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001055
1056 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001057 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001058 int vp8_associated_payload;
1059 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1060 &vp8_associated_payload));
1061 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1062
1063 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1064
1065 // RTX codec for RED.
1066 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1067 int red_associated_payload;
1068 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1069 &red_associated_payload));
1070 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1071
1072 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1073
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001074 int associated_payload_type;
1075 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1076 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1077 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1078 // Verify default parameters has been added to the VP8 codec.
1079 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
1080
1081 // Mock encoder creation. |engine| take ownership of the encoder.
1082 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1083 codec_info.is_hardware_accelerated = false;
1084 codec_info.has_internal_source = false;
1085 const webrtc::SdpVideoFormat format("VP8");
1086 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
1087 .WillRepeatedly(testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001088 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möller4db138e2018-04-19 09:04:13 +02001089 rtc::Event encoder_created(false, false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001090 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001091 .WillOnce(
1092 ::testing::DoAll(::testing::InvokeWithoutArgs(
1093 [&encoder_created]() { encoder_created.Set(); }),
1094 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001095
1096 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001097 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001098 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
1099 .WillOnce(testing::Return(decoder));
1100
1101 // Create a call.
1102 webrtc::RtcEventLogNullImpl event_log;
1103 std::unique_ptr<webrtc::Call> call(
1104 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1105
1106 // Create send channel.
1107 const int send_ssrc = 123;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001108 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateChannel(
1109 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001110 cricket::VideoSendParameters send_parameters;
1111 send_parameters.codecs.push_back(engine_codecs.at(0));
1112 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1113 send_channel->OnReadyToSend(true);
1114 EXPECT_TRUE(
1115 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1116 EXPECT_TRUE(send_channel->SetSend(true));
1117
Niels Möller4db138e2018-04-19 09:04:13 +02001118 // Set capturer.
1119 FakeVideoCapturerWithTaskQueue capturer;
1120 EXPECT_EQ(cricket::CS_RUNNING,
1121 capturer.Start(capturer.GetSupportedFormats()->front()));
1122 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &capturer));
1123 // Sending one frame will allocate the encoder.
1124 EXPECT_TRUE(capturer.CaptureFrame());
1125 encoder_created.Wait(kTimeout);
1126
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001127 // Create recv channel.
1128 const int recv_ssrc = 321;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001129 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateChannel(
1130 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001131 cricket::VideoRecvParameters recv_parameters;
1132 recv_parameters.codecs.push_back(engine_codecs.at(0));
1133 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1134 EXPECT_TRUE(recv_channel->AddRecvStream(
1135 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1136
1137 // Remove streams previously added to free the encoder and decoder instance.
1138 EXPECT_CALL(*encoder_factory, Die());
1139 EXPECT_CALL(*decoder_factory, Die());
1140 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1141 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1142}
1143
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001144// Test behavior when decoder factory fails to create a decoder (returns null).
1145TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1146 // |engine| take ownership of the factories.
1147 webrtc::MockVideoEncoderFactory* encoder_factory =
1148 new testing::StrictMock<webrtc::MockVideoEncoderFactory>();
1149 webrtc::MockVideoDecoderFactory* decoder_factory =
1150 new testing::StrictMock<webrtc::MockVideoDecoderFactory>();
1151 WebRtcVideoEngine engine(
1152 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1153 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1154 const webrtc::SdpVideoFormat vp8_format("VP8");
1155 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1156 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1157 .WillRepeatedly(testing::Return(supported_formats));
1158
1159 // Decoder creation fails.
1160 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(testing::_))
1161 .WillOnce(testing::Return(nullptr));
1162
1163 // Create a call.
1164 webrtc::RtcEventLogNullImpl event_log;
1165 std::unique_ptr<webrtc::Call> call(
1166 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1167
1168 // Create recv channel.
1169 const int recv_ssrc = 321;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001170 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateChannel(
1171 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001172 cricket::VideoRecvParameters recv_parameters;
1173 recv_parameters.codecs.push_back(engine.codecs().front());
1174 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1175 EXPECT_TRUE(recv_channel->AddRecvStream(
1176 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1177
1178 // Remove streams previously added to free the encoder and decoder instance.
1179 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1180}
1181
eladalonf1841382017-06-12 01:16:46 -07001182TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001183 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001184 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001185 std::unique_ptr<VideoMediaChannel> channel(
1186 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001187 ASSERT_TRUE(
1188 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1189 cricket::VideoCodec codec = GetEngineCodec("VP8");
1190 cricket::VideoSendParameters parameters;
1191 parameters.codecs.push_back(codec);
1192 channel->OnReadyToSend(true);
1193 channel->SetSend(true);
1194 ASSERT_TRUE(channel->SetSendParameters(parameters));
1195
Tommi85959932018-02-07 19:26:06 +01001196 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08001197 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02001198 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001199
1200 EXPECT_EQ(cricket::CS_RUNNING,
1201 capturer.Start(capturer.GetSupportedFormats()->front()));
1202 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001203 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001204 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001205 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001206
Niels Möllerff40b142018-04-09 08:49:14 +02001207 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001208 EXPECT_TRUE(capturer.CaptureFrame());
1209 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001210 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001211
1212 options.is_screencast.emplace(true);
Niels Möllerff40b142018-04-09 08:49:14 +02001213 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001214 EXPECT_TRUE(capturer.CaptureFrame());
1215 // Change to screen content, recreate encoder. For the simulcast encoder
1216 // adapter case, this will result in two calls since InitEncode triggers a
1217 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001218 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001219 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001220 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001221
Niels Möllerff40b142018-04-09 08:49:14 +02001222 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001223 EXPECT_TRUE(capturer.CaptureFrame());
1224 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001225 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001226
1227 options.is_screencast.emplace(false);
1228 options.video_noise_reduction.emplace(false);
Niels Möllerff40b142018-04-09 08:49:14 +02001229 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001230 // Change back to regular video content, update encoder. Also change
1231 // a non |is_screencast| option just to verify it doesn't affect recreation.
1232 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001233 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001234 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001235 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001236
1237 // Remove stream previously added to free the external encoder instance.
1238 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001239 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001240}
1241
Niels Möller6557d0c2018-04-11 15:18:34 +02001242class WebRtcVideoChannelBaseTest : public testing::Test {
1243 protected:
1244 WebRtcVideoChannelBaseTest()
Jonas Oreland49ac5952018-09-26 16:04:32 +02001245 : engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001246 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001247
1248 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001249 // One testcase calls SetUp in a loop, only create call_ once.
1250 if (!call_) {
1251 call_.reset(webrtc::Call::Create(webrtc::Call::Config(&event_log_)));
1252 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001253 cricket::MediaConfig media_config;
1254 // Disabling cpu overuse detection actually disables quality scaling too; it
1255 // implies DegradationPreference kMaintainResolution. Automatic scaling
1256 // needs to be disabled, otherwise, tests which check the size of received
1257 // frames become flaky.
1258 media_config.video.enable_cpu_adaptation = false;
1259 channel_.reset(engine_.CreateChannel(call_.get(), media_config,
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001260 cricket::VideoOptions(),
1261 webrtc::CryptoOptions()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001262 channel_->OnReadyToSend(true);
1263 EXPECT_TRUE(channel_.get() != NULL);
1264 network_interface_.SetDestination(channel_.get());
Anton Sukhanov98a462c2018-10-17 13:15:42 -07001265 channel_->SetInterface(&network_interface_, /*media_transport=*/nullptr);
Niels Möller6557d0c2018-04-11 15:18:34 +02001266 cricket::VideoRecvParameters parameters;
1267 parameters.codecs = engine_.codecs();
1268 channel_->SetRecvParameters(parameters);
1269 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
1270 video_capturer_.reset(CreateFakeVideoCapturer());
1271 cricket::VideoFormat format(640, 480,
1272 cricket::VideoFormat::FpsToInterval(kFramerate),
1273 cricket::FOURCC_I420);
1274 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001275 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001276 }
1277
1278 virtual cricket::FakeVideoCapturerWithTaskQueue* CreateFakeVideoCapturer() {
1279 return new cricket::FakeVideoCapturerWithTaskQueue();
1280 }
1281
1282 // Utility method to setup an additional stream to send and receive video.
1283 // Used to test send and recv between two streams.
1284 void SetUpSecondStream() {
1285 SetUpSecondStreamWithNoRecv();
1286 // Setup recv for second stream.
1287 EXPECT_TRUE(channel_->AddRecvStream(
1288 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1289 // Make the second renderer available for use by a new stream.
1290 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1291 }
1292 // Setup an additional stream just to send video. Defer add recv stream.
1293 // This is required if you want to test unsignalled recv of video rtp packets.
1294 void SetUpSecondStreamWithNoRecv() {
1295 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001296 EXPECT_TRUE(
1297 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001298 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001299 EXPECT_FALSE(
1300 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001301 EXPECT_TRUE(channel_->AddSendStream(
1302 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1303 // We dont add recv for the second stream.
1304
1305 // Setup the receive and renderer for second stream after send.
1306 video_capturer_2_.reset(CreateFakeVideoCapturer());
1307 cricket::VideoFormat format(640, 480,
1308 cricket::VideoFormat::FpsToInterval(kFramerate),
1309 cricket::FOURCC_I420);
1310 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(format));
1311
Yves Gerey665174f2018-06-19 15:03:05 +02001312 EXPECT_TRUE(
1313 channel_->SetVideoSend(kSsrc + 2, nullptr, video_capturer_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001314 }
Yves Gerey665174f2018-06-19 15:03:05 +02001315 virtual void TearDown() { channel_.reset(); }
1316 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001317
1318 bool SetOneCodec(const cricket::VideoCodec& codec) {
1319 cricket::VideoFormat capture_format(
1320 kVideoWidth, kVideoHeight,
1321 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1322
1323 if (video_capturer_) {
1324 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(capture_format));
1325 }
1326 if (video_capturer_2_) {
1327 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(capture_format));
1328 }
1329
1330 bool sending = channel_->sending();
1331 bool success = SetSend(false);
1332 if (success) {
1333 cricket::VideoSendParameters parameters;
1334 parameters.codecs.push_back(codec);
1335 success = channel_->SetSendParameters(parameters);
1336 }
1337 if (success) {
1338 success = SetSend(sending);
1339 }
1340 return success;
1341 }
Yves Gerey665174f2018-06-19 15:03:05 +02001342 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001343 bool SendFrame() {
1344 if (video_capturer_2_) {
1345 video_capturer_2_->CaptureFrame();
1346 }
1347 return video_capturer_.get() && video_capturer_->CaptureFrame();
1348 }
1349 bool WaitAndSendFrame(int wait_ms) {
1350 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
1351 ret &= SendFrame();
1352 return ret;
1353 }
Yves Gerey665174f2018-06-19 15:03:05 +02001354 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001355 int NumRtpBytes(uint32_t ssrc) {
1356 return network_interface_.NumRtpBytes(ssrc);
1357 }
Yves Gerey665174f2018-06-19 15:03:05 +02001358 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001359 int NumRtpPackets(uint32_t ssrc) {
1360 return network_interface_.NumRtpPackets(ssrc);
1361 }
Yves Gerey665174f2018-06-19 15:03:05 +02001362 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001363 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1364 return network_interface_.GetRtpPacket(index);
1365 }
1366 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001367 webrtc::RTPHeader header;
1368 EXPECT_TRUE(ParseRtpPacket(p, &header));
1369 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001370 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001371
Niels Möller6557d0c2018-04-11 15:18:34 +02001372 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001373 webrtc::RTPHeader* header) {
1374 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1375 webrtc::RtpHeaderParser::Create());
1376 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001377 }
1378
1379 // Tests that we can send and receive frames.
1380 void SendAndReceive(const cricket::VideoCodec& codec) {
1381 EXPECT_TRUE(SetOneCodec(codec));
1382 EXPECT_TRUE(SetSend(true));
1383 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1384 EXPECT_EQ(0, renderer_.num_rendered_frames());
1385 EXPECT_TRUE(SendFrame());
1386 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1387 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1388 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1389 }
1390
1391 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001392 int duration_sec,
1393 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001394 EXPECT_TRUE(SetOneCodec(codec));
1395 EXPECT_TRUE(SetSend(true));
1396 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1397 EXPECT_EQ(0, renderer_.num_rendered_frames());
1398 for (int i = 0; i < duration_sec; ++i) {
1399 for (int frame = 1; frame <= fps; ++frame) {
1400 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1401 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1402 }
1403 }
1404 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1405 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1406 }
1407
Niels Möller6557d0c2018-04-11 15:18:34 +02001408 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1409 cricket::VideoMediaInfo info;
1410 EXPECT_TRUE(channel_->GetStats(&info));
1411 return info.senders[i];
1412 }
1413
1414 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1415 cricket::VideoMediaInfo info;
1416 EXPECT_TRUE(channel_->GetStats(&info));
1417 return info.receivers[i];
1418 }
1419
1420 // Two streams one channel tests.
1421
1422 // Tests that we can send and receive frames.
1423 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1424 SetUpSecondStream();
1425 // Test sending and receiving on first stream.
1426 SendAndReceive(codec);
1427 // Test sending and receiving on second stream.
1428 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1429 EXPECT_GT(NumRtpPackets(), 0);
1430 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1431 }
1432
1433 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1434 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller80cd25b2018-10-23 10:07:25 +02001435 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001436 return engine_codec;
1437 }
1438 // This point should never be reached.
1439 ADD_FAILURE() << "Unrecognized codec name: " << name;
1440 return cricket::VideoCodec();
1441 }
1442
1443 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1444
1445 cricket::StreamParams DefaultSendStreamParams() {
1446 return cricket::StreamParams::CreateLegacy(kSsrc);
1447 }
1448
1449 webrtc::RtcEventLogNullImpl event_log_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001450 std::unique_ptr<webrtc::Call> call_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001451 WebRtcVideoEngine engine_;
1452 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_;
1453 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_2_;
1454 std::unique_ptr<WebRtcVideoChannel> channel_;
1455 cricket::FakeNetworkInterface network_interface_;
1456 cricket::FakeVideoRenderer renderer_;
1457
1458 // Used by test cases where 2 streams are run on the same channel.
1459 cricket::FakeVideoRenderer renderer2_;
1460};
1461
1462// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001463TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001464 EXPECT_FALSE(channel_->sending());
Yves Gerey665174f2018-06-19 15:03:05 +02001465 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001466 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1467 EXPECT_FALSE(channel_->sending());
1468 EXPECT_TRUE(SetSend(true));
1469 EXPECT_TRUE(channel_->sending());
1470 EXPECT_TRUE(SendFrame());
1471 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1472 EXPECT_TRUE(SetSend(false));
1473 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001474}
Niels Möller6557d0c2018-04-11 15:18:34 +02001475
1476// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001477TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001478 EXPECT_FALSE(channel_->sending());
1479 EXPECT_FALSE(SetSend(true));
1480 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001481}
Niels Möller6557d0c2018-04-11 15:18:34 +02001482
1483// Test that we properly set the send and recv buffer sizes by the time
1484// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001485TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001486 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1487 EXPECT_TRUE(SetSend(true));
1488 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1489 EXPECT_EQ(64 * 1024, network_interface_.recvbuf_size());
srtee0c2eea2017-12-15 17:44:33 +01001490}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001491
Erik Språng820ebd02018-08-20 17:14:25 +02001492// Test that we properly set the send and recv buffer sizes when overriding
1493// via field trials.
1494TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSize) {
1495 // Set field trial to override the default recv buffer size, and then re-run
1496 // setup where the interface is created and configured.
1497 const int kCustomRecvBufferSize = 123456;
1498 webrtc::test::ScopedFieldTrials field_trial(
1499 "WebRTC-IncreasedReceivebuffers/123456/");
1500 SetUp();
1501
1502 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1503 EXPECT_TRUE(SetSend(true));
1504 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1505 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1506}
1507
1508// Test that we properly set the send and recv buffer sizes when overriding
1509// via field trials with suffix.
1510TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSizeWithSuffix) {
1511 // Set field trial to override the default recv buffer size, and then re-run
1512 // setup where the interface is created and configured.
1513 const int kCustomRecvBufferSize = 123456;
1514 webrtc::test::ScopedFieldTrials field_trial(
1515 "WebRTC-IncreasedReceivebuffers/123456_Dogfood/");
1516 SetUp();
1517
1518 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1519 EXPECT_TRUE(SetSend(true));
1520 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1521 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1522}
1523
1524// Test that we properly set the send and recv buffer sizes when overriding
1525// via field trials that don't make any sense.
1526TEST_F(WebRtcVideoChannelBaseTest, InvalidRecvBufferSize) {
1527 // Set bogus field trial values to override the default recv buffer size, and
1528 // then re-run setup where the interface is created and configured. The
1529 // default value should still be used.
1530
1531 for (std::string group : {" ", "NotANumber", "-1", "0"}) {
1532 std::string field_trial_string = "WebRTC-IncreasedReceivebuffers/";
1533 field_trial_string += group;
1534 field_trial_string += "/";
1535 webrtc::test::ScopedFieldTrials field_trial(field_trial_string);
1536 SetUp();
1537
1538 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1539 EXPECT_TRUE(SetSend(true));
1540 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1541 EXPECT_EQ(64 * 1024, network_interface_.recvbuf_size());
1542 }
1543}
1544
Niels Möller6557d0c2018-04-11 15:18:34 +02001545// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001546TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001547 const int kDurationSec = 3;
1548 const int kFps = 10;
1549 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1550
1551 cricket::VideoMediaInfo info;
1552 EXPECT_TRUE(channel_->GetStats(&info));
1553
1554 ASSERT_EQ(1U, info.senders.size());
1555 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1556 // For webrtc, bytes_sent does not include the RTP header length.
1557 EXPECT_GT(info.senders[0].bytes_sent, 0);
1558 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1559 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1560 ASSERT_TRUE(info.senders[0].codec_payload_type);
1561 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1562 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1563 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1564 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1565 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1566 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1567 EXPECT_GT(info.senders[0].framerate_input, 0);
1568 EXPECT_GT(info.senders[0].framerate_sent, 0);
1569
1570 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1571 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1572 info.send_codecs[DefaultCodec().id]);
1573
1574 ASSERT_EQ(1U, info.receivers.size());
1575 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1576 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1577 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1578 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1579 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1580 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1581 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1582 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1583 EXPECT_EQ(0, info.receivers[0].packets_lost);
1584 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1585 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1586 EXPECT_EQ(0, info.receivers[0].firs_sent);
1587 EXPECT_EQ(0, info.receivers[0].plis_sent);
1588 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1589 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1590 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1591 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1592 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1593 EXPECT_GT(info.receivers[0].framerate_output, 0);
1594
1595 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1596 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1597 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001598}
Niels Möller6557d0c2018-04-11 15:18:34 +02001599
1600// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001601TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001602 cricket::FakeVideoRenderer renderer1, renderer2;
1603 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1604 cricket::VideoSendParameters parameters;
1605 parameters.codecs.push_back(DefaultCodec());
1606 parameters.conference_mode = true;
1607 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1608 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001609 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1610 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001611 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1612 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1613 EXPECT_EQ(0, renderer1.num_rendered_frames());
1614 EXPECT_EQ(0, renderer2.num_rendered_frames());
1615 std::vector<uint32_t> ssrcs;
1616 ssrcs.push_back(1);
1617 ssrcs.push_back(2);
1618 network_interface_.SetConferenceMode(true, ssrcs);
1619 EXPECT_TRUE(SendFrame());
1620 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1621 kTimeout);
1622 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1623 kTimeout);
1624
1625 EXPECT_TRUE(channel_->SetSend(false));
1626
1627 cricket::VideoMediaInfo info;
1628 EXPECT_TRUE(channel_->GetStats(&info));
1629 ASSERT_EQ(1U, info.senders.size());
1630 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1631 // For webrtc, bytes_sent does not include the RTP header length.
1632 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1633 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1634 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1635 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1636
1637 ASSERT_EQ(2U, info.receivers.size());
1638 for (size_t i = 0; i < info.receivers.size(); ++i) {
1639 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1640 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1641 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001642 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001643 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1644 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1645 }
srtee0c2eea2017-12-15 17:44:33 +01001646}
Niels Möller6557d0c2018-04-11 15:18:34 +02001647
1648// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001649TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001650 // Normal setup; note that we set the SSRC explicitly to ensure that
1651 // it will come first in the senders map.
1652 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1653 cricket::VideoSendParameters parameters;
1654 parameters.codecs.push_back(DefaultCodec());
1655 parameters.conference_mode = true;
1656 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001657 EXPECT_TRUE(
1658 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001659 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1660 EXPECT_TRUE(SetSend(true));
1661 EXPECT_TRUE(SendFrame());
1662 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1663 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1664
1665 // Add an additional capturer, and hook up a renderer to receive it.
1666 cricket::FakeVideoRenderer renderer2;
1667 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1668 CreateFakeVideoCapturer());
1669 const int kTestWidth = 160;
1670 const int kTestHeight = 120;
1671 cricket::VideoFormat format(kTestWidth, kTestHeight,
1672 cricket::VideoFormat::FpsToInterval(5),
1673 cricket::FOURCC_I420);
1674 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001675 EXPECT_TRUE(
1676 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001677 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, capturer.get()));
Yves Gerey665174f2018-06-19 15:03:05 +02001678 EXPECT_TRUE(
1679 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001680 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
1681 EXPECT_TRUE(capturer->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001682 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1683 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001684
1685 // Get stats, and make sure they are correct for two senders. We wait until
1686 // the number of expected packets have been sent to avoid races where we
1687 // check stats before it has been updated.
1688 cricket::VideoMediaInfo info;
1689 for (uint32_t i = 0; i < kTimeout; ++i) {
1690 rtc::Thread::Current()->ProcessMessages(1);
1691 EXPECT_TRUE(channel_->GetStats(&info));
1692 ASSERT_EQ(2U, info.senders.size());
1693 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1694 NumRtpPackets()) {
1695 // Stats have been updated for both sent frames, expectations can be
1696 // checked now.
1697 break;
1698 }
1699 }
1700 EXPECT_EQ(NumRtpPackets(),
1701 info.senders[0].packets_sent + info.senders[1].packets_sent)
1702 << "Timed out while waiting for packet counts for all sent packets.";
1703 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1704 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1705 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1706 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1707 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1708 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1709 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1710 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1711 // The capturer must be unregistered here as it runs out of it's scope next.
1712 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001713}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001714
Niels Möller6557d0c2018-04-11 15:18:34 +02001715// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001716TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001717 cricket::VideoSendParameters parameters;
1718 parameters.codecs.push_back(DefaultCodec());
1719 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1720 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1721 parameters.max_bandwidth_bps = 128 * 1024;
1722 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001723}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001724
Niels Möller6557d0c2018-04-11 15:18:34 +02001725// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001726TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001727 EXPECT_TRUE(SetDefaultCodec());
1728 EXPECT_TRUE(SetSend(true));
1729 EXPECT_TRUE(SendFrame());
1730 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001731 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001732 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001733 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1734 EXPECT_EQ(kSsrc, header.ssrc);
1735
Niels Möller6557d0c2018-04-11 15:18:34 +02001736 // Packets are being paced out, so these can mismatch between the first and
1737 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001738 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1739 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001740 EXPECT_EQ(1, NumSentSsrcs());
1741 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1742 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001743}
Niels Möller6557d0c2018-04-11 15:18:34 +02001744
1745// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001746TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001747 // Remove stream added in Setup.
1748 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1749 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001750 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001751 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
1752 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001753 EXPECT_TRUE(SetSend(true));
1754 EXPECT_TRUE(WaitAndSendFrame(0));
1755 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001756 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001757 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001758 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1759 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001760 // Packets are being paced out, so these can mismatch between the first and
1761 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001762 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1763 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001764 EXPECT_EQ(1, NumSentSsrcs());
1765 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1766 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001767}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001768
Niels Möller6557d0c2018-04-11 15:18:34 +02001769// Test that we can set the default video renderer before and after
1770// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001771TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001772 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1773 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001774
1775 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1776 rtc::SetBE32(packet1.data() + 8, kSsrc);
1777 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1778 EXPECT_TRUE(SetDefaultCodec());
1779 EXPECT_TRUE(SetSend(true));
1780 EXPECT_EQ(0, renderer_.num_rendered_frames());
1781 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
1782 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1783 EXPECT_TRUE(SendFrame());
1784 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001785}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001786
Niels Möller6557d0c2018-04-11 15:18:34 +02001787// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001788TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001789 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1790 EXPECT_TRUE(SetSend(true));
1791 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1792 EXPECT_TRUE(SendFrame());
1793 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1794 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001795 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001796 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001797 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1798 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001799 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1800 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001801
1802 // Remove the send stream that was added during Setup.
1803 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1804 int rtp_packets = NumRtpPackets();
1805
Niels Möller6557d0c2018-04-11 15:18:34 +02001806 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001807 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
1808 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001809 EXPECT_EQ(rtp_packets, NumRtpPackets());
1810 // Wait 30ms to guarantee the engine does not drop the frame.
1811 EXPECT_TRUE(WaitAndSendFrame(30));
1812 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1813
1814 last_packet = NumRtpPackets() - 1;
1815 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001816 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1817 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001818}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001819
Niels Möller6557d0c2018-04-11 15:18:34 +02001820// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001821TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001822 cricket::FakeVideoRenderer renderer1, renderer2;
1823 EXPECT_TRUE(SetDefaultCodec());
1824 cricket::VideoSendParameters parameters;
1825 parameters.codecs.push_back(DefaultCodec());
1826 parameters.conference_mode = true;
1827 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1828 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001829 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1830 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001831 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1832 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1833 EXPECT_EQ(0, renderer1.num_rendered_frames());
1834 EXPECT_EQ(0, renderer2.num_rendered_frames());
1835 std::vector<uint32_t> ssrcs;
1836 ssrcs.push_back(1);
1837 ssrcs.push_back(2);
1838 network_interface_.SetConferenceMode(true, ssrcs);
1839 EXPECT_TRUE(SendFrame());
1840 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1841 kTimeout);
1842 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1843 kTimeout);
1844
1845 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1846 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1847 EXPECT_EQ(kVideoWidth, renderer1.width());
1848 EXPECT_EQ(kVideoHeight, renderer1.height());
1849 EXPECT_EQ(kVideoWidth, renderer2.width());
1850 EXPECT_EQ(kVideoHeight, renderer2.height());
1851 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1852 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001853}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001854
Niels Möller6557d0c2018-04-11 15:18:34 +02001855// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001856TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001857 using cricket::VideoCodec;
1858 using cricket::VideoOptions;
1859 using cricket::VideoFormat;
1860 using cricket::FOURCC_I420;
1861
1862 VideoCodec codec = DefaultCodec();
1863 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1864 EXPECT_TRUE(SetOneCodec(codec));
1865 EXPECT_TRUE(SetSend(true));
1866 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1867 EXPECT_EQ(0, renderer_.num_rendered_frames());
1868 EXPECT_TRUE(SendFrame());
1869 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1870 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1871 CreateFakeVideoCapturer());
1872
1873 // TODO(nisse): This testcase fails if we don't configure
1874 // screencast. It's unclear why, I see nothing obvious in this
1875 // test which is related to screencast logic.
1876 VideoOptions video_options;
1877 video_options.is_screencast = true;
1878 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1879
1880 VideoFormat format(480, 360, VideoFormat::FpsToInterval(30), FOURCC_I420);
1881 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
1882 // All capturers start generating frames with the same timestamp. ViE does
1883 // not allow the same timestamp to be used. Capture one frame before
1884 // associating the capturer with the channel.
1885 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1886
1887 int captured_frames = 1;
1888 for (int iterations = 0; iterations < 2; ++iterations) {
1889 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, capturer.get()));
1890 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
1891 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1892 ++captured_frames;
1893 // Wait until frame of right size is captured.
1894 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001895 format.width == renderer_.width() &&
1896 format.height == renderer_.height() &&
1897 !renderer_.black_frame(),
1898 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001899 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1900 EXPECT_EQ(format.width, renderer_.width());
1901 EXPECT_EQ(format.height, renderer_.height());
1902 captured_frames = renderer_.num_rendered_frames() + 1;
1903 EXPECT_FALSE(renderer_.black_frame());
1904 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1905 // Make sure a black frame is generated within the specified timeout.
1906 // The black frame should be the resolution of the previous frame to
1907 // prevent expensive encoder reconfigurations.
1908 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001909 format.width == renderer_.width() &&
1910 format.height == renderer_.height() &&
1911 renderer_.black_frame(),
1912 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001913 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1914 EXPECT_EQ(format.width, renderer_.width());
1915 EXPECT_EQ(format.height, renderer_.height());
1916 EXPECT_TRUE(renderer_.black_frame());
1917
1918 // The black frame has the same timestamp as the next frame since it's
1919 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1920 // not render a frame with the same timestamp so capture another frame
1921 // with the frame capturer to increment the next frame's timestamp.
1922 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1923 }
srtee0c2eea2017-12-15 17:44:33 +01001924}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001925
Niels Möller6557d0c2018-04-11 15:18:34 +02001926// Tests that if SetVideoSend is called with a NULL capturer after the
1927// capturer was already removed, the application doesn't crash (and no black
1928// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001929TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001930 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1931 EXPECT_TRUE(SetSend(true));
1932 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1933 EXPECT_EQ(0, renderer_.num_rendered_frames());
1934 EXPECT_TRUE(SendFrame());
1935 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1936 // Wait for one frame so they don't get dropped because we send frames too
1937 // tightly.
1938 rtc::Thread::Current()->ProcessMessages(30);
1939 // Remove the capturer.
1940 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1941
1942 // No capturer was added, so this SetVideoSend shouldn't do anything.
1943 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1944 rtc::Thread::Current()->ProcessMessages(300);
1945 // Verify no more frames were sent.
1946 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001947}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001948
Niels Möller6557d0c2018-04-11 15:18:34 +02001949// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001950TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001951 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1952 // interval time to avoid that.
1953 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1954 // interval time to avoid that.
1955 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001956 EXPECT_TRUE(
1957 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001958 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1959 cricket::VideoFormat capture_format(
1960 kVideoWidth, kVideoHeight,
1961 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1962 // Set up additional stream 1.
1963 cricket::FakeVideoRenderer renderer1;
1964 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001965 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001966 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001967 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001968 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer1(
1969 CreateFakeVideoCapturer());
1970 EXPECT_EQ(cricket::CS_RUNNING, capturer1->Start(capture_format));
1971 // Set up additional stream 2.
1972 cricket::FakeVideoRenderer renderer2;
1973 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001974 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001975 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001976 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001977 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer2(
1978 CreateFakeVideoCapturer());
1979 EXPECT_EQ(cricket::CS_RUNNING, capturer2->Start(capture_format));
1980 // State for all the streams.
1981 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1982 // A limitation in the lmi implementation requires that SetVideoSend() is
1983 // called after SetOneCodec().
1984 // TODO(hellner): this seems like an unnecessary constraint, fix it.
1985 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, capturer1.get()));
1986 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, capturer2.get()));
1987 EXPECT_TRUE(SetSend(true));
1988 // Test capturer associated with engine.
1989 const int kTestWidth = 160;
1990 const int kTestHeight = 120;
1991 EXPECT_TRUE(capturer1->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001992 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
1993 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001994 // Capture a frame with additional capturer2, frames should be received
1995 EXPECT_TRUE(capturer2->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001996 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1997 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001998 // Successfully remove the capturer.
1999 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
2000 // The capturers must be unregistered here as it runs out of it's scope
2001 // next.
2002 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
2003 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01002004}
Niels Möller6557d0c2018-04-11 15:18:34 +02002005
2006// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01002007TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002008 // Remove the send stream that was added during Setup.
2009 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
2010
2011 cricket::StreamParams empty;
2012 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02002013 EXPECT_TRUE(
2014 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01002015}
Niels Möller6557d0c2018-04-11 15:18:34 +02002016
2017// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01002018TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002019 // Remove stream added in Setup. I.e. remove stream corresponding to default
2020 // channel.
2021 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02002022 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02002023 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
2024 EXPECT_TRUE(channel_->AddSendStream(
2025 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
2026 }
2027 // Delete one of the non default channel streams, let the destructor delete
2028 // the remaining ones.
2029 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
2030 // Stream should already be deleted.
2031 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01002032}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00002033
eladalonf1841382017-06-12 01:16:46 -07002034TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08002035 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002036}
2037
eladalonf1841382017-06-12 01:16:46 -07002038TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08002039 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002040}
2041
eladalonf1841382017-06-12 01:16:46 -07002042TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002043 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002044}
2045
eladalonf1841382017-06-12 01:16:46 -07002046TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002047 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2048 // bitrates. This currently happens at <250k, and two streams sharing 300k
2049 // initially will use QVGA instead of VGA.
2050 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2051 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002052 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002053 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002054 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002055}
2056
eladalonf1841382017-06-12 01:16:46 -07002057class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002058 public:
eladalonf1841382017-06-12 01:16:46 -07002059 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2060 explicit WebRtcVideoChannelTest(const char* field_trials)
2061 : WebRtcVideoEngineTest(field_trials), last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002062 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002063 encoder_factory_->AddSupportedVideoCodecType("VP8");
2064 encoder_factory_->AddSupportedVideoCodecType("VP9");
2065#if defined(WEBRTC_USE_H264)
2066 encoder_factory_->AddSupportedVideoCodecType("H264");
2067#endif
2068
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002069 fake_call_.reset(new FakeCall());
kthelgason2bc68642017-02-07 07:02:22 -08002070 channel_.reset(engine_.CreateChannel(fake_call_.get(), GetMediaConfig(),
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002071 VideoOptions(),
2072 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002073 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002074 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002075 send_parameters_.codecs = engine_.codecs();
2076 recv_parameters_.codecs = engine_.codecs();
2077 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002078 }
2079
2080 protected:
2081 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002082 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002083 }
2084
2085 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002086 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002087 EXPECT_TRUE(channel_->AddSendStream(sp));
2088 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002089 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002090 EXPECT_EQ(num_streams + 1, streams.size());
2091 return streams[streams.size() - 1];
2092 }
2093
2094 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002095 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002096 }
2097
2098 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002099 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002100 }
2101
2102 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002103 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002104 EXPECT_TRUE(channel_->AddRecvStream(sp));
2105 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002106 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002107 EXPECT_EQ(num_streams + 1, streams.size());
2108 return streams[streams.size() - 1];
2109 }
2110
pbos@webrtc.org00873182014-11-25 14:03:34 +00002111 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2112 int expected_min_bitrate_bps,
2113 const char* start_bitrate_kbps,
2114 int expected_start_bitrate_bps,
2115 const char* max_bitrate_kbps,
2116 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002117 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2118 expected_start_bitrate_bps,
2119 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002120 auto& codecs = send_parameters_.codecs;
2121 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002122 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002123 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2124 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2125 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002126 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002127 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002128
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002129 void ExpectSetBitrateParameters(int min_bitrate_bps,
2130 int start_bitrate_bps,
2131 int max_bitrate_bps) {
2132 EXPECT_CALL(
2133 *fake_call_->GetMockTransportControllerSend(),
2134 SetSdpBitrateParameters(AllOf(
2135 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2136 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2137 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2138 }
2139
2140 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2141 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2142 SetSdpBitrateParameters(Field(
2143 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002144 }
2145
isheriff6f8d6862016-05-26 11:24:55 -07002146 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002147 // Enable extension.
2148 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002149 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002150 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002151 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002152 FakeVideoSendStream* send_stream =
2153 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2154
2155 // Verify the send extension id.
2156 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2157 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002158 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002159 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002160 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002161 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2162 // receivers.
2163 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2164 ->GetConfig()
2165 .rtp.extensions.empty());
2166
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002167 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002168 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002169 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2170 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002171 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2172
2173 // Verify that adding receive RTP header extensions adds them for existing
2174 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002175 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002176 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002177 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2178 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002179 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002180 }
2181
isheriff6f8d6862016-05-26 11:24:55 -07002182 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002183 // Enable extension.
2184 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002185 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002186 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002187 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002188
2189 FakeVideoReceiveStream* recv_stream =
2190 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2191
2192 // Verify the recv extension id.
2193 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2194 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002195 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002196 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002197 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002198
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002199 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2200 // senders.
2201 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2202 ->GetConfig()
2203 .rtp.extensions.empty());
2204
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002205 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002206 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002207 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2208 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002209 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2210
2211 // Verify that adding receive RTP header extensions adds them for existing
2212 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002213 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002214 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002215 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2216 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002217 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002218 }
2219
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002220 void TestExtensionFilter(const std::vector<std::string>& extensions,
2221 const std::string& expected_extension) {
2222 cricket::VideoSendParameters parameters = send_parameters_;
2223 int expected_id = -1;
2224 int id = 1;
2225 for (const std::string& extension : extensions) {
2226 if (extension == expected_extension)
2227 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002228 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002229 }
2230 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2231 FakeVideoSendStream* send_stream =
2232 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2233
2234 // Verify that only one of them has been set, and that it is the one with
2235 // highest priority (transport sequence number).
2236 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2237 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2238 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002239 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002240 }
2241
asapersson3c81a1a2017-06-14 05:52:21 -07002242 void TestDegradationPreference(bool resolution_scaling_enabled,
2243 bool fps_scaling_enabled);
2244
Erik Språngefbde372015-04-29 16:21:28 +02002245 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002246 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002247 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2248 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002249
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002250 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002251 uint32_t ssrc,
Tommi85959932018-02-07 19:26:06 +01002252 FakeVideoCapturerWithTaskQueue* capturer,
nisse0db023a2016-03-01 04:29:59 -08002253 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002254 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002255 options.video_noise_reduction = enabled;
Niels Möllerff40b142018-04-09 08:49:14 +02002256 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, capturer));
nisse0db023a2016-03-01 04:29:59 -08002257 // Options only take effect on the next frame.
2258 EXPECT_TRUE(capturer->CaptureFrame());
2259
Erik Språng143cec12015-04-28 10:01:41 +02002260 return fake_call_->GetVideoSendStreams().back();
2261 }
2262
Peter Boström2feafdb2015-09-09 14:32:14 +02002263 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2264 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002265 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002266 std::vector<uint32_t> ssrcs;
2267 std::vector<uint32_t> rtx_ssrcs;
2268 uint32_t num_streams = enabled ? 3 : 1;
2269 for (uint32_t i = 0; i < num_streams; ++i) {
2270 uint32_t ssrc = last_ssrc_ + i;
2271 ssrcs.push_back(ssrc);
2272 if (with_rtx) {
2273 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2274 }
Erik Språng143cec12015-04-28 10:01:41 +02002275 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002276 if (with_rtx) {
2277 return AddSendStream(
2278 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2279 }
2280 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002281 }
2282
perkjfa10b552016-10-02 23:45:26 -07002283 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002284 std::vector<FakeVideoSendStream*> streams =
2285 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002286 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002287 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002288 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002289 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002290 }
2291
perkjfa10b552016-10-02 23:45:26 -07002292 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002293 int stream_max,
2294 int expected_encoder_bitrate) {
2295 VideoSendParameters limited_send_params = send_parameters_;
2296 limited_send_params.max_bandwidth_bps = global_max;
2297 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002298 webrtc::RtpParameters parameters =
2299 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002300 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002301 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002302 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002303 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002304 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002305 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002306 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002307 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002308 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002309 }
2310
Åsa Persson55659812018-06-18 17:51:32 +02002311 // Values from kSimulcastConfigs in simulcast.cc.
2312 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2313 std::vector<webrtc::VideoStream> layers(3);
2314 layers[0].min_bitrate_bps = 30000;
2315 layers[0].target_bitrate_bps = 150000;
2316 layers[0].max_bitrate_bps = 200000;
2317 layers[1].min_bitrate_bps = 150000;
2318 layers[1].target_bitrate_bps = 500000;
2319 layers[1].max_bitrate_bps = 700000;
2320 layers[2].min_bitrate_bps = 600000;
2321 layers[2].target_bitrate_bps = 2500000;
2322 layers[2].max_bitrate_bps = 2500000;
2323 return layers;
2324 }
2325
kwiberg686a8ef2016-02-26 03:00:35 -08002326 std::unique_ptr<FakeCall> fake_call_;
2327 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002328 cricket::VideoSendParameters send_parameters_;
2329 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002330 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002331};
2332
eladalonf1841382017-06-12 01:16:46 -07002333TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002334 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002335 const std::string kSyncLabel = "AvSyncLabel";
2336
2337 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002338 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002339 EXPECT_TRUE(channel_->AddRecvStream(sp));
2340
Mirko Bonadeif859e552018-05-30 15:31:29 +02002341 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002342 EXPECT_EQ(kSyncLabel,
2343 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2344 << "SyncGroup should be set based on sync_label";
2345}
2346
eladalonf1841382017-06-12 01:16:46 -07002347TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002348 cricket::VideoSendParameters parameters;
2349 parameters.codecs = engine_.codecs();
2350 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002351 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002352 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002353 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002354
2355 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002356 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2357 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002358 FakeVideoSendStream* send_stream = AddSendStream(
2359 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2360
2361 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2362 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2363 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2364
2365 // Receiver side.
2366 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2367 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002368 EXPECT_FALSE(
2369 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002370 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002371 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002372 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002373 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002374 << "RTX should be mapped for the RED payload type";
2375
brandtr14742122017-01-27 04:53:07 -08002376 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002377}
2378
eladalonf1841382017-06-12 01:16:46 -07002379TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002380 // Setup one channel with an associated RTX stream.
2381 cricket::StreamParams params =
2382 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2383 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2384 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002385 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002386
2387 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2388 << "RTX should be mapped for all decoders/payload types.";
2389 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002390 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002391 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002392}
2393
eladalonf1841382017-06-12 01:16:46 -07002394TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002395 // Setup one channel without an associated RTX stream.
2396 cricket::StreamParams params =
2397 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2398 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002399 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002400}
2401
eladalonf1841382017-06-12 01:16:46 -07002402TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002403 FakeVideoSendStream* send_stream =
2404 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2405 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2406
2407 FakeVideoReceiveStream* recv_stream =
2408 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2409 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002410}
2411
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002412// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002413TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002414 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002415}
isheriff6f8d6862016-05-26 11:24:55 -07002416
eladalonf1841382017-06-12 01:16:46 -07002417TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002418 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002419}
2420
2421// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002422TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002423 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002424}
isheriff6f8d6862016-05-26 11:24:55 -07002425
eladalonf1841382017-06-12 01:16:46 -07002426TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002427 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002428}
2429
eladalonf1841382017-06-12 01:16:46 -07002430TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002431 // Enable three redundant extensions.
2432 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002433 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2434 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2435 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2436 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002437}
2438
eladalonf1841382017-06-12 01:16:46 -07002439TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002440 // Enable two redundant extensions.
2441 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002442 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2443 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2444 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002445}
2446
stefanc1aeaf02015-10-15 07:26:07 -07002447// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002448TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002449 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002450}
eladalonf1841382017-06-12 01:16:46 -07002451TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002452 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002453}
2454
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002455// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002456TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002457 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002458}
eladalonf1841382017-06-12 01:16:46 -07002459TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002460 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002461}
2462
eladalonf1841382017-06-12 01:16:46 -07002463TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002464 const int kAbsSendTimeId = 1;
2465 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002466 send_parameters_.extensions.push_back(
2467 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2468 send_parameters_.extensions.push_back(
2469 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002470
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002471 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002472 FakeVideoSendStream* send_stream =
2473 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2474
2475 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002476 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002477
2478 // Setting the same extensions (even if in different order) shouldn't
2479 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002480 std::reverse(send_parameters_.extensions.begin(),
2481 send_parameters_.extensions.end());
2482 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002483
2484 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2485
2486 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002487 send_parameters_.extensions.resize(1);
2488 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002489
2490 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2491}
2492
eladalonf1841382017-06-12 01:16:46 -07002493TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002494 const int kTOffsetId = 1;
2495 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002496 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002497 recv_parameters_.extensions.push_back(
2498 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2499 recv_parameters_.extensions.push_back(
2500 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2501 recv_parameters_.extensions.push_back(
2502 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002503
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002504 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002505 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002506 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2507
2508 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002509 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002510
2511 // Setting the same extensions (even if in different order) shouldn't
2512 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002513 std::reverse(recv_parameters_.extensions.begin(),
2514 recv_parameters_.extensions.end());
2515 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002516
2517 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2518
2519 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002520 recv_parameters_.extensions.resize(1);
2521 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002522
2523 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2524}
2525
eladalonf1841382017-06-12 01:16:46 -07002526TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002527 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002528 const int kUnsupportedId = 1;
2529 const int kTOffsetId = 2;
2530
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002531 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002532 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002533 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002534 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002535 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002536 FakeVideoSendStream* send_stream =
2537 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2538
2539 // Only timestamp offset extension is set to send stream,
2540 // unsupported rtp extension is ignored.
2541 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002542 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2543 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002544}
2545
eladalonf1841382017-06-12 01:16:46 -07002546TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002547 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002548 const int kUnsupportedId = 1;
2549 const int kTOffsetId = 2;
2550
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002551 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002552 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002553 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002554 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002555 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002556 FakeVideoReceiveStream* recv_stream =
2557 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2558
2559 // Only timestamp offset extension is set to receive stream,
2560 // unsupported rtp extension is ignored.
2561 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002562 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2563 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002564}
2565
eladalonf1841382017-06-12 01:16:46 -07002566TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002567 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002568 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002569 send_parameters_.extensions.push_back(
2570 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002571 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002572 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2573 }
2574}
2575
eladalonf1841382017-06-12 01:16:46 -07002576TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002577 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002578 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002579 recv_parameters_.extensions.push_back(
2580 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002581 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002582 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2583 }
2584}
2585
eladalonf1841382017-06-12 01:16:46 -07002586TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002587 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002588 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002589 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002590 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002591 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002592 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002593
2594 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002595 send_parameters_.extensions.clear();
2596 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002597 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002598 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2599 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002600}
2601
eladalonf1841382017-06-12 01:16:46 -07002602TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002603 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002604 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002605 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002606 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002607 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002608 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002609
2610 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002611 recv_parameters_.extensions.clear();
2612 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002613 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002614 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2615 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002616}
2617
eladalonf1841382017-06-12 01:16:46 -07002618TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002619 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002620 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002621}
2622
eladalonf1841382017-06-12 01:16:46 -07002623TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002624 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002625 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002626}
2627
eladalonf1841382017-06-12 01:16:46 -07002628TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002629 FakeVideoReceiveStream* stream = AddRecvStream();
2630 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002631}
2632
eladalonf1841382017-06-12 01:16:46 -07002633TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002634 FakeVideoReceiveStream* stream = AddRecvStream();
2635 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2636}
2637
eladalonf1841382017-06-12 01:16:46 -07002638TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002639 FakeVideoReceiveStream* stream = AddRecvStream();
2640 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2641
Peter Boström126c03e2015-05-11 12:48:12 +02002642 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002643 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002644 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002645 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2646 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002647 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002648 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2649
2650 // Verify that REMB is turned on when setting default codecs since the
2651 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002652 parameters.codecs = engine_.codecs();
2653 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002654 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002655 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002656}
2657
eladalonf1841382017-06-12 01:16:46 -07002658TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002659 FakeVideoReceiveStream* stream = AddRecvStream();
2660 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2661
2662 // Verify that transport cc feedback is turned off when send(!) codecs without
2663 // transport cc feedback are set.
2664 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002665 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002666 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2667 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2668 stream = fake_call_->GetVideoReceiveStreams()[0];
2669 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2670
2671 // Verify that transport cc feedback is turned on when setting default codecs
2672 // since the default codecs have transport cc feedback enabled.
2673 parameters.codecs = engine_.codecs();
2674 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2675 stream = fake_call_->GetVideoReceiveStreams()[0];
2676 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2677}
2678
eladalonf1841382017-06-12 01:16:46 -07002679TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002680 AssignDefaultCodec();
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002681 VerifyCodecHasDefaultFeedbackParams(default_codec_);
2682
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002683 cricket::VideoSendParameters parameters;
2684 parameters.codecs = engine_.codecs();
2685 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002686 EXPECT_TRUE(channel_->SetSend(true));
2687
2688 // Send side.
2689 FakeVideoSendStream* send_stream =
2690 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2691 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2692
2693 // Receiver side.
2694 FakeVideoReceiveStream* recv_stream =
2695 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2696 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2697
2698 // Nack history size should match between sender and receiver.
2699 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2700 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002701}
2702
eladalonf1841382017-06-12 01:16:46 -07002703TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002704 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002705 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002706
2707 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2708 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2709
2710 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002711 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002712 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002713 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2714 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002715 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2716 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2717 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002718 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2719
Peter Boström67c9df72015-05-11 14:34:58 +02002720 // Verify that NACK is turned on when setting default codecs since the
2721 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002722 parameters.codecs = engine_.codecs();
2723 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002724 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2725 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2726 send_stream = fake_call_->GetVideoSendStreams()[0];
2727 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002728}
2729
Peter Boströme7ba0862016-03-12 00:02:28 +01002730// This test verifies that new frame sizes reconfigures encoders even though not
2731// (yet) sending. The purpose of this is to permit encoding as quickly as
2732// possible once we start sending. Likely the frames being input are from the
2733// same source that will be sent later, which just means that we're ready
2734// earlier.
eladalonf1841382017-06-12 01:16:46 -07002735TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002736 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002737 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002738 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2739 channel_->SetSend(false);
2740
2741 FakeVideoSendStream* stream = AddSendStream();
2742
perkjfa10b552016-10-02 23:45:26 -07002743 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002744 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002745 EXPECT_EQ(0u, streams[0].width);
2746 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002747
Tommi85959932018-02-07 19:26:06 +01002748 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002749 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj26752742016-10-24 01:21:16 -07002750 VideoFormat capture_format = capturer.GetSupportedFormats()->front();
2751 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
Peter Boströme7ba0862016-03-12 00:02:28 +01002752 EXPECT_TRUE(capturer.CaptureFrame());
2753
2754 // Frame entered, should be reconfigured to new dimensions.
2755 streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002756 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.width), streams[0].width);
2757 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.height),
2758 streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002759
Niels Möllerff40b142018-04-09 08:49:14 +02002760 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002761}
2762
eladalonf1841382017-06-12 01:16:46 -07002763TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002764 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002765 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002766 cricket::VideoSendParameters parameters;
2767 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002768 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002769 AddSendStream();
2770
Tommi85959932018-02-07 19:26:06 +01002771 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07002772 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002773 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Yves Gerey665174f2018-06-19 15:03:05 +02002774 EXPECT_TRUE(
2775 channel_->SetVideoSend(last_ssrc_, &min_bitrate_options, &capturer));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002776 cricket::VideoFormat capture_format_hd =
2777 capturer.GetSupportedFormats()->front();
2778 EXPECT_EQ(1280, capture_format_hd.width);
2779 EXPECT_EQ(720, capture_format_hd.height);
2780 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2781
2782 EXPECT_TRUE(channel_->SetSend(true));
2783
2784 EXPECT_TRUE(capturer.CaptureFrame());
2785 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2786 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2787
2788 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2789
2790 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002791 webrtc::VideoEncoderConfig encoder_config =
2792 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002793 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002794 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002795 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002796 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2797 streams.front().width);
2798 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2799 streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002800 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2801 << "Non-screenshare shouldn't use min-transmit bitrate.";
2802
Niels Möllerff40b142018-04-09 08:49:14 +02002803 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002804 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002805 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002806 screencast_options.is_screencast = true;
deadbeef5a4a75a2016-06-02 16:23:38 -07002807 EXPECT_TRUE(
Niels Möllerff40b142018-04-09 08:49:14 +02002808 channel_->SetVideoSend(last_ssrc_, &screencast_options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08002809 EXPECT_TRUE(capturer.CaptureFrame());
sprangf24a0642017-02-28 13:23:26 -08002810 // Send stream recreated after option change.
2811 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2812 send_stream = fake_call_->GetVideoSendStreams().front();
2813 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002814
2815 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002816 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002817 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002818 encoder_config.content_type);
2819 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2820 encoder_config.min_transmit_bitrate_bps);
2821
perkjfa10b552016-10-02 23:45:26 -07002822 streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002823 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2824 streams.front().width);
2825 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2826 streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002827 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002828 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002829}
2830
eladalonf1841382017-06-12 01:16:46 -07002831TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002832 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002833 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002834 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002835 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002836
2837 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002838 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002839 options.is_screencast = true;
Tommi85959932018-02-07 19:26:06 +01002840 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002841 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002842 cricket::VideoFormat capture_format_hd =
2843 capturer.GetSupportedFormats()->front();
2844 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2845
2846 EXPECT_TRUE(channel_->SetSend(true));
2847
2848 EXPECT_TRUE(capturer.CaptureFrame());
2849 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2850 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2851
perkj26091b12016-09-01 01:17:40 -07002852 webrtc::VideoEncoderConfig encoder_config =
2853 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002854
2855 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002856 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002857 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002858 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002859
2860 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2861 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002862 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002863 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002864 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002865
Niels Möllerff40b142018-04-09 08:49:14 +02002866 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002867}
2868
eladalonf1841382017-06-12 01:16:46 -07002869TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002870 FakeVideoSendStream* stream = AddSendStream();
2871 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2872}
2873
eladalonf1841382017-06-12 01:16:46 -07002874TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002875 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002876 media_config.video.suspend_below_min_bitrate = true;
2877
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002878 channel_.reset(engine_.CreateChannel(
2879 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002880 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002881
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002882 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002883
2884 FakeVideoSendStream* stream = AddSendStream();
2885 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2886
nisse0db023a2016-03-01 04:29:59 -08002887 media_config.video.suspend_below_min_bitrate = false;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002888 channel_.reset(engine_.CreateChannel(
2889 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002890 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002891
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002892 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002893
nisse0db023a2016-03-01 04:29:59 -08002894 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002895 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2896}
2897
eladalonf1841382017-06-12 01:16:46 -07002898TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002899 FakeVideoSendStream* stream = AddSendStream();
2900 webrtc::VideoCodecVP8 vp8_settings;
2901 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2902 EXPECT_TRUE(vp8_settings.denoisingOn);
2903}
2904
eladalonf1841382017-06-12 01:16:46 -07002905TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002906 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002907 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002908 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002909
Peter Boström2feafdb2015-09-09 14:32:14 +02002910 // Single-stream settings should apply with RTX as well (verifies that we
2911 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2912 // both RTX and regular SSRCs).
2913 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002914
Tommi85959932018-02-07 19:26:06 +01002915 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002916 EXPECT_EQ(cricket::CS_RUNNING,
2917 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002918 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002919 channel_->SetSend(true);
2920
2921 EXPECT_TRUE(capturer.CaptureFrame());
2922
pbos4cba4eb2015-10-26 11:18:18 -07002923 webrtc::VideoCodecVP8 vp8_settings;
2924 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2925 EXPECT_TRUE(vp8_settings.denoisingOn)
2926 << "VP8 denoising should be on by default.";
2927
nisse05103312016-03-16 02:22:50 -07002928 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002929
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002930 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2931 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002932 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2933 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002934
nisse05103312016-03-16 02:22:50 -07002935 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002936
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002937 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2938 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002939 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2940 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2941
Niels Möllerff40b142018-04-09 08:49:14 +02002942 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002943 stream = SetUpSimulcast(true, false);
Niels Möllerff40b142018-04-09 08:49:14 +02002944 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002945 channel_->SetSend(true);
2946 EXPECT_TRUE(capturer.CaptureFrame());
2947
Mirko Bonadeif859e552018-05-30 15:31:29 +02002948 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002949 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2950 // Autmatic resize off when using simulcast.
2951 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2952 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2953
2954 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002955 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002956 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002957 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
Niels Möller60653ba2016-03-02 11:41:36 +01002958
nisse05103312016-03-16 02:22:50 -07002959 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002960
Mirko Bonadeif859e552018-05-30 15:31:29 +02002961 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002962 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2963 EXPECT_FALSE(vp8_settings.denoisingOn);
2964 // Resizing and frame dropping always off for screen sharing.
2965 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2966 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2967
nisse05103312016-03-16 02:22:50 -07002968 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02002969
2970 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2971 EXPECT_FALSE(vp8_settings.denoisingOn);
2972 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2973 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2974
Niels Möllerff40b142018-04-09 08:49:14 +02002975 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02002976}
2977
deadbeef119760a2016-04-04 11:43:27 -07002978// Test that setting the same options doesn't result in the encoder being
2979// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07002980TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07002981 VideoOptions options;
Tommi85959932018-02-07 19:26:06 +01002982 FakeVideoCapturerWithTaskQueue capturer;
deadbeef119760a2016-04-04 11:43:27 -07002983
perkjfa10b552016-10-02 23:45:26 -07002984 AddSendStream();
deadbeef119760a2016-04-04 11:43:27 -07002985 EXPECT_EQ(cricket::CS_RUNNING,
2986 capturer.Start(capturer.GetSupportedFormats()->front()));
perkjfa10b552016-10-02 23:45:26 -07002987 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002988 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07002989 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2990 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2991
Niels Möllerff40b142018-04-09 08:49:14 +02002992 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
2993 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002994 EXPECT_TRUE(capturer.CaptureFrame());
perkjfa10b552016-10-02 23:45:26 -07002995 // Expect 1 reconfigurations at this point from the initial configuration.
2996 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07002997
2998 // Set the options one more time and expect no additional reconfigurations.
Niels Möllerff40b142018-04-09 08:49:14 +02002999 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkjfa10b552016-10-02 23:45:26 -07003000 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
3001
3002 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01003003 options.video_noise_reduction = true;
Niels Möllerff40b142018-04-09 08:49:14 +02003004 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07003005 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
3006
Niels Möllerff40b142018-04-09 08:49:14 +02003007 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07003008}
3009
eladalonf1841382017-06-12 01:16:46 -07003010class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02003011 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07003012 Vp9SettingsTest() : Vp9SettingsTest("") {}
3013 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07003014 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02003015 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003016 }
3017 virtual ~Vp9SettingsTest() {}
3018
3019 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003020 void TearDown() override {
3021 // Remove references to encoder_factory_ since this will be destroyed
3022 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003023 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003024 }
Erik Språng143cec12015-04-28 10:01:41 +02003025};
3026
3027TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003028 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003029 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003030 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003031
Peter Boström2feafdb2015-09-09 14:32:14 +02003032 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003033
Tommi85959932018-02-07 19:26:06 +01003034 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02003035 EXPECT_EQ(cricket::CS_RUNNING,
3036 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003037 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02003038 channel_->SetSend(true);
3039
3040 EXPECT_TRUE(capturer.CaptureFrame());
3041
pbos4cba4eb2015-10-26 11:18:18 -07003042 webrtc::VideoCodecVP9 vp9_settings;
3043 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003044 EXPECT_TRUE(vp9_settings.denoisingOn)
3045 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003046
nisse05103312016-03-16 02:22:50 -07003047 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003048
Erik Språng143cec12015-04-28 10:01:41 +02003049 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3050 EXPECT_FALSE(vp9_settings.denoisingOn);
3051 // Frame dropping always on for real time video.
3052 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3053
nisse05103312016-03-16 02:22:50 -07003054 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02003055
3056 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3057 EXPECT_TRUE(vp9_settings.denoisingOn);
3058 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3059
3060 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003061 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003062 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02003063 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003064
nisse05103312016-03-16 02:22:50 -07003065 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003066
3067 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3068 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003069 // Frame dropping always on for screen sharing.
3070 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003071
nisse05103312016-03-16 02:22:50 -07003072 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003073
3074 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3075 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003076 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003077
Niels Möllerff40b142018-04-09 08:49:14 +02003078 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003079}
3080
Sergey Silkinf18072e2018-03-14 10:35:35 +01003081TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3082 cricket::VideoSendParameters parameters;
3083 parameters.codecs.push_back(GetEngineCodec("VP9"));
3084 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3085
3086 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3087
3088 FakeVideoSendStream* stream =
3089 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3090
3091 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3092 EXPECT_EQ(ssrcs.size(), config.rtp.ssrcs.size());
3093
3094 FakeVideoCapturerWithTaskQueue capturer;
3095 EXPECT_EQ(cricket::CS_RUNNING,
3096 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003097 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &capturer));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003098 channel_->SetSend(true);
3099
3100 EXPECT_TRUE(capturer.CaptureFrame());
3101
3102 webrtc::VideoCodecVP9 vp9_settings;
3103 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3104
3105 const size_t kNumSpatialLayers = ssrcs.size();
3106 const size_t kNumTemporalLayers = 3;
3107 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3108 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3109
Niels Möllerff40b142018-04-09 08:49:14 +02003110 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003111}
3112
asaperssonc5dabdd2016-03-21 04:15:50 -07003113class Vp9SettingsTestWithFieldTrial : public Vp9SettingsTest {
3114 public:
brandtr468da7c2016-11-22 02:16:47 -08003115 explicit Vp9SettingsTestWithFieldTrial(const char* field_trials)
asaperssonc5dabdd2016-03-21 04:15:50 -07003116 : Vp9SettingsTest(field_trials) {}
3117
3118 protected:
3119 void VerifySettings(int num_spatial_layers, int num_temporal_layers) {
3120 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003121 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003122 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3123
3124 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3125
Tommi85959932018-02-07 19:26:06 +01003126 FakeVideoCapturerWithTaskQueue capturer;
asaperssonc5dabdd2016-03-21 04:15:50 -07003127 EXPECT_EQ(cricket::CS_RUNNING,
3128 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003129 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
asaperssonc5dabdd2016-03-21 04:15:50 -07003130 channel_->SetSend(true);
3131
3132 EXPECT_TRUE(capturer.CaptureFrame());
3133
3134 webrtc::VideoCodecVP9 vp9_settings;
3135 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3136 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3137 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
3138
Niels Möllerff40b142018-04-09 08:49:14 +02003139 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003140 }
3141};
3142
3143class Vp9SettingsTestWithNoFlag : public Vp9SettingsTestWithFieldTrial {
3144 public:
3145 Vp9SettingsTestWithNoFlag() : Vp9SettingsTestWithFieldTrial("") {}
3146};
3147
3148TEST_F(Vp9SettingsTestWithNoFlag, VerifySettings) {
3149 const int kNumSpatialLayers = 1;
3150 const int kNumTemporalLayers = 1;
3151 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3152}
3153
3154class Vp9SettingsTestWithInvalidFlag : public Vp9SettingsTestWithFieldTrial {
3155 public:
3156 Vp9SettingsTestWithInvalidFlag()
3157 : Vp9SettingsTestWithFieldTrial("WebRTC-SupportVP9SVC/Default/") {}
3158};
3159
3160TEST_F(Vp9SettingsTestWithInvalidFlag, VerifySettings) {
3161 const int kNumSpatialLayers = 1;
3162 const int kNumTemporalLayers = 1;
3163 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3164}
3165
3166class Vp9SettingsTestWith2SL3TLFlag : public Vp9SettingsTestWithFieldTrial {
3167 public:
3168 Vp9SettingsTestWith2SL3TLFlag()
3169 : Vp9SettingsTestWithFieldTrial(
3170 "WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/") {}
3171};
3172
3173TEST_F(Vp9SettingsTestWith2SL3TLFlag, VerifySettings) {
3174 const int kNumSpatialLayers = 2;
3175 const int kNumTemporalLayers = 3;
3176 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3177}
3178
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003179TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3180 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3181 ASSERT_EQ(1u, streams.size());
3182 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3183}
3184
3185TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
3186 webrtc::test::ScopedFieldTrials override_field_trials_(
3187 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3188 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3189 ASSERT_EQ(1u, streams.size());
3190 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3191}
3192
asapersson3c81a1a2017-06-14 05:52:21 -07003193TEST_F(WebRtcVideoChannelTest,
3194 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
3195 webrtc::test::ScopedFieldTrials override_field_trials_(
3196 "WebRTC-Video-BalancedDegradation/Disabled/");
3197 const bool kResolutionScalingEnabled = true;
3198 const bool kFpsScalingEnabled = false;
3199 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3200}
3201
3202TEST_F(WebRtcVideoChannelTest,
3203 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
3204 webrtc::test::ScopedFieldTrials override_field_trials_(
3205 "WebRTC-Video-BalancedDegradation/Enabled/");
3206 const bool kResolutionScalingEnabled = true;
3207 const bool kFpsScalingEnabled = true;
3208 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3209}
3210
eladalonf1841382017-06-12 01:16:46 -07003211TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003212 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003213}
3214
eladalonf1841382017-06-12 01:16:46 -07003215TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003216 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003217}
3218
eladalonf1841382017-06-12 01:16:46 -07003219TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003220 TestCpuAdaptation(true, true);
3221}
3222
eladalonf1841382017-06-12 01:16:46 -07003223TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruseAndChangeResolution) {
magjed509e4fe2016-11-18 01:34:11 -08003224 cricket::VideoCodec codec = GetEngineCodec("VP8");
perkj2d5f0912016-02-29 00:04:41 -08003225 cricket::VideoSendParameters parameters;
3226 parameters.codecs.push_back(codec);
3227
kthelgason2bc68642017-02-07 07:02:22 -08003228 MediaConfig media_config = GetMediaConfig();
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003229 channel_.reset(engine_.CreateChannel(
3230 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003231 channel_->OnReadyToSend(true);
perkj2d5f0912016-02-29 00:04:41 -08003232 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3233
3234 AddSendStream();
3235
Tommi85959932018-02-07 19:26:06 +01003236 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003237 ASSERT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003238 ASSERT_EQ(cricket::CS_RUNNING,
3239 capturer.Start(capturer.GetSupportedFormats()->front()));
3240 ASSERT_TRUE(channel_->SetSend(true));
3241
3242 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3243 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003244
Niels Möllera6cc0f92018-02-12 17:14:55 +01003245 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003246 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3247 EXPECT_EQ(1280, send_stream->GetLastWidth());
3248 EXPECT_EQ(720, send_stream->GetLastHeight());
3249
3250 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003251 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003252 wants.max_pixel_count =
3253 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003254 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003255 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003256 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3257 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3258 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3259
3260 // Trigger overuse again.
sprangc5d62e22017-04-02 23:53:04 -07003261 wants.max_pixel_count =
3262 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003263 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003264 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003265 EXPECT_EQ(3, send_stream->GetNumberOfSwappedFrames());
3266 EXPECT_EQ(1280 * 2 / 4, send_stream->GetLastWidth());
3267 EXPECT_EQ(720 * 2 / 4, send_stream->GetLastHeight());
3268
3269 // Change input resolution.
Niels Möllera6cc0f92018-02-12 17:14:55 +01003270 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003271 EXPECT_EQ(4, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003272 EXPECT_EQ(1284 / 2, send_stream->GetLastWidth());
3273 EXPECT_EQ(724 / 2, send_stream->GetLastHeight());
3274
3275 // Trigger underuse which should go back up in resolution.
sprang84a37592017-02-10 07:04:27 -08003276 int current_pixel_count =
3277 send_stream->GetLastWidth() * send_stream->GetLastHeight();
3278 // Cap the max to 4x the pixel count (assuming max 1/2 x 1/2 scale downs)
3279 // of the current stream, so we don't take too large steps.
sprangc5d62e22017-04-02 23:53:04 -07003280 wants.max_pixel_count = current_pixel_count * 4;
sprang84a37592017-02-10 07:04:27 -08003281 // Default step down is 3/5 pixel count, so go up by 5/3.
Oskar Sundbom78807582017-11-16 11:09:55 +01003282 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003283 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003284 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003285 EXPECT_EQ(5, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003286 EXPECT_EQ(1284 * 3 / 4, send_stream->GetLastWidth());
3287 EXPECT_EQ(724 * 3 / 4, send_stream->GetLastHeight());
3288
sprang84a37592017-02-10 07:04:27 -08003289 // Trigger underuse again, should go back up to full resolution.
3290 current_pixel_count =
3291 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003292 wants.max_pixel_count = current_pixel_count * 4;
Oskar Sundbom78807582017-11-16 11:09:55 +01003293 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003294 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003295 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003296 EXPECT_EQ(6, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003297 EXPECT_EQ(1284, send_stream->GetLastWidth());
3298 EXPECT_EQ(724, send_stream->GetLastHeight());
3299
Niels Möllerff40b142018-04-09 08:49:14 +02003300 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003301}
3302
eladalonf1841382017-06-12 01:16:46 -07003303TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003304 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003305 cricket::VideoSendParameters parameters;
3306 parameters.codecs.push_back(codec);
3307
kthelgason2bc68642017-02-07 07:02:22 -08003308 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003309 media_config.video.enable_cpu_adaptation = true;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003310 channel_.reset(engine_.CreateChannel(
3311 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003312 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003313 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3314
3315 AddSendStream();
3316
Tommi85959932018-02-07 19:26:06 +01003317 FakeVideoCapturerWithTaskQueue capturer;
Per766ad3b2016-04-05 15:23:49 +02003318 ASSERT_EQ(cricket::CS_RUNNING,
3319 capturer.Start(capturer.GetSupportedFormats()->front()));
3320 ASSERT_TRUE(channel_->SetSend(true));
3321 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003322 camera_options.is_screencast = false;
Yves Gerey665174f2018-06-19 15:03:05 +02003323 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
Per766ad3b2016-04-05 15:23:49 +02003324
3325 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3326 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003327
Niels Möllera6cc0f92018-02-12 17:14:55 +01003328 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003329 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3330 EXPECT_EQ(1280, send_stream->GetLastWidth());
3331 EXPECT_EQ(720, send_stream->GetLastHeight());
3332
3333 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003334 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003335 wants.max_pixel_count =
3336 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003337 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003338 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003339 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3340 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3341 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3342
3343 // Switch to screen share. Expect no CPU adaptation.
Tommi85959932018-02-07 19:26:06 +01003344 FakeVideoCapturerWithTaskQueue screen_share(true);
Per766ad3b2016-04-05 15:23:49 +02003345 ASSERT_EQ(cricket::CS_RUNNING,
3346 screen_share.Start(screen_share.GetSupportedFormats()->front()));
Per766ad3b2016-04-05 15:23:49 +02003347 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003348 screenshare_options.is_screencast = true;
Yves Gerey665174f2018-06-19 15:03:05 +02003349 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &screen_share);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003350 EXPECT_TRUE(screen_share.CaptureCustomFrame(1284, 724));
sprangf24a0642017-02-28 13:23:26 -08003351 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3352 send_stream = fake_call_->GetVideoSendStreams().front();
3353 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003354 EXPECT_EQ(1284, send_stream->GetLastWidth());
3355 EXPECT_EQ(724, send_stream->GetLastHeight());
3356
3357 // Switch back to the normal capturer. Expect the frame to be CPU adapted.
Yves Gerey665174f2018-06-19 15:03:05 +02003358 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
sprangf24a0642017-02-28 13:23:26 -08003359 send_stream = fake_call_->GetVideoSendStreams().front();
3360 // We have a new fake send stream, so it doesn't remember the old sink wants.
3361 // In practice, it will be populated from
mflodmancc3d4422017-08-03 08:27:51 -07003362 // VideoStreamEncoder::VideoSourceProxy::SetSource(), so simulate that here.
sprangf24a0642017-02-28 13:23:26 -08003363 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003364 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
sprangf24a0642017-02-28 13:23:26 -08003365 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3366 send_stream = fake_call_->GetVideoSendStreams().front();
3367 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003368 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3369 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3370
Niels Möllerff40b142018-04-09 08:49:14 +02003371 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003372}
3373
asapersson3c81a1a2017-06-14 05:52:21 -07003374// TODO(asapersson): Remove this test when the balanced field trial is removed.
3375void WebRtcVideoChannelTest::TestDegradationPreference(
3376 bool resolution_scaling_enabled,
3377 bool fps_scaling_enabled) {
3378 cricket::VideoCodec codec = GetEngineCodec("VP8");
3379 cricket::VideoSendParameters parameters;
3380 parameters.codecs.push_back(codec);
3381
3382 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003383 media_config.video.enable_cpu_adaptation = true;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003384 channel_.reset(engine_.CreateChannel(
3385 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
asapersson3c81a1a2017-06-14 05:52:21 -07003386 channel_->OnReadyToSend(true);
3387
3388 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3389
3390 AddSendStream();
3391
Tommi85959932018-02-07 19:26:06 +01003392 FakeVideoCapturerWithTaskQueue capturer;
asapersson3c81a1a2017-06-14 05:52:21 -07003393 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02003394 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
asapersson3c81a1a2017-06-14 05:52:21 -07003395 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
3396 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
3397
3398 EXPECT_TRUE(channel_->SetSend(true));
3399
3400 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3401 EXPECT_EQ(resolution_scaling_enabled,
3402 send_stream->resolution_scaling_enabled());
3403 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3404
Niels Möllerff40b142018-04-09 08:49:14 +02003405 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003406}
3407
eladalonf1841382017-06-12 01:16:46 -07003408void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3409 bool is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003410 const int kDefaultFps = 30;
magjed509e4fe2016-11-18 01:34:11 -08003411 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003412 cricket::VideoSendParameters parameters;
3413 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003414
kthelgason2bc68642017-02-07 07:02:22 -08003415 MediaConfig media_config = GetMediaConfig();
3416 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003417 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003418 }
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003419 channel_.reset(engine_.CreateChannel(
3420 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003421 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003422
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003423 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003424
3425 AddSendStream();
3426
Tommi85959932018-02-07 19:26:06 +01003427 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07003428 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003429 options.is_screencast = is_screenshare;
Niels Möllerff40b142018-04-09 08:49:14 +02003430 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj26752742016-10-24 01:21:16 -07003431 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
sprangc5d62e22017-04-02 23:53:04 -07003432 capture_format.interval = rtc::kNumNanosecsPerSec / kDefaultFps;
perkj26752742016-10-24 01:21:16 -07003433 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003434
3435 EXPECT_TRUE(channel_->SetSend(true));
3436
solenberge5269742015-09-08 05:13:22 -07003437 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003438
sprangc5d62e22017-04-02 23:53:04 -07003439 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003440 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003441 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3442 EXPECT_EQ(is_screenshare, send_stream->framerate_scaling_enabled());
perkj2d5f0912016-02-29 00:04:41 -08003443
3444 EXPECT_TRUE(capturer.CaptureFrame());
3445 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3446
perkj26752742016-10-24 01:21:16 -07003447 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3448 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
perkj2d5f0912016-02-29 00:04:41 -08003449
Niels Möllerff40b142018-04-09 08:49:14 +02003450 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003451 return;
3452 }
3453
sprangc5d62e22017-04-02 23:53:04 -07003454 if (is_screenshare) {
3455 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3456 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3457 } else {
3458 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3459 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3460 }
3461
perkj803d97f2016-11-01 11:45:46 -07003462 // Trigger overuse.
3463 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3464
3465 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003466 if (is_screenshare) {
3467 wants.max_framerate_fps = (kDefaultFps * 2) / 3;
3468 } else {
3469 wants.max_pixel_count = capture_format.width * capture_format.height - 1;
3470 }
perkj803d97f2016-11-01 11:45:46 -07003471 send_stream->InjectVideoSinkWants(wants);
3472
sprangc5d62e22017-04-02 23:53:04 -07003473 for (int i = 0; i < kDefaultFps; ++i)
3474 EXPECT_TRUE(capturer.CaptureFrame());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003475
sprangc5d62e22017-04-02 23:53:04 -07003476 if (is_screenshare) {
3477 // Drops every third frame.
3478 EXPECT_EQ(kDefaultFps * 2 / 3, send_stream->GetNumberOfSwappedFrames());
3479 EXPECT_EQ(send_stream->GetLastWidth(), capture_format.width);
3480 EXPECT_EQ(send_stream->GetLastHeight(), capture_format.height);
3481 } else {
3482 EXPECT_EQ(kDefaultFps, send_stream->GetNumberOfSwappedFrames());
3483 EXPECT_LT(send_stream->GetLastWidth(), capture_format.width);
3484 EXPECT_LT(send_stream->GetLastHeight(), capture_format.height);
3485 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003486
3487 // Trigger underuse which should go back to normal resolution.
sprang84a37592017-02-10 07:04:27 -08003488 int last_pixel_count =
3489 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003490 if (is_screenshare) {
3491 wants.max_framerate_fps = kDefaultFps;
3492 } else {
3493 wants.max_pixel_count = last_pixel_count * 4;
3494 wants.target_pixel_count.emplace((last_pixel_count * 5) / 3);
3495 }
perkj803d97f2016-11-01 11:45:46 -07003496 send_stream->InjectVideoSinkWants(wants);
3497
sprangc5d62e22017-04-02 23:53:04 -07003498 for (int i = 0; i < kDefaultFps; ++i)
3499 EXPECT_TRUE(capturer.CaptureFrame());
3500
3501 if (is_screenshare) {
3502 EXPECT_EQ(kDefaultFps + (kDefaultFps * 2 / 3),
3503 send_stream->GetNumberOfSwappedFrames());
3504 } else {
3505 EXPECT_EQ(kDefaultFps * 2, send_stream->GetNumberOfSwappedFrames());
3506 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003507
perkj26752742016-10-24 01:21:16 -07003508 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3509 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003510
Niels Möllerff40b142018-04-09 08:49:14 +02003511 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003512}
3513
eladalonf1841382017-06-12 01:16:46 -07003514TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003515 // Start at last timestamp to verify that wraparounds are estimated correctly.
3516 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3517 static const int64_t kInitialNtpTimeMs = 1247891230;
3518 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003519 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003520
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003521 FakeVideoReceiveStream* stream = AddRecvStream();
3522 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003523 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003524
nisse64ec8f82016-09-27 00:17:25 -07003525 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4),
3526 kInitialTimestamp, 0,
3527 webrtc::kVideoRotation_0);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003528 // Initial NTP time is not available on the first frame, but should still be
3529 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003530 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003531
3532 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003533
3534 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3535 // triggers a constant-overflow warning, hence we're calculating it explicitly
3536 // here.
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +02003537 fake_clock_.AdvanceTimeMicros(kFrameOffsetMs * rtc::kNumMicrosecsPerMillisec);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003538 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3539 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003540 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003541
3542 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003543
3544 // Verify that NTP time has been correctly deduced.
3545 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003546 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003547 ASSERT_EQ(1u, info.receivers.size());
3548 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003549}
3550
eladalonf1841382017-06-12 01:16:46 -07003551TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003552 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003553 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003554
3555 VideoCodec codec;
3556 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003557 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003558
3559 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003560 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3561 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003562 FakeVideoSendStream* stream = AddSendStream(
3563 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003564 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003565
3566 // Make sure NACK and FEC are enabled on the correct payload types.
3567 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003568 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3569 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003570
3571 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3572 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003573 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003574 // TODO(juberti): Check RTCP, PLI, TMMBR.
3575}
3576
brandtr31bd2242017-05-19 05:47:46 -07003577// The following four tests ensures that FlexFEC is not activated by default
3578// when the field trials are not enabled.
3579// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3580// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003581TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003582 FakeVideoSendStream* stream = AddSendStream();
3583 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3584
brandtr3d200bd2017-01-16 06:59:19 -08003585 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003586 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3587 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003588}
3589
eladalonf1841382017-06-12 01:16:46 -07003590TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003591 FakeVideoSendStream* stream = AddSendStream(
3592 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3593 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3594
brandtr3d200bd2017-01-16 06:59:19 -08003595 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003596 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3597 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3598}
3599
Yves Gerey665174f2018-06-19 15:03:05 +02003600TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003601 AddRecvStream();
3602
3603 const std::vector<FakeFlexfecReceiveStream*>& streams =
3604 fake_call_->GetFlexfecReceiveStreams();
3605 EXPECT_TRUE(streams.empty());
3606}
3607
eladalonf1841382017-06-12 01:16:46 -07003608TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003609 AddRecvStream(
3610 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3611
3612 const std::vector<FakeFlexfecReceiveStream*>& streams =
3613 fake_call_->GetFlexfecReceiveStreams();
3614 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003615}
3616
3617// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3618// tests that use this test fixture into the corresponding "non-field trial"
3619// tests.
eladalonf1841382017-06-12 01:16:46 -07003620class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003621 public:
eladalonf1841382017-06-12 01:16:46 -07003622 WebRtcVideoChannelFlexfecRecvTest()
3623 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003624};
3625
eladalonf1841382017-06-12 01:16:46 -07003626TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003627 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3628 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3629 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3630}
3631
eladalonf1841382017-06-12 01:16:46 -07003632TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003633 AddRecvStream();
3634
3635 const std::vector<FakeFlexfecReceiveStream*>& streams =
3636 fake_call_->GetFlexfecReceiveStreams();
3637 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003638
3639 const std::vector<FakeVideoReceiveStream*>& video_streams =
3640 fake_call_->GetVideoReceiveStreams();
3641 ASSERT_EQ(1U, video_streams.size());
3642 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3643 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3644 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003645}
3646
eladalonf1841382017-06-12 01:16:46 -07003647TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003648 AddRecvStream(
3649 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3650
3651 const std::vector<FakeFlexfecReceiveStream*>& streams =
3652 fake_call_->GetFlexfecReceiveStreams();
3653 ASSERT_EQ(1U, streams.size());
3654 const FakeFlexfecReceiveStream* stream = streams.front();
3655 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3656 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3657 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3658 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3659 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003660
3661 const std::vector<FakeVideoReceiveStream*>& video_streams =
3662 fake_call_->GetVideoReceiveStreams();
3663 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003664 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3665 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003666 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003667 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003668 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003669}
3670
eladalonf1841382017-06-12 01:16:46 -07003671TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003672 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3673 cricket::VideoRecvParameters recv_parameters;
3674 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3675 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3676
3677 AddRecvStream(
3678 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3679 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003680 const std::vector<FakeVideoReceiveStream*>& video_streams =
3681 fake_call_->GetVideoReceiveStreams();
3682 ASSERT_EQ(1U, video_streams.size());
3683 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3684 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3685 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003686
3687 // Enable FlexFEC.
3688 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3689 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3690 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3691 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3692 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3693 << "Enabling FlexFEC should not create VideoReceiveStream.";
3694 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3695 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003696 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3697 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003698}
3699
eladalonf1841382017-06-12 01:16:46 -07003700TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003701 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3702 cricket::VideoRecvParameters recv_parameters;
3703 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3704 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3705 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3706
3707 AddRecvStream(
3708 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3709 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003710 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003711 const std::vector<FakeVideoReceiveStream*>& video_streams =
3712 fake_call_->GetVideoReceiveStreams();
3713 ASSERT_EQ(1U, video_streams.size());
3714 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3715 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3716 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003717
3718 // Disable FlexFEC.
3719 recv_parameters.codecs.clear();
3720 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3721 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3722 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3723 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3724 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3725 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3726 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3727 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003728 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3729 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003730}
3731
brandtr31bd2242017-05-19 05:47:46 -07003732// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3733// tests that use this test fixture into the corresponding "non-field trial"
3734// tests.
eladalonf1841382017-06-12 01:16:46 -07003735class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003736 public:
eladalonf1841382017-06-12 01:16:46 -07003737 WebRtcVideoChannelFlexfecSendRecvTest()
3738 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003739 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3740 }
3741};
3742
Yves Gerey665174f2018-06-19 15:03:05 +02003743TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003744 FakeVideoSendStream* stream = AddSendStream();
3745 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3746
brandtr3d200bd2017-01-16 06:59:19 -08003747 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3748 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3749 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003750}
3751
eladalonf1841382017-06-12 01:16:46 -07003752TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003753 FakeVideoSendStream* stream = AddSendStream(
3754 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3755 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3756
brandtr3d200bd2017-01-16 06:59:19 -08003757 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3758 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3759 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3760 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003761}
3762
eladalonf1841382017-06-12 01:16:46 -07003763TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003764 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003765 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003766 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003767
3768 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003769 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003770
brandtrb5f2c3f2016-10-04 23:28:39 -07003771 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3772 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003773}
3774
eladalonf1841382017-06-12 01:16:46 -07003775TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003776 cricket::VideoSendParameters parameters;
3777 parameters.codecs.push_back(GetEngineCodec("VP8"));
3778 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3779
3780 FakeVideoSendStream* stream = AddSendStream();
3781 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3782
brandtr3d200bd2017-01-16 06:59:19 -08003783 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003784}
3785
eladalonf1841382017-06-12 01:16:46 -07003786TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003787 AddRecvStream(
3788 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003789
3790 cricket::VideoRecvParameters recv_parameters;
3791 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3792 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3793 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003794
3795 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3796 fake_call_->GetFlexfecReceiveStreams();
3797 ASSERT_EQ(1U, flexfec_streams.size());
3798 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3799 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3800 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003801 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003802 flexfec_stream_config.payload_type);
3803 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3804 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3805 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3806 const std::vector<FakeVideoReceiveStream*>& video_streams =
3807 fake_call_->GetVideoReceiveStreams();
3808 const FakeVideoReceiveStream* video_stream = video_streams.front();
3809 const webrtc::VideoReceiveStream::Config& video_stream_config =
3810 video_stream->GetConfig();
3811 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3812 flexfec_stream_config.local_ssrc);
3813 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3814 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3815 flexfec_stream_config.rtcp_send_transport);
3816 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3817 // spec-compliant way.
3818 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3819 flexfec_stream_config.transport_cc);
3820 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3821 EXPECT_EQ(video_stream_config.rtp.extensions,
3822 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003823}
3824
brandtr31bd2242017-05-19 05:47:46 -07003825// We should not send FlexFEC, even if we advertise it, unless the right
3826// field trial is set.
3827// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003828TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003829 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3830 cricket::VideoSendParameters parameters;
3831 parameters.codecs.push_back(GetEngineCodec("VP8"));
3832 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3833 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3834
3835 FakeVideoSendStream* stream = AddSendStream();
3836 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3837
3838 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003839 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003840 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3841}
3842
eladalonf1841382017-06-12 01:16:46 -07003843TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003844 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3845 cricket::VideoSendParameters parameters;
3846 parameters.codecs.push_back(GetEngineCodec("VP8"));
3847 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3848 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3849
3850 FakeVideoSendStream* stream = AddSendStream(
3851 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3852 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3853
3854 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003855 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003856 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3857}
3858
eladalonf1841382017-06-12 01:16:46 -07003859TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003860 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003861 const int kUnusedPayloadType = 127;
3862 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3863
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003864 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003865 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003866 parameters.codecs.push_back(rtx_codec);
3867 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003868 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003869}
3870
eladalonf1841382017-06-12 01:16:46 -07003871TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003872 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003873 const int kUnusedPayloadType1 = 126;
3874 const int kUnusedPayloadType2 = 127;
3875 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3876 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3877 {
3878 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3879 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3880 cricket::VideoSendParameters parameters;
3881 parameters.codecs.push_back(GetEngineCodec("VP8"));
3882 parameters.codecs.push_back(rtx_codec);
3883 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3884 }
3885 {
3886 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3887 kUnusedPayloadType1, kUnusedPayloadType2);
3888 cricket::VideoSendParameters parameters;
3889 parameters.codecs.push_back(GetEngineCodec("VP8"));
3890 parameters.codecs.push_back(rtx_codec);
3891 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3892 << "RTX without matching video codec should be rejected.";
3893 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003894}
3895
eladalonf1841382017-06-12 01:16:46 -07003896TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003897 const int kUnusedPayloadType1 = 126;
3898 const int kUnusedPayloadType2 = 127;
3899 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3900 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3901
3902 // SSRCs for RTX.
3903 cricket::StreamParams params =
3904 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3905 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3906 AddSendStream(params);
3907
3908 // Original payload type for RTX.
3909 cricket::VideoSendParameters parameters;
3910 parameters.codecs.push_back(GetEngineCodec("VP8"));
3911 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3912 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3913 parameters.codecs.push_back(rtx_codec);
3914 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3915 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3916 const webrtc::VideoSendStream::Config& config_before =
3917 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3918 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3919 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3920 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3921
3922 // Change payload type for RTX.
3923 parameters.codecs[1].id = kUnusedPayloadType2;
3924 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3925 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3926 const webrtc::VideoSendStream::Config& config_after =
3927 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3928 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3929 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3930 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3931}
3932
eladalonf1841382017-06-12 01:16:46 -07003933TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003934 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003935 parameters.codecs.push_back(GetEngineCodec("VP8"));
3936 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003937 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003938
3939 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003940 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003941
magjed509e4fe2016-11-18 01:34:11 -08003942 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003943
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003944 parameters.codecs.pop_back();
3945 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003946 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003947 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003948 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003949 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003950 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3951}
3952
eladalonf1841382017-06-12 01:16:46 -07003953TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003954 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003955 cricket::VideoSendParameters parameters;
3956 parameters.codecs.push_back(GetEngineCodec("VP8"));
3957 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3958 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3959
3960 FakeVideoSendStream* stream = AddSendStream(
3961 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3962 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3963
brandtr3d200bd2017-01-16 06:59:19 -08003964 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3965 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003966 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3967 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
3968
3969 parameters.codecs.pop_back();
3970 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3971 stream = fake_call_->GetVideoSendStreams()[0];
3972 ASSERT_TRUE(stream != nullptr);
3973 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08003974 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003975 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003976}
3977
eladalonf1841382017-06-12 01:16:46 -07003978TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003979 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07003980 cricket::VideoCodec codec(100, "VP8");
3981 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
3982 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07003983
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003984 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003985 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003986
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003987 FakeVideoSendStream* stream = AddSendStream();
Tommi85959932018-02-07 19:26:06 +01003988 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003989 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003990
3991 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003992 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003993
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003994 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07003995 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
3996 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003997 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003998 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003999 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02004000 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004001}
4002
eladalonf1841382017-06-12 01:16:46 -07004003TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004004 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4005 200000);
4006}
4007
eladalonf1841382017-06-12 01:16:46 -07004008TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00004009 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
4010 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
4011 ASSERT_EQ(1u, streams.size());
4012 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
4013}
4014
eladalonf1841382017-06-12 01:16:46 -07004015TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00004016 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004017 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00004018}
4019
eladalonf1841382017-06-12 01:16:46 -07004020TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004021 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004022}
4023
eladalonf1841382017-06-12 01:16:46 -07004024TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004025 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
4026 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
4027 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004028}
4029
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004030// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4031// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07004032TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004033 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4034 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4035 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4036 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004037 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004038 ExpectSetBitrateParameters(100000, 200000, 400000);
4039 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4040 // Since the codec isn't changing, start_bitrate_bps should be -1.
4041 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004042
4043 // Decrease max_bandwidth_bps.
4044 send_parameters_.max_bandwidth_bps = 350000;
4045 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004046
4047 // Now try again with the values flipped around.
4048 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4049 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004050 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004051 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004052
4053 // If we change the codec max, max_bandwidth_bps should still apply.
4054 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004055 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004056 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004057}
4058
Yves Gerey665174f2018-06-19 15:03:05 +02004059TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004060 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4061 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004062 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004063 // Setting max bitrate should keep previous min bitrate.
4064 // Setting max bitrate should not reset start bitrate.
4065 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004066 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004067}
4068
eladalonf1841382017-06-12 01:16:46 -07004069TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004070 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004071 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004072 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004073 // -1 means to disable max bitrate (set infinite).
4074 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004075 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004076 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004077}
4078
eladalonf1841382017-06-12 01:16:46 -07004079TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004080 send_parameters_.max_bandwidth_bps = 99999;
4081 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004082 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004083 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004084 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4085 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4086 stream->GetVideoStreams()[0].max_bitrate_bps);
4087
4088 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004089 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004090 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4091 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004092 stream->GetVideoStreams()[0].max_bitrate_bps);
4093}
4094
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004095// Tests that when the codec specific max bitrate and VideoSendParameters
4096// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4097// appropriately.
4098TEST_F(WebRtcVideoChannelTest,
4099 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4100 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4101 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4102 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4103 send_parameters_.max_bandwidth_bps = -1;
4104 AddSendStream();
4105 ExpectSetMaxBitrate(300000);
4106 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4107
4108 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4109 ASSERT_EQ(1u, video_send_streams.size());
4110 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4111 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4112 // First the max bitrate is set based upon the codec param.
4113 EXPECT_EQ(300000,
4114 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4115
4116 // The VideoSendParameters max bitrate overrides the codec's.
4117 send_parameters_.max_bandwidth_bps = 500000;
4118 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4119 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4120 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4121 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4122}
4123
4124// Tests that when the codec specific max bitrate and RtpParameters
4125// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4126// appropriately.
4127TEST_F(WebRtcVideoChannelTest,
4128 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4129 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4130 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4131 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4132 send_parameters_.max_bandwidth_bps = -1;
4133 AddSendStream();
4134 ExpectSetMaxBitrate(300000);
4135 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4136
4137 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4138 ASSERT_EQ(1u, video_send_streams.size());
4139 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4140 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4141 // First the max bitrate is set based upon the codec param.
4142 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4143
4144 // The RtpParameter max bitrate overrides the codec's.
4145 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4146 ASSERT_EQ(1u, parameters.encodings.size());
4147 parameters.encodings[0].max_bitrate_bps = 500000;
4148 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4149 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4150 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4151 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4152}
4153
Åsa Persson55659812018-06-18 17:51:32 +02004154TEST_F(WebRtcVideoChannelTest,
4155 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4156 send_parameters_.max_bandwidth_bps = 99999;
4157 FakeVideoSendStream* stream = AddSendStream();
4158 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4159 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4160 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4161 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4162 stream->GetVideoStreams()[0].max_bitrate_bps);
4163
4164 // Get and set the rtp encoding parameters.
4165 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4166 EXPECT_EQ(1u, parameters.encodings.size());
4167
4168 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4169 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4170 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4171 stream->GetVideoStreams()[0].max_bitrate_bps);
4172
4173 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4174 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4175 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4176 stream->GetVideoStreams()[0].max_bitrate_bps);
4177}
4178
eladalonf1841382017-06-12 01:16:46 -07004179TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004180 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004181 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004182 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004183 channel_->SetSend(true);
4184
4185 FakeVideoSendStream* stream = AddSendStream();
4186
Tommi85959932018-02-07 19:26:06 +01004187 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004188 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Peter Boström3afc8c42016-01-27 16:45:21 +01004189 EXPECT_EQ(cricket::CS_RUNNING,
4190 capturer.Start(capturer.GetSupportedFormats()->front()));
4191
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004192 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4193 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4194 EXPECT_GT(initial_max_bitrate_bps, 0);
4195
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004196 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4197 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004198 // Insert a frame to update the encoder config.
4199 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004200 streams = stream->GetVideoStreams();
4201 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004202 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004203}
4204
eladalonf1841382017-06-12 01:16:46 -07004205TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004206 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004207 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004208 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004209 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004210 channel_->SetSend(true);
4211
4212 FakeVideoSendStream* stream = AddSendStream(
4213 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4214
4215 // Send a frame to make sure this scales up to >1 stream (simulcast).
Tommi85959932018-02-07 19:26:06 +01004216 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004217 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &capturer));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004218 EXPECT_EQ(cricket::CS_RUNNING,
4219 capturer.Start(capturer.GetSupportedFormats()->front()));
4220 EXPECT_TRUE(capturer.CaptureFrame());
4221
4222 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4223 ASSERT_GT(streams.size(), 1u)
4224 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004225 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004226 EXPECT_GT(initial_max_bitrate_bps, 0);
4227
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004228 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4229 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004230 // Insert a frame to update the encoder config.
4231 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004232 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004233 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004234 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4235
Niels Möllerff40b142018-04-09 08:49:14 +02004236 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004237}
4238
eladalonf1841382017-06-12 01:16:46 -07004239TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004240 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004241 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004242 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004243 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4244 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004245 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004246 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004247
4248 VideoCodec codec;
4249 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4250 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4251}
4252
eladalonf1841382017-06-12 01:16:46 -07004253TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004254 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004255 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004256 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004257 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004258 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004259 parameters.codecs[0].id = kIncorrectPayloads[i];
4260 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004261 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004262 }
4263}
4264
eladalonf1841382017-06-12 01:16:46 -07004265TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004266 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004267 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004268 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004269 parameters.codecs[0].id = payload_type;
4270 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004271 << "Payload type '" << payload_type << "' rejected.";
4272 }
4273}
4274
deadbeef67cf2c12016-04-13 10:07:16 -07004275// Test that setting the a different set of codecs but with an identical front
4276// codec doesn't result in the stream being recreated.
4277// This may happen when a subsequent negotiation includes fewer codecs, as a
4278// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004279TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004280 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4281 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004282 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4283 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004284 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4285
4286 AddSendStream();
4287 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4288
4289 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004290 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004291 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4292 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4293}
4294
eladalonf1841382017-06-12 01:16:46 -07004295TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004296 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004297 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004298 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004299}
4300
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004301// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004302TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004303 const int kUnusedPayloadType1 = 126;
4304 const int kUnusedPayloadType2 = 127;
4305 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4306 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4307
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004308 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004309 parameters.codecs.push_back(GetEngineCodec("VP8"));
4310 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004311 parameters.codecs.push_back(rtx_codec);
4312 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004313 << "RTX codec without associated payload should be rejected.";
4314
magjed509e4fe2016-11-18 01:34:11 -08004315 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004316 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004317 << "RTX codec with invalid associated payload type should be rejected.";
4318
magjed509e4fe2016-11-18 01:34:11 -08004319 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004320 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004321
magjed509e4fe2016-11-18 01:34:11 -08004322 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004323 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004324 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004325
Yves Gerey665174f2018-06-19 15:03:05 +02004326 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4327 << "RTX codec with another RTX as associated payload type should be "
4328 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004329}
4330
eladalonf1841382017-06-12 01:16:46 -07004331TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004332 const int kUnusedPayloadType1 = 126;
4333 const int kUnusedPayloadType2 = 127;
4334 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4335 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4336
4337 // SSRCs for RTX.
4338 cricket::StreamParams params =
4339 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4340 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4341 AddRecvStream(params);
4342
4343 // Original payload type for RTX.
4344 cricket::VideoRecvParameters parameters;
4345 parameters.codecs.push_back(GetEngineCodec("VP8"));
4346 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4347 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4348 parameters.codecs.push_back(rtx_codec);
4349 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4350 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4351 const webrtc::VideoReceiveStream::Config& config_before =
4352 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004353 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4354 const int* payload_type_before = FindKeyByValue(
4355 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4356 ASSERT_NE(payload_type_before, nullptr);
4357 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004358 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4359
4360 // Change payload type for RTX.
4361 parameters.codecs[1].id = kUnusedPayloadType2;
4362 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4363 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4364 const webrtc::VideoReceiveStream::Config& config_after =
4365 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004366 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4367 const int* payload_type_after = FindKeyByValue(
4368 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4369 ASSERT_NE(payload_type_after, nullptr);
4370 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004371 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4372}
4373
eladalonf1841382017-06-12 01:16:46 -07004374TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004375 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004376 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004377 parameters.codecs[0].id = 99;
4378 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004379}
4380
eladalonf1841382017-06-12 01:16:46 -07004381TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004382 cricket::VideoRecvParameters parameters;
4383 parameters.codecs = engine_.codecs();
4384 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004385
4386 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004387 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004388 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004389 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004390}
4391
eladalonf1841382017-06-12 01:16:46 -07004392TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004393 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004394 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004395 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004396 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004397}
4398
eladalonf1841382017-06-12 01:16:46 -07004399TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004400 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004401 parameters.codecs.push_back(GetEngineCodec("VP8"));
4402 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004403 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004404}
4405
eladalonf1841382017-06-12 01:16:46 -07004406TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004407 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004408 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4409 send_parameters.codecs.push_back(GetEngineCodec("red"));
4410 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004411 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004412
4413 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004414
magjed509e4fe2016-11-18 01:34:11 -08004415 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004416 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004417
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004418 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004419 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004420 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004421 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004422 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004423 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004424 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4425}
4426
eladalonf1841382017-06-12 01:16:46 -07004427TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004428 AddRecvStream(
4429 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004430 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004431 fake_call_->GetFlexfecReceiveStreams();
4432
4433 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004434 const FakeFlexfecReceiveStream* stream = streams.front();
4435 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4436 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4437 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4438 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004439
4440 cricket::VideoRecvParameters recv_parameters;
4441 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4442 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4443 EXPECT_TRUE(streams.empty())
4444 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004445}
4446
eladalonf1841382017-06-12 01:16:46 -07004447TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004448 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004449 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004450 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004451
4452 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004453 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4454 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4455 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004456 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4457 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004458 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004459 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004460 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004461 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004462
4463 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004464 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4465 send_parameters.codecs.push_back(GetEngineCodec("red"));
4466 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004467 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4468 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004469 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004470 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004471 << "ULPFEC should be enabled on the receive stream.";
4472}
4473
eladalonf1841382017-06-12 01:16:46 -07004474TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004475 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004476 AddRecvStream(
4477 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004478 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004479 fake_call_->GetFlexfecReceiveStreams();
4480
4481 cricket::VideoRecvParameters recv_parameters;
4482 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4483 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4484 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4485 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004486 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004487 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004488 stream_with_recv_params->GetConfig().payload_type);
4489 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004490 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004491 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004492 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004493 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004494
4495 cricket::VideoSendParameters send_parameters;
4496 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4497 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4498 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4499 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004500 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004501 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004502 stream_with_send_params->GetConfig().payload_type);
4503 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004504 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004505 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004506 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004507 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004508}
4509
eladalonf1841382017-06-12 01:16:46 -07004510TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004511 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004512 parameters.codecs.push_back(GetEngineCodec("VP8"));
4513 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004514 parameters.codecs[1].id = parameters.codecs[0].id;
4515 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004516}
4517
eladalonf1841382017-06-12 01:16:46 -07004518TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004519 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004520 cricket::VideoRecvParameters parameters;
4521 parameters.codecs.push_back(GetEngineCodec("VP8"));
4522 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4523 parameters.codecs[1].id = parameters.codecs[0].id;
4524 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4525}
4526
eladalonf1841382017-06-12 01:16:46 -07004527TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004528 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004529 parameters.codecs.push_back(GetEngineCodec("VP8"));
4530 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004531 parameters.codecs[1].id = parameters.codecs[0].id;
4532 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004533}
4534
eladalonf1841382017-06-12 01:16:46 -07004535TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004536 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004537 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004538 parameters.codecs.push_back(GetEngineCodec("VP8"));
4539 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004540 parameters.codecs[1].id += 1;
4541 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004542}
4543
deadbeef67cf2c12016-04-13 10:07:16 -07004544// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004545// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004546TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004547 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004548 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004549 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4550 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004551 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004552
4553 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4554 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4555
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004556 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004557 parameters2.codecs.push_back(GetEngineCodec("red"));
4558 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004559 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004560 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4561}
4562
eladalonf1841382017-06-12 01:16:46 -07004563TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004564 EXPECT_FALSE(AddSendStream()->IsSending());
4565}
4566
eladalonf1841382017-06-12 01:16:46 -07004567TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004568 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004569}
4570
eladalonf1841382017-06-12 01:16:46 -07004571TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004572 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004573 EXPECT_FALSE(stream->IsSending());
4574
4575 // false->true
4576 EXPECT_TRUE(channel_->SetSend(true));
4577 EXPECT_TRUE(stream->IsSending());
4578 // true->true
4579 EXPECT_TRUE(channel_->SetSend(true));
4580 EXPECT_TRUE(stream->IsSending());
4581 // true->false
4582 EXPECT_TRUE(channel_->SetSend(false));
4583 EXPECT_FALSE(stream->IsSending());
4584 // false->false
4585 EXPECT_TRUE(channel_->SetSend(false));
4586 EXPECT_FALSE(stream->IsSending());
4587
4588 EXPECT_TRUE(channel_->SetSend(true));
4589 FakeVideoSendStream* new_stream = AddSendStream();
4590 EXPECT_TRUE(new_stream->IsSending())
4591 << "Send stream created after SetSend(true) not sending initially.";
4592}
4593
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004594// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004595TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004596 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004597 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004598 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004599 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004600 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004601
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07004602 channel.reset(static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateChannel(
4603 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004604 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004605 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004606 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004607
Tim Haloun648d28a2018-10-18 16:52:22 -07004608 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4609 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004610 config.enable_dscp = true;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07004611 channel.reset(static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateChannel(
4612 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004613 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
Tim Haloun648d28a2018-10-18 16:52:22 -07004614 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4615
4616 // Create a send stream to configure
4617 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4618 parameters = channel->GetRtpSendParameters(kSsrc);
4619 ASSERT_FALSE(parameters.encodings.empty());
4620
4621 // Various priorities map to various dscp values.
4622 parameters.encodings[0].network_priority = 4.0;
4623 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004624 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004625 parameters.encodings[0].network_priority = 0.5;
4626 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4627 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4628
4629 // A bad priority does not change the dscp value.
4630 parameters.encodings[0].network_priority = 0.0;
4631 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4632 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004633
Tim Haloun6ca98362018-09-17 17:06:08 -07004634 // Packets should also self-identify their dscp in PacketOptions.
4635 const uint8_t kData[10] = {0};
4636 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4637 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004638 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004639
nisse51542be2016-02-12 02:27:06 -08004640 // Verify that setting the option to false resets the
4641 // DiffServCodePoint.
4642 config.enable_dscp = false;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07004643 channel.reset(static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateChannel(
4644 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004645 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004646 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004647}
4648
deadbeef13871492015-12-09 12:37:51 -08004649// This test verifies that the RTCP reduced size mode is properly applied to
4650// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004651TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004652 // Create stream, expecting that default mode is "compound".
4653 FakeVideoSendStream* stream1 = AddSendStream();
4654 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004655 webrtc::RtpParameters rtp_parameters =
4656 channel_->GetRtpSendParameters(last_ssrc_);
4657 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004658
4659 // Now enable reduced size mode.
4660 send_parameters_.rtcp.reduced_size = true;
4661 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4662 stream1 = fake_call_->GetVideoSendStreams()[0];
4663 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004664 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4665 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004666
4667 // Create a new stream and ensure it picks up the reduced size mode.
4668 FakeVideoSendStream* stream2 = AddSendStream();
4669 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4670}
4671
4672// This test verifies that the RTCP reduced size mode is properly applied to
4673// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004674TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004675 // Create stream, expecting that default mode is "compound".
4676 FakeVideoReceiveStream* stream1 = AddRecvStream();
4677 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4678
4679 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004680 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4681 // the reduced_size flag should come from that.
4682 send_parameters_.rtcp.reduced_size = true;
4683 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004684 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4685 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4686
4687 // Create a new stream and ensure it picks up the reduced size mode.
4688 FakeVideoReceiveStream* stream2 = AddRecvStream();
4689 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4690}
4691
eladalonf1841382017-06-12 01:16:46 -07004692TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004693 EXPECT_EQ(webrtc::kNetworkUp,
4694 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4695 EXPECT_EQ(webrtc::kNetworkUp,
4696 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004697
4698 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004699 EXPECT_EQ(webrtc::kNetworkDown,
4700 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4701 EXPECT_EQ(webrtc::kNetworkUp,
4702 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004703
4704 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004705 EXPECT_EQ(webrtc::kNetworkUp,
4706 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4707 EXPECT_EQ(webrtc::kNetworkUp,
4708 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004709}
4710
eladalonf1841382017-06-12 01:16:46 -07004711TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004712 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004713 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004714 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004715
4716 AddSendStream();
4717
4718 cricket::VideoMediaInfo info;
4719 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004720 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004721}
4722
eladalonf1841382017-06-12 01:16:46 -07004723TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004724 FakeVideoSendStream* stream = AddSendStream();
4725 webrtc::VideoSendStream::Stats stats;
4726 stats.encoder_implementation_name = "encoder_implementation_name";
4727 stream->SetStats(stats);
4728
4729 cricket::VideoMediaInfo info;
4730 ASSERT_TRUE(channel_->GetStats(&info));
4731 EXPECT_EQ(stats.encoder_implementation_name,
4732 info.senders[0].encoder_implementation_name);
4733}
4734
eladalonf1841382017-06-12 01:16:46 -07004735TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004736 FakeVideoSendStream* stream = AddSendStream();
4737 webrtc::VideoSendStream::Stats stats;
4738 stats.avg_encode_time_ms = 13;
4739 stats.encode_usage_percent = 42;
4740 stream->SetStats(stats);
4741
4742 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004743 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004744 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4745 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4746}
4747
eladalonf1841382017-06-12 01:16:46 -07004748TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004749 FakeVideoSendStream* stream = AddSendStream();
4750 webrtc::VideoSendStream::Stats stats;
4751 stats.frames_encoded = 13;
4752 stream->SetStats(stats);
4753
4754 cricket::VideoMediaInfo info;
4755 ASSERT_TRUE(channel_->GetStats(&info));
4756 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4757}
4758
eladalonf1841382017-06-12 01:16:46 -07004759TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004760 FakeVideoSendStream* stream = AddSendStream();
4761 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004762 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004763 stream->SetStats(stats);
4764
4765 cricket::VideoMediaInfo info;
4766 ASSERT_TRUE(channel_->GetStats(&info));
4767 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4768}
4769
eladalonf1841382017-06-12 01:16:46 -07004770TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004771 FakeVideoSendStream* stream = AddSendStream();
4772 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004773 stats.substreams[17].width = 123;
4774 stats.substreams[17].height = 40;
4775 stats.substreams[42].width = 80;
4776 stats.substreams[42].height = 31;
4777 stats.substreams[11].width = 20;
4778 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004779 stream->SetStats(stats);
4780
4781 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004782 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004783 ASSERT_EQ(1u, info.senders.size());
4784 EXPECT_EQ(123, info.senders[0].send_frame_width);
4785 EXPECT_EQ(90, info.senders[0].send_frame_height);
4786}
4787
eladalonf1841382017-06-12 01:16:46 -07004788TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004789 FakeVideoSendStream* stream = AddSendStream();
4790 webrtc::VideoSendStream::Stats stats;
4791 stats.number_of_cpu_adapt_changes = 2;
4792 stats.cpu_limited_resolution = true;
4793 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004794
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004795 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004796 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004797 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004798 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004799 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004800}
4801
eladalonf1841382017-06-12 01:16:46 -07004802TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004803 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004804 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004805 stats.number_of_cpu_adapt_changes = 2;
4806 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004807 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004808 stream->SetStats(stats);
4809
4810 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004811 EXPECT_TRUE(channel_->GetStats(&info));
4812 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004813 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4814 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004815 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004816 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004817}
4818
eladalonf1841382017-06-12 01:16:46 -07004819TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004820 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4821 FakeVideoSendStream* stream = AddSendStream();
4822 webrtc::VideoSendStream::Stats stats;
4823 stats.bw_limited_resolution = true;
4824 stream->SetStats(stats);
4825
4826 cricket::VideoMediaInfo info;
4827 EXPECT_TRUE(channel_->GetStats(&info));
4828 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004829 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004830 info.senders[0].adapt_reason);
4831}
4832
Yves Gerey665174f2018-06-19 15:03:05 +02004833TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004834 FakeVideoSendStream* stream = AddSendStream();
4835 webrtc::VideoSendStream::Stats stats;
4836 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4837 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4838 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4839
4840 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4841 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4842 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4843
4844 stream->SetStats(stats);
4845
4846 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004847 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004848 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4849 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4850 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4851}
4852
eladalonf1841382017-06-12 01:16:46 -07004853TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004854 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4855 FakeVideoReceiveStream* stream = AddRecvStream();
4856 webrtc::VideoReceiveStream::Stats stats;
4857 stats.rtcp_packet_type_counts.fir_packets = 2;
4858 stats.rtcp_packet_type_counts.nack_packets = 3;
4859 stats.rtcp_packet_type_counts.pli_packets = 4;
4860 stream->SetStats(stats);
4861
4862 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004863 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004864 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004865 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004866 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004867 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004868 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004869 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004870}
4871
eladalonf1841382017-06-12 01:16:46 -07004872TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004873 FakeVideoReceiveStream* stream = AddRecvStream();
4874 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004875 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004876 stats.decode_ms = 2;
4877 stats.max_decode_ms = 3;
4878 stats.current_delay_ms = 4;
4879 stats.target_delay_ms = 5;
4880 stats.jitter_buffer_ms = 6;
4881 stats.min_playout_delay_ms = 7;
4882 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07004883 stats.width = 9;
4884 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08004885 stats.frame_counts.key_frames = 11;
4886 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08004887 stats.frames_rendered = 13;
4888 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01004889 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004890 stream->SetStats(stats);
4891
4892 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004893 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01004894 EXPECT_EQ(stats.decoder_implementation_name,
4895 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004896 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
4897 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
4898 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
4899 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
4900 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
4901 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
4902 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07004903 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
4904 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004905 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
4906 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08004907 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08004908 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07004909 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08004910 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004911}
4912
eladalonf1841382017-06-12 01:16:46 -07004913TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02004914 FakeVideoReceiveStream* stream = AddRecvStream();
4915 webrtc::VideoReceiveStream::Stats stats;
4916 stats.rtp_stats.transmitted.payload_bytes = 2;
4917 stats.rtp_stats.transmitted.header_bytes = 3;
4918 stats.rtp_stats.transmitted.padding_bytes = 4;
4919 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07004920 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02004921 stats.rtcp_stats.fraction_lost = 7;
4922 stream->SetStats(stats);
4923
4924 cricket::VideoMediaInfo info;
4925 ASSERT_TRUE(channel_->GetStats(&info));
4926 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
4927 stats.rtp_stats.transmitted.header_bytes +
4928 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004929 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02004930 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004931 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07004932 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004933 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02004934 info.receivers[0].fraction_lost);
4935}
4936
eladalonf1841382017-06-12 01:16:46 -07004937TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004938 AddSendStream();
4939 AddSendStream();
4940 webrtc::Call::Stats stats;
4941 stats.rtt_ms = 123;
4942 fake_call_->SetStats(stats);
4943
4944 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004945 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004946 ASSERT_EQ(2u, info.senders.size());
4947 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
4948 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
4949}
4950
eladalonf1841382017-06-12 01:16:46 -07004951TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004952 FakeVideoSendStream* stream = AddSendStream();
4953 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004954 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004955 stats.media_bitrate_bps = 123;
4956 stats.substreams[17].total_bitrate_bps = 1;
4957 stats.substreams[17].retransmit_bitrate_bps = 2;
4958 stats.substreams[42].total_bitrate_bps = 3;
4959 stats.substreams[42].retransmit_bitrate_bps = 4;
4960 stream->SetStats(stats);
4961
4962 FakeVideoSendStream* stream2 = AddSendStream();
4963 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004964 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004965 stats2.media_bitrate_bps = 321;
4966 stats2.substreams[13].total_bitrate_bps = 5;
4967 stats2.substreams[13].retransmit_bitrate_bps = 6;
4968 stats2.substreams[21].total_bitrate_bps = 7;
4969 stats2.substreams[21].retransmit_bitrate_bps = 8;
4970 stream2->SetStats(stats2);
4971
4972 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004973 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004974 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07004975 BandwidthEstimationInfo bwe_info;
4976 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004977 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
4978 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
4979 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
4980 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004981 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004982 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004983 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004984 bwe_info.actual_enc_bitrate);
4985 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004986 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07004987 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004988 << "Bandwidth stats should take all streams into account.";
4989}
4990
eladalonf1841382017-06-12 01:16:46 -07004991TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004992 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004993
Peter Boström0c4e06b2015-10-07 12:23:21 +02004994 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4995 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004996
4997 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4998 const size_t kDataLength = 12;
4999 uint8_t data[kDataLength];
5000 memset(data, 0, sizeof(data));
5001 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07005002 rtc::CopyOnWriteBuffer packet(data, kDataLength);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005003 rtc::PacketTime packet_time;
5004 channel_->OnPacketReceived(&packet, packet_time);
5005
5006 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5007 << "No default receive stream created.";
5008 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08005009 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005010 << "Default receive stream should not have configured RTX";
5011
5012 EXPECT_TRUE(channel_->AddRecvStream(
5013 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
5014 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08005015 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005016 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07005017 EXPECT_FALSE(
5018 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07005019 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02005020 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07005021 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02005022 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07005023 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08005024 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005025}
5026
eladalonf1841382017-06-12 01:16:46 -07005027TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005028 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01005029
Peter Boström0c4e06b2015-10-07 12:23:21 +02005030 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5031 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01005032
5033 StreamParams sp =
5034 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5035 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
5036
5037 EXPECT_FALSE(channel_->AddSendStream(sp));
5038 EXPECT_FALSE(channel_->AddRecvStream(sp));
5039}
5040
eladalonf1841382017-06-12 01:16:46 -07005041TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005042 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005043
Peter Boström0c4e06b2015-10-07 12:23:21 +02005044 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5045 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005046
5047 StreamParams sp =
5048 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5049
5050 EXPECT_TRUE(channel_->AddSendStream(sp));
5051 EXPECT_TRUE(channel_->AddRecvStream(sp));
5052
5053 // The RTX SSRC is already used in previous streams, using it should fail.
5054 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5055 EXPECT_FALSE(channel_->AddSendStream(sp));
5056 EXPECT_FALSE(channel_->AddRecvStream(sp));
5057
5058 // After removing the original stream this should be fine to add (makes sure
5059 // that RTX ssrcs are not forever taken).
5060 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5061 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5062 EXPECT_TRUE(channel_->AddSendStream(sp));
5063 EXPECT_TRUE(channel_->AddRecvStream(sp));
5064}
5065
eladalonf1841382017-06-12 01:16:46 -07005066TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005067 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005068 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5069 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005070 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005071
Peter Boströmd6f4c252015-03-26 16:23:04 +01005072 StreamParams sp =
5073 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5074
5075 EXPECT_TRUE(channel_->AddSendStream(sp));
5076 EXPECT_TRUE(channel_->AddRecvStream(sp));
5077
5078 // One of the SSRCs is already used in previous streams, using it should fail.
5079 sp = cricket::CreateSimStreamParams("cname",
5080 MAKE_VECTOR(kOverlappingStreamSsrcs));
5081 EXPECT_FALSE(channel_->AddSendStream(sp));
5082 EXPECT_FALSE(channel_->AddRecvStream(sp));
5083
5084 // After removing the original stream this should be fine to add (makes sure
5085 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005086 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5087 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005088 EXPECT_TRUE(channel_->AddSendStream(sp));
5089 EXPECT_TRUE(channel_->AddRecvStream(sp));
5090}
5091
eladalonf1841382017-06-12 01:16:46 -07005092TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005093 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005094
5095 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5096 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5097
5098 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5099 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5100
5101 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5102
5103 static const uint32_t kReceiverSsrcs[] = {3};
5104 static const uint32_t kReceiverRtxSsrcs[] = {2};
5105
5106 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5107 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5108 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5109
5110 cricket::VideoMediaInfo info;
5111 ASSERT_TRUE(channel_->GetStats(&info));
5112
5113 ASSERT_EQ(1u, info.senders.size());
5114 ASSERT_EQ(1u, info.receivers.size());
5115
5116 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5117 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5118 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5119}
5120
eladalonf1841382017-06-12 01:16:46 -07005121TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005122 FakeVideoReceiveStream* stream = AddRecvStream();
5123 webrtc::VideoReceiveStream::Stats stats;
5124 cricket::VideoMediaInfo info;
5125
5126 // Report no codec name before receiving.
5127 stream->SetStats(stats);
5128 ASSERT_TRUE(channel_->GetStats(&info));
5129 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5130
5131 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005132 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005133 stream->SetStats(stats);
5134 ASSERT_TRUE(channel_->GetStats(&info));
5135 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5136
5137 // Report no codec name for unknown playload types.
5138 stats.current_payload_type = 3;
5139 stream->SetStats(stats);
5140 ASSERT_TRUE(channel_->GetStats(&info));
5141 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5142}
5143
Seth Hampson5897a6e2018-04-03 11:16:33 -07005144// Tests that when we add a stream without SSRCs, but contains a stream_id
5145// that it is stored and its stream id is later used when the first packet
5146// arrives to properly create a receive stream with a sync label.
5147TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5148 const char kSyncLabel[] = "sync_label";
5149 cricket::StreamParams unsignaled_stream;
5150 unsignaled_stream.set_stream_ids({kSyncLabel});
5151 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5152 // The stream shouldn't have been created at this point because it doesn't
5153 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005154 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005155
5156 // Create and deliver packet.
5157 const size_t kDataLength = 12;
5158 uint8_t data[kDataLength];
5159 memset(data, 0, sizeof(data));
5160 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5161 rtc::CopyOnWriteBuffer packet(data, kDataLength);
5162 rtc::PacketTime packet_time;
5163 channel_->OnPacketReceived(&packet, packet_time);
5164
5165 // The stream should now be created with the appropriate sync label.
5166 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5167 EXPECT_EQ(kSyncLabel,
5168 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5169
5170 // Removing the unsignaled stream should clear the cache. This time when
5171 // a default video receive stream is created it won't have a sync_group.
5172 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5173 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5174 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5175
5176 channel_->OnPacketReceived(&packet, packet_time);
5177 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5178 EXPECT_TRUE(
5179 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5180}
5181
eladalonf1841382017-06-12 01:16:46 -07005182void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005183 uint8_t payload_type,
5184 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005185 // kRedRtxPayloadType must currently be unused.
5186 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5187
noahricd10a68e2015-07-10 11:27:55 -07005188 // Add a RED RTX codec.
5189 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005190 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005191 recv_parameters_.codecs.push_back(red_rtx_codec);
5192 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005193
5194 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5195 const size_t kDataLength = 12;
5196 uint8_t data[kDataLength];
5197 memset(data, 0, sizeof(data));
5198
5199 rtc::Set8(data, 1, payload_type);
5200 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005201 rtc::CopyOnWriteBuffer packet(data, kDataLength);
noahricd10a68e2015-07-10 11:27:55 -07005202 rtc::PacketTime packet_time;
5203 channel_->OnPacketReceived(&packet, packet_time);
5204
5205 if (expect_created_receive_stream) {
5206 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5207 << "Should have created a receive stream for payload type: "
5208 << payload_type;
5209 } else {
5210 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5211 << "Shouldn't have created a receive stream for payload type: "
5212 << payload_type;
5213 }
5214}
5215
Åsa Persson2c7149b2018-10-15 09:36:10 +02005216class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5217 public:
5218 WebRtcVideoChannelDiscardUnknownSsrcTest()
5219 : WebRtcVideoChannelTest(
5220 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5221};
5222
5223TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5224 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5225 false /* expect_created_receive_stream */);
5226}
5227
eladalonf1841382017-06-12 01:16:46 -07005228TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005229 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5230 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005231}
5232
eladalonf1841382017-06-12 01:16:46 -07005233TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005234 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5235 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005236}
5237
eladalonf1841382017-06-12 01:16:46 -07005238TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005239 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005240 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5241 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5242 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5243 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005244}
5245
eladalonf1841382017-06-12 01:16:46 -07005246TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005247 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5248 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005249}
5250
eladalonf1841382017-06-12 01:16:46 -07005251TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005252 FlexfecPacketDoesntCreateUnsignalledStream) {
5253 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5254 false /* expect_created_receive_stream */);
5255}
5256
eladalonf1841382017-06-12 01:16:46 -07005257TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005258 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5259 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005260}
5261
mzanaty8a855d62017-02-17 15:46:43 -08005262// Test that receiving any unsignalled SSRC works even if it changes.
5263// The first unsignalled SSRC received will create a default receive stream.
5264// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005265TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005266 // Allow receiving VP8, VP9, H264 (if enabled).
5267 cricket::VideoRecvParameters parameters;
5268 parameters.codecs.push_back(GetEngineCodec("VP8"));
5269 parameters.codecs.push_back(GetEngineCodec("VP9"));
5270
5271#if defined(WEBRTC_USE_H264)
5272 cricket::VideoCodec H264codec(126, "H264");
5273 parameters.codecs.push_back(H264codec);
5274#endif
5275
5276 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5277 // No receive streams yet.
5278 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5279 cricket::FakeVideoRenderer renderer;
5280 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5281
5282 // Receive VP8 packet on first SSRC.
5283 uint8_t data[kMinRtpPacketLen];
5284 cricket::RtpHeader rtpHeader;
5285 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5286 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005287 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005288 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5289 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5290 rtc::PacketTime packet_time;
5291 channel_->OnPacketReceived(&packet, packet_time);
5292 // VP8 packet should create default receive stream.
5293 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005294 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005295 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5296 // Verify that the receive stream sinks to a renderer.
5297 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4), 100, 0,
5298 webrtc::kVideoRotation_0);
5299 recv_stream->InjectFrame(video_frame);
5300 EXPECT_EQ(1, renderer.num_rendered_frames());
5301
5302 // Receive VP9 packet on second SSRC.
5303 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005304 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005305 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5306 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
5307 channel_->OnPacketReceived(&packet2, packet_time);
5308 // VP9 packet should replace the default receive SSRC.
5309 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5310 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5311 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5312 // Verify that the receive stream sinks to a renderer.
5313 webrtc::VideoFrame video_frame2(CreateBlackFrameBuffer(4, 4), 200, 0,
ilnik00d802b2017-04-11 10:34:31 -07005314 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005315 recv_stream->InjectFrame(video_frame2);
5316 EXPECT_EQ(2, renderer.num_rendered_frames());
5317
5318#if defined(WEBRTC_USE_H264)
5319 // Receive H264 packet on third SSRC.
5320 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005321 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005322 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5323 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
5324 channel_->OnPacketReceived(&packet3, packet_time);
5325 // H264 packet should replace the default receive SSRC.
5326 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5327 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5328 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5329 // Verify that the receive stream sinks to a renderer.
5330 webrtc::VideoFrame video_frame3(CreateBlackFrameBuffer(4, 4), 300, 0,
ilnik00d802b2017-04-11 10:34:31 -07005331 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005332 recv_stream->InjectFrame(video_frame3);
5333 EXPECT_EQ(3, renderer.num_rendered_frames());
5334#endif
5335}
5336
brandtr0dc57ea2017-05-29 23:33:31 -07005337// This test verifies that when a new default stream is created for a new
5338// unsignaled SSRC, the new stream does not overwrite any old stream that had
5339// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005340TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005341 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5342 cricket::VideoRecvParameters parameters;
5343 parameters.codecs.push_back(GetEngineCodec("VP8"));
5344 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5345
5346 // No streams signaled and no packets received, so we should not have any
5347 // stream objects created yet.
5348 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5349
5350 // Receive packet on an unsignaled SSRC.
5351 uint8_t data[kMinRtpPacketLen];
5352 cricket::RtpHeader rtp_header;
5353 rtp_header.payload_type = GetEngineCodec("VP8").id;
5354 rtp_header.seq_num = rtp_header.timestamp = 0;
5355 rtp_header.ssrc = kSsrcs3[0];
5356 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5357 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5358 rtc::PacketTime packet_time;
5359 channel_->OnPacketReceived(&packet, packet_time);
5360 // Default receive stream should be created.
5361 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5362 FakeVideoReceiveStream* recv_stream0 =
5363 fake_call_->GetVideoReceiveStreams()[0];
5364 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5365
5366 // Signal the SSRC.
5367 EXPECT_TRUE(
5368 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5369 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5370 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5371 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5372
5373 // Receive packet on a different unsignaled SSRC.
5374 rtp_header.ssrc = kSsrcs3[1];
5375 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5376 packet.SetData(data, sizeof(data));
5377 channel_->OnPacketReceived(&packet, packet_time);
5378 // New default receive stream should be created, but old stream should remain.
5379 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5380 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5381 FakeVideoReceiveStream* recv_stream1 =
5382 fake_call_->GetVideoReceiveStreams()[1];
5383 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5384}
5385
Seth Hampson7c682e02018-05-04 16:28:15 -07005386TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005387 AddSendStream();
5388
Tommi85959932018-02-07 19:26:06 +01005389 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02005390 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
skvladdc1c62c2016-03-16 19:07:43 -07005391 cricket::VideoFormat capture_format_hd =
5392 capturer.GetSupportedFormats()->front();
5393 EXPECT_EQ(1280, capture_format_hd.width);
5394 EXPECT_EQ(720, capture_format_hd.height);
5395 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
5396 EXPECT_TRUE(channel_->SetSend(true));
perkjfa10b552016-10-02 23:45:26 -07005397 capturer.CaptureFrame();
skvladdc1c62c2016-03-16 19:07:43 -07005398
perkjfa10b552016-10-02 23:45:26 -07005399 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005400 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005401
5402 // TODO(skvlad): Resolve the inconsistency between the interpretation
5403 // of the global bitrate limit for audio and video:
5404 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5405 // max_bandwidth_bps = -1 - remove the bandwidth limit
5406 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005407 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005408
perkjfa10b552016-10-02 23:45:26 -07005409 SetAndExpectMaxBitrate(1000, 0, 1000);
5410 SetAndExpectMaxBitrate(1000, 800, 800);
5411 SetAndExpectMaxBitrate(600, 800, 600);
5412 SetAndExpectMaxBitrate(0, 800, 800);
5413 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005414
Niels Möllerff40b142018-04-09 08:49:14 +02005415 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005416}
5417
eladalonf1841382017-06-12 01:16:46 -07005418TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005419 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005420 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005421 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005422
5423 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005424 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005425 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005426}
5427
eladalonf1841382017-06-12 01:16:46 -07005428TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005429 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005430 FakeVideoSendStream* stream = AddSendStream();
5431
Seth Hampson7c682e02018-05-04 16:28:15 -07005432 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5433 EXPECT_EQ(1UL, parameters.encodings.size());
5434 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5435 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5436
5437 // Note that this is testing the behavior of the FakeVideoSendStream, which
5438 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5439 // we are just testing the behavior of
5440 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005441 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5442 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005443
5444 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5445 // by this amount.
5446 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5447 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5448 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5449 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5450
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005451 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5452 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5453 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5454}
5455
5456TEST_F(WebRtcVideoChannelTest,
5457 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5458 FakeVideoSendStream* stream = AddSendStream();
5459
5460 // Note that this is testing the behavior of the FakeVideoSendStream, which
5461 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5462 // we are just testing the behavior of
5463 // EncoderStreamFactory::CreateEncoderStreams.
5464 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5465 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5466
5467 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5468 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5469 EXPECT_EQ(1UL, parameters.encodings.size());
5470 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5471 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5472
5473 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5474 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5475 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5476}
5477
5478TEST_F(WebRtcVideoChannelTest,
5479 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5480 send_parameters_.max_bandwidth_bps = 99999;
5481 FakeVideoSendStream* stream = AddSendStream();
5482 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5483 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5484 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5485 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5486 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5487 stream->GetVideoStreams()[0].max_bitrate_bps);
5488
5489 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5490 // adjusted down.
5491 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5492 EXPECT_EQ(1UL, parameters.encodings.size());
5493 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5494 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5495 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5496 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5497 stream->GetVideoStreams()[0].min_bitrate_bps);
5498 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5499 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005500}
5501
Åsa Persson8c1bf952018-09-13 10:42:19 +02005502TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5503 FakeVideoSendStream* stream = AddSendStream();
5504
5505 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5506 EXPECT_EQ(1UL, parameters.encodings.size());
5507 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5508 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5509
5510 // Note that this is testing the behavior of the FakeVideoSendStream, which
5511 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5512 // we are just testing the behavior of
5513 // EncoderStreamFactory::CreateEncoderStreams.
5514 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5515 EXPECT_EQ(kDefaultVideoMaxFramerate,
5516 stream->GetVideoStreams()[0].max_framerate);
5517
5518 // Set max framerate and check that VideoStream.max_framerate is set.
5519 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5520 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5521 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5522 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5523
5524 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5525 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5526}
5527
Åsa Persson23eba222018-10-02 14:47:06 +02005528TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5529 FakeVideoSendStream* stream = AddSendStream();
5530
5531 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5532 EXPECT_EQ(1UL, parameters.encodings.size());
5533 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5534 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5535
5536 // Note that this is testing the behavior of the FakeVideoSendStream, which
5537 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5538 // we are just testing the behavior of
5539 // EncoderStreamFactory::CreateEncoderStreams.
5540 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5541 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5542
5543 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5544 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5545 parameters.encodings[0].num_temporal_layers = 2;
5546 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5547
5548 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5549 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5550}
5551
Seth Hampson7c682e02018-05-04 16:28:15 -07005552TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005553 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005554 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005555 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005556 // Two or more encodings should result in failure.
5557 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005558 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005559 // Zero encodings should also fail.
5560 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005561 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005562}
5563
Zach Stein3ca452b2018-01-18 10:01:24 -08005564TEST_F(WebRtcVideoChannelTest,
5565 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5566 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5567 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5568 AddSendStream(sp);
5569
5570 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5571
5572 // Additional encodings should result in failure.
5573 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005574 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005575 // Zero encodings should also fail.
5576 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005577 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005578}
5579
deadbeeffb2aced2017-01-06 23:05:37 -08005580// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005581TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005582 AddSendStream();
5583 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005584 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005585 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005586}
5587
Seth Hampson24722b32017-12-22 09:36:42 -08005588// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5589// a value <= 0, setting the parameters returns false.
5590TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5591 AddSendStream();
5592 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5593 EXPECT_EQ(1UL, parameters.encodings.size());
5594 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5595 parameters.encodings[0].bitrate_priority);
5596
5597 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005598 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005599 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005600 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005601}
5602
5603// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5604// properly on the VideoChannel and propogates down to the video encoder.
5605TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5606 AddSendStream();
5607 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5608 EXPECT_EQ(1UL, parameters.encodings.size());
5609 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5610 parameters.encodings[0].bitrate_priority);
5611
5612 // Change the value and set it on the VideoChannel.
5613 double new_bitrate_priority = 2.0;
5614 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005615 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005616
5617 // Verify that the encoding parameters bitrate_priority is set for the
5618 // VideoChannel.
5619 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5620 EXPECT_EQ(1UL, parameters.encodings.size());
5621 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5622
5623 // Verify that the new value propagated down to the encoder.
5624 std::vector<FakeVideoSendStream*> video_send_streams =
5625 fake_call_->GetVideoSendStreams();
5626 EXPECT_EQ(1UL, video_send_streams.size());
5627 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5628 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5629 // appropriately.
5630 EXPECT_EQ(new_bitrate_priority,
5631 video_send_stream->GetEncoderConfig().bitrate_priority);
5632 // Check that the vector of VideoStreams also was propagated correctly. Note
5633 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5634 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005635 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005636 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5637}
5638
5639// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5640// VideoChannel and the value propogates to the video encoder with all simulcast
5641// streams.
5642TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5643 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005644 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005645 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5646 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5647 AddSendStream(stream_params);
5648 uint32_t primary_ssrc = stream_params.first_ssrc();
5649
Tommi85959932018-02-07 19:26:06 +01005650 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
5651 // frame. This creates multiple VideoStreams for all simulcast layers when
5652 // reconfiguring, and allows us to test this behavior.
5653 FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson24722b32017-12-22 09:36:42 -08005654 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02005655 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson24722b32017-12-22 09:36:42 -08005656 EXPECT_EQ(cricket::CS_RUNNING,
5657 capturer.Start(cricket::VideoFormat(
5658 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
5659 cricket::FOURCC_I420)));
5660 channel_->SetSend(true);
5661 EXPECT_TRUE(capturer.CaptureFrame());
5662 // Get and set the rtp encoding parameters.
5663 webrtc::RtpParameters parameters =
5664 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005665 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005666 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5667 parameters.encodings[0].bitrate_priority);
5668 // Change the value and set it on the VideoChannel.
5669 double new_bitrate_priority = 2.0;
5670 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005671 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005672
5673 // Verify that the encoding parameters priority is set on the VideoChannel.
5674 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005675 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005676 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5677
5678 // Verify that the new value propagated down to the encoder.
5679 std::vector<FakeVideoSendStream*> video_send_streams =
5680 fake_call_->GetVideoSendStreams();
5681 EXPECT_EQ(1UL, video_send_streams.size());
5682 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5683 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5684 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005685 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005686 video_send_stream->GetEncoderConfig().number_of_streams);
5687 EXPECT_EQ(new_bitrate_priority,
5688 video_send_stream->GetEncoderConfig().bitrate_priority);
5689 // Check that the vector of VideoStreams also propagated correctly. The
5690 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5691 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005692 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005693 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005694 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5695 // Since we are only setting bitrate priority per-sender, the other
5696 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005697 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005698 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005699 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005700 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005701 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005702}
5703
Tim Haloun648d28a2018-10-18 16:52:22 -07005704// RTCRtpEncodingParameters.network_priority must be one of a few values
5705// derived from the default priority, corresponding to very-low, low, medium,
5706// or high.
5707TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
5708 AddSendStream();
5709 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5710 EXPECT_EQ(1UL, parameters.encodings.size());
5711 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5712 parameters.encodings[0].network_priority);
5713
5714 double good_values[] = {0.5, 1.0, 2.0, 4.0};
5715 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
5716 for (auto it : good_values) {
5717 parameters.encodings[0].network_priority = it;
5718 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5719 }
5720 for (auto it : bad_values) {
5721 parameters.encodings[0].network_priority = it;
5722 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5723 }
5724}
5725
Åsa Persson8c1bf952018-09-13 10:42:19 +02005726TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
5727 const size_t kNumSimulcastStreams = 3;
5728 SetUpSimulcast(true, false);
5729
5730 // Get and set the rtp encoding parameters.
5731 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5732 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5733 for (const auto& encoding : parameters.encodings) {
5734 EXPECT_FALSE(encoding.max_framerate);
5735 }
5736
5737 // Change the value and set it on the VideoChannel.
5738 parameters.encodings[0].max_framerate = 10;
5739 parameters.encodings[1].max_framerate = 20;
5740 parameters.encodings[2].max_framerate = 25;
5741 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5742
5743 // Verify that the bitrates are set on the VideoChannel.
5744 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5745 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5746 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
5747 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
5748 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
5749}
5750
Åsa Persson23eba222018-10-02 14:47:06 +02005751TEST_F(WebRtcVideoChannelTest,
5752 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
5753 const size_t kNumSimulcastStreams = 3;
5754 SetUpSimulcast(true, false);
5755
5756 // Get and set the rtp encoding parameters.
5757 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5758 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5759
5760 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
5761 parameters.encodings[0].num_temporal_layers = 0;
5762 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5763 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5764 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
5765 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5766 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5767}
5768
5769TEST_F(WebRtcVideoChannelTest,
5770 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
5771 const size_t kNumSimulcastStreams = 3;
5772 SetUpSimulcast(true, false);
5773
5774 // Get and set the rtp encoding parameters.
5775 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5776 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5777
5778 // No/all layers should be set.
5779 parameters.encodings[0].num_temporal_layers = 1;
5780 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5781 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5782
5783 // Different values not supported.
5784 parameters.encodings[0].num_temporal_layers = 1;
5785 parameters.encodings[1].num_temporal_layers = 2;
5786 parameters.encodings[2].num_temporal_layers = 2;
5787 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5788 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5789}
5790
5791TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
5792 const size_t kNumSimulcastStreams = 3;
5793 SetUpSimulcast(true, false);
5794
5795 // Get and set the rtp encoding parameters.
5796 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5797 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5798 for (const auto& encoding : parameters.encodings)
5799 EXPECT_FALSE(encoding.num_temporal_layers);
5800
5801 // Change the value and set it on the VideoChannel.
5802 parameters.encodings[0].num_temporal_layers = 3;
5803 parameters.encodings[1].num_temporal_layers = 3;
5804 parameters.encodings[2].num_temporal_layers = 3;
5805 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5806
5807 // Verify that the number of temporal layers are set on the VideoChannel.
5808 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5809 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5810 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
5811 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
5812 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
5813}
5814
5815TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
5816 const size_t kNumSimulcastStreams = 3;
5817 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5818
5819 // Send a full size frame so all simulcast layers are used when reconfiguring.
5820 FakeVideoCapturerWithTaskQueue capturer;
5821 VideoOptions options;
5822 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5823 EXPECT_EQ(cricket::CS_RUNNING,
5824 capturer.Start(capturer.GetSupportedFormats()->front()));
5825 channel_->SetSend(true);
5826 EXPECT_TRUE(capturer.CaptureFrame());
5827
5828 // Get and set the rtp encoding parameters.
5829 // Change the value and set it on the VideoChannel.
5830 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5831 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5832 parameters.encodings[0].num_temporal_layers = 2;
5833 parameters.encodings[1].num_temporal_layers = 2;
5834 parameters.encodings[2].num_temporal_layers = 2;
5835 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5836
5837 // Verify that the new value is propagated down to the encoder.
5838 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5839 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5840 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5841 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5842 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5843 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
5844 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
5845 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
5846
5847 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5848 // VideoStreams are created appropriately for the simulcast case.
5849 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5850 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5851 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
5852 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
5853
5854 // No parameter changed, encoder should not be reconfigured.
5855 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5856 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5857
5858 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5859}
5860
5861TEST_F(WebRtcVideoChannelTest,
5862 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
5863 const size_t kDefaultNumTemporalLayers = 3;
5864 const size_t kNumSimulcastStreams = 3;
5865 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5866
5867 // Send a full size frame so all simulcast layers are used when reconfiguring.
5868 FakeVideoCapturerWithTaskQueue capturer;
5869 VideoOptions options;
5870 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5871 EXPECT_EQ(cricket::CS_RUNNING,
5872 capturer.Start(capturer.GetSupportedFormats()->front()));
5873 channel_->SetSend(true);
5874 EXPECT_TRUE(capturer.CaptureFrame());
5875
5876 // Change rtp encoding parameters, num_temporal_layers not changed.
5877 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5878 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5879 parameters.encodings[0].min_bitrate_bps = 33000;
5880 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5881
5882 // Verify that no value is propagated down to the encoder.
5883 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5884 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5885 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5886 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
5887 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
5888 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
5889
5890 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5891 // VideoStreams are created appropriately for the simulcast case.
5892 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5893 EXPECT_EQ(kDefaultNumTemporalLayers,
5894 stream->GetVideoStreams()[0].num_temporal_layers);
5895 EXPECT_EQ(kDefaultNumTemporalLayers,
5896 stream->GetVideoStreams()[1].num_temporal_layers);
5897 EXPECT_EQ(kDefaultNumTemporalLayers,
5898 stream->GetVideoStreams()[2].num_temporal_layers);
5899
5900 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5901}
5902
Åsa Persson8c1bf952018-09-13 10:42:19 +02005903TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
5904 const size_t kNumSimulcastStreams = 3;
5905 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5906
5907 // Send a full size frame so all simulcast layers are used when reconfiguring.
5908 FakeVideoCapturerWithTaskQueue capturer;
5909 VideoOptions options;
5910 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5911 EXPECT_EQ(cricket::CS_RUNNING,
5912 capturer.Start(capturer.GetSupportedFormats()->front()));
5913 channel_->SetSend(true);
5914 EXPECT_TRUE(capturer.CaptureFrame());
5915
5916 // Get and set the rtp encoding parameters.
5917 // Change the value and set it on the VideoChannel.
5918 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5919 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5920 parameters.encodings[0].max_framerate = 15;
5921 parameters.encodings[1].max_framerate = 25;
5922 parameters.encodings[2].max_framerate = 20;
5923 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5924
5925 // Verify that the new value propagated down to the encoder.
5926 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5927 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5928 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5929 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5930 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5931 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5932 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
5933 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5934
5935 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5936 // VideoStreams are created appropriately for the simulcast case.
5937 // Currently the maximum |max_framerate| is used.
5938 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5939 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
5940 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
5941 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
5942
5943 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5944}
5945
5946TEST_F(WebRtcVideoChannelTest,
5947 DefaultValuePropagatedToEncoderForUnsetFramerate) {
5948 const size_t kNumSimulcastStreams = 3;
5949 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5950 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5951
5952 // Send a full size frame so all simulcast layers are used when reconfiguring.
5953 FakeVideoCapturerWithTaskQueue capturer;
5954 VideoOptions options;
5955 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5956 EXPECT_EQ(cricket::CS_RUNNING,
5957 capturer.Start(capturer.GetSupportedFormats()->front()));
5958 channel_->SetSend(true);
5959 EXPECT_TRUE(capturer.CaptureFrame());
5960
5961 // Get and set the rtp encoding parameters.
5962 // Change the value and set it on the VideoChannel.
5963 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5964 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5965 parameters.encodings[0].max_framerate = 15;
5966 parameters.encodings[2].max_framerate = 20;
5967 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5968
5969 // Verify that the new value propagated down to the encoder.
5970 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5971 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5972 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5973 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5974 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5975 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
5976 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5977
5978 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5979 // VideoStreams are created appropriately for the simulcast case.
5980 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
5981 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5982 EXPECT_EQ(kDefaultVideoMaxFramerate,
5983 stream->GetVideoStreams()[0].max_framerate);
5984 EXPECT_EQ(kDefaultVideoMaxFramerate,
5985 stream->GetVideoStreams()[1].max_framerate);
5986 EXPECT_EQ(kDefaultVideoMaxFramerate,
5987 stream->GetVideoStreams()[2].max_framerate);
5988
5989 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5990}
5991
Åsa Persson55659812018-06-18 17:51:32 +02005992TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
5993 const size_t kNumSimulcastStreams = 3;
5994 SetUpSimulcast(true, false);
5995
5996 // Get and set the rtp encoding parameters.
5997 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5998 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5999 for (const auto& encoding : parameters.encodings) {
6000 EXPECT_FALSE(encoding.min_bitrate_bps);
6001 EXPECT_FALSE(encoding.max_bitrate_bps);
6002 }
6003
6004 // Change the value and set it on the VideoChannel.
6005 parameters.encodings[0].min_bitrate_bps = 100000;
6006 parameters.encodings[0].max_bitrate_bps = 200000;
6007 parameters.encodings[1].min_bitrate_bps = 300000;
6008 parameters.encodings[1].max_bitrate_bps = 400000;
6009 parameters.encodings[2].min_bitrate_bps = 500000;
6010 parameters.encodings[2].max_bitrate_bps = 600000;
6011 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6012
6013 // Verify that the bitrates are set on the VideoChannel.
6014 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6015 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6016 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6017 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6018 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6019 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6020 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6021 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6022}
6023
6024TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6025 const size_t kNumSimulcastStreams = 3;
6026 SetUpSimulcast(true, false);
6027
6028 // Get and set the rtp encoding parameters.
6029 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6030 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6031
6032 // Max bitrate lower than min bitrate should fail.
6033 parameters.encodings[2].min_bitrate_bps = 100000;
6034 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6035 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6036 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6037}
6038
6039// Test that min and max bitrate values set via RtpParameters are correctly
6040// propagated to the underlying encoder, and that the target is set to 3/4 of
6041// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6042// that are used if no min/max are specified).
6043TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6044 const size_t kNumSimulcastStreams = 3;
6045 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6046
6047 // Send a full size frame so all simulcast layers are used when reconfiguring.
6048 FakeVideoCapturerWithTaskQueue capturer;
6049 VideoOptions options;
6050 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6051 EXPECT_EQ(cricket::CS_RUNNING,
6052 capturer.Start(capturer.GetSupportedFormats()->front()));
6053 channel_->SetSend(true);
6054 EXPECT_TRUE(capturer.CaptureFrame());
6055
6056 // Get and set the rtp encoding parameters.
6057 // Change the value and set it on the VideoChannel.
6058 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6059 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6060 parameters.encodings[0].min_bitrate_bps = 100000;
6061 parameters.encodings[0].max_bitrate_bps = 200000;
6062 parameters.encodings[1].min_bitrate_bps = 300000;
6063 parameters.encodings[1].max_bitrate_bps = 400000;
6064 parameters.encodings[2].min_bitrate_bps = 500000;
6065 parameters.encodings[2].max_bitrate_bps = 600000;
6066 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6067
6068 // Verify that the new value propagated down to the encoder.
6069 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6070 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6071 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6072 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6073 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6074 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6075 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6076 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6077 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6078 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6079 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6080
6081 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6082 // VideoStreams are created appropriately for the simulcast case.
6083 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6084 // Target bitrate: 200000 * 3 / 4 = 150000.
6085 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6086 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6087 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6088 // Target bitrate: 400000 * 3 / 4 = 300000.
6089 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6090 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6091 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6092 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6093 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6094 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6095 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6096
6097 // No parameter changed, encoder should not be reconfigured.
6098 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6099 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6100
6101 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6102}
6103
6104// Test to only specify the min or max bitrate value for a layer via
6105// RtpParameters. The unspecified min/max and target value should be set to the
6106// simulcast default that is used if no min/max are specified.
6107TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6108 const size_t kNumSimulcastStreams = 3;
6109 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6110 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6111
6112 // Send a full size frame so all simulcast layers are used when reconfiguring.
6113 FakeVideoCapturerWithTaskQueue capturer;
6114 VideoOptions options;
6115 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6116 EXPECT_EQ(cricket::CS_RUNNING,
6117 capturer.Start(capturer.GetSupportedFormats()->front()));
6118 channel_->SetSend(true);
6119 EXPECT_TRUE(capturer.CaptureFrame());
6120
6121 // Get and set the rtp encoding parameters.
6122 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6123 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6124
6125 // Change the value and set it on the VideoChannel.
6126 // Layer 0: only configure min bitrate.
6127 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6128 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6129 // Layer 1: only configure max bitrate.
6130 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6131 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6132 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6133
6134 // Verify that the new value propagated down to the encoder.
6135 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6136 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6137 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6138 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6139 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6140 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6141 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6142 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6143 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6144 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6145
6146 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6147 // VideoStreams are created appropriately for the simulcast case.
6148 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6149 // Layer 0: min configured bitrate should overwrite min default.
6150 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6151 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6152 stream->GetVideoStreams()[0].target_bitrate_bps);
6153 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6154 stream->GetVideoStreams()[0].max_bitrate_bps);
6155 // Layer 1: max configured bitrate should overwrite max default.
6156 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6157 stream->GetVideoStreams()[1].min_bitrate_bps);
6158 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6159 stream->GetVideoStreams()[1].target_bitrate_bps);
6160 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6161 // Layer 2: min and max bitrate not configured, default expected.
6162 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6163 stream->GetVideoStreams()[2].min_bitrate_bps);
6164 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6165 stream->GetVideoStreams()[2].target_bitrate_bps);
6166 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6167 stream->GetVideoStreams()[2].max_bitrate_bps);
6168
6169 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6170}
6171
6172// Test that specifying the min (or max) bitrate value for a layer via
6173// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6174// unspecified values accordingly.
6175TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6176 const size_t kNumSimulcastStreams = 3;
6177 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6178 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6179
6180 // Send a full size frame so all simulcast layers are used when reconfiguring.
6181 FakeVideoCapturerWithTaskQueue capturer;
6182 VideoOptions options;
6183 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6184 EXPECT_EQ(cricket::CS_RUNNING,
6185 capturer.Start(capturer.GetSupportedFormats()->front()));
6186 channel_->SetSend(true);
6187 EXPECT_TRUE(capturer.CaptureFrame());
6188
6189 // Get and set the rtp encoding parameters.
6190 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6191 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6192
6193 // Change the value and set it on the VideoChannel.
6194 // For layer 0, set the min bitrate above the default max.
6195 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6196 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6197 // For layer 1, set the max bitrate below the default min.
6198 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6199 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6200 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6201
6202 // Verify that the new value propagated down to the encoder.
6203 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6204 // VideoStreams are created appropriately for the simulcast case.
6205 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6206 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6207 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6208 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6209 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6210 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6211 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6212 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6213 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6214 // Layer 2: min and max bitrate not configured, default expected.
6215 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6216 stream->GetVideoStreams()[2].min_bitrate_bps);
6217 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6218 stream->GetVideoStreams()[2].target_bitrate_bps);
6219 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6220 stream->GetVideoStreams()[2].max_bitrate_bps);
6221
6222 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6223}
6224
6225TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6226 const size_t kNumSimulcastStreams = 3;
6227 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6228 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6229
6230 // Send a full size frame so all simulcast layers are used when reconfiguring.
6231 FakeVideoCapturerWithTaskQueue capturer;
6232 VideoOptions options;
6233 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6234 EXPECT_EQ(cricket::CS_RUNNING,
6235 capturer.Start(capturer.GetSupportedFormats()->front()));
6236 channel_->SetSend(true);
6237 EXPECT_TRUE(capturer.CaptureFrame());
6238
6239 // Set max bitrate for all but the highest layer.
6240 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6241 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6242 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6243 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6244 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6245
6246 // Set max bandwidth equal to total max bitrate.
6247 send_parameters_.max_bandwidth_bps =
6248 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6249 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6250 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6251
6252 // No bitrate above the total max to give to the highest layer.
6253 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6254 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6255 stream->GetVideoStreams()[2].max_bitrate_bps);
6256
6257 // Set max bandwidth above the total max bitrate.
6258 send_parameters_.max_bandwidth_bps =
6259 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6260 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6261 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6262
6263 // The highest layer has no max bitrate set -> the bitrate above the total
6264 // max should be given to the highest layer.
6265 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6266 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6267 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6268 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6269 stream->GetVideoStreams()[2].max_bitrate_bps);
6270
6271 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6272}
6273
6274TEST_F(WebRtcVideoChannelTest,
6275 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6276 const size_t kNumSimulcastStreams = 3;
6277 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6278 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6279 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6280
6281 // Send a full size frame so all simulcast layers are used when reconfiguring.
6282 FakeVideoCapturerWithTaskQueue capturer;
6283 VideoOptions options;
6284 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6285 EXPECT_EQ(cricket::CS_RUNNING,
6286 capturer.Start(capturer.GetSupportedFormats()->front()));
6287 channel_->SetSend(true);
6288 EXPECT_TRUE(capturer.CaptureFrame());
6289
6290 // Set max bitrate for the highest layer.
6291 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6292 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6293 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6294 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6295
6296 // Set max bandwidth above the total max bitrate.
6297 send_parameters_.max_bandwidth_bps =
6298 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6299 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6300 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6301
6302 // The highest layer has the max bitrate set -> the bitrate above the total
6303 // max should not be given to the highest layer.
6304 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6305 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6306 stream->GetVideoStreams()[2].max_bitrate_bps);
6307
6308 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6309}
6310
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006311// Test that min and max bitrate values set via RtpParameters are correctly
6312// propagated to the underlying encoder for a single stream.
6313TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6314 FakeVideoSendStream* stream = AddSendStream();
6315 EXPECT_TRUE(channel_->SetSend(true));
6316 EXPECT_TRUE(stream->IsSending());
6317
6318 // Set min and max bitrate.
6319 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6320 EXPECT_EQ(1u, parameters.encodings.size());
6321 parameters.encodings[0].min_bitrate_bps = 80000;
6322 parameters.encodings[0].max_bitrate_bps = 150000;
6323 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6324
6325 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6326 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6327 EXPECT_EQ(1u, encoder_config.number_of_streams);
6328 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6329 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6330 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6331
6332 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6333 // VideoStreams are created appropriately.
6334 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6335 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6336 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6337 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6338}
6339
6340// Test the default min and max bitrate value are correctly propagated to the
6341// underlying encoder for a single stream (when the values are not set via
6342// RtpParameters).
6343TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6344 FakeVideoSendStream* stream = AddSendStream();
6345 EXPECT_TRUE(channel_->SetSend(true));
6346 EXPECT_TRUE(stream->IsSending());
6347
6348 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6349 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6350 EXPECT_EQ(1u, encoder_config.number_of_streams);
6351 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6352 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6353 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6354
6355 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6356 // VideoStreams are created appropriately.
6357 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6358 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6359 stream->GetVideoStreams()[0].min_bitrate_bps);
6360 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6361 stream->GetVideoStreams()[0].min_bitrate_bps);
6362 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6363 stream->GetVideoStreams()[0].target_bitrate_bps);
6364}
6365
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006366// Test that a stream will not be sending if its encoding is made inactive
6367// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006368TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006369 FakeVideoSendStream* stream = AddSendStream();
6370 EXPECT_TRUE(channel_->SetSend(true));
6371 EXPECT_TRUE(stream->IsSending());
6372
6373 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006374 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006375 ASSERT_EQ(1u, parameters.encodings.size());
6376 ASSERT_TRUE(parameters.encodings[0].active);
6377 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006378 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006379 EXPECT_FALSE(stream->IsSending());
6380
6381 // Now change it back to active and verify we resume sending.
6382 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006383 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006384 EXPECT_TRUE(stream->IsSending());
6385}
6386
Seth Hampson8234ead2018-02-02 15:16:24 -08006387// Tests that when active is updated for any simulcast layer then the send
6388// stream's sending state will be updated and it will be reconfigured with the
6389// new appropriate active simulcast streams.
6390TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6391 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006392 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006393 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6394 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6395 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6396 uint32_t primary_ssrc = stream_params.first_ssrc();
6397
Tommi85959932018-02-07 19:26:06 +01006398 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
6399 // frame. This allows us to test that ReconfigureEncoder is called
6400 // appropriately.
6401 cricket::FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson8234ead2018-02-02 15:16:24 -08006402 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02006403 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson8234ead2018-02-02 15:16:24 -08006404 EXPECT_EQ(cricket::CS_RUNNING,
6405 capturer.Start(cricket::VideoFormat(
6406 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
6407 cricket::FOURCC_I420)));
6408 channel_->SetSend(true);
6409 EXPECT_TRUE(capturer.CaptureFrame());
6410
6411 // Check that all encodings are initially active.
6412 webrtc::RtpParameters parameters =
6413 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006414 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006415 EXPECT_TRUE(parameters.encodings[0].active);
6416 EXPECT_TRUE(parameters.encodings[1].active);
6417 EXPECT_TRUE(parameters.encodings[2].active);
6418 EXPECT_TRUE(fake_video_send_stream->IsSending());
6419
6420 // Only turn on only the middle stream.
6421 parameters.encodings[0].active = false;
6422 parameters.encodings[1].active = true;
6423 parameters.encodings[2].active = false;
6424 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6425 // Verify that the active fields are set on the VideoChannel.
6426 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006427 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006428 EXPECT_FALSE(parameters.encodings[0].active);
6429 EXPECT_TRUE(parameters.encodings[1].active);
6430 EXPECT_FALSE(parameters.encodings[2].active);
6431 // Check that the VideoSendStream is updated appropriately. This means its
6432 // send state was updated and it was reconfigured.
6433 EXPECT_TRUE(fake_video_send_stream->IsSending());
6434 std::vector<webrtc::VideoStream> simulcast_streams =
6435 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006436 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006437 EXPECT_FALSE(simulcast_streams[0].active);
6438 EXPECT_TRUE(simulcast_streams[1].active);
6439 EXPECT_FALSE(simulcast_streams[2].active);
6440
6441 // Turn off all streams.
6442 parameters.encodings[0].active = false;
6443 parameters.encodings[1].active = false;
6444 parameters.encodings[2].active = false;
6445 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6446 // Verify that the active fields are set on the VideoChannel.
6447 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006448 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006449 EXPECT_FALSE(parameters.encodings[0].active);
6450 EXPECT_FALSE(parameters.encodings[1].active);
6451 EXPECT_FALSE(parameters.encodings[2].active);
6452 // Check that the VideoSendStream is off.
6453 EXPECT_FALSE(fake_video_send_stream->IsSending());
6454 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006455 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006456 EXPECT_FALSE(simulcast_streams[0].active);
6457 EXPECT_FALSE(simulcast_streams[1].active);
6458 EXPECT_FALSE(simulcast_streams[2].active);
6459
Niels Möllerff40b142018-04-09 08:49:14 +02006460 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08006461}
6462
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006463// Test that if a stream is reconfigured (due to a codec change or other
6464// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07006465TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006466 InactiveStreamDoesntStartSendingWhenReconfigured) {
6467 // Set an initial codec list, which will be modified later.
6468 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08006469 parameters1.codecs.push_back(GetEngineCodec("VP8"));
6470 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006471 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
6472
6473 FakeVideoSendStream* stream = AddSendStream();
6474 EXPECT_TRUE(channel_->SetSend(true));
6475 EXPECT_TRUE(stream->IsSending());
6476
6477 // Get current parameters and change "active" to false.
6478 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6479 ASSERT_EQ(1u, parameters.encodings.size());
6480 ASSERT_TRUE(parameters.encodings[0].active);
6481 parameters.encodings[0].active = false;
6482 EXPECT_EQ(1u, GetFakeSendStreams().size());
6483 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08006484 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006485 EXPECT_FALSE(stream->IsSending());
6486
6487 // Reorder the codec list, causing the stream to be reconfigured.
6488 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08006489 parameters2.codecs.push_back(GetEngineCodec("VP9"));
6490 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006491 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
6492 auto new_streams = GetFakeSendStreams();
6493 // Assert that a new underlying stream was created due to the codec change.
6494 // Otherwise, this test isn't testing what it set out to test.
6495 EXPECT_EQ(1u, GetFakeSendStreams().size());
6496 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
6497
6498 // Verify that we still are not sending anything, due to the inactive
6499 // encoding.
6500 EXPECT_FALSE(new_streams[0]->IsSending());
6501}
6502
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006503// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006504TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006505 AddSendStream();
6506 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006507 parameters.codecs.push_back(GetEngineCodec("VP8"));
6508 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006509 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6510
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006511 webrtc::RtpParameters rtp_parameters =
6512 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006513 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006514 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6515 rtp_parameters.codecs[0]);
6516 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6517 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006518}
6519
Florent Castellidacec712018-05-24 16:24:21 +02006520// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
6521TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
6522 StreamParams params = StreamParams::CreateLegacy(kSsrc);
6523 params.cname = "rtcpcname";
6524 AddSendStream(params);
6525
6526 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
6527 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
6528}
6529
deadbeeffb2aced2017-01-06 23:05:37 -08006530// Test that RtpParameters for send stream has one encoding and it has
6531// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006532TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08006533 AddSendStream();
6534
6535 webrtc::RtpParameters rtp_parameters =
6536 channel_->GetRtpSendParameters(last_ssrc_);
6537 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006538 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08006539}
6540
Florent Castelliabe301f2018-06-12 18:33:49 +02006541TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
6542 AddSendStream();
6543
6544 webrtc::RtpParameters rtp_parameters =
6545 channel_->GetRtpSendParameters(last_ssrc_);
6546 rtp_parameters.header_extensions.emplace_back();
6547
6548 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
6549
6550 webrtc::RTCError result =
6551 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6552 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
6553}
6554
Florent Castelli87b3c512018-07-18 16:00:28 +02006555TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
6556 AddSendStream();
6557
6558 FakeVideoCapturerWithTaskQueue capturer;
6559 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
6560
6561 webrtc::RtpParameters rtp_parameters =
6562 channel_->GetRtpSendParameters(last_ssrc_);
6563 EXPECT_EQ(rtp_parameters.degradation_preference,
6564 webrtc::DegradationPreference::BALANCED);
6565 rtp_parameters.degradation_preference =
6566 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
6567
6568 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
6569
6570 webrtc::RtpParameters updated_rtp_parameters =
6571 channel_->GetRtpSendParameters(last_ssrc_);
6572 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
6573 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
6574
6575 // Remove the source since it will be destroyed before the channel
6576 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6577}
6578
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006579// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006580TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006581 AddSendStream();
6582 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006583 parameters.codecs.push_back(GetEngineCodec("VP8"));
6584 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006585 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6586
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006587 webrtc::RtpParameters initial_params =
6588 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006589
6590 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08006591 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006592
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006593 // ... And this shouldn't change the params returned by GetRtpSendParameters.
6594 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
6595}
6596
6597// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006598TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006599 AddRecvStream();
6600 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006601 parameters.codecs.push_back(GetEngineCodec("VP8"));
6602 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006603 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6604
6605 webrtc::RtpParameters rtp_parameters =
6606 channel_->GetRtpReceiveParameters(last_ssrc_);
6607 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006608 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6609 rtp_parameters.codecs[0]);
6610 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6611 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006612}
6613
johan073ece42016-08-26 02:59:47 -07006614#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07006615TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006616#else
eladalonf1841382017-06-12 01:16:46 -07006617TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006618#endif
johan3859c892016-08-05 09:19:25 -07006619 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07006620 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08006621 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07006622 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07006623 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08006624 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07006625 parameters.codecs.push_back(kH264sprop2);
6626 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6627
6628 FakeVideoReceiveStream* recv_stream = AddRecvStream();
6629 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
6630 webrtc::RtpParameters rtp_parameters =
6631 channel_->GetRtpReceiveParameters(last_ssrc_);
6632 ASSERT_EQ(2u, rtp_parameters.codecs.size());
6633 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
6634 ASSERT_EQ(2u, cfg.decoders.size());
6635 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006636 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006637 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006638 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
6639 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006640 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07006641
6642 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006643 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006644 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006645 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
6646 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006647 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07006648}
6649
sakal1fd95952016-06-22 00:46:15 -07006650// Test that RtpParameters for receive stream has one encoding and it has
6651// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006652TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07006653 AddRecvStream();
6654
6655 webrtc::RtpParameters rtp_parameters =
6656 channel_->GetRtpReceiveParameters(last_ssrc_);
6657 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006658 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07006659}
6660
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006661// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006662TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006663 AddRecvStream();
6664 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006665 parameters.codecs.push_back(GetEngineCodec("VP8"));
6666 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006667 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6668
6669 webrtc::RtpParameters initial_params =
6670 channel_->GetRtpReceiveParameters(last_ssrc_);
6671
6672 // We should be able to set the params we just got.
6673 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
6674
6675 // ... And this shouldn't change the params returned by
6676 // GetRtpReceiveParameters.
6677 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006678}
6679
deadbeef3bc15102017-04-20 19:25:07 -07006680// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
6681// aren't signaled. It should always return an empty "RtpEncodingParameters",
6682// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07006683TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07006684 // Call necessary methods to configure receiving a default stream as
6685 // soon as it arrives.
6686 cricket::VideoRecvParameters parameters;
6687 parameters.codecs.push_back(GetEngineCodec("VP8"));
6688 parameters.codecs.push_back(GetEngineCodec("VP9"));
6689 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6690
6691 // Call GetRtpReceiveParameters before configured to receive an unsignaled
6692 // stream. Should return nothing.
6693 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
6694
6695 // Set a sink for an unsignaled stream.
6696 cricket::FakeVideoRenderer renderer;
6697 // Value of "0" means "unsignaled stream".
6698 EXPECT_TRUE(channel_->SetSink(0, &renderer));
6699
6700 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
6701 // in this method means "unsignaled stream".
6702 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
6703 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6704 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6705
6706 // Receive VP8 packet.
6707 uint8_t data[kMinRtpPacketLen];
6708 cricket::RtpHeader rtpHeader;
6709 rtpHeader.payload_type = GetEngineCodec("VP8").id;
6710 rtpHeader.seq_num = rtpHeader.timestamp = 0;
6711 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
6712 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
6713 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
6714 rtc::PacketTime packet_time;
6715 channel_->OnPacketReceived(&packet, packet_time);
6716
6717 // The |ssrc| member should still be unset.
6718 rtp_parameters = channel_->GetRtpReceiveParameters(0);
6719 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6720 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6721}
6722
eladalonf1841382017-06-12 01:16:46 -07006723void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02006724 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006725 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02006726
6727 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02006728 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02006729 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02006730 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02006731
6732 if (receiver_first) {
6733 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6734 std::vector<FakeVideoReceiveStream*> receive_streams =
6735 fake_call_->GetVideoReceiveStreams();
6736 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02006737 // Default local SSRC when we have no sender.
6738 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6739 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006740 }
6741 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
6742 if (!receiver_first)
6743 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6744 std::vector<FakeVideoReceiveStream*> receive_streams =
6745 fake_call_->GetVideoReceiveStreams();
6746 ASSERT_EQ(1u, receive_streams.size());
6747 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02006748
6749 // Removing first sender should fall back to another (in this case the second)
6750 // local send stream's SSRC.
6751 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
6752 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006753 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006754 ASSERT_EQ(1u, receive_streams.size());
6755 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
6756
6757 // Removing the last sender should fall back to default local SSRC.
6758 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006759 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006760 ASSERT_EQ(1u, receive_streams.size());
6761 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6762 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006763}
6764
eladalonf1841382017-06-12 01:16:46 -07006765TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02006766 TestReceiverLocalSsrcConfiguration(false);
6767}
6768
eladalonf1841382017-06-12 01:16:46 -07006769TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02006770 TestReceiverLocalSsrcConfiguration(true);
6771}
6772
eladalonf1841382017-06-12 01:16:46 -07006773class WebRtcVideoChannelSimulcastTest : public testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006774 public:
eladalonf1841382017-06-12 01:16:46 -07006775 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01006776 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006777 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
6778 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +02006779 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006780 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02006781 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006782 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07006783 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006784
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00006785 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02006786 encoder_factory_->AddSupportedVideoCodecType("VP8");
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07006787 channel_.reset(engine_.CreateChannel(&fake_call_, GetMediaConfig(),
6788 VideoOptions(),
6789 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08006790 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006791 last_ssrc_ = 123;
6792 }
6793
6794 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006795 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07006796 int capture_width,
6797 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006798 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08006799 size_t expected_num_streams,
6800 bool screenshare,
6801 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006802 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006803 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08006804 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006805 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006806
Peter Boström0c4e06b2015-10-07 12:23:21 +02006807 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07006808 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006809 ssrcs.resize(num_configured_streams);
6810
sprangf24a0642017-02-28 13:23:26 -08006811 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006812 // Send a full-size frame to trigger a stream reconfiguration to use all
6813 // expected simulcast layers.
Tommi85959932018-02-07 19:26:06 +01006814 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08006815 VideoOptions options;
6816 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01006817 options.is_screencast = screenshare;
Yves Gerey665174f2018-06-19 15:03:05 +02006818 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08006819 // Fetch the latest stream since SetVideoSend() may recreate it if the
6820 // screen content setting is changed.
6821 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006822 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(cricket::VideoFormat(
perkj26752742016-10-24 01:21:16 -07006823 capture_width, capture_height,
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006824 cricket::VideoFormat::FpsToInterval(30),
6825 cricket::FOURCC_I420)));
6826 channel_->SetSend(true);
6827 EXPECT_TRUE(capturer.CaptureFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006828
Zach Stein3ca452b2018-01-18 10:01:24 -08006829 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
6830 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
6831
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006832 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6833 ASSERT_EQ(expected_num_streams, video_streams.size());
6834
sprang429600d2017-01-26 06:12:26 -08006835 std::vector<webrtc::VideoStream> expected_streams;
6836 if (conference_mode) {
6837 expected_streams = GetSimulcastConfig(
6838 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08006839 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02006840 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08006841 if (screenshare) {
6842 for (const webrtc::VideoStream& stream : expected_streams) {
6843 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00006844 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
6845 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08006846 }
6847 }
sprang429600d2017-01-26 06:12:26 -08006848 } else {
6849 webrtc::VideoStream stream;
6850 stream.width = capture_width;
6851 stream.height = capture_height;
6852 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01006853 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08006854 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006855 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08006856 stream.max_qp = kDefaultQpMax;
6857 expected_streams.push_back(stream);
6858 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006859
6860 ASSERT_EQ(expected_streams.size(), video_streams.size());
6861
6862 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006863 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006864 for (size_t i = 0; i < num_streams; ++i) {
6865 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
6866 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
6867
6868 EXPECT_GT(video_streams[i].max_framerate, 0);
6869 EXPECT_EQ(expected_streams[i].max_framerate,
6870 video_streams[i].max_framerate);
6871
6872 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
6873 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
6874 video_streams[i].min_bitrate_bps);
6875
6876 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
6877 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
6878 video_streams[i].target_bitrate_bps);
6879
6880 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
6881 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
6882 video_streams[i].max_bitrate_bps);
6883
6884 EXPECT_GT(video_streams[i].max_qp, 0);
6885 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
6886
Sergey Silkina796a7e2018-03-01 15:11:29 +01006887 EXPECT_EQ(conference_mode,
6888 expected_streams[i].num_temporal_layers.has_value());
6889
6890 if (conference_mode) {
6891 EXPECT_EQ(expected_streams[i].num_temporal_layers,
6892 video_streams[i].num_temporal_layers);
6893 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006894
6895 if (i == num_streams - 1) {
6896 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
6897 } else {
6898 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
6899 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006900 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006901
Niels Möllerff40b142018-04-09 08:49:14 +02006902 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006903 }
6904
6905 FakeVideoSendStream* AddSendStream() {
6906 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
6907 }
6908
6909 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006910 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006911 EXPECT_TRUE(channel_->AddSendStream(sp));
6912 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006913 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006914 EXPECT_EQ(num_streams + 1, streams.size());
6915 return streams[streams.size() - 1];
6916 }
6917
6918 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006919 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006920 }
6921
6922 FakeVideoReceiveStream* AddRecvStream() {
6923 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
6924 }
6925
6926 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006927 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006928 EXPECT_TRUE(channel_->AddRecvStream(sp));
6929 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006930 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006931 EXPECT_EQ(num_streams + 1, streams.size());
6932 return streams[streams.size() - 1];
6933 }
6934
skvlad11a9cbf2016-10-07 11:53:05 -07006935 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006936 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006937 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
6938 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -07006939 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08006940 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02006941 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006942};
6943
eladalonf1841382017-06-12 01:16:46 -07006944TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006945 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
6946 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006947}
6948
eladalonf1841382017-06-12 01:16:46 -07006949TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006950 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
6951 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006952}
6953
6954// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07006955TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08006956 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
6957 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006958}
sprang429600d2017-01-26 06:12:26 -08006959
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006960TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006961 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6962 false);
6963}
6964
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006965TEST_F(WebRtcVideoChannelSimulcastTest,
6966 SetSendCodecsForConferenceModeScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006967 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6968 true);
6969}
6970
eladalonf1841382017-06-12 01:16:46 -07006971TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
Erik Språngb65aa012018-09-24 11:35:19 +02006972 webrtc::test::ScopedFieldTrials override_field_trials_(
6973 "WebRTC-SimulcastScreenshare/Enabled/");
sprang429600d2017-01-26 06:12:26 -08006974 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
6975 true);
6976}
6977
eladalonf1841382017-06-12 01:16:46 -07006978TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07006979 NoSimulcastScreenshareWithoutConference) {
Erik Språngb65aa012018-09-24 11:35:19 +02006980 webrtc::test::ScopedFieldTrials override_field_trials_(
6981 "WebRTC-SimulcastScreenshare/Enabled/");
sprangfe627f32017-03-29 08:24:59 -07006982 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6983 false);
6984}
6985
Yves Gereyb6a89422018-10-08 10:08:32 +02006986class WebRtcVideoFakeClock {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006987 public:
Yves Gereyb6a89422018-10-08 10:08:32 +02006988 WebRtcVideoFakeClock() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006989 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1)); // avoid time=0
6990 }
6991 rtc::ScopedFakeClock fake_clock_;
6992};
6993
Yves Gereyb6a89422018-10-08 10:08:32 +02006994// The fake clock needs to be initialized before the call, and not
6995// destroyed until after all threads spawned by the test have been stopped.
6996// This mixin ensures that.
6997class WebRtcVideoChannelTestWithClock : public WebRtcVideoFakeClock,
6998 public WebRtcVideoChannelBaseTest {};
6999
Jonas Oreland49ac5952018-09-26 16:04:32 +02007000TEST_F(WebRtcVideoChannelTestWithClock, GetSources) {
7001 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7002 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7003
7004 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7005
7006 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7007 rtc::SetBE32(packet1.data() + 8, kSsrc);
7008 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7009 EXPECT_TRUE(SetDefaultCodec());
7010 EXPECT_TRUE(SetSend(true));
7011 EXPECT_EQ(0, renderer_.num_rendered_frames());
7012 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
7013
7014 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7015 EXPECT_EQ(1u, sources.size());
7016 EXPECT_EQ(webrtc::RtpSourceType::SSRC, sources[0].source_type());
7017 int64_t timestamp1 = sources[0].timestamp_ms();
7018
7019 // a new packet.
7020 int64_t timeDeltaMs = 1;
7021 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
7022 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
7023 int64_t timestamp2 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7024 EXPECT_EQ(timestamp2, timestamp1 + timeDeltaMs);
7025
7026 // It only keeps 10s of history.
7027 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7028 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7029 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7030}
7031
7032TEST_F(WebRtcVideoChannelTestWithClock, GetContributingSources) {
7033 uint8_t data1[] = {0x81, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
7034 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7035
7036 uint32_t kCsrc = 4321u;
7037 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7038 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7039
7040 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7041 rtc::SetBE32(packet1.data() + 8, kSsrc);
7042 rtc::SetBE32(packet1.data() + 12, kCsrc);
7043 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7044 EXPECT_TRUE(SetDefaultCodec());
7045 EXPECT_TRUE(SetSend(true));
7046 EXPECT_EQ(0, renderer_.num_rendered_frames());
7047 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
7048
7049 {
7050 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7051 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7052 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7053 EXPECT_EQ(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7054 // 1 SSRC and 1 CSRC.
7055 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7056 [](const webrtc::RtpSource& source) {
7057 return source.source_type() ==
7058 webrtc::RtpSourceType::SSRC;
7059 }));
7060 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7061 [](const webrtc::RtpSource& source) {
7062 return source.source_type() ==
7063 webrtc::RtpSourceType::CSRC;
7064 }));
7065 }
7066 int64_t timestamp1 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7067
7068 // a new packet with only ssrc (i.e no csrc).
7069 uint8_t data2[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7070 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7071 rtc::CopyOnWriteBuffer packet2(data2, sizeof(data2));
7072 rtc::SetBE32(packet2.data() + 8, kSsrc);
7073
7074 int64_t timeDeltaMs = 1;
7075 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
7076 channel_->OnPacketReceived(&packet2, rtc::PacketTime());
7077
7078 {
7079 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7080 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7081 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7082 EXPECT_NE(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7083 // 1 SSRC and 1 CSRC.
7084 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7085 [](const webrtc::RtpSource& source) {
7086 return source.source_type() ==
7087 webrtc::RtpSourceType::SSRC;
7088 }));
7089 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7090 [](const webrtc::RtpSource& source) {
7091 return source.source_type() ==
7092 webrtc::RtpSourceType::CSRC;
7093 }));
7094 auto ssrcSource = std::find_if(
7095 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7096 return source.source_type() == webrtc::RtpSourceType::SSRC;
7097 });
7098 auto csrcSource = std::find_if(
7099 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7100 return source.source_type() == webrtc::RtpSourceType::CSRC;
7101 });
7102
7103 EXPECT_EQ(ssrcSource->timestamp_ms(), timestamp1 + timeDeltaMs);
7104 EXPECT_EQ(csrcSource->timestamp_ms(), timestamp1);
7105 }
7106
7107 // It only keeps 10s of history.
7108 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7109
7110 {
7111 ASSERT_EQ(1u, channel_->GetSources(kSsrc).size());
7112 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7113 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7114 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7115 [](const webrtc::RtpSource& source) {
7116 return source.source_type() ==
7117 webrtc::RtpSourceType::SSRC;
7118 }));
7119 EXPECT_EQ(0, std::count_if(sources.begin(), sources.end(),
7120 [](const webrtc::RtpSource& source) {
7121 return source.source_type() ==
7122 webrtc::RtpSourceType::CSRC;
7123 }));
7124 }
7125
7126 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7127 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7128 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7129}
7130
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007131} // namespace cricket