blob: 517266a11f99d4e3ab4860f4d8d51b9afc6297b5 [file] [log] [blame]
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00001/*
phoglund@webrtc.org78088c22012-02-07 14:56:45 +00002 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00003 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
Jonas Olssona4d87372019-07-05 19:08:33 +020011#include "modules/rtp_rtcp/source/rtp_sender.h"
12
kwiberg84be5112016-04-27 01:19:58 -070013#include <memory>
danilchapb8b6fbb2015-12-10 05:05:27 -080014#include <vector>
15
Karl Wiberg918f50c2018-07-05 11:40:33 +020016#include "absl/memory/memory.h"
Per Kjellandere11b7d22019-02-21 07:55:59 +010017#include "api/transport/field_trial_based_config.h"
Erik Språngf93eda12019-01-16 17:10:57 +010018#include "api/video/video_codec_constants.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020019#include "api/video/video_timing.h"
Elad Alon4a87e1c2017-10-03 16:11:34 +020020#include "logging/rtc_event_log/events/rtc_event.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020021#include "logging/rtc_event_log/mock/mock_rtc_event_log.h"
22#include "modules/rtp_rtcp/include/rtp_cvo.h"
23#include "modules/rtp_rtcp/include/rtp_header_extension_map.h"
Erik Språngaa59eca2019-07-24 14:52:55 +020024#include "modules/rtp_rtcp/include/rtp_packet_sender.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020025#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
26#include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
27#include "modules/rtp_rtcp/source/rtp_format_video_generic.h"
philipelb3e42a42018-09-13 10:57:14 +020028#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor.h"
29#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor_extension.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020030#include "modules/rtp_rtcp/source/rtp_header_extensions.h"
31#include "modules/rtp_rtcp/source/rtp_packet_received.h"
32#include "modules/rtp_rtcp/source/rtp_packet_to_send.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020033#include "modules/rtp_rtcp/source/rtp_sender_video.h"
34#include "modules/rtp_rtcp/source/rtp_utility.h"
35#include "rtc_base/arraysize.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020036#include "rtc_base/rate_limiter.h"
37#include "test/field_trial.h"
38#include "test/gmock.h"
39#include "test/gtest.h"
40#include "test/mock_transport.h"
Tommi25eb47c2019-08-29 16:39:05 +020041#include "test/rtp_header_parser.h"
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +000042
43namespace webrtc {
44
andrew@webrtc.org8a442592011-12-16 21:24:30 +000045namespace {
Elad Alond8d32482019-02-18 23:45:57 +010046enum : int { // The first valid value is 1.
47 kAbsoluteSendTimeExtensionId = 1,
48 kAudioLevelExtensionId,
Elad Alonccb9b752019-02-19 13:01:31 +010049 kGenericDescriptorId00,
50 kGenericDescriptorId01,
Elad Alond8d32482019-02-18 23:45:57 +010051 kMidExtensionId,
52 kRepairedRidExtensionId,
53 kRidExtensionId,
54 kTransmissionTimeOffsetExtensionId,
55 kTransportSequenceNumberExtensionId,
56 kVideoRotationExtensionId,
57 kVideoTimingExtensionId,
58};
59
andrew@webrtc.org8a442592011-12-16 21:24:30 +000060const int kPayload = 100;
Shao Changbine62202f2015-04-21 20:24:50 +080061const int kRtxPayload = 98;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000062const uint32_t kTimestamp = 10;
63const uint16_t kSeqNum = 33;
brandtr9dfff292016-11-14 05:14:50 -080064const uint32_t kSsrc = 725242;
Erik Språng9c771c22019-06-17 16:31:53 +020065const uint32_t kRtxSsrc = 12345;
66const uint32_t kFlexFecSsrc = 45678;
Erik Språng1fbfecd2019-08-26 19:00:05 +020067const uint16_t kTransportSequenceNumber = 1;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +000068const uint64_t kStartTime = 123456789;
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +000069const size_t kMaxPaddingSize = 224u;
Stefan Holmera246cfb2016-08-23 17:51:42 +020070const uint8_t kPayloadData[] = {47, 11, 32, 93, 89};
spranga8ae6f22017-09-04 07:23:56 -070071const int64_t kDefaultExpectedRetransmissionTimeMs = 125;
Amit Hilbuch77938e62018-12-21 09:23:38 -080072const char kNoRid[] = "";
73const char kNoMid[] = "";
andrew@webrtc.org8a442592011-12-16 21:24:30 +000074
Danil Chapovalov5e57b172016-09-02 19:15:59 +020075using ::testing::_;
Erik Språng30a276b2019-04-23 12:00:11 +020076using ::testing::AllOf;
Danil Chapovalov5e57b172016-09-02 19:15:59 +020077using ::testing::ElementsAreArray;
Erik Språng30a276b2019-04-23 12:00:11 +020078using ::testing::Field;
Erik Språng9c771c22019-06-17 16:31:53 +020079using ::testing::NiceMock;
Erik Språng478cb462019-06-26 15:49:27 +020080using ::testing::Pointee;
81using ::testing::Property;
Erik Språng214f5432019-06-20 15:09:58 +020082using ::testing::Return;
Erik Språng9c771c22019-06-17 16:31:53 +020083using ::testing::StrictMock;
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +000084
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000085uint64_t ConvertMsToAbsSendTime(int64_t time_ms) {
Stefan Holmer0a87ffc2015-10-21 13:41:48 +020086 return (((time_ms << 18) + 500) / 1000) & 0x00ffffff;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000087}
88
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +000089class LoopbackTransportTest : public webrtc::Transport {
90 public:
Petter Strandmark26bc6692018-05-29 08:43:35 +020091 LoopbackTransportTest() : total_bytes_sent_(0) {
danilchap12ba1862016-10-26 02:41:55 -070092 receivers_extensions_.Register(kRtpExtensionTransmissionTimeOffset,
93 kTransmissionTimeOffsetExtensionId);
94 receivers_extensions_.Register(kRtpExtensionAbsoluteSendTime,
95 kAbsoluteSendTimeExtensionId);
96 receivers_extensions_.Register(kRtpExtensionTransportSequenceNumber,
97 kTransportSequenceNumberExtensionId);
98 receivers_extensions_.Register(kRtpExtensionVideoRotation,
99 kVideoRotationExtensionId);
100 receivers_extensions_.Register(kRtpExtensionAudioLevel,
101 kAudioLevelExtensionId);
ilnik04f4d122017-06-19 07:18:55 -0700102 receivers_extensions_.Register(kRtpExtensionVideoTiming,
103 kVideoTimingExtensionId);
Steve Anton296a0ce2018-03-22 15:17:27 -0700104 receivers_extensions_.Register(kRtpExtensionMid, kMidExtensionId);
Elad Alonccb9b752019-02-19 13:01:31 +0100105 receivers_extensions_.Register(kRtpExtensionGenericFrameDescriptor00,
106 kGenericDescriptorId00);
107 receivers_extensions_.Register(kRtpExtensionGenericFrameDescriptor01,
108 kGenericDescriptorId01);
Amit Hilbuch77938e62018-12-21 09:23:38 -0800109 receivers_extensions_.Register(kRtpExtensionRtpStreamId, kRidExtensionId);
110 receivers_extensions_.Register(kRtpExtensionRepairedRtpStreamId,
111 kRepairedRidExtensionId);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000112 }
danilchap12ba1862016-10-26 02:41:55 -0700113
stefan1d8a5062015-10-02 03:39:33 -0700114 bool SendRtp(const uint8_t* data,
115 size_t len,
116 const PacketOptions& options) override {
Petter Strandmark26bc6692018-05-29 08:43:35 +0200117 last_options_ = options;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000118 total_bytes_sent_ += len;
danilchap12ba1862016-10-26 02:41:55 -0700119 sent_packets_.push_back(RtpPacketReceived(&receivers_extensions_));
120 EXPECT_TRUE(sent_packets_.back().Parse(data, len));
pbos2d566682015-09-28 09:59:31 -0700121 return true;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000122 }
danilchap162abd32015-12-10 02:39:40 -0800123 bool SendRtcp(const uint8_t* data, size_t len) override { return false; }
danilchap12ba1862016-10-26 02:41:55 -0700124 const RtpPacketReceived& last_sent_packet() { return sent_packets_.back(); }
125 int packets_sent() { return sent_packets_.size(); }
126
pbos@webrtc.org72491b92014-07-10 16:24:54 +0000127 size_t total_bytes_sent_;
Petter Strandmark26bc6692018-05-29 08:43:35 +0200128 PacketOptions last_options_;
danilchap12ba1862016-10-26 02:41:55 -0700129 std::vector<RtpPacketReceived> sent_packets_;
130
131 private:
132 RtpHeaderExtensionMap receivers_extensions_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000133};
134
Elad Alon4a87e1c2017-10-03 16:11:34 +0200135MATCHER_P(SameRtcEventTypeAs, value, "") {
136 return value == arg->GetType();
137}
138
Erik Språngf6468d22019-07-05 16:53:43 +0200139struct TestConfig {
Erik Språngf5815fa2019-08-21 14:27:31 +0200140 explicit TestConfig(bool with_overhead) : with_overhead(with_overhead) {}
Erik Språngf6468d22019-07-05 16:53:43 +0200141 bool with_overhead = false;
Erik Språngf6468d22019-07-05 16:53:43 +0200142};
143
144std::string ToFieldTrialString(TestConfig config) {
145 std::string field_trials;
146 if (config.with_overhead) {
147 field_trials += "WebRTC-SendSideBwe-WithOverhead/Enabled/";
148 }
Erik Språngf6468d22019-07-05 16:53:43 +0200149 return field_trials;
150}
151
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000152} // namespace
153
Erik Språngaa59eca2019-07-24 14:52:55 +0200154class MockRtpPacketPacer : public RtpPacketSender {
sprangebbf8a82015-09-21 15:11:14 -0700155 public:
Erik Språng59b86542019-06-23 18:24:46 +0200156 MockRtpPacketPacer() {}
157 virtual ~MockRtpPacketPacer() {}
158
159 MOCK_METHOD1(EnqueuePacket, void(std::unique_ptr<RtpPacketToSend>));
sprangebbf8a82015-09-21 15:11:14 -0700160
Erik Språngaa59eca2019-07-24 14:52:55 +0200161 MOCK_METHOD2(CreateProbeCluster, void(int bitrate_bps, int cluster_id));
162
163 MOCK_METHOD0(Pause, void());
164 MOCK_METHOD0(Resume, void());
165 MOCK_METHOD1(SetCongestionWindow,
166 void(absl::optional<int64_t> congestion_window_bytes));
167 MOCK_METHOD1(UpdateOutstandingData, void(int64_t outstanding_bytes));
168 MOCK_METHOD1(SetAccountForAudioPackets, void(bool account_for_audio));
sprangebbf8a82015-09-21 15:11:14 -0700169};
170
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200171class MockSendSideDelayObserver : public SendSideDelayObserver {
172 public:
Henrik Boström9fe18342019-05-16 18:38:20 +0200173 MOCK_METHOD4(SendSideDelayUpdated, void(int, int, uint64_t, uint32_t));
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200174};
175
asapersson35151f32016-05-02 23:44:01 -0700176class MockSendPacketObserver : public SendPacketObserver {
177 public:
178 MOCK_METHOD3(OnSendPacket, void(uint16_t, int64_t, uint32_t));
179};
180
Stefan Holmera246cfb2016-08-23 17:51:42 +0200181class MockTransportFeedbackObserver : public TransportFeedbackObserver {
182 public:
Erik Språng30a276b2019-04-23 12:00:11 +0200183 MOCK_METHOD1(OnAddPacket, void(const RtpPacketSendInfo&));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200184 MOCK_METHOD1(OnTransportFeedback, void(const rtcp::TransportFeedback&));
elad.alonf9490002017-03-06 05:32:21 -0800185 MOCK_CONST_METHOD0(GetTransportFeedbackVector, std::vector<PacketFeedback>());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200186};
187
minyue3a407ee2017-04-03 01:10:33 -0700188class MockOverheadObserver : public OverheadObserver {
189 public:
190 MOCK_METHOD1(OnOverheadChanged, void(size_t overhead_bytes_per_packet));
191};
192
Erik Språngf6468d22019-07-05 16:53:43 +0200193class RtpSenderTest : public ::testing::TestWithParam<TestConfig> {
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000194 protected:
195 RtpSenderTest()
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000196 : fake_clock_(kStartTime),
terelius429c3452016-01-21 05:42:04 -0800197 mock_rtc_event_log_(),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000198 mock_paced_sender_(),
sprangcd349d92016-07-13 09:11:28 -0700199 retransmission_rate_limiter_(&fake_clock_, 1000),
Erik Språng4580ca22019-07-04 10:38:43 +0200200 flexfec_sender_(0,
201 kFlexFecSsrc,
202 kSsrc,
203 "",
204 std::vector<RtpExtension>(),
205 std::vector<RtpExtensionSize>(),
206 nullptr,
207 &fake_clock_),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000208 rtp_sender_(),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000209 transport_(),
minyue3a407ee2017-04-03 01:10:33 -0700210 kMarkerBit(true),
Erik Språngf6468d22019-07-05 16:53:43 +0200211 field_trials_(ToFieldTrialString(GetParam())) {}
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000212
Erik Språng7b52f102018-02-07 14:37:37 +0100213 void SetUp() override { SetUpRtpSender(true, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200214
Erik Språng7b52f102018-02-07 14:37:37 +0100215 void SetUpRtpSender(bool pacer, bool populate_network2) {
Erik Språng4580ca22019-07-04 10:38:43 +0200216 RtpRtcp::Configuration config;
217 config.clock = &fake_clock_;
218 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200219 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200220 config.rtx_send_ssrc = kRtxSsrc;
221 config.flexfec_sender = &flexfec_sender_;
Erik Språng4580ca22019-07-04 10:38:43 +0200222 config.event_log = &mock_rtc_event_log_;
223 config.send_packet_observer = &send_packet_observer_;
224 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
225 config.paced_sender = pacer ? &mock_paced_sender_ : nullptr;
226 config.populate_network2_timestamp = populate_network2;
227 rtp_sender_.reset(new RTPSender(config));
brandtr9dfff292016-11-14 05:14:50 -0800228 rtp_sender_->SetSequenceNumber(kSeqNum);
danilchap71fead22016-08-18 02:01:49 -0700229 rtp_sender_->SetTimestampOffset(0);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000230 }
231
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000232 SimulatedClock fake_clock_;
Erik Språng9c771c22019-06-17 16:31:53 +0200233 NiceMock<MockRtcEventLog> mock_rtc_event_log_;
Erik Språng59b86542019-06-23 18:24:46 +0200234 MockRtpPacketPacer mock_paced_sender_;
Erik Språng9c771c22019-06-17 16:31:53 +0200235 StrictMock<MockSendPacketObserver> send_packet_observer_;
236 StrictMock<MockTransportFeedbackObserver> feedback_observer_;
sprangcd349d92016-07-13 09:11:28 -0700237 RateLimiter retransmission_rate_limiter_;
Erik Språng4580ca22019-07-04 10:38:43 +0200238 FlexfecSender flexfec_sender_;
kwiberg84be5112016-04-27 01:19:58 -0700239 std::unique_ptr<RTPSender> rtp_sender_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000240 LoopbackTransportTest transport_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000241 const bool kMarkerBit;
minyue3a407ee2017-04-03 01:10:33 -0700242 test::ScopedFieldTrials field_trials_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000243
danilchapb6f1fb52016-10-19 06:11:39 -0700244 std::unique_ptr<RtpPacketToSend> BuildRtpPacket(int payload_type,
245 bool marker_bit,
246 uint32_t timestamp,
247 int64_t capture_time_ms) {
248 auto packet = rtp_sender_->AllocatePacket();
249 packet->SetPayloadType(payload_type);
Erik Språng60ffc312019-07-30 22:03:49 +0200250 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
danilchapb6f1fb52016-10-19 06:11:39 -0700251 packet->SetMarker(marker_bit);
252 packet->SetTimestamp(timestamp);
253 packet->set_capture_time_ms(capture_time_ms);
254 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
255 return packet;
256 }
257
Erik Språngf6468d22019-07-05 16:53:43 +0200258 std::unique_ptr<RtpPacketToSend> SendPacket(int64_t capture_time_ms,
259 int payload_length) {
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000260 uint32_t timestamp = capture_time_ms * 90;
danilchapb6f1fb52016-10-19 06:11:39 -0700261 auto packet =
262 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
263 packet->AllocatePayload(payload_length);
Erik Språng70768f42019-08-27 18:16:26 +0200264 packet->set_allow_retransmission(true);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000265
266 // Packet should be stored in a send bucket.
Erik Språngf6468d22019-07-05 16:53:43 +0200267 EXPECT_TRUE(rtp_sender_->SendToNetwork(
Erik Språng70768f42019-08-27 18:16:26 +0200268 absl::make_unique<RtpPacketToSend>(*packet)));
Erik Språngf6468d22019-07-05 16:53:43 +0200269 return packet;
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000270 }
asapersson35151f32016-05-02 23:44:01 -0700271
Erik Språngf6468d22019-07-05 16:53:43 +0200272 std::unique_ptr<RtpPacketToSend> SendGenericPacket() {
asapersson35151f32016-05-02 23:44:01 -0700273 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
Erik Språngf6468d22019-07-05 16:53:43 +0200274 return SendPacket(kCaptureTimeMs, sizeof(kPayloadData));
asapersson35151f32016-05-02 23:44:01 -0700275 }
Steve Anton2bac7da2019-07-21 15:04:21 -0400276
Erik Språng4208a132019-08-26 08:58:45 +0200277 size_t GenerateAndSendPadding(size_t target_size_bytes) {
278 size_t generated_bytes = 0;
279 for (auto& packet : rtp_sender_->GeneratePadding(target_size_bytes)) {
280 generated_bytes += packet->payload_size() + packet->padding_size();
281 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
282 }
283 return generated_bytes;
284 }
285
Steve Anton2bac7da2019-07-21 15:04:21 -0400286 // The following are helpers for configuring the RTPSender. They must be
287 // called before sending any packets.
288
289 // Enable the retransmission stream with sizable packet storage.
290 void EnableRtx() {
291 // RTX needs to be able to read the source packets from the packet store.
292 // Pick a number of packets to store big enough for any unit test.
293 constexpr uint16_t kNumberOfPacketsToStore = 100;
294 rtp_sender_->SetStorePacketsStatus(true, kNumberOfPacketsToStore);
295 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
296 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
297 }
298
299 // Enable sending of the MID header extension for both the primary SSRC and
300 // the RTX SSRC.
301 void EnableMidSending(const std::string& mid) {
302 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionMid, kMidExtensionId);
303 rtp_sender_->SetMid(mid);
304 }
305
306 // Enable sending of the RSID header extension for the primary SSRC and the
307 // RRSID header extension for the RTX SSRC.
308 void EnableRidSending(const std::string& rid) {
309 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionRtpStreamId,
310 kRidExtensionId);
311 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionRepairedRtpStreamId,
312 kRepairedRidExtensionId);
313 rtp_sender_->SetRid(rid);
314 }
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000315};
316
Peter Boströme23e7372015-10-08 11:44:14 +0200317// TODO(pbos): Move tests over from WithoutPacer to RtpSenderTest as this is our
318// default code path.
319class RtpSenderTestWithoutPacer : public RtpSenderTest {
320 public:
Erik Språng7b52f102018-02-07 14:37:37 +0100321 void SetUp() override { SetUpRtpSender(false, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200322};
323
minyue3a407ee2017-04-03 01:10:33 -0700324TEST_P(RtpSenderTestWithoutPacer, AllocatePacketSetCsrc) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200325 // Configure rtp_sender with csrc.
326 std::vector<uint32_t> csrcs;
327 csrcs.push_back(0x23456789);
328 rtp_sender_->SetCsrcs(csrcs);
329
330 auto packet = rtp_sender_->AllocatePacket();
331
332 ASSERT_TRUE(packet);
333 EXPECT_EQ(rtp_sender_->SSRC(), packet->Ssrc());
334 EXPECT_EQ(csrcs, packet->Csrcs());
335}
336
minyue3a407ee2017-04-03 01:10:33 -0700337TEST_P(RtpSenderTestWithoutPacer, AllocatePacketReserveExtensions) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200338 // Configure rtp_sender with extensions.
339 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
340 kRtpExtensionTransmissionTimeOffset,
341 kTransmissionTimeOffsetExtensionId));
342 ASSERT_EQ(
343 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
344 kAbsoluteSendTimeExtensionId));
345 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
346 kAudioLevelExtensionId));
347 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
348 kRtpExtensionTransportSequenceNumber,
349 kTransportSequenceNumberExtensionId));
350 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
351 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
352
353 auto packet = rtp_sender_->AllocatePacket();
354
355 ASSERT_TRUE(packet);
356 // Preallocate BWE extensions RtpSender set itself.
357 EXPECT_TRUE(packet->HasExtension<TransmissionOffset>());
358 EXPECT_TRUE(packet->HasExtension<AbsoluteSendTime>());
359 EXPECT_TRUE(packet->HasExtension<TransportSequenceNumber>());
360 // Do not allocate media specific extensions.
361 EXPECT_FALSE(packet->HasExtension<AudioLevel>());
362 EXPECT_FALSE(packet->HasExtension<VideoOrientation>());
363}
364
minyue3a407ee2017-04-03 01:10:33 -0700365TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberAdvanceSequenceNumber) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200366 auto packet = rtp_sender_->AllocatePacket();
367 ASSERT_TRUE(packet);
368 const uint16_t sequence_number = rtp_sender_->SequenceNumber();
369
370 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
371
372 EXPECT_EQ(sequence_number, packet->SequenceNumber());
373 EXPECT_EQ(sequence_number + 1, rtp_sender_->SequenceNumber());
374}
375
minyue3a407ee2017-04-03 01:10:33 -0700376TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberFailsOnNotSending) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200377 auto packet = rtp_sender_->AllocatePacket();
378 ASSERT_TRUE(packet);
379
380 rtp_sender_->SetSendingMediaStatus(false);
381 EXPECT_FALSE(rtp_sender_->AssignSequenceNumber(packet.get()));
382}
383
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100384TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberMayAllowPaddingOnVideo) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200385 constexpr size_t kPaddingSize = 100;
386 auto packet = rtp_sender_->AllocatePacket();
387 ASSERT_TRUE(packet);
388
Erik Språng4208a132019-08-26 08:58:45 +0200389 ASSERT_TRUE(rtp_sender_->GeneratePadding(kPaddingSize).empty());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200390 packet->SetMarker(false);
391 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100392 // Packet without marker bit doesn't allow padding on video stream.
Erik Språng4208a132019-08-26 08:58:45 +0200393 ASSERT_TRUE(rtp_sender_->GeneratePadding(kPaddingSize).empty());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200394
395 packet->SetMarker(true);
396 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
397 // Packet with marker bit allows send padding.
Erik Språng4208a132019-08-26 08:58:45 +0200398 ASSERT_FALSE(rtp_sender_->GeneratePadding(kPaddingSize).empty());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200399}
400
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100401TEST_P(RtpSenderTest, AssignSequenceNumberAllowsPaddingOnAudio) {
402 MockTransport transport;
Erik Språng4580ca22019-07-04 10:38:43 +0200403 RtpRtcp::Configuration config;
404 config.audio = true;
405 config.clock = &fake_clock_;
406 config.outgoing_transport = &transport;
407 config.paced_sender = &mock_paced_sender_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200408 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200409 config.event_log = &mock_rtc_event_log_;
410 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
411 rtp_sender_ = absl::make_unique<RTPSender>(config);
412
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100413 rtp_sender_->SetTimestampOffset(0);
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100414
415 std::unique_ptr<RtpPacketToSend> audio_packet = rtp_sender_->AllocatePacket();
416 // Padding on audio stream allowed regardless of marker in the last packet.
417 audio_packet->SetMarker(false);
418 audio_packet->SetPayloadType(kPayload);
419 rtp_sender_->AssignSequenceNumber(audio_packet.get());
420
421 const size_t kPaddingSize = 59;
422 EXPECT_CALL(transport, SendRtp(_, kPaddingSize + kRtpHeaderSize, _))
Erik Språng214f5432019-06-20 15:09:58 +0200423 .WillOnce(Return(true));
Erik Språng4208a132019-08-26 08:58:45 +0200424 EXPECT_EQ(kPaddingSize, GenerateAndSendPadding(kPaddingSize));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100425
426 // Requested padding size is too small, will send a larger one.
427 const size_t kMinPaddingSize = 50;
428 EXPECT_CALL(transport, SendRtp(_, kMinPaddingSize + kRtpHeaderSize, _))
Erik Språng214f5432019-06-20 15:09:58 +0200429 .WillOnce(Return(true));
Erik Språng4208a132019-08-26 08:58:45 +0200430 EXPECT_EQ(kMinPaddingSize, GenerateAndSendPadding(kMinPaddingSize - 5));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100431}
432
minyue3a407ee2017-04-03 01:10:33 -0700433TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberSetPaddingTimestamps) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200434 constexpr size_t kPaddingSize = 100;
435 auto packet = rtp_sender_->AllocatePacket();
436 ASSERT_TRUE(packet);
437 packet->SetMarker(true);
438 packet->SetTimestamp(kTimestamp);
439
440 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
Erik Språng4208a132019-08-26 08:58:45 +0200441 auto padding_packets = rtp_sender_->GeneratePadding(kPaddingSize);
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200442
Erik Språng4208a132019-08-26 08:58:45 +0200443 ASSERT_EQ(1u, padding_packets.size());
danilchap12ba1862016-10-26 02:41:55 -0700444 // Verify padding packet timestamp.
Erik Språng4208a132019-08-26 08:58:45 +0200445 EXPECT_EQ(kTimestamp, padding_packets[0]->Timestamp());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200446}
447
minyue3a407ee2017-04-03 01:10:33 -0700448TEST_P(RtpSenderTestWithoutPacer,
449 TransportFeedbackObserverGetsCorrectByteCount) {
450 constexpr int kRtpOverheadBytesPerPacket = 12 + 8;
Erik Språng9c771c22019-06-17 16:31:53 +0200451 NiceMock<MockOverheadObserver> mock_overhead_observer;
Erik Språng4580ca22019-07-04 10:38:43 +0200452
453 RtpRtcp::Configuration config;
454 config.clock = &fake_clock_;
455 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200456 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200457 config.transport_feedback_callback = &feedback_observer_;
458 config.event_log = &mock_rtc_event_log_;
459 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
460 config.overhead_observer = &mock_overhead_observer;
461 rtp_sender_ = absl::make_unique<RTPSender>(config);
462
minyue3a407ee2017-04-03 01:10:33 -0700463 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
464 kRtpExtensionTransportSequenceNumber,
465 kTransportSequenceNumberExtensionId));
minyue3a407ee2017-04-03 01:10:33 -0700466
467 const size_t expected_bytes =
Erik Språngf6468d22019-07-05 16:53:43 +0200468 GetParam().with_overhead
469 ? sizeof(kPayloadData) + kRtpOverheadBytesPerPacket
470 : sizeof(kPayloadData);
minyue3a407ee2017-04-03 01:10:33 -0700471
472 EXPECT_CALL(feedback_observer_,
Erik Språng30a276b2019-04-23 12:00:11 +0200473 OnAddPacket(AllOf(
474 Field(&RtpPacketSendInfo::ssrc, rtp_sender_->SSRC()),
475 Field(&RtpPacketSendInfo::transport_sequence_number,
476 kTransportSequenceNumber),
477 Field(&RtpPacketSendInfo::rtp_sequence_number,
478 rtp_sender_->SequenceNumber()),
479 Field(&RtpPacketSendInfo::length, expected_bytes),
480 Field(&RtpPacketSendInfo::pacing_info, PacedPacketInfo()))))
minyue3a407ee2017-04-03 01:10:33 -0700481 .Times(1);
482 EXPECT_CALL(mock_overhead_observer,
483 OnOverheadChanged(kRtpOverheadBytesPerPacket))
484 .Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100485 SendGenericPacket();
minyue3a407ee2017-04-03 01:10:33 -0700486}
487
488TEST_P(RtpSenderTestWithoutPacer, SendsPacketsWithTransportSequenceNumber) {
Erik Språng4580ca22019-07-04 10:38:43 +0200489 RtpRtcp::Configuration config;
490 config.clock = &fake_clock_;
491 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200492 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200493 config.transport_feedback_callback = &feedback_observer_;
494 config.event_log = &mock_rtc_event_log_;
495 config.send_packet_observer = &send_packet_observer_;
496 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
497 rtp_sender_ = absl::make_unique<RTPSender>(config);
498
Stefan Holmerf5dca482016-01-27 12:58:51 +0100499 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
500 kRtpExtensionTransportSequenceNumber,
501 kTransportSequenceNumberExtensionId));
502
asapersson35151f32016-05-02 23:44:01 -0700503 EXPECT_CALL(send_packet_observer_,
504 OnSendPacket(kTransportSequenceNumber, _, _))
505 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700506
507 EXPECT_CALL(feedback_observer_,
Erik Språng30a276b2019-04-23 12:00:11 +0200508 OnAddPacket(AllOf(
509 Field(&RtpPacketSendInfo::ssrc, rtp_sender_->SSRC()),
510 Field(&RtpPacketSendInfo::transport_sequence_number,
511 kTransportSequenceNumber),
512 Field(&RtpPacketSendInfo::rtp_sequence_number,
513 rtp_sender_->SequenceNumber()),
514 Field(&RtpPacketSendInfo::pacing_info, PacedPacketInfo()))))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200515 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700516
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100517 SendGenericPacket();
Stefan Holmerf5dca482016-01-27 12:58:51 +0100518
danilchap12ba1862016-10-26 02:41:55 -0700519 const auto& packet = transport_.last_sent_packet();
520 uint16_t transport_seq_no;
521 ASSERT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
522 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200523 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200524 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200525}
526
527TEST_P(RtpSenderTestWithoutPacer, PacketOptionsNoRetransmission) {
Erik Språng4580ca22019-07-04 10:38:43 +0200528 RtpRtcp::Configuration config;
529 config.clock = &fake_clock_;
530 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200531 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200532 config.transport_feedback_callback = &feedback_observer_;
533 config.event_log = &mock_rtc_event_log_;
534 config.send_packet_observer = &send_packet_observer_;
535 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
536 rtp_sender_ = absl::make_unique<RTPSender>(config);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200537
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100538 SendGenericPacket();
Petter Strandmark26bc6692018-05-29 08:43:35 +0200539
540 EXPECT_FALSE(transport_.last_options_.is_retransmit);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100541}
542
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200543TEST_P(RtpSenderTestWithoutPacer,
544 SetsIncludedInFeedbackWhenTransportSequenceNumberExtensionIsRegistered) {
545 SetUpRtpSender(false, false);
546 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber,
547 kTransportSequenceNumberExtensionId);
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200548 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100549 SendGenericPacket();
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200550 EXPECT_TRUE(transport_.last_options_.included_in_feedback);
551}
552
553TEST_P(
554 RtpSenderTestWithoutPacer,
555 SetsIncludedInAllocationWhenTransportSequenceNumberExtensionIsRegistered) {
556 SetUpRtpSender(false, false);
557 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber,
558 kTransportSequenceNumberExtensionId);
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200559 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100560 SendGenericPacket();
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200561 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
562}
563
564TEST_P(RtpSenderTestWithoutPacer,
565 SetsIncludedInAllocationWhenForcedAsPartOfAllocation) {
566 SetUpRtpSender(false, false);
567 rtp_sender_->SetAsPartOfAllocation(true);
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100568 SendGenericPacket();
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200569 EXPECT_FALSE(transport_.last_options_.included_in_feedback);
570 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
571}
572
573TEST_P(RtpSenderTestWithoutPacer, DoesnSetIncludedInAllocationByDefault) {
574 SetUpRtpSender(false, false);
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100575 SendGenericPacket();
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200576 EXPECT_FALSE(transport_.last_options_.included_in_feedback);
577 EXPECT_FALSE(transport_.last_options_.included_in_allocation);
stefana23fc622016-07-28 07:56:38 -0700578}
asapersson35151f32016-05-02 23:44:01 -0700579
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200580TEST_P(RtpSenderTestWithoutPacer, OnSendSideDelayUpdated) {
Erik Språng9c771c22019-06-17 16:31:53 +0200581 StrictMock<MockSendSideDelayObserver> send_side_delay_observer_;
Erik Språng4580ca22019-07-04 10:38:43 +0200582
583 RtpRtcp::Configuration config;
584 config.clock = &fake_clock_;
585 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200586 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200587 config.send_side_delay_observer = &send_side_delay_observer_;
588 config.event_log = &mock_rtc_event_log_;
589 rtp_sender_ = absl::make_unique<RTPSender>(config);
590
Niels Möller5fe95102019-03-04 16:49:25 +0100591 PlayoutDelayOracle playout_delay_oracle;
Niels Möller59ab1cf2019-02-06 22:48:11 +0100592 RTPSenderVideo rtp_sender_video(&fake_clock_, rtp_sender_.get(), nullptr,
Elad Alona0e99432019-05-24 13:50:56 +0200593 &playout_delay_oracle, nullptr, false, false,
Andrei Dumitru09872732019-08-29 12:00:29 -0700594 false, FieldTrialBasedConfig());
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200595
596 const uint8_t kPayloadType = 127;
Niels Möller8a40edd2019-01-24 18:04:44 +0100597 const char payload_name[] = "GENERIC";
Niels Möller59ab1cf2019-02-06 22:48:11 +0100598
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +0200599 rtp_sender_video.RegisterPayloadType(kPayloadType, payload_name,
600 /*raw_payload=*/false);
Niels Möller59ab1cf2019-02-06 22:48:11 +0100601
602 const uint32_t kCaptureTimeMsToRtpTimestamp = 90; // 90 kHz clock
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200603 RTPVideoHeader video_header;
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200604
Henrik Boström9fe18342019-05-16 18:38:20 +0200605 // Send packet with 10 ms send-side delay. The average, max and total should
606 // be 10 ms.
607 EXPECT_CALL(send_side_delay_observer_,
608 SendSideDelayUpdated(10, 10, 10, kSsrc))
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200609 .Times(1);
610 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
611 fake_clock_.AdvanceTimeMilliseconds(10);
Niels Möller59ab1cf2019-02-06 22:48:11 +0100612 EXPECT_TRUE(rtp_sender_video.SendVideo(
Niels Möller8f7ce222019-03-21 15:43:58 +0100613 VideoFrameType::kVideoFrameKey, kPayloadType,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200614 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
Niels Möller59ab1cf2019-02-06 22:48:11 +0100615 kPayloadData, sizeof(kPayloadData), nullptr, &video_header,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200616 kDefaultExpectedRetransmissionTimeMs));
617
Henrik Boström9fe18342019-05-16 18:38:20 +0200618 // Send another packet with 20 ms delay. The average, max and total should be
619 // 15, 20 and 30 ms respectively.
620 EXPECT_CALL(send_side_delay_observer_,
621 SendSideDelayUpdated(15, 20, 30, kSsrc))
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200622 .Times(1);
623 fake_clock_.AdvanceTimeMilliseconds(10);
Niels Möller59ab1cf2019-02-06 22:48:11 +0100624 EXPECT_TRUE(rtp_sender_video.SendVideo(
Niels Möller8f7ce222019-03-21 15:43:58 +0100625 VideoFrameType::kVideoFrameKey, kPayloadType,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200626 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
Niels Möller59ab1cf2019-02-06 22:48:11 +0100627 kPayloadData, sizeof(kPayloadData), nullptr, &video_header,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200628 kDefaultExpectedRetransmissionTimeMs));
629
630 // Send another packet at the same time, which replaces the last packet.
631 // Since this packet has 0 ms delay, the average is now 5 ms and max is 10 ms.
Henrik Boström9fe18342019-05-16 18:38:20 +0200632 // The total counter stays the same though.
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200633 // TODO(terelius): Is is not clear that this is the right behavior.
Henrik Boström9fe18342019-05-16 18:38:20 +0200634 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(5, 10, 30, kSsrc))
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200635 .Times(1);
636 capture_time_ms = fake_clock_.TimeInMilliseconds();
Niels Möller59ab1cf2019-02-06 22:48:11 +0100637 EXPECT_TRUE(rtp_sender_video.SendVideo(
Niels Möller8f7ce222019-03-21 15:43:58 +0100638 VideoFrameType::kVideoFrameKey, kPayloadType,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200639 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
Niels Möller59ab1cf2019-02-06 22:48:11 +0100640 kPayloadData, sizeof(kPayloadData), nullptr, &video_header,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200641 kDefaultExpectedRetransmissionTimeMs));
642
643 // Send a packet 1 second later. The earlier packets should have timed
Henrik Boström9fe18342019-05-16 18:38:20 +0200644 // out, so both max and average should be the delay of this packet. The total
645 // keeps increasing.
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200646 fake_clock_.AdvanceTimeMilliseconds(1000);
647 capture_time_ms = fake_clock_.TimeInMilliseconds();
648 fake_clock_.AdvanceTimeMilliseconds(1);
Henrik Boström9fe18342019-05-16 18:38:20 +0200649 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(1, 1, 31, kSsrc))
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200650 .Times(1);
Niels Möller59ab1cf2019-02-06 22:48:11 +0100651 EXPECT_TRUE(rtp_sender_video.SendVideo(
Niels Möller8f7ce222019-03-21 15:43:58 +0100652 VideoFrameType::kVideoFrameKey, kPayloadType,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200653 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
Niels Möller59ab1cf2019-02-06 22:48:11 +0100654 kPayloadData, sizeof(kPayloadData), nullptr, &video_header,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200655 kDefaultExpectedRetransmissionTimeMs));
656}
657
minyue3a407ee2017-04-03 01:10:33 -0700658TEST_P(RtpSenderTestWithoutPacer, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700659 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
660 kRtpExtensionTransportSequenceNumber,
661 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700662 EXPECT_CALL(send_packet_observer_,
663 OnSendPacket(kTransportSequenceNumber, _, _))
664 .Times(1);
665
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100666 SendGenericPacket();
asapersson35151f32016-05-02 23:44:01 -0700667}
668
minyue3a407ee2017-04-03 01:10:33 -0700669TEST_P(RtpSenderTest, SendsPacketsWithTransportSequenceNumber) {
Erik Språng4580ca22019-07-04 10:38:43 +0200670 RtpRtcp::Configuration config;
671 config.clock = &fake_clock_;
672 config.outgoing_transport = &transport_;
673 config.paced_sender = &mock_paced_sender_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200674 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200675 config.transport_feedback_callback = &feedback_observer_;
676 config.event_log = &mock_rtc_event_log_;
677 config.send_packet_observer = &send_packet_observer_;
678 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
679 rtp_sender_ = absl::make_unique<RTPSender>(config);
680
brandtr9dfff292016-11-14 05:14:50 -0800681 rtp_sender_->SetSequenceNumber(kSeqNum);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200682 rtp_sender_->SetStorePacketsStatus(true, 10);
683 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
684 kRtpExtensionTransportSequenceNumber,
685 kTransportSequenceNumberExtensionId));
686
Stefan Holmera246cfb2016-08-23 17:51:42 +0200687 EXPECT_CALL(send_packet_observer_,
688 OnSendPacket(kTransportSequenceNumber, _, _))
689 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700690 EXPECT_CALL(feedback_observer_,
Erik Språng30a276b2019-04-23 12:00:11 +0200691 OnAddPacket(AllOf(
692 Field(&RtpPacketSendInfo::ssrc, rtp_sender_->SSRC()),
693 Field(&RtpPacketSendInfo::transport_sequence_number,
694 kTransportSequenceNumber),
695 Field(&RtpPacketSendInfo::rtp_sequence_number,
696 rtp_sender_->SequenceNumber()),
697 Field(&RtpPacketSendInfo::pacing_info, PacedPacketInfo()))))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200698 .Times(1);
699
Erik Språngf5815fa2019-08-21 14:27:31 +0200700 EXPECT_CALL(
701 mock_paced_sender_,
702 EnqueuePacket(
703 AllOf(Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
704 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))));
705 auto packet = SendGenericPacket();
706 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
707 // Transport sequence number is set by PacketRouter, before TrySendPacket().
708 packet->SetExtension<TransportSequenceNumber>(kTransportSequenceNumber);
709 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200710
danilchap12ba1862016-10-26 02:41:55 -0700711 uint16_t transport_seq_no;
Erik Språngf5815fa2019-08-21 14:27:31 +0200712 EXPECT_TRUE(
713 transport_.last_sent_packet().GetExtension<TransportSequenceNumber>(
714 &transport_seq_no));
danilchap12ba1862016-10-26 02:41:55 -0700715 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200716 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200717}
718
Erik Språng7b52f102018-02-07 14:37:37 +0100719TEST_P(RtpSenderTest, WritesPacerExitToTimingExtension) {
ilnik04f4d122017-06-19 07:18:55 -0700720 rtp_sender_->SetStorePacketsStatus(true, 10);
721 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
722 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
723 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
724 auto packet = rtp_sender_->AllocatePacket();
725 packet->SetPayloadType(kPayload);
726 packet->SetMarker(true);
727 packet->SetTimestamp(kTimestamp);
728 packet->set_capture_time_ms(capture_time_ms);
ilnik2edc6842017-07-06 03:06:50 -0700729 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
ilnik04f4d122017-06-19 07:18:55 -0700730 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
731 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
732 size_t packet_size = packet->size();
ilnik04f4d122017-06-19 07:18:55 -0700733
734 const int kStoredTimeInMs = 100;
Erik Språngf5815fa2019-08-21 14:27:31 +0200735 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Erik Språng70768f42019-08-27 18:16:26 +0200736 packet->set_allow_retransmission(true);
Erik Språngf5815fa2019-08-21 14:27:31 +0200737 EXPECT_CALL(mock_paced_sender_,
738 EnqueuePacket(Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc))));
Erik Språng70768f42019-08-27 18:16:26 +0200739 EXPECT_TRUE(
740 rtp_sender_->SendToNetwork(absl::make_unique<RtpPacketToSend>(*packet)));
Erik Språngf5815fa2019-08-21 14:27:31 +0200741 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
742 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
ilnik04f4d122017-06-19 07:18:55 -0700743 EXPECT_EQ(1, transport_.packets_sent());
744 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
745
danilchapce251812017-09-11 12:24:41 -0700746 VideoSendTiming video_timing;
747 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
748 &video_timing));
749 EXPECT_EQ(kStoredTimeInMs, video_timing.pacer_exit_delta_ms);
Erik Språng7b52f102018-02-07 14:37:37 +0100750}
ilnik04f4d122017-06-19 07:18:55 -0700751
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100752TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtensionWithPacer) {
753 SetUpRtpSender(/*pacer=*/true, /*populate_network2=*/true);
Erik Språng7b52f102018-02-07 14:37:37 +0100754 rtp_sender_->SetStorePacketsStatus(true, 10);
755 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
756 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
757 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
758 auto packet = rtp_sender_->AllocatePacket();
759 packet->SetPayloadType(kPayload);
760 packet->SetMarker(true);
761 packet->SetTimestamp(kTimestamp);
762 packet->set_capture_time_ms(capture_time_ms);
763 const uint16_t kPacerExitMs = 1234u;
764 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, kPacerExitMs, 0u, 0u, true};
765 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
766 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
767 size_t packet_size = packet->size();
768
769 const int kStoredTimeInMs = 100;
Erik Språngf6468d22019-07-05 16:53:43 +0200770
Erik Språngf6468d22019-07-05 16:53:43 +0200771 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Erik Språng70768f42019-08-27 18:16:26 +0200772 packet->set_allow_retransmission(true);
Erik Språngf6468d22019-07-05 16:53:43 +0200773 EXPECT_CALL(
774 mock_paced_sender_,
775 EnqueuePacket(Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc))));
776 EXPECT_TRUE(rtp_sender_->SendToNetwork(
Erik Språng70768f42019-08-27 18:16:26 +0200777 absl::make_unique<RtpPacketToSend>(*packet)));
Erik Språngf6468d22019-07-05 16:53:43 +0200778 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
779 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +0200780
Erik Språng7b52f102018-02-07 14:37:37 +0100781 EXPECT_EQ(1, transport_.packets_sent());
ilnik04f4d122017-06-19 07:18:55 -0700782 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
783
Erik Språng7b52f102018-02-07 14:37:37 +0100784 VideoSendTiming video_timing;
danilchapce251812017-09-11 12:24:41 -0700785 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
786 &video_timing));
Erik Språng7b52f102018-02-07 14:37:37 +0100787 EXPECT_EQ(kStoredTimeInMs, video_timing.network2_timestamp_delta_ms);
788 EXPECT_EQ(kPacerExitMs, video_timing.pacer_exit_delta_ms);
ilnik04f4d122017-06-19 07:18:55 -0700789}
790
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100791TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtensionWithoutPacer) {
792 SetUpRtpSender(/*pacer=*/false, /*populate_network2=*/true);
793 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
794 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
795 auto packet = rtp_sender_->AllocatePacket();
796 packet->SetMarker(true);
797 packet->set_capture_time_ms(fake_clock_.TimeInMilliseconds());
798 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
799 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
Erik Språng70768f42019-08-27 18:16:26 +0200800 packet->set_allow_retransmission(true);
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100801 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
Erik Språng1fbfecd2019-08-26 19:00:05 +0200802 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100803
804 const int kPropagateTimeMs = 10;
805 fake_clock_.AdvanceTimeMilliseconds(kPropagateTimeMs);
806
Erik Språng70768f42019-08-27 18:16:26 +0200807 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet)));
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100808
809 EXPECT_EQ(1, transport_.packets_sent());
810 absl::optional<VideoSendTiming> video_timing =
811 transport_.last_sent_packet().GetExtension<VideoTimingExtension>();
812 ASSERT_TRUE(video_timing);
813 EXPECT_EQ(kPropagateTimeMs, video_timing->network2_timestamp_delta_ms);
814}
815
minyue3a407ee2017-04-03 01:10:33 -0700816TEST_P(RtpSenderTest, TrafficSmoothingWithExtensions) {
Elad Alon4a87e1c2017-10-03 16:11:34 +0200817 EXPECT_CALL(mock_rtc_event_log_,
818 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000819
pwestin@webrtc.orgc66e8b32012-11-07 17:01:04 +0000820 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000821 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800822 kRtpExtensionTransmissionTimeOffset,
823 kTransmissionTimeOffsetExtensionId));
824 EXPECT_EQ(
825 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
826 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000827 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700828 auto packet =
829 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
830 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000831
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000832 const int kStoredTimeInMs = 100;
Erik Språngf6468d22019-07-05 16:53:43 +0200833 EXPECT_CALL(
834 mock_paced_sender_,
835 EnqueuePacket(AllOf(
836 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
837 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))));
838 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Erik Språng70768f42019-08-27 18:16:26 +0200839 packet->set_allow_retransmission(true);
Erik Språngf6468d22019-07-05 16:53:43 +0200840 EXPECT_TRUE(rtp_sender_->SendToNetwork(
Erik Språng70768f42019-08-27 18:16:26 +0200841 absl::make_unique<RtpPacketToSend>(*packet)));
Erik Språngf6468d22019-07-05 16:53:43 +0200842 EXPECT_EQ(0, transport_.packets_sent());
843 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
844 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000845
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000846 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700847 EXPECT_EQ(1, transport_.packets_sent());
848 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
849
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000850 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700851 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000852
853 // Verify transmission time offset.
854 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000855 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000856 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000857 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000858}
859
minyue3a407ee2017-04-03 01:10:33 -0700860TEST_P(RtpSenderTest, TrafficSmoothingRetransmits) {
Elad Alon4a87e1c2017-10-03 16:11:34 +0200861 EXPECT_CALL(mock_rtc_event_log_,
862 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000863
864 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000865 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800866 kRtpExtensionTransmissionTimeOffset,
867 kTransmissionTimeOffsetExtensionId));
868 EXPECT_EQ(
869 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
870 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000871 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700872 auto packet =
873 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
874 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000875
876 // Packet should be stored in a send bucket.
Erik Språngf6468d22019-07-05 16:53:43 +0200877 EXPECT_CALL(
878 mock_paced_sender_,
879 EnqueuePacket(AllOf(
880 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
881 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))));
882 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
883 packet->set_allow_retransmission(true);
884 EXPECT_TRUE(rtp_sender_->SendToNetwork(
Erik Språng70768f42019-08-27 18:16:26 +0200885 absl::make_unique<RtpPacketToSend>(*packet)));
Erik Språngf6468d22019-07-05 16:53:43 +0200886 // Immediately process send bucket and send packet.
887 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +0200888
Erik Språng0f4f0552019-05-08 10:15:05 -0700889 EXPECT_EQ(1, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000890
Erik Språng0f4f0552019-05-08 10:15:05 -0700891 // Retransmit packet.
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000892 const int kStoredTimeInMs = 100;
893 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
894
Erik Språng0f4f0552019-05-08 10:15:05 -0700895 EXPECT_CALL(mock_rtc_event_log_,
896 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
Erik Språngf6468d22019-07-05 16:53:43 +0200897 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
898 packet->set_retransmitted_sequence_number(kSeqNum);
899 EXPECT_CALL(
900 mock_paced_sender_,
901 EnqueuePacket(AllOf(
902 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
903 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))));
904 EXPECT_EQ(static_cast<int>(packet_size),
905 rtp_sender_->ReSendPacket(kSeqNum));
906 EXPECT_EQ(1, transport_.packets_sent());
907 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000908
909 // Process send bucket. Packet should now be sent.
Erik Språng0f4f0552019-05-08 10:15:05 -0700910 EXPECT_EQ(2, transport_.packets_sent());
danilchap12ba1862016-10-26 02:41:55 -0700911 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000912
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000913 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700914 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000915
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000916 // Verify transmission time offset.
917 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000918 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000919 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
920 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
921}
922
923// This test sends 1 regular video packet, then 4 padding packets, and then
924// 1 more regular packet.
minyue3a407ee2017-04-03 01:10:33 -0700925TEST_P(RtpSenderTest, SendPadding) {
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000926 // Make all (non-padding) packets go to send queue.
Elad Alon4a87e1c2017-10-03 16:11:34 +0200927 EXPECT_CALL(mock_rtc_event_log_,
928 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
929 .Times(1 + 4 + 1);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000930
931 uint16_t seq_num = kSeqNum;
932 uint32_t timestamp = kTimestamp;
933 rtp_sender_->SetStorePacketsStatus(true, 10);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000934 size_t rtp_header_len = kRtpHeaderSize;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000935 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800936 kRtpExtensionTransmissionTimeOffset,
937 kTransmissionTimeOffsetExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000938 rtp_header_len += 4; // 4 bytes extension.
danilchap162abd32015-12-10 02:39:40 -0800939 EXPECT_EQ(
940 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
941 kAbsoluteSendTimeExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000942 rtp_header_len += 4; // 4 bytes extension.
943 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
944
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000945 webrtc::RTPHeader rtp_header;
946
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000947 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700948 auto packet =
949 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200950 const uint32_t media_packet_timestamp = timestamp;
danilchapb6f1fb52016-10-19 06:11:39 -0700951 size_t packet_size = packet->size();
Erik Språngf6468d22019-07-05 16:53:43 +0200952 int total_packets_sent = 0;
953 const int kStoredTimeInMs = 100;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000954
955 // Packet should be stored in a send bucket.
Erik Språngf6468d22019-07-05 16:53:43 +0200956 EXPECT_CALL(
957 mock_paced_sender_,
958 EnqueuePacket(AllOf(
959 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
960 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))));
961 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
962 packet->set_allow_retransmission(true);
963 EXPECT_TRUE(rtp_sender_->SendToNetwork(
Erik Språng70768f42019-08-27 18:16:26 +0200964 absl::make_unique<RtpPacketToSend>(*packet)));
Erik Språngf6468d22019-07-05 16:53:43 +0200965 EXPECT_EQ(total_packets_sent, transport_.packets_sent());
966 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
967 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
968 ++seq_num;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000969
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000970 // Packet should now be sent. This test doesn't verify the regular video
971 // packet, since it is tested in another test.
danilchap12ba1862016-10-26 02:41:55 -0700972 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000973 timestamp += 90 * kStoredTimeInMs;
974
975 // Send padding 4 times, waiting 50 ms between each.
976 for (int i = 0; i < 4; ++i) {
977 const int kPaddingPeriodMs = 50;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000978 const size_t kPaddingBytes = 100;
979 const size_t kMaxPaddingLength = 224; // Value taken from rtp_sender.cc.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000980 // Padding will be forced to full packets.
Erik Språng4208a132019-08-26 08:58:45 +0200981 EXPECT_EQ(kMaxPaddingLength, GenerateAndSendPadding(kPaddingBytes));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000982
983 // Process send bucket. Padding should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700984 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000985 EXPECT_EQ(kMaxPaddingLength + rtp_header_len,
danilchap12ba1862016-10-26 02:41:55 -0700986 transport_.last_sent_packet().size());
987
988 transport_.last_sent_packet().GetHeader(&rtp_header);
pbosbd2522a2015-07-01 05:35:53 -0700989 EXPECT_EQ(kMaxPaddingLength, rtp_header.paddingLength);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000990
Stefan Holmer586b19b2015-09-18 11:14:31 +0200991 // Verify sequence number and timestamp. The timestamp should be the same
992 // as the last media packet.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000993 EXPECT_EQ(seq_num++, rtp_header.sequenceNumber);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200994 EXPECT_EQ(media_packet_timestamp, rtp_header.timestamp);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000995 // Verify transmission time offset.
Stefan Holmer586b19b2015-09-18 11:14:31 +0200996 int offset = timestamp - media_packet_timestamp;
997 EXPECT_EQ(offset, rtp_header.extension.transmissionTimeOffset);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000998 uint64_t expected_send_time =
999 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
1000 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
1001 fake_clock_.AdvanceTimeMilliseconds(kPaddingPeriodMs);
1002 timestamp += 90 * kPaddingPeriodMs;
1003 }
1004
1005 // Send a regular video packet again.
1006 capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -07001007 packet = BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
1008 packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001009
Erik Språngf6468d22019-07-05 16:53:43 +02001010 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Erik Språng70768f42019-08-27 18:16:26 +02001011 packet->set_allow_retransmission(true);
Erik Språngf6468d22019-07-05 16:53:43 +02001012 EXPECT_CALL(
1013 mock_paced_sender_,
1014 EnqueuePacket(AllOf(
1015 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
1016 Pointee(Property(&RtpPacketToSend::SequenceNumber, seq_num)))));
1017 EXPECT_TRUE(rtp_sender_->SendToNetwork(
Erik Språng70768f42019-08-27 18:16:26 +02001018 absl::make_unique<RtpPacketToSend>(*packet)));
Erik Språngf6468d22019-07-05 16:53:43 +02001019 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
terelius5d332ac2016-01-14 14:37:39 -08001020
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001021 // Process send bucket.
danilchap12ba1862016-10-26 02:41:55 -07001022 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
1023 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
1024 transport_.last_sent_packet().GetHeader(&rtp_header);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001025
1026 // Verify sequence number and timestamp.
1027 EXPECT_EQ(seq_num, rtp_header.sequenceNumber);
1028 EXPECT_EQ(timestamp, rtp_header.timestamp);
1029 // Verify transmission time offset. This packet is sent without delay.
1030 EXPECT_EQ(0, rtp_header.extension.transmissionTimeOffset);
1031 uint64_t expected_send_time =
1032 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +00001033 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +00001034}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001035
minyue3a407ee2017-04-03 01:10:33 -07001036TEST_P(RtpSenderTest, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -07001037 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1038 kRtpExtensionTransportSequenceNumber,
1039 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -07001040 rtp_sender_->SetStorePacketsStatus(true, 10);
1041
1042 EXPECT_CALL(send_packet_observer_,
1043 OnSendPacket(kTransportSequenceNumber, _, _))
1044 .Times(1);
asapersson35151f32016-05-02 23:44:01 -07001045
Erik Språngf6468d22019-07-05 16:53:43 +02001046 EXPECT_CALL(
1047 mock_paced_sender_,
1048 EnqueuePacket(AllOf(
1049 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
1050 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))));
1051 auto packet = SendGenericPacket();
1052 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
1053 packet->SetExtension<TransportSequenceNumber>(kTransportSequenceNumber);
1054 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +02001055
danilchap12ba1862016-10-26 02:41:55 -07001056 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -07001057}
1058
minyue3a407ee2017-04-03 01:10:33 -07001059TEST_P(RtpSenderTest, OnSendPacketNotUpdatedForRetransmits) {
stefana23fc622016-07-28 07:56:38 -07001060 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1061 kRtpExtensionTransportSequenceNumber,
1062 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -07001063 rtp_sender_->SetStorePacketsStatus(true, 10);
1064
1065 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
asapersson35151f32016-05-02 23:44:01 -07001066
Erik Språngf6468d22019-07-05 16:53:43 +02001067 EXPECT_CALL(
1068 mock_paced_sender_,
1069 EnqueuePacket(AllOf(
1070 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
1071 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))));
1072 auto packet = SendGenericPacket();
1073 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
1074 packet->SetExtension<TransportSequenceNumber>(kTransportSequenceNumber);
1075 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +02001076
danilchap12ba1862016-10-26 02:41:55 -07001077 EXPECT_EQ(1, transport_.packets_sent());
Petter Strandmark26bc6692018-05-29 08:43:35 +02001078 EXPECT_TRUE(transport_.last_options_.is_retransmit);
asapersson35151f32016-05-02 23:44:01 -07001079}
1080
minyue3a407ee2017-04-03 01:10:33 -07001081TEST_P(RtpSenderTestWithoutPacer, SendGenericVideo) {
Niels Möller8a40edd2019-01-24 18:04:44 +01001082 const char payload_name[] = "GENERIC";
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001083 const uint8_t payload_type = 127;
Niels Möller5fe95102019-03-04 16:49:25 +01001084 PlayoutDelayOracle playout_delay_oracle;
Niels Möller59ab1cf2019-02-06 22:48:11 +01001085 RTPSenderVideo rtp_sender_video(&fake_clock_, rtp_sender_.get(), nullptr,
Elad Alona0e99432019-05-24 13:50:56 +02001086 &playout_delay_oracle, nullptr, false, false,
Andrei Dumitru09872732019-08-29 12:00:29 -07001087 false, FieldTrialBasedConfig());
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001088 rtp_sender_video.RegisterPayloadType(payload_type, payload_name,
1089 /*raw_payload=*/false);
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001090 uint8_t payload[] = {47, 11, 32, 93, 89};
1091
1092 // Send keyframe
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001093 RTPVideoHeader video_header;
Niels Möller59ab1cf2019-02-06 22:48:11 +01001094 ASSERT_TRUE(rtp_sender_video.SendVideo(
Niels Möller8f7ce222019-03-21 15:43:58 +01001095 VideoFrameType::kVideoFrameKey, payload_type, 1234, 4321, payload,
1096 sizeof(payload), nullptr, &video_header,
1097 kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001098
danilchap96c15872016-11-21 01:35:29 -08001099 auto sent_payload = transport_.last_sent_packet().payload();
1100 uint8_t generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001101 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
1102 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -08001103 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001104
1105 // Send delta frame
1106 payload[0] = 13;
1107 payload[1] = 42;
1108 payload[4] = 13;
1109
Niels Möller59ab1cf2019-02-06 22:48:11 +01001110 ASSERT_TRUE(rtp_sender_video.SendVideo(
Niels Möller8f7ce222019-03-21 15:43:58 +01001111 VideoFrameType::kVideoFrameDelta, payload_type, 1234, 4321, payload,
1112 sizeof(payload), nullptr, &video_header,
1113 kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001114
danilchap96c15872016-11-21 01:35:29 -08001115 sent_payload = transport_.last_sent_packet().payload();
1116 generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001117 EXPECT_FALSE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
1118 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -08001119 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001120}
1121
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001122TEST_P(RtpSenderTestWithoutPacer, SendRawVideo) {
1123 const char payload_name[] = "VP8";
1124 const uint8_t payload_type = 111;
1125 const uint8_t payload[] = {11, 22, 33, 44, 55};
1126
1127 PlayoutDelayOracle playout_delay_oracle;
1128 RTPSenderVideo rtp_sender_video(&fake_clock_, rtp_sender_.get(), nullptr,
Elad Alona0e99432019-05-24 13:50:56 +02001129 &playout_delay_oracle, nullptr, false, false,
Andrei Dumitru09872732019-08-29 12:00:29 -07001130 false, FieldTrialBasedConfig());
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001131 rtp_sender_video.RegisterPayloadType(payload_type, payload_name,
1132 /*raw_payload=*/true);
1133
1134 // Send a frame.
1135 RTPVideoHeader video_header;
1136 ASSERT_TRUE(rtp_sender_video.SendVideo(
1137 VideoFrameType::kVideoFrameKey, payload_type, 1234, 4321, payload,
1138 sizeof(payload), nullptr, &video_header,
1139 kDefaultExpectedRetransmissionTimeMs));
1140
1141 auto sent_payload = transport_.last_sent_packet().payload();
1142 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
1143}
1144
minyue3a407ee2017-04-03 01:10:33 -07001145TEST_P(RtpSenderTest, SendFlexfecPackets) {
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001146 constexpr uint32_t kTimestamp = 1234;
brandtrdbdb3f12016-11-10 05:04:48 -08001147 constexpr int kMediaPayloadType = 127;
1148 constexpr int kFlexfecPayloadType = 118;
brandtrdbdb3f12016-11-10 05:04:48 -08001149 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001150 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
Erik Språng4580ca22019-07-04 10:38:43 +02001151 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid,
1152 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001153 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001154
1155 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng4580ca22019-07-04 10:38:43 +02001156 RtpRtcp::Configuration config;
1157 config.clock = &fake_clock_;
1158 config.outgoing_transport = &transport_;
1159 config.paced_sender = &mock_paced_sender_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001160 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02001161 config.flexfec_sender = &flexfec_sender_;
Erik Språng4580ca22019-07-04 10:38:43 +02001162 config.event_log = &mock_rtc_event_log_;
1163 config.send_packet_observer = &send_packet_observer_;
1164 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
1165 rtp_sender_ = absl::make_unique<RTPSender>(config);
1166
brandtrdbdb3f12016-11-10 05:04:48 -08001167 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001168 rtp_sender_->SetStorePacketsStatus(true, 10);
1169
Niels Möller5fe95102019-03-04 16:49:25 +01001170 PlayoutDelayOracle playout_delay_oracle;
Elad Alona0e99432019-05-24 13:50:56 +02001171 RTPSenderVideo rtp_sender_video(
1172 &fake_clock_, rtp_sender_.get(), &flexfec_sender, &playout_delay_oracle,
Andrei Dumitru09872732019-08-29 12:00:29 -07001173 nullptr, false, false, false, FieldTrialBasedConfig());
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001174 rtp_sender_video.RegisterPayloadType(kMediaPayloadType, "GENERIC",
1175 /*raw_payload=*/false);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001176
brandtrdbdb3f12016-11-10 05:04:48 -08001177 // Parameters selected to generate a single FEC packet per media packet.
1178 FecProtectionParams params;
1179 params.fec_rate = 15;
1180 params.max_fec_frames = 1;
1181 params.fec_mask_type = kFecMaskRandom;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001182 rtp_sender_video.SetFecParameters(params, params);
brandtrdbdb3f12016-11-10 05:04:48 -08001183
brandtr9dfff292016-11-14 05:14:50 -08001184 uint16_t flexfec_seq_num;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001185 RTPVideoHeader video_header;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001186
Erik Språngf6468d22019-07-05 16:53:43 +02001187 std::unique_ptr<RtpPacketToSend> media_packet;
1188 std::unique_ptr<RtpPacketToSend> fec_packet;
1189
1190 EXPECT_CALL(mock_paced_sender_, EnqueuePacket)
1191 .Times(2)
1192 .WillRepeatedly([&](std::unique_ptr<RtpPacketToSend> packet) {
1193 if (packet->packet_type() == RtpPacketToSend::Type::kVideo) {
1194 EXPECT_EQ(packet->Ssrc(), kSsrc);
1195 EXPECT_EQ(packet->SequenceNumber(), kSeqNum);
1196 media_packet = std::move(packet);
1197 } else {
1198 EXPECT_EQ(packet->packet_type(),
1199 RtpPacketToSend::Type::kForwardErrorCorrection);
1200 EXPECT_EQ(packet->Ssrc(), kFlexFecSsrc);
1201 fec_packet = std::move(packet);
1202 }
1203 });
1204
1205 EXPECT_TRUE(rtp_sender_video.SendVideo(
1206 VideoFrameType::kVideoFrameKey, kMediaPayloadType, kTimestamp,
1207 fake_clock_.TimeInMilliseconds(), kPayloadData, sizeof(kPayloadData),
1208 nullptr, &video_header, kDefaultExpectedRetransmissionTimeMs));
1209 ASSERT_TRUE(media_packet != nullptr);
1210 ASSERT_TRUE(fec_packet != nullptr);
1211
1212 flexfec_seq_num = fec_packet->SequenceNumber();
1213 rtp_sender_->TrySendPacket(media_packet.get(), PacedPacketInfo());
1214 rtp_sender_->TrySendPacket(fec_packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +02001215
brandtr9dfff292016-11-14 05:14:50 -08001216 ASSERT_EQ(2, transport_.packets_sent());
Erik Språngf5815fa2019-08-21 14:27:31 +02001217 const RtpPacketReceived& sent_media_packet = transport_.sent_packets_[0];
1218 EXPECT_EQ(kMediaPayloadType, sent_media_packet.PayloadType());
1219 EXPECT_EQ(kSeqNum, sent_media_packet.SequenceNumber());
1220 EXPECT_EQ(kSsrc, sent_media_packet.Ssrc());
1221 const RtpPacketReceived& sent_flexfec_packet = transport_.sent_packets_[1];
1222 EXPECT_EQ(kFlexfecPayloadType, sent_flexfec_packet.PayloadType());
1223 EXPECT_EQ(flexfec_seq_num, sent_flexfec_packet.SequenceNumber());
1224 EXPECT_EQ(kFlexFecSsrc, sent_flexfec_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001225}
1226
Erik Språngf6468d22019-07-05 16:53:43 +02001227// TODO(ilnik): because of webrtc:7859. Once FEC moved below pacer, this test
1228// should be removed.
1229TEST_P(RtpSenderTest, NoFlexfecForTimingFrames) {
1230 constexpr uint32_t kTimestamp = 1234;
1231 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
1232 constexpr int kMediaPayloadType = 127;
1233 constexpr int kFlexfecPayloadType = 118;
1234 const std::vector<RtpExtension> kNoRtpExtensions;
1235 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
1236
1237 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid,
1238 kNoRtpExtensions, kNoRtpExtensionSizes,
1239 nullptr /* rtp_state */, &fake_clock_);
1240
1241 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng630443a2019-07-26 16:44:55 +02001242 RtpRtcp::Configuration config;
1243 config.clock = &fake_clock_;
1244 config.outgoing_transport = &transport_;
1245 config.paced_sender = &mock_paced_sender_;
1246 config.flexfec_sender = &flexfec_sender;
Erik Språng630443a2019-07-26 16:44:55 +02001247 config.event_log = &mock_rtc_event_log_;
1248 config.send_packet_observer = &send_packet_observer_;
1249 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001250 config.local_media_ssrc = kSsrc;
Erik Språng630443a2019-07-26 16:44:55 +02001251 rtp_sender_ = absl::make_unique<RTPSender>(config);
Erik Språngf6468d22019-07-05 16:53:43 +02001252 rtp_sender_->SetSequenceNumber(kSeqNum);
1253 rtp_sender_->SetStorePacketsStatus(true, 10);
1254
1255 PlayoutDelayOracle playout_delay_oracle;
1256 RTPSenderVideo rtp_sender_video(
1257 &fake_clock_, rtp_sender_.get(), &flexfec_sender, &playout_delay_oracle,
Andrei Dumitru09872732019-08-29 12:00:29 -07001258 nullptr, false, false, false, FieldTrialBasedConfig());
Erik Språngf6468d22019-07-05 16:53:43 +02001259 rtp_sender_video.RegisterPayloadType(kMediaPayloadType, "GENERIC",
1260 /*raw_payload=*/false);
1261
1262 // Need extension to be registered for timing frames to be sent.
1263 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1264 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1265
1266 // Parameters selected to generate a single FEC packet per media packet.
1267 FecProtectionParams params;
1268 params.fec_rate = 15;
1269 params.max_fec_frames = 1;
1270 params.fec_mask_type = kFecMaskRandom;
1271 rtp_sender_video.SetFecParameters(params, params);
1272
1273 RTPVideoHeader video_header;
1274 video_header.video_timing.flags = VideoSendTiming::kTriggeredByTimer;
1275
1276 EXPECT_CALL(mock_rtc_event_log_,
1277 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1278 .Times(1);
Erik Språngf6468d22019-07-05 16:53:43 +02001279 std::unique_ptr<RtpPacketToSend> rtp_packet;
1280 EXPECT_CALL(
1281 mock_paced_sender_,
1282 EnqueuePacket(AllOf(
1283 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
1284 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))))
1285 .WillOnce([&rtp_packet](std::unique_ptr<RtpPacketToSend> packet) {
1286 rtp_packet = std::move(packet);
1287 });
1288
1289 EXPECT_CALL(
1290 mock_paced_sender_,
1291 EnqueuePacket(Pointee(Property(&RtpPacketToSend::Ssrc, kFlexFecSsrc))))
1292 .Times(0); // Not called because packet should not be protected.
1293
1294 EXPECT_TRUE(rtp_sender_video.SendVideo(
1295 VideoFrameType::kVideoFrameKey, kMediaPayloadType, kTimestamp,
1296 kCaptureTimeMs, kPayloadData, sizeof(kPayloadData), nullptr,
1297 &video_header, kDefaultExpectedRetransmissionTimeMs));
1298
1299 EXPECT_TRUE(
1300 rtp_sender_->TrySendPacket(rtp_packet.get(), PacedPacketInfo()));
Erik Språngf6468d22019-07-05 16:53:43 +02001301
1302 ASSERT_EQ(1, transport_.packets_sent());
Erik Språngf5815fa2019-08-21 14:27:31 +02001303 const RtpPacketReceived& sent_media_packet1 = transport_.sent_packets_[0];
1304 EXPECT_EQ(kMediaPayloadType, sent_media_packet1.PayloadType());
1305 EXPECT_EQ(kSeqNum, sent_media_packet1.SequenceNumber());
1306 EXPECT_EQ(kSsrc, sent_media_packet1.Ssrc());
Erik Språngf6468d22019-07-05 16:53:43 +02001307
1308 // Now try to send not a timing frame.
1309 uint16_t flexfec_seq_num;
1310
1311 EXPECT_CALL(mock_rtc_event_log_,
1312 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1313 .Times(2);
Erik Språngf5815fa2019-08-21 14:27:31 +02001314 std::unique_ptr<RtpPacketToSend> media_packet2;
1315 std::unique_ptr<RtpPacketToSend> fec_packet;
Erik Språngf6468d22019-07-05 16:53:43 +02001316
Erik Språngf5815fa2019-08-21 14:27:31 +02001317 EXPECT_CALL(mock_paced_sender_, EnqueuePacket)
1318 .Times(2)
1319 .WillRepeatedly([&](std::unique_ptr<RtpPacketToSend> packet) {
1320 if (packet->packet_type() == RtpPacketToSend::Type::kVideo) {
1321 EXPECT_EQ(packet->Ssrc(), kSsrc);
1322 EXPECT_EQ(packet->SequenceNumber(), kSeqNum + 1);
1323 media_packet2 = std::move(packet);
1324 } else {
1325 EXPECT_EQ(packet->packet_type(),
1326 RtpPacketToSend::Type::kForwardErrorCorrection);
1327 EXPECT_EQ(packet->Ssrc(), kFlexFecSsrc);
1328 fec_packet = std::move(packet);
1329 }
1330 });
Erik Språngf6468d22019-07-05 16:53:43 +02001331
Erik Språngf5815fa2019-08-21 14:27:31 +02001332 video_header.video_timing.flags = VideoSendTiming::kInvalid;
1333 EXPECT_TRUE(rtp_sender_video.SendVideo(
1334 VideoFrameType::kVideoFrameKey, kMediaPayloadType, kTimestamp + 1,
1335 kCaptureTimeMs + 1, kPayloadData, sizeof(kPayloadData), nullptr,
1336 &video_header, kDefaultExpectedRetransmissionTimeMs));
Erik Språngf6468d22019-07-05 16:53:43 +02001337
Erik Språngf5815fa2019-08-21 14:27:31 +02001338 ASSERT_TRUE(media_packet2 != nullptr);
1339 ASSERT_TRUE(fec_packet != nullptr);
Erik Språngf6468d22019-07-05 16:53:43 +02001340
Erik Språngf5815fa2019-08-21 14:27:31 +02001341 flexfec_seq_num = fec_packet->SequenceNumber();
1342 rtp_sender_->TrySendPacket(media_packet2.get(), PacedPacketInfo());
1343 rtp_sender_->TrySendPacket(fec_packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +02001344
1345 ASSERT_EQ(3, transport_.packets_sent());
Erik Språngf5815fa2019-08-21 14:27:31 +02001346 const RtpPacketReceived& sent_media_packet2 = transport_.sent_packets_[1];
1347 EXPECT_EQ(kMediaPayloadType, sent_media_packet2.PayloadType());
1348 EXPECT_EQ(kSeqNum + 1, sent_media_packet2.SequenceNumber());
1349 EXPECT_EQ(kSsrc, sent_media_packet2.Ssrc());
Erik Språngf6468d22019-07-05 16:53:43 +02001350 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[2];
1351 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1352 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1353 EXPECT_EQ(kFlexFecSsrc, flexfec_packet.Ssrc());
1354}
1355
minyue3a407ee2017-04-03 01:10:33 -07001356TEST_P(RtpSenderTestWithoutPacer, SendFlexfecPackets) {
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001357 constexpr uint32_t kTimestamp = 1234;
brandtrdbdb3f12016-11-10 05:04:48 -08001358 constexpr int kMediaPayloadType = 127;
1359 constexpr int kFlexfecPayloadType = 118;
brandtrdbdb3f12016-11-10 05:04:48 -08001360 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001361 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
Erik Språngf6468d22019-07-05 16:53:43 +02001362 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid,
Erik Språng4580ca22019-07-04 10:38:43 +02001363 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001364 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001365
1366 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng4580ca22019-07-04 10:38:43 +02001367 RtpRtcp::Configuration config;
1368 config.clock = &fake_clock_;
1369 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001370 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02001371 config.flexfec_sender = &flexfec_sender;
Erik Språng4580ca22019-07-04 10:38:43 +02001372 config.event_log = &mock_rtc_event_log_;
1373 config.send_packet_observer = &send_packet_observer_;
1374 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
1375 rtp_sender_ = absl::make_unique<RTPSender>(config);
1376
brandtrdbdb3f12016-11-10 05:04:48 -08001377 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001378
Niels Möller5fe95102019-03-04 16:49:25 +01001379 PlayoutDelayOracle playout_delay_oracle;
Elad Alona0e99432019-05-24 13:50:56 +02001380 RTPSenderVideo rtp_sender_video(
1381 &fake_clock_, rtp_sender_.get(), &flexfec_sender, &playout_delay_oracle,
Andrei Dumitru09872732019-08-29 12:00:29 -07001382 nullptr, false, false, false, FieldTrialBasedConfig());
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001383 rtp_sender_video.RegisterPayloadType(kMediaPayloadType, "GENERIC",
1384 /*raw_payload=*/false);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001385
brandtrdbdb3f12016-11-10 05:04:48 -08001386 // Parameters selected to generate a single FEC packet per media packet.
1387 FecProtectionParams params;
1388 params.fec_rate = 15;
1389 params.max_fec_frames = 1;
1390 params.fec_mask_type = kFecMaskRandom;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001391 rtp_sender_video.SetFecParameters(params, params);
brandtrdbdb3f12016-11-10 05:04:48 -08001392
Elad Alon4a87e1c2017-10-03 16:11:34 +02001393 EXPECT_CALL(mock_rtc_event_log_,
1394 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1395 .Times(2);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001396 RTPVideoHeader video_header;
1397 EXPECT_TRUE(rtp_sender_video.SendVideo(
Niels Möller8f7ce222019-03-21 15:43:58 +01001398 VideoFrameType::kVideoFrameKey, kMediaPayloadType, kTimestamp,
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001399 fake_clock_.TimeInMilliseconds(), kPayloadData, sizeof(kPayloadData),
1400 nullptr, &video_header, kDefaultExpectedRetransmissionTimeMs));
1401
brandtrdbdb3f12016-11-10 05:04:48 -08001402 ASSERT_EQ(2, transport_.packets_sent());
1403 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1404 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
Erik Språng4580ca22019-07-04 10:38:43 +02001405 EXPECT_EQ(kSsrc, media_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001406 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1407 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
Erik Språngf6468d22019-07-05 16:53:43 +02001408 EXPECT_EQ(kFlexFecSsrc, flexfec_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001409}
1410
Steve Anton296a0ce2018-03-22 15:17:27 -07001411// Test that the MID header extension is included on sent packets when
1412// configured.
1413TEST_P(RtpSenderTestWithoutPacer, MidIncludedOnSentPackets) {
1414 const char kMid[] = "mid";
1415
Steve Anton2bac7da2019-07-21 15:04:21 -04001416 EnableMidSending(kMid);
Steve Anton296a0ce2018-03-22 15:17:27 -07001417
1418 // Send a couple packets.
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001419 SendGenericPacket();
1420 SendGenericPacket();
Steve Anton296a0ce2018-03-22 15:17:27 -07001421
1422 // Expect both packets to have the MID set.
1423 ASSERT_EQ(2u, transport_.sent_packets_.size());
1424 for (const RtpPacketReceived& packet : transport_.sent_packets_) {
1425 std::string mid;
1426 ASSERT_TRUE(packet.GetExtension<RtpMid>(&mid));
1427 EXPECT_EQ(kMid, mid);
1428 }
1429}
1430
Amit Hilbuch77938e62018-12-21 09:23:38 -08001431TEST_P(RtpSenderTestWithoutPacer, RidIncludedOnSentPackets) {
1432 const char kRid[] = "f";
1433
Steve Anton2bac7da2019-07-21 15:04:21 -04001434 EnableRidSending(kRid);
Amit Hilbuch77938e62018-12-21 09:23:38 -08001435
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001436 SendGenericPacket();
Amit Hilbuch77938e62018-12-21 09:23:38 -08001437
1438 ASSERT_EQ(1u, transport_.sent_packets_.size());
1439 const RtpPacketReceived& packet = transport_.sent_packets_[0];
1440 std::string rid;
1441 ASSERT_TRUE(packet.GetExtension<RtpStreamId>(&rid));
1442 EXPECT_EQ(kRid, rid);
1443}
1444
1445TEST_P(RtpSenderTestWithoutPacer, RidIncludedOnRtxSentPackets) {
1446 const char kRid[] = "f";
Amit Hilbuch77938e62018-12-21 09:23:38 -08001447
Steve Anton2bac7da2019-07-21 15:04:21 -04001448 EnableRtx();
1449 EnableRidSending(kRid);
Amit Hilbuch77938e62018-12-21 09:23:38 -08001450
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001451 SendGenericPacket();
Amit Hilbuch77938e62018-12-21 09:23:38 -08001452 ASSERT_EQ(1u, transport_.sent_packets_.size());
1453 const RtpPacketReceived& packet = transport_.sent_packets_[0];
1454 std::string rid;
1455 ASSERT_TRUE(packet.GetExtension<RtpStreamId>(&rid));
1456 EXPECT_EQ(kRid, rid);
1457 rid = kNoRid;
Steve Anton2bac7da2019-07-21 15:04:21 -04001458 EXPECT_FALSE(packet.HasExtension<RepairedRtpStreamId>());
Amit Hilbuch77938e62018-12-21 09:23:38 -08001459
1460 uint16_t packet_id = packet.SequenceNumber();
1461 rtp_sender_->ReSendPacket(packet_id);
1462 ASSERT_EQ(2u, transport_.sent_packets_.size());
1463 const RtpPacketReceived& rtx_packet = transport_.sent_packets_[1];
1464 ASSERT_TRUE(rtx_packet.GetExtension<RepairedRtpStreamId>(&rid));
1465 EXPECT_EQ(kRid, rid);
1466 EXPECT_FALSE(rtx_packet.HasExtension<RtpStreamId>());
1467}
1468
Steve Anton2bac7da2019-07-21 15:04:21 -04001469TEST_P(RtpSenderTestWithoutPacer, MidAndRidNotIncludedOnSentPacketsAfterAck) {
1470 const char kMid[] = "mid";
1471 const char kRid[] = "f";
1472
1473 EnableMidSending(kMid);
1474 EnableRidSending(kRid);
1475
1476 // This first packet should include both MID and RID.
1477 auto first_built_packet = SendGenericPacket();
1478
1479 rtp_sender_->OnReceivedAckOnSsrc(first_built_packet->SequenceNumber());
1480
1481 // The second packet should include neither since an ack was received.
1482 SendGenericPacket();
1483
1484 ASSERT_EQ(2u, transport_.sent_packets_.size());
1485
1486 const RtpPacketReceived& first_packet = transport_.sent_packets_[0];
1487 std::string mid, rid;
1488 ASSERT_TRUE(first_packet.GetExtension<RtpMid>(&mid));
1489 EXPECT_EQ(kMid, mid);
1490 ASSERT_TRUE(first_packet.GetExtension<RtpStreamId>(&rid));
1491 EXPECT_EQ(kRid, rid);
1492
1493 const RtpPacketReceived& second_packet = transport_.sent_packets_[1];
1494 EXPECT_FALSE(second_packet.HasExtension<RtpMid>());
1495 EXPECT_FALSE(second_packet.HasExtension<RtpStreamId>());
1496}
1497
1498// Test that the first RTX packet includes both MID and RRID even if the packet
1499// being retransmitted did not have MID or RID. The MID and RID are needed on
1500// the first packets for a given SSRC, and RTX packets are sent on a separate
1501// SSRC.
1502TEST_P(RtpSenderTestWithoutPacer, MidAndRidIncludedOnFirstRtxPacket) {
1503 const char kMid[] = "mid";
1504 const char kRid[] = "f";
1505
1506 EnableRtx();
1507 EnableMidSending(kMid);
1508 EnableRidSending(kRid);
1509
1510 // This first packet will include both MID and RID.
1511 auto first_built_packet = SendGenericPacket();
1512 rtp_sender_->OnReceivedAckOnSsrc(first_built_packet->SequenceNumber());
1513
1514 // The second packet will include neither since an ack was received.
1515 auto second_built_packet = SendGenericPacket();
1516
1517 // The first RTX packet should include MID and RRID.
1518 ASSERT_LT(0,
1519 rtp_sender_->ReSendPacket(second_built_packet->SequenceNumber()));
1520
1521 ASSERT_EQ(3u, transport_.sent_packets_.size());
1522
1523 const RtpPacketReceived& rtx_packet = transport_.sent_packets_[2];
1524 std::string mid, rrid;
1525 ASSERT_TRUE(rtx_packet.GetExtension<RtpMid>(&mid));
1526 EXPECT_EQ(kMid, mid);
1527 ASSERT_TRUE(rtx_packet.GetExtension<RepairedRtpStreamId>(&rrid));
1528 EXPECT_EQ(kRid, rrid);
1529}
1530
1531// Test that the RTX packets sent after receving an ACK on the RTX SSRC does
1532// not include either MID or RRID even if the packet being retransmitted did
1533// had a MID or RID.
1534TEST_P(RtpSenderTestWithoutPacer, MidAndRidNotIncludedOnRtxPacketsAfterAck) {
1535 const char kMid[] = "mid";
1536 const char kRid[] = "f";
1537
1538 EnableRtx();
1539 EnableMidSending(kMid);
1540 EnableRidSending(kRid);
1541
1542 // This first packet will include both MID and RID.
1543 auto first_built_packet = SendGenericPacket();
1544 rtp_sender_->OnReceivedAckOnSsrc(first_built_packet->SequenceNumber());
1545
1546 // The second packet will include neither since an ack was received.
1547 auto second_built_packet = SendGenericPacket();
1548
1549 // The first RTX packet will include MID and RRID.
1550 ASSERT_LT(0,
1551 rtp_sender_->ReSendPacket(second_built_packet->SequenceNumber()));
1552
1553 ASSERT_EQ(3u, transport_.sent_packets_.size());
1554 const RtpPacketReceived& first_rtx_packet = transport_.sent_packets_[2];
1555
1556 rtp_sender_->OnReceivedAckOnRtxSsrc(first_rtx_packet.SequenceNumber());
1557
1558 // The second and third RTX packets should not include MID nor RRID.
1559 ASSERT_LT(0, rtp_sender_->ReSendPacket(first_built_packet->SequenceNumber()));
1560 ASSERT_LT(0,
1561 rtp_sender_->ReSendPacket(second_built_packet->SequenceNumber()));
1562
1563 ASSERT_EQ(5u, transport_.sent_packets_.size());
1564
1565 const RtpPacketReceived& second_rtx_packet = transport_.sent_packets_[3];
1566 EXPECT_FALSE(second_rtx_packet.HasExtension<RtpMid>());
1567 EXPECT_FALSE(second_rtx_packet.HasExtension<RepairedRtpStreamId>());
1568
1569 const RtpPacketReceived& third_rtx_packet = transport_.sent_packets_[4];
1570 EXPECT_FALSE(third_rtx_packet.HasExtension<RtpMid>());
1571 EXPECT_FALSE(third_rtx_packet.HasExtension<RepairedRtpStreamId>());
1572}
1573
1574// Test that if the RtpState indicates an ACK has been received on that SSRC
1575// then neither the MID nor RID header extensions will be sent.
1576TEST_P(RtpSenderTestWithoutPacer,
1577 MidAndRidNotIncludedOnSentPacketsAfterRtpStateRestored) {
1578 const char kMid[] = "mid";
1579 const char kRid[] = "f";
1580
1581 EnableMidSending(kMid);
1582 EnableRidSending(kRid);
1583
1584 RtpState state = rtp_sender_->GetRtpState();
1585 EXPECT_FALSE(state.ssrc_has_acked);
1586 state.ssrc_has_acked = true;
1587 rtp_sender_->SetRtpState(state);
1588
1589 SendGenericPacket();
1590
1591 ASSERT_EQ(1u, transport_.sent_packets_.size());
1592 const RtpPacketReceived& packet = transport_.sent_packets_[0];
1593 EXPECT_FALSE(packet.HasExtension<RtpMid>());
1594 EXPECT_FALSE(packet.HasExtension<RtpStreamId>());
1595}
1596
1597// Test that if the RTX RtpState indicates an ACK has been received on that
1598// RTX SSRC then neither the MID nor RRID header extensions will be sent on
1599// RTX packets.
1600TEST_P(RtpSenderTestWithoutPacer,
1601 MidAndRridNotIncludedOnRtxPacketsAfterRtpStateRestored) {
1602 const char kMid[] = "mid";
1603 const char kRid[] = "f";
1604
1605 EnableRtx();
1606 EnableMidSending(kMid);
1607 EnableRidSending(kRid);
1608
1609 RtpState rtx_state = rtp_sender_->GetRtxRtpState();
1610 EXPECT_FALSE(rtx_state.ssrc_has_acked);
1611 rtx_state.ssrc_has_acked = true;
1612 rtp_sender_->SetRtxRtpState(rtx_state);
1613
1614 auto built_packet = SendGenericPacket();
1615 ASSERT_LT(0, rtp_sender_->ReSendPacket(built_packet->SequenceNumber()));
1616
1617 ASSERT_EQ(2u, transport_.sent_packets_.size());
1618 const RtpPacketReceived& rtx_packet = transport_.sent_packets_[1];
1619 EXPECT_FALSE(rtx_packet.HasExtension<RtpMid>());
1620 EXPECT_FALSE(rtx_packet.HasExtension<RepairedRtpStreamId>());
1621}
1622
minyue3a407ee2017-04-03 01:10:33 -07001623TEST_P(RtpSenderTest, FecOverheadRate) {
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001624 constexpr uint32_t kTimestamp = 1234;
1625 constexpr int kMediaPayloadType = 127;
brandtr81eab612017-01-24 04:06:09 -08001626 constexpr int kFlexfecPayloadType = 118;
brandtr81eab612017-01-24 04:06:09 -08001627 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001628 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
Erik Språng4580ca22019-07-04 10:38:43 +02001629 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid,
1630 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001631 nullptr /* rtp_state */, &fake_clock_);
brandtr81eab612017-01-24 04:06:09 -08001632
1633 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng4580ca22019-07-04 10:38:43 +02001634 RtpRtcp::Configuration config;
1635 config.clock = &fake_clock_;
1636 config.outgoing_transport = &transport_;
1637 config.paced_sender = &mock_paced_sender_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001638 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02001639 config.flexfec_sender = &flexfec_sender;
Erik Språng4580ca22019-07-04 10:38:43 +02001640 config.event_log = &mock_rtc_event_log_;
1641 config.send_packet_observer = &send_packet_observer_;
1642 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
1643 rtp_sender_ = absl::make_unique<RTPSender>(config);
1644
brandtr81eab612017-01-24 04:06:09 -08001645 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr81eab612017-01-24 04:06:09 -08001646
Niels Möller5fe95102019-03-04 16:49:25 +01001647 PlayoutDelayOracle playout_delay_oracle;
Elad Alona0e99432019-05-24 13:50:56 +02001648 RTPSenderVideo rtp_sender_video(
1649 &fake_clock_, rtp_sender_.get(), &flexfec_sender, &playout_delay_oracle,
Andrei Dumitru09872732019-08-29 12:00:29 -07001650 nullptr, false, false, false, FieldTrialBasedConfig());
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001651 rtp_sender_video.RegisterPayloadType(kMediaPayloadType, "GENERIC",
1652 /*raw_payload=*/false);
brandtr81eab612017-01-24 04:06:09 -08001653 // Parameters selected to generate a single FEC packet per media packet.
1654 FecProtectionParams params;
1655 params.fec_rate = 15;
1656 params.max_fec_frames = 1;
1657 params.fec_mask_type = kFecMaskRandom;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001658 rtp_sender_video.SetFecParameters(params, params);
brandtr81eab612017-01-24 04:06:09 -08001659
1660 constexpr size_t kNumMediaPackets = 10;
1661 constexpr size_t kNumFecPackets = kNumMediaPackets;
1662 constexpr int64_t kTimeBetweenPacketsMs = 10;
Erik Språngf6468d22019-07-05 16:53:43 +02001663 EXPECT_CALL(mock_paced_sender_, EnqueuePacket)
1664 .Times(kNumMediaPackets + kNumFecPackets);
brandtr81eab612017-01-24 04:06:09 -08001665 for (size_t i = 0; i < kNumMediaPackets; ++i) {
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001666 RTPVideoHeader video_header;
1667
1668 EXPECT_TRUE(rtp_sender_video.SendVideo(
Niels Möller8f7ce222019-03-21 15:43:58 +01001669 VideoFrameType::kVideoFrameKey, kMediaPayloadType, kTimestamp,
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001670 fake_clock_.TimeInMilliseconds(), kPayloadData, sizeof(kPayloadData),
1671 nullptr, &video_header, kDefaultExpectedRetransmissionTimeMs));
1672
brandtr81eab612017-01-24 04:06:09 -08001673 fake_clock_.AdvanceTimeMilliseconds(kTimeBetweenPacketsMs);
1674 }
1675 constexpr size_t kRtpHeaderLength = 12;
1676 constexpr size_t kFlexfecHeaderLength = 20;
1677 constexpr size_t kGenericCodecHeaderLength = 1;
1678 constexpr size_t kPayloadLength = sizeof(kPayloadData);
1679 constexpr size_t kPacketLength = kRtpHeaderLength + kFlexfecHeaderLength +
1680 kGenericCodecHeaderLength + kPayloadLength;
1681 EXPECT_NEAR(kNumFecPackets * kPacketLength * 8 /
1682 (kNumFecPackets * kTimeBetweenPacketsMs / 1000.0f),
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001683 rtp_sender_video.FecOverheadRate(), 500);
brandtr81eab612017-01-24 04:06:09 -08001684}
1685
minyue3a407ee2017-04-03 01:10:33 -07001686TEST_P(RtpSenderTest, BitrateCallbacks) {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001687 class TestCallback : public BitrateStatisticsObserver {
1688 public:
sprangcd349d92016-07-13 09:11:28 -07001689 TestCallback()
1690 : BitrateStatisticsObserver(),
1691 num_calls_(0),
1692 ssrc_(0),
1693 total_bitrate_(0),
1694 retransmit_bitrate_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001695 ~TestCallback() override = default;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001696
sprangcd349d92016-07-13 09:11:28 -07001697 void Notify(uint32_t total_bitrate,
1698 uint32_t retransmit_bitrate,
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001699 uint32_t ssrc) override {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001700 ++num_calls_;
1701 ssrc_ = ssrc;
sprangcd349d92016-07-13 09:11:28 -07001702 total_bitrate_ = total_bitrate;
1703 retransmit_bitrate_ = retransmit_bitrate;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001704 }
1705
1706 uint32_t num_calls_;
1707 uint32_t ssrc_;
sprangcd349d92016-07-13 09:11:28 -07001708 uint32_t total_bitrate_;
1709 uint32_t retransmit_bitrate_;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001710 } callback;
Erik Språng4580ca22019-07-04 10:38:43 +02001711
1712 RtpRtcp::Configuration config;
1713 config.clock = &fake_clock_;
1714 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001715 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02001716 config.send_bitrate_observer = &callback;
1717 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
1718 rtp_sender_ = absl::make_unique<RTPSender>(config);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001719
Niels Möller5fe95102019-03-04 16:49:25 +01001720 PlayoutDelayOracle playout_delay_oracle;
Niels Möller59ab1cf2019-02-06 22:48:11 +01001721 RTPSenderVideo rtp_sender_video(&fake_clock_, rtp_sender_.get(), nullptr,
Elad Alona0e99432019-05-24 13:50:56 +02001722 &playout_delay_oracle, nullptr, false, false,
Andrei Dumitru09872732019-08-29 12:00:29 -07001723 false, FieldTrialBasedConfig());
Niels Möller59ab1cf2019-02-06 22:48:11 +01001724 const char payload_name[] = "GENERIC";
1725 const uint8_t payload_type = 127;
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001726 rtp_sender_video.RegisterPayloadType(payload_type, payload_name,
1727 /*raw_payload=*/false);
Niels Möller59ab1cf2019-02-06 22:48:11 +01001728
sprangcd349d92016-07-13 09:11:28 -07001729 // Simulate kNumPackets sent with kPacketInterval ms intervals, with the
1730 // number of packets selected so that we fill (but don't overflow) the one
1731 // second averaging window.
1732 const uint32_t kWindowSizeMs = 1000;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001733 const uint32_t kPacketInterval = 20;
sprangcd349d92016-07-13 09:11:28 -07001734 const uint32_t kNumPackets =
1735 (kWindowSizeMs - kPacketInterval) / kPacketInterval;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001736 // Overhead = 12 bytes RTP header + 1 byte generic header.
1737 const uint32_t kPacketOverhead = 13;
1738
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001739 uint8_t payload[] = {47, 11, 32, 93, 89};
1740 rtp_sender_->SetStorePacketsStatus(true, 1);
1741 uint32_t ssrc = rtp_sender_->SSRC();
1742
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001743 // Initial process call so we get a new time window.
1744 rtp_sender_->ProcessBitrate();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001745
1746 // Send a few frames.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001747 RTPVideoHeader video_header;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001748 for (uint32_t i = 0; i < kNumPackets; ++i) {
Niels Möller59ab1cf2019-02-06 22:48:11 +01001749 ASSERT_TRUE(rtp_sender_video.SendVideo(
Niels Möller8f7ce222019-03-21 15:43:58 +01001750 VideoFrameType::kVideoFrameKey, payload_type, 1234, 4321, payload,
1751 sizeof(payload), nullptr, &video_header,
1752 kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001753 fake_clock_.AdvanceTimeMilliseconds(kPacketInterval);
1754 }
1755
1756 rtp_sender_->ProcessBitrate();
1757
stefan@webrtc.org0bae1fa2014-11-05 14:05:29 +00001758 // We get one call for every stats updated, thus two calls since both the
1759 // stream stats and the retransmit stats are updated once.
1760 EXPECT_EQ(2u, callback.num_calls_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001761 EXPECT_EQ(ssrc, callback.ssrc_);
sprangcd349d92016-07-13 09:11:28 -07001762 const uint32_t kTotalPacketSize = kPacketOverhead + sizeof(payload);
1763 // Bitrate measured over delta between last and first timestamp, plus one.
1764 const uint32_t kExpectedWindowMs = kNumPackets * kPacketInterval + 1;
1765 const uint32_t kExpectedBitsAccumulated = kTotalPacketSize * kNumPackets * 8;
1766 const uint32_t kExpectedRateBps =
1767 (kExpectedBitsAccumulated * 1000 + (kExpectedWindowMs / 2)) /
1768 kExpectedWindowMs;
1769 EXPECT_EQ(kExpectedRateBps, callback.total_bitrate_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001770
andresp@webrtc.orgd11bec42014-07-08 14:32:58 +00001771 rtp_sender_.reset();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001772}
1773
minyue3a407ee2017-04-03 01:10:33 -07001774TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacks) {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001775 class TestCallback : public StreamDataCountersCallback {
1776 public:
danilchap162abd32015-12-10 02:39:40 -08001777 TestCallback() : StreamDataCountersCallback(), ssrc_(0), counters_() {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001778 ~TestCallback() override = default;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001779
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001780 void DataCountersUpdated(const StreamDataCounters& counters,
1781 uint32_t ssrc) override {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001782 ssrc_ = ssrc;
1783 counters_ = counters;
1784 }
1785
1786 uint32_t ssrc_;
1787 StreamDataCounters counters_;
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001788
1789 void MatchPacketCounter(const RtpPacketCounter& expected,
1790 const RtpPacketCounter& actual) {
1791 EXPECT_EQ(expected.payload_bytes, actual.payload_bytes);
1792 EXPECT_EQ(expected.header_bytes, actual.header_bytes);
1793 EXPECT_EQ(expected.padding_bytes, actual.padding_bytes);
1794 EXPECT_EQ(expected.packets, actual.packets);
1795 }
1796
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001797 void Matches(uint32_t ssrc, const StreamDataCounters& counters) {
1798 EXPECT_EQ(ssrc, ssrc_);
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001799 MatchPacketCounter(counters.transmitted, counters_.transmitted);
1800 MatchPacketCounter(counters.retransmitted, counters_.retransmitted);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001801 EXPECT_EQ(counters.fec.packets, counters_.fec.packets);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001802 }
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001803 } callback;
1804
1805 const uint8_t kRedPayloadType = 96;
1806 const uint8_t kUlpfecPayloadType = 97;
Niels Möller8a40edd2019-01-24 18:04:44 +01001807 const char payload_name[] = "GENERIC";
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001808 const uint8_t payload_type = 127;
Niels Möller5fe95102019-03-04 16:49:25 +01001809 PlayoutDelayOracle playout_delay_oracle;
Niels Möller59ab1cf2019-02-06 22:48:11 +01001810 RTPSenderVideo rtp_sender_video(&fake_clock_, rtp_sender_.get(), nullptr,
Elad Alona0e99432019-05-24 13:50:56 +02001811 &playout_delay_oracle, nullptr, false, false,
Andrei Dumitru09872732019-08-29 12:00:29 -07001812 false, FieldTrialBasedConfig());
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001813 rtp_sender_video.RegisterPayloadType(payload_type, payload_name,
1814 /*raw_payload=*/false);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001815 uint8_t payload[] = {47, 11, 32, 93, 89};
1816 rtp_sender_->SetStorePacketsStatus(true, 1);
1817 uint32_t ssrc = rtp_sender_->SSRC();
1818
1819 rtp_sender_->RegisterRtpStatisticsCallback(&callback);
1820
1821 // Send a frame.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001822 RTPVideoHeader video_header;
Niels Möller59ab1cf2019-02-06 22:48:11 +01001823 ASSERT_TRUE(rtp_sender_video.SendVideo(
Niels Möller8f7ce222019-03-21 15:43:58 +01001824 VideoFrameType::kVideoFrameKey, payload_type, 1234, 4321, payload,
1825 sizeof(payload), nullptr, &video_header,
1826 kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001827 StreamDataCounters expected;
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001828 expected.transmitted.payload_bytes = 6;
1829 expected.transmitted.header_bytes = 12;
1830 expected.transmitted.padding_bytes = 0;
1831 expected.transmitted.packets = 1;
1832 expected.retransmitted.payload_bytes = 0;
1833 expected.retransmitted.header_bytes = 0;
1834 expected.retransmitted.padding_bytes = 0;
1835 expected.retransmitted.packets = 0;
1836 expected.fec.packets = 0;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001837 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001838
1839 // Retransmit a frame.
1840 uint16_t seqno = rtp_sender_->SequenceNumber() - 1;
Erik Språnga12b1d62018-03-14 12:39:24 +01001841 rtp_sender_->ReSendPacket(seqno);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001842 expected.transmitted.payload_bytes = 12;
1843 expected.transmitted.header_bytes = 24;
1844 expected.transmitted.packets = 2;
1845 expected.retransmitted.payload_bytes = 6;
1846 expected.retransmitted.header_bytes = 12;
1847 expected.retransmitted.padding_bytes = 0;
1848 expected.retransmitted.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001849 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001850
1851 // Send padding.
Erik Språng4208a132019-08-26 08:58:45 +02001852 GenerateAndSendPadding(kMaxPaddingSize);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001853 expected.transmitted.payload_bytes = 12;
1854 expected.transmitted.header_bytes = 36;
1855 expected.transmitted.padding_bytes = kMaxPaddingSize;
1856 expected.transmitted.packets = 3;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001857 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001858
brandtrf1bb4762016-11-07 03:05:06 -08001859 // Send ULPFEC.
Niels Möller59ab1cf2019-02-06 22:48:11 +01001860 rtp_sender_video.SetUlpfecConfig(kRedPayloadType, kUlpfecPayloadType);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001861 FecProtectionParams fec_params;
1862 fec_params.fec_mask_type = kFecMaskRandom;
1863 fec_params.fec_rate = 1;
1864 fec_params.max_fec_frames = 1;
Niels Möller59ab1cf2019-02-06 22:48:11 +01001865 rtp_sender_video.SetFecParameters(fec_params, fec_params);
1866 ASSERT_TRUE(rtp_sender_video.SendVideo(
Niels Möller8f7ce222019-03-21 15:43:58 +01001867 VideoFrameType::kVideoFrameDelta, payload_type, 1234, 4321, payload,
1868 sizeof(payload), nullptr, &video_header,
1869 kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001870 expected.transmitted.payload_bytes = 40;
1871 expected.transmitted.header_bytes = 60;
1872 expected.transmitted.packets = 5;
1873 expected.fec.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001874 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001875
sprang867fb522015-08-03 04:38:41 -07001876 rtp_sender_->RegisterRtpStatisticsCallback(nullptr);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001877}
1878
minyue3a407ee2017-04-03 01:10:33 -07001879TEST_P(RtpSenderTestWithoutPacer, BytesReportedCorrectly) {
Niels Möller59ab1cf2019-02-06 22:48:11 +01001880 // XXX const char* kPayloadName = "GENERIC";
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001881 const uint8_t kPayloadType = 127;
Shao Changbine62202f2015-04-21 20:24:50 +08001882 rtp_sender_->SetRtxPayloadType(kPayloadType - 1, kPayloadType);
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +00001883 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001884
Niels Möller59ab1cf2019-02-06 22:48:11 +01001885 SendGenericPacket();
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001886 // Will send 2 full-size padding packets.
Erik Språng4208a132019-08-26 08:58:45 +02001887 GenerateAndSendPadding(1);
1888 GenerateAndSendPadding(1);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001889
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001890 StreamDataCounters rtp_stats;
1891 StreamDataCounters rtx_stats;
1892 rtp_sender_->GetDataCounters(&rtp_stats, &rtx_stats);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001893
Niels Möller59ab1cf2019-02-06 22:48:11 +01001894 // Payload
asapersson@webrtc.orgd08d3892014-12-16 12:03:11 +00001895 EXPECT_GT(rtp_stats.first_packet_time_ms, -1);
Niels Möller59ab1cf2019-02-06 22:48:11 +01001896 EXPECT_EQ(rtp_stats.transmitted.payload_bytes, sizeof(kPayloadData));
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001897 EXPECT_EQ(rtp_stats.transmitted.header_bytes, 12u);
1898 EXPECT_EQ(rtp_stats.transmitted.padding_bytes, 0u);
1899 EXPECT_EQ(rtx_stats.transmitted.payload_bytes, 0u);
1900 EXPECT_EQ(rtx_stats.transmitted.header_bytes, 24u);
1901 EXPECT_EQ(rtx_stats.transmitted.padding_bytes, 2 * kMaxPaddingSize);
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001902
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001903 EXPECT_EQ(rtp_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001904 rtp_stats.transmitted.payload_bytes +
1905 rtp_stats.transmitted.header_bytes +
1906 rtp_stats.transmitted.padding_bytes);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001907 EXPECT_EQ(rtx_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001908 rtx_stats.transmitted.payload_bytes +
1909 rtx_stats.transmitted.header_bytes +
1910 rtx_stats.transmitted.padding_bytes);
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001911
danilchap162abd32015-12-10 02:39:40 -08001912 EXPECT_EQ(
1913 transport_.total_bytes_sent_,
1914 rtp_stats.transmitted.TotalBytes() + rtx_stats.transmitted.TotalBytes());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001915}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001916
minyue3a407ee2017-04-03 01:10:33 -07001917TEST_P(RtpSenderTestWithoutPacer, RespectsNackBitrateLimit) {
sprang38778b02015-09-29 09:48:22 -07001918 const int32_t kPacketSize = 1400;
1919 const int32_t kNumPackets = 30;
1920
sprangcd349d92016-07-13 09:11:28 -07001921 retransmission_rate_limiter_.SetMaxRate(kPacketSize * kNumPackets * 8);
1922
sprang38778b02015-09-29 09:48:22 -07001923 rtp_sender_->SetStorePacketsStatus(true, kNumPackets);
sprang38778b02015-09-29 09:48:22 -07001924 const uint16_t kStartSequenceNumber = rtp_sender_->SequenceNumber();
Danil Chapovalov2800d742016-08-26 18:48:46 +02001925 std::vector<uint16_t> sequence_numbers;
sprang38778b02015-09-29 09:48:22 -07001926 for (int32_t i = 0; i < kNumPackets; ++i) {
1927 sequence_numbers.push_back(kStartSequenceNumber + i);
1928 fake_clock_.AdvanceTimeMilliseconds(1);
1929 SendPacket(fake_clock_.TimeInMilliseconds(), kPacketSize);
1930 }
danilchap12ba1862016-10-26 02:41:55 -07001931 EXPECT_EQ(kNumPackets, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001932
1933 fake_clock_.AdvanceTimeMilliseconds(1000 - kNumPackets);
1934
1935 // Resending should work - brings the bandwidth up to the limit.
1936 // NACK bitrate is capped to the same bitrate as the encoder, since the max
1937 // protection overhead is 50% (see MediaOptimization::SetTargetRates).
Danil Chapovalov2800d742016-08-26 18:48:46 +02001938 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001939 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001940
sprangcd349d92016-07-13 09:11:28 -07001941 // Must be at least 5ms in between retransmission attempts.
1942 fake_clock_.AdvanceTimeMilliseconds(5);
1943
sprang38778b02015-09-29 09:48:22 -07001944 // Resending should not work, bandwidth exceeded.
Danil Chapovalov2800d742016-08-26 18:48:46 +02001945 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001946 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001947}
1948
minyue3a407ee2017-04-03 01:10:33 -07001949TEST_P(RtpSenderTest, OnOverheadChanged) {
michaelt4da30442016-11-17 01:38:43 -08001950 MockOverheadObserver mock_overhead_observer;
Erik Språng4580ca22019-07-04 10:38:43 +02001951 RtpRtcp::Configuration config;
1952 config.clock = &fake_clock_;
1953 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001954 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02001955 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
1956 config.overhead_observer = &mock_overhead_observer;
1957 rtp_sender_ = absl::make_unique<RTPSender>(config);
michaelt4da30442016-11-17 01:38:43 -08001958
michaelt4da30442016-11-17 01:38:43 -08001959 // RTP overhead is 12B.
nisse284542b2017-01-10 08:58:32 -08001960 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(12)).Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001961 SendGenericPacket();
michaelt4da30442016-11-17 01:38:43 -08001962
1963 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
1964 kTransmissionTimeOffsetExtensionId);
1965
1966 // TransmissionTimeOffset extension has a size of 8B.
nisse284542b2017-01-10 08:58:32 -08001967 // 12B + 8B = 20B
1968 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(20)).Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001969 SendGenericPacket();
michaelt4da30442016-11-17 01:38:43 -08001970}
1971
minyue3a407ee2017-04-03 01:10:33 -07001972TEST_P(RtpSenderTest, DoesNotUpdateOverheadOnEqualSize) {
michaelt4da30442016-11-17 01:38:43 -08001973 MockOverheadObserver mock_overhead_observer;
Erik Språng4580ca22019-07-04 10:38:43 +02001974 RtpRtcp::Configuration config;
1975 config.clock = &fake_clock_;
1976 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001977 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02001978 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
1979 config.overhead_observer = &mock_overhead_observer;
1980 rtp_sender_ = absl::make_unique<RTPSender>(config);
michaelt4da30442016-11-17 01:38:43 -08001981
1982 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(_)).Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001983 SendGenericPacket();
1984 SendGenericPacket();
michaelt4da30442016-11-17 01:38:43 -08001985}
1986
Erik Språng9c771c22019-06-17 16:31:53 +02001987TEST_P(RtpSenderTest, TrySendPacketMatchesVideo) {
1988 std::unique_ptr<RtpPacketToSend> packet =
1989 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
1990 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
1991
1992 // Verify not sent with wrong SSRC.
1993 packet->SetSsrc(kSsrc + 1);
1994 EXPECT_FALSE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
1995
1996 // Verify sent with correct SSRC.
1997 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
1998 packet->SetSsrc(kSsrc);
1999 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2000 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2001}
2002
2003TEST_P(RtpSenderTest, TrySendPacketMatchesAudio) {
2004 std::unique_ptr<RtpPacketToSend> packet =
2005 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2006 packet->set_packet_type(RtpPacketToSend::Type::kAudio);
2007
2008 // Verify not sent with wrong SSRC.
2009 packet->SetSsrc(kSsrc + 1);
2010 EXPECT_FALSE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2011
2012 // Verify sent with correct SSRC.
2013 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2014 packet->SetSsrc(kSsrc);
2015 packet->set_packet_type(RtpPacketToSend::Type::kAudio);
2016 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2017}
2018
2019TEST_P(RtpSenderTest, TrySendPacketMatchesRetransmissions) {
2020 std::unique_ptr<RtpPacketToSend> packet =
2021 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2022 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2023
2024 // Verify not sent with wrong SSRC.
2025 packet->SetSsrc(kSsrc + 1);
2026 EXPECT_FALSE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2027
2028 // Verify sent with correct SSRC (non-RTX).
2029 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2030 packet->SetSsrc(kSsrc);
2031 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2032 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2033
2034 // RTX retransmission.
2035 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2036 packet->SetSsrc(kRtxSsrc);
2037 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2038 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2039}
2040
2041TEST_P(RtpSenderTest, TrySendPacketMatchesPadding) {
2042 std::unique_ptr<RtpPacketToSend> packet =
2043 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2044 packet->set_packet_type(RtpPacketToSend::Type::kPadding);
2045
2046 // Verify not sent with wrong SSRC.
2047 packet->SetSsrc(kSsrc + 1);
2048 EXPECT_FALSE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2049
2050 // Verify sent with correct SSRC (non-RTX).
2051 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2052 packet->SetSsrc(kSsrc);
2053 packet->set_packet_type(RtpPacketToSend::Type::kPadding);
2054 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2055
2056 // RTX padding.
2057 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2058 packet->SetSsrc(kRtxSsrc);
2059 packet->set_packet_type(RtpPacketToSend::Type::kPadding);
2060 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2061}
2062
2063TEST_P(RtpSenderTest, TrySendPacketMatchesFlexfec) {
2064 std::unique_ptr<RtpPacketToSend> packet =
2065 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2066 packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection);
2067
2068 // Verify not sent with wrong SSRC.
2069 packet->SetSsrc(kSsrc + 1);
2070 EXPECT_FALSE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2071
2072 // Verify sent with correct SSRC.
2073 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2074 packet->SetSsrc(kFlexFecSsrc);
2075 packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection);
2076 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2077}
2078
2079TEST_P(RtpSenderTest, TrySendPacketMatchesUlpfec) {
2080 std::unique_ptr<RtpPacketToSend> packet =
2081 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2082 packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection);
2083
2084 // Verify not sent with wrong SSRC.
2085 packet->SetSsrc(kSsrc + 1);
2086 EXPECT_FALSE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2087
2088 // Verify sent with correct SSRC.
2089 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2090 packet->SetSsrc(kSsrc);
2091 packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection);
2092 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2093}
2094
2095TEST_P(RtpSenderTest, TrySendPacketHandlesRetransmissionHistory) {
2096 rtp_sender_->SetStorePacketsStatus(true, 10);
2097
2098 // Build a media packet and send it.
2099 std::unique_ptr<RtpPacketToSend> packet =
2100 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2101 const uint16_t media_sequence_number = packet->SequenceNumber();
2102 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2103 packet->set_allow_retransmission(true);
2104 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2105
2106 // Simulate retransmission request.
2107 fake_clock_.AdvanceTimeMilliseconds(30);
2108 EXPECT_GT(rtp_sender_->ReSendPacket(media_sequence_number), 0);
2109
2110 // Packet already pending, retransmission not allowed.
2111 fake_clock_.AdvanceTimeMilliseconds(30);
2112 EXPECT_EQ(rtp_sender_->ReSendPacket(media_sequence_number), 0);
2113
2114 // Packet exiting pacer, mark as not longer pending.
2115 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2116 EXPECT_NE(packet->SequenceNumber(), media_sequence_number);
2117 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2118 packet->SetSsrc(kRtxSsrc);
2119 packet->set_retransmitted_sequence_number(media_sequence_number);
2120 packet->set_allow_retransmission(false);
2121 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2122
2123 // Retransmissions allowed again.
2124 fake_clock_.AdvanceTimeMilliseconds(30);
2125 EXPECT_GT(rtp_sender_->ReSendPacket(media_sequence_number), 0);
2126
2127 // Retransmission of RTX packet should not be allowed.
2128 EXPECT_EQ(rtp_sender_->ReSendPacket(packet->SequenceNumber()), 0);
2129}
2130
2131TEST_P(RtpSenderTest, TrySendPacketUpdatesExtensions) {
2132 ASSERT_EQ(rtp_sender_->RegisterRtpHeaderExtension(
2133 kRtpExtensionTransmissionTimeOffset,
2134 kTransmissionTimeOffsetExtensionId),
2135 0);
2136 ASSERT_EQ(rtp_sender_->RegisterRtpHeaderExtension(
2137 kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId),
2138 0);
2139 ASSERT_EQ(rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionVideoTiming,
2140 kVideoTimingExtensionId),
2141 0);
2142
2143 std::unique_ptr<RtpPacketToSend> packet =
2144 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2145 packet->set_packetization_finish_time_ms(fake_clock_.TimeInMilliseconds());
2146
2147 const int32_t kDiffMs = 10;
2148 fake_clock_.AdvanceTimeMilliseconds(kDiffMs);
2149
2150 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2151 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2152
2153 const RtpPacketReceived& received_packet = transport_.last_sent_packet();
2154
2155 EXPECT_EQ(received_packet.GetExtension<TransmissionOffset>(), kDiffMs * 90);
2156
2157 EXPECT_EQ(received_packet.GetExtension<AbsoluteSendTime>(),
2158 AbsoluteSendTime::MsTo24Bits(fake_clock_.TimeInMilliseconds()));
2159
2160 VideoSendTiming timing;
2161 EXPECT_TRUE(received_packet.GetExtension<VideoTimingExtension>(&timing));
2162 EXPECT_EQ(timing.pacer_exit_delta_ms, kDiffMs);
2163}
2164
2165TEST_P(RtpSenderTest, TrySendPacketSetsPacketOptions) {
2166 const uint16_t kPacketId = 42;
2167 ASSERT_EQ(rtp_sender_->RegisterRtpHeaderExtension(
2168 kRtpExtensionTransportSequenceNumber,
2169 kTransportSequenceNumberExtensionId),
2170 0);
2171 std::unique_ptr<RtpPacketToSend> packet =
2172 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2173 packet->SetExtension<TransportSequenceNumber>(kPacketId);
2174
2175 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2176 EXPECT_CALL(send_packet_observer_, OnSendPacket);
2177 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2178
2179 EXPECT_EQ(transport_.last_options_.packet_id, kPacketId);
2180 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
2181 EXPECT_TRUE(transport_.last_options_.included_in_feedback);
2182 EXPECT_FALSE(transport_.last_options_.is_retransmit);
2183
2184 // Send another packet as retransmission, verify options are populated.
2185 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2186 packet->SetExtension<TransportSequenceNumber>(kPacketId + 1);
2187 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2188 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2189 EXPECT_TRUE(transport_.last_options_.is_retransmit);
2190}
2191
2192TEST_P(RtpSenderTest, TrySendPacketUpdatesStats) {
2193 const size_t kPayloadSize = 1000;
2194
2195 StrictMock<MockSendSideDelayObserver> send_side_delay_observer;
Erik Språng4580ca22019-07-04 10:38:43 +02002196
2197 RtpRtcp::Configuration config;
2198 config.clock = &fake_clock_;
2199 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02002200 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02002201 config.rtx_send_ssrc = kRtxSsrc;
2202 config.flexfec_sender = &flexfec_sender_;
2203 config.send_side_delay_observer = &send_side_delay_observer;
2204 config.event_log = &mock_rtc_event_log_;
2205 config.send_packet_observer = &send_packet_observer_;
2206 rtp_sender_ = absl::make_unique<RTPSender>(config);
Erik Språng9c771c22019-06-17 16:31:53 +02002207 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2208 kRtpExtensionTransportSequenceNumber,
2209 kTransportSequenceNumberExtensionId));
2210
2211 const int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
2212
2213 std::unique_ptr<RtpPacketToSend> video_packet =
2214 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2215 video_packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2216 video_packet->SetPayloadSize(kPayloadSize);
2217 video_packet->SetExtension<TransportSequenceNumber>(1);
2218
2219 std::unique_ptr<RtpPacketToSend> rtx_packet =
2220 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2221 rtx_packet->SetSsrc(kRtxSsrc);
2222 rtx_packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2223 rtx_packet->SetPayloadSize(kPayloadSize);
2224 rtx_packet->SetExtension<TransportSequenceNumber>(2);
2225
2226 std::unique_ptr<RtpPacketToSend> fec_packet =
2227 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2228 fec_packet->SetSsrc(kFlexFecSsrc);
2229 fec_packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection);
2230 fec_packet->SetPayloadSize(kPayloadSize);
2231 fec_packet->SetExtension<TransportSequenceNumber>(3);
2232
2233 const int64_t kDiffMs = 25;
2234 fake_clock_.AdvanceTimeMilliseconds(kDiffMs);
2235
2236 EXPECT_CALL(send_side_delay_observer,
2237 SendSideDelayUpdated(kDiffMs, kDiffMs, kDiffMs, kSsrc));
2238 EXPECT_CALL(
2239 send_side_delay_observer,
2240 SendSideDelayUpdated(kDiffMs, kDiffMs, 2 * kDiffMs, kFlexFecSsrc));
2241
2242 EXPECT_CALL(send_packet_observer_, OnSendPacket(1, capture_time_ms, kSsrc));
2243 EXPECT_TRUE(
2244 rtp_sender_->TrySendPacket(video_packet.get(), PacedPacketInfo()));
2245
2246 // Send packet observer not called for padding/retransmissions.
2247 EXPECT_CALL(send_packet_observer_, OnSendPacket(2, _, _)).Times(0);
2248 EXPECT_TRUE(rtp_sender_->TrySendPacket(rtx_packet.get(), PacedPacketInfo()));
2249
2250 EXPECT_CALL(send_packet_observer_,
2251 OnSendPacket(3, capture_time_ms, kFlexFecSsrc));
2252 EXPECT_TRUE(rtp_sender_->TrySendPacket(fec_packet.get(), PacedPacketInfo()));
2253
2254 StreamDataCounters rtp_stats;
2255 StreamDataCounters rtx_stats;
2256 rtp_sender_->GetDataCounters(&rtp_stats, &rtx_stats);
2257 EXPECT_EQ(rtp_stats.transmitted.packets, 2u);
2258 EXPECT_EQ(rtp_stats.fec.packets, 1u);
2259 EXPECT_EQ(rtx_stats.retransmitted.packets, 1u);
2260}
2261
Erik Språng478cb462019-06-26 15:49:27 +02002262TEST_P(RtpSenderTest, GeneratePaddingResendsOldPacketsWithRtx) {
Mirko Bonadeia7e3bce2019-07-12 17:35:56 +00002263 // Min requested size in order to use RTX payload.
2264 const size_t kMinPaddingSize = 50;
2265
Erik Språng478cb462019-06-26 15:49:27 +02002266 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
2267 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
2268 rtp_sender_->SetStorePacketsStatus(true, 1);
2269
Erik Språng0f6191d2019-07-15 20:33:40 +02002270 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2271 kRtpExtensionTransmissionTimeOffset,
2272 kTransmissionTimeOffsetExtensionId));
2273 ASSERT_EQ(
2274 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
2275 kAbsoluteSendTimeExtensionId));
2276 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2277 kRtpExtensionTransportSequenceNumber,
2278 kTransportSequenceNumberExtensionId));
2279
Erik Språng478cb462019-06-26 15:49:27 +02002280 const size_t kPayloadPacketSize = 1234;
2281 std::unique_ptr<RtpPacketToSend> packet =
2282 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2283 packet->set_allow_retransmission(true);
2284 packet->SetPayloadSize(kPayloadPacketSize);
2285 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2286
2287 // Send a dummy video packet so it ends up in the packet history.
Erik Språng0f6191d2019-07-15 20:33:40 +02002288 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
Erik Språng478cb462019-06-26 15:49:27 +02002289 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2290
2291 // Generated padding has large enough budget that the video packet should be
2292 // retransmitted as padding.
Erik Språngf6468d22019-07-05 16:53:43 +02002293 std::vector<std::unique_ptr<RtpPacketToSend>> generated_packets =
Mirko Bonadeia7e3bce2019-07-12 17:35:56 +00002294 rtp_sender_->GeneratePadding(kMinPaddingSize);
Erik Språngf6468d22019-07-05 16:53:43 +02002295 ASSERT_EQ(generated_packets.size(), 1u);
2296 auto& padding_packet = generated_packets.front();
2297 EXPECT_EQ(padding_packet->packet_type(), RtpPacketToSend::Type::kPadding);
2298 EXPECT_EQ(padding_packet->Ssrc(), kRtxSsrc);
2299 EXPECT_EQ(padding_packet->payload_size(),
2300 kPayloadPacketSize + kRtxHeaderSize);
Erik Språng0f6191d2019-07-15 20:33:40 +02002301 EXPECT_TRUE(padding_packet->IsExtensionReserved<TransportSequenceNumber>());
2302 EXPECT_TRUE(padding_packet->IsExtensionReserved<AbsoluteSendTime>());
2303 EXPECT_TRUE(padding_packet->IsExtensionReserved<TransmissionOffset>());
2304
2305 // Verify all header extensions are received.
2306 EXPECT_TRUE(
2307 rtp_sender_->TrySendPacket(padding_packet.get(), PacedPacketInfo()));
2308 webrtc::RTPHeader rtp_header;
2309 transport_.last_sent_packet().GetHeader(&rtp_header);
2310 EXPECT_TRUE(rtp_header.extension.hasAbsoluteSendTime);
2311 EXPECT_TRUE(rtp_header.extension.hasTransmissionTimeOffset);
2312 EXPECT_TRUE(rtp_header.extension.hasTransportSequenceNumber);
Erik Språng478cb462019-06-26 15:49:27 +02002313
2314 // Not enough budged for payload padding, use plain padding instead.
Mirko Bonadeia7e3bce2019-07-12 17:35:56 +00002315 const size_t kPaddingBytesRequested = kMinPaddingSize - 1;
Erik Språngf6468d22019-07-05 16:53:43 +02002316
2317 size_t padding_bytes_generated = 0;
2318 generated_packets = rtp_sender_->GeneratePadding(kPaddingBytesRequested);
Mirko Bonadeia7e3bce2019-07-12 17:35:56 +00002319 EXPECT_EQ(generated_packets.size(), 1u);
Erik Språngf6468d22019-07-05 16:53:43 +02002320 for (auto& packet : generated_packets) {
2321 EXPECT_EQ(packet->packet_type(), RtpPacketToSend::Type::kPadding);
2322 EXPECT_EQ(packet->Ssrc(), kRtxSsrc);
2323 EXPECT_EQ(packet->payload_size(), 0u);
2324 EXPECT_GT(packet->padding_size(), 0u);
2325 padding_bytes_generated += packet->padding_size();
Erik Språng0f6191d2019-07-15 20:33:40 +02002326
2327 EXPECT_TRUE(packet->IsExtensionReserved<TransportSequenceNumber>());
2328 EXPECT_TRUE(packet->IsExtensionReserved<AbsoluteSendTime>());
2329 EXPECT_TRUE(packet->IsExtensionReserved<TransmissionOffset>());
2330
2331 // Verify all header extensions are received.
2332 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2333 webrtc::RTPHeader rtp_header;
2334 transport_.last_sent_packet().GetHeader(&rtp_header);
2335 EXPECT_TRUE(rtp_header.extension.hasAbsoluteSendTime);
2336 EXPECT_TRUE(rtp_header.extension.hasTransmissionTimeOffset);
2337 EXPECT_TRUE(rtp_header.extension.hasTransportSequenceNumber);
Erik Språngf6468d22019-07-05 16:53:43 +02002338 }
2339
Mirko Bonadeia7e3bce2019-07-12 17:35:56 +00002340 EXPECT_EQ(padding_bytes_generated, kMaxPaddingSize);
Erik Språng478cb462019-06-26 15:49:27 +02002341}
2342
2343TEST_P(RtpSenderTest, GeneratePaddingCreatesPurePaddingWithoutRtx) {
2344 rtp_sender_->SetStorePacketsStatus(true, 1);
Erik Språng0f6191d2019-07-15 20:33:40 +02002345 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2346 kRtpExtensionTransmissionTimeOffset,
2347 kTransmissionTimeOffsetExtensionId));
2348 ASSERT_EQ(
2349 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
2350 kAbsoluteSendTimeExtensionId));
2351 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2352 kRtpExtensionTransportSequenceNumber,
2353 kTransportSequenceNumberExtensionId));
Erik Språng478cb462019-06-26 15:49:27 +02002354
2355 const size_t kPayloadPacketSize = 1234;
2356 // Send a dummy video packet so it ends up in the packet history. Since we
2357 // are not using RTX, it should never be used as padding.
2358 std::unique_ptr<RtpPacketToSend> packet =
2359 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2360 packet->set_allow_retransmission(true);
2361 packet->SetPayloadSize(kPayloadPacketSize);
2362 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Erik Språng0f6191d2019-07-15 20:33:40 +02002363 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
Erik Språng478cb462019-06-26 15:49:27 +02002364 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2365
2366 // Payload padding not available without RTX, only generate plain padding on
2367 // the media SSRC.
2368 // Number of padding packets is the requested padding size divided by max
2369 // padding packet size, rounded up. Pure padding packets are always of the
2370 // maximum size.
2371 const size_t kPaddingBytesRequested = kPayloadPacketSize + kRtxHeaderSize;
2372 const size_t kExpectedNumPaddingPackets =
2373 (kPaddingBytesRequested + kMaxPaddingSize - 1) / kMaxPaddingSize;
Erik Språngf6468d22019-07-05 16:53:43 +02002374 size_t padding_bytes_generated = 0;
2375 std::vector<std::unique_ptr<RtpPacketToSend>> padding_packets =
2376 rtp_sender_->GeneratePadding(kPaddingBytesRequested);
2377 EXPECT_EQ(padding_packets.size(), kExpectedNumPaddingPackets);
2378 for (auto& packet : padding_packets) {
2379 EXPECT_EQ(packet->packet_type(), RtpPacketToSend::Type::kPadding);
2380 EXPECT_EQ(packet->Ssrc(), kSsrc);
2381 EXPECT_EQ(packet->payload_size(), 0u);
2382 EXPECT_GT(packet->padding_size(), 0u);
2383 padding_bytes_generated += packet->padding_size();
Erik Språng0f6191d2019-07-15 20:33:40 +02002384 EXPECT_TRUE(packet->IsExtensionReserved<TransportSequenceNumber>());
2385 EXPECT_TRUE(packet->IsExtensionReserved<AbsoluteSendTime>());
2386 EXPECT_TRUE(packet->IsExtensionReserved<TransmissionOffset>());
2387
2388 // Verify all header extensions are received.
2389 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2390 webrtc::RTPHeader rtp_header;
2391 transport_.last_sent_packet().GetHeader(&rtp_header);
2392 EXPECT_TRUE(rtp_header.extension.hasAbsoluteSendTime);
2393 EXPECT_TRUE(rtp_header.extension.hasTransmissionTimeOffset);
2394 EXPECT_TRUE(rtp_header.extension.hasTransportSequenceNumber);
Erik Språngf6468d22019-07-05 16:53:43 +02002395 }
2396
2397 EXPECT_EQ(padding_bytes_generated,
2398 kExpectedNumPaddingPackets * kMaxPaddingSize);
Erik Språng478cb462019-06-26 15:49:27 +02002399}
2400
Mirko Bonadei999a72a2019-07-12 17:33:46 +00002401TEST_P(RtpSenderTest, SupportsPadding) {
2402 bool kSendingMediaStats[] = {true, false};
2403 bool kEnableRedundantPayloads[] = {true, false};
2404 RTPExtensionType kBweExtensionTypes[] = {
2405 kRtpExtensionTransportSequenceNumber,
2406 kRtpExtensionTransportSequenceNumber02, kRtpExtensionAbsoluteSendTime,
2407 kRtpExtensionTransmissionTimeOffset};
2408 const int kExtensionsId = 7;
2409
2410 for (bool sending_media : kSendingMediaStats) {
2411 rtp_sender_->SetSendingMediaStatus(sending_media);
2412 for (bool redundant_payloads : kEnableRedundantPayloads) {
2413 int rtx_mode = kRtxRetransmitted;
2414 if (redundant_payloads) {
2415 rtx_mode |= kRtxRedundantPayloads;
2416 }
2417 rtp_sender_->SetRtxStatus(rtx_mode);
2418
2419 for (auto extension_type : kBweExtensionTypes) {
2420 EXPECT_FALSE(rtp_sender_->SupportsPadding());
2421 rtp_sender_->RegisterRtpHeaderExtension(extension_type, kExtensionsId);
2422 if (!sending_media) {
2423 EXPECT_FALSE(rtp_sender_->SupportsPadding());
2424 } else {
2425 EXPECT_TRUE(rtp_sender_->SupportsPadding());
2426 if (redundant_payloads) {
2427 EXPECT_TRUE(rtp_sender_->SupportsRtxPayloadPadding());
2428 } else {
2429 EXPECT_FALSE(rtp_sender_->SupportsRtxPayloadPadding());
2430 }
2431 }
2432 rtp_sender_->DeregisterRtpHeaderExtension(extension_type);
2433 EXPECT_FALSE(rtp_sender_->SupportsPadding());
2434 }
2435 }
2436 }
2437}
2438
Erik Språnga57711c2019-07-24 10:47:20 +02002439TEST_P(RtpSenderTest, SetsCaptureTimeAndPopulatesTransmissionOffset) {
2440 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
2441 kTransmissionTimeOffsetExtensionId);
2442
2443 rtp_sender_->SetSendingMediaStatus(true);
2444 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
2445 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
2446 rtp_sender_->SetStorePacketsStatus(true, 10);
2447
2448 const int64_t kMissingCaptureTimeMs = 0;
2449 const uint32_t kTimestampTicksPerMs = 90;
2450 const int64_t kOffsetMs = 10;
2451
Erik Språnga57711c2019-07-24 10:47:20 +02002452 auto packet =
2453 BuildRtpPacket(kPayload, kMarkerBit, fake_clock_.TimeInMilliseconds(),
2454 kMissingCaptureTimeMs);
2455 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2456 packet->ReserveExtension<TransmissionOffset>();
2457 packet->AllocatePayload(sizeof(kPayloadData));
2458
2459 std::unique_ptr<RtpPacketToSend> packet_to_pace;
2460 EXPECT_CALL(mock_paced_sender_, EnqueuePacket)
2461 .WillOnce([&](std::unique_ptr<RtpPacketToSend> packet) {
2462 EXPECT_GT(packet->capture_time_ms(), 0);
2463 packet_to_pace = std::move(packet);
2464 });
2465
Erik Språng70768f42019-08-27 18:16:26 +02002466 packet->set_allow_retransmission(true);
2467 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet)));
Erik Språnga57711c2019-07-24 10:47:20 +02002468
2469 fake_clock_.AdvanceTimeMilliseconds(kOffsetMs);
2470
2471 rtp_sender_->TrySendPacket(packet_to_pace.get(), PacedPacketInfo());
Erik Språnga57711c2019-07-24 10:47:20 +02002472
2473 EXPECT_EQ(1, transport_.packets_sent());
2474 absl::optional<int32_t> transmission_time_extension =
2475 transport_.sent_packets_.back().GetExtension<TransmissionOffset>();
2476 ASSERT_TRUE(transmission_time_extension.has_value());
2477 EXPECT_EQ(*transmission_time_extension, kOffsetMs * kTimestampTicksPerMs);
2478
2479 // Retransmit packet. The RTX packet should get the same capture time as the
2480 // original packet, so offset is delta from original packet to now.
2481 fake_clock_.AdvanceTimeMilliseconds(kOffsetMs);
2482
Erik Språnga57711c2019-07-24 10:47:20 +02002483 std::unique_ptr<RtpPacketToSend> rtx_packet_to_pace;
2484 EXPECT_CALL(mock_paced_sender_, EnqueuePacket)
2485 .WillOnce([&](std::unique_ptr<RtpPacketToSend> packet) {
2486 EXPECT_GT(packet->capture_time_ms(), 0);
2487 rtx_packet_to_pace = std::move(packet);
2488 });
2489
2490 EXPECT_GT(rtp_sender_->ReSendPacket(kSeqNum), 0);
2491 rtp_sender_->TrySendPacket(rtx_packet_to_pace.get(), PacedPacketInfo());
Erik Språnga57711c2019-07-24 10:47:20 +02002492
2493 EXPECT_EQ(2, transport_.packets_sent());
2494 transmission_time_extension =
2495 transport_.sent_packets_.back().GetExtension<TransmissionOffset>();
2496 ASSERT_TRUE(transmission_time_extension.has_value());
2497 EXPECT_EQ(*transmission_time_extension, 2 * kOffsetMs * kTimestampTicksPerMs);
2498}
2499
Erik Språng6cacef22019-07-24 14:15:51 +02002500TEST_P(RtpSenderTestWithoutPacer, ClearHistoryOnSsrcChange) {
2501 const int64_t kRtt = 10;
2502
2503 rtp_sender_->SetSendingMediaStatus(true);
2504 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
2505 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
2506 rtp_sender_->SetStorePacketsStatus(true, 10);
2507 rtp_sender_->SetRtt(kRtt);
Erik Språng6cacef22019-07-24 14:15:51 +02002508
2509 // Send a packet and record its sequence numbers.
2510 SendGenericPacket();
2511 ASSERT_EQ(1u, transport_.sent_packets_.size());
2512 const uint16_t packet_seqence_number =
2513 transport_.sent_packets_.back().SequenceNumber();
2514
2515 // Advance time and make sure it can be retransmitted, even if we try to set
2516 // the ssrc the what it already is.
2517 rtp_sender_->SetSSRC(kSsrc);
2518 fake_clock_.AdvanceTimeMilliseconds(kRtt);
2519 EXPECT_GT(rtp_sender_->ReSendPacket(packet_seqence_number), 0);
2520
2521 // Change the SSRC, then move the time and try to retransmit again. The old
2522 // packet should now be gone.
2523 rtp_sender_->SetSSRC(kSsrc + 1);
2524 fake_clock_.AdvanceTimeMilliseconds(kRtt);
2525 EXPECT_EQ(rtp_sender_->ReSendPacket(packet_seqence_number), 0);
2526}
2527
2528TEST_P(RtpSenderTestWithoutPacer, ClearHistoryOnSequenceNumberCange) {
2529 const int64_t kRtt = 10;
2530
2531 rtp_sender_->SetSendingMediaStatus(true);
2532 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
2533 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
2534 rtp_sender_->SetStorePacketsStatus(true, 10);
2535 rtp_sender_->SetRtt(kRtt);
2536
2537 // Send a packet and record its sequence numbers.
2538 SendGenericPacket();
2539 ASSERT_EQ(1u, transport_.sent_packets_.size());
2540 const uint16_t packet_seqence_number =
2541 transport_.sent_packets_.back().SequenceNumber();
2542
2543 // Advance time and make sure it can be retransmitted, even if we try to set
2544 // the ssrc the what it already is.
2545 rtp_sender_->SetSequenceNumber(rtp_sender_->SequenceNumber());
2546 fake_clock_.AdvanceTimeMilliseconds(kRtt);
2547 EXPECT_GT(rtp_sender_->ReSendPacket(packet_seqence_number), 0);
2548
2549 // Change the sequence number, then move the time and try to retransmit again.
2550 // The old packet should now be gone.
2551 rtp_sender_->SetSequenceNumber(rtp_sender_->SequenceNumber() - 1);
2552 fake_clock_.AdvanceTimeMilliseconds(kRtt);
2553 EXPECT_EQ(rtp_sender_->ReSendPacket(packet_seqence_number), 0);
2554}
2555
Erik Språng60ffc312019-07-30 22:03:49 +02002556TEST_P(RtpSenderTest, IgnoresNackAfterDisablingMedia) {
2557 const int64_t kRtt = 10;
2558
2559 rtp_sender_->SetSendingMediaStatus(true);
2560 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
2561 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
2562 rtp_sender_->SetStorePacketsStatus(true, 10);
2563 rtp_sender_->SetRtt(kRtt);
2564
2565 // Send a packet so it is in the packet history.
Erik Språng60ffc312019-07-30 22:03:49 +02002566 std::unique_ptr<RtpPacketToSend> packet_to_pace;
2567 EXPECT_CALL(mock_paced_sender_, EnqueuePacket)
2568 .WillOnce([&](std::unique_ptr<RtpPacketToSend> packet) {
2569 packet_to_pace = std::move(packet);
2570 });
2571
2572 SendGenericPacket();
2573 rtp_sender_->TrySendPacket(packet_to_pace.get(), PacedPacketInfo());
2574
2575 ASSERT_EQ(1u, transport_.sent_packets_.size());
2576
2577 // Disable media sending and try to retransmit the packet, it should fail.
2578 rtp_sender_->SetSendingMediaStatus(false);
2579 fake_clock_.AdvanceTimeMilliseconds(kRtt);
2580 EXPECT_LT(rtp_sender_->ReSendPacket(kSeqNum), 0);
Erik Språng60ffc312019-07-30 22:03:49 +02002581}
2582
Mirko Bonadeic84f6612019-01-31 12:20:57 +01002583INSTANTIATE_TEST_SUITE_P(WithAndWithoutOverhead,
2584 RtpSenderTest,
Erik Språngf5815fa2019-08-21 14:27:31 +02002585 ::testing::Values(TestConfig{false},
2586 TestConfig{true}));
Erik Språngf6468d22019-07-05 16:53:43 +02002587
Mirko Bonadeic84f6612019-01-31 12:20:57 +01002588INSTANTIATE_TEST_SUITE_P(WithAndWithoutOverhead,
2589 RtpSenderTestWithoutPacer,
Erik Språngf5815fa2019-08-21 14:27:31 +02002590 ::testing::Values(TestConfig{false},
2591 TestConfig{true}));
Niels Möllera34d7762019-02-01 14:13:29 +01002592
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00002593} // namespace webrtc