blob: 56ba5faa68c047f3f33d9ed39e797bb5b100d626 [file] [log] [blame]
Dave Houlton4d9b2f82018-10-24 18:21:06 -06001/* Copyright (c) 2015-2018 The Khronos Group Inc.
2 * Copyright (c) 2015-2018 Valve Corporation
3 * Copyright (c) 2015-2018 LunarG, Inc.
4 * Copyright (C) 2015-2018 Google Inc.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
John Zulaufa999d1b2018-11-29 13:38:40 -070019 * Author: John Zulauf <jzulauf@lunarg.com>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060020 */
21
22#define NOMINMAX
23
24#include <limits.h>
25#include <math.h>
26#include <stdio.h>
27#include <stdlib.h>
28#include <string.h>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060029
30#include <iostream>
31#include <string>
32#include <sstream>
33#include <unordered_map>
34#include <unordered_set>
35#include <vector>
36#include <mutex>
37
38#include "vk_loader_platform.h"
39#include "vulkan/vk_layer.h"
40#include "vk_layer_config.h"
41#include "vk_dispatch_table_helper.h"
John Zulaufde972ac2017-10-26 12:07:05 -060042#include "vk_typemap_helper.h"
Mark Lobodzinskid4950072017-08-01 13:02:20 -060043
Mark Lobodzinskid4950072017-08-01 13:02:20 -060044#include "vk_layer_data.h"
45#include "vk_layer_logging.h"
46#include "vk_layer_extension_utils.h"
47#include "vk_layer_utils.h"
Lenny Komow4c0da772018-07-03 10:17:21 -060048#include "vk_layer_dispatch_table.h"
Mark Lobodzinskid4950072017-08-01 13:02:20 -060049
50#include "parameter_name.h"
51#include "parameter_validation.h"
52
Mark Lobodzinskid4950072017-08-01 13:02:20 -060053namespace parameter_validation {
54
Mark Lobodzinski78a12a92017-08-08 14:16:51 -060055extern std::unordered_map<std::string, void *> custom_functions;
56
Mark Lobodzinskid4950072017-08-01 13:02:20 -060057extern bool parameter_validation_vkCreateInstance(VkInstance instance, const VkInstanceCreateInfo *pCreateInfo,
58 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance);
59extern bool parameter_validation_vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator);
60extern bool parameter_validation_vkCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
61 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice);
62extern bool parameter_validation_vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator);
63extern bool parameter_validation_vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
64 const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool);
65extern bool parameter_validation_vkCreateDebugReportCallbackEXT(VkInstance instance,
66 const VkDebugReportCallbackCreateInfoEXT *pCreateInfo,
67 const VkAllocationCallbacks *pAllocator,
68 VkDebugReportCallbackEXT *pMsgCallback);
69extern bool parameter_validation_vkDestroyDebugReportCallbackEXT(VkInstance instance, VkDebugReportCallbackEXT msgCallback,
70 const VkAllocationCallbacks *pAllocator);
Mark Young6ba8abe2017-11-09 10:37:04 -070071extern bool parameter_validation_vkCreateDebugUtilsMessengerEXT(VkInstance instance,
72 const VkDebugUtilsMessengerCreateInfoEXT *pCreateInfo,
73 const VkAllocationCallbacks *pAllocator,
74 VkDebugUtilsMessengerEXT *pMessenger);
75extern bool parameter_validation_vkDestroyDebugUtilsMessengerEXT(VkInstance instance, VkDebugUtilsMessengerEXT messenger,
76 const VkAllocationCallbacks *pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060077extern bool parameter_validation_vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo,
78 const VkAllocationCallbacks *pAllocator, VkCommandPool *pCommandPool);
Petr Krause91f7a12017-12-14 20:57:36 +010079extern bool parameter_validation_vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
80 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
Tobias Hectord942eb92018-10-22 15:18:56 +010081extern bool parameter_validation_vkCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
82 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
Petr Krause91f7a12017-12-14 20:57:36 +010083extern bool parameter_validation_vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
84 const VkAllocationCallbacks *pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060085
86// TODO : This can be much smarter, using separate locks for separate global data
87std::mutex global_lock;
88
89static uint32_t loader_layer_if_version = CURRENT_LOADER_LAYER_INTERFACE_VERSION;
90std::unordered_map<void *, layer_data *> layer_data_map;
91std::unordered_map<void *, instance_layer_data *> instance_layer_data_map;
92
93void InitializeManualParameterValidationFunctionPointers(void);
94
95static void init_parameter_validation(instance_layer_data *instance_data, const VkAllocationCallbacks *pAllocator) {
Mark Young6ba8abe2017-11-09 10:37:04 -070096 layer_debug_messenger_actions(instance_data->report_data, instance_data->logging_messenger, pAllocator,
97 "lunarg_parameter_validation");
Mark Lobodzinskid4950072017-08-01 13:02:20 -060098}
99
Mark Young6ba8abe2017-11-09 10:37:04 -0700100static const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION},
101 {VK_EXT_DEBUG_UTILS_EXTENSION_NAME, VK_EXT_DEBUG_UTILS_SPEC_VERSION}};
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600102
103static const VkLayerProperties global_layer = {
Dave Houltonb3bbec72018-01-17 10:13:33 -0700104 "VK_LAYER_LUNARG_parameter_validation",
105 VK_LAYER_API_VERSION,
106 1,
107 "LunarG Validation Layer",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600108};
109
Tobias Hectord942eb92018-10-22 15:18:56 +0100110enum RenderPassCreateVersion { RENDER_PASS_VERSION_1 = 0, RENDER_PASS_VERSION_2 = 1 };
111
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600112static const int MaxParamCheckerStringLength = 256;
113
John Zulauf71968502017-10-26 13:51:15 -0600114template <typename T>
115static inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
116 // Using only < for generality and || for early abort
117 return !((value < min) || (max < value));
118}
119
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600120static bool validate_string(debug_report_data *report_data, const char *apiName, const ParameterName &stringName,
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600121 const std::string &vuid, const char *validateString) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600122 bool skip = false;
123
124 VkStringErrorFlags result = vk_string_validate(MaxParamCheckerStringLength, validateString);
125
126 if (result == VK_STRING_ERROR_NONE) {
127 return skip;
128 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600129 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid,
130 "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(), MaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600131 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600132 skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid,
133 "%s: string %s contains invalid characters or is badly formed", apiName, stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600134 }
135 return skip;
136}
137
138static bool ValidateDeviceQueueFamily(layer_data *device_data, uint32_t queue_family, const char *cmd_name,
Dave Houlton13b65502018-05-23 13:35:24 -0600139 const char *parameter_name, const std::string &error_code, bool optional = false) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600140 bool skip = false;
141
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600142 if (!optional && queue_family == VK_QUEUE_FAMILY_IGNORED) {
143 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600144 HandleToUint64(device_data->device), error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600145 "%s: %s is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family index value.",
146 cmd_name, parameter_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600147 } else if (device_data->queueFamilyIndexMap.find(queue_family) == device_data->queueFamilyIndexMap.end()) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600148 skip |=
149 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Mark Lobodzinski88529492018-04-01 10:38:15 -0600150 HandleToUint64(device_data->device), error_code,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600151 "%s: %s (= %" PRIu32
152 ") is not one of the queue families given via VkDeviceQueueCreateInfo structures when the device was created.",
153 cmd_name, parameter_name, queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600154 }
155
156 return skip;
157}
158
159static bool ValidateQueueFamilies(layer_data *device_data, uint32_t queue_family_count, const uint32_t *queue_families,
Dave Houlton13b65502018-05-23 13:35:24 -0600160 const char *cmd_name, const char *array_parameter_name, const std::string &unique_error_code,
161 const std::string &valid_error_code, bool optional = false) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600162 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600163 if (queue_families) {
164 std::unordered_set<uint32_t> set;
165 for (uint32_t i = 0; i < queue_family_count; ++i) {
166 std::string parameter_name = std::string(array_parameter_name) + "[" + std::to_string(i) + "]";
167
168 if (set.count(queue_families[i])) {
169 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600170 HandleToUint64(device_data->device), "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600171 "%s: %s (=%" PRIu32 ") is not unique within %s array.", cmd_name, parameter_name.c_str(),
172 queue_families[i], array_parameter_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600173 } else {
174 set.insert(queue_families[i]);
175 skip |= ValidateDeviceQueueFamily(device_data, queue_families[i], cmd_name, parameter_name.c_str(),
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600176 valid_error_code, optional);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600177 }
178 }
179 }
180 return skip;
181}
182
John Zulauf620755c2018-04-16 11:00:43 -0600183static bool validate_api_version(const instance_layer_data *instance_data, uint32_t api_version, uint32_t effective_api_version) {
184 bool skip = false;
185 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
186 if (api_version_nopatch != effective_api_version) {
187 if (api_version_nopatch < VK_API_VERSION_1_0) {
188 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600189 HandleToUint64(instance_data->instance), kVUIDUndefined,
John Zulauf620755c2018-04-16 11:00:43 -0600190 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
191 "Using VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
192 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
193 } else {
194 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600195 HandleToUint64(instance_data->instance), kVUIDUndefined,
John Zulauf620755c2018-04-16 11:00:43 -0600196 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
197 "Assuming VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
198 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
199 }
200 }
201 return skip;
202}
203
204template <typename ExtensionState>
Dave Houlton13b65502018-05-23 13:35:24 -0600205static bool validate_extension_reqs(const instance_layer_data *instance_data, const ExtensionState &extensions,
206 const std::string &vuid, const char *extension_type, const char *extension_name) {
John Zulauf620755c2018-04-16 11:00:43 -0600207 bool skip = false;
208 if (!extension_name) {
209 return skip; // Robust to invalid char *
210 }
211 auto info = ExtensionState::get_info(extension_name);
212
213 if (!info.state) {
214 return skip; // Unknown extensions cannot be checked so report OK
215 }
216
Pat Brown3eddb062018-09-05 14:07:37 -0400217 // Check against the required list in the info
John Zulauf620755c2018-04-16 11:00:43 -0600218 std::vector<const char *> missing;
219 for (const auto &req : info.requires) {
220 if (!(extensions.*(req.enabled))) {
221 missing.push_back(req.name);
222 }
223 }
224
225 // Report any missing requirements
226 if (missing.size()) {
227 std::string missing_joined_list = string_join(", ", missing);
228 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT,
Pat Brown3eddb062018-09-05 14:07:37 -0400229 HandleToUint64(instance_data->instance), vuid, "Missing extension%s required by the %s extension %s: %s.",
230 ((missing.size() > 1) ? "s" : ""), extension_type, extension_name, missing_joined_list.c_str());
John Zulauf620755c2018-04-16 11:00:43 -0600231 }
232 return skip;
233}
234
235bool validate_instance_extensions(const instance_layer_data *instance_data, const VkInstanceCreateInfo *pCreateInfo) {
236 bool skip = false;
237 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
Dave Houlton413a6782018-05-22 13:01:54 -0600238 skip |=
239 validate_extension_reqs(instance_data, instance_data->extensions, "VUID-vkCreateInstance-ppEnabledExtensionNames-01388",
240 "instance", pCreateInfo->ppEnabledExtensionNames[i]);
John Zulauf620755c2018-04-16 11:00:43 -0600241 }
242
243 return skip;
244}
245
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600246VKAPI_ATTR VkResult VKAPI_CALL vkCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600247 VkInstance *pInstance) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600248 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
249
250 VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO);
251 assert(chain_info != nullptr);
252 assert(chain_info->u.pLayerInfo != nullptr);
253
254 PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr;
255 PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance");
256 if (fpCreateInstance == NULL) {
257 return VK_ERROR_INITIALIZATION_FAILED;
258 }
259
260 // Advance the link info for the next element on the chain
261 chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext;
262
263 result = fpCreateInstance(pCreateInfo, pAllocator, pInstance);
264
265 if (result == VK_SUCCESS) {
266 InitializeManualParameterValidationFunctionPointers();
267 auto my_instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), instance_layer_data_map);
268 assert(my_instance_data != nullptr);
269
270 layer_init_instance_dispatch_table(*pInstance, &my_instance_data->dispatch_table, fpGetInstanceProcAddr);
271 my_instance_data->instance = *pInstance;
272 my_instance_data->report_data =
Mark Young6ba8abe2017-11-09 10:37:04 -0700273 debug_utils_create_instance(&my_instance_data->dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount,
274 pCreateInfo->ppEnabledExtensionNames);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600275
276 // Look for one or more debug report create info structures
277 // and setup a callback(s) for each one found.
Mark Young6ba8abe2017-11-09 10:37:04 -0700278 if (!layer_copy_tmp_debug_messengers(pCreateInfo->pNext, &my_instance_data->num_tmp_debug_messengers,
279 &my_instance_data->tmp_messenger_create_infos,
280 &my_instance_data->tmp_debug_messengers)) {
281 if (my_instance_data->num_tmp_debug_messengers > 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600282 // Setup the temporary callback(s) here to catch early issues:
Mark Young6ba8abe2017-11-09 10:37:04 -0700283 if (layer_enable_tmp_debug_messengers(my_instance_data->report_data, my_instance_data->num_tmp_debug_messengers,
284 my_instance_data->tmp_messenger_create_infos,
285 my_instance_data->tmp_debug_messengers)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600286 // Failure of setting up one or more of the callback.
287 // Therefore, clean up and don't use those callbacks:
Mark Young6ba8abe2017-11-09 10:37:04 -0700288 layer_free_tmp_debug_messengers(my_instance_data->tmp_messenger_create_infos,
289 my_instance_data->tmp_debug_messengers);
290 my_instance_data->num_tmp_debug_messengers = 0;
291 }
292 }
293 }
294 if (!layer_copy_tmp_report_callbacks(pCreateInfo->pNext, &my_instance_data->num_tmp_report_callbacks,
295 &my_instance_data->tmp_report_create_infos, &my_instance_data->tmp_report_callbacks)) {
296 if (my_instance_data->num_tmp_report_callbacks > 0) {
297 // Setup the temporary callback(s) here to catch early issues:
298 if (layer_enable_tmp_report_callbacks(my_instance_data->report_data, my_instance_data->num_tmp_report_callbacks,
299 my_instance_data->tmp_report_create_infos,
300 my_instance_data->tmp_report_callbacks)) {
301 // Failure of setting up one or more of the callback.
302 // Therefore, clean up and don't use those callbacks:
303 layer_free_tmp_report_callbacks(my_instance_data->tmp_report_create_infos,
304 my_instance_data->tmp_report_callbacks);
305 my_instance_data->num_tmp_report_callbacks = 0;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600306 }
307 }
308 }
309
310 init_parameter_validation(my_instance_data, pAllocator);
John Zulaufe6db8a32018-03-30 14:51:59 -0600311 // Note: From the spec--
312 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
313 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
314 uint32_t api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
315 ? pCreateInfo->pApplicationInfo->apiVersion
316 : VK_API_VERSION_1_0;
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600317
John Zulauf1909e6a2018-09-05 11:43:11 -0600318 my_instance_data->api_version = my_instance_data->extensions.InitFromInstanceCreateInfo(api_version, pCreateInfo);
Mark Lobodzinskibfb7ab92017-10-27 13:22:23 -0600319
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600320 // Ordinarily we'd check these before calling down the chain, but none of the layer support is in place until now, if we
321 // survive we can report the issue now.
John Zulauf1909e6a2018-09-05 11:43:11 -0600322 validate_api_version(my_instance_data, api_version, my_instance_data->api_version);
John Zulauf620755c2018-04-16 11:00:43 -0600323 validate_instance_extensions(my_instance_data, pCreateInfo);
324
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600325 parameter_validation_vkCreateInstance(*pInstance, pCreateInfo, pAllocator, pInstance);
326
327 if (pCreateInfo->pApplicationInfo) {
328 if (pCreateInfo->pApplicationInfo->pApplicationName) {
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600329 validate_string(
330 my_instance_data->report_data, "vkCreateInstance", "pCreateInfo->VkApplicationInfo->pApplicationName",
331 "VUID-VkApplicationInfo-pApplicationName-parameter", pCreateInfo->pApplicationInfo->pApplicationName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600332 }
333
334 if (pCreateInfo->pApplicationInfo->pEngineName) {
335 validate_string(my_instance_data->report_data, "vkCreateInstance", "pCreateInfo->VkApplicationInfo->pEngineName",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600336 "VUID-VkApplicationInfo-pEngineName-parameter", pCreateInfo->pApplicationInfo->pEngineName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600337 }
338 }
339
340 // Disable the tmp callbacks:
Mark Young6ba8abe2017-11-09 10:37:04 -0700341 if (my_instance_data->num_tmp_debug_messengers > 0) {
342 layer_disable_tmp_debug_messengers(my_instance_data->report_data, my_instance_data->num_tmp_debug_messengers,
343 my_instance_data->tmp_debug_messengers);
344 }
345 if (my_instance_data->num_tmp_report_callbacks > 0) {
346 layer_disable_tmp_report_callbacks(my_instance_data->report_data, my_instance_data->num_tmp_report_callbacks,
347 my_instance_data->tmp_report_callbacks);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600348 }
349 }
350
351 return result;
352}
353
354VKAPI_ATTR void VKAPI_CALL vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) {
355 // Grab the key before the instance is destroyed.
356 dispatch_key key = get_dispatch_key(instance);
357 bool skip = false;
358 auto instance_data = GetLayerDataPtr(key, instance_layer_data_map);
359
360 // Enable the temporary callback(s) here to catch vkDestroyInstance issues:
361 bool callback_setup = false;
Mark Young6ba8abe2017-11-09 10:37:04 -0700362 if (instance_data->num_tmp_debug_messengers > 0) {
363 if (!layer_enable_tmp_debug_messengers(instance_data->report_data, instance_data->num_tmp_debug_messengers,
364 instance_data->tmp_messenger_create_infos, instance_data->tmp_debug_messengers)) {
365 callback_setup = true;
366 }
367 }
368 if (instance_data->num_tmp_report_callbacks > 0) {
369 if (!layer_enable_tmp_report_callbacks(instance_data->report_data, instance_data->num_tmp_report_callbacks,
370 instance_data->tmp_report_create_infos, instance_data->tmp_report_callbacks)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600371 callback_setup = true;
372 }
373 }
374
375 skip |= parameter_validation_vkDestroyInstance(instance, pAllocator);
376
377 // Disable and cleanup the temporary callback(s):
378 if (callback_setup) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700379 layer_disable_tmp_debug_messengers(instance_data->report_data, instance_data->num_tmp_debug_messengers,
380 instance_data->tmp_debug_messengers);
381 layer_disable_tmp_report_callbacks(instance_data->report_data, instance_data->num_tmp_report_callbacks,
382 instance_data->tmp_report_callbacks);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600383 }
Mark Young6ba8abe2017-11-09 10:37:04 -0700384 if (instance_data->num_tmp_debug_messengers > 0) {
385 layer_free_tmp_debug_messengers(instance_data->tmp_messenger_create_infos, instance_data->tmp_debug_messengers);
386 instance_data->num_tmp_debug_messengers = 0;
387 }
388 if (instance_data->num_tmp_report_callbacks > 0) {
389 layer_free_tmp_report_callbacks(instance_data->tmp_report_create_infos, instance_data->tmp_report_callbacks);
390 instance_data->num_tmp_report_callbacks = 0;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600391 }
392
393 if (!skip) {
394 instance_data->dispatch_table.DestroyInstance(instance, pAllocator);
395
396 // Clean up logging callback, if any
Mark Young6ba8abe2017-11-09 10:37:04 -0700397 while (instance_data->logging_messenger.size() > 0) {
398 VkDebugUtilsMessengerEXT messenger = instance_data->logging_messenger.back();
399 layer_destroy_messenger_callback(instance_data->report_data, messenger, pAllocator);
400 instance_data->logging_messenger.pop_back();
401 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600402 while (instance_data->logging_callback.size() > 0) {
403 VkDebugReportCallbackEXT callback = instance_data->logging_callback.back();
Mark Young6ba8abe2017-11-09 10:37:04 -0700404 layer_destroy_report_callback(instance_data->report_data, callback, pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600405 instance_data->logging_callback.pop_back();
406 }
407
Mark Young6ba8abe2017-11-09 10:37:04 -0700408 layer_debug_utils_destroy_instance(instance_data->report_data);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600409 }
410
411 FreeLayerDataPtr(key, instance_layer_data_map);
412}
413
414VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugReportCallbackEXT(VkInstance instance,
415 const VkDebugReportCallbackCreateInfoEXT *pCreateInfo,
416 const VkAllocationCallbacks *pAllocator,
417 VkDebugReportCallbackEXT *pMsgCallback) {
418 bool skip = parameter_validation_vkCreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback);
419 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
420
421 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
422 VkResult result = instance_data->dispatch_table.CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback);
423 if (result == VK_SUCCESS) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700424 result = layer_create_report_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMsgCallback);
425 // If something happened during this call, clean up the message callback that was created earlier in the lower levels
426 if (VK_SUCCESS != result) {
427 instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, *pMsgCallback, pAllocator);
428 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600429 }
430 return result;
431}
432
433VKAPI_ATTR void VKAPI_CALL vkDestroyDebugReportCallbackEXT(VkInstance instance, VkDebugReportCallbackEXT msgCallback,
434 const VkAllocationCallbacks *pAllocator) {
435 bool skip = parameter_validation_vkDestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator);
436 if (!skip) {
437 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
438 instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator);
Mark Young6ba8abe2017-11-09 10:37:04 -0700439 layer_destroy_report_callback(instance_data->report_data, msgCallback, pAllocator);
440 }
441}
442
443VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugUtilsMessengerEXT(VkInstance instance,
444 const VkDebugUtilsMessengerCreateInfoEXT *pCreateInfo,
445 const VkAllocationCallbacks *pAllocator,
446 VkDebugUtilsMessengerEXT *pMessenger) {
447 bool skip = parameter_validation_vkCreateDebugUtilsMessengerEXT(instance, pCreateInfo, pAllocator, pMessenger);
448 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
449
450 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
451 VkResult result = instance_data->dispatch_table.CreateDebugUtilsMessengerEXT(instance, pCreateInfo, pAllocator, pMessenger);
452 if (VK_SUCCESS == result) {
453 result = layer_create_messenger_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMessenger);
454 // If something happened during this call, clean up the message callback that was created earlier in the lower levels
455 if (VK_SUCCESS != result) {
456 instance_data->dispatch_table.DestroyDebugUtilsMessengerEXT(instance, *pMessenger, pAllocator);
457 }
458 }
459 return result;
460}
461
462VKAPI_ATTR void VKAPI_CALL vkDestroyDebugUtilsMessengerEXT(VkInstance instance, VkDebugUtilsMessengerEXT messenger,
463 const VkAllocationCallbacks *pAllocator) {
464 bool skip = parameter_validation_vkDestroyDebugUtilsMessengerEXT(instance, messenger, pAllocator);
465 if (!skip) {
466 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
467 instance_data->dispatch_table.DestroyDebugUtilsMessengerEXT(instance, messenger, pAllocator);
468 layer_destroy_messenger_callback(instance_data->report_data, messenger, pAllocator);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600469 }
470}
471
John Zulauf620755c2018-04-16 11:00:43 -0600472template <typename ExtensionState>
473static bool extension_state_by_name(const ExtensionState &extensions, const char *extension_name) {
474 if (!extension_name) return false; // null strings specify nothing
475 auto info = ExtensionState::get_info(extension_name);
476 bool state = info.state ? extensions.*(info.state) : false; // unknown extensions can't be enabled in extension struct
477 return state;
478}
479
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600480static bool ValidateDeviceCreateInfo(instance_layer_data *instance_data, VkPhysicalDevice physicalDevice,
John Zulauf620755c2018-04-16 11:00:43 -0600481 const VkDeviceCreateInfo *pCreateInfo, const DeviceExtensions &extensions) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600482 bool skip = false;
John Zulauf620755c2018-04-16 11:00:43 -0600483 bool maint1 = false;
484 bool negative_viewport = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600485
486 if ((pCreateInfo->enabledLayerCount > 0) && (pCreateInfo->ppEnabledLayerNames != NULL)) {
487 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
488 skip |= validate_string(instance_data->report_data, "vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600489 "VUID-VkDeviceCreateInfo-ppEnabledLayerNames-parameter", pCreateInfo->ppEnabledLayerNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600490 }
491 }
492
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600493 if ((pCreateInfo->enabledExtensionCount > 0) && (pCreateInfo->ppEnabledExtensionNames != NULL)) {
John Zulauf620755c2018-04-16 11:00:43 -0600494 maint1 = extension_state_by_name(extensions, VK_KHR_MAINTENANCE1_EXTENSION_NAME);
495 negative_viewport = extension_state_by_name(extensions, VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME);
496
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600497 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
498 skip |= validate_string(instance_data->report_data, "vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
Mark Lobodzinskiebee3552018-05-29 09:55:54 -0600499 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-parameter",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600500 pCreateInfo->ppEnabledExtensionNames[i]);
Dave Houlton413a6782018-05-22 13:01:54 -0600501 skip |= validate_extension_reqs(instance_data, extensions, "VUID-vkCreateDevice-ppEnabledExtensionNames-01387",
502 "device", pCreateInfo->ppEnabledExtensionNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600503 }
504 }
505
506 if (maint1 && negative_viewport) {
507 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600508 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-00374",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600509 "VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include VK_KHR_maintenance1 and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600510 "VK_AMD_negative_viewport_height.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600511 }
512
513 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
514 // Check for get_physical_device_properties2 struct
John Zulaufde972ac2017-10-26 12:07:05 -0600515 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
516 if (features2) {
517 // Cannot include VkPhysicalDeviceFeatures2KHR and have non-null pEnabledFeatures
518 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600519 kVUID_PVError_InvalidUsage,
John Zulaufde972ac2017-10-26 12:07:05 -0600520 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2KHR struct when "
521 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600522 }
523 }
524
525 // Validate pCreateInfo->pQueueCreateInfos
526 if (pCreateInfo->pQueueCreateInfos) {
527 std::unordered_set<uint32_t> set;
528
529 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
530 const uint32_t requested_queue_family = pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex;
531 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
532 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600533 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600534 "VUID-VkDeviceQueueCreateInfo-queueFamilyIndex-00381",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600535 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -0700536 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600537 "index value.",
538 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600539 } else if (set.count(requested_queue_family)) {
540 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600541 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600542 "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600543 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].queueFamilyIndex (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600544 ") is not unique within pCreateInfo->pQueueCreateInfos array.",
545 i, requested_queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600546 } else {
547 set.insert(requested_queue_family);
548 }
549
550 if (pCreateInfo->pQueueCreateInfos[i].pQueuePriorities != nullptr) {
551 for (uint32_t j = 0; j < pCreateInfo->pQueueCreateInfos[i].queueCount; ++j) {
552 const float queue_priority = pCreateInfo->pQueueCreateInfos[i].pQueuePriorities[j];
553 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
554 skip |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600555 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, HandleToUint64(physicalDevice),
Dave Houlton413a6782018-05-22 13:01:54 -0600556 "VUID-VkDeviceQueueCreateInfo-pQueuePriorities-00383",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600557 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600558 "] (=%f) is not between 0 and 1 (inclusive).",
559 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600560 }
561 }
562 }
563 }
564 }
565
566 return skip;
567}
568
569VKAPI_ATTR VkResult VKAPI_CALL vkCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
570 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) {
571 // NOTE: Don't validate physicalDevice or any dispatchable object as the first parameter. We couldn't get here if it was wrong!
572
573 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
574 bool skip = false;
575 auto my_instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
576 assert(my_instance_data != nullptr);
John Zulauf620755c2018-04-16 11:00:43 -0600577
578 // Query and save physical device limits for this device, needed for validation
579 VkPhysicalDeviceProperties device_properties = {};
580 my_instance_data->dispatch_table.GetPhysicalDeviceProperties(physicalDevice, &device_properties);
581
John Zulauf1909e6a2018-09-05 11:43:11 -0600582 // Setup the validation tables based on the application API version from the instance and the capabilities of the device driver.
583 uint32_t effective_api_version = std::min(device_properties.apiVersion, my_instance_data->api_version);
John Zulauf620755c2018-04-16 11:00:43 -0600584 DeviceExtensions extensions;
John Zulauf1909e6a2018-09-05 11:43:11 -0600585 uint32_t api_version = extensions.InitFromDeviceCreateInfo(&my_instance_data->extensions, effective_api_version, pCreateInfo);
John Zulauf620755c2018-04-16 11:00:43 -0600586
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600587 std::unique_lock<std::mutex> lock(global_lock);
588
589 skip |= parameter_validation_vkCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice);
590
John Zulauf620755c2018-04-16 11:00:43 -0600591 if (pCreateInfo != NULL) skip |= ValidateDeviceCreateInfo(my_instance_data, physicalDevice, pCreateInfo, extensions);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600592
593 if (!skip) {
594 VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO);
595 assert(chain_info != nullptr);
596 assert(chain_info->u.pLayerInfo != nullptr);
597
598 PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr;
599 PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr;
600 PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice");
601 if (fpCreateDevice == NULL) {
602 return VK_ERROR_INITIALIZATION_FAILED;
603 }
604
605 // Advance the link info for the next element on the chain
606 chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext;
607
608 lock.unlock();
609
610 result = fpCreateDevice(physicalDevice, pCreateInfo, pAllocator, pDevice);
611
612 lock.lock();
613
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600614 if (result == VK_SUCCESS) {
615 layer_data *my_device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
616 assert(my_device_data != nullptr);
617
Mark Young6ba8abe2017-11-09 10:37:04 -0700618 my_device_data->report_data = layer_debug_utils_create_device(my_instance_data->report_data, *pDevice);
John Zulauf9b777302018-10-08 11:15:51 -0600619 layer_init_device_dispatch_table(*pDevice, &my_device_data->dispatch_table, fpGetDeviceProcAddr);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600620
John Zulauf620755c2018-04-16 11:00:43 -0600621 my_device_data->api_version = api_version;
622 my_device_data->extensions = extensions;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600623
624 // Store createdevice data
625 if ((pCreateInfo != nullptr) && (pCreateInfo->pQueueCreateInfos != nullptr)) {
626 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
627 my_device_data->queueFamilyIndexMap.insert(std::make_pair(pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex,
628 pCreateInfo->pQueueCreateInfos[i].queueCount));
629 }
630 }
631
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600632 memcpy(&my_device_data->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
633 my_device_data->physical_device = physicalDevice;
634 my_device_data->device = *pDevice;
635
Jeff Bolz5d2b7432018-09-06 10:32:36 -0500636 if (my_device_data->extensions.vk_nv_shading_rate_image) {
637 // Get the needed shading rate image limits
638 auto shading_rate_image_props = lvl_init_struct<VkPhysicalDeviceShadingRateImagePropertiesNV>();
639 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&shading_rate_image_props);
640 my_instance_data->dispatch_table.GetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
641 my_device_data->phys_dev_ext_props.shading_rate_image_props = shading_rate_image_props;
642 }
643
Jeff Bolz45bf7d62018-09-18 15:39:58 -0500644 if (my_device_data->extensions.vk_nv_mesh_shader) {
645 // Get the needed mesh shader limits
646 auto mesh_shader_props = lvl_init_struct<VkPhysicalDeviceMeshShaderPropertiesNV>();
647 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&mesh_shader_props);
648 my_instance_data->dispatch_table.GetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
649 my_device_data->phys_dev_ext_props.mesh_shader_props = mesh_shader_props;
650 }
651
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600652 // Save app-enabled features in this device's layer_data structure
John Zulauf1bde5bb2017-10-18 18:21:23 -0600653 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
654 const VkPhysicalDeviceFeatures *enabled_features_found = pCreateInfo->pEnabledFeatures;
655 if ((nullptr == enabled_features_found) && my_device_data->extensions.vk_khr_get_physical_device_properties_2) {
John Zulaufde972ac2017-10-26 12:07:05 -0600656 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
657 if (features2) {
658 enabled_features_found = &(features2->features);
John Zulauf1bde5bb2017-10-18 18:21:23 -0600659 }
660 }
661 if (enabled_features_found) {
Dave Houltonb3bbec72018-01-17 10:13:33 -0700662 my_device_data->physical_device_features = *enabled_features_found;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600663 } else {
664 memset(&my_device_data->physical_device_features, 0, sizeof(VkPhysicalDeviceFeatures));
665 }
666 }
667 }
668
669 return result;
670}
671
672VKAPI_ATTR void VKAPI_CALL vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) {
673 dispatch_key key = get_dispatch_key(device);
674 bool skip = false;
675 layer_data *device_data = GetLayerDataPtr(key, layer_data_map);
676 {
677 std::unique_lock<std::mutex> lock(global_lock);
678 skip |= parameter_validation_vkDestroyDevice(device, pAllocator);
679 }
680
681 if (!skip) {
Mark Young6ba8abe2017-11-09 10:37:04 -0700682 layer_debug_utils_destroy_device(device);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600683 device_data->dispatch_table.DestroyDevice(device, pAllocator);
684 }
685 FreeLayerDataPtr(key, layer_data_map);
686}
687
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600688bool pv_vkGetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, VkQueue *pQueue) {
689 bool skip = false;
690 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
691
Dave Houlton413a6782018-05-22 13:01:54 -0600692 skip |= ValidateDeviceQueueFamily(device_data, queueFamilyIndex, "vkGetDeviceQueue", "queueFamilyIndex",
693 "VUID-vkGetDeviceQueue-queueFamilyIndex-00384");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600694 const auto &queue_data = device_data->queueFamilyIndexMap.find(queueFamilyIndex);
695 if (queue_data != device_data->queueFamilyIndexMap.end() && queue_data->second <= queueIndex) {
696 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600697 HandleToUint64(device), "VUID-vkGetDeviceQueue-queueIndex-00385",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600698 "vkGetDeviceQueue: queueIndex (=%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -0700699 ") is not less than the number of queues requested from queueFamilyIndex (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600700 ") when the device was created (i.e. is not less than %" PRIu32 ").",
701 queueIndex, queueFamilyIndex, queue_data->second);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600702 }
703 return skip;
704}
705
706VKAPI_ATTR VkResult VKAPI_CALL vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo,
707 const VkAllocationCallbacks *pAllocator, VkCommandPool *pCommandPool) {
708 layer_data *local_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
709 bool skip = false;
710 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
711 std::unique_lock<std::mutex> lock(global_lock);
712
713 skip |= ValidateDeviceQueueFamily(local_data, pCreateInfo->queueFamilyIndex, "vkCreateCommandPool",
Dave Houlton341c0052018-06-21 15:00:45 -0600714 "pCreateInfo->queueFamilyIndex", "VUID-vkCreateCommandPool-queueFamilyIndex-01937");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600715
716 skip |= parameter_validation_vkCreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
717
718 lock.unlock();
719 if (!skip) {
720 result = local_data->dispatch_table.CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
721 }
722 return result;
723}
724
725VKAPI_ATTR VkResult VKAPI_CALL vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
726 const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) {
727 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
728 bool skip = false;
729 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
730
731 skip |= parameter_validation_vkCreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool);
732
733 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
734 if (pCreateInfo != nullptr) {
735 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
736 // VkQueryPipelineStatisticFlagBits values
737 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
738 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
739 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600740 "VUID-VkQueryPoolCreateInfo-queryType-00792",
Dave Houltona9df0ce2018-02-07 10:51:23 -0700741 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
742 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600743 "values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600744 }
745 }
746 if (!skip) {
747 result = device_data->dispatch_table.CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool);
748 }
749 return result;
750}
751
Tobias Hectord942eb92018-10-22 15:18:56 +0100752template <typename T>
753static void RecordRenderPass(layer_data *device_data, VkRenderPass renderPass, const T *pCreateInfo) {
754 auto &renderpass_state = device_data->renderpasses_states[renderPass];
755
756 for (uint32_t subpass = 0; subpass < pCreateInfo->subpassCount; ++subpass) {
757 bool uses_color = false;
758 for (uint32_t i = 0; i < pCreateInfo->pSubpasses[subpass].colorAttachmentCount && !uses_color; ++i)
759 if (pCreateInfo->pSubpasses[subpass].pColorAttachments[i].attachment != VK_ATTACHMENT_UNUSED) uses_color = true;
760
761 bool uses_depthstencil = false;
762 if (pCreateInfo->pSubpasses[subpass].pDepthStencilAttachment)
763 if (pCreateInfo->pSubpasses[subpass].pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)
764 uses_depthstencil = true;
765
766 if (uses_color) renderpass_state.subpasses_using_color_attachment.insert(subpass);
767 if (uses_depthstencil) renderpass_state.subpasses_using_depthstencil_attachment.insert(subpass);
768 }
769}
770
Petr Krause91f7a12017-12-14 20:57:36 +0100771VKAPI_ATTR VkResult VKAPI_CALL vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
772 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) {
773 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
774 bool skip = false;
775 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
776
777 {
778 std::unique_lock<std::mutex> lock(global_lock);
779 skip |= parameter_validation_vkCreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
780
Dave Houltonb3bbec72018-01-17 10:13:33 -0700781 typedef bool (*PFN_manual_vkCreateRenderPass)(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
782 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
Petr Krause91f7a12017-12-14 20:57:36 +0100783 PFN_manual_vkCreateRenderPass custom_func = (PFN_manual_vkCreateRenderPass)custom_functions["vkCreateRenderPass"];
784 if (custom_func != nullptr) {
785 skip |= custom_func(device, pCreateInfo, pAllocator, pRenderPass);
786 }
787 }
788
789 if (!skip) {
790 result = device_data->dispatch_table.CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
791
792 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
793 if (result == VK_SUCCESS) {
794 std::unique_lock<std::mutex> lock(global_lock);
Tobias Hectord942eb92018-10-22 15:18:56 +0100795 RecordRenderPass(device_data, *pRenderPass, pCreateInfo);
796 }
797 }
798 return result;
799}
Petr Krause91f7a12017-12-14 20:57:36 +0100800
Tobias Hectord942eb92018-10-22 15:18:56 +0100801VKAPI_ATTR VkResult VKAPI_CALL vkCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
802 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) {
803 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
804 bool skip = false;
805 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
Petr Krause91f7a12017-12-14 20:57:36 +0100806
Tobias Hectord942eb92018-10-22 15:18:56 +0100807 {
808 std::unique_lock<std::mutex> lock(global_lock);
809 skip |= parameter_validation_vkCreateRenderPass2KHR(device, pCreateInfo, pAllocator, pRenderPass);
Petr Krause91f7a12017-12-14 20:57:36 +0100810
Tobias Hectord942eb92018-10-22 15:18:56 +0100811 typedef bool (*PFN_manual_vkCreateRenderPass2KHR)(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
812 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass);
813 PFN_manual_vkCreateRenderPass2KHR custom_func =
814 (PFN_manual_vkCreateRenderPass2KHR)custom_functions["vkCreateRenderPass2KHR"];
815 if (custom_func != nullptr) {
816 skip |= custom_func(device, pCreateInfo, pAllocator, pRenderPass);
817 }
818 }
819
820 if (!skip) {
821 result = device_data->dispatch_table.CreateRenderPass2KHR(device, pCreateInfo, pAllocator, pRenderPass);
822
823 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
824 if (result == VK_SUCCESS) {
825 std::unique_lock<std::mutex> lock(global_lock);
826 RecordRenderPass(device_data, *pRenderPass, pCreateInfo);
Petr Krause91f7a12017-12-14 20:57:36 +0100827 }
828 }
829 return result;
830}
831
832VKAPI_ATTR void VKAPI_CALL vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) {
833 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
834 bool skip = false;
835
836 {
837 std::unique_lock<std::mutex> lock(global_lock);
838 skip |= parameter_validation_vkDestroyRenderPass(device, renderPass, pAllocator);
839
Dave Houltonb3bbec72018-01-17 10:13:33 -0700840 typedef bool (*PFN_manual_vkDestroyRenderPass)(VkDevice device, VkRenderPass renderPass,
841 const VkAllocationCallbacks *pAllocator);
Petr Krause91f7a12017-12-14 20:57:36 +0100842 PFN_manual_vkDestroyRenderPass custom_func = (PFN_manual_vkDestroyRenderPass)custom_functions["vkDestroyRenderPass"];
843 if (custom_func != nullptr) {
844 skip |= custom_func(device, renderPass, pAllocator);
845 }
846 }
847
848 if (!skip) {
849 device_data->dispatch_table.DestroyRenderPass(device, renderPass, pAllocator);
850
851 // track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
852 {
853 std::unique_lock<std::mutex> lock(global_lock);
854 device_data->renderpasses_states.erase(renderPass);
855 }
856 }
857}
858
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600859bool pv_vkCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
860 VkBuffer *pBuffer) {
861 bool skip = false;
862 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
863 debug_report_data *report_data = device_data->report_data;
864
Mark Lobodzinski88529492018-04-01 10:38:15 -0600865 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, VK_NULL_HANDLE, "vkCreateBuffer"};
Petr Krause5c37652018-01-05 04:05:12 +0100866
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600867 if (pCreateInfo != nullptr) {
Dave Houlton413a6782018-05-22 13:01:54 -0600868 skip |= ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", "VUID-VkBufferCreateInfo-size-00912", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600869
870 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
871 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
872 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
873 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600874 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600875 "VUID-VkBufferCreateInfo-sharingMode-00914",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600876 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600877 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600878 }
879
880 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
881 // queueFamilyIndexCount uint32_t values
882 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600883 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600884 "VUID-VkBufferCreateInfo-sharingMode-00913",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600885 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
886 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600887 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600888 } else {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600889 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
Dave Houlton413a6782018-05-22 13:01:54 -0600890 "vkCreateBuffer", "pCreateInfo->pQueueFamilyIndices", kVUID_PVError_InvalidUsage,
891 kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600892 }
893 }
894
895 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
896 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
897 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
898 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600899 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600900 "VUID-VkBufferCreateInfo-flags-00918",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600901 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600902 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600903 }
904 }
905
906 return skip;
907}
908
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600909bool pv_vkCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
910 VkImage *pImage) {
911 bool skip = false;
912 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
913 debug_report_data *report_data = device_data->report_data;
914
Mark Lobodzinski88529492018-04-01 10:38:15 -0600915 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE, "vkCreateImage"};
Petr Krause5c37652018-01-05 04:05:12 +0100916
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600917 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600918 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
919 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
920 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
921 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600922 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600923 "VUID-VkImageCreateInfo-sharingMode-00942",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600924 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600925 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600926 }
927
928 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
929 // queueFamilyIndexCount uint32_t values
930 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600931 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600932 "VUID-VkImageCreateInfo-sharingMode-00941",
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600933 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
934 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600935 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600936 } else {
Dave Houlton413a6782018-05-22 13:01:54 -0600937 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
938 "vkCreateImage", "pCreateInfo->pQueueFamilyIndices", kVUID_PVError_InvalidUsage,
939 kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600940 }
941 }
942
Dave Houlton413a6782018-05-22 13:01:54 -0600943 skip |= ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width",
944 "VUID-VkImageCreateInfo-extent-00944", log_misc);
945 skip |= ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height",
946 "VUID-VkImageCreateInfo-extent-00945", log_misc);
947 skip |= ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth",
948 "VUID-VkImageCreateInfo-extent-00946", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600949
Dave Houlton413a6782018-05-22 13:01:54 -0600950 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", "VUID-VkImageCreateInfo-mipLevels-00947",
951 log_misc);
952 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers",
953 "VUID-VkImageCreateInfo-arrayLayers-00948", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600954
Dave Houlton130c0212018-01-29 13:39:56 -0700955 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700956 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
957 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
958 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -0600959 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
960 "VUID-VkImageCreateInfo-initialLayout-00993",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600961 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
962 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700963 }
964
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600965 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100966 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
967 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -0600968 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600969 "VUID-VkImageCreateInfo-imageType-00956",
Dave Houltona9df0ce2018-02-07 10:51:23 -0700970 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600971 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600972 }
973
974 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
Petr Kraus3f433212018-03-13 12:31:27 +0100975 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
976 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600977 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600978 VK_NULL_HANDLE, "VUID-VkImageCreateInfo-imageType-00954",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600979 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
980 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
981 ") are not equal.",
982 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100983 }
984
985 if (pCreateInfo->arrayLayers < 6) {
986 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -0600987 VK_NULL_HANDLE, "VUID-VkImageCreateInfo-imageType-00954",
Petr Kraus3f433212018-03-13 12:31:27 +0100988 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600989 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
990 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +0100991 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600992 }
993
994 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski88529492018-04-01 10:38:15 -0600995 skip |=
996 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -0600997 "VUID-VkImageCreateInfo-imageType-00957",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600998 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600999 }
1000 }
1001
Dave Houlton130c0212018-01-29 13:39:56 -07001002 // 3D image may have only 1 layer
1003 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001004 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001005 "VUID-VkImageCreateInfo-imageType-00961",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001006 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -07001007 }
1008
1009 // If multi-sample, validate type, usage, tiling and mip levels.
1010 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
1011 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
Shannon McPhersona886c2a2018-10-12 14:38:20 -06001012 (pCreateInfo->mipLevels != 1) || (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001013 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Shannon McPhersona886c2a2018-10-12 14:38:20 -06001014 "VUID-VkImageCreateInfo-samples-02257",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001015 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
Dave Houlton130c0212018-01-29 13:39:56 -07001016 }
1017
1018 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
1019 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
1020 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
1021 // At least one of the legal attachment bits must be set
1022 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001023 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001024 "VUID-VkImageCreateInfo-usage-00966",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001025 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -07001026 }
1027 // No flags other than the legal attachment bits may be set
1028 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
1029 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001030 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001031 "VUID-VkImageCreateInfo-usage-00963",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001032 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -07001033 }
1034 }
1035
Jeff Bolzef40fec2018-09-01 22:04:34 -05001036 // mipLevels must be less than or equal to the number of levels in the complete mipmap chain
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001037 uint32_t maxDim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Jeff Bolzef40fec2018-09-01 22:04:34 -05001038 // Max mip levels is different for corner-sampled images vs normal images.
Dave Houlton142c4cb2018-10-17 15:04:41 -06001039 uint32_t maxMipLevels = (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) ? (uint32_t)(ceil(log2(maxDim)))
1040 : (uint32_t)(floor(log2(maxDim)) + 1);
Jeff Bolzef40fec2018-09-01 22:04:34 -05001041 if (maxDim > 0 && pCreateInfo->mipLevels > maxMipLevels) {
Dave Houlton413a6782018-05-22 13:01:54 -06001042 skip |=
1043 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1044 "VUID-VkImageCreateInfo-mipLevels-00958",
1045 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
1046 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001047 }
1048
Mark Lobodzinski69259c52018-09-18 15:14:58 -06001049 if ((pCreateInfo->flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT) && (pCreateInfo->imageType != VK_IMAGE_TYPE_3D)) {
1050 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE,
1051 "VUID-VkImageCreateInfo-flags-00950",
1052 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT but "
1053 "pCreateInfo->imageType is not VK_IMAGE_TYPE_3D.");
1054 }
1055
Petr Krausb6f97802018-03-13 12:31:39 +01001056 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!device_data->physical_device_features.sparseBinding)) {
1057 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001058 "VUID-VkImageCreateInfo-flags-00969",
Petr Krausb6f97802018-03-13 12:31:39 +01001059 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001060 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +01001061 }
1062
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001063 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
1064 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
1065 if (((pCreateInfo->flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
1066 ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001067 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001068 "VUID-VkImageCreateInfo-flags-00987",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001069 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001070 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001071 }
1072
1073 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
1074 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
1075 // Linear tiling is unsupported
1076 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
Dave Houlton413a6782018-05-22 13:01:54 -06001077 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1078 kVUID_PVError_InvalidUsage,
1079 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
1080 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001081 }
1082
1083 // Sparse 1D image isn't valid
1084 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001085 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001086 "VUID-VkImageCreateInfo-imageType-00970",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001087 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001088 }
1089
1090 // Sparse 2D image when device doesn't support it
1091 if ((VK_FALSE == device_data->physical_device_features.sparseResidencyImage2D) &&
1092 (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001093 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001094 "VUID-VkImageCreateInfo-imageType-00971",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001095 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001096 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001097 }
1098
1099 // Sparse 3D image when device doesn't support it
1100 if ((VK_FALSE == device_data->physical_device_features.sparseResidencyImage3D) &&
1101 (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06001102 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001103 "VUID-VkImageCreateInfo-imageType-00972",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001104 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001105 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001106 }
1107
1108 // Multi-sample 2D image when device doesn't support it
1109 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
1110 if ((VK_FALSE == device_data->physical_device_features.sparseResidency2Samples) &&
1111 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001112 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001113 "VUID-VkImageCreateInfo-imageType-00973",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001114 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001115 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001116 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency4Samples) &&
1117 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001118 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001119 "VUID-VkImageCreateInfo-imageType-00974",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001120 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001121 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001122 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency8Samples) &&
1123 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001124 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001125 "VUID-VkImageCreateInfo-imageType-00975",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001126 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001127 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001128 } else if ((VK_FALSE == device_data->physical_device_features.sparseResidency16Samples) &&
1129 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07001130 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001131 "VUID-VkImageCreateInfo-imageType-00976",
Dave Houltona9df0ce2018-02-07 10:51:23 -07001132 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001133 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001134 }
1135 }
1136 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001137
Jeff Bolz9af91c52018-09-01 21:53:57 -05001138 if (pCreateInfo->usage & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) {
1139 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
1140 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1141 "VUID-VkImageCreateInfo-imageType-02082",
1142 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1143 "imageType must be VK_IMAGE_TYPE_2D.");
1144 }
1145 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
1146 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1147 "VUID-VkImageCreateInfo-samples-02083",
1148 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1149 "samples must be VK_SAMPLE_COUNT_1_BIT.");
1150 }
1151 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
1152 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1153 "VUID-VkImageCreateInfo-tiling-02084",
1154 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
1155 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
1156 }
1157 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001158
1159 if (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001160 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D && pCreateInfo->imageType != VK_IMAGE_TYPE_3D) {
Jeff Bolzef40fec2018-09-01 22:04:34 -05001161 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1162 "VUID-VkImageCreateInfo-flags-02050",
1163 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
1164 "imageType must be VK_IMAGE_TYPE_2D or VK_IMAGE_TYPE_3D.");
1165 }
1166
Dave Houlton142c4cb2018-10-17 15:04:41 -06001167 if ((pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) || FormatIsDepthOrStencil(pCreateInfo->format)) {
Jeff Bolzef40fec2018-09-01 22:04:34 -05001168 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1169 "VUID-VkImageCreateInfo-flags-02051",
1170 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
1171 "it must not also contain VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT and format must "
1172 "not be a depth/stencil format.");
1173 }
1174
Dave Houlton142c4cb2018-10-17 15:04:41 -06001175 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D && (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1)) {
Jeff Bolzef40fec2018-09-01 22:04:34 -05001176 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1177 "VUID-VkImageCreateInfo-flags-02052",
1178 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
1179 "imageType is VK_IMAGE_TYPE_2D, extent.width and extent.height must be "
1180 "greater than 1.");
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001181 } else if (pCreateInfo->imageType == VK_IMAGE_TYPE_3D &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06001182 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1 || pCreateInfo->extent.depth == 1)) {
Jeff Bolzef40fec2018-09-01 22:04:34 -05001183 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1184 "VUID-VkImageCreateInfo-flags-02053",
1185 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
1186 "imageType is VK_IMAGE_TYPE_3D, extent.width, extent.height, and extent.depth "
1187 "must be greater than 1.");
Jeff Bolzef40fec2018-09-01 22:04:34 -05001188 }
1189 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001190 }
Jeff Bolzef40fec2018-09-01 22:04:34 -05001191
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001192 return skip;
1193}
1194
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001195bool pv_vkCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
1196 VkImageView *pView) {
1197 bool skip = false;
1198 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1199 debug_report_data *report_data = device_data->report_data;
1200
1201 if (pCreateInfo != nullptr) {
Dave Houltonbd2e2622018-04-10 16:41:14 -06001202 // Validate chained VkImageViewUsageCreateInfo struct, if present
1203 if (nullptr != pCreateInfo->pNext) {
1204 auto chained_ivuci_struct = lvl_find_in_chain<VkImageViewUsageCreateInfoKHR>(pCreateInfo->pNext);
1205 if (chained_ivuci_struct) {
1206 if (0 == chained_ivuci_struct->usage) {
1207 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001208 "VUID-VkImageViewUsageCreateInfo-usage-requiredbitmask",
Dave Houlton0f3795b2018-04-13 15:04:35 -06001209 "vkCreateImageView: Chained VkImageViewUsageCreateInfo usage field must not be 0.");
Dave Houltonbd2e2622018-04-10 16:41:14 -06001210 } else if (chained_ivuci_struct->usage & ~AllVkImageUsageFlagBits) {
1211 std::stringstream ss;
1212 ss << "vkCreateImageView: Chained VkImageViewUsageCreateInfo usage field (0x" << std::hex
1213 << chained_ivuci_struct->usage << ") contains invalid flag bits.";
1214 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001215 "VUID-VkImageViewUsageCreateInfo-usage-parameter", "%s", ss.str().c_str());
Dave Houltonbd2e2622018-04-10 16:41:14 -06001216 }
1217 }
1218 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001219 }
1220 return skip;
1221}
1222
Petr Krausb3fcdb42018-01-09 22:09:09 +01001223bool pv_VkViewport(const layer_data *device_data, const VkViewport &viewport, const char *fn_name, const char *param_name,
1224 VkDebugReportObjectTypeEXT object_type, uint64_t object = 0) {
1225 bool skip = false;
1226 debug_report_data *report_data = device_data->report_data;
1227
1228 // Note: for numerical correctness
1229 // - float comparisons should expect NaN (comparison always false).
1230 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
1231
1232 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -07001233 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001234 if (v1_f <= 0.0f) return true;
1235
1236 float intpart;
1237 const float fract = modff(v1_f, &intpart);
1238
1239 assert(std::numeric_limits<float>::radix == 2);
1240 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
1241 if (intpart >= u32_max_plus1) return false;
1242
1243 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
1244 if (v1_u32 < v2_u32)
1245 return true;
1246 else if (v1_u32 == v2_u32 && fract == 0.0f)
1247 return true;
1248 else
1249 return false;
1250 };
1251
1252 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
1253 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
1254 return (v1_f <= v2_f);
1255 };
1256
1257 // width
1258 bool width_healthy = true;
1259 const auto max_w = device_data->device_limits.maxViewportDimensions[0];
1260
1261 if (!(viewport.width > 0.0f)) {
1262 width_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001263 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-width-01770",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001264 "%s: %s.width (=%f) is not greater than 0.0.", fn_name, param_name, viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001265 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
1266 width_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001267 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-width-01771",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001268 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
1269 param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001270 } else if (!f_lte_u32_exact(viewport.width, max_w) && f_lte_u32_direct(viewport.width, max_w)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001271 skip |= log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001272 "%s: %s.width (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001273 "), but it is within the static_cast<float>(maxViewportDimensions[0]) limit.",
1274 fn_name, param_name, viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001275 }
1276
1277 // height
1278 bool height_healthy = true;
Petr Krausaf9c1222018-03-10 02:39:47 +01001279 const bool negative_height_enabled = device_data->api_version >= VK_API_VERSION_1_1 ||
1280 device_data->extensions.vk_khr_maintenance1 ||
1281 device_data->extensions.vk_amd_negative_viewport_height;
Petr Krausb3fcdb42018-01-09 22:09:09 +01001282 const auto max_h = device_data->device_limits.maxViewportDimensions[1];
1283
1284 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
1285 height_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001286 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-height-01772",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001287 "%s: %s.height (=%f) is not greater 0.0.", fn_name, param_name, viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001288 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
1289 height_healthy = false;
1290
Dave Houlton413a6782018-05-22 13:01:54 -06001291 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-height-01773",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001292 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
1293 ").",
1294 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001295 } else if (!f_lte_u32_exact(fabsf(viewport.height), max_h) && f_lte_u32_direct(fabsf(viewport.height), max_h)) {
1296 height_healthy = false;
1297
1298 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -06001299 report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, object_type, object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +01001300 "%s: Absolute value of %s.height (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001301 "), but it is within the static_cast<float>(maxViewportDimensions[1]) limit.",
1302 fn_name, param_name, viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001303 }
1304
1305 // x
1306 bool x_healthy = true;
1307 if (!(viewport.x >= device_data->device_limits.viewportBoundsRange[0])) {
1308 x_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001309 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-x-01774",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001310 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
1311 viewport.x, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001312 }
1313
1314 // x + width
1315 if (x_healthy && width_healthy) {
1316 const float right_bound = viewport.x + viewport.width;
1317 if (!(right_bound <= device_data->device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001318 skip |=
Dave Houlton413a6782018-05-22 13:01:54 -06001319 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-x-01232",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001320 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1321 fn_name, param_name, param_name, viewport.x, viewport.width, right_bound,
1322 device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001323 }
1324 }
1325
1326 // y
1327 bool y_healthy = true;
1328 if (!(viewport.y >= device_data->device_limits.viewportBoundsRange[0])) {
1329 y_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001330 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01775",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001331 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name, param_name,
1332 viewport.y, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001333 } else if (negative_height_enabled && !(viewport.y <= device_data->device_limits.viewportBoundsRange[1])) {
1334 y_healthy = false;
Dave Houlton413a6782018-05-22 13:01:54 -06001335 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01776",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001336 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name, param_name,
1337 viewport.y, device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001338 }
1339
1340 // y + height
1341 if (y_healthy && height_healthy) {
1342 const float boundary = viewport.y + viewport.height;
1343
1344 if (!(boundary <= device_data->device_limits.viewportBoundsRange[1])) {
Dave Houlton413a6782018-05-22 13:01:54 -06001345 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01233",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001346 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
1347 fn_name, param_name, param_name, viewport.y, viewport.height, boundary,
1348 device_data->device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001349 } else if (negative_height_enabled && !(boundary >= device_data->device_limits.viewportBoundsRange[0])) {
1350 skip |= log_msg(
Dave Houlton413a6782018-05-22 13:01:54 -06001351 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-y-01777",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001352 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
1353 param_name, param_name, viewport.y, viewport.height, boundary, device_data->device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001354 }
1355 }
1356
1357 if (!device_data->extensions.vk_ext_depth_range_unrestricted) {
1358 // minDepth
1359 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001360 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-minDepth-01234",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001361
Petr Krausb3fcdb42018-01-09 22:09:09 +01001362 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001363 "[0.0, 1.0] range.",
1364 fn_name, param_name, viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001365 }
1366
1367 // maxDepth
1368 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
Dave Houlton413a6782018-05-22 13:01:54 -06001369 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object, "VUID-VkViewport-maxDepth-01235",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001370
Petr Krausb3fcdb42018-01-09 22:09:09 +01001371 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001372 "[0.0, 1.0] range.",
1373 fn_name, param_name, viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +01001374 }
1375 }
1376
1377 return skip;
1378}
1379
Dave Houlton142c4cb2018-10-17 15:04:41 -06001380struct SampleOrderInfo {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001381 VkShadingRatePaletteEntryNV shadingRate;
1382 uint32_t width;
1383 uint32_t height;
1384};
1385
1386// All palette entries with more than one pixel per fragment
Dave Houlton142c4cb2018-10-17 15:04:41 -06001387static SampleOrderInfo sampleOrderInfos[] = {
1388 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_1X2_PIXELS_NV, 1, 2},
1389 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X1_PIXELS_NV, 2, 1},
1390 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X2_PIXELS_NV, 2, 2},
1391 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X2_PIXELS_NV, 4, 2},
1392 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X4_PIXELS_NV, 2, 4},
1393 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X4_PIXELS_NV, 4, 4},
Jeff Bolz9af91c52018-09-01 21:53:57 -05001394};
1395
Dave Houlton142c4cb2018-10-17 15:04:41 -06001396bool ValidateCoarseSampleOrderCustomNV(layer_data *device_data, const VkCoarseSampleOrderCustomNV *order) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001397 bool skip = false;
1398 debug_report_data *report_data = device_data->report_data;
1399
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001400 SampleOrderInfo *sampleOrderInfo;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001401 uint32_t infoIdx = 0;
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001402 for (sampleOrderInfo = nullptr; infoIdx < ARRAY_SIZE(sampleOrderInfos); ++infoIdx) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001403 if (sampleOrderInfos[infoIdx].shadingRate == order->shadingRate) {
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001404 sampleOrderInfo = &sampleOrderInfos[infoIdx];
Jeff Bolz9af91c52018-09-01 21:53:57 -05001405 break;
1406 }
1407 }
1408
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001409 if (sampleOrderInfo == nullptr) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001410 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1411 "VUID-VkCoarseSampleOrderCustomNV-shadingRate-02073",
1412 "VkCoarseSampleOrderCustomNV shadingRate must be a shading rate "
1413 "that generates fragments with more than one pixel.");
1414 return skip;
1415 }
1416
Dave Houlton142c4cb2018-10-17 15:04:41 -06001417 if (order->sampleCount == 0 || (order->sampleCount & (order->sampleCount - 1)) ||
Jeff Bolz9af91c52018-09-01 21:53:57 -05001418 !(order->sampleCount & device_data->device_limits.framebufferNoAttachmentsSampleCounts)) {
1419 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1420 "VUID-VkCoarseSampleOrderCustomNV-sampleCount-02074",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001421 "VkCoarseSampleOrderCustomNV sampleCount (=%" PRIu32
1422 ") must "
Jeff Bolz9af91c52018-09-01 21:53:57 -05001423 "correspond to a sample count enumerated in VkSampleCountFlags whose corresponding bit "
1424 "is set in framebufferNoAttachmentsSampleCounts.",
1425 order->sampleCount);
1426 }
1427
Jeff Bolz9af91c52018-09-01 21:53:57 -05001428 if (order->sampleLocationCount != order->sampleCount * sampleOrderInfo->width * sampleOrderInfo->height) {
1429 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1430 "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02075",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001431 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1432 ") must "
1433 "be equal to the product of sampleCount (=%" PRIu32
1434 "), the fragment width for shadingRate "
Jeff Bolz9af91c52018-09-01 21:53:57 -05001435 "(=%" PRIu32 "), and the fragment height for shadingRate (=%" PRIu32 ").",
1436 order->sampleLocationCount, order->sampleCount, sampleOrderInfo->width, sampleOrderInfo->height);
1437 }
1438
Jeff Bolz5d2b7432018-09-06 10:32:36 -05001439 if (order->sampleLocationCount > device_data->phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001440 skip |= log_msg(
1441 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1442 "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02076",
1443 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
1444 ") must "
1445 "be less than or equal to VkPhysicalDeviceShadingRateImagePropertiesNV shadingRateMaxCoarseSamples (=%" PRIu32 ").",
1446 order->sampleLocationCount, device_data->phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001447 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001448
1449 // Accumulate a bitmask tracking which (x,y,sample) tuples are seen. Expect
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001450 // the first width*height*sampleCount bits to all be set. Note: There is no
1451 // guarantee that 64 bits is enough, but practically it's unlikely for an
1452 // implementation to support more than 32 bits for samplemask.
Jeff Bolz45bf7d62018-09-18 15:39:58 -05001453 assert(device_data->phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples <= 64);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001454 uint64_t sampleLocationsMask = 0;
1455 for (uint32_t i = 0; i < order->sampleLocationCount; ++i) {
1456 const VkCoarseSampleLocationNV *sampleLoc = &order->pSampleLocations[i];
1457 if (sampleLoc->pixelX >= sampleOrderInfo->width) {
1458 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1459 "VUID-VkCoarseSampleLocationNV-pixelX-02078",
1460 "pixelX must be less than the width (in pixels) of the fragment.");
1461 }
1462 if (sampleLoc->pixelY >= sampleOrderInfo->height) {
1463 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1464 "VUID-VkCoarseSampleLocationNV-pixelY-02079",
1465 "pixelY must be less than the height (in pixels) of the fragment.");
1466 }
1467 if (sampleLoc->sample >= order->sampleCount) {
1468 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1469 "VUID-VkCoarseSampleLocationNV-sample-02080",
1470 "sample must be less than the number of coverage samples in each pixel belonging to the fragment.");
1471 }
1472 uint32_t idx = sampleLoc->sample + order->sampleCount * (sampleLoc->pixelX + sampleOrderInfo->width * sampleLoc->pixelY);
1473 sampleLocationsMask |= 1ULL << idx;
1474 }
1475
1476 uint64_t expectedMask = (order->sampleLocationCount == 64) ? ~0ULL : ((1ULL << order->sampleLocationCount) - 1);
1477 if (sampleLocationsMask != expectedMask) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001478 skip |= log_msg(
1479 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1480 "VUID-VkCoarseSampleOrderCustomNV-pSampleLocations-02077",
1481 "The array pSampleLocations must contain exactly one entry for "
1482 "every combination of valid values for pixelX, pixelY, and sample in the structure VkCoarseSampleOrderCustomNV.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05001483 }
1484
1485 return skip;
1486}
1487
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001488bool pv_vkCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t createInfoCount,
1489 const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator,
1490 VkPipeline *pPipelines) {
1491 bool skip = false;
1492 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
1493 debug_report_data *report_data = device_data->report_data;
1494
1495 if (pCreateInfos != nullptr) {
1496 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001497 bool has_dynamic_viewport = false;
1498 bool has_dynamic_scissor = false;
1499 bool has_dynamic_line_width = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001500 bool has_dynamic_viewport_w_scaling_nv = false;
1501 bool has_dynamic_discard_rectangle_ext = false;
1502 bool has_dynamic_sample_locations_ext = false;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001503 bool has_dynamic_exclusive_scissor_nv = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001504 bool has_dynamic_shading_rate_palette_nv = false;
Petr Kraus299ba622017-11-24 03:09:03 +01001505 if (pCreateInfos[i].pDynamicState != nullptr) {
1506 const auto &dynamic_state_info = *pCreateInfos[i].pDynamicState;
1507 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1508 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
1509 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) has_dynamic_viewport = true;
1510 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) has_dynamic_scissor = true;
1511 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) has_dynamic_line_width = true;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001512 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) has_dynamic_viewport_w_scaling_nv = true;
1513 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) has_dynamic_discard_rectangle_ext = true;
1514 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) has_dynamic_sample_locations_ext = true;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001515 if (dynamic_state == VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV) has_dynamic_exclusive_scissor_nv = true;
Dave Houlton142c4cb2018-10-17 15:04:41 -06001516 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV)
1517 has_dynamic_shading_rate_palette_nv = true;
Petr Kraus299ba622017-11-24 03:09:03 +01001518 }
1519 }
1520
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001521 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
1522 if (pCreateInfos[i].pVertexInputState != nullptr) {
1523 auto const &vertex_input_state = pCreateInfos[i].pVertexInputState;
Peter Kohautc7d9d392018-07-15 00:34:07 +02001524
1525 if (vertex_input_state->vertexBindingDescriptionCount > device_data->device_limits.maxVertexInputBindings) {
1526 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1527 "VUID-VkPipelineVertexInputStateCreateInfo-vertexBindingDescriptionCount-00613",
1528 "vkCreateGraphicsPipelines: pararameter "
1529 "pCreateInfo[%d].pVertexInputState->vertexBindingDescriptionCount (%u) is "
1530 "greater than VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1531 i, vertex_input_state->vertexBindingDescriptionCount,
1532 device_data->device_limits.maxVertexInputBindings);
1533 }
1534
1535 if (vertex_input_state->vertexAttributeDescriptionCount > device_data->device_limits.maxVertexInputAttributes) {
1536 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1537 "VUID-VkPipelineVertexInputStateCreateInfo-vertexAttributeDescriptionCount-00614",
1538 "vkCreateGraphicsPipelines: pararameter "
Peter Kohaut9e92c5c2018-07-17 10:32:17 +02001539 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptionCount (%u) is "
Peter Kohautc7d9d392018-07-15 00:34:07 +02001540 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1541 i, vertex_input_state->vertexBindingDescriptionCount,
1542 device_data->device_limits.maxVertexInputAttributes);
1543 }
1544
1545 std::unordered_set<uint32_t> vertex_bindings(vertex_input_state->vertexBindingDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001546 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
1547 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001548 auto const &binding_it = vertex_bindings.find(vertex_bind_desc.binding);
1549 if (binding_it != vertex_bindings.cend()) {
1550 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1551 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-00616",
1552 "vkCreateGraphicsPipelines: parameter "
1553 "pCreateInfo[%d].pVertexInputState->pVertexBindingDescription[%d].binding "
1554 "(%" PRIu32 ") is not distinct.",
1555 i, d, vertex_bind_desc.binding);
1556 }
1557 vertex_bindings.insert(vertex_bind_desc.binding);
1558
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001559 if (vertex_bind_desc.binding >= device_data->device_limits.maxVertexInputBindings) {
1560 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001561 "VUID-VkVertexInputBindingDescription-binding-00618",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001562 "vkCreateGraphicsPipelines: parameter "
1563 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001564 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1565 i, d, vertex_bind_desc.binding, device_data->device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001566 }
1567
1568 if (vertex_bind_desc.stride > device_data->device_limits.maxVertexInputBindingStride) {
1569 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001570 "VUID-VkVertexInputBindingDescription-stride-00619",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001571 "vkCreateGraphicsPipelines: parameter "
1572 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].stride (%u) is greater "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001573 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%u).",
1574 i, d, vertex_bind_desc.stride, device_data->device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001575 }
1576 }
1577
Peter Kohautc7d9d392018-07-15 00:34:07 +02001578 std::unordered_set<uint32_t> attribute_locations(vertex_input_state->vertexAttributeDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001579 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
1580 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001581 auto const &location_it = attribute_locations.find(vertex_attrib_desc.location);
1582 if (location_it != attribute_locations.cend()) {
1583 skip |= log_msg(
1584 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1585 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-00617",
1586 "vkCreateGraphicsPipelines: parameter "
1587 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].location (%u) is not distinct.",
1588 i, d, vertex_attrib_desc.location);
1589 }
1590 attribute_locations.insert(vertex_attrib_desc.location);
1591
1592 auto const &binding_it = vertex_bindings.find(vertex_attrib_desc.binding);
1593 if (binding_it == vertex_bindings.cend()) {
1594 skip |= log_msg(
1595 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
1596 "VUID-VkPipelineVertexInputStateCreateInfo-binding-00615",
1597 "vkCreateGraphicsPipelines: parameter "
1598 " pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].binding (%u) does not exist "
1599 "in any pCreateInfo[%d].pVertexInputState->pVertexBindingDescription.",
1600 i, d, vertex_attrib_desc.binding, i);
1601 }
1602
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001603 if (vertex_attrib_desc.location >= device_data->device_limits.maxVertexInputAttributes) {
1604 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001605 "VUID-VkVertexInputAttributeDescription-location-00620",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001606 "vkCreateGraphicsPipelines: parameter "
1607 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].location (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001608 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1609 i, d, vertex_attrib_desc.location, device_data->device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001610 }
1611
1612 if (vertex_attrib_desc.binding >= device_data->device_limits.maxVertexInputBindings) {
1613 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001614 "VUID-VkVertexInputAttributeDescription-binding-00621",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001615 "vkCreateGraphicsPipelines: parameter "
1616 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].binding (%u) is "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001617 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1618 i, d, vertex_attrib_desc.binding, device_data->device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001619 }
1620
1621 if (vertex_attrib_desc.offset > device_data->device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06001622 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001623 "VUID-VkVertexInputAttributeDescription-offset-00622",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001624 "vkCreateGraphicsPipelines: parameter "
1625 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].offset (%u) is "
1626 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%u).",
1627 i, d, vertex_attrib_desc.offset, device_data->device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001628 }
1629 }
1630 }
1631
1632 if (pCreateInfos[i].pStages != nullptr) {
1633 bool has_control = false;
1634 bool has_eval = false;
1635
1636 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
1637 if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
1638 has_control = true;
1639 } else if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
1640 has_eval = true;
1641 }
1642 }
1643
1644 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
1645 if (has_control && has_eval) {
1646 if (pCreateInfos[i].pTessellationState == nullptr) {
1647 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001648 "VUID-VkGraphicsPipelineCreateInfo-pStages-00731",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001649 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pStages includes a tessellation control "
1650 "shader stage and a tessellation evaluation shader stage, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001651 "pCreateInfos[%d].pTessellationState must not be NULL.",
1652 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001653 } else {
1654 skip |= validate_struct_pnext(
1655 report_data, "vkCreateGraphicsPipelines",
1656 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}), NULL,
Dave Houlton413a6782018-05-22 13:01:54 -06001657 pCreateInfos[i].pTessellationState->pNext, 0, NULL, GeneratedHeaderVersion,
1658 "VUID-VkGraphicsPipelineCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001659
1660 skip |= validate_reserved_flags(
1661 report_data, "vkCreateGraphicsPipelines",
1662 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001663 pCreateInfos[i].pTessellationState->flags,
1664 "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001665
1666 if (pCreateInfos[i].pTessellationState->sType !=
1667 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO) {
1668 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001669 "VUID-VkPipelineTessellationStateCreateInfo-sType-sType",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001670 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pTessellationState->sType must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001671 "be VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO.",
1672 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001673 }
1674
1675 if (pCreateInfos[i].pTessellationState->patchControlPoints == 0 ||
1676 pCreateInfos[i].pTessellationState->patchControlPoints >
1677 device_data->device_limits.maxTessellationPatchSize) {
1678 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001679 "VUID-VkPipelineTessellationStateCreateInfo-patchControlPoints-01214",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001680 "vkCreateGraphicsPipelines: invalid parameter "
1681 "pCreateInfos[%d].pTessellationState->patchControlPoints value %u. patchControlPoints "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001682 "should be >0 and <=%u.",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001683 i, pCreateInfos[i].pTessellationState->patchControlPoints,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001684 device_data->device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001685 }
1686 }
1687 }
1688 }
1689
1690 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
1691 if ((pCreateInfos[i].pRasterizationState != nullptr) &&
1692 (pCreateInfos[i].pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
1693 if (pCreateInfos[i].pViewportState == nullptr) {
Petr Krausa6103552017-11-16 21:21:58 +01001694 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001695 VK_NULL_HANDLE, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00750",
Petr Krausa6103552017-11-16 21:21:58 +01001696 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
1697 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001698 "].pViewportState (=NULL) is not a valid pointer.",
1699 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001700 } else {
Petr Krausa6103552017-11-16 21:21:58 +01001701 const auto &viewport_state = *pCreateInfos[i].pViewportState;
1702
1703 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
1704 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001705 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-sType-sType",
Petr Krausa6103552017-11-16 21:21:58 +01001706 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001707 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
1708 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001709 }
1710
Petr Krausa6103552017-11-16 21:21:58 +01001711 const VkStructureType allowed_structs_VkPipelineViewportStateCreateInfo[] = {
1712 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001713 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV,
1714 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_EXCLUSIVE_SCISSOR_STATE_CREATE_INFO_NV,
Jeff Bolz9af91c52018-09-01 21:53:57 -05001715 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SHADING_RATE_IMAGE_STATE_CREATE_INFO_NV,
1716 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_COARSE_SAMPLE_ORDER_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001717 };
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001718 skip |= validate_struct_pnext(
1719 report_data, "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01001720 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
Jeff Bolz9af91c52018-09-01 21:53:57 -05001721 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV, "
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001722 "VkPipelineViewportExclusiveScissorStateCreateInfoNV, VkPipelineViewportShadingRateImageStateCreateInfoNV, "
1723 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV",
Petr Krausa6103552017-11-16 21:21:58 +01001724 viewport_state.pNext, ARRAY_SIZE(allowed_structs_VkPipelineViewportStateCreateInfo),
Dave Houlton413a6782018-05-22 13:01:54 -06001725 allowed_structs_VkPipelineViewportStateCreateInfo, 65,
1726 "VUID-VkPipelineViewportStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001727
1728 skip |= validate_reserved_flags(
1729 report_data, "vkCreateGraphicsPipelines",
1730 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001731 viewport_state.flags, "VUID-VkPipelineViewportStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001732
Dave Houlton142c4cb2018-10-17 15:04:41 -06001733 auto exclusive_scissor_struct = lvl_find_in_chain<VkPipelineViewportExclusiveScissorStateCreateInfoNV>(
1734 pCreateInfos[i].pViewportState->pNext);
1735 auto shading_rate_image_struct = lvl_find_in_chain<VkPipelineViewportShadingRateImageStateCreateInfoNV>(
1736 pCreateInfos[i].pViewportState->pNext);
1737 auto coarse_sample_order_struct = lvl_find_in_chain<VkPipelineViewportCoarseSampleOrderStateCreateInfoNV>(
1738 pCreateInfos[i].pViewportState->pNext);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001739
Petr Krausa6103552017-11-16 21:21:58 +01001740 if (!device_data->physical_device_features.multiViewport) {
1741 if (viewport_state.viewportCount != 1) {
1742 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001743 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216",
Petr Krausa6103552017-11-16 21:21:58 +01001744 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1745 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001746 ") is not 1.",
1747 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001748 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001749
Petr Krausa6103552017-11-16 21:21:58 +01001750 if (viewport_state.scissorCount != 1) {
1751 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001752 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01217",
Petr Krausa6103552017-11-16 21:21:58 +01001753 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1754 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001755 ") is not 1.",
1756 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001757 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001758
Dave Houlton142c4cb2018-10-17 15:04:41 -06001759 if (exclusive_scissor_struct && (exclusive_scissor_struct->exclusiveScissorCount != 0 &&
1760 exclusive_scissor_struct->exclusiveScissorCount != 1)) {
1761 skip |=
1762 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1763 VK_NULL_HANDLE,
1764 "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02027",
1765 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1766 "disabled, but pCreateInfos[%" PRIu32
1767 "] VkPipelineViewportExclusiveScissorStateCreateInfoNV::exclusiveScissorCount (=%" PRIu32
1768 ") is not 1.",
1769 i, exclusive_scissor_struct->exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001770 }
1771
Jeff Bolz9af91c52018-09-01 21:53:57 -05001772 if (shading_rate_image_struct &&
1773 (shading_rate_image_struct->viewportCount != 0 && shading_rate_image_struct->viewportCount != 1)) {
1774 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton142c4cb2018-10-17 15:04:41 -06001775 VK_NULL_HANDLE,
1776 "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02054",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001777 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
Dave Houlton142c4cb2018-10-17 15:04:41 -06001778 "disabled, but pCreateInfos[%" PRIu32
1779 "] VkPipelineViewportShadingRateImageStateCreateInfoNV::viewportCount (=%" PRIu32
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001780 ") is neither 0 nor 1.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001781 i, shading_rate_image_struct->viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001782 }
1783
Petr Krausa6103552017-11-16 21:21:58 +01001784 } else { // multiViewport enabled
1785 if (viewport_state.viewportCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001786 skip |= log_msg(
1787 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001788 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001789 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
Petr Krausa6103552017-11-16 21:21:58 +01001790 } else if (viewport_state.viewportCount > device_data->device_limits.maxViewports) {
1791 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001792 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01218",
Petr Krausa6103552017-11-16 21:21:58 +01001793 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1794 "].pViewportState->viewportCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001795 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1796 i, viewport_state.viewportCount, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001797 }
Petr Krausa6103552017-11-16 21:21:58 +01001798
1799 if (viewport_state.scissorCount == 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001800 skip |= log_msg(
1801 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001802 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001803 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
Petr Krausa6103552017-11-16 21:21:58 +01001804 } else if (viewport_state.scissorCount > device_data->device_limits.maxViewports) {
1805 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001806 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01219",
Petr Krausa6103552017-11-16 21:21:58 +01001807 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1808 "].pViewportState->scissorCount (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001809 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1810 i, viewport_state.scissorCount, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001811 }
1812 }
1813
Jeff Bolz3e71f782018-08-29 23:15:45 -05001814 if (exclusive_scissor_struct &&
1815 exclusive_scissor_struct->exclusiveScissorCount > device_data->device_limits.maxViewports) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001816 skip |= log_msg(
1817 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
1818 "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02028",
1819 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
1820 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1821 i, exclusive_scissor_struct->exclusiveScissorCount, device_data->device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001822 }
1823
Jeff Bolz9af91c52018-09-01 21:53:57 -05001824 if (shading_rate_image_struct &&
1825 shading_rate_image_struct->viewportCount > device_data->device_limits.maxViewports) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001826 skip |=
1827 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1828 VK_NULL_HANDLE, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02055",
1829 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1830 "] VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1831 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1832 i, shading_rate_image_struct->viewportCount, device_data->device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001833 }
1834
Petr Krausa6103552017-11-16 21:21:58 +01001835 if (viewport_state.scissorCount != viewport_state.viewportCount) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001836 skip |=
1837 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001838 VK_NULL_HANDLE, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01220",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001839 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
1840 ") is not identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1841 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001842 }
1843
Dave Houlton142c4cb2018-10-17 15:04:41 -06001844 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount != 0 &&
Jeff Bolz3e71f782018-08-29 23:15:45 -05001845 exclusive_scissor_struct->exclusiveScissorCount != viewport_state.viewportCount) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001846 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1847 VK_NULL_HANDLE,
1848 "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02029",
1849 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
1850 ") must be zero or identical to pCreateInfos[%" PRIu32
1851 "].pViewportState->viewportCount (=%" PRIu32 ").",
1852 i, exclusive_scissor_struct->exclusiveScissorCount, i, viewport_state.viewportCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001853 }
1854
Dave Houlton142c4cb2018-10-17 15:04:41 -06001855 if (shading_rate_image_struct && shading_rate_image_struct->shadingRateImageEnable &&
Jeff Bolz9af91c52018-09-01 21:53:57 -05001856 shading_rate_image_struct->viewportCount != viewport_state.viewportCount) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001857 skip |= log_msg(
1858 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
1859 "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-shadingRateImageEnable-02056",
1860 "vkCreateGraphicsPipelines: If shadingRateImageEnable is enabled, pCreateInfos[%" PRIu32
1861 "] "
1862 "VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1863 ") must identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1864 i, shading_rate_image_struct->viewportCount, i, viewport_state.viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001865 }
1866
Petr Krausa6103552017-11-16 21:21:58 +01001867 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
1868 skip |= log_msg(
1869 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001870 "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00747",
Petr Krausa6103552017-11-16 21:21:58 +01001871 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
1872 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001873 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
1874 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001875 }
1876
1877 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
1878 skip |= log_msg(
1879 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
Dave Houlton413a6782018-05-22 13:01:54 -06001880 "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00748",
Petr Krausa6103552017-11-16 21:21:58 +01001881 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
1882 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001883 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
1884 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001885 }
1886
Jeff Bolz3e71f782018-08-29 23:15:45 -05001887 if (!has_dynamic_exclusive_scissor_nv && exclusive_scissor_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06001888 exclusive_scissor_struct->exclusiveScissorCount > 0 &&
1889 exclusive_scissor_struct->pExclusiveScissors == nullptr) {
1890 skip |=
1891 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1892 VK_NULL_HANDLE, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-pDynamicStates-02030",
1893 "vkCreateGraphicsPipelines: The exclusive scissor state is static (pCreateInfos[%" PRIu32
1894 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV), but "
1895 "pCreateInfos[%" PRIu32 "] pExclusiveScissors (=NULL) is an invalid pointer.",
1896 i, i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001897 }
1898
Jeff Bolz9af91c52018-09-01 21:53:57 -05001899 if (!has_dynamic_shading_rate_palette_nv && shading_rate_image_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06001900 shading_rate_image_struct->viewportCount > 0 &&
1901 shading_rate_image_struct->pShadingRatePalettes == nullptr) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05001902 skip |= log_msg(
1903 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, VK_NULL_HANDLE,
1904 "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-pDynamicStates-02057",
1905 "vkCreateGraphicsPipelines: The shading rate palette state is static (pCreateInfos[%" PRIu32
Dave Houlton142c4cb2018-10-17 15:04:41 -06001906 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV), "
1907 "but pCreateInfos[%" PRIu32 "] pShadingRatePalettes (=NULL) is an invalid pointer.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001908 i, i);
1909 }
1910
Petr Krausb3fcdb42018-01-09 22:09:09 +01001911 // validate the VkViewports
1912 if (!has_dynamic_viewport && viewport_state.pViewports) {
1913 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
1914 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
1915 const char fn_name[] = "vkCreateGraphicsPipelines";
1916 const std::string param_name = "pCreateInfos[" + std::to_string(i) + "].pViewportState->pViewports[" +
1917 std::to_string(viewport_i) + "]";
1918 skip |= pv_VkViewport(device_data, viewport, fn_name, param_name.c_str(),
1919 VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT);
1920 }
1921 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001922
1923 if (has_dynamic_viewport_w_scaling_nv && !device_data->extensions.vk_nv_clip_space_w_scaling) {
1924 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001925 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001926 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001927 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001928 "VK_NV_clip_space_w_scaling extension is not enabled.",
1929 i);
1930 }
1931
1932 if (has_dynamic_discard_rectangle_ext && !device_data->extensions.vk_ext_discard_rectangles) {
1933 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001934 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001935 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001936 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001937 "VK_EXT_discard_rectangles extension is not enabled.",
1938 i);
1939 }
1940
1941 if (has_dynamic_sample_locations_ext && !device_data->extensions.vk_ext_sample_locations) {
1942 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06001943 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001944 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
Dave Houltona9df0ce2018-02-07 10:51:23 -07001945 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001946 "VK_EXT_sample_locations extension is not enabled.",
1947 i);
1948 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001949
1950 if (has_dynamic_exclusive_scissor_nv && !device_data->extensions.vk_nv_scissor_exclusive) {
1951 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1952 VK_NULL_HANDLE, kVUID_PVError_ExtensionNotEnabled,
1953 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1954 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV, but "
1955 "VK_NV_scissor_exclusive extension is not enabled.",
1956 i);
1957 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001958
1959 if (coarse_sample_order_struct &&
1960 coarse_sample_order_struct->sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
1961 coarse_sample_order_struct->customSampleOrderCount != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001962 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
1963 VK_NULL_HANDLE,
1964 "VUID-VkPipelineViewportCoarseSampleOrderStateCreateInfoNV-sampleOrderType-02072",
1965 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1966 "] "
1967 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV sampleOrderType is not "
1968 "VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV and customSampleOrderCount is not 0.",
1969 i);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001970 }
1971
1972 if (coarse_sample_order_struct) {
1973 for (uint32_t order_i = 0; order_i < coarse_sample_order_struct->customSampleOrderCount; ++order_i) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06001974 skip |= ValidateCoarseSampleOrderCustomNV(device_data,
1975 &coarse_sample_order_struct->pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001976 }
1977 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001978 }
1979
1980 if (pCreateInfos[i].pMultisampleState == nullptr) {
1981 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06001982 "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00751",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001983 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pRasterizationState->rasterizerDiscardEnable "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001984 "is VK_FALSE, pCreateInfos[%d].pMultisampleState must not be NULL.",
1985 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001986 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07001987 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
1988 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
1989 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07001990 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07001991 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07001992 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001993 skip |= validate_struct_pnext(
1994 report_data, "vkCreateGraphicsPipelines",
John Zulauf96b0e422017-11-14 11:43:19 -07001995 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
1996 valid_struct_names, pCreateInfos[i].pMultisampleState->pNext, 3, valid_next_stypes, GeneratedHeaderVersion,
Dave Houlton413a6782018-05-22 13:01:54 -06001997 "VUID-VkPipelineMultisampleStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001998
1999 skip |= validate_reserved_flags(
2000 report_data, "vkCreateGraphicsPipelines",
2001 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002002 pCreateInfos[i].pMultisampleState->flags, "VUID-VkPipelineMultisampleStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002003
2004 skip |= validate_bool32(
2005 report_data, "vkCreateGraphicsPipelines",
2006 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
2007 pCreateInfos[i].pMultisampleState->sampleShadingEnable);
2008
2009 skip |= validate_array(
2010 report_data, "vkCreateGraphicsPipelines",
2011 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
2012 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002013 pCreateInfos[i].pMultisampleState->rasterizationSamples, &pCreateInfos[i].pMultisampleState->pSampleMask,
Dave Houlton413a6782018-05-22 13:01:54 -06002014 true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002015
2016 skip |= validate_bool32(
2017 report_data, "vkCreateGraphicsPipelines",
2018 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable", ParameterName::IndexVector{i}),
2019 pCreateInfos[i].pMultisampleState->alphaToCoverageEnable);
2020
2021 skip |= validate_bool32(
2022 report_data, "vkCreateGraphicsPipelines",
2023 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
2024 pCreateInfos[i].pMultisampleState->alphaToOneEnable);
2025
2026 if (pCreateInfos[i].pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
2027 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002028 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002029 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pMultisampleState->sType must be "
2030 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
2031 i);
2032 }
John Zulauf7acac592017-11-06 11:15:53 -07002033 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable == VK_TRUE) {
2034 if (!device_data->physical_device_features.sampleRateShading) {
2035 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002036 "VUID-VkPipelineMultisampleStateCreateInfo-sampleShadingEnable-00784",
John Zulauf7acac592017-11-06 11:15:53 -07002037 "vkCreateGraphicsPipelines(): parameter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002038 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable.",
2039 i);
John Zulauf7acac592017-11-06 11:15:53 -07002040 }
2041 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
2042 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
2043 if (!in_inclusive_range(pCreateInfos[i].pMultisampleState->minSampleShading, 0.F, 1.0F)) {
2044 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002045 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002046 "VUID-VkPipelineMultisampleStateCreateInfo-minSampleShading-00786",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002047 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%d].pMultisampleState->minSampleShading.", i);
John Zulauf7acac592017-11-06 11:15:53 -07002048 }
2049 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002050 }
2051
Petr Krause91f7a12017-12-14 20:57:36 +01002052 bool uses_color_attachment = false;
2053 bool uses_depthstencil_attachment = false;
2054 {
2055 const auto subpasses_uses_it = device_data->renderpasses_states.find(pCreateInfos[i].renderPass);
2056 if (subpasses_uses_it != device_data->renderpasses_states.end()) {
2057 const auto &subpasses_uses = subpasses_uses_it->second;
2058 if (subpasses_uses.subpasses_using_color_attachment.count(pCreateInfos[i].subpass))
2059 uses_color_attachment = true;
2060 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(pCreateInfos[i].subpass))
2061 uses_depthstencil_attachment = true;
2062 }
2063 }
2064
2065 if (pCreateInfos[i].pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002066 skip |= validate_struct_pnext(
2067 report_data, "vkCreateGraphicsPipelines",
2068 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
Dave Houlton413a6782018-05-22 13:01:54 -06002069 pCreateInfos[i].pDepthStencilState->pNext, 0, NULL, GeneratedHeaderVersion,
2070 "VUID-VkPipelineDepthStencilStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002071
2072 skip |= validate_reserved_flags(
2073 report_data, "vkCreateGraphicsPipelines",
2074 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002075 pCreateInfos[i].pDepthStencilState->flags, "VUID-VkPipelineDepthStencilStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002076
2077 skip |= validate_bool32(
2078 report_data, "vkCreateGraphicsPipelines",
2079 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
2080 pCreateInfos[i].pDepthStencilState->depthTestEnable);
2081
2082 skip |= validate_bool32(
2083 report_data, "vkCreateGraphicsPipelines",
2084 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
2085 pCreateInfos[i].pDepthStencilState->depthWriteEnable);
2086
2087 skip |= validate_ranged_enum(
2088 report_data, "vkCreateGraphicsPipelines",
2089 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
2090 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->depthCompareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002091 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002092
2093 skip |= validate_bool32(
2094 report_data, "vkCreateGraphicsPipelines",
2095 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
2096 pCreateInfos[i].pDepthStencilState->depthBoundsTestEnable);
2097
2098 skip |= validate_bool32(
2099 report_data, "vkCreateGraphicsPipelines",
2100 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
2101 pCreateInfos[i].pDepthStencilState->stencilTestEnable);
2102
2103 skip |= validate_ranged_enum(
2104 report_data, "vkCreateGraphicsPipelines",
2105 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
2106 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002107 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002108
2109 skip |= validate_ranged_enum(
2110 report_data, "vkCreateGraphicsPipelines",
2111 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
2112 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002113 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002114
2115 skip |= validate_ranged_enum(
2116 report_data, "vkCreateGraphicsPipelines",
2117 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
2118 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002119 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002120
2121 skip |= validate_ranged_enum(
2122 report_data, "vkCreateGraphicsPipelines",
2123 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
2124 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->front.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002125 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002126
2127 skip |= validate_ranged_enum(
2128 report_data, "vkCreateGraphicsPipelines",
2129 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
2130 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002131 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002132
2133 skip |= validate_ranged_enum(
2134 report_data, "vkCreateGraphicsPipelines",
2135 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
2136 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002137 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002138
2139 skip |= validate_ranged_enum(
2140 report_data, "vkCreateGraphicsPipelines",
2141 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
2142 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002143 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002144
2145 skip |= validate_ranged_enum(
2146 report_data, "vkCreateGraphicsPipelines",
2147 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
2148 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->back.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002149 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002150
2151 if (pCreateInfos[i].pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
2152 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002153 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002154 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pDepthStencilState->sType must be "
2155 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
2156 i);
2157 }
2158 }
2159
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002160 const VkStructureType allowed_structs_VkPipelineColorBlendStateCreateInfo[] = {
2161 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_ADVANCED_STATE_CREATE_INFO_EXT};
2162
Petr Krause91f7a12017-12-14 20:57:36 +01002163 if (pCreateInfos[i].pColorBlendState != nullptr && uses_color_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002164 skip |= validate_struct_pnext(
2165 report_data, "vkCreateGraphicsPipelines",
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002166 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}),
2167 "VkPipelineColorBlendAdvancedStateCreateInfoEXT", pCreateInfos[i].pColorBlendState->pNext,
2168 ARRAY_SIZE(allowed_structs_VkPipelineColorBlendStateCreateInfo),
2169 allowed_structs_VkPipelineColorBlendStateCreateInfo, GeneratedHeaderVersion,
Dave Houlton413a6782018-05-22 13:01:54 -06002170 "VUID-VkPipelineColorBlendStateCreateInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002171
2172 skip |= validate_reserved_flags(
2173 report_data, "vkCreateGraphicsPipelines",
2174 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002175 pCreateInfos[i].pColorBlendState->flags, "VUID-VkPipelineColorBlendStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002176
2177 skip |= validate_bool32(
2178 report_data, "vkCreateGraphicsPipelines",
2179 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
2180 pCreateInfos[i].pColorBlendState->logicOpEnable);
2181
2182 skip |= validate_array(
2183 report_data, "vkCreateGraphicsPipelines",
2184 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
2185 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002186 pCreateInfos[i].pColorBlendState->attachmentCount, &pCreateInfos[i].pColorBlendState->pAttachments, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002187 true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002188
2189 if (pCreateInfos[i].pColorBlendState->pAttachments != NULL) {
2190 for (uint32_t attachmentIndex = 0; attachmentIndex < pCreateInfos[i].pColorBlendState->attachmentCount;
2191 ++attachmentIndex) {
2192 skip |= validate_bool32(report_data, "vkCreateGraphicsPipelines",
2193 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
2194 ParameterName::IndexVector{i, attachmentIndex}),
2195 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].blendEnable);
2196
2197 skip |= validate_ranged_enum(
2198 report_data, "vkCreateGraphicsPipelines",
2199 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
2200 ParameterName::IndexVector{i, attachmentIndex}),
2201 "VkBlendFactor", AllVkBlendFactorEnums,
2202 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002203 "VUID-VkPipelineColorBlendAttachmentState-srcColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002204
2205 skip |= validate_ranged_enum(
2206 report_data, "vkCreateGraphicsPipelines",
2207 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
2208 ParameterName::IndexVector{i, attachmentIndex}),
2209 "VkBlendFactor", AllVkBlendFactorEnums,
2210 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002211 "VUID-VkPipelineColorBlendAttachmentState-dstColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002212
2213 skip |= validate_ranged_enum(
2214 report_data, "vkCreateGraphicsPipelines",
2215 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
2216 ParameterName::IndexVector{i, attachmentIndex}),
2217 "VkBlendOp", AllVkBlendOpEnums,
2218 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002219 "VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002220
2221 skip |= validate_ranged_enum(
2222 report_data, "vkCreateGraphicsPipelines",
2223 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
2224 ParameterName::IndexVector{i, attachmentIndex}),
2225 "VkBlendFactor", AllVkBlendFactorEnums,
2226 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002227 "VUID-VkPipelineColorBlendAttachmentState-srcAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002228
2229 skip |= validate_ranged_enum(
2230 report_data, "vkCreateGraphicsPipelines",
2231 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
2232 ParameterName::IndexVector{i, attachmentIndex}),
2233 "VkBlendFactor", AllVkBlendFactorEnums,
2234 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002235 "VUID-VkPipelineColorBlendAttachmentState-dstAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002236
2237 skip |= validate_ranged_enum(
2238 report_data, "vkCreateGraphicsPipelines",
2239 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
2240 ParameterName::IndexVector{i, attachmentIndex}),
2241 "VkBlendOp", AllVkBlendOpEnums,
2242 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].alphaBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002243 "VUID-VkPipelineColorBlendAttachmentState-alphaBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002244
2245 skip |=
2246 validate_flags(report_data, "vkCreateGraphicsPipelines",
2247 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
2248 ParameterName::IndexVector{i, attachmentIndex}),
2249 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
2250 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorWriteMask,
Dave Houlton413a6782018-05-22 13:01:54 -06002251 false, false, "VUID-VkPipelineColorBlendAttachmentState-colorWriteMask-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002252 }
2253 }
2254
2255 if (pCreateInfos[i].pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
2256 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002257 kVUID_PVError_InvalidStructSType,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002258 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pColorBlendState->sType must be "
2259 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2260 i);
2261 }
2262
2263 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
2264 if (pCreateInfos[i].pColorBlendState->logicOpEnable == VK_TRUE) {
2265 skip |= validate_ranged_enum(
2266 report_data, "vkCreateGraphicsPipelines",
2267 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
Dave Houlton413a6782018-05-22 13:01:54 -06002268 AllVkLogicOpEnums, pCreateInfos[i].pColorBlendState->logicOp,
2269 "VUID-VkPipelineColorBlendStateCreateInfo-logicOpEnable-00607");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002270 }
2271 }
2272 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002273
Petr Kraus9752aae2017-11-24 03:05:50 +01002274 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
2275 if (pCreateInfos[i].basePipelineIndex != -1) {
2276 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002277 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002278 "VUID-VkGraphicsPipelineCreateInfo-flags-00724",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002279 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineHandle, must be "
2280 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002281 "and pCreateInfos->basePipelineIndex is not -1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002282 }
2283 }
2284
Petr Kraus9752aae2017-11-24 03:05:50 +01002285 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
2286 if (pCreateInfos[i].basePipelineIndex != -1) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002287 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002288 "VUID-VkGraphicsPipelineCreateInfo-flags-00725",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002289 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineIndex, must be -1 if "
2290 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002291 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002292 }
2293 }
2294 }
2295
Petr Kraus9752aae2017-11-24 03:05:50 +01002296 if (pCreateInfos[i].pRasterizationState) {
2297 if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002298 (device_data->physical_device_features.fillModeNonSolid == false)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002299 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002300 kVUID_PVError_DeviceFeature,
Dave Houltona9df0ce2018-02-07 10:51:23 -07002301 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2302 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
2303 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002304 }
Petr Kraus299ba622017-11-24 03:09:03 +01002305
2306 if (!has_dynamic_line_width && !device_data->physical_device_features.wideLines &&
2307 (pCreateInfos[i].pRasterizationState->lineWidth != 1.0f)) {
Dave Houlton413a6782018-05-22 13:01:54 -06002308 skip |=
2309 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
2310 0, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00749",
2311 "The line width state is static (pCreateInfos[%" PRIu32
2312 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
2313 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
2314 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
2315 i, i, pCreateInfos[i].pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002316 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002317 }
2318
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002319 for (size_t j = 0; j < pCreateInfos[i].stageCount; j++) {
2320 skip |= validate_string(device_data->report_data, "vkCreateGraphicsPipelines",
2321 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, j}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002322 "VUID-VkGraphicsPipelineCreateInfo-pStages-parameter", pCreateInfos[i].pStages[j].pName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002323 }
2324 }
2325 }
2326
2327 return skip;
2328}
2329
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002330bool pv_vkCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t createInfoCount,
2331 const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator,
2332 VkPipeline *pPipelines) {
2333 bool skip = false;
2334 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2335
2336 for (uint32_t i = 0; i < createInfoCount; i++) {
2337 skip |= validate_string(device_data->report_data, "vkCreateComputePipelines",
2338 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002339 "VUID-VkPipelineShaderStageCreateInfo-pName-parameter", pCreateInfos[i].stage.pName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002340 }
2341
2342 return skip;
2343}
2344
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002345bool pv_vkCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
2346 VkSampler *pSampler) {
2347 bool skip = false;
2348 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2349 debug_report_data *report_data = device_data->report_data;
2350
2351 if (pCreateInfo != nullptr) {
John Zulauf71968502017-10-26 13:51:15 -06002352 const auto &features = device_data->physical_device_features;
2353 const auto &limits = device_data->device_limits;
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002354
John Zulauf71968502017-10-26 13:51:15 -06002355 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
2356 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002357 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002358 "VUID-VkSamplerCreateInfo-anisotropyEnable-01071",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002359 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
John Zulauf71968502017-10-26 13:51:15 -06002360 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002361 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06002362 }
2363
2364 // Anistropy cannot be enabled in sampler unless enabled as a feature
2365 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002366 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002367 "VUID-VkSamplerCreateInfo-anisotropyEnable-01070",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002368 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
2369 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06002370 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002371 }
John Zulauf71968502017-10-26 13:51:15 -06002372
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002373 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
2374 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
2375 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2376 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01072",
2377 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2378 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
2379 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
2380 }
2381 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
2382 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2383 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01073",
2384 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2385 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
2386 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
2387 }
2388 if (pCreateInfo->minLod != 0.0f || pCreateInfo->maxLod != 0.0f) {
2389 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2390 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01074",
2391 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2392 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must both be zero.",
2393 pCreateInfo->minLod, pCreateInfo->maxLod);
2394 }
2395 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2396 pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2397 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2398 pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
2399 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2400 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01075",
2401 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2402 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must both be "
2403 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER.",
2404 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
2405 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
2406 }
2407 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002408 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002409 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01076",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002410 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002411 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06002412 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002413 if (pCreateInfo->compareEnable == VK_TRUE) {
2414 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2415 "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01077",
2416 "vkCreateSampler(): pCreateInfo->compareEnable and pCreateInfo->unnormalizedCoordinates must "
2417 "not both be VK_TRUE.");
2418 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002419 }
2420
2421 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
2422 if (pCreateInfo->compareEnable == VK_TRUE) {
Dave Houlton413a6782018-05-22 13:01:54 -06002423 skip |=
2424 validate_ranged_enum(report_data, "vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp", AllVkCompareOpEnums,
2425 pCreateInfo->compareOp, "VUID-VkSamplerCreateInfo-compareEnable-01080");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002426 }
2427
2428 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
2429 // valid VkBorderColor value
2430 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2431 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2432 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
2433 skip |= validate_ranged_enum(report_data, "vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor",
Dave Houlton413a6782018-05-22 13:01:54 -06002434 AllVkBorderColorEnums, pCreateInfo->borderColor,
2435 "VUID-VkSamplerCreateInfo-addressModeU-01078");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002436 }
2437
2438 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE, the
2439 // VK_KHR_sampler_mirror_clamp_to_edge extension must be enabled
2440 if (!device_data->extensions.vk_khr_sampler_mirror_clamp_to_edge &&
2441 ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2442 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2443 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002444 skip |=
2445 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2446 "VUID-VkSamplerCreateInfo-addressModeU-01079",
2447 "vkCreateSampler(): A VkSamplerAddressMode value is set to VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE "
2448 "but the VK_KHR_sampler_mirror_clamp_to_edge extension has not been enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002449 }
John Zulauf275805c2017-10-26 15:34:49 -06002450
2451 // Checks for the IMG cubic filtering extension
2452 if (device_data->extensions.vk_img_filter_cubic) {
2453 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
2454 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002455 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002456 "VUID-VkSamplerCreateInfo-magFilter-01081",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002457 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002458 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06002459 }
2460 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002461 }
2462
2463 return skip;
2464}
2465
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002466bool pv_vkCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
2467 const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) {
2468 bool skip = false;
2469 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2470 debug_report_data *report_data = device_data->report_data;
2471
2472 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2473 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
2474 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
2475 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
2476 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER or VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, and descriptorCount
2477 // is not 0 and pImmutableSamplers is not NULL, pImmutableSamplers must be a pointer to an array of descriptorCount
2478 // valid VkSampler handles
2479 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2480 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
2481 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
2482 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
2483 ++descriptor_index) {
2484 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
2485 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002486 kVUID_PVError_RequiredParameter,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002487 "vkCreateDescriptorSetLayout: required parameter "
Dave Houltona9df0ce2018-02-07 10:51:23 -07002488 "pCreateInfo->pBindings[%d].pImmutableSamplers[%d] specified as VK_NULL_HANDLE",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002489 i, descriptor_index);
2490 }
2491 }
2492 }
2493
2494 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
2495 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
2496 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07002497 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002498 "VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283",
Dave Houltona9df0ce2018-02-07 10:51:23 -07002499 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0, "
2500 "pCreateInfo->pBindings[%d].stageFlags must be a valid combination of VkShaderStageFlagBits "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002501 "values.",
2502 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002503 }
2504 }
2505 }
2506 }
2507
2508 return skip;
2509}
2510
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002511bool pv_vkFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t descriptorSetCount,
2512 const VkDescriptorSet *pDescriptorSets) {
2513 bool skip = false;
2514 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2515 debug_report_data *report_data = device_data->report_data;
2516
2517 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2518 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2519 // validate_array()
2520 skip |= validate_array(report_data, "vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount,
Dave Houlton413a6782018-05-22 13:01:54 -06002521 &pDescriptorSets, true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002522 return skip;
2523}
2524
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002525bool pv_vkUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites,
2526 uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) {
2527 bool skip = false;
2528 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2529 debug_report_data *report_data = device_data->report_data;
2530
2531 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2532 if (pDescriptorWrites != NULL) {
2533 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
2534 // descriptorCount must be greater than 0
2535 if (pDescriptorWrites[i].descriptorCount == 0) {
2536 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002537 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002538 "VUID-VkWriteDescriptorSet-descriptorCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002539 "vkUpdateDescriptorSets(): parameter pDescriptorWrites[%d].descriptorCount must be greater than 0.", i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002540 }
2541
2542 // dstSet must be a valid VkDescriptorSet handle
2543 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2544 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
2545 pDescriptorWrites[i].dstSet);
2546
2547 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2548 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
2549 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
2550 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
2551 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
2552 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
2553 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
2554 // pImageInfo must be a pointer to an array of descriptorCount valid VkDescriptorImageInfo structures
2555 if (pDescriptorWrites[i].pImageInfo == nullptr) {
2556 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002557 "VUID-VkWriteDescriptorSet-descriptorType-00322",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002558 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2559 "VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
2560 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002561 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%d].pImageInfo must not be NULL.",
2562 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002563 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
2564 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
2565 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageView and imageLayout
2566 // members of any given element of pImageInfo must be a valid VkImageView and VkImageLayout, respectively
2567 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2568 ++descriptor_index) {
2569 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2570 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageView",
2571 ParameterName::IndexVector{i, descriptor_index}),
2572 pDescriptorWrites[i].pImageInfo[descriptor_index].imageView);
2573 skip |= validate_ranged_enum(report_data, "vkUpdateDescriptorSets",
2574 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
2575 ParameterName::IndexVector{i, descriptor_index}),
2576 "VkImageLayout", AllVkImageLayoutEnums,
Dave Houlton413a6782018-05-22 13:01:54 -06002577 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002578 }
2579 }
2580 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2581 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2582 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
2583 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2584 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
2585 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
2586 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
2587 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
2588 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002589 "VUID-VkWriteDescriptorSet-descriptorType-00324",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002590 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2591 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
2592 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002593 "pDescriptorWrites[%d].pBufferInfo must not be NULL.",
2594 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002595 } else {
2596 for (uint32_t descriptorIndex = 0; descriptorIndex < pDescriptorWrites[i].descriptorCount; ++descriptorIndex) {
2597 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2598 ParameterName("pDescriptorWrites[%i].pBufferInfo[%i].buffer",
2599 ParameterName::IndexVector{i, descriptorIndex}),
2600 pDescriptorWrites[i].pBufferInfo[descriptorIndex].buffer);
2601 }
2602 }
2603 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
2604 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
2605 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER,
2606 // pTexelBufferView must be a pointer to an array of descriptorCount valid VkBufferView handles
2607 if (pDescriptorWrites[i].pTexelBufferView == nullptr) {
2608 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002609 "VUID-VkWriteDescriptorSet-descriptorType-00323",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002610 "vkUpdateDescriptorSets(): if pDescriptorWrites[%d].descriptorType is "
2611 "VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002612 "pDescriptorWrites[%d].pTexelBufferView must not be NULL.",
2613 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002614 } else {
2615 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2616 ++descriptor_index) {
2617 skip |= validate_required_handle(report_data, "vkUpdateDescriptorSets",
2618 ParameterName("pDescriptorWrites[%i].pTexelBufferView[%i]",
2619 ParameterName::IndexVector{i, descriptor_index}),
2620 pDescriptorWrites[i].pTexelBufferView[descriptor_index]);
2621 }
2622 }
2623 }
2624
2625 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2626 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
2627 VkDeviceSize uniformAlignment = device_data->device_limits.minUniformBufferOffsetAlignment;
2628 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2629 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2630 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002631 skip |=
2632 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002633 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0,
2634 "VUID-VkWriteDescriptorSet-descriptorType-00327",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002635 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2636 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2637 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002638 }
2639 }
2640 }
2641 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2642 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2643 VkDeviceSize storageAlignment = device_data->device_limits.minStorageBufferOffsetAlignment;
2644 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2645 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2646 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002647 skip |=
2648 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002649 VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0,
2650 "VUID-VkWriteDescriptorSet-descriptorType-00328",
Mark Lobodzinski88529492018-04-01 10:38:15 -06002651 "vkUpdateDescriptorSets(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2652 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2653 i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002654 }
2655 }
2656 }
2657 }
2658 }
2659 }
2660 return skip;
2661}
2662
Tobias Hectord942eb92018-10-22 15:18:56 +01002663template <typename RenderPassCreateInfoGeneric>
2664bool pv_CreateRenderPassGeneric(VkDevice device, const RenderPassCreateInfoGeneric *pCreateInfo,
2665 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
2666 RenderPassCreateVersion rp_version) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002667 bool skip = false;
2668 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2669 uint32_t max_color_attachments = device_data->device_limits.maxColorAttachments;
Tobias Hectord942eb92018-10-22 15:18:56 +01002670 bool use_rp2 = (rp_version == RENDER_PASS_VERSION_2);
2671 const char *vuid;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002672
2673 for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) {
2674 if (pCreateInfo->pAttachments[i].format == VK_FORMAT_UNDEFINED) {
2675 std::stringstream ss;
Tobias Hectord942eb92018-10-22 15:18:56 +01002676 ss << (use_rp2 ? "vkCreateRenderPass2KHR" : "vkCreateRenderPass") << ": pCreateInfo->pAttachments[" << i
2677 << "].format is VK_FORMAT_UNDEFINED. ";
2678 vuid = use_rp2 ? "VUID-VkAttachmentDescription2KHR-format-parameter" : "VUID-VkAttachmentDescription-format-parameter";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002679 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Tobias Hectord942eb92018-10-22 15:18:56 +01002680 vuid, "%s", ss.str().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002681 }
2682 if (pCreateInfo->pAttachments[i].finalLayout == VK_IMAGE_LAYOUT_UNDEFINED ||
2683 pCreateInfo->pAttachments[i].finalLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) {
Tobias Hectord942eb92018-10-22 15:18:56 +01002684 vuid =
2685 use_rp2 ? "VUID-VkAttachmentDescription2KHR-finalLayout-03061" : "VUID-VkAttachmentDescription-finalLayout-00843";
2686 skip |=
2687 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid,
2688 "pCreateInfo->pAttachments[%d].finalLayout must not be VK_IMAGE_LAYOUT_UNDEFINED or "
2689 "VK_IMAGE_LAYOUT_PREINITIALIZED.",
2690 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002691 }
2692 }
2693
2694 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
2695 if (pCreateInfo->pSubpasses[i].colorAttachmentCount > max_color_attachments) {
Tobias Hectord942eb92018-10-22 15:18:56 +01002696 vuid = use_rp2 ? "VUID-VkSubpassDescription2KHR-colorAttachmentCount-03063"
2697 : "VUID-VkSubpassDescription-colorAttachmentCount-00845";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002698 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Tobias Hectord942eb92018-10-22 15:18:56 +01002699 vuid, "Cannot create a render pass with %d color attachments. Max is %d.",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002700 pCreateInfo->pSubpasses[i].colorAttachmentCount, max_color_attachments);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002701 }
2702 }
2703 return skip;
2704}
2705
Tobias Hectord942eb92018-10-22 15:18:56 +01002706bool pv_vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
2707 VkRenderPass *pRenderPass) {
2708 return pv_CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_1);
2709}
2710
2711bool pv_vkCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
2712 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) {
2713 return pv_CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
2714}
2715
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002716bool pv_vkFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount,
2717 const VkCommandBuffer *pCommandBuffers) {
2718 bool skip = false;
2719 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
2720 debug_report_data *report_data = device_data->report_data;
2721
2722 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2723 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2724 // validate_array()
2725 skip |= validate_array(report_data, "vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount,
Dave Houlton413a6782018-05-22 13:01:54 -06002726 &pCommandBuffers, true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002727 return skip;
2728}
2729
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002730bool pv_vkBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) {
2731 bool skip = false;
2732 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2733 debug_report_data *report_data = device_data->report_data;
2734 const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo;
2735
2736 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2737 // TODO: pBeginInfo->pInheritanceInfo must not be NULL if commandBuffer is a secondary command buffer
2738 skip |= validate_struct_type(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo",
2739 "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO", pBeginInfo->pInheritanceInfo,
Mark Lobodzinskia16ebc72018-06-15 14:47:39 -06002740 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, false,
2741 "VUID_vkBeginCommandBuffer-pBeginInfo-parameter", "VUID_VkCommandBufferBeginInfo-sType-sType");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002742
2743 if (pBeginInfo->pInheritanceInfo != NULL) {
Dave Houlton413a6782018-05-22 13:01:54 -06002744 skip |= validate_struct_pnext(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pNext", NULL,
2745 pBeginInfo->pInheritanceInfo->pNext, 0, NULL, GeneratedHeaderVersion,
2746 "VUID-VkCommandBufferBeginInfo-pNext-pNext");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002747
2748 skip |= validate_bool32(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->occlusionQueryEnable",
2749 pBeginInfo->pInheritanceInfo->occlusionQueryEnable);
2750
2751 // TODO: This only needs to be validated when the inherited queries feature is enabled
2752 // skip |= validate_flags(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags",
2753 // "VkQueryControlFlagBits", AllVkQueryControlFlagBits, pBeginInfo->pInheritanceInfo->queryFlags, false);
2754
2755 // TODO: This must be 0 if the pipeline statistics queries feature is not enabled
2756 skip |= validate_flags(report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->pipelineStatistics",
2757 "VkQueryPipelineStatisticFlagBits", AllVkQueryPipelineStatisticFlagBits,
Dave Houlton413a6782018-05-22 13:01:54 -06002758 pBeginInfo->pInheritanceInfo->pipelineStatistics, false, false, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002759 }
2760
2761 if (pInfo != NULL) {
2762 if ((device_data->physical_device_features.inheritedQueries == VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
2763 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002764 HandleToUint64(commandBuffer), "VUID-VkCommandBufferInheritanceInfo-occlusionQueryEnable-00056",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002765 "Cannot set inherited occlusionQueryEnable in vkBeginCommandBuffer() when device does not support "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002766 "inheritedQueries.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002767 }
2768 if ((device_data->physical_device_features.inheritedQueries != VK_FALSE) && (pInfo->occlusionQueryEnable != VK_FALSE)) {
2769 skip |= validate_flags(device_data->report_data, "vkBeginCommandBuffer", "pBeginInfo->pInheritanceInfo->queryFlags",
2770 "VkQueryControlFlagBits", AllVkQueryControlFlagBits, pInfo->queryFlags, false, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002771 "VUID-VkCommandBufferInheritanceInfo-queryFlags-00057");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002772 }
2773 }
2774
2775 return skip;
2776}
2777
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002778bool pv_vkCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
2779 const VkViewport *pViewports) {
2780 bool skip = false;
2781 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2782
Petr Krausd55e77c2018-01-09 22:09:25 +01002783 if (!device_data->physical_device_features.multiViewport) {
2784 if (firstViewport != 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002785 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002786 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-firstViewport-01224",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002787 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
2788 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01002789 }
2790 if (viewportCount > 1) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002791 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002792 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-viewportCount-01225",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002793 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
2794 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002795 }
2796 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01002797 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002798 if (sum > device_data->device_limits.maxViewports) {
2799 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002800 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewport-firstViewport-01223",
Petr Krausd55e77c2018-01-09 22:09:25 +01002801 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002802 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2803 firstViewport, viewportCount, sum, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002804 }
2805 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01002806
2807 if (pViewports) {
2808 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
2809 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
2810 const char fn_name[] = "vkCmdSetViewport";
2811 const std::string param_name = "pViewports[" + std::to_string(viewport_i) + "]";
2812 skip |= pv_VkViewport(device_data, viewport, fn_name, param_name.c_str(),
2813 VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, HandleToUint64(commandBuffer));
2814 }
2815 }
2816
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002817 return skip;
2818}
2819
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002820bool pv_vkCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) {
2821 bool skip = false;
2822 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2823 debug_report_data *report_data = device_data->report_data;
2824
Petr Kraus6260f0a2018-02-27 21:15:55 +01002825 if (!device_data->physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002826 if (firstScissor != 0) {
Petr Kraus6260f0a2018-02-27 21:15:55 +01002827 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002828 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-firstScissor-00593",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002829 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
2830 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002831 }
2832 if (scissorCount > 1) {
2833 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002834 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-scissorCount-00594",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002835 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
2836 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002837 }
2838 } else { // multiViewport enabled
2839 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
2840 if (sum > device_data->device_limits.maxViewports) {
2841 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002842 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-firstScissor-00592",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002843 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002844 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2845 firstScissor, scissorCount, sum, device_data->device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002846 }
2847 }
2848
Petr Kraus6260f0a2018-02-27 21:15:55 +01002849 if (pScissors) {
2850 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
2851 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002852
Petr Kraus6260f0a2018-02-27 21:15:55 +01002853 if (scissor.offset.x < 0) {
2854 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002855 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-x-00595",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002856 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
2857 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002858 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002859
Petr Kraus6260f0a2018-02-27 21:15:55 +01002860 if (scissor.offset.y < 0) {
2861 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002862 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-x-00595",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002863 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
2864 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002865 }
2866
2867 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
2868 if (x_sum > INT32_MAX) {
2869 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002870 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-offset-00596",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002871 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002872 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2873 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002874 }
2875
2876 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
2877 if (y_sum > INT32_MAX) {
2878 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002879 HandleToUint64(commandBuffer), "VUID-vkCmdSetScissor-offset-00597",
Petr Kraus6260f0a2018-02-27 21:15:55 +01002880 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002881 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2882 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002883 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002884 }
2885 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01002886
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002887 return skip;
2888}
2889
Petr Kraus299ba622017-11-24 03:09:03 +01002890bool pv_vkCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) {
2891 bool skip = false;
2892 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2893 debug_report_data *report_data = device_data->report_data;
2894
2895 if (!device_data->physical_device_features.wideLines && (lineWidth != 1.0f)) {
2896 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06002897 HandleToUint64(commandBuffer), "VUID-vkCmdSetLineWidth-lineWidth-00788",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002898 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002899 }
2900
2901 return skip;
2902}
2903
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002904bool pv_vkCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, uint32_t firstVertex,
2905 uint32_t firstInstance) {
2906 bool skip = false;
2907 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2908 if (vertexCount == 0) {
2909 // TODO: Verify against Valid Usage section. I don't see a non-zero vertexCount listed, may need to add that and make
2910 // this an error or leave as is.
2911 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002912 kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t vertexCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002913 }
2914
2915 if (instanceCount == 0) {
2916 // TODO: Verify against Valid Usage section. I don't see a non-zero instanceCount listed, may need to add that and make
2917 // this an error or leave as is.
2918 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002919 kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t instanceCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002920 }
2921 return skip;
2922}
2923
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002924bool pv_vkCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) {
2925 bool skip = false;
2926 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2927
2928 if (!device_data->physical_device_features.multiDrawIndirect && ((count > 1))) {
2929 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002930 kVUID_PVError_DeviceFeature,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002931 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
2932 }
2933 return skip;
2934}
2935
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002936bool pv_vkCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count,
2937 uint32_t stride) {
2938 bool skip = false;
2939 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2940 if (!device_data->physical_device_features.multiDrawIndirect && ((count > 1))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002941 skip |=
2942 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
2943 kVUID_PVError_DeviceFeature,
2944 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002945 }
2946 return skip;
2947}
2948
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002949bool pv_vkCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage,
2950 VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) {
2951 bool skip = false;
2952 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2953
Dave Houltonf5217612018-02-02 16:18:52 -07002954 VkImageAspectFlags legal_aspect_flags =
2955 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2956 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2957 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2958 }
2959
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002960 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002961 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002962 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002963 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002964 "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002965 "vkCmdCopyImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002966 }
Dave Houltonf5217612018-02-02 16:18:52 -07002967 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002968 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002969 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002970 "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002971 "vkCmdCopyImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002972 }
2973 }
2974 return skip;
2975}
2976
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002977bool pv_vkCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage,
2978 VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) {
2979 bool skip = false;
2980 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
2981
Dave Houltonf5217612018-02-02 16:18:52 -07002982 VkImageAspectFlags legal_aspect_flags =
2983 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
2984 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
2985 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2986 }
2987
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002988 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002989 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002990 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002991 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002992 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002993 "vkCmdBlitImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator");
2994 }
Dave Houltonf5217612018-02-02 16:18:52 -07002995 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002996 skip |= log_msg(
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06002997 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06002998 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002999 "vkCmdBlitImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator");
3000 }
3001 }
3002 return skip;
3003}
3004
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003005bool pv_vkCmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkImage dstImage, VkImageLayout dstImageLayout,
3006 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
3007 bool skip = false;
3008 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3009
Dave Houltonf5217612018-02-02 16:18:52 -07003010 VkImageAspectFlags legal_aspect_flags =
3011 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
3012 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
3013 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
3014 }
3015
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003016 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07003017 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Dave Houltona9df0ce2018-02-07 10:51:23 -07003018 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003019 kVUID_PVError_UnrecognizedValue,
Dave Houltona9df0ce2018-02-07 10:51:23 -07003020 "vkCmdCopyBufferToImage() parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an "
3021 "unrecognized enumerator");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003022 }
3023 }
3024 return skip;
3025}
3026
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003027bool pv_vkCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkBuffer dstBuffer,
3028 uint32_t regionCount, const VkBufferImageCopy *pRegions) {
3029 bool skip = false;
3030 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3031
Dave Houltonf5217612018-02-02 16:18:52 -07003032 VkImageAspectFlags legal_aspect_flags =
3033 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
3034 if (device_data->extensions.vk_khr_sampler_ycbcr_conversion) {
3035 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
3036 }
3037
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003038 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07003039 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003040 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003041 kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003042 "vkCmdCopyImageToBuffer parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an unrecognized "
3043 "enumerator");
3044 }
3045 }
3046 return skip;
3047}
3048
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003049bool pv_vkCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize dataSize,
3050 const void *pData) {
3051 bool skip = false;
3052 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3053
3054 if (dstOffset & 3) {
3055 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003056 "VUID-vkCmdUpdateBuffer-dstOffset-00036",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003057 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3058 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003059 }
3060
3061 if ((dataSize <= 0) || (dataSize > 65536)) {
3062 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003063 "VUID-vkCmdUpdateBuffer-dataSize-00037",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003064 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003065 "), must be greater than zero and less than or equal to 65536.",
3066 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003067 } else if (dataSize & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003068 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003069 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003070 "VUID-vkCmdUpdateBuffer-dataSize-00038",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003071 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.", dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003072 }
3073 return skip;
3074}
3075
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003076bool pv_vkCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size,
3077 uint32_t data) {
3078 bool skip = false;
3079 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3080
3081 if (dstOffset & 3) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003082 skip |=
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003083 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003084 "VUID-vkCmdFillBuffer-dstOffset-00025",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003085 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.", dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003086 }
3087
3088 if (size != VK_WHOLE_SIZE) {
3089 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003090 skip |=
3091 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003092 "VUID-vkCmdFillBuffer-size-00026",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003093 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003094 } else if (size & 3) {
3095 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003096 "VUID-vkCmdFillBuffer-size-00028",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003097 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003098 }
3099 }
3100 return skip;
3101}
3102
3103VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) {
3104 return util_GetLayerProperties(1, &global_layer, pCount, pProperties);
3105}
3106
3107VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount,
3108 VkLayerProperties *pProperties) {
3109 return util_GetLayerProperties(1, &global_layer, pCount, pProperties);
3110}
3111
3112VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount,
3113 VkExtensionProperties *pProperties) {
3114 if (pLayerName && !strcmp(pLayerName, global_layer.layerName))
3115 return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties);
3116
3117 return VK_ERROR_LAYER_NOT_PRESENT;
3118}
3119
3120VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, const char *pLayerName,
3121 uint32_t *pPropertyCount, VkExtensionProperties *pProperties) {
3122 // Parameter_validation does not have any physical device extensions
3123 if (pLayerName && !strcmp(pLayerName, global_layer.layerName))
3124 return util_GetExtensionProperties(0, NULL, pPropertyCount, pProperties);
3125
3126 instance_layer_data *local_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
Dave Houlton413a6782018-05-22 13:01:54 -06003127 bool skip = validate_array(local_data->report_data, "vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties",
3128 pPropertyCount, &pProperties, true, false, false, kVUIDUndefined,
3129 "VUID-vkEnumerateDeviceExtensionProperties-pProperties-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003130 if (skip) return VK_ERROR_VALIDATION_FAILED_EXT;
3131
3132 return local_data->dispatch_table.EnumerateDeviceExtensionProperties(physicalDevice, NULL, pPropertyCount, pProperties);
3133}
3134
3135static bool require_device_extension(layer_data *device_data, bool flag, char const *function_name, char const *extension_name) {
3136 if (!flag) {
3137 return log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003138 kVUID_PVError_ExtensionNotEnabled,
3139 "%s() called even though the %s extension was not enabled for this VkDevice.", function_name,
3140 extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003141 }
3142
3143 return false;
3144}
3145
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003146bool pv_vkCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, const VkAllocationCallbacks *pAllocator,
3147 VkSwapchainKHR *pSwapchain) {
3148 bool skip = false;
3149 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3150 debug_report_data *report_data = device_data->report_data;
3151
Mark Lobodzinski88529492018-04-01 10:38:15 -06003152 const LogMiscParams log_misc{report_data, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, VK_NULL_HANDLE,
Petr Krause5c37652018-01-05 04:05:12 +01003153 "vkCreateSwapchainKHR"};
3154
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003155 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003156 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3157 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
3158 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
3159 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003160 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003161 "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01278",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003162 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003163 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003164 }
3165
3166 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
3167 // queueFamilyIndexCount uint32_t values
3168 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinskib1fd9d12018-03-30 14:26:00 -06003169 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003170 "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01277",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003171 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3172 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003173 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003174 } else {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003175 skip |= ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices,
Dave Houlton413a6782018-05-22 13:01:54 -06003176 "vkCreateSwapchainKHR", "pCreateInfo->pQueueFamilyIndices",
3177 kVUID_PVError_InvalidUsage, kVUID_PVError_InvalidUsage, false);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003178 }
3179 }
3180
Dave Houlton413a6782018-05-22 13:01:54 -06003181 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers",
3182 "VUID-VkSwapchainCreateInfoKHR-imageArrayLayers-01275", log_misc);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003183 }
3184
3185 return skip;
3186}
3187
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003188bool pv_vkQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) {
3189 bool skip = false;
3190 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(queue), layer_data_map);
3191
3192 if (pPresentInfo && pPresentInfo->pNext) {
John Zulaufde972ac2017-10-26 12:07:05 -06003193 const auto *present_regions = lvl_find_in_chain<VkPresentRegionsKHR>(pPresentInfo->pNext);
3194 if (present_regions) {
3195 // TODO: This and all other pNext extension dependencies should be added to code-generation
3196 skip |= require_device_extension(device_data, device_data->extensions.vk_khr_incremental_present, "vkQueuePresentKHR",
3197 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
3198 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
3199 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003200 kVUID_PVError_InvalidUsage,
Dave Houltona9df0ce2018-02-07 10:51:23 -07003201 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
3202 "extension swapchainCount is %i. These values must be equal.",
John Zulaufde972ac2017-10-26 12:07:05 -06003203 pPresentInfo->swapchainCount, present_regions->swapchainCount);
3204 }
Dave Houlton413a6782018-05-22 13:01:54 -06003205 skip |=
3206 validate_struct_pnext(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL,
3207 present_regions->pNext, 0, NULL, GeneratedHeaderVersion, "VUID-VkPresentInfoKHR-pNext-pNext");
John Zulaufde972ac2017-10-26 12:07:05 -06003208 skip |= validate_array(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->swapchainCount",
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00003209 "pCreateInfo->pNext->pRegions", present_regions->swapchainCount, &present_regions->pRegions,
Dave Houlton413a6782018-05-22 13:01:54 -06003210 true, false, kVUIDUndefined, kVUIDUndefined);
John Zulaufde972ac2017-10-26 12:07:05 -06003211 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
3212 skip |= validate_array(device_data->report_data, "QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003213 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
Dave Houlton413a6782018-05-22 13:01:54 -06003214 &present_regions->pRegions[i].pRectangles, true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003215 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003216 }
3217 }
3218
3219 return skip;
3220}
3221
3222#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003223bool pv_vkCreateWin32SurfaceKHR(VkInstance instance, const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
3224 const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) {
3225 auto device_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3226 bool skip = false;
3227
3228 if (pCreateInfo->hwnd == nullptr) {
3229 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
Dave Houlton413a6782018-05-22 13:01:54 -06003230 "VUID-VkWin32SurfaceCreateInfoKHR-hwnd-01308",
3231 "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003232 }
3233
3234 return skip;
3235}
3236#endif // VK_USE_PLATFORM_WIN32_KHR
3237
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003238bool pv_vkDebugMarkerSetObjectNameEXT(VkDevice device, const VkDebugMarkerObjectNameInfoEXT *pNameInfo) {
3239 auto device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3240 if (pNameInfo->pObjectName) {
3241 device_data->report_data->debugObjectNameMap->insert(
3242 std::make_pair<uint64_t, std::string>((uint64_t &&) pNameInfo->object, pNameInfo->pObjectName));
3243 } else {
3244 device_data->report_data->debugObjectNameMap->erase(pNameInfo->object);
3245 }
3246 return false;
3247}
3248
Petr Krausc8655be2017-09-27 18:56:51 +02003249bool pv_vkCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
3250 const VkAllocationCallbacks *pAllocator, VkDescriptorPool *pDescriptorPool) {
3251 auto device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3252 bool skip = false;
3253
3254 if (pCreateInfo) {
3255 if (pCreateInfo->maxSets <= 0) {
Dave Houlton413a6782018-05-22 13:01:54 -06003256 skip |=
3257 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
3258 VK_NULL_HANDLE, "VUID-VkDescriptorPoolCreateInfo-maxSets-00301",
3259 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02003260 }
3261
3262 if (pCreateInfo->pPoolSizes) {
3263 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
3264 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
3265 skip |= log_msg(
3266 device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003267 VK_NULL_HANDLE, "VUID-VkDescriptorPoolSize-descriptorCount-00302",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003268 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02003269 }
Jeff Bolze54ae892018-09-08 12:16:29 -05003270 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT &&
3271 (pCreateInfo->pPoolSizes[i].descriptorCount % 4) != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003272 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT,
3273 VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, VK_NULL_HANDLE,
3274 "VUID-VkDescriptorPoolSize-type-02218",
3275 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
3276 "].type is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT "
3277 " and pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not a multiple of 4.",
3278 i, i);
Jeff Bolze54ae892018-09-08 12:16:29 -05003279 }
Petr Krausc8655be2017-09-27 18:56:51 +02003280 }
3281 }
3282 }
3283
3284 return skip;
3285}
3286
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003287bool pv_vkCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX, uint32_t groupCountY, uint32_t groupCountZ) {
3288 bool skip = false;
3289 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3290
3291 if (groupCountX > device_data->device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003292 skip |=
3293 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003294 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountX-00386",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003295 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3296 groupCountX, device_data->device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003297 }
3298
3299 if (groupCountY > device_data->device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003300 skip |=
3301 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003302 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountY-00387",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003303 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3304 groupCountY, device_data->device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003305 }
3306
3307 if (groupCountZ > device_data->device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003308 skip |=
3309 log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003310 HandleToUint64(commandBuffer), "VUID-vkCmdDispatch-groupCountZ-00388",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003311 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3312 groupCountZ, device_data->device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003313 }
3314
3315 return skip;
3316}
John Zulaufa999d1b2018-11-29 13:38:40 -07003317bool pv_vkCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset) {
3318 bool skip = false;
3319 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3320
3321 if ((offset % 4) != 0) {
3322 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3323 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchIndirect-offset-00406",
3324 "vkCmdDispatchIndirect(): offset (%" PRIu64 ") must be a multiple of 4.", offset);
3325 }
3326 return skip;
3327}
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003328
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003329bool pv_vkCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX, uint32_t baseGroupY, uint32_t baseGroupZ,
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003330 uint32_t groupCountX, uint32_t groupCountY, uint32_t groupCountZ) {
3331 bool skip = false;
3332 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3333
3334 // Paired if {} else if {} tests used to avoid any possible uint underflow
3335 uint32_t limit = device_data->device_limits.maxComputeWorkGroupCount[0];
3336 if (baseGroupX >= limit) {
3337 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003338 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupX-00421",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003339 "vkCmdDispatch(): baseGroupX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003340 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3341 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003342 } else if (groupCountX > (limit - baseGroupX)) {
3343 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003344 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountX-00424",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003345 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003346 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3347 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003348 }
3349
3350 limit = device_data->device_limits.maxComputeWorkGroupCount[1];
3351 if (baseGroupY >= limit) {
3352 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003353 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupX-00422",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003354 "vkCmdDispatch(): baseGroupY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003355 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3356 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003357 } else if (groupCountY > (limit - baseGroupY)) {
3358 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003359 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountY-00425",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003360 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003361 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3362 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003363 }
3364
3365 limit = device_data->device_limits.maxComputeWorkGroupCount[2];
3366 if (baseGroupZ >= limit) {
3367 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003368 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-baseGroupZ-00423",
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003369 "vkCmdDispatch(): baseGroupZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003370 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3371 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003372 } else if (groupCountZ > (limit - baseGroupZ)) {
3373 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Dave Houlton413a6782018-05-22 13:01:54 -06003374 HandleToUint64(commandBuffer), "VUID-vkCmdDispatchBase-groupCountZ-00426",
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003375 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003376 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3377 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003378 }
3379
3380 return skip;
3381}
3382
Dave Houlton142c4cb2018-10-17 15:04:41 -06003383bool pv_vkCmdSetExclusiveScissorNV(VkCommandBuffer commandBuffer, uint32_t firstExclusiveScissor, uint32_t exclusiveScissorCount,
3384 const VkRect2D *pExclusiveScissors) {
Jeff Bolz3e71f782018-08-29 23:15:45 -05003385 bool skip = false;
3386
3387 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3388 debug_report_data *report_data = device_data->report_data;
3389
3390 if (!device_data->physical_device_features.multiViewport) {
3391 if (firstExclusiveScissor != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003392 skip |=
3393 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3394 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02035",
3395 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but firstExclusiveScissor (=%" PRIu32
3396 ") is not 0.",
3397 firstExclusiveScissor);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003398 }
3399 if (exclusiveScissorCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003400 skip |=
3401 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3402 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-exclusiveScissorCount-02036",
3403 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but exclusiveScissorCount (=%" PRIu32
3404 ") is not 1.",
3405 exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003406 }
3407 } else { // multiViewport enabled
3408 const uint64_t sum = static_cast<uint64_t>(firstExclusiveScissor) + static_cast<uint64_t>(exclusiveScissorCount);
3409 if (sum > device_data->device_limits.maxViewports) {
3410 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3411 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02034",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003412 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor + exclusiveScissorCount (=%" PRIu32 " + %" PRIu32
3413 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
Jeff Bolz3e71f782018-08-29 23:15:45 -05003414 firstExclusiveScissor, exclusiveScissorCount, sum, device_data->device_limits.maxViewports);
3415 }
3416 }
3417
3418 if (firstExclusiveScissor >= device_data->device_limits.maxViewports) {
3419 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3420 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02033",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003421 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor (=%" PRIu32 ") must be less than maxViewports (=%" PRIu32
3422 ").",
Jeff Bolz3e71f782018-08-29 23:15:45 -05003423 firstExclusiveScissor, device_data->device_limits.maxViewports);
3424 }
3425
3426 if (pExclusiveScissors) {
3427 for (uint32_t scissor_i = 0; scissor_i < exclusiveScissorCount; ++scissor_i) {
3428 const auto &scissor = pExclusiveScissors[scissor_i]; // will crash on invalid ptr
3429
3430 if (scissor.offset.x < 0) {
3431 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3432 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-x-02037",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003433 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.",
3434 scissor_i, scissor.offset.x);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003435 }
3436
3437 if (scissor.offset.y < 0) {
3438 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3439 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-x-02037",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003440 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.",
3441 scissor_i, scissor.offset.y);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003442 }
3443
3444 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
3445 if (x_sum > INT32_MAX) {
3446 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3447 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-offset-02038",
3448 "vkCmdSetExclusiveScissorNV: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3449 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3450 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
3451 }
3452
3453 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
3454 if (y_sum > INT32_MAX) {
3455 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3456 HandleToUint64(commandBuffer), "VUID-vkCmdSetExclusiveScissorNV-offset-02039",
3457 "vkCmdSetExclusiveScissorNV: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3458 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3459 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
3460 }
3461 }
3462 }
3463
3464 return skip;
3465}
3466
Dave Houlton142c4cb2018-10-17 15:04:41 -06003467bool pv_vkCmdSetViewportShadingRatePaletteNV(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
3468 const VkShadingRatePaletteNV *pShadingRatePalettes) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003469 bool skip = false;
3470
3471 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3472 debug_report_data *report_data = device_data->report_data;
3473
3474 if (!device_data->physical_device_features.multiViewport) {
3475 if (firstViewport != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003476 skip |=
3477 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3478 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02068",
3479 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but firstViewport (=%" PRIu32
3480 ") is not 0.",
3481 firstViewport);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003482 }
3483 if (viewportCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003484 skip |=
3485 log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3486 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-viewportCount-02069",
3487 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
3488 ") is not 1.",
3489 viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003490 }
3491 }
3492
3493 if (firstViewport >= device_data->device_limits.maxViewports) {
3494 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3495 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02066",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003496 "vkCmdSetViewportShadingRatePaletteNV: firstViewport (=%" PRIu32
3497 ") must be less than maxViewports (=%" PRIu32 ").",
Jeff Bolz9af91c52018-09-01 21:53:57 -05003498 firstViewport, device_data->device_limits.maxViewports);
3499 }
3500
3501 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
3502 if (sum > device_data->device_limits.maxViewports) {
3503 skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3504 HandleToUint64(commandBuffer), "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02067",
3505 "vkCmdSetViewportShadingRatePaletteNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3506 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3507 firstViewport, viewportCount, sum, device_data->device_limits.maxViewports);
3508 }
3509
3510 return skip;
3511}
3512
Dave Houlton142c4cb2018-10-17 15:04:41 -06003513bool pv_vkCmdSetCoarseSampleOrderNV(VkCommandBuffer commandBuffer, VkCoarseSampleOrderTypeNV sampleOrderType,
3514 uint32_t customSampleOrderCount, const VkCoarseSampleOrderCustomNV *pCustomSampleOrders) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003515 bool skip = false;
3516
3517 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3518 debug_report_data *report_data = device_data->report_data;
3519
Dave Houlton142c4cb2018-10-17 15:04:41 -06003520 if (sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV && customSampleOrderCount != 0) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003521 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3522 HandleToUint64(commandBuffer), "VUID-vkCmdSetCoarseSampleOrderNV-sampleOrderType-02081",
3523 "vkCmdSetCoarseSampleOrderNV: If sampleOrderType is not VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV, "
3524 "customSampleOrderCount must be 0.");
3525 }
3526
3527 for (uint32_t order_i = 0; order_i < customSampleOrderCount; ++order_i) {
3528 skip |= ValidateCoarseSampleOrderCustomNV(device_data, &pCustomSampleOrders[order_i]);
3529 }
3530
3531 return skip;
3532}
3533
Dave Houlton142c4cb2018-10-17 15:04:41 -06003534bool pv_vkCmdDrawMeshTasksNV(VkCommandBuffer commandBuffer, uint32_t taskCount, uint32_t firstTask) {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003535 bool skip = false;
3536
3537 layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3538
3539 if (taskCount > dev_data->phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003540 skip |= log_msg(
3541 dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3542 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksNV-taskCount-02119",
3543 "vkCmdDrawMeshTasksNV() parameter, uint32_t taskCount (0x%" PRIxLEAST32
3544 "), must be less than or equal to VkPhysicalDeviceMeshShaderPropertiesNV::maxDrawMeshTasksCount (0x%" PRIxLEAST32 ").",
3545 taskCount, dev_data->phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003546 }
3547
3548 return skip;
3549}
3550
Dave Houlton142c4cb2018-10-17 15:04:41 -06003551bool pv_vkCmdDrawMeshTasksIndirectNV(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t drawCount,
3552 uint32_t stride) {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003553 bool skip = false;
3554
3555 layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3556 debug_report_data *report_data = dev_data->report_data;
3557
3558 if (offset & 3) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003559 skip |= log_msg(
3560 report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3561 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectNV-offset-02145",
3562 "vkCmdDrawMeshTasksIndirectNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003563 }
3564
3565 if (drawCount > 1 && ((stride & 3) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV))) {
3566 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3567 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02146",
3568 "vkCmdDrawMeshTasksIndirectNV() parameter, uint32_t stride (0x%" PRIxLEAST32
3569 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
3570 stride);
3571 }
3572
Jeff Bolzb574c342018-11-08 15:36:57 -06003573 if (!dev_data->physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
3574 skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3575 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02147",
3576 "vkCmdDrawMeshTasksIndirectNV(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d",
3577 drawCount);
3578 }
3579
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003580 return skip;
3581}
3582
Dave Houlton142c4cb2018-10-17 15:04:41 -06003583bool pv_vkCmdDrawMeshTasksIndirectCountNV(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkBuffer countBuffer,
3584 VkDeviceSize countBufferOffset, uint32_t maxDrawCount, uint32_t stride) {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003585 bool skip = false;
3586
3587 layer_data *dev_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map);
3588
3589 if (offset & 3) {
3590 skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3591 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectCountNV-offset-02180",
3592 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64
3593 "), is not a multiple of 4.",
3594 offset);
3595 }
3596
3597 if (countBufferOffset & 3) {
3598 skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3599 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectCountNV-countBufferOffset-02181",
3600 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64
3601 "), is not a multiple of 4.",
3602 countBufferOffset);
3603 }
3604
3605 if ((stride & 3) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV)) {
3606 skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
3607 HandleToUint64(commandBuffer), "VUID-vkCmdDrawMeshTasksIndirectCountNV-stride-02182",
3608 "vkCmdDrawMeshTasksIndirectCountNV() parameter, uint32_t stride (0x%" PRIxLEAST32
3609 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
3610 stride);
3611 }
3612
3613 return skip;
3614}
3615
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003616VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice device, const char *funcName) {
Mark Lobodzinskib7a26382018-07-02 13:14:26 -06003617 layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map);
3618 if (!ApiParentExtensionEnabled(funcName, device_data->extensions.device_extension_set)) {
3619 return nullptr;
3620 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003621 const auto item = name_to_funcptr_map.find(funcName);
3622 if (item != name_to_funcptr_map.end()) {
3623 return reinterpret_cast<PFN_vkVoidFunction>(item->second);
3624 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003625 const auto &table = device_data->dispatch_table;
3626 if (!table.GetDeviceProcAddr) return nullptr;
3627 return table.GetDeviceProcAddr(device, funcName);
3628}
3629
3630VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) {
3631 const auto item = name_to_funcptr_map.find(funcName);
3632 if (item != name_to_funcptr_map.end()) {
3633 return reinterpret_cast<PFN_vkVoidFunction>(item->second);
3634 }
3635
3636 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3637 auto &table = instance_data->dispatch_table;
3638 if (!table.GetInstanceProcAddr) return nullptr;
3639 return table.GetInstanceProcAddr(instance, funcName);
3640}
3641
3642VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetPhysicalDeviceProcAddr(VkInstance instance, const char *funcName) {
3643 assert(instance);
3644 auto instance_data = GetLayerDataPtr(get_dispatch_key(instance), instance_layer_data_map);
3645
3646 if (!instance_data->dispatch_table.GetPhysicalDeviceProcAddr) return nullptr;
3647 return instance_data->dispatch_table.GetPhysicalDeviceProcAddr(instance, funcName);
3648}
3649
3650// If additional validation is needed outside of the generated checks, a manual routine can be added to this file
3651// and the address filled in here. The autogenerated source will call these routines if the pointers are not NULL.
Petr Krausc8655be2017-09-27 18:56:51 +02003652void InitializeManualParameterValidationFunctionPointers() {
Dave Houltonb3bbec72018-01-17 10:13:33 -07003653 custom_functions["vkGetDeviceQueue"] = (void *)pv_vkGetDeviceQueue;
3654 custom_functions["vkCreateBuffer"] = (void *)pv_vkCreateBuffer;
3655 custom_functions["vkCreateImage"] = (void *)pv_vkCreateImage;
3656 custom_functions["vkCreateImageView"] = (void *)pv_vkCreateImageView;
3657 custom_functions["vkCreateGraphicsPipelines"] = (void *)pv_vkCreateGraphicsPipelines;
3658 custom_functions["vkCreateComputePipelines"] = (void *)pv_vkCreateComputePipelines;
3659 custom_functions["vkCreateSampler"] = (void *)pv_vkCreateSampler;
3660 custom_functions["vkCreateDescriptorSetLayout"] = (void *)pv_vkCreateDescriptorSetLayout;
3661 custom_functions["vkFreeDescriptorSets"] = (void *)pv_vkFreeDescriptorSets;
3662 custom_functions["vkUpdateDescriptorSets"] = (void *)pv_vkUpdateDescriptorSets;
3663 custom_functions["vkCreateRenderPass"] = (void *)pv_vkCreateRenderPass;
Tobias Hectord942eb92018-10-22 15:18:56 +01003664 custom_functions["vkCreateRenderPass2KHR"] = (void *)pv_vkCreateRenderPass2KHR;
Dave Houltonb3bbec72018-01-17 10:13:33 -07003665 custom_functions["vkBeginCommandBuffer"] = (void *)pv_vkBeginCommandBuffer;
3666 custom_functions["vkCmdSetViewport"] = (void *)pv_vkCmdSetViewport;
3667 custom_functions["vkCmdSetScissor"] = (void *)pv_vkCmdSetScissor;
Petr Kraus299ba622017-11-24 03:09:03 +01003668 custom_functions["vkCmdSetLineWidth"] = (void *)pv_vkCmdSetLineWidth;
Dave Houltonb3bbec72018-01-17 10:13:33 -07003669 custom_functions["vkCmdDraw"] = (void *)pv_vkCmdDraw;
3670 custom_functions["vkCmdDrawIndirect"] = (void *)pv_vkCmdDrawIndirect;
3671 custom_functions["vkCmdDrawIndexedIndirect"] = (void *)pv_vkCmdDrawIndexedIndirect;
3672 custom_functions["vkCmdCopyImage"] = (void *)pv_vkCmdCopyImage;
3673 custom_functions["vkCmdBlitImage"] = (void *)pv_vkCmdBlitImage;
3674 custom_functions["vkCmdCopyBufferToImage"] = (void *)pv_vkCmdCopyBufferToImage;
3675 custom_functions["vkCmdCopyImageToBuffer"] = (void *)pv_vkCmdCopyImageToBuffer;
3676 custom_functions["vkCmdUpdateBuffer"] = (void *)pv_vkCmdUpdateBuffer;
3677 custom_functions["vkCmdFillBuffer"] = (void *)pv_vkCmdFillBuffer;
3678 custom_functions["vkCreateSwapchainKHR"] = (void *)pv_vkCreateSwapchainKHR;
3679 custom_functions["vkQueuePresentKHR"] = (void *)pv_vkQueuePresentKHR;
3680 custom_functions["vkCreateDescriptorPool"] = (void *)pv_vkCreateDescriptorPool;
3681 custom_functions["vkCmdDispatch"] = (void *)pv_vkCmdDispatch;
John Zulaufa999d1b2018-11-29 13:38:40 -07003682 custom_functions["vkCmdDispatchIndirect"] = (void *)pv_vkCmdDispatchIndirect;
Mark Lobodzinskibf973a12018-03-01 08:50:21 -07003683 custom_functions["vkCmdDispatchBaseKHR"] = (void *)pv_vkCmdDispatchBaseKHR;
Jeff Bolz3e71f782018-08-29 23:15:45 -05003684 custom_functions["vkCmdSetExclusiveScissorNV"] = (void *)pv_vkCmdSetExclusiveScissorNV;
Jeff Bolz9af91c52018-09-01 21:53:57 -05003685 custom_functions["vkCmdSetViewportShadingRatePaletteNV"] = (void *)pv_vkCmdSetViewportShadingRatePaletteNV;
3686 custom_functions["vkCmdSetCoarseSampleOrderNV"] = (void *)pv_vkCmdSetCoarseSampleOrderNV;
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003687 custom_functions["vkCmdDrawMeshTasksNV"] = (void *)pv_vkCmdDrawMeshTasksNV;
3688 custom_functions["vkCmdDrawMeshTasksIndirectNV"] = (void *)pv_vkCmdDrawMeshTasksIndirectNV;
3689 custom_functions["vkCmdDrawMeshTasksIndirectCountNV"] = (void *)pv_vkCmdDrawMeshTasksIndirectCountNV;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003690}
3691
3692} // namespace parameter_validation
3693
3694VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount,
3695 VkExtensionProperties *pProperties) {
3696 return parameter_validation::vkEnumerateInstanceExtensionProperties(pLayerName, pCount, pProperties);
3697}
3698
3699VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(uint32_t *pCount,
3700 VkLayerProperties *pProperties) {
3701 return parameter_validation::vkEnumerateInstanceLayerProperties(pCount, pProperties);
3702}
3703
3704VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount,
3705 VkLayerProperties *pProperties) {
3706 // the layer command handles VK_NULL_HANDLE just fine internally
3707 assert(physicalDevice == VK_NULL_HANDLE);
3708 return parameter_validation::vkEnumerateDeviceLayerProperties(VK_NULL_HANDLE, pCount, pProperties);
3709}
3710
3711VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
3712 const char *pLayerName, uint32_t *pCount,
3713 VkExtensionProperties *pProperties) {
3714 // the layer command handles VK_NULL_HANDLE just fine internally
3715 assert(physicalDevice == VK_NULL_HANDLE);
3716 return parameter_validation::vkEnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties);
3717}
3718
3719VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) {
3720 return parameter_validation::vkGetDeviceProcAddr(dev, funcName);
3721}
3722
3723VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) {
3724 return parameter_validation::vkGetInstanceProcAddr(instance, funcName);
3725}
3726
3727VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vk_layerGetPhysicalDeviceProcAddr(VkInstance instance,
3728 const char *funcName) {
3729 return parameter_validation::vkGetPhysicalDeviceProcAddr(instance, funcName);
3730}
3731
Lenny Komow2d0cbbe2018-05-24 13:38:05 -06003732VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL VKAPI_CALL
3733vkNegotiateLoaderLayerInterfaceVersion(VkNegotiateLayerInterface *pVersionStruct) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003734 assert(pVersionStruct != NULL);
3735 assert(pVersionStruct->sType == LAYER_NEGOTIATE_INTERFACE_STRUCT);
3736
3737 // Fill in the function pointers if our version is at least capable of having the structure contain them.
3738 if (pVersionStruct->loaderLayerInterfaceVersion >= 2) {
3739 pVersionStruct->pfnGetInstanceProcAddr = vkGetInstanceProcAddr;
3740 pVersionStruct->pfnGetDeviceProcAddr = vkGetDeviceProcAddr;
3741 pVersionStruct->pfnGetPhysicalDeviceProcAddr = vk_layerGetPhysicalDeviceProcAddr;
3742 }
3743
3744 if (pVersionStruct->loaderLayerInterfaceVersion < CURRENT_LOADER_LAYER_INTERFACE_VERSION) {
3745 parameter_validation::loader_layer_if_version = pVersionStruct->loaderLayerInterfaceVersion;
3746 } else if (pVersionStruct->loaderLayerInterfaceVersion > CURRENT_LOADER_LAYER_INTERFACE_VERSION) {
3747 pVersionStruct->loaderLayerInterfaceVersion = CURRENT_LOADER_LAYER_INTERFACE_VERSION;
3748 }
3749
3750 return VK_SUCCESS;
3751}