blob: 3d96d37eb26c4b4f6cd62d32f45ea63e4359a6b3 [file] [log] [blame]
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08001/* Copyright (c) 2015-2020 The Khronos Group Inc.
2 * Copyright (c) 2015-2020 Valve Corporation
3 * Copyright (c) 2015-2020 LunarG, Inc.
4 * Copyright (C) 2015-2020 Google Inc.
Mark Lobodzinskid4950072017-08-01 13:02:20 -06005 *
6 * Licensed under the Apache License, Version 2.0 (the "License");
7 * you may not use this file except in compliance with the License.
8 * You may obtain a copy of the License at
9 *
10 * http://www.apache.org/licenses/LICENSE-2.0
11 *
12 * Unless required by applicable law or agreed to in writing, software
13 * distributed under the License is distributed on an "AS IS" BASIS,
14 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 * See the License for the specific language governing permissions and
16 * limitations under the License.
17 *
18 * Author: Mark Lobodzinski <mark@LunarG.com>
John Zulaufa999d1b2018-11-29 13:38:40 -070019 * Author: John Zulauf <jzulauf@lunarg.com>
Mark Lobodzinskid4950072017-08-01 13:02:20 -060020 */
21
orbea80ddc062019-09-10 10:33:19 -070022#include <cmath>
Shahbaz Youssefi6be11412019-01-10 15:29:30 -050023
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070024#include "chassis.h"
25#include "stateless_validation.h"
Mark Lobodzinskie514d1a2019-03-12 08:47:45 -060026#include "layer_chassis_dispatch.h"
Tobias Hectord942eb92018-10-22 15:18:56 +010027
Mark Lobodzinskid4950072017-08-01 13:02:20 -060028static const int MaxParamCheckerStringLength = 256;
29
John Zulauf71968502017-10-26 13:51:15 -060030template <typename T>
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -070031inline bool in_inclusive_range(const T &value, const T &min, const T &max) {
John Zulauf71968502017-10-26 13:51:15 -060032 // Using only < for generality and || for early abort
33 return !((value < min) || (max < value));
34}
35
Mark Lobodzinskibf599b92018-12-31 12:15:55 -070036bool StatelessValidation::validate_string(const char *apiName, const ParameterName &stringName, const std::string &vuid,
Jeff Bolz46c0ea02019-10-09 13:06:29 -050037 const char *validateString) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -060038 bool skip = false;
39
40 VkStringErrorFlags result = vk_string_validate(MaxParamCheckerStringLength, validateString);
41
42 if (result == VK_STRING_ERROR_NONE) {
43 return skip;
44 } else if (result & VK_STRING_ERROR_LENGTH) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070045 skip = LogError(device, vuid, "%s: string %s exceeds max length %d", apiName, stringName.get_name().c_str(),
46 MaxParamCheckerStringLength);
Mark Lobodzinskid4950072017-08-01 13:02:20 -060047 } else if (result & VK_STRING_ERROR_BAD_DATA) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070048 skip = LogError(device, vuid, "%s: string %s contains invalid characters or is badly formed", apiName,
49 stringName.get_name().c_str());
Mark Lobodzinskid4950072017-08-01 13:02:20 -060050 }
51 return skip;
52}
53
Jeff Bolz46c0ea02019-10-09 13:06:29 -050054bool StatelessValidation::validate_api_version(uint32_t api_version, uint32_t effective_api_version) const {
John Zulauf620755c2018-04-16 11:00:43 -060055 bool skip = false;
56 uint32_t api_version_nopatch = VK_MAKE_VERSION(VK_VERSION_MAJOR(api_version), VK_VERSION_MINOR(api_version), 0);
57 if (api_version_nopatch != effective_api_version) {
58 if (api_version_nopatch < VK_API_VERSION_1_0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070059 skip |= LogError(instance, kVUIDUndefined,
60 "Invalid CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
61 "Using VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
62 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060063 } else {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -070064 skip |= LogWarning(instance, kVUIDUndefined,
65 "Unrecognized CreateInstance->pCreateInfo->pApplicationInfo.apiVersion number (0x%08x). "
66 "Assuming VK_API_VERSION_%" PRIu32 "_%" PRIu32 ".",
67 api_version, VK_VERSION_MAJOR(effective_api_version), VK_VERSION_MINOR(effective_api_version));
John Zulauf620755c2018-04-16 11:00:43 -060068 }
69 }
70 return skip;
71}
72
Jeff Bolz46c0ea02019-10-09 13:06:29 -050073bool StatelessValidation::validate_instance_extensions(const VkInstanceCreateInfo *pCreateInfo) const {
John Zulauf620755c2018-04-16 11:00:43 -060074 bool skip = false;
Mark Lobodzinski05cce202019-08-27 10:28:37 -060075 // Create and use a local instance extension object, as an actual instance has not been created yet
76 uint32_t specified_version = (pCreateInfo->pApplicationInfo ? pCreateInfo->pApplicationInfo->apiVersion : VK_API_VERSION_1_0);
77 InstanceExtensions local_instance_extensions;
78 local_instance_extensions.InitFromInstanceCreateInfo(specified_version, pCreateInfo);
79
John Zulauf620755c2018-04-16 11:00:43 -060080 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
Mark Lobodzinski05cce202019-08-27 10:28:37 -060081 skip |= validate_extension_reqs(local_instance_extensions, "VUID-vkCreateInstance-ppEnabledExtensionNames-01388",
82 "instance", pCreateInfo->ppEnabledExtensionNames[i]);
John Zulauf620755c2018-04-16 11:00:43 -060083 }
84
85 return skip;
86}
87
John Zulauf620755c2018-04-16 11:00:43 -060088template <typename ExtensionState>
Tony-LunarG2ec96bb2019-11-26 13:43:02 -070089ExtEnabled extension_state_by_name(const ExtensionState &extensions, const char *extension_name) {
90 if (!extension_name) return kNotEnabled; // null strings specify nothing
John Zulauf620755c2018-04-16 11:00:43 -060091 auto info = ExtensionState::get_info(extension_name);
Tony-LunarG2ec96bb2019-11-26 13:43:02 -070092 ExtEnabled state =
93 info.state ? extensions.*(info.state) : kNotEnabled; // unknown extensions can't be enabled in extension struct
John Zulauf620755c2018-04-16 11:00:43 -060094 return state;
95}
96
Mark Lobodzinskibf599b92018-12-31 12:15:55 -070097bool StatelessValidation::manual_PreCallValidateCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -050098 const VkAllocationCallbacks *pAllocator,
99 VkInstance *pInstance) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700100 bool skip = false;
101 // Note: From the spec--
102 // Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing an apiVersion of 0 is equivalent to providing
103 // an apiVersion of VK_MAKE_VERSION(1, 0, 0). (a.k.a. VK_API_VERSION_1_0)
104 uint32_t local_api_version = (pCreateInfo->pApplicationInfo && pCreateInfo->pApplicationInfo->apiVersion)
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700105 ? pCreateInfo->pApplicationInfo->apiVersion
106 : VK_API_VERSION_1_0;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700107 skip |= validate_api_version(local_api_version, api_version);
108 skip |= validate_instance_extensions(pCreateInfo);
109 return skip;
110}
111
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700112void StatelessValidation::PostCallRecordCreateInstance(const VkInstanceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700113 const VkAllocationCallbacks *pAllocator, VkInstance *pInstance,
114 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700115 auto instance_data = GetLayerDataPtr(get_dispatch_key(*pInstance), layer_data_map);
116 // Copy extension data into local object
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700117 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700118 this->instance_extensions = instance_data->instance_extensions;
119}
120
121void StatelessValidation::PostCallRecordCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700122 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice, VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700123 auto device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -0700124 if (result != VK_SUCCESS) return;
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700125 ValidationObject *validation_data = GetValidationObject(device_data->object_dispatch, LayerObjectTypeParameterValidation);
126 StatelessValidation *stateless_validation = static_cast<StatelessValidation *>(validation_data);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700127
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700128 // Parmeter validation also uses extension data
129 stateless_validation->device_extensions = this->device_extensions;
130
131 VkPhysicalDeviceProperties device_properties = {};
132 // Need to get instance and do a getlayerdata call...
Tony-LunarG152a88b2019-03-20 15:42:24 -0600133 DispatchGetPhysicalDeviceProperties(physicalDevice, &device_properties);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700134 memcpy(&stateless_validation->device_limits, &device_properties.limits, sizeof(VkPhysicalDeviceLimits));
135
136 if (device_extensions.vk_nv_shading_rate_image) {
137 // Get the needed shading rate image limits
138 auto shading_rate_image_props = lvl_init_struct<VkPhysicalDeviceShadingRateImagePropertiesNV>();
139 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&shading_rate_image_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600140 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700141 phys_dev_ext_props.shading_rate_image_props = shading_rate_image_props;
142 }
143
144 if (device_extensions.vk_nv_mesh_shader) {
145 // Get the needed mesh shader limits
146 auto mesh_shader_props = lvl_init_struct<VkPhysicalDeviceMeshShaderPropertiesNV>();
147 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&mesh_shader_props);
Tony-LunarG152a88b2019-03-20 15:42:24 -0600148 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700149 phys_dev_ext_props.mesh_shader_props = mesh_shader_props;
150 }
151
Jason Macnak5c954952019-07-09 15:46:12 -0700152 if (device_extensions.vk_nv_ray_tracing) {
153 // Get the needed ray tracing limits
154 auto ray_tracing_props = lvl_init_struct<VkPhysicalDeviceRayTracingPropertiesNV>();
155 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&ray_tracing_props);
156 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
157 phys_dev_ext_props.ray_tracing_props = ray_tracing_props;
158 }
159
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -0700160 if (device_extensions.vk_ext_transform_feedback) {
161 // Get the needed transform feedback limits
162 auto transform_feedback_props = lvl_init_struct<VkPhysicalDeviceTransformFeedbackPropertiesEXT>();
163 auto prop2 = lvl_init_struct<VkPhysicalDeviceProperties2KHR>(&transform_feedback_props);
164 DispatchGetPhysicalDeviceProperties2KHR(physicalDevice, &prop2);
165 phys_dev_ext_props.transform_feedback_props = transform_feedback_props;
166 }
167
Jasper St. Pierrea49b4be2019-02-05 17:48:57 -0800168 stateless_validation->phys_dev_ext_props = this->phys_dev_ext_props;
169
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700170 // Save app-enabled features in this device's validation object
171 // The enabled features can come from either pEnabledFeatures, or from the pNext chain
Petr Kraus715bcc72019-08-15 17:17:33 +0200172 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
173 safe_VkPhysicalDeviceFeatures2 tmp_features2_state;
174 tmp_features2_state.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_FEATURES_2;
175 if (features2) {
176 tmp_features2_state.features = features2->features;
177 } else if (pCreateInfo->pEnabledFeatures) {
178 tmp_features2_state.features = *pCreateInfo->pEnabledFeatures;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700179 } else {
Petr Kraus715bcc72019-08-15 17:17:33 +0200180 tmp_features2_state.features = {};
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700181 }
Petr Kraus715bcc72019-08-15 17:17:33 +0200182 // Use pCreateInfo->pNext to get full chain
Tony-LunarG6c3c5452019-12-13 10:37:38 -0700183 stateless_validation->device_createinfo_pnext = SafePnextCopy(pCreateInfo->pNext);
Petr Kraus715bcc72019-08-15 17:17:33 +0200184 stateless_validation->physical_device_features2 = tmp_features2_state;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700185}
186
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700187bool StatelessValidation::manual_PreCallValidateCreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500188 const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600189 bool skip = false;
190
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200191 for (size_t i = 0; i < pCreateInfo->enabledLayerCount; i++) {
192 skip |= validate_string("vkCreateDevice", "pCreateInfo->ppEnabledLayerNames",
193 "VUID-VkDeviceCreateInfo-ppEnabledLayerNames-parameter", pCreateInfo->ppEnabledLayerNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600194 }
195
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200196 for (size_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
197 skip |=
198 validate_string("vkCreateDevice", "pCreateInfo->ppEnabledExtensionNames",
199 "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-parameter", pCreateInfo->ppEnabledExtensionNames[i]);
200 skip |= validate_extension_reqs(device_extensions, "VUID-vkCreateDevice-ppEnabledExtensionNames-01387", "device",
201 pCreateInfo->ppEnabledExtensionNames[i]);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600202 }
203
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200204 {
Tony-LunarG2ec96bb2019-11-26 13:43:02 -0700205 bool maint1 = IsExtEnabled(extension_state_by_name(device_extensions, VK_KHR_MAINTENANCE1_EXTENSION_NAME));
206 bool negative_viewport =
207 IsExtEnabled(extension_state_by_name(device_extensions, VK_AMD_NEGATIVE_VIEWPORT_HEIGHT_EXTENSION_NAME));
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200208 if (maint1 && negative_viewport) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700209 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-00374",
210 "VkDeviceCreateInfo->ppEnabledExtensionNames must not simultaneously include VK_KHR_maintenance1 and "
211 "VK_AMD_negative_viewport_height.");
Petr Kraus6c4bdce2019-08-27 17:35:01 +0200212 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600213 }
214
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600215 {
216 bool khr_bda = IsExtEnabled(extension_state_by_name(device_extensions, VK_KHR_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
217 bool ext_bda = IsExtEnabled(extension_state_by_name(device_extensions, VK_EXT_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME));
218 if (khr_bda && ext_bda) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700219 skip |= LogError(device, "VUID-VkDeviceCreateInfo-ppEnabledExtensionNames-03328",
220 "VkDeviceCreateInfo->ppEnabledExtensionNames must not contain both VK_KHR_buffer_device_address and "
221 "VK_EXT_buffer_device_address.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -0600222 }
223 }
224
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600225 if (pCreateInfo->pNext != NULL && pCreateInfo->pEnabledFeatures) {
226 // Check for get_physical_device_properties2 struct
John Zulaufde972ac2017-10-26 12:07:05 -0600227 const auto *features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2KHR>(pCreateInfo->pNext);
228 if (features2) {
229 // Cannot include VkPhysicalDeviceFeatures2KHR and have non-null pEnabledFeatures
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700230 skip |= LogError(device, kVUID_PVError_InvalidUsage,
231 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2KHR struct when "
232 "pCreateInfo->pEnabledFeatures is non-NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600233 }
234 }
235
Locke77fad1c2019-04-16 13:09:03 -0600236 auto features2 = lvl_find_in_chain<VkPhysicalDeviceFeatures2>(pCreateInfo->pNext);
237 if (features2) {
238 if (!instance_extensions.vk_khr_get_physical_device_properties_2) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700239 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
240 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceFeatures2 struct, "
241 "VK_KHR_get_physical_device_properties2 must be enabled when it creates an instance.");
Locke77fad1c2019-04-16 13:09:03 -0600242 }
243 }
244
245 auto vertex_attribute_divisor_features =
246 lvl_find_in_chain<VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT>(pCreateInfo->pNext);
247 if (vertex_attribute_divisor_features) {
248 bool extension_found = false;
249 for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; ++i) {
250 if (0 == strncmp(pCreateInfo->ppEnabledExtensionNames[i], VK_EXT_VERTEX_ATTRIBUTE_DIVISOR_EXTENSION_NAME,
251 VK_MAX_EXTENSION_NAME_SIZE)) {
252 extension_found = true;
253 break;
254 }
255 }
256 if (!extension_found) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700257 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
258 "VkDeviceCreateInfo->pNext includes a VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT "
259 "struct, VK_EXT_vertex_attribute_divisor must be enabled when it creates a device.");
Locke77fad1c2019-04-16 13:09:03 -0600260 }
261 }
262
Tony-LunarG28017bc2020-01-23 14:40:25 -0700263 const auto *vulkan_11_features = lvl_find_in_chain<VkPhysicalDeviceVulkan11Features>(pCreateInfo->pNext);
264 if (vulkan_11_features) {
265 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
266 while (current) {
267 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_16BIT_STORAGE_FEATURES ||
268 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_MULTIVIEW_FEATURES ||
269 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VARIABLE_POINTERS_FEATURES ||
270 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PROTECTED_MEMORY_FEATURES ||
271 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SAMPLER_YCBCR_CONVERSION_FEATURES ||
272 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_DRAW_PARAMETERS_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700273 skip |= LogError(
274 instance, "VUID-VkDeviceCreateInfo-pNext-02829",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700275 "If the pNext chain includes a VkPhysicalDeviceVulkan11Features structure, then it must not include a "
276 "VkPhysicalDevice16BitStorageFeatures, VkPhysicalDeviceMultiviewFeatures, "
277 "VkPhysicalDeviceVariablePointersFeatures, VkPhysicalDeviceProtectedMemoryFeatures, "
278 "VkPhysicalDeviceSamplerYcbcrConversionFeatures, or VkPhysicalDeviceShaderDrawParametersFeatures structure");
279 break;
280 }
281 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
282 }
283 }
284
285 const auto *vulkan_12_features = lvl_find_in_chain<VkPhysicalDeviceVulkan12Features>(pCreateInfo->pNext);
286 if (vulkan_12_features) {
287 const VkBaseOutStructure *current = reinterpret_cast<const VkBaseOutStructure *>(pCreateInfo->pNext);
288 while (current) {
289 if (current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_8BIT_STORAGE_FEATURES ||
290 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_ATOMIC_INT64_FEATURES ||
291 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_FLOAT16_INT8_FEATURES ||
292 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_DESCRIPTOR_INDEXING_FEATURES ||
293 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SCALAR_BLOCK_LAYOUT_FEATURES ||
294 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_IMAGELESS_FRAMEBUFFER_FEATURES ||
295 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_UNIFORM_BUFFER_STANDARD_LAYOUT_FEATURES ||
296 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_SUBGROUP_EXTENDED_TYPES_FEATURES ||
297 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SEPARATE_DEPTH_STENCIL_LAYOUTS_FEATURES ||
298 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_HOST_QUERY_RESET_FEATURES ||
299 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_TIMELINE_SEMAPHORE_FEATURES ||
300 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_BUFFER_DEVICE_ADDRESS_FEATURES ||
301 current->sType == VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_MEMORY_MODEL_FEATURES) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700302 skip |= LogError(
303 instance, "VUID-VkDeviceCreateInfo-pNext-02830",
Tony-LunarG28017bc2020-01-23 14:40:25 -0700304 "If the pNext chain includes a VkPhysicalDeviceVulkan12Features structure, then it must not include a "
305 "VkPhysicalDevice8BitStorageFeatures, VkPhysicalDeviceShaderAtomicInt64Features, "
306 "VkPhysicalDeviceShaderFloat16Int8Features, VkPhysicalDeviceDescriptorIndexingFeatures, "
307 "VkPhysicalDeviceScalarBlockLayoutFeatures, VkPhysicalDeviceImagelessFramebufferFeatures, "
308 "VkPhysicalDeviceUniformBufferStandardLayoutFeatures, VkPhysicalDeviceShaderSubgroupExtendedTypesFeatures, "
309 "VkPhysicalDeviceSeparateDepthStencilLayoutsFeatures, VkPhysicalDeviceHostQueryResetFeatures, "
310 "VkPhysicalDeviceTimelineSemaphoreFeatures, VkPhysicalDeviceBufferDeviceAddressFeatures, or "
311 "VkPhysicalDeviceVulkanMemoryModelFeatures structure");
312 break;
313 }
314 current = reinterpret_cast<const VkBaseOutStructure *>(current->pNext);
315 }
316 }
317
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600318 // Validate pCreateInfo->pQueueCreateInfos
319 if (pCreateInfo->pQueueCreateInfos) {
320 std::unordered_set<uint32_t> set;
321
322 for (uint32_t i = 0; i < pCreateInfo->queueCreateInfoCount; ++i) {
323 const uint32_t requested_queue_family = pCreateInfo->pQueueCreateInfos[i].queueFamilyIndex;
324 if (requested_queue_family == VK_QUEUE_FAMILY_IGNORED) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700325 skip |=
326 LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-queueFamilyIndex-00381",
327 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32
328 "].queueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, but it is required to provide a valid queue family "
329 "index value.",
330 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600331 } else if (set.count(requested_queue_family)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700332 skip |= LogError(physicalDevice, "VUID-VkDeviceCreateInfo-queueFamilyIndex-00372",
333 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].queueFamilyIndex (=%" PRIu32
334 ") is not unique within pCreateInfo->pQueueCreateInfos array.",
335 i, requested_queue_family);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600336 } else {
337 set.insert(requested_queue_family);
338 }
339
340 if (pCreateInfo->pQueueCreateInfos[i].pQueuePriorities != nullptr) {
341 for (uint32_t j = 0; j < pCreateInfo->pQueueCreateInfos[i].queueCount; ++j) {
342 const float queue_priority = pCreateInfo->pQueueCreateInfos[i].pQueuePriorities[j];
343 if (!(queue_priority >= 0.f) || !(queue_priority <= 1.f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700344 skip |= LogError(physicalDevice, "VUID-VkDeviceQueueCreateInfo-pQueuePriorities-00383",
345 "vkCreateDevice: pCreateInfo->pQueueCreateInfos[%" PRIu32 "].pQueuePriorities[%" PRIu32
346 "] (=%f) is not between 0 and 1 (inclusive).",
347 i, j, queue_priority);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600348 }
349 }
350 }
351 }
352 }
353
354 return skip;
355}
356
Jeff Bolz46c0ea02019-10-09 13:06:29 -0500357bool StatelessValidation::require_device_extension(bool flag, char const *function_name, char const *extension_name) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700358 if (!flag) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700359 return LogError(device, kVUID_PVError_ExtensionNotEnabled,
360 "%s() called even though the %s extension was not enabled for this VkDevice.", function_name,
361 extension_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600362 }
363
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700364 return false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600365}
366
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700367bool StatelessValidation::manual_PreCallValidateCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500368 const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) const {
Petr Krause91f7a12017-12-14 20:57:36 +0100369 bool skip = false;
370
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600371 if (pCreateInfo != nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700372 skip |=
373 ValidateGreaterThanZero(pCreateInfo->size, "pCreateInfo->size", "VUID-VkBufferCreateInfo-size-00912", "vkCreateBuffer");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600374
375 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
376 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
377 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
378 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700379 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00914",
380 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
381 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600382 }
383
384 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
385 // queueFamilyIndexCount uint32_t values
386 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700387 skip |= LogError(device, "VUID-VkBufferCreateInfo-sharingMode-00913",
388 "vkCreateBuffer: if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
389 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
390 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600391 }
392 }
393
394 // If flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain
395 // VK_BUFFER_CREATE_SPARSE_BINDING_BIT
396 if (((pCreateInfo->flags & (VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT | VK_BUFFER_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
397 ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) != VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700398 skip |= LogError(device, "VUID-VkBufferCreateInfo-flags-00918",
399 "vkCreateBuffer: if pCreateInfo->flags contains VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT or "
400 "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_BUFFER_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600401 }
402 }
403
404 return skip;
405}
406
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700407bool StatelessValidation::manual_PreCallValidateCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500408 const VkAllocationCallbacks *pAllocator, VkImage *pImage) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600409 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600410
411 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600412 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
413 if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
414 // If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
415 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700416 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00942",
417 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
418 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600419 }
420
421 // If sharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
422 // queueFamilyIndexCount uint32_t values
423 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700424 skip |= LogError(device, "VUID-VkImageCreateInfo-sharingMode-00941",
425 "vkCreateImage(): if pCreateInfo->sharingMode is VK_SHARING_MODE_CONCURRENT, "
426 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
427 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600428 }
429 }
430
Dave Houlton413a6782018-05-22 13:01:54 -0600431 skip |= ValidateGreaterThanZero(pCreateInfo->extent.width, "pCreateInfo->extent.width",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700432 "VUID-VkImageCreateInfo-extent-00944", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600433 skip |= ValidateGreaterThanZero(pCreateInfo->extent.height, "pCreateInfo->extent.height",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700434 "VUID-VkImageCreateInfo-extent-00945", "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600435 skip |= ValidateGreaterThanZero(pCreateInfo->extent.depth, "pCreateInfo->extent.depth",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700436 "VUID-VkImageCreateInfo-extent-00946", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600437
Dave Houlton413a6782018-05-22 13:01:54 -0600438 skip |= ValidateGreaterThanZero(pCreateInfo->mipLevels, "pCreateInfo->mipLevels", "VUID-VkImageCreateInfo-mipLevels-00947",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700439 "vkCreateImage");
Dave Houlton413a6782018-05-22 13:01:54 -0600440 skip |= ValidateGreaterThanZero(pCreateInfo->arrayLayers, "pCreateInfo->arrayLayers",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700441 "VUID-VkImageCreateInfo-arrayLayers-00948", "vkCreateImage");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600442
Dave Houlton130c0212018-01-29 13:39:56 -0700443 // InitialLayout must be PREINITIALIZED or UNDEFINED
Dave Houltone19e20d2018-02-02 16:32:41 -0700444 if ((pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_UNDEFINED) &&
445 (pCreateInfo->initialLayout != VK_IMAGE_LAYOUT_PREINITIALIZED)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700446 skip |= LogError(
447 device, "VUID-VkImageCreateInfo-initialLayout-00993",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600448 "vkCreateImage(): initialLayout is %s, must be VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED.",
449 string_VkImageLayout(pCreateInfo->initialLayout));
Dave Houlton130c0212018-01-29 13:39:56 -0700450 }
451
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600452 // If imageType is VK_IMAGE_TYPE_1D, both extent.height and extent.depth must be 1
Petr Kraus3ac9e812018-03-13 12:31:08 +0100453 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_1D) &&
454 ((pCreateInfo->extent.height != 1) || (pCreateInfo->extent.depth != 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700455 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00956",
456 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_1D, both pCreateInfo->extent.height and "
457 "pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600458 }
459
460 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D) {
Petr Kraus3f433212018-03-13 12:31:27 +0100461 if (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) {
462 if (pCreateInfo->extent.width != pCreateInfo->extent.height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700463 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
464 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
465 "pCreateInfo->extent.width (=%" PRIu32 ") and pCreateInfo->extent.height (=%" PRIu32
466 ") are not equal.",
467 pCreateInfo->extent.width, pCreateInfo->extent.height);
Petr Kraus3f433212018-03-13 12:31:27 +0100468 }
469
470 if (pCreateInfo->arrayLayers < 6) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700471 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00954",
472 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT, but "
473 "pCreateInfo->arrayLayers (=%" PRIu32 ") is not greater than or equal to 6.",
474 pCreateInfo->arrayLayers);
Petr Kraus3f433212018-03-13 12:31:27 +0100475 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600476 }
477
478 if (pCreateInfo->extent.depth != 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700479 skip |= LogError(
480 device, "VUID-VkImageCreateInfo-imageType-00957",
481 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_2D, pCreateInfo->extent.depth must be 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600482 }
483 }
484
Dave Houlton130c0212018-01-29 13:39:56 -0700485 // 3D image may have only 1 layer
486 if ((pCreateInfo->imageType == VK_IMAGE_TYPE_3D) && (pCreateInfo->arrayLayers != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700487 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00961",
488 "vkCreateImage(): if pCreateInfo->imageType is VK_IMAGE_TYPE_3D, pCreateInfo->arrayLayers must be 1.");
Dave Houlton130c0212018-01-29 13:39:56 -0700489 }
490
491 // If multi-sample, validate type, usage, tiling and mip levels.
492 if ((pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) &&
493 ((pCreateInfo->imageType != VK_IMAGE_TYPE_2D) || (pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) ||
Shannon McPhersona886c2a2018-10-12 14:38:20 -0600494 (pCreateInfo->mipLevels != 1) || (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700495 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02257",
496 "vkCreateImage(): Multi-sample image with incompatible type, usage, tiling, or mips.");
Dave Houlton130c0212018-01-29 13:39:56 -0700497 }
498
499 if (0 != (pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT)) {
500 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
501 VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
502 // At least one of the legal attachment bits must be set
503 if (0 == (pCreateInfo->usage & legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700504 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00966",
505 "vkCreateImage(): Transient attachment image without a compatible attachment flag set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700506 }
507 // No flags other than the legal attachment bits may be set
508 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
509 if (0 != (pCreateInfo->usage & ~legal_flags)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700510 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00963",
511 "vkCreateImage(): Transient attachment image with incompatible usage flags set.");
Dave Houlton130c0212018-01-29 13:39:56 -0700512 }
513 }
514
Jeff Bolzef40fec2018-09-01 22:04:34 -0500515 // mipLevels must be less than or equal to the number of levels in the complete mipmap chain
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600516 uint32_t maxDim = std::max(std::max(pCreateInfo->extent.width, pCreateInfo->extent.height), pCreateInfo->extent.depth);
Jeff Bolzef40fec2018-09-01 22:04:34 -0500517 // Max mip levels is different for corner-sampled images vs normal images.
Dave Houlton142c4cb2018-10-17 15:04:41 -0600518 uint32_t maxMipLevels = (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) ? (uint32_t)(ceil(log2(maxDim)))
519 : (uint32_t)(floor(log2(maxDim)) + 1);
Jeff Bolzef40fec2018-09-01 22:04:34 -0500520 if (maxDim > 0 && pCreateInfo->mipLevels > maxMipLevels) {
Dave Houlton413a6782018-05-22 13:01:54 -0600521 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700522 LogError(device, "VUID-VkImageCreateInfo-mipLevels-00958",
523 "vkCreateImage(): pCreateInfo->mipLevels must be less than or equal to "
524 "floor(log2(max(pCreateInfo->extent.width, pCreateInfo->extent.height, pCreateInfo->extent.depth)))+1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600525 }
526
Mark Lobodzinski69259c52018-09-18 15:14:58 -0600527 if ((pCreateInfo->flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT) && (pCreateInfo->imageType != VK_IMAGE_TYPE_3D)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700528 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00950",
529 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT but "
530 "pCreateInfo->imageType is not VK_IMAGE_TYPE_3D.");
Mark Lobodzinski69259c52018-09-18 15:14:58 -0600531 }
532
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700533 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) && (!physical_device_features.sparseBinding)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700534 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00969",
535 "vkCreateImage(): pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_BINDING_BIT, but the "
536 "VkPhysicalDeviceFeatures::sparseBinding feature is disabled.");
Petr Krausb6f97802018-03-13 12:31:39 +0100537 }
538
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600539 // If flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain
540 // VK_IMAGE_CREATE_SPARSE_BINDING_BIT
541 if (((pCreateInfo->flags & (VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT)) != 0) &&
542 ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT) != VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700543 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-00987",
544 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT or "
545 "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT, it must also contain VK_IMAGE_CREATE_SPARSE_BINDING_BIT.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600546 }
547
548 // Check for combinations of attributes that are incompatible with having VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT set
549 if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT) != 0) {
550 // Linear tiling is unsupported
551 if (VK_IMAGE_TILING_LINEAR == pCreateInfo->tiling) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700552 skip |= LogError(device, kVUID_PVError_InvalidUsage,
553 "vkCreateImage: if pCreateInfo->flags contains VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT then image "
554 "tiling of VK_IMAGE_TILING_LINEAR is not supported");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600555 }
556
557 // Sparse 1D image isn't valid
558 if (VK_IMAGE_TYPE_1D == pCreateInfo->imageType) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700559 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00970",
560 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 1D image.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600561 }
562
563 // Sparse 2D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700564 if ((VK_FALSE == physical_device_features.sparseResidencyImage2D) && (VK_IMAGE_TYPE_2D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700565 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00971",
566 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2D image if corresponding "
567 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600568 }
569
570 // Sparse 3D image when device doesn't support it
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700571 if ((VK_FALSE == physical_device_features.sparseResidencyImage3D) && (VK_IMAGE_TYPE_3D == pCreateInfo->imageType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700572 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00972",
573 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 3D image if corresponding "
574 "feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600575 }
576
577 // Multi-sample 2D image when device doesn't support it
578 if (VK_IMAGE_TYPE_2D == pCreateInfo->imageType) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700579 if ((VK_FALSE == physical_device_features.sparseResidency2Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600580 (VK_SAMPLE_COUNT_2_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700581 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00973",
582 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 2-sample image if "
583 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700584 } else if ((VK_FALSE == physical_device_features.sparseResidency4Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600585 (VK_SAMPLE_COUNT_4_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700586 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00974",
587 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 4-sample image if "
588 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700589 } else if ((VK_FALSE == physical_device_features.sparseResidency8Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600590 (VK_SAMPLE_COUNT_8_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700591 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00975",
592 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 8-sample image if "
593 "corresponding feature is not enabled on the device.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700594 } else if ((VK_FALSE == physical_device_features.sparseResidency16Samples) &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600595 (VK_SAMPLE_COUNT_16_BIT == pCreateInfo->samples)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700596 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-00976",
597 "vkCreateImage: cannot specify VK_IMAGE_CREATE_SPARSE_BINDING_BIT for 16-sample image if "
598 "corresponding feature is not enabled on the device.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600599 }
600 }
601 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500602
Jeff Bolz9af91c52018-09-01 21:53:57 -0500603 if (pCreateInfo->usage & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) {
604 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700605 skip |= LogError(device, "VUID-VkImageCreateInfo-imageType-02082",
606 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
607 "imageType must be VK_IMAGE_TYPE_2D.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500608 }
609 if (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700610 skip |= LogError(device, "VUID-VkImageCreateInfo-samples-02083",
611 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
612 "samples must be VK_SAMPLE_COUNT_1_BIT.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500613 }
614 if (pCreateInfo->tiling != VK_IMAGE_TILING_OPTIMAL) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700615 skip |= LogError(device, "VUID-VkImageCreateInfo-tiling-02084",
616 "vkCreateImage: if usage includes VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, "
617 "tiling must be VK_IMAGE_TILING_OPTIMAL.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500618 }
619 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500620
621 if (pCreateInfo->flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) {
Dave Houlton142c4cb2018-10-17 15:04:41 -0600622 if (pCreateInfo->imageType != VK_IMAGE_TYPE_2D && pCreateInfo->imageType != VK_IMAGE_TYPE_3D) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700623 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02050",
624 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
625 "imageType must be VK_IMAGE_TYPE_2D or VK_IMAGE_TYPE_3D.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500626 }
627
Dave Houlton142c4cb2018-10-17 15:04:41 -0600628 if ((pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) || FormatIsDepthOrStencil(pCreateInfo->format)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700629 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02051",
630 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV, "
631 "it must not also contain VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT and format must "
632 "not be a depth/stencil format.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500633 }
634
Dave Houlton142c4cb2018-10-17 15:04:41 -0600635 if (pCreateInfo->imageType == VK_IMAGE_TYPE_2D && (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700636 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02052",
637 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
638 "imageType is VK_IMAGE_TYPE_2D, extent.width and extent.height must be "
639 "greater than 1.");
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500640 } else if (pCreateInfo->imageType == VK_IMAGE_TYPE_3D &&
Dave Houlton142c4cb2018-10-17 15:04:41 -0600641 (pCreateInfo->extent.width == 1 || pCreateInfo->extent.height == 1 || pCreateInfo->extent.depth == 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700642 skip |= LogError(device, "VUID-VkImageCreateInfo-flags-02053",
643 "vkCreateImage: If flags contains VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV and "
644 "imageType is VK_IMAGE_TYPE_3D, extent.width, extent.height, and extent.depth "
645 "must be greater than 1.");
Jeff Bolzef40fec2018-09-01 22:04:34 -0500646 }
647 }
Andrew Fobel3abeb992020-01-20 16:33:22 -0500648
649 const auto image_stencil_struct = lvl_find_in_chain<VkImageStencilUsageCreateInfoEXT>(pCreateInfo->pNext);
650 if (image_stencil_struct != nullptr) {
651 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
652 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
653 // No flags other than the legal attachment bits may be set
654 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
655 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700656 skip |= LogError(device, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
657 "vkCreateImage(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage includes "
658 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
659 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500660 }
661 }
662
663 if (FormatIsDepthOrStencil(pCreateInfo->format)) {
664 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT) != 0) {
665 if (pCreateInfo->extent.width > device_limits.maxFramebufferWidth) {
666 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700667 LogError(device, "VUID-VkImageCreateInfo-Format-02536",
668 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
669 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image width exceeds device "
670 "maxFramebufferWidth");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500671 }
672
673 if (pCreateInfo->extent.height > device_limits.maxFramebufferHeight) {
674 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700675 LogError(device, "VUID-VkImageCreateInfo-format-02537",
676 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
677 "stencilUsage including VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT and image height exceeds device "
678 "maxFramebufferHeight");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500679 }
680 }
681
682 if (!physical_device_features.shaderStorageImageMultisample &&
683 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
684 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
685 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700686 LogError(device, "VUID-VkImageCreateInfo-format-02538",
687 "vkCreateImage(): Depth-stencil image contains VkImageStencilUsageCreateInfo structure with "
688 "stencilUsage including VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images feature is "
689 "not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
Andrew Fobel3abeb992020-01-20 16:33:22 -0500690 }
691
692 if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0) &&
693 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700694 skip |= LogError(
695 device, "VUID-VkImageCreateInfo-format-02795",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500696 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
697 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
698 "also include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
699 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0) &&
700 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700701 skip |= LogError(
702 device, "VUID-VkImageCreateInfo-format-02796",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500703 "vkCreateImage(): Depth-stencil image in which usage does not include "
704 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT "
705 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
706 "also not include VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT");
707 }
708
709 if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) &&
710 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700711 skip |= LogError(
712 device, "VUID-VkImageCreateInfo-format-02797",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500713 "vkCreateImage(): Depth-stencil image in which usage includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
714 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
715 "also include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
716 } else if (((pCreateInfo->usage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) == 0) &&
717 ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700718 skip |= LogError(
719 device, "VUID-VkImageCreateInfo-format-02798",
Andrew Fobel3abeb992020-01-20 16:33:22 -0500720 "vkCreateImage(): Depth-stencil image in which usage does not include "
721 "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT "
722 "contains VkImageStencilUsageCreateInfo structure, VkImageStencilUsageCreateInfo::stencilUsage must "
723 "also not include VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT");
724 }
725 }
726 }
Spencer Frickeca52b5c2020-03-16 17:34:00 -0700727
728 if ((!physical_device_features.shaderStorageImageMultisample) && ((pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT) != 0) &&
729 (pCreateInfo->samples != VK_SAMPLE_COUNT_1_BIT)) {
730 skip |= LogError(device, "VUID-VkImageCreateInfo-usage-00968",
731 "vkCreateImage(): usage contains VK_IMAGE_USAGE_STORAGE_BIT and the multisampled storage images "
732 "feature is not enabled, image samples must be VK_SAMPLE_COUNT_1_BIT");
733 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600734 }
Jeff Bolzef40fec2018-09-01 22:04:34 -0500735
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600736 return skip;
737}
738
Jeff Bolz6d3beaa2019-02-09 21:00:05 -0600739bool StatelessValidation::manual_PreCallValidateViewport(const VkViewport &viewport, const char *fn_name,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700740 const ParameterName &parameter_name, VkCommandBuffer object) const {
Petr Krausb3fcdb42018-01-09 22:09:09 +0100741 bool skip = false;
Petr Krausb3fcdb42018-01-09 22:09:09 +0100742
743 // Note: for numerical correctness
744 // - float comparisons should expect NaN (comparison always false).
745 // - VkPhysicalDeviceLimits::maxViewportDimensions is uint32_t, not float -> careful.
746
747 const auto f_lte_u32_exact = [](const float v1_f, const uint32_t v2_u32) {
John Zulaufac0876c2018-02-19 10:09:35 -0700748 if (std::isnan(v1_f)) return false;
Petr Krausb3fcdb42018-01-09 22:09:09 +0100749 if (v1_f <= 0.0f) return true;
750
751 float intpart;
752 const float fract = modff(v1_f, &intpart);
753
754 assert(std::numeric_limits<float>::radix == 2);
755 const float u32_max_plus1 = ldexpf(1.0f, 32); // hopefully exact
756 if (intpart >= u32_max_plus1) return false;
757
758 uint32_t v1_u32 = static_cast<uint32_t>(intpart);
759 if (v1_u32 < v2_u32)
760 return true;
761 else if (v1_u32 == v2_u32 && fract == 0.0f)
762 return true;
763 else
764 return false;
765 };
766
767 const auto f_lte_u32_direct = [](const float v1_f, const uint32_t v2_u32) {
768 const float v2_f = static_cast<float>(v2_u32); // not accurate for > radix^digits; and undefined rounding mode
769 return (v1_f <= v2_f);
770 };
771
772 // width
773 bool width_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700774 const auto max_w = device_limits.maxViewportDimensions[0];
Petr Krausb3fcdb42018-01-09 22:09:09 +0100775
776 if (!(viewport.width > 0.0f)) {
777 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700778 skip |= LogError(object, "VUID-VkViewport-width-01770", "%s: %s.width (=%f) is not greater than 0.0.", fn_name,
779 parameter_name.get_name().c_str(), viewport.width);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100780 } else if (!(f_lte_u32_exact(viewport.width, max_w) || f_lte_u32_direct(viewport.width, max_w))) {
781 width_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700782 skip |= LogError(object, "VUID-VkViewport-width-01771",
783 "%s: %s.width (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32 ").", fn_name,
784 parameter_name.get_name().c_str(), viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100785 } else if (!f_lte_u32_exact(viewport.width, max_w) && f_lte_u32_direct(viewport.width, max_w)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700786 skip |= LogWarning(object, kVUID_PVError_NONE,
787 "%s: %s.width (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[0] (=%" PRIu32
788 "), but it is within the static_cast<float>(maxViewportDimensions[0]) limit.",
789 fn_name, parameter_name.get_name().c_str(), viewport.width, max_w);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100790 }
791
792 // height
793 bool height_healthy = true;
Mark Lobodzinskia09ab942020-02-20 11:01:59 -0700794 const bool negative_height_enabled = device_extensions.vk_khr_maintenance1 || device_extensions.vk_amd_negative_viewport_height;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700795 const auto max_h = device_limits.maxViewportDimensions[1];
Petr Krausb3fcdb42018-01-09 22:09:09 +0100796
797 if (!negative_height_enabled && !(viewport.height > 0.0f)) {
798 height_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700799 skip |= LogError(object, "VUID-VkViewport-height-01772", "%s: %s.height (=%f) is not greater 0.0.", fn_name,
800 parameter_name.get_name().c_str(), viewport.height);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100801 } else if (!(f_lte_u32_exact(fabsf(viewport.height), max_h) || f_lte_u32_direct(fabsf(viewport.height), max_h))) {
802 height_healthy = false;
803
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700804 skip |= LogError(object, "VUID-VkViewport-height-01773",
805 "%s: Absolute value of %s.height (=%f) exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
806 ").",
807 fn_name, parameter_name.get_name().c_str(), viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100808 } else if (!f_lte_u32_exact(fabsf(viewport.height), max_h) && f_lte_u32_direct(fabsf(viewport.height), max_h)) {
809 height_healthy = false;
810
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700811 skip |= LogWarning(
812 object, kVUID_PVError_NONE,
Petr Krausb3fcdb42018-01-09 22:09:09 +0100813 "%s: Absolute value of %s.height (=%f) technically exceeds VkPhysicalDeviceLimits::maxViewportDimensions[1] (=%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -0600814 "), but it is within the static_cast<float>(maxViewportDimensions[1]) limit.",
Jeff Bolz6d3beaa2019-02-09 21:00:05 -0600815 fn_name, parameter_name.get_name().c_str(), viewport.height, max_h);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100816 }
817
818 // x
819 bool x_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700820 if (!(viewport.x >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +0100821 x_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700822 skip |= LogError(object, "VUID-VkViewport-x-01774",
823 "%s: %s.x (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
824 parameter_name.get_name().c_str(), viewport.x, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100825 }
826
827 // x + width
828 if (x_healthy && width_healthy) {
829 const float right_bound = viewport.x + viewport.width;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700830 if (!(right_bound <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700831 skip |= LogError(
832 object, "VUID-VkViewport-x-01232",
833 "%s: %s.x + %s.width (=%f + %f = %f) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
834 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.x, viewport.width,
835 right_bound, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100836 }
837 }
838
839 // y
840 bool y_healthy = true;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700841 if (!(viewport.y >= device_limits.viewportBoundsRange[0])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +0100842 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700843 skip |= LogError(object, "VUID-VkViewport-y-01775",
844 "%s: %s.y (=%f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).", fn_name,
845 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[0]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700846 } else if (negative_height_enabled && !(viewport.y <= device_limits.viewportBoundsRange[1])) {
Petr Krausb3fcdb42018-01-09 22:09:09 +0100847 y_healthy = false;
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700848 skip |= LogError(object, "VUID-VkViewport-y-01776",
849 "%s: %s.y (=%f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).", fn_name,
850 parameter_name.get_name().c_str(), viewport.y, device_limits.viewportBoundsRange[1]);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100851 }
852
853 // y + height
854 if (y_healthy && height_healthy) {
855 const float boundary = viewport.y + viewport.height;
856
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700857 if (!(boundary <= device_limits.viewportBoundsRange[1])) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700858 skip |= LogError(object, "VUID-VkViewport-y-01233",
859 "%s: %s.y + %s.height (=%f + %f = %f) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=%f).",
860 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y,
861 viewport.height, boundary, device_limits.viewportBoundsRange[1]);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700862 } else if (negative_height_enabled && !(boundary >= device_limits.viewportBoundsRange[0])) {
Jeff Bolz6d3beaa2019-02-09 21:00:05 -0600863 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700864 LogError(object, "VUID-VkViewport-y-01777",
865 "%s: %s.y + %s.height (=%f + %f = %f) is less than VkPhysicalDeviceLimits::viewportBoundsRange[0] (=%f).",
866 fn_name, parameter_name.get_name().c_str(), parameter_name.get_name().c_str(), viewport.y, viewport.height,
867 boundary, device_limits.viewportBoundsRange[0]);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100868 }
869 }
870
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700871 if (!device_extensions.vk_ext_depth_range_unrestricted) {
Petr Krausb3fcdb42018-01-09 22:09:09 +0100872 // minDepth
873 if (!(viewport.minDepth >= 0.0) || !(viewport.minDepth <= 1.0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700874 skip |= LogError(object, "VUID-VkViewport-minDepth-01234",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600875
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700876 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.minDepth (=%f) is not within the "
877 "[0.0, 1.0] range.",
878 fn_name, parameter_name.get_name().c_str(), viewport.minDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100879 }
880
881 // maxDepth
882 if (!(viewport.maxDepth >= 0.0) || !(viewport.maxDepth <= 1.0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700883 skip |= LogError(object, "VUID-VkViewport-maxDepth-01235",
Mark Lobodzinski88529492018-04-01 10:38:15 -0600884
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700885 "%s: VK_EXT_depth_range_unrestricted extension is not enabled and %s.maxDepth (=%f) is not within the "
886 "[0.0, 1.0] range.",
887 fn_name, parameter_name.get_name().c_str(), viewport.maxDepth);
Petr Krausb3fcdb42018-01-09 22:09:09 +0100888 }
889 }
890
891 return skip;
892}
893
Dave Houlton142c4cb2018-10-17 15:04:41 -0600894struct SampleOrderInfo {
Jeff Bolz9af91c52018-09-01 21:53:57 -0500895 VkShadingRatePaletteEntryNV shadingRate;
896 uint32_t width;
897 uint32_t height;
898};
899
900// All palette entries with more than one pixel per fragment
Dave Houlton142c4cb2018-10-17 15:04:41 -0600901static SampleOrderInfo sampleOrderInfos[] = {
902 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_1X2_PIXELS_NV, 1, 2},
903 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X1_PIXELS_NV, 2, 1},
904 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X2_PIXELS_NV, 2, 2},
905 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X2_PIXELS_NV, 4, 2},
906 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_2X4_PIXELS_NV, 2, 4},
907 {VK_SHADING_RATE_PALETTE_ENTRY_1_INVOCATION_PER_4X4_PIXELS_NV, 4, 4},
Jeff Bolz9af91c52018-09-01 21:53:57 -0500908};
909
Jeff Bolz46c0ea02019-10-09 13:06:29 -0500910bool StatelessValidation::ValidateCoarseSampleOrderCustomNV(const VkCoarseSampleOrderCustomNV *order) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -0500911 bool skip = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -0500912
Jeff Bolz45bf7d62018-09-18 15:39:58 -0500913 SampleOrderInfo *sampleOrderInfo;
Jeff Bolz9af91c52018-09-01 21:53:57 -0500914 uint32_t infoIdx = 0;
Jeff Bolz45bf7d62018-09-18 15:39:58 -0500915 for (sampleOrderInfo = nullptr; infoIdx < ARRAY_SIZE(sampleOrderInfos); ++infoIdx) {
Jeff Bolz9af91c52018-09-01 21:53:57 -0500916 if (sampleOrderInfos[infoIdx].shadingRate == order->shadingRate) {
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500917 sampleOrderInfo = &sampleOrderInfos[infoIdx];
Jeff Bolz9af91c52018-09-01 21:53:57 -0500918 break;
919 }
920 }
921
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500922 if (sampleOrderInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700923 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-shadingRate-02073",
924 "VkCoarseSampleOrderCustomNV shadingRate must be a shading rate "
925 "that generates fragments with more than one pixel.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500926 return skip;
927 }
928
Dave Houlton142c4cb2018-10-17 15:04:41 -0600929 if (order->sampleCount == 0 || (order->sampleCount & (order->sampleCount - 1)) ||
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700930 !(order->sampleCount & device_limits.framebufferNoAttachmentsSampleCounts)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700931 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleCount-02074",
932 "VkCoarseSampleOrderCustomNV sampleCount (=%" PRIu32
933 ") must "
934 "correspond to a sample count enumerated in VkSampleCountFlags whose corresponding bit "
935 "is set in framebufferNoAttachmentsSampleCounts.",
936 order->sampleCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -0500937 }
938
Jeff Bolz9af91c52018-09-01 21:53:57 -0500939 if (order->sampleLocationCount != order->sampleCount * sampleOrderInfo->width * sampleOrderInfo->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700940 skip |= LogError(device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02075",
941 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
942 ") must "
943 "be equal to the product of sampleCount (=%" PRIu32
944 "), the fragment width for shadingRate "
945 "(=%" PRIu32 "), and the fragment height for shadingRate (=%" PRIu32 ").",
946 order->sampleLocationCount, order->sampleCount, sampleOrderInfo->width, sampleOrderInfo->height);
Jeff Bolz9af91c52018-09-01 21:53:57 -0500947 }
948
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700949 if (order->sampleLocationCount > phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700950 skip |= LogError(
951 device, "VUID-VkCoarseSampleOrderCustomNV-sampleLocationCount-02076",
Dave Houlton142c4cb2018-10-17 15:04:41 -0600952 "VkCoarseSampleOrderCustomNV sampleLocationCount (=%" PRIu32
953 ") must "
954 "be less than or equal to VkPhysicalDeviceShadingRateImagePropertiesNV shadingRateMaxCoarseSamples (=%" PRIu32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700955 order->sampleLocationCount, phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples);
Jeff Bolz9af91c52018-09-01 21:53:57 -0500956 }
Jeff Bolz9af91c52018-09-01 21:53:57 -0500957
958 // Accumulate a bitmask tracking which (x,y,sample) tuples are seen. Expect
Jeff Bolzb8a8dd02018-09-18 02:39:24 -0500959 // the first width*height*sampleCount bits to all be set. Note: There is no
960 // guarantee that 64 bits is enough, but practically it's unlikely for an
961 // implementation to support more than 32 bits for samplemask.
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -0700962 assert(phys_dev_ext_props.shading_rate_image_props.shadingRateMaxCoarseSamples <= 64);
Jeff Bolz9af91c52018-09-01 21:53:57 -0500963 uint64_t sampleLocationsMask = 0;
964 for (uint32_t i = 0; i < order->sampleLocationCount; ++i) {
965 const VkCoarseSampleLocationNV *sampleLoc = &order->pSampleLocations[i];
966 if (sampleLoc->pixelX >= sampleOrderInfo->width) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700967 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelX-02078",
968 "pixelX must be less than the width (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500969 }
970 if (sampleLoc->pixelY >= sampleOrderInfo->height) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700971 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-pixelY-02079",
972 "pixelY must be less than the height (in pixels) of the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500973 }
974 if (sampleLoc->sample >= order->sampleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700975 skip |= LogError(device, "VUID-VkCoarseSampleLocationNV-sample-02080",
976 "sample must be less than the number of coverage samples in each pixel belonging to the fragment.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500977 }
978 uint32_t idx = sampleLoc->sample + order->sampleCount * (sampleLoc->pixelX + sampleOrderInfo->width * sampleLoc->pixelY);
979 sampleLocationsMask |= 1ULL << idx;
980 }
981
982 uint64_t expectedMask = (order->sampleLocationCount == 64) ? ~0ULL : ((1ULL << order->sampleLocationCount) - 1);
983 if (sampleLocationsMask != expectedMask) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -0700984 skip |= LogError(
985 device, "VUID-VkCoarseSampleOrderCustomNV-pSampleLocations-02077",
Dave Houlton142c4cb2018-10-17 15:04:41 -0600986 "The array pSampleLocations must contain exactly one entry for "
987 "every combination of valid values for pixelX, pixelY, and sample in the structure VkCoarseSampleOrderCustomNV.");
Jeff Bolz9af91c52018-09-01 21:53:57 -0500988 }
989
990 return skip;
991}
992
Mark Lobodzinskibf599b92018-12-31 12:15:55 -0700993bool StatelessValidation::manual_PreCallValidateCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache,
994 uint32_t createInfoCount,
995 const VkGraphicsPipelineCreateInfo *pCreateInfos,
996 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -0500997 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600998 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -0600999
1000 if (pCreateInfos != nullptr) {
1001 for (uint32_t i = 0; i < createInfoCount; ++i) {
Petr Kraus299ba622017-11-24 03:09:03 +01001002 bool has_dynamic_viewport = false;
1003 bool has_dynamic_scissor = false;
1004 bool has_dynamic_line_width = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001005 bool has_dynamic_depth_bias = false;
1006 bool has_dynamic_blend_constant = false;
1007 bool has_dynamic_depth_bounds = false;
1008 bool has_dynamic_stencil_compare = false;
1009 bool has_dynamic_stencil_write = false;
1010 bool has_dynamic_stencil_reference = false;
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001011 bool has_dynamic_viewport_w_scaling_nv = false;
1012 bool has_dynamic_discard_rectangle_ext = false;
1013 bool has_dynamic_sample_locations_ext = false;
Jeff Bolz3e71f782018-08-29 23:15:45 -05001014 bool has_dynamic_exclusive_scissor_nv = false;
Jeff Bolz9af91c52018-09-01 21:53:57 -05001015 bool has_dynamic_shading_rate_palette_nv = false;
Spencer Fricke8d428882020-03-16 17:23:33 -07001016 bool has_dynamic_viewport_course_sample_order_nv = false;
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001017 bool has_dynamic_line_stipple = false;
Petr Kraus299ba622017-11-24 03:09:03 +01001018 if (pCreateInfos[i].pDynamicState != nullptr) {
1019 const auto &dynamic_state_info = *pCreateInfos[i].pDynamicState;
1020 for (uint32_t state_index = 0; state_index < dynamic_state_info.dynamicStateCount; ++state_index) {
1021 const auto &dynamic_state = dynamic_state_info.pDynamicStates[state_index];
Spencer Fricke8d428882020-03-16 17:23:33 -07001022 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT) {
1023 if (has_dynamic_viewport == true) {
1024 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1025 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT was listed twice in the "
1026 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1027 i);
1028 }
1029 has_dynamic_viewport = true;
1030 }
1031 if (dynamic_state == VK_DYNAMIC_STATE_SCISSOR) {
1032 if (has_dynamic_scissor == true) {
1033 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1034 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SCISSOR was listed twice in the "
1035 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1036 i);
1037 }
1038 has_dynamic_scissor = true;
1039 }
1040 if (dynamic_state == VK_DYNAMIC_STATE_LINE_WIDTH) {
1041 if (has_dynamic_line_width == true) {
1042 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1043 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_WIDTH was listed twice in the "
1044 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1045 i);
1046 }
1047 has_dynamic_line_width = true;
1048 }
1049 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BIAS) {
1050 if (has_dynamic_depth_bias == true) {
1051 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1052 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BIAS was listed twice in the "
1053 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1054 i);
1055 }
1056 has_dynamic_depth_bias = true;
1057 }
1058 if (dynamic_state == VK_DYNAMIC_STATE_BLEND_CONSTANTS) {
1059 if (has_dynamic_blend_constant == true) {
1060 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1061 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_BLEND_CONSTANTS was listed twice in the "
1062 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1063 i);
1064 }
1065 has_dynamic_blend_constant = true;
1066 }
1067 if (dynamic_state == VK_DYNAMIC_STATE_DEPTH_BOUNDS) {
1068 if (has_dynamic_depth_bounds == true) {
1069 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1070 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DEPTH_BOUNDS was listed twice in the "
1071 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1072 i);
1073 }
1074 has_dynamic_depth_bounds = true;
1075 }
1076 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK) {
1077 if (has_dynamic_stencil_compare == true) {
1078 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1079 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK was listed twice in "
1080 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1081 i);
1082 }
1083 has_dynamic_stencil_compare = true;
1084 }
1085 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_WRITE_MASK) {
1086 if (has_dynamic_stencil_write == true) {
1087 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1088 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_WRITE_MASK was listed twice in "
1089 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1090 i);
1091 }
1092 has_dynamic_stencil_write = true;
1093 }
1094 if (dynamic_state == VK_DYNAMIC_STATE_STENCIL_REFERENCE) {
1095 if (has_dynamic_stencil_reference == true) {
1096 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1097 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_STENCIL_REFERENCE was listed twice in "
1098 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1099 i);
1100 }
1101 has_dynamic_stencil_reference = true;
1102 }
1103 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV) {
1104 if (has_dynamic_viewport_w_scaling_nv == true) {
1105 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1106 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV was listed twice "
1107 "in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1108 i);
1109 }
1110 has_dynamic_viewport_w_scaling_nv = true;
1111 }
1112 if (dynamic_state == VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT) {
1113 if (has_dynamic_discard_rectangle_ext == true) {
1114 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1115 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT was listed twice "
1116 "in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1117 i);
1118 }
1119 has_dynamic_discard_rectangle_ext = true;
1120 }
1121 if (dynamic_state == VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT) {
1122 if (has_dynamic_sample_locations_ext == true) {
1123 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1124 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT was listed twice in "
1125 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1126 i);
1127 }
1128 has_dynamic_sample_locations_ext = true;
1129 }
1130 if (dynamic_state == VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV) {
1131 if (has_dynamic_exclusive_scissor_nv == true) {
1132 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1133 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV was listed twice in "
1134 "the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1135 i);
1136 }
1137 has_dynamic_exclusive_scissor_nv = true;
1138 }
1139 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV) {
1140 if (has_dynamic_shading_rate_palette_nv == true) {
1141 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1142 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV was "
1143 "listed twice in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1144 i);
1145 }
Dave Houlton142c4cb2018-10-17 15:04:41 -06001146 has_dynamic_shading_rate_palette_nv = true;
Spencer Fricke8d428882020-03-16 17:23:33 -07001147 }
1148 if (dynamic_state == VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV) {
1149 if (has_dynamic_viewport_course_sample_order_nv == true) {
1150 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1151 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_VIEWPORT_COARSE_SAMPLE_ORDER_NV was "
1152 "listed twice in the pCreateInfos[%d].pDynamicState->pDynamicStates array",
1153 i);
1154 }
1155 has_dynamic_viewport_course_sample_order_nv = true;
1156 }
1157 if (dynamic_state == VK_DYNAMIC_STATE_LINE_STIPPLE_EXT) {
1158 if (has_dynamic_line_stipple == true) {
1159 skip |= LogError(device, "VUID-VkPipelineDynamicStateCreateInfo-pDynamicStates-01442",
1160 "vkCreateGraphicsPipelines: VK_DYNAMIC_STATE_LINE_STIPPLE_EXT was listed twice in the "
1161 "pCreateInfos[%d].pDynamicState->pDynamicStates array",
1162 i);
1163 }
1164 has_dynamic_line_stipple = true;
1165 }
Petr Kraus299ba622017-11-24 03:09:03 +01001166 }
1167 }
1168
Peter Chen85366392019-05-14 15:20:11 -04001169 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
1170 if ((feedback_struct != nullptr) &&
1171 (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001172 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02668",
1173 "vkCreateGraphicsPipelines(): in pCreateInfo[%" PRIu32
1174 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
1175 "(=%" PRIu32 ") must equal VkGraphicsPipelineCreateInfo::stageCount(=%" PRIu32 ").",
1176 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04001177 }
1178
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001179 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001180
1181 // Collect active stages
1182 uint32_t active_shaders = 0;
1183 for (uint32_t stages = 0; stages < pCreateInfos[i].stageCount; stages++) {
Spencer Fricked84808f2020-01-20 06:08:01 -08001184 active_shaders |= pCreateInfos[i].pStages[stages].stage;
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001185 }
1186
1187 if ((active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) &&
1188 (active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && (pCreateInfos[i].pTessellationState != nullptr)) {
1189 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState",
1190 "VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO",
1191 pCreateInfos[i].pTessellationState,
1192 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_STATE_CREATE_INFO, false, kVUIDUndefined,
1193 "VUID-VkPipelineTessellationStateCreateInfo-sType-sType");
1194
1195 const VkStructureType allowed_structs_VkPipelineTessellationStateCreateInfo[] = {
1196 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO};
1197
1198 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->pNext",
1199 "VkPipelineTessellationDomainOriginStateCreateInfo",
1200 pCreateInfos[i].pTessellationState->pNext,
1201 ARRAY_SIZE(allowed_structs_VkPipelineTessellationStateCreateInfo),
1202 allowed_structs_VkPipelineTessellationStateCreateInfo, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001203 "VUID-VkPipelineTessellationStateCreateInfo-pNext-pNext",
1204 "VUID-VkPipelineTessellationStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001205
1206 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pTessellationState->flags",
1207 pCreateInfos[i].pTessellationState->flags,
1208 "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
1209 }
1210
1211 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (pCreateInfos[i].pInputAssemblyState != nullptr)) {
1212 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState",
1213 "VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO",
1214 pCreateInfos[i].pInputAssemblyState,
1215 VK_STRUCTURE_TYPE_PIPELINE_INPUT_ASSEMBLY_STATE_CREATE_INFO, false, kVUIDUndefined,
1216 "VUID-VkPipelineInputAssemblyStateCreateInfo-sType-sType");
1217
1218 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->pNext", NULL,
1219 pCreateInfos[i].pInputAssemblyState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001220 "VUID-VkPipelineInputAssemblyStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001221
1222 skip |= validate_reserved_flags("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->flags",
1223 pCreateInfos[i].pInputAssemblyState->flags,
1224 "VUID-VkPipelineInputAssemblyStateCreateInfo-flags-zerobitmask");
1225
1226 skip |= validate_ranged_enum("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->topology",
1227 "VkPrimitiveTopology", AllVkPrimitiveTopologyEnums,
1228 pCreateInfos[i].pInputAssemblyState->topology,
1229 "VUID-VkPipelineInputAssemblyStateCreateInfo-topology-parameter");
1230
1231 skip |= validate_bool32("vkCreateGraphicsPipelines", "pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable",
1232 pCreateInfos[i].pInputAssemblyState->primitiveRestartEnable);
1233 }
1234
1235 if (!(active_shaders & VK_SHADER_STAGE_MESH_BIT_NV) && (pCreateInfos[i].pVertexInputState != nullptr)) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001236 auto const &vertex_input_state = pCreateInfos[i].pVertexInputState;
Peter Kohautc7d9d392018-07-15 00:34:07 +02001237
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001238 if (pCreateInfos[i].pVertexInputState->flags != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001239 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-flags-zerobitmask",
1240 "vkCreateGraphicsPipelines: pararameter "
1241 "pCreateInfos[%d].pVertexInputState->flags (%u) is reserved and must be zero.",
1242 i, vertex_input_state->flags);
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001243 }
1244
1245 const VkStructureType allowed_structs_VkPipelineVertexInputStateCreateInfo[] = {
1246 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_DIVISOR_STATE_CREATE_INFO_EXT};
1247 skip |= validate_struct_pnext("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->pNext",
1248 "VkPipelineVertexInputDivisorStateCreateInfoEXT",
1249 pCreateInfos[i].pVertexInputState->pNext, 1,
1250 allowed_structs_VkPipelineVertexInputStateCreateInfo, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001251 "VUID-VkPipelineVertexInputStateCreateInfo-pNext-pNext",
1252 "VUID-VkPipelineVertexInputStateCreateInfo-sType-unique");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001253 skip |= validate_struct_type("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState",
1254 "VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO", vertex_input_state,
Shannon McPherson3cc90bc2019-08-13 11:28:22 -06001255 VK_STRUCTURE_TYPE_PIPELINE_VERTEX_INPUT_STATE_CREATE_INFO, false, kVUIDUndefined,
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001256 "VUID-VkPipelineVertexInputStateCreateInfo-sType-sType");
1257 skip |=
1258 validate_array("vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount",
1259 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions",
1260 pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount,
1261 &pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions, false, true, kVUIDUndefined,
1262 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-parameter");
1263
1264 skip |= validate_array(
1265 "vkCreateGraphicsPipelines", "pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount",
1266 "pCreateInfos[i]->pVertexAttributeDescriptions", vertex_input_state->vertexAttributeDescriptionCount,
1267 &vertex_input_state->pVertexAttributeDescriptions, false, true, kVUIDUndefined,
1268 "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-parameter");
1269
1270 if (pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions != NULL) {
1271 for (uint32_t vertexBindingDescriptionIndex = 0;
1272 vertexBindingDescriptionIndex < pCreateInfos[i].pVertexInputState->vertexBindingDescriptionCount;
1273 ++vertexBindingDescriptionIndex) {
1274 skip |= validate_ranged_enum(
1275 "vkCreateGraphicsPipelines",
1276 "pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions[j].inputRate", "VkVertexInputRate",
1277 AllVkVertexInputRateEnums,
1278 pCreateInfos[i].pVertexInputState->pVertexBindingDescriptions[vertexBindingDescriptionIndex].inputRate,
1279 "VUID-VkVertexInputBindingDescription-inputRate-parameter");
1280 }
1281 }
1282
1283 if (pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions != NULL) {
1284 for (uint32_t vertexAttributeDescriptionIndex = 0;
1285 vertexAttributeDescriptionIndex < pCreateInfos[i].pVertexInputState->vertexAttributeDescriptionCount;
1286 ++vertexAttributeDescriptionIndex) {
1287 skip |= validate_ranged_enum(
1288 "vkCreateGraphicsPipelines",
1289 "pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions[i].format", "VkFormat",
1290 AllVkFormatEnums,
1291 pCreateInfos[i].pVertexInputState->pVertexAttributeDescriptions[vertexAttributeDescriptionIndex].format,
1292 "VUID-VkVertexInputAttributeDescription-format-parameter");
1293 }
1294 }
1295
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001296 if (vertex_input_state->vertexBindingDescriptionCount > device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001297 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexBindingDescriptionCount-00613",
1298 "vkCreateGraphicsPipelines: pararameter "
1299 "pCreateInfo[%d].pVertexInputState->vertexBindingDescriptionCount (%u) is "
1300 "greater than VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1301 i, vertex_input_state->vertexBindingDescriptionCount, device_limits.maxVertexInputBindings);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001302 }
1303
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001304 if (vertex_input_state->vertexAttributeDescriptionCount > device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001305 skip |=
1306 LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-vertexAttributeDescriptionCount-00614",
1307 "vkCreateGraphicsPipelines: pararameter "
1308 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptionCount (%u) is "
1309 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1310 i, vertex_input_state->vertexAttributeDescriptionCount, device_limits.maxVertexInputAttributes);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001311 }
1312
1313 std::unordered_set<uint32_t> vertex_bindings(vertex_input_state->vertexBindingDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001314 for (uint32_t d = 0; d < vertex_input_state->vertexBindingDescriptionCount; ++d) {
1315 auto const &vertex_bind_desc = vertex_input_state->pVertexBindingDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001316 auto const &binding_it = vertex_bindings.find(vertex_bind_desc.binding);
1317 if (binding_it != vertex_bindings.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001318 skip |= LogError(device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexBindingDescriptions-00616",
1319 "vkCreateGraphicsPipelines: parameter "
1320 "pCreateInfo[%d].pVertexInputState->pVertexBindingDescription[%d].binding "
1321 "(%" PRIu32 ") is not distinct.",
1322 i, d, vertex_bind_desc.binding);
Peter Kohautc7d9d392018-07-15 00:34:07 +02001323 }
1324 vertex_bindings.insert(vertex_bind_desc.binding);
1325
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001326 if (vertex_bind_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001327 skip |= LogError(device, "VUID-VkVertexInputBindingDescription-binding-00618",
1328 "vkCreateGraphicsPipelines: parameter "
1329 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].binding (%u) is "
1330 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1331 i, d, vertex_bind_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001332 }
1333
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001334 if (vertex_bind_desc.stride > device_limits.maxVertexInputBindingStride) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001335 skip |=
1336 LogError(device, "VUID-VkVertexInputBindingDescription-stride-00619",
1337 "vkCreateGraphicsPipelines: parameter "
1338 "pCreateInfos[%u].pVertexInputState->pVertexBindingDescriptions[%u].stride (%u) is greater "
1339 "than VkPhysicalDeviceLimits::maxVertexInputBindingStride (%u).",
1340 i, d, vertex_bind_desc.stride, device_limits.maxVertexInputBindingStride);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001341 }
1342 }
1343
Peter Kohautc7d9d392018-07-15 00:34:07 +02001344 std::unordered_set<uint32_t> attribute_locations(vertex_input_state->vertexAttributeDescriptionCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001345 for (uint32_t d = 0; d < vertex_input_state->vertexAttributeDescriptionCount; ++d) {
1346 auto const &vertex_attrib_desc = vertex_input_state->pVertexAttributeDescriptions[d];
Peter Kohautc7d9d392018-07-15 00:34:07 +02001347 auto const &location_it = attribute_locations.find(vertex_attrib_desc.location);
1348 if (location_it != attribute_locations.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001349 skip |= LogError(
1350 device, "VUID-VkPipelineVertexInputStateCreateInfo-pVertexAttributeDescriptions-00617",
Peter Kohautc7d9d392018-07-15 00:34:07 +02001351 "vkCreateGraphicsPipelines: parameter "
1352 "pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].location (%u) is not distinct.",
1353 i, d, vertex_attrib_desc.location);
1354 }
1355 attribute_locations.insert(vertex_attrib_desc.location);
1356
1357 auto const &binding_it = vertex_bindings.find(vertex_attrib_desc.binding);
1358 if (binding_it == vertex_bindings.cend()) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001359 skip |= LogError(
1360 device, "VUID-VkPipelineVertexInputStateCreateInfo-binding-00615",
Peter Kohautc7d9d392018-07-15 00:34:07 +02001361 "vkCreateGraphicsPipelines: parameter "
1362 " pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].binding (%u) does not exist "
1363 "in any pCreateInfo[%d].pVertexInputState->pVertexBindingDescription.",
1364 i, d, vertex_attrib_desc.binding, i);
1365 }
1366
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001367 if (vertex_attrib_desc.location >= device_limits.maxVertexInputAttributes) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001368 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-location-00620",
1369 "vkCreateGraphicsPipelines: parameter "
1370 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].location (%u) is "
1371 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputAttributes (%u).",
1372 i, d, vertex_attrib_desc.location, device_limits.maxVertexInputAttributes);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001373 }
1374
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001375 if (vertex_attrib_desc.binding >= device_limits.maxVertexInputBindings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001376 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-binding-00621",
1377 "vkCreateGraphicsPipelines: parameter "
1378 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].binding (%u) is "
1379 "greater than or equal to VkPhysicalDeviceLimits::maxVertexInputBindings (%u).",
1380 i, d, vertex_attrib_desc.binding, device_limits.maxVertexInputBindings);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001381 }
1382
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001383 if (vertex_attrib_desc.offset > device_limits.maxVertexInputAttributeOffset) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001384 skip |= LogError(device, "VUID-VkVertexInputAttributeDescription-offset-00622",
1385 "vkCreateGraphicsPipelines: parameter "
1386 "pCreateInfos[%u].pVertexInputState->pVertexAttributeDescriptions[%u].offset (%u) is "
1387 "greater than VkPhysicalDeviceLimits::maxVertexInputAttributeOffset (%u).",
1388 i, d, vertex_attrib_desc.offset, device_limits.maxVertexInputAttributeOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001389 }
1390 }
1391 }
1392
1393 if (pCreateInfos[i].pStages != nullptr) {
1394 bool has_control = false;
1395 bool has_eval = false;
1396
1397 for (uint32_t stage_index = 0; stage_index < pCreateInfos[i].stageCount; ++stage_index) {
1398 if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
1399 has_control = true;
1400 } else if (pCreateInfos[i].pStages[stage_index].stage == VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) {
1401 has_eval = true;
1402 }
1403 }
1404
1405 // pTessellationState is ignored without both tessellation control and tessellation evaluation shaders stages
1406 if (has_control && has_eval) {
1407 if (pCreateInfos[i].pTessellationState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001408 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pStages-00731",
1409 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pStages includes a tessellation control "
1410 "shader stage and a tessellation evaluation shader stage, "
1411 "pCreateInfos[%d].pTessellationState must not be NULL.",
1412 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001413 } else {
Lockee04009e2019-03-08 12:22:35 -07001414 const VkStructureType allowed_type =
1415 VK_STRUCTURE_TYPE_PIPELINE_TESSELLATION_DOMAIN_ORIGIN_STATE_CREATE_INFO;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001416 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001417 "vkCreateGraphicsPipelines",
Lockee04009e2019-03-08 12:22:35 -07001418 ParameterName("pCreateInfos[%i].pTessellationState->pNext", ParameterName::IndexVector{i}),
1419 "VkPipelineTessellationDomainOriginStateCreateInfo", pCreateInfos[i].pTessellationState->pNext, 1,
sfricke-samsung32a27362020-02-28 09:06:42 -08001420 &allowed_type, GeneratedVulkanHeaderVersion, "VUID-VkGraphicsPipelineCreateInfo-pNext-pNext",
1421 "VUID-VkGraphicsPipelineCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001422
1423 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001424 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001425 ParameterName("pCreateInfos[%i].pTessellationState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001426 pCreateInfos[i].pTessellationState->flags,
1427 "VUID-VkPipelineTessellationStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001428
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001429 if (pCreateInfos[i].pTessellationState->patchControlPoints == 0 ||
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001430 pCreateInfos[i].pTessellationState->patchControlPoints > device_limits.maxTessellationPatchSize) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001431 skip |= LogError(device, "VUID-VkPipelineTessellationStateCreateInfo-patchControlPoints-01214",
1432 "vkCreateGraphicsPipelines: invalid parameter "
1433 "pCreateInfos[%d].pTessellationState->patchControlPoints value %u. patchControlPoints "
1434 "should be >0 and <=%u.",
1435 i, pCreateInfos[i].pTessellationState->patchControlPoints,
1436 device_limits.maxTessellationPatchSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001437 }
1438 }
1439 }
1440 }
1441
1442 // pViewportState, pMultisampleState, pDepthStencilState, and pColorBlendState ignored when rasterization is disabled
1443 if ((pCreateInfos[i].pRasterizationState != nullptr) &&
1444 (pCreateInfos[i].pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) {
1445 if (pCreateInfos[i].pViewportState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001446 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00750",
1447 "vkCreateGraphicsPipelines: Rasterization is enabled (pCreateInfos[%" PRIu32
1448 "].pRasterizationState->rasterizerDiscardEnable is VK_FALSE), but pCreateInfos[%" PRIu32
1449 "].pViewportState (=NULL) is not a valid pointer.",
1450 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001451 } else {
Petr Krausa6103552017-11-16 21:21:58 +01001452 const auto &viewport_state = *pCreateInfos[i].pViewportState;
1453
1454 if (viewport_state.sType != VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001455 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-sType-sType",
1456 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1457 "].pViewportState->sType is not VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO.",
1458 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001459 }
1460
Petr Krausa6103552017-11-16 21:21:58 +01001461 const VkStructureType allowed_structs_VkPipelineViewportStateCreateInfo[] = {
1462 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SWIZZLE_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001463 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_W_SCALING_STATE_CREATE_INFO_NV,
1464 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_EXCLUSIVE_SCISSOR_STATE_CREATE_INFO_NV,
Jeff Bolz9af91c52018-09-01 21:53:57 -05001465 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_SHADING_RATE_IMAGE_STATE_CREATE_INFO_NV,
1466 VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_COARSE_SAMPLE_ORDER_STATE_CREATE_INFO_NV,
Jeff Bolz3e71f782018-08-29 23:15:45 -05001467 };
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001468 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001469 "vkCreateGraphicsPipelines",
Petr Krausa6103552017-11-16 21:21:58 +01001470 ParameterName("pCreateInfos[%i].pViewportState->pNext", ParameterName::IndexVector{i}),
Jeff Bolz9af91c52018-09-01 21:53:57 -05001471 "VkPipelineViewportSwizzleStateCreateInfoNV, VkPipelineViewportWScalingStateCreateInfoNV, "
Jeff Bolzb8a8dd02018-09-18 02:39:24 -05001472 "VkPipelineViewportExclusiveScissorStateCreateInfoNV, VkPipelineViewportShadingRateImageStateCreateInfoNV, "
1473 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV",
Petr Krausa6103552017-11-16 21:21:58 +01001474 viewport_state.pNext, ARRAY_SIZE(allowed_structs_VkPipelineViewportStateCreateInfo),
sfricke-samsung32a27362020-02-28 09:06:42 -08001475 allowed_structs_VkPipelineViewportStateCreateInfo, 65, "VUID-VkPipelineViewportStateCreateInfo-pNext-pNext",
1476 "VUID-VkPipelineViewportStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001477
1478 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001479 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001480 ParameterName("pCreateInfos[%i].pViewportState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001481 viewport_state.flags, "VUID-VkPipelineViewportStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001482
Dave Houlton142c4cb2018-10-17 15:04:41 -06001483 auto exclusive_scissor_struct = lvl_find_in_chain<VkPipelineViewportExclusiveScissorStateCreateInfoNV>(
1484 pCreateInfos[i].pViewportState->pNext);
1485 auto shading_rate_image_struct = lvl_find_in_chain<VkPipelineViewportShadingRateImageStateCreateInfoNV>(
1486 pCreateInfos[i].pViewportState->pNext);
1487 auto coarse_sample_order_struct = lvl_find_in_chain<VkPipelineViewportCoarseSampleOrderStateCreateInfoNV>(
1488 pCreateInfos[i].pViewportState->pNext);
Chris Mayer328d8212018-12-11 14:16:18 +01001489 const auto vp_swizzle_struct =
1490 lvl_find_in_chain<VkPipelineViewportSwizzleStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02001491 const auto vp_w_scaling_struct =
1492 lvl_find_in_chain<VkPipelineViewportWScalingStateCreateInfoNV>(pCreateInfos[i].pViewportState->pNext);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001493
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001494 if (!physical_device_features.multiViewport) {
Petr Krausa6103552017-11-16 21:21:58 +01001495 if (viewport_state.viewportCount != 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001496 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01216",
1497 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1498 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32
1499 ") is not 1.",
1500 i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001501 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001502
Petr Krausa6103552017-11-16 21:21:58 +01001503 if (viewport_state.scissorCount != 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001504 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01217",
1505 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1506 "disabled, but pCreateInfos[%" PRIu32 "].pViewportState->scissorCount (=%" PRIu32
1507 ") is not 1.",
1508 i, viewport_state.scissorCount);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001509 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001510
Dave Houlton142c4cb2018-10-17 15:04:41 -06001511 if (exclusive_scissor_struct && (exclusive_scissor_struct->exclusiveScissorCount != 0 &&
1512 exclusive_scissor_struct->exclusiveScissorCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001513 skip |= LogError(
1514 device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02027",
1515 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1516 "disabled, but pCreateInfos[%" PRIu32
1517 "] VkPipelineViewportExclusiveScissorStateCreateInfoNV::exclusiveScissorCount (=%" PRIu32
1518 ") is not 1.",
1519 i, exclusive_scissor_struct->exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001520 }
1521
Jeff Bolz9af91c52018-09-01 21:53:57 -05001522 if (shading_rate_image_struct &&
1523 (shading_rate_image_struct->viewportCount != 0 && shading_rate_image_struct->viewportCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001524 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02054",
1525 "vkCreateGraphicsPipelines: The VkPhysicalDeviceFeatures::multiViewport feature is "
1526 "disabled, but pCreateInfos[%" PRIu32
1527 "] VkPipelineViewportShadingRateImageStateCreateInfoNV::viewportCount (=%" PRIu32
1528 ") is neither 0 nor 1.",
1529 i, shading_rate_image_struct->viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001530 }
1531
Petr Krausa6103552017-11-16 21:21:58 +01001532 } else { // multiViewport enabled
1533 if (viewport_state.viewportCount == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001534 skip |= LogError(
1535 device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001536 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->viewportCount is 0.", i);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001537 } else if (viewport_state.viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001538 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportCount-01218",
1539 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1540 "].pViewportState->viewportCount (=%" PRIu32
1541 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1542 i, viewport_state.viewportCount, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001543 }
Petr Krausa6103552017-11-16 21:21:58 +01001544
1545 if (viewport_state.scissorCount == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001546 skip |= LogError(
1547 device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-arraylength",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001548 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "].pViewportState->scissorCount is 0.", i);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001549 } else if (viewport_state.scissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001550 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01219",
1551 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1552 "].pViewportState->scissorCount (=%" PRIu32
1553 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1554 i, viewport_state.scissorCount, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001555 }
1556 }
1557
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001558 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001559 skip |=
1560 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02028",
1561 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
1562 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1563 i, exclusive_scissor_struct->exclusiveScissorCount, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001564 }
1565
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001566 if (shading_rate_image_struct && shading_rate_image_struct->viewportCount > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001567 skip |= LogError(device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-viewportCount-02055",
1568 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1569 "] VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1570 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
1571 i, shading_rate_image_struct->viewportCount, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001572 }
1573
Petr Krausa6103552017-11-16 21:21:58 +01001574 if (viewport_state.scissorCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001575 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-scissorCount-01220",
1576 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1577 "].pViewportState->scissorCount (=%" PRIu32 ") is not identical to pCreateInfos[%" PRIu32
1578 "].pViewportState->viewportCount (=%" PRIu32 ").",
1579 i, viewport_state.scissorCount, i, viewport_state.viewportCount);
Petr Krausa6103552017-11-16 21:21:58 +01001580 }
1581
Dave Houlton142c4cb2018-10-17 15:04:41 -06001582 if (exclusive_scissor_struct && exclusive_scissor_struct->exclusiveScissorCount != 0 &&
Jeff Bolz3e71f782018-08-29 23:15:45 -05001583 exclusive_scissor_struct->exclusiveScissorCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001584 skip |=
1585 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-exclusiveScissorCount-02029",
1586 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32 "] exclusiveScissorCount (=%" PRIu32
1587 ") must be zero or identical to pCreateInfos[%" PRIu32
1588 "].pViewportState->viewportCount (=%" PRIu32 ").",
1589 i, exclusive_scissor_struct->exclusiveScissorCount, i, viewport_state.viewportCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001590 }
1591
Dave Houlton142c4cb2018-10-17 15:04:41 -06001592 if (shading_rate_image_struct && shading_rate_image_struct->shadingRateImageEnable &&
Jeff Bolz9af91c52018-09-01 21:53:57 -05001593 shading_rate_image_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001594 skip |= LogError(
1595 device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-shadingRateImageEnable-02056",
Dave Houlton142c4cb2018-10-17 15:04:41 -06001596 "vkCreateGraphicsPipelines: If shadingRateImageEnable is enabled, pCreateInfos[%" PRIu32
1597 "] "
1598 "VkPipelineViewportShadingRateImageStateCreateInfoNV viewportCount (=%" PRIu32
1599 ") must identical to pCreateInfos[%" PRIu32 "].pViewportState->viewportCount (=%" PRIu32 ").",
1600 i, shading_rate_image_struct->viewportCount, i, viewport_state.viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001601 }
1602
Petr Krausa6103552017-11-16 21:21:58 +01001603 if (!has_dynamic_viewport && viewport_state.viewportCount > 0 && viewport_state.pViewports == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001604 skip |= LogError(
1605 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00747",
Petr Krausa6103552017-11-16 21:21:58 +01001606 "vkCreateGraphicsPipelines: The viewport state is static (pCreateInfos[%" PRIu32
1607 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001608 "].pViewportState->pViewports (=NULL) is an invalid pointer.",
1609 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001610 }
1611
1612 if (!has_dynamic_scissor && viewport_state.scissorCount > 0 && viewport_state.pScissors == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001613 skip |= LogError(
1614 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00748",
Petr Krausa6103552017-11-16 21:21:58 +01001615 "vkCreateGraphicsPipelines: The scissor state is static (pCreateInfos[%" PRIu32
1616 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_SCISSOR), but pCreateInfos[%" PRIu32
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06001617 "].pViewportState->pScissors (=NULL) is an invalid pointer.",
1618 i, i);
Petr Krausa6103552017-11-16 21:21:58 +01001619 }
1620
Jeff Bolz3e71f782018-08-29 23:15:45 -05001621 if (!has_dynamic_exclusive_scissor_nv && exclusive_scissor_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06001622 exclusive_scissor_struct->exclusiveScissorCount > 0 &&
1623 exclusive_scissor_struct->pExclusiveScissors == nullptr) {
1624 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001625 LogError(device, "VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-pDynamicStates-02030",
1626 "vkCreateGraphicsPipelines: The exclusive scissor state is static (pCreateInfos[%" PRIu32
1627 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV), but "
1628 "pCreateInfos[%" PRIu32 "] pExclusiveScissors (=NULL) is an invalid pointer.",
1629 i, i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001630 }
1631
Jeff Bolz9af91c52018-09-01 21:53:57 -05001632 if (!has_dynamic_shading_rate_palette_nv && shading_rate_image_struct &&
Dave Houlton142c4cb2018-10-17 15:04:41 -06001633 shading_rate_image_struct->viewportCount > 0 &&
1634 shading_rate_image_struct->pShadingRatePalettes == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001635 skip |= LogError(
1636 device, "VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-pDynamicStates-02057",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001637 "vkCreateGraphicsPipelines: The shading rate palette state is static (pCreateInfos[%" PRIu32
Dave Houlton142c4cb2018-10-17 15:04:41 -06001638 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_VIEWPORT_SHADING_RATE_PALETTE_NV), "
1639 "but pCreateInfos[%" PRIu32 "] pShadingRatePalettes (=NULL) is an invalid pointer.",
Jeff Bolz9af91c52018-09-01 21:53:57 -05001640 i, i);
1641 }
1642
Chris Mayer328d8212018-12-11 14:16:18 +01001643 if (vp_swizzle_struct) {
1644 if (vp_swizzle_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001645 skip |= LogError(device, "VUID-VkPipelineViewportSwizzleStateCreateInfoNV-viewportCount-01215",
1646 "vkCreateGraphicsPipelines: The viewport swizzle state vieport count of %" PRIu32
1647 " does "
1648 "not match the viewport count of %" PRIu32 " in VkPipelineViewportStateCreateInfo.",
1649 vp_swizzle_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer328d8212018-12-11 14:16:18 +01001650 }
1651 }
1652
Petr Krausb3fcdb42018-01-09 22:09:09 +01001653 // validate the VkViewports
1654 if (!has_dynamic_viewport && viewport_state.pViewports) {
1655 for (uint32_t viewport_i = 0; viewport_i < viewport_state.viewportCount; ++viewport_i) {
1656 const auto &viewport = viewport_state.pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06001657 const char *fn_name = "vkCreateGraphicsPipelines";
1658 skip |= manual_PreCallValidateViewport(viewport, fn_name,
1659 ParameterName("pCreateInfos[%i].pViewportState->pViewports[%i]",
1660 ParameterName::IndexVector{i, viewport_i}),
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001661 VkCommandBuffer(0));
Petr Krausb3fcdb42018-01-09 22:09:09 +01001662 }
1663 }
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001664
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001665 if (has_dynamic_viewport_w_scaling_nv && !device_extensions.vk_nv_clip_space_w_scaling) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001666 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
1667 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1668 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_VIEWPORT_W_SCALING_NV, but "
1669 "VK_NV_clip_space_w_scaling extension is not enabled.",
1670 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001671 }
1672
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001673 if (has_dynamic_discard_rectangle_ext && !device_extensions.vk_ext_discard_rectangles) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001674 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
1675 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1676 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT, but "
1677 "VK_EXT_discard_rectangles extension is not enabled.",
1678 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001679 }
1680
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001681 if (has_dynamic_sample_locations_ext && !device_extensions.vk_ext_sample_locations) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001682 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
1683 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1684 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_EXT, but "
1685 "VK_EXT_sample_locations extension is not enabled.",
1686 i);
Jeremy Kniager71fd5f02017-11-15 13:27:03 -07001687 }
Jeff Bolz3e71f782018-08-29 23:15:45 -05001688
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001689 if (has_dynamic_exclusive_scissor_nv && !device_extensions.vk_nv_scissor_exclusive) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001690 skip |= LogError(device, kVUID_PVError_ExtensionNotEnabled,
1691 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1692 "].pDynamicState->pDynamicStates contains VK_DYNAMIC_STATE_EXCLUSIVE_SCISSOR_NV, but "
1693 "VK_NV_scissor_exclusive extension is not enabled.",
1694 i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05001695 }
Jeff Bolz9af91c52018-09-01 21:53:57 -05001696
1697 if (coarse_sample_order_struct &&
1698 coarse_sample_order_struct->sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV &&
1699 coarse_sample_order_struct->customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001700 skip |= LogError(device, "VUID-VkPipelineViewportCoarseSampleOrderStateCreateInfoNV-sampleOrderType-02072",
1701 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1702 "] "
1703 "VkPipelineViewportCoarseSampleOrderStateCreateInfoNV sampleOrderType is not "
1704 "VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV and customSampleOrderCount is not 0.",
1705 i);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001706 }
1707
1708 if (coarse_sample_order_struct) {
1709 for (uint32_t order_i = 0; order_i < coarse_sample_order_struct->customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001710 skip |= ValidateCoarseSampleOrderCustomNV(&coarse_sample_order_struct->pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05001711 }
1712 }
Chris Mayer9ded5eb2019-09-19 16:33:26 +02001713
1714 if (vp_w_scaling_struct && (vp_w_scaling_struct->viewportWScalingEnable == VK_TRUE)) {
1715 if (vp_w_scaling_struct->viewportCount != viewport_state.viewportCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001716 skip |= LogError(device, "VUID-VkPipelineViewportStateCreateInfo-viewportWScalingEnable-01726",
1717 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1718 "] "
1719 "VkPipelineViewportWScalingStateCreateInfoNV.viewportCount (=%" PRIu32
1720 ") "
1721 "is not equal to VkPipelineViewportStateCreateInfo.viewportCount (=%" PRIu32 ").",
1722 i, vp_w_scaling_struct->viewportCount, viewport_state.viewportCount);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02001723 }
1724 if (!has_dynamic_viewport_w_scaling_nv && !vp_w_scaling_struct->pViewportWScalings) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001725 skip |= LogError(
1726 device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-01715",
Chris Mayer9ded5eb2019-09-19 16:33:26 +02001727 "vkCreateGraphicsPipelines: pCreateInfos[%" PRIu32
1728 "] "
1729 "VkPipelineViewportWScalingStateCreateInfoNV.pViewportWScalings (=NULL) is not a valid array.",
1730 i);
1731 }
1732 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001733 }
1734
1735 if (pCreateInfos[i].pMultisampleState == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001736 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-rasterizerDiscardEnable-00751",
1737 "vkCreateGraphicsPipelines: if pCreateInfos[%d].pRasterizationState->rasterizerDiscardEnable "
1738 "is VK_FALSE, pCreateInfos[%d].pMultisampleState must not be NULL.",
1739 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001740 } else {
Dave Houltonb3bbec72018-01-17 10:13:33 -07001741 const VkStructureType valid_next_stypes[] = {LvlTypeMap<VkPipelineCoverageModulationStateCreateInfoNV>::kSType,
1742 LvlTypeMap<VkPipelineCoverageToColorStateCreateInfoNV>::kSType,
1743 LvlTypeMap<VkPipelineSampleLocationsStateCreateInfoEXT>::kSType};
Mike Schuchardt97662b02017-12-06 13:31:29 -07001744 const char *valid_struct_names =
Dave Houltona9df0ce2018-02-07 10:51:23 -07001745 "VkPipelineCoverageModulationStateCreateInfoNV, VkPipelineCoverageToColorStateCreateInfoNV, "
John Zulauf96b0e422017-11-14 11:43:19 -07001746 "VkPipelineSampleLocationsStateCreateInfoEXT";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001747 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001748 "vkCreateGraphicsPipelines",
John Zulauf96b0e422017-11-14 11:43:19 -07001749 ParameterName("pCreateInfos[%i].pMultisampleState->pNext", ParameterName::IndexVector{i}),
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07001750 valid_struct_names, pCreateInfos[i].pMultisampleState->pNext, 3, valid_next_stypes,
sfricke-samsung32a27362020-02-28 09:06:42 -08001751 GeneratedVulkanHeaderVersion, "VUID-VkPipelineMultisampleStateCreateInfo-pNext-pNext",
1752 "VUID-VkPipelineMultisampleStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001753
1754 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001755 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001756 ParameterName("pCreateInfos[%i].pMultisampleState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001757 pCreateInfos[i].pMultisampleState->flags, "VUID-VkPipelineMultisampleStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001758
1759 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001760 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001761 ParameterName("pCreateInfos[%i].pMultisampleState->sampleShadingEnable", ParameterName::IndexVector{i}),
1762 pCreateInfos[i].pMultisampleState->sampleShadingEnable);
1763
1764 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001765 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001766 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
1767 ParameterName("pCreateInfos[%i].pMultisampleState->pSampleMask", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00001768 pCreateInfos[i].pMultisampleState->rasterizationSamples, &pCreateInfos[i].pMultisampleState->pSampleMask,
Dave Houlton413a6782018-05-22 13:01:54 -06001769 true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001770
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001771 skip |= validate_flags(
1772 "vkCreateGraphicsPipelines",
1773 ParameterName("pCreateInfos[%i].pMultisampleState->rasterizationSamples", ParameterName::IndexVector{i}),
1774 "VkSampleCountFlagBits", AllVkSampleCountFlagBits, pCreateInfos[i].pMultisampleState->rasterizationSamples,
Petr Kraus52758be2019-08-12 00:53:58 +02001775 kRequiredSingleBit, "VUID-VkPipelineMultisampleStateCreateInfo-rasterizationSamples-parameter");
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06001776
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001777 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001778 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001779 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToCoverageEnable", ParameterName::IndexVector{i}),
1780 pCreateInfos[i].pMultisampleState->alphaToCoverageEnable);
1781
1782 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001783 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001784 ParameterName("pCreateInfos[%i].pMultisampleState->alphaToOneEnable", ParameterName::IndexVector{i}),
1785 pCreateInfos[i].pMultisampleState->alphaToOneEnable);
1786
1787 if (pCreateInfos[i].pMultisampleState->sType != VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001788 skip |= LogError(device, kVUID_PVError_InvalidStructSType,
1789 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pMultisampleState->sType must be "
1790 "VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO",
1791 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001792 }
John Zulauf7acac592017-11-06 11:15:53 -07001793 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable == VK_TRUE) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001794 if (!physical_device_features.sampleRateShading) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001795 skip |= LogError(device, "VUID-VkPipelineMultisampleStateCreateInfo-sampleShadingEnable-00784",
1796 "vkCreateGraphicsPipelines(): parameter "
1797 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable.",
1798 i);
John Zulauf7acac592017-11-06 11:15:53 -07001799 }
1800 // TODO Add documentation issue about when minSampleShading must be in range and when it is ignored
1801 // For now a "least noise" test *only* when sampleShadingEnable is VK_TRUE.
1802 if (!in_inclusive_range(pCreateInfos[i].pMultisampleState->minSampleShading, 0.F, 1.0F)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001803 skip |= LogError(
1804 device,
1805
Dave Houlton413a6782018-05-22 13:01:54 -06001806 "VUID-VkPipelineMultisampleStateCreateInfo-minSampleShading-00786",
Mark Lobodzinski88529492018-04-01 10:38:15 -06001807 "vkCreateGraphicsPipelines(): parameter pCreateInfos[%d].pMultisampleState->minSampleShading.", i);
John Zulauf7acac592017-11-06 11:15:53 -07001808 }
1809 }
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001810
1811 const auto *line_state = lvl_find_in_chain<VkPipelineRasterizationLineStateCreateInfoEXT>(
1812 pCreateInfos[i].pRasterizationState->pNext);
1813
1814 if (line_state) {
1815 if ((line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT ||
1816 line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT)) {
1817 if (pCreateInfos[i].pMultisampleState->alphaToCoverageEnable) {
1818 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001819 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
1820 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
1821 "pCreateInfos[%d].pMultisampleState->alphaToCoverageEnable == VK_TRUE.",
1822 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001823 }
1824 if (pCreateInfos[i].pMultisampleState->alphaToOneEnable) {
1825 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001826 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
1827 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
1828 "pCreateInfos[%d].pMultisampleState->alphaToOneEnable == VK_TRUE.",
1829 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001830 }
1831 if (pCreateInfos[i].pMultisampleState->sampleShadingEnable) {
1832 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001833 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766",
1834 "vkCreateGraphicsPipelines(): Bresenham/Smooth line rasterization not supported with "
1835 "pCreateInfos[%d].pMultisampleState->sampleShadingEnable == VK_TRUE.",
1836 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001837 }
1838 }
1839 if (line_state->stippledLineEnable && !has_dynamic_line_stipple) {
1840 if (line_state->lineStippleFactor < 1 || line_state->lineStippleFactor > 256) {
1841 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001842 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-stippledLineEnable-02767",
1843 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineStippleFactor = %d must be in the "
1844 "range [1,256].",
1845 i, line_state->lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001846 }
1847 }
1848 const auto *line_features =
Tony-LunarG6c3c5452019-12-13 10:37:38 -07001849 lvl_find_in_chain<VkPhysicalDeviceLineRasterizationFeaturesEXT>(device_createinfo_pnext);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001850 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
1851 (!line_features || !line_features->rectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001852 skip |=
1853 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02768",
1854 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
1855 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT requires the rectangularLines feature.",
1856 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001857 }
1858 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
1859 (!line_features || !line_features->bresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001860 skip |=
1861 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02769",
1862 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
1863 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT requires the bresenhamLines feature.",
1864 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001865 }
1866 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
1867 (!line_features || !line_features->smoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001868 skip |=
1869 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-lineRasterizationMode-02770",
1870 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
1871 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT requires the smoothLines feature.",
1872 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001873 }
1874 if (line_state->stippledLineEnable) {
1875 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT &&
1876 (!line_features || !line_features->stippledRectangularLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001877 skip |=
1878 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02771",
1879 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
1880 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT with stipple requires the "
1881 "stippledRectangularLines feature.",
1882 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001883 }
1884 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT &&
1885 (!line_features || !line_features->stippledBresenhamLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001886 skip |=
1887 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02772",
1888 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
1889 "VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT with stipple requires the "
1890 "stippledBresenhamLines feature.",
1891 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001892 }
1893 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT &&
1894 (!line_features || !line_features->stippledSmoothLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001895 skip |=
1896 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02773",
1897 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
1898 "VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT with stipple requires the "
1899 "stippledSmoothLines feature.",
1900 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001901 }
1902 if (line_state->lineRasterizationMode == VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT &&
1903 (!line_features || !line_features->stippledSmoothLines || !device_limits.strictLines)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07001904 skip |=
1905 LogError(device, "VUID-VkPipelineRasterizationLineStateCreateInfoEXT-stippledLineEnable-02774",
1906 "vkCreateGraphicsPipelines(): pCreateInfos[%d] lineRasterizationMode = "
1907 "VK_LINE_RASTERIZATION_MODE_DEFAULT_EXT with stipple requires the "
1908 "stippledRectangularLines and strictLines features.",
1909 i);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05001910 }
1911 }
1912 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001913 }
1914
Petr Krause91f7a12017-12-14 20:57:36 +01001915 bool uses_color_attachment = false;
1916 bool uses_depthstencil_attachment = false;
1917 {
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07001918 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001919 const auto subpasses_uses_it = renderpasses_states.find(pCreateInfos[i].renderPass);
1920 if (subpasses_uses_it != renderpasses_states.end()) {
Petr Krause91f7a12017-12-14 20:57:36 +01001921 const auto &subpasses_uses = subpasses_uses_it->second;
1922 if (subpasses_uses.subpasses_using_color_attachment.count(pCreateInfos[i].subpass))
1923 uses_color_attachment = true;
1924 if (subpasses_uses.subpasses_using_depthstencil_attachment.count(pCreateInfos[i].subpass))
1925 uses_depthstencil_attachment = true;
1926 }
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07001927 lock.unlock();
Petr Krause91f7a12017-12-14 20:57:36 +01001928 }
1929
1930 if (pCreateInfos[i].pDepthStencilState != nullptr && uses_depthstencil_attachment) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001931 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001932 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001933 ParameterName("pCreateInfos[%i].pDepthStencilState->pNext", ParameterName::IndexVector{i}), NULL,
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001934 pCreateInfos[i].pDepthStencilState->pNext, 0, NULL, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08001935 "VUID-VkPipelineDepthStencilStateCreateInfo-pNext-pNext", nullptr);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001936
1937 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001938 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001939 ParameterName("pCreateInfos[%i].pDepthStencilState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06001940 pCreateInfos[i].pDepthStencilState->flags, "VUID-VkPipelineDepthStencilStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001941
1942 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001943 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001944 ParameterName("pCreateInfos[%i].pDepthStencilState->depthTestEnable", ParameterName::IndexVector{i}),
1945 pCreateInfos[i].pDepthStencilState->depthTestEnable);
1946
1947 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001948 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001949 ParameterName("pCreateInfos[%i].pDepthStencilState->depthWriteEnable", ParameterName::IndexVector{i}),
1950 pCreateInfos[i].pDepthStencilState->depthWriteEnable);
1951
1952 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001953 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001954 ParameterName("pCreateInfos[%i].pDepthStencilState->depthCompareOp", ParameterName::IndexVector{i}),
1955 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->depthCompareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001956 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001957
1958 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001959 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001960 ParameterName("pCreateInfos[%i].pDepthStencilState->depthBoundsTestEnable", ParameterName::IndexVector{i}),
1961 pCreateInfos[i].pDepthStencilState->depthBoundsTestEnable);
1962
1963 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001964 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001965 ParameterName("pCreateInfos[%i].pDepthStencilState->stencilTestEnable", ParameterName::IndexVector{i}),
1966 pCreateInfos[i].pDepthStencilState->stencilTestEnable);
1967
1968 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001969 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001970 ParameterName("pCreateInfos[%i].pDepthStencilState->front.failOp", ParameterName::IndexVector{i}),
1971 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001972 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001973
1974 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001975 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001976 ParameterName("pCreateInfos[%i].pDepthStencilState->front.passOp", ParameterName::IndexVector{i}),
1977 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001978 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001979
1980 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001981 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001982 ParameterName("pCreateInfos[%i].pDepthStencilState->front.depthFailOp", ParameterName::IndexVector{i}),
1983 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->front.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001984 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001985
1986 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001987 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001988 ParameterName("pCreateInfos[%i].pDepthStencilState->front.compareOp", ParameterName::IndexVector{i}),
1989 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->front.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001990 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001991
1992 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001993 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001994 ParameterName("pCreateInfos[%i].pDepthStencilState->back.failOp", ParameterName::IndexVector{i}),
1995 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.failOp,
Dave Houlton413a6782018-05-22 13:01:54 -06001996 "VUID-VkStencilOpState-failOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06001997
1998 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07001999 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002000 ParameterName("pCreateInfos[%i].pDepthStencilState->back.passOp", ParameterName::IndexVector{i}),
2001 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.passOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002002 "VUID-VkStencilOpState-passOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002003
2004 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002005 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002006 ParameterName("pCreateInfos[%i].pDepthStencilState->back.depthFailOp", ParameterName::IndexVector{i}),
2007 "VkStencilOp", AllVkStencilOpEnums, pCreateInfos[i].pDepthStencilState->back.depthFailOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002008 "VUID-VkStencilOpState-depthFailOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002009
2010 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002011 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002012 ParameterName("pCreateInfos[%i].pDepthStencilState->back.compareOp", ParameterName::IndexVector{i}),
2013 "VkCompareOp", AllVkCompareOpEnums, pCreateInfos[i].pDepthStencilState->back.compareOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002014 "VUID-VkPipelineDepthStencilStateCreateInfo-depthCompareOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002015
2016 if (pCreateInfos[i].pDepthStencilState->sType != VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002017 skip |= LogError(device, kVUID_PVError_InvalidStructSType,
2018 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pDepthStencilState->sType must be "
2019 "VK_STRUCTURE_TYPE_PIPELINE_DEPTH_STENCIL_STATE_CREATE_INFO",
2020 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002021 }
2022 }
2023
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002024 const VkStructureType allowed_structs_VkPipelineColorBlendStateCreateInfo[] = {
2025 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_ADVANCED_STATE_CREATE_INFO_EXT};
2026
Petr Krause91f7a12017-12-14 20:57:36 +01002027 if (pCreateInfos[i].pColorBlendState != nullptr && uses_color_attachment) {
Mark Lobodzinski876d5b52019-08-06 16:32:27 -06002028 skip |= validate_struct_type("vkCreateGraphicsPipelines",
2029 ParameterName("pCreateInfos[%i].pColorBlendState", ParameterName::IndexVector{i}),
2030 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2031 pCreateInfos[i].pColorBlendState,
2032 VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO, false, kVUIDUndefined,
2033 "VUID-VkPipelineColorBlendStateCreateInfo-sType-sType");
2034
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002035 skip |= validate_struct_pnext(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002036 "vkCreateGraphicsPipelines",
Shannon McPherson9b9532b2018-10-24 12:00:09 -06002037 ParameterName("pCreateInfos[%i].pColorBlendState->pNext", ParameterName::IndexVector{i}),
2038 "VkPipelineColorBlendAdvancedStateCreateInfoEXT", pCreateInfos[i].pColorBlendState->pNext,
2039 ARRAY_SIZE(allowed_structs_VkPipelineColorBlendStateCreateInfo),
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002040 allowed_structs_VkPipelineColorBlendStateCreateInfo, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08002041 "VUID-VkPipelineColorBlendStateCreateInfo-pNext-pNext",
2042 "VUID-VkPipelineColorBlendStateCreateInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002043
2044 skip |= validate_reserved_flags(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002045 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002046 ParameterName("pCreateInfos[%i].pColorBlendState->flags", ParameterName::IndexVector{i}),
Dave Houlton413a6782018-05-22 13:01:54 -06002047 pCreateInfos[i].pColorBlendState->flags, "VUID-VkPipelineColorBlendStateCreateInfo-flags-zerobitmask");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002048
2049 skip |= validate_bool32(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002050 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002051 ParameterName("pCreateInfos[%i].pColorBlendState->logicOpEnable", ParameterName::IndexVector{i}),
2052 pCreateInfos[i].pColorBlendState->logicOpEnable);
2053
2054 skip |= validate_array(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002055 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002056 ParameterName("pCreateInfos[%i].pColorBlendState->attachmentCount", ParameterName::IndexVector{i}),
2057 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments", ParameterName::IndexVector{i}),
Gabríel Arthúr Pétursson092b29b2018-03-21 22:44:11 +00002058 pCreateInfos[i].pColorBlendState->attachmentCount, &pCreateInfos[i].pColorBlendState->pAttachments, false,
Dave Houlton413a6782018-05-22 13:01:54 -06002059 true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002060
2061 if (pCreateInfos[i].pColorBlendState->pAttachments != NULL) {
2062 for (uint32_t attachmentIndex = 0; attachmentIndex < pCreateInfos[i].pColorBlendState->attachmentCount;
2063 ++attachmentIndex) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002064 skip |= validate_bool32("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002065 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].blendEnable",
2066 ParameterName::IndexVector{i, attachmentIndex}),
2067 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].blendEnable);
2068
2069 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002070 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002071 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcColorBlendFactor",
2072 ParameterName::IndexVector{i, attachmentIndex}),
2073 "VkBlendFactor", AllVkBlendFactorEnums,
2074 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002075 "VUID-VkPipelineColorBlendAttachmentState-srcColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002076
2077 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002078 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002079 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstColorBlendFactor",
2080 ParameterName::IndexVector{i, attachmentIndex}),
2081 "VkBlendFactor", AllVkBlendFactorEnums,
2082 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstColorBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002083 "VUID-VkPipelineColorBlendAttachmentState-dstColorBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002084
2085 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002086 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002087 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorBlendOp",
2088 ParameterName::IndexVector{i, attachmentIndex}),
2089 "VkBlendOp", AllVkBlendOpEnums,
2090 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002091 "VUID-VkPipelineColorBlendAttachmentState-colorBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002092
2093 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002094 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002095 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].srcAlphaBlendFactor",
2096 ParameterName::IndexVector{i, attachmentIndex}),
2097 "VkBlendFactor", AllVkBlendFactorEnums,
2098 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].srcAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002099 "VUID-VkPipelineColorBlendAttachmentState-srcAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002100
2101 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002102 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002103 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].dstAlphaBlendFactor",
2104 ParameterName::IndexVector{i, attachmentIndex}),
2105 "VkBlendFactor", AllVkBlendFactorEnums,
2106 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].dstAlphaBlendFactor,
Dave Houlton413a6782018-05-22 13:01:54 -06002107 "VUID-VkPipelineColorBlendAttachmentState-dstAlphaBlendFactor-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002108
2109 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002110 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002111 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].alphaBlendOp",
2112 ParameterName::IndexVector{i, attachmentIndex}),
2113 "VkBlendOp", AllVkBlendOpEnums,
2114 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].alphaBlendOp,
Dave Houlton413a6782018-05-22 13:01:54 -06002115 "VUID-VkPipelineColorBlendAttachmentState-alphaBlendOp-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002116
2117 skip |=
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002118 validate_flags("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002119 ParameterName("pCreateInfos[%i].pColorBlendState->pAttachments[%i].colorWriteMask",
2120 ParameterName::IndexVector{i, attachmentIndex}),
2121 "VkColorComponentFlagBits", AllVkColorComponentFlagBits,
2122 pCreateInfos[i].pColorBlendState->pAttachments[attachmentIndex].colorWriteMask,
Petr Kraus52758be2019-08-12 00:53:58 +02002123 kOptionalFlags, "VUID-VkPipelineColorBlendAttachmentState-colorWriteMask-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002124 }
2125 }
2126
2127 if (pCreateInfos[i].pColorBlendState->sType != VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002128 skip |= LogError(device, kVUID_PVError_InvalidStructSType,
2129 "vkCreateGraphicsPipelines: parameter pCreateInfos[%d].pColorBlendState->sType must be "
2130 "VK_STRUCTURE_TYPE_PIPELINE_COLOR_BLEND_STATE_CREATE_INFO",
2131 i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002132 }
2133
2134 // If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value
2135 if (pCreateInfos[i].pColorBlendState->logicOpEnable == VK_TRUE) {
2136 skip |= validate_ranged_enum(
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002137 "vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002138 ParameterName("pCreateInfos[%i].pColorBlendState->logicOp", ParameterName::IndexVector{i}), "VkLogicOp",
Dave Houlton413a6782018-05-22 13:01:54 -06002139 AllVkLogicOpEnums, pCreateInfos[i].pColorBlendState->logicOp,
2140 "VUID-VkPipelineColorBlendStateCreateInfo-logicOpEnable-00607");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002141 }
2142 }
2143 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002144
Petr Kraus9752aae2017-11-24 03:05:50 +01002145 if (pCreateInfos[i].flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) {
2146 if (pCreateInfos[i].basePipelineIndex != -1) {
2147 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002148 skip |=
2149 LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00724",
2150 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineHandle, must be "
2151 "VK_NULL_HANDLE if pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag "
2152 "and pCreateInfos->basePipelineIndex is not -1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002153 }
2154 }
2155
Petr Kraus9752aae2017-11-24 03:05:50 +01002156 if (pCreateInfos[i].basePipelineHandle != VK_NULL_HANDLE) {
2157 if (pCreateInfos[i].basePipelineIndex != -1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002158 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00725",
2159 "vkCreateGraphicsPipelines parameter, pCreateInfos->basePipelineIndex, must be -1 if "
2160 "pCreateInfos->flags contains the VK_PIPELINE_CREATE_DERIVATIVE_BIT flag and "
2161 "pCreateInfos->basePipelineHandle is not VK_NULL_HANDLE.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002162 }
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06002163 } else {
2164 if (static_cast<const uint32_t>(pCreateInfos[i].basePipelineIndex) >= createInfoCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002165 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-flags-00723",
2166 "vkCreateGraphicsPipelines parameter pCreateInfos->basePipelineIndex (%d) must be a valid"
2167 "index into the pCreateInfos array, of size %d.",
2168 pCreateInfos[i].basePipelineIndex, createInfoCount);
Mark Lobodzinski4dfeb942019-09-13 12:11:13 -06002169 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002170 }
2171 }
2172
Petr Kraus9752aae2017-11-24 03:05:50 +01002173 if (pCreateInfos[i].pRasterizationState) {
Chris Mayer840b2c42019-08-22 18:12:22 +02002174 if (!device_extensions.vk_nv_fill_rectangle) {
2175 if (pCreateInfos[i].pRasterizationState->polygonMode == VK_POLYGON_MODE_FILL_RECTANGLE_NV) {
2176 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002177 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01414",
2178 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2179 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_FILL_RECTANGLE_NV "
2180 "if the extension VK_NV_fill_rectangle is not enabled.");
Chris Mayer840b2c42019-08-22 18:12:22 +02002181 } else if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
2182 (physical_device_features.fillModeNonSolid == false)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002183 skip |= LogError(device, kVUID_PVError_DeviceFeature,
2184 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2185 "pCreateInfos->pRasterizationState->polygonMode cannot be VK_POLYGON_MODE_POINT or "
2186 "VK_POLYGON_MODE_LINE if VkPhysicalDeviceFeatures->fillModeNonSolid is false.");
Chris Mayer840b2c42019-08-22 18:12:22 +02002187 }
2188 } else {
2189 if ((pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL) &&
2190 (pCreateInfos[i].pRasterizationState->polygonMode != VK_POLYGON_MODE_FILL_RECTANGLE_NV) &&
2191 (physical_device_features.fillModeNonSolid == false)) {
2192 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002193 LogError(device, "VUID-VkPipelineRasterizationStateCreateInfo-polygonMode-01507",
2194 "vkCreateGraphicsPipelines parameter, VkPolygonMode "
2195 "pCreateInfos->pRasterizationState->polygonMode must be VK_POLYGON_MODE_FILL or "
2196 "VK_POLYGON_MODE_FILL_RECTANGLE_NV if VkPhysicalDeviceFeatures->fillModeNonSolid is false.");
Chris Mayer840b2c42019-08-22 18:12:22 +02002197 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002198 }
Petr Kraus299ba622017-11-24 03:09:03 +01002199
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002200 if (!has_dynamic_line_width && !physical_device_features.wideLines &&
Petr Kraus299ba622017-11-24 03:09:03 +01002201 (pCreateInfos[i].pRasterizationState->lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002202 skip |= LogError(device, "VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-00749",
2203 "The line width state is static (pCreateInfos[%" PRIu32
2204 "].pDynamicState->pDynamicStates does not contain VK_DYNAMIC_STATE_LINE_WIDTH) and "
2205 "VkPhysicalDeviceFeatures::wideLines is disabled, but pCreateInfos[%" PRIu32
2206 "].pRasterizationState->lineWidth (=%f) is not 1.0.",
2207 i, i, pCreateInfos[i].pRasterizationState->lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002208 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002209 }
2210
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002211 for (size_t j = 0; j < pCreateInfos[i].stageCount; j++) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002212 skip |= validate_string("vkCreateGraphicsPipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002213 ParameterName("pCreateInfos[%i].pStages[%i].pName", ParameterName::IndexVector{i, j}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002214 "VUID-VkGraphicsPipelineCreateInfo-pStages-parameter", pCreateInfos[i].pStages[j].pName);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002215 }
2216 }
2217 }
2218
2219 return skip;
2220}
2221
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002222bool StatelessValidation::manual_PreCallValidateCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache,
2223 uint32_t createInfoCount,
2224 const VkComputePipelineCreateInfo *pCreateInfos,
2225 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002226 VkPipeline *pPipelines) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002227 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002228 for (uint32_t i = 0; i < createInfoCount; i++) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002229 skip |= validate_string("vkCreateComputePipelines",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002230 ParameterName("pCreateInfos[%i].stage.pName", ParameterName::IndexVector{i}),
Mark Lobodzinskiebee3552018-05-29 09:55:54 -06002231 "VUID-VkPipelineShaderStageCreateInfo-pName-parameter", pCreateInfos[i].stage.pName);
Peter Chen85366392019-05-14 15:20:11 -04002232 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
2233 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != 1)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002234 skip |=
2235 LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02669",
2236 "vkCreateComputePipelines(): in pCreateInfo[%" PRIu32
2237 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount must equal 1, found %" PRIu32 ".",
2238 i, feedback_struct->pipelineStageCreationFeedbackCount);
Peter Chen85366392019-05-14 15:20:11 -04002239 }
sfricke-samsungc5227152020-02-09 17:36:31 -08002240
2241 // Make sure compute stage is selected
2242 if (pCreateInfos[i].stage.stage != VK_SHADER_STAGE_COMPUTE_BIT) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002243 skip |= LogError(device, "VUID-VkComputePipelineCreateInfo-stage-00701",
2244 "vkCreateComputePipelines(): the pCreateInfo[%u].stage.stage (%s) is not VK_SHADER_STAGE_COMPUTE_BIT",
2245 i, string_VkShaderStageFlagBits(pCreateInfos[i].stage.stage));
sfricke-samsungc5227152020-02-09 17:36:31 -08002246 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002247 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002248 return skip;
2249}
2250
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002251bool StatelessValidation::manual_PreCallValidateCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002252 const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002253 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002254
2255 if (pCreateInfo != nullptr) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002256 const auto &features = physical_device_features;
2257 const auto &limits = device_limits;
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002258
John Zulauf71968502017-10-26 13:51:15 -06002259 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
2260 if (!in_inclusive_range(pCreateInfo->maxAnisotropy, 1.0F, limits.maxSamplerAnisotropy)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002261 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01071",
2262 "vkCreateSampler(): value of %s must be in range [1.0, %f] %s, but %f found.",
2263 "pCreateInfo->maxAnisotropy", limits.maxSamplerAnisotropy,
2264 "VkPhysicalDeviceLimits::maxSamplerAnistropy", pCreateInfo->maxAnisotropy);
John Zulauf71968502017-10-26 13:51:15 -06002265 }
2266
2267 // Anistropy cannot be enabled in sampler unless enabled as a feature
2268 if (features.samplerAnisotropy == VK_FALSE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002269 skip |= LogError(device, "VUID-VkSamplerCreateInfo-anisotropyEnable-01070",
2270 "vkCreateSampler(): Anisotropic sampling feature is not enabled, %s must be VK_FALSE.",
2271 "pCreateInfo->anisotropyEnable");
John Zulauf71968502017-10-26 13:51:15 -06002272 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002273 }
John Zulauf71968502017-10-26 13:51:15 -06002274
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002275 if (pCreateInfo->unnormalizedCoordinates == VK_TRUE) {
2276 if (pCreateInfo->minFilter != pCreateInfo->magFilter) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002277 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01072",
2278 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2279 "pCreateInfo->minFilter (%s) and pCreateInfo->magFilter (%s) must be equal.",
2280 string_VkFilter(pCreateInfo->minFilter), string_VkFilter(pCreateInfo->magFilter));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002281 }
2282 if (pCreateInfo->mipmapMode != VK_SAMPLER_MIPMAP_MODE_NEAREST) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002283 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01073",
2284 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2285 "pCreateInfo->mipmapMode (%s) must be VK_SAMPLER_MIPMAP_MODE_NEAREST.",
2286 string_VkSamplerMipmapMode(pCreateInfo->mipmapMode));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002287 }
2288 if (pCreateInfo->minLod != 0.0f || pCreateInfo->maxLod != 0.0f) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002289 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01074",
2290 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2291 "pCreateInfo->minLod (%f) and pCreateInfo->maxLod (%f) must both be zero.",
2292 pCreateInfo->minLod, pCreateInfo->maxLod);
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002293 }
2294 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2295 pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2296 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE &&
2297 pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002298 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01075",
2299 "vkCreateSampler(): when pCreateInfo->unnormalizedCoordinates is VK_TRUE, "
2300 "pCreateInfo->addressModeU (%s) and pCreateInfo->addressModeV (%s) must both be "
2301 "VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER.",
2302 string_VkSamplerAddressMode(pCreateInfo->addressModeU),
2303 string_VkSamplerAddressMode(pCreateInfo->addressModeV));
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002304 }
2305 if (pCreateInfo->anisotropyEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002306 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01076",
2307 "vkCreateSampler(): pCreateInfo->anisotropyEnable and pCreateInfo->unnormalizedCoordinates must "
2308 "not both be VK_TRUE.");
John Zulauf71968502017-10-26 13:51:15 -06002309 }
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002310 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002311 skip |= LogError(device, "VUID-VkSamplerCreateInfo-unnormalizedCoordinates-01077",
2312 "vkCreateSampler(): pCreateInfo->compareEnable and pCreateInfo->unnormalizedCoordinates must "
2313 "not both be VK_TRUE.");
Jesse Hallcc1fbef2018-06-03 15:58:56 -07002314 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002315 }
2316
2317 // If compareEnable is VK_TRUE, compareOp must be a valid VkCompareOp value
2318 if (pCreateInfo->compareEnable == VK_TRUE) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002319 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->compareOp", "VkCompareOp", AllVkCompareOpEnums,
2320 pCreateInfo->compareOp, "VUID-VkSamplerCreateInfo-compareEnable-01080");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002321 }
2322
2323 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER, borderColor must be a
2324 // valid VkBorderColor value
2325 if ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2326 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER) ||
2327 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER)) {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002328 skip |= validate_ranged_enum("vkCreateSampler", "pCreateInfo->borderColor", "VkBorderColor", AllVkBorderColorEnums,
2329 pCreateInfo->borderColor, "VUID-VkSamplerCreateInfo-addressModeU-01078");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002330 }
2331
2332 // If any of addressModeU, addressModeV or addressModeW are VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE, the
2333 // VK_KHR_sampler_mirror_clamp_to_edge extension must be enabled
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002334 if (!device_extensions.vk_khr_sampler_mirror_clamp_to_edge &&
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002335 ((pCreateInfo->addressModeU == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2336 (pCreateInfo->addressModeV == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE) ||
2337 (pCreateInfo->addressModeW == VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE))) {
Dave Houlton413a6782018-05-22 13:01:54 -06002338 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002339 LogError(device, "VUID-VkSamplerCreateInfo-addressModeU-01079",
2340 "vkCreateSampler(): A VkSamplerAddressMode value is set to VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE "
2341 "but the VK_KHR_sampler_mirror_clamp_to_edge extension has not been enabled.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002342 }
John Zulauf275805c2017-10-26 15:34:49 -06002343
2344 // Checks for the IMG cubic filtering extension
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002345 if (device_extensions.vk_img_filter_cubic) {
John Zulauf275805c2017-10-26 15:34:49 -06002346 if ((pCreateInfo->anisotropyEnable == VK_TRUE) &&
2347 ((pCreateInfo->minFilter == VK_FILTER_CUBIC_IMG) || (pCreateInfo->magFilter == VK_FILTER_CUBIC_IMG))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002348 skip |= LogError(device, "VUID-VkSamplerCreateInfo-magFilter-01081",
2349 "vkCreateSampler(): Anisotropic sampling must not be VK_TRUE when either minFilter or magFilter "
2350 "are VK_FILTER_CUBIC_IMG.");
John Zulauf275805c2017-10-26 15:34:49 -06002351 }
2352 }
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07002353
sfricke-samsungd91da4a2020-02-09 17:19:04 -08002354 // Check for valid Lod range
2355 if (pCreateInfo->minLod > pCreateInfo->maxLod) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07002356 skip |=
2357 LogError(device, "VUID-VkSamplerCreateInfo-maxLod-01973",
2358 "vkCreateSampler(): minLod (%f) is greater than maxLod (%f)", pCreateInfo->minLod, pCreateInfo->maxLod);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08002359 }
2360
2361 // Check mipLodBias to device limit
2362 if (pCreateInfo->mipLodBias > limits.maxSamplerLodBias) {
Mark Lobodzinski728ab482020-02-12 13:46:47 -07002363 skip |= LogError(device, "VUID-VkSamplerCreateInfo-mipLodBias-01069",
2364 "vkCreateSampler(): mipLodBias (%f) is greater than VkPhysicalDeviceLimits::maxSamplerLodBias (%f)",
2365 pCreateInfo->mipLodBias, limits.maxSamplerLodBias);
sfricke-samsungd91da4a2020-02-09 17:19:04 -08002366 }
2367
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07002368 const auto *sampler_conversion = lvl_find_in_chain<VkSamplerYcbcrConversionInfo>(pCreateInfo->pNext);
2369 if (sampler_conversion != nullptr) {
2370 if ((pCreateInfo->addressModeU != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
2371 (pCreateInfo->addressModeV != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
2372 (pCreateInfo->addressModeW != VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE) ||
2373 (pCreateInfo->anisotropyEnable != VK_FALSE) || (pCreateInfo->unnormalizedCoordinates != VK_FALSE)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002374 skip |= LogError(
Mark Lobodzinski728ab482020-02-12 13:46:47 -07002375 device, "VUID-VkSamplerCreateInfo-addressModeU-01646",
Mark Lobodzinski61992fc2020-01-14 14:00:08 -07002376 "vkCreateSampler(): SamplerYCbCrConversion is enabled: "
2377 "addressModeU (%s), addressModeV (%s), addressModeW (%s) must be CLAMP_TO_EDGE, and anisotropyEnable (%s) "
2378 "and unnormalizedCoordinates (%s) must be VK_FALSE.",
2379 string_VkSamplerAddressMode(pCreateInfo->addressModeU), string_VkSamplerAddressMode(pCreateInfo->addressModeV),
2380 string_VkSamplerAddressMode(pCreateInfo->addressModeW), pCreateInfo->anisotropyEnable ? "VK_TRUE" : "VK_FALSE",
2381 pCreateInfo->unnormalizedCoordinates ? "VK_TRUE" : "VK_FALSE");
2382 }
2383 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002384 }
2385
2386 return skip;
2387}
2388
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002389bool StatelessValidation::manual_PreCallValidateCreateDescriptorSetLayout(VkDevice device,
2390 const VkDescriptorSetLayoutCreateInfo *pCreateInfo,
2391 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002392 VkDescriptorSetLayout *pSetLayout) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002393 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002394
2395 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2396 if ((pCreateInfo != nullptr) && (pCreateInfo->pBindings != nullptr)) {
2397 for (uint32_t i = 0; i < pCreateInfo->bindingCount; ++i) {
2398 if (pCreateInfo->pBindings[i].descriptorCount != 0) {
2399 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER or VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, and descriptorCount
2400 // is not 0 and pImmutableSamplers is not NULL, pImmutableSamplers must be a pointer to an array of descriptorCount
2401 // valid VkSampler handles
2402 if (((pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2403 (pCreateInfo->pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER)) &&
2404 (pCreateInfo->pBindings[i].pImmutableSamplers != nullptr)) {
2405 for (uint32_t descriptor_index = 0; descriptor_index < pCreateInfo->pBindings[i].descriptorCount;
2406 ++descriptor_index) {
2407 if (pCreateInfo->pBindings[i].pImmutableSamplers[descriptor_index] == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002408 skip |= LogError(device, kVUID_PVError_RequiredParameter,
2409 "vkCreateDescriptorSetLayout: required parameter "
2410 "pCreateInfo->pBindings[%d].pImmutableSamplers[%d] specified as VK_NULL_HANDLE",
2411 i, descriptor_index);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002412 }
2413 }
2414 }
2415
2416 // If descriptorCount is not 0, stageFlags must be a valid combination of VkShaderStageFlagBits values
2417 if ((pCreateInfo->pBindings[i].stageFlags != 0) &&
2418 ((pCreateInfo->pBindings[i].stageFlags & (~AllVkShaderStageFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002419 skip |= LogError(device, "VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283",
2420 "vkCreateDescriptorSetLayout(): if pCreateInfo->pBindings[%d].descriptorCount is not 0, "
2421 "pCreateInfo->pBindings[%d].stageFlags must be a valid combination of VkShaderStageFlagBits "
2422 "values.",
2423 i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002424 }
2425 }
2426 }
2427 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002428 return skip;
2429}
2430
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002431bool StatelessValidation::manual_PreCallValidateFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool,
2432 uint32_t descriptorSetCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002433 const VkDescriptorSet *pDescriptorSets) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002434 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2435 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2436 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002437 return validate_array("vkFreeDescriptorSets", "descriptorSetCount", "pDescriptorSets", descriptorSetCount, &pDescriptorSets,
2438 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002439}
2440
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002441bool StatelessValidation::validate_WriteDescriptorSet(const char *vkCallingFunction, const uint32_t descriptorWriteCount,
2442 const VkWriteDescriptorSet *pDescriptorWrites,
2443 const bool validateDstSet) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002444 bool skip = false;
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002445
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002446 if (pDescriptorWrites != NULL) {
2447 for (uint32_t i = 0; i < descriptorWriteCount; ++i) {
2448 // descriptorCount must be greater than 0
2449 if (pDescriptorWrites[i].descriptorCount == 0) {
2450 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002451 LogError(device, "VUID-VkWriteDescriptorSet-descriptorCount-arraylength",
2452 "%s(): parameter pDescriptorWrites[%d].descriptorCount must be greater than 0.", vkCallingFunction, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002453 }
2454
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002455 // If called from vkCmdPushDescriptorSetKHR, the dstSet member is ignored.
2456 if (validateDstSet) {
2457 // dstSet must be a valid VkDescriptorSet handle
2458 skip |= validate_required_handle(vkCallingFunction,
2459 ParameterName("pDescriptorWrites[%i].dstSet", ParameterName::IndexVector{i}),
2460 pDescriptorWrites[i].dstSet);
2461 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002462
2463 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) ||
2464 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER) ||
2465 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE) ||
2466 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) ||
2467 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)) {
2468 // If descriptorType is VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
2469 // VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT,
2470 // pImageInfo must be a pointer to an array of descriptorCount valid VkDescriptorImageInfo structures
2471 if (pDescriptorWrites[i].pImageInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002472 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00322",
2473 "%s(): if pDescriptorWrites[%d].descriptorType is "
2474 "VK_DESCRIPTOR_TYPE_SAMPLER, VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, "
2475 "VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or "
2476 "VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, pDescriptorWrites[%d].pImageInfo must not be NULL.",
2477 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002478 } else if (pDescriptorWrites[i].descriptorType != VK_DESCRIPTOR_TYPE_SAMPLER) {
2479 // If descriptorType is VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER, VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE,
2480 // VK_DESCRIPTOR_TYPE_STORAGE_IMAGE or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, the imageView and imageLayout
2481 // members of any given element of pImageInfo must be a valid VkImageView and VkImageLayout, respectively
2482 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2483 ++descriptor_index) {
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002484 skip |= validate_required_handle(vkCallingFunction,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002485 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageView",
2486 ParameterName::IndexVector{i, descriptor_index}),
2487 pDescriptorWrites[i].pImageInfo[descriptor_index].imageView);
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002488 skip |= validate_ranged_enum(vkCallingFunction,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002489 ParameterName("pDescriptorWrites[%i].pImageInfo[%i].imageLayout",
2490 ParameterName::IndexVector{i, descriptor_index}),
2491 "VkImageLayout", AllVkImageLayoutEnums,
Dave Houlton413a6782018-05-22 13:01:54 -06002492 pDescriptorWrites[i].pImageInfo[descriptor_index].imageLayout, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002493 }
2494 }
2495 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2496 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2497 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
2498 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
2499 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
2500 // VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, pBufferInfo must be a
2501 // pointer to an array of descriptorCount valid VkDescriptorBufferInfo structures
2502 if (pDescriptorWrites[i].pBufferInfo == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002503 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00324",
2504 "%s(): if pDescriptorWrites[%d].descriptorType is "
2505 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, "
2506 "VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, "
2507 "pDescriptorWrites[%d].pBufferInfo must not be NULL.",
2508 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002509 } else {
2510 for (uint32_t descriptorIndex = 0; descriptorIndex < pDescriptorWrites[i].descriptorCount; ++descriptorIndex) {
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002511 skip |= validate_required_handle(vkCallingFunction,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002512 ParameterName("pDescriptorWrites[%i].pBufferInfo[%i].buffer",
2513 ParameterName::IndexVector{i, descriptorIndex}),
2514 pDescriptorWrites[i].pBufferInfo[descriptorIndex].buffer);
2515 }
2516 }
2517 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) ||
2518 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)) {
2519 // If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER,
2520 // pTexelBufferView must be a pointer to an array of descriptorCount valid VkBufferView handles
2521 if (pDescriptorWrites[i].pTexelBufferView == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002522 skip |= LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00323",
2523 "%s(): if pDescriptorWrites[%d].descriptorType is "
2524 "VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER, "
2525 "pDescriptorWrites[%d].pTexelBufferView must not be NULL.",
2526 vkCallingFunction, i, i);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002527 } else {
2528 for (uint32_t descriptor_index = 0; descriptor_index < pDescriptorWrites[i].descriptorCount;
2529 ++descriptor_index) {
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002530 skip |= validate_required_handle(vkCallingFunction,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002531 ParameterName("pDescriptorWrites[%i].pTexelBufferView[%i]",
2532 ParameterName::IndexVector{i, descriptor_index}),
2533 pDescriptorWrites[i].pTexelBufferView[descriptor_index]);
2534 }
2535 }
2536 }
2537
2538 if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) ||
2539 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002540 VkDeviceSize uniformAlignment = device_limits.minUniformBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002541 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2542 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2543 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002544 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002545 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00327",
2546 "%s(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2547 ") must be a multiple of device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2548 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, uniformAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002549 }
2550 }
2551 }
2552 } else if ((pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) ||
2553 (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002554 VkDeviceSize storageAlignment = device_limits.minStorageBufferOffsetAlignment;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002555 for (uint32_t j = 0; j < pDescriptorWrites[i].descriptorCount; j++) {
2556 if (pDescriptorWrites[i].pBufferInfo != NULL) {
2557 if (SafeModulo(pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment) != 0) {
Mark Lobodzinski88529492018-04-01 10:38:15 -06002558 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002559 LogError(device, "VUID-VkWriteDescriptorSet-descriptorType-00328",
2560 "%s(): pDescriptorWrites[%d].pBufferInfo[%d].offset (0x%" PRIxLEAST64
2561 ") must be a multiple of device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ".",
2562 vkCallingFunction, i, j, pDescriptorWrites[i].pBufferInfo[j].offset, storageAlignment);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002563 }
2564 }
2565 }
2566 }
2567 }
2568 }
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002569
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002570 return skip;
2571}
2572
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07002573bool StatelessValidation::manual_PreCallValidateUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount,
2574 const VkWriteDescriptorSet *pDescriptorWrites,
2575 uint32_t descriptorCopyCount,
2576 const VkCopyDescriptorSet *pDescriptorCopies) const {
2577 return validate_WriteDescriptorSet("vkUpdateDescriptorSets", descriptorWriteCount, pDescriptorWrites);
2578}
2579
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002580bool StatelessValidation::manual_PreCallValidateCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002581 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002582 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002583 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_1);
2584}
2585
2586bool StatelessValidation::manual_PreCallValidateCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002587 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002588 VkRenderPass *pRenderPass) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002589 return CreateRenderPassGeneric(device, pCreateInfo, pAllocator, pRenderPass, RENDER_PASS_VERSION_2);
2590}
2591
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002592bool StatelessValidation::manual_PreCallValidateFreeCommandBuffers(VkDevice device, VkCommandPool commandPool,
2593 uint32_t commandBufferCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002594 const VkCommandBuffer *pCommandBuffers) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002595 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002596
2597 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
2598 // This is an array of handles, where the elements are allowed to be VK_NULL_HANDLE, and does not require any validation beyond
2599 // validate_array()
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002600 skip |= validate_array("vkFreeCommandBuffers", "commandBufferCount", "pCommandBuffers", commandBufferCount, &pCommandBuffers,
2601 true, true, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002602 return skip;
2603}
2604
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002605bool StatelessValidation::manual_PreCallValidateBeginCommandBuffer(VkCommandBuffer commandBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002606 const VkCommandBufferBeginInfo *pBeginInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002607 bool skip = false;
Petr Krause7bb9e82019-08-11 21:34:43 +02002608
2609 // VkCommandBufferInheritanceInfo validation, due to a 'noautovalidity' of pBeginInfo->pInheritanceInfo in vkBeginCommandBuffer
2610 const char *cmd_name = "vkBeginCommandBuffer";
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002611 const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo;
2612
Petr Krause7bb9e82019-08-11 21:34:43 +02002613 // Implicit VUs
2614 // validate only sType here; pointer has to be validated in core_validation
2615 const bool kNotRequired = false;
2616 const char *kNoVUID = nullptr;
2617 skip |= validate_struct_type(cmd_name, "pBeginInfo->pInheritanceInfo", "VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO",
2618 pInfo, VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO, kNotRequired, kNoVUID,
2619 "VUID-VkCommandBufferInheritanceInfo-sType-sType");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002620
Petr Krause7bb9e82019-08-11 21:34:43 +02002621 if (pInfo) {
2622 const VkStructureType allowed_structs_VkCommandBufferInheritanceInfo[] = {
2623 VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_CONDITIONAL_RENDERING_INFO_EXT};
2624 skip |= validate_struct_pnext(
2625 cmd_name, "pBeginInfo->pInheritanceInfo->pNext", "VkCommandBufferInheritanceConditionalRenderingInfoEXT", pInfo->pNext,
2626 ARRAY_SIZE(allowed_structs_VkCommandBufferInheritanceInfo), allowed_structs_VkCommandBufferInheritanceInfo,
sfricke-samsung32a27362020-02-28 09:06:42 -08002627 GeneratedVulkanHeaderVersion, "VUID-VkCommandBufferInheritanceInfo-pNext-pNext",
2628 "VUID-VkCommandBufferInheritanceInfo-sType-unique");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002629
Petr Krause7bb9e82019-08-11 21:34:43 +02002630 skip |= validate_bool32(cmd_name, "pBeginInfo->pInheritanceInfo->occlusionQueryEnable", pInfo->occlusionQueryEnable);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002631
Petr Krause7bb9e82019-08-11 21:34:43 +02002632 // Explicit VUs
2633 if (!physical_device_features.inheritedQueries && pInfo->occlusionQueryEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002634 skip |= LogError(
2635 commandBuffer, "VUID-VkCommandBufferInheritanceInfo-occlusionQueryEnable-00056",
Petr Krause7bb9e82019-08-11 21:34:43 +02002636 "%s: Inherited queries feature is disabled, but pBeginInfo->pInheritanceInfo->occlusionQueryEnable is VK_TRUE.",
2637 cmd_name);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002638 }
Petr Krause7bb9e82019-08-11 21:34:43 +02002639
2640 if (physical_device_features.inheritedQueries) {
2641 skip |= validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", "VkQueryControlFlagBits",
Petr Kraus52758be2019-08-12 00:53:58 +02002642 AllVkQueryControlFlagBits, pInfo->queryFlags, kOptionalFlags,
Dave Houlton413a6782018-05-22 13:01:54 -06002643 "VUID-VkCommandBufferInheritanceInfo-queryFlags-00057");
Petr Krause7bb9e82019-08-11 21:34:43 +02002644 } else { // !inheritedQueries
Petr Krause7bb9e82019-08-11 21:34:43 +02002645 skip |= validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->queryFlags", pInfo->queryFlags,
Petr Kraus43aed2c2019-08-18 13:59:16 +02002646 "VUID-VkCommandBufferInheritanceInfo-queryFlags-02788");
Petr Krause7bb9e82019-08-11 21:34:43 +02002647 }
2648
2649 if (physical_device_features.pipelineStatisticsQuery) {
Petr Krause7bb9e82019-08-11 21:34:43 +02002650 skip |= validate_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", "VkQueryPipelineStatisticFlagBits",
Petr Kraus52758be2019-08-12 00:53:58 +02002651 AllVkQueryPipelineStatisticFlagBits, pInfo->pipelineStatistics, kOptionalFlags,
Petr Kraus43aed2c2019-08-18 13:59:16 +02002652 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-02789");
Petr Krause7bb9e82019-08-11 21:34:43 +02002653 } else { // !pipelineStatisticsQuery
2654 skip |= validate_reserved_flags(cmd_name, "pBeginInfo->pInheritanceInfo->pipelineStatistics", pInfo->pipelineStatistics,
2655 "VUID-VkCommandBufferInheritanceInfo-pipelineStatistics-00058");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002656 }
Petr Kraus139757b2019-08-15 17:19:33 +02002657
2658 const auto *conditional_rendering = lvl_find_in_chain<VkCommandBufferInheritanceConditionalRenderingInfoEXT>(pInfo->pNext);
2659 if (conditional_rendering) {
Tony-LunarG6c3c5452019-12-13 10:37:38 -07002660 const auto *cr_features = lvl_find_in_chain<VkPhysicalDeviceConditionalRenderingFeaturesEXT>(device_createinfo_pnext);
Petr Kraus139757b2019-08-15 17:19:33 +02002661 const auto inherited_conditional_rendering = cr_features && cr_features->inheritedConditionalRendering;
2662 if (!inherited_conditional_rendering && conditional_rendering->conditionalRenderingEnable == VK_TRUE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002663 skip |= LogError(
2664 commandBuffer, "VUID-VkCommandBufferInheritanceConditionalRenderingInfoEXT-conditionalRenderingEnable-01977",
Petr Kraus139757b2019-08-15 17:19:33 +02002665 "vkBeginCommandBuffer: Inherited conditional rendering is disabled, but "
2666 "pBeginInfo->pInheritanceInfo->pNext<VkCommandBufferInheritanceConditionalRenderingInfoEXT> is VK_TRUE.");
2667 }
2668 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002669 }
2670
2671 return skip;
2672}
2673
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002674bool StatelessValidation::manual_PreCallValidateCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002675 uint32_t viewportCount, const VkViewport *pViewports) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002676 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002677
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002678 if (!physical_device_features.multiViewport) {
Petr Krausd55e77c2018-01-09 22:09:25 +01002679 if (firstViewport != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002680 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01224",
2681 "vkCmdSetViewport: The multiViewport feature is disabled, but firstViewport (=%" PRIu32 ") is not 0.",
2682 firstViewport);
Petr Krausd55e77c2018-01-09 22:09:25 +01002683 }
2684 if (viewportCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002685 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-viewportCount-01225",
2686 "vkCmdSetViewport: The multiViewport feature is disabled, but viewportCount (=%" PRIu32 ") is not 1.",
2687 viewportCount);
Petr Krausd55e77c2018-01-09 22:09:25 +01002688 }
2689 } else { // multiViewport enabled
Petr Kraus7dfeed12018-02-27 20:51:20 +01002690 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002691 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002692 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewport-firstViewport-01223",
2693 "vkCmdSetViewport: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
2694 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2695 firstViewport, viewportCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002696 }
2697 }
Petr Krausb3fcdb42018-01-09 22:09:09 +01002698
2699 if (pViewports) {
2700 for (uint32_t viewport_i = 0; viewport_i < viewportCount; ++viewport_i) {
2701 const auto &viewport = pViewports[viewport_i]; // will crash on invalid ptr
Jeff Bolz6d3beaa2019-02-09 21:00:05 -06002702 const char *fn_name = "vkCmdSetViewport";
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002703 skip |= manual_PreCallValidateViewport(
2704 viewport, fn_name, ParameterName("pViewports[%i]", ParameterName::IndexVector{viewport_i}), commandBuffer);
Petr Krausb3fcdb42018-01-09 22:09:09 +01002705 }
2706 }
2707
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002708 return skip;
2709}
2710
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002711bool StatelessValidation::manual_PreCallValidateCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002712 uint32_t scissorCount, const VkRect2D *pScissors) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002713 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002714
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002715 if (!physical_device_features.multiViewport) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002716 if (firstScissor != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002717 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00593",
2718 "vkCmdSetScissor: The multiViewport feature is disabled, but firstScissor (=%" PRIu32 ") is not 0.",
2719 firstScissor);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002720 }
2721 if (scissorCount > 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002722 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-scissorCount-00594",
2723 "vkCmdSetScissor: The multiViewport feature is disabled, but scissorCount (=%" PRIu32 ") is not 1.",
2724 scissorCount);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002725 }
2726 } else { // multiViewport enabled
2727 const uint64_t sum = static_cast<uint64_t>(firstScissor) + static_cast<uint64_t>(scissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002728 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002729 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-firstScissor-00592",
2730 "vkCmdSetScissor: firstScissor + scissorCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
2731 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
2732 firstScissor, scissorCount, sum, device_limits.maxViewports);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002733 }
2734 }
2735
Petr Kraus6260f0a2018-02-27 21:15:55 +01002736 if (pScissors) {
2737 for (uint32_t scissor_i = 0; scissor_i < scissorCount; ++scissor_i) {
2738 const auto &scissor = pScissors[scissor_i]; // will crash on invalid ptr
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002739
Petr Kraus6260f0a2018-02-27 21:15:55 +01002740 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002741 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
2742 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.", scissor_i,
2743 scissor.offset.x);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002744 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002745
Petr Kraus6260f0a2018-02-27 21:15:55 +01002746 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002747 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-x-00595",
2748 "vkCmdSetScissor: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.", scissor_i,
2749 scissor.offset.y);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002750 }
2751
2752 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
2753 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002754 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00596",
2755 "vkCmdSetScissor: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
2756 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2757 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002758 }
2759
2760 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
2761 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002762 skip |= LogError(commandBuffer, "VUID-vkCmdSetScissor-offset-00597",
2763 "vkCmdSetScissor: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
2764 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
2765 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Petr Kraus6260f0a2018-02-27 21:15:55 +01002766 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002767 }
2768 }
Petr Kraus6260f0a2018-02-27 21:15:55 +01002769
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002770 return skip;
2771}
2772
Jeff Bolz5c801d12019-10-09 10:38:45 -05002773bool StatelessValidation::manual_PreCallValidateCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) const {
Petr Kraus299ba622017-11-24 03:09:03 +01002774 bool skip = false;
Petr Kraus299ba622017-11-24 03:09:03 +01002775
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002776 if (!physical_device_features.wideLines && (lineWidth != 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002777 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineWidth-lineWidth-00788",
2778 "VkPhysicalDeviceFeatures::wideLines is disabled, but lineWidth (=%f) is not 1.0.", lineWidth);
Petr Kraus299ba622017-11-24 03:09:03 +01002779 }
2780
2781 return skip;
2782}
2783
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002784bool StatelessValidation::manual_PreCallValidateCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002785 uint32_t firstVertex, uint32_t firstInstance) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002786 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002787 if (vertexCount == 0) {
2788 // TODO: Verify against Valid Usage section. I don't see a non-zero vertexCount listed, may need to add that and make
2789 // this an error or leave as is.
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002790 skip |= LogWarning(device, kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t vertexCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002791 }
2792
2793 if (instanceCount == 0) {
2794 // TODO: Verify against Valid Usage section. I don't see a non-zero instanceCount listed, may need to add that and make
2795 // this an error or leave as is.
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002796 skip |= LogWarning(device, kVUID_PVError_RequiredParameter, "vkCmdDraw parameter, uint32_t instanceCount, is 0");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002797 }
2798 return skip;
2799}
2800
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002801bool StatelessValidation::manual_PreCallValidateCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002802 uint32_t count, uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002803 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002804
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002805 if (!physical_device_features.multiDrawIndirect && ((count > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002806 skip |= LogError(device, kVUID_PVError_DeviceFeature,
2807 "CmdDrawIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002808 }
2809 return skip;
2810}
2811
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002812bool StatelessValidation::manual_PreCallValidateCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002813 VkDeviceSize offset, uint32_t count, uint32_t stride) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002814 bool skip = false;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002815 if (!physical_device_features.multiDrawIndirect && ((count > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002816 skip |=
2817 LogError(device, kVUID_PVError_DeviceFeature,
2818 "CmdDrawIndexedIndirect(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", count);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002819 }
2820 return skip;
2821}
2822
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06002823bool StatelessValidation::manual_PreCallValidateCmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount,
2824 const VkClearAttachment *pAttachments, uint32_t rectCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002825 const VkClearRect *pRects) const {
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06002826 bool skip = false;
2827 for (uint32_t rect = 0; rect < rectCount; rect++) {
2828 if (pRects[rect].layerCount == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002829 skip |= LogError(commandBuffer, "VUID-vkCmdClearAttachments-layerCount-01934",
2830 "CmdClearAttachments(): pRects[%d].layerCount is zero.", rect);
Mark Lobodzinskif77a4ac2019-06-27 15:30:51 -06002831 }
2832 }
2833 return skip;
2834}
2835
Andrew Fobel3abeb992020-01-20 16:33:22 -05002836bool StatelessValidation::ValidateGetPhysicalDeviceImageFormatProperties2(VkPhysicalDevice physicalDevice,
2837 const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
2838 VkImageFormatProperties2 *pImageFormatProperties,
2839 const char *apiName) const {
2840 bool skip = false;
2841
2842 if (pImageFormatInfo != nullptr) {
2843 const auto image_stencil_struct = lvl_find_in_chain<VkImageStencilUsageCreateInfoEXT>(pImageFormatInfo->pNext);
2844 if (image_stencil_struct != nullptr) {
2845 if ((image_stencil_struct->stencilUsage & VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT) != 0) {
2846 VkImageUsageFlags legal_flags = (VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
2847 // No flags other than the legal attachment bits may be set
2848 legal_flags |= VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT;
2849 if ((image_stencil_struct->stencilUsage & ~legal_flags) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002850 skip |= LogError(physicalDevice, "VUID-VkImageStencilUsageCreateInfo-stencilUsage-02539",
2851 "%s(): in pNext chain, VkImageStencilUsageCreateInfo::stencilUsage "
2852 "includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, it must not include bits other than "
2853 "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT or VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT",
2854 apiName);
Andrew Fobel3abeb992020-01-20 16:33:22 -05002855 }
2856 }
2857 }
2858 }
2859
2860 return skip;
2861}
2862
2863bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2(
2864 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
2865 VkImageFormatProperties2 *pImageFormatProperties) const {
2866 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
2867 "vkGetPhysicalDeviceImageFormatProperties2");
2868}
2869
2870bool StatelessValidation::manual_PreCallValidateGetPhysicalDeviceImageFormatProperties2KHR(
2871 VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
2872 VkImageFormatProperties2 *pImageFormatProperties) const {
2873 return ValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties,
2874 "vkGetPhysicalDeviceImageFormatProperties2KHR");
2875}
2876
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002877bool StatelessValidation::manual_PreCallValidateCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage,
2878 VkImageLayout srcImageLayout, VkImage dstImage,
2879 VkImageLayout dstImageLayout, uint32_t regionCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002880 const VkImageCopy *pRegions) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002881 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002882
Dave Houltonf5217612018-02-02 16:18:52 -07002883 VkImageAspectFlags legal_aspect_flags =
2884 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002885 if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
Dave Houltonf5217612018-02-02 16:18:52 -07002886 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2887 }
2888
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002889 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002890 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002891 skip |= LogError(
2892 device, "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002893 "vkCmdCopyImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002894 }
Dave Houltonf5217612018-02-02 16:18:52 -07002895 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002896 skip |= LogError(
2897 device, "VUID-VkImageSubresourceLayers-aspectMask-parameter",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06002898 "vkCmdCopyImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002899 }
2900 }
2901 return skip;
2902}
2903
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002904bool StatelessValidation::manual_PreCallValidateCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage,
2905 VkImageLayout srcImageLayout, VkImage dstImage,
2906 VkImageLayout dstImageLayout, uint32_t regionCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002907 const VkImageBlit *pRegions, VkFilter filter) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002908 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002909
Dave Houltonf5217612018-02-02 16:18:52 -07002910 VkImageAspectFlags legal_aspect_flags =
2911 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002912 if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
Dave Houltonf5217612018-02-02 16:18:52 -07002913 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2914 }
2915
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002916 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002917 if ((pRegions->srcSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002918 skip |= LogError(
2919 device, kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002920 "vkCmdBlitImage() parameter, VkImageAspect pRegions->srcSubresource.aspectMask, is an unrecognized enumerator");
2921 }
Dave Houltonf5217612018-02-02 16:18:52 -07002922 if ((pRegions->dstSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002923 skip |= LogError(
2924 device, kVUID_PVError_UnrecognizedValue,
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002925 "vkCmdBlitImage() parameter, VkImageAspect pRegions->dstSubresource.aspectMask, is an unrecognized enumerator");
2926 }
2927 }
2928 return skip;
2929}
2930
sfricke-samsung3999ef62020-02-09 17:05:59 -08002931bool StatelessValidation::manual_PreCallValidateCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer,
2932 uint32_t regionCount, const VkBufferCopy *pRegions) const {
2933 bool skip = false;
2934
2935 if (pRegions != nullptr) {
2936 for (uint32_t i = 0; i < regionCount; i++) {
2937 if (pRegions[i].size == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002938 skip |= LogError(device, "VUID-VkBufferCopy-size-01988",
2939 "vkCmdCopyBuffer() pRegions[%u].size must be greater than zero", i);
sfricke-samsung3999ef62020-02-09 17:05:59 -08002940 }
2941 }
2942 }
2943 return skip;
2944}
2945
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002946bool StatelessValidation::manual_PreCallValidateCmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer,
2947 VkImage dstImage, VkImageLayout dstImageLayout,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002948 uint32_t regionCount,
2949 const VkBufferImageCopy *pRegions) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002950 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002951
Dave Houltonf5217612018-02-02 16:18:52 -07002952 VkImageAspectFlags legal_aspect_flags =
2953 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002954 if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
Dave Houltonf5217612018-02-02 16:18:52 -07002955 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2956 }
2957
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002958 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002959 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002960 skip |= LogError(device, kVUID_PVError_UnrecognizedValue,
2961 "vkCmdCopyBufferToImage() parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an "
2962 "unrecognized enumerator");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002963 }
2964 }
2965 return skip;
2966}
2967
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002968bool StatelessValidation::manual_PreCallValidateCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage,
2969 VkImageLayout srcImageLayout, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002970 uint32_t regionCount,
2971 const VkBufferImageCopy *pRegions) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002972 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002973
Dave Houltonf5217612018-02-02 16:18:52 -07002974 VkImageAspectFlags legal_aspect_flags =
2975 VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07002976 if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
Dave Houltonf5217612018-02-02 16:18:52 -07002977 legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
2978 }
2979
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002980 if (pRegions != nullptr) {
Dave Houltonf5217612018-02-02 16:18:52 -07002981 if ((pRegions->imageSubresource.aspectMask & legal_aspect_flags) == 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002982 LogError(device, kVUID_PVError_UnrecognizedValue,
2983 "vkCmdCopyImageToBuffer parameter, VkImageAspect pRegions->imageSubresource.aspectMask, is an unrecognized "
2984 "enumerator");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002985 }
2986 }
2987 return skip;
2988}
2989
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07002990bool StatelessValidation::manual_PreCallValidateCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05002991 VkDeviceSize dstOffset, VkDeviceSize dataSize,
2992 const void *pData) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002993 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002994
2995 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07002996 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dstOffset-00036",
2997 "vkCmdUpdateBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
2998 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06002999 }
3000
3001 if ((dataSize <= 0) || (dataSize > 65536)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003002 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00037",
3003 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64
3004 "), must be greater than zero and less than or equal to 65536.",
3005 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003006 } else if (dataSize & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003007 skip |= LogError(device, "VUID-vkCmdUpdateBuffer-dataSize-00038",
3008 "vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3009 dataSize);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003010 }
3011 return skip;
3012}
3013
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003014bool StatelessValidation::manual_PreCallValidateCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003015 VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003016 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003017
3018 if (dstOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003019 skip |= LogError(device, "VUID-vkCmdFillBuffer-dstOffset-00025",
3020 "vkCmdFillBuffer() parameter, VkDeviceSize dstOffset (0x%" PRIxLEAST64 "), is not a multiple of 4.",
3021 dstOffset);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003022 }
3023
3024 if (size != VK_WHOLE_SIZE) {
3025 if (size <= 0) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003026 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003027 LogError(device, "VUID-vkCmdFillBuffer-size-00026",
3028 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), must be greater than zero.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003029 } else if (size & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003030 skip |= LogError(device, "VUID-vkCmdFillBuffer-size-00028",
3031 "vkCmdFillBuffer() parameter, VkDeviceSize size (0x%" PRIxLEAST64 "), is not a multiple of 4.", size);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003032 }
3033 }
3034 return skip;
3035}
3036
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003037bool StatelessValidation::manual_PreCallValidateCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003038 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003039 VkSwapchainKHR *pSwapchain) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003040 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003041
3042 if (pCreateInfo != nullptr) {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003043 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3044 if (pCreateInfo->imageSharingMode == VK_SHARING_MODE_CONCURRENT) {
3045 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1
3046 if (pCreateInfo->queueFamilyIndexCount <= 1) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003047 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01278",
3048 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3049 "pCreateInfo->queueFamilyIndexCount must be greater than 1.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003050 }
3051
3052 // If imageSharingMode is VK_SHARING_MODE_CONCURRENT, pQueueFamilyIndices must be a pointer to an array of
3053 // queueFamilyIndexCount uint32_t values
3054 if (pCreateInfo->pQueueFamilyIndices == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003055 skip |= LogError(device, "VUID-VkSwapchainCreateInfoKHR-imageSharingMode-01277",
3056 "vkCreateSwapchainKHR(): if pCreateInfo->imageSharingMode is VK_SHARING_MODE_CONCURRENT, "
3057 "pCreateInfo->pQueueFamilyIndices must be a pointer to an array of "
3058 "pCreateInfo->queueFamilyIndexCount uint32_t values.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003059 }
3060 }
3061
Dave Houlton413a6782018-05-22 13:01:54 -06003062 skip |= ValidateGreaterThanZero(pCreateInfo->imageArrayLayers, "pCreateInfo->imageArrayLayers",
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003063 "VUID-VkSwapchainCreateInfoKHR-imageArrayLayers-01275", "vkCreateSwapchainKHR");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003064 }
3065
3066 return skip;
3067}
3068
Jeff Bolz5c801d12019-10-09 10:38:45 -05003069bool StatelessValidation::manual_PreCallValidateQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003070 bool skip = false;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003071
3072 if (pPresentInfo && pPresentInfo->pNext) {
John Zulaufde972ac2017-10-26 12:07:05 -06003073 const auto *present_regions = lvl_find_in_chain<VkPresentRegionsKHR>(pPresentInfo->pNext);
3074 if (present_regions) {
3075 // TODO: This and all other pNext extension dependencies should be added to code-generation
Tony-LunarG2ec96bb2019-11-26 13:43:02 -07003076 skip |= require_device_extension(IsExtEnabled(device_extensions.vk_khr_incremental_present), "vkQueuePresentKHR",
John Zulaufde972ac2017-10-26 12:07:05 -06003077 VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME);
3078 if (present_regions->swapchainCount != pPresentInfo->swapchainCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003079 skip |= LogError(device, kVUID_PVError_InvalidUsage,
3080 "QueuePresentKHR(): pPresentInfo->swapchainCount has a value of %i but VkPresentRegionsKHR "
3081 "extension swapchainCount is %i. These values must be equal.",
3082 pPresentInfo->swapchainCount, present_regions->swapchainCount);
John Zulaufde972ac2017-10-26 12:07:05 -06003083 }
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003084 skip |= validate_struct_pnext("QueuePresentKHR", "pCreateInfo->pNext->pNext", NULL, present_regions->pNext, 0, NULL,
sfricke-samsung32a27362020-02-28 09:06:42 -08003085 GeneratedVulkanHeaderVersion, "VUID-VkPresentInfoKHR-pNext-pNext",
3086 "VUID-VkPresentInfoKHR-sType-unique");
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003087 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->swapchainCount", "pCreateInfo->pNext->pRegions",
3088 present_regions->swapchainCount, &present_regions->pRegions, true, false, kVUIDUndefined,
3089 kVUIDUndefined);
John Zulaufde972ac2017-10-26 12:07:05 -06003090 for (uint32_t i = 0; i < present_regions->swapchainCount; ++i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003091 skip |= validate_array("QueuePresentKHR", "pCreateInfo->pNext->pRegions[].rectangleCount",
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003092 "pCreateInfo->pNext->pRegions[].pRectangles", present_regions->pRegions[i].rectangleCount,
Dave Houlton413a6782018-05-22 13:01:54 -06003093 &present_regions->pRegions[i].pRectangles, true, false, kVUIDUndefined, kVUIDUndefined);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003094 }
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003095 }
3096 }
3097
3098 return skip;
3099}
3100
3101#ifdef VK_USE_PLATFORM_WIN32_KHR
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003102bool StatelessValidation::manual_PreCallValidateCreateWin32SurfaceKHR(VkInstance instance,
3103 const VkWin32SurfaceCreateInfoKHR *pCreateInfo,
3104 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003105 VkSurfaceKHR *pSurface) const {
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003106 bool skip = false;
3107
3108 if (pCreateInfo->hwnd == nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003109 skip |= LogError(device, "VUID-VkWin32SurfaceCreateInfoKHR-hwnd-01308",
3110 "vkCreateWin32SurfaceKHR(): hwnd must be a valid Win32 HWND but hwnd is NULL.");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003111 }
3112
3113 return skip;
3114}
3115#endif // VK_USE_PLATFORM_WIN32_KHR
3116
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003117bool StatelessValidation::manual_PreCallValidateCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo,
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003118 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003119 VkDescriptorPool *pDescriptorPool) const {
Petr Krausc8655be2017-09-27 18:56:51 +02003120 bool skip = false;
3121
3122 if (pCreateInfo) {
3123 if (pCreateInfo->maxSets <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003124 skip |= LogError(device, "VUID-VkDescriptorPoolCreateInfo-maxSets-00301",
3125 "vkCreateDescriptorPool(): pCreateInfo->maxSets is not greater than 0.");
Petr Krausc8655be2017-09-27 18:56:51 +02003126 }
3127
3128 if (pCreateInfo->pPoolSizes) {
3129 for (uint32_t i = 0; i < pCreateInfo->poolSizeCount; ++i) {
3130 if (pCreateInfo->pPoolSizes[i].descriptorCount <= 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003131 skip |= LogError(
3132 device, "VUID-VkDescriptorPoolSize-descriptorCount-00302",
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003133 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not greater than 0.", i);
Petr Krausc8655be2017-09-27 18:56:51 +02003134 }
Jeff Bolze54ae892018-09-08 12:16:29 -05003135 if (pCreateInfo->pPoolSizes[i].type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT &&
3136 (pCreateInfo->pPoolSizes[i].descriptorCount % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003137 skip |= LogError(device, "VUID-VkDescriptorPoolSize-type-02218",
3138 "vkCreateDescriptorPool(): pCreateInfo->pPoolSizes[%" PRIu32
3139 "].type is VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK_EXT "
3140 " and pCreateInfo->pPoolSizes[%" PRIu32 "].descriptorCount is not a multiple of 4.",
3141 i, i);
Jeff Bolze54ae892018-09-08 12:16:29 -05003142 }
Petr Krausc8655be2017-09-27 18:56:51 +02003143 }
3144 }
3145 }
3146
3147 return skip;
3148}
3149
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003150bool StatelessValidation::manual_PreCallValidateCmdDispatch(VkCommandBuffer commandBuffer, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003151 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003152 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003153
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003154 if (groupCountX > device_limits.maxComputeWorkGroupCount[0]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003155 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003156 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountX-00386",
3157 "vkCmdDispatch(): groupCountX (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3158 groupCountX, device_limits.maxComputeWorkGroupCount[0]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003159 }
3160
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003161 if (groupCountY > device_limits.maxComputeWorkGroupCount[1]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003162 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003163 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountY-00387",
3164 "vkCmdDispatch(): groupCountY (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3165 groupCountY, device_limits.maxComputeWorkGroupCount[1]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003166 }
3167
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003168 if (groupCountZ > device_limits.maxComputeWorkGroupCount[2]) {
Mark Lobodzinski487a0d12018-03-30 10:09:03 -06003169 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003170 LogError(commandBuffer, "VUID-vkCmdDispatch-groupCountZ-00388",
3171 "vkCmdDispatch(): groupCountZ (%" PRIu32 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3172 groupCountZ, device_limits.maxComputeWorkGroupCount[2]);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003173 }
3174
3175 return skip;
3176}
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003177
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003178bool StatelessValidation::manual_PreCallValidateCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003179 VkDeviceSize offset) const {
John Zulaufa999d1b2018-11-29 13:38:40 -07003180 bool skip = false;
John Zulaufa999d1b2018-11-29 13:38:40 -07003181
3182 if ((offset % 4) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003183 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchIndirect-offset-02710",
3184 "vkCmdDispatchIndirect(): offset (%" PRIu64 ") must be a multiple of 4.", offset);
John Zulaufa999d1b2018-11-29 13:38:40 -07003185 }
3186 return skip;
3187}
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003188
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003189bool StatelessValidation::manual_PreCallValidateCmdDispatchBaseKHR(VkCommandBuffer commandBuffer, uint32_t baseGroupX,
3190 uint32_t baseGroupY, uint32_t baseGroupZ, uint32_t groupCountX,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003191 uint32_t groupCountY, uint32_t groupCountZ) const {
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003192 bool skip = false;
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003193
3194 // Paired if {} else if {} tests used to avoid any possible uint underflow
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003195 uint32_t limit = device_limits.maxComputeWorkGroupCount[0];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003196 if (baseGroupX >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003197 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00421",
3198 "vkCmdDispatch(): baseGroupX (%" PRIu32
3199 ") equals or exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3200 baseGroupX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003201 } else if (groupCountX > (limit - baseGroupX)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003202 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountX-00424",
3203 "vkCmdDispatchBaseKHR(): baseGroupX (%" PRIu32 ") + groupCountX (%" PRIu32
3204 ") exceeds device limit maxComputeWorkGroupCount[0] (%" PRIu32 ").",
3205 baseGroupX, groupCountX, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003206 }
3207
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003208 limit = device_limits.maxComputeWorkGroupCount[1];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003209 if (baseGroupY >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003210 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupX-00422",
3211 "vkCmdDispatch(): baseGroupY (%" PRIu32
3212 ") equals or exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3213 baseGroupY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003214 } else if (groupCountY > (limit - baseGroupY)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003215 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountY-00425",
3216 "vkCmdDispatchBaseKHR(): baseGroupY (%" PRIu32 ") + groupCountY (%" PRIu32
3217 ") exceeds device limit maxComputeWorkGroupCount[1] (%" PRIu32 ").",
3218 baseGroupY, groupCountY, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003219 }
3220
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003221 limit = device_limits.maxComputeWorkGroupCount[2];
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003222 if (baseGroupZ >= limit) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003223 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-baseGroupZ-00423",
3224 "vkCmdDispatch(): baseGroupZ (%" PRIu32
3225 ") equals or exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3226 baseGroupZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003227 } else if (groupCountZ > (limit - baseGroupZ)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003228 skip |= LogError(commandBuffer, "VUID-vkCmdDispatchBase-groupCountZ-00426",
3229 "vkCmdDispatchBaseKHR(): baseGroupZ (%" PRIu32 ") + groupCountZ (%" PRIu32
3230 ") exceeds device limit maxComputeWorkGroupCount[2] (%" PRIu32 ").",
3231 baseGroupZ, groupCountZ, limit);
Dave Houltonbb7d3fe2018-01-11 17:09:16 -07003232 }
3233
3234 return skip;
3235}
3236
Jeremy Hayes390ff6f2020-02-10 13:48:57 -07003237bool StatelessValidation::manual_PreCallValidateCmdPushDescriptorSetKHR(VkCommandBuffer commandBuffer,
3238 VkPipelineBindPoint pipelineBindPoint,
3239 VkPipelineLayout layout, uint32_t set,
3240 uint32_t descriptorWriteCount,
3241 const VkWriteDescriptorSet *pDescriptorWrites) const {
3242 return validate_WriteDescriptorSet("vkCmdPushDescriptorSetKHR", descriptorWriteCount, pDescriptorWrites, false);
3243}
3244
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003245bool StatelessValidation::manual_PreCallValidateCmdSetExclusiveScissorNV(VkCommandBuffer commandBuffer,
3246 uint32_t firstExclusiveScissor,
3247 uint32_t exclusiveScissorCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003248 const VkRect2D *pExclusiveScissors) const {
Jeff Bolz3e71f782018-08-29 23:15:45 -05003249 bool skip = false;
3250
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003251 if (!physical_device_features.multiViewport) {
Jeff Bolz3e71f782018-08-29 23:15:45 -05003252 if (firstExclusiveScissor != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003253 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003254 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02035",
3255 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but firstExclusiveScissor (=%" PRIu32
3256 ") is not 0.",
3257 firstExclusiveScissor);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003258 }
3259 if (exclusiveScissorCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003260 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003261 LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-exclusiveScissorCount-02036",
3262 "vkCmdSetExclusiveScissorNV: The multiViewport feature is disabled, but exclusiveScissorCount (=%" PRIu32
3263 ") is not 1.",
3264 exclusiveScissorCount);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003265 }
3266 } else { // multiViewport enabled
3267 const uint64_t sum = static_cast<uint64_t>(firstExclusiveScissor) + static_cast<uint64_t>(exclusiveScissorCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003268 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003269 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02034",
3270 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor + exclusiveScissorCount (=%" PRIu32 " + %" PRIu32
3271 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3272 firstExclusiveScissor, exclusiveScissorCount, sum, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003273 }
3274 }
3275
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003276 if (firstExclusiveScissor >= device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003277 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-firstExclusiveScissor-02033",
3278 "vkCmdSetExclusiveScissorNV: firstExclusiveScissor (=%" PRIu32
3279 ") must be less than maxViewports (=%" PRIu32 ").",
3280 firstExclusiveScissor, device_limits.maxViewports);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003281 }
3282
3283 if (pExclusiveScissors) {
3284 for (uint32_t scissor_i = 0; scissor_i < exclusiveScissorCount; ++scissor_i) {
3285 const auto &scissor = pExclusiveScissors[scissor_i]; // will crash on invalid ptr
3286
3287 if (scissor.offset.x < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003288 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
3289 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.x (=%" PRIi32 ") is negative.",
3290 scissor_i, scissor.offset.x);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003291 }
3292
3293 if (scissor.offset.y < 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003294 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-x-02037",
3295 "vkCmdSetExclusiveScissorNV: pScissors[%" PRIu32 "].offset.y (=%" PRIi32 ") is negative.",
3296 scissor_i, scissor.offset.y);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003297 }
3298
3299 const int64_t x_sum = static_cast<int64_t>(scissor.offset.x) + static_cast<int64_t>(scissor.extent.width);
3300 if (x_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003301 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02038",
3302 "vkCmdSetExclusiveScissorNV: offset.x + extent.width (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3303 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3304 scissor.offset.x, scissor.extent.width, x_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003305 }
3306
3307 const int64_t y_sum = static_cast<int64_t>(scissor.offset.y) + static_cast<int64_t>(scissor.extent.height);
3308 if (y_sum > INT32_MAX) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003309 skip |= LogError(commandBuffer, "VUID-vkCmdSetExclusiveScissorNV-offset-02039",
3310 "vkCmdSetExclusiveScissorNV: offset.y + extent.height (=%" PRIi32 " + %" PRIu32 " = %" PRIi64
3311 ") of pScissors[%" PRIu32 "] will overflow int32_t.",
3312 scissor.offset.y, scissor.extent.height, y_sum, scissor_i);
Jeff Bolz3e71f782018-08-29 23:15:45 -05003313 }
3314 }
3315 }
3316
3317 return skip;
3318}
3319
Chris Mayer9ded5eb2019-09-19 16:33:26 +02003320bool StatelessValidation::manual_PreCallValidateCmdSetViewportWScalingNV(VkCommandBuffer commandBuffer, uint32_t firstViewport,
3321 uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003322 const VkViewportWScalingNV *pViewportWScalings) const {
Chris Mayer9ded5eb2019-09-19 16:33:26 +02003323 bool skip = false;
3324 if (firstViewport >= device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003325 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWScalingNV-firstViewport-01323",
3326 "vkCmdSetViewportWScalingNV: firstViewport (=%" PRIu32 ") must be less than maxViewports (=%" PRIu32 ").",
3327 firstViewport, device_limits.maxViewports);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02003328 } else {
3329 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
3330 if ((sum < 1) || (sum > device_limits.maxViewports)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003331 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportWScalingNV-firstViewport-01324",
3332 "vkCmdSetViewportWScalingNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32 " = %" PRIu64
3333 ") must be between 1 and VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 "), inculsive.",
3334 firstViewport, viewportCount, sum, device_limits.maxViewports);
Chris Mayer9ded5eb2019-09-19 16:33:26 +02003335 }
3336 }
3337
3338 return skip;
3339}
3340
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003341bool StatelessValidation::manual_PreCallValidateCmdSetViewportShadingRatePaletteNV(
3342 VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003343 const VkShadingRatePaletteNV *pShadingRatePalettes) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003344 bool skip = false;
3345
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003346 if (!physical_device_features.multiViewport) {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003347 if (firstViewport != 0) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003348 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003349 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02068",
3350 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but firstViewport (=%" PRIu32
3351 ") is not 0.",
3352 firstViewport);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003353 }
3354 if (viewportCount > 1) {
Dave Houlton142c4cb2018-10-17 15:04:41 -06003355 skip |=
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003356 LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-viewportCount-02069",
3357 "vkCmdSetViewportShadingRatePaletteNV: The multiViewport feature is disabled, but viewportCount (=%" PRIu32
3358 ") is not 1.",
3359 viewportCount);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003360 }
3361 }
3362
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003363 if (firstViewport >= device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003364 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02066",
3365 "vkCmdSetViewportShadingRatePaletteNV: firstViewport (=%" PRIu32
3366 ") must be less than maxViewports (=%" PRIu32 ").",
3367 firstViewport, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003368 }
3369
3370 const uint64_t sum = static_cast<uint64_t>(firstViewport) + static_cast<uint64_t>(viewportCount);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003371 if (sum > device_limits.maxViewports) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003372 skip |= LogError(commandBuffer, "VUID-vkCmdSetViewportShadingRatePaletteNV-firstViewport-02067",
3373 "vkCmdSetViewportShadingRatePaletteNV: firstViewport + viewportCount (=%" PRIu32 " + %" PRIu32
3374 " = %" PRIu64 ") is greater than VkPhysicalDeviceLimits::maxViewports (=%" PRIu32 ").",
3375 firstViewport, viewportCount, sum, device_limits.maxViewports);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003376 }
3377
3378 return skip;
3379}
3380
Jeff Bolz5c801d12019-10-09 10:38:45 -05003381bool StatelessValidation::manual_PreCallValidateCmdSetCoarseSampleOrderNV(
3382 VkCommandBuffer commandBuffer, VkCoarseSampleOrderTypeNV sampleOrderType, uint32_t customSampleOrderCount,
3383 const VkCoarseSampleOrderCustomNV *pCustomSampleOrders) const {
Jeff Bolz9af91c52018-09-01 21:53:57 -05003384 bool skip = false;
3385
Dave Houlton142c4cb2018-10-17 15:04:41 -06003386 if (sampleOrderType != VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV && customSampleOrderCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003387 skip |= LogError(commandBuffer, "VUID-vkCmdSetCoarseSampleOrderNV-sampleOrderType-02081",
3388 "vkCmdSetCoarseSampleOrderNV: If sampleOrderType is not VK_COARSE_SAMPLE_ORDER_TYPE_CUSTOM_NV, "
3389 "customSampleOrderCount must be 0.");
Jeff Bolz9af91c52018-09-01 21:53:57 -05003390 }
3391
3392 for (uint32_t order_i = 0; order_i < customSampleOrderCount; ++order_i) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003393 skip |= ValidateCoarseSampleOrderCustomNV(&pCustomSampleOrders[order_i]);
Jeff Bolz9af91c52018-09-01 21:53:57 -05003394 }
3395
3396 return skip;
3397}
3398
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003399bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksNV(VkCommandBuffer commandBuffer, uint32_t taskCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003400 uint32_t firstTask) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003401 bool skip = false;
3402
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003403 if (taskCount > phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003404 skip |= LogError(
3405 commandBuffer, "VUID-vkCmdDrawMeshTasksNV-taskCount-02119",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003406 "vkCmdDrawMeshTasksNV() parameter, uint32_t taskCount (0x%" PRIxLEAST32
3407 "), must be less than or equal to VkPhysicalDeviceMeshShaderPropertiesNV::maxDrawMeshTasksCount (0x%" PRIxLEAST32 ").",
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003408 taskCount, phys_dev_ext_props.mesh_shader_props.maxDrawMeshTasksCount);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003409 }
3410
3411 return skip;
3412}
3413
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003414bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
3415 VkDeviceSize offset, uint32_t drawCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003416 uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003417 bool skip = false;
Lockee1c22882019-06-10 16:02:54 -06003418 static const int condition_multiples = 0b0011;
3419 if (offset & condition_multiples) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003420 skip |= LogError(
3421 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-offset-02710",
Dave Houlton142c4cb2018-10-17 15:04:41 -06003422 "vkCmdDrawMeshTasksIndirectNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64 "), is not a multiple of 4.", offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003423 }
Lockee1c22882019-06-10 16:02:54 -06003424 if (drawCount > 1 && ((stride & condition_multiples) || stride < sizeof(VkDrawMeshTasksIndirectCommandNV))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003425 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02146",
3426 "vkCmdDrawMeshTasksIndirectNV() parameter, uint32_t stride (0x%" PRIxLEAST32
3427 "), is not a multiple of 4 or smaller than sizeof (VkDrawMeshTasksIndirectCommandNV).",
3428 stride);
Lockee1c22882019-06-10 16:02:54 -06003429 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003430 if (!physical_device_features.multiDrawIndirect && ((drawCount > 1))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003431 skip |= LogError(
3432 commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectNV-drawCount-02718",
3433 "vkCmdDrawMeshTasksIndirectNV(): Device feature multiDrawIndirect disabled: count must be 0 or 1 but is %d", drawCount);
Jeff Bolzb574c342018-11-08 15:36:57 -06003434 }
3435
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003436 return skip;
3437}
3438
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003439bool StatelessValidation::manual_PreCallValidateCmdDrawMeshTasksIndirectCountNV(VkCommandBuffer commandBuffer, VkBuffer buffer,
3440 VkDeviceSize offset, VkBuffer countBuffer,
3441 VkDeviceSize countBufferOffset,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003442 uint32_t maxDrawCount, uint32_t stride) const {
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003443 bool skip = false;
3444
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003445 if (offset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003446 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-offset-02710",
3447 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize offset (0x%" PRIxLEAST64
3448 "), is not a multiple of 4.",
3449 offset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003450 }
3451
3452 if (countBufferOffset & 3) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003453 skip |= LogError(commandBuffer, "VUID-vkCmdDrawMeshTasksIndirectCountNV-countBufferOffset-02716",
3454 "vkCmdDrawMeshTasksIndirectCountNV() parameter, VkDeviceSize countBufferOffset (0x%" PRIxLEAST64
3455 "), is not a multiple of 4.",
3456 countBufferOffset);
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003457 }
3458
Jeff Bolz45bf7d62018-09-18 15:39:58 -05003459 return skip;
3460}
3461
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003462bool StatelessValidation::manual_PreCallValidateCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003463 const VkAllocationCallbacks *pAllocator,
3464 VkQueryPool *pQueryPool) const {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003465 bool skip = false;
3466
3467 // Validation for parameters excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3468 if (pCreateInfo != nullptr) {
3469 // If queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, pipelineStatistics must be a valid combination of
3470 // VkQueryPipelineStatisticFlagBits values
3471 if ((pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) && (pCreateInfo->pipelineStatistics != 0) &&
3472 ((pCreateInfo->pipelineStatistics & (~AllVkQueryPipelineStatisticFlagBits)) != 0)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003473 skip |= LogError(device, "VUID-VkQueryPoolCreateInfo-queryType-00792",
3474 "vkCreateQueryPool(): if pCreateInfo->queryType is VK_QUERY_TYPE_PIPELINE_STATISTICS, "
3475 "pCreateInfo->pipelineStatistics must be a valid combination of VkQueryPipelineStatisticFlagBits "
3476 "values.");
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003477 }
Mark Lobodzinskib7a26382018-07-02 13:14:26 -06003478 }
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003479 return skip;
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003480}
3481
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003482bool StatelessValidation::manual_PreCallValidateEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice,
3483 const char *pLayerName, uint32_t *pPropertyCount,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003484 VkExtensionProperties *pProperties) const {
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003485 return validate_array("vkEnumerateDeviceExtensionProperties", "pPropertyCount", "pProperties", pPropertyCount, &pProperties,
3486 true, false, false, kVUIDUndefined, "VUID-vkEnumerateDeviceExtensionProperties-pProperties-parameter");
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003487}
3488
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003489void StatelessValidation::PostCallRecordCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07003490 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
3491 VkResult result) {
3492 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003493 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003494}
3495
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003496void StatelessValidation::PostCallRecordCreateRenderPass2KHR(VkDevice device, const VkRenderPassCreateInfo2KHR *pCreateInfo,
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07003497 const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass,
3498 VkResult result) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003499 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskicd05c1e2019-01-17 15:33:46 -07003500 if (result != VK_SUCCESS) return;
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003501 RecordRenderPass(*pRenderPass, pCreateInfo);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003502}
3503
Mark Lobodzinskibf599b92018-12-31 12:15:55 -07003504void StatelessValidation::PostCallRecordDestroyRenderPass(VkDevice device, VkRenderPass renderPass,
3505 const VkAllocationCallbacks *pAllocator) {
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003506 // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
Mark Lobodzinskif27a6bc2019-02-04 13:00:49 -07003507 std::unique_lock<std::mutex> lock(renderpass_map_mutex);
Mark Lobodzinskiaf7c0382018-12-18 11:55:55 -07003508 renderpasses_states.erase(renderPass);
Mark Lobodzinskid4950072017-08-01 13:02:20 -06003509}
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06003510
3511bool StatelessValidation::manual_PreCallValidateAllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003512 const VkAllocationCallbacks *pAllocator,
3513 VkDeviceMemory *pMemory) const {
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06003514 bool skip = false;
3515
3516 if (pAllocateInfo) {
3517 auto chained_prio_struct = lvl_find_in_chain<VkMemoryPriorityAllocateInfoEXT>(pAllocateInfo->pNext);
3518 if (chained_prio_struct && (chained_prio_struct->priority < 0.0f || chained_prio_struct->priority > 1.0f)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003519 skip |= LogError(device, "VUID-VkMemoryPriorityAllocateInfoEXT-priority-02602",
3520 "priority (=%f) must be between `0` and `1`, inclusive.", chained_prio_struct->priority);
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06003521 }
Jeff Bolz4563f2a2019-12-10 13:30:30 -06003522
3523 VkMemoryAllocateFlags flags = 0;
3524 auto flags_info = lvl_find_in_chain<VkMemoryAllocateFlagsInfo>(pAllocateInfo->pNext);
3525 if (flags_info) {
3526 flags = flags_info->flags;
3527 }
3528
3529 auto opaque_alloc_info = lvl_find_in_chain<VkMemoryOpaqueCaptureAddressAllocateInfoKHR>(pAllocateInfo->pNext);
3530 if (opaque_alloc_info && opaque_alloc_info->opaqueCaptureAddress != 0) {
3531 if (!(flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003532 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03329",
3533 "If opaqueCaptureAddress is non-zero, VkMemoryAllocateFlagsInfo::flags must include "
3534 "VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06003535 }
3536
3537#ifdef VK_USE_PLATFORM_WIN32_KHR
3538 auto import_memory_win32_handle = lvl_find_in_chain<VkImportMemoryWin32HandleInfoKHR>(pAllocateInfo->pNext);
3539#endif
3540 auto import_memory_fd = lvl_find_in_chain<VkImportMemoryFdInfoKHR>(pAllocateInfo->pNext);
3541 auto import_memory_host_pointer = lvl_find_in_chain<VkImportMemoryHostPointerInfoEXT>(pAllocateInfo->pNext);
3542#ifdef VK_USE_PLATFORM_ANDROID_KHR
3543 auto import_memory_ahb = lvl_find_in_chain<VkImportAndroidHardwareBufferInfoANDROID>(pAllocateInfo->pNext);
3544#endif
3545
3546 if (import_memory_host_pointer) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003547 skip |= LogError(
3548 device, "VUID-VkMemoryAllocateInfo-pNext-03332",
Jeff Bolz4563f2a2019-12-10 13:30:30 -06003549 "If the pNext chain includes a VkImportMemoryHostPointerInfoEXT structure, opaqueCaptureAddress must be zero.");
3550 }
3551 if (
3552#ifdef VK_USE_PLATFORM_WIN32_KHR
3553 (import_memory_win32_handle && import_memory_win32_handle->handleType) ||
3554#endif
3555 (import_memory_fd && import_memory_fd->handleType) ||
3556#ifdef VK_USE_PLATFORM_ANDROID_KHR
3557 (import_memory_ahb && import_memory_ahb->buffer) ||
3558#endif
3559 (import_memory_host_pointer && import_memory_host_pointer->handleType)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003560 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-opaqueCaptureAddress-03333",
3561 "If the parameters define an import operation, opaqueCaptureAddress must be zero.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06003562 }
3563 }
3564
3565 if (flags) {
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07003566 VkBool32 capture_replay = false;
3567 VkBool32 buffer_device_address = false;
3568 const auto *vulkan_12_features = lvl_find_in_chain<VkPhysicalDeviceVulkan12Features>(device_createinfo_pnext);
3569 if (vulkan_12_features) {
3570 capture_replay = vulkan_12_features->bufferDeviceAddressCaptureReplay;
3571 buffer_device_address = vulkan_12_features->bufferDeviceAddress;
3572 } else {
3573 const auto *bda_features =
3574 lvl_find_in_chain<VkPhysicalDeviceBufferDeviceAddressFeaturesKHR>(device_createinfo_pnext);
3575 if (bda_features) {
3576 capture_replay = bda_features->bufferDeviceAddressCaptureReplay;
3577 buffer_device_address = bda_features->bufferDeviceAddress;
3578 }
3579 }
3580 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR) && !capture_replay) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003581 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03330",
3582 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_KHR is set, "
3583 "bufferDeviceAddressCaptureReplay must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06003584 }
Tony-LunarGa74d3fe2019-11-22 15:43:20 -07003585 if ((flags & VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT_KHR) && !buffer_device_address) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003586 skip |= LogError(device, "VUID-VkMemoryAllocateInfo-flags-03331",
3587 "If VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT_KHR is set, bufferDeviceAddress must be enabled.");
Jeff Bolz4563f2a2019-12-10 13:30:30 -06003588 }
3589 }
Jeff Bolz7e7e6e02019-01-11 22:53:41 -06003590 }
3591 return skip;
3592}
Ricardo Garciaa4935972019-02-21 17:43:18 +01003593
Jason Macnak192fa0e2019-07-26 15:07:16 -07003594bool StatelessValidation::ValidateGeometryTrianglesNV(const VkGeometryTrianglesNV &triangles,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003595 VkAccelerationStructureNV object_handle, const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07003596 bool skip = false;
3597
3598 if (triangles.vertexFormat != VK_FORMAT_R32G32B32_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16B16_SFLOAT &&
3599 triangles.vertexFormat != VK_FORMAT_R16G16B16_SNORM && triangles.vertexFormat != VK_FORMAT_R32G32_SFLOAT &&
3600 triangles.vertexFormat != VK_FORMAT_R16G16_SFLOAT && triangles.vertexFormat != VK_FORMAT_R16G16_SNORM) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003601 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexFormat-02430", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003602 } else {
3603 uint32_t vertex_component_size = 0;
3604 if (triangles.vertexFormat == VK_FORMAT_R32G32B32_SFLOAT || triangles.vertexFormat == VK_FORMAT_R32G32_SFLOAT) {
3605 vertex_component_size = 4;
3606 } else if (triangles.vertexFormat == VK_FORMAT_R16G16B16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16B16_SNORM ||
3607 triangles.vertexFormat == VK_FORMAT_R16G16_SFLOAT || triangles.vertexFormat == VK_FORMAT_R16G16_SNORM) {
3608 vertex_component_size = 2;
3609 }
3610 if (vertex_component_size > 0 && SafeModulo(triangles.vertexOffset, vertex_component_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003611 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-vertexOffset-02429", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003612 }
3613 }
3614
3615 if (triangles.indexType != VK_INDEX_TYPE_UINT32 && triangles.indexType != VK_INDEX_TYPE_UINT16 &&
3616 triangles.indexType != VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003617 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexType-02433", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003618 } else {
3619 uint32_t index_element_size = 0;
3620 if (triangles.indexType == VK_INDEX_TYPE_UINT32) {
3621 index_element_size = 4;
3622 } else if (triangles.indexType == VK_INDEX_TYPE_UINT16) {
3623 index_element_size = 2;
3624 }
3625 if (index_element_size > 0 && SafeModulo(triangles.indexOffset, index_element_size) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003626 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexOffset-02432", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003627 }
3628 }
3629 if (triangles.indexType == VK_INDEX_TYPE_NONE_NV) {
3630 if (triangles.indexCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003631 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexCount-02436", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003632 }
3633 if (triangles.indexData != VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003634 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-indexData-02434", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003635 }
3636 }
3637
3638 if (SafeModulo(triangles.transformOffset, 16) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003639 skip |= LogError(object_handle, "VUID-VkGeometryTrianglesNV-transformOffset-02438", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003640 }
3641
3642 return skip;
3643}
3644
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003645bool StatelessValidation::ValidateGeometryAABBNV(const VkGeometryAABBNV &aabbs, VkAccelerationStructureNV object_handle,
3646 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07003647 bool skip = false;
3648
3649 if (SafeModulo(aabbs.offset, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003650 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-offset-02440", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003651 }
3652 if (SafeModulo(aabbs.stride, 8) != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003653 skip |= LogError(object_handle, "VUID-VkGeometryAABBNV-stride-02441", "%s", func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003654 }
3655
3656 return skip;
3657}
3658
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003659bool StatelessValidation::ValidateGeometryNV(const VkGeometryNV &geometry, VkAccelerationStructureNV object_handle,
3660 const char *func_name) const {
Jason Macnak192fa0e2019-07-26 15:07:16 -07003661 bool skip = false;
3662 if (geometry.geometryType == VK_GEOMETRY_TYPE_TRIANGLES_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003663 skip = ValidateGeometryTrianglesNV(geometry.geometry.triangles, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003664 } else if (geometry.geometryType == VK_GEOMETRY_TYPE_AABBS_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003665 skip = ValidateGeometryAABBNV(geometry.geometry.aabbs, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003666 }
3667 return skip;
3668}
3669
3670bool StatelessValidation::ValidateAccelerationStructureInfoNV(const VkAccelerationStructureInfoNV &info,
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003671 VkAccelerationStructureNV object_handle,
Jason Macnak192fa0e2019-07-26 15:07:16 -07003672 const char *func_name) const {
Jason Macnak5c954952019-07-09 15:46:12 -07003673 bool skip = false;
3674 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV && info.geometryCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003675 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02425",
3676 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_NV then "
3677 "geometryCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07003678 }
3679 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.instanceCount != 0) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003680 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-type-02426",
3681 "VkAccelerationStructureInfoNV: If type is VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV then "
3682 "instanceCount must be 0.");
Jason Macnak5c954952019-07-09 15:46:12 -07003683 }
3684 if (info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV &&
3685 info.flags & VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003686 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-flags-02592",
3687 "VkAccelerationStructureInfoNV: If flags has the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_NV"
3688 "bit set, then it must not have the VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_BUILD_BIT_NV bit set.");
Jason Macnak5c954952019-07-09 15:46:12 -07003689 }
3690 if (info.geometryCount > phys_dev_ext_props.ray_tracing_props.maxGeometryCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003691 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-geometryCount-02422",
3692 "VkAccelerationStructureInfoNV: geometryCount must be less than or equal to "
3693 "VkPhysicalDeviceRayTracingPropertiesNV::maxGeometryCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07003694 }
3695 if (info.instanceCount > phys_dev_ext_props.ray_tracing_props.maxInstanceCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003696 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-instanceCount-02423",
3697 "VkAccelerationStructureInfoNV: instanceCount must be less than or equal to "
3698 "VkPhysicalDeviceRayTracingPropertiesNV::maxInstanceCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07003699 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07003700 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 0) {
Jason Macnak5c954952019-07-09 15:46:12 -07003701 uint64_t total_triangle_count = 0;
3702 for (uint32_t i = 0; i < info.geometryCount; i++) {
3703 const VkGeometryNV &geometry = info.pGeometries[i];
Jason Macnak192fa0e2019-07-26 15:07:16 -07003704
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003705 skip |= ValidateGeometryNV(geometry, object_handle, func_name);
Jason Macnak192fa0e2019-07-26 15:07:16 -07003706
Jason Macnak5c954952019-07-09 15:46:12 -07003707 if (geometry.geometryType != VK_GEOMETRY_TYPE_TRIANGLES_NV) {
3708 continue;
3709 }
3710 total_triangle_count += geometry.geometry.triangles.indexCount / 3;
3711 }
3712 if (total_triangle_count > phys_dev_ext_props.ray_tracing_props.maxTriangleCount) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003713 skip |= LogError(object_handle, "VUID-VkAccelerationStructureInfoNV-maxTriangleCount-02424",
3714 "VkAccelerationStructureInfoNV: The total number of triangles in all geometries must be less than "
3715 "or equal to VkPhysicalDeviceRayTracingPropertiesNV::maxTriangleCount.");
Jason Macnak5c954952019-07-09 15:46:12 -07003716 }
3717 }
Jason Macnak21ba97e2019-08-09 12:57:44 -07003718 if (info.type == VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_NV && info.geometryCount > 1) {
3719 const VkGeometryTypeNV first_geometry_type = info.pGeometries[0].geometryType;
3720 for (uint32_t i = 1; i < info.geometryCount; i++) {
3721 const VkGeometryNV &geometry = info.pGeometries[i];
3722 if (geometry.geometryType != first_geometry_type) {
3723 // TODO: update fake VUID below with the real one once it is generated.
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003724 skip |= LogError(device, "UNASSIGNED-VkAccelerationStructureInfoNV-pGeometries-XXXX",
3725 "VkAccelerationStructureInfoNV: info.pGeometries[%d].geometryType does not match "
3726 "info.pGeometries[0].geometryType.",
3727 i);
Jason Macnak21ba97e2019-08-09 12:57:44 -07003728 }
3729 }
3730 }
Jason Macnak5c954952019-07-09 15:46:12 -07003731 return skip;
3732}
3733
Ricardo Garciaa4935972019-02-21 17:43:18 +01003734bool StatelessValidation::manual_PreCallValidateCreateAccelerationStructureNV(
3735 VkDevice device, const VkAccelerationStructureCreateInfoNV *pCreateInfo, const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003736 VkAccelerationStructureNV *pAccelerationStructure) const {
Ricardo Garciaa4935972019-02-21 17:43:18 +01003737 bool skip = false;
3738
3739 if (pCreateInfo) {
3740 if ((pCreateInfo->compactedSize != 0) &&
3741 ((pCreateInfo->info.geometryCount != 0) || (pCreateInfo->info.instanceCount != 0))) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003742 skip |= LogError(device, "VUID-VkAccelerationStructureCreateInfoNV-compactedSize-02421",
3743 "vkCreateAccelerationStructureNV(): pCreateInfo->compactedSize nonzero (%" PRIu64
3744 ") with info.geometryCount (%" PRIu32 ") or info.instanceCount (%" PRIu32 ") nonzero.",
3745 pCreateInfo->compactedSize, pCreateInfo->info.geometryCount, pCreateInfo->info.instanceCount);
Ricardo Garciaa4935972019-02-21 17:43:18 +01003746 }
Jason Macnak5c954952019-07-09 15:46:12 -07003747
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003748 skip |= ValidateAccelerationStructureInfoNV(pCreateInfo->info, VkAccelerationStructureNV(0),
Jason Macnak192fa0e2019-07-26 15:07:16 -07003749 "vkCreateAccelerationStructureNV()");
Ricardo Garciaa4935972019-02-21 17:43:18 +01003750 }
3751
3752 return skip;
3753}
Mike Schuchardt21638df2019-03-16 10:52:02 -07003754
Jeff Bolz5c801d12019-10-09 10:38:45 -05003755bool StatelessValidation::manual_PreCallValidateCmdBuildAccelerationStructureNV(VkCommandBuffer commandBuffer,
3756 const VkAccelerationStructureInfoNV *pInfo,
3757 VkBuffer instanceData, VkDeviceSize instanceOffset,
3758 VkBool32 update, VkAccelerationStructureNV dst,
3759 VkAccelerationStructureNV src, VkBuffer scratch,
3760 VkDeviceSize scratchOffset) const {
Jason Macnak5c954952019-07-09 15:46:12 -07003761 bool skip = false;
3762
3763 if (pInfo != nullptr) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003764 skip |= ValidateAccelerationStructureInfoNV(*pInfo, dst, "vkCmdBuildAccelerationStructureNV()");
Jason Macnak5c954952019-07-09 15:46:12 -07003765 }
3766
3767 return skip;
3768}
3769
3770bool StatelessValidation::manual_PreCallValidateGetAccelerationStructureHandleNV(VkDevice device,
3771 VkAccelerationStructureNV accelerationStructure,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003772 size_t dataSize, void *pData) const {
Jason Macnak5c954952019-07-09 15:46:12 -07003773 bool skip = false;
3774 if (dataSize < 8) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003775 skip = LogError(accelerationStructure, "VUID-vkGetAccelerationStructureHandleNV-dataSize-02240",
3776 "vkGetAccelerationStructureHandleNV(): dataSize must be greater than or equal to 8.");
Jason Macnak5c954952019-07-09 15:46:12 -07003777 }
3778 return skip;
3779}
3780
Peter Chen85366392019-05-14 15:20:11 -04003781bool StatelessValidation::manual_PreCallValidateCreateRayTracingPipelinesNV(VkDevice device, VkPipelineCache pipelineCache,
3782 uint32_t createInfoCount,
3783 const VkRayTracingPipelineCreateInfoNV *pCreateInfos,
3784 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003785 VkPipeline *pPipelines) const {
Peter Chen85366392019-05-14 15:20:11 -04003786 bool skip = false;
3787
3788 for (uint32_t i = 0; i < createInfoCount; i++) {
3789 auto feedback_struct = lvl_find_in_chain<VkPipelineCreationFeedbackCreateInfoEXT>(pCreateInfos[i].pNext);
3790 if ((feedback_struct != nullptr) && (feedback_struct->pipelineStageCreationFeedbackCount != pCreateInfos[i].stageCount)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003791 skip |= LogError(device, "VUID-VkPipelineCreationFeedbackCreateInfoEXT-pipelineStageCreationFeedbackCount-02670",
3792 "vkCreateRayTracingPipelinesNV(): in pCreateInfo[%" PRIu32
3793 "], VkPipelineCreationFeedbackEXT::pipelineStageCreationFeedbackCount"
3794 "(=%" PRIu32 ") must equal VkRayTracingPipelineCreateInfoNV::stageCount(=%" PRIu32 ").",
3795 i, feedback_struct->pipelineStageCreationFeedbackCount, pCreateInfos[i].stageCount);
Peter Chen85366392019-05-14 15:20:11 -04003796 }
3797 }
3798
3799 return skip;
3800}
3801
Mike Schuchardt21638df2019-03-16 10:52:02 -07003802#ifdef VK_USE_PLATFORM_WIN32_KHR
3803bool StatelessValidation::PreCallValidateGetDeviceGroupSurfacePresentModes2EXT(VkDevice device,
3804 const VkPhysicalDeviceSurfaceInfo2KHR *pSurfaceInfo,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003805 VkDeviceGroupPresentModeFlagsKHR *pModes) const {
Mike Schuchardt21638df2019-03-16 10:52:02 -07003806 bool skip = false;
3807 if (!device_extensions.vk_khr_swapchain)
3808 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SWAPCHAIN_EXTENSION_NAME);
3809 if (!device_extensions.vk_khr_get_surface_capabilities_2)
3810 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_SURFACE_CAPABILITIES_2_EXTENSION_NAME);
3811 if (!device_extensions.vk_khr_surface)
3812 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_SURFACE_EXTENSION_NAME);
3813 if (!device_extensions.vk_khr_get_physical_device_properties_2)
3814 skip |=
3815 OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME);
3816 if (!device_extensions.vk_ext_full_screen_exclusive)
3817 skip |= OutputExtensionError("vkGetDeviceGroupSurfacePresentModes2EXT", VK_EXT_FULL_SCREEN_EXCLUSIVE_EXTENSION_NAME);
3818 skip |= validate_struct_type(
3819 "vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo", "VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR",
3820 pSurfaceInfo, VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SURFACE_INFO_2_KHR, true,
3821 "VUID-vkGetDeviceGroupSurfacePresentModes2EXT-pSurfaceInfo-parameter", "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-sType");
3822 if (pSurfaceInfo != NULL) {
3823 const VkStructureType allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR[] = {
3824 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_INFO_EXT,
3825 VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_WIN32_INFO_EXT};
3826
3827 skip |= validate_struct_pnext("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->pNext",
3828 "VkSurfaceFullScreenExclusiveInfoEXT, VkSurfaceFullScreenExclusiveWin32InfoEXT",
3829 pSurfaceInfo->pNext, ARRAY_SIZE(allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR),
3830 allowed_structs_VkPhysicalDeviceSurfaceInfo2KHR, GeneratedVulkanHeaderVersion,
sfricke-samsung32a27362020-02-28 09:06:42 -08003831 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-pNext-pNext",
3832 "VUID-VkPhysicalDeviceSurfaceInfo2KHR-sType-unique");
Mike Schuchardt21638df2019-03-16 10:52:02 -07003833
3834 skip |= validate_required_handle("vkGetDeviceGroupSurfacePresentModes2EXT", "pSurfaceInfo->surface", pSurfaceInfo->surface);
3835 }
3836 return skip;
3837}
3838#endif
Tobias Hectorebb855f2019-07-23 12:17:33 +01003839
3840bool StatelessValidation::manual_PreCallValidateCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo,
3841 const VkAllocationCallbacks *pAllocator,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003842 VkFramebuffer *pFramebuffer) const {
Tobias Hectorebb855f2019-07-23 12:17:33 +01003843 // Validation for pAttachments which is excluded from the generated validation code due to a 'noautovalidity' tag in vk.xml
3844 bool skip = false;
3845 if ((pCreateInfo->flags & VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT_KHR) == 0) {
3846 skip |= validate_array("vkCreateFramebuffer", "attachmentCount", "pAttachments", pCreateInfo->attachmentCount,
3847 &pCreateInfo->pAttachments, false, true, kVUIDUndefined, kVUIDUndefined);
3848 }
3849 return skip;
3850}
Jeff Bolz8125a8b2019-08-16 16:29:45 -05003851
3852bool StatelessValidation::manual_PreCallValidateCmdSetLineStippleEXT(VkCommandBuffer commandBuffer, uint32_t lineStippleFactor,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003853 uint16_t lineStipplePattern) const {
Jeff Bolz8125a8b2019-08-16 16:29:45 -05003854 bool skip = false;
3855
3856 if (lineStippleFactor < 1 || lineStippleFactor > 256) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003857 skip |= LogError(commandBuffer, "VUID-vkCmdSetLineStippleEXT-lineStippleFactor-02776",
3858 "vkCmdSetLineStippleEXT::lineStippleFactor=%d is not in [1,256].", lineStippleFactor);
Jeff Bolz8125a8b2019-08-16 16:29:45 -05003859 }
3860
3861 return skip;
3862}
Piers Daniell8fd03f52019-08-21 12:07:53 -06003863
3864bool StatelessValidation::manual_PreCallValidateCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003865 VkDeviceSize offset, VkIndexType indexType) const {
Piers Daniell8fd03f52019-08-21 12:07:53 -06003866 bool skip = false;
3867
3868 if (indexType == VK_INDEX_TYPE_NONE_NV) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003869 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02507",
3870 "vkCmdBindIndexBuffer() indexType must not be VK_INDEX_TYPE_NONE_NV.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06003871 }
3872
Tony-LunarG6c3c5452019-12-13 10:37:38 -07003873 const auto *index_type_uint8_features = lvl_find_in_chain<VkPhysicalDeviceIndexTypeUint8FeaturesEXT>(device_createinfo_pnext);
Piers Daniell8fd03f52019-08-21 12:07:53 -06003874 if (indexType == VK_INDEX_TYPE_UINT8_EXT && !index_type_uint8_features->indexTypeUint8) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003875 skip |= LogError(commandBuffer, "VUID-vkCmdBindIndexBuffer-indexType-02765",
3876 "vkCmdBindIndexBuffer() indexType is VK_INDEX_TYPE_UINT8_EXT but indexTypeUint8 feature is not enabled.");
Piers Daniell8fd03f52019-08-21 12:07:53 -06003877 }
3878
3879 return skip;
3880}
Mark Lobodzinski84988402019-09-11 15:27:30 -06003881
sfricke-samsung4ada8d42020-02-09 17:43:11 -08003882bool StatelessValidation::manual_PreCallValidateCmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding,
3883 uint32_t bindingCount, const VkBuffer *pBuffers,
3884 const VkDeviceSize *pOffsets) const {
3885 bool skip = false;
3886 if (firstBinding > device_limits.maxVertexInputBindings) {
3887 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00624",
3888 "vkCmdBindVertexBuffers() firstBinding (%u) must be less than maxVertexInputBindings (%u)", firstBinding,
3889 device_limits.maxVertexInputBindings);
3890 } else if ((firstBinding + bindingCount) > device_limits.maxVertexInputBindings) {
3891 skip |= LogError(commandBuffer, "VUID-vkCmdBindVertexBuffers-firstBinding-00625",
3892 "vkCmdBindVertexBuffers() sum of firstBinding (%u) and bindingCount (%u) must be less than "
3893 "maxVertexInputBindings (%u)",
3894 firstBinding, bindingCount, device_limits.maxVertexInputBindings);
3895 }
3896
3897 return skip;
3898}
3899
Mark Lobodzinski84988402019-09-11 15:27:30 -06003900bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectNameEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003901 const VkDebugUtilsObjectNameInfoEXT *pNameInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06003902 bool skip = false;
3903 if (pNameInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003904 skip |= LogError(device, "VUID-VkDebugUtilsObjectNameInfoEXT-objectType-02589",
3905 "vkSetDebugUtilsObjectNameEXT() pNameInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06003906 }
3907 return skip;
3908}
3909
3910bool StatelessValidation::manual_PreCallValidateSetDebugUtilsObjectTagEXT(VkDevice device,
Jeff Bolz5c801d12019-10-09 10:38:45 -05003911 const VkDebugUtilsObjectTagInfoEXT *pTagInfo) const {
Mark Lobodzinski84988402019-09-11 15:27:30 -06003912 bool skip = false;
3913 if (pTagInfo->objectType == VK_OBJECT_TYPE_UNKNOWN) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003914 skip |= LogError(device, "VUID-VkDebugUtilsObjectTagInfoEXT-objectType-01908",
3915 "vkSetDebugUtilsObjectTagEXT() pTagInfo->objectType cannot be VK_OBJECT_TYPE_UNKNOWN.");
Mark Lobodzinski84988402019-09-11 15:27:30 -06003916 }
3917 return skip;
3918}
Petr Kraus3d720392019-11-13 02:52:39 +01003919
3920bool StatelessValidation::manual_PreCallValidateAcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout,
3921 VkSemaphore semaphore, VkFence fence,
3922 uint32_t *pImageIndex) const {
3923 bool skip = false;
3924
3925 if (semaphore == VK_NULL_HANDLE && fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003926 skip |= LogError(swapchain, "VUID-vkAcquireNextImageKHR-semaphore-01780",
3927 "vkAcquireNextImageKHR: semaphore and fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01003928 }
3929
3930 return skip;
3931}
3932
3933bool StatelessValidation::manual_PreCallValidateAcquireNextImage2KHR(VkDevice device, const VkAcquireNextImageInfoKHR *pAcquireInfo,
3934 uint32_t *pImageIndex) const {
3935 bool skip = false;
3936
3937 if (pAcquireInfo->semaphore == VK_NULL_HANDLE && pAcquireInfo->fence == VK_NULL_HANDLE) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003938 skip |= LogError(pAcquireInfo->swapchain, "VUID-VkAcquireNextImageInfoKHR-semaphore-01782",
3939 "vkAcquireNextImage2KHR: pAcquireInfo->semaphore and pAcquireInfo->fence are both VK_NULL_HANDLE.");
Petr Kraus3d720392019-11-13 02:52:39 +01003940 }
3941
3942 return skip;
3943}
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07003944
3945bool StatelessValidation::manual_PreCallValidateCmdDrawIndirectByteCountEXT(VkCommandBuffer commandBuffer, uint32_t instanceCount,
3946 uint32_t firstInstance, VkBuffer counterBuffer,
3947 VkDeviceSize counterBufferOffset,
3948 uint32_t counterOffset, uint32_t vertexStride) const {
3949 bool skip = false;
3950
3951 if ((vertexStride <= 0) || (vertexStride > phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003952 skip |= LogError(
3953 counterBuffer, "VUID-vkCmdDrawIndirectByteCountEXT-vertexStride-02289",
Mark Lobodzinski953b7bc2019-12-19 13:50:10 -07003954 "vkCmdDrawIndirectByteCountEXT: vertexStride (%d) must be between 0 and maxTransformFeedbackBufferDataStride (%d).",
3955 vertexStride, phys_dev_ext_props.transform_feedback_props.maxTransformFeedbackBufferDataStride);
3956 }
3957
3958 return skip;
3959}
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08003960
3961bool StatelessValidation::ValidateCreateSamplerYcbcrConversion(VkDevice device,
3962 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
3963 const VkAllocationCallbacks *pAllocator,
3964 VkSamplerYcbcrConversion *pYcbcrConversion,
3965 const char *apiName) const {
3966 bool skip = false;
3967
3968 // Check samplerYcbcrConversion feature is set
Tony-LunarG6c3c5452019-12-13 10:37:38 -07003969 const auto *ycbcr_features = lvl_find_in_chain<VkPhysicalDeviceSamplerYcbcrConversionFeatures>(device_createinfo_pnext);
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08003970 if ((ycbcr_features == nullptr) || (ycbcr_features->samplerYcbcrConversion == VK_FALSE)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003971 skip |= LogError(device, "VUID-vkCreateSamplerYcbcrConversion-None-01648",
3972 "samplerYcbcrConversion must be enabled to call %s.", apiName);
sfricke-samsung11ea8ed2020-01-07 22:24:56 -08003973 }
3974 return skip;
3975}
3976
3977bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversion(VkDevice device,
3978 const VkSamplerYcbcrConversionCreateInfo *pCreateInfo,
3979 const VkAllocationCallbacks *pAllocator,
3980 VkSamplerYcbcrConversion *pYcbcrConversion) const {
3981 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
3982 "vkCreateSamplerYcbcrConversion");
3983}
3984
3985bool StatelessValidation::manual_PreCallValidateCreateSamplerYcbcrConversionKHR(
3986 VkDevice device, const VkSamplerYcbcrConversionCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator,
3987 VkSamplerYcbcrConversion *pYcbcrConversion) const {
3988 return ValidateCreateSamplerYcbcrConversion(device, pCreateInfo, pAllocator, pYcbcrConversion,
3989 "vkCreateSamplerYcbcrConversionKHR");
3990}
sfricke-samsung1708a8c2020-02-10 00:35:06 -08003991
3992bool StatelessValidation::manual_PreCallValidateImportSemaphoreFdKHR(
3993 VkDevice device, const VkImportSemaphoreFdInfoKHR *pImportSemaphoreFdInfo) const {
3994 bool skip = false;
3995 VkExternalSemaphoreHandleTypeFlags supported_handle_types =
3996 VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_OPAQUE_FD_BIT | VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT;
3997
3998 if (0 == (pImportSemaphoreFdInfo->handleType & supported_handle_types)) {
Mark Lobodzinski5d8244a2020-01-23 13:00:43 -07003999 skip |= LogError(device, "VUID-VkImportSemaphoreFdInfoKHR-handleType-01143",
4000 "vkImportSemaphoreFdKHR() to semaphore %s handleType %s is not one of the supported handleTypes (%s).",
4001 report_data->FormatHandle(pImportSemaphoreFdInfo->semaphore).c_str(),
4002 string_VkExternalSemaphoreHandleTypeFlagBits(pImportSemaphoreFdInfo->handleType),
4003 string_VkExternalSemaphoreHandleTypeFlags(supported_handle_types).c_str());
sfricke-samsung1708a8c2020-02-10 00:35:06 -08004004 }
4005 return skip;
4006}