blob: 9956f2a0ff629a478f9d922492442fc750ae9027 [file] [log] [blame]
Mike Frysinger4f994402019-09-13 17:40:45 -04001#!/usr/bin/env python3
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002# -*- coding: utf-8 -*-
Jon Salz98255932012-08-18 14:48:02 +08003# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
Mike Frysingerae409522014-02-01 03:16:11 -05007"""Presubmit checks to run when doing `repo upload`.
8
Tom Hughes40bdce52020-08-25 08:57:03 -07009You can add new checks by adding a function to the HOOKS constants.
Mike Frysingerae409522014-02-01 03:16:11 -050010"""
11
Mike Frysinger09d6a3d2013-10-08 22:21:03 -040012from __future__ import print_function
13
Keigo Okadd908822019-06-04 11:30:25 +090014import argparse
Alex Deymo643ac4c2015-09-03 10:40:50 -070015import collections
Mike Frysingerf252cfc2019-12-09 17:34:28 -050016import configparser
Keigo Oka7e880ac2019-07-03 15:03:43 +090017import datetime
Daniel Erate3ea3fc2015-02-13 15:27:52 -070018import fnmatch
Jon Salz3ee59de2012-08-18 13:54:22 +080019import functools
Dale Curtis2975c432011-05-03 17:25:20 -070020import json
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070021import os
Stephen Boyd6bf5ea82020-10-15 00:02:07 -070022import pathlib
Ryan Cuiec4d6332011-05-02 14:15:25 -070023import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070024import sys
Peter Ammon811f6702014-06-12 15:45:38 -070025import stat
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -050026import subprocess
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070027
Ryan Cui1562fb82011-05-09 11:01:31 -070028from errors import (VerifyException, HookFailure, PrintErrorForProject,
29 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070030
Mike Frysinger919c7032019-09-13 17:48:08 -040031if __name__ in ('__builtin__', 'builtins'):
Mike Frysinger653cd262019-09-20 14:05:02 -040032 # If repo imports us, the __name__ will be __builtin__, and the cwd will be in
33 # the top level of the checkout (i.e. $CHROMEOS_CHECKOUT). chromite will be
34 # in that directory, so add it to our path. This works whether we're running
35 # the repo in $CHROMEOS_CHECKOUT/.repo/repo/ or a custom version in a
36 # completely different tree.
37 # TODO(vapier): Python 2 used "__builtin__" while Python 3 uses "builtins".
Mike Frysinger6850d512018-05-21 12:12:14 -040038 sys.path.insert(0, os.getcwd())
39
Mike Frysinger653cd262019-09-20 14:05:02 -040040elif __name__ == '__main__':
41 # If we're run directly, we'll find chromite relative to the repohooks dir in
42 # $CHROMEOS_CHECKOUT/src/repohooks, so go up two dirs.
David Jamesc3b68b32013-04-03 09:17:03 -070043 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
44
Mike Frysingerfd481ce2019-09-13 18:14:48 -040045# The sys.path monkey patching confuses the linter.
46# pylint: disable=wrong-import-position
Mike Frysinger66142932014-12-18 14:55:57 -050047from chromite.lib import commandline
Rahul Chaudhry0e515342015-08-07 12:00:43 -070048from chromite.lib import cros_build_lib
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050049from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070050from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070051from chromite.lib import patch
Mike Frysingered1b95a2019-12-12 19:04:51 -050052from chromite.lib import terminal
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040053from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070054
Mike Frysingerff4768e2020-02-27 18:48:13 -050055
56assert sys.version_info >= (3, 6), 'This module requires Python 3.6+'
57
58
Vadim Bendebury2b62d742014-06-22 13:14:51 -070059PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070060
Mike Frysingered9b2a02019-12-12 18:52:32 -050061
62# Link to commit message documentation for users.
63DOC_COMMIT_MSG_URL = ('https://chromium.googlesource.com/chromiumos/docs/+/HEAD'
64 '/contributing.md#commit-messages')
65
66
Ryan Cuiec4d6332011-05-02 14:15:25 -070067COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050068 # C++ and friends
Mike Frysinger24dd3c52019-08-17 14:22:48 -040069 r'.*\.c$', r'.*\.cc$', r'.*\.cpp$', r'.*\.h$', r'.*\.m$', r'.*\.mm$',
70 r'.*\.inl$', r'.*\.asm$', r'.*\.hxx$', r'.*\.hpp$', r'.*\.s$', r'.*\.S$',
Mike Frysingerae409522014-02-01 03:16:11 -050071 # Scripts
Mike Frysinger24dd3c52019-08-17 14:22:48 -040072 r'.*\.js$', r'.*\.py$', r'.*\.sh$', r'.*\.rb$', r'.*\.pl$', r'.*\.pm$',
Bob Haarman0dc1f942020-10-03 00:06:59 +000073 # No extension at all, note that ALL CAPS files are excluded by
Mike Frysingerae409522014-02-01 03:16:11 -050074 # COMMON_EXCLUDED_LIST below.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040075 r'(^|.*[\\\/])[^.]+$',
Mike Frysingerae409522014-02-01 03:16:11 -050076 # Other
Mike Frysinger24dd3c52019-08-17 14:22:48 -040077 r'.*\.java$', r'.*\.mk$', r'.*\.am$',
Harry Cutts24a75b62020-12-04 12:03:14 -080078 r'.*\.policy$', r'.*\.rules$', r'.*\.conf$', r'.*\.go$',
Mike Frysinger24dd3c52019-08-17 14:22:48 -040079 r'(^OWNERS|/OWNERS)',
Ryan Cuiec4d6332011-05-02 14:15:25 -070080]
81
Ryan Cui1562fb82011-05-09 11:01:31 -070082
Ryan Cuiec4d6332011-05-02 14:15:25 -070083COMMON_EXCLUDED_PATHS = [
Daniel Erate3ea3fc2015-02-13 15:27:52 -070084 # For ebuild trees, ignore any caches and manifest data.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040085 r'.*/Manifest$',
86 r'.*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$',
Doug Anderson5bfb6792011-10-25 16:45:41 -070087
Daniel Erate3ea3fc2015-02-13 15:27:52 -070088 # Ignore profiles data (like overlay-tegra2/profiles).
Mike Frysinger24dd3c52019-08-17 14:22:48 -040089 r'(^|.*/)overlay-.*/profiles/.*',
90 r'^profiles/.*$',
Mike Frysinger98638102014-08-28 00:15:08 -040091
C Shapiro8f90e9b2017-06-28 09:54:50 -060092 # Ignore config files in ebuild setup.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040093 r'(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*',
94 r'^chromeos-base/chromeos-bsp.*/files/.*',
C Shapiro8f90e9b2017-06-28 09:54:50 -060095
Daniel Erate3ea3fc2015-02-13 15:27:52 -070096 # Ignore minified js and jquery.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040097 r'.*\.min\.js',
98 r'.*jquery.*\.js',
Mike Frysinger33a458d2014-03-03 17:00:51 -050099
100 # Ignore license files as the content is often taken verbatim.
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400101 r'.*/licenses/.*',
Alex Klein619c0912019-01-30 17:13:23 -0700102
Mike Frysinger13650402019-07-31 14:31:46 -0400103 # Exclude generated protobuf bindings.
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400104 r'.*_pb2\.py$',
105 r'.*\.pb\.go$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700106]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700107
Ken Turnerd07564b2018-02-08 17:57:59 +1100108LICENSE_EXCLUDED_PATHS = [
LaMont Jones775c2b32020-02-19 17:32:54 -0700109 r'^(.*/)?OWNERS(\..*)?$',
Tom Hughes90b7bd42020-11-10 10:31:49 -0800110 r'^(.*/)?DIR_METADATA(\..*)?$',
Ken Turnerd07564b2018-02-08 17:57:59 +1100111]
Ryan Cui1562fb82011-05-09 11:01:31 -0700112
Ryan Cui9b651632011-05-11 11:38:58 -0700113_CONFIG_FILE = 'PRESUBMIT.cfg'
114
115
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700116# File containing wildcards, one per line, matching files that should be
117# excluded from presubmit checks. Lines beginning with '#' are ignored.
118_IGNORE_FILE = '.presubmitignore'
119
Cheng Yuehb707c522020-01-02 14:06:59 +0800120
121TEST_FIELD_RE = r'\nTEST=\S+'
122
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700123BLOCKED_TERMS_FILE = 'blocked_terms.txt'
124UNBLOCKED_TERMS_FILE = 'unblocked_terms.txt'
125
Doug Anderson44a644f2011-11-02 10:37:37 -0700126# Exceptions
127
128
129class BadInvocation(Exception):
130 """An Exception indicating a bad invocation of the program."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700131
132
Ryan Cui1562fb82011-05-09 11:01:31 -0700133# General Helpers
134
Sean Paulba01d402011-05-05 11:36:23 -0400135
Mike Frysingerb2496652019-09-12 23:35:46 -0400136class Cache(object):
137 """General helper for caching git content."""
138
139 def __init__(self):
140 self._cache = {}
141
142 def get_subcache(self, scope):
143 return self._cache.setdefault(scope, {})
144
145 def clear(self):
146 self._cache.clear()
147
148CACHE = Cache()
149
150
Alex Deymo643ac4c2015-09-03 10:40:50 -0700151Project = collections.namedtuple('Project', ['name', 'dir', 'remote'])
152
153
Mike Frysinger526a5f82019-09-13 18:05:30 -0400154def _run_command(cmd, **kwargs):
Doug Anderson44a644f2011-11-02 10:37:37 -0700155 """Executes the passed in command and returns raw stdout output.
156
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400157 This is a convenience func to set some run defaults differently.
Mike Frysinger526a5f82019-09-13 18:05:30 -0400158
Doug Anderson44a644f2011-11-02 10:37:37 -0700159 Args:
160 cmd: The command to run; should be a list of strings.
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400161 **kwargs: Same as cros_build_lib.run.
Doug Anderson44a644f2011-11-02 10:37:37 -0700162
163 Returns:
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700164 The stdout from the process (discards stderr and returncode).
Doug Anderson44a644f2011-11-02 10:37:37 -0700165 """
Mike Frysinger526a5f82019-09-13 18:05:30 -0400166 kwargs.setdefault('print_cmd', False)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400167 kwargs.setdefault('stdout', True)
168 kwargs.setdefault('check', False)
Mike Frysinger054c1592019-11-18 03:51:54 -0500169 result = cros_build_lib.run(cmd, **kwargs)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400170 # NB: We decode this directly rather than through kwargs as our tests rely
171 # on this post-processing behavior currently.
Mike Frysinger71e643e2019-09-13 17:26:39 -0400172 return result.output.decode('utf-8', 'replace')
Ryan Cui72834d12011-05-05 14:51:33 -0700173
Ryan Cui1562fb82011-05-09 11:01:31 -0700174
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700175def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700176 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700177 if __name__ == '__main__':
178 # Works when file is run on its own (__file__ is defined)...
179 return os.path.abspath(os.path.dirname(__file__))
180 else:
181 # We need to do this when we're run through repo. Since repo executes
182 # us with execfile(), we don't get __file__ defined.
183 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
184 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700185
Ryan Cui1562fb82011-05-09 11:01:31 -0700186
Ryan Cuiec4d6332011-05-02 14:15:25 -0700187def _match_regex_list(subject, expressions):
188 """Try to match a list of regular expressions to a string.
189
190 Args:
191 subject: The string to match regexes on
192 expressions: A list of regular expressions to check for matches with.
193
194 Returns:
195 Whether the passed in subject matches any of the passed in regexes.
196 """
197 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500198 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700199 return True
200 return False
201
Ryan Cui1562fb82011-05-09 11:01:31 -0700202
Mike Frysingerae409522014-02-01 03:16:11 -0500203def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700204 """Filter out files based on the conditions passed in.
205
206 Args:
207 files: list of filepaths to filter
208 include_list: list of regex that when matched with a file path will cause it
209 to be added to the output list unless the file is also matched with a
210 regex in the exclude_list.
211 exclude_list: list of regex that when matched with a file will prevent it
212 from being added to the output list, even if it is also matched with a
213 regex in the include_list.
214
215 Returns:
216 A list of filepaths that contain files matched in the include_list and not
217 in the exclude_list.
218 """
219 filtered = []
220 for f in files:
221 if (_match_regex_list(f, include_list) and
222 not _match_regex_list(f, exclude_list)):
223 filtered.append(f)
224 return filtered
225
Ryan Cuiec4d6332011-05-02 14:15:25 -0700226
227# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700228
229
Ryan Cui4725d952011-05-05 15:41:19 -0700230def _get_upstream_branch():
231 """Returns the upstream tracking branch of the current branch.
232
233 Raises:
234 Error if there is no tracking branch
235 """
236 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
237 current_branch = current_branch.replace('refs/heads/', '')
238 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700239 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700240
241 cfg_option = 'branch.' + current_branch + '.%s'
242 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
243 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
244 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700245 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700246
247 return full_upstream.replace('heads', 'remotes/' + remote)
248
Ryan Cui1562fb82011-05-09 11:01:31 -0700249
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700250def _get_patch(commit):
251 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700252 if commit == PRE_SUBMIT:
253 return _run_command(['git', 'diff', '--cached', 'HEAD'])
254 else:
255 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700256
Ryan Cui1562fb82011-05-09 11:01:31 -0700257
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500258def _get_file_content(path, commit):
259 """Returns the content of a file at a specific commit.
260
261 We can't rely on the file as it exists in the filesystem as people might be
262 uploading a series of changes which modifies the file multiple times.
263
264 Note: The "content" of a symlink is just the target. So if you're expecting
265 a full file, you should check that first. One way to detect is that the
266 content will not have any newlines.
267 """
Mike Frysingerb2496652019-09-12 23:35:46 -0400268 # Make sure people don't accidentally pass in full paths which will never
269 # work. You need to use relative=True with _get_affected_files.
270 if path.startswith('/'):
271 raise ValueError('_get_file_content must be called with relative paths: %s'
272 % (path,))
273
274 # {<commit>: {<path1>: <content>, <path2>: <content>}}
275 cache = CACHE.get_subcache('get_file_content')
276 if path in cache:
277 return cache[path]
278
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700279 if commit == PRE_SUBMIT:
Mike Frysingerd9ed85f2021-02-03 12:38:24 -0500280 content = _run_command(['git', 'diff', 'HEAD', '--', path], stderr=True)
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700281 else:
Mike Frysingerd9ed85f2021-02-03 12:38:24 -0500282 content = _run_command(['git', 'show', '%s:%s' % (commit, path)],
283 stderr=True)
Mike Frysingerb2496652019-09-12 23:35:46 -0400284 cache[path] = content
285 return content
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500286
287
Mike Frysingerae409522014-02-01 03:16:11 -0500288def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700289 """Returns a list of (linenum, lines) tuples that the commit touched."""
Mike Frysingerb2496652019-09-12 23:35:46 -0400290 # {<commit>: {<path1>: <content>, <path2>: <content>}}
291 cache = CACHE.get_subcache('get_file_diff')
292 if path in cache:
293 return cache[path]
294
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700295 if commit == PRE_SUBMIT:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800296 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD',
Yu-Ping Wue3e47362020-09-22 15:54:40 +0800297 '--', path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700298 else:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800299 command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit,
Yu-Ping Wue3e47362020-09-22 15:54:40 +0800300 '--', path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700301 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700302
303 new_lines = []
304 line_num = 0
305 for line in output.splitlines():
306 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
307 if m:
308 line_num = int(m.groups(1)[0])
309 continue
310 if line.startswith('+') and not line.startswith('++'):
Mike Frysinger71e643e2019-09-13 17:26:39 -0400311 new_lines.append((line_num, line[1:]))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700312 if not line.startswith('-'):
313 line_num += 1
Mike Frysingerb2496652019-09-12 23:35:46 -0400314 cache[path] = new_lines
Ryan Cuiec4d6332011-05-02 14:15:25 -0700315 return new_lines
316
Ryan Cui1562fb82011-05-09 11:01:31 -0700317
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700318def _get_ignore_wildcards(directory, cache):
319 """Get wildcards listed in a directory's _IGNORE_FILE.
320
321 Args:
322 directory: A string containing a directory path.
323 cache: A dictionary (opaque to caller) caching previously-read wildcards.
324
325 Returns:
326 A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE
327 wasn't present.
328 """
329 # In the cache, keys are directories and values are lists of wildcards from
330 # _IGNORE_FILE within those directories (and empty if no file was present).
331 if directory not in cache:
332 wildcards = []
333 dotfile_path = os.path.join(directory, _IGNORE_FILE)
334 if os.path.exists(dotfile_path):
335 # TODO(derat): Consider using _get_file_content() to get the file as of
336 # this commit instead of the on-disk version. This may have a noticeable
337 # performance impact, as each call to _get_file_content() runs git.
338 with open(dotfile_path, 'r') as dotfile:
339 for line in dotfile.readlines():
340 line = line.strip()
341 if line.startswith('#'):
342 continue
343 if line.endswith('/'):
344 line += '*'
345 wildcards.append(line)
346 cache[directory] = wildcards
347
348 return cache[directory]
349
350
351def _path_is_ignored(path, cache):
352 """Check whether a path is ignored by _IGNORE_FILE.
353
354 Args:
355 path: A string containing a path.
356 cache: A dictionary (opaque to caller) caching previously-read wildcards.
357
358 Returns:
359 True if a file named _IGNORE_FILE in one of the passed-in path's parent
360 directories contains a wildcard matching the path.
361 """
362 # Skip ignore files.
363 if os.path.basename(path) == _IGNORE_FILE:
364 return True
365
366 path = os.path.abspath(path)
367 base = os.getcwd()
368
369 prefix = os.path.dirname(path)
370 while prefix.startswith(base):
371 rel_path = path[len(prefix) + 1:]
372 for wildcard in _get_ignore_wildcards(prefix, cache):
373 if fnmatch.fnmatch(rel_path, wildcard):
374 return True
375 prefix = os.path.dirname(prefix)
376
377 return False
378
379
Mike Frysinger292b45d2014-11-25 01:17:10 -0500380def _get_affected_files(commit, include_deletes=False, relative=False,
381 include_symlinks=False, include_adds=True,
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700382 full_details=False, use_ignore_files=True):
Peter Ammon811f6702014-06-12 15:45:38 -0700383 """Returns list of file paths that were modified/added, excluding symlinks.
384
385 Args:
386 commit: The commit
387 include_deletes: If true, we'll include deleted files in the result
388 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500389 include_symlinks: If true, we'll include symlinks in the result
390 include_adds: If true, we'll include new files in the result
391 full_details: If False, return filenames, else return structured results.
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700392 use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files.
Peter Ammon811f6702014-06-12 15:45:38 -0700393
394 Returns:
395 A list of modified/added (and perhaps deleted) files
396 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500397 if not relative and full_details:
398 raise ValueError('full_details only supports relative paths currently')
399
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700400 if commit == PRE_SUBMIT:
401 return _run_command(['git', 'diff-index', '--cached',
402 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500403
404 path = os.getcwd()
Mike Frysingerb2496652019-09-12 23:35:46 -0400405 # {<commit>: {<path1>: <content>, <path2>: <content>}}
406 cache = CACHE.get_subcache('get_affected_files')
407 if path not in cache:
408 cache[path] = git.RawDiff(path, '%s^!' % commit)
409 files = cache[path]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500410
411 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500412 if not include_symlinks:
413 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500414
415 if not include_deletes:
416 files = [x for x in files if x.status != 'D']
417
Mike Frysinger292b45d2014-11-25 01:17:10 -0500418 if not include_adds:
419 files = [x for x in files if x.status != 'A']
420
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700421 if use_ignore_files:
422 cache = {}
423 is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache)
424 files = [x for x in files if not is_ignored(x)]
425
Mike Frysinger292b45d2014-11-25 01:17:10 -0500426 if full_details:
427 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500428 return files
429 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500430 # Caller only cares about filenames.
431 files = [x.dst_file if x.dst_file else x.src_file for x in files]
432 if relative:
433 return files
434 else:
435 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700436
437
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700438def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700439 """Returns a list of commits for this review."""
Mike Frysingere300c7d2019-09-12 23:33:52 -0400440 cmd = ['git', 'log', '--no-merges', '--format=%H',
441 '%s..' % _get_upstream_branch()]
Ryan Cui72834d12011-05-05 14:51:33 -0700442 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700443
Ryan Cui1562fb82011-05-09 11:01:31 -0700444
Ryan Cuiec4d6332011-05-02 14:15:25 -0700445def _get_commit_desc(commit):
446 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700447 if commit == PRE_SUBMIT:
448 return ''
Mike Frysingerb2496652019-09-12 23:35:46 -0400449
450 # {<commit>: <content>}
451 cache = CACHE.get_subcache('get_commit_desc')
452 if commit not in cache:
Mike Frysinger4efdee72019-11-04 10:57:01 -0500453 cache[commit] = _run_command(['git', 'log', '--format=%B',
Mike Frysingerb2496652019-09-12 23:35:46 -0400454 commit + '^!'])
455 return cache[commit]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700456
457
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800458def _check_lines_in_diff(commit, files, check_callable, error_description):
459 """Checks given file for errors via the given check.
460
461 This is a convenience function for common per-line checks. It goes through all
462 files and returns a HookFailure with the error description listing all the
463 failures.
464
465 Args:
466 commit: The commit we're working on.
467 files: The files to check.
468 check_callable: A callable that takes a line and returns True if this line
469 _fails_ the check.
470 error_description: A string describing the error.
471 """
472 errors = []
473 for afile in files:
474 for line_num, line in _get_file_diff(afile, commit):
Bernie Thompson8e26f742020-07-23 14:32:31 -0700475 result = check_callable(line)
476 if result:
477 msg = f'{afile}, line {line_num}'
478 if isinstance(result, str):
479 msg += f': {result}'
480 errors.append(msg)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800481 if errors:
482 return HookFailure(error_description, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400483 return None
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800484
485
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900486def _parse_common_inclusion_options(options):
487 """Parses common hook options for including/excluding files.
488
489 Args:
490 options: Option string list.
491
492 Returns:
493 (included, excluded) where each one is a list of regex strings.
494 """
495 parser = argparse.ArgumentParser()
496 parser.add_argument('--exclude_regex', action='append')
497 parser.add_argument('--include_regex', action='append')
498 opts = parser.parse_args(options)
499 included = opts.include_regex or []
500 excluded = opts.exclude_regex or []
501 return included, excluded
502
503
Ryan Cuiec4d6332011-05-02 14:15:25 -0700504# Common Hooks
505
Ryan Cui1562fb82011-05-09 11:01:31 -0700506
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900507def _check_no_long_lines(_project, commit, options=()):
Mike Frysinger55f85b52014-12-18 14:45:21 -0500508 """Checks there are no lines longer than MAX_LEN in any of the text files."""
Keigo Oka9732e382019-06-28 17:44:59 +0900509 LONG_LINE_OK_PATHS = [
510 # Go has no line length limit.
511 # https://golang.org/doc/effective_go.html#formatting
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400512 r'.*\.go$',
Mike Frysingerf8961942020-05-15 00:36:31 -0400513 # Python does its own long line checks via pylint.
514 r'.*\.py$',
Keigo Oka9732e382019-06-28 17:44:59 +0900515 ]
Mike Frysinger55f85b52014-12-18 14:45:21 -0500516
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900517 DEFAULT_MAX_LENGTHS = [
518 # Java's line length limit is 100 chars.
519 # https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md
520 (r'.*\.java$', 100),
Mike Frysingerf8961942020-05-15 00:36:31 -0400521 # Rust's line length limit is 100 chars.
522 (r'.*\.rs$', 100),
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900523 ]
524
Ryan Cuiec4d6332011-05-02 14:15:25 -0700525 MAX_LEN = 80
526
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900527 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700528 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900529 included + COMMON_INCLUDED_PATHS,
Keigo Oka9732e382019-06-28 17:44:59 +0900530 excluded + COMMON_EXCLUDED_PATHS + LONG_LINE_OK_PATHS)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700531
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900532 errors = []
Ryan Cuiec4d6332011-05-02 14:15:25 -0700533 for afile in files:
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700534 skip_regexps = (
535 r'https?://',
536 r'^#\s*(define|include|import|pragma|if|ifndef|endif)\b',
537 )
538
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900539 max_len = MAX_LEN
540
541 for expr, length in DEFAULT_MAX_LENGTHS:
542 if re.search(expr, afile):
543 max_len = length
544 break
545
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700546 if os.path.basename(afile).startswith('OWNERS'):
547 # File paths can get long, and there's no way to break them up into
548 # multiple lines.
549 skip_regexps += (
550 r'^include\b',
551 r'file:',
552 )
553
554 skip_regexps = [re.compile(x) for x in skip_regexps]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700555 for line_num, line in _get_file_diff(afile, commit):
556 # Allow certain lines to exceed the maxlen rule.
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900557 if len(line) <= max_len or any(x.search(line) for x in skip_regexps):
Jon Salz98255932012-08-18 14:48:02 +0800558 continue
559
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900560 errors.append('%s, line %s, %s chars, over %s chars' %
561 (afile, line_num, len(line), max_len))
Jon Salz98255932012-08-18 14:48:02 +0800562 if len(errors) == 5: # Just show the first 5 errors.
563 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700564
565 if errors:
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900566 msg = 'Found lines longer than the limit (first 5 shown):'
Ryan Cui1562fb82011-05-09 11:01:31 -0700567 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400568 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700569
Ryan Cuiec4d6332011-05-02 14:15:25 -0700570
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900571def _check_no_stray_whitespace(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700572 """Checks that there is no stray whitespace at source lines end."""
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900573 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700574 files = _filter_files(_get_affected_files(commit),
Tomasz Figa375b9622020-09-22 14:25:07 +0000575 included + COMMON_INCLUDED_PATHS + [r'^.*\.md$'],
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900576 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800577 return _check_lines_in_diff(commit, files,
578 lambda line: line.rstrip() != line,
579 'Found line ending with white space in:')
Ryan Cui1562fb82011-05-09 11:01:31 -0700580
Ryan Cuiec4d6332011-05-02 14:15:25 -0700581
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900582def _check_no_tabs(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700583 """Checks there are no unexpanded tabs."""
Mike Frysingercd134512017-10-26 04:36:33 -0400584 # Don't add entire repos here. Update the PRESUBMIT.cfg in each repo instead.
Bob Haarman0dc1f942020-10-03 00:06:59 +0000585 # We only allow known specific filetypes here that show up in all repos.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700586 TAB_OK_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400587 r'.*\.ebuild$',
588 r'.*\.eclass$',
589 r'.*\.go$',
590 r'.*/[M|m]akefile$',
591 r'.*\.mk$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700592 ]
593
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900594 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700595 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900596 included + COMMON_INCLUDED_PATHS,
597 excluded + COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800598 return _check_lines_in_diff(commit, files,
599 lambda line: '\t' in line,
600 'Found a tab character in:')
Ryan Cuiec4d6332011-05-02 14:15:25 -0700601
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800602
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700603def _read_terms_file(terms_file):
604 """Read list of words from file, skipping comments and blank lines."""
605 file_terms = set()
606 for line in osutils.ReadFile(terms_file).splitlines():
607 # Allow comment and blank lines.
608 line = line.split('#', 1)[0]
609 if not line:
610 continue
611 file_terms.add(line)
612 return file_terms
613
614
Bernie Thompson8e26f742020-07-23 14:32:31 -0700615def _check_keywords(_project, commit, options=()):
616 """Checks there are no blocked keywords in commit content."""
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700617 # Read options from override list.
Bernie Thompson8e26f742020-07-23 14:32:31 -0700618 parser = argparse.ArgumentParser()
619 parser.add_argument('--exclude_regex', action='append', default=[])
620 parser.add_argument('--include_regex', action='append', default=[])
621 parser.add_argument('--block', action='append', default=[])
622 parser.add_argument('--unblock', action='append', default=[])
623 opts = parser.parse_args(options)
624
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700625 # Read blocked word list.
626 blocked_terms_file = os.path.join(_get_hooks_dir(), BLOCKED_TERMS_FILE)
627 common_keywords = _read_terms_file(blocked_terms_file)
628
629 # Read unblocked word list. Global list is skipped if local list exists.
630 unblocked_terms_file = os.path.join(_get_hooks_dir(), UNBLOCKED_TERMS_FILE)
631 if os.path.isfile(os.path.join(_project.dir, UNBLOCKED_TERMS_FILE)):
632 unblocked_terms_file = os.path.join(_project.dir, UNBLOCKED_TERMS_FILE)
633 unblocked_words = _read_terms_file(unblocked_terms_file)
634 unblocked_words.update(opts.unblock)
635
Bernie Thompson8e26f742020-07-23 14:32:31 -0700636 keywords = set(common_keywords | set(opts.block))
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700637 keywords = sorted(keywords - unblocked_words)
Mike Frysinger6140f572020-09-10 04:52:46 -0400638 files = _filter_files(
639 _get_affected_files(commit),
Tomasz Figa375b9622020-09-22 14:25:07 +0000640 opts.include_regex + COMMON_INCLUDED_PATHS + [r'^.*\.md$'],
Mike Frysinger6140f572020-09-10 04:52:46 -0400641 opts.exclude_regex + COMMON_EXCLUDED_PATHS)
Bernie Thompson8e26f742020-07-23 14:32:31 -0700642 errors = []
643
644 def _check_line(line):
Laurent Chavey434af9a2020-09-28 22:25:16 +0900645 # Store information about each span matching blocking regex.
646 # to match unblocked regex with blocked reg ex match.
647 # [{'span':re.span, - overlap of matching regex in line
648 # 'group':re.group, - matching term
649 # 'blocked':bool, - True: matching blocked, False: matching unblocked
650 # 'keyword':regex, - block regex
651 # }, ...]
652 blocked_span = []
653 # Store information about each span matching unblocking regex.
654 # [re.span, ...]
655 unblocked_span = []
656
Bernie Thompson8e26f742020-07-23 14:32:31 -0700657 for word in keywords:
Laurent Chavey434af9a2020-09-28 22:25:16 +0900658 for match in re.finditer(word, line, flags=re.I):
659 blocked_span.append({'span' : match.span(),
660 'group' : match.group(0),
661 'blocked' : True,
662 'keyword' : word})
663
664 for unblocked in unblocked_words:
665 for match in re.finditer(unblocked, line, flags=re.I):
666 unblocked_span.append(match.span())
667
668 # Unblock terms that are superset of blocked terms:
669 # blocked := "this.?word"
670 # unblocked := "\.this.?word"
671 # "this line is blocked because of this1word"
672 # "this line is unblocked because of thenew.this1word"
673 #
674 for b in blocked_span:
675 for ub in unblocked_span:
676 if ub[0] <= b['span'][0] and ub[1] >= b['span'][1]:
677 b['blocked'] = False
678 if b['blocked']:
679 return f'Matched "{b["group"]}" with regex of "{b["keyword"]}"'
Bernie Thompson8e26f742020-07-23 14:32:31 -0700680 return False
681
682 diff_errors = _check_lines_in_diff(commit, files, _check_line,
683 'Found a blocked keyword in:')
684 if diff_errors:
685 errors.append(diff_errors)
686
687 line_num = 1
688 commit_desc_errors = []
689 for line in _get_commit_desc(commit).splitlines():
690 result = _check_line(line)
691 if result:
692 commit_desc_errors.append('Commit message, line %s: %s' %
693 (line_num, result))
694 line_num += 1
695 if commit_desc_errors:
696 errors.append(HookFailure('Found a blocked keyword in:',
697 commit_desc_errors))
698 return errors
699
700
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900701def _check_tabbed_indents(_project, commit, options=()):
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800702 """Checks that indents use tabs only."""
703 TABS_REQUIRED_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400704 r'.*\.ebuild$',
705 r'.*\.eclass$',
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800706 ]
707 LEADING_SPACE_RE = re.compile('[\t]* ')
708
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900709 included, excluded = _parse_common_inclusion_options(options)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800710 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900711 included + TABS_REQUIRED_PATHS,
712 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800713 return _check_lines_in_diff(
714 commit, files,
715 lambda line: LEADING_SPACE_RE.match(line) is not None,
716 'Found a space in indentation (must be all tabs):')
Ryan Cui1562fb82011-05-09 11:01:31 -0700717
Ryan Cuiec4d6332011-05-02 14:15:25 -0700718
LaMont Jones872fe762020-02-10 15:36:14 -0700719def _check_gofmt(_project, commit, options=()):
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700720 """Checks that Go files are formatted with gofmt."""
LaMont Jones872fe762020-02-10 15:36:14 -0700721 included, excluded = _parse_common_inclusion_options(options)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700722 errors = []
723 files = _filter_files(_get_affected_files(commit, relative=True),
LaMont Jones872fe762020-02-10 15:36:14 -0700724 included + [r'\.go$'],
725 excluded)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700726
727 for gofile in files:
728 contents = _get_file_content(gofile, commit)
Mike Frysingeraa7dc942019-09-25 00:07:24 -0400729 output = _run_command(cmd=['gofmt', '-l'], input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500730 stderr=subprocess.STDOUT)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700731 if output:
732 errors.append(gofile)
733 if errors:
734 return HookFailure('Files not formatted with gofmt:', errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400735 return None
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700736
737
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600738def _check_rustfmt(_project, commit):
739 """Checks that Rust files are formatted with rustfmt."""
740 errors = []
741 files = _filter_files(_get_affected_files(commit, relative=True),
742 [r'\.rs$'])
743
744 for rustfile in files:
745 contents = _get_file_content(rustfile, commit)
Chirantan Ekbote1da56d52020-07-13 17:35:35 +0900746 output = _run_command(cmd=['rustfmt', '--edition', '2018'],
747 input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500748 stderr=subprocess.STDOUT)
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600749 if output != contents:
750 errors.append(rustfile)
751 if errors:
752 return HookFailure('Files not formatted with rustfmt: '
753 "(run 'cargo fmt' to fix)", errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400754 return None
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600755
756
Keiichi Watanabe6ab73fd2020-07-14 23:42:02 +0900757class CargoClippyArgumentParserError(Exception):
758 """An exception indicating an invalid check_cargo_clippy option."""
759
760
761class CargoClippyArgumentParser(argparse.ArgumentParser):
762 """A argument parser for check_cargo_clippy."""
763
764 def error(self, message):
765 raise CargoClippyArgumentParserError(message)
766
767
768# A cargo project in which clippy runs.
769ClippyProject = collections.namedtuple('ClippyProject', ('root', 'script'))
770
771
772class _AddClippyProjectAction(argparse.Action):
773 """A callback that adds a cargo clippy setting.
774
775 It accepts a value which is in the form of "ROOT[:SCRIPT]".
776 """
777
778 def __call__(self, parser, namespace, values, option_string=None):
779 if getattr(namespace, self.dest, None) is None:
780 setattr(namespace, self.dest, [])
781 spec = values.split(':', 1)
782 if len(spec) == 1:
783 spec += [None]
784
785 if spec[0].startswith('/'):
786 raise CargoClippyArgumentParserError('root path must not start with "/"'
787 f' but "{spec[0]}"')
788
789 clippy = ClippyProject(root=spec[0], script=spec[1])
790 getattr(namespace, self.dest).append(clippy)
791
792
793def _get_cargo_clippy_parser():
794 """Creates a parser for check_cargo_clippy options."""
795
796 parser = CargoClippyArgumentParser()
797 parser.add_argument('--project', action=_AddClippyProjectAction, default=[])
798
799 return parser
800
801
802def _check_cargo_clippy(project, commit, options=()):
803 """Checks that a change doesn't produce cargo-clippy errors."""
804
805 options = list(options)
806 if not options:
807 return []
808 parser = _get_cargo_clippy_parser()
809
810 try:
811 opts = parser.parse_args(options)
812 except CargoClippyArgumentParserError as e:
813 return [HookFailure('invalid check_cargo_clippy option is given.'
814 f' Please check PRESUBMIT.cfg is correct: {e}')]
815 files = _get_affected_files(commit)
816
817 errors = []
818 for clippy in opts.project:
819 root = os.path.normpath(os.path.join(project.dir, clippy.root))
820
821 # Check if any file under `root` was modified.
822 modified = False
823 for f in files:
824 if f.startswith(root):
825 modified = True
826 break
827 if not modified:
828 continue
829
830 # Clean cargo's cache when we run clippy for this `root` for the first time.
831 # We don't want to clean the cache between commits to save time when
832 # multiple commits are checked.
833 if root not in _check_cargo_clippy.cleaned_root:
834 _run_command(['cargo', 'clean',
835 f'--manifest-path={root}/Cargo.toml'],
836 stderr=subprocess.STDOUT)
837 _check_cargo_clippy.cleaned_root.add(root)
838
839 cmd = ['cargo', 'clippy', '--all-features', '--all-targets',
840 f'--manifest-path={root}/Cargo.toml',
841 '--', '-D', 'warnings']
842 # Overwrite the clippy command if a project-specific script is specified.
843 if clippy.script:
844 cmd = [os.path.join(project.dir, clippy.script)]
845
846 output = _run_command(cmd, stderr=subprocess.STDOUT)
847 error = re.search(r'^error: ', output, flags=re.MULTILINE)
848 if error:
849 msg = output[error.start():]
850 errors.append(HookFailure(msg))
851
852 return errors
853
854
855# Stores cargo projects in which `cargo clean` ran.
856_check_cargo_clippy.cleaned_root = set()
857
858
Mike Frysingerae409522014-02-01 03:16:11 -0500859def _check_change_has_test_field(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700860 """Check for a non-empty 'TEST=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500861 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700862
Cheng Yuehb707c522020-01-02 14:06:59 +0800863 if not re.search(TEST_FIELD_RE, _get_commit_desc(commit)):
Mike Frysingered9b2a02019-12-12 18:52:32 -0500864 msg = ('Changelist description needs TEST field (after first line)\n%s' %
865 (SEE_ALSO,))
Ryan Cui1562fb82011-05-09 11:01:31 -0700866 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400867 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700868
Ryan Cuiec4d6332011-05-02 14:15:25 -0700869
Mike Frysingerae409522014-02-01 03:16:11 -0500870def _check_change_has_valid_cq_depend(_project, commit):
Jason D. Clinton299e3222019-05-23 09:42:03 -0600871 """Check for a correctly formatted Cq-Depend field in the commit message."""
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700872 desc = _get_commit_desc(commit)
Jason D. Clinton299e3222019-05-23 09:42:03 -0600873 msg = 'Changelist has invalid Cq-Depend target.'
874 example = 'Example: Cq-Depend: chromium:1234, chrome-internal:2345'
David Jamesc3b68b32013-04-03 09:17:03 -0700875 try:
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700876 patch.GetPaladinDeps(desc)
David Jamesc3b68b32013-04-03 09:17:03 -0700877 except ValueError as ex:
878 return HookFailure(msg, [example, str(ex)])
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700879 # Check that Cq-Depend is in the same paragraph as Change-Id.
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500880 msg = 'Cq-Depend is not in the same paragraph as Change-Id.'
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700881 paragraphs = desc.split('\n\n')
882 for paragraph in paragraphs:
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500883 if (re.search(r'^Cq-Depend:', paragraph, re.M) and not
884 re.search('^Change-Id:', paragraph, re.M)):
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700885 return HookFailure(msg)
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500886
887 # We no longer support CQ-DEPEND= lines.
888 if re.search(r'^CQ-DEPEND[=:]', desc, re.M):
889 return HookFailure(
890 'CQ-DEPEND= is no longer supported. Please see:\n'
891 'https://chromium.googlesource.com/chromiumos/docs/+/HEAD/'
892 'contributing.md#CQ-DEPEND')
893
Mike Frysinger8cf80812019-09-16 23:49:29 -0400894 return None
David Jamesc3b68b32013-04-03 09:17:03 -0700895
896
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800897def _check_change_is_contribution(_project, commit):
898 """Check that the change is a contribution."""
899 NO_CONTRIB = 'not a contribution'
900 if NO_CONTRIB in _get_commit_desc(commit).lower():
901 msg = ('Changelist is not a contribution, this cannot be accepted.\n'
902 'Please remove the "%s" text from the commit message.') % NO_CONTRIB
903 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400904 return None
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800905
906
Alex Deymo643ac4c2015-09-03 10:40:50 -0700907def _check_change_has_bug_field(project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700908 """Check for a correctly formatted 'BUG=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500909 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
910
David James5c0073d2013-04-03 08:48:52 -0700911 OLD_BUG_RE = r'\nBUG=.*chromium-os'
912 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
913 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
914 'the chromium tracker in your BUG= line now.')
915 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700916
Alex Deymo643ac4c2015-09-03 10:40:50 -0700917 # Android internal and external projects use "Bug: " to track bugs in
918 # buganizer.
919 BUG_COLON_REMOTES = (
920 'aosp',
921 'goog',
922 )
923 if project.remote in BUG_COLON_REMOTES:
924 BUG_RE = r'\nBug: ?([Nn]one|\d+)'
925 if not re.search(BUG_RE, _get_commit_desc(commit)):
926 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500927 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700928 'Bug: 9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500929 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700930 return HookFailure(msg)
931 else:
Jorge Lucangeli Obesdce214e2017-10-25 15:04:39 -0400932 BUG_RE = r'\nBUG=([Nn]one|(chromium|b):\d+)'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700933 if not re.search(BUG_RE, _get_commit_desc(commit)):
934 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500935 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700936 'BUG=chromium:9999 (for public tracker)\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700937 'BUG=b:9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500938 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700939 return HookFailure(msg)
Ryan Cui1562fb82011-05-09 11:01:31 -0700940
Cheng Yuehb707c522020-01-02 14:06:59 +0800941 TEST_BEFORE_BUG_RE = TEST_FIELD_RE + r'.*' + BUG_RE
942
943 if re.search(TEST_BEFORE_BUG_RE, _get_commit_desc(commit), re.DOTALL):
944 msg = ('The BUG field must come before the TEST field.\n%s' %
945 (SEE_ALSO,))
946 return HookFailure(msg)
947
Mike Frysinger8cf80812019-09-16 23:49:29 -0400948 return None
949
Ryan Cuiec4d6332011-05-02 14:15:25 -0700950
Jack Neus8edbf642019-07-10 16:08:31 -0600951def _check_change_no_include_oem(project, commit):
952 """Check that the change does not reference OEMs."""
953 ALLOWLIST = {
954 'chromiumos/platform/ec',
955 # Used by unit tests.
956 'project',
957 }
958 if project.name not in ALLOWLIST:
959 return None
960
Mike Frysingerbb34a222019-07-31 14:40:46 -0400961 TAGS = {
Jack Neus8edbf642019-07-10 16:08:31 -0600962 'Reviewed-on',
963 'Reviewed-by',
964 'Signed-off-by',
965 'Commit-Ready',
966 'Tested-by',
967 'Commit-Queue',
Jack Neus8edbf642019-07-10 16:08:31 -0600968 'Acked-by',
969 'Modified-by',
970 'CC',
971 'Suggested-by',
972 'Reported-by',
973 'Acked-for-chrome-by',
LaMont Jones237f3ef2020-01-22 10:40:52 -0700974 'Cq-Cl-Tag',
LaMont Jonesfb5e8bf2020-03-03 12:50:06 -0700975 'Cq-Include-Trybots',
Mike Frysingerbb34a222019-07-31 14:40:46 -0400976 }
Jack Neus8edbf642019-07-10 16:08:31 -0600977
978 # Ignore tags, which could reasonably contain OEM names
979 # (e.g. Reviewed-by: foo@oem.corp-partner.google.com).
Jack Neus8edbf642019-07-10 16:08:31 -0600980 commit_message = ' '.join(
Mike Frysingerbb34a222019-07-31 14:40:46 -0400981 x for x in _get_commit_desc(commit).splitlines()
982 if ':' not in x or x.split(':', 1)[0] not in TAGS)
983
Jack Neus8edbf642019-07-10 16:08:31 -0600984 commit_message = re.sub(r'[\s_-]+', ' ', commit_message)
985
986 # Exercise caution when expanding these lists. Adding a name
987 # could indicate a new relationship with a company!
988 OEMS = ['hp', 'hewlett packard', 'dell', 'lenovo', 'acer', 'asus', 'samsung']
989 ODMS = [
990 'bitland', 'compal', 'haier', 'huaqin', 'inventec', 'lg', 'pegatron',
991 'pegatron(ems)', 'quanta', 'samsung', 'wistron'
992 ]
993
994 for name_type, name_list in [('OEM', OEMS), ('ODM', ODMS)]:
995 # Construct regex
996 name_re = r'\b(%s)\b' % '|'.join([re.escape(x) for x in name_list])
997 matches = [x[0] for x in re.findall(name_re, commit_message, re.IGNORECASE)]
Mike Frysingere52b1bc2019-09-16 23:45:41 -0400998 if matches:
Jack Neus8edbf642019-07-10 16:08:31 -0600999 # If there's a match, throw an error.
1000 error_msg = ('Changelist description contains the name of an'
1001 ' %s: "%s".' % (name_type, '","'.join(matches)))
1002 return HookFailure(error_msg)
1003
Mike Frysinger8cf80812019-09-16 23:49:29 -04001004 return None
1005
Jack Neus8edbf642019-07-10 16:08:31 -06001006
Mike Frysinger292b45d2014-11-25 01:17:10 -05001007def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -07001008 """Check that we're not missing a revbump of an ebuild in the given commit.
1009
1010 If the given commit touches files in a directory that has ebuilds somewhere
1011 up the directory hierarchy, it's very likely that we need an ebuild revbump
1012 in order for those changes to take effect.
1013
1014 It's not totally trivial to detect a revbump, so at least detect that an
1015 ebuild with a revision number in it was touched. This should handle the
1016 common case where we use a symlink to do the revbump.
1017
1018 TODO: it would be nice to enhance this hook to:
1019 * Handle cases where people revbump with a slightly different syntax. I see
1020 one ebuild (puppy) that revbumps with _pN. This is a false positive.
1021 * Catches cases where people aren't using symlinks for revbumps. If they
1022 edit a revisioned file directly (and are expected to rename it for revbump)
1023 we'll miss that. Perhaps we could detect that the file touched is a
1024 symlink?
1025
1026 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
1027 still better off than without this check.
1028
1029 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001030 project: The Project to look at
Doug Anderson42b8a052013-06-26 10:45:36 -07001031 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -05001032 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -07001033
1034 Returns:
1035 A HookFailure or None.
1036 """
Mike Frysinger011af942014-01-17 16:12:22 -05001037 # If this is the portage-stable overlay, then ignore the check. It's rare
1038 # that we're doing anything other than importing files from upstream, so
1039 # forcing a rev bump makes no sense.
Bob Haarman0dc1f942020-10-03 00:06:59 +00001040 allowlist = (
Mike Frysinger011af942014-01-17 16:12:22 -05001041 'chromiumos/overlays/portage-stable',
1042 )
Bob Haarman0dc1f942020-10-03 00:06:59 +00001043 if project.name in allowlist:
Mike Frysinger011af942014-01-17 16:12:22 -05001044 return None
1045
Mike Frysinger292b45d2014-11-25 01:17:10 -05001046 def FinalName(obj):
1047 # If the file is being deleted, then the dst_file is not set.
1048 if obj.dst_file is None:
1049 return obj.src_file
1050 else:
1051 return obj.dst_file
1052
Stephen Boyd6bf5ea82020-10-15 00:02:07 -07001053 def AllowedPath(obj):
Mike Frysinger78dbc242020-11-27 16:46:39 -05001054 allowed_files = {
1055 'ChangeLog', 'Manifest', 'metadata.xml', 'OWNERS', 'README.md',
1056 }
Stephen Boyd6bf5ea82020-10-15 00:02:07 -07001057 allowed_directories = {'profiles'}
1058
1059 affected = pathlib.Path(FinalName(obj))
1060 if affected.name in allowed_files:
1061 return True
1062
1063 for directory in allowed_directories:
1064 if directory in affected.parts:
1065 return True
1066
1067 return False
1068
Mike Frysinger292b45d2014-11-25 01:17:10 -05001069 affected_path_objs = _get_affected_files(
1070 commit, include_deletes=True, include_symlinks=True, relative=True,
1071 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -07001072
Stephen Boyd6bf5ea82020-10-15 00:02:07 -07001073 # Don't yell about changes to allowed files or directories...
Mike Frysinger292b45d2014-11-25 01:17:10 -05001074 affected_path_objs = [x for x in affected_path_objs
Stephen Boyd6bf5ea82020-10-15 00:02:07 -07001075 if not AllowedPath(x)]
Mike Frysinger292b45d2014-11-25 01:17:10 -05001076 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -07001077 return None
1078
1079 # If we've touched any file named with a -rN.ebuild then we'll say we're
1080 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -05001081 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
1082 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -07001083 if touched_revved_ebuild:
1084 return None
1085
Mike Frysinger292b45d2014-11-25 01:17:10 -05001086 # If we're creating new ebuilds from scratch, then we don't need an uprev.
1087 # Find all the dirs that new ebuilds and ignore their files/.
1088 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
1089 if FinalName(x).endswith('.ebuild') and x.status == 'A']
1090 affected_path_objs = [obj for obj in affected_path_objs
1091 if not any(FinalName(obj).startswith(x)
1092 for x in ebuild_dirs)]
1093 if not affected_path_objs:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001094 return None
Mike Frysinger292b45d2014-11-25 01:17:10 -05001095
Doug Anderson42b8a052013-06-26 10:45:36 -07001096 # We want to examine the current contents of all directories that are parents
1097 # of files that were touched (up to the top of the project).
1098 #
1099 # ...note: we use the current directory contents even though it may have
1100 # changed since the commit we're looking at. This is just a heuristic after
1101 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -05001102 if project_top is None:
1103 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -07001104 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -05001105 for obj in affected_path_objs:
1106 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -07001107 while os.path.exists(path) and not os.path.samefile(path, project_top):
1108 dirs_to_check.add(path)
1109 path = os.path.dirname(path)
1110
1111 # Look through each directory. If it's got an ebuild in it then we'll
1112 # consider this as a case when we need a revbump.
Gwendal Grignoua3086c32014-12-09 11:17:22 -08001113 affected_paths = set(os.path.join(project_top, FinalName(x))
1114 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -07001115 for dir_path in dirs_to_check:
1116 contents = os.listdir(dir_path)
1117 ebuilds = [os.path.join(dir_path, path)
1118 for path in contents if path.endswith('.ebuild')]
1119 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
1120
C Shapiroae157ae2017-09-18 16:24:03 -06001121 affected_paths_under_9999_ebuilds = set()
1122 for affected_path in affected_paths:
1123 for ebuild_9999 in ebuilds_9999:
1124 ebuild_dir = os.path.dirname(ebuild_9999)
1125 if affected_path.startswith(ebuild_dir):
1126 affected_paths_under_9999_ebuilds.add(affected_path)
1127
1128 # If every file changed exists under a 9999 ebuild, then skip
1129 if len(affected_paths_under_9999_ebuilds) == len(affected_paths):
1130 continue
1131
Doug Anderson42b8a052013-06-26 10:45:36 -07001132 # If the -9999.ebuild file was touched the bot will uprev for us.
1133 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -05001134 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -07001135 continue
1136
1137 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -05001138 return HookFailure('Changelist probably needs a revbump of an ebuild, '
1139 'or a -r1.ebuild symlink if this is a new ebuild:\n'
1140 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -07001141
1142 return None
1143
1144
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001145def _check_ebuild_eapi(project, commit):
Mike Frysinger948284a2018-02-01 15:22:56 -05001146 """Make sure we have people use EAPI=5 or newer with custom ebuilds.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001147
1148 We want to get away from older EAPI's as it makes life confusing and they
1149 have less builtin error checking.
1150
1151 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001152 project: The Project to look at
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001153 commit: The commit to look at
1154
1155 Returns:
1156 A HookFailure or None.
1157 """
1158 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -05001159 # that we're doing anything other than importing files from upstream, and
1160 # we shouldn't be rewriting things fundamentally anyways.
Bob Haarman0dc1f942020-10-03 00:06:59 +00001161 allowlist = (
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001162 'chromiumos/overlays/portage-stable',
1163 )
Bob Haarman0dc1f942020-10-03 00:06:59 +00001164 if project.name in allowlist:
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001165 return None
1166
Mike Frysinger948284a2018-02-01 15:22:56 -05001167 BAD_EAPIS = ('0', '1', '2', '3', '4')
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001168
1169 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
1170
1171 ebuilds_re = [r'\.ebuild$']
1172 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1173 ebuilds_re)
1174 bad_ebuilds = []
1175
1176 for ebuild in ebuilds:
1177 # If the ebuild does not specify an EAPI, it defaults to 0.
1178 eapi = '0'
1179
1180 lines = _get_file_content(ebuild, commit).splitlines()
1181 if len(lines) == 1:
1182 # This is most likely a symlink, so skip it entirely.
1183 continue
1184
1185 for line in lines:
1186 m = get_eapi.match(line)
1187 if m:
1188 # Once we hit the first EAPI line in this ebuild, stop processing.
1189 # The spec requires that there only be one and it be first, so
1190 # checking all possible values is pointless. We also assume that
1191 # it's "the" EAPI line and not something in the middle of a heredoc.
1192 eapi = m.group(1)
1193 break
1194
1195 if eapi in BAD_EAPIS:
1196 bad_ebuilds.append((ebuild, eapi))
1197
1198 if bad_ebuilds:
1199 # pylint: disable=C0301
Mike Frysingerc6114f42020-05-15 00:55:05 -04001200 url = 'https://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001201 # pylint: enable=C0301
1202 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -05001203 'These ebuilds are using old EAPIs. If these are imported from\n'
1204 'Gentoo, then you may ignore and upload once with the --no-verify\n'
Mike Frysingerc6114f42020-05-15 00:55:05 -04001205 'flag. Otherwise, please update to 7 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001206 '\t%s\n'
1207 'See this guide for more details:\n%s\n' %
1208 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
1209
Mike Frysinger8cf80812019-09-16 23:49:29 -04001210 return None
1211
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001212
Mike Frysinger89bdb852014-02-01 05:26:26 -05001213def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -05001214 """Make sure we use the new style KEYWORDS when possible in ebuilds.
1215
1216 If an ebuild generally does not care about the arch it is running on, then
1217 ebuilds should flag it with one of:
1218 KEYWORDS="*" # A stable ebuild.
1219 KEYWORDS="~*" # An unstable ebuild.
1220 KEYWORDS="-* ..." # Is known to only work on specific arches.
1221
1222 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001223 project: The Project to look at
Mike Frysingerc51ece72014-01-17 16:23:40 -05001224 commit: The commit to look at
1225
1226 Returns:
1227 A HookFailure or None.
1228 """
Bob Haarman0dc1f942020-10-03 00:06:59 +00001229 ALLOWLIST = set(('*', '-*', '~*'))
Mike Frysingerc51ece72014-01-17 16:23:40 -05001230
1231 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
1232
Mike Frysinger89bdb852014-02-01 05:26:26 -05001233 ebuilds_re = [r'\.ebuild$']
1234 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1235 ebuilds_re)
1236
Mike Frysinger8d42d742014-09-22 15:50:21 -04001237 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -05001238 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -04001239 # We get the full content rather than a diff as the latter does not work
1240 # on new files (like when adding new ebuilds).
1241 lines = _get_file_content(ebuild, commit).splitlines()
1242 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -05001243 m = get_keywords.match(line)
1244 if m:
1245 keywords = set(m.group(1).split())
Bob Haarman0dc1f942020-10-03 00:06:59 +00001246 if not keywords or ALLOWLIST - keywords != ALLOWLIST:
Mike Frysingerc51ece72014-01-17 16:23:40 -05001247 continue
1248
Mike Frysinger8d42d742014-09-22 15:50:21 -04001249 bad_ebuilds.append(ebuild)
1250
1251 if bad_ebuilds:
1252 return HookFailure(
1253 '%s\n'
1254 'Please update KEYWORDS to use a glob:\n'
1255 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
1256 ' KEYWORDS="*"\n'
1257 'If the ebuild should be marked unstable (normal for '
1258 'cros-workon / 9999 ebuilds):\n'
1259 ' KEYWORDS="~*"\n'
Mike Frysingerde8efea2015-05-17 03:42:26 -04001260 'If the ebuild needs to be marked for only specific arches, '
Mike Frysinger8d42d742014-09-22 15:50:21 -04001261 'then use -* like so:\n'
1262 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -05001263
Mike Frysinger8cf80812019-09-16 23:49:29 -04001264 return None
1265
Mike Frysingerc51ece72014-01-17 16:23:40 -05001266
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001267def _check_ebuild_licenses(_project, commit):
1268 """Check if the LICENSE field in the ebuild is correct."""
Brian Norris7a610e82016-02-17 12:24:54 -08001269 affected_paths = _get_affected_files(commit, relative=True)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001270 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
1271
1272 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -08001273 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001274
1275 for ebuild in touched_ebuilds:
Alex Kleinb5953522018-08-03 11:44:21 -06001276 # e.g. path/to/overlay/category/package/package.ebuild -> path/to/overlay
1277 overlay_path = os.sep.join(ebuild.split(os.sep)[:-3])
1278
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001279 try:
Brian Norris7a610e82016-02-17 12:24:54 -08001280 ebuild_content = _get_file_content(ebuild, commit)
Alex Kleinb5953522018-08-03 11:44:21 -06001281 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content,
1282 overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001283 except ValueError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001284 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001285
Sergey Frolovc1bd8782021-01-20 19:35:44 -07001286 # Virtual packages must use "metapackage" license.
1287 if ebuild.split('/')[-3] == 'virtual':
1288 if license_types != ['metapackage']:
1289 return HookFailure('Virtual package must use LICENSE="metapackage".',
1290 [ebuild])
1291
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001292 # Also ignore licenses ending with '?'
1293 for license_type in [x for x in license_types
1294 if x not in LICENSES_IGNORE and not x.endswith('?')]:
1295 try:
Alex Kleinb5953522018-08-03 11:44:21 -06001296 licenses_lib.Licensing.FindLicenseType(license_type,
1297 overlay_path=overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001298 except AssertionError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001299 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001300
Mike Frysinger8cf80812019-09-16 23:49:29 -04001301 return None
1302
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001303
Mike Frysingerd9ed85f2021-02-03 12:38:24 -05001304def _check_ebuild_owners(project, commit):
Mike Frysingerb04778f2020-11-30 02:41:14 -05001305 """Require all new packages include an OWNERS file."""
1306 # Look for all adds/removes since we're going to ignore changes that only
1307 # update a package. We only want to flag new package imports for now.
1308 affected_files_objs = _get_affected_files(
1309 commit, include_deletes=True, include_symlinks=True, relative=True,
1310 full_details=True)
1311
1312 # If this CL doesn't include any ebuilds, don't bother complaining.
1313 new_ebuilds = [x for x in affected_files_objs
1314 if x.status == 'A' and x.src_file.endswith('.ebuild')]
1315 if not new_ebuilds:
1316 return None
1317
1318 # Check each package dir.
1319 packages_missing_owners = []
1320 package_dirs = sorted(set(os.path.dirname(x.src_file) for x in new_ebuilds))
1321 for package_dir in package_dirs:
1322 package_files = [
1323 x for x in affected_files_objs
1324 if (x.src_file and x.src_file.startswith(f'{package_dir}/')) or
1325 (x.dst_file and x.dst_file.startswith(f'{package_dir}/'))]
1326
1327 # Only complain about new ebuilds, not existing ones. For now.
1328 # We'll assume that "all adds" means it's a new package.
1329 if any(x for x in package_files if x.status != 'A'):
1330 continue
1331
1332 # See if there's an OWNERS file in there already.
Mike Frysingerd9ed85f2021-02-03 12:38:24 -05001333 data = _get_file_content(os.path.join(package_dir, 'OWNERS'), commit)
1334 if not data:
1335 # Allow specific overlays to declare OWNERS for all packages.
1336 if (project.name == 'chromiumos/overlays/board-overlays' or
1337 re.match(r'^chromeos/overlays/(baseboard|chipset|project|overlay)-',
1338 project.name)):
1339 data = _get_file_content(os.path.join(os.path.dirname(os.path.dirname(
1340 package_dir)), 'OWNERS'), commit)
1341
1342 if not data:
1343 packages_missing_owners.append(package_dir)
1344 continue
1345
1346 # Require specific people and not just *.
1347 lines = {x for x in data.splitlines() if x.split('#', 1)[0].strip()}
1348 if not lines - {'*'}:
Mike Frysingerb04778f2020-11-30 02:41:14 -05001349 packages_missing_owners.append(package_dir)
1350
1351 if packages_missing_owners:
1352 return HookFailure(
Mike Frysingerd9ed85f2021-02-03 12:38:24 -05001353 'All new packages must have an OWNERS file filled out.',
Mike Frysingerb04778f2020-11-30 02:41:14 -05001354 packages_missing_owners)
1355
1356 return None
1357
1358
Mike Frysinger6ee76b82020-11-20 01:16:06 -05001359def _check_ebuild_r0(_project, commit):
1360 """Do not allow ebuilds to end with -r0 versions."""
1361 ebuilds = _filter_files(
1362 _get_affected_files(commit, include_symlinks=True, relative=True),
1363 (r'-r0\.ebuild$',))
1364 if ebuilds:
1365 return HookFailure(
1366 'The -r0 in ebuilds is redundant and confusing. Simply remove it.\n'
1367 'For example: git mv foo-1.0-r0.ebuild foo-1.0.ebuild',
1368 ebuilds)
1369
1370 return None
1371
1372
Mike Frysingercd363c82014-02-01 05:20:18 -05001373def _check_ebuild_virtual_pv(project, commit):
1374 """Enforce the virtual PV policies."""
1375 # If this is the portage-stable overlay, then ignore the check.
1376 # We want to import virtuals as-is from upstream Gentoo.
Bob Haarman0dc1f942020-10-03 00:06:59 +00001377 allowlist = (
Mike Frysingercd363c82014-02-01 05:20:18 -05001378 'chromiumos/overlays/portage-stable',
1379 )
Bob Haarman0dc1f942020-10-03 00:06:59 +00001380 if project.name in allowlist:
Mike Frysingercd363c82014-02-01 05:20:18 -05001381 return None
1382
1383 # We assume the repo name is the same as the dir name on disk.
1384 # It would be dumb to not have them match though.
Alex Deymo643ac4c2015-09-03 10:40:50 -07001385 project_base = os.path.basename(project.name)
Mike Frysingercd363c82014-02-01 05:20:18 -05001386
1387 is_variant = lambda x: x.startswith('overlay-variant-')
1388 is_board = lambda x: x.startswith('overlay-')
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001389 is_baseboard = lambda x: x.startswith('baseboard-')
1390 is_chipset = lambda x: x.startswith('chipset-')
1391 is_project = lambda x: x.startswith('project-')
Mike Frysingercd363c82014-02-01 05:20:18 -05001392 is_private = lambda x: x.endswith('-private')
1393
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001394 is_special_overlay = lambda x: (is_board(x) or is_chipset(x) or
1395 is_baseboard(x) or is_project(x))
1396
Mike Frysingercd363c82014-02-01 05:20:18 -05001397 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
1398
1399 ebuilds_re = [r'\.ebuild$']
1400 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1401 ebuilds_re)
1402 bad_ebuilds = []
1403
1404 for ebuild in ebuilds:
1405 m = get_pv.match(ebuild)
1406 if m:
1407 overlay = m.group(1)
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001408 if not overlay or not is_special_overlay(overlay):
Alex Deymo643ac4c2015-09-03 10:40:50 -07001409 overlay = project_base
Mike Frysingercd363c82014-02-01 05:20:18 -05001410
1411 pv = m.group(3).split('-', 1)[0]
1412
Bernie Thompsone5ee1822016-01-12 14:22:23 -08001413 # Virtual versions >= 4 are special cases used above the standard
1414 # versioning structure, e.g. if one has a board inheriting a board.
Julius Werner0299a2b2020-07-31 18:20:43 -07001415 if pv[0] >= '4':
Bernie Thompsone5ee1822016-01-12 14:22:23 -08001416 want_pv = pv
Mike Frysingercd363c82014-02-01 05:20:18 -05001417 elif is_board(overlay):
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001418 if is_private(overlay):
1419 want_pv = '3.5' if is_variant(overlay) else '3'
1420 elif is_board(overlay):
1421 want_pv = '2.5' if is_variant(overlay) else '2'
1422 elif is_baseboard(overlay):
Julius Werner0299a2b2020-07-31 18:20:43 -07001423 want_pv = '1.9.5' if is_private(overlay) else '1.9'
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001424 elif is_chipset(overlay):
Julius Werner0299a2b2020-07-31 18:20:43 -07001425 want_pv = '1.8.5' if is_private(overlay) else '1.8'
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001426 elif is_project(overlay):
1427 want_pv = '1.7' if is_private(overlay) else '1.5'
Mike Frysingercd363c82014-02-01 05:20:18 -05001428 else:
1429 want_pv = '1'
1430
1431 if pv != want_pv:
1432 bad_ebuilds.append((ebuild, pv, want_pv))
1433
1434 if bad_ebuilds:
1435 # pylint: disable=C0301
1436 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
1437 # pylint: enable=C0301
1438 return HookFailure(
1439 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
1440 '\t%s\n'
1441 'If this is an upstream Gentoo virtual, then you may ignore this\n'
1442 'check (and re-run w/--no-verify). Otherwise, please see this\n'
1443 'page for more details:\n%s\n' %
1444 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
1445 for x in bad_ebuilds]), url))
1446
Mike Frysinger8cf80812019-09-16 23:49:29 -04001447 return None
1448
Mike Frysingercd363c82014-02-01 05:20:18 -05001449
Daniel Erat9d203ff2015-02-17 10:12:21 -07001450def _check_portage_make_use_var(_project, commit):
1451 """Verify that $USE is set correctly in make.conf and make.defaults."""
1452 files = _filter_files(_get_affected_files(commit, relative=True),
1453 [r'(^|/)make.(conf|defaults)$'])
1454
1455 errors = []
1456 for path in files:
1457 basename = os.path.basename(path)
1458
1459 # Has a USE= line already been encountered in this file?
1460 saw_use = False
1461
1462 for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1):
1463 if not line.startswith('USE='):
1464 continue
1465
1466 preserves_use = '${USE}' in line or '$USE' in line
1467
1468 if (basename == 'make.conf' or
1469 (basename == 'make.defaults' and saw_use)) and not preserves_use:
1470 errors.append('%s:%d: missing ${USE}' % (path, i))
1471 elif basename == 'make.defaults' and not saw_use and preserves_use:
1472 errors.append('%s:%d: ${USE} referenced in initial declaration' %
1473 (path, i))
1474
1475 saw_use = True
1476
1477 if errors:
1478 return HookFailure(
1479 'One or more Portage make files appear to set USE incorrectly.\n'
1480 '\n'
1481 'All USE assignments in make.conf and all assignments after the\n'
1482 'initial declaration in make.defaults should contain "${USE}" to\n'
1483 'preserve previously-set flags.\n'
1484 '\n'
1485 'The initial USE declaration in make.defaults should not contain\n'
1486 '"${USE}".\n',
1487 errors)
1488
Mike Frysinger8cf80812019-09-16 23:49:29 -04001489 return None
1490
Daniel Erat9d203ff2015-02-17 10:12:21 -07001491
Mike Frysingerae409522014-02-01 03:16:11 -05001492def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001493 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001494 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001495 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001496 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001497 if not m:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001498 return HookFailure('Last paragraph of description must include Change-Id.')
Ryan Cui1562fb82011-05-09 11:01:31 -07001499
LaMont Jonesfb5e8bf2020-03-03 12:50:06 -07001500 # S-o-b and some other tags always allowed to follow Change-ID in the footer.
1501 allowed_tags = ['Signed-off-by', 'Cq-Cl-Tag', 'Cq-Include-Trybots']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001502
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001503 end = desc[m.end():].strip().splitlines()
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001504 cherry_pick_marker = 'cherry picked from commit'
1505
1506 if end and cherry_pick_marker in end[-1]:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001507 # Cherry picked patches allow more tags in the last paragraph.
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001508 allowed_tags += ['Commit-Queue', 'Commit-Ready', 'Reviewed-by',
1509 'Reviewed-on', 'Tested-by']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001510 end = end[:-1]
1511
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001512 # Note that descriptions could have multiple cherry pick markers.
1513 tag_search = r'^(%s:|\(%s) ' % (':|'.join(allowed_tags), cherry_pick_marker)
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001514
1515 if [x for x in end if not re.search(tag_search, x)]:
1516 return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' %
1517 ':", "'.join(allowed_tags))
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001518
Mike Frysinger8cf80812019-09-16 23:49:29 -04001519 return None
1520
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001521
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001522def _check_commit_message_style(_project, commit):
1523 """Verify that the commit message matches our style.
1524
1525 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
1526 commit hooks.
1527 """
Mike Frysingered9b2a02019-12-12 18:52:32 -05001528 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Mike Frysinger4efdee72019-11-04 10:57:01 -05001529
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001530 desc = _get_commit_desc(commit)
1531
1532 # The first line should be by itself.
1533 lines = desc.splitlines()
1534 if len(lines) > 1 and lines[1]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001535 return HookFailure('The second line of the commit message must be blank.'
1536 '\n%s' % (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001537
1538 # The first line should be one sentence.
1539 if '. ' in lines[0]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001540 return HookFailure('The first line cannot be more than one sentence.\n%s' %
1541 (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001542
1543 # The first line cannot be too long.
1544 MAX_FIRST_LINE_LEN = 100
1545 if len(lines[0]) > MAX_FIRST_LINE_LEN:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001546 return HookFailure('The first line must be less than %i chars.\n%s' %
1547 (MAX_FIRST_LINE_LEN, SEE_ALSO))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001548
Mike Frysinger8cf80812019-09-16 23:49:29 -04001549 return None
1550
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001551
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001552def _check_cros_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001553 """Verifies the Chromium OS license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -07001554
Mike Frysinger98638102014-08-28 00:15:08 -04001555 Should be following the spec:
1556 http://dev.chromium.org/developers/coding-style#TOC-File-headers
1557 """
1558 # For older years, be a bit more flexible as our policy says leave them be.
1559 LICENSE_HEADER = (
Keigo Oka7e880ac2019-07-03 15:03:43 +09001560 r'.*Copyright(?: \(c\))? (20[0-9]{2})(?:-20[0-9]{2})? The Chromium OS '
1561 r'Authors\. All rights reserved\.\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001562 r'.*Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001563 r'be\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001564 r'.*found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -05001565 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001566 )
1567 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1568
1569 # For newer years, be stricter.
Keigo Oka7e880ac2019-07-03 15:03:43 +09001570 BAD_COPYRIGHT_LINE = (
Brian Norris68838dd2018-09-26 18:30:24 -07001571 r'.*Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001572 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001573 )
Keigo Oka7e880ac2019-07-03 15:03:43 +09001574 bad_copyright_re = re.compile(BAD_COPYRIGHT_LINE)
Mike Frysinger98638102014-08-28 00:15:08 -04001575
Shuhei Takahashiabc20f32017-07-10 19:35:45 +09001576 included, excluded = _parse_common_inclusion_options(options)
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001577
Mike Frysinger98638102014-08-28 00:15:08 -04001578 bad_files = []
1579 bad_copyright_files = []
Keigo Oka7e880ac2019-07-03 15:03:43 +09001580 bad_year_files = []
1581
Ken Turnerd07564b2018-02-08 17:57:59 +11001582 files = _filter_files(
1583 _get_affected_files(commit, relative=True),
1584 included + COMMON_INCLUDED_PATHS,
1585 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001586 existing_files = set(_get_affected_files(commit, relative=True,
1587 include_adds=False))
Mike Frysinger98638102014-08-28 00:15:08 -04001588
Keigo Oka7e880ac2019-07-03 15:03:43 +09001589 current_year = str(datetime.datetime.now().year)
Mike Frysinger98638102014-08-28 00:15:08 -04001590 for f in files:
1591 contents = _get_file_content(f, commit)
1592 if not contents:
1593 # Ignore empty files.
1594 continue
1595
Keigo Oka7e880ac2019-07-03 15:03:43 +09001596 m = license_re.search(contents)
1597 if not m:
Mike Frysinger98638102014-08-28 00:15:08 -04001598 bad_files.append(f)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001599 elif bad_copyright_re.search(contents):
Mike Frysinger98638102014-08-28 00:15:08 -04001600 bad_copyright_files.append(f)
1601
Keigo Oka7e880ac2019-07-03 15:03:43 +09001602 if m and f not in existing_files:
1603 year = m.group(1)
1604 if year != current_year:
1605 bad_year_files.append(f)
1606
1607 errors = []
Mike Frysinger98638102014-08-28 00:15:08 -04001608 if bad_files:
1609 msg = '%s:\n%s\n%s' % (
1610 'License must match', license_re.pattern,
1611 'Found a bad header in these files:')
Keigo Oka7e880ac2019-07-03 15:03:43 +09001612 errors.append(HookFailure(msg, bad_files))
Mike Frysinger98638102014-08-28 00:15:08 -04001613 if bad_copyright_files:
1614 msg = 'Do not use (c) in copyright headers in new files:'
Keigo Oka7e880ac2019-07-03 15:03:43 +09001615 errors.append(HookFailure(msg, bad_copyright_files))
1616 if bad_year_files:
1617 msg = 'Use current year (%s) in copyright headers in new files:' % (
1618 current_year)
1619 errors.append(HookFailure(msg, bad_year_files))
Ryan Cuiec4d6332011-05-02 14:15:25 -07001620
Keigo Oka7e880ac2019-07-03 15:03:43 +09001621 return errors
Ryan Cuiec4d6332011-05-02 14:15:25 -07001622
Mike Frysinger8cf80812019-09-16 23:49:29 -04001623
Amin Hassani391efa92018-01-26 17:58:05 -08001624def _check_aosp_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001625 """Verifies the AOSP license/copyright header.
1626
1627 AOSP uses the Apache2 License:
1628 https://source.android.com/source/licenses.html
1629 """
1630 LICENSE_HEADER = (
1631 r"""^[#/\*]*
1632[#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project
1633[#/\*]* ?
1634[#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\);
1635[#/\*]* ?you may not use this file except in compliance with the License\.
1636[#/\*]* ?You may obtain a copy of the License at
1637[#/\*]* ?
1638[#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0
1639[#/\*]* ?
1640[#/\*]* ?Unless required by applicable law or agreed to in writing, software
1641[#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS,
1642[#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """
1643 r"""implied\.
1644[#/\*]* ?See the License for the specific language governing permissions and
1645[#/\*]* ?limitations under the License\.
1646[#/\*]*$
1647"""
1648 )
1649 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1650
Amin Hassani391efa92018-01-26 17:58:05 -08001651 included, excluded = _parse_common_inclusion_options(options)
1652
Ken Turnerd07564b2018-02-08 17:57:59 +11001653 files = _filter_files(
1654 _get_affected_files(commit, relative=True),
1655 included + COMMON_INCLUDED_PATHS,
1656 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Alex Deymof5792ce2015-08-24 22:50:08 -07001657
1658 bad_files = []
1659 for f in files:
1660 contents = _get_file_content(f, commit)
1661 if not contents:
1662 # Ignore empty files.
1663 continue
1664
1665 if not license_re.search(contents):
1666 bad_files.append(f)
1667
1668 if bad_files:
1669 msg = ('License must match:\n%s\nFound a bad header in these files:' %
1670 license_re.pattern)
1671 return HookFailure(msg, bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001672 return None
Alex Deymof5792ce2015-08-24 22:50:08 -07001673
1674
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001675def _check_layout_conf(_project, commit):
1676 """Verifies the metadata/layout.conf file."""
1677 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001678 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001679 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001680 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001681
Mike Frysinger94a670c2014-09-19 12:46:26 -04001682 # Handle multiple overlays in a single commit (like the public tree).
1683 for f in _get_affected_files(commit, relative=True):
1684 if f.endswith(repo_name):
1685 repo_names.append(f)
1686 elif f.endswith(layout_path):
1687 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001688
1689 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -04001690 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001691 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -04001692 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001693
Mike Frysinger94a670c2014-09-19 12:46:26 -04001694 # Gather all the errors in one pass so we show one full message.
1695 all_errors = {}
1696 for layout_path in layout_paths:
1697 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001698
Mike Frysinger94a670c2014-09-19 12:46:26 -04001699 # Make sure the config file is sorted.
1700 data = [x for x in _get_file_content(layout_path, commit).splitlines()
1701 if x and x[0] != '#']
1702 if sorted(data) != data:
1703 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001704
Mike Frysinger94a670c2014-09-19 12:46:26 -04001705 # Require people to set specific values all the time.
1706 settings = (
1707 # TODO: Enable this for everyone. http://crbug.com/408038
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001708 # ('fast caching', 'cache-format = md5-dict'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001709 ('fast manifests', 'thin-manifests = true'),
Mike Frysingerd7734522015-02-26 16:12:43 -05001710 ('extra features', 'profile-formats = portage-2 profile-default-eapi'),
1711 ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001712 )
1713 for reason, line in settings:
1714 if line not in data:
1715 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001716
Mike Frysinger94a670c2014-09-19 12:46:26 -04001717 # Require one of these settings.
Mike Frysinger5fae62d2015-11-11 20:12:15 -05001718 if 'use-manifests = strict' not in data:
1719 errors += ['enable file checking with: use-manifests = strict']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001720
Mike Frysinger94a670c2014-09-19 12:46:26 -04001721 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -04001722 for line in data:
1723 if line.startswith('repo-name = '):
1724 break
1725 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -04001726 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001727
Mike Frysinger94a670c2014-09-19 12:46:26 -04001728 # Summarize all the errors we saw (if any).
1729 lines = ''
1730 for layout_path, errors in all_errors.items():
1731 if errors:
1732 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
1733 if lines:
1734 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
1735 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001736
Mike Frysinger8cf80812019-09-16 23:49:29 -04001737 return None
1738
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001739
Keigo Oka4a09bd92019-05-07 14:01:00 +09001740def _check_no_new_gyp(_project, commit):
1741 """Verifies no project starts to use GYP."""
Keigo Oka4a09bd92019-05-07 14:01:00 +09001742 gypfiles = _filter_files(
1743 _get_affected_files(commit, include_symlinks=True, relative=True),
1744 [r'\.gyp$'])
1745
1746 if gypfiles:
1747 return HookFailure('GYP is deprecated and not allowed in a new project:',
1748 gypfiles)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001749 return None
Keigo Oka4a09bd92019-05-07 14:01:00 +09001750
1751
Ryan Cuiec4d6332011-05-02 14:15:25 -07001752# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001753
Ryan Cui1562fb82011-05-09 11:01:31 -07001754
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001755def _check_clang_format(_project, commit, options=()):
1756 """Runs clang-format on the given project"""
1757 hooks_dir = _get_hooks_dir()
1758 options = list(options)
1759 if commit == PRE_SUBMIT:
1760 options.append('--commit=HEAD')
1761 else:
1762 options.extend(['--commit', commit])
Brian Norris0c62a142018-12-11 13:24:29 -08001763 cmd = [os.path.join(hooks_dir, 'clang-format.py')] + options
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001764 cmd_result = cros_build_lib.run(cmd,
1765 print_cmd=False,
1766 stdout=True,
1767 encoding='utf-8',
1768 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001769 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001770 check=False)
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001771 if cmd_result.returncode:
1772 return HookFailure('clang-format.py errors/warnings\n\n' +
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001773 cmd_result.stdout)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001774 return None
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001775
1776
Mike Frysingerae409522014-02-01 03:16:11 -05001777def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001778 """Runs checkpatch.pl on the given project"""
Tomasz Figabd8faf62020-09-22 14:06:05 +00001779 # Bypass checkpatch for upstream or almost upstream commits, since we do not
1780 # intend to modify the upstream commits when landing them to our branches.
1781 # Any fixes should sent as independent patches.
1782 # The check is retained for FROMLIST and BACKPORT commits, as by definition
1783 # those can be still fixed up.
1784 desc = _get_commit_desc(commit)
1785 if desc.startswith('UPSTREAM:') or desc.startswith('FROMGIT:'):
1786 return None
1787
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001788 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001789 options = list(options)
Brian Norris4cee0502020-06-12 17:02:56 -07001790 if options and options[0].startswith('./') and os.path.exists(options[0]):
1791 cmdpath = options.pop(0)
1792 else:
1793 cmdpath = os.path.join(hooks_dir, 'checkpatch.pl')
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001794 if commit == PRE_SUBMIT:
1795 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
1796 # this case.
1797 options.append('--ignore=MISSING_SIGN_OFF')
Filipe Brandenburger28d48d62015-10-07 09:48:54 -07001798 # Always ignore the check for the MAINTAINERS file. We do not track that
1799 # information on that file in our source trees, so let's suppress the
1800 # warning.
1801 options.append('--ignore=FILE_PATH_CHANGES')
Filipe Brandenburgerce978322015-10-09 10:04:15 -07001802 # Do not complain about the Change-Id: fields, since we use Gerrit.
1803 # Upstream does not want those lines (since they do not use Gerrit), but
1804 # we always do, so disable the check globally.
Daisuke Nojiri4844f892015-10-08 09:54:33 -07001805 options.append('--ignore=GERRIT_CHANGE_ID')
Brian Norris4cee0502020-06-12 17:02:56 -07001806 cmd = [cmdpath] + options + ['-']
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001807 cmd_result = cros_build_lib.run(
1808 cmd, print_cmd=False, input=_get_patch(commit).encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001809 stdout=True, stderr=subprocess.STDOUT, check=False, encoding='utf-8',
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001810 errors='replace')
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001811 if cmd_result.returncode:
Brian Norris4cee0502020-06-12 17:02:56 -07001812 return HookFailure('%s errors/warnings\n\n%s' %
1813 (cmdpath, cmd_result.stdout))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001814 return None
Ryan Cuiec4d6332011-05-02 14:15:25 -07001815
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001816
Brian Norris23c62e92018-11-14 12:25:51 -08001817def _run_kerneldoc(_project, commit, options=()):
1818 """Runs kernel-doc validator on the given project"""
1819 included, excluded = _parse_common_inclusion_options(options)
1820 files = _filter_files(_get_affected_files(commit, relative=True),
1821 included, excluded)
1822 if files:
1823 hooks_dir = _get_hooks_dir()
Brian Norris0c62a142018-12-11 13:24:29 -08001824 cmd = [os.path.join(hooks_dir, 'kernel-doc'), '-none'] + files
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001825 output = _run_command(cmd, stderr=subprocess.STDOUT)
Brian Norris23c62e92018-11-14 12:25:51 -08001826 if output:
Brian Norris0c62a142018-12-11 13:24:29 -08001827 return HookFailure('kernel-doc errors/warnings:',
1828 items=output.splitlines())
Mike Frysinger8cf80812019-09-16 23:49:29 -04001829 return None
Brian Norris23c62e92018-11-14 12:25:51 -08001830
1831
Mike Frysingerae409522014-02-01 03:16:11 -05001832def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -07001833 """Makes sure kernel config changes are not mixed with code changes"""
1834 files = _get_affected_files(commit)
Mike Frysingerf252cfc2019-12-09 17:34:28 -05001835 if len(_filter_files(files, [r'chromeos/config'])) not in [0, len(files)]:
Olof Johanssona96810f2012-09-04 16:20:03 -07001836 return HookFailure('Changes to chromeos/config/ and regular files must '
1837 'be in separate commits:\n%s' % '\n'.join(files))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001838 return None
Anton Staaf815d6852011-08-22 10:08:45 -07001839
Mike Frysingerae409522014-02-01 03:16:11 -05001840
1841def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -07001842 """Checks that all JSON files are syntactically valid."""
Mike Frysinger908be682018-01-04 02:21:50 -05001843 ret = []
1844
1845 files = _filter_files(_get_affected_files(commit, relative=True),
1846 [r'.*\.json$'])
1847 for f in files:
1848 data = _get_file_content(f, commit)
Dale Curtis2975c432011-05-03 17:25:20 -07001849 try:
Mike Frysinger908be682018-01-04 02:21:50 -05001850 json.loads(data)
1851 except Exception as e:
1852 ret.append('%s: Invalid JSON: %s' % (f, e))
1853
1854 if ret:
1855 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001856 return None
Dale Curtis2975c432011-05-03 17:25:20 -07001857
1858
Mike Frysingerae409522014-02-01 03:16:11 -05001859def _check_manifests(_project, commit):
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001860 """Make sure Manifest files only have comments & DIST lines."""
1861 ret = []
Mike Frysinger52b537e2013-08-22 22:59:53 -04001862
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001863 manifests = _filter_files(_get_affected_files(commit, relative=True),
1864 [r'.*/Manifest$'])
1865 for path in manifests:
1866 data = _get_file_content(path, commit)
1867
1868 # Disallow blank files.
1869 if not data.strip():
1870 ret.append('%s: delete empty file' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001871 continue
1872
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001873 # Make sure the last newline isn't omitted.
1874 if data[-1] != '\n':
1875 ret.append('%s: missing trailing newline' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001876
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001877 # Do not allow leading or trailing blank lines.
1878 lines = data.splitlines()
1879 if not lines[0]:
1880 ret.append('%s: delete leading blank lines' % (path,))
1881 if not lines[-1]:
1882 ret.append('%s: delete trailing blank lines' % (path,))
1883
1884 for line in lines:
1885 # Disallow leading/trailing whitespace.
1886 if line != line.strip():
1887 ret.append('%s: remove leading/trailing whitespace: %s' % (path, line))
1888
1889 # Allow blank lines & comments.
1890 line = line.split('#', 1)[0]
1891 if not line:
1892 continue
1893
1894 # All other linse should start with DIST.
1895 if not line.startswith('DIST '):
1896 ret.append('%s: remove non-DIST lines: %s' % (path, line))
1897 break
1898
1899 if ret:
1900 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001901 return None
Mike Frysinger52b537e2013-08-22 22:59:53 -04001902
1903
Mike Frysingerae409522014-02-01 03:16:11 -05001904def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001905 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001906 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001907 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001908 BRANCH_RE = r'\nBRANCH=\S+'
1909
1910 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
1911 msg = ('Changelist description needs BRANCH field (after first line)\n'
1912 'E.g. BRANCH=none or BRANCH=link,snow')
1913 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001914 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001915
1916
Mike Frysinger45334bd2019-11-04 10:42:33 -05001917def _check_change_has_no_branch_field(_project, commit):
1918 """Verify 'BRANCH=' field does not exist in the commit message."""
1919 if commit == PRE_SUBMIT:
1920 return None
1921 BRANCH_RE = r'\nBRANCH=\S+'
1922
1923 if re.search(BRANCH_RE, _get_commit_desc(commit)):
1924 msg = 'This checkout does not use BRANCH= fields. Delete them.'
1925 return HookFailure(msg)
1926 return None
1927
1928
Mike Frysingerae409522014-02-01 03:16:11 -05001929def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001930 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001931 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001932 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001933 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1934
1935 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1936 msg = ('Changelist description needs Signed-off-by: field\n'
1937 'E.g. Signed-off-by: My Name <me@chromium.org>')
1938 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001939 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001940
1941
Mike Frysinger9ab64b12019-11-04 10:53:08 -05001942def _check_change_has_no_signoff_field(_project, commit):
1943 """Verify 'Signed-off-by:' field does not exist in the commit message."""
1944 if commit == PRE_SUBMIT:
1945 return None
1946 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1947
1948 if re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1949 msg = 'This checkout does not use Signed-off-by: tags. Delete them.'
1950 return HookFailure(msg)
1951 return None
1952
1953
Jon Salz3ee59de2012-08-18 13:54:22 +08001954def _run_project_hook_script(script, project, commit):
1955 """Runs a project hook script.
1956
1957 The script is run with the following environment variables set:
1958 PRESUBMIT_PROJECT: The affected project
1959 PRESUBMIT_COMMIT: The affected commit
1960 PRESUBMIT_FILES: A newline-separated list of affected files
1961
1962 The script is considered to fail if the exit code is non-zero. It should
1963 write an error message to stdout.
1964 """
1965 env = dict(os.environ)
Alex Deymo643ac4c2015-09-03 10:40:50 -07001966 env['PRESUBMIT_PROJECT'] = project.name
Jon Salz3ee59de2012-08-18 13:54:22 +08001967 env['PRESUBMIT_COMMIT'] = commit
1968
1969 # Put affected files in an environment variable
1970 files = _get_affected_files(commit)
1971 env['PRESUBMIT_FILES'] = '\n'.join(files)
1972
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001973 cmd_result = cros_build_lib.run(cmd=script,
1974 env=env,
1975 shell=True,
1976 print_cmd=False,
1977 input=os.devnull,
1978 stdout=True,
1979 encoding='utf-8',
1980 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001981 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001982 check=False)
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001983 if cmd_result.returncode:
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001984 stdout = cmd_result.stdout
Jon Salz7b618af2012-08-31 06:03:16 +08001985 if stdout:
1986 stdout = re.sub('(?m)^', ' ', stdout)
1987 return HookFailure('Hook script "%s" failed with code %d%s' %
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001988 (script, cmd_result.returncode,
Jon Salz3ee59de2012-08-18 13:54:22 +08001989 ':\n' + stdout if stdout else ''))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001990 return None
Jon Salz3ee59de2012-08-18 13:54:22 +08001991
1992
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001993def _check_project_prefix(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -05001994 """Require the commit message have a project specific prefix as needed."""
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001995
Brian Norris77608e12018-04-06 10:38:43 -07001996 files = _get_affected_files(commit, include_deletes=True, relative=True)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001997 prefix = os.path.commonprefix(files)
1998 prefix = os.path.dirname(prefix)
1999
2000 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07002001 if not prefix:
Mike Frysinger8cf80812019-09-16 23:49:29 -04002002 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07002003
2004 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07002005
2006 # The common files may all be within a subdirectory of the main project
2007 # directory, so walk up the tree until we find an alias file.
2008 # _get_affected_files() should return relative paths, but check against '/' to
2009 # ensure that this loop terminates even if it receives an absolute path.
2010 while prefix and prefix != '/':
2011 alias_file = os.path.join(prefix, '.project_alias')
2012
2013 # If an alias exists, use it.
2014 if os.path.isfile(alias_file):
2015 project_name = osutils.ReadFile(alias_file).strip()
2016
2017 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07002018
2019 if not _get_commit_desc(commit).startswith(project_name + ': '):
2020 return HookFailure('The commit title for changes affecting only %s'
2021 ' should start with \"%s: \"'
2022 % (project_name, project_name))
Mike Frysinger8cf80812019-09-16 23:49:29 -04002023 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07002024
2025
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09002026def _check_filepath_chartype(_project, commit):
2027 """Checks that FilePath::CharType stuff is not used."""
2028
2029 FILEPATH_REGEXP = re.compile('|'.join(
2030 [r'(?:base::)?FilePath::(?:Char|String|StringPiece)Type',
Satoru Takabayashi4ca37922018-08-08 10:16:38 +09002031 r'(?:base::)?FilePath::FromUTF8Unsafe',
2032 r'AsUTF8Unsafe',
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09002033 r'FILE_PATH_LITERAL']))
2034 files = _filter_files(_get_affected_files(commit, relative=True),
2035 [r'.*\.(cc|h)$'])
2036
2037 errors = []
2038 for afile in files:
2039 for line_num, line in _get_file_diff(afile, commit):
2040 m = re.search(FILEPATH_REGEXP, line)
2041 if m:
2042 errors.append('%s, line %s has %s' % (afile, line_num, m.group(0)))
2043
2044 if errors:
2045 msg = 'Please assume FilePath::CharType is char (crbug.com/870621):'
2046 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -04002047 return None
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09002048
2049
Mike Frysingerf9d41b32017-02-23 15:20:04 -05002050def _check_exec_files(_project, commit):
2051 """Make +x bits on files."""
2052 # List of files that should never be +x.
2053 NO_EXEC = (
2054 'ChangeLog*',
2055 'COPYING',
2056 'make.conf',
2057 'make.defaults',
2058 'Manifest',
2059 'OWNERS',
2060 'package.use',
2061 'package.keywords',
2062 'package.mask',
2063 'parent',
2064 'README',
2065 'TODO',
2066 '.gitignore',
2067 '*.[achly]',
2068 '*.[ch]xx',
2069 '*.boto',
2070 '*.cc',
2071 '*.cfg',
2072 '*.conf',
2073 '*.config',
2074 '*.cpp',
2075 '*.css',
2076 '*.ebuild',
2077 '*.eclass',
Tatsuhisa Yamaguchi3b053632019-01-10 14:45:14 +09002078 '*.gn',
2079 '*.gni',
Mike Frysingerf9d41b32017-02-23 15:20:04 -05002080 '*.gyp',
2081 '*.gypi',
2082 '*.htm',
2083 '*.html',
2084 '*.ini',
2085 '*.js',
2086 '*.json',
2087 '*.md',
2088 '*.mk',
2089 '*.patch',
2090 '*.policy',
2091 '*.proto',
2092 '*.raw',
2093 '*.rules',
2094 '*.service',
2095 '*.target',
2096 '*.txt',
2097 '*.xml',
2098 '*.yaml',
2099 )
2100
2101 def FinalName(obj):
2102 # If the file is being deleted, then the dst_file is not set.
2103 if obj.dst_file is None:
2104 return obj.src_file
2105 else:
2106 return obj.dst_file
2107
2108 bad_files = []
2109 files = _get_affected_files(commit, relative=True, full_details=True)
2110 for f in files:
2111 mode = int(f.dst_mode, 8)
2112 if not mode & 0o111:
2113 continue
2114 name = FinalName(f)
2115 for no_exec in NO_EXEC:
2116 if fnmatch.fnmatch(name, no_exec):
2117 bad_files.append(name)
2118 break
2119
2120 if bad_files:
2121 return HookFailure('These files should not be executable. '
2122 'Please `chmod -x` them.', bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04002123 return None
Mike Frysingerf9d41b32017-02-23 15:20:04 -05002124
2125
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002126# Base
2127
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002128# A list of hooks which are not project specific and check patch description
2129# (as opposed to patch body).
2130_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07002131 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07002132 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07002133 _check_change_has_test_field,
2134 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04002135 _check_commit_message_style,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08002136 _check_change_is_contribution,
Jack Neus8edbf642019-07-10 16:08:31 -06002137 _check_change_no_include_oem,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002138]
2139
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002140# A list of hooks that are not project-specific
2141_COMMON_HOOKS = [
Keiichi Watanabe6ab73fd2020-07-14 23:42:02 +09002142 _check_cargo_clippy,
Aviv Keshet5ac59522017-01-31 14:28:27 -08002143 _check_cros_license,
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05002144 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05002145 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08002146 _check_ebuild_licenses,
Mike Frysingerb04778f2020-11-30 02:41:14 -05002147 _check_ebuild_owners,
Mike Frysinger6ee76b82020-11-20 01:16:06 -05002148 _check_ebuild_r0,
Mike Frysingercd363c82014-02-01 05:20:18 -05002149 _check_ebuild_virtual_pv,
Mike Frysingerf9d41b32017-02-23 15:20:04 -05002150 _check_exec_files,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002151 _check_for_uprev,
Rahul Chaudhry09f61372015-07-31 17:14:26 -07002152 _check_gofmt,
Bernie Thompson8e26f742020-07-23 14:32:31 -07002153 _check_keywords,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04002154 _check_layout_conf,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002155 _check_no_long_lines,
Keigo Oka4a09bd92019-05-07 14:01:00 +09002156 _check_no_new_gyp,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002157 _check_no_stray_whitespace,
Ryan Cui9b651632011-05-11 11:38:58 -07002158 _check_no_tabs,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002159 _check_portage_make_use_var,
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -06002160 _check_rustfmt,
Aviv Keshet5ac59522017-01-31 14:28:27 -08002161 _check_tabbed_indents,
Ryan Cui9b651632011-05-11 11:38:58 -07002162]
Ryan Cuiec4d6332011-05-02 14:15:25 -07002163
Ryan Cui1562fb82011-05-09 11:01:31 -07002164
Ryan Cui9b651632011-05-11 11:38:58 -07002165# A dictionary of flags (keys) that can appear in the config file, and the hook
Mike Frysinger3554bc92015-03-11 04:59:21 -04002166# that the flag controls (value).
2167_HOOK_FLAGS = {
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07002168 'clang_format_check': _check_clang_format,
Mike Frysingera7642f52015-03-25 18:31:42 -04002169 'checkpatch_check': _run_checkpatch,
Brian Norris23c62e92018-11-14 12:25:51 -08002170 'kerneldoc_check': _run_kerneldoc,
Ryan Cui9b651632011-05-11 11:38:58 -07002171 'stray_whitespace_check': _check_no_stray_whitespace,
Mike Frysingerff6c7d62015-03-24 13:49:46 -04002172 'json_check': _run_json_check,
Ryan Cui9b651632011-05-11 11:38:58 -07002173 'long_line_check': _check_no_long_lines,
Alex Deymof5792ce2015-08-24 22:50:08 -07002174 'cros_license_check': _check_cros_license,
2175 'aosp_license_check': _check_aosp_license,
LaMont Jones872fe762020-02-10 15:36:14 -07002176 'gofmt_check': _check_gofmt,
Bernie Thompson8e26f742020-07-23 14:32:31 -07002177 'keyword_check': _check_keywords,
Ryan Cui9b651632011-05-11 11:38:58 -07002178 'tab_check': _check_no_tabs,
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08002179 'tabbed_indent_required_check': _check_tabbed_indents,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07002180 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08002181 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07002182 'bug_field_check': _check_change_has_bug_field,
2183 'test_field_check': _check_change_has_test_field,
Steve Fung49ec7e92015-03-23 16:07:12 -07002184 'manifest_check': _check_manifests,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08002185 'contribution_check': _check_change_is_contribution,
Mike Frysinger47bd1252018-06-11 12:12:20 -04002186 'project_prefix_check': _check_project_prefix,
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09002187 'filepath_chartype_check': _check_filepath_chartype,
Keiichi Watanabe6ab73fd2020-07-14 23:42:02 +09002188 'cargo_clippy_check': _check_cargo_clippy,
Julius Werner291d8602020-07-31 17:34:02 -07002189 'exec_files_check': _check_exec_files,
Mike Frysingera5c2a5b2020-12-18 01:57:13 -05002190 'kernel_splitconfig_check': _kernel_configcheck,
Ryan Cui9b651632011-05-11 11:38:58 -07002191}
2192
2193
Mike Frysinger3554bc92015-03-11 04:59:21 -04002194def _get_override_hooks(config):
2195 """Returns a set of hooks controlled by the current project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07002196
2197 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08002198
2199 Args:
2200 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07002201 """
2202 SECTION = 'Hook Overrides'
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002203 SECTION_OPTIONS = 'Hook Overrides Options'
Ryan Cui9b651632011-05-11 11:38:58 -07002204
Mike Frysinger56e8de02019-07-31 14:40:14 -04002205 valid_keys = set(_HOOK_FLAGS.keys())
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002206 hooks = _HOOK_FLAGS.copy()
Mike Frysinger180ecd62020-08-19 00:41:51 -04002207 hook_overrides = set(
2208 config.options(SECTION) if config.has_section(SECTION) else [])
2209
2210 unknown_keys = hook_overrides - valid_keys
2211 if unknown_keys:
2212 raise ValueError(f'{_CONFIG_FILE}: [{SECTION}]: unknown keys: '
2213 f'{unknown_keys}')
Mike Frysinger3554bc92015-03-11 04:59:21 -04002214
2215 enable_flags = []
Ryan Cui9b651632011-05-11 11:38:58 -07002216 disable_flags = []
Mike Frysinger180ecd62020-08-19 00:41:51 -04002217 for flag in valid_keys:
2218 if flag in hook_overrides:
2219 try:
2220 enabled = config.getboolean(SECTION, flag)
2221 except ValueError as e:
2222 raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' %
2223 (flag, _CONFIG_FILE, e))
2224 elif hooks[flag] in _COMMON_HOOKS:
2225 # Enable common hooks by default so we process custom options below.
2226 enabled = True
2227 else:
2228 # All other hooks we left as a tristate. We use this below for a few
2229 # hooks to control default behavior.
2230 enabled = None
Mike Frysinger3554bc92015-03-11 04:59:21 -04002231
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002232 if enabled:
2233 enable_flags.append(flag)
Mike Frysinger180ecd62020-08-19 00:41:51 -04002234 elif enabled is not None:
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002235 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07002236
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002237 # See if this hook has custom options.
2238 if enabled:
2239 try:
2240 options = config.get(SECTION_OPTIONS, flag)
2241 hooks[flag] = functools.partial(hooks[flag], options=options.split())
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002242 hooks[flag].__name__ = flag
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04002243 except (configparser.NoOptionError, configparser.NoSectionError):
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002244 pass
2245
2246 enabled_hooks = set(hooks[x] for x in enable_flags)
2247 disabled_hooks = set(hooks[x] for x in disable_flags)
Mike Frysinger45334bd2019-11-04 10:42:33 -05002248
Mike Frysinger9ab64b12019-11-04 10:53:08 -05002249 if _check_change_has_signoff_field not in enabled_hooks:
Drew Davenport85848e52020-01-15 14:40:29 -07002250 if _check_change_has_signoff_field not in disabled_hooks:
2251 enabled_hooks.add(_check_change_has_no_signoff_field)
Mike Frysinger45334bd2019-11-04 10:42:33 -05002252 if _check_change_has_branch_field not in enabled_hooks:
2253 enabled_hooks.add(_check_change_has_no_branch_field)
2254
Mike Frysinger3554bc92015-03-11 04:59:21 -04002255 return enabled_hooks, disabled_hooks
Ryan Cui9b651632011-05-11 11:38:58 -07002256
2257
Jon Salz3ee59de2012-08-18 13:54:22 +08002258def _get_project_hook_scripts(config):
2259 """Returns a list of project-specific hook scripts.
2260
2261 Args:
2262 config: A ConfigParser for the project's config file.
2263 """
2264 SECTION = 'Hook Scripts'
2265 if not config.has_section(SECTION):
2266 return []
2267
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002268 return config.items(SECTION)
Jon Salz3ee59de2012-08-18 13:54:22 +08002269
2270
Mike Frysingerff916c62020-12-18 01:58:08 -05002271def _get_project_hooks(presubmit, config_file=None):
Ryan Cui9b651632011-05-11 11:38:58 -07002272 """Returns a list of hooks that need to be run for a project.
2273
2274 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002275
2276 Args:
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002277 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002278 config_file: A string, the config file. Defaults to _CONFIG_FILE.
Ryan Cui9b651632011-05-11 11:38:58 -07002279 """
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04002280 config = configparser.RawConfigParser()
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002281 if config_file is None:
2282 config_file = _CONFIG_FILE
2283 if not os.path.exists(config_file):
Jon Salz3ee59de2012-08-18 13:54:22 +08002284 # Just use an empty config file
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04002285 config = configparser.RawConfigParser()
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09002286 else:
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002287 config.read(config_file)
Jon Salz3ee59de2012-08-18 13:54:22 +08002288
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002289 if presubmit:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07002290 hooks = _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002291 else:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07002292 hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002293
Mike Frysinger3554bc92015-03-11 04:59:21 -04002294 enabled_hooks, disabled_hooks = _get_override_hooks(config)
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07002295 hooks = [hook for hook in hooks if hook not in disabled_hooks]
2296
2297 # If a list is both in _COMMON_HOOKS and also enabled explicitly through an
2298 # override, keep the override only. Note that the override may end up being
2299 # a functools.partial, in which case we need to extract the .func to compare
2300 # it to the common hooks.
2301 unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks]
2302 hooks = [hook for hook in hooks if hook not in unwrapped_hooks]
2303
2304 hooks = list(enabled_hooks) + hooks
Ryan Cui9b651632011-05-11 11:38:58 -07002305
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002306 for name, script in _get_project_hook_scripts(config):
2307 func = functools.partial(_run_project_hook_script, script)
2308 func.__name__ = name
2309 hooks.append(func)
Jon Salz3ee59de2012-08-18 13:54:22 +08002310
Ryan Cui9b651632011-05-11 11:38:58 -07002311 return hooks
2312
2313
Alex Deymo643ac4c2015-09-03 10:40:50 -07002314def _run_project_hooks(project_name, proj_dir=None,
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002315 commit_list=None, presubmit=False,
2316 config_file=None):
Ryan Cui1562fb82011-05-09 11:01:31 -07002317 """For each project run its project specific hook from the hooks dictionary.
2318
2319 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002320 project_name: The name of project to run hooks for.
Doug Anderson44a644f2011-11-02 10:37:37 -07002321 proj_dir: If non-None, this is the directory the project is in. If None,
2322 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07002323 commit_list: A list of commits to run hooks against. If None or empty list
2324 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002325 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002326 config_file: A string, the presubmit config file. If not specified,
2327 defaults to PRESUBMIT.cfg in the project directory.
Ryan Cui1562fb82011-05-09 11:01:31 -07002328
2329 Returns:
2330 Boolean value of whether any errors were ecountered while running the hooks.
2331 """
Doug Anderson44a644f2011-11-02 10:37:37 -07002332 if proj_dir is None:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002333 proj_dirs = _run_command(
2334 ['repo', 'forall', project_name, '-c', 'pwd']).split()
Mike Frysingere52b1bc2019-09-16 23:45:41 -04002335 if not proj_dirs:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002336 print('%s cannot be found.' % project_name, file=sys.stderr)
David James2edd9002013-10-11 14:09:19 -07002337 print('Please specify a valid project.', file=sys.stderr)
2338 return True
2339 if len(proj_dirs) > 1:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002340 print('%s is associated with multiple directories.' % project_name,
David James2edd9002013-10-11 14:09:19 -07002341 file=sys.stderr)
2342 print('Please specify a directory to help disambiguate.', file=sys.stderr)
2343 return True
2344 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07002345
Ryan Cuiec4d6332011-05-02 14:15:25 -07002346 pwd = os.getcwd()
2347 # hooks assume they are run from the root of the project
2348 os.chdir(proj_dir)
2349
Mike Frysingered1b95a2019-12-12 19:04:51 -05002350 color = terminal.Color()
2351
Alex Deymo643ac4c2015-09-03 10:40:50 -07002352 remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref',
2353 '--symbolic-full-name', '@{u}']).strip()
2354 if not remote_branch:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002355 print("Your project %s doesn't track any remote repo." % project_name,
Alex Deymo643ac4c2015-09-03 10:40:50 -07002356 file=sys.stderr)
2357 remote = None
2358 else:
Josh Pratt15d13ab2018-08-13 11:52:48 +10002359 branch_items = remote_branch.split('/', 1)
2360 if len(branch_items) != 2:
2361 PrintErrorForProject(
2362 project_name,
2363 HookFailure(
2364 'Cannot get remote and branch name (%s)' % remote_branch))
2365 os.chdir(pwd)
2366 return True
2367 remote, _branch = branch_items
Alex Deymo643ac4c2015-09-03 10:40:50 -07002368
2369 project = Project(name=project_name, dir=proj_dir, remote=remote)
2370
Doug Anderson14749562013-06-26 13:38:29 -07002371 if not commit_list:
2372 try:
2373 commit_list = _get_commits()
2374 except VerifyException as e:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002375 PrintErrorForProject(project.name, HookFailure(str(e)))
Doug Anderson14749562013-06-26 13:38:29 -07002376 os.chdir(pwd)
2377 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07002378
Mike Frysingerff916c62020-12-18 01:58:08 -05002379 hooks = _get_project_hooks(presubmit, config_file)
Ryan Cui1562fb82011-05-09 11:01:31 -07002380 error_found = False
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002381 commit_count = len(commit_list)
Mike Frysingerb99b3772019-08-17 14:19:44 -04002382 hook_count = len(hooks)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002383 for i, commit in enumerate(commit_list):
Mike Frysingerb2496652019-09-12 23:35:46 -04002384 CACHE.clear()
2385
LaMont Jones69d3e182020-03-11 15:00:53 -06002386 # If run with --pre-submit, then commit is PRE_SUBMIT, and not a commit.
2387 # Use that as the description.
2388 desc = commit if commit == PRE_SUBMIT else _get_commit_desc(commit)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002389 print('[%s %i/%i %s] %s' %
2390 (color.Color(color.CYAN, 'COMMIT'), i + 1, commit_count, commit[0:12],
2391 desc.splitlines()[0]))
2392
Mike Frysingerb99b3772019-08-17 14:19:44 -04002393 for h, hook in enumerate(hooks):
Mike Frysingered1b95a2019-12-12 19:04:51 -05002394 output = ('[%s %i/%i PRESUBMIT.cfg] %s' %
2395 (color.Color(color.YELLOW, 'RUNNING'), h + 1, hook_count,
2396 hook.__name__))
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002397 print(output, end='\r')
2398 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002399 hook_error = hook(project, commit)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002400 print(' ' * len(output), end='\r')
2401 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002402 if hook_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002403 if not isinstance(hook_error, list):
2404 hook_error = [hook_error]
2405 PrintErrorsForCommit(color, hook, project.name, hook_error)
Ryan Cui1562fb82011-05-09 11:01:31 -07002406 error_found = True
Don Garrettdba548a2011-05-05 15:17:14 -07002407
Ryan Cuiec4d6332011-05-02 14:15:25 -07002408 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07002409 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002410
Mike Frysingerae409522014-02-01 03:16:11 -05002411
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002412# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002413
Ryan Cui1562fb82011-05-09 11:01:31 -07002414
Mike Frysingerae409522014-02-01 03:16:11 -05002415def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08002416 """Main function invoked directly by repo.
2417
2418 This function will exit directly upon error so that repo doesn't print some
2419 obscure error message.
2420
2421 Args:
2422 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07002423 worktree_list: A list of directories. It should be the same length as
2424 project_list, so that each entry in project_list matches with a directory
2425 in worktree_list. If None, we will attempt to calculate the directories
2426 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08002427 kwargs: Leave this here for forward-compatibility.
2428 """
Mike Frysingered1b95a2019-12-12 19:04:51 -05002429 start_time = datetime.datetime.now()
Ryan Cui1562fb82011-05-09 11:01:31 -07002430 found_error = False
David James2edd9002013-10-11 14:09:19 -07002431 if not worktree_list:
2432 worktree_list = [None] * len(project_list)
2433 for project, worktree in zip(project_list, worktree_list):
2434 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07002435 found_error = True
2436
Mike Frysingered1b95a2019-12-12 19:04:51 -05002437 end_time = datetime.datetime.now()
2438 color = terminal.Color()
Mike Frysingerae409522014-02-01 03:16:11 -05002439 if found_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002440 msg = ('%s: Preupload failed due to above error(s).\n'
Ryan Cui9b651632011-05-11 11:38:58 -07002441 '- To disable some source style checks, and for other hints, see '
Mike Frysingered1b95a2019-12-12 19:04:51 -05002442 '<checkout_dir>/src/repohooks/README.md\n'
2443 "- To upload only current project, run 'repo upload .'" %
2444 (color.Color(color.RED, 'FATAL'),))
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04002445 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07002446 sys.exit(1)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002447 else:
2448 msg = ('[%s] repohooks passed in %s' %
2449 (color.Color(color.GREEN, 'PASSED'), end_time - start_time))
2450 print(msg)
Anush Elangovan63afad72011-03-23 00:41:27 -07002451
Ryan Cui1562fb82011-05-09 11:01:31 -07002452
Doug Anderson44a644f2011-11-02 10:37:37 -07002453def _identify_project(path):
2454 """Identify the repo project associated with the given path.
2455
2456 Returns:
2457 A string indicating what project is associated with the path passed in or
2458 a blank string upon failure.
2459 """
2460 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002461 stderr=True, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002462
2463
Mike Frysinger55f85b52014-12-18 14:45:21 -05002464def direct_main(argv):
Doug Anderson44a644f2011-11-02 10:37:37 -07002465 """Run hooks directly (outside of the context of repo).
2466
Doug Anderson44a644f2011-11-02 10:37:37 -07002467 Args:
Mike Frysinger55f85b52014-12-18 14:45:21 -05002468 argv: The command line args to process
Doug Anderson44a644f2011-11-02 10:37:37 -07002469
2470 Returns:
2471 0 if no pre-upload failures, 1 if failures.
2472
2473 Raises:
2474 BadInvocation: On some types of invocation errors.
2475 """
Mike Frysinger66142932014-12-18 14:55:57 -05002476 parser = commandline.ArgumentParser(description=__doc__)
2477 parser.add_argument('--dir', default=None,
2478 help='The directory that the project lives in. If not '
2479 'specified, use the git project root based on the cwd.')
2480 parser.add_argument('--project', default=None,
2481 help='The project repo path; this can affect how the '
2482 'hooks get run, since some hooks are project-specific. '
2483 'For chromite this is chromiumos/chromite. If not '
2484 'specified, the repo tool will be used to figure this '
2485 'out based on the dir.')
2486 parser.add_argument('--rerun-since', default=None,
Vadim Bendebury75447b92018-01-10 12:06:01 -08002487 help='Rerun hooks on old commits since some point '
2488 'in the past. The argument could be a date (should '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002489 "match git log's concept of a date, e.g. 2012-06-20), "
Vadim Bendebury75447b92018-01-10 12:06:01 -08002490 'or a SHA1, or just a number of commits to check (from 1 '
2491 'to 99). This option is mutually exclusive with '
2492 '--pre-submit.')
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002493 parser.add_argument('--pre-submit', action='store_true',
Mike Frysinger66142932014-12-18 14:55:57 -05002494 help='Run the check against the pending commit. '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002495 "This option should be used at the 'git commit' "
2496 "phase as opposed to 'repo upload'. This option "
Mike Frysinger66142932014-12-18 14:55:57 -05002497 'is mutually exclusive with --rerun-since.')
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002498 parser.add_argument('--presubmit-config',
2499 help='Specify presubmit config file to be used.')
Mike Frysinger66142932014-12-18 14:55:57 -05002500 parser.add_argument('commits', nargs='*',
2501 help='Check specific commits')
2502 opts = parser.parse_args(argv)
Doug Anderson44a644f2011-11-02 10:37:37 -07002503
Doug Anderson14749562013-06-26 13:38:29 -07002504 if opts.rerun_since:
Mike Frysinger66142932014-12-18 14:55:57 -05002505 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002506 raise BadInvocation("Can't pass commits and use rerun-since: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002507 ' '.join(opts.commits))
Doug Anderson14749562013-06-26 13:38:29 -07002508
Vadim Bendebury75447b92018-01-10 12:06:01 -08002509 if len(opts.rerun_since) < 3 and opts.rerun_since.isdigit():
2510 # This must be the number of commits to check. We don't expect the user
2511 # to want to check more than 99 commits.
2512 limit = '-n%s' % opts.rerun_since
2513 elif git.IsSHA1(opts.rerun_since, False):
2514 limit = '%s..' % opts.rerun_since
2515 else:
2516 # This better be a date.
2517 limit = '--since=%s' % opts.rerun_since
2518 cmd = ['git', 'log', limit, '--pretty=%H']
Doug Anderson14749562013-06-26 13:38:29 -07002519 all_commits = _run_command(cmd).splitlines()
2520 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
2521
2522 # Eliminate chrome-bot commits but keep ordering the same...
2523 bot_commits = set(bot_commits)
Mike Frysinger66142932014-12-18 14:55:57 -05002524 opts.commits = [c for c in all_commits if c not in bot_commits]
Doug Anderson14749562013-06-26 13:38:29 -07002525
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002526 if opts.pre_submit:
2527 raise BadInvocation('rerun-since and pre-submit can not be '
2528 'used together')
2529 if opts.pre_submit:
Mike Frysinger66142932014-12-18 14:55:57 -05002530 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002531 raise BadInvocation("Can't pass commits and use pre-submit: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002532 ' '.join(opts.commits))
2533 opts.commits = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07002534
2535 # Check/normlaize git dir; if unspecified, we'll use the root of the git
2536 # project from CWD
2537 if opts.dir is None:
Mike Frysinger9ba001a2020-11-20 01:02:11 -05002538 git_dir = _run_command(['git', 'rev-parse', '--show-toplevel'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002539 stderr=True).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002540 if not git_dir:
2541 raise BadInvocation('The current directory is not part of a git project.')
Mike Frysinger9ba001a2020-11-20 01:02:11 -05002542 opts.dir = git_dir
Doug Anderson44a644f2011-11-02 10:37:37 -07002543 elif not os.path.isdir(opts.dir):
2544 raise BadInvocation('Invalid dir: %s' % opts.dir)
2545 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
2546 raise BadInvocation('Not a git directory: %s' % opts.dir)
2547
2548 # Identify the project if it wasn't specified; this _requires_ the repo
2549 # tool to be installed and for the project to be part of a repo checkout.
2550 if not opts.project:
2551 opts.project = _identify_project(opts.dir)
2552 if not opts.project:
2553 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
2554
Doug Anderson14749562013-06-26 13:38:29 -07002555 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Mike Frysinger66142932014-12-18 14:55:57 -05002556 commit_list=opts.commits,
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002557 presubmit=opts.pre_submit,
2558 config_file=opts.presubmit_config)
Doug Anderson44a644f2011-11-02 10:37:37 -07002559 if found_error:
2560 return 1
2561 return 0
2562
2563
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002564if __name__ == '__main__':
Mike Frysinger55f85b52014-12-18 14:45:21 -05002565 sys.exit(direct_main(sys.argv[1:]))