blob: 26b0a7e28f035db9dd880b4371eddf2b9c187b11 [file] [log] [blame]
Mike Frysinger4f994402019-09-13 17:40:45 -04001#!/usr/bin/env python3
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002# -*- coding: utf-8 -*-
Jon Salz98255932012-08-18 14:48:02 +08003# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
Mike Frysingerae409522014-02-01 03:16:11 -05007"""Presubmit checks to run when doing `repo upload`.
8
Tom Hughes40bdce52020-08-25 08:57:03 -07009You can add new checks by adding a function to the HOOKS constants.
Mike Frysingerae409522014-02-01 03:16:11 -050010"""
11
Mike Frysinger09d6a3d2013-10-08 22:21:03 -040012from __future__ import print_function
13
Keigo Okadd908822019-06-04 11:30:25 +090014import argparse
Alex Deymo643ac4c2015-09-03 10:40:50 -070015import collections
Mike Frysingerf252cfc2019-12-09 17:34:28 -050016import configparser
Keigo Oka7e880ac2019-07-03 15:03:43 +090017import datetime
Daniel Erate3ea3fc2015-02-13 15:27:52 -070018import fnmatch
Jon Salz3ee59de2012-08-18 13:54:22 +080019import functools
Dale Curtis2975c432011-05-03 17:25:20 -070020import json
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070021import os
Stephen Boyd6bf5ea82020-10-15 00:02:07 -070022import pathlib
Ryan Cuiec4d6332011-05-02 14:15:25 -070023import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070024import sys
Peter Ammon811f6702014-06-12 15:45:38 -070025import stat
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -050026import subprocess
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070027
Ryan Cui1562fb82011-05-09 11:01:31 -070028from errors import (VerifyException, HookFailure, PrintErrorForProject,
29 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070030
Mike Frysinger919c7032019-09-13 17:48:08 -040031if __name__ in ('__builtin__', 'builtins'):
Mike Frysinger653cd262019-09-20 14:05:02 -040032 # If repo imports us, the __name__ will be __builtin__, and the cwd will be in
33 # the top level of the checkout (i.e. $CHROMEOS_CHECKOUT). chromite will be
34 # in that directory, so add it to our path. This works whether we're running
35 # the repo in $CHROMEOS_CHECKOUT/.repo/repo/ or a custom version in a
36 # completely different tree.
37 # TODO(vapier): Python 2 used "__builtin__" while Python 3 uses "builtins".
Mike Frysinger6850d512018-05-21 12:12:14 -040038 sys.path.insert(0, os.getcwd())
39
Mike Frysinger653cd262019-09-20 14:05:02 -040040elif __name__ == '__main__':
41 # If we're run directly, we'll find chromite relative to the repohooks dir in
42 # $CHROMEOS_CHECKOUT/src/repohooks, so go up two dirs.
David Jamesc3b68b32013-04-03 09:17:03 -070043 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
44
Mike Frysingerfd481ce2019-09-13 18:14:48 -040045# The sys.path monkey patching confuses the linter.
46# pylint: disable=wrong-import-position
Mike Frysinger66142932014-12-18 14:55:57 -050047from chromite.lib import commandline
Rahul Chaudhry0e515342015-08-07 12:00:43 -070048from chromite.lib import cros_build_lib
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050049from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070050from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070051from chromite.lib import patch
Mike Frysingered1b95a2019-12-12 19:04:51 -050052from chromite.lib import terminal
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040053from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070054
Mike Frysingerff4768e2020-02-27 18:48:13 -050055
56assert sys.version_info >= (3, 6), 'This module requires Python 3.6+'
57
58
Vadim Bendebury2b62d742014-06-22 13:14:51 -070059PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070060
Mike Frysingered9b2a02019-12-12 18:52:32 -050061
62# Link to commit message documentation for users.
63DOC_COMMIT_MSG_URL = ('https://chromium.googlesource.com/chromiumos/docs/+/HEAD'
64 '/contributing.md#commit-messages')
65
66
Ryan Cuiec4d6332011-05-02 14:15:25 -070067COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050068 # C++ and friends
Mike Frysinger24dd3c52019-08-17 14:22:48 -040069 r'.*\.c$', r'.*\.cc$', r'.*\.cpp$', r'.*\.h$', r'.*\.m$', r'.*\.mm$',
70 r'.*\.inl$', r'.*\.asm$', r'.*\.hxx$', r'.*\.hpp$', r'.*\.s$', r'.*\.S$',
Mike Frysingerae409522014-02-01 03:16:11 -050071 # Scripts
Mike Frysinger24dd3c52019-08-17 14:22:48 -040072 r'.*\.js$', r'.*\.py$', r'.*\.sh$', r'.*\.rb$', r'.*\.pl$', r'.*\.pm$',
Bob Haarman0dc1f942020-10-03 00:06:59 +000073 # No extension at all, note that ALL CAPS files are excluded by
Mike Frysingerae409522014-02-01 03:16:11 -050074 # COMMON_EXCLUDED_LIST below.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040075 r'(^|.*[\\\/])[^.]+$',
Mike Frysingerae409522014-02-01 03:16:11 -050076 # Other
Mike Frysinger24dd3c52019-08-17 14:22:48 -040077 r'.*\.java$', r'.*\.mk$', r'.*\.am$',
78 r'.*\.policy$', r'.*\.conf$', r'.*\.go$',
79 r'(^OWNERS|/OWNERS)',
Ryan Cuiec4d6332011-05-02 14:15:25 -070080]
81
Ryan Cui1562fb82011-05-09 11:01:31 -070082
Ryan Cuiec4d6332011-05-02 14:15:25 -070083COMMON_EXCLUDED_PATHS = [
Daniel Erate3ea3fc2015-02-13 15:27:52 -070084 # For ebuild trees, ignore any caches and manifest data.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040085 r'.*/Manifest$',
86 r'.*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$',
Doug Anderson5bfb6792011-10-25 16:45:41 -070087
Daniel Erate3ea3fc2015-02-13 15:27:52 -070088 # Ignore profiles data (like overlay-tegra2/profiles).
Mike Frysinger24dd3c52019-08-17 14:22:48 -040089 r'(^|.*/)overlay-.*/profiles/.*',
90 r'^profiles/.*$',
Mike Frysinger98638102014-08-28 00:15:08 -040091
C Shapiro8f90e9b2017-06-28 09:54:50 -060092 # Ignore config files in ebuild setup.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040093 r'(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*',
94 r'^chromeos-base/chromeos-bsp.*/files/.*',
C Shapiro8f90e9b2017-06-28 09:54:50 -060095
Daniel Erate3ea3fc2015-02-13 15:27:52 -070096 # Ignore minified js and jquery.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040097 r'.*\.min\.js',
98 r'.*jquery.*\.js',
Mike Frysinger33a458d2014-03-03 17:00:51 -050099
100 # Ignore license files as the content is often taken verbatim.
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400101 r'.*/licenses/.*',
Alex Klein619c0912019-01-30 17:13:23 -0700102
Mike Frysinger13650402019-07-31 14:31:46 -0400103 # Exclude generated protobuf bindings.
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400104 r'.*_pb2\.py$',
105 r'.*\.pb\.go$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700106]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700107
Ken Turnerd07564b2018-02-08 17:57:59 +1100108LICENSE_EXCLUDED_PATHS = [
LaMont Jones775c2b32020-02-19 17:32:54 -0700109 r'^(.*/)?OWNERS(\..*)?$',
Ken Turnerd07564b2018-02-08 17:57:59 +1100110]
Ryan Cui1562fb82011-05-09 11:01:31 -0700111
Ryan Cui9b651632011-05-11 11:38:58 -0700112_CONFIG_FILE = 'PRESUBMIT.cfg'
113
114
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700115# File containing wildcards, one per line, matching files that should be
116# excluded from presubmit checks. Lines beginning with '#' are ignored.
117_IGNORE_FILE = '.presubmitignore'
118
Cheng Yuehb707c522020-01-02 14:06:59 +0800119
120TEST_FIELD_RE = r'\nTEST=\S+'
121
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700122BLOCKED_TERMS_FILE = 'blocked_terms.txt'
123UNBLOCKED_TERMS_FILE = 'unblocked_terms.txt'
124
Doug Anderson44a644f2011-11-02 10:37:37 -0700125# Exceptions
126
127
128class BadInvocation(Exception):
129 """An Exception indicating a bad invocation of the program."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700130
131
Ryan Cui1562fb82011-05-09 11:01:31 -0700132# General Helpers
133
Sean Paulba01d402011-05-05 11:36:23 -0400134
Mike Frysingerb2496652019-09-12 23:35:46 -0400135class Cache(object):
136 """General helper for caching git content."""
137
138 def __init__(self):
139 self._cache = {}
140
141 def get_subcache(self, scope):
142 return self._cache.setdefault(scope, {})
143
144 def clear(self):
145 self._cache.clear()
146
147CACHE = Cache()
148
149
Alex Deymo643ac4c2015-09-03 10:40:50 -0700150Project = collections.namedtuple('Project', ['name', 'dir', 'remote'])
151
152
Mike Frysinger526a5f82019-09-13 18:05:30 -0400153def _run_command(cmd, **kwargs):
Doug Anderson44a644f2011-11-02 10:37:37 -0700154 """Executes the passed in command and returns raw stdout output.
155
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400156 This is a convenience func to set some run defaults differently.
Mike Frysinger526a5f82019-09-13 18:05:30 -0400157
Doug Anderson44a644f2011-11-02 10:37:37 -0700158 Args:
159 cmd: The command to run; should be a list of strings.
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400160 **kwargs: Same as cros_build_lib.run.
Doug Anderson44a644f2011-11-02 10:37:37 -0700161
162 Returns:
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700163 The stdout from the process (discards stderr and returncode).
Doug Anderson44a644f2011-11-02 10:37:37 -0700164 """
Mike Frysinger526a5f82019-09-13 18:05:30 -0400165 kwargs.setdefault('print_cmd', False)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400166 kwargs.setdefault('stdout', True)
167 kwargs.setdefault('check', False)
Mike Frysinger054c1592019-11-18 03:51:54 -0500168 result = cros_build_lib.run(cmd, **kwargs)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400169 # NB: We decode this directly rather than through kwargs as our tests rely
170 # on this post-processing behavior currently.
Mike Frysinger71e643e2019-09-13 17:26:39 -0400171 return result.output.decode('utf-8', 'replace')
Ryan Cui72834d12011-05-05 14:51:33 -0700172
Ryan Cui1562fb82011-05-09 11:01:31 -0700173
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700174def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700175 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700176 if __name__ == '__main__':
177 # Works when file is run on its own (__file__ is defined)...
178 return os.path.abspath(os.path.dirname(__file__))
179 else:
180 # We need to do this when we're run through repo. Since repo executes
181 # us with execfile(), we don't get __file__ defined.
182 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
183 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700184
Ryan Cui1562fb82011-05-09 11:01:31 -0700185
Ryan Cuiec4d6332011-05-02 14:15:25 -0700186def _match_regex_list(subject, expressions):
187 """Try to match a list of regular expressions to a string.
188
189 Args:
190 subject: The string to match regexes on
191 expressions: A list of regular expressions to check for matches with.
192
193 Returns:
194 Whether the passed in subject matches any of the passed in regexes.
195 """
196 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500197 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700198 return True
199 return False
200
Ryan Cui1562fb82011-05-09 11:01:31 -0700201
Mike Frysingerae409522014-02-01 03:16:11 -0500202def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700203 """Filter out files based on the conditions passed in.
204
205 Args:
206 files: list of filepaths to filter
207 include_list: list of regex that when matched with a file path will cause it
208 to be added to the output list unless the file is also matched with a
209 regex in the exclude_list.
210 exclude_list: list of regex that when matched with a file will prevent it
211 from being added to the output list, even if it is also matched with a
212 regex in the include_list.
213
214 Returns:
215 A list of filepaths that contain files matched in the include_list and not
216 in the exclude_list.
217 """
218 filtered = []
219 for f in files:
220 if (_match_regex_list(f, include_list) and
221 not _match_regex_list(f, exclude_list)):
222 filtered.append(f)
223 return filtered
224
Ryan Cuiec4d6332011-05-02 14:15:25 -0700225
226# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700227
228
Ryan Cui4725d952011-05-05 15:41:19 -0700229def _get_upstream_branch():
230 """Returns the upstream tracking branch of the current branch.
231
232 Raises:
233 Error if there is no tracking branch
234 """
235 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
236 current_branch = current_branch.replace('refs/heads/', '')
237 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700238 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700239
240 cfg_option = 'branch.' + current_branch + '.%s'
241 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
242 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
243 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700244 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700245
246 return full_upstream.replace('heads', 'remotes/' + remote)
247
Ryan Cui1562fb82011-05-09 11:01:31 -0700248
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700249def _get_patch(commit):
250 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700251 if commit == PRE_SUBMIT:
252 return _run_command(['git', 'diff', '--cached', 'HEAD'])
253 else:
254 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700255
Ryan Cui1562fb82011-05-09 11:01:31 -0700256
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500257def _get_file_content(path, commit):
258 """Returns the content of a file at a specific commit.
259
260 We can't rely on the file as it exists in the filesystem as people might be
261 uploading a series of changes which modifies the file multiple times.
262
263 Note: The "content" of a symlink is just the target. So if you're expecting
264 a full file, you should check that first. One way to detect is that the
265 content will not have any newlines.
266 """
Mike Frysingerb2496652019-09-12 23:35:46 -0400267 # Make sure people don't accidentally pass in full paths which will never
268 # work. You need to use relative=True with _get_affected_files.
269 if path.startswith('/'):
270 raise ValueError('_get_file_content must be called with relative paths: %s'
271 % (path,))
272
273 # {<commit>: {<path1>: <content>, <path2>: <content>}}
274 cache = CACHE.get_subcache('get_file_content')
275 if path in cache:
276 return cache[path]
277
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700278 if commit == PRE_SUBMIT:
Yu-Ping Wue3e47362020-09-22 15:54:40 +0800279 content = _run_command(['git', 'diff', 'HEAD', '--', path])
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700280 else:
Mike Frysingerb2496652019-09-12 23:35:46 -0400281 content = _run_command(['git', 'show', '%s:%s' % (commit, path)])
282 cache[path] = content
283 return content
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500284
285
Mike Frysingerae409522014-02-01 03:16:11 -0500286def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700287 """Returns a list of (linenum, lines) tuples that the commit touched."""
Mike Frysingerb2496652019-09-12 23:35:46 -0400288 # {<commit>: {<path1>: <content>, <path2>: <content>}}
289 cache = CACHE.get_subcache('get_file_diff')
290 if path in cache:
291 return cache[path]
292
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700293 if commit == PRE_SUBMIT:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800294 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD',
Yu-Ping Wue3e47362020-09-22 15:54:40 +0800295 '--', path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700296 else:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800297 command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit,
Yu-Ping Wue3e47362020-09-22 15:54:40 +0800298 '--', path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700299 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700300
301 new_lines = []
302 line_num = 0
303 for line in output.splitlines():
304 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
305 if m:
306 line_num = int(m.groups(1)[0])
307 continue
308 if line.startswith('+') and not line.startswith('++'):
Mike Frysinger71e643e2019-09-13 17:26:39 -0400309 new_lines.append((line_num, line[1:]))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700310 if not line.startswith('-'):
311 line_num += 1
Mike Frysingerb2496652019-09-12 23:35:46 -0400312 cache[path] = new_lines
Ryan Cuiec4d6332011-05-02 14:15:25 -0700313 return new_lines
314
Ryan Cui1562fb82011-05-09 11:01:31 -0700315
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700316def _get_ignore_wildcards(directory, cache):
317 """Get wildcards listed in a directory's _IGNORE_FILE.
318
319 Args:
320 directory: A string containing a directory path.
321 cache: A dictionary (opaque to caller) caching previously-read wildcards.
322
323 Returns:
324 A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE
325 wasn't present.
326 """
327 # In the cache, keys are directories and values are lists of wildcards from
328 # _IGNORE_FILE within those directories (and empty if no file was present).
329 if directory not in cache:
330 wildcards = []
331 dotfile_path = os.path.join(directory, _IGNORE_FILE)
332 if os.path.exists(dotfile_path):
333 # TODO(derat): Consider using _get_file_content() to get the file as of
334 # this commit instead of the on-disk version. This may have a noticeable
335 # performance impact, as each call to _get_file_content() runs git.
336 with open(dotfile_path, 'r') as dotfile:
337 for line in dotfile.readlines():
338 line = line.strip()
339 if line.startswith('#'):
340 continue
341 if line.endswith('/'):
342 line += '*'
343 wildcards.append(line)
344 cache[directory] = wildcards
345
346 return cache[directory]
347
348
349def _path_is_ignored(path, cache):
350 """Check whether a path is ignored by _IGNORE_FILE.
351
352 Args:
353 path: A string containing a path.
354 cache: A dictionary (opaque to caller) caching previously-read wildcards.
355
356 Returns:
357 True if a file named _IGNORE_FILE in one of the passed-in path's parent
358 directories contains a wildcard matching the path.
359 """
360 # Skip ignore files.
361 if os.path.basename(path) == _IGNORE_FILE:
362 return True
363
364 path = os.path.abspath(path)
365 base = os.getcwd()
366
367 prefix = os.path.dirname(path)
368 while prefix.startswith(base):
369 rel_path = path[len(prefix) + 1:]
370 for wildcard in _get_ignore_wildcards(prefix, cache):
371 if fnmatch.fnmatch(rel_path, wildcard):
372 return True
373 prefix = os.path.dirname(prefix)
374
375 return False
376
377
Mike Frysinger292b45d2014-11-25 01:17:10 -0500378def _get_affected_files(commit, include_deletes=False, relative=False,
379 include_symlinks=False, include_adds=True,
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700380 full_details=False, use_ignore_files=True):
Peter Ammon811f6702014-06-12 15:45:38 -0700381 """Returns list of file paths that were modified/added, excluding symlinks.
382
383 Args:
384 commit: The commit
385 include_deletes: If true, we'll include deleted files in the result
386 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500387 include_symlinks: If true, we'll include symlinks in the result
388 include_adds: If true, we'll include new files in the result
389 full_details: If False, return filenames, else return structured results.
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700390 use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files.
Peter Ammon811f6702014-06-12 15:45:38 -0700391
392 Returns:
393 A list of modified/added (and perhaps deleted) files
394 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500395 if not relative and full_details:
396 raise ValueError('full_details only supports relative paths currently')
397
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700398 if commit == PRE_SUBMIT:
399 return _run_command(['git', 'diff-index', '--cached',
400 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500401
402 path = os.getcwd()
Mike Frysingerb2496652019-09-12 23:35:46 -0400403 # {<commit>: {<path1>: <content>, <path2>: <content>}}
404 cache = CACHE.get_subcache('get_affected_files')
405 if path not in cache:
406 cache[path] = git.RawDiff(path, '%s^!' % commit)
407 files = cache[path]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500408
409 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500410 if not include_symlinks:
411 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500412
413 if not include_deletes:
414 files = [x for x in files if x.status != 'D']
415
Mike Frysinger292b45d2014-11-25 01:17:10 -0500416 if not include_adds:
417 files = [x for x in files if x.status != 'A']
418
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700419 if use_ignore_files:
420 cache = {}
421 is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache)
422 files = [x for x in files if not is_ignored(x)]
423
Mike Frysinger292b45d2014-11-25 01:17:10 -0500424 if full_details:
425 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500426 return files
427 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500428 # Caller only cares about filenames.
429 files = [x.dst_file if x.dst_file else x.src_file for x in files]
430 if relative:
431 return files
432 else:
433 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700434
435
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700436def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700437 """Returns a list of commits for this review."""
Mike Frysingere300c7d2019-09-12 23:33:52 -0400438 cmd = ['git', 'log', '--no-merges', '--format=%H',
439 '%s..' % _get_upstream_branch()]
Ryan Cui72834d12011-05-05 14:51:33 -0700440 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700441
Ryan Cui1562fb82011-05-09 11:01:31 -0700442
Ryan Cuiec4d6332011-05-02 14:15:25 -0700443def _get_commit_desc(commit):
444 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700445 if commit == PRE_SUBMIT:
446 return ''
Mike Frysingerb2496652019-09-12 23:35:46 -0400447
448 # {<commit>: <content>}
449 cache = CACHE.get_subcache('get_commit_desc')
450 if commit not in cache:
Mike Frysinger4efdee72019-11-04 10:57:01 -0500451 cache[commit] = _run_command(['git', 'log', '--format=%B',
Mike Frysingerb2496652019-09-12 23:35:46 -0400452 commit + '^!'])
453 return cache[commit]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700454
455
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800456def _check_lines_in_diff(commit, files, check_callable, error_description):
457 """Checks given file for errors via the given check.
458
459 This is a convenience function for common per-line checks. It goes through all
460 files and returns a HookFailure with the error description listing all the
461 failures.
462
463 Args:
464 commit: The commit we're working on.
465 files: The files to check.
466 check_callable: A callable that takes a line and returns True if this line
467 _fails_ the check.
468 error_description: A string describing the error.
469 """
470 errors = []
471 for afile in files:
472 for line_num, line in _get_file_diff(afile, commit):
Bernie Thompson8e26f742020-07-23 14:32:31 -0700473 result = check_callable(line)
474 if result:
475 msg = f'{afile}, line {line_num}'
476 if isinstance(result, str):
477 msg += f': {result}'
478 errors.append(msg)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800479 if errors:
480 return HookFailure(error_description, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400481 return None
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800482
483
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900484def _parse_common_inclusion_options(options):
485 """Parses common hook options for including/excluding files.
486
487 Args:
488 options: Option string list.
489
490 Returns:
491 (included, excluded) where each one is a list of regex strings.
492 """
493 parser = argparse.ArgumentParser()
494 parser.add_argument('--exclude_regex', action='append')
495 parser.add_argument('--include_regex', action='append')
496 opts = parser.parse_args(options)
497 included = opts.include_regex or []
498 excluded = opts.exclude_regex or []
499 return included, excluded
500
501
Ryan Cuiec4d6332011-05-02 14:15:25 -0700502# Common Hooks
503
Ryan Cui1562fb82011-05-09 11:01:31 -0700504
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900505def _check_no_long_lines(_project, commit, options=()):
Mike Frysinger55f85b52014-12-18 14:45:21 -0500506 """Checks there are no lines longer than MAX_LEN in any of the text files."""
Keigo Oka9732e382019-06-28 17:44:59 +0900507 LONG_LINE_OK_PATHS = [
508 # Go has no line length limit.
509 # https://golang.org/doc/effective_go.html#formatting
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400510 r'.*\.go$',
Mike Frysingerf8961942020-05-15 00:36:31 -0400511 # Python does its own long line checks via pylint.
512 r'.*\.py$',
Keigo Oka9732e382019-06-28 17:44:59 +0900513 ]
Mike Frysinger55f85b52014-12-18 14:45:21 -0500514
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900515 DEFAULT_MAX_LENGTHS = [
516 # Java's line length limit is 100 chars.
517 # https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md
518 (r'.*\.java$', 100),
Mike Frysingerf8961942020-05-15 00:36:31 -0400519 # Rust's line length limit is 100 chars.
520 (r'.*\.rs$', 100),
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900521 ]
522
Ryan Cuiec4d6332011-05-02 14:15:25 -0700523 MAX_LEN = 80
524
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900525 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700526 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900527 included + COMMON_INCLUDED_PATHS,
Keigo Oka9732e382019-06-28 17:44:59 +0900528 excluded + COMMON_EXCLUDED_PATHS + LONG_LINE_OK_PATHS)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700529
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900530 errors = []
Ryan Cuiec4d6332011-05-02 14:15:25 -0700531 for afile in files:
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700532 skip_regexps = (
533 r'https?://',
534 r'^#\s*(define|include|import|pragma|if|ifndef|endif)\b',
535 )
536
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900537 max_len = MAX_LEN
538
539 for expr, length in DEFAULT_MAX_LENGTHS:
540 if re.search(expr, afile):
541 max_len = length
542 break
543
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700544 if os.path.basename(afile).startswith('OWNERS'):
545 # File paths can get long, and there's no way to break them up into
546 # multiple lines.
547 skip_regexps += (
548 r'^include\b',
549 r'file:',
550 )
551
552 skip_regexps = [re.compile(x) for x in skip_regexps]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700553 for line_num, line in _get_file_diff(afile, commit):
554 # Allow certain lines to exceed the maxlen rule.
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900555 if len(line) <= max_len or any(x.search(line) for x in skip_regexps):
Jon Salz98255932012-08-18 14:48:02 +0800556 continue
557
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900558 errors.append('%s, line %s, %s chars, over %s chars' %
559 (afile, line_num, len(line), max_len))
Jon Salz98255932012-08-18 14:48:02 +0800560 if len(errors) == 5: # Just show the first 5 errors.
561 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700562
563 if errors:
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900564 msg = 'Found lines longer than the limit (first 5 shown):'
Ryan Cui1562fb82011-05-09 11:01:31 -0700565 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400566 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700567
Ryan Cuiec4d6332011-05-02 14:15:25 -0700568
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900569def _check_no_stray_whitespace(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700570 """Checks that there is no stray whitespace at source lines end."""
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900571 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700572 files = _filter_files(_get_affected_files(commit),
Tomasz Figa375b9622020-09-22 14:25:07 +0000573 included + COMMON_INCLUDED_PATHS + [r'^.*\.md$'],
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900574 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800575 return _check_lines_in_diff(commit, files,
576 lambda line: line.rstrip() != line,
577 'Found line ending with white space in:')
Ryan Cui1562fb82011-05-09 11:01:31 -0700578
Ryan Cuiec4d6332011-05-02 14:15:25 -0700579
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900580def _check_no_tabs(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700581 """Checks there are no unexpanded tabs."""
Mike Frysingercd134512017-10-26 04:36:33 -0400582 # Don't add entire repos here. Update the PRESUBMIT.cfg in each repo instead.
Bob Haarman0dc1f942020-10-03 00:06:59 +0000583 # We only allow known specific filetypes here that show up in all repos.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700584 TAB_OK_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400585 r'.*\.ebuild$',
586 r'.*\.eclass$',
587 r'.*\.go$',
588 r'.*/[M|m]akefile$',
589 r'.*\.mk$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700590 ]
591
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900592 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700593 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900594 included + COMMON_INCLUDED_PATHS,
595 excluded + COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800596 return _check_lines_in_diff(commit, files,
597 lambda line: '\t' in line,
598 'Found a tab character in:')
Ryan Cuiec4d6332011-05-02 14:15:25 -0700599
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800600
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700601def _read_terms_file(terms_file):
602 """Read list of words from file, skipping comments and blank lines."""
603 file_terms = set()
604 for line in osutils.ReadFile(terms_file).splitlines():
605 # Allow comment and blank lines.
606 line = line.split('#', 1)[0]
607 if not line:
608 continue
609 file_terms.add(line)
610 return file_terms
611
612
Bernie Thompson8e26f742020-07-23 14:32:31 -0700613def _check_keywords(_project, commit, options=()):
614 """Checks there are no blocked keywords in commit content."""
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700615 # Read options from override list.
Bernie Thompson8e26f742020-07-23 14:32:31 -0700616 parser = argparse.ArgumentParser()
617 parser.add_argument('--exclude_regex', action='append', default=[])
618 parser.add_argument('--include_regex', action='append', default=[])
619 parser.add_argument('--block', action='append', default=[])
620 parser.add_argument('--unblock', action='append', default=[])
621 opts = parser.parse_args(options)
622
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700623 # Read blocked word list.
624 blocked_terms_file = os.path.join(_get_hooks_dir(), BLOCKED_TERMS_FILE)
625 common_keywords = _read_terms_file(blocked_terms_file)
626
627 # Read unblocked word list. Global list is skipped if local list exists.
628 unblocked_terms_file = os.path.join(_get_hooks_dir(), UNBLOCKED_TERMS_FILE)
629 if os.path.isfile(os.path.join(_project.dir, UNBLOCKED_TERMS_FILE)):
630 unblocked_terms_file = os.path.join(_project.dir, UNBLOCKED_TERMS_FILE)
631 unblocked_words = _read_terms_file(unblocked_terms_file)
632 unblocked_words.update(opts.unblock)
633
Bernie Thompson8e26f742020-07-23 14:32:31 -0700634 keywords = set(common_keywords | set(opts.block))
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700635 keywords = sorted(keywords - unblocked_words)
Mike Frysinger6140f572020-09-10 04:52:46 -0400636 files = _filter_files(
637 _get_affected_files(commit),
Tomasz Figa375b9622020-09-22 14:25:07 +0000638 opts.include_regex + COMMON_INCLUDED_PATHS + [r'^.*\.md$'],
Mike Frysinger6140f572020-09-10 04:52:46 -0400639 opts.exclude_regex + COMMON_EXCLUDED_PATHS)
Bernie Thompson8e26f742020-07-23 14:32:31 -0700640 errors = []
641
642 def _check_line(line):
Laurent Chavey434af9a2020-09-28 22:25:16 +0900643 # Store information about each span matching blocking regex.
644 # to match unblocked regex with blocked reg ex match.
645 # [{'span':re.span, - overlap of matching regex in line
646 # 'group':re.group, - matching term
647 # 'blocked':bool, - True: matching blocked, False: matching unblocked
648 # 'keyword':regex, - block regex
649 # }, ...]
650 blocked_span = []
651 # Store information about each span matching unblocking regex.
652 # [re.span, ...]
653 unblocked_span = []
654
Bernie Thompson8e26f742020-07-23 14:32:31 -0700655 for word in keywords:
Laurent Chavey434af9a2020-09-28 22:25:16 +0900656 for match in re.finditer(word, line, flags=re.I):
657 blocked_span.append({'span' : match.span(),
658 'group' : match.group(0),
659 'blocked' : True,
660 'keyword' : word})
661
662 for unblocked in unblocked_words:
663 for match in re.finditer(unblocked, line, flags=re.I):
664 unblocked_span.append(match.span())
665
666 # Unblock terms that are superset of blocked terms:
667 # blocked := "this.?word"
668 # unblocked := "\.this.?word"
669 # "this line is blocked because of this1word"
670 # "this line is unblocked because of thenew.this1word"
671 #
672 for b in blocked_span:
673 for ub in unblocked_span:
674 if ub[0] <= b['span'][0] and ub[1] >= b['span'][1]:
675 b['blocked'] = False
676 if b['blocked']:
677 return f'Matched "{b["group"]}" with regex of "{b["keyword"]}"'
Bernie Thompson8e26f742020-07-23 14:32:31 -0700678 return False
679
680 diff_errors = _check_lines_in_diff(commit, files, _check_line,
681 'Found a blocked keyword in:')
682 if diff_errors:
683 errors.append(diff_errors)
684
685 line_num = 1
686 commit_desc_errors = []
687 for line in _get_commit_desc(commit).splitlines():
688 result = _check_line(line)
689 if result:
690 commit_desc_errors.append('Commit message, line %s: %s' %
691 (line_num, result))
692 line_num += 1
693 if commit_desc_errors:
694 errors.append(HookFailure('Found a blocked keyword in:',
695 commit_desc_errors))
696 return errors
697
698
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900699def _check_tabbed_indents(_project, commit, options=()):
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800700 """Checks that indents use tabs only."""
701 TABS_REQUIRED_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400702 r'.*\.ebuild$',
703 r'.*\.eclass$',
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800704 ]
705 LEADING_SPACE_RE = re.compile('[\t]* ')
706
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900707 included, excluded = _parse_common_inclusion_options(options)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800708 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900709 included + TABS_REQUIRED_PATHS,
710 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800711 return _check_lines_in_diff(
712 commit, files,
713 lambda line: LEADING_SPACE_RE.match(line) is not None,
714 'Found a space in indentation (must be all tabs):')
Ryan Cui1562fb82011-05-09 11:01:31 -0700715
Ryan Cuiec4d6332011-05-02 14:15:25 -0700716
LaMont Jones872fe762020-02-10 15:36:14 -0700717def _check_gofmt(_project, commit, options=()):
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700718 """Checks that Go files are formatted with gofmt."""
LaMont Jones872fe762020-02-10 15:36:14 -0700719 included, excluded = _parse_common_inclusion_options(options)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700720 errors = []
721 files = _filter_files(_get_affected_files(commit, relative=True),
LaMont Jones872fe762020-02-10 15:36:14 -0700722 included + [r'\.go$'],
723 excluded)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700724
725 for gofile in files:
726 contents = _get_file_content(gofile, commit)
Mike Frysingeraa7dc942019-09-25 00:07:24 -0400727 output = _run_command(cmd=['gofmt', '-l'], input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500728 stderr=subprocess.STDOUT)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700729 if output:
730 errors.append(gofile)
731 if errors:
732 return HookFailure('Files not formatted with gofmt:', errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400733 return None
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700734
735
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600736def _check_rustfmt(_project, commit):
737 """Checks that Rust files are formatted with rustfmt."""
738 errors = []
739 files = _filter_files(_get_affected_files(commit, relative=True),
740 [r'\.rs$'])
741
742 for rustfile in files:
743 contents = _get_file_content(rustfile, commit)
Chirantan Ekbote1da56d52020-07-13 17:35:35 +0900744 output = _run_command(cmd=['rustfmt', '--edition', '2018'],
745 input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500746 stderr=subprocess.STDOUT)
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600747 if output != contents:
748 errors.append(rustfile)
749 if errors:
750 return HookFailure('Files not formatted with rustfmt: '
751 "(run 'cargo fmt' to fix)", errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400752 return None
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600753
754
Keiichi Watanabe6ab73fd2020-07-14 23:42:02 +0900755class CargoClippyArgumentParserError(Exception):
756 """An exception indicating an invalid check_cargo_clippy option."""
757
758
759class CargoClippyArgumentParser(argparse.ArgumentParser):
760 """A argument parser for check_cargo_clippy."""
761
762 def error(self, message):
763 raise CargoClippyArgumentParserError(message)
764
765
766# A cargo project in which clippy runs.
767ClippyProject = collections.namedtuple('ClippyProject', ('root', 'script'))
768
769
770class _AddClippyProjectAction(argparse.Action):
771 """A callback that adds a cargo clippy setting.
772
773 It accepts a value which is in the form of "ROOT[:SCRIPT]".
774 """
775
776 def __call__(self, parser, namespace, values, option_string=None):
777 if getattr(namespace, self.dest, None) is None:
778 setattr(namespace, self.dest, [])
779 spec = values.split(':', 1)
780 if len(spec) == 1:
781 spec += [None]
782
783 if spec[0].startswith('/'):
784 raise CargoClippyArgumentParserError('root path must not start with "/"'
785 f' but "{spec[0]}"')
786
787 clippy = ClippyProject(root=spec[0], script=spec[1])
788 getattr(namespace, self.dest).append(clippy)
789
790
791def _get_cargo_clippy_parser():
792 """Creates a parser for check_cargo_clippy options."""
793
794 parser = CargoClippyArgumentParser()
795 parser.add_argument('--project', action=_AddClippyProjectAction, default=[])
796
797 return parser
798
799
800def _check_cargo_clippy(project, commit, options=()):
801 """Checks that a change doesn't produce cargo-clippy errors."""
802
803 options = list(options)
804 if not options:
805 return []
806 parser = _get_cargo_clippy_parser()
807
808 try:
809 opts = parser.parse_args(options)
810 except CargoClippyArgumentParserError as e:
811 return [HookFailure('invalid check_cargo_clippy option is given.'
812 f' Please check PRESUBMIT.cfg is correct: {e}')]
813 files = _get_affected_files(commit)
814
815 errors = []
816 for clippy in opts.project:
817 root = os.path.normpath(os.path.join(project.dir, clippy.root))
818
819 # Check if any file under `root` was modified.
820 modified = False
821 for f in files:
822 if f.startswith(root):
823 modified = True
824 break
825 if not modified:
826 continue
827
828 # Clean cargo's cache when we run clippy for this `root` for the first time.
829 # We don't want to clean the cache between commits to save time when
830 # multiple commits are checked.
831 if root not in _check_cargo_clippy.cleaned_root:
832 _run_command(['cargo', 'clean',
833 f'--manifest-path={root}/Cargo.toml'],
834 stderr=subprocess.STDOUT)
835 _check_cargo_clippy.cleaned_root.add(root)
836
837 cmd = ['cargo', 'clippy', '--all-features', '--all-targets',
838 f'--manifest-path={root}/Cargo.toml',
839 '--', '-D', 'warnings']
840 # Overwrite the clippy command if a project-specific script is specified.
841 if clippy.script:
842 cmd = [os.path.join(project.dir, clippy.script)]
843
844 output = _run_command(cmd, stderr=subprocess.STDOUT)
845 error = re.search(r'^error: ', output, flags=re.MULTILINE)
846 if error:
847 msg = output[error.start():]
848 errors.append(HookFailure(msg))
849
850 return errors
851
852
853# Stores cargo projects in which `cargo clean` ran.
854_check_cargo_clippy.cleaned_root = set()
855
856
Mike Frysingerae409522014-02-01 03:16:11 -0500857def _check_change_has_test_field(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700858 """Check for a non-empty 'TEST=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500859 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700860
Cheng Yuehb707c522020-01-02 14:06:59 +0800861 if not re.search(TEST_FIELD_RE, _get_commit_desc(commit)):
Mike Frysingered9b2a02019-12-12 18:52:32 -0500862 msg = ('Changelist description needs TEST field (after first line)\n%s' %
863 (SEE_ALSO,))
Ryan Cui1562fb82011-05-09 11:01:31 -0700864 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400865 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700866
Ryan Cuiec4d6332011-05-02 14:15:25 -0700867
Mike Frysingerae409522014-02-01 03:16:11 -0500868def _check_change_has_valid_cq_depend(_project, commit):
Jason D. Clinton299e3222019-05-23 09:42:03 -0600869 """Check for a correctly formatted Cq-Depend field in the commit message."""
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700870 desc = _get_commit_desc(commit)
Jason D. Clinton299e3222019-05-23 09:42:03 -0600871 msg = 'Changelist has invalid Cq-Depend target.'
872 example = 'Example: Cq-Depend: chromium:1234, chrome-internal:2345'
David Jamesc3b68b32013-04-03 09:17:03 -0700873 try:
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700874 patch.GetPaladinDeps(desc)
David Jamesc3b68b32013-04-03 09:17:03 -0700875 except ValueError as ex:
876 return HookFailure(msg, [example, str(ex)])
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700877 # Check that Cq-Depend is in the same paragraph as Change-Id.
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500878 msg = 'Cq-Depend is not in the same paragraph as Change-Id.'
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700879 paragraphs = desc.split('\n\n')
880 for paragraph in paragraphs:
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500881 if (re.search(r'^Cq-Depend:', paragraph, re.M) and not
882 re.search('^Change-Id:', paragraph, re.M)):
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700883 return HookFailure(msg)
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500884
885 # We no longer support CQ-DEPEND= lines.
886 if re.search(r'^CQ-DEPEND[=:]', desc, re.M):
887 return HookFailure(
888 'CQ-DEPEND= is no longer supported. Please see:\n'
889 'https://chromium.googlesource.com/chromiumos/docs/+/HEAD/'
890 'contributing.md#CQ-DEPEND')
891
Mike Frysinger8cf80812019-09-16 23:49:29 -0400892 return None
David Jamesc3b68b32013-04-03 09:17:03 -0700893
894
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800895def _check_change_is_contribution(_project, commit):
896 """Check that the change is a contribution."""
897 NO_CONTRIB = 'not a contribution'
898 if NO_CONTRIB in _get_commit_desc(commit).lower():
899 msg = ('Changelist is not a contribution, this cannot be accepted.\n'
900 'Please remove the "%s" text from the commit message.') % NO_CONTRIB
901 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400902 return None
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800903
904
Alex Deymo643ac4c2015-09-03 10:40:50 -0700905def _check_change_has_bug_field(project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700906 """Check for a correctly formatted 'BUG=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500907 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
908
David James5c0073d2013-04-03 08:48:52 -0700909 OLD_BUG_RE = r'\nBUG=.*chromium-os'
910 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
911 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
912 'the chromium tracker in your BUG= line now.')
913 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700914
Alex Deymo643ac4c2015-09-03 10:40:50 -0700915 # Android internal and external projects use "Bug: " to track bugs in
916 # buganizer.
917 BUG_COLON_REMOTES = (
918 'aosp',
919 'goog',
920 )
921 if project.remote in BUG_COLON_REMOTES:
922 BUG_RE = r'\nBug: ?([Nn]one|\d+)'
923 if not re.search(BUG_RE, _get_commit_desc(commit)):
924 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500925 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700926 'Bug: 9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500927 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700928 return HookFailure(msg)
929 else:
Jorge Lucangeli Obesdce214e2017-10-25 15:04:39 -0400930 BUG_RE = r'\nBUG=([Nn]one|(chromium|b):\d+)'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700931 if not re.search(BUG_RE, _get_commit_desc(commit)):
932 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500933 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700934 'BUG=chromium:9999 (for public tracker)\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700935 'BUG=b:9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500936 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700937 return HookFailure(msg)
Ryan Cui1562fb82011-05-09 11:01:31 -0700938
Cheng Yuehb707c522020-01-02 14:06:59 +0800939 TEST_BEFORE_BUG_RE = TEST_FIELD_RE + r'.*' + BUG_RE
940
941 if re.search(TEST_BEFORE_BUG_RE, _get_commit_desc(commit), re.DOTALL):
942 msg = ('The BUG field must come before the TEST field.\n%s' %
943 (SEE_ALSO,))
944 return HookFailure(msg)
945
Mike Frysinger8cf80812019-09-16 23:49:29 -0400946 return None
947
Ryan Cuiec4d6332011-05-02 14:15:25 -0700948
Jack Neus8edbf642019-07-10 16:08:31 -0600949def _check_change_no_include_oem(project, commit):
950 """Check that the change does not reference OEMs."""
951 ALLOWLIST = {
952 'chromiumos/platform/ec',
953 # Used by unit tests.
954 'project',
955 }
956 if project.name not in ALLOWLIST:
957 return None
958
Mike Frysingerbb34a222019-07-31 14:40:46 -0400959 TAGS = {
Jack Neus8edbf642019-07-10 16:08:31 -0600960 'Reviewed-on',
961 'Reviewed-by',
962 'Signed-off-by',
963 'Commit-Ready',
964 'Tested-by',
965 'Commit-Queue',
Jack Neus8edbf642019-07-10 16:08:31 -0600966 'Acked-by',
967 'Modified-by',
968 'CC',
969 'Suggested-by',
970 'Reported-by',
971 'Acked-for-chrome-by',
LaMont Jones237f3ef2020-01-22 10:40:52 -0700972 'Cq-Cl-Tag',
LaMont Jonesfb5e8bf2020-03-03 12:50:06 -0700973 'Cq-Include-Trybots',
Mike Frysingerbb34a222019-07-31 14:40:46 -0400974 }
Jack Neus8edbf642019-07-10 16:08:31 -0600975
976 # Ignore tags, which could reasonably contain OEM names
977 # (e.g. Reviewed-by: foo@oem.corp-partner.google.com).
Jack Neus8edbf642019-07-10 16:08:31 -0600978 commit_message = ' '.join(
Mike Frysingerbb34a222019-07-31 14:40:46 -0400979 x for x in _get_commit_desc(commit).splitlines()
980 if ':' not in x or x.split(':', 1)[0] not in TAGS)
981
Jack Neus8edbf642019-07-10 16:08:31 -0600982 commit_message = re.sub(r'[\s_-]+', ' ', commit_message)
983
984 # Exercise caution when expanding these lists. Adding a name
985 # could indicate a new relationship with a company!
986 OEMS = ['hp', 'hewlett packard', 'dell', 'lenovo', 'acer', 'asus', 'samsung']
987 ODMS = [
988 'bitland', 'compal', 'haier', 'huaqin', 'inventec', 'lg', 'pegatron',
989 'pegatron(ems)', 'quanta', 'samsung', 'wistron'
990 ]
991
992 for name_type, name_list in [('OEM', OEMS), ('ODM', ODMS)]:
993 # Construct regex
994 name_re = r'\b(%s)\b' % '|'.join([re.escape(x) for x in name_list])
995 matches = [x[0] for x in re.findall(name_re, commit_message, re.IGNORECASE)]
Mike Frysingere52b1bc2019-09-16 23:45:41 -0400996 if matches:
Jack Neus8edbf642019-07-10 16:08:31 -0600997 # If there's a match, throw an error.
998 error_msg = ('Changelist description contains the name of an'
999 ' %s: "%s".' % (name_type, '","'.join(matches)))
1000 return HookFailure(error_msg)
1001
Mike Frysinger8cf80812019-09-16 23:49:29 -04001002 return None
1003
Jack Neus8edbf642019-07-10 16:08:31 -06001004
Mike Frysinger292b45d2014-11-25 01:17:10 -05001005def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -07001006 """Check that we're not missing a revbump of an ebuild in the given commit.
1007
1008 If the given commit touches files in a directory that has ebuilds somewhere
1009 up the directory hierarchy, it's very likely that we need an ebuild revbump
1010 in order for those changes to take effect.
1011
1012 It's not totally trivial to detect a revbump, so at least detect that an
1013 ebuild with a revision number in it was touched. This should handle the
1014 common case where we use a symlink to do the revbump.
1015
1016 TODO: it would be nice to enhance this hook to:
1017 * Handle cases where people revbump with a slightly different syntax. I see
1018 one ebuild (puppy) that revbumps with _pN. This is a false positive.
1019 * Catches cases where people aren't using symlinks for revbumps. If they
1020 edit a revisioned file directly (and are expected to rename it for revbump)
1021 we'll miss that. Perhaps we could detect that the file touched is a
1022 symlink?
1023
1024 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
1025 still better off than without this check.
1026
1027 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001028 project: The Project to look at
Doug Anderson42b8a052013-06-26 10:45:36 -07001029 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -05001030 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -07001031
1032 Returns:
1033 A HookFailure or None.
1034 """
Mike Frysinger011af942014-01-17 16:12:22 -05001035 # If this is the portage-stable overlay, then ignore the check. It's rare
1036 # that we're doing anything other than importing files from upstream, so
1037 # forcing a rev bump makes no sense.
Bob Haarman0dc1f942020-10-03 00:06:59 +00001038 allowlist = (
Mike Frysinger011af942014-01-17 16:12:22 -05001039 'chromiumos/overlays/portage-stable',
1040 )
Bob Haarman0dc1f942020-10-03 00:06:59 +00001041 if project.name in allowlist:
Mike Frysinger011af942014-01-17 16:12:22 -05001042 return None
1043
Mike Frysinger292b45d2014-11-25 01:17:10 -05001044 def FinalName(obj):
1045 # If the file is being deleted, then the dst_file is not set.
1046 if obj.dst_file is None:
1047 return obj.src_file
1048 else:
1049 return obj.dst_file
1050
Stephen Boyd6bf5ea82020-10-15 00:02:07 -07001051 def AllowedPath(obj):
1052 allowed_files = {'ChangeLog', 'Manifest', 'metadata.xml'}
1053 allowed_directories = {'profiles'}
1054
1055 affected = pathlib.Path(FinalName(obj))
1056 if affected.name in allowed_files:
1057 return True
1058
1059 for directory in allowed_directories:
1060 if directory in affected.parts:
1061 return True
1062
1063 return False
1064
Mike Frysinger292b45d2014-11-25 01:17:10 -05001065 affected_path_objs = _get_affected_files(
1066 commit, include_deletes=True, include_symlinks=True, relative=True,
1067 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -07001068
Stephen Boyd6bf5ea82020-10-15 00:02:07 -07001069 # Don't yell about changes to allowed files or directories...
Mike Frysinger292b45d2014-11-25 01:17:10 -05001070 affected_path_objs = [x for x in affected_path_objs
Stephen Boyd6bf5ea82020-10-15 00:02:07 -07001071 if not AllowedPath(x)]
Mike Frysinger292b45d2014-11-25 01:17:10 -05001072 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -07001073 return None
1074
1075 # If we've touched any file named with a -rN.ebuild then we'll say we're
1076 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -05001077 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
1078 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -07001079 if touched_revved_ebuild:
1080 return None
1081
Mike Frysinger292b45d2014-11-25 01:17:10 -05001082 # If we're creating new ebuilds from scratch, then we don't need an uprev.
1083 # Find all the dirs that new ebuilds and ignore their files/.
1084 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
1085 if FinalName(x).endswith('.ebuild') and x.status == 'A']
1086 affected_path_objs = [obj for obj in affected_path_objs
1087 if not any(FinalName(obj).startswith(x)
1088 for x in ebuild_dirs)]
1089 if not affected_path_objs:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001090 return None
Mike Frysinger292b45d2014-11-25 01:17:10 -05001091
Doug Anderson42b8a052013-06-26 10:45:36 -07001092 # We want to examine the current contents of all directories that are parents
1093 # of files that were touched (up to the top of the project).
1094 #
1095 # ...note: we use the current directory contents even though it may have
1096 # changed since the commit we're looking at. This is just a heuristic after
1097 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -05001098 if project_top is None:
1099 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -07001100 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -05001101 for obj in affected_path_objs:
1102 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -07001103 while os.path.exists(path) and not os.path.samefile(path, project_top):
1104 dirs_to_check.add(path)
1105 path = os.path.dirname(path)
1106
1107 # Look through each directory. If it's got an ebuild in it then we'll
1108 # consider this as a case when we need a revbump.
Gwendal Grignoua3086c32014-12-09 11:17:22 -08001109 affected_paths = set(os.path.join(project_top, FinalName(x))
1110 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -07001111 for dir_path in dirs_to_check:
1112 contents = os.listdir(dir_path)
1113 ebuilds = [os.path.join(dir_path, path)
1114 for path in contents if path.endswith('.ebuild')]
1115 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
1116
C Shapiroae157ae2017-09-18 16:24:03 -06001117 affected_paths_under_9999_ebuilds = set()
1118 for affected_path in affected_paths:
1119 for ebuild_9999 in ebuilds_9999:
1120 ebuild_dir = os.path.dirname(ebuild_9999)
1121 if affected_path.startswith(ebuild_dir):
1122 affected_paths_under_9999_ebuilds.add(affected_path)
1123
1124 # If every file changed exists under a 9999 ebuild, then skip
1125 if len(affected_paths_under_9999_ebuilds) == len(affected_paths):
1126 continue
1127
Doug Anderson42b8a052013-06-26 10:45:36 -07001128 # If the -9999.ebuild file was touched the bot will uprev for us.
1129 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -05001130 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -07001131 continue
1132
1133 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -05001134 return HookFailure('Changelist probably needs a revbump of an ebuild, '
1135 'or a -r1.ebuild symlink if this is a new ebuild:\n'
1136 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -07001137
1138 return None
1139
1140
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001141def _check_ebuild_eapi(project, commit):
Mike Frysinger948284a2018-02-01 15:22:56 -05001142 """Make sure we have people use EAPI=5 or newer with custom ebuilds.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001143
1144 We want to get away from older EAPI's as it makes life confusing and they
1145 have less builtin error checking.
1146
1147 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001148 project: The Project to look at
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001149 commit: The commit to look at
1150
1151 Returns:
1152 A HookFailure or None.
1153 """
1154 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -05001155 # that we're doing anything other than importing files from upstream, and
1156 # we shouldn't be rewriting things fundamentally anyways.
Bob Haarman0dc1f942020-10-03 00:06:59 +00001157 allowlist = (
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001158 'chromiumos/overlays/portage-stable',
1159 )
Bob Haarman0dc1f942020-10-03 00:06:59 +00001160 if project.name in allowlist:
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001161 return None
1162
Mike Frysinger948284a2018-02-01 15:22:56 -05001163 BAD_EAPIS = ('0', '1', '2', '3', '4')
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001164
1165 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
1166
1167 ebuilds_re = [r'\.ebuild$']
1168 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1169 ebuilds_re)
1170 bad_ebuilds = []
1171
1172 for ebuild in ebuilds:
1173 # If the ebuild does not specify an EAPI, it defaults to 0.
1174 eapi = '0'
1175
1176 lines = _get_file_content(ebuild, commit).splitlines()
1177 if len(lines) == 1:
1178 # This is most likely a symlink, so skip it entirely.
1179 continue
1180
1181 for line in lines:
1182 m = get_eapi.match(line)
1183 if m:
1184 # Once we hit the first EAPI line in this ebuild, stop processing.
1185 # The spec requires that there only be one and it be first, so
1186 # checking all possible values is pointless. We also assume that
1187 # it's "the" EAPI line and not something in the middle of a heredoc.
1188 eapi = m.group(1)
1189 break
1190
1191 if eapi in BAD_EAPIS:
1192 bad_ebuilds.append((ebuild, eapi))
1193
1194 if bad_ebuilds:
1195 # pylint: disable=C0301
Mike Frysingerc6114f42020-05-15 00:55:05 -04001196 url = 'https://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001197 # pylint: enable=C0301
1198 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -05001199 'These ebuilds are using old EAPIs. If these are imported from\n'
1200 'Gentoo, then you may ignore and upload once with the --no-verify\n'
Mike Frysingerc6114f42020-05-15 00:55:05 -04001201 'flag. Otherwise, please update to 7 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001202 '\t%s\n'
1203 'See this guide for more details:\n%s\n' %
1204 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
1205
Mike Frysinger8cf80812019-09-16 23:49:29 -04001206 return None
1207
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001208
Mike Frysinger89bdb852014-02-01 05:26:26 -05001209def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -05001210 """Make sure we use the new style KEYWORDS when possible in ebuilds.
1211
1212 If an ebuild generally does not care about the arch it is running on, then
1213 ebuilds should flag it with one of:
1214 KEYWORDS="*" # A stable ebuild.
1215 KEYWORDS="~*" # An unstable ebuild.
1216 KEYWORDS="-* ..." # Is known to only work on specific arches.
1217
1218 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001219 project: The Project to look at
Mike Frysingerc51ece72014-01-17 16:23:40 -05001220 commit: The commit to look at
1221
1222 Returns:
1223 A HookFailure or None.
1224 """
Bob Haarman0dc1f942020-10-03 00:06:59 +00001225 ALLOWLIST = set(('*', '-*', '~*'))
Mike Frysingerc51ece72014-01-17 16:23:40 -05001226
1227 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
1228
Mike Frysinger89bdb852014-02-01 05:26:26 -05001229 ebuilds_re = [r'\.ebuild$']
1230 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1231 ebuilds_re)
1232
Mike Frysinger8d42d742014-09-22 15:50:21 -04001233 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -05001234 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -04001235 # We get the full content rather than a diff as the latter does not work
1236 # on new files (like when adding new ebuilds).
1237 lines = _get_file_content(ebuild, commit).splitlines()
1238 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -05001239 m = get_keywords.match(line)
1240 if m:
1241 keywords = set(m.group(1).split())
Bob Haarman0dc1f942020-10-03 00:06:59 +00001242 if not keywords or ALLOWLIST - keywords != ALLOWLIST:
Mike Frysingerc51ece72014-01-17 16:23:40 -05001243 continue
1244
Mike Frysinger8d42d742014-09-22 15:50:21 -04001245 bad_ebuilds.append(ebuild)
1246
1247 if bad_ebuilds:
1248 return HookFailure(
1249 '%s\n'
1250 'Please update KEYWORDS to use a glob:\n'
1251 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
1252 ' KEYWORDS="*"\n'
1253 'If the ebuild should be marked unstable (normal for '
1254 'cros-workon / 9999 ebuilds):\n'
1255 ' KEYWORDS="~*"\n'
Mike Frysingerde8efea2015-05-17 03:42:26 -04001256 'If the ebuild needs to be marked for only specific arches, '
Mike Frysinger8d42d742014-09-22 15:50:21 -04001257 'then use -* like so:\n'
1258 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -05001259
Mike Frysinger8cf80812019-09-16 23:49:29 -04001260 return None
1261
Mike Frysingerc51ece72014-01-17 16:23:40 -05001262
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001263def _check_ebuild_licenses(_project, commit):
1264 """Check if the LICENSE field in the ebuild is correct."""
Brian Norris7a610e82016-02-17 12:24:54 -08001265 affected_paths = _get_affected_files(commit, relative=True)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001266 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
1267
1268 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -08001269 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001270
1271 for ebuild in touched_ebuilds:
1272 # Skip virutal packages.
1273 if ebuild.split('/')[-3] == 'virtual':
1274 continue
1275
Alex Kleinb5953522018-08-03 11:44:21 -06001276 # e.g. path/to/overlay/category/package/package.ebuild -> path/to/overlay
1277 overlay_path = os.sep.join(ebuild.split(os.sep)[:-3])
1278
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001279 try:
Brian Norris7a610e82016-02-17 12:24:54 -08001280 ebuild_content = _get_file_content(ebuild, commit)
Alex Kleinb5953522018-08-03 11:44:21 -06001281 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content,
1282 overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001283 except ValueError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001284 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001285
1286 # Also ignore licenses ending with '?'
1287 for license_type in [x for x in license_types
1288 if x not in LICENSES_IGNORE and not x.endswith('?')]:
1289 try:
Alex Kleinb5953522018-08-03 11:44:21 -06001290 licenses_lib.Licensing.FindLicenseType(license_type,
1291 overlay_path=overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001292 except AssertionError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001293 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001294
Mike Frysinger8cf80812019-09-16 23:49:29 -04001295 return None
1296
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001297
Mike Frysingercd363c82014-02-01 05:20:18 -05001298def _check_ebuild_virtual_pv(project, commit):
1299 """Enforce the virtual PV policies."""
1300 # If this is the portage-stable overlay, then ignore the check.
1301 # We want to import virtuals as-is from upstream Gentoo.
Bob Haarman0dc1f942020-10-03 00:06:59 +00001302 allowlist = (
Mike Frysingercd363c82014-02-01 05:20:18 -05001303 'chromiumos/overlays/portage-stable',
1304 )
Bob Haarman0dc1f942020-10-03 00:06:59 +00001305 if project.name in allowlist:
Mike Frysingercd363c82014-02-01 05:20:18 -05001306 return None
1307
1308 # We assume the repo name is the same as the dir name on disk.
1309 # It would be dumb to not have them match though.
Alex Deymo643ac4c2015-09-03 10:40:50 -07001310 project_base = os.path.basename(project.name)
Mike Frysingercd363c82014-02-01 05:20:18 -05001311
1312 is_variant = lambda x: x.startswith('overlay-variant-')
1313 is_board = lambda x: x.startswith('overlay-')
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001314 is_baseboard = lambda x: x.startswith('baseboard-')
1315 is_chipset = lambda x: x.startswith('chipset-')
1316 is_project = lambda x: x.startswith('project-')
Mike Frysingercd363c82014-02-01 05:20:18 -05001317 is_private = lambda x: x.endswith('-private')
1318
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001319 is_special_overlay = lambda x: (is_board(x) or is_chipset(x) or
1320 is_baseboard(x) or is_project(x))
1321
Mike Frysingercd363c82014-02-01 05:20:18 -05001322 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
1323
1324 ebuilds_re = [r'\.ebuild$']
1325 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1326 ebuilds_re)
1327 bad_ebuilds = []
1328
1329 for ebuild in ebuilds:
1330 m = get_pv.match(ebuild)
1331 if m:
1332 overlay = m.group(1)
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001333 if not overlay or not is_special_overlay(overlay):
Alex Deymo643ac4c2015-09-03 10:40:50 -07001334 overlay = project_base
Mike Frysingercd363c82014-02-01 05:20:18 -05001335
1336 pv = m.group(3).split('-', 1)[0]
1337
Bernie Thompsone5ee1822016-01-12 14:22:23 -08001338 # Virtual versions >= 4 are special cases used above the standard
1339 # versioning structure, e.g. if one has a board inheriting a board.
Julius Werner0299a2b2020-07-31 18:20:43 -07001340 if pv[0] >= '4':
Bernie Thompsone5ee1822016-01-12 14:22:23 -08001341 want_pv = pv
Mike Frysingercd363c82014-02-01 05:20:18 -05001342 elif is_board(overlay):
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001343 if is_private(overlay):
1344 want_pv = '3.5' if is_variant(overlay) else '3'
1345 elif is_board(overlay):
1346 want_pv = '2.5' if is_variant(overlay) else '2'
1347 elif is_baseboard(overlay):
Julius Werner0299a2b2020-07-31 18:20:43 -07001348 want_pv = '1.9.5' if is_private(overlay) else '1.9'
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001349 elif is_chipset(overlay):
Julius Werner0299a2b2020-07-31 18:20:43 -07001350 want_pv = '1.8.5' if is_private(overlay) else '1.8'
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001351 elif is_project(overlay):
1352 want_pv = '1.7' if is_private(overlay) else '1.5'
Mike Frysingercd363c82014-02-01 05:20:18 -05001353 else:
1354 want_pv = '1'
1355
1356 if pv != want_pv:
1357 bad_ebuilds.append((ebuild, pv, want_pv))
1358
1359 if bad_ebuilds:
1360 # pylint: disable=C0301
1361 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
1362 # pylint: enable=C0301
1363 return HookFailure(
1364 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
1365 '\t%s\n'
1366 'If this is an upstream Gentoo virtual, then you may ignore this\n'
1367 'check (and re-run w/--no-verify). Otherwise, please see this\n'
1368 'page for more details:\n%s\n' %
1369 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
1370 for x in bad_ebuilds]), url))
1371
Mike Frysinger8cf80812019-09-16 23:49:29 -04001372 return None
1373
Mike Frysingercd363c82014-02-01 05:20:18 -05001374
Daniel Erat9d203ff2015-02-17 10:12:21 -07001375def _check_portage_make_use_var(_project, commit):
1376 """Verify that $USE is set correctly in make.conf and make.defaults."""
1377 files = _filter_files(_get_affected_files(commit, relative=True),
1378 [r'(^|/)make.(conf|defaults)$'])
1379
1380 errors = []
1381 for path in files:
1382 basename = os.path.basename(path)
1383
1384 # Has a USE= line already been encountered in this file?
1385 saw_use = False
1386
1387 for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1):
1388 if not line.startswith('USE='):
1389 continue
1390
1391 preserves_use = '${USE}' in line or '$USE' in line
1392
1393 if (basename == 'make.conf' or
1394 (basename == 'make.defaults' and saw_use)) and not preserves_use:
1395 errors.append('%s:%d: missing ${USE}' % (path, i))
1396 elif basename == 'make.defaults' and not saw_use and preserves_use:
1397 errors.append('%s:%d: ${USE} referenced in initial declaration' %
1398 (path, i))
1399
1400 saw_use = True
1401
1402 if errors:
1403 return HookFailure(
1404 'One or more Portage make files appear to set USE incorrectly.\n'
1405 '\n'
1406 'All USE assignments in make.conf and all assignments after the\n'
1407 'initial declaration in make.defaults should contain "${USE}" to\n'
1408 'preserve previously-set flags.\n'
1409 '\n'
1410 'The initial USE declaration in make.defaults should not contain\n'
1411 '"${USE}".\n',
1412 errors)
1413
Mike Frysinger8cf80812019-09-16 23:49:29 -04001414 return None
1415
Daniel Erat9d203ff2015-02-17 10:12:21 -07001416
Mike Frysingerae409522014-02-01 03:16:11 -05001417def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001418 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001419 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001420 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001421 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001422 if not m:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001423 return HookFailure('Last paragraph of description must include Change-Id.')
Ryan Cui1562fb82011-05-09 11:01:31 -07001424
LaMont Jonesfb5e8bf2020-03-03 12:50:06 -07001425 # S-o-b and some other tags always allowed to follow Change-ID in the footer.
1426 allowed_tags = ['Signed-off-by', 'Cq-Cl-Tag', 'Cq-Include-Trybots']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001427
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001428 end = desc[m.end():].strip().splitlines()
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001429 cherry_pick_marker = 'cherry picked from commit'
1430
1431 if end and cherry_pick_marker in end[-1]:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001432 # Cherry picked patches allow more tags in the last paragraph.
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001433 allowed_tags += ['Commit-Queue', 'Commit-Ready', 'Reviewed-by',
1434 'Reviewed-on', 'Tested-by']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001435 end = end[:-1]
1436
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001437 # Note that descriptions could have multiple cherry pick markers.
1438 tag_search = r'^(%s:|\(%s) ' % (':|'.join(allowed_tags), cherry_pick_marker)
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001439
1440 if [x for x in end if not re.search(tag_search, x)]:
1441 return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' %
1442 ':", "'.join(allowed_tags))
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001443
Mike Frysinger8cf80812019-09-16 23:49:29 -04001444 return None
1445
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001446
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001447def _check_commit_message_style(_project, commit):
1448 """Verify that the commit message matches our style.
1449
1450 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
1451 commit hooks.
1452 """
Mike Frysingered9b2a02019-12-12 18:52:32 -05001453 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Mike Frysinger4efdee72019-11-04 10:57:01 -05001454
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001455 desc = _get_commit_desc(commit)
1456
1457 # The first line should be by itself.
1458 lines = desc.splitlines()
1459 if len(lines) > 1 and lines[1]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001460 return HookFailure('The second line of the commit message must be blank.'
1461 '\n%s' % (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001462
1463 # The first line should be one sentence.
1464 if '. ' in lines[0]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001465 return HookFailure('The first line cannot be more than one sentence.\n%s' %
1466 (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001467
1468 # The first line cannot be too long.
1469 MAX_FIRST_LINE_LEN = 100
1470 if len(lines[0]) > MAX_FIRST_LINE_LEN:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001471 return HookFailure('The first line must be less than %i chars.\n%s' %
1472 (MAX_FIRST_LINE_LEN, SEE_ALSO))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001473
Mike Frysinger8cf80812019-09-16 23:49:29 -04001474 return None
1475
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001476
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001477def _check_cros_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001478 """Verifies the Chromium OS license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -07001479
Mike Frysinger98638102014-08-28 00:15:08 -04001480 Should be following the spec:
1481 http://dev.chromium.org/developers/coding-style#TOC-File-headers
1482 """
1483 # For older years, be a bit more flexible as our policy says leave them be.
1484 LICENSE_HEADER = (
Keigo Oka7e880ac2019-07-03 15:03:43 +09001485 r'.*Copyright(?: \(c\))? (20[0-9]{2})(?:-20[0-9]{2})? The Chromium OS '
1486 r'Authors\. All rights reserved\.\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001487 r'.*Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001488 r'be\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001489 r'.*found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -05001490 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001491 )
1492 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1493
1494 # For newer years, be stricter.
Keigo Oka7e880ac2019-07-03 15:03:43 +09001495 BAD_COPYRIGHT_LINE = (
Brian Norris68838dd2018-09-26 18:30:24 -07001496 r'.*Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001497 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001498 )
Keigo Oka7e880ac2019-07-03 15:03:43 +09001499 bad_copyright_re = re.compile(BAD_COPYRIGHT_LINE)
Mike Frysinger98638102014-08-28 00:15:08 -04001500
Shuhei Takahashiabc20f32017-07-10 19:35:45 +09001501 included, excluded = _parse_common_inclusion_options(options)
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001502
Mike Frysinger98638102014-08-28 00:15:08 -04001503 bad_files = []
1504 bad_copyright_files = []
Keigo Oka7e880ac2019-07-03 15:03:43 +09001505 bad_year_files = []
1506
Ken Turnerd07564b2018-02-08 17:57:59 +11001507 files = _filter_files(
1508 _get_affected_files(commit, relative=True),
1509 included + COMMON_INCLUDED_PATHS,
1510 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001511 existing_files = set(_get_affected_files(commit, relative=True,
1512 include_adds=False))
Mike Frysinger98638102014-08-28 00:15:08 -04001513
Keigo Oka7e880ac2019-07-03 15:03:43 +09001514 current_year = str(datetime.datetime.now().year)
Mike Frysinger98638102014-08-28 00:15:08 -04001515 for f in files:
1516 contents = _get_file_content(f, commit)
1517 if not contents:
1518 # Ignore empty files.
1519 continue
1520
Keigo Oka7e880ac2019-07-03 15:03:43 +09001521 m = license_re.search(contents)
1522 if not m:
Mike Frysinger98638102014-08-28 00:15:08 -04001523 bad_files.append(f)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001524 elif bad_copyright_re.search(contents):
Mike Frysinger98638102014-08-28 00:15:08 -04001525 bad_copyright_files.append(f)
1526
Keigo Oka7e880ac2019-07-03 15:03:43 +09001527 if m and f not in existing_files:
1528 year = m.group(1)
1529 if year != current_year:
1530 bad_year_files.append(f)
1531
1532 errors = []
Mike Frysinger98638102014-08-28 00:15:08 -04001533 if bad_files:
1534 msg = '%s:\n%s\n%s' % (
1535 'License must match', license_re.pattern,
1536 'Found a bad header in these files:')
Keigo Oka7e880ac2019-07-03 15:03:43 +09001537 errors.append(HookFailure(msg, bad_files))
Mike Frysinger98638102014-08-28 00:15:08 -04001538 if bad_copyright_files:
1539 msg = 'Do not use (c) in copyright headers in new files:'
Keigo Oka7e880ac2019-07-03 15:03:43 +09001540 errors.append(HookFailure(msg, bad_copyright_files))
1541 if bad_year_files:
1542 msg = 'Use current year (%s) in copyright headers in new files:' % (
1543 current_year)
1544 errors.append(HookFailure(msg, bad_year_files))
Ryan Cuiec4d6332011-05-02 14:15:25 -07001545
Keigo Oka7e880ac2019-07-03 15:03:43 +09001546 return errors
Ryan Cuiec4d6332011-05-02 14:15:25 -07001547
Mike Frysinger8cf80812019-09-16 23:49:29 -04001548
Amin Hassani391efa92018-01-26 17:58:05 -08001549def _check_aosp_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001550 """Verifies the AOSP license/copyright header.
1551
1552 AOSP uses the Apache2 License:
1553 https://source.android.com/source/licenses.html
1554 """
1555 LICENSE_HEADER = (
1556 r"""^[#/\*]*
1557[#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project
1558[#/\*]* ?
1559[#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\);
1560[#/\*]* ?you may not use this file except in compliance with the License\.
1561[#/\*]* ?You may obtain a copy of the License at
1562[#/\*]* ?
1563[#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0
1564[#/\*]* ?
1565[#/\*]* ?Unless required by applicable law or agreed to in writing, software
1566[#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS,
1567[#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """
1568 r"""implied\.
1569[#/\*]* ?See the License for the specific language governing permissions and
1570[#/\*]* ?limitations under the License\.
1571[#/\*]*$
1572"""
1573 )
1574 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1575
Amin Hassani391efa92018-01-26 17:58:05 -08001576 included, excluded = _parse_common_inclusion_options(options)
1577
Ken Turnerd07564b2018-02-08 17:57:59 +11001578 files = _filter_files(
1579 _get_affected_files(commit, relative=True),
1580 included + COMMON_INCLUDED_PATHS,
1581 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Alex Deymof5792ce2015-08-24 22:50:08 -07001582
1583 bad_files = []
1584 for f in files:
1585 contents = _get_file_content(f, commit)
1586 if not contents:
1587 # Ignore empty files.
1588 continue
1589
1590 if not license_re.search(contents):
1591 bad_files.append(f)
1592
1593 if bad_files:
1594 msg = ('License must match:\n%s\nFound a bad header in these files:' %
1595 license_re.pattern)
1596 return HookFailure(msg, bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001597 return None
Alex Deymof5792ce2015-08-24 22:50:08 -07001598
1599
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001600def _check_layout_conf(_project, commit):
1601 """Verifies the metadata/layout.conf file."""
1602 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001603 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001604 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001605 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001606
Mike Frysinger94a670c2014-09-19 12:46:26 -04001607 # Handle multiple overlays in a single commit (like the public tree).
1608 for f in _get_affected_files(commit, relative=True):
1609 if f.endswith(repo_name):
1610 repo_names.append(f)
1611 elif f.endswith(layout_path):
1612 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001613
1614 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -04001615 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001616 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -04001617 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001618
Mike Frysinger94a670c2014-09-19 12:46:26 -04001619 # Gather all the errors in one pass so we show one full message.
1620 all_errors = {}
1621 for layout_path in layout_paths:
1622 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001623
Mike Frysinger94a670c2014-09-19 12:46:26 -04001624 # Make sure the config file is sorted.
1625 data = [x for x in _get_file_content(layout_path, commit).splitlines()
1626 if x and x[0] != '#']
1627 if sorted(data) != data:
1628 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001629
Mike Frysinger94a670c2014-09-19 12:46:26 -04001630 # Require people to set specific values all the time.
1631 settings = (
1632 # TODO: Enable this for everyone. http://crbug.com/408038
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001633 # ('fast caching', 'cache-format = md5-dict'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001634 ('fast manifests', 'thin-manifests = true'),
Mike Frysingerd7734522015-02-26 16:12:43 -05001635 ('extra features', 'profile-formats = portage-2 profile-default-eapi'),
1636 ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001637 )
1638 for reason, line in settings:
1639 if line not in data:
1640 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001641
Mike Frysinger94a670c2014-09-19 12:46:26 -04001642 # Require one of these settings.
Mike Frysinger5fae62d2015-11-11 20:12:15 -05001643 if 'use-manifests = strict' not in data:
1644 errors += ['enable file checking with: use-manifests = strict']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001645
Mike Frysinger94a670c2014-09-19 12:46:26 -04001646 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -04001647 for line in data:
1648 if line.startswith('repo-name = '):
1649 break
1650 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -04001651 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001652
Mike Frysinger94a670c2014-09-19 12:46:26 -04001653 # Summarize all the errors we saw (if any).
1654 lines = ''
1655 for layout_path, errors in all_errors.items():
1656 if errors:
1657 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
1658 if lines:
1659 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
1660 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001661
Mike Frysinger8cf80812019-09-16 23:49:29 -04001662 return None
1663
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001664
Keigo Oka4a09bd92019-05-07 14:01:00 +09001665def _check_no_new_gyp(_project, commit):
1666 """Verifies no project starts to use GYP."""
Keigo Oka4a09bd92019-05-07 14:01:00 +09001667 gypfiles = _filter_files(
1668 _get_affected_files(commit, include_symlinks=True, relative=True),
1669 [r'\.gyp$'])
1670
1671 if gypfiles:
1672 return HookFailure('GYP is deprecated and not allowed in a new project:',
1673 gypfiles)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001674 return None
Keigo Oka4a09bd92019-05-07 14:01:00 +09001675
1676
Ryan Cuiec4d6332011-05-02 14:15:25 -07001677# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001678
Ryan Cui1562fb82011-05-09 11:01:31 -07001679
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001680def _check_clang_format(_project, commit, options=()):
1681 """Runs clang-format on the given project"""
1682 hooks_dir = _get_hooks_dir()
1683 options = list(options)
1684 if commit == PRE_SUBMIT:
1685 options.append('--commit=HEAD')
1686 else:
1687 options.extend(['--commit', commit])
Brian Norris0c62a142018-12-11 13:24:29 -08001688 cmd = [os.path.join(hooks_dir, 'clang-format.py')] + options
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001689 cmd_result = cros_build_lib.run(cmd,
1690 print_cmd=False,
1691 stdout=True,
1692 encoding='utf-8',
1693 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001694 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001695 check=False)
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001696 if cmd_result.returncode:
1697 return HookFailure('clang-format.py errors/warnings\n\n' +
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001698 cmd_result.stdout)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001699 return None
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001700
1701
Mike Frysingerae409522014-02-01 03:16:11 -05001702def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001703 """Runs checkpatch.pl on the given project"""
Tomasz Figabd8faf62020-09-22 14:06:05 +00001704 # Bypass checkpatch for upstream or almost upstream commits, since we do not
1705 # intend to modify the upstream commits when landing them to our branches.
1706 # Any fixes should sent as independent patches.
1707 # The check is retained for FROMLIST and BACKPORT commits, as by definition
1708 # those can be still fixed up.
1709 desc = _get_commit_desc(commit)
1710 if desc.startswith('UPSTREAM:') or desc.startswith('FROMGIT:'):
1711 return None
1712
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001713 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001714 options = list(options)
Brian Norris4cee0502020-06-12 17:02:56 -07001715 if options and options[0].startswith('./') and os.path.exists(options[0]):
1716 cmdpath = options.pop(0)
1717 else:
1718 cmdpath = os.path.join(hooks_dir, 'checkpatch.pl')
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001719 if commit == PRE_SUBMIT:
1720 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
1721 # this case.
1722 options.append('--ignore=MISSING_SIGN_OFF')
Filipe Brandenburger28d48d62015-10-07 09:48:54 -07001723 # Always ignore the check for the MAINTAINERS file. We do not track that
1724 # information on that file in our source trees, so let's suppress the
1725 # warning.
1726 options.append('--ignore=FILE_PATH_CHANGES')
Filipe Brandenburgerce978322015-10-09 10:04:15 -07001727 # Do not complain about the Change-Id: fields, since we use Gerrit.
1728 # Upstream does not want those lines (since they do not use Gerrit), but
1729 # we always do, so disable the check globally.
Daisuke Nojiri4844f892015-10-08 09:54:33 -07001730 options.append('--ignore=GERRIT_CHANGE_ID')
Brian Norris4cee0502020-06-12 17:02:56 -07001731 cmd = [cmdpath] + options + ['-']
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001732 cmd_result = cros_build_lib.run(
1733 cmd, print_cmd=False, input=_get_patch(commit).encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001734 stdout=True, stderr=subprocess.STDOUT, check=False, encoding='utf-8',
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001735 errors='replace')
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001736 if cmd_result.returncode:
Brian Norris4cee0502020-06-12 17:02:56 -07001737 return HookFailure('%s errors/warnings\n\n%s' %
1738 (cmdpath, cmd_result.stdout))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001739 return None
Ryan Cuiec4d6332011-05-02 14:15:25 -07001740
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001741
Brian Norris23c62e92018-11-14 12:25:51 -08001742def _run_kerneldoc(_project, commit, options=()):
1743 """Runs kernel-doc validator on the given project"""
1744 included, excluded = _parse_common_inclusion_options(options)
1745 files = _filter_files(_get_affected_files(commit, relative=True),
1746 included, excluded)
1747 if files:
1748 hooks_dir = _get_hooks_dir()
Brian Norris0c62a142018-12-11 13:24:29 -08001749 cmd = [os.path.join(hooks_dir, 'kernel-doc'), '-none'] + files
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001750 output = _run_command(cmd, stderr=subprocess.STDOUT)
Brian Norris23c62e92018-11-14 12:25:51 -08001751 if output:
Brian Norris0c62a142018-12-11 13:24:29 -08001752 return HookFailure('kernel-doc errors/warnings:',
1753 items=output.splitlines())
Mike Frysinger8cf80812019-09-16 23:49:29 -04001754 return None
Brian Norris23c62e92018-11-14 12:25:51 -08001755
1756
Mike Frysingerae409522014-02-01 03:16:11 -05001757def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -07001758 """Makes sure kernel config changes are not mixed with code changes"""
1759 files = _get_affected_files(commit)
Mike Frysingerf252cfc2019-12-09 17:34:28 -05001760 if len(_filter_files(files, [r'chromeos/config'])) not in [0, len(files)]:
Olof Johanssona96810f2012-09-04 16:20:03 -07001761 return HookFailure('Changes to chromeos/config/ and regular files must '
1762 'be in separate commits:\n%s' % '\n'.join(files))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001763 return None
Anton Staaf815d6852011-08-22 10:08:45 -07001764
Mike Frysingerae409522014-02-01 03:16:11 -05001765
1766def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -07001767 """Checks that all JSON files are syntactically valid."""
Mike Frysinger908be682018-01-04 02:21:50 -05001768 ret = []
1769
1770 files = _filter_files(_get_affected_files(commit, relative=True),
1771 [r'.*\.json$'])
1772 for f in files:
1773 data = _get_file_content(f, commit)
Dale Curtis2975c432011-05-03 17:25:20 -07001774 try:
Mike Frysinger908be682018-01-04 02:21:50 -05001775 json.loads(data)
1776 except Exception as e:
1777 ret.append('%s: Invalid JSON: %s' % (f, e))
1778
1779 if ret:
1780 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001781 return None
Dale Curtis2975c432011-05-03 17:25:20 -07001782
1783
Mike Frysingerae409522014-02-01 03:16:11 -05001784def _check_manifests(_project, commit):
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001785 """Make sure Manifest files only have comments & DIST lines."""
1786 ret = []
Mike Frysinger52b537e2013-08-22 22:59:53 -04001787
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001788 manifests = _filter_files(_get_affected_files(commit, relative=True),
1789 [r'.*/Manifest$'])
1790 for path in manifests:
1791 data = _get_file_content(path, commit)
1792
1793 # Disallow blank files.
1794 if not data.strip():
1795 ret.append('%s: delete empty file' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001796 continue
1797
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001798 # Make sure the last newline isn't omitted.
1799 if data[-1] != '\n':
1800 ret.append('%s: missing trailing newline' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001801
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001802 # Do not allow leading or trailing blank lines.
1803 lines = data.splitlines()
1804 if not lines[0]:
1805 ret.append('%s: delete leading blank lines' % (path,))
1806 if not lines[-1]:
1807 ret.append('%s: delete trailing blank lines' % (path,))
1808
1809 for line in lines:
1810 # Disallow leading/trailing whitespace.
1811 if line != line.strip():
1812 ret.append('%s: remove leading/trailing whitespace: %s' % (path, line))
1813
1814 # Allow blank lines & comments.
1815 line = line.split('#', 1)[0]
1816 if not line:
1817 continue
1818
1819 # All other linse should start with DIST.
1820 if not line.startswith('DIST '):
1821 ret.append('%s: remove non-DIST lines: %s' % (path, line))
1822 break
1823
1824 if ret:
1825 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001826 return None
Mike Frysinger52b537e2013-08-22 22:59:53 -04001827
1828
Mike Frysingerae409522014-02-01 03:16:11 -05001829def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001830 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001831 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001832 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001833 BRANCH_RE = r'\nBRANCH=\S+'
1834
1835 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
1836 msg = ('Changelist description needs BRANCH field (after first line)\n'
1837 'E.g. BRANCH=none or BRANCH=link,snow')
1838 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001839 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001840
1841
Mike Frysinger45334bd2019-11-04 10:42:33 -05001842def _check_change_has_no_branch_field(_project, commit):
1843 """Verify 'BRANCH=' field does not exist in the commit message."""
1844 if commit == PRE_SUBMIT:
1845 return None
1846 BRANCH_RE = r'\nBRANCH=\S+'
1847
1848 if re.search(BRANCH_RE, _get_commit_desc(commit)):
1849 msg = 'This checkout does not use BRANCH= fields. Delete them.'
1850 return HookFailure(msg)
1851 return None
1852
1853
Mike Frysingerae409522014-02-01 03:16:11 -05001854def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001855 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001856 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001857 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001858 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1859
1860 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1861 msg = ('Changelist description needs Signed-off-by: field\n'
1862 'E.g. Signed-off-by: My Name <me@chromium.org>')
1863 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001864 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001865
1866
Mike Frysinger9ab64b12019-11-04 10:53:08 -05001867def _check_change_has_no_signoff_field(_project, commit):
1868 """Verify 'Signed-off-by:' field does not exist in the commit message."""
1869 if commit == PRE_SUBMIT:
1870 return None
1871 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1872
1873 if re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1874 msg = 'This checkout does not use Signed-off-by: tags. Delete them.'
1875 return HookFailure(msg)
1876 return None
1877
1878
Jon Salz3ee59de2012-08-18 13:54:22 +08001879def _run_project_hook_script(script, project, commit):
1880 """Runs a project hook script.
1881
1882 The script is run with the following environment variables set:
1883 PRESUBMIT_PROJECT: The affected project
1884 PRESUBMIT_COMMIT: The affected commit
1885 PRESUBMIT_FILES: A newline-separated list of affected files
1886
1887 The script is considered to fail if the exit code is non-zero. It should
1888 write an error message to stdout.
1889 """
1890 env = dict(os.environ)
Alex Deymo643ac4c2015-09-03 10:40:50 -07001891 env['PRESUBMIT_PROJECT'] = project.name
Jon Salz3ee59de2012-08-18 13:54:22 +08001892 env['PRESUBMIT_COMMIT'] = commit
1893
1894 # Put affected files in an environment variable
1895 files = _get_affected_files(commit)
1896 env['PRESUBMIT_FILES'] = '\n'.join(files)
1897
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001898 cmd_result = cros_build_lib.run(cmd=script,
1899 env=env,
1900 shell=True,
1901 print_cmd=False,
1902 input=os.devnull,
1903 stdout=True,
1904 encoding='utf-8',
1905 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001906 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001907 check=False)
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001908 if cmd_result.returncode:
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001909 stdout = cmd_result.stdout
Jon Salz7b618af2012-08-31 06:03:16 +08001910 if stdout:
1911 stdout = re.sub('(?m)^', ' ', stdout)
1912 return HookFailure('Hook script "%s" failed with code %d%s' %
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001913 (script, cmd_result.returncode,
Jon Salz3ee59de2012-08-18 13:54:22 +08001914 ':\n' + stdout if stdout else ''))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001915 return None
Jon Salz3ee59de2012-08-18 13:54:22 +08001916
1917
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001918def _check_project_prefix(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -05001919 """Require the commit message have a project specific prefix as needed."""
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001920
Brian Norris77608e12018-04-06 10:38:43 -07001921 files = _get_affected_files(commit, include_deletes=True, relative=True)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001922 prefix = os.path.commonprefix(files)
1923 prefix = os.path.dirname(prefix)
1924
1925 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07001926 if not prefix:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001927 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001928
1929 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07001930
1931 # The common files may all be within a subdirectory of the main project
1932 # directory, so walk up the tree until we find an alias file.
1933 # _get_affected_files() should return relative paths, but check against '/' to
1934 # ensure that this loop terminates even if it receives an absolute path.
1935 while prefix and prefix != '/':
1936 alias_file = os.path.join(prefix, '.project_alias')
1937
1938 # If an alias exists, use it.
1939 if os.path.isfile(alias_file):
1940 project_name = osutils.ReadFile(alias_file).strip()
1941
1942 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001943
1944 if not _get_commit_desc(commit).startswith(project_name + ': '):
1945 return HookFailure('The commit title for changes affecting only %s'
1946 ' should start with \"%s: \"'
1947 % (project_name, project_name))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001948 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001949
1950
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001951def _check_filepath_chartype(_project, commit):
1952 """Checks that FilePath::CharType stuff is not used."""
1953
1954 FILEPATH_REGEXP = re.compile('|'.join(
1955 [r'(?:base::)?FilePath::(?:Char|String|StringPiece)Type',
Satoru Takabayashi4ca37922018-08-08 10:16:38 +09001956 r'(?:base::)?FilePath::FromUTF8Unsafe',
1957 r'AsUTF8Unsafe',
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001958 r'FILE_PATH_LITERAL']))
1959 files = _filter_files(_get_affected_files(commit, relative=True),
1960 [r'.*\.(cc|h)$'])
1961
1962 errors = []
1963 for afile in files:
1964 for line_num, line in _get_file_diff(afile, commit):
1965 m = re.search(FILEPATH_REGEXP, line)
1966 if m:
1967 errors.append('%s, line %s has %s' % (afile, line_num, m.group(0)))
1968
1969 if errors:
1970 msg = 'Please assume FilePath::CharType is char (crbug.com/870621):'
1971 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001972 return None
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001973
1974
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001975def _check_exec_files(_project, commit):
1976 """Make +x bits on files."""
1977 # List of files that should never be +x.
1978 NO_EXEC = (
1979 'ChangeLog*',
1980 'COPYING',
1981 'make.conf',
1982 'make.defaults',
1983 'Manifest',
1984 'OWNERS',
1985 'package.use',
1986 'package.keywords',
1987 'package.mask',
1988 'parent',
1989 'README',
1990 'TODO',
1991 '.gitignore',
1992 '*.[achly]',
1993 '*.[ch]xx',
1994 '*.boto',
1995 '*.cc',
1996 '*.cfg',
1997 '*.conf',
1998 '*.config',
1999 '*.cpp',
2000 '*.css',
2001 '*.ebuild',
2002 '*.eclass',
Tatsuhisa Yamaguchi3b053632019-01-10 14:45:14 +09002003 '*.gn',
2004 '*.gni',
Mike Frysingerf9d41b32017-02-23 15:20:04 -05002005 '*.gyp',
2006 '*.gypi',
2007 '*.htm',
2008 '*.html',
2009 '*.ini',
2010 '*.js',
2011 '*.json',
2012 '*.md',
2013 '*.mk',
2014 '*.patch',
2015 '*.policy',
2016 '*.proto',
2017 '*.raw',
2018 '*.rules',
2019 '*.service',
2020 '*.target',
2021 '*.txt',
2022 '*.xml',
2023 '*.yaml',
2024 )
2025
2026 def FinalName(obj):
2027 # If the file is being deleted, then the dst_file is not set.
2028 if obj.dst_file is None:
2029 return obj.src_file
2030 else:
2031 return obj.dst_file
2032
2033 bad_files = []
2034 files = _get_affected_files(commit, relative=True, full_details=True)
2035 for f in files:
2036 mode = int(f.dst_mode, 8)
2037 if not mode & 0o111:
2038 continue
2039 name = FinalName(f)
2040 for no_exec in NO_EXEC:
2041 if fnmatch.fnmatch(name, no_exec):
2042 bad_files.append(name)
2043 break
2044
2045 if bad_files:
2046 return HookFailure('These files should not be executable. '
2047 'Please `chmod -x` them.', bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04002048 return None
Mike Frysingerf9d41b32017-02-23 15:20:04 -05002049
2050
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002051# Base
2052
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002053# A list of hooks which are not project specific and check patch description
2054# (as opposed to patch body).
2055_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07002056 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07002057 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07002058 _check_change_has_test_field,
2059 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04002060 _check_commit_message_style,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08002061 _check_change_is_contribution,
Jack Neus8edbf642019-07-10 16:08:31 -06002062 _check_change_no_include_oem,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002063]
2064
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002065# A list of hooks that are not project-specific
2066_COMMON_HOOKS = [
Keiichi Watanabe6ab73fd2020-07-14 23:42:02 +09002067 _check_cargo_clippy,
Aviv Keshet5ac59522017-01-31 14:28:27 -08002068 _check_cros_license,
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05002069 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05002070 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08002071 _check_ebuild_licenses,
Mike Frysingercd363c82014-02-01 05:20:18 -05002072 _check_ebuild_virtual_pv,
Mike Frysingerf9d41b32017-02-23 15:20:04 -05002073 _check_exec_files,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002074 _check_for_uprev,
Rahul Chaudhry09f61372015-07-31 17:14:26 -07002075 _check_gofmt,
Bernie Thompson8e26f742020-07-23 14:32:31 -07002076 _check_keywords,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04002077 _check_layout_conf,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002078 _check_no_long_lines,
Keigo Oka4a09bd92019-05-07 14:01:00 +09002079 _check_no_new_gyp,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002080 _check_no_stray_whitespace,
Ryan Cui9b651632011-05-11 11:38:58 -07002081 _check_no_tabs,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002082 _check_portage_make_use_var,
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -06002083 _check_rustfmt,
Aviv Keshet5ac59522017-01-31 14:28:27 -08002084 _check_tabbed_indents,
Ryan Cui9b651632011-05-11 11:38:58 -07002085]
Ryan Cuiec4d6332011-05-02 14:15:25 -07002086
Ryan Cui1562fb82011-05-09 11:01:31 -07002087
Ryan Cui9b651632011-05-11 11:38:58 -07002088# A dictionary of project-specific hooks(callbacks), indexed by project name.
2089# dict[project] = [callback1, callback2]
2090_PROJECT_SPECIFIC_HOOKS = {
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002091 'chromiumos/third_party/kernel': [_kernel_configcheck],
2092 'chromiumos/third_party/kernel-next': [_kernel_configcheck],
Ryan Cui9b651632011-05-11 11:38:58 -07002093}
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002094
Ryan Cui1562fb82011-05-09 11:01:31 -07002095
Ryan Cui9b651632011-05-11 11:38:58 -07002096# A dictionary of flags (keys) that can appear in the config file, and the hook
Mike Frysinger3554bc92015-03-11 04:59:21 -04002097# that the flag controls (value).
2098_HOOK_FLAGS = {
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07002099 'clang_format_check': _check_clang_format,
Mike Frysingera7642f52015-03-25 18:31:42 -04002100 'checkpatch_check': _run_checkpatch,
Brian Norris23c62e92018-11-14 12:25:51 -08002101 'kerneldoc_check': _run_kerneldoc,
Ryan Cui9b651632011-05-11 11:38:58 -07002102 'stray_whitespace_check': _check_no_stray_whitespace,
Mike Frysingerff6c7d62015-03-24 13:49:46 -04002103 'json_check': _run_json_check,
Ryan Cui9b651632011-05-11 11:38:58 -07002104 'long_line_check': _check_no_long_lines,
Alex Deymof5792ce2015-08-24 22:50:08 -07002105 'cros_license_check': _check_cros_license,
2106 'aosp_license_check': _check_aosp_license,
LaMont Jones872fe762020-02-10 15:36:14 -07002107 'gofmt_check': _check_gofmt,
Bernie Thompson8e26f742020-07-23 14:32:31 -07002108 'keyword_check': _check_keywords,
Ryan Cui9b651632011-05-11 11:38:58 -07002109 'tab_check': _check_no_tabs,
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08002110 'tabbed_indent_required_check': _check_tabbed_indents,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07002111 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08002112 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07002113 'bug_field_check': _check_change_has_bug_field,
2114 'test_field_check': _check_change_has_test_field,
Steve Fung49ec7e92015-03-23 16:07:12 -07002115 'manifest_check': _check_manifests,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08002116 'contribution_check': _check_change_is_contribution,
Mike Frysinger47bd1252018-06-11 12:12:20 -04002117 'project_prefix_check': _check_project_prefix,
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09002118 'filepath_chartype_check': _check_filepath_chartype,
Keiichi Watanabe6ab73fd2020-07-14 23:42:02 +09002119 'cargo_clippy_check': _check_cargo_clippy,
Julius Werner291d8602020-07-31 17:34:02 -07002120 'exec_files_check': _check_exec_files,
Ryan Cui9b651632011-05-11 11:38:58 -07002121}
2122
2123
Mike Frysinger3554bc92015-03-11 04:59:21 -04002124def _get_override_hooks(config):
2125 """Returns a set of hooks controlled by the current project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07002126
2127 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08002128
2129 Args:
2130 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07002131 """
2132 SECTION = 'Hook Overrides'
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002133 SECTION_OPTIONS = 'Hook Overrides Options'
Ryan Cui9b651632011-05-11 11:38:58 -07002134
Mike Frysinger56e8de02019-07-31 14:40:14 -04002135 valid_keys = set(_HOOK_FLAGS.keys())
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002136 hooks = _HOOK_FLAGS.copy()
Mike Frysinger180ecd62020-08-19 00:41:51 -04002137 hook_overrides = set(
2138 config.options(SECTION) if config.has_section(SECTION) else [])
2139
2140 unknown_keys = hook_overrides - valid_keys
2141 if unknown_keys:
2142 raise ValueError(f'{_CONFIG_FILE}: [{SECTION}]: unknown keys: '
2143 f'{unknown_keys}')
Mike Frysinger3554bc92015-03-11 04:59:21 -04002144
2145 enable_flags = []
Ryan Cui9b651632011-05-11 11:38:58 -07002146 disable_flags = []
Mike Frysinger180ecd62020-08-19 00:41:51 -04002147 for flag in valid_keys:
2148 if flag in hook_overrides:
2149 try:
2150 enabled = config.getboolean(SECTION, flag)
2151 except ValueError as e:
2152 raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' %
2153 (flag, _CONFIG_FILE, e))
2154 elif hooks[flag] in _COMMON_HOOKS:
2155 # Enable common hooks by default so we process custom options below.
2156 enabled = True
2157 else:
2158 # All other hooks we left as a tristate. We use this below for a few
2159 # hooks to control default behavior.
2160 enabled = None
Mike Frysinger3554bc92015-03-11 04:59:21 -04002161
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002162 if enabled:
2163 enable_flags.append(flag)
Mike Frysinger180ecd62020-08-19 00:41:51 -04002164 elif enabled is not None:
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002165 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07002166
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002167 # See if this hook has custom options.
2168 if enabled:
2169 try:
2170 options = config.get(SECTION_OPTIONS, flag)
2171 hooks[flag] = functools.partial(hooks[flag], options=options.split())
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002172 hooks[flag].__name__ = flag
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04002173 except (configparser.NoOptionError, configparser.NoSectionError):
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002174 pass
2175
2176 enabled_hooks = set(hooks[x] for x in enable_flags)
2177 disabled_hooks = set(hooks[x] for x in disable_flags)
Mike Frysinger45334bd2019-11-04 10:42:33 -05002178
Mike Frysinger9ab64b12019-11-04 10:53:08 -05002179 if _check_change_has_signoff_field not in enabled_hooks:
Drew Davenport85848e52020-01-15 14:40:29 -07002180 if _check_change_has_signoff_field not in disabled_hooks:
2181 enabled_hooks.add(_check_change_has_no_signoff_field)
Mike Frysinger45334bd2019-11-04 10:42:33 -05002182 if _check_change_has_branch_field not in enabled_hooks:
2183 enabled_hooks.add(_check_change_has_no_branch_field)
2184
Mike Frysinger3554bc92015-03-11 04:59:21 -04002185 return enabled_hooks, disabled_hooks
Ryan Cui9b651632011-05-11 11:38:58 -07002186
2187
Jon Salz3ee59de2012-08-18 13:54:22 +08002188def _get_project_hook_scripts(config):
2189 """Returns a list of project-specific hook scripts.
2190
2191 Args:
2192 config: A ConfigParser for the project's config file.
2193 """
2194 SECTION = 'Hook Scripts'
2195 if not config.has_section(SECTION):
2196 return []
2197
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002198 return config.items(SECTION)
Jon Salz3ee59de2012-08-18 13:54:22 +08002199
2200
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002201def _get_project_hooks(project, presubmit, config_file=None):
Ryan Cui9b651632011-05-11 11:38:58 -07002202 """Returns a list of hooks that need to be run for a project.
2203
2204 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002205
2206 Args:
2207 project: A string, name of the project.
2208 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002209 config_file: A string, the config file. Defaults to _CONFIG_FILE.
Ryan Cui9b651632011-05-11 11:38:58 -07002210 """
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04002211 config = configparser.RawConfigParser()
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002212 if config_file is None:
2213 config_file = _CONFIG_FILE
2214 if not os.path.exists(config_file):
Jon Salz3ee59de2012-08-18 13:54:22 +08002215 # Just use an empty config file
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04002216 config = configparser.RawConfigParser()
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09002217 else:
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002218 config.read(config_file)
Jon Salz3ee59de2012-08-18 13:54:22 +08002219
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002220 if presubmit:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07002221 hooks = _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002222 else:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07002223 hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002224
Mike Frysinger3554bc92015-03-11 04:59:21 -04002225 enabled_hooks, disabled_hooks = _get_override_hooks(config)
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07002226 hooks = [hook for hook in hooks if hook not in disabled_hooks]
2227
2228 # If a list is both in _COMMON_HOOKS and also enabled explicitly through an
2229 # override, keep the override only. Note that the override may end up being
2230 # a functools.partial, in which case we need to extract the .func to compare
2231 # it to the common hooks.
2232 unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks]
2233 hooks = [hook for hook in hooks if hook not in unwrapped_hooks]
2234
2235 hooks = list(enabled_hooks) + hooks
Ryan Cui9b651632011-05-11 11:38:58 -07002236
2237 if project in _PROJECT_SPECIFIC_HOOKS:
Puneet Kumarc80e3f62012-08-13 19:01:18 -07002238 hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project]
2239 if hook not in disabled_hooks)
Ryan Cui9b651632011-05-11 11:38:58 -07002240
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002241 for name, script in _get_project_hook_scripts(config):
2242 func = functools.partial(_run_project_hook_script, script)
2243 func.__name__ = name
2244 hooks.append(func)
Jon Salz3ee59de2012-08-18 13:54:22 +08002245
Ryan Cui9b651632011-05-11 11:38:58 -07002246 return hooks
2247
2248
Alex Deymo643ac4c2015-09-03 10:40:50 -07002249def _run_project_hooks(project_name, proj_dir=None,
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002250 commit_list=None, presubmit=False,
2251 config_file=None):
Ryan Cui1562fb82011-05-09 11:01:31 -07002252 """For each project run its project specific hook from the hooks dictionary.
2253
2254 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002255 project_name: The name of project to run hooks for.
Doug Anderson44a644f2011-11-02 10:37:37 -07002256 proj_dir: If non-None, this is the directory the project is in. If None,
2257 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07002258 commit_list: A list of commits to run hooks against. If None or empty list
2259 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002260 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002261 config_file: A string, the presubmit config file. If not specified,
2262 defaults to PRESUBMIT.cfg in the project directory.
Ryan Cui1562fb82011-05-09 11:01:31 -07002263
2264 Returns:
2265 Boolean value of whether any errors were ecountered while running the hooks.
2266 """
Doug Anderson44a644f2011-11-02 10:37:37 -07002267 if proj_dir is None:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002268 proj_dirs = _run_command(
2269 ['repo', 'forall', project_name, '-c', 'pwd']).split()
Mike Frysingere52b1bc2019-09-16 23:45:41 -04002270 if not proj_dirs:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002271 print('%s cannot be found.' % project_name, file=sys.stderr)
David James2edd9002013-10-11 14:09:19 -07002272 print('Please specify a valid project.', file=sys.stderr)
2273 return True
2274 if len(proj_dirs) > 1:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002275 print('%s is associated with multiple directories.' % project_name,
David James2edd9002013-10-11 14:09:19 -07002276 file=sys.stderr)
2277 print('Please specify a directory to help disambiguate.', file=sys.stderr)
2278 return True
2279 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07002280
Ryan Cuiec4d6332011-05-02 14:15:25 -07002281 pwd = os.getcwd()
2282 # hooks assume they are run from the root of the project
2283 os.chdir(proj_dir)
2284
Mike Frysingered1b95a2019-12-12 19:04:51 -05002285 color = terminal.Color()
2286
Alex Deymo643ac4c2015-09-03 10:40:50 -07002287 remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref',
2288 '--symbolic-full-name', '@{u}']).strip()
2289 if not remote_branch:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002290 print("Your project %s doesn't track any remote repo." % project_name,
Alex Deymo643ac4c2015-09-03 10:40:50 -07002291 file=sys.stderr)
2292 remote = None
2293 else:
Josh Pratt15d13ab2018-08-13 11:52:48 +10002294 branch_items = remote_branch.split('/', 1)
2295 if len(branch_items) != 2:
2296 PrintErrorForProject(
2297 project_name,
2298 HookFailure(
2299 'Cannot get remote and branch name (%s)' % remote_branch))
2300 os.chdir(pwd)
2301 return True
2302 remote, _branch = branch_items
Alex Deymo643ac4c2015-09-03 10:40:50 -07002303
2304 project = Project(name=project_name, dir=proj_dir, remote=remote)
2305
Doug Anderson14749562013-06-26 13:38:29 -07002306 if not commit_list:
2307 try:
2308 commit_list = _get_commits()
2309 except VerifyException as e:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002310 PrintErrorForProject(project.name, HookFailure(str(e)))
Doug Anderson14749562013-06-26 13:38:29 -07002311 os.chdir(pwd)
2312 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07002313
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002314 hooks = _get_project_hooks(project.name, presubmit, config_file)
Ryan Cui1562fb82011-05-09 11:01:31 -07002315 error_found = False
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002316 commit_count = len(commit_list)
Mike Frysingerb99b3772019-08-17 14:19:44 -04002317 hook_count = len(hooks)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002318 for i, commit in enumerate(commit_list):
Mike Frysingerb2496652019-09-12 23:35:46 -04002319 CACHE.clear()
2320
LaMont Jones69d3e182020-03-11 15:00:53 -06002321 # If run with --pre-submit, then commit is PRE_SUBMIT, and not a commit.
2322 # Use that as the description.
2323 desc = commit if commit == PRE_SUBMIT else _get_commit_desc(commit)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002324 print('[%s %i/%i %s] %s' %
2325 (color.Color(color.CYAN, 'COMMIT'), i + 1, commit_count, commit[0:12],
2326 desc.splitlines()[0]))
2327
Mike Frysingerb99b3772019-08-17 14:19:44 -04002328 for h, hook in enumerate(hooks):
Mike Frysingered1b95a2019-12-12 19:04:51 -05002329 output = ('[%s %i/%i PRESUBMIT.cfg] %s' %
2330 (color.Color(color.YELLOW, 'RUNNING'), h + 1, hook_count,
2331 hook.__name__))
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002332 print(output, end='\r')
2333 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002334 hook_error = hook(project, commit)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002335 print(' ' * len(output), end='\r')
2336 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002337 if hook_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002338 if not isinstance(hook_error, list):
2339 hook_error = [hook_error]
2340 PrintErrorsForCommit(color, hook, project.name, hook_error)
Ryan Cui1562fb82011-05-09 11:01:31 -07002341 error_found = True
Don Garrettdba548a2011-05-05 15:17:14 -07002342
Ryan Cuiec4d6332011-05-02 14:15:25 -07002343 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07002344 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002345
Mike Frysingerae409522014-02-01 03:16:11 -05002346
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002347# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002348
Ryan Cui1562fb82011-05-09 11:01:31 -07002349
Mike Frysingerae409522014-02-01 03:16:11 -05002350def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08002351 """Main function invoked directly by repo.
2352
2353 This function will exit directly upon error so that repo doesn't print some
2354 obscure error message.
2355
2356 Args:
2357 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07002358 worktree_list: A list of directories. It should be the same length as
2359 project_list, so that each entry in project_list matches with a directory
2360 in worktree_list. If None, we will attempt to calculate the directories
2361 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08002362 kwargs: Leave this here for forward-compatibility.
2363 """
Mike Frysingered1b95a2019-12-12 19:04:51 -05002364 start_time = datetime.datetime.now()
Ryan Cui1562fb82011-05-09 11:01:31 -07002365 found_error = False
David James2edd9002013-10-11 14:09:19 -07002366 if not worktree_list:
2367 worktree_list = [None] * len(project_list)
2368 for project, worktree in zip(project_list, worktree_list):
2369 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07002370 found_error = True
2371
Mike Frysingered1b95a2019-12-12 19:04:51 -05002372 end_time = datetime.datetime.now()
2373 color = terminal.Color()
Mike Frysingerae409522014-02-01 03:16:11 -05002374 if found_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002375 msg = ('%s: Preupload failed due to above error(s).\n'
Ryan Cui9b651632011-05-11 11:38:58 -07002376 '- To disable some source style checks, and for other hints, see '
Mike Frysingered1b95a2019-12-12 19:04:51 -05002377 '<checkout_dir>/src/repohooks/README.md\n'
2378 "- To upload only current project, run 'repo upload .'" %
2379 (color.Color(color.RED, 'FATAL'),))
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04002380 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07002381 sys.exit(1)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002382 else:
2383 msg = ('[%s] repohooks passed in %s' %
2384 (color.Color(color.GREEN, 'PASSED'), end_time - start_time))
2385 print(msg)
Anush Elangovan63afad72011-03-23 00:41:27 -07002386
Ryan Cui1562fb82011-05-09 11:01:31 -07002387
Doug Anderson44a644f2011-11-02 10:37:37 -07002388def _identify_project(path):
2389 """Identify the repo project associated with the given path.
2390
2391 Returns:
2392 A string indicating what project is associated with the path passed in or
2393 a blank string upon failure.
2394 """
2395 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002396 stderr=True, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002397
2398
Mike Frysinger55f85b52014-12-18 14:45:21 -05002399def direct_main(argv):
Doug Anderson44a644f2011-11-02 10:37:37 -07002400 """Run hooks directly (outside of the context of repo).
2401
Doug Anderson44a644f2011-11-02 10:37:37 -07002402 Args:
Mike Frysinger55f85b52014-12-18 14:45:21 -05002403 argv: The command line args to process
Doug Anderson44a644f2011-11-02 10:37:37 -07002404
2405 Returns:
2406 0 if no pre-upload failures, 1 if failures.
2407
2408 Raises:
2409 BadInvocation: On some types of invocation errors.
2410 """
Mike Frysinger66142932014-12-18 14:55:57 -05002411 parser = commandline.ArgumentParser(description=__doc__)
2412 parser.add_argument('--dir', default=None,
2413 help='The directory that the project lives in. If not '
2414 'specified, use the git project root based on the cwd.')
2415 parser.add_argument('--project', default=None,
2416 help='The project repo path; this can affect how the '
2417 'hooks get run, since some hooks are project-specific. '
2418 'For chromite this is chromiumos/chromite. If not '
2419 'specified, the repo tool will be used to figure this '
2420 'out based on the dir.')
2421 parser.add_argument('--rerun-since', default=None,
Vadim Bendebury75447b92018-01-10 12:06:01 -08002422 help='Rerun hooks on old commits since some point '
2423 'in the past. The argument could be a date (should '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002424 "match git log's concept of a date, e.g. 2012-06-20), "
Vadim Bendebury75447b92018-01-10 12:06:01 -08002425 'or a SHA1, or just a number of commits to check (from 1 '
2426 'to 99). This option is mutually exclusive with '
2427 '--pre-submit.')
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002428 parser.add_argument('--pre-submit', action='store_true',
Mike Frysinger66142932014-12-18 14:55:57 -05002429 help='Run the check against the pending commit. '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002430 "This option should be used at the 'git commit' "
2431 "phase as opposed to 'repo upload'. This option "
Mike Frysinger66142932014-12-18 14:55:57 -05002432 'is mutually exclusive with --rerun-since.')
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002433 parser.add_argument('--presubmit-config',
2434 help='Specify presubmit config file to be used.')
Mike Frysinger66142932014-12-18 14:55:57 -05002435 parser.add_argument('commits', nargs='*',
2436 help='Check specific commits')
2437 opts = parser.parse_args(argv)
Doug Anderson44a644f2011-11-02 10:37:37 -07002438
Doug Anderson14749562013-06-26 13:38:29 -07002439 if opts.rerun_since:
Mike Frysinger66142932014-12-18 14:55:57 -05002440 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002441 raise BadInvocation("Can't pass commits and use rerun-since: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002442 ' '.join(opts.commits))
Doug Anderson14749562013-06-26 13:38:29 -07002443
Vadim Bendebury75447b92018-01-10 12:06:01 -08002444 if len(opts.rerun_since) < 3 and opts.rerun_since.isdigit():
2445 # This must be the number of commits to check. We don't expect the user
2446 # to want to check more than 99 commits.
2447 limit = '-n%s' % opts.rerun_since
2448 elif git.IsSHA1(opts.rerun_since, False):
2449 limit = '%s..' % opts.rerun_since
2450 else:
2451 # This better be a date.
2452 limit = '--since=%s' % opts.rerun_since
2453 cmd = ['git', 'log', limit, '--pretty=%H']
Doug Anderson14749562013-06-26 13:38:29 -07002454 all_commits = _run_command(cmd).splitlines()
2455 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
2456
2457 # Eliminate chrome-bot commits but keep ordering the same...
2458 bot_commits = set(bot_commits)
Mike Frysinger66142932014-12-18 14:55:57 -05002459 opts.commits = [c for c in all_commits if c not in bot_commits]
Doug Anderson14749562013-06-26 13:38:29 -07002460
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002461 if opts.pre_submit:
2462 raise BadInvocation('rerun-since and pre-submit can not be '
2463 'used together')
2464 if opts.pre_submit:
Mike Frysinger66142932014-12-18 14:55:57 -05002465 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002466 raise BadInvocation("Can't pass commits and use pre-submit: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002467 ' '.join(opts.commits))
2468 opts.commits = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07002469
2470 # Check/normlaize git dir; if unspecified, we'll use the root of the git
2471 # project from CWD
2472 if opts.dir is None:
2473 git_dir = _run_command(['git', 'rev-parse', '--git-dir'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002474 stderr=True).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002475 if not git_dir:
2476 raise BadInvocation('The current directory is not part of a git project.')
2477 opts.dir = os.path.dirname(os.path.abspath(git_dir))
2478 elif not os.path.isdir(opts.dir):
2479 raise BadInvocation('Invalid dir: %s' % opts.dir)
2480 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
2481 raise BadInvocation('Not a git directory: %s' % opts.dir)
2482
2483 # Identify the project if it wasn't specified; this _requires_ the repo
2484 # tool to be installed and for the project to be part of a repo checkout.
2485 if not opts.project:
2486 opts.project = _identify_project(opts.dir)
2487 if not opts.project:
2488 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
2489
Doug Anderson14749562013-06-26 13:38:29 -07002490 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Mike Frysinger66142932014-12-18 14:55:57 -05002491 commit_list=opts.commits,
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002492 presubmit=opts.pre_submit,
2493 config_file=opts.presubmit_config)
Doug Anderson44a644f2011-11-02 10:37:37 -07002494 if found_error:
2495 return 1
2496 return 0
2497
2498
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002499if __name__ == '__main__':
Mike Frysinger55f85b52014-12-18 14:45:21 -05002500 sys.exit(direct_main(sys.argv[1:]))