Mike Frysinger | 4f99440 | 2019-09-13 17:40:45 -0400 | [diff] [blame] | 1 | #!/usr/bin/env python3 |
Mike Frysinger | b7d552e | 2017-11-23 11:50:47 -0500 | [diff] [blame] | 2 | # -*- coding: utf-8 -*- |
Jon Salz | 9825593 | 2012-08-18 14:48:02 +0800 | [diff] [blame] | 3 | # Copyright (c) 2012 The Chromium OS Authors. All rights reserved. |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 4 | # Use of this source code is governed by a BSD-style license that can be |
| 5 | # found in the LICENSE file. |
| 6 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 7 | """Presubmit checks to run when doing `repo upload`. |
| 8 | |
Tom Hughes | 40bdce5 | 2020-08-25 08:57:03 -0700 | [diff] [blame] | 9 | You can add new checks by adding a function to the HOOKS constants. |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 10 | """ |
| 11 | |
Mike Frysinger | 09d6a3d | 2013-10-08 22:21:03 -0400 | [diff] [blame] | 12 | from __future__ import print_function |
| 13 | |
Keigo Oka | dd90882 | 2019-06-04 11:30:25 +0900 | [diff] [blame] | 14 | import argparse |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 15 | import collections |
Mike Frysinger | f252cfc | 2019-12-09 17:34:28 -0500 | [diff] [blame] | 16 | import configparser |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 17 | import datetime |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 18 | import fnmatch |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 19 | import functools |
Dale Curtis | 2975c43 | 2011-05-03 17:25:20 -0700 | [diff] [blame] | 20 | import json |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 21 | import os |
Stephen Boyd | 6bf5ea8 | 2020-10-15 00:02:07 -0700 | [diff] [blame] | 22 | import pathlib |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 23 | import re |
Mandeep Singh Baines | a7ffa4b | 2011-05-03 11:37:02 -0700 | [diff] [blame] | 24 | import sys |
Peter Ammon | 811f670 | 2014-06-12 15:45:38 -0700 | [diff] [blame] | 25 | import stat |
Mike Frysinger | d0c5c8b | 2019-12-17 02:28:26 -0500 | [diff] [blame] | 26 | import subprocess |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 27 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 28 | from errors import (VerifyException, HookFailure, PrintErrorForProject, |
| 29 | PrintErrorsForCommit) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 30 | |
Mike Frysinger | 919c703 | 2019-09-13 17:48:08 -0400 | [diff] [blame] | 31 | if __name__ in ('__builtin__', 'builtins'): |
Mike Frysinger | 653cd26 | 2019-09-20 14:05:02 -0400 | [diff] [blame] | 32 | # If repo imports us, the __name__ will be __builtin__, and the cwd will be in |
| 33 | # the top level of the checkout (i.e. $CHROMEOS_CHECKOUT). chromite will be |
| 34 | # in that directory, so add it to our path. This works whether we're running |
| 35 | # the repo in $CHROMEOS_CHECKOUT/.repo/repo/ or a custom version in a |
| 36 | # completely different tree. |
| 37 | # TODO(vapier): Python 2 used "__builtin__" while Python 3 uses "builtins". |
Mike Frysinger | 6850d51 | 2018-05-21 12:12:14 -0400 | [diff] [blame] | 38 | sys.path.insert(0, os.getcwd()) |
| 39 | |
Mike Frysinger | 653cd26 | 2019-09-20 14:05:02 -0400 | [diff] [blame] | 40 | elif __name__ == '__main__': |
| 41 | # If we're run directly, we'll find chromite relative to the repohooks dir in |
| 42 | # $CHROMEOS_CHECKOUT/src/repohooks, so go up two dirs. |
David James | c3b68b3 | 2013-04-03 09:17:03 -0700 | [diff] [blame] | 43 | sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..')) |
| 44 | |
Mike Frysinger | fd481ce | 2019-09-13 18:14:48 -0400 | [diff] [blame] | 45 | # The sys.path monkey patching confuses the linter. |
| 46 | # pylint: disable=wrong-import-position |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 47 | from chromite.lib import commandline |
Rahul Chaudhry | 0e51534 | 2015-08-07 12:00:43 -0700 | [diff] [blame] | 48 | from chromite.lib import cros_build_lib |
Mike Frysinger | d3bd32c | 2014-11-24 23:34:29 -0500 | [diff] [blame] | 49 | from chromite.lib import git |
Daniel Erat | a350fd3 | 2014-09-29 14:02:34 -0700 | [diff] [blame] | 50 | from chromite.lib import osutils |
David James | c3b68b3 | 2013-04-03 09:17:03 -0700 | [diff] [blame] | 51 | from chromite.lib import patch |
Mike Frysinger | ed1b95a | 2019-12-12 19:04:51 -0500 | [diff] [blame] | 52 | from chromite.lib import terminal |
Mike Frysinger | 2ec70ed | 2014-08-17 19:28:34 -0400 | [diff] [blame] | 53 | from chromite.licensing import licenses_lib |
David James | c3b68b3 | 2013-04-03 09:17:03 -0700 | [diff] [blame] | 54 | |
Mike Frysinger | ff4768e | 2020-02-27 18:48:13 -0500 | [diff] [blame] | 55 | |
| 56 | assert sys.version_info >= (3, 6), 'This module requires Python 3.6+' |
| 57 | |
| 58 | |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 59 | PRE_SUBMIT = 'pre-submit' |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 60 | |
Mike Frysinger | ed9b2a0 | 2019-12-12 18:52:32 -0500 | [diff] [blame] | 61 | |
| 62 | # Link to commit message documentation for users. |
| 63 | DOC_COMMIT_MSG_URL = ('https://chromium.googlesource.com/chromiumos/docs/+/HEAD' |
| 64 | '/contributing.md#commit-messages') |
| 65 | |
| 66 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 67 | COMMON_INCLUDED_PATHS = [ |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 68 | # C++ and friends |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 69 | r'.*\.c$', r'.*\.cc$', r'.*\.cpp$', r'.*\.h$', r'.*\.m$', r'.*\.mm$', |
| 70 | r'.*\.inl$', r'.*\.asm$', r'.*\.hxx$', r'.*\.hpp$', r'.*\.s$', r'.*\.S$', |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 71 | # Scripts |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 72 | r'.*\.js$', r'.*\.py$', r'.*\.sh$', r'.*\.rb$', r'.*\.pl$', r'.*\.pm$', |
Bob Haarman | 0dc1f94 | 2020-10-03 00:06:59 +0000 | [diff] [blame] | 73 | # No extension at all, note that ALL CAPS files are excluded by |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 74 | # COMMON_EXCLUDED_LIST below. |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 75 | r'(^|.*[\\\/])[^.]+$', |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 76 | # Other |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 77 | r'.*\.java$', r'.*\.mk$', r'.*\.am$', |
| 78 | r'.*\.policy$', r'.*\.conf$', r'.*\.go$', |
| 79 | r'(^OWNERS|/OWNERS)', |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 80 | ] |
| 81 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 82 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 83 | COMMON_EXCLUDED_PATHS = [ |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 84 | # For ebuild trees, ignore any caches and manifest data. |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 85 | r'.*/Manifest$', |
| 86 | r'.*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$', |
Doug Anderson | 5bfb679 | 2011-10-25 16:45:41 -0700 | [diff] [blame] | 87 | |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 88 | # Ignore profiles data (like overlay-tegra2/profiles). |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 89 | r'(^|.*/)overlay-.*/profiles/.*', |
| 90 | r'^profiles/.*$', |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 91 | |
C Shapiro | 8f90e9b | 2017-06-28 09:54:50 -0600 | [diff] [blame] | 92 | # Ignore config files in ebuild setup. |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 93 | r'(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*', |
| 94 | r'^chromeos-base/chromeos-bsp.*/files/.*', |
C Shapiro | 8f90e9b | 2017-06-28 09:54:50 -0600 | [diff] [blame] | 95 | |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 96 | # Ignore minified js and jquery. |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 97 | r'.*\.min\.js', |
| 98 | r'.*jquery.*\.js', |
Mike Frysinger | 33a458d | 2014-03-03 17:00:51 -0500 | [diff] [blame] | 99 | |
| 100 | # Ignore license files as the content is often taken verbatim. |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 101 | r'.*/licenses/.*', |
Alex Klein | 619c091 | 2019-01-30 17:13:23 -0700 | [diff] [blame] | 102 | |
Mike Frysinger | 1365040 | 2019-07-31 14:31:46 -0400 | [diff] [blame] | 103 | # Exclude generated protobuf bindings. |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 104 | r'.*_pb2\.py$', |
| 105 | r'.*\.pb\.go$', |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 106 | ] |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 107 | |
Ken Turner | d07564b | 2018-02-08 17:57:59 +1100 | [diff] [blame] | 108 | LICENSE_EXCLUDED_PATHS = [ |
LaMont Jones | 775c2b3 | 2020-02-19 17:32:54 -0700 | [diff] [blame] | 109 | r'^(.*/)?OWNERS(\..*)?$', |
Tom Hughes | 90b7bd4 | 2020-11-10 10:31:49 -0800 | [diff] [blame] | 110 | r'^(.*/)?DIR_METADATA(\..*)?$', |
Ken Turner | d07564b | 2018-02-08 17:57:59 +1100 | [diff] [blame] | 111 | ] |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 112 | |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 113 | _CONFIG_FILE = 'PRESUBMIT.cfg' |
| 114 | |
| 115 | |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 116 | # File containing wildcards, one per line, matching files that should be |
| 117 | # excluded from presubmit checks. Lines beginning with '#' are ignored. |
| 118 | _IGNORE_FILE = '.presubmitignore' |
| 119 | |
Cheng Yueh | b707c52 | 2020-01-02 14:06:59 +0800 | [diff] [blame] | 120 | |
| 121 | TEST_FIELD_RE = r'\nTEST=\S+' |
| 122 | |
Daisuke Nojiri | 2089e01 | 2020-08-20 15:12:36 -0700 | [diff] [blame] | 123 | BLOCKED_TERMS_FILE = 'blocked_terms.txt' |
| 124 | UNBLOCKED_TERMS_FILE = 'unblocked_terms.txt' |
| 125 | |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 126 | # Exceptions |
| 127 | |
| 128 | |
| 129 | class BadInvocation(Exception): |
| 130 | """An Exception indicating a bad invocation of the program.""" |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 131 | |
| 132 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 133 | # General Helpers |
| 134 | |
Sean Paul | ba01d40 | 2011-05-05 11:36:23 -0400 | [diff] [blame] | 135 | |
Mike Frysinger | b249665 | 2019-09-12 23:35:46 -0400 | [diff] [blame] | 136 | class Cache(object): |
| 137 | """General helper for caching git content.""" |
| 138 | |
| 139 | def __init__(self): |
| 140 | self._cache = {} |
| 141 | |
| 142 | def get_subcache(self, scope): |
| 143 | return self._cache.setdefault(scope, {}) |
| 144 | |
| 145 | def clear(self): |
| 146 | self._cache.clear() |
| 147 | |
| 148 | CACHE = Cache() |
| 149 | |
| 150 | |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 151 | Project = collections.namedtuple('Project', ['name', 'dir', 'remote']) |
| 152 | |
| 153 | |
Mike Frysinger | 526a5f8 | 2019-09-13 18:05:30 -0400 | [diff] [blame] | 154 | def _run_command(cmd, **kwargs): |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 155 | """Executes the passed in command and returns raw stdout output. |
| 156 | |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 157 | This is a convenience func to set some run defaults differently. |
Mike Frysinger | 526a5f8 | 2019-09-13 18:05:30 -0400 | [diff] [blame] | 158 | |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 159 | Args: |
| 160 | cmd: The command to run; should be a list of strings. |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 161 | **kwargs: Same as cros_build_lib.run. |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 162 | |
| 163 | Returns: |
Rahul Chaudhry | 0e51534 | 2015-08-07 12:00:43 -0700 | [diff] [blame] | 164 | The stdout from the process (discards stderr and returncode). |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 165 | """ |
Mike Frysinger | 526a5f8 | 2019-09-13 18:05:30 -0400 | [diff] [blame] | 166 | kwargs.setdefault('print_cmd', False) |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 167 | kwargs.setdefault('stdout', True) |
| 168 | kwargs.setdefault('check', False) |
Mike Frysinger | 054c159 | 2019-11-18 03:51:54 -0500 | [diff] [blame] | 169 | result = cros_build_lib.run(cmd, **kwargs) |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 170 | # NB: We decode this directly rather than through kwargs as our tests rely |
| 171 | # on this post-processing behavior currently. |
Mike Frysinger | 71e643e | 2019-09-13 17:26:39 -0400 | [diff] [blame] | 172 | return result.output.decode('utf-8', 'replace') |
Ryan Cui | 72834d1 | 2011-05-05 14:51:33 -0700 | [diff] [blame] | 173 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 174 | |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 175 | def _get_hooks_dir(): |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 176 | """Returns the absolute path to the repohooks directory.""" |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 177 | if __name__ == '__main__': |
| 178 | # Works when file is run on its own (__file__ is defined)... |
| 179 | return os.path.abspath(os.path.dirname(__file__)) |
| 180 | else: |
| 181 | # We need to do this when we're run through repo. Since repo executes |
| 182 | # us with execfile(), we don't get __file__ defined. |
| 183 | cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd'] |
| 184 | return _run_command(cmd).strip() |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 185 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 186 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 187 | def _match_regex_list(subject, expressions): |
| 188 | """Try to match a list of regular expressions to a string. |
| 189 | |
| 190 | Args: |
| 191 | subject: The string to match regexes on |
| 192 | expressions: A list of regular expressions to check for matches with. |
| 193 | |
| 194 | Returns: |
| 195 | Whether the passed in subject matches any of the passed in regexes. |
| 196 | """ |
| 197 | for expr in expressions: |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 198 | if re.search(expr, subject): |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 199 | return True |
| 200 | return False |
| 201 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 202 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 203 | def _filter_files(files, include_list, exclude_list=()): |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 204 | """Filter out files based on the conditions passed in. |
| 205 | |
| 206 | Args: |
| 207 | files: list of filepaths to filter |
| 208 | include_list: list of regex that when matched with a file path will cause it |
| 209 | to be added to the output list unless the file is also matched with a |
| 210 | regex in the exclude_list. |
| 211 | exclude_list: list of regex that when matched with a file will prevent it |
| 212 | from being added to the output list, even if it is also matched with a |
| 213 | regex in the include_list. |
| 214 | |
| 215 | Returns: |
| 216 | A list of filepaths that contain files matched in the include_list and not |
| 217 | in the exclude_list. |
| 218 | """ |
| 219 | filtered = [] |
| 220 | for f in files: |
| 221 | if (_match_regex_list(f, include_list) and |
| 222 | not _match_regex_list(f, exclude_list)): |
| 223 | filtered.append(f) |
| 224 | return filtered |
| 225 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 226 | |
| 227 | # Git Helpers |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 228 | |
| 229 | |
Ryan Cui | 4725d95 | 2011-05-05 15:41:19 -0700 | [diff] [blame] | 230 | def _get_upstream_branch(): |
| 231 | """Returns the upstream tracking branch of the current branch. |
| 232 | |
| 233 | Raises: |
| 234 | Error if there is no tracking branch |
| 235 | """ |
| 236 | current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip() |
| 237 | current_branch = current_branch.replace('refs/heads/', '') |
| 238 | if not current_branch: |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 239 | raise VerifyException('Need to be on a tracking branch') |
Ryan Cui | 4725d95 | 2011-05-05 15:41:19 -0700 | [diff] [blame] | 240 | |
| 241 | cfg_option = 'branch.' + current_branch + '.%s' |
| 242 | full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip() |
| 243 | remote = _run_command(['git', 'config', cfg_option % 'remote']).strip() |
| 244 | if not remote or not full_upstream: |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 245 | raise VerifyException('Need to be on a tracking branch') |
Ryan Cui | 4725d95 | 2011-05-05 15:41:19 -0700 | [diff] [blame] | 246 | |
| 247 | return full_upstream.replace('heads', 'remotes/' + remote) |
| 248 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 249 | |
Che-Liang Chiou | 5ce2d7b | 2013-03-22 18:47:55 -0700 | [diff] [blame] | 250 | def _get_patch(commit): |
| 251 | """Returns the patch for this commit.""" |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 252 | if commit == PRE_SUBMIT: |
| 253 | return _run_command(['git', 'diff', '--cached', 'HEAD']) |
| 254 | else: |
| 255 | return _run_command(['git', 'format-patch', '--stdout', '-1', commit]) |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 256 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 257 | |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 258 | def _get_file_content(path, commit): |
| 259 | """Returns the content of a file at a specific commit. |
| 260 | |
| 261 | We can't rely on the file as it exists in the filesystem as people might be |
| 262 | uploading a series of changes which modifies the file multiple times. |
| 263 | |
| 264 | Note: The "content" of a symlink is just the target. So if you're expecting |
| 265 | a full file, you should check that first. One way to detect is that the |
| 266 | content will not have any newlines. |
| 267 | """ |
Mike Frysinger | b249665 | 2019-09-12 23:35:46 -0400 | [diff] [blame] | 268 | # Make sure people don't accidentally pass in full paths which will never |
| 269 | # work. You need to use relative=True with _get_affected_files. |
| 270 | if path.startswith('/'): |
| 271 | raise ValueError('_get_file_content must be called with relative paths: %s' |
| 272 | % (path,)) |
| 273 | |
| 274 | # {<commit>: {<path1>: <content>, <path2>: <content>}} |
| 275 | cache = CACHE.get_subcache('get_file_content') |
| 276 | if path in cache: |
| 277 | return cache[path] |
| 278 | |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 279 | if commit == PRE_SUBMIT: |
Yu-Ping Wu | e3e4736 | 2020-09-22 15:54:40 +0800 | [diff] [blame] | 280 | content = _run_command(['git', 'diff', 'HEAD', '--', path]) |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 281 | else: |
Mike Frysinger | b249665 | 2019-09-12 23:35:46 -0400 | [diff] [blame] | 282 | content = _run_command(['git', 'show', '%s:%s' % (commit, path)]) |
| 283 | cache[path] = content |
| 284 | return content |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 285 | |
| 286 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 287 | def _get_file_diff(path, commit): |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 288 | """Returns a list of (linenum, lines) tuples that the commit touched.""" |
Mike Frysinger | b249665 | 2019-09-12 23:35:46 -0400 | [diff] [blame] | 289 | # {<commit>: {<path1>: <content>, <path2>: <content>}} |
| 290 | cache = CACHE.get_subcache('get_file_diff') |
| 291 | if path in cache: |
| 292 | return cache[path] |
| 293 | |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 294 | if commit == PRE_SUBMIT: |
Prathmesh Prabhu | a9de172 | 2016-12-22 14:56:40 -0800 | [diff] [blame] | 295 | command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD', |
Yu-Ping Wu | e3e4736 | 2020-09-22 15:54:40 +0800 | [diff] [blame] | 296 | '--', path] |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 297 | else: |
Prathmesh Prabhu | a9de172 | 2016-12-22 14:56:40 -0800 | [diff] [blame] | 298 | command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit, |
Yu-Ping Wu | e3e4736 | 2020-09-22 15:54:40 +0800 | [diff] [blame] | 299 | '--', path] |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 300 | output = _run_command(command) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 301 | |
| 302 | new_lines = [] |
| 303 | line_num = 0 |
| 304 | for line in output.splitlines(): |
| 305 | m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line) |
| 306 | if m: |
| 307 | line_num = int(m.groups(1)[0]) |
| 308 | continue |
| 309 | if line.startswith('+') and not line.startswith('++'): |
Mike Frysinger | 71e643e | 2019-09-13 17:26:39 -0400 | [diff] [blame] | 310 | new_lines.append((line_num, line[1:])) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 311 | if not line.startswith('-'): |
| 312 | line_num += 1 |
Mike Frysinger | b249665 | 2019-09-12 23:35:46 -0400 | [diff] [blame] | 313 | cache[path] = new_lines |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 314 | return new_lines |
| 315 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 316 | |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 317 | def _get_ignore_wildcards(directory, cache): |
| 318 | """Get wildcards listed in a directory's _IGNORE_FILE. |
| 319 | |
| 320 | Args: |
| 321 | directory: A string containing a directory path. |
| 322 | cache: A dictionary (opaque to caller) caching previously-read wildcards. |
| 323 | |
| 324 | Returns: |
| 325 | A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE |
| 326 | wasn't present. |
| 327 | """ |
| 328 | # In the cache, keys are directories and values are lists of wildcards from |
| 329 | # _IGNORE_FILE within those directories (and empty if no file was present). |
| 330 | if directory not in cache: |
| 331 | wildcards = [] |
| 332 | dotfile_path = os.path.join(directory, _IGNORE_FILE) |
| 333 | if os.path.exists(dotfile_path): |
| 334 | # TODO(derat): Consider using _get_file_content() to get the file as of |
| 335 | # this commit instead of the on-disk version. This may have a noticeable |
| 336 | # performance impact, as each call to _get_file_content() runs git. |
| 337 | with open(dotfile_path, 'r') as dotfile: |
| 338 | for line in dotfile.readlines(): |
| 339 | line = line.strip() |
| 340 | if line.startswith('#'): |
| 341 | continue |
| 342 | if line.endswith('/'): |
| 343 | line += '*' |
| 344 | wildcards.append(line) |
| 345 | cache[directory] = wildcards |
| 346 | |
| 347 | return cache[directory] |
| 348 | |
| 349 | |
| 350 | def _path_is_ignored(path, cache): |
| 351 | """Check whether a path is ignored by _IGNORE_FILE. |
| 352 | |
| 353 | Args: |
| 354 | path: A string containing a path. |
| 355 | cache: A dictionary (opaque to caller) caching previously-read wildcards. |
| 356 | |
| 357 | Returns: |
| 358 | True if a file named _IGNORE_FILE in one of the passed-in path's parent |
| 359 | directories contains a wildcard matching the path. |
| 360 | """ |
| 361 | # Skip ignore files. |
| 362 | if os.path.basename(path) == _IGNORE_FILE: |
| 363 | return True |
| 364 | |
| 365 | path = os.path.abspath(path) |
| 366 | base = os.getcwd() |
| 367 | |
| 368 | prefix = os.path.dirname(path) |
| 369 | while prefix.startswith(base): |
| 370 | rel_path = path[len(prefix) + 1:] |
| 371 | for wildcard in _get_ignore_wildcards(prefix, cache): |
| 372 | if fnmatch.fnmatch(rel_path, wildcard): |
| 373 | return True |
| 374 | prefix = os.path.dirname(prefix) |
| 375 | |
| 376 | return False |
| 377 | |
| 378 | |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 379 | def _get_affected_files(commit, include_deletes=False, relative=False, |
| 380 | include_symlinks=False, include_adds=True, |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 381 | full_details=False, use_ignore_files=True): |
Peter Ammon | 811f670 | 2014-06-12 15:45:38 -0700 | [diff] [blame] | 382 | """Returns list of file paths that were modified/added, excluding symlinks. |
| 383 | |
| 384 | Args: |
| 385 | commit: The commit |
| 386 | include_deletes: If true, we'll include deleted files in the result |
| 387 | relative: Whether to return relative or full paths to files |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 388 | include_symlinks: If true, we'll include symlinks in the result |
| 389 | include_adds: If true, we'll include new files in the result |
| 390 | full_details: If False, return filenames, else return structured results. |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 391 | use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files. |
Peter Ammon | 811f670 | 2014-06-12 15:45:38 -0700 | [diff] [blame] | 392 | |
| 393 | Returns: |
| 394 | A list of modified/added (and perhaps deleted) files |
| 395 | """ |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 396 | if not relative and full_details: |
| 397 | raise ValueError('full_details only supports relative paths currently') |
| 398 | |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 399 | if commit == PRE_SUBMIT: |
| 400 | return _run_command(['git', 'diff-index', '--cached', |
| 401 | '--name-only', 'HEAD']).split() |
Mike Frysinger | d3bd32c | 2014-11-24 23:34:29 -0500 | [diff] [blame] | 402 | |
| 403 | path = os.getcwd() |
Mike Frysinger | b249665 | 2019-09-12 23:35:46 -0400 | [diff] [blame] | 404 | # {<commit>: {<path1>: <content>, <path2>: <content>}} |
| 405 | cache = CACHE.get_subcache('get_affected_files') |
| 406 | if path not in cache: |
| 407 | cache[path] = git.RawDiff(path, '%s^!' % commit) |
| 408 | files = cache[path] |
Mike Frysinger | d3bd32c | 2014-11-24 23:34:29 -0500 | [diff] [blame] | 409 | |
| 410 | # Filter out symlinks. |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 411 | if not include_symlinks: |
| 412 | files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))] |
Mike Frysinger | d3bd32c | 2014-11-24 23:34:29 -0500 | [diff] [blame] | 413 | |
| 414 | if not include_deletes: |
| 415 | files = [x for x in files if x.status != 'D'] |
| 416 | |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 417 | if not include_adds: |
| 418 | files = [x for x in files if x.status != 'A'] |
| 419 | |
Daniel Erat | e3ea3fc | 2015-02-13 15:27:52 -0700 | [diff] [blame] | 420 | if use_ignore_files: |
| 421 | cache = {} |
| 422 | is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache) |
| 423 | files = [x for x in files if not is_ignored(x)] |
| 424 | |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 425 | if full_details: |
| 426 | # Caller wants the raw objects to parse status/etc... themselves. |
Mike Frysinger | d3bd32c | 2014-11-24 23:34:29 -0500 | [diff] [blame] | 427 | return files |
| 428 | else: |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 429 | # Caller only cares about filenames. |
| 430 | files = [x.dst_file if x.dst_file else x.src_file for x in files] |
| 431 | if relative: |
| 432 | return files |
| 433 | else: |
| 434 | return [os.path.join(path, x) for x in files] |
Peter Ammon | 811f670 | 2014-06-12 15:45:38 -0700 | [diff] [blame] | 435 | |
| 436 | |
Mandeep Singh Baines | b9ed140 | 2011-04-29 15:32:06 -0700 | [diff] [blame] | 437 | def _get_commits(): |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 438 | """Returns a list of commits for this review.""" |
Mike Frysinger | e300c7d | 2019-09-12 23:33:52 -0400 | [diff] [blame] | 439 | cmd = ['git', 'log', '--no-merges', '--format=%H', |
| 440 | '%s..' % _get_upstream_branch()] |
Ryan Cui | 72834d1 | 2011-05-05 14:51:33 -0700 | [diff] [blame] | 441 | return _run_command(cmd).split() |
Mandeep Singh Baines | b9ed140 | 2011-04-29 15:32:06 -0700 | [diff] [blame] | 442 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 443 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 444 | def _get_commit_desc(commit): |
| 445 | """Returns the full commit message of a commit.""" |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 446 | if commit == PRE_SUBMIT: |
| 447 | return '' |
Mike Frysinger | b249665 | 2019-09-12 23:35:46 -0400 | [diff] [blame] | 448 | |
| 449 | # {<commit>: <content>} |
| 450 | cache = CACHE.get_subcache('get_commit_desc') |
| 451 | if commit not in cache: |
Mike Frysinger | 4efdee7 | 2019-11-04 10:57:01 -0500 | [diff] [blame] | 452 | cache[commit] = _run_command(['git', 'log', '--format=%B', |
Mike Frysinger | b249665 | 2019-09-12 23:35:46 -0400 | [diff] [blame] | 453 | commit + '^!']) |
| 454 | return cache[commit] |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 455 | |
| 456 | |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 457 | def _check_lines_in_diff(commit, files, check_callable, error_description): |
| 458 | """Checks given file for errors via the given check. |
| 459 | |
| 460 | This is a convenience function for common per-line checks. It goes through all |
| 461 | files and returns a HookFailure with the error description listing all the |
| 462 | failures. |
| 463 | |
| 464 | Args: |
| 465 | commit: The commit we're working on. |
| 466 | files: The files to check. |
| 467 | check_callable: A callable that takes a line and returns True if this line |
| 468 | _fails_ the check. |
| 469 | error_description: A string describing the error. |
| 470 | """ |
| 471 | errors = [] |
| 472 | for afile in files: |
| 473 | for line_num, line in _get_file_diff(afile, commit): |
Bernie Thompson | 8e26f74 | 2020-07-23 14:32:31 -0700 | [diff] [blame] | 474 | result = check_callable(line) |
| 475 | if result: |
| 476 | msg = f'{afile}, line {line_num}' |
| 477 | if isinstance(result, str): |
| 478 | msg += f': {result}' |
| 479 | errors.append(msg) |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 480 | if errors: |
| 481 | return HookFailure(error_description, errors) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 482 | return None |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 483 | |
| 484 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 485 | def _parse_common_inclusion_options(options): |
| 486 | """Parses common hook options for including/excluding files. |
| 487 | |
| 488 | Args: |
| 489 | options: Option string list. |
| 490 | |
| 491 | Returns: |
| 492 | (included, excluded) where each one is a list of regex strings. |
| 493 | """ |
| 494 | parser = argparse.ArgumentParser() |
| 495 | parser.add_argument('--exclude_regex', action='append') |
| 496 | parser.add_argument('--include_regex', action='append') |
| 497 | opts = parser.parse_args(options) |
| 498 | included = opts.include_regex or [] |
| 499 | excluded = opts.exclude_regex or [] |
| 500 | return included, excluded |
| 501 | |
| 502 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 503 | # Common Hooks |
| 504 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 505 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 506 | def _check_no_long_lines(_project, commit, options=()): |
Mike Frysinger | 55f85b5 | 2014-12-18 14:45:21 -0500 | [diff] [blame] | 507 | """Checks there are no lines longer than MAX_LEN in any of the text files.""" |
Keigo Oka | 9732e38 | 2019-06-28 17:44:59 +0900 | [diff] [blame] | 508 | LONG_LINE_OK_PATHS = [ |
| 509 | # Go has no line length limit. |
| 510 | # https://golang.org/doc/effective_go.html#formatting |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 511 | r'.*\.go$', |
Mike Frysinger | f896194 | 2020-05-15 00:36:31 -0400 | [diff] [blame] | 512 | # Python does its own long line checks via pylint. |
| 513 | r'.*\.py$', |
Keigo Oka | 9732e38 | 2019-06-28 17:44:59 +0900 | [diff] [blame] | 514 | ] |
Mike Frysinger | 55f85b5 | 2014-12-18 14:45:21 -0500 | [diff] [blame] | 515 | |
Ayato Tokubi | 5aae3f7 | 2020-01-16 17:43:47 +0900 | [diff] [blame] | 516 | DEFAULT_MAX_LENGTHS = [ |
| 517 | # Java's line length limit is 100 chars. |
| 518 | # https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md |
| 519 | (r'.*\.java$', 100), |
Mike Frysinger | f896194 | 2020-05-15 00:36:31 -0400 | [diff] [blame] | 520 | # Rust's line length limit is 100 chars. |
| 521 | (r'.*\.rs$', 100), |
Ayato Tokubi | 5aae3f7 | 2020-01-16 17:43:47 +0900 | [diff] [blame] | 522 | ] |
| 523 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 524 | MAX_LEN = 80 |
| 525 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 526 | included, excluded = _parse_common_inclusion_options(options) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 527 | files = _filter_files(_get_affected_files(commit), |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 528 | included + COMMON_INCLUDED_PATHS, |
Keigo Oka | 9732e38 | 2019-06-28 17:44:59 +0900 | [diff] [blame] | 529 | excluded + COMMON_EXCLUDED_PATHS + LONG_LINE_OK_PATHS) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 530 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 531 | errors = [] |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 532 | for afile in files: |
George Burgess IV | f9f79eb | 2019-07-09 20:12:55 -0700 | [diff] [blame] | 533 | skip_regexps = ( |
| 534 | r'https?://', |
| 535 | r'^#\s*(define|include|import|pragma|if|ifndef|endif)\b', |
| 536 | ) |
| 537 | |
Ayato Tokubi | 5aae3f7 | 2020-01-16 17:43:47 +0900 | [diff] [blame] | 538 | max_len = MAX_LEN |
| 539 | |
| 540 | for expr, length in DEFAULT_MAX_LENGTHS: |
| 541 | if re.search(expr, afile): |
| 542 | max_len = length |
| 543 | break |
| 544 | |
George Burgess IV | f9f79eb | 2019-07-09 20:12:55 -0700 | [diff] [blame] | 545 | if os.path.basename(afile).startswith('OWNERS'): |
| 546 | # File paths can get long, and there's no way to break them up into |
| 547 | # multiple lines. |
| 548 | skip_regexps += ( |
| 549 | r'^include\b', |
| 550 | r'file:', |
| 551 | ) |
| 552 | |
| 553 | skip_regexps = [re.compile(x) for x in skip_regexps] |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 554 | for line_num, line in _get_file_diff(afile, commit): |
| 555 | # Allow certain lines to exceed the maxlen rule. |
Ayato Tokubi | 5aae3f7 | 2020-01-16 17:43:47 +0900 | [diff] [blame] | 556 | if len(line) <= max_len or any(x.search(line) for x in skip_regexps): |
Jon Salz | 9825593 | 2012-08-18 14:48:02 +0800 | [diff] [blame] | 557 | continue |
| 558 | |
Ayato Tokubi | 5aae3f7 | 2020-01-16 17:43:47 +0900 | [diff] [blame] | 559 | errors.append('%s, line %s, %s chars, over %s chars' % |
| 560 | (afile, line_num, len(line), max_len)) |
Jon Salz | 9825593 | 2012-08-18 14:48:02 +0800 | [diff] [blame] | 561 | if len(errors) == 5: # Just show the first 5 errors. |
| 562 | break |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 563 | |
| 564 | if errors: |
Ayato Tokubi | 5aae3f7 | 2020-01-16 17:43:47 +0900 | [diff] [blame] | 565 | msg = 'Found lines longer than the limit (first 5 shown):' |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 566 | return HookFailure(msg, errors) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 567 | return None |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 568 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 569 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 570 | def _check_no_stray_whitespace(_project, commit, options=()): |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 571 | """Checks that there is no stray whitespace at source lines end.""" |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 572 | included, excluded = _parse_common_inclusion_options(options) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 573 | files = _filter_files(_get_affected_files(commit), |
Tomasz Figa | 375b962 | 2020-09-22 14:25:07 +0000 | [diff] [blame] | 574 | included + COMMON_INCLUDED_PATHS + [r'^.*\.md$'], |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 575 | excluded + COMMON_EXCLUDED_PATHS) |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 576 | return _check_lines_in_diff(commit, files, |
| 577 | lambda line: line.rstrip() != line, |
| 578 | 'Found line ending with white space in:') |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 579 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 580 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 581 | def _check_no_tabs(_project, commit, options=()): |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 582 | """Checks there are no unexpanded tabs.""" |
Mike Frysinger | cd13451 | 2017-10-26 04:36:33 -0400 | [diff] [blame] | 583 | # Don't add entire repos here. Update the PRESUBMIT.cfg in each repo instead. |
Bob Haarman | 0dc1f94 | 2020-10-03 00:06:59 +0000 | [diff] [blame] | 584 | # We only allow known specific filetypes here that show up in all repos. |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 585 | TAB_OK_PATHS = [ |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 586 | r'.*\.ebuild$', |
| 587 | r'.*\.eclass$', |
| 588 | r'.*\.go$', |
| 589 | r'.*/[M|m]akefile$', |
| 590 | r'.*\.mk$', |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 591 | ] |
| 592 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 593 | included, excluded = _parse_common_inclusion_options(options) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 594 | files = _filter_files(_get_affected_files(commit), |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 595 | included + COMMON_INCLUDED_PATHS, |
| 596 | excluded + COMMON_EXCLUDED_PATHS + TAB_OK_PATHS) |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 597 | return _check_lines_in_diff(commit, files, |
| 598 | lambda line: '\t' in line, |
| 599 | 'Found a tab character in:') |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 600 | |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 601 | |
Daisuke Nojiri | 2089e01 | 2020-08-20 15:12:36 -0700 | [diff] [blame] | 602 | def _read_terms_file(terms_file): |
| 603 | """Read list of words from file, skipping comments and blank lines.""" |
| 604 | file_terms = set() |
| 605 | for line in osutils.ReadFile(terms_file).splitlines(): |
| 606 | # Allow comment and blank lines. |
| 607 | line = line.split('#', 1)[0] |
| 608 | if not line: |
| 609 | continue |
| 610 | file_terms.add(line) |
| 611 | return file_terms |
| 612 | |
| 613 | |
Bernie Thompson | 8e26f74 | 2020-07-23 14:32:31 -0700 | [diff] [blame] | 614 | def _check_keywords(_project, commit, options=()): |
| 615 | """Checks there are no blocked keywords in commit content.""" |
Daisuke Nojiri | 2089e01 | 2020-08-20 15:12:36 -0700 | [diff] [blame] | 616 | # Read options from override list. |
Bernie Thompson | 8e26f74 | 2020-07-23 14:32:31 -0700 | [diff] [blame] | 617 | parser = argparse.ArgumentParser() |
| 618 | parser.add_argument('--exclude_regex', action='append', default=[]) |
| 619 | parser.add_argument('--include_regex', action='append', default=[]) |
| 620 | parser.add_argument('--block', action='append', default=[]) |
| 621 | parser.add_argument('--unblock', action='append', default=[]) |
| 622 | opts = parser.parse_args(options) |
| 623 | |
Daisuke Nojiri | 2089e01 | 2020-08-20 15:12:36 -0700 | [diff] [blame] | 624 | # Read blocked word list. |
| 625 | blocked_terms_file = os.path.join(_get_hooks_dir(), BLOCKED_TERMS_FILE) |
| 626 | common_keywords = _read_terms_file(blocked_terms_file) |
| 627 | |
| 628 | # Read unblocked word list. Global list is skipped if local list exists. |
| 629 | unblocked_terms_file = os.path.join(_get_hooks_dir(), UNBLOCKED_TERMS_FILE) |
| 630 | if os.path.isfile(os.path.join(_project.dir, UNBLOCKED_TERMS_FILE)): |
| 631 | unblocked_terms_file = os.path.join(_project.dir, UNBLOCKED_TERMS_FILE) |
| 632 | unblocked_words = _read_terms_file(unblocked_terms_file) |
| 633 | unblocked_words.update(opts.unblock) |
| 634 | |
Bernie Thompson | 8e26f74 | 2020-07-23 14:32:31 -0700 | [diff] [blame] | 635 | keywords = set(common_keywords | set(opts.block)) |
Daisuke Nojiri | 2089e01 | 2020-08-20 15:12:36 -0700 | [diff] [blame] | 636 | keywords = sorted(keywords - unblocked_words) |
Mike Frysinger | 6140f57 | 2020-09-10 04:52:46 -0400 | [diff] [blame] | 637 | files = _filter_files( |
| 638 | _get_affected_files(commit), |
Tomasz Figa | 375b962 | 2020-09-22 14:25:07 +0000 | [diff] [blame] | 639 | opts.include_regex + COMMON_INCLUDED_PATHS + [r'^.*\.md$'], |
Mike Frysinger | 6140f57 | 2020-09-10 04:52:46 -0400 | [diff] [blame] | 640 | opts.exclude_regex + COMMON_EXCLUDED_PATHS) |
Bernie Thompson | 8e26f74 | 2020-07-23 14:32:31 -0700 | [diff] [blame] | 641 | errors = [] |
| 642 | |
| 643 | def _check_line(line): |
Laurent Chavey | 434af9a | 2020-09-28 22:25:16 +0900 | [diff] [blame] | 644 | # Store information about each span matching blocking regex. |
| 645 | # to match unblocked regex with blocked reg ex match. |
| 646 | # [{'span':re.span, - overlap of matching regex in line |
| 647 | # 'group':re.group, - matching term |
| 648 | # 'blocked':bool, - True: matching blocked, False: matching unblocked |
| 649 | # 'keyword':regex, - block regex |
| 650 | # }, ...] |
| 651 | blocked_span = [] |
| 652 | # Store information about each span matching unblocking regex. |
| 653 | # [re.span, ...] |
| 654 | unblocked_span = [] |
| 655 | |
Bernie Thompson | 8e26f74 | 2020-07-23 14:32:31 -0700 | [diff] [blame] | 656 | for word in keywords: |
Laurent Chavey | 434af9a | 2020-09-28 22:25:16 +0900 | [diff] [blame] | 657 | for match in re.finditer(word, line, flags=re.I): |
| 658 | blocked_span.append({'span' : match.span(), |
| 659 | 'group' : match.group(0), |
| 660 | 'blocked' : True, |
| 661 | 'keyword' : word}) |
| 662 | |
| 663 | for unblocked in unblocked_words: |
| 664 | for match in re.finditer(unblocked, line, flags=re.I): |
| 665 | unblocked_span.append(match.span()) |
| 666 | |
| 667 | # Unblock terms that are superset of blocked terms: |
| 668 | # blocked := "this.?word" |
| 669 | # unblocked := "\.this.?word" |
| 670 | # "this line is blocked because of this1word" |
| 671 | # "this line is unblocked because of thenew.this1word" |
| 672 | # |
| 673 | for b in blocked_span: |
| 674 | for ub in unblocked_span: |
| 675 | if ub[0] <= b['span'][0] and ub[1] >= b['span'][1]: |
| 676 | b['blocked'] = False |
| 677 | if b['blocked']: |
| 678 | return f'Matched "{b["group"]}" with regex of "{b["keyword"]}"' |
Bernie Thompson | 8e26f74 | 2020-07-23 14:32:31 -0700 | [diff] [blame] | 679 | return False |
| 680 | |
| 681 | diff_errors = _check_lines_in_diff(commit, files, _check_line, |
| 682 | 'Found a blocked keyword in:') |
| 683 | if diff_errors: |
| 684 | errors.append(diff_errors) |
| 685 | |
| 686 | line_num = 1 |
| 687 | commit_desc_errors = [] |
| 688 | for line in _get_commit_desc(commit).splitlines(): |
| 689 | result = _check_line(line) |
| 690 | if result: |
| 691 | commit_desc_errors.append('Commit message, line %s: %s' % |
| 692 | (line_num, result)) |
| 693 | line_num += 1 |
| 694 | if commit_desc_errors: |
| 695 | errors.append(HookFailure('Found a blocked keyword in:', |
| 696 | commit_desc_errors)) |
| 697 | return errors |
| 698 | |
| 699 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 700 | def _check_tabbed_indents(_project, commit, options=()): |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 701 | """Checks that indents use tabs only.""" |
| 702 | TABS_REQUIRED_PATHS = [ |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 703 | r'.*\.ebuild$', |
| 704 | r'.*\.eclass$', |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 705 | ] |
| 706 | LEADING_SPACE_RE = re.compile('[\t]* ') |
| 707 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 708 | included, excluded = _parse_common_inclusion_options(options) |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 709 | files = _filter_files(_get_affected_files(commit), |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 710 | included + TABS_REQUIRED_PATHS, |
| 711 | excluded + COMMON_EXCLUDED_PATHS) |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 712 | return _check_lines_in_diff( |
| 713 | commit, files, |
| 714 | lambda line: LEADING_SPACE_RE.match(line) is not None, |
| 715 | 'Found a space in indentation (must be all tabs):') |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 716 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 717 | |
LaMont Jones | 872fe76 | 2020-02-10 15:36:14 -0700 | [diff] [blame] | 718 | def _check_gofmt(_project, commit, options=()): |
Rahul Chaudhry | 09f6137 | 2015-07-31 17:14:26 -0700 | [diff] [blame] | 719 | """Checks that Go files are formatted with gofmt.""" |
LaMont Jones | 872fe76 | 2020-02-10 15:36:14 -0700 | [diff] [blame] | 720 | included, excluded = _parse_common_inclusion_options(options) |
Rahul Chaudhry | 09f6137 | 2015-07-31 17:14:26 -0700 | [diff] [blame] | 721 | errors = [] |
| 722 | files = _filter_files(_get_affected_files(commit, relative=True), |
LaMont Jones | 872fe76 | 2020-02-10 15:36:14 -0700 | [diff] [blame] | 723 | included + [r'\.go$'], |
| 724 | excluded) |
Rahul Chaudhry | 09f6137 | 2015-07-31 17:14:26 -0700 | [diff] [blame] | 725 | |
| 726 | for gofile in files: |
| 727 | contents = _get_file_content(gofile, commit) |
Mike Frysinger | aa7dc94 | 2019-09-25 00:07:24 -0400 | [diff] [blame] | 728 | output = _run_command(cmd=['gofmt', '-l'], input=contents.encode('utf-8'), |
Mike Frysinger | d0c5c8b | 2019-12-17 02:28:26 -0500 | [diff] [blame] | 729 | stderr=subprocess.STDOUT) |
Rahul Chaudhry | 09f6137 | 2015-07-31 17:14:26 -0700 | [diff] [blame] | 730 | if output: |
| 731 | errors.append(gofile) |
| 732 | if errors: |
| 733 | return HookFailure('Files not formatted with gofmt:', errors) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 734 | return None |
Rahul Chaudhry | 09f6137 | 2015-07-31 17:14:26 -0700 | [diff] [blame] | 735 | |
| 736 | |
Fletcher Woodruff | ce1cb1b | 2019-08-16 15:59:32 -0600 | [diff] [blame] | 737 | def _check_rustfmt(_project, commit): |
| 738 | """Checks that Rust files are formatted with rustfmt.""" |
| 739 | errors = [] |
| 740 | files = _filter_files(_get_affected_files(commit, relative=True), |
| 741 | [r'\.rs$']) |
| 742 | |
| 743 | for rustfile in files: |
| 744 | contents = _get_file_content(rustfile, commit) |
Chirantan Ekbote | 1da56d5 | 2020-07-13 17:35:35 +0900 | [diff] [blame] | 745 | output = _run_command(cmd=['rustfmt', '--edition', '2018'], |
| 746 | input=contents.encode('utf-8'), |
Mike Frysinger | d0c5c8b | 2019-12-17 02:28:26 -0500 | [diff] [blame] | 747 | stderr=subprocess.STDOUT) |
Fletcher Woodruff | ce1cb1b | 2019-08-16 15:59:32 -0600 | [diff] [blame] | 748 | if output != contents: |
| 749 | errors.append(rustfile) |
| 750 | if errors: |
| 751 | return HookFailure('Files not formatted with rustfmt: ' |
| 752 | "(run 'cargo fmt' to fix)", errors) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 753 | return None |
Fletcher Woodruff | ce1cb1b | 2019-08-16 15:59:32 -0600 | [diff] [blame] | 754 | |
| 755 | |
Keiichi Watanabe | 6ab73fd | 2020-07-14 23:42:02 +0900 | [diff] [blame] | 756 | class CargoClippyArgumentParserError(Exception): |
| 757 | """An exception indicating an invalid check_cargo_clippy option.""" |
| 758 | |
| 759 | |
| 760 | class CargoClippyArgumentParser(argparse.ArgumentParser): |
| 761 | """A argument parser for check_cargo_clippy.""" |
| 762 | |
| 763 | def error(self, message): |
| 764 | raise CargoClippyArgumentParserError(message) |
| 765 | |
| 766 | |
| 767 | # A cargo project in which clippy runs. |
| 768 | ClippyProject = collections.namedtuple('ClippyProject', ('root', 'script')) |
| 769 | |
| 770 | |
| 771 | class _AddClippyProjectAction(argparse.Action): |
| 772 | """A callback that adds a cargo clippy setting. |
| 773 | |
| 774 | It accepts a value which is in the form of "ROOT[:SCRIPT]". |
| 775 | """ |
| 776 | |
| 777 | def __call__(self, parser, namespace, values, option_string=None): |
| 778 | if getattr(namespace, self.dest, None) is None: |
| 779 | setattr(namespace, self.dest, []) |
| 780 | spec = values.split(':', 1) |
| 781 | if len(spec) == 1: |
| 782 | spec += [None] |
| 783 | |
| 784 | if spec[0].startswith('/'): |
| 785 | raise CargoClippyArgumentParserError('root path must not start with "/"' |
| 786 | f' but "{spec[0]}"') |
| 787 | |
| 788 | clippy = ClippyProject(root=spec[0], script=spec[1]) |
| 789 | getattr(namespace, self.dest).append(clippy) |
| 790 | |
| 791 | |
| 792 | def _get_cargo_clippy_parser(): |
| 793 | """Creates a parser for check_cargo_clippy options.""" |
| 794 | |
| 795 | parser = CargoClippyArgumentParser() |
| 796 | parser.add_argument('--project', action=_AddClippyProjectAction, default=[]) |
| 797 | |
| 798 | return parser |
| 799 | |
| 800 | |
| 801 | def _check_cargo_clippy(project, commit, options=()): |
| 802 | """Checks that a change doesn't produce cargo-clippy errors.""" |
| 803 | |
| 804 | options = list(options) |
| 805 | if not options: |
| 806 | return [] |
| 807 | parser = _get_cargo_clippy_parser() |
| 808 | |
| 809 | try: |
| 810 | opts = parser.parse_args(options) |
| 811 | except CargoClippyArgumentParserError as e: |
| 812 | return [HookFailure('invalid check_cargo_clippy option is given.' |
| 813 | f' Please check PRESUBMIT.cfg is correct: {e}')] |
| 814 | files = _get_affected_files(commit) |
| 815 | |
| 816 | errors = [] |
| 817 | for clippy in opts.project: |
| 818 | root = os.path.normpath(os.path.join(project.dir, clippy.root)) |
| 819 | |
| 820 | # Check if any file under `root` was modified. |
| 821 | modified = False |
| 822 | for f in files: |
| 823 | if f.startswith(root): |
| 824 | modified = True |
| 825 | break |
| 826 | if not modified: |
| 827 | continue |
| 828 | |
| 829 | # Clean cargo's cache when we run clippy for this `root` for the first time. |
| 830 | # We don't want to clean the cache between commits to save time when |
| 831 | # multiple commits are checked. |
| 832 | if root not in _check_cargo_clippy.cleaned_root: |
| 833 | _run_command(['cargo', 'clean', |
| 834 | f'--manifest-path={root}/Cargo.toml'], |
| 835 | stderr=subprocess.STDOUT) |
| 836 | _check_cargo_clippy.cleaned_root.add(root) |
| 837 | |
| 838 | cmd = ['cargo', 'clippy', '--all-features', '--all-targets', |
| 839 | f'--manifest-path={root}/Cargo.toml', |
| 840 | '--', '-D', 'warnings'] |
| 841 | # Overwrite the clippy command if a project-specific script is specified. |
| 842 | if clippy.script: |
| 843 | cmd = [os.path.join(project.dir, clippy.script)] |
| 844 | |
| 845 | output = _run_command(cmd, stderr=subprocess.STDOUT) |
| 846 | error = re.search(r'^error: ', output, flags=re.MULTILINE) |
| 847 | if error: |
| 848 | msg = output[error.start():] |
| 849 | errors.append(HookFailure(msg)) |
| 850 | |
| 851 | return errors |
| 852 | |
| 853 | |
| 854 | # Stores cargo projects in which `cargo clean` ran. |
| 855 | _check_cargo_clippy.cleaned_root = set() |
| 856 | |
| 857 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 858 | def _check_change_has_test_field(_project, commit): |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 859 | """Check for a non-empty 'TEST=' field in the commit message.""" |
Mike Frysinger | ed9b2a0 | 2019-12-12 18:52:32 -0500 | [diff] [blame] | 860 | SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 861 | |
Cheng Yueh | b707c52 | 2020-01-02 14:06:59 +0800 | [diff] [blame] | 862 | if not re.search(TEST_FIELD_RE, _get_commit_desc(commit)): |
Mike Frysinger | ed9b2a0 | 2019-12-12 18:52:32 -0500 | [diff] [blame] | 863 | msg = ('Changelist description needs TEST field (after first line)\n%s' % |
| 864 | (SEE_ALSO,)) |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 865 | return HookFailure(msg) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 866 | return None |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 867 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 868 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 869 | def _check_change_has_valid_cq_depend(_project, commit): |
Jason D. Clinton | 299e322 | 2019-05-23 09:42:03 -0600 | [diff] [blame] | 870 | """Check for a correctly formatted Cq-Depend field in the commit message.""" |
Luigi Semenzato | b8c7d7d | 2019-06-03 09:43:21 -0700 | [diff] [blame] | 871 | desc = _get_commit_desc(commit) |
Jason D. Clinton | 299e322 | 2019-05-23 09:42:03 -0600 | [diff] [blame] | 872 | msg = 'Changelist has invalid Cq-Depend target.' |
| 873 | example = 'Example: Cq-Depend: chromium:1234, chrome-internal:2345' |
David James | c3b68b3 | 2013-04-03 09:17:03 -0700 | [diff] [blame] | 874 | try: |
Luigi Semenzato | b8c7d7d | 2019-06-03 09:43:21 -0700 | [diff] [blame] | 875 | patch.GetPaladinDeps(desc) |
David James | c3b68b3 | 2013-04-03 09:17:03 -0700 | [diff] [blame] | 876 | except ValueError as ex: |
| 877 | return HookFailure(msg, [example, str(ex)]) |
Luigi Semenzato | b8c7d7d | 2019-06-03 09:43:21 -0700 | [diff] [blame] | 878 | # Check that Cq-Depend is in the same paragraph as Change-Id. |
Mike Frysinger | e39d0cd | 2019-11-25 13:30:06 -0500 | [diff] [blame] | 879 | msg = 'Cq-Depend is not in the same paragraph as Change-Id.' |
Luigi Semenzato | b8c7d7d | 2019-06-03 09:43:21 -0700 | [diff] [blame] | 880 | paragraphs = desc.split('\n\n') |
| 881 | for paragraph in paragraphs: |
Mike Frysinger | e39d0cd | 2019-11-25 13:30:06 -0500 | [diff] [blame] | 882 | if (re.search(r'^Cq-Depend:', paragraph, re.M) and not |
| 883 | re.search('^Change-Id:', paragraph, re.M)): |
Luigi Semenzato | b8c7d7d | 2019-06-03 09:43:21 -0700 | [diff] [blame] | 884 | return HookFailure(msg) |
Mike Frysinger | e39d0cd | 2019-11-25 13:30:06 -0500 | [diff] [blame] | 885 | |
| 886 | # We no longer support CQ-DEPEND= lines. |
| 887 | if re.search(r'^CQ-DEPEND[=:]', desc, re.M): |
| 888 | return HookFailure( |
| 889 | 'CQ-DEPEND= is no longer supported. Please see:\n' |
| 890 | 'https://chromium.googlesource.com/chromiumos/docs/+/HEAD/' |
| 891 | 'contributing.md#CQ-DEPEND') |
| 892 | |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 893 | return None |
David James | c3b68b3 | 2013-04-03 09:17:03 -0700 | [diff] [blame] | 894 | |
| 895 | |
Bernie Thompson | f8fea99 | 2016-01-14 10:27:18 -0800 | [diff] [blame] | 896 | def _check_change_is_contribution(_project, commit): |
| 897 | """Check that the change is a contribution.""" |
| 898 | NO_CONTRIB = 'not a contribution' |
| 899 | if NO_CONTRIB in _get_commit_desc(commit).lower(): |
| 900 | msg = ('Changelist is not a contribution, this cannot be accepted.\n' |
| 901 | 'Please remove the "%s" text from the commit message.') % NO_CONTRIB |
| 902 | return HookFailure(msg) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 903 | return None |
Bernie Thompson | f8fea99 | 2016-01-14 10:27:18 -0800 | [diff] [blame] | 904 | |
| 905 | |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 906 | def _check_change_has_bug_field(project, commit): |
David McMahon | 8f6553e | 2011-06-10 15:46:36 -0700 | [diff] [blame] | 907 | """Check for a correctly formatted 'BUG=' field in the commit message.""" |
Mike Frysinger | ed9b2a0 | 2019-12-12 18:52:32 -0500 | [diff] [blame] | 908 | SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,) |
| 909 | |
David James | 5c0073d | 2013-04-03 08:48:52 -0700 | [diff] [blame] | 910 | OLD_BUG_RE = r'\nBUG=.*chromium-os' |
| 911 | if re.search(OLD_BUG_RE, _get_commit_desc(commit)): |
| 912 | msg = ('The chromium-os bug tracker is now deprecated. Please use\n' |
| 913 | 'the chromium tracker in your BUG= line now.') |
| 914 | return HookFailure(msg) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 915 | |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 916 | # Android internal and external projects use "Bug: " to track bugs in |
| 917 | # buganizer. |
| 918 | BUG_COLON_REMOTES = ( |
| 919 | 'aosp', |
| 920 | 'goog', |
| 921 | ) |
| 922 | if project.remote in BUG_COLON_REMOTES: |
| 923 | BUG_RE = r'\nBug: ?([Nn]one|\d+)' |
| 924 | if not re.search(BUG_RE, _get_commit_desc(commit)): |
| 925 | msg = ('Changelist description needs BUG field (after first line):\n' |
Mike Frysinger | ed9b2a0 | 2019-12-12 18:52:32 -0500 | [diff] [blame] | 926 | 'Examples:\n' |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 927 | 'Bug: 9999 (for buganizer)\n' |
Mike Frysinger | ed9b2a0 | 2019-12-12 18:52:32 -0500 | [diff] [blame] | 928 | 'BUG=None\n%s' % (SEE_ALSO,)) |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 929 | return HookFailure(msg) |
| 930 | else: |
Jorge Lucangeli Obes | dce214e | 2017-10-25 15:04:39 -0400 | [diff] [blame] | 931 | BUG_RE = r'\nBUG=([Nn]one|(chromium|b):\d+)' |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 932 | if not re.search(BUG_RE, _get_commit_desc(commit)): |
| 933 | msg = ('Changelist description needs BUG field (after first line):\n' |
Mike Frysinger | ed9b2a0 | 2019-12-12 18:52:32 -0500 | [diff] [blame] | 934 | 'Examples:\n' |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 935 | 'BUG=chromium:9999 (for public tracker)\n' |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 936 | 'BUG=b:9999 (for buganizer)\n' |
Mike Frysinger | ed9b2a0 | 2019-12-12 18:52:32 -0500 | [diff] [blame] | 937 | 'BUG=None\n%s' % (SEE_ALSO,)) |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 938 | return HookFailure(msg) |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 939 | |
Cheng Yueh | b707c52 | 2020-01-02 14:06:59 +0800 | [diff] [blame] | 940 | TEST_BEFORE_BUG_RE = TEST_FIELD_RE + r'.*' + BUG_RE |
| 941 | |
| 942 | if re.search(TEST_BEFORE_BUG_RE, _get_commit_desc(commit), re.DOTALL): |
| 943 | msg = ('The BUG field must come before the TEST field.\n%s' % |
| 944 | (SEE_ALSO,)) |
| 945 | return HookFailure(msg) |
| 946 | |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 947 | return None |
| 948 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 949 | |
Jack Neus | 8edbf64 | 2019-07-10 16:08:31 -0600 | [diff] [blame] | 950 | def _check_change_no_include_oem(project, commit): |
| 951 | """Check that the change does not reference OEMs.""" |
| 952 | ALLOWLIST = { |
| 953 | 'chromiumos/platform/ec', |
| 954 | # Used by unit tests. |
| 955 | 'project', |
| 956 | } |
| 957 | if project.name not in ALLOWLIST: |
| 958 | return None |
| 959 | |
Mike Frysinger | bb34a22 | 2019-07-31 14:40:46 -0400 | [diff] [blame] | 960 | TAGS = { |
Jack Neus | 8edbf64 | 2019-07-10 16:08:31 -0600 | [diff] [blame] | 961 | 'Reviewed-on', |
| 962 | 'Reviewed-by', |
| 963 | 'Signed-off-by', |
| 964 | 'Commit-Ready', |
| 965 | 'Tested-by', |
| 966 | 'Commit-Queue', |
Jack Neus | 8edbf64 | 2019-07-10 16:08:31 -0600 | [diff] [blame] | 967 | 'Acked-by', |
| 968 | 'Modified-by', |
| 969 | 'CC', |
| 970 | 'Suggested-by', |
| 971 | 'Reported-by', |
| 972 | 'Acked-for-chrome-by', |
LaMont Jones | 237f3ef | 2020-01-22 10:40:52 -0700 | [diff] [blame] | 973 | 'Cq-Cl-Tag', |
LaMont Jones | fb5e8bf | 2020-03-03 12:50:06 -0700 | [diff] [blame] | 974 | 'Cq-Include-Trybots', |
Mike Frysinger | bb34a22 | 2019-07-31 14:40:46 -0400 | [diff] [blame] | 975 | } |
Jack Neus | 8edbf64 | 2019-07-10 16:08:31 -0600 | [diff] [blame] | 976 | |
| 977 | # Ignore tags, which could reasonably contain OEM names |
| 978 | # (e.g. Reviewed-by: foo@oem.corp-partner.google.com). |
Jack Neus | 8edbf64 | 2019-07-10 16:08:31 -0600 | [diff] [blame] | 979 | commit_message = ' '.join( |
Mike Frysinger | bb34a22 | 2019-07-31 14:40:46 -0400 | [diff] [blame] | 980 | x for x in _get_commit_desc(commit).splitlines() |
| 981 | if ':' not in x or x.split(':', 1)[0] not in TAGS) |
| 982 | |
Jack Neus | 8edbf64 | 2019-07-10 16:08:31 -0600 | [diff] [blame] | 983 | commit_message = re.sub(r'[\s_-]+', ' ', commit_message) |
| 984 | |
| 985 | # Exercise caution when expanding these lists. Adding a name |
| 986 | # could indicate a new relationship with a company! |
| 987 | OEMS = ['hp', 'hewlett packard', 'dell', 'lenovo', 'acer', 'asus', 'samsung'] |
| 988 | ODMS = [ |
| 989 | 'bitland', 'compal', 'haier', 'huaqin', 'inventec', 'lg', 'pegatron', |
| 990 | 'pegatron(ems)', 'quanta', 'samsung', 'wistron' |
| 991 | ] |
| 992 | |
| 993 | for name_type, name_list in [('OEM', OEMS), ('ODM', ODMS)]: |
| 994 | # Construct regex |
| 995 | name_re = r'\b(%s)\b' % '|'.join([re.escape(x) for x in name_list]) |
| 996 | matches = [x[0] for x in re.findall(name_re, commit_message, re.IGNORECASE)] |
Mike Frysinger | e52b1bc | 2019-09-16 23:45:41 -0400 | [diff] [blame] | 997 | if matches: |
Jack Neus | 8edbf64 | 2019-07-10 16:08:31 -0600 | [diff] [blame] | 998 | # If there's a match, throw an error. |
| 999 | error_msg = ('Changelist description contains the name of an' |
| 1000 | ' %s: "%s".' % (name_type, '","'.join(matches))) |
| 1001 | return HookFailure(error_msg) |
| 1002 | |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1003 | return None |
| 1004 | |
Jack Neus | 8edbf64 | 2019-07-10 16:08:31 -0600 | [diff] [blame] | 1005 | |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 1006 | def _check_for_uprev(project, commit, project_top=None): |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 1007 | """Check that we're not missing a revbump of an ebuild in the given commit. |
| 1008 | |
| 1009 | If the given commit touches files in a directory that has ebuilds somewhere |
| 1010 | up the directory hierarchy, it's very likely that we need an ebuild revbump |
| 1011 | in order for those changes to take effect. |
| 1012 | |
| 1013 | It's not totally trivial to detect a revbump, so at least detect that an |
| 1014 | ebuild with a revision number in it was touched. This should handle the |
| 1015 | common case where we use a symlink to do the revbump. |
| 1016 | |
| 1017 | TODO: it would be nice to enhance this hook to: |
| 1018 | * Handle cases where people revbump with a slightly different syntax. I see |
| 1019 | one ebuild (puppy) that revbumps with _pN. This is a false positive. |
| 1020 | * Catches cases where people aren't using symlinks for revbumps. If they |
| 1021 | edit a revisioned file directly (and are expected to rename it for revbump) |
| 1022 | we'll miss that. Perhaps we could detect that the file touched is a |
| 1023 | symlink? |
| 1024 | |
| 1025 | If a project doesn't use symlinks we'll potentially miss a revbump, but we're |
| 1026 | still better off than without this check. |
| 1027 | |
| 1028 | Args: |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 1029 | project: The Project to look at |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 1030 | commit: The commit to look at |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 1031 | project_top: Top dir to process commits in |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 1032 | |
| 1033 | Returns: |
| 1034 | A HookFailure or None. |
| 1035 | """ |
Mike Frysinger | 011af94 | 2014-01-17 16:12:22 -0500 | [diff] [blame] | 1036 | # If this is the portage-stable overlay, then ignore the check. It's rare |
| 1037 | # that we're doing anything other than importing files from upstream, so |
| 1038 | # forcing a rev bump makes no sense. |
Bob Haarman | 0dc1f94 | 2020-10-03 00:06:59 +0000 | [diff] [blame] | 1039 | allowlist = ( |
Mike Frysinger | 011af94 | 2014-01-17 16:12:22 -0500 | [diff] [blame] | 1040 | 'chromiumos/overlays/portage-stable', |
| 1041 | ) |
Bob Haarman | 0dc1f94 | 2020-10-03 00:06:59 +0000 | [diff] [blame] | 1042 | if project.name in allowlist: |
Mike Frysinger | 011af94 | 2014-01-17 16:12:22 -0500 | [diff] [blame] | 1043 | return None |
| 1044 | |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 1045 | def FinalName(obj): |
| 1046 | # If the file is being deleted, then the dst_file is not set. |
| 1047 | if obj.dst_file is None: |
| 1048 | return obj.src_file |
| 1049 | else: |
| 1050 | return obj.dst_file |
| 1051 | |
Stephen Boyd | 6bf5ea8 | 2020-10-15 00:02:07 -0700 | [diff] [blame] | 1052 | def AllowedPath(obj): |
| 1053 | allowed_files = {'ChangeLog', 'Manifest', 'metadata.xml'} |
| 1054 | allowed_directories = {'profiles'} |
| 1055 | |
| 1056 | affected = pathlib.Path(FinalName(obj)) |
| 1057 | if affected.name in allowed_files: |
| 1058 | return True |
| 1059 | |
| 1060 | for directory in allowed_directories: |
| 1061 | if directory in affected.parts: |
| 1062 | return True |
| 1063 | |
| 1064 | return False |
| 1065 | |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 1066 | affected_path_objs = _get_affected_files( |
| 1067 | commit, include_deletes=True, include_symlinks=True, relative=True, |
| 1068 | full_details=True) |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 1069 | |
Stephen Boyd | 6bf5ea8 | 2020-10-15 00:02:07 -0700 | [diff] [blame] | 1070 | # Don't yell about changes to allowed files or directories... |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 1071 | affected_path_objs = [x for x in affected_path_objs |
Stephen Boyd | 6bf5ea8 | 2020-10-15 00:02:07 -0700 | [diff] [blame] | 1072 | if not AllowedPath(x)] |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 1073 | if not affected_path_objs: |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 1074 | return None |
| 1075 | |
| 1076 | # If we've touched any file named with a -rN.ebuild then we'll say we're |
| 1077 | # OK right away. See TODO above about enhancing this. |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 1078 | touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x)) |
| 1079 | for x in affected_path_objs) |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 1080 | if touched_revved_ebuild: |
| 1081 | return None |
| 1082 | |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 1083 | # If we're creating new ebuilds from scratch, then we don't need an uprev. |
| 1084 | # Find all the dirs that new ebuilds and ignore their files/. |
| 1085 | ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs |
| 1086 | if FinalName(x).endswith('.ebuild') and x.status == 'A'] |
| 1087 | affected_path_objs = [obj for obj in affected_path_objs |
| 1088 | if not any(FinalName(obj).startswith(x) |
| 1089 | for x in ebuild_dirs)] |
| 1090 | if not affected_path_objs: |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1091 | return None |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 1092 | |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 1093 | # We want to examine the current contents of all directories that are parents |
| 1094 | # of files that were touched (up to the top of the project). |
| 1095 | # |
| 1096 | # ...note: we use the current directory contents even though it may have |
| 1097 | # changed since the commit we're looking at. This is just a heuristic after |
| 1098 | # all. Worst case we don't flag a missing revbump. |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 1099 | if project_top is None: |
| 1100 | project_top = os.getcwd() |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 1101 | dirs_to_check = set([project_top]) |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 1102 | for obj in affected_path_objs: |
| 1103 | path = os.path.join(project_top, os.path.dirname(FinalName(obj))) |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 1104 | while os.path.exists(path) and not os.path.samefile(path, project_top): |
| 1105 | dirs_to_check.add(path) |
| 1106 | path = os.path.dirname(path) |
| 1107 | |
| 1108 | # Look through each directory. If it's got an ebuild in it then we'll |
| 1109 | # consider this as a case when we need a revbump. |
Gwendal Grignou | a3086c3 | 2014-12-09 11:17:22 -0800 | [diff] [blame] | 1110 | affected_paths = set(os.path.join(project_top, FinalName(x)) |
| 1111 | for x in affected_path_objs) |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 1112 | for dir_path in dirs_to_check: |
| 1113 | contents = os.listdir(dir_path) |
| 1114 | ebuilds = [os.path.join(dir_path, path) |
| 1115 | for path in contents if path.endswith('.ebuild')] |
| 1116 | ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')] |
| 1117 | |
C Shapiro | ae157ae | 2017-09-18 16:24:03 -0600 | [diff] [blame] | 1118 | affected_paths_under_9999_ebuilds = set() |
| 1119 | for affected_path in affected_paths: |
| 1120 | for ebuild_9999 in ebuilds_9999: |
| 1121 | ebuild_dir = os.path.dirname(ebuild_9999) |
| 1122 | if affected_path.startswith(ebuild_dir): |
| 1123 | affected_paths_under_9999_ebuilds.add(affected_path) |
| 1124 | |
| 1125 | # If every file changed exists under a 9999 ebuild, then skip |
| 1126 | if len(affected_paths_under_9999_ebuilds) == len(affected_paths): |
| 1127 | continue |
| 1128 | |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 1129 | # If the -9999.ebuild file was touched the bot will uprev for us. |
| 1130 | # ...we'll use a simple intersection here as a heuristic... |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 1131 | if set(ebuilds_9999) & affected_paths: |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 1132 | continue |
| 1133 | |
| 1134 | if ebuilds: |
Mike Frysinger | 292b45d | 2014-11-25 01:17:10 -0500 | [diff] [blame] | 1135 | return HookFailure('Changelist probably needs a revbump of an ebuild, ' |
| 1136 | 'or a -r1.ebuild symlink if this is a new ebuild:\n' |
| 1137 | '%s' % dir_path) |
Doug Anderson | 42b8a05 | 2013-06-26 10:45:36 -0700 | [diff] [blame] | 1138 | |
| 1139 | return None |
| 1140 | |
| 1141 | |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 1142 | def _check_ebuild_eapi(project, commit): |
Mike Frysinger | 948284a | 2018-02-01 15:22:56 -0500 | [diff] [blame] | 1143 | """Make sure we have people use EAPI=5 or newer with custom ebuilds. |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 1144 | |
| 1145 | We want to get away from older EAPI's as it makes life confusing and they |
| 1146 | have less builtin error checking. |
| 1147 | |
| 1148 | Args: |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 1149 | project: The Project to look at |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 1150 | commit: The commit to look at |
| 1151 | |
| 1152 | Returns: |
| 1153 | A HookFailure or None. |
| 1154 | """ |
| 1155 | # If this is the portage-stable overlay, then ignore the check. It's rare |
Mike Frysinger | cd6adfc | 2014-02-06 01:03:56 -0500 | [diff] [blame] | 1156 | # that we're doing anything other than importing files from upstream, and |
| 1157 | # we shouldn't be rewriting things fundamentally anyways. |
Bob Haarman | 0dc1f94 | 2020-10-03 00:06:59 +0000 | [diff] [blame] | 1158 | allowlist = ( |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 1159 | 'chromiumos/overlays/portage-stable', |
| 1160 | ) |
Bob Haarman | 0dc1f94 | 2020-10-03 00:06:59 +0000 | [diff] [blame] | 1161 | if project.name in allowlist: |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 1162 | return None |
| 1163 | |
Mike Frysinger | 948284a | 2018-02-01 15:22:56 -0500 | [diff] [blame] | 1164 | BAD_EAPIS = ('0', '1', '2', '3', '4') |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 1165 | |
| 1166 | get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)') |
| 1167 | |
| 1168 | ebuilds_re = [r'\.ebuild$'] |
| 1169 | ebuilds = _filter_files(_get_affected_files(commit, relative=True), |
| 1170 | ebuilds_re) |
| 1171 | bad_ebuilds = [] |
| 1172 | |
| 1173 | for ebuild in ebuilds: |
| 1174 | # If the ebuild does not specify an EAPI, it defaults to 0. |
| 1175 | eapi = '0' |
| 1176 | |
| 1177 | lines = _get_file_content(ebuild, commit).splitlines() |
| 1178 | if len(lines) == 1: |
| 1179 | # This is most likely a symlink, so skip it entirely. |
| 1180 | continue |
| 1181 | |
| 1182 | for line in lines: |
| 1183 | m = get_eapi.match(line) |
| 1184 | if m: |
| 1185 | # Once we hit the first EAPI line in this ebuild, stop processing. |
| 1186 | # The spec requires that there only be one and it be first, so |
| 1187 | # checking all possible values is pointless. We also assume that |
| 1188 | # it's "the" EAPI line and not something in the middle of a heredoc. |
| 1189 | eapi = m.group(1) |
| 1190 | break |
| 1191 | |
| 1192 | if eapi in BAD_EAPIS: |
| 1193 | bad_ebuilds.append((ebuild, eapi)) |
| 1194 | |
| 1195 | if bad_ebuilds: |
| 1196 | # pylint: disable=C0301 |
Mike Frysinger | c6114f4 | 2020-05-15 00:55:05 -0400 | [diff] [blame] | 1197 | url = 'https://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis' |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 1198 | # pylint: enable=C0301 |
| 1199 | return HookFailure( |
Mike Frysinger | cd6adfc | 2014-02-06 01:03:56 -0500 | [diff] [blame] | 1200 | 'These ebuilds are using old EAPIs. If these are imported from\n' |
| 1201 | 'Gentoo, then you may ignore and upload once with the --no-verify\n' |
Mike Frysinger | c6114f4 | 2020-05-15 00:55:05 -0400 | [diff] [blame] | 1202 | 'flag. Otherwise, please update to 7 or newer.\n' |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 1203 | '\t%s\n' |
| 1204 | 'See this guide for more details:\n%s\n' % |
| 1205 | ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url)) |
| 1206 | |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1207 | return None |
| 1208 | |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 1209 | |
Mike Frysinger | 89bdb85 | 2014-02-01 05:26:26 -0500 | [diff] [blame] | 1210 | def _check_ebuild_keywords(_project, commit): |
Mike Frysinger | c51ece7 | 2014-01-17 16:23:40 -0500 | [diff] [blame] | 1211 | """Make sure we use the new style KEYWORDS when possible in ebuilds. |
| 1212 | |
| 1213 | If an ebuild generally does not care about the arch it is running on, then |
| 1214 | ebuilds should flag it with one of: |
| 1215 | KEYWORDS="*" # A stable ebuild. |
| 1216 | KEYWORDS="~*" # An unstable ebuild. |
| 1217 | KEYWORDS="-* ..." # Is known to only work on specific arches. |
| 1218 | |
| 1219 | Args: |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 1220 | project: The Project to look at |
Mike Frysinger | c51ece7 | 2014-01-17 16:23:40 -0500 | [diff] [blame] | 1221 | commit: The commit to look at |
| 1222 | |
| 1223 | Returns: |
| 1224 | A HookFailure or None. |
| 1225 | """ |
Bob Haarman | 0dc1f94 | 2020-10-03 00:06:59 +0000 | [diff] [blame] | 1226 | ALLOWLIST = set(('*', '-*', '~*')) |
Mike Frysinger | c51ece7 | 2014-01-17 16:23:40 -0500 | [diff] [blame] | 1227 | |
| 1228 | get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"') |
| 1229 | |
Mike Frysinger | 89bdb85 | 2014-02-01 05:26:26 -0500 | [diff] [blame] | 1230 | ebuilds_re = [r'\.ebuild$'] |
| 1231 | ebuilds = _filter_files(_get_affected_files(commit, relative=True), |
| 1232 | ebuilds_re) |
| 1233 | |
Mike Frysinger | 8d42d74 | 2014-09-22 15:50:21 -0400 | [diff] [blame] | 1234 | bad_ebuilds = [] |
Mike Frysinger | c51ece7 | 2014-01-17 16:23:40 -0500 | [diff] [blame] | 1235 | for ebuild in ebuilds: |
Mike Frysinger | 5c9e58d | 2014-09-09 03:32:50 -0400 | [diff] [blame] | 1236 | # We get the full content rather than a diff as the latter does not work |
| 1237 | # on new files (like when adding new ebuilds). |
| 1238 | lines = _get_file_content(ebuild, commit).splitlines() |
| 1239 | for line in lines: |
Mike Frysinger | c51ece7 | 2014-01-17 16:23:40 -0500 | [diff] [blame] | 1240 | m = get_keywords.match(line) |
| 1241 | if m: |
| 1242 | keywords = set(m.group(1).split()) |
Bob Haarman | 0dc1f94 | 2020-10-03 00:06:59 +0000 | [diff] [blame] | 1243 | if not keywords or ALLOWLIST - keywords != ALLOWLIST: |
Mike Frysinger | c51ece7 | 2014-01-17 16:23:40 -0500 | [diff] [blame] | 1244 | continue |
| 1245 | |
Mike Frysinger | 8d42d74 | 2014-09-22 15:50:21 -0400 | [diff] [blame] | 1246 | bad_ebuilds.append(ebuild) |
| 1247 | |
| 1248 | if bad_ebuilds: |
| 1249 | return HookFailure( |
| 1250 | '%s\n' |
| 1251 | 'Please update KEYWORDS to use a glob:\n' |
| 1252 | 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n' |
| 1253 | ' KEYWORDS="*"\n' |
| 1254 | 'If the ebuild should be marked unstable (normal for ' |
| 1255 | 'cros-workon / 9999 ebuilds):\n' |
| 1256 | ' KEYWORDS="~*"\n' |
Mike Frysinger | de8efea | 2015-05-17 03:42:26 -0400 | [diff] [blame] | 1257 | 'If the ebuild needs to be marked for only specific arches, ' |
Mike Frysinger | 8d42d74 | 2014-09-22 15:50:21 -0400 | [diff] [blame] | 1258 | 'then use -* like so:\n' |
| 1259 | ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds)) |
Mike Frysinger | c51ece7 | 2014-01-17 16:23:40 -0500 | [diff] [blame] | 1260 | |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1261 | return None |
| 1262 | |
Mike Frysinger | c51ece7 | 2014-01-17 16:23:40 -0500 | [diff] [blame] | 1263 | |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 1264 | def _check_ebuild_licenses(_project, commit): |
| 1265 | """Check if the LICENSE field in the ebuild is correct.""" |
Brian Norris | 7a610e8 | 2016-02-17 12:24:54 -0800 | [diff] [blame] | 1266 | affected_paths = _get_affected_files(commit, relative=True) |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 1267 | touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')] |
| 1268 | |
| 1269 | # A list of licenses to ignore for now. |
Yu-Ju Hong | c0963fa | 2014-03-03 12:36:52 -0800 | [diff] [blame] | 1270 | LICENSES_IGNORE = ['||', '(', ')'] |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 1271 | |
| 1272 | for ebuild in touched_ebuilds: |
| 1273 | # Skip virutal packages. |
| 1274 | if ebuild.split('/')[-3] == 'virtual': |
| 1275 | continue |
| 1276 | |
Alex Klein | b595352 | 2018-08-03 11:44:21 -0600 | [diff] [blame] | 1277 | # e.g. path/to/overlay/category/package/package.ebuild -> path/to/overlay |
| 1278 | overlay_path = os.sep.join(ebuild.split(os.sep)[:-3]) |
| 1279 | |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 1280 | try: |
Brian Norris | 7a610e8 | 2016-02-17 12:24:54 -0800 | [diff] [blame] | 1281 | ebuild_content = _get_file_content(ebuild, commit) |
Alex Klein | b595352 | 2018-08-03 11:44:21 -0600 | [diff] [blame] | 1282 | license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content, |
| 1283 | overlay_path) |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 1284 | except ValueError as e: |
Mike Frysinger | f1ee2bf | 2019-09-16 23:47:33 -0400 | [diff] [blame] | 1285 | return HookFailure(str(e), [ebuild]) |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 1286 | |
| 1287 | # Also ignore licenses ending with '?' |
| 1288 | for license_type in [x for x in license_types |
| 1289 | if x not in LICENSES_IGNORE and not x.endswith('?')]: |
| 1290 | try: |
Alex Klein | b595352 | 2018-08-03 11:44:21 -0600 | [diff] [blame] | 1291 | licenses_lib.Licensing.FindLicenseType(license_type, |
| 1292 | overlay_path=overlay_path) |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 1293 | except AssertionError as e: |
Mike Frysinger | f1ee2bf | 2019-09-16 23:47:33 -0400 | [diff] [blame] | 1294 | return HookFailure(str(e), [ebuild]) |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 1295 | |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1296 | return None |
| 1297 | |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 1298 | |
Mike Frysinger | 6ee76b8 | 2020-11-20 01:16:06 -0500 | [diff] [blame] | 1299 | def _check_ebuild_r0(_project, commit): |
| 1300 | """Do not allow ebuilds to end with -r0 versions.""" |
| 1301 | ebuilds = _filter_files( |
| 1302 | _get_affected_files(commit, include_symlinks=True, relative=True), |
| 1303 | (r'-r0\.ebuild$',)) |
| 1304 | if ebuilds: |
| 1305 | return HookFailure( |
| 1306 | 'The -r0 in ebuilds is redundant and confusing. Simply remove it.\n' |
| 1307 | 'For example: git mv foo-1.0-r0.ebuild foo-1.0.ebuild', |
| 1308 | ebuilds) |
| 1309 | |
| 1310 | return None |
| 1311 | |
| 1312 | |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 1313 | def _check_ebuild_virtual_pv(project, commit): |
| 1314 | """Enforce the virtual PV policies.""" |
| 1315 | # If this is the portage-stable overlay, then ignore the check. |
| 1316 | # We want to import virtuals as-is from upstream Gentoo. |
Bob Haarman | 0dc1f94 | 2020-10-03 00:06:59 +0000 | [diff] [blame] | 1317 | allowlist = ( |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 1318 | 'chromiumos/overlays/portage-stable', |
| 1319 | ) |
Bob Haarman | 0dc1f94 | 2020-10-03 00:06:59 +0000 | [diff] [blame] | 1320 | if project.name in allowlist: |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 1321 | return None |
| 1322 | |
| 1323 | # We assume the repo name is the same as the dir name on disk. |
| 1324 | # It would be dumb to not have them match though. |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 1325 | project_base = os.path.basename(project.name) |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 1326 | |
| 1327 | is_variant = lambda x: x.startswith('overlay-variant-') |
| 1328 | is_board = lambda x: x.startswith('overlay-') |
Douglas Anderson | b43df7f | 2018-06-25 13:40:50 -0700 | [diff] [blame] | 1329 | is_baseboard = lambda x: x.startswith('baseboard-') |
| 1330 | is_chipset = lambda x: x.startswith('chipset-') |
| 1331 | is_project = lambda x: x.startswith('project-') |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 1332 | is_private = lambda x: x.endswith('-private') |
| 1333 | |
Douglas Anderson | b43df7f | 2018-06-25 13:40:50 -0700 | [diff] [blame] | 1334 | is_special_overlay = lambda x: (is_board(x) or is_chipset(x) or |
| 1335 | is_baseboard(x) or is_project(x)) |
| 1336 | |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 1337 | get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$') |
| 1338 | |
| 1339 | ebuilds_re = [r'\.ebuild$'] |
| 1340 | ebuilds = _filter_files(_get_affected_files(commit, relative=True), |
| 1341 | ebuilds_re) |
| 1342 | bad_ebuilds = [] |
| 1343 | |
| 1344 | for ebuild in ebuilds: |
| 1345 | m = get_pv.match(ebuild) |
| 1346 | if m: |
| 1347 | overlay = m.group(1) |
Douglas Anderson | b43df7f | 2018-06-25 13:40:50 -0700 | [diff] [blame] | 1348 | if not overlay or not is_special_overlay(overlay): |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 1349 | overlay = project_base |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 1350 | |
| 1351 | pv = m.group(3).split('-', 1)[0] |
| 1352 | |
Bernie Thompson | e5ee182 | 2016-01-12 14:22:23 -0800 | [diff] [blame] | 1353 | # Virtual versions >= 4 are special cases used above the standard |
| 1354 | # versioning structure, e.g. if one has a board inheriting a board. |
Julius Werner | 0299a2b | 2020-07-31 18:20:43 -0700 | [diff] [blame] | 1355 | if pv[0] >= '4': |
Bernie Thompson | e5ee182 | 2016-01-12 14:22:23 -0800 | [diff] [blame] | 1356 | want_pv = pv |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 1357 | elif is_board(overlay): |
Douglas Anderson | b43df7f | 2018-06-25 13:40:50 -0700 | [diff] [blame] | 1358 | if is_private(overlay): |
| 1359 | want_pv = '3.5' if is_variant(overlay) else '3' |
| 1360 | elif is_board(overlay): |
| 1361 | want_pv = '2.5' if is_variant(overlay) else '2' |
| 1362 | elif is_baseboard(overlay): |
Julius Werner | 0299a2b | 2020-07-31 18:20:43 -0700 | [diff] [blame] | 1363 | want_pv = '1.9.5' if is_private(overlay) else '1.9' |
Douglas Anderson | b43df7f | 2018-06-25 13:40:50 -0700 | [diff] [blame] | 1364 | elif is_chipset(overlay): |
Julius Werner | 0299a2b | 2020-07-31 18:20:43 -0700 | [diff] [blame] | 1365 | want_pv = '1.8.5' if is_private(overlay) else '1.8' |
Douglas Anderson | b43df7f | 2018-06-25 13:40:50 -0700 | [diff] [blame] | 1366 | elif is_project(overlay): |
| 1367 | want_pv = '1.7' if is_private(overlay) else '1.5' |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 1368 | else: |
| 1369 | want_pv = '1' |
| 1370 | |
| 1371 | if pv != want_pv: |
| 1372 | bad_ebuilds.append((ebuild, pv, want_pv)) |
| 1373 | |
| 1374 | if bad_ebuilds: |
| 1375 | # pylint: disable=C0301 |
| 1376 | url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management' |
| 1377 | # pylint: enable=C0301 |
| 1378 | return HookFailure( |
| 1379 | 'These virtuals have incorrect package versions (PVs). Please adjust:\n' |
| 1380 | '\t%s\n' |
| 1381 | 'If this is an upstream Gentoo virtual, then you may ignore this\n' |
| 1382 | 'check (and re-run w/--no-verify). Otherwise, please see this\n' |
| 1383 | 'page for more details:\n%s\n' % |
| 1384 | ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x |
| 1385 | for x in bad_ebuilds]), url)) |
| 1386 | |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1387 | return None |
| 1388 | |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 1389 | |
Daniel Erat | 9d203ff | 2015-02-17 10:12:21 -0700 | [diff] [blame] | 1390 | def _check_portage_make_use_var(_project, commit): |
| 1391 | """Verify that $USE is set correctly in make.conf and make.defaults.""" |
| 1392 | files = _filter_files(_get_affected_files(commit, relative=True), |
| 1393 | [r'(^|/)make.(conf|defaults)$']) |
| 1394 | |
| 1395 | errors = [] |
| 1396 | for path in files: |
| 1397 | basename = os.path.basename(path) |
| 1398 | |
| 1399 | # Has a USE= line already been encountered in this file? |
| 1400 | saw_use = False |
| 1401 | |
| 1402 | for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1): |
| 1403 | if not line.startswith('USE='): |
| 1404 | continue |
| 1405 | |
| 1406 | preserves_use = '${USE}' in line or '$USE' in line |
| 1407 | |
| 1408 | if (basename == 'make.conf' or |
| 1409 | (basename == 'make.defaults' and saw_use)) and not preserves_use: |
| 1410 | errors.append('%s:%d: missing ${USE}' % (path, i)) |
| 1411 | elif basename == 'make.defaults' and not saw_use and preserves_use: |
| 1412 | errors.append('%s:%d: ${USE} referenced in initial declaration' % |
| 1413 | (path, i)) |
| 1414 | |
| 1415 | saw_use = True |
| 1416 | |
| 1417 | if errors: |
| 1418 | return HookFailure( |
| 1419 | 'One or more Portage make files appear to set USE incorrectly.\n' |
| 1420 | '\n' |
| 1421 | 'All USE assignments in make.conf and all assignments after the\n' |
| 1422 | 'initial declaration in make.defaults should contain "${USE}" to\n' |
| 1423 | 'preserve previously-set flags.\n' |
| 1424 | '\n' |
| 1425 | 'The initial USE declaration in make.defaults should not contain\n' |
| 1426 | '"${USE}".\n', |
| 1427 | errors) |
| 1428 | |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1429 | return None |
| 1430 | |
Daniel Erat | 9d203ff | 2015-02-17 10:12:21 -0700 | [diff] [blame] | 1431 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 1432 | def _check_change_has_proper_changeid(_project, commit): |
Mandeep Singh Baines | a23eb5f | 2011-05-04 13:43:25 -0700 | [diff] [blame] | 1433 | """Verify that Change-ID is present in last paragraph of commit message.""" |
Mike Frysinger | 4a22bf0 | 2014-10-31 13:53:35 -0400 | [diff] [blame] | 1434 | CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n' |
Mandeep Singh Baines | a23eb5f | 2011-05-04 13:43:25 -0700 | [diff] [blame] | 1435 | desc = _get_commit_desc(commit) |
Mike Frysinger | 4a22bf0 | 2014-10-31 13:53:35 -0400 | [diff] [blame] | 1436 | m = re.search(CHANGE_ID_RE, desc) |
Mike Frysinger | 02b88bd | 2014-11-21 00:29:38 -0500 | [diff] [blame] | 1437 | if not m: |
Vadim Bendebury | 20532ba | 2017-05-23 17:26:15 -0700 | [diff] [blame] | 1438 | return HookFailure('Last paragraph of description must include Change-Id.') |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 1439 | |
LaMont Jones | fb5e8bf | 2020-03-03 12:50:06 -0700 | [diff] [blame] | 1440 | # S-o-b and some other tags always allowed to follow Change-ID in the footer. |
| 1441 | allowed_tags = ['Signed-off-by', 'Cq-Cl-Tag', 'Cq-Include-Trybots'] |
Vadim Bendebury | 20532ba | 2017-05-23 17:26:15 -0700 | [diff] [blame] | 1442 | |
Mike Frysinger | 02b88bd | 2014-11-21 00:29:38 -0500 | [diff] [blame] | 1443 | end = desc[m.end():].strip().splitlines() |
Vadim Bendebury | 6504aea | 2017-09-13 18:35:49 -0700 | [diff] [blame] | 1444 | cherry_pick_marker = 'cherry picked from commit' |
| 1445 | |
| 1446 | if end and cherry_pick_marker in end[-1]: |
Vadim Bendebury | 20532ba | 2017-05-23 17:26:15 -0700 | [diff] [blame] | 1447 | # Cherry picked patches allow more tags in the last paragraph. |
Vadim Bendebury | 6504aea | 2017-09-13 18:35:49 -0700 | [diff] [blame] | 1448 | allowed_tags += ['Commit-Queue', 'Commit-Ready', 'Reviewed-by', |
| 1449 | 'Reviewed-on', 'Tested-by'] |
Vadim Bendebury | 20532ba | 2017-05-23 17:26:15 -0700 | [diff] [blame] | 1450 | end = end[:-1] |
| 1451 | |
Vadim Bendebury | 6504aea | 2017-09-13 18:35:49 -0700 | [diff] [blame] | 1452 | # Note that descriptions could have multiple cherry pick markers. |
| 1453 | tag_search = r'^(%s:|\(%s) ' % (':|'.join(allowed_tags), cherry_pick_marker) |
Vadim Bendebury | 20532ba | 2017-05-23 17:26:15 -0700 | [diff] [blame] | 1454 | |
| 1455 | if [x for x in end if not re.search(tag_search, x)]: |
| 1456 | return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' % |
| 1457 | ':", "'.join(allowed_tags)) |
Mike Frysinger | 02b88bd | 2014-11-21 00:29:38 -0500 | [diff] [blame] | 1458 | |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1459 | return None |
| 1460 | |
Mandeep Singh Baines | a23eb5f | 2011-05-04 13:43:25 -0700 | [diff] [blame] | 1461 | |
Mike Frysinger | 36b2ebc | 2014-10-31 14:02:03 -0400 | [diff] [blame] | 1462 | def _check_commit_message_style(_project, commit): |
| 1463 | """Verify that the commit message matches our style. |
| 1464 | |
| 1465 | We do not check for BUG=/TEST=/etc... lines here as that is handled by other |
| 1466 | commit hooks. |
| 1467 | """ |
Mike Frysinger | ed9b2a0 | 2019-12-12 18:52:32 -0500 | [diff] [blame] | 1468 | SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,) |
Mike Frysinger | 4efdee7 | 2019-11-04 10:57:01 -0500 | [diff] [blame] | 1469 | |
Mike Frysinger | 36b2ebc | 2014-10-31 14:02:03 -0400 | [diff] [blame] | 1470 | desc = _get_commit_desc(commit) |
| 1471 | |
| 1472 | # The first line should be by itself. |
| 1473 | lines = desc.splitlines() |
| 1474 | if len(lines) > 1 and lines[1]: |
Mike Frysinger | 4efdee7 | 2019-11-04 10:57:01 -0500 | [diff] [blame] | 1475 | return HookFailure('The second line of the commit message must be blank.' |
| 1476 | '\n%s' % (SEE_ALSO,)) |
Mike Frysinger | 36b2ebc | 2014-10-31 14:02:03 -0400 | [diff] [blame] | 1477 | |
| 1478 | # The first line should be one sentence. |
| 1479 | if '. ' in lines[0]: |
Mike Frysinger | 4efdee7 | 2019-11-04 10:57:01 -0500 | [diff] [blame] | 1480 | return HookFailure('The first line cannot be more than one sentence.\n%s' % |
| 1481 | (SEE_ALSO,)) |
Mike Frysinger | 36b2ebc | 2014-10-31 14:02:03 -0400 | [diff] [blame] | 1482 | |
| 1483 | # The first line cannot be too long. |
| 1484 | MAX_FIRST_LINE_LEN = 100 |
| 1485 | if len(lines[0]) > MAX_FIRST_LINE_LEN: |
Mike Frysinger | 4efdee7 | 2019-11-04 10:57:01 -0500 | [diff] [blame] | 1486 | return HookFailure('The first line must be less than %i chars.\n%s' % |
| 1487 | (MAX_FIRST_LINE_LEN, SEE_ALSO)) |
Mike Frysinger | 36b2ebc | 2014-10-31 14:02:03 -0400 | [diff] [blame] | 1488 | |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1489 | return None |
| 1490 | |
Mike Frysinger | 36b2ebc | 2014-10-31 14:02:03 -0400 | [diff] [blame] | 1491 | |
Filipe Brandenburger | 4b542b1 | 2015-10-09 12:46:31 -0700 | [diff] [blame] | 1492 | def _check_cros_license(_project, commit, options=()): |
Alex Deymo | f5792ce | 2015-08-24 22:50:08 -0700 | [diff] [blame] | 1493 | """Verifies the Chromium OS license/copyright header. |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 1494 | |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1495 | Should be following the spec: |
| 1496 | http://dev.chromium.org/developers/coding-style#TOC-File-headers |
| 1497 | """ |
| 1498 | # For older years, be a bit more flexible as our policy says leave them be. |
| 1499 | LICENSE_HEADER = ( |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 1500 | r'.*Copyright(?: \(c\))? (20[0-9]{2})(?:-20[0-9]{2})? The Chromium OS ' |
| 1501 | r'Authors\. All rights reserved\.\n' |
Brian Norris | 68838dd | 2018-09-26 18:30:24 -0700 | [diff] [blame] | 1502 | r'.*Use of this source code is governed by a BSD-style license that can ' |
Mike Frysinger | b81102f | 2014-11-21 00:33:35 -0500 | [diff] [blame] | 1503 | r'be\n' |
Brian Norris | 68838dd | 2018-09-26 18:30:24 -0700 | [diff] [blame] | 1504 | r'.*found in the LICENSE file\.' |
Mike Frysinger | b81102f | 2014-11-21 00:33:35 -0500 | [diff] [blame] | 1505 | r'\n' |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1506 | ) |
| 1507 | license_re = re.compile(LICENSE_HEADER, re.MULTILINE) |
| 1508 | |
| 1509 | # For newer years, be stricter. |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 1510 | BAD_COPYRIGHT_LINE = ( |
Brian Norris | 68838dd | 2018-09-26 18:30:24 -0700 | [diff] [blame] | 1511 | r'.*Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. ' |
Mike Frysinger | b81102f | 2014-11-21 00:33:35 -0500 | [diff] [blame] | 1512 | r'All rights reserved\.' r'\n' |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1513 | ) |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 1514 | bad_copyright_re = re.compile(BAD_COPYRIGHT_LINE) |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1515 | |
Shuhei Takahashi | abc20f3 | 2017-07-10 19:35:45 +0900 | [diff] [blame] | 1516 | included, excluded = _parse_common_inclusion_options(options) |
Filipe Brandenburger | 4b542b1 | 2015-10-09 12:46:31 -0700 | [diff] [blame] | 1517 | |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1518 | bad_files = [] |
| 1519 | bad_copyright_files = [] |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 1520 | bad_year_files = [] |
| 1521 | |
Ken Turner | d07564b | 2018-02-08 17:57:59 +1100 | [diff] [blame] | 1522 | files = _filter_files( |
| 1523 | _get_affected_files(commit, relative=True), |
| 1524 | included + COMMON_INCLUDED_PATHS, |
| 1525 | excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS) |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 1526 | existing_files = set(_get_affected_files(commit, relative=True, |
| 1527 | include_adds=False)) |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1528 | |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 1529 | current_year = str(datetime.datetime.now().year) |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1530 | for f in files: |
| 1531 | contents = _get_file_content(f, commit) |
| 1532 | if not contents: |
| 1533 | # Ignore empty files. |
| 1534 | continue |
| 1535 | |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 1536 | m = license_re.search(contents) |
| 1537 | if not m: |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1538 | bad_files.append(f) |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 1539 | elif bad_copyright_re.search(contents): |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1540 | bad_copyright_files.append(f) |
| 1541 | |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 1542 | if m and f not in existing_files: |
| 1543 | year = m.group(1) |
| 1544 | if year != current_year: |
| 1545 | bad_year_files.append(f) |
| 1546 | |
| 1547 | errors = [] |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1548 | if bad_files: |
| 1549 | msg = '%s:\n%s\n%s' % ( |
| 1550 | 'License must match', license_re.pattern, |
| 1551 | 'Found a bad header in these files:') |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 1552 | errors.append(HookFailure(msg, bad_files)) |
Mike Frysinger | 9863810 | 2014-08-28 00:15:08 -0400 | [diff] [blame] | 1553 | if bad_copyright_files: |
| 1554 | msg = 'Do not use (c) in copyright headers in new files:' |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 1555 | errors.append(HookFailure(msg, bad_copyright_files)) |
| 1556 | if bad_year_files: |
| 1557 | msg = 'Use current year (%s) in copyright headers in new files:' % ( |
| 1558 | current_year) |
| 1559 | errors.append(HookFailure(msg, bad_year_files)) |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 1560 | |
Keigo Oka | 7e880ac | 2019-07-03 15:03:43 +0900 | [diff] [blame] | 1561 | return errors |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 1562 | |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1563 | |
Amin Hassani | 391efa9 | 2018-01-26 17:58:05 -0800 | [diff] [blame] | 1564 | def _check_aosp_license(_project, commit, options=()): |
Alex Deymo | f5792ce | 2015-08-24 22:50:08 -0700 | [diff] [blame] | 1565 | """Verifies the AOSP license/copyright header. |
| 1566 | |
| 1567 | AOSP uses the Apache2 License: |
| 1568 | https://source.android.com/source/licenses.html |
| 1569 | """ |
| 1570 | LICENSE_HEADER = ( |
| 1571 | r"""^[#/\*]* |
| 1572 | [#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project |
| 1573 | [#/\*]* ? |
| 1574 | [#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\); |
| 1575 | [#/\*]* ?you may not use this file except in compliance with the License\. |
| 1576 | [#/\*]* ?You may obtain a copy of the License at |
| 1577 | [#/\*]* ? |
| 1578 | [#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0 |
| 1579 | [#/\*]* ? |
| 1580 | [#/\*]* ?Unless required by applicable law or agreed to in writing, software |
| 1581 | [#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS, |
| 1582 | [#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """ |
| 1583 | r"""implied\. |
| 1584 | [#/\*]* ?See the License for the specific language governing permissions and |
| 1585 | [#/\*]* ?limitations under the License\. |
| 1586 | [#/\*]*$ |
| 1587 | """ |
| 1588 | ) |
| 1589 | license_re = re.compile(LICENSE_HEADER, re.MULTILINE) |
| 1590 | |
Amin Hassani | 391efa9 | 2018-01-26 17:58:05 -0800 | [diff] [blame] | 1591 | included, excluded = _parse_common_inclusion_options(options) |
| 1592 | |
Ken Turner | d07564b | 2018-02-08 17:57:59 +1100 | [diff] [blame] | 1593 | files = _filter_files( |
| 1594 | _get_affected_files(commit, relative=True), |
| 1595 | included + COMMON_INCLUDED_PATHS, |
| 1596 | excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS) |
Alex Deymo | f5792ce | 2015-08-24 22:50:08 -0700 | [diff] [blame] | 1597 | |
| 1598 | bad_files = [] |
| 1599 | for f in files: |
| 1600 | contents = _get_file_content(f, commit) |
| 1601 | if not contents: |
| 1602 | # Ignore empty files. |
| 1603 | continue |
| 1604 | |
| 1605 | if not license_re.search(contents): |
| 1606 | bad_files.append(f) |
| 1607 | |
| 1608 | if bad_files: |
| 1609 | msg = ('License must match:\n%s\nFound a bad header in these files:' % |
| 1610 | license_re.pattern) |
| 1611 | return HookFailure(msg, bad_files) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1612 | return None |
Alex Deymo | f5792ce | 2015-08-24 22:50:08 -0700 | [diff] [blame] | 1613 | |
| 1614 | |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1615 | def _check_layout_conf(_project, commit): |
| 1616 | """Verifies the metadata/layout.conf file.""" |
| 1617 | repo_name = 'profiles/repo_name' |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1618 | repo_names = [] |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1619 | layout_path = 'metadata/layout.conf' |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1620 | layout_paths = [] |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1621 | |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1622 | # Handle multiple overlays in a single commit (like the public tree). |
| 1623 | for f in _get_affected_files(commit, relative=True): |
| 1624 | if f.endswith(repo_name): |
| 1625 | repo_names.append(f) |
| 1626 | elif f.endswith(layout_path): |
| 1627 | layout_paths.append(f) |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1628 | |
| 1629 | # Disallow new repos with the repo_name file. |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1630 | if repo_names: |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1631 | return HookFailure('%s: use "repo-name" in %s instead' % |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1632 | (repo_names, layout_path)) |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1633 | |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1634 | # Gather all the errors in one pass so we show one full message. |
| 1635 | all_errors = {} |
| 1636 | for layout_path in layout_paths: |
| 1637 | all_errors[layout_path] = errors = [] |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1638 | |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1639 | # Make sure the config file is sorted. |
| 1640 | data = [x for x in _get_file_content(layout_path, commit).splitlines() |
| 1641 | if x and x[0] != '#'] |
| 1642 | if sorted(data) != data: |
| 1643 | errors += ['keep lines sorted'] |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1644 | |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1645 | # Require people to set specific values all the time. |
| 1646 | settings = ( |
| 1647 | # TODO: Enable this for everyone. http://crbug.com/408038 |
Shuhei Takahashi | 3cbb8dd | 2019-10-29 12:37:11 +0900 | [diff] [blame] | 1648 | # ('fast caching', 'cache-format = md5-dict'), |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1649 | ('fast manifests', 'thin-manifests = true'), |
Mike Frysinger | d773452 | 2015-02-26 16:12:43 -0500 | [diff] [blame] | 1650 | ('extra features', 'profile-formats = portage-2 profile-default-eapi'), |
| 1651 | ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'), |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1652 | ) |
| 1653 | for reason, line in settings: |
| 1654 | if line not in data: |
| 1655 | errors += ['enable %s with: %s' % (reason, line)] |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1656 | |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1657 | # Require one of these settings. |
Mike Frysinger | 5fae62d | 2015-11-11 20:12:15 -0500 | [diff] [blame] | 1658 | if 'use-manifests = strict' not in data: |
| 1659 | errors += ['enable file checking with: use-manifests = strict'] |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1660 | |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1661 | # Require repo-name to be set. |
Mike Frysinger | 324cf68 | 2014-09-22 15:52:50 -0400 | [diff] [blame] | 1662 | for line in data: |
| 1663 | if line.startswith('repo-name = '): |
| 1664 | break |
| 1665 | else: |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1666 | errors += ['set the board name with: repo-name = $BOARD'] |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1667 | |
Mike Frysinger | 94a670c | 2014-09-19 12:46:26 -0400 | [diff] [blame] | 1668 | # Summarize all the errors we saw (if any). |
| 1669 | lines = '' |
| 1670 | for layout_path, errors in all_errors.items(): |
| 1671 | if errors: |
| 1672 | lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors) |
| 1673 | if lines: |
| 1674 | lines = 'See the portage(5) man page for layout.conf details' + lines + '\n' |
| 1675 | return HookFailure(lines) |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1676 | |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1677 | return None |
| 1678 | |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 1679 | |
Keigo Oka | 4a09bd9 | 2019-05-07 14:01:00 +0900 | [diff] [blame] | 1680 | def _check_no_new_gyp(_project, commit): |
| 1681 | """Verifies no project starts to use GYP.""" |
Keigo Oka | 4a09bd9 | 2019-05-07 14:01:00 +0900 | [diff] [blame] | 1682 | gypfiles = _filter_files( |
| 1683 | _get_affected_files(commit, include_symlinks=True, relative=True), |
| 1684 | [r'\.gyp$']) |
| 1685 | |
| 1686 | if gypfiles: |
| 1687 | return HookFailure('GYP is deprecated and not allowed in a new project:', |
| 1688 | gypfiles) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1689 | return None |
Keigo Oka | 4a09bd9 | 2019-05-07 14:01:00 +0900 | [diff] [blame] | 1690 | |
| 1691 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 1692 | # Project-specific hooks |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 1693 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 1694 | |
Luis Hector Chavez | b50391d | 2017-09-26 15:48:15 -0700 | [diff] [blame] | 1695 | def _check_clang_format(_project, commit, options=()): |
| 1696 | """Runs clang-format on the given project""" |
| 1697 | hooks_dir = _get_hooks_dir() |
| 1698 | options = list(options) |
| 1699 | if commit == PRE_SUBMIT: |
| 1700 | options.append('--commit=HEAD') |
| 1701 | else: |
| 1702 | options.extend(['--commit', commit]) |
Brian Norris | 0c62a14 | 2018-12-11 13:24:29 -0800 | [diff] [blame] | 1703 | cmd = [os.path.join(hooks_dir, 'clang-format.py')] + options |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 1704 | cmd_result = cros_build_lib.run(cmd, |
| 1705 | print_cmd=False, |
| 1706 | stdout=True, |
| 1707 | encoding='utf-8', |
| 1708 | errors='replace', |
Mike Frysinger | d0c5c8b | 2019-12-17 02:28:26 -0500 | [diff] [blame] | 1709 | stderr=subprocess.STDOUT, |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 1710 | check=False) |
Luis Hector Chavez | b50391d | 2017-09-26 15:48:15 -0700 | [diff] [blame] | 1711 | if cmd_result.returncode: |
| 1712 | return HookFailure('clang-format.py errors/warnings\n\n' + |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 1713 | cmd_result.stdout) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1714 | return None |
Luis Hector Chavez | b50391d | 2017-09-26 15:48:15 -0700 | [diff] [blame] | 1715 | |
| 1716 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 1717 | def _run_checkpatch(_project, commit, options=()): |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 1718 | """Runs checkpatch.pl on the given project""" |
Tomasz Figa | bd8faf6 | 2020-09-22 14:06:05 +0000 | [diff] [blame] | 1719 | # Bypass checkpatch for upstream or almost upstream commits, since we do not |
| 1720 | # intend to modify the upstream commits when landing them to our branches. |
| 1721 | # Any fixes should sent as independent patches. |
| 1722 | # The check is retained for FROMLIST and BACKPORT commits, as by definition |
| 1723 | # those can be still fixed up. |
| 1724 | desc = _get_commit_desc(commit) |
| 1725 | if desc.startswith('UPSTREAM:') or desc.startswith('FROMGIT:'): |
| 1726 | return None |
| 1727 | |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 1728 | hooks_dir = _get_hooks_dir() |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1729 | options = list(options) |
Brian Norris | 4cee050 | 2020-06-12 17:02:56 -0700 | [diff] [blame] | 1730 | if options and options[0].startswith('./') and os.path.exists(options[0]): |
| 1731 | cmdpath = options.pop(0) |
| 1732 | else: |
| 1733 | cmdpath = os.path.join(hooks_dir, 'checkpatch.pl') |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1734 | if commit == PRE_SUBMIT: |
| 1735 | # The --ignore option must be present and include 'MISSING_SIGN_OFF' in |
| 1736 | # this case. |
| 1737 | options.append('--ignore=MISSING_SIGN_OFF') |
Filipe Brandenburger | 28d48d6 | 2015-10-07 09:48:54 -0700 | [diff] [blame] | 1738 | # Always ignore the check for the MAINTAINERS file. We do not track that |
| 1739 | # information on that file in our source trees, so let's suppress the |
| 1740 | # warning. |
| 1741 | options.append('--ignore=FILE_PATH_CHANGES') |
Filipe Brandenburger | ce97832 | 2015-10-09 10:04:15 -0700 | [diff] [blame] | 1742 | # Do not complain about the Change-Id: fields, since we use Gerrit. |
| 1743 | # Upstream does not want those lines (since they do not use Gerrit), but |
| 1744 | # we always do, so disable the check globally. |
Daisuke Nojiri | 4844f89 | 2015-10-08 09:54:33 -0700 | [diff] [blame] | 1745 | options.append('--ignore=GERRIT_CHANGE_ID') |
Brian Norris | 4cee050 | 2020-06-12 17:02:56 -0700 | [diff] [blame] | 1746 | cmd = [cmdpath] + options + ['-'] |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 1747 | cmd_result = cros_build_lib.run( |
| 1748 | cmd, print_cmd=False, input=_get_patch(commit).encode('utf-8'), |
Mike Frysinger | d0c5c8b | 2019-12-17 02:28:26 -0500 | [diff] [blame] | 1749 | stdout=True, stderr=subprocess.STDOUT, check=False, encoding='utf-8', |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 1750 | errors='replace') |
Rahul Chaudhry | 0e51534 | 2015-08-07 12:00:43 -0700 | [diff] [blame] | 1751 | if cmd_result.returncode: |
Brian Norris | 4cee050 | 2020-06-12 17:02:56 -0700 | [diff] [blame] | 1752 | return HookFailure('%s errors/warnings\n\n%s' % |
| 1753 | (cmdpath, cmd_result.stdout)) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1754 | return None |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 1755 | |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 1756 | |
Brian Norris | 23c62e9 | 2018-11-14 12:25:51 -0800 | [diff] [blame] | 1757 | def _run_kerneldoc(_project, commit, options=()): |
| 1758 | """Runs kernel-doc validator on the given project""" |
| 1759 | included, excluded = _parse_common_inclusion_options(options) |
| 1760 | files = _filter_files(_get_affected_files(commit, relative=True), |
| 1761 | included, excluded) |
| 1762 | if files: |
| 1763 | hooks_dir = _get_hooks_dir() |
Brian Norris | 0c62a14 | 2018-12-11 13:24:29 -0800 | [diff] [blame] | 1764 | cmd = [os.path.join(hooks_dir, 'kernel-doc'), '-none'] + files |
Mike Frysinger | d0c5c8b | 2019-12-17 02:28:26 -0500 | [diff] [blame] | 1765 | output = _run_command(cmd, stderr=subprocess.STDOUT) |
Brian Norris | 23c62e9 | 2018-11-14 12:25:51 -0800 | [diff] [blame] | 1766 | if output: |
Brian Norris | 0c62a14 | 2018-12-11 13:24:29 -0800 | [diff] [blame] | 1767 | return HookFailure('kernel-doc errors/warnings:', |
| 1768 | items=output.splitlines()) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1769 | return None |
Brian Norris | 23c62e9 | 2018-11-14 12:25:51 -0800 | [diff] [blame] | 1770 | |
| 1771 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 1772 | def _kernel_configcheck(_project, commit): |
Olof Johansson | a96810f | 2012-09-04 16:20:03 -0700 | [diff] [blame] | 1773 | """Makes sure kernel config changes are not mixed with code changes""" |
| 1774 | files = _get_affected_files(commit) |
Mike Frysinger | f252cfc | 2019-12-09 17:34:28 -0500 | [diff] [blame] | 1775 | if len(_filter_files(files, [r'chromeos/config'])) not in [0, len(files)]: |
Olof Johansson | a96810f | 2012-09-04 16:20:03 -0700 | [diff] [blame] | 1776 | return HookFailure('Changes to chromeos/config/ and regular files must ' |
| 1777 | 'be in separate commits:\n%s' % '\n'.join(files)) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1778 | return None |
Anton Staaf | 815d685 | 2011-08-22 10:08:45 -0700 | [diff] [blame] | 1779 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 1780 | |
| 1781 | def _run_json_check(_project, commit): |
Dale Curtis | 2975c43 | 2011-05-03 17:25:20 -0700 | [diff] [blame] | 1782 | """Checks that all JSON files are syntactically valid.""" |
Mike Frysinger | 908be68 | 2018-01-04 02:21:50 -0500 | [diff] [blame] | 1783 | ret = [] |
| 1784 | |
| 1785 | files = _filter_files(_get_affected_files(commit, relative=True), |
| 1786 | [r'.*\.json$']) |
| 1787 | for f in files: |
| 1788 | data = _get_file_content(f, commit) |
Dale Curtis | 2975c43 | 2011-05-03 17:25:20 -0700 | [diff] [blame] | 1789 | try: |
Mike Frysinger | 908be68 | 2018-01-04 02:21:50 -0500 | [diff] [blame] | 1790 | json.loads(data) |
| 1791 | except Exception as e: |
| 1792 | ret.append('%s: Invalid JSON: %s' % (f, e)) |
| 1793 | |
| 1794 | if ret: |
| 1795 | return HookFailure('\n'.join(ret)) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1796 | return None |
Dale Curtis | 2975c43 | 2011-05-03 17:25:20 -0700 | [diff] [blame] | 1797 | |
| 1798 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 1799 | def _check_manifests(_project, commit): |
Mike Frysinger | aae3cb5 | 2018-01-03 16:49:33 -0500 | [diff] [blame] | 1800 | """Make sure Manifest files only have comments & DIST lines.""" |
| 1801 | ret = [] |
Mike Frysinger | 52b537e | 2013-08-22 22:59:53 -0400 | [diff] [blame] | 1802 | |
Mike Frysinger | aae3cb5 | 2018-01-03 16:49:33 -0500 | [diff] [blame] | 1803 | manifests = _filter_files(_get_affected_files(commit, relative=True), |
| 1804 | [r'.*/Manifest$']) |
| 1805 | for path in manifests: |
| 1806 | data = _get_file_content(path, commit) |
| 1807 | |
| 1808 | # Disallow blank files. |
| 1809 | if not data.strip(): |
| 1810 | ret.append('%s: delete empty file' % (path,)) |
Mike Frysinger | 52b537e | 2013-08-22 22:59:53 -0400 | [diff] [blame] | 1811 | continue |
| 1812 | |
Mike Frysinger | aae3cb5 | 2018-01-03 16:49:33 -0500 | [diff] [blame] | 1813 | # Make sure the last newline isn't omitted. |
| 1814 | if data[-1] != '\n': |
| 1815 | ret.append('%s: missing trailing newline' % (path,)) |
Mike Frysinger | 52b537e | 2013-08-22 22:59:53 -0400 | [diff] [blame] | 1816 | |
Mike Frysinger | aae3cb5 | 2018-01-03 16:49:33 -0500 | [diff] [blame] | 1817 | # Do not allow leading or trailing blank lines. |
| 1818 | lines = data.splitlines() |
| 1819 | if not lines[0]: |
| 1820 | ret.append('%s: delete leading blank lines' % (path,)) |
| 1821 | if not lines[-1]: |
| 1822 | ret.append('%s: delete trailing blank lines' % (path,)) |
| 1823 | |
| 1824 | for line in lines: |
| 1825 | # Disallow leading/trailing whitespace. |
| 1826 | if line != line.strip(): |
| 1827 | ret.append('%s: remove leading/trailing whitespace: %s' % (path, line)) |
| 1828 | |
| 1829 | # Allow blank lines & comments. |
| 1830 | line = line.split('#', 1)[0] |
| 1831 | if not line: |
| 1832 | continue |
| 1833 | |
| 1834 | # All other linse should start with DIST. |
| 1835 | if not line.startswith('DIST '): |
| 1836 | ret.append('%s: remove non-DIST lines: %s' % (path, line)) |
| 1837 | break |
| 1838 | |
| 1839 | if ret: |
| 1840 | return HookFailure('\n'.join(ret)) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1841 | return None |
Mike Frysinger | 52b537e | 2013-08-22 22:59:53 -0400 | [diff] [blame] | 1842 | |
| 1843 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 1844 | def _check_change_has_branch_field(_project, commit): |
Puneet Kumar | c80e3f6 | 2012-08-13 19:01:18 -0700 | [diff] [blame] | 1845 | """Check for a non-empty 'BRANCH=' field in the commit message.""" |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1846 | if commit == PRE_SUBMIT: |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1847 | return None |
Puneet Kumar | c80e3f6 | 2012-08-13 19:01:18 -0700 | [diff] [blame] | 1848 | BRANCH_RE = r'\nBRANCH=\S+' |
| 1849 | |
| 1850 | if not re.search(BRANCH_RE, _get_commit_desc(commit)): |
| 1851 | msg = ('Changelist description needs BRANCH field (after first line)\n' |
| 1852 | 'E.g. BRANCH=none or BRANCH=link,snow') |
| 1853 | return HookFailure(msg) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1854 | return None |
Puneet Kumar | c80e3f6 | 2012-08-13 19:01:18 -0700 | [diff] [blame] | 1855 | |
| 1856 | |
Mike Frysinger | 45334bd | 2019-11-04 10:42:33 -0500 | [diff] [blame] | 1857 | def _check_change_has_no_branch_field(_project, commit): |
| 1858 | """Verify 'BRANCH=' field does not exist in the commit message.""" |
| 1859 | if commit == PRE_SUBMIT: |
| 1860 | return None |
| 1861 | BRANCH_RE = r'\nBRANCH=\S+' |
| 1862 | |
| 1863 | if re.search(BRANCH_RE, _get_commit_desc(commit)): |
| 1864 | msg = 'This checkout does not use BRANCH= fields. Delete them.' |
| 1865 | return HookFailure(msg) |
| 1866 | return None |
| 1867 | |
| 1868 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 1869 | def _check_change_has_signoff_field(_project, commit): |
Shawn Nematbakhsh | 51e16ac | 2014-01-28 15:31:07 -0800 | [diff] [blame] | 1870 | """Check for a non-empty 'Signed-off-by:' field in the commit message.""" |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 1871 | if commit == PRE_SUBMIT: |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1872 | return None |
Shawn Nematbakhsh | 51e16ac | 2014-01-28 15:31:07 -0800 | [diff] [blame] | 1873 | SIGNOFF_RE = r'\nSigned-off-by: \S+' |
| 1874 | |
| 1875 | if not re.search(SIGNOFF_RE, _get_commit_desc(commit)): |
| 1876 | msg = ('Changelist description needs Signed-off-by: field\n' |
| 1877 | 'E.g. Signed-off-by: My Name <me@chromium.org>') |
| 1878 | return HookFailure(msg) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1879 | return None |
Shawn Nematbakhsh | 51e16ac | 2014-01-28 15:31:07 -0800 | [diff] [blame] | 1880 | |
| 1881 | |
Mike Frysinger | 9ab64b1 | 2019-11-04 10:53:08 -0500 | [diff] [blame] | 1882 | def _check_change_has_no_signoff_field(_project, commit): |
| 1883 | """Verify 'Signed-off-by:' field does not exist in the commit message.""" |
| 1884 | if commit == PRE_SUBMIT: |
| 1885 | return None |
| 1886 | SIGNOFF_RE = r'\nSigned-off-by: \S+' |
| 1887 | |
| 1888 | if re.search(SIGNOFF_RE, _get_commit_desc(commit)): |
| 1889 | msg = 'This checkout does not use Signed-off-by: tags. Delete them.' |
| 1890 | return HookFailure(msg) |
| 1891 | return None |
| 1892 | |
| 1893 | |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 1894 | def _run_project_hook_script(script, project, commit): |
| 1895 | """Runs a project hook script. |
| 1896 | |
| 1897 | The script is run with the following environment variables set: |
| 1898 | PRESUBMIT_PROJECT: The affected project |
| 1899 | PRESUBMIT_COMMIT: The affected commit |
| 1900 | PRESUBMIT_FILES: A newline-separated list of affected files |
| 1901 | |
| 1902 | The script is considered to fail if the exit code is non-zero. It should |
| 1903 | write an error message to stdout. |
| 1904 | """ |
| 1905 | env = dict(os.environ) |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 1906 | env['PRESUBMIT_PROJECT'] = project.name |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 1907 | env['PRESUBMIT_COMMIT'] = commit |
| 1908 | |
| 1909 | # Put affected files in an environment variable |
| 1910 | files = _get_affected_files(commit) |
| 1911 | env['PRESUBMIT_FILES'] = '\n'.join(files) |
| 1912 | |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 1913 | cmd_result = cros_build_lib.run(cmd=script, |
| 1914 | env=env, |
| 1915 | shell=True, |
| 1916 | print_cmd=False, |
| 1917 | input=os.devnull, |
| 1918 | stdout=True, |
| 1919 | encoding='utf-8', |
| 1920 | errors='replace', |
Mike Frysinger | d0c5c8b | 2019-12-17 02:28:26 -0500 | [diff] [blame] | 1921 | stderr=subprocess.STDOUT, |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 1922 | check=False) |
Rahul Chaudhry | 0e51534 | 2015-08-07 12:00:43 -0700 | [diff] [blame] | 1923 | if cmd_result.returncode: |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 1924 | stdout = cmd_result.stdout |
Jon Salz | 7b618af | 2012-08-31 06:03:16 +0800 | [diff] [blame] | 1925 | if stdout: |
| 1926 | stdout = re.sub('(?m)^', ' ', stdout) |
| 1927 | return HookFailure('Hook script "%s" failed with code %d%s' % |
Rahul Chaudhry | 0e51534 | 2015-08-07 12:00:43 -0700 | [diff] [blame] | 1928 | (script, cmd_result.returncode, |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 1929 | ':\n' + stdout if stdout else '')) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1930 | return None |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 1931 | |
| 1932 | |
Bertrand SIMONNET | 0022fff | 2014-07-07 09:52:15 -0700 | [diff] [blame] | 1933 | def _check_project_prefix(_project, commit): |
Mike Frysinger | 55f85b5 | 2014-12-18 14:45:21 -0500 | [diff] [blame] | 1934 | """Require the commit message have a project specific prefix as needed.""" |
Bertrand SIMONNET | 0022fff | 2014-07-07 09:52:15 -0700 | [diff] [blame] | 1935 | |
Brian Norris | 77608e1 | 2018-04-06 10:38:43 -0700 | [diff] [blame] | 1936 | files = _get_affected_files(commit, include_deletes=True, relative=True) |
Bertrand SIMONNET | 0022fff | 2014-07-07 09:52:15 -0700 | [diff] [blame] | 1937 | prefix = os.path.commonprefix(files) |
| 1938 | prefix = os.path.dirname(prefix) |
| 1939 | |
| 1940 | # If there is no common prefix, the CL span multiple projects. |
Daniel Erat | a350fd3 | 2014-09-29 14:02:34 -0700 | [diff] [blame] | 1941 | if not prefix: |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1942 | return None |
Bertrand SIMONNET | 0022fff | 2014-07-07 09:52:15 -0700 | [diff] [blame] | 1943 | |
| 1944 | project_name = prefix.split('/')[0] |
Daniel Erat | a350fd3 | 2014-09-29 14:02:34 -0700 | [diff] [blame] | 1945 | |
| 1946 | # The common files may all be within a subdirectory of the main project |
| 1947 | # directory, so walk up the tree until we find an alias file. |
| 1948 | # _get_affected_files() should return relative paths, but check against '/' to |
| 1949 | # ensure that this loop terminates even if it receives an absolute path. |
| 1950 | while prefix and prefix != '/': |
| 1951 | alias_file = os.path.join(prefix, '.project_alias') |
| 1952 | |
| 1953 | # If an alias exists, use it. |
| 1954 | if os.path.isfile(alias_file): |
| 1955 | project_name = osutils.ReadFile(alias_file).strip() |
| 1956 | |
| 1957 | prefix = os.path.dirname(prefix) |
Bertrand SIMONNET | 0022fff | 2014-07-07 09:52:15 -0700 | [diff] [blame] | 1958 | |
| 1959 | if not _get_commit_desc(commit).startswith(project_name + ': '): |
| 1960 | return HookFailure('The commit title for changes affecting only %s' |
| 1961 | ' should start with \"%s: \"' |
| 1962 | % (project_name, project_name)) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1963 | return None |
Bertrand SIMONNET | 0022fff | 2014-07-07 09:52:15 -0700 | [diff] [blame] | 1964 | |
| 1965 | |
Satoru Takabayashi | 15d17a5 | 2018-08-06 11:12:15 +0900 | [diff] [blame] | 1966 | def _check_filepath_chartype(_project, commit): |
| 1967 | """Checks that FilePath::CharType stuff is not used.""" |
| 1968 | |
| 1969 | FILEPATH_REGEXP = re.compile('|'.join( |
| 1970 | [r'(?:base::)?FilePath::(?:Char|String|StringPiece)Type', |
Satoru Takabayashi | 4ca3792 | 2018-08-08 10:16:38 +0900 | [diff] [blame] | 1971 | r'(?:base::)?FilePath::FromUTF8Unsafe', |
| 1972 | r'AsUTF8Unsafe', |
Satoru Takabayashi | 15d17a5 | 2018-08-06 11:12:15 +0900 | [diff] [blame] | 1973 | r'FILE_PATH_LITERAL'])) |
| 1974 | files = _filter_files(_get_affected_files(commit, relative=True), |
| 1975 | [r'.*\.(cc|h)$']) |
| 1976 | |
| 1977 | errors = [] |
| 1978 | for afile in files: |
| 1979 | for line_num, line in _get_file_diff(afile, commit): |
| 1980 | m = re.search(FILEPATH_REGEXP, line) |
| 1981 | if m: |
| 1982 | errors.append('%s, line %s has %s' % (afile, line_num, m.group(0))) |
| 1983 | |
| 1984 | if errors: |
| 1985 | msg = 'Please assume FilePath::CharType is char (crbug.com/870621):' |
| 1986 | return HookFailure(msg, errors) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 1987 | return None |
Satoru Takabayashi | 15d17a5 | 2018-08-06 11:12:15 +0900 | [diff] [blame] | 1988 | |
| 1989 | |
Mike Frysinger | f9d41b3 | 2017-02-23 15:20:04 -0500 | [diff] [blame] | 1990 | def _check_exec_files(_project, commit): |
| 1991 | """Make +x bits on files.""" |
| 1992 | # List of files that should never be +x. |
| 1993 | NO_EXEC = ( |
| 1994 | 'ChangeLog*', |
| 1995 | 'COPYING', |
| 1996 | 'make.conf', |
| 1997 | 'make.defaults', |
| 1998 | 'Manifest', |
| 1999 | 'OWNERS', |
| 2000 | 'package.use', |
| 2001 | 'package.keywords', |
| 2002 | 'package.mask', |
| 2003 | 'parent', |
| 2004 | 'README', |
| 2005 | 'TODO', |
| 2006 | '.gitignore', |
| 2007 | '*.[achly]', |
| 2008 | '*.[ch]xx', |
| 2009 | '*.boto', |
| 2010 | '*.cc', |
| 2011 | '*.cfg', |
| 2012 | '*.conf', |
| 2013 | '*.config', |
| 2014 | '*.cpp', |
| 2015 | '*.css', |
| 2016 | '*.ebuild', |
| 2017 | '*.eclass', |
Tatsuhisa Yamaguchi | 3b05363 | 2019-01-10 14:45:14 +0900 | [diff] [blame] | 2018 | '*.gn', |
| 2019 | '*.gni', |
Mike Frysinger | f9d41b3 | 2017-02-23 15:20:04 -0500 | [diff] [blame] | 2020 | '*.gyp', |
| 2021 | '*.gypi', |
| 2022 | '*.htm', |
| 2023 | '*.html', |
| 2024 | '*.ini', |
| 2025 | '*.js', |
| 2026 | '*.json', |
| 2027 | '*.md', |
| 2028 | '*.mk', |
| 2029 | '*.patch', |
| 2030 | '*.policy', |
| 2031 | '*.proto', |
| 2032 | '*.raw', |
| 2033 | '*.rules', |
| 2034 | '*.service', |
| 2035 | '*.target', |
| 2036 | '*.txt', |
| 2037 | '*.xml', |
| 2038 | '*.yaml', |
| 2039 | ) |
| 2040 | |
| 2041 | def FinalName(obj): |
| 2042 | # If the file is being deleted, then the dst_file is not set. |
| 2043 | if obj.dst_file is None: |
| 2044 | return obj.src_file |
| 2045 | else: |
| 2046 | return obj.dst_file |
| 2047 | |
| 2048 | bad_files = [] |
| 2049 | files = _get_affected_files(commit, relative=True, full_details=True) |
| 2050 | for f in files: |
| 2051 | mode = int(f.dst_mode, 8) |
| 2052 | if not mode & 0o111: |
| 2053 | continue |
| 2054 | name = FinalName(f) |
| 2055 | for no_exec in NO_EXEC: |
| 2056 | if fnmatch.fnmatch(name, no_exec): |
| 2057 | bad_files.append(name) |
| 2058 | break |
| 2059 | |
| 2060 | if bad_files: |
| 2061 | return HookFailure('These files should not be executable. ' |
| 2062 | 'Please `chmod -x` them.', bad_files) |
Mike Frysinger | 8cf8081 | 2019-09-16 23:49:29 -0400 | [diff] [blame] | 2063 | return None |
Mike Frysinger | f9d41b3 | 2017-02-23 15:20:04 -0500 | [diff] [blame] | 2064 | |
| 2065 | |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 2066 | # Base |
| 2067 | |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 2068 | # A list of hooks which are not project specific and check patch description |
| 2069 | # (as opposed to patch body). |
| 2070 | _PATCH_DESCRIPTION_HOOKS = [ |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 2071 | _check_change_has_bug_field, |
David James | c3b68b3 | 2013-04-03 09:17:03 -0700 | [diff] [blame] | 2072 | _check_change_has_valid_cq_depend, |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 2073 | _check_change_has_test_field, |
| 2074 | _check_change_has_proper_changeid, |
Mike Frysinger | 36b2ebc | 2014-10-31 14:02:03 -0400 | [diff] [blame] | 2075 | _check_commit_message_style, |
Bernie Thompson | f8fea99 | 2016-01-14 10:27:18 -0800 | [diff] [blame] | 2076 | _check_change_is_contribution, |
Jack Neus | 8edbf64 | 2019-07-10 16:08:31 -0600 | [diff] [blame] | 2077 | _check_change_no_include_oem, |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 2078 | ] |
| 2079 | |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 2080 | # A list of hooks that are not project-specific |
| 2081 | _COMMON_HOOKS = [ |
Keiichi Watanabe | 6ab73fd | 2020-07-14 23:42:02 +0900 | [diff] [blame] | 2082 | _check_cargo_clippy, |
Aviv Keshet | 5ac5952 | 2017-01-31 14:28:27 -0800 | [diff] [blame] | 2083 | _check_cros_license, |
Mike Frysinger | bf8b91c | 2014-02-01 02:50:27 -0500 | [diff] [blame] | 2084 | _check_ebuild_eapi, |
Mike Frysinger | 89bdb85 | 2014-02-01 05:26:26 -0500 | [diff] [blame] | 2085 | _check_ebuild_keywords, |
Yu-Ju Hong | 5e0efa7 | 2013-11-19 16:28:10 -0800 | [diff] [blame] | 2086 | _check_ebuild_licenses, |
Mike Frysinger | 6ee76b8 | 2020-11-20 01:16:06 -0500 | [diff] [blame] | 2087 | _check_ebuild_r0, |
Mike Frysinger | cd363c8 | 2014-02-01 05:20:18 -0500 | [diff] [blame] | 2088 | _check_ebuild_virtual_pv, |
Mike Frysinger | f9d41b3 | 2017-02-23 15:20:04 -0500 | [diff] [blame] | 2089 | _check_exec_files, |
Daniel Erat | 9d203ff | 2015-02-17 10:12:21 -0700 | [diff] [blame] | 2090 | _check_for_uprev, |
Rahul Chaudhry | 09f6137 | 2015-07-31 17:14:26 -0700 | [diff] [blame] | 2091 | _check_gofmt, |
Bernie Thompson | 8e26f74 | 2020-07-23 14:32:31 -0700 | [diff] [blame] | 2092 | _check_keywords, |
Mike Frysinger | 998c2cc | 2014-08-27 05:20:23 -0400 | [diff] [blame] | 2093 | _check_layout_conf, |
Daniel Erat | 9d203ff | 2015-02-17 10:12:21 -0700 | [diff] [blame] | 2094 | _check_no_long_lines, |
Keigo Oka | 4a09bd9 | 2019-05-07 14:01:00 +0900 | [diff] [blame] | 2095 | _check_no_new_gyp, |
Daniel Erat | 9d203ff | 2015-02-17 10:12:21 -0700 | [diff] [blame] | 2096 | _check_no_stray_whitespace, |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 2097 | _check_no_tabs, |
Daniel Erat | 9d203ff | 2015-02-17 10:12:21 -0700 | [diff] [blame] | 2098 | _check_portage_make_use_var, |
Fletcher Woodruff | ce1cb1b | 2019-08-16 15:59:32 -0600 | [diff] [blame] | 2099 | _check_rustfmt, |
Aviv Keshet | 5ac5952 | 2017-01-31 14:28:27 -0800 | [diff] [blame] | 2100 | _check_tabbed_indents, |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 2101 | ] |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 2102 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 2103 | |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 2104 | # A dictionary of project-specific hooks(callbacks), indexed by project name. |
| 2105 | # dict[project] = [callback1, callback2] |
| 2106 | _PROJECT_SPECIFIC_HOOKS = { |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 2107 | 'chromiumos/third_party/kernel': [_kernel_configcheck], |
| 2108 | 'chromiumos/third_party/kernel-next': [_kernel_configcheck], |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 2109 | } |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 2110 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 2111 | |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 2112 | # A dictionary of flags (keys) that can appear in the config file, and the hook |
Mike Frysinger | 3554bc9 | 2015-03-11 04:59:21 -0400 | [diff] [blame] | 2113 | # that the flag controls (value). |
| 2114 | _HOOK_FLAGS = { |
Luis Hector Chavez | b50391d | 2017-09-26 15:48:15 -0700 | [diff] [blame] | 2115 | 'clang_format_check': _check_clang_format, |
Mike Frysinger | a7642f5 | 2015-03-25 18:31:42 -0400 | [diff] [blame] | 2116 | 'checkpatch_check': _run_checkpatch, |
Brian Norris | 23c62e9 | 2018-11-14 12:25:51 -0800 | [diff] [blame] | 2117 | 'kerneldoc_check': _run_kerneldoc, |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 2118 | 'stray_whitespace_check': _check_no_stray_whitespace, |
Mike Frysinger | ff6c7d6 | 2015-03-24 13:49:46 -0400 | [diff] [blame] | 2119 | 'json_check': _run_json_check, |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 2120 | 'long_line_check': _check_no_long_lines, |
Alex Deymo | f5792ce | 2015-08-24 22:50:08 -0700 | [diff] [blame] | 2121 | 'cros_license_check': _check_cros_license, |
| 2122 | 'aosp_license_check': _check_aosp_license, |
LaMont Jones | 872fe76 | 2020-02-10 15:36:14 -0700 | [diff] [blame] | 2123 | 'gofmt_check': _check_gofmt, |
Bernie Thompson | 8e26f74 | 2020-07-23 14:32:31 -0700 | [diff] [blame] | 2124 | 'keyword_check': _check_keywords, |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 2125 | 'tab_check': _check_no_tabs, |
Prathmesh Prabhu | c525465 | 2016-12-22 12:58:05 -0800 | [diff] [blame] | 2126 | 'tabbed_indent_required_check': _check_tabbed_indents, |
Puneet Kumar | c80e3f6 | 2012-08-13 19:01:18 -0700 | [diff] [blame] | 2127 | 'branch_check': _check_change_has_branch_field, |
Shawn Nematbakhsh | 51e16ac | 2014-01-28 15:31:07 -0800 | [diff] [blame] | 2128 | 'signoff_check': _check_change_has_signoff_field, |
Josh Triplett | 0e8fc7f | 2014-04-23 16:00:00 -0700 | [diff] [blame] | 2129 | 'bug_field_check': _check_change_has_bug_field, |
| 2130 | 'test_field_check': _check_change_has_test_field, |
Steve Fung | 49ec7e9 | 2015-03-23 16:07:12 -0700 | [diff] [blame] | 2131 | 'manifest_check': _check_manifests, |
Bernie Thompson | f8fea99 | 2016-01-14 10:27:18 -0800 | [diff] [blame] | 2132 | 'contribution_check': _check_change_is_contribution, |
Mike Frysinger | 47bd125 | 2018-06-11 12:12:20 -0400 | [diff] [blame] | 2133 | 'project_prefix_check': _check_project_prefix, |
Satoru Takabayashi | 15d17a5 | 2018-08-06 11:12:15 +0900 | [diff] [blame] | 2134 | 'filepath_chartype_check': _check_filepath_chartype, |
Keiichi Watanabe | 6ab73fd | 2020-07-14 23:42:02 +0900 | [diff] [blame] | 2135 | 'cargo_clippy_check': _check_cargo_clippy, |
Julius Werner | 291d860 | 2020-07-31 17:34:02 -0700 | [diff] [blame] | 2136 | 'exec_files_check': _check_exec_files, |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 2137 | } |
| 2138 | |
| 2139 | |
Mike Frysinger | 3554bc9 | 2015-03-11 04:59:21 -0400 | [diff] [blame] | 2140 | def _get_override_hooks(config): |
| 2141 | """Returns a set of hooks controlled by the current project's config file. |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 2142 | |
| 2143 | Expects to be called within the project root. |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 2144 | |
| 2145 | Args: |
| 2146 | config: A ConfigParser for the project's config file. |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 2147 | """ |
| 2148 | SECTION = 'Hook Overrides' |
Mike Frysinger | f8ce171 | 2015-03-25 18:32:33 -0400 | [diff] [blame] | 2149 | SECTION_OPTIONS = 'Hook Overrides Options' |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 2150 | |
Mike Frysinger | 56e8de0 | 2019-07-31 14:40:14 -0400 | [diff] [blame] | 2151 | valid_keys = set(_HOOK_FLAGS.keys()) |
Mike Frysinger | f8ce171 | 2015-03-25 18:32:33 -0400 | [diff] [blame] | 2152 | hooks = _HOOK_FLAGS.copy() |
Mike Frysinger | 180ecd6 | 2020-08-19 00:41:51 -0400 | [diff] [blame] | 2153 | hook_overrides = set( |
| 2154 | config.options(SECTION) if config.has_section(SECTION) else []) |
| 2155 | |
| 2156 | unknown_keys = hook_overrides - valid_keys |
| 2157 | if unknown_keys: |
| 2158 | raise ValueError(f'{_CONFIG_FILE}: [{SECTION}]: unknown keys: ' |
| 2159 | f'{unknown_keys}') |
Mike Frysinger | 3554bc9 | 2015-03-11 04:59:21 -0400 | [diff] [blame] | 2160 | |
| 2161 | enable_flags = [] |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 2162 | disable_flags = [] |
Mike Frysinger | 180ecd6 | 2020-08-19 00:41:51 -0400 | [diff] [blame] | 2163 | for flag in valid_keys: |
| 2164 | if flag in hook_overrides: |
| 2165 | try: |
| 2166 | enabled = config.getboolean(SECTION, flag) |
| 2167 | except ValueError as e: |
| 2168 | raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' % |
| 2169 | (flag, _CONFIG_FILE, e)) |
| 2170 | elif hooks[flag] in _COMMON_HOOKS: |
| 2171 | # Enable common hooks by default so we process custom options below. |
| 2172 | enabled = True |
| 2173 | else: |
| 2174 | # All other hooks we left as a tristate. We use this below for a few |
| 2175 | # hooks to control default behavior. |
| 2176 | enabled = None |
Mike Frysinger | 3554bc9 | 2015-03-11 04:59:21 -0400 | [diff] [blame] | 2177 | |
Mike Frysinger | f8ce171 | 2015-03-25 18:32:33 -0400 | [diff] [blame] | 2178 | if enabled: |
| 2179 | enable_flags.append(flag) |
Mike Frysinger | 180ecd6 | 2020-08-19 00:41:51 -0400 | [diff] [blame] | 2180 | elif enabled is not None: |
Mike Frysinger | f8ce171 | 2015-03-25 18:32:33 -0400 | [diff] [blame] | 2181 | disable_flags.append(flag) |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 2182 | |
Mike Frysinger | f8ce171 | 2015-03-25 18:32:33 -0400 | [diff] [blame] | 2183 | # See if this hook has custom options. |
| 2184 | if enabled: |
| 2185 | try: |
| 2186 | options = config.get(SECTION_OPTIONS, flag) |
| 2187 | hooks[flag] = functools.partial(hooks[flag], options=options.split()) |
Mike Frysinger | b7d552e | 2017-11-23 11:50:47 -0500 | [diff] [blame] | 2188 | hooks[flag].__name__ = flag |
Mike Frysinger | 7bfc89f | 2019-09-13 15:45:51 -0400 | [diff] [blame] | 2189 | except (configparser.NoOptionError, configparser.NoSectionError): |
Mike Frysinger | f8ce171 | 2015-03-25 18:32:33 -0400 | [diff] [blame] | 2190 | pass |
| 2191 | |
| 2192 | enabled_hooks = set(hooks[x] for x in enable_flags) |
| 2193 | disabled_hooks = set(hooks[x] for x in disable_flags) |
Mike Frysinger | 45334bd | 2019-11-04 10:42:33 -0500 | [diff] [blame] | 2194 | |
Mike Frysinger | 9ab64b1 | 2019-11-04 10:53:08 -0500 | [diff] [blame] | 2195 | if _check_change_has_signoff_field not in enabled_hooks: |
Drew Davenport | 85848e5 | 2020-01-15 14:40:29 -0700 | [diff] [blame] | 2196 | if _check_change_has_signoff_field not in disabled_hooks: |
| 2197 | enabled_hooks.add(_check_change_has_no_signoff_field) |
Mike Frysinger | 45334bd | 2019-11-04 10:42:33 -0500 | [diff] [blame] | 2198 | if _check_change_has_branch_field not in enabled_hooks: |
| 2199 | enabled_hooks.add(_check_change_has_no_branch_field) |
| 2200 | |
Mike Frysinger | 3554bc9 | 2015-03-11 04:59:21 -0400 | [diff] [blame] | 2201 | return enabled_hooks, disabled_hooks |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 2202 | |
| 2203 | |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 2204 | def _get_project_hook_scripts(config): |
| 2205 | """Returns a list of project-specific hook scripts. |
| 2206 | |
| 2207 | Args: |
| 2208 | config: A ConfigParser for the project's config file. |
| 2209 | """ |
| 2210 | SECTION = 'Hook Scripts' |
| 2211 | if not config.has_section(SECTION): |
| 2212 | return [] |
| 2213 | |
Mike Frysinger | b7d552e | 2017-11-23 11:50:47 -0500 | [diff] [blame] | 2214 | return config.items(SECTION) |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 2215 | |
| 2216 | |
Sonny Sasaka | 5a905ea | 2020-07-24 15:30:12 -0700 | [diff] [blame] | 2217 | def _get_project_hooks(project, presubmit, config_file=None): |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 2218 | """Returns a list of hooks that need to be run for a project. |
| 2219 | |
| 2220 | Expects to be called from within the project root. |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 2221 | |
| 2222 | Args: |
| 2223 | project: A string, name of the project. |
| 2224 | presubmit: A Boolean, True if the check is run as a git pre-submit script. |
Sonny Sasaka | 5a905ea | 2020-07-24 15:30:12 -0700 | [diff] [blame] | 2225 | config_file: A string, the config file. Defaults to _CONFIG_FILE. |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 2226 | """ |
Mike Frysinger | 7bfc89f | 2019-09-13 15:45:51 -0400 | [diff] [blame] | 2227 | config = configparser.RawConfigParser() |
Sonny Sasaka | 5a905ea | 2020-07-24 15:30:12 -0700 | [diff] [blame] | 2228 | if config_file is None: |
| 2229 | config_file = _CONFIG_FILE |
| 2230 | if not os.path.exists(config_file): |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 2231 | # Just use an empty config file |
Mike Frysinger | 7bfc89f | 2019-09-13 15:45:51 -0400 | [diff] [blame] | 2232 | config = configparser.RawConfigParser() |
Shuhei Takahashi | 3cbb8dd | 2019-10-29 12:37:11 +0900 | [diff] [blame] | 2233 | else: |
Sonny Sasaka | 5a905ea | 2020-07-24 15:30:12 -0700 | [diff] [blame] | 2234 | config.read(config_file) |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 2235 | |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 2236 | if presubmit: |
Filipe Brandenburger | f70d32c | 2015-10-09 13:35:45 -0700 | [diff] [blame] | 2237 | hooks = _COMMON_HOOKS |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 2238 | else: |
Filipe Brandenburger | f70d32c | 2015-10-09 13:35:45 -0700 | [diff] [blame] | 2239 | hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 2240 | |
Mike Frysinger | 3554bc9 | 2015-03-11 04:59:21 -0400 | [diff] [blame] | 2241 | enabled_hooks, disabled_hooks = _get_override_hooks(config) |
Filipe Brandenburger | f70d32c | 2015-10-09 13:35:45 -0700 | [diff] [blame] | 2242 | hooks = [hook for hook in hooks if hook not in disabled_hooks] |
| 2243 | |
| 2244 | # If a list is both in _COMMON_HOOKS and also enabled explicitly through an |
| 2245 | # override, keep the override only. Note that the override may end up being |
| 2246 | # a functools.partial, in which case we need to extract the .func to compare |
| 2247 | # it to the common hooks. |
| 2248 | unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks] |
| 2249 | hooks = [hook for hook in hooks if hook not in unwrapped_hooks] |
| 2250 | |
| 2251 | hooks = list(enabled_hooks) + hooks |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 2252 | |
| 2253 | if project in _PROJECT_SPECIFIC_HOOKS: |
Puneet Kumar | c80e3f6 | 2012-08-13 19:01:18 -0700 | [diff] [blame] | 2254 | hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project] |
| 2255 | if hook not in disabled_hooks) |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 2256 | |
Mike Frysinger | b7d552e | 2017-11-23 11:50:47 -0500 | [diff] [blame] | 2257 | for name, script in _get_project_hook_scripts(config): |
| 2258 | func = functools.partial(_run_project_hook_script, script) |
| 2259 | func.__name__ = name |
| 2260 | hooks.append(func) |
Jon Salz | 3ee59de | 2012-08-18 13:54:22 +0800 | [diff] [blame] | 2261 | |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 2262 | return hooks |
| 2263 | |
| 2264 | |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 2265 | def _run_project_hooks(project_name, proj_dir=None, |
Sonny Sasaka | 5a905ea | 2020-07-24 15:30:12 -0700 | [diff] [blame] | 2266 | commit_list=None, presubmit=False, |
| 2267 | config_file=None): |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 2268 | """For each project run its project specific hook from the hooks dictionary. |
| 2269 | |
| 2270 | Args: |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 2271 | project_name: The name of project to run hooks for. |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 2272 | proj_dir: If non-None, this is the directory the project is in. If None, |
| 2273 | we'll ask repo. |
Doug Anderson | 1474956 | 2013-06-26 13:38:29 -0700 | [diff] [blame] | 2274 | commit_list: A list of commits to run hooks against. If None or empty list |
| 2275 | then we'll automatically get the list of commits that would be uploaded. |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 2276 | presubmit: A Boolean, True if the check is run as a git pre-submit script. |
Sonny Sasaka | 5a905ea | 2020-07-24 15:30:12 -0700 | [diff] [blame] | 2277 | config_file: A string, the presubmit config file. If not specified, |
| 2278 | defaults to PRESUBMIT.cfg in the project directory. |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 2279 | |
| 2280 | Returns: |
| 2281 | Boolean value of whether any errors were ecountered while running the hooks. |
| 2282 | """ |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 2283 | if proj_dir is None: |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 2284 | proj_dirs = _run_command( |
| 2285 | ['repo', 'forall', project_name, '-c', 'pwd']).split() |
Mike Frysinger | e52b1bc | 2019-09-16 23:45:41 -0400 | [diff] [blame] | 2286 | if not proj_dirs: |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 2287 | print('%s cannot be found.' % project_name, file=sys.stderr) |
David James | 2edd900 | 2013-10-11 14:09:19 -0700 | [diff] [blame] | 2288 | print('Please specify a valid project.', file=sys.stderr) |
| 2289 | return True |
| 2290 | if len(proj_dirs) > 1: |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 2291 | print('%s is associated with multiple directories.' % project_name, |
David James | 2edd900 | 2013-10-11 14:09:19 -0700 | [diff] [blame] | 2292 | file=sys.stderr) |
| 2293 | print('Please specify a directory to help disambiguate.', file=sys.stderr) |
| 2294 | return True |
| 2295 | proj_dir = proj_dirs[0] |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 2296 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 2297 | pwd = os.getcwd() |
| 2298 | # hooks assume they are run from the root of the project |
| 2299 | os.chdir(proj_dir) |
| 2300 | |
Mike Frysinger | ed1b95a | 2019-12-12 19:04:51 -0500 | [diff] [blame] | 2301 | color = terminal.Color() |
| 2302 | |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 2303 | remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref', |
| 2304 | '--symbolic-full-name', '@{u}']).strip() |
| 2305 | if not remote_branch: |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 2306 | print("Your project %s doesn't track any remote repo." % project_name, |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 2307 | file=sys.stderr) |
| 2308 | remote = None |
| 2309 | else: |
Josh Pratt | 15d13ab | 2018-08-13 11:52:48 +1000 | [diff] [blame] | 2310 | branch_items = remote_branch.split('/', 1) |
| 2311 | if len(branch_items) != 2: |
| 2312 | PrintErrorForProject( |
| 2313 | project_name, |
| 2314 | HookFailure( |
| 2315 | 'Cannot get remote and branch name (%s)' % remote_branch)) |
| 2316 | os.chdir(pwd) |
| 2317 | return True |
| 2318 | remote, _branch = branch_items |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 2319 | |
| 2320 | project = Project(name=project_name, dir=proj_dir, remote=remote) |
| 2321 | |
Doug Anderson | 1474956 | 2013-06-26 13:38:29 -0700 | [diff] [blame] | 2322 | if not commit_list: |
| 2323 | try: |
| 2324 | commit_list = _get_commits() |
| 2325 | except VerifyException as e: |
Alex Deymo | 643ac4c | 2015-09-03 10:40:50 -0700 | [diff] [blame] | 2326 | PrintErrorForProject(project.name, HookFailure(str(e))) |
Doug Anderson | 1474956 | 2013-06-26 13:38:29 -0700 | [diff] [blame] | 2327 | os.chdir(pwd) |
| 2328 | return True |
Ryan Cui | fa55df5 | 2011-05-06 11:16:55 -0700 | [diff] [blame] | 2329 | |
Sonny Sasaka | 5a905ea | 2020-07-24 15:30:12 -0700 | [diff] [blame] | 2330 | hooks = _get_project_hooks(project.name, presubmit, config_file) |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 2331 | error_found = False |
Mike Frysinger | b7d552e | 2017-11-23 11:50:47 -0500 | [diff] [blame] | 2332 | commit_count = len(commit_list) |
Mike Frysinger | b99b377 | 2019-08-17 14:19:44 -0400 | [diff] [blame] | 2333 | hook_count = len(hooks) |
Mike Frysinger | b7d552e | 2017-11-23 11:50:47 -0500 | [diff] [blame] | 2334 | for i, commit in enumerate(commit_list): |
Mike Frysinger | b249665 | 2019-09-12 23:35:46 -0400 | [diff] [blame] | 2335 | CACHE.clear() |
| 2336 | |
LaMont Jones | 69d3e18 | 2020-03-11 15:00:53 -0600 | [diff] [blame] | 2337 | # If run with --pre-submit, then commit is PRE_SUBMIT, and not a commit. |
| 2338 | # Use that as the description. |
| 2339 | desc = commit if commit == PRE_SUBMIT else _get_commit_desc(commit) |
Mike Frysinger | ed1b95a | 2019-12-12 19:04:51 -0500 | [diff] [blame] | 2340 | print('[%s %i/%i %s] %s' % |
| 2341 | (color.Color(color.CYAN, 'COMMIT'), i + 1, commit_count, commit[0:12], |
| 2342 | desc.splitlines()[0])) |
| 2343 | |
Mike Frysinger | b99b377 | 2019-08-17 14:19:44 -0400 | [diff] [blame] | 2344 | for h, hook in enumerate(hooks): |
Mike Frysinger | ed1b95a | 2019-12-12 19:04:51 -0500 | [diff] [blame] | 2345 | output = ('[%s %i/%i PRESUBMIT.cfg] %s' % |
| 2346 | (color.Color(color.YELLOW, 'RUNNING'), h + 1, hook_count, |
| 2347 | hook.__name__)) |
Mike Frysinger | b7d552e | 2017-11-23 11:50:47 -0500 | [diff] [blame] | 2348 | print(output, end='\r') |
| 2349 | sys.stdout.flush() |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 2350 | hook_error = hook(project, commit) |
Mike Frysinger | b7d552e | 2017-11-23 11:50:47 -0500 | [diff] [blame] | 2351 | print(' ' * len(output), end='\r') |
| 2352 | sys.stdout.flush() |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 2353 | if hook_error: |
Mike Frysinger | ed1b95a | 2019-12-12 19:04:51 -0500 | [diff] [blame] | 2354 | if not isinstance(hook_error, list): |
| 2355 | hook_error = [hook_error] |
| 2356 | PrintErrorsForCommit(color, hook, project.name, hook_error) |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 2357 | error_found = True |
Don Garrett | dba548a | 2011-05-05 15:17:14 -0700 | [diff] [blame] | 2358 | |
Ryan Cui | ec4d633 | 2011-05-02 14:15:25 -0700 | [diff] [blame] | 2359 | os.chdir(pwd) |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 2360 | return error_found |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 2361 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 2362 | |
Mandeep Singh Baines | 116ad10 | 2011-04-27 15:16:37 -0700 | [diff] [blame] | 2363 | # Main |
Mandeep Singh Baines | 69e470e | 2011-04-06 10:34:52 -0700 | [diff] [blame] | 2364 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 2365 | |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 2366 | def main(project_list, worktree_list=None, **_kwargs): |
Doug Anderson | 0645663 | 2012-01-05 11:02:14 -0800 | [diff] [blame] | 2367 | """Main function invoked directly by repo. |
| 2368 | |
| 2369 | This function will exit directly upon error so that repo doesn't print some |
| 2370 | obscure error message. |
| 2371 | |
| 2372 | Args: |
| 2373 | project_list: List of projects to run on. |
David James | 2edd900 | 2013-10-11 14:09:19 -0700 | [diff] [blame] | 2374 | worktree_list: A list of directories. It should be the same length as |
| 2375 | project_list, so that each entry in project_list matches with a directory |
| 2376 | in worktree_list. If None, we will attempt to calculate the directories |
| 2377 | automatically. |
Doug Anderson | 0645663 | 2012-01-05 11:02:14 -0800 | [diff] [blame] | 2378 | kwargs: Leave this here for forward-compatibility. |
| 2379 | """ |
Mike Frysinger | ed1b95a | 2019-12-12 19:04:51 -0500 | [diff] [blame] | 2380 | start_time = datetime.datetime.now() |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 2381 | found_error = False |
David James | 2edd900 | 2013-10-11 14:09:19 -0700 | [diff] [blame] | 2382 | if not worktree_list: |
| 2383 | worktree_list = [None] * len(project_list) |
| 2384 | for project, worktree in zip(project_list, worktree_list): |
| 2385 | if _run_project_hooks(project, proj_dir=worktree): |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 2386 | found_error = True |
| 2387 | |
Mike Frysinger | ed1b95a | 2019-12-12 19:04:51 -0500 | [diff] [blame] | 2388 | end_time = datetime.datetime.now() |
| 2389 | color = terminal.Color() |
Mike Frysinger | ae40952 | 2014-02-01 03:16:11 -0500 | [diff] [blame] | 2390 | if found_error: |
Mike Frysinger | ed1b95a | 2019-12-12 19:04:51 -0500 | [diff] [blame] | 2391 | msg = ('%s: Preupload failed due to above error(s).\n' |
Ryan Cui | 9b65163 | 2011-05-11 11:38:58 -0700 | [diff] [blame] | 2392 | '- To disable some source style checks, and for other hints, see ' |
Mike Frysinger | ed1b95a | 2019-12-12 19:04:51 -0500 | [diff] [blame] | 2393 | '<checkout_dir>/src/repohooks/README.md\n' |
| 2394 | "- To upload only current project, run 'repo upload .'" % |
| 2395 | (color.Color(color.RED, 'FATAL'),)) |
Mike Frysinger | 09d6a3d | 2013-10-08 22:21:03 -0400 | [diff] [blame] | 2396 | print(msg, file=sys.stderr) |
Don Garrett | dba548a | 2011-05-05 15:17:14 -0700 | [diff] [blame] | 2397 | sys.exit(1) |
Mike Frysinger | ed1b95a | 2019-12-12 19:04:51 -0500 | [diff] [blame] | 2398 | else: |
| 2399 | msg = ('[%s] repohooks passed in %s' % |
| 2400 | (color.Color(color.GREEN, 'PASSED'), end_time - start_time)) |
| 2401 | print(msg) |
Anush Elangovan | 63afad7 | 2011-03-23 00:41:27 -0700 | [diff] [blame] | 2402 | |
Ryan Cui | 1562fb8 | 2011-05-09 11:01:31 -0700 | [diff] [blame] | 2403 | |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 2404 | def _identify_project(path): |
| 2405 | """Identify the repo project associated with the given path. |
| 2406 | |
| 2407 | Returns: |
| 2408 | A string indicating what project is associated with the path passed in or |
| 2409 | a blank string upon failure. |
| 2410 | """ |
| 2411 | return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'], |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 2412 | stderr=True, cwd=path).strip() |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 2413 | |
| 2414 | |
Mike Frysinger | 55f85b5 | 2014-12-18 14:45:21 -0500 | [diff] [blame] | 2415 | def direct_main(argv): |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 2416 | """Run hooks directly (outside of the context of repo). |
| 2417 | |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 2418 | Args: |
Mike Frysinger | 55f85b5 | 2014-12-18 14:45:21 -0500 | [diff] [blame] | 2419 | argv: The command line args to process |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 2420 | |
| 2421 | Returns: |
| 2422 | 0 if no pre-upload failures, 1 if failures. |
| 2423 | |
| 2424 | Raises: |
| 2425 | BadInvocation: On some types of invocation errors. |
| 2426 | """ |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 2427 | parser = commandline.ArgumentParser(description=__doc__) |
| 2428 | parser.add_argument('--dir', default=None, |
| 2429 | help='The directory that the project lives in. If not ' |
| 2430 | 'specified, use the git project root based on the cwd.') |
| 2431 | parser.add_argument('--project', default=None, |
| 2432 | help='The project repo path; this can affect how the ' |
| 2433 | 'hooks get run, since some hooks are project-specific. ' |
| 2434 | 'For chromite this is chromiumos/chromite. If not ' |
| 2435 | 'specified, the repo tool will be used to figure this ' |
| 2436 | 'out based on the dir.') |
| 2437 | parser.add_argument('--rerun-since', default=None, |
Vadim Bendebury | 75447b9 | 2018-01-10 12:06:01 -0800 | [diff] [blame] | 2438 | help='Rerun hooks on old commits since some point ' |
| 2439 | 'in the past. The argument could be a date (should ' |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 2440 | "match git log's concept of a date, e.g. 2012-06-20), " |
Vadim Bendebury | 75447b9 | 2018-01-10 12:06:01 -0800 | [diff] [blame] | 2441 | 'or a SHA1, or just a number of commits to check (from 1 ' |
| 2442 | 'to 99). This option is mutually exclusive with ' |
| 2443 | '--pre-submit.') |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 2444 | parser.add_argument('--pre-submit', action='store_true', |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 2445 | help='Run the check against the pending commit. ' |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 2446 | "This option should be used at the 'git commit' " |
| 2447 | "phase as opposed to 'repo upload'. This option " |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 2448 | 'is mutually exclusive with --rerun-since.') |
Sonny Sasaka | 5a905ea | 2020-07-24 15:30:12 -0700 | [diff] [blame] | 2449 | parser.add_argument('--presubmit-config', |
| 2450 | help='Specify presubmit config file to be used.') |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 2451 | parser.add_argument('commits', nargs='*', |
| 2452 | help='Check specific commits') |
| 2453 | opts = parser.parse_args(argv) |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 2454 | |
Doug Anderson | 1474956 | 2013-06-26 13:38:29 -0700 | [diff] [blame] | 2455 | if opts.rerun_since: |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 2456 | if opts.commits: |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 2457 | raise BadInvocation("Can't pass commits and use rerun-since: %s" % |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 2458 | ' '.join(opts.commits)) |
Doug Anderson | 1474956 | 2013-06-26 13:38:29 -0700 | [diff] [blame] | 2459 | |
Vadim Bendebury | 75447b9 | 2018-01-10 12:06:01 -0800 | [diff] [blame] | 2460 | if len(opts.rerun_since) < 3 and opts.rerun_since.isdigit(): |
| 2461 | # This must be the number of commits to check. We don't expect the user |
| 2462 | # to want to check more than 99 commits. |
| 2463 | limit = '-n%s' % opts.rerun_since |
| 2464 | elif git.IsSHA1(opts.rerun_since, False): |
| 2465 | limit = '%s..' % opts.rerun_since |
| 2466 | else: |
| 2467 | # This better be a date. |
| 2468 | limit = '--since=%s' % opts.rerun_since |
| 2469 | cmd = ['git', 'log', limit, '--pretty=%H'] |
Doug Anderson | 1474956 | 2013-06-26 13:38:29 -0700 | [diff] [blame] | 2470 | all_commits = _run_command(cmd).splitlines() |
| 2471 | bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines() |
| 2472 | |
| 2473 | # Eliminate chrome-bot commits but keep ordering the same... |
| 2474 | bot_commits = set(bot_commits) |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 2475 | opts.commits = [c for c in all_commits if c not in bot_commits] |
Doug Anderson | 1474956 | 2013-06-26 13:38:29 -0700 | [diff] [blame] | 2476 | |
Vadim Bendebury | 2b62d74 | 2014-06-22 13:14:51 -0700 | [diff] [blame] | 2477 | if opts.pre_submit: |
| 2478 | raise BadInvocation('rerun-since and pre-submit can not be ' |
| 2479 | 'used together') |
| 2480 | if opts.pre_submit: |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 2481 | if opts.commits: |
Mike Frysinger | 24dd3c5 | 2019-08-17 14:22:48 -0400 | [diff] [blame] | 2482 | raise BadInvocation("Can't pass commits and use pre-submit: %s" % |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 2483 | ' '.join(opts.commits)) |
| 2484 | opts.commits = [PRE_SUBMIT,] |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 2485 | |
| 2486 | # Check/normlaize git dir; if unspecified, we'll use the root of the git |
| 2487 | # project from CWD |
| 2488 | if opts.dir is None: |
Mike Frysinger | 9ba001a | 2020-11-20 01:02:11 -0500 | [diff] [blame] | 2489 | git_dir = _run_command(['git', 'rev-parse', '--show-toplevel'], |
Mike Frysinger | 7bb709f | 2019-09-29 23:20:12 -0400 | [diff] [blame] | 2490 | stderr=True).strip() |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 2491 | if not git_dir: |
| 2492 | raise BadInvocation('The current directory is not part of a git project.') |
Mike Frysinger | 9ba001a | 2020-11-20 01:02:11 -0500 | [diff] [blame] | 2493 | opts.dir = git_dir |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 2494 | elif not os.path.isdir(opts.dir): |
| 2495 | raise BadInvocation('Invalid dir: %s' % opts.dir) |
| 2496 | elif not os.path.isdir(os.path.join(opts.dir, '.git')): |
| 2497 | raise BadInvocation('Not a git directory: %s' % opts.dir) |
| 2498 | |
| 2499 | # Identify the project if it wasn't specified; this _requires_ the repo |
| 2500 | # tool to be installed and for the project to be part of a repo checkout. |
| 2501 | if not opts.project: |
| 2502 | opts.project = _identify_project(opts.dir) |
| 2503 | if not opts.project: |
| 2504 | raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir) |
| 2505 | |
Doug Anderson | 1474956 | 2013-06-26 13:38:29 -0700 | [diff] [blame] | 2506 | found_error = _run_project_hooks(opts.project, proj_dir=opts.dir, |
Mike Frysinger | 6614293 | 2014-12-18 14:55:57 -0500 | [diff] [blame] | 2507 | commit_list=opts.commits, |
Sonny Sasaka | 5a905ea | 2020-07-24 15:30:12 -0700 | [diff] [blame] | 2508 | presubmit=opts.pre_submit, |
| 2509 | config_file=opts.presubmit_config) |
Doug Anderson | 44a644f | 2011-11-02 10:37:37 -0700 | [diff] [blame] | 2510 | if found_error: |
| 2511 | return 1 |
| 2512 | return 0 |
| 2513 | |
| 2514 | |
Mandeep Singh Baines | 69e470e | 2011-04-06 10:34:52 -0700 | [diff] [blame] | 2515 | if __name__ == '__main__': |
Mike Frysinger | 55f85b5 | 2014-12-18 14:45:21 -0500 | [diff] [blame] | 2516 | sys.exit(direct_main(sys.argv[1:])) |