blob: ce994f56709c5cf01e10e2d463088c351b8f66bf [file] [log] [blame]
Mike Frysinger4f994402019-09-13 17:40:45 -04001#!/usr/bin/env python3
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002# -*- coding: utf-8 -*-
Jon Salz98255932012-08-18 14:48:02 +08003# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
Mike Frysingerae409522014-02-01 03:16:11 -05007"""Presubmit checks to run when doing `repo upload`.
8
Tom Hughes40bdce52020-08-25 08:57:03 -07009You can add new checks by adding a function to the HOOKS constants.
Mike Frysingerae409522014-02-01 03:16:11 -050010"""
11
Mike Frysinger09d6a3d2013-10-08 22:21:03 -040012from __future__ import print_function
13
Keigo Okadd908822019-06-04 11:30:25 +090014import argparse
Alex Deymo643ac4c2015-09-03 10:40:50 -070015import collections
Mike Frysingerf252cfc2019-12-09 17:34:28 -050016import configparser
Keigo Oka7e880ac2019-07-03 15:03:43 +090017import datetime
Daniel Erate3ea3fc2015-02-13 15:27:52 -070018import fnmatch
Jon Salz3ee59de2012-08-18 13:54:22 +080019import functools
Dale Curtis2975c432011-05-03 17:25:20 -070020import json
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070021import os
Ryan Cuiec4d6332011-05-02 14:15:25 -070022import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070023import sys
Peter Ammon811f6702014-06-12 15:45:38 -070024import stat
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -050025import subprocess
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070026
Ryan Cui1562fb82011-05-09 11:01:31 -070027from errors import (VerifyException, HookFailure, PrintErrorForProject,
28 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070029
Mike Frysinger919c7032019-09-13 17:48:08 -040030if __name__ in ('__builtin__', 'builtins'):
Mike Frysinger653cd262019-09-20 14:05:02 -040031 # If repo imports us, the __name__ will be __builtin__, and the cwd will be in
32 # the top level of the checkout (i.e. $CHROMEOS_CHECKOUT). chromite will be
33 # in that directory, so add it to our path. This works whether we're running
34 # the repo in $CHROMEOS_CHECKOUT/.repo/repo/ or a custom version in a
35 # completely different tree.
36 # TODO(vapier): Python 2 used "__builtin__" while Python 3 uses "builtins".
Mike Frysinger6850d512018-05-21 12:12:14 -040037 sys.path.insert(0, os.getcwd())
38
Mike Frysinger653cd262019-09-20 14:05:02 -040039elif __name__ == '__main__':
40 # If we're run directly, we'll find chromite relative to the repohooks dir in
41 # $CHROMEOS_CHECKOUT/src/repohooks, so go up two dirs.
David Jamesc3b68b32013-04-03 09:17:03 -070042 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
43
Mike Frysingerfd481ce2019-09-13 18:14:48 -040044# The sys.path monkey patching confuses the linter.
45# pylint: disable=wrong-import-position
Mike Frysinger66142932014-12-18 14:55:57 -050046from chromite.lib import commandline
Rahul Chaudhry0e515342015-08-07 12:00:43 -070047from chromite.lib import cros_build_lib
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050048from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070049from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070050from chromite.lib import patch
Mike Frysingered1b95a2019-12-12 19:04:51 -050051from chromite.lib import terminal
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040052from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070053
Mike Frysingerff4768e2020-02-27 18:48:13 -050054
55assert sys.version_info >= (3, 6), 'This module requires Python 3.6+'
56
57
Vadim Bendebury2b62d742014-06-22 13:14:51 -070058PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070059
Mike Frysingered9b2a02019-12-12 18:52:32 -050060
61# Link to commit message documentation for users.
62DOC_COMMIT_MSG_URL = ('https://chromium.googlesource.com/chromiumos/docs/+/HEAD'
63 '/contributing.md#commit-messages')
64
65
Ryan Cuiec4d6332011-05-02 14:15:25 -070066COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050067 # C++ and friends
Mike Frysinger24dd3c52019-08-17 14:22:48 -040068 r'.*\.c$', r'.*\.cc$', r'.*\.cpp$', r'.*\.h$', r'.*\.m$', r'.*\.mm$',
69 r'.*\.inl$', r'.*\.asm$', r'.*\.hxx$', r'.*\.hpp$', r'.*\.s$', r'.*\.S$',
Mike Frysingerae409522014-02-01 03:16:11 -050070 # Scripts
Mike Frysinger24dd3c52019-08-17 14:22:48 -040071 r'.*\.js$', r'.*\.py$', r'.*\.sh$', r'.*\.rb$', r'.*\.pl$', r'.*\.pm$',
Bob Haarman0dc1f942020-10-03 00:06:59 +000072 # No extension at all, note that ALL CAPS files are excluded by
Mike Frysingerae409522014-02-01 03:16:11 -050073 # COMMON_EXCLUDED_LIST below.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040074 r'(^|.*[\\\/])[^.]+$',
Mike Frysingerae409522014-02-01 03:16:11 -050075 # Other
Mike Frysinger24dd3c52019-08-17 14:22:48 -040076 r'.*\.java$', r'.*\.mk$', r'.*\.am$',
77 r'.*\.policy$', r'.*\.conf$', r'.*\.go$',
78 r'(^OWNERS|/OWNERS)',
Ryan Cuiec4d6332011-05-02 14:15:25 -070079]
80
Ryan Cui1562fb82011-05-09 11:01:31 -070081
Ryan Cuiec4d6332011-05-02 14:15:25 -070082COMMON_EXCLUDED_PATHS = [
Daniel Erate3ea3fc2015-02-13 15:27:52 -070083 # For ebuild trees, ignore any caches and manifest data.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040084 r'.*/Manifest$',
85 r'.*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$',
Doug Anderson5bfb6792011-10-25 16:45:41 -070086
Daniel Erate3ea3fc2015-02-13 15:27:52 -070087 # Ignore profiles data (like overlay-tegra2/profiles).
Mike Frysinger24dd3c52019-08-17 14:22:48 -040088 r'(^|.*/)overlay-.*/profiles/.*',
89 r'^profiles/.*$',
Mike Frysinger98638102014-08-28 00:15:08 -040090
C Shapiro8f90e9b2017-06-28 09:54:50 -060091 # Ignore config files in ebuild setup.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040092 r'(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*',
93 r'^chromeos-base/chromeos-bsp.*/files/.*',
C Shapiro8f90e9b2017-06-28 09:54:50 -060094
Daniel Erate3ea3fc2015-02-13 15:27:52 -070095 # Ignore minified js and jquery.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040096 r'.*\.min\.js',
97 r'.*jquery.*\.js',
Mike Frysinger33a458d2014-03-03 17:00:51 -050098
99 # Ignore license files as the content is often taken verbatim.
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400100 r'.*/licenses/.*',
Alex Klein619c0912019-01-30 17:13:23 -0700101
Mike Frysinger13650402019-07-31 14:31:46 -0400102 # Exclude generated protobuf bindings.
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400103 r'.*_pb2\.py$',
104 r'.*\.pb\.go$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700105]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700106
Ken Turnerd07564b2018-02-08 17:57:59 +1100107LICENSE_EXCLUDED_PATHS = [
LaMont Jones775c2b32020-02-19 17:32:54 -0700108 r'^(.*/)?OWNERS(\..*)?$',
Ken Turnerd07564b2018-02-08 17:57:59 +1100109]
Ryan Cui1562fb82011-05-09 11:01:31 -0700110
Ryan Cui9b651632011-05-11 11:38:58 -0700111_CONFIG_FILE = 'PRESUBMIT.cfg'
112
113
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700114# File containing wildcards, one per line, matching files that should be
115# excluded from presubmit checks. Lines beginning with '#' are ignored.
116_IGNORE_FILE = '.presubmitignore'
117
Cheng Yuehb707c522020-01-02 14:06:59 +0800118
119TEST_FIELD_RE = r'\nTEST=\S+'
120
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700121BLOCKED_TERMS_FILE = 'blocked_terms.txt'
122UNBLOCKED_TERMS_FILE = 'unblocked_terms.txt'
123
Doug Anderson44a644f2011-11-02 10:37:37 -0700124# Exceptions
125
126
127class BadInvocation(Exception):
128 """An Exception indicating a bad invocation of the program."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700129
130
Ryan Cui1562fb82011-05-09 11:01:31 -0700131# General Helpers
132
Sean Paulba01d402011-05-05 11:36:23 -0400133
Mike Frysingerb2496652019-09-12 23:35:46 -0400134class Cache(object):
135 """General helper for caching git content."""
136
137 def __init__(self):
138 self._cache = {}
139
140 def get_subcache(self, scope):
141 return self._cache.setdefault(scope, {})
142
143 def clear(self):
144 self._cache.clear()
145
146CACHE = Cache()
147
148
Alex Deymo643ac4c2015-09-03 10:40:50 -0700149Project = collections.namedtuple('Project', ['name', 'dir', 'remote'])
150
151
Mike Frysinger526a5f82019-09-13 18:05:30 -0400152def _run_command(cmd, **kwargs):
Doug Anderson44a644f2011-11-02 10:37:37 -0700153 """Executes the passed in command and returns raw stdout output.
154
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400155 This is a convenience func to set some run defaults differently.
Mike Frysinger526a5f82019-09-13 18:05:30 -0400156
Doug Anderson44a644f2011-11-02 10:37:37 -0700157 Args:
158 cmd: The command to run; should be a list of strings.
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400159 **kwargs: Same as cros_build_lib.run.
Doug Anderson44a644f2011-11-02 10:37:37 -0700160
161 Returns:
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700162 The stdout from the process (discards stderr and returncode).
Doug Anderson44a644f2011-11-02 10:37:37 -0700163 """
Mike Frysinger526a5f82019-09-13 18:05:30 -0400164 kwargs.setdefault('print_cmd', False)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400165 kwargs.setdefault('stdout', True)
166 kwargs.setdefault('check', False)
Mike Frysinger054c1592019-11-18 03:51:54 -0500167 result = cros_build_lib.run(cmd, **kwargs)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400168 # NB: We decode this directly rather than through kwargs as our tests rely
169 # on this post-processing behavior currently.
Mike Frysinger71e643e2019-09-13 17:26:39 -0400170 return result.output.decode('utf-8', 'replace')
Ryan Cui72834d12011-05-05 14:51:33 -0700171
Ryan Cui1562fb82011-05-09 11:01:31 -0700172
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700173def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700174 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700175 if __name__ == '__main__':
176 # Works when file is run on its own (__file__ is defined)...
177 return os.path.abspath(os.path.dirname(__file__))
178 else:
179 # We need to do this when we're run through repo. Since repo executes
180 # us with execfile(), we don't get __file__ defined.
181 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
182 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700183
Ryan Cui1562fb82011-05-09 11:01:31 -0700184
Ryan Cuiec4d6332011-05-02 14:15:25 -0700185def _match_regex_list(subject, expressions):
186 """Try to match a list of regular expressions to a string.
187
188 Args:
189 subject: The string to match regexes on
190 expressions: A list of regular expressions to check for matches with.
191
192 Returns:
193 Whether the passed in subject matches any of the passed in regexes.
194 """
195 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500196 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700197 return True
198 return False
199
Ryan Cui1562fb82011-05-09 11:01:31 -0700200
Mike Frysingerae409522014-02-01 03:16:11 -0500201def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700202 """Filter out files based on the conditions passed in.
203
204 Args:
205 files: list of filepaths to filter
206 include_list: list of regex that when matched with a file path will cause it
207 to be added to the output list unless the file is also matched with a
208 regex in the exclude_list.
209 exclude_list: list of regex that when matched with a file will prevent it
210 from being added to the output list, even if it is also matched with a
211 regex in the include_list.
212
213 Returns:
214 A list of filepaths that contain files matched in the include_list and not
215 in the exclude_list.
216 """
217 filtered = []
218 for f in files:
219 if (_match_regex_list(f, include_list) and
220 not _match_regex_list(f, exclude_list)):
221 filtered.append(f)
222 return filtered
223
Ryan Cuiec4d6332011-05-02 14:15:25 -0700224
225# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700226
227
Ryan Cui4725d952011-05-05 15:41:19 -0700228def _get_upstream_branch():
229 """Returns the upstream tracking branch of the current branch.
230
231 Raises:
232 Error if there is no tracking branch
233 """
234 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
235 current_branch = current_branch.replace('refs/heads/', '')
236 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700237 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700238
239 cfg_option = 'branch.' + current_branch + '.%s'
240 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
241 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
242 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700243 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700244
245 return full_upstream.replace('heads', 'remotes/' + remote)
246
Ryan Cui1562fb82011-05-09 11:01:31 -0700247
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700248def _get_patch(commit):
249 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700250 if commit == PRE_SUBMIT:
251 return _run_command(['git', 'diff', '--cached', 'HEAD'])
252 else:
253 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700254
Ryan Cui1562fb82011-05-09 11:01:31 -0700255
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500256def _get_file_content(path, commit):
257 """Returns the content of a file at a specific commit.
258
259 We can't rely on the file as it exists in the filesystem as people might be
260 uploading a series of changes which modifies the file multiple times.
261
262 Note: The "content" of a symlink is just the target. So if you're expecting
263 a full file, you should check that first. One way to detect is that the
264 content will not have any newlines.
265 """
Mike Frysingerb2496652019-09-12 23:35:46 -0400266 # Make sure people don't accidentally pass in full paths which will never
267 # work. You need to use relative=True with _get_affected_files.
268 if path.startswith('/'):
269 raise ValueError('_get_file_content must be called with relative paths: %s'
270 % (path,))
271
272 # {<commit>: {<path1>: <content>, <path2>: <content>}}
273 cache = CACHE.get_subcache('get_file_content')
274 if path in cache:
275 return cache[path]
276
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700277 if commit == PRE_SUBMIT:
Yu-Ping Wue3e47362020-09-22 15:54:40 +0800278 content = _run_command(['git', 'diff', 'HEAD', '--', path])
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700279 else:
Mike Frysingerb2496652019-09-12 23:35:46 -0400280 content = _run_command(['git', 'show', '%s:%s' % (commit, path)])
281 cache[path] = content
282 return content
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500283
284
Mike Frysingerae409522014-02-01 03:16:11 -0500285def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700286 """Returns a list of (linenum, lines) tuples that the commit touched."""
Mike Frysingerb2496652019-09-12 23:35:46 -0400287 # {<commit>: {<path1>: <content>, <path2>: <content>}}
288 cache = CACHE.get_subcache('get_file_diff')
289 if path in cache:
290 return cache[path]
291
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700292 if commit == PRE_SUBMIT:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800293 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD',
Yu-Ping Wue3e47362020-09-22 15:54:40 +0800294 '--', path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700295 else:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800296 command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit,
Yu-Ping Wue3e47362020-09-22 15:54:40 +0800297 '--', path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700298 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700299
300 new_lines = []
301 line_num = 0
302 for line in output.splitlines():
303 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
304 if m:
305 line_num = int(m.groups(1)[0])
306 continue
307 if line.startswith('+') and not line.startswith('++'):
Mike Frysinger71e643e2019-09-13 17:26:39 -0400308 new_lines.append((line_num, line[1:]))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700309 if not line.startswith('-'):
310 line_num += 1
Mike Frysingerb2496652019-09-12 23:35:46 -0400311 cache[path] = new_lines
Ryan Cuiec4d6332011-05-02 14:15:25 -0700312 return new_lines
313
Ryan Cui1562fb82011-05-09 11:01:31 -0700314
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700315def _get_ignore_wildcards(directory, cache):
316 """Get wildcards listed in a directory's _IGNORE_FILE.
317
318 Args:
319 directory: A string containing a directory path.
320 cache: A dictionary (opaque to caller) caching previously-read wildcards.
321
322 Returns:
323 A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE
324 wasn't present.
325 """
326 # In the cache, keys are directories and values are lists of wildcards from
327 # _IGNORE_FILE within those directories (and empty if no file was present).
328 if directory not in cache:
329 wildcards = []
330 dotfile_path = os.path.join(directory, _IGNORE_FILE)
331 if os.path.exists(dotfile_path):
332 # TODO(derat): Consider using _get_file_content() to get the file as of
333 # this commit instead of the on-disk version. This may have a noticeable
334 # performance impact, as each call to _get_file_content() runs git.
335 with open(dotfile_path, 'r') as dotfile:
336 for line in dotfile.readlines():
337 line = line.strip()
338 if line.startswith('#'):
339 continue
340 if line.endswith('/'):
341 line += '*'
342 wildcards.append(line)
343 cache[directory] = wildcards
344
345 return cache[directory]
346
347
348def _path_is_ignored(path, cache):
349 """Check whether a path is ignored by _IGNORE_FILE.
350
351 Args:
352 path: A string containing a path.
353 cache: A dictionary (opaque to caller) caching previously-read wildcards.
354
355 Returns:
356 True if a file named _IGNORE_FILE in one of the passed-in path's parent
357 directories contains a wildcard matching the path.
358 """
359 # Skip ignore files.
360 if os.path.basename(path) == _IGNORE_FILE:
361 return True
362
363 path = os.path.abspath(path)
364 base = os.getcwd()
365
366 prefix = os.path.dirname(path)
367 while prefix.startswith(base):
368 rel_path = path[len(prefix) + 1:]
369 for wildcard in _get_ignore_wildcards(prefix, cache):
370 if fnmatch.fnmatch(rel_path, wildcard):
371 return True
372 prefix = os.path.dirname(prefix)
373
374 return False
375
376
Mike Frysinger292b45d2014-11-25 01:17:10 -0500377def _get_affected_files(commit, include_deletes=False, relative=False,
378 include_symlinks=False, include_adds=True,
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700379 full_details=False, use_ignore_files=True):
Peter Ammon811f6702014-06-12 15:45:38 -0700380 """Returns list of file paths that were modified/added, excluding symlinks.
381
382 Args:
383 commit: The commit
384 include_deletes: If true, we'll include deleted files in the result
385 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500386 include_symlinks: If true, we'll include symlinks in the result
387 include_adds: If true, we'll include new files in the result
388 full_details: If False, return filenames, else return structured results.
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700389 use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files.
Peter Ammon811f6702014-06-12 15:45:38 -0700390
391 Returns:
392 A list of modified/added (and perhaps deleted) files
393 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500394 if not relative and full_details:
395 raise ValueError('full_details only supports relative paths currently')
396
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700397 if commit == PRE_SUBMIT:
398 return _run_command(['git', 'diff-index', '--cached',
399 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500400
401 path = os.getcwd()
Mike Frysingerb2496652019-09-12 23:35:46 -0400402 # {<commit>: {<path1>: <content>, <path2>: <content>}}
403 cache = CACHE.get_subcache('get_affected_files')
404 if path not in cache:
405 cache[path] = git.RawDiff(path, '%s^!' % commit)
406 files = cache[path]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500407
408 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500409 if not include_symlinks:
410 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500411
412 if not include_deletes:
413 files = [x for x in files if x.status != 'D']
414
Mike Frysinger292b45d2014-11-25 01:17:10 -0500415 if not include_adds:
416 files = [x for x in files if x.status != 'A']
417
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700418 if use_ignore_files:
419 cache = {}
420 is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache)
421 files = [x for x in files if not is_ignored(x)]
422
Mike Frysinger292b45d2014-11-25 01:17:10 -0500423 if full_details:
424 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500425 return files
426 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500427 # Caller only cares about filenames.
428 files = [x.dst_file if x.dst_file else x.src_file for x in files]
429 if relative:
430 return files
431 else:
432 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700433
434
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700435def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700436 """Returns a list of commits for this review."""
Mike Frysingere300c7d2019-09-12 23:33:52 -0400437 cmd = ['git', 'log', '--no-merges', '--format=%H',
438 '%s..' % _get_upstream_branch()]
Ryan Cui72834d12011-05-05 14:51:33 -0700439 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700440
Ryan Cui1562fb82011-05-09 11:01:31 -0700441
Ryan Cuiec4d6332011-05-02 14:15:25 -0700442def _get_commit_desc(commit):
443 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700444 if commit == PRE_SUBMIT:
445 return ''
Mike Frysingerb2496652019-09-12 23:35:46 -0400446
447 # {<commit>: <content>}
448 cache = CACHE.get_subcache('get_commit_desc')
449 if commit not in cache:
Mike Frysinger4efdee72019-11-04 10:57:01 -0500450 cache[commit] = _run_command(['git', 'log', '--format=%B',
Mike Frysingerb2496652019-09-12 23:35:46 -0400451 commit + '^!'])
452 return cache[commit]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700453
454
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800455def _check_lines_in_diff(commit, files, check_callable, error_description):
456 """Checks given file for errors via the given check.
457
458 This is a convenience function for common per-line checks. It goes through all
459 files and returns a HookFailure with the error description listing all the
460 failures.
461
462 Args:
463 commit: The commit we're working on.
464 files: The files to check.
465 check_callable: A callable that takes a line and returns True if this line
466 _fails_ the check.
467 error_description: A string describing the error.
468 """
469 errors = []
470 for afile in files:
471 for line_num, line in _get_file_diff(afile, commit):
Bernie Thompson8e26f742020-07-23 14:32:31 -0700472 result = check_callable(line)
473 if result:
474 msg = f'{afile}, line {line_num}'
475 if isinstance(result, str):
476 msg += f': {result}'
477 errors.append(msg)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800478 if errors:
479 return HookFailure(error_description, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400480 return None
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800481
482
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900483def _parse_common_inclusion_options(options):
484 """Parses common hook options for including/excluding files.
485
486 Args:
487 options: Option string list.
488
489 Returns:
490 (included, excluded) where each one is a list of regex strings.
491 """
492 parser = argparse.ArgumentParser()
493 parser.add_argument('--exclude_regex', action='append')
494 parser.add_argument('--include_regex', action='append')
495 opts = parser.parse_args(options)
496 included = opts.include_regex or []
497 excluded = opts.exclude_regex or []
498 return included, excluded
499
500
Ryan Cuiec4d6332011-05-02 14:15:25 -0700501# Common Hooks
502
Ryan Cui1562fb82011-05-09 11:01:31 -0700503
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900504def _check_no_long_lines(_project, commit, options=()):
Mike Frysinger55f85b52014-12-18 14:45:21 -0500505 """Checks there are no lines longer than MAX_LEN in any of the text files."""
Keigo Oka9732e382019-06-28 17:44:59 +0900506 LONG_LINE_OK_PATHS = [
507 # Go has no line length limit.
508 # https://golang.org/doc/effective_go.html#formatting
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400509 r'.*\.go$',
Mike Frysingerf8961942020-05-15 00:36:31 -0400510 # Python does its own long line checks via pylint.
511 r'.*\.py$',
Keigo Oka9732e382019-06-28 17:44:59 +0900512 ]
Mike Frysinger55f85b52014-12-18 14:45:21 -0500513
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900514 DEFAULT_MAX_LENGTHS = [
515 # Java's line length limit is 100 chars.
516 # https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md
517 (r'.*\.java$', 100),
Mike Frysingerf8961942020-05-15 00:36:31 -0400518 # Rust's line length limit is 100 chars.
519 (r'.*\.rs$', 100),
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900520 ]
521
Ryan Cuiec4d6332011-05-02 14:15:25 -0700522 MAX_LEN = 80
523
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900524 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700525 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900526 included + COMMON_INCLUDED_PATHS,
Keigo Oka9732e382019-06-28 17:44:59 +0900527 excluded + COMMON_EXCLUDED_PATHS + LONG_LINE_OK_PATHS)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700528
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900529 errors = []
Ryan Cuiec4d6332011-05-02 14:15:25 -0700530 for afile in files:
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700531 skip_regexps = (
532 r'https?://',
533 r'^#\s*(define|include|import|pragma|if|ifndef|endif)\b',
534 )
535
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900536 max_len = MAX_LEN
537
538 for expr, length in DEFAULT_MAX_LENGTHS:
539 if re.search(expr, afile):
540 max_len = length
541 break
542
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700543 if os.path.basename(afile).startswith('OWNERS'):
544 # File paths can get long, and there's no way to break them up into
545 # multiple lines.
546 skip_regexps += (
547 r'^include\b',
548 r'file:',
549 )
550
551 skip_regexps = [re.compile(x) for x in skip_regexps]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700552 for line_num, line in _get_file_diff(afile, commit):
553 # Allow certain lines to exceed the maxlen rule.
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900554 if len(line) <= max_len or any(x.search(line) for x in skip_regexps):
Jon Salz98255932012-08-18 14:48:02 +0800555 continue
556
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900557 errors.append('%s, line %s, %s chars, over %s chars' %
558 (afile, line_num, len(line), max_len))
Jon Salz98255932012-08-18 14:48:02 +0800559 if len(errors) == 5: # Just show the first 5 errors.
560 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700561
562 if errors:
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900563 msg = 'Found lines longer than the limit (first 5 shown):'
Ryan Cui1562fb82011-05-09 11:01:31 -0700564 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400565 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700566
Ryan Cuiec4d6332011-05-02 14:15:25 -0700567
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900568def _check_no_stray_whitespace(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700569 """Checks that there is no stray whitespace at source lines end."""
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900570 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700571 files = _filter_files(_get_affected_files(commit),
Tomasz Figa375b9622020-09-22 14:25:07 +0000572 included + COMMON_INCLUDED_PATHS + [r'^.*\.md$'],
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900573 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800574 return _check_lines_in_diff(commit, files,
575 lambda line: line.rstrip() != line,
576 'Found line ending with white space in:')
Ryan Cui1562fb82011-05-09 11:01:31 -0700577
Ryan Cuiec4d6332011-05-02 14:15:25 -0700578
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900579def _check_no_tabs(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700580 """Checks there are no unexpanded tabs."""
Mike Frysingercd134512017-10-26 04:36:33 -0400581 # Don't add entire repos here. Update the PRESUBMIT.cfg in each repo instead.
Bob Haarman0dc1f942020-10-03 00:06:59 +0000582 # We only allow known specific filetypes here that show up in all repos.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700583 TAB_OK_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400584 r'.*\.ebuild$',
585 r'.*\.eclass$',
586 r'.*\.go$',
587 r'.*/[M|m]akefile$',
588 r'.*\.mk$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700589 ]
590
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900591 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700592 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900593 included + COMMON_INCLUDED_PATHS,
594 excluded + COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800595 return _check_lines_in_diff(commit, files,
596 lambda line: '\t' in line,
597 'Found a tab character in:')
Ryan Cuiec4d6332011-05-02 14:15:25 -0700598
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800599
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700600def _read_terms_file(terms_file):
601 """Read list of words from file, skipping comments and blank lines."""
602 file_terms = set()
603 for line in osutils.ReadFile(terms_file).splitlines():
604 # Allow comment and blank lines.
605 line = line.split('#', 1)[0]
606 if not line:
607 continue
608 file_terms.add(line)
609 return file_terms
610
611
Bernie Thompson8e26f742020-07-23 14:32:31 -0700612def _check_keywords(_project, commit, options=()):
613 """Checks there are no blocked keywords in commit content."""
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700614 # Read options from override list.
Bernie Thompson8e26f742020-07-23 14:32:31 -0700615 parser = argparse.ArgumentParser()
616 parser.add_argument('--exclude_regex', action='append', default=[])
617 parser.add_argument('--include_regex', action='append', default=[])
618 parser.add_argument('--block', action='append', default=[])
619 parser.add_argument('--unblock', action='append', default=[])
620 opts = parser.parse_args(options)
621
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700622 # Read blocked word list.
623 blocked_terms_file = os.path.join(_get_hooks_dir(), BLOCKED_TERMS_FILE)
624 common_keywords = _read_terms_file(blocked_terms_file)
625
626 # Read unblocked word list. Global list is skipped if local list exists.
627 unblocked_terms_file = os.path.join(_get_hooks_dir(), UNBLOCKED_TERMS_FILE)
628 if os.path.isfile(os.path.join(_project.dir, UNBLOCKED_TERMS_FILE)):
629 unblocked_terms_file = os.path.join(_project.dir, UNBLOCKED_TERMS_FILE)
630 unblocked_words = _read_terms_file(unblocked_terms_file)
631 unblocked_words.update(opts.unblock)
632
Bernie Thompson8e26f742020-07-23 14:32:31 -0700633 keywords = set(common_keywords | set(opts.block))
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700634 keywords = sorted(keywords - unblocked_words)
Mike Frysinger6140f572020-09-10 04:52:46 -0400635 files = _filter_files(
636 _get_affected_files(commit),
Tomasz Figa375b9622020-09-22 14:25:07 +0000637 opts.include_regex + COMMON_INCLUDED_PATHS + [r'^.*\.md$'],
Mike Frysinger6140f572020-09-10 04:52:46 -0400638 opts.exclude_regex + COMMON_EXCLUDED_PATHS)
Bernie Thompson8e26f742020-07-23 14:32:31 -0700639 errors = []
640
641 def _check_line(line):
Laurent Chavey434af9a2020-09-28 22:25:16 +0900642 # Store information about each span matching blocking regex.
643 # to match unblocked regex with blocked reg ex match.
644 # [{'span':re.span, - overlap of matching regex in line
645 # 'group':re.group, - matching term
646 # 'blocked':bool, - True: matching blocked, False: matching unblocked
647 # 'keyword':regex, - block regex
648 # }, ...]
649 blocked_span = []
650 # Store information about each span matching unblocking regex.
651 # [re.span, ...]
652 unblocked_span = []
653
Bernie Thompson8e26f742020-07-23 14:32:31 -0700654 for word in keywords:
Laurent Chavey434af9a2020-09-28 22:25:16 +0900655 for match in re.finditer(word, line, flags=re.I):
656 blocked_span.append({'span' : match.span(),
657 'group' : match.group(0),
658 'blocked' : True,
659 'keyword' : word})
660
661 for unblocked in unblocked_words:
662 for match in re.finditer(unblocked, line, flags=re.I):
663 unblocked_span.append(match.span())
664
665 # Unblock terms that are superset of blocked terms:
666 # blocked := "this.?word"
667 # unblocked := "\.this.?word"
668 # "this line is blocked because of this1word"
669 # "this line is unblocked because of thenew.this1word"
670 #
671 for b in blocked_span:
672 for ub in unblocked_span:
673 if ub[0] <= b['span'][0] and ub[1] >= b['span'][1]:
674 b['blocked'] = False
675 if b['blocked']:
676 return f'Matched "{b["group"]}" with regex of "{b["keyword"]}"'
Bernie Thompson8e26f742020-07-23 14:32:31 -0700677 return False
678
679 diff_errors = _check_lines_in_diff(commit, files, _check_line,
680 'Found a blocked keyword in:')
681 if diff_errors:
682 errors.append(diff_errors)
683
684 line_num = 1
685 commit_desc_errors = []
686 for line in _get_commit_desc(commit).splitlines():
687 result = _check_line(line)
688 if result:
689 commit_desc_errors.append('Commit message, line %s: %s' %
690 (line_num, result))
691 line_num += 1
692 if commit_desc_errors:
693 errors.append(HookFailure('Found a blocked keyword in:',
694 commit_desc_errors))
695 return errors
696
697
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900698def _check_tabbed_indents(_project, commit, options=()):
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800699 """Checks that indents use tabs only."""
700 TABS_REQUIRED_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400701 r'.*\.ebuild$',
702 r'.*\.eclass$',
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800703 ]
704 LEADING_SPACE_RE = re.compile('[\t]* ')
705
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900706 included, excluded = _parse_common_inclusion_options(options)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800707 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900708 included + TABS_REQUIRED_PATHS,
709 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800710 return _check_lines_in_diff(
711 commit, files,
712 lambda line: LEADING_SPACE_RE.match(line) is not None,
713 'Found a space in indentation (must be all tabs):')
Ryan Cui1562fb82011-05-09 11:01:31 -0700714
Ryan Cuiec4d6332011-05-02 14:15:25 -0700715
LaMont Jones872fe762020-02-10 15:36:14 -0700716def _check_gofmt(_project, commit, options=()):
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700717 """Checks that Go files are formatted with gofmt."""
LaMont Jones872fe762020-02-10 15:36:14 -0700718 included, excluded = _parse_common_inclusion_options(options)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700719 errors = []
720 files = _filter_files(_get_affected_files(commit, relative=True),
LaMont Jones872fe762020-02-10 15:36:14 -0700721 included + [r'\.go$'],
722 excluded)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700723
724 for gofile in files:
725 contents = _get_file_content(gofile, commit)
Mike Frysingeraa7dc942019-09-25 00:07:24 -0400726 output = _run_command(cmd=['gofmt', '-l'], input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500727 stderr=subprocess.STDOUT)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700728 if output:
729 errors.append(gofile)
730 if errors:
731 return HookFailure('Files not formatted with gofmt:', errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400732 return None
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700733
734
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600735def _check_rustfmt(_project, commit):
736 """Checks that Rust files are formatted with rustfmt."""
737 errors = []
738 files = _filter_files(_get_affected_files(commit, relative=True),
739 [r'\.rs$'])
740
741 for rustfile in files:
742 contents = _get_file_content(rustfile, commit)
Chirantan Ekbote1da56d52020-07-13 17:35:35 +0900743 output = _run_command(cmd=['rustfmt', '--edition', '2018'],
744 input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500745 stderr=subprocess.STDOUT)
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600746 if output != contents:
747 errors.append(rustfile)
748 if errors:
749 return HookFailure('Files not formatted with rustfmt: '
750 "(run 'cargo fmt' to fix)", errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400751 return None
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600752
753
Keiichi Watanabe6ab73fd2020-07-14 23:42:02 +0900754class CargoClippyArgumentParserError(Exception):
755 """An exception indicating an invalid check_cargo_clippy option."""
756
757
758class CargoClippyArgumentParser(argparse.ArgumentParser):
759 """A argument parser for check_cargo_clippy."""
760
761 def error(self, message):
762 raise CargoClippyArgumentParserError(message)
763
764
765# A cargo project in which clippy runs.
766ClippyProject = collections.namedtuple('ClippyProject', ('root', 'script'))
767
768
769class _AddClippyProjectAction(argparse.Action):
770 """A callback that adds a cargo clippy setting.
771
772 It accepts a value which is in the form of "ROOT[:SCRIPT]".
773 """
774
775 def __call__(self, parser, namespace, values, option_string=None):
776 if getattr(namespace, self.dest, None) is None:
777 setattr(namespace, self.dest, [])
778 spec = values.split(':', 1)
779 if len(spec) == 1:
780 spec += [None]
781
782 if spec[0].startswith('/'):
783 raise CargoClippyArgumentParserError('root path must not start with "/"'
784 f' but "{spec[0]}"')
785
786 clippy = ClippyProject(root=spec[0], script=spec[1])
787 getattr(namespace, self.dest).append(clippy)
788
789
790def _get_cargo_clippy_parser():
791 """Creates a parser for check_cargo_clippy options."""
792
793 parser = CargoClippyArgumentParser()
794 parser.add_argument('--project', action=_AddClippyProjectAction, default=[])
795
796 return parser
797
798
799def _check_cargo_clippy(project, commit, options=()):
800 """Checks that a change doesn't produce cargo-clippy errors."""
801
802 options = list(options)
803 if not options:
804 return []
805 parser = _get_cargo_clippy_parser()
806
807 try:
808 opts = parser.parse_args(options)
809 except CargoClippyArgumentParserError as e:
810 return [HookFailure('invalid check_cargo_clippy option is given.'
811 f' Please check PRESUBMIT.cfg is correct: {e}')]
812 files = _get_affected_files(commit)
813
814 errors = []
815 for clippy in opts.project:
816 root = os.path.normpath(os.path.join(project.dir, clippy.root))
817
818 # Check if any file under `root` was modified.
819 modified = False
820 for f in files:
821 if f.startswith(root):
822 modified = True
823 break
824 if not modified:
825 continue
826
827 # Clean cargo's cache when we run clippy for this `root` for the first time.
828 # We don't want to clean the cache between commits to save time when
829 # multiple commits are checked.
830 if root not in _check_cargo_clippy.cleaned_root:
831 _run_command(['cargo', 'clean',
832 f'--manifest-path={root}/Cargo.toml'],
833 stderr=subprocess.STDOUT)
834 _check_cargo_clippy.cleaned_root.add(root)
835
836 cmd = ['cargo', 'clippy', '--all-features', '--all-targets',
837 f'--manifest-path={root}/Cargo.toml',
838 '--', '-D', 'warnings']
839 # Overwrite the clippy command if a project-specific script is specified.
840 if clippy.script:
841 cmd = [os.path.join(project.dir, clippy.script)]
842
843 output = _run_command(cmd, stderr=subprocess.STDOUT)
844 error = re.search(r'^error: ', output, flags=re.MULTILINE)
845 if error:
846 msg = output[error.start():]
847 errors.append(HookFailure(msg))
848
849 return errors
850
851
852# Stores cargo projects in which `cargo clean` ran.
853_check_cargo_clippy.cleaned_root = set()
854
855
Mike Frysingerae409522014-02-01 03:16:11 -0500856def _check_change_has_test_field(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700857 """Check for a non-empty 'TEST=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500858 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700859
Cheng Yuehb707c522020-01-02 14:06:59 +0800860 if not re.search(TEST_FIELD_RE, _get_commit_desc(commit)):
Mike Frysingered9b2a02019-12-12 18:52:32 -0500861 msg = ('Changelist description needs TEST field (after first line)\n%s' %
862 (SEE_ALSO,))
Ryan Cui1562fb82011-05-09 11:01:31 -0700863 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400864 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700865
Ryan Cuiec4d6332011-05-02 14:15:25 -0700866
Mike Frysingerae409522014-02-01 03:16:11 -0500867def _check_change_has_valid_cq_depend(_project, commit):
Jason D. Clinton299e3222019-05-23 09:42:03 -0600868 """Check for a correctly formatted Cq-Depend field in the commit message."""
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700869 desc = _get_commit_desc(commit)
Jason D. Clinton299e3222019-05-23 09:42:03 -0600870 msg = 'Changelist has invalid Cq-Depend target.'
871 example = 'Example: Cq-Depend: chromium:1234, chrome-internal:2345'
David Jamesc3b68b32013-04-03 09:17:03 -0700872 try:
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700873 patch.GetPaladinDeps(desc)
David Jamesc3b68b32013-04-03 09:17:03 -0700874 except ValueError as ex:
875 return HookFailure(msg, [example, str(ex)])
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700876 # Check that Cq-Depend is in the same paragraph as Change-Id.
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500877 msg = 'Cq-Depend is not in the same paragraph as Change-Id.'
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700878 paragraphs = desc.split('\n\n')
879 for paragraph in paragraphs:
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500880 if (re.search(r'^Cq-Depend:', paragraph, re.M) and not
881 re.search('^Change-Id:', paragraph, re.M)):
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700882 return HookFailure(msg)
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500883
884 # We no longer support CQ-DEPEND= lines.
885 if re.search(r'^CQ-DEPEND[=:]', desc, re.M):
886 return HookFailure(
887 'CQ-DEPEND= is no longer supported. Please see:\n'
888 'https://chromium.googlesource.com/chromiumos/docs/+/HEAD/'
889 'contributing.md#CQ-DEPEND')
890
Mike Frysinger8cf80812019-09-16 23:49:29 -0400891 return None
David Jamesc3b68b32013-04-03 09:17:03 -0700892
893
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800894def _check_change_is_contribution(_project, commit):
895 """Check that the change is a contribution."""
896 NO_CONTRIB = 'not a contribution'
897 if NO_CONTRIB in _get_commit_desc(commit).lower():
898 msg = ('Changelist is not a contribution, this cannot be accepted.\n'
899 'Please remove the "%s" text from the commit message.') % NO_CONTRIB
900 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400901 return None
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800902
903
Alex Deymo643ac4c2015-09-03 10:40:50 -0700904def _check_change_has_bug_field(project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700905 """Check for a correctly formatted 'BUG=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500906 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
907
David James5c0073d2013-04-03 08:48:52 -0700908 OLD_BUG_RE = r'\nBUG=.*chromium-os'
909 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
910 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
911 'the chromium tracker in your BUG= line now.')
912 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700913
Alex Deymo643ac4c2015-09-03 10:40:50 -0700914 # Android internal and external projects use "Bug: " to track bugs in
915 # buganizer.
916 BUG_COLON_REMOTES = (
917 'aosp',
918 'goog',
919 )
920 if project.remote in BUG_COLON_REMOTES:
921 BUG_RE = r'\nBug: ?([Nn]one|\d+)'
922 if not re.search(BUG_RE, _get_commit_desc(commit)):
923 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500924 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700925 'Bug: 9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500926 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700927 return HookFailure(msg)
928 else:
Jorge Lucangeli Obesdce214e2017-10-25 15:04:39 -0400929 BUG_RE = r'\nBUG=([Nn]one|(chromium|b):\d+)'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700930 if not re.search(BUG_RE, _get_commit_desc(commit)):
931 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500932 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700933 'BUG=chromium:9999 (for public tracker)\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700934 'BUG=b:9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500935 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700936 return HookFailure(msg)
Ryan Cui1562fb82011-05-09 11:01:31 -0700937
Cheng Yuehb707c522020-01-02 14:06:59 +0800938 TEST_BEFORE_BUG_RE = TEST_FIELD_RE + r'.*' + BUG_RE
939
940 if re.search(TEST_BEFORE_BUG_RE, _get_commit_desc(commit), re.DOTALL):
941 msg = ('The BUG field must come before the TEST field.\n%s' %
942 (SEE_ALSO,))
943 return HookFailure(msg)
944
Mike Frysinger8cf80812019-09-16 23:49:29 -0400945 return None
946
Ryan Cuiec4d6332011-05-02 14:15:25 -0700947
Jack Neus8edbf642019-07-10 16:08:31 -0600948def _check_change_no_include_oem(project, commit):
949 """Check that the change does not reference OEMs."""
950 ALLOWLIST = {
951 'chromiumos/platform/ec',
952 # Used by unit tests.
953 'project',
954 }
955 if project.name not in ALLOWLIST:
956 return None
957
Mike Frysingerbb34a222019-07-31 14:40:46 -0400958 TAGS = {
Jack Neus8edbf642019-07-10 16:08:31 -0600959 'Reviewed-on',
960 'Reviewed-by',
961 'Signed-off-by',
962 'Commit-Ready',
963 'Tested-by',
964 'Commit-Queue',
Jack Neus8edbf642019-07-10 16:08:31 -0600965 'Acked-by',
966 'Modified-by',
967 'CC',
968 'Suggested-by',
969 'Reported-by',
970 'Acked-for-chrome-by',
LaMont Jones237f3ef2020-01-22 10:40:52 -0700971 'Cq-Cl-Tag',
LaMont Jonesfb5e8bf2020-03-03 12:50:06 -0700972 'Cq-Include-Trybots',
Mike Frysingerbb34a222019-07-31 14:40:46 -0400973 }
Jack Neus8edbf642019-07-10 16:08:31 -0600974
975 # Ignore tags, which could reasonably contain OEM names
976 # (e.g. Reviewed-by: foo@oem.corp-partner.google.com).
Jack Neus8edbf642019-07-10 16:08:31 -0600977 commit_message = ' '.join(
Mike Frysingerbb34a222019-07-31 14:40:46 -0400978 x for x in _get_commit_desc(commit).splitlines()
979 if ':' not in x or x.split(':', 1)[0] not in TAGS)
980
Jack Neus8edbf642019-07-10 16:08:31 -0600981 commit_message = re.sub(r'[\s_-]+', ' ', commit_message)
982
983 # Exercise caution when expanding these lists. Adding a name
984 # could indicate a new relationship with a company!
985 OEMS = ['hp', 'hewlett packard', 'dell', 'lenovo', 'acer', 'asus', 'samsung']
986 ODMS = [
987 'bitland', 'compal', 'haier', 'huaqin', 'inventec', 'lg', 'pegatron',
988 'pegatron(ems)', 'quanta', 'samsung', 'wistron'
989 ]
990
991 for name_type, name_list in [('OEM', OEMS), ('ODM', ODMS)]:
992 # Construct regex
993 name_re = r'\b(%s)\b' % '|'.join([re.escape(x) for x in name_list])
994 matches = [x[0] for x in re.findall(name_re, commit_message, re.IGNORECASE)]
Mike Frysingere52b1bc2019-09-16 23:45:41 -0400995 if matches:
Jack Neus8edbf642019-07-10 16:08:31 -0600996 # If there's a match, throw an error.
997 error_msg = ('Changelist description contains the name of an'
998 ' %s: "%s".' % (name_type, '","'.join(matches)))
999 return HookFailure(error_msg)
1000
Mike Frysinger8cf80812019-09-16 23:49:29 -04001001 return None
1002
Jack Neus8edbf642019-07-10 16:08:31 -06001003
Mike Frysinger292b45d2014-11-25 01:17:10 -05001004def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -07001005 """Check that we're not missing a revbump of an ebuild in the given commit.
1006
1007 If the given commit touches files in a directory that has ebuilds somewhere
1008 up the directory hierarchy, it's very likely that we need an ebuild revbump
1009 in order for those changes to take effect.
1010
1011 It's not totally trivial to detect a revbump, so at least detect that an
1012 ebuild with a revision number in it was touched. This should handle the
1013 common case where we use a symlink to do the revbump.
1014
1015 TODO: it would be nice to enhance this hook to:
1016 * Handle cases where people revbump with a slightly different syntax. I see
1017 one ebuild (puppy) that revbumps with _pN. This is a false positive.
1018 * Catches cases where people aren't using symlinks for revbumps. If they
1019 edit a revisioned file directly (and are expected to rename it for revbump)
1020 we'll miss that. Perhaps we could detect that the file touched is a
1021 symlink?
1022
1023 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
1024 still better off than without this check.
1025
1026 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001027 project: The Project to look at
Doug Anderson42b8a052013-06-26 10:45:36 -07001028 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -05001029 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -07001030
1031 Returns:
1032 A HookFailure or None.
1033 """
Mike Frysinger011af942014-01-17 16:12:22 -05001034 # If this is the portage-stable overlay, then ignore the check. It's rare
1035 # that we're doing anything other than importing files from upstream, so
1036 # forcing a rev bump makes no sense.
Bob Haarman0dc1f942020-10-03 00:06:59 +00001037 allowlist = (
Mike Frysinger011af942014-01-17 16:12:22 -05001038 'chromiumos/overlays/portage-stable',
1039 )
Bob Haarman0dc1f942020-10-03 00:06:59 +00001040 if project.name in allowlist:
Mike Frysinger011af942014-01-17 16:12:22 -05001041 return None
1042
Mike Frysinger292b45d2014-11-25 01:17:10 -05001043 def FinalName(obj):
1044 # If the file is being deleted, then the dst_file is not set.
1045 if obj.dst_file is None:
1046 return obj.src_file
1047 else:
1048 return obj.dst_file
1049
1050 affected_path_objs = _get_affected_files(
1051 commit, include_deletes=True, include_symlinks=True, relative=True,
1052 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -07001053
Bob Haarman0dc1f942020-10-03 00:06:59 +00001054 # Don't yell about changes to allowed files...
1055 allowlist = {'ChangeLog', 'Manifest', 'metadata.xml'}
Mike Frysinger292b45d2014-11-25 01:17:10 -05001056 affected_path_objs = [x for x in affected_path_objs
Bob Haarman0dc1f942020-10-03 00:06:59 +00001057 if os.path.basename(FinalName(x)) not in allowlist]
Mike Frysinger292b45d2014-11-25 01:17:10 -05001058 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -07001059 return None
1060
1061 # If we've touched any file named with a -rN.ebuild then we'll say we're
1062 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -05001063 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
1064 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -07001065 if touched_revved_ebuild:
1066 return None
1067
Mike Frysinger292b45d2014-11-25 01:17:10 -05001068 # If we're creating new ebuilds from scratch, then we don't need an uprev.
1069 # Find all the dirs that new ebuilds and ignore their files/.
1070 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
1071 if FinalName(x).endswith('.ebuild') and x.status == 'A']
1072 affected_path_objs = [obj for obj in affected_path_objs
1073 if not any(FinalName(obj).startswith(x)
1074 for x in ebuild_dirs)]
1075 if not affected_path_objs:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001076 return None
Mike Frysinger292b45d2014-11-25 01:17:10 -05001077
Doug Anderson42b8a052013-06-26 10:45:36 -07001078 # We want to examine the current contents of all directories that are parents
1079 # of files that were touched (up to the top of the project).
1080 #
1081 # ...note: we use the current directory contents even though it may have
1082 # changed since the commit we're looking at. This is just a heuristic after
1083 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -05001084 if project_top is None:
1085 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -07001086 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -05001087 for obj in affected_path_objs:
1088 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -07001089 while os.path.exists(path) and not os.path.samefile(path, project_top):
1090 dirs_to_check.add(path)
1091 path = os.path.dirname(path)
1092
1093 # Look through each directory. If it's got an ebuild in it then we'll
1094 # consider this as a case when we need a revbump.
Gwendal Grignoua3086c32014-12-09 11:17:22 -08001095 affected_paths = set(os.path.join(project_top, FinalName(x))
1096 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -07001097 for dir_path in dirs_to_check:
1098 contents = os.listdir(dir_path)
1099 ebuilds = [os.path.join(dir_path, path)
1100 for path in contents if path.endswith('.ebuild')]
1101 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
1102
C Shapiroae157ae2017-09-18 16:24:03 -06001103 affected_paths_under_9999_ebuilds = set()
1104 for affected_path in affected_paths:
1105 for ebuild_9999 in ebuilds_9999:
1106 ebuild_dir = os.path.dirname(ebuild_9999)
1107 if affected_path.startswith(ebuild_dir):
1108 affected_paths_under_9999_ebuilds.add(affected_path)
1109
1110 # If every file changed exists under a 9999 ebuild, then skip
1111 if len(affected_paths_under_9999_ebuilds) == len(affected_paths):
1112 continue
1113
Doug Anderson42b8a052013-06-26 10:45:36 -07001114 # If the -9999.ebuild file was touched the bot will uprev for us.
1115 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -05001116 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -07001117 continue
1118
1119 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -05001120 return HookFailure('Changelist probably needs a revbump of an ebuild, '
1121 'or a -r1.ebuild symlink if this is a new ebuild:\n'
1122 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -07001123
1124 return None
1125
1126
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001127def _check_ebuild_eapi(project, commit):
Mike Frysinger948284a2018-02-01 15:22:56 -05001128 """Make sure we have people use EAPI=5 or newer with custom ebuilds.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001129
1130 We want to get away from older EAPI's as it makes life confusing and they
1131 have less builtin error checking.
1132
1133 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001134 project: The Project to look at
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001135 commit: The commit to look at
1136
1137 Returns:
1138 A HookFailure or None.
1139 """
1140 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -05001141 # that we're doing anything other than importing files from upstream, and
1142 # we shouldn't be rewriting things fundamentally anyways.
Bob Haarman0dc1f942020-10-03 00:06:59 +00001143 allowlist = (
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001144 'chromiumos/overlays/portage-stable',
1145 )
Bob Haarman0dc1f942020-10-03 00:06:59 +00001146 if project.name in allowlist:
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001147 return None
1148
Mike Frysinger948284a2018-02-01 15:22:56 -05001149 BAD_EAPIS = ('0', '1', '2', '3', '4')
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001150
1151 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
1152
1153 ebuilds_re = [r'\.ebuild$']
1154 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1155 ebuilds_re)
1156 bad_ebuilds = []
1157
1158 for ebuild in ebuilds:
1159 # If the ebuild does not specify an EAPI, it defaults to 0.
1160 eapi = '0'
1161
1162 lines = _get_file_content(ebuild, commit).splitlines()
1163 if len(lines) == 1:
1164 # This is most likely a symlink, so skip it entirely.
1165 continue
1166
1167 for line in lines:
1168 m = get_eapi.match(line)
1169 if m:
1170 # Once we hit the first EAPI line in this ebuild, stop processing.
1171 # The spec requires that there only be one and it be first, so
1172 # checking all possible values is pointless. We also assume that
1173 # it's "the" EAPI line and not something in the middle of a heredoc.
1174 eapi = m.group(1)
1175 break
1176
1177 if eapi in BAD_EAPIS:
1178 bad_ebuilds.append((ebuild, eapi))
1179
1180 if bad_ebuilds:
1181 # pylint: disable=C0301
Mike Frysingerc6114f42020-05-15 00:55:05 -04001182 url = 'https://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001183 # pylint: enable=C0301
1184 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -05001185 'These ebuilds are using old EAPIs. If these are imported from\n'
1186 'Gentoo, then you may ignore and upload once with the --no-verify\n'
Mike Frysingerc6114f42020-05-15 00:55:05 -04001187 'flag. Otherwise, please update to 7 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001188 '\t%s\n'
1189 'See this guide for more details:\n%s\n' %
1190 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
1191
Mike Frysinger8cf80812019-09-16 23:49:29 -04001192 return None
1193
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001194
Mike Frysinger89bdb852014-02-01 05:26:26 -05001195def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -05001196 """Make sure we use the new style KEYWORDS when possible in ebuilds.
1197
1198 If an ebuild generally does not care about the arch it is running on, then
1199 ebuilds should flag it with one of:
1200 KEYWORDS="*" # A stable ebuild.
1201 KEYWORDS="~*" # An unstable ebuild.
1202 KEYWORDS="-* ..." # Is known to only work on specific arches.
1203
1204 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001205 project: The Project to look at
Mike Frysingerc51ece72014-01-17 16:23:40 -05001206 commit: The commit to look at
1207
1208 Returns:
1209 A HookFailure or None.
1210 """
Bob Haarman0dc1f942020-10-03 00:06:59 +00001211 ALLOWLIST = set(('*', '-*', '~*'))
Mike Frysingerc51ece72014-01-17 16:23:40 -05001212
1213 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
1214
Mike Frysinger89bdb852014-02-01 05:26:26 -05001215 ebuilds_re = [r'\.ebuild$']
1216 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1217 ebuilds_re)
1218
Mike Frysinger8d42d742014-09-22 15:50:21 -04001219 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -05001220 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -04001221 # We get the full content rather than a diff as the latter does not work
1222 # on new files (like when adding new ebuilds).
1223 lines = _get_file_content(ebuild, commit).splitlines()
1224 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -05001225 m = get_keywords.match(line)
1226 if m:
1227 keywords = set(m.group(1).split())
Bob Haarman0dc1f942020-10-03 00:06:59 +00001228 if not keywords or ALLOWLIST - keywords != ALLOWLIST:
Mike Frysingerc51ece72014-01-17 16:23:40 -05001229 continue
1230
Mike Frysinger8d42d742014-09-22 15:50:21 -04001231 bad_ebuilds.append(ebuild)
1232
1233 if bad_ebuilds:
1234 return HookFailure(
1235 '%s\n'
1236 'Please update KEYWORDS to use a glob:\n'
1237 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
1238 ' KEYWORDS="*"\n'
1239 'If the ebuild should be marked unstable (normal for '
1240 'cros-workon / 9999 ebuilds):\n'
1241 ' KEYWORDS="~*"\n'
Mike Frysingerde8efea2015-05-17 03:42:26 -04001242 'If the ebuild needs to be marked for only specific arches, '
Mike Frysinger8d42d742014-09-22 15:50:21 -04001243 'then use -* like so:\n'
1244 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -05001245
Mike Frysinger8cf80812019-09-16 23:49:29 -04001246 return None
1247
Mike Frysingerc51ece72014-01-17 16:23:40 -05001248
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001249def _check_ebuild_licenses(_project, commit):
1250 """Check if the LICENSE field in the ebuild is correct."""
Brian Norris7a610e82016-02-17 12:24:54 -08001251 affected_paths = _get_affected_files(commit, relative=True)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001252 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
1253
1254 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -08001255 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001256
1257 for ebuild in touched_ebuilds:
1258 # Skip virutal packages.
1259 if ebuild.split('/')[-3] == 'virtual':
1260 continue
1261
Alex Kleinb5953522018-08-03 11:44:21 -06001262 # e.g. path/to/overlay/category/package/package.ebuild -> path/to/overlay
1263 overlay_path = os.sep.join(ebuild.split(os.sep)[:-3])
1264
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001265 try:
Brian Norris7a610e82016-02-17 12:24:54 -08001266 ebuild_content = _get_file_content(ebuild, commit)
Alex Kleinb5953522018-08-03 11:44:21 -06001267 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content,
1268 overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001269 except ValueError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001270 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001271
1272 # Also ignore licenses ending with '?'
1273 for license_type in [x for x in license_types
1274 if x not in LICENSES_IGNORE and not x.endswith('?')]:
1275 try:
Alex Kleinb5953522018-08-03 11:44:21 -06001276 licenses_lib.Licensing.FindLicenseType(license_type,
1277 overlay_path=overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001278 except AssertionError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001279 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001280
Mike Frysinger8cf80812019-09-16 23:49:29 -04001281 return None
1282
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001283
Mike Frysingercd363c82014-02-01 05:20:18 -05001284def _check_ebuild_virtual_pv(project, commit):
1285 """Enforce the virtual PV policies."""
1286 # If this is the portage-stable overlay, then ignore the check.
1287 # We want to import virtuals as-is from upstream Gentoo.
Bob Haarman0dc1f942020-10-03 00:06:59 +00001288 allowlist = (
Mike Frysingercd363c82014-02-01 05:20:18 -05001289 'chromiumos/overlays/portage-stable',
1290 )
Bob Haarman0dc1f942020-10-03 00:06:59 +00001291 if project.name in allowlist:
Mike Frysingercd363c82014-02-01 05:20:18 -05001292 return None
1293
1294 # We assume the repo name is the same as the dir name on disk.
1295 # It would be dumb to not have them match though.
Alex Deymo643ac4c2015-09-03 10:40:50 -07001296 project_base = os.path.basename(project.name)
Mike Frysingercd363c82014-02-01 05:20:18 -05001297
1298 is_variant = lambda x: x.startswith('overlay-variant-')
1299 is_board = lambda x: x.startswith('overlay-')
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001300 is_baseboard = lambda x: x.startswith('baseboard-')
1301 is_chipset = lambda x: x.startswith('chipset-')
1302 is_project = lambda x: x.startswith('project-')
Mike Frysingercd363c82014-02-01 05:20:18 -05001303 is_private = lambda x: x.endswith('-private')
1304
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001305 is_special_overlay = lambda x: (is_board(x) or is_chipset(x) or
1306 is_baseboard(x) or is_project(x))
1307
Mike Frysingercd363c82014-02-01 05:20:18 -05001308 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
1309
1310 ebuilds_re = [r'\.ebuild$']
1311 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1312 ebuilds_re)
1313 bad_ebuilds = []
1314
1315 for ebuild in ebuilds:
1316 m = get_pv.match(ebuild)
1317 if m:
1318 overlay = m.group(1)
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001319 if not overlay or not is_special_overlay(overlay):
Alex Deymo643ac4c2015-09-03 10:40:50 -07001320 overlay = project_base
Mike Frysingercd363c82014-02-01 05:20:18 -05001321
1322 pv = m.group(3).split('-', 1)[0]
1323
Bernie Thompsone5ee1822016-01-12 14:22:23 -08001324 # Virtual versions >= 4 are special cases used above the standard
1325 # versioning structure, e.g. if one has a board inheriting a board.
Julius Werner0299a2b2020-07-31 18:20:43 -07001326 if pv[0] >= '4':
Bernie Thompsone5ee1822016-01-12 14:22:23 -08001327 want_pv = pv
Mike Frysingercd363c82014-02-01 05:20:18 -05001328 elif is_board(overlay):
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001329 if is_private(overlay):
1330 want_pv = '3.5' if is_variant(overlay) else '3'
1331 elif is_board(overlay):
1332 want_pv = '2.5' if is_variant(overlay) else '2'
1333 elif is_baseboard(overlay):
Julius Werner0299a2b2020-07-31 18:20:43 -07001334 want_pv = '1.9.5' if is_private(overlay) else '1.9'
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001335 elif is_chipset(overlay):
Julius Werner0299a2b2020-07-31 18:20:43 -07001336 want_pv = '1.8.5' if is_private(overlay) else '1.8'
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001337 elif is_project(overlay):
1338 want_pv = '1.7' if is_private(overlay) else '1.5'
Mike Frysingercd363c82014-02-01 05:20:18 -05001339 else:
1340 want_pv = '1'
1341
1342 if pv != want_pv:
1343 bad_ebuilds.append((ebuild, pv, want_pv))
1344
1345 if bad_ebuilds:
1346 # pylint: disable=C0301
1347 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
1348 # pylint: enable=C0301
1349 return HookFailure(
1350 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
1351 '\t%s\n'
1352 'If this is an upstream Gentoo virtual, then you may ignore this\n'
1353 'check (and re-run w/--no-verify). Otherwise, please see this\n'
1354 'page for more details:\n%s\n' %
1355 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
1356 for x in bad_ebuilds]), url))
1357
Mike Frysinger8cf80812019-09-16 23:49:29 -04001358 return None
1359
Mike Frysingercd363c82014-02-01 05:20:18 -05001360
Daniel Erat9d203ff2015-02-17 10:12:21 -07001361def _check_portage_make_use_var(_project, commit):
1362 """Verify that $USE is set correctly in make.conf and make.defaults."""
1363 files = _filter_files(_get_affected_files(commit, relative=True),
1364 [r'(^|/)make.(conf|defaults)$'])
1365
1366 errors = []
1367 for path in files:
1368 basename = os.path.basename(path)
1369
1370 # Has a USE= line already been encountered in this file?
1371 saw_use = False
1372
1373 for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1):
1374 if not line.startswith('USE='):
1375 continue
1376
1377 preserves_use = '${USE}' in line or '$USE' in line
1378
1379 if (basename == 'make.conf' or
1380 (basename == 'make.defaults' and saw_use)) and not preserves_use:
1381 errors.append('%s:%d: missing ${USE}' % (path, i))
1382 elif basename == 'make.defaults' and not saw_use and preserves_use:
1383 errors.append('%s:%d: ${USE} referenced in initial declaration' %
1384 (path, i))
1385
1386 saw_use = True
1387
1388 if errors:
1389 return HookFailure(
1390 'One or more Portage make files appear to set USE incorrectly.\n'
1391 '\n'
1392 'All USE assignments in make.conf and all assignments after the\n'
1393 'initial declaration in make.defaults should contain "${USE}" to\n'
1394 'preserve previously-set flags.\n'
1395 '\n'
1396 'The initial USE declaration in make.defaults should not contain\n'
1397 '"${USE}".\n',
1398 errors)
1399
Mike Frysinger8cf80812019-09-16 23:49:29 -04001400 return None
1401
Daniel Erat9d203ff2015-02-17 10:12:21 -07001402
Mike Frysingerae409522014-02-01 03:16:11 -05001403def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001404 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001405 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001406 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001407 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001408 if not m:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001409 return HookFailure('Last paragraph of description must include Change-Id.')
Ryan Cui1562fb82011-05-09 11:01:31 -07001410
LaMont Jonesfb5e8bf2020-03-03 12:50:06 -07001411 # S-o-b and some other tags always allowed to follow Change-ID in the footer.
1412 allowed_tags = ['Signed-off-by', 'Cq-Cl-Tag', 'Cq-Include-Trybots']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001413
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001414 end = desc[m.end():].strip().splitlines()
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001415 cherry_pick_marker = 'cherry picked from commit'
1416
1417 if end and cherry_pick_marker in end[-1]:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001418 # Cherry picked patches allow more tags in the last paragraph.
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001419 allowed_tags += ['Commit-Queue', 'Commit-Ready', 'Reviewed-by',
1420 'Reviewed-on', 'Tested-by']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001421 end = end[:-1]
1422
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001423 # Note that descriptions could have multiple cherry pick markers.
1424 tag_search = r'^(%s:|\(%s) ' % (':|'.join(allowed_tags), cherry_pick_marker)
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001425
1426 if [x for x in end if not re.search(tag_search, x)]:
1427 return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' %
1428 ':", "'.join(allowed_tags))
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001429
Mike Frysinger8cf80812019-09-16 23:49:29 -04001430 return None
1431
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001432
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001433def _check_commit_message_style(_project, commit):
1434 """Verify that the commit message matches our style.
1435
1436 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
1437 commit hooks.
1438 """
Mike Frysingered9b2a02019-12-12 18:52:32 -05001439 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Mike Frysinger4efdee72019-11-04 10:57:01 -05001440
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001441 desc = _get_commit_desc(commit)
1442
1443 # The first line should be by itself.
1444 lines = desc.splitlines()
1445 if len(lines) > 1 and lines[1]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001446 return HookFailure('The second line of the commit message must be blank.'
1447 '\n%s' % (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001448
1449 # The first line should be one sentence.
1450 if '. ' in lines[0]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001451 return HookFailure('The first line cannot be more than one sentence.\n%s' %
1452 (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001453
1454 # The first line cannot be too long.
1455 MAX_FIRST_LINE_LEN = 100
1456 if len(lines[0]) > MAX_FIRST_LINE_LEN:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001457 return HookFailure('The first line must be less than %i chars.\n%s' %
1458 (MAX_FIRST_LINE_LEN, SEE_ALSO))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001459
Mike Frysinger8cf80812019-09-16 23:49:29 -04001460 return None
1461
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001462
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001463def _check_cros_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001464 """Verifies the Chromium OS license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -07001465
Mike Frysinger98638102014-08-28 00:15:08 -04001466 Should be following the spec:
1467 http://dev.chromium.org/developers/coding-style#TOC-File-headers
1468 """
1469 # For older years, be a bit more flexible as our policy says leave them be.
1470 LICENSE_HEADER = (
Keigo Oka7e880ac2019-07-03 15:03:43 +09001471 r'.*Copyright(?: \(c\))? (20[0-9]{2})(?:-20[0-9]{2})? The Chromium OS '
1472 r'Authors\. All rights reserved\.\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001473 r'.*Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001474 r'be\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001475 r'.*found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -05001476 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001477 )
1478 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1479
1480 # For newer years, be stricter.
Keigo Oka7e880ac2019-07-03 15:03:43 +09001481 BAD_COPYRIGHT_LINE = (
Brian Norris68838dd2018-09-26 18:30:24 -07001482 r'.*Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001483 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001484 )
Keigo Oka7e880ac2019-07-03 15:03:43 +09001485 bad_copyright_re = re.compile(BAD_COPYRIGHT_LINE)
Mike Frysinger98638102014-08-28 00:15:08 -04001486
Shuhei Takahashiabc20f32017-07-10 19:35:45 +09001487 included, excluded = _parse_common_inclusion_options(options)
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001488
Mike Frysinger98638102014-08-28 00:15:08 -04001489 bad_files = []
1490 bad_copyright_files = []
Keigo Oka7e880ac2019-07-03 15:03:43 +09001491 bad_year_files = []
1492
Ken Turnerd07564b2018-02-08 17:57:59 +11001493 files = _filter_files(
1494 _get_affected_files(commit, relative=True),
1495 included + COMMON_INCLUDED_PATHS,
1496 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001497 existing_files = set(_get_affected_files(commit, relative=True,
1498 include_adds=False))
Mike Frysinger98638102014-08-28 00:15:08 -04001499
Keigo Oka7e880ac2019-07-03 15:03:43 +09001500 current_year = str(datetime.datetime.now().year)
Mike Frysinger98638102014-08-28 00:15:08 -04001501 for f in files:
1502 contents = _get_file_content(f, commit)
1503 if not contents:
1504 # Ignore empty files.
1505 continue
1506
Keigo Oka7e880ac2019-07-03 15:03:43 +09001507 m = license_re.search(contents)
1508 if not m:
Mike Frysinger98638102014-08-28 00:15:08 -04001509 bad_files.append(f)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001510 elif bad_copyright_re.search(contents):
Mike Frysinger98638102014-08-28 00:15:08 -04001511 bad_copyright_files.append(f)
1512
Keigo Oka7e880ac2019-07-03 15:03:43 +09001513 if m and f not in existing_files:
1514 year = m.group(1)
1515 if year != current_year:
1516 bad_year_files.append(f)
1517
1518 errors = []
Mike Frysinger98638102014-08-28 00:15:08 -04001519 if bad_files:
1520 msg = '%s:\n%s\n%s' % (
1521 'License must match', license_re.pattern,
1522 'Found a bad header in these files:')
Keigo Oka7e880ac2019-07-03 15:03:43 +09001523 errors.append(HookFailure(msg, bad_files))
Mike Frysinger98638102014-08-28 00:15:08 -04001524 if bad_copyright_files:
1525 msg = 'Do not use (c) in copyright headers in new files:'
Keigo Oka7e880ac2019-07-03 15:03:43 +09001526 errors.append(HookFailure(msg, bad_copyright_files))
1527 if bad_year_files:
1528 msg = 'Use current year (%s) in copyright headers in new files:' % (
1529 current_year)
1530 errors.append(HookFailure(msg, bad_year_files))
Ryan Cuiec4d6332011-05-02 14:15:25 -07001531
Keigo Oka7e880ac2019-07-03 15:03:43 +09001532 return errors
Ryan Cuiec4d6332011-05-02 14:15:25 -07001533
Mike Frysinger8cf80812019-09-16 23:49:29 -04001534
Amin Hassani391efa92018-01-26 17:58:05 -08001535def _check_aosp_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001536 """Verifies the AOSP license/copyright header.
1537
1538 AOSP uses the Apache2 License:
1539 https://source.android.com/source/licenses.html
1540 """
1541 LICENSE_HEADER = (
1542 r"""^[#/\*]*
1543[#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project
1544[#/\*]* ?
1545[#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\);
1546[#/\*]* ?you may not use this file except in compliance with the License\.
1547[#/\*]* ?You may obtain a copy of the License at
1548[#/\*]* ?
1549[#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0
1550[#/\*]* ?
1551[#/\*]* ?Unless required by applicable law or agreed to in writing, software
1552[#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS,
1553[#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """
1554 r"""implied\.
1555[#/\*]* ?See the License for the specific language governing permissions and
1556[#/\*]* ?limitations under the License\.
1557[#/\*]*$
1558"""
1559 )
1560 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1561
Amin Hassani391efa92018-01-26 17:58:05 -08001562 included, excluded = _parse_common_inclusion_options(options)
1563
Ken Turnerd07564b2018-02-08 17:57:59 +11001564 files = _filter_files(
1565 _get_affected_files(commit, relative=True),
1566 included + COMMON_INCLUDED_PATHS,
1567 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Alex Deymof5792ce2015-08-24 22:50:08 -07001568
1569 bad_files = []
1570 for f in files:
1571 contents = _get_file_content(f, commit)
1572 if not contents:
1573 # Ignore empty files.
1574 continue
1575
1576 if not license_re.search(contents):
1577 bad_files.append(f)
1578
1579 if bad_files:
1580 msg = ('License must match:\n%s\nFound a bad header in these files:' %
1581 license_re.pattern)
1582 return HookFailure(msg, bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001583 return None
Alex Deymof5792ce2015-08-24 22:50:08 -07001584
1585
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001586def _check_layout_conf(_project, commit):
1587 """Verifies the metadata/layout.conf file."""
1588 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001589 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001590 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001591 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001592
Mike Frysinger94a670c2014-09-19 12:46:26 -04001593 # Handle multiple overlays in a single commit (like the public tree).
1594 for f in _get_affected_files(commit, relative=True):
1595 if f.endswith(repo_name):
1596 repo_names.append(f)
1597 elif f.endswith(layout_path):
1598 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001599
1600 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -04001601 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001602 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -04001603 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001604
Mike Frysinger94a670c2014-09-19 12:46:26 -04001605 # Gather all the errors in one pass so we show one full message.
1606 all_errors = {}
1607 for layout_path in layout_paths:
1608 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001609
Mike Frysinger94a670c2014-09-19 12:46:26 -04001610 # Make sure the config file is sorted.
1611 data = [x for x in _get_file_content(layout_path, commit).splitlines()
1612 if x and x[0] != '#']
1613 if sorted(data) != data:
1614 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001615
Mike Frysinger94a670c2014-09-19 12:46:26 -04001616 # Require people to set specific values all the time.
1617 settings = (
1618 # TODO: Enable this for everyone. http://crbug.com/408038
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001619 # ('fast caching', 'cache-format = md5-dict'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001620 ('fast manifests', 'thin-manifests = true'),
Mike Frysingerd7734522015-02-26 16:12:43 -05001621 ('extra features', 'profile-formats = portage-2 profile-default-eapi'),
1622 ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001623 )
1624 for reason, line in settings:
1625 if line not in data:
1626 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001627
Mike Frysinger94a670c2014-09-19 12:46:26 -04001628 # Require one of these settings.
Mike Frysinger5fae62d2015-11-11 20:12:15 -05001629 if 'use-manifests = strict' not in data:
1630 errors += ['enable file checking with: use-manifests = strict']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001631
Mike Frysinger94a670c2014-09-19 12:46:26 -04001632 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -04001633 for line in data:
1634 if line.startswith('repo-name = '):
1635 break
1636 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -04001637 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001638
Mike Frysinger94a670c2014-09-19 12:46:26 -04001639 # Summarize all the errors we saw (if any).
1640 lines = ''
1641 for layout_path, errors in all_errors.items():
1642 if errors:
1643 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
1644 if lines:
1645 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
1646 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001647
Mike Frysinger8cf80812019-09-16 23:49:29 -04001648 return None
1649
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001650
Keigo Oka4a09bd92019-05-07 14:01:00 +09001651def _check_no_new_gyp(_project, commit):
1652 """Verifies no project starts to use GYP."""
Keigo Oka4a09bd92019-05-07 14:01:00 +09001653 gypfiles = _filter_files(
1654 _get_affected_files(commit, include_symlinks=True, relative=True),
1655 [r'\.gyp$'])
1656
1657 if gypfiles:
1658 return HookFailure('GYP is deprecated and not allowed in a new project:',
1659 gypfiles)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001660 return None
Keigo Oka4a09bd92019-05-07 14:01:00 +09001661
1662
Ryan Cuiec4d6332011-05-02 14:15:25 -07001663# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001664
Ryan Cui1562fb82011-05-09 11:01:31 -07001665
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001666def _check_clang_format(_project, commit, options=()):
1667 """Runs clang-format on the given project"""
1668 hooks_dir = _get_hooks_dir()
1669 options = list(options)
1670 if commit == PRE_SUBMIT:
1671 options.append('--commit=HEAD')
1672 else:
1673 options.extend(['--commit', commit])
Brian Norris0c62a142018-12-11 13:24:29 -08001674 cmd = [os.path.join(hooks_dir, 'clang-format.py')] + options
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001675 cmd_result = cros_build_lib.run(cmd,
1676 print_cmd=False,
1677 stdout=True,
1678 encoding='utf-8',
1679 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001680 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001681 check=False)
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001682 if cmd_result.returncode:
1683 return HookFailure('clang-format.py errors/warnings\n\n' +
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001684 cmd_result.stdout)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001685 return None
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001686
1687
Mike Frysingerae409522014-02-01 03:16:11 -05001688def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001689 """Runs checkpatch.pl on the given project"""
Tomasz Figabd8faf62020-09-22 14:06:05 +00001690 # Bypass checkpatch for upstream or almost upstream commits, since we do not
1691 # intend to modify the upstream commits when landing them to our branches.
1692 # Any fixes should sent as independent patches.
1693 # The check is retained for FROMLIST and BACKPORT commits, as by definition
1694 # those can be still fixed up.
1695 desc = _get_commit_desc(commit)
1696 if desc.startswith('UPSTREAM:') or desc.startswith('FROMGIT:'):
1697 return None
1698
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001699 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001700 options = list(options)
Brian Norris4cee0502020-06-12 17:02:56 -07001701 if options and options[0].startswith('./') and os.path.exists(options[0]):
1702 cmdpath = options.pop(0)
1703 else:
1704 cmdpath = os.path.join(hooks_dir, 'checkpatch.pl')
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001705 if commit == PRE_SUBMIT:
1706 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
1707 # this case.
1708 options.append('--ignore=MISSING_SIGN_OFF')
Filipe Brandenburger28d48d62015-10-07 09:48:54 -07001709 # Always ignore the check for the MAINTAINERS file. We do not track that
1710 # information on that file in our source trees, so let's suppress the
1711 # warning.
1712 options.append('--ignore=FILE_PATH_CHANGES')
Filipe Brandenburgerce978322015-10-09 10:04:15 -07001713 # Do not complain about the Change-Id: fields, since we use Gerrit.
1714 # Upstream does not want those lines (since they do not use Gerrit), but
1715 # we always do, so disable the check globally.
Daisuke Nojiri4844f892015-10-08 09:54:33 -07001716 options.append('--ignore=GERRIT_CHANGE_ID')
Brian Norris4cee0502020-06-12 17:02:56 -07001717 cmd = [cmdpath] + options + ['-']
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001718 cmd_result = cros_build_lib.run(
1719 cmd, print_cmd=False, input=_get_patch(commit).encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001720 stdout=True, stderr=subprocess.STDOUT, check=False, encoding='utf-8',
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001721 errors='replace')
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001722 if cmd_result.returncode:
Brian Norris4cee0502020-06-12 17:02:56 -07001723 return HookFailure('%s errors/warnings\n\n%s' %
1724 (cmdpath, cmd_result.stdout))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001725 return None
Ryan Cuiec4d6332011-05-02 14:15:25 -07001726
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001727
Brian Norris23c62e92018-11-14 12:25:51 -08001728def _run_kerneldoc(_project, commit, options=()):
1729 """Runs kernel-doc validator on the given project"""
1730 included, excluded = _parse_common_inclusion_options(options)
1731 files = _filter_files(_get_affected_files(commit, relative=True),
1732 included, excluded)
1733 if files:
1734 hooks_dir = _get_hooks_dir()
Brian Norris0c62a142018-12-11 13:24:29 -08001735 cmd = [os.path.join(hooks_dir, 'kernel-doc'), '-none'] + files
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001736 output = _run_command(cmd, stderr=subprocess.STDOUT)
Brian Norris23c62e92018-11-14 12:25:51 -08001737 if output:
Brian Norris0c62a142018-12-11 13:24:29 -08001738 return HookFailure('kernel-doc errors/warnings:',
1739 items=output.splitlines())
Mike Frysinger8cf80812019-09-16 23:49:29 -04001740 return None
Brian Norris23c62e92018-11-14 12:25:51 -08001741
1742
Mike Frysingerae409522014-02-01 03:16:11 -05001743def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -07001744 """Makes sure kernel config changes are not mixed with code changes"""
1745 files = _get_affected_files(commit)
Mike Frysingerf252cfc2019-12-09 17:34:28 -05001746 if len(_filter_files(files, [r'chromeos/config'])) not in [0, len(files)]:
Olof Johanssona96810f2012-09-04 16:20:03 -07001747 return HookFailure('Changes to chromeos/config/ and regular files must '
1748 'be in separate commits:\n%s' % '\n'.join(files))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001749 return None
Anton Staaf815d6852011-08-22 10:08:45 -07001750
Mike Frysingerae409522014-02-01 03:16:11 -05001751
1752def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -07001753 """Checks that all JSON files are syntactically valid."""
Mike Frysinger908be682018-01-04 02:21:50 -05001754 ret = []
1755
1756 files = _filter_files(_get_affected_files(commit, relative=True),
1757 [r'.*\.json$'])
1758 for f in files:
1759 data = _get_file_content(f, commit)
Dale Curtis2975c432011-05-03 17:25:20 -07001760 try:
Mike Frysinger908be682018-01-04 02:21:50 -05001761 json.loads(data)
1762 except Exception as e:
1763 ret.append('%s: Invalid JSON: %s' % (f, e))
1764
1765 if ret:
1766 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001767 return None
Dale Curtis2975c432011-05-03 17:25:20 -07001768
1769
Mike Frysingerae409522014-02-01 03:16:11 -05001770def _check_manifests(_project, commit):
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001771 """Make sure Manifest files only have comments & DIST lines."""
1772 ret = []
Mike Frysinger52b537e2013-08-22 22:59:53 -04001773
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001774 manifests = _filter_files(_get_affected_files(commit, relative=True),
1775 [r'.*/Manifest$'])
1776 for path in manifests:
1777 data = _get_file_content(path, commit)
1778
1779 # Disallow blank files.
1780 if not data.strip():
1781 ret.append('%s: delete empty file' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001782 continue
1783
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001784 # Make sure the last newline isn't omitted.
1785 if data[-1] != '\n':
1786 ret.append('%s: missing trailing newline' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001787
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001788 # Do not allow leading or trailing blank lines.
1789 lines = data.splitlines()
1790 if not lines[0]:
1791 ret.append('%s: delete leading blank lines' % (path,))
1792 if not lines[-1]:
1793 ret.append('%s: delete trailing blank lines' % (path,))
1794
1795 for line in lines:
1796 # Disallow leading/trailing whitespace.
1797 if line != line.strip():
1798 ret.append('%s: remove leading/trailing whitespace: %s' % (path, line))
1799
1800 # Allow blank lines & comments.
1801 line = line.split('#', 1)[0]
1802 if not line:
1803 continue
1804
1805 # All other linse should start with DIST.
1806 if not line.startswith('DIST '):
1807 ret.append('%s: remove non-DIST lines: %s' % (path, line))
1808 break
1809
1810 if ret:
1811 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001812 return None
Mike Frysinger52b537e2013-08-22 22:59:53 -04001813
1814
Mike Frysingerae409522014-02-01 03:16:11 -05001815def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001816 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001817 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001818 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001819 BRANCH_RE = r'\nBRANCH=\S+'
1820
1821 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
1822 msg = ('Changelist description needs BRANCH field (after first line)\n'
1823 'E.g. BRANCH=none or BRANCH=link,snow')
1824 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001825 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001826
1827
Mike Frysinger45334bd2019-11-04 10:42:33 -05001828def _check_change_has_no_branch_field(_project, commit):
1829 """Verify 'BRANCH=' field does not exist in the commit message."""
1830 if commit == PRE_SUBMIT:
1831 return None
1832 BRANCH_RE = r'\nBRANCH=\S+'
1833
1834 if re.search(BRANCH_RE, _get_commit_desc(commit)):
1835 msg = 'This checkout does not use BRANCH= fields. Delete them.'
1836 return HookFailure(msg)
1837 return None
1838
1839
Mike Frysingerae409522014-02-01 03:16:11 -05001840def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001841 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001842 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001843 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001844 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1845
1846 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1847 msg = ('Changelist description needs Signed-off-by: field\n'
1848 'E.g. Signed-off-by: My Name <me@chromium.org>')
1849 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001850 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001851
1852
Mike Frysinger9ab64b12019-11-04 10:53:08 -05001853def _check_change_has_no_signoff_field(_project, commit):
1854 """Verify 'Signed-off-by:' field does not exist in the commit message."""
1855 if commit == PRE_SUBMIT:
1856 return None
1857 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1858
1859 if re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1860 msg = 'This checkout does not use Signed-off-by: tags. Delete them.'
1861 return HookFailure(msg)
1862 return None
1863
1864
Jon Salz3ee59de2012-08-18 13:54:22 +08001865def _run_project_hook_script(script, project, commit):
1866 """Runs a project hook script.
1867
1868 The script is run with the following environment variables set:
1869 PRESUBMIT_PROJECT: The affected project
1870 PRESUBMIT_COMMIT: The affected commit
1871 PRESUBMIT_FILES: A newline-separated list of affected files
1872
1873 The script is considered to fail if the exit code is non-zero. It should
1874 write an error message to stdout.
1875 """
1876 env = dict(os.environ)
Alex Deymo643ac4c2015-09-03 10:40:50 -07001877 env['PRESUBMIT_PROJECT'] = project.name
Jon Salz3ee59de2012-08-18 13:54:22 +08001878 env['PRESUBMIT_COMMIT'] = commit
1879
1880 # Put affected files in an environment variable
1881 files = _get_affected_files(commit)
1882 env['PRESUBMIT_FILES'] = '\n'.join(files)
1883
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001884 cmd_result = cros_build_lib.run(cmd=script,
1885 env=env,
1886 shell=True,
1887 print_cmd=False,
1888 input=os.devnull,
1889 stdout=True,
1890 encoding='utf-8',
1891 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001892 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001893 check=False)
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001894 if cmd_result.returncode:
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001895 stdout = cmd_result.stdout
Jon Salz7b618af2012-08-31 06:03:16 +08001896 if stdout:
1897 stdout = re.sub('(?m)^', ' ', stdout)
1898 return HookFailure('Hook script "%s" failed with code %d%s' %
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001899 (script, cmd_result.returncode,
Jon Salz3ee59de2012-08-18 13:54:22 +08001900 ':\n' + stdout if stdout else ''))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001901 return None
Jon Salz3ee59de2012-08-18 13:54:22 +08001902
1903
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001904def _check_project_prefix(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -05001905 """Require the commit message have a project specific prefix as needed."""
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001906
Brian Norris77608e12018-04-06 10:38:43 -07001907 files = _get_affected_files(commit, include_deletes=True, relative=True)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001908 prefix = os.path.commonprefix(files)
1909 prefix = os.path.dirname(prefix)
1910
1911 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07001912 if not prefix:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001913 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001914
1915 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07001916
1917 # The common files may all be within a subdirectory of the main project
1918 # directory, so walk up the tree until we find an alias file.
1919 # _get_affected_files() should return relative paths, but check against '/' to
1920 # ensure that this loop terminates even if it receives an absolute path.
1921 while prefix and prefix != '/':
1922 alias_file = os.path.join(prefix, '.project_alias')
1923
1924 # If an alias exists, use it.
1925 if os.path.isfile(alias_file):
1926 project_name = osutils.ReadFile(alias_file).strip()
1927
1928 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001929
1930 if not _get_commit_desc(commit).startswith(project_name + ': '):
1931 return HookFailure('The commit title for changes affecting only %s'
1932 ' should start with \"%s: \"'
1933 % (project_name, project_name))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001934 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001935
1936
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001937def _check_filepath_chartype(_project, commit):
1938 """Checks that FilePath::CharType stuff is not used."""
1939
1940 FILEPATH_REGEXP = re.compile('|'.join(
1941 [r'(?:base::)?FilePath::(?:Char|String|StringPiece)Type',
Satoru Takabayashi4ca37922018-08-08 10:16:38 +09001942 r'(?:base::)?FilePath::FromUTF8Unsafe',
1943 r'AsUTF8Unsafe',
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001944 r'FILE_PATH_LITERAL']))
1945 files = _filter_files(_get_affected_files(commit, relative=True),
1946 [r'.*\.(cc|h)$'])
1947
1948 errors = []
1949 for afile in files:
1950 for line_num, line in _get_file_diff(afile, commit):
1951 m = re.search(FILEPATH_REGEXP, line)
1952 if m:
1953 errors.append('%s, line %s has %s' % (afile, line_num, m.group(0)))
1954
1955 if errors:
1956 msg = 'Please assume FilePath::CharType is char (crbug.com/870621):'
1957 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001958 return None
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001959
1960
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001961def _check_exec_files(_project, commit):
1962 """Make +x bits on files."""
1963 # List of files that should never be +x.
1964 NO_EXEC = (
1965 'ChangeLog*',
1966 'COPYING',
1967 'make.conf',
1968 'make.defaults',
1969 'Manifest',
1970 'OWNERS',
1971 'package.use',
1972 'package.keywords',
1973 'package.mask',
1974 'parent',
1975 'README',
1976 'TODO',
1977 '.gitignore',
1978 '*.[achly]',
1979 '*.[ch]xx',
1980 '*.boto',
1981 '*.cc',
1982 '*.cfg',
1983 '*.conf',
1984 '*.config',
1985 '*.cpp',
1986 '*.css',
1987 '*.ebuild',
1988 '*.eclass',
Tatsuhisa Yamaguchi3b053632019-01-10 14:45:14 +09001989 '*.gn',
1990 '*.gni',
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001991 '*.gyp',
1992 '*.gypi',
1993 '*.htm',
1994 '*.html',
1995 '*.ini',
1996 '*.js',
1997 '*.json',
1998 '*.md',
1999 '*.mk',
2000 '*.patch',
2001 '*.policy',
2002 '*.proto',
2003 '*.raw',
2004 '*.rules',
2005 '*.service',
2006 '*.target',
2007 '*.txt',
2008 '*.xml',
2009 '*.yaml',
2010 )
2011
2012 def FinalName(obj):
2013 # If the file is being deleted, then the dst_file is not set.
2014 if obj.dst_file is None:
2015 return obj.src_file
2016 else:
2017 return obj.dst_file
2018
2019 bad_files = []
2020 files = _get_affected_files(commit, relative=True, full_details=True)
2021 for f in files:
2022 mode = int(f.dst_mode, 8)
2023 if not mode & 0o111:
2024 continue
2025 name = FinalName(f)
2026 for no_exec in NO_EXEC:
2027 if fnmatch.fnmatch(name, no_exec):
2028 bad_files.append(name)
2029 break
2030
2031 if bad_files:
2032 return HookFailure('These files should not be executable. '
2033 'Please `chmod -x` them.', bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04002034 return None
Mike Frysingerf9d41b32017-02-23 15:20:04 -05002035
2036
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002037# Base
2038
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002039# A list of hooks which are not project specific and check patch description
2040# (as opposed to patch body).
2041_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07002042 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07002043 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07002044 _check_change_has_test_field,
2045 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04002046 _check_commit_message_style,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08002047 _check_change_is_contribution,
Jack Neus8edbf642019-07-10 16:08:31 -06002048 _check_change_no_include_oem,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002049]
2050
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002051# A list of hooks that are not project-specific
2052_COMMON_HOOKS = [
Keiichi Watanabe6ab73fd2020-07-14 23:42:02 +09002053 _check_cargo_clippy,
Aviv Keshet5ac59522017-01-31 14:28:27 -08002054 _check_cros_license,
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05002055 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05002056 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08002057 _check_ebuild_licenses,
Mike Frysingercd363c82014-02-01 05:20:18 -05002058 _check_ebuild_virtual_pv,
Mike Frysingerf9d41b32017-02-23 15:20:04 -05002059 _check_exec_files,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002060 _check_for_uprev,
Rahul Chaudhry09f61372015-07-31 17:14:26 -07002061 _check_gofmt,
Bernie Thompson8e26f742020-07-23 14:32:31 -07002062 _check_keywords,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04002063 _check_layout_conf,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002064 _check_no_long_lines,
Keigo Oka4a09bd92019-05-07 14:01:00 +09002065 _check_no_new_gyp,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002066 _check_no_stray_whitespace,
Ryan Cui9b651632011-05-11 11:38:58 -07002067 _check_no_tabs,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002068 _check_portage_make_use_var,
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -06002069 _check_rustfmt,
Aviv Keshet5ac59522017-01-31 14:28:27 -08002070 _check_tabbed_indents,
Ryan Cui9b651632011-05-11 11:38:58 -07002071]
Ryan Cuiec4d6332011-05-02 14:15:25 -07002072
Ryan Cui1562fb82011-05-09 11:01:31 -07002073
Ryan Cui9b651632011-05-11 11:38:58 -07002074# A dictionary of project-specific hooks(callbacks), indexed by project name.
2075# dict[project] = [callback1, callback2]
2076_PROJECT_SPECIFIC_HOOKS = {
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002077 'chromiumos/third_party/kernel': [_kernel_configcheck],
2078 'chromiumos/third_party/kernel-next': [_kernel_configcheck],
Ryan Cui9b651632011-05-11 11:38:58 -07002079}
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002080
Ryan Cui1562fb82011-05-09 11:01:31 -07002081
Ryan Cui9b651632011-05-11 11:38:58 -07002082# A dictionary of flags (keys) that can appear in the config file, and the hook
Mike Frysinger3554bc92015-03-11 04:59:21 -04002083# that the flag controls (value).
2084_HOOK_FLAGS = {
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07002085 'clang_format_check': _check_clang_format,
Mike Frysingera7642f52015-03-25 18:31:42 -04002086 'checkpatch_check': _run_checkpatch,
Brian Norris23c62e92018-11-14 12:25:51 -08002087 'kerneldoc_check': _run_kerneldoc,
Ryan Cui9b651632011-05-11 11:38:58 -07002088 'stray_whitespace_check': _check_no_stray_whitespace,
Mike Frysingerff6c7d62015-03-24 13:49:46 -04002089 'json_check': _run_json_check,
Ryan Cui9b651632011-05-11 11:38:58 -07002090 'long_line_check': _check_no_long_lines,
Alex Deymof5792ce2015-08-24 22:50:08 -07002091 'cros_license_check': _check_cros_license,
2092 'aosp_license_check': _check_aosp_license,
LaMont Jones872fe762020-02-10 15:36:14 -07002093 'gofmt_check': _check_gofmt,
Bernie Thompson8e26f742020-07-23 14:32:31 -07002094 'keyword_check': _check_keywords,
Ryan Cui9b651632011-05-11 11:38:58 -07002095 'tab_check': _check_no_tabs,
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08002096 'tabbed_indent_required_check': _check_tabbed_indents,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07002097 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08002098 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07002099 'bug_field_check': _check_change_has_bug_field,
2100 'test_field_check': _check_change_has_test_field,
Steve Fung49ec7e92015-03-23 16:07:12 -07002101 'manifest_check': _check_manifests,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08002102 'contribution_check': _check_change_is_contribution,
Mike Frysinger47bd1252018-06-11 12:12:20 -04002103 'project_prefix_check': _check_project_prefix,
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09002104 'filepath_chartype_check': _check_filepath_chartype,
Keiichi Watanabe6ab73fd2020-07-14 23:42:02 +09002105 'cargo_clippy_check': _check_cargo_clippy,
Julius Werner291d8602020-07-31 17:34:02 -07002106 'exec_files_check': _check_exec_files,
Ryan Cui9b651632011-05-11 11:38:58 -07002107}
2108
2109
Mike Frysinger3554bc92015-03-11 04:59:21 -04002110def _get_override_hooks(config):
2111 """Returns a set of hooks controlled by the current project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07002112
2113 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08002114
2115 Args:
2116 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07002117 """
2118 SECTION = 'Hook Overrides'
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002119 SECTION_OPTIONS = 'Hook Overrides Options'
Ryan Cui9b651632011-05-11 11:38:58 -07002120
Mike Frysinger56e8de02019-07-31 14:40:14 -04002121 valid_keys = set(_HOOK_FLAGS.keys())
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002122 hooks = _HOOK_FLAGS.copy()
Mike Frysinger180ecd62020-08-19 00:41:51 -04002123 hook_overrides = set(
2124 config.options(SECTION) if config.has_section(SECTION) else [])
2125
2126 unknown_keys = hook_overrides - valid_keys
2127 if unknown_keys:
2128 raise ValueError(f'{_CONFIG_FILE}: [{SECTION}]: unknown keys: '
2129 f'{unknown_keys}')
Mike Frysinger3554bc92015-03-11 04:59:21 -04002130
2131 enable_flags = []
Ryan Cui9b651632011-05-11 11:38:58 -07002132 disable_flags = []
Mike Frysinger180ecd62020-08-19 00:41:51 -04002133 for flag in valid_keys:
2134 if flag in hook_overrides:
2135 try:
2136 enabled = config.getboolean(SECTION, flag)
2137 except ValueError as e:
2138 raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' %
2139 (flag, _CONFIG_FILE, e))
2140 elif hooks[flag] in _COMMON_HOOKS:
2141 # Enable common hooks by default so we process custom options below.
2142 enabled = True
2143 else:
2144 # All other hooks we left as a tristate. We use this below for a few
2145 # hooks to control default behavior.
2146 enabled = None
Mike Frysinger3554bc92015-03-11 04:59:21 -04002147
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002148 if enabled:
2149 enable_flags.append(flag)
Mike Frysinger180ecd62020-08-19 00:41:51 -04002150 elif enabled is not None:
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002151 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07002152
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002153 # See if this hook has custom options.
2154 if enabled:
2155 try:
2156 options = config.get(SECTION_OPTIONS, flag)
2157 hooks[flag] = functools.partial(hooks[flag], options=options.split())
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002158 hooks[flag].__name__ = flag
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04002159 except (configparser.NoOptionError, configparser.NoSectionError):
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002160 pass
2161
2162 enabled_hooks = set(hooks[x] for x in enable_flags)
2163 disabled_hooks = set(hooks[x] for x in disable_flags)
Mike Frysinger45334bd2019-11-04 10:42:33 -05002164
Mike Frysinger9ab64b12019-11-04 10:53:08 -05002165 if _check_change_has_signoff_field not in enabled_hooks:
Drew Davenport85848e52020-01-15 14:40:29 -07002166 if _check_change_has_signoff_field not in disabled_hooks:
2167 enabled_hooks.add(_check_change_has_no_signoff_field)
Mike Frysinger45334bd2019-11-04 10:42:33 -05002168 if _check_change_has_branch_field not in enabled_hooks:
2169 enabled_hooks.add(_check_change_has_no_branch_field)
2170
Mike Frysinger3554bc92015-03-11 04:59:21 -04002171 return enabled_hooks, disabled_hooks
Ryan Cui9b651632011-05-11 11:38:58 -07002172
2173
Jon Salz3ee59de2012-08-18 13:54:22 +08002174def _get_project_hook_scripts(config):
2175 """Returns a list of project-specific hook scripts.
2176
2177 Args:
2178 config: A ConfigParser for the project's config file.
2179 """
2180 SECTION = 'Hook Scripts'
2181 if not config.has_section(SECTION):
2182 return []
2183
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002184 return config.items(SECTION)
Jon Salz3ee59de2012-08-18 13:54:22 +08002185
2186
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002187def _get_project_hooks(project, presubmit, config_file=None):
Ryan Cui9b651632011-05-11 11:38:58 -07002188 """Returns a list of hooks that need to be run for a project.
2189
2190 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002191
2192 Args:
2193 project: A string, name of the project.
2194 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002195 config_file: A string, the config file. Defaults to _CONFIG_FILE.
Ryan Cui9b651632011-05-11 11:38:58 -07002196 """
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04002197 config = configparser.RawConfigParser()
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002198 if config_file is None:
2199 config_file = _CONFIG_FILE
2200 if not os.path.exists(config_file):
Jon Salz3ee59de2012-08-18 13:54:22 +08002201 # Just use an empty config file
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04002202 config = configparser.RawConfigParser()
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09002203 else:
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002204 config.read(config_file)
Jon Salz3ee59de2012-08-18 13:54:22 +08002205
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002206 if presubmit:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07002207 hooks = _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002208 else:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07002209 hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002210
Mike Frysinger3554bc92015-03-11 04:59:21 -04002211 enabled_hooks, disabled_hooks = _get_override_hooks(config)
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07002212 hooks = [hook for hook in hooks if hook not in disabled_hooks]
2213
2214 # If a list is both in _COMMON_HOOKS and also enabled explicitly through an
2215 # override, keep the override only. Note that the override may end up being
2216 # a functools.partial, in which case we need to extract the .func to compare
2217 # it to the common hooks.
2218 unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks]
2219 hooks = [hook for hook in hooks if hook not in unwrapped_hooks]
2220
2221 hooks = list(enabled_hooks) + hooks
Ryan Cui9b651632011-05-11 11:38:58 -07002222
2223 if project in _PROJECT_SPECIFIC_HOOKS:
Puneet Kumarc80e3f62012-08-13 19:01:18 -07002224 hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project]
2225 if hook not in disabled_hooks)
Ryan Cui9b651632011-05-11 11:38:58 -07002226
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002227 for name, script in _get_project_hook_scripts(config):
2228 func = functools.partial(_run_project_hook_script, script)
2229 func.__name__ = name
2230 hooks.append(func)
Jon Salz3ee59de2012-08-18 13:54:22 +08002231
Ryan Cui9b651632011-05-11 11:38:58 -07002232 return hooks
2233
2234
Alex Deymo643ac4c2015-09-03 10:40:50 -07002235def _run_project_hooks(project_name, proj_dir=None,
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002236 commit_list=None, presubmit=False,
2237 config_file=None):
Ryan Cui1562fb82011-05-09 11:01:31 -07002238 """For each project run its project specific hook from the hooks dictionary.
2239
2240 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002241 project_name: The name of project to run hooks for.
Doug Anderson44a644f2011-11-02 10:37:37 -07002242 proj_dir: If non-None, this is the directory the project is in. If None,
2243 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07002244 commit_list: A list of commits to run hooks against. If None or empty list
2245 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002246 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002247 config_file: A string, the presubmit config file. If not specified,
2248 defaults to PRESUBMIT.cfg in the project directory.
Ryan Cui1562fb82011-05-09 11:01:31 -07002249
2250 Returns:
2251 Boolean value of whether any errors were ecountered while running the hooks.
2252 """
Doug Anderson44a644f2011-11-02 10:37:37 -07002253 if proj_dir is None:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002254 proj_dirs = _run_command(
2255 ['repo', 'forall', project_name, '-c', 'pwd']).split()
Mike Frysingere52b1bc2019-09-16 23:45:41 -04002256 if not proj_dirs:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002257 print('%s cannot be found.' % project_name, file=sys.stderr)
David James2edd9002013-10-11 14:09:19 -07002258 print('Please specify a valid project.', file=sys.stderr)
2259 return True
2260 if len(proj_dirs) > 1:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002261 print('%s is associated with multiple directories.' % project_name,
David James2edd9002013-10-11 14:09:19 -07002262 file=sys.stderr)
2263 print('Please specify a directory to help disambiguate.', file=sys.stderr)
2264 return True
2265 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07002266
Ryan Cuiec4d6332011-05-02 14:15:25 -07002267 pwd = os.getcwd()
2268 # hooks assume they are run from the root of the project
2269 os.chdir(proj_dir)
2270
Mike Frysingered1b95a2019-12-12 19:04:51 -05002271 color = terminal.Color()
2272
Alex Deymo643ac4c2015-09-03 10:40:50 -07002273 remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref',
2274 '--symbolic-full-name', '@{u}']).strip()
2275 if not remote_branch:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002276 print("Your project %s doesn't track any remote repo." % project_name,
Alex Deymo643ac4c2015-09-03 10:40:50 -07002277 file=sys.stderr)
2278 remote = None
2279 else:
Josh Pratt15d13ab2018-08-13 11:52:48 +10002280 branch_items = remote_branch.split('/', 1)
2281 if len(branch_items) != 2:
2282 PrintErrorForProject(
2283 project_name,
2284 HookFailure(
2285 'Cannot get remote and branch name (%s)' % remote_branch))
2286 os.chdir(pwd)
2287 return True
2288 remote, _branch = branch_items
Alex Deymo643ac4c2015-09-03 10:40:50 -07002289
2290 project = Project(name=project_name, dir=proj_dir, remote=remote)
2291
Doug Anderson14749562013-06-26 13:38:29 -07002292 if not commit_list:
2293 try:
2294 commit_list = _get_commits()
2295 except VerifyException as e:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002296 PrintErrorForProject(project.name, HookFailure(str(e)))
Doug Anderson14749562013-06-26 13:38:29 -07002297 os.chdir(pwd)
2298 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07002299
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002300 hooks = _get_project_hooks(project.name, presubmit, config_file)
Ryan Cui1562fb82011-05-09 11:01:31 -07002301 error_found = False
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002302 commit_count = len(commit_list)
Mike Frysingerb99b3772019-08-17 14:19:44 -04002303 hook_count = len(hooks)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002304 for i, commit in enumerate(commit_list):
Mike Frysingerb2496652019-09-12 23:35:46 -04002305 CACHE.clear()
2306
LaMont Jones69d3e182020-03-11 15:00:53 -06002307 # If run with --pre-submit, then commit is PRE_SUBMIT, and not a commit.
2308 # Use that as the description.
2309 desc = commit if commit == PRE_SUBMIT else _get_commit_desc(commit)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002310 print('[%s %i/%i %s] %s' %
2311 (color.Color(color.CYAN, 'COMMIT'), i + 1, commit_count, commit[0:12],
2312 desc.splitlines()[0]))
2313
Mike Frysingerb99b3772019-08-17 14:19:44 -04002314 for h, hook in enumerate(hooks):
Mike Frysingered1b95a2019-12-12 19:04:51 -05002315 output = ('[%s %i/%i PRESUBMIT.cfg] %s' %
2316 (color.Color(color.YELLOW, 'RUNNING'), h + 1, hook_count,
2317 hook.__name__))
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002318 print(output, end='\r')
2319 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002320 hook_error = hook(project, commit)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002321 print(' ' * len(output), end='\r')
2322 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002323 if hook_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002324 if not isinstance(hook_error, list):
2325 hook_error = [hook_error]
2326 PrintErrorsForCommit(color, hook, project.name, hook_error)
Ryan Cui1562fb82011-05-09 11:01:31 -07002327 error_found = True
Don Garrettdba548a2011-05-05 15:17:14 -07002328
Ryan Cuiec4d6332011-05-02 14:15:25 -07002329 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07002330 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002331
Mike Frysingerae409522014-02-01 03:16:11 -05002332
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002333# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002334
Ryan Cui1562fb82011-05-09 11:01:31 -07002335
Mike Frysingerae409522014-02-01 03:16:11 -05002336def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08002337 """Main function invoked directly by repo.
2338
2339 This function will exit directly upon error so that repo doesn't print some
2340 obscure error message.
2341
2342 Args:
2343 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07002344 worktree_list: A list of directories. It should be the same length as
2345 project_list, so that each entry in project_list matches with a directory
2346 in worktree_list. If None, we will attempt to calculate the directories
2347 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08002348 kwargs: Leave this here for forward-compatibility.
2349 """
Mike Frysingered1b95a2019-12-12 19:04:51 -05002350 start_time = datetime.datetime.now()
Ryan Cui1562fb82011-05-09 11:01:31 -07002351 found_error = False
David James2edd9002013-10-11 14:09:19 -07002352 if not worktree_list:
2353 worktree_list = [None] * len(project_list)
2354 for project, worktree in zip(project_list, worktree_list):
2355 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07002356 found_error = True
2357
Mike Frysingered1b95a2019-12-12 19:04:51 -05002358 end_time = datetime.datetime.now()
2359 color = terminal.Color()
Mike Frysingerae409522014-02-01 03:16:11 -05002360 if found_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002361 msg = ('%s: Preupload failed due to above error(s).\n'
Ryan Cui9b651632011-05-11 11:38:58 -07002362 '- To disable some source style checks, and for other hints, see '
Mike Frysingered1b95a2019-12-12 19:04:51 -05002363 '<checkout_dir>/src/repohooks/README.md\n'
2364 "- To upload only current project, run 'repo upload .'" %
2365 (color.Color(color.RED, 'FATAL'),))
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04002366 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07002367 sys.exit(1)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002368 else:
2369 msg = ('[%s] repohooks passed in %s' %
2370 (color.Color(color.GREEN, 'PASSED'), end_time - start_time))
2371 print(msg)
Anush Elangovan63afad72011-03-23 00:41:27 -07002372
Ryan Cui1562fb82011-05-09 11:01:31 -07002373
Doug Anderson44a644f2011-11-02 10:37:37 -07002374def _identify_project(path):
2375 """Identify the repo project associated with the given path.
2376
2377 Returns:
2378 A string indicating what project is associated with the path passed in or
2379 a blank string upon failure.
2380 """
2381 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002382 stderr=True, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002383
2384
Mike Frysinger55f85b52014-12-18 14:45:21 -05002385def direct_main(argv):
Doug Anderson44a644f2011-11-02 10:37:37 -07002386 """Run hooks directly (outside of the context of repo).
2387
Doug Anderson44a644f2011-11-02 10:37:37 -07002388 Args:
Mike Frysinger55f85b52014-12-18 14:45:21 -05002389 argv: The command line args to process
Doug Anderson44a644f2011-11-02 10:37:37 -07002390
2391 Returns:
2392 0 if no pre-upload failures, 1 if failures.
2393
2394 Raises:
2395 BadInvocation: On some types of invocation errors.
2396 """
Mike Frysinger66142932014-12-18 14:55:57 -05002397 parser = commandline.ArgumentParser(description=__doc__)
2398 parser.add_argument('--dir', default=None,
2399 help='The directory that the project lives in. If not '
2400 'specified, use the git project root based on the cwd.')
2401 parser.add_argument('--project', default=None,
2402 help='The project repo path; this can affect how the '
2403 'hooks get run, since some hooks are project-specific. '
2404 'For chromite this is chromiumos/chromite. If not '
2405 'specified, the repo tool will be used to figure this '
2406 'out based on the dir.')
2407 parser.add_argument('--rerun-since', default=None,
Vadim Bendebury75447b92018-01-10 12:06:01 -08002408 help='Rerun hooks on old commits since some point '
2409 'in the past. The argument could be a date (should '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002410 "match git log's concept of a date, e.g. 2012-06-20), "
Vadim Bendebury75447b92018-01-10 12:06:01 -08002411 'or a SHA1, or just a number of commits to check (from 1 '
2412 'to 99). This option is mutually exclusive with '
2413 '--pre-submit.')
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002414 parser.add_argument('--pre-submit', action='store_true',
Mike Frysinger66142932014-12-18 14:55:57 -05002415 help='Run the check against the pending commit. '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002416 "This option should be used at the 'git commit' "
2417 "phase as opposed to 'repo upload'. This option "
Mike Frysinger66142932014-12-18 14:55:57 -05002418 'is mutually exclusive with --rerun-since.')
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002419 parser.add_argument('--presubmit-config',
2420 help='Specify presubmit config file to be used.')
Mike Frysinger66142932014-12-18 14:55:57 -05002421 parser.add_argument('commits', nargs='*',
2422 help='Check specific commits')
2423 opts = parser.parse_args(argv)
Doug Anderson44a644f2011-11-02 10:37:37 -07002424
Doug Anderson14749562013-06-26 13:38:29 -07002425 if opts.rerun_since:
Mike Frysinger66142932014-12-18 14:55:57 -05002426 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002427 raise BadInvocation("Can't pass commits and use rerun-since: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002428 ' '.join(opts.commits))
Doug Anderson14749562013-06-26 13:38:29 -07002429
Vadim Bendebury75447b92018-01-10 12:06:01 -08002430 if len(opts.rerun_since) < 3 and opts.rerun_since.isdigit():
2431 # This must be the number of commits to check. We don't expect the user
2432 # to want to check more than 99 commits.
2433 limit = '-n%s' % opts.rerun_since
2434 elif git.IsSHA1(opts.rerun_since, False):
2435 limit = '%s..' % opts.rerun_since
2436 else:
2437 # This better be a date.
2438 limit = '--since=%s' % opts.rerun_since
2439 cmd = ['git', 'log', limit, '--pretty=%H']
Doug Anderson14749562013-06-26 13:38:29 -07002440 all_commits = _run_command(cmd).splitlines()
2441 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
2442
2443 # Eliminate chrome-bot commits but keep ordering the same...
2444 bot_commits = set(bot_commits)
Mike Frysinger66142932014-12-18 14:55:57 -05002445 opts.commits = [c for c in all_commits if c not in bot_commits]
Doug Anderson14749562013-06-26 13:38:29 -07002446
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002447 if opts.pre_submit:
2448 raise BadInvocation('rerun-since and pre-submit can not be '
2449 'used together')
2450 if opts.pre_submit:
Mike Frysinger66142932014-12-18 14:55:57 -05002451 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002452 raise BadInvocation("Can't pass commits and use pre-submit: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002453 ' '.join(opts.commits))
2454 opts.commits = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07002455
2456 # Check/normlaize git dir; if unspecified, we'll use the root of the git
2457 # project from CWD
2458 if opts.dir is None:
2459 git_dir = _run_command(['git', 'rev-parse', '--git-dir'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002460 stderr=True).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002461 if not git_dir:
2462 raise BadInvocation('The current directory is not part of a git project.')
2463 opts.dir = os.path.dirname(os.path.abspath(git_dir))
2464 elif not os.path.isdir(opts.dir):
2465 raise BadInvocation('Invalid dir: %s' % opts.dir)
2466 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
2467 raise BadInvocation('Not a git directory: %s' % opts.dir)
2468
2469 # Identify the project if it wasn't specified; this _requires_ the repo
2470 # tool to be installed and for the project to be part of a repo checkout.
2471 if not opts.project:
2472 opts.project = _identify_project(opts.dir)
2473 if not opts.project:
2474 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
2475
Doug Anderson14749562013-06-26 13:38:29 -07002476 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Mike Frysinger66142932014-12-18 14:55:57 -05002477 commit_list=opts.commits,
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002478 presubmit=opts.pre_submit,
2479 config_file=opts.presubmit_config)
Doug Anderson44a644f2011-11-02 10:37:37 -07002480 if found_error:
2481 return 1
2482 return 0
2483
2484
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002485if __name__ == '__main__':
Mike Frysinger55f85b52014-12-18 14:45:21 -05002486 sys.exit(direct_main(sys.argv[1:]))