blob: e22a032940c27aee50d41b4c9ce15c9c7b04526c [file] [log] [blame]
Mike Frysinger4f994402019-09-13 17:40:45 -04001#!/usr/bin/env python3
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002# -*- coding: utf-8 -*-
Jon Salz98255932012-08-18 14:48:02 +08003# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
Mike Frysingerae409522014-02-01 03:16:11 -05007"""Presubmit checks to run when doing `repo upload`.
8
9You can add new checks by adding a functions to the HOOKS constants.
10"""
11
Mike Frysinger09d6a3d2013-10-08 22:21:03 -040012from __future__ import print_function
13
Keigo Okadd908822019-06-04 11:30:25 +090014import argparse
Alex Deymo643ac4c2015-09-03 10:40:50 -070015import collections
Mike Frysingerf252cfc2019-12-09 17:34:28 -050016import configparser
Keigo Oka7e880ac2019-07-03 15:03:43 +090017import datetime
Daniel Erate3ea3fc2015-02-13 15:27:52 -070018import fnmatch
Jon Salz3ee59de2012-08-18 13:54:22 +080019import functools
Dale Curtis2975c432011-05-03 17:25:20 -070020import json
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070021import os
Ryan Cuiec4d6332011-05-02 14:15:25 -070022import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070023import sys
Peter Ammon811f6702014-06-12 15:45:38 -070024import stat
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -050025import subprocess
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070026
Ryan Cui1562fb82011-05-09 11:01:31 -070027from errors import (VerifyException, HookFailure, PrintErrorForProject,
28 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070029
Mike Frysinger919c7032019-09-13 17:48:08 -040030if __name__ in ('__builtin__', 'builtins'):
Mike Frysinger653cd262019-09-20 14:05:02 -040031 # If repo imports us, the __name__ will be __builtin__, and the cwd will be in
32 # the top level of the checkout (i.e. $CHROMEOS_CHECKOUT). chromite will be
33 # in that directory, so add it to our path. This works whether we're running
34 # the repo in $CHROMEOS_CHECKOUT/.repo/repo/ or a custom version in a
35 # completely different tree.
36 # TODO(vapier): Python 2 used "__builtin__" while Python 3 uses "builtins".
Mike Frysinger6850d512018-05-21 12:12:14 -040037 sys.path.insert(0, os.getcwd())
38
Mike Frysinger653cd262019-09-20 14:05:02 -040039elif __name__ == '__main__':
40 # If we're run directly, we'll find chromite relative to the repohooks dir in
41 # $CHROMEOS_CHECKOUT/src/repohooks, so go up two dirs.
David Jamesc3b68b32013-04-03 09:17:03 -070042 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
43
Mike Frysingerfd481ce2019-09-13 18:14:48 -040044# The sys.path monkey patching confuses the linter.
45# pylint: disable=wrong-import-position
Mike Frysinger66142932014-12-18 14:55:57 -050046from chromite.lib import commandline
Rahul Chaudhry0e515342015-08-07 12:00:43 -070047from chromite.lib import cros_build_lib
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050048from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070049from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070050from chromite.lib import patch
Mike Frysingered1b95a2019-12-12 19:04:51 -050051from chromite.lib import terminal
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040052from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070053
Mike Frysingerff4768e2020-02-27 18:48:13 -050054
55assert sys.version_info >= (3, 6), 'This module requires Python 3.6+'
56
57
Vadim Bendebury2b62d742014-06-22 13:14:51 -070058PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070059
Mike Frysingered9b2a02019-12-12 18:52:32 -050060
61# Link to commit message documentation for users.
62DOC_COMMIT_MSG_URL = ('https://chromium.googlesource.com/chromiumos/docs/+/HEAD'
63 '/contributing.md#commit-messages')
64
65
Ryan Cuiec4d6332011-05-02 14:15:25 -070066COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050067 # C++ and friends
Mike Frysinger24dd3c52019-08-17 14:22:48 -040068 r'.*\.c$', r'.*\.cc$', r'.*\.cpp$', r'.*\.h$', r'.*\.m$', r'.*\.mm$',
69 r'.*\.inl$', r'.*\.asm$', r'.*\.hxx$', r'.*\.hpp$', r'.*\.s$', r'.*\.S$',
Mike Frysingerae409522014-02-01 03:16:11 -050070 # Scripts
Mike Frysinger24dd3c52019-08-17 14:22:48 -040071 r'.*\.js$', r'.*\.py$', r'.*\.sh$', r'.*\.rb$', r'.*\.pl$', r'.*\.pm$',
Mike Frysingerae409522014-02-01 03:16:11 -050072 # No extension at all, note that ALL CAPS files are black listed in
73 # COMMON_EXCLUDED_LIST below.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040074 r'(^|.*[\\\/])[^.]+$',
Mike Frysingerae409522014-02-01 03:16:11 -050075 # Other
Mike Frysinger24dd3c52019-08-17 14:22:48 -040076 r'.*\.java$', r'.*\.mk$', r'.*\.am$',
77 r'.*\.policy$', r'.*\.conf$', r'.*\.go$',
78 r'(^OWNERS|/OWNERS)',
Ryan Cuiec4d6332011-05-02 14:15:25 -070079]
80
Ryan Cui1562fb82011-05-09 11:01:31 -070081
Ryan Cuiec4d6332011-05-02 14:15:25 -070082COMMON_EXCLUDED_PATHS = [
Daniel Erate3ea3fc2015-02-13 15:27:52 -070083 # For ebuild trees, ignore any caches and manifest data.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040084 r'.*/Manifest$',
85 r'.*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$',
Doug Anderson5bfb6792011-10-25 16:45:41 -070086
Daniel Erate3ea3fc2015-02-13 15:27:52 -070087 # Ignore profiles data (like overlay-tegra2/profiles).
Mike Frysinger24dd3c52019-08-17 14:22:48 -040088 r'(^|.*/)overlay-.*/profiles/.*',
89 r'^profiles/.*$',
Mike Frysinger98638102014-08-28 00:15:08 -040090
C Shapiro8f90e9b2017-06-28 09:54:50 -060091 # Ignore config files in ebuild setup.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040092 r'(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*',
93 r'^chromeos-base/chromeos-bsp.*/files/.*',
C Shapiro8f90e9b2017-06-28 09:54:50 -060094
Daniel Erate3ea3fc2015-02-13 15:27:52 -070095 # Ignore minified js and jquery.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040096 r'.*\.min\.js',
97 r'.*jquery.*\.js',
Mike Frysinger33a458d2014-03-03 17:00:51 -050098
99 # Ignore license files as the content is often taken verbatim.
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400100 r'.*/licenses/.*',
Alex Klein619c0912019-01-30 17:13:23 -0700101
Mike Frysinger13650402019-07-31 14:31:46 -0400102 # Exclude generated protobuf bindings.
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400103 r'.*_pb2\.py$',
104 r'.*\.pb\.go$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700105]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700106
Ken Turnerd07564b2018-02-08 17:57:59 +1100107LICENSE_EXCLUDED_PATHS = [
LaMont Jones775c2b32020-02-19 17:32:54 -0700108 r'^(.*/)?OWNERS(\..*)?$',
Ken Turnerd07564b2018-02-08 17:57:59 +1100109]
Ryan Cui1562fb82011-05-09 11:01:31 -0700110
Ryan Cui9b651632011-05-11 11:38:58 -0700111_CONFIG_FILE = 'PRESUBMIT.cfg'
112
113
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700114# File containing wildcards, one per line, matching files that should be
115# excluded from presubmit checks. Lines beginning with '#' are ignored.
116_IGNORE_FILE = '.presubmitignore'
117
Cheng Yuehb707c522020-01-02 14:06:59 +0800118
119TEST_FIELD_RE = r'\nTEST=\S+'
120
Doug Anderson44a644f2011-11-02 10:37:37 -0700121# Exceptions
122
123
124class BadInvocation(Exception):
125 """An Exception indicating a bad invocation of the program."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700126
127
Ryan Cui1562fb82011-05-09 11:01:31 -0700128# General Helpers
129
Sean Paulba01d402011-05-05 11:36:23 -0400130
Mike Frysingerb2496652019-09-12 23:35:46 -0400131class Cache(object):
132 """General helper for caching git content."""
133
134 def __init__(self):
135 self._cache = {}
136
137 def get_subcache(self, scope):
138 return self._cache.setdefault(scope, {})
139
140 def clear(self):
141 self._cache.clear()
142
143CACHE = Cache()
144
145
Alex Deymo643ac4c2015-09-03 10:40:50 -0700146Project = collections.namedtuple('Project', ['name', 'dir', 'remote'])
147
148
Mike Frysinger526a5f82019-09-13 18:05:30 -0400149def _run_command(cmd, **kwargs):
Doug Anderson44a644f2011-11-02 10:37:37 -0700150 """Executes the passed in command and returns raw stdout output.
151
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400152 This is a convenience func to set some run defaults differently.
Mike Frysinger526a5f82019-09-13 18:05:30 -0400153
Doug Anderson44a644f2011-11-02 10:37:37 -0700154 Args:
155 cmd: The command to run; should be a list of strings.
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400156 **kwargs: Same as cros_build_lib.run.
Doug Anderson44a644f2011-11-02 10:37:37 -0700157
158 Returns:
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700159 The stdout from the process (discards stderr and returncode).
Doug Anderson44a644f2011-11-02 10:37:37 -0700160 """
Mike Frysinger526a5f82019-09-13 18:05:30 -0400161 kwargs.setdefault('print_cmd', False)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400162 kwargs.setdefault('stdout', True)
163 kwargs.setdefault('check', False)
Mike Frysinger054c1592019-11-18 03:51:54 -0500164 result = cros_build_lib.run(cmd, **kwargs)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400165 # NB: We decode this directly rather than through kwargs as our tests rely
166 # on this post-processing behavior currently.
Mike Frysinger71e643e2019-09-13 17:26:39 -0400167 return result.output.decode('utf-8', 'replace')
Ryan Cui72834d12011-05-05 14:51:33 -0700168
Ryan Cui1562fb82011-05-09 11:01:31 -0700169
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700170def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700171 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700172 if __name__ == '__main__':
173 # Works when file is run on its own (__file__ is defined)...
174 return os.path.abspath(os.path.dirname(__file__))
175 else:
176 # We need to do this when we're run through repo. Since repo executes
177 # us with execfile(), we don't get __file__ defined.
178 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
179 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700180
Ryan Cui1562fb82011-05-09 11:01:31 -0700181
Ryan Cuiec4d6332011-05-02 14:15:25 -0700182def _match_regex_list(subject, expressions):
183 """Try to match a list of regular expressions to a string.
184
185 Args:
186 subject: The string to match regexes on
187 expressions: A list of regular expressions to check for matches with.
188
189 Returns:
190 Whether the passed in subject matches any of the passed in regexes.
191 """
192 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500193 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700194 return True
195 return False
196
Ryan Cui1562fb82011-05-09 11:01:31 -0700197
Mike Frysingerae409522014-02-01 03:16:11 -0500198def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700199 """Filter out files based on the conditions passed in.
200
201 Args:
202 files: list of filepaths to filter
203 include_list: list of regex that when matched with a file path will cause it
204 to be added to the output list unless the file is also matched with a
205 regex in the exclude_list.
206 exclude_list: list of regex that when matched with a file will prevent it
207 from being added to the output list, even if it is also matched with a
208 regex in the include_list.
209
210 Returns:
211 A list of filepaths that contain files matched in the include_list and not
212 in the exclude_list.
213 """
214 filtered = []
215 for f in files:
216 if (_match_regex_list(f, include_list) and
217 not _match_regex_list(f, exclude_list)):
218 filtered.append(f)
219 return filtered
220
Ryan Cuiec4d6332011-05-02 14:15:25 -0700221
222# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700223
224
Ryan Cui4725d952011-05-05 15:41:19 -0700225def _get_upstream_branch():
226 """Returns the upstream tracking branch of the current branch.
227
228 Raises:
229 Error if there is no tracking branch
230 """
231 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
232 current_branch = current_branch.replace('refs/heads/', '')
233 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700234 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700235
236 cfg_option = 'branch.' + current_branch + '.%s'
237 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
238 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
239 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700240 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700241
242 return full_upstream.replace('heads', 'remotes/' + remote)
243
Ryan Cui1562fb82011-05-09 11:01:31 -0700244
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700245def _get_patch(commit):
246 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700247 if commit == PRE_SUBMIT:
248 return _run_command(['git', 'diff', '--cached', 'HEAD'])
249 else:
250 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700251
Ryan Cui1562fb82011-05-09 11:01:31 -0700252
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500253def _get_file_content(path, commit):
254 """Returns the content of a file at a specific commit.
255
256 We can't rely on the file as it exists in the filesystem as people might be
257 uploading a series of changes which modifies the file multiple times.
258
259 Note: The "content" of a symlink is just the target. So if you're expecting
260 a full file, you should check that first. One way to detect is that the
261 content will not have any newlines.
262 """
Mike Frysingerb2496652019-09-12 23:35:46 -0400263 # Make sure people don't accidentally pass in full paths which will never
264 # work. You need to use relative=True with _get_affected_files.
265 if path.startswith('/'):
266 raise ValueError('_get_file_content must be called with relative paths: %s'
267 % (path,))
268
269 # {<commit>: {<path1>: <content>, <path2>: <content>}}
270 cache = CACHE.get_subcache('get_file_content')
271 if path in cache:
272 return cache[path]
273
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700274 if commit == PRE_SUBMIT:
Mike Frysingerb2496652019-09-12 23:35:46 -0400275 content = _run_command(['git', 'diff', 'HEAD', path])
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700276 else:
Mike Frysingerb2496652019-09-12 23:35:46 -0400277 content = _run_command(['git', 'show', '%s:%s' % (commit, path)])
278 cache[path] = content
279 return content
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500280
281
Mike Frysingerae409522014-02-01 03:16:11 -0500282def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700283 """Returns a list of (linenum, lines) tuples that the commit touched."""
Mike Frysingerb2496652019-09-12 23:35:46 -0400284 # {<commit>: {<path1>: <content>, <path2>: <content>}}
285 cache = CACHE.get_subcache('get_file_diff')
286 if path in cache:
287 return cache[path]
288
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700289 if commit == PRE_SUBMIT:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800290 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD',
291 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700292 else:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800293 command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit,
294 path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700295 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700296
297 new_lines = []
298 line_num = 0
299 for line in output.splitlines():
300 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
301 if m:
302 line_num = int(m.groups(1)[0])
303 continue
304 if line.startswith('+') and not line.startswith('++'):
Mike Frysinger71e643e2019-09-13 17:26:39 -0400305 new_lines.append((line_num, line[1:]))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700306 if not line.startswith('-'):
307 line_num += 1
Mike Frysingerb2496652019-09-12 23:35:46 -0400308 cache[path] = new_lines
Ryan Cuiec4d6332011-05-02 14:15:25 -0700309 return new_lines
310
Ryan Cui1562fb82011-05-09 11:01:31 -0700311
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700312def _get_ignore_wildcards(directory, cache):
313 """Get wildcards listed in a directory's _IGNORE_FILE.
314
315 Args:
316 directory: A string containing a directory path.
317 cache: A dictionary (opaque to caller) caching previously-read wildcards.
318
319 Returns:
320 A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE
321 wasn't present.
322 """
323 # In the cache, keys are directories and values are lists of wildcards from
324 # _IGNORE_FILE within those directories (and empty if no file was present).
325 if directory not in cache:
326 wildcards = []
327 dotfile_path = os.path.join(directory, _IGNORE_FILE)
328 if os.path.exists(dotfile_path):
329 # TODO(derat): Consider using _get_file_content() to get the file as of
330 # this commit instead of the on-disk version. This may have a noticeable
331 # performance impact, as each call to _get_file_content() runs git.
332 with open(dotfile_path, 'r') as dotfile:
333 for line in dotfile.readlines():
334 line = line.strip()
335 if line.startswith('#'):
336 continue
337 if line.endswith('/'):
338 line += '*'
339 wildcards.append(line)
340 cache[directory] = wildcards
341
342 return cache[directory]
343
344
345def _path_is_ignored(path, cache):
346 """Check whether a path is ignored by _IGNORE_FILE.
347
348 Args:
349 path: A string containing a path.
350 cache: A dictionary (opaque to caller) caching previously-read wildcards.
351
352 Returns:
353 True if a file named _IGNORE_FILE in one of the passed-in path's parent
354 directories contains a wildcard matching the path.
355 """
356 # Skip ignore files.
357 if os.path.basename(path) == _IGNORE_FILE:
358 return True
359
360 path = os.path.abspath(path)
361 base = os.getcwd()
362
363 prefix = os.path.dirname(path)
364 while prefix.startswith(base):
365 rel_path = path[len(prefix) + 1:]
366 for wildcard in _get_ignore_wildcards(prefix, cache):
367 if fnmatch.fnmatch(rel_path, wildcard):
368 return True
369 prefix = os.path.dirname(prefix)
370
371 return False
372
373
Mike Frysinger292b45d2014-11-25 01:17:10 -0500374def _get_affected_files(commit, include_deletes=False, relative=False,
375 include_symlinks=False, include_adds=True,
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700376 full_details=False, use_ignore_files=True):
Peter Ammon811f6702014-06-12 15:45:38 -0700377 """Returns list of file paths that were modified/added, excluding symlinks.
378
379 Args:
380 commit: The commit
381 include_deletes: If true, we'll include deleted files in the result
382 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500383 include_symlinks: If true, we'll include symlinks in the result
384 include_adds: If true, we'll include new files in the result
385 full_details: If False, return filenames, else return structured results.
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700386 use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files.
Peter Ammon811f6702014-06-12 15:45:38 -0700387
388 Returns:
389 A list of modified/added (and perhaps deleted) files
390 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500391 if not relative and full_details:
392 raise ValueError('full_details only supports relative paths currently')
393
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700394 if commit == PRE_SUBMIT:
395 return _run_command(['git', 'diff-index', '--cached',
396 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500397
398 path = os.getcwd()
Mike Frysingerb2496652019-09-12 23:35:46 -0400399 # {<commit>: {<path1>: <content>, <path2>: <content>}}
400 cache = CACHE.get_subcache('get_affected_files')
401 if path not in cache:
402 cache[path] = git.RawDiff(path, '%s^!' % commit)
403 files = cache[path]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500404
405 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500406 if not include_symlinks:
407 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500408
409 if not include_deletes:
410 files = [x for x in files if x.status != 'D']
411
Mike Frysinger292b45d2014-11-25 01:17:10 -0500412 if not include_adds:
413 files = [x for x in files if x.status != 'A']
414
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700415 if use_ignore_files:
416 cache = {}
417 is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache)
418 files = [x for x in files if not is_ignored(x)]
419
Mike Frysinger292b45d2014-11-25 01:17:10 -0500420 if full_details:
421 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500422 return files
423 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500424 # Caller only cares about filenames.
425 files = [x.dst_file if x.dst_file else x.src_file for x in files]
426 if relative:
427 return files
428 else:
429 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700430
431
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700432def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700433 """Returns a list of commits for this review."""
Mike Frysingere300c7d2019-09-12 23:33:52 -0400434 cmd = ['git', 'log', '--no-merges', '--format=%H',
435 '%s..' % _get_upstream_branch()]
Ryan Cui72834d12011-05-05 14:51:33 -0700436 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700437
Ryan Cui1562fb82011-05-09 11:01:31 -0700438
Ryan Cuiec4d6332011-05-02 14:15:25 -0700439def _get_commit_desc(commit):
440 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700441 if commit == PRE_SUBMIT:
442 return ''
Mike Frysingerb2496652019-09-12 23:35:46 -0400443
444 # {<commit>: <content>}
445 cache = CACHE.get_subcache('get_commit_desc')
446 if commit not in cache:
Mike Frysinger4efdee72019-11-04 10:57:01 -0500447 cache[commit] = _run_command(['git', 'log', '--format=%B',
Mike Frysingerb2496652019-09-12 23:35:46 -0400448 commit + '^!'])
449 return cache[commit]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700450
451
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800452def _check_lines_in_diff(commit, files, check_callable, error_description):
453 """Checks given file for errors via the given check.
454
455 This is a convenience function for common per-line checks. It goes through all
456 files and returns a HookFailure with the error description listing all the
457 failures.
458
459 Args:
460 commit: The commit we're working on.
461 files: The files to check.
462 check_callable: A callable that takes a line and returns True if this line
463 _fails_ the check.
464 error_description: A string describing the error.
465 """
466 errors = []
467 for afile in files:
468 for line_num, line in _get_file_diff(afile, commit):
469 if check_callable(line):
470 errors.append('%s, line %s' % (afile, line_num))
471 if errors:
472 return HookFailure(error_description, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400473 return None
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800474
475
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900476def _parse_common_inclusion_options(options):
477 """Parses common hook options for including/excluding files.
478
479 Args:
480 options: Option string list.
481
482 Returns:
483 (included, excluded) where each one is a list of regex strings.
484 """
485 parser = argparse.ArgumentParser()
486 parser.add_argument('--exclude_regex', action='append')
487 parser.add_argument('--include_regex', action='append')
488 opts = parser.parse_args(options)
489 included = opts.include_regex or []
490 excluded = opts.exclude_regex or []
491 return included, excluded
492
493
Ryan Cuiec4d6332011-05-02 14:15:25 -0700494# Common Hooks
495
Ryan Cui1562fb82011-05-09 11:01:31 -0700496
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900497def _check_no_long_lines(_project, commit, options=()):
Mike Frysinger55f85b52014-12-18 14:45:21 -0500498 """Checks there are no lines longer than MAX_LEN in any of the text files."""
Keigo Oka9732e382019-06-28 17:44:59 +0900499 LONG_LINE_OK_PATHS = [
500 # Go has no line length limit.
501 # https://golang.org/doc/effective_go.html#formatting
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400502 r'.*\.go$',
Mike Frysingerf8961942020-05-15 00:36:31 -0400503 # Python does its own long line checks via pylint.
504 r'.*\.py$',
Keigo Oka9732e382019-06-28 17:44:59 +0900505 ]
Mike Frysinger55f85b52014-12-18 14:45:21 -0500506
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900507 DEFAULT_MAX_LENGTHS = [
508 # Java's line length limit is 100 chars.
509 # https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md
510 (r'.*\.java$', 100),
Mike Frysingerf8961942020-05-15 00:36:31 -0400511 # Rust's line length limit is 100 chars.
512 (r'.*\.rs$', 100),
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900513 ]
514
Ryan Cuiec4d6332011-05-02 14:15:25 -0700515 MAX_LEN = 80
516
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900517 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700518 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900519 included + COMMON_INCLUDED_PATHS,
Keigo Oka9732e382019-06-28 17:44:59 +0900520 excluded + COMMON_EXCLUDED_PATHS + LONG_LINE_OK_PATHS)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700521
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900522 errors = []
Ryan Cuiec4d6332011-05-02 14:15:25 -0700523 for afile in files:
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700524 skip_regexps = (
525 r'https?://',
526 r'^#\s*(define|include|import|pragma|if|ifndef|endif)\b',
527 )
528
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900529 max_len = MAX_LEN
530
531 for expr, length in DEFAULT_MAX_LENGTHS:
532 if re.search(expr, afile):
533 max_len = length
534 break
535
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700536 if os.path.basename(afile).startswith('OWNERS'):
537 # File paths can get long, and there's no way to break them up into
538 # multiple lines.
539 skip_regexps += (
540 r'^include\b',
541 r'file:',
542 )
543
544 skip_regexps = [re.compile(x) for x in skip_regexps]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700545 for line_num, line in _get_file_diff(afile, commit):
546 # Allow certain lines to exceed the maxlen rule.
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900547 if len(line) <= max_len or any(x.search(line) for x in skip_regexps):
Jon Salz98255932012-08-18 14:48:02 +0800548 continue
549
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900550 errors.append('%s, line %s, %s chars, over %s chars' %
551 (afile, line_num, len(line), max_len))
Jon Salz98255932012-08-18 14:48:02 +0800552 if len(errors) == 5: # Just show the first 5 errors.
553 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700554
555 if errors:
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900556 msg = 'Found lines longer than the limit (first 5 shown):'
Ryan Cui1562fb82011-05-09 11:01:31 -0700557 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400558 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700559
Ryan Cuiec4d6332011-05-02 14:15:25 -0700560
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900561def _check_no_stray_whitespace(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700562 """Checks that there is no stray whitespace at source lines end."""
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900563 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700564 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900565 included + COMMON_INCLUDED_PATHS,
566 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800567 return _check_lines_in_diff(commit, files,
568 lambda line: line.rstrip() != line,
569 'Found line ending with white space in:')
Ryan Cui1562fb82011-05-09 11:01:31 -0700570
Ryan Cuiec4d6332011-05-02 14:15:25 -0700571
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900572def _check_no_tabs(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700573 """Checks there are no unexpanded tabs."""
Mike Frysingercd134512017-10-26 04:36:33 -0400574 # Don't add entire repos here. Update the PRESUBMIT.cfg in each repo instead.
575 # We only whitelist known specific filetypes here that show up in all repos.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700576 TAB_OK_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400577 r'.*\.ebuild$',
578 r'.*\.eclass$',
579 r'.*\.go$',
580 r'.*/[M|m]akefile$',
581 r'.*\.mk$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700582 ]
583
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900584 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700585 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900586 included + COMMON_INCLUDED_PATHS,
587 excluded + COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800588 return _check_lines_in_diff(commit, files,
589 lambda line: '\t' in line,
590 'Found a tab character in:')
Ryan Cuiec4d6332011-05-02 14:15:25 -0700591
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800592
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900593def _check_tabbed_indents(_project, commit, options=()):
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800594 """Checks that indents use tabs only."""
595 TABS_REQUIRED_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400596 r'.*\.ebuild$',
597 r'.*\.eclass$',
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800598 ]
599 LEADING_SPACE_RE = re.compile('[\t]* ')
600
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900601 included, excluded = _parse_common_inclusion_options(options)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800602 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900603 included + TABS_REQUIRED_PATHS,
604 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800605 return _check_lines_in_diff(
606 commit, files,
607 lambda line: LEADING_SPACE_RE.match(line) is not None,
608 'Found a space in indentation (must be all tabs):')
Ryan Cui1562fb82011-05-09 11:01:31 -0700609
Ryan Cuiec4d6332011-05-02 14:15:25 -0700610
LaMont Jones872fe762020-02-10 15:36:14 -0700611def _check_gofmt(_project, commit, options=()):
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700612 """Checks that Go files are formatted with gofmt."""
LaMont Jones872fe762020-02-10 15:36:14 -0700613 included, excluded = _parse_common_inclusion_options(options)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700614 errors = []
615 files = _filter_files(_get_affected_files(commit, relative=True),
LaMont Jones872fe762020-02-10 15:36:14 -0700616 included + [r'\.go$'],
617 excluded)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700618
619 for gofile in files:
620 contents = _get_file_content(gofile, commit)
Mike Frysingeraa7dc942019-09-25 00:07:24 -0400621 output = _run_command(cmd=['gofmt', '-l'], input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500622 stderr=subprocess.STDOUT)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700623 if output:
624 errors.append(gofile)
625 if errors:
626 return HookFailure('Files not formatted with gofmt:', errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400627 return None
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700628
629
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600630def _check_rustfmt(_project, commit):
631 """Checks that Rust files are formatted with rustfmt."""
632 errors = []
633 files = _filter_files(_get_affected_files(commit, relative=True),
634 [r'\.rs$'])
635
636 for rustfile in files:
637 contents = _get_file_content(rustfile, commit)
Chirantan Ekbote1da56d52020-07-13 17:35:35 +0900638 output = _run_command(cmd=['rustfmt', '--edition', '2018'],
639 input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500640 stderr=subprocess.STDOUT)
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600641 if output != contents:
642 errors.append(rustfile)
643 if errors:
644 return HookFailure('Files not formatted with rustfmt: '
645 "(run 'cargo fmt' to fix)", errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400646 return None
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600647
648
Mike Frysingerae409522014-02-01 03:16:11 -0500649def _check_change_has_test_field(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700650 """Check for a non-empty 'TEST=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500651 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700652
Cheng Yuehb707c522020-01-02 14:06:59 +0800653 if not re.search(TEST_FIELD_RE, _get_commit_desc(commit)):
Mike Frysingered9b2a02019-12-12 18:52:32 -0500654 msg = ('Changelist description needs TEST field (after first line)\n%s' %
655 (SEE_ALSO,))
Ryan Cui1562fb82011-05-09 11:01:31 -0700656 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400657 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700658
Ryan Cuiec4d6332011-05-02 14:15:25 -0700659
Mike Frysingerae409522014-02-01 03:16:11 -0500660def _check_change_has_valid_cq_depend(_project, commit):
Jason D. Clinton299e3222019-05-23 09:42:03 -0600661 """Check for a correctly formatted Cq-Depend field in the commit message."""
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700662 desc = _get_commit_desc(commit)
Jason D. Clinton299e3222019-05-23 09:42:03 -0600663 msg = 'Changelist has invalid Cq-Depend target.'
664 example = 'Example: Cq-Depend: chromium:1234, chrome-internal:2345'
David Jamesc3b68b32013-04-03 09:17:03 -0700665 try:
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700666 patch.GetPaladinDeps(desc)
David Jamesc3b68b32013-04-03 09:17:03 -0700667 except ValueError as ex:
668 return HookFailure(msg, [example, str(ex)])
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700669 # Check that Cq-Depend is in the same paragraph as Change-Id.
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500670 msg = 'Cq-Depend is not in the same paragraph as Change-Id.'
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700671 paragraphs = desc.split('\n\n')
672 for paragraph in paragraphs:
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500673 if (re.search(r'^Cq-Depend:', paragraph, re.M) and not
674 re.search('^Change-Id:', paragraph, re.M)):
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700675 return HookFailure(msg)
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500676
677 # We no longer support CQ-DEPEND= lines.
678 if re.search(r'^CQ-DEPEND[=:]', desc, re.M):
679 return HookFailure(
680 'CQ-DEPEND= is no longer supported. Please see:\n'
681 'https://chromium.googlesource.com/chromiumos/docs/+/HEAD/'
682 'contributing.md#CQ-DEPEND')
683
Mike Frysinger8cf80812019-09-16 23:49:29 -0400684 return None
David Jamesc3b68b32013-04-03 09:17:03 -0700685
686
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800687def _check_change_is_contribution(_project, commit):
688 """Check that the change is a contribution."""
689 NO_CONTRIB = 'not a contribution'
690 if NO_CONTRIB in _get_commit_desc(commit).lower():
691 msg = ('Changelist is not a contribution, this cannot be accepted.\n'
692 'Please remove the "%s" text from the commit message.') % NO_CONTRIB
693 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400694 return None
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800695
696
Alex Deymo643ac4c2015-09-03 10:40:50 -0700697def _check_change_has_bug_field(project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700698 """Check for a correctly formatted 'BUG=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500699 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
700
David James5c0073d2013-04-03 08:48:52 -0700701 OLD_BUG_RE = r'\nBUG=.*chromium-os'
702 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
703 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
704 'the chromium tracker in your BUG= line now.')
705 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700706
Alex Deymo643ac4c2015-09-03 10:40:50 -0700707 # Android internal and external projects use "Bug: " to track bugs in
708 # buganizer.
709 BUG_COLON_REMOTES = (
710 'aosp',
711 'goog',
712 )
713 if project.remote in BUG_COLON_REMOTES:
714 BUG_RE = r'\nBug: ?([Nn]one|\d+)'
715 if not re.search(BUG_RE, _get_commit_desc(commit)):
716 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500717 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700718 'Bug: 9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500719 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700720 return HookFailure(msg)
721 else:
Jorge Lucangeli Obesdce214e2017-10-25 15:04:39 -0400722 BUG_RE = r'\nBUG=([Nn]one|(chromium|b):\d+)'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700723 if not re.search(BUG_RE, _get_commit_desc(commit)):
724 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500725 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700726 'BUG=chromium:9999 (for public tracker)\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700727 'BUG=b:9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500728 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700729 return HookFailure(msg)
Ryan Cui1562fb82011-05-09 11:01:31 -0700730
Cheng Yuehb707c522020-01-02 14:06:59 +0800731 TEST_BEFORE_BUG_RE = TEST_FIELD_RE + r'.*' + BUG_RE
732
733 if re.search(TEST_BEFORE_BUG_RE, _get_commit_desc(commit), re.DOTALL):
734 msg = ('The BUG field must come before the TEST field.\n%s' %
735 (SEE_ALSO,))
736 return HookFailure(msg)
737
Mike Frysinger8cf80812019-09-16 23:49:29 -0400738 return None
739
Ryan Cuiec4d6332011-05-02 14:15:25 -0700740
Jack Neus8edbf642019-07-10 16:08:31 -0600741def _check_change_no_include_oem(project, commit):
742 """Check that the change does not reference OEMs."""
743 ALLOWLIST = {
744 'chromiumos/platform/ec',
745 # Used by unit tests.
746 'project',
747 }
748 if project.name not in ALLOWLIST:
749 return None
750
Mike Frysingerbb34a222019-07-31 14:40:46 -0400751 TAGS = {
Jack Neus8edbf642019-07-10 16:08:31 -0600752 'Reviewed-on',
753 'Reviewed-by',
754 'Signed-off-by',
755 'Commit-Ready',
756 'Tested-by',
757 'Commit-Queue',
Jack Neus8edbf642019-07-10 16:08:31 -0600758 'Acked-by',
759 'Modified-by',
760 'CC',
761 'Suggested-by',
762 'Reported-by',
763 'Acked-for-chrome-by',
LaMont Jones237f3ef2020-01-22 10:40:52 -0700764 'Cq-Cl-Tag',
LaMont Jonesfb5e8bf2020-03-03 12:50:06 -0700765 'Cq-Include-Trybots',
Mike Frysingerbb34a222019-07-31 14:40:46 -0400766 }
Jack Neus8edbf642019-07-10 16:08:31 -0600767
768 # Ignore tags, which could reasonably contain OEM names
769 # (e.g. Reviewed-by: foo@oem.corp-partner.google.com).
Jack Neus8edbf642019-07-10 16:08:31 -0600770 commit_message = ' '.join(
Mike Frysingerbb34a222019-07-31 14:40:46 -0400771 x for x in _get_commit_desc(commit).splitlines()
772 if ':' not in x or x.split(':', 1)[0] not in TAGS)
773
Jack Neus8edbf642019-07-10 16:08:31 -0600774 commit_message = re.sub(r'[\s_-]+', ' ', commit_message)
775
776 # Exercise caution when expanding these lists. Adding a name
777 # could indicate a new relationship with a company!
778 OEMS = ['hp', 'hewlett packard', 'dell', 'lenovo', 'acer', 'asus', 'samsung']
779 ODMS = [
780 'bitland', 'compal', 'haier', 'huaqin', 'inventec', 'lg', 'pegatron',
781 'pegatron(ems)', 'quanta', 'samsung', 'wistron'
782 ]
783
784 for name_type, name_list in [('OEM', OEMS), ('ODM', ODMS)]:
785 # Construct regex
786 name_re = r'\b(%s)\b' % '|'.join([re.escape(x) for x in name_list])
787 matches = [x[0] for x in re.findall(name_re, commit_message, re.IGNORECASE)]
Mike Frysingere52b1bc2019-09-16 23:45:41 -0400788 if matches:
Jack Neus8edbf642019-07-10 16:08:31 -0600789 # If there's a match, throw an error.
790 error_msg = ('Changelist description contains the name of an'
791 ' %s: "%s".' % (name_type, '","'.join(matches)))
792 return HookFailure(error_msg)
793
Mike Frysinger8cf80812019-09-16 23:49:29 -0400794 return None
795
Jack Neus8edbf642019-07-10 16:08:31 -0600796
Mike Frysinger292b45d2014-11-25 01:17:10 -0500797def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -0700798 """Check that we're not missing a revbump of an ebuild in the given commit.
799
800 If the given commit touches files in a directory that has ebuilds somewhere
801 up the directory hierarchy, it's very likely that we need an ebuild revbump
802 in order for those changes to take effect.
803
804 It's not totally trivial to detect a revbump, so at least detect that an
805 ebuild with a revision number in it was touched. This should handle the
806 common case where we use a symlink to do the revbump.
807
808 TODO: it would be nice to enhance this hook to:
809 * Handle cases where people revbump with a slightly different syntax. I see
810 one ebuild (puppy) that revbumps with _pN. This is a false positive.
811 * Catches cases where people aren't using symlinks for revbumps. If they
812 edit a revisioned file directly (and are expected to rename it for revbump)
813 we'll miss that. Perhaps we could detect that the file touched is a
814 symlink?
815
816 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
817 still better off than without this check.
818
819 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700820 project: The Project to look at
Doug Anderson42b8a052013-06-26 10:45:36 -0700821 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -0500822 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -0700823
824 Returns:
825 A HookFailure or None.
826 """
Mike Frysinger011af942014-01-17 16:12:22 -0500827 # If this is the portage-stable overlay, then ignore the check. It's rare
828 # that we're doing anything other than importing files from upstream, so
829 # forcing a rev bump makes no sense.
830 whitelist = (
831 'chromiumos/overlays/portage-stable',
832 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700833 if project.name in whitelist:
Mike Frysinger011af942014-01-17 16:12:22 -0500834 return None
835
Mike Frysinger292b45d2014-11-25 01:17:10 -0500836 def FinalName(obj):
837 # If the file is being deleted, then the dst_file is not set.
838 if obj.dst_file is None:
839 return obj.src_file
840 else:
841 return obj.dst_file
842
843 affected_path_objs = _get_affected_files(
844 commit, include_deletes=True, include_symlinks=True, relative=True,
845 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -0700846
847 # Don't yell about changes to whitelisted files...
Mike Frysinger550c05c2019-12-09 18:16:36 -0500848 whitelist = {'ChangeLog', 'Manifest', 'metadata.xml'}
Mike Frysinger292b45d2014-11-25 01:17:10 -0500849 affected_path_objs = [x for x in affected_path_objs
850 if os.path.basename(FinalName(x)) not in whitelist]
851 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -0700852 return None
853
854 # If we've touched any file named with a -rN.ebuild then we'll say we're
855 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500856 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
857 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700858 if touched_revved_ebuild:
859 return None
860
Mike Frysinger292b45d2014-11-25 01:17:10 -0500861 # If we're creating new ebuilds from scratch, then we don't need an uprev.
862 # Find all the dirs that new ebuilds and ignore their files/.
863 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
864 if FinalName(x).endswith('.ebuild') and x.status == 'A']
865 affected_path_objs = [obj for obj in affected_path_objs
866 if not any(FinalName(obj).startswith(x)
867 for x in ebuild_dirs)]
868 if not affected_path_objs:
Mike Frysinger8cf80812019-09-16 23:49:29 -0400869 return None
Mike Frysinger292b45d2014-11-25 01:17:10 -0500870
Doug Anderson42b8a052013-06-26 10:45:36 -0700871 # We want to examine the current contents of all directories that are parents
872 # of files that were touched (up to the top of the project).
873 #
874 # ...note: we use the current directory contents even though it may have
875 # changed since the commit we're looking at. This is just a heuristic after
876 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500877 if project_top is None:
878 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -0700879 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -0500880 for obj in affected_path_objs:
881 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -0700882 while os.path.exists(path) and not os.path.samefile(path, project_top):
883 dirs_to_check.add(path)
884 path = os.path.dirname(path)
885
886 # Look through each directory. If it's got an ebuild in it then we'll
887 # consider this as a case when we need a revbump.
Gwendal Grignoua3086c32014-12-09 11:17:22 -0800888 affected_paths = set(os.path.join(project_top, FinalName(x))
889 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -0700890 for dir_path in dirs_to_check:
891 contents = os.listdir(dir_path)
892 ebuilds = [os.path.join(dir_path, path)
893 for path in contents if path.endswith('.ebuild')]
894 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
895
C Shapiroae157ae2017-09-18 16:24:03 -0600896 affected_paths_under_9999_ebuilds = set()
897 for affected_path in affected_paths:
898 for ebuild_9999 in ebuilds_9999:
899 ebuild_dir = os.path.dirname(ebuild_9999)
900 if affected_path.startswith(ebuild_dir):
901 affected_paths_under_9999_ebuilds.add(affected_path)
902
903 # If every file changed exists under a 9999 ebuild, then skip
904 if len(affected_paths_under_9999_ebuilds) == len(affected_paths):
905 continue
906
Doug Anderson42b8a052013-06-26 10:45:36 -0700907 # If the -9999.ebuild file was touched the bot will uprev for us.
908 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -0500909 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -0700910 continue
911
912 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500913 return HookFailure('Changelist probably needs a revbump of an ebuild, '
914 'or a -r1.ebuild symlink if this is a new ebuild:\n'
915 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -0700916
917 return None
918
919
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500920def _check_ebuild_eapi(project, commit):
Mike Frysinger948284a2018-02-01 15:22:56 -0500921 """Make sure we have people use EAPI=5 or newer with custom ebuilds.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500922
923 We want to get away from older EAPI's as it makes life confusing and they
924 have less builtin error checking.
925
926 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700927 project: The Project to look at
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500928 commit: The commit to look at
929
930 Returns:
931 A HookFailure or None.
932 """
933 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500934 # that we're doing anything other than importing files from upstream, and
935 # we shouldn't be rewriting things fundamentally anyways.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500936 whitelist = (
937 'chromiumos/overlays/portage-stable',
938 )
Alex Deymo643ac4c2015-09-03 10:40:50 -0700939 if project.name in whitelist:
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500940 return None
941
Mike Frysinger948284a2018-02-01 15:22:56 -0500942 BAD_EAPIS = ('0', '1', '2', '3', '4')
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500943
944 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
945
946 ebuilds_re = [r'\.ebuild$']
947 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
948 ebuilds_re)
949 bad_ebuilds = []
950
951 for ebuild in ebuilds:
952 # If the ebuild does not specify an EAPI, it defaults to 0.
953 eapi = '0'
954
955 lines = _get_file_content(ebuild, commit).splitlines()
956 if len(lines) == 1:
957 # This is most likely a symlink, so skip it entirely.
958 continue
959
960 for line in lines:
961 m = get_eapi.match(line)
962 if m:
963 # Once we hit the first EAPI line in this ebuild, stop processing.
964 # The spec requires that there only be one and it be first, so
965 # checking all possible values is pointless. We also assume that
966 # it's "the" EAPI line and not something in the middle of a heredoc.
967 eapi = m.group(1)
968 break
969
970 if eapi in BAD_EAPIS:
971 bad_ebuilds.append((ebuild, eapi))
972
973 if bad_ebuilds:
974 # pylint: disable=C0301
Mike Frysingerc6114f42020-05-15 00:55:05 -0400975 url = 'https://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500976 # pylint: enable=C0301
977 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -0500978 'These ebuilds are using old EAPIs. If these are imported from\n'
979 'Gentoo, then you may ignore and upload once with the --no-verify\n'
Mike Frysingerc6114f42020-05-15 00:55:05 -0400980 'flag. Otherwise, please update to 7 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500981 '\t%s\n'
982 'See this guide for more details:\n%s\n' %
983 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
984
Mike Frysinger8cf80812019-09-16 23:49:29 -0400985 return None
986
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500987
Mike Frysinger89bdb852014-02-01 05:26:26 -0500988def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -0500989 """Make sure we use the new style KEYWORDS when possible in ebuilds.
990
991 If an ebuild generally does not care about the arch it is running on, then
992 ebuilds should flag it with one of:
993 KEYWORDS="*" # A stable ebuild.
994 KEYWORDS="~*" # An unstable ebuild.
995 KEYWORDS="-* ..." # Is known to only work on specific arches.
996
997 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -0700998 project: The Project to look at
Mike Frysingerc51ece72014-01-17 16:23:40 -0500999 commit: The commit to look at
1000
1001 Returns:
1002 A HookFailure or None.
1003 """
1004 WHITELIST = set(('*', '-*', '~*'))
1005
1006 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
1007
Mike Frysinger89bdb852014-02-01 05:26:26 -05001008 ebuilds_re = [r'\.ebuild$']
1009 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1010 ebuilds_re)
1011
Mike Frysinger8d42d742014-09-22 15:50:21 -04001012 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -05001013 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -04001014 # We get the full content rather than a diff as the latter does not work
1015 # on new files (like when adding new ebuilds).
1016 lines = _get_file_content(ebuild, commit).splitlines()
1017 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -05001018 m = get_keywords.match(line)
1019 if m:
1020 keywords = set(m.group(1).split())
1021 if not keywords or WHITELIST - keywords != WHITELIST:
1022 continue
1023
Mike Frysinger8d42d742014-09-22 15:50:21 -04001024 bad_ebuilds.append(ebuild)
1025
1026 if bad_ebuilds:
1027 return HookFailure(
1028 '%s\n'
1029 'Please update KEYWORDS to use a glob:\n'
1030 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
1031 ' KEYWORDS="*"\n'
1032 'If the ebuild should be marked unstable (normal for '
1033 'cros-workon / 9999 ebuilds):\n'
1034 ' KEYWORDS="~*"\n'
Mike Frysingerde8efea2015-05-17 03:42:26 -04001035 'If the ebuild needs to be marked for only specific arches, '
Mike Frysinger8d42d742014-09-22 15:50:21 -04001036 'then use -* like so:\n'
1037 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -05001038
Mike Frysinger8cf80812019-09-16 23:49:29 -04001039 return None
1040
Mike Frysingerc51ece72014-01-17 16:23:40 -05001041
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001042def _check_ebuild_licenses(_project, commit):
1043 """Check if the LICENSE field in the ebuild is correct."""
Brian Norris7a610e82016-02-17 12:24:54 -08001044 affected_paths = _get_affected_files(commit, relative=True)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001045 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
1046
1047 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -08001048 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001049
1050 for ebuild in touched_ebuilds:
1051 # Skip virutal packages.
1052 if ebuild.split('/')[-3] == 'virtual':
1053 continue
1054
Alex Kleinb5953522018-08-03 11:44:21 -06001055 # e.g. path/to/overlay/category/package/package.ebuild -> path/to/overlay
1056 overlay_path = os.sep.join(ebuild.split(os.sep)[:-3])
1057
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001058 try:
Brian Norris7a610e82016-02-17 12:24:54 -08001059 ebuild_content = _get_file_content(ebuild, commit)
Alex Kleinb5953522018-08-03 11:44:21 -06001060 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content,
1061 overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001062 except ValueError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001063 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001064
1065 # Also ignore licenses ending with '?'
1066 for license_type in [x for x in license_types
1067 if x not in LICENSES_IGNORE and not x.endswith('?')]:
1068 try:
Alex Kleinb5953522018-08-03 11:44:21 -06001069 licenses_lib.Licensing.FindLicenseType(license_type,
1070 overlay_path=overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001071 except AssertionError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001072 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001073
Mike Frysinger8cf80812019-09-16 23:49:29 -04001074 return None
1075
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001076
Mike Frysingercd363c82014-02-01 05:20:18 -05001077def _check_ebuild_virtual_pv(project, commit):
1078 """Enforce the virtual PV policies."""
1079 # If this is the portage-stable overlay, then ignore the check.
1080 # We want to import virtuals as-is from upstream Gentoo.
1081 whitelist = (
1082 'chromiumos/overlays/portage-stable',
1083 )
Alex Deymo643ac4c2015-09-03 10:40:50 -07001084 if project.name in whitelist:
Mike Frysingercd363c82014-02-01 05:20:18 -05001085 return None
1086
1087 # We assume the repo name is the same as the dir name on disk.
1088 # It would be dumb to not have them match though.
Alex Deymo643ac4c2015-09-03 10:40:50 -07001089 project_base = os.path.basename(project.name)
Mike Frysingercd363c82014-02-01 05:20:18 -05001090
1091 is_variant = lambda x: x.startswith('overlay-variant-')
1092 is_board = lambda x: x.startswith('overlay-')
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001093 is_baseboard = lambda x: x.startswith('baseboard-')
1094 is_chipset = lambda x: x.startswith('chipset-')
1095 is_project = lambda x: x.startswith('project-')
Mike Frysingercd363c82014-02-01 05:20:18 -05001096 is_private = lambda x: x.endswith('-private')
1097
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001098 is_special_overlay = lambda x: (is_board(x) or is_chipset(x) or
1099 is_baseboard(x) or is_project(x))
1100
Mike Frysingercd363c82014-02-01 05:20:18 -05001101 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
1102
1103 ebuilds_re = [r'\.ebuild$']
1104 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1105 ebuilds_re)
1106 bad_ebuilds = []
1107
1108 for ebuild in ebuilds:
1109 m = get_pv.match(ebuild)
1110 if m:
1111 overlay = m.group(1)
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001112 if not overlay or not is_special_overlay(overlay):
Alex Deymo643ac4c2015-09-03 10:40:50 -07001113 overlay = project_base
Mike Frysingercd363c82014-02-01 05:20:18 -05001114
1115 pv = m.group(3).split('-', 1)[0]
1116
Bernie Thompsone5ee1822016-01-12 14:22:23 -08001117 # Virtual versions >= 4 are special cases used above the standard
1118 # versioning structure, e.g. if one has a board inheriting a board.
1119 if float(pv) >= 4:
1120 want_pv = pv
Mike Frysingercd363c82014-02-01 05:20:18 -05001121 elif is_board(overlay):
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001122 if is_private(overlay):
1123 want_pv = '3.5' if is_variant(overlay) else '3'
1124 elif is_board(overlay):
1125 want_pv = '2.5' if is_variant(overlay) else '2'
1126 elif is_baseboard(overlay):
1127 want_pv = '1.9'
1128 elif is_chipset(overlay):
1129 want_pv = '1.8'
1130 elif is_project(overlay):
1131 want_pv = '1.7' if is_private(overlay) else '1.5'
Mike Frysingercd363c82014-02-01 05:20:18 -05001132 else:
1133 want_pv = '1'
1134
1135 if pv != want_pv:
1136 bad_ebuilds.append((ebuild, pv, want_pv))
1137
1138 if bad_ebuilds:
1139 # pylint: disable=C0301
1140 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
1141 # pylint: enable=C0301
1142 return HookFailure(
1143 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
1144 '\t%s\n'
1145 'If this is an upstream Gentoo virtual, then you may ignore this\n'
1146 'check (and re-run w/--no-verify). Otherwise, please see this\n'
1147 'page for more details:\n%s\n' %
1148 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
1149 for x in bad_ebuilds]), url))
1150
Mike Frysinger8cf80812019-09-16 23:49:29 -04001151 return None
1152
Mike Frysingercd363c82014-02-01 05:20:18 -05001153
Daniel Erat9d203ff2015-02-17 10:12:21 -07001154def _check_portage_make_use_var(_project, commit):
1155 """Verify that $USE is set correctly in make.conf and make.defaults."""
1156 files = _filter_files(_get_affected_files(commit, relative=True),
1157 [r'(^|/)make.(conf|defaults)$'])
1158
1159 errors = []
1160 for path in files:
1161 basename = os.path.basename(path)
1162
1163 # Has a USE= line already been encountered in this file?
1164 saw_use = False
1165
1166 for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1):
1167 if not line.startswith('USE='):
1168 continue
1169
1170 preserves_use = '${USE}' in line or '$USE' in line
1171
1172 if (basename == 'make.conf' or
1173 (basename == 'make.defaults' and saw_use)) and not preserves_use:
1174 errors.append('%s:%d: missing ${USE}' % (path, i))
1175 elif basename == 'make.defaults' and not saw_use and preserves_use:
1176 errors.append('%s:%d: ${USE} referenced in initial declaration' %
1177 (path, i))
1178
1179 saw_use = True
1180
1181 if errors:
1182 return HookFailure(
1183 'One or more Portage make files appear to set USE incorrectly.\n'
1184 '\n'
1185 'All USE assignments in make.conf and all assignments after the\n'
1186 'initial declaration in make.defaults should contain "${USE}" to\n'
1187 'preserve previously-set flags.\n'
1188 '\n'
1189 'The initial USE declaration in make.defaults should not contain\n'
1190 '"${USE}".\n',
1191 errors)
1192
Mike Frysinger8cf80812019-09-16 23:49:29 -04001193 return None
1194
Daniel Erat9d203ff2015-02-17 10:12:21 -07001195
Mike Frysingerae409522014-02-01 03:16:11 -05001196def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001197 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001198 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001199 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001200 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001201 if not m:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001202 return HookFailure('Last paragraph of description must include Change-Id.')
Ryan Cui1562fb82011-05-09 11:01:31 -07001203
LaMont Jonesfb5e8bf2020-03-03 12:50:06 -07001204 # S-o-b and some other tags always allowed to follow Change-ID in the footer.
1205 allowed_tags = ['Signed-off-by', 'Cq-Cl-Tag', 'Cq-Include-Trybots']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001206
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001207 end = desc[m.end():].strip().splitlines()
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001208 cherry_pick_marker = 'cherry picked from commit'
1209
1210 if end and cherry_pick_marker in end[-1]:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001211 # Cherry picked patches allow more tags in the last paragraph.
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001212 allowed_tags += ['Commit-Queue', 'Commit-Ready', 'Reviewed-by',
1213 'Reviewed-on', 'Tested-by']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001214 end = end[:-1]
1215
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001216 # Note that descriptions could have multiple cherry pick markers.
1217 tag_search = r'^(%s:|\(%s) ' % (':|'.join(allowed_tags), cherry_pick_marker)
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001218
1219 if [x for x in end if not re.search(tag_search, x)]:
1220 return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' %
1221 ':", "'.join(allowed_tags))
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001222
Mike Frysinger8cf80812019-09-16 23:49:29 -04001223 return None
1224
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001225
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001226def _check_commit_message_style(_project, commit):
1227 """Verify that the commit message matches our style.
1228
1229 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
1230 commit hooks.
1231 """
Mike Frysingered9b2a02019-12-12 18:52:32 -05001232 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Mike Frysinger4efdee72019-11-04 10:57:01 -05001233
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001234 desc = _get_commit_desc(commit)
1235
1236 # The first line should be by itself.
1237 lines = desc.splitlines()
1238 if len(lines) > 1 and lines[1]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001239 return HookFailure('The second line of the commit message must be blank.'
1240 '\n%s' % (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001241
1242 # The first line should be one sentence.
1243 if '. ' in lines[0]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001244 return HookFailure('The first line cannot be more than one sentence.\n%s' %
1245 (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001246
1247 # The first line cannot be too long.
1248 MAX_FIRST_LINE_LEN = 100
1249 if len(lines[0]) > MAX_FIRST_LINE_LEN:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001250 return HookFailure('The first line must be less than %i chars.\n%s' %
1251 (MAX_FIRST_LINE_LEN, SEE_ALSO))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001252
Mike Frysinger8cf80812019-09-16 23:49:29 -04001253 return None
1254
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001255
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001256def _check_cros_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001257 """Verifies the Chromium OS license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -07001258
Mike Frysinger98638102014-08-28 00:15:08 -04001259 Should be following the spec:
1260 http://dev.chromium.org/developers/coding-style#TOC-File-headers
1261 """
1262 # For older years, be a bit more flexible as our policy says leave them be.
1263 LICENSE_HEADER = (
Keigo Oka7e880ac2019-07-03 15:03:43 +09001264 r'.*Copyright(?: \(c\))? (20[0-9]{2})(?:-20[0-9]{2})? The Chromium OS '
1265 r'Authors\. All rights reserved\.\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001266 r'.*Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001267 r'be\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001268 r'.*found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -05001269 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001270 )
1271 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1272
1273 # For newer years, be stricter.
Keigo Oka7e880ac2019-07-03 15:03:43 +09001274 BAD_COPYRIGHT_LINE = (
Brian Norris68838dd2018-09-26 18:30:24 -07001275 r'.*Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001276 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001277 )
Keigo Oka7e880ac2019-07-03 15:03:43 +09001278 bad_copyright_re = re.compile(BAD_COPYRIGHT_LINE)
Mike Frysinger98638102014-08-28 00:15:08 -04001279
Shuhei Takahashiabc20f32017-07-10 19:35:45 +09001280 included, excluded = _parse_common_inclusion_options(options)
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001281
Mike Frysinger98638102014-08-28 00:15:08 -04001282 bad_files = []
1283 bad_copyright_files = []
Keigo Oka7e880ac2019-07-03 15:03:43 +09001284 bad_year_files = []
1285
Ken Turnerd07564b2018-02-08 17:57:59 +11001286 files = _filter_files(
1287 _get_affected_files(commit, relative=True),
1288 included + COMMON_INCLUDED_PATHS,
1289 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001290 existing_files = set(_get_affected_files(commit, relative=True,
1291 include_adds=False))
Mike Frysinger98638102014-08-28 00:15:08 -04001292
Keigo Oka7e880ac2019-07-03 15:03:43 +09001293 current_year = str(datetime.datetime.now().year)
Mike Frysinger98638102014-08-28 00:15:08 -04001294 for f in files:
1295 contents = _get_file_content(f, commit)
1296 if not contents:
1297 # Ignore empty files.
1298 continue
1299
Keigo Oka7e880ac2019-07-03 15:03:43 +09001300 m = license_re.search(contents)
1301 if not m:
Mike Frysinger98638102014-08-28 00:15:08 -04001302 bad_files.append(f)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001303 elif bad_copyright_re.search(contents):
Mike Frysinger98638102014-08-28 00:15:08 -04001304 bad_copyright_files.append(f)
1305
Keigo Oka7e880ac2019-07-03 15:03:43 +09001306 if m and f not in existing_files:
1307 year = m.group(1)
1308 if year != current_year:
1309 bad_year_files.append(f)
1310
1311 errors = []
Mike Frysinger98638102014-08-28 00:15:08 -04001312 if bad_files:
1313 msg = '%s:\n%s\n%s' % (
1314 'License must match', license_re.pattern,
1315 'Found a bad header in these files:')
Keigo Oka7e880ac2019-07-03 15:03:43 +09001316 errors.append(HookFailure(msg, bad_files))
Mike Frysinger98638102014-08-28 00:15:08 -04001317 if bad_copyright_files:
1318 msg = 'Do not use (c) in copyright headers in new files:'
Keigo Oka7e880ac2019-07-03 15:03:43 +09001319 errors.append(HookFailure(msg, bad_copyright_files))
1320 if bad_year_files:
1321 msg = 'Use current year (%s) in copyright headers in new files:' % (
1322 current_year)
1323 errors.append(HookFailure(msg, bad_year_files))
Ryan Cuiec4d6332011-05-02 14:15:25 -07001324
Keigo Oka7e880ac2019-07-03 15:03:43 +09001325 return errors
Ryan Cuiec4d6332011-05-02 14:15:25 -07001326
Mike Frysinger8cf80812019-09-16 23:49:29 -04001327
Amin Hassani391efa92018-01-26 17:58:05 -08001328def _check_aosp_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001329 """Verifies the AOSP license/copyright header.
1330
1331 AOSP uses the Apache2 License:
1332 https://source.android.com/source/licenses.html
1333 """
1334 LICENSE_HEADER = (
1335 r"""^[#/\*]*
1336[#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project
1337[#/\*]* ?
1338[#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\);
1339[#/\*]* ?you may not use this file except in compliance with the License\.
1340[#/\*]* ?You may obtain a copy of the License at
1341[#/\*]* ?
1342[#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0
1343[#/\*]* ?
1344[#/\*]* ?Unless required by applicable law or agreed to in writing, software
1345[#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS,
1346[#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """
1347 r"""implied\.
1348[#/\*]* ?See the License for the specific language governing permissions and
1349[#/\*]* ?limitations under the License\.
1350[#/\*]*$
1351"""
1352 )
1353 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1354
Amin Hassani391efa92018-01-26 17:58:05 -08001355 included, excluded = _parse_common_inclusion_options(options)
1356
Ken Turnerd07564b2018-02-08 17:57:59 +11001357 files = _filter_files(
1358 _get_affected_files(commit, relative=True),
1359 included + COMMON_INCLUDED_PATHS,
1360 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Alex Deymof5792ce2015-08-24 22:50:08 -07001361
1362 bad_files = []
1363 for f in files:
1364 contents = _get_file_content(f, commit)
1365 if not contents:
1366 # Ignore empty files.
1367 continue
1368
1369 if not license_re.search(contents):
1370 bad_files.append(f)
1371
1372 if bad_files:
1373 msg = ('License must match:\n%s\nFound a bad header in these files:' %
1374 license_re.pattern)
1375 return HookFailure(msg, bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001376 return None
Alex Deymof5792ce2015-08-24 22:50:08 -07001377
1378
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001379def _check_layout_conf(_project, commit):
1380 """Verifies the metadata/layout.conf file."""
1381 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001382 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001383 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001384 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001385
Mike Frysinger94a670c2014-09-19 12:46:26 -04001386 # Handle multiple overlays in a single commit (like the public tree).
1387 for f in _get_affected_files(commit, relative=True):
1388 if f.endswith(repo_name):
1389 repo_names.append(f)
1390 elif f.endswith(layout_path):
1391 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001392
1393 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -04001394 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001395 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -04001396 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001397
Mike Frysinger94a670c2014-09-19 12:46:26 -04001398 # Gather all the errors in one pass so we show one full message.
1399 all_errors = {}
1400 for layout_path in layout_paths:
1401 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001402
Mike Frysinger94a670c2014-09-19 12:46:26 -04001403 # Make sure the config file is sorted.
1404 data = [x for x in _get_file_content(layout_path, commit).splitlines()
1405 if x and x[0] != '#']
1406 if sorted(data) != data:
1407 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001408
Mike Frysinger94a670c2014-09-19 12:46:26 -04001409 # Require people to set specific values all the time.
1410 settings = (
1411 # TODO: Enable this for everyone. http://crbug.com/408038
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001412 # ('fast caching', 'cache-format = md5-dict'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001413 ('fast manifests', 'thin-manifests = true'),
Mike Frysingerd7734522015-02-26 16:12:43 -05001414 ('extra features', 'profile-formats = portage-2 profile-default-eapi'),
1415 ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001416 )
1417 for reason, line in settings:
1418 if line not in data:
1419 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001420
Mike Frysinger94a670c2014-09-19 12:46:26 -04001421 # Require one of these settings.
Mike Frysinger5fae62d2015-11-11 20:12:15 -05001422 if 'use-manifests = strict' not in data:
1423 errors += ['enable file checking with: use-manifests = strict']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001424
Mike Frysinger94a670c2014-09-19 12:46:26 -04001425 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -04001426 for line in data:
1427 if line.startswith('repo-name = '):
1428 break
1429 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -04001430 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001431
Mike Frysinger94a670c2014-09-19 12:46:26 -04001432 # Summarize all the errors we saw (if any).
1433 lines = ''
1434 for layout_path, errors in all_errors.items():
1435 if errors:
1436 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
1437 if lines:
1438 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
1439 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001440
Mike Frysinger8cf80812019-09-16 23:49:29 -04001441 return None
1442
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001443
Keigo Oka4a09bd92019-05-07 14:01:00 +09001444def _check_no_new_gyp(_project, commit):
1445 """Verifies no project starts to use GYP."""
Keigo Oka4a09bd92019-05-07 14:01:00 +09001446 gypfiles = _filter_files(
1447 _get_affected_files(commit, include_symlinks=True, relative=True),
1448 [r'\.gyp$'])
1449
1450 if gypfiles:
1451 return HookFailure('GYP is deprecated and not allowed in a new project:',
1452 gypfiles)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001453 return None
Keigo Oka4a09bd92019-05-07 14:01:00 +09001454
1455
Ryan Cuiec4d6332011-05-02 14:15:25 -07001456# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001457
Ryan Cui1562fb82011-05-09 11:01:31 -07001458
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001459def _check_clang_format(_project, commit, options=()):
1460 """Runs clang-format on the given project"""
1461 hooks_dir = _get_hooks_dir()
1462 options = list(options)
1463 if commit == PRE_SUBMIT:
1464 options.append('--commit=HEAD')
1465 else:
1466 options.extend(['--commit', commit])
Brian Norris0c62a142018-12-11 13:24:29 -08001467 cmd = [os.path.join(hooks_dir, 'clang-format.py')] + options
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001468 cmd_result = cros_build_lib.run(cmd,
1469 print_cmd=False,
1470 stdout=True,
1471 encoding='utf-8',
1472 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001473 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001474 check=False)
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001475 if cmd_result.returncode:
1476 return HookFailure('clang-format.py errors/warnings\n\n' +
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001477 cmd_result.stdout)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001478 return None
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001479
1480
Mike Frysingerae409522014-02-01 03:16:11 -05001481def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001482 """Runs checkpatch.pl on the given project"""
1483 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001484 options = list(options)
Brian Norris4cee0502020-06-12 17:02:56 -07001485 if options and options[0].startswith('./') and os.path.exists(options[0]):
1486 cmdpath = options.pop(0)
1487 else:
1488 cmdpath = os.path.join(hooks_dir, 'checkpatch.pl')
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001489 if commit == PRE_SUBMIT:
1490 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
1491 # this case.
1492 options.append('--ignore=MISSING_SIGN_OFF')
Filipe Brandenburger28d48d62015-10-07 09:48:54 -07001493 # Always ignore the check for the MAINTAINERS file. We do not track that
1494 # information on that file in our source trees, so let's suppress the
1495 # warning.
1496 options.append('--ignore=FILE_PATH_CHANGES')
Filipe Brandenburgerce978322015-10-09 10:04:15 -07001497 # Do not complain about the Change-Id: fields, since we use Gerrit.
1498 # Upstream does not want those lines (since they do not use Gerrit), but
1499 # we always do, so disable the check globally.
Daisuke Nojiri4844f892015-10-08 09:54:33 -07001500 options.append('--ignore=GERRIT_CHANGE_ID')
Brian Norris4cee0502020-06-12 17:02:56 -07001501 cmd = [cmdpath] + options + ['-']
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001502 cmd_result = cros_build_lib.run(
1503 cmd, print_cmd=False, input=_get_patch(commit).encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001504 stdout=True, stderr=subprocess.STDOUT, check=False, encoding='utf-8',
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001505 errors='replace')
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001506 if cmd_result.returncode:
Brian Norris4cee0502020-06-12 17:02:56 -07001507 return HookFailure('%s errors/warnings\n\n%s' %
1508 (cmdpath, cmd_result.stdout))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001509 return None
Ryan Cuiec4d6332011-05-02 14:15:25 -07001510
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001511
Brian Norris23c62e92018-11-14 12:25:51 -08001512def _run_kerneldoc(_project, commit, options=()):
1513 """Runs kernel-doc validator on the given project"""
1514 included, excluded = _parse_common_inclusion_options(options)
1515 files = _filter_files(_get_affected_files(commit, relative=True),
1516 included, excluded)
1517 if files:
1518 hooks_dir = _get_hooks_dir()
Brian Norris0c62a142018-12-11 13:24:29 -08001519 cmd = [os.path.join(hooks_dir, 'kernel-doc'), '-none'] + files
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001520 output = _run_command(cmd, stderr=subprocess.STDOUT)
Brian Norris23c62e92018-11-14 12:25:51 -08001521 if output:
Brian Norris0c62a142018-12-11 13:24:29 -08001522 return HookFailure('kernel-doc errors/warnings:',
1523 items=output.splitlines())
Mike Frysinger8cf80812019-09-16 23:49:29 -04001524 return None
Brian Norris23c62e92018-11-14 12:25:51 -08001525
1526
Mike Frysingerae409522014-02-01 03:16:11 -05001527def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -07001528 """Makes sure kernel config changes are not mixed with code changes"""
1529 files = _get_affected_files(commit)
Mike Frysingerf252cfc2019-12-09 17:34:28 -05001530 if len(_filter_files(files, [r'chromeos/config'])) not in [0, len(files)]:
Olof Johanssona96810f2012-09-04 16:20:03 -07001531 return HookFailure('Changes to chromeos/config/ and regular files must '
1532 'be in separate commits:\n%s' % '\n'.join(files))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001533 return None
Anton Staaf815d6852011-08-22 10:08:45 -07001534
Mike Frysingerae409522014-02-01 03:16:11 -05001535
1536def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -07001537 """Checks that all JSON files are syntactically valid."""
Mike Frysinger908be682018-01-04 02:21:50 -05001538 ret = []
1539
1540 files = _filter_files(_get_affected_files(commit, relative=True),
1541 [r'.*\.json$'])
1542 for f in files:
1543 data = _get_file_content(f, commit)
Dale Curtis2975c432011-05-03 17:25:20 -07001544 try:
Mike Frysinger908be682018-01-04 02:21:50 -05001545 json.loads(data)
1546 except Exception as e:
1547 ret.append('%s: Invalid JSON: %s' % (f, e))
1548
1549 if ret:
1550 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001551 return None
Dale Curtis2975c432011-05-03 17:25:20 -07001552
1553
Mike Frysingerae409522014-02-01 03:16:11 -05001554def _check_manifests(_project, commit):
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001555 """Make sure Manifest files only have comments & DIST lines."""
1556 ret = []
Mike Frysinger52b537e2013-08-22 22:59:53 -04001557
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001558 manifests = _filter_files(_get_affected_files(commit, relative=True),
1559 [r'.*/Manifest$'])
1560 for path in manifests:
1561 data = _get_file_content(path, commit)
1562
1563 # Disallow blank files.
1564 if not data.strip():
1565 ret.append('%s: delete empty file' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001566 continue
1567
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001568 # Make sure the last newline isn't omitted.
1569 if data[-1] != '\n':
1570 ret.append('%s: missing trailing newline' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001571
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001572 # Do not allow leading or trailing blank lines.
1573 lines = data.splitlines()
1574 if not lines[0]:
1575 ret.append('%s: delete leading blank lines' % (path,))
1576 if not lines[-1]:
1577 ret.append('%s: delete trailing blank lines' % (path,))
1578
1579 for line in lines:
1580 # Disallow leading/trailing whitespace.
1581 if line != line.strip():
1582 ret.append('%s: remove leading/trailing whitespace: %s' % (path, line))
1583
1584 # Allow blank lines & comments.
1585 line = line.split('#', 1)[0]
1586 if not line:
1587 continue
1588
1589 # All other linse should start with DIST.
1590 if not line.startswith('DIST '):
1591 ret.append('%s: remove non-DIST lines: %s' % (path, line))
1592 break
1593
1594 if ret:
1595 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001596 return None
Mike Frysinger52b537e2013-08-22 22:59:53 -04001597
1598
Mike Frysingerae409522014-02-01 03:16:11 -05001599def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001600 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001601 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001602 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001603 BRANCH_RE = r'\nBRANCH=\S+'
1604
1605 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
1606 msg = ('Changelist description needs BRANCH field (after first line)\n'
1607 'E.g. BRANCH=none or BRANCH=link,snow')
1608 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001609 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001610
1611
Mike Frysinger45334bd2019-11-04 10:42:33 -05001612def _check_change_has_no_branch_field(_project, commit):
1613 """Verify 'BRANCH=' field does not exist in the commit message."""
1614 if commit == PRE_SUBMIT:
1615 return None
1616 BRANCH_RE = r'\nBRANCH=\S+'
1617
1618 if re.search(BRANCH_RE, _get_commit_desc(commit)):
1619 msg = 'This checkout does not use BRANCH= fields. Delete them.'
1620 return HookFailure(msg)
1621 return None
1622
1623
Mike Frysingerae409522014-02-01 03:16:11 -05001624def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001625 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001626 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001627 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001628 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1629
1630 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1631 msg = ('Changelist description needs Signed-off-by: field\n'
1632 'E.g. Signed-off-by: My Name <me@chromium.org>')
1633 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001634 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001635
1636
Mike Frysinger9ab64b12019-11-04 10:53:08 -05001637def _check_change_has_no_signoff_field(_project, commit):
1638 """Verify 'Signed-off-by:' field does not exist in the commit message."""
1639 if commit == PRE_SUBMIT:
1640 return None
1641 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1642
1643 if re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1644 msg = 'This checkout does not use Signed-off-by: tags. Delete them.'
1645 return HookFailure(msg)
1646 return None
1647
1648
Jon Salz3ee59de2012-08-18 13:54:22 +08001649def _run_project_hook_script(script, project, commit):
1650 """Runs a project hook script.
1651
1652 The script is run with the following environment variables set:
1653 PRESUBMIT_PROJECT: The affected project
1654 PRESUBMIT_COMMIT: The affected commit
1655 PRESUBMIT_FILES: A newline-separated list of affected files
1656
1657 The script is considered to fail if the exit code is non-zero. It should
1658 write an error message to stdout.
1659 """
1660 env = dict(os.environ)
Alex Deymo643ac4c2015-09-03 10:40:50 -07001661 env['PRESUBMIT_PROJECT'] = project.name
Jon Salz3ee59de2012-08-18 13:54:22 +08001662 env['PRESUBMIT_COMMIT'] = commit
1663
1664 # Put affected files in an environment variable
1665 files = _get_affected_files(commit)
1666 env['PRESUBMIT_FILES'] = '\n'.join(files)
1667
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001668 cmd_result = cros_build_lib.run(cmd=script,
1669 env=env,
1670 shell=True,
1671 print_cmd=False,
1672 input=os.devnull,
1673 stdout=True,
1674 encoding='utf-8',
1675 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001676 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001677 check=False)
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001678 if cmd_result.returncode:
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001679 stdout = cmd_result.stdout
Jon Salz7b618af2012-08-31 06:03:16 +08001680 if stdout:
1681 stdout = re.sub('(?m)^', ' ', stdout)
1682 return HookFailure('Hook script "%s" failed with code %d%s' %
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001683 (script, cmd_result.returncode,
Jon Salz3ee59de2012-08-18 13:54:22 +08001684 ':\n' + stdout if stdout else ''))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001685 return None
Jon Salz3ee59de2012-08-18 13:54:22 +08001686
1687
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001688def _check_project_prefix(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -05001689 """Require the commit message have a project specific prefix as needed."""
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001690
Brian Norris77608e12018-04-06 10:38:43 -07001691 files = _get_affected_files(commit, include_deletes=True, relative=True)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001692 prefix = os.path.commonprefix(files)
1693 prefix = os.path.dirname(prefix)
1694
1695 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07001696 if not prefix:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001697 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001698
1699 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07001700
1701 # The common files may all be within a subdirectory of the main project
1702 # directory, so walk up the tree until we find an alias file.
1703 # _get_affected_files() should return relative paths, but check against '/' to
1704 # ensure that this loop terminates even if it receives an absolute path.
1705 while prefix and prefix != '/':
1706 alias_file = os.path.join(prefix, '.project_alias')
1707
1708 # If an alias exists, use it.
1709 if os.path.isfile(alias_file):
1710 project_name = osutils.ReadFile(alias_file).strip()
1711
1712 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001713
1714 if not _get_commit_desc(commit).startswith(project_name + ': '):
1715 return HookFailure('The commit title for changes affecting only %s'
1716 ' should start with \"%s: \"'
1717 % (project_name, project_name))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001718 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001719
1720
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001721def _check_filepath_chartype(_project, commit):
1722 """Checks that FilePath::CharType stuff is not used."""
1723
1724 FILEPATH_REGEXP = re.compile('|'.join(
1725 [r'(?:base::)?FilePath::(?:Char|String|StringPiece)Type',
Satoru Takabayashi4ca37922018-08-08 10:16:38 +09001726 r'(?:base::)?FilePath::FromUTF8Unsafe',
1727 r'AsUTF8Unsafe',
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001728 r'FILE_PATH_LITERAL']))
1729 files = _filter_files(_get_affected_files(commit, relative=True),
1730 [r'.*\.(cc|h)$'])
1731
1732 errors = []
1733 for afile in files:
1734 for line_num, line in _get_file_diff(afile, commit):
1735 m = re.search(FILEPATH_REGEXP, line)
1736 if m:
1737 errors.append('%s, line %s has %s' % (afile, line_num, m.group(0)))
1738
1739 if errors:
1740 msg = 'Please assume FilePath::CharType is char (crbug.com/870621):'
1741 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001742 return None
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001743
1744
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001745def _check_exec_files(_project, commit):
1746 """Make +x bits on files."""
1747 # List of files that should never be +x.
1748 NO_EXEC = (
1749 'ChangeLog*',
1750 'COPYING',
1751 'make.conf',
1752 'make.defaults',
1753 'Manifest',
1754 'OWNERS',
1755 'package.use',
1756 'package.keywords',
1757 'package.mask',
1758 'parent',
1759 'README',
1760 'TODO',
1761 '.gitignore',
1762 '*.[achly]',
1763 '*.[ch]xx',
1764 '*.boto',
1765 '*.cc',
1766 '*.cfg',
1767 '*.conf',
1768 '*.config',
1769 '*.cpp',
1770 '*.css',
1771 '*.ebuild',
1772 '*.eclass',
Tatsuhisa Yamaguchi3b053632019-01-10 14:45:14 +09001773 '*.gn',
1774 '*.gni',
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001775 '*.gyp',
1776 '*.gypi',
1777 '*.htm',
1778 '*.html',
1779 '*.ini',
1780 '*.js',
1781 '*.json',
1782 '*.md',
1783 '*.mk',
1784 '*.patch',
1785 '*.policy',
1786 '*.proto',
1787 '*.raw',
1788 '*.rules',
1789 '*.service',
1790 '*.target',
1791 '*.txt',
1792 '*.xml',
1793 '*.yaml',
1794 )
1795
1796 def FinalName(obj):
1797 # If the file is being deleted, then the dst_file is not set.
1798 if obj.dst_file is None:
1799 return obj.src_file
1800 else:
1801 return obj.dst_file
1802
1803 bad_files = []
1804 files = _get_affected_files(commit, relative=True, full_details=True)
1805 for f in files:
1806 mode = int(f.dst_mode, 8)
1807 if not mode & 0o111:
1808 continue
1809 name = FinalName(f)
1810 for no_exec in NO_EXEC:
1811 if fnmatch.fnmatch(name, no_exec):
1812 bad_files.append(name)
1813 break
1814
1815 if bad_files:
1816 return HookFailure('These files should not be executable. '
1817 'Please `chmod -x` them.', bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001818 return None
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001819
1820
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001821# Base
1822
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001823# A list of hooks which are not project specific and check patch description
1824# (as opposed to patch body).
1825_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07001826 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07001827 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07001828 _check_change_has_test_field,
1829 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001830 _check_commit_message_style,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001831 _check_change_is_contribution,
Jack Neus8edbf642019-07-10 16:08:31 -06001832 _check_change_no_include_oem,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001833]
1834
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001835# A list of hooks that are not project-specific
1836_COMMON_HOOKS = [
Aviv Keshet5ac59522017-01-31 14:28:27 -08001837 _check_cros_license,
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001838 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05001839 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001840 _check_ebuild_licenses,
Mike Frysingercd363c82014-02-01 05:20:18 -05001841 _check_ebuild_virtual_pv,
Mike Frysingerf9d41b32017-02-23 15:20:04 -05001842 _check_exec_files,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001843 _check_for_uprev,
Rahul Chaudhry09f61372015-07-31 17:14:26 -07001844 _check_gofmt,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001845 _check_layout_conf,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001846 _check_no_long_lines,
Keigo Oka4a09bd92019-05-07 14:01:00 +09001847 _check_no_new_gyp,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001848 _check_no_stray_whitespace,
Ryan Cui9b651632011-05-11 11:38:58 -07001849 _check_no_tabs,
Daniel Erat9d203ff2015-02-17 10:12:21 -07001850 _check_portage_make_use_var,
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -06001851 _check_rustfmt,
Aviv Keshet5ac59522017-01-31 14:28:27 -08001852 _check_tabbed_indents,
Ryan Cui9b651632011-05-11 11:38:58 -07001853]
Ryan Cuiec4d6332011-05-02 14:15:25 -07001854
Ryan Cui1562fb82011-05-09 11:01:31 -07001855
Ryan Cui9b651632011-05-11 11:38:58 -07001856# A dictionary of project-specific hooks(callbacks), indexed by project name.
1857# dict[project] = [callback1, callback2]
1858_PROJECT_SPECIFIC_HOOKS = {
Mike Frysinger24dd3c52019-08-17 14:22:48 -04001859 'chromiumos/third_party/kernel': [_kernel_configcheck],
1860 'chromiumos/third_party/kernel-next': [_kernel_configcheck],
Ryan Cui9b651632011-05-11 11:38:58 -07001861}
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001862
Ryan Cui1562fb82011-05-09 11:01:31 -07001863
Ryan Cui9b651632011-05-11 11:38:58 -07001864# A dictionary of flags (keys) that can appear in the config file, and the hook
Mike Frysinger3554bc92015-03-11 04:59:21 -04001865# that the flag controls (value).
1866_HOOK_FLAGS = {
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001867 'clang_format_check': _check_clang_format,
Mike Frysingera7642f52015-03-25 18:31:42 -04001868 'checkpatch_check': _run_checkpatch,
Brian Norris23c62e92018-11-14 12:25:51 -08001869 'kerneldoc_check': _run_kerneldoc,
Ryan Cui9b651632011-05-11 11:38:58 -07001870 'stray_whitespace_check': _check_no_stray_whitespace,
Mike Frysingerff6c7d62015-03-24 13:49:46 -04001871 'json_check': _run_json_check,
Ryan Cui9b651632011-05-11 11:38:58 -07001872 'long_line_check': _check_no_long_lines,
Alex Deymof5792ce2015-08-24 22:50:08 -07001873 'cros_license_check': _check_cros_license,
1874 'aosp_license_check': _check_aosp_license,
LaMont Jones872fe762020-02-10 15:36:14 -07001875 'gofmt_check': _check_gofmt,
Ryan Cui9b651632011-05-11 11:38:58 -07001876 'tab_check': _check_no_tabs,
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08001877 'tabbed_indent_required_check': _check_tabbed_indents,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001878 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001879 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07001880 'bug_field_check': _check_change_has_bug_field,
1881 'test_field_check': _check_change_has_test_field,
Steve Fung49ec7e92015-03-23 16:07:12 -07001882 'manifest_check': _check_manifests,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08001883 'contribution_check': _check_change_is_contribution,
Mike Frysinger47bd1252018-06-11 12:12:20 -04001884 'project_prefix_check': _check_project_prefix,
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09001885 'filepath_chartype_check': _check_filepath_chartype,
Ryan Cui9b651632011-05-11 11:38:58 -07001886}
1887
1888
Mike Frysinger3554bc92015-03-11 04:59:21 -04001889def _get_override_hooks(config):
1890 """Returns a set of hooks controlled by the current project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001891
1892 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08001893
1894 Args:
1895 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07001896 """
1897 SECTION = 'Hook Overrides'
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001898 SECTION_OPTIONS = 'Hook Overrides Options'
Ryan Cui9b651632011-05-11 11:38:58 -07001899
Mike Frysinger56e8de02019-07-31 14:40:14 -04001900 valid_keys = set(_HOOK_FLAGS.keys())
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001901 hooks = _HOOK_FLAGS.copy()
Mike Frysinger380592f2020-02-03 15:27:16 -05001902 options = config.options(SECTION) if config.has_section(SECTION) else []
Mike Frysinger3554bc92015-03-11 04:59:21 -04001903
1904 enable_flags = []
Ryan Cui9b651632011-05-11 11:38:58 -07001905 disable_flags = []
Mike Frysinger380592f2020-02-03 15:27:16 -05001906 for flag in options:
Mike Frysinger3554bc92015-03-11 04:59:21 -04001907 if flag not in valid_keys:
1908 raise ValueError('Error: unknown key "%s" in hook section of "%s"' %
1909 (flag, _CONFIG_FILE))
1910
Ryan Cui9b651632011-05-11 11:38:58 -07001911 try:
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001912 enabled = config.getboolean(SECTION, flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001913 except ValueError as e:
Mike Frysinger3554bc92015-03-11 04:59:21 -04001914 raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' %
1915 (flag, _CONFIG_FILE, e))
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001916 if enabled:
1917 enable_flags.append(flag)
1918 else:
1919 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07001920
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001921 # See if this hook has custom options.
1922 if enabled:
1923 try:
1924 options = config.get(SECTION_OPTIONS, flag)
1925 hooks[flag] = functools.partial(hooks[flag], options=options.split())
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001926 hooks[flag].__name__ = flag
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04001927 except (configparser.NoOptionError, configparser.NoSectionError):
Mike Frysingerf8ce1712015-03-25 18:32:33 -04001928 pass
1929
1930 enabled_hooks = set(hooks[x] for x in enable_flags)
1931 disabled_hooks = set(hooks[x] for x in disable_flags)
Mike Frysinger45334bd2019-11-04 10:42:33 -05001932
Mike Frysinger9ab64b12019-11-04 10:53:08 -05001933 if _check_change_has_signoff_field not in enabled_hooks:
Drew Davenport85848e52020-01-15 14:40:29 -07001934 if _check_change_has_signoff_field not in disabled_hooks:
1935 enabled_hooks.add(_check_change_has_no_signoff_field)
Mike Frysinger45334bd2019-11-04 10:42:33 -05001936 if _check_change_has_branch_field not in enabled_hooks:
1937 enabled_hooks.add(_check_change_has_no_branch_field)
1938
Mike Frysinger3554bc92015-03-11 04:59:21 -04001939 return enabled_hooks, disabled_hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001940
1941
Jon Salz3ee59de2012-08-18 13:54:22 +08001942def _get_project_hook_scripts(config):
1943 """Returns a list of project-specific hook scripts.
1944
1945 Args:
1946 config: A ConfigParser for the project's config file.
1947 """
1948 SECTION = 'Hook Scripts'
1949 if not config.has_section(SECTION):
1950 return []
1951
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001952 return config.items(SECTION)
Jon Salz3ee59de2012-08-18 13:54:22 +08001953
1954
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001955def _get_project_hooks(project, presubmit):
Ryan Cui9b651632011-05-11 11:38:58 -07001956 """Returns a list of hooks that need to be run for a project.
1957
1958 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001959
1960 Args:
1961 project: A string, name of the project.
1962 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui9b651632011-05-11 11:38:58 -07001963 """
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04001964 config = configparser.RawConfigParser()
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001965 if not os.path.exists(_CONFIG_FILE):
Jon Salz3ee59de2012-08-18 13:54:22 +08001966 # Just use an empty config file
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04001967 config = configparser.RawConfigParser()
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001968 else:
1969 config.read(_CONFIG_FILE)
Jon Salz3ee59de2012-08-18 13:54:22 +08001970
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001971 if presubmit:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001972 hooks = _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001973 else:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001974 hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001975
Mike Frysinger3554bc92015-03-11 04:59:21 -04001976 enabled_hooks, disabled_hooks = _get_override_hooks(config)
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07001977 hooks = [hook for hook in hooks if hook not in disabled_hooks]
1978
1979 # If a list is both in _COMMON_HOOKS and also enabled explicitly through an
1980 # override, keep the override only. Note that the override may end up being
1981 # a functools.partial, in which case we need to extract the .func to compare
1982 # it to the common hooks.
1983 unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks]
1984 hooks = [hook for hook in hooks if hook not in unwrapped_hooks]
1985
1986 hooks = list(enabled_hooks) + hooks
Ryan Cui9b651632011-05-11 11:38:58 -07001987
1988 if project in _PROJECT_SPECIFIC_HOOKS:
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001989 hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project]
1990 if hook not in disabled_hooks)
Ryan Cui9b651632011-05-11 11:38:58 -07001991
Mike Frysingerb7d552e2017-11-23 11:50:47 -05001992 for name, script in _get_project_hook_scripts(config):
1993 func = functools.partial(_run_project_hook_script, script)
1994 func.__name__ = name
1995 hooks.append(func)
Jon Salz3ee59de2012-08-18 13:54:22 +08001996
Ryan Cui9b651632011-05-11 11:38:58 -07001997 return hooks
1998
1999
Alex Deymo643ac4c2015-09-03 10:40:50 -07002000def _run_project_hooks(project_name, proj_dir=None,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002001 commit_list=None, presubmit=False):
Ryan Cui1562fb82011-05-09 11:01:31 -07002002 """For each project run its project specific hook from the hooks dictionary.
2003
2004 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002005 project_name: The name of project to run hooks for.
Doug Anderson44a644f2011-11-02 10:37:37 -07002006 proj_dir: If non-None, this is the directory the project is in. If None,
2007 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07002008 commit_list: A list of commits to run hooks against. If None or empty list
2009 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002010 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Ryan Cui1562fb82011-05-09 11:01:31 -07002011
2012 Returns:
2013 Boolean value of whether any errors were ecountered while running the hooks.
2014 """
Doug Anderson44a644f2011-11-02 10:37:37 -07002015 if proj_dir is None:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002016 proj_dirs = _run_command(
2017 ['repo', 'forall', project_name, '-c', 'pwd']).split()
Mike Frysingere52b1bc2019-09-16 23:45:41 -04002018 if not proj_dirs:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002019 print('%s cannot be found.' % project_name, file=sys.stderr)
David James2edd9002013-10-11 14:09:19 -07002020 print('Please specify a valid project.', file=sys.stderr)
2021 return True
2022 if len(proj_dirs) > 1:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002023 print('%s is associated with multiple directories.' % project_name,
David James2edd9002013-10-11 14:09:19 -07002024 file=sys.stderr)
2025 print('Please specify a directory to help disambiguate.', file=sys.stderr)
2026 return True
2027 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07002028
Ryan Cuiec4d6332011-05-02 14:15:25 -07002029 pwd = os.getcwd()
2030 # hooks assume they are run from the root of the project
2031 os.chdir(proj_dir)
2032
Mike Frysingered1b95a2019-12-12 19:04:51 -05002033 color = terminal.Color()
2034
Alex Deymo643ac4c2015-09-03 10:40:50 -07002035 remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref',
2036 '--symbolic-full-name', '@{u}']).strip()
2037 if not remote_branch:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002038 print("Your project %s doesn't track any remote repo." % project_name,
Alex Deymo643ac4c2015-09-03 10:40:50 -07002039 file=sys.stderr)
2040 remote = None
2041 else:
Josh Pratt15d13ab2018-08-13 11:52:48 +10002042 branch_items = remote_branch.split('/', 1)
2043 if len(branch_items) != 2:
2044 PrintErrorForProject(
2045 project_name,
2046 HookFailure(
2047 'Cannot get remote and branch name (%s)' % remote_branch))
2048 os.chdir(pwd)
2049 return True
2050 remote, _branch = branch_items
Alex Deymo643ac4c2015-09-03 10:40:50 -07002051
2052 project = Project(name=project_name, dir=proj_dir, remote=remote)
2053
Doug Anderson14749562013-06-26 13:38:29 -07002054 if not commit_list:
2055 try:
2056 commit_list = _get_commits()
2057 except VerifyException as e:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002058 PrintErrorForProject(project.name, HookFailure(str(e)))
Doug Anderson14749562013-06-26 13:38:29 -07002059 os.chdir(pwd)
2060 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07002061
Alex Deymo643ac4c2015-09-03 10:40:50 -07002062 hooks = _get_project_hooks(project.name, presubmit)
Ryan Cui1562fb82011-05-09 11:01:31 -07002063 error_found = False
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002064 commit_count = len(commit_list)
Mike Frysingerb99b3772019-08-17 14:19:44 -04002065 hook_count = len(hooks)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002066 for i, commit in enumerate(commit_list):
Mike Frysingerb2496652019-09-12 23:35:46 -04002067 CACHE.clear()
2068
LaMont Jones69d3e182020-03-11 15:00:53 -06002069 # If run with --pre-submit, then commit is PRE_SUBMIT, and not a commit.
2070 # Use that as the description.
2071 desc = commit if commit == PRE_SUBMIT else _get_commit_desc(commit)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002072 print('[%s %i/%i %s] %s' %
2073 (color.Color(color.CYAN, 'COMMIT'), i + 1, commit_count, commit[0:12],
2074 desc.splitlines()[0]))
2075
Mike Frysingerb99b3772019-08-17 14:19:44 -04002076 for h, hook in enumerate(hooks):
Mike Frysingered1b95a2019-12-12 19:04:51 -05002077 output = ('[%s %i/%i PRESUBMIT.cfg] %s' %
2078 (color.Color(color.YELLOW, 'RUNNING'), h + 1, hook_count,
2079 hook.__name__))
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002080 print(output, end='\r')
2081 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002082 hook_error = hook(project, commit)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002083 print(' ' * len(output), end='\r')
2084 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002085 if hook_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002086 if not isinstance(hook_error, list):
2087 hook_error = [hook_error]
2088 PrintErrorsForCommit(color, hook, project.name, hook_error)
Ryan Cui1562fb82011-05-09 11:01:31 -07002089 error_found = True
Don Garrettdba548a2011-05-05 15:17:14 -07002090
Ryan Cuiec4d6332011-05-02 14:15:25 -07002091 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07002092 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002093
Mike Frysingerae409522014-02-01 03:16:11 -05002094
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002095# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002096
Ryan Cui1562fb82011-05-09 11:01:31 -07002097
Mike Frysingerae409522014-02-01 03:16:11 -05002098def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08002099 """Main function invoked directly by repo.
2100
2101 This function will exit directly upon error so that repo doesn't print some
2102 obscure error message.
2103
2104 Args:
2105 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07002106 worktree_list: A list of directories. It should be the same length as
2107 project_list, so that each entry in project_list matches with a directory
2108 in worktree_list. If None, we will attempt to calculate the directories
2109 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08002110 kwargs: Leave this here for forward-compatibility.
2111 """
Mike Frysingered1b95a2019-12-12 19:04:51 -05002112 start_time = datetime.datetime.now()
Ryan Cui1562fb82011-05-09 11:01:31 -07002113 found_error = False
David James2edd9002013-10-11 14:09:19 -07002114 if not worktree_list:
2115 worktree_list = [None] * len(project_list)
2116 for project, worktree in zip(project_list, worktree_list):
2117 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07002118 found_error = True
2119
Mike Frysingered1b95a2019-12-12 19:04:51 -05002120 end_time = datetime.datetime.now()
2121 color = terminal.Color()
Mike Frysingerae409522014-02-01 03:16:11 -05002122 if found_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002123 msg = ('%s: Preupload failed due to above error(s).\n'
Ryan Cui9b651632011-05-11 11:38:58 -07002124 '- To disable some source style checks, and for other hints, see '
Mike Frysingered1b95a2019-12-12 19:04:51 -05002125 '<checkout_dir>/src/repohooks/README.md\n'
2126 "- To upload only current project, run 'repo upload .'" %
2127 (color.Color(color.RED, 'FATAL'),))
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04002128 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07002129 sys.exit(1)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002130 else:
2131 msg = ('[%s] repohooks passed in %s' %
2132 (color.Color(color.GREEN, 'PASSED'), end_time - start_time))
2133 print(msg)
Anush Elangovan63afad72011-03-23 00:41:27 -07002134
Ryan Cui1562fb82011-05-09 11:01:31 -07002135
Doug Anderson44a644f2011-11-02 10:37:37 -07002136def _identify_project(path):
2137 """Identify the repo project associated with the given path.
2138
2139 Returns:
2140 A string indicating what project is associated with the path passed in or
2141 a blank string upon failure.
2142 """
2143 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002144 stderr=True, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002145
2146
Mike Frysinger55f85b52014-12-18 14:45:21 -05002147def direct_main(argv):
Doug Anderson44a644f2011-11-02 10:37:37 -07002148 """Run hooks directly (outside of the context of repo).
2149
Doug Anderson44a644f2011-11-02 10:37:37 -07002150 Args:
Mike Frysinger55f85b52014-12-18 14:45:21 -05002151 argv: The command line args to process
Doug Anderson44a644f2011-11-02 10:37:37 -07002152
2153 Returns:
2154 0 if no pre-upload failures, 1 if failures.
2155
2156 Raises:
2157 BadInvocation: On some types of invocation errors.
2158 """
Mike Frysinger66142932014-12-18 14:55:57 -05002159 parser = commandline.ArgumentParser(description=__doc__)
2160 parser.add_argument('--dir', default=None,
2161 help='The directory that the project lives in. If not '
2162 'specified, use the git project root based on the cwd.')
2163 parser.add_argument('--project', default=None,
2164 help='The project repo path; this can affect how the '
2165 'hooks get run, since some hooks are project-specific. '
2166 'For chromite this is chromiumos/chromite. If not '
2167 'specified, the repo tool will be used to figure this '
2168 'out based on the dir.')
2169 parser.add_argument('--rerun-since', default=None,
Vadim Bendebury75447b92018-01-10 12:06:01 -08002170 help='Rerun hooks on old commits since some point '
2171 'in the past. The argument could be a date (should '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002172 "match git log's concept of a date, e.g. 2012-06-20), "
Vadim Bendebury75447b92018-01-10 12:06:01 -08002173 'or a SHA1, or just a number of commits to check (from 1 '
2174 'to 99). This option is mutually exclusive with '
2175 '--pre-submit.')
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002176 parser.add_argument('--pre-submit', action='store_true',
Mike Frysinger66142932014-12-18 14:55:57 -05002177 help='Run the check against the pending commit. '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002178 "This option should be used at the 'git commit' "
2179 "phase as opposed to 'repo upload'. This option "
Mike Frysinger66142932014-12-18 14:55:57 -05002180 'is mutually exclusive with --rerun-since.')
2181 parser.add_argument('commits', nargs='*',
2182 help='Check specific commits')
2183 opts = parser.parse_args(argv)
Doug Anderson44a644f2011-11-02 10:37:37 -07002184
Doug Anderson14749562013-06-26 13:38:29 -07002185 if opts.rerun_since:
Mike Frysinger66142932014-12-18 14:55:57 -05002186 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002187 raise BadInvocation("Can't pass commits and use rerun-since: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002188 ' '.join(opts.commits))
Doug Anderson14749562013-06-26 13:38:29 -07002189
Vadim Bendebury75447b92018-01-10 12:06:01 -08002190 if len(opts.rerun_since) < 3 and opts.rerun_since.isdigit():
2191 # This must be the number of commits to check. We don't expect the user
2192 # to want to check more than 99 commits.
2193 limit = '-n%s' % opts.rerun_since
2194 elif git.IsSHA1(opts.rerun_since, False):
2195 limit = '%s..' % opts.rerun_since
2196 else:
2197 # This better be a date.
2198 limit = '--since=%s' % opts.rerun_since
2199 cmd = ['git', 'log', limit, '--pretty=%H']
Doug Anderson14749562013-06-26 13:38:29 -07002200 all_commits = _run_command(cmd).splitlines()
2201 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
2202
2203 # Eliminate chrome-bot commits but keep ordering the same...
2204 bot_commits = set(bot_commits)
Mike Frysinger66142932014-12-18 14:55:57 -05002205 opts.commits = [c for c in all_commits if c not in bot_commits]
Doug Anderson14749562013-06-26 13:38:29 -07002206
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002207 if opts.pre_submit:
2208 raise BadInvocation('rerun-since and pre-submit can not be '
2209 'used together')
2210 if opts.pre_submit:
Mike Frysinger66142932014-12-18 14:55:57 -05002211 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002212 raise BadInvocation("Can't pass commits and use pre-submit: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002213 ' '.join(opts.commits))
2214 opts.commits = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07002215
2216 # Check/normlaize git dir; if unspecified, we'll use the root of the git
2217 # project from CWD
2218 if opts.dir is None:
2219 git_dir = _run_command(['git', 'rev-parse', '--git-dir'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002220 stderr=True).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002221 if not git_dir:
2222 raise BadInvocation('The current directory is not part of a git project.')
2223 opts.dir = os.path.dirname(os.path.abspath(git_dir))
2224 elif not os.path.isdir(opts.dir):
2225 raise BadInvocation('Invalid dir: %s' % opts.dir)
2226 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
2227 raise BadInvocation('Not a git directory: %s' % opts.dir)
2228
2229 # Identify the project if it wasn't specified; this _requires_ the repo
2230 # tool to be installed and for the project to be part of a repo checkout.
2231 if not opts.project:
2232 opts.project = _identify_project(opts.dir)
2233 if not opts.project:
2234 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
2235
Doug Anderson14749562013-06-26 13:38:29 -07002236 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Mike Frysinger66142932014-12-18 14:55:57 -05002237 commit_list=opts.commits,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002238 presubmit=opts.pre_submit)
Doug Anderson44a644f2011-11-02 10:37:37 -07002239 if found_error:
2240 return 1
2241 return 0
2242
2243
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002244if __name__ == '__main__':
Mike Frysinger55f85b52014-12-18 14:45:21 -05002245 sys.exit(direct_main(sys.argv[1:]))