blob: 8f03fa1bc232ae3267925c19a7e8ecf59538b066 [file] [log] [blame]
Mike Frysinger4f994402019-09-13 17:40:45 -04001#!/usr/bin/env python3
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002# -*- coding: utf-8 -*-
Jon Salz98255932012-08-18 14:48:02 +08003# Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
Mike Frysingerae409522014-02-01 03:16:11 -05007"""Presubmit checks to run when doing `repo upload`.
8
Tom Hughes40bdce52020-08-25 08:57:03 -07009You can add new checks by adding a function to the HOOKS constants.
Mike Frysingerae409522014-02-01 03:16:11 -050010"""
11
Mike Frysinger09d6a3d2013-10-08 22:21:03 -040012from __future__ import print_function
13
Keigo Okadd908822019-06-04 11:30:25 +090014import argparse
Alex Deymo643ac4c2015-09-03 10:40:50 -070015import collections
Mike Frysingerf252cfc2019-12-09 17:34:28 -050016import configparser
Keigo Oka7e880ac2019-07-03 15:03:43 +090017import datetime
Daniel Erate3ea3fc2015-02-13 15:27:52 -070018import fnmatch
Jon Salz3ee59de2012-08-18 13:54:22 +080019import functools
Dale Curtis2975c432011-05-03 17:25:20 -070020import json
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070021import os
Stephen Boyd6bf5ea82020-10-15 00:02:07 -070022import pathlib
Ryan Cuiec4d6332011-05-02 14:15:25 -070023import re
Mandeep Singh Bainesa7ffa4b2011-05-03 11:37:02 -070024import sys
Peter Ammon811f6702014-06-12 15:45:38 -070025import stat
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -050026import subprocess
Mandeep Singh Baines116ad102011-04-27 15:16:37 -070027
Ryan Cui1562fb82011-05-09 11:01:31 -070028from errors import (VerifyException, HookFailure, PrintErrorForProject,
29 PrintErrorsForCommit)
Ryan Cuiec4d6332011-05-02 14:15:25 -070030
Mike Frysinger919c7032019-09-13 17:48:08 -040031if __name__ in ('__builtin__', 'builtins'):
Mike Frysinger653cd262019-09-20 14:05:02 -040032 # If repo imports us, the __name__ will be __builtin__, and the cwd will be in
33 # the top level of the checkout (i.e. $CHROMEOS_CHECKOUT). chromite will be
34 # in that directory, so add it to our path. This works whether we're running
35 # the repo in $CHROMEOS_CHECKOUT/.repo/repo/ or a custom version in a
36 # completely different tree.
37 # TODO(vapier): Python 2 used "__builtin__" while Python 3 uses "builtins".
Mike Frysinger6850d512018-05-21 12:12:14 -040038 sys.path.insert(0, os.getcwd())
39
Mike Frysinger653cd262019-09-20 14:05:02 -040040elif __name__ == '__main__':
41 # If we're run directly, we'll find chromite relative to the repohooks dir in
42 # $CHROMEOS_CHECKOUT/src/repohooks, so go up two dirs.
David Jamesc3b68b32013-04-03 09:17:03 -070043 sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
44
Mike Frysingerfd481ce2019-09-13 18:14:48 -040045# The sys.path monkey patching confuses the linter.
46# pylint: disable=wrong-import-position
Mike Frysinger66142932014-12-18 14:55:57 -050047from chromite.lib import commandline
Rahul Chaudhry0e515342015-08-07 12:00:43 -070048from chromite.lib import cros_build_lib
Mike Frysingerd3bd32c2014-11-24 23:34:29 -050049from chromite.lib import git
Daniel Erata350fd32014-09-29 14:02:34 -070050from chromite.lib import osutils
David Jamesc3b68b32013-04-03 09:17:03 -070051from chromite.lib import patch
Mike Frysingered1b95a2019-12-12 19:04:51 -050052from chromite.lib import terminal
Mike Frysinger2ec70ed2014-08-17 19:28:34 -040053from chromite.licensing import licenses_lib
David Jamesc3b68b32013-04-03 09:17:03 -070054
Mike Frysingerff4768e2020-02-27 18:48:13 -050055
56assert sys.version_info >= (3, 6), 'This module requires Python 3.6+'
57
58
Vadim Bendebury2b62d742014-06-22 13:14:51 -070059PRE_SUBMIT = 'pre-submit'
Ryan Cuiec4d6332011-05-02 14:15:25 -070060
Mike Frysingered9b2a02019-12-12 18:52:32 -050061
62# Link to commit message documentation for users.
63DOC_COMMIT_MSG_URL = ('https://chromium.googlesource.com/chromiumos/docs/+/HEAD'
64 '/contributing.md#commit-messages')
65
66
Ryan Cuiec4d6332011-05-02 14:15:25 -070067COMMON_INCLUDED_PATHS = [
Mike Frysingerae409522014-02-01 03:16:11 -050068 # C++ and friends
Mike Frysinger24dd3c52019-08-17 14:22:48 -040069 r'.*\.c$', r'.*\.cc$', r'.*\.cpp$', r'.*\.h$', r'.*\.m$', r'.*\.mm$',
70 r'.*\.inl$', r'.*\.asm$', r'.*\.hxx$', r'.*\.hpp$', r'.*\.s$', r'.*\.S$',
Mike Frysingerae409522014-02-01 03:16:11 -050071 # Scripts
Mike Frysinger24dd3c52019-08-17 14:22:48 -040072 r'.*\.js$', r'.*\.py$', r'.*\.sh$', r'.*\.rb$', r'.*\.pl$', r'.*\.pm$',
Bob Haarman0dc1f942020-10-03 00:06:59 +000073 # No extension at all, note that ALL CAPS files are excluded by
Mike Frysingerae409522014-02-01 03:16:11 -050074 # COMMON_EXCLUDED_LIST below.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040075 r'(^|.*[\\\/])[^.]+$',
Mike Frysingerae409522014-02-01 03:16:11 -050076 # Other
Mike Frysinger24dd3c52019-08-17 14:22:48 -040077 r'.*\.java$', r'.*\.mk$', r'.*\.am$',
78 r'.*\.policy$', r'.*\.conf$', r'.*\.go$',
79 r'(^OWNERS|/OWNERS)',
Ryan Cuiec4d6332011-05-02 14:15:25 -070080]
81
Ryan Cui1562fb82011-05-09 11:01:31 -070082
Ryan Cuiec4d6332011-05-02 14:15:25 -070083COMMON_EXCLUDED_PATHS = [
Daniel Erate3ea3fc2015-02-13 15:27:52 -070084 # For ebuild trees, ignore any caches and manifest data.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040085 r'.*/Manifest$',
86 r'.*/metadata/[^/]*cache[^/]*/[^/]+/[^/]+$',
Doug Anderson5bfb6792011-10-25 16:45:41 -070087
Daniel Erate3ea3fc2015-02-13 15:27:52 -070088 # Ignore profiles data (like overlay-tegra2/profiles).
Mike Frysinger24dd3c52019-08-17 14:22:48 -040089 r'(^|.*/)overlay-.*/profiles/.*',
90 r'^profiles/.*$',
Mike Frysinger98638102014-08-28 00:15:08 -040091
C Shapiro8f90e9b2017-06-28 09:54:50 -060092 # Ignore config files in ebuild setup.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040093 r'(^|.*/)overlay-.*/chromeos-base/chromeos-bsp.*/files/.*',
94 r'^chromeos-base/chromeos-bsp.*/files/.*',
C Shapiro8f90e9b2017-06-28 09:54:50 -060095
Daniel Erate3ea3fc2015-02-13 15:27:52 -070096 # Ignore minified js and jquery.
Mike Frysinger24dd3c52019-08-17 14:22:48 -040097 r'.*\.min\.js',
98 r'.*jquery.*\.js',
Mike Frysinger33a458d2014-03-03 17:00:51 -050099
100 # Ignore license files as the content is often taken verbatim.
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400101 r'.*/licenses/.*',
Alex Klein619c0912019-01-30 17:13:23 -0700102
Mike Frysinger13650402019-07-31 14:31:46 -0400103 # Exclude generated protobuf bindings.
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400104 r'.*_pb2\.py$',
105 r'.*\.pb\.go$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700106]
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700107
Ken Turnerd07564b2018-02-08 17:57:59 +1100108LICENSE_EXCLUDED_PATHS = [
LaMont Jones775c2b32020-02-19 17:32:54 -0700109 r'^(.*/)?OWNERS(\..*)?$',
Tom Hughes90b7bd42020-11-10 10:31:49 -0800110 r'^(.*/)?DIR_METADATA(\..*)?$',
Ken Turnerd07564b2018-02-08 17:57:59 +1100111]
Ryan Cui1562fb82011-05-09 11:01:31 -0700112
Ryan Cui9b651632011-05-11 11:38:58 -0700113_CONFIG_FILE = 'PRESUBMIT.cfg'
114
115
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700116# File containing wildcards, one per line, matching files that should be
117# excluded from presubmit checks. Lines beginning with '#' are ignored.
118_IGNORE_FILE = '.presubmitignore'
119
Cheng Yuehb707c522020-01-02 14:06:59 +0800120
121TEST_FIELD_RE = r'\nTEST=\S+'
122
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700123BLOCKED_TERMS_FILE = 'blocked_terms.txt'
124UNBLOCKED_TERMS_FILE = 'unblocked_terms.txt'
125
Doug Anderson44a644f2011-11-02 10:37:37 -0700126# Exceptions
127
128
129class BadInvocation(Exception):
130 """An Exception indicating a bad invocation of the program."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700131
132
Ryan Cui1562fb82011-05-09 11:01:31 -0700133# General Helpers
134
Sean Paulba01d402011-05-05 11:36:23 -0400135
Mike Frysingerb2496652019-09-12 23:35:46 -0400136class Cache(object):
137 """General helper for caching git content."""
138
139 def __init__(self):
140 self._cache = {}
141
142 def get_subcache(self, scope):
143 return self._cache.setdefault(scope, {})
144
145 def clear(self):
146 self._cache.clear()
147
148CACHE = Cache()
149
150
Alex Deymo643ac4c2015-09-03 10:40:50 -0700151Project = collections.namedtuple('Project', ['name', 'dir', 'remote'])
152
153
Mike Frysinger526a5f82019-09-13 18:05:30 -0400154def _run_command(cmd, **kwargs):
Doug Anderson44a644f2011-11-02 10:37:37 -0700155 """Executes the passed in command and returns raw stdout output.
156
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400157 This is a convenience func to set some run defaults differently.
Mike Frysinger526a5f82019-09-13 18:05:30 -0400158
Doug Anderson44a644f2011-11-02 10:37:37 -0700159 Args:
160 cmd: The command to run; should be a list of strings.
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400161 **kwargs: Same as cros_build_lib.run.
Doug Anderson44a644f2011-11-02 10:37:37 -0700162
163 Returns:
Rahul Chaudhry0e515342015-08-07 12:00:43 -0700164 The stdout from the process (discards stderr and returncode).
Doug Anderson44a644f2011-11-02 10:37:37 -0700165 """
Mike Frysinger526a5f82019-09-13 18:05:30 -0400166 kwargs.setdefault('print_cmd', False)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400167 kwargs.setdefault('stdout', True)
168 kwargs.setdefault('check', False)
Mike Frysinger054c1592019-11-18 03:51:54 -0500169 result = cros_build_lib.run(cmd, **kwargs)
Mike Frysinger7bb709f2019-09-29 23:20:12 -0400170 # NB: We decode this directly rather than through kwargs as our tests rely
171 # on this post-processing behavior currently.
Mike Frysinger71e643e2019-09-13 17:26:39 -0400172 return result.output.decode('utf-8', 'replace')
Ryan Cui72834d12011-05-05 14:51:33 -0700173
Ryan Cui1562fb82011-05-09 11:01:31 -0700174
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700175def _get_hooks_dir():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700176 """Returns the absolute path to the repohooks directory."""
Doug Anderson44a644f2011-11-02 10:37:37 -0700177 if __name__ == '__main__':
178 # Works when file is run on its own (__file__ is defined)...
179 return os.path.abspath(os.path.dirname(__file__))
180 else:
181 # We need to do this when we're run through repo. Since repo executes
182 # us with execfile(), we don't get __file__ defined.
183 cmd = ['repo', 'forall', 'chromiumos/repohooks', '-c', 'pwd']
184 return _run_command(cmd).strip()
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700185
Ryan Cui1562fb82011-05-09 11:01:31 -0700186
Ryan Cuiec4d6332011-05-02 14:15:25 -0700187def _match_regex_list(subject, expressions):
188 """Try to match a list of regular expressions to a string.
189
190 Args:
191 subject: The string to match regexes on
192 expressions: A list of regular expressions to check for matches with.
193
194 Returns:
195 Whether the passed in subject matches any of the passed in regexes.
196 """
197 for expr in expressions:
Mike Frysingerae409522014-02-01 03:16:11 -0500198 if re.search(expr, subject):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700199 return True
200 return False
201
Ryan Cui1562fb82011-05-09 11:01:31 -0700202
Mike Frysingerae409522014-02-01 03:16:11 -0500203def _filter_files(files, include_list, exclude_list=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700204 """Filter out files based on the conditions passed in.
205
206 Args:
207 files: list of filepaths to filter
208 include_list: list of regex that when matched with a file path will cause it
209 to be added to the output list unless the file is also matched with a
210 regex in the exclude_list.
211 exclude_list: list of regex that when matched with a file will prevent it
212 from being added to the output list, even if it is also matched with a
213 regex in the include_list.
214
215 Returns:
216 A list of filepaths that contain files matched in the include_list and not
217 in the exclude_list.
218 """
219 filtered = []
220 for f in files:
221 if (_match_regex_list(f, include_list) and
222 not _match_regex_list(f, exclude_list)):
223 filtered.append(f)
224 return filtered
225
Ryan Cuiec4d6332011-05-02 14:15:25 -0700226
227# Git Helpers
Ryan Cui1562fb82011-05-09 11:01:31 -0700228
229
Ryan Cui4725d952011-05-05 15:41:19 -0700230def _get_upstream_branch():
231 """Returns the upstream tracking branch of the current branch.
232
233 Raises:
234 Error if there is no tracking branch
235 """
236 current_branch = _run_command(['git', 'symbolic-ref', 'HEAD']).strip()
237 current_branch = current_branch.replace('refs/heads/', '')
238 if not current_branch:
Ryan Cui1562fb82011-05-09 11:01:31 -0700239 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700240
241 cfg_option = 'branch.' + current_branch + '.%s'
242 full_upstream = _run_command(['git', 'config', cfg_option % 'merge']).strip()
243 remote = _run_command(['git', 'config', cfg_option % 'remote']).strip()
244 if not remote or not full_upstream:
Ryan Cui1562fb82011-05-09 11:01:31 -0700245 raise VerifyException('Need to be on a tracking branch')
Ryan Cui4725d952011-05-05 15:41:19 -0700246
247 return full_upstream.replace('heads', 'remotes/' + remote)
248
Ryan Cui1562fb82011-05-09 11:01:31 -0700249
Che-Liang Chiou5ce2d7b2013-03-22 18:47:55 -0700250def _get_patch(commit):
251 """Returns the patch for this commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700252 if commit == PRE_SUBMIT:
253 return _run_command(['git', 'diff', '--cached', 'HEAD'])
254 else:
255 return _run_command(['git', 'format-patch', '--stdout', '-1', commit])
Mandeep Singh Baines116ad102011-04-27 15:16:37 -0700256
Ryan Cui1562fb82011-05-09 11:01:31 -0700257
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500258def _get_file_content(path, commit):
259 """Returns the content of a file at a specific commit.
260
261 We can't rely on the file as it exists in the filesystem as people might be
262 uploading a series of changes which modifies the file multiple times.
263
264 Note: The "content" of a symlink is just the target. So if you're expecting
265 a full file, you should check that first. One way to detect is that the
266 content will not have any newlines.
267 """
Mike Frysingerb2496652019-09-12 23:35:46 -0400268 # Make sure people don't accidentally pass in full paths which will never
269 # work. You need to use relative=True with _get_affected_files.
270 if path.startswith('/'):
271 raise ValueError('_get_file_content must be called with relative paths: %s'
272 % (path,))
273
274 # {<commit>: {<path1>: <content>, <path2>: <content>}}
275 cache = CACHE.get_subcache('get_file_content')
276 if path in cache:
277 return cache[path]
278
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700279 if commit == PRE_SUBMIT:
Yu-Ping Wue3e47362020-09-22 15:54:40 +0800280 content = _run_command(['git', 'diff', 'HEAD', '--', path])
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700281 else:
Mike Frysingerb2496652019-09-12 23:35:46 -0400282 content = _run_command(['git', 'show', '%s:%s' % (commit, path)])
283 cache[path] = content
284 return content
Mike Frysingerbf8b91c2014-02-01 02:50:27 -0500285
286
Mike Frysingerae409522014-02-01 03:16:11 -0500287def _get_file_diff(path, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700288 """Returns a list of (linenum, lines) tuples that the commit touched."""
Mike Frysingerb2496652019-09-12 23:35:46 -0400289 # {<commit>: {<path1>: <content>, <path2>: <content>}}
290 cache = CACHE.get_subcache('get_file_diff')
291 if path in cache:
292 return cache[path]
293
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700294 if commit == PRE_SUBMIT:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800295 command = ['git', 'diff', '-p', '--pretty=format:', '--no-ext-diff', 'HEAD',
Yu-Ping Wue3e47362020-09-22 15:54:40 +0800296 '--', path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700297 else:
Prathmesh Prabhua9de1722016-12-22 14:56:40 -0800298 command = ['git', 'show', '-p', '--pretty=format:', '--no-ext-diff', commit,
Yu-Ping Wue3e47362020-09-22 15:54:40 +0800299 '--', path]
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700300 output = _run_command(command)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700301
302 new_lines = []
303 line_num = 0
304 for line in output.splitlines():
305 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
306 if m:
307 line_num = int(m.groups(1)[0])
308 continue
309 if line.startswith('+') and not line.startswith('++'):
Mike Frysinger71e643e2019-09-13 17:26:39 -0400310 new_lines.append((line_num, line[1:]))
Ryan Cuiec4d6332011-05-02 14:15:25 -0700311 if not line.startswith('-'):
312 line_num += 1
Mike Frysingerb2496652019-09-12 23:35:46 -0400313 cache[path] = new_lines
Ryan Cuiec4d6332011-05-02 14:15:25 -0700314 return new_lines
315
Ryan Cui1562fb82011-05-09 11:01:31 -0700316
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700317def _get_ignore_wildcards(directory, cache):
318 """Get wildcards listed in a directory's _IGNORE_FILE.
319
320 Args:
321 directory: A string containing a directory path.
322 cache: A dictionary (opaque to caller) caching previously-read wildcards.
323
324 Returns:
325 A list of wildcards from _IGNORE_FILE or an empty list if _IGNORE_FILE
326 wasn't present.
327 """
328 # In the cache, keys are directories and values are lists of wildcards from
329 # _IGNORE_FILE within those directories (and empty if no file was present).
330 if directory not in cache:
331 wildcards = []
332 dotfile_path = os.path.join(directory, _IGNORE_FILE)
333 if os.path.exists(dotfile_path):
334 # TODO(derat): Consider using _get_file_content() to get the file as of
335 # this commit instead of the on-disk version. This may have a noticeable
336 # performance impact, as each call to _get_file_content() runs git.
337 with open(dotfile_path, 'r') as dotfile:
338 for line in dotfile.readlines():
339 line = line.strip()
340 if line.startswith('#'):
341 continue
342 if line.endswith('/'):
343 line += '*'
344 wildcards.append(line)
345 cache[directory] = wildcards
346
347 return cache[directory]
348
349
350def _path_is_ignored(path, cache):
351 """Check whether a path is ignored by _IGNORE_FILE.
352
353 Args:
354 path: A string containing a path.
355 cache: A dictionary (opaque to caller) caching previously-read wildcards.
356
357 Returns:
358 True if a file named _IGNORE_FILE in one of the passed-in path's parent
359 directories contains a wildcard matching the path.
360 """
361 # Skip ignore files.
362 if os.path.basename(path) == _IGNORE_FILE:
363 return True
364
365 path = os.path.abspath(path)
366 base = os.getcwd()
367
368 prefix = os.path.dirname(path)
369 while prefix.startswith(base):
370 rel_path = path[len(prefix) + 1:]
371 for wildcard in _get_ignore_wildcards(prefix, cache):
372 if fnmatch.fnmatch(rel_path, wildcard):
373 return True
374 prefix = os.path.dirname(prefix)
375
376 return False
377
378
Mike Frysinger292b45d2014-11-25 01:17:10 -0500379def _get_affected_files(commit, include_deletes=False, relative=False,
380 include_symlinks=False, include_adds=True,
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700381 full_details=False, use_ignore_files=True):
Peter Ammon811f6702014-06-12 15:45:38 -0700382 """Returns list of file paths that were modified/added, excluding symlinks.
383
384 Args:
385 commit: The commit
386 include_deletes: If true, we'll include deleted files in the result
387 relative: Whether to return relative or full paths to files
Mike Frysinger292b45d2014-11-25 01:17:10 -0500388 include_symlinks: If true, we'll include symlinks in the result
389 include_adds: If true, we'll include new files in the result
390 full_details: If False, return filenames, else return structured results.
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700391 use_ignore_files: Whether we ignore files matched by _IGNORE_FILE files.
Peter Ammon811f6702014-06-12 15:45:38 -0700392
393 Returns:
394 A list of modified/added (and perhaps deleted) files
395 """
Mike Frysinger292b45d2014-11-25 01:17:10 -0500396 if not relative and full_details:
397 raise ValueError('full_details only supports relative paths currently')
398
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700399 if commit == PRE_SUBMIT:
400 return _run_command(['git', 'diff-index', '--cached',
401 '--name-only', 'HEAD']).split()
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500402
403 path = os.getcwd()
Mike Frysingerb2496652019-09-12 23:35:46 -0400404 # {<commit>: {<path1>: <content>, <path2>: <content>}}
405 cache = CACHE.get_subcache('get_affected_files')
406 if path not in cache:
407 cache[path] = git.RawDiff(path, '%s^!' % commit)
408 files = cache[path]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500409
410 # Filter out symlinks.
Mike Frysinger292b45d2014-11-25 01:17:10 -0500411 if not include_symlinks:
412 files = [x for x in files if not stat.S_ISLNK(int(x.dst_mode, 8))]
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500413
414 if not include_deletes:
415 files = [x for x in files if x.status != 'D']
416
Mike Frysinger292b45d2014-11-25 01:17:10 -0500417 if not include_adds:
418 files = [x for x in files if x.status != 'A']
419
Daniel Erate3ea3fc2015-02-13 15:27:52 -0700420 if use_ignore_files:
421 cache = {}
422 is_ignored = lambda x: _path_is_ignored(x.dst_file or x.src_file, cache)
423 files = [x for x in files if not is_ignored(x)]
424
Mike Frysinger292b45d2014-11-25 01:17:10 -0500425 if full_details:
426 # Caller wants the raw objects to parse status/etc... themselves.
Mike Frysingerd3bd32c2014-11-24 23:34:29 -0500427 return files
428 else:
Mike Frysinger292b45d2014-11-25 01:17:10 -0500429 # Caller only cares about filenames.
430 files = [x.dst_file if x.dst_file else x.src_file for x in files]
431 if relative:
432 return files
433 else:
434 return [os.path.join(path, x) for x in files]
Peter Ammon811f6702014-06-12 15:45:38 -0700435
436
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700437def _get_commits():
Ryan Cuiec4d6332011-05-02 14:15:25 -0700438 """Returns a list of commits for this review."""
Mike Frysingere300c7d2019-09-12 23:33:52 -0400439 cmd = ['git', 'log', '--no-merges', '--format=%H',
440 '%s..' % _get_upstream_branch()]
Ryan Cui72834d12011-05-05 14:51:33 -0700441 return _run_command(cmd).split()
Mandeep Singh Bainesb9ed1402011-04-29 15:32:06 -0700442
Ryan Cui1562fb82011-05-09 11:01:31 -0700443
Ryan Cuiec4d6332011-05-02 14:15:25 -0700444def _get_commit_desc(commit):
445 """Returns the full commit message of a commit."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -0700446 if commit == PRE_SUBMIT:
447 return ''
Mike Frysingerb2496652019-09-12 23:35:46 -0400448
449 # {<commit>: <content>}
450 cache = CACHE.get_subcache('get_commit_desc')
451 if commit not in cache:
Mike Frysinger4efdee72019-11-04 10:57:01 -0500452 cache[commit] = _run_command(['git', 'log', '--format=%B',
Mike Frysingerb2496652019-09-12 23:35:46 -0400453 commit + '^!'])
454 return cache[commit]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700455
456
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800457def _check_lines_in_diff(commit, files, check_callable, error_description):
458 """Checks given file for errors via the given check.
459
460 This is a convenience function for common per-line checks. It goes through all
461 files and returns a HookFailure with the error description listing all the
462 failures.
463
464 Args:
465 commit: The commit we're working on.
466 files: The files to check.
467 check_callable: A callable that takes a line and returns True if this line
468 _fails_ the check.
469 error_description: A string describing the error.
470 """
471 errors = []
472 for afile in files:
473 for line_num, line in _get_file_diff(afile, commit):
Bernie Thompson8e26f742020-07-23 14:32:31 -0700474 result = check_callable(line)
475 if result:
476 msg = f'{afile}, line {line_num}'
477 if isinstance(result, str):
478 msg += f': {result}'
479 errors.append(msg)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800480 if errors:
481 return HookFailure(error_description, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400482 return None
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800483
484
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900485def _parse_common_inclusion_options(options):
486 """Parses common hook options for including/excluding files.
487
488 Args:
489 options: Option string list.
490
491 Returns:
492 (included, excluded) where each one is a list of regex strings.
493 """
494 parser = argparse.ArgumentParser()
495 parser.add_argument('--exclude_regex', action='append')
496 parser.add_argument('--include_regex', action='append')
497 opts = parser.parse_args(options)
498 included = opts.include_regex or []
499 excluded = opts.exclude_regex or []
500 return included, excluded
501
502
Ryan Cuiec4d6332011-05-02 14:15:25 -0700503# Common Hooks
504
Ryan Cui1562fb82011-05-09 11:01:31 -0700505
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900506def _check_no_long_lines(_project, commit, options=()):
Mike Frysinger55f85b52014-12-18 14:45:21 -0500507 """Checks there are no lines longer than MAX_LEN in any of the text files."""
Keigo Oka9732e382019-06-28 17:44:59 +0900508 LONG_LINE_OK_PATHS = [
509 # Go has no line length limit.
510 # https://golang.org/doc/effective_go.html#formatting
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400511 r'.*\.go$',
Mike Frysingerf8961942020-05-15 00:36:31 -0400512 # Python does its own long line checks via pylint.
513 r'.*\.py$',
Keigo Oka9732e382019-06-28 17:44:59 +0900514 ]
Mike Frysinger55f85b52014-12-18 14:45:21 -0500515
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900516 DEFAULT_MAX_LENGTHS = [
517 # Java's line length limit is 100 chars.
518 # https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md
519 (r'.*\.java$', 100),
Mike Frysingerf8961942020-05-15 00:36:31 -0400520 # Rust's line length limit is 100 chars.
521 (r'.*\.rs$', 100),
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900522 ]
523
Ryan Cuiec4d6332011-05-02 14:15:25 -0700524 MAX_LEN = 80
525
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900526 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700527 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900528 included + COMMON_INCLUDED_PATHS,
Keigo Oka9732e382019-06-28 17:44:59 +0900529 excluded + COMMON_EXCLUDED_PATHS + LONG_LINE_OK_PATHS)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700530
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900531 errors = []
Ryan Cuiec4d6332011-05-02 14:15:25 -0700532 for afile in files:
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700533 skip_regexps = (
534 r'https?://',
535 r'^#\s*(define|include|import|pragma|if|ifndef|endif)\b',
536 )
537
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900538 max_len = MAX_LEN
539
540 for expr, length in DEFAULT_MAX_LENGTHS:
541 if re.search(expr, afile):
542 max_len = length
543 break
544
George Burgess IVf9f79eb2019-07-09 20:12:55 -0700545 if os.path.basename(afile).startswith('OWNERS'):
546 # File paths can get long, and there's no way to break them up into
547 # multiple lines.
548 skip_regexps += (
549 r'^include\b',
550 r'file:',
551 )
552
553 skip_regexps = [re.compile(x) for x in skip_regexps]
Ryan Cuiec4d6332011-05-02 14:15:25 -0700554 for line_num, line in _get_file_diff(afile, commit):
555 # Allow certain lines to exceed the maxlen rule.
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900556 if len(line) <= max_len or any(x.search(line) for x in skip_regexps):
Jon Salz98255932012-08-18 14:48:02 +0800557 continue
558
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900559 errors.append('%s, line %s, %s chars, over %s chars' %
560 (afile, line_num, len(line), max_len))
Jon Salz98255932012-08-18 14:48:02 +0800561 if len(errors) == 5: # Just show the first 5 errors.
562 break
Ryan Cuiec4d6332011-05-02 14:15:25 -0700563
564 if errors:
Ayato Tokubi5aae3f72020-01-16 17:43:47 +0900565 msg = 'Found lines longer than the limit (first 5 shown):'
Ryan Cui1562fb82011-05-09 11:01:31 -0700566 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400567 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700568
Ryan Cuiec4d6332011-05-02 14:15:25 -0700569
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900570def _check_no_stray_whitespace(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700571 """Checks that there is no stray whitespace at source lines end."""
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900572 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700573 files = _filter_files(_get_affected_files(commit),
Tomasz Figa375b9622020-09-22 14:25:07 +0000574 included + COMMON_INCLUDED_PATHS + [r'^.*\.md$'],
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900575 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800576 return _check_lines_in_diff(commit, files,
577 lambda line: line.rstrip() != line,
578 'Found line ending with white space in:')
Ryan Cui1562fb82011-05-09 11:01:31 -0700579
Ryan Cuiec4d6332011-05-02 14:15:25 -0700580
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900581def _check_no_tabs(_project, commit, options=()):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700582 """Checks there are no unexpanded tabs."""
Mike Frysingercd134512017-10-26 04:36:33 -0400583 # Don't add entire repos here. Update the PRESUBMIT.cfg in each repo instead.
Bob Haarman0dc1f942020-10-03 00:06:59 +0000584 # We only allow known specific filetypes here that show up in all repos.
Ryan Cuiec4d6332011-05-02 14:15:25 -0700585 TAB_OK_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400586 r'.*\.ebuild$',
587 r'.*\.eclass$',
588 r'.*\.go$',
589 r'.*/[M|m]akefile$',
590 r'.*\.mk$',
Ryan Cuiec4d6332011-05-02 14:15:25 -0700591 ]
592
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900593 included, excluded = _parse_common_inclusion_options(options)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700594 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900595 included + COMMON_INCLUDED_PATHS,
596 excluded + COMMON_EXCLUDED_PATHS + TAB_OK_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800597 return _check_lines_in_diff(commit, files,
598 lambda line: '\t' in line,
599 'Found a tab character in:')
Ryan Cuiec4d6332011-05-02 14:15:25 -0700600
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800601
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700602def _read_terms_file(terms_file):
603 """Read list of words from file, skipping comments and blank lines."""
604 file_terms = set()
605 for line in osutils.ReadFile(terms_file).splitlines():
606 # Allow comment and blank lines.
607 line = line.split('#', 1)[0]
608 if not line:
609 continue
610 file_terms.add(line)
611 return file_terms
612
613
Bernie Thompson8e26f742020-07-23 14:32:31 -0700614def _check_keywords(_project, commit, options=()):
615 """Checks there are no blocked keywords in commit content."""
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700616 # Read options from override list.
Bernie Thompson8e26f742020-07-23 14:32:31 -0700617 parser = argparse.ArgumentParser()
618 parser.add_argument('--exclude_regex', action='append', default=[])
619 parser.add_argument('--include_regex', action='append', default=[])
620 parser.add_argument('--block', action='append', default=[])
621 parser.add_argument('--unblock', action='append', default=[])
622 opts = parser.parse_args(options)
623
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700624 # Read blocked word list.
625 blocked_terms_file = os.path.join(_get_hooks_dir(), BLOCKED_TERMS_FILE)
626 common_keywords = _read_terms_file(blocked_terms_file)
627
628 # Read unblocked word list. Global list is skipped if local list exists.
629 unblocked_terms_file = os.path.join(_get_hooks_dir(), UNBLOCKED_TERMS_FILE)
630 if os.path.isfile(os.path.join(_project.dir, UNBLOCKED_TERMS_FILE)):
631 unblocked_terms_file = os.path.join(_project.dir, UNBLOCKED_TERMS_FILE)
632 unblocked_words = _read_terms_file(unblocked_terms_file)
633 unblocked_words.update(opts.unblock)
634
Bernie Thompson8e26f742020-07-23 14:32:31 -0700635 keywords = set(common_keywords | set(opts.block))
Daisuke Nojiri2089e012020-08-20 15:12:36 -0700636 keywords = sorted(keywords - unblocked_words)
Mike Frysinger6140f572020-09-10 04:52:46 -0400637 files = _filter_files(
638 _get_affected_files(commit),
Tomasz Figa375b9622020-09-22 14:25:07 +0000639 opts.include_regex + COMMON_INCLUDED_PATHS + [r'^.*\.md$'],
Mike Frysinger6140f572020-09-10 04:52:46 -0400640 opts.exclude_regex + COMMON_EXCLUDED_PATHS)
Bernie Thompson8e26f742020-07-23 14:32:31 -0700641 errors = []
642
643 def _check_line(line):
Laurent Chavey434af9a2020-09-28 22:25:16 +0900644 # Store information about each span matching blocking regex.
645 # to match unblocked regex with blocked reg ex match.
646 # [{'span':re.span, - overlap of matching regex in line
647 # 'group':re.group, - matching term
648 # 'blocked':bool, - True: matching blocked, False: matching unblocked
649 # 'keyword':regex, - block regex
650 # }, ...]
651 blocked_span = []
652 # Store information about each span matching unblocking regex.
653 # [re.span, ...]
654 unblocked_span = []
655
Bernie Thompson8e26f742020-07-23 14:32:31 -0700656 for word in keywords:
Laurent Chavey434af9a2020-09-28 22:25:16 +0900657 for match in re.finditer(word, line, flags=re.I):
658 blocked_span.append({'span' : match.span(),
659 'group' : match.group(0),
660 'blocked' : True,
661 'keyword' : word})
662
663 for unblocked in unblocked_words:
664 for match in re.finditer(unblocked, line, flags=re.I):
665 unblocked_span.append(match.span())
666
667 # Unblock terms that are superset of blocked terms:
668 # blocked := "this.?word"
669 # unblocked := "\.this.?word"
670 # "this line is blocked because of this1word"
671 # "this line is unblocked because of thenew.this1word"
672 #
673 for b in blocked_span:
674 for ub in unblocked_span:
675 if ub[0] <= b['span'][0] and ub[1] >= b['span'][1]:
676 b['blocked'] = False
677 if b['blocked']:
678 return f'Matched "{b["group"]}" with regex of "{b["keyword"]}"'
Bernie Thompson8e26f742020-07-23 14:32:31 -0700679 return False
680
681 diff_errors = _check_lines_in_diff(commit, files, _check_line,
682 'Found a blocked keyword in:')
683 if diff_errors:
684 errors.append(diff_errors)
685
686 line_num = 1
687 commit_desc_errors = []
688 for line in _get_commit_desc(commit).splitlines():
689 result = _check_line(line)
690 if result:
691 commit_desc_errors.append('Commit message, line %s: %s' %
692 (line_num, result))
693 line_num += 1
694 if commit_desc_errors:
695 errors.append(HookFailure('Found a blocked keyword in:',
696 commit_desc_errors))
697 return errors
698
699
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900700def _check_tabbed_indents(_project, commit, options=()):
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800701 """Checks that indents use tabs only."""
702 TABS_REQUIRED_PATHS = [
Mike Frysinger24dd3c52019-08-17 14:22:48 -0400703 r'.*\.ebuild$',
704 r'.*\.eclass$',
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800705 ]
706 LEADING_SPACE_RE = re.compile('[\t]* ')
707
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900708 included, excluded = _parse_common_inclusion_options(options)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800709 files = _filter_files(_get_affected_files(commit),
Shuhei Takahashiabc20f32017-07-10 19:35:45 +0900710 included + TABS_REQUIRED_PATHS,
711 excluded + COMMON_EXCLUDED_PATHS)
Prathmesh Prabhuc5254652016-12-22 12:58:05 -0800712 return _check_lines_in_diff(
713 commit, files,
714 lambda line: LEADING_SPACE_RE.match(line) is not None,
715 'Found a space in indentation (must be all tabs):')
Ryan Cui1562fb82011-05-09 11:01:31 -0700716
Ryan Cuiec4d6332011-05-02 14:15:25 -0700717
LaMont Jones872fe762020-02-10 15:36:14 -0700718def _check_gofmt(_project, commit, options=()):
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700719 """Checks that Go files are formatted with gofmt."""
LaMont Jones872fe762020-02-10 15:36:14 -0700720 included, excluded = _parse_common_inclusion_options(options)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700721 errors = []
722 files = _filter_files(_get_affected_files(commit, relative=True),
LaMont Jones872fe762020-02-10 15:36:14 -0700723 included + [r'\.go$'],
724 excluded)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700725
726 for gofile in files:
727 contents = _get_file_content(gofile, commit)
Mike Frysingeraa7dc942019-09-25 00:07:24 -0400728 output = _run_command(cmd=['gofmt', '-l'], input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500729 stderr=subprocess.STDOUT)
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700730 if output:
731 errors.append(gofile)
732 if errors:
733 return HookFailure('Files not formatted with gofmt:', errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400734 return None
Rahul Chaudhry09f61372015-07-31 17:14:26 -0700735
736
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600737def _check_rustfmt(_project, commit):
738 """Checks that Rust files are formatted with rustfmt."""
739 errors = []
740 files = _filter_files(_get_affected_files(commit, relative=True),
741 [r'\.rs$'])
742
743 for rustfile in files:
744 contents = _get_file_content(rustfile, commit)
Chirantan Ekbote1da56d52020-07-13 17:35:35 +0900745 output = _run_command(cmd=['rustfmt', '--edition', '2018'],
746 input=contents.encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -0500747 stderr=subprocess.STDOUT)
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600748 if output != contents:
749 errors.append(rustfile)
750 if errors:
751 return HookFailure('Files not formatted with rustfmt: '
752 "(run 'cargo fmt' to fix)", errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400753 return None
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -0600754
755
Keiichi Watanabe6ab73fd2020-07-14 23:42:02 +0900756class CargoClippyArgumentParserError(Exception):
757 """An exception indicating an invalid check_cargo_clippy option."""
758
759
760class CargoClippyArgumentParser(argparse.ArgumentParser):
761 """A argument parser for check_cargo_clippy."""
762
763 def error(self, message):
764 raise CargoClippyArgumentParserError(message)
765
766
767# A cargo project in which clippy runs.
768ClippyProject = collections.namedtuple('ClippyProject', ('root', 'script'))
769
770
771class _AddClippyProjectAction(argparse.Action):
772 """A callback that adds a cargo clippy setting.
773
774 It accepts a value which is in the form of "ROOT[:SCRIPT]".
775 """
776
777 def __call__(self, parser, namespace, values, option_string=None):
778 if getattr(namespace, self.dest, None) is None:
779 setattr(namespace, self.dest, [])
780 spec = values.split(':', 1)
781 if len(spec) == 1:
782 spec += [None]
783
784 if spec[0].startswith('/'):
785 raise CargoClippyArgumentParserError('root path must not start with "/"'
786 f' but "{spec[0]}"')
787
788 clippy = ClippyProject(root=spec[0], script=spec[1])
789 getattr(namespace, self.dest).append(clippy)
790
791
792def _get_cargo_clippy_parser():
793 """Creates a parser for check_cargo_clippy options."""
794
795 parser = CargoClippyArgumentParser()
796 parser.add_argument('--project', action=_AddClippyProjectAction, default=[])
797
798 return parser
799
800
801def _check_cargo_clippy(project, commit, options=()):
802 """Checks that a change doesn't produce cargo-clippy errors."""
803
804 options = list(options)
805 if not options:
806 return []
807 parser = _get_cargo_clippy_parser()
808
809 try:
810 opts = parser.parse_args(options)
811 except CargoClippyArgumentParserError as e:
812 return [HookFailure('invalid check_cargo_clippy option is given.'
813 f' Please check PRESUBMIT.cfg is correct: {e}')]
814 files = _get_affected_files(commit)
815
816 errors = []
817 for clippy in opts.project:
818 root = os.path.normpath(os.path.join(project.dir, clippy.root))
819
820 # Check if any file under `root` was modified.
821 modified = False
822 for f in files:
823 if f.startswith(root):
824 modified = True
825 break
826 if not modified:
827 continue
828
829 # Clean cargo's cache when we run clippy for this `root` for the first time.
830 # We don't want to clean the cache between commits to save time when
831 # multiple commits are checked.
832 if root not in _check_cargo_clippy.cleaned_root:
833 _run_command(['cargo', 'clean',
834 f'--manifest-path={root}/Cargo.toml'],
835 stderr=subprocess.STDOUT)
836 _check_cargo_clippy.cleaned_root.add(root)
837
838 cmd = ['cargo', 'clippy', '--all-features', '--all-targets',
839 f'--manifest-path={root}/Cargo.toml',
840 '--', '-D', 'warnings']
841 # Overwrite the clippy command if a project-specific script is specified.
842 if clippy.script:
843 cmd = [os.path.join(project.dir, clippy.script)]
844
845 output = _run_command(cmd, stderr=subprocess.STDOUT)
846 error = re.search(r'^error: ', output, flags=re.MULTILINE)
847 if error:
848 msg = output[error.start():]
849 errors.append(HookFailure(msg))
850
851 return errors
852
853
854# Stores cargo projects in which `cargo clean` ran.
855_check_cargo_clippy.cleaned_root = set()
856
857
Mike Frysingerae409522014-02-01 03:16:11 -0500858def _check_change_has_test_field(_project, commit):
Ryan Cuiec4d6332011-05-02 14:15:25 -0700859 """Check for a non-empty 'TEST=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500860 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700861
Cheng Yuehb707c522020-01-02 14:06:59 +0800862 if not re.search(TEST_FIELD_RE, _get_commit_desc(commit)):
Mike Frysingered9b2a02019-12-12 18:52:32 -0500863 msg = ('Changelist description needs TEST field (after first line)\n%s' %
864 (SEE_ALSO,))
Ryan Cui1562fb82011-05-09 11:01:31 -0700865 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400866 return None
Ryan Cui1562fb82011-05-09 11:01:31 -0700867
Ryan Cuiec4d6332011-05-02 14:15:25 -0700868
Mike Frysingerae409522014-02-01 03:16:11 -0500869def _check_change_has_valid_cq_depend(_project, commit):
Jason D. Clinton299e3222019-05-23 09:42:03 -0600870 """Check for a correctly formatted Cq-Depend field in the commit message."""
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700871 desc = _get_commit_desc(commit)
Jason D. Clinton299e3222019-05-23 09:42:03 -0600872 msg = 'Changelist has invalid Cq-Depend target.'
873 example = 'Example: Cq-Depend: chromium:1234, chrome-internal:2345'
David Jamesc3b68b32013-04-03 09:17:03 -0700874 try:
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700875 patch.GetPaladinDeps(desc)
David Jamesc3b68b32013-04-03 09:17:03 -0700876 except ValueError as ex:
877 return HookFailure(msg, [example, str(ex)])
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700878 # Check that Cq-Depend is in the same paragraph as Change-Id.
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500879 msg = 'Cq-Depend is not in the same paragraph as Change-Id.'
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700880 paragraphs = desc.split('\n\n')
881 for paragraph in paragraphs:
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500882 if (re.search(r'^Cq-Depend:', paragraph, re.M) and not
883 re.search('^Change-Id:', paragraph, re.M)):
Luigi Semenzatob8c7d7d2019-06-03 09:43:21 -0700884 return HookFailure(msg)
Mike Frysingere39d0cd2019-11-25 13:30:06 -0500885
886 # We no longer support CQ-DEPEND= lines.
887 if re.search(r'^CQ-DEPEND[=:]', desc, re.M):
888 return HookFailure(
889 'CQ-DEPEND= is no longer supported. Please see:\n'
890 'https://chromium.googlesource.com/chromiumos/docs/+/HEAD/'
891 'contributing.md#CQ-DEPEND')
892
Mike Frysinger8cf80812019-09-16 23:49:29 -0400893 return None
David Jamesc3b68b32013-04-03 09:17:03 -0700894
895
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800896def _check_change_is_contribution(_project, commit):
897 """Check that the change is a contribution."""
898 NO_CONTRIB = 'not a contribution'
899 if NO_CONTRIB in _get_commit_desc(commit).lower():
900 msg = ('Changelist is not a contribution, this cannot be accepted.\n'
901 'Please remove the "%s" text from the commit message.') % NO_CONTRIB
902 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -0400903 return None
Bernie Thompsonf8fea992016-01-14 10:27:18 -0800904
905
Alex Deymo643ac4c2015-09-03 10:40:50 -0700906def _check_change_has_bug_field(project, commit):
David McMahon8f6553e2011-06-10 15:46:36 -0700907 """Check for a correctly formatted 'BUG=' field in the commit message."""
Mike Frysingered9b2a02019-12-12 18:52:32 -0500908 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
909
David James5c0073d2013-04-03 08:48:52 -0700910 OLD_BUG_RE = r'\nBUG=.*chromium-os'
911 if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
912 msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
913 'the chromium tracker in your BUG= line now.')
914 return HookFailure(msg)
Ryan Cuiec4d6332011-05-02 14:15:25 -0700915
Alex Deymo643ac4c2015-09-03 10:40:50 -0700916 # Android internal and external projects use "Bug: " to track bugs in
917 # buganizer.
918 BUG_COLON_REMOTES = (
919 'aosp',
920 'goog',
921 )
922 if project.remote in BUG_COLON_REMOTES:
923 BUG_RE = r'\nBug: ?([Nn]one|\d+)'
924 if not re.search(BUG_RE, _get_commit_desc(commit)):
925 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500926 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700927 'Bug: 9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500928 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700929 return HookFailure(msg)
930 else:
Jorge Lucangeli Obesdce214e2017-10-25 15:04:39 -0400931 BUG_RE = r'\nBUG=([Nn]one|(chromium|b):\d+)'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700932 if not re.search(BUG_RE, _get_commit_desc(commit)):
933 msg = ('Changelist description needs BUG field (after first line):\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500934 'Examples:\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700935 'BUG=chromium:9999 (for public tracker)\n'
Alex Deymo643ac4c2015-09-03 10:40:50 -0700936 'BUG=b:9999 (for buganizer)\n'
Mike Frysingered9b2a02019-12-12 18:52:32 -0500937 'BUG=None\n%s' % (SEE_ALSO,))
Alex Deymo643ac4c2015-09-03 10:40:50 -0700938 return HookFailure(msg)
Ryan Cui1562fb82011-05-09 11:01:31 -0700939
Cheng Yuehb707c522020-01-02 14:06:59 +0800940 TEST_BEFORE_BUG_RE = TEST_FIELD_RE + r'.*' + BUG_RE
941
942 if re.search(TEST_BEFORE_BUG_RE, _get_commit_desc(commit), re.DOTALL):
943 msg = ('The BUG field must come before the TEST field.\n%s' %
944 (SEE_ALSO,))
945 return HookFailure(msg)
946
Mike Frysinger8cf80812019-09-16 23:49:29 -0400947 return None
948
Ryan Cuiec4d6332011-05-02 14:15:25 -0700949
Jack Neus8edbf642019-07-10 16:08:31 -0600950def _check_change_no_include_oem(project, commit):
951 """Check that the change does not reference OEMs."""
952 ALLOWLIST = {
953 'chromiumos/platform/ec',
954 # Used by unit tests.
955 'project',
956 }
957 if project.name not in ALLOWLIST:
958 return None
959
Mike Frysingerbb34a222019-07-31 14:40:46 -0400960 TAGS = {
Jack Neus8edbf642019-07-10 16:08:31 -0600961 'Reviewed-on',
962 'Reviewed-by',
963 'Signed-off-by',
964 'Commit-Ready',
965 'Tested-by',
966 'Commit-Queue',
Jack Neus8edbf642019-07-10 16:08:31 -0600967 'Acked-by',
968 'Modified-by',
969 'CC',
970 'Suggested-by',
971 'Reported-by',
972 'Acked-for-chrome-by',
LaMont Jones237f3ef2020-01-22 10:40:52 -0700973 'Cq-Cl-Tag',
LaMont Jonesfb5e8bf2020-03-03 12:50:06 -0700974 'Cq-Include-Trybots',
Mike Frysingerbb34a222019-07-31 14:40:46 -0400975 }
Jack Neus8edbf642019-07-10 16:08:31 -0600976
977 # Ignore tags, which could reasonably contain OEM names
978 # (e.g. Reviewed-by: foo@oem.corp-partner.google.com).
Jack Neus8edbf642019-07-10 16:08:31 -0600979 commit_message = ' '.join(
Mike Frysingerbb34a222019-07-31 14:40:46 -0400980 x for x in _get_commit_desc(commit).splitlines()
981 if ':' not in x or x.split(':', 1)[0] not in TAGS)
982
Jack Neus8edbf642019-07-10 16:08:31 -0600983 commit_message = re.sub(r'[\s_-]+', ' ', commit_message)
984
985 # Exercise caution when expanding these lists. Adding a name
986 # could indicate a new relationship with a company!
987 OEMS = ['hp', 'hewlett packard', 'dell', 'lenovo', 'acer', 'asus', 'samsung']
988 ODMS = [
989 'bitland', 'compal', 'haier', 'huaqin', 'inventec', 'lg', 'pegatron',
990 'pegatron(ems)', 'quanta', 'samsung', 'wistron'
991 ]
992
993 for name_type, name_list in [('OEM', OEMS), ('ODM', ODMS)]:
994 # Construct regex
995 name_re = r'\b(%s)\b' % '|'.join([re.escape(x) for x in name_list])
996 matches = [x[0] for x in re.findall(name_re, commit_message, re.IGNORECASE)]
Mike Frysingere52b1bc2019-09-16 23:45:41 -0400997 if matches:
Jack Neus8edbf642019-07-10 16:08:31 -0600998 # If there's a match, throw an error.
999 error_msg = ('Changelist description contains the name of an'
1000 ' %s: "%s".' % (name_type, '","'.join(matches)))
1001 return HookFailure(error_msg)
1002
Mike Frysinger8cf80812019-09-16 23:49:29 -04001003 return None
1004
Jack Neus8edbf642019-07-10 16:08:31 -06001005
Mike Frysinger292b45d2014-11-25 01:17:10 -05001006def _check_for_uprev(project, commit, project_top=None):
Doug Anderson42b8a052013-06-26 10:45:36 -07001007 """Check that we're not missing a revbump of an ebuild in the given commit.
1008
1009 If the given commit touches files in a directory that has ebuilds somewhere
1010 up the directory hierarchy, it's very likely that we need an ebuild revbump
1011 in order for those changes to take effect.
1012
1013 It's not totally trivial to detect a revbump, so at least detect that an
1014 ebuild with a revision number in it was touched. This should handle the
1015 common case where we use a symlink to do the revbump.
1016
1017 TODO: it would be nice to enhance this hook to:
1018 * Handle cases where people revbump with a slightly different syntax. I see
1019 one ebuild (puppy) that revbumps with _pN. This is a false positive.
1020 * Catches cases where people aren't using symlinks for revbumps. If they
1021 edit a revisioned file directly (and are expected to rename it for revbump)
1022 we'll miss that. Perhaps we could detect that the file touched is a
1023 symlink?
1024
1025 If a project doesn't use symlinks we'll potentially miss a revbump, but we're
1026 still better off than without this check.
1027
1028 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001029 project: The Project to look at
Doug Anderson42b8a052013-06-26 10:45:36 -07001030 commit: The commit to look at
Mike Frysinger292b45d2014-11-25 01:17:10 -05001031 project_top: Top dir to process commits in
Doug Anderson42b8a052013-06-26 10:45:36 -07001032
1033 Returns:
1034 A HookFailure or None.
1035 """
Mike Frysinger011af942014-01-17 16:12:22 -05001036 # If this is the portage-stable overlay, then ignore the check. It's rare
1037 # that we're doing anything other than importing files from upstream, so
1038 # forcing a rev bump makes no sense.
Bob Haarman0dc1f942020-10-03 00:06:59 +00001039 allowlist = (
Mike Frysinger011af942014-01-17 16:12:22 -05001040 'chromiumos/overlays/portage-stable',
1041 )
Bob Haarman0dc1f942020-10-03 00:06:59 +00001042 if project.name in allowlist:
Mike Frysinger011af942014-01-17 16:12:22 -05001043 return None
1044
Mike Frysinger292b45d2014-11-25 01:17:10 -05001045 def FinalName(obj):
1046 # If the file is being deleted, then the dst_file is not set.
1047 if obj.dst_file is None:
1048 return obj.src_file
1049 else:
1050 return obj.dst_file
1051
Stephen Boyd6bf5ea82020-10-15 00:02:07 -07001052 def AllowedPath(obj):
Mike Frysinger78dbc242020-11-27 16:46:39 -05001053 allowed_files = {
1054 'ChangeLog', 'Manifest', 'metadata.xml', 'OWNERS', 'README.md',
1055 }
Stephen Boyd6bf5ea82020-10-15 00:02:07 -07001056 allowed_directories = {'profiles'}
1057
1058 affected = pathlib.Path(FinalName(obj))
1059 if affected.name in allowed_files:
1060 return True
1061
1062 for directory in allowed_directories:
1063 if directory in affected.parts:
1064 return True
1065
1066 return False
1067
Mike Frysinger292b45d2014-11-25 01:17:10 -05001068 affected_path_objs = _get_affected_files(
1069 commit, include_deletes=True, include_symlinks=True, relative=True,
1070 full_details=True)
Doug Anderson42b8a052013-06-26 10:45:36 -07001071
Stephen Boyd6bf5ea82020-10-15 00:02:07 -07001072 # Don't yell about changes to allowed files or directories...
Mike Frysinger292b45d2014-11-25 01:17:10 -05001073 affected_path_objs = [x for x in affected_path_objs
Stephen Boyd6bf5ea82020-10-15 00:02:07 -07001074 if not AllowedPath(x)]
Mike Frysinger292b45d2014-11-25 01:17:10 -05001075 if not affected_path_objs:
Doug Anderson42b8a052013-06-26 10:45:36 -07001076 return None
1077
1078 # If we've touched any file named with a -rN.ebuild then we'll say we're
1079 # OK right away. See TODO above about enhancing this.
Mike Frysinger292b45d2014-11-25 01:17:10 -05001080 touched_revved_ebuild = any(re.search(r'-r\d*\.ebuild$', FinalName(x))
1081 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -07001082 if touched_revved_ebuild:
1083 return None
1084
Mike Frysinger292b45d2014-11-25 01:17:10 -05001085 # If we're creating new ebuilds from scratch, then we don't need an uprev.
1086 # Find all the dirs that new ebuilds and ignore their files/.
1087 ebuild_dirs = [os.path.dirname(FinalName(x)) + '/' for x in affected_path_objs
1088 if FinalName(x).endswith('.ebuild') and x.status == 'A']
1089 affected_path_objs = [obj for obj in affected_path_objs
1090 if not any(FinalName(obj).startswith(x)
1091 for x in ebuild_dirs)]
1092 if not affected_path_objs:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001093 return None
Mike Frysinger292b45d2014-11-25 01:17:10 -05001094
Doug Anderson42b8a052013-06-26 10:45:36 -07001095 # We want to examine the current contents of all directories that are parents
1096 # of files that were touched (up to the top of the project).
1097 #
1098 # ...note: we use the current directory contents even though it may have
1099 # changed since the commit we're looking at. This is just a heuristic after
1100 # all. Worst case we don't flag a missing revbump.
Mike Frysinger292b45d2014-11-25 01:17:10 -05001101 if project_top is None:
1102 project_top = os.getcwd()
Doug Anderson42b8a052013-06-26 10:45:36 -07001103 dirs_to_check = set([project_top])
Mike Frysinger292b45d2014-11-25 01:17:10 -05001104 for obj in affected_path_objs:
1105 path = os.path.join(project_top, os.path.dirname(FinalName(obj)))
Doug Anderson42b8a052013-06-26 10:45:36 -07001106 while os.path.exists(path) and not os.path.samefile(path, project_top):
1107 dirs_to_check.add(path)
1108 path = os.path.dirname(path)
1109
1110 # Look through each directory. If it's got an ebuild in it then we'll
1111 # consider this as a case when we need a revbump.
Gwendal Grignoua3086c32014-12-09 11:17:22 -08001112 affected_paths = set(os.path.join(project_top, FinalName(x))
1113 for x in affected_path_objs)
Doug Anderson42b8a052013-06-26 10:45:36 -07001114 for dir_path in dirs_to_check:
1115 contents = os.listdir(dir_path)
1116 ebuilds = [os.path.join(dir_path, path)
1117 for path in contents if path.endswith('.ebuild')]
1118 ebuilds_9999 = [path for path in ebuilds if path.endswith('-9999.ebuild')]
1119
C Shapiroae157ae2017-09-18 16:24:03 -06001120 affected_paths_under_9999_ebuilds = set()
1121 for affected_path in affected_paths:
1122 for ebuild_9999 in ebuilds_9999:
1123 ebuild_dir = os.path.dirname(ebuild_9999)
1124 if affected_path.startswith(ebuild_dir):
1125 affected_paths_under_9999_ebuilds.add(affected_path)
1126
1127 # If every file changed exists under a 9999 ebuild, then skip
1128 if len(affected_paths_under_9999_ebuilds) == len(affected_paths):
1129 continue
1130
Doug Anderson42b8a052013-06-26 10:45:36 -07001131 # If the -9999.ebuild file was touched the bot will uprev for us.
1132 # ...we'll use a simple intersection here as a heuristic...
Mike Frysinger292b45d2014-11-25 01:17:10 -05001133 if set(ebuilds_9999) & affected_paths:
Doug Anderson42b8a052013-06-26 10:45:36 -07001134 continue
1135
1136 if ebuilds:
Mike Frysinger292b45d2014-11-25 01:17:10 -05001137 return HookFailure('Changelist probably needs a revbump of an ebuild, '
1138 'or a -r1.ebuild symlink if this is a new ebuild:\n'
1139 '%s' % dir_path)
Doug Anderson42b8a052013-06-26 10:45:36 -07001140
1141 return None
1142
1143
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001144def _check_ebuild_eapi(project, commit):
Mike Frysinger948284a2018-02-01 15:22:56 -05001145 """Make sure we have people use EAPI=5 or newer with custom ebuilds.
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001146
1147 We want to get away from older EAPI's as it makes life confusing and they
1148 have less builtin error checking.
1149
1150 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001151 project: The Project to look at
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001152 commit: The commit to look at
1153
1154 Returns:
1155 A HookFailure or None.
1156 """
1157 # If this is the portage-stable overlay, then ignore the check. It's rare
Mike Frysingercd6adfc2014-02-06 01:03:56 -05001158 # that we're doing anything other than importing files from upstream, and
1159 # we shouldn't be rewriting things fundamentally anyways.
Bob Haarman0dc1f942020-10-03 00:06:59 +00001160 allowlist = (
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001161 'chromiumos/overlays/portage-stable',
1162 )
Bob Haarman0dc1f942020-10-03 00:06:59 +00001163 if project.name in allowlist:
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001164 return None
1165
Mike Frysinger948284a2018-02-01 15:22:56 -05001166 BAD_EAPIS = ('0', '1', '2', '3', '4')
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001167
1168 get_eapi = re.compile(r'^\s*EAPI=[\'"]?([^\'"]+)')
1169
1170 ebuilds_re = [r'\.ebuild$']
1171 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1172 ebuilds_re)
1173 bad_ebuilds = []
1174
1175 for ebuild in ebuilds:
1176 # If the ebuild does not specify an EAPI, it defaults to 0.
1177 eapi = '0'
1178
1179 lines = _get_file_content(ebuild, commit).splitlines()
1180 if len(lines) == 1:
1181 # This is most likely a symlink, so skip it entirely.
1182 continue
1183
1184 for line in lines:
1185 m = get_eapi.match(line)
1186 if m:
1187 # Once we hit the first EAPI line in this ebuild, stop processing.
1188 # The spec requires that there only be one and it be first, so
1189 # checking all possible values is pointless. We also assume that
1190 # it's "the" EAPI line and not something in the middle of a heredoc.
1191 eapi = m.group(1)
1192 break
1193
1194 if eapi in BAD_EAPIS:
1195 bad_ebuilds.append((ebuild, eapi))
1196
1197 if bad_ebuilds:
1198 # pylint: disable=C0301
Mike Frysingerc6114f42020-05-15 00:55:05 -04001199 url = 'https://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/upgrade-ebuild-eapis'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001200 # pylint: enable=C0301
1201 return HookFailure(
Mike Frysingercd6adfc2014-02-06 01:03:56 -05001202 'These ebuilds are using old EAPIs. If these are imported from\n'
1203 'Gentoo, then you may ignore and upload once with the --no-verify\n'
Mike Frysingerc6114f42020-05-15 00:55:05 -04001204 'flag. Otherwise, please update to 7 or newer.\n'
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001205 '\t%s\n'
1206 'See this guide for more details:\n%s\n' %
1207 ('\n\t'.join(['%s: EAPI=%s' % x for x in bad_ebuilds]), url))
1208
Mike Frysinger8cf80812019-09-16 23:49:29 -04001209 return None
1210
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05001211
Mike Frysinger89bdb852014-02-01 05:26:26 -05001212def _check_ebuild_keywords(_project, commit):
Mike Frysingerc51ece72014-01-17 16:23:40 -05001213 """Make sure we use the new style KEYWORDS when possible in ebuilds.
1214
1215 If an ebuild generally does not care about the arch it is running on, then
1216 ebuilds should flag it with one of:
1217 KEYWORDS="*" # A stable ebuild.
1218 KEYWORDS="~*" # An unstable ebuild.
1219 KEYWORDS="-* ..." # Is known to only work on specific arches.
1220
1221 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07001222 project: The Project to look at
Mike Frysingerc51ece72014-01-17 16:23:40 -05001223 commit: The commit to look at
1224
1225 Returns:
1226 A HookFailure or None.
1227 """
Bob Haarman0dc1f942020-10-03 00:06:59 +00001228 ALLOWLIST = set(('*', '-*', '~*'))
Mike Frysingerc51ece72014-01-17 16:23:40 -05001229
1230 get_keywords = re.compile(r'^\s*KEYWORDS="(.*)"')
1231
Mike Frysinger89bdb852014-02-01 05:26:26 -05001232 ebuilds_re = [r'\.ebuild$']
1233 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1234 ebuilds_re)
1235
Mike Frysinger8d42d742014-09-22 15:50:21 -04001236 bad_ebuilds = []
Mike Frysingerc51ece72014-01-17 16:23:40 -05001237 for ebuild in ebuilds:
Mike Frysinger5c9e58d2014-09-09 03:32:50 -04001238 # We get the full content rather than a diff as the latter does not work
1239 # on new files (like when adding new ebuilds).
1240 lines = _get_file_content(ebuild, commit).splitlines()
1241 for line in lines:
Mike Frysingerc51ece72014-01-17 16:23:40 -05001242 m = get_keywords.match(line)
1243 if m:
1244 keywords = set(m.group(1).split())
Bob Haarman0dc1f942020-10-03 00:06:59 +00001245 if not keywords or ALLOWLIST - keywords != ALLOWLIST:
Mike Frysingerc51ece72014-01-17 16:23:40 -05001246 continue
1247
Mike Frysinger8d42d742014-09-22 15:50:21 -04001248 bad_ebuilds.append(ebuild)
1249
1250 if bad_ebuilds:
1251 return HookFailure(
1252 '%s\n'
1253 'Please update KEYWORDS to use a glob:\n'
1254 'If the ebuild should be marked stable (normal for non-9999 ebuilds):\n'
1255 ' KEYWORDS="*"\n'
1256 'If the ebuild should be marked unstable (normal for '
1257 'cros-workon / 9999 ebuilds):\n'
1258 ' KEYWORDS="~*"\n'
Mike Frysingerde8efea2015-05-17 03:42:26 -04001259 'If the ebuild needs to be marked for only specific arches, '
Mike Frysinger8d42d742014-09-22 15:50:21 -04001260 'then use -* like so:\n'
1261 ' KEYWORDS="-* arm ..."\n' % '\n* '.join(bad_ebuilds))
Mike Frysingerc51ece72014-01-17 16:23:40 -05001262
Mike Frysinger8cf80812019-09-16 23:49:29 -04001263 return None
1264
Mike Frysingerc51ece72014-01-17 16:23:40 -05001265
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001266def _check_ebuild_licenses(_project, commit):
1267 """Check if the LICENSE field in the ebuild is correct."""
Brian Norris7a610e82016-02-17 12:24:54 -08001268 affected_paths = _get_affected_files(commit, relative=True)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001269 touched_ebuilds = [x for x in affected_paths if x.endswith('.ebuild')]
1270
1271 # A list of licenses to ignore for now.
Yu-Ju Hongc0963fa2014-03-03 12:36:52 -08001272 LICENSES_IGNORE = ['||', '(', ')']
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001273
1274 for ebuild in touched_ebuilds:
1275 # Skip virutal packages.
1276 if ebuild.split('/')[-3] == 'virtual':
1277 continue
1278
Alex Kleinb5953522018-08-03 11:44:21 -06001279 # e.g. path/to/overlay/category/package/package.ebuild -> path/to/overlay
1280 overlay_path = os.sep.join(ebuild.split(os.sep)[:-3])
1281
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001282 try:
Brian Norris7a610e82016-02-17 12:24:54 -08001283 ebuild_content = _get_file_content(ebuild, commit)
Alex Kleinb5953522018-08-03 11:44:21 -06001284 license_types = licenses_lib.GetLicenseTypesFromEbuild(ebuild_content,
1285 overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001286 except ValueError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001287 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001288
1289 # Also ignore licenses ending with '?'
1290 for license_type in [x for x in license_types
1291 if x not in LICENSES_IGNORE and not x.endswith('?')]:
1292 try:
Alex Kleinb5953522018-08-03 11:44:21 -06001293 licenses_lib.Licensing.FindLicenseType(license_type,
1294 overlay_path=overlay_path)
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001295 except AssertionError as e:
Mike Frysingerf1ee2bf2019-09-16 23:47:33 -04001296 return HookFailure(str(e), [ebuild])
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001297
Mike Frysinger8cf80812019-09-16 23:49:29 -04001298 return None
1299
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08001300
Mike Frysingerb04778f2020-11-30 02:41:14 -05001301def _check_ebuild_owners(_project, commit):
1302 """Require all new packages include an OWNERS file."""
1303 # Look for all adds/removes since we're going to ignore changes that only
1304 # update a package. We only want to flag new package imports for now.
1305 affected_files_objs = _get_affected_files(
1306 commit, include_deletes=True, include_symlinks=True, relative=True,
1307 full_details=True)
1308
1309 # If this CL doesn't include any ebuilds, don't bother complaining.
1310 new_ebuilds = [x for x in affected_files_objs
1311 if x.status == 'A' and x.src_file.endswith('.ebuild')]
1312 if not new_ebuilds:
1313 return None
1314
1315 # Check each package dir.
1316 packages_missing_owners = []
1317 package_dirs = sorted(set(os.path.dirname(x.src_file) for x in new_ebuilds))
1318 for package_dir in package_dirs:
1319 package_files = [
1320 x for x in affected_files_objs
1321 if (x.src_file and x.src_file.startswith(f'{package_dir}/')) or
1322 (x.dst_file and x.dst_file.startswith(f'{package_dir}/'))]
1323
1324 # Only complain about new ebuilds, not existing ones. For now.
1325 # We'll assume that "all adds" means it's a new package.
1326 if any(x for x in package_files if x.status != 'A'):
1327 continue
1328
1329 # See if there's an OWNERS file in there already.
1330 if not _get_file_content(os.path.join(package_dir, 'OWNERS'), commit):
1331 packages_missing_owners.append(package_dir)
1332
1333 if packages_missing_owners:
1334 return HookFailure(
1335 'All new packages must have an OWNERS file included.',
1336 packages_missing_owners)
1337
1338 return None
1339
1340
Mike Frysinger6ee76b82020-11-20 01:16:06 -05001341def _check_ebuild_r0(_project, commit):
1342 """Do not allow ebuilds to end with -r0 versions."""
1343 ebuilds = _filter_files(
1344 _get_affected_files(commit, include_symlinks=True, relative=True),
1345 (r'-r0\.ebuild$',))
1346 if ebuilds:
1347 return HookFailure(
1348 'The -r0 in ebuilds is redundant and confusing. Simply remove it.\n'
1349 'For example: git mv foo-1.0-r0.ebuild foo-1.0.ebuild',
1350 ebuilds)
1351
1352 return None
1353
1354
Mike Frysingercd363c82014-02-01 05:20:18 -05001355def _check_ebuild_virtual_pv(project, commit):
1356 """Enforce the virtual PV policies."""
1357 # If this is the portage-stable overlay, then ignore the check.
1358 # We want to import virtuals as-is from upstream Gentoo.
Bob Haarman0dc1f942020-10-03 00:06:59 +00001359 allowlist = (
Mike Frysingercd363c82014-02-01 05:20:18 -05001360 'chromiumos/overlays/portage-stable',
1361 )
Bob Haarman0dc1f942020-10-03 00:06:59 +00001362 if project.name in allowlist:
Mike Frysingercd363c82014-02-01 05:20:18 -05001363 return None
1364
1365 # We assume the repo name is the same as the dir name on disk.
1366 # It would be dumb to not have them match though.
Alex Deymo643ac4c2015-09-03 10:40:50 -07001367 project_base = os.path.basename(project.name)
Mike Frysingercd363c82014-02-01 05:20:18 -05001368
1369 is_variant = lambda x: x.startswith('overlay-variant-')
1370 is_board = lambda x: x.startswith('overlay-')
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001371 is_baseboard = lambda x: x.startswith('baseboard-')
1372 is_chipset = lambda x: x.startswith('chipset-')
1373 is_project = lambda x: x.startswith('project-')
Mike Frysingercd363c82014-02-01 05:20:18 -05001374 is_private = lambda x: x.endswith('-private')
1375
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001376 is_special_overlay = lambda x: (is_board(x) or is_chipset(x) or
1377 is_baseboard(x) or is_project(x))
1378
Mike Frysingercd363c82014-02-01 05:20:18 -05001379 get_pv = re.compile(r'(.*?)virtual/([^/]+)/\2-([^/]*)\.ebuild$')
1380
1381 ebuilds_re = [r'\.ebuild$']
1382 ebuilds = _filter_files(_get_affected_files(commit, relative=True),
1383 ebuilds_re)
1384 bad_ebuilds = []
1385
1386 for ebuild in ebuilds:
1387 m = get_pv.match(ebuild)
1388 if m:
1389 overlay = m.group(1)
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001390 if not overlay or not is_special_overlay(overlay):
Alex Deymo643ac4c2015-09-03 10:40:50 -07001391 overlay = project_base
Mike Frysingercd363c82014-02-01 05:20:18 -05001392
1393 pv = m.group(3).split('-', 1)[0]
1394
Bernie Thompsone5ee1822016-01-12 14:22:23 -08001395 # Virtual versions >= 4 are special cases used above the standard
1396 # versioning structure, e.g. if one has a board inheriting a board.
Julius Werner0299a2b2020-07-31 18:20:43 -07001397 if pv[0] >= '4':
Bernie Thompsone5ee1822016-01-12 14:22:23 -08001398 want_pv = pv
Mike Frysingercd363c82014-02-01 05:20:18 -05001399 elif is_board(overlay):
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001400 if is_private(overlay):
1401 want_pv = '3.5' if is_variant(overlay) else '3'
1402 elif is_board(overlay):
1403 want_pv = '2.5' if is_variant(overlay) else '2'
1404 elif is_baseboard(overlay):
Julius Werner0299a2b2020-07-31 18:20:43 -07001405 want_pv = '1.9.5' if is_private(overlay) else '1.9'
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001406 elif is_chipset(overlay):
Julius Werner0299a2b2020-07-31 18:20:43 -07001407 want_pv = '1.8.5' if is_private(overlay) else '1.8'
Douglas Andersonb43df7f2018-06-25 13:40:50 -07001408 elif is_project(overlay):
1409 want_pv = '1.7' if is_private(overlay) else '1.5'
Mike Frysingercd363c82014-02-01 05:20:18 -05001410 else:
1411 want_pv = '1'
1412
1413 if pv != want_pv:
1414 bad_ebuilds.append((ebuild, pv, want_pv))
1415
1416 if bad_ebuilds:
1417 # pylint: disable=C0301
1418 url = 'http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/portage-build-faq#TOC-Virtuals-and-central-management'
1419 # pylint: enable=C0301
1420 return HookFailure(
1421 'These virtuals have incorrect package versions (PVs). Please adjust:\n'
1422 '\t%s\n'
1423 'If this is an upstream Gentoo virtual, then you may ignore this\n'
1424 'check (and re-run w/--no-verify). Otherwise, please see this\n'
1425 'page for more details:\n%s\n' %
1426 ('\n\t'.join(['%s:\n\t\tPV is %s but should be %s' % x
1427 for x in bad_ebuilds]), url))
1428
Mike Frysinger8cf80812019-09-16 23:49:29 -04001429 return None
1430
Mike Frysingercd363c82014-02-01 05:20:18 -05001431
Daniel Erat9d203ff2015-02-17 10:12:21 -07001432def _check_portage_make_use_var(_project, commit):
1433 """Verify that $USE is set correctly in make.conf and make.defaults."""
1434 files = _filter_files(_get_affected_files(commit, relative=True),
1435 [r'(^|/)make.(conf|defaults)$'])
1436
1437 errors = []
1438 for path in files:
1439 basename = os.path.basename(path)
1440
1441 # Has a USE= line already been encountered in this file?
1442 saw_use = False
1443
1444 for i, line in enumerate(_get_file_content(path, commit).splitlines(), 1):
1445 if not line.startswith('USE='):
1446 continue
1447
1448 preserves_use = '${USE}' in line or '$USE' in line
1449
1450 if (basename == 'make.conf' or
1451 (basename == 'make.defaults' and saw_use)) and not preserves_use:
1452 errors.append('%s:%d: missing ${USE}' % (path, i))
1453 elif basename == 'make.defaults' and not saw_use and preserves_use:
1454 errors.append('%s:%d: ${USE} referenced in initial declaration' %
1455 (path, i))
1456
1457 saw_use = True
1458
1459 if errors:
1460 return HookFailure(
1461 'One or more Portage make files appear to set USE incorrectly.\n'
1462 '\n'
1463 'All USE assignments in make.conf and all assignments after the\n'
1464 'initial declaration in make.defaults should contain "${USE}" to\n'
1465 'preserve previously-set flags.\n'
1466 '\n'
1467 'The initial USE declaration in make.defaults should not contain\n'
1468 '"${USE}".\n',
1469 errors)
1470
Mike Frysinger8cf80812019-09-16 23:49:29 -04001471 return None
1472
Daniel Erat9d203ff2015-02-17 10:12:21 -07001473
Mike Frysingerae409522014-02-01 03:16:11 -05001474def _check_change_has_proper_changeid(_project, commit):
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001475 """Verify that Change-ID is present in last paragraph of commit message."""
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001476 CHANGE_ID_RE = r'\nChange-Id: I[a-f0-9]+\n'
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001477 desc = _get_commit_desc(commit)
Mike Frysinger4a22bf02014-10-31 13:53:35 -04001478 m = re.search(CHANGE_ID_RE, desc)
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001479 if not m:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001480 return HookFailure('Last paragraph of description must include Change-Id.')
Ryan Cui1562fb82011-05-09 11:01:31 -07001481
LaMont Jonesfb5e8bf2020-03-03 12:50:06 -07001482 # S-o-b and some other tags always allowed to follow Change-ID in the footer.
1483 allowed_tags = ['Signed-off-by', 'Cq-Cl-Tag', 'Cq-Include-Trybots']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001484
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001485 end = desc[m.end():].strip().splitlines()
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001486 cherry_pick_marker = 'cherry picked from commit'
1487
1488 if end and cherry_pick_marker in end[-1]:
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001489 # Cherry picked patches allow more tags in the last paragraph.
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001490 allowed_tags += ['Commit-Queue', 'Commit-Ready', 'Reviewed-by',
1491 'Reviewed-on', 'Tested-by']
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001492 end = end[:-1]
1493
Vadim Bendebury6504aea2017-09-13 18:35:49 -07001494 # Note that descriptions could have multiple cherry pick markers.
1495 tag_search = r'^(%s:|\(%s) ' % (':|'.join(allowed_tags), cherry_pick_marker)
Vadim Bendebury20532ba2017-05-23 17:26:15 -07001496
1497 if [x for x in end if not re.search(tag_search, x)]:
1498 return HookFailure('Only "%s:" tag(s) may follow the Change-Id.' %
1499 ':", "'.join(allowed_tags))
Mike Frysinger02b88bd2014-11-21 00:29:38 -05001500
Mike Frysinger8cf80812019-09-16 23:49:29 -04001501 return None
1502
Mandeep Singh Bainesa23eb5f2011-05-04 13:43:25 -07001503
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001504def _check_commit_message_style(_project, commit):
1505 """Verify that the commit message matches our style.
1506
1507 We do not check for BUG=/TEST=/etc... lines here as that is handled by other
1508 commit hooks.
1509 """
Mike Frysingered9b2a02019-12-12 18:52:32 -05001510 SEE_ALSO = 'Please review the documentation:\n%s' % (DOC_COMMIT_MSG_URL,)
Mike Frysinger4efdee72019-11-04 10:57:01 -05001511
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001512 desc = _get_commit_desc(commit)
1513
1514 # The first line should be by itself.
1515 lines = desc.splitlines()
1516 if len(lines) > 1 and lines[1]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001517 return HookFailure('The second line of the commit message must be blank.'
1518 '\n%s' % (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001519
1520 # The first line should be one sentence.
1521 if '. ' in lines[0]:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001522 return HookFailure('The first line cannot be more than one sentence.\n%s' %
1523 (SEE_ALSO,))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001524
1525 # The first line cannot be too long.
1526 MAX_FIRST_LINE_LEN = 100
1527 if len(lines[0]) > MAX_FIRST_LINE_LEN:
Mike Frysinger4efdee72019-11-04 10:57:01 -05001528 return HookFailure('The first line must be less than %i chars.\n%s' %
1529 (MAX_FIRST_LINE_LEN, SEE_ALSO))
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001530
Mike Frysinger8cf80812019-09-16 23:49:29 -04001531 return None
1532
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04001533
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001534def _check_cros_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001535 """Verifies the Chromium OS license/copyright header.
Ryan Cuiec4d6332011-05-02 14:15:25 -07001536
Mike Frysinger98638102014-08-28 00:15:08 -04001537 Should be following the spec:
1538 http://dev.chromium.org/developers/coding-style#TOC-File-headers
1539 """
1540 # For older years, be a bit more flexible as our policy says leave them be.
1541 LICENSE_HEADER = (
Keigo Oka7e880ac2019-07-03 15:03:43 +09001542 r'.*Copyright(?: \(c\))? (20[0-9]{2})(?:-20[0-9]{2})? The Chromium OS '
1543 r'Authors\. All rights reserved\.\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001544 r'.*Use of this source code is governed by a BSD-style license that can '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001545 r'be\n'
Brian Norris68838dd2018-09-26 18:30:24 -07001546 r'.*found in the LICENSE file\.'
Mike Frysingerb81102f2014-11-21 00:33:35 -05001547 r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001548 )
1549 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1550
1551 # For newer years, be stricter.
Keigo Oka7e880ac2019-07-03 15:03:43 +09001552 BAD_COPYRIGHT_LINE = (
Brian Norris68838dd2018-09-26 18:30:24 -07001553 r'.*Copyright \(c\) 20(1[5-9]|[2-9][0-9]) The Chromium OS Authors\. '
Mike Frysingerb81102f2014-11-21 00:33:35 -05001554 r'All rights reserved\.' r'\n'
Mike Frysinger98638102014-08-28 00:15:08 -04001555 )
Keigo Oka7e880ac2019-07-03 15:03:43 +09001556 bad_copyright_re = re.compile(BAD_COPYRIGHT_LINE)
Mike Frysinger98638102014-08-28 00:15:08 -04001557
Shuhei Takahashiabc20f32017-07-10 19:35:45 +09001558 included, excluded = _parse_common_inclusion_options(options)
Filipe Brandenburger4b542b12015-10-09 12:46:31 -07001559
Mike Frysinger98638102014-08-28 00:15:08 -04001560 bad_files = []
1561 bad_copyright_files = []
Keigo Oka7e880ac2019-07-03 15:03:43 +09001562 bad_year_files = []
1563
Ken Turnerd07564b2018-02-08 17:57:59 +11001564 files = _filter_files(
1565 _get_affected_files(commit, relative=True),
1566 included + COMMON_INCLUDED_PATHS,
1567 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001568 existing_files = set(_get_affected_files(commit, relative=True,
1569 include_adds=False))
Mike Frysinger98638102014-08-28 00:15:08 -04001570
Keigo Oka7e880ac2019-07-03 15:03:43 +09001571 current_year = str(datetime.datetime.now().year)
Mike Frysinger98638102014-08-28 00:15:08 -04001572 for f in files:
1573 contents = _get_file_content(f, commit)
1574 if not contents:
1575 # Ignore empty files.
1576 continue
1577
Keigo Oka7e880ac2019-07-03 15:03:43 +09001578 m = license_re.search(contents)
1579 if not m:
Mike Frysinger98638102014-08-28 00:15:08 -04001580 bad_files.append(f)
Keigo Oka7e880ac2019-07-03 15:03:43 +09001581 elif bad_copyright_re.search(contents):
Mike Frysinger98638102014-08-28 00:15:08 -04001582 bad_copyright_files.append(f)
1583
Keigo Oka7e880ac2019-07-03 15:03:43 +09001584 if m and f not in existing_files:
1585 year = m.group(1)
1586 if year != current_year:
1587 bad_year_files.append(f)
1588
1589 errors = []
Mike Frysinger98638102014-08-28 00:15:08 -04001590 if bad_files:
1591 msg = '%s:\n%s\n%s' % (
1592 'License must match', license_re.pattern,
1593 'Found a bad header in these files:')
Keigo Oka7e880ac2019-07-03 15:03:43 +09001594 errors.append(HookFailure(msg, bad_files))
Mike Frysinger98638102014-08-28 00:15:08 -04001595 if bad_copyright_files:
1596 msg = 'Do not use (c) in copyright headers in new files:'
Keigo Oka7e880ac2019-07-03 15:03:43 +09001597 errors.append(HookFailure(msg, bad_copyright_files))
1598 if bad_year_files:
1599 msg = 'Use current year (%s) in copyright headers in new files:' % (
1600 current_year)
1601 errors.append(HookFailure(msg, bad_year_files))
Ryan Cuiec4d6332011-05-02 14:15:25 -07001602
Keigo Oka7e880ac2019-07-03 15:03:43 +09001603 return errors
Ryan Cuiec4d6332011-05-02 14:15:25 -07001604
Mike Frysinger8cf80812019-09-16 23:49:29 -04001605
Amin Hassani391efa92018-01-26 17:58:05 -08001606def _check_aosp_license(_project, commit, options=()):
Alex Deymof5792ce2015-08-24 22:50:08 -07001607 """Verifies the AOSP license/copyright header.
1608
1609 AOSP uses the Apache2 License:
1610 https://source.android.com/source/licenses.html
1611 """
1612 LICENSE_HEADER = (
1613 r"""^[#/\*]*
1614[#/\*]* ?Copyright( \([cC]\))? 20[-0-9]{2,7} The Android Open Source Project
1615[#/\*]* ?
1616[#/\*]* ?Licensed under the Apache License, Version 2.0 \(the "License"\);
1617[#/\*]* ?you may not use this file except in compliance with the License\.
1618[#/\*]* ?You may obtain a copy of the License at
1619[#/\*]* ?
1620[#/\*]* ? http://www\.apache\.org/licenses/LICENSE-2\.0
1621[#/\*]* ?
1622[#/\*]* ?Unless required by applicable law or agreed to in writing, software
1623[#/\*]* ?distributed under the License is distributed on an "AS IS" BASIS,
1624[#/\*]* ?WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or """
1625 r"""implied\.
1626[#/\*]* ?See the License for the specific language governing permissions and
1627[#/\*]* ?limitations under the License\.
1628[#/\*]*$
1629"""
1630 )
1631 license_re = re.compile(LICENSE_HEADER, re.MULTILINE)
1632
Amin Hassani391efa92018-01-26 17:58:05 -08001633 included, excluded = _parse_common_inclusion_options(options)
1634
Ken Turnerd07564b2018-02-08 17:57:59 +11001635 files = _filter_files(
1636 _get_affected_files(commit, relative=True),
1637 included + COMMON_INCLUDED_PATHS,
1638 excluded + COMMON_EXCLUDED_PATHS + LICENSE_EXCLUDED_PATHS)
Alex Deymof5792ce2015-08-24 22:50:08 -07001639
1640 bad_files = []
1641 for f in files:
1642 contents = _get_file_content(f, commit)
1643 if not contents:
1644 # Ignore empty files.
1645 continue
1646
1647 if not license_re.search(contents):
1648 bad_files.append(f)
1649
1650 if bad_files:
1651 msg = ('License must match:\n%s\nFound a bad header in these files:' %
1652 license_re.pattern)
1653 return HookFailure(msg, bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001654 return None
Alex Deymof5792ce2015-08-24 22:50:08 -07001655
1656
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001657def _check_layout_conf(_project, commit):
1658 """Verifies the metadata/layout.conf file."""
1659 repo_name = 'profiles/repo_name'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001660 repo_names = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001661 layout_path = 'metadata/layout.conf'
Mike Frysinger94a670c2014-09-19 12:46:26 -04001662 layout_paths = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001663
Mike Frysinger94a670c2014-09-19 12:46:26 -04001664 # Handle multiple overlays in a single commit (like the public tree).
1665 for f in _get_affected_files(commit, relative=True):
1666 if f.endswith(repo_name):
1667 repo_names.append(f)
1668 elif f.endswith(layout_path):
1669 layout_paths.append(f)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001670
1671 # Disallow new repos with the repo_name file.
Mike Frysinger94a670c2014-09-19 12:46:26 -04001672 if repo_names:
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001673 return HookFailure('%s: use "repo-name" in %s instead' %
Mike Frysinger94a670c2014-09-19 12:46:26 -04001674 (repo_names, layout_path))
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001675
Mike Frysinger94a670c2014-09-19 12:46:26 -04001676 # Gather all the errors in one pass so we show one full message.
1677 all_errors = {}
1678 for layout_path in layout_paths:
1679 all_errors[layout_path] = errors = []
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001680
Mike Frysinger94a670c2014-09-19 12:46:26 -04001681 # Make sure the config file is sorted.
1682 data = [x for x in _get_file_content(layout_path, commit).splitlines()
1683 if x and x[0] != '#']
1684 if sorted(data) != data:
1685 errors += ['keep lines sorted']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001686
Mike Frysinger94a670c2014-09-19 12:46:26 -04001687 # Require people to set specific values all the time.
1688 settings = (
1689 # TODO: Enable this for everyone. http://crbug.com/408038
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09001690 # ('fast caching', 'cache-format = md5-dict'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001691 ('fast manifests', 'thin-manifests = true'),
Mike Frysingerd7734522015-02-26 16:12:43 -05001692 ('extra features', 'profile-formats = portage-2 profile-default-eapi'),
1693 ('newer eapi', 'profile_eapi_when_unspecified = 5-progress'),
Mike Frysinger94a670c2014-09-19 12:46:26 -04001694 )
1695 for reason, line in settings:
1696 if line not in data:
1697 errors += ['enable %s with: %s' % (reason, line)]
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001698
Mike Frysinger94a670c2014-09-19 12:46:26 -04001699 # Require one of these settings.
Mike Frysinger5fae62d2015-11-11 20:12:15 -05001700 if 'use-manifests = strict' not in data:
1701 errors += ['enable file checking with: use-manifests = strict']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001702
Mike Frysinger94a670c2014-09-19 12:46:26 -04001703 # Require repo-name to be set.
Mike Frysinger324cf682014-09-22 15:52:50 -04001704 for line in data:
1705 if line.startswith('repo-name = '):
1706 break
1707 else:
Mike Frysinger94a670c2014-09-19 12:46:26 -04001708 errors += ['set the board name with: repo-name = $BOARD']
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001709
Mike Frysinger94a670c2014-09-19 12:46:26 -04001710 # Summarize all the errors we saw (if any).
1711 lines = ''
1712 for layout_path, errors in all_errors.items():
1713 if errors:
1714 lines += '\n\t- '.join(['\n* %s:' % layout_path] + errors)
1715 if lines:
1716 lines = 'See the portage(5) man page for layout.conf details' + lines + '\n'
1717 return HookFailure(lines)
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001718
Mike Frysinger8cf80812019-09-16 23:49:29 -04001719 return None
1720
Mike Frysinger998c2cc2014-08-27 05:20:23 -04001721
Keigo Oka4a09bd92019-05-07 14:01:00 +09001722def _check_no_new_gyp(_project, commit):
1723 """Verifies no project starts to use GYP."""
Keigo Oka4a09bd92019-05-07 14:01:00 +09001724 gypfiles = _filter_files(
1725 _get_affected_files(commit, include_symlinks=True, relative=True),
1726 [r'\.gyp$'])
1727
1728 if gypfiles:
1729 return HookFailure('GYP is deprecated and not allowed in a new project:',
1730 gypfiles)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001731 return None
Keigo Oka4a09bd92019-05-07 14:01:00 +09001732
1733
Ryan Cuiec4d6332011-05-02 14:15:25 -07001734# Project-specific hooks
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001735
Ryan Cui1562fb82011-05-09 11:01:31 -07001736
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001737def _check_clang_format(_project, commit, options=()):
1738 """Runs clang-format on the given project"""
1739 hooks_dir = _get_hooks_dir()
1740 options = list(options)
1741 if commit == PRE_SUBMIT:
1742 options.append('--commit=HEAD')
1743 else:
1744 options.extend(['--commit', commit])
Brian Norris0c62a142018-12-11 13:24:29 -08001745 cmd = [os.path.join(hooks_dir, 'clang-format.py')] + options
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001746 cmd_result = cros_build_lib.run(cmd,
1747 print_cmd=False,
1748 stdout=True,
1749 encoding='utf-8',
1750 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001751 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001752 check=False)
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001753 if cmd_result.returncode:
1754 return HookFailure('clang-format.py errors/warnings\n\n' +
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001755 cmd_result.stdout)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001756 return None
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07001757
1758
Mike Frysingerae409522014-02-01 03:16:11 -05001759def _run_checkpatch(_project, commit, options=()):
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001760 """Runs checkpatch.pl on the given project"""
Tomasz Figabd8faf62020-09-22 14:06:05 +00001761 # Bypass checkpatch for upstream or almost upstream commits, since we do not
1762 # intend to modify the upstream commits when landing them to our branches.
1763 # Any fixes should sent as independent patches.
1764 # The check is retained for FROMLIST and BACKPORT commits, as by definition
1765 # those can be still fixed up.
1766 desc = _get_commit_desc(commit)
1767 if desc.startswith('UPSTREAM:') or desc.startswith('FROMGIT:'):
1768 return None
1769
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001770 hooks_dir = _get_hooks_dir()
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001771 options = list(options)
Brian Norris4cee0502020-06-12 17:02:56 -07001772 if options and options[0].startswith('./') and os.path.exists(options[0]):
1773 cmdpath = options.pop(0)
1774 else:
1775 cmdpath = os.path.join(hooks_dir, 'checkpatch.pl')
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001776 if commit == PRE_SUBMIT:
1777 # The --ignore option must be present and include 'MISSING_SIGN_OFF' in
1778 # this case.
1779 options.append('--ignore=MISSING_SIGN_OFF')
Filipe Brandenburger28d48d62015-10-07 09:48:54 -07001780 # Always ignore the check for the MAINTAINERS file. We do not track that
1781 # information on that file in our source trees, so let's suppress the
1782 # warning.
1783 options.append('--ignore=FILE_PATH_CHANGES')
Filipe Brandenburgerce978322015-10-09 10:04:15 -07001784 # Do not complain about the Change-Id: fields, since we use Gerrit.
1785 # Upstream does not want those lines (since they do not use Gerrit), but
1786 # we always do, so disable the check globally.
Daisuke Nojiri4844f892015-10-08 09:54:33 -07001787 options.append('--ignore=GERRIT_CHANGE_ID')
Brian Norris4cee0502020-06-12 17:02:56 -07001788 cmd = [cmdpath] + options + ['-']
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001789 cmd_result = cros_build_lib.run(
1790 cmd, print_cmd=False, input=_get_patch(commit).encode('utf-8'),
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001791 stdout=True, stderr=subprocess.STDOUT, check=False, encoding='utf-8',
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001792 errors='replace')
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001793 if cmd_result.returncode:
Brian Norris4cee0502020-06-12 17:02:56 -07001794 return HookFailure('%s errors/warnings\n\n%s' %
1795 (cmdpath, cmd_result.stdout))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001796 return None
Ryan Cuiec4d6332011-05-02 14:15:25 -07001797
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07001798
Brian Norris23c62e92018-11-14 12:25:51 -08001799def _run_kerneldoc(_project, commit, options=()):
1800 """Runs kernel-doc validator on the given project"""
1801 included, excluded = _parse_common_inclusion_options(options)
1802 files = _filter_files(_get_affected_files(commit, relative=True),
1803 included, excluded)
1804 if files:
1805 hooks_dir = _get_hooks_dir()
Brian Norris0c62a142018-12-11 13:24:29 -08001806 cmd = [os.path.join(hooks_dir, 'kernel-doc'), '-none'] + files
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001807 output = _run_command(cmd, stderr=subprocess.STDOUT)
Brian Norris23c62e92018-11-14 12:25:51 -08001808 if output:
Brian Norris0c62a142018-12-11 13:24:29 -08001809 return HookFailure('kernel-doc errors/warnings:',
1810 items=output.splitlines())
Mike Frysinger8cf80812019-09-16 23:49:29 -04001811 return None
Brian Norris23c62e92018-11-14 12:25:51 -08001812
1813
Mike Frysingerae409522014-02-01 03:16:11 -05001814def _kernel_configcheck(_project, commit):
Olof Johanssona96810f2012-09-04 16:20:03 -07001815 """Makes sure kernel config changes are not mixed with code changes"""
1816 files = _get_affected_files(commit)
Mike Frysingerf252cfc2019-12-09 17:34:28 -05001817 if len(_filter_files(files, [r'chromeos/config'])) not in [0, len(files)]:
Olof Johanssona96810f2012-09-04 16:20:03 -07001818 return HookFailure('Changes to chromeos/config/ and regular files must '
1819 'be in separate commits:\n%s' % '\n'.join(files))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001820 return None
Anton Staaf815d6852011-08-22 10:08:45 -07001821
Mike Frysingerae409522014-02-01 03:16:11 -05001822
1823def _run_json_check(_project, commit):
Dale Curtis2975c432011-05-03 17:25:20 -07001824 """Checks that all JSON files are syntactically valid."""
Mike Frysinger908be682018-01-04 02:21:50 -05001825 ret = []
1826
1827 files = _filter_files(_get_affected_files(commit, relative=True),
1828 [r'.*\.json$'])
1829 for f in files:
1830 data = _get_file_content(f, commit)
Dale Curtis2975c432011-05-03 17:25:20 -07001831 try:
Mike Frysinger908be682018-01-04 02:21:50 -05001832 json.loads(data)
1833 except Exception as e:
1834 ret.append('%s: Invalid JSON: %s' % (f, e))
1835
1836 if ret:
1837 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001838 return None
Dale Curtis2975c432011-05-03 17:25:20 -07001839
1840
Mike Frysingerae409522014-02-01 03:16:11 -05001841def _check_manifests(_project, commit):
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001842 """Make sure Manifest files only have comments & DIST lines."""
1843 ret = []
Mike Frysinger52b537e2013-08-22 22:59:53 -04001844
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001845 manifests = _filter_files(_get_affected_files(commit, relative=True),
1846 [r'.*/Manifest$'])
1847 for path in manifests:
1848 data = _get_file_content(path, commit)
1849
1850 # Disallow blank files.
1851 if not data.strip():
1852 ret.append('%s: delete empty file' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001853 continue
1854
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001855 # Make sure the last newline isn't omitted.
1856 if data[-1] != '\n':
1857 ret.append('%s: missing trailing newline' % (path,))
Mike Frysinger52b537e2013-08-22 22:59:53 -04001858
Mike Frysingeraae3cb52018-01-03 16:49:33 -05001859 # Do not allow leading or trailing blank lines.
1860 lines = data.splitlines()
1861 if not lines[0]:
1862 ret.append('%s: delete leading blank lines' % (path,))
1863 if not lines[-1]:
1864 ret.append('%s: delete trailing blank lines' % (path,))
1865
1866 for line in lines:
1867 # Disallow leading/trailing whitespace.
1868 if line != line.strip():
1869 ret.append('%s: remove leading/trailing whitespace: %s' % (path, line))
1870
1871 # Allow blank lines & comments.
1872 line = line.split('#', 1)[0]
1873 if not line:
1874 continue
1875
1876 # All other linse should start with DIST.
1877 if not line.startswith('DIST '):
1878 ret.append('%s: remove non-DIST lines: %s' % (path, line))
1879 break
1880
1881 if ret:
1882 return HookFailure('\n'.join(ret))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001883 return None
Mike Frysinger52b537e2013-08-22 22:59:53 -04001884
1885
Mike Frysingerae409522014-02-01 03:16:11 -05001886def _check_change_has_branch_field(_project, commit):
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001887 """Check for a non-empty 'BRANCH=' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001888 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001889 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001890 BRANCH_RE = r'\nBRANCH=\S+'
1891
1892 if not re.search(BRANCH_RE, _get_commit_desc(commit)):
1893 msg = ('Changelist description needs BRANCH field (after first line)\n'
1894 'E.g. BRANCH=none or BRANCH=link,snow')
1895 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001896 return None
Puneet Kumarc80e3f62012-08-13 19:01:18 -07001897
1898
Mike Frysinger45334bd2019-11-04 10:42:33 -05001899def _check_change_has_no_branch_field(_project, commit):
1900 """Verify 'BRANCH=' field does not exist in the commit message."""
1901 if commit == PRE_SUBMIT:
1902 return None
1903 BRANCH_RE = r'\nBRANCH=\S+'
1904
1905 if re.search(BRANCH_RE, _get_commit_desc(commit)):
1906 msg = 'This checkout does not use BRANCH= fields. Delete them.'
1907 return HookFailure(msg)
1908 return None
1909
1910
Mike Frysingerae409522014-02-01 03:16:11 -05001911def _check_change_has_signoff_field(_project, commit):
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001912 """Check for a non-empty 'Signed-off-by:' field in the commit message."""
Vadim Bendebury2b62d742014-06-22 13:14:51 -07001913 if commit == PRE_SUBMIT:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001914 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001915 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1916
1917 if not re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1918 msg = ('Changelist description needs Signed-off-by: field\n'
1919 'E.g. Signed-off-by: My Name <me@chromium.org>')
1920 return HookFailure(msg)
Mike Frysinger8cf80812019-09-16 23:49:29 -04001921 return None
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08001922
1923
Mike Frysinger9ab64b12019-11-04 10:53:08 -05001924def _check_change_has_no_signoff_field(_project, commit):
1925 """Verify 'Signed-off-by:' field does not exist in the commit message."""
1926 if commit == PRE_SUBMIT:
1927 return None
1928 SIGNOFF_RE = r'\nSigned-off-by: \S+'
1929
1930 if re.search(SIGNOFF_RE, _get_commit_desc(commit)):
1931 msg = 'This checkout does not use Signed-off-by: tags. Delete them.'
1932 return HookFailure(msg)
1933 return None
1934
1935
Jon Salz3ee59de2012-08-18 13:54:22 +08001936def _run_project_hook_script(script, project, commit):
1937 """Runs a project hook script.
1938
1939 The script is run with the following environment variables set:
1940 PRESUBMIT_PROJECT: The affected project
1941 PRESUBMIT_COMMIT: The affected commit
1942 PRESUBMIT_FILES: A newline-separated list of affected files
1943
1944 The script is considered to fail if the exit code is non-zero. It should
1945 write an error message to stdout.
1946 """
1947 env = dict(os.environ)
Alex Deymo643ac4c2015-09-03 10:40:50 -07001948 env['PRESUBMIT_PROJECT'] = project.name
Jon Salz3ee59de2012-08-18 13:54:22 +08001949 env['PRESUBMIT_COMMIT'] = commit
1950
1951 # Put affected files in an environment variable
1952 files = _get_affected_files(commit)
1953 env['PRESUBMIT_FILES'] = '\n'.join(files)
1954
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001955 cmd_result = cros_build_lib.run(cmd=script,
1956 env=env,
1957 shell=True,
1958 print_cmd=False,
1959 input=os.devnull,
1960 stdout=True,
1961 encoding='utf-8',
1962 errors='replace',
Mike Frysingerd0c5c8b2019-12-17 02:28:26 -05001963 stderr=subprocess.STDOUT,
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001964 check=False)
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001965 if cmd_result.returncode:
Mike Frysinger7bb709f2019-09-29 23:20:12 -04001966 stdout = cmd_result.stdout
Jon Salz7b618af2012-08-31 06:03:16 +08001967 if stdout:
1968 stdout = re.sub('(?m)^', ' ', stdout)
1969 return HookFailure('Hook script "%s" failed with code %d%s' %
Rahul Chaudhry0e515342015-08-07 12:00:43 -07001970 (script, cmd_result.returncode,
Jon Salz3ee59de2012-08-18 13:54:22 +08001971 ':\n' + stdout if stdout else ''))
Mike Frysinger8cf80812019-09-16 23:49:29 -04001972 return None
Jon Salz3ee59de2012-08-18 13:54:22 +08001973
1974
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001975def _check_project_prefix(_project, commit):
Mike Frysinger55f85b52014-12-18 14:45:21 -05001976 """Require the commit message have a project specific prefix as needed."""
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001977
Brian Norris77608e12018-04-06 10:38:43 -07001978 files = _get_affected_files(commit, include_deletes=True, relative=True)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001979 prefix = os.path.commonprefix(files)
1980 prefix = os.path.dirname(prefix)
1981
1982 # If there is no common prefix, the CL span multiple projects.
Daniel Erata350fd32014-09-29 14:02:34 -07001983 if not prefix:
Mike Frysinger8cf80812019-09-16 23:49:29 -04001984 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07001985
1986 project_name = prefix.split('/')[0]
Daniel Erata350fd32014-09-29 14:02:34 -07001987
1988 # The common files may all be within a subdirectory of the main project
1989 # directory, so walk up the tree until we find an alias file.
1990 # _get_affected_files() should return relative paths, but check against '/' to
1991 # ensure that this loop terminates even if it receives an absolute path.
1992 while prefix and prefix != '/':
1993 alias_file = os.path.join(prefix, '.project_alias')
1994
1995 # If an alias exists, use it.
1996 if os.path.isfile(alias_file):
1997 project_name = osutils.ReadFile(alias_file).strip()
1998
1999 prefix = os.path.dirname(prefix)
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07002000
2001 if not _get_commit_desc(commit).startswith(project_name + ': '):
2002 return HookFailure('The commit title for changes affecting only %s'
2003 ' should start with \"%s: \"'
2004 % (project_name, project_name))
Mike Frysinger8cf80812019-09-16 23:49:29 -04002005 return None
Bertrand SIMONNET0022fff2014-07-07 09:52:15 -07002006
2007
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09002008def _check_filepath_chartype(_project, commit):
2009 """Checks that FilePath::CharType stuff is not used."""
2010
2011 FILEPATH_REGEXP = re.compile('|'.join(
2012 [r'(?:base::)?FilePath::(?:Char|String|StringPiece)Type',
Satoru Takabayashi4ca37922018-08-08 10:16:38 +09002013 r'(?:base::)?FilePath::FromUTF8Unsafe',
2014 r'AsUTF8Unsafe',
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09002015 r'FILE_PATH_LITERAL']))
2016 files = _filter_files(_get_affected_files(commit, relative=True),
2017 [r'.*\.(cc|h)$'])
2018
2019 errors = []
2020 for afile in files:
2021 for line_num, line in _get_file_diff(afile, commit):
2022 m = re.search(FILEPATH_REGEXP, line)
2023 if m:
2024 errors.append('%s, line %s has %s' % (afile, line_num, m.group(0)))
2025
2026 if errors:
2027 msg = 'Please assume FilePath::CharType is char (crbug.com/870621):'
2028 return HookFailure(msg, errors)
Mike Frysinger8cf80812019-09-16 23:49:29 -04002029 return None
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09002030
2031
Mike Frysingerf9d41b32017-02-23 15:20:04 -05002032def _check_exec_files(_project, commit):
2033 """Make +x bits on files."""
2034 # List of files that should never be +x.
2035 NO_EXEC = (
2036 'ChangeLog*',
2037 'COPYING',
2038 'make.conf',
2039 'make.defaults',
2040 'Manifest',
2041 'OWNERS',
2042 'package.use',
2043 'package.keywords',
2044 'package.mask',
2045 'parent',
2046 'README',
2047 'TODO',
2048 '.gitignore',
2049 '*.[achly]',
2050 '*.[ch]xx',
2051 '*.boto',
2052 '*.cc',
2053 '*.cfg',
2054 '*.conf',
2055 '*.config',
2056 '*.cpp',
2057 '*.css',
2058 '*.ebuild',
2059 '*.eclass',
Tatsuhisa Yamaguchi3b053632019-01-10 14:45:14 +09002060 '*.gn',
2061 '*.gni',
Mike Frysingerf9d41b32017-02-23 15:20:04 -05002062 '*.gyp',
2063 '*.gypi',
2064 '*.htm',
2065 '*.html',
2066 '*.ini',
2067 '*.js',
2068 '*.json',
2069 '*.md',
2070 '*.mk',
2071 '*.patch',
2072 '*.policy',
2073 '*.proto',
2074 '*.raw',
2075 '*.rules',
2076 '*.service',
2077 '*.target',
2078 '*.txt',
2079 '*.xml',
2080 '*.yaml',
2081 )
2082
2083 def FinalName(obj):
2084 # If the file is being deleted, then the dst_file is not set.
2085 if obj.dst_file is None:
2086 return obj.src_file
2087 else:
2088 return obj.dst_file
2089
2090 bad_files = []
2091 files = _get_affected_files(commit, relative=True, full_details=True)
2092 for f in files:
2093 mode = int(f.dst_mode, 8)
2094 if not mode & 0o111:
2095 continue
2096 name = FinalName(f)
2097 for no_exec in NO_EXEC:
2098 if fnmatch.fnmatch(name, no_exec):
2099 bad_files.append(name)
2100 break
2101
2102 if bad_files:
2103 return HookFailure('These files should not be executable. '
2104 'Please `chmod -x` them.', bad_files)
Mike Frysinger8cf80812019-09-16 23:49:29 -04002105 return None
Mike Frysingerf9d41b32017-02-23 15:20:04 -05002106
2107
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002108# Base
2109
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002110# A list of hooks which are not project specific and check patch description
2111# (as opposed to patch body).
2112_PATCH_DESCRIPTION_HOOKS = [
Ryan Cui9b651632011-05-11 11:38:58 -07002113 _check_change_has_bug_field,
David Jamesc3b68b32013-04-03 09:17:03 -07002114 _check_change_has_valid_cq_depend,
Ryan Cui9b651632011-05-11 11:38:58 -07002115 _check_change_has_test_field,
2116 _check_change_has_proper_changeid,
Mike Frysinger36b2ebc2014-10-31 14:02:03 -04002117 _check_commit_message_style,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08002118 _check_change_is_contribution,
Jack Neus8edbf642019-07-10 16:08:31 -06002119 _check_change_no_include_oem,
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002120]
2121
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002122# A list of hooks that are not project-specific
2123_COMMON_HOOKS = [
Keiichi Watanabe6ab73fd2020-07-14 23:42:02 +09002124 _check_cargo_clippy,
Aviv Keshet5ac59522017-01-31 14:28:27 -08002125 _check_cros_license,
Mike Frysingerbf8b91c2014-02-01 02:50:27 -05002126 _check_ebuild_eapi,
Mike Frysinger89bdb852014-02-01 05:26:26 -05002127 _check_ebuild_keywords,
Yu-Ju Hong5e0efa72013-11-19 16:28:10 -08002128 _check_ebuild_licenses,
Mike Frysingerb04778f2020-11-30 02:41:14 -05002129 _check_ebuild_owners,
Mike Frysinger6ee76b82020-11-20 01:16:06 -05002130 _check_ebuild_r0,
Mike Frysingercd363c82014-02-01 05:20:18 -05002131 _check_ebuild_virtual_pv,
Mike Frysingerf9d41b32017-02-23 15:20:04 -05002132 _check_exec_files,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002133 _check_for_uprev,
Rahul Chaudhry09f61372015-07-31 17:14:26 -07002134 _check_gofmt,
Bernie Thompson8e26f742020-07-23 14:32:31 -07002135 _check_keywords,
Mike Frysinger998c2cc2014-08-27 05:20:23 -04002136 _check_layout_conf,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002137 _check_no_long_lines,
Keigo Oka4a09bd92019-05-07 14:01:00 +09002138 _check_no_new_gyp,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002139 _check_no_stray_whitespace,
Ryan Cui9b651632011-05-11 11:38:58 -07002140 _check_no_tabs,
Daniel Erat9d203ff2015-02-17 10:12:21 -07002141 _check_portage_make_use_var,
Fletcher Woodruffce1cb1b2019-08-16 15:59:32 -06002142 _check_rustfmt,
Aviv Keshet5ac59522017-01-31 14:28:27 -08002143 _check_tabbed_indents,
Ryan Cui9b651632011-05-11 11:38:58 -07002144]
Ryan Cuiec4d6332011-05-02 14:15:25 -07002145
Ryan Cui1562fb82011-05-09 11:01:31 -07002146
Ryan Cui9b651632011-05-11 11:38:58 -07002147# A dictionary of project-specific hooks(callbacks), indexed by project name.
2148# dict[project] = [callback1, callback2]
2149_PROJECT_SPECIFIC_HOOKS = {
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002150 'chromiumos/third_party/kernel': [_kernel_configcheck],
2151 'chromiumos/third_party/kernel-next': [_kernel_configcheck],
Ryan Cui9b651632011-05-11 11:38:58 -07002152}
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002153
Ryan Cui1562fb82011-05-09 11:01:31 -07002154
Ryan Cui9b651632011-05-11 11:38:58 -07002155# A dictionary of flags (keys) that can appear in the config file, and the hook
Mike Frysinger3554bc92015-03-11 04:59:21 -04002156# that the flag controls (value).
2157_HOOK_FLAGS = {
Luis Hector Chavezb50391d2017-09-26 15:48:15 -07002158 'clang_format_check': _check_clang_format,
Mike Frysingera7642f52015-03-25 18:31:42 -04002159 'checkpatch_check': _run_checkpatch,
Brian Norris23c62e92018-11-14 12:25:51 -08002160 'kerneldoc_check': _run_kerneldoc,
Ryan Cui9b651632011-05-11 11:38:58 -07002161 'stray_whitespace_check': _check_no_stray_whitespace,
Mike Frysingerff6c7d62015-03-24 13:49:46 -04002162 'json_check': _run_json_check,
Ryan Cui9b651632011-05-11 11:38:58 -07002163 'long_line_check': _check_no_long_lines,
Alex Deymof5792ce2015-08-24 22:50:08 -07002164 'cros_license_check': _check_cros_license,
2165 'aosp_license_check': _check_aosp_license,
LaMont Jones872fe762020-02-10 15:36:14 -07002166 'gofmt_check': _check_gofmt,
Bernie Thompson8e26f742020-07-23 14:32:31 -07002167 'keyword_check': _check_keywords,
Ryan Cui9b651632011-05-11 11:38:58 -07002168 'tab_check': _check_no_tabs,
Prathmesh Prabhuc5254652016-12-22 12:58:05 -08002169 'tabbed_indent_required_check': _check_tabbed_indents,
Puneet Kumarc80e3f62012-08-13 19:01:18 -07002170 'branch_check': _check_change_has_branch_field,
Shawn Nematbakhsh51e16ac2014-01-28 15:31:07 -08002171 'signoff_check': _check_change_has_signoff_field,
Josh Triplett0e8fc7f2014-04-23 16:00:00 -07002172 'bug_field_check': _check_change_has_bug_field,
2173 'test_field_check': _check_change_has_test_field,
Steve Fung49ec7e92015-03-23 16:07:12 -07002174 'manifest_check': _check_manifests,
Bernie Thompsonf8fea992016-01-14 10:27:18 -08002175 'contribution_check': _check_change_is_contribution,
Mike Frysinger47bd1252018-06-11 12:12:20 -04002176 'project_prefix_check': _check_project_prefix,
Satoru Takabayashi15d17a52018-08-06 11:12:15 +09002177 'filepath_chartype_check': _check_filepath_chartype,
Keiichi Watanabe6ab73fd2020-07-14 23:42:02 +09002178 'cargo_clippy_check': _check_cargo_clippy,
Julius Werner291d8602020-07-31 17:34:02 -07002179 'exec_files_check': _check_exec_files,
Ryan Cui9b651632011-05-11 11:38:58 -07002180}
2181
2182
Mike Frysinger3554bc92015-03-11 04:59:21 -04002183def _get_override_hooks(config):
2184 """Returns a set of hooks controlled by the current project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07002185
2186 Expects to be called within the project root.
Jon Salz3ee59de2012-08-18 13:54:22 +08002187
2188 Args:
2189 config: A ConfigParser for the project's config file.
Ryan Cui9b651632011-05-11 11:38:58 -07002190 """
2191 SECTION = 'Hook Overrides'
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002192 SECTION_OPTIONS = 'Hook Overrides Options'
Ryan Cui9b651632011-05-11 11:38:58 -07002193
Mike Frysinger56e8de02019-07-31 14:40:14 -04002194 valid_keys = set(_HOOK_FLAGS.keys())
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002195 hooks = _HOOK_FLAGS.copy()
Mike Frysinger180ecd62020-08-19 00:41:51 -04002196 hook_overrides = set(
2197 config.options(SECTION) if config.has_section(SECTION) else [])
2198
2199 unknown_keys = hook_overrides - valid_keys
2200 if unknown_keys:
2201 raise ValueError(f'{_CONFIG_FILE}: [{SECTION}]: unknown keys: '
2202 f'{unknown_keys}')
Mike Frysinger3554bc92015-03-11 04:59:21 -04002203
2204 enable_flags = []
Ryan Cui9b651632011-05-11 11:38:58 -07002205 disable_flags = []
Mike Frysinger180ecd62020-08-19 00:41:51 -04002206 for flag in valid_keys:
2207 if flag in hook_overrides:
2208 try:
2209 enabled = config.getboolean(SECTION, flag)
2210 except ValueError as e:
2211 raise ValueError('Error: parsing flag "%s" in "%s" failed: %s' %
2212 (flag, _CONFIG_FILE, e))
2213 elif hooks[flag] in _COMMON_HOOKS:
2214 # Enable common hooks by default so we process custom options below.
2215 enabled = True
2216 else:
2217 # All other hooks we left as a tristate. We use this below for a few
2218 # hooks to control default behavior.
2219 enabled = None
Mike Frysinger3554bc92015-03-11 04:59:21 -04002220
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002221 if enabled:
2222 enable_flags.append(flag)
Mike Frysinger180ecd62020-08-19 00:41:51 -04002223 elif enabled is not None:
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002224 disable_flags.append(flag)
Ryan Cui9b651632011-05-11 11:38:58 -07002225
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002226 # See if this hook has custom options.
2227 if enabled:
2228 try:
2229 options = config.get(SECTION_OPTIONS, flag)
2230 hooks[flag] = functools.partial(hooks[flag], options=options.split())
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002231 hooks[flag].__name__ = flag
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04002232 except (configparser.NoOptionError, configparser.NoSectionError):
Mike Frysingerf8ce1712015-03-25 18:32:33 -04002233 pass
2234
2235 enabled_hooks = set(hooks[x] for x in enable_flags)
2236 disabled_hooks = set(hooks[x] for x in disable_flags)
Mike Frysinger45334bd2019-11-04 10:42:33 -05002237
Mike Frysinger9ab64b12019-11-04 10:53:08 -05002238 if _check_change_has_signoff_field not in enabled_hooks:
Drew Davenport85848e52020-01-15 14:40:29 -07002239 if _check_change_has_signoff_field not in disabled_hooks:
2240 enabled_hooks.add(_check_change_has_no_signoff_field)
Mike Frysinger45334bd2019-11-04 10:42:33 -05002241 if _check_change_has_branch_field not in enabled_hooks:
2242 enabled_hooks.add(_check_change_has_no_branch_field)
2243
Mike Frysinger3554bc92015-03-11 04:59:21 -04002244 return enabled_hooks, disabled_hooks
Ryan Cui9b651632011-05-11 11:38:58 -07002245
2246
Jon Salz3ee59de2012-08-18 13:54:22 +08002247def _get_project_hook_scripts(config):
2248 """Returns a list of project-specific hook scripts.
2249
2250 Args:
2251 config: A ConfigParser for the project's config file.
2252 """
2253 SECTION = 'Hook Scripts'
2254 if not config.has_section(SECTION):
2255 return []
2256
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002257 return config.items(SECTION)
Jon Salz3ee59de2012-08-18 13:54:22 +08002258
2259
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002260def _get_project_hooks(project, presubmit, config_file=None):
Ryan Cui9b651632011-05-11 11:38:58 -07002261 """Returns a list of hooks that need to be run for a project.
2262
2263 Expects to be called from within the project root.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002264
2265 Args:
2266 project: A string, name of the project.
2267 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002268 config_file: A string, the config file. Defaults to _CONFIG_FILE.
Ryan Cui9b651632011-05-11 11:38:58 -07002269 """
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04002270 config = configparser.RawConfigParser()
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002271 if config_file is None:
2272 config_file = _CONFIG_FILE
2273 if not os.path.exists(config_file):
Jon Salz3ee59de2012-08-18 13:54:22 +08002274 # Just use an empty config file
Mike Frysinger7bfc89f2019-09-13 15:45:51 -04002275 config = configparser.RawConfigParser()
Shuhei Takahashi3cbb8dd2019-10-29 12:37:11 +09002276 else:
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002277 config.read(config_file)
Jon Salz3ee59de2012-08-18 13:54:22 +08002278
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002279 if presubmit:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07002280 hooks = _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002281 else:
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07002282 hooks = _PATCH_DESCRIPTION_HOOKS + _COMMON_HOOKS
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002283
Mike Frysinger3554bc92015-03-11 04:59:21 -04002284 enabled_hooks, disabled_hooks = _get_override_hooks(config)
Filipe Brandenburgerf70d32c2015-10-09 13:35:45 -07002285 hooks = [hook for hook in hooks if hook not in disabled_hooks]
2286
2287 # If a list is both in _COMMON_HOOKS and also enabled explicitly through an
2288 # override, keep the override only. Note that the override may end up being
2289 # a functools.partial, in which case we need to extract the .func to compare
2290 # it to the common hooks.
2291 unwrapped_hooks = [getattr(hook, 'func', hook) for hook in enabled_hooks]
2292 hooks = [hook for hook in hooks if hook not in unwrapped_hooks]
2293
2294 hooks = list(enabled_hooks) + hooks
Ryan Cui9b651632011-05-11 11:38:58 -07002295
2296 if project in _PROJECT_SPECIFIC_HOOKS:
Puneet Kumarc80e3f62012-08-13 19:01:18 -07002297 hooks.extend(hook for hook in _PROJECT_SPECIFIC_HOOKS[project]
2298 if hook not in disabled_hooks)
Ryan Cui9b651632011-05-11 11:38:58 -07002299
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002300 for name, script in _get_project_hook_scripts(config):
2301 func = functools.partial(_run_project_hook_script, script)
2302 func.__name__ = name
2303 hooks.append(func)
Jon Salz3ee59de2012-08-18 13:54:22 +08002304
Ryan Cui9b651632011-05-11 11:38:58 -07002305 return hooks
2306
2307
Alex Deymo643ac4c2015-09-03 10:40:50 -07002308def _run_project_hooks(project_name, proj_dir=None,
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002309 commit_list=None, presubmit=False,
2310 config_file=None):
Ryan Cui1562fb82011-05-09 11:01:31 -07002311 """For each project run its project specific hook from the hooks dictionary.
2312
2313 Args:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002314 project_name: The name of project to run hooks for.
Doug Anderson44a644f2011-11-02 10:37:37 -07002315 proj_dir: If non-None, this is the directory the project is in. If None,
2316 we'll ask repo.
Doug Anderson14749562013-06-26 13:38:29 -07002317 commit_list: A list of commits to run hooks against. If None or empty list
2318 then we'll automatically get the list of commits that would be uploaded.
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002319 presubmit: A Boolean, True if the check is run as a git pre-submit script.
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002320 config_file: A string, the presubmit config file. If not specified,
2321 defaults to PRESUBMIT.cfg in the project directory.
Ryan Cui1562fb82011-05-09 11:01:31 -07002322
2323 Returns:
2324 Boolean value of whether any errors were ecountered while running the hooks.
2325 """
Doug Anderson44a644f2011-11-02 10:37:37 -07002326 if proj_dir is None:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002327 proj_dirs = _run_command(
2328 ['repo', 'forall', project_name, '-c', 'pwd']).split()
Mike Frysingere52b1bc2019-09-16 23:45:41 -04002329 if not proj_dirs:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002330 print('%s cannot be found.' % project_name, file=sys.stderr)
David James2edd9002013-10-11 14:09:19 -07002331 print('Please specify a valid project.', file=sys.stderr)
2332 return True
2333 if len(proj_dirs) > 1:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002334 print('%s is associated with multiple directories.' % project_name,
David James2edd9002013-10-11 14:09:19 -07002335 file=sys.stderr)
2336 print('Please specify a directory to help disambiguate.', file=sys.stderr)
2337 return True
2338 proj_dir = proj_dirs[0]
Doug Anderson44a644f2011-11-02 10:37:37 -07002339
Ryan Cuiec4d6332011-05-02 14:15:25 -07002340 pwd = os.getcwd()
2341 # hooks assume they are run from the root of the project
2342 os.chdir(proj_dir)
2343
Mike Frysingered1b95a2019-12-12 19:04:51 -05002344 color = terminal.Color()
2345
Alex Deymo643ac4c2015-09-03 10:40:50 -07002346 remote_branch = _run_command(['git', 'rev-parse', '--abbrev-ref',
2347 '--symbolic-full-name', '@{u}']).strip()
2348 if not remote_branch:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002349 print("Your project %s doesn't track any remote repo." % project_name,
Alex Deymo643ac4c2015-09-03 10:40:50 -07002350 file=sys.stderr)
2351 remote = None
2352 else:
Josh Pratt15d13ab2018-08-13 11:52:48 +10002353 branch_items = remote_branch.split('/', 1)
2354 if len(branch_items) != 2:
2355 PrintErrorForProject(
2356 project_name,
2357 HookFailure(
2358 'Cannot get remote and branch name (%s)' % remote_branch))
2359 os.chdir(pwd)
2360 return True
2361 remote, _branch = branch_items
Alex Deymo643ac4c2015-09-03 10:40:50 -07002362
2363 project = Project(name=project_name, dir=proj_dir, remote=remote)
2364
Doug Anderson14749562013-06-26 13:38:29 -07002365 if not commit_list:
2366 try:
2367 commit_list = _get_commits()
2368 except VerifyException as e:
Alex Deymo643ac4c2015-09-03 10:40:50 -07002369 PrintErrorForProject(project.name, HookFailure(str(e)))
Doug Anderson14749562013-06-26 13:38:29 -07002370 os.chdir(pwd)
2371 return True
Ryan Cuifa55df52011-05-06 11:16:55 -07002372
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002373 hooks = _get_project_hooks(project.name, presubmit, config_file)
Ryan Cui1562fb82011-05-09 11:01:31 -07002374 error_found = False
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002375 commit_count = len(commit_list)
Mike Frysingerb99b3772019-08-17 14:19:44 -04002376 hook_count = len(hooks)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002377 for i, commit in enumerate(commit_list):
Mike Frysingerb2496652019-09-12 23:35:46 -04002378 CACHE.clear()
2379
LaMont Jones69d3e182020-03-11 15:00:53 -06002380 # If run with --pre-submit, then commit is PRE_SUBMIT, and not a commit.
2381 # Use that as the description.
2382 desc = commit if commit == PRE_SUBMIT else _get_commit_desc(commit)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002383 print('[%s %i/%i %s] %s' %
2384 (color.Color(color.CYAN, 'COMMIT'), i + 1, commit_count, commit[0:12],
2385 desc.splitlines()[0]))
2386
Mike Frysingerb99b3772019-08-17 14:19:44 -04002387 for h, hook in enumerate(hooks):
Mike Frysingered1b95a2019-12-12 19:04:51 -05002388 output = ('[%s %i/%i PRESUBMIT.cfg] %s' %
2389 (color.Color(color.YELLOW, 'RUNNING'), h + 1, hook_count,
2390 hook.__name__))
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002391 print(output, end='\r')
2392 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002393 hook_error = hook(project, commit)
Mike Frysingerb7d552e2017-11-23 11:50:47 -05002394 print(' ' * len(output), end='\r')
2395 sys.stdout.flush()
Ryan Cui1562fb82011-05-09 11:01:31 -07002396 if hook_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002397 if not isinstance(hook_error, list):
2398 hook_error = [hook_error]
2399 PrintErrorsForCommit(color, hook, project.name, hook_error)
Ryan Cui1562fb82011-05-09 11:01:31 -07002400 error_found = True
Don Garrettdba548a2011-05-05 15:17:14 -07002401
Ryan Cuiec4d6332011-05-02 14:15:25 -07002402 os.chdir(pwd)
Ryan Cui1562fb82011-05-09 11:01:31 -07002403 return error_found
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002404
Mike Frysingerae409522014-02-01 03:16:11 -05002405
Mandeep Singh Baines116ad102011-04-27 15:16:37 -07002406# Main
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002407
Ryan Cui1562fb82011-05-09 11:01:31 -07002408
Mike Frysingerae409522014-02-01 03:16:11 -05002409def main(project_list, worktree_list=None, **_kwargs):
Doug Anderson06456632012-01-05 11:02:14 -08002410 """Main function invoked directly by repo.
2411
2412 This function will exit directly upon error so that repo doesn't print some
2413 obscure error message.
2414
2415 Args:
2416 project_list: List of projects to run on.
David James2edd9002013-10-11 14:09:19 -07002417 worktree_list: A list of directories. It should be the same length as
2418 project_list, so that each entry in project_list matches with a directory
2419 in worktree_list. If None, we will attempt to calculate the directories
2420 automatically.
Doug Anderson06456632012-01-05 11:02:14 -08002421 kwargs: Leave this here for forward-compatibility.
2422 """
Mike Frysingered1b95a2019-12-12 19:04:51 -05002423 start_time = datetime.datetime.now()
Ryan Cui1562fb82011-05-09 11:01:31 -07002424 found_error = False
David James2edd9002013-10-11 14:09:19 -07002425 if not worktree_list:
2426 worktree_list = [None] * len(project_list)
2427 for project, worktree in zip(project_list, worktree_list):
2428 if _run_project_hooks(project, proj_dir=worktree):
Ryan Cui1562fb82011-05-09 11:01:31 -07002429 found_error = True
2430
Mike Frysingered1b95a2019-12-12 19:04:51 -05002431 end_time = datetime.datetime.now()
2432 color = terminal.Color()
Mike Frysingerae409522014-02-01 03:16:11 -05002433 if found_error:
Mike Frysingered1b95a2019-12-12 19:04:51 -05002434 msg = ('%s: Preupload failed due to above error(s).\n'
Ryan Cui9b651632011-05-11 11:38:58 -07002435 '- To disable some source style checks, and for other hints, see '
Mike Frysingered1b95a2019-12-12 19:04:51 -05002436 '<checkout_dir>/src/repohooks/README.md\n'
2437 "- To upload only current project, run 'repo upload .'" %
2438 (color.Color(color.RED, 'FATAL'),))
Mike Frysinger09d6a3d2013-10-08 22:21:03 -04002439 print(msg, file=sys.stderr)
Don Garrettdba548a2011-05-05 15:17:14 -07002440 sys.exit(1)
Mike Frysingered1b95a2019-12-12 19:04:51 -05002441 else:
2442 msg = ('[%s] repohooks passed in %s' %
2443 (color.Color(color.GREEN, 'PASSED'), end_time - start_time))
2444 print(msg)
Anush Elangovan63afad72011-03-23 00:41:27 -07002445
Ryan Cui1562fb82011-05-09 11:01:31 -07002446
Doug Anderson44a644f2011-11-02 10:37:37 -07002447def _identify_project(path):
2448 """Identify the repo project associated with the given path.
2449
2450 Returns:
2451 A string indicating what project is associated with the path passed in or
2452 a blank string upon failure.
2453 """
2454 return _run_command(['repo', 'forall', '.', '-c', 'echo ${REPO_PROJECT}'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002455 stderr=True, cwd=path).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002456
2457
Mike Frysinger55f85b52014-12-18 14:45:21 -05002458def direct_main(argv):
Doug Anderson44a644f2011-11-02 10:37:37 -07002459 """Run hooks directly (outside of the context of repo).
2460
Doug Anderson44a644f2011-11-02 10:37:37 -07002461 Args:
Mike Frysinger55f85b52014-12-18 14:45:21 -05002462 argv: The command line args to process
Doug Anderson44a644f2011-11-02 10:37:37 -07002463
2464 Returns:
2465 0 if no pre-upload failures, 1 if failures.
2466
2467 Raises:
2468 BadInvocation: On some types of invocation errors.
2469 """
Mike Frysinger66142932014-12-18 14:55:57 -05002470 parser = commandline.ArgumentParser(description=__doc__)
2471 parser.add_argument('--dir', default=None,
2472 help='The directory that the project lives in. If not '
2473 'specified, use the git project root based on the cwd.')
2474 parser.add_argument('--project', default=None,
2475 help='The project repo path; this can affect how the '
2476 'hooks get run, since some hooks are project-specific. '
2477 'For chromite this is chromiumos/chromite. If not '
2478 'specified, the repo tool will be used to figure this '
2479 'out based on the dir.')
2480 parser.add_argument('--rerun-since', default=None,
Vadim Bendebury75447b92018-01-10 12:06:01 -08002481 help='Rerun hooks on old commits since some point '
2482 'in the past. The argument could be a date (should '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002483 "match git log's concept of a date, e.g. 2012-06-20), "
Vadim Bendebury75447b92018-01-10 12:06:01 -08002484 'or a SHA1, or just a number of commits to check (from 1 '
2485 'to 99). This option is mutually exclusive with '
2486 '--pre-submit.')
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002487 parser.add_argument('--pre-submit', action='store_true',
Mike Frysinger66142932014-12-18 14:55:57 -05002488 help='Run the check against the pending commit. '
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002489 "This option should be used at the 'git commit' "
2490 "phase as opposed to 'repo upload'. This option "
Mike Frysinger66142932014-12-18 14:55:57 -05002491 'is mutually exclusive with --rerun-since.')
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002492 parser.add_argument('--presubmit-config',
2493 help='Specify presubmit config file to be used.')
Mike Frysinger66142932014-12-18 14:55:57 -05002494 parser.add_argument('commits', nargs='*',
2495 help='Check specific commits')
2496 opts = parser.parse_args(argv)
Doug Anderson44a644f2011-11-02 10:37:37 -07002497
Doug Anderson14749562013-06-26 13:38:29 -07002498 if opts.rerun_since:
Mike Frysinger66142932014-12-18 14:55:57 -05002499 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002500 raise BadInvocation("Can't pass commits and use rerun-since: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002501 ' '.join(opts.commits))
Doug Anderson14749562013-06-26 13:38:29 -07002502
Vadim Bendebury75447b92018-01-10 12:06:01 -08002503 if len(opts.rerun_since) < 3 and opts.rerun_since.isdigit():
2504 # This must be the number of commits to check. We don't expect the user
2505 # to want to check more than 99 commits.
2506 limit = '-n%s' % opts.rerun_since
2507 elif git.IsSHA1(opts.rerun_since, False):
2508 limit = '%s..' % opts.rerun_since
2509 else:
2510 # This better be a date.
2511 limit = '--since=%s' % opts.rerun_since
2512 cmd = ['git', 'log', limit, '--pretty=%H']
Doug Anderson14749562013-06-26 13:38:29 -07002513 all_commits = _run_command(cmd).splitlines()
2514 bot_commits = _run_command(cmd + ['--author=chrome-bot']).splitlines()
2515
2516 # Eliminate chrome-bot commits but keep ordering the same...
2517 bot_commits = set(bot_commits)
Mike Frysinger66142932014-12-18 14:55:57 -05002518 opts.commits = [c for c in all_commits if c not in bot_commits]
Doug Anderson14749562013-06-26 13:38:29 -07002519
Vadim Bendebury2b62d742014-06-22 13:14:51 -07002520 if opts.pre_submit:
2521 raise BadInvocation('rerun-since and pre-submit can not be '
2522 'used together')
2523 if opts.pre_submit:
Mike Frysinger66142932014-12-18 14:55:57 -05002524 if opts.commits:
Mike Frysinger24dd3c52019-08-17 14:22:48 -04002525 raise BadInvocation("Can't pass commits and use pre-submit: %s" %
Mike Frysinger66142932014-12-18 14:55:57 -05002526 ' '.join(opts.commits))
2527 opts.commits = [PRE_SUBMIT,]
Doug Anderson44a644f2011-11-02 10:37:37 -07002528
2529 # Check/normlaize git dir; if unspecified, we'll use the root of the git
2530 # project from CWD
2531 if opts.dir is None:
Mike Frysinger9ba001a2020-11-20 01:02:11 -05002532 git_dir = _run_command(['git', 'rev-parse', '--show-toplevel'],
Mike Frysinger7bb709f2019-09-29 23:20:12 -04002533 stderr=True).strip()
Doug Anderson44a644f2011-11-02 10:37:37 -07002534 if not git_dir:
2535 raise BadInvocation('The current directory is not part of a git project.')
Mike Frysinger9ba001a2020-11-20 01:02:11 -05002536 opts.dir = git_dir
Doug Anderson44a644f2011-11-02 10:37:37 -07002537 elif not os.path.isdir(opts.dir):
2538 raise BadInvocation('Invalid dir: %s' % opts.dir)
2539 elif not os.path.isdir(os.path.join(opts.dir, '.git')):
2540 raise BadInvocation('Not a git directory: %s' % opts.dir)
2541
2542 # Identify the project if it wasn't specified; this _requires_ the repo
2543 # tool to be installed and for the project to be part of a repo checkout.
2544 if not opts.project:
2545 opts.project = _identify_project(opts.dir)
2546 if not opts.project:
2547 raise BadInvocation("Repo couldn't identify the project of %s" % opts.dir)
2548
Doug Anderson14749562013-06-26 13:38:29 -07002549 found_error = _run_project_hooks(opts.project, proj_dir=opts.dir,
Mike Frysinger66142932014-12-18 14:55:57 -05002550 commit_list=opts.commits,
Sonny Sasaka5a905ea2020-07-24 15:30:12 -07002551 presubmit=opts.pre_submit,
2552 config_file=opts.presubmit_config)
Doug Anderson44a644f2011-11-02 10:37:37 -07002553 if found_error:
2554 return 1
2555 return 0
2556
2557
Mandeep Singh Baines69e470e2011-04-06 10:34:52 -07002558if __name__ == '__main__':
Mike Frysinger55f85b52014-12-18 14:45:21 -05002559 sys.exit(direct_main(sys.argv[1:]))