blob: 178e0e9883747ad225559cd1ee2c19ac27c42b41 [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00009__version__ = '1.8.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000010
11# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
12# caching (between all different invocations of presubmit scripts for a given
13# change). We should add it as our presubmit scripts start feeling slow.
14
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090015import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000016import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000017import cPickle # Exposed through the API.
18import cpplint
19import cStringIO # Exposed through the API.
dcheng091b7db2016-06-16 01:27:51 -070020import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000021import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000022import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000023import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000024import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000025import logging
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000026import marshal # Exposed through the API.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import optparse
29import os # Somewhat exposed through the API.
30import pickle # Exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000031import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040033import signal
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000034import sys # Parts exposed through API.
35import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040036import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000037import time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +000038import traceback # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000039import types
maruel@chromium.org1487d532009-06-06 00:22:57 +000040import unittest # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000041import urllib2 # Exposed through the API.
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000042import urlparse
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000043from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000044
45# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000046import fix_encoding
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000047import gclient_utils # Exposed through the API
Aaron Gableb584c4f2017-04-26 16:28:08 -070048import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000049import gerrit_util
dpranke@chromium.org2a009622011-03-01 02:43:31 +000050import owners
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020051import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000052import presubmit_canned_checks
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000053import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000054import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000055
56
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000057# Ask for feedback only once in program lifetime.
58_ASKED_FOR_FEEDBACK = False
59
60
maruel@chromium.org899e1c12011-04-07 17:03:18 +000061class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000062 pass
63
64
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000065class CommandData(object):
66 def __init__(self, name, cmd, kwargs, message):
67 self.name = name
68 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040069 self.stdin = kwargs.get('stdin', None)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000070 self.kwargs = kwargs
Edward Lesmes8e282792018-04-03 18:50:29 -040071 self.kwargs['stdout'] = subprocess.PIPE
72 self.kwargs['stderr'] = subprocess.STDOUT
73 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000074 self.message = message
75 self.info = None
76
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000077
Edward Lesmes8e282792018-04-03 18:50:29 -040078# Adapted from
79# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
80#
81# An object that catches SIGINT sent to the Python process and notices
82# if processes passed to wait() die by SIGINT (we need to look for
83# both of those cases, because pressing Ctrl+C can result in either
84# the main process or one of the subprocesses getting the signal).
85#
86# Before a SIGINT is seen, wait(p) will simply call p.wait() and
87# return the result. Once a SIGINT has been seen (in the main process
88# or a subprocess, including the one the current call is waiting for),
89# wait(p) will call p.terminate() and raise ProcessWasInterrupted.
90class SigintHandler(object):
91 class ProcessWasInterrupted(Exception):
92 pass
93
94 sigint_returncodes = {-signal.SIGINT, # Unix
95 -1073741510, # Windows
96 }
97 def __init__(self):
98 self.__lock = threading.Lock()
99 self.__processes = set()
100 self.__got_sigint = False
101 signal.signal(signal.SIGINT, lambda signal_num, frame: self.interrupt())
102
103 def __on_sigint(self):
104 self.__got_sigint = True
105 while self.__processes:
106 try:
107 self.__processes.pop().terminate()
108 except OSError:
109 pass
110
111 def interrupt(self):
112 with self.__lock:
113 self.__on_sigint()
114
115 def got_sigint(self):
116 with self.__lock:
117 return self.__got_sigint
118
119 def wait(self, p, stdin):
120 with self.__lock:
121 if self.__got_sigint:
122 p.terminate()
123 self.__processes.add(p)
124 stdout, stderr = p.communicate(stdin)
125 code = p.returncode
126 with self.__lock:
127 self.__processes.discard(p)
128 if code in self.sigint_returncodes:
129 self.__on_sigint()
130 if self.__got_sigint:
131 raise self.ProcessWasInterrupted
132 return stdout, stderr
133
134sigint_handler = SigintHandler()
135
136
137class ThreadPool(object):
138 def __init__(self, pool_size=None):
139 self._pool_size = pool_size or multiprocessing.cpu_count()
140 self._messages = []
141 self._messages_lock = threading.Lock()
142 self._tests = []
143 self._tests_lock = threading.Lock()
144 self._nonparallel_tests = []
145
146 def CallCommand(self, test):
147 """Runs an external program.
148
149 This function converts invocation of .py files and invocations of "python"
150 to vpython invocations.
151 """
152 vpython = 'vpython.bat' if sys.platform == 'win32' else 'vpython'
153
154 cmd = test.cmd
155 if cmd[0] == 'python':
156 cmd = list(cmd)
157 cmd[0] = vpython
158 elif cmd[0].endswith('.py'):
159 cmd = [vpython] + cmd
160
161 try:
162 start = time.time()
163 p = subprocess.Popen(cmd, **test.kwargs)
164 stdout, _ = sigint_handler.wait(p, test.stdin)
165 duration = time.time() - start
166 except OSError as e:
167 duration = time.time() - start
168 return test.message(
169 '%s exec failure (%4.2fs)\n %s' % (test.name, duration, e))
170 if p.returncode != 0:
171 return test.message(
172 '%s (%4.2fs) failed\n%s' % (test.name, duration, stdout))
173 if test.info:
174 return test.info('%s (%4.2fs)' % (test.name, duration))
175
176 def AddTests(self, tests, parallel=True):
177 if parallel:
178 self._tests.extend(tests)
179 else:
180 self._nonparallel_tests.extend(tests)
181
182 def RunAsync(self):
183 self._messages = []
184
185 def _WorkerFn():
186 while True:
187 test = None
188 with self._tests_lock:
189 if not self._tests:
190 break
191 test = self._tests.pop()
192 result = self.CallCommand(test)
193 if result:
194 with self._messages_lock:
195 self._messages.append(result)
196
197 def _StartDaemon():
198 t = threading.Thread(target=_WorkerFn)
199 t.daemon = True
200 t.start()
201 return t
202
203 while self._nonparallel_tests:
204 test = self._nonparallel_tests.pop()
205 result = self.CallCommand(test)
206 if result:
207 self._messages.append(result)
208
209 if self._tests:
210 threads = [_StartDaemon() for _ in range(self._pool_size)]
211 for worker in threads:
212 worker.join()
213
214 return self._messages
215
216
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000217def normpath(path):
218 '''Version of os.path.normpath that also changes backward slashes to
219 forward slashes when not running on Windows.
220 '''
221 # This is safe to always do because the Windows version of os.path.normpath
222 # will replace forward slashes with backward slashes.
223 path = path.replace(os.sep, '/')
224 return os.path.normpath(path)
225
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000226
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000227def _RightHandSideLinesImpl(affected_files):
228 """Implements RightHandSideLines for InputApi and GclChange."""
229 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000230 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000231 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000232 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000233
234
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000235class PresubmitOutput(object):
236 def __init__(self, input_stream=None, output_stream=None):
237 self.input_stream = input_stream
238 self.output_stream = output_stream
239 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -0800240 self.more_cc = []
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000241 self.written_output = []
242 self.error_count = 0
243
244 def prompt_yes_no(self, prompt_string):
245 self.write(prompt_string)
246 if self.input_stream:
247 response = self.input_stream.readline().strip().lower()
248 if response not in ('y', 'yes'):
249 self.fail()
250 else:
251 self.fail()
252
253 def fail(self):
254 self.error_count += 1
255
256 def should_continue(self):
257 return not self.error_count
258
259 def write(self, s):
260 self.written_output.append(s)
261 if self.output_stream:
262 self.output_stream.write(s)
263
264 def getvalue(self):
265 return ''.join(self.written_output)
266
267
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000268# Top level object so multiprocessing can pickle
269# Public access through OutputApi object.
270class _PresubmitResult(object):
271 """Base class for result objects."""
272 fatal = False
273 should_prompt = False
274
275 def __init__(self, message, items=None, long_text=''):
276 """
277 message: A short one-line message to indicate errors.
278 items: A list of short strings to indicate where errors occurred.
279 long_text: multi-line text output, e.g. from another tool
280 """
281 self._message = message
282 self._items = items or []
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000283 self._long_text = long_text.rstrip()
284
285 def handle(self, output):
286 output.write(self._message)
287 output.write('\n')
288 for index, item in enumerate(self._items):
289 output.write(' ')
290 # Write separately in case it's unicode.
291 output.write(str(item))
292 if index < len(self._items) - 1:
293 output.write(' \\')
294 output.write('\n')
295 if self._long_text:
296 output.write('\n***************\n')
297 # Write separately in case it's unicode.
298 output.write(self._long_text)
299 output.write('\n***************\n')
300 if self.fatal:
301 output.fail()
302
303
304# Top level object so multiprocessing can pickle
305# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000306class _PresubmitError(_PresubmitResult):
307 """A hard presubmit error."""
308 fatal = True
309
310
311# Top level object so multiprocessing can pickle
312# Public access through OutputApi object.
313class _PresubmitPromptWarning(_PresubmitResult):
314 """An warning that prompts the user if they want to continue."""
315 should_prompt = True
316
317
318# Top level object so multiprocessing can pickle
319# Public access through OutputApi object.
320class _PresubmitNotifyResult(_PresubmitResult):
321 """Just print something to the screen -- but it's not even a warning."""
322 pass
323
324
325# Top level object so multiprocessing can pickle
326# Public access through OutputApi object.
327class _MailTextResult(_PresubmitResult):
328 """A warning that should be included in the review request email."""
329 def __init__(self, *args, **kwargs):
330 super(_MailTextResult, self).__init__()
331 raise NotImplementedError()
332
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000333class GerritAccessor(object):
334 """Limited Gerrit functionality for canned presubmit checks to work.
335
336 To avoid excessive Gerrit calls, caches the results.
337 """
338
339 def __init__(self, host):
340 self.host = host
341 self.cache = {}
342
343 def _FetchChangeDetail(self, issue):
344 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100345 try:
346 return gerrit_util.GetChangeDetail(
347 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700348 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100349 except gerrit_util.GerritError as e:
350 if e.http_status == 404:
351 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
352 'no credentials to fetch issue details' % issue)
353 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000354
355 def GetChangeInfo(self, issue):
356 """Returns labels and all revisions (patchsets) for this issue.
357
358 The result is a dictionary according to Gerrit REST Api.
359 https://gerrit-review.googlesource.com/Documentation/rest-api.html
360
361 However, API isn't very clear what's inside, so see tests for example.
362 """
363 assert issue
364 cache_key = int(issue)
365 if cache_key not in self.cache:
366 self.cache[cache_key] = self._FetchChangeDetail(issue)
367 return self.cache[cache_key]
368
369 def GetChangeDescription(self, issue, patchset=None):
370 """If patchset is none, fetches current patchset."""
371 info = self.GetChangeInfo(issue)
372 # info is a reference to cache. We'll modify it here adding description to
373 # it to the right patchset, if it is not yet there.
374
375 # Find revision info for the patchset we want.
376 if patchset is not None:
377 for rev, rev_info in info['revisions'].iteritems():
378 if str(rev_info['_number']) == str(patchset):
379 break
380 else:
381 raise Exception('patchset %s doesn\'t exist in issue %s' % (
382 patchset, issue))
383 else:
384 rev = info['current_revision']
385 rev_info = info['revisions'][rev]
386
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100387 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000388
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800389 def GetDestRef(self, issue):
390 ref = self.GetChangeInfo(issue)['branch']
391 if not ref.startswith('refs/'):
392 # NOTE: it is possible to create 'refs/x' branch,
393 # aka 'refs/heads/refs/x'. However, this is ill-advised.
394 ref = 'refs/heads/%s' % ref
395 return ref
396
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000397 def GetChangeOwner(self, issue):
398 return self.GetChangeInfo(issue)['owner']['email']
399
400 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700401 changeinfo = self.GetChangeInfo(issue)
402 if approving_only:
403 labelinfo = changeinfo.get('labels', {}).get('Code-Review', {})
404 values = labelinfo.get('values', {}).keys()
405 try:
406 max_value = max(int(v) for v in values)
407 reviewers = [r for r in labelinfo.get('all', [])
408 if r.get('value', 0) == max_value]
409 except ValueError: # values is the empty list
410 reviewers = []
411 else:
412 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
413 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000414
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000415
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000416class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000417 """An instance of OutputApi gets passed to presubmit scripts so that they
418 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000419 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000420 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000421 PresubmitError = _PresubmitError
422 PresubmitPromptWarning = _PresubmitPromptWarning
423 PresubmitNotifyResult = _PresubmitNotifyResult
424 MailTextResult = _MailTextResult
425
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000426 def __init__(self, is_committing):
427 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800428 self.more_cc = []
429
430 def AppendCC(self, cc):
431 """Appends a user to cc for this change."""
432 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000433
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000434 def PresubmitPromptOrNotify(self, *args, **kwargs):
435 """Warn the user when uploading, but only notify if committing."""
436 if self.is_committing:
437 return self.PresubmitNotifyResult(*args, **kwargs)
438 return self.PresubmitPromptWarning(*args, **kwargs)
439
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000440
441class InputApi(object):
442 """An instance of this object is passed to presubmit scripts so they can
443 know stuff about the change they're looking at.
444 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000445 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800446 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000447
maruel@chromium.org3410d912009-06-09 20:56:16 +0000448 # File extensions that are considered source files from a style guide
449 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000450 #
451 # Files without an extension aren't included in the list. If you want to
452 # filter them as source files, add r"(^|.*?[\\\/])[^.]+$" to the white list.
453 # Note that ALL CAPS files are black listed in DEFAULT_BLACK_LIST below.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000454 DEFAULT_WHITE_LIST = (
455 # C++ and friends
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000456 r".+\.c$", r".+\.cc$", r".+\.cpp$", r".+\.h$", r".+\.m$", r".+\.mm$",
457 r".+\.inl$", r".+\.asm$", r".+\.hxx$", r".+\.hpp$", r".+\.s$", r".+\.S$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000458 # Scripts
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000459 r".+\.js$", r".+\.py$", r".+\.sh$", r".+\.rb$", r".+\.pl$", r".+\.pm$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000460 # Other
Sergey Ulanov166bc4c2018-04-30 17:03:38 -0700461 r".+\.java$", r".+\.mk$", r".+\.am$", r".+\.css$", r".+\.mojom$",
462 r".+\.fidl$"
maruel@chromium.org3410d912009-06-09 20:56:16 +0000463 )
464
465 # Path regexp that should be excluded from being considered containing source
466 # files. Don't modify this list from a presubmit script!
467 DEFAULT_BLACK_LIST = (
gavinp@chromium.org656326d2012-08-13 00:43:57 +0000468 r"testing_support[\\\/]google_appengine[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000469 r".*\bexperimental[\\\/].*",
Kent Tamura179dd1e2018-04-26 15:07:41 +0900470 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
471 # (crbug.com/539768 and crbug.com/836555).
472 r".*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000473 # Output directories (just in case)
474 r".*\bDebug[\\\/].*",
475 r".*\bRelease[\\\/].*",
476 r".*\bxcodebuild[\\\/].*",
thakis@chromium.orgc1c96352013-10-09 19:50:27 +0000477 r".*\bout[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000478 # All caps files like README and LICENCE.
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000479 r".*\b[A-Z0-9_]{2,}$",
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000480 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
maruel@chromium.org5d0dc432011-01-03 02:40:37 +0000481 r"(|.*[\\\/])\.git[\\\/].*",
482 r"(|.*[\\\/])\.svn[\\\/].*",
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000483 # There is no point in processing a patch file.
484 r".+\.diff$",
485 r".+\.patch$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000486 )
487
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000488 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400489 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000490 """Builds an InputApi object.
491
492 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000493 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000494 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000495 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000496 gerrit_obj: provides basic Gerrit codereview functionality.
497 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400498 parallel: if true, all tests reported via input_api.RunTests for all
499 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000500 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000501 # Version number of the presubmit_support script.
502 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000503 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000504 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000505 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000506 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000507
Edward Lesmes8e282792018-04-03 18:50:29 -0400508 self.parallel = parallel
509 self.thread_pool = thread_pool or ThreadPool()
510
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000511 # We expose various modules and functions as attributes of the input_api
512 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900513 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000514 self.basename = os.path.basename
515 self.cPickle = cPickle
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000516 self.cpplint = cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000517 self.cStringIO = cStringIO
dcheng091b7db2016-06-16 01:27:51 -0700518 self.fnmatch = fnmatch
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000519 self.gclient_utils = gclient_utils
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000520 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000521 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000522 self.logging = logging.getLogger('PRESUBMIT')
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000523 self.marshal = marshal
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000524 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000525 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000526 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000527 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000528 self.pickle = pickle
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000529 self.re = re
530 self.subprocess = subprocess
531 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000532 self.time = time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000533 self.traceback = traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +0000534 self.unittest = unittest
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000535 self.urllib2 = urllib2
536
Robert Iannucci50258932018-03-19 10:30:59 -0700537 self.is_windows = sys.platform == 'win32'
538
539 # Set python_executable to 'python'. This is interpreted in CallCommand to
540 # convert to vpython in order to allow scripts in other repos (e.g. src.git)
541 # to automatically pick up that repo's .vpython file, instead of inheriting
542 # the one in depot_tools.
543 self.python_executable = 'python'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000544 self.environ = os.environ
545
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000546 # InputApi.platform is the platform you're currently running on.
547 self.platform = sys.platform
548
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000549 self.cpu_count = multiprocessing.cpu_count()
550
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000551 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000552 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000553
554 # We carry the canned checks so presubmit scripts can easily use them.
555 self.canned_checks = presubmit_canned_checks
556
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100557 # Temporary files we must manually remove at the end of a run.
558 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200559
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000560 # TODO(dpranke): figure out a list of all approved owners for a repo
561 # in order to be able to handle wildcard OWNERS files?
562 self.owners_db = owners.Database(change.RepositoryRoot(),
Jochen Eisinger72606f82017-04-04 10:44:18 +0200563 fopen=file, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200564 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000565 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000566 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000567
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000568 # Replace <hash_map> and <hash_set> as headers that need to be included
danakj@chromium.org18278522013-06-11 22:42:32 +0000569 # with "base/containers/hash_tables.h" instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000570 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800571 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000572 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000573 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000574 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
575 for (a, b, header) in cpplint._re_pattern_templates
576 ]
577
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000578 def PresubmitLocalPath(self):
579 """Returns the local path of the presubmit script currently being run.
580
581 This is useful if you don't want to hard-code absolute paths in the
582 presubmit script. For example, It can be used to find another file
583 relative to the PRESUBMIT.py script, so the whole tree can be branched and
584 the presubmit script still works, without editing its content.
585 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000586 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000587
agable0b65e732016-11-22 09:25:46 -0800588 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000589 """Same as input_api.change.AffectedFiles() except only lists files
590 (and optionally directories) in the same directory as the current presubmit
591 script, or subdirectories thereof.
592 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000593 dir_with_slash = normpath("%s/" % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000594 if len(dir_with_slash) == 1:
595 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000596
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000597 return filter(
598 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
agable0b65e732016-11-22 09:25:46 -0800599 self.change.AffectedFiles(include_deletes, file_filter))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000600
agable0b65e732016-11-22 09:25:46 -0800601 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000602 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800603 paths = [af.LocalPath() for af in self.AffectedFiles()]
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000604 logging.debug("LocalPaths: %s", paths)
605 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000606
agable0b65e732016-11-22 09:25:46 -0800607 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000608 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800609 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000610
John Budorick16162372018-04-18 10:39:53 -0700611 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800612 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000613 in the same directory as the current presubmit script, or subdirectories
614 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000615 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000616 if include_deletes is not None:
agable0b65e732016-11-22 09:25:46 -0800617 warn("AffectedTestableFiles(include_deletes=%s)"
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000618 " is deprecated and ignored" % str(include_deletes),
619 category=DeprecationWarning,
620 stacklevel=2)
agable0b65e732016-11-22 09:25:46 -0800621 return filter(lambda x: x.IsTestableFile(),
John Budorick16162372018-04-18 10:39:53 -0700622 self.AffectedFiles(include_deletes=False, **kwargs))
agable0b65e732016-11-22 09:25:46 -0800623
624 def AffectedTextFiles(self, include_deletes=None):
625 """An alias to AffectedTestableFiles for backwards compatibility."""
626 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000627
maruel@chromium.org3410d912009-06-09 20:56:16 +0000628 def FilterSourceFile(self, affected_file, white_list=None, black_list=None):
629 """Filters out files that aren't considered "source file".
630
631 If white_list or black_list is None, InputApi.DEFAULT_WHITE_LIST
632 and InputApi.DEFAULT_BLACK_LIST is used respectively.
633
634 The lists will be compiled as regular expression and
635 AffectedFile.LocalPath() needs to pass both list.
636
637 Note: Copy-paste this function to suit your needs or use a lambda function.
638 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000639 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000640 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000641 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000642 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000643 return True
644 return False
645 return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and
646 not Find(affected_file, black_list or self.DEFAULT_BLACK_LIST))
647
648 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800649 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000650
651 If source_file is None, InputApi.FilterSourceFile() is used.
652 """
653 if not source_file:
654 source_file = self.FilterSourceFile
agable0b65e732016-11-22 09:25:46 -0800655 return filter(source_file, self.AffectedTestableFiles())
maruel@chromium.org3410d912009-06-09 20:56:16 +0000656
657 def RightHandSideLines(self, source_file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000658 """An iterator over all text lines in "new" version of changed files.
659
660 Only lists lines from new or modified text files in the change that are
661 contained by the directory of the currently executing presubmit script.
662
663 This is useful for doing line-by-line regex checks, like checking for
664 trailing whitespace.
665
666 Yields:
667 a 3 tuple:
668 the AffectedFile instance of the current file;
669 integer line number (1-based); and
670 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000671
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000672 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000673 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000674 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000675 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000676
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000677 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000678 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000679
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000680 Deny reading anything outside the repository.
681 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000682 if isinstance(file_item, AffectedFile):
683 file_item = file_item.AbsoluteLocalPath()
684 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000685 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000686 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000687
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100688 def CreateTemporaryFile(self, **kwargs):
689 """Returns a named temporary file that must be removed with a call to
690 RemoveTemporaryFiles().
691
692 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
693 except for |delete|, which is always set to False.
694
695 Presubmit checks that need to create a temporary file and pass it for
696 reading should use this function instead of NamedTemporaryFile(), as
697 Windows fails to open a file that is already open for writing.
698
699 with input_api.CreateTemporaryFile() as f:
700 f.write('xyz')
701 f.close()
702 input_api.subprocess.check_output(['script-that', '--reads-from',
703 f.name])
704
705
706 Note that callers of CreateTemporaryFile() should not worry about removing
707 any temporary file; this is done transparently by the presubmit handling
708 code.
709 """
710 if 'delete' in kwargs:
711 # Prevent users from passing |delete|; we take care of file deletion
712 # ourselves and this prevents unintuitive error messages when we pass
713 # delete=False and 'delete' is also in kwargs.
714 raise TypeError('CreateTemporaryFile() does not take a "delete" '
715 'argument, file deletion is handled automatically by '
716 'the same presubmit_support code that creates InputApi '
717 'objects.')
718 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
719 self._named_temporary_files.append(temp_file.name)
720 return temp_file
721
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000722 @property
723 def tbr(self):
724 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400725 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000726
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000727 def RunTests(self, tests_mix, parallel=True):
Edward Lesmes8e282792018-04-03 18:50:29 -0400728 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
729 # will run all tests once all PRESUBMIT files are processed.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000730 tests = []
731 msgs = []
Edward Lemur7e3c67f2018-07-20 20:52:49 +0000732 parallel = parallel and self.parallel
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000733 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400734 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000735 msgs.append(t)
736 else:
737 assert issubclass(t.message, _PresubmitResult)
738 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000739 if self.verbose:
740 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400741 if not t.kwargs.get('cwd'):
742 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400743 self.thread_pool.AddTests(tests, parallel)
Edward Lemur7e3c67f2018-07-20 20:52:49 +0000744 if not parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400745 msgs.extend(self.thread_pool.RunAsync())
746 return msgs
scottmg86099d72016-09-01 09:16:51 -0700747
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000748
nick@chromium.orgff526192013-06-10 19:30:26 +0000749class _DiffCache(object):
750 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000751 def __init__(self, upstream=None):
752 """Stores the upstream revision against which all diffs will be computed."""
753 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000754
755 def GetDiff(self, path, local_root):
756 """Get the diff for a particular path."""
757 raise NotImplementedError()
758
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700759 def GetOldContents(self, path, local_root):
760 """Get the old version for a particular path."""
761 raise NotImplementedError()
762
nick@chromium.orgff526192013-06-10 19:30:26 +0000763
nick@chromium.orgff526192013-06-10 19:30:26 +0000764class _GitDiffCache(_DiffCache):
765 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000766 def __init__(self, upstream):
767 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000768 self._diffs_by_file = None
769
770 def GetDiff(self, path, local_root):
771 if not self._diffs_by_file:
772 # Compute a single diff for all files and parse the output; should
773 # with git this is much faster than computing one diff for each file.
774 diffs = {}
775
776 # Don't specify any filenames below, because there are command line length
777 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000778 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
779 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000780
781 # This regex matches the path twice, separated by a space. Note that
782 # filename itself may contain spaces.
783 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
784 current_diff = []
785 keep_line_endings = True
786 for x in unified_diff.splitlines(keep_line_endings):
787 match = file_marker.match(x)
788 if match:
789 # Marks the start of a new per-file section.
790 diffs[match.group('filename')] = current_diff = [x]
791 elif x.startswith('diff --git'):
792 raise PresubmitFailure('Unexpected diff line: %s' % x)
793 else:
794 current_diff.append(x)
795
796 self._diffs_by_file = dict(
797 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
798
799 if path not in self._diffs_by_file:
800 raise PresubmitFailure(
801 'Unified diff did not contain entry for file %s' % path)
802
803 return self._diffs_by_file[path]
804
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700805 def GetOldContents(self, path, local_root):
806 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
807
nick@chromium.orgff526192013-06-10 19:30:26 +0000808
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000809class AffectedFile(object):
810 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000811
812 DIFF_CACHE = _DiffCache
813
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000814 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800815 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000816 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000817 self._path = path
818 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000819 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000820 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000821 self._cached_changed_contents = None
822 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000823 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700824 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000825
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000826 def LocalPath(self):
827 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400828
829 This should be used for error messages but not for accessing files,
830 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
831 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000832 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000833 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000834
835 def AbsoluteLocalPath(self):
836 """Returns the absolute path of this file on the local disk.
837 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000838 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000839
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000840 def Action(self):
841 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000842 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000843
agable0b65e732016-11-22 09:25:46 -0800844 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000845 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000846
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000847 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000848 raise NotImplementedError() # Implement when needed
849
agable0b65e732016-11-22 09:25:46 -0800850 def IsTextFile(self):
851 """An alias to IsTestableFile for backwards compatibility."""
852 return self.IsTestableFile()
853
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700854 def OldContents(self):
855 """Returns an iterator over the lines in the old version of file.
856
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700857 The old version is the file before any modifications in the user's
858 workspace, i.e. the "left hand side".
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700859
860 Contents will be empty if the file is a directory or does not exist.
861 Note: The carriage returns (LF or CR) are stripped off.
862 """
863 return self._diff_cache.GetOldContents(self.LocalPath(),
864 self._local_root).splitlines()
865
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000866 def NewContents(self):
867 """Returns an iterator over the lines in the new version of file.
868
869 The new version is the file in the user's workspace, i.e. the "right hand
870 side".
871
872 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000873 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000874 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000875 if self._cached_new_contents is None:
876 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -0800877 try:
878 self._cached_new_contents = gclient_utils.FileRead(
879 self.AbsoluteLocalPath(), 'rU').splitlines()
880 except IOError:
881 pass # File not found? That's fine; maybe it was deleted.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000882 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000883
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000884 def ChangedContents(self):
885 """Returns a list of tuples (line number, line text) of all new lines.
886
887 This relies on the scm diff output describing each changed code section
888 with a line of the form
889
890 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
891 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000892 if self._cached_changed_contents is not None:
893 return self._cached_changed_contents[:]
894 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000895 line_num = 0
896
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000897 for line in self.GenerateScmDiff().splitlines():
898 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
899 if m:
900 line_num = int(m.groups(1)[0])
901 continue
902 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000903 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000904 if not line.startswith('-'):
905 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000906 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000907
maruel@chromium.org5de13972009-06-10 18:16:06 +0000908 def __str__(self):
909 return self.LocalPath()
910
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000911 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +0000912 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000913
maruel@chromium.org58407af2011-04-12 23:15:57 +0000914
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000915class GitAffectedFile(AffectedFile):
916 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000917 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800918 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000919
nick@chromium.orgff526192013-06-10 19:30:26 +0000920 DIFF_CACHE = _GitDiffCache
921
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000922 def __init__(self, *args, **kwargs):
923 AffectedFile.__init__(self, *args, **kwargs)
924 self._server_path = None
agable0b65e732016-11-22 09:25:46 -0800925 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000926
agable0b65e732016-11-22 09:25:46 -0800927 def IsTestableFile(self):
928 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000929 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -0800930 # A deleted file is not testable.
931 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000932 else:
agable0b65e732016-11-22 09:25:46 -0800933 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
934 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000935
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000936
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000937class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000938 """Describe a change.
939
940 Used directly by the presubmit scripts to query the current change being
941 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000942
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000943 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +0000944 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000945 self.KEY: equivalent to tags['KEY']
946 """
947
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000948 _AFFECTED_FILES = AffectedFile
949
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000950 # Matches key/value (or "tag") lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +0000951 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +0000952 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000953 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000954
maruel@chromium.org58407af2011-04-12 23:15:57 +0000955 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000956 self, name, description, local_root, files, issue, patchset, author,
957 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000958 if files is None:
959 files = []
960 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +0000961 # Convert root into an absolute path.
962 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000963 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000964 self.issue = issue
965 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +0000966 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000967
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000968 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000969 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000970 self._description_without_tags = ''
971 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000972
maruel@chromium.orge085d812011-10-10 19:49:15 +0000973 assert all(
974 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
975
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000976 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000977 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +0000978 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
979 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000980 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000981
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000982 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000983 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000984 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000985
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000986 def DescriptionText(self):
987 """Returns the user-entered changelist description, minus tags.
988
989 Any line in the user-provided description starting with e.g. "FOO="
990 (whitespace permitted before and around) is considered a tag line. Such
991 lines are stripped out of the description this function returns.
992 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000993 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000994
995 def FullDescriptionText(self):
996 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000997 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000998
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000999 def SetDescriptionText(self, description):
1000 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001001
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001002 Also updates the list of tags."""
1003 self._full_description = description
1004
1005 # From the description text, build up a dictionary of key/value pairs
1006 # plus the description minus all key/value or "tag" lines.
1007 description_without_tags = []
1008 self.tags = {}
1009 for line in self._full_description.splitlines():
1010 m = self.TAG_LINE_RE.match(line)
1011 if m:
1012 self.tags[m.group('key')] = m.group('value')
1013 else:
1014 description_without_tags.append(line)
1015
1016 # Change back to text and remove whitespace at end.
1017 self._description_without_tags = (
1018 '\n'.join(description_without_tags).rstrip())
1019
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001020 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001021 """Returns the repository (checkout) root directory for this change,
1022 as an absolute path.
1023 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001024 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001025
1026 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001027 """Return tags directly as attributes on the object."""
1028 if not re.match(r"^[A-Z_]*$", attr):
1029 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001030 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001031
Aaron Gablefc03e672017-05-15 14:09:42 -07001032 def BugsFromDescription(self):
1033 """Returns all bugs referenced in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001034 tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()]
1035 footers = git_footers.parse_footers(self._full_description).get('Bug', [])
1036 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001037
1038 def ReviewersFromDescription(self):
1039 """Returns all reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001040 # We don't support a "R:" git-footer for reviewers; that is in metadata.
1041 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1042 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001043
1044 def TBRsFromDescription(self):
1045 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001046 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
1047 # TODO(agable): Remove support for 'Tbr:' when TBRs are programmatically
1048 # determined by self-CR+1s.
1049 footers = git_footers.parse_footers(self._full_description).get('Tbr', [])
1050 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001051
1052 # TODO(agable): Delete these once we're sure they're unused.
1053 @property
1054 def BUG(self):
1055 return ','.join(self.BugsFromDescription())
1056 @property
1057 def R(self):
1058 return ','.join(self.ReviewersFromDescription())
1059 @property
1060 def TBR(self):
1061 return ','.join(self.TBRsFromDescription())
1062
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001063 def AllFiles(self, root=None):
1064 """List all files under source control in the repo."""
1065 raise NotImplementedError()
1066
agable0b65e732016-11-22 09:25:46 -08001067 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001068 """Returns a list of AffectedFile instances for all files in the change.
1069
1070 Args:
1071 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001072 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001073
1074 Returns:
1075 [AffectedFile(path, action), AffectedFile(path, action)]
1076 """
agable0b65e732016-11-22 09:25:46 -08001077 affected = filter(file_filter, self._affected_files)
sail@chromium.org5538e022011-05-12 17:53:16 +00001078
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001079 if include_deletes:
1080 return affected
Lei Zhang9611c4c2017-04-04 01:41:56 -07001081 return filter(lambda x: x.Action() != 'D', affected)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001082
John Budorick16162372018-04-18 10:39:53 -07001083 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001084 """Return a list of the existing text files in a change."""
1085 if include_deletes is not None:
agable0b65e732016-11-22 09:25:46 -08001086 warn("AffectedTeestableFiles(include_deletes=%s)"
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001087 " is deprecated and ignored" % str(include_deletes),
1088 category=DeprecationWarning,
1089 stacklevel=2)
agable0b65e732016-11-22 09:25:46 -08001090 return filter(lambda x: x.IsTestableFile(),
John Budorick16162372018-04-18 10:39:53 -07001091 self.AffectedFiles(include_deletes=False, **kwargs))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001092
agable0b65e732016-11-22 09:25:46 -08001093 def AffectedTextFiles(self, include_deletes=None):
1094 """An alias to AffectedTestableFiles for backwards compatibility."""
1095 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001096
agable0b65e732016-11-22 09:25:46 -08001097 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001098 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001099 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001100
agable0b65e732016-11-22 09:25:46 -08001101 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001102 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001103 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001104
1105 def RightHandSideLines(self):
1106 """An iterator over all text lines in "new" version of changed files.
1107
1108 Lists lines from new or modified text files in the change.
1109
1110 This is useful for doing line-by-line regex checks, like checking for
1111 trailing whitespace.
1112
1113 Yields:
1114 a 3 tuple:
1115 the AffectedFile instance of the current file;
1116 integer line number (1-based); and
1117 the contents of the line as a string.
1118 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001119 return _RightHandSideLinesImpl(
1120 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001121 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001122
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001123 def OriginalOwnersFiles(self):
1124 """A map from path names of affected OWNERS files to their old content."""
1125 def owners_file_filter(f):
1126 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1127 files = self.AffectedFiles(file_filter=owners_file_filter)
1128 return dict([(f.LocalPath(), f.OldContents()) for f in files])
1129
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001130
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001131class GitChange(Change):
1132 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001133 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001134
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001135 def AllFiles(self, root=None):
1136 """List all files under source control in the repo."""
1137 root = root or self.RepositoryRoot()
1138 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001139 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1140 cwd=root).splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001141
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001142
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001143def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001144 """Finds all presubmit files that apply to a given set of source files.
1145
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001146 If inherit-review-settings-ok is present right under root, looks for
1147 PRESUBMIT.py in directories enclosing root.
1148
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001149 Args:
1150 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001151 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001152
1153 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001154 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001155 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001156 files = [normpath(os.path.join(root, f)) for f in files]
1157
1158 # List all the individual directories containing files.
1159 directories = set([os.path.dirname(f) for f in files])
1160
1161 # Ignore root if inherit-review-settings-ok is present.
1162 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1163 root = None
1164
1165 # Collect all unique directories that may contain PRESUBMIT.py.
1166 candidates = set()
1167 for directory in directories:
1168 while True:
1169 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001170 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001171 candidates.add(directory)
1172 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001173 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001174 parent_dir = os.path.dirname(directory)
1175 if parent_dir == directory:
1176 # We hit the system root directory.
1177 break
1178 directory = parent_dir
1179
1180 # Look for PRESUBMIT.py in all candidate directories.
1181 results = []
1182 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001183 try:
1184 for f in os.listdir(directory):
1185 p = os.path.join(directory, f)
1186 if os.path.isfile(p) and re.match(
1187 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1188 results.append(p)
1189 except OSError:
1190 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001191
tobiasjs2836bcf2016-08-16 04:08:16 -07001192 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001193 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001194
1195
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001196class GetTryMastersExecuter(object):
1197 @staticmethod
1198 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1199 """Executes GetPreferredTryMasters() from a single presubmit script.
1200
1201 Args:
1202 script_text: The text of the presubmit script.
1203 presubmit_path: Project script to run.
1204 project: Project name to pass to presubmit script for bot selection.
1205
1206 Return:
1207 A map of try masters to map of builders to set of tests.
1208 """
1209 context = {}
1210 try:
1211 exec script_text in context
1212 except Exception, e:
1213 raise PresubmitFailure('"%s" had an exception.\n%s'
1214 % (presubmit_path, e))
1215
1216 function_name = 'GetPreferredTryMasters'
1217 if function_name not in context:
1218 return {}
1219 get_preferred_try_masters = context[function_name]
1220 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1221 raise PresubmitFailure(
1222 'Expected function "GetPreferredTryMasters" to take two arguments.')
1223 return get_preferred_try_masters(project, change)
1224
1225
rmistry@google.com5626a922015-02-26 14:03:30 +00001226class GetPostUploadExecuter(object):
1227 @staticmethod
1228 def ExecPresubmitScript(script_text, presubmit_path, cl, change):
1229 """Executes PostUploadHook() from a single presubmit script.
1230
1231 Args:
1232 script_text: The text of the presubmit script.
1233 presubmit_path: Project script to run.
1234 cl: The Changelist object.
1235 change: The Change object.
1236
1237 Return:
1238 A list of results objects.
1239 """
1240 context = {}
1241 try:
1242 exec script_text in context
1243 except Exception, e:
1244 raise PresubmitFailure('"%s" had an exception.\n%s'
1245 % (presubmit_path, e))
1246
1247 function_name = 'PostUploadHook'
1248 if function_name not in context:
1249 return {}
1250 post_upload_hook = context[function_name]
1251 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1252 raise PresubmitFailure(
1253 'Expected function "PostUploadHook" to take three arguments.')
1254 return post_upload_hook(cl, change, OutputApi(False))
1255
1256
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001257def _MergeMasters(masters1, masters2):
1258 """Merges two master maps. Merges also the tests of each builder."""
1259 result = {}
1260 for (master, builders) in itertools.chain(masters1.iteritems(),
1261 masters2.iteritems()):
1262 new_builders = result.setdefault(master, {})
1263 for (builder, tests) in builders.iteritems():
1264 new_builders.setdefault(builder, set([])).update(tests)
1265 return result
1266
1267
1268def DoGetTryMasters(change,
1269 changed_files,
1270 repository_root,
1271 default_presubmit,
1272 project,
1273 verbose,
1274 output_stream):
1275 """Get the list of try masters from the presubmit scripts.
1276
1277 Args:
1278 changed_files: List of modified files.
1279 repository_root: The repository root.
1280 default_presubmit: A default presubmit script to execute in any case.
1281 project: Optional name of a project used in selecting trybots.
1282 verbose: Prints debug info.
1283 output_stream: A stream to write debug output to.
1284
1285 Return:
1286 Map of try masters to map of builders to set of tests.
1287 """
1288 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1289 if not presubmit_files and verbose:
1290 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1291 results = {}
1292 executer = GetTryMastersExecuter()
1293
1294 if default_presubmit:
1295 if verbose:
1296 output_stream.write("Running default presubmit script.\n")
1297 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1298 results = _MergeMasters(results, executer.ExecPresubmitScript(
1299 default_presubmit, fake_path, project, change))
1300 for filename in presubmit_files:
1301 filename = os.path.abspath(filename)
1302 if verbose:
1303 output_stream.write("Running %s\n" % filename)
1304 # Accept CRLF presubmit script.
1305 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1306 results = _MergeMasters(results, executer.ExecPresubmitScript(
1307 presubmit_script, filename, project, change))
1308
1309 # Make sets to lists again for later JSON serialization.
1310 for builders in results.itervalues():
1311 for builder in builders:
1312 builders[builder] = list(builders[builder])
1313
1314 if results and verbose:
1315 output_stream.write('%s\n' % str(results))
1316 return results
1317
1318
rmistry@google.com5626a922015-02-26 14:03:30 +00001319def DoPostUploadExecuter(change,
1320 cl,
1321 repository_root,
1322 verbose,
1323 output_stream):
1324 """Execute the post upload hook.
1325
1326 Args:
1327 change: The Change object.
1328 cl: The Changelist object.
1329 repository_root: The repository root.
1330 verbose: Prints debug info.
1331 output_stream: A stream to write debug output to.
1332 """
1333 presubmit_files = ListRelevantPresubmitFiles(
1334 change.LocalPaths(), repository_root)
1335 if not presubmit_files and verbose:
1336 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1337 results = []
1338 executer = GetPostUploadExecuter()
1339 # The root presubmit file should be executed after the ones in subdirectories.
1340 # i.e. the specific post upload hooks should run before the general ones.
1341 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1342 presubmit_files.reverse()
1343
1344 for filename in presubmit_files:
1345 filename = os.path.abspath(filename)
1346 if verbose:
1347 output_stream.write("Running %s\n" % filename)
1348 # Accept CRLF presubmit script.
1349 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1350 results.extend(executer.ExecPresubmitScript(
1351 presubmit_script, filename, cl, change))
1352 output_stream.write('\n')
1353 if results:
1354 output_stream.write('** Post Upload Hook Messages **\n')
1355 for result in results:
1356 result.handle(output_stream)
1357 output_stream.write('\n')
1358
1359 return results
1360
1361
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001362class PresubmitExecuter(object):
Aaron Gable668c1d82018-04-03 10:19:16 -07001363 def __init__(self, change, committing, verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04001364 gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001365 """
1366 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001367 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001368 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001369 gerrit_obj: provides basic Gerrit codereview functionality.
1370 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001371 parallel: if true, all tests reported via input_api.RunTests for all
1372 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001373 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001374 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001375 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001376 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001377 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001378 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001379 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001380 self.thread_pool = thread_pool
1381 self.parallel = parallel
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001382
1383 def ExecPresubmitScript(self, script_text, presubmit_path):
1384 """Executes a single presubmit script.
1385
1386 Args:
1387 script_text: The text of the presubmit script.
1388 presubmit_path: The path to the presubmit file (this will be reported via
1389 input_api.PresubmitLocalPath()).
1390
1391 Return:
1392 A list of result objects, empty if no problems.
1393 """
thakis@chromium.orgc6ef53a2014-11-04 00:13:54 +00001394
chase@chromium.org8e416c82009-10-06 04:30:44 +00001395 # Change to the presubmit file's directory to support local imports.
1396 main_path = os.getcwd()
1397 os.chdir(os.path.dirname(presubmit_path))
1398
1399 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001400 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001401 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001402 dry_run=self.dry_run, thread_pool=self.thread_pool,
1403 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001404 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001405 context = {}
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001406 try:
1407 exec script_text in context
1408 except Exception, e:
1409 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001410
1411 # These function names must change if we make substantial changes to
1412 # the presubmit API that are not backwards compatible.
1413 if self.committing:
1414 function_name = 'CheckChangeOnCommit'
1415 else:
1416 function_name = 'CheckChangeOnUpload'
1417 if function_name in context:
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001418 try:
Daniel Cheng7227d212017-11-17 08:12:37 -08001419 context['__args'] = (input_api, output_api)
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001420 logging.debug('Running %s in %s', function_name, presubmit_path)
1421 result = eval(function_name + '(*__args)', context)
1422 logging.debug('Running %s done.', function_name)
Daniel Chengd36fce42017-11-21 21:52:52 -08001423 self.more_cc.extend(output_api.more_cc)
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001424 finally:
1425 map(os.remove, input_api._named_temporary_files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001426 if not (isinstance(result, types.TupleType) or
1427 isinstance(result, types.ListType)):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001428 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001429 'Presubmit functions must return a tuple or list')
1430 for item in result:
1431 if not isinstance(item, OutputApi.PresubmitResult):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001432 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001433 'All presubmit results must be of types derived from '
1434 'output_api.PresubmitResult')
1435 else:
1436 result = () # no error since the script doesn't care about current event.
1437
chase@chromium.org8e416c82009-10-06 04:30:44 +00001438 # Return the process to the original working directory.
1439 os.chdir(main_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001440 return result
1441
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001442def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001443 committing,
1444 verbose,
1445 output_stream,
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001446 input_stream,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001447 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001448 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001449 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001450 dry_run=None,
1451 parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001452 """Runs all presubmit checks that apply to the files in the change.
1453
1454 This finds all PRESUBMIT.py files in directories enclosing the files in the
1455 change (up to the repository root) and calls the relevant entrypoint function
1456 depending on whether the change is being committed or uploaded.
1457
1458 Prints errors, warnings and notifications. Prompts the user for warnings
1459 when needed.
1460
1461 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001462 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001463 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001464 verbose: Prints debug info.
1465 output_stream: A stream to write output from presubmit tests to.
1466 input_stream: A stream to read input from the user.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001467 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001468 may_prompt: Enable (y/n) questions on warning or error. If False,
1469 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001470 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001471 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001472 parallel: if true, all tests specified by input_api.RunTests in all
1473 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001474
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001475 Warning:
1476 If may_prompt is true, output_stream SHOULD be sys.stdout and input_stream
1477 SHOULD be sys.stdin.
1478
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001479 Return:
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001480 A PresubmitOutput object. Use output.should_continue() to figure out
1481 if there were errors or warnings and the caller should abort.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001482 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001483 old_environ = os.environ
1484 try:
1485 # Make sure python subprocesses won't generate .pyc files.
1486 os.environ = os.environ.copy()
1487 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001488
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001489 output = PresubmitOutput(input_stream, output_stream)
1490 if committing:
1491 output.write("Running presubmit commit checks ...\n")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001492 else:
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001493 output.write("Running presubmit upload checks ...\n")
1494 start_time = time.time()
1495 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001496 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001497 if not presubmit_files and verbose:
maruel@chromium.orgfae707b2011-09-15 18:57:58 +00001498 output.write("Warning, no PRESUBMIT.py found.\n")
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001499 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001500 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001501 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
1502 dry_run, thread_pool, parallel)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001503 if default_presubmit:
1504 if verbose:
1505 output.write("Running default presubmit script.\n")
1506 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1507 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1508 for filename in presubmit_files:
1509 filename = os.path.abspath(filename)
1510 if verbose:
1511 output.write("Running %s\n" % filename)
1512 # Accept CRLF presubmit script.
1513 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1514 results += executer.ExecPresubmitScript(presubmit_script, filename)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001515
Edward Lesmes8e282792018-04-03 18:50:29 -04001516 results += thread_pool.RunAsync()
1517
Daniel Cheng7227d212017-11-17 08:12:37 -08001518 output.more_cc.extend(executer.more_cc)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001519 errors = []
1520 notifications = []
1521 warnings = []
1522 for result in results:
1523 if result.fatal:
1524 errors.append(result)
1525 elif result.should_prompt:
1526 warnings.append(result)
1527 else:
1528 notifications.append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001529
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001530 output.write('\n')
1531 for name, items in (('Messages', notifications),
1532 ('Warnings', warnings),
1533 ('ERRORS', errors)):
1534 if items:
1535 output.write('** Presubmit %s **\n' % name)
1536 for item in items:
1537 item.handle(output)
1538 output.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001539
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001540 total_time = time.time() - start_time
1541 if total_time > 1.0:
1542 output.write("Presubmit checks took %.1fs to calculate.\n\n" % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001543
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001544 if errors:
1545 output.fail()
1546 elif warnings:
1547 output.write('There were presubmit warnings. ')
1548 if may_prompt:
1549 output.prompt_yes_no('Are you sure you wish to continue? (y/N): ')
1550 else:
1551 output.write('Presubmit checks passed.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001552
1553 global _ASKED_FOR_FEEDBACK
1554 # Ask for feedback one time out of 5.
1555 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001556 output.write(
1557 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1558 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1559 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001560 _ASKED_FOR_FEEDBACK = True
1561 return output
1562 finally:
1563 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001564
1565
1566def ScanSubDirs(mask, recursive):
1567 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001568 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001569
1570 results = []
1571 for root, dirs, files in os.walk('.'):
1572 if '.svn' in dirs:
1573 dirs.remove('.svn')
1574 if '.git' in dirs:
1575 dirs.remove('.git')
1576 for name in files:
1577 if fnmatch.fnmatch(name, mask):
1578 results.append(os.path.join(root, name))
1579 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001580
1581
1582def ParseFiles(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001583 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001584 files = []
1585 for arg in args:
maruel@chromium.orge3608df2009-11-10 20:22:57 +00001586 files.extend([('M', f) for f in ScanSubDirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001587 return files
1588
1589
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001590def load_files(options, args):
1591 """Tries to determine the SCM."""
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001592 files = []
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001593 if args:
1594 files = ParseFiles(args, options.recursive)
agable0b65e732016-11-22 09:25:46 -08001595 change_scm = scm.determine_scm(options.root)
1596 if change_scm == 'git':
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001597 change_class = GitChange
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001598 upstream = options.upstream or None
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001599 if not files:
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001600 files = scm.GIT.CaptureStatus([], options.root, upstream)
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001601 else:
tobiasjs2836bcf2016-08-16 04:08:16 -07001602 logging.info('Doesn\'t seem under source control. Got %d files', len(args))
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001603 if not files:
1604 return None, None
1605 change_class = Change
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001606 return change_class, files
1607
1608
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001609@contextlib.contextmanager
1610def canned_check_filter(method_names):
1611 filtered = {}
1612 try:
1613 for method_name in method_names:
1614 if not hasattr(presubmit_canned_checks, method_name):
Aaron Gableecee74c2018-04-02 15:13:08 -07001615 logging.warn('Skipping unknown "canned" check %s' % method_name)
1616 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001617 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1618 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1619 yield
1620 finally:
1621 for name, method in filtered.iteritems():
1622 setattr(presubmit_canned_checks, name, method)
1623
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001624
sbc@chromium.org013731e2015-02-26 18:28:43 +00001625def main(argv=None):
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001626 parser = optparse.OptionParser(usage="%prog [options] <files...>",
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001627 version="%prog " + str(__version__))
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001628 parser.add_option("-c", "--commit", action="store_true", default=False,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001629 help="Use commit instead of upload checks")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001630 parser.add_option("-u", "--upload", action="store_false", dest='commit',
1631 help="Use upload instead of commit checks")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001632 parser.add_option("-r", "--recursive", action="store_true",
1633 help="Act recursively")
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001634 parser.add_option("-v", "--verbose", action="count", default=0,
1635 help="Use 2 times for more debug info")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001636 parser.add_option("--name", default='no name')
maruel@chromium.org58407af2011-04-12 23:15:57 +00001637 parser.add_option("--author")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001638 parser.add_option("--description", default='')
1639 parser.add_option("--issue", type='int', default=0)
1640 parser.add_option("--patchset", type='int', default=0)
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001641 parser.add_option("--root", default=os.getcwd(),
1642 help="Search for PRESUBMIT.py up to this directory. "
1643 "If inherit-review-settings-ok is present in this "
1644 "directory, parent directories up to the root file "
1645 "system directories will also be searched.")
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001646 parser.add_option("--upstream",
1647 help="Git only: the base ref or upstream branch against "
1648 "which the diff should be computed.")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001649 parser.add_option("--default_presubmit")
1650 parser.add_option("--may_prompt", action='store_true', default=False)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001651 parser.add_option("--skip_canned", action='append', default=[],
1652 help="A list of checks to skip which appear in "
1653 "presubmit_canned_checks. Can be provided multiple times "
1654 "to skip multiple canned checks.")
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001655 parser.add_option("--dry_run", action='store_true',
1656 help=optparse.SUPPRESS_HELP)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001657 parser.add_option("--gerrit_url", help=optparse.SUPPRESS_HELP)
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001658 parser.add_option("--gerrit_fetch", action='store_true',
1659 help=optparse.SUPPRESS_HELP)
Edward Lesmes8e282792018-04-03 18:50:29 -04001660 parser.add_option('--parallel', action='store_true',
1661 help='Run all tests specified by input_api.RunTests in all '
1662 'PRESUBMIT files in parallel.')
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001663
maruel@chromium.org82e5f282011-03-17 14:08:55 +00001664 options, args = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001665
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001666 if options.verbose >= 2:
maruel@chromium.org7444c502011-02-09 14:02:11 +00001667 logging.basicConfig(level=logging.DEBUG)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001668 elif options.verbose:
1669 logging.basicConfig(level=logging.INFO)
1670 else:
1671 logging.basicConfig(level=logging.ERROR)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001672
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001673 change_class, files = load_files(options, args)
1674 if not change_class:
1675 parser.error('For unversioned directory, <files> is not optional.')
tobiasjs2836bcf2016-08-16 04:08:16 -07001676 logging.info('Found %d file(s).', len(files))
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001677
Aaron Gable668c1d82018-04-03 10:19:16 -07001678 gerrit_obj = None
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001679 if options.gerrit_url and options.gerrit_fetch:
tandrii@chromium.org83b1b232016-04-29 16:33:19 +00001680 assert options.issue and options.patchset
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001681 gerrit_obj = GerritAccessor(urlparse.urlparse(options.gerrit_url).netloc)
1682 options.author = gerrit_obj.GetChangeOwner(options.issue)
1683 options.description = gerrit_obj.GetChangeDescription(options.issue,
1684 options.patchset)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001685 logging.info('Got author: "%s"', options.author)
1686 logging.info('Got description: """\n%s\n"""', options.description)
1687
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001688 try:
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001689 with canned_check_filter(options.skip_canned):
1690 results = DoPresubmitChecks(
1691 change_class(options.name,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001692 options.description,
1693 options.root,
1694 files,
1695 options.issue,
1696 options.patchset,
1697 options.author,
1698 upstream=options.upstream),
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001699 options.commit,
1700 options.verbose,
1701 sys.stdout,
1702 sys.stdin,
1703 options.default_presubmit,
1704 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001705 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001706 options.dry_run,
1707 options.parallel)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001708 return not results.should_continue()
1709 except PresubmitFailure, e:
1710 print >> sys.stderr, e
1711 print >> sys.stderr, 'Maybe your depot_tools is out of date?'
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001712 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001713
1714
1715if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001716 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00001717 try:
1718 sys.exit(main())
1719 except KeyboardInterrupt:
1720 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07001721 sys.exit(2)