blob: bf367c683e6f3a8e6e816acda71f964962f5b53b [file] [log] [blame]
iannucci@chromium.org405b87e2015-11-12 18:08:34 +00001#!/usr/bin/env python
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02002# Copyright (c) 2013 The Chromium Authors. All rights reserved.
maruel@chromium.org725f1c32011-04-01 20:24:54 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006# Copyright (C) 2008 Evan Martin <martine@danga.com>
7
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00008"""A git-command for integrating reviews on Rietveld and Gerrit."""
maruel@chromium.org725f1c32011-04-01 20:24:54 +00009
vapiera7fbd5a2016-06-16 09:17:49 -070010from __future__ import print_function
11
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +000012from distutils.version import LooseVersion
calamity@chromium.orgffde55c2015-03-12 00:44:17 +000013from multiprocessing.pool import ThreadPool
thakis@chromium.org3421c992014-11-02 02:20:32 +000014import base64
rmistry@google.com2dd99862015-06-22 12:22:18 +000015import collections
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +010016import contextlib
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010017import datetime
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +010018import fnmatch
sheyang@google.com6ebaf782015-05-12 19:17:54 +000019import httplib
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +010020import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000021import json
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000022import logging
calamity@chromium.orgcf197482016-04-29 20:15:53 +000023import multiprocessing
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000024import optparse
25import os
26import re
Andrii Shyshkalov353637c2017-03-14 16:52:18 +010027import shutil
ukai@chromium.org78c4b982012-02-14 02:20:26 +000028import stat
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000029import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070030import tempfile
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000031import textwrap
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000032import urllib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000033import urllib2
maruel@chromium.org967c0a82013-06-17 22:52:24 +000034import urlparse
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000035import uuid
thestig@chromium.org00858c82013-12-02 23:08:03 +000036import webbrowser
thakis@chromium.org3421c992014-11-02 02:20:32 +000037import zlib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000038
39try:
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -080040 import readline # pylint: disable=import-error,W0611
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000041except ImportError:
42 pass
43
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000044from third_party import colorama
sheyang@google.com6ebaf782015-05-12 19:17:54 +000045from third_party import httplib2
maruel@chromium.org2a74d372011-03-29 19:05:50 +000046from third_party import upload
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000047import auth
skobes6468b902016-10-24 08:45:10 -070048import checkout
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +000049import clang_format
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +000050import dart_format
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +000051import setup_color
maruel@chromium.org6f09cd92011-04-01 16:38:12 +000052import fix_encoding
maruel@chromium.org0e0436a2011-10-25 13:32:41 +000053import gclient_utils
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +000054import gerrit_util
szager@chromium.org151ebcf2016-03-09 01:08:25 +000055import git_cache
iannucci@chromium.org9e849272014-04-04 00:31:55 +000056import git_common
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +000057import git_footers
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000058import metrics
piman@chromium.org336f9122014-09-04 02:16:55 +000059import owners
iannucci@chromium.org9e849272014-04-04 00:31:55 +000060import owners_finder
maruel@chromium.org2a74d372011-03-29 19:05:50 +000061import presubmit_support
maruel@chromium.orgcab38e92011-04-09 00:30:51 +000062import rietveld
maruel@chromium.org2a74d372011-03-29 19:05:50 +000063import scm
Francois Dorayd42c6812017-05-30 15:10:20 -040064import split_cl
maruel@chromium.org0633fb42013-08-16 20:06:14 +000065import subcommand
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +000066import subprocess2
maruel@chromium.org2a74d372011-03-29 19:05:50 +000067import watchlists
68
tandrii7400cf02016-06-21 08:48:07 -070069__version__ = '2.0'
maruel@chromium.org2a74d372011-03-29 19:05:50 +000070
tandrii9d2c7a32016-06-22 03:42:45 -070071COMMIT_BOT_EMAIL = 'commit-bot@chromium.org'
iannuccie7f68952016-08-15 17:45:29 -070072DEFAULT_SERVER = 'https://codereview.chromium.org'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -080073POSTUPSTREAM_HOOK = '.git/hooks/post-cl-land'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000074DESCRIPTION_BACKUP_FILE = '~/.git_cl_description_backup'
rmistry@google.comc68112d2015-03-03 12:48:06 +000075REFS_THAT_ALIAS_TO_OTHER_REFS = {
76 'refs/remotes/origin/lkgr': 'refs/remotes/origin/master',
77 'refs/remotes/origin/lkcr': 'refs/remotes/origin/master',
78}
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000079
thestig@chromium.org44202a22014-03-11 19:22:18 +000080# Valid extensions for files we want to lint.
81DEFAULT_LINT_REGEX = r"(.*\.cpp|.*\.cc|.*\.h)"
82DEFAULT_LINT_IGNORE_REGEX = r"$^"
83
borenet6c0efe62016-10-19 08:13:29 -070084# Buildbucket master name prefix.
85MASTER_PREFIX = 'master.'
86
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000087# Shortcut since it quickly becomes redundant.
88Fore = colorama.Fore
maruel@chromium.org90541732011-04-01 17:54:18 +000089
maruel@chromium.orgddd59412011-11-30 14:20:38 +000090# Initialized in main()
91settings = None
92
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +010093# Used by tests/git_cl_test.py to add extra logging.
94# Inside the weirdly failing test, add this:
95# >>> self.mock(git_cl, '_IS_BEING_TESTED', True)
Quinten Yearsley0c62da92017-05-31 13:39:42 -070096# And scroll up to see the stack trace printed.
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +010097_IS_BEING_TESTED = False
98
maruel@chromium.orgddd59412011-11-30 14:20:38 +000099
Christopher Lamf732cd52017-01-24 12:40:11 +1100100def DieWithError(message, change_desc=None):
101 if change_desc:
102 SaveDescriptionBackup(change_desc)
103
vapiera7fbd5a2016-06-16 09:17:49 -0700104 print(message, file=sys.stderr)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000105 sys.exit(1)
106
107
Christopher Lamf732cd52017-01-24 12:40:11 +1100108def SaveDescriptionBackup(change_desc):
109 backup_path = os.path.expanduser(DESCRIPTION_BACKUP_FILE)
110 print('\nError after CL description prompt -- saving description to %s\n' %
111 backup_path)
112 backup_file = open(backup_path, 'w')
113 backup_file.write(change_desc.description)
114 backup_file.close()
115
116
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000117def GetNoGitPagerEnv():
118 env = os.environ.copy()
119 # 'cat' is a magical git string that disables pagers on all platforms.
120 env['GIT_PAGER'] = 'cat'
121 return env
122
vadimsh@chromium.org566a02a2014-08-22 01:34:13 +0000123
bsep@chromium.org627d9002016-04-29 00:00:52 +0000124def RunCommand(args, error_ok=False, error_message=None, shell=False, **kwargs):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000125 try:
bsep@chromium.org627d9002016-04-29 00:00:52 +0000126 return subprocess2.check_output(args, shell=shell, **kwargs)
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000127 except subprocess2.CalledProcessError as e:
128 logging.debug('Failed running %s', args)
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000129 if not error_ok:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000130 DieWithError(
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000131 'Command "%s" failed.\n%s' % (
132 ' '.join(args), error_message or e.stdout or ''))
133 return e.stdout
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000134
135
136def RunGit(args, **kwargs):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000137 """Returns stdout."""
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000138 return RunCommand(['git'] + args, **kwargs)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000139
140
enne@chromium.org3b7e15c2014-01-21 17:44:47 +0000141def RunGitWithCode(args, suppress_stderr=False):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000142 """Returns return code and stdout."""
tandrii5d48c322016-08-18 16:19:37 -0700143 if suppress_stderr:
144 stderr = subprocess2.VOID
145 else:
146 stderr = sys.stderr
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000147 try:
tandrii5d48c322016-08-18 16:19:37 -0700148 (out, _), code = subprocess2.communicate(['git'] + args,
149 env=GetNoGitPagerEnv(),
150 stdout=subprocess2.PIPE,
151 stderr=stderr)
152 return code, out
153 except subprocess2.CalledProcessError as e:
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +0900154 logging.debug('Failed running %s', ['git'] + args)
tandrii5d48c322016-08-18 16:19:37 -0700155 return e.returncode, e.stdout
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000156
157
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000158def RunGitSilent(args):
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000159 """Returns stdout, suppresses stderr and ignores the return code."""
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000160 return RunGitWithCode(args, suppress_stderr=True)[1]
161
162
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000163def IsGitVersionAtLeast(min_version):
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000164 prefix = 'git version '
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000165 version = RunGit(['--version']).strip()
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000166 return (version.startswith(prefix) and
167 LooseVersion(version[len(prefix):]) >= LooseVersion(min_version))
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000168
169
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000170def BranchExists(branch):
171 """Return True if specified branch exists."""
172 code, _ = RunGitWithCode(['rev-parse', '--verify', branch],
173 suppress_stderr=True)
174 return not code
175
176
tandrii2a16b952016-10-19 07:09:44 -0700177def time_sleep(seconds):
178 # Use this so that it can be mocked in tests without interfering with python
179 # system machinery.
180 import time # Local import to discourage others from importing time globally.
181 return time.sleep(seconds)
182
183
maruel@chromium.org90541732011-04-01 17:54:18 +0000184def ask_for_data(prompt):
185 try:
186 return raw_input(prompt)
187 except KeyboardInterrupt:
188 # Hide the exception.
189 sys.exit(1)
190
191
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100192def confirm_or_exit(prefix='', action='confirm'):
193 """Asks user to press enter to continue or press Ctrl+C to abort."""
194 if not prefix or prefix.endswith('\n'):
195 mid = 'Press'
Andrii Shyshkalov353637c2017-03-14 16:52:18 +0100196 elif prefix.endswith('.') or prefix.endswith('?'):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100197 mid = ' Press'
198 elif prefix.endswith(' '):
199 mid = 'press'
200 else:
201 mid = ' press'
202 ask_for_data('%s%s Enter to %s, or Ctrl+C to abort' % (prefix, mid, action))
203
204
205def ask_for_explicit_yes(prompt):
206 """Returns whether user typed 'y' or 'yes' to confirm the given prompt"""
207 result = ask_for_data(prompt + ' [Yes/No]: ').lower()
208 while True:
209 if 'yes'.startswith(result):
210 return True
211 if 'no'.startswith(result):
212 return False
213 result = ask_for_data('Please, type yes or no: ').lower()
214
215
tandrii5d48c322016-08-18 16:19:37 -0700216def _git_branch_config_key(branch, key):
217 """Helper method to return Git config key for a branch."""
218 assert branch, 'branch name is required to set git config for it'
219 return 'branch.%s.%s' % (branch, key)
220
221
222def _git_get_branch_config_value(key, default=None, value_type=str,
223 branch=False):
224 """Returns git config value of given or current branch if any.
225
226 Returns default in all other cases.
227 """
228 assert value_type in (int, str, bool)
229 if branch is False: # Distinguishing default arg value from None.
230 branch = GetCurrentBranch()
231
rogerta@chromium.orgcaa16552013-03-18 20:45:05 +0000232 if not branch:
tandrii5d48c322016-08-18 16:19:37 -0700233 return default
rogerta@chromium.orgcaa16552013-03-18 20:45:05 +0000234
tandrii5d48c322016-08-18 16:19:37 -0700235 args = ['config']
tandrii33a46ff2016-08-23 05:53:40 -0700236 if value_type == bool:
tandrii5d48c322016-08-18 16:19:37 -0700237 args.append('--bool')
tandrii33a46ff2016-08-23 05:53:40 -0700238 # git config also has --int, but apparently git config suffers from integer
239 # overflows (http://crbug.com/640115), so don't use it.
tandrii5d48c322016-08-18 16:19:37 -0700240 args.append(_git_branch_config_key(branch, key))
241 code, out = RunGitWithCode(args)
242 if code == 0:
243 value = out.strip()
244 if value_type == int:
245 return int(value)
246 if value_type == bool:
247 return bool(value.lower() == 'true')
248 return value
iannucci@chromium.org79540052012-10-19 23:15:26 +0000249 return default
250
251
tandrii5d48c322016-08-18 16:19:37 -0700252def _git_set_branch_config_value(key, value, branch=None, **kwargs):
253 """Sets the value or unsets if it's None of a git branch config.
254
255 Valid, though not necessarily existing, branch must be provided,
256 otherwise currently checked out branch is used.
257 """
258 if not branch:
259 branch = GetCurrentBranch()
260 assert branch, 'a branch name OR currently checked out branch is required'
261 args = ['config']
qyearsley12fa6ff2016-08-24 09:18:40 -0700262 # Check for boolean first, because bool is int, but int is not bool.
tandrii5d48c322016-08-18 16:19:37 -0700263 if value is None:
264 args.append('--unset')
265 elif isinstance(value, bool):
266 args.append('--bool')
267 value = str(value).lower()
tandrii5d48c322016-08-18 16:19:37 -0700268 else:
tandrii33a46ff2016-08-23 05:53:40 -0700269 # git config also has --int, but apparently git config suffers from integer
270 # overflows (http://crbug.com/640115), so don't use it.
tandrii5d48c322016-08-18 16:19:37 -0700271 value = str(value)
272 args.append(_git_branch_config_key(branch, key))
273 if value is not None:
274 args.append(value)
275 RunGit(args, **kwargs)
276
277
Andrii Shyshkalova6695812016-12-06 17:47:09 +0100278def _get_committer_timestamp(commit):
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700279 """Returns Unix timestamp as integer of a committer in a commit.
Andrii Shyshkalova6695812016-12-06 17:47:09 +0100280
281 Commit can be whatever git show would recognize, such as HEAD, sha1 or ref.
282 """
283 # Git also stores timezone offset, but it only affects visual display,
284 # actual point in time is defined by this timestamp only.
285 return int(RunGit(['show', '-s', '--format=%ct', commit]).strip())
286
287
288def _git_amend_head(message, committer_timestamp):
289 """Amends commit with new message and desired committer_timestamp.
290
291 Sets committer timezone to UTC.
292 """
293 env = os.environ.copy()
294 env['GIT_COMMITTER_DATE'] = '%d+0000' % committer_timestamp
295 return RunGit(['commit', '--amend', '-m', message], env=env)
296
297
machenbach@chromium.org45453142015-09-15 08:45:22 +0000298def _get_properties_from_options(options):
299 properties = dict(x.split('=', 1) for x in options.properties)
300 for key, val in properties.iteritems():
301 try:
302 properties[key] = json.loads(val)
303 except ValueError:
304 pass # If a value couldn't be evaluated, treat it as a string.
305 return properties
306
307
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000308def _prefix_master(master):
309 """Convert user-specified master name to full master name.
310
311 Buildbucket uses full master name(master.tryserver.chromium.linux) as bucket
312 name, while the developers always use shortened master name
313 (tryserver.chromium.linux) by stripping off the prefix 'master.'. This
314 function does the conversion for buildbucket migration.
315 """
borenet6c0efe62016-10-19 08:13:29 -0700316 if master.startswith(MASTER_PREFIX):
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000317 return master
borenet6c0efe62016-10-19 08:13:29 -0700318 return '%s%s' % (MASTER_PREFIX, master)
319
320
321def _unprefix_master(bucket):
322 """Convert bucket name to shortened master name.
323
324 Buildbucket uses full master name(master.tryserver.chromium.linux) as bucket
325 name, while the developers always use shortened master name
326 (tryserver.chromium.linux) by stripping off the prefix 'master.'. This
327 function does the conversion for buildbucket migration.
328 """
329 if bucket.startswith(MASTER_PREFIX):
330 return bucket[len(MASTER_PREFIX):]
331 return bucket
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000332
333
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000334def _buildbucket_retry(operation_name, http, *args, **kwargs):
335 """Retries requests to buildbucket service and returns parsed json content."""
336 try_count = 0
337 while True:
338 response, content = http.request(*args, **kwargs)
339 try:
340 content_json = json.loads(content)
341 except ValueError:
342 content_json = None
343
344 # Buildbucket could return an error even if status==200.
345 if content_json and content_json.get('error'):
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000346 error = content_json.get('error')
347 if error.get('code') == 403:
348 raise BuildbucketResponseException(
349 'Access denied: %s' % error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000350 msg = 'Error in response. Reason: %s. Message: %s.' % (
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000351 error.get('reason', ''), error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000352 raise BuildbucketResponseException(msg)
353
354 if response.status == 200:
Nodir Turakulov23d75d22018-06-04 12:37:32 -0700355 if content_json is None:
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000356 raise BuildbucketResponseException(
357 'Buildbucket returns invalid json content: %s.\n'
Nodir Turakulov9ac59792018-06-04 12:34:14 -0700358 'Please file bugs at http://crbug.com, '
359 'component "Infra>Platform>BuildBucket".' %
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000360 content)
361 return content_json
362 if response.status < 500 or try_count >= 2:
363 raise httplib2.HttpLib2Error(content)
364
365 # status >= 500 means transient failures.
366 logging.debug('Transient errors when %s. Will retry.', operation_name)
tandrii2a16b952016-10-19 07:09:44 -0700367 time_sleep(0.5 + 1.5*try_count)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000368 try_count += 1
369 assert False, 'unreachable'
370
371
qyearsley1fdfcb62016-10-24 13:22:03 -0700372def _get_bucket_map(changelist, options, option_parser):
qyearsleydd49f942016-10-28 11:57:22 -0700373 """Returns a dict mapping bucket names to builders and tests,
374 for triggering try jobs.
qyearsley1fdfcb62016-10-24 13:22:03 -0700375 """
qyearsleydd49f942016-10-28 11:57:22 -0700376 # If no bots are listed, we try to get a set of builders and tests based
377 # on GetPreferredTryMasters functions in PRESUBMIT.py files.
qyearsley1fdfcb62016-10-24 13:22:03 -0700378 if not options.bot:
379 change = changelist.GetChange(
380 changelist.GetCommonAncestorWithUpstream(), None)
qyearsley136b49f2016-10-31 09:02:26 -0700381 # Get try masters from PRESUBMIT.py files.
nodire4f0fe02016-11-04 16:23:30 -0700382 masters = presubmit_support.DoGetTryMasters(
qyearsley1fdfcb62016-10-24 13:22:03 -0700383 change=change,
384 changed_files=change.LocalPaths(),
385 repository_root=settings.GetRoot(),
386 default_presubmit=None,
387 project=None,
388 verbose=options.verbose,
389 output_stream=sys.stdout)
nodire4f0fe02016-11-04 16:23:30 -0700390 if masters is None:
391 return None
Sergiy Byelozyorov935b93f2016-11-28 20:41:56 +0100392 return {_prefix_master(m): b for m, b in masters.iteritems()}
qyearsley1fdfcb62016-10-24 13:22:03 -0700393
qyearsley1fdfcb62016-10-24 13:22:03 -0700394 if options.bucket:
395 return {options.bucket: {b: [] for b in options.bot}}
qyearsleydd49f942016-10-28 11:57:22 -0700396 if options.master:
397 return {_prefix_master(options.master): {b: [] for b in options.bot}}
qyearsley1fdfcb62016-10-24 13:22:03 -0700398
qyearsleydd49f942016-10-28 11:57:22 -0700399 # If bots are listed but no master or bucket, then we need to find out
400 # the corresponding master for each bot.
401 bucket_map, error_message = _get_bucket_map_for_builders(options.bot)
402 if error_message:
403 option_parser.error(
404 'Tryserver master cannot be found because: %s\n'
405 'Please manually specify the tryserver master, e.g. '
406 '"-m tryserver.chromium.linux".' % error_message)
407 return bucket_map
qyearsley1fdfcb62016-10-24 13:22:03 -0700408
409
qyearsley123a4682016-10-26 09:12:17 -0700410def _get_bucket_map_for_builders(builders):
411 """Returns a map of buckets to builders for the given builders."""
qyearsley1fdfcb62016-10-24 13:22:03 -0700412 map_url = 'https://builders-map.appspot.com/'
413 try:
qyearsley123a4682016-10-26 09:12:17 -0700414 builders_map = json.load(urllib2.urlopen(map_url))
qyearsley1fdfcb62016-10-24 13:22:03 -0700415 except urllib2.URLError as e:
416 return None, ('Failed to fetch builder-to-master map from %s. Error: %s.' %
417 (map_url, e))
418 except ValueError as e:
419 return None, ('Invalid json string from %s. Error: %s.' % (map_url, e))
qyearsley123a4682016-10-26 09:12:17 -0700420 if not builders_map:
qyearsley1fdfcb62016-10-24 13:22:03 -0700421 return None, 'Failed to build master map.'
422
qyearsley123a4682016-10-26 09:12:17 -0700423 bucket_map = {}
424 for builder in builders:
Nodir Turakulovb422e682018-02-20 22:51:30 -0800425 bucket = builders_map.get(builder, {}).get('bucket')
426 if bucket:
427 bucket_map.setdefault(bucket, {})[builder] = []
qyearsley123a4682016-10-26 09:12:17 -0700428 return bucket_map, None
qyearsley1fdfcb62016-10-24 13:22:03 -0700429
430
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -0800431def _trigger_try_jobs(auth_config, changelist, buckets, options, patchset):
qyearsley1fdfcb62016-10-24 13:22:03 -0700432 """Sends a request to Buildbucket to trigger try jobs for a changelist.
433
434 Args:
Aaron Gablefb28d482018-04-02 13:08:06 -0700435 auth_config: AuthConfig for Buildbucket.
qyearsley1fdfcb62016-10-24 13:22:03 -0700436 changelist: Changelist that the try jobs are associated with.
437 buckets: A nested dict mapping bucket names to builders to tests.
438 options: Command-line options.
439 """
tandriide281ae2016-10-12 06:02:30 -0700440 assert changelist.GetIssue(), 'CL must be uploaded first'
441 codereview_url = changelist.GetCodereviewServer()
442 assert codereview_url, 'CL must be uploaded first'
443 patchset = patchset or changelist.GetMostRecentPatchset()
444 assert patchset, 'CL must be uploaded first'
445
446 codereview_host = urlparse.urlparse(codereview_url).hostname
Aaron Gablefb28d482018-04-02 13:08:06 -0700447 # Cache the buildbucket credentials under the codereview host key, so that
448 # users can use different credentials for different buckets.
tandriide281ae2016-10-12 06:02:30 -0700449 authenticator = auth.get_authenticator_for_host(codereview_host, auth_config)
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000450 http = authenticator.authorize(httplib2.Http())
451 http.force_exception_to_status_code = True
tandriide281ae2016-10-12 06:02:30 -0700452
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000453 buildbucket_put_url = (
454 'https://{hostname}/_ah/api/buildbucket/v1/builds/batch'.format(
sheyang@chromium.orgdb375572015-08-17 19:22:23 +0000455 hostname=options.buildbucket_host))
tandriide281ae2016-10-12 06:02:30 -0700456 buildset = 'patch/{codereview}/{hostname}/{issue}/{patch}'.format(
457 codereview='gerrit' if changelist.IsGerrit() else 'rietveld',
458 hostname=codereview_host,
459 issue=changelist.GetIssue(),
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000460 patch=patchset)
tandrii8c5a3532016-11-04 07:52:02 -0700461
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700462 shared_parameters_properties = changelist.GetTryJobProperties(patchset)
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -0800463 shared_parameters_properties['category'] = options.category
tandrii8c5a3532016-11-04 07:52:02 -0700464 if options.clobber:
465 shared_parameters_properties['clobber'] = True
tandriide281ae2016-10-12 06:02:30 -0700466 extra_properties = _get_properties_from_options(options)
tandrii8c5a3532016-11-04 07:52:02 -0700467 if extra_properties:
468 shared_parameters_properties.update(extra_properties)
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000469
470 batch_req_body = {'builds': []}
471 print_text = []
472 print_text.append('Tried jobs on:')
borenet6c0efe62016-10-19 08:13:29 -0700473 for bucket, builders_and_tests in sorted(buckets.iteritems()):
474 print_text.append('Bucket: %s' % bucket)
475 master = None
476 if bucket.startswith(MASTER_PREFIX):
477 master = _unprefix_master(bucket)
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000478 for builder, tests in sorted(builders_and_tests.iteritems()):
479 print_text.append(' %s: %s' % (builder, tests))
480 parameters = {
481 'builder_name': builder,
nodir@chromium.orgd2217312015-09-21 15:51:21 +0000482 'changes': [{
Andrii Shyshkaloveadad922017-01-26 09:38:30 +0100483 'author': {'email': changelist.GetIssueOwner()},
nodir@chromium.orgd2217312015-09-21 15:51:21 +0000484 'revision': options.revision,
485 }],
tandrii8c5a3532016-11-04 07:52:02 -0700486 'properties': shared_parameters_properties.copy(),
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000487 }
machenbach@chromium.org2403e802016-04-29 12:34:42 +0000488 if 'presubmit' in builder.lower():
489 parameters['properties']['dry_run'] = 'true'
tandrii@chromium.org3764fa22015-10-21 16:40:40 +0000490 if tests:
491 parameters['properties']['testfilter'] = tests
borenet6c0efe62016-10-19 08:13:29 -0700492
493 tags = [
494 'builder:%s' % builder,
495 'buildset:%s' % buildset,
496 'user_agent:git_cl_try',
497 ]
498 if master:
499 parameters['properties']['master'] = master
500 tags.append('master:%s' % master)
501
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000502 batch_req_body['builds'].append(
503 {
504 'bucket': bucket,
505 'parameters_json': json.dumps(parameters),
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000506 'client_operation_id': str(uuid.uuid4()),
borenet6c0efe62016-10-19 08:13:29 -0700507 'tags': tags,
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000508 }
509 )
510
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000511 _buildbucket_retry(
qyearsleyeab3c042016-08-24 09:18:28 -0700512 'triggering try jobs',
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000513 http,
514 buildbucket_put_url,
515 'PUT',
516 body=json.dumps(batch_req_body),
517 headers={'Content-Type': 'application/json'}
518 )
tandrii@chromium.org35c61452016-02-26 15:24:57 +0000519 print_text.append('To see results here, run: git cl try-results')
520 print_text.append('To see results in browser, run: git cl web')
vapiera7fbd5a2016-06-16 09:17:49 -0700521 print('\n'.join(print_text))
kjellander@chromium.org44424542015-06-02 18:35:29 +0000522
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000523
tandrii221ab252016-10-06 08:12:04 -0700524def fetch_try_jobs(auth_config, changelist, buildbucket_host,
525 patchset=None):
qyearsleyeab3c042016-08-24 09:18:28 -0700526 """Fetches try jobs from buildbucket.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000527
qyearsley53f48a12016-09-01 10:45:13 -0700528 Returns a map from build id to build info as a dictionary.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000529 """
tandrii221ab252016-10-06 08:12:04 -0700530 assert buildbucket_host
531 assert changelist.GetIssue(), 'CL must be uploaded first'
532 assert changelist.GetCodereviewServer(), 'CL must be uploaded first'
533 patchset = patchset or changelist.GetMostRecentPatchset()
534 assert patchset, 'CL must be uploaded first'
535
536 codereview_url = changelist.GetCodereviewServer()
537 codereview_host = urlparse.urlparse(codereview_url).hostname
538 authenticator = auth.get_authenticator_for_host(codereview_host, auth_config)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000539 if authenticator.has_cached_credentials():
540 http = authenticator.authorize(httplib2.Http())
541 else:
vapiera7fbd5a2016-06-16 09:17:49 -0700542 print('Warning: Some results might be missing because %s' %
543 # Get the message on how to login.
tandrii221ab252016-10-06 08:12:04 -0700544 (auth.LoginRequiredError(codereview_host).message,))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000545 http = httplib2.Http()
546
547 http.force_exception_to_status_code = True
548
tandrii221ab252016-10-06 08:12:04 -0700549 buildset = 'patch/{codereview}/{hostname}/{issue}/{patch}'.format(
550 codereview='gerrit' if changelist.IsGerrit() else 'rietveld',
551 hostname=codereview_host,
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000552 issue=changelist.GetIssue(),
tandrii221ab252016-10-06 08:12:04 -0700553 patch=patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000554 params = {'tag': 'buildset:%s' % buildset}
555
556 builds = {}
557 while True:
558 url = 'https://{hostname}/_ah/api/buildbucket/v1/search?{params}'.format(
tandrii221ab252016-10-06 08:12:04 -0700559 hostname=buildbucket_host,
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000560 params=urllib.urlencode(params))
qyearsleyeab3c042016-08-24 09:18:28 -0700561 content = _buildbucket_retry('fetching try jobs', http, url, 'GET')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000562 for build in content.get('builds', []):
563 builds[build['id']] = build
564 if 'next_cursor' in content:
565 params['start_cursor'] = content['next_cursor']
566 else:
567 break
568 return builds
569
570
qyearsleyeab3c042016-08-24 09:18:28 -0700571def print_try_jobs(options, builds):
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000572 """Prints nicely result of fetch_try_jobs."""
573 if not builds:
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700574 print('No try jobs scheduled.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000575 return
576
577 # Make a copy, because we'll be modifying builds dictionary.
578 builds = builds.copy()
579 builder_names_cache = {}
580
581 def get_builder(b):
582 try:
583 return builder_names_cache[b['id']]
584 except KeyError:
585 try:
586 parameters = json.loads(b['parameters_json'])
587 name = parameters['builder_name']
588 except (ValueError, KeyError) as error:
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700589 print('WARNING: Failed to get builder name for build %s: %s' % (
vapiera7fbd5a2016-06-16 09:17:49 -0700590 b['id'], error))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000591 name = None
592 builder_names_cache[b['id']] = name
593 return name
594
595 def get_bucket(b):
596 bucket = b['bucket']
597 if bucket.startswith('master.'):
598 return bucket[len('master.'):]
599 return bucket
600
601 if options.print_master:
602 name_fmt = '%%-%ds %%-%ds' % (
603 max(len(str(get_bucket(b))) for b in builds.itervalues()),
604 max(len(str(get_builder(b))) for b in builds.itervalues()))
605 def get_name(b):
606 return name_fmt % (get_bucket(b), get_builder(b))
607 else:
608 name_fmt = '%%-%ds' % (
609 max(len(str(get_builder(b))) for b in builds.itervalues()))
610 def get_name(b):
611 return name_fmt % get_builder(b)
612
613 def sort_key(b):
614 return b['status'], b.get('result'), get_name(b), b.get('url')
615
616 def pop(title, f, color=None, **kwargs):
617 """Pop matching builds from `builds` dict and print them."""
618
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +0000619 if not options.color or color is None:
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000620 colorize = str
621 else:
622 colorize = lambda x: '%s%s%s' % (color, x, Fore.RESET)
623
624 result = []
625 for b in builds.values():
626 if all(b.get(k) == v for k, v in kwargs.iteritems()):
627 builds.pop(b['id'])
628 result.append(b)
629 if result:
vapiera7fbd5a2016-06-16 09:17:49 -0700630 print(colorize(title))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000631 for b in sorted(result, key=sort_key):
vapiera7fbd5a2016-06-16 09:17:49 -0700632 print(' ', colorize('\t'.join(map(str, f(b)))))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000633
634 total = len(builds)
635 pop(status='COMPLETED', result='SUCCESS',
636 title='Successes:', color=Fore.GREEN,
637 f=lambda b: (get_name(b), b.get('url')))
638 pop(status='COMPLETED', result='FAILURE', failure_reason='INFRA_FAILURE',
639 title='Infra Failures:', color=Fore.MAGENTA,
640 f=lambda b: (get_name(b), b.get('url')))
641 pop(status='COMPLETED', result='FAILURE', failure_reason='BUILD_FAILURE',
642 title='Failures:', color=Fore.RED,
643 f=lambda b: (get_name(b), b.get('url')))
644 pop(status='COMPLETED', result='CANCELED',
645 title='Canceled:', color=Fore.MAGENTA,
646 f=lambda b: (get_name(b),))
647 pop(status='COMPLETED', result='FAILURE',
648 failure_reason='INVALID_BUILD_DEFINITION',
649 title='Wrong master/builder name:', color=Fore.MAGENTA,
650 f=lambda b: (get_name(b),))
651 pop(status='COMPLETED', result='FAILURE',
652 title='Other failures:',
653 f=lambda b: (get_name(b), b.get('failure_reason'), b.get('url')))
654 pop(status='COMPLETED',
655 title='Other finished:',
656 f=lambda b: (get_name(b), b.get('result'), b.get('url')))
657 pop(status='STARTED',
658 title='Started:', color=Fore.YELLOW,
659 f=lambda b: (get_name(b), b.get('url')))
660 pop(status='SCHEDULED',
661 title='Scheduled:',
662 f=lambda b: (get_name(b), 'id=%s' % b['id']))
663 # The last section is just in case buildbucket API changes OR there is a bug.
664 pop(title='Other:',
665 f=lambda b: (get_name(b), 'id=%s' % b['id']))
666 assert len(builds) == 0
qyearsleyeab3c042016-08-24 09:18:28 -0700667 print('Total: %d try jobs' % total)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000668
669
qyearsley53f48a12016-09-01 10:45:13 -0700670def write_try_results_json(output_file, builds):
671 """Writes a subset of the data from fetch_try_jobs to a file as JSON.
672
673 The input |builds| dict is assumed to be generated by Buildbucket.
674 Buildbucket documentation: http://goo.gl/G0s101
675 """
676
677 def convert_build_dict(build):
Quinten Yearsleya563d722017-12-11 16:36:54 -0800678 """Extracts some of the information from one build dict."""
679 parameters = json.loads(build.get('parameters_json', '{}')) or {}
qyearsley53f48a12016-09-01 10:45:13 -0700680 return {
681 'buildbucket_id': build.get('id'),
qyearsley53f48a12016-09-01 10:45:13 -0700682 'bucket': build.get('bucket'),
Quinten Yearsleya563d722017-12-11 16:36:54 -0800683 'builder_name': parameters.get('builder_name'),
684 'created_ts': build.get('created_ts'),
685 'experimental': build.get('experimental'),
qyearsley53f48a12016-09-01 10:45:13 -0700686 'failure_reason': build.get('failure_reason'),
Quinten Yearsleya563d722017-12-11 16:36:54 -0800687 'result': build.get('result'),
688 'status': build.get('status'),
689 'tags': build.get('tags'),
qyearsley53f48a12016-09-01 10:45:13 -0700690 'url': build.get('url'),
691 }
692
693 converted = []
694 for _, build in sorted(builds.items()):
695 converted.append(convert_build_dict(build))
696 write_json(output_file, converted)
697
698
Aaron Gable13101a62018-02-09 13:20:41 -0800699def print_stats(args):
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000700 """Prints statistics about the change to the user."""
701 # --no-ext-diff is broken in some versions of Git, so try to work around
702 # this by overriding the environment (but there is still a problem if the
703 # git config key "diff.external" is used).
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000704 env = GetNoGitPagerEnv()
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000705 if 'GIT_EXTERNAL_DIFF' in env:
706 del env['GIT_EXTERNAL_DIFF']
iannucci@chromium.org79540052012-10-19 23:15:26 +0000707
szager@chromium.orgd057f9a2014-05-29 21:09:36 +0000708 try:
709 stdout = sys.stdout.fileno()
710 except AttributeError:
711 stdout = None
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000712 return subprocess2.call(
Aaron Gable13101a62018-02-09 13:20:41 -0800713 ['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] + args,
szager@chromium.orgd057f9a2014-05-29 21:09:36 +0000714 stdout=stdout, env=env)
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000715
716
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000717class BuildbucketResponseException(Exception):
718 pass
719
720
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000721class Settings(object):
722 def __init__(self):
723 self.default_server = None
724 self.cc = None
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000725 self.root = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000726 self.tree_status_url = None
727 self.viewvc_url = None
728 self.updated = False
ukai@chromium.orge8077812012-02-03 03:41:46 +0000729 self.is_gerrit = None
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000730 self.squash_gerrit_uploads = None
tandrii@chromium.org28253532016-04-14 13:46:56 +0000731 self.gerrit_skip_ensure_authenticated = None
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000732 self.git_editor = None
sheyang@chromium.org152cf832014-06-11 21:37:49 +0000733 self.project = None
kjellander@chromium.org6abc6522014-12-02 07:34:49 +0000734 self.force_https_commit_url = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000735
736 def LazyUpdateIfNeeded(self):
737 """Updates the settings from a codereview.settings file, if available."""
738 if not self.updated:
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000739 # The only value that actually changes the behavior is
740 # autoupdate = "false". Everything else means "true".
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +0000741 autoupdate = RunGit(['config', 'rietveld.autoupdate'],
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000742 error_ok=True
743 ).strip().lower()
744
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000745 cr_settings_file = FindCodereviewSettingsFile()
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000746 if autoupdate != 'false' and cr_settings_file:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000747 LoadCodereviewSettingsFromFile(cr_settings_file)
748 self.updated = True
749
750 def GetDefaultServerUrl(self, error_ok=False):
751 if not self.default_server:
752 self.LazyUpdateIfNeeded()
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +0000753 self.default_server = gclient_utils.UpgradeToHttps(
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000754 self._GetRietveldConfig('server', error_ok=True))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000755 if error_ok:
756 return self.default_server
757 if not self.default_server:
758 error_message = ('Could not find settings file. You must configure '
759 'your review setup by running "git cl config".')
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +0000760 self.default_server = gclient_utils.UpgradeToHttps(
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000761 self._GetRietveldConfig('server', error_message=error_message))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000762 return self.default_server
763
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000764 @staticmethod
765 def GetRelativeRoot():
766 return RunGit(['rev-parse', '--show-cdup']).strip()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000767
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000768 def GetRoot(self):
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000769 if self.root is None:
770 self.root = os.path.abspath(self.GetRelativeRoot())
771 return self.root
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000772
szager@chromium.org151ebcf2016-03-09 01:08:25 +0000773 def GetGitMirror(self, remote='origin'):
774 """If this checkout is from a local git mirror, return a Mirror object."""
szager@chromium.org81593742016-03-09 20:27:58 +0000775 local_url = RunGit(['config', '--get', 'remote.%s.url' % remote]).strip()
szager@chromium.org151ebcf2016-03-09 01:08:25 +0000776 if not os.path.isdir(local_url):
777 return None
778 git_cache.Mirror.SetCachePath(os.path.dirname(local_url))
779 remote_url = git_cache.Mirror.CacheDirToUrl(local_url)
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100780 # Use the /dev/null print_func to avoid terminal spew.
Andrii Shyshkalov18975322017-01-25 16:44:13 +0100781 mirror = git_cache.Mirror(remote_url, print_func=lambda *args: None)
szager@chromium.org151ebcf2016-03-09 01:08:25 +0000782 if mirror.exists():
783 return mirror
784 return None
785
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000786 def GetTreeStatusUrl(self, error_ok=False):
787 if not self.tree_status_url:
788 error_message = ('You must configure your tree status URL by running '
789 '"git cl config".')
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000790 self.tree_status_url = self._GetRietveldConfig(
791 'tree-status-url', error_ok=error_ok, error_message=error_message)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000792 return self.tree_status_url
793
794 def GetViewVCUrl(self):
795 if not self.viewvc_url:
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000796 self.viewvc_url = self._GetRietveldConfig('viewvc-url', error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000797 return self.viewvc_url
798
rmistry@google.com90752582014-01-14 21:04:50 +0000799 def GetBugPrefix(self):
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000800 return self._GetRietveldConfig('bug-prefix', error_ok=True)
rmistry@google.com90752582014-01-14 21:04:50 +0000801
rmistry@google.com78948ed2015-07-08 23:09:57 +0000802 def GetIsSkipDependencyUpload(self, branch_name):
803 """Returns true if specified branch should skip dep uploads."""
804 return self._GetBranchConfig(branch_name, 'skip-deps-uploads',
805 error_ok=True)
806
rmistry@google.com5626a922015-02-26 14:03:30 +0000807 def GetRunPostUploadHook(self):
808 run_post_upload_hook = self._GetRietveldConfig(
809 'run-post-upload-hook', error_ok=True)
810 return run_post_upload_hook == "True"
811
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000812 def GetDefaultCCList(self):
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000813 return self._GetRietveldConfig('cc', error_ok=True)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000814
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000815 def GetDefaultPrivateFlag(self):
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000816 return self._GetRietveldConfig('private', error_ok=True)
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000817
ukai@chromium.orge8077812012-02-03 03:41:46 +0000818 def GetIsGerrit(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700819 """Return true if this repo is associated with gerrit code review system."""
ukai@chromium.orge8077812012-02-03 03:41:46 +0000820 if self.is_gerrit is None:
Aaron Gable9b465272017-05-12 10:53:51 -0700821 self.is_gerrit = (
822 self._GetConfig('gerrit.host', error_ok=True).lower() == 'true')
ukai@chromium.orge8077812012-02-03 03:41:46 +0000823 return self.is_gerrit
824
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000825 def GetSquashGerritUploads(self):
826 """Return true if uploads to Gerrit should be squashed by default."""
827 if self.squash_gerrit_uploads is None:
tandriia60502f2016-06-20 02:01:53 -0700828 self.squash_gerrit_uploads = self.GetSquashGerritUploadsOverride()
829 if self.squash_gerrit_uploads is None:
830 # Default is squash now (http://crbug.com/611892#c23).
831 self.squash_gerrit_uploads = not (
832 RunGit(['config', '--bool', 'gerrit.squash-uploads'],
833 error_ok=True).strip() == 'false')
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000834 return self.squash_gerrit_uploads
835
tandriia60502f2016-06-20 02:01:53 -0700836 def GetSquashGerritUploadsOverride(self):
837 """Return True or False if codereview.settings should be overridden.
838
839 Returns None if no override has been defined.
840 """
841 # See also http://crbug.com/611892#c23
842 result = RunGit(['config', '--bool', 'gerrit.override-squash-uploads'],
843 error_ok=True).strip()
844 if result == 'true':
845 return True
846 if result == 'false':
847 return False
848 return None
849
tandrii@chromium.org28253532016-04-14 13:46:56 +0000850 def GetGerritSkipEnsureAuthenticated(self):
851 """Return True if EnsureAuthenticated should not be done for Gerrit
852 uploads."""
853 if self.gerrit_skip_ensure_authenticated is None:
854 self.gerrit_skip_ensure_authenticated = (
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000855 RunGit(['config', '--bool', 'gerrit.skip-ensure-authenticated'],
tandrii@chromium.org28253532016-04-14 13:46:56 +0000856 error_ok=True).strip() == 'true')
857 return self.gerrit_skip_ensure_authenticated
858
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000859 def GetGitEditor(self):
860 """Return the editor specified in the git config, or None if none is."""
861 if self.git_editor is None:
862 self.git_editor = self._GetConfig('core.editor', error_ok=True)
863 return self.git_editor or None
864
thestig@chromium.org44202a22014-03-11 19:22:18 +0000865 def GetLintRegex(self):
866 return (self._GetRietveldConfig('cpplint-regex', error_ok=True) or
867 DEFAULT_LINT_REGEX)
868
869 def GetLintIgnoreRegex(self):
870 return (self._GetRietveldConfig('cpplint-ignore-regex', error_ok=True) or
871 DEFAULT_LINT_IGNORE_REGEX)
872
sheyang@chromium.org152cf832014-06-11 21:37:49 +0000873 def GetProject(self):
874 if not self.project:
875 self.project = self._GetRietveldConfig('project', error_ok=True)
876 return self.project
877
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000878 def _GetRietveldConfig(self, param, **kwargs):
879 return self._GetConfig('rietveld.' + param, **kwargs)
880
rmistry@google.com78948ed2015-07-08 23:09:57 +0000881 def _GetBranchConfig(self, branch_name, param, **kwargs):
882 return self._GetConfig('branch.' + branch_name + '.' + param, **kwargs)
883
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000884 def _GetConfig(self, param, **kwargs):
885 self.LazyUpdateIfNeeded()
886 return RunGit(['config', param], **kwargs).strip()
887
888
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100889@contextlib.contextmanager
890def _get_gerrit_project_config_file(remote_url):
891 """Context manager to fetch and store Gerrit's project.config from
892 refs/meta/config branch and store it in temp file.
893
894 Provides a temporary filename or None if there was error.
895 """
896 error, _ = RunGitWithCode([
897 'fetch', remote_url,
898 '+refs/meta/config:refs/git_cl/meta/config'])
899 if error:
900 # Ref doesn't exist or isn't accessible to current user.
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700901 print('WARNING: Failed to fetch project config for %s: %s' %
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100902 (remote_url, error))
903 yield None
904 return
905
906 error, project_config_data = RunGitWithCode(
907 ['show', 'refs/git_cl/meta/config:project.config'])
908 if error:
909 print('WARNING: project.config file not found')
910 yield None
911 return
912
913 with gclient_utils.temporary_directory() as tempdir:
914 project_config_file = os.path.join(tempdir, 'project.config')
915 gclient_utils.FileWrite(project_config_file, project_config_data)
916 yield project_config_file
917
918
919def _is_git_numberer_enabled(remote_url, remote_ref):
920 """Returns True if Git Numberer is enabled on this ref."""
921 # TODO(tandrii): this should be deleted once repos below are 100% on Gerrit.
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +0100922 KNOWN_PROJECTS_WHITELIST = [
923 'chromium/src',
924 'external/webrtc',
925 'v8/v8',
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +0100926 'infra/experimental',
Edward Lemur32357d32017-09-11 20:22:45 +0200927 # For webrtc.googlesource.com/src.
928 'src',
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +0100929 ]
930
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100931 assert remote_ref and remote_ref.startswith('refs/'), remote_ref
932 url_parts = urlparse.urlparse(remote_url)
933 project_name = url_parts.path.lstrip('/').rstrip('git./')
934 for known in KNOWN_PROJECTS_WHITELIST:
935 if project_name.endswith(known):
936 break
937 else:
938 # Early exit to avoid extra fetches for repos that aren't using Git
939 # Numberer.
940 return False
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +0100941
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100942 with _get_gerrit_project_config_file(remote_url) as project_config_file:
943 if project_config_file is None:
944 # Failed to fetch project.config, which shouldn't happen on open source
945 # repos KNOWN_PROJECTS_WHITELIST.
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +0100946 return False
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100947 def get_opts(x):
948 code, out = RunGitWithCode(
949 ['config', '-f', project_config_file, '--get-all',
950 'plugin.git-numberer.validate-%s-refglob' % x])
951 if code == 0:
952 return out.strip().splitlines()
953 return []
954 enabled, disabled = map(get_opts, ['enabled', 'disabled'])
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +0100955
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100956 logging.info('validator config enabled %s disabled %s refglobs for '
957 '(this ref: %s)', enabled, disabled, remote_ref)
Andrii Shyshkalov351c61d2017-01-21 20:40:16 +0000958
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100959 def match_refglobs(refglobs):
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +0100960 for refglob in refglobs:
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100961 if remote_ref == refglob or fnmatch.fnmatch(remote_ref, refglob):
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +0100962 return True
963 return False
964
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100965 if match_refglobs(disabled):
966 return False
967 return match_refglobs(enabled)
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +0100968
969
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000970def ShortBranchName(branch):
971 """Convert a name like 'refs/heads/foo' to just 'foo'."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000972 return branch.replace('refs/heads/', '', 1)
973
974
975def GetCurrentBranchRef():
976 """Returns branch ref (e.g., refs/heads/master) or None."""
977 return RunGit(['symbolic-ref', 'HEAD'],
978 stderr=subprocess2.VOID, error_ok=True).strip() or None
979
980
981def GetCurrentBranch():
982 """Returns current branch or None.
983
984 For refs/heads/* branches, returns just last part. For others, full ref.
985 """
986 branchref = GetCurrentBranchRef()
987 if branchref:
988 return ShortBranchName(branchref)
989 return None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000990
991
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000992class _CQState(object):
993 """Enum for states of CL with respect to Commit Queue."""
994 NONE = 'none'
995 DRY_RUN = 'dry_run'
996 COMMIT = 'commit'
997
998 ALL_STATES = [NONE, DRY_RUN, COMMIT]
999
1000
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001001class _ParsedIssueNumberArgument(object):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +02001002 def __init__(self, issue=None, patchset=None, hostname=None, codereview=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001003 self.issue = issue
1004 self.patchset = patchset
1005 self.hostname = hostname
Andrii Shyshkalov90f31922017-04-10 16:10:21 +02001006 assert codereview in (None, 'rietveld', 'gerrit')
1007 self.codereview = codereview
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001008
1009 @property
1010 def valid(self):
1011 return self.issue is not None
1012
1013
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001014def ParseIssueNumberArgument(arg, codereview=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001015 """Parses the issue argument and returns _ParsedIssueNumberArgument."""
1016 fail_result = _ParsedIssueNumberArgument()
1017
1018 if arg.isdigit():
Aaron Gableaee6c852017-06-26 12:49:01 -07001019 return _ParsedIssueNumberArgument(issue=int(arg), codereview=codereview)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001020 if not arg.startswith('http'):
1021 return fail_result
Aaron Gableaee6c852017-06-26 12:49:01 -07001022
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001023 url = gclient_utils.UpgradeToHttps(arg)
1024 try:
1025 parsed_url = urlparse.urlparse(url)
1026 except ValueError:
1027 return fail_result
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02001028
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001029 if codereview is not None:
1030 parsed = _CODEREVIEW_IMPLEMENTATIONS[codereview].ParseIssueURL(parsed_url)
1031 return parsed or fail_result
1032
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02001033 results = {}
1034 for name, cls in _CODEREVIEW_IMPLEMENTATIONS.iteritems():
1035 parsed = cls.ParseIssueURL(parsed_url)
1036 if parsed is not None:
1037 results[name] = parsed
1038
1039 if not results:
1040 return fail_result
1041 if len(results) == 1:
1042 return results.values()[0]
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001043
1044 if parsed_url.netloc and parsed_url.netloc.split('.')[0].endswith('-review'):
1045 # This is likely Gerrit.
1046 return results['gerrit']
1047 # Choose Rietveld as before if URL can parsed by either.
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02001048 return results['rietveld']
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001049
1050
Aaron Gablea45ee112016-11-22 15:14:38 -08001051class GerritChangeNotExists(Exception):
tandriic2405f52016-10-10 08:13:15 -07001052 def __init__(self, issue, url):
1053 self.issue = issue
1054 self.url = url
Aaron Gablea45ee112016-11-22 15:14:38 -08001055 super(GerritChangeNotExists, self).__init__()
tandriic2405f52016-10-10 08:13:15 -07001056
1057 def __str__(self):
Aaron Gablea45ee112016-11-22 15:14:38 -08001058 return 'change %s at %s does not exist or you have no access to it' % (
tandriic2405f52016-10-10 08:13:15 -07001059 self.issue, self.url)
1060
1061
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001062_CommentSummary = collections.namedtuple(
1063 '_CommentSummary', ['date', 'message', 'sender',
1064 # TODO(tandrii): these two aren't known in Gerrit.
1065 'approval', 'disapproval'])
1066
1067
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001068class Changelist(object):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001069 """Changelist works with one changelist in local branch.
1070
1071 Supports two codereview backends: Rietveld or Gerrit, selected at object
1072 creation.
1073
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00001074 Notes:
1075 * Not safe for concurrent multi-{thread,process} use.
1076 * Caches values from current branch. Therefore, re-use after branch change
tandrii5d48c322016-08-18 16:19:37 -07001077 with great care.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001078 """
1079
1080 def __init__(self, branchref=None, issue=None, codereview=None, **kwargs):
1081 """Create a new ChangeList instance.
1082
1083 If issue is given, the codereview must be given too.
1084
1085 If `codereview` is given, it must be 'rietveld' or 'gerrit'.
1086 Otherwise, it's decided based on current configuration of the local branch,
1087 with default being 'rietveld' for backwards compatibility.
1088 See _load_codereview_impl for more details.
1089
1090 **kwargs will be passed directly to codereview implementation.
1091 """
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001092 # Poke settings so we get the "configure your server" message if necessary.
maruel@chromium.org379d07a2011-11-30 14:58:10 +00001093 global settings
1094 if not settings:
1095 # Happens when git_cl.py is used as a utility library.
1096 settings = Settings()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001097
1098 if issue:
1099 assert codereview, 'codereview must be known, if issue is known'
1100
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001101 self.branchref = branchref
1102 if self.branchref:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00001103 assert branchref.startswith('refs/heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001104 self.branch = ShortBranchName(self.branchref)
1105 else:
1106 self.branch = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001107 self.upstream_branch = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001108 self.lookedup_issue = False
1109 self.issue = issue or None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001110 self.has_description = False
1111 self.description = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001112 self.lookedup_patchset = False
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001113 self.patchset = None
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001114 self.cc = None
Daniel Cheng7227d212017-11-17 08:12:37 -08001115 self.more_cc = []
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001116 self._remote = None
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001117
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001118 self._codereview_impl = None
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001119 self._codereview = None
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001120 self._load_codereview_impl(codereview, **kwargs)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001121 assert self._codereview_impl
1122 assert self._codereview in _CODEREVIEW_IMPLEMENTATIONS
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001123
1124 def _load_codereview_impl(self, codereview=None, **kwargs):
1125 if codereview:
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001126 assert codereview in _CODEREVIEW_IMPLEMENTATIONS
1127 cls = _CODEREVIEW_IMPLEMENTATIONS[codereview]
1128 self._codereview = codereview
1129 self._codereview_impl = cls(self, **kwargs)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001130 return
1131
1132 # Automatic selection based on issue number set for a current branch.
1133 # Rietveld takes precedence over Gerrit.
1134 assert not self.issue
1135 # Whether we find issue or not, we are doing the lookup.
1136 self.lookedup_issue = True
tandrii5d48c322016-08-18 16:19:37 -07001137 if self.GetBranch():
1138 for codereview, cls in _CODEREVIEW_IMPLEMENTATIONS.iteritems():
1139 issue = _git_get_branch_config_value(
1140 cls.IssueConfigKey(), value_type=int, branch=self.GetBranch())
1141 if issue:
1142 self._codereview = codereview
1143 self._codereview_impl = cls(self, **kwargs)
1144 self.issue = int(issue)
1145 return
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001146
1147 # No issue is set for this branch, so decide based on repo-wide settings.
1148 return self._load_codereview_impl(
1149 codereview='gerrit' if settings.GetIsGerrit() else 'rietveld',
1150 **kwargs)
1151
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001152 def IsGerrit(self):
1153 return self._codereview == 'gerrit'
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001154
1155 def GetCCList(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001156 """Returns the users cc'd on this CL.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001157
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001158 The return value is a string suitable for passing to git cl with the --cc
1159 flag.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001160 """
1161 if self.cc is None:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001162 base_cc = settings.GetDefaultCCList()
Daniel Cheng7227d212017-11-17 08:12:37 -08001163 more_cc = ','.join(self.more_cc)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001164 self.cc = ','.join(filter(None, (base_cc, more_cc))) or ''
1165 return self.cc
1166
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001167 def GetCCListWithoutDefault(self):
1168 """Return the users cc'd on this CL excluding default ones."""
1169 if self.cc is None:
Daniel Cheng7227d212017-11-17 08:12:37 -08001170 self.cc = ','.join(self.more_cc)
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001171 return self.cc
1172
Daniel Cheng7227d212017-11-17 08:12:37 -08001173 def ExtendCC(self, more_cc):
1174 """Extends the list of users to cc on this CL based on the changed files."""
1175 self.more_cc.extend(more_cc)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001176
1177 def GetBranch(self):
1178 """Returns the short branch name, e.g. 'master'."""
1179 if not self.branch:
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001180 branchref = GetCurrentBranchRef()
szager@chromium.orgd62c61f2014-10-20 22:33:21 +00001181 if not branchref:
1182 return None
1183 self.branchref = branchref
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001184 self.branch = ShortBranchName(self.branchref)
1185 return self.branch
1186
1187 def GetBranchRef(self):
1188 """Returns the full branch name, e.g. 'refs/heads/master'."""
1189 self.GetBranch() # Poke the lazy loader.
1190 return self.branchref
1191
tandrii@chromium.org534f67a2016-04-07 18:47:05 +00001192 def ClearBranch(self):
1193 """Clears cached branch data of this object."""
1194 self.branch = self.branchref = None
1195
tandrii5d48c322016-08-18 16:19:37 -07001196 def _GitGetBranchConfigValue(self, key, default=None, **kwargs):
1197 assert 'branch' not in kwargs, 'this CL branch is used automatically'
1198 kwargs['branch'] = self.GetBranch()
1199 return _git_get_branch_config_value(key, default, **kwargs)
1200
1201 def _GitSetBranchConfigValue(self, key, value, **kwargs):
1202 assert 'branch' not in kwargs, 'this CL branch is used automatically'
1203 assert self.GetBranch(), (
1204 'this CL must have an associated branch to %sset %s%s' %
1205 ('un' if value is None else '',
1206 key,
1207 '' if value is None else ' to %r' % value))
1208 kwargs['branch'] = self.GetBranch()
1209 return _git_set_branch_config_value(key, value, **kwargs)
1210
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001211 @staticmethod
1212 def FetchUpstreamTuple(branch):
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001213 """Returns a tuple containing remote and remote ref,
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001214 e.g. 'origin', 'refs/heads/master'
1215 """
1216 remote = '.'
tandrii5d48c322016-08-18 16:19:37 -07001217 upstream_branch = _git_get_branch_config_value('merge', branch=branch)
1218
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001219 if upstream_branch:
tandrii5d48c322016-08-18 16:19:37 -07001220 remote = _git_get_branch_config_value('remote', branch=branch)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001221 else:
bauerb@chromium.orgade368c2011-03-01 08:57:50 +00001222 upstream_branch = RunGit(['config', 'rietveld.upstream-branch'],
1223 error_ok=True).strip()
1224 if upstream_branch:
1225 remote = RunGit(['config', 'rietveld.upstream-remote']).strip()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001226 else:
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001227 # Else, try to guess the origin remote.
1228 remote_branches = RunGit(['branch', '-r']).split()
1229 if 'origin/master' in remote_branches:
1230 # Fall back on origin/master if it exits.
1231 remote = 'origin'
1232 upstream_branch = 'refs/heads/master'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001233 else:
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001234 DieWithError(
1235 'Unable to determine default branch to diff against.\n'
1236 'Either pass complete "git diff"-style arguments, like\n'
1237 ' git cl upload origin/master\n'
1238 'or verify this branch is set up to track another \n'
1239 '(via the --track argument to "git checkout -b ...").')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001240
1241 return remote, upstream_branch
1242
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001243 def GetCommonAncestorWithUpstream(self):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001244 upstream_branch = self.GetUpstreamBranch()
1245 if not BranchExists(upstream_branch):
1246 DieWithError('The upstream for the current branch (%s) does not exist '
1247 'anymore.\nPlease fix it and try again.' % self.GetBranch())
iannucci@chromium.org9e849272014-04-04 00:31:55 +00001248 return git_common.get_or_create_merge_base(self.GetBranch(),
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001249 upstream_branch)
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001250
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001251 def GetUpstreamBranch(self):
1252 if self.upstream_branch is None:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001253 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001254 if remote is not '.':
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001255 upstream_branch = upstream_branch.replace('refs/heads/',
1256 'refs/remotes/%s/' % remote)
1257 upstream_branch = upstream_branch.replace('refs/branch-heads/',
1258 'refs/remotes/branch-heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001259 self.upstream_branch = upstream_branch
1260 return self.upstream_branch
1261
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001262 def GetRemoteBranch(self):
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001263 if not self._remote:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001264 remote, branch = None, self.GetBranch()
1265 seen_branches = set()
1266 while branch not in seen_branches:
1267 seen_branches.add(branch)
1268 remote, branch = self.FetchUpstreamTuple(branch)
1269 branch = ShortBranchName(branch)
1270 if remote != '.' or branch.startswith('refs/remotes'):
1271 break
1272 else:
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001273 remotes = RunGit(['remote'], error_ok=True).split()
1274 if len(remotes) == 1:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001275 remote, = remotes
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001276 elif 'origin' in remotes:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001277 remote = 'origin'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001278 logging.warn('Could not determine which remote this change is '
1279 'associated with, so defaulting to "%s".' % self._remote)
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001280 else:
1281 logging.warn('Could not determine which remote this change is '
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001282 'associated with.')
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001283 branch = 'HEAD'
1284 if branch.startswith('refs/remotes'):
1285 self._remote = (remote, branch)
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001286 elif branch.startswith('refs/branch-heads/'):
1287 self._remote = (remote, branch.replace('refs/', 'refs/remotes/'))
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001288 else:
1289 self._remote = (remote, 'refs/remotes/%s/%s' % (remote, branch))
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001290 return self._remote
1291
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001292 def GitSanityChecks(self, upstream_git_obj):
1293 """Checks git repo status and ensures diff is from local commits."""
1294
sbc@chromium.org79706062015-01-14 21:18:12 +00001295 if upstream_git_obj is None:
1296 if self.GetBranch() is None:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001297 print('ERROR: Unable to determine current branch (detached HEAD?)',
vapiera7fbd5a2016-06-16 09:17:49 -07001298 file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001299 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001300 print('ERROR: No upstream branch.', file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001301 return False
1302
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001303 # Verify the commit we're diffing against is in our current branch.
1304 upstream_sha = RunGit(['rev-parse', '--verify', upstream_git_obj]).strip()
1305 common_ancestor = RunGit(['merge-base', upstream_sha, 'HEAD']).strip()
1306 if upstream_sha != common_ancestor:
vapiera7fbd5a2016-06-16 09:17:49 -07001307 print('ERROR: %s is not in the current branch. You may need to rebase '
1308 'your tracking branch' % upstream_sha, file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001309 return False
1310
1311 # List the commits inside the diff, and verify they are all local.
1312 commits_in_diff = RunGit(
1313 ['rev-list', '^%s' % upstream_sha, 'HEAD']).splitlines()
1314 code, remote_branch = RunGitWithCode(['config', 'gitcl.remotebranch'])
1315 remote_branch = remote_branch.strip()
1316 if code != 0:
1317 _, remote_branch = self.GetRemoteBranch()
1318
1319 commits_in_remote = RunGit(
1320 ['rev-list', '^%s' % upstream_sha, remote_branch]).splitlines()
1321
1322 common_commits = set(commits_in_diff) & set(commits_in_remote)
1323 if common_commits:
vapiera7fbd5a2016-06-16 09:17:49 -07001324 print('ERROR: Your diff contains %d commits already in %s.\n'
1325 'Run "git log --oneline %s..HEAD" to get a list of commits in '
1326 'the diff. If you are using a custom git flow, you can override'
1327 ' the reference used for this check with "git config '
1328 'gitcl.remotebranch <git-ref>".' % (
1329 len(common_commits), remote_branch, upstream_git_obj),
1330 file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001331 return False
1332 return True
1333
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001334 def GetGitBaseUrlFromConfig(self):
sheyang@chromium.orga656e702014-05-15 20:43:05 +00001335 """Return the configured base URL from branch.<branchname>.baseurl.
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001336
1337 Returns None if it is not set.
1338 """
tandrii5d48c322016-08-18 16:19:37 -07001339 return self._GitGetBranchConfigValue('base-url')
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001340
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001341 def GetRemoteUrl(self):
1342 """Return the configured remote URL, e.g. 'git://example.org/foo.git/'.
1343
1344 Returns None if there is no remote.
1345 """
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001346 remote, _ = self.GetRemoteBranch()
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001347 url = RunGit(['config', 'remote.%s.url' % remote], error_ok=True).strip()
1348
1349 # If URL is pointing to a local directory, it is probably a git cache.
1350 if os.path.isdir(url):
1351 url = RunGit(['config', 'remote.%s.url' % remote],
1352 error_ok=True,
1353 cwd=url).strip()
1354 return url
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001355
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001356 def GetIssue(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001357 """Returns the issue number as a int or None if not set."""
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001358 if self.issue is None and not self.lookedup_issue:
tandrii5d48c322016-08-18 16:19:37 -07001359 self.issue = self._GitGetBranchConfigValue(
1360 self._codereview_impl.IssueConfigKey(), value_type=int)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001361 self.lookedup_issue = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001362 return self.issue
1363
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001364 def GetIssueURL(self):
1365 """Get the URL for a particular issue."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001366 issue = self.GetIssue()
1367 if not issue:
dbeam@chromium.org015fd3d2013-06-18 19:02:50 +00001368 return None
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001369 return '%s/%s' % (self._codereview_impl.GetCodereviewServer(), issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001370
Andrii Shyshkalov31863012017-02-08 11:35:12 +01001371 def GetDescription(self, pretty=False, force=False):
1372 if not self.has_description or force:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001373 if self.GetIssue():
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001374 self.description = self._codereview_impl.FetchDescription(force=force)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001375 self.has_description = True
1376 if pretty:
Asanka Herath7c61dcb2016-12-14 13:01:58 -05001377 # Set width to 72 columns + 2 space indent.
1378 wrapper = textwrap.TextWrapper(width=74, replace_whitespace=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001379 wrapper.initial_indent = wrapper.subsequent_indent = ' '
Asanka Herath7c61dcb2016-12-14 13:01:58 -05001380 lines = self.description.splitlines()
1381 return '\n'.join([wrapper.fill(line) for line in lines])
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001382 return self.description
1383
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001384 def GetDescriptionFooters(self):
1385 """Returns (non_footer_lines, footers) for the commit message.
1386
1387 Returns:
1388 non_footer_lines (list(str)) - Simple list of description lines without
1389 any footer. The lines do not contain newlines, nor does the list contain
1390 the empty line between the message and the footers.
1391 footers (list(tuple(KEY, VALUE))) - List of parsed footers, e.g.
1392 [("Change-Id", "Ideadbeef...."), ...]
1393 """
1394 raw_description = self.GetDescription()
1395 msg_lines, _, footers = git_footers.split_footers(raw_description)
1396 if footers:
1397 msg_lines = msg_lines[:len(msg_lines)-1]
1398 return msg_lines, footers
1399
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001400 def GetPatchset(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001401 """Returns the patchset number as a int or None if not set."""
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001402 if self.patchset is None and not self.lookedup_patchset:
tandrii5d48c322016-08-18 16:19:37 -07001403 self.patchset = self._GitGetBranchConfigValue(
1404 self._codereview_impl.PatchsetConfigKey(), value_type=int)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001405 self.lookedup_patchset = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001406 return self.patchset
1407
1408 def SetPatchset(self, patchset):
tandrii5d48c322016-08-18 16:19:37 -07001409 """Set this branch's patchset. If patchset=0, clears the patchset."""
1410 assert self.GetBranch()
1411 if not patchset:
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001412 self.patchset = None
tandrii5d48c322016-08-18 16:19:37 -07001413 else:
1414 self.patchset = int(patchset)
1415 self._GitSetBranchConfigValue(
1416 self._codereview_impl.PatchsetConfigKey(), self.patchset)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001417
tandrii@chromium.orga342c922016-03-16 07:08:25 +00001418 def SetIssue(self, issue=None):
tandrii5d48c322016-08-18 16:19:37 -07001419 """Set this branch's issue. If issue isn't given, clears the issue."""
1420 assert self.GetBranch()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001421 if issue:
tandrii5d48c322016-08-18 16:19:37 -07001422 issue = int(issue)
1423 self._GitSetBranchConfigValue(
1424 self._codereview_impl.IssueConfigKey(), issue)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001425 self.issue = issue
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001426 codereview_server = self._codereview_impl.GetCodereviewServer()
1427 if codereview_server:
tandrii5d48c322016-08-18 16:19:37 -07001428 self._GitSetBranchConfigValue(
1429 self._codereview_impl.CodereviewServerConfigKey(),
1430 codereview_server)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001431 else:
tandrii5d48c322016-08-18 16:19:37 -07001432 # Reset all of these just to be clean.
1433 reset_suffixes = [
1434 'last-upload-hash',
1435 self._codereview_impl.IssueConfigKey(),
1436 self._codereview_impl.PatchsetConfigKey(),
1437 self._codereview_impl.CodereviewServerConfigKey(),
1438 ] + self._PostUnsetIssueProperties()
1439 for prop in reset_suffixes:
1440 self._GitSetBranchConfigValue(prop, None, error_ok=True)
Aaron Gableca01e2c2017-07-19 11:16:02 -07001441 msg = RunGit(['log', '-1', '--format=%B']).strip()
1442 if msg and git_footers.get_footer_change_id(msg):
1443 print('WARNING: The change patched into this branch has a Change-Id. '
1444 'Removing it.')
1445 RunGit(['commit', '--amend', '-m',
1446 git_footers.remove_footer(msg, 'Change-Id')])
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001447 self.issue = None
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001448 self.patchset = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001449
dnjba1b0f32016-09-02 12:37:42 -07001450 def GetChange(self, upstream_branch, author, local_description=False):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001451 if not self.GitSanityChecks(upstream_branch):
1452 DieWithError('\nGit sanity check failure')
1453
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001454 root = settings.GetRelativeRoot()
bratell@opera.comf267b0e2013-05-02 09:11:43 +00001455 if not root:
1456 root = '.'
bauerb@chromium.org512f1ef2011-04-20 15:17:57 +00001457 absroot = os.path.abspath(root)
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001458
1459 # We use the sha1 of HEAD as a name of this change.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001460 name = RunGitWithCode(['rev-parse', 'HEAD'])[1].strip()
bauerb@chromium.org512f1ef2011-04-20 15:17:57 +00001461 # Need to pass a relative path for msysgit.
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001462 try:
maruel@chromium.org80a9ef12011-12-13 20:44:10 +00001463 files = scm.GIT.CaptureStatus([root], '.', upstream_branch)
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001464 except subprocess2.CalledProcessError:
1465 DieWithError(
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001466 ('\nFailed to diff against upstream branch %s\n\n'
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001467 'This branch probably doesn\'t exist anymore. To reset the\n'
1468 'tracking branch, please run\n'
stip7a3dd352016-09-22 17:32:28 -07001469 ' git branch --set-upstream-to origin/master %s\n'
1470 'or replace origin/master with the relevant branch') %
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001471 (upstream_branch, self.GetBranch()))
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001472
maruel@chromium.org52424302012-08-29 15:14:30 +00001473 issue = self.GetIssue()
1474 patchset = self.GetPatchset()
dnjba1b0f32016-09-02 12:37:42 -07001475 if issue and not local_description:
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001476 description = self.GetDescription()
1477 else:
1478 # If the change was never uploaded, use the log messages of all commits
1479 # up to the branch point, as git cl upload will prefill the description
1480 # with these log messages.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001481 args = ['log', '--pretty=format:%s%n%n%b', '%s...' % (upstream_branch)]
1482 description = RunGitWithCode(args)[1].strip()
maruel@chromium.org03b3bdc2011-06-14 13:04:12 +00001483
1484 if not author:
maruel@chromium.org13f623c2011-07-22 16:02:23 +00001485 author = RunGit(['config', 'user.email']).strip() or None
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001486 return presubmit_support.GitChange(
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001487 name,
1488 description,
1489 absroot,
1490 files,
1491 issue,
1492 patchset,
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001493 author,
1494 upstream=upstream_branch)
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001495
dsansomee2d6fd92016-09-08 00:10:47 -07001496 def UpdateDescription(self, description, force=False):
Andrii Shyshkalov83051152017-02-07 23:47:29 +01001497 self._codereview_impl.UpdateDescriptionRemote(description, force=force)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001498 self.description = description
Andrii Shyshkalov83051152017-02-07 23:47:29 +01001499 self.has_description = True
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001500
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001501 def UpdateDescriptionFooters(self, description_lines, footers, force=False):
1502 """Sets the description for this CL remotely.
1503
1504 You can get description_lines and footers with GetDescriptionFooters.
1505
1506 Args:
1507 description_lines (list(str)) - List of CL description lines without
1508 newline characters.
1509 footers (list(tuple(KEY, VALUE))) - List of footers, as returned by
1510 GetDescriptionFooters. Key must conform to the git footers format (i.e.
1511 `List-Of-Tokens`). It will be case-normalized so that each token is
1512 title-cased.
1513 """
1514 new_description = '\n'.join(description_lines)
1515 if footers:
1516 new_description += '\n'
1517 for k, v in footers:
1518 foot = '%s: %s' % (git_footers.normalize_name(k), v)
1519 if not git_footers.FOOTER_PATTERN.match(foot):
1520 raise ValueError('Invalid footer %r' % foot)
1521 new_description += foot + '\n'
1522 self.UpdateDescription(new_description, force)
1523
Edward Lesmes8e282792018-04-03 18:50:29 -04001524 def RunHook(self, committing, may_prompt, verbose, change, parallel):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001525 """Calls sys.exit() if the hook fails; returns a HookResults otherwise."""
1526 try:
1527 return presubmit_support.DoPresubmitChecks(change, committing,
1528 verbose=verbose, output_stream=sys.stdout, input_stream=sys.stdin,
1529 default_presubmit=None, may_prompt=may_prompt,
Edward Lesmes8e282792018-04-03 18:50:29 -04001530 gerrit_obj=self._codereview_impl.GetGerritObjForPresubmit(),
1531 parallel=parallel)
vapierfd77ac72016-06-16 08:33:57 -07001532 except presubmit_support.PresubmitFailure as e:
Aaron Gable5d5f22c2018-02-02 09:12:41 -08001533 DieWithError('%s\nMaybe your depot_tools is out of date?' % e)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001534
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001535 def CMDPatchIssue(self, issue_arg, reject, nocommit, directory):
1536 """Fetches and applies the issue patch from codereview to local branch."""
tandrii@chromium.orgef7c68c2016-04-07 09:39:39 +00001537 if isinstance(issue_arg, (int, long)) or issue_arg.isdigit():
1538 parsed_issue_arg = _ParsedIssueNumberArgument(int(issue_arg))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001539 else:
1540 # Assume url.
1541 parsed_issue_arg = self._codereview_impl.ParseIssueURL(
1542 urlparse.urlparse(issue_arg))
1543 if not parsed_issue_arg or not parsed_issue_arg.valid:
1544 DieWithError('Failed to parse issue argument "%s". '
1545 'Must be an issue number or a valid URL.' % issue_arg)
1546 return self._codereview_impl.CMDPatchWithParsedIssue(
Aaron Gable62619a32017-06-16 08:22:09 -07001547 parsed_issue_arg, reject, nocommit, directory, False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001548
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001549 def CMDUpload(self, options, git_diff_args, orig_args):
1550 """Uploads a change to codereview."""
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001551 custom_cl_base = None
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001552 if git_diff_args:
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001553 custom_cl_base = base_branch = git_diff_args[0]
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001554 else:
1555 if self.GetBranch() is None:
1556 DieWithError('Can\'t upload from detached HEAD state. Get on a branch!')
1557
1558 # Default to diffing against common ancestor of upstream branch
1559 base_branch = self.GetCommonAncestorWithUpstream()
1560 git_diff_args = [base_branch, 'HEAD']
1561
Aaron Gablec4c40d12017-05-22 11:49:53 -07001562 # Warn about Rietveld deprecation for initial uploads to Rietveld.
1563 if not self.IsGerrit() and not self.GetIssue():
1564 print('=====================================')
1565 print('NOTICE: Rietveld is being deprecated. '
1566 'You can upload changes to Gerrit with')
1567 print(' git cl upload --gerrit')
1568 print('or set Gerrit to be your default code review tool with')
1569 print(' git config gerrit.host true')
1570 print('=====================================')
1571
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001572 # Fast best-effort checks to abort before running potentially
1573 # expensive hooks if uploading is likely to fail anyway. Passing these
1574 # checks does not guarantee that uploading will not fail.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001575 self._codereview_impl.EnsureAuthenticated(force=options.force)
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001576 self._codereview_impl.EnsureCanUploadPatchset(force=options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001577
1578 # Apply watchlists on upload.
1579 change = self.GetChange(base_branch, None)
1580 watchlist = watchlists.Watchlists(change.RepositoryRoot())
1581 files = [f.LocalPath() for f in change.AffectedFiles()]
1582 if not options.bypass_watchlists:
Daniel Cheng7227d212017-11-17 08:12:37 -08001583 self.ExtendCC(watchlist.GetWatchersForPaths(files))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001584
1585 if not options.bypass_hooks:
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001586 if options.reviewers or options.tbrs or options.add_owners_to:
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001587 # Set the reviewer list now so that presubmit checks can access it.
1588 change_description = ChangeDescription(change.FullDescriptionText())
1589 change_description.update_reviewers(options.reviewers,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001590 options.tbrs,
Robert Iannuccif2708bd2017-04-17 15:49:02 -07001591 options.add_owners_to,
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001592 change)
1593 change.SetDescriptionText(change_description.description)
1594 hook_results = self.RunHook(committing=False,
Edward Lesmes8e282792018-04-03 18:50:29 -04001595 may_prompt=not options.force,
1596 verbose=options.verbose,
1597 change=change, parallel=options.parallel)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001598 if not hook_results.should_continue():
1599 return 1
1600 if not options.reviewers and hook_results.reviewers:
1601 options.reviewers = hook_results.reviewers.split(',')
Daniel Cheng7227d212017-11-17 08:12:37 -08001602 self.ExtendCC(hook_results.more_cc)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001603
Ravi Mistryfda50ca2016-11-14 10:19:18 -05001604 # TODO(tandrii): Checking local patchset against remote patchset is only
1605 # supported for Rietveld. Extend it to Gerrit or remove it completely.
1606 if self.GetIssue() and not self.IsGerrit():
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001607 latest_patchset = self.GetMostRecentPatchset()
1608 local_patchset = self.GetPatchset()
1609 if (latest_patchset and local_patchset and
1610 local_patchset != latest_patchset):
vapiera7fbd5a2016-06-16 09:17:49 -07001611 print('The last upload made from this repository was patchset #%d but '
1612 'the most recent patchset on the server is #%d.'
1613 % (local_patchset, latest_patchset))
1614 print('Uploading will still work, but if you\'ve uploaded to this '
1615 'issue from another machine or branch the patch you\'re '
1616 'uploading now might not include those changes.')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001617 confirm_or_exit(action='upload')
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001618
Aaron Gable13101a62018-02-09 13:20:41 -08001619 print_stats(git_diff_args)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001620 ret = self.CMDUploadChange(options, git_diff_args, custom_cl_base, change)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001621 if not ret:
Ravi Mistry31e7d562018-04-02 12:53:57 -04001622 if self.IsGerrit():
1623 self.SetLabels(options.enable_auto_submit, options.use_commit_queue,
1624 options.cq_dry_run);
1625 else:
1626 if options.use_commit_queue:
1627 self.SetCQState(_CQState.COMMIT)
1628 elif options.cq_dry_run:
1629 self.SetCQState(_CQState.DRY_RUN)
tandrii4d0545a2016-07-06 03:56:49 -07001630
tandrii5d48c322016-08-18 16:19:37 -07001631 _git_set_branch_config_value('last-upload-hash',
1632 RunGit(['rev-parse', 'HEAD']).strip())
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001633 # Run post upload hooks, if specified.
1634 if settings.GetRunPostUploadHook():
1635 presubmit_support.DoPostUploadExecuter(
1636 change,
1637 self,
1638 settings.GetRoot(),
1639 options.verbose,
1640 sys.stdout)
1641
1642 # Upload all dependencies if specified.
1643 if options.dependencies:
vapiera7fbd5a2016-06-16 09:17:49 -07001644 print()
1645 print('--dependencies has been specified.')
1646 print('All dependent local branches will be re-uploaded.')
1647 print()
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001648 # Remove the dependencies flag from args so that we do not end up in a
1649 # loop.
1650 orig_args.remove('--dependencies')
1651 ret = upload_branch_deps(self, orig_args)
1652 return ret
1653
Ravi Mistry31e7d562018-04-02 12:53:57 -04001654 def SetLabels(self, enable_auto_submit, use_commit_queue, cq_dry_run):
1655 """Sets labels on the change based on the provided flags.
1656
1657 Sets labels if issue is already uploaded and known, else returns without
1658 doing anything.
1659
1660 Args:
1661 enable_auto_submit: Sets Auto-Submit+1 on the change.
1662 use_commit_queue: Sets Commit-Queue+2 on the change.
1663 cq_dry_run: Sets Commit-Queue+1 on the change. Overrides Commit-Queue+2 if
1664 both use_commit_queue and cq_dry_run are true.
1665 """
1666 if not self.GetIssue():
1667 return
1668 try:
1669 self._codereview_impl.SetLabels(enable_auto_submit, use_commit_queue,
1670 cq_dry_run)
1671 return 0
1672 except KeyboardInterrupt:
1673 raise
1674 except:
1675 labels = []
1676 if enable_auto_submit:
1677 labels.append('Auto-Submit')
1678 if use_commit_queue or cq_dry_run:
1679 labels.append('Commit-Queue')
1680 print('WARNING: Failed to set label(s) on your change: %s\n'
1681 'Either:\n'
1682 ' * Your project does not have the above label(s),\n'
1683 ' * You don\'t have permission to set the above label(s),\n'
1684 ' * There\'s a bug in this code (see stack trace below).\n' %
1685 (', '.join(labels)))
1686 # Still raise exception so that stack trace is printed.
1687 raise
1688
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001689 def SetCQState(self, new_state):
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001690 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001691
1692 Issue must have been already uploaded and known.
1693 """
1694 assert new_state in _CQState.ALL_STATES
1695 assert self.GetIssue()
qyearsley1fdfcb62016-10-24 13:22:03 -07001696 try:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001697 self._codereview_impl.SetCQState(new_state)
qyearsley1fdfcb62016-10-24 13:22:03 -07001698 return 0
1699 except KeyboardInterrupt:
1700 raise
1701 except:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001702 print('WARNING: Failed to %s.\n'
qyearsley1fdfcb62016-10-24 13:22:03 -07001703 'Either:\n'
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001704 ' * Your project has no CQ,\n'
1705 ' * You don\'t have permission to change the CQ state,\n'
1706 ' * There\'s a bug in this code (see stack trace below).\n'
1707 'Consider specifying which bots to trigger manually or asking your '
1708 'project owners for permissions or contacting Chrome Infra at:\n'
1709 'https://www.chromium.org/infra\n\n' %
1710 ('cancel CQ' if new_state == _CQState.NONE else 'trigger CQ'))
qyearsley1fdfcb62016-10-24 13:22:03 -07001711 # Still raise exception so that stack trace is printed.
1712 raise
1713
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001714 # Forward methods to codereview specific implementation.
1715
Aaron Gable636b13f2017-07-14 10:42:48 -07001716 def AddComment(self, message, publish=None):
1717 return self._codereview_impl.AddComment(message, publish=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001718
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001719 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001720 """Returns list of _CommentSummary for each comment.
1721
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001722 args:
1723 readable: determines whether the output is designed for a human or a machine
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001724 """
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001725 return self._codereview_impl.GetCommentsSummary(readable)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001726
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001727 def CloseIssue(self):
1728 return self._codereview_impl.CloseIssue()
1729
1730 def GetStatus(self):
1731 return self._codereview_impl.GetStatus()
1732
1733 def GetCodereviewServer(self):
1734 return self._codereview_impl.GetCodereviewServer()
1735
tandriide281ae2016-10-12 06:02:30 -07001736 def GetIssueOwner(self):
1737 """Get owner from codereview, which may differ from this checkout."""
1738 return self._codereview_impl.GetIssueOwner()
1739
Edward Lemur707d70b2018-02-07 00:50:14 +01001740 def GetReviewers(self):
1741 return self._codereview_impl.GetReviewers()
1742
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001743 def GetMostRecentPatchset(self):
1744 return self._codereview_impl.GetMostRecentPatchset()
1745
tandriide281ae2016-10-12 06:02:30 -07001746 def CannotTriggerTryJobReason(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001747 """Returns reason (str) if unable trigger try jobs on this CL or None."""
tandriide281ae2016-10-12 06:02:30 -07001748 return self._codereview_impl.CannotTriggerTryJobReason()
1749
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001750 def GetTryJobProperties(self, patchset=None):
1751 """Returns dictionary of properties to launch try job."""
1752 return self._codereview_impl.GetTryJobProperties(patchset=patchset)
tandrii8c5a3532016-11-04 07:52:02 -07001753
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001754 def __getattr__(self, attr):
1755 # This is because lots of untested code accesses Rietveld-specific stuff
1756 # directly, and it's hard to fix for sure. So, just let it work, and fix
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00001757 # on a case by case basis.
tandrii4d895502016-08-18 08:26:19 -07001758 # Note that child method defines __getattr__ as well, and forwards it here,
1759 # because _RietveldChangelistImpl is not cleaned up yet, and given
1760 # deprecation of Rietveld, it should probably be just removed.
1761 # Until that time, avoid infinite recursion by bypassing __getattr__
1762 # of implementation class.
1763 return self._codereview_impl.__getattribute__(attr)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001764
1765
1766class _ChangelistCodereviewBase(object):
1767 """Abstract base class encapsulating codereview specifics of a changelist."""
1768 def __init__(self, changelist):
1769 self._changelist = changelist # instance of Changelist
1770
1771 def __getattr__(self, attr):
1772 # Forward methods to changelist.
1773 # TODO(tandrii): maybe clean up _GerritChangelistImpl and
1774 # _RietveldChangelistImpl to avoid this hack?
1775 return getattr(self._changelist, attr)
1776
1777 def GetStatus(self):
1778 """Apply a rough heuristic to give a simple summary of an issue's review
1779 or CQ status, assuming adherence to a common workflow.
1780
1781 Returns None if no issue for this branch, or specific string keywords.
1782 """
1783 raise NotImplementedError()
1784
1785 def GetCodereviewServer(self):
1786 """Returns server URL without end slash, like "https://codereview.com"."""
1787 raise NotImplementedError()
1788
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001789 def FetchDescription(self, force=False):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001790 """Fetches and returns description from the codereview server."""
1791 raise NotImplementedError()
1792
tandrii5d48c322016-08-18 16:19:37 -07001793 @classmethod
1794 def IssueConfigKey(cls):
1795 """Returns branch setting storing issue number."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001796 raise NotImplementedError()
1797
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001798 @classmethod
tandrii5d48c322016-08-18 16:19:37 -07001799 def PatchsetConfigKey(cls):
1800 """Returns branch setting storing patchset number."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001801 raise NotImplementedError()
1802
tandrii5d48c322016-08-18 16:19:37 -07001803 @classmethod
1804 def CodereviewServerConfigKey(cls):
1805 """Returns branch setting storing codereview server."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001806 raise NotImplementedError()
1807
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001808 def _PostUnsetIssueProperties(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001809 """Which branch-specific properties to erase when unsetting issue."""
tandrii5d48c322016-08-18 16:19:37 -07001810 return []
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001811
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001812 def GetGerritObjForPresubmit(self):
1813 # None is valid return value, otherwise presubmit_support.GerritAccessor.
1814 return None
1815
dsansomee2d6fd92016-09-08 00:10:47 -07001816 def UpdateDescriptionRemote(self, description, force=False):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001817 """Update the description on codereview site."""
1818 raise NotImplementedError()
1819
Aaron Gable636b13f2017-07-14 10:42:48 -07001820 def AddComment(self, message, publish=None):
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001821 """Posts a comment to the codereview site."""
1822 raise NotImplementedError()
1823
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001824 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001825 raise NotImplementedError()
1826
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001827 def CloseIssue(self):
1828 """Closes the issue."""
1829 raise NotImplementedError()
1830
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001831 def GetMostRecentPatchset(self):
1832 """Returns the most recent patchset number from the codereview site."""
1833 raise NotImplementedError()
1834
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001835 def CMDPatchWithParsedIssue(self, parsed_issue_arg, reject, nocommit,
Aaron Gable62619a32017-06-16 08:22:09 -07001836 directory, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001837 """Fetches and applies the issue.
1838
1839 Arguments:
1840 parsed_issue_arg: instance of _ParsedIssueNumberArgument.
1841 reject: if True, reject the failed patch instead of switching to 3-way
1842 merge. Rietveld only.
1843 nocommit: do not commit the patch, thus leave the tree dirty. Rietveld
1844 only.
1845 directory: switch to directory before applying the patch. Rietveld only.
Aaron Gable62619a32017-06-16 08:22:09 -07001846 force: if true, overwrites existing local state.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001847 """
1848 raise NotImplementedError()
1849
1850 @staticmethod
1851 def ParseIssueURL(parsed_url):
1852 """Parses url and returns instance of _ParsedIssueNumberArgument or None if
1853 failed."""
1854 raise NotImplementedError()
1855
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001856 def EnsureAuthenticated(self, force, refresh=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001857 """Best effort check that user is authenticated with codereview server.
1858
1859 Arguments:
1860 force: whether to skip confirmation questions.
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001861 refresh: whether to attempt to refresh credentials. Ignored if not
1862 applicable.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001863 """
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001864 raise NotImplementedError()
1865
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001866 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001867 """Best effort check that uploading isn't supposed to fail for predictable
1868 reasons.
1869
1870 This method should raise informative exception if uploading shouldn't
1871 proceed.
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001872
1873 Arguments:
1874 force: whether to skip confirmation questions.
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001875 """
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001876 raise NotImplementedError()
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001877
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001878 def CMDUploadChange(self, options, git_diff_args, custom_cl_base, change):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00001879 """Uploads a change to codereview."""
1880 raise NotImplementedError()
1881
Ravi Mistry31e7d562018-04-02 12:53:57 -04001882 def SetLabels(self, enable_auto_submit, use_commit_queue, cq_dry_run):
1883 """Sets labels on the change based on the provided flags.
1884
1885 Issue must have been already uploaded and known.
1886 """
1887 raise NotImplementedError()
1888
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001889 def SetCQState(self, new_state):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001890 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001891
1892 Issue must have been already uploaded and known.
1893 """
1894 raise NotImplementedError()
1895
tandriie113dfd2016-10-11 10:20:12 -07001896 def CannotTriggerTryJobReason(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001897 """Returns reason (str) if unable trigger try jobs on this CL or None."""
tandriie113dfd2016-10-11 10:20:12 -07001898 raise NotImplementedError()
1899
tandriide281ae2016-10-12 06:02:30 -07001900 def GetIssueOwner(self):
1901 raise NotImplementedError()
1902
Edward Lemur707d70b2018-02-07 00:50:14 +01001903 def GetReviewers(self):
1904 raise NotImplementedError()
1905
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001906 def GetTryJobProperties(self, patchset=None):
tandriide281ae2016-10-12 06:02:30 -07001907 raise NotImplementedError()
1908
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001909
1910class _RietveldChangelistImpl(_ChangelistCodereviewBase):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001911
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001912 def __init__(self, changelist, auth_config=None, codereview_host=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001913 super(_RietveldChangelistImpl, self).__init__(changelist)
1914 assert settings, 'must be initialized in _ChangelistCodereviewBase'
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001915 if not codereview_host:
martiniss6eda05f2016-06-30 10:18:35 -07001916 settings.GetDefaultServerUrl()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001917
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001918 self._rietveld_server = codereview_host
Andrii Shyshkalov98cef572017-01-25 13:57:52 +01001919 self._auth_config = auth_config or auth.make_auth_config()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001920 self._props = None
1921 self._rpc_server = None
1922
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001923 def GetCodereviewServer(self):
1924 if not self._rietveld_server:
1925 # If we're on a branch then get the server potentially associated
1926 # with that branch.
1927 if self.GetIssue():
tandrii5d48c322016-08-18 16:19:37 -07001928 self._rietveld_server = gclient_utils.UpgradeToHttps(
1929 self._GitGetBranchConfigValue(self.CodereviewServerConfigKey()))
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001930 if not self._rietveld_server:
1931 self._rietveld_server = settings.GetDefaultServerUrl()
1932 return self._rietveld_server
1933
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001934 def EnsureAuthenticated(self, force, refresh=False):
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001935 """Best effort check that user is authenticated with Rietveld server."""
1936 if self._auth_config.use_oauth2:
1937 authenticator = auth.get_authenticator_for_host(
1938 self.GetCodereviewServer(), self._auth_config)
1939 if not authenticator.has_cached_credentials():
1940 raise auth.LoginRequiredError(self.GetCodereviewServer())
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001941 if refresh:
1942 authenticator.get_access_token()
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001943
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001944 def EnsureCanUploadPatchset(self, force):
1945 # No checks for Rietveld because we are deprecating Rietveld.
1946 pass
1947
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001948 def FetchDescription(self, force=False):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001949 issue = self.GetIssue()
1950 assert issue
1951 try:
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001952 return self.RpcServer().get_description(issue, force=force).strip()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001953 except urllib2.HTTPError as e:
1954 if e.code == 404:
1955 DieWithError(
1956 ('\nWhile fetching the description for issue %d, received a '
1957 '404 (not found)\n'
1958 'error. It is likely that you deleted this '
1959 'issue on the server. If this is the\n'
1960 'case, please run\n\n'
1961 ' git cl issue 0\n\n'
1962 'to clear the association with the deleted issue. Then run '
1963 'this command again.') % issue)
1964 else:
1965 DieWithError(
1966 '\nFailed to fetch issue description. HTTP error %d' % e.code)
1967 except urllib2.URLError as e:
vapiera7fbd5a2016-06-16 09:17:49 -07001968 print('Warning: Failed to retrieve CL description due to network '
1969 'failure.', file=sys.stderr)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001970 return ''
1971
1972 def GetMostRecentPatchset(self):
1973 return self.GetIssueProperties()['patchsets'][-1]
1974
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001975 def GetIssueProperties(self):
1976 if self._props is None:
1977 issue = self.GetIssue()
1978 if not issue:
1979 self._props = {}
1980 else:
1981 self._props = self.RpcServer().get_issue_properties(issue, True)
1982 return self._props
1983
tandriie113dfd2016-10-11 10:20:12 -07001984 def CannotTriggerTryJobReason(self):
1985 props = self.GetIssueProperties()
1986 if not props:
1987 return 'Rietveld doesn\'t know about your issue %s' % self.GetIssue()
1988 if props.get('closed'):
1989 return 'CL %s is closed' % self.GetIssue()
1990 if props.get('private'):
1991 return 'CL %s is private' % self.GetIssue()
1992 return None
1993
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001994 def GetTryJobProperties(self, patchset=None):
1995 """Returns dictionary of properties to launch try job."""
tandrii8c5a3532016-11-04 07:52:02 -07001996 project = (self.GetIssueProperties() or {}).get('project')
1997 return {
1998 'issue': self.GetIssue(),
1999 'patch_project': project,
2000 'patch_storage': 'rietveld',
2001 'patchset': patchset or self.GetPatchset(),
2002 'rietveld': self.GetCodereviewServer(),
2003 }
2004
tandriide281ae2016-10-12 06:02:30 -07002005 def GetIssueOwner(self):
2006 return (self.GetIssueProperties() or {}).get('owner_email')
2007
Edward Lemur707d70b2018-02-07 00:50:14 +01002008 def GetReviewers(self):
2009 return (self.GetIssueProperties() or {}).get('reviewers')
2010
Aaron Gable636b13f2017-07-14 10:42:48 -07002011 def AddComment(self, message, publish=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002012 return self.RpcServer().add_comment(self.GetIssue(), message)
2013
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002014 def GetCommentsSummary(self, _readable=True):
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01002015 summary = []
2016 for message in self.GetIssueProperties().get('messages', []):
2017 date = datetime.datetime.strptime(message['date'], '%Y-%m-%d %H:%M:%S.%f')
2018 summary.append(_CommentSummary(
2019 date=date,
2020 disapproval=bool(message['disapproval']),
2021 approval=bool(message['approval']),
2022 sender=message['sender'],
2023 message=message['text'],
2024 ))
2025 return summary
2026
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00002027 def GetStatus(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002028 """Applies a rough heuristic to give a simple summary of an issue's review
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00002029 or CQ status, assuming adherence to a common workflow.
2030
2031 Returns None if no issue for this branch, or one of the following keywords:
Aaron Gablea1bab272017-04-11 16:38:18 -07002032 * 'error' - error from review tool (including deleted issues)
2033 * 'unsent' - not sent for review
2034 * 'waiting' - waiting for review
2035 * 'reply' - waiting for owner to reply to review
2036 * 'not lgtm' - Code-Review label has been set negatively
2037 * 'lgtm' - LGTM from at least one approved reviewer
2038 * 'commit' - in the commit queue
2039 * 'closed' - closed
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00002040 """
2041 if not self.GetIssue():
2042 return None
2043
2044 try:
2045 props = self.GetIssueProperties()
2046 except urllib2.HTTPError:
2047 return 'error'
2048
2049 if props.get('closed'):
2050 # Issue is closed.
2051 return 'closed'
tandrii@chromium.orgb4f6a222016-03-03 01:11:04 +00002052 if props.get('commit') and not props.get('cq_dry_run', False):
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00002053 # Issue is in the commit queue.
2054 return 'commit'
2055
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00002056 messages = props.get('messages') or []
Aaron Gablea1bab272017-04-11 16:38:18 -07002057 if not messages:
2058 # No message was sent.
2059 return 'unsent'
2060
2061 if get_approving_reviewers(props):
2062 return 'lgtm'
2063 elif get_approving_reviewers(props, disapproval=True):
2064 return 'not lgtm'
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00002065
tandrii9d2c7a32016-06-22 03:42:45 -07002066 # Skip CQ messages that don't require owner's action.
2067 while messages and messages[-1]['sender'] == COMMIT_BOT_EMAIL:
2068 if 'Dry run:' in messages[-1]['text']:
2069 messages.pop()
2070 elif 'The CQ bit was unchecked' in messages[-1]['text']:
2071 # This message always follows prior messages from CQ,
2072 # so skip this too.
2073 messages.pop()
2074 else:
2075 # This is probably a CQ messages warranting user attention.
2076 break
2077
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00002078 if messages[-1]['sender'] != props.get('owner_email'):
tandrii9d2c7a32016-06-22 03:42:45 -07002079 # Non-LGTM reply from non-owner and not CQ bot.
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00002080 return 'reply'
2081 return 'waiting'
2082
dsansomee2d6fd92016-09-08 00:10:47 -07002083 def UpdateDescriptionRemote(self, description, force=False):
Andrii Shyshkalov83051152017-02-07 23:47:29 +01002084 self.RpcServer().update_description(self.GetIssue(), description)
maruel@chromium.orgb021b322013-04-08 17:57:29 +00002085
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002086 def CloseIssue(self):
maruel@chromium.orgb021b322013-04-08 17:57:29 +00002087 return self.RpcServer().close_issue(self.GetIssue())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002088
maruel@chromium.org27bb3872011-05-30 20:33:19 +00002089 def SetFlag(self, flag, value):
tandrii4b233bd2016-07-06 03:50:29 -07002090 return self.SetFlags({flag: value})
2091
2092 def SetFlags(self, flags):
2093 """Sets flags on this CL/patchset in Rietveld.
tandrii4b233bd2016-07-06 03:50:29 -07002094 """
phajdan.jr68598232016-08-10 03:28:28 -07002095 patchset = self.GetPatchset() or self.GetMostRecentPatchset()
maruel@chromium.org27bb3872011-05-30 20:33:19 +00002096 try:
tandrii4b233bd2016-07-06 03:50:29 -07002097 return self.RpcServer().set_flags(
phajdan.jr68598232016-08-10 03:28:28 -07002098 self.GetIssue(), patchset, flags)
vapierfd77ac72016-06-16 08:33:57 -07002099 except urllib2.HTTPError as e:
maruel@chromium.org27bb3872011-05-30 20:33:19 +00002100 if e.code == 404:
2101 DieWithError('The issue %s doesn\'t exist.' % self.GetIssue())
2102 if e.code == 403:
2103 DieWithError(
2104 ('Access denied to issue %s. Maybe the patchset %s doesn\'t '
phajdan.jr68598232016-08-10 03:28:28 -07002105 'match?') % (self.GetIssue(), patchset))
maruel@chromium.org27bb3872011-05-30 20:33:19 +00002106 raise
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002107
maruel@chromium.orgcab38e92011-04-09 00:30:51 +00002108 def RpcServer(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002109 """Returns an upload.RpcServer() to access this review's rietveld instance.
2110 """
maruel@chromium.orge77ebbf2011-03-29 20:35:38 +00002111 if not self._rpc_server:
maruel@chromium.org4bac4b52012-11-27 20:33:52 +00002112 self._rpc_server = rietveld.CachingRietveld(
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002113 self.GetCodereviewServer(),
Andrii Shyshkalov98cef572017-01-25 13:57:52 +01002114 self._auth_config)
maruel@chromium.orge77ebbf2011-03-29 20:35:38 +00002115 return self._rpc_server
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002116
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00002117 @classmethod
tandrii5d48c322016-08-18 16:19:37 -07002118 def IssueConfigKey(cls):
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00002119 return 'rietveldissue'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002120
tandrii5d48c322016-08-18 16:19:37 -07002121 @classmethod
2122 def PatchsetConfigKey(cls):
2123 return 'rietveldpatchset'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002124
tandrii5d48c322016-08-18 16:19:37 -07002125 @classmethod
2126 def CodereviewServerConfigKey(cls):
2127 return 'rietveldserver'
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002128
Ravi Mistry31e7d562018-04-02 12:53:57 -04002129 def SetLabels(self, enable_auto_submit, use_commit_queue, cq_dry_run):
2130 raise NotImplementedError()
2131
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002132 def SetCQState(self, new_state):
2133 props = self.GetIssueProperties()
2134 if props.get('private'):
2135 DieWithError('Cannot set-commit on private issue')
2136
2137 if new_state == _CQState.COMMIT:
tandrii4d843592016-07-27 08:22:56 -07002138 self.SetFlags({'commit': '1', 'cq_dry_run': '0'})
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002139 elif new_state == _CQState.NONE:
tandrii4b233bd2016-07-06 03:50:29 -07002140 self.SetFlags({'commit': '0', 'cq_dry_run': '0'})
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002141 else:
tandrii4b233bd2016-07-06 03:50:29 -07002142 assert new_state == _CQState.DRY_RUN
2143 self.SetFlags({'commit': '1', 'cq_dry_run': '1'})
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002144
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002145 def CMDPatchWithParsedIssue(self, parsed_issue_arg, reject, nocommit,
Aaron Gable62619a32017-06-16 08:22:09 -07002146 directory, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002147 # PatchIssue should never be called with a dirty tree. It is up to the
2148 # caller to check this, but just in case we assert here since the
2149 # consequences of the caller not checking this could be dire.
2150 assert(not git_common.is_dirty_git_tree('apply'))
2151 assert(parsed_issue_arg.valid)
2152 self._changelist.issue = parsed_issue_arg.issue
2153 if parsed_issue_arg.hostname:
2154 self._rietveld_server = 'https://%s' % parsed_issue_arg.hostname
2155
skobes6468b902016-10-24 08:45:10 -07002156 patchset = parsed_issue_arg.patchset or self.GetMostRecentPatchset()
2157 patchset_object = self.RpcServer().get_patch(self.GetIssue(), patchset)
2158 scm_obj = checkout.GitCheckout(settings.GetRoot(), None, None, None, None)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002159 try:
skobes6468b902016-10-24 08:45:10 -07002160 scm_obj.apply_patch(patchset_object)
2161 except Exception as e:
2162 print(str(e))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002163 return 1
2164
2165 # If we had an issue, commit the current state and register the issue.
2166 if not nocommit:
Aaron Gabled343c632017-03-15 11:02:26 -07002167 self.SetIssue(self.GetIssue())
2168 self.SetPatchset(patchset)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002169 RunGit(['commit', '-m', (self.GetDescription() + '\n\n' +
2170 'patch from issue %(i)s at patchset '
2171 '%(p)s (http://crrev.com/%(i)s#ps%(p)s)'
2172 % {'i': self.GetIssue(), 'p': patchset})])
vapiera7fbd5a2016-06-16 09:17:49 -07002173 print('Committed patch locally.')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002174 else:
vapiera7fbd5a2016-06-16 09:17:49 -07002175 print('Patch applied to index.')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002176 return 0
2177
2178 @staticmethod
2179 def ParseIssueURL(parsed_url):
2180 if not parsed_url.scheme or not parsed_url.scheme.startswith('http'):
2181 return None
wychen3c1c1722016-08-04 11:46:36 -07002182 # Rietveld patch: https://domain/<number>/#ps<patchset>
2183 match = re.match(r'/(\d+)/$', parsed_url.path)
2184 match2 = re.match(r'ps(\d+)$', parsed_url.fragment)
2185 if match and match2:
skobes6468b902016-10-24 08:45:10 -07002186 return _ParsedIssueNumberArgument(
wychen3c1c1722016-08-04 11:46:36 -07002187 issue=int(match.group(1)),
2188 patchset=int(match2.group(1)),
Andrii Shyshkalov90f31922017-04-10 16:10:21 +02002189 hostname=parsed_url.netloc,
2190 codereview='rietveld')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002191 # Typical url: https://domain/<issue_number>[/[other]]
2192 match = re.match('/(\d+)(/.*)?$', parsed_url.path)
2193 if match:
skobes6468b902016-10-24 08:45:10 -07002194 return _ParsedIssueNumberArgument(
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002195 issue=int(match.group(1)),
Andrii Shyshkalov90f31922017-04-10 16:10:21 +02002196 hostname=parsed_url.netloc,
2197 codereview='rietveld')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002198 # Rietveld patch: https://domain/download/issue<number>_<patchset>.diff
2199 match = re.match(r'/download/issue(\d+)_(\d+).diff$', parsed_url.path)
2200 if match:
skobes6468b902016-10-24 08:45:10 -07002201 return _ParsedIssueNumberArgument(
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002202 issue=int(match.group(1)),
2203 patchset=int(match.group(2)),
Andrii Shyshkalov90f31922017-04-10 16:10:21 +02002204 hostname=parsed_url.netloc,
2205 codereview='rietveld')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002206 return None
2207
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002208 def CMDUploadChange(self, options, args, custom_cl_base, change):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002209 """Upload the patch to Rietveld."""
2210 upload_args = ['--assume_yes'] # Don't ask about untracked files.
2211 upload_args.extend(['--server', self.GetCodereviewServer()])
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002212 upload_args.extend(auth.auth_config_to_command_options(self._auth_config))
2213 if options.emulate_svn_auto_props:
2214 upload_args.append('--emulate_svn_auto_props')
2215
2216 change_desc = None
2217
2218 if options.email is not None:
2219 upload_args.extend(['--email', options.email])
2220
2221 if self.GetIssue():
nodirca166002016-06-27 10:59:51 -07002222 if options.title is not None:
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002223 upload_args.extend(['--title', options.title])
2224 if options.message:
2225 upload_args.extend(['--message', options.message])
2226 upload_args.extend(['--issue', str(self.GetIssue())])
vapiera7fbd5a2016-06-16 09:17:49 -07002227 print('This branch is associated with issue %s. '
2228 'Adding patch to that issue.' % self.GetIssue())
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002229 else:
nodirca166002016-06-27 10:59:51 -07002230 if options.title is not None:
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002231 upload_args.extend(['--title', options.title])
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08002232 if options.message:
2233 message = options.message
2234 else:
2235 message = CreateDescriptionFromLog(args)
2236 if options.title:
2237 message = options.title + '\n\n' + message
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002238 change_desc = ChangeDescription(message)
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002239 if options.reviewers or options.add_owners_to:
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002240 change_desc.update_reviewers(options.reviewers, options.tbrs,
2241 options.add_owners_to, change)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002242 if not options.force:
Aaron Gable3a16ed12017-03-23 10:51:55 -07002243 change_desc.prompt(bug=options.bug, git_footer=False)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002244
2245 if not change_desc.description:
vapiera7fbd5a2016-06-16 09:17:49 -07002246 print('Description is empty; aborting.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002247 return 1
2248
2249 upload_args.extend(['--message', change_desc.description])
2250 if change_desc.get_reviewers():
2251 upload_args.append('--reviewers=%s' % ','.join(
2252 change_desc.get_reviewers()))
2253 if options.send_mail:
2254 if not change_desc.get_reviewers():
Christopher Lamf732cd52017-01-24 12:40:11 +11002255 DieWithError("Must specify reviewers to send email.", change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002256 upload_args.append('--send_mail')
2257
2258 # We check this before applying rietveld.private assuming that in
2259 # rietveld.cc only addresses which we can send private CLs to are listed
2260 # if rietveld.private is set, and so we should ignore rietveld.cc only
2261 # when --private is specified explicitly on the command line.
2262 if options.private:
2263 logging.warn('rietveld.cc is ignored since private flag is specified. '
2264 'You need to review and add them manually if necessary.')
2265 cc = self.GetCCListWithoutDefault()
2266 else:
2267 cc = self.GetCCList()
2268 cc = ','.join(filter(None, (cc, ','.join(options.cc))))
bradnelsond975b302016-10-23 12:20:23 -07002269 if change_desc.get_cced():
2270 cc = ','.join(filter(None, (cc, ','.join(change_desc.get_cced()))))
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002271 if cc:
2272 upload_args.extend(['--cc', cc])
2273
2274 if options.private or settings.GetDefaultPrivateFlag() == "True":
2275 upload_args.append('--private')
2276
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002277 # Include the upstream repo's URL in the change -- this is useful for
2278 # projects that have their source spread across multiple repos.
2279 remote_url = self.GetGitBaseUrlFromConfig()
2280 if not remote_url:
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08002281 if self.GetRemoteUrl() and '/' in self.GetUpstreamBranch():
2282 remote_url = '%s@%s' % (self.GetRemoteUrl(),
2283 self.GetUpstreamBranch().split('/')[-1])
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002284 if remote_url:
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002285 remote, remote_branch = self.GetRemoteBranch()
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01002286 target_ref = GetTargetRef(remote, remote_branch, options.target_branch)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002287 if target_ref:
2288 upload_args.extend(['--target_ref', target_ref])
2289
2290 # Look for dependent patchsets. See crbug.com/480453 for more details.
2291 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
2292 upstream_branch = ShortBranchName(upstream_branch)
2293 if remote is '.':
2294 # A local branch is being tracked.
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00002295 local_branch = upstream_branch
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002296 if settings.GetIsSkipDependencyUpload(local_branch):
vapiera7fbd5a2016-06-16 09:17:49 -07002297 print()
2298 print('Skipping dependency patchset upload because git config '
2299 'branch.%s.skip-deps-uploads is set to True.' % local_branch)
2300 print()
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002301 else:
2302 auth_config = auth.extract_auth_config_from_options(options)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00002303 branch_cl = Changelist(branchref='refs/heads/'+local_branch,
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002304 auth_config=auth_config)
2305 branch_cl_issue_url = branch_cl.GetIssueURL()
2306 branch_cl_issue = branch_cl.GetIssue()
2307 branch_cl_patchset = branch_cl.GetPatchset()
2308 if branch_cl_issue_url and branch_cl_issue and branch_cl_patchset:
2309 upload_args.extend(
2310 ['--depends_on_patchset', '%s:%s' % (
2311 branch_cl_issue, branch_cl_patchset)])
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00002312 print(
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002313 '\n'
2314 'The current branch (%s) is tracking a local branch (%s) with '
2315 'an associated CL.\n'
2316 'Adding %s/#ps%s as a dependency patchset.\n'
2317 '\n' % (self.GetBranch(), local_branch, branch_cl_issue_url,
2318 branch_cl_patchset))
2319
2320 project = settings.GetProject()
2321 if project:
2322 upload_args.extend(['--project', project])
Aaron Gable665a4392017-06-29 10:53:46 -07002323 else:
2324 print()
2325 print('WARNING: Uploading without a project specified. Please ensure '
2326 'your repo\'s codereview.settings has a "PROJECT: foo" line.')
2327 print()
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002328
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002329 try:
2330 upload_args = ['upload'] + upload_args + args
2331 logging.info('upload.RealMain(%s)', upload_args)
2332 issue, patchset = upload.RealMain(upload_args)
2333 issue = int(issue)
2334 patchset = int(patchset)
2335 except KeyboardInterrupt:
2336 sys.exit(1)
2337 except:
2338 # If we got an exception after the user typed a description for their
2339 # change, back up the description before re-raising.
2340 if change_desc:
Christopher Lamf732cd52017-01-24 12:40:11 +11002341 SaveDescriptionBackup(change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002342 raise
2343
2344 if not self.GetIssue():
2345 self.SetIssue(issue)
2346 self.SetPatchset(patchset)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002347 return 0
2348
Andrii Shyshkalov18975322017-01-25 16:44:13 +01002349
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002350class _GerritChangelistImpl(_ChangelistCodereviewBase):
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002351 def __init__(self, changelist, auth_config=None, codereview_host=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002352 # auth_config is Rietveld thing, kept here to preserve interface only.
2353 super(_GerritChangelistImpl, self).__init__(changelist)
2354 self._change_id = None
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002355 # Lazily cached values.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002356 self._gerrit_host = None # e.g. chromium-review.googlesource.com
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002357 self._gerrit_server = None # e.g. https://chromium-review.googlesource.com
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002358 # Map from change number (issue) to its detail cache.
2359 self._detail_cache = {}
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002360
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002361 if codereview_host is not None:
2362 assert not codereview_host.startswith('https://'), codereview_host
2363 self._gerrit_host = codereview_host
2364 self._gerrit_server = 'https://%s' % codereview_host
2365
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002366 def _GetGerritHost(self):
2367 # Lazy load of configs.
2368 self.GetCodereviewServer()
tandriie32e3ea2016-06-22 02:52:48 -07002369 if self._gerrit_host and '.' not in self._gerrit_host:
2370 # Abbreviated domain like "chromium" instead of chromium.googlesource.com.
2371 # This happens for internal stuff http://crbug.com/614312.
2372 parsed = urlparse.urlparse(self.GetRemoteUrl())
2373 if parsed.scheme == 'sso':
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002374 print('WARNING: using non-https URLs for remote is likely broken\n'
tandriie32e3ea2016-06-22 02:52:48 -07002375 ' Your current remote is: %s' % self.GetRemoteUrl())
2376 self._gerrit_host = '%s.googlesource.com' % self._gerrit_host
2377 self._gerrit_server = 'https://%s' % self._gerrit_host
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002378 return self._gerrit_host
2379
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002380 def _GetGitHost(self):
2381 """Returns git host to be used when uploading change to Gerrit."""
2382 return urlparse.urlparse(self.GetRemoteUrl()).netloc
2383
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002384 def GetCodereviewServer(self):
2385 if not self._gerrit_server:
2386 # If we're on a branch then get the server potentially associated
2387 # with that branch.
2388 if self.GetIssue():
tandrii5d48c322016-08-18 16:19:37 -07002389 self._gerrit_server = self._GitGetBranchConfigValue(
2390 self.CodereviewServerConfigKey())
2391 if self._gerrit_server:
2392 self._gerrit_host = urlparse.urlparse(self._gerrit_server).netloc
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002393 if not self._gerrit_server:
2394 # We assume repo to be hosted on Gerrit, and hence Gerrit server
2395 # has "-review" suffix for lowest level subdomain.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002396 parts = self._GetGitHost().split('.')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002397 parts[0] = parts[0] + '-review'
2398 self._gerrit_host = '.'.join(parts)
2399 self._gerrit_server = 'https://%s' % self._gerrit_host
2400 return self._gerrit_server
2401
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00002402 @classmethod
tandrii5d48c322016-08-18 16:19:37 -07002403 def IssueConfigKey(cls):
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00002404 return 'gerritissue'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002405
tandrii5d48c322016-08-18 16:19:37 -07002406 @classmethod
2407 def PatchsetConfigKey(cls):
2408 return 'gerritpatchset'
2409
2410 @classmethod
2411 def CodereviewServerConfigKey(cls):
2412 return 'gerritserver'
2413
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01002414 def EnsureAuthenticated(self, force, refresh=None):
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00002415 """Best effort check that user is authenticated with Gerrit server."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00002416 if settings.GetGerritSkipEnsureAuthenticated():
2417 # For projects with unusual authentication schemes.
2418 # See http://crbug.com/603378.
2419 return
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002420 # Lazy-loader to identify Gerrit and Git hosts.
2421 if gerrit_util.GceAuthenticator.is_gce():
2422 return
2423 self.GetCodereviewServer()
2424 git_host = self._GetGitHost()
2425 assert self._gerrit_server and self._gerrit_host
2426 cookie_auth = gerrit_util.CookiesAuthenticator()
2427
2428 gerrit_auth = cookie_auth.get_auth_header(self._gerrit_host)
2429 git_auth = cookie_auth.get_auth_header(git_host)
2430 if gerrit_auth and git_auth:
2431 if gerrit_auth == git_auth:
2432 return
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02002433 all_gsrc = cookie_auth.get_auth_header('d0esN0tEx1st.googlesource.com')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002434 print((
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002435 'WARNING: You have different credentials for Gerrit and git hosts:\n'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002436 ' %s\n'
2437 ' %s\n'
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02002438 ' Consider running the following command:\n'
2439 ' git cl creds-check\n'
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02002440 ' %s\n'
Andrii Shyshkalov8e4576f2017-05-10 15:46:53 +02002441 ' %s') %
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02002442 (git_host, self._gerrit_host,
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02002443 ('Hint: delete creds for .googlesource.com' if all_gsrc else ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002444 cookie_auth.get_new_password_message(git_host)))
2445 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002446 confirm_or_exit('If you know what you are doing', action='continue')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002447 return
2448 else:
2449 missing = (
Anna Henningsen4e891442017-07-06 21:40:58 +02002450 ([] if gerrit_auth else [self._gerrit_host]) +
2451 ([] if git_auth else [git_host]))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002452 DieWithError('Credentials for the following hosts are required:\n'
2453 ' %s\n'
2454 'These are read from %s (or legacy %s)\n'
2455 '%s' % (
2456 '\n '.join(missing),
2457 cookie_auth.get_gitcookies_path(),
2458 cookie_auth.get_netrc_path(),
2459 cookie_auth.get_new_password_message(git_host)))
2460
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002461 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01002462 if not self.GetIssue():
2463 return
2464
2465 # Warm change details cache now to avoid RPCs later, reducing latency for
2466 # developers.
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002467 self._GetChangeDetail(
2468 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT'])
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01002469
2470 status = self._GetChangeDetail()['status']
2471 if status in ('MERGED', 'ABANDONED'):
2472 DieWithError('Change %s has been %s, new uploads are not allowed' %
2473 (self.GetIssueURL(),
2474 'submitted' if status == 'MERGED' else 'abandoned'))
2475
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002476 if gerrit_util.GceAuthenticator.is_gce():
2477 return
2478 cookies_user = gerrit_util.CookiesAuthenticator().get_auth_email(
2479 self._GetGerritHost())
2480 if self.GetIssueOwner() == cookies_user:
2481 return
2482 logging.debug('change %s owner is %s, cookies user is %s',
2483 self.GetIssue(), self.GetIssueOwner(), cookies_user)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002484 # Maybe user has linked accounts or something like that,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002485 # so ask what Gerrit thinks of this user.
2486 details = gerrit_util.GetAccountDetails(self._GetGerritHost(), 'self')
2487 if details['email'] == self.GetIssueOwner():
2488 return
2489 if not force:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002490 print('WARNING: Change %s is owned by %s, but you authenticate to Gerrit '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002491 'as %s.\n'
2492 'Uploading may fail due to lack of permissions.' %
2493 (self.GetIssue(), self.GetIssueOwner(), details['email']))
2494 confirm_or_exit(action='upload')
2495
2496
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002497 def _PostUnsetIssueProperties(self):
2498 """Which branch-specific properties to erase when unsetting issue."""
tandrii5d48c322016-08-18 16:19:37 -07002499 return ['gerritsquashhash']
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002500
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00002501 def GetGerritObjForPresubmit(self):
2502 return presubmit_support.GerritAccessor(self._GetGerritHost())
2503
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002504 def GetStatus(self):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002505 """Apply a rough heuristic to give a simple summary of an issue's review
2506 or CQ status, assuming adherence to a common workflow.
2507
2508 Returns None if no issue for this branch, or one of the following keywords:
Aaron Gable9ab38c62017-04-06 14:36:33 -07002509 * 'error' - error from review tool (including deleted issues)
2510 * 'unsent' - no reviewers added
2511 * 'waiting' - waiting for review
2512 * 'reply' - waiting for uploader to reply to review
2513 * 'lgtm' - Code-Review label has been set
2514 * 'commit' - in the commit queue
2515 * 'closed' - successfully submitted or abandoned
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002516 """
2517 if not self.GetIssue():
2518 return None
2519
2520 try:
Aaron Gable9ab38c62017-04-06 14:36:33 -07002521 data = self._GetChangeDetail([
2522 'DETAILED_LABELS', 'CURRENT_REVISION', 'SUBMITTABLE'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002523 except (httplib.HTTPException, GerritChangeNotExists):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002524 return 'error'
2525
tandrii@chromium.org5e1bf382016-05-17 08:43:24 +00002526 if data['status'] in ('ABANDONED', 'MERGED'):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002527 return 'closed'
2528
Aaron Gable9ab38c62017-04-06 14:36:33 -07002529 if data['labels'].get('Commit-Queue', {}).get('approved'):
2530 # The section will have an "approved" subsection if anyone has voted
2531 # the maximum value on the label.
2532 return 'commit'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002533
Aaron Gable9ab38c62017-04-06 14:36:33 -07002534 if data['labels'].get('Code-Review', {}).get('approved'):
2535 return 'lgtm'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002536
2537 if not data.get('reviewers', {}).get('REVIEWER', []):
2538 return 'unsent'
2539
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01002540 owner = data['owner'].get('_account_id')
Aaron Gable9ab38c62017-04-06 14:36:33 -07002541 messages = sorted(data.get('messages', []), key=lambda m: m.get('updated'))
2542 last_message_author = messages.pop().get('author', {})
2543 while last_message_author:
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01002544 if last_message_author.get('email') == COMMIT_BOT_EMAIL:
2545 # Ignore replies from CQ.
Aaron Gable9ab38c62017-04-06 14:36:33 -07002546 last_message_author = messages.pop().get('author', {})
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01002547 continue
Aaron Gable9ab38c62017-04-06 14:36:33 -07002548 if last_message_author.get('_account_id') == owner:
2549 # Most recent message was by owner.
2550 return 'waiting'
2551 else:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002552 # Some reply from non-owner.
2553 return 'reply'
Aaron Gable9ab38c62017-04-06 14:36:33 -07002554
2555 # Somehow there are no messages even though there are reviewers.
2556 return 'unsent'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002557
2558 def GetMostRecentPatchset(self):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002559 data = self._GetChangeDetail(['CURRENT_REVISION'])
Aaron Gablee8856ee2017-12-07 12:41:46 -08002560 patchset = data['revisions'][data['current_revision']]['_number']
2561 self.SetPatchset(patchset)
2562 return patchset
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002563
Kenneth Russell61e2ed42017-02-15 11:47:13 -08002564 def FetchDescription(self, force=False):
2565 data = self._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'],
2566 no_cache=force)
tandrii@chromium.org2d3da632016-04-25 19:23:27 +00002567 current_rev = data['current_revision']
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +01002568 return data['revisions'][current_rev]['commit']['message']
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002569
dsansomee2d6fd92016-09-08 00:10:47 -07002570 def UpdateDescriptionRemote(self, description, force=False):
2571 if gerrit_util.HasPendingChangeEdit(self._GetGerritHost(), self.GetIssue()):
2572 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002573 confirm_or_exit(
dsansomee2d6fd92016-09-08 00:10:47 -07002574 'The description cannot be modified while the issue has a pending '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002575 'unpublished edit. Either publish the edit in the Gerrit web UI '
2576 'or delete it.\n\n', action='delete the unpublished edit')
dsansomee2d6fd92016-09-08 00:10:47 -07002577
2578 gerrit_util.DeletePendingChangeEdit(self._GetGerritHost(),
2579 self.GetIssue())
scottmg@chromium.org6d1266e2016-04-26 11:12:26 +00002580 gerrit_util.SetCommitMessage(self._GetGerritHost(), self.GetIssue(),
Andrii Shyshkalovea4fc832016-12-01 14:53:23 +01002581 description, notify='NONE')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002582
Aaron Gable636b13f2017-07-14 10:42:48 -07002583 def AddComment(self, message, publish=None):
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002584 gerrit_util.SetReview(self._GetGerritHost(), self.GetIssue(),
Aaron Gable636b13f2017-07-14 10:42:48 -07002585 msg=message, ready=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002586
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002587 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002588 # DETAILED_ACCOUNTS is to get emails in accounts.
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002589 messages = self._GetChangeDetail(
2590 options=['MESSAGES', 'DETAILED_ACCOUNTS']).get('messages', [])
2591 file_comments = gerrit_util.GetChangeComments(
2592 self._GetGerritHost(), self.GetIssue())
2593
2594 # Build dictionary of file comments for easy access and sorting later.
2595 # {author+date: {path: {patchset: {line: url+message}}}}
2596 comments = collections.defaultdict(
2597 lambda: collections.defaultdict(lambda: collections.defaultdict(dict)))
2598 for path, line_comments in file_comments.iteritems():
2599 for comment in line_comments:
2600 if comment.get('tag', '').startswith('autogenerated'):
2601 continue
2602 key = (comment['author']['email'], comment['updated'])
2603 if comment.get('side', 'REVISION') == 'PARENT':
2604 patchset = 'Base'
2605 else:
2606 patchset = 'PS%d' % comment['patch_set']
2607 line = comment.get('line', 0)
2608 url = ('https://%s/c/%s/%s/%s#%s%s' %
2609 (self._GetGerritHost(), self.GetIssue(), comment['patch_set'], path,
2610 'b' if comment.get('side') == 'PARENT' else '',
2611 str(line) if line else ''))
2612 comments[key][path][patchset][line] = (url, comment['message'])
2613
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002614 summary = []
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002615 for msg in messages:
2616 # Don't bother showing autogenerated messages.
2617 if msg.get('tag') and msg.get('tag').startswith('autogenerated'):
2618 continue
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002619 # Gerrit spits out nanoseconds.
2620 assert len(msg['date'].split('.')[-1]) == 9
2621 date = datetime.datetime.strptime(msg['date'][:-3],
2622 '%Y-%m-%d %H:%M:%S.%f')
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002623 message = msg['message']
2624 key = (msg['author']['email'], msg['date'])
2625 if key in comments:
2626 message += '\n'
2627 for path, patchsets in sorted(comments.get(key, {}).items()):
2628 if readable:
2629 message += '\n%s' % path
2630 for patchset, lines in sorted(patchsets.items()):
2631 for line, (url, content) in sorted(lines.items()):
2632 if line:
2633 line_str = 'Line %d' % line
2634 path_str = '%s:%d:' % (path, line)
2635 else:
2636 line_str = 'File comment'
2637 path_str = '%s:0:' % path
2638 if readable:
2639 message += '\n %s, %s: %s' % (patchset, line_str, url)
2640 message += '\n %s\n' % content
2641 else:
2642 message += '\n%s ' % path_str
2643 message += '\n%s\n' % content
2644
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002645 summary.append(_CommentSummary(
2646 date=date,
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002647 message=message,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002648 sender=msg['author']['email'],
2649 # These could be inferred from the text messages and correlated with
2650 # Code-Review label maximum, however this is not reliable.
2651 # Leaving as is until the need arises.
2652 approval=False,
2653 disapproval=False,
2654 ))
2655 return summary
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01002656
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002657 def CloseIssue(self):
2658 gerrit_util.AbandonChange(self._GetGerritHost(), self.GetIssue(), msg='')
2659
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002660 def SubmitIssue(self, wait_for_merge=True):
2661 gerrit_util.SubmitChange(self._GetGerritHost(), self.GetIssue(),
2662 wait_for_merge=wait_for_merge)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002663
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002664 def _GetChangeDetail(self, options=None, issue=None,
2665 no_cache=False):
2666 """Returns details of the issue by querying Gerrit and caching results.
2667
2668 If fresh data is needed, set no_cache=True which will clear cache and
2669 thus new data will be fetched from Gerrit.
2670 """
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002671 options = options or []
2672 issue = issue or self.GetIssue()
tandriic2405f52016-10-10 08:13:15 -07002673 assert issue, 'issue is required to query Gerrit'
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002674
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002675 # Optimization to avoid multiple RPCs:
2676 if (('CURRENT_REVISION' in options or 'ALL_REVISIONS' in options) and
2677 'CURRENT_COMMIT' not in options):
2678 options.append('CURRENT_COMMIT')
2679
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002680 # Normalize issue and options for consistent keys in cache.
2681 issue = str(issue)
2682 options = [o.upper() for o in options]
2683
2684 # Check in cache first unless no_cache is True.
2685 if no_cache:
2686 self._detail_cache.pop(issue, None)
2687 else:
2688 options_set = frozenset(options)
2689 for cached_options_set, data in self._detail_cache.get(issue, []):
2690 # Assumption: data fetched before with extra options is suitable
2691 # for return for a smaller set of options.
2692 # For example, if we cached data for
2693 # options=[CURRENT_REVISION, DETAILED_FOOTERS]
2694 # and request is for options=[CURRENT_REVISION],
2695 # THEN we can return prior cached data.
2696 if options_set.issubset(cached_options_set):
2697 return data
2698
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002699 try:
Aaron Gable19ee16c2017-04-18 11:56:35 -07002700 data = gerrit_util.GetChangeDetail(
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002701 self._GetGerritHost(), str(issue), options)
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002702 except gerrit_util.GerritError as e:
2703 if e.http_status == 404:
Aaron Gablea45ee112016-11-22 15:14:38 -08002704 raise GerritChangeNotExists(issue, self.GetCodereviewServer())
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002705 raise
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002706
2707 self._detail_cache.setdefault(issue, []).append((frozenset(options), data))
tandriic2405f52016-10-10 08:13:15 -07002708 return data
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002709
agable32978d92016-11-01 12:55:02 -07002710 def _GetChangeCommit(self, issue=None):
2711 issue = issue or self.GetIssue()
2712 assert issue, 'issue is required to query Gerrit'
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002713 try:
2714 data = gerrit_util.GetChangeCommit(self._GetGerritHost(), str(issue))
2715 except gerrit_util.GerritError as e:
2716 if e.http_status == 404:
2717 raise GerritChangeNotExists(issue, self.GetCodereviewServer())
2718 raise
agable32978d92016-11-01 12:55:02 -07002719 return data
2720
Olivier Robin75ee7252018-04-13 10:02:56 +02002721 def CMDLand(self, force, bypass_hooks, verbose, parallel):
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002722 if git_common.is_dirty_git_tree('land'):
2723 return 1
tandriid60367b2016-06-22 05:25:12 -07002724 detail = self._GetChangeDetail(['CURRENT_REVISION', 'LABELS'])
2725 if u'Commit-Queue' in detail.get('labels', {}):
2726 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002727 confirm_or_exit('\nIt seems this repository has a Commit Queue, '
2728 'which can test and land changes for you. '
2729 'Are you sure you wish to bypass it?\n',
2730 action='bypass CQ')
tandriid60367b2016-06-22 05:25:12 -07002731
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002732 differs = True
tandriic4344b52016-08-29 06:04:54 -07002733 last_upload = self._GitGetBranchConfigValue('gerritsquashhash')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002734 # Note: git diff outputs nothing if there is no diff.
2735 if not last_upload or RunGit(['diff', last_upload]).strip():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002736 print('WARNING: Some changes from local branch haven\'t been uploaded.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002737 else:
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002738 if detail['current_revision'] == last_upload:
2739 differs = False
2740 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002741 print('WARNING: Local branch contents differ from latest uploaded '
2742 'patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002743 if differs:
2744 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002745 confirm_or_exit(
2746 'Do you want to submit latest Gerrit patchset and bypass hooks?\n',
2747 action='submit')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002748 print('WARNING: Bypassing hooks and submitting latest uploaded patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002749 elif not bypass_hooks:
2750 hook_results = self.RunHook(
2751 committing=True,
2752 may_prompt=not force,
2753 verbose=verbose,
Olivier Robin75ee7252018-04-13 10:02:56 +02002754 change=self.GetChange(self.GetCommonAncestorWithUpstream(), None),
2755 parallel=parallel)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002756 if not hook_results.should_continue():
2757 return 1
2758
2759 self.SubmitIssue(wait_for_merge=True)
2760 print('Issue %s has been submitted.' % self.GetIssueURL())
agable32978d92016-11-01 12:55:02 -07002761 links = self._GetChangeCommit().get('web_links', [])
2762 for link in links:
Aaron Gable02cdbb42016-12-13 16:24:25 -08002763 if link.get('name') == 'gitiles' and link.get('url'):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002764 print('Landed as: %s' % link.get('url'))
agable32978d92016-11-01 12:55:02 -07002765 break
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002766 return 0
2767
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002768 def CMDPatchWithParsedIssue(self, parsed_issue_arg, reject, nocommit,
Aaron Gable62619a32017-06-16 08:22:09 -07002769 directory, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002770 assert not reject
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002771 assert not directory
2772 assert parsed_issue_arg.valid
2773
2774 self._changelist.issue = parsed_issue_arg.issue
2775
2776 if parsed_issue_arg.hostname:
2777 self._gerrit_host = parsed_issue_arg.hostname
2778 self._gerrit_server = 'https://%s' % self._gerrit_host
2779
tandriic2405f52016-10-10 08:13:15 -07002780 try:
2781 detail = self._GetChangeDetail(['ALL_REVISIONS'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002782 except GerritChangeNotExists as e:
tandriic2405f52016-10-10 08:13:15 -07002783 DieWithError(str(e))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002784
2785 if not parsed_issue_arg.patchset:
2786 # Use current revision by default.
2787 revision_info = detail['revisions'][detail['current_revision']]
2788 patchset = int(revision_info['_number'])
2789 else:
2790 patchset = parsed_issue_arg.patchset
2791 for revision_info in detail['revisions'].itervalues():
2792 if int(revision_info['_number']) == parsed_issue_arg.patchset:
2793 break
2794 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08002795 DieWithError('Couldn\'t find patchset %i in change %i' %
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002796 (parsed_issue_arg.patchset, self.GetIssue()))
2797
Aaron Gable697a91b2018-01-19 15:20:15 -08002798 remote_url = self._changelist.GetRemoteUrl()
2799 if remote_url.endswith('.git'):
2800 remote_url = remote_url[:-len('.git')]
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002801 fetch_info = revision_info['fetch']['http']
Aaron Gable697a91b2018-01-19 15:20:15 -08002802
2803 if remote_url != fetch_info['url']:
2804 DieWithError('Trying to patch a change from %s but this repo appears '
2805 'to be %s.' % (fetch_info['url'], remote_url))
2806
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002807 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
Aaron Gable9387b4f2017-06-08 10:50:03 -07002808
Aaron Gable62619a32017-06-16 08:22:09 -07002809 if force:
2810 RunGit(['reset', '--hard', 'FETCH_HEAD'])
2811 print('Checked out commit for change %i patchset %i locally' %
2812 (parsed_issue_arg.issue, patchset))
Stefan Zager2d5f0392017-10-10 15:17:53 -07002813 elif nocommit:
2814 RunGit(['cherry-pick', '--no-commit', 'FETCH_HEAD'])
2815 print('Patch applied to index.')
Aaron Gable62619a32017-06-16 08:22:09 -07002816 else:
Aaron Gable9387b4f2017-06-08 10:50:03 -07002817 RunGit(['cherry-pick', 'FETCH_HEAD'])
2818 print('Committed patch for change %i patchset %i locally.' %
Aaron Gable62619a32017-06-16 08:22:09 -07002819 (parsed_issue_arg.issue, patchset))
2820 print('Note: this created a local commit which does not have '
2821 'the same hash as the one uploaded for review. This will make '
2822 'uploading changes based on top of this branch difficult.\n'
2823 'If you want to do that, use "git cl patch --force" instead.')
2824
Stefan Zagerd08043c2017-10-12 12:07:02 -07002825 if self.GetBranch():
2826 self.SetIssue(parsed_issue_arg.issue)
2827 self.SetPatchset(patchset)
2828 fetched_hash = RunGit(['rev-parse', 'FETCH_HEAD']).strip()
2829 self._GitSetBranchConfigValue('last-upload-hash', fetched_hash)
2830 self._GitSetBranchConfigValue('gerritsquashhash', fetched_hash)
2831 else:
2832 print('WARNING: You are in detached HEAD state.\n'
2833 'The patch has been applied to your checkout, but you will not be '
2834 'able to upload a new patch set to the gerrit issue.\n'
2835 'Try using the \'-b\' option if you would like to work on a '
2836 'branch and/or upload a new patch set.')
2837
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002838 return 0
2839
2840 @staticmethod
2841 def ParseIssueURL(parsed_url):
2842 if not parsed_url.scheme or not parsed_url.scheme.startswith('http'):
2843 return None
Aaron Gable01b91062017-08-24 17:48:40 -07002844 # Gerrit's new UI is https://domain/c/project/+/<issue_number>[/[patchset]]
2845 # But old GWT UI is https://domain/#/c/project/+/<issue_number>[/[patchset]]
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002846 # Short urls like https://domain/<issue_number> can be used, but don't allow
2847 # specifying the patchset (you'd 404), but we allow that here.
2848 if parsed_url.path == '/':
2849 part = parsed_url.fragment
2850 else:
2851 part = parsed_url.path
Aaron Gable01b91062017-08-24 17:48:40 -07002852 match = re.match('(/c(/.*/\+)?)?/(\d+)(/(\d+)?/?)?$', part)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002853 if match:
2854 return _ParsedIssueNumberArgument(
Aaron Gable01b91062017-08-24 17:48:40 -07002855 issue=int(match.group(3)),
2856 patchset=int(match.group(5)) if match.group(5) else None,
Andrii Shyshkalov90f31922017-04-10 16:10:21 +02002857 hostname=parsed_url.netloc,
2858 codereview='gerrit')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002859 return None
2860
tandrii16e0b4e2016-06-07 10:34:28 -07002861 def _GerritCommitMsgHookCheck(self, offer_removal):
2862 hook = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
2863 if not os.path.exists(hook):
2864 return
2865 # Crude attempt to distinguish Gerrit Codereview hook from potentially
2866 # custom developer made one.
2867 data = gclient_utils.FileRead(hook)
2868 if not('From Gerrit Code Review' in data and 'add_ChangeId()' in data):
2869 return
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002870 print('WARNING: You have Gerrit commit-msg hook installed.\n'
qyearsley12fa6ff2016-08-24 09:18:40 -07002871 'It is not necessary for uploading with git cl in squash mode, '
tandrii16e0b4e2016-06-07 10:34:28 -07002872 'and may interfere with it in subtle ways.\n'
2873 'We recommend you remove the commit-msg hook.')
2874 if offer_removal:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002875 if ask_for_explicit_yes('Do you want to remove it now?'):
tandrii16e0b4e2016-06-07 10:34:28 -07002876 gclient_utils.rm_file_or_tree(hook)
2877 print('Gerrit commit-msg hook removed.')
2878 else:
2879 print('OK, will keep Gerrit commit-msg hook in place.')
2880
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002881 def CMDUploadChange(self, options, git_diff_args, custom_cl_base, change):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002882 """Upload the current branch to Gerrit."""
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00002883 if options.squash and options.no_squash:
2884 DieWithError('Can only use one of --squash or --no-squash')
tandriia60502f2016-06-20 02:01:53 -07002885
2886 if not options.squash and not options.no_squash:
2887 # Load default for user, repo, squash=true, in this order.
2888 options.squash = settings.GetSquashGerritUploads()
2889 elif options.no_squash:
2890 options.squash = False
tandrii26f3e4e2016-06-10 08:37:04 -07002891
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002892 remote, remote_branch = self.GetRemoteBranch()
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01002893 branch = GetTargetRef(remote, remote_branch, options.target_branch)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002894
Aaron Gableb56ad332017-01-06 15:24:31 -08002895 # This may be None; default fallback value is determined in logic below.
2896 title = options.title
2897
Dominic Battre7d1c4842017-10-27 09:17:28 +02002898 # Extract bug number from branch name.
2899 bug = options.bug
2900 match = re.match(r'(?:bug|fix)[_-]?(\d+)', self.GetBranch())
2901 if not bug and match:
2902 bug = match.group(1)
2903
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002904 if options.squash:
tandrii16e0b4e2016-06-07 10:34:28 -07002905 self._GerritCommitMsgHookCheck(offer_removal=not options.force)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002906 if self.GetIssue():
2907 # Try to get the message from a previous upload.
2908 message = self.GetDescription()
2909 if not message:
2910 DieWithError(
Aaron Gablea45ee112016-11-22 15:14:38 -08002911 'failed to fetch description from current Gerrit change %d\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002912 '%s' % (self.GetIssue(), self.GetIssueURL()))
Aaron Gableb56ad332017-01-06 15:24:31 -08002913 if not title:
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002914 if options.message:
Aaron Gable7303dcb2017-06-07 14:17:32 -07002915 # When uploading a subsequent patchset, -m|--message is taken
2916 # as the patchset title if --title was not provided.
2917 title = options.message.strip()
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002918 else:
2919 default_title = RunGit(
2920 ['show', '-s', '--format=%s', 'HEAD']).strip()
Aaron Gable7303dcb2017-06-07 14:17:32 -07002921 if options.force:
2922 title = default_title
2923 else:
2924 title = ask_for_data(
2925 'Title for patchset [%s]: ' % default_title) or default_title
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002926 change_id = self._GetChangeDetail()['change_id']
2927 while True:
2928 footer_change_ids = git_footers.get_footer_change_id(message)
2929 if footer_change_ids == [change_id]:
2930 break
2931 if not footer_change_ids:
2932 message = git_footers.add_footer_change_id(message, change_id)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002933 print('WARNING: appended missing Change-Id to change description.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002934 continue
2935 # There is already a valid footer but with different or several ids.
2936 # Doing this automatically is non-trivial as we don't want to lose
2937 # existing other footers, yet we want to append just 1 desired
2938 # Change-Id. Thus, just create a new footer, but let user verify the
2939 # new description.
2940 message = '%s\n\nChange-Id: %s' % (message, change_id)
2941 print(
Aaron Gablea45ee112016-11-22 15:14:38 -08002942 'WARNING: change %s has Change-Id footer(s):\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002943 ' %s\n'
Aaron Gablea45ee112016-11-22 15:14:38 -08002944 'but change has Change-Id %s, according to Gerrit.\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002945 'Please, check the proposed correction to the description, '
2946 'and edit it if necessary but keep the "Change-Id: %s" footer\n'
2947 % (self.GetIssue(), '\n '.join(footer_change_ids), change_id,
2948 change_id))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002949 confirm_or_exit(action='edit')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002950 if not options.force:
2951 change_desc = ChangeDescription(message)
Dominic Battre7d1c4842017-10-27 09:17:28 +02002952 change_desc.prompt(bug=bug)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002953 message = change_desc.description
2954 if not message:
2955 DieWithError("Description is empty. Aborting...")
2956 # Continue the while loop.
2957 # Sanity check of this code - we should end up with proper message
2958 # footer.
2959 assert [change_id] == git_footers.get_footer_change_id(message)
2960 change_desc = ChangeDescription(message)
Aaron Gableb56ad332017-01-06 15:24:31 -08002961 else: # if not self.GetIssue()
2962 if options.message:
2963 message = options.message
2964 else:
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002965 message = CreateDescriptionFromLog(git_diff_args)
Aaron Gableb56ad332017-01-06 15:24:31 -08002966 if options.title:
2967 message = options.title + '\n\n' + message
2968 change_desc = ChangeDescription(message)
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002969
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002970 if not options.force:
Dominic Battre7d1c4842017-10-27 09:17:28 +02002971 change_desc.prompt(bug=bug)
Aaron Gableb56ad332017-01-06 15:24:31 -08002972 # On first upload, patchset title is always this string, while
2973 # --title flag gets converted to first line of message.
2974 title = 'Initial upload'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002975 if not change_desc.description:
2976 DieWithError("Description is empty. Aborting...")
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002977 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002978 if len(change_ids) > 1:
2979 DieWithError('too many Change-Id footers, at most 1 allowed.')
2980 if not change_ids:
2981 # Generate the Change-Id automatically.
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002982 change_desc.set_description(git_footers.add_footer_change_id(
2983 change_desc.description,
2984 GenerateGerritChangeId(change_desc.description)))
2985 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002986 assert len(change_ids) == 1
2987 change_id = change_ids[0]
2988
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002989 if options.reviewers or options.tbrs or options.add_owners_to:
2990 change_desc.update_reviewers(options.reviewers, options.tbrs,
2991 options.add_owners_to, change)
2992
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002993 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002994 parent = self._ComputeParent(remote, upstream_branch, custom_cl_base,
2995 options.force, change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002996 tree = RunGit(['rev-parse', 'HEAD:']).strip()
Aaron Gable9a03ae02017-11-03 11:31:07 -07002997 with tempfile.NamedTemporaryFile(delete=False) as desc_tempfile:
2998 desc_tempfile.write(change_desc.description)
2999 desc_tempfile.close()
3000 ref_to_push = RunGit(['commit-tree', tree, '-p', parent,
3001 '-F', desc_tempfile.name]).strip()
3002 os.remove(desc_tempfile.name)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003003 else:
3004 change_desc = ChangeDescription(
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02003005 options.message or CreateDescriptionFromLog(git_diff_args))
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003006 if not change_desc.description:
3007 DieWithError("Description is empty. Aborting...")
3008
3009 if not git_footers.get_footer_change_id(change_desc.description):
3010 DownloadGerritHook(False)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02003011 change_desc.set_description(
3012 self._AddChangeIdToCommitMessage(options, git_diff_args))
Robert Iannuccidb02dd02017-04-19 12:18:20 -07003013 if options.reviewers or options.tbrs or options.add_owners_to:
3014 change_desc.update_reviewers(options.reviewers, options.tbrs,
3015 options.add_owners_to, change)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003016 ref_to_push = 'HEAD'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02003017 # For no-squash mode, we assume the remote called "origin" is the one we
3018 # want. It is not worthwhile to support different workflows for
3019 # no-squash mode.
3020 parent = 'origin/%s' % branch
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003021 change_id = git_footers.get_footer_change_id(change_desc.description)[0]
3022
3023 assert change_desc
3024 commits = RunGitSilent(['rev-list', '%s..%s' % (parent,
3025 ref_to_push)]).splitlines()
3026 if len(commits) > 1:
3027 print('WARNING: This will upload %d commits. Run the following command '
3028 'to see which commits will be uploaded: ' % len(commits))
3029 print('git log %s..%s' % (parent, ref_to_push))
3030 print('You can also use `git squash-branch` to squash these into a '
3031 'single commit.')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01003032 confirm_or_exit(action='upload')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003033
Aaron Gable6dadfbf2017-05-09 14:27:58 -07003034 if options.reviewers or options.tbrs or options.add_owners_to:
3035 change_desc.update_reviewers(options.reviewers, options.tbrs,
3036 options.add_owners_to, change)
3037
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00003038 # Extra options that can be specified at push time. Doc:
3039 # https://gerrit-review.googlesource.com/Documentation/user-upload.html
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00003040 refspec_opts = []
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02003041
Aaron Gable844cf292017-06-28 11:32:59 -07003042 # By default, new changes are started in WIP mode, and subsequent patchsets
3043 # don't send email. At any time, passing --send-mail will mark the change
3044 # ready and send email for that particular patch.
Aaron Gableafd52772017-06-27 16:40:10 -07003045 if options.send_mail:
3046 refspec_opts.append('ready')
Aaron Gable844cf292017-06-28 11:32:59 -07003047 refspec_opts.append('notify=ALL')
Jamie Madill276da0b2018-04-27 14:41:20 -04003048 elif not self.GetIssue() and options.squash:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08003049 refspec_opts.append('wip')
Aaron Gableafd52772017-06-27 16:40:10 -07003050 else:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08003051 refspec_opts.append('notify=NONE')
Aaron Gable70f4e242017-06-26 10:45:59 -07003052
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02003053 # TODO(tandrii): options.message should be posted as a comment
Aaron Gablee5adf612017-07-14 10:43:58 -07003054 # if --send-mail is set on non-initial upload as Rietveld used to do it.
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02003055
Aaron Gable9b713dd2016-12-14 16:04:21 -08003056 if title:
Nick Carter8692b182017-11-06 16:30:38 -08003057 # Punctuation and whitespace in |title| must be percent-encoded.
3058 refspec_opts.append('m=' + gerrit_util.PercentEncodeForGitRef(title))
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00003059
agablec6787972016-09-09 16:13:34 -07003060 if options.private:
Aaron Gableb02daf02017-05-23 11:53:46 -07003061 refspec_opts.append('private')
agablec6787972016-09-09 16:13:34 -07003062
rmistry9eadede2016-09-19 11:22:43 -07003063 if options.topic:
3064 # Documentation on Gerrit topics is here:
3065 # https://gerrit-review.googlesource.com/Documentation/user-upload.html#topic
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00003066 refspec_opts.append('topic=%s' % options.topic)
rmistry9eadede2016-09-19 11:22:43 -07003067
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08003068 # Gerrit sorts hashtags, so order is not important.
Nodir Turakulov23b82142017-11-16 11:04:25 -08003069 hashtags = {change_desc.sanitize_hash_tag(t) for t in options.hashtags}
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08003070 if not self.GetIssue():
Nodir Turakulov23b82142017-11-16 11:04:25 -08003071 hashtags.update(change_desc.get_hash_tags())
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08003072 refspec_opts += ['hashtag=%s' % t for t in sorted(hashtags)]
3073
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00003074 refspec_suffix = ''
3075 if refspec_opts:
3076 refspec_suffix = '%' + ','.join(refspec_opts)
3077 assert ' ' not in refspec_suffix, (
3078 'spaces not allowed in refspec: "%s"' % refspec_suffix)
3079 refspec = '%s:refs/for/%s%s' % (ref_to_push, branch, refspec_suffix)
3080
Andrii Shyshkalov7d518832016-12-15 20:48:21 +01003081 try:
3082 push_stdout = gclient_utils.CheckCallAndFilter(
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00003083 ['git', 'push', self.GetRemoteUrl(), refspec],
3084 print_stdout=True,
Andrii Shyshkalov7d518832016-12-15 20:48:21 +01003085 # Flush after every line: useful for seeing progress when running as
3086 # recipe.
3087 filter_fn=lambda _: sys.stdout.flush())
3088 except subprocess2.CalledProcessError:
3089 DieWithError('Failed to create a change. Please examine output above '
Andrii Shyshkalov9d932212017-04-10 14:28:23 +02003090 'for the reason of the failure.\n'
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003091 'Hint: run command below to diagnose common Git/Gerrit '
Andrii Shyshkalov9d932212017-04-10 14:28:23 +02003092 'credential problems:\n'
3093 ' git cl creds-check\n',
3094 change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003095
3096 if options.squash:
Aaron Gable289b4312017-09-13 14:06:16 -07003097 regex = re.compile(r'remote:\s+https?://[\w\-\.\+\/#]*/(\d+)\s.*')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003098 change_numbers = [m.group(1)
3099 for m in map(regex.match, push_stdout.splitlines())
3100 if m]
3101 if len(change_numbers) != 1:
3102 DieWithError(
3103 ('Created|Updated %d issues on Gerrit, but only 1 expected.\n'
Christopher Lamf732cd52017-01-24 12:40:11 +11003104 'Change-Id: %s') % (len(change_numbers), change_id), change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003105 self.SetIssue(change_numbers[0])
tandrii5d48c322016-08-18 16:19:37 -07003106 self._GitSetBranchConfigValue('gerritsquashhash', ref_to_push)
tandrii88189772016-09-29 04:29:57 -07003107
Aaron Gable6dadfbf2017-05-09 14:27:58 -07003108 reviewers = sorted(change_desc.get_reviewers())
3109
tandrii88189772016-09-29 04:29:57 -07003110 # Add cc's from the CC_LIST and --cc flag (if any).
Aaron Gabled1052492017-05-15 15:05:34 -07003111 if not options.private:
3112 cc = self.GetCCList().split(',')
3113 else:
3114 cc = []
tandrii88189772016-09-29 04:29:57 -07003115 if options.cc:
3116 cc.extend(options.cc)
3117 cc = filter(None, [email.strip() for email in cc])
bradnelsond975b302016-10-23 12:20:23 -07003118 if change_desc.get_cced():
3119 cc.extend(change_desc.get_cced())
Aaron Gable6dadfbf2017-05-09 14:27:58 -07003120
3121 gerrit_util.AddReviewers(
3122 self._GetGerritHost(), self.GetIssue(), reviewers, cc,
3123 notify=bool(options.send_mail))
3124
Aaron Gablefd238082017-06-07 13:42:34 -07003125 if change_desc.get_reviewers(tbr_only=True):
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09003126 labels = self._GetChangeDetail(['LABELS']).get('labels', {})
3127 score = 1
3128 if 'Code-Review' in labels and 'values' in labels['Code-Review']:
3129 score = max([int(x) for x in labels['Code-Review']['values'].keys()])
3130 print('Adding self-LGTM (Code-Review +%d) because of TBRs.' % score)
Aaron Gablefd238082017-06-07 13:42:34 -07003131 gerrit_util.SetReview(
3132 self._GetGerritHost(), self.GetIssue(),
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09003133 msg='Self-approving for TBR',
3134 labels={'Code-Review': score})
Aaron Gablefd238082017-06-07 13:42:34 -07003135
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003136 return 0
3137
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02003138 def _ComputeParent(self, remote, upstream_branch, custom_cl_base, force,
3139 change_desc):
3140 """Computes parent of the generated commit to be uploaded to Gerrit.
3141
3142 Returns revision or a ref name.
3143 """
3144 if custom_cl_base:
3145 # Try to avoid creating additional unintended CLs when uploading, unless
3146 # user wants to take this risk.
3147 local_ref_of_target_remote = self.GetRemoteBranch()[1]
3148 code, _ = RunGitWithCode(['merge-base', '--is-ancestor', custom_cl_base,
3149 local_ref_of_target_remote])
3150 if code == 1:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003151 print('\nWARNING: Manually specified base of this CL `%s` '
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02003152 'doesn\'t seem to belong to target remote branch `%s`.\n\n'
3153 'If you proceed with upload, more than 1 CL may be created by '
3154 'Gerrit as a result, in turn confusing or crashing git cl.\n\n'
3155 'If you are certain that specified base `%s` has already been '
3156 'uploaded to Gerrit as another CL, you may proceed.\n' %
3157 (custom_cl_base, local_ref_of_target_remote, custom_cl_base))
3158 if not force:
3159 confirm_or_exit(
3160 'Do you take responsibility for cleaning up potential mess '
3161 'resulting from proceeding with upload?',
3162 action='upload')
3163 return custom_cl_base
3164
Aaron Gablef97e33d2017-03-30 15:44:27 -07003165 if remote != '.':
3166 return self.GetCommonAncestorWithUpstream()
3167
3168 # If our upstream branch is local, we base our squashed commit on its
3169 # squashed version.
3170 upstream_branch_name = scm.GIT.ShortBranchName(upstream_branch)
3171
Aaron Gablef97e33d2017-03-30 15:44:27 -07003172 if upstream_branch_name == 'master':
Aaron Gable0bbd1c22017-05-08 14:37:08 -07003173 return self.GetCommonAncestorWithUpstream()
Aaron Gablef97e33d2017-03-30 15:44:27 -07003174
3175 # Check the squashed hash of the parent.
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02003176 # TODO(tandrii): consider checking parent change in Gerrit and using its
3177 # hash if tree hash of latest parent revision (patchset) in Gerrit matches
3178 # the tree hash of the parent branch. The upside is less likely bogus
3179 # requests to reupload parent change just because it's uploadhash is
3180 # missing, yet the downside likely exists, too (albeit unknown to me yet).
Aaron Gablef97e33d2017-03-30 15:44:27 -07003181 parent = RunGit(['config',
3182 'branch.%s.gerritsquashhash' % upstream_branch_name],
3183 error_ok=True).strip()
3184 # Verify that the upstream branch has been uploaded too, otherwise
3185 # Gerrit will create additional CLs when uploading.
3186 if not parent or (RunGitSilent(['rev-parse', upstream_branch + ':']) !=
3187 RunGitSilent(['rev-parse', parent + ':'])):
3188 DieWithError(
3189 '\nUpload upstream branch %s first.\n'
3190 'It is likely that this branch has been rebased since its last '
3191 'upload, so you just need to upload it again.\n'
3192 '(If you uploaded it with --no-squash, then branch dependencies '
3193 'are not supported, and you should reupload with --squash.)'
3194 % upstream_branch_name,
3195 change_desc)
3196 return parent
3197
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00003198 def _AddChangeIdToCommitMessage(self, options, args):
3199 """Re-commits using the current message, assumes the commit hook is in
3200 place.
3201 """
3202 log_desc = options.message or CreateDescriptionFromLog(args)
3203 git_command = ['commit', '--amend', '-m', log_desc]
3204 RunGit(git_command)
3205 new_log_desc = CreateDescriptionFromLog(args)
3206 if git_footers.get_footer_change_id(new_log_desc):
vapiera7fbd5a2016-06-16 09:17:49 -07003207 print('git-cl: Added Change-Id to commit message.')
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00003208 return new_log_desc
3209 else:
tandrii@chromium.orgb067ec52016-05-31 15:24:44 +00003210 DieWithError('ERROR: Gerrit commit-msg hook not installed.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003211
Ravi Mistry31e7d562018-04-02 12:53:57 -04003212 def SetLabels(self, enable_auto_submit, use_commit_queue, cq_dry_run):
3213 """Sets labels on the change based on the provided flags."""
3214 labels = {}
3215 notify = None;
3216 if enable_auto_submit:
3217 labels['Auto-Submit'] = 1
3218 if use_commit_queue:
3219 labels['Commit-Queue'] = 2
3220 elif cq_dry_run:
3221 labels['Commit-Queue'] = 1
3222 notify = False
3223 if labels:
3224 gerrit_util.SetReview(self._GetGerritHost(), self.GetIssue(),
3225 labels=labels, notify=notify)
3226
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00003227 def SetCQState(self, new_state):
3228 """Sets the Commit-Queue label assuming canonical CQ config for Gerrit."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00003229 vote_map = {
3230 _CQState.NONE: 0,
3231 _CQState.DRY_RUN: 1,
Andrii Shyshkalov18975322017-01-25 16:44:13 +01003232 _CQState.COMMIT: 2,
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00003233 }
Aaron Gablefc62f762017-07-17 11:12:07 -07003234 labels = {'Commit-Queue': vote_map[new_state]}
3235 notify = False if new_state == _CQState.DRY_RUN else None
3236 gerrit_util.SetReview(self._GetGerritHost(), self.GetIssue(),
3237 labels=labels, notify=notify)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00003238
tandriie113dfd2016-10-11 10:20:12 -07003239 def CannotTriggerTryJobReason(self):
tandrii8c5a3532016-11-04 07:52:02 -07003240 try:
3241 data = self._GetChangeDetail()
Aaron Gablea45ee112016-11-22 15:14:38 -08003242 except GerritChangeNotExists:
3243 return 'Gerrit doesn\'t know about your change %s' % self.GetIssue()
tandrii8c5a3532016-11-04 07:52:02 -07003244
3245 if data['status'] in ('ABANDONED', 'MERGED'):
3246 return 'CL %s is closed' % self.GetIssue()
3247
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003248 def GetTryJobProperties(self, patchset=None):
3249 """Returns dictionary of properties to launch try job."""
tandrii8c5a3532016-11-04 07:52:02 -07003250 data = self._GetChangeDetail(['ALL_REVISIONS'])
3251 patchset = int(patchset or self.GetPatchset())
3252 assert patchset
3253 revision_data = None # Pylint wants it to be defined.
3254 for revision_data in data['revisions'].itervalues():
3255 if int(revision_data['_number']) == patchset:
3256 break
3257 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08003258 raise Exception('Patchset %d is not known in Gerrit change %d' %
tandrii8c5a3532016-11-04 07:52:02 -07003259 (patchset, self.GetIssue()))
3260 return {
3261 'patch_issue': self.GetIssue(),
3262 'patch_set': patchset or self.GetPatchset(),
3263 'patch_project': data['project'],
3264 'patch_storage': 'gerrit',
3265 'patch_ref': revision_data['fetch']['http']['ref'],
3266 'patch_repository_url': revision_data['fetch']['http']['url'],
3267 'patch_gerrit_url': self.GetCodereviewServer(),
3268 }
tandriie113dfd2016-10-11 10:20:12 -07003269
tandriide281ae2016-10-12 06:02:30 -07003270 def GetIssueOwner(self):
tandrii8c5a3532016-11-04 07:52:02 -07003271 return self._GetChangeDetail(['DETAILED_ACCOUNTS'])['owner']['email']
tandriide281ae2016-10-12 06:02:30 -07003272
Edward Lemur707d70b2018-02-07 00:50:14 +01003273 def GetReviewers(self):
3274 details = self._GetChangeDetail(['DETAILED_ACCOUNTS'])
3275 return [reviewer['email'] for reviewer in details['reviewers']['REVIEWER']]
3276
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00003277
3278_CODEREVIEW_IMPLEMENTATIONS = {
3279 'rietveld': _RietveldChangelistImpl,
3280 'gerrit': _GerritChangelistImpl,
3281}
3282
tandrii@chromium.org013a2802016-03-29 09:52:33 +00003283
iannuccie53c9352016-08-17 14:40:40 -07003284def _add_codereview_issue_select_options(parser, extra=""):
3285 _add_codereview_select_options(parser)
3286
3287 text = ('Operate on this issue number instead of the current branch\'s '
3288 'implicit issue.')
3289 if extra:
3290 text += ' '+extra
3291 parser.add_option('-i', '--issue', type=int, help=text)
3292
3293
3294def _process_codereview_issue_select_options(parser, options):
3295 _process_codereview_select_options(parser, options)
3296 if options.issue is not None and not options.forced_codereview:
3297 parser.error('--issue must be specified with either --rietveld or --gerrit')
3298
3299
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00003300def _add_codereview_select_options(parser):
3301 """Appends --gerrit and --rietveld options to force specific codereview."""
3302 parser.codereview_group = optparse.OptionGroup(
3303 parser, 'EXPERIMENTAL! Codereview override options')
3304 parser.add_option_group(parser.codereview_group)
3305 parser.codereview_group.add_option(
3306 '--gerrit', action='store_true',
3307 help='Force the use of Gerrit for codereview')
3308 parser.codereview_group.add_option(
3309 '--rietveld', action='store_true',
3310 help='Force the use of Rietveld for codereview')
3311
3312
3313def _process_codereview_select_options(parser, options):
3314 if options.gerrit and options.rietveld:
3315 parser.error('Options --gerrit and --rietveld are mutually exclusive')
3316 options.forced_codereview = None
3317 if options.gerrit:
3318 options.forced_codereview = 'gerrit'
3319 elif options.rietveld:
3320 options.forced_codereview = 'rietveld'
3321
3322
tandriif9aefb72016-07-01 09:06:51 -07003323def _get_bug_line_values(default_project, bugs):
3324 """Given default_project and comma separated list of bugs, yields bug line
3325 values.
3326
3327 Each bug can be either:
3328 * a number, which is combined with default_project
3329 * string, which is left as is.
3330
3331 This function may produce more than one line, because bugdroid expects one
3332 project per line.
3333
3334 >>> list(_get_bug_line_values('v8', '123,chromium:789'))
3335 ['v8:123', 'chromium:789']
3336 """
3337 default_bugs = []
3338 others = []
3339 for bug in bugs.split(','):
3340 bug = bug.strip()
3341 if bug:
3342 try:
3343 default_bugs.append(int(bug))
3344 except ValueError:
3345 others.append(bug)
3346
3347 if default_bugs:
3348 default_bugs = ','.join(map(str, default_bugs))
3349 if default_project:
3350 yield '%s:%s' % (default_project, default_bugs)
3351 else:
3352 yield default_bugs
3353 for other in sorted(others):
3354 # Don't bother finding common prefixes, CLs with >2 bugs are very very rare.
3355 yield other
3356
3357
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003358class ChangeDescription(object):
3359 """Contains a parsed form of the change description."""
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00003360 R_LINE = r'^[ \t]*(TBR|R)[ \t]*=[ \t]*(.*?)[ \t]*$'
bradnelsond975b302016-10-23 12:20:23 -07003361 CC_LINE = r'^[ \t]*(CC)[ \t]*=[ \t]*(.*?)[ \t]*$'
Aaron Gable3a16ed12017-03-23 10:51:55 -07003362 BUG_LINE = r'^[ \t]*(?:(BUG)[ \t]*=|Bug:)[ \t]*(.*?)[ \t]*$'
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003363 CHERRY_PICK_LINE = r'^\(cherry picked from commit [a-fA-F0-9]{40}\)$'
Nodir Turakulov23b82142017-11-16 11:04:25 -08003364 STRIP_HASH_TAG_PREFIX = r'^(\s*(revert|reland)( "|:)?\s*)*'
3365 BRACKET_HASH_TAG = r'\s*\[([^\[\]]+)\]'
3366 COLON_SEPARATED_HASH_TAG = r'^([a-zA-Z0-9_\- ]+):'
3367 BAD_HASH_TAG_CHUNK = r'[^a-zA-Z0-9]+'
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003368
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003369 def __init__(self, description):
agable@chromium.org42c20792013-09-12 17:34:49 +00003370 self._description_lines = (description or '').strip().splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003371
agable@chromium.org42c20792013-09-12 17:34:49 +00003372 @property # www.logilab.org/ticket/89786
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003373 def description(self): # pylint: disable=method-hidden
agable@chromium.org42c20792013-09-12 17:34:49 +00003374 return '\n'.join(self._description_lines)
3375
3376 def set_description(self, desc):
3377 if isinstance(desc, basestring):
3378 lines = desc.splitlines()
3379 else:
3380 lines = [line.rstrip() for line in desc]
3381 while lines and not lines[0]:
3382 lines.pop(0)
3383 while lines and not lines[-1]:
3384 lines.pop(-1)
3385 self._description_lines = lines
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003386
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003387 def update_reviewers(self, reviewers, tbrs, add_owners_to=None, change=None):
3388 """Rewrites the R=/TBR= line(s) as a single line each.
3389
3390 Args:
3391 reviewers (list(str)) - list of additional emails to use for reviewers.
3392 tbrs (list(str)) - list of additional emails to use for TBRs.
3393 add_owners_to (None|'R'|'TBR') - Pass to do an OWNERS lookup for files in
3394 the change that are missing OWNER coverage. If this is not None, you
3395 must also pass a value for `change`.
3396 change (Change) - The Change that should be used for OWNERS lookups.
3397 """
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003398 assert isinstance(reviewers, list), reviewers
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003399 assert isinstance(tbrs, list), tbrs
3400
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003401 assert add_owners_to in (None, 'TBR', 'R'), add_owners_to
Robert Iannuccia28592e2017-04-18 13:14:49 -07003402 assert not add_owners_to or change, add_owners_to
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003403
3404 if not reviewers and not tbrs and not add_owners_to:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003405 return
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003406
3407 reviewers = set(reviewers)
3408 tbrs = set(tbrs)
3409 LOOKUP = {
3410 'TBR': tbrs,
3411 'R': reviewers,
3412 }
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003413
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003414 # Get the set of R= and TBR= lines and remove them from the description.
agable@chromium.org42c20792013-09-12 17:34:49 +00003415 regexp = re.compile(self.R_LINE)
3416 matches = [regexp.match(line) for line in self._description_lines]
3417 new_desc = [l for i, l in enumerate(self._description_lines)
3418 if not matches[i]]
3419 self.set_description(new_desc)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003420
agable@chromium.org42c20792013-09-12 17:34:49 +00003421 # Construct new unified R= and TBR= lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003422
3423 # First, update tbrs/reviewers with names from the R=/TBR= lines (if any).
agable@chromium.org42c20792013-09-12 17:34:49 +00003424 for match in matches:
3425 if not match:
3426 continue
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003427 LOOKUP[match.group(1)].update(cleanup_list([match.group(2).strip()]))
3428
3429 # Next, maybe fill in OWNERS coverage gaps to either tbrs/reviewers.
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003430 if add_owners_to:
piman@chromium.org336f9122014-09-04 02:16:55 +00003431 owners_db = owners.Database(change.RepositoryRoot(),
Jochen Eisinger72606f82017-04-04 10:44:18 +02003432 fopen=file, os_path=os.path)
piman@chromium.org336f9122014-09-04 02:16:55 +00003433 missing_files = owners_db.files_not_covered_by(change.LocalPaths(),
Robert Iannucci100aa212017-04-18 17:28:26 -07003434 (tbrs | reviewers))
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003435 LOOKUP[add_owners_to].update(
3436 owners_db.reviewers_for(missing_files, change.author_email))
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003437
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003438 # If any folks ended up in both groups, remove them from tbrs.
3439 tbrs -= reviewers
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003440
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003441 new_r_line = 'R=' + ', '.join(sorted(reviewers)) if reviewers else None
3442 new_tbr_line = 'TBR=' + ', '.join(sorted(tbrs)) if tbrs else None
agable@chromium.org42c20792013-09-12 17:34:49 +00003443
3444 # Put the new lines in the description where the old first R= line was.
3445 line_loc = next((i for i, match in enumerate(matches) if match), -1)
3446 if 0 <= line_loc < len(self._description_lines):
3447 if new_tbr_line:
3448 self._description_lines.insert(line_loc, new_tbr_line)
3449 if new_r_line:
3450 self._description_lines.insert(line_loc, new_r_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003451 else:
agable@chromium.org42c20792013-09-12 17:34:49 +00003452 if new_r_line:
3453 self.append_footer(new_r_line)
3454 if new_tbr_line:
3455 self.append_footer(new_tbr_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003456
Aaron Gable3a16ed12017-03-23 10:51:55 -07003457 def prompt(self, bug=None, git_footer=True):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003458 """Asks the user to update the description."""
agable@chromium.org42c20792013-09-12 17:34:49 +00003459 self.set_description([
3460 '# Enter a description of the change.',
3461 '# This will be displayed on the codereview site.',
3462 '# The first line will also be used as the subject of the review.',
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +00003463 '#--------------------This line is 72 characters long'
agable@chromium.org42c20792013-09-12 17:34:49 +00003464 '--------------------',
3465 ] + self._description_lines)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003466
agable@chromium.org42c20792013-09-12 17:34:49 +00003467 regexp = re.compile(self.BUG_LINE)
3468 if not any((regexp.match(line) for line in self._description_lines)):
tandriif9aefb72016-07-01 09:06:51 -07003469 prefix = settings.GetBugPrefix()
3470 values = list(_get_bug_line_values(prefix, bug or '')) or [prefix]
Aaron Gable3a16ed12017-03-23 10:51:55 -07003471 if git_footer:
3472 self.append_footer('Bug: %s' % ', '.join(values))
3473 else:
3474 for value in values:
3475 self.append_footer('BUG=%s' % value)
tandriif9aefb72016-07-01 09:06:51 -07003476
agable@chromium.org42c20792013-09-12 17:34:49 +00003477 content = gclient_utils.RunEditor(self.description, True,
jbroman@chromium.org615a2622013-05-03 13:20:14 +00003478 git_editor=settings.GetGitEditor())
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00003479 if not content:
3480 DieWithError('Running editor failed')
agable@chromium.org42c20792013-09-12 17:34:49 +00003481 lines = content.splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003482
Bruce Dawson2377b012018-01-11 16:46:49 -08003483 # Strip off comments and default inserted "Bug:" line.
3484 clean_lines = [line.rstrip() for line in lines if not
3485 (line.startswith('#') or line.rstrip() == "Bug:")]
agable@chromium.org42c20792013-09-12 17:34:49 +00003486 if not clean_lines:
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00003487 DieWithError('No CL description, aborting')
agable@chromium.org42c20792013-09-12 17:34:49 +00003488 self.set_description(clean_lines)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003489
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003490 def append_footer(self, line):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00003491 """Adds a footer line to the description.
3492
3493 Differentiates legacy "KEY=xxx" footers (used to be called tags) and
3494 Gerrit's footers in the form of "Footer-Key: footer any value" and ensures
3495 that Gerrit footers are always at the end.
3496 """
3497 parsed_footer_line = git_footers.parse_footer(line)
3498 if parsed_footer_line:
3499 # Line is a gerrit footer in the form: Footer-Key: any value.
3500 # Thus, must be appended observing Gerrit footer rules.
3501 self.set_description(
3502 git_footers.add_footer(self.description,
3503 key=parsed_footer_line[0],
3504 value=parsed_footer_line[1]))
3505 return
3506
3507 if not self._description_lines:
3508 self._description_lines.append(line)
3509 return
3510
3511 top_lines, gerrit_footers, _ = git_footers.split_footers(self.description)
3512 if gerrit_footers:
3513 # git_footers.split_footers ensures that there is an empty line before
3514 # actual (gerrit) footers, if any. We have to keep it that way.
3515 assert top_lines and top_lines[-1] == ''
3516 top_lines, separator = top_lines[:-1], top_lines[-1:]
3517 else:
3518 separator = [] # No need for separator if there are no gerrit_footers.
3519
3520 prev_line = top_lines[-1] if top_lines else ''
3521 if (not presubmit_support.Change.TAG_LINE_RE.match(prev_line) or
3522 not presubmit_support.Change.TAG_LINE_RE.match(line)):
3523 top_lines.append('')
3524 top_lines.append(line)
3525 self._description_lines = top_lines + separator + gerrit_footers
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003526
tandrii99a72f22016-08-17 14:33:24 -07003527 def get_reviewers(self, tbr_only=False):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003528 """Retrieves the list of reviewers."""
agable@chromium.org42c20792013-09-12 17:34:49 +00003529 matches = [re.match(self.R_LINE, line) for line in self._description_lines]
tandrii99a72f22016-08-17 14:33:24 -07003530 reviewers = [match.group(2).strip()
3531 for match in matches
3532 if match and (not tbr_only or match.group(1).upper() == 'TBR')]
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003533 return cleanup_list(reviewers)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003534
bradnelsond975b302016-10-23 12:20:23 -07003535 def get_cced(self):
3536 """Retrieves the list of reviewers."""
3537 matches = [re.match(self.CC_LINE, line) for line in self._description_lines]
3538 cced = [match.group(2).strip() for match in matches if match]
3539 return cleanup_list(cced)
3540
Nodir Turakulov23b82142017-11-16 11:04:25 -08003541 def get_hash_tags(self):
3542 """Extracts and sanitizes a list of Gerrit hashtags."""
3543 subject = (self._description_lines or ('',))[0]
3544 subject = re.sub(
3545 self.STRIP_HASH_TAG_PREFIX, '', subject, flags=re.IGNORECASE)
3546
3547 tags = []
3548 start = 0
3549 bracket_exp = re.compile(self.BRACKET_HASH_TAG)
3550 while True:
3551 m = bracket_exp.match(subject, start)
3552 if not m:
3553 break
3554 tags.append(self.sanitize_hash_tag(m.group(1)))
3555 start = m.end()
3556
3557 if not tags:
3558 # Try "Tag: " prefix.
3559 m = re.match(self.COLON_SEPARATED_HASH_TAG, subject)
3560 if m:
3561 tags.append(self.sanitize_hash_tag(m.group(1)))
3562 return tags
3563
3564 @classmethod
3565 def sanitize_hash_tag(cls, tag):
3566 """Returns a sanitized Gerrit hash tag.
3567
3568 A sanitized hashtag can be used as a git push refspec parameter value.
3569 """
3570 return re.sub(cls.BAD_HASH_TAG_CHUNK, '-', tag).strip('-').lower()
3571
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003572 def update_with_git_number_footers(self, parent_hash, parent_msg, dest_ref):
3573 """Updates this commit description given the parent.
3574
3575 This is essentially what Gnumbd used to do.
3576 Consult https://goo.gl/WMmpDe for more details.
3577 """
3578 assert parent_msg # No, orphan branch creation isn't supported.
3579 assert parent_hash
3580 assert dest_ref
3581 parent_footer_map = git_footers.parse_footers(parent_msg)
3582 # This will also happily parse svn-position, which GnumbD is no longer
3583 # supporting. While we'd generate correct footers, the verifier plugin
3584 # installed in Gerrit will block such commit (ie git push below will fail).
3585 parent_position = git_footers.get_position(parent_footer_map)
3586
3587 # Cherry-picks may have last line obscuring their prior footers,
3588 # from git_footers perspective. This is also what Gnumbd did.
3589 cp_line = None
3590 if (self._description_lines and
3591 re.match(self.CHERRY_PICK_LINE, self._description_lines[-1])):
3592 cp_line = self._description_lines.pop()
3593
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003594 top_lines, footer_lines, _ = git_footers.split_footers(self.description)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003595
3596 # Original-ify all Cr- footers, to avoid re-lands, cherry-picks, or just
3597 # user interference with actual footers we'd insert below.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003598 for i, line in enumerate(footer_lines):
3599 k, v = git_footers.parse_footer(line) or (None, None)
3600 if k and k.startswith('Cr-'):
3601 footer_lines[i] = '%s: %s' % ('Cr-Original-' + k[len('Cr-'):], v)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003602
3603 # Add Position and Lineage footers based on the parent.
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +01003604 lineage = list(reversed(parent_footer_map.get('Cr-Branched-From', [])))
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003605 if parent_position[0] == dest_ref:
3606 # Same branch as parent.
3607 number = int(parent_position[1]) + 1
3608 else:
3609 number = 1 # New branch, and extra lineage.
3610 lineage.insert(0, '%s-%s@{#%d}' % (parent_hash, parent_position[0],
3611 int(parent_position[1])))
3612
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003613 footer_lines.append('Cr-Commit-Position: %s@{#%d}' % (dest_ref, number))
3614 footer_lines.extend('Cr-Branched-From: %s' % v for v in lineage)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003615
3616 self._description_lines = top_lines
3617 if cp_line:
3618 self._description_lines.append(cp_line)
3619 if self._description_lines[-1] != '':
3620 self._description_lines.append('') # Ensure footer separator.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003621 self._description_lines.extend(footer_lines)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003622
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003623
Aaron Gablea1bab272017-04-11 16:38:18 -07003624def get_approving_reviewers(props, disapproval=False):
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003625 """Retrieves the reviewers that approved a CL from the issue properties with
3626 messages.
3627
3628 Note that the list may contain reviewers that are not committer, thus are not
3629 considered by the CQ.
Aaron Gablea1bab272017-04-11 16:38:18 -07003630
3631 If disapproval is True, instead returns reviewers who 'not lgtm'd the CL.
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003632 """
Aaron Gablea1bab272017-04-11 16:38:18 -07003633 approval_type = 'disapproval' if disapproval else 'approval'
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003634 return sorted(
3635 set(
3636 message['sender']
3637 for message in props['messages']
Aaron Gablea1bab272017-04-11 16:38:18 -07003638 if message[approval_type] and message['sender'] in props['reviewers']
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003639 )
3640 )
3641
3642
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003643def FindCodereviewSettingsFile(filename='codereview.settings'):
3644 """Finds the given file starting in the cwd and going up.
3645
3646 Only looks up to the top of the repository unless an
3647 'inherit-review-settings-ok' file exists in the root of the repository.
3648 """
3649 inherit_ok_file = 'inherit-review-settings-ok'
3650 cwd = os.getcwd()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00003651 root = settings.GetRoot()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003652 if os.path.isfile(os.path.join(root, inherit_ok_file)):
3653 root = '/'
3654 while True:
3655 if filename in os.listdir(cwd):
3656 if os.path.isfile(os.path.join(cwd, filename)):
3657 return open(os.path.join(cwd, filename))
3658 if cwd == root:
3659 break
3660 cwd = os.path.dirname(cwd)
3661
3662
3663def LoadCodereviewSettingsFromFile(fileobj):
3664 """Parse a codereview.settings file and updates hooks."""
maruel@chromium.org99ac1c52012-01-16 14:52:12 +00003665 keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003666
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003667 def SetProperty(name, setting, unset_error_ok=False):
3668 fullname = 'rietveld.' + name
3669 if setting in keyvals:
3670 RunGit(['config', fullname, keyvals[setting]])
3671 else:
3672 RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok)
3673
tandrii48df5812016-10-17 03:55:37 -07003674 if not keyvals.get('GERRIT_HOST', False):
3675 SetProperty('server', 'CODE_REVIEW_SERVER')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003676 # Only server setting is required. Other settings can be absent.
3677 # In that case, we ignore errors raised during option deletion attempt.
3678 SetProperty('cc', 'CC_LIST', unset_error_ok=True)
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +00003679 SetProperty('private', 'PRIVATE', unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003680 SetProperty('tree-status-url', 'STATUS', unset_error_ok=True)
3681 SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True)
rmistry@google.com90752582014-01-14 21:04:50 +00003682 SetProperty('bug-prefix', 'BUG_PREFIX', unset_error_ok=True)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003683 SetProperty('cpplint-regex', 'LINT_REGEX', unset_error_ok=True)
3684 SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True)
sheyang@chromium.org152cf832014-06-11 21:37:49 +00003685 SetProperty('project', 'PROJECT', unset_error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +00003686 SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK',
3687 unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003688
ukai@chromium.org7044efc2013-11-28 01:51:21 +00003689 if 'GERRIT_HOST' in keyvals:
ukai@chromium.orge8077812012-02-03 03:41:46 +00003690 RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']])
ukai@chromium.orge8077812012-02-03 03:41:46 +00003691
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003692 if 'GERRIT_SQUASH_UPLOADS' in keyvals:
tandrii8dd81ea2016-06-16 13:24:23 -07003693 RunGit(['config', 'gerrit.squash-uploads',
3694 keyvals['GERRIT_SQUASH_UPLOADS']])
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003695
tandrii@chromium.org28253532016-04-14 13:46:56 +00003696 if 'GERRIT_SKIP_ENSURE_AUTHENTICATED' in keyvals:
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00003697 RunGit(['config', 'gerrit.skip-ensure-authenticated',
tandrii@chromium.org28253532016-04-14 13:46:56 +00003698 keyvals['GERRIT_SKIP_ENSURE_AUTHENTICATED']])
3699
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003700 if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01003701 # should be of the form
3702 # PUSH_URL_CONFIG: url.ssh://gitrw.chromium.org.pushinsteadof
3703 # ORIGIN_URL_CONFIG: http://src.chromium.org/git
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003704 RunGit(['config', keyvals['PUSH_URL_CONFIG'],
3705 keyvals['ORIGIN_URL_CONFIG']])
3706
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003707
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003708def urlretrieve(source, destination):
3709 """urllib is broken for SSL connections via a proxy therefore we
3710 can't use urllib.urlretrieve()."""
3711 with open(destination, 'w') as f:
3712 f.write(urllib2.urlopen(source).read())
3713
3714
ukai@chromium.org712d6102013-11-27 00:52:58 +00003715def hasSheBang(fname):
3716 """Checks fname is a #! script."""
3717 with open(fname) as f:
3718 return f.read(2).startswith('#!')
3719
3720
bpastene@chromium.org917f0ff2016-04-05 00:45:30 +00003721# TODO(bpastene) Remove once a cleaner fix to crbug.com/600473 presents itself.
3722def DownloadHooks(*args, **kwargs):
3723 pass
3724
3725
tandrii@chromium.org18630d62016-03-04 12:06:02 +00003726def DownloadGerritHook(force):
3727 """Download and install Gerrit commit-msg hook.
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003728
3729 Args:
3730 force: True to update hooks. False to install hooks if not present.
3731 """
3732 if not settings.GetIsGerrit():
3733 return
ukai@chromium.org712d6102013-11-27 00:52:58 +00003734 src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg'
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003735 dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
3736 if not os.access(dst, os.X_OK):
3737 if os.path.exists(dst):
3738 if not force:
3739 return
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003740 try:
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003741 urlretrieve(src, dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003742 if not hasSheBang(dst):
3743 DieWithError('Not a script: %s\n'
3744 'You need to download from\n%s\n'
3745 'into .git/hooks/commit-msg and '
3746 'chmod +x .git/hooks/commit-msg' % (dst, src))
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003747 os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
3748 except Exception:
3749 if os.path.exists(dst):
3750 os.remove(dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003751 DieWithError('\nFailed to download hooks.\n'
3752 'You need to download from\n%s\n'
3753 'into .git/hooks/commit-msg and '
3754 'chmod +x .git/hooks/commit-msg' % src)
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003755
3756
tandrii@chromium.orge7d3d162016-03-15 14:15:57 +00003757def GetRietveldCodereviewSettingsInteractively():
3758 """Prompt the user for settings."""
3759 server = settings.GetDefaultServerUrl(error_ok=True)
3760 prompt = 'Rietveld server (host[:port])'
3761 prompt += ' [%s]' % (server or DEFAULT_SERVER)
3762 newserver = ask_for_data(prompt + ':')
3763 if not server and not newserver:
3764 newserver = DEFAULT_SERVER
3765 if newserver:
3766 newserver = gclient_utils.UpgradeToHttps(newserver)
3767 if newserver != server:
3768 RunGit(['config', 'rietveld.server', newserver])
3769
3770 def SetProperty(initial, caption, name, is_url):
3771 prompt = caption
3772 if initial:
3773 prompt += ' ("x" to clear) [%s]' % initial
3774 new_val = ask_for_data(prompt + ':')
3775 if new_val == 'x':
3776 RunGit(['config', '--unset-all', 'rietveld.' + name], error_ok=True)
3777 elif new_val:
3778 if is_url:
3779 new_val = gclient_utils.UpgradeToHttps(new_val)
3780 if new_val != initial:
3781 RunGit(['config', 'rietveld.' + name, new_val])
3782
3783 SetProperty(settings.GetDefaultCCList(), 'CC list', 'cc', False)
3784 SetProperty(settings.GetDefaultPrivateFlag(),
3785 'Private flag (rietveld only)', 'private', False)
3786 SetProperty(settings.GetTreeStatusUrl(error_ok=True), 'Tree status URL',
3787 'tree-status-url', False)
3788 SetProperty(settings.GetViewVCUrl(), 'ViewVC URL', 'viewvc-url', True)
3789 SetProperty(settings.GetBugPrefix(), 'Bug Prefix', 'bug-prefix', False)
3790 SetProperty(settings.GetRunPostUploadHook(), 'Run Post Upload Hook',
3791 'run-post-upload-hook', False)
3792
Andrii Shyshkalov18975322017-01-25 16:44:13 +01003793
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003794class _GitCookiesChecker(object):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003795 """Provides facilities for validating and suggesting fixes to .gitcookies."""
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003796
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003797 _GOOGLESOURCE = 'googlesource.com'
3798
3799 def __init__(self):
3800 # Cached list of [host, identity, source], where source is either
3801 # .gitcookies or .netrc.
3802 self._all_hosts = None
3803
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003804 def ensure_configured_gitcookies(self):
3805 """Runs checks and suggests fixes to make git use .gitcookies from default
3806 path."""
3807 default = gerrit_util.CookiesAuthenticator.get_gitcookies_path()
3808 configured_path = RunGitSilent(
3809 ['config', '--global', 'http.cookiefile']).strip()
Andrii Shyshkalov1e250cd2017-05-10 15:39:31 +02003810 configured_path = os.path.expanduser(configured_path)
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003811 if configured_path:
3812 self._ensure_default_gitcookies_path(configured_path, default)
3813 else:
3814 self._configure_gitcookies_path(default)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003815
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003816 @staticmethod
3817 def _ensure_default_gitcookies_path(configured_path, default_path):
3818 assert configured_path
3819 if configured_path == default_path:
3820 print('git is already configured to use your .gitcookies from %s' %
3821 configured_path)
3822 return
3823
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003824 print('WARNING: You have configured custom path to .gitcookies: %s\n'
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003825 'Gerrit and other depot_tools expect .gitcookies at %s\n' %
3826 (configured_path, default_path))
3827
3828 if not os.path.exists(configured_path):
3829 print('However, your configured .gitcookies file is missing.')
3830 confirm_or_exit('Reconfigure git to use default .gitcookies?',
3831 action='reconfigure')
3832 RunGit(['config', '--global', 'http.cookiefile', default_path])
3833 return
3834
3835 if os.path.exists(default_path):
3836 print('WARNING: default .gitcookies file already exists %s' %
3837 default_path)
3838 DieWithError('Please delete %s manually and re-run git cl creds-check' %
3839 default_path)
3840
3841 confirm_or_exit('Move existing .gitcookies to default location?',
3842 action='move')
3843 shutil.move(configured_path, default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003844 RunGit(['config', '--global', 'http.cookiefile', default_path])
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003845 print('Moved and reconfigured git to use .gitcookies from %s' %
3846 default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003847
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003848 @staticmethod
3849 def _configure_gitcookies_path(default_path):
3850 netrc_path = gerrit_util.CookiesAuthenticator.get_netrc_path()
3851 if os.path.exists(netrc_path):
3852 print('You seem to be using outdated .netrc for git credentials: %s' %
3853 netrc_path)
3854 print('This tool will guide you through setting up recommended '
3855 '.gitcookies store for git credentials.\n'
3856 '\n'
3857 'IMPORTANT: If something goes wrong and you decide to go back, do:\n'
3858 ' git config --global --unset http.cookiefile\n'
3859 ' mv %s %s.backup\n\n' % (default_path, default_path))
3860 confirm_or_exit(action='setup .gitcookies')
3861 RunGit(['config', '--global', 'http.cookiefile', default_path])
3862 print('Configured git to use .gitcookies from %s' % default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003863
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003864 def get_hosts_with_creds(self, include_netrc=False):
3865 if self._all_hosts is None:
3866 a = gerrit_util.CookiesAuthenticator()
3867 self._all_hosts = [
3868 (h, u, s)
3869 for h, u, s in itertools.chain(
3870 ((h, u, '.netrc') for h, (u, _, _) in a.netrc.hosts.iteritems()),
3871 ((h, u, '.gitcookies') for h, (u, _) in a.gitcookies.iteritems())
3872 )
3873 if h.endswith(self._GOOGLESOURCE)
3874 ]
3875
3876 if include_netrc:
3877 return self._all_hosts
3878 return [(h, u, s) for h, u, s in self._all_hosts if s != '.netrc']
3879
3880 def print_current_creds(self, include_netrc=False):
3881 hosts = sorted(self.get_hosts_with_creds(include_netrc=include_netrc))
3882 if not hosts:
3883 print('No Git/Gerrit credentials found')
3884 return
3885 lengths = [max(map(len, (row[i] for row in hosts))) for i in xrange(3)]
3886 header = [('Host', 'User', 'Which file'),
3887 ['=' * l for l in lengths]]
3888 for row in (header + hosts):
3889 print('\t'.join((('%%+%ds' % l) % s)
3890 for l, s in zip(lengths, row)))
3891
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003892 @staticmethod
3893 def _parse_identity(identity):
Lei Zhangd3f769a2017-12-15 15:16:14 -08003894 """Parses identity "git-<username>.domain" into <username> and domain."""
3895 # Special case: usernames that contain ".", which are generally not
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02003896 # distinguishable from sub-domains. But we do know typical domains:
3897 if identity.endswith('.chromium.org'):
3898 domain = 'chromium.org'
3899 username = identity[:-len('.chromium.org')]
3900 else:
3901 username, domain = identity.split('.', 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003902 if username.startswith('git-'):
3903 username = username[len('git-'):]
3904 return username, domain
3905
3906 def _get_usernames_of_domain(self, domain):
3907 """Returns list of usernames referenced by .gitcookies in a given domain."""
3908 identities_by_domain = {}
3909 for _, identity, _ in self.get_hosts_with_creds():
3910 username, domain = self._parse_identity(identity)
3911 identities_by_domain.setdefault(domain, []).append(username)
3912 return identities_by_domain.get(domain)
3913
3914 def _canonical_git_googlesource_host(self, host):
3915 """Normalizes Gerrit hosts (with '-review') to Git host."""
3916 assert host.endswith(self._GOOGLESOURCE)
3917 # Prefix doesn't include '.' at the end.
3918 prefix = host[:-(1 + len(self._GOOGLESOURCE))]
3919 if prefix.endswith('-review'):
3920 prefix = prefix[:-len('-review')]
3921 return prefix + '.' + self._GOOGLESOURCE
3922
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003923 def _canonical_gerrit_googlesource_host(self, host):
3924 git_host = self._canonical_git_googlesource_host(host)
3925 prefix = git_host.split('.', 1)[0]
3926 return prefix + '-review.' + self._GOOGLESOURCE
3927
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003928 def _get_counterpart_host(self, host):
3929 assert host.endswith(self._GOOGLESOURCE)
3930 git = self._canonical_git_googlesource_host(host)
3931 gerrit = self._canonical_gerrit_googlesource_host(git)
3932 return git if gerrit == host else gerrit
3933
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003934 def has_generic_host(self):
3935 """Returns whether generic .googlesource.com has been configured.
3936
3937 Chrome Infra recommends to use explicit ${host}.googlesource.com instead.
3938 """
3939 for host, _, _ in self.get_hosts_with_creds(include_netrc=False):
3940 if host == '.' + self._GOOGLESOURCE:
3941 return True
3942 return False
3943
3944 def _get_git_gerrit_identity_pairs(self):
3945 """Returns map from canonic host to pair of identities (Git, Gerrit).
3946
3947 One of identities might be None, meaning not configured.
3948 """
3949 host_to_identity_pairs = {}
3950 for host, identity, _ in self.get_hosts_with_creds():
3951 canonical = self._canonical_git_googlesource_host(host)
3952 pair = host_to_identity_pairs.setdefault(canonical, [None, None])
3953 idx = 0 if canonical == host else 1
3954 pair[idx] = identity
3955 return host_to_identity_pairs
3956
3957 def get_partially_configured_hosts(self):
3958 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003959 (host if i1 else self._canonical_gerrit_googlesource_host(host))
3960 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().iteritems()
3961 if None in (i1, i2) and host != '.' + self._GOOGLESOURCE)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003962
3963 def get_conflicting_hosts(self):
3964 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003965 host
3966 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().iteritems()
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003967 if None not in (i1, i2) and i1 != i2)
3968
3969 def get_duplicated_hosts(self):
3970 counters = collections.Counter(h for h, _, _ in self.get_hosts_with_creds())
3971 return set(host for host, count in counters.iteritems() if count > 1)
3972
3973 _EXPECTED_HOST_IDENTITY_DOMAINS = {
3974 'chromium.googlesource.com': 'chromium.org',
3975 'chrome-internal.googlesource.com': 'google.com',
3976 }
3977
3978 def get_hosts_with_wrong_identities(self):
3979 """Finds hosts which **likely** reference wrong identities.
3980
3981 Note: skips hosts which have conflicting identities for Git and Gerrit.
3982 """
3983 hosts = set()
3984 for host, expected in self._EXPECTED_HOST_IDENTITY_DOMAINS.iteritems():
3985 pair = self._get_git_gerrit_identity_pairs().get(host)
3986 if pair and pair[0] == pair[1]:
3987 _, domain = self._parse_identity(pair[0])
3988 if domain != expected:
3989 hosts.add(host)
3990 return hosts
3991
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003992 @staticmethod
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003993 def _format_hosts(hosts, extra_column_func=None):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003994 hosts = sorted(hosts)
3995 assert hosts
3996 if extra_column_func is None:
3997 extras = [''] * len(hosts)
3998 else:
3999 extras = [extra_column_func(host) for host in hosts]
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02004000 tmpl = '%%-%ds %%-%ds' % (max(map(len, hosts)), max(map(len, extras)))
4001 lines = []
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004002 for he in zip(hosts, extras):
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02004003 lines.append(tmpl % he)
4004 return lines
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004005
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02004006 def _find_problems(self):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004007 if self.has_generic_host():
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02004008 yield ('.googlesource.com wildcard record detected',
4009 ['Chrome Infrastructure team recommends to list full host names '
4010 'explicitly.'],
4011 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004012
4013 dups = self.get_duplicated_hosts()
4014 if dups:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02004015 yield ('The following hosts were defined twice',
4016 self._format_hosts(dups),
4017 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004018
4019 partial = self.get_partially_configured_hosts()
4020 if partial:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02004021 yield ('Credentials should come in pairs for Git and Gerrit hosts. '
4022 'These hosts are missing',
4023 self._format_hosts(partial, lambda host: 'but %s defined' %
4024 self._get_counterpart_host(host)),
4025 partial)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004026
4027 conflicting = self.get_conflicting_hosts()
4028 if conflicting:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02004029 yield ('The following Git hosts have differing credentials from their '
4030 'Gerrit counterparts',
4031 self._format_hosts(conflicting, lambda host: '%s vs %s' %
4032 tuple(self._get_git_gerrit_identity_pairs()[host])),
4033 conflicting)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004034
4035 wrong = self.get_hosts_with_wrong_identities()
4036 if wrong:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02004037 yield ('These hosts likely use wrong identity',
4038 self._format_hosts(wrong, lambda host: '%s but %s recommended' %
4039 (self._get_git_gerrit_identity_pairs()[host][0],
4040 self._EXPECTED_HOST_IDENTITY_DOMAINS[host])),
4041 wrong)
4042
4043 def find_and_report_problems(self):
4044 """Returns True if there was at least one problem, else False."""
4045 found = False
4046 bad_hosts = set()
4047 for title, sublines, hosts in self._find_problems():
4048 if not found:
4049 found = True
4050 print('\n\n.gitcookies problem report:\n')
4051 bad_hosts.update(hosts or [])
4052 print(' %s%s' % (title , (':' if sublines else '')))
4053 if sublines:
4054 print()
4055 print(' %s' % '\n '.join(sublines))
4056 print()
4057
4058 if bad_hosts:
4059 assert found
4060 print(' You can manually remove corresponding lines in your %s file and '
4061 'visit the following URLs with correct account to generate '
4062 'correct credential lines:\n' %
4063 gerrit_util.CookiesAuthenticator.get_gitcookies_path())
4064 print(' %s' % '\n '.join(sorted(set(
4065 gerrit_util.CookiesAuthenticator().get_new_password_url(
4066 self._canonical_git_googlesource_host(host))
4067 for host in bad_hosts
4068 ))))
4069 return found
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004070
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01004071
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004072@metrics.collector.collect_metrics('git cl creds-check')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01004073def CMDcreds_check(parser, args):
4074 """Checks credentials and suggests changes."""
4075 _, _ = parser.parse_args(args)
4076
4077 if gerrit_util.GceAuthenticator.is_gce():
Aaron Gabled10ca0e2017-09-11 11:24:10 -07004078 DieWithError(
4079 'This command is not designed for GCE, are you on a bot?\n'
4080 'If you need to run this, export SKIP_GCE_AUTH_FOR_GIT=1 in your env.')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01004081
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01004082 checker = _GitCookiesChecker()
4083 checker.ensure_configured_gitcookies()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01004084
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004085 print('Your .netrc and .gitcookies have credentials for these hosts:')
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01004086 checker.print_current_creds(include_netrc=True)
4087
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004088 if not checker.find_and_report_problems():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004089 print('\nNo problems detected in your .gitcookies file.')
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004090 return 0
4091 return 1
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01004092
4093
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004094@subcommand.usage('[repo root containing codereview.settings]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004095@metrics.collector.collect_metrics('git cl config')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004096def CMDconfig(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004097 """Edits configuration for this tree."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004098
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004099 print('WARNING: git cl config works for Rietveld only.')
tandrii5d0a0422016-09-14 06:24:35 -07004100 # TODO(tandrii): remove this once we switch to Gerrit.
4101 # See bugs http://crbug.com/637561 and http://crbug.com/600469.
pgervais@chromium.org87884cc2014-01-03 22:23:41 +00004102 parser.add_option('--activate-update', action='store_true',
4103 help='activate auto-updating [rietveld] section in '
4104 '.git/config')
4105 parser.add_option('--deactivate-update', action='store_true',
4106 help='deactivate auto-updating [rietveld] section in '
4107 '.git/config')
4108 options, args = parser.parse_args(args)
4109
4110 if options.deactivate_update:
4111 RunGit(['config', 'rietveld.autoupdate', 'false'])
4112 return
4113
4114 if options.activate_update:
4115 RunGit(['config', '--unset', 'rietveld.autoupdate'])
4116 return
4117
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004118 if len(args) == 0:
tandrii@chromium.orge7d3d162016-03-15 14:15:57 +00004119 GetRietveldCodereviewSettingsInteractively()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004120 return 0
4121
4122 url = args[0]
4123 if not url.endswith('codereview.settings'):
4124 url = os.path.join(url, 'codereview.settings')
4125
4126 # Load code review settings and download hooks (if available).
4127 LoadCodereviewSettingsFromFile(urllib2.urlopen(url))
4128 return 0
4129
4130
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004131@metrics.collector.collect_metrics('git cl baseurl')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00004132def CMDbaseurl(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004133 """Gets or sets base-url for this branch."""
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00004134 branchref = RunGit(['symbolic-ref', 'HEAD']).strip()
4135 branch = ShortBranchName(branchref)
4136 _, args = parser.parse_args(args)
4137 if not args:
vapiera7fbd5a2016-06-16 09:17:49 -07004138 print('Current base-url:')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00004139 return RunGit(['config', 'branch.%s.base-url' % branch],
4140 error_ok=False).strip()
4141 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004142 print('Setting base-url to %s' % args[0])
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00004143 return RunGit(['config', 'branch.%s.base-url' % branch, args[0]],
4144 error_ok=False).strip()
4145
4146
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00004147def color_for_status(status):
4148 """Maps a Changelist status to color, for CMDstatus and other tools."""
4149 return {
Aaron Gable9ab38c62017-04-06 14:36:33 -07004150 'unsent': Fore.YELLOW,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00004151 'waiting': Fore.BLUE,
4152 'reply': Fore.YELLOW,
Aaron Gable9ab38c62017-04-06 14:36:33 -07004153 'not lgtm': Fore.RED,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00004154 'lgtm': Fore.GREEN,
4155 'commit': Fore.MAGENTA,
4156 'closed': Fore.CYAN,
4157 'error': Fore.WHITE,
4158 }.get(status, Fore.WHITE)
4159
tandrii@chromium.org04ea8462016-04-25 19:51:21 +00004160
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004161def get_cl_statuses(changes, fine_grained, max_processes=None):
4162 """Returns a blocking iterable of (cl, status) for given branches.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004163
4164 If fine_grained is true, this will fetch CL statuses from the server.
4165 Otherwise, simply indicate if there's a matching url for the given branches.
4166
4167 If max_processes is specified, it is used as the maximum number of processes
4168 to spawn to fetch CL status from the server. Otherwise 1 process per branch is
4169 spawned.
calamity@chromium.orgcf197482016-04-29 20:15:53 +00004170
4171 See GetStatus() for a list of possible statuses.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004172 """
qyearsley12fa6ff2016-08-24 09:18:40 -07004173 # Silence upload.py otherwise it becomes unwieldy.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004174 upload.verbosity = 0
4175
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01004176 if not changes:
4177 raise StopIteration()
calamity@chromium.orgcf197482016-04-29 20:15:53 +00004178
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01004179 if not fine_grained:
4180 # Fast path which doesn't involve querying codereview servers.
Aaron Gablea1bab272017-04-11 16:38:18 -07004181 # Do not use get_approving_reviewers(), since it requires an HTTP request.
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004182 for cl in changes:
4183 yield (cl, 'waiting' if cl.GetIssueURL() else 'error')
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01004184 return
4185
4186 # First, sort out authentication issues.
4187 logging.debug('ensuring credentials exist')
4188 for cl in changes:
4189 cl.EnsureAuthenticated(force=False, refresh=True)
4190
4191 def fetch(cl):
4192 try:
4193 return (cl, cl.GetStatus())
4194 except:
4195 # See http://crbug.com/629863.
Andrii Shyshkalov98824232018-04-19 11:37:15 -07004196 logging.exception('failed to fetch status for cl %s:', cl.GetIssue())
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01004197 raise
4198
4199 threads_count = len(changes)
4200 if max_processes:
4201 threads_count = max(1, min(threads_count, max_processes))
4202 logging.debug('querying %d CLs using %d threads', len(changes), threads_count)
4203
4204 pool = ThreadPool(threads_count)
4205 fetched_cls = set()
4206 try:
4207 it = pool.imap_unordered(fetch, changes).__iter__()
4208 while True:
4209 try:
4210 cl, status = it.next(timeout=5)
4211 except multiprocessing.TimeoutError:
4212 break
4213 fetched_cls.add(cl)
4214 yield cl, status
4215 finally:
4216 pool.close()
4217
4218 # Add any branches that failed to fetch.
4219 for cl in set(changes) - fetched_cls:
4220 yield (cl, 'error')
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00004221
rmistry@google.com2dd99862015-06-22 12:22:18 +00004222
4223def upload_branch_deps(cl, args):
4224 """Uploads CLs of local branches that are dependents of the current branch.
4225
4226 If the local branch dependency tree looks like:
4227 test1 -> test2.1 -> test3.1
4228 -> test3.2
4229 -> test2.2 -> test3.3
4230
4231 and you run "git cl upload --dependencies" from test1 then "git cl upload" is
4232 run on the dependent branches in this order:
4233 test2.1, test3.1, test3.2, test2.2, test3.3
4234
4235 Note: This function does not rebase your local dependent branches. Use it when
4236 you make a change to the parent branch that will not conflict with its
4237 dependent branches, and you would like their dependencies updated in
4238 Rietveld.
4239 """
4240 if git_common.is_dirty_git_tree('upload-branch-deps'):
4241 return 1
4242
4243 root_branch = cl.GetBranch()
4244 if root_branch is None:
4245 DieWithError('Can\'t find dependent branches from detached HEAD state. '
4246 'Get on a branch!')
Andrii Shyshkalov1090fd52017-01-26 09:37:54 +01004247 if not cl.GetIssue() or (not cl.IsGerrit() and not cl.GetPatchset()):
rmistry@google.com2dd99862015-06-22 12:22:18 +00004248 DieWithError('Current branch does not have an uploaded CL. We cannot set '
4249 'patchset dependencies without an uploaded CL.')
4250
4251 branches = RunGit(['for-each-ref',
4252 '--format=%(refname:short) %(upstream:short)',
4253 'refs/heads'])
4254 if not branches:
4255 print('No local branches found.')
4256 return 0
4257
4258 # Create a dictionary of all local branches to the branches that are dependent
4259 # on it.
4260 tracked_to_dependents = collections.defaultdict(list)
4261 for b in branches.splitlines():
4262 tokens = b.split()
4263 if len(tokens) == 2:
4264 branch_name, tracked = tokens
4265 tracked_to_dependents[tracked].append(branch_name)
4266
vapiera7fbd5a2016-06-16 09:17:49 -07004267 print()
4268 print('The dependent local branches of %s are:' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00004269 dependents = []
4270 def traverse_dependents_preorder(branch, padding=''):
4271 dependents_to_process = tracked_to_dependents.get(branch, [])
4272 padding += ' '
4273 for dependent in dependents_to_process:
vapiera7fbd5a2016-06-16 09:17:49 -07004274 print('%s%s' % (padding, dependent))
rmistry@google.com2dd99862015-06-22 12:22:18 +00004275 dependents.append(dependent)
4276 traverse_dependents_preorder(dependent, padding)
4277 traverse_dependents_preorder(root_branch)
vapiera7fbd5a2016-06-16 09:17:49 -07004278 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00004279
4280 if not dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07004281 print('There are no dependent local branches for %s' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00004282 return 0
4283
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01004284 confirm_or_exit('This command will checkout all dependent branches and run '
4285 '"git cl upload".', action='continue')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004286
andybons@chromium.org962f9462016-02-03 20:00:42 +00004287 # Add a default patchset title to all upload calls in Rietveld.
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00004288 if not cl.IsGerrit():
andybons@chromium.org962f9462016-02-03 20:00:42 +00004289 args.extend(['-t', 'Updated patchset dependency'])
4290
rmistry@google.com2dd99862015-06-22 12:22:18 +00004291 # Record all dependents that failed to upload.
4292 failures = {}
4293 # Go through all dependents, checkout the branch and upload.
4294 try:
4295 for dependent_branch in dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07004296 print()
4297 print('--------------------------------------')
4298 print('Running "git cl upload" from %s:' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00004299 RunGit(['checkout', '-q', dependent_branch])
vapiera7fbd5a2016-06-16 09:17:49 -07004300 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00004301 try:
4302 if CMDupload(OptionParser(), args) != 0:
vapiera7fbd5a2016-06-16 09:17:49 -07004303 print('Upload failed for %s!' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00004304 failures[dependent_branch] = 1
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08004305 except: # pylint: disable=bare-except
rmistry@google.com2dd99862015-06-22 12:22:18 +00004306 failures[dependent_branch] = 1
vapiera7fbd5a2016-06-16 09:17:49 -07004307 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00004308 finally:
4309 # Swap back to the original root branch.
4310 RunGit(['checkout', '-q', root_branch])
4311
vapiera7fbd5a2016-06-16 09:17:49 -07004312 print()
4313 print('Upload complete for dependent branches!')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004314 for dependent_branch in dependents:
4315 upload_status = 'failed' if failures.get(dependent_branch) else 'succeeded'
vapiera7fbd5a2016-06-16 09:17:49 -07004316 print(' %s : %s' % (dependent_branch, upload_status))
4317 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00004318
4319 return 0
4320
4321
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004322@metrics.collector.collect_metrics('git cl archive')
kmarshall3bff56b2016-06-06 18:31:47 -07004323def CMDarchive(parser, args):
4324 """Archives and deletes branches associated with closed changelists."""
4325 parser.add_option(
4326 '-j', '--maxjobs', action='store', type=int,
kmarshall9249e012016-08-23 12:02:16 -07004327 help='The maximum number of jobs to use when retrieving review status.')
kmarshall3bff56b2016-06-06 18:31:47 -07004328 parser.add_option(
4329 '-f', '--force', action='store_true',
4330 help='Bypasses the confirmation prompt.')
kmarshall9249e012016-08-23 12:02:16 -07004331 parser.add_option(
4332 '-d', '--dry-run', action='store_true',
4333 help='Skip the branch tagging and removal steps.')
4334 parser.add_option(
4335 '-t', '--notags', action='store_true',
4336 help='Do not tag archived branches. '
4337 'Note: local commit history may be lost.')
kmarshall3bff56b2016-06-06 18:31:47 -07004338
4339 auth.add_auth_options(parser)
4340 options, args = parser.parse_args(args)
4341 if args:
4342 parser.error('Unsupported args: %s' % ' '.join(args))
4343 auth_config = auth.extract_auth_config_from_options(options)
4344
4345 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
4346 if not branches:
4347 return 0
4348
vapiera7fbd5a2016-06-16 09:17:49 -07004349 print('Finding all branches associated with closed issues...')
kmarshall3bff56b2016-06-06 18:31:47 -07004350 changes = [Changelist(branchref=b, auth_config=auth_config)
4351 for b in branches.splitlines()]
4352 alignment = max(5, max(len(c.GetBranch()) for c in changes))
4353 statuses = get_cl_statuses(changes,
4354 fine_grained=True,
4355 max_processes=options.maxjobs)
4356 proposal = [(cl.GetBranch(),
4357 'git-cl-archived-%s-%s' % (cl.GetIssue(), cl.GetBranch()))
4358 for cl, status in statuses
4359 if status == 'closed']
4360 proposal.sort()
4361
4362 if not proposal:
vapiera7fbd5a2016-06-16 09:17:49 -07004363 print('No branches with closed codereview issues found.')
kmarshall3bff56b2016-06-06 18:31:47 -07004364 return 0
4365
4366 current_branch = GetCurrentBranch()
4367
vapiera7fbd5a2016-06-16 09:17:49 -07004368 print('\nBranches with closed issues that will be archived:\n')
kmarshall9249e012016-08-23 12:02:16 -07004369 if options.notags:
4370 for next_item in proposal:
4371 print(' ' + next_item[0])
4372 else:
4373 print('%*s | %s' % (alignment, 'Branch name', 'Archival tag name'))
4374 for next_item in proposal:
4375 print('%*s %s' % (alignment, next_item[0], next_item[1]))
kmarshall3bff56b2016-06-06 18:31:47 -07004376
kmarshall9249e012016-08-23 12:02:16 -07004377 # Quit now on precondition failure or if instructed by the user, either
4378 # via an interactive prompt or by command line flags.
4379 if options.dry_run:
4380 print('\nNo changes were made (dry run).\n')
4381 return 0
4382 elif any(branch == current_branch for branch, _ in proposal):
kmarshall3bff56b2016-06-06 18:31:47 -07004383 print('You are currently on a branch \'%s\' which is associated with a '
4384 'closed codereview issue, so archive cannot proceed. Please '
4385 'checkout another branch and run this command again.' %
4386 current_branch)
4387 return 1
kmarshall9249e012016-08-23 12:02:16 -07004388 elif not options.force:
sergiyb4a5ecbe2016-06-20 09:46:00 -07004389 answer = ask_for_data('\nProceed with deletion (Y/n)? ').lower()
4390 if answer not in ('y', ''):
vapiera7fbd5a2016-06-16 09:17:49 -07004391 print('Aborted.')
kmarshall3bff56b2016-06-06 18:31:47 -07004392 return 1
4393
4394 for branch, tagname in proposal:
kmarshall9249e012016-08-23 12:02:16 -07004395 if not options.notags:
4396 RunGit(['tag', tagname, branch])
kmarshall3bff56b2016-06-06 18:31:47 -07004397 RunGit(['branch', '-D', branch])
kmarshall9249e012016-08-23 12:02:16 -07004398
vapiera7fbd5a2016-06-16 09:17:49 -07004399 print('\nJob\'s done!')
kmarshall3bff56b2016-06-06 18:31:47 -07004400
4401 return 0
4402
4403
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004404@metrics.collector.collect_metrics('git cl status')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004405def CMDstatus(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004406 """Show status of changelists.
4407
4408 Colors are used to tell the state of the CL unless --fast is used:
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00004409 - Blue waiting for review
Aaron Gable9ab38c62017-04-06 14:36:33 -07004410 - Yellow waiting for you to reply to review, or not yet sent
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00004411 - Green LGTM'ed
Aaron Gable9ab38c62017-04-06 14:36:33 -07004412 - Red 'not LGTM'ed
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00004413 - Magenta in the commit queue
4414 - Cyan was committed, branch can be deleted
Aaron Gable9ab38c62017-04-06 14:36:33 -07004415 - White error, or unknown status
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004416
4417 Also see 'git cl comments'.
4418 """
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004419 parser.add_option('--field',
phajdan.jr289d03e2016-08-16 08:21:06 -07004420 help='print only specific field (desc|id|patch|status|url)')
maruel@chromium.org1033efd2013-07-23 23:25:09 +00004421 parser.add_option('-f', '--fast', action='store_true',
4422 help='Do not retrieve review status')
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004423 parser.add_option(
4424 '-j', '--maxjobs', action='store', type=int,
4425 help='The maximum number of jobs to use when retrieving review status')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004426
4427 auth.add_auth_options(parser)
iannuccie53c9352016-08-17 14:40:40 -07004428 _add_codereview_issue_select_options(
4429 parser, 'Must be in conjunction with --field.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004430 options, args = parser.parse_args(args)
iannuccie53c9352016-08-17 14:40:40 -07004431 _process_codereview_issue_select_options(parser, options)
maruel@chromium.org39c0b222013-08-17 16:57:01 +00004432 if args:
4433 parser.error('Unsupported args: %s' % args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004434 auth_config = auth.extract_auth_config_from_options(options)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004435
iannuccie53c9352016-08-17 14:40:40 -07004436 if options.issue is not None and not options.field:
4437 parser.error('--field must be specified with --issue')
iannucci3c972b92016-08-17 13:24:10 -07004438
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004439 if options.field:
iannucci3c972b92016-08-17 13:24:10 -07004440 cl = Changelist(auth_config=auth_config, issue=options.issue,
4441 codereview=options.forced_codereview)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004442 if options.field.startswith('desc'):
vapiera7fbd5a2016-06-16 09:17:49 -07004443 print(cl.GetDescription())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004444 elif options.field == 'id':
4445 issueid = cl.GetIssue()
4446 if issueid:
vapiera7fbd5a2016-06-16 09:17:49 -07004447 print(issueid)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004448 elif options.field == 'patch':
Aaron Gablee8856ee2017-12-07 12:41:46 -08004449 patchset = cl.GetMostRecentPatchset()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004450 if patchset:
vapiera7fbd5a2016-06-16 09:17:49 -07004451 print(patchset)
phajdan.jr289d03e2016-08-16 08:21:06 -07004452 elif options.field == 'status':
4453 print(cl.GetStatus())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004454 elif options.field == 'url':
4455 url = cl.GetIssueURL()
4456 if url:
vapiera7fbd5a2016-06-16 09:17:49 -07004457 print(url)
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00004458 return 0
4459
4460 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
4461 if not branches:
4462 print('No local branch found.')
4463 return 0
4464
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004465 changes = [
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004466 Changelist(branchref=b, auth_config=auth_config)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004467 for b in branches.splitlines()]
vapiera7fbd5a2016-06-16 09:17:49 -07004468 print('Branches associated with reviews:')
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004469 output = get_cl_statuses(changes,
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004470 fine_grained=not options.fast,
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004471 max_processes=options.maxjobs)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00004472
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004473 branch_statuses = {}
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004474 alignment = max(5, max(len(ShortBranchName(c.GetBranch())) for c in changes))
4475 for cl in sorted(changes, key=lambda c: c.GetBranch()):
4476 branch = cl.GetBranch()
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004477 while branch not in branch_statuses:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004478 c, status = output.next()
4479 branch_statuses[c.GetBranch()] = status
4480 status = branch_statuses.pop(branch)
4481 url = cl.GetIssueURL()
4482 if url and (not status or status == 'error'):
4483 # The issue probably doesn't exist anymore.
4484 url += ' (broken)'
4485
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00004486 color = color_for_status(status)
maruel@chromium.org885f6512013-07-27 02:17:26 +00004487 reset = Fore.RESET
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00004488 if not setup_color.IS_TTY:
maruel@chromium.org885f6512013-07-27 02:17:26 +00004489 color = ''
4490 reset = ''
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00004491 status_str = '(%s)' % status if status else ''
vapiera7fbd5a2016-06-16 09:17:49 -07004492 print(' %*s : %s%s %s%s' % (
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004493 alignment, ShortBranchName(branch), color, url,
vapiera7fbd5a2016-06-16 09:17:49 -07004494 status_str, reset))
maruel@chromium.org1033efd2013-07-23 23:25:09 +00004495
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01004496
4497 branch = GetCurrentBranch()
vapiera7fbd5a2016-06-16 09:17:49 -07004498 print()
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01004499 print('Current branch: %s' % branch)
4500 for cl in changes:
4501 if cl.GetBranch() == branch:
4502 break
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00004503 if not cl.GetIssue():
vapiera7fbd5a2016-06-16 09:17:49 -07004504 print('No issue assigned.')
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00004505 return 0
vapiera7fbd5a2016-06-16 09:17:49 -07004506 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
maruel@chromium.org85616e02014-07-28 15:37:55 +00004507 if not options.fast:
vapiera7fbd5a2016-06-16 09:17:49 -07004508 print('Issue description:')
4509 print(cl.GetDescription(pretty=True))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004510 return 0
4511
4512
maruel@chromium.org39c0b222013-08-17 16:57:01 +00004513def colorize_CMDstatus_doc():
4514 """To be called once in main() to add colors to git cl status help."""
4515 colors = [i for i in dir(Fore) if i[0].isupper()]
4516
4517 def colorize_line(line):
4518 for color in colors:
4519 if color in line.upper():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004520 # Extract whitespace first and the leading '-'.
maruel@chromium.org39c0b222013-08-17 16:57:01 +00004521 indent = len(line) - len(line.lstrip(' ')) + 1
4522 return line[:indent] + getattr(Fore, color) + line[indent:] + Fore.RESET
4523 return line
4524
4525 lines = CMDstatus.__doc__.splitlines()
4526 CMDstatus.__doc__ = '\n'.join(colorize_line(l) for l in lines)
4527
4528
phajdan.jre328cf92016-08-22 04:12:17 -07004529def write_json(path, contents):
Stefan Zager1306bd02017-06-22 19:26:46 -07004530 if path == '-':
4531 json.dump(contents, sys.stdout)
4532 else:
4533 with open(path, 'w') as f:
4534 json.dump(contents, f)
phajdan.jre328cf92016-08-22 04:12:17 -07004535
4536
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004537@subcommand.usage('[issue_number]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004538@metrics.collector.collect_metrics('git cl issue')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004539def CMDissue(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004540 """Sets or displays the current code review issue number.
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004541
4542 Pass issue number 0 to clear the current issue.
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004543 """
dnj@chromium.org406c4402015-03-03 17:22:28 +00004544 parser.add_option('-r', '--reverse', action='store_true',
4545 help='Lookup the branch(es) for the specified issues. If '
4546 'no issues are specified, all branches with mapped '
4547 'issues will be listed.')
Stefan Zager1306bd02017-06-22 19:26:46 -07004548 parser.add_option('--json',
4549 help='Path to JSON output file, or "-" for stdout.')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004550 _add_codereview_select_options(parser)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004551 options, args = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004552 _process_codereview_select_options(parser, options)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004553
dnj@chromium.org406c4402015-03-03 17:22:28 +00004554 if options.reverse:
4555 branches = RunGit(['for-each-ref', 'refs/heads',
Aaron Gablead64abd2017-12-04 09:49:13 -08004556 '--format=%(refname)']).splitlines()
dnj@chromium.org406c4402015-03-03 17:22:28 +00004557 # Reverse issue lookup.
4558 issue_branch_map = {}
4559 for branch in branches:
4560 cl = Changelist(branchref=branch)
4561 issue_branch_map.setdefault(cl.GetIssue(), []).append(branch)
4562 if not args:
4563 args = sorted(issue_branch_map.iterkeys())
phajdan.jre328cf92016-08-22 04:12:17 -07004564 result = {}
dnj@chromium.org406c4402015-03-03 17:22:28 +00004565 for issue in args:
4566 if not issue:
4567 continue
phajdan.jre328cf92016-08-22 04:12:17 -07004568 result[int(issue)] = issue_branch_map.get(int(issue))
vapiera7fbd5a2016-06-16 09:17:49 -07004569 print('Branch for issue number %s: %s' % (
4570 issue, ', '.join(issue_branch_map.get(int(issue)) or ('None',))))
phajdan.jre328cf92016-08-22 04:12:17 -07004571 if options.json:
4572 write_json(options.json, result)
Aaron Gable78753da2017-06-15 10:35:49 -07004573 return 0
4574
4575 if len(args) > 0:
4576 issue = ParseIssueNumberArgument(args[0], options.forced_codereview)
4577 if not issue.valid:
4578 DieWithError('Pass a url or number to set the issue, 0 to unset it, '
4579 'or no argument to list it.\n'
4580 'Maybe you want to run git cl status?')
4581 cl = Changelist(codereview=issue.codereview)
4582 cl.SetIssue(issue.issue)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004583 else:
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004584 cl = Changelist(codereview=options.forced_codereview)
Aaron Gable78753da2017-06-15 10:35:49 -07004585 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
4586 if options.json:
4587 write_json(options.json, {
4588 'issue': cl.GetIssue(),
4589 'issue_url': cl.GetIssueURL(),
4590 })
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004591 return 0
4592
4593
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004594@metrics.collector.collect_metrics('git cl comments')
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004595def CMDcomments(parser, args):
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004596 """Shows or posts review comments for any changelist."""
4597 parser.add_option('-a', '--add-comment', dest='comment',
4598 help='comment to add to an issue')
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01004599 parser.add_option('-i', '--issue', dest='issue',
4600 help='review issue id (defaults to current issue). '
4601 'If given, requires --rietveld or --gerrit')
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07004602 parser.add_option('-m', '--machine-readable', dest='readable',
4603 action='store_false', default=True,
4604 help='output comments in a format compatible with '
4605 'editor parsing')
smut@google.comc85ac942015-09-15 16:34:43 +00004606 parser.add_option('-j', '--json-file',
Stefan Zager1306bd02017-06-22 19:26:46 -07004607 help='File to write JSON summary to, or "-" for stdout')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004608 auth.add_auth_options(parser)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004609 _add_codereview_select_options(parser)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004610 options, args = parser.parse_args(args)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004611 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004612 auth_config = auth.extract_auth_config_from_options(options)
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004613
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004614 issue = None
4615 if options.issue:
4616 try:
4617 issue = int(options.issue)
4618 except ValueError:
4619 DieWithError('A review issue id is expected to be a number')
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01004620 if not options.forced_codereview:
4621 parser.error('--gerrit or --rietveld is required if --issue is specified')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004622
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004623 cl = Changelist(issue=issue,
Andrii Shyshkalov70909e12017-04-10 14:38:32 +02004624 codereview=options.forced_codereview,
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004625 auth_config=auth_config)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004626
4627 if options.comment:
4628 cl.AddComment(options.comment)
4629 return 0
4630
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07004631 summary = sorted(cl.GetCommentsSummary(readable=options.readable),
4632 key=lambda c: c.date)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004633 for comment in summary:
4634 if comment.disapproval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004635 color = Fore.RED
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004636 elif comment.approval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004637 color = Fore.GREEN
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004638 elif comment.sender == cl.GetIssueOwner():
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004639 color = Fore.MAGENTA
4640 else:
4641 color = Fore.BLUE
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004642 print('\n%s%s %s%s\n%s' % (
4643 color,
4644 comment.date.strftime('%Y-%m-%d %H:%M:%S UTC'),
4645 comment.sender,
4646 Fore.RESET,
4647 '\n'.join(' ' + l for l in comment.message.strip().splitlines())))
4648
smut@google.comc85ac942015-09-15 16:34:43 +00004649 if options.json_file:
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004650 def pre_serialize(c):
4651 dct = c.__dict__.copy()
4652 dct['date'] = dct['date'].strftime('%Y-%m-%d %H:%M:%S.%f')
4653 return dct
smut@google.comc85ac942015-09-15 16:34:43 +00004654 with open(options.json_file, 'wb') as f:
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004655 json.dump(map(pre_serialize, summary), f)
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004656 return 0
4657
4658
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004659@subcommand.usage('[codereview url or issue id]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004660@metrics.collector.collect_metrics('git cl description')
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004661def CMDdescription(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004662 """Brings up the editor for the current CL's description."""
smut@google.com34fb6b12015-07-13 20:03:26 +00004663 parser.add_option('-d', '--display', action='store_true',
4664 help='Display the description instead of opening an editor')
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004665 parser.add_option('-n', '--new-description',
dnjba1b0f32016-09-02 12:37:42 -07004666 help='New description to set for this issue (- for stdin, '
4667 '+ to load from local commit HEAD)')
dsansomee2d6fd92016-09-08 00:10:47 -07004668 parser.add_option('-f', '--force', action='store_true',
4669 help='Delete any unpublished Gerrit edits for this issue '
4670 'without prompting')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004671
4672 _add_codereview_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004673 auth.add_auth_options(parser)
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004674 options, args = parser.parse_args(args)
4675 _process_codereview_select_options(parser, options)
4676
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004677 target_issue_arg = None
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004678 if len(args) > 0:
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004679 target_issue_arg = ParseIssueNumberArgument(args[0],
4680 options.forced_codereview)
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004681 if not target_issue_arg.valid:
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02004682 parser.error('invalid codereview url or CL id')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004683
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004684 auth_config = auth.extract_auth_config_from_options(options)
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004685
martiniss6eda05f2016-06-30 10:18:35 -07004686 kwargs = {
4687 'auth_config': auth_config,
4688 'codereview': options.forced_codereview,
4689 }
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004690 detected_codereview_from_url = False
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004691 if target_issue_arg:
4692 kwargs['issue'] = target_issue_arg.issue
4693 kwargs['codereview_host'] = target_issue_arg.hostname
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004694 if target_issue_arg.codereview and not options.forced_codereview:
4695 detected_codereview_from_url = True
4696 kwargs['codereview'] = target_issue_arg.codereview
martiniss6eda05f2016-06-30 10:18:35 -07004697
4698 cl = Changelist(**kwargs)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004699 if not cl.GetIssue():
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004700 assert not detected_codereview_from_url
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004701 DieWithError('This branch has no associated changelist.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004702
4703 if detected_codereview_from_url:
4704 logging.info('canonical issue/change URL: %s (type: %s)\n',
4705 cl.GetIssueURL(), target_issue_arg.codereview)
4706
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004707 description = ChangeDescription(cl.GetDescription())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004708
smut@google.com34fb6b12015-07-13 20:03:26 +00004709 if options.display:
vapiera7fbd5a2016-06-16 09:17:49 -07004710 print(description.description)
smut@google.com34fb6b12015-07-13 20:03:26 +00004711 return 0
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004712
4713 if options.new_description:
4714 text = options.new_description
4715 if text == '-':
4716 text = '\n'.join(l.rstrip() for l in sys.stdin)
dnjba1b0f32016-09-02 12:37:42 -07004717 elif text == '+':
4718 base_branch = cl.GetCommonAncestorWithUpstream()
4719 change = cl.GetChange(base_branch, None, local_description=True)
4720 text = change.FullDescriptionText()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004721
4722 description.set_description(text)
4723 else:
Aaron Gable3a16ed12017-03-23 10:51:55 -07004724 description.prompt(git_footer=cl.IsGerrit())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004725
Andrii Shyshkalov680253d2017-03-15 21:07:36 +01004726 if cl.GetDescription().strip() != description.description:
dsansomee2d6fd92016-09-08 00:10:47 -07004727 cl.UpdateDescription(description.description, force=options.force)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004728 return 0
4729
4730
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004731def CreateDescriptionFromLog(args):
4732 """Pulls out the commit log to use as a base for the CL description."""
4733 log_args = []
4734 if len(args) == 1 and not args[0].endswith('.'):
4735 log_args = [args[0] + '..']
4736 elif len(args) == 1 and args[0].endswith('...'):
4737 log_args = [args[0][:-1]]
4738 elif len(args) == 2:
4739 log_args = [args[0] + '..' + args[1]]
4740 else:
4741 log_args = args[:] # Hope for the best!
maruel@chromium.org373af802012-05-25 21:07:33 +00004742 return RunGit(['log', '--pretty=format:%s\n\n%b'] + log_args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004743
4744
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004745@metrics.collector.collect_metrics('git cl lint')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004746def CMDlint(parser, args):
4747 """Runs cpplint on the current changelist."""
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004748 parser.add_option('--filter', action='append', metavar='-x,+y',
4749 help='Comma-separated list of cpplint\'s category-filters')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004750 auth.add_auth_options(parser)
4751 options, args = parser.parse_args(args)
4752 auth_config = auth.extract_auth_config_from_options(options)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004753
4754 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08004755 # pylint: disable=protected-access
thestig@chromium.org44202a22014-03-11 19:22:18 +00004756 try:
4757 import cpplint
4758 import cpplint_chromium
4759 except ImportError:
vapiera7fbd5a2016-06-16 09:17:49 -07004760 print('Your depot_tools is missing cpplint.py and/or cpplint_chromium.py.')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004761 return 1
4762
4763 # Change the current working directory before calling lint so that it
4764 # shows the correct base.
4765 previous_cwd = os.getcwd()
4766 os.chdir(settings.GetRoot())
4767 try:
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004768 cl = Changelist(auth_config=auth_config)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004769 change = cl.GetChange(cl.GetCommonAncestorWithUpstream(), None)
4770 files = [f.LocalPath() for f in change.AffectedFiles()]
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004771 if not files:
vapiera7fbd5a2016-06-16 09:17:49 -07004772 print('Cannot lint an empty CL')
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004773 return 1
thestig@chromium.org44202a22014-03-11 19:22:18 +00004774
4775 # Process cpplints arguments if any.
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004776 command = args + files
4777 if options.filter:
4778 command = ['--filter=' + ','.join(options.filter)] + command
4779 filenames = cpplint.ParseArguments(command)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004780
4781 white_regex = re.compile(settings.GetLintRegex())
4782 black_regex = re.compile(settings.GetLintIgnoreRegex())
4783 extra_check_functions = [cpplint_chromium.CheckPointerDeclarationWhitespace]
4784 for filename in filenames:
4785 if white_regex.match(filename):
4786 if black_regex.match(filename):
vapiera7fbd5a2016-06-16 09:17:49 -07004787 print('Ignoring file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004788 else:
4789 cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level,
4790 extra_check_functions)
4791 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004792 print('Skipping file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004793 finally:
4794 os.chdir(previous_cwd)
vapiera7fbd5a2016-06-16 09:17:49 -07004795 print('Total errors found: %d\n' % cpplint._cpplint_state.error_count)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004796 if cpplint._cpplint_state.error_count != 0:
4797 return 1
4798 return 0
4799
4800
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004801@metrics.collector.collect_metrics('git cl presubmit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004802def CMDpresubmit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004803 """Runs presubmit tests on the current changelist."""
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004804 parser.add_option('-u', '--upload', action='store_true',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004805 help='Run upload hook instead of the push hook')
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004806 parser.add_option('-f', '--force', action='store_true',
sbc@chromium.org495ad152012-09-04 23:07:42 +00004807 help='Run checks even if tree is dirty')
Aaron Gable8076c282017-11-29 14:39:41 -08004808 parser.add_option('--all', action='store_true',
4809 help='Run checks against all files, not just modified ones')
Edward Lesmes8e282792018-04-03 18:50:29 -04004810 parser.add_option('--parallel', action='store_true',
4811 help='Run all tests specified by input_api.RunTests in all '
4812 'PRESUBMIT files in parallel.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004813 auth.add_auth_options(parser)
4814 options, args = parser.parse_args(args)
4815 auth_config = auth.extract_auth_config_from_options(options)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004816
sbc@chromium.org71437c02015-04-09 19:29:40 +00004817 if not options.force and git_common.is_dirty_git_tree('presubmit'):
vapiera7fbd5a2016-06-16 09:17:49 -07004818 print('use --force to check even if tree is dirty.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004819 return 1
4820
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004821 cl = Changelist(auth_config=auth_config)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004822 if args:
4823 base_branch = args[0]
4824 else:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00004825 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004826 base_branch = cl.GetCommonAncestorWithUpstream()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004827
Aaron Gable8076c282017-11-29 14:39:41 -08004828 if options.all:
4829 base_change = cl.GetChange(base_branch, None)
4830 files = [('M', f) for f in base_change.AllFiles()]
4831 change = presubmit_support.GitChange(
4832 base_change.Name(),
4833 base_change.FullDescriptionText(),
4834 base_change.RepositoryRoot(),
4835 files,
4836 base_change.issue,
4837 base_change.patchset,
4838 base_change.author_email,
4839 base_change._upstream)
4840 else:
4841 change = cl.GetChange(base_branch, None)
4842
ilevy@chromium.org051ad0e2013-03-04 21:57:34 +00004843 cl.RunHook(
4844 committing=not options.upload,
4845 may_prompt=False,
4846 verbose=options.verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04004847 change=change,
4848 parallel=options.parallel)
dpranke@chromium.org0a2bb372011-03-25 01:16:22 +00004849 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004850
4851
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004852def GenerateGerritChangeId(message):
4853 """Returns Ixxxxxx...xxx change id.
4854
4855 Works the same way as
4856 https://gerrit-review.googlesource.com/tools/hooks/commit-msg
4857 but can be called on demand on all platforms.
4858
4859 The basic idea is to generate git hash of a state of the tree, original commit
4860 message, author/committer info and timestamps.
4861 """
4862 lines = []
4863 tree_hash = RunGitSilent(['write-tree'])
4864 lines.append('tree %s' % tree_hash.strip())
4865 code, parent = RunGitWithCode(['rev-parse', 'HEAD~0'], suppress_stderr=False)
4866 if code == 0:
4867 lines.append('parent %s' % parent.strip())
4868 author = RunGitSilent(['var', 'GIT_AUTHOR_IDENT'])
4869 lines.append('author %s' % author.strip())
4870 committer = RunGitSilent(['var', 'GIT_COMMITTER_IDENT'])
4871 lines.append('committer %s' % committer.strip())
4872 lines.append('')
4873 # Note: Gerrit's commit-hook actually cleans message of some lines and
4874 # whitespace. This code is not doing this, but it clearly won't decrease
4875 # entropy.
4876 lines.append(message)
4877 change_hash = RunCommand(['git', 'hash-object', '-t', 'commit', '--stdin'],
4878 stdin='\n'.join(lines))
4879 return 'I%s' % change_hash.strip()
4880
4881
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01004882def GetTargetRef(remote, remote_branch, target_branch):
wittman@chromium.org455dc922015-01-26 20:15:50 +00004883 """Computes the remote branch ref to use for the CL.
4884
4885 Args:
4886 remote (str): The git remote for the CL.
4887 remote_branch (str): The git remote branch for the CL.
4888 target_branch (str): The target branch specified by the user.
wittman@chromium.org455dc922015-01-26 20:15:50 +00004889 """
4890 if not (remote and remote_branch):
4891 return None
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004892
wittman@chromium.org455dc922015-01-26 20:15:50 +00004893 if target_branch:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004894 # Canonicalize branch references to the equivalent local full symbolic
wittman@chromium.org455dc922015-01-26 20:15:50 +00004895 # refs, which are then translated into the remote full symbolic refs
4896 # below.
4897 if '/' not in target_branch:
4898 remote_branch = 'refs/remotes/%s/%s' % (remote, target_branch)
4899 else:
4900 prefix_replacements = (
4901 ('^((refs/)?remotes/)?branch-heads/', 'refs/remotes/branch-heads/'),
4902 ('^((refs/)?remotes/)?%s/' % remote, 'refs/remotes/%s/' % remote),
4903 ('^(refs/)?heads/', 'refs/remotes/%s/' % remote),
4904 )
4905 match = None
4906 for regex, replacement in prefix_replacements:
4907 match = re.search(regex, target_branch)
4908 if match:
4909 remote_branch = target_branch.replace(match.group(0), replacement)
4910 break
4911 if not match:
4912 # This is a branch path but not one we recognize; use as-is.
4913 remote_branch = target_branch
rmistry@google.comc68112d2015-03-03 12:48:06 +00004914 elif remote_branch in REFS_THAT_ALIAS_TO_OTHER_REFS:
4915 # Handle the refs that need to land in different refs.
4916 remote_branch = REFS_THAT_ALIAS_TO_OTHER_REFS[remote_branch]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004917
wittman@chromium.org455dc922015-01-26 20:15:50 +00004918 # Create the true path to the remote branch.
4919 # Does the following translation:
4920 # * refs/remotes/origin/refs/diff/test -> refs/diff/test
4921 # * refs/remotes/origin/master -> refs/heads/master
4922 # * refs/remotes/branch-heads/test -> refs/branch-heads/test
4923 if remote_branch.startswith('refs/remotes/%s/refs/' % remote):
4924 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, '')
4925 elif remote_branch.startswith('refs/remotes/%s/' % remote):
4926 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote,
4927 'refs/heads/')
4928 elif remote_branch.startswith('refs/remotes/branch-heads'):
4929 remote_branch = remote_branch.replace('refs/remotes/', 'refs/')
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01004930
wittman@chromium.org455dc922015-01-26 20:15:50 +00004931 return remote_branch
4932
4933
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004934def cleanup_list(l):
4935 """Fixes a list so that comma separated items are put as individual items.
4936
4937 So that "--reviewers joe@c,john@c --reviewers joa@c" results in
4938 options.reviewers == sorted(['joe@c', 'john@c', 'joa@c']).
4939 """
4940 items = sum((i.split(',') for i in l), [])
4941 stripped_items = (i.strip() for i in items)
4942 return sorted(filter(None, stripped_items))
4943
4944
Aaron Gable4db38df2017-11-03 14:59:07 -07004945@subcommand.usage('[flags]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004946@metrics.collector.collect_metrics('git cl upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004947def CMDupload(parser, args):
rmistry@google.com78948ed2015-07-08 23:09:57 +00004948 """Uploads the current changelist to codereview.
4949
4950 Can skip dependency patchset uploads for a branch by running:
4951 git config branch.branch_name.skip-deps-uploads True
4952 To unset run:
4953 git config --unset branch.branch_name.skip-deps-uploads
4954 Can also set the above globally by using the --global flag.
Dominic Battre7d1c4842017-10-27 09:17:28 +02004955
4956 If the name of the checked out branch starts with "bug-" or "fix-" followed by
4957 a bug number, this bug number is automatically populated in the CL
4958 description.
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004959
4960 If subject contains text in square brackets or has "<text>: " prefix, such
4961 text(s) is treated as Gerrit hashtags. For example, CLs with subjects
4962 [git-cl] add support for hashtags
4963 Foo bar: implement foo
4964 will be hashtagged with "git-cl" and "foo-bar" respectively.
rmistry@google.com78948ed2015-07-08 23:09:57 +00004965 """
ukai@chromium.orge8077812012-02-03 03:41:46 +00004966 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4967 help='bypass upload presubmit hook')
brettw@chromium.orgb65c43c2013-06-10 22:04:49 +00004968 parser.add_option('--bypass-watchlists', action='store_true',
4969 dest='bypass_watchlists',
4970 help='bypass watchlists auto CC-ing reviewers')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004971 parser.add_option('-f', '--force', action='store_true', dest='force',
ukai@chromium.orge8077812012-02-03 03:41:46 +00004972 help="force yes to questions (don't prompt)")
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004973 parser.add_option('--message', '-m', dest='message',
4974 help='message for patchset')
tandriif9aefb72016-07-01 09:06:51 -07004975 parser.add_option('-b', '--bug',
4976 help='pre-populate the bug number(s) for this issue. '
4977 'If several, separate with commas')
tandriib80458a2016-06-23 12:20:07 -07004978 parser.add_option('--message-file', dest='message_file',
4979 help='file which contains message for patchset')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004980 parser.add_option('--title', '-t', dest='title',
4981 help='title for patchset')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004982 parser.add_option('-r', '--reviewers',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004983 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004984 help='reviewer email addresses')
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004985 parser.add_option('--tbrs',
4986 action='append', default=[],
4987 help='TBR email addresses')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004988 parser.add_option('--cc',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004989 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004990 help='cc email addresses')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004991 parser.add_option('--hashtag', dest='hashtags',
4992 action='append', default=[],
4993 help=('Gerrit hashtag for new CL; '
4994 'can be applied multiple times'))
adamk@chromium.org36f47302013-04-05 01:08:31 +00004995 parser.add_option('-s', '--send-mail', action='store_true',
Aaron Gable59f48512017-01-12 10:54:46 -08004996 help='send email to reviewer(s) and cc(s) immediately')
pgervais@chromium.orgb9f27512014-08-08 15:52:33 +00004997 parser.add_option('--emulate_svn_auto_props',
4998 '--emulate-svn-auto-props',
4999 action="store_true",
ukai@chromium.orge8077812012-02-03 03:41:46 +00005000 dest="emulate_svn_auto_props",
5001 help="Emulate Subversion's auto properties feature.")
ukai@chromium.orge8077812012-02-03 03:41:46 +00005002 parser.add_option('-c', '--use-commit-queue', action='store_true',
Aaron Gableedbc4132017-09-11 13:22:28 -07005003 help='tell the commit queue to commit this patchset; '
5004 'implies --send-mail')
ukai@chromium.org8ef7ab22012-11-28 04:24:52 +00005005 parser.add_option('--target_branch',
pgervais@chromium.orgb9f27512014-08-08 15:52:33 +00005006 '--target-branch',
wittman@chromium.org455dc922015-01-26 20:15:50 +00005007 metavar='TARGET',
5008 help='Apply CL to remote ref TARGET. ' +
5009 'Default: remote branch head, or master')
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00005010 parser.add_option('--squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08005011 help='Squash multiple commits into one')
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00005012 parser.add_option('--no-squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08005013 help='Don\'t squash multiple commits into one')
rmistry9eadede2016-09-19 11:22:43 -07005014 parser.add_option('--topic', default=None,
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08005015 help='Topic to specify when uploading')
Robert Iannuccif2708bd2017-04-17 15:49:02 -07005016 parser.add_option('--tbr-owners', dest='add_owners_to', action='store_const',
5017 const='TBR', help='add a set of OWNERS to TBR')
5018 parser.add_option('--r-owners', dest='add_owners_to', action='store_const',
5019 const='R', help='add a set of OWNERS to R')
tandrii@chromium.orgd50452a2015-11-23 16:38:15 +00005020 parser.add_option('-d', '--cq-dry-run', dest='cq_dry_run',
5021 action='store_true',
rmistry@google.comef966222015-04-07 11:15:01 +00005022 help='Send the patchset to do a CQ dry run right after '
5023 'upload.')
rmistry@google.com2dd99862015-06-22 12:22:18 +00005024 parser.add_option('--dependencies', action='store_true',
5025 help='Uploads CLs of all the local branches that depend on '
5026 'the current branch')
Ravi Mistry31e7d562018-04-02 12:53:57 -04005027 parser.add_option('-a', '--enable-auto-submit', action='store_true',
5028 help='Sends your change to the CQ after an approval. Only '
5029 'works on repos that have the Auto-Submit label '
5030 'enabled')
Edward Lesmes8e282792018-04-03 18:50:29 -04005031 parser.add_option('--parallel', action='store_true',
5032 help='Run all tests specified by input_api.RunTests in all '
5033 'PRESUBMIT files in parallel.')
pgervais@chromium.org91141372014-01-09 23:27:20 +00005034
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08005035 # TODO: remove Rietveld flags
5036 parser.add_option('--private', action='store_true',
5037 help='set the review private (rietveld only)')
5038 parser.add_option('--email', default=None,
5039 help='email address to use to connect to Rietveld')
5040
rmistry@google.com2dd99862015-06-22 12:22:18 +00005041 orig_args = args
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005042 auth.add_auth_options(parser)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00005043 _add_codereview_select_options(parser)
ukai@chromium.orge8077812012-02-03 03:41:46 +00005044 (options, args) = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00005045 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005046 auth_config = auth.extract_auth_config_from_options(options)
ukai@chromium.orge8077812012-02-03 03:41:46 +00005047
sbc@chromium.org71437c02015-04-09 19:29:40 +00005048 if git_common.is_dirty_git_tree('upload'):
ukai@chromium.orge8077812012-02-03 03:41:46 +00005049 return 1
5050
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00005051 options.reviewers = cleanup_list(options.reviewers)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07005052 options.tbrs = cleanup_list(options.tbrs)
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00005053 options.cc = cleanup_list(options.cc)
5054
tandriib80458a2016-06-23 12:20:07 -07005055 if options.message_file:
5056 if options.message:
5057 parser.error('only one of --message and --message-file allowed.')
5058 options.message = gclient_utils.FileRead(options.message_file)
5059 options.message_file = None
5060
tandrii4d0545a2016-07-06 03:56:49 -07005061 if options.cq_dry_run and options.use_commit_queue:
5062 parser.error('only one of --use-commit-queue and --cq-dry-run allowed.')
5063
Aaron Gableedbc4132017-09-11 13:22:28 -07005064 if options.use_commit_queue:
5065 options.send_mail = True
5066
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00005067 # For sanity of test expectations, do this otherwise lazy-loading *now*.
5068 settings.GetIsGerrit()
5069
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00005070 cl = Changelist(auth_config=auth_config, codereview=options.forced_codereview)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00005071 return cl.CMDUpload(options, args, orig_args)
ukai@chromium.orge8077812012-02-03 03:41:46 +00005072
5073
Francois Dorayd42c6812017-05-30 15:10:20 -04005074@subcommand.usage('--description=<description file>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005075@metrics.collector.collect_metrics('git cl split')
Francois Dorayd42c6812017-05-30 15:10:20 -04005076def CMDsplit(parser, args):
5077 """Splits a branch into smaller branches and uploads CLs.
5078
5079 Creates a branch and uploads a CL for each group of files modified in the
5080 current branch that share a common OWNERS file. In the CL description and
Quinten Yearsley0c62da92017-05-31 13:39:42 -07005081 comment, the string '$directory', is replaced with the directory containing
Francois Dorayd42c6812017-05-30 15:10:20 -04005082 the shared OWNERS file.
5083 """
5084 parser.add_option("-d", "--description", dest="description_file",
Gabriel Charette02b5ee82017-11-08 16:36:05 -05005085 help="A text file containing a CL description in which "
5086 "$directory will be replaced by each CL's directory.")
Francois Dorayd42c6812017-05-30 15:10:20 -04005087 parser.add_option("-c", "--comment", dest="comment_file",
5088 help="A text file containing a CL comment.")
Chris Watkinsba28e462017-12-13 11:22:17 +11005089 parser.add_option("-n", "--dry-run", dest="dry_run", action='store_true',
5090 default=False,
5091 help="List the files and reviewers for each CL that would "
5092 "be created, but don't create branches or CLs.")
Francois Dorayd42c6812017-05-30 15:10:20 -04005093 options, _ = parser.parse_args(args)
5094
5095 if not options.description_file:
5096 parser.error('No --description flag specified.')
5097
5098 def WrappedCMDupload(args):
5099 return CMDupload(OptionParser(), args)
5100
5101 return split_cl.SplitCl(options.description_file, options.comment_file,
Chris Watkinsba28e462017-12-13 11:22:17 +11005102 Changelist, WrappedCMDupload, options.dry_run)
Francois Dorayd42c6812017-05-30 15:10:20 -04005103
5104
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005105@subcommand.usage('DEPRECATED')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005106@metrics.collector.collect_metrics('git cl commit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005107def CMDdcommit(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005108 """DEPRECATED: Used to commit the current changelist via git-svn."""
5109 message = ('git-cl no longer supports committing to SVN repositories via '
5110 'git-svn. You probably want to use `git cl land` instead.')
5111 print(message)
5112 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005113
5114
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01005115# Two special branches used by git cl land.
5116MERGE_BRANCH = 'git-cl-commit'
5117CHERRY_PICK_BRANCH = 'git-cl-cherry-pick'
5118
5119
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005120@subcommand.usage('[upstream branch to apply against]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005121@metrics.collector.collect_metrics('git cl land')
pgervais@chromium.orgcee6dc42014-05-07 17:04:03 +00005122def CMDland(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005123 """Commits the current changelist via git.
5124
5125 In case of Gerrit, uses Gerrit REST api to "submit" the issue, which pushes
5126 upstream and closes the issue automatically and atomically.
5127
5128 Otherwise (in case of Rietveld):
5129 Squashes branch into a single commit.
5130 Updates commit message with metadata (e.g. pointer to review).
5131 Pushes the code upstream.
5132 Updates review and closes.
5133 """
5134 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
5135 help='bypass upload presubmit hook')
5136 parser.add_option('-m', dest='message',
5137 help="override review description")
Aaron Gablef7543cd2017-07-20 14:26:31 -07005138 parser.add_option('-f', '--force', action='store_true', dest='force',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005139 help="force yes to questions (don't prompt)")
5140 parser.add_option('-c', dest='contributor',
5141 help="external contributor for patch (appended to " +
5142 "description and used as author for git). Should be " +
5143 "formatted as 'First Last <email@example.com>'")
Edward Lesmes67b3faa2018-04-13 17:50:52 -04005144 parser.add_option('--parallel', action='store_true',
5145 help='Run all tests specified by input_api.RunTests in all '
5146 'PRESUBMIT files in parallel.')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005147 auth.add_auth_options(parser)
5148 (options, args) = parser.parse_args(args)
5149 auth_config = auth.extract_auth_config_from_options(options)
5150
5151 cl = Changelist(auth_config=auth_config)
5152
Robert Iannucci2e73d432018-03-14 01:10:47 -07005153 if not cl.IsGerrit():
5154 parser.error('rietveld is not supported')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005155
Robert Iannucci2e73d432018-03-14 01:10:47 -07005156 if options.message:
5157 # This could be implemented, but it requires sending a new patch to
5158 # Gerrit, as Gerrit unlike Rietveld versions messages with patchsets.
5159 # Besides, Gerrit has the ability to change the commit message on submit
5160 # automatically, thus there is no need to support this option (so far?).
5161 parser.error('-m MESSAGE option is not supported for Gerrit.')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005162 if options.contributor:
Robert Iannucci2e73d432018-03-14 01:10:47 -07005163 parser.error(
5164 '-c CONTRIBUTOR option is not supported for Gerrit.\n'
5165 'Before uploading a commit to Gerrit, ensure it\'s author field is '
5166 'the contributor\'s "name <email>". If you can\'t upload such a '
5167 'commit for review, contact your repository admin and request'
5168 '"Forge-Author" permission.')
5169 if not cl.GetIssue():
5170 DieWithError('You must upload the change first to Gerrit.\n'
5171 ' If you would rather have `git cl land` upload '
5172 'automatically for you, see http://crbug.com/642759')
5173 return cl._codereview_impl.CMDLand(options.force, options.bypass_hooks,
Olivier Robin75ee7252018-04-13 10:02:56 +02005174 options.verbose, options.parallel)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005175
5176
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01005177def PushToGitWithAutoRebase(remote, branch, original_description,
5178 git_numberer_enabled, max_attempts=3):
5179 """Pushes current HEAD commit on top of remote's branch.
5180
5181 Attempts to fetch and autorebase on push failures.
5182 Adds git number footers on the fly.
5183
5184 Returns integer code from last command.
5185 """
5186 cherry = RunGit(['rev-parse', 'HEAD']).strip()
5187 code = 0
5188 attempts_left = max_attempts
5189 while attempts_left:
5190 attempts_left -= 1
5191 print('Attempt %d of %d' % (max_attempts - attempts_left, max_attempts))
5192
5193 # Fetch remote/branch into local cherry_pick_branch, overriding the latter.
5194 # If fetch fails, retry.
5195 print('Fetching %s/%s...' % (remote, branch))
5196 code, out = RunGitWithCode(
5197 ['retry', 'fetch', remote,
5198 '+%s:refs/heads/%s' % (branch, CHERRY_PICK_BRANCH)])
5199 if code:
5200 print('Fetch failed with exit code %d.' % code)
5201 print(out.strip())
5202 continue
5203
5204 print('Cherry-picking commit on top of latest %s' % branch)
5205 RunGitWithCode(['checkout', 'refs/heads/%s' % CHERRY_PICK_BRANCH],
5206 suppress_stderr=True)
5207 parent_hash = RunGit(['rev-parse', 'HEAD']).strip()
5208 code, out = RunGitWithCode(['cherry-pick', cherry])
5209 if code:
5210 print('Your patch doesn\'t apply cleanly to \'%s\' HEAD @ %s, '
5211 'the following files have merge conflicts:' %
5212 (branch, parent_hash))
Aaron Gable7817f022017-12-12 09:43:17 -08005213 print(RunGit(['-c', 'core.quotePath=false', 'diff',
5214 '--name-status', '--diff-filter=U']).strip())
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01005215 print('Please rebase your patch and try again.')
5216 RunGitWithCode(['cherry-pick', '--abort'])
5217 break
5218
5219 commit_desc = ChangeDescription(original_description)
5220 if git_numberer_enabled:
5221 logging.debug('Adding git number footers')
5222 parent_msg = RunGit(['show', '-s', '--format=%B', parent_hash]).strip()
5223 commit_desc.update_with_git_number_footers(parent_hash, parent_msg,
5224 branch)
5225 # Ensure timestamps are monotonically increasing.
5226 timestamp = max(1 + _get_committer_timestamp(parent_hash),
5227 _get_committer_timestamp('HEAD'))
5228 _git_amend_head(commit_desc.description, timestamp)
5229
5230 code, out = RunGitWithCode(
5231 ['push', '--porcelain', remote, 'HEAD:%s' % branch])
5232 print(out)
5233 if code == 0:
5234 break
5235 if IsFatalPushFailure(out):
5236 print('Fatal push error. Make sure your .netrc credentials and git '
Andrii Shyshkalov9d932212017-04-10 14:28:23 +02005237 'user.email are correct and you have push access to the repo.\n'
5238 'Hint: run command below to diangose common Git/Gerrit credential '
5239 'problems:\n'
5240 ' git cl creds-check\n')
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01005241 break
5242 return code
5243
5244
5245def IsFatalPushFailure(push_stdout):
5246 """True if retrying push won't help."""
5247 return '(prohibited by Gerrit)' in push_stdout
5248
5249
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00005250@subcommand.usage('<patch url or issue id or issue url>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005251@metrics.collector.collect_metrics('git cl patch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005252def CMDpatch(parser, args):
marq@chromium.orge5e59002013-10-02 23:21:25 +00005253 """Patches in a code review."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005254 parser.add_option('-b', dest='newbranch',
5255 help='create a new branch off trunk for the patch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00005256 parser.add_option('-f', '--force', action='store_true',
Aaron Gable62619a32017-06-16 08:22:09 -07005257 help='overwrite state on the current or chosen branch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00005258 parser.add_option('-d', '--directory', action='store', metavar='DIR',
Aaron Gable62619a32017-06-16 08:22:09 -07005259 help='change to the directory DIR immediately, '
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005260 'before doing anything else. Rietveld only.')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00005261 parser.add_option('--reject', action='store_true',
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +00005262 help='failed patches spew .rej files rather than '
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005263 'attempting a 3-way merge. Rietveld only.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005264 parser.add_option('-n', '--no-commit', action='store_true', dest='nocommit',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005265 help='don\'t commit after patch applies. Rietveld only.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005266
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005267
5268 group = optparse.OptionGroup(
5269 parser,
5270 'Options for continuing work on the current issue uploaded from a '
5271 'different clone (e.g. different machine). Must be used independently '
5272 'from the other options. No issue number should be specified, and the '
5273 'branch must have an issue number associated with it')
5274 group.add_option('--reapply', action='store_true', dest='reapply',
5275 help='Reset the branch and reapply the issue.\n'
5276 'CAUTION: This will undo any local changes in this '
5277 'branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005278
5279 group.add_option('--pull', action='store_true', dest='pull',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005280 help='Performs a pull before reapplying.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005281 parser.add_option_group(group)
5282
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005283 auth.add_auth_options(parser)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00005284 _add_codereview_select_options(parser)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005285 (options, args) = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00005286 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005287 auth_config = auth.extract_auth_config_from_options(options)
5288
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005289 if options.reapply:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005290 if options.newbranch:
5291 parser.error('--reapply works on the current branch only')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005292 if len(args) > 0:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005293 parser.error('--reapply implies no additional arguments')
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00005294
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005295 cl = Changelist(auth_config=auth_config,
5296 codereview=options.forced_codereview)
5297 if not cl.GetIssue():
5298 parser.error('current branch must have an associated issue')
5299
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005300 upstream = cl.GetUpstreamBranch()
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005301 if upstream is None:
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005302 parser.error('No upstream branch specified. Cannot reset branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005303
5304 RunGit(['reset', '--hard', upstream])
5305 if options.pull:
5306 RunGit(['pull'])
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005307
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005308 return cl.CMDPatchIssue(cl.GetIssue(), options.reject, options.nocommit,
5309 options.directory)
5310
5311 if len(args) != 1 or not args[0]:
5312 parser.error('Must specify issue number or url')
5313
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005314 target_issue_arg = ParseIssueNumberArgument(args[0],
5315 options.forced_codereview)
5316 if not target_issue_arg.valid:
5317 parser.error('invalid codereview url or CL id')
5318
5319 cl_kwargs = {
5320 'auth_config': auth_config,
5321 'codereview_host': target_issue_arg.hostname,
5322 'codereview': options.forced_codereview,
5323 }
5324 detected_codereview_from_url = False
5325 if target_issue_arg.codereview and not options.forced_codereview:
5326 detected_codereview_from_url = True
5327 cl_kwargs['codereview'] = target_issue_arg.codereview
5328 cl_kwargs['issue'] = target_issue_arg.issue
5329
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005330 # We don't want uncommitted changes mixed up with the patch.
5331 if git_common.is_dirty_git_tree('patch'):
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00005332 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005333
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005334 if options.newbranch:
5335 if options.force:
5336 RunGit(['branch', '-D', options.newbranch],
5337 stderr=subprocess2.PIPE, error_ok=True)
5338 RunGit(['new-branch', options.newbranch])
5339
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005340 cl = Changelist(**cl_kwargs)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005341
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005342 if cl.IsGerrit():
5343 if options.reject:
5344 parser.error('--reject is not supported with Gerrit codereview.')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005345 if options.directory:
5346 parser.error('--directory is not supported with Gerrit codereview.')
5347
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005348 if detected_codereview_from_url:
5349 print('canonical issue/change URL: %s (type: %s)\n' %
5350 (cl.GetIssueURL(), target_issue_arg.codereview))
5351
5352 return cl.CMDPatchWithParsedIssue(target_issue_arg, options.reject,
Aaron Gable62619a32017-06-16 08:22:09 -07005353 options.nocommit, options.directory,
5354 options.force)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005355
5356
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00005357def GetTreeStatus(url=None):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005358 """Fetches the tree status and returns either 'open', 'closed',
5359 'unknown' or 'unset'."""
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00005360 url = url or settings.GetTreeStatusUrl(error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005361 if url:
5362 status = urllib2.urlopen(url).read().lower()
5363 if status.find('closed') != -1 or status == '0':
5364 return 'closed'
5365 elif status.find('open') != -1 or status == '1':
5366 return 'open'
5367 return 'unknown'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005368 return 'unset'
5369
dpranke@chromium.org970c5222011-03-12 00:32:24 +00005370
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005371def GetTreeStatusReason():
5372 """Fetches the tree status from a json url and returns the message
5373 with the reason for the tree to be opened or closed."""
msb@chromium.orgbf1a7ba2011-02-01 16:21:46 +00005374 url = settings.GetTreeStatusUrl()
5375 json_url = urlparse.urljoin(url, '/current?format=json')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005376 connection = urllib2.urlopen(json_url)
5377 status = json.loads(connection.read())
5378 connection.close()
5379 return status['message']
5380
dpranke@chromium.org970c5222011-03-12 00:32:24 +00005381
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005382@metrics.collector.collect_metrics('git cl tree')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005383def CMDtree(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005384 """Shows the status of the tree."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00005385 _, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005386 status = GetTreeStatus()
5387 if 'unset' == status:
vapiera7fbd5a2016-06-16 09:17:49 -07005388 print('You must configure your tree status URL by running "git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005389 return 2
5390
vapiera7fbd5a2016-06-16 09:17:49 -07005391 print('The tree is %s' % status)
5392 print()
5393 print(GetTreeStatusReason())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005394 if status != 'open':
5395 return 1
5396 return 0
5397
5398
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005399@metrics.collector.collect_metrics('git cl try')
maruel@chromium.org15192402012-09-06 12:38:29 +00005400def CMDtry(parser, args):
qyearsley1fdfcb62016-10-24 13:22:03 -07005401 """Triggers try jobs using either BuildBucket or CQ dry run."""
tandrii1838bad2016-10-06 00:10:52 -07005402 group = optparse.OptionGroup(parser, 'Try job options')
maruel@chromium.org15192402012-09-06 12:38:29 +00005403 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005404 '-b', '--bot', action='append',
5405 help=('IMPORTANT: specify ONE builder per --bot flag. Use it multiple '
5406 'times to specify multiple builders. ex: '
5407 '"-b win_rel -b win_layout". See '
5408 'the try server waterfall for the builders name and the tests '
5409 'available.'))
maruel@chromium.org15192402012-09-06 12:38:29 +00005410 group.add_option(
borenet6c0efe62016-10-19 08:13:29 -07005411 '-B', '--bucket', default='',
5412 help=('Buildbucket bucket to send the try requests.'))
5413 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005414 '-m', '--master', default='',
Nodir Turakulovf6929a12017-10-09 12:34:44 -07005415 help=('DEPRECATED, use -B. The try master where to run the builds.'))
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00005416 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005417 '-r', '--revision',
tandriif7b29d42016-10-07 08:45:41 -07005418 help='Revision to use for the try job; default: the revision will '
5419 'be determined by the try recipe that builder runs, which usually '
5420 'defaults to HEAD of origin/master')
maruel@chromium.org15192402012-09-06 12:38:29 +00005421 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005422 '-c', '--clobber', action='store_true', default=False,
tandriif7b29d42016-10-07 08:45:41 -07005423 help='Force a clobber before building; that is don\'t do an '
tandrii1838bad2016-10-06 00:10:52 -07005424 'incremental build')
maruel@chromium.org15192402012-09-06 12:38:29 +00005425 group.add_option(
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08005426 '--category', default='git_cl_try', help='Specify custom build category.')
5427 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005428 '--project',
5429 help='Override which project to use. Projects are defined '
tandriif7b29d42016-10-07 08:45:41 -07005430 'in recipe to determine to which repository or directory to '
5431 'apply the patch')
maruel@chromium.org15192402012-09-06 12:38:29 +00005432 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005433 '-p', '--property', dest='properties', action='append', default=[],
5434 help='Specify generic properties in the form -p key1=value1 -p '
tandriif7b29d42016-10-07 08:45:41 -07005435 'key2=value2 etc. The value will be treated as '
5436 'json if decodable, or as string otherwise. '
5437 'NOTE: using this may make your try job not usable for CQ, '
5438 'which will then schedule another try job with default properties')
sheyang@chromium.orgdb375572015-08-17 19:22:23 +00005439 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005440 '--buildbucket-host', default='cr-buildbucket.appspot.com',
5441 help='Host of buildbucket. The default host is %default.')
maruel@chromium.org15192402012-09-06 12:38:29 +00005442 parser.add_option_group(group)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005443 auth.add_auth_options(parser)
Koji Ishii31c14782018-01-08 17:17:33 +09005444 _add_codereview_issue_select_options(parser)
maruel@chromium.org15192402012-09-06 12:38:29 +00005445 options, args = parser.parse_args(args)
Koji Ishii31c14782018-01-08 17:17:33 +09005446 _process_codereview_issue_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005447 auth_config = auth.extract_auth_config_from_options(options)
maruel@chromium.org15192402012-09-06 12:38:29 +00005448
Nodir Turakulovf6929a12017-10-09 12:34:44 -07005449 if options.master and options.master.startswith('luci.'):
5450 parser.error(
5451 '-m option does not support LUCI. Please pass -B %s' % options.master)
machenbach@chromium.org45453142015-09-15 08:45:22 +00005452 # Make sure that all properties are prop=value pairs.
5453 bad_params = [x for x in options.properties if '=' not in x]
5454 if bad_params:
5455 parser.error('Got properties with missing "=": %s' % bad_params)
5456
maruel@chromium.org15192402012-09-06 12:38:29 +00005457 if args:
5458 parser.error('Unknown arguments: %s' % args)
5459
Koji Ishii31c14782018-01-08 17:17:33 +09005460 cl = Changelist(auth_config=auth_config, issue=options.issue,
5461 codereview=options.forced_codereview)
maruel@chromium.org15192402012-09-06 12:38:29 +00005462 if not cl.GetIssue():
5463 parser.error('Need to upload first')
5464
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01005465 if cl.IsGerrit():
5466 # HACK: warm up Gerrit change detail cache to save on RPCs.
5467 cl._codereview_impl._GetChangeDetail(['DETAILED_ACCOUNTS', 'ALL_REVISIONS'])
5468
tandriie113dfd2016-10-11 10:20:12 -07005469 error_message = cl.CannotTriggerTryJobReason()
5470 if error_message:
qyearsley99e2cdf2016-10-23 12:51:41 -07005471 parser.error('Can\'t trigger try jobs: %s' % error_message)
jrobbins@chromium.org16f10f72014-06-24 22:14:36 +00005472
borenet6c0efe62016-10-19 08:13:29 -07005473 if options.bucket and options.master:
5474 parser.error('Only one of --bucket and --master may be used.')
5475
qyearsley1fdfcb62016-10-24 13:22:03 -07005476 buckets = _get_bucket_map(cl, options, parser)
phajdan.jr@chromium.org8da7f272014-03-14 01:28:39 +00005477
qyearsleydd49f942016-10-28 11:57:22 -07005478 # If no bots are listed and we couldn't get a list based on PRESUBMIT files,
5479 # then we default to triggering a CQ dry run (see http://crbug.com/625697).
qyearsley1fdfcb62016-10-24 13:22:03 -07005480 if not buckets:
qyearsley1fdfcb62016-10-24 13:22:03 -07005481 if options.verbose:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07005482 print('git cl try with no bots now defaults to CQ dry run.')
5483 print('Scheduling CQ dry run on: %s' % cl.GetIssueURL())
5484 return cl.SetCQState(_CQState.DRY_RUN)
stip@chromium.org43064fd2013-12-18 20:07:44 +00005485
borenet6c0efe62016-10-19 08:13:29 -07005486 for builders in buckets.itervalues():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00005487 if any('triggered' in b for b in builders):
vapiera7fbd5a2016-06-16 09:17:49 -07005488 print('ERROR You are trying to send a job to a triggered bot. This type '
tandriide281ae2016-10-12 06:02:30 -07005489 'of bot requires an initial job from a parent (usually a builder). '
5490 'Instead send your job to the parent.\n'
vapiera7fbd5a2016-06-16 09:17:49 -07005491 'Bot list: %s' % builders, file=sys.stderr)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00005492 return 1
ilevy@chromium.orgf3b21232012-09-24 20:48:55 +00005493
ilevy@chromium.org36e420b2013-08-06 23:21:12 +00005494 patchset = cl.GetMostRecentPatchset()
Ravi Mistryfda50ca2016-11-14 10:19:18 -05005495 # TODO(tandrii): Checking local patchset against remote patchset is only
5496 # supported for Rietveld. Extend it to Gerrit or remove it completely.
5497 if not cl.IsGerrit() and patchset != cl.GetPatchset():
tandriide281ae2016-10-12 06:02:30 -07005498 print('Warning: Codereview server has newer patchsets (%s) than most '
5499 'recent upload from local checkout (%s). Did a previous upload '
5500 'fail?\n'
5501 'By default, git cl try uses the latest patchset from '
5502 'codereview, continuing to use patchset %s.\n' %
5503 (patchset, cl.GetPatchset(), patchset))
qyearsley1fdfcb62016-10-24 13:22:03 -07005504
tandrii568043b2016-10-11 07:49:18 -07005505 try:
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08005506 _trigger_try_jobs(auth_config, cl, buckets, options, patchset)
tandrii568043b2016-10-11 07:49:18 -07005507 except BuildbucketResponseException as ex:
5508 print('ERROR: %s' % ex)
5509 return 1
maruel@chromium.org15192402012-09-06 12:38:29 +00005510 return 0
5511
5512
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005513@metrics.collector.collect_metrics('git cl try-results')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005514def CMDtry_results(parser, args):
tandrii1838bad2016-10-06 00:10:52 -07005515 """Prints info about try jobs associated with current CL."""
5516 group = optparse.OptionGroup(parser, 'Try job results options')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005517 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005518 '-p', '--patchset', type=int, help='patchset number if not current.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005519 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005520 '--print-master', action='store_true', help='print master name as well.')
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +00005521 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005522 '--color', action='store_true', default=setup_color.IS_TTY,
5523 help='force color output, useful when piping output.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005524 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005525 '--buildbucket-host', default='cr-buildbucket.appspot.com',
5526 help='Host of buildbucket. The default host is %default.')
qyearsley53f48a12016-09-01 10:45:13 -07005527 group.add_option(
Stefan Zager1306bd02017-06-22 19:26:46 -07005528 '--json', help=('Path of JSON output file to write try job results to,'
5529 'or "-" for stdout.'))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005530 parser.add_option_group(group)
5531 auth.add_auth_options(parser)
Stefan Zager27db3f22017-10-10 15:15:01 -07005532 _add_codereview_issue_select_options(parser)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005533 options, args = parser.parse_args(args)
Stefan Zager27db3f22017-10-10 15:15:01 -07005534 _process_codereview_issue_select_options(parser, options)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005535 if args:
5536 parser.error('Unrecognized args: %s' % ' '.join(args))
5537
5538 auth_config = auth.extract_auth_config_from_options(options)
Stefan Zager27db3f22017-10-10 15:15:01 -07005539 cl = Changelist(
5540 issue=options.issue, codereview=options.forced_codereview,
5541 auth_config=auth_config)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005542 if not cl.GetIssue():
5543 parser.error('Need to upload first')
5544
tandrii221ab252016-10-06 08:12:04 -07005545 patchset = options.patchset
5546 if not patchset:
5547 patchset = cl.GetMostRecentPatchset()
5548 if not patchset:
5549 parser.error('Codereview doesn\'t know about issue %s. '
5550 'No access to issue or wrong issue number?\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01005551 'Either upload first, or pass --patchset explicitly' %
tandrii221ab252016-10-06 08:12:04 -07005552 cl.GetIssue())
5553
Ravi Mistryfda50ca2016-11-14 10:19:18 -05005554 # TODO(tandrii): Checking local patchset against remote patchset is only
5555 # supported for Rietveld. Extend it to Gerrit or remove it completely.
5556 if not cl.IsGerrit() and patchset != cl.GetPatchset():
tandrii45b2a582016-10-11 03:14:16 -07005557 print('Warning: Codereview server has newer patchsets (%s) than most '
5558 'recent upload from local checkout (%s). Did a previous upload '
5559 'fail?\n'
tandriide281ae2016-10-12 06:02:30 -07005560 'By default, git cl try-results uses the latest patchset from '
5561 'codereview, continuing to use patchset %s.\n' %
tandrii45b2a582016-10-11 03:14:16 -07005562 (patchset, cl.GetPatchset(), patchset))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005563 try:
tandrii221ab252016-10-06 08:12:04 -07005564 jobs = fetch_try_jobs(auth_config, cl, options.buildbucket_host, patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005565 except BuildbucketResponseException as ex:
vapiera7fbd5a2016-06-16 09:17:49 -07005566 print('Buildbucket error: %s' % ex)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005567 return 1
qyearsley53f48a12016-09-01 10:45:13 -07005568 if options.json:
5569 write_try_results_json(options.json, jobs)
5570 else:
5571 print_try_jobs(options, jobs)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005572 return 0
5573
5574
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005575@subcommand.usage('[new upstream branch]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005576@metrics.collector.collect_metrics('git cl upstream')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005577def CMDupstream(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005578 """Prints or sets the name of the upstream branch, if any."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00005579 _, args = parser.parse_args(args)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005580 if len(args) > 1:
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005581 parser.error('Unrecognized args: %s' % ' '.join(args))
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005582
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005583 cl = Changelist()
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005584 if args:
5585 # One arg means set upstream branch.
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00005586 branch = cl.GetBranch()
stip7a3dd352016-09-22 17:32:28 -07005587 RunGit(['branch', '--set-upstream-to', args[0], branch])
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005588 cl = Changelist()
vapiera7fbd5a2016-06-16 09:17:49 -07005589 print('Upstream branch set to %s' % (cl.GetUpstreamBranch(),))
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00005590
5591 # Clear configured merge-base, if there is one.
5592 git_common.remove_merge_base(branch)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005593 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005594 print(cl.GetUpstreamBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005595 return 0
5596
5597
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005598@metrics.collector.collect_metrics('git cl web')
thestig@chromium.org00858c82013-12-02 23:08:03 +00005599def CMDweb(parser, args):
5600 """Opens the current CL in the web browser."""
5601 _, args = parser.parse_args(args)
5602 if args:
5603 parser.error('Unrecognized args: %s' % ' '.join(args))
5604
5605 issue_url = Changelist().GetIssueURL()
5606 if not issue_url:
vapiera7fbd5a2016-06-16 09:17:49 -07005607 print('ERROR No issue to open', file=sys.stderr)
thestig@chromium.org00858c82013-12-02 23:08:03 +00005608 return 1
5609
5610 webbrowser.open(issue_url)
5611 return 0
5612
5613
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005614@metrics.collector.collect_metrics('git cl set-commit')
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005615def CMDset_commit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005616 """Sets the commit bit to trigger the Commit Queue."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005617 parser.add_option('-d', '--dry-run', action='store_true',
5618 help='trigger in dry run mode')
5619 parser.add_option('-c', '--clear', action='store_true',
5620 help='stop CQ run, if any')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005621 auth.add_auth_options(parser)
iannuccie53c9352016-08-17 14:40:40 -07005622 _add_codereview_issue_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005623 options, args = parser.parse_args(args)
iannuccie53c9352016-08-17 14:40:40 -07005624 _process_codereview_issue_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005625 auth_config = auth.extract_auth_config_from_options(options)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005626 if args:
5627 parser.error('Unrecognized args: %s' % ' '.join(args))
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005628 if options.dry_run and options.clear:
5629 parser.error('Make up your mind: both --dry-run and --clear not allowed')
5630
iannuccie53c9352016-08-17 14:40:40 -07005631 cl = Changelist(auth_config=auth_config, issue=options.issue,
5632 codereview=options.forced_codereview)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005633 if options.clear:
tandriid9e5ce52016-07-13 02:32:59 -07005634 state = _CQState.NONE
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005635 elif options.dry_run:
5636 state = _CQState.DRY_RUN
5637 else:
5638 state = _CQState.COMMIT
5639 if not cl.GetIssue():
5640 parser.error('Must upload the issue first')
tandrii9de9ec62016-07-13 03:01:59 -07005641 cl.SetCQState(state)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005642 return 0
5643
5644
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005645@metrics.collector.collect_metrics('git cl set-close')
groby@chromium.org411034a2013-02-26 15:12:01 +00005646def CMDset_close(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005647 """Closes the issue."""
iannuccie53c9352016-08-17 14:40:40 -07005648 _add_codereview_issue_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005649 auth.add_auth_options(parser)
5650 options, args = parser.parse_args(args)
iannuccie53c9352016-08-17 14:40:40 -07005651 _process_codereview_issue_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005652 auth_config = auth.extract_auth_config_from_options(options)
groby@chromium.org411034a2013-02-26 15:12:01 +00005653 if args:
5654 parser.error('Unrecognized args: %s' % ' '.join(args))
iannuccie53c9352016-08-17 14:40:40 -07005655 cl = Changelist(auth_config=auth_config, issue=options.issue,
5656 codereview=options.forced_codereview)
groby@chromium.org411034a2013-02-26 15:12:01 +00005657 # Ensure there actually is an issue to close.
Aaron Gable7139a4e2017-09-05 17:53:09 -07005658 if not cl.GetIssue():
5659 DieWithError('ERROR No issue to close')
groby@chromium.org411034a2013-02-26 15:12:01 +00005660 cl.CloseIssue()
5661 return 0
5662
5663
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005664@metrics.collector.collect_metrics('git cl diff')
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005665def CMDdiff(parser, args):
wychen@chromium.org37b2ec02015-04-03 00:49:15 +00005666 """Shows differences between local tree and last upload."""
thomasanderson074beb22016-08-29 14:03:20 -07005667 parser.add_option(
5668 '--stat',
5669 action='store_true',
5670 dest='stat',
5671 help='Generate a diffstat')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005672 auth.add_auth_options(parser)
5673 options, args = parser.parse_args(args)
5674 auth_config = auth.extract_auth_config_from_options(options)
5675 if args:
5676 parser.error('Unrecognized args: %s' % ' '.join(args))
wychen@chromium.org46309bf2015-04-03 21:04:49 +00005677
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005678 cl = Changelist(auth_config=auth_config)
sbc@chromium.org78dc9842013-11-25 18:43:44 +00005679 issue = cl.GetIssue()
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005680 branch = cl.GetBranch()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00005681 if not issue:
5682 DieWithError('No issue found for current branch (%s)' % branch)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005683
Aaron Gablea718c3e2017-08-28 17:47:28 -07005684 base = cl._GitGetBranchConfigValue('last-upload-hash')
5685 if not base:
5686 base = cl._GitGetBranchConfigValue('gerritsquashhash')
5687 if not base:
5688 detail = cl._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
5689 revision_info = detail['revisions'][detail['current_revision']]
5690 fetch_info = revision_info['fetch']['http']
5691 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
5692 base = 'FETCH_HEAD'
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005693
Aaron Gablea718c3e2017-08-28 17:47:28 -07005694 cmd = ['git', 'diff']
5695 if options.stat:
5696 cmd.append('--stat')
5697 cmd.append(base)
5698 subprocess2.check_call(cmd)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005699
5700 return 0
5701
5702
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005703@metrics.collector.collect_metrics('git cl owners')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005704def CMDowners(parser, args):
Dirk Prankebf980882017-09-02 15:08:00 -07005705 """Finds potential owners for reviewing."""
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005706 parser.add_option(
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00005707 '--ignore-current',
5708 action='store_true',
5709 help='Ignore the CL\'s current reviewers and start from scratch.')
5710 parser.add_option(
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005711 '--no-color',
5712 action='store_true',
5713 help='Use this option to disable color output')
Dirk Prankebf980882017-09-02 15:08:00 -07005714 parser.add_option(
5715 '--batch',
5716 action='store_true',
5717 help='Do not run interactively, just suggest some')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005718 auth.add_auth_options(parser)
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005719 options, args = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005720 auth_config = auth.extract_auth_config_from_options(options)
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005721
5722 author = RunGit(['config', 'user.email']).strip() or None
5723
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005724 cl = Changelist(auth_config=auth_config)
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005725
5726 if args:
5727 if len(args) > 1:
5728 parser.error('Unknown args')
5729 base_branch = args[0]
5730 else:
5731 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005732 base_branch = cl.GetCommonAncestorWithUpstream()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005733
5734 change = cl.GetChange(base_branch, None)
Dirk Prankebf980882017-09-02 15:08:00 -07005735 affected_files = [f.LocalPath() for f in change.AffectedFiles()]
5736
5737 if options.batch:
5738 db = owners.Database(change.RepositoryRoot(), file, os.path)
5739 print('\n'.join(db.reviewers_for(affected_files, author)))
5740 return 0
5741
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005742 return owners_finder.OwnersFinder(
Dirk Prankebf980882017-09-02 15:08:00 -07005743 affected_files,
Jochen Eisinger72606f82017-04-04 10:44:18 +02005744 change.RepositoryRoot(),
Edward Lemur707d70b2018-02-07 00:50:14 +01005745 author,
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00005746 [] if options.ignore_current else cl.GetReviewers(),
Edward Lemur707d70b2018-02-07 00:50:14 +01005747 fopen=file, os_path=os.path,
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02005748 disable_color=options.no_color,
5749 override_files=change.OriginalOwnersFiles()).run()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005750
5751
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005752def BuildGitDiffCmd(diff_type, upstream_commit, args):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005753 """Generates a diff command."""
5754 # Generate diff for the current branch's changes.
Aaron Gablef4068aa2017-12-12 15:14:09 -08005755 diff_cmd = ['-c', 'core.quotePath=false', 'diff',
5756 '--no-ext-diff', '--no-prefix', diff_type,
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005757 upstream_commit, '--']
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005758
5759 if args:
5760 for arg in args:
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005761 if os.path.isdir(arg) or os.path.isfile(arg):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005762 diff_cmd.append(arg)
5763 else:
5764 DieWithError('Argument "%s" is not a file or a directory' % arg)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005765
5766 return diff_cmd
5767
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005768
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005769def MatchingFileType(file_name, extensions):
5770 """Returns true if the file name ends with one of the given extensions."""
5771 return bool([ext for ext in extensions if file_name.lower().endswith(ext)])
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005772
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005773
enne@chromium.org555cfe42014-01-29 18:21:39 +00005774@subcommand.usage('[files or directories to diff]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005775@metrics.collector.collect_metrics('git cl format')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005776def CMDformat(parser, args):
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005777 """Runs auto-formatting tools (clang-format etc.) on the diff."""
Christopher Lamc5ba6922017-01-24 11:19:14 +11005778 CLANG_EXTS = ['.cc', '.cpp', '.h', '.m', '.mm', '.proto', '.java']
kylechar58edce22016-06-17 06:07:51 -07005779 GN_EXTS = ['.gn', '.gni', '.typemap']
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00005780 parser.add_option('--full', action='store_true',
5781 help='Reformat the full content of all touched files')
5782 parser.add_option('--dry-run', action='store_true',
5783 help='Don\'t modify any file on disk.')
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005784 parser.add_option('--python', action='store_true',
5785 help='Format python code with yapf (experimental).')
Christopher Lamc5ba6922017-01-24 11:19:14 +11005786 parser.add_option('--js', action='store_true',
5787 help='Format javascript code with clang-format.')
wittman@chromium.org04d5a222014-03-07 18:30:42 +00005788 parser.add_option('--diff', action='store_true',
5789 help='Print diff to stdout rather than modifying files.')
Ilya Shermane081cbe2017-08-15 17:51:04 -07005790 parser.add_option('--presubmit', action='store_true',
5791 help='Used when running the script from a presubmit.')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005792 opts, args = parser.parse_args(args)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005793
Daniel Chengc55eecf2016-12-30 03:11:02 -08005794 # Normalize any remaining args against the current path, so paths relative to
5795 # the current directory are still resolved as expected.
5796 args = [os.path.join(os.getcwd(), arg) for arg in args]
5797
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005798 # git diff generates paths against the root of the repository. Change
5799 # to that directory so clang-format can find files even within subdirs.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005800 rel_base_path = settings.GetRelativeRoot()
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005801 if rel_base_path:
5802 os.chdir(rel_base_path)
5803
digit@chromium.org29e47272013-05-17 17:01:46 +00005804 # Grab the merge-base commit, i.e. the upstream commit of the current
5805 # branch when it was created or the last time it was rebased. This is
5806 # to cover the case where the user may have called "git fetch origin",
5807 # moving the origin branch to a newer commit, but hasn't rebased yet.
5808 upstream_commit = None
5809 cl = Changelist()
5810 upstream_branch = cl.GetUpstreamBranch()
5811 if upstream_branch:
5812 upstream_commit = RunGit(['merge-base', 'HEAD', upstream_branch])
5813 upstream_commit = upstream_commit.strip()
5814
5815 if not upstream_commit:
5816 DieWithError('Could not find base commit for this branch. '
5817 'Are you in detached state?')
5818
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005819 changed_files_cmd = BuildGitDiffCmd('--name-only', upstream_commit, args)
5820 diff_output = RunGit(changed_files_cmd)
5821 diff_files = diff_output.splitlines()
jkarlin@chromium.orgad21b922016-01-28 17:48:42 +00005822 # Filter out files deleted by this CL
5823 diff_files = [x for x in diff_files if os.path.isfile(x)]
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005824
Christopher Lamc5ba6922017-01-24 11:19:14 +11005825 if opts.js:
Deepanjan Roy605dd312018-07-02 17:48:54 +00005826 CLANG_EXTS.extend(['.js', '.ts'])
Christopher Lamc5ba6922017-01-24 11:19:14 +11005827
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005828 clang_diff_files = [x for x in diff_files if MatchingFileType(x, CLANG_EXTS)]
5829 python_diff_files = [x for x in diff_files if MatchingFileType(x, ['.py'])]
5830 dart_diff_files = [x for x in diff_files if MatchingFileType(x, ['.dart'])]
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005831 gn_diff_files = [x for x in diff_files if MatchingFileType(x, GN_EXTS)]
digit@chromium.org29e47272013-05-17 17:01:46 +00005832
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +00005833 top_dir = os.path.normpath(
5834 RunGit(["rev-parse", "--show-toplevel"]).rstrip('\n'))
5835
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005836 # Set to 2 to signal to CheckPatchFormatted() that this patch isn't
5837 # formatted. This is used to block during the presubmit.
5838 return_value = 0
5839
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005840 if clang_diff_files:
techtonik@gmail.com5573df12016-04-12 18:34:10 +00005841 # Locate the clang-format binary in the checkout
5842 try:
5843 clang_format_tool = clang_format.FindClangFormatToolInChromiumTree()
vapierfd77ac72016-06-16 08:33:57 -07005844 except clang_format.NotFoundError as e:
techtonik@gmail.com5573df12016-04-12 18:34:10 +00005845 DieWithError(e)
5846
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005847 if opts.full:
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005848 cmd = [clang_format_tool]
5849 if not opts.dry_run and not opts.diff:
5850 cmd.append('-i')
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005851 stdout = RunCommand(cmd + clang_diff_files, cwd=top_dir)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005852 if opts.diff:
5853 sys.stdout.write(stdout)
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005854 else:
5855 env = os.environ.copy()
5856 env['PATH'] = str(os.path.dirname(clang_format_tool))
5857 try:
5858 script = clang_format.FindClangFormatScriptInChromiumTree(
5859 'clang-format-diff.py')
vapierfd77ac72016-06-16 08:33:57 -07005860 except clang_format.NotFoundError as e:
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005861 DieWithError(e)
digit@chromium.orgd6ddc1c2013-10-25 15:36:32 +00005862
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005863 cmd = [sys.executable, script, '-p0']
5864 if not opts.dry_run and not opts.diff:
5865 cmd.append('-i')
digit@chromium.orgd6ddc1c2013-10-25 15:36:32 +00005866
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005867 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, clang_diff_files)
5868 diff_output = RunGit(diff_cmd)
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005869
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005870 stdout = RunCommand(cmd, stdin=diff_output, cwd=top_dir, env=env)
5871 if opts.diff:
5872 sys.stdout.write(stdout)
5873 if opts.dry_run and len(stdout) > 0:
5874 return_value = 2
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005875
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005876 # Similar code to above, but using yapf on .py files rather than clang-format
5877 # on C/C++ files
5878 if opts.python:
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005879 yapf_tool = gclient_utils.FindExecutable('yapf')
5880 if yapf_tool is None:
5881 DieWithError('yapf not found in PATH')
5882
5883 if opts.full:
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005884 if python_diff_files:
Nodir Turakulovaf43f402018-05-31 14:54:24 -07005885 if opts.dry_run or opts.diff:
5886 cmd = [yapf_tool, '--diff'] + python_diff_files
5887 stdout = RunCommand(cmd, error_ok=True, cwd=top_dir)
5888 if opts.diff:
5889 sys.stdout.write(stdout)
5890 elif len(stdout) > 0:
5891 return_value = 2
5892 else:
5893 RunCommand([yapf_tool, '-i'] + python_diff_files, cwd=top_dir)
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005894 else:
5895 # TODO(sbc): yapf --lines mode still has some issues.
5896 # https://github.com/google/yapf/issues/154
5897 DieWithError('--python currently only works with --full')
5898
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005899 # Dart's formatter does not have the nice property of only operating on
5900 # modified chunks, so hard code full.
5901 if dart_diff_files:
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005902 try:
5903 command = [dart_format.FindDartFmtToolInChromiumTree()]
5904 if not opts.dry_run and not opts.diff:
5905 command.append('-w')
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005906 command.extend(dart_diff_files)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005907
ppi@chromium.org6593d932016-03-03 15:41:15 +00005908 stdout = RunCommand(command, cwd=top_dir)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005909 if opts.dry_run and stdout:
5910 return_value = 2
5911 except dart_format.NotFoundError as e:
vapiera7fbd5a2016-06-16 09:17:49 -07005912 print('Warning: Unable to check Dart code formatting. Dart SDK not '
5913 'found in this checkout. Files in other languages are still '
5914 'formatted.')
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005915
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005916 # Format GN build files. Always run on full build files for canonical form.
5917 if gn_diff_files:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005918 cmd = ['gn', 'format']
brettw4b8ed592016-08-05 16:19:12 -07005919 if opts.dry_run or opts.diff:
5920 cmd.append('--dry-run')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005921 for gn_diff_file in gn_diff_files:
brettw4b8ed592016-08-05 16:19:12 -07005922 gn_ret = subprocess2.call(cmd + [gn_diff_file],
5923 shell=sys.platform == 'win32',
5924 cwd=top_dir)
5925 if opts.dry_run and gn_ret == 2:
5926 return_value = 2 # Not formatted.
5927 elif opts.diff and gn_ret == 2:
5928 # TODO this should compute and print the actual diff.
5929 print("This change has GN build file diff for " + gn_diff_file)
5930 elif gn_ret != 0:
5931 # For non-dry run cases (and non-2 return values for dry-run), a
5932 # nonzero error code indicates a failure, probably because the file
5933 # doesn't parse.
5934 DieWithError("gn format failed on " + gn_diff_file +
5935 "\nTry running 'gn format' on this file manually.")
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005936
Ilya Shermane081cbe2017-08-15 17:51:04 -07005937 # Skip the metrics formatting from the global presubmit hook. These files have
5938 # a separate presubmit hook that issues an error if the files need formatting,
5939 # whereas the top-level presubmit script merely issues a warning. Formatting
5940 # these files is somewhat slow, so it's important not to duplicate the work.
5941 if not opts.presubmit:
5942 for xml_dir in GetDirtyMetricsDirs(diff_files):
5943 tool_dir = os.path.join(top_dir, xml_dir)
5944 cmd = [os.path.join(tool_dir, 'pretty_print.py'), '--non-interactive']
5945 if opts.dry_run or opts.diff:
5946 cmd.append('--diff')
Ilya Sherman235b70d2017-08-22 17:46:38 -07005947 stdout = RunCommand(cmd, cwd=top_dir)
Ilya Shermane081cbe2017-08-15 17:51:04 -07005948 if opts.diff:
5949 sys.stdout.write(stdout)
5950 if opts.dry_run and stdout:
5951 return_value = 2 # Not formatted.
Alexei Svitkinef3cac412017-02-06 11:08:50 -05005952
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005953 return return_value
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005954
Steven Holte2e664bf2017-04-21 13:10:47 -07005955def GetDirtyMetricsDirs(diff_files):
5956 xml_diff_files = [x for x in diff_files if MatchingFileType(x, ['.xml'])]
5957 metrics_xml_dirs = [
5958 os.path.join('tools', 'metrics', 'actions'),
5959 os.path.join('tools', 'metrics', 'histograms'),
5960 os.path.join('tools', 'metrics', 'rappor'),
5961 os.path.join('tools', 'metrics', 'ukm')]
5962 for xml_dir in metrics_xml_dirs:
5963 if any(file.startswith(xml_dir) for file in xml_diff_files):
5964 yield xml_dir
5965
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005966
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005967@subcommand.usage('<codereview url or issue id>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005968@metrics.collector.collect_metrics('git cl checkout')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005969def CMDcheckout(parser, args):
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005970 """Checks out a branch associated with a given Rietveld or Gerrit issue."""
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005971 _, args = parser.parse_args(args)
5972
5973 if len(args) != 1:
5974 parser.print_help()
5975 return 1
5976
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005977 issue_arg = ParseIssueNumberArgument(args[0])
tandrii@chromium.orgde6c9a12016-04-11 15:33:53 +00005978 if not issue_arg.valid:
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02005979 parser.error('invalid codereview url or CL id')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005980
tandrii@chromium.orgabd27e52016-04-11 15:43:32 +00005981 target_issue = str(issue_arg.issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005982
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005983 def find_issues(issueprefix):
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00005984 output = RunGit(['config', '--local', '--get-regexp',
5985 r'branch\..*\.%s' % issueprefix],
5986 error_ok=True)
5987 for key, issue in [x.split() for x in output.splitlines()]:
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005988 if issue == target_issue:
5989 yield re.sub(r'branch\.(.*)\.%s' % issueprefix, r'\1', key)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005990
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005991 branches = []
5992 for cls in _CODEREVIEW_IMPLEMENTATIONS.values():
tandrii5d48c322016-08-18 16:19:37 -07005993 branches.extend(find_issues(cls.IssueConfigKey()))
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005994 if len(branches) == 0:
vapiera7fbd5a2016-06-16 09:17:49 -07005995 print('No branch found for issue %s.' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005996 return 1
5997 if len(branches) == 1:
5998 RunGit(['checkout', branches[0]])
5999 else:
vapiera7fbd5a2016-06-16 09:17:49 -07006000 print('Multiple branches match issue %s:' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00006001 for i in range(len(branches)):
vapiera7fbd5a2016-06-16 09:17:49 -07006002 print('%d: %s' % (i, branches[i]))
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00006003 which = raw_input('Choose by index: ')
6004 try:
6005 RunGit(['checkout', branches[int(which)]])
6006 except (IndexError, ValueError):
vapiera7fbd5a2016-06-16 09:17:49 -07006007 print('Invalid selection, not checking out any branch.')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00006008 return 1
6009
6010 return 0
6011
6012
maruel@chromium.org29404b52014-09-08 22:58:00 +00006013def CMDlol(parser, args):
6014 # This command is intentionally undocumented.
vapiera7fbd5a2016-06-16 09:17:49 -07006015 print(zlib.decompress(base64.b64decode(
thakis@chromium.org3421c992014-11-02 02:20:32 +00006016 'eNptkLEOwyAMRHe+wupCIqW57v0Vq84WqWtXyrcXnCBsmgMJ+/SSAxMZgRB6NzE'
6017 'E2ObgCKJooYdu4uAQVffUEoE1sRQLxAcqzd7uK2gmStrll1ucV3uZyaY5sXyDd9'
6018 'JAnN+lAXsOMJ90GANAi43mq5/VeeacylKVgi8o6F1SC63FxnagHfJUTfUYdCR/W'
vapiera7fbd5a2016-06-16 09:17:49 -07006019 'Ofe+0dHL7PicpytKP750Fh1q2qnLVof4w8OZWNY')))
maruel@chromium.org29404b52014-09-08 22:58:00 +00006020 return 0
6021
6022
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00006023class OptionParser(optparse.OptionParser):
6024 """Creates the option parse and add --verbose support."""
6025 def __init__(self, *args, **kwargs):
maruel@chromium.org0633fb42013-08-16 20:06:14 +00006026 optparse.OptionParser.__init__(
6027 self, *args, prog='git cl', version=__version__, **kwargs)
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00006028 self.add_option(
6029 '-v', '--verbose', action='count', default=0,
6030 help='Use 2 times for more debugging info')
6031
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00006032 def parse_args(self, args=None, _values=None):
6033 # Create an optparse.Values object that will store only the actual passed
6034 # options, without the defaults.
6035 actual_options = optparse.Values()
6036 _, args = optparse.OptionParser.parse_args(self, args, actual_options)
6037 # Create an optparse.Values object with the default options.
6038 options = optparse.Values(self.get_default_values().__dict__)
6039 # Update it with the options passed by the user.
6040 options._update_careful(actual_options.__dict__)
6041 # Store the options passed by the user in an _actual_options attribute.
6042 # We store only the keys, and not the values, since the values can contain
6043 # arbitrary information, which might be PII.
6044 metrics.collector.add('arguments', actual_options.__dict__.keys())
6045
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00006046 levels = [logging.WARNING, logging.INFO, logging.DEBUG]
Andrii Shyshkalov5b04a572017-01-23 17:44:41 +01006047 logging.basicConfig(
6048 level=levels[min(options.verbose, len(levels) - 1)],
6049 format='[%(levelname).1s%(asctime)s %(process)d %(thread)d '
6050 '%(filename)s] %(message)s')
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00006051 return options, args
6052
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00006053
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006054def main(argv):
maruel@chromium.org82798cb2012-02-23 18:16:12 +00006055 if sys.hexversion < 0x02060000:
vapiera7fbd5a2016-06-16 09:17:49 -07006056 print('\nYour python version %s is unsupported, please upgrade.\n' %
6057 (sys.version.split(' ', 1)[0],), file=sys.stderr)
maruel@chromium.org82798cb2012-02-23 18:16:12 +00006058 return 2
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00006059
maruel@chromium.orgddd59412011-11-30 14:20:38 +00006060 # Reload settings.
6061 global settings
6062 settings = Settings()
6063
Edward Lemurad463c92018-07-25 21:31:23 +00006064 if not metrics.DISABLE_METRICS_COLLECTION:
6065 metrics.collector.add('project_urls', [settings.GetViewVCUrl().strip('/+')])
maruel@chromium.org39c0b222013-08-17 16:57:01 +00006066 colorize_CMDstatus_doc()
maruel@chromium.org0633fb42013-08-16 20:06:14 +00006067 dispatcher = subcommand.CommandDispatcher(__name__)
6068 try:
6069 return dispatcher.execute(OptionParser(), argv)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +00006070 except auth.AuthenticationError as e:
6071 DieWithError(str(e))
vapierfd77ac72016-06-16 08:33:57 -07006072 except urllib2.HTTPError as e:
maruel@chromium.org0633fb42013-08-16 20:06:14 +00006073 if e.code != 500:
6074 raise
6075 DieWithError(
6076 ('AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
6077 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
sbc@chromium.org013731e2015-02-26 18:28:43 +00006078 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006079
6080
6081if __name__ == '__main__':
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00006082 # These affect sys.stdout so do it outside of main() to simplify mocks in
6083 # unit testing.
maruel@chromium.org6f09cd92011-04-01 16:38:12 +00006084 fix_encoding.fix_encoding()
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00006085 setup_color.init()
sbc@chromium.org013731e2015-02-26 18:28:43 +00006086 try:
6087 sys.exit(main(sys.argv[1:]))
6088 except KeyboardInterrupt:
6089 sys.stderr.write('interrupted\n')
6090 sys.exit(1)