blob: 52b5147d83cb1f795eeb516f7975ed4cb5fb280c [file] [log] [blame]
Edward Lesmes98eda3f2019-08-12 21:09:53 +00001#!/usr/bin/env python
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02002# Copyright (c) 2013 The Chromium Authors. All rights reserved.
maruel@chromium.org725f1c32011-04-01 20:24:54 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006# Copyright (C) 2008 Evan Martin <martine@danga.com>
7
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00008"""A git-command for integrating reviews on Gerrit."""
maruel@chromium.org725f1c32011-04-01 20:24:54 +00009
vapiera7fbd5a2016-06-16 09:17:49 -070010from __future__ import print_function
11
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +000012from distutils.version import LooseVersion
calamity@chromium.orgffde55c2015-03-12 00:44:17 +000013from multiprocessing.pool import ThreadPool
thakis@chromium.org3421c992014-11-02 02:20:32 +000014import base64
rmistry@google.com2dd99862015-06-22 12:22:18 +000015import collections
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +010016import contextlib
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010017import datetime
sheyang@google.com6ebaf782015-05-12 19:17:54 +000018import httplib
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +010019import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000020import json
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000021import logging
calamity@chromium.orgcf197482016-04-29 20:15:53 +000022import multiprocessing
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000023import optparse
24import os
25import re
Andrii Shyshkalov353637c2017-03-14 16:52:18 +010026import shutil
ukai@chromium.org78c4b982012-02-14 02:20:26 +000027import stat
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000028import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070029import tempfile
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000030import textwrap
Edward Lemurfec80c42018-11-01 23:14:14 +000031import time
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000032import urllib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000033import urllib2
maruel@chromium.org967c0a82013-06-17 22:52:24 +000034import urlparse
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000035import uuid
thestig@chromium.org00858c82013-12-02 23:08:03 +000036import webbrowser
thakis@chromium.org3421c992014-11-02 02:20:32 +000037import zlib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000038
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000039from third_party import colorama
sheyang@google.com6ebaf782015-05-12 19:17:54 +000040from third_party import httplib2
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000041import auth
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +000042import clang_format
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +000043import dart_format
maruel@chromium.org6f09cd92011-04-01 16:38:12 +000044import fix_encoding
maruel@chromium.org0e0436a2011-10-25 13:32:41 +000045import gclient_utils
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +000046import gerrit_util
iannucci@chromium.org9e849272014-04-04 00:31:55 +000047import git_common
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +000048import git_footers
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000049import metrics
Edward Lesmes93277a72018-10-18 22:04:26 +000050import metrics_utils
piman@chromium.org336f9122014-09-04 02:16:55 +000051import owners
iannucci@chromium.org9e849272014-04-04 00:31:55 +000052import owners_finder
maruel@chromium.org2a74d372011-03-29 19:05:50 +000053import presubmit_support
54import scm
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000055import setup_color
Francois Dorayd42c6812017-05-30 15:10:20 -040056import split_cl
maruel@chromium.org0633fb42013-08-16 20:06:14 +000057import subcommand
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +000058import subprocess2
maruel@chromium.org2a74d372011-03-29 19:05:50 +000059import watchlists
60
tandrii7400cf02016-06-21 08:48:07 -070061__version__ = '2.0'
maruel@chromium.org2a74d372011-03-29 19:05:50 +000062
Edward Lemur0f58ae42019-04-30 17:24:12 +000063# Traces for git push will be stored in a traces directory inside the
64# depot_tools checkout.
65DEPOT_TOOLS = os.path.dirname(os.path.abspath(__file__))
66TRACES_DIR = os.path.join(DEPOT_TOOLS, 'traces')
67
68# When collecting traces, Git hashes will be reduced to 6 characters to reduce
69# the size after compression.
70GIT_HASH_RE = re.compile(r'\b([a-f0-9]{6})[a-f0-9]{34}\b', flags=re.I)
71# Used to redact the cookies from the gitcookies file.
72GITCOOKIES_REDACT_RE = re.compile(r'1/.*')
73
Edward Lemur1b52d872019-05-09 21:12:12 +000074# The maximum number of traces we will keep. Multiplied by 3 since we store
75# 3 files per trace.
76MAX_TRACES = 3 * 10
Edward Lemur5737f022019-05-17 01:24:00 +000077# Message to be displayed to the user to inform where to find the traces for a
78# git-cl upload execution.
Edward Lemur0f58ae42019-04-30 17:24:12 +000079TRACES_MESSAGE = (
Edward Lemur1b52d872019-05-09 21:12:12 +000080'\n'
Edward Lemur5737f022019-05-17 01:24:00 +000081'The traces of this git-cl execution have been recorded at:\n'
Edward Lemur1b52d872019-05-09 21:12:12 +000082' %(trace_name)s-traces.zip\n'
Edward Lemur5737f022019-05-17 01:24:00 +000083'Copies of your gitcookies file and git config have been recorded at:\n'
84' %(trace_name)s-git-info.zip\n')
Edward Lemur1b52d872019-05-09 21:12:12 +000085# Format of the message to be stored as part of the traces to give developers a
86# better context when they go through traces.
87TRACES_README_FORMAT = (
88'Date: %(now)s\n'
89'\n'
90'Change: https://%(gerrit_host)s/q/%(change_id)s\n'
91'Title: %(title)s\n'
92'\n'
93'%(description)s\n'
94'\n'
95'Execution time: %(execution_time)s\n'
96'Exit code: %(exit_code)s\n') + TRACES_MESSAGE
Edward Lemur0f58ae42019-04-30 17:24:12 +000097
tandrii9d2c7a32016-06-22 03:42:45 -070098COMMIT_BOT_EMAIL = 'commit-bot@chromium.org'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -080099POSTUPSTREAM_HOOK = '.git/hooks/post-cl-land'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000100DESCRIPTION_BACKUP_FILE = '~/.git_cl_description_backup'
rmistry@google.comc68112d2015-03-03 12:48:06 +0000101REFS_THAT_ALIAS_TO_OTHER_REFS = {
102 'refs/remotes/origin/lkgr': 'refs/remotes/origin/master',
103 'refs/remotes/origin/lkcr': 'refs/remotes/origin/master',
104}
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000105
thestig@chromium.org44202a22014-03-11 19:22:18 +0000106# Valid extensions for files we want to lint.
107DEFAULT_LINT_REGEX = r"(.*\.cpp|.*\.cc|.*\.h)"
108DEFAULT_LINT_IGNORE_REGEX = r"$^"
109
Aiden Bennerc08566e2018-10-03 17:52:42 +0000110# File name for yapf style config files.
111YAPF_CONFIG_FILENAME = '.style.yapf'
112
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000113# Shortcut since it quickly becomes repetitive.
maruel@chromium.org2e23ce32013-05-07 12:42:28 +0000114Fore = colorama.Fore
maruel@chromium.org90541732011-04-01 17:54:18 +0000115
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000116# Initialized in main()
117settings = None
118
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100119# Used by tests/git_cl_test.py to add extra logging.
120# Inside the weirdly failing test, add this:
121# >>> self.mock(git_cl, '_IS_BEING_TESTED', True)
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700122# And scroll up to see the stack trace printed.
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100123_IS_BEING_TESTED = False
124
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000125
Christopher Lamf732cd52017-01-24 12:40:11 +1100126def DieWithError(message, change_desc=None):
127 if change_desc:
128 SaveDescriptionBackup(change_desc)
129
vapiera7fbd5a2016-06-16 09:17:49 -0700130 print(message, file=sys.stderr)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000131 sys.exit(1)
132
133
Christopher Lamf732cd52017-01-24 12:40:11 +1100134def SaveDescriptionBackup(change_desc):
135 backup_path = os.path.expanduser(DESCRIPTION_BACKUP_FILE)
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000136 print('\nsaving CL description to %s\n' % backup_path)
Christopher Lamf732cd52017-01-24 12:40:11 +1100137 backup_file = open(backup_path, 'w')
138 backup_file.write(change_desc.description)
139 backup_file.close()
140
141
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000142def GetNoGitPagerEnv():
143 env = os.environ.copy()
144 # 'cat' is a magical git string that disables pagers on all platforms.
145 env['GIT_PAGER'] = 'cat'
146 return env
147
vadimsh@chromium.org566a02a2014-08-22 01:34:13 +0000148
bsep@chromium.org627d9002016-04-29 00:00:52 +0000149def RunCommand(args, error_ok=False, error_message=None, shell=False, **kwargs):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000150 try:
bsep@chromium.org627d9002016-04-29 00:00:52 +0000151 return subprocess2.check_output(args, shell=shell, **kwargs)
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000152 except subprocess2.CalledProcessError as e:
153 logging.debug('Failed running %s', args)
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000154 if not error_ok:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000155 DieWithError(
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000156 'Command "%s" failed.\n%s' % (
157 ' '.join(args), error_message or e.stdout or ''))
158 return e.stdout
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000159
160
161def RunGit(args, **kwargs):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000162 """Returns stdout."""
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000163 return RunCommand(['git'] + args, **kwargs)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000164
165
enne@chromium.org3b7e15c2014-01-21 17:44:47 +0000166def RunGitWithCode(args, suppress_stderr=False):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000167 """Returns return code and stdout."""
tandrii5d48c322016-08-18 16:19:37 -0700168 if suppress_stderr:
169 stderr = subprocess2.VOID
170 else:
171 stderr = sys.stderr
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000172 try:
tandrii5d48c322016-08-18 16:19:37 -0700173 (out, _), code = subprocess2.communicate(['git'] + args,
174 env=GetNoGitPagerEnv(),
175 stdout=subprocess2.PIPE,
176 stderr=stderr)
177 return code, out
178 except subprocess2.CalledProcessError as e:
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +0900179 logging.debug('Failed running %s', ['git'] + args)
tandrii5d48c322016-08-18 16:19:37 -0700180 return e.returncode, e.stdout
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000181
182
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000183def RunGitSilent(args):
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000184 """Returns stdout, suppresses stderr and ignores the return code."""
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000185 return RunGitWithCode(args, suppress_stderr=True)[1]
186
187
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000188def IsGitVersionAtLeast(min_version):
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000189 prefix = 'git version '
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000190 version = RunGit(['--version']).strip()
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000191 return (version.startswith(prefix) and
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000192 LooseVersion(version[len(prefix):]) >= LooseVersion(min_version))
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000193
194
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000195def BranchExists(branch):
196 """Return True if specified branch exists."""
197 code, _ = RunGitWithCode(['rev-parse', '--verify', branch],
198 suppress_stderr=True)
199 return not code
200
201
tandrii2a16b952016-10-19 07:09:44 -0700202def time_sleep(seconds):
203 # Use this so that it can be mocked in tests without interfering with python
204 # system machinery.
tandrii2a16b952016-10-19 07:09:44 -0700205 return time.sleep(seconds)
206
207
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000208def time_time():
209 # Use this so that it can be mocked in tests without interfering with python
210 # system machinery.
211 return time.time()
212
213
Edward Lemur1b52d872019-05-09 21:12:12 +0000214def datetime_now():
215 # Use this so that it can be mocked in tests without interfering with python
216 # system machinery.
217 return datetime.datetime.now()
218
219
maruel@chromium.org90541732011-04-01 17:54:18 +0000220def ask_for_data(prompt):
221 try:
222 return raw_input(prompt)
223 except KeyboardInterrupt:
224 # Hide the exception.
225 sys.exit(1)
226
227
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100228def confirm_or_exit(prefix='', action='confirm'):
229 """Asks user to press enter to continue or press Ctrl+C to abort."""
230 if not prefix or prefix.endswith('\n'):
231 mid = 'Press'
Andrii Shyshkalov353637c2017-03-14 16:52:18 +0100232 elif prefix.endswith('.') or prefix.endswith('?'):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100233 mid = ' Press'
234 elif prefix.endswith(' '):
235 mid = 'press'
236 else:
237 mid = ' press'
238 ask_for_data('%s%s Enter to %s, or Ctrl+C to abort' % (prefix, mid, action))
239
240
241def ask_for_explicit_yes(prompt):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000242 """Returns whether user typed 'y' or 'yes' to confirm the given prompt."""
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100243 result = ask_for_data(prompt + ' [Yes/No]: ').lower()
244 while True:
245 if 'yes'.startswith(result):
246 return True
247 if 'no'.startswith(result):
248 return False
249 result = ask_for_data('Please, type yes or no: ').lower()
250
251
tandrii5d48c322016-08-18 16:19:37 -0700252def _git_branch_config_key(branch, key):
253 """Helper method to return Git config key for a branch."""
254 assert branch, 'branch name is required to set git config for it'
255 return 'branch.%s.%s' % (branch, key)
256
257
258def _git_get_branch_config_value(key, default=None, value_type=str,
259 branch=False):
260 """Returns git config value of given or current branch if any.
261
262 Returns default in all other cases.
263 """
264 assert value_type in (int, str, bool)
265 if branch is False: # Distinguishing default arg value from None.
266 branch = GetCurrentBranch()
267
rogerta@chromium.orgcaa16552013-03-18 20:45:05 +0000268 if not branch:
tandrii5d48c322016-08-18 16:19:37 -0700269 return default
rogerta@chromium.orgcaa16552013-03-18 20:45:05 +0000270
tandrii5d48c322016-08-18 16:19:37 -0700271 args = ['config']
tandrii33a46ff2016-08-23 05:53:40 -0700272 if value_type == bool:
tandrii5d48c322016-08-18 16:19:37 -0700273 args.append('--bool')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000274 # `git config` also has --int, but apparently git config suffers from integer
tandrii33a46ff2016-08-23 05:53:40 -0700275 # overflows (http://crbug.com/640115), so don't use it.
tandrii5d48c322016-08-18 16:19:37 -0700276 args.append(_git_branch_config_key(branch, key))
277 code, out = RunGitWithCode(args)
278 if code == 0:
279 value = out.strip()
280 if value_type == int:
281 return int(value)
282 if value_type == bool:
283 return bool(value.lower() == 'true')
284 return value
iannucci@chromium.org79540052012-10-19 23:15:26 +0000285 return default
286
287
tandrii5d48c322016-08-18 16:19:37 -0700288def _git_set_branch_config_value(key, value, branch=None, **kwargs):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000289 """Sets or unsets the git branch config value.
tandrii5d48c322016-08-18 16:19:37 -0700290
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000291 If value is None, the key will be unset, otherwise it will be set.
292 If no branch is given, the currently checked out branch is used.
tandrii5d48c322016-08-18 16:19:37 -0700293 """
294 if not branch:
295 branch = GetCurrentBranch()
296 assert branch, 'a branch name OR currently checked out branch is required'
297 args = ['config']
qyearsley12fa6ff2016-08-24 09:18:40 -0700298 # Check for boolean first, because bool is int, but int is not bool.
tandrii5d48c322016-08-18 16:19:37 -0700299 if value is None:
300 args.append('--unset')
301 elif isinstance(value, bool):
302 args.append('--bool')
303 value = str(value).lower()
tandrii5d48c322016-08-18 16:19:37 -0700304 else:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000305 # `git config` also has --int, but apparently git config suffers from
306 # integer overflows (http://crbug.com/640115), so don't use it.
tandrii5d48c322016-08-18 16:19:37 -0700307 value = str(value)
308 args.append(_git_branch_config_key(branch, key))
309 if value is not None:
310 args.append(value)
311 RunGit(args, **kwargs)
312
313
Andrii Shyshkalova6695812016-12-06 17:47:09 +0100314def _get_committer_timestamp(commit):
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700315 """Returns Unix timestamp as integer of a committer in a commit.
Andrii Shyshkalova6695812016-12-06 17:47:09 +0100316
317 Commit can be whatever git show would recognize, such as HEAD, sha1 or ref.
318 """
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000319 # Git also stores timezone offset, but it only affects visual display;
Andrii Shyshkalova6695812016-12-06 17:47:09 +0100320 # actual point in time is defined by this timestamp only.
321 return int(RunGit(['show', '-s', '--format=%ct', commit]).strip())
322
323
324def _git_amend_head(message, committer_timestamp):
325 """Amends commit with new message and desired committer_timestamp.
326
327 Sets committer timezone to UTC.
328 """
329 env = os.environ.copy()
330 env['GIT_COMMITTER_DATE'] = '%d+0000' % committer_timestamp
331 return RunGit(['commit', '--amend', '-m', message], env=env)
332
333
machenbach@chromium.org45453142015-09-15 08:45:22 +0000334def _get_properties_from_options(options):
335 properties = dict(x.split('=', 1) for x in options.properties)
336 for key, val in properties.iteritems():
337 try:
338 properties[key] = json.loads(val)
339 except ValueError:
340 pass # If a value couldn't be evaluated, treat it as a string.
341 return properties
342
343
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000344def _buildbucket_retry(operation_name, http, *args, **kwargs):
345 """Retries requests to buildbucket service and returns parsed json content."""
346 try_count = 0
347 while True:
348 response, content = http.request(*args, **kwargs)
349 try:
350 content_json = json.loads(content)
351 except ValueError:
352 content_json = None
353
354 # Buildbucket could return an error even if status==200.
355 if content_json and content_json.get('error'):
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000356 error = content_json.get('error')
357 if error.get('code') == 403:
358 raise BuildbucketResponseException(
359 'Access denied: %s' % error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000360 msg = 'Error in response. Reason: %s. Message: %s.' % (
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000361 error.get('reason', ''), error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000362 raise BuildbucketResponseException(msg)
363
364 if response.status == 200:
Nodir Turakulov23d75d22018-06-04 12:37:32 -0700365 if content_json is None:
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000366 raise BuildbucketResponseException(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000367 'Buildbucket returned invalid JSON content: %s.\n'
Nodir Turakulov9ac59792018-06-04 12:34:14 -0700368 'Please file bugs at http://crbug.com, '
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000369 'component "Infra>Platform>Buildbucket".' %
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000370 content)
371 return content_json
372 if response.status < 500 or try_count >= 2:
373 raise httplib2.HttpLib2Error(content)
374
375 # status >= 500 means transient failures.
376 logging.debug('Transient errors when %s. Will retry.', operation_name)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000377 time_sleep(0.5 + (1.5 * try_count))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000378 try_count += 1
379 assert False, 'unreachable'
380
381
qyearsley1fdfcb62016-10-24 13:22:03 -0700382def _get_bucket_map(changelist, options, option_parser):
qyearsleydd49f942016-10-28 11:57:22 -0700383 """Returns a dict mapping bucket names to builders and tests,
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000384 for triggering tryjobs.
qyearsley1fdfcb62016-10-24 13:22:03 -0700385 """
qyearsleydd49f942016-10-28 11:57:22 -0700386 # If no bots are listed, we try to get a set of builders and tests based
387 # on GetPreferredTryMasters functions in PRESUBMIT.py files.
qyearsley1fdfcb62016-10-24 13:22:03 -0700388 if not options.bot:
389 change = changelist.GetChange(
390 changelist.GetCommonAncestorWithUpstream(), None)
qyearsley136b49f2016-10-31 09:02:26 -0700391 # Get try masters from PRESUBMIT.py files.
nodire4f0fe02016-11-04 16:23:30 -0700392 masters = presubmit_support.DoGetTryMasters(
qyearsley1fdfcb62016-10-24 13:22:03 -0700393 change=change,
394 changed_files=change.LocalPaths(),
395 repository_root=settings.GetRoot(),
396 default_presubmit=None,
397 project=None,
398 verbose=options.verbose,
399 output_stream=sys.stdout)
nodire4f0fe02016-11-04 16:23:30 -0700400 if masters is None:
401 return None
Edward Lemurc8b67ed2019-09-12 20:28:58 +0000402 return {m: b for m, b in masters.iteritems()}
qyearsley1fdfcb62016-10-24 13:22:03 -0700403
qyearsley1fdfcb62016-10-24 13:22:03 -0700404 if options.bucket:
405 return {options.bucket: {b: [] for b in options.bot}}
Andrii Shyshkalov75424372019-08-30 22:48:15 +0000406 option_parser.error(
407 'Please specify the bucket, e.g. "-B luci.chromium.try".')
qyearsley1fdfcb62016-10-24 13:22:03 -0700408
409
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -0800410def _trigger_try_jobs(auth_config, changelist, buckets, options, patchset):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000411 """Sends a request to Buildbucket to trigger tryjobs for a changelist.
qyearsley1fdfcb62016-10-24 13:22:03 -0700412
413 Args:
Aaron Gablefb28d482018-04-02 13:08:06 -0700414 auth_config: AuthConfig for Buildbucket.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000415 changelist: Changelist that the tryjobs are associated with.
qyearsley1fdfcb62016-10-24 13:22:03 -0700416 buckets: A nested dict mapping bucket names to builders to tests.
417 options: Command-line options.
418 """
Edward Lemur5b6ae8b2019-09-12 23:27:24 +0000419 _, ret_code = subprocess2.communicate(
420 ['bb', 'auth-info'], stdout=subprocess2.VOID, stderr=subprocess2.VOID)
421 if ret_code:
422 DieWithError('"bb auth-login" must be executed before scheduling try jobs.')
tandriide281ae2016-10-12 06:02:30 -0700423
Edward Lemur5b6ae8b2019-09-12 23:27:24 +0000424 gerrit_change = changelist.GetGerritChange()
425 shared_properties = {
426 'category': options.category,
427 }
tandrii8c5a3532016-11-04 07:52:02 -0700428 if options.clobber:
Edward Lemur5b6ae8b2019-09-12 23:27:24 +0000429 shared_properties['clobber'] = True
tandriide281ae2016-10-12 06:02:30 -0700430 extra_properties = _get_properties_from_options(options)
tandrii8c5a3532016-11-04 07:52:02 -0700431 if extra_properties:
Edward Lemur5b6ae8b2019-09-12 23:27:24 +0000432 shared_properties.update(extra_properties)
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000433
Edward Lemur5b6ae8b2019-09-12 23:27:24 +0000434 batch_request = {'requests': []}
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000435 print_text = []
436 print_text.append('Tried jobs on:')
borenet6c0efe62016-10-19 08:13:29 -0700437 for bucket, builders_and_tests in sorted(buckets.iteritems()):
438 print_text.append('Bucket: %s' % bucket)
Edward Lemur5b6ae8b2019-09-12 23:27:24 +0000439 project, bucket = bucket.split('.', 1)
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000440 for builder, tests in sorted(builders_and_tests.iteritems()):
441 print_text.append(' %s: %s' % (builder, tests))
Edward Lemur5b6ae8b2019-09-12 23:27:24 +0000442 properties = shared_properties.copy()
machenbach@chromium.org2403e802016-04-29 12:34:42 +0000443 if 'presubmit' in builder.lower():
Edward Lemur5b6ae8b2019-09-12 23:27:24 +0000444 properties['dry_run'] = 'true'
tandrii@chromium.org3764fa22015-10-21 16:40:40 +0000445 if tests:
Edward Lemur5b6ae8b2019-09-12 23:27:24 +0000446 properties['testfilter'] = tests
borenet6c0efe62016-10-19 08:13:29 -0700447
448 tags = [
Edward Lemur5b6ae8b2019-09-12 23:27:24 +0000449 {
450 'key': 'builder',
451 'value': builder,
452 },
453 {
454 'key': 'user_agent',
455 'value': 'git_cl_try',
456 },
borenet6c0efe62016-10-19 08:13:29 -0700457 ]
borenet6c0efe62016-10-19 08:13:29 -0700458
Edward Lemur5b6ae8b2019-09-12 23:27:24 +0000459 batch_request['requests'].append(
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000460 {
Edward Lemur5b6ae8b2019-09-12 23:27:24 +0000461 'scheduleBuild': {
462 'builder': {
463 'project': options.project or project,
464 'bucket': bucket,
465 'builder': builder,
466 },
467 'properties': properties,
468 'requestId': str(uuid.uuid4()),
469 'gerritChanges': [gerrit_change],
470 'tags': tags,
471 }
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000472 }
473 )
474
Edward Lemur5b6ae8b2019-09-12 23:27:24 +0000475 (stdout, _), ret_code = subprocess2.communicate(
476 ['bb', 'batch', '-host', options.buildbucket_host],
477 stdin=json.dumps(batch_request, sort_keys=True),
478 stdout=subprocess2.PIPE)
479 if ret_code:
480 print_text.append('Failed to schedule builds for some bots:')
481 if stdout:
482 responses = json.loads(stdout)
483 print_text.extend(
484 ' ' + response['error']['message']
485 for response in responses['responses'] if 'error' in response)
486
tandrii@chromium.org35c61452016-02-26 15:24:57 +0000487 print_text.append('To see results here, run: git cl try-results')
488 print_text.append('To see results in browser, run: git cl web')
vapiera7fbd5a2016-06-16 09:17:49 -0700489 print('\n'.join(print_text))
kjellander@chromium.org44424542015-06-02 18:35:29 +0000490
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000491
tandrii221ab252016-10-06 08:12:04 -0700492def fetch_try_jobs(auth_config, changelist, buildbucket_host,
493 patchset=None):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000494 """Fetches tryjobs from buildbucket.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000495
qyearsley53f48a12016-09-01 10:45:13 -0700496 Returns a map from build id to build info as a dictionary.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000497 """
tandrii221ab252016-10-06 08:12:04 -0700498 assert buildbucket_host
499 assert changelist.GetIssue(), 'CL must be uploaded first'
500 assert changelist.GetCodereviewServer(), 'CL must be uploaded first'
501 patchset = patchset or changelist.GetMostRecentPatchset()
502 assert patchset, 'CL must be uploaded first'
503
504 codereview_url = changelist.GetCodereviewServer()
505 codereview_host = urlparse.urlparse(codereview_url).hostname
506 authenticator = auth.get_authenticator_for_host(codereview_host, auth_config)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000507 if authenticator.has_cached_credentials():
508 http = authenticator.authorize(httplib2.Http())
509 else:
vapiera7fbd5a2016-06-16 09:17:49 -0700510 print('Warning: Some results might be missing because %s' %
511 # Get the message on how to login.
tandrii221ab252016-10-06 08:12:04 -0700512 (auth.LoginRequiredError(codereview_host).message,))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000513 http = httplib2.Http()
514
515 http.force_exception_to_status_code = True
516
Andrii Shyshkalov03da1502018-10-15 03:42:34 +0000517 buildset = 'patch/gerrit/{hostname}/{issue}/{patch}'.format(
tandrii221ab252016-10-06 08:12:04 -0700518 hostname=codereview_host,
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000519 issue=changelist.GetIssue(),
tandrii221ab252016-10-06 08:12:04 -0700520 patch=patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000521 params = {'tag': 'buildset:%s' % buildset}
522
523 builds = {}
524 while True:
525 url = 'https://{hostname}/_ah/api/buildbucket/v1/search?{params}'.format(
tandrii221ab252016-10-06 08:12:04 -0700526 hostname=buildbucket_host,
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000527 params=urllib.urlencode(params))
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000528 content = _buildbucket_retry('fetching tryjobs', http, url, 'GET')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000529 for build in content.get('builds', []):
530 builds[build['id']] = build
531 if 'next_cursor' in content:
532 params['start_cursor'] = content['next_cursor']
533 else:
534 break
535 return builds
536
537
qyearsleyeab3c042016-08-24 09:18:28 -0700538def print_try_jobs(options, builds):
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000539 """Prints nicely result of fetch_try_jobs."""
540 if not builds:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000541 print('No tryjobs scheduled.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000542 return
543
544 # Make a copy, because we'll be modifying builds dictionary.
545 builds = builds.copy()
546 builder_names_cache = {}
547
548 def get_builder(b):
549 try:
550 return builder_names_cache[b['id']]
551 except KeyError:
552 try:
553 parameters = json.loads(b['parameters_json'])
554 name = parameters['builder_name']
555 except (ValueError, KeyError) as error:
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700556 print('WARNING: Failed to get builder name for build %s: %s' % (
vapiera7fbd5a2016-06-16 09:17:49 -0700557 b['id'], error))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000558 name = None
559 builder_names_cache[b['id']] = name
560 return name
561
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000562 if options.print_master:
563 name_fmt = '%%-%ds %%-%ds' % (
Edward Lemurc8b67ed2019-09-12 20:28:58 +0000564 max(len(str(b['bucket'])) for b in builds.itervalues()),
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000565 max(len(str(get_builder(b))) for b in builds.itervalues()))
566 def get_name(b):
Edward Lemurc8b67ed2019-09-12 20:28:58 +0000567 return name_fmt % (b['bucket'], get_builder(b))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000568 else:
569 name_fmt = '%%-%ds' % (
570 max(len(str(get_builder(b))) for b in builds.itervalues()))
571 def get_name(b):
572 return name_fmt % get_builder(b)
573
574 def sort_key(b):
575 return b['status'], b.get('result'), get_name(b), b.get('url')
576
577 def pop(title, f, color=None, **kwargs):
578 """Pop matching builds from `builds` dict and print them."""
579
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +0000580 if not options.color or color is None:
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000581 colorize = str
582 else:
583 colorize = lambda x: '%s%s%s' % (color, x, Fore.RESET)
584
585 result = []
586 for b in builds.values():
587 if all(b.get(k) == v for k, v in kwargs.iteritems()):
588 builds.pop(b['id'])
589 result.append(b)
590 if result:
vapiera7fbd5a2016-06-16 09:17:49 -0700591 print(colorize(title))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000592 for b in sorted(result, key=sort_key):
vapiera7fbd5a2016-06-16 09:17:49 -0700593 print(' ', colorize('\t'.join(map(str, f(b)))))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000594
595 total = len(builds)
596 pop(status='COMPLETED', result='SUCCESS',
597 title='Successes:', color=Fore.GREEN,
598 f=lambda b: (get_name(b), b.get('url')))
599 pop(status='COMPLETED', result='FAILURE', failure_reason='INFRA_FAILURE',
600 title='Infra Failures:', color=Fore.MAGENTA,
601 f=lambda b: (get_name(b), b.get('url')))
602 pop(status='COMPLETED', result='FAILURE', failure_reason='BUILD_FAILURE',
603 title='Failures:', color=Fore.RED,
604 f=lambda b: (get_name(b), b.get('url')))
605 pop(status='COMPLETED', result='CANCELED',
606 title='Canceled:', color=Fore.MAGENTA,
607 f=lambda b: (get_name(b),))
608 pop(status='COMPLETED', result='FAILURE',
609 failure_reason='INVALID_BUILD_DEFINITION',
610 title='Wrong master/builder name:', color=Fore.MAGENTA,
611 f=lambda b: (get_name(b),))
612 pop(status='COMPLETED', result='FAILURE',
613 title='Other failures:',
614 f=lambda b: (get_name(b), b.get('failure_reason'), b.get('url')))
615 pop(status='COMPLETED',
616 title='Other finished:',
617 f=lambda b: (get_name(b), b.get('result'), b.get('url')))
618 pop(status='STARTED',
619 title='Started:', color=Fore.YELLOW,
620 f=lambda b: (get_name(b), b.get('url')))
621 pop(status='SCHEDULED',
622 title='Scheduled:',
623 f=lambda b: (get_name(b), 'id=%s' % b['id']))
624 # The last section is just in case buildbucket API changes OR there is a bug.
625 pop(title='Other:',
626 f=lambda b: (get_name(b), 'id=%s' % b['id']))
627 assert len(builds) == 0
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000628 print('Total: %d tryjobs' % total)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000629
630
Aiden Bennerc08566e2018-10-03 17:52:42 +0000631def _ComputeDiffLineRanges(files, upstream_commit):
632 """Gets the changed line ranges for each file since upstream_commit.
633
634 Parses a git diff on provided files and returns a dict that maps a file name
635 to an ordered list of range tuples in the form (start_line, count).
636 Ranges are in the same format as a git diff.
637 """
638 # If files is empty then diff_output will be a full diff.
639 if len(files) == 0:
640 return {}
641
Aiden Benner6c18a1a2018-11-23 20:18:23 +0000642 # Take the git diff and find the line ranges where there are changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000643 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, files, allow_prefix=True)
644 diff_output = RunGit(diff_cmd)
645
646 pattern = r'(?:^diff --git a/(?:.*) b/(.*))|(?:^@@.*\+(.*) @@)'
647 # 2 capture groups
648 # 0 == fname of diff file
649 # 1 == 'diff_start,diff_count' or 'diff_start'
650 # will match each of
651 # diff --git a/foo.foo b/foo.py
652 # @@ -12,2 +14,3 @@
653 # @@ -12,2 +17 @@
654 # running re.findall on the above string with pattern will give
655 # [('foo.py', ''), ('', '14,3'), ('', '17')]
656
657 curr_file = None
658 line_diffs = {}
659 for match in re.findall(pattern, diff_output, flags=re.MULTILINE):
660 if match[0] != '':
661 # Will match the second filename in diff --git a/a.py b/b.py.
662 curr_file = match[0]
663 line_diffs[curr_file] = []
664 else:
665 # Matches +14,3
666 if ',' in match[1]:
667 diff_start, diff_count = match[1].split(',')
668 else:
669 # Single line changes are of the form +12 instead of +12,1.
670 diff_start = match[1]
671 diff_count = 1
672
673 diff_start = int(diff_start)
674 diff_count = int(diff_count)
675
676 # If diff_count == 0 this is a removal we can ignore.
677 line_diffs[curr_file].append((diff_start, diff_count))
678
679 return line_diffs
680
681
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000682def _FindYapfConfigFile(fpath, yapf_config_cache, top_dir=None):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000683 """Checks if a yapf file is in any parent directory of fpath until top_dir.
684
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000685 Recursively checks parent directories to find yapf file and if no yapf file
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000686 is found returns None. Uses yapf_config_cache as a cache for previously found
687 configs.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000688 """
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000689 fpath = os.path.abspath(fpath)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000690 # Return result if we've already computed it.
691 if fpath in yapf_config_cache:
692 return yapf_config_cache[fpath]
693
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000694 parent_dir = os.path.dirname(fpath)
695 if os.path.isfile(fpath):
696 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000697 else:
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000698 # Otherwise fpath is a directory
699 yapf_file = os.path.join(fpath, YAPF_CONFIG_FILENAME)
700 if os.path.isfile(yapf_file):
701 ret = yapf_file
702 elif fpath == top_dir or parent_dir == fpath:
703 # If we're at the top level directory, or if we're at root
704 # there is no provided style.
705 ret = None
706 else:
707 # Otherwise recurse on the current directory.
708 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000709 yapf_config_cache[fpath] = ret
710 return ret
711
712
qyearsley53f48a12016-09-01 10:45:13 -0700713def write_try_results_json(output_file, builds):
714 """Writes a subset of the data from fetch_try_jobs to a file as JSON.
715
716 The input |builds| dict is assumed to be generated by Buildbucket.
717 Buildbucket documentation: http://goo.gl/G0s101
718 """
719
720 def convert_build_dict(build):
Quinten Yearsleya563d722017-12-11 16:36:54 -0800721 """Extracts some of the information from one build dict."""
722 parameters = json.loads(build.get('parameters_json', '{}')) or {}
qyearsley53f48a12016-09-01 10:45:13 -0700723 return {
724 'buildbucket_id': build.get('id'),
qyearsley53f48a12016-09-01 10:45:13 -0700725 'bucket': build.get('bucket'),
Quinten Yearsleya563d722017-12-11 16:36:54 -0800726 'builder_name': parameters.get('builder_name'),
727 'created_ts': build.get('created_ts'),
728 'experimental': build.get('experimental'),
qyearsley53f48a12016-09-01 10:45:13 -0700729 'failure_reason': build.get('failure_reason'),
Quinten Yearsleya563d722017-12-11 16:36:54 -0800730 'result': build.get('result'),
731 'status': build.get('status'),
732 'tags': build.get('tags'),
qyearsley53f48a12016-09-01 10:45:13 -0700733 'url': build.get('url'),
734 }
735
736 converted = []
737 for _, build in sorted(builds.items()):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000738 converted.append(convert_build_dict(build))
qyearsley53f48a12016-09-01 10:45:13 -0700739 write_json(output_file, converted)
740
741
Aaron Gable13101a62018-02-09 13:20:41 -0800742def print_stats(args):
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000743 """Prints statistics about the change to the user."""
744 # --no-ext-diff is broken in some versions of Git, so try to work around
745 # this by overriding the environment (but there is still a problem if the
746 # git config key "diff.external" is used).
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000747 env = GetNoGitPagerEnv()
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000748 if 'GIT_EXTERNAL_DIFF' in env:
749 del env['GIT_EXTERNAL_DIFF']
iannucci@chromium.org79540052012-10-19 23:15:26 +0000750
szager@chromium.orgd057f9a2014-05-29 21:09:36 +0000751 try:
752 stdout = sys.stdout.fileno()
753 except AttributeError:
754 stdout = None
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000755 return subprocess2.call(
Aaron Gable13101a62018-02-09 13:20:41 -0800756 ['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] + args,
szager@chromium.orgd057f9a2014-05-29 21:09:36 +0000757 stdout=stdout, env=env)
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000758
759
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000760class BuildbucketResponseException(Exception):
761 pass
762
763
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000764class Settings(object):
765 def __init__(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000766 self.cc = None
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000767 self.root = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000768 self.tree_status_url = None
769 self.viewvc_url = None
770 self.updated = False
ukai@chromium.orge8077812012-02-03 03:41:46 +0000771 self.is_gerrit = None
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000772 self.squash_gerrit_uploads = None
tandrii@chromium.org28253532016-04-14 13:46:56 +0000773 self.gerrit_skip_ensure_authenticated = None
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000774 self.git_editor = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000775
776 def LazyUpdateIfNeeded(self):
777 """Updates the settings from a codereview.settings file, if available."""
778 if not self.updated:
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000779 # The only value that actually changes the behavior is
780 # autoupdate = "false". Everything else means "true".
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +0000781 autoupdate = RunGit(['config', 'rietveld.autoupdate'],
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000782 error_ok=True
783 ).strip().lower()
784
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000785 cr_settings_file = FindCodereviewSettingsFile()
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000786 if autoupdate != 'false' and cr_settings_file:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000787 LoadCodereviewSettingsFromFile(cr_settings_file)
788 self.updated = True
789
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000790 @staticmethod
791 def GetRelativeRoot():
792 return RunGit(['rev-parse', '--show-cdup']).strip()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000793
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000794 def GetRoot(self):
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000795 if self.root is None:
796 self.root = os.path.abspath(self.GetRelativeRoot())
797 return self.root
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000798
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000799 def GetTreeStatusUrl(self, error_ok=False):
800 if not self.tree_status_url:
801 error_message = ('You must configure your tree status URL by running '
802 '"git cl config".')
Edward Lemur61ea3072018-12-01 00:34:36 +0000803 self.tree_status_url = self._GetConfig(
804 'rietveld.tree-status-url', error_ok=error_ok,
805 error_message=error_message)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000806 return self.tree_status_url
807
808 def GetViewVCUrl(self):
809 if not self.viewvc_url:
Edward Lemur61ea3072018-12-01 00:34:36 +0000810 self.viewvc_url = self._GetConfig('rietveld.viewvc-url', error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000811 return self.viewvc_url
812
rmistry@google.com90752582014-01-14 21:04:50 +0000813 def GetBugPrefix(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000814 return self._GetConfig('rietveld.bug-prefix', error_ok=True)
rmistry@google.com78948ed2015-07-08 23:09:57 +0000815
rmistry@google.com5626a922015-02-26 14:03:30 +0000816 def GetRunPostUploadHook(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000817 run_post_upload_hook = self._GetConfig(
818 'rietveld.run-post-upload-hook', error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +0000819 return run_post_upload_hook == "True"
820
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000821 def GetDefaultCCList(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000822 return self._GetConfig('rietveld.cc', error_ok=True)
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000823
ukai@chromium.orge8077812012-02-03 03:41:46 +0000824 def GetIsGerrit(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000825 """Returns True if this repo is associated with Gerrit."""
ukai@chromium.orge8077812012-02-03 03:41:46 +0000826 if self.is_gerrit is None:
Aaron Gable9b465272017-05-12 10:53:51 -0700827 self.is_gerrit = (
828 self._GetConfig('gerrit.host', error_ok=True).lower() == 'true')
ukai@chromium.orge8077812012-02-03 03:41:46 +0000829 return self.is_gerrit
830
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000831 def GetSquashGerritUploads(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000832 """Returns True if uploads to Gerrit should be squashed by default."""
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000833 if self.squash_gerrit_uploads is None:
tandriia60502f2016-06-20 02:01:53 -0700834 self.squash_gerrit_uploads = self.GetSquashGerritUploadsOverride()
835 if self.squash_gerrit_uploads is None:
836 # Default is squash now (http://crbug.com/611892#c23).
837 self.squash_gerrit_uploads = not (
838 RunGit(['config', '--bool', 'gerrit.squash-uploads'],
839 error_ok=True).strip() == 'false')
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000840 return self.squash_gerrit_uploads
841
tandriia60502f2016-06-20 02:01:53 -0700842 def GetSquashGerritUploadsOverride(self):
843 """Return True or False if codereview.settings should be overridden.
844
845 Returns None if no override has been defined.
846 """
847 # See also http://crbug.com/611892#c23
848 result = RunGit(['config', '--bool', 'gerrit.override-squash-uploads'],
849 error_ok=True).strip()
850 if result == 'true':
851 return True
852 if result == 'false':
853 return False
854 return None
855
tandrii@chromium.org28253532016-04-14 13:46:56 +0000856 def GetGerritSkipEnsureAuthenticated(self):
857 """Return True if EnsureAuthenticated should not be done for Gerrit
858 uploads."""
859 if self.gerrit_skip_ensure_authenticated is None:
860 self.gerrit_skip_ensure_authenticated = (
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000861 RunGit(['config', '--bool', 'gerrit.skip-ensure-authenticated'],
tandrii@chromium.org28253532016-04-14 13:46:56 +0000862 error_ok=True).strip() == 'true')
863 return self.gerrit_skip_ensure_authenticated
864
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000865 def GetGitEditor(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000866 """Returns the editor specified in the git config, or None if none is."""
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000867 if self.git_editor is None:
Raul Tambre5a525872019-02-12 19:08:08 +0000868 # Git requires single quotes for paths with spaces. We need to replace
869 # them with double quotes for Windows to treat such paths as a single
870 # path.
871 self.git_editor = self._GetConfig(
872 'core.editor', error_ok=True).replace('\'', '"')
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000873 return self.git_editor or None
874
thestig@chromium.org44202a22014-03-11 19:22:18 +0000875 def GetLintRegex(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000876 return (self._GetConfig('rietveld.cpplint-regex', error_ok=True) or
thestig@chromium.org44202a22014-03-11 19:22:18 +0000877 DEFAULT_LINT_REGEX)
878
879 def GetLintIgnoreRegex(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000880 return (self._GetConfig('rietveld.cpplint-ignore-regex', error_ok=True) or
thestig@chromium.org44202a22014-03-11 19:22:18 +0000881 DEFAULT_LINT_IGNORE_REGEX)
882
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000883 def _GetConfig(self, param, **kwargs):
884 self.LazyUpdateIfNeeded()
885 return RunGit(['config', param], **kwargs).strip()
886
887
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100888@contextlib.contextmanager
889def _get_gerrit_project_config_file(remote_url):
890 """Context manager to fetch and store Gerrit's project.config from
891 refs/meta/config branch and store it in temp file.
892
893 Provides a temporary filename or None if there was error.
894 """
895 error, _ = RunGitWithCode([
896 'fetch', remote_url,
897 '+refs/meta/config:refs/git_cl/meta/config'])
898 if error:
899 # Ref doesn't exist or isn't accessible to current user.
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700900 print('WARNING: Failed to fetch project config for %s: %s' %
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100901 (remote_url, error))
902 yield None
903 return
904
905 error, project_config_data = RunGitWithCode(
906 ['show', 'refs/git_cl/meta/config:project.config'])
907 if error:
908 print('WARNING: project.config file not found')
909 yield None
910 return
911
912 with gclient_utils.temporary_directory() as tempdir:
913 project_config_file = os.path.join(tempdir, 'project.config')
914 gclient_utils.FileWrite(project_config_file, project_config_data)
915 yield project_config_file
916
917
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000918def ShortBranchName(branch):
919 """Convert a name like 'refs/heads/foo' to just 'foo'."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000920 return branch.replace('refs/heads/', '', 1)
921
922
923def GetCurrentBranchRef():
924 """Returns branch ref (e.g., refs/heads/master) or None."""
925 return RunGit(['symbolic-ref', 'HEAD'],
926 stderr=subprocess2.VOID, error_ok=True).strip() or None
927
928
929def GetCurrentBranch():
930 """Returns current branch or None.
931
932 For refs/heads/* branches, returns just last part. For others, full ref.
933 """
934 branchref = GetCurrentBranchRef()
935 if branchref:
936 return ShortBranchName(branchref)
937 return None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000938
939
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000940class _CQState(object):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +0000941 """Enum for states of CL with respect to CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000942 NONE = 'none'
943 DRY_RUN = 'dry_run'
944 COMMIT = 'commit'
945
946 ALL_STATES = [NONE, DRY_RUN, COMMIT]
947
948
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000949class _ParsedIssueNumberArgument(object):
Edward Lemurf38bc172019-09-03 21:02:13 +0000950 def __init__(self, issue=None, patchset=None, hostname=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000951 self.issue = issue
952 self.patchset = patchset
953 self.hostname = hostname
954
955 @property
956 def valid(self):
957 return self.issue is not None
958
959
Edward Lemurf38bc172019-09-03 21:02:13 +0000960def ParseIssueNumberArgument(arg):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000961 """Parses the issue argument and returns _ParsedIssueNumberArgument."""
962 fail_result = _ParsedIssueNumberArgument()
963
964 if arg.isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +0000965 return _ParsedIssueNumberArgument(issue=int(arg))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000966 if not arg.startswith('http'):
967 return fail_result
Aaron Gableaee6c852017-06-26 12:49:01 -0700968
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000969 url = gclient_utils.UpgradeToHttps(arg)
970 try:
971 parsed_url = urlparse.urlparse(url)
972 except ValueError:
973 return fail_result
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +0200974
Andrii Shyshkalov0a264d82018-11-21 00:36:16 +0000975 return _GerritChangelistImpl.ParseIssueURL(parsed_url) or fail_result
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000976
977
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +0000978def _create_description_from_log(args):
979 """Pulls out the commit log to use as a base for the CL description."""
980 log_args = []
981 if len(args) == 1 and not args[0].endswith('.'):
982 log_args = [args[0] + '..']
983 elif len(args) == 1 and args[0].endswith('...'):
984 log_args = [args[0][:-1]]
985 elif len(args) == 2:
986 log_args = [args[0] + '..' + args[1]]
987 else:
988 log_args = args[:] # Hope for the best!
989 return RunGit(['log', '--pretty=format:%s\n\n%b'] + log_args)
990
991
Aaron Gablea45ee112016-11-22 15:14:38 -0800992class GerritChangeNotExists(Exception):
tandriic2405f52016-10-10 08:13:15 -0700993 def __init__(self, issue, url):
994 self.issue = issue
995 self.url = url
Aaron Gablea45ee112016-11-22 15:14:38 -0800996 super(GerritChangeNotExists, self).__init__()
tandriic2405f52016-10-10 08:13:15 -0700997
998 def __str__(self):
Aaron Gablea45ee112016-11-22 15:14:38 -0800999 return 'change %s at %s does not exist or you have no access to it' % (
tandriic2405f52016-10-10 08:13:15 -07001000 self.issue, self.url)
1001
1002
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001003_CommentSummary = collections.namedtuple(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001004 '_CommentSummary', ['date', 'message', 'sender', 'autogenerated',
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001005 # TODO(tandrii): these two aren't known in Gerrit.
1006 'approval', 'disapproval'])
1007
1008
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001009class Changelist(object):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001010 """Changelist works with one changelist in local branch.
1011
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00001012 Notes:
1013 * Not safe for concurrent multi-{thread,process} use.
1014 * Caches values from current branch. Therefore, re-use after branch change
tandrii5d48c322016-08-18 16:19:37 -07001015 with great care.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001016 """
1017
Edward Lemurf38bc172019-09-03 21:02:13 +00001018 def __init__(self, branchref=None, issue=None, **kwargs):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001019 """Create a new ChangeList instance.
1020
Edward Lemurf38bc172019-09-03 21:02:13 +00001021 **kwargs will be passed directly to Gerrit implementation.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001022 """
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001023 # Poke settings so we get the "configure your server" message if necessary.
maruel@chromium.org379d07a2011-11-30 14:58:10 +00001024 global settings
1025 if not settings:
1026 # Happens when git_cl.py is used as a utility library.
1027 settings = Settings()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001028
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001029 self.branchref = branchref
1030 if self.branchref:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00001031 assert branchref.startswith('refs/heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001032 self.branch = ShortBranchName(self.branchref)
1033 else:
1034 self.branch = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001035 self.upstream_branch = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001036 self.lookedup_issue = False
1037 self.issue = issue or None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001038 self.has_description = False
1039 self.description = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001040 self.lookedup_patchset = False
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001041 self.patchset = None
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001042 self.cc = None
Daniel Cheng7227d212017-11-17 08:12:37 -08001043 self.more_cc = []
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001044 self._remote = None
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001045 self._cached_remote_url = (False, None) # (is_cached, value)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001046
Edward Lemurf38bc172019-09-03 21:02:13 +00001047 self._codereview_impl = _GerritChangelistImpl(self, **kwargs)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001048
1049 def GetCCList(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001050 """Returns the users cc'd on this CL.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001051
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001052 The return value is a string suitable for passing to git cl with the --cc
1053 flag.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001054 """
1055 if self.cc is None:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001056 base_cc = settings.GetDefaultCCList()
Daniel Cheng7227d212017-11-17 08:12:37 -08001057 more_cc = ','.join(self.more_cc)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001058 self.cc = ','.join(filter(None, (base_cc, more_cc))) or ''
1059 return self.cc
1060
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001061 def GetCCListWithoutDefault(self):
1062 """Return the users cc'd on this CL excluding default ones."""
1063 if self.cc is None:
Daniel Cheng7227d212017-11-17 08:12:37 -08001064 self.cc = ','.join(self.more_cc)
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001065 return self.cc
1066
Daniel Cheng7227d212017-11-17 08:12:37 -08001067 def ExtendCC(self, more_cc):
1068 """Extends the list of users to cc on this CL based on the changed files."""
1069 self.more_cc.extend(more_cc)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001070
1071 def GetBranch(self):
1072 """Returns the short branch name, e.g. 'master'."""
1073 if not self.branch:
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001074 branchref = GetCurrentBranchRef()
szager@chromium.orgd62c61f2014-10-20 22:33:21 +00001075 if not branchref:
1076 return None
1077 self.branchref = branchref
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001078 self.branch = ShortBranchName(self.branchref)
1079 return self.branch
1080
1081 def GetBranchRef(self):
1082 """Returns the full branch name, e.g. 'refs/heads/master'."""
1083 self.GetBranch() # Poke the lazy loader.
1084 return self.branchref
1085
tandrii@chromium.org534f67a2016-04-07 18:47:05 +00001086 def ClearBranch(self):
1087 """Clears cached branch data of this object."""
1088 self.branch = self.branchref = None
1089
tandrii5d48c322016-08-18 16:19:37 -07001090 def _GitGetBranchConfigValue(self, key, default=None, **kwargs):
1091 assert 'branch' not in kwargs, 'this CL branch is used automatically'
1092 kwargs['branch'] = self.GetBranch()
1093 return _git_get_branch_config_value(key, default, **kwargs)
1094
1095 def _GitSetBranchConfigValue(self, key, value, **kwargs):
1096 assert 'branch' not in kwargs, 'this CL branch is used automatically'
1097 assert self.GetBranch(), (
1098 'this CL must have an associated branch to %sset %s%s' %
1099 ('un' if value is None else '',
1100 key,
1101 '' if value is None else ' to %r' % value))
1102 kwargs['branch'] = self.GetBranch()
1103 return _git_set_branch_config_value(key, value, **kwargs)
1104
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001105 @staticmethod
1106 def FetchUpstreamTuple(branch):
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001107 """Returns a tuple containing remote and remote ref,
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001108 e.g. 'origin', 'refs/heads/master'
1109 """
1110 remote = '.'
tandrii5d48c322016-08-18 16:19:37 -07001111 upstream_branch = _git_get_branch_config_value('merge', branch=branch)
1112
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001113 if upstream_branch:
tandrii5d48c322016-08-18 16:19:37 -07001114 remote = _git_get_branch_config_value('remote', branch=branch)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001115 else:
bauerb@chromium.orgade368c2011-03-01 08:57:50 +00001116 upstream_branch = RunGit(['config', 'rietveld.upstream-branch'],
1117 error_ok=True).strip()
1118 if upstream_branch:
1119 remote = RunGit(['config', 'rietveld.upstream-remote']).strip()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001120 else:
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001121 # Else, try to guess the origin remote.
1122 remote_branches = RunGit(['branch', '-r']).split()
1123 if 'origin/master' in remote_branches:
1124 # Fall back on origin/master if it exits.
1125 remote = 'origin'
1126 upstream_branch = 'refs/heads/master'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001127 else:
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001128 DieWithError(
1129 'Unable to determine default branch to diff against.\n'
1130 'Either pass complete "git diff"-style arguments, like\n'
1131 ' git cl upload origin/master\n'
1132 'or verify this branch is set up to track another \n'
1133 '(via the --track argument to "git checkout -b ...").')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001134
1135 return remote, upstream_branch
1136
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001137 def GetCommonAncestorWithUpstream(self):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001138 upstream_branch = self.GetUpstreamBranch()
1139 if not BranchExists(upstream_branch):
1140 DieWithError('The upstream for the current branch (%s) does not exist '
1141 'anymore.\nPlease fix it and try again.' % self.GetBranch())
iannucci@chromium.org9e849272014-04-04 00:31:55 +00001142 return git_common.get_or_create_merge_base(self.GetBranch(),
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001143 upstream_branch)
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001144
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001145 def GetUpstreamBranch(self):
1146 if self.upstream_branch is None:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001147 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Raul Tambrefe1dbe12019-05-02 04:43:57 +00001148 if remote != '.':
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001149 upstream_branch = upstream_branch.replace('refs/heads/',
1150 'refs/remotes/%s/' % remote)
1151 upstream_branch = upstream_branch.replace('refs/branch-heads/',
1152 'refs/remotes/branch-heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001153 self.upstream_branch = upstream_branch
1154 return self.upstream_branch
1155
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001156 def GetRemoteBranch(self):
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001157 if not self._remote:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001158 remote, branch = None, self.GetBranch()
1159 seen_branches = set()
1160 while branch not in seen_branches:
1161 seen_branches.add(branch)
1162 remote, branch = self.FetchUpstreamTuple(branch)
1163 branch = ShortBranchName(branch)
1164 if remote != '.' or branch.startswith('refs/remotes'):
1165 break
1166 else:
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001167 remotes = RunGit(['remote'], error_ok=True).split()
1168 if len(remotes) == 1:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001169 remote, = remotes
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001170 elif 'origin' in remotes:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001171 remote = 'origin'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001172 logging.warn('Could not determine which remote this change is '
1173 'associated with, so defaulting to "%s".' % self._remote)
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001174 else:
1175 logging.warn('Could not determine which remote this change is '
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001176 'associated with.')
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001177 branch = 'HEAD'
1178 if branch.startswith('refs/remotes'):
1179 self._remote = (remote, branch)
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001180 elif branch.startswith('refs/branch-heads/'):
1181 self._remote = (remote, branch.replace('refs/', 'refs/remotes/'))
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001182 else:
1183 self._remote = (remote, 'refs/remotes/%s/%s' % (remote, branch))
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001184 return self._remote
1185
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001186 def GitSanityChecks(self, upstream_git_obj):
1187 """Checks git repo status and ensures diff is from local commits."""
1188
sbc@chromium.org79706062015-01-14 21:18:12 +00001189 if upstream_git_obj is None:
1190 if self.GetBranch() is None:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001191 print('ERROR: Unable to determine current branch (detached HEAD?)',
vapiera7fbd5a2016-06-16 09:17:49 -07001192 file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001193 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001194 print('ERROR: No upstream branch.', file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001195 return False
1196
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001197 # Verify the commit we're diffing against is in our current branch.
1198 upstream_sha = RunGit(['rev-parse', '--verify', upstream_git_obj]).strip()
1199 common_ancestor = RunGit(['merge-base', upstream_sha, 'HEAD']).strip()
1200 if upstream_sha != common_ancestor:
vapiera7fbd5a2016-06-16 09:17:49 -07001201 print('ERROR: %s is not in the current branch. You may need to rebase '
1202 'your tracking branch' % upstream_sha, file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001203 return False
1204
1205 # List the commits inside the diff, and verify they are all local.
1206 commits_in_diff = RunGit(
1207 ['rev-list', '^%s' % upstream_sha, 'HEAD']).splitlines()
1208 code, remote_branch = RunGitWithCode(['config', 'gitcl.remotebranch'])
1209 remote_branch = remote_branch.strip()
1210 if code != 0:
1211 _, remote_branch = self.GetRemoteBranch()
1212
1213 commits_in_remote = RunGit(
1214 ['rev-list', '^%s' % upstream_sha, remote_branch]).splitlines()
1215
1216 common_commits = set(commits_in_diff) & set(commits_in_remote)
1217 if common_commits:
vapiera7fbd5a2016-06-16 09:17:49 -07001218 print('ERROR: Your diff contains %d commits already in %s.\n'
1219 'Run "git log --oneline %s..HEAD" to get a list of commits in '
1220 'the diff. If you are using a custom git flow, you can override'
1221 ' the reference used for this check with "git config '
1222 'gitcl.remotebranch <git-ref>".' % (
1223 len(common_commits), remote_branch, upstream_git_obj),
1224 file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001225 return False
1226 return True
1227
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001228 def GetGitBaseUrlFromConfig(self):
sheyang@chromium.orga656e702014-05-15 20:43:05 +00001229 """Return the configured base URL from branch.<branchname>.baseurl.
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001230
1231 Returns None if it is not set.
1232 """
tandrii5d48c322016-08-18 16:19:37 -07001233 return self._GitGetBranchConfigValue('base-url')
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001234
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001235 def GetRemoteUrl(self):
1236 """Return the configured remote URL, e.g. 'git://example.org/foo.git/'.
1237
1238 Returns None if there is no remote.
1239 """
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001240 is_cached, value = self._cached_remote_url
1241 if is_cached:
1242 return value
1243
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001244 remote, _ = self.GetRemoteBranch()
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001245 url = RunGit(['config', 'remote.%s.url' % remote], error_ok=True).strip()
1246
Edward Lemur298f2cf2019-02-22 21:40:39 +00001247 # Check if the remote url can be parsed as an URL.
1248 host = urlparse.urlparse(url).netloc
1249 if host:
1250 self._cached_remote_url = (True, url)
1251 return url
1252
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001253 # If it cannot be parsed as an url, assume it is a local directory,
1254 # probably a git cache.
Edward Lemur298f2cf2019-02-22 21:40:39 +00001255 logging.warning('"%s" doesn\'t appear to point to a git host. '
1256 'Interpreting it as a local directory.', url)
1257 if not os.path.isdir(url):
1258 logging.error(
1259 'Remote "%s" for branch "%s" points to "%s", but it doesn\'t exist.',
1260 remote, url, self.GetBranch())
1261 return None
1262
1263 cache_path = url
1264 url = RunGit(['config', 'remote.%s.url' % remote],
1265 error_ok=True,
1266 cwd=url).strip()
1267
1268 host = urlparse.urlparse(url).netloc
1269 if not host:
1270 logging.error(
1271 'Remote "%(remote)s" for branch "%(branch)s" points to '
1272 '"%(cache_path)s", but it is misconfigured.\n'
1273 '"%(cache_path)s" must be a git repo and must have a remote named '
1274 '"%(remote)s" pointing to the git host.', {
1275 'remote': remote,
1276 'cache_path': cache_path,
1277 'branch': self.GetBranch()})
1278 return None
1279
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001280 self._cached_remote_url = (True, url)
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001281 return url
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001282
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001283 def GetIssue(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001284 """Returns the issue number as a int or None if not set."""
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001285 if self.issue is None and not self.lookedup_issue:
tandrii5d48c322016-08-18 16:19:37 -07001286 self.issue = self._GitGetBranchConfigValue(
1287 self._codereview_impl.IssueConfigKey(), value_type=int)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001288 self.lookedup_issue = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001289 return self.issue
1290
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001291 def GetIssueURL(self):
1292 """Get the URL for a particular issue."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001293 issue = self.GetIssue()
1294 if not issue:
dbeam@chromium.org015fd3d2013-06-18 19:02:50 +00001295 return None
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001296 return '%s/%s' % (self._codereview_impl.GetCodereviewServer(), issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001297
Andrii Shyshkalov31863012017-02-08 11:35:12 +01001298 def GetDescription(self, pretty=False, force=False):
1299 if not self.has_description or force:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001300 if self.GetIssue():
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001301 self.description = self._codereview_impl.FetchDescription(force=force)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001302 self.has_description = True
1303 if pretty:
Asanka Herath7c61dcb2016-12-14 13:01:58 -05001304 # Set width to 72 columns + 2 space indent.
1305 wrapper = textwrap.TextWrapper(width=74, replace_whitespace=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001306 wrapper.initial_indent = wrapper.subsequent_indent = ' '
Asanka Herath7c61dcb2016-12-14 13:01:58 -05001307 lines = self.description.splitlines()
1308 return '\n'.join([wrapper.fill(line) for line in lines])
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001309 return self.description
1310
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001311 def GetDescriptionFooters(self):
1312 """Returns (non_footer_lines, footers) for the commit message.
1313
1314 Returns:
1315 non_footer_lines (list(str)) - Simple list of description lines without
1316 any footer. The lines do not contain newlines, nor does the list contain
1317 the empty line between the message and the footers.
1318 footers (list(tuple(KEY, VALUE))) - List of parsed footers, e.g.
1319 [("Change-Id", "Ideadbeef...."), ...]
1320 """
1321 raw_description = self.GetDescription()
1322 msg_lines, _, footers = git_footers.split_footers(raw_description)
1323 if footers:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001324 msg_lines = msg_lines[:len(msg_lines) - 1]
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001325 return msg_lines, footers
1326
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001327 def GetPatchset(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001328 """Returns the patchset number as a int or None if not set."""
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001329 if self.patchset is None and not self.lookedup_patchset:
tandrii5d48c322016-08-18 16:19:37 -07001330 self.patchset = self._GitGetBranchConfigValue(
1331 self._codereview_impl.PatchsetConfigKey(), value_type=int)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001332 self.lookedup_patchset = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001333 return self.patchset
1334
1335 def SetPatchset(self, patchset):
tandrii5d48c322016-08-18 16:19:37 -07001336 """Set this branch's patchset. If patchset=0, clears the patchset."""
1337 assert self.GetBranch()
1338 if not patchset:
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001339 self.patchset = None
tandrii5d48c322016-08-18 16:19:37 -07001340 else:
1341 self.patchset = int(patchset)
1342 self._GitSetBranchConfigValue(
1343 self._codereview_impl.PatchsetConfigKey(), self.patchset)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001344
tandrii@chromium.orga342c922016-03-16 07:08:25 +00001345 def SetIssue(self, issue=None):
tandrii5d48c322016-08-18 16:19:37 -07001346 """Set this branch's issue. If issue isn't given, clears the issue."""
1347 assert self.GetBranch()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001348 if issue:
tandrii5d48c322016-08-18 16:19:37 -07001349 issue = int(issue)
1350 self._GitSetBranchConfigValue(
1351 self._codereview_impl.IssueConfigKey(), issue)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001352 self.issue = issue
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001353 codereview_server = self._codereview_impl.GetCodereviewServer()
1354 if codereview_server:
tandrii5d48c322016-08-18 16:19:37 -07001355 self._GitSetBranchConfigValue(
1356 self._codereview_impl.CodereviewServerConfigKey(),
1357 codereview_server)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001358 else:
tandrii5d48c322016-08-18 16:19:37 -07001359 # Reset all of these just to be clean.
1360 reset_suffixes = [
1361 'last-upload-hash',
1362 self._codereview_impl.IssueConfigKey(),
1363 self._codereview_impl.PatchsetConfigKey(),
1364 self._codereview_impl.CodereviewServerConfigKey(),
1365 ] + self._PostUnsetIssueProperties()
1366 for prop in reset_suffixes:
1367 self._GitSetBranchConfigValue(prop, None, error_ok=True)
Aaron Gableca01e2c2017-07-19 11:16:02 -07001368 msg = RunGit(['log', '-1', '--format=%B']).strip()
1369 if msg and git_footers.get_footer_change_id(msg):
1370 print('WARNING: The change patched into this branch has a Change-Id. '
1371 'Removing it.')
1372 RunGit(['commit', '--amend', '-m',
1373 git_footers.remove_footer(msg, 'Change-Id')])
Edward Lemurf38bc172019-09-03 21:02:13 +00001374 self.lookedup_issue = True
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001375 self.issue = None
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001376 self.patchset = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001377
dnjba1b0f32016-09-02 12:37:42 -07001378 def GetChange(self, upstream_branch, author, local_description=False):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001379 if not self.GitSanityChecks(upstream_branch):
1380 DieWithError('\nGit sanity check failure')
1381
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001382 root = settings.GetRelativeRoot()
bratell@opera.comf267b0e2013-05-02 09:11:43 +00001383 if not root:
1384 root = '.'
bauerb@chromium.org512f1ef2011-04-20 15:17:57 +00001385 absroot = os.path.abspath(root)
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001386
1387 # We use the sha1 of HEAD as a name of this change.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001388 name = RunGitWithCode(['rev-parse', 'HEAD'])[1].strip()
bauerb@chromium.org512f1ef2011-04-20 15:17:57 +00001389 # Need to pass a relative path for msysgit.
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001390 try:
maruel@chromium.org80a9ef12011-12-13 20:44:10 +00001391 files = scm.GIT.CaptureStatus([root], '.', upstream_branch)
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001392 except subprocess2.CalledProcessError:
1393 DieWithError(
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001394 ('\nFailed to diff against upstream branch %s\n\n'
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001395 'This branch probably doesn\'t exist anymore. To reset the\n'
1396 'tracking branch, please run\n'
stip7a3dd352016-09-22 17:32:28 -07001397 ' git branch --set-upstream-to origin/master %s\n'
1398 'or replace origin/master with the relevant branch') %
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001399 (upstream_branch, self.GetBranch()))
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001400
maruel@chromium.org52424302012-08-29 15:14:30 +00001401 issue = self.GetIssue()
1402 patchset = self.GetPatchset()
dnjba1b0f32016-09-02 12:37:42 -07001403 if issue and not local_description:
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001404 description = self.GetDescription()
1405 else:
1406 # If the change was never uploaded, use the log messages of all commits
1407 # up to the branch point, as git cl upload will prefill the description
1408 # with these log messages.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001409 args = ['log', '--pretty=format:%s%n%n%b', '%s...' % (upstream_branch)]
1410 description = RunGitWithCode(args)[1].strip()
maruel@chromium.org03b3bdc2011-06-14 13:04:12 +00001411
1412 if not author:
maruel@chromium.org13f623c2011-07-22 16:02:23 +00001413 author = RunGit(['config', 'user.email']).strip() or None
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001414 return presubmit_support.GitChange(
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001415 name,
1416 description,
1417 absroot,
1418 files,
1419 issue,
1420 patchset,
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001421 author,
1422 upstream=upstream_branch)
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001423
dsansomee2d6fd92016-09-08 00:10:47 -07001424 def UpdateDescription(self, description, force=False):
Andrii Shyshkalov83051152017-02-07 23:47:29 +01001425 self._codereview_impl.UpdateDescriptionRemote(description, force=force)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001426 self.description = description
Andrii Shyshkalov83051152017-02-07 23:47:29 +01001427 self.has_description = True
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001428
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001429 def UpdateDescriptionFooters(self, description_lines, footers, force=False):
1430 """Sets the description for this CL remotely.
1431
1432 You can get description_lines and footers with GetDescriptionFooters.
1433
1434 Args:
1435 description_lines (list(str)) - List of CL description lines without
1436 newline characters.
1437 footers (list(tuple(KEY, VALUE))) - List of footers, as returned by
1438 GetDescriptionFooters. Key must conform to the git footers format (i.e.
1439 `List-Of-Tokens`). It will be case-normalized so that each token is
1440 title-cased.
1441 """
1442 new_description = '\n'.join(description_lines)
1443 if footers:
1444 new_description += '\n'
1445 for k, v in footers:
1446 foot = '%s: %s' % (git_footers.normalize_name(k), v)
1447 if not git_footers.FOOTER_PATTERN.match(foot):
1448 raise ValueError('Invalid footer %r' % foot)
1449 new_description += foot + '\n'
1450 self.UpdateDescription(new_description, force)
1451
Edward Lesmes8e282792018-04-03 18:50:29 -04001452 def RunHook(self, committing, may_prompt, verbose, change, parallel):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001453 """Calls sys.exit() if the hook fails; returns a HookResults otherwise."""
1454 try:
Edward Lemur2c48f242019-06-04 16:14:09 +00001455 start = time_time()
1456 result = presubmit_support.DoPresubmitChecks(change, committing,
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001457 verbose=verbose, output_stream=sys.stdout, input_stream=sys.stdin,
1458 default_presubmit=None, may_prompt=may_prompt,
Edward Lesmes8e282792018-04-03 18:50:29 -04001459 gerrit_obj=self._codereview_impl.GetGerritObjForPresubmit(),
1460 parallel=parallel)
Edward Lemur2c48f242019-06-04 16:14:09 +00001461 metrics.collector.add_repeated('sub_commands', {
1462 'command': 'presubmit',
1463 'execution_time': time_time() - start,
1464 'exit_code': 0 if result.should_continue() else 1,
1465 })
1466 return result
vapierfd77ac72016-06-16 08:33:57 -07001467 except presubmit_support.PresubmitFailure as e:
Aaron Gable5d5f22c2018-02-02 09:12:41 -08001468 DieWithError('%s\nMaybe your depot_tools is out of date?' % e)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001469
Edward Lemurf38bc172019-09-03 21:02:13 +00001470 def CMDPatchIssue(self, issue_arg, nocommit):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001471 """Fetches and applies the issue patch from codereview to local branch."""
tandrii@chromium.orgef7c68c2016-04-07 09:39:39 +00001472 if isinstance(issue_arg, (int, long)) or issue_arg.isdigit():
1473 parsed_issue_arg = _ParsedIssueNumberArgument(int(issue_arg))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001474 else:
1475 # Assume url.
1476 parsed_issue_arg = self._codereview_impl.ParseIssueURL(
1477 urlparse.urlparse(issue_arg))
1478 if not parsed_issue_arg or not parsed_issue_arg.valid:
1479 DieWithError('Failed to parse issue argument "%s". '
1480 'Must be an issue number or a valid URL.' % issue_arg)
1481 return self._codereview_impl.CMDPatchWithParsedIssue(
Edward Lemurf38bc172019-09-03 21:02:13 +00001482 parsed_issue_arg, nocommit, False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001483
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001484 def CMDUpload(self, options, git_diff_args, orig_args):
1485 """Uploads a change to codereview."""
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001486 custom_cl_base = None
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001487 if git_diff_args:
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001488 custom_cl_base = base_branch = git_diff_args[0]
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001489 else:
1490 if self.GetBranch() is None:
1491 DieWithError('Can\'t upload from detached HEAD state. Get on a branch!')
1492
1493 # Default to diffing against common ancestor of upstream branch
1494 base_branch = self.GetCommonAncestorWithUpstream()
1495 git_diff_args = [base_branch, 'HEAD']
1496
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001497 # Fast best-effort checks to abort before running potentially expensive
1498 # hooks if uploading is likely to fail anyway. Passing these checks does
1499 # not guarantee that uploading will not fail.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001500 self._codereview_impl.EnsureAuthenticated(force=options.force)
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001501 self._codereview_impl.EnsureCanUploadPatchset(force=options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001502
1503 # Apply watchlists on upload.
1504 change = self.GetChange(base_branch, None)
1505 watchlist = watchlists.Watchlists(change.RepositoryRoot())
1506 files = [f.LocalPath() for f in change.AffectedFiles()]
1507 if not options.bypass_watchlists:
Daniel Cheng7227d212017-11-17 08:12:37 -08001508 self.ExtendCC(watchlist.GetWatchersForPaths(files))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001509
1510 if not options.bypass_hooks:
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001511 if options.reviewers or options.tbrs or options.add_owners_to:
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001512 # Set the reviewer list now so that presubmit checks can access it.
1513 change_description = ChangeDescription(change.FullDescriptionText())
1514 change_description.update_reviewers(options.reviewers,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001515 options.tbrs,
Robert Iannuccif2708bd2017-04-17 15:49:02 -07001516 options.add_owners_to,
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001517 change)
1518 change.SetDescriptionText(change_description.description)
1519 hook_results = self.RunHook(committing=False,
Edward Lesmes8e282792018-04-03 18:50:29 -04001520 may_prompt=not options.force,
1521 verbose=options.verbose,
1522 change=change, parallel=options.parallel)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001523 if not hook_results.should_continue():
1524 return 1
1525 if not options.reviewers and hook_results.reviewers:
1526 options.reviewers = hook_results.reviewers.split(',')
Daniel Cheng7227d212017-11-17 08:12:37 -08001527 self.ExtendCC(hook_results.more_cc)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001528
Aaron Gable13101a62018-02-09 13:20:41 -08001529 print_stats(git_diff_args)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001530 ret = self.CMDUploadChange(options, git_diff_args, custom_cl_base, change)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001531 if not ret:
tandrii5d48c322016-08-18 16:19:37 -07001532 _git_set_branch_config_value('last-upload-hash',
1533 RunGit(['rev-parse', 'HEAD']).strip())
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001534 # Run post upload hooks, if specified.
1535 if settings.GetRunPostUploadHook():
1536 presubmit_support.DoPostUploadExecuter(
1537 change,
1538 self,
1539 settings.GetRoot(),
1540 options.verbose,
1541 sys.stdout)
1542
1543 # Upload all dependencies if specified.
1544 if options.dependencies:
vapiera7fbd5a2016-06-16 09:17:49 -07001545 print()
1546 print('--dependencies has been specified.')
1547 print('All dependent local branches will be re-uploaded.')
1548 print()
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001549 # Remove the dependencies flag from args so that we do not end up in a
1550 # loop.
1551 orig_args.remove('--dependencies')
1552 ret = upload_branch_deps(self, orig_args)
1553 return ret
1554
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001555 def SetCQState(self, new_state):
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001556 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001557
1558 Issue must have been already uploaded and known.
1559 """
1560 assert new_state in _CQState.ALL_STATES
1561 assert self.GetIssue()
qyearsley1fdfcb62016-10-24 13:22:03 -07001562 try:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001563 self._codereview_impl.SetCQState(new_state)
qyearsley1fdfcb62016-10-24 13:22:03 -07001564 return 0
1565 except KeyboardInterrupt:
1566 raise
1567 except:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001568 print('WARNING: Failed to %s.\n'
qyearsley1fdfcb62016-10-24 13:22:03 -07001569 'Either:\n'
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001570 ' * Your project has no CQ,\n'
1571 ' * You don\'t have permission to change the CQ state,\n'
1572 ' * There\'s a bug in this code (see stack trace below).\n'
1573 'Consider specifying which bots to trigger manually or asking your '
1574 'project owners for permissions or contacting Chrome Infra at:\n'
1575 'https://www.chromium.org/infra\n\n' %
1576 ('cancel CQ' if new_state == _CQState.NONE else 'trigger CQ'))
qyearsley1fdfcb62016-10-24 13:22:03 -07001577 # Still raise exception so that stack trace is printed.
1578 raise
1579
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001580 # Forward methods to codereview specific implementation.
1581
Aaron Gable636b13f2017-07-14 10:42:48 -07001582 def AddComment(self, message, publish=None):
1583 return self._codereview_impl.AddComment(message, publish=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001584
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001585 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001586 """Returns list of _CommentSummary for each comment.
1587
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001588 args:
1589 readable: determines whether the output is designed for a human or a machine
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001590 """
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001591 return self._codereview_impl.GetCommentsSummary(readable)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001592
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001593 def CloseIssue(self):
1594 return self._codereview_impl.CloseIssue()
1595
1596 def GetStatus(self):
1597 return self._codereview_impl.GetStatus()
1598
1599 def GetCodereviewServer(self):
1600 return self._codereview_impl.GetCodereviewServer()
1601
tandriide281ae2016-10-12 06:02:30 -07001602 def GetIssueOwner(self):
1603 """Get owner from codereview, which may differ from this checkout."""
1604 return self._codereview_impl.GetIssueOwner()
1605
Edward Lemur707d70b2018-02-07 00:50:14 +01001606 def GetReviewers(self):
1607 return self._codereview_impl.GetReviewers()
1608
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001609 def GetMostRecentPatchset(self):
1610 return self._codereview_impl.GetMostRecentPatchset()
1611
tandriide281ae2016-10-12 06:02:30 -07001612 def CannotTriggerTryJobReason(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001613 """Returns reason (str) if unable trigger tryjobs on this CL or None."""
tandriide281ae2016-10-12 06:02:30 -07001614 return self._codereview_impl.CannotTriggerTryJobReason()
1615
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001616 def __getattr__(self, attr):
1617 # This is because lots of untested code accesses Rietveld-specific stuff
1618 # directly, and it's hard to fix for sure. So, just let it work, and fix
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00001619 # on a case by case basis.
tandrii4d895502016-08-18 08:26:19 -07001620 # Note that child method defines __getattr__ as well, and forwards it here,
1621 # because _RietveldChangelistImpl is not cleaned up yet, and given
1622 # deprecation of Rietveld, it should probably be just removed.
1623 # Until that time, avoid infinite recursion by bypassing __getattr__
1624 # of implementation class.
1625 return self._codereview_impl.__getattribute__(attr)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001626
1627
1628class _ChangelistCodereviewBase(object):
1629 """Abstract base class encapsulating codereview specifics of a changelist."""
1630 def __init__(self, changelist):
1631 self._changelist = changelist # instance of Changelist
1632
1633 def __getattr__(self, attr):
1634 # Forward methods to changelist.
1635 # TODO(tandrii): maybe clean up _GerritChangelistImpl and
1636 # _RietveldChangelistImpl to avoid this hack?
1637 return getattr(self._changelist, attr)
1638
1639 def GetStatus(self):
1640 """Apply a rough heuristic to give a simple summary of an issue's review
1641 or CQ status, assuming adherence to a common workflow.
1642
1643 Returns None if no issue for this branch, or specific string keywords.
1644 """
1645 raise NotImplementedError()
1646
1647 def GetCodereviewServer(self):
1648 """Returns server URL without end slash, like "https://codereview.com"."""
1649 raise NotImplementedError()
1650
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001651 def FetchDescription(self, force=False):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001652 """Fetches and returns description from the codereview server."""
1653 raise NotImplementedError()
1654
tandrii5d48c322016-08-18 16:19:37 -07001655 @classmethod
1656 def IssueConfigKey(cls):
1657 """Returns branch setting storing issue number."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001658 raise NotImplementedError()
1659
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001660 @classmethod
tandrii5d48c322016-08-18 16:19:37 -07001661 def PatchsetConfigKey(cls):
1662 """Returns branch setting storing patchset number."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001663 raise NotImplementedError()
1664
tandrii5d48c322016-08-18 16:19:37 -07001665 @classmethod
1666 def CodereviewServerConfigKey(cls):
1667 """Returns branch setting storing codereview server."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001668 raise NotImplementedError()
1669
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001670 def _PostUnsetIssueProperties(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001671 """Which branch-specific properties to erase when unsetting issue."""
tandrii5d48c322016-08-18 16:19:37 -07001672 return []
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001673
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001674 def GetGerritObjForPresubmit(self):
1675 # None is valid return value, otherwise presubmit_support.GerritAccessor.
1676 return None
1677
dsansomee2d6fd92016-09-08 00:10:47 -07001678 def UpdateDescriptionRemote(self, description, force=False):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001679 """Update the description on codereview site."""
1680 raise NotImplementedError()
1681
Aaron Gable636b13f2017-07-14 10:42:48 -07001682 def AddComment(self, message, publish=None):
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001683 """Posts a comment to the codereview site."""
1684 raise NotImplementedError()
1685
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001686 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001687 raise NotImplementedError()
1688
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001689 def CloseIssue(self):
1690 """Closes the issue."""
1691 raise NotImplementedError()
1692
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001693 def GetMostRecentPatchset(self):
1694 """Returns the most recent patchset number from the codereview site."""
1695 raise NotImplementedError()
1696
Edward Lemurf38bc172019-09-03 21:02:13 +00001697 def CMDPatchWithParsedIssue(self, parsed_issue_arg, nocommit, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001698 """Fetches and applies the issue.
1699
1700 Arguments:
1701 parsed_issue_arg: instance of _ParsedIssueNumberArgument.
Edward Lemurf38bc172019-09-03 21:02:13 +00001702 nocommit: do not commit the patch, thus leave the tree dirty.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001703 """
1704 raise NotImplementedError()
1705
1706 @staticmethod
1707 def ParseIssueURL(parsed_url):
1708 """Parses url and returns instance of _ParsedIssueNumberArgument or None if
1709 failed."""
1710 raise NotImplementedError()
1711
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001712 def EnsureAuthenticated(self, force, refresh=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001713 """Best effort check that user is authenticated with codereview server.
1714
1715 Arguments:
1716 force: whether to skip confirmation questions.
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001717 refresh: whether to attempt to refresh credentials. Ignored if not
1718 applicable.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001719 """
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001720 raise NotImplementedError()
1721
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001722 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001723 """Best effort check that uploading isn't supposed to fail for predictable
1724 reasons.
1725
1726 This method should raise informative exception if uploading shouldn't
1727 proceed.
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001728
1729 Arguments:
1730 force: whether to skip confirmation questions.
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001731 """
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001732 raise NotImplementedError()
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001733
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001734 def CMDUploadChange(self, options, git_diff_args, custom_cl_base, change):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00001735 """Uploads a change to codereview."""
1736 raise NotImplementedError()
1737
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001738 def SetCQState(self, new_state):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001739 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001740
1741 Issue must have been already uploaded and known.
1742 """
1743 raise NotImplementedError()
1744
tandriie113dfd2016-10-11 10:20:12 -07001745 def CannotTriggerTryJobReason(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001746 """Returns reason (str) if unable trigger tryjobs on this CL or None."""
tandriie113dfd2016-10-11 10:20:12 -07001747 raise NotImplementedError()
1748
tandriide281ae2016-10-12 06:02:30 -07001749 def GetIssueOwner(self):
1750 raise NotImplementedError()
1751
Edward Lemur707d70b2018-02-07 00:50:14 +01001752 def GetReviewers(self):
1753 raise NotImplementedError()
1754
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001755class _GerritChangelistImpl(_ChangelistCodereviewBase):
Edward Lemur934836a2019-09-09 20:16:54 +00001756 def __init__(self, changelist, codereview_host=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001757 super(_GerritChangelistImpl, self).__init__(changelist)
1758 self._change_id = None
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001759 # Lazily cached values.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001760 self._gerrit_host = None # e.g. chromium-review.googlesource.com
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001761 self._gerrit_server = None # e.g. https://chromium-review.googlesource.com
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001762 # Map from change number (issue) to its detail cache.
1763 self._detail_cache = {}
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001764
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001765 if codereview_host is not None:
1766 assert not codereview_host.startswith('https://'), codereview_host
1767 self._gerrit_host = codereview_host
1768 self._gerrit_server = 'https://%s' % codereview_host
1769
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001770 def _GetGerritHost(self):
1771 # Lazy load of configs.
1772 self.GetCodereviewServer()
tandriie32e3ea2016-06-22 02:52:48 -07001773 if self._gerrit_host and '.' not in self._gerrit_host:
1774 # Abbreviated domain like "chromium" instead of chromium.googlesource.com.
1775 # This happens for internal stuff http://crbug.com/614312.
1776 parsed = urlparse.urlparse(self.GetRemoteUrl())
1777 if parsed.scheme == 'sso':
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001778 print('WARNING: using non-https URLs for remote is likely broken\n'
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001779 ' Your current remote is: %s' % self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001780 self._gerrit_host = '%s.googlesource.com' % self._gerrit_host
1781 self._gerrit_server = 'https://%s' % self._gerrit_host
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001782 return self._gerrit_host
1783
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001784 def _GetGitHost(self):
1785 """Returns git host to be used when uploading change to Gerrit."""
Edward Lemur298f2cf2019-02-22 21:40:39 +00001786 remote_url = self.GetRemoteUrl()
1787 if not remote_url:
1788 return None
1789 return urlparse.urlparse(remote_url).netloc
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001790
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001791 def GetCodereviewServer(self):
1792 if not self._gerrit_server:
1793 # If we're on a branch then get the server potentially associated
1794 # with that branch.
1795 if self.GetIssue():
tandrii5d48c322016-08-18 16:19:37 -07001796 self._gerrit_server = self._GitGetBranchConfigValue(
1797 self.CodereviewServerConfigKey())
1798 if self._gerrit_server:
1799 self._gerrit_host = urlparse.urlparse(self._gerrit_server).netloc
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001800 if not self._gerrit_server:
1801 # We assume repo to be hosted on Gerrit, and hence Gerrit server
1802 # has "-review" suffix for lowest level subdomain.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001803 parts = self._GetGitHost().split('.')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001804 parts[0] = parts[0] + '-review'
1805 self._gerrit_host = '.'.join(parts)
1806 self._gerrit_server = 'https://%s' % self._gerrit_host
1807 return self._gerrit_server
1808
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001809 def _GetGerritProject(self):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001810 """Returns Gerrit project name based on remote git URL."""
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001811 remote_url = self.GetRemoteUrl()
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001812 if remote_url is None:
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001813 logging.warn('can\'t detect Gerrit project.')
1814 return None
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001815 project = urlparse.urlparse(remote_url).path.strip('/')
1816 if project.endswith('.git'):
1817 project = project[:-len('.git')]
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001818 # *.googlesource.com hosts ensure that Git/Gerrit projects don't start with
1819 # 'a/' prefix, because 'a/' prefix is used to force authentication in
1820 # gitiles/git-over-https protocol. E.g.,
1821 # https://chromium.googlesource.com/a/v8/v8 refers to the same repo/project
1822 # as
1823 # https://chromium.googlesource.com/v8/v8
1824 if project.startswith('a/'):
1825 project = project[len('a/'):]
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001826 return project
1827
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001828 def _GerritChangeIdentifier(self):
1829 """Handy method for gerrit_util.ChangeIdentifier for a given CL.
1830
1831 Not to be confused by value of "Change-Id:" footer.
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001832 If Gerrit project can be determined, this will speed up Gerrit HTTP API RPC.
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001833 """
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001834 project = self._GetGerritProject()
1835 if project:
1836 return gerrit_util.ChangeIdentifier(project, self.GetIssue())
1837 # Fall back on still unique, but less efficient change number.
1838 return str(self.GetIssue())
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001839
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001840 @classmethod
tandrii5d48c322016-08-18 16:19:37 -07001841 def IssueConfigKey(cls):
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001842 return 'gerritissue'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001843
tandrii5d48c322016-08-18 16:19:37 -07001844 @classmethod
1845 def PatchsetConfigKey(cls):
1846 return 'gerritpatchset'
1847
1848 @classmethod
1849 def CodereviewServerConfigKey(cls):
1850 return 'gerritserver'
1851
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001852 def EnsureAuthenticated(self, force, refresh=None):
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001853 """Best effort check that user is authenticated with Gerrit server."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001854 if settings.GetGerritSkipEnsureAuthenticated():
1855 # For projects with unusual authentication schemes.
1856 # See http://crbug.com/603378.
1857 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001858
1859 # Check presence of cookies only if using cookies-based auth method.
1860 cookie_auth = gerrit_util.Authenticator.get()
1861 if not isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001862 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001863
Daniel Chengcf6269b2019-05-18 01:02:12 +00001864 if urlparse.urlparse(self.GetRemoteUrl()).scheme != 'https':
1865 print('WARNING: Ignoring branch %s with non-https remote %s' %
1866 (self._changelist.branch, self.GetRemoteUrl()))
1867 return
1868
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001869 # Lazy-loader to identify Gerrit and Git hosts.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001870 self.GetCodereviewServer()
1871 git_host = self._GetGitHost()
Edward Lemur298f2cf2019-02-22 21:40:39 +00001872 assert self._gerrit_server and self._gerrit_host and git_host
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001873
1874 gerrit_auth = cookie_auth.get_auth_header(self._gerrit_host)
1875 git_auth = cookie_auth.get_auth_header(git_host)
1876 if gerrit_auth and git_auth:
1877 if gerrit_auth == git_auth:
1878 return
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001879 all_gsrc = cookie_auth.get_auth_header('d0esN0tEx1st.googlesource.com')
Raul Tambre80ee78e2019-05-06 22:41:05 +00001880 print(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001881 'WARNING: You have different credentials for Gerrit and git hosts:\n'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001882 ' %s\n'
1883 ' %s\n'
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001884 ' Consider running the following command:\n'
1885 ' git cl creds-check\n'
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001886 ' %s\n'
Raul Tambre80ee78e2019-05-06 22:41:05 +00001887 ' %s' %
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001888 (git_host, self._gerrit_host,
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001889 ('Hint: delete creds for .googlesource.com' if all_gsrc else ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001890 cookie_auth.get_new_password_message(git_host)))
1891 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001892 confirm_or_exit('If you know what you are doing', action='continue')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001893 return
1894 else:
1895 missing = (
Anna Henningsen4e891442017-07-06 21:40:58 +02001896 ([] if gerrit_auth else [self._gerrit_host]) +
1897 ([] if git_auth else [git_host]))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001898 DieWithError('Credentials for the following hosts are required:\n'
1899 ' %s\n'
1900 'These are read from %s (or legacy %s)\n'
1901 '%s' % (
1902 '\n '.join(missing),
1903 cookie_auth.get_gitcookies_path(),
1904 cookie_auth.get_netrc_path(),
1905 cookie_auth.get_new_password_message(git_host)))
1906
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001907 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001908 if not self.GetIssue():
1909 return
1910
1911 # Warm change details cache now to avoid RPCs later, reducing latency for
1912 # developers.
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001913 self._GetChangeDetail(
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +00001914 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS'])
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001915
1916 status = self._GetChangeDetail()['status']
1917 if status in ('MERGED', 'ABANDONED'):
1918 DieWithError('Change %s has been %s, new uploads are not allowed' %
1919 (self.GetIssueURL(),
1920 'submitted' if status == 'MERGED' else 'abandoned'))
1921
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001922 # TODO(vadimsh): For some reason the chunk of code below was skipped if
1923 # 'is_gce' is True. I'm just refactoring it to be 'skip if not cookies'.
1924 # Apparently this check is not very important? Otherwise get_auth_email
1925 # could have been added to other implementations of Authenticator.
1926 cookies_auth = gerrit_util.Authenticator.get()
1927 if not isinstance(cookies_auth, gerrit_util.CookiesAuthenticator):
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001928 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001929
1930 cookies_user = cookies_auth.get_auth_email(self._GetGerritHost())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001931 if self.GetIssueOwner() == cookies_user:
1932 return
1933 logging.debug('change %s owner is %s, cookies user is %s',
1934 self.GetIssue(), self.GetIssueOwner(), cookies_user)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001935 # Maybe user has linked accounts or something like that,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001936 # so ask what Gerrit thinks of this user.
1937 details = gerrit_util.GetAccountDetails(self._GetGerritHost(), 'self')
1938 if details['email'] == self.GetIssueOwner():
1939 return
1940 if not force:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001941 print('WARNING: Change %s is owned by %s, but you authenticate to Gerrit '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001942 'as %s.\n'
1943 'Uploading may fail due to lack of permissions.' %
1944 (self.GetIssue(), self.GetIssueOwner(), details['email']))
1945 confirm_or_exit(action='upload')
1946
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001947 def _PostUnsetIssueProperties(self):
1948 """Which branch-specific properties to erase when unsetting issue."""
tandrii5d48c322016-08-18 16:19:37 -07001949 return ['gerritsquashhash']
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001950
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001951 def GetGerritObjForPresubmit(self):
1952 return presubmit_support.GerritAccessor(self._GetGerritHost())
1953
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001954 def GetStatus(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001955 """Applies a rough heuristic to give a simple summary of an issue's review
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001956 or CQ status, assuming adherence to a common workflow.
1957
1958 Returns None if no issue for this branch, or one of the following keywords:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001959 * 'error' - error from review tool (including deleted issues)
1960 * 'unsent' - no reviewers added
1961 * 'waiting' - waiting for review
1962 * 'reply' - waiting for uploader to reply to review
1963 * 'lgtm' - Code-Review label has been set
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00001964 * 'dry-run' - dry-running in the CQ
1965 * 'commit' - in the CQ
Aaron Gable9ab38c62017-04-06 14:36:33 -07001966 * 'closed' - successfully submitted or abandoned
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001967 """
1968 if not self.GetIssue():
1969 return None
1970
1971 try:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001972 data = self._GetChangeDetail([
1973 'DETAILED_LABELS', 'CURRENT_REVISION', 'SUBMITTABLE'])
Aaron Gablea45ee112016-11-22 15:14:38 -08001974 except (httplib.HTTPException, GerritChangeNotExists):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001975 return 'error'
1976
tandrii@chromium.org5e1bf382016-05-17 08:43:24 +00001977 if data['status'] in ('ABANDONED', 'MERGED'):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001978 return 'closed'
1979
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001980 cq_label = data['labels'].get('Commit-Queue', {})
1981 max_cq_vote = 0
1982 for vote in cq_label.get('all', []):
1983 max_cq_vote = max(max_cq_vote, vote.get('value', 0))
1984 if max_cq_vote == 2:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001985 return 'commit'
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001986 if max_cq_vote == 1:
1987 return 'dry-run'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001988
Aaron Gable9ab38c62017-04-06 14:36:33 -07001989 if data['labels'].get('Code-Review', {}).get('approved'):
1990 return 'lgtm'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001991
1992 if not data.get('reviewers', {}).get('REVIEWER', []):
1993 return 'unsent'
1994
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001995 owner = data['owner'].get('_account_id')
Aaron Gable9ab38c62017-04-06 14:36:33 -07001996 messages = sorted(data.get('messages', []), key=lambda m: m.get('updated'))
1997 last_message_author = messages.pop().get('author', {})
1998 while last_message_author:
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001999 if last_message_author.get('email') == COMMIT_BOT_EMAIL:
2000 # Ignore replies from CQ.
Aaron Gable9ab38c62017-04-06 14:36:33 -07002001 last_message_author = messages.pop().get('author', {})
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01002002 continue
Aaron Gable9ab38c62017-04-06 14:36:33 -07002003 if last_message_author.get('_account_id') == owner:
2004 # Most recent message was by owner.
2005 return 'waiting'
2006 else:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002007 # Some reply from non-owner.
2008 return 'reply'
Aaron Gable9ab38c62017-04-06 14:36:33 -07002009
2010 # Somehow there are no messages even though there are reviewers.
2011 return 'unsent'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002012
2013 def GetMostRecentPatchset(self):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002014 data = self._GetChangeDetail(['CURRENT_REVISION'])
Aaron Gablee8856ee2017-12-07 12:41:46 -08002015 patchset = data['revisions'][data['current_revision']]['_number']
2016 self.SetPatchset(patchset)
2017 return patchset
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002018
Kenneth Russell61e2ed42017-02-15 11:47:13 -08002019 def FetchDescription(self, force=False):
2020 data = self._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'],
2021 no_cache=force)
tandrii@chromium.org2d3da632016-04-25 19:23:27 +00002022 current_rev = data['current_revision']
Dan Beamcf6df902018-11-08 01:48:37 +00002023 return data['revisions'][current_rev]['commit']['message'].encode(
2024 'utf-8', 'ignore')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002025
dsansomee2d6fd92016-09-08 00:10:47 -07002026 def UpdateDescriptionRemote(self, description, force=False):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002027 if gerrit_util.HasPendingChangeEdit(
2028 self._GetGerritHost(), self._GerritChangeIdentifier()):
dsansomee2d6fd92016-09-08 00:10:47 -07002029 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002030 confirm_or_exit(
dsansomee2d6fd92016-09-08 00:10:47 -07002031 'The description cannot be modified while the issue has a pending '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002032 'unpublished edit. Either publish the edit in the Gerrit web UI '
2033 'or delete it.\n\n', action='delete the unpublished edit')
dsansomee2d6fd92016-09-08 00:10:47 -07002034
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002035 gerrit_util.DeletePendingChangeEdit(
2036 self._GetGerritHost(), self._GerritChangeIdentifier())
2037 gerrit_util.SetCommitMessage(
2038 self._GetGerritHost(), self._GerritChangeIdentifier(),
2039 description, notify='NONE')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002040
Aaron Gable636b13f2017-07-14 10:42:48 -07002041 def AddComment(self, message, publish=None):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002042 gerrit_util.SetReview(
2043 self._GetGerritHost(), self._GerritChangeIdentifier(),
2044 msg=message, ready=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002045
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002046 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002047 # DETAILED_ACCOUNTS is to get emails in accounts.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002048 # CURRENT_REVISION is included to get the latest patchset so that
2049 # only the robot comments from the latest patchset can be shown.
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002050 messages = self._GetChangeDetail(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002051 options=['MESSAGES', 'DETAILED_ACCOUNTS',
2052 'CURRENT_REVISION']).get('messages', [])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002053 file_comments = gerrit_util.GetChangeComments(
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002054 self._GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002055 robot_file_comments = gerrit_util.GetChangeRobotComments(
2056 self._GetGerritHost(), self._GerritChangeIdentifier())
2057
2058 # Add the robot comments onto the list of comments, but only
2059 # keep those that are from the latest pachset.
2060 latest_patch_set = self.GetMostRecentPatchset()
2061 for path, robot_comments in robot_file_comments.iteritems():
2062 line_comments = file_comments.setdefault(path, [])
2063 line_comments.extend(
2064 [c for c in robot_comments if c['patch_set'] == latest_patch_set])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002065
2066 # Build dictionary of file comments for easy access and sorting later.
2067 # {author+date: {path: {patchset: {line: url+message}}}}
2068 comments = collections.defaultdict(
2069 lambda: collections.defaultdict(lambda: collections.defaultdict(dict)))
2070 for path, line_comments in file_comments.iteritems():
2071 for comment in line_comments:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002072 tag = comment.get('tag', '')
2073 if tag.startswith('autogenerated') and 'robot_id' not in comment:
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002074 continue
2075 key = (comment['author']['email'], comment['updated'])
2076 if comment.get('side', 'REVISION') == 'PARENT':
2077 patchset = 'Base'
2078 else:
2079 patchset = 'PS%d' % comment['patch_set']
2080 line = comment.get('line', 0)
2081 url = ('https://%s/c/%s/%s/%s#%s%s' %
2082 (self._GetGerritHost(), self.GetIssue(), comment['patch_set'], path,
2083 'b' if comment.get('side') == 'PARENT' else '',
2084 str(line) if line else ''))
2085 comments[key][path][patchset][line] = (url, comment['message'])
2086
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002087 summaries = []
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002088 for msg in messages:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002089 summary = self._BuildCommentSummary(msg, comments, readable)
2090 if summary:
2091 summaries.append(summary)
2092 return summaries
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002093
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002094 @staticmethod
2095 def _BuildCommentSummary(msg, comments, readable):
2096 key = (msg['author']['email'], msg['date'])
2097 # Don't bother showing autogenerated messages that don't have associated
2098 # file or line comments. this will filter out most autogenerated
2099 # messages, but will keep robot comments like those from Tricium.
2100 is_autogenerated = msg.get('tag', '').startswith('autogenerated')
2101 if is_autogenerated and not comments.get(key):
2102 return None
2103 message = msg['message']
2104 # Gerrit spits out nanoseconds.
2105 assert len(msg['date'].split('.')[-1]) == 9
2106 date = datetime.datetime.strptime(msg['date'][:-3],
2107 '%Y-%m-%d %H:%M:%S.%f')
2108 if key in comments:
2109 message += '\n'
2110 for path, patchsets in sorted(comments.get(key, {}).items()):
2111 if readable:
2112 message += '\n%s' % path
2113 for patchset, lines in sorted(patchsets.items()):
2114 for line, (url, content) in sorted(lines.items()):
2115 if line:
2116 line_str = 'Line %d' % line
2117 path_str = '%s:%d:' % (path, line)
2118 else:
2119 line_str = 'File comment'
2120 path_str = '%s:0:' % path
2121 if readable:
2122 message += '\n %s, %s: %s' % (patchset, line_str, url)
2123 message += '\n %s\n' % content
2124 else:
2125 message += '\n%s ' % path_str
2126 message += '\n%s\n' % content
2127
2128 return _CommentSummary(
2129 date=date,
2130 message=message,
2131 sender=msg['author']['email'],
2132 autogenerated=is_autogenerated,
2133 # These could be inferred from the text messages and correlated with
2134 # Code-Review label maximum, however this is not reliable.
2135 # Leaving as is until the need arises.
2136 approval=False,
2137 disapproval=False,
2138 )
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01002139
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002140 def CloseIssue(self):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002141 gerrit_util.AbandonChange(
2142 self._GetGerritHost(), self._GerritChangeIdentifier(), msg='')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002143
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002144 def SubmitIssue(self, wait_for_merge=True):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002145 gerrit_util.SubmitChange(
2146 self._GetGerritHost(), self._GerritChangeIdentifier(),
2147 wait_for_merge=wait_for_merge)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002148
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002149 def _GetChangeDetail(self, options=None, no_cache=False):
2150 """Returns details of associated Gerrit change and caching results.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002151
2152 If fresh data is needed, set no_cache=True which will clear cache and
2153 thus new data will be fetched from Gerrit.
2154 """
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002155 options = options or []
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002156 assert self.GetIssue(), 'issue is required to query Gerrit'
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002157
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002158 # Optimization to avoid multiple RPCs:
2159 if (('CURRENT_REVISION' in options or 'ALL_REVISIONS' in options) and
2160 'CURRENT_COMMIT' not in options):
2161 options.append('CURRENT_COMMIT')
2162
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002163 # Normalize issue and options for consistent keys in cache.
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002164 cache_key = str(self.GetIssue())
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002165 options = [o.upper() for o in options]
2166
2167 # Check in cache first unless no_cache is True.
2168 if no_cache:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002169 self._detail_cache.pop(cache_key, None)
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002170 else:
2171 options_set = frozenset(options)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002172 for cached_options_set, data in self._detail_cache.get(cache_key, []):
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002173 # Assumption: data fetched before with extra options is suitable
2174 # for return for a smaller set of options.
2175 # For example, if we cached data for
2176 # options=[CURRENT_REVISION, DETAILED_FOOTERS]
2177 # and request is for options=[CURRENT_REVISION],
2178 # THEN we can return prior cached data.
2179 if options_set.issubset(cached_options_set):
2180 return data
2181
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002182 try:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002183 data = gerrit_util.GetChangeDetail(
2184 self._GetGerritHost(), self._GerritChangeIdentifier(), options)
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002185 except gerrit_util.GerritError as e:
2186 if e.http_status == 404:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002187 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002188 raise
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002189
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002190 self._detail_cache.setdefault(cache_key, []).append(
2191 (frozenset(options), data))
tandriic2405f52016-10-10 08:13:15 -07002192 return data
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002193
Andrii Shyshkalovcc5f17e2018-08-22 23:35:59 +00002194 def _GetChangeCommit(self):
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002195 assert self.GetIssue(), 'issue must be set to query Gerrit'
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002196 try:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002197 data = gerrit_util.GetChangeCommit(
2198 self._GetGerritHost(), self._GerritChangeIdentifier())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002199 except gerrit_util.GerritError as e:
2200 if e.http_status == 404:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002201 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002202 raise
agable32978d92016-11-01 12:55:02 -07002203 return data
2204
Karen Qian40c19422019-03-13 21:28:29 +00002205 def _IsCqConfigured(self):
2206 detail = self._GetChangeDetail(['LABELS'])
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002207 if u'Commit-Queue' not in detail.get('labels', {}):
Karen Qian40c19422019-03-13 21:28:29 +00002208 return False
2209 # TODO(crbug/753213): Remove temporary hack
2210 if ('https://chromium.googlesource.com/chromium/src' ==
2211 self._changelist.GetRemoteUrl() and
2212 detail['branch'].startswith('refs/branch-heads/')):
2213 return False
2214 return True
2215
Olivier Robin75ee7252018-04-13 10:02:56 +02002216 def CMDLand(self, force, bypass_hooks, verbose, parallel):
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002217 if git_common.is_dirty_git_tree('land'):
2218 return 1
Karen Qian40c19422019-03-13 21:28:29 +00002219
tandriid60367b2016-06-22 05:25:12 -07002220 detail = self._GetChangeDetail(['CURRENT_REVISION', 'LABELS'])
Karen Qian40c19422019-03-13 21:28:29 +00002221 if not force and self._IsCqConfigured():
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00002222 confirm_or_exit('\nIt seems this repository has a CQ, '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002223 'which can test and land changes for you. '
2224 'Are you sure you wish to bypass it?\n',
2225 action='bypass CQ')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002226 differs = True
tandriic4344b52016-08-29 06:04:54 -07002227 last_upload = self._GitGetBranchConfigValue('gerritsquashhash')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002228 # Note: git diff outputs nothing if there is no diff.
2229 if not last_upload or RunGit(['diff', last_upload]).strip():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002230 print('WARNING: Some changes from local branch haven\'t been uploaded.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002231 else:
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002232 if detail['current_revision'] == last_upload:
2233 differs = False
2234 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002235 print('WARNING: Local branch contents differ from latest uploaded '
2236 'patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002237 if differs:
2238 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002239 confirm_or_exit(
2240 'Do you want to submit latest Gerrit patchset and bypass hooks?\n',
2241 action='submit')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002242 print('WARNING: Bypassing hooks and submitting latest uploaded patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002243 elif not bypass_hooks:
2244 hook_results = self.RunHook(
2245 committing=True,
2246 may_prompt=not force,
2247 verbose=verbose,
Olivier Robin75ee7252018-04-13 10:02:56 +02002248 change=self.GetChange(self.GetCommonAncestorWithUpstream(), None),
2249 parallel=parallel)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002250 if not hook_results.should_continue():
2251 return 1
2252
2253 self.SubmitIssue(wait_for_merge=True)
2254 print('Issue %s has been submitted.' % self.GetIssueURL())
agable32978d92016-11-01 12:55:02 -07002255 links = self._GetChangeCommit().get('web_links', [])
2256 for link in links:
Aaron Gable02cdbb42016-12-13 16:24:25 -08002257 if link.get('name') == 'gitiles' and link.get('url'):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002258 print('Landed as: %s' % link.get('url'))
agable32978d92016-11-01 12:55:02 -07002259 break
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002260 return 0
2261
Edward Lemurf38bc172019-09-03 21:02:13 +00002262 def CMDPatchWithParsedIssue(self, parsed_issue_arg, nocommit, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002263 assert parsed_issue_arg.valid
2264
2265 self._changelist.issue = parsed_issue_arg.issue
2266
2267 if parsed_issue_arg.hostname:
2268 self._gerrit_host = parsed_issue_arg.hostname
2269 self._gerrit_server = 'https://%s' % self._gerrit_host
2270
tandriic2405f52016-10-10 08:13:15 -07002271 try:
2272 detail = self._GetChangeDetail(['ALL_REVISIONS'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002273 except GerritChangeNotExists as e:
tandriic2405f52016-10-10 08:13:15 -07002274 DieWithError(str(e))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002275
2276 if not parsed_issue_arg.patchset:
2277 # Use current revision by default.
2278 revision_info = detail['revisions'][detail['current_revision']]
2279 patchset = int(revision_info['_number'])
2280 else:
2281 patchset = parsed_issue_arg.patchset
2282 for revision_info in detail['revisions'].itervalues():
2283 if int(revision_info['_number']) == parsed_issue_arg.patchset:
2284 break
2285 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08002286 DieWithError('Couldn\'t find patchset %i in change %i' %
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002287 (parsed_issue_arg.patchset, self.GetIssue()))
2288
Aaron Gable697a91b2018-01-19 15:20:15 -08002289 remote_url = self._changelist.GetRemoteUrl()
2290 if remote_url.endswith('.git'):
2291 remote_url = remote_url[:-len('.git')]
erikchen0d14d0d2018-08-28 18:57:09 +00002292 remote_url = remote_url.rstrip('/')
2293
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002294 fetch_info = revision_info['fetch']['http']
erikchen0d14d0d2018-08-28 18:57:09 +00002295 fetch_info['url'] = fetch_info['url'].rstrip('/')
Aaron Gable697a91b2018-01-19 15:20:15 -08002296
2297 if remote_url != fetch_info['url']:
2298 DieWithError('Trying to patch a change from %s but this repo appears '
2299 'to be %s.' % (fetch_info['url'], remote_url))
2300
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002301 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
Aaron Gable9387b4f2017-06-08 10:50:03 -07002302
Aaron Gable62619a32017-06-16 08:22:09 -07002303 if force:
2304 RunGit(['reset', '--hard', 'FETCH_HEAD'])
2305 print('Checked out commit for change %i patchset %i locally' %
2306 (parsed_issue_arg.issue, patchset))
Stefan Zager2d5f0392017-10-10 15:17:53 -07002307 elif nocommit:
2308 RunGit(['cherry-pick', '--no-commit', 'FETCH_HEAD'])
2309 print('Patch applied to index.')
Aaron Gable62619a32017-06-16 08:22:09 -07002310 else:
Aaron Gable9387b4f2017-06-08 10:50:03 -07002311 RunGit(['cherry-pick', 'FETCH_HEAD'])
2312 print('Committed patch for change %i patchset %i locally.' %
Aaron Gable62619a32017-06-16 08:22:09 -07002313 (parsed_issue_arg.issue, patchset))
2314 print('Note: this created a local commit which does not have '
2315 'the same hash as the one uploaded for review. This will make '
2316 'uploading changes based on top of this branch difficult.\n'
2317 'If you want to do that, use "git cl patch --force" instead.')
2318
Stefan Zagerd08043c2017-10-12 12:07:02 -07002319 if self.GetBranch():
2320 self.SetIssue(parsed_issue_arg.issue)
2321 self.SetPatchset(patchset)
2322 fetched_hash = RunGit(['rev-parse', 'FETCH_HEAD']).strip()
2323 self._GitSetBranchConfigValue('last-upload-hash', fetched_hash)
2324 self._GitSetBranchConfigValue('gerritsquashhash', fetched_hash)
2325 else:
2326 print('WARNING: You are in detached HEAD state.\n'
2327 'The patch has been applied to your checkout, but you will not be '
2328 'able to upload a new patch set to the gerrit issue.\n'
2329 'Try using the \'-b\' option if you would like to work on a '
2330 'branch and/or upload a new patch set.')
2331
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002332 return 0
2333
2334 @staticmethod
2335 def ParseIssueURL(parsed_url):
2336 if not parsed_url.scheme or not parsed_url.scheme.startswith('http'):
2337 return None
Aaron Gable01b91062017-08-24 17:48:40 -07002338 # Gerrit's new UI is https://domain/c/project/+/<issue_number>[/[patchset]]
2339 # But old GWT UI is https://domain/#/c/project/+/<issue_number>[/[patchset]]
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002340 # Short urls like https://domain/<issue_number> can be used, but don't allow
2341 # specifying the patchset (you'd 404), but we allow that here.
2342 if parsed_url.path == '/':
2343 part = parsed_url.fragment
2344 else:
2345 part = parsed_url.path
Bruce Dawson9c062012019-05-02 19:20:28 +00002346 match = re.match(r'(/c(/.*/\+)?)?/(\d+)(/(\d+)?/?)?$', part)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002347 if match:
2348 return _ParsedIssueNumberArgument(
Aaron Gable01b91062017-08-24 17:48:40 -07002349 issue=int(match.group(3)),
2350 patchset=int(match.group(5)) if match.group(5) else None,
Edward Lemurf38bc172019-09-03 21:02:13 +00002351 hostname=parsed_url.netloc)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002352 return None
2353
tandrii16e0b4e2016-06-07 10:34:28 -07002354 def _GerritCommitMsgHookCheck(self, offer_removal):
2355 hook = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
2356 if not os.path.exists(hook):
2357 return
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002358 # Crude attempt to distinguish Gerrit Codereview hook from a potentially
2359 # custom developer-made one.
tandrii16e0b4e2016-06-07 10:34:28 -07002360 data = gclient_utils.FileRead(hook)
2361 if not('From Gerrit Code Review' in data and 'add_ChangeId()' in data):
2362 return
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002363 print('WARNING: You have Gerrit commit-msg hook installed.\n'
qyearsley12fa6ff2016-08-24 09:18:40 -07002364 'It is not necessary for uploading with git cl in squash mode, '
tandrii16e0b4e2016-06-07 10:34:28 -07002365 'and may interfere with it in subtle ways.\n'
2366 'We recommend you remove the commit-msg hook.')
2367 if offer_removal:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002368 if ask_for_explicit_yes('Do you want to remove it now?'):
tandrii16e0b4e2016-06-07 10:34:28 -07002369 gclient_utils.rm_file_or_tree(hook)
2370 print('Gerrit commit-msg hook removed.')
2371 else:
2372 print('OK, will keep Gerrit commit-msg hook in place.')
2373
Edward Lemur1b52d872019-05-09 21:12:12 +00002374 def _CleanUpOldTraces(self):
2375 """Keep only the last |MAX_TRACES| traces."""
2376 try:
2377 traces = sorted([
2378 os.path.join(TRACES_DIR, f)
2379 for f in os.listdir(TRACES_DIR)
2380 if (os.path.isfile(os.path.join(TRACES_DIR, f))
2381 and not f.startswith('tmp'))
2382 ])
2383 traces_to_delete = traces[:-MAX_TRACES]
2384 for trace in traces_to_delete:
Daniel Chengcf6269b2019-05-18 01:02:12 +00002385 os.remove(trace)
Edward Lemur1b52d872019-05-09 21:12:12 +00002386 except OSError:
2387 print('WARNING: Failed to remove old git traces from\n'
2388 ' %s'
2389 'Consider removing them manually.' % TRACES_DIR)
Edward Lemurdc8e23d2019-05-07 00:45:48 +00002390
Edward Lemur5737f022019-05-17 01:24:00 +00002391 def _WriteGitPushTraces(self, trace_name, traces_dir, git_push_metadata):
Edward Lemur1b52d872019-05-09 21:12:12 +00002392 """Zip and write the git push traces stored in traces_dir."""
2393 gclient_utils.safe_makedirs(TRACES_DIR)
Edward Lemur1b52d872019-05-09 21:12:12 +00002394 traces_zip = trace_name + '-traces'
2395 traces_readme = trace_name + '-README'
Michael Mosse7f0b4c2019-05-08 04:36:24 +00002396 # Create a temporary dir to store git config and gitcookies in. It will be
2397 # compressed and stored next to the traces.
2398 git_info_dir = tempfile.mkdtemp()
Edward Lemur1b52d872019-05-09 21:12:12 +00002399 git_info_zip = trace_name + '-git-info'
2400
Edward Lemur5737f022019-05-17 01:24:00 +00002401 git_push_metadata['now'] = datetime_now().strftime('%c')
Eric Boren67c48202019-05-30 16:52:51 +00002402 if sys.stdin.encoding and sys.stdin.encoding != 'utf-8':
sangwoo.ko7a614332019-05-22 02:46:19 +00002403 git_push_metadata['now'] = git_push_metadata['now'].decode(
2404 sys.stdin.encoding)
2405
Edward Lemur1b52d872019-05-09 21:12:12 +00002406 git_push_metadata['trace_name'] = trace_name
2407 gclient_utils.FileWrite(
2408 traces_readme, TRACES_README_FORMAT % git_push_metadata)
2409
2410 # Keep only the first 6 characters of the git hashes on the packet
2411 # trace. This greatly decreases size after compression.
2412 packet_traces = os.path.join(traces_dir, 'trace-packet')
2413 if os.path.isfile(packet_traces):
2414 contents = gclient_utils.FileRead(packet_traces)
2415 gclient_utils.FileWrite(
2416 packet_traces, GIT_HASH_RE.sub(r'\1', contents))
2417 shutil.make_archive(traces_zip, 'zip', traces_dir)
2418
2419 # Collect and compress the git config and gitcookies.
2420 git_config = RunGit(['config', '-l'])
2421 gclient_utils.FileWrite(
2422 os.path.join(git_info_dir, 'git-config'),
2423 git_config)
2424
2425 cookie_auth = gerrit_util.Authenticator.get()
2426 if isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
2427 gitcookies_path = cookie_auth.get_gitcookies_path()
2428 if os.path.isfile(gitcookies_path):
2429 gitcookies = gclient_utils.FileRead(gitcookies_path)
2430 gclient_utils.FileWrite(
2431 os.path.join(git_info_dir, 'gitcookies'),
2432 GITCOOKIES_REDACT_RE.sub('REDACTED', gitcookies))
2433 shutil.make_archive(git_info_zip, 'zip', git_info_dir)
2434
Edward Lemur1b52d872019-05-09 21:12:12 +00002435 gclient_utils.rmtree(git_info_dir)
2436
2437 def _RunGitPushWithTraces(
2438 self, change_desc, refspec, refspec_opts, git_push_metadata):
2439 """Run git push and collect the traces resulting from the execution."""
2440 # Create a temporary directory to store traces in. Traces will be compressed
2441 # and stored in a 'traces' dir inside depot_tools.
2442 traces_dir = tempfile.mkdtemp()
Edward Lemur5737f022019-05-17 01:24:00 +00002443 trace_name = os.path.join(
2444 TRACES_DIR, datetime_now().strftime('%Y%m%dT%H%M%S.%f'))
Edward Lemur0f58ae42019-04-30 17:24:12 +00002445
2446 env = os.environ.copy()
2447 env['GIT_REDACT_COOKIES'] = 'o,SSO,GSSO_Uberproxy'
2448 env['GIT_TR2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Jonathan Nieder9779b142019-05-29 23:19:29 +00002449 env['GIT_TRACE2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002450 env['GIT_TRACE_CURL'] = os.path.join(traces_dir, 'trace-curl')
2451 env['GIT_TRACE_CURL_NO_DATA'] = '1'
2452 env['GIT_TRACE_PACKET'] = os.path.join(traces_dir, 'trace-packet')
2453
2454 try:
2455 push_returncode = 0
Edward Lemur1b52d872019-05-09 21:12:12 +00002456 remote_url = self.GetRemoteUrl()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002457 before_push = time_time()
2458 push_stdout = gclient_utils.CheckCallAndFilter(
Edward Lemur1b52d872019-05-09 21:12:12 +00002459 ['git', 'push', remote_url, refspec],
Edward Lemur0f58ae42019-04-30 17:24:12 +00002460 env=env,
2461 print_stdout=True,
2462 # Flush after every line: useful for seeing progress when running as
2463 # recipe.
2464 filter_fn=lambda _: sys.stdout.flush())
2465 except subprocess2.CalledProcessError as e:
2466 push_returncode = e.returncode
2467 DieWithError('Failed to create a change. Please examine output above '
2468 'for the reason of the failure.\n'
2469 'Hint: run command below to diagnose common Git/Gerrit '
2470 'credential problems:\n'
Edward Lemur5737f022019-05-17 01:24:00 +00002471 ' git cl creds-check\n'
2472 '\n'
2473 'If git-cl is not working correctly, file a bug under the '
2474 'Infra>SDK component including the files below.\n'
2475 'Review the files before upload, since they might contain '
2476 'sensitive information.\n'
2477 'Set the Restrict-View-Google label so that they are not '
2478 'publicly accessible.\n'
2479 + TRACES_MESSAGE % {'trace_name': trace_name},
Edward Lemur0f58ae42019-04-30 17:24:12 +00002480 change_desc)
2481 finally:
2482 execution_time = time_time() - before_push
2483 metrics.collector.add_repeated('sub_commands', {
2484 'command': 'git push',
2485 'execution_time': execution_time,
2486 'exit_code': push_returncode,
2487 'arguments': metrics_utils.extract_known_subcommand_args(refspec_opts),
2488 })
2489
Edward Lemur1b52d872019-05-09 21:12:12 +00002490 git_push_metadata['execution_time'] = execution_time
2491 git_push_metadata['exit_code'] = push_returncode
Edward Lemur5737f022019-05-17 01:24:00 +00002492 self._WriteGitPushTraces(trace_name, traces_dir, git_push_metadata)
Edward Lemur0f58ae42019-04-30 17:24:12 +00002493
Edward Lemur1b52d872019-05-09 21:12:12 +00002494 self._CleanUpOldTraces()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002495 gclient_utils.rmtree(traces_dir)
2496
2497 return push_stdout
2498
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002499 def CMDUploadChange(self, options, git_diff_args, custom_cl_base, change):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002500 """Upload the current branch to Gerrit."""
Mike Frysingera989d552019-08-14 20:51:23 +00002501 if options.squash is None:
tandriia60502f2016-06-20 02:01:53 -07002502 # Load default for user, repo, squash=true, in this order.
2503 options.squash = settings.GetSquashGerritUploads()
tandrii26f3e4e2016-06-10 08:37:04 -07002504
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002505 remote, remote_branch = self.GetRemoteBranch()
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01002506 branch = GetTargetRef(remote, remote_branch, options.target_branch)
Aaron Gableb56ad332017-01-06 15:24:31 -08002507 # This may be None; default fallback value is determined in logic below.
2508 title = options.title
2509
Dominic Battre7d1c4842017-10-27 09:17:28 +02002510 # Extract bug number from branch name.
2511 bug = options.bug
2512 match = re.match(r'(?:bug|fix)[_-]?(\d+)', self.GetBranch())
2513 if not bug and match:
2514 bug = match.group(1)
2515
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002516 if options.squash:
tandrii16e0b4e2016-06-07 10:34:28 -07002517 self._GerritCommitMsgHookCheck(offer_removal=not options.force)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002518 if self.GetIssue():
2519 # Try to get the message from a previous upload.
2520 message = self.GetDescription()
2521 if not message:
2522 DieWithError(
Aaron Gablea45ee112016-11-22 15:14:38 -08002523 'failed to fetch description from current Gerrit change %d\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002524 '%s' % (self.GetIssue(), self.GetIssueURL()))
Aaron Gableb56ad332017-01-06 15:24:31 -08002525 if not title:
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002526 if options.message:
Aaron Gable7303dcb2017-06-07 14:17:32 -07002527 # When uploading a subsequent patchset, -m|--message is taken
2528 # as the patchset title if --title was not provided.
2529 title = options.message.strip()
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002530 else:
2531 default_title = RunGit(
2532 ['show', '-s', '--format=%s', 'HEAD']).strip()
Aaron Gable7303dcb2017-06-07 14:17:32 -07002533 if options.force:
2534 title = default_title
2535 else:
2536 title = ask_for_data(
2537 'Title for patchset [%s]: ' % default_title) or default_title
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002538 change_id = self._GetChangeDetail()['change_id']
2539 while True:
2540 footer_change_ids = git_footers.get_footer_change_id(message)
2541 if footer_change_ids == [change_id]:
2542 break
2543 if not footer_change_ids:
2544 message = git_footers.add_footer_change_id(message, change_id)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002545 print('WARNING: appended missing Change-Id to change description.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002546 continue
2547 # There is already a valid footer but with different or several ids.
2548 # Doing this automatically is non-trivial as we don't want to lose
2549 # existing other footers, yet we want to append just 1 desired
2550 # Change-Id. Thus, just create a new footer, but let user verify the
2551 # new description.
2552 message = '%s\n\nChange-Id: %s' % (message, change_id)
2553 print(
Aaron Gablea45ee112016-11-22 15:14:38 -08002554 'WARNING: change %s has Change-Id footer(s):\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002555 ' %s\n'
Aaron Gablea45ee112016-11-22 15:14:38 -08002556 'but change has Change-Id %s, according to Gerrit.\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002557 'Please, check the proposed correction to the description, '
2558 'and edit it if necessary but keep the "Change-Id: %s" footer\n'
2559 % (self.GetIssue(), '\n '.join(footer_change_ids), change_id,
2560 change_id))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002561 confirm_or_exit(action='edit')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002562 if not options.force:
2563 change_desc = ChangeDescription(message)
Dominic Battre7d1c4842017-10-27 09:17:28 +02002564 change_desc.prompt(bug=bug)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002565 message = change_desc.description
2566 if not message:
2567 DieWithError("Description is empty. Aborting...")
2568 # Continue the while loop.
2569 # Sanity check of this code - we should end up with proper message
2570 # footer.
2571 assert [change_id] == git_footers.get_footer_change_id(message)
2572 change_desc = ChangeDescription(message)
Aaron Gableb56ad332017-01-06 15:24:31 -08002573 else: # if not self.GetIssue()
2574 if options.message:
2575 message = options.message
2576 else:
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002577 message = _create_description_from_log(git_diff_args)
Aaron Gableb56ad332017-01-06 15:24:31 -08002578 if options.title:
2579 message = options.title + '\n\n' + message
2580 change_desc = ChangeDescription(message)
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002581
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002582 if not options.force:
Dominic Battre7d1c4842017-10-27 09:17:28 +02002583 change_desc.prompt(bug=bug)
Aaron Gableb56ad332017-01-06 15:24:31 -08002584 # On first upload, patchset title is always this string, while
2585 # --title flag gets converted to first line of message.
2586 title = 'Initial upload'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002587 if not change_desc.description:
2588 DieWithError("Description is empty. Aborting...")
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002589 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002590 if len(change_ids) > 1:
2591 DieWithError('too many Change-Id footers, at most 1 allowed.')
2592 if not change_ids:
2593 # Generate the Change-Id automatically.
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002594 change_desc.set_description(git_footers.add_footer_change_id(
2595 change_desc.description,
2596 GenerateGerritChangeId(change_desc.description)))
2597 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002598 assert len(change_ids) == 1
2599 change_id = change_ids[0]
2600
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002601 if options.reviewers or options.tbrs or options.add_owners_to:
2602 change_desc.update_reviewers(options.reviewers, options.tbrs,
2603 options.add_owners_to, change)
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002604 if options.preserve_tryjobs:
2605 change_desc.set_preserve_tryjobs()
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002606
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002607 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002608 parent = self._ComputeParent(remote, upstream_branch, custom_cl_base,
2609 options.force, change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002610 tree = RunGit(['rev-parse', 'HEAD:']).strip()
Aaron Gable9a03ae02017-11-03 11:31:07 -07002611 with tempfile.NamedTemporaryFile(delete=False) as desc_tempfile:
2612 desc_tempfile.write(change_desc.description)
2613 desc_tempfile.close()
2614 ref_to_push = RunGit(['commit-tree', tree, '-p', parent,
2615 '-F', desc_tempfile.name]).strip()
2616 os.remove(desc_tempfile.name)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002617 else:
2618 change_desc = ChangeDescription(
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002619 options.message or _create_description_from_log(git_diff_args))
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002620 if not change_desc.description:
2621 DieWithError("Description is empty. Aborting...")
2622
2623 if not git_footers.get_footer_change_id(change_desc.description):
2624 DownloadGerritHook(False)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002625 change_desc.set_description(
2626 self._AddChangeIdToCommitMessage(options, git_diff_args))
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002627 if options.reviewers or options.tbrs or options.add_owners_to:
2628 change_desc.update_reviewers(options.reviewers, options.tbrs,
2629 options.add_owners_to, change)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002630 ref_to_push = 'HEAD'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002631 # For no-squash mode, we assume the remote called "origin" is the one we
2632 # want. It is not worthwhile to support different workflows for
2633 # no-squash mode.
2634 parent = 'origin/%s' % branch
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002635 change_id = git_footers.get_footer_change_id(change_desc.description)[0]
2636
2637 assert change_desc
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00002638 SaveDescriptionBackup(change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002639 commits = RunGitSilent(['rev-list', '%s..%s' % (parent,
2640 ref_to_push)]).splitlines()
2641 if len(commits) > 1:
2642 print('WARNING: This will upload %d commits. Run the following command '
2643 'to see which commits will be uploaded: ' % len(commits))
2644 print('git log %s..%s' % (parent, ref_to_push))
2645 print('You can also use `git squash-branch` to squash these into a '
2646 'single commit.')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002647 confirm_or_exit(action='upload')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002648
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002649 if options.reviewers or options.tbrs or options.add_owners_to:
2650 change_desc.update_reviewers(options.reviewers, options.tbrs,
2651 options.add_owners_to, change)
2652
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002653 reviewers = sorted(change_desc.get_reviewers())
2654 # Add cc's from the CC_LIST and --cc flag (if any).
2655 if not options.private and not options.no_autocc:
2656 cc = self.GetCCList().split(',')
2657 else:
2658 cc = []
2659 if options.cc:
2660 cc.extend(options.cc)
2661 cc = filter(None, [email.strip() for email in cc])
2662 if change_desc.get_cced():
2663 cc.extend(change_desc.get_cced())
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00002664 if self._GetGerritHost() == 'chromium-review.googlesource.com':
2665 valid_accounts = set(reviewers + cc)
2666 # TODO(crbug/877717): relax this for all hosts.
2667 else:
2668 valid_accounts = gerrit_util.ValidAccounts(
2669 self._GetGerritHost(), reviewers + cc)
Andrii Shyshkalovf170af42018-10-30 07:00:44 +00002670 logging.info('accounts %s are recognized, %s invalid',
2671 sorted(valid_accounts),
2672 set(reviewers + cc).difference(set(valid_accounts)))
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002673
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002674 # Extra options that can be specified at push time. Doc:
2675 # https://gerrit-review.googlesource.com/Documentation/user-upload.html
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002676 refspec_opts = []
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002677
Aaron Gable844cf292017-06-28 11:32:59 -07002678 # By default, new changes are started in WIP mode, and subsequent patchsets
2679 # don't send email. At any time, passing --send-mail will mark the change
2680 # ready and send email for that particular patch.
Aaron Gableafd52772017-06-27 16:40:10 -07002681 if options.send_mail:
2682 refspec_opts.append('ready')
Aaron Gable844cf292017-06-28 11:32:59 -07002683 refspec_opts.append('notify=ALL')
Jamie Madill276da0b2018-04-27 14:41:20 -04002684 elif not self.GetIssue() and options.squash:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002685 refspec_opts.append('wip')
Aaron Gableafd52772017-06-27 16:40:10 -07002686 else:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002687 refspec_opts.append('notify=NONE')
Aaron Gable70f4e242017-06-26 10:45:59 -07002688
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002689 # TODO(tandrii): options.message should be posted as a comment
Aaron Gablee5adf612017-07-14 10:43:58 -07002690 # if --send-mail is set on non-initial upload as Rietveld used to do it.
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002691
Aaron Gable9b713dd2016-12-14 16:04:21 -08002692 if title:
Nick Carter8692b182017-11-06 16:30:38 -08002693 # Punctuation and whitespace in |title| must be percent-encoded.
2694 refspec_opts.append('m=' + gerrit_util.PercentEncodeForGitRef(title))
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002695
agablec6787972016-09-09 16:13:34 -07002696 if options.private:
Aaron Gableb02daf02017-05-23 11:53:46 -07002697 refspec_opts.append('private')
agablec6787972016-09-09 16:13:34 -07002698
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002699 for r in sorted(reviewers):
2700 if r in valid_accounts:
2701 refspec_opts.append('r=%s' % r)
2702 reviewers.remove(r)
2703 else:
2704 # TODO(tandrii): this should probably be a hard failure.
2705 print('WARNING: reviewer %s doesn\'t have a Gerrit account, skipping'
2706 % r)
2707 for c in sorted(cc):
2708 # refspec option will be rejected if cc doesn't correspond to an
2709 # account, even though REST call to add such arbitrary cc may succeed.
2710 if c in valid_accounts:
2711 refspec_opts.append('cc=%s' % c)
2712 cc.remove(c)
2713
rmistry9eadede2016-09-19 11:22:43 -07002714 if options.topic:
2715 # Documentation on Gerrit topics is here:
2716 # https://gerrit-review.googlesource.com/Documentation/user-upload.html#topic
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002717 refspec_opts.append('topic=%s' % options.topic)
rmistry9eadede2016-09-19 11:22:43 -07002718
Edward Lemur687ca902018-12-05 02:30:30 +00002719 if options.enable_auto_submit:
2720 refspec_opts.append('l=Auto-Submit+1')
2721 if options.use_commit_queue:
2722 refspec_opts.append('l=Commit-Queue+2')
2723 elif options.cq_dry_run:
2724 refspec_opts.append('l=Commit-Queue+1')
2725
2726 if change_desc.get_reviewers(tbr_only=True):
2727 score = gerrit_util.GetCodeReviewTbrScore(
2728 self._GetGerritHost(),
2729 self._GetGerritProject())
2730 refspec_opts.append('l=Code-Review+%s' % score)
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00002731
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002732 # Gerrit sorts hashtags, so order is not important.
Nodir Turakulov23b82142017-11-16 11:04:25 -08002733 hashtags = {change_desc.sanitize_hash_tag(t) for t in options.hashtags}
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002734 if not self.GetIssue():
Nodir Turakulov23b82142017-11-16 11:04:25 -08002735 hashtags.update(change_desc.get_hash_tags())
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002736 refspec_opts += ['hashtag=%s' % t for t in sorted(hashtags)]
2737
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002738 refspec_suffix = ''
2739 if refspec_opts:
2740 refspec_suffix = '%' + ','.join(refspec_opts)
2741 assert ' ' not in refspec_suffix, (
2742 'spaces not allowed in refspec: "%s"' % refspec_suffix)
2743 refspec = '%s:refs/for/%s%s' % (ref_to_push, branch, refspec_suffix)
2744
Edward Lemur1b52d872019-05-09 21:12:12 +00002745 git_push_metadata = {
2746 'gerrit_host': self._GetGerritHost(),
2747 'title': title or '<untitled>',
2748 'change_id': change_id,
2749 'description': change_desc.description,
2750 }
2751 push_stdout = self._RunGitPushWithTraces(
2752 change_desc, refspec, refspec_opts, git_push_metadata)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002753
2754 if options.squash:
Aaron Gable289b4312017-09-13 14:06:16 -07002755 regex = re.compile(r'remote:\s+https?://[\w\-\.\+\/#]*/(\d+)\s.*')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002756 change_numbers = [m.group(1)
2757 for m in map(regex.match, push_stdout.splitlines())
2758 if m]
2759 if len(change_numbers) != 1:
2760 DieWithError(
2761 ('Created|Updated %d issues on Gerrit, but only 1 expected.\n'
Christopher Lamf732cd52017-01-24 12:40:11 +11002762 'Change-Id: %s') % (len(change_numbers), change_id), change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002763 self.SetIssue(change_numbers[0])
tandrii5d48c322016-08-18 16:19:37 -07002764 self._GitSetBranchConfigValue('gerritsquashhash', ref_to_push)
tandrii88189772016-09-29 04:29:57 -07002765
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002766 if self.GetIssue() and (reviewers or cc):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002767 # GetIssue() is not set in case of non-squash uploads according to tests.
2768 # TODO(agable): non-squash uploads in git cl should be removed.
2769 gerrit_util.AddReviewers(
2770 self._GetGerritHost(),
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00002771 self._GerritChangeIdentifier(),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002772 reviewers, cc,
2773 notify=bool(options.send_mail))
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002774
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002775 return 0
2776
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002777 def _ComputeParent(self, remote, upstream_branch, custom_cl_base, force,
2778 change_desc):
2779 """Computes parent of the generated commit to be uploaded to Gerrit.
2780
2781 Returns revision or a ref name.
2782 """
2783 if custom_cl_base:
2784 # Try to avoid creating additional unintended CLs when uploading, unless
2785 # user wants to take this risk.
2786 local_ref_of_target_remote = self.GetRemoteBranch()[1]
2787 code, _ = RunGitWithCode(['merge-base', '--is-ancestor', custom_cl_base,
2788 local_ref_of_target_remote])
2789 if code == 1:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002790 print('\nWARNING: Manually specified base of this CL `%s` '
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002791 'doesn\'t seem to belong to target remote branch `%s`.\n\n'
2792 'If you proceed with upload, more than 1 CL may be created by '
2793 'Gerrit as a result, in turn confusing or crashing git cl.\n\n'
2794 'If you are certain that specified base `%s` has already been '
2795 'uploaded to Gerrit as another CL, you may proceed.\n' %
2796 (custom_cl_base, local_ref_of_target_remote, custom_cl_base))
2797 if not force:
2798 confirm_or_exit(
2799 'Do you take responsibility for cleaning up potential mess '
2800 'resulting from proceeding with upload?',
2801 action='upload')
2802 return custom_cl_base
2803
Aaron Gablef97e33d2017-03-30 15:44:27 -07002804 if remote != '.':
2805 return self.GetCommonAncestorWithUpstream()
2806
2807 # If our upstream branch is local, we base our squashed commit on its
2808 # squashed version.
2809 upstream_branch_name = scm.GIT.ShortBranchName(upstream_branch)
2810
Aaron Gablef97e33d2017-03-30 15:44:27 -07002811 if upstream_branch_name == 'master':
Aaron Gable0bbd1c22017-05-08 14:37:08 -07002812 return self.GetCommonAncestorWithUpstream()
Aaron Gablef97e33d2017-03-30 15:44:27 -07002813
2814 # Check the squashed hash of the parent.
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002815 # TODO(tandrii): consider checking parent change in Gerrit and using its
2816 # hash if tree hash of latest parent revision (patchset) in Gerrit matches
2817 # the tree hash of the parent branch. The upside is less likely bogus
2818 # requests to reupload parent change just because it's uploadhash is
2819 # missing, yet the downside likely exists, too (albeit unknown to me yet).
Aaron Gablef97e33d2017-03-30 15:44:27 -07002820 parent = RunGit(['config',
2821 'branch.%s.gerritsquashhash' % upstream_branch_name],
2822 error_ok=True).strip()
2823 # Verify that the upstream branch has been uploaded too, otherwise
2824 # Gerrit will create additional CLs when uploading.
2825 if not parent or (RunGitSilent(['rev-parse', upstream_branch + ':']) !=
2826 RunGitSilent(['rev-parse', parent + ':'])):
2827 DieWithError(
2828 '\nUpload upstream branch %s first.\n'
2829 'It is likely that this branch has been rebased since its last '
2830 'upload, so you just need to upload it again.\n'
2831 '(If you uploaded it with --no-squash, then branch dependencies '
2832 'are not supported, and you should reupload with --squash.)'
2833 % upstream_branch_name,
2834 change_desc)
2835 return parent
2836
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002837 def _AddChangeIdToCommitMessage(self, options, args):
2838 """Re-commits using the current message, assumes the commit hook is in
2839 place.
2840 """
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002841 log_desc = options.message or _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002842 git_command = ['commit', '--amend', '-m', log_desc]
2843 RunGit(git_command)
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002844 new_log_desc = _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002845 if git_footers.get_footer_change_id(new_log_desc):
vapiera7fbd5a2016-06-16 09:17:49 -07002846 print('git-cl: Added Change-Id to commit message.')
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002847 return new_log_desc
2848 else:
tandrii@chromium.orgb067ec52016-05-31 15:24:44 +00002849 DieWithError('ERROR: Gerrit commit-msg hook not installed.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002850
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002851 def SetCQState(self, new_state):
2852 """Sets the Commit-Queue label assuming canonical CQ config for Gerrit."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002853 vote_map = {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002854 _CQState.NONE: 0,
2855 _CQState.DRY_RUN: 1,
2856 _CQState.COMMIT: 2,
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002857 }
Aaron Gablefc62f762017-07-17 11:12:07 -07002858 labels = {'Commit-Queue': vote_map[new_state]}
2859 notify = False if new_state == _CQState.DRY_RUN else None
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002860 gerrit_util.SetReview(
2861 self._GetGerritHost(), self._GerritChangeIdentifier(),
2862 labels=labels, notify=notify)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002863
tandriie113dfd2016-10-11 10:20:12 -07002864 def CannotTriggerTryJobReason(self):
tandrii8c5a3532016-11-04 07:52:02 -07002865 try:
2866 data = self._GetChangeDetail()
Aaron Gablea45ee112016-11-22 15:14:38 -08002867 except GerritChangeNotExists:
2868 return 'Gerrit doesn\'t know about your change %s' % self.GetIssue()
tandrii8c5a3532016-11-04 07:52:02 -07002869
2870 if data['status'] in ('ABANDONED', 'MERGED'):
2871 return 'CL %s is closed' % self.GetIssue()
2872
Edward Lemur5b6ae8b2019-09-12 23:27:24 +00002873 def GetGerritChange(self, patchset=None):
2874 """Returns a buildbucket.v2.GerritChange message for the current issue."""
2875 host = urlparse.urlparse(self.GetCodereviewServer()).hostname
2876 issue = self.GetIssue()
tandrii8c5a3532016-11-04 07:52:02 -07002877 patchset = int(patchset or self.GetPatchset())
Edward Lemur5b6ae8b2019-09-12 23:27:24 +00002878 data = self._GetChangeDetail(['ALL_REVISIONS'])
2879
2880 assert host and issue and patchset, 'CL must be uploaded first'
2881
2882 has_patchset = any(
2883 int(revision_data['_number']) == patchset
2884 for revision_data in data['revisions'].itervalues())
2885 if not has_patchset:
Aaron Gablea45ee112016-11-22 15:14:38 -08002886 raise Exception('Patchset %d is not known in Gerrit change %d' %
tandrii8c5a3532016-11-04 07:52:02 -07002887 (patchset, self.GetIssue()))
Edward Lemur5b6ae8b2019-09-12 23:27:24 +00002888
tandrii8c5a3532016-11-04 07:52:02 -07002889 return {
Edward Lemur5b6ae8b2019-09-12 23:27:24 +00002890 'host': host,
2891 'change': issue,
2892 'project': data['project'],
2893 'patchset': patchset,
tandrii8c5a3532016-11-04 07:52:02 -07002894 }
tandriie113dfd2016-10-11 10:20:12 -07002895
tandriide281ae2016-10-12 06:02:30 -07002896 def GetIssueOwner(self):
tandrii8c5a3532016-11-04 07:52:02 -07002897 return self._GetChangeDetail(['DETAILED_ACCOUNTS'])['owner']['email']
tandriide281ae2016-10-12 06:02:30 -07002898
Edward Lemur707d70b2018-02-07 00:50:14 +01002899 def GetReviewers(self):
2900 details = self._GetChangeDetail(['DETAILED_ACCOUNTS'])
Mohamed Heikal171c0742018-11-09 20:38:51 +00002901 return [r['email'] for r in details['reviewers'].get('REVIEWER', [])]
Edward Lemur707d70b2018-02-07 00:50:14 +01002902
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002903
2904_CODEREVIEW_IMPLEMENTATIONS = {
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002905 'gerrit': _GerritChangelistImpl,
2906}
2907
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002908
iannuccie53c9352016-08-17 14:40:40 -07002909def _add_codereview_issue_select_options(parser, extra=""):
2910 _add_codereview_select_options(parser)
2911
2912 text = ('Operate on this issue number instead of the current branch\'s '
2913 'implicit issue.')
2914 if extra:
2915 text += ' '+extra
2916 parser.add_option('-i', '--issue', type=int, help=text)
2917
2918
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002919def _add_codereview_select_options(parser):
Edward Lemurf38bc172019-09-03 21:02:13 +00002920 """Appends --gerrit option to force specific codereview."""
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002921 parser.codereview_group = optparse.OptionGroup(
Edward Lemurf38bc172019-09-03 21:02:13 +00002922 parser, 'DEPRECATED! Codereview override options')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002923 parser.add_option_group(parser.codereview_group)
2924 parser.codereview_group.add_option(
2925 '--gerrit', action='store_true',
Edward Lemurf38bc172019-09-03 21:02:13 +00002926 help='Deprecated. Noop. Do not use.')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002927
2928
2929def _process_codereview_select_options(parser, options):
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002930 options.forced_codereview = None
2931 if options.gerrit:
2932 options.forced_codereview = 'gerrit'
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002933
2934
tandriif9aefb72016-07-01 09:06:51 -07002935def _get_bug_line_values(default_project, bugs):
2936 """Given default_project and comma separated list of bugs, yields bug line
2937 values.
2938
2939 Each bug can be either:
2940 * a number, which is combined with default_project
2941 * string, which is left as is.
2942
2943 This function may produce more than one line, because bugdroid expects one
2944 project per line.
2945
2946 >>> list(_get_bug_line_values('v8', '123,chromium:789'))
2947 ['v8:123', 'chromium:789']
2948 """
2949 default_bugs = []
2950 others = []
2951 for bug in bugs.split(','):
2952 bug = bug.strip()
2953 if bug:
2954 try:
2955 default_bugs.append(int(bug))
2956 except ValueError:
2957 others.append(bug)
2958
2959 if default_bugs:
2960 default_bugs = ','.join(map(str, default_bugs))
2961 if default_project:
2962 yield '%s:%s' % (default_project, default_bugs)
2963 else:
2964 yield default_bugs
2965 for other in sorted(others):
2966 # Don't bother finding common prefixes, CLs with >2 bugs are very very rare.
2967 yield other
2968
2969
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002970class ChangeDescription(object):
2971 """Contains a parsed form of the change description."""
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00002972 R_LINE = r'^[ \t]*(TBR|R)[ \t]*=[ \t]*(.*?)[ \t]*$'
bradnelsond975b302016-10-23 12:20:23 -07002973 CC_LINE = r'^[ \t]*(CC)[ \t]*=[ \t]*(.*?)[ \t]*$'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002974 BUG_LINE = r'^[ \t]*(?:(BUG)[ \t]*=|Bug:)[ \t]*(.*?)[ \t]*$'
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002975 CHERRY_PICK_LINE = r'^\(cherry picked from commit [a-fA-F0-9]{40}\)$'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002976 STRIP_HASH_TAG_PREFIX = r'^(\s*(revert|reland)( "|:)?\s*)*'
2977 BRACKET_HASH_TAG = r'\s*\[([^\[\]]+)\]'
2978 COLON_SEPARATED_HASH_TAG = r'^([a-zA-Z0-9_\- ]+):'
2979 BAD_HASH_TAG_CHUNK = r'[^a-zA-Z0-9]+'
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002980
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002981 def __init__(self, description):
agable@chromium.org42c20792013-09-12 17:34:49 +00002982 self._description_lines = (description or '').strip().splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002983
agable@chromium.org42c20792013-09-12 17:34:49 +00002984 @property # www.logilab.org/ticket/89786
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08002985 def description(self): # pylint: disable=method-hidden
agable@chromium.org42c20792013-09-12 17:34:49 +00002986 return '\n'.join(self._description_lines)
2987
2988 def set_description(self, desc):
2989 if isinstance(desc, basestring):
2990 lines = desc.splitlines()
2991 else:
2992 lines = [line.rstrip() for line in desc]
2993 while lines and not lines[0]:
2994 lines.pop(0)
2995 while lines and not lines[-1]:
2996 lines.pop(-1)
2997 self._description_lines = lines
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002998
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002999 def update_reviewers(self, reviewers, tbrs, add_owners_to=None, change=None):
3000 """Rewrites the R=/TBR= line(s) as a single line each.
3001
3002 Args:
3003 reviewers (list(str)) - list of additional emails to use for reviewers.
3004 tbrs (list(str)) - list of additional emails to use for TBRs.
3005 add_owners_to (None|'R'|'TBR') - Pass to do an OWNERS lookup for files in
3006 the change that are missing OWNER coverage. If this is not None, you
3007 must also pass a value for `change`.
3008 change (Change) - The Change that should be used for OWNERS lookups.
3009 """
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003010 assert isinstance(reviewers, list), reviewers
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003011 assert isinstance(tbrs, list), tbrs
3012
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003013 assert add_owners_to in (None, 'TBR', 'R'), add_owners_to
Robert Iannuccia28592e2017-04-18 13:14:49 -07003014 assert not add_owners_to or change, add_owners_to
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003015
3016 if not reviewers and not tbrs and not add_owners_to:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003017 return
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003018
3019 reviewers = set(reviewers)
3020 tbrs = set(tbrs)
3021 LOOKUP = {
3022 'TBR': tbrs,
3023 'R': reviewers,
3024 }
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003025
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003026 # Get the set of R= and TBR= lines and remove them from the description.
agable@chromium.org42c20792013-09-12 17:34:49 +00003027 regexp = re.compile(self.R_LINE)
3028 matches = [regexp.match(line) for line in self._description_lines]
3029 new_desc = [l for i, l in enumerate(self._description_lines)
3030 if not matches[i]]
3031 self.set_description(new_desc)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003032
agable@chromium.org42c20792013-09-12 17:34:49 +00003033 # Construct new unified R= and TBR= lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003034
3035 # First, update tbrs/reviewers with names from the R=/TBR= lines (if any).
agable@chromium.org42c20792013-09-12 17:34:49 +00003036 for match in matches:
3037 if not match:
3038 continue
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003039 LOOKUP[match.group(1)].update(cleanup_list([match.group(2).strip()]))
3040
3041 # Next, maybe fill in OWNERS coverage gaps to either tbrs/reviewers.
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003042 if add_owners_to:
piman@chromium.org336f9122014-09-04 02:16:55 +00003043 owners_db = owners.Database(change.RepositoryRoot(),
Jochen Eisinger72606f82017-04-04 10:44:18 +02003044 fopen=file, os_path=os.path)
piman@chromium.org336f9122014-09-04 02:16:55 +00003045 missing_files = owners_db.files_not_covered_by(change.LocalPaths(),
Robert Iannucci100aa212017-04-18 17:28:26 -07003046 (tbrs | reviewers))
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003047 LOOKUP[add_owners_to].update(
3048 owners_db.reviewers_for(missing_files, change.author_email))
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003049
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003050 # If any folks ended up in both groups, remove them from tbrs.
3051 tbrs -= reviewers
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003052
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003053 new_r_line = 'R=' + ', '.join(sorted(reviewers)) if reviewers else None
3054 new_tbr_line = 'TBR=' + ', '.join(sorted(tbrs)) if tbrs else None
agable@chromium.org42c20792013-09-12 17:34:49 +00003055
3056 # Put the new lines in the description where the old first R= line was.
3057 line_loc = next((i for i, match in enumerate(matches) if match), -1)
3058 if 0 <= line_loc < len(self._description_lines):
3059 if new_tbr_line:
3060 self._description_lines.insert(line_loc, new_tbr_line)
3061 if new_r_line:
3062 self._description_lines.insert(line_loc, new_r_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003063 else:
agable@chromium.org42c20792013-09-12 17:34:49 +00003064 if new_r_line:
3065 self.append_footer(new_r_line)
3066 if new_tbr_line:
3067 self.append_footer(new_tbr_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003068
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00003069 def set_preserve_tryjobs(self):
3070 """Ensures description footer contains 'Cq-Do-Not-Cancel-Tryjobs: true'."""
3071 footers = git_footers.parse_footers(self.description)
3072 for v in footers.get('Cq-Do-Not-Cancel-Tryjobs', []):
3073 if v.lower() == 'true':
3074 return
3075 self.append_footer('Cq-Do-Not-Cancel-Tryjobs: true')
3076
Aaron Gable3a16ed12017-03-23 10:51:55 -07003077 def prompt(self, bug=None, git_footer=True):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003078 """Asks the user to update the description."""
agable@chromium.org42c20792013-09-12 17:34:49 +00003079 self.set_description([
3080 '# Enter a description of the change.',
3081 '# This will be displayed on the codereview site.',
3082 '# The first line will also be used as the subject of the review.',
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +00003083 '#--------------------This line is 72 characters long'
agable@chromium.org42c20792013-09-12 17:34:49 +00003084 '--------------------',
3085 ] + self._description_lines)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003086
agable@chromium.org42c20792013-09-12 17:34:49 +00003087 regexp = re.compile(self.BUG_LINE)
Jonas Termansend0f79112019-03-22 15:28:26 +00003088 prefix = settings.GetBugPrefix()
agable@chromium.org42c20792013-09-12 17:34:49 +00003089 if not any((regexp.match(line) for line in self._description_lines)):
tandriif9aefb72016-07-01 09:06:51 -07003090 values = list(_get_bug_line_values(prefix, bug or '')) or [prefix]
Aaron Gable3a16ed12017-03-23 10:51:55 -07003091 if git_footer:
3092 self.append_footer('Bug: %s' % ', '.join(values))
3093 else:
3094 for value in values:
3095 self.append_footer('BUG=%s' % value)
tandriif9aefb72016-07-01 09:06:51 -07003096
agable@chromium.org42c20792013-09-12 17:34:49 +00003097 content = gclient_utils.RunEditor(self.description, True,
jbroman@chromium.org615a2622013-05-03 13:20:14 +00003098 git_editor=settings.GetGitEditor())
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00003099 if not content:
3100 DieWithError('Running editor failed')
agable@chromium.org42c20792013-09-12 17:34:49 +00003101 lines = content.splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003102
Bruce Dawson2377b012018-01-11 16:46:49 -08003103 # Strip off comments and default inserted "Bug:" line.
3104 clean_lines = [line.rstrip() for line in lines if not
Jonas Termansend0f79112019-03-22 15:28:26 +00003105 (line.startswith('#') or
3106 line.rstrip() == "Bug:" or
3107 line.rstrip() == "Bug: " + prefix)]
agable@chromium.org42c20792013-09-12 17:34:49 +00003108 if not clean_lines:
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00003109 DieWithError('No CL description, aborting')
agable@chromium.org42c20792013-09-12 17:34:49 +00003110 self.set_description(clean_lines)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003111
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003112 def append_footer(self, line):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00003113 """Adds a footer line to the description.
3114
3115 Differentiates legacy "KEY=xxx" footers (used to be called tags) and
3116 Gerrit's footers in the form of "Footer-Key: footer any value" and ensures
3117 that Gerrit footers are always at the end.
3118 """
3119 parsed_footer_line = git_footers.parse_footer(line)
3120 if parsed_footer_line:
3121 # Line is a gerrit footer in the form: Footer-Key: any value.
3122 # Thus, must be appended observing Gerrit footer rules.
3123 self.set_description(
3124 git_footers.add_footer(self.description,
3125 key=parsed_footer_line[0],
3126 value=parsed_footer_line[1]))
3127 return
3128
3129 if not self._description_lines:
3130 self._description_lines.append(line)
3131 return
3132
3133 top_lines, gerrit_footers, _ = git_footers.split_footers(self.description)
3134 if gerrit_footers:
3135 # git_footers.split_footers ensures that there is an empty line before
3136 # actual (gerrit) footers, if any. We have to keep it that way.
3137 assert top_lines and top_lines[-1] == ''
3138 top_lines, separator = top_lines[:-1], top_lines[-1:]
3139 else:
3140 separator = [] # No need for separator if there are no gerrit_footers.
3141
3142 prev_line = top_lines[-1] if top_lines else ''
3143 if (not presubmit_support.Change.TAG_LINE_RE.match(prev_line) or
3144 not presubmit_support.Change.TAG_LINE_RE.match(line)):
3145 top_lines.append('')
3146 top_lines.append(line)
3147 self._description_lines = top_lines + separator + gerrit_footers
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003148
tandrii99a72f22016-08-17 14:33:24 -07003149 def get_reviewers(self, tbr_only=False):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003150 """Retrieves the list of reviewers."""
agable@chromium.org42c20792013-09-12 17:34:49 +00003151 matches = [re.match(self.R_LINE, line) for line in self._description_lines]
tandrii99a72f22016-08-17 14:33:24 -07003152 reviewers = [match.group(2).strip()
3153 for match in matches
3154 if match and (not tbr_only or match.group(1).upper() == 'TBR')]
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003155 return cleanup_list(reviewers)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003156
bradnelsond975b302016-10-23 12:20:23 -07003157 def get_cced(self):
3158 """Retrieves the list of reviewers."""
3159 matches = [re.match(self.CC_LINE, line) for line in self._description_lines]
3160 cced = [match.group(2).strip() for match in matches if match]
3161 return cleanup_list(cced)
3162
Nodir Turakulov23b82142017-11-16 11:04:25 -08003163 def get_hash_tags(self):
3164 """Extracts and sanitizes a list of Gerrit hashtags."""
3165 subject = (self._description_lines or ('',))[0]
3166 subject = re.sub(
3167 self.STRIP_HASH_TAG_PREFIX, '', subject, flags=re.IGNORECASE)
3168
3169 tags = []
3170 start = 0
3171 bracket_exp = re.compile(self.BRACKET_HASH_TAG)
3172 while True:
3173 m = bracket_exp.match(subject, start)
3174 if not m:
3175 break
3176 tags.append(self.sanitize_hash_tag(m.group(1)))
3177 start = m.end()
3178
3179 if not tags:
3180 # Try "Tag: " prefix.
3181 m = re.match(self.COLON_SEPARATED_HASH_TAG, subject)
3182 if m:
3183 tags.append(self.sanitize_hash_tag(m.group(1)))
3184 return tags
3185
3186 @classmethod
3187 def sanitize_hash_tag(cls, tag):
3188 """Returns a sanitized Gerrit hash tag.
3189
3190 A sanitized hashtag can be used as a git push refspec parameter value.
3191 """
3192 return re.sub(cls.BAD_HASH_TAG_CHUNK, '-', tag).strip('-').lower()
3193
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003194 def update_with_git_number_footers(self, parent_hash, parent_msg, dest_ref):
3195 """Updates this commit description given the parent.
3196
3197 This is essentially what Gnumbd used to do.
3198 Consult https://goo.gl/WMmpDe for more details.
3199 """
3200 assert parent_msg # No, orphan branch creation isn't supported.
3201 assert parent_hash
3202 assert dest_ref
3203 parent_footer_map = git_footers.parse_footers(parent_msg)
3204 # This will also happily parse svn-position, which GnumbD is no longer
3205 # supporting. While we'd generate correct footers, the verifier plugin
3206 # installed in Gerrit will block such commit (ie git push below will fail).
3207 parent_position = git_footers.get_position(parent_footer_map)
3208
3209 # Cherry-picks may have last line obscuring their prior footers,
3210 # from git_footers perspective. This is also what Gnumbd did.
3211 cp_line = None
3212 if (self._description_lines and
3213 re.match(self.CHERRY_PICK_LINE, self._description_lines[-1])):
3214 cp_line = self._description_lines.pop()
3215
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003216 top_lines, footer_lines, _ = git_footers.split_footers(self.description)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003217
3218 # Original-ify all Cr- footers, to avoid re-lands, cherry-picks, or just
3219 # user interference with actual footers we'd insert below.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003220 for i, line in enumerate(footer_lines):
3221 k, v = git_footers.parse_footer(line) or (None, None)
3222 if k and k.startswith('Cr-'):
3223 footer_lines[i] = '%s: %s' % ('Cr-Original-' + k[len('Cr-'):], v)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003224
3225 # Add Position and Lineage footers based on the parent.
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +01003226 lineage = list(reversed(parent_footer_map.get('Cr-Branched-From', [])))
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003227 if parent_position[0] == dest_ref:
3228 # Same branch as parent.
3229 number = int(parent_position[1]) + 1
3230 else:
3231 number = 1 # New branch, and extra lineage.
3232 lineage.insert(0, '%s-%s@{#%d}' % (parent_hash, parent_position[0],
3233 int(parent_position[1])))
3234
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003235 footer_lines.append('Cr-Commit-Position: %s@{#%d}' % (dest_ref, number))
3236 footer_lines.extend('Cr-Branched-From: %s' % v for v in lineage)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003237
3238 self._description_lines = top_lines
3239 if cp_line:
3240 self._description_lines.append(cp_line)
3241 if self._description_lines[-1] != '':
3242 self._description_lines.append('') # Ensure footer separator.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003243 self._description_lines.extend(footer_lines)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003244
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003245
Aaron Gablea1bab272017-04-11 16:38:18 -07003246def get_approving_reviewers(props, disapproval=False):
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003247 """Retrieves the reviewers that approved a CL from the issue properties with
3248 messages.
3249
3250 Note that the list may contain reviewers that are not committer, thus are not
3251 considered by the CQ.
Aaron Gablea1bab272017-04-11 16:38:18 -07003252
3253 If disapproval is True, instead returns reviewers who 'not lgtm'd the CL.
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003254 """
Aaron Gablea1bab272017-04-11 16:38:18 -07003255 approval_type = 'disapproval' if disapproval else 'approval'
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003256 return sorted(
3257 set(
3258 message['sender']
3259 for message in props['messages']
Aaron Gablea1bab272017-04-11 16:38:18 -07003260 if message[approval_type] and message['sender'] in props['reviewers']
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003261 )
3262 )
3263
3264
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003265def FindCodereviewSettingsFile(filename='codereview.settings'):
3266 """Finds the given file starting in the cwd and going up.
3267
3268 Only looks up to the top of the repository unless an
3269 'inherit-review-settings-ok' file exists in the root of the repository.
3270 """
3271 inherit_ok_file = 'inherit-review-settings-ok'
3272 cwd = os.getcwd()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00003273 root = settings.GetRoot()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003274 if os.path.isfile(os.path.join(root, inherit_ok_file)):
3275 root = '/'
3276 while True:
3277 if filename in os.listdir(cwd):
3278 if os.path.isfile(os.path.join(cwd, filename)):
3279 return open(os.path.join(cwd, filename))
3280 if cwd == root:
3281 break
3282 cwd = os.path.dirname(cwd)
3283
3284
3285def LoadCodereviewSettingsFromFile(fileobj):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003286 """Parses a codereview.settings file and updates hooks."""
maruel@chromium.org99ac1c52012-01-16 14:52:12 +00003287 keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003288
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003289 def SetProperty(name, setting, unset_error_ok=False):
3290 fullname = 'rietveld.' + name
3291 if setting in keyvals:
3292 RunGit(['config', fullname, keyvals[setting]])
3293 else:
3294 RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok)
3295
tandrii48df5812016-10-17 03:55:37 -07003296 if not keyvals.get('GERRIT_HOST', False):
3297 SetProperty('server', 'CODE_REVIEW_SERVER')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003298 # Only server setting is required. Other settings can be absent.
3299 # In that case, we ignore errors raised during option deletion attempt.
3300 SetProperty('cc', 'CC_LIST', unset_error_ok=True)
3301 SetProperty('tree-status-url', 'STATUS', unset_error_ok=True)
3302 SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True)
rmistry@google.com90752582014-01-14 21:04:50 +00003303 SetProperty('bug-prefix', 'BUG_PREFIX', unset_error_ok=True)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003304 SetProperty('cpplint-regex', 'LINT_REGEX', unset_error_ok=True)
3305 SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +00003306 SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK',
3307 unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003308
ukai@chromium.org7044efc2013-11-28 01:51:21 +00003309 if 'GERRIT_HOST' in keyvals:
ukai@chromium.orge8077812012-02-03 03:41:46 +00003310 RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']])
ukai@chromium.orge8077812012-02-03 03:41:46 +00003311
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003312 if 'GERRIT_SQUASH_UPLOADS' in keyvals:
tandrii8dd81ea2016-06-16 13:24:23 -07003313 RunGit(['config', 'gerrit.squash-uploads',
3314 keyvals['GERRIT_SQUASH_UPLOADS']])
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003315
tandrii@chromium.org28253532016-04-14 13:46:56 +00003316 if 'GERRIT_SKIP_ENSURE_AUTHENTICATED' in keyvals:
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00003317 RunGit(['config', 'gerrit.skip-ensure-authenticated',
tandrii@chromium.org28253532016-04-14 13:46:56 +00003318 keyvals['GERRIT_SKIP_ENSURE_AUTHENTICATED']])
3319
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003320 if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01003321 # should be of the form
3322 # PUSH_URL_CONFIG: url.ssh://gitrw.chromium.org.pushinsteadof
3323 # ORIGIN_URL_CONFIG: http://src.chromium.org/git
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003324 RunGit(['config', keyvals['PUSH_URL_CONFIG'],
3325 keyvals['ORIGIN_URL_CONFIG']])
3326
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003327
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003328def urlretrieve(source, destination):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003329 """Downloads a network object to a local file, like urllib.urlretrieve.
3330
3331 This is necessary because urllib is broken for SSL connections via a proxy.
3332 """
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003333 with open(destination, 'w') as f:
3334 f.write(urllib2.urlopen(source).read())
3335
3336
ukai@chromium.org712d6102013-11-27 00:52:58 +00003337def hasSheBang(fname):
3338 """Checks fname is a #! script."""
3339 with open(fname) as f:
3340 return f.read(2).startswith('#!')
3341
3342
bpastene@chromium.org917f0ff2016-04-05 00:45:30 +00003343# TODO(bpastene) Remove once a cleaner fix to crbug.com/600473 presents itself.
3344def DownloadHooks(*args, **kwargs):
3345 pass
3346
3347
tandrii@chromium.org18630d62016-03-04 12:06:02 +00003348def DownloadGerritHook(force):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003349 """Downloads and installs a Gerrit commit-msg hook.
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003350
3351 Args:
3352 force: True to update hooks. False to install hooks if not present.
3353 """
3354 if not settings.GetIsGerrit():
3355 return
ukai@chromium.org712d6102013-11-27 00:52:58 +00003356 src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg'
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003357 dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
3358 if not os.access(dst, os.X_OK):
3359 if os.path.exists(dst):
3360 if not force:
3361 return
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003362 try:
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003363 urlretrieve(src, dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003364 if not hasSheBang(dst):
3365 DieWithError('Not a script: %s\n'
3366 'You need to download from\n%s\n'
3367 'into .git/hooks/commit-msg and '
3368 'chmod +x .git/hooks/commit-msg' % (dst, src))
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003369 os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
3370 except Exception:
3371 if os.path.exists(dst):
3372 os.remove(dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003373 DieWithError('\nFailed to download hooks.\n'
3374 'You need to download from\n%s\n'
3375 'into .git/hooks/commit-msg and '
3376 'chmod +x .git/hooks/commit-msg' % src)
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003377
3378
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003379class _GitCookiesChecker(object):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003380 """Provides facilities for validating and suggesting fixes to .gitcookies."""
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003381
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003382 _GOOGLESOURCE = 'googlesource.com'
3383
3384 def __init__(self):
3385 # Cached list of [host, identity, source], where source is either
3386 # .gitcookies or .netrc.
3387 self._all_hosts = None
3388
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003389 def ensure_configured_gitcookies(self):
3390 """Runs checks and suggests fixes to make git use .gitcookies from default
3391 path."""
3392 default = gerrit_util.CookiesAuthenticator.get_gitcookies_path()
3393 configured_path = RunGitSilent(
3394 ['config', '--global', 'http.cookiefile']).strip()
Andrii Shyshkalov1e250cd2017-05-10 15:39:31 +02003395 configured_path = os.path.expanduser(configured_path)
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003396 if configured_path:
3397 self._ensure_default_gitcookies_path(configured_path, default)
3398 else:
3399 self._configure_gitcookies_path(default)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003400
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003401 @staticmethod
3402 def _ensure_default_gitcookies_path(configured_path, default_path):
3403 assert configured_path
3404 if configured_path == default_path:
3405 print('git is already configured to use your .gitcookies from %s' %
3406 configured_path)
3407 return
3408
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003409 print('WARNING: You have configured custom path to .gitcookies: %s\n'
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003410 'Gerrit and other depot_tools expect .gitcookies at %s\n' %
3411 (configured_path, default_path))
3412
3413 if not os.path.exists(configured_path):
3414 print('However, your configured .gitcookies file is missing.')
3415 confirm_or_exit('Reconfigure git to use default .gitcookies?',
3416 action='reconfigure')
3417 RunGit(['config', '--global', 'http.cookiefile', default_path])
3418 return
3419
3420 if os.path.exists(default_path):
3421 print('WARNING: default .gitcookies file already exists %s' %
3422 default_path)
3423 DieWithError('Please delete %s manually and re-run git cl creds-check' %
3424 default_path)
3425
3426 confirm_or_exit('Move existing .gitcookies to default location?',
3427 action='move')
3428 shutil.move(configured_path, default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003429 RunGit(['config', '--global', 'http.cookiefile', default_path])
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003430 print('Moved and reconfigured git to use .gitcookies from %s' %
3431 default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003432
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003433 @staticmethod
3434 def _configure_gitcookies_path(default_path):
3435 netrc_path = gerrit_util.CookiesAuthenticator.get_netrc_path()
3436 if os.path.exists(netrc_path):
3437 print('You seem to be using outdated .netrc for git credentials: %s' %
3438 netrc_path)
3439 print('This tool will guide you through setting up recommended '
3440 '.gitcookies store for git credentials.\n'
3441 '\n'
3442 'IMPORTANT: If something goes wrong and you decide to go back, do:\n'
3443 ' git config --global --unset http.cookiefile\n'
3444 ' mv %s %s.backup\n\n' % (default_path, default_path))
3445 confirm_or_exit(action='setup .gitcookies')
3446 RunGit(['config', '--global', 'http.cookiefile', default_path])
3447 print('Configured git to use .gitcookies from %s' % default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003448
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003449 def get_hosts_with_creds(self, include_netrc=False):
3450 if self._all_hosts is None:
3451 a = gerrit_util.CookiesAuthenticator()
3452 self._all_hosts = [
3453 (h, u, s)
3454 for h, u, s in itertools.chain(
3455 ((h, u, '.netrc') for h, (u, _, _) in a.netrc.hosts.iteritems()),
3456 ((h, u, '.gitcookies') for h, (u, _) in a.gitcookies.iteritems())
3457 )
3458 if h.endswith(self._GOOGLESOURCE)
3459 ]
3460
3461 if include_netrc:
3462 return self._all_hosts
3463 return [(h, u, s) for h, u, s in self._all_hosts if s != '.netrc']
3464
3465 def print_current_creds(self, include_netrc=False):
3466 hosts = sorted(self.get_hosts_with_creds(include_netrc=include_netrc))
3467 if not hosts:
3468 print('No Git/Gerrit credentials found')
3469 return
3470 lengths = [max(map(len, (row[i] for row in hosts))) for i in xrange(3)]
3471 header = [('Host', 'User', 'Which file'),
3472 ['=' * l for l in lengths]]
3473 for row in (header + hosts):
3474 print('\t'.join((('%%+%ds' % l) % s)
3475 for l, s in zip(lengths, row)))
3476
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003477 @staticmethod
3478 def _parse_identity(identity):
Lei Zhangd3f769a2017-12-15 15:16:14 -08003479 """Parses identity "git-<username>.domain" into <username> and domain."""
3480 # Special case: usernames that contain ".", which are generally not
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02003481 # distinguishable from sub-domains. But we do know typical domains:
3482 if identity.endswith('.chromium.org'):
3483 domain = 'chromium.org'
3484 username = identity[:-len('.chromium.org')]
3485 else:
3486 username, domain = identity.split('.', 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003487 if username.startswith('git-'):
3488 username = username[len('git-'):]
3489 return username, domain
3490
3491 def _get_usernames_of_domain(self, domain):
3492 """Returns list of usernames referenced by .gitcookies in a given domain."""
3493 identities_by_domain = {}
3494 for _, identity, _ in self.get_hosts_with_creds():
3495 username, domain = self._parse_identity(identity)
3496 identities_by_domain.setdefault(domain, []).append(username)
3497 return identities_by_domain.get(domain)
3498
3499 def _canonical_git_googlesource_host(self, host):
3500 """Normalizes Gerrit hosts (with '-review') to Git host."""
3501 assert host.endswith(self._GOOGLESOURCE)
3502 # Prefix doesn't include '.' at the end.
3503 prefix = host[:-(1 + len(self._GOOGLESOURCE))]
3504 if prefix.endswith('-review'):
3505 prefix = prefix[:-len('-review')]
3506 return prefix + '.' + self._GOOGLESOURCE
3507
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003508 def _canonical_gerrit_googlesource_host(self, host):
3509 git_host = self._canonical_git_googlesource_host(host)
3510 prefix = git_host.split('.', 1)[0]
3511 return prefix + '-review.' + self._GOOGLESOURCE
3512
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003513 def _get_counterpart_host(self, host):
3514 assert host.endswith(self._GOOGLESOURCE)
3515 git = self._canonical_git_googlesource_host(host)
3516 gerrit = self._canonical_gerrit_googlesource_host(git)
3517 return git if gerrit == host else gerrit
3518
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003519 def has_generic_host(self):
3520 """Returns whether generic .googlesource.com has been configured.
3521
3522 Chrome Infra recommends to use explicit ${host}.googlesource.com instead.
3523 """
3524 for host, _, _ in self.get_hosts_with_creds(include_netrc=False):
3525 if host == '.' + self._GOOGLESOURCE:
3526 return True
3527 return False
3528
3529 def _get_git_gerrit_identity_pairs(self):
3530 """Returns map from canonic host to pair of identities (Git, Gerrit).
3531
3532 One of identities might be None, meaning not configured.
3533 """
3534 host_to_identity_pairs = {}
3535 for host, identity, _ in self.get_hosts_with_creds():
3536 canonical = self._canonical_git_googlesource_host(host)
3537 pair = host_to_identity_pairs.setdefault(canonical, [None, None])
3538 idx = 0 if canonical == host else 1
3539 pair[idx] = identity
3540 return host_to_identity_pairs
3541
3542 def get_partially_configured_hosts(self):
3543 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003544 (host if i1 else self._canonical_gerrit_googlesource_host(host))
3545 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().iteritems()
3546 if None in (i1, i2) and host != '.' + self._GOOGLESOURCE)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003547
3548 def get_conflicting_hosts(self):
3549 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003550 host
3551 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().iteritems()
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003552 if None not in (i1, i2) and i1 != i2)
3553
3554 def get_duplicated_hosts(self):
3555 counters = collections.Counter(h for h, _, _ in self.get_hosts_with_creds())
3556 return set(host for host, count in counters.iteritems() if count > 1)
3557
3558 _EXPECTED_HOST_IDENTITY_DOMAINS = {
3559 'chromium.googlesource.com': 'chromium.org',
3560 'chrome-internal.googlesource.com': 'google.com',
3561 }
3562
3563 def get_hosts_with_wrong_identities(self):
3564 """Finds hosts which **likely** reference wrong identities.
3565
3566 Note: skips hosts which have conflicting identities for Git and Gerrit.
3567 """
3568 hosts = set()
3569 for host, expected in self._EXPECTED_HOST_IDENTITY_DOMAINS.iteritems():
3570 pair = self._get_git_gerrit_identity_pairs().get(host)
3571 if pair and pair[0] == pair[1]:
3572 _, domain = self._parse_identity(pair[0])
3573 if domain != expected:
3574 hosts.add(host)
3575 return hosts
3576
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003577 @staticmethod
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003578 def _format_hosts(hosts, extra_column_func=None):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003579 hosts = sorted(hosts)
3580 assert hosts
3581 if extra_column_func is None:
3582 extras = [''] * len(hosts)
3583 else:
3584 extras = [extra_column_func(host) for host in hosts]
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003585 tmpl = '%%-%ds %%-%ds' % (max(map(len, hosts)), max(map(len, extras)))
3586 lines = []
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003587 for he in zip(hosts, extras):
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003588 lines.append(tmpl % he)
3589 return lines
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003590
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003591 def _find_problems(self):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003592 if self.has_generic_host():
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003593 yield ('.googlesource.com wildcard record detected',
3594 ['Chrome Infrastructure team recommends to list full host names '
3595 'explicitly.'],
3596 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003597
3598 dups = self.get_duplicated_hosts()
3599 if dups:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003600 yield ('The following hosts were defined twice',
3601 self._format_hosts(dups),
3602 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003603
3604 partial = self.get_partially_configured_hosts()
3605 if partial:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003606 yield ('Credentials should come in pairs for Git and Gerrit hosts. '
3607 'These hosts are missing',
3608 self._format_hosts(partial, lambda host: 'but %s defined' %
3609 self._get_counterpart_host(host)),
3610 partial)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003611
3612 conflicting = self.get_conflicting_hosts()
3613 if conflicting:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003614 yield ('The following Git hosts have differing credentials from their '
3615 'Gerrit counterparts',
3616 self._format_hosts(conflicting, lambda host: '%s vs %s' %
3617 tuple(self._get_git_gerrit_identity_pairs()[host])),
3618 conflicting)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003619
3620 wrong = self.get_hosts_with_wrong_identities()
3621 if wrong:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003622 yield ('These hosts likely use wrong identity',
3623 self._format_hosts(wrong, lambda host: '%s but %s recommended' %
3624 (self._get_git_gerrit_identity_pairs()[host][0],
3625 self._EXPECTED_HOST_IDENTITY_DOMAINS[host])),
3626 wrong)
3627
3628 def find_and_report_problems(self):
3629 """Returns True if there was at least one problem, else False."""
3630 found = False
3631 bad_hosts = set()
3632 for title, sublines, hosts in self._find_problems():
3633 if not found:
3634 found = True
3635 print('\n\n.gitcookies problem report:\n')
3636 bad_hosts.update(hosts or [])
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003637 print(' %s%s' % (title, (':' if sublines else '')))
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003638 if sublines:
3639 print()
3640 print(' %s' % '\n '.join(sublines))
3641 print()
3642
3643 if bad_hosts:
3644 assert found
3645 print(' You can manually remove corresponding lines in your %s file and '
3646 'visit the following URLs with correct account to generate '
3647 'correct credential lines:\n' %
3648 gerrit_util.CookiesAuthenticator.get_gitcookies_path())
3649 print(' %s' % '\n '.join(sorted(set(
3650 gerrit_util.CookiesAuthenticator().get_new_password_url(
3651 self._canonical_git_googlesource_host(host))
3652 for host in bad_hosts
3653 ))))
3654 return found
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003655
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003656
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003657@metrics.collector.collect_metrics('git cl creds-check')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003658def CMDcreds_check(parser, args):
3659 """Checks credentials and suggests changes."""
3660 _, _ = parser.parse_args(args)
3661
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003662 # Code below checks .gitcookies. Abort if using something else.
3663 authn = gerrit_util.Authenticator.get()
3664 if not isinstance(authn, gerrit_util.CookiesAuthenticator):
3665 if isinstance(authn, gerrit_util.GceAuthenticator):
3666 DieWithError(
3667 'This command is not designed for GCE, are you on a bot?\n'
3668 'If you need to run this on GCE, export SKIP_GCE_AUTH_FOR_GIT=1 '
3669 'in your env.')
Aaron Gabled10ca0e2017-09-11 11:24:10 -07003670 DieWithError(
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003671 'This command is not designed for bot environment. It checks '
3672 '~/.gitcookies file not generally used on bots.')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003673
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003674 checker = _GitCookiesChecker()
3675 checker.ensure_configured_gitcookies()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003676
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003677 print('Your .netrc and .gitcookies have credentials for these hosts:')
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003678 checker.print_current_creds(include_netrc=True)
3679
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003680 if not checker.find_and_report_problems():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003681 print('\nNo problems detected in your .gitcookies file.')
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003682 return 0
3683 return 1
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003684
3685
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003686@metrics.collector.collect_metrics('git cl baseurl')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003687def CMDbaseurl(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003688 """Gets or sets base-url for this branch."""
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003689 branchref = RunGit(['symbolic-ref', 'HEAD']).strip()
3690 branch = ShortBranchName(branchref)
3691 _, args = parser.parse_args(args)
3692 if not args:
vapiera7fbd5a2016-06-16 09:17:49 -07003693 print('Current base-url:')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003694 return RunGit(['config', 'branch.%s.base-url' % branch],
3695 error_ok=False).strip()
3696 else:
vapiera7fbd5a2016-06-16 09:17:49 -07003697 print('Setting base-url to %s' % args[0])
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003698 return RunGit(['config', 'branch.%s.base-url' % branch, args[0]],
3699 error_ok=False).strip()
3700
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003701
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003702def color_for_status(status):
3703 """Maps a Changelist status to color, for CMDstatus and other tools."""
3704 return {
Aaron Gable9ab38c62017-04-06 14:36:33 -07003705 'unsent': Fore.YELLOW,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003706 'waiting': Fore.BLUE,
3707 'reply': Fore.YELLOW,
Aaron Gable9ab38c62017-04-06 14:36:33 -07003708 'not lgtm': Fore.RED,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003709 'lgtm': Fore.GREEN,
3710 'commit': Fore.MAGENTA,
3711 'closed': Fore.CYAN,
3712 'error': Fore.WHITE,
3713 }.get(status, Fore.WHITE)
3714
tandrii@chromium.org04ea8462016-04-25 19:51:21 +00003715
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003716def get_cl_statuses(changes, fine_grained, max_processes=None):
3717 """Returns a blocking iterable of (cl, status) for given branches.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003718
3719 If fine_grained is true, this will fetch CL statuses from the server.
3720 Otherwise, simply indicate if there's a matching url for the given branches.
3721
3722 If max_processes is specified, it is used as the maximum number of processes
3723 to spawn to fetch CL status from the server. Otherwise 1 process per branch is
3724 spawned.
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003725
3726 See GetStatus() for a list of possible statuses.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003727 """
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003728 if not changes:
3729 raise StopIteration()
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003730
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003731 if not fine_grained:
3732 # Fast path which doesn't involve querying codereview servers.
Aaron Gablea1bab272017-04-11 16:38:18 -07003733 # Do not use get_approving_reviewers(), since it requires an HTTP request.
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003734 for cl in changes:
3735 yield (cl, 'waiting' if cl.GetIssueURL() else 'error')
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003736 return
3737
3738 # First, sort out authentication issues.
3739 logging.debug('ensuring credentials exist')
3740 for cl in changes:
3741 cl.EnsureAuthenticated(force=False, refresh=True)
3742
3743 def fetch(cl):
3744 try:
3745 return (cl, cl.GetStatus())
3746 except:
3747 # See http://crbug.com/629863.
Andrii Shyshkalov98824232018-04-19 11:37:15 -07003748 logging.exception('failed to fetch status for cl %s:', cl.GetIssue())
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003749 raise
3750
3751 threads_count = len(changes)
3752 if max_processes:
3753 threads_count = max(1, min(threads_count, max_processes))
3754 logging.debug('querying %d CLs using %d threads', len(changes), threads_count)
3755
3756 pool = ThreadPool(threads_count)
3757 fetched_cls = set()
3758 try:
3759 it = pool.imap_unordered(fetch, changes).__iter__()
3760 while True:
3761 try:
3762 cl, status = it.next(timeout=5)
3763 except multiprocessing.TimeoutError:
3764 break
3765 fetched_cls.add(cl)
3766 yield cl, status
3767 finally:
3768 pool.close()
3769
3770 # Add any branches that failed to fetch.
3771 for cl in set(changes) - fetched_cls:
3772 yield (cl, 'error')
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003773
rmistry@google.com2dd99862015-06-22 12:22:18 +00003774
3775def upload_branch_deps(cl, args):
3776 """Uploads CLs of local branches that are dependents of the current branch.
3777
3778 If the local branch dependency tree looks like:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003779
3780 test1 -> test2.1 -> test3.1
3781 -> test3.2
3782 -> test2.2 -> test3.3
rmistry@google.com2dd99862015-06-22 12:22:18 +00003783
3784 and you run "git cl upload --dependencies" from test1 then "git cl upload" is
3785 run on the dependent branches in this order:
3786 test2.1, test3.1, test3.2, test2.2, test3.3
3787
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003788 Note: This function does not rebase your local dependent branches. Use it
3789 when you make a change to the parent branch that will not conflict
3790 with its dependent branches, and you would like their dependencies
3791 updated in Rietveld.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003792 """
3793 if git_common.is_dirty_git_tree('upload-branch-deps'):
3794 return 1
3795
3796 root_branch = cl.GetBranch()
3797 if root_branch is None:
3798 DieWithError('Can\'t find dependent branches from detached HEAD state. '
3799 'Get on a branch!')
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00003800 if not cl.GetIssue():
rmistry@google.com2dd99862015-06-22 12:22:18 +00003801 DieWithError('Current branch does not have an uploaded CL. We cannot set '
3802 'patchset dependencies without an uploaded CL.')
3803
3804 branches = RunGit(['for-each-ref',
3805 '--format=%(refname:short) %(upstream:short)',
3806 'refs/heads'])
3807 if not branches:
3808 print('No local branches found.')
3809 return 0
3810
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003811 # Create a dictionary of all local branches to the branches that are
3812 # dependent on it.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003813 tracked_to_dependents = collections.defaultdict(list)
3814 for b in branches.splitlines():
3815 tokens = b.split()
3816 if len(tokens) == 2:
3817 branch_name, tracked = tokens
3818 tracked_to_dependents[tracked].append(branch_name)
3819
vapiera7fbd5a2016-06-16 09:17:49 -07003820 print()
3821 print('The dependent local branches of %s are:' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003822 dependents = []
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003823
rmistry@google.com2dd99862015-06-22 12:22:18 +00003824 def traverse_dependents_preorder(branch, padding=''):
3825 dependents_to_process = tracked_to_dependents.get(branch, [])
3826 padding += ' '
3827 for dependent in dependents_to_process:
vapiera7fbd5a2016-06-16 09:17:49 -07003828 print('%s%s' % (padding, dependent))
rmistry@google.com2dd99862015-06-22 12:22:18 +00003829 dependents.append(dependent)
3830 traverse_dependents_preorder(dependent, padding)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003831
rmistry@google.com2dd99862015-06-22 12:22:18 +00003832 traverse_dependents_preorder(root_branch)
vapiera7fbd5a2016-06-16 09:17:49 -07003833 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003834
3835 if not dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003836 print('There are no dependent local branches for %s' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003837 return 0
3838
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01003839 confirm_or_exit('This command will checkout all dependent branches and run '
3840 '"git cl upload".', action='continue')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003841
rmistry@google.com2dd99862015-06-22 12:22:18 +00003842 # Record all dependents that failed to upload.
3843 failures = {}
3844 # Go through all dependents, checkout the branch and upload.
3845 try:
3846 for dependent_branch in dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003847 print()
3848 print('--------------------------------------')
3849 print('Running "git cl upload" from %s:' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003850 RunGit(['checkout', '-q', dependent_branch])
vapiera7fbd5a2016-06-16 09:17:49 -07003851 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003852 try:
3853 if CMDupload(OptionParser(), args) != 0:
vapiera7fbd5a2016-06-16 09:17:49 -07003854 print('Upload failed for %s!' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003855 failures[dependent_branch] = 1
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003856 except: # pylint: disable=bare-except
rmistry@google.com2dd99862015-06-22 12:22:18 +00003857 failures[dependent_branch] = 1
vapiera7fbd5a2016-06-16 09:17:49 -07003858 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003859 finally:
3860 # Swap back to the original root branch.
3861 RunGit(['checkout', '-q', root_branch])
3862
vapiera7fbd5a2016-06-16 09:17:49 -07003863 print()
3864 print('Upload complete for dependent branches!')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003865 for dependent_branch in dependents:
3866 upload_status = 'failed' if failures.get(dependent_branch) else 'succeeded'
vapiera7fbd5a2016-06-16 09:17:49 -07003867 print(' %s : %s' % (dependent_branch, upload_status))
3868 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003869
3870 return 0
3871
3872
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003873@metrics.collector.collect_metrics('git cl archive')
kmarshall3bff56b2016-06-06 18:31:47 -07003874def CMDarchive(parser, args):
3875 """Archives and deletes branches associated with closed changelists."""
3876 parser.add_option(
3877 '-j', '--maxjobs', action='store', type=int,
kmarshall9249e012016-08-23 12:02:16 -07003878 help='The maximum number of jobs to use when retrieving review status.')
kmarshall3bff56b2016-06-06 18:31:47 -07003879 parser.add_option(
3880 '-f', '--force', action='store_true',
3881 help='Bypasses the confirmation prompt.')
kmarshall9249e012016-08-23 12:02:16 -07003882 parser.add_option(
3883 '-d', '--dry-run', action='store_true',
3884 help='Skip the branch tagging and removal steps.')
3885 parser.add_option(
3886 '-t', '--notags', action='store_true',
3887 help='Do not tag archived branches. '
3888 'Note: local commit history may be lost.')
kmarshall3bff56b2016-06-06 18:31:47 -07003889
kmarshall3bff56b2016-06-06 18:31:47 -07003890 options, args = parser.parse_args(args)
3891 if args:
3892 parser.error('Unsupported args: %s' % ' '.join(args))
kmarshall3bff56b2016-06-06 18:31:47 -07003893
3894 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
3895 if not branches:
3896 return 0
3897
vapiera7fbd5a2016-06-16 09:17:49 -07003898 print('Finding all branches associated with closed issues...')
Edward Lemur934836a2019-09-09 20:16:54 +00003899 changes = [Changelist(branchref=b)
3900 for b in branches.splitlines()]
kmarshall3bff56b2016-06-06 18:31:47 -07003901 alignment = max(5, max(len(c.GetBranch()) for c in changes))
3902 statuses = get_cl_statuses(changes,
3903 fine_grained=True,
3904 max_processes=options.maxjobs)
3905 proposal = [(cl.GetBranch(),
3906 'git-cl-archived-%s-%s' % (cl.GetIssue(), cl.GetBranch()))
3907 for cl, status in statuses
Andrii Shyshkalov51bdf8c2018-10-18 01:07:58 +00003908 if status in ('closed', 'rietveld-not-supported')]
kmarshall3bff56b2016-06-06 18:31:47 -07003909 proposal.sort()
3910
3911 if not proposal:
vapiera7fbd5a2016-06-16 09:17:49 -07003912 print('No branches with closed codereview issues found.')
kmarshall3bff56b2016-06-06 18:31:47 -07003913 return 0
3914
3915 current_branch = GetCurrentBranch()
3916
vapiera7fbd5a2016-06-16 09:17:49 -07003917 print('\nBranches with closed issues that will be archived:\n')
kmarshall9249e012016-08-23 12:02:16 -07003918 if options.notags:
3919 for next_item in proposal:
3920 print(' ' + next_item[0])
3921 else:
3922 print('%*s | %s' % (alignment, 'Branch name', 'Archival tag name'))
3923 for next_item in proposal:
3924 print('%*s %s' % (alignment, next_item[0], next_item[1]))
kmarshall3bff56b2016-06-06 18:31:47 -07003925
kmarshall9249e012016-08-23 12:02:16 -07003926 # Quit now on precondition failure or if instructed by the user, either
3927 # via an interactive prompt or by command line flags.
3928 if options.dry_run:
3929 print('\nNo changes were made (dry run).\n')
3930 return 0
3931 elif any(branch == current_branch for branch, _ in proposal):
kmarshall3bff56b2016-06-06 18:31:47 -07003932 print('You are currently on a branch \'%s\' which is associated with a '
3933 'closed codereview issue, so archive cannot proceed. Please '
3934 'checkout another branch and run this command again.' %
3935 current_branch)
3936 return 1
kmarshall9249e012016-08-23 12:02:16 -07003937 elif not options.force:
sergiyb4a5ecbe2016-06-20 09:46:00 -07003938 answer = ask_for_data('\nProceed with deletion (Y/n)? ').lower()
3939 if answer not in ('y', ''):
vapiera7fbd5a2016-06-16 09:17:49 -07003940 print('Aborted.')
kmarshall3bff56b2016-06-06 18:31:47 -07003941 return 1
3942
3943 for branch, tagname in proposal:
kmarshall9249e012016-08-23 12:02:16 -07003944 if not options.notags:
3945 RunGit(['tag', tagname, branch])
kmarshall3bff56b2016-06-06 18:31:47 -07003946 RunGit(['branch', '-D', branch])
kmarshall9249e012016-08-23 12:02:16 -07003947
vapiera7fbd5a2016-06-16 09:17:49 -07003948 print('\nJob\'s done!')
kmarshall3bff56b2016-06-06 18:31:47 -07003949
3950 return 0
3951
3952
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003953@metrics.collector.collect_metrics('git cl status')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003954def CMDstatus(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003955 """Show status of changelists.
3956
3957 Colors are used to tell the state of the CL unless --fast is used:
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003958 - Blue waiting for review
Aaron Gable9ab38c62017-04-06 14:36:33 -07003959 - Yellow waiting for you to reply to review, or not yet sent
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003960 - Green LGTM'ed
Aaron Gable9ab38c62017-04-06 14:36:33 -07003961 - Red 'not LGTM'ed
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00003962 - Magenta in the CQ
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003963 - Cyan was committed, branch can be deleted
Aaron Gable9ab38c62017-04-06 14:36:33 -07003964 - White error, or unknown status
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003965
3966 Also see 'git cl comments'.
3967 """
Alan Cuttera3be9a52019-03-04 18:50:33 +00003968 parser.add_option(
3969 '--no-branch-color',
3970 action='store_true',
3971 help='Disable colorized branch names')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003972 parser.add_option('--field',
phajdan.jr289d03e2016-08-16 08:21:06 -07003973 help='print only specific field (desc|id|patch|status|url)')
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003974 parser.add_option('-f', '--fast', action='store_true',
3975 help='Do not retrieve review status')
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003976 parser.add_option(
3977 '-j', '--maxjobs', action='store', type=int,
3978 help='The maximum number of jobs to use when retrieving review status')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003979
iannuccie53c9352016-08-17 14:40:40 -07003980 _add_codereview_issue_select_options(
3981 parser, 'Must be in conjunction with --field.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003982 options, args = parser.parse_args(args)
Edward Lemurf38bc172019-09-03 21:02:13 +00003983 _process_codereview_select_options(parser, options)
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003984 if args:
3985 parser.error('Unsupported args: %s' % args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003986
iannuccie53c9352016-08-17 14:40:40 -07003987 if options.issue is not None and not options.field:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00003988 parser.error('--field must be specified with --issue.')
iannucci3c972b92016-08-17 13:24:10 -07003989
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003990 if options.field:
Edward Lemur934836a2019-09-09 20:16:54 +00003991 cl = Changelist(issue=options.issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003992 if options.field.startswith('desc'):
vapiera7fbd5a2016-06-16 09:17:49 -07003993 print(cl.GetDescription())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003994 elif options.field == 'id':
3995 issueid = cl.GetIssue()
3996 if issueid:
vapiera7fbd5a2016-06-16 09:17:49 -07003997 print(issueid)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003998 elif options.field == 'patch':
Aaron Gablee8856ee2017-12-07 12:41:46 -08003999 patchset = cl.GetMostRecentPatchset()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004000 if patchset:
vapiera7fbd5a2016-06-16 09:17:49 -07004001 print(patchset)
phajdan.jr289d03e2016-08-16 08:21:06 -07004002 elif options.field == 'status':
4003 print(cl.GetStatus())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004004 elif options.field == 'url':
4005 url = cl.GetIssueURL()
4006 if url:
vapiera7fbd5a2016-06-16 09:17:49 -07004007 print(url)
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00004008 return 0
4009
4010 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
4011 if not branches:
4012 print('No local branch found.')
4013 return 0
4014
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004015 changes = [
Edward Lemur934836a2019-09-09 20:16:54 +00004016 Changelist(branchref=b)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004017 for b in branches.splitlines()]
vapiera7fbd5a2016-06-16 09:17:49 -07004018 print('Branches associated with reviews:')
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004019 output = get_cl_statuses(changes,
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004020 fine_grained=not options.fast,
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004021 max_processes=options.maxjobs)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00004022
Daniel McArdlea23bf592019-02-12 00:25:12 +00004023 current_branch = GetCurrentBranch()
4024
4025 def FormatBranchName(branch, colorize=False):
4026 """Simulates 'git branch' behavior. Colorizes and prefixes branch name with
4027 an asterisk when it is the current branch."""
4028
4029 asterisk = ""
4030 color = Fore.RESET
4031 if branch == current_branch:
4032 asterisk = "* "
4033 color = Fore.GREEN
4034 branch_name = ShortBranchName(branch)
4035
4036 if colorize:
4037 return asterisk + color + branch_name + Fore.RESET
Daniel McArdle452a49f2019-02-14 17:28:31 +00004038 return asterisk + branch_name
4039
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004040 branch_statuses = {}
Daniel McArdlea23bf592019-02-12 00:25:12 +00004041
4042 alignment = max(5, max(len(FormatBranchName(c.GetBranch())) for c in changes))
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004043 for cl in sorted(changes, key=lambda c: c.GetBranch()):
4044 branch = cl.GetBranch()
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004045 while branch not in branch_statuses:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004046 c, status = output.next()
4047 branch_statuses[c.GetBranch()] = status
4048 status = branch_statuses.pop(branch)
4049 url = cl.GetIssueURL()
4050 if url and (not status or status == 'error'):
4051 # The issue probably doesn't exist anymore.
4052 url += ' (broken)'
4053
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00004054 color = color_for_status(status)
maruel@chromium.org885f6512013-07-27 02:17:26 +00004055 reset = Fore.RESET
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00004056 if not setup_color.IS_TTY:
maruel@chromium.org885f6512013-07-27 02:17:26 +00004057 color = ''
4058 reset = ''
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00004059 status_str = '(%s)' % status if status else ''
Daniel McArdle452a49f2019-02-14 17:28:31 +00004060
Alan Cuttera3be9a52019-03-04 18:50:33 +00004061 branch_display = FormatBranchName(branch)
4062 padding = ' ' * (alignment - len(branch_display))
4063 if not options.no_branch_color:
4064 branch_display = FormatBranchName(branch, colorize=True)
Daniel McArdle452a49f2019-02-14 17:28:31 +00004065
Alan Cuttera3be9a52019-03-04 18:50:33 +00004066 print(' %s : %s%s %s%s' % (padding + branch_display, color, url,
4067 status_str, reset))
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01004068
vapiera7fbd5a2016-06-16 09:17:49 -07004069 print()
Daniel McArdlea23bf592019-02-12 00:25:12 +00004070 print('Current branch: %s' % current_branch)
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01004071 for cl in changes:
Daniel McArdlea23bf592019-02-12 00:25:12 +00004072 if cl.GetBranch() == current_branch:
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01004073 break
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00004074 if not cl.GetIssue():
vapiera7fbd5a2016-06-16 09:17:49 -07004075 print('No issue assigned.')
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00004076 return 0
vapiera7fbd5a2016-06-16 09:17:49 -07004077 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
maruel@chromium.org85616e02014-07-28 15:37:55 +00004078 if not options.fast:
vapiera7fbd5a2016-06-16 09:17:49 -07004079 print('Issue description:')
4080 print(cl.GetDescription(pretty=True))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004081 return 0
4082
4083
maruel@chromium.org39c0b222013-08-17 16:57:01 +00004084def colorize_CMDstatus_doc():
4085 """To be called once in main() to add colors to git cl status help."""
4086 colors = [i for i in dir(Fore) if i[0].isupper()]
4087
4088 def colorize_line(line):
4089 for color in colors:
4090 if color in line.upper():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004091 # Extract whitespace first and the leading '-'.
maruel@chromium.org39c0b222013-08-17 16:57:01 +00004092 indent = len(line) - len(line.lstrip(' ')) + 1
4093 return line[:indent] + getattr(Fore, color) + line[indent:] + Fore.RESET
4094 return line
4095
4096 lines = CMDstatus.__doc__.splitlines()
4097 CMDstatus.__doc__ = '\n'.join(colorize_line(l) for l in lines)
4098
4099
phajdan.jre328cf92016-08-22 04:12:17 -07004100def write_json(path, contents):
Stefan Zager1306bd02017-06-22 19:26:46 -07004101 if path == '-':
4102 json.dump(contents, sys.stdout)
4103 else:
4104 with open(path, 'w') as f:
4105 json.dump(contents, f)
phajdan.jre328cf92016-08-22 04:12:17 -07004106
4107
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004108@subcommand.usage('[issue_number]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004109@metrics.collector.collect_metrics('git cl issue')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004110def CMDissue(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004111 """Sets or displays the current code review issue number.
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004112
4113 Pass issue number 0 to clear the current issue.
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004114 """
dnj@chromium.org406c4402015-03-03 17:22:28 +00004115 parser.add_option('-r', '--reverse', action='store_true',
4116 help='Lookup the branch(es) for the specified issues. If '
4117 'no issues are specified, all branches with mapped '
4118 'issues will be listed.')
Stefan Zager1306bd02017-06-22 19:26:46 -07004119 parser.add_option('--json',
4120 help='Path to JSON output file, or "-" for stdout.')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004121 _add_codereview_select_options(parser)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004122 options, args = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004123 _process_codereview_select_options(parser, options)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004124
dnj@chromium.org406c4402015-03-03 17:22:28 +00004125 if options.reverse:
4126 branches = RunGit(['for-each-ref', 'refs/heads',
Aaron Gablead64abd2017-12-04 09:49:13 -08004127 '--format=%(refname)']).splitlines()
dnj@chromium.org406c4402015-03-03 17:22:28 +00004128 # Reverse issue lookup.
4129 issue_branch_map = {}
Daniel Bratellb56a43a2018-09-06 15:49:03 +00004130
4131 git_config = {}
4132 for config in RunGit(['config', '--get-regexp',
4133 r'branch\..*issue']).splitlines():
4134 name, _space, val = config.partition(' ')
4135 git_config[name] = val
4136
dnj@chromium.org406c4402015-03-03 17:22:28 +00004137 for branch in branches:
Daniel Bratellb56a43a2018-09-06 15:49:03 +00004138 for cls in _CODEREVIEW_IMPLEMENTATIONS.values():
4139 config_key = _git_branch_config_key(ShortBranchName(branch),
4140 cls.IssueConfigKey())
4141 issue = git_config.get(config_key)
4142 if issue:
4143 issue_branch_map.setdefault(int(issue), []).append(branch)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004144 if not args:
4145 args = sorted(issue_branch_map.iterkeys())
phajdan.jre328cf92016-08-22 04:12:17 -07004146 result = {}
dnj@chromium.org406c4402015-03-03 17:22:28 +00004147 for issue in args:
Lei Zhang5a368d42019-03-25 23:18:19 +00004148 try:
4149 issue_num = int(issue)
4150 except ValueError:
4151 print('ERROR cannot parse issue number: %s' % issue, file=sys.stderr)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004152 continue
Lei Zhang5a368d42019-03-25 23:18:19 +00004153 result[issue_num] = issue_branch_map.get(issue_num)
vapiera7fbd5a2016-06-16 09:17:49 -07004154 print('Branch for issue number %s: %s' % (
Lei Zhang5a368d42019-03-25 23:18:19 +00004155 issue, ', '.join(issue_branch_map.get(issue_num) or ('None',))))
phajdan.jre328cf92016-08-22 04:12:17 -07004156 if options.json:
4157 write_json(options.json, result)
Aaron Gable78753da2017-06-15 10:35:49 -07004158 return 0
4159
4160 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00004161 issue = ParseIssueNumberArgument(args[0])
Aaron Gable78753da2017-06-15 10:35:49 -07004162 if not issue.valid:
4163 DieWithError('Pass a url or number to set the issue, 0 to unset it, '
4164 'or no argument to list it.\n'
4165 'Maybe you want to run git cl status?')
Edward Lemurf38bc172019-09-03 21:02:13 +00004166 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07004167 cl.SetIssue(issue.issue)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004168 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00004169 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07004170 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
4171 if options.json:
4172 write_json(options.json, {
4173 'issue': cl.GetIssue(),
4174 'issue_url': cl.GetIssueURL(),
4175 })
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004176 return 0
4177
4178
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004179@metrics.collector.collect_metrics('git cl comments')
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004180def CMDcomments(parser, args):
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004181 """Shows or posts review comments for any changelist."""
4182 parser.add_option('-a', '--add-comment', dest='comment',
4183 help='comment to add to an issue')
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00004184 parser.add_option('-p', '--publish', action='store_true',
4185 help='marks CL as ready and sends comment to reviewers')
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01004186 parser.add_option('-i', '--issue', dest='issue',
Edward Lemurf38bc172019-09-03 21:02:13 +00004187 help='review issue id (defaults to current issue).')
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07004188 parser.add_option('-m', '--machine-readable', dest='readable',
4189 action='store_false', default=True,
4190 help='output comments in a format compatible with '
4191 'editor parsing')
smut@google.comc85ac942015-09-15 16:34:43 +00004192 parser.add_option('-j', '--json-file',
Stefan Zager1306bd02017-06-22 19:26:46 -07004193 help='File to write JSON summary to, or "-" for stdout')
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004194 _add_codereview_select_options(parser)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004195 options, args = parser.parse_args(args)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004196 _process_codereview_select_options(parser, options)
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004197
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004198 issue = None
4199 if options.issue:
4200 try:
4201 issue = int(options.issue)
4202 except ValueError:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004203 DieWithError('A review issue ID is expected to be a number.')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004204
Edward Lemur934836a2019-09-09 20:16:54 +00004205 cl = Changelist(issue=issue)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004206
4207 if options.comment:
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00004208 cl.AddComment(options.comment, options.publish)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004209 return 0
4210
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07004211 summary = sorted(cl.GetCommentsSummary(readable=options.readable),
4212 key=lambda c: c.date)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004213 for comment in summary:
4214 if comment.disapproval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004215 color = Fore.RED
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004216 elif comment.approval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004217 color = Fore.GREEN
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004218 elif comment.sender == cl.GetIssueOwner():
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004219 color = Fore.MAGENTA
Quinten Yearsley0e617c02019-02-20 00:37:03 +00004220 elif comment.autogenerated:
4221 color = Fore.CYAN
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004222 else:
4223 color = Fore.BLUE
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004224 print('\n%s%s %s%s\n%s' % (
4225 color,
4226 comment.date.strftime('%Y-%m-%d %H:%M:%S UTC'),
4227 comment.sender,
4228 Fore.RESET,
4229 '\n'.join(' ' + l for l in comment.message.strip().splitlines())))
4230
smut@google.comc85ac942015-09-15 16:34:43 +00004231 if options.json_file:
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004232 def pre_serialize(c):
4233 dct = c.__dict__.copy()
4234 dct['date'] = dct['date'].strftime('%Y-%m-%d %H:%M:%S.%f')
4235 return dct
Leszek Swirski45b20c42018-09-17 17:05:26 +00004236 write_json(options.json_file, map(pre_serialize, summary))
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004237 return 0
4238
4239
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004240@subcommand.usage('[codereview url or issue id]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004241@metrics.collector.collect_metrics('git cl description')
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004242def CMDdescription(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004243 """Brings up the editor for the current CL's description."""
smut@google.com34fb6b12015-07-13 20:03:26 +00004244 parser.add_option('-d', '--display', action='store_true',
4245 help='Display the description instead of opening an editor')
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004246 parser.add_option('-n', '--new-description',
dnjba1b0f32016-09-02 12:37:42 -07004247 help='New description to set for this issue (- for stdin, '
4248 '+ to load from local commit HEAD)')
dsansomee2d6fd92016-09-08 00:10:47 -07004249 parser.add_option('-f', '--force', action='store_true',
4250 help='Delete any unpublished Gerrit edits for this issue '
4251 'without prompting')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004252
4253 _add_codereview_select_options(parser)
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004254 options, args = parser.parse_args(args)
4255 _process_codereview_select_options(parser, options)
4256
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004257 target_issue_arg = None
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004258 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00004259 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004260 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004261 parser.error('Invalid issue ID or URL.')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004262
Edward Lemur934836a2019-09-09 20:16:54 +00004263 kwargs = {}
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004264 detected_codereview_from_url = False
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004265 if target_issue_arg:
4266 kwargs['issue'] = target_issue_arg.issue
4267 kwargs['codereview_host'] = target_issue_arg.hostname
Edward Lemurf38bc172019-09-03 21:02:13 +00004268 if not args[0].isdigit() and not options.forced_codereview:
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004269 detected_codereview_from_url = True
martiniss6eda05f2016-06-30 10:18:35 -07004270
4271 cl = Changelist(**kwargs)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004272 if not cl.GetIssue():
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004273 assert not detected_codereview_from_url
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004274 DieWithError('This branch has no associated changelist.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004275
4276 if detected_codereview_from_url:
Edward Lemurf38bc172019-09-03 21:02:13 +00004277 logging.info('canonical issue/change URL: %s\n', cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004278
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004279 description = ChangeDescription(cl.GetDescription())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004280
smut@google.com34fb6b12015-07-13 20:03:26 +00004281 if options.display:
vapiera7fbd5a2016-06-16 09:17:49 -07004282 print(description.description)
smut@google.com34fb6b12015-07-13 20:03:26 +00004283 return 0
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004284
4285 if options.new_description:
4286 text = options.new_description
4287 if text == '-':
4288 text = '\n'.join(l.rstrip() for l in sys.stdin)
dnjba1b0f32016-09-02 12:37:42 -07004289 elif text == '+':
4290 base_branch = cl.GetCommonAncestorWithUpstream()
4291 change = cl.GetChange(base_branch, None, local_description=True)
4292 text = change.FullDescriptionText()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004293
4294 description.set_description(text)
4295 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00004296 description.prompt()
Andrii Shyshkalov680253d2017-03-15 21:07:36 +01004297 if cl.GetDescription().strip() != description.description:
dsansomee2d6fd92016-09-08 00:10:47 -07004298 cl.UpdateDescription(description.description, force=options.force)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004299 return 0
4300
4301
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004302@metrics.collector.collect_metrics('git cl lint')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004303def CMDlint(parser, args):
4304 """Runs cpplint on the current changelist."""
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004305 parser.add_option('--filter', action='append', metavar='-x,+y',
4306 help='Comma-separated list of cpplint\'s category-filters')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004307 options, args = parser.parse_args(args)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004308
4309 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08004310 # pylint: disable=protected-access
thestig@chromium.org44202a22014-03-11 19:22:18 +00004311 try:
4312 import cpplint
4313 import cpplint_chromium
4314 except ImportError:
vapiera7fbd5a2016-06-16 09:17:49 -07004315 print('Your depot_tools is missing cpplint.py and/or cpplint_chromium.py.')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004316 return 1
4317
4318 # Change the current working directory before calling lint so that it
4319 # shows the correct base.
4320 previous_cwd = os.getcwd()
4321 os.chdir(settings.GetRoot())
4322 try:
Edward Lemur934836a2019-09-09 20:16:54 +00004323 cl = Changelist()
thestig@chromium.org44202a22014-03-11 19:22:18 +00004324 change = cl.GetChange(cl.GetCommonAncestorWithUpstream(), None)
4325 files = [f.LocalPath() for f in change.AffectedFiles()]
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004326 if not files:
vapiera7fbd5a2016-06-16 09:17:49 -07004327 print('Cannot lint an empty CL')
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004328 return 1
thestig@chromium.org44202a22014-03-11 19:22:18 +00004329
4330 # Process cpplints arguments if any.
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004331 command = args + files
4332 if options.filter:
4333 command = ['--filter=' + ','.join(options.filter)] + command
4334 filenames = cpplint.ParseArguments(command)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004335
4336 white_regex = re.compile(settings.GetLintRegex())
4337 black_regex = re.compile(settings.GetLintIgnoreRegex())
4338 extra_check_functions = [cpplint_chromium.CheckPointerDeclarationWhitespace]
4339 for filename in filenames:
4340 if white_regex.match(filename):
4341 if black_regex.match(filename):
vapiera7fbd5a2016-06-16 09:17:49 -07004342 print('Ignoring file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004343 else:
4344 cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level,
4345 extra_check_functions)
4346 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004347 print('Skipping file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004348 finally:
4349 os.chdir(previous_cwd)
vapiera7fbd5a2016-06-16 09:17:49 -07004350 print('Total errors found: %d\n' % cpplint._cpplint_state.error_count)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004351 if cpplint._cpplint_state.error_count != 0:
4352 return 1
4353 return 0
4354
4355
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004356@metrics.collector.collect_metrics('git cl presubmit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004357def CMDpresubmit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004358 """Runs presubmit tests on the current changelist."""
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004359 parser.add_option('-u', '--upload', action='store_true',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004360 help='Run upload hook instead of the push hook')
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004361 parser.add_option('-f', '--force', action='store_true',
sbc@chromium.org495ad152012-09-04 23:07:42 +00004362 help='Run checks even if tree is dirty')
Aaron Gable8076c282017-11-29 14:39:41 -08004363 parser.add_option('--all', action='store_true',
4364 help='Run checks against all files, not just modified ones')
Edward Lesmes8e282792018-04-03 18:50:29 -04004365 parser.add_option('--parallel', action='store_true',
4366 help='Run all tests specified by input_api.RunTests in all '
4367 'PRESUBMIT files in parallel.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004368 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004369
sbc@chromium.org71437c02015-04-09 19:29:40 +00004370 if not options.force and git_common.is_dirty_git_tree('presubmit'):
vapiera7fbd5a2016-06-16 09:17:49 -07004371 print('use --force to check even if tree is dirty.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004372 return 1
4373
Edward Lemur934836a2019-09-09 20:16:54 +00004374 cl = Changelist()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004375 if args:
4376 base_branch = args[0]
4377 else:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00004378 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004379 base_branch = cl.GetCommonAncestorWithUpstream()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004380
Aaron Gable8076c282017-11-29 14:39:41 -08004381 if options.all:
4382 base_change = cl.GetChange(base_branch, None)
4383 files = [('M', f) for f in base_change.AllFiles()]
4384 change = presubmit_support.GitChange(
4385 base_change.Name(),
4386 base_change.FullDescriptionText(),
4387 base_change.RepositoryRoot(),
4388 files,
4389 base_change.issue,
4390 base_change.patchset,
4391 base_change.author_email,
4392 base_change._upstream)
4393 else:
4394 change = cl.GetChange(base_branch, None)
4395
ilevy@chromium.org051ad0e2013-03-04 21:57:34 +00004396 cl.RunHook(
4397 committing=not options.upload,
4398 may_prompt=False,
4399 verbose=options.verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04004400 change=change,
4401 parallel=options.parallel)
dpranke@chromium.org0a2bb372011-03-25 01:16:22 +00004402 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004403
4404
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004405def GenerateGerritChangeId(message):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004406 """Returns the Change ID footer value (Ixxxxxx...xxx).
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004407
4408 Works the same way as
4409 https://gerrit-review.googlesource.com/tools/hooks/commit-msg
4410 but can be called on demand on all platforms.
4411
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004412 The basic idea is to generate git hash of a state of the tree, original
4413 commit message, author/committer info and timestamps.
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004414 """
4415 lines = []
4416 tree_hash = RunGitSilent(['write-tree'])
4417 lines.append('tree %s' % tree_hash.strip())
4418 code, parent = RunGitWithCode(['rev-parse', 'HEAD~0'], suppress_stderr=False)
4419 if code == 0:
4420 lines.append('parent %s' % parent.strip())
4421 author = RunGitSilent(['var', 'GIT_AUTHOR_IDENT'])
4422 lines.append('author %s' % author.strip())
4423 committer = RunGitSilent(['var', 'GIT_COMMITTER_IDENT'])
4424 lines.append('committer %s' % committer.strip())
4425 lines.append('')
4426 # Note: Gerrit's commit-hook actually cleans message of some lines and
4427 # whitespace. This code is not doing this, but it clearly won't decrease
4428 # entropy.
4429 lines.append(message)
4430 change_hash = RunCommand(['git', 'hash-object', '-t', 'commit', '--stdin'],
Raul Tambreb946b232019-03-26 14:48:46 +00004431 stdin=('\n'.join(lines)).encode())
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004432 return 'I%s' % change_hash.strip()
4433
4434
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01004435def GetTargetRef(remote, remote_branch, target_branch):
wittman@chromium.org455dc922015-01-26 20:15:50 +00004436 """Computes the remote branch ref to use for the CL.
4437
4438 Args:
4439 remote (str): The git remote for the CL.
4440 remote_branch (str): The git remote branch for the CL.
4441 target_branch (str): The target branch specified by the user.
wittman@chromium.org455dc922015-01-26 20:15:50 +00004442 """
4443 if not (remote and remote_branch):
4444 return None
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004445
wittman@chromium.org455dc922015-01-26 20:15:50 +00004446 if target_branch:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004447 # Canonicalize branch references to the equivalent local full symbolic
wittman@chromium.org455dc922015-01-26 20:15:50 +00004448 # refs, which are then translated into the remote full symbolic refs
4449 # below.
4450 if '/' not in target_branch:
4451 remote_branch = 'refs/remotes/%s/%s' % (remote, target_branch)
4452 else:
4453 prefix_replacements = (
4454 ('^((refs/)?remotes/)?branch-heads/', 'refs/remotes/branch-heads/'),
4455 ('^((refs/)?remotes/)?%s/' % remote, 'refs/remotes/%s/' % remote),
4456 ('^(refs/)?heads/', 'refs/remotes/%s/' % remote),
4457 )
4458 match = None
4459 for regex, replacement in prefix_replacements:
4460 match = re.search(regex, target_branch)
4461 if match:
4462 remote_branch = target_branch.replace(match.group(0), replacement)
4463 break
4464 if not match:
4465 # This is a branch path but not one we recognize; use as-is.
4466 remote_branch = target_branch
rmistry@google.comc68112d2015-03-03 12:48:06 +00004467 elif remote_branch in REFS_THAT_ALIAS_TO_OTHER_REFS:
4468 # Handle the refs that need to land in different refs.
4469 remote_branch = REFS_THAT_ALIAS_TO_OTHER_REFS[remote_branch]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004470
wittman@chromium.org455dc922015-01-26 20:15:50 +00004471 # Create the true path to the remote branch.
4472 # Does the following translation:
4473 # * refs/remotes/origin/refs/diff/test -> refs/diff/test
4474 # * refs/remotes/origin/master -> refs/heads/master
4475 # * refs/remotes/branch-heads/test -> refs/branch-heads/test
4476 if remote_branch.startswith('refs/remotes/%s/refs/' % remote):
4477 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, '')
4478 elif remote_branch.startswith('refs/remotes/%s/' % remote):
4479 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote,
4480 'refs/heads/')
4481 elif remote_branch.startswith('refs/remotes/branch-heads'):
4482 remote_branch = remote_branch.replace('refs/remotes/', 'refs/')
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01004483
wittman@chromium.org455dc922015-01-26 20:15:50 +00004484 return remote_branch
4485
4486
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004487def cleanup_list(l):
4488 """Fixes a list so that comma separated items are put as individual items.
4489
4490 So that "--reviewers joe@c,john@c --reviewers joa@c" results in
4491 options.reviewers == sorted(['joe@c', 'john@c', 'joa@c']).
4492 """
4493 items = sum((i.split(',') for i in l), [])
4494 stripped_items = (i.strip() for i in items)
4495 return sorted(filter(None, stripped_items))
4496
4497
Aaron Gable4db38df2017-11-03 14:59:07 -07004498@subcommand.usage('[flags]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004499@metrics.collector.collect_metrics('git cl upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004500def CMDupload(parser, args):
rmistry@google.com78948ed2015-07-08 23:09:57 +00004501 """Uploads the current changelist to codereview.
4502
4503 Can skip dependency patchset uploads for a branch by running:
4504 git config branch.branch_name.skip-deps-uploads True
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004505 To unset, run:
rmistry@google.com78948ed2015-07-08 23:09:57 +00004506 git config --unset branch.branch_name.skip-deps-uploads
4507 Can also set the above globally by using the --global flag.
Dominic Battre7d1c4842017-10-27 09:17:28 +02004508
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004509 If the name of the checked out branch starts with "bug-" or "fix-" followed
4510 by a bug number, this bug number is automatically populated in the CL
Dominic Battre7d1c4842017-10-27 09:17:28 +02004511 description.
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004512
4513 If subject contains text in square brackets or has "<text>: " prefix, such
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004514 text(s) is treated as Gerrit hashtags. For example, CLs with subjects:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004515 [git-cl] add support for hashtags
4516 Foo bar: implement foo
4517 will be hashtagged with "git-cl" and "foo-bar" respectively.
rmistry@google.com78948ed2015-07-08 23:09:57 +00004518 """
ukai@chromium.orge8077812012-02-03 03:41:46 +00004519 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4520 help='bypass upload presubmit hook')
brettw@chromium.orgb65c43c2013-06-10 22:04:49 +00004521 parser.add_option('--bypass-watchlists', action='store_true',
4522 dest='bypass_watchlists',
4523 help='bypass watchlists auto CC-ing reviewers')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004524 parser.add_option('-f', '--force', action='store_true', dest='force',
ukai@chromium.orge8077812012-02-03 03:41:46 +00004525 help="force yes to questions (don't prompt)")
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004526 parser.add_option('--message', '-m', dest='message',
4527 help='message for patchset')
tandriif9aefb72016-07-01 09:06:51 -07004528 parser.add_option('-b', '--bug',
4529 help='pre-populate the bug number(s) for this issue. '
4530 'If several, separate with commas')
tandriib80458a2016-06-23 12:20:07 -07004531 parser.add_option('--message-file', dest='message_file',
4532 help='file which contains message for patchset')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004533 parser.add_option('--title', '-t', dest='title',
4534 help='title for patchset')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004535 parser.add_option('-r', '--reviewers',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004536 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004537 help='reviewer email addresses')
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004538 parser.add_option('--tbrs',
4539 action='append', default=[],
4540 help='TBR email addresses')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004541 parser.add_option('--cc',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004542 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004543 help='cc email addresses')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004544 parser.add_option('--hashtag', dest='hashtags',
4545 action='append', default=[],
4546 help=('Gerrit hashtag for new CL; '
4547 'can be applied multiple times'))
adamk@chromium.org36f47302013-04-05 01:08:31 +00004548 parser.add_option('-s', '--send-mail', action='store_true',
Aaron Gable59f48512017-01-12 10:54:46 -08004549 help='send email to reviewer(s) and cc(s) immediately')
ukai@chromium.org8ef7ab22012-11-28 04:24:52 +00004550 parser.add_option('--target_branch',
pgervais@chromium.orgb9f27512014-08-08 15:52:33 +00004551 '--target-branch',
wittman@chromium.org455dc922015-01-26 20:15:50 +00004552 metavar='TARGET',
4553 help='Apply CL to remote ref TARGET. ' +
4554 'Default: remote branch head, or master')
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004555 parser.add_option('--squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004556 help='Squash multiple commits into one')
Mike Frysingera989d552019-08-14 20:51:23 +00004557 parser.add_option('--no-squash', action='store_false', dest='squash',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004558 help='Don\'t squash multiple commits into one')
rmistry9eadede2016-09-19 11:22:43 -07004559 parser.add_option('--topic', default=None,
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004560 help='Topic to specify when uploading')
Robert Iannuccif2708bd2017-04-17 15:49:02 -07004561 parser.add_option('--tbr-owners', dest='add_owners_to', action='store_const',
4562 const='TBR', help='add a set of OWNERS to TBR')
4563 parser.add_option('--r-owners', dest='add_owners_to', action='store_const',
4564 const='R', help='add a set of OWNERS to R')
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004565 parser.add_option('-c', '--use-commit-queue', action='store_true',
4566 help='tell the CQ to commit this patchset; '
4567 'implies --send-mail')
tandrii@chromium.orgd50452a2015-11-23 16:38:15 +00004568 parser.add_option('-d', '--cq-dry-run', dest='cq_dry_run',
4569 action='store_true',
rmistry@google.comef966222015-04-07 11:15:01 +00004570 help='Send the patchset to do a CQ dry run right after '
4571 'upload.')
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00004572 parser.add_option('--preserve-tryjobs', action='store_true',
4573 help='instruct the CQ to let tryjobs running even after '
4574 'new patchsets are uploaded instead of canceling '
4575 'prior patchset\' tryjobs')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004576 parser.add_option('--dependencies', action='store_true',
4577 help='Uploads CLs of all the local branches that depend on '
4578 'the current branch')
Ravi Mistry31e7d562018-04-02 12:53:57 -04004579 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4580 help='Sends your change to the CQ after an approval. Only '
4581 'works on repos that have the Auto-Submit label '
4582 'enabled')
Edward Lesmes8e282792018-04-03 18:50:29 -04004583 parser.add_option('--parallel', action='store_true',
4584 help='Run all tests specified by input_api.RunTests in all '
4585 'PRESUBMIT files in parallel.')
pgervais@chromium.org91141372014-01-09 23:27:20 +00004586
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004587 parser.add_option('--no-autocc', action='store_true',
4588 help='Disables automatic addition of CC emails')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004589 parser.add_option('--private', action='store_true',
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004590 help='Set the review private. This implies --no-autocc.')
4591
rmistry@google.com2dd99862015-06-22 12:22:18 +00004592 orig_args = args
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004593 _add_codereview_select_options(parser)
ukai@chromium.orge8077812012-02-03 03:41:46 +00004594 (options, args) = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004595 _process_codereview_select_options(parser, options)
ukai@chromium.orge8077812012-02-03 03:41:46 +00004596
sbc@chromium.org71437c02015-04-09 19:29:40 +00004597 if git_common.is_dirty_git_tree('upload'):
ukai@chromium.orge8077812012-02-03 03:41:46 +00004598 return 1
4599
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004600 options.reviewers = cleanup_list(options.reviewers)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004601 options.tbrs = cleanup_list(options.tbrs)
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004602 options.cc = cleanup_list(options.cc)
4603
tandriib80458a2016-06-23 12:20:07 -07004604 if options.message_file:
4605 if options.message:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004606 parser.error('Only one of --message and --message-file allowed.')
tandriib80458a2016-06-23 12:20:07 -07004607 options.message = gclient_utils.FileRead(options.message_file)
4608 options.message_file = None
4609
tandrii4d0545a2016-07-06 03:56:49 -07004610 if options.cq_dry_run and options.use_commit_queue:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004611 parser.error('Only one of --use-commit-queue and --cq-dry-run allowed.')
tandrii4d0545a2016-07-06 03:56:49 -07004612
Aaron Gableedbc4132017-09-11 13:22:28 -07004613 if options.use_commit_queue:
4614 options.send_mail = True
4615
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00004616 # For sanity of test expectations, do this otherwise lazy-loading *now*.
4617 settings.GetIsGerrit()
4618
Edward Lemur934836a2019-09-09 20:16:54 +00004619 cl = Changelist()
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00004620
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00004621 return cl.CMDUpload(options, args, orig_args)
ukai@chromium.orge8077812012-02-03 03:41:46 +00004622
4623
Francois Dorayd42c6812017-05-30 15:10:20 -04004624@subcommand.usage('--description=<description file>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004625@metrics.collector.collect_metrics('git cl split')
Francois Dorayd42c6812017-05-30 15:10:20 -04004626def CMDsplit(parser, args):
4627 """Splits a branch into smaller branches and uploads CLs.
4628
4629 Creates a branch and uploads a CL for each group of files modified in the
4630 current branch that share a common OWNERS file. In the CL description and
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004631 comment, the string '$directory', is replaced with the directory containing
Francois Dorayd42c6812017-05-30 15:10:20 -04004632 the shared OWNERS file.
4633 """
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004634 parser.add_option('-d', '--description', dest='description_file',
4635 help='A text file containing a CL description in which '
4636 '$directory will be replaced by each CL\'s directory.')
4637 parser.add_option('-c', '--comment', dest='comment_file',
4638 help='A text file containing a CL comment.')
4639 parser.add_option('-n', '--dry-run', dest='dry_run', action='store_true',
Chris Watkinsba28e462017-12-13 11:22:17 +11004640 default=False,
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004641 help='List the files and reviewers for each CL that would '
4642 'be created, but don\'t create branches or CLs.')
4643 parser.add_option('--cq-dry-run', action='store_true',
4644 help='If set, will do a cq dry run for each uploaded CL. '
4645 'Please be careful when doing this; more than ~10 CLs '
4646 'has the potential to overload our build '
4647 'infrastructure. Try to upload these not during high '
4648 'load times (usually 11-3 Mountain View time). Email '
4649 'infra-dev@chromium.org with any questions.')
Takuto Ikuta51eca592019-02-14 19:40:52 +00004650 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4651 default=True,
4652 help='Sends your change to the CQ after an approval. Only '
4653 'works on repos that have the Auto-Submit label '
4654 'enabled')
Francois Dorayd42c6812017-05-30 15:10:20 -04004655 options, _ = parser.parse_args(args)
4656
4657 if not options.description_file:
4658 parser.error('No --description flag specified.')
4659
4660 def WrappedCMDupload(args):
4661 return CMDupload(OptionParser(), args)
4662
4663 return split_cl.SplitCl(options.description_file, options.comment_file,
Stephen Martiniscb326682018-08-29 21:06:30 +00004664 Changelist, WrappedCMDupload, options.dry_run,
Takuto Ikuta51eca592019-02-14 19:40:52 +00004665 options.cq_dry_run, options.enable_auto_submit)
Francois Dorayd42c6812017-05-30 15:10:20 -04004666
4667
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004668@subcommand.usage('DEPRECATED')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004669@metrics.collector.collect_metrics('git cl commit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004670def CMDdcommit(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004671 """DEPRECATED: Used to commit the current changelist via git-svn."""
4672 message = ('git-cl no longer supports committing to SVN repositories via '
4673 'git-svn. You probably want to use `git cl land` instead.')
4674 print(message)
4675 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004676
4677
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01004678# Two special branches used by git cl land.
4679MERGE_BRANCH = 'git-cl-commit'
4680CHERRY_PICK_BRANCH = 'git-cl-cherry-pick'
4681
4682
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004683@subcommand.usage('[upstream branch to apply against]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004684@metrics.collector.collect_metrics('git cl land')
pgervais@chromium.orgcee6dc42014-05-07 17:04:03 +00004685def CMDland(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004686 """Commits the current changelist via git.
4687
4688 In case of Gerrit, uses Gerrit REST api to "submit" the issue, which pushes
4689 upstream and closes the issue automatically and atomically.
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004690 """
4691 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4692 help='bypass upload presubmit hook')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004693 parser.add_option('-f', '--force', action='store_true', dest='force',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004694 help="force yes to questions (don't prompt)")
Edward Lesmes67b3faa2018-04-13 17:50:52 -04004695 parser.add_option('--parallel', action='store_true',
4696 help='Run all tests specified by input_api.RunTests in all '
4697 'PRESUBMIT files in parallel.')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004698 (options, args) = parser.parse_args(args)
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004699
Edward Lemur934836a2019-09-09 20:16:54 +00004700 cl = Changelist()
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004701
Robert Iannucci2e73d432018-03-14 01:10:47 -07004702 if not cl.GetIssue():
4703 DieWithError('You must upload the change first to Gerrit.\n'
4704 ' If you would rather have `git cl land` upload '
4705 'automatically for you, see http://crbug.com/642759')
4706 return cl._codereview_impl.CMDLand(options.force, options.bypass_hooks,
Olivier Robin75ee7252018-04-13 10:02:56 +02004707 options.verbose, options.parallel)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004708
4709
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004710@subcommand.usage('<patch url or issue id or issue url>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004711@metrics.collector.collect_metrics('git cl patch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004712def CMDpatch(parser, args):
marq@chromium.orge5e59002013-10-02 23:21:25 +00004713 """Patches in a code review."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004714 parser.add_option('-b', dest='newbranch',
4715 help='create a new branch off trunk for the patch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00004716 parser.add_option('-f', '--force', action='store_true',
Aaron Gable62619a32017-06-16 08:22:09 -07004717 help='overwrite state on the current or chosen branch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004718 parser.add_option('-n', '--no-commit', action='store_true', dest='nocommit',
Edward Lemurf38bc172019-09-03 21:02:13 +00004719 help='don\'t commit after patch applies.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004720
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004721 group = optparse.OptionGroup(
4722 parser,
4723 'Options for continuing work on the current issue uploaded from a '
4724 'different clone (e.g. different machine). Must be used independently '
4725 'from the other options. No issue number should be specified, and the '
4726 'branch must have an issue number associated with it')
4727 group.add_option('--reapply', action='store_true', dest='reapply',
4728 help='Reset the branch and reapply the issue.\n'
4729 'CAUTION: This will undo any local changes in this '
4730 'branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004731
4732 group.add_option('--pull', action='store_true', dest='pull',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004733 help='Performs a pull before reapplying.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004734 parser.add_option_group(group)
4735
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004736 _add_codereview_select_options(parser)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004737 (options, args) = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004738 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004739
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004740 if options.reapply:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004741 if options.newbranch:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004742 parser.error('--reapply works on the current branch only.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004743 if len(args) > 0:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004744 parser.error('--reapply implies no additional arguments.')
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004745
Edward Lemur934836a2019-09-09 20:16:54 +00004746 cl = Changelist()
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004747 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004748 parser.error('Current branch must have an associated issue.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004749
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004750 upstream = cl.GetUpstreamBranch()
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004751 if upstream is None:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004752 parser.error('No upstream branch specified. Cannot reset branch.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004753
4754 RunGit(['reset', '--hard', upstream])
4755 if options.pull:
4756 RunGit(['pull'])
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004757
Edward Lemurf38bc172019-09-03 21:02:13 +00004758 return cl.CMDPatchIssue(cl.GetIssue(), options.nocommit)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004759
4760 if len(args) != 1 or not args[0]:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004761 parser.error('Must specify issue number or URL.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004762
Edward Lemurf38bc172019-09-03 21:02:13 +00004763 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004764 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004765 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004766
4767 cl_kwargs = {
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004768 'codereview_host': target_issue_arg.hostname,
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004769 }
4770 detected_codereview_from_url = False
Edward Lemurf38bc172019-09-03 21:02:13 +00004771 if not args[0].isdigit() and not options.forced_codereview:
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004772 detected_codereview_from_url = True
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004773 cl_kwargs['issue'] = target_issue_arg.issue
4774
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004775 # We don't want uncommitted changes mixed up with the patch.
4776 if git_common.is_dirty_git_tree('patch'):
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004777 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004778
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004779 if options.newbranch:
4780 if options.force:
4781 RunGit(['branch', '-D', options.newbranch],
4782 stderr=subprocess2.PIPE, error_ok=True)
4783 RunGit(['new-branch', options.newbranch])
4784
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004785 cl = Changelist(**cl_kwargs)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004786
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004787 if detected_codereview_from_url:
Edward Lemurf38bc172019-09-03 21:02:13 +00004788 print('canonical issue/change URL: %s\n' % cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004789
Edward Lemurf38bc172019-09-03 21:02:13 +00004790 return cl.CMDPatchWithParsedIssue(
4791 target_issue_arg, options.nocommit, options.force)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004792
4793
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004794def GetTreeStatus(url=None):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004795 """Fetches the tree status and returns either 'open', 'closed',
4796 'unknown' or 'unset'."""
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004797 url = url or settings.GetTreeStatusUrl(error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004798 if url:
4799 status = urllib2.urlopen(url).read().lower()
4800 if status.find('closed') != -1 or status == '0':
4801 return 'closed'
4802 elif status.find('open') != -1 or status == '1':
4803 return 'open'
4804 return 'unknown'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004805 return 'unset'
4806
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004807
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004808def GetTreeStatusReason():
4809 """Fetches the tree status from a json url and returns the message
4810 with the reason for the tree to be opened or closed."""
msb@chromium.orgbf1a7ba2011-02-01 16:21:46 +00004811 url = settings.GetTreeStatusUrl()
4812 json_url = urlparse.urljoin(url, '/current?format=json')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004813 connection = urllib2.urlopen(json_url)
4814 status = json.loads(connection.read())
4815 connection.close()
4816 return status['message']
4817
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004818
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004819@metrics.collector.collect_metrics('git cl tree')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004820def CMDtree(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004821 """Shows the status of the tree."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004822 _, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004823 status = GetTreeStatus()
4824 if 'unset' == status:
vapiera7fbd5a2016-06-16 09:17:49 -07004825 print('You must configure your tree status URL by running "git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004826 return 2
4827
vapiera7fbd5a2016-06-16 09:17:49 -07004828 print('The tree is %s' % status)
4829 print()
4830 print(GetTreeStatusReason())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004831 if status != 'open':
4832 return 1
4833 return 0
4834
4835
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004836@metrics.collector.collect_metrics('git cl try')
maruel@chromium.org15192402012-09-06 12:38:29 +00004837def CMDtry(parser, args):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004838 """Triggers tryjobs using either Buildbucket or CQ dry run."""
4839 group = optparse.OptionGroup(parser, 'Tryjob options')
maruel@chromium.org15192402012-09-06 12:38:29 +00004840 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004841 '-b', '--bot', action='append',
4842 help=('IMPORTANT: specify ONE builder per --bot flag. Use it multiple '
4843 'times to specify multiple builders. ex: '
4844 '"-b win_rel -b win_layout". See '
4845 'the try server waterfall for the builders name and the tests '
4846 'available.'))
maruel@chromium.org15192402012-09-06 12:38:29 +00004847 group.add_option(
borenet6c0efe62016-10-19 08:13:29 -07004848 '-B', '--bucket', default='',
4849 help=('Buildbucket bucket to send the try requests.'))
4850 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004851 '-r', '--revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004852 help='Revision to use for the tryjob; default: the revision will '
tandriif7b29d42016-10-07 08:45:41 -07004853 'be determined by the try recipe that builder runs, which usually '
4854 'defaults to HEAD of origin/master')
maruel@chromium.org15192402012-09-06 12:38:29 +00004855 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004856 '-c', '--clobber', action='store_true', default=False,
tandriif7b29d42016-10-07 08:45:41 -07004857 help='Force a clobber before building; that is don\'t do an '
tandrii1838bad2016-10-06 00:10:52 -07004858 'incremental build')
maruel@chromium.org15192402012-09-06 12:38:29 +00004859 group.add_option(
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08004860 '--category', default='git_cl_try', help='Specify custom build category.')
4861 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004862 '--project',
4863 help='Override which project to use. Projects are defined '
tandriif7b29d42016-10-07 08:45:41 -07004864 'in recipe to determine to which repository or directory to '
4865 'apply the patch')
maruel@chromium.org15192402012-09-06 12:38:29 +00004866 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004867 '-p', '--property', dest='properties', action='append', default=[],
4868 help='Specify generic properties in the form -p key1=value1 -p '
tandriif7b29d42016-10-07 08:45:41 -07004869 'key2=value2 etc. The value will be treated as '
4870 'json if decodable, or as string otherwise. '
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004871 'NOTE: using this may make your tryjob not usable for CQ, '
4872 'which will then schedule another tryjob with default properties')
sheyang@chromium.orgdb375572015-08-17 19:22:23 +00004873 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004874 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4875 help='Host of buildbucket. The default host is %default.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004876 parser.add_option_group(group)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004877 auth.add_auth_options(parser)
Koji Ishii31c14782018-01-08 17:17:33 +09004878 _add_codereview_issue_select_options(parser)
maruel@chromium.org15192402012-09-06 12:38:29 +00004879 options, args = parser.parse_args(args)
Edward Lemurf38bc172019-09-03 21:02:13 +00004880 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004881 auth_config = auth.extract_auth_config_from_options(options)
maruel@chromium.org15192402012-09-06 12:38:29 +00004882
machenbach@chromium.org45453142015-09-15 08:45:22 +00004883 # Make sure that all properties are prop=value pairs.
4884 bad_params = [x for x in options.properties if '=' not in x]
4885 if bad_params:
4886 parser.error('Got properties with missing "=": %s' % bad_params)
4887
maruel@chromium.org15192402012-09-06 12:38:29 +00004888 if args:
4889 parser.error('Unknown arguments: %s' % args)
4890
Edward Lemur934836a2019-09-09 20:16:54 +00004891 cl = Changelist(issue=options.issue)
maruel@chromium.org15192402012-09-06 12:38:29 +00004892 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004893 parser.error('Need to upload first.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004894
Edward Lemurf38bc172019-09-03 21:02:13 +00004895 # HACK: warm up Gerrit change detail cache to save on RPCs.
4896 cl._codereview_impl._GetChangeDetail(['DETAILED_ACCOUNTS', 'ALL_REVISIONS'])
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01004897
tandriie113dfd2016-10-11 10:20:12 -07004898 error_message = cl.CannotTriggerTryJobReason()
4899 if error_message:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004900 parser.error('Can\'t trigger tryjobs: %s' % error_message)
jrobbins@chromium.org16f10f72014-06-24 22:14:36 +00004901
qyearsley1fdfcb62016-10-24 13:22:03 -07004902 buckets = _get_bucket_map(cl, options, parser)
Edward Lemurc8b67ed2019-09-12 20:28:58 +00004903 if buckets and any(b.startswith('master.') for b in buckets):
4904 print('ERROR: Buildbot masters are not supported.')
4905 return 1
phajdan.jr@chromium.org8da7f272014-03-14 01:28:39 +00004906
qyearsleydd49f942016-10-28 11:57:22 -07004907 # If no bots are listed and we couldn't get a list based on PRESUBMIT files,
4908 # then we default to triggering a CQ dry run (see http://crbug.com/625697).
qyearsley1fdfcb62016-10-24 13:22:03 -07004909 if not buckets:
qyearsley1fdfcb62016-10-24 13:22:03 -07004910 if options.verbose:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07004911 print('git cl try with no bots now defaults to CQ dry run.')
4912 print('Scheduling CQ dry run on: %s' % cl.GetIssueURL())
4913 return cl.SetCQState(_CQState.DRY_RUN)
stip@chromium.org43064fd2013-12-18 20:07:44 +00004914
borenet6c0efe62016-10-19 08:13:29 -07004915 for builders in buckets.itervalues():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00004916 if any('triggered' in b for b in builders):
vapiera7fbd5a2016-06-16 09:17:49 -07004917 print('ERROR You are trying to send a job to a triggered bot. This type '
tandriide281ae2016-10-12 06:02:30 -07004918 'of bot requires an initial job from a parent (usually a builder). '
4919 'Instead send your job to the parent.\n'
vapiera7fbd5a2016-06-16 09:17:49 -07004920 'Bot list: %s' % builders, file=sys.stderr)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00004921 return 1
ilevy@chromium.orgf3b21232012-09-24 20:48:55 +00004922
ilevy@chromium.org36e420b2013-08-06 23:21:12 +00004923 patchset = cl.GetMostRecentPatchset()
tandrii568043b2016-10-11 07:49:18 -07004924 try:
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08004925 _trigger_try_jobs(auth_config, cl, buckets, options, patchset)
tandrii568043b2016-10-11 07:49:18 -07004926 except BuildbucketResponseException as ex:
4927 print('ERROR: %s' % ex)
4928 return 1
maruel@chromium.org15192402012-09-06 12:38:29 +00004929 return 0
4930
4931
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004932@metrics.collector.collect_metrics('git cl try-results')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004933def CMDtry_results(parser, args):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00004934 """Prints info about results for tryjobs associated with the current CL."""
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004935 group = optparse.OptionGroup(parser, 'Tryjob results options')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004936 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004937 '-p', '--patchset', type=int, help='patchset number if not current.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004938 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004939 '--print-master', action='store_true', help='print master name as well.')
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +00004940 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004941 '--color', action='store_true', default=setup_color.IS_TTY,
4942 help='force color output, useful when piping output.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004943 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004944 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4945 help='Host of buildbucket. The default host is %default.')
qyearsley53f48a12016-09-01 10:45:13 -07004946 group.add_option(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004947 '--json', help=('Path of JSON output file to write tryjob results to,'
Stefan Zager1306bd02017-06-22 19:26:46 -07004948 'or "-" for stdout.'))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004949 parser.add_option_group(group)
4950 auth.add_auth_options(parser)
Stefan Zager27db3f22017-10-10 15:15:01 -07004951 _add_codereview_issue_select_options(parser)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004952 options, args = parser.parse_args(args)
Edward Lemurf38bc172019-09-03 21:02:13 +00004953 _process_codereview_select_options(parser, options)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004954 if args:
4955 parser.error('Unrecognized args: %s' % ' '.join(args))
4956
4957 auth_config = auth.extract_auth_config_from_options(options)
Edward Lemur934836a2019-09-09 20:16:54 +00004958 cl = Changelist(issue=options.issue)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004959 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004960 parser.error('Need to upload first.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004961
tandrii221ab252016-10-06 08:12:04 -07004962 patchset = options.patchset
4963 if not patchset:
4964 patchset = cl.GetMostRecentPatchset()
4965 if not patchset:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004966 parser.error('Code review host doesn\'t know about issue %s. '
tandrii221ab252016-10-06 08:12:04 -07004967 'No access to issue or wrong issue number?\n'
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004968 'Either upload first, or pass --patchset explicitly.' %
tandrii221ab252016-10-06 08:12:04 -07004969 cl.GetIssue())
4970
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004971 try:
tandrii221ab252016-10-06 08:12:04 -07004972 jobs = fetch_try_jobs(auth_config, cl, options.buildbucket_host, patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004973 except BuildbucketResponseException as ex:
vapiera7fbd5a2016-06-16 09:17:49 -07004974 print('Buildbucket error: %s' % ex)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004975 return 1
qyearsley53f48a12016-09-01 10:45:13 -07004976 if options.json:
4977 write_try_results_json(options.json, jobs)
4978 else:
4979 print_try_jobs(options, jobs)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004980 return 0
4981
4982
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004983@subcommand.usage('[new upstream branch]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004984@metrics.collector.collect_metrics('git cl upstream')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004985def CMDupstream(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004986 """Prints or sets the name of the upstream branch, if any."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004987 _, args = parser.parse_args(args)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004988 if len(args) > 1:
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004989 parser.error('Unrecognized args: %s' % ' '.join(args))
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004990
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004991 cl = Changelist()
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004992 if args:
4993 # One arg means set upstream branch.
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004994 branch = cl.GetBranch()
stip7a3dd352016-09-22 17:32:28 -07004995 RunGit(['branch', '--set-upstream-to', args[0], branch])
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004996 cl = Changelist()
vapiera7fbd5a2016-06-16 09:17:49 -07004997 print('Upstream branch set to %s' % (cl.GetUpstreamBranch(),))
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004998
4999 # Clear configured merge-base, if there is one.
5000 git_common.remove_merge_base(branch)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005001 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005002 print(cl.GetUpstreamBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005003 return 0
5004
5005
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005006@metrics.collector.collect_metrics('git cl web')
thestig@chromium.org00858c82013-12-02 23:08:03 +00005007def CMDweb(parser, args):
5008 """Opens the current CL in the web browser."""
5009 _, args = parser.parse_args(args)
5010 if args:
5011 parser.error('Unrecognized args: %s' % ' '.join(args))
5012
5013 issue_url = Changelist().GetIssueURL()
5014 if not issue_url:
vapiera7fbd5a2016-06-16 09:17:49 -07005015 print('ERROR No issue to open', file=sys.stderr)
thestig@chromium.org00858c82013-12-02 23:08:03 +00005016 return 1
5017
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00005018 # Redirect I/O before invoking browser to hide its output. For example, this
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005019 # allows us to hide the "Created new window in existing browser session."
5020 # message from Chrome. Based on https://stackoverflow.com/a/2323563.
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00005021 saved_stdout = os.dup(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00005022 saved_stderr = os.dup(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00005023 os.close(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00005024 os.close(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00005025 os.open(os.devnull, os.O_RDWR)
5026 try:
5027 webbrowser.open(issue_url)
5028 finally:
5029 os.dup2(saved_stdout, 1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00005030 os.dup2(saved_stderr, 2)
thestig@chromium.org00858c82013-12-02 23:08:03 +00005031 return 0
5032
5033
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005034@metrics.collector.collect_metrics('git cl set-commit')
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005035def CMDset_commit(parser, args):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00005036 """Sets the commit bit to trigger the CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005037 parser.add_option('-d', '--dry-run', action='store_true',
5038 help='trigger in dry run mode')
5039 parser.add_option('-c', '--clear', action='store_true',
5040 help='stop CQ run, if any')
iannuccie53c9352016-08-17 14:40:40 -07005041 _add_codereview_issue_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005042 options, args = parser.parse_args(args)
Edward Lemurf38bc172019-09-03 21:02:13 +00005043 _process_codereview_select_options(parser, options)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005044 if args:
5045 parser.error('Unrecognized args: %s' % ' '.join(args))
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005046 if options.dry_run and options.clear:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005047 parser.error('Only one of --dry-run and --clear are allowed.')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005048
Edward Lemur934836a2019-09-09 20:16:54 +00005049 cl = Changelist(issue=options.issue)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005050 if options.clear:
tandriid9e5ce52016-07-13 02:32:59 -07005051 state = _CQState.NONE
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005052 elif options.dry_run:
5053 state = _CQState.DRY_RUN
5054 else:
5055 state = _CQState.COMMIT
5056 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005057 parser.error('Must upload the issue first.')
tandrii9de9ec62016-07-13 03:01:59 -07005058 cl.SetCQState(state)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005059 return 0
5060
5061
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005062@metrics.collector.collect_metrics('git cl set-close')
groby@chromium.org411034a2013-02-26 15:12:01 +00005063def CMDset_close(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005064 """Closes the issue."""
iannuccie53c9352016-08-17 14:40:40 -07005065 _add_codereview_issue_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005066 options, args = parser.parse_args(args)
Edward Lemurf38bc172019-09-03 21:02:13 +00005067 _process_codereview_select_options(parser, options)
groby@chromium.org411034a2013-02-26 15:12:01 +00005068 if args:
5069 parser.error('Unrecognized args: %s' % ' '.join(args))
Edward Lemur934836a2019-09-09 20:16:54 +00005070 cl = Changelist(issue=options.issue)
groby@chromium.org411034a2013-02-26 15:12:01 +00005071 # Ensure there actually is an issue to close.
Aaron Gable7139a4e2017-09-05 17:53:09 -07005072 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005073 DieWithError('ERROR: No issue to close.')
groby@chromium.org411034a2013-02-26 15:12:01 +00005074 cl.CloseIssue()
5075 return 0
5076
5077
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005078@metrics.collector.collect_metrics('git cl diff')
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005079def CMDdiff(parser, args):
wychen@chromium.org37b2ec02015-04-03 00:49:15 +00005080 """Shows differences between local tree and last upload."""
thomasanderson074beb22016-08-29 14:03:20 -07005081 parser.add_option(
5082 '--stat',
5083 action='store_true',
5084 dest='stat',
5085 help='Generate a diffstat')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005086 options, args = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005087 if args:
5088 parser.error('Unrecognized args: %s' % ' '.join(args))
wychen@chromium.org46309bf2015-04-03 21:04:49 +00005089
Edward Lemur934836a2019-09-09 20:16:54 +00005090 cl = Changelist()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00005091 issue = cl.GetIssue()
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005092 branch = cl.GetBranch()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00005093 if not issue:
5094 DieWithError('No issue found for current branch (%s)' % branch)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005095
Aaron Gablea718c3e2017-08-28 17:47:28 -07005096 base = cl._GitGetBranchConfigValue('last-upload-hash')
5097 if not base:
5098 base = cl._GitGetBranchConfigValue('gerritsquashhash')
5099 if not base:
5100 detail = cl._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
5101 revision_info = detail['revisions'][detail['current_revision']]
5102 fetch_info = revision_info['fetch']['http']
5103 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
5104 base = 'FETCH_HEAD'
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005105
Aaron Gablea718c3e2017-08-28 17:47:28 -07005106 cmd = ['git', 'diff']
5107 if options.stat:
5108 cmd.append('--stat')
5109 cmd.append(base)
5110 subprocess2.check_call(cmd)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005111
5112 return 0
5113
5114
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005115@metrics.collector.collect_metrics('git cl owners')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005116def CMDowners(parser, args):
Dirk Prankebf980882017-09-02 15:08:00 -07005117 """Finds potential owners for reviewing."""
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005118 parser.add_option(
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00005119 '--ignore-current',
5120 action='store_true',
5121 help='Ignore the CL\'s current reviewers and start from scratch.')
5122 parser.add_option(
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00005123 '--ignore-self',
5124 action='store_true',
5125 help='Do not consider CL\'s author as an owners.')
5126 parser.add_option(
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005127 '--no-color',
5128 action='store_true',
5129 help='Use this option to disable color output')
Dirk Prankebf980882017-09-02 15:08:00 -07005130 parser.add_option(
5131 '--batch',
5132 action='store_true',
5133 help='Do not run interactively, just suggest some')
Yang Guo6e269a02019-06-26 11:17:02 +00005134 # TODO: Consider moving this to another command, since other
5135 # git-cl owners commands deal with owners for a given CL.
5136 parser.add_option(
5137 '--show-all',
5138 action='store_true',
5139 help='Show all owners for a particular file')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005140 options, args = parser.parse_args(args)
5141
5142 author = RunGit(['config', 'user.email']).strip() or None
5143
Edward Lemur934836a2019-09-09 20:16:54 +00005144 cl = Changelist()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005145
Yang Guo6e269a02019-06-26 11:17:02 +00005146 if options.show_all:
5147 for arg in args:
5148 base_branch = cl.GetCommonAncestorWithUpstream()
5149 change = cl.GetChange(base_branch, None)
5150 database = owners.Database(change.RepositoryRoot(), file, os.path)
5151 database.load_data_needed_for([arg])
5152 print('Owners for %s:' % arg)
5153 for owner in sorted(database.all_possible_owners([arg], None)):
5154 print(' - %s' % owner)
5155 return 0
5156
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005157 if args:
5158 if len(args) > 1:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005159 parser.error('Unknown args.')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005160 base_branch = args[0]
5161 else:
5162 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005163 base_branch = cl.GetCommonAncestorWithUpstream()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005164
5165 change = cl.GetChange(base_branch, None)
Dirk Prankebf980882017-09-02 15:08:00 -07005166 affected_files = [f.LocalPath() for f in change.AffectedFiles()]
5167
5168 if options.batch:
5169 db = owners.Database(change.RepositoryRoot(), file, os.path)
5170 print('\n'.join(db.reviewers_for(affected_files, author)))
5171 return 0
5172
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005173 return owners_finder.OwnersFinder(
Dirk Prankebf980882017-09-02 15:08:00 -07005174 affected_files,
Jochen Eisinger72606f82017-04-04 10:44:18 +02005175 change.RepositoryRoot(),
Edward Lemur707d70b2018-02-07 00:50:14 +01005176 author,
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00005177 [] if options.ignore_current else cl.GetReviewers(),
Edward Lemur707d70b2018-02-07 00:50:14 +01005178 fopen=file, os_path=os.path,
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02005179 disable_color=options.no_color,
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00005180 override_files=change.OriginalOwnersFiles(),
5181 ignore_author=options.ignore_self).run()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005182
5183
Aiden Bennerc08566e2018-10-03 17:52:42 +00005184def BuildGitDiffCmd(diff_type, upstream_commit, args, allow_prefix=False):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005185 """Generates a diff command."""
5186 # Generate diff for the current branch's changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +00005187 diff_cmd = ['-c', 'core.quotePath=false', 'diff', '--no-ext-diff']
5188
Aiden Benner6c18a1a2018-11-23 20:18:23 +00005189 if allow_prefix:
5190 # explicitly setting --src-prefix and --dst-prefix is necessary in the
5191 # case that diff.noprefix is set in the user's git config.
5192 diff_cmd += ['--src-prefix=a/', '--dst-prefix=b/']
5193 else:
Aiden Bennerc08566e2018-10-03 17:52:42 +00005194 diff_cmd += ['--no-prefix']
5195
5196 diff_cmd += [diff_type, upstream_commit, '--']
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005197
5198 if args:
5199 for arg in args:
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005200 if os.path.isdir(arg) or os.path.isfile(arg):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005201 diff_cmd.append(arg)
5202 else:
5203 DieWithError('Argument "%s" is not a file or a directory' % arg)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005204
5205 return diff_cmd
5206
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005207
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005208def MatchingFileType(file_name, extensions):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00005209 """Returns True if the file name ends with one of the given extensions."""
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005210 return bool([ext for ext in extensions if file_name.lower().endswith(ext)])
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005211
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005212
enne@chromium.org555cfe42014-01-29 18:21:39 +00005213@subcommand.usage('[files or directories to diff]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005214@metrics.collector.collect_metrics('git cl format')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005215def CMDformat(parser, args):
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005216 """Runs auto-formatting tools (clang-format etc.) on the diff."""
Christopher Lamc5ba6922017-01-24 11:19:14 +11005217 CLANG_EXTS = ['.cc', '.cpp', '.h', '.m', '.mm', '.proto', '.java']
kylechar58edce22016-06-17 06:07:51 -07005218 GN_EXTS = ['.gn', '.gni', '.typemap']
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00005219 parser.add_option('--full', action='store_true',
5220 help='Reformat the full content of all touched files')
5221 parser.add_option('--dry-run', action='store_true',
5222 help='Don\'t modify any file on disk.')
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005223 parser.add_option(
5224 '--python',
5225 action='store_true',
5226 default=None,
5227 help='Enables python formatting on all python files.')
5228 parser.add_option(
5229 '--no-python',
5230 action='store_true',
5231 dest='python',
5232 help='Disables python formatting on all python files. '
5233 'Takes precedence over --python. '
5234 'If neither --python or --no-python are set, python '
5235 'files that have a .style.yapf file in an ancestor '
5236 'directory will be formatted.')
Christopher Lamc5ba6922017-01-24 11:19:14 +11005237 parser.add_option('--js', action='store_true',
5238 help='Format javascript code with clang-format.')
wittman@chromium.org04d5a222014-03-07 18:30:42 +00005239 parser.add_option('--diff', action='store_true',
5240 help='Print diff to stdout rather than modifying files.')
Ilya Shermane081cbe2017-08-15 17:51:04 -07005241 parser.add_option('--presubmit', action='store_true',
5242 help='Used when running the script from a presubmit.')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005243 opts, args = parser.parse_args(args)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005244
Daniel Chengc55eecf2016-12-30 03:11:02 -08005245 # Normalize any remaining args against the current path, so paths relative to
5246 # the current directory are still resolved as expected.
5247 args = [os.path.join(os.getcwd(), arg) for arg in args]
5248
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005249 # git diff generates paths against the root of the repository. Change
5250 # to that directory so clang-format can find files even within subdirs.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005251 rel_base_path = settings.GetRelativeRoot()
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005252 if rel_base_path:
5253 os.chdir(rel_base_path)
5254
digit@chromium.org29e47272013-05-17 17:01:46 +00005255 # Grab the merge-base commit, i.e. the upstream commit of the current
5256 # branch when it was created or the last time it was rebased. This is
5257 # to cover the case where the user may have called "git fetch origin",
5258 # moving the origin branch to a newer commit, but hasn't rebased yet.
5259 upstream_commit = None
5260 cl = Changelist()
5261 upstream_branch = cl.GetUpstreamBranch()
5262 if upstream_branch:
5263 upstream_commit = RunGit(['merge-base', 'HEAD', upstream_branch])
5264 upstream_commit = upstream_commit.strip()
5265
5266 if not upstream_commit:
5267 DieWithError('Could not find base commit for this branch. '
5268 'Are you in detached state?')
5269
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005270 changed_files_cmd = BuildGitDiffCmd('--name-only', upstream_commit, args)
5271 diff_output = RunGit(changed_files_cmd)
5272 diff_files = diff_output.splitlines()
jkarlin@chromium.orgad21b922016-01-28 17:48:42 +00005273 # Filter out files deleted by this CL
5274 diff_files = [x for x in diff_files if os.path.isfile(x)]
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005275
Christopher Lamc5ba6922017-01-24 11:19:14 +11005276 if opts.js:
Deepanjan Roy605dd312018-07-02 17:48:54 +00005277 CLANG_EXTS.extend(['.js', '.ts'])
Christopher Lamc5ba6922017-01-24 11:19:14 +11005278
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005279 clang_diff_files = [x for x in diff_files if MatchingFileType(x, CLANG_EXTS)]
5280 python_diff_files = [x for x in diff_files if MatchingFileType(x, ['.py'])]
5281 dart_diff_files = [x for x in diff_files if MatchingFileType(x, ['.dart'])]
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005282 gn_diff_files = [x for x in diff_files if MatchingFileType(x, GN_EXTS)]
digit@chromium.org29e47272013-05-17 17:01:46 +00005283
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +00005284 top_dir = os.path.normpath(
5285 RunGit(["rev-parse", "--show-toplevel"]).rstrip('\n'))
5286
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005287 # Set to 2 to signal to CheckPatchFormatted() that this patch isn't
5288 # formatted. This is used to block during the presubmit.
5289 return_value = 0
5290
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005291 if clang_diff_files:
techtonik@gmail.com5573df12016-04-12 18:34:10 +00005292 # Locate the clang-format binary in the checkout
5293 try:
5294 clang_format_tool = clang_format.FindClangFormatToolInChromiumTree()
vapierfd77ac72016-06-16 08:33:57 -07005295 except clang_format.NotFoundError as e:
techtonik@gmail.com5573df12016-04-12 18:34:10 +00005296 DieWithError(e)
5297
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005298 if opts.full:
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005299 cmd = [clang_format_tool]
5300 if not opts.dry_run and not opts.diff:
5301 cmd.append('-i')
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005302 stdout = RunCommand(cmd + clang_diff_files, cwd=top_dir)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005303 if opts.diff:
5304 sys.stdout.write(stdout)
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005305 else:
5306 env = os.environ.copy()
5307 env['PATH'] = str(os.path.dirname(clang_format_tool))
5308 try:
5309 script = clang_format.FindClangFormatScriptInChromiumTree(
5310 'clang-format-diff.py')
vapierfd77ac72016-06-16 08:33:57 -07005311 except clang_format.NotFoundError as e:
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005312 DieWithError(e)
digit@chromium.orgd6ddc1c2013-10-25 15:36:32 +00005313
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005314 cmd = [sys.executable, script, '-p0']
5315 if not opts.dry_run and not opts.diff:
5316 cmd.append('-i')
digit@chromium.orgd6ddc1c2013-10-25 15:36:32 +00005317
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005318 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, clang_diff_files)
5319 diff_output = RunGit(diff_cmd)
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005320
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005321 stdout = RunCommand(cmd, stdin=diff_output, cwd=top_dir, env=env)
5322 if opts.diff:
5323 sys.stdout.write(stdout)
5324 if opts.dry_run and len(stdout) > 0:
5325 return_value = 2
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005326
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005327 # Similar code to above, but using yapf on .py files rather than clang-format
5328 # on C/C++ files
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005329 py_explicitly_disabled = opts.python is not None and not opts.python
5330 if python_diff_files and not py_explicitly_disabled:
Aiden Bennere47ac152018-11-20 16:44:03 +00005331 depot_tools_path = os.path.dirname(os.path.abspath(__file__))
5332 yapf_tool = os.path.join(depot_tools_path, 'yapf')
5333 if sys.platform.startswith('win'):
5334 yapf_tool += '.bat'
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005335
Aiden Bennerc08566e2018-10-03 17:52:42 +00005336 # If we couldn't find a yapf file we'll default to the chromium style
5337 # specified in depot_tools.
Aiden Bennerc08566e2018-10-03 17:52:42 +00005338 chromium_default_yapf_style = os.path.join(depot_tools_path,
5339 YAPF_CONFIG_FILENAME)
Aiden Bennerc08566e2018-10-03 17:52:42 +00005340 # Used for caching.
5341 yapf_configs = {}
5342 for f in python_diff_files:
5343 # Find the yapf style config for the current file, defaults to depot
5344 # tools default.
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005345 _FindYapfConfigFile(f, yapf_configs, top_dir)
5346
5347 # Turn on python formatting by default if a yapf config is specified.
5348 # This breaks in the case of this repo though since the specified
5349 # style file is also the global default.
5350 if opts.python is None:
5351 filtered_py_files = []
5352 for f in python_diff_files:
5353 if _FindYapfConfigFile(f, yapf_configs, top_dir) is not None:
5354 filtered_py_files.append(f)
5355 else:
5356 filtered_py_files = python_diff_files
5357
5358 # Note: yapf still seems to fix indentation of the entire file
5359 # even if line ranges are specified.
5360 # See https://github.com/google/yapf/issues/499
5361 if not opts.full and filtered_py_files:
5362 py_line_diffs = _ComputeDiffLineRanges(filtered_py_files, upstream_commit)
5363
5364 for f in filtered_py_files:
5365 yapf_config = _FindYapfConfigFile(f, yapf_configs, top_dir)
5366 if yapf_config is None:
5367 yapf_config = chromium_default_yapf_style
Aiden Bennerc08566e2018-10-03 17:52:42 +00005368
5369 cmd = [yapf_tool, '--style', yapf_config, f]
5370
5371 has_formattable_lines = False
5372 if not opts.full:
5373 # Only run yapf over changed line ranges.
5374 for diff_start, diff_len in py_line_diffs[f]:
5375 diff_end = diff_start + diff_len - 1
5376 # Yapf errors out if diff_end < diff_start but this
5377 # is a valid line range diff for a removal.
5378 if diff_end >= diff_start:
5379 has_formattable_lines = True
5380 cmd += ['-l', '{}-{}'.format(diff_start, diff_end)]
5381 # If all line diffs were removals we have nothing to format.
5382 if not has_formattable_lines:
5383 continue
5384
5385 if opts.diff or opts.dry_run:
5386 cmd += ['--diff']
5387 # Will return non-zero exit code if non-empty diff.
5388 stdout = RunCommand(cmd, error_ok=True, cwd=top_dir)
5389 if opts.diff:
5390 sys.stdout.write(stdout)
5391 elif len(stdout) > 0:
5392 return_value = 2
5393 else:
5394 cmd += ['-i']
5395 RunCommand(cmd, cwd=top_dir)
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005396
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005397 # Dart's formatter does not have the nice property of only operating on
5398 # modified chunks, so hard code full.
5399 if dart_diff_files:
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005400 try:
5401 command = [dart_format.FindDartFmtToolInChromiumTree()]
5402 if not opts.dry_run and not opts.diff:
5403 command.append('-w')
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005404 command.extend(dart_diff_files)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005405
ppi@chromium.org6593d932016-03-03 15:41:15 +00005406 stdout = RunCommand(command, cwd=top_dir)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005407 if opts.dry_run and stdout:
5408 return_value = 2
5409 except dart_format.NotFoundError as e:
vapiera7fbd5a2016-06-16 09:17:49 -07005410 print('Warning: Unable to check Dart code formatting. Dart SDK not '
5411 'found in this checkout. Files in other languages are still '
5412 'formatted.')
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005413
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005414 # Format GN build files. Always run on full build files for canonical form.
5415 if gn_diff_files:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005416 cmd = ['gn', 'format']
brettw4b8ed592016-08-05 16:19:12 -07005417 if opts.dry_run or opts.diff:
5418 cmd.append('--dry-run')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005419 for gn_diff_file in gn_diff_files:
brettw4b8ed592016-08-05 16:19:12 -07005420 gn_ret = subprocess2.call(cmd + [gn_diff_file],
5421 shell=sys.platform == 'win32',
5422 cwd=top_dir)
5423 if opts.dry_run and gn_ret == 2:
5424 return_value = 2 # Not formatted.
5425 elif opts.diff and gn_ret == 2:
5426 # TODO this should compute and print the actual diff.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005427 print('This change has GN build file diff for ' + gn_diff_file)
brettw4b8ed592016-08-05 16:19:12 -07005428 elif gn_ret != 0:
5429 # For non-dry run cases (and non-2 return values for dry-run), a
5430 # nonzero error code indicates a failure, probably because the file
5431 # doesn't parse.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005432 DieWithError('gn format failed on ' + gn_diff_file +
5433 '\nTry running `gn format` on this file manually.')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005434
Ilya Shermane081cbe2017-08-15 17:51:04 -07005435 # Skip the metrics formatting from the global presubmit hook. These files have
5436 # a separate presubmit hook that issues an error if the files need formatting,
5437 # whereas the top-level presubmit script merely issues a warning. Formatting
5438 # these files is somewhat slow, so it's important not to duplicate the work.
5439 if not opts.presubmit:
5440 for xml_dir in GetDirtyMetricsDirs(diff_files):
5441 tool_dir = os.path.join(top_dir, xml_dir)
5442 cmd = [os.path.join(tool_dir, 'pretty_print.py'), '--non-interactive']
5443 if opts.dry_run or opts.diff:
5444 cmd.append('--diff')
Ilya Sherman235b70d2017-08-22 17:46:38 -07005445 stdout = RunCommand(cmd, cwd=top_dir)
Ilya Shermane081cbe2017-08-15 17:51:04 -07005446 if opts.diff:
5447 sys.stdout.write(stdout)
5448 if opts.dry_run and stdout:
5449 return_value = 2 # Not formatted.
Alexei Svitkinef3cac412017-02-06 11:08:50 -05005450
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005451 return return_value
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005452
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005453
Steven Holte2e664bf2017-04-21 13:10:47 -07005454def GetDirtyMetricsDirs(diff_files):
5455 xml_diff_files = [x for x in diff_files if MatchingFileType(x, ['.xml'])]
5456 metrics_xml_dirs = [
5457 os.path.join('tools', 'metrics', 'actions'),
5458 os.path.join('tools', 'metrics', 'histograms'),
5459 os.path.join('tools', 'metrics', 'rappor'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005460 os.path.join('tools', 'metrics', 'ukm'),
5461 ]
Steven Holte2e664bf2017-04-21 13:10:47 -07005462 for xml_dir in metrics_xml_dirs:
5463 if any(file.startswith(xml_dir) for file in xml_diff_files):
5464 yield xml_dir
5465
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005466
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005467@subcommand.usage('<codereview url or issue id>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005468@metrics.collector.collect_metrics('git cl checkout')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005469def CMDcheckout(parser, args):
Edward Lemurf38bc172019-09-03 21:02:13 +00005470 """Checks out a branch associated with a given Gerrit issue."""
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005471 _, args = parser.parse_args(args)
5472
5473 if len(args) != 1:
5474 parser.print_help()
5475 return 1
5476
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005477 issue_arg = ParseIssueNumberArgument(args[0])
tandrii@chromium.orgde6c9a12016-04-11 15:33:53 +00005478 if not issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005479 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005480
tandrii@chromium.orgabd27e52016-04-11 15:43:32 +00005481 target_issue = str(issue_arg.issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005482
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005483 def find_issues(issueprefix):
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00005484 output = RunGit(['config', '--local', '--get-regexp',
5485 r'branch\..*\.%s' % issueprefix],
5486 error_ok=True)
5487 for key, issue in [x.split() for x in output.splitlines()]:
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005488 if issue == target_issue:
5489 yield re.sub(r'branch\.(.*)\.%s' % issueprefix, r'\1', key)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005490
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005491 branches = []
5492 for cls in _CODEREVIEW_IMPLEMENTATIONS.values():
tandrii5d48c322016-08-18 16:19:37 -07005493 branches.extend(find_issues(cls.IssueConfigKey()))
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005494 if len(branches) == 0:
vapiera7fbd5a2016-06-16 09:17:49 -07005495 print('No branch found for issue %s.' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005496 return 1
5497 if len(branches) == 1:
5498 RunGit(['checkout', branches[0]])
5499 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005500 print('Multiple branches match issue %s:' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005501 for i in range(len(branches)):
vapiera7fbd5a2016-06-16 09:17:49 -07005502 print('%d: %s' % (i, branches[i]))
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005503 which = raw_input('Choose by index: ')
5504 try:
5505 RunGit(['checkout', branches[int(which)]])
5506 except (IndexError, ValueError):
vapiera7fbd5a2016-06-16 09:17:49 -07005507 print('Invalid selection, not checking out any branch.')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005508 return 1
5509
5510 return 0
5511
5512
maruel@chromium.org29404b52014-09-08 22:58:00 +00005513def CMDlol(parser, args):
5514 # This command is intentionally undocumented.
vapiera7fbd5a2016-06-16 09:17:49 -07005515 print(zlib.decompress(base64.b64decode(
thakis@chromium.org3421c992014-11-02 02:20:32 +00005516 'eNptkLEOwyAMRHe+wupCIqW57v0Vq84WqWtXyrcXnCBsmgMJ+/SSAxMZgRB6NzE'
5517 'E2ObgCKJooYdu4uAQVffUEoE1sRQLxAcqzd7uK2gmStrll1ucV3uZyaY5sXyDd9'
5518 'JAnN+lAXsOMJ90GANAi43mq5/VeeacylKVgi8o6F1SC63FxnagHfJUTfUYdCR/W'
vapiera7fbd5a2016-06-16 09:17:49 -07005519 'Ofe+0dHL7PicpytKP750Fh1q2qnLVof4w8OZWNY')))
maruel@chromium.org29404b52014-09-08 22:58:00 +00005520 return 0
5521
5522
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005523class OptionParser(optparse.OptionParser):
5524 """Creates the option parse and add --verbose support."""
5525 def __init__(self, *args, **kwargs):
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005526 optparse.OptionParser.__init__(
5527 self, *args, prog='git cl', version=__version__, **kwargs)
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005528 self.add_option(
5529 '-v', '--verbose', action='count', default=0,
5530 help='Use 2 times for more debugging info')
5531
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005532 def parse_args(self, args=None, _values=None):
Andrii Shyshkalov46f20cd2018-10-30 06:42:54 +00005533 try:
5534 return self._parse_args(args)
5535 finally:
5536 # Regardless of success or failure of args parsing, we want to report
5537 # metrics, but only after logging has been initialized (if parsing
5538 # succeeded).
5539 global settings
5540 settings = Settings()
5541
5542 if not metrics.DISABLE_METRICS_COLLECTION:
5543 # GetViewVCUrl ultimately calls logging method.
5544 project_url = settings.GetViewVCUrl().strip('/+')
5545 if project_url in metrics_utils.KNOWN_PROJECT_URLS:
5546 metrics.collector.add('project_urls', [project_url])
5547
5548 def _parse_args(self, args=None):
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005549 # Create an optparse.Values object that will store only the actual passed
5550 # options, without the defaults.
5551 actual_options = optparse.Values()
5552 _, args = optparse.OptionParser.parse_args(self, args, actual_options)
5553 # Create an optparse.Values object with the default options.
5554 options = optparse.Values(self.get_default_values().__dict__)
5555 # Update it with the options passed by the user.
5556 options._update_careful(actual_options.__dict__)
5557 # Store the options passed by the user in an _actual_options attribute.
5558 # We store only the keys, and not the values, since the values can contain
5559 # arbitrary information, which might be PII.
5560 metrics.collector.add('arguments', actual_options.__dict__.keys())
5561
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005562 levels = [logging.WARNING, logging.INFO, logging.DEBUG]
Andrii Shyshkalov5b04a572017-01-23 17:44:41 +01005563 logging.basicConfig(
5564 level=levels[min(options.verbose, len(levels) - 1)],
5565 format='[%(levelname).1s%(asctime)s %(process)d %(thread)d '
5566 '%(filename)s] %(message)s')
Edward Lemur83bd7f42018-10-10 00:14:21 +00005567
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005568 return options, args
5569
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005570
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005571def main(argv):
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005572 if sys.hexversion < 0x02060000:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005573 print('\nYour Python version %s is unsupported, please upgrade.\n' %
vapiera7fbd5a2016-06-16 09:17:49 -07005574 (sys.version.split(' ', 1)[0],), file=sys.stderr)
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005575 return 2
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00005576
maruel@chromium.org39c0b222013-08-17 16:57:01 +00005577 colorize_CMDstatus_doc()
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005578 dispatcher = subcommand.CommandDispatcher(__name__)
5579 try:
5580 return dispatcher.execute(OptionParser(), argv)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +00005581 except auth.AuthenticationError as e:
5582 DieWithError(str(e))
vapierfd77ac72016-06-16 08:33:57 -07005583 except urllib2.HTTPError as e:
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005584 if e.code != 500:
5585 raise
5586 DieWithError(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005587 ('App Engine is misbehaving and returned HTTP %d, again. Keep faith '
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005588 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
sbc@chromium.org013731e2015-02-26 18:28:43 +00005589 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005590
5591
5592if __name__ == '__main__':
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005593 # These affect sys.stdout, so do it outside of main() to simplify mocks in
5594 # the unit tests.
maruel@chromium.org6f09cd92011-04-01 16:38:12 +00005595 fix_encoding.fix_encoding()
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00005596 setup_color.init()
Edward Lemur6f812e12018-07-31 22:45:57 +00005597 with metrics.collector.print_notice_and_exit():
sbc@chromium.org013731e2015-02-26 18:28:43 +00005598 sys.exit(main(sys.argv[1:]))