blob: 51950870f7acb78d523227647ba389cafc917d40 [file] [log] [blame]
philipelbe7a9e52016-05-19 12:19:35 +02001/*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020011#include "modules/video_coding/frame_buffer2.h"
philipelbe7a9e52016-05-19 12:19:35 +020012
13#include <algorithm>
Yves Gerey3e707812018-11-28 16:47:49 +010014#include <cstdlib>
15#include <iterator>
philipele0b2f152016-09-28 10:23:49 +020016#include <queue>
Yves Gerey3e707812018-11-28 16:47:49 +010017#include <utility>
philipel798b2822018-06-11 13:10:14 +020018#include <vector>
philipelbe7a9e52016-05-19 12:19:35 +020019
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +020020#include "absl/memory/memory.h"
Yves Gerey3e707812018-11-28 16:47:49 +010021#include "api/video/encoded_image.h"
22#include "api/video/video_timing.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020023#include "modules/video_coding/include/video_coding_defines.h"
24#include "modules/video_coding/jitter_estimator.h"
25#include "modules/video_coding/timing.h"
26#include "rtc_base/checks.h"
Yves Gerey3e707812018-11-28 16:47:49 +010027#include "rtc_base/experiments/rtt_mult_experiment.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020028#include "rtc_base/logging.h"
Yves Gerey3e707812018-11-28 16:47:49 +010029#include "rtc_base/numerics/sequence_number_util.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020030#include "rtc_base/trace_event.h"
31#include "system_wrappers/include/clock.h"
philipel707f2782017-10-02 14:10:28 +020032#include "system_wrappers/include/field_trial.h"
philipelbe7a9e52016-05-19 12:19:35 +020033
34namespace webrtc {
35namespace video_coding {
36
37namespace {
philipele0b2f152016-09-28 10:23:49 +020038// Max number of frames the buffer will hold.
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +010039constexpr size_t kMaxFramesBuffered = 800;
philipelbe7a9e52016-05-19 12:19:35 +020040
philipele0b2f152016-09-28 10:23:49 +020041// Max number of decoded frame info that will be saved.
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +010042constexpr int kMaxFramesHistory = 1 << 13;
philipel65e1f942017-07-24 08:26:53 -070043
Ilya Nikolaevskiy8c4fe162018-02-27 15:49:47 +010044// The time it's allowed for a frame to be late to its rendering prediction and
45// still be rendered.
Ilya Nikolaevskiy7eef0072018-02-28 09:59:26 +010046constexpr int kMaxAllowedFrameDelayMs = 5;
Ilya Nikolaevskiy8c4fe162018-02-27 15:49:47 +010047
philipel65e1f942017-07-24 08:26:53 -070048constexpr int64_t kLogNonDecodedIntervalMs = 5000;
philipelbe7a9e52016-05-19 12:19:35 +020049} // namespace
50
philipelbe7a9e52016-05-19 12:19:35 +020051FrameBuffer::FrameBuffer(Clock* clock,
philipela45102f2017-02-22 05:30:39 -080052 VCMTiming* timing,
53 VCMReceiveStatisticsCallback* stats_callback)
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +010054 : decoded_frames_history_(kMaxFramesHistory),
55 clock_(clock),
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +020056 callback_queue_(nullptr),
Niels Möllerd9c2d942019-04-30 09:16:36 +020057 jitter_estimator_(clock),
philipelbe7a9e52016-05-19 12:19:35 +020058 timing_(timing),
philipel4f6cd6a2016-08-03 10:59:32 +020059 inter_frame_delay_(clock_->TimeInMilliseconds()),
philipel29f730e2017-03-15 08:10:08 -070060 stopped_(false),
philipela45102f2017-02-22 05:30:39 -080061 protection_mode_(kProtectionNack),
philipel65e1f942017-07-24 08:26:53 -070062 stats_callback_(stats_callback),
Elad Alone4b50232019-01-14 18:56:14 +010063 last_log_non_decoded_ms_(-kLogNonDecodedIntervalMs),
64 add_rtt_to_playout_delay_(
“Michaeld3a4ebe2019-06-07 03:55:01 -050065 webrtc::field_trial::IsEnabled("WebRTC-AddRttToPlayoutDelay")),
Tommi430951a2020-05-19 23:27:29 +020066 rtt_mult_settings_(RttMultExperiment::GetRttMultValue()) {
67 callback_checker_.Detach();
68}
philipel266f0a42016-11-28 08:49:07 -080069
Tommi430951a2020-05-19 23:27:29 +020070FrameBuffer::~FrameBuffer() {
71 RTC_DCHECK_RUN_ON(&construction_checker_);
72}
philipelbe7a9e52016-05-19 12:19:35 +020073
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +020074void FrameBuffer::NextFrame(
75 int64_t max_wait_time_ms,
76 bool keyframe_required,
77 rtc::TaskQueue* callback_queue,
78 std::function<void(std::unique_ptr<EncodedFrame>, ReturnReason)> handler) {
Tommi430951a2020-05-19 23:27:29 +020079 RTC_DCHECK_RUN_ON(&callback_checker_);
80 RTC_DCHECK(callback_queue->IsCurrent());
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +020081 TRACE_EVENT0("webrtc", "FrameBuffer::NextFrame");
82 int64_t latest_return_time_ms =
83 clock_->TimeInMilliseconds() + max_wait_time_ms;
Tommi430951a2020-05-19 23:27:29 +020084
Markus Handell6deec382020-07-07 12:17:12 +020085 MutexLock lock(&mutex_);
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +020086 if (stopped_) {
87 return;
88 }
89 latest_return_time_ms_ = latest_return_time_ms;
90 keyframe_required_ = keyframe_required;
91 frame_handler_ = handler;
92 callback_queue_ = callback_queue;
93 StartWaitForNextFrameOnQueue();
94}
95
96void FrameBuffer::StartWaitForNextFrameOnQueue() {
97 RTC_DCHECK(callback_queue_);
98 RTC_DCHECK(!callback_task_.Running());
99 int64_t wait_ms = FindNextFrame(clock_->TimeInMilliseconds());
100 callback_task_ = RepeatingTaskHandle::DelayedStart(
Danil Chapovalov55284022020-02-07 14:53:52 +0100101 callback_queue_->Get(), TimeDelta::Millis(wait_ms), [this] {
Tommi430951a2020-05-19 23:27:29 +0200102 RTC_DCHECK_RUN_ON(&callback_checker_);
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200103 // If this task has not been cancelled, we did not get any new frames
104 // while waiting. Continue with frame delivery.
Markus Handell6deec382020-07-07 12:17:12 +0200105 MutexLock lock(&mutex_);
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200106 if (!frames_to_decode_.empty()) {
107 // We have frames, deliver!
108 frame_handler_(absl::WrapUnique(GetNextFrame()), kFrameFound);
109 CancelCallback();
110 return TimeDelta::Zero(); // Ignored.
111 } else if (clock_->TimeInMilliseconds() >= latest_return_time_ms_) {
112 // We have timed out, signal this and stop repeating.
113 frame_handler_(nullptr, kTimeout);
114 CancelCallback();
115 return TimeDelta::Zero(); // Ignored.
116 } else {
117 // If there's no frames to decode and there is still time left, it
118 // means that the frame buffer was cleared between creation and
119 // execution of this task. Continue waiting for the remaining time.
120 int64_t wait_ms = FindNextFrame(clock_->TimeInMilliseconds());
Danil Chapovalov55284022020-02-07 14:53:52 +0100121 return TimeDelta::Millis(wait_ms);
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200122 }
123 });
124}
125
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200126int64_t FrameBuffer::FindNextFrame(int64_t now_ms) {
127 int64_t wait_ms = latest_return_time_ms_ - now_ms;
128 frames_to_decode_.clear();
129
130 // |last_continuous_frame_| may be empty below, but nullopt is smaller
131 // than everything else and loop will immediately terminate as expected.
132 for (auto frame_it = frames_.begin();
133 frame_it != frames_.end() && frame_it->first <= last_continuous_frame_;
134 ++frame_it) {
135 if (!frame_it->second.continuous ||
136 frame_it->second.num_missing_decodable > 0) {
137 continue;
138 }
139
140 EncodedFrame* frame = frame_it->second.frame.get();
141
142 if (keyframe_required_ && !frame->is_keyframe())
143 continue;
144
145 auto last_decoded_frame_timestamp =
146 decoded_frames_history_.GetLastDecodedFrameTimestamp();
147
148 // TODO(https://bugs.webrtc.org/9974): consider removing this check
149 // as it may make a stream undecodable after a very long delay between
150 // frames.
151 if (last_decoded_frame_timestamp &&
152 AheadOf(*last_decoded_frame_timestamp, frame->Timestamp())) {
153 continue;
154 }
155
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200156 // Gather all remaining frames for the same superframe.
157 std::vector<FrameMap::iterator> current_superframe;
158 current_superframe.push_back(frame_it);
159 bool last_layer_completed = frame_it->second.frame->is_last_spatial_layer;
160 FrameMap::iterator next_frame_it = frame_it;
philipela65d7852020-11-20 17:49:24 +0100161 while (!last_layer_completed) {
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200162 ++next_frame_it;
philipela65d7852020-11-20 17:49:24 +0100163
164 if (next_frame_it == frames_.end() || !next_frame_it->second.frame) {
165 break;
166 }
167
168 if (next_frame_it->second.frame->Timestamp() != frame->Timestamp() ||
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200169 !next_frame_it->second.continuous) {
170 break;
171 }
philipela65d7852020-11-20 17:49:24 +0100172
173 if (next_frame_it->second.num_missing_decodable > 0) {
philipelcb327d92020-12-10 10:49:20 +0100174 bool has_inter_layer_dependency = false;
175 for (size_t i = 0; i < EncodedFrame::kMaxFrameReferences &&
philipela65d7852020-11-20 17:49:24 +0100176 i < next_frame_it->second.frame->num_references;
177 ++i) {
178 if (next_frame_it->second.frame->references[i] >=
179 frame_it->first.picture_id) {
180 has_inter_layer_dependency = true;
philipelcb327d92020-12-10 10:49:20 +0100181 break;
philipela65d7852020-11-20 17:49:24 +0100182 }
183 }
184
185 // If the frame has an undecoded dependency that is not within the same
philipelcb327d92020-12-10 10:49:20 +0100186 // temporal unit then this frame is not yet ready to be decoded. If it
philipela65d7852020-11-20 17:49:24 +0100187 // is within the same temporal unit then the not yet decoded dependency
188 // is just a lower spatial frame, which is ok.
189 if (!has_inter_layer_dependency ||
190 next_frame_it->second.num_missing_decodable > 1) {
191 break;
192 }
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200193 }
philipela65d7852020-11-20 17:49:24 +0100194
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200195 current_superframe.push_back(next_frame_it);
196 last_layer_completed = next_frame_it->second.frame->is_last_spatial_layer;
197 }
198 // Check if the current superframe is complete.
199 // TODO(bugs.webrtc.org/10064): consider returning all available to
200 // decode frames even if the superframe is not complete yet.
201 if (!last_layer_completed) {
202 continue;
203 }
204
205 frames_to_decode_ = std::move(current_superframe);
206
207 if (frame->RenderTime() == -1) {
208 frame->SetRenderTime(timing_->RenderTimeMs(frame->Timestamp(), now_ms));
209 }
210 wait_ms = timing_->MaxWaitingTime(frame->RenderTime(), now_ms);
211
212 // This will cause the frame buffer to prefer high framerate rather
213 // than high resolution in the case of the decoder not decoding fast
214 // enough and the stream has multiple spatial and temporal layers.
215 // For multiple temporal layers it may cause non-base layer frames to be
216 // skipped if they are late.
217 if (wait_ms < -kMaxAllowedFrameDelayMs)
218 continue;
219
220 break;
221 }
222 wait_ms = std::min<int64_t>(wait_ms, latest_return_time_ms_ - now_ms);
223 wait_ms = std::max<int64_t>(wait_ms, 0);
224 return wait_ms;
225}
226
227EncodedFrame* FrameBuffer::GetNextFrame() {
Tommi430951a2020-05-19 23:27:29 +0200228 RTC_DCHECK_RUN_ON(&callback_checker_);
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200229 int64_t now_ms = clock_->TimeInMilliseconds();
230 // TODO(ilnik): remove |frames_out| use frames_to_decode_ directly.
231 std::vector<EncodedFrame*> frames_out;
232
233 RTC_DCHECK(!frames_to_decode_.empty());
234 bool superframe_delayed_by_retransmission = false;
235 size_t superframe_size = 0;
236 EncodedFrame* first_frame = frames_to_decode_[0]->second.frame.get();
237 int64_t render_time_ms = first_frame->RenderTime();
238 int64_t receive_time_ms = first_frame->ReceivedTime();
239 // Gracefully handle bad RTP timestamps and render time issues.
240 if (HasBadRenderTiming(*first_frame, now_ms)) {
Niels Möllerd9c2d942019-04-30 09:16:36 +0200241 jitter_estimator_.Reset();
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200242 timing_->Reset();
243 render_time_ms = timing_->RenderTimeMs(first_frame->Timestamp(), now_ms);
244 }
245
246 for (FrameMap::iterator& frame_it : frames_to_decode_) {
247 RTC_DCHECK(frame_it != frames_.end());
248 EncodedFrame* frame = frame_it->second.frame.release();
249
250 frame->SetRenderTime(render_time_ms);
251
252 superframe_delayed_by_retransmission |= frame->delayed_by_retransmission();
253 receive_time_ms = std::max(receive_time_ms, frame->ReceivedTime());
254 superframe_size += frame->size();
255
256 PropagateDecodability(frame_it->second);
257 decoded_frames_history_.InsertDecoded(frame_it->first, frame->Timestamp());
258
259 // Remove decoded frame and all undecoded frames before it.
Johannes Kron0c141c52019-08-26 15:04:43 +0200260 if (stats_callback_) {
261 unsigned int dropped_frames = std::count_if(
262 frames_.begin(), frame_it,
263 [](const std::pair<const VideoLayerFrameId, FrameInfo>& frame) {
264 return frame.second.frame != nullptr;
265 });
266 if (dropped_frames > 0) {
267 stats_callback_->OnDroppedFrames(dropped_frames);
268 }
269 }
270
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200271 frames_.erase(frames_.begin(), ++frame_it);
272
273 frames_out.push_back(frame);
274 }
275
276 if (!superframe_delayed_by_retransmission) {
277 int64_t frame_delay;
278
279 if (inter_frame_delay_.CalculateDelay(first_frame->Timestamp(),
280 &frame_delay, receive_time_ms)) {
Niels Möllerd9c2d942019-04-30 09:16:36 +0200281 jitter_estimator_.UpdateEstimate(frame_delay, superframe_size);
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200282 }
283
284 float rtt_mult = protection_mode_ == kProtectionNackFEC ? 0.0 : 1.0;
“Michaeld3a4ebe2019-06-07 03:55:01 -0500285 absl::optional<float> rtt_mult_add_cap_ms = absl::nullopt;
286 if (rtt_mult_settings_.has_value()) {
287 rtt_mult = rtt_mult_settings_->rtt_mult_setting;
288 rtt_mult_add_cap_ms = rtt_mult_settings_->rtt_mult_add_cap_ms;
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200289 }
“Michaele0f37042019-06-04 10:04:12 -0500290 timing_->SetJitterDelay(
291 jitter_estimator_.GetJitterEstimate(rtt_mult, rtt_mult_add_cap_ms));
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200292 timing_->UpdateCurrentDelay(render_time_ms, now_ms);
293 } else {
294 if (RttMultExperiment::RttMultEnabled() || add_rtt_to_playout_delay_)
Niels Möllerd9c2d942019-04-30 09:16:36 +0200295 jitter_estimator_.FrameNacked();
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200296 }
297
298 UpdateJitterDelay();
299 UpdateTimingFrameInfo();
300
301 if (frames_out.size() == 1) {
302 return frames_out[0];
303 } else {
304 return CombineAndDeleteFrames(frames_out);
305 }
306}
307
philipele7c891f2018-02-22 14:35:06 +0100308bool FrameBuffer::HasBadRenderTiming(const EncodedFrame& frame,
309 int64_t now_ms) {
stefan95e97542017-05-23 09:52:18 -0700310 // Assume that render timing errors are due to changes in the video stream.
311 int64_t render_time_ms = frame.RenderTimeMs();
Stefan Holmer812ceaf2018-05-15 13:00:10 +0200312 // Zero render time means render immediately.
313 if (render_time_ms == 0) {
314 return false;
315 }
stefan95e97542017-05-23 09:52:18 -0700316 if (render_time_ms < 0) {
317 return true;
318 }
Stefan Holmer812ceaf2018-05-15 13:00:10 +0200319 const int64_t kMaxVideoDelayMs = 10000;
stefan95e97542017-05-23 09:52:18 -0700320 if (std::abs(render_time_ms - now_ms) > kMaxVideoDelayMs) {
321 int frame_delay = static_cast<int>(std::abs(render_time_ms - now_ms));
Mirko Bonadei675513b2017-11-09 11:09:25 +0100322 RTC_LOG(LS_WARNING)
323 << "A frame about to be decoded is out of the configured "
Jonas Olssonb2b20312020-01-14 12:11:31 +0100324 "delay bounds ("
325 << frame_delay << " > " << kMaxVideoDelayMs
Mirko Bonadei675513b2017-11-09 11:09:25 +0100326 << "). Resetting the video jitter buffer.";
stefan95e97542017-05-23 09:52:18 -0700327 return true;
328 }
329 if (static_cast<int>(timing_->TargetVideoDelay()) > kMaxVideoDelayMs) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100330 RTC_LOG(LS_WARNING) << "The video target delay has grown larger than "
331 << kMaxVideoDelayMs << " ms.";
stefan95e97542017-05-23 09:52:18 -0700332 return true;
333 }
334 return false;
335}
336
philipel4f6cd6a2016-08-03 10:59:32 +0200337void FrameBuffer::SetProtectionMode(VCMVideoProtection mode) {
tommidb23ea62017-03-03 07:21:18 -0800338 TRACE_EVENT0("webrtc", "FrameBuffer::SetProtectionMode");
Markus Handell6deec382020-07-07 12:17:12 +0200339 MutexLock lock(&mutex_);
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000340 protection_mode_ = mode;
philipel4f6cd6a2016-08-03 10:59:32 +0200341}
342
philipel504c47d2016-06-30 17:33:02 +0200343void FrameBuffer::Stop() {
tommidb23ea62017-03-03 07:21:18 -0800344 TRACE_EVENT0("webrtc", "FrameBuffer::Stop");
Markus Handell6deec382020-07-07 12:17:12 +0200345 MutexLock lock(&mutex_);
Tommi430951a2020-05-19 23:27:29 +0200346 if (stopped_)
347 return;
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000348 stopped_ = true;
Tommi430951a2020-05-19 23:27:29 +0200349
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200350 CancelCallback();
philipel504c47d2016-06-30 17:33:02 +0200351}
352
Ilya Nikolaevskiye6a2d942018-11-07 14:32:28 +0100353void FrameBuffer::Clear() {
Markus Handell6deec382020-07-07 12:17:12 +0200354 MutexLock lock(&mutex_);
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000355 ClearFramesAndHistory();
Ilya Nikolaevskiye6a2d942018-11-07 14:32:28 +0100356}
357
Johannes Kron111e9812020-10-26 13:54:40 +0100358int FrameBuffer::Size() {
359 MutexLock lock(&mutex_);
360 return frames_.size();
361}
362
philipele21be1d2017-09-25 06:37:12 -0700363void FrameBuffer::UpdateRtt(int64_t rtt_ms) {
Markus Handell6deec382020-07-07 12:17:12 +0200364 MutexLock lock(&mutex_);
Niels Möllerd9c2d942019-04-30 09:16:36 +0200365 jitter_estimator_.UpdateRtt(rtt_ms);
philipele21be1d2017-09-25 06:37:12 -0700366}
367
philipele7c891f2018-02-22 14:35:06 +0100368bool FrameBuffer::ValidReferences(const EncodedFrame& frame) const {
philipel112adf92017-06-15 09:06:21 -0700369 for (size_t i = 0; i < frame.num_references; ++i) {
Philip Eliasson1f850a62019-03-19 12:15:00 +0000370 if (frame.references[i] >= frame.id.picture_id)
philipel112adf92017-06-15 09:06:21 -0700371 return false;
philipel3b3c9c42017-09-11 09:38:36 -0700372
philipel112adf92017-06-15 09:06:21 -0700373 for (size_t j = i + 1; j < frame.num_references; ++j) {
374 if (frame.references[i] == frame.references[j])
375 return false;
376 }
377 }
378
philipel112adf92017-06-15 09:06:21 -0700379 return true;
380}
381
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200382void FrameBuffer::CancelCallback() {
Tommi430951a2020-05-19 23:27:29 +0200383 // Called from the callback queue or from within Stop().
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200384 frame_handler_ = {};
385 callback_task_.Stop();
386 callback_queue_ = nullptr;
Tommi430951a2020-05-19 23:27:29 +0200387 callback_checker_.Detach();
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200388}
389
philipele7c891f2018-02-22 14:35:06 +0100390int64_t FrameBuffer::InsertFrame(std::unique_ptr<EncodedFrame> frame) {
tommidb23ea62017-03-03 07:21:18 -0800391 TRACE_EVENT0("webrtc", "FrameBuffer::InsertFrame");
philipel93e451b2016-10-06 12:25:13 +0200392 RTC_DCHECK(frame);
tommi0a735642017-03-14 06:23:57 -0700393
Markus Handell6deec382020-07-07 12:17:12 +0200394 MutexLock lock(&mutex_);
philipel29f730e2017-03-15 08:10:08 -0700395
Ilya Nikolaevskiy48193b02019-03-25 11:40:34 +0100396 const VideoLayerFrameId& id = frame->id;
philipel1610f942017-12-12 13:58:31 +0100397 int64_t last_continuous_picture_id =
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100398 !last_continuous_frame_ ? -1 : last_continuous_frame_->picture_id;
philipele0b2f152016-09-28 10:23:49 +0200399
philipel112adf92017-06-15 09:06:21 -0700400 if (!ValidReferences(*frame)) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100401 RTC_LOG(LS_WARNING) << "Frame with (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100402 << id.picture_id << ":"
403 << static_cast<int>(id.spatial_layer)
Mirko Bonadei675513b2017-11-09 11:09:25 +0100404 << ") has invalid frame references, dropping frame.";
philipel112adf92017-06-15 09:06:21 -0700405 return last_continuous_picture_id;
406 }
407
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100408 if (frames_.size() >= kMaxFramesBuffered) {
philipel9771c502018-03-02 11:06:27 +0100409 if (frame->is_keyframe()) {
410 RTC_LOG(LS_WARNING) << "Inserting keyframe (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100411 << id.picture_id << ":"
412 << static_cast<int>(id.spatial_layer)
philipel9771c502018-03-02 11:06:27 +0100413 << ") but buffer is full, clearing"
Jonas Olssonb2b20312020-01-14 12:11:31 +0100414 " buffer and inserting the frame.";
philipel9771c502018-03-02 11:06:27 +0100415 ClearFramesAndHistory();
416 } else {
417 RTC_LOG(LS_WARNING) << "Frame with (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100418 << id.picture_id << ":"
419 << static_cast<int>(id.spatial_layer)
philipel9771c502018-03-02 11:06:27 +0100420 << ") could not be inserted due to the frame "
Jonas Olssonb2b20312020-01-14 12:11:31 +0100421 "buffer being full, dropping frame.";
philipel9771c502018-03-02 11:06:27 +0100422 return last_continuous_picture_id;
423 }
philipele0b2f152016-09-28 10:23:49 +0200424 }
425
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100426 auto last_decoded_frame = decoded_frames_history_.GetLastDecodedFrameId();
427 auto last_decoded_frame_timestamp =
428 decoded_frames_history_.GetLastDecodedFrameTimestamp();
429 if (last_decoded_frame && id <= *last_decoded_frame) {
430 if (AheadOf(frame->Timestamp(), *last_decoded_frame_timestamp) &&
philipel3042c2d2017-08-18 04:55:02 -0700431 frame->is_keyframe()) {
philipelfcc60062017-01-18 05:35:20 -0800432 // If this frame has a newer timestamp but an earlier picture id then we
433 // assume there has been a jump in the picture id due to some encoder
434 // reconfiguration or some other reason. Even though this is not according
435 // to spec we can still continue to decode from this frame if it is a
436 // keyframe.
Mirko Bonadei675513b2017-11-09 11:09:25 +0100437 RTC_LOG(LS_WARNING)
438 << "A jump in picture id was detected, clearing buffer.";
philipelfcc60062017-01-18 05:35:20 -0800439 ClearFramesAndHistory();
440 last_continuous_picture_id = -1;
441 } else {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100442 RTC_LOG(LS_WARNING) << "Frame with (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100443 << id.picture_id << ":"
444 << static_cast<int>(id.spatial_layer)
Mirko Bonadei675513b2017-11-09 11:09:25 +0100445 << ") inserted after frame ("
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100446 << last_decoded_frame->picture_id << ":"
447 << static_cast<int>(last_decoded_frame->spatial_layer)
Mirko Bonadei675513b2017-11-09 11:09:25 +0100448 << ") was handed off for decoding, dropping frame.";
philipelfcc60062017-01-18 05:35:20 -0800449 return last_continuous_picture_id;
450 }
philipele0b2f152016-09-28 10:23:49 +0200451 }
452
philipel146a48b2017-04-20 04:04:38 -0700453 // Test if inserting this frame would cause the order of the frames to become
454 // ambiguous (covering more than half the interval of 2^16). This can happen
455 // when the picture id make large jumps mid stream.
philipel0fa82a62018-03-19 15:34:53 +0100456 if (!frames_.empty() && id < frames_.begin()->first &&
457 frames_.rbegin()->first < id) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100458 RTC_LOG(LS_WARNING)
459 << "A jump in picture id was detected, clearing buffer.";
philipel146a48b2017-04-20 04:04:38 -0700460 ClearFramesAndHistory();
461 last_continuous_picture_id = -1;
462 }
463
philipel0fa82a62018-03-19 15:34:53 +0100464 auto info = frames_.emplace(id, FrameInfo()).first;
philipele0b2f152016-09-28 10:23:49 +0200465
philipel93e451b2016-10-06 12:25:13 +0200466 if (info->second.frame) {
philipele0b2f152016-09-28 10:23:49 +0200467 return last_continuous_picture_id;
468 }
469
philipel93e451b2016-10-06 12:25:13 +0200470 if (!UpdateFrameInfoWithIncomingFrame(*frame, info))
471 return last_continuous_picture_id;
Ruslan Burakov493a6502019-02-27 15:32:48 +0100472
473 if (!frame->delayed_by_retransmission())
474 timing_->IncomingTimestamp(frame->Timestamp(), frame->ReceivedTime());
philipel0a9f6de2018-02-28 11:29:47 +0100475
philipel0cb73262020-12-08 17:36:53 +0100476 // It can happen that a frame will be reported as fully received even if a
477 // lower spatial layer frame is missing.
478 if (stats_callback_ && frame->is_last_spatial_layer) {
Johannes Kronb88b44e2019-08-22 13:16:44 +0200479 stats_callback_->OnCompleteFrame(frame->is_keyframe(), frame->size(),
480 frame->contentType());
481 }
482
philipele0b2f152016-09-28 10:23:49 +0200483 info->second.frame = std::move(frame);
philipele0b2f152016-09-28 10:23:49 +0200484
485 if (info->second.num_missing_continuous == 0) {
486 info->second.continuous = true;
487 PropagateContinuity(info);
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100488 last_continuous_picture_id = last_continuous_frame_->picture_id;
philipele0b2f152016-09-28 10:23:49 +0200489
490 // Since we now have new continuous frames there might be a better frame
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200491 // to return from NextFrame.
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200492 if (callback_queue_) {
493 callback_queue_->PostTask([this] {
Markus Handell6deec382020-07-07 12:17:12 +0200494 MutexLock lock(&mutex_);
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200495 if (!callback_task_.Running())
496 return;
497 RTC_CHECK(frame_handler_);
498 callback_task_.Stop();
499 StartWaitForNextFrameOnQueue();
500 });
501 }
philipele0b2f152016-09-28 10:23:49 +0200502 }
503
504 return last_continuous_picture_id;
philipelbe7a9e52016-05-19 12:19:35 +0200505}
506
philipele0b2f152016-09-28 10:23:49 +0200507void FrameBuffer::PropagateContinuity(FrameMap::iterator start) {
tommidb23ea62017-03-03 07:21:18 -0800508 TRACE_EVENT0("webrtc", "FrameBuffer::PropagateContinuity");
philipele0b2f152016-09-28 10:23:49 +0200509 RTC_DCHECK(start->second.continuous);
philipele0b2f152016-09-28 10:23:49 +0200510
511 std::queue<FrameMap::iterator> continuous_frames;
512 continuous_frames.push(start);
513
514 // A simple BFS to traverse continuous frames.
515 while (!continuous_frames.empty()) {
516 auto frame = continuous_frames.front();
517 continuous_frames.pop();
518
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100519 if (!last_continuous_frame_ || *last_continuous_frame_ < frame->first) {
520 last_continuous_frame_ = frame->first;
521 }
philipele0b2f152016-09-28 10:23:49 +0200522
523 // Loop through all dependent frames, and if that frame no longer has
524 // any unfulfilled dependencies then that frame is continuous as well.
Elad Alon69321dd2019-01-10 15:02:54 +0100525 for (size_t d = 0; d < frame->second.dependent_frames.size(); ++d) {
philipele0b2f152016-09-28 10:23:49 +0200526 auto frame_ref = frames_.find(frame->second.dependent_frames[d]);
philipel112adf92017-06-15 09:06:21 -0700527 RTC_DCHECK(frame_ref != frames_.end());
philipele0b2f152016-09-28 10:23:49 +0200528
philipel112adf92017-06-15 09:06:21 -0700529 // TODO(philipel): Look into why we've seen this happen.
530 if (frame_ref != frames_.end()) {
531 --frame_ref->second.num_missing_continuous;
532 if (frame_ref->second.num_missing_continuous == 0) {
533 frame_ref->second.continuous = true;
534 continuous_frames.push(frame_ref);
535 }
philipele0b2f152016-09-28 10:23:49 +0200536 }
537 }
538 }
539}
540
541void FrameBuffer::PropagateDecodability(const FrameInfo& info) {
tommidb23ea62017-03-03 07:21:18 -0800542 TRACE_EVENT0("webrtc", "FrameBuffer::PropagateDecodability");
Elad Alon69321dd2019-01-10 15:02:54 +0100543 for (size_t d = 0; d < info.dependent_frames.size(); ++d) {
philipele0b2f152016-09-28 10:23:49 +0200544 auto ref_info = frames_.find(info.dependent_frames[d]);
philipel93e451b2016-10-06 12:25:13 +0200545 RTC_DCHECK(ref_info != frames_.end());
tommie95b78b2017-05-14 07:23:11 -0700546 // TODO(philipel): Look into why we've seen this happen.
547 if (ref_info != frames_.end()) {
548 RTC_DCHECK_GT(ref_info->second.num_missing_decodable, 0U);
549 --ref_info->second.num_missing_decodable;
550 }
philipele0b2f152016-09-28 10:23:49 +0200551 }
552}
553
philipele7c891f2018-02-22 14:35:06 +0100554bool FrameBuffer::UpdateFrameInfoWithIncomingFrame(const EncodedFrame& frame,
philipele0b2f152016-09-28 10:23:49 +0200555 FrameMap::iterator info) {
tommidb23ea62017-03-03 07:21:18 -0800556 TRACE_EVENT0("webrtc", "FrameBuffer::UpdateFrameInfoWithIncomingFrame");
philipel0fa82a62018-03-19 15:34:53 +0100557 const VideoLayerFrameId& id = frame.id;
philipele0b2f152016-09-28 10:23:49 +0200558
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100559 auto last_decoded_frame = decoded_frames_history_.GetLastDecodedFrameId();
560 RTC_DCHECK(!last_decoded_frame || *last_decoded_frame < info->first);
philipele0b2f152016-09-28 10:23:49 +0200561
philipel798b2822018-06-11 13:10:14 +0200562 // In this function we determine how many missing dependencies this |frame|
563 // has to become continuous/decodable. If a frame that this |frame| depend
564 // on has already been decoded then we can ignore that dependency since it has
565 // already been fulfilled.
566 //
567 // For all other frames we will register a backwards reference to this |frame|
568 // so that |num_missing_continuous| and |num_missing_decodable| can be
569 // decremented as frames become continuous/are decoded.
570 struct Dependency {
571 VideoLayerFrameId id;
572 bool continuous;
573 };
574 std::vector<Dependency> not_yet_fulfilled_dependencies;
575
576 // Find all dependencies that have not yet been fulfilled.
philipele0b2f152016-09-28 10:23:49 +0200577 for (size_t i = 0; i < frame.num_references; ++i) {
philipel0fa82a62018-03-19 15:34:53 +0100578 VideoLayerFrameId ref_key(frame.references[i], frame.id.spatial_layer);
philipel798b2822018-06-11 13:10:14 +0200579 // Does |frame| depend on a frame earlier than the last decoded one?
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100580 if (last_decoded_frame && ref_key <= *last_decoded_frame) {
philipel798b2822018-06-11 13:10:14 +0200581 // Was that frame decoded? If not, this |frame| will never become
582 // decodable.
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100583 if (!decoded_frames_history_.WasDecoded(ref_key)) {
philipel65e1f942017-07-24 08:26:53 -0700584 int64_t now_ms = clock_->TimeInMilliseconds();
585 if (last_log_non_decoded_ms_ + kLogNonDecodedIntervalMs < now_ms) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100586 RTC_LOG(LS_WARNING)
philipel0fa82a62018-03-19 15:34:53 +0100587 << "Frame with (picture_id:spatial_id) (" << id.picture_id << ":"
588 << static_cast<int>(id.spatial_layer)
philipel65e1f942017-07-24 08:26:53 -0700589 << ") depends on a non-decoded frame more previous than"
Jonas Olssonb2b20312020-01-14 12:11:31 +0100590 " the last decoded frame, dropping frame.";
philipel65e1f942017-07-24 08:26:53 -0700591 last_log_non_decoded_ms_ = now_ms;
592 }
philipele0b2f152016-09-28 10:23:49 +0200593 return false;
594 }
philipele0b2f152016-09-28 10:23:49 +0200595 } else {
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100596 auto ref_info = frames_.find(ref_key);
philipel798b2822018-06-11 13:10:14 +0200597 bool ref_continuous =
598 ref_info != frames_.end() && ref_info->second.continuous;
599 not_yet_fulfilled_dependencies.push_back({ref_key, ref_continuous});
philipele0b2f152016-09-28 10:23:49 +0200600 }
philipelbe7a9e52016-05-19 12:19:35 +0200601 }
602
philipel798b2822018-06-11 13:10:14 +0200603 info->second.num_missing_continuous = not_yet_fulfilled_dependencies.size();
604 info->second.num_missing_decodable = not_yet_fulfilled_dependencies.size();
605
606 for (const Dependency& dep : not_yet_fulfilled_dependencies) {
607 if (dep.continuous)
608 --info->second.num_missing_continuous;
609
Elad Alon69321dd2019-01-10 15:02:54 +0100610 frames_[dep.id].dependent_frames.push_back(id);
philipel798b2822018-06-11 13:10:14 +0200611 }
philipel93e451b2016-10-06 12:25:13 +0200612
philipelbe7a9e52016-05-19 12:19:35 +0200613 return true;
614}
615
philipelbe742702016-11-30 01:31:40 -0800616void FrameBuffer::UpdateJitterDelay() {
tommidb23ea62017-03-03 07:21:18 -0800617 TRACE_EVENT0("webrtc", "FrameBuffer::UpdateJitterDelay");
philipela45102f2017-02-22 05:30:39 -0800618 if (!stats_callback_)
619 return;
philipelbe742702016-11-30 01:31:40 -0800620
philipela45102f2017-02-22 05:30:39 -0800621 int max_decode_ms;
622 int current_delay_ms;
623 int target_delay_ms;
624 int jitter_buffer_ms;
625 int min_playout_delay_ms;
626 int render_delay_ms;
Johannes Kronbfd343b2019-07-01 10:07:50 +0200627 if (timing_->GetTimings(&max_decode_ms, &current_delay_ms, &target_delay_ms,
628 &jitter_buffer_ms, &min_playout_delay_ms,
629 &render_delay_ms)) {
philipela45102f2017-02-22 05:30:39 -0800630 stats_callback_->OnFrameBufferTimingsUpdated(
Johannes Kronbfd343b2019-07-01 10:07:50 +0200631 max_decode_ms, current_delay_ms, target_delay_ms, jitter_buffer_ms,
632 min_playout_delay_ms, render_delay_ms);
philipelbe742702016-11-30 01:31:40 -0800633 }
philipel266f0a42016-11-28 08:49:07 -0800634}
635
ilnik2edc6842017-07-06 03:06:50 -0700636void FrameBuffer::UpdateTimingFrameInfo() {
637 TRACE_EVENT0("webrtc", "FrameBuffer::UpdateTimingFrameInfo");
Danil Chapovalov0040b662018-06-18 10:48:16 +0200638 absl::optional<TimingFrameInfo> info = timing_->GetTimingFrameInfo();
philipel97187112018-03-23 10:43:21 +0100639 if (info && stats_callback_)
ilnik2edc6842017-07-06 03:06:50 -0700640 stats_callback_->OnTimingFrameInfoUpdated(*info);
641}
642
philipelfcc60062017-01-18 05:35:20 -0800643void FrameBuffer::ClearFramesAndHistory() {
ilnik2edc6842017-07-06 03:06:50 -0700644 TRACE_EVENT0("webrtc", "FrameBuffer::ClearFramesAndHistory");
Johannes Kron0c141c52019-08-26 15:04:43 +0200645 if (stats_callback_) {
646 unsigned int dropped_frames = std::count_if(
647 frames_.begin(), frames_.end(),
648 [](const std::pair<const VideoLayerFrameId, FrameInfo>& frame) {
649 return frame.second.frame != nullptr;
650 });
651 if (dropped_frames > 0) {
652 stats_callback_->OnDroppedFrames(dropped_frames);
653 }
654 }
philipelfcc60062017-01-18 05:35:20 -0800655 frames_.clear();
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100656 last_continuous_frame_.reset();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100657 frames_to_decode_.clear();
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100658 decoded_frames_history_.Clear();
philipelfcc60062017-01-18 05:35:20 -0800659}
660
Niels Möllerff2e2152019-09-27 10:29:30 +0200661// TODO(philipel): Avoid the concatenation of frames here, by replacing
662// NextFrame and GetNextFrame with methods returning multiple frames.
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100663EncodedFrame* FrameBuffer::CombineAndDeleteFrames(
664 const std::vector<EncodedFrame*>& frames) const {
665 RTC_DCHECK(!frames.empty());
Sergey Silkin61832dd2018-12-20 14:32:14 +0100666 EncodedFrame* first_frame = frames[0];
667 EncodedFrame* last_frame = frames.back();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100668 size_t total_length = 0;
669 for (size_t i = 0; i < frames.size(); ++i) {
670 total_length += frames[i]->size();
671 }
Niels Möllerff2e2152019-09-27 10:29:30 +0200672 auto encoded_image_buffer = EncodedImageBuffer::Create(total_length);
673 uint8_t* buffer = encoded_image_buffer->data();
philipel0cb73262020-12-08 17:36:53 +0100674 first_frame->SetSpatialLayerFrameSize(first_frame->SpatialIndex().value_or(0),
Sergey Silkin2799e632019-05-17 09:51:39 +0200675 first_frame->size());
Niels Möllerff2e2152019-09-27 10:29:30 +0200676 memcpy(buffer, first_frame->data(), first_frame->size());
677 buffer += first_frame->size();
Sergey Silkin2799e632019-05-17 09:51:39 +0200678
Sergey Silkin61832dd2018-12-20 14:32:14 +0100679 // Spatial index of combined frame is set equal to spatial index of its top
680 // spatial layer.
philipel0cb73262020-12-08 17:36:53 +0100681 first_frame->SetSpatialIndex(last_frame->SpatialIndex().value_or(0));
Sergey Silkin61832dd2018-12-20 14:32:14 +0100682 first_frame->id.spatial_layer = last_frame->id.spatial_layer;
683
684 first_frame->video_timing_mutable()->network2_timestamp_ms =
685 last_frame->video_timing().network2_timestamp_ms;
686 first_frame->video_timing_mutable()->receive_finish_ms =
687 last_frame->video_timing().receive_finish_ms;
688
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100689 // Append all remaining frames to the first one.
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100690 for (size_t i = 1; i < frames.size(); ++i) {
Sergey Silkin61832dd2018-12-20 14:32:14 +0100691 EncodedFrame* next_frame = frames[i];
philipel0cb73262020-12-08 17:36:53 +0100692 first_frame->SetSpatialLayerFrameSize(
693 next_frame->SpatialIndex().value_or(0), next_frame->size());
Niels Möller9c843902019-01-11 10:21:35 +0100694 memcpy(buffer, next_frame->data(), next_frame->size());
Sergey Silkin61832dd2018-12-20 14:32:14 +0100695 buffer += next_frame->size();
696 delete next_frame;
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100697 }
Niels Möllerff2e2152019-09-27 10:29:30 +0200698 first_frame->SetEncodedData(encoded_image_buffer);
Sergey Silkin61832dd2018-12-20 14:32:14 +0100699 return first_frame;
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100700}
701
Niels Möllerbe682d42018-03-27 08:31:45 +0200702FrameBuffer::FrameInfo::FrameInfo() = default;
703FrameBuffer::FrameInfo::FrameInfo(FrameInfo&&) = default;
704FrameBuffer::FrameInfo::~FrameInfo() = default;
705
philipelbe7a9e52016-05-19 12:19:35 +0200706} // namespace video_coding
707} // namespace webrtc