blob: 88ac09c4969614be9eb5041d6a1717a942fc2230 [file] [log] [blame]
philipelbe7a9e52016-05-19 12:19:35 +02001/*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020011#include "modules/video_coding/frame_buffer2.h"
philipelbe7a9e52016-05-19 12:19:35 +020012
13#include <algorithm>
Yves Gerey3e707812018-11-28 16:47:49 +010014#include <cstdlib>
15#include <iterator>
philipele0b2f152016-09-28 10:23:49 +020016#include <queue>
Yves Gerey3e707812018-11-28 16:47:49 +010017#include <utility>
philipel798b2822018-06-11 13:10:14 +020018#include <vector>
philipelbe7a9e52016-05-19 12:19:35 +020019
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +020020#include "absl/memory/memory.h"
Yves Gerey3e707812018-11-28 16:47:49 +010021#include "api/video/encoded_image.h"
22#include "api/video/video_timing.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020023#include "modules/video_coding/include/video_coding_defines.h"
24#include "modules/video_coding/jitter_estimator.h"
25#include "modules/video_coding/timing.h"
26#include "rtc_base/checks.h"
Yves Gerey3e707812018-11-28 16:47:49 +010027#include "rtc_base/experiments/rtt_mult_experiment.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020028#include "rtc_base/logging.h"
Yves Gerey3e707812018-11-28 16:47:49 +010029#include "rtc_base/numerics/sequence_number_util.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020030#include "rtc_base/trace_event.h"
31#include "system_wrappers/include/clock.h"
philipel707f2782017-10-02 14:10:28 +020032#include "system_wrappers/include/field_trial.h"
philipelbe7a9e52016-05-19 12:19:35 +020033
34namespace webrtc {
35namespace video_coding {
36
37namespace {
philipele0b2f152016-09-28 10:23:49 +020038// Max number of frames the buffer will hold.
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +010039constexpr size_t kMaxFramesBuffered = 800;
philipelbe7a9e52016-05-19 12:19:35 +020040
philipele0b2f152016-09-28 10:23:49 +020041// Max number of decoded frame info that will be saved.
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +010042constexpr int kMaxFramesHistory = 1 << 13;
philipel65e1f942017-07-24 08:26:53 -070043
Ilya Nikolaevskiy8c4fe162018-02-27 15:49:47 +010044// The time it's allowed for a frame to be late to its rendering prediction and
45// still be rendered.
Ilya Nikolaevskiy7eef0072018-02-28 09:59:26 +010046constexpr int kMaxAllowedFrameDelayMs = 5;
Ilya Nikolaevskiy8c4fe162018-02-27 15:49:47 +010047
philipel65e1f942017-07-24 08:26:53 -070048constexpr int64_t kLogNonDecodedIntervalMs = 5000;
philipelbe7a9e52016-05-19 12:19:35 +020049} // namespace
50
philipelbe7a9e52016-05-19 12:19:35 +020051FrameBuffer::FrameBuffer(Clock* clock,
philipela45102f2017-02-22 05:30:39 -080052 VCMTiming* timing,
53 VCMReceiveStatisticsCallback* stats_callback)
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +010054 : decoded_frames_history_(kMaxFramesHistory),
55 clock_(clock),
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +020056 callback_queue_(nullptr),
Niels Möllerd9c2d942019-04-30 09:16:36 +020057 jitter_estimator_(clock),
philipelbe7a9e52016-05-19 12:19:35 +020058 timing_(timing),
philipel4f6cd6a2016-08-03 10:59:32 +020059 inter_frame_delay_(clock_->TimeInMilliseconds()),
philipel29f730e2017-03-15 08:10:08 -070060 stopped_(false),
philipela45102f2017-02-22 05:30:39 -080061 protection_mode_(kProtectionNack),
philipel65e1f942017-07-24 08:26:53 -070062 stats_callback_(stats_callback),
Elad Alone4b50232019-01-14 18:56:14 +010063 last_log_non_decoded_ms_(-kLogNonDecodedIntervalMs),
64 add_rtt_to_playout_delay_(
“Michaeld3a4ebe2019-06-07 03:55:01 -050065 webrtc::field_trial::IsEnabled("WebRTC-AddRttToPlayoutDelay")),
Tommi430951a2020-05-19 23:27:29 +020066 rtt_mult_settings_(RttMultExperiment::GetRttMultValue()) {
67 callback_checker_.Detach();
68}
philipel266f0a42016-11-28 08:49:07 -080069
Tommi430951a2020-05-19 23:27:29 +020070FrameBuffer::~FrameBuffer() {
71 RTC_DCHECK_RUN_ON(&construction_checker_);
72}
philipelbe7a9e52016-05-19 12:19:35 +020073
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +020074void FrameBuffer::NextFrame(
75 int64_t max_wait_time_ms,
76 bool keyframe_required,
77 rtc::TaskQueue* callback_queue,
78 std::function<void(std::unique_ptr<EncodedFrame>, ReturnReason)> handler) {
Tommi430951a2020-05-19 23:27:29 +020079 RTC_DCHECK_RUN_ON(&callback_checker_);
80 RTC_DCHECK(callback_queue->IsCurrent());
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +020081 TRACE_EVENT0("webrtc", "FrameBuffer::NextFrame");
82 int64_t latest_return_time_ms =
83 clock_->TimeInMilliseconds() + max_wait_time_ms;
Tommi430951a2020-05-19 23:27:29 +020084
Markus Handell6deec382020-07-07 12:17:12 +020085 MutexLock lock(&mutex_);
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +020086 if (stopped_) {
87 return;
88 }
89 latest_return_time_ms_ = latest_return_time_ms;
90 keyframe_required_ = keyframe_required;
91 frame_handler_ = handler;
92 callback_queue_ = callback_queue;
93 StartWaitForNextFrameOnQueue();
94}
95
96void FrameBuffer::StartWaitForNextFrameOnQueue() {
97 RTC_DCHECK(callback_queue_);
98 RTC_DCHECK(!callback_task_.Running());
99 int64_t wait_ms = FindNextFrame(clock_->TimeInMilliseconds());
100 callback_task_ = RepeatingTaskHandle::DelayedStart(
Danil Chapovalov55284022020-02-07 14:53:52 +0100101 callback_queue_->Get(), TimeDelta::Millis(wait_ms), [this] {
Tommi430951a2020-05-19 23:27:29 +0200102 RTC_DCHECK_RUN_ON(&callback_checker_);
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200103 // If this task has not been cancelled, we did not get any new frames
104 // while waiting. Continue with frame delivery.
Markus Handell6deec382020-07-07 12:17:12 +0200105 MutexLock lock(&mutex_);
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200106 if (!frames_to_decode_.empty()) {
107 // We have frames, deliver!
108 frame_handler_(absl::WrapUnique(GetNextFrame()), kFrameFound);
109 CancelCallback();
110 return TimeDelta::Zero(); // Ignored.
111 } else if (clock_->TimeInMilliseconds() >= latest_return_time_ms_) {
112 // We have timed out, signal this and stop repeating.
113 frame_handler_(nullptr, kTimeout);
114 CancelCallback();
115 return TimeDelta::Zero(); // Ignored.
116 } else {
117 // If there's no frames to decode and there is still time left, it
118 // means that the frame buffer was cleared between creation and
119 // execution of this task. Continue waiting for the remaining time.
120 int64_t wait_ms = FindNextFrame(clock_->TimeInMilliseconds());
Danil Chapovalov55284022020-02-07 14:53:52 +0100121 return TimeDelta::Millis(wait_ms);
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200122 }
123 });
124}
125
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200126int64_t FrameBuffer::FindNextFrame(int64_t now_ms) {
127 int64_t wait_ms = latest_return_time_ms_ - now_ms;
128 frames_to_decode_.clear();
129
130 // |last_continuous_frame_| may be empty below, but nullopt is smaller
131 // than everything else and loop will immediately terminate as expected.
132 for (auto frame_it = frames_.begin();
133 frame_it != frames_.end() && frame_it->first <= last_continuous_frame_;
134 ++frame_it) {
135 if (!frame_it->second.continuous ||
136 frame_it->second.num_missing_decodable > 0) {
137 continue;
138 }
139
140 EncodedFrame* frame = frame_it->second.frame.get();
141
142 if (keyframe_required_ && !frame->is_keyframe())
143 continue;
144
145 auto last_decoded_frame_timestamp =
146 decoded_frames_history_.GetLastDecodedFrameTimestamp();
147
148 // TODO(https://bugs.webrtc.org/9974): consider removing this check
149 // as it may make a stream undecodable after a very long delay between
150 // frames.
151 if (last_decoded_frame_timestamp &&
152 AheadOf(*last_decoded_frame_timestamp, frame->Timestamp())) {
153 continue;
154 }
155
156 // Only ever return all parts of a superframe. Therefore skip this
157 // frame if it's not a beginning of a superframe.
158 if (frame->inter_layer_predicted) {
159 continue;
160 }
161
162 // Gather all remaining frames for the same superframe.
163 std::vector<FrameMap::iterator> current_superframe;
164 current_superframe.push_back(frame_it);
165 bool last_layer_completed = frame_it->second.frame->is_last_spatial_layer;
166 FrameMap::iterator next_frame_it = frame_it;
167 while (true) {
168 ++next_frame_it;
169 if (next_frame_it == frames_.end() ||
170 next_frame_it->first.picture_id != frame->id.picture_id ||
171 !next_frame_it->second.continuous) {
172 break;
173 }
174 // Check if the next frame has some undecoded references other than
175 // the previous frame in the same superframe.
176 size_t num_allowed_undecoded_refs =
177 (next_frame_it->second.frame->inter_layer_predicted) ? 1 : 0;
178 if (next_frame_it->second.num_missing_decodable >
179 num_allowed_undecoded_refs) {
180 break;
181 }
182 // All frames in the superframe should have the same timestamp.
183 if (frame->Timestamp() != next_frame_it->second.frame->Timestamp()) {
184 RTC_LOG(LS_WARNING) << "Frames in a single superframe have different"
185 " timestamps. Skipping undecodable superframe.";
186 break;
187 }
188 current_superframe.push_back(next_frame_it);
189 last_layer_completed = next_frame_it->second.frame->is_last_spatial_layer;
190 }
191 // Check if the current superframe is complete.
192 // TODO(bugs.webrtc.org/10064): consider returning all available to
193 // decode frames even if the superframe is not complete yet.
194 if (!last_layer_completed) {
195 continue;
196 }
197
198 frames_to_decode_ = std::move(current_superframe);
199
200 if (frame->RenderTime() == -1) {
201 frame->SetRenderTime(timing_->RenderTimeMs(frame->Timestamp(), now_ms));
202 }
203 wait_ms = timing_->MaxWaitingTime(frame->RenderTime(), now_ms);
204
205 // This will cause the frame buffer to prefer high framerate rather
206 // than high resolution in the case of the decoder not decoding fast
207 // enough and the stream has multiple spatial and temporal layers.
208 // For multiple temporal layers it may cause non-base layer frames to be
209 // skipped if they are late.
210 if (wait_ms < -kMaxAllowedFrameDelayMs)
211 continue;
212
213 break;
214 }
215 wait_ms = std::min<int64_t>(wait_ms, latest_return_time_ms_ - now_ms);
216 wait_ms = std::max<int64_t>(wait_ms, 0);
217 return wait_ms;
218}
219
220EncodedFrame* FrameBuffer::GetNextFrame() {
Tommi430951a2020-05-19 23:27:29 +0200221 RTC_DCHECK_RUN_ON(&callback_checker_);
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200222 int64_t now_ms = clock_->TimeInMilliseconds();
223 // TODO(ilnik): remove |frames_out| use frames_to_decode_ directly.
224 std::vector<EncodedFrame*> frames_out;
225
226 RTC_DCHECK(!frames_to_decode_.empty());
227 bool superframe_delayed_by_retransmission = false;
228 size_t superframe_size = 0;
229 EncodedFrame* first_frame = frames_to_decode_[0]->second.frame.get();
230 int64_t render_time_ms = first_frame->RenderTime();
231 int64_t receive_time_ms = first_frame->ReceivedTime();
232 // Gracefully handle bad RTP timestamps and render time issues.
233 if (HasBadRenderTiming(*first_frame, now_ms)) {
Niels Möllerd9c2d942019-04-30 09:16:36 +0200234 jitter_estimator_.Reset();
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200235 timing_->Reset();
236 render_time_ms = timing_->RenderTimeMs(first_frame->Timestamp(), now_ms);
237 }
238
239 for (FrameMap::iterator& frame_it : frames_to_decode_) {
240 RTC_DCHECK(frame_it != frames_.end());
241 EncodedFrame* frame = frame_it->second.frame.release();
242
243 frame->SetRenderTime(render_time_ms);
244
245 superframe_delayed_by_retransmission |= frame->delayed_by_retransmission();
246 receive_time_ms = std::max(receive_time_ms, frame->ReceivedTime());
247 superframe_size += frame->size();
248
249 PropagateDecodability(frame_it->second);
250 decoded_frames_history_.InsertDecoded(frame_it->first, frame->Timestamp());
251
252 // Remove decoded frame and all undecoded frames before it.
Johannes Kron0c141c52019-08-26 15:04:43 +0200253 if (stats_callback_) {
254 unsigned int dropped_frames = std::count_if(
255 frames_.begin(), frame_it,
256 [](const std::pair<const VideoLayerFrameId, FrameInfo>& frame) {
257 return frame.second.frame != nullptr;
258 });
259 if (dropped_frames > 0) {
260 stats_callback_->OnDroppedFrames(dropped_frames);
261 }
262 }
263
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200264 frames_.erase(frames_.begin(), ++frame_it);
265
266 frames_out.push_back(frame);
267 }
268
269 if (!superframe_delayed_by_retransmission) {
270 int64_t frame_delay;
271
272 if (inter_frame_delay_.CalculateDelay(first_frame->Timestamp(),
273 &frame_delay, receive_time_ms)) {
Niels Möllerd9c2d942019-04-30 09:16:36 +0200274 jitter_estimator_.UpdateEstimate(frame_delay, superframe_size);
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200275 }
276
277 float rtt_mult = protection_mode_ == kProtectionNackFEC ? 0.0 : 1.0;
“Michaeld3a4ebe2019-06-07 03:55:01 -0500278 absl::optional<float> rtt_mult_add_cap_ms = absl::nullopt;
279 if (rtt_mult_settings_.has_value()) {
280 rtt_mult = rtt_mult_settings_->rtt_mult_setting;
281 rtt_mult_add_cap_ms = rtt_mult_settings_->rtt_mult_add_cap_ms;
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200282 }
“Michaele0f37042019-06-04 10:04:12 -0500283 timing_->SetJitterDelay(
284 jitter_estimator_.GetJitterEstimate(rtt_mult, rtt_mult_add_cap_ms));
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200285 timing_->UpdateCurrentDelay(render_time_ms, now_ms);
286 } else {
287 if (RttMultExperiment::RttMultEnabled() || add_rtt_to_playout_delay_)
Niels Möllerd9c2d942019-04-30 09:16:36 +0200288 jitter_estimator_.FrameNacked();
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200289 }
290
291 UpdateJitterDelay();
292 UpdateTimingFrameInfo();
293
294 if (frames_out.size() == 1) {
295 return frames_out[0];
296 } else {
297 return CombineAndDeleteFrames(frames_out);
298 }
299}
300
philipele7c891f2018-02-22 14:35:06 +0100301bool FrameBuffer::HasBadRenderTiming(const EncodedFrame& frame,
302 int64_t now_ms) {
stefan95e97542017-05-23 09:52:18 -0700303 // Assume that render timing errors are due to changes in the video stream.
304 int64_t render_time_ms = frame.RenderTimeMs();
Stefan Holmer812ceaf2018-05-15 13:00:10 +0200305 // Zero render time means render immediately.
306 if (render_time_ms == 0) {
307 return false;
308 }
stefan95e97542017-05-23 09:52:18 -0700309 if (render_time_ms < 0) {
310 return true;
311 }
Stefan Holmer812ceaf2018-05-15 13:00:10 +0200312 const int64_t kMaxVideoDelayMs = 10000;
stefan95e97542017-05-23 09:52:18 -0700313 if (std::abs(render_time_ms - now_ms) > kMaxVideoDelayMs) {
314 int frame_delay = static_cast<int>(std::abs(render_time_ms - now_ms));
Mirko Bonadei675513b2017-11-09 11:09:25 +0100315 RTC_LOG(LS_WARNING)
316 << "A frame about to be decoded is out of the configured "
Jonas Olssonb2b20312020-01-14 12:11:31 +0100317 "delay bounds ("
318 << frame_delay << " > " << kMaxVideoDelayMs
Mirko Bonadei675513b2017-11-09 11:09:25 +0100319 << "). Resetting the video jitter buffer.";
stefan95e97542017-05-23 09:52:18 -0700320 return true;
321 }
322 if (static_cast<int>(timing_->TargetVideoDelay()) > kMaxVideoDelayMs) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100323 RTC_LOG(LS_WARNING) << "The video target delay has grown larger than "
324 << kMaxVideoDelayMs << " ms.";
stefan95e97542017-05-23 09:52:18 -0700325 return true;
326 }
327 return false;
328}
329
philipel4f6cd6a2016-08-03 10:59:32 +0200330void FrameBuffer::SetProtectionMode(VCMVideoProtection mode) {
tommidb23ea62017-03-03 07:21:18 -0800331 TRACE_EVENT0("webrtc", "FrameBuffer::SetProtectionMode");
Markus Handell6deec382020-07-07 12:17:12 +0200332 MutexLock lock(&mutex_);
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000333 protection_mode_ = mode;
philipel4f6cd6a2016-08-03 10:59:32 +0200334}
335
philipel504c47d2016-06-30 17:33:02 +0200336void FrameBuffer::Start() {
tommidb23ea62017-03-03 07:21:18 -0800337 TRACE_EVENT0("webrtc", "FrameBuffer::Start");
Markus Handell6deec382020-07-07 12:17:12 +0200338 MutexLock lock(&mutex_);
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000339 stopped_ = false;
philipel504c47d2016-06-30 17:33:02 +0200340}
341
342void FrameBuffer::Stop() {
tommidb23ea62017-03-03 07:21:18 -0800343 TRACE_EVENT0("webrtc", "FrameBuffer::Stop");
Markus Handell6deec382020-07-07 12:17:12 +0200344 MutexLock lock(&mutex_);
Tommi430951a2020-05-19 23:27:29 +0200345 if (stopped_)
346 return;
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000347 stopped_ = true;
Tommi430951a2020-05-19 23:27:29 +0200348
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200349 CancelCallback();
philipel504c47d2016-06-30 17:33:02 +0200350}
351
Ilya Nikolaevskiye6a2d942018-11-07 14:32:28 +0100352void FrameBuffer::Clear() {
Markus Handell6deec382020-07-07 12:17:12 +0200353 MutexLock lock(&mutex_);
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000354 ClearFramesAndHistory();
Ilya Nikolaevskiye6a2d942018-11-07 14:32:28 +0100355}
356
philipele21be1d2017-09-25 06:37:12 -0700357void FrameBuffer::UpdateRtt(int64_t rtt_ms) {
Markus Handell6deec382020-07-07 12:17:12 +0200358 MutexLock lock(&mutex_);
Niels Möllerd9c2d942019-04-30 09:16:36 +0200359 jitter_estimator_.UpdateRtt(rtt_ms);
philipele21be1d2017-09-25 06:37:12 -0700360}
361
philipele7c891f2018-02-22 14:35:06 +0100362bool FrameBuffer::ValidReferences(const EncodedFrame& frame) const {
philipel112adf92017-06-15 09:06:21 -0700363 for (size_t i = 0; i < frame.num_references; ++i) {
Philip Eliasson1f850a62019-03-19 12:15:00 +0000364 if (frame.references[i] >= frame.id.picture_id)
philipel112adf92017-06-15 09:06:21 -0700365 return false;
philipel3b3c9c42017-09-11 09:38:36 -0700366
philipel112adf92017-06-15 09:06:21 -0700367 for (size_t j = i + 1; j < frame.num_references; ++j) {
368 if (frame.references[i] == frame.references[j])
369 return false;
370 }
371 }
372
philipel0fa82a62018-03-19 15:34:53 +0100373 if (frame.inter_layer_predicted && frame.id.spatial_layer == 0)
philipel112adf92017-06-15 09:06:21 -0700374 return false;
375
376 return true;
377}
378
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200379void FrameBuffer::CancelCallback() {
Tommi430951a2020-05-19 23:27:29 +0200380 // Called from the callback queue or from within Stop().
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200381 frame_handler_ = {};
382 callback_task_.Stop();
383 callback_queue_ = nullptr;
Tommi430951a2020-05-19 23:27:29 +0200384 callback_checker_.Detach();
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200385}
386
Ilya Nikolaevskiy48193b02019-03-25 11:40:34 +0100387bool FrameBuffer::IsCompleteSuperFrame(const EncodedFrame& frame) {
388 if (frame.inter_layer_predicted) {
389 // Check that all previous spatial layers are already inserted.
390 VideoLayerFrameId id = frame.id;
391 RTC_DCHECK_GT(id.spatial_layer, 0);
392 --id.spatial_layer;
393 FrameMap::iterator prev_frame = frames_.find(id);
Ilya Nikolaevskiyb4a70ed2019-04-23 10:37:06 +0200394 if (prev_frame == frames_.end() || !prev_frame->second.frame)
Ilya Nikolaevskiy48193b02019-03-25 11:40:34 +0100395 return false;
396 while (prev_frame->second.frame->inter_layer_predicted) {
Ilya Nikolaevskiyf87a7df2019-04-09 19:23:36 +0200397 if (prev_frame == frames_.begin())
398 return false;
Ilya Nikolaevskiy48193b02019-03-25 11:40:34 +0100399 --prev_frame;
400 --id.spatial_layer;
Ilya Nikolaevskiyb4a70ed2019-04-23 10:37:06 +0200401 if (!prev_frame->second.frame ||
402 prev_frame->first.picture_id != id.picture_id ||
Ilya Nikolaevskiy48193b02019-03-25 11:40:34 +0100403 prev_frame->first.spatial_layer != id.spatial_layer) {
404 return false;
405 }
406 }
407 }
408
409 if (!frame.is_last_spatial_layer) {
410 // Check that all following spatial layers are already inserted.
411 VideoLayerFrameId id = frame.id;
412 ++id.spatial_layer;
413 FrameMap::iterator next_frame = frames_.find(id);
Ilya Nikolaevskiyb4a70ed2019-04-23 10:37:06 +0200414 if (next_frame == frames_.end() || !next_frame->second.frame)
Ilya Nikolaevskiy48193b02019-03-25 11:40:34 +0100415 return false;
416 while (!next_frame->second.frame->is_last_spatial_layer) {
417 ++next_frame;
418 ++id.spatial_layer;
Ilya Nikolaevskiyb4a70ed2019-04-23 10:37:06 +0200419 if (next_frame == frames_.end() || !next_frame->second.frame ||
Ilya Nikolaevskiy48193b02019-03-25 11:40:34 +0100420 next_frame->first.picture_id != id.picture_id ||
421 next_frame->first.spatial_layer != id.spatial_layer) {
422 return false;
423 }
424 }
425 }
426
427 return true;
428}
429
philipele7c891f2018-02-22 14:35:06 +0100430int64_t FrameBuffer::InsertFrame(std::unique_ptr<EncodedFrame> frame) {
tommidb23ea62017-03-03 07:21:18 -0800431 TRACE_EVENT0("webrtc", "FrameBuffer::InsertFrame");
philipel93e451b2016-10-06 12:25:13 +0200432 RTC_DCHECK(frame);
tommi0a735642017-03-14 06:23:57 -0700433
Markus Handell6deec382020-07-07 12:17:12 +0200434 MutexLock lock(&mutex_);
philipel29f730e2017-03-15 08:10:08 -0700435
Ilya Nikolaevskiy48193b02019-03-25 11:40:34 +0100436 const VideoLayerFrameId& id = frame->id;
philipel1610f942017-12-12 13:58:31 +0100437 int64_t last_continuous_picture_id =
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100438 !last_continuous_frame_ ? -1 : last_continuous_frame_->picture_id;
philipele0b2f152016-09-28 10:23:49 +0200439
philipel112adf92017-06-15 09:06:21 -0700440 if (!ValidReferences(*frame)) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100441 RTC_LOG(LS_WARNING) << "Frame with (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100442 << id.picture_id << ":"
443 << static_cast<int>(id.spatial_layer)
Mirko Bonadei675513b2017-11-09 11:09:25 +0100444 << ") has invalid frame references, dropping frame.";
philipel112adf92017-06-15 09:06:21 -0700445 return last_continuous_picture_id;
446 }
447
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100448 if (frames_.size() >= kMaxFramesBuffered) {
philipel9771c502018-03-02 11:06:27 +0100449 if (frame->is_keyframe()) {
450 RTC_LOG(LS_WARNING) << "Inserting keyframe (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100451 << id.picture_id << ":"
452 << static_cast<int>(id.spatial_layer)
philipel9771c502018-03-02 11:06:27 +0100453 << ") but buffer is full, clearing"
Jonas Olssonb2b20312020-01-14 12:11:31 +0100454 " buffer and inserting the frame.";
philipel9771c502018-03-02 11:06:27 +0100455 ClearFramesAndHistory();
456 } else {
457 RTC_LOG(LS_WARNING) << "Frame with (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100458 << id.picture_id << ":"
459 << static_cast<int>(id.spatial_layer)
philipel9771c502018-03-02 11:06:27 +0100460 << ") could not be inserted due to the frame "
Jonas Olssonb2b20312020-01-14 12:11:31 +0100461 "buffer being full, dropping frame.";
philipel9771c502018-03-02 11:06:27 +0100462 return last_continuous_picture_id;
463 }
philipele0b2f152016-09-28 10:23:49 +0200464 }
465
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100466 auto last_decoded_frame = decoded_frames_history_.GetLastDecodedFrameId();
467 auto last_decoded_frame_timestamp =
468 decoded_frames_history_.GetLastDecodedFrameTimestamp();
469 if (last_decoded_frame && id <= *last_decoded_frame) {
470 if (AheadOf(frame->Timestamp(), *last_decoded_frame_timestamp) &&
philipel3042c2d2017-08-18 04:55:02 -0700471 frame->is_keyframe()) {
philipelfcc60062017-01-18 05:35:20 -0800472 // If this frame has a newer timestamp but an earlier picture id then we
473 // assume there has been a jump in the picture id due to some encoder
474 // reconfiguration or some other reason. Even though this is not according
475 // to spec we can still continue to decode from this frame if it is a
476 // keyframe.
Mirko Bonadei675513b2017-11-09 11:09:25 +0100477 RTC_LOG(LS_WARNING)
478 << "A jump in picture id was detected, clearing buffer.";
philipelfcc60062017-01-18 05:35:20 -0800479 ClearFramesAndHistory();
480 last_continuous_picture_id = -1;
481 } else {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100482 RTC_LOG(LS_WARNING) << "Frame with (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100483 << id.picture_id << ":"
484 << static_cast<int>(id.spatial_layer)
Mirko Bonadei675513b2017-11-09 11:09:25 +0100485 << ") inserted after frame ("
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100486 << last_decoded_frame->picture_id << ":"
487 << static_cast<int>(last_decoded_frame->spatial_layer)
Mirko Bonadei675513b2017-11-09 11:09:25 +0100488 << ") was handed off for decoding, dropping frame.";
philipelfcc60062017-01-18 05:35:20 -0800489 return last_continuous_picture_id;
490 }
philipele0b2f152016-09-28 10:23:49 +0200491 }
492
philipel146a48b2017-04-20 04:04:38 -0700493 // Test if inserting this frame would cause the order of the frames to become
494 // ambiguous (covering more than half the interval of 2^16). This can happen
495 // when the picture id make large jumps mid stream.
philipel0fa82a62018-03-19 15:34:53 +0100496 if (!frames_.empty() && id < frames_.begin()->first &&
497 frames_.rbegin()->first < id) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100498 RTC_LOG(LS_WARNING)
499 << "A jump in picture id was detected, clearing buffer.";
philipel146a48b2017-04-20 04:04:38 -0700500 ClearFramesAndHistory();
501 last_continuous_picture_id = -1;
502 }
503
philipel0fa82a62018-03-19 15:34:53 +0100504 auto info = frames_.emplace(id, FrameInfo()).first;
philipele0b2f152016-09-28 10:23:49 +0200505
philipel93e451b2016-10-06 12:25:13 +0200506 if (info->second.frame) {
philipele0b2f152016-09-28 10:23:49 +0200507 return last_continuous_picture_id;
508 }
509
philipel93e451b2016-10-06 12:25:13 +0200510 if (!UpdateFrameInfoWithIncomingFrame(*frame, info))
511 return last_continuous_picture_id;
Ruslan Burakov493a6502019-02-27 15:32:48 +0100512
513 if (!frame->delayed_by_retransmission())
514 timing_->IncomingTimestamp(frame->Timestamp(), frame->ReceivedTime());
philipel0a9f6de2018-02-28 11:29:47 +0100515
Johannes Kronb88b44e2019-08-22 13:16:44 +0200516 if (stats_callback_ && IsCompleteSuperFrame(*frame)) {
517 stats_callback_->OnCompleteFrame(frame->is_keyframe(), frame->size(),
518 frame->contentType());
519 }
520
philipele0b2f152016-09-28 10:23:49 +0200521 info->second.frame = std::move(frame);
philipele0b2f152016-09-28 10:23:49 +0200522
523 if (info->second.num_missing_continuous == 0) {
524 info->second.continuous = true;
525 PropagateContinuity(info);
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100526 last_continuous_picture_id = last_continuous_frame_->picture_id;
philipele0b2f152016-09-28 10:23:49 +0200527
528 // Since we now have new continuous frames there might be a better frame
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200529 // to return from NextFrame.
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200530 if (callback_queue_) {
531 callback_queue_->PostTask([this] {
Markus Handell6deec382020-07-07 12:17:12 +0200532 MutexLock lock(&mutex_);
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200533 if (!callback_task_.Running())
534 return;
535 RTC_CHECK(frame_handler_);
536 callback_task_.Stop();
537 StartWaitForNextFrameOnQueue();
538 });
539 }
philipele0b2f152016-09-28 10:23:49 +0200540 }
541
542 return last_continuous_picture_id;
philipelbe7a9e52016-05-19 12:19:35 +0200543}
544
philipele0b2f152016-09-28 10:23:49 +0200545void FrameBuffer::PropagateContinuity(FrameMap::iterator start) {
tommidb23ea62017-03-03 07:21:18 -0800546 TRACE_EVENT0("webrtc", "FrameBuffer::PropagateContinuity");
philipele0b2f152016-09-28 10:23:49 +0200547 RTC_DCHECK(start->second.continuous);
philipele0b2f152016-09-28 10:23:49 +0200548
549 std::queue<FrameMap::iterator> continuous_frames;
550 continuous_frames.push(start);
551
552 // A simple BFS to traverse continuous frames.
553 while (!continuous_frames.empty()) {
554 auto frame = continuous_frames.front();
555 continuous_frames.pop();
556
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100557 if (!last_continuous_frame_ || *last_continuous_frame_ < frame->first) {
558 last_continuous_frame_ = frame->first;
559 }
philipele0b2f152016-09-28 10:23:49 +0200560
561 // Loop through all dependent frames, and if that frame no longer has
562 // any unfulfilled dependencies then that frame is continuous as well.
Elad Alon69321dd2019-01-10 15:02:54 +0100563 for (size_t d = 0; d < frame->second.dependent_frames.size(); ++d) {
philipele0b2f152016-09-28 10:23:49 +0200564 auto frame_ref = frames_.find(frame->second.dependent_frames[d]);
philipel112adf92017-06-15 09:06:21 -0700565 RTC_DCHECK(frame_ref != frames_.end());
philipele0b2f152016-09-28 10:23:49 +0200566
philipel112adf92017-06-15 09:06:21 -0700567 // TODO(philipel): Look into why we've seen this happen.
568 if (frame_ref != frames_.end()) {
569 --frame_ref->second.num_missing_continuous;
570 if (frame_ref->second.num_missing_continuous == 0) {
571 frame_ref->second.continuous = true;
572 continuous_frames.push(frame_ref);
573 }
philipele0b2f152016-09-28 10:23:49 +0200574 }
575 }
576 }
577}
578
579void FrameBuffer::PropagateDecodability(const FrameInfo& info) {
tommidb23ea62017-03-03 07:21:18 -0800580 TRACE_EVENT0("webrtc", "FrameBuffer::PropagateDecodability");
Elad Alon69321dd2019-01-10 15:02:54 +0100581 for (size_t d = 0; d < info.dependent_frames.size(); ++d) {
philipele0b2f152016-09-28 10:23:49 +0200582 auto ref_info = frames_.find(info.dependent_frames[d]);
philipel93e451b2016-10-06 12:25:13 +0200583 RTC_DCHECK(ref_info != frames_.end());
tommie95b78b2017-05-14 07:23:11 -0700584 // TODO(philipel): Look into why we've seen this happen.
585 if (ref_info != frames_.end()) {
586 RTC_DCHECK_GT(ref_info->second.num_missing_decodable, 0U);
587 --ref_info->second.num_missing_decodable;
588 }
philipele0b2f152016-09-28 10:23:49 +0200589 }
590}
591
philipele7c891f2018-02-22 14:35:06 +0100592bool FrameBuffer::UpdateFrameInfoWithIncomingFrame(const EncodedFrame& frame,
philipele0b2f152016-09-28 10:23:49 +0200593 FrameMap::iterator info) {
tommidb23ea62017-03-03 07:21:18 -0800594 TRACE_EVENT0("webrtc", "FrameBuffer::UpdateFrameInfoWithIncomingFrame");
philipel0fa82a62018-03-19 15:34:53 +0100595 const VideoLayerFrameId& id = frame.id;
philipele0b2f152016-09-28 10:23:49 +0200596
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100597 auto last_decoded_frame = decoded_frames_history_.GetLastDecodedFrameId();
598 RTC_DCHECK(!last_decoded_frame || *last_decoded_frame < info->first);
philipele0b2f152016-09-28 10:23:49 +0200599
philipel798b2822018-06-11 13:10:14 +0200600 // In this function we determine how many missing dependencies this |frame|
601 // has to become continuous/decodable. If a frame that this |frame| depend
602 // on has already been decoded then we can ignore that dependency since it has
603 // already been fulfilled.
604 //
605 // For all other frames we will register a backwards reference to this |frame|
606 // so that |num_missing_continuous| and |num_missing_decodable| can be
607 // decremented as frames become continuous/are decoded.
608 struct Dependency {
609 VideoLayerFrameId id;
610 bool continuous;
611 };
612 std::vector<Dependency> not_yet_fulfilled_dependencies;
613
614 // Find all dependencies that have not yet been fulfilled.
philipele0b2f152016-09-28 10:23:49 +0200615 for (size_t i = 0; i < frame.num_references; ++i) {
philipel0fa82a62018-03-19 15:34:53 +0100616 VideoLayerFrameId ref_key(frame.references[i], frame.id.spatial_layer);
philipel798b2822018-06-11 13:10:14 +0200617 // Does |frame| depend on a frame earlier than the last decoded one?
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100618 if (last_decoded_frame && ref_key <= *last_decoded_frame) {
philipel798b2822018-06-11 13:10:14 +0200619 // Was that frame decoded? If not, this |frame| will never become
620 // decodable.
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100621 if (!decoded_frames_history_.WasDecoded(ref_key)) {
philipel65e1f942017-07-24 08:26:53 -0700622 int64_t now_ms = clock_->TimeInMilliseconds();
623 if (last_log_non_decoded_ms_ + kLogNonDecodedIntervalMs < now_ms) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100624 RTC_LOG(LS_WARNING)
philipel0fa82a62018-03-19 15:34:53 +0100625 << "Frame with (picture_id:spatial_id) (" << id.picture_id << ":"
626 << static_cast<int>(id.spatial_layer)
philipel65e1f942017-07-24 08:26:53 -0700627 << ") depends on a non-decoded frame more previous than"
Jonas Olssonb2b20312020-01-14 12:11:31 +0100628 " the last decoded frame, dropping frame.";
philipel65e1f942017-07-24 08:26:53 -0700629 last_log_non_decoded_ms_ = now_ms;
630 }
philipele0b2f152016-09-28 10:23:49 +0200631 return false;
632 }
philipele0b2f152016-09-28 10:23:49 +0200633 } else {
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100634 auto ref_info = frames_.find(ref_key);
philipel798b2822018-06-11 13:10:14 +0200635 bool ref_continuous =
636 ref_info != frames_.end() && ref_info->second.continuous;
637 not_yet_fulfilled_dependencies.push_back({ref_key, ref_continuous});
philipele0b2f152016-09-28 10:23:49 +0200638 }
philipelbe7a9e52016-05-19 12:19:35 +0200639 }
640
philipel798b2822018-06-11 13:10:14 +0200641 // Does |frame| depend on the lower spatial layer?
philipelbe7a9e52016-05-19 12:19:35 +0200642 if (frame.inter_layer_predicted) {
philipel0fa82a62018-03-19 15:34:53 +0100643 VideoLayerFrameId ref_key(frame.id.picture_id, frame.id.spatial_layer - 1);
philipel798b2822018-06-11 13:10:14 +0200644 auto ref_info = frames_.find(ref_key);
philipele0b2f152016-09-28 10:23:49 +0200645
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100646 bool lower_layer_decoded =
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100647 last_decoded_frame && *last_decoded_frame == ref_key;
philipel798b2822018-06-11 13:10:14 +0200648 bool lower_layer_continuous =
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100649 lower_layer_decoded ||
650 (ref_info != frames_.end() && ref_info->second.continuous);
philipel798b2822018-06-11 13:10:14 +0200651
652 if (!lower_layer_continuous || !lower_layer_decoded) {
653 not_yet_fulfilled_dependencies.push_back(
654 {ref_key, lower_layer_continuous});
philipele0b2f152016-09-28 10:23:49 +0200655 }
philipelbe7a9e52016-05-19 12:19:35 +0200656 }
657
philipel798b2822018-06-11 13:10:14 +0200658 info->second.num_missing_continuous = not_yet_fulfilled_dependencies.size();
659 info->second.num_missing_decodable = not_yet_fulfilled_dependencies.size();
660
661 for (const Dependency& dep : not_yet_fulfilled_dependencies) {
662 if (dep.continuous)
663 --info->second.num_missing_continuous;
664
Elad Alon69321dd2019-01-10 15:02:54 +0100665 frames_[dep.id].dependent_frames.push_back(id);
philipel798b2822018-06-11 13:10:14 +0200666 }
philipel93e451b2016-10-06 12:25:13 +0200667
philipelbe7a9e52016-05-19 12:19:35 +0200668 return true;
669}
670
philipelbe742702016-11-30 01:31:40 -0800671void FrameBuffer::UpdateJitterDelay() {
tommidb23ea62017-03-03 07:21:18 -0800672 TRACE_EVENT0("webrtc", "FrameBuffer::UpdateJitterDelay");
philipela45102f2017-02-22 05:30:39 -0800673 if (!stats_callback_)
674 return;
philipelbe742702016-11-30 01:31:40 -0800675
philipela45102f2017-02-22 05:30:39 -0800676 int max_decode_ms;
677 int current_delay_ms;
678 int target_delay_ms;
679 int jitter_buffer_ms;
680 int min_playout_delay_ms;
681 int render_delay_ms;
Johannes Kronbfd343b2019-07-01 10:07:50 +0200682 if (timing_->GetTimings(&max_decode_ms, &current_delay_ms, &target_delay_ms,
683 &jitter_buffer_ms, &min_playout_delay_ms,
684 &render_delay_ms)) {
philipela45102f2017-02-22 05:30:39 -0800685 stats_callback_->OnFrameBufferTimingsUpdated(
Johannes Kronbfd343b2019-07-01 10:07:50 +0200686 max_decode_ms, current_delay_ms, target_delay_ms, jitter_buffer_ms,
687 min_playout_delay_ms, render_delay_ms);
philipelbe742702016-11-30 01:31:40 -0800688 }
philipel266f0a42016-11-28 08:49:07 -0800689}
690
ilnik2edc6842017-07-06 03:06:50 -0700691void FrameBuffer::UpdateTimingFrameInfo() {
692 TRACE_EVENT0("webrtc", "FrameBuffer::UpdateTimingFrameInfo");
Danil Chapovalov0040b662018-06-18 10:48:16 +0200693 absl::optional<TimingFrameInfo> info = timing_->GetTimingFrameInfo();
philipel97187112018-03-23 10:43:21 +0100694 if (info && stats_callback_)
ilnik2edc6842017-07-06 03:06:50 -0700695 stats_callback_->OnTimingFrameInfoUpdated(*info);
696}
697
philipelfcc60062017-01-18 05:35:20 -0800698void FrameBuffer::ClearFramesAndHistory() {
ilnik2edc6842017-07-06 03:06:50 -0700699 TRACE_EVENT0("webrtc", "FrameBuffer::ClearFramesAndHistory");
Johannes Kron0c141c52019-08-26 15:04:43 +0200700 if (stats_callback_) {
701 unsigned int dropped_frames = std::count_if(
702 frames_.begin(), frames_.end(),
703 [](const std::pair<const VideoLayerFrameId, FrameInfo>& frame) {
704 return frame.second.frame != nullptr;
705 });
706 if (dropped_frames > 0) {
707 stats_callback_->OnDroppedFrames(dropped_frames);
708 }
709 }
philipelfcc60062017-01-18 05:35:20 -0800710 frames_.clear();
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100711 last_continuous_frame_.reset();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100712 frames_to_decode_.clear();
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100713 decoded_frames_history_.Clear();
philipelfcc60062017-01-18 05:35:20 -0800714}
715
Niels Möllerff2e2152019-09-27 10:29:30 +0200716// TODO(philipel): Avoid the concatenation of frames here, by replacing
717// NextFrame and GetNextFrame with methods returning multiple frames.
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100718EncodedFrame* FrameBuffer::CombineAndDeleteFrames(
719 const std::vector<EncodedFrame*>& frames) const {
720 RTC_DCHECK(!frames.empty());
Sergey Silkin61832dd2018-12-20 14:32:14 +0100721 EncodedFrame* first_frame = frames[0];
722 EncodedFrame* last_frame = frames.back();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100723 size_t total_length = 0;
724 for (size_t i = 0; i < frames.size(); ++i) {
725 total_length += frames[i]->size();
726 }
Niels Möllerff2e2152019-09-27 10:29:30 +0200727 auto encoded_image_buffer = EncodedImageBuffer::Create(total_length);
728 uint8_t* buffer = encoded_image_buffer->data();
Sergey Silkin2799e632019-05-17 09:51:39 +0200729 first_frame->SetSpatialLayerFrameSize(first_frame->id.spatial_layer,
730 first_frame->size());
Niels Möllerff2e2152019-09-27 10:29:30 +0200731 memcpy(buffer, first_frame->data(), first_frame->size());
732 buffer += first_frame->size();
Sergey Silkin2799e632019-05-17 09:51:39 +0200733
Sergey Silkin61832dd2018-12-20 14:32:14 +0100734 // Spatial index of combined frame is set equal to spatial index of its top
735 // spatial layer.
736 first_frame->SetSpatialIndex(last_frame->id.spatial_layer);
737 first_frame->id.spatial_layer = last_frame->id.spatial_layer;
738
739 first_frame->video_timing_mutable()->network2_timestamp_ms =
740 last_frame->video_timing().network2_timestamp_ms;
741 first_frame->video_timing_mutable()->receive_finish_ms =
742 last_frame->video_timing().receive_finish_ms;
743
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100744 // Append all remaining frames to the first one.
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100745 for (size_t i = 1; i < frames.size(); ++i) {
Sergey Silkin61832dd2018-12-20 14:32:14 +0100746 EncodedFrame* next_frame = frames[i];
Sergey Silkin2799e632019-05-17 09:51:39 +0200747 first_frame->SetSpatialLayerFrameSize(next_frame->id.spatial_layer,
748 next_frame->size());
Niels Möller9c843902019-01-11 10:21:35 +0100749 memcpy(buffer, next_frame->data(), next_frame->size());
Sergey Silkin61832dd2018-12-20 14:32:14 +0100750 buffer += next_frame->size();
751 delete next_frame;
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100752 }
Niels Möllerff2e2152019-09-27 10:29:30 +0200753 first_frame->SetEncodedData(encoded_image_buffer);
Sergey Silkin61832dd2018-12-20 14:32:14 +0100754 return first_frame;
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100755}
756
Niels Möllerbe682d42018-03-27 08:31:45 +0200757FrameBuffer::FrameInfo::FrameInfo() = default;
758FrameBuffer::FrameInfo::FrameInfo(FrameInfo&&) = default;
759FrameBuffer::FrameInfo::~FrameInfo() = default;
760
philipelbe7a9e52016-05-19 12:19:35 +0200761} // namespace video_coding
762} // namespace webrtc