blob: 10bc711332e8618654421fb1dd5d630882406c11 [file] [log] [blame]
philipelbe7a9e52016-05-19 12:19:35 +02001/*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020011#include "modules/video_coding/frame_buffer2.h"
philipelbe7a9e52016-05-19 12:19:35 +020012
13#include <algorithm>
Yves Gerey3e707812018-11-28 16:47:49 +010014#include <cstdlib>
15#include <iterator>
philipele0b2f152016-09-28 10:23:49 +020016#include <queue>
Yves Gerey3e707812018-11-28 16:47:49 +010017#include <utility>
philipel798b2822018-06-11 13:10:14 +020018#include <vector>
philipelbe7a9e52016-05-19 12:19:35 +020019
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +020020#include "absl/memory/memory.h"
Yves Gerey3e707812018-11-28 16:47:49 +010021#include "api/video/encoded_image.h"
22#include "api/video/video_timing.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020023#include "modules/video_coding/include/video_coding_defines.h"
24#include "modules/video_coding/jitter_estimator.h"
25#include "modules/video_coding/timing.h"
26#include "rtc_base/checks.h"
Yves Gerey3e707812018-11-28 16:47:49 +010027#include "rtc_base/experiments/rtt_mult_experiment.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020028#include "rtc_base/logging.h"
Yves Gerey3e707812018-11-28 16:47:49 +010029#include "rtc_base/numerics/sequence_number_util.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020030#include "rtc_base/trace_event.h"
31#include "system_wrappers/include/clock.h"
philipel707f2782017-10-02 14:10:28 +020032#include "system_wrappers/include/field_trial.h"
philipelbe7a9e52016-05-19 12:19:35 +020033
34namespace webrtc {
35namespace video_coding {
36
37namespace {
philipele0b2f152016-09-28 10:23:49 +020038// Max number of frames the buffer will hold.
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +010039constexpr size_t kMaxFramesBuffered = 800;
philipelbe7a9e52016-05-19 12:19:35 +020040
philipele0b2f152016-09-28 10:23:49 +020041// Max number of decoded frame info that will be saved.
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +010042constexpr int kMaxFramesHistory = 1 << 13;
philipel65e1f942017-07-24 08:26:53 -070043
Ilya Nikolaevskiy8c4fe162018-02-27 15:49:47 +010044// The time it's allowed for a frame to be late to its rendering prediction and
45// still be rendered.
Ilya Nikolaevskiy7eef0072018-02-28 09:59:26 +010046constexpr int kMaxAllowedFrameDelayMs = 5;
Ilya Nikolaevskiy8c4fe162018-02-27 15:49:47 +010047
philipel65e1f942017-07-24 08:26:53 -070048constexpr int64_t kLogNonDecodedIntervalMs = 5000;
philipelbe7a9e52016-05-19 12:19:35 +020049} // namespace
50
philipelbe7a9e52016-05-19 12:19:35 +020051FrameBuffer::FrameBuffer(Clock* clock,
philipela45102f2017-02-22 05:30:39 -080052 VCMTiming* timing,
53 VCMReceiveStatisticsCallback* stats_callback)
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +010054 : decoded_frames_history_(kMaxFramesHistory),
55 clock_(clock),
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +020056 callback_queue_(nullptr),
Niels Möllerd9c2d942019-04-30 09:16:36 +020057 jitter_estimator_(clock),
philipelbe7a9e52016-05-19 12:19:35 +020058 timing_(timing),
philipel4f6cd6a2016-08-03 10:59:32 +020059 inter_frame_delay_(clock_->TimeInMilliseconds()),
philipel29f730e2017-03-15 08:10:08 -070060 stopped_(false),
philipela45102f2017-02-22 05:30:39 -080061 protection_mode_(kProtectionNack),
philipel65e1f942017-07-24 08:26:53 -070062 stats_callback_(stats_callback),
Elad Alone4b50232019-01-14 18:56:14 +010063 last_log_non_decoded_ms_(-kLogNonDecodedIntervalMs),
64 add_rtt_to_playout_delay_(
Henrik Boströmc680c4a2019-04-03 10:27:36 +000065 webrtc::field_trial::IsEnabled("WebRTC-AddRttToPlayoutDelay")) {}
philipel266f0a42016-11-28 08:49:07 -080066
philipela45102f2017-02-22 05:30:39 -080067FrameBuffer::~FrameBuffer() {}
philipelbe7a9e52016-05-19 12:19:35 +020068
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +020069void FrameBuffer::NextFrame(
70 int64_t max_wait_time_ms,
71 bool keyframe_required,
72 rtc::TaskQueue* callback_queue,
73 std::function<void(std::unique_ptr<EncodedFrame>, ReturnReason)> handler) {
74 RTC_DCHECK_RUN_ON(callback_queue);
75 TRACE_EVENT0("webrtc", "FrameBuffer::NextFrame");
76 int64_t latest_return_time_ms =
77 clock_->TimeInMilliseconds() + max_wait_time_ms;
78 rtc::CritScope lock(&crit_);
79 if (stopped_) {
80 return;
81 }
82 latest_return_time_ms_ = latest_return_time_ms;
83 keyframe_required_ = keyframe_required;
84 frame_handler_ = handler;
85 callback_queue_ = callback_queue;
86 StartWaitForNextFrameOnQueue();
87}
88
89void FrameBuffer::StartWaitForNextFrameOnQueue() {
90 RTC_DCHECK(callback_queue_);
91 RTC_DCHECK(!callback_task_.Running());
92 int64_t wait_ms = FindNextFrame(clock_->TimeInMilliseconds());
93 callback_task_ = RepeatingTaskHandle::DelayedStart(
94 callback_queue_->Get(), TimeDelta::ms(wait_ms), [this] {
95 // If this task has not been cancelled, we did not get any new frames
96 // while waiting. Continue with frame delivery.
97 rtc::CritScope lock(&crit_);
98 if (!frames_to_decode_.empty()) {
99 // We have frames, deliver!
100 frame_handler_(absl::WrapUnique(GetNextFrame()), kFrameFound);
101 CancelCallback();
102 return TimeDelta::Zero(); // Ignored.
103 } else if (clock_->TimeInMilliseconds() >= latest_return_time_ms_) {
104 // We have timed out, signal this and stop repeating.
105 frame_handler_(nullptr, kTimeout);
106 CancelCallback();
107 return TimeDelta::Zero(); // Ignored.
108 } else {
109 // If there's no frames to decode and there is still time left, it
110 // means that the frame buffer was cleared between creation and
111 // execution of this task. Continue waiting for the remaining time.
112 int64_t wait_ms = FindNextFrame(clock_->TimeInMilliseconds());
113 return TimeDelta::ms(wait_ms);
114 }
115 });
116}
117
philipel75562822016-09-05 10:57:41 +0200118FrameBuffer::ReturnReason FrameBuffer::NextFrame(
119 int64_t max_wait_time_ms,
philipele7c891f2018-02-22 14:35:06 +0100120 std::unique_ptr<EncodedFrame>* frame_out,
philipel3042c2d2017-08-18 04:55:02 -0700121 bool keyframe_required) {
tommidb23ea62017-03-03 07:21:18 -0800122 TRACE_EVENT0("webrtc", "FrameBuffer::NextFrame");
philipel1c056252017-01-31 09:53:12 -0800123 int64_t latest_return_time_ms =
124 clock_->TimeInMilliseconds() + max_wait_time_ms;
philipel504c47d2016-06-30 17:33:02 +0200125 int64_t wait_ms = max_wait_time_ms;
philipel29f730e2017-03-15 08:10:08 -0700126 int64_t now_ms = 0;
philipele0b2f152016-09-28 10:23:49 +0200127
128 do {
philipel29f730e2017-03-15 08:10:08 -0700129 now_ms = clock_->TimeInMilliseconds();
philipel504c47d2016-06-30 17:33:02 +0200130 {
131 rtc::CritScope lock(&crit_);
tommi0a735642017-03-14 06:23:57 -0700132 new_continuous_frame_event_.Reset();
philipel29f730e2017-03-15 08:10:08 -0700133 if (stopped_)
134 return kStopped;
135
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200136 keyframe_required_ = keyframe_required;
137 latest_return_time_ms_ = latest_return_time_ms;
138 wait_ms = FindNextFrame(now_ms);
139 }
tommi0a735642017-03-14 06:23:57 -0700140 } while (new_continuous_frame_event_.Wait(wait_ms));
philipele0b2f152016-09-28 10:23:49 +0200141
philipel29f730e2017-03-15 08:10:08 -0700142 {
143 rtc::CritScope lock(&crit_);
philipele0b2f152016-09-28 10:23:49 +0200144
Ilya Nikolaevskiyfdfe1c92019-01-18 13:33:38 +0100145 if (!frames_to_decode_.empty()) {
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200146 frame_out->reset(GetNextFrame());
philipel29f730e2017-03-15 08:10:08 -0700147 return kFrameFound;
philipelbe7a9e52016-05-19 12:19:35 +0200148 }
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200149 }
tommi0a735642017-03-14 06:23:57 -0700150
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200151 if (latest_return_time_ms - clock_->TimeInMilliseconds() > 0) {
philipel1c056252017-01-31 09:53:12 -0800152 // If |next_frame_it_ == frames_.end()| and there is still time left, it
153 // means that the frame buffer was cleared as the thread in this function
154 // was waiting to acquire |crit_| in order to return. Wait for the
155 // remaining time and then return.
philipelcd936fd2019-05-02 13:53:10 +0200156 return NextFrame(latest_return_time_ms - now_ms, frame_out,
157 keyframe_required);
philipelbe7a9e52016-05-19 12:19:35 +0200158 }
tommi0a735642017-03-14 06:23:57 -0700159 return kTimeout;
philipelbe7a9e52016-05-19 12:19:35 +0200160}
161
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200162int64_t FrameBuffer::FindNextFrame(int64_t now_ms) {
163 int64_t wait_ms = latest_return_time_ms_ - now_ms;
164 frames_to_decode_.clear();
165
166 // |last_continuous_frame_| may be empty below, but nullopt is smaller
167 // than everything else and loop will immediately terminate as expected.
168 for (auto frame_it = frames_.begin();
169 frame_it != frames_.end() && frame_it->first <= last_continuous_frame_;
170 ++frame_it) {
171 if (!frame_it->second.continuous ||
172 frame_it->second.num_missing_decodable > 0) {
173 continue;
174 }
175
176 EncodedFrame* frame = frame_it->second.frame.get();
177
178 if (keyframe_required_ && !frame->is_keyframe())
179 continue;
180
181 auto last_decoded_frame_timestamp =
182 decoded_frames_history_.GetLastDecodedFrameTimestamp();
183
184 // TODO(https://bugs.webrtc.org/9974): consider removing this check
185 // as it may make a stream undecodable after a very long delay between
186 // frames.
187 if (last_decoded_frame_timestamp &&
188 AheadOf(*last_decoded_frame_timestamp, frame->Timestamp())) {
189 continue;
190 }
191
192 // Only ever return all parts of a superframe. Therefore skip this
193 // frame if it's not a beginning of a superframe.
194 if (frame->inter_layer_predicted) {
195 continue;
196 }
197
198 // Gather all remaining frames for the same superframe.
199 std::vector<FrameMap::iterator> current_superframe;
200 current_superframe.push_back(frame_it);
201 bool last_layer_completed = frame_it->second.frame->is_last_spatial_layer;
202 FrameMap::iterator next_frame_it = frame_it;
203 while (true) {
204 ++next_frame_it;
205 if (next_frame_it == frames_.end() ||
206 next_frame_it->first.picture_id != frame->id.picture_id ||
207 !next_frame_it->second.continuous) {
208 break;
209 }
210 // Check if the next frame has some undecoded references other than
211 // the previous frame in the same superframe.
212 size_t num_allowed_undecoded_refs =
213 (next_frame_it->second.frame->inter_layer_predicted) ? 1 : 0;
214 if (next_frame_it->second.num_missing_decodable >
215 num_allowed_undecoded_refs) {
216 break;
217 }
218 // All frames in the superframe should have the same timestamp.
219 if (frame->Timestamp() != next_frame_it->second.frame->Timestamp()) {
220 RTC_LOG(LS_WARNING) << "Frames in a single superframe have different"
221 " timestamps. Skipping undecodable superframe.";
222 break;
223 }
224 current_superframe.push_back(next_frame_it);
225 last_layer_completed = next_frame_it->second.frame->is_last_spatial_layer;
226 }
227 // Check if the current superframe is complete.
228 // TODO(bugs.webrtc.org/10064): consider returning all available to
229 // decode frames even if the superframe is not complete yet.
230 if (!last_layer_completed) {
231 continue;
232 }
233
234 frames_to_decode_ = std::move(current_superframe);
235
236 if (frame->RenderTime() == -1) {
237 frame->SetRenderTime(timing_->RenderTimeMs(frame->Timestamp(), now_ms));
238 }
239 wait_ms = timing_->MaxWaitingTime(frame->RenderTime(), now_ms);
240
241 // This will cause the frame buffer to prefer high framerate rather
242 // than high resolution in the case of the decoder not decoding fast
243 // enough and the stream has multiple spatial and temporal layers.
244 // For multiple temporal layers it may cause non-base layer frames to be
245 // skipped if they are late.
246 if (wait_ms < -kMaxAllowedFrameDelayMs)
247 continue;
248
249 break;
250 }
251 wait_ms = std::min<int64_t>(wait_ms, latest_return_time_ms_ - now_ms);
252 wait_ms = std::max<int64_t>(wait_ms, 0);
253 return wait_ms;
254}
255
256EncodedFrame* FrameBuffer::GetNextFrame() {
257 int64_t now_ms = clock_->TimeInMilliseconds();
258 // TODO(ilnik): remove |frames_out| use frames_to_decode_ directly.
259 std::vector<EncodedFrame*> frames_out;
260
261 RTC_DCHECK(!frames_to_decode_.empty());
262 bool superframe_delayed_by_retransmission = false;
263 size_t superframe_size = 0;
264 EncodedFrame* first_frame = frames_to_decode_[0]->second.frame.get();
265 int64_t render_time_ms = first_frame->RenderTime();
266 int64_t receive_time_ms = first_frame->ReceivedTime();
267 // Gracefully handle bad RTP timestamps and render time issues.
268 if (HasBadRenderTiming(*first_frame, now_ms)) {
Niels Möllerd9c2d942019-04-30 09:16:36 +0200269 jitter_estimator_.Reset();
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200270 timing_->Reset();
271 render_time_ms = timing_->RenderTimeMs(first_frame->Timestamp(), now_ms);
272 }
273
274 for (FrameMap::iterator& frame_it : frames_to_decode_) {
275 RTC_DCHECK(frame_it != frames_.end());
276 EncodedFrame* frame = frame_it->second.frame.release();
277
278 frame->SetRenderTime(render_time_ms);
279
280 superframe_delayed_by_retransmission |= frame->delayed_by_retransmission();
281 receive_time_ms = std::max(receive_time_ms, frame->ReceivedTime());
282 superframe_size += frame->size();
283
284 PropagateDecodability(frame_it->second);
285 decoded_frames_history_.InsertDecoded(frame_it->first, frame->Timestamp());
286
287 // Remove decoded frame and all undecoded frames before it.
288 frames_.erase(frames_.begin(), ++frame_it);
289
290 frames_out.push_back(frame);
291 }
292
293 if (!superframe_delayed_by_retransmission) {
294 int64_t frame_delay;
295
296 if (inter_frame_delay_.CalculateDelay(first_frame->Timestamp(),
297 &frame_delay, receive_time_ms)) {
Niels Möllerd9c2d942019-04-30 09:16:36 +0200298 jitter_estimator_.UpdateEstimate(frame_delay, superframe_size);
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200299 }
300
301 float rtt_mult = protection_mode_ == kProtectionNackFEC ? 0.0 : 1.0;
“Michaele0f37042019-06-04 10:04:12 -0500302 absl::optional<double> rtt_mult_add_cap_ms = absl::nullopt;
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200303 if (RttMultExperiment::RttMultEnabled()) {
304 rtt_mult = RttMultExperiment::GetRttMultValue();
“Michaele0f37042019-06-04 10:04:12 -0500305 // TODO(mhoro): add RttMultExperiment::GetJitterEstCapValue();
306 rtt_mult_add_cap_ms = 200.0;
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200307 }
“Michaele0f37042019-06-04 10:04:12 -0500308 timing_->SetJitterDelay(
309 jitter_estimator_.GetJitterEstimate(rtt_mult, rtt_mult_add_cap_ms));
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200310 timing_->UpdateCurrentDelay(render_time_ms, now_ms);
311 } else {
312 if (RttMultExperiment::RttMultEnabled() || add_rtt_to_playout_delay_)
Niels Möllerd9c2d942019-04-30 09:16:36 +0200313 jitter_estimator_.FrameNacked();
Sebastian Jansson1c747f52019-04-04 13:01:39 +0200314 }
315
316 UpdateJitterDelay();
317 UpdateTimingFrameInfo();
318
319 if (frames_out.size() == 1) {
320 return frames_out[0];
321 } else {
322 return CombineAndDeleteFrames(frames_out);
323 }
324}
325
philipele7c891f2018-02-22 14:35:06 +0100326bool FrameBuffer::HasBadRenderTiming(const EncodedFrame& frame,
327 int64_t now_ms) {
stefan95e97542017-05-23 09:52:18 -0700328 // Assume that render timing errors are due to changes in the video stream.
329 int64_t render_time_ms = frame.RenderTimeMs();
Stefan Holmer812ceaf2018-05-15 13:00:10 +0200330 // Zero render time means render immediately.
331 if (render_time_ms == 0) {
332 return false;
333 }
stefan95e97542017-05-23 09:52:18 -0700334 if (render_time_ms < 0) {
335 return true;
336 }
Stefan Holmer812ceaf2018-05-15 13:00:10 +0200337 const int64_t kMaxVideoDelayMs = 10000;
stefan95e97542017-05-23 09:52:18 -0700338 if (std::abs(render_time_ms - now_ms) > kMaxVideoDelayMs) {
339 int frame_delay = static_cast<int>(std::abs(render_time_ms - now_ms));
Mirko Bonadei675513b2017-11-09 11:09:25 +0100340 RTC_LOG(LS_WARNING)
341 << "A frame about to be decoded is out of the configured "
342 << "delay bounds (" << frame_delay << " > " << kMaxVideoDelayMs
343 << "). Resetting the video jitter buffer.";
stefan95e97542017-05-23 09:52:18 -0700344 return true;
345 }
346 if (static_cast<int>(timing_->TargetVideoDelay()) > kMaxVideoDelayMs) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100347 RTC_LOG(LS_WARNING) << "The video target delay has grown larger than "
348 << kMaxVideoDelayMs << " ms.";
stefan95e97542017-05-23 09:52:18 -0700349 return true;
350 }
351 return false;
352}
353
philipel4f6cd6a2016-08-03 10:59:32 +0200354void FrameBuffer::SetProtectionMode(VCMVideoProtection mode) {
tommidb23ea62017-03-03 07:21:18 -0800355 TRACE_EVENT0("webrtc", "FrameBuffer::SetProtectionMode");
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000356 rtc::CritScope lock(&crit_);
357 protection_mode_ = mode;
philipel4f6cd6a2016-08-03 10:59:32 +0200358}
359
philipel504c47d2016-06-30 17:33:02 +0200360void FrameBuffer::Start() {
tommidb23ea62017-03-03 07:21:18 -0800361 TRACE_EVENT0("webrtc", "FrameBuffer::Start");
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000362 rtc::CritScope lock(&crit_);
363 stopped_ = false;
philipel504c47d2016-06-30 17:33:02 +0200364}
365
366void FrameBuffer::Stop() {
tommidb23ea62017-03-03 07:21:18 -0800367 TRACE_EVENT0("webrtc", "FrameBuffer::Stop");
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000368 rtc::CritScope lock(&crit_);
369 stopped_ = true;
370 new_continuous_frame_event_.Set();
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200371 CancelCallback();
philipel504c47d2016-06-30 17:33:02 +0200372}
373
Ilya Nikolaevskiye6a2d942018-11-07 14:32:28 +0100374void FrameBuffer::Clear() {
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000375 rtc::CritScope lock(&crit_);
376 ClearFramesAndHistory();
Ilya Nikolaevskiye6a2d942018-11-07 14:32:28 +0100377}
378
philipele21be1d2017-09-25 06:37:12 -0700379void FrameBuffer::UpdateRtt(int64_t rtt_ms) {
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000380 rtc::CritScope lock(&crit_);
Niels Möllerd9c2d942019-04-30 09:16:36 +0200381 jitter_estimator_.UpdateRtt(rtt_ms);
philipele21be1d2017-09-25 06:37:12 -0700382}
383
philipele7c891f2018-02-22 14:35:06 +0100384bool FrameBuffer::ValidReferences(const EncodedFrame& frame) const {
philipel112adf92017-06-15 09:06:21 -0700385 for (size_t i = 0; i < frame.num_references; ++i) {
Philip Eliasson1f850a62019-03-19 12:15:00 +0000386 if (frame.references[i] >= frame.id.picture_id)
philipel112adf92017-06-15 09:06:21 -0700387 return false;
philipel3b3c9c42017-09-11 09:38:36 -0700388
philipel112adf92017-06-15 09:06:21 -0700389 for (size_t j = i + 1; j < frame.num_references; ++j) {
390 if (frame.references[i] == frame.references[j])
391 return false;
392 }
393 }
394
philipel0fa82a62018-03-19 15:34:53 +0100395 if (frame.inter_layer_predicted && frame.id.spatial_layer == 0)
philipel112adf92017-06-15 09:06:21 -0700396 return false;
397
398 return true;
399}
400
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200401void FrameBuffer::CancelCallback() {
402 frame_handler_ = {};
403 callback_task_.Stop();
404 callback_queue_ = nullptr;
405}
406
Ilya Nikolaevskiy48193b02019-03-25 11:40:34 +0100407bool FrameBuffer::IsCompleteSuperFrame(const EncodedFrame& frame) {
408 if (frame.inter_layer_predicted) {
409 // Check that all previous spatial layers are already inserted.
410 VideoLayerFrameId id = frame.id;
411 RTC_DCHECK_GT(id.spatial_layer, 0);
412 --id.spatial_layer;
413 FrameMap::iterator prev_frame = frames_.find(id);
Ilya Nikolaevskiyb4a70ed2019-04-23 10:37:06 +0200414 if (prev_frame == frames_.end() || !prev_frame->second.frame)
Ilya Nikolaevskiy48193b02019-03-25 11:40:34 +0100415 return false;
416 while (prev_frame->second.frame->inter_layer_predicted) {
Ilya Nikolaevskiyf87a7df2019-04-09 19:23:36 +0200417 if (prev_frame == frames_.begin())
418 return false;
Ilya Nikolaevskiy48193b02019-03-25 11:40:34 +0100419 --prev_frame;
420 --id.spatial_layer;
Ilya Nikolaevskiyb4a70ed2019-04-23 10:37:06 +0200421 if (!prev_frame->second.frame ||
422 prev_frame->first.picture_id != id.picture_id ||
Ilya Nikolaevskiy48193b02019-03-25 11:40:34 +0100423 prev_frame->first.spatial_layer != id.spatial_layer) {
424 return false;
425 }
426 }
427 }
428
429 if (!frame.is_last_spatial_layer) {
430 // Check that all following spatial layers are already inserted.
431 VideoLayerFrameId id = frame.id;
432 ++id.spatial_layer;
433 FrameMap::iterator next_frame = frames_.find(id);
Ilya Nikolaevskiyb4a70ed2019-04-23 10:37:06 +0200434 if (next_frame == frames_.end() || !next_frame->second.frame)
Ilya Nikolaevskiy48193b02019-03-25 11:40:34 +0100435 return false;
436 while (!next_frame->second.frame->is_last_spatial_layer) {
437 ++next_frame;
438 ++id.spatial_layer;
Ilya Nikolaevskiyb4a70ed2019-04-23 10:37:06 +0200439 if (next_frame == frames_.end() || !next_frame->second.frame ||
Ilya Nikolaevskiy48193b02019-03-25 11:40:34 +0100440 next_frame->first.picture_id != id.picture_id ||
441 next_frame->first.spatial_layer != id.spatial_layer) {
442 return false;
443 }
444 }
445 }
446
447 return true;
448}
449
philipele7c891f2018-02-22 14:35:06 +0100450int64_t FrameBuffer::InsertFrame(std::unique_ptr<EncodedFrame> frame) {
tommidb23ea62017-03-03 07:21:18 -0800451 TRACE_EVENT0("webrtc", "FrameBuffer::InsertFrame");
philipel93e451b2016-10-06 12:25:13 +0200452 RTC_DCHECK(frame);
tommi0a735642017-03-14 06:23:57 -0700453
454 rtc::CritScope lock(&crit_);
philipel29f730e2017-03-15 08:10:08 -0700455
Ilya Nikolaevskiy48193b02019-03-25 11:40:34 +0100456 if (stats_callback_ && IsCompleteSuperFrame(*frame)) {
457 stats_callback_->OnCompleteFrame(frame->is_keyframe(), frame->size(),
458 frame->contentType());
459 }
460 const VideoLayerFrameId& id = frame->id;
461
philipel1610f942017-12-12 13:58:31 +0100462 int64_t last_continuous_picture_id =
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100463 !last_continuous_frame_ ? -1 : last_continuous_frame_->picture_id;
philipele0b2f152016-09-28 10:23:49 +0200464
philipel112adf92017-06-15 09:06:21 -0700465 if (!ValidReferences(*frame)) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100466 RTC_LOG(LS_WARNING) << "Frame with (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100467 << id.picture_id << ":"
468 << static_cast<int>(id.spatial_layer)
Mirko Bonadei675513b2017-11-09 11:09:25 +0100469 << ") has invalid frame references, dropping frame.";
philipel112adf92017-06-15 09:06:21 -0700470 return last_continuous_picture_id;
471 }
472
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100473 if (frames_.size() >= kMaxFramesBuffered) {
philipel9771c502018-03-02 11:06:27 +0100474 if (frame->is_keyframe()) {
475 RTC_LOG(LS_WARNING) << "Inserting keyframe (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100476 << id.picture_id << ":"
477 << static_cast<int>(id.spatial_layer)
philipel9771c502018-03-02 11:06:27 +0100478 << ") but buffer is full, clearing"
479 << " buffer and inserting the frame.";
480 ClearFramesAndHistory();
481 } else {
482 RTC_LOG(LS_WARNING) << "Frame with (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100483 << id.picture_id << ":"
484 << static_cast<int>(id.spatial_layer)
philipel9771c502018-03-02 11:06:27 +0100485 << ") could not be inserted due to the frame "
486 << "buffer being full, dropping frame.";
487 return last_continuous_picture_id;
488 }
philipele0b2f152016-09-28 10:23:49 +0200489 }
490
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100491 auto last_decoded_frame = decoded_frames_history_.GetLastDecodedFrameId();
492 auto last_decoded_frame_timestamp =
493 decoded_frames_history_.GetLastDecodedFrameTimestamp();
494 if (last_decoded_frame && id <= *last_decoded_frame) {
495 if (AheadOf(frame->Timestamp(), *last_decoded_frame_timestamp) &&
philipel3042c2d2017-08-18 04:55:02 -0700496 frame->is_keyframe()) {
philipelfcc60062017-01-18 05:35:20 -0800497 // If this frame has a newer timestamp but an earlier picture id then we
498 // assume there has been a jump in the picture id due to some encoder
499 // reconfiguration or some other reason. Even though this is not according
500 // to spec we can still continue to decode from this frame if it is a
501 // keyframe.
Mirko Bonadei675513b2017-11-09 11:09:25 +0100502 RTC_LOG(LS_WARNING)
503 << "A jump in picture id was detected, clearing buffer.";
philipelfcc60062017-01-18 05:35:20 -0800504 ClearFramesAndHistory();
505 last_continuous_picture_id = -1;
506 } else {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100507 RTC_LOG(LS_WARNING) << "Frame with (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100508 << id.picture_id << ":"
509 << static_cast<int>(id.spatial_layer)
Mirko Bonadei675513b2017-11-09 11:09:25 +0100510 << ") inserted after frame ("
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100511 << last_decoded_frame->picture_id << ":"
512 << static_cast<int>(last_decoded_frame->spatial_layer)
Mirko Bonadei675513b2017-11-09 11:09:25 +0100513 << ") was handed off for decoding, dropping frame.";
philipelfcc60062017-01-18 05:35:20 -0800514 return last_continuous_picture_id;
515 }
philipele0b2f152016-09-28 10:23:49 +0200516 }
517
philipel146a48b2017-04-20 04:04:38 -0700518 // Test if inserting this frame would cause the order of the frames to become
519 // ambiguous (covering more than half the interval of 2^16). This can happen
520 // when the picture id make large jumps mid stream.
philipel0fa82a62018-03-19 15:34:53 +0100521 if (!frames_.empty() && id < frames_.begin()->first &&
522 frames_.rbegin()->first < id) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100523 RTC_LOG(LS_WARNING)
524 << "A jump in picture id was detected, clearing buffer.";
philipel146a48b2017-04-20 04:04:38 -0700525 ClearFramesAndHistory();
526 last_continuous_picture_id = -1;
527 }
528
philipel0fa82a62018-03-19 15:34:53 +0100529 auto info = frames_.emplace(id, FrameInfo()).first;
philipele0b2f152016-09-28 10:23:49 +0200530
philipel93e451b2016-10-06 12:25:13 +0200531 if (info->second.frame) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100532 RTC_LOG(LS_WARNING) << "Frame with (picture_id:spatial_id) ("
philipel0fa82a62018-03-19 15:34:53 +0100533 << id.picture_id << ":"
534 << static_cast<int>(id.spatial_layer)
Mirko Bonadei675513b2017-11-09 11:09:25 +0100535 << ") already inserted, dropping frame.";
philipele0b2f152016-09-28 10:23:49 +0200536 return last_continuous_picture_id;
537 }
538
philipel93e451b2016-10-06 12:25:13 +0200539 if (!UpdateFrameInfoWithIncomingFrame(*frame, info))
540 return last_continuous_picture_id;
Ruslan Burakov493a6502019-02-27 15:32:48 +0100541
542 if (!frame->delayed_by_retransmission())
543 timing_->IncomingTimestamp(frame->Timestamp(), frame->ReceivedTime());
philipel0a9f6de2018-02-28 11:29:47 +0100544
philipele0b2f152016-09-28 10:23:49 +0200545 info->second.frame = std::move(frame);
philipele0b2f152016-09-28 10:23:49 +0200546
547 if (info->second.num_missing_continuous == 0) {
548 info->second.continuous = true;
549 PropagateContinuity(info);
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100550 last_continuous_picture_id = last_continuous_frame_->picture_id;
philipele0b2f152016-09-28 10:23:49 +0200551
552 // Since we now have new continuous frames there might be a better frame
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200553 // to return from NextFrame.
Henrik Boströmc680c4a2019-04-03 10:27:36 +0000554 new_continuous_frame_event_.Set();
Sebastian Jansson11d0d7b2019-04-11 12:39:34 +0200555
556 if (callback_queue_) {
557 callback_queue_->PostTask([this] {
558 rtc::CritScope lock(&crit_);
559 if (!callback_task_.Running())
560 return;
561 RTC_CHECK(frame_handler_);
562 callback_task_.Stop();
563 StartWaitForNextFrameOnQueue();
564 });
565 }
philipele0b2f152016-09-28 10:23:49 +0200566 }
567
568 return last_continuous_picture_id;
philipelbe7a9e52016-05-19 12:19:35 +0200569}
570
philipele0b2f152016-09-28 10:23:49 +0200571void FrameBuffer::PropagateContinuity(FrameMap::iterator start) {
tommidb23ea62017-03-03 07:21:18 -0800572 TRACE_EVENT0("webrtc", "FrameBuffer::PropagateContinuity");
philipele0b2f152016-09-28 10:23:49 +0200573 RTC_DCHECK(start->second.continuous);
philipele0b2f152016-09-28 10:23:49 +0200574
575 std::queue<FrameMap::iterator> continuous_frames;
576 continuous_frames.push(start);
577
578 // A simple BFS to traverse continuous frames.
579 while (!continuous_frames.empty()) {
580 auto frame = continuous_frames.front();
581 continuous_frames.pop();
582
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100583 if (!last_continuous_frame_ || *last_continuous_frame_ < frame->first) {
584 last_continuous_frame_ = frame->first;
585 }
philipele0b2f152016-09-28 10:23:49 +0200586
587 // Loop through all dependent frames, and if that frame no longer has
588 // any unfulfilled dependencies then that frame is continuous as well.
Elad Alon69321dd2019-01-10 15:02:54 +0100589 for (size_t d = 0; d < frame->second.dependent_frames.size(); ++d) {
philipele0b2f152016-09-28 10:23:49 +0200590 auto frame_ref = frames_.find(frame->second.dependent_frames[d]);
philipel112adf92017-06-15 09:06:21 -0700591 RTC_DCHECK(frame_ref != frames_.end());
philipele0b2f152016-09-28 10:23:49 +0200592
philipel112adf92017-06-15 09:06:21 -0700593 // TODO(philipel): Look into why we've seen this happen.
594 if (frame_ref != frames_.end()) {
595 --frame_ref->second.num_missing_continuous;
596 if (frame_ref->second.num_missing_continuous == 0) {
597 frame_ref->second.continuous = true;
598 continuous_frames.push(frame_ref);
599 }
philipele0b2f152016-09-28 10:23:49 +0200600 }
601 }
602 }
603}
604
605void FrameBuffer::PropagateDecodability(const FrameInfo& info) {
tommidb23ea62017-03-03 07:21:18 -0800606 TRACE_EVENT0("webrtc", "FrameBuffer::PropagateDecodability");
Elad Alon69321dd2019-01-10 15:02:54 +0100607 for (size_t d = 0; d < info.dependent_frames.size(); ++d) {
philipele0b2f152016-09-28 10:23:49 +0200608 auto ref_info = frames_.find(info.dependent_frames[d]);
philipel93e451b2016-10-06 12:25:13 +0200609 RTC_DCHECK(ref_info != frames_.end());
tommie95b78b2017-05-14 07:23:11 -0700610 // TODO(philipel): Look into why we've seen this happen.
611 if (ref_info != frames_.end()) {
612 RTC_DCHECK_GT(ref_info->second.num_missing_decodable, 0U);
613 --ref_info->second.num_missing_decodable;
614 }
philipele0b2f152016-09-28 10:23:49 +0200615 }
616}
617
philipele7c891f2018-02-22 14:35:06 +0100618bool FrameBuffer::UpdateFrameInfoWithIncomingFrame(const EncodedFrame& frame,
philipele0b2f152016-09-28 10:23:49 +0200619 FrameMap::iterator info) {
tommidb23ea62017-03-03 07:21:18 -0800620 TRACE_EVENT0("webrtc", "FrameBuffer::UpdateFrameInfoWithIncomingFrame");
philipel0fa82a62018-03-19 15:34:53 +0100621 const VideoLayerFrameId& id = frame.id;
philipele0b2f152016-09-28 10:23:49 +0200622
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100623 auto last_decoded_frame = decoded_frames_history_.GetLastDecodedFrameId();
624 RTC_DCHECK(!last_decoded_frame || *last_decoded_frame < info->first);
philipele0b2f152016-09-28 10:23:49 +0200625
philipel798b2822018-06-11 13:10:14 +0200626 // In this function we determine how many missing dependencies this |frame|
627 // has to become continuous/decodable. If a frame that this |frame| depend
628 // on has already been decoded then we can ignore that dependency since it has
629 // already been fulfilled.
630 //
631 // For all other frames we will register a backwards reference to this |frame|
632 // so that |num_missing_continuous| and |num_missing_decodable| can be
633 // decremented as frames become continuous/are decoded.
634 struct Dependency {
635 VideoLayerFrameId id;
636 bool continuous;
637 };
638 std::vector<Dependency> not_yet_fulfilled_dependencies;
639
640 // Find all dependencies that have not yet been fulfilled.
philipele0b2f152016-09-28 10:23:49 +0200641 for (size_t i = 0; i < frame.num_references; ++i) {
philipel0fa82a62018-03-19 15:34:53 +0100642 VideoLayerFrameId ref_key(frame.references[i], frame.id.spatial_layer);
philipel798b2822018-06-11 13:10:14 +0200643 // Does |frame| depend on a frame earlier than the last decoded one?
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100644 if (last_decoded_frame && ref_key <= *last_decoded_frame) {
philipel798b2822018-06-11 13:10:14 +0200645 // Was that frame decoded? If not, this |frame| will never become
646 // decodable.
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100647 if (!decoded_frames_history_.WasDecoded(ref_key)) {
philipel65e1f942017-07-24 08:26:53 -0700648 int64_t now_ms = clock_->TimeInMilliseconds();
649 if (last_log_non_decoded_ms_ + kLogNonDecodedIntervalMs < now_ms) {
Mirko Bonadei675513b2017-11-09 11:09:25 +0100650 RTC_LOG(LS_WARNING)
philipel0fa82a62018-03-19 15:34:53 +0100651 << "Frame with (picture_id:spatial_id) (" << id.picture_id << ":"
652 << static_cast<int>(id.spatial_layer)
philipel65e1f942017-07-24 08:26:53 -0700653 << ") depends on a non-decoded frame more previous than"
654 << " the last decoded frame, dropping frame.";
655 last_log_non_decoded_ms_ = now_ms;
656 }
philipele0b2f152016-09-28 10:23:49 +0200657 return false;
658 }
philipele0b2f152016-09-28 10:23:49 +0200659 } else {
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100660 auto ref_info = frames_.find(ref_key);
philipel798b2822018-06-11 13:10:14 +0200661 bool ref_continuous =
662 ref_info != frames_.end() && ref_info->second.continuous;
663 not_yet_fulfilled_dependencies.push_back({ref_key, ref_continuous});
philipele0b2f152016-09-28 10:23:49 +0200664 }
philipelbe7a9e52016-05-19 12:19:35 +0200665 }
666
philipel798b2822018-06-11 13:10:14 +0200667 // Does |frame| depend on the lower spatial layer?
philipelbe7a9e52016-05-19 12:19:35 +0200668 if (frame.inter_layer_predicted) {
philipel0fa82a62018-03-19 15:34:53 +0100669 VideoLayerFrameId ref_key(frame.id.picture_id, frame.id.spatial_layer - 1);
philipel798b2822018-06-11 13:10:14 +0200670 auto ref_info = frames_.find(ref_key);
philipele0b2f152016-09-28 10:23:49 +0200671
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100672 bool lower_layer_decoded =
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100673 last_decoded_frame && *last_decoded_frame == ref_key;
philipel798b2822018-06-11 13:10:14 +0200674 bool lower_layer_continuous =
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100675 lower_layer_decoded ||
676 (ref_info != frames_.end() && ref_info->second.continuous);
philipel798b2822018-06-11 13:10:14 +0200677
678 if (!lower_layer_continuous || !lower_layer_decoded) {
679 not_yet_fulfilled_dependencies.push_back(
680 {ref_key, lower_layer_continuous});
philipele0b2f152016-09-28 10:23:49 +0200681 }
philipelbe7a9e52016-05-19 12:19:35 +0200682 }
683
philipel798b2822018-06-11 13:10:14 +0200684 info->second.num_missing_continuous = not_yet_fulfilled_dependencies.size();
685 info->second.num_missing_decodable = not_yet_fulfilled_dependencies.size();
686
687 for (const Dependency& dep : not_yet_fulfilled_dependencies) {
688 if (dep.continuous)
689 --info->second.num_missing_continuous;
690
Elad Alon69321dd2019-01-10 15:02:54 +0100691 frames_[dep.id].dependent_frames.push_back(id);
philipel798b2822018-06-11 13:10:14 +0200692 }
philipel93e451b2016-10-06 12:25:13 +0200693
philipelbe7a9e52016-05-19 12:19:35 +0200694 return true;
695}
696
philipelbe742702016-11-30 01:31:40 -0800697void FrameBuffer::UpdateJitterDelay() {
tommidb23ea62017-03-03 07:21:18 -0800698 TRACE_EVENT0("webrtc", "FrameBuffer::UpdateJitterDelay");
philipela45102f2017-02-22 05:30:39 -0800699 if (!stats_callback_)
700 return;
philipelbe742702016-11-30 01:31:40 -0800701
philipela45102f2017-02-22 05:30:39 -0800702 int decode_ms;
703 int max_decode_ms;
704 int current_delay_ms;
705 int target_delay_ms;
706 int jitter_buffer_ms;
707 int min_playout_delay_ms;
708 int render_delay_ms;
709 if (timing_->GetTimings(&decode_ms, &max_decode_ms, &current_delay_ms,
710 &target_delay_ms, &jitter_buffer_ms,
711 &min_playout_delay_ms, &render_delay_ms)) {
712 stats_callback_->OnFrameBufferTimingsUpdated(
713 decode_ms, max_decode_ms, current_delay_ms, target_delay_ms,
714 jitter_buffer_ms, min_playout_delay_ms, render_delay_ms);
philipelbe742702016-11-30 01:31:40 -0800715 }
philipel266f0a42016-11-28 08:49:07 -0800716}
717
ilnik2edc6842017-07-06 03:06:50 -0700718void FrameBuffer::UpdateTimingFrameInfo() {
719 TRACE_EVENT0("webrtc", "FrameBuffer::UpdateTimingFrameInfo");
Danil Chapovalov0040b662018-06-18 10:48:16 +0200720 absl::optional<TimingFrameInfo> info = timing_->GetTimingFrameInfo();
philipel97187112018-03-23 10:43:21 +0100721 if (info && stats_callback_)
ilnik2edc6842017-07-06 03:06:50 -0700722 stats_callback_->OnTimingFrameInfoUpdated(*info);
723}
724
philipelfcc60062017-01-18 05:35:20 -0800725void FrameBuffer::ClearFramesAndHistory() {
ilnik2edc6842017-07-06 03:06:50 -0700726 TRACE_EVENT0("webrtc", "FrameBuffer::ClearFramesAndHistory");
philipelfcc60062017-01-18 05:35:20 -0800727 frames_.clear();
Ilya Nikolaevskiy6551faf2019-01-10 15:16:47 +0100728 last_continuous_frame_.reset();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100729 frames_to_decode_.clear();
Ilya Nikolaevskiy13717842019-01-14 13:24:22 +0100730 decoded_frames_history_.Clear();
philipelfcc60062017-01-18 05:35:20 -0800731}
732
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100733EncodedFrame* FrameBuffer::CombineAndDeleteFrames(
734 const std::vector<EncodedFrame*>& frames) const {
735 RTC_DCHECK(!frames.empty());
Sergey Silkin61832dd2018-12-20 14:32:14 +0100736 EncodedFrame* first_frame = frames[0];
737 EncodedFrame* last_frame = frames.back();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100738 size_t total_length = 0;
739 for (size_t i = 0; i < frames.size(); ++i) {
740 total_length += frames[i]->size();
741 }
Sergey Silkin61832dd2018-12-20 14:32:14 +0100742 first_frame->VerifyAndAllocate(total_length);
743
Sergey Silkin2799e632019-05-17 09:51:39 +0200744 first_frame->SetSpatialLayerFrameSize(first_frame->id.spatial_layer,
745 first_frame->size());
746
Sergey Silkin61832dd2018-12-20 14:32:14 +0100747 // Spatial index of combined frame is set equal to spatial index of its top
748 // spatial layer.
749 first_frame->SetSpatialIndex(last_frame->id.spatial_layer);
750 first_frame->id.spatial_layer = last_frame->id.spatial_layer;
751
752 first_frame->video_timing_mutable()->network2_timestamp_ms =
753 last_frame->video_timing().network2_timestamp_ms;
754 first_frame->video_timing_mutable()->receive_finish_ms =
755 last_frame->video_timing().receive_finish_ms;
756
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100757 // Append all remaining frames to the first one.
Niels Möller9c843902019-01-11 10:21:35 +0100758 uint8_t* buffer = first_frame->data() + first_frame->size();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100759 for (size_t i = 1; i < frames.size(); ++i) {
Sergey Silkin61832dd2018-12-20 14:32:14 +0100760 EncodedFrame* next_frame = frames[i];
Sergey Silkin2799e632019-05-17 09:51:39 +0200761 first_frame->SetSpatialLayerFrameSize(next_frame->id.spatial_layer,
762 next_frame->size());
Niels Möller9c843902019-01-11 10:21:35 +0100763 memcpy(buffer, next_frame->data(), next_frame->size());
Sergey Silkin61832dd2018-12-20 14:32:14 +0100764 buffer += next_frame->size();
765 delete next_frame;
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100766 }
Sergey Silkin61832dd2018-12-20 14:32:14 +0100767 first_frame->set_size(total_length);
768 return first_frame;
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100769}
770
Niels Möllerbe682d42018-03-27 08:31:45 +0200771FrameBuffer::FrameInfo::FrameInfo() = default;
772FrameBuffer::FrameInfo::FrameInfo(FrameInfo&&) = default;
773FrameBuffer::FrameInfo::~FrameInfo() = default;
774
philipelbe7a9e52016-05-19 12:19:35 +0200775} // namespace video_coding
776} // namespace webrtc