blob: e269632ccc82469a369ce217e6ae652533408fca [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +000011#include <algorithm>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000012#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080013#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070014#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000015#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000016
Niels Möller039743e2018-10-23 10:07:25 +020017#include "absl/strings/match.h"
Seth Hampson24722b32017-12-22 09:36:42 -080018#include "api/rtpparameters.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070019#include "api/test/mock_video_decoder_factory.h"
20#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020021#include "api/units/time_delta.h"
Åsa Persson23eba222018-10-02 14:47:06 +020022#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020023#include "api/video_codecs/builtin_video_decoder_factory.h"
24#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020025#include "api/video_codecs/sdp_video_format.h"
26#include "api/video_codecs/video_decoder_factory.h"
27#include "api/video_codecs/video_encoder.h"
28#include "api/video_codecs/video_encoder_factory.h"
29#include "call/flexfec_receive_stream.h"
30#include "common_video/h264/profile_level_id.h"
31#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller6557d0c2018-04-11 15:18:34 +020032#include "media/base/fakenetworkinterface.h"
33#include "media/base/fakevideocapturer.h"
34#include "media/base/fakevideorenderer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020035#include "media/base/mediaconstants.h"
36#include "media/base/rtputils.h"
37#include "media/base/testutils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020038#include "media/engine/constants.h"
39#include "media/engine/fakewebrtccall.h"
40#include "media/engine/fakewebrtcvideoengine.h"
41#include "media/engine/simulcast.h"
42#include "media/engine/webrtcvideoengine.h"
43#include "media/engine/webrtcvoiceengine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020044#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020045#include "rtc_base/arraysize.h"
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +020046#include "rtc_base/fakeclock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020047#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020048#include "rtc_base/numerics/safe_conversions.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020049#include "rtc_base/stringutils.h"
50#include "test/field_trial.h"
51#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000052
Tommi85959932018-02-07 19:26:06 +010053using cricket::FakeVideoCapturerWithTaskQueue;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010054using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070055using webrtc::RtpExtension;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010056using testing::Field;
isheriff6f8d6862016-05-26 11:24:55 -070057
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000058namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000059static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000060
noahricd10a68e2015-07-10 11:27:55 -070061static const uint8_t kRedRtxPayloadType = 125;
62
Niels Möller6557d0c2018-04-11 15:18:34 +020063static const uint32_t kTimeout = 5000U;
64static const uint32_t kDefaultReceiveSsrc = 0;
65static const uint32_t kSsrc = 1234u;
66static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
67static const int kVideoWidth = 640;
68static const int kVideoHeight = 360;
69static const int kFramerate = 30;
70
Peter Boström0c4e06b2015-10-07 12:23:21 +020071static const uint32_t kSsrcs1[] = {1};
72static const uint32_t kSsrcs3[] = {1, 2, 3};
73static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080074static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020075static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080076static const uint32_t kDefaultRecvSsrc = 0;
77
pbos@webrtc.org3c107582014-07-20 15:27:35 +000078static const char kUnsupportedExtensionName[] =
79 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000080
magjed509e4fe2016-11-18 01:34:11 -080081cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
82 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020083 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080084}
85
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000086void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
87 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
88 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
89 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
90 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
91 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
92 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
93 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -080094 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
95 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000096 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
97}
98
magjed725e4842016-11-16 00:48:13 -080099// Return true if any codec in |codecs| is an RTX codec with associated payload
100// type |payload_type|.
101bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
102 int payload_type) {
103 for (const cricket::VideoCodec& codec : codecs) {
104 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200105 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800106 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
107 &associated_payload_type) &&
108 associated_payload_type == payload_type) {
109 return true;
110 }
111 }
112 return false;
113}
114
nisseca5706d2017-09-11 02:32:16 -0700115// TODO(nisse): Duplicated in call.cc.
116const int* FindKeyByValue(const std::map<int, int>& m, int v) {
117 for (const auto& kv : m) {
118 if (kv.second == v)
119 return &kv.first;
120 }
121 return nullptr;
122}
123
Yves Gerey665174f2018-06-19 15:03:05 +0200124bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
125 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700126 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
127 payload_type) != nullptr;
128}
129
130// Check that there's an Rtx payload type for each decoder.
131bool VerifyRtxReceiveAssociations(
132 const webrtc::VideoReceiveStream::Config& config) {
133 for (const auto& decoder : config.decoders) {
134 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
135 return false;
136 }
137 return true;
138}
139
brandtrffc61182016-11-28 06:02:22 -0800140rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700141 int width,
142 int height) {
143 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
144 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800145 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700146 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000147}
148
Shao Changbine62202f2015-04-21 20:24:50 +0800149void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
150 const std::map<int, int>& rtx_types) {
151 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200152 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800153 EXPECT_TRUE(it != rtx_types.end() &&
154 it->second == config.rtp.rtx.payload_type);
155
brandtrb5f2c3f2016-10-04 23:28:39 -0700156 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
157 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800158 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700159 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800160 }
161}
kthelgason2bc68642017-02-07 07:02:22 -0800162
163cricket::MediaConfig GetMediaConfig() {
164 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100165 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800166 return media_config;
167}
nisse26e3abb2017-08-25 04:44:25 -0700168
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200169// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
170int GetMaxDefaultBitrateBps(size_t width, size_t height) {
171 if (width * height <= 320 * 240) {
172 return 600000;
173 } else if (width * height <= 640 * 480) {
174 return 1700000;
175 } else if (width * height <= 960 * 540) {
176 return 2000000;
177 } else {
178 return 2500000;
179 }
180}
181
Niels Möller731a2c22018-07-30 15:08:07 +0200182class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
183 public:
184 MOCK_METHOD2(AddOrUpdateSink,
185 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
186 const rtc::VideoSinkWants& wants));
187 MOCK_METHOD1(RemoveSink,
188 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
189};
190
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000191} // namespace
192
Yves Gerey665174f2018-06-19 15:03:05 +0200193#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200194 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200195 EXPECT_EQ((w), renderer_.width()); \
196 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200197 EXPECT_EQ(0, renderer_.errors());
198
Yves Gerey665174f2018-06-19 15:03:05 +0200199#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200200 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200201 EXPECT_EQ((w), (r).width()); \
202 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200203 EXPECT_EQ(0, (r).errors());
204
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000205namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700206class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000207 public:
eladalonf1841382017-06-12 01:16:46 -0700208 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
209 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700210 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700211 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200212 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
213 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +0200214 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200215 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200216 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200217 decoder_factory_)) {
218 // Ensure fake clock doesn't return 0, which will cause some initializations
219 // fail inside RTP senders.
220 fake_clock_.AdvanceTimeMicros(1);
221 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000222
223 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200224 void AssignDefaultAptRtxTypes();
225 void AssignDefaultCodec();
226
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100227 // Find the index of the codec in the engine with the given name. The codec
228 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100229 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100230
magjed509e4fe2016-11-18 01:34:11 -0800231 // Find the codec in the engine with the given name. The codec must be
232 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100233 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800234
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200235 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000236
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200237 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000238 const std::vector<VideoCodec>& codecs);
239
Peter Boströme4499152016-02-05 11:13:28 +0100240 void TestExtendedEncoderOveruse(bool use_external_encoder);
241
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200242 // Has to be the first one, so it is initialized before the call or there is a
243 // race condition in the clock access.
244 rtc::ScopedFakeClock fake_clock_;
stefanc1aeaf02015-10-15 07:26:07 -0700245 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700246 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700247 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000248 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800249 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200250 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
251 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -0700252 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000253 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800254 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000255};
256
eladalonf1841382017-06-12 01:16:46 -0700257TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200258 encoder_factory_->AddSupportedVideoCodecType("VP8");
259 AssignDefaultCodec();
260
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000261 std::vector<VideoCodec> engine_codecs = engine_.codecs();
262 for (size_t i = 0; i < engine_codecs.size(); ++i) {
263 if (engine_codecs[i].name != kRtxCodecName)
264 continue;
265 int associated_payload_type;
266 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000267 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000268 EXPECT_EQ(default_codec_.id, associated_payload_type);
269 return;
270 }
271 FAIL() << "No RTX codec found among default codecs.";
272}
273
eladalonf1841382017-06-12 01:16:46 -0700274TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100275 RtpCapabilities capabilities = engine_.GetCapabilities();
276 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700277 for (const RtpExtension& extension : capabilities.header_extensions) {
278 if (extension.uri == RtpExtension::kTimestampOffsetUri) {
279 EXPECT_EQ(RtpExtension::kTimestampOffsetDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000280 return;
281 }
282 }
283 FAIL() << "Timestamp offset extension not in header-extension list.";
284}
285
eladalonf1841382017-06-12 01:16:46 -0700286TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100287 RtpCapabilities capabilities = engine_.GetCapabilities();
288 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700289 for (const RtpExtension& extension : capabilities.header_extensions) {
290 if (extension.uri == RtpExtension::kAbsSendTimeUri) {
291 EXPECT_EQ(RtpExtension::kAbsSendTimeDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000292 return;
293 }
294 }
295 FAIL() << "Absolute Sender Time extension not in header-extension list.";
296}
297
eladalonf1841382017-06-12 01:16:46 -0700298TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100299 RtpCapabilities capabilities = engine_.GetCapabilities();
300 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700301 for (const RtpExtension& extension : capabilities.header_extensions) {
302 if (extension.uri == RtpExtension::kTransportSequenceNumberUri) {
303 EXPECT_EQ(RtpExtension::kTransportSequenceNumberDefaultId, extension.id);
stefanc1aeaf02015-10-15 07:26:07 -0700304 return;
305 }
306 }
307 FAIL() << "Transport sequence number extension not in header-extension list.";
308}
309
eladalonf1841382017-06-12 01:16:46 -0700310TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100311 RtpCapabilities capabilities = engine_.GetCapabilities();
312 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700313 for (const RtpExtension& extension : capabilities.header_extensions) {
314 if (extension.uri == RtpExtension::kVideoRotationUri) {
315 EXPECT_EQ(RtpExtension::kVideoRotationDefaultId, extension.id);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700316 return;
317 }
318 }
319 FAIL() << "Video Rotation extension not in header-extension list.";
320}
321
philipel1e054862018-10-08 16:13:53 +0200322class WebRtcVideoEngineTestWithGenericDescriptor
323 : public WebRtcVideoEngineTest {
324 public:
325 WebRtcVideoEngineTestWithGenericDescriptor()
326 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
327};
328
329TEST_F(WebRtcVideoEngineTestWithGenericDescriptor, AdvertiseGenericDescriptor) {
330 RtpCapabilities capabilities = engine_.GetCapabilities();
331 ASSERT_FALSE(capabilities.header_extensions.empty());
332 for (const RtpExtension& extension : capabilities.header_extensions) {
333 if (extension.uri == RtpExtension::kGenericFrameDescriptorUri) {
334 EXPECT_EQ(RtpExtension::kGenericFrameDescriptorDefaultId, extension.id);
335 return;
336 }
337 }
338 FAIL() << "Generic descriptor extension not in header-extension list.";
339}
340
eladalonf1841382017-06-12 01:16:46 -0700341TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200342 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700343 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200344 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700345
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200346 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700347
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200348 std::unique_ptr<VideoMediaChannel> channel(
349 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700350 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
351
352 // Add CVO extension.
353 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800354 cricket::VideoSendParameters parameters;
355 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200356 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700357 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200358 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700359
Niels Möller731a2c22018-07-30 15:08:07 +0200360 EXPECT_CALL(
361 video_source,
362 AddOrUpdateSink(testing::_,
363 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700364 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200365 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700366
367 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200368 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700369
370 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200371 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200372 EXPECT_CALL(
373 video_source,
374 AddOrUpdateSink(testing::_,
375 Field(&rtc::VideoSinkWants::rotation_applied, true)));
376
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200377 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700378}
379
eladalonf1841382017-06-12 01:16:46 -0700380TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200381 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800382 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200383 testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800384
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200385 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800386
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200387 std::unique_ptr<VideoMediaChannel> channel(
388 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800389 // Add CVO extension.
390 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800391 cricket::VideoSendParameters parameters;
392 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800393 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700394 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800395 EXPECT_TRUE(channel->SetSendParameters(parameters));
396 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
397
Niels Möller731a2c22018-07-30 15:08:07 +0200398 // Set source.
399 EXPECT_CALL(
400 video_source,
401 AddOrUpdateSink(testing::_,
402 Field(&rtc::VideoSinkWants::rotation_applied, false)));
403 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800404}
405
eladalonf1841382017-06-12 01:16:46 -0700406TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200407 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700408
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200409 encoder_factory_->AddSupportedVideoCodecType("VP8");
410 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700411
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200412 std::unique_ptr<VideoMediaChannel> channel(
413 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700414 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
415
416 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200417 EXPECT_CALL(
418 video_source,
419 AddOrUpdateSink(testing::_,
420 Field(&rtc::VideoSinkWants::rotation_applied, true)));
421 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700422
perkjcaafdba2016-03-20 07:34:29 -0700423 // Verify capturer has turned on applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200424 testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700425
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700426 // Add CVO extension.
427 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800428 cricket::VideoSendParameters parameters;
429 parameters.codecs.push_back(GetEngineCodec("VP8"));
430 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200431 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700432 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700433 // Also remove the first codec to trigger a codec change as well.
434 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200435 EXPECT_CALL(
436 video_source,
437 AddOrUpdateSink(testing::_,
438 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200439 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700440
441 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200442 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700443
444 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200445 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200446 EXPECT_CALL(
447 video_source,
448 AddOrUpdateSink(testing::_,
449 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200450 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700451}
452
eladalonf1841382017-06-12 01:16:46 -0700453TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200454 encoder_factory_->AddSupportedVideoCodecType("VP8");
455
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700456 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
457 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000458
459 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
460
461 EXPECT_FALSE(channel->SetSend(true))
462 << "Channel should not start without codecs.";
463 EXPECT_TRUE(channel->SetSend(false))
464 << "Channel should be stoppable even without set codecs.";
465}
466
eladalonf1841382017-06-12 01:16:46 -0700467TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200468 encoder_factory_->AddSupportedVideoCodecType("VP8");
469
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700470 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
471 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000472 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
473 VideoMediaInfo info;
474 channel->GetStats(&info);
475}
476
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200477TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200478 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000479
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200480 std::unique_ptr<VideoMediaChannel> channel(
481 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800482 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000483
484 EXPECT_TRUE(
485 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200486 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000487 EXPECT_TRUE(channel->SetSend(true));
Tommi85959932018-02-07 19:26:06 +0100488 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200489 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000490 EXPECT_EQ(cricket::CS_RUNNING,
491 capturer.Start(capturer.GetSupportedFormats()->front()));
492 EXPECT_TRUE(capturer.CaptureFrame());
Per21d45d22016-10-30 21:37:57 +0100493 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200494 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
495 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000496 kTimeout);
497
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200498 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100499 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000500
501 // Setting codecs of the same type should not reallocate any encoders
502 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800503 cricket::VideoSendParameters parameters;
504 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200505 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200506 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000507
508 // Remove stream previously added to free the external encoder instance.
509 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200510 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000511}
512
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200513// Test that when an encoder factory supports H264, we add an RTX
514// codec for it.
515// TODO(deadbeef): This test should be updated if/when we start
516// adding RTX codecs for unrecognized codec names.
517TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800518 using webrtc::H264::ProfileLevelIdToString;
519 using webrtc::H264::ProfileLevelId;
520 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200521 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
522 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800523 *ProfileLevelIdToString(
524 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200525 webrtc::SdpVideoFormat h264_constrained_high("H264");
526 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800527 *ProfileLevelIdToString(
528 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200529 webrtc::SdpVideoFormat h264_high("H264");
530 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800531 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
532
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200533 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
534 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
535 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700536
magjed725e4842016-11-16 00:48:13 -0800537 // First figure out what payload types the test codecs got assigned.
538 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800539 // Now search for RTX codecs for them. Expect that they all have associated
540 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800541 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200542 codecs,
543 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
544 ->id));
magjed725e4842016-11-16 00:48:13 -0800545 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200546 codecs,
547 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
548 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800549 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200550 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700551}
552
Peter Boström12996152016-05-14 02:03:18 +0200553#if !defined(RTC_DISABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700554TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200555 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100556
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200557 std::unique_ptr<VideoMediaChannel> channel(
558 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100559
560 EXPECT_TRUE(
561 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
562}
Peter Boström12996152016-05-14 02:03:18 +0200563#endif // !defined(RTC_DISABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100564
eladalonf1841382017-06-12 01:16:46 -0700565TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200566 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100567 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200568 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200569 std::unique_ptr<VideoMediaChannel> channel(
570 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700571
572 EXPECT_TRUE(
573 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
574
Tommi85959932018-02-07 19:26:06 +0100575 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200576 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
qiangchenc27d89f2015-07-16 10:27:16 -0700577 capturer.Start(cricket::VideoFormat(1280, 720,
578 cricket::VideoFormat::FpsToInterval(60),
579 cricket::FOURCC_I420));
580 channel->SetSend(true);
581
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200582 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700583
584 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700585 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700586 for (int i = 0; i < 10; i++) {
587 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700588 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700589 int64_t interval = timestamp - last_timestamp;
590
591 // Precision changes from nanosecond to millisecond.
592 // Allow error to be no more than 1.
593 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
594
595 last_timestamp = timestamp;
596 }
597
598 capturer.Start(cricket::VideoFormat(1280, 720,
599 cricket::VideoFormat::FpsToInterval(30),
600 cricket::FOURCC_I420));
601
602 EXPECT_TRUE(capturer.CaptureFrame());
603 last_timestamp = stream->GetLastTimestamp();
604 for (int i = 0; i < 10; i++) {
605 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700606 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700607 int64_t interval = timestamp - last_timestamp;
608
609 // Precision changes from nanosecond to millisecond.
610 // Allow error to be no more than 1.
611 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
612
613 last_timestamp = timestamp;
614 }
615
616 // Remove stream previously added to free the external encoder instance.
617 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
618}
619
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200620void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
621 std::vector<VideoCodec> engine_codecs = engine_.codecs();
622 RTC_DCHECK(!engine_codecs.empty());
623 for (const cricket::VideoCodec& codec : engine_codecs) {
624 if (codec.name == "rtx") {
625 int associated_payload_type;
626 if (codec.GetParam(kCodecParamAssociatedPayloadType,
627 &associated_payload_type)) {
628 default_apt_rtx_types_[associated_payload_type] = codec.id;
629 }
630 }
631 }
632}
633
634void WebRtcVideoEngineTest::AssignDefaultCodec() {
635 std::vector<VideoCodec> engine_codecs = engine_.codecs();
636 RTC_DCHECK(!engine_codecs.empty());
637 bool codec_set = false;
638 for (const cricket::VideoCodec& codec : engine_codecs) {
639 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
640 codec.name != "ulpfec") {
641 default_codec_ = codec;
642 codec_set = true;
643 }
644 }
645
646 RTC_DCHECK(codec_set);
647}
648
Oleh Prypina40f8242017-12-21 13:32:23 +0100649size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
650 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100651 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
652 for (size_t i = 0; i < codecs.size(); ++i) {
653 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200654 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200655 continue;
656 // The tests only use H264 Constrained Baseline. Make sure we don't return
657 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200658 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200659 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200660 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
661 if (profile_level_id->profile !=
662 webrtc::H264::kProfileConstrainedBaseline) {
663 continue;
664 }
665 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100666 return i;
magjed509e4fe2016-11-18 01:34:11 -0800667 }
668 // This point should never be reached.
669 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100670 return -1;
671}
672
673cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
674 const std::string& name) const {
675 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800676}
677
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200678VideoMediaChannel*
679WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700680 VideoMediaChannel* channel = engine_.CreateChannel(
681 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200682 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800683 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200684 for (const webrtc::SdpVideoFormat& format :
685 encoder_factory_->GetSupportedFormats()) {
686 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
687 if (std::find(parameters.codecs.begin(), parameters.codecs.end(),
688 engine_codec) == parameters.codecs.end()) {
689 parameters.codecs.push_back(engine_codec);
690 }
691 }
magjed509e4fe2016-11-18 01:34:11 -0800692
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200693 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000694
695 return channel;
696}
697
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200698VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000699 const std::vector<VideoCodec>& codecs) {
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700700 VideoMediaChannel* channel = engine_.CreateChannel(
701 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200702 cricket::VideoRecvParameters parameters;
703 parameters.codecs = codecs;
704 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000705
706 return channel;
707}
708
eladalonf1841382017-06-12 01:16:46 -0700709TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200710 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000711
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200712 std::unique_ptr<VideoMediaChannel> channel(
713 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000714
Peter Boström0c4e06b2015-10-07 12:23:21 +0200715 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000716
Yves Gerey665174f2018-06-19 15:03:05 +0200717 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000718 EXPECT_TRUE(channel->SetSend(true));
719
Tommi85959932018-02-07 19:26:06 +0100720 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200721 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000722 EXPECT_EQ(cricket::CS_RUNNING,
723 capturer.Start(capturer.GetSupportedFormats()->front()));
724 EXPECT_TRUE(capturer.CaptureFrame());
725
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200726 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000727
728 // Verify that encoders are configured for simulcast through adapter
729 // (increasing resolution and only configured to send one stream each).
730 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200731 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
732 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000733 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200734 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000735 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
736 EXPECT_GT(codec_settings.width, prev_width);
737 prev_width = codec_settings.width;
738 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000739
Niels Möllerff40b142018-04-09 08:49:14 +0200740 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000741
742 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200743 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000744}
745
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200746TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
747 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200748 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000749
Niels Möller4db138e2018-04-19 09:04:13 +0200750 // Set capturer.
751 FakeVideoCapturerWithTaskQueue capturer;
752 EXPECT_EQ(cricket::CS_RUNNING,
753 capturer.Start(capturer.GetSupportedFormats()->front()));
754
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700755 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
756 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200757 cricket::VideoSendParameters parameters;
758 parameters.codecs.push_back(GetEngineCodec("H264"));
759 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000760
761 EXPECT_TRUE(
762 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller4db138e2018-04-19 09:04:13 +0200763 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
764 // Sending one frame will have allocate the encoder.
765 EXPECT_TRUE(capturer.CaptureFrame());
766
767 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000768
Anders Carlsson67537952018-05-03 11:28:29 +0200769 cricket::VideoSendParameters new_parameters;
770 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
771 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200772
773 // Sending one frame will switch encoder.
774 EXPECT_TRUE(capturer.CaptureFrame());
775
Anders Carlsson8a150d92018-05-14 12:40:04 +0200776 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000777}
778
eladalonf1841382017-06-12 01:16:46 -0700779TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000780 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200781 encoder_factory_->AddSupportedVideoCodecType("VP8");
782 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000783
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700784 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
785 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800786 cricket::VideoSendParameters parameters;
787 parameters.codecs.push_back(GetEngineCodec("VP8"));
788 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000789
Peter Boström0c4e06b2015-10-07 12:23:21 +0200790 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000791
Yves Gerey665174f2018-06-19 15:03:05 +0200792 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000793 EXPECT_TRUE(channel->SetSend(true));
794
795 // Send a fake frame, or else the media engine will configure the simulcast
796 // encoder adapter at a low-enough size that it'll only create a single
797 // encoder layer.
Tommi85959932018-02-07 19:26:06 +0100798 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200799 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000800 EXPECT_EQ(cricket::CS_RUNNING,
801 capturer.Start(capturer.GetSupportedFormats()->front()));
802 EXPECT_TRUE(capturer.CaptureFrame());
803
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200804 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
805 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000806 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200807 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000808
809 channel.reset();
810 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200811 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000812}
813
eladalonf1841382017-06-12 01:16:46 -0700814TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000815 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200816 encoder_factory_->AddSupportedVideoCodecType("VP8");
817 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000818
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700819 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
820 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800821 cricket::VideoSendParameters parameters;
822 parameters.codecs.push_back(GetEngineCodec("H264"));
823 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000824
825 EXPECT_TRUE(
826 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100827
828 // Send a frame of 720p. This should trigger a "real" encoder initialization.
829 cricket::VideoFormat format(
830 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100831 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200832 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Per21d45d22016-10-30 21:37:57 +0100833 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
834 EXPECT_TRUE(capturer.CaptureFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200835 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
836 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200837 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000838 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200839 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000840
841 channel.reset();
842 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200843 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000844}
845
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200846TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
847 webrtc::test::ScopedFieldTrials override_field_trials_(
848 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200849 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700850
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700851 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
852 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200853 cricket::VideoSendParameters parameters;
854 parameters.codecs.push_back(GetEngineCodec("H264"));
855 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700856
Peter Boström0c4e06b2015-10-07 12:23:21 +0200857 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700858 EXPECT_TRUE(
859 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100860
861 // Send a frame of 720p. This should trigger a "real" encoder initialization.
noahricfdac5162015-08-27 01:59:29 -0700862 cricket::VideoFormat format(
863 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100864 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200865 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &capturer));
Peter Boströmce23bee2016-02-02 14:14:30 +0100866 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
867 EXPECT_TRUE(capturer.CaptureFrame());
868
Niels Möller4db138e2018-04-19 09:04:13 +0200869 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200870 ASSERT_EQ(1u, encoder_factory_->encoders().size());
871 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
872 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700873 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200874 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200875 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700876}
877
brandtrffc61182016-11-28 06:02:22 -0800878// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700879// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800880//
881// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700882TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800883 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200884 encoder_factory_->AddSupportedVideoCodecType("VP8");
885
brandtrffc61182016-11-28 06:02:22 -0800886 auto is_flexfec = [](const VideoCodec& codec) {
887 if (codec.name == "flexfec-03")
888 return true;
889 return false;
890 };
891
892 // FlexFEC is not active without field trial.
brandtrffc61182016-11-28 06:02:22 -0800893 const std::vector<VideoCodec> codecs_before = engine_.codecs();
894 EXPECT_EQ(codecs_before.end(), std::find_if(codecs_before.begin(),
895 codecs_before.end(), is_flexfec));
896
897 // FlexFEC is active with field trial.
898 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800899 "WebRTC-FlexFEC-03-Advertised/Enabled/");
brandtrffc61182016-11-28 06:02:22 -0800900 const std::vector<VideoCodec> codecs_after = engine_.codecs();
901 EXPECT_NE(codecs_after.end(),
902 std::find_if(codecs_after.begin(), codecs_after.end(), is_flexfec));
903}
904
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200905// Test that codecs are added in the order they are reported from the factory.
906TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
907 encoder_factory_->AddSupportedVideoCodecType("VP8");
908 const char* kFakeCodecName = "FakeCodec";
909 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000910
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200911 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100912 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200913 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
914 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000915}
916
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200917// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800918// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200919TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100920 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
921 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100922
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100923 // Set up external encoder factory with first codec, and initialize engine.
924 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
925
brandtrffc61182016-11-28 06:02:22 -0800926 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800927
928 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100929 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800930 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200931 // The codec itself and RTX should have been added.
932 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100933
934 // Check that both fake codecs are present and that the second fake codec
935 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100936 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
937 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100938 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800939}
940
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200941TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
942 const char* kFakeCodecName = "FakeCodec";
943 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
944
945 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
946 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
947}
948
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200949TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
950 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200951 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200952 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800953 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000954
kwiberg686a8ef2016-02-26 03:00:35 -0800955 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200956 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000957
958 EXPECT_TRUE(
959 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200960 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000961
962 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200963 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200964 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000965
966 // Remove stream previously added to free the external decoder instance.
967 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200968 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000969}
970
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200971// Verifies that we can set up decoders.
972TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000973 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
974 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
975 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
976 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200977 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +0200978 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000979 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800980 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000981
kwiberg686a8ef2016-02-26 03:00:35 -0800982 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200983 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000984
985 EXPECT_TRUE(
986 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200987 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000988}
989
Jonas Oreland49ac5952018-09-26 16:04:32 +0200990// Tests when GetSources is called with non-existing ssrc, it will return an
991// empty list of RtpSource without crashing.
992TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
993 // Setup an recv stream with |kSsrc|.
994 encoder_factory_->AddSupportedVideoCodecType("VP8");
995 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
996 cricket::VideoRecvParameters parameters;
997 parameters.codecs.push_back(GetEngineCodec("VP8"));
998 std::unique_ptr<VideoMediaChannel> channel(
999 SetRecvParamsWithSupportedCodecs(parameters.codecs));
1000
1001 EXPECT_TRUE(
1002 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1003
1004 // Call GetSources with |kSsrc + 1| which doesn't exist.
1005 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1006 EXPECT_EQ(0u, sources.size());
1007}
1008
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001009TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1010 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1011 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
1012 WebRtcVideoEngine engine(std::move(encoder_factory),
1013 std::move(decoder_factory));
1014 EXPECT_EQ(0u, engine.codecs().size());
1015}
1016
1017TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1018 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001019 webrtc::MockVideoEncoderFactory* encoder_factory =
1020 new webrtc::MockVideoEncoderFactory();
1021 webrtc::MockVideoDecoderFactory* decoder_factory =
1022 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001023 WebRtcVideoEngine engine(
1024 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1025 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1026 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1027 EXPECT_EQ(0u, engine.codecs().size());
1028 EXPECT_CALL(*encoder_factory, Die());
1029 EXPECT_CALL(*decoder_factory, Die());
1030}
1031
1032// Test full behavior in the video engine when video codec factories of the new
1033// type are injected supporting the single codec Vp8. Check the returned codecs
1034// from the engine and that we will create a Vp8 encoder and decoder using the
1035// new factories.
1036TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1037 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001038 webrtc::MockVideoEncoderFactory* encoder_factory =
1039 new webrtc::MockVideoEncoderFactory();
1040 webrtc::MockVideoDecoderFactory* decoder_factory =
1041 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001042 WebRtcVideoEngine engine(
1043 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1044 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1045 const webrtc::SdpVideoFormat vp8_format("VP8");
1046 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1047 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1048 .WillRepeatedly(testing::Return(supported_formats));
1049
1050 // Verify the codecs from the engine.
1051 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001052 // Verify default codecs has been added correctly.
1053 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001054 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001055
1056 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001057 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001058 int vp8_associated_payload;
1059 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1060 &vp8_associated_payload));
1061 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1062
1063 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1064
1065 // RTX codec for RED.
1066 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1067 int red_associated_payload;
1068 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1069 &red_associated_payload));
1070 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1071
1072 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1073
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001074 int associated_payload_type;
1075 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1076 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1077 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1078 // Verify default parameters has been added to the VP8 codec.
1079 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
1080
1081 // Mock encoder creation. |engine| take ownership of the encoder.
1082 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1083 codec_info.is_hardware_accelerated = false;
1084 codec_info.has_internal_source = false;
1085 const webrtc::SdpVideoFormat format("VP8");
1086 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
1087 .WillRepeatedly(testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001088 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möller4db138e2018-04-19 09:04:13 +02001089 rtc::Event encoder_created(false, false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001090 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001091 .WillOnce(
1092 ::testing::DoAll(::testing::InvokeWithoutArgs(
1093 [&encoder_created]() { encoder_created.Set(); }),
1094 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001095
1096 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001097 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001098 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
1099 .WillOnce(testing::Return(decoder));
1100
1101 // Create a call.
1102 webrtc::RtcEventLogNullImpl event_log;
1103 std::unique_ptr<webrtc::Call> call(
1104 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1105
1106 // Create send channel.
1107 const int send_ssrc = 123;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001108 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateChannel(
1109 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001110 cricket::VideoSendParameters send_parameters;
1111 send_parameters.codecs.push_back(engine_codecs.at(0));
1112 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1113 send_channel->OnReadyToSend(true);
1114 EXPECT_TRUE(
1115 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1116 EXPECT_TRUE(send_channel->SetSend(true));
1117
Niels Möller4db138e2018-04-19 09:04:13 +02001118 // Set capturer.
1119 FakeVideoCapturerWithTaskQueue capturer;
1120 EXPECT_EQ(cricket::CS_RUNNING,
1121 capturer.Start(capturer.GetSupportedFormats()->front()));
1122 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &capturer));
1123 // Sending one frame will allocate the encoder.
1124 EXPECT_TRUE(capturer.CaptureFrame());
1125 encoder_created.Wait(kTimeout);
1126
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001127 // Create recv channel.
1128 const int recv_ssrc = 321;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001129 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateChannel(
1130 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001131 cricket::VideoRecvParameters recv_parameters;
1132 recv_parameters.codecs.push_back(engine_codecs.at(0));
1133 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1134 EXPECT_TRUE(recv_channel->AddRecvStream(
1135 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1136
1137 // Remove streams previously added to free the encoder and decoder instance.
1138 EXPECT_CALL(*encoder_factory, Die());
1139 EXPECT_CALL(*decoder_factory, Die());
1140 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1141 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1142}
1143
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001144// Test behavior when decoder factory fails to create a decoder (returns null).
1145TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1146 // |engine| take ownership of the factories.
1147 webrtc::MockVideoEncoderFactory* encoder_factory =
1148 new testing::StrictMock<webrtc::MockVideoEncoderFactory>();
1149 webrtc::MockVideoDecoderFactory* decoder_factory =
1150 new testing::StrictMock<webrtc::MockVideoDecoderFactory>();
1151 WebRtcVideoEngine engine(
1152 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1153 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1154 const webrtc::SdpVideoFormat vp8_format("VP8");
1155 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1156 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1157 .WillRepeatedly(testing::Return(supported_formats));
1158
1159 // Decoder creation fails.
1160 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(testing::_))
1161 .WillOnce(testing::Return(nullptr));
1162
1163 // Create a call.
1164 webrtc::RtcEventLogNullImpl event_log;
1165 std::unique_ptr<webrtc::Call> call(
1166 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1167
1168 // Create recv channel.
1169 const int recv_ssrc = 321;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001170 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateChannel(
1171 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001172 cricket::VideoRecvParameters recv_parameters;
1173 recv_parameters.codecs.push_back(engine.codecs().front());
1174 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1175 EXPECT_TRUE(recv_channel->AddRecvStream(
1176 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1177
1178 // Remove streams previously added to free the encoder and decoder instance.
1179 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1180}
1181
eladalonf1841382017-06-12 01:16:46 -07001182TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001183 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001184 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001185 std::unique_ptr<VideoMediaChannel> channel(
1186 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001187 ASSERT_TRUE(
1188 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1189 cricket::VideoCodec codec = GetEngineCodec("VP8");
1190 cricket::VideoSendParameters parameters;
1191 parameters.codecs.push_back(codec);
1192 channel->OnReadyToSend(true);
1193 channel->SetSend(true);
1194 ASSERT_TRUE(channel->SetSendParameters(parameters));
1195
Tommi85959932018-02-07 19:26:06 +01001196 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08001197 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02001198 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001199
1200 EXPECT_EQ(cricket::CS_RUNNING,
1201 capturer.Start(capturer.GetSupportedFormats()->front()));
1202 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001203 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001204 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001205 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001206
Niels Möllerff40b142018-04-09 08:49:14 +02001207 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001208 EXPECT_TRUE(capturer.CaptureFrame());
1209 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001210 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001211
1212 options.is_screencast.emplace(true);
Niels Möllerff40b142018-04-09 08:49:14 +02001213 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001214 EXPECT_TRUE(capturer.CaptureFrame());
1215 // Change to screen content, recreate encoder. For the simulcast encoder
1216 // adapter case, this will result in two calls since InitEncode triggers a
1217 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001218 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001219 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001220 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001221
Niels Möllerff40b142018-04-09 08:49:14 +02001222 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001223 EXPECT_TRUE(capturer.CaptureFrame());
1224 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001225 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001226
1227 options.is_screencast.emplace(false);
1228 options.video_noise_reduction.emplace(false);
Niels Möllerff40b142018-04-09 08:49:14 +02001229 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001230 // Change back to regular video content, update encoder. Also change
1231 // a non |is_screencast| option just to verify it doesn't affect recreation.
1232 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001233 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001234 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001235 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001236
1237 // Remove stream previously added to free the external encoder instance.
1238 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001239 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001240}
1241
Niels Möller6557d0c2018-04-11 15:18:34 +02001242class WebRtcVideoChannelBaseTest : public testing::Test {
1243 protected:
1244 WebRtcVideoChannelBaseTest()
Jonas Oreland49ac5952018-09-26 16:04:32 +02001245 : engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001246 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001247
1248 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001249 // One testcase calls SetUp in a loop, only create call_ once.
1250 if (!call_) {
1251 call_.reset(webrtc::Call::Create(webrtc::Call::Config(&event_log_)));
1252 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001253 cricket::MediaConfig media_config;
1254 // Disabling cpu overuse detection actually disables quality scaling too; it
1255 // implies DegradationPreference kMaintainResolution. Automatic scaling
1256 // needs to be disabled, otherwise, tests which check the size of received
1257 // frames become flaky.
1258 media_config.video.enable_cpu_adaptation = false;
1259 channel_.reset(engine_.CreateChannel(call_.get(), media_config,
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001260 cricket::VideoOptions(),
1261 webrtc::CryptoOptions()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001262 channel_->OnReadyToSend(true);
1263 EXPECT_TRUE(channel_.get() != NULL);
1264 network_interface_.SetDestination(channel_.get());
Anton Sukhanov98a462c2018-10-17 13:15:42 -07001265 channel_->SetInterface(&network_interface_, /*media_transport=*/nullptr);
Niels Möller6557d0c2018-04-11 15:18:34 +02001266 cricket::VideoRecvParameters parameters;
1267 parameters.codecs = engine_.codecs();
1268 channel_->SetRecvParameters(parameters);
1269 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
1270 video_capturer_.reset(CreateFakeVideoCapturer());
1271 cricket::VideoFormat format(640, 480,
1272 cricket::VideoFormat::FpsToInterval(kFramerate),
1273 cricket::FOURCC_I420);
1274 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001275 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001276 }
1277
1278 virtual cricket::FakeVideoCapturerWithTaskQueue* CreateFakeVideoCapturer() {
1279 return new cricket::FakeVideoCapturerWithTaskQueue();
1280 }
1281
1282 // Utility method to setup an additional stream to send and receive video.
1283 // Used to test send and recv between two streams.
1284 void SetUpSecondStream() {
1285 SetUpSecondStreamWithNoRecv();
1286 // Setup recv for second stream.
1287 EXPECT_TRUE(channel_->AddRecvStream(
1288 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1289 // Make the second renderer available for use by a new stream.
1290 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1291 }
1292 // Setup an additional stream just to send video. Defer add recv stream.
1293 // This is required if you want to test unsignalled recv of video rtp packets.
1294 void SetUpSecondStreamWithNoRecv() {
1295 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001296 EXPECT_TRUE(
1297 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001298 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001299 EXPECT_FALSE(
1300 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001301 EXPECT_TRUE(channel_->AddSendStream(
1302 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1303 // We dont add recv for the second stream.
1304
1305 // Setup the receive and renderer for second stream after send.
1306 video_capturer_2_.reset(CreateFakeVideoCapturer());
1307 cricket::VideoFormat format(640, 480,
1308 cricket::VideoFormat::FpsToInterval(kFramerate),
1309 cricket::FOURCC_I420);
1310 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(format));
1311
Yves Gerey665174f2018-06-19 15:03:05 +02001312 EXPECT_TRUE(
1313 channel_->SetVideoSend(kSsrc + 2, nullptr, video_capturer_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001314 }
Yves Gerey665174f2018-06-19 15:03:05 +02001315 virtual void TearDown() { channel_.reset(); }
1316 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001317
1318 bool SetOneCodec(const cricket::VideoCodec& codec) {
1319 cricket::VideoFormat capture_format(
1320 kVideoWidth, kVideoHeight,
1321 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1322
1323 if (video_capturer_) {
1324 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(capture_format));
1325 }
1326 if (video_capturer_2_) {
1327 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(capture_format));
1328 }
1329
1330 bool sending = channel_->sending();
1331 bool success = SetSend(false);
1332 if (success) {
1333 cricket::VideoSendParameters parameters;
1334 parameters.codecs.push_back(codec);
1335 success = channel_->SetSendParameters(parameters);
1336 }
1337 if (success) {
1338 success = SetSend(sending);
1339 }
1340 return success;
1341 }
Yves Gerey665174f2018-06-19 15:03:05 +02001342 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001343 bool SendFrame() {
1344 if (video_capturer_2_) {
1345 video_capturer_2_->CaptureFrame();
1346 }
1347 return video_capturer_.get() && video_capturer_->CaptureFrame();
1348 }
1349 bool WaitAndSendFrame(int wait_ms) {
1350 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
1351 ret &= SendFrame();
1352 return ret;
1353 }
Yves Gerey665174f2018-06-19 15:03:05 +02001354 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001355 int NumRtpBytes(uint32_t ssrc) {
1356 return network_interface_.NumRtpBytes(ssrc);
1357 }
Yves Gerey665174f2018-06-19 15:03:05 +02001358 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001359 int NumRtpPackets(uint32_t ssrc) {
1360 return network_interface_.NumRtpPackets(ssrc);
1361 }
Yves Gerey665174f2018-06-19 15:03:05 +02001362 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001363 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1364 return network_interface_.GetRtpPacket(index);
1365 }
1366 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001367 webrtc::RTPHeader header;
1368 EXPECT_TRUE(ParseRtpPacket(p, &header));
1369 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001370 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001371
Niels Möller6557d0c2018-04-11 15:18:34 +02001372 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001373 webrtc::RTPHeader* header) {
1374 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1375 webrtc::RtpHeaderParser::Create());
1376 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001377 }
1378
1379 // Tests that we can send and receive frames.
1380 void SendAndReceive(const cricket::VideoCodec& codec) {
1381 EXPECT_TRUE(SetOneCodec(codec));
1382 EXPECT_TRUE(SetSend(true));
1383 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1384 EXPECT_EQ(0, renderer_.num_rendered_frames());
1385 EXPECT_TRUE(SendFrame());
1386 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1387 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1388 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1389 }
1390
1391 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001392 int duration_sec,
1393 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001394 EXPECT_TRUE(SetOneCodec(codec));
1395 EXPECT_TRUE(SetSend(true));
1396 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1397 EXPECT_EQ(0, renderer_.num_rendered_frames());
1398 for (int i = 0; i < duration_sec; ++i) {
1399 for (int frame = 1; frame <= fps; ++frame) {
1400 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1401 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1402 }
1403 }
1404 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1405 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1406 }
1407
Niels Möller6557d0c2018-04-11 15:18:34 +02001408 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1409 cricket::VideoMediaInfo info;
1410 EXPECT_TRUE(channel_->GetStats(&info));
1411 return info.senders[i];
1412 }
1413
1414 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1415 cricket::VideoMediaInfo info;
1416 EXPECT_TRUE(channel_->GetStats(&info));
1417 return info.receivers[i];
1418 }
1419
1420 // Two streams one channel tests.
1421
1422 // Tests that we can send and receive frames.
1423 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1424 SetUpSecondStream();
1425 // Test sending and receiving on first stream.
1426 SendAndReceive(codec);
1427 // Test sending and receiving on second stream.
1428 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1429 EXPECT_GT(NumRtpPackets(), 0);
1430 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1431 }
1432
1433 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1434 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001435 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001436 return engine_codec;
1437 }
1438 // This point should never be reached.
1439 ADD_FAILURE() << "Unrecognized codec name: " << name;
1440 return cricket::VideoCodec();
1441 }
1442
1443 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1444
1445 cricket::StreamParams DefaultSendStreamParams() {
1446 return cricket::StreamParams::CreateLegacy(kSsrc);
1447 }
1448
1449 webrtc::RtcEventLogNullImpl event_log_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001450 std::unique_ptr<webrtc::Call> call_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001451 WebRtcVideoEngine engine_;
1452 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_;
1453 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_2_;
1454 std::unique_ptr<WebRtcVideoChannel> channel_;
1455 cricket::FakeNetworkInterface network_interface_;
1456 cricket::FakeVideoRenderer renderer_;
1457
1458 // Used by test cases where 2 streams are run on the same channel.
1459 cricket::FakeVideoRenderer renderer2_;
1460};
1461
1462// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001463TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001464 EXPECT_FALSE(channel_->sending());
Yves Gerey665174f2018-06-19 15:03:05 +02001465 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001466 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1467 EXPECT_FALSE(channel_->sending());
1468 EXPECT_TRUE(SetSend(true));
1469 EXPECT_TRUE(channel_->sending());
1470 EXPECT_TRUE(SendFrame());
1471 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1472 EXPECT_TRUE(SetSend(false));
1473 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001474}
Niels Möller6557d0c2018-04-11 15:18:34 +02001475
1476// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001477TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001478 EXPECT_FALSE(channel_->sending());
1479 EXPECT_FALSE(SetSend(true));
1480 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001481}
Niels Möller6557d0c2018-04-11 15:18:34 +02001482
1483// Test that we properly set the send and recv buffer sizes by the time
1484// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001485TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001486 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1487 EXPECT_TRUE(SetSend(true));
1488 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001489 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001490}
1491
Niels Möller6557d0c2018-04-11 15:18:34 +02001492// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001493TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001494 const int kDurationSec = 3;
1495 const int kFps = 10;
1496 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1497
1498 cricket::VideoMediaInfo info;
1499 EXPECT_TRUE(channel_->GetStats(&info));
1500
1501 ASSERT_EQ(1U, info.senders.size());
1502 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1503 // For webrtc, bytes_sent does not include the RTP header length.
1504 EXPECT_GT(info.senders[0].bytes_sent, 0);
1505 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1506 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1507 ASSERT_TRUE(info.senders[0].codec_payload_type);
1508 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1509 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1510 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1511 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1512 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1513 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1514 EXPECT_GT(info.senders[0].framerate_input, 0);
1515 EXPECT_GT(info.senders[0].framerate_sent, 0);
1516
1517 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1518 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1519 info.send_codecs[DefaultCodec().id]);
1520
1521 ASSERT_EQ(1U, info.receivers.size());
1522 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1523 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1524 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1525 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1526 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1527 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1528 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1529 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1530 EXPECT_EQ(0, info.receivers[0].packets_lost);
1531 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1532 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1533 EXPECT_EQ(0, info.receivers[0].firs_sent);
1534 EXPECT_EQ(0, info.receivers[0].plis_sent);
1535 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1536 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1537 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1538 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1539 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1540 EXPECT_GT(info.receivers[0].framerate_output, 0);
1541
1542 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1543 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1544 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001545}
Niels Möller6557d0c2018-04-11 15:18:34 +02001546
1547// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001548TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001549 cricket::FakeVideoRenderer renderer1, renderer2;
1550 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1551 cricket::VideoSendParameters parameters;
1552 parameters.codecs.push_back(DefaultCodec());
1553 parameters.conference_mode = true;
1554 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1555 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001556 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1557 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001558 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1559 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1560 EXPECT_EQ(0, renderer1.num_rendered_frames());
1561 EXPECT_EQ(0, renderer2.num_rendered_frames());
1562 std::vector<uint32_t> ssrcs;
1563 ssrcs.push_back(1);
1564 ssrcs.push_back(2);
1565 network_interface_.SetConferenceMode(true, ssrcs);
1566 EXPECT_TRUE(SendFrame());
1567 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1568 kTimeout);
1569 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1570 kTimeout);
1571
1572 EXPECT_TRUE(channel_->SetSend(false));
1573
1574 cricket::VideoMediaInfo info;
1575 EXPECT_TRUE(channel_->GetStats(&info));
1576 ASSERT_EQ(1U, info.senders.size());
1577 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1578 // For webrtc, bytes_sent does not include the RTP header length.
1579 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1580 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1581 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1582 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1583
1584 ASSERT_EQ(2U, info.receivers.size());
1585 for (size_t i = 0; i < info.receivers.size(); ++i) {
1586 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1587 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1588 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001589 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001590 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1591 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1592 }
srtee0c2eea2017-12-15 17:44:33 +01001593}
Niels Möller6557d0c2018-04-11 15:18:34 +02001594
1595// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001596TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001597 // Normal setup; note that we set the SSRC explicitly to ensure that
1598 // it will come first in the senders map.
1599 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1600 cricket::VideoSendParameters parameters;
1601 parameters.codecs.push_back(DefaultCodec());
1602 parameters.conference_mode = true;
1603 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001604 EXPECT_TRUE(
1605 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001606 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1607 EXPECT_TRUE(SetSend(true));
1608 EXPECT_TRUE(SendFrame());
1609 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1610 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1611
1612 // Add an additional capturer, and hook up a renderer to receive it.
1613 cricket::FakeVideoRenderer renderer2;
1614 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1615 CreateFakeVideoCapturer());
1616 const int kTestWidth = 160;
1617 const int kTestHeight = 120;
1618 cricket::VideoFormat format(kTestWidth, kTestHeight,
1619 cricket::VideoFormat::FpsToInterval(5),
1620 cricket::FOURCC_I420);
1621 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001622 EXPECT_TRUE(
1623 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001624 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, capturer.get()));
Yves Gerey665174f2018-06-19 15:03:05 +02001625 EXPECT_TRUE(
1626 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001627 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
1628 EXPECT_TRUE(capturer->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001629 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1630 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001631
1632 // Get stats, and make sure they are correct for two senders. We wait until
1633 // the number of expected packets have been sent to avoid races where we
1634 // check stats before it has been updated.
1635 cricket::VideoMediaInfo info;
1636 for (uint32_t i = 0; i < kTimeout; ++i) {
1637 rtc::Thread::Current()->ProcessMessages(1);
1638 EXPECT_TRUE(channel_->GetStats(&info));
1639 ASSERT_EQ(2U, info.senders.size());
1640 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1641 NumRtpPackets()) {
1642 // Stats have been updated for both sent frames, expectations can be
1643 // checked now.
1644 break;
1645 }
1646 }
1647 EXPECT_EQ(NumRtpPackets(),
1648 info.senders[0].packets_sent + info.senders[1].packets_sent)
1649 << "Timed out while waiting for packet counts for all sent packets.";
1650 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1651 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1652 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1653 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1654 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1655 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1656 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1657 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1658 // The capturer must be unregistered here as it runs out of it's scope next.
1659 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001660}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001661
Niels Möller6557d0c2018-04-11 15:18:34 +02001662// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001663TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001664 cricket::VideoSendParameters parameters;
1665 parameters.codecs.push_back(DefaultCodec());
1666 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1667 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1668 parameters.max_bandwidth_bps = 128 * 1024;
1669 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001670}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001671
Niels Möller6557d0c2018-04-11 15:18:34 +02001672// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001673TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001674 EXPECT_TRUE(SetDefaultCodec());
1675 EXPECT_TRUE(SetSend(true));
1676 EXPECT_TRUE(SendFrame());
1677 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001678 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001679 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001680 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1681 EXPECT_EQ(kSsrc, header.ssrc);
1682
Niels Möller6557d0c2018-04-11 15:18:34 +02001683 // Packets are being paced out, so these can mismatch between the first and
1684 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001685 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1686 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001687 EXPECT_EQ(1, NumSentSsrcs());
1688 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1689 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001690}
Niels Möller6557d0c2018-04-11 15:18:34 +02001691
1692// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001693TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001694 // Remove stream added in Setup.
1695 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1696 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001697 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001698 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
1699 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001700 EXPECT_TRUE(SetSend(true));
1701 EXPECT_TRUE(WaitAndSendFrame(0));
1702 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001703 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001704 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001705 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1706 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001707 // Packets are being paced out, so these can mismatch between the first and
1708 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001709 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1710 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001711 EXPECT_EQ(1, NumSentSsrcs());
1712 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1713 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001714}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001715
Niels Möller6557d0c2018-04-11 15:18:34 +02001716// Test that we can set the default video renderer before and after
1717// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001718TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001719 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1720 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001721
1722 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1723 rtc::SetBE32(packet1.data() + 8, kSsrc);
1724 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1725 EXPECT_TRUE(SetDefaultCodec());
1726 EXPECT_TRUE(SetSend(true));
1727 EXPECT_EQ(0, renderer_.num_rendered_frames());
1728 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
1729 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1730 EXPECT_TRUE(SendFrame());
1731 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001732}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001733
Niels Möller6557d0c2018-04-11 15:18:34 +02001734// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001735TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001736 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1737 EXPECT_TRUE(SetSend(true));
1738 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1739 EXPECT_TRUE(SendFrame());
1740 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1741 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001742 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001743 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001744 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1745 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001746 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1747 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001748
1749 // Remove the send stream that was added during Setup.
1750 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1751 int rtp_packets = NumRtpPackets();
1752
Niels Möller6557d0c2018-04-11 15:18:34 +02001753 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001754 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
1755 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001756 EXPECT_EQ(rtp_packets, NumRtpPackets());
1757 // Wait 30ms to guarantee the engine does not drop the frame.
1758 EXPECT_TRUE(WaitAndSendFrame(30));
1759 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1760
1761 last_packet = NumRtpPackets() - 1;
1762 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001763 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1764 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001765}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001766
Niels Möller6557d0c2018-04-11 15:18:34 +02001767// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001768TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001769 cricket::FakeVideoRenderer renderer1, renderer2;
1770 EXPECT_TRUE(SetDefaultCodec());
1771 cricket::VideoSendParameters parameters;
1772 parameters.codecs.push_back(DefaultCodec());
1773 parameters.conference_mode = true;
1774 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1775 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001776 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1777 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001778 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1779 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1780 EXPECT_EQ(0, renderer1.num_rendered_frames());
1781 EXPECT_EQ(0, renderer2.num_rendered_frames());
1782 std::vector<uint32_t> ssrcs;
1783 ssrcs.push_back(1);
1784 ssrcs.push_back(2);
1785 network_interface_.SetConferenceMode(true, ssrcs);
1786 EXPECT_TRUE(SendFrame());
1787 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1788 kTimeout);
1789 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1790 kTimeout);
1791
1792 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1793 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1794 EXPECT_EQ(kVideoWidth, renderer1.width());
1795 EXPECT_EQ(kVideoHeight, renderer1.height());
1796 EXPECT_EQ(kVideoWidth, renderer2.width());
1797 EXPECT_EQ(kVideoHeight, renderer2.height());
1798 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1799 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001800}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001801
Niels Möller6557d0c2018-04-11 15:18:34 +02001802// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001803TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001804 using cricket::VideoCodec;
1805 using cricket::VideoOptions;
1806 using cricket::VideoFormat;
1807 using cricket::FOURCC_I420;
1808
1809 VideoCodec codec = DefaultCodec();
1810 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1811 EXPECT_TRUE(SetOneCodec(codec));
1812 EXPECT_TRUE(SetSend(true));
1813 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1814 EXPECT_EQ(0, renderer_.num_rendered_frames());
1815 EXPECT_TRUE(SendFrame());
1816 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1817 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1818 CreateFakeVideoCapturer());
1819
1820 // TODO(nisse): This testcase fails if we don't configure
1821 // screencast. It's unclear why, I see nothing obvious in this
1822 // test which is related to screencast logic.
1823 VideoOptions video_options;
1824 video_options.is_screencast = true;
1825 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1826
1827 VideoFormat format(480, 360, VideoFormat::FpsToInterval(30), FOURCC_I420);
1828 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
1829 // All capturers start generating frames with the same timestamp. ViE does
1830 // not allow the same timestamp to be used. Capture one frame before
1831 // associating the capturer with the channel.
1832 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1833
1834 int captured_frames = 1;
1835 for (int iterations = 0; iterations < 2; ++iterations) {
1836 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, capturer.get()));
1837 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
1838 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1839 ++captured_frames;
1840 // Wait until frame of right size is captured.
1841 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001842 format.width == renderer_.width() &&
1843 format.height == renderer_.height() &&
1844 !renderer_.black_frame(),
1845 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001846 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1847 EXPECT_EQ(format.width, renderer_.width());
1848 EXPECT_EQ(format.height, renderer_.height());
1849 captured_frames = renderer_.num_rendered_frames() + 1;
1850 EXPECT_FALSE(renderer_.black_frame());
1851 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1852 // Make sure a black frame is generated within the specified timeout.
1853 // The black frame should be the resolution of the previous frame to
1854 // prevent expensive encoder reconfigurations.
1855 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001856 format.width == renderer_.width() &&
1857 format.height == renderer_.height() &&
1858 renderer_.black_frame(),
1859 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001860 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1861 EXPECT_EQ(format.width, renderer_.width());
1862 EXPECT_EQ(format.height, renderer_.height());
1863 EXPECT_TRUE(renderer_.black_frame());
1864
1865 // The black frame has the same timestamp as the next frame since it's
1866 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1867 // not render a frame with the same timestamp so capture another frame
1868 // with the frame capturer to increment the next frame's timestamp.
1869 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1870 }
srtee0c2eea2017-12-15 17:44:33 +01001871}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001872
Niels Möller6557d0c2018-04-11 15:18:34 +02001873// Tests that if SetVideoSend is called with a NULL capturer after the
1874// capturer was already removed, the application doesn't crash (and no black
1875// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001876TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001877 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1878 EXPECT_TRUE(SetSend(true));
1879 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1880 EXPECT_EQ(0, renderer_.num_rendered_frames());
1881 EXPECT_TRUE(SendFrame());
1882 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1883 // Wait for one frame so they don't get dropped because we send frames too
1884 // tightly.
1885 rtc::Thread::Current()->ProcessMessages(30);
1886 // Remove the capturer.
1887 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1888
1889 // No capturer was added, so this SetVideoSend shouldn't do anything.
1890 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1891 rtc::Thread::Current()->ProcessMessages(300);
1892 // Verify no more frames were sent.
1893 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001894}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001895
Niels Möller6557d0c2018-04-11 15:18:34 +02001896// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001897TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001898 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1899 // interval time to avoid that.
1900 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1901 // interval time to avoid that.
1902 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001903 EXPECT_TRUE(
1904 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001905 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1906 cricket::VideoFormat capture_format(
1907 kVideoWidth, kVideoHeight,
1908 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1909 // Set up additional stream 1.
1910 cricket::FakeVideoRenderer renderer1;
1911 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001912 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001913 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001914 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001915 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer1(
1916 CreateFakeVideoCapturer());
1917 EXPECT_EQ(cricket::CS_RUNNING, capturer1->Start(capture_format));
1918 // Set up additional stream 2.
1919 cricket::FakeVideoRenderer renderer2;
1920 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001921 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001922 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001923 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001924 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer2(
1925 CreateFakeVideoCapturer());
1926 EXPECT_EQ(cricket::CS_RUNNING, capturer2->Start(capture_format));
1927 // State for all the streams.
1928 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1929 // A limitation in the lmi implementation requires that SetVideoSend() is
1930 // called after SetOneCodec().
1931 // TODO(hellner): this seems like an unnecessary constraint, fix it.
1932 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, capturer1.get()));
1933 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, capturer2.get()));
1934 EXPECT_TRUE(SetSend(true));
1935 // Test capturer associated with engine.
1936 const int kTestWidth = 160;
1937 const int kTestHeight = 120;
1938 EXPECT_TRUE(capturer1->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001939 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
1940 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001941 // Capture a frame with additional capturer2, frames should be received
1942 EXPECT_TRUE(capturer2->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001943 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1944 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001945 // Successfully remove the capturer.
1946 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1947 // The capturers must be unregistered here as it runs out of it's scope
1948 // next.
1949 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
1950 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01001951}
Niels Möller6557d0c2018-04-11 15:18:34 +02001952
1953// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01001954TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001955 // Remove the send stream that was added during Setup.
1956 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1957
1958 cricket::StreamParams empty;
1959 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02001960 EXPECT_TRUE(
1961 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01001962}
Niels Möller6557d0c2018-04-11 15:18:34 +02001963
1964// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01001965TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001966 // Remove stream added in Setup. I.e. remove stream corresponding to default
1967 // channel.
1968 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02001969 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02001970 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
1971 EXPECT_TRUE(channel_->AddSendStream(
1972 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
1973 }
1974 // Delete one of the non default channel streams, let the destructor delete
1975 // the remaining ones.
1976 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
1977 // Stream should already be deleted.
1978 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01001979}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00001980
eladalonf1841382017-06-12 01:16:46 -07001981TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08001982 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001983}
1984
eladalonf1841382017-06-12 01:16:46 -07001985TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08001986 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001987}
1988
eladalonf1841382017-06-12 01:16:46 -07001989TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08001990 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001991}
1992
eladalonf1841382017-06-12 01:16:46 -07001993TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02001994 // Set a high bitrate to not be downscaled by VP8 due to low initial start
1995 // bitrates. This currently happens at <250k, and two streams sharing 300k
1996 // initially will use QVGA instead of VGA.
1997 // TODO(pbos): Set up the quality scaler so that both senders reliably start
1998 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08001999 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002000 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002001 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002002}
2003
eladalonf1841382017-06-12 01:16:46 -07002004class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002005 public:
eladalonf1841382017-06-12 01:16:46 -07002006 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2007 explicit WebRtcVideoChannelTest(const char* field_trials)
2008 : WebRtcVideoEngineTest(field_trials), last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002009 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002010 encoder_factory_->AddSupportedVideoCodecType("VP8");
2011 encoder_factory_->AddSupportedVideoCodecType("VP9");
2012#if defined(WEBRTC_USE_H264)
2013 encoder_factory_->AddSupportedVideoCodecType("H264");
2014#endif
2015
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002016 fake_call_.reset(new FakeCall());
kthelgason2bc68642017-02-07 07:02:22 -08002017 channel_.reset(engine_.CreateChannel(fake_call_.get(), GetMediaConfig(),
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002018 VideoOptions(),
2019 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002020 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002021 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002022 send_parameters_.codecs = engine_.codecs();
2023 recv_parameters_.codecs = engine_.codecs();
2024 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002025 }
2026
2027 protected:
2028 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002029 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002030 }
2031
2032 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002033 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002034 EXPECT_TRUE(channel_->AddSendStream(sp));
2035 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002036 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002037 EXPECT_EQ(num_streams + 1, streams.size());
2038 return streams[streams.size() - 1];
2039 }
2040
2041 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002042 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002043 }
2044
2045 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002046 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002047 }
2048
2049 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002050 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002051 EXPECT_TRUE(channel_->AddRecvStream(sp));
2052 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002053 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002054 EXPECT_EQ(num_streams + 1, streams.size());
2055 return streams[streams.size() - 1];
2056 }
2057
pbos@webrtc.org00873182014-11-25 14:03:34 +00002058 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2059 int expected_min_bitrate_bps,
2060 const char* start_bitrate_kbps,
2061 int expected_start_bitrate_bps,
2062 const char* max_bitrate_kbps,
2063 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002064 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2065 expected_start_bitrate_bps,
2066 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002067 auto& codecs = send_parameters_.codecs;
2068 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002069 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002070 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2071 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2072 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002073 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002074 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002075
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002076 void ExpectSetBitrateParameters(int min_bitrate_bps,
2077 int start_bitrate_bps,
2078 int max_bitrate_bps) {
2079 EXPECT_CALL(
2080 *fake_call_->GetMockTransportControllerSend(),
2081 SetSdpBitrateParameters(AllOf(
2082 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2083 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2084 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2085 }
2086
2087 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2088 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2089 SetSdpBitrateParameters(Field(
2090 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002091 }
2092
isheriff6f8d6862016-05-26 11:24:55 -07002093 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002094 // Enable extension.
2095 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002096 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002097 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002098 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002099 FakeVideoSendStream* send_stream =
2100 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2101
2102 // Verify the send extension id.
2103 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2104 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002105 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002106 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002107 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002108 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2109 // receivers.
2110 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2111 ->GetConfig()
2112 .rtp.extensions.empty());
2113
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002114 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002115 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002116 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2117 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002118 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2119
2120 // Verify that adding receive RTP header extensions adds them for existing
2121 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002122 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002123 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002124 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2125 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002126 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002127 }
2128
isheriff6f8d6862016-05-26 11:24:55 -07002129 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002130 // Enable extension.
2131 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002132 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002133 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002134 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002135
2136 FakeVideoReceiveStream* recv_stream =
2137 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2138
2139 // Verify the recv extension id.
2140 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2141 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002142 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002143 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002144 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002145
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002146 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2147 // senders.
2148 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2149 ->GetConfig()
2150 .rtp.extensions.empty());
2151
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002152 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002153 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002154 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2155 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002156 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2157
2158 // Verify that adding receive RTP header extensions adds them for existing
2159 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002160 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002161 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002162 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2163 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002164 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002165 }
2166
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002167 void TestExtensionFilter(const std::vector<std::string>& extensions,
2168 const std::string& expected_extension) {
2169 cricket::VideoSendParameters parameters = send_parameters_;
2170 int expected_id = -1;
2171 int id = 1;
2172 for (const std::string& extension : extensions) {
2173 if (extension == expected_extension)
2174 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002175 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002176 }
2177 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2178 FakeVideoSendStream* send_stream =
2179 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2180
2181 // Verify that only one of them has been set, and that it is the one with
2182 // highest priority (transport sequence number).
2183 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2184 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2185 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002186 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002187 }
2188
asapersson3c81a1a2017-06-14 05:52:21 -07002189 void TestDegradationPreference(bool resolution_scaling_enabled,
2190 bool fps_scaling_enabled);
2191
Erik Språngefbde372015-04-29 16:21:28 +02002192 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002193 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002194 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2195 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002196
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002197 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002198 uint32_t ssrc,
Tommi85959932018-02-07 19:26:06 +01002199 FakeVideoCapturerWithTaskQueue* capturer,
nisse0db023a2016-03-01 04:29:59 -08002200 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002201 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002202 options.video_noise_reduction = enabled;
Niels Möllerff40b142018-04-09 08:49:14 +02002203 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, capturer));
nisse0db023a2016-03-01 04:29:59 -08002204 // Options only take effect on the next frame.
2205 EXPECT_TRUE(capturer->CaptureFrame());
2206
Erik Språng143cec12015-04-28 10:01:41 +02002207 return fake_call_->GetVideoSendStreams().back();
2208 }
2209
Peter Boström2feafdb2015-09-09 14:32:14 +02002210 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2211 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002212 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002213 std::vector<uint32_t> ssrcs;
2214 std::vector<uint32_t> rtx_ssrcs;
2215 uint32_t num_streams = enabled ? 3 : 1;
2216 for (uint32_t i = 0; i < num_streams; ++i) {
2217 uint32_t ssrc = last_ssrc_ + i;
2218 ssrcs.push_back(ssrc);
2219 if (with_rtx) {
2220 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2221 }
Erik Språng143cec12015-04-28 10:01:41 +02002222 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002223 if (with_rtx) {
2224 return AddSendStream(
2225 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2226 }
2227 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002228 }
2229
perkjfa10b552016-10-02 23:45:26 -07002230 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002231 std::vector<FakeVideoSendStream*> streams =
2232 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002233 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002234 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002235 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002236 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002237 }
2238
perkjfa10b552016-10-02 23:45:26 -07002239 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002240 int stream_max,
2241 int expected_encoder_bitrate) {
2242 VideoSendParameters limited_send_params = send_parameters_;
2243 limited_send_params.max_bandwidth_bps = global_max;
2244 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002245 webrtc::RtpParameters parameters =
2246 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002247 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002248 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002249 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002250 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002251 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002252 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002253 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002254 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002255 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002256 }
2257
Åsa Persson55659812018-06-18 17:51:32 +02002258 // Values from kSimulcastConfigs in simulcast.cc.
2259 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2260 std::vector<webrtc::VideoStream> layers(3);
2261 layers[0].min_bitrate_bps = 30000;
2262 layers[0].target_bitrate_bps = 150000;
2263 layers[0].max_bitrate_bps = 200000;
2264 layers[1].min_bitrate_bps = 150000;
2265 layers[1].target_bitrate_bps = 500000;
2266 layers[1].max_bitrate_bps = 700000;
2267 layers[2].min_bitrate_bps = 600000;
2268 layers[2].target_bitrate_bps = 2500000;
2269 layers[2].max_bitrate_bps = 2500000;
2270 return layers;
2271 }
2272
kwiberg686a8ef2016-02-26 03:00:35 -08002273 std::unique_ptr<FakeCall> fake_call_;
2274 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002275 cricket::VideoSendParameters send_parameters_;
2276 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002277 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002278};
2279
eladalonf1841382017-06-12 01:16:46 -07002280TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002281 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002282 const std::string kSyncLabel = "AvSyncLabel";
2283
2284 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002285 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002286 EXPECT_TRUE(channel_->AddRecvStream(sp));
2287
Mirko Bonadeif859e552018-05-30 15:31:29 +02002288 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002289 EXPECT_EQ(kSyncLabel,
2290 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2291 << "SyncGroup should be set based on sync_label";
2292}
2293
eladalonf1841382017-06-12 01:16:46 -07002294TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002295 cricket::VideoSendParameters parameters;
2296 parameters.codecs = engine_.codecs();
2297 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002298 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002299 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002300 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002301
2302 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002303 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2304 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002305 FakeVideoSendStream* send_stream = AddSendStream(
2306 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2307
2308 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2309 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2310 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2311
2312 // Receiver side.
2313 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2314 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002315 EXPECT_FALSE(
2316 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002317 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002318 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002319 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002320 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002321 << "RTX should be mapped for the RED payload type";
2322
brandtr14742122017-01-27 04:53:07 -08002323 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002324}
2325
eladalonf1841382017-06-12 01:16:46 -07002326TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002327 // Setup one channel with an associated RTX stream.
2328 cricket::StreamParams params =
2329 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2330 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2331 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002332 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002333
2334 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2335 << "RTX should be mapped for all decoders/payload types.";
2336 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002337 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002338 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002339}
2340
eladalonf1841382017-06-12 01:16:46 -07002341TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002342 // Setup one channel without an associated RTX stream.
2343 cricket::StreamParams params =
2344 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2345 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002346 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002347}
2348
eladalonf1841382017-06-12 01:16:46 -07002349TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002350 FakeVideoSendStream* send_stream =
2351 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2352 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2353
2354 FakeVideoReceiveStream* recv_stream =
2355 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2356 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002357}
2358
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002359// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002360TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002361 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002362}
isheriff6f8d6862016-05-26 11:24:55 -07002363
eladalonf1841382017-06-12 01:16:46 -07002364TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002365 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002366}
2367
2368// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002369TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002370 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002371}
isheriff6f8d6862016-05-26 11:24:55 -07002372
eladalonf1841382017-06-12 01:16:46 -07002373TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002374 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002375}
2376
eladalonf1841382017-06-12 01:16:46 -07002377TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002378 // Enable three redundant extensions.
2379 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002380 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2381 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2382 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2383 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002384}
2385
eladalonf1841382017-06-12 01:16:46 -07002386TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002387 // Enable two redundant extensions.
2388 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002389 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2390 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2391 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002392}
2393
stefanc1aeaf02015-10-15 07:26:07 -07002394// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002395TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002396 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002397}
eladalonf1841382017-06-12 01:16:46 -07002398TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002399 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002400}
2401
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002402// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002403TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002404 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002405}
eladalonf1841382017-06-12 01:16:46 -07002406TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002407 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002408}
2409
eladalonf1841382017-06-12 01:16:46 -07002410TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002411 const int kAbsSendTimeId = 1;
2412 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002413 send_parameters_.extensions.push_back(
2414 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2415 send_parameters_.extensions.push_back(
2416 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002417
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002418 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002419 FakeVideoSendStream* send_stream =
2420 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2421
2422 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002423 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002424
2425 // Setting the same extensions (even if in different order) shouldn't
2426 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002427 std::reverse(send_parameters_.extensions.begin(),
2428 send_parameters_.extensions.end());
2429 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002430
2431 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2432
2433 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002434 send_parameters_.extensions.resize(1);
2435 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002436
2437 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2438}
2439
eladalonf1841382017-06-12 01:16:46 -07002440TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002441 const int kTOffsetId = 1;
2442 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002443 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002444 recv_parameters_.extensions.push_back(
2445 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2446 recv_parameters_.extensions.push_back(
2447 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2448 recv_parameters_.extensions.push_back(
2449 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002450
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002451 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002452 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002453 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2454
2455 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002456 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002457
2458 // Setting the same extensions (even if in different order) shouldn't
2459 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002460 std::reverse(recv_parameters_.extensions.begin(),
2461 recv_parameters_.extensions.end());
2462 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002463
2464 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2465
2466 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002467 recv_parameters_.extensions.resize(1);
2468 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002469
2470 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2471}
2472
eladalonf1841382017-06-12 01:16:46 -07002473TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002474 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002475 const int kUnsupportedId = 1;
2476 const int kTOffsetId = 2;
2477
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002478 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002479 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002480 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002481 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002482 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002483 FakeVideoSendStream* send_stream =
2484 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2485
2486 // Only timestamp offset extension is set to send stream,
2487 // unsupported rtp extension is ignored.
2488 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002489 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2490 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002491}
2492
eladalonf1841382017-06-12 01:16:46 -07002493TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002494 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002495 const int kUnsupportedId = 1;
2496 const int kTOffsetId = 2;
2497
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002498 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002499 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002500 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002501 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002502 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002503 FakeVideoReceiveStream* recv_stream =
2504 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2505
2506 // Only timestamp offset extension is set to receive stream,
2507 // unsupported rtp extension is ignored.
2508 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002509 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2510 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002511}
2512
eladalonf1841382017-06-12 01:16:46 -07002513TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002514 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002515 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002516 send_parameters_.extensions.push_back(
2517 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002518 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002519 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2520 }
2521}
2522
eladalonf1841382017-06-12 01:16:46 -07002523TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002524 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002525 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002526 recv_parameters_.extensions.push_back(
2527 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002528 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002529 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2530 }
2531}
2532
eladalonf1841382017-06-12 01:16:46 -07002533TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002534 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002535 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002536 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002537 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002538 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002539 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002540
2541 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002542 send_parameters_.extensions.clear();
2543 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002544 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002545 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2546 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002547}
2548
eladalonf1841382017-06-12 01:16:46 -07002549TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002550 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002551 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002552 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002553 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002554 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002555 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002556
2557 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002558 recv_parameters_.extensions.clear();
2559 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002560 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002561 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2562 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002563}
2564
eladalonf1841382017-06-12 01:16:46 -07002565TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002566 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002567 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002568}
2569
eladalonf1841382017-06-12 01:16:46 -07002570TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002571 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002572 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002573}
2574
eladalonf1841382017-06-12 01:16:46 -07002575TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002576 FakeVideoReceiveStream* stream = AddRecvStream();
2577 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002578}
2579
eladalonf1841382017-06-12 01:16:46 -07002580TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002581 FakeVideoReceiveStream* stream = AddRecvStream();
2582 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2583}
2584
eladalonf1841382017-06-12 01:16:46 -07002585TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002586 FakeVideoReceiveStream* stream = AddRecvStream();
2587 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2588
Peter Boström126c03e2015-05-11 12:48:12 +02002589 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002590 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002591 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002592 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2593 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002594 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002595 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2596
2597 // Verify that REMB is turned on when setting default codecs since the
2598 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002599 parameters.codecs = engine_.codecs();
2600 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002601 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002602 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002603}
2604
eladalonf1841382017-06-12 01:16:46 -07002605TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002606 FakeVideoReceiveStream* stream = AddRecvStream();
2607 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2608
2609 // Verify that transport cc feedback is turned off when send(!) codecs without
2610 // transport cc feedback are set.
2611 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002612 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002613 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2614 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2615 stream = fake_call_->GetVideoReceiveStreams()[0];
2616 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2617
2618 // Verify that transport cc feedback is turned on when setting default codecs
2619 // since the default codecs have transport cc feedback enabled.
2620 parameters.codecs = engine_.codecs();
2621 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2622 stream = fake_call_->GetVideoReceiveStreams()[0];
2623 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2624}
2625
eladalonf1841382017-06-12 01:16:46 -07002626TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002627 AssignDefaultCodec();
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002628 VerifyCodecHasDefaultFeedbackParams(default_codec_);
2629
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002630 cricket::VideoSendParameters parameters;
2631 parameters.codecs = engine_.codecs();
2632 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002633 EXPECT_TRUE(channel_->SetSend(true));
2634
2635 // Send side.
2636 FakeVideoSendStream* send_stream =
2637 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2638 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2639
2640 // Receiver side.
2641 FakeVideoReceiveStream* recv_stream =
2642 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2643 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2644
2645 // Nack history size should match between sender and receiver.
2646 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2647 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002648}
2649
eladalonf1841382017-06-12 01:16:46 -07002650TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002651 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002652 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002653
2654 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2655 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2656
2657 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002658 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002659 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002660 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2661 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002662 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2663 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2664 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002665 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2666
Peter Boström67c9df72015-05-11 14:34:58 +02002667 // Verify that NACK is turned on when setting default codecs since the
2668 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002669 parameters.codecs = engine_.codecs();
2670 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002671 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2672 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2673 send_stream = fake_call_->GetVideoSendStreams()[0];
2674 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002675}
2676
Peter Boströme7ba0862016-03-12 00:02:28 +01002677// This test verifies that new frame sizes reconfigures encoders even though not
2678// (yet) sending. The purpose of this is to permit encoding as quickly as
2679// possible once we start sending. Likely the frames being input are from the
2680// same source that will be sent later, which just means that we're ready
2681// earlier.
eladalonf1841382017-06-12 01:16:46 -07002682TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002683 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002684 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002685 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2686 channel_->SetSend(false);
2687
2688 FakeVideoSendStream* stream = AddSendStream();
2689
perkjfa10b552016-10-02 23:45:26 -07002690 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002691 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002692 EXPECT_EQ(0u, streams[0].width);
2693 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002694
Tommi85959932018-02-07 19:26:06 +01002695 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002696 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj26752742016-10-24 01:21:16 -07002697 VideoFormat capture_format = capturer.GetSupportedFormats()->front();
2698 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
Peter Boströme7ba0862016-03-12 00:02:28 +01002699 EXPECT_TRUE(capturer.CaptureFrame());
2700
2701 // Frame entered, should be reconfigured to new dimensions.
2702 streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002703 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.width), streams[0].width);
2704 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.height),
2705 streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002706
Niels Möllerff40b142018-04-09 08:49:14 +02002707 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002708}
2709
eladalonf1841382017-06-12 01:16:46 -07002710TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002711 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002712 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002713 cricket::VideoSendParameters parameters;
2714 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002715 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002716 AddSendStream();
2717
Tommi85959932018-02-07 19:26:06 +01002718 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07002719 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002720 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Yves Gerey665174f2018-06-19 15:03:05 +02002721 EXPECT_TRUE(
2722 channel_->SetVideoSend(last_ssrc_, &min_bitrate_options, &capturer));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002723 cricket::VideoFormat capture_format_hd =
2724 capturer.GetSupportedFormats()->front();
2725 EXPECT_EQ(1280, capture_format_hd.width);
2726 EXPECT_EQ(720, capture_format_hd.height);
2727 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2728
2729 EXPECT_TRUE(channel_->SetSend(true));
2730
2731 EXPECT_TRUE(capturer.CaptureFrame());
2732 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2733 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2734
2735 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2736
2737 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002738 webrtc::VideoEncoderConfig encoder_config =
2739 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002740 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002741 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002742 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002743 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2744 streams.front().width);
2745 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2746 streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002747 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2748 << "Non-screenshare shouldn't use min-transmit bitrate.";
2749
Niels Möllerff40b142018-04-09 08:49:14 +02002750 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002751 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002752 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002753 screencast_options.is_screencast = true;
deadbeef5a4a75a2016-06-02 16:23:38 -07002754 EXPECT_TRUE(
Niels Möllerff40b142018-04-09 08:49:14 +02002755 channel_->SetVideoSend(last_ssrc_, &screencast_options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08002756 EXPECT_TRUE(capturer.CaptureFrame());
sprangf24a0642017-02-28 13:23:26 -08002757 // Send stream recreated after option change.
2758 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2759 send_stream = fake_call_->GetVideoSendStreams().front();
2760 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002761
2762 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002763 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002764 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002765 encoder_config.content_type);
2766 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2767 encoder_config.min_transmit_bitrate_bps);
2768
perkjfa10b552016-10-02 23:45:26 -07002769 streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002770 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2771 streams.front().width);
2772 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2773 streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002774 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002775 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002776}
2777
eladalonf1841382017-06-12 01:16:46 -07002778TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002779 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002780 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002781 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002782 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002783
2784 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002785 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002786 options.is_screencast = true;
Tommi85959932018-02-07 19:26:06 +01002787 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002788 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002789 cricket::VideoFormat capture_format_hd =
2790 capturer.GetSupportedFormats()->front();
2791 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2792
2793 EXPECT_TRUE(channel_->SetSend(true));
2794
2795 EXPECT_TRUE(capturer.CaptureFrame());
2796 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2797 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2798
perkj26091b12016-09-01 01:17:40 -07002799 webrtc::VideoEncoderConfig encoder_config =
2800 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002801
2802 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002803 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002804 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002805 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002806
2807 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2808 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002809 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002810 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002811 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002812
Niels Möllerff40b142018-04-09 08:49:14 +02002813 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002814}
2815
eladalonf1841382017-06-12 01:16:46 -07002816TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002817 FakeVideoSendStream* stream = AddSendStream();
2818 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2819}
2820
eladalonf1841382017-06-12 01:16:46 -07002821TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002822 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002823 media_config.video.suspend_below_min_bitrate = true;
2824
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002825 channel_.reset(engine_.CreateChannel(
2826 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002827 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002828
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002829 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002830
2831 FakeVideoSendStream* stream = AddSendStream();
2832 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2833
nisse0db023a2016-03-01 04:29:59 -08002834 media_config.video.suspend_below_min_bitrate = false;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002835 channel_.reset(engine_.CreateChannel(
2836 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002837 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002838
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002839 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002840
nisse0db023a2016-03-01 04:29:59 -08002841 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002842 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2843}
2844
eladalonf1841382017-06-12 01:16:46 -07002845TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002846 FakeVideoSendStream* stream = AddSendStream();
2847 webrtc::VideoCodecVP8 vp8_settings;
2848 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2849 EXPECT_TRUE(vp8_settings.denoisingOn);
2850}
2851
eladalonf1841382017-06-12 01:16:46 -07002852TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002853 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002854 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002855 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002856
Peter Boström2feafdb2015-09-09 14:32:14 +02002857 // Single-stream settings should apply with RTX as well (verifies that we
2858 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2859 // both RTX and regular SSRCs).
2860 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002861
Tommi85959932018-02-07 19:26:06 +01002862 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002863 EXPECT_EQ(cricket::CS_RUNNING,
2864 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002865 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002866 channel_->SetSend(true);
2867
2868 EXPECT_TRUE(capturer.CaptureFrame());
2869
pbos4cba4eb2015-10-26 11:18:18 -07002870 webrtc::VideoCodecVP8 vp8_settings;
2871 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2872 EXPECT_TRUE(vp8_settings.denoisingOn)
2873 << "VP8 denoising should be on by default.";
2874
nisse05103312016-03-16 02:22:50 -07002875 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002876
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002877 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2878 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002879 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2880 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002881
nisse05103312016-03-16 02:22:50 -07002882 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002883
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002884 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2885 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002886 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2887 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2888
Niels Möllerff40b142018-04-09 08:49:14 +02002889 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002890 stream = SetUpSimulcast(true, false);
Niels Möllerff40b142018-04-09 08:49:14 +02002891 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002892 channel_->SetSend(true);
2893 EXPECT_TRUE(capturer.CaptureFrame());
2894
Mirko Bonadeif859e552018-05-30 15:31:29 +02002895 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002896 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2897 // Autmatic resize off when using simulcast.
2898 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2899 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2900
2901 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002902 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002903 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002904 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
Niels Möller60653ba2016-03-02 11:41:36 +01002905
nisse05103312016-03-16 02:22:50 -07002906 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002907
Mirko Bonadeif859e552018-05-30 15:31:29 +02002908 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002909 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2910 EXPECT_FALSE(vp8_settings.denoisingOn);
2911 // Resizing and frame dropping always off for screen sharing.
2912 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2913 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2914
nisse05103312016-03-16 02:22:50 -07002915 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02002916
2917 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2918 EXPECT_FALSE(vp8_settings.denoisingOn);
2919 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2920 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2921
Niels Möllerff40b142018-04-09 08:49:14 +02002922 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02002923}
2924
deadbeef119760a2016-04-04 11:43:27 -07002925// Test that setting the same options doesn't result in the encoder being
2926// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07002927TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07002928 VideoOptions options;
Tommi85959932018-02-07 19:26:06 +01002929 FakeVideoCapturerWithTaskQueue capturer;
deadbeef119760a2016-04-04 11:43:27 -07002930
perkjfa10b552016-10-02 23:45:26 -07002931 AddSendStream();
deadbeef119760a2016-04-04 11:43:27 -07002932 EXPECT_EQ(cricket::CS_RUNNING,
2933 capturer.Start(capturer.GetSupportedFormats()->front()));
perkjfa10b552016-10-02 23:45:26 -07002934 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002935 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07002936 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2937 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2938
Niels Möllerff40b142018-04-09 08:49:14 +02002939 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
2940 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002941 EXPECT_TRUE(capturer.CaptureFrame());
perkjfa10b552016-10-02 23:45:26 -07002942 // Expect 1 reconfigurations at this point from the initial configuration.
2943 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07002944
2945 // Set the options one more time and expect no additional reconfigurations.
Niels Möllerff40b142018-04-09 08:49:14 +02002946 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkjfa10b552016-10-02 23:45:26 -07002947 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
2948
2949 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01002950 options.video_noise_reduction = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002951 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002952 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
2953
Niels Möllerff40b142018-04-09 08:49:14 +02002954 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07002955}
2956
eladalonf1841382017-06-12 01:16:46 -07002957class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02002958 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07002959 Vp9SettingsTest() : Vp9SettingsTest("") {}
2960 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07002961 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02002962 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02002963 }
2964 virtual ~Vp9SettingsTest() {}
2965
2966 protected:
Erik Språng143cec12015-04-28 10:01:41 +02002967 void TearDown() override {
2968 // Remove references to encoder_factory_ since this will be destroyed
2969 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002970 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02002971 }
Erik Språng143cec12015-04-28 10:01:41 +02002972};
2973
2974TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002975 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002976 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002977 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02002978
Peter Boström2feafdb2015-09-09 14:32:14 +02002979 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02002980
Tommi85959932018-02-07 19:26:06 +01002981 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002982 EXPECT_EQ(cricket::CS_RUNNING,
2983 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002984 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002985 channel_->SetSend(true);
2986
2987 EXPECT_TRUE(capturer.CaptureFrame());
2988
pbos4cba4eb2015-10-26 11:18:18 -07002989 webrtc::VideoCodecVP9 vp9_settings;
2990 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07002991 EXPECT_TRUE(vp9_settings.denoisingOn)
2992 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07002993
nisse05103312016-03-16 02:22:50 -07002994 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002995
Erik Språng143cec12015-04-28 10:01:41 +02002996 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2997 EXPECT_FALSE(vp9_settings.denoisingOn);
2998 // Frame dropping always on for real time video.
2999 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3000
nisse05103312016-03-16 02:22:50 -07003001 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02003002
3003 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3004 EXPECT_TRUE(vp9_settings.denoisingOn);
3005 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3006
3007 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003008 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003009 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02003010 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003011
nisse05103312016-03-16 02:22:50 -07003012 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003013
3014 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3015 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003016 // Frame dropping always on for screen sharing.
3017 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003018
nisse05103312016-03-16 02:22:50 -07003019 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003020
3021 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3022 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003023 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003024
Niels Möllerff40b142018-04-09 08:49:14 +02003025 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003026}
3027
Sergey Silkinf18072e2018-03-14 10:35:35 +01003028TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3029 cricket::VideoSendParameters parameters;
3030 parameters.codecs.push_back(GetEngineCodec("VP9"));
3031 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3032
3033 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3034
3035 FakeVideoSendStream* stream =
3036 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3037
3038 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3039 EXPECT_EQ(ssrcs.size(), config.rtp.ssrcs.size());
3040
3041 FakeVideoCapturerWithTaskQueue capturer;
3042 EXPECT_EQ(cricket::CS_RUNNING,
3043 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003044 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &capturer));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003045 channel_->SetSend(true);
3046
3047 EXPECT_TRUE(capturer.CaptureFrame());
3048
3049 webrtc::VideoCodecVP9 vp9_settings;
3050 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3051
3052 const size_t kNumSpatialLayers = ssrcs.size();
3053 const size_t kNumTemporalLayers = 3;
3054 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3055 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3056
Niels Möllerff40b142018-04-09 08:49:14 +02003057 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003058}
3059
asaperssonc5dabdd2016-03-21 04:15:50 -07003060class Vp9SettingsTestWithFieldTrial : public Vp9SettingsTest {
3061 public:
brandtr468da7c2016-11-22 02:16:47 -08003062 explicit Vp9SettingsTestWithFieldTrial(const char* field_trials)
asaperssonc5dabdd2016-03-21 04:15:50 -07003063 : Vp9SettingsTest(field_trials) {}
3064
3065 protected:
3066 void VerifySettings(int num_spatial_layers, int num_temporal_layers) {
3067 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003068 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003069 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3070
3071 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3072
Tommi85959932018-02-07 19:26:06 +01003073 FakeVideoCapturerWithTaskQueue capturer;
asaperssonc5dabdd2016-03-21 04:15:50 -07003074 EXPECT_EQ(cricket::CS_RUNNING,
3075 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003076 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
asaperssonc5dabdd2016-03-21 04:15:50 -07003077 channel_->SetSend(true);
3078
3079 EXPECT_TRUE(capturer.CaptureFrame());
3080
3081 webrtc::VideoCodecVP9 vp9_settings;
3082 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3083 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3084 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
3085
Niels Möllerff40b142018-04-09 08:49:14 +02003086 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003087 }
3088};
3089
3090class Vp9SettingsTestWithNoFlag : public Vp9SettingsTestWithFieldTrial {
3091 public:
3092 Vp9SettingsTestWithNoFlag() : Vp9SettingsTestWithFieldTrial("") {}
3093};
3094
3095TEST_F(Vp9SettingsTestWithNoFlag, VerifySettings) {
3096 const int kNumSpatialLayers = 1;
3097 const int kNumTemporalLayers = 1;
3098 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3099}
3100
3101class Vp9SettingsTestWithInvalidFlag : public Vp9SettingsTestWithFieldTrial {
3102 public:
3103 Vp9SettingsTestWithInvalidFlag()
3104 : Vp9SettingsTestWithFieldTrial("WebRTC-SupportVP9SVC/Default/") {}
3105};
3106
3107TEST_F(Vp9SettingsTestWithInvalidFlag, VerifySettings) {
3108 const int kNumSpatialLayers = 1;
3109 const int kNumTemporalLayers = 1;
3110 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3111}
3112
3113class Vp9SettingsTestWith2SL3TLFlag : public Vp9SettingsTestWithFieldTrial {
3114 public:
3115 Vp9SettingsTestWith2SL3TLFlag()
3116 : Vp9SettingsTestWithFieldTrial(
3117 "WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/") {}
3118};
3119
3120TEST_F(Vp9SettingsTestWith2SL3TLFlag, VerifySettings) {
3121 const int kNumSpatialLayers = 2;
3122 const int kNumTemporalLayers = 3;
3123 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3124}
3125
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003126TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3127 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3128 ASSERT_EQ(1u, streams.size());
3129 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3130}
3131
3132TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
3133 webrtc::test::ScopedFieldTrials override_field_trials_(
3134 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3135 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3136 ASSERT_EQ(1u, streams.size());
3137 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3138}
3139
asapersson3c81a1a2017-06-14 05:52:21 -07003140TEST_F(WebRtcVideoChannelTest,
3141 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
3142 webrtc::test::ScopedFieldTrials override_field_trials_(
3143 "WebRTC-Video-BalancedDegradation/Disabled/");
3144 const bool kResolutionScalingEnabled = true;
3145 const bool kFpsScalingEnabled = false;
3146 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3147}
3148
3149TEST_F(WebRtcVideoChannelTest,
3150 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
3151 webrtc::test::ScopedFieldTrials override_field_trials_(
3152 "WebRTC-Video-BalancedDegradation/Enabled/");
3153 const bool kResolutionScalingEnabled = true;
3154 const bool kFpsScalingEnabled = true;
3155 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3156}
3157
eladalonf1841382017-06-12 01:16:46 -07003158TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003159 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003160}
3161
eladalonf1841382017-06-12 01:16:46 -07003162TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003163 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003164}
3165
eladalonf1841382017-06-12 01:16:46 -07003166TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003167 TestCpuAdaptation(true, true);
3168}
3169
eladalonf1841382017-06-12 01:16:46 -07003170TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruseAndChangeResolution) {
magjed509e4fe2016-11-18 01:34:11 -08003171 cricket::VideoCodec codec = GetEngineCodec("VP8");
perkj2d5f0912016-02-29 00:04:41 -08003172 cricket::VideoSendParameters parameters;
3173 parameters.codecs.push_back(codec);
3174
kthelgason2bc68642017-02-07 07:02:22 -08003175 MediaConfig media_config = GetMediaConfig();
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003176 channel_.reset(engine_.CreateChannel(
3177 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003178 channel_->OnReadyToSend(true);
perkj2d5f0912016-02-29 00:04:41 -08003179 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3180
3181 AddSendStream();
3182
Tommi85959932018-02-07 19:26:06 +01003183 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003184 ASSERT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003185 ASSERT_EQ(cricket::CS_RUNNING,
3186 capturer.Start(capturer.GetSupportedFormats()->front()));
3187 ASSERT_TRUE(channel_->SetSend(true));
3188
3189 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3190 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003191
Niels Möllera6cc0f92018-02-12 17:14:55 +01003192 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003193 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3194 EXPECT_EQ(1280, send_stream->GetLastWidth());
3195 EXPECT_EQ(720, send_stream->GetLastHeight());
3196
3197 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003198 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003199 wants.max_pixel_count =
3200 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003201 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003202 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003203 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3204 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3205 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3206
3207 // Trigger overuse again.
sprangc5d62e22017-04-02 23:53:04 -07003208 wants.max_pixel_count =
3209 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003210 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003211 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003212 EXPECT_EQ(3, send_stream->GetNumberOfSwappedFrames());
3213 EXPECT_EQ(1280 * 2 / 4, send_stream->GetLastWidth());
3214 EXPECT_EQ(720 * 2 / 4, send_stream->GetLastHeight());
3215
3216 // Change input resolution.
Niels Möllera6cc0f92018-02-12 17:14:55 +01003217 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003218 EXPECT_EQ(4, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003219 EXPECT_EQ(1284 / 2, send_stream->GetLastWidth());
3220 EXPECT_EQ(724 / 2, send_stream->GetLastHeight());
3221
3222 // Trigger underuse which should go back up in resolution.
sprang84a37592017-02-10 07:04:27 -08003223 int current_pixel_count =
3224 send_stream->GetLastWidth() * send_stream->GetLastHeight();
3225 // Cap the max to 4x the pixel count (assuming max 1/2 x 1/2 scale downs)
3226 // of the current stream, so we don't take too large steps.
sprangc5d62e22017-04-02 23:53:04 -07003227 wants.max_pixel_count = current_pixel_count * 4;
sprang84a37592017-02-10 07:04:27 -08003228 // Default step down is 3/5 pixel count, so go up by 5/3.
Oskar Sundbom78807582017-11-16 11:09:55 +01003229 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003230 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003231 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003232 EXPECT_EQ(5, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003233 EXPECT_EQ(1284 * 3 / 4, send_stream->GetLastWidth());
3234 EXPECT_EQ(724 * 3 / 4, send_stream->GetLastHeight());
3235
sprang84a37592017-02-10 07:04:27 -08003236 // Trigger underuse again, should go back up to full resolution.
3237 current_pixel_count =
3238 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003239 wants.max_pixel_count = current_pixel_count * 4;
Oskar Sundbom78807582017-11-16 11:09:55 +01003240 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003241 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003242 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003243 EXPECT_EQ(6, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003244 EXPECT_EQ(1284, send_stream->GetLastWidth());
3245 EXPECT_EQ(724, send_stream->GetLastHeight());
3246
Niels Möllerff40b142018-04-09 08:49:14 +02003247 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003248}
3249
eladalonf1841382017-06-12 01:16:46 -07003250TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003251 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003252 cricket::VideoSendParameters parameters;
3253 parameters.codecs.push_back(codec);
3254
kthelgason2bc68642017-02-07 07:02:22 -08003255 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003256 media_config.video.enable_cpu_adaptation = true;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003257 channel_.reset(engine_.CreateChannel(
3258 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003259 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003260 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3261
3262 AddSendStream();
3263
Tommi85959932018-02-07 19:26:06 +01003264 FakeVideoCapturerWithTaskQueue capturer;
Per766ad3b2016-04-05 15:23:49 +02003265 ASSERT_EQ(cricket::CS_RUNNING,
3266 capturer.Start(capturer.GetSupportedFormats()->front()));
3267 ASSERT_TRUE(channel_->SetSend(true));
3268 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003269 camera_options.is_screencast = false;
Yves Gerey665174f2018-06-19 15:03:05 +02003270 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
Per766ad3b2016-04-05 15:23:49 +02003271
3272 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3273 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003274
Niels Möllera6cc0f92018-02-12 17:14:55 +01003275 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003276 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3277 EXPECT_EQ(1280, send_stream->GetLastWidth());
3278 EXPECT_EQ(720, send_stream->GetLastHeight());
3279
3280 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003281 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003282 wants.max_pixel_count =
3283 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003284 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003285 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003286 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3287 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3288 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3289
3290 // Switch to screen share. Expect no CPU adaptation.
Tommi85959932018-02-07 19:26:06 +01003291 FakeVideoCapturerWithTaskQueue screen_share(true);
Per766ad3b2016-04-05 15:23:49 +02003292 ASSERT_EQ(cricket::CS_RUNNING,
3293 screen_share.Start(screen_share.GetSupportedFormats()->front()));
Per766ad3b2016-04-05 15:23:49 +02003294 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003295 screenshare_options.is_screencast = true;
Yves Gerey665174f2018-06-19 15:03:05 +02003296 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &screen_share);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003297 EXPECT_TRUE(screen_share.CaptureCustomFrame(1284, 724));
sprangf24a0642017-02-28 13:23:26 -08003298 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3299 send_stream = fake_call_->GetVideoSendStreams().front();
3300 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003301 EXPECT_EQ(1284, send_stream->GetLastWidth());
3302 EXPECT_EQ(724, send_stream->GetLastHeight());
3303
3304 // Switch back to the normal capturer. Expect the frame to be CPU adapted.
Yves Gerey665174f2018-06-19 15:03:05 +02003305 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
sprangf24a0642017-02-28 13:23:26 -08003306 send_stream = fake_call_->GetVideoSendStreams().front();
3307 // We have a new fake send stream, so it doesn't remember the old sink wants.
3308 // In practice, it will be populated from
mflodmancc3d4422017-08-03 08:27:51 -07003309 // VideoStreamEncoder::VideoSourceProxy::SetSource(), so simulate that here.
sprangf24a0642017-02-28 13:23:26 -08003310 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003311 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
sprangf24a0642017-02-28 13:23:26 -08003312 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3313 send_stream = fake_call_->GetVideoSendStreams().front();
3314 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003315 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3316 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3317
Niels Möllerff40b142018-04-09 08:49:14 +02003318 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003319}
3320
asapersson3c81a1a2017-06-14 05:52:21 -07003321// TODO(asapersson): Remove this test when the balanced field trial is removed.
3322void WebRtcVideoChannelTest::TestDegradationPreference(
3323 bool resolution_scaling_enabled,
3324 bool fps_scaling_enabled) {
3325 cricket::VideoCodec codec = GetEngineCodec("VP8");
3326 cricket::VideoSendParameters parameters;
3327 parameters.codecs.push_back(codec);
3328
3329 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003330 media_config.video.enable_cpu_adaptation = true;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003331 channel_.reset(engine_.CreateChannel(
3332 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
asapersson3c81a1a2017-06-14 05:52:21 -07003333 channel_->OnReadyToSend(true);
3334
3335 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3336
3337 AddSendStream();
3338
Tommi85959932018-02-07 19:26:06 +01003339 FakeVideoCapturerWithTaskQueue capturer;
asapersson3c81a1a2017-06-14 05:52:21 -07003340 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02003341 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
asapersson3c81a1a2017-06-14 05:52:21 -07003342 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
3343 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
3344
3345 EXPECT_TRUE(channel_->SetSend(true));
3346
3347 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3348 EXPECT_EQ(resolution_scaling_enabled,
3349 send_stream->resolution_scaling_enabled());
3350 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3351
Niels Möllerff40b142018-04-09 08:49:14 +02003352 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003353}
3354
eladalonf1841382017-06-12 01:16:46 -07003355void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3356 bool is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003357 const int kDefaultFps = 30;
magjed509e4fe2016-11-18 01:34:11 -08003358 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003359 cricket::VideoSendParameters parameters;
3360 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003361
kthelgason2bc68642017-02-07 07:02:22 -08003362 MediaConfig media_config = GetMediaConfig();
3363 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003364 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003365 }
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003366 channel_.reset(engine_.CreateChannel(
3367 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003368 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003369
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003370 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003371
3372 AddSendStream();
3373
Tommi85959932018-02-07 19:26:06 +01003374 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07003375 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003376 options.is_screencast = is_screenshare;
Niels Möllerff40b142018-04-09 08:49:14 +02003377 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj26752742016-10-24 01:21:16 -07003378 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
sprangc5d62e22017-04-02 23:53:04 -07003379 capture_format.interval = rtc::kNumNanosecsPerSec / kDefaultFps;
perkj26752742016-10-24 01:21:16 -07003380 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003381
3382 EXPECT_TRUE(channel_->SetSend(true));
3383
solenberge5269742015-09-08 05:13:22 -07003384 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003385
sprangc5d62e22017-04-02 23:53:04 -07003386 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003387 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003388 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3389 EXPECT_EQ(is_screenshare, send_stream->framerate_scaling_enabled());
perkj2d5f0912016-02-29 00:04:41 -08003390
3391 EXPECT_TRUE(capturer.CaptureFrame());
3392 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3393
perkj26752742016-10-24 01:21:16 -07003394 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3395 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
perkj2d5f0912016-02-29 00:04:41 -08003396
Niels Möllerff40b142018-04-09 08:49:14 +02003397 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003398 return;
3399 }
3400
sprangc5d62e22017-04-02 23:53:04 -07003401 if (is_screenshare) {
3402 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3403 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3404 } else {
3405 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3406 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3407 }
3408
perkj803d97f2016-11-01 11:45:46 -07003409 // Trigger overuse.
3410 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3411
3412 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003413 if (is_screenshare) {
3414 wants.max_framerate_fps = (kDefaultFps * 2) / 3;
3415 } else {
3416 wants.max_pixel_count = capture_format.width * capture_format.height - 1;
3417 }
perkj803d97f2016-11-01 11:45:46 -07003418 send_stream->InjectVideoSinkWants(wants);
3419
sprangc5d62e22017-04-02 23:53:04 -07003420 for (int i = 0; i < kDefaultFps; ++i)
3421 EXPECT_TRUE(capturer.CaptureFrame());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003422
sprangc5d62e22017-04-02 23:53:04 -07003423 if (is_screenshare) {
3424 // Drops every third frame.
3425 EXPECT_EQ(kDefaultFps * 2 / 3, send_stream->GetNumberOfSwappedFrames());
3426 EXPECT_EQ(send_stream->GetLastWidth(), capture_format.width);
3427 EXPECT_EQ(send_stream->GetLastHeight(), capture_format.height);
3428 } else {
3429 EXPECT_EQ(kDefaultFps, send_stream->GetNumberOfSwappedFrames());
3430 EXPECT_LT(send_stream->GetLastWidth(), capture_format.width);
3431 EXPECT_LT(send_stream->GetLastHeight(), capture_format.height);
3432 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003433
3434 // Trigger underuse which should go back to normal resolution.
sprang84a37592017-02-10 07:04:27 -08003435 int last_pixel_count =
3436 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003437 if (is_screenshare) {
3438 wants.max_framerate_fps = kDefaultFps;
3439 } else {
3440 wants.max_pixel_count = last_pixel_count * 4;
3441 wants.target_pixel_count.emplace((last_pixel_count * 5) / 3);
3442 }
perkj803d97f2016-11-01 11:45:46 -07003443 send_stream->InjectVideoSinkWants(wants);
3444
sprangc5d62e22017-04-02 23:53:04 -07003445 for (int i = 0; i < kDefaultFps; ++i)
3446 EXPECT_TRUE(capturer.CaptureFrame());
3447
3448 if (is_screenshare) {
3449 EXPECT_EQ(kDefaultFps + (kDefaultFps * 2 / 3),
3450 send_stream->GetNumberOfSwappedFrames());
3451 } else {
3452 EXPECT_EQ(kDefaultFps * 2, send_stream->GetNumberOfSwappedFrames());
3453 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003454
perkj26752742016-10-24 01:21:16 -07003455 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3456 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003457
Niels Möllerff40b142018-04-09 08:49:14 +02003458 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003459}
3460
eladalonf1841382017-06-12 01:16:46 -07003461TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003462 // Start at last timestamp to verify that wraparounds are estimated correctly.
3463 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3464 static const int64_t kInitialNtpTimeMs = 1247891230;
3465 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003466 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003467
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003468 FakeVideoReceiveStream* stream = AddRecvStream();
3469 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003470 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003471
nisse64ec8f82016-09-27 00:17:25 -07003472 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4),
3473 kInitialTimestamp, 0,
3474 webrtc::kVideoRotation_0);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003475 // Initial NTP time is not available on the first frame, but should still be
3476 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003477 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003478
3479 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003480
3481 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3482 // triggers a constant-overflow warning, hence we're calculating it explicitly
3483 // here.
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +02003484 fake_clock_.AdvanceTimeMicros(kFrameOffsetMs * rtc::kNumMicrosecsPerMillisec);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003485 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3486 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003487 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003488
3489 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003490
3491 // Verify that NTP time has been correctly deduced.
3492 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003493 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003494 ASSERT_EQ(1u, info.receivers.size());
3495 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003496}
3497
eladalonf1841382017-06-12 01:16:46 -07003498TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003499 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003500 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003501
3502 VideoCodec codec;
3503 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003504 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003505
3506 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003507 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3508 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003509 FakeVideoSendStream* stream = AddSendStream(
3510 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003511 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003512
3513 // Make sure NACK and FEC are enabled on the correct payload types.
3514 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003515 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3516 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003517
3518 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3519 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003520 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003521 // TODO(juberti): Check RTCP, PLI, TMMBR.
3522}
3523
brandtr31bd2242017-05-19 05:47:46 -07003524// The following four tests ensures that FlexFEC is not activated by default
3525// when the field trials are not enabled.
3526// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3527// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003528TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003529 FakeVideoSendStream* stream = AddSendStream();
3530 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3531
brandtr3d200bd2017-01-16 06:59:19 -08003532 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003533 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3534 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003535}
3536
eladalonf1841382017-06-12 01:16:46 -07003537TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003538 FakeVideoSendStream* stream = AddSendStream(
3539 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3540 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3541
brandtr3d200bd2017-01-16 06:59:19 -08003542 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003543 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3544 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3545}
3546
Yves Gerey665174f2018-06-19 15:03:05 +02003547TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003548 AddRecvStream();
3549
3550 const std::vector<FakeFlexfecReceiveStream*>& streams =
3551 fake_call_->GetFlexfecReceiveStreams();
3552 EXPECT_TRUE(streams.empty());
3553}
3554
eladalonf1841382017-06-12 01:16:46 -07003555TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003556 AddRecvStream(
3557 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3558
3559 const std::vector<FakeFlexfecReceiveStream*>& streams =
3560 fake_call_->GetFlexfecReceiveStreams();
3561 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003562}
3563
3564// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3565// tests that use this test fixture into the corresponding "non-field trial"
3566// tests.
eladalonf1841382017-06-12 01:16:46 -07003567class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003568 public:
eladalonf1841382017-06-12 01:16:46 -07003569 WebRtcVideoChannelFlexfecRecvTest()
3570 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003571};
3572
eladalonf1841382017-06-12 01:16:46 -07003573TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003574 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3575 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3576 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3577}
3578
eladalonf1841382017-06-12 01:16:46 -07003579TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003580 AddRecvStream();
3581
3582 const std::vector<FakeFlexfecReceiveStream*>& streams =
3583 fake_call_->GetFlexfecReceiveStreams();
3584 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003585
3586 const std::vector<FakeVideoReceiveStream*>& video_streams =
3587 fake_call_->GetVideoReceiveStreams();
3588 ASSERT_EQ(1U, video_streams.size());
3589 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3590 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3591 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003592}
3593
eladalonf1841382017-06-12 01:16:46 -07003594TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003595 AddRecvStream(
3596 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3597
3598 const std::vector<FakeFlexfecReceiveStream*>& streams =
3599 fake_call_->GetFlexfecReceiveStreams();
3600 ASSERT_EQ(1U, streams.size());
3601 const FakeFlexfecReceiveStream* stream = streams.front();
3602 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3603 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3604 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3605 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3606 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003607
3608 const std::vector<FakeVideoReceiveStream*>& video_streams =
3609 fake_call_->GetVideoReceiveStreams();
3610 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003611 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3612 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003613 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003614 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003615 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003616}
3617
eladalonf1841382017-06-12 01:16:46 -07003618TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003619 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3620 cricket::VideoRecvParameters recv_parameters;
3621 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3622 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3623
3624 AddRecvStream(
3625 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3626 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003627 const std::vector<FakeVideoReceiveStream*>& video_streams =
3628 fake_call_->GetVideoReceiveStreams();
3629 ASSERT_EQ(1U, video_streams.size());
3630 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3631 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3632 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003633
3634 // Enable FlexFEC.
3635 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3636 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3637 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3638 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3639 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3640 << "Enabling FlexFEC should not create VideoReceiveStream.";
3641 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3642 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003643 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3644 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003645}
3646
eladalonf1841382017-06-12 01:16:46 -07003647TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003648 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3649 cricket::VideoRecvParameters recv_parameters;
3650 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3651 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3652 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3653
3654 AddRecvStream(
3655 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3656 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003657 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003658 const std::vector<FakeVideoReceiveStream*>& video_streams =
3659 fake_call_->GetVideoReceiveStreams();
3660 ASSERT_EQ(1U, video_streams.size());
3661 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3662 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3663 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003664
3665 // Disable FlexFEC.
3666 recv_parameters.codecs.clear();
3667 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3668 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3669 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3670 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3671 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3672 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3673 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3674 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003675 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3676 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003677}
3678
brandtr31bd2242017-05-19 05:47:46 -07003679// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3680// tests that use this test fixture into the corresponding "non-field trial"
3681// tests.
eladalonf1841382017-06-12 01:16:46 -07003682class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003683 public:
eladalonf1841382017-06-12 01:16:46 -07003684 WebRtcVideoChannelFlexfecSendRecvTest()
3685 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003686 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3687 }
3688};
3689
Yves Gerey665174f2018-06-19 15:03:05 +02003690TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003691 FakeVideoSendStream* stream = AddSendStream();
3692 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3693
brandtr3d200bd2017-01-16 06:59:19 -08003694 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3695 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3696 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003697}
3698
eladalonf1841382017-06-12 01:16:46 -07003699TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003700 FakeVideoSendStream* stream = AddSendStream(
3701 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3702 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3703
brandtr3d200bd2017-01-16 06:59:19 -08003704 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3705 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3706 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3707 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003708}
3709
eladalonf1841382017-06-12 01:16:46 -07003710TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003711 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003712 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003713 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003714
3715 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003716 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003717
brandtrb5f2c3f2016-10-04 23:28:39 -07003718 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3719 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003720}
3721
eladalonf1841382017-06-12 01:16:46 -07003722TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003723 cricket::VideoSendParameters parameters;
3724 parameters.codecs.push_back(GetEngineCodec("VP8"));
3725 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3726
3727 FakeVideoSendStream* stream = AddSendStream();
3728 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3729
brandtr3d200bd2017-01-16 06:59:19 -08003730 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003731}
3732
eladalonf1841382017-06-12 01:16:46 -07003733TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003734 AddRecvStream(
3735 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003736
3737 cricket::VideoRecvParameters recv_parameters;
3738 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3739 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3740 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003741
3742 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3743 fake_call_->GetFlexfecReceiveStreams();
3744 ASSERT_EQ(1U, flexfec_streams.size());
3745 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3746 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3747 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003748 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003749 flexfec_stream_config.payload_type);
3750 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3751 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3752 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3753 const std::vector<FakeVideoReceiveStream*>& video_streams =
3754 fake_call_->GetVideoReceiveStreams();
3755 const FakeVideoReceiveStream* video_stream = video_streams.front();
3756 const webrtc::VideoReceiveStream::Config& video_stream_config =
3757 video_stream->GetConfig();
3758 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3759 flexfec_stream_config.local_ssrc);
3760 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3761 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3762 flexfec_stream_config.rtcp_send_transport);
3763 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3764 // spec-compliant way.
3765 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3766 flexfec_stream_config.transport_cc);
3767 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3768 EXPECT_EQ(video_stream_config.rtp.extensions,
3769 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003770}
3771
brandtr31bd2242017-05-19 05:47:46 -07003772// We should not send FlexFEC, even if we advertise it, unless the right
3773// field trial is set.
3774// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003775TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003776 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3777 cricket::VideoSendParameters parameters;
3778 parameters.codecs.push_back(GetEngineCodec("VP8"));
3779 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3780 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3781
3782 FakeVideoSendStream* stream = AddSendStream();
3783 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3784
3785 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003786 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003787 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3788}
3789
eladalonf1841382017-06-12 01:16:46 -07003790TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003791 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3792 cricket::VideoSendParameters parameters;
3793 parameters.codecs.push_back(GetEngineCodec("VP8"));
3794 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3795 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3796
3797 FakeVideoSendStream* stream = AddSendStream(
3798 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3799 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3800
3801 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003802 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003803 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3804}
3805
eladalonf1841382017-06-12 01:16:46 -07003806TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003807 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003808 const int kUnusedPayloadType = 127;
3809 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3810
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003811 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003812 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003813 parameters.codecs.push_back(rtx_codec);
3814 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003815 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003816}
3817
eladalonf1841382017-06-12 01:16:46 -07003818TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003819 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003820 const int kUnusedPayloadType1 = 126;
3821 const int kUnusedPayloadType2 = 127;
3822 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3823 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3824 {
3825 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3826 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3827 cricket::VideoSendParameters parameters;
3828 parameters.codecs.push_back(GetEngineCodec("VP8"));
3829 parameters.codecs.push_back(rtx_codec);
3830 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3831 }
3832 {
3833 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3834 kUnusedPayloadType1, kUnusedPayloadType2);
3835 cricket::VideoSendParameters parameters;
3836 parameters.codecs.push_back(GetEngineCodec("VP8"));
3837 parameters.codecs.push_back(rtx_codec);
3838 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3839 << "RTX without matching video codec should be rejected.";
3840 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003841}
3842
eladalonf1841382017-06-12 01:16:46 -07003843TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003844 const int kUnusedPayloadType1 = 126;
3845 const int kUnusedPayloadType2 = 127;
3846 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3847 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3848
3849 // SSRCs for RTX.
3850 cricket::StreamParams params =
3851 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3852 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3853 AddSendStream(params);
3854
3855 // Original payload type for RTX.
3856 cricket::VideoSendParameters parameters;
3857 parameters.codecs.push_back(GetEngineCodec("VP8"));
3858 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3859 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3860 parameters.codecs.push_back(rtx_codec);
3861 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3862 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3863 const webrtc::VideoSendStream::Config& config_before =
3864 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3865 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3866 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3867 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3868
3869 // Change payload type for RTX.
3870 parameters.codecs[1].id = kUnusedPayloadType2;
3871 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3872 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3873 const webrtc::VideoSendStream::Config& config_after =
3874 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3875 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3876 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3877 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3878}
3879
eladalonf1841382017-06-12 01:16:46 -07003880TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003881 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003882 parameters.codecs.push_back(GetEngineCodec("VP8"));
3883 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003884 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003885
3886 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003887 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003888
magjed509e4fe2016-11-18 01:34:11 -08003889 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003890
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003891 parameters.codecs.pop_back();
3892 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003893 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003894 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003895 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003896 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003897 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3898}
3899
eladalonf1841382017-06-12 01:16:46 -07003900TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003901 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003902 cricket::VideoSendParameters parameters;
3903 parameters.codecs.push_back(GetEngineCodec("VP8"));
3904 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3905 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3906
3907 FakeVideoSendStream* stream = AddSendStream(
3908 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3909 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3910
brandtr3d200bd2017-01-16 06:59:19 -08003911 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3912 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003913 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3914 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
3915
3916 parameters.codecs.pop_back();
3917 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3918 stream = fake_call_->GetVideoSendStreams()[0];
3919 ASSERT_TRUE(stream != nullptr);
3920 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08003921 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003922 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003923}
3924
eladalonf1841382017-06-12 01:16:46 -07003925TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003926 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07003927 cricket::VideoCodec codec(100, "VP8");
3928 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
3929 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07003930
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003931 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003932 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003933
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003934 FakeVideoSendStream* stream = AddSendStream();
Tommi85959932018-02-07 19:26:06 +01003935 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003936 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003937
3938 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003939 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003940
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003941 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07003942 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
3943 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003944 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003945 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003946 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02003947 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003948}
3949
eladalonf1841382017-06-12 01:16:46 -07003950TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003951 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3952 200000);
3953}
3954
eladalonf1841382017-06-12 01:16:46 -07003955TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00003956 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
3957 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3958 ASSERT_EQ(1u, streams.size());
3959 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
3960}
3961
eladalonf1841382017-06-12 01:16:46 -07003962TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00003963 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003964 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00003965}
3966
eladalonf1841382017-06-12 01:16:46 -07003967TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003968 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003969}
3970
eladalonf1841382017-06-12 01:16:46 -07003971TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003972 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
3973 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
3974 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003975}
3976
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003977// Test that when both the codec-specific bitrate params and max_bandwidth_bps
3978// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07003979TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003980 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
3981 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
3982 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
3983 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003984 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003985 ExpectSetBitrateParameters(100000, 200000, 400000);
3986 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
3987 // Since the codec isn't changing, start_bitrate_bps should be -1.
3988 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003989
3990 // Decrease max_bandwidth_bps.
3991 send_parameters_.max_bandwidth_bps = 350000;
3992 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003993
3994 // Now try again with the values flipped around.
3995 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
3996 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003997 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003998 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003999
4000 // If we change the codec max, max_bandwidth_bps should still apply.
4001 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004002 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004003 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004004}
4005
Yves Gerey665174f2018-06-19 15:03:05 +02004006TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004007 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4008 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004009 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004010 // Setting max bitrate should keep previous min bitrate.
4011 // Setting max bitrate should not reset start bitrate.
4012 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004013 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004014}
4015
eladalonf1841382017-06-12 01:16:46 -07004016TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004017 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004018 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004019 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004020 // -1 means to disable max bitrate (set infinite).
4021 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004022 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004023 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004024}
4025
eladalonf1841382017-06-12 01:16:46 -07004026TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004027 send_parameters_.max_bandwidth_bps = 99999;
4028 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004029 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004030 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004031 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4032 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4033 stream->GetVideoStreams()[0].max_bitrate_bps);
4034
4035 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004036 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004037 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4038 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004039 stream->GetVideoStreams()[0].max_bitrate_bps);
4040}
4041
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004042// Tests that when the codec specific max bitrate and VideoSendParameters
4043// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4044// appropriately.
4045TEST_F(WebRtcVideoChannelTest,
4046 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4047 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4048 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4049 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4050 send_parameters_.max_bandwidth_bps = -1;
4051 AddSendStream();
4052 ExpectSetMaxBitrate(300000);
4053 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4054
4055 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4056 ASSERT_EQ(1u, video_send_streams.size());
4057 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4058 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4059 // First the max bitrate is set based upon the codec param.
4060 EXPECT_EQ(300000,
4061 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4062
4063 // The VideoSendParameters max bitrate overrides the codec's.
4064 send_parameters_.max_bandwidth_bps = 500000;
4065 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4066 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4067 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4068 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4069}
4070
4071// Tests that when the codec specific max bitrate and RtpParameters
4072// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4073// appropriately.
4074TEST_F(WebRtcVideoChannelTest,
4075 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4076 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4077 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4078 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4079 send_parameters_.max_bandwidth_bps = -1;
4080 AddSendStream();
4081 ExpectSetMaxBitrate(300000);
4082 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4083
4084 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4085 ASSERT_EQ(1u, video_send_streams.size());
4086 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4087 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4088 // First the max bitrate is set based upon the codec param.
4089 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4090
4091 // The RtpParameter max bitrate overrides the codec's.
4092 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4093 ASSERT_EQ(1u, parameters.encodings.size());
4094 parameters.encodings[0].max_bitrate_bps = 500000;
4095 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4096 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4097 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4098 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4099}
4100
Åsa Persson55659812018-06-18 17:51:32 +02004101TEST_F(WebRtcVideoChannelTest,
4102 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4103 send_parameters_.max_bandwidth_bps = 99999;
4104 FakeVideoSendStream* stream = AddSendStream();
4105 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4106 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4107 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4108 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4109 stream->GetVideoStreams()[0].max_bitrate_bps);
4110
4111 // Get and set the rtp encoding parameters.
4112 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4113 EXPECT_EQ(1u, parameters.encodings.size());
4114
4115 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4116 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4117 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4118 stream->GetVideoStreams()[0].max_bitrate_bps);
4119
4120 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4121 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4122 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4123 stream->GetVideoStreams()[0].max_bitrate_bps);
4124}
4125
eladalonf1841382017-06-12 01:16:46 -07004126TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004127 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004128 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004129 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004130 channel_->SetSend(true);
4131
4132 FakeVideoSendStream* stream = AddSendStream();
4133
Tommi85959932018-02-07 19:26:06 +01004134 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004135 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Peter Boström3afc8c42016-01-27 16:45:21 +01004136 EXPECT_EQ(cricket::CS_RUNNING,
4137 capturer.Start(capturer.GetSupportedFormats()->front()));
4138
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004139 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4140 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4141 EXPECT_GT(initial_max_bitrate_bps, 0);
4142
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004143 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4144 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004145 // Insert a frame to update the encoder config.
4146 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004147 streams = stream->GetVideoStreams();
4148 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004149 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004150}
4151
eladalonf1841382017-06-12 01:16:46 -07004152TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004153 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004154 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004155 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004156 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004157 channel_->SetSend(true);
4158
4159 FakeVideoSendStream* stream = AddSendStream(
4160 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4161
4162 // Send a frame to make sure this scales up to >1 stream (simulcast).
Tommi85959932018-02-07 19:26:06 +01004163 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004164 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &capturer));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004165 EXPECT_EQ(cricket::CS_RUNNING,
4166 capturer.Start(capturer.GetSupportedFormats()->front()));
4167 EXPECT_TRUE(capturer.CaptureFrame());
4168
4169 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4170 ASSERT_GT(streams.size(), 1u)
4171 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004172 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004173 EXPECT_GT(initial_max_bitrate_bps, 0);
4174
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004175 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4176 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004177 // Insert a frame to update the encoder config.
4178 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004179 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004180 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004181 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4182
Niels Möllerff40b142018-04-09 08:49:14 +02004183 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004184}
4185
eladalonf1841382017-06-12 01:16:46 -07004186TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004187 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004188 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004189 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004190 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4191 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004192 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004193 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004194
4195 VideoCodec codec;
4196 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4197 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4198}
4199
eladalonf1841382017-06-12 01:16:46 -07004200TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004201 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004202 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004203 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004204 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004205 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004206 parameters.codecs[0].id = kIncorrectPayloads[i];
4207 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004208 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004209 }
4210}
4211
eladalonf1841382017-06-12 01:16:46 -07004212TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004213 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004214 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004215 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004216 parameters.codecs[0].id = payload_type;
4217 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004218 << "Payload type '" << payload_type << "' rejected.";
4219 }
4220}
4221
deadbeef67cf2c12016-04-13 10:07:16 -07004222// Test that setting the a different set of codecs but with an identical front
4223// codec doesn't result in the stream being recreated.
4224// This may happen when a subsequent negotiation includes fewer codecs, as a
4225// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004226TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004227 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4228 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004229 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4230 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004231 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4232
4233 AddSendStream();
4234 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4235
4236 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004237 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004238 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4239 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4240}
4241
eladalonf1841382017-06-12 01:16:46 -07004242TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004243 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004244 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004245 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004246}
4247
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004248// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004249TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004250 const int kUnusedPayloadType1 = 126;
4251 const int kUnusedPayloadType2 = 127;
4252 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4253 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4254
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004255 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004256 parameters.codecs.push_back(GetEngineCodec("VP8"));
4257 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004258 parameters.codecs.push_back(rtx_codec);
4259 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004260 << "RTX codec without associated payload should be rejected.";
4261
magjed509e4fe2016-11-18 01:34:11 -08004262 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004263 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004264 << "RTX codec with invalid associated payload type should be rejected.";
4265
magjed509e4fe2016-11-18 01:34:11 -08004266 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004267 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004268
magjed509e4fe2016-11-18 01:34:11 -08004269 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004270 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004271 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004272
Yves Gerey665174f2018-06-19 15:03:05 +02004273 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4274 << "RTX codec with another RTX as associated payload type should be "
4275 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004276}
4277
eladalonf1841382017-06-12 01:16:46 -07004278TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004279 const int kUnusedPayloadType1 = 126;
4280 const int kUnusedPayloadType2 = 127;
4281 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4282 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4283
4284 // SSRCs for RTX.
4285 cricket::StreamParams params =
4286 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4287 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4288 AddRecvStream(params);
4289
4290 // Original payload type for RTX.
4291 cricket::VideoRecvParameters parameters;
4292 parameters.codecs.push_back(GetEngineCodec("VP8"));
4293 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4294 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4295 parameters.codecs.push_back(rtx_codec);
4296 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4297 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4298 const webrtc::VideoReceiveStream::Config& config_before =
4299 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004300 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4301 const int* payload_type_before = FindKeyByValue(
4302 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4303 ASSERT_NE(payload_type_before, nullptr);
4304 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004305 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4306
4307 // Change payload type for RTX.
4308 parameters.codecs[1].id = kUnusedPayloadType2;
4309 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4310 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4311 const webrtc::VideoReceiveStream::Config& config_after =
4312 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004313 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4314 const int* payload_type_after = FindKeyByValue(
4315 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4316 ASSERT_NE(payload_type_after, nullptr);
4317 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004318 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4319}
4320
eladalonf1841382017-06-12 01:16:46 -07004321TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004322 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004323 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004324 parameters.codecs[0].id = 99;
4325 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004326}
4327
eladalonf1841382017-06-12 01:16:46 -07004328TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004329 cricket::VideoRecvParameters parameters;
4330 parameters.codecs = engine_.codecs();
4331 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004332
4333 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004334 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004335 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004336 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004337}
4338
eladalonf1841382017-06-12 01:16:46 -07004339TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004340 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004341 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004342 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004343 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004344}
4345
eladalonf1841382017-06-12 01:16:46 -07004346TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004347 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004348 parameters.codecs.push_back(GetEngineCodec("VP8"));
4349 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004350 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004351}
4352
eladalonf1841382017-06-12 01:16:46 -07004353TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004354 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004355 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4356 send_parameters.codecs.push_back(GetEngineCodec("red"));
4357 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004358 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004359
4360 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004361
magjed509e4fe2016-11-18 01:34:11 -08004362 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004363 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004364
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004365 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004366 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004367 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004368 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004369 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004370 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004371 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4372}
4373
eladalonf1841382017-06-12 01:16:46 -07004374TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004375 AddRecvStream(
4376 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004377 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004378 fake_call_->GetFlexfecReceiveStreams();
4379
4380 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004381 const FakeFlexfecReceiveStream* stream = streams.front();
4382 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4383 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4384 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4385 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004386
4387 cricket::VideoRecvParameters recv_parameters;
4388 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4389 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4390 EXPECT_TRUE(streams.empty())
4391 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004392}
4393
eladalonf1841382017-06-12 01:16:46 -07004394TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004395 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004396 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004397 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004398
4399 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004400 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4401 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4402 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004403 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4404 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004405 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004406 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004407 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004408 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004409
4410 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004411 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4412 send_parameters.codecs.push_back(GetEngineCodec("red"));
4413 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004414 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4415 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004416 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004417 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004418 << "ULPFEC should be enabled on the receive stream.";
4419}
4420
eladalonf1841382017-06-12 01:16:46 -07004421TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004422 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004423 AddRecvStream(
4424 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004425 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004426 fake_call_->GetFlexfecReceiveStreams();
4427
4428 cricket::VideoRecvParameters recv_parameters;
4429 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4430 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4431 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4432 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004433 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004434 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004435 stream_with_recv_params->GetConfig().payload_type);
4436 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004437 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004438 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004439 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004440 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004441
4442 cricket::VideoSendParameters send_parameters;
4443 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4444 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4445 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4446 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004447 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004448 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004449 stream_with_send_params->GetConfig().payload_type);
4450 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004451 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004452 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004453 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004454 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004455}
4456
eladalonf1841382017-06-12 01:16:46 -07004457TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004458 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004459 parameters.codecs.push_back(GetEngineCodec("VP8"));
4460 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004461 parameters.codecs[1].id = parameters.codecs[0].id;
4462 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004463}
4464
eladalonf1841382017-06-12 01:16:46 -07004465TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004466 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004467 cricket::VideoRecvParameters parameters;
4468 parameters.codecs.push_back(GetEngineCodec("VP8"));
4469 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4470 parameters.codecs[1].id = parameters.codecs[0].id;
4471 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4472}
4473
eladalonf1841382017-06-12 01:16:46 -07004474TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004475 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004476 parameters.codecs.push_back(GetEngineCodec("VP8"));
4477 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004478 parameters.codecs[1].id = parameters.codecs[0].id;
4479 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004480}
4481
eladalonf1841382017-06-12 01:16:46 -07004482TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004483 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004484 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004485 parameters.codecs.push_back(GetEngineCodec("VP8"));
4486 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004487 parameters.codecs[1].id += 1;
4488 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004489}
4490
deadbeef67cf2c12016-04-13 10:07:16 -07004491// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004492// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004493TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004494 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004495 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004496 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4497 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004498 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004499
4500 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4501 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4502
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004503 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004504 parameters2.codecs.push_back(GetEngineCodec("red"));
4505 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004506 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004507 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4508}
4509
eladalonf1841382017-06-12 01:16:46 -07004510TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004511 EXPECT_FALSE(AddSendStream()->IsSending());
4512}
4513
eladalonf1841382017-06-12 01:16:46 -07004514TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004515 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004516}
4517
eladalonf1841382017-06-12 01:16:46 -07004518TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004519 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004520 EXPECT_FALSE(stream->IsSending());
4521
4522 // false->true
4523 EXPECT_TRUE(channel_->SetSend(true));
4524 EXPECT_TRUE(stream->IsSending());
4525 // true->true
4526 EXPECT_TRUE(channel_->SetSend(true));
4527 EXPECT_TRUE(stream->IsSending());
4528 // true->false
4529 EXPECT_TRUE(channel_->SetSend(false));
4530 EXPECT_FALSE(stream->IsSending());
4531 // false->false
4532 EXPECT_TRUE(channel_->SetSend(false));
4533 EXPECT_FALSE(stream->IsSending());
4534
4535 EXPECT_TRUE(channel_->SetSend(true));
4536 FakeVideoSendStream* new_stream = AddSendStream();
4537 EXPECT_TRUE(new_stream->IsSending())
4538 << "Send stream created after SetSend(true) not sending initially.";
4539}
4540
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004541// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004542TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004543 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004544 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004545 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004546 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004547 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004548
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07004549 channel.reset(static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateChannel(
4550 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004551 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004552 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004553 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004554
Tim Haloun648d28a2018-10-18 16:52:22 -07004555 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4556 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004557 config.enable_dscp = true;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07004558 channel.reset(static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateChannel(
4559 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004560 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
Tim Haloun648d28a2018-10-18 16:52:22 -07004561 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4562
4563 // Create a send stream to configure
4564 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4565 parameters = channel->GetRtpSendParameters(kSsrc);
4566 ASSERT_FALSE(parameters.encodings.empty());
4567
4568 // Various priorities map to various dscp values.
4569 parameters.encodings[0].network_priority = 4.0;
4570 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004571 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004572 parameters.encodings[0].network_priority = 0.5;
4573 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4574 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4575
4576 // A bad priority does not change the dscp value.
4577 parameters.encodings[0].network_priority = 0.0;
4578 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4579 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004580
Tim Haloun6ca98362018-09-17 17:06:08 -07004581 // Packets should also self-identify their dscp in PacketOptions.
4582 const uint8_t kData[10] = {0};
4583 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4584 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004585 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004586
nisse51542be2016-02-12 02:27:06 -08004587 // Verify that setting the option to false resets the
4588 // DiffServCodePoint.
4589 config.enable_dscp = false;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07004590 channel.reset(static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateChannel(
4591 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004592 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004593 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004594}
4595
deadbeef13871492015-12-09 12:37:51 -08004596// This test verifies that the RTCP reduced size mode is properly applied to
4597// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004598TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004599 // Create stream, expecting that default mode is "compound".
4600 FakeVideoSendStream* stream1 = AddSendStream();
4601 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004602 webrtc::RtpParameters rtp_parameters =
4603 channel_->GetRtpSendParameters(last_ssrc_);
4604 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004605
4606 // Now enable reduced size mode.
4607 send_parameters_.rtcp.reduced_size = true;
4608 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4609 stream1 = fake_call_->GetVideoSendStreams()[0];
4610 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004611 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4612 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004613
4614 // Create a new stream and ensure it picks up the reduced size mode.
4615 FakeVideoSendStream* stream2 = AddSendStream();
4616 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4617}
4618
4619// This test verifies that the RTCP reduced size mode is properly applied to
4620// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004621TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004622 // Create stream, expecting that default mode is "compound".
4623 FakeVideoReceiveStream* stream1 = AddRecvStream();
4624 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4625
4626 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004627 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4628 // the reduced_size flag should come from that.
4629 send_parameters_.rtcp.reduced_size = true;
4630 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004631 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4632 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4633
4634 // Create a new stream and ensure it picks up the reduced size mode.
4635 FakeVideoReceiveStream* stream2 = AddRecvStream();
4636 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4637}
4638
eladalonf1841382017-06-12 01:16:46 -07004639TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004640 EXPECT_EQ(webrtc::kNetworkUp,
4641 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4642 EXPECT_EQ(webrtc::kNetworkUp,
4643 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004644
4645 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004646 EXPECT_EQ(webrtc::kNetworkDown,
4647 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4648 EXPECT_EQ(webrtc::kNetworkUp,
4649 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004650
4651 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004652 EXPECT_EQ(webrtc::kNetworkUp,
4653 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4654 EXPECT_EQ(webrtc::kNetworkUp,
4655 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004656}
4657
eladalonf1841382017-06-12 01:16:46 -07004658TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004659 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004660 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004661 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004662
4663 AddSendStream();
4664
4665 cricket::VideoMediaInfo info;
4666 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004667 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004668}
4669
eladalonf1841382017-06-12 01:16:46 -07004670TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004671 FakeVideoSendStream* stream = AddSendStream();
4672 webrtc::VideoSendStream::Stats stats;
4673 stats.encoder_implementation_name = "encoder_implementation_name";
4674 stream->SetStats(stats);
4675
4676 cricket::VideoMediaInfo info;
4677 ASSERT_TRUE(channel_->GetStats(&info));
4678 EXPECT_EQ(stats.encoder_implementation_name,
4679 info.senders[0].encoder_implementation_name);
4680}
4681
eladalonf1841382017-06-12 01:16:46 -07004682TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004683 FakeVideoSendStream* stream = AddSendStream();
4684 webrtc::VideoSendStream::Stats stats;
4685 stats.avg_encode_time_ms = 13;
4686 stats.encode_usage_percent = 42;
4687 stream->SetStats(stats);
4688
4689 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004690 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004691 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4692 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4693}
4694
eladalonf1841382017-06-12 01:16:46 -07004695TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004696 FakeVideoSendStream* stream = AddSendStream();
4697 webrtc::VideoSendStream::Stats stats;
4698 stats.frames_encoded = 13;
4699 stream->SetStats(stats);
4700
4701 cricket::VideoMediaInfo info;
4702 ASSERT_TRUE(channel_->GetStats(&info));
4703 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4704}
4705
eladalonf1841382017-06-12 01:16:46 -07004706TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004707 FakeVideoSendStream* stream = AddSendStream();
4708 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004709 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004710 stream->SetStats(stats);
4711
4712 cricket::VideoMediaInfo info;
4713 ASSERT_TRUE(channel_->GetStats(&info));
4714 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4715}
4716
eladalonf1841382017-06-12 01:16:46 -07004717TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004718 FakeVideoSendStream* stream = AddSendStream();
4719 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004720 stats.substreams[17].width = 123;
4721 stats.substreams[17].height = 40;
4722 stats.substreams[42].width = 80;
4723 stats.substreams[42].height = 31;
4724 stats.substreams[11].width = 20;
4725 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004726 stream->SetStats(stats);
4727
4728 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004729 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004730 ASSERT_EQ(1u, info.senders.size());
4731 EXPECT_EQ(123, info.senders[0].send_frame_width);
4732 EXPECT_EQ(90, info.senders[0].send_frame_height);
4733}
4734
eladalonf1841382017-06-12 01:16:46 -07004735TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004736 FakeVideoSendStream* stream = AddSendStream();
4737 webrtc::VideoSendStream::Stats stats;
4738 stats.number_of_cpu_adapt_changes = 2;
4739 stats.cpu_limited_resolution = true;
4740 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004741
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004742 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004743 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004744 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004745 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004746 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004747}
4748
eladalonf1841382017-06-12 01:16:46 -07004749TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004750 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004751 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004752 stats.number_of_cpu_adapt_changes = 2;
4753 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004754 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004755 stream->SetStats(stats);
4756
4757 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004758 EXPECT_TRUE(channel_->GetStats(&info));
4759 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004760 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4761 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004762 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004763 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004764}
4765
eladalonf1841382017-06-12 01:16:46 -07004766TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004767 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4768 FakeVideoSendStream* stream = AddSendStream();
4769 webrtc::VideoSendStream::Stats stats;
4770 stats.bw_limited_resolution = true;
4771 stream->SetStats(stats);
4772
4773 cricket::VideoMediaInfo info;
4774 EXPECT_TRUE(channel_->GetStats(&info));
4775 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004776 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004777 info.senders[0].adapt_reason);
4778}
4779
Yves Gerey665174f2018-06-19 15:03:05 +02004780TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004781 FakeVideoSendStream* stream = AddSendStream();
4782 webrtc::VideoSendStream::Stats stats;
4783 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4784 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4785 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4786
4787 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4788 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4789 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4790
4791 stream->SetStats(stats);
4792
4793 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004794 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004795 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4796 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4797 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4798}
4799
eladalonf1841382017-06-12 01:16:46 -07004800TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004801 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4802 FakeVideoReceiveStream* stream = AddRecvStream();
4803 webrtc::VideoReceiveStream::Stats stats;
4804 stats.rtcp_packet_type_counts.fir_packets = 2;
4805 stats.rtcp_packet_type_counts.nack_packets = 3;
4806 stats.rtcp_packet_type_counts.pli_packets = 4;
4807 stream->SetStats(stats);
4808
4809 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004810 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004811 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004812 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004813 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004814 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004815 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004816 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004817}
4818
eladalonf1841382017-06-12 01:16:46 -07004819TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004820 FakeVideoReceiveStream* stream = AddRecvStream();
4821 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004822 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004823 stats.decode_ms = 2;
4824 stats.max_decode_ms = 3;
4825 stats.current_delay_ms = 4;
4826 stats.target_delay_ms = 5;
4827 stats.jitter_buffer_ms = 6;
4828 stats.min_playout_delay_ms = 7;
4829 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07004830 stats.width = 9;
4831 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08004832 stats.frame_counts.key_frames = 11;
4833 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08004834 stats.frames_rendered = 13;
4835 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01004836 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004837 stream->SetStats(stats);
4838
4839 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004840 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01004841 EXPECT_EQ(stats.decoder_implementation_name,
4842 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004843 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
4844 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
4845 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
4846 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
4847 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
4848 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
4849 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07004850 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
4851 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004852 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
4853 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08004854 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08004855 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07004856 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08004857 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004858}
4859
eladalonf1841382017-06-12 01:16:46 -07004860TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02004861 FakeVideoReceiveStream* stream = AddRecvStream();
4862 webrtc::VideoReceiveStream::Stats stats;
4863 stats.rtp_stats.transmitted.payload_bytes = 2;
4864 stats.rtp_stats.transmitted.header_bytes = 3;
4865 stats.rtp_stats.transmitted.padding_bytes = 4;
4866 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07004867 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02004868 stats.rtcp_stats.fraction_lost = 7;
4869 stream->SetStats(stats);
4870
4871 cricket::VideoMediaInfo info;
4872 ASSERT_TRUE(channel_->GetStats(&info));
4873 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
4874 stats.rtp_stats.transmitted.header_bytes +
4875 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004876 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02004877 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004878 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07004879 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004880 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02004881 info.receivers[0].fraction_lost);
4882}
4883
eladalonf1841382017-06-12 01:16:46 -07004884TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004885 AddSendStream();
4886 AddSendStream();
4887 webrtc::Call::Stats stats;
4888 stats.rtt_ms = 123;
4889 fake_call_->SetStats(stats);
4890
4891 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004892 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004893 ASSERT_EQ(2u, info.senders.size());
4894 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
4895 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
4896}
4897
eladalonf1841382017-06-12 01:16:46 -07004898TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004899 FakeVideoSendStream* stream = AddSendStream();
4900 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004901 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004902 stats.media_bitrate_bps = 123;
4903 stats.substreams[17].total_bitrate_bps = 1;
4904 stats.substreams[17].retransmit_bitrate_bps = 2;
4905 stats.substreams[42].total_bitrate_bps = 3;
4906 stats.substreams[42].retransmit_bitrate_bps = 4;
4907 stream->SetStats(stats);
4908
4909 FakeVideoSendStream* stream2 = AddSendStream();
4910 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004911 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004912 stats2.media_bitrate_bps = 321;
4913 stats2.substreams[13].total_bitrate_bps = 5;
4914 stats2.substreams[13].retransmit_bitrate_bps = 6;
4915 stats2.substreams[21].total_bitrate_bps = 7;
4916 stats2.substreams[21].retransmit_bitrate_bps = 8;
4917 stream2->SetStats(stats2);
4918
4919 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004920 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004921 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07004922 BandwidthEstimationInfo bwe_info;
4923 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004924 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
4925 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
4926 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
4927 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004928 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004929 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004930 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004931 bwe_info.actual_enc_bitrate);
4932 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004933 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07004934 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004935 << "Bandwidth stats should take all streams into account.";
4936}
4937
eladalonf1841382017-06-12 01:16:46 -07004938TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004939 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004940
Peter Boström0c4e06b2015-10-07 12:23:21 +02004941 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4942 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004943
4944 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4945 const size_t kDataLength = 12;
4946 uint8_t data[kDataLength];
4947 memset(data, 0, sizeof(data));
4948 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07004949 rtc::CopyOnWriteBuffer packet(data, kDataLength);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004950 rtc::PacketTime packet_time;
4951 channel_->OnPacketReceived(&packet, packet_time);
4952
4953 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
4954 << "No default receive stream created.";
4955 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08004956 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004957 << "Default receive stream should not have configured RTX";
4958
4959 EXPECT_TRUE(channel_->AddRecvStream(
4960 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
4961 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08004962 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004963 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07004964 EXPECT_FALSE(
4965 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07004966 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02004967 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07004968 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02004969 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07004970 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08004971 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004972}
4973
eladalonf1841382017-06-12 01:16:46 -07004974TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004975 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01004976
Peter Boström0c4e06b2015-10-07 12:23:21 +02004977 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4978 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01004979
4980 StreamParams sp =
4981 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4982 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
4983
4984 EXPECT_FALSE(channel_->AddSendStream(sp));
4985 EXPECT_FALSE(channel_->AddRecvStream(sp));
4986}
4987
eladalonf1841382017-06-12 01:16:46 -07004988TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004989 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004990
Peter Boström0c4e06b2015-10-07 12:23:21 +02004991 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4992 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01004993
4994 StreamParams sp =
4995 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4996
4997 EXPECT_TRUE(channel_->AddSendStream(sp));
4998 EXPECT_TRUE(channel_->AddRecvStream(sp));
4999
5000 // The RTX SSRC is already used in previous streams, using it should fail.
5001 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5002 EXPECT_FALSE(channel_->AddSendStream(sp));
5003 EXPECT_FALSE(channel_->AddRecvStream(sp));
5004
5005 // After removing the original stream this should be fine to add (makes sure
5006 // that RTX ssrcs are not forever taken).
5007 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5008 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5009 EXPECT_TRUE(channel_->AddSendStream(sp));
5010 EXPECT_TRUE(channel_->AddRecvStream(sp));
5011}
5012
eladalonf1841382017-06-12 01:16:46 -07005013TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005014 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005015 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5016 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005017 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005018
Peter Boströmd6f4c252015-03-26 16:23:04 +01005019 StreamParams sp =
5020 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5021
5022 EXPECT_TRUE(channel_->AddSendStream(sp));
5023 EXPECT_TRUE(channel_->AddRecvStream(sp));
5024
5025 // One of the SSRCs is already used in previous streams, using it should fail.
5026 sp = cricket::CreateSimStreamParams("cname",
5027 MAKE_VECTOR(kOverlappingStreamSsrcs));
5028 EXPECT_FALSE(channel_->AddSendStream(sp));
5029 EXPECT_FALSE(channel_->AddRecvStream(sp));
5030
5031 // After removing the original stream this should be fine to add (makes sure
5032 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005033 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5034 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005035 EXPECT_TRUE(channel_->AddSendStream(sp));
5036 EXPECT_TRUE(channel_->AddRecvStream(sp));
5037}
5038
eladalonf1841382017-06-12 01:16:46 -07005039TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005040 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005041
5042 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5043 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5044
5045 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5046 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5047
5048 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5049
5050 static const uint32_t kReceiverSsrcs[] = {3};
5051 static const uint32_t kReceiverRtxSsrcs[] = {2};
5052
5053 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5054 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5055 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5056
5057 cricket::VideoMediaInfo info;
5058 ASSERT_TRUE(channel_->GetStats(&info));
5059
5060 ASSERT_EQ(1u, info.senders.size());
5061 ASSERT_EQ(1u, info.receivers.size());
5062
5063 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5064 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5065 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5066}
5067
eladalonf1841382017-06-12 01:16:46 -07005068TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005069 FakeVideoReceiveStream* stream = AddRecvStream();
5070 webrtc::VideoReceiveStream::Stats stats;
5071 cricket::VideoMediaInfo info;
5072
5073 // Report no codec name before receiving.
5074 stream->SetStats(stats);
5075 ASSERT_TRUE(channel_->GetStats(&info));
5076 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5077
5078 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005079 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005080 stream->SetStats(stats);
5081 ASSERT_TRUE(channel_->GetStats(&info));
5082 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5083
5084 // Report no codec name for unknown playload types.
5085 stats.current_payload_type = 3;
5086 stream->SetStats(stats);
5087 ASSERT_TRUE(channel_->GetStats(&info));
5088 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5089}
5090
Seth Hampson5897a6e2018-04-03 11:16:33 -07005091// Tests that when we add a stream without SSRCs, but contains a stream_id
5092// that it is stored and its stream id is later used when the first packet
5093// arrives to properly create a receive stream with a sync label.
5094TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5095 const char kSyncLabel[] = "sync_label";
5096 cricket::StreamParams unsignaled_stream;
5097 unsignaled_stream.set_stream_ids({kSyncLabel});
5098 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5099 // The stream shouldn't have been created at this point because it doesn't
5100 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005101 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005102
5103 // Create and deliver packet.
5104 const size_t kDataLength = 12;
5105 uint8_t data[kDataLength];
5106 memset(data, 0, sizeof(data));
5107 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5108 rtc::CopyOnWriteBuffer packet(data, kDataLength);
5109 rtc::PacketTime packet_time;
5110 channel_->OnPacketReceived(&packet, packet_time);
5111
5112 // The stream should now be created with the appropriate sync label.
5113 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5114 EXPECT_EQ(kSyncLabel,
5115 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5116
5117 // Removing the unsignaled stream should clear the cache. This time when
5118 // a default video receive stream is created it won't have a sync_group.
5119 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5120 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5121 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5122
5123 channel_->OnPacketReceived(&packet, packet_time);
5124 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5125 EXPECT_TRUE(
5126 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5127}
5128
eladalonf1841382017-06-12 01:16:46 -07005129void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005130 uint8_t payload_type,
5131 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005132 // kRedRtxPayloadType must currently be unused.
5133 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5134
noahricd10a68e2015-07-10 11:27:55 -07005135 // Add a RED RTX codec.
5136 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005137 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005138 recv_parameters_.codecs.push_back(red_rtx_codec);
5139 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005140
5141 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5142 const size_t kDataLength = 12;
5143 uint8_t data[kDataLength];
5144 memset(data, 0, sizeof(data));
5145
5146 rtc::Set8(data, 1, payload_type);
5147 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005148 rtc::CopyOnWriteBuffer packet(data, kDataLength);
noahricd10a68e2015-07-10 11:27:55 -07005149 rtc::PacketTime packet_time;
5150 channel_->OnPacketReceived(&packet, packet_time);
5151
5152 if (expect_created_receive_stream) {
5153 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5154 << "Should have created a receive stream for payload type: "
5155 << payload_type;
5156 } else {
5157 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5158 << "Shouldn't have created a receive stream for payload type: "
5159 << payload_type;
5160 }
5161}
5162
Åsa Persson2c7149b2018-10-15 09:36:10 +02005163class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5164 public:
5165 WebRtcVideoChannelDiscardUnknownSsrcTest()
5166 : WebRtcVideoChannelTest(
5167 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5168};
5169
5170TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5171 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5172 false /* expect_created_receive_stream */);
5173}
5174
eladalonf1841382017-06-12 01:16:46 -07005175TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005176 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5177 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005178}
5179
eladalonf1841382017-06-12 01:16:46 -07005180TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005181 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5182 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005183}
5184
eladalonf1841382017-06-12 01:16:46 -07005185TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005186 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005187 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5188 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5189 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5190 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005191}
5192
eladalonf1841382017-06-12 01:16:46 -07005193TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005194 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5195 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005196}
5197
eladalonf1841382017-06-12 01:16:46 -07005198TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005199 FlexfecPacketDoesntCreateUnsignalledStream) {
5200 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5201 false /* expect_created_receive_stream */);
5202}
5203
eladalonf1841382017-06-12 01:16:46 -07005204TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005205 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5206 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005207}
5208
mzanaty8a855d62017-02-17 15:46:43 -08005209// Test that receiving any unsignalled SSRC works even if it changes.
5210// The first unsignalled SSRC received will create a default receive stream.
5211// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005212TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005213 // Allow receiving VP8, VP9, H264 (if enabled).
5214 cricket::VideoRecvParameters parameters;
5215 parameters.codecs.push_back(GetEngineCodec("VP8"));
5216 parameters.codecs.push_back(GetEngineCodec("VP9"));
5217
5218#if defined(WEBRTC_USE_H264)
5219 cricket::VideoCodec H264codec(126, "H264");
5220 parameters.codecs.push_back(H264codec);
5221#endif
5222
5223 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5224 // No receive streams yet.
5225 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5226 cricket::FakeVideoRenderer renderer;
5227 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5228
5229 // Receive VP8 packet on first SSRC.
5230 uint8_t data[kMinRtpPacketLen];
5231 cricket::RtpHeader rtpHeader;
5232 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5233 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005234 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005235 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5236 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5237 rtc::PacketTime packet_time;
5238 channel_->OnPacketReceived(&packet, packet_time);
5239 // VP8 packet should create default receive stream.
5240 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005241 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005242 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5243 // Verify that the receive stream sinks to a renderer.
5244 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4), 100, 0,
5245 webrtc::kVideoRotation_0);
5246 recv_stream->InjectFrame(video_frame);
5247 EXPECT_EQ(1, renderer.num_rendered_frames());
5248
5249 // Receive VP9 packet on second SSRC.
5250 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005251 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005252 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5253 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
5254 channel_->OnPacketReceived(&packet2, packet_time);
5255 // VP9 packet should replace the default receive SSRC.
5256 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5257 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5258 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5259 // Verify that the receive stream sinks to a renderer.
5260 webrtc::VideoFrame video_frame2(CreateBlackFrameBuffer(4, 4), 200, 0,
ilnik00d802b2017-04-11 10:34:31 -07005261 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005262 recv_stream->InjectFrame(video_frame2);
5263 EXPECT_EQ(2, renderer.num_rendered_frames());
5264
5265#if defined(WEBRTC_USE_H264)
5266 // Receive H264 packet on third SSRC.
5267 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005268 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005269 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5270 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
5271 channel_->OnPacketReceived(&packet3, packet_time);
5272 // H264 packet should replace the default receive SSRC.
5273 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5274 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5275 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5276 // Verify that the receive stream sinks to a renderer.
5277 webrtc::VideoFrame video_frame3(CreateBlackFrameBuffer(4, 4), 300, 0,
ilnik00d802b2017-04-11 10:34:31 -07005278 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005279 recv_stream->InjectFrame(video_frame3);
5280 EXPECT_EQ(3, renderer.num_rendered_frames());
5281#endif
5282}
5283
brandtr0dc57ea2017-05-29 23:33:31 -07005284// This test verifies that when a new default stream is created for a new
5285// unsignaled SSRC, the new stream does not overwrite any old stream that had
5286// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005287TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005288 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5289 cricket::VideoRecvParameters parameters;
5290 parameters.codecs.push_back(GetEngineCodec("VP8"));
5291 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5292
5293 // No streams signaled and no packets received, so we should not have any
5294 // stream objects created yet.
5295 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5296
5297 // Receive packet on an unsignaled SSRC.
5298 uint8_t data[kMinRtpPacketLen];
5299 cricket::RtpHeader rtp_header;
5300 rtp_header.payload_type = GetEngineCodec("VP8").id;
5301 rtp_header.seq_num = rtp_header.timestamp = 0;
5302 rtp_header.ssrc = kSsrcs3[0];
5303 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5304 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5305 rtc::PacketTime packet_time;
5306 channel_->OnPacketReceived(&packet, packet_time);
5307 // Default receive stream should be created.
5308 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5309 FakeVideoReceiveStream* recv_stream0 =
5310 fake_call_->GetVideoReceiveStreams()[0];
5311 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5312
5313 // Signal the SSRC.
5314 EXPECT_TRUE(
5315 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5316 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5317 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5318 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5319
5320 // Receive packet on a different unsignaled SSRC.
5321 rtp_header.ssrc = kSsrcs3[1];
5322 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5323 packet.SetData(data, sizeof(data));
5324 channel_->OnPacketReceived(&packet, packet_time);
5325 // New default receive stream should be created, but old stream should remain.
5326 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5327 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5328 FakeVideoReceiveStream* recv_stream1 =
5329 fake_call_->GetVideoReceiveStreams()[1];
5330 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5331}
5332
Seth Hampson7c682e02018-05-04 16:28:15 -07005333TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005334 AddSendStream();
5335
Tommi85959932018-02-07 19:26:06 +01005336 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02005337 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
skvladdc1c62c2016-03-16 19:07:43 -07005338 cricket::VideoFormat capture_format_hd =
5339 capturer.GetSupportedFormats()->front();
5340 EXPECT_EQ(1280, capture_format_hd.width);
5341 EXPECT_EQ(720, capture_format_hd.height);
5342 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
5343 EXPECT_TRUE(channel_->SetSend(true));
perkjfa10b552016-10-02 23:45:26 -07005344 capturer.CaptureFrame();
skvladdc1c62c2016-03-16 19:07:43 -07005345
perkjfa10b552016-10-02 23:45:26 -07005346 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005347 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005348
5349 // TODO(skvlad): Resolve the inconsistency between the interpretation
5350 // of the global bitrate limit for audio and video:
5351 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5352 // max_bandwidth_bps = -1 - remove the bandwidth limit
5353 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005354 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005355
perkjfa10b552016-10-02 23:45:26 -07005356 SetAndExpectMaxBitrate(1000, 0, 1000);
5357 SetAndExpectMaxBitrate(1000, 800, 800);
5358 SetAndExpectMaxBitrate(600, 800, 600);
5359 SetAndExpectMaxBitrate(0, 800, 800);
5360 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005361
Niels Möllerff40b142018-04-09 08:49:14 +02005362 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005363}
5364
eladalonf1841382017-06-12 01:16:46 -07005365TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005366 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005367 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005368 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005369
5370 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005371 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005372 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005373}
5374
eladalonf1841382017-06-12 01:16:46 -07005375TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005376 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005377 FakeVideoSendStream* stream = AddSendStream();
5378
Seth Hampson7c682e02018-05-04 16:28:15 -07005379 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5380 EXPECT_EQ(1UL, parameters.encodings.size());
5381 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5382 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5383
5384 // Note that this is testing the behavior of the FakeVideoSendStream, which
5385 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5386 // we are just testing the behavior of
5387 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005388 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5389 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005390
5391 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5392 // by this amount.
5393 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5394 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5395 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5396 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5397
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005398 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5399 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5400 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5401}
5402
5403TEST_F(WebRtcVideoChannelTest,
5404 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5405 FakeVideoSendStream* stream = AddSendStream();
5406
5407 // Note that this is testing the behavior of the FakeVideoSendStream, which
5408 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5409 // we are just testing the behavior of
5410 // EncoderStreamFactory::CreateEncoderStreams.
5411 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5412 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5413
5414 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5415 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5416 EXPECT_EQ(1UL, parameters.encodings.size());
5417 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5418 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5419
5420 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5421 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5422 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5423}
5424
5425TEST_F(WebRtcVideoChannelTest,
5426 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5427 send_parameters_.max_bandwidth_bps = 99999;
5428 FakeVideoSendStream* stream = AddSendStream();
5429 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5430 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5431 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5432 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5433 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5434 stream->GetVideoStreams()[0].max_bitrate_bps);
5435
5436 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5437 // adjusted down.
5438 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5439 EXPECT_EQ(1UL, parameters.encodings.size());
5440 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5441 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5442 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5443 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5444 stream->GetVideoStreams()[0].min_bitrate_bps);
5445 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5446 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005447}
5448
Åsa Persson8c1bf952018-09-13 10:42:19 +02005449TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5450 FakeVideoSendStream* stream = AddSendStream();
5451
5452 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5453 EXPECT_EQ(1UL, parameters.encodings.size());
5454 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5455 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5456
5457 // Note that this is testing the behavior of the FakeVideoSendStream, which
5458 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5459 // we are just testing the behavior of
5460 // EncoderStreamFactory::CreateEncoderStreams.
5461 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5462 EXPECT_EQ(kDefaultVideoMaxFramerate,
5463 stream->GetVideoStreams()[0].max_framerate);
5464
5465 // Set max framerate and check that VideoStream.max_framerate is set.
5466 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5467 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5468 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5469 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5470
5471 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5472 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5473}
5474
Åsa Persson23eba222018-10-02 14:47:06 +02005475TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5476 FakeVideoSendStream* stream = AddSendStream();
5477
5478 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5479 EXPECT_EQ(1UL, parameters.encodings.size());
5480 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5481 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5482
5483 // Note that this is testing the behavior of the FakeVideoSendStream, which
5484 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5485 // we are just testing the behavior of
5486 // EncoderStreamFactory::CreateEncoderStreams.
5487 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5488 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5489
5490 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5491 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5492 parameters.encodings[0].num_temporal_layers = 2;
5493 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5494
5495 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5496 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5497}
5498
Seth Hampson7c682e02018-05-04 16:28:15 -07005499TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005500 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005501 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005502 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005503 // Two or more encodings should result in failure.
5504 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005505 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005506 // Zero encodings should also fail.
5507 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005508 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005509}
5510
Zach Stein3ca452b2018-01-18 10:01:24 -08005511TEST_F(WebRtcVideoChannelTest,
5512 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5513 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5514 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5515 AddSendStream(sp);
5516
5517 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5518
5519 // Additional encodings should result in failure.
5520 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005521 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005522 // Zero encodings should also fail.
5523 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005524 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005525}
5526
deadbeeffb2aced2017-01-06 23:05:37 -08005527// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005528TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005529 AddSendStream();
5530 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005531 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005532 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005533}
5534
Seth Hampson24722b32017-12-22 09:36:42 -08005535// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5536// a value <= 0, setting the parameters returns false.
5537TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5538 AddSendStream();
5539 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5540 EXPECT_EQ(1UL, parameters.encodings.size());
5541 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5542 parameters.encodings[0].bitrate_priority);
5543
5544 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005545 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005546 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005547 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005548}
5549
5550// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5551// properly on the VideoChannel and propogates down to the video encoder.
5552TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5553 AddSendStream();
5554 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5555 EXPECT_EQ(1UL, parameters.encodings.size());
5556 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5557 parameters.encodings[0].bitrate_priority);
5558
5559 // Change the value and set it on the VideoChannel.
5560 double new_bitrate_priority = 2.0;
5561 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005562 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005563
5564 // Verify that the encoding parameters bitrate_priority is set for the
5565 // VideoChannel.
5566 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5567 EXPECT_EQ(1UL, parameters.encodings.size());
5568 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5569
5570 // Verify that the new value propagated down to the encoder.
5571 std::vector<FakeVideoSendStream*> video_send_streams =
5572 fake_call_->GetVideoSendStreams();
5573 EXPECT_EQ(1UL, video_send_streams.size());
5574 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5575 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5576 // appropriately.
5577 EXPECT_EQ(new_bitrate_priority,
5578 video_send_stream->GetEncoderConfig().bitrate_priority);
5579 // Check that the vector of VideoStreams also was propagated correctly. Note
5580 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5581 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005582 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005583 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5584}
5585
5586// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5587// VideoChannel and the value propogates to the video encoder with all simulcast
5588// streams.
5589TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5590 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005591 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005592 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5593 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5594 AddSendStream(stream_params);
5595 uint32_t primary_ssrc = stream_params.first_ssrc();
5596
Tommi85959932018-02-07 19:26:06 +01005597 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
5598 // frame. This creates multiple VideoStreams for all simulcast layers when
5599 // reconfiguring, and allows us to test this behavior.
5600 FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson24722b32017-12-22 09:36:42 -08005601 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02005602 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson24722b32017-12-22 09:36:42 -08005603 EXPECT_EQ(cricket::CS_RUNNING,
5604 capturer.Start(cricket::VideoFormat(
5605 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
5606 cricket::FOURCC_I420)));
5607 channel_->SetSend(true);
5608 EXPECT_TRUE(capturer.CaptureFrame());
5609 // Get and set the rtp encoding parameters.
5610 webrtc::RtpParameters parameters =
5611 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005612 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005613 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5614 parameters.encodings[0].bitrate_priority);
5615 // Change the value and set it on the VideoChannel.
5616 double new_bitrate_priority = 2.0;
5617 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005618 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005619
5620 // Verify that the encoding parameters priority is set on the VideoChannel.
5621 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005622 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005623 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5624
5625 // Verify that the new value propagated down to the encoder.
5626 std::vector<FakeVideoSendStream*> video_send_streams =
5627 fake_call_->GetVideoSendStreams();
5628 EXPECT_EQ(1UL, video_send_streams.size());
5629 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5630 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5631 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005632 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005633 video_send_stream->GetEncoderConfig().number_of_streams);
5634 EXPECT_EQ(new_bitrate_priority,
5635 video_send_stream->GetEncoderConfig().bitrate_priority);
5636 // Check that the vector of VideoStreams also propagated correctly. The
5637 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5638 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005639 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005640 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005641 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5642 // Since we are only setting bitrate priority per-sender, the other
5643 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005644 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005645 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005646 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005647 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005648 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005649}
5650
Tim Haloun648d28a2018-10-18 16:52:22 -07005651// RTCRtpEncodingParameters.network_priority must be one of a few values
5652// derived from the default priority, corresponding to very-low, low, medium,
5653// or high.
5654TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
5655 AddSendStream();
5656 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5657 EXPECT_EQ(1UL, parameters.encodings.size());
5658 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5659 parameters.encodings[0].network_priority);
5660
5661 double good_values[] = {0.5, 1.0, 2.0, 4.0};
5662 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
5663 for (auto it : good_values) {
5664 parameters.encodings[0].network_priority = it;
5665 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5666 }
5667 for (auto it : bad_values) {
5668 parameters.encodings[0].network_priority = it;
5669 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5670 }
5671}
5672
Åsa Persson8c1bf952018-09-13 10:42:19 +02005673TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
5674 const size_t kNumSimulcastStreams = 3;
5675 SetUpSimulcast(true, false);
5676
5677 // Get and set the rtp encoding parameters.
5678 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5679 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5680 for (const auto& encoding : parameters.encodings) {
5681 EXPECT_FALSE(encoding.max_framerate);
5682 }
5683
5684 // Change the value and set it on the VideoChannel.
5685 parameters.encodings[0].max_framerate = 10;
5686 parameters.encodings[1].max_framerate = 20;
5687 parameters.encodings[2].max_framerate = 25;
5688 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5689
5690 // Verify that the bitrates are set on the VideoChannel.
5691 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5692 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5693 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
5694 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
5695 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
5696}
5697
Åsa Persson23eba222018-10-02 14:47:06 +02005698TEST_F(WebRtcVideoChannelTest,
5699 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
5700 const size_t kNumSimulcastStreams = 3;
5701 SetUpSimulcast(true, false);
5702
5703 // Get and set the rtp encoding parameters.
5704 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5705 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5706
5707 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
5708 parameters.encodings[0].num_temporal_layers = 0;
5709 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5710 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5711 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
5712 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5713 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5714}
5715
5716TEST_F(WebRtcVideoChannelTest,
5717 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
5718 const size_t kNumSimulcastStreams = 3;
5719 SetUpSimulcast(true, false);
5720
5721 // Get and set the rtp encoding parameters.
5722 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5723 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5724
5725 // No/all layers should be set.
5726 parameters.encodings[0].num_temporal_layers = 1;
5727 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5728 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5729
5730 // Different values not supported.
5731 parameters.encodings[0].num_temporal_layers = 1;
5732 parameters.encodings[1].num_temporal_layers = 2;
5733 parameters.encodings[2].num_temporal_layers = 2;
5734 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5735 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5736}
5737
5738TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
5739 const size_t kNumSimulcastStreams = 3;
5740 SetUpSimulcast(true, false);
5741
5742 // Get and set the rtp encoding parameters.
5743 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5744 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5745 for (const auto& encoding : parameters.encodings)
5746 EXPECT_FALSE(encoding.num_temporal_layers);
5747
5748 // Change the value and set it on the VideoChannel.
5749 parameters.encodings[0].num_temporal_layers = 3;
5750 parameters.encodings[1].num_temporal_layers = 3;
5751 parameters.encodings[2].num_temporal_layers = 3;
5752 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5753
5754 // Verify that the number of temporal layers are set on the VideoChannel.
5755 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5756 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5757 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
5758 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
5759 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
5760}
5761
5762TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
5763 const size_t kNumSimulcastStreams = 3;
5764 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5765
5766 // Send a full size frame so all simulcast layers are used when reconfiguring.
5767 FakeVideoCapturerWithTaskQueue capturer;
5768 VideoOptions options;
5769 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5770 EXPECT_EQ(cricket::CS_RUNNING,
5771 capturer.Start(capturer.GetSupportedFormats()->front()));
5772 channel_->SetSend(true);
5773 EXPECT_TRUE(capturer.CaptureFrame());
5774
5775 // Get and set the rtp encoding parameters.
5776 // Change the value and set it on the VideoChannel.
5777 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5778 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5779 parameters.encodings[0].num_temporal_layers = 2;
5780 parameters.encodings[1].num_temporal_layers = 2;
5781 parameters.encodings[2].num_temporal_layers = 2;
5782 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5783
5784 // Verify that the new value is propagated down to the encoder.
5785 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5786 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5787 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5788 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5789 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5790 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
5791 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
5792 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
5793
5794 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5795 // VideoStreams are created appropriately for the simulcast case.
5796 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5797 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5798 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
5799 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
5800
5801 // No parameter changed, encoder should not be reconfigured.
5802 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5803 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5804
5805 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5806}
5807
5808TEST_F(WebRtcVideoChannelTest,
5809 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
5810 const size_t kDefaultNumTemporalLayers = 3;
5811 const size_t kNumSimulcastStreams = 3;
5812 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5813
5814 // Send a full size frame so all simulcast layers are used when reconfiguring.
5815 FakeVideoCapturerWithTaskQueue capturer;
5816 VideoOptions options;
5817 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5818 EXPECT_EQ(cricket::CS_RUNNING,
5819 capturer.Start(capturer.GetSupportedFormats()->front()));
5820 channel_->SetSend(true);
5821 EXPECT_TRUE(capturer.CaptureFrame());
5822
5823 // Change rtp encoding parameters, num_temporal_layers not changed.
5824 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5825 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5826 parameters.encodings[0].min_bitrate_bps = 33000;
5827 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5828
5829 // Verify that no value is propagated down to the encoder.
5830 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5831 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5832 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5833 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
5834 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
5835 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
5836
5837 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5838 // VideoStreams are created appropriately for the simulcast case.
5839 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5840 EXPECT_EQ(kDefaultNumTemporalLayers,
5841 stream->GetVideoStreams()[0].num_temporal_layers);
5842 EXPECT_EQ(kDefaultNumTemporalLayers,
5843 stream->GetVideoStreams()[1].num_temporal_layers);
5844 EXPECT_EQ(kDefaultNumTemporalLayers,
5845 stream->GetVideoStreams()[2].num_temporal_layers);
5846
5847 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5848}
5849
Åsa Persson8c1bf952018-09-13 10:42:19 +02005850TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
5851 const size_t kNumSimulcastStreams = 3;
5852 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5853
5854 // Send a full size frame so all simulcast layers are used when reconfiguring.
5855 FakeVideoCapturerWithTaskQueue capturer;
5856 VideoOptions options;
5857 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5858 EXPECT_EQ(cricket::CS_RUNNING,
5859 capturer.Start(capturer.GetSupportedFormats()->front()));
5860 channel_->SetSend(true);
5861 EXPECT_TRUE(capturer.CaptureFrame());
5862
5863 // Get and set the rtp encoding parameters.
5864 // Change the value and set it on the VideoChannel.
5865 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5866 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5867 parameters.encodings[0].max_framerate = 15;
5868 parameters.encodings[1].max_framerate = 25;
5869 parameters.encodings[2].max_framerate = 20;
5870 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5871
5872 // Verify that the new value propagated down to the encoder.
5873 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5874 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5875 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5876 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5877 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5878 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5879 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
5880 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5881
5882 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5883 // VideoStreams are created appropriately for the simulcast case.
5884 // Currently the maximum |max_framerate| is used.
5885 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5886 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
5887 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
5888 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
5889
5890 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5891}
5892
5893TEST_F(WebRtcVideoChannelTest,
5894 DefaultValuePropagatedToEncoderForUnsetFramerate) {
5895 const size_t kNumSimulcastStreams = 3;
5896 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5897 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5898
5899 // Send a full size frame so all simulcast layers are used when reconfiguring.
5900 FakeVideoCapturerWithTaskQueue capturer;
5901 VideoOptions options;
5902 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5903 EXPECT_EQ(cricket::CS_RUNNING,
5904 capturer.Start(capturer.GetSupportedFormats()->front()));
5905 channel_->SetSend(true);
5906 EXPECT_TRUE(capturer.CaptureFrame());
5907
5908 // Get and set the rtp encoding parameters.
5909 // Change the value and set it on the VideoChannel.
5910 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5911 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5912 parameters.encodings[0].max_framerate = 15;
5913 parameters.encodings[2].max_framerate = 20;
5914 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5915
5916 // Verify that the new value propagated down to the encoder.
5917 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5918 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5919 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5920 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5921 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5922 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
5923 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5924
5925 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5926 // VideoStreams are created appropriately for the simulcast case.
5927 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
5928 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5929 EXPECT_EQ(kDefaultVideoMaxFramerate,
5930 stream->GetVideoStreams()[0].max_framerate);
5931 EXPECT_EQ(kDefaultVideoMaxFramerate,
5932 stream->GetVideoStreams()[1].max_framerate);
5933 EXPECT_EQ(kDefaultVideoMaxFramerate,
5934 stream->GetVideoStreams()[2].max_framerate);
5935
5936 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5937}
5938
Åsa Persson55659812018-06-18 17:51:32 +02005939TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
5940 const size_t kNumSimulcastStreams = 3;
5941 SetUpSimulcast(true, false);
5942
5943 // Get and set the rtp encoding parameters.
5944 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5945 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5946 for (const auto& encoding : parameters.encodings) {
5947 EXPECT_FALSE(encoding.min_bitrate_bps);
5948 EXPECT_FALSE(encoding.max_bitrate_bps);
5949 }
5950
5951 // Change the value and set it on the VideoChannel.
5952 parameters.encodings[0].min_bitrate_bps = 100000;
5953 parameters.encodings[0].max_bitrate_bps = 200000;
5954 parameters.encodings[1].min_bitrate_bps = 300000;
5955 parameters.encodings[1].max_bitrate_bps = 400000;
5956 parameters.encodings[2].min_bitrate_bps = 500000;
5957 parameters.encodings[2].max_bitrate_bps = 600000;
5958 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5959
5960 // Verify that the bitrates are set on the VideoChannel.
5961 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5962 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5963 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
5964 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
5965 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
5966 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
5967 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
5968 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
5969}
5970
5971TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
5972 const size_t kNumSimulcastStreams = 3;
5973 SetUpSimulcast(true, false);
5974
5975 // Get and set the rtp encoding parameters.
5976 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5977 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5978
5979 // Max bitrate lower than min bitrate should fail.
5980 parameters.encodings[2].min_bitrate_bps = 100000;
5981 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
5982 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5983 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5984}
5985
5986// Test that min and max bitrate values set via RtpParameters are correctly
5987// propagated to the underlying encoder, and that the target is set to 3/4 of
5988// the maximum (3/4 was chosen because it's similar to the simulcast defaults
5989// that are used if no min/max are specified).
5990TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
5991 const size_t kNumSimulcastStreams = 3;
5992 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5993
5994 // Send a full size frame so all simulcast layers are used when reconfiguring.
5995 FakeVideoCapturerWithTaskQueue capturer;
5996 VideoOptions options;
5997 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5998 EXPECT_EQ(cricket::CS_RUNNING,
5999 capturer.Start(capturer.GetSupportedFormats()->front()));
6000 channel_->SetSend(true);
6001 EXPECT_TRUE(capturer.CaptureFrame());
6002
6003 // Get and set the rtp encoding parameters.
6004 // Change the value and set it on the VideoChannel.
6005 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6006 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6007 parameters.encodings[0].min_bitrate_bps = 100000;
6008 parameters.encodings[0].max_bitrate_bps = 200000;
6009 parameters.encodings[1].min_bitrate_bps = 300000;
6010 parameters.encodings[1].max_bitrate_bps = 400000;
6011 parameters.encodings[2].min_bitrate_bps = 500000;
6012 parameters.encodings[2].max_bitrate_bps = 600000;
6013 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6014
6015 // Verify that the new value propagated down to the encoder.
6016 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6017 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6018 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6019 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6020 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6021 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6022 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6023 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6024 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6025 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6026 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6027
6028 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6029 // VideoStreams are created appropriately for the simulcast case.
6030 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6031 // Target bitrate: 200000 * 3 / 4 = 150000.
6032 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6033 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6034 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6035 // Target bitrate: 400000 * 3 / 4 = 300000.
6036 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6037 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6038 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6039 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6040 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6041 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6042 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6043
6044 // No parameter changed, encoder should not be reconfigured.
6045 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6046 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6047
6048 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6049}
6050
6051// Test to only specify the min or max bitrate value for a layer via
6052// RtpParameters. The unspecified min/max and target value should be set to the
6053// simulcast default that is used if no min/max are specified.
6054TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6055 const size_t kNumSimulcastStreams = 3;
6056 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6057 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6058
6059 // Send a full size frame so all simulcast layers are used when reconfiguring.
6060 FakeVideoCapturerWithTaskQueue capturer;
6061 VideoOptions options;
6062 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6063 EXPECT_EQ(cricket::CS_RUNNING,
6064 capturer.Start(capturer.GetSupportedFormats()->front()));
6065 channel_->SetSend(true);
6066 EXPECT_TRUE(capturer.CaptureFrame());
6067
6068 // Get and set the rtp encoding parameters.
6069 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6070 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6071
6072 // Change the value and set it on the VideoChannel.
6073 // Layer 0: only configure min bitrate.
6074 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6075 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6076 // Layer 1: only configure max bitrate.
6077 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6078 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6079 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6080
6081 // Verify that the new value propagated down to the encoder.
6082 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6083 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6084 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6085 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6086 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6087 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6088 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6089 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6090 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6091 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6092
6093 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6094 // VideoStreams are created appropriately for the simulcast case.
6095 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6096 // Layer 0: min configured bitrate should overwrite min default.
6097 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6098 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6099 stream->GetVideoStreams()[0].target_bitrate_bps);
6100 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6101 stream->GetVideoStreams()[0].max_bitrate_bps);
6102 // Layer 1: max configured bitrate should overwrite max default.
6103 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6104 stream->GetVideoStreams()[1].min_bitrate_bps);
6105 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6106 stream->GetVideoStreams()[1].target_bitrate_bps);
6107 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6108 // Layer 2: min and max bitrate not configured, default expected.
6109 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6110 stream->GetVideoStreams()[2].min_bitrate_bps);
6111 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6112 stream->GetVideoStreams()[2].target_bitrate_bps);
6113 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6114 stream->GetVideoStreams()[2].max_bitrate_bps);
6115
6116 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6117}
6118
6119// Test that specifying the min (or max) bitrate value for a layer via
6120// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6121// unspecified values accordingly.
6122TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6123 const size_t kNumSimulcastStreams = 3;
6124 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6125 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6126
6127 // Send a full size frame so all simulcast layers are used when reconfiguring.
6128 FakeVideoCapturerWithTaskQueue capturer;
6129 VideoOptions options;
6130 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6131 EXPECT_EQ(cricket::CS_RUNNING,
6132 capturer.Start(capturer.GetSupportedFormats()->front()));
6133 channel_->SetSend(true);
6134 EXPECT_TRUE(capturer.CaptureFrame());
6135
6136 // Get and set the rtp encoding parameters.
6137 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6138 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6139
6140 // Change the value and set it on the VideoChannel.
6141 // For layer 0, set the min bitrate above the default max.
6142 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6143 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6144 // For layer 1, set the max bitrate below the default min.
6145 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6146 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6147 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6148
6149 // Verify that the new value propagated down to the encoder.
6150 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6151 // VideoStreams are created appropriately for the simulcast case.
6152 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6153 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6154 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6155 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6156 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6157 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6158 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6159 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6160 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6161 // Layer 2: min and max bitrate not configured, default expected.
6162 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6163 stream->GetVideoStreams()[2].min_bitrate_bps);
6164 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6165 stream->GetVideoStreams()[2].target_bitrate_bps);
6166 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6167 stream->GetVideoStreams()[2].max_bitrate_bps);
6168
6169 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6170}
6171
6172TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6173 const size_t kNumSimulcastStreams = 3;
6174 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6175 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6176
6177 // Send a full size frame so all simulcast layers are used when reconfiguring.
6178 FakeVideoCapturerWithTaskQueue capturer;
6179 VideoOptions options;
6180 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6181 EXPECT_EQ(cricket::CS_RUNNING,
6182 capturer.Start(capturer.GetSupportedFormats()->front()));
6183 channel_->SetSend(true);
6184 EXPECT_TRUE(capturer.CaptureFrame());
6185
6186 // Set max bitrate for all but the highest layer.
6187 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6188 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6189 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6190 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6191 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6192
6193 // Set max bandwidth equal to total max bitrate.
6194 send_parameters_.max_bandwidth_bps =
6195 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6196 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6197 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6198
6199 // No bitrate above the total max to give to the highest layer.
6200 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6201 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6202 stream->GetVideoStreams()[2].max_bitrate_bps);
6203
6204 // Set max bandwidth above the total max bitrate.
6205 send_parameters_.max_bandwidth_bps =
6206 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6207 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6208 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6209
6210 // The highest layer has no max bitrate set -> the bitrate above the total
6211 // max should be given to the highest layer.
6212 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6213 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6214 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6215 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6216 stream->GetVideoStreams()[2].max_bitrate_bps);
6217
6218 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6219}
6220
6221TEST_F(WebRtcVideoChannelTest,
6222 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6223 const size_t kNumSimulcastStreams = 3;
6224 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6225 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6226 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6227
6228 // Send a full size frame so all simulcast layers are used when reconfiguring.
6229 FakeVideoCapturerWithTaskQueue capturer;
6230 VideoOptions options;
6231 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6232 EXPECT_EQ(cricket::CS_RUNNING,
6233 capturer.Start(capturer.GetSupportedFormats()->front()));
6234 channel_->SetSend(true);
6235 EXPECT_TRUE(capturer.CaptureFrame());
6236
6237 // Set max bitrate for the highest layer.
6238 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6239 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6240 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6241 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6242
6243 // Set max bandwidth above the total max bitrate.
6244 send_parameters_.max_bandwidth_bps =
6245 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6246 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6247 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6248
6249 // The highest layer has the max bitrate set -> the bitrate above the total
6250 // max should not be given to the highest layer.
6251 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6252 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6253 stream->GetVideoStreams()[2].max_bitrate_bps);
6254
6255 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6256}
6257
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006258// Test that min and max bitrate values set via RtpParameters are correctly
6259// propagated to the underlying encoder for a single stream.
6260TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6261 FakeVideoSendStream* stream = AddSendStream();
6262 EXPECT_TRUE(channel_->SetSend(true));
6263 EXPECT_TRUE(stream->IsSending());
6264
6265 // Set min and max bitrate.
6266 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6267 EXPECT_EQ(1u, parameters.encodings.size());
6268 parameters.encodings[0].min_bitrate_bps = 80000;
6269 parameters.encodings[0].max_bitrate_bps = 150000;
6270 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6271
6272 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6273 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6274 EXPECT_EQ(1u, encoder_config.number_of_streams);
6275 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6276 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6277 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6278
6279 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6280 // VideoStreams are created appropriately.
6281 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6282 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6283 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6284 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6285}
6286
6287// Test the default min and max bitrate value are correctly propagated to the
6288// underlying encoder for a single stream (when the values are not set via
6289// RtpParameters).
6290TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6291 FakeVideoSendStream* stream = AddSendStream();
6292 EXPECT_TRUE(channel_->SetSend(true));
6293 EXPECT_TRUE(stream->IsSending());
6294
6295 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6296 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6297 EXPECT_EQ(1u, encoder_config.number_of_streams);
6298 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6299 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6300 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6301
6302 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6303 // VideoStreams are created appropriately.
6304 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6305 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6306 stream->GetVideoStreams()[0].min_bitrate_bps);
6307 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6308 stream->GetVideoStreams()[0].min_bitrate_bps);
6309 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6310 stream->GetVideoStreams()[0].target_bitrate_bps);
6311}
6312
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006313// Test that a stream will not be sending if its encoding is made inactive
6314// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006315TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006316 FakeVideoSendStream* stream = AddSendStream();
6317 EXPECT_TRUE(channel_->SetSend(true));
6318 EXPECT_TRUE(stream->IsSending());
6319
6320 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006321 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006322 ASSERT_EQ(1u, parameters.encodings.size());
6323 ASSERT_TRUE(parameters.encodings[0].active);
6324 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006325 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006326 EXPECT_FALSE(stream->IsSending());
6327
6328 // Now change it back to active and verify we resume sending.
6329 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006330 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006331 EXPECT_TRUE(stream->IsSending());
6332}
6333
Seth Hampson8234ead2018-02-02 15:16:24 -08006334// Tests that when active is updated for any simulcast layer then the send
6335// stream's sending state will be updated and it will be reconfigured with the
6336// new appropriate active simulcast streams.
6337TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6338 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006339 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006340 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6341 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6342 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6343 uint32_t primary_ssrc = stream_params.first_ssrc();
6344
Tommi85959932018-02-07 19:26:06 +01006345 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
6346 // frame. This allows us to test that ReconfigureEncoder is called
6347 // appropriately.
6348 cricket::FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson8234ead2018-02-02 15:16:24 -08006349 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02006350 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson8234ead2018-02-02 15:16:24 -08006351 EXPECT_EQ(cricket::CS_RUNNING,
6352 capturer.Start(cricket::VideoFormat(
6353 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
6354 cricket::FOURCC_I420)));
6355 channel_->SetSend(true);
6356 EXPECT_TRUE(capturer.CaptureFrame());
6357
6358 // Check that all encodings are initially active.
6359 webrtc::RtpParameters parameters =
6360 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006361 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006362 EXPECT_TRUE(parameters.encodings[0].active);
6363 EXPECT_TRUE(parameters.encodings[1].active);
6364 EXPECT_TRUE(parameters.encodings[2].active);
6365 EXPECT_TRUE(fake_video_send_stream->IsSending());
6366
6367 // Only turn on only the middle stream.
6368 parameters.encodings[0].active = false;
6369 parameters.encodings[1].active = true;
6370 parameters.encodings[2].active = false;
6371 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6372 // Verify that the active fields are set on the VideoChannel.
6373 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006374 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006375 EXPECT_FALSE(parameters.encodings[0].active);
6376 EXPECT_TRUE(parameters.encodings[1].active);
6377 EXPECT_FALSE(parameters.encodings[2].active);
6378 // Check that the VideoSendStream is updated appropriately. This means its
6379 // send state was updated and it was reconfigured.
6380 EXPECT_TRUE(fake_video_send_stream->IsSending());
6381 std::vector<webrtc::VideoStream> simulcast_streams =
6382 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006383 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006384 EXPECT_FALSE(simulcast_streams[0].active);
6385 EXPECT_TRUE(simulcast_streams[1].active);
6386 EXPECT_FALSE(simulcast_streams[2].active);
6387
6388 // Turn off all streams.
6389 parameters.encodings[0].active = false;
6390 parameters.encodings[1].active = false;
6391 parameters.encodings[2].active = false;
6392 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6393 // Verify that the active fields are set on the VideoChannel.
6394 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006395 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006396 EXPECT_FALSE(parameters.encodings[0].active);
6397 EXPECT_FALSE(parameters.encodings[1].active);
6398 EXPECT_FALSE(parameters.encodings[2].active);
6399 // Check that the VideoSendStream is off.
6400 EXPECT_FALSE(fake_video_send_stream->IsSending());
6401 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006402 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006403 EXPECT_FALSE(simulcast_streams[0].active);
6404 EXPECT_FALSE(simulcast_streams[1].active);
6405 EXPECT_FALSE(simulcast_streams[2].active);
6406
Niels Möllerff40b142018-04-09 08:49:14 +02006407 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08006408}
6409
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006410// Test that if a stream is reconfigured (due to a codec change or other
6411// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07006412TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006413 InactiveStreamDoesntStartSendingWhenReconfigured) {
6414 // Set an initial codec list, which will be modified later.
6415 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08006416 parameters1.codecs.push_back(GetEngineCodec("VP8"));
6417 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006418 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
6419
6420 FakeVideoSendStream* stream = AddSendStream();
6421 EXPECT_TRUE(channel_->SetSend(true));
6422 EXPECT_TRUE(stream->IsSending());
6423
6424 // Get current parameters and change "active" to false.
6425 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6426 ASSERT_EQ(1u, parameters.encodings.size());
6427 ASSERT_TRUE(parameters.encodings[0].active);
6428 parameters.encodings[0].active = false;
6429 EXPECT_EQ(1u, GetFakeSendStreams().size());
6430 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08006431 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006432 EXPECT_FALSE(stream->IsSending());
6433
6434 // Reorder the codec list, causing the stream to be reconfigured.
6435 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08006436 parameters2.codecs.push_back(GetEngineCodec("VP9"));
6437 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006438 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
6439 auto new_streams = GetFakeSendStreams();
6440 // Assert that a new underlying stream was created due to the codec change.
6441 // Otherwise, this test isn't testing what it set out to test.
6442 EXPECT_EQ(1u, GetFakeSendStreams().size());
6443 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
6444
6445 // Verify that we still are not sending anything, due to the inactive
6446 // encoding.
6447 EXPECT_FALSE(new_streams[0]->IsSending());
6448}
6449
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006450// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006451TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006452 AddSendStream();
6453 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006454 parameters.codecs.push_back(GetEngineCodec("VP8"));
6455 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006456 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6457
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006458 webrtc::RtpParameters rtp_parameters =
6459 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006460 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006461 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6462 rtp_parameters.codecs[0]);
6463 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6464 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006465}
6466
Florent Castellidacec712018-05-24 16:24:21 +02006467// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
6468TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
6469 StreamParams params = StreamParams::CreateLegacy(kSsrc);
6470 params.cname = "rtcpcname";
6471 AddSendStream(params);
6472
6473 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
6474 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
6475}
6476
deadbeeffb2aced2017-01-06 23:05:37 -08006477// Test that RtpParameters for send stream has one encoding and it has
6478// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006479TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08006480 AddSendStream();
6481
6482 webrtc::RtpParameters rtp_parameters =
6483 channel_->GetRtpSendParameters(last_ssrc_);
6484 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006485 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08006486}
6487
Florent Castelliabe301f2018-06-12 18:33:49 +02006488TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
6489 AddSendStream();
6490
6491 webrtc::RtpParameters rtp_parameters =
6492 channel_->GetRtpSendParameters(last_ssrc_);
6493 rtp_parameters.header_extensions.emplace_back();
6494
6495 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
6496
6497 webrtc::RTCError result =
6498 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6499 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
6500}
6501
Florent Castelli87b3c512018-07-18 16:00:28 +02006502TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
6503 AddSendStream();
6504
6505 FakeVideoCapturerWithTaskQueue capturer;
6506 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
6507
6508 webrtc::RtpParameters rtp_parameters =
6509 channel_->GetRtpSendParameters(last_ssrc_);
6510 EXPECT_EQ(rtp_parameters.degradation_preference,
6511 webrtc::DegradationPreference::BALANCED);
6512 rtp_parameters.degradation_preference =
6513 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
6514
6515 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
6516
6517 webrtc::RtpParameters updated_rtp_parameters =
6518 channel_->GetRtpSendParameters(last_ssrc_);
6519 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
6520 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
6521
6522 // Remove the source since it will be destroyed before the channel
6523 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6524}
6525
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006526// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006527TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006528 AddSendStream();
6529 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006530 parameters.codecs.push_back(GetEngineCodec("VP8"));
6531 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006532 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6533
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006534 webrtc::RtpParameters initial_params =
6535 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006536
6537 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08006538 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006539
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006540 // ... And this shouldn't change the params returned by GetRtpSendParameters.
6541 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
6542}
6543
6544// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006545TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006546 AddRecvStream();
6547 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006548 parameters.codecs.push_back(GetEngineCodec("VP8"));
6549 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006550 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6551
6552 webrtc::RtpParameters rtp_parameters =
6553 channel_->GetRtpReceiveParameters(last_ssrc_);
6554 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006555 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6556 rtp_parameters.codecs[0]);
6557 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6558 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006559}
6560
johan073ece42016-08-26 02:59:47 -07006561#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07006562TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006563#else
eladalonf1841382017-06-12 01:16:46 -07006564TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006565#endif
johan3859c892016-08-05 09:19:25 -07006566 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07006567 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08006568 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07006569 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07006570 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08006571 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07006572 parameters.codecs.push_back(kH264sprop2);
6573 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6574
6575 FakeVideoReceiveStream* recv_stream = AddRecvStream();
6576 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
6577 webrtc::RtpParameters rtp_parameters =
6578 channel_->GetRtpReceiveParameters(last_ssrc_);
6579 ASSERT_EQ(2u, rtp_parameters.codecs.size());
6580 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
6581 ASSERT_EQ(2u, cfg.decoders.size());
6582 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006583 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006584 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006585 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
6586 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006587 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07006588
6589 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006590 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006591 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006592 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
6593 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006594 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07006595}
6596
sakal1fd95952016-06-22 00:46:15 -07006597// Test that RtpParameters for receive stream has one encoding and it has
6598// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006599TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07006600 AddRecvStream();
6601
6602 webrtc::RtpParameters rtp_parameters =
6603 channel_->GetRtpReceiveParameters(last_ssrc_);
6604 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006605 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07006606}
6607
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006608// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006609TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006610 AddRecvStream();
6611 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006612 parameters.codecs.push_back(GetEngineCodec("VP8"));
6613 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006614 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6615
6616 webrtc::RtpParameters initial_params =
6617 channel_->GetRtpReceiveParameters(last_ssrc_);
6618
6619 // We should be able to set the params we just got.
6620 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
6621
6622 // ... And this shouldn't change the params returned by
6623 // GetRtpReceiveParameters.
6624 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006625}
6626
deadbeef3bc15102017-04-20 19:25:07 -07006627// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
6628// aren't signaled. It should always return an empty "RtpEncodingParameters",
6629// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07006630TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07006631 // Call necessary methods to configure receiving a default stream as
6632 // soon as it arrives.
6633 cricket::VideoRecvParameters parameters;
6634 parameters.codecs.push_back(GetEngineCodec("VP8"));
6635 parameters.codecs.push_back(GetEngineCodec("VP9"));
6636 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6637
6638 // Call GetRtpReceiveParameters before configured to receive an unsignaled
6639 // stream. Should return nothing.
6640 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
6641
6642 // Set a sink for an unsignaled stream.
6643 cricket::FakeVideoRenderer renderer;
6644 // Value of "0" means "unsignaled stream".
6645 EXPECT_TRUE(channel_->SetSink(0, &renderer));
6646
6647 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
6648 // in this method means "unsignaled stream".
6649 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
6650 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6651 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6652
6653 // Receive VP8 packet.
6654 uint8_t data[kMinRtpPacketLen];
6655 cricket::RtpHeader rtpHeader;
6656 rtpHeader.payload_type = GetEngineCodec("VP8").id;
6657 rtpHeader.seq_num = rtpHeader.timestamp = 0;
6658 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
6659 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
6660 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
6661 rtc::PacketTime packet_time;
6662 channel_->OnPacketReceived(&packet, packet_time);
6663
6664 // The |ssrc| member should still be unset.
6665 rtp_parameters = channel_->GetRtpReceiveParameters(0);
6666 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6667 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6668}
6669
eladalonf1841382017-06-12 01:16:46 -07006670void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02006671 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006672 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02006673
6674 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02006675 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02006676 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02006677 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02006678
6679 if (receiver_first) {
6680 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6681 std::vector<FakeVideoReceiveStream*> receive_streams =
6682 fake_call_->GetVideoReceiveStreams();
6683 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02006684 // Default local SSRC when we have no sender.
6685 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6686 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006687 }
6688 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
6689 if (!receiver_first)
6690 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6691 std::vector<FakeVideoReceiveStream*> receive_streams =
6692 fake_call_->GetVideoReceiveStreams();
6693 ASSERT_EQ(1u, receive_streams.size());
6694 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02006695
6696 // Removing first sender should fall back to another (in this case the second)
6697 // local send stream's SSRC.
6698 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
6699 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006700 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006701 ASSERT_EQ(1u, receive_streams.size());
6702 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
6703
6704 // Removing the last sender should fall back to default local SSRC.
6705 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006706 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006707 ASSERT_EQ(1u, receive_streams.size());
6708 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6709 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006710}
6711
eladalonf1841382017-06-12 01:16:46 -07006712TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02006713 TestReceiverLocalSsrcConfiguration(false);
6714}
6715
eladalonf1841382017-06-12 01:16:46 -07006716TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02006717 TestReceiverLocalSsrcConfiguration(true);
6718}
6719
eladalonf1841382017-06-12 01:16:46 -07006720class WebRtcVideoChannelSimulcastTest : public testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006721 public:
eladalonf1841382017-06-12 01:16:46 -07006722 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01006723 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006724 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
6725 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +02006726 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006727 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02006728 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006729 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07006730 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006731
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00006732 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02006733 encoder_factory_->AddSupportedVideoCodecType("VP8");
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07006734 channel_.reset(engine_.CreateChannel(&fake_call_, GetMediaConfig(),
6735 VideoOptions(),
6736 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08006737 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006738 last_ssrc_ = 123;
6739 }
6740
6741 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006742 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07006743 int capture_width,
6744 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006745 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08006746 size_t expected_num_streams,
6747 bool screenshare,
6748 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006749 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006750 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08006751 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006752 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006753
Peter Boström0c4e06b2015-10-07 12:23:21 +02006754 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07006755 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006756 ssrcs.resize(num_configured_streams);
6757
sprangf24a0642017-02-28 13:23:26 -08006758 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006759 // Send a full-size frame to trigger a stream reconfiguration to use all
6760 // expected simulcast layers.
Tommi85959932018-02-07 19:26:06 +01006761 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08006762 VideoOptions options;
6763 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01006764 options.is_screencast = screenshare;
Yves Gerey665174f2018-06-19 15:03:05 +02006765 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08006766 // Fetch the latest stream since SetVideoSend() may recreate it if the
6767 // screen content setting is changed.
6768 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006769 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(cricket::VideoFormat(
perkj26752742016-10-24 01:21:16 -07006770 capture_width, capture_height,
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006771 cricket::VideoFormat::FpsToInterval(30),
6772 cricket::FOURCC_I420)));
6773 channel_->SetSend(true);
6774 EXPECT_TRUE(capturer.CaptureFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006775
Zach Stein3ca452b2018-01-18 10:01:24 -08006776 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
6777 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
6778
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006779 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6780 ASSERT_EQ(expected_num_streams, video_streams.size());
6781
sprang429600d2017-01-26 06:12:26 -08006782 std::vector<webrtc::VideoStream> expected_streams;
6783 if (conference_mode) {
6784 expected_streams = GetSimulcastConfig(
6785 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08006786 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02006787 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08006788 if (screenshare) {
6789 for (const webrtc::VideoStream& stream : expected_streams) {
6790 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00006791 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
6792 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08006793 }
6794 }
sprang429600d2017-01-26 06:12:26 -08006795 } else {
6796 webrtc::VideoStream stream;
6797 stream.width = capture_width;
6798 stream.height = capture_height;
6799 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01006800 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08006801 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006802 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08006803 stream.max_qp = kDefaultQpMax;
6804 expected_streams.push_back(stream);
6805 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006806
6807 ASSERT_EQ(expected_streams.size(), video_streams.size());
6808
6809 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006810 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006811 for (size_t i = 0; i < num_streams; ++i) {
6812 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
6813 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
6814
6815 EXPECT_GT(video_streams[i].max_framerate, 0);
6816 EXPECT_EQ(expected_streams[i].max_framerate,
6817 video_streams[i].max_framerate);
6818
6819 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
6820 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
6821 video_streams[i].min_bitrate_bps);
6822
6823 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
6824 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
6825 video_streams[i].target_bitrate_bps);
6826
6827 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
6828 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
6829 video_streams[i].max_bitrate_bps);
6830
6831 EXPECT_GT(video_streams[i].max_qp, 0);
6832 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
6833
Sergey Silkina796a7e2018-03-01 15:11:29 +01006834 EXPECT_EQ(conference_mode,
6835 expected_streams[i].num_temporal_layers.has_value());
6836
6837 if (conference_mode) {
6838 EXPECT_EQ(expected_streams[i].num_temporal_layers,
6839 video_streams[i].num_temporal_layers);
6840 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006841
6842 if (i == num_streams - 1) {
6843 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
6844 } else {
6845 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
6846 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006847 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006848
Niels Möllerff40b142018-04-09 08:49:14 +02006849 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006850 }
6851
6852 FakeVideoSendStream* AddSendStream() {
6853 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
6854 }
6855
6856 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006857 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006858 EXPECT_TRUE(channel_->AddSendStream(sp));
6859 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006860 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006861 EXPECT_EQ(num_streams + 1, streams.size());
6862 return streams[streams.size() - 1];
6863 }
6864
6865 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006866 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006867 }
6868
6869 FakeVideoReceiveStream* AddRecvStream() {
6870 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
6871 }
6872
6873 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006874 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006875 EXPECT_TRUE(channel_->AddRecvStream(sp));
6876 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006877 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006878 EXPECT_EQ(num_streams + 1, streams.size());
6879 return streams[streams.size() - 1];
6880 }
6881
skvlad11a9cbf2016-10-07 11:53:05 -07006882 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006883 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006884 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
6885 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -07006886 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08006887 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02006888 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006889};
6890
eladalonf1841382017-06-12 01:16:46 -07006891TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006892 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
6893 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006894}
6895
eladalonf1841382017-06-12 01:16:46 -07006896TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006897 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
6898 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006899}
6900
6901// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07006902TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08006903 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
6904 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006905}
sprang429600d2017-01-26 06:12:26 -08006906
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006907TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006908 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6909 false);
6910}
6911
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006912TEST_F(WebRtcVideoChannelSimulcastTest,
6913 SetSendCodecsForConferenceModeScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006914 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6915 true);
6916}
6917
eladalonf1841382017-06-12 01:16:46 -07006918TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
Erik Språngb65aa012018-09-24 11:35:19 +02006919 webrtc::test::ScopedFieldTrials override_field_trials_(
6920 "WebRTC-SimulcastScreenshare/Enabled/");
sprang429600d2017-01-26 06:12:26 -08006921 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
6922 true);
6923}
6924
eladalonf1841382017-06-12 01:16:46 -07006925TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07006926 NoSimulcastScreenshareWithoutConference) {
Erik Språngb65aa012018-09-24 11:35:19 +02006927 webrtc::test::ScopedFieldTrials override_field_trials_(
6928 "WebRTC-SimulcastScreenshare/Enabled/");
sprangfe627f32017-03-29 08:24:59 -07006929 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6930 false);
6931}
6932
Yves Gereyb6a89422018-10-08 10:08:32 +02006933class WebRtcVideoFakeClock {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006934 public:
Yves Gereyb6a89422018-10-08 10:08:32 +02006935 WebRtcVideoFakeClock() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006936 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1)); // avoid time=0
6937 }
6938 rtc::ScopedFakeClock fake_clock_;
6939};
6940
Yves Gereyb6a89422018-10-08 10:08:32 +02006941// The fake clock needs to be initialized before the call, and not
6942// destroyed until after all threads spawned by the test have been stopped.
6943// This mixin ensures that.
6944class WebRtcVideoChannelTestWithClock : public WebRtcVideoFakeClock,
6945 public WebRtcVideoChannelBaseTest {};
6946
Jonas Oreland49ac5952018-09-26 16:04:32 +02006947TEST_F(WebRtcVideoChannelTestWithClock, GetSources) {
6948 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
6949 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
6950
6951 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
6952
6953 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
6954 rtc::SetBE32(packet1.data() + 8, kSsrc);
6955 channel_->SetSink(kDefaultReceiveSsrc, NULL);
6956 EXPECT_TRUE(SetDefaultCodec());
6957 EXPECT_TRUE(SetSend(true));
6958 EXPECT_EQ(0, renderer_.num_rendered_frames());
6959 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
6960
6961 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
6962 EXPECT_EQ(1u, sources.size());
6963 EXPECT_EQ(webrtc::RtpSourceType::SSRC, sources[0].source_type());
6964 int64_t timestamp1 = sources[0].timestamp_ms();
6965
6966 // a new packet.
6967 int64_t timeDeltaMs = 1;
6968 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
6969 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
6970 int64_t timestamp2 = channel_->GetSources(kSsrc)[0].timestamp_ms();
6971 EXPECT_EQ(timestamp2, timestamp1 + timeDeltaMs);
6972
6973 // It only keeps 10s of history.
6974 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
6975 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
6976 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
6977}
6978
6979TEST_F(WebRtcVideoChannelTestWithClock, GetContributingSources) {
6980 uint8_t data1[] = {0x81, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
6981 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
6982
6983 uint32_t kCsrc = 4321u;
6984 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
6985 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
6986
6987 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
6988 rtc::SetBE32(packet1.data() + 8, kSsrc);
6989 rtc::SetBE32(packet1.data() + 12, kCsrc);
6990 channel_->SetSink(kDefaultReceiveSsrc, NULL);
6991 EXPECT_TRUE(SetDefaultCodec());
6992 EXPECT_TRUE(SetSend(true));
6993 EXPECT_EQ(0, renderer_.num_rendered_frames());
6994 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
6995
6996 {
6997 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
6998 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
6999 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7000 EXPECT_EQ(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7001 // 1 SSRC and 1 CSRC.
7002 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7003 [](const webrtc::RtpSource& source) {
7004 return source.source_type() ==
7005 webrtc::RtpSourceType::SSRC;
7006 }));
7007 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7008 [](const webrtc::RtpSource& source) {
7009 return source.source_type() ==
7010 webrtc::RtpSourceType::CSRC;
7011 }));
7012 }
7013 int64_t timestamp1 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7014
7015 // a new packet with only ssrc (i.e no csrc).
7016 uint8_t data2[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7017 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7018 rtc::CopyOnWriteBuffer packet2(data2, sizeof(data2));
7019 rtc::SetBE32(packet2.data() + 8, kSsrc);
7020
7021 int64_t timeDeltaMs = 1;
7022 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
7023 channel_->OnPacketReceived(&packet2, rtc::PacketTime());
7024
7025 {
7026 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7027 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7028 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7029 EXPECT_NE(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7030 // 1 SSRC and 1 CSRC.
7031 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7032 [](const webrtc::RtpSource& source) {
7033 return source.source_type() ==
7034 webrtc::RtpSourceType::SSRC;
7035 }));
7036 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7037 [](const webrtc::RtpSource& source) {
7038 return source.source_type() ==
7039 webrtc::RtpSourceType::CSRC;
7040 }));
7041 auto ssrcSource = std::find_if(
7042 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7043 return source.source_type() == webrtc::RtpSourceType::SSRC;
7044 });
7045 auto csrcSource = std::find_if(
7046 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7047 return source.source_type() == webrtc::RtpSourceType::CSRC;
7048 });
7049
7050 EXPECT_EQ(ssrcSource->timestamp_ms(), timestamp1 + timeDeltaMs);
7051 EXPECT_EQ(csrcSource->timestamp_ms(), timestamp1);
7052 }
7053
7054 // It only keeps 10s of history.
7055 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7056
7057 {
7058 ASSERT_EQ(1u, channel_->GetSources(kSsrc).size());
7059 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7060 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7061 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7062 [](const webrtc::RtpSource& source) {
7063 return source.source_type() ==
7064 webrtc::RtpSourceType::SSRC;
7065 }));
7066 EXPECT_EQ(0, std::count_if(sources.begin(), sources.end(),
7067 [](const webrtc::RtpSource& source) {
7068 return source.source_type() ==
7069 webrtc::RtpSourceType::CSRC;
7070 }));
7071 }
7072
7073 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7074 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7075 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7076}
7077
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007078} // namespace cricket