blob: 2ae5891a8545b623cb39cee8bc2e892ba0cd1a8c [file] [log] [blame]
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00001/*
phoglund@webrtc.org78088c22012-02-07 14:56:45 +00002 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00003 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
Jonas Olssona4d87372019-07-05 19:08:33 +020011#include "modules/rtp_rtcp/source/rtp_sender.h"
12
kwiberg84be5112016-04-27 01:19:58 -070013#include <memory>
danilchapb8b6fbb2015-12-10 05:05:27 -080014#include <vector>
15
Karl Wiberg918f50c2018-07-05 11:40:33 +020016#include "absl/memory/memory.h"
Per Kjellandere11b7d22019-02-21 07:55:59 +010017#include "api/transport/field_trial_based_config.h"
Erik Språngf93eda12019-01-16 17:10:57 +010018#include "api/video/video_codec_constants.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020019#include "api/video/video_timing.h"
Elad Alon4a87e1c2017-10-03 16:11:34 +020020#include "logging/rtc_event_log/events/rtc_event.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020021#include "logging/rtc_event_log/mock/mock_rtc_event_log.h"
22#include "modules/rtp_rtcp/include/rtp_cvo.h"
23#include "modules/rtp_rtcp/include/rtp_header_extension_map.h"
24#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Erik Språngaa59eca2019-07-24 14:52:55 +020025#include "modules/rtp_rtcp/include/rtp_packet_sender.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020026#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
27#include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
28#include "modules/rtp_rtcp/source/rtp_format_video_generic.h"
philipelb3e42a42018-09-13 10:57:14 +020029#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor.h"
30#include "modules/rtp_rtcp/source/rtp_generic_frame_descriptor_extension.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020031#include "modules/rtp_rtcp/source/rtp_header_extensions.h"
32#include "modules/rtp_rtcp/source/rtp_packet_received.h"
33#include "modules/rtp_rtcp/source/rtp_packet_to_send.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020034#include "modules/rtp_rtcp/source/rtp_sender_video.h"
35#include "modules/rtp_rtcp/source/rtp_utility.h"
36#include "rtc_base/arraysize.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020037#include "rtc_base/rate_limiter.h"
38#include "test/field_trial.h"
39#include "test/gmock.h"
40#include "test/gtest.h"
41#include "test/mock_transport.h"
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +000042
43namespace webrtc {
44
andrew@webrtc.org8a442592011-12-16 21:24:30 +000045namespace {
Elad Alond8d32482019-02-18 23:45:57 +010046enum : int { // The first valid value is 1.
47 kAbsoluteSendTimeExtensionId = 1,
48 kAudioLevelExtensionId,
Elad Alonccb9b752019-02-19 13:01:31 +010049 kGenericDescriptorId00,
50 kGenericDescriptorId01,
Elad Alond8d32482019-02-18 23:45:57 +010051 kMidExtensionId,
52 kRepairedRidExtensionId,
53 kRidExtensionId,
54 kTransmissionTimeOffsetExtensionId,
55 kTransportSequenceNumberExtensionId,
56 kVideoRotationExtensionId,
57 kVideoTimingExtensionId,
58};
59
andrew@webrtc.org8a442592011-12-16 21:24:30 +000060const int kPayload = 100;
Shao Changbine62202f2015-04-21 20:24:50 +080061const int kRtxPayload = 98;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000062const uint32_t kTimestamp = 10;
63const uint16_t kSeqNum = 33;
brandtr9dfff292016-11-14 05:14:50 -080064const uint32_t kSsrc = 725242;
Erik Språng9c771c22019-06-17 16:31:53 +020065const uint32_t kRtxSsrc = 12345;
66const uint32_t kFlexFecSsrc = 45678;
Erik Språng1fbfecd2019-08-26 19:00:05 +020067const uint16_t kTransportSequenceNumber = 1;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +000068const uint64_t kStartTime = 123456789;
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +000069const size_t kMaxPaddingSize = 224u;
Stefan Holmera246cfb2016-08-23 17:51:42 +020070const uint8_t kPayloadData[] = {47, 11, 32, 93, 89};
spranga8ae6f22017-09-04 07:23:56 -070071const int64_t kDefaultExpectedRetransmissionTimeMs = 125;
Amit Hilbuch77938e62018-12-21 09:23:38 -080072const char kNoRid[] = "";
73const char kNoMid[] = "";
andrew@webrtc.org8a442592011-12-16 21:24:30 +000074
Danil Chapovalov5e57b172016-09-02 19:15:59 +020075using ::testing::_;
Erik Språng30a276b2019-04-23 12:00:11 +020076using ::testing::AllOf;
Erik Språng214f5432019-06-20 15:09:58 +020077using ::testing::AtLeast;
78using ::testing::DoAll;
philipelb3e42a42018-09-13 10:57:14 +020079using ::testing::ElementsAre;
Danil Chapovalov5e57b172016-09-02 19:15:59 +020080using ::testing::ElementsAreArray;
Erik Språng30a276b2019-04-23 12:00:11 +020081using ::testing::Field;
Erik Språng478cb462019-06-26 15:49:27 +020082using ::testing::Gt;
sprang168794c2017-07-06 04:38:06 -070083using ::testing::Invoke;
Erik Språng9c771c22019-06-17 16:31:53 +020084using ::testing::NiceMock;
Erik Språng478cb462019-06-26 15:49:27 +020085using ::testing::Pointee;
86using ::testing::Property;
Erik Språng214f5432019-06-20 15:09:58 +020087using ::testing::Return;
88using ::testing::SaveArg;
Danil Chapovalov84ffb352018-09-25 18:59:09 +020089using ::testing::SizeIs;
Erik Språng9c771c22019-06-17 16:31:53 +020090using ::testing::StrictMock;
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +000091
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000092uint64_t ConvertMsToAbsSendTime(int64_t time_ms) {
Stefan Holmer0a87ffc2015-10-21 13:41:48 +020093 return (((time_ms << 18) + 500) / 1000) & 0x00ffffff;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000094}
95
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +000096class LoopbackTransportTest : public webrtc::Transport {
97 public:
Petter Strandmark26bc6692018-05-29 08:43:35 +020098 LoopbackTransportTest() : total_bytes_sent_(0) {
danilchap12ba1862016-10-26 02:41:55 -070099 receivers_extensions_.Register(kRtpExtensionTransmissionTimeOffset,
100 kTransmissionTimeOffsetExtensionId);
101 receivers_extensions_.Register(kRtpExtensionAbsoluteSendTime,
102 kAbsoluteSendTimeExtensionId);
103 receivers_extensions_.Register(kRtpExtensionTransportSequenceNumber,
104 kTransportSequenceNumberExtensionId);
105 receivers_extensions_.Register(kRtpExtensionVideoRotation,
106 kVideoRotationExtensionId);
107 receivers_extensions_.Register(kRtpExtensionAudioLevel,
108 kAudioLevelExtensionId);
ilnik04f4d122017-06-19 07:18:55 -0700109 receivers_extensions_.Register(kRtpExtensionVideoTiming,
110 kVideoTimingExtensionId);
Steve Anton296a0ce2018-03-22 15:17:27 -0700111 receivers_extensions_.Register(kRtpExtensionMid, kMidExtensionId);
Elad Alonccb9b752019-02-19 13:01:31 +0100112 receivers_extensions_.Register(kRtpExtensionGenericFrameDescriptor00,
113 kGenericDescriptorId00);
114 receivers_extensions_.Register(kRtpExtensionGenericFrameDescriptor01,
115 kGenericDescriptorId01);
Amit Hilbuch77938e62018-12-21 09:23:38 -0800116 receivers_extensions_.Register(kRtpExtensionRtpStreamId, kRidExtensionId);
117 receivers_extensions_.Register(kRtpExtensionRepairedRtpStreamId,
118 kRepairedRidExtensionId);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000119 }
danilchap12ba1862016-10-26 02:41:55 -0700120
stefan1d8a5062015-10-02 03:39:33 -0700121 bool SendRtp(const uint8_t* data,
122 size_t len,
123 const PacketOptions& options) override {
Petter Strandmark26bc6692018-05-29 08:43:35 +0200124 last_options_ = options;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000125 total_bytes_sent_ += len;
danilchap12ba1862016-10-26 02:41:55 -0700126 sent_packets_.push_back(RtpPacketReceived(&receivers_extensions_));
127 EXPECT_TRUE(sent_packets_.back().Parse(data, len));
pbos2d566682015-09-28 09:59:31 -0700128 return true;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000129 }
danilchap162abd32015-12-10 02:39:40 -0800130 bool SendRtcp(const uint8_t* data, size_t len) override { return false; }
danilchap12ba1862016-10-26 02:41:55 -0700131 const RtpPacketReceived& last_sent_packet() { return sent_packets_.back(); }
132 int packets_sent() { return sent_packets_.size(); }
133
pbos@webrtc.org72491b92014-07-10 16:24:54 +0000134 size_t total_bytes_sent_;
Petter Strandmark26bc6692018-05-29 08:43:35 +0200135 PacketOptions last_options_;
danilchap12ba1862016-10-26 02:41:55 -0700136 std::vector<RtpPacketReceived> sent_packets_;
137
138 private:
139 RtpHeaderExtensionMap receivers_extensions_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000140};
141
Elad Alon4a87e1c2017-10-03 16:11:34 +0200142MATCHER_P(SameRtcEventTypeAs, value, "") {
143 return value == arg->GetType();
144}
145
Erik Språngf6468d22019-07-05 16:53:43 +0200146struct TestConfig {
Erik Språngf5815fa2019-08-21 14:27:31 +0200147 explicit TestConfig(bool with_overhead) : with_overhead(with_overhead) {}
Erik Språngf6468d22019-07-05 16:53:43 +0200148 bool with_overhead = false;
Erik Språngf6468d22019-07-05 16:53:43 +0200149};
150
151std::string ToFieldTrialString(TestConfig config) {
152 std::string field_trials;
153 if (config.with_overhead) {
154 field_trials += "WebRTC-SendSideBwe-WithOverhead/Enabled/";
155 }
Erik Språngf6468d22019-07-05 16:53:43 +0200156 return field_trials;
157}
158
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000159} // namespace
160
Erik Språngaa59eca2019-07-24 14:52:55 +0200161class MockRtpPacketPacer : public RtpPacketSender {
sprangebbf8a82015-09-21 15:11:14 -0700162 public:
Erik Språng59b86542019-06-23 18:24:46 +0200163 MockRtpPacketPacer() {}
164 virtual ~MockRtpPacketPacer() {}
165
166 MOCK_METHOD1(EnqueuePacket, void(std::unique_ptr<RtpPacketToSend>));
sprangebbf8a82015-09-21 15:11:14 -0700167
Erik Språngaa59eca2019-07-24 14:52:55 +0200168 MOCK_METHOD2(CreateProbeCluster, void(int bitrate_bps, int cluster_id));
169
170 MOCK_METHOD0(Pause, void());
171 MOCK_METHOD0(Resume, void());
172 MOCK_METHOD1(SetCongestionWindow,
173 void(absl::optional<int64_t> congestion_window_bytes));
174 MOCK_METHOD1(UpdateOutstandingData, void(int64_t outstanding_bytes));
175 MOCK_METHOD1(SetAccountForAudioPackets, void(bool account_for_audio));
sprangebbf8a82015-09-21 15:11:14 -0700176};
177
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200178class MockSendSideDelayObserver : public SendSideDelayObserver {
179 public:
Henrik Boström9fe18342019-05-16 18:38:20 +0200180 MOCK_METHOD4(SendSideDelayUpdated, void(int, int, uint64_t, uint32_t));
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200181};
182
asapersson35151f32016-05-02 23:44:01 -0700183class MockSendPacketObserver : public SendPacketObserver {
184 public:
185 MOCK_METHOD3(OnSendPacket, void(uint16_t, int64_t, uint32_t));
186};
187
Stefan Holmera246cfb2016-08-23 17:51:42 +0200188class MockTransportFeedbackObserver : public TransportFeedbackObserver {
189 public:
Erik Språng30a276b2019-04-23 12:00:11 +0200190 MOCK_METHOD1(OnAddPacket, void(const RtpPacketSendInfo&));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200191 MOCK_METHOD1(OnTransportFeedback, void(const rtcp::TransportFeedback&));
elad.alonf9490002017-03-06 05:32:21 -0800192 MOCK_CONST_METHOD0(GetTransportFeedbackVector, std::vector<PacketFeedback>());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200193};
194
minyue3a407ee2017-04-03 01:10:33 -0700195class MockOverheadObserver : public OverheadObserver {
196 public:
197 MOCK_METHOD1(OnOverheadChanged, void(size_t overhead_bytes_per_packet));
198};
199
Erik Språngf6468d22019-07-05 16:53:43 +0200200class RtpSenderTest : public ::testing::TestWithParam<TestConfig> {
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000201 protected:
202 RtpSenderTest()
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000203 : fake_clock_(kStartTime),
terelius429c3452016-01-21 05:42:04 -0800204 mock_rtc_event_log_(),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000205 mock_paced_sender_(),
sprangcd349d92016-07-13 09:11:28 -0700206 retransmission_rate_limiter_(&fake_clock_, 1000),
Erik Språng4580ca22019-07-04 10:38:43 +0200207 flexfec_sender_(0,
208 kFlexFecSsrc,
209 kSsrc,
210 "",
211 std::vector<RtpExtension>(),
212 std::vector<RtpExtensionSize>(),
213 nullptr,
214 &fake_clock_),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000215 rtp_sender_(),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000216 transport_(),
minyue3a407ee2017-04-03 01:10:33 -0700217 kMarkerBit(true),
Erik Språngf6468d22019-07-05 16:53:43 +0200218 field_trials_(ToFieldTrialString(GetParam())) {}
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000219
Erik Språng7b52f102018-02-07 14:37:37 +0100220 void SetUp() override { SetUpRtpSender(true, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200221
Erik Språng7b52f102018-02-07 14:37:37 +0100222 void SetUpRtpSender(bool pacer, bool populate_network2) {
Erik Språng4580ca22019-07-04 10:38:43 +0200223 RtpRtcp::Configuration config;
224 config.clock = &fake_clock_;
225 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200226 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200227 config.rtx_send_ssrc = kRtxSsrc;
228 config.flexfec_sender = &flexfec_sender_;
Erik Språng4580ca22019-07-04 10:38:43 +0200229 config.event_log = &mock_rtc_event_log_;
230 config.send_packet_observer = &send_packet_observer_;
231 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
232 config.paced_sender = pacer ? &mock_paced_sender_ : nullptr;
233 config.populate_network2_timestamp = populate_network2;
234 rtp_sender_.reset(new RTPSender(config));
brandtr9dfff292016-11-14 05:14:50 -0800235 rtp_sender_->SetSequenceNumber(kSeqNum);
danilchap71fead22016-08-18 02:01:49 -0700236 rtp_sender_->SetTimestampOffset(0);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000237 }
238
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000239 SimulatedClock fake_clock_;
Erik Språng9c771c22019-06-17 16:31:53 +0200240 NiceMock<MockRtcEventLog> mock_rtc_event_log_;
Erik Språng59b86542019-06-23 18:24:46 +0200241 MockRtpPacketPacer mock_paced_sender_;
Erik Språng9c771c22019-06-17 16:31:53 +0200242 StrictMock<MockSendPacketObserver> send_packet_observer_;
243 StrictMock<MockTransportFeedbackObserver> feedback_observer_;
sprangcd349d92016-07-13 09:11:28 -0700244 RateLimiter retransmission_rate_limiter_;
Erik Språng4580ca22019-07-04 10:38:43 +0200245 FlexfecSender flexfec_sender_;
kwiberg84be5112016-04-27 01:19:58 -0700246 std::unique_ptr<RTPSender> rtp_sender_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000247 LoopbackTransportTest transport_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000248 const bool kMarkerBit;
minyue3a407ee2017-04-03 01:10:33 -0700249 test::ScopedFieldTrials field_trials_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000250
danilchapb6f1fb52016-10-19 06:11:39 -0700251 std::unique_ptr<RtpPacketToSend> BuildRtpPacket(int payload_type,
252 bool marker_bit,
253 uint32_t timestamp,
254 int64_t capture_time_ms) {
255 auto packet = rtp_sender_->AllocatePacket();
256 packet->SetPayloadType(payload_type);
Erik Språng60ffc312019-07-30 22:03:49 +0200257 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
danilchapb6f1fb52016-10-19 06:11:39 -0700258 packet->SetMarker(marker_bit);
259 packet->SetTimestamp(timestamp);
260 packet->set_capture_time_ms(capture_time_ms);
261 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
262 return packet;
263 }
264
Erik Språngf6468d22019-07-05 16:53:43 +0200265 std::unique_ptr<RtpPacketToSend> SendPacket(int64_t capture_time_ms,
266 int payload_length) {
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000267 uint32_t timestamp = capture_time_ms * 90;
danilchapb6f1fb52016-10-19 06:11:39 -0700268 auto packet =
269 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
270 packet->AllocatePayload(payload_length);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000271
272 // Packet should be stored in a send bucket.
Erik Språngf6468d22019-07-05 16:53:43 +0200273 EXPECT_TRUE(rtp_sender_->SendToNetwork(
Erik Språng60ffc312019-07-30 22:03:49 +0200274 absl::make_unique<RtpPacketToSend>(*packet), kAllowRetransmission));
Erik Språngf6468d22019-07-05 16:53:43 +0200275 return packet;
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000276 }
asapersson35151f32016-05-02 23:44:01 -0700277
Erik Språngf6468d22019-07-05 16:53:43 +0200278 std::unique_ptr<RtpPacketToSend> SendGenericPacket() {
asapersson35151f32016-05-02 23:44:01 -0700279 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
Erik Språngf6468d22019-07-05 16:53:43 +0200280 return SendPacket(kCaptureTimeMs, sizeof(kPayloadData));
asapersson35151f32016-05-02 23:44:01 -0700281 }
Steve Anton2bac7da2019-07-21 15:04:21 -0400282
Erik Språng4208a132019-08-26 08:58:45 +0200283 size_t GenerateAndSendPadding(size_t target_size_bytes) {
284 size_t generated_bytes = 0;
285 for (auto& packet : rtp_sender_->GeneratePadding(target_size_bytes)) {
286 generated_bytes += packet->payload_size() + packet->padding_size();
287 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
288 }
289 return generated_bytes;
290 }
291
Steve Anton2bac7da2019-07-21 15:04:21 -0400292 // The following are helpers for configuring the RTPSender. They must be
293 // called before sending any packets.
294
295 // Enable the retransmission stream with sizable packet storage.
296 void EnableRtx() {
297 // RTX needs to be able to read the source packets from the packet store.
298 // Pick a number of packets to store big enough for any unit test.
299 constexpr uint16_t kNumberOfPacketsToStore = 100;
300 rtp_sender_->SetStorePacketsStatus(true, kNumberOfPacketsToStore);
301 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
302 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
303 }
304
305 // Enable sending of the MID header extension for both the primary SSRC and
306 // the RTX SSRC.
307 void EnableMidSending(const std::string& mid) {
308 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionMid, kMidExtensionId);
309 rtp_sender_->SetMid(mid);
310 }
311
312 // Enable sending of the RSID header extension for the primary SSRC and the
313 // RRSID header extension for the RTX SSRC.
314 void EnableRidSending(const std::string& rid) {
315 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionRtpStreamId,
316 kRidExtensionId);
317 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionRepairedRtpStreamId,
318 kRepairedRidExtensionId);
319 rtp_sender_->SetRid(rid);
320 }
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000321};
322
Peter Boströme23e7372015-10-08 11:44:14 +0200323// TODO(pbos): Move tests over from WithoutPacer to RtpSenderTest as this is our
324// default code path.
325class RtpSenderTestWithoutPacer : public RtpSenderTest {
326 public:
Erik Språng7b52f102018-02-07 14:37:37 +0100327 void SetUp() override { SetUpRtpSender(false, false); }
Peter Boströme23e7372015-10-08 11:44:14 +0200328};
329
minyue3a407ee2017-04-03 01:10:33 -0700330TEST_P(RtpSenderTestWithoutPacer, AllocatePacketSetCsrc) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200331 // Configure rtp_sender with csrc.
332 std::vector<uint32_t> csrcs;
333 csrcs.push_back(0x23456789);
334 rtp_sender_->SetCsrcs(csrcs);
335
336 auto packet = rtp_sender_->AllocatePacket();
337
338 ASSERT_TRUE(packet);
339 EXPECT_EQ(rtp_sender_->SSRC(), packet->Ssrc());
340 EXPECT_EQ(csrcs, packet->Csrcs());
341}
342
minyue3a407ee2017-04-03 01:10:33 -0700343TEST_P(RtpSenderTestWithoutPacer, AllocatePacketReserveExtensions) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200344 // Configure rtp_sender with extensions.
345 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
346 kRtpExtensionTransmissionTimeOffset,
347 kTransmissionTimeOffsetExtensionId));
348 ASSERT_EQ(
349 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
350 kAbsoluteSendTimeExtensionId));
351 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
352 kAudioLevelExtensionId));
353 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
354 kRtpExtensionTransportSequenceNumber,
355 kTransportSequenceNumberExtensionId));
356 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
357 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
358
359 auto packet = rtp_sender_->AllocatePacket();
360
361 ASSERT_TRUE(packet);
362 // Preallocate BWE extensions RtpSender set itself.
363 EXPECT_TRUE(packet->HasExtension<TransmissionOffset>());
364 EXPECT_TRUE(packet->HasExtension<AbsoluteSendTime>());
365 EXPECT_TRUE(packet->HasExtension<TransportSequenceNumber>());
366 // Do not allocate media specific extensions.
367 EXPECT_FALSE(packet->HasExtension<AudioLevel>());
368 EXPECT_FALSE(packet->HasExtension<VideoOrientation>());
369}
370
minyue3a407ee2017-04-03 01:10:33 -0700371TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberAdvanceSequenceNumber) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200372 auto packet = rtp_sender_->AllocatePacket();
373 ASSERT_TRUE(packet);
374 const uint16_t sequence_number = rtp_sender_->SequenceNumber();
375
376 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
377
378 EXPECT_EQ(sequence_number, packet->SequenceNumber());
379 EXPECT_EQ(sequence_number + 1, rtp_sender_->SequenceNumber());
380}
381
minyue3a407ee2017-04-03 01:10:33 -0700382TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberFailsOnNotSending) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200383 auto packet = rtp_sender_->AllocatePacket();
384 ASSERT_TRUE(packet);
385
386 rtp_sender_->SetSendingMediaStatus(false);
387 EXPECT_FALSE(rtp_sender_->AssignSequenceNumber(packet.get()));
388}
389
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100390TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberMayAllowPaddingOnVideo) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200391 constexpr size_t kPaddingSize = 100;
392 auto packet = rtp_sender_->AllocatePacket();
393 ASSERT_TRUE(packet);
394
Erik Språng4208a132019-08-26 08:58:45 +0200395 ASSERT_TRUE(rtp_sender_->GeneratePadding(kPaddingSize).empty());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200396 packet->SetMarker(false);
397 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100398 // Packet without marker bit doesn't allow padding on video stream.
Erik Språng4208a132019-08-26 08:58:45 +0200399 ASSERT_TRUE(rtp_sender_->GeneratePadding(kPaddingSize).empty());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200400
401 packet->SetMarker(true);
402 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
403 // Packet with marker bit allows send padding.
Erik Språng4208a132019-08-26 08:58:45 +0200404 ASSERT_FALSE(rtp_sender_->GeneratePadding(kPaddingSize).empty());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200405}
406
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100407TEST_P(RtpSenderTest, AssignSequenceNumberAllowsPaddingOnAudio) {
408 MockTransport transport;
Erik Språng4580ca22019-07-04 10:38:43 +0200409 RtpRtcp::Configuration config;
410 config.audio = true;
411 config.clock = &fake_clock_;
412 config.outgoing_transport = &transport;
413 config.paced_sender = &mock_paced_sender_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200414 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200415 config.event_log = &mock_rtc_event_log_;
416 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
417 rtp_sender_ = absl::make_unique<RTPSender>(config);
418
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100419 rtp_sender_->SetTimestampOffset(0);
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100420
421 std::unique_ptr<RtpPacketToSend> audio_packet = rtp_sender_->AllocatePacket();
422 // Padding on audio stream allowed regardless of marker in the last packet.
423 audio_packet->SetMarker(false);
424 audio_packet->SetPayloadType(kPayload);
425 rtp_sender_->AssignSequenceNumber(audio_packet.get());
426
427 const size_t kPaddingSize = 59;
428 EXPECT_CALL(transport, SendRtp(_, kPaddingSize + kRtpHeaderSize, _))
Erik Språng214f5432019-06-20 15:09:58 +0200429 .WillOnce(Return(true));
Erik Språng4208a132019-08-26 08:58:45 +0200430 EXPECT_EQ(kPaddingSize, GenerateAndSendPadding(kPaddingSize));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100431
432 // Requested padding size is too small, will send a larger one.
433 const size_t kMinPaddingSize = 50;
434 EXPECT_CALL(transport, SendRtp(_, kMinPaddingSize + kRtpHeaderSize, _))
Erik Språng214f5432019-06-20 15:09:58 +0200435 .WillOnce(Return(true));
Erik Språng4208a132019-08-26 08:58:45 +0200436 EXPECT_EQ(kMinPaddingSize, GenerateAndSendPadding(kMinPaddingSize - 5));
Danil Chapovalovb3179c72018-03-22 10:13:07 +0100437}
438
minyue3a407ee2017-04-03 01:10:33 -0700439TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberSetPaddingTimestamps) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200440 constexpr size_t kPaddingSize = 100;
441 auto packet = rtp_sender_->AllocatePacket();
442 ASSERT_TRUE(packet);
443 packet->SetMarker(true);
444 packet->SetTimestamp(kTimestamp);
445
446 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
Erik Språng4208a132019-08-26 08:58:45 +0200447 auto padding_packets = rtp_sender_->GeneratePadding(kPaddingSize);
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200448
Erik Språng4208a132019-08-26 08:58:45 +0200449 ASSERT_EQ(1u, padding_packets.size());
danilchap12ba1862016-10-26 02:41:55 -0700450 // Verify padding packet timestamp.
Erik Språng4208a132019-08-26 08:58:45 +0200451 EXPECT_EQ(kTimestamp, padding_packets[0]->Timestamp());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200452}
453
minyue3a407ee2017-04-03 01:10:33 -0700454TEST_P(RtpSenderTestWithoutPacer,
455 TransportFeedbackObserverGetsCorrectByteCount) {
456 constexpr int kRtpOverheadBytesPerPacket = 12 + 8;
Erik Språng9c771c22019-06-17 16:31:53 +0200457 NiceMock<MockOverheadObserver> mock_overhead_observer;
Erik Språng4580ca22019-07-04 10:38:43 +0200458
459 RtpRtcp::Configuration config;
460 config.clock = &fake_clock_;
461 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200462 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200463 config.transport_feedback_callback = &feedback_observer_;
464 config.event_log = &mock_rtc_event_log_;
465 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
466 config.overhead_observer = &mock_overhead_observer;
467 rtp_sender_ = absl::make_unique<RTPSender>(config);
468
minyue3a407ee2017-04-03 01:10:33 -0700469 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
470 kRtpExtensionTransportSequenceNumber,
471 kTransportSequenceNumberExtensionId));
minyue3a407ee2017-04-03 01:10:33 -0700472
473 const size_t expected_bytes =
Erik Språngf6468d22019-07-05 16:53:43 +0200474 GetParam().with_overhead
475 ? sizeof(kPayloadData) + kRtpOverheadBytesPerPacket
476 : sizeof(kPayloadData);
minyue3a407ee2017-04-03 01:10:33 -0700477
478 EXPECT_CALL(feedback_observer_,
Erik Språng30a276b2019-04-23 12:00:11 +0200479 OnAddPacket(AllOf(
480 Field(&RtpPacketSendInfo::ssrc, rtp_sender_->SSRC()),
481 Field(&RtpPacketSendInfo::transport_sequence_number,
482 kTransportSequenceNumber),
483 Field(&RtpPacketSendInfo::rtp_sequence_number,
484 rtp_sender_->SequenceNumber()),
485 Field(&RtpPacketSendInfo::length, expected_bytes),
486 Field(&RtpPacketSendInfo::pacing_info, PacedPacketInfo()))))
minyue3a407ee2017-04-03 01:10:33 -0700487 .Times(1);
488 EXPECT_CALL(mock_overhead_observer,
489 OnOverheadChanged(kRtpOverheadBytesPerPacket))
490 .Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100491 SendGenericPacket();
minyue3a407ee2017-04-03 01:10:33 -0700492}
493
494TEST_P(RtpSenderTestWithoutPacer, SendsPacketsWithTransportSequenceNumber) {
Erik Språng4580ca22019-07-04 10:38:43 +0200495 RtpRtcp::Configuration config;
496 config.clock = &fake_clock_;
497 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200498 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200499 config.transport_feedback_callback = &feedback_observer_;
500 config.event_log = &mock_rtc_event_log_;
501 config.send_packet_observer = &send_packet_observer_;
502 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
503 rtp_sender_ = absl::make_unique<RTPSender>(config);
504
Stefan Holmerf5dca482016-01-27 12:58:51 +0100505 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
506 kRtpExtensionTransportSequenceNumber,
507 kTransportSequenceNumberExtensionId));
508
asapersson35151f32016-05-02 23:44:01 -0700509 EXPECT_CALL(send_packet_observer_,
510 OnSendPacket(kTransportSequenceNumber, _, _))
511 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700512
513 EXPECT_CALL(feedback_observer_,
Erik Språng30a276b2019-04-23 12:00:11 +0200514 OnAddPacket(AllOf(
515 Field(&RtpPacketSendInfo::ssrc, rtp_sender_->SSRC()),
516 Field(&RtpPacketSendInfo::transport_sequence_number,
517 kTransportSequenceNumber),
518 Field(&RtpPacketSendInfo::rtp_sequence_number,
519 rtp_sender_->SequenceNumber()),
520 Field(&RtpPacketSendInfo::pacing_info, PacedPacketInfo()))))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200521 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700522
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100523 SendGenericPacket();
Stefan Holmerf5dca482016-01-27 12:58:51 +0100524
danilchap12ba1862016-10-26 02:41:55 -0700525 const auto& packet = transport_.last_sent_packet();
526 uint16_t transport_seq_no;
527 ASSERT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
528 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200529 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200530 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200531}
532
533TEST_P(RtpSenderTestWithoutPacer, PacketOptionsNoRetransmission) {
Erik Språng4580ca22019-07-04 10:38:43 +0200534 RtpRtcp::Configuration config;
535 config.clock = &fake_clock_;
536 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200537 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200538 config.transport_feedback_callback = &feedback_observer_;
539 config.event_log = &mock_rtc_event_log_;
540 config.send_packet_observer = &send_packet_observer_;
541 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
542 rtp_sender_ = absl::make_unique<RTPSender>(config);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200543
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100544 SendGenericPacket();
Petter Strandmark26bc6692018-05-29 08:43:35 +0200545
546 EXPECT_FALSE(transport_.last_options_.is_retransmit);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100547}
548
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200549TEST_P(RtpSenderTestWithoutPacer,
550 SetsIncludedInFeedbackWhenTransportSequenceNumberExtensionIsRegistered) {
551 SetUpRtpSender(false, false);
552 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber,
553 kTransportSequenceNumberExtensionId);
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200554 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100555 SendGenericPacket();
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200556 EXPECT_TRUE(transport_.last_options_.included_in_feedback);
557}
558
559TEST_P(
560 RtpSenderTestWithoutPacer,
561 SetsIncludedInAllocationWhenTransportSequenceNumberExtensionIsRegistered) {
562 SetUpRtpSender(false, false);
563 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransportSequenceNumber,
564 kTransportSequenceNumberExtensionId);
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200565 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100566 SendGenericPacket();
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200567 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
568}
569
570TEST_P(RtpSenderTestWithoutPacer,
571 SetsIncludedInAllocationWhenForcedAsPartOfAllocation) {
572 SetUpRtpSender(false, false);
573 rtp_sender_->SetAsPartOfAllocation(true);
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100574 SendGenericPacket();
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200575 EXPECT_FALSE(transport_.last_options_.included_in_feedback);
576 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
577}
578
579TEST_P(RtpSenderTestWithoutPacer, DoesnSetIncludedInAllocationByDefault) {
580 SetUpRtpSender(false, false);
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100581 SendGenericPacket();
Sebastian Jansson1bca65b2018-10-10 09:58:08 +0200582 EXPECT_FALSE(transport_.last_options_.included_in_feedback);
583 EXPECT_FALSE(transport_.last_options_.included_in_allocation);
stefana23fc622016-07-28 07:56:38 -0700584}
asapersson35151f32016-05-02 23:44:01 -0700585
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200586TEST_P(RtpSenderTestWithoutPacer, OnSendSideDelayUpdated) {
Erik Språng9c771c22019-06-17 16:31:53 +0200587 StrictMock<MockSendSideDelayObserver> send_side_delay_observer_;
Erik Språng4580ca22019-07-04 10:38:43 +0200588
589 RtpRtcp::Configuration config;
590 config.clock = &fake_clock_;
591 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200592 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200593 config.send_side_delay_observer = &send_side_delay_observer_;
594 config.event_log = &mock_rtc_event_log_;
595 rtp_sender_ = absl::make_unique<RTPSender>(config);
596
Niels Möller5fe95102019-03-04 16:49:25 +0100597 PlayoutDelayOracle playout_delay_oracle;
Niels Möller59ab1cf2019-02-06 22:48:11 +0100598 RTPSenderVideo rtp_sender_video(&fake_clock_, rtp_sender_.get(), nullptr,
Elad Alona0e99432019-05-24 13:50:56 +0200599 &playout_delay_oracle, nullptr, false, false,
Niels Möller5fe95102019-03-04 16:49:25 +0100600 FieldTrialBasedConfig());
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200601
602 const uint8_t kPayloadType = 127;
Niels Möller8a40edd2019-01-24 18:04:44 +0100603 const char payload_name[] = "GENERIC";
Niels Möller59ab1cf2019-02-06 22:48:11 +0100604
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +0200605 rtp_sender_video.RegisterPayloadType(kPayloadType, payload_name,
606 /*raw_payload=*/false);
Niels Möller59ab1cf2019-02-06 22:48:11 +0100607
608 const uint32_t kCaptureTimeMsToRtpTimestamp = 90; // 90 kHz clock
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200609 RTPVideoHeader video_header;
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200610
Henrik Boström9fe18342019-05-16 18:38:20 +0200611 // Send packet with 10 ms send-side delay. The average, max and total should
612 // be 10 ms.
613 EXPECT_CALL(send_side_delay_observer_,
614 SendSideDelayUpdated(10, 10, 10, kSsrc))
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200615 .Times(1);
616 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
617 fake_clock_.AdvanceTimeMilliseconds(10);
Niels Möller59ab1cf2019-02-06 22:48:11 +0100618 EXPECT_TRUE(rtp_sender_video.SendVideo(
Niels Möller8f7ce222019-03-21 15:43:58 +0100619 VideoFrameType::kVideoFrameKey, kPayloadType,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200620 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
Niels Möller59ab1cf2019-02-06 22:48:11 +0100621 kPayloadData, sizeof(kPayloadData), nullptr, &video_header,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200622 kDefaultExpectedRetransmissionTimeMs));
623
Henrik Boström9fe18342019-05-16 18:38:20 +0200624 // Send another packet with 20 ms delay. The average, max and total should be
625 // 15, 20 and 30 ms respectively.
626 EXPECT_CALL(send_side_delay_observer_,
627 SendSideDelayUpdated(15, 20, 30, kSsrc))
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200628 .Times(1);
629 fake_clock_.AdvanceTimeMilliseconds(10);
Niels Möller59ab1cf2019-02-06 22:48:11 +0100630 EXPECT_TRUE(rtp_sender_video.SendVideo(
Niels Möller8f7ce222019-03-21 15:43:58 +0100631 VideoFrameType::kVideoFrameKey, kPayloadType,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200632 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
Niels Möller59ab1cf2019-02-06 22:48:11 +0100633 kPayloadData, sizeof(kPayloadData), nullptr, &video_header,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200634 kDefaultExpectedRetransmissionTimeMs));
635
636 // Send another packet at the same time, which replaces the last packet.
637 // Since this packet has 0 ms delay, the average is now 5 ms and max is 10 ms.
Henrik Boström9fe18342019-05-16 18:38:20 +0200638 // The total counter stays the same though.
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200639 // TODO(terelius): Is is not clear that this is the right behavior.
Henrik Boström9fe18342019-05-16 18:38:20 +0200640 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(5, 10, 30, kSsrc))
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200641 .Times(1);
642 capture_time_ms = fake_clock_.TimeInMilliseconds();
Niels Möller59ab1cf2019-02-06 22:48:11 +0100643 EXPECT_TRUE(rtp_sender_video.SendVideo(
Niels Möller8f7ce222019-03-21 15:43:58 +0100644 VideoFrameType::kVideoFrameKey, kPayloadType,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200645 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
Niels Möller59ab1cf2019-02-06 22:48:11 +0100646 kPayloadData, sizeof(kPayloadData), nullptr, &video_header,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200647 kDefaultExpectedRetransmissionTimeMs));
648
649 // Send a packet 1 second later. The earlier packets should have timed
Henrik Boström9fe18342019-05-16 18:38:20 +0200650 // out, so both max and average should be the delay of this packet. The total
651 // keeps increasing.
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200652 fake_clock_.AdvanceTimeMilliseconds(1000);
653 capture_time_ms = fake_clock_.TimeInMilliseconds();
654 fake_clock_.AdvanceTimeMilliseconds(1);
Henrik Boström9fe18342019-05-16 18:38:20 +0200655 EXPECT_CALL(send_side_delay_observer_, SendSideDelayUpdated(1, 1, 31, kSsrc))
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200656 .Times(1);
Niels Möller59ab1cf2019-02-06 22:48:11 +0100657 EXPECT_TRUE(rtp_sender_video.SendVideo(
Niels Möller8f7ce222019-03-21 15:43:58 +0100658 VideoFrameType::kVideoFrameKey, kPayloadType,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200659 capture_time_ms * kCaptureTimeMsToRtpTimestamp, capture_time_ms,
Niels Möller59ab1cf2019-02-06 22:48:11 +0100660 kPayloadData, sizeof(kPayloadData), nullptr, &video_header,
Johannes Kron4a8a5e72018-09-26 09:57:48 +0200661 kDefaultExpectedRetransmissionTimeMs));
662}
663
minyue3a407ee2017-04-03 01:10:33 -0700664TEST_P(RtpSenderTestWithoutPacer, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700665 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
666 kRtpExtensionTransportSequenceNumber,
667 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700668 EXPECT_CALL(send_packet_observer_,
669 OnSendPacket(kTransportSequenceNumber, _, _))
670 .Times(1);
671
Niels Möllere7b9e6b2019-02-06 18:23:44 +0100672 SendGenericPacket();
asapersson35151f32016-05-02 23:44:01 -0700673}
674
minyue3a407ee2017-04-03 01:10:33 -0700675TEST_P(RtpSenderTest, SendsPacketsWithTransportSequenceNumber) {
Erik Språng4580ca22019-07-04 10:38:43 +0200676 RtpRtcp::Configuration config;
677 config.clock = &fake_clock_;
678 config.outgoing_transport = &transport_;
679 config.paced_sender = &mock_paced_sender_;
Erik Språng54d5d2c2019-08-20 17:22:36 +0200680 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +0200681 config.transport_feedback_callback = &feedback_observer_;
682 config.event_log = &mock_rtc_event_log_;
683 config.send_packet_observer = &send_packet_observer_;
684 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
685 rtp_sender_ = absl::make_unique<RTPSender>(config);
686
brandtr9dfff292016-11-14 05:14:50 -0800687 rtp_sender_->SetSequenceNumber(kSeqNum);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200688 rtp_sender_->SetStorePacketsStatus(true, 10);
689 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
690 kRtpExtensionTransportSequenceNumber,
691 kTransportSequenceNumberExtensionId));
692
Stefan Holmera246cfb2016-08-23 17:51:42 +0200693 EXPECT_CALL(send_packet_observer_,
694 OnSendPacket(kTransportSequenceNumber, _, _))
695 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700696 EXPECT_CALL(feedback_observer_,
Erik Språng30a276b2019-04-23 12:00:11 +0200697 OnAddPacket(AllOf(
698 Field(&RtpPacketSendInfo::ssrc, rtp_sender_->SSRC()),
699 Field(&RtpPacketSendInfo::transport_sequence_number,
700 kTransportSequenceNumber),
701 Field(&RtpPacketSendInfo::rtp_sequence_number,
702 rtp_sender_->SequenceNumber()),
703 Field(&RtpPacketSendInfo::pacing_info, PacedPacketInfo()))))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200704 .Times(1);
705
Erik Språngf5815fa2019-08-21 14:27:31 +0200706 EXPECT_CALL(
707 mock_paced_sender_,
708 EnqueuePacket(
709 AllOf(Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
710 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))));
711 auto packet = SendGenericPacket();
712 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
713 // Transport sequence number is set by PacketRouter, before TrySendPacket().
714 packet->SetExtension<TransportSequenceNumber>(kTransportSequenceNumber);
715 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200716
danilchap12ba1862016-10-26 02:41:55 -0700717 uint16_t transport_seq_no;
Erik Språngf5815fa2019-08-21 14:27:31 +0200718 EXPECT_TRUE(
719 transport_.last_sent_packet().GetExtension<TransportSequenceNumber>(
720 &transport_seq_no));
danilchap12ba1862016-10-26 02:41:55 -0700721 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
Petter Strandmark26bc6692018-05-29 08:43:35 +0200722 EXPECT_EQ(transport_.last_options_.packet_id, transport_seq_no);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200723}
724
Erik Språng7b52f102018-02-07 14:37:37 +0100725TEST_P(RtpSenderTest, WritesPacerExitToTimingExtension) {
ilnik04f4d122017-06-19 07:18:55 -0700726 rtp_sender_->SetStorePacketsStatus(true, 10);
727 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
728 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
729 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
730 auto packet = rtp_sender_->AllocatePacket();
731 packet->SetPayloadType(kPayload);
732 packet->SetMarker(true);
733 packet->SetTimestamp(kTimestamp);
734 packet->set_capture_time_ms(capture_time_ms);
ilnik2edc6842017-07-06 03:06:50 -0700735 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
ilnik04f4d122017-06-19 07:18:55 -0700736 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
737 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
738 size_t packet_size = packet->size();
ilnik04f4d122017-06-19 07:18:55 -0700739
740 const int kStoredTimeInMs = 100;
Erik Språngf5815fa2019-08-21 14:27:31 +0200741 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
742 EXPECT_CALL(mock_paced_sender_,
743 EnqueuePacket(Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc))));
744 EXPECT_TRUE(rtp_sender_->SendToNetwork(
745 absl::make_unique<RtpPacketToSend>(*packet), kAllowRetransmission));
746 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
747 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
ilnik04f4d122017-06-19 07:18:55 -0700748 EXPECT_EQ(1, transport_.packets_sent());
749 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
750
danilchapce251812017-09-11 12:24:41 -0700751 VideoSendTiming video_timing;
752 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
753 &video_timing));
754 EXPECT_EQ(kStoredTimeInMs, video_timing.pacer_exit_delta_ms);
Erik Språng7b52f102018-02-07 14:37:37 +0100755}
ilnik04f4d122017-06-19 07:18:55 -0700756
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100757TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtensionWithPacer) {
758 SetUpRtpSender(/*pacer=*/true, /*populate_network2=*/true);
Erik Språng7b52f102018-02-07 14:37:37 +0100759 rtp_sender_->SetStorePacketsStatus(true, 10);
760 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
761 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
762 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
763 auto packet = rtp_sender_->AllocatePacket();
764 packet->SetPayloadType(kPayload);
765 packet->SetMarker(true);
766 packet->SetTimestamp(kTimestamp);
767 packet->set_capture_time_ms(capture_time_ms);
768 const uint16_t kPacerExitMs = 1234u;
769 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, kPacerExitMs, 0u, 0u, true};
770 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
771 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
772 size_t packet_size = packet->size();
773
774 const int kStoredTimeInMs = 100;
Erik Språngf6468d22019-07-05 16:53:43 +0200775
Erik Språngf6468d22019-07-05 16:53:43 +0200776 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
777 EXPECT_CALL(
778 mock_paced_sender_,
779 EnqueuePacket(Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc))));
780 EXPECT_TRUE(rtp_sender_->SendToNetwork(
Erik Språngf5815fa2019-08-21 14:27:31 +0200781 absl::make_unique<RtpPacketToSend>(*packet), kAllowRetransmission));
Erik Språngf6468d22019-07-05 16:53:43 +0200782 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
783 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +0200784
Erik Språng7b52f102018-02-07 14:37:37 +0100785 EXPECT_EQ(1, transport_.packets_sent());
ilnik04f4d122017-06-19 07:18:55 -0700786 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
787
Erik Språng7b52f102018-02-07 14:37:37 +0100788 VideoSendTiming video_timing;
danilchapce251812017-09-11 12:24:41 -0700789 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
790 &video_timing));
Erik Språng7b52f102018-02-07 14:37:37 +0100791 EXPECT_EQ(kStoredTimeInMs, video_timing.network2_timestamp_delta_ms);
792 EXPECT_EQ(kPacerExitMs, video_timing.pacer_exit_delta_ms);
ilnik04f4d122017-06-19 07:18:55 -0700793}
794
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100795TEST_P(RtpSenderTest, WritesNetwork2ToTimingExtensionWithoutPacer) {
796 SetUpRtpSender(/*pacer=*/false, /*populate_network2=*/true);
797 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
798 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
799 auto packet = rtp_sender_->AllocatePacket();
800 packet->SetMarker(true);
801 packet->set_capture_time_ms(fake_clock_.TimeInMilliseconds());
802 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
803 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
804 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
Erik Språng1fbfecd2019-08-26 19:00:05 +0200805 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100806
807 const int kPropagateTimeMs = 10;
808 fake_clock_.AdvanceTimeMilliseconds(kPropagateTimeMs);
809
Erik Språngf5815fa2019-08-21 14:27:31 +0200810 EXPECT_TRUE(
811 rtp_sender_->SendToNetwork(std::move(packet), kAllowRetransmission));
Danil Chapovalovaf52b682018-11-27 10:48:27 +0100812
813 EXPECT_EQ(1, transport_.packets_sent());
814 absl::optional<VideoSendTiming> video_timing =
815 transport_.last_sent_packet().GetExtension<VideoTimingExtension>();
816 ASSERT_TRUE(video_timing);
817 EXPECT_EQ(kPropagateTimeMs, video_timing->network2_timestamp_delta_ms);
818}
819
minyue3a407ee2017-04-03 01:10:33 -0700820TEST_P(RtpSenderTest, TrafficSmoothingWithExtensions) {
Elad Alon4a87e1c2017-10-03 16:11:34 +0200821 EXPECT_CALL(mock_rtc_event_log_,
822 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000823
pwestin@webrtc.orgc66e8b32012-11-07 17:01:04 +0000824 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000825 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800826 kRtpExtensionTransmissionTimeOffset,
827 kTransmissionTimeOffsetExtensionId));
828 EXPECT_EQ(
829 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
830 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000831 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700832 auto packet =
833 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
834 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000835
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000836 const int kStoredTimeInMs = 100;
Erik Språngf6468d22019-07-05 16:53:43 +0200837 EXPECT_CALL(
838 mock_paced_sender_,
839 EnqueuePacket(AllOf(
840 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
841 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))));
842 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
843 EXPECT_TRUE(rtp_sender_->SendToNetwork(
844 absl::make_unique<RtpPacketToSend>(*packet), kAllowRetransmission));
845 EXPECT_EQ(0, transport_.packets_sent());
846 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
847 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000848
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000849 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700850 EXPECT_EQ(1, transport_.packets_sent());
851 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
852
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000853 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700854 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000855
856 // Verify transmission time offset.
857 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000858 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000859 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000860 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000861}
862
minyue3a407ee2017-04-03 01:10:33 -0700863TEST_P(RtpSenderTest, TrafficSmoothingRetransmits) {
Elad Alon4a87e1c2017-10-03 16:11:34 +0200864 EXPECT_CALL(mock_rtc_event_log_,
865 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000866
867 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000868 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800869 kRtpExtensionTransmissionTimeOffset,
870 kTransmissionTimeOffsetExtensionId));
871 EXPECT_EQ(
872 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
873 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000874 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700875 auto packet =
876 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
877 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000878
879 // Packet should be stored in a send bucket.
Erik Språngf6468d22019-07-05 16:53:43 +0200880 EXPECT_CALL(
881 mock_paced_sender_,
882 EnqueuePacket(AllOf(
883 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
884 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))));
885 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
886 packet->set_allow_retransmission(true);
887 EXPECT_TRUE(rtp_sender_->SendToNetwork(
888 absl::make_unique<RtpPacketToSend>(*packet), kAllowRetransmission));
889 // Immediately process send bucket and send packet.
890 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +0200891
Erik Språng0f4f0552019-05-08 10:15:05 -0700892 EXPECT_EQ(1, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000893
Erik Språng0f4f0552019-05-08 10:15:05 -0700894 // Retransmit packet.
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000895 const int kStoredTimeInMs = 100;
896 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
897
Erik Språng0f4f0552019-05-08 10:15:05 -0700898 EXPECT_CALL(mock_rtc_event_log_,
899 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)));
Erik Språngf6468d22019-07-05 16:53:43 +0200900 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
901 packet->set_retransmitted_sequence_number(kSeqNum);
902 EXPECT_CALL(
903 mock_paced_sender_,
904 EnqueuePacket(AllOf(
905 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
906 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))));
907 EXPECT_EQ(static_cast<int>(packet_size),
908 rtp_sender_->ReSendPacket(kSeqNum));
909 EXPECT_EQ(1, transport_.packets_sent());
910 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000911
912 // Process send bucket. Packet should now be sent.
Erik Språng0f4f0552019-05-08 10:15:05 -0700913 EXPECT_EQ(2, transport_.packets_sent());
danilchap12ba1862016-10-26 02:41:55 -0700914 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000915
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000916 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700917 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000918
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000919 // Verify transmission time offset.
920 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000921 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000922 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
923 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
924}
925
926// This test sends 1 regular video packet, then 4 padding packets, and then
927// 1 more regular packet.
minyue3a407ee2017-04-03 01:10:33 -0700928TEST_P(RtpSenderTest, SendPadding) {
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000929 // Make all (non-padding) packets go to send queue.
Elad Alon4a87e1c2017-10-03 16:11:34 +0200930 EXPECT_CALL(mock_rtc_event_log_,
931 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
932 .Times(1 + 4 + 1);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000933
934 uint16_t seq_num = kSeqNum;
935 uint32_t timestamp = kTimestamp;
936 rtp_sender_->SetStorePacketsStatus(true, 10);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000937 size_t rtp_header_len = kRtpHeaderSize;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000938 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800939 kRtpExtensionTransmissionTimeOffset,
940 kTransmissionTimeOffsetExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000941 rtp_header_len += 4; // 4 bytes extension.
danilchap162abd32015-12-10 02:39:40 -0800942 EXPECT_EQ(
943 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
944 kAbsoluteSendTimeExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000945 rtp_header_len += 4; // 4 bytes extension.
946 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
947
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000948 webrtc::RTPHeader rtp_header;
949
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000950 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700951 auto packet =
952 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200953 const uint32_t media_packet_timestamp = timestamp;
danilchapb6f1fb52016-10-19 06:11:39 -0700954 size_t packet_size = packet->size();
Erik Språngf6468d22019-07-05 16:53:43 +0200955 int total_packets_sent = 0;
956 const int kStoredTimeInMs = 100;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000957
958 // Packet should be stored in a send bucket.
Erik Språngf6468d22019-07-05 16:53:43 +0200959 EXPECT_CALL(
960 mock_paced_sender_,
961 EnqueuePacket(AllOf(
962 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
963 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))));
964 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
965 packet->set_allow_retransmission(true);
966 EXPECT_TRUE(rtp_sender_->SendToNetwork(
967 absl::make_unique<RtpPacketToSend>(*packet), kAllowRetransmission));
968 EXPECT_EQ(total_packets_sent, transport_.packets_sent());
969 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
970 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
971 ++seq_num;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000972
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000973 // Packet should now be sent. This test doesn't verify the regular video
974 // packet, since it is tested in another test.
danilchap12ba1862016-10-26 02:41:55 -0700975 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000976 timestamp += 90 * kStoredTimeInMs;
977
978 // Send padding 4 times, waiting 50 ms between each.
979 for (int i = 0; i < 4; ++i) {
980 const int kPaddingPeriodMs = 50;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000981 const size_t kPaddingBytes = 100;
982 const size_t kMaxPaddingLength = 224; // Value taken from rtp_sender.cc.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000983 // Padding will be forced to full packets.
Erik Språng4208a132019-08-26 08:58:45 +0200984 EXPECT_EQ(kMaxPaddingLength, GenerateAndSendPadding(kPaddingBytes));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000985
986 // Process send bucket. Padding should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700987 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000988 EXPECT_EQ(kMaxPaddingLength + rtp_header_len,
danilchap12ba1862016-10-26 02:41:55 -0700989 transport_.last_sent_packet().size());
990
991 transport_.last_sent_packet().GetHeader(&rtp_header);
pbosbd2522a2015-07-01 05:35:53 -0700992 EXPECT_EQ(kMaxPaddingLength, rtp_header.paddingLength);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000993
Stefan Holmer586b19b2015-09-18 11:14:31 +0200994 // Verify sequence number and timestamp. The timestamp should be the same
995 // as the last media packet.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000996 EXPECT_EQ(seq_num++, rtp_header.sequenceNumber);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200997 EXPECT_EQ(media_packet_timestamp, rtp_header.timestamp);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000998 // Verify transmission time offset.
Stefan Holmer586b19b2015-09-18 11:14:31 +0200999 int offset = timestamp - media_packet_timestamp;
1000 EXPECT_EQ(offset, rtp_header.extension.transmissionTimeOffset);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001001 uint64_t expected_send_time =
1002 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
1003 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
1004 fake_clock_.AdvanceTimeMilliseconds(kPaddingPeriodMs);
1005 timestamp += 90 * kPaddingPeriodMs;
1006 }
1007
1008 // Send a regular video packet again.
1009 capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -07001010 packet = BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
1011 packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001012
Erik Språngf6468d22019-07-05 16:53:43 +02001013 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
1014 EXPECT_CALL(
1015 mock_paced_sender_,
1016 EnqueuePacket(AllOf(
1017 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
1018 Pointee(Property(&RtpPacketToSend::SequenceNumber, seq_num)))));
1019 EXPECT_TRUE(rtp_sender_->SendToNetwork(
1020 absl::make_unique<RtpPacketToSend>(*packet), kAllowRetransmission));
1021 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
terelius5d332ac2016-01-14 14:37:39 -08001022
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001023 // Process send bucket.
danilchap12ba1862016-10-26 02:41:55 -07001024 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
1025 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
1026 transport_.last_sent_packet().GetHeader(&rtp_header);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +00001027
1028 // Verify sequence number and timestamp.
1029 EXPECT_EQ(seq_num, rtp_header.sequenceNumber);
1030 EXPECT_EQ(timestamp, rtp_header.timestamp);
1031 // Verify transmission time offset. This packet is sent without delay.
1032 EXPECT_EQ(0, rtp_header.extension.transmissionTimeOffset);
1033 uint64_t expected_send_time =
1034 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +00001035 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +00001036}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001037
minyue3a407ee2017-04-03 01:10:33 -07001038TEST_P(RtpSenderTest, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -07001039 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1040 kRtpExtensionTransportSequenceNumber,
1041 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -07001042 rtp_sender_->SetStorePacketsStatus(true, 10);
1043
1044 EXPECT_CALL(send_packet_observer_,
1045 OnSendPacket(kTransportSequenceNumber, _, _))
1046 .Times(1);
asapersson35151f32016-05-02 23:44:01 -07001047
Erik Språngf6468d22019-07-05 16:53:43 +02001048 EXPECT_CALL(
1049 mock_paced_sender_,
1050 EnqueuePacket(AllOf(
1051 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
1052 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))));
1053 auto packet = SendGenericPacket();
1054 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
1055 packet->SetExtension<TransportSequenceNumber>(kTransportSequenceNumber);
1056 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +02001057
danilchap12ba1862016-10-26 02:41:55 -07001058 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -07001059}
1060
minyue3a407ee2017-04-03 01:10:33 -07001061TEST_P(RtpSenderTest, OnSendPacketNotUpdatedForRetransmits) {
stefana23fc622016-07-28 07:56:38 -07001062 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1063 kRtpExtensionTransportSequenceNumber,
1064 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -07001065 rtp_sender_->SetStorePacketsStatus(true, 10);
1066
1067 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
asapersson35151f32016-05-02 23:44:01 -07001068
Erik Språngf6468d22019-07-05 16:53:43 +02001069 EXPECT_CALL(
1070 mock_paced_sender_,
1071 EnqueuePacket(AllOf(
1072 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
1073 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))));
1074 auto packet = SendGenericPacket();
1075 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
1076 packet->SetExtension<TransportSequenceNumber>(kTransportSequenceNumber);
1077 rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +02001078
danilchap12ba1862016-10-26 02:41:55 -07001079 EXPECT_EQ(1, transport_.packets_sent());
Petter Strandmark26bc6692018-05-29 08:43:35 +02001080 EXPECT_TRUE(transport_.last_options_.is_retransmit);
asapersson35151f32016-05-02 23:44:01 -07001081}
1082
minyue3a407ee2017-04-03 01:10:33 -07001083TEST_P(RtpSenderTestWithoutPacer, SendGenericVideo) {
Niels Möller8a40edd2019-01-24 18:04:44 +01001084 const char payload_name[] = "GENERIC";
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001085 const uint8_t payload_type = 127;
Niels Möller5fe95102019-03-04 16:49:25 +01001086 PlayoutDelayOracle playout_delay_oracle;
Niels Möller59ab1cf2019-02-06 22:48:11 +01001087 RTPSenderVideo rtp_sender_video(&fake_clock_, rtp_sender_.get(), nullptr,
Elad Alona0e99432019-05-24 13:50:56 +02001088 &playout_delay_oracle, nullptr, false, false,
Niels Möller5fe95102019-03-04 16:49:25 +01001089 FieldTrialBasedConfig());
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001090 rtp_sender_video.RegisterPayloadType(payload_type, payload_name,
1091 /*raw_payload=*/false);
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001092 uint8_t payload[] = {47, 11, 32, 93, 89};
1093
1094 // Send keyframe
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001095 RTPVideoHeader video_header;
Niels Möller59ab1cf2019-02-06 22:48:11 +01001096 ASSERT_TRUE(rtp_sender_video.SendVideo(
Niels Möller8f7ce222019-03-21 15:43:58 +01001097 VideoFrameType::kVideoFrameKey, payload_type, 1234, 4321, payload,
1098 sizeof(payload), nullptr, &video_header,
1099 kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001100
danilchap96c15872016-11-21 01:35:29 -08001101 auto sent_payload = transport_.last_sent_packet().payload();
1102 uint8_t generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001103 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
1104 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -08001105 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001106
1107 // Send delta frame
1108 payload[0] = 13;
1109 payload[1] = 42;
1110 payload[4] = 13;
1111
Niels Möller59ab1cf2019-02-06 22:48:11 +01001112 ASSERT_TRUE(rtp_sender_video.SendVideo(
Niels Möller8f7ce222019-03-21 15:43:58 +01001113 VideoFrameType::kVideoFrameDelta, payload_type, 1234, 4321, payload,
1114 sizeof(payload), nullptr, &video_header,
1115 kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001116
danilchap96c15872016-11-21 01:35:29 -08001117 sent_payload = transport_.last_sent_packet().payload();
1118 generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001119 EXPECT_FALSE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
1120 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -08001121 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001122}
1123
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001124TEST_P(RtpSenderTestWithoutPacer, SendRawVideo) {
1125 const char payload_name[] = "VP8";
1126 const uint8_t payload_type = 111;
1127 const uint8_t payload[] = {11, 22, 33, 44, 55};
1128
1129 PlayoutDelayOracle playout_delay_oracle;
1130 RTPSenderVideo rtp_sender_video(&fake_clock_, rtp_sender_.get(), nullptr,
Elad Alona0e99432019-05-24 13:50:56 +02001131 &playout_delay_oracle, nullptr, false, false,
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001132 FieldTrialBasedConfig());
1133 rtp_sender_video.RegisterPayloadType(payload_type, payload_name,
1134 /*raw_payload=*/true);
1135
1136 // Send a frame.
1137 RTPVideoHeader video_header;
1138 ASSERT_TRUE(rtp_sender_video.SendVideo(
1139 VideoFrameType::kVideoFrameKey, payload_type, 1234, 4321, payload,
1140 sizeof(payload), nullptr, &video_header,
1141 kDefaultExpectedRetransmissionTimeMs));
1142
1143 auto sent_payload = transport_.last_sent_packet().payload();
1144 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
1145}
1146
minyue3a407ee2017-04-03 01:10:33 -07001147TEST_P(RtpSenderTest, SendFlexfecPackets) {
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001148 constexpr uint32_t kTimestamp = 1234;
brandtrdbdb3f12016-11-10 05:04:48 -08001149 constexpr int kMediaPayloadType = 127;
1150 constexpr int kFlexfecPayloadType = 118;
brandtrdbdb3f12016-11-10 05:04:48 -08001151 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001152 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
Erik Språng4580ca22019-07-04 10:38:43 +02001153 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid,
1154 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001155 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001156
1157 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng4580ca22019-07-04 10:38:43 +02001158 RtpRtcp::Configuration config;
1159 config.clock = &fake_clock_;
1160 config.outgoing_transport = &transport_;
1161 config.paced_sender = &mock_paced_sender_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001162 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02001163 config.flexfec_sender = &flexfec_sender_;
Erik Språng4580ca22019-07-04 10:38:43 +02001164 config.event_log = &mock_rtc_event_log_;
1165 config.send_packet_observer = &send_packet_observer_;
1166 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
1167 rtp_sender_ = absl::make_unique<RTPSender>(config);
1168
brandtrdbdb3f12016-11-10 05:04:48 -08001169 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001170 rtp_sender_->SetStorePacketsStatus(true, 10);
1171
Niels Möller5fe95102019-03-04 16:49:25 +01001172 PlayoutDelayOracle playout_delay_oracle;
Elad Alona0e99432019-05-24 13:50:56 +02001173 RTPSenderVideo rtp_sender_video(
1174 &fake_clock_, rtp_sender_.get(), &flexfec_sender, &playout_delay_oracle,
1175 nullptr, false, false, FieldTrialBasedConfig());
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001176 rtp_sender_video.RegisterPayloadType(kMediaPayloadType, "GENERIC",
1177 /*raw_payload=*/false);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001178
brandtrdbdb3f12016-11-10 05:04:48 -08001179 // Parameters selected to generate a single FEC packet per media packet.
1180 FecProtectionParams params;
1181 params.fec_rate = 15;
1182 params.max_fec_frames = 1;
1183 params.fec_mask_type = kFecMaskRandom;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001184 rtp_sender_video.SetFecParameters(params, params);
brandtrdbdb3f12016-11-10 05:04:48 -08001185
brandtr9dfff292016-11-14 05:14:50 -08001186 uint16_t flexfec_seq_num;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001187 RTPVideoHeader video_header;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001188
Erik Språngf6468d22019-07-05 16:53:43 +02001189 std::unique_ptr<RtpPacketToSend> media_packet;
1190 std::unique_ptr<RtpPacketToSend> fec_packet;
1191
1192 EXPECT_CALL(mock_paced_sender_, EnqueuePacket)
1193 .Times(2)
1194 .WillRepeatedly([&](std::unique_ptr<RtpPacketToSend> packet) {
1195 if (packet->packet_type() == RtpPacketToSend::Type::kVideo) {
1196 EXPECT_EQ(packet->Ssrc(), kSsrc);
1197 EXPECT_EQ(packet->SequenceNumber(), kSeqNum);
1198 media_packet = std::move(packet);
1199 } else {
1200 EXPECT_EQ(packet->packet_type(),
1201 RtpPacketToSend::Type::kForwardErrorCorrection);
1202 EXPECT_EQ(packet->Ssrc(), kFlexFecSsrc);
1203 fec_packet = std::move(packet);
1204 }
1205 });
1206
1207 EXPECT_TRUE(rtp_sender_video.SendVideo(
1208 VideoFrameType::kVideoFrameKey, kMediaPayloadType, kTimestamp,
1209 fake_clock_.TimeInMilliseconds(), kPayloadData, sizeof(kPayloadData),
1210 nullptr, &video_header, kDefaultExpectedRetransmissionTimeMs));
1211 ASSERT_TRUE(media_packet != nullptr);
1212 ASSERT_TRUE(fec_packet != nullptr);
1213
1214 flexfec_seq_num = fec_packet->SequenceNumber();
1215 rtp_sender_->TrySendPacket(media_packet.get(), PacedPacketInfo());
1216 rtp_sender_->TrySendPacket(fec_packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +02001217
brandtr9dfff292016-11-14 05:14:50 -08001218 ASSERT_EQ(2, transport_.packets_sent());
Erik Språngf5815fa2019-08-21 14:27:31 +02001219 const RtpPacketReceived& sent_media_packet = transport_.sent_packets_[0];
1220 EXPECT_EQ(kMediaPayloadType, sent_media_packet.PayloadType());
1221 EXPECT_EQ(kSeqNum, sent_media_packet.SequenceNumber());
1222 EXPECT_EQ(kSsrc, sent_media_packet.Ssrc());
1223 const RtpPacketReceived& sent_flexfec_packet = transport_.sent_packets_[1];
1224 EXPECT_EQ(kFlexfecPayloadType, sent_flexfec_packet.PayloadType());
1225 EXPECT_EQ(flexfec_seq_num, sent_flexfec_packet.SequenceNumber());
1226 EXPECT_EQ(kFlexFecSsrc, sent_flexfec_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001227}
1228
Erik Språngf6468d22019-07-05 16:53:43 +02001229// TODO(ilnik): because of webrtc:7859. Once FEC moved below pacer, this test
1230// should be removed.
1231TEST_P(RtpSenderTest, NoFlexfecForTimingFrames) {
1232 constexpr uint32_t kTimestamp = 1234;
1233 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
1234 constexpr int kMediaPayloadType = 127;
1235 constexpr int kFlexfecPayloadType = 118;
1236 const std::vector<RtpExtension> kNoRtpExtensions;
1237 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
1238
1239 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid,
1240 kNoRtpExtensions, kNoRtpExtensionSizes,
1241 nullptr /* rtp_state */, &fake_clock_);
1242
1243 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng630443a2019-07-26 16:44:55 +02001244 RtpRtcp::Configuration config;
1245 config.clock = &fake_clock_;
1246 config.outgoing_transport = &transport_;
1247 config.paced_sender = &mock_paced_sender_;
1248 config.flexfec_sender = &flexfec_sender;
Erik Språng630443a2019-07-26 16:44:55 +02001249 config.event_log = &mock_rtc_event_log_;
1250 config.send_packet_observer = &send_packet_observer_;
1251 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001252 config.local_media_ssrc = kSsrc;
Erik Språng630443a2019-07-26 16:44:55 +02001253 rtp_sender_ = absl::make_unique<RTPSender>(config);
Erik Språngf6468d22019-07-05 16:53:43 +02001254 rtp_sender_->SetSequenceNumber(kSeqNum);
1255 rtp_sender_->SetStorePacketsStatus(true, 10);
1256
1257 PlayoutDelayOracle playout_delay_oracle;
1258 RTPSenderVideo rtp_sender_video(
1259 &fake_clock_, rtp_sender_.get(), &flexfec_sender, &playout_delay_oracle,
1260 nullptr, false, false, FieldTrialBasedConfig());
1261 rtp_sender_video.RegisterPayloadType(kMediaPayloadType, "GENERIC",
1262 /*raw_payload=*/false);
1263
1264 // Need extension to be registered for timing frames to be sent.
1265 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1266 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1267
1268 // Parameters selected to generate a single FEC packet per media packet.
1269 FecProtectionParams params;
1270 params.fec_rate = 15;
1271 params.max_fec_frames = 1;
1272 params.fec_mask_type = kFecMaskRandom;
1273 rtp_sender_video.SetFecParameters(params, params);
1274
1275 RTPVideoHeader video_header;
1276 video_header.video_timing.flags = VideoSendTiming::kTriggeredByTimer;
1277
1278 EXPECT_CALL(mock_rtc_event_log_,
1279 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1280 .Times(1);
Erik Språngf6468d22019-07-05 16:53:43 +02001281 std::unique_ptr<RtpPacketToSend> rtp_packet;
1282 EXPECT_CALL(
1283 mock_paced_sender_,
1284 EnqueuePacket(AllOf(
1285 Pointee(Property(&RtpPacketToSend::Ssrc, kSsrc)),
1286 Pointee(Property(&RtpPacketToSend::SequenceNumber, kSeqNum)))))
1287 .WillOnce([&rtp_packet](std::unique_ptr<RtpPacketToSend> packet) {
1288 rtp_packet = std::move(packet);
1289 });
1290
1291 EXPECT_CALL(
1292 mock_paced_sender_,
1293 EnqueuePacket(Pointee(Property(&RtpPacketToSend::Ssrc, kFlexFecSsrc))))
1294 .Times(0); // Not called because packet should not be protected.
1295
1296 EXPECT_TRUE(rtp_sender_video.SendVideo(
1297 VideoFrameType::kVideoFrameKey, kMediaPayloadType, kTimestamp,
1298 kCaptureTimeMs, kPayloadData, sizeof(kPayloadData), nullptr,
1299 &video_header, kDefaultExpectedRetransmissionTimeMs));
1300
1301 EXPECT_TRUE(
1302 rtp_sender_->TrySendPacket(rtp_packet.get(), PacedPacketInfo()));
Erik Språngf6468d22019-07-05 16:53:43 +02001303
1304 ASSERT_EQ(1, transport_.packets_sent());
Erik Språngf5815fa2019-08-21 14:27:31 +02001305 const RtpPacketReceived& sent_media_packet1 = transport_.sent_packets_[0];
1306 EXPECT_EQ(kMediaPayloadType, sent_media_packet1.PayloadType());
1307 EXPECT_EQ(kSeqNum, sent_media_packet1.SequenceNumber());
1308 EXPECT_EQ(kSsrc, sent_media_packet1.Ssrc());
Erik Språngf6468d22019-07-05 16:53:43 +02001309
1310 // Now try to send not a timing frame.
1311 uint16_t flexfec_seq_num;
1312
1313 EXPECT_CALL(mock_rtc_event_log_,
1314 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1315 .Times(2);
Erik Språngf5815fa2019-08-21 14:27:31 +02001316 std::unique_ptr<RtpPacketToSend> media_packet2;
1317 std::unique_ptr<RtpPacketToSend> fec_packet;
Erik Språngf6468d22019-07-05 16:53:43 +02001318
Erik Språngf5815fa2019-08-21 14:27:31 +02001319 EXPECT_CALL(mock_paced_sender_, EnqueuePacket)
1320 .Times(2)
1321 .WillRepeatedly([&](std::unique_ptr<RtpPacketToSend> packet) {
1322 if (packet->packet_type() == RtpPacketToSend::Type::kVideo) {
1323 EXPECT_EQ(packet->Ssrc(), kSsrc);
1324 EXPECT_EQ(packet->SequenceNumber(), kSeqNum + 1);
1325 media_packet2 = std::move(packet);
1326 } else {
1327 EXPECT_EQ(packet->packet_type(),
1328 RtpPacketToSend::Type::kForwardErrorCorrection);
1329 EXPECT_EQ(packet->Ssrc(), kFlexFecSsrc);
1330 fec_packet = std::move(packet);
1331 }
1332 });
Erik Språngf6468d22019-07-05 16:53:43 +02001333
Erik Språngf5815fa2019-08-21 14:27:31 +02001334 video_header.video_timing.flags = VideoSendTiming::kInvalid;
1335 EXPECT_TRUE(rtp_sender_video.SendVideo(
1336 VideoFrameType::kVideoFrameKey, kMediaPayloadType, kTimestamp + 1,
1337 kCaptureTimeMs + 1, kPayloadData, sizeof(kPayloadData), nullptr,
1338 &video_header, kDefaultExpectedRetransmissionTimeMs));
Erik Språngf6468d22019-07-05 16:53:43 +02001339
Erik Språngf5815fa2019-08-21 14:27:31 +02001340 ASSERT_TRUE(media_packet2 != nullptr);
1341 ASSERT_TRUE(fec_packet != nullptr);
Erik Språngf6468d22019-07-05 16:53:43 +02001342
Erik Språngf5815fa2019-08-21 14:27:31 +02001343 flexfec_seq_num = fec_packet->SequenceNumber();
1344 rtp_sender_->TrySendPacket(media_packet2.get(), PacedPacketInfo());
1345 rtp_sender_->TrySendPacket(fec_packet.get(), PacedPacketInfo());
Erik Språngf6468d22019-07-05 16:53:43 +02001346
1347 ASSERT_EQ(3, transport_.packets_sent());
Erik Språngf5815fa2019-08-21 14:27:31 +02001348 const RtpPacketReceived& sent_media_packet2 = transport_.sent_packets_[1];
1349 EXPECT_EQ(kMediaPayloadType, sent_media_packet2.PayloadType());
1350 EXPECT_EQ(kSeqNum + 1, sent_media_packet2.SequenceNumber());
1351 EXPECT_EQ(kSsrc, sent_media_packet2.Ssrc());
Erik Språngf6468d22019-07-05 16:53:43 +02001352 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[2];
1353 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1354 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1355 EXPECT_EQ(kFlexFecSsrc, flexfec_packet.Ssrc());
1356}
1357
minyue3a407ee2017-04-03 01:10:33 -07001358TEST_P(RtpSenderTestWithoutPacer, SendFlexfecPackets) {
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001359 constexpr uint32_t kTimestamp = 1234;
brandtrdbdb3f12016-11-10 05:04:48 -08001360 constexpr int kMediaPayloadType = 127;
1361 constexpr int kFlexfecPayloadType = 118;
brandtrdbdb3f12016-11-10 05:04:48 -08001362 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001363 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
Erik Språngf6468d22019-07-05 16:53:43 +02001364 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid,
Erik Språng4580ca22019-07-04 10:38:43 +02001365 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001366 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001367
1368 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng4580ca22019-07-04 10:38:43 +02001369 RtpRtcp::Configuration config;
1370 config.clock = &fake_clock_;
1371 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001372 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02001373 config.flexfec_sender = &flexfec_sender;
Erik Språng4580ca22019-07-04 10:38:43 +02001374 config.event_log = &mock_rtc_event_log_;
1375 config.send_packet_observer = &send_packet_observer_;
1376 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
1377 rtp_sender_ = absl::make_unique<RTPSender>(config);
1378
brandtrdbdb3f12016-11-10 05:04:48 -08001379 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtrdbdb3f12016-11-10 05:04:48 -08001380
Niels Möller5fe95102019-03-04 16:49:25 +01001381 PlayoutDelayOracle playout_delay_oracle;
Elad Alona0e99432019-05-24 13:50:56 +02001382 RTPSenderVideo rtp_sender_video(
1383 &fake_clock_, rtp_sender_.get(), &flexfec_sender, &playout_delay_oracle,
1384 nullptr, false, false, FieldTrialBasedConfig());
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001385 rtp_sender_video.RegisterPayloadType(kMediaPayloadType, "GENERIC",
1386 /*raw_payload=*/false);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001387
brandtrdbdb3f12016-11-10 05:04:48 -08001388 // Parameters selected to generate a single FEC packet per media packet.
1389 FecProtectionParams params;
1390 params.fec_rate = 15;
1391 params.max_fec_frames = 1;
1392 params.fec_mask_type = kFecMaskRandom;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001393 rtp_sender_video.SetFecParameters(params, params);
brandtrdbdb3f12016-11-10 05:04:48 -08001394
Elad Alon4a87e1c2017-10-03 16:11:34 +02001395 EXPECT_CALL(mock_rtc_event_log_,
1396 LogProxy(SameRtcEventTypeAs(RtcEvent::Type::RtpPacketOutgoing)))
1397 .Times(2);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001398 RTPVideoHeader video_header;
1399 EXPECT_TRUE(rtp_sender_video.SendVideo(
Niels Möller8f7ce222019-03-21 15:43:58 +01001400 VideoFrameType::kVideoFrameKey, kMediaPayloadType, kTimestamp,
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001401 fake_clock_.TimeInMilliseconds(), kPayloadData, sizeof(kPayloadData),
1402 nullptr, &video_header, kDefaultExpectedRetransmissionTimeMs));
1403
brandtrdbdb3f12016-11-10 05:04:48 -08001404 ASSERT_EQ(2, transport_.packets_sent());
1405 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1406 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
Erik Språng4580ca22019-07-04 10:38:43 +02001407 EXPECT_EQ(kSsrc, media_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001408 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1409 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
Erik Språngf6468d22019-07-05 16:53:43 +02001410 EXPECT_EQ(kFlexFecSsrc, flexfec_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -08001411}
1412
Steve Anton296a0ce2018-03-22 15:17:27 -07001413// Test that the MID header extension is included on sent packets when
1414// configured.
1415TEST_P(RtpSenderTestWithoutPacer, MidIncludedOnSentPackets) {
1416 const char kMid[] = "mid";
1417
Steve Anton2bac7da2019-07-21 15:04:21 -04001418 EnableMidSending(kMid);
Steve Anton296a0ce2018-03-22 15:17:27 -07001419
1420 // Send a couple packets.
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001421 SendGenericPacket();
1422 SendGenericPacket();
Steve Anton296a0ce2018-03-22 15:17:27 -07001423
1424 // Expect both packets to have the MID set.
1425 ASSERT_EQ(2u, transport_.sent_packets_.size());
1426 for (const RtpPacketReceived& packet : transport_.sent_packets_) {
1427 std::string mid;
1428 ASSERT_TRUE(packet.GetExtension<RtpMid>(&mid));
1429 EXPECT_EQ(kMid, mid);
1430 }
1431}
1432
Amit Hilbuch77938e62018-12-21 09:23:38 -08001433TEST_P(RtpSenderTestWithoutPacer, RidIncludedOnSentPackets) {
1434 const char kRid[] = "f";
1435
Steve Anton2bac7da2019-07-21 15:04:21 -04001436 EnableRidSending(kRid);
Amit Hilbuch77938e62018-12-21 09:23:38 -08001437
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001438 SendGenericPacket();
Amit Hilbuch77938e62018-12-21 09:23:38 -08001439
1440 ASSERT_EQ(1u, transport_.sent_packets_.size());
1441 const RtpPacketReceived& packet = transport_.sent_packets_[0];
1442 std::string rid;
1443 ASSERT_TRUE(packet.GetExtension<RtpStreamId>(&rid));
1444 EXPECT_EQ(kRid, rid);
1445}
1446
1447TEST_P(RtpSenderTestWithoutPacer, RidIncludedOnRtxSentPackets) {
1448 const char kRid[] = "f";
Amit Hilbuch77938e62018-12-21 09:23:38 -08001449
Steve Anton2bac7da2019-07-21 15:04:21 -04001450 EnableRtx();
1451 EnableRidSending(kRid);
Amit Hilbuch77938e62018-12-21 09:23:38 -08001452
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001453 SendGenericPacket();
Amit Hilbuch77938e62018-12-21 09:23:38 -08001454 ASSERT_EQ(1u, transport_.sent_packets_.size());
1455 const RtpPacketReceived& packet = transport_.sent_packets_[0];
1456 std::string rid;
1457 ASSERT_TRUE(packet.GetExtension<RtpStreamId>(&rid));
1458 EXPECT_EQ(kRid, rid);
1459 rid = kNoRid;
Steve Anton2bac7da2019-07-21 15:04:21 -04001460 EXPECT_FALSE(packet.HasExtension<RepairedRtpStreamId>());
Amit Hilbuch77938e62018-12-21 09:23:38 -08001461
1462 uint16_t packet_id = packet.SequenceNumber();
1463 rtp_sender_->ReSendPacket(packet_id);
1464 ASSERT_EQ(2u, transport_.sent_packets_.size());
1465 const RtpPacketReceived& rtx_packet = transport_.sent_packets_[1];
1466 ASSERT_TRUE(rtx_packet.GetExtension<RepairedRtpStreamId>(&rid));
1467 EXPECT_EQ(kRid, rid);
1468 EXPECT_FALSE(rtx_packet.HasExtension<RtpStreamId>());
1469}
1470
Steve Anton2bac7da2019-07-21 15:04:21 -04001471TEST_P(RtpSenderTestWithoutPacer, MidAndRidNotIncludedOnSentPacketsAfterAck) {
1472 const char kMid[] = "mid";
1473 const char kRid[] = "f";
1474
1475 EnableMidSending(kMid);
1476 EnableRidSending(kRid);
1477
1478 // This first packet should include both MID and RID.
1479 auto first_built_packet = SendGenericPacket();
1480
1481 rtp_sender_->OnReceivedAckOnSsrc(first_built_packet->SequenceNumber());
1482
1483 // The second packet should include neither since an ack was received.
1484 SendGenericPacket();
1485
1486 ASSERT_EQ(2u, transport_.sent_packets_.size());
1487
1488 const RtpPacketReceived& first_packet = transport_.sent_packets_[0];
1489 std::string mid, rid;
1490 ASSERT_TRUE(first_packet.GetExtension<RtpMid>(&mid));
1491 EXPECT_EQ(kMid, mid);
1492 ASSERT_TRUE(first_packet.GetExtension<RtpStreamId>(&rid));
1493 EXPECT_EQ(kRid, rid);
1494
1495 const RtpPacketReceived& second_packet = transport_.sent_packets_[1];
1496 EXPECT_FALSE(second_packet.HasExtension<RtpMid>());
1497 EXPECT_FALSE(second_packet.HasExtension<RtpStreamId>());
1498}
1499
1500// Test that the first RTX packet includes both MID and RRID even if the packet
1501// being retransmitted did not have MID or RID. The MID and RID are needed on
1502// the first packets for a given SSRC, and RTX packets are sent on a separate
1503// SSRC.
1504TEST_P(RtpSenderTestWithoutPacer, MidAndRidIncludedOnFirstRtxPacket) {
1505 const char kMid[] = "mid";
1506 const char kRid[] = "f";
1507
1508 EnableRtx();
1509 EnableMidSending(kMid);
1510 EnableRidSending(kRid);
1511
1512 // This first packet will include both MID and RID.
1513 auto first_built_packet = SendGenericPacket();
1514 rtp_sender_->OnReceivedAckOnSsrc(first_built_packet->SequenceNumber());
1515
1516 // The second packet will include neither since an ack was received.
1517 auto second_built_packet = SendGenericPacket();
1518
1519 // The first RTX packet should include MID and RRID.
1520 ASSERT_LT(0,
1521 rtp_sender_->ReSendPacket(second_built_packet->SequenceNumber()));
1522
1523 ASSERT_EQ(3u, transport_.sent_packets_.size());
1524
1525 const RtpPacketReceived& rtx_packet = transport_.sent_packets_[2];
1526 std::string mid, rrid;
1527 ASSERT_TRUE(rtx_packet.GetExtension<RtpMid>(&mid));
1528 EXPECT_EQ(kMid, mid);
1529 ASSERT_TRUE(rtx_packet.GetExtension<RepairedRtpStreamId>(&rrid));
1530 EXPECT_EQ(kRid, rrid);
1531}
1532
1533// Test that the RTX packets sent after receving an ACK on the RTX SSRC does
1534// not include either MID or RRID even if the packet being retransmitted did
1535// had a MID or RID.
1536TEST_P(RtpSenderTestWithoutPacer, MidAndRidNotIncludedOnRtxPacketsAfterAck) {
1537 const char kMid[] = "mid";
1538 const char kRid[] = "f";
1539
1540 EnableRtx();
1541 EnableMidSending(kMid);
1542 EnableRidSending(kRid);
1543
1544 // This first packet will include both MID and RID.
1545 auto first_built_packet = SendGenericPacket();
1546 rtp_sender_->OnReceivedAckOnSsrc(first_built_packet->SequenceNumber());
1547
1548 // The second packet will include neither since an ack was received.
1549 auto second_built_packet = SendGenericPacket();
1550
1551 // The first RTX packet will include MID and RRID.
1552 ASSERT_LT(0,
1553 rtp_sender_->ReSendPacket(second_built_packet->SequenceNumber()));
1554
1555 ASSERT_EQ(3u, transport_.sent_packets_.size());
1556 const RtpPacketReceived& first_rtx_packet = transport_.sent_packets_[2];
1557
1558 rtp_sender_->OnReceivedAckOnRtxSsrc(first_rtx_packet.SequenceNumber());
1559
1560 // The second and third RTX packets should not include MID nor RRID.
1561 ASSERT_LT(0, rtp_sender_->ReSendPacket(first_built_packet->SequenceNumber()));
1562 ASSERT_LT(0,
1563 rtp_sender_->ReSendPacket(second_built_packet->SequenceNumber()));
1564
1565 ASSERT_EQ(5u, transport_.sent_packets_.size());
1566
1567 const RtpPacketReceived& second_rtx_packet = transport_.sent_packets_[3];
1568 EXPECT_FALSE(second_rtx_packet.HasExtension<RtpMid>());
1569 EXPECT_FALSE(second_rtx_packet.HasExtension<RepairedRtpStreamId>());
1570
1571 const RtpPacketReceived& third_rtx_packet = transport_.sent_packets_[4];
1572 EXPECT_FALSE(third_rtx_packet.HasExtension<RtpMid>());
1573 EXPECT_FALSE(third_rtx_packet.HasExtension<RepairedRtpStreamId>());
1574}
1575
1576// Test that if the RtpState indicates an ACK has been received on that SSRC
1577// then neither the MID nor RID header extensions will be sent.
1578TEST_P(RtpSenderTestWithoutPacer,
1579 MidAndRidNotIncludedOnSentPacketsAfterRtpStateRestored) {
1580 const char kMid[] = "mid";
1581 const char kRid[] = "f";
1582
1583 EnableMidSending(kMid);
1584 EnableRidSending(kRid);
1585
1586 RtpState state = rtp_sender_->GetRtpState();
1587 EXPECT_FALSE(state.ssrc_has_acked);
1588 state.ssrc_has_acked = true;
1589 rtp_sender_->SetRtpState(state);
1590
1591 SendGenericPacket();
1592
1593 ASSERT_EQ(1u, transport_.sent_packets_.size());
1594 const RtpPacketReceived& packet = transport_.sent_packets_[0];
1595 EXPECT_FALSE(packet.HasExtension<RtpMid>());
1596 EXPECT_FALSE(packet.HasExtension<RtpStreamId>());
1597}
1598
1599// Test that if the RTX RtpState indicates an ACK has been received on that
1600// RTX SSRC then neither the MID nor RRID header extensions will be sent on
1601// RTX packets.
1602TEST_P(RtpSenderTestWithoutPacer,
1603 MidAndRridNotIncludedOnRtxPacketsAfterRtpStateRestored) {
1604 const char kMid[] = "mid";
1605 const char kRid[] = "f";
1606
1607 EnableRtx();
1608 EnableMidSending(kMid);
1609 EnableRidSending(kRid);
1610
1611 RtpState rtx_state = rtp_sender_->GetRtxRtpState();
1612 EXPECT_FALSE(rtx_state.ssrc_has_acked);
1613 rtx_state.ssrc_has_acked = true;
1614 rtp_sender_->SetRtxRtpState(rtx_state);
1615
1616 auto built_packet = SendGenericPacket();
1617 ASSERT_LT(0, rtp_sender_->ReSendPacket(built_packet->SequenceNumber()));
1618
1619 ASSERT_EQ(2u, transport_.sent_packets_.size());
1620 const RtpPacketReceived& rtx_packet = transport_.sent_packets_[1];
1621 EXPECT_FALSE(rtx_packet.HasExtension<RtpMid>());
1622 EXPECT_FALSE(rtx_packet.HasExtension<RepairedRtpStreamId>());
1623}
1624
minyue3a407ee2017-04-03 01:10:33 -07001625TEST_P(RtpSenderTest, FecOverheadRate) {
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001626 constexpr uint32_t kTimestamp = 1234;
1627 constexpr int kMediaPayloadType = 127;
brandtr81eab612017-01-24 04:06:09 -08001628 constexpr int kFlexfecPayloadType = 118;
brandtr81eab612017-01-24 04:06:09 -08001629 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001630 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
Erik Språng4580ca22019-07-04 10:38:43 +02001631 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexFecSsrc, kSsrc, kNoMid,
1632 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001633 nullptr /* rtp_state */, &fake_clock_);
brandtr81eab612017-01-24 04:06:09 -08001634
1635 // Reset |rtp_sender_| to use FlexFEC.
Erik Språng4580ca22019-07-04 10:38:43 +02001636 RtpRtcp::Configuration config;
1637 config.clock = &fake_clock_;
1638 config.outgoing_transport = &transport_;
1639 config.paced_sender = &mock_paced_sender_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001640 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02001641 config.flexfec_sender = &flexfec_sender;
Erik Språng4580ca22019-07-04 10:38:43 +02001642 config.event_log = &mock_rtc_event_log_;
1643 config.send_packet_observer = &send_packet_observer_;
1644 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
1645 rtp_sender_ = absl::make_unique<RTPSender>(config);
1646
brandtr81eab612017-01-24 04:06:09 -08001647 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr81eab612017-01-24 04:06:09 -08001648
Niels Möller5fe95102019-03-04 16:49:25 +01001649 PlayoutDelayOracle playout_delay_oracle;
Elad Alona0e99432019-05-24 13:50:56 +02001650 RTPSenderVideo rtp_sender_video(
1651 &fake_clock_, rtp_sender_.get(), &flexfec_sender, &playout_delay_oracle,
1652 nullptr, false, false, FieldTrialBasedConfig());
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001653 rtp_sender_video.RegisterPayloadType(kMediaPayloadType, "GENERIC",
1654 /*raw_payload=*/false);
brandtr81eab612017-01-24 04:06:09 -08001655 // Parameters selected to generate a single FEC packet per media packet.
1656 FecProtectionParams params;
1657 params.fec_rate = 15;
1658 params.max_fec_frames = 1;
1659 params.fec_mask_type = kFecMaskRandom;
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001660 rtp_sender_video.SetFecParameters(params, params);
brandtr81eab612017-01-24 04:06:09 -08001661
1662 constexpr size_t kNumMediaPackets = 10;
1663 constexpr size_t kNumFecPackets = kNumMediaPackets;
1664 constexpr int64_t kTimeBetweenPacketsMs = 10;
Erik Språngf6468d22019-07-05 16:53:43 +02001665 EXPECT_CALL(mock_paced_sender_, EnqueuePacket)
1666 .Times(kNumMediaPackets + kNumFecPackets);
brandtr81eab612017-01-24 04:06:09 -08001667 for (size_t i = 0; i < kNumMediaPackets; ++i) {
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001668 RTPVideoHeader video_header;
1669
1670 EXPECT_TRUE(rtp_sender_video.SendVideo(
Niels Möller8f7ce222019-03-21 15:43:58 +01001671 VideoFrameType::kVideoFrameKey, kMediaPayloadType, kTimestamp,
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001672 fake_clock_.TimeInMilliseconds(), kPayloadData, sizeof(kPayloadData),
1673 nullptr, &video_header, kDefaultExpectedRetransmissionTimeMs));
1674
brandtr81eab612017-01-24 04:06:09 -08001675 fake_clock_.AdvanceTimeMilliseconds(kTimeBetweenPacketsMs);
1676 }
1677 constexpr size_t kRtpHeaderLength = 12;
1678 constexpr size_t kFlexfecHeaderLength = 20;
1679 constexpr size_t kGenericCodecHeaderLength = 1;
1680 constexpr size_t kPayloadLength = sizeof(kPayloadData);
1681 constexpr size_t kPacketLength = kRtpHeaderLength + kFlexfecHeaderLength +
1682 kGenericCodecHeaderLength + kPayloadLength;
1683 EXPECT_NEAR(kNumFecPackets * kPacketLength * 8 /
1684 (kNumFecPackets * kTimeBetweenPacketsMs / 1000.0f),
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001685 rtp_sender_video.FecOverheadRate(), 500);
brandtr81eab612017-01-24 04:06:09 -08001686}
1687
minyue3a407ee2017-04-03 01:10:33 -07001688TEST_P(RtpSenderTest, BitrateCallbacks) {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001689 class TestCallback : public BitrateStatisticsObserver {
1690 public:
sprangcd349d92016-07-13 09:11:28 -07001691 TestCallback()
1692 : BitrateStatisticsObserver(),
1693 num_calls_(0),
1694 ssrc_(0),
1695 total_bitrate_(0),
1696 retransmit_bitrate_(0) {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001697 ~TestCallback() override = default;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001698
sprangcd349d92016-07-13 09:11:28 -07001699 void Notify(uint32_t total_bitrate,
1700 uint32_t retransmit_bitrate,
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001701 uint32_t ssrc) override {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001702 ++num_calls_;
1703 ssrc_ = ssrc;
sprangcd349d92016-07-13 09:11:28 -07001704 total_bitrate_ = total_bitrate;
1705 retransmit_bitrate_ = retransmit_bitrate;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001706 }
1707
1708 uint32_t num_calls_;
1709 uint32_t ssrc_;
sprangcd349d92016-07-13 09:11:28 -07001710 uint32_t total_bitrate_;
1711 uint32_t retransmit_bitrate_;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001712 } callback;
Erik Språng4580ca22019-07-04 10:38:43 +02001713
1714 RtpRtcp::Configuration config;
1715 config.clock = &fake_clock_;
1716 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001717 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02001718 config.send_bitrate_observer = &callback;
1719 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
1720 rtp_sender_ = absl::make_unique<RTPSender>(config);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001721
Niels Möller5fe95102019-03-04 16:49:25 +01001722 PlayoutDelayOracle playout_delay_oracle;
Niels Möller59ab1cf2019-02-06 22:48:11 +01001723 RTPSenderVideo rtp_sender_video(&fake_clock_, rtp_sender_.get(), nullptr,
Elad Alona0e99432019-05-24 13:50:56 +02001724 &playout_delay_oracle, nullptr, false, false,
Niels Möller5fe95102019-03-04 16:49:25 +01001725 FieldTrialBasedConfig());
Niels Möller59ab1cf2019-02-06 22:48:11 +01001726 const char payload_name[] = "GENERIC";
1727 const uint8_t payload_type = 127;
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001728 rtp_sender_video.RegisterPayloadType(payload_type, payload_name,
1729 /*raw_payload=*/false);
Niels Möller59ab1cf2019-02-06 22:48:11 +01001730
sprangcd349d92016-07-13 09:11:28 -07001731 // Simulate kNumPackets sent with kPacketInterval ms intervals, with the
1732 // number of packets selected so that we fill (but don't overflow) the one
1733 // second averaging window.
1734 const uint32_t kWindowSizeMs = 1000;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001735 const uint32_t kPacketInterval = 20;
sprangcd349d92016-07-13 09:11:28 -07001736 const uint32_t kNumPackets =
1737 (kWindowSizeMs - kPacketInterval) / kPacketInterval;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001738 // Overhead = 12 bytes RTP header + 1 byte generic header.
1739 const uint32_t kPacketOverhead = 13;
1740
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001741 uint8_t payload[] = {47, 11, 32, 93, 89};
1742 rtp_sender_->SetStorePacketsStatus(true, 1);
1743 uint32_t ssrc = rtp_sender_->SSRC();
1744
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001745 // Initial process call so we get a new time window.
1746 rtp_sender_->ProcessBitrate();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001747
1748 // Send a few frames.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001749 RTPVideoHeader video_header;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001750 for (uint32_t i = 0; i < kNumPackets; ++i) {
Niels Möller59ab1cf2019-02-06 22:48:11 +01001751 ASSERT_TRUE(rtp_sender_video.SendVideo(
Niels Möller8f7ce222019-03-21 15:43:58 +01001752 VideoFrameType::kVideoFrameKey, payload_type, 1234, 4321, payload,
1753 sizeof(payload), nullptr, &video_header,
1754 kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001755 fake_clock_.AdvanceTimeMilliseconds(kPacketInterval);
1756 }
1757
1758 rtp_sender_->ProcessBitrate();
1759
stefan@webrtc.org0bae1fa2014-11-05 14:05:29 +00001760 // We get one call for every stats updated, thus two calls since both the
1761 // stream stats and the retransmit stats are updated once.
1762 EXPECT_EQ(2u, callback.num_calls_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001763 EXPECT_EQ(ssrc, callback.ssrc_);
sprangcd349d92016-07-13 09:11:28 -07001764 const uint32_t kTotalPacketSize = kPacketOverhead + sizeof(payload);
1765 // Bitrate measured over delta between last and first timestamp, plus one.
1766 const uint32_t kExpectedWindowMs = kNumPackets * kPacketInterval + 1;
1767 const uint32_t kExpectedBitsAccumulated = kTotalPacketSize * kNumPackets * 8;
1768 const uint32_t kExpectedRateBps =
1769 (kExpectedBitsAccumulated * 1000 + (kExpectedWindowMs / 2)) /
1770 kExpectedWindowMs;
1771 EXPECT_EQ(kExpectedRateBps, callback.total_bitrate_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001772
andresp@webrtc.orgd11bec42014-07-08 14:32:58 +00001773 rtp_sender_.reset();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001774}
1775
minyue3a407ee2017-04-03 01:10:33 -07001776TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacks) {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001777 class TestCallback : public StreamDataCountersCallback {
1778 public:
danilchap162abd32015-12-10 02:39:40 -08001779 TestCallback() : StreamDataCountersCallback(), ssrc_(0), counters_() {}
Danil Chapovalovdd7e2842018-03-09 15:37:03 +00001780 ~TestCallback() override = default;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001781
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001782 void DataCountersUpdated(const StreamDataCounters& counters,
1783 uint32_t ssrc) override {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001784 ssrc_ = ssrc;
1785 counters_ = counters;
1786 }
1787
1788 uint32_t ssrc_;
1789 StreamDataCounters counters_;
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001790
1791 void MatchPacketCounter(const RtpPacketCounter& expected,
1792 const RtpPacketCounter& actual) {
1793 EXPECT_EQ(expected.payload_bytes, actual.payload_bytes);
1794 EXPECT_EQ(expected.header_bytes, actual.header_bytes);
1795 EXPECT_EQ(expected.padding_bytes, actual.padding_bytes);
1796 EXPECT_EQ(expected.packets, actual.packets);
1797 }
1798
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001799 void Matches(uint32_t ssrc, const StreamDataCounters& counters) {
1800 EXPECT_EQ(ssrc, ssrc_);
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001801 MatchPacketCounter(counters.transmitted, counters_.transmitted);
1802 MatchPacketCounter(counters.retransmitted, counters_.retransmitted);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001803 EXPECT_EQ(counters.fec.packets, counters_.fec.packets);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001804 }
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001805 } callback;
1806
1807 const uint8_t kRedPayloadType = 96;
1808 const uint8_t kUlpfecPayloadType = 97;
Niels Möller8a40edd2019-01-24 18:04:44 +01001809 const char payload_name[] = "GENERIC";
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001810 const uint8_t payload_type = 127;
Niels Möller5fe95102019-03-04 16:49:25 +01001811 PlayoutDelayOracle playout_delay_oracle;
Niels Möller59ab1cf2019-02-06 22:48:11 +01001812 RTPSenderVideo rtp_sender_video(&fake_clock_, rtp_sender_.get(), nullptr,
Elad Alona0e99432019-05-24 13:50:56 +02001813 &playout_delay_oracle, nullptr, false, false,
Niels Möller5fe95102019-03-04 16:49:25 +01001814 FieldTrialBasedConfig());
Mirta Dvornicicfe68daa2019-05-23 13:21:12 +02001815 rtp_sender_video.RegisterPayloadType(payload_type, payload_name,
1816 /*raw_payload=*/false);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001817 uint8_t payload[] = {47, 11, 32, 93, 89};
1818 rtp_sender_->SetStorePacketsStatus(true, 1);
1819 uint32_t ssrc = rtp_sender_->SSRC();
1820
1821 rtp_sender_->RegisterRtpStatisticsCallback(&callback);
1822
1823 // Send a frame.
Sami Kalliomäki426a80c2018-08-08 11:37:59 +02001824 RTPVideoHeader video_header;
Niels Möller59ab1cf2019-02-06 22:48:11 +01001825 ASSERT_TRUE(rtp_sender_video.SendVideo(
Niels Möller8f7ce222019-03-21 15:43:58 +01001826 VideoFrameType::kVideoFrameKey, payload_type, 1234, 4321, payload,
1827 sizeof(payload), nullptr, &video_header,
1828 kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001829 StreamDataCounters expected;
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001830 expected.transmitted.payload_bytes = 6;
1831 expected.transmitted.header_bytes = 12;
1832 expected.transmitted.padding_bytes = 0;
1833 expected.transmitted.packets = 1;
1834 expected.retransmitted.payload_bytes = 0;
1835 expected.retransmitted.header_bytes = 0;
1836 expected.retransmitted.padding_bytes = 0;
1837 expected.retransmitted.packets = 0;
1838 expected.fec.packets = 0;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001839 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001840
1841 // Retransmit a frame.
1842 uint16_t seqno = rtp_sender_->SequenceNumber() - 1;
Erik Språnga12b1d62018-03-14 12:39:24 +01001843 rtp_sender_->ReSendPacket(seqno);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001844 expected.transmitted.payload_bytes = 12;
1845 expected.transmitted.header_bytes = 24;
1846 expected.transmitted.packets = 2;
1847 expected.retransmitted.payload_bytes = 6;
1848 expected.retransmitted.header_bytes = 12;
1849 expected.retransmitted.padding_bytes = 0;
1850 expected.retransmitted.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001851 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001852
1853 // Send padding.
Erik Språng4208a132019-08-26 08:58:45 +02001854 GenerateAndSendPadding(kMaxPaddingSize);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001855 expected.transmitted.payload_bytes = 12;
1856 expected.transmitted.header_bytes = 36;
1857 expected.transmitted.padding_bytes = kMaxPaddingSize;
1858 expected.transmitted.packets = 3;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001859 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001860
brandtrf1bb4762016-11-07 03:05:06 -08001861 // Send ULPFEC.
Niels Möller59ab1cf2019-02-06 22:48:11 +01001862 rtp_sender_video.SetUlpfecConfig(kRedPayloadType, kUlpfecPayloadType);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001863 FecProtectionParams fec_params;
1864 fec_params.fec_mask_type = kFecMaskRandom;
1865 fec_params.fec_rate = 1;
1866 fec_params.max_fec_frames = 1;
Niels Möller59ab1cf2019-02-06 22:48:11 +01001867 rtp_sender_video.SetFecParameters(fec_params, fec_params);
1868 ASSERT_TRUE(rtp_sender_video.SendVideo(
Niels Möller8f7ce222019-03-21 15:43:58 +01001869 VideoFrameType::kVideoFrameDelta, payload_type, 1234, 4321, payload,
1870 sizeof(payload), nullptr, &video_header,
1871 kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001872 expected.transmitted.payload_bytes = 40;
1873 expected.transmitted.header_bytes = 60;
1874 expected.transmitted.packets = 5;
1875 expected.fec.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001876 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001877
sprang867fb522015-08-03 04:38:41 -07001878 rtp_sender_->RegisterRtpStatisticsCallback(nullptr);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001879}
1880
minyue3a407ee2017-04-03 01:10:33 -07001881TEST_P(RtpSenderTestWithoutPacer, BytesReportedCorrectly) {
Niels Möller59ab1cf2019-02-06 22:48:11 +01001882 // XXX const char* kPayloadName = "GENERIC";
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001883 const uint8_t kPayloadType = 127;
Shao Changbine62202f2015-04-21 20:24:50 +08001884 rtp_sender_->SetRtxPayloadType(kPayloadType - 1, kPayloadType);
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +00001885 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001886
Niels Möller59ab1cf2019-02-06 22:48:11 +01001887 SendGenericPacket();
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001888 // Will send 2 full-size padding packets.
Erik Språng4208a132019-08-26 08:58:45 +02001889 GenerateAndSendPadding(1);
1890 GenerateAndSendPadding(1);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001891
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001892 StreamDataCounters rtp_stats;
1893 StreamDataCounters rtx_stats;
1894 rtp_sender_->GetDataCounters(&rtp_stats, &rtx_stats);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001895
Niels Möller59ab1cf2019-02-06 22:48:11 +01001896 // Payload
asapersson@webrtc.orgd08d3892014-12-16 12:03:11 +00001897 EXPECT_GT(rtp_stats.first_packet_time_ms, -1);
Niels Möller59ab1cf2019-02-06 22:48:11 +01001898 EXPECT_EQ(rtp_stats.transmitted.payload_bytes, sizeof(kPayloadData));
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001899 EXPECT_EQ(rtp_stats.transmitted.header_bytes, 12u);
1900 EXPECT_EQ(rtp_stats.transmitted.padding_bytes, 0u);
1901 EXPECT_EQ(rtx_stats.transmitted.payload_bytes, 0u);
1902 EXPECT_EQ(rtx_stats.transmitted.header_bytes, 24u);
1903 EXPECT_EQ(rtx_stats.transmitted.padding_bytes, 2 * kMaxPaddingSize);
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001904
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001905 EXPECT_EQ(rtp_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001906 rtp_stats.transmitted.payload_bytes +
1907 rtp_stats.transmitted.header_bytes +
1908 rtp_stats.transmitted.padding_bytes);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001909 EXPECT_EQ(rtx_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001910 rtx_stats.transmitted.payload_bytes +
1911 rtx_stats.transmitted.header_bytes +
1912 rtx_stats.transmitted.padding_bytes);
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001913
danilchap162abd32015-12-10 02:39:40 -08001914 EXPECT_EQ(
1915 transport_.total_bytes_sent_,
1916 rtp_stats.transmitted.TotalBytes() + rtx_stats.transmitted.TotalBytes());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001917}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001918
minyue3a407ee2017-04-03 01:10:33 -07001919TEST_P(RtpSenderTestWithoutPacer, RespectsNackBitrateLimit) {
sprang38778b02015-09-29 09:48:22 -07001920 const int32_t kPacketSize = 1400;
1921 const int32_t kNumPackets = 30;
1922
sprangcd349d92016-07-13 09:11:28 -07001923 retransmission_rate_limiter_.SetMaxRate(kPacketSize * kNumPackets * 8);
1924
sprang38778b02015-09-29 09:48:22 -07001925 rtp_sender_->SetStorePacketsStatus(true, kNumPackets);
sprang38778b02015-09-29 09:48:22 -07001926 const uint16_t kStartSequenceNumber = rtp_sender_->SequenceNumber();
Danil Chapovalov2800d742016-08-26 18:48:46 +02001927 std::vector<uint16_t> sequence_numbers;
sprang38778b02015-09-29 09:48:22 -07001928 for (int32_t i = 0; i < kNumPackets; ++i) {
1929 sequence_numbers.push_back(kStartSequenceNumber + i);
1930 fake_clock_.AdvanceTimeMilliseconds(1);
1931 SendPacket(fake_clock_.TimeInMilliseconds(), kPacketSize);
1932 }
danilchap12ba1862016-10-26 02:41:55 -07001933 EXPECT_EQ(kNumPackets, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001934
1935 fake_clock_.AdvanceTimeMilliseconds(1000 - kNumPackets);
1936
1937 // Resending should work - brings the bandwidth up to the limit.
1938 // NACK bitrate is capped to the same bitrate as the encoder, since the max
1939 // protection overhead is 50% (see MediaOptimization::SetTargetRates).
Danil Chapovalov2800d742016-08-26 18:48:46 +02001940 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001941 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001942
sprangcd349d92016-07-13 09:11:28 -07001943 // Must be at least 5ms in between retransmission attempts.
1944 fake_clock_.AdvanceTimeMilliseconds(5);
1945
sprang38778b02015-09-29 09:48:22 -07001946 // Resending should not work, bandwidth exceeded.
Danil Chapovalov2800d742016-08-26 18:48:46 +02001947 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001948 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001949}
1950
minyue3a407ee2017-04-03 01:10:33 -07001951TEST_P(RtpSenderTest, OnOverheadChanged) {
michaelt4da30442016-11-17 01:38:43 -08001952 MockOverheadObserver mock_overhead_observer;
Erik Språng4580ca22019-07-04 10:38:43 +02001953 RtpRtcp::Configuration config;
1954 config.clock = &fake_clock_;
1955 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001956 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02001957 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
1958 config.overhead_observer = &mock_overhead_observer;
1959 rtp_sender_ = absl::make_unique<RTPSender>(config);
michaelt4da30442016-11-17 01:38:43 -08001960
michaelt4da30442016-11-17 01:38:43 -08001961 // RTP overhead is 12B.
nisse284542b2017-01-10 08:58:32 -08001962 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(12)).Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001963 SendGenericPacket();
michaelt4da30442016-11-17 01:38:43 -08001964
1965 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
1966 kTransmissionTimeOffsetExtensionId);
1967
1968 // TransmissionTimeOffset extension has a size of 8B.
nisse284542b2017-01-10 08:58:32 -08001969 // 12B + 8B = 20B
1970 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(20)).Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001971 SendGenericPacket();
michaelt4da30442016-11-17 01:38:43 -08001972}
1973
minyue3a407ee2017-04-03 01:10:33 -07001974TEST_P(RtpSenderTest, DoesNotUpdateOverheadOnEqualSize) {
michaelt4da30442016-11-17 01:38:43 -08001975 MockOverheadObserver mock_overhead_observer;
Erik Språng4580ca22019-07-04 10:38:43 +02001976 RtpRtcp::Configuration config;
1977 config.clock = &fake_clock_;
1978 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02001979 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02001980 config.retransmission_rate_limiter = &retransmission_rate_limiter_;
1981 config.overhead_observer = &mock_overhead_observer;
1982 rtp_sender_ = absl::make_unique<RTPSender>(config);
michaelt4da30442016-11-17 01:38:43 -08001983
1984 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(_)).Times(1);
Niels Möllere7b9e6b2019-02-06 18:23:44 +01001985 SendGenericPacket();
1986 SendGenericPacket();
michaelt4da30442016-11-17 01:38:43 -08001987}
1988
Erik Språng9c771c22019-06-17 16:31:53 +02001989TEST_P(RtpSenderTest, TrySendPacketMatchesVideo) {
1990 std::unique_ptr<RtpPacketToSend> packet =
1991 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
1992 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
1993
1994 // Verify not sent with wrong SSRC.
1995 packet->SetSsrc(kSsrc + 1);
1996 EXPECT_FALSE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
1997
1998 // Verify sent with correct SSRC.
1999 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2000 packet->SetSsrc(kSsrc);
2001 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2002 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2003}
2004
2005TEST_P(RtpSenderTest, TrySendPacketMatchesAudio) {
2006 std::unique_ptr<RtpPacketToSend> packet =
2007 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2008 packet->set_packet_type(RtpPacketToSend::Type::kAudio);
2009
2010 // Verify not sent with wrong SSRC.
2011 packet->SetSsrc(kSsrc + 1);
2012 EXPECT_FALSE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2013
2014 // Verify sent with correct SSRC.
2015 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2016 packet->SetSsrc(kSsrc);
2017 packet->set_packet_type(RtpPacketToSend::Type::kAudio);
2018 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2019}
2020
2021TEST_P(RtpSenderTest, TrySendPacketMatchesRetransmissions) {
2022 std::unique_ptr<RtpPacketToSend> packet =
2023 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2024 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2025
2026 // Verify not sent with wrong SSRC.
2027 packet->SetSsrc(kSsrc + 1);
2028 EXPECT_FALSE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2029
2030 // Verify sent with correct SSRC (non-RTX).
2031 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2032 packet->SetSsrc(kSsrc);
2033 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2034 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2035
2036 // RTX retransmission.
2037 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2038 packet->SetSsrc(kRtxSsrc);
2039 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2040 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2041}
2042
2043TEST_P(RtpSenderTest, TrySendPacketMatchesPadding) {
2044 std::unique_ptr<RtpPacketToSend> packet =
2045 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2046 packet->set_packet_type(RtpPacketToSend::Type::kPadding);
2047
2048 // Verify not sent with wrong SSRC.
2049 packet->SetSsrc(kSsrc + 1);
2050 EXPECT_FALSE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2051
2052 // Verify sent with correct SSRC (non-RTX).
2053 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2054 packet->SetSsrc(kSsrc);
2055 packet->set_packet_type(RtpPacketToSend::Type::kPadding);
2056 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2057
2058 // RTX padding.
2059 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2060 packet->SetSsrc(kRtxSsrc);
2061 packet->set_packet_type(RtpPacketToSend::Type::kPadding);
2062 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2063}
2064
2065TEST_P(RtpSenderTest, TrySendPacketMatchesFlexfec) {
2066 std::unique_ptr<RtpPacketToSend> packet =
2067 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2068 packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection);
2069
2070 // Verify not sent with wrong SSRC.
2071 packet->SetSsrc(kSsrc + 1);
2072 EXPECT_FALSE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2073
2074 // Verify sent with correct SSRC.
2075 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2076 packet->SetSsrc(kFlexFecSsrc);
2077 packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection);
2078 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2079}
2080
2081TEST_P(RtpSenderTest, TrySendPacketMatchesUlpfec) {
2082 std::unique_ptr<RtpPacketToSend> packet =
2083 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2084 packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection);
2085
2086 // Verify not sent with wrong SSRC.
2087 packet->SetSsrc(kSsrc + 1);
2088 EXPECT_FALSE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2089
2090 // Verify sent with correct SSRC.
2091 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2092 packet->SetSsrc(kSsrc);
2093 packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection);
2094 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2095}
2096
2097TEST_P(RtpSenderTest, TrySendPacketHandlesRetransmissionHistory) {
2098 rtp_sender_->SetStorePacketsStatus(true, 10);
2099
2100 // Build a media packet and send it.
2101 std::unique_ptr<RtpPacketToSend> packet =
2102 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2103 const uint16_t media_sequence_number = packet->SequenceNumber();
2104 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2105 packet->set_allow_retransmission(true);
2106 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2107
2108 // Simulate retransmission request.
2109 fake_clock_.AdvanceTimeMilliseconds(30);
2110 EXPECT_GT(rtp_sender_->ReSendPacket(media_sequence_number), 0);
2111
2112 // Packet already pending, retransmission not allowed.
2113 fake_clock_.AdvanceTimeMilliseconds(30);
2114 EXPECT_EQ(rtp_sender_->ReSendPacket(media_sequence_number), 0);
2115
2116 // Packet exiting pacer, mark as not longer pending.
2117 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2118 EXPECT_NE(packet->SequenceNumber(), media_sequence_number);
2119 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2120 packet->SetSsrc(kRtxSsrc);
2121 packet->set_retransmitted_sequence_number(media_sequence_number);
2122 packet->set_allow_retransmission(false);
2123 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2124
2125 // Retransmissions allowed again.
2126 fake_clock_.AdvanceTimeMilliseconds(30);
2127 EXPECT_GT(rtp_sender_->ReSendPacket(media_sequence_number), 0);
2128
2129 // Retransmission of RTX packet should not be allowed.
2130 EXPECT_EQ(rtp_sender_->ReSendPacket(packet->SequenceNumber()), 0);
2131}
2132
2133TEST_P(RtpSenderTest, TrySendPacketUpdatesExtensions) {
2134 ASSERT_EQ(rtp_sender_->RegisterRtpHeaderExtension(
2135 kRtpExtensionTransmissionTimeOffset,
2136 kTransmissionTimeOffsetExtensionId),
2137 0);
2138 ASSERT_EQ(rtp_sender_->RegisterRtpHeaderExtension(
2139 kRtpExtensionAbsoluteSendTime, kAbsoluteSendTimeExtensionId),
2140 0);
2141 ASSERT_EQ(rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionVideoTiming,
2142 kVideoTimingExtensionId),
2143 0);
2144
2145 std::unique_ptr<RtpPacketToSend> packet =
2146 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2147 packet->set_packetization_finish_time_ms(fake_clock_.TimeInMilliseconds());
2148
2149 const int32_t kDiffMs = 10;
2150 fake_clock_.AdvanceTimeMilliseconds(kDiffMs);
2151
2152 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2153 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2154
2155 const RtpPacketReceived& received_packet = transport_.last_sent_packet();
2156
2157 EXPECT_EQ(received_packet.GetExtension<TransmissionOffset>(), kDiffMs * 90);
2158
2159 EXPECT_EQ(received_packet.GetExtension<AbsoluteSendTime>(),
2160 AbsoluteSendTime::MsTo24Bits(fake_clock_.TimeInMilliseconds()));
2161
2162 VideoSendTiming timing;
2163 EXPECT_TRUE(received_packet.GetExtension<VideoTimingExtension>(&timing));
2164 EXPECT_EQ(timing.pacer_exit_delta_ms, kDiffMs);
2165}
2166
2167TEST_P(RtpSenderTest, TrySendPacketSetsPacketOptions) {
2168 const uint16_t kPacketId = 42;
2169 ASSERT_EQ(rtp_sender_->RegisterRtpHeaderExtension(
2170 kRtpExtensionTransportSequenceNumber,
2171 kTransportSequenceNumberExtensionId),
2172 0);
2173 std::unique_ptr<RtpPacketToSend> packet =
2174 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2175 packet->SetExtension<TransportSequenceNumber>(kPacketId);
2176
2177 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2178 EXPECT_CALL(send_packet_observer_, OnSendPacket);
2179 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2180
2181 EXPECT_EQ(transport_.last_options_.packet_id, kPacketId);
2182 EXPECT_TRUE(transport_.last_options_.included_in_allocation);
2183 EXPECT_TRUE(transport_.last_options_.included_in_feedback);
2184 EXPECT_FALSE(transport_.last_options_.is_retransmit);
2185
2186 // Send another packet as retransmission, verify options are populated.
2187 packet = BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2188 packet->SetExtension<TransportSequenceNumber>(kPacketId + 1);
2189 packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2190 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2191 EXPECT_TRUE(transport_.last_options_.is_retransmit);
2192}
2193
2194TEST_P(RtpSenderTest, TrySendPacketUpdatesStats) {
2195 const size_t kPayloadSize = 1000;
2196
2197 StrictMock<MockSendSideDelayObserver> send_side_delay_observer;
Erik Språng4580ca22019-07-04 10:38:43 +02002198
2199 RtpRtcp::Configuration config;
2200 config.clock = &fake_clock_;
2201 config.outgoing_transport = &transport_;
Erik Språng54d5d2c2019-08-20 17:22:36 +02002202 config.local_media_ssrc = kSsrc;
Erik Språng4580ca22019-07-04 10:38:43 +02002203 config.rtx_send_ssrc = kRtxSsrc;
2204 config.flexfec_sender = &flexfec_sender_;
2205 config.send_side_delay_observer = &send_side_delay_observer;
2206 config.event_log = &mock_rtc_event_log_;
2207 config.send_packet_observer = &send_packet_observer_;
2208 rtp_sender_ = absl::make_unique<RTPSender>(config);
Erik Språng9c771c22019-06-17 16:31:53 +02002209 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2210 kRtpExtensionTransportSequenceNumber,
2211 kTransportSequenceNumberExtensionId));
2212
2213 const int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
2214
2215 std::unique_ptr<RtpPacketToSend> video_packet =
2216 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2217 video_packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2218 video_packet->SetPayloadSize(kPayloadSize);
2219 video_packet->SetExtension<TransportSequenceNumber>(1);
2220
2221 std::unique_ptr<RtpPacketToSend> rtx_packet =
2222 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2223 rtx_packet->SetSsrc(kRtxSsrc);
2224 rtx_packet->set_packet_type(RtpPacketToSend::Type::kRetransmission);
2225 rtx_packet->SetPayloadSize(kPayloadSize);
2226 rtx_packet->SetExtension<TransportSequenceNumber>(2);
2227
2228 std::unique_ptr<RtpPacketToSend> fec_packet =
2229 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2230 fec_packet->SetSsrc(kFlexFecSsrc);
2231 fec_packet->set_packet_type(RtpPacketToSend::Type::kForwardErrorCorrection);
2232 fec_packet->SetPayloadSize(kPayloadSize);
2233 fec_packet->SetExtension<TransportSequenceNumber>(3);
2234
2235 const int64_t kDiffMs = 25;
2236 fake_clock_.AdvanceTimeMilliseconds(kDiffMs);
2237
2238 EXPECT_CALL(send_side_delay_observer,
2239 SendSideDelayUpdated(kDiffMs, kDiffMs, kDiffMs, kSsrc));
2240 EXPECT_CALL(
2241 send_side_delay_observer,
2242 SendSideDelayUpdated(kDiffMs, kDiffMs, 2 * kDiffMs, kFlexFecSsrc));
2243
2244 EXPECT_CALL(send_packet_observer_, OnSendPacket(1, capture_time_ms, kSsrc));
2245 EXPECT_TRUE(
2246 rtp_sender_->TrySendPacket(video_packet.get(), PacedPacketInfo()));
2247
2248 // Send packet observer not called for padding/retransmissions.
2249 EXPECT_CALL(send_packet_observer_, OnSendPacket(2, _, _)).Times(0);
2250 EXPECT_TRUE(rtp_sender_->TrySendPacket(rtx_packet.get(), PacedPacketInfo()));
2251
2252 EXPECT_CALL(send_packet_observer_,
2253 OnSendPacket(3, capture_time_ms, kFlexFecSsrc));
2254 EXPECT_TRUE(rtp_sender_->TrySendPacket(fec_packet.get(), PacedPacketInfo()));
2255
2256 StreamDataCounters rtp_stats;
2257 StreamDataCounters rtx_stats;
2258 rtp_sender_->GetDataCounters(&rtp_stats, &rtx_stats);
2259 EXPECT_EQ(rtp_stats.transmitted.packets, 2u);
2260 EXPECT_EQ(rtp_stats.fec.packets, 1u);
2261 EXPECT_EQ(rtx_stats.retransmitted.packets, 1u);
2262}
2263
Erik Språng478cb462019-06-26 15:49:27 +02002264TEST_P(RtpSenderTest, GeneratePaddingResendsOldPacketsWithRtx) {
Mirko Bonadeia7e3bce2019-07-12 17:35:56 +00002265 // Min requested size in order to use RTX payload.
2266 const size_t kMinPaddingSize = 50;
2267
Erik Språng478cb462019-06-26 15:49:27 +02002268 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
2269 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
2270 rtp_sender_->SetStorePacketsStatus(true, 1);
2271
Erik Språng0f6191d2019-07-15 20:33:40 +02002272 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2273 kRtpExtensionTransmissionTimeOffset,
2274 kTransmissionTimeOffsetExtensionId));
2275 ASSERT_EQ(
2276 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
2277 kAbsoluteSendTimeExtensionId));
2278 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2279 kRtpExtensionTransportSequenceNumber,
2280 kTransportSequenceNumberExtensionId));
2281
Erik Språng478cb462019-06-26 15:49:27 +02002282 const size_t kPayloadPacketSize = 1234;
2283 std::unique_ptr<RtpPacketToSend> packet =
2284 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2285 packet->set_allow_retransmission(true);
2286 packet->SetPayloadSize(kPayloadPacketSize);
2287 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2288
2289 // Send a dummy video packet so it ends up in the packet history.
Erik Språng0f6191d2019-07-15 20:33:40 +02002290 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
Erik Språng478cb462019-06-26 15:49:27 +02002291 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2292
2293 // Generated padding has large enough budget that the video packet should be
2294 // retransmitted as padding.
Erik Språngf6468d22019-07-05 16:53:43 +02002295 std::vector<std::unique_ptr<RtpPacketToSend>> generated_packets =
Mirko Bonadeia7e3bce2019-07-12 17:35:56 +00002296 rtp_sender_->GeneratePadding(kMinPaddingSize);
Erik Språngf6468d22019-07-05 16:53:43 +02002297 ASSERT_EQ(generated_packets.size(), 1u);
2298 auto& padding_packet = generated_packets.front();
2299 EXPECT_EQ(padding_packet->packet_type(), RtpPacketToSend::Type::kPadding);
2300 EXPECT_EQ(padding_packet->Ssrc(), kRtxSsrc);
2301 EXPECT_EQ(padding_packet->payload_size(),
2302 kPayloadPacketSize + kRtxHeaderSize);
Erik Språng0f6191d2019-07-15 20:33:40 +02002303 EXPECT_TRUE(padding_packet->IsExtensionReserved<TransportSequenceNumber>());
2304 EXPECT_TRUE(padding_packet->IsExtensionReserved<AbsoluteSendTime>());
2305 EXPECT_TRUE(padding_packet->IsExtensionReserved<TransmissionOffset>());
2306
2307 // Verify all header extensions are received.
2308 EXPECT_TRUE(
2309 rtp_sender_->TrySendPacket(padding_packet.get(), PacedPacketInfo()));
2310 webrtc::RTPHeader rtp_header;
2311 transport_.last_sent_packet().GetHeader(&rtp_header);
2312 EXPECT_TRUE(rtp_header.extension.hasAbsoluteSendTime);
2313 EXPECT_TRUE(rtp_header.extension.hasTransmissionTimeOffset);
2314 EXPECT_TRUE(rtp_header.extension.hasTransportSequenceNumber);
Erik Språng478cb462019-06-26 15:49:27 +02002315
2316 // Not enough budged for payload padding, use plain padding instead.
Mirko Bonadeia7e3bce2019-07-12 17:35:56 +00002317 const size_t kPaddingBytesRequested = kMinPaddingSize - 1;
Erik Språngf6468d22019-07-05 16:53:43 +02002318
2319 size_t padding_bytes_generated = 0;
2320 generated_packets = rtp_sender_->GeneratePadding(kPaddingBytesRequested);
Mirko Bonadeia7e3bce2019-07-12 17:35:56 +00002321 EXPECT_EQ(generated_packets.size(), 1u);
Erik Språngf6468d22019-07-05 16:53:43 +02002322 for (auto& packet : generated_packets) {
2323 EXPECT_EQ(packet->packet_type(), RtpPacketToSend::Type::kPadding);
2324 EXPECT_EQ(packet->Ssrc(), kRtxSsrc);
2325 EXPECT_EQ(packet->payload_size(), 0u);
2326 EXPECT_GT(packet->padding_size(), 0u);
2327 padding_bytes_generated += packet->padding_size();
Erik Språng0f6191d2019-07-15 20:33:40 +02002328
2329 EXPECT_TRUE(packet->IsExtensionReserved<TransportSequenceNumber>());
2330 EXPECT_TRUE(packet->IsExtensionReserved<AbsoluteSendTime>());
2331 EXPECT_TRUE(packet->IsExtensionReserved<TransmissionOffset>());
2332
2333 // Verify all header extensions are received.
2334 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2335 webrtc::RTPHeader rtp_header;
2336 transport_.last_sent_packet().GetHeader(&rtp_header);
2337 EXPECT_TRUE(rtp_header.extension.hasAbsoluteSendTime);
2338 EXPECT_TRUE(rtp_header.extension.hasTransmissionTimeOffset);
2339 EXPECT_TRUE(rtp_header.extension.hasTransportSequenceNumber);
Erik Språngf6468d22019-07-05 16:53:43 +02002340 }
2341
Mirko Bonadeia7e3bce2019-07-12 17:35:56 +00002342 EXPECT_EQ(padding_bytes_generated, kMaxPaddingSize);
Erik Språng478cb462019-06-26 15:49:27 +02002343}
2344
2345TEST_P(RtpSenderTest, GeneratePaddingCreatesPurePaddingWithoutRtx) {
2346 rtp_sender_->SetStorePacketsStatus(true, 1);
Erik Språng0f6191d2019-07-15 20:33:40 +02002347 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2348 kRtpExtensionTransmissionTimeOffset,
2349 kTransmissionTimeOffsetExtensionId));
2350 ASSERT_EQ(
2351 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
2352 kAbsoluteSendTimeExtensionId));
2353 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
2354 kRtpExtensionTransportSequenceNumber,
2355 kTransportSequenceNumberExtensionId));
Erik Språng478cb462019-06-26 15:49:27 +02002356
2357 const size_t kPayloadPacketSize = 1234;
2358 // Send a dummy video packet so it ends up in the packet history. Since we
2359 // are not using RTX, it should never be used as padding.
2360 std::unique_ptr<RtpPacketToSend> packet =
2361 BuildRtpPacket(kPayload, true, 0, fake_clock_.TimeInMilliseconds());
2362 packet->set_allow_retransmission(true);
2363 packet->SetPayloadSize(kPayloadPacketSize);
2364 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
Erik Språng0f6191d2019-07-15 20:33:40 +02002365 EXPECT_CALL(send_packet_observer_, OnSendPacket).Times(1);
Erik Språng478cb462019-06-26 15:49:27 +02002366 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2367
2368 // Payload padding not available without RTX, only generate plain padding on
2369 // the media SSRC.
2370 // Number of padding packets is the requested padding size divided by max
2371 // padding packet size, rounded up. Pure padding packets are always of the
2372 // maximum size.
2373 const size_t kPaddingBytesRequested = kPayloadPacketSize + kRtxHeaderSize;
2374 const size_t kExpectedNumPaddingPackets =
2375 (kPaddingBytesRequested + kMaxPaddingSize - 1) / kMaxPaddingSize;
Erik Språngf6468d22019-07-05 16:53:43 +02002376 size_t padding_bytes_generated = 0;
2377 std::vector<std::unique_ptr<RtpPacketToSend>> padding_packets =
2378 rtp_sender_->GeneratePadding(kPaddingBytesRequested);
2379 EXPECT_EQ(padding_packets.size(), kExpectedNumPaddingPackets);
2380 for (auto& packet : padding_packets) {
2381 EXPECT_EQ(packet->packet_type(), RtpPacketToSend::Type::kPadding);
2382 EXPECT_EQ(packet->Ssrc(), kSsrc);
2383 EXPECT_EQ(packet->payload_size(), 0u);
2384 EXPECT_GT(packet->padding_size(), 0u);
2385 padding_bytes_generated += packet->padding_size();
Erik Språng0f6191d2019-07-15 20:33:40 +02002386 EXPECT_TRUE(packet->IsExtensionReserved<TransportSequenceNumber>());
2387 EXPECT_TRUE(packet->IsExtensionReserved<AbsoluteSendTime>());
2388 EXPECT_TRUE(packet->IsExtensionReserved<TransmissionOffset>());
2389
2390 // Verify all header extensions are received.
2391 EXPECT_TRUE(rtp_sender_->TrySendPacket(packet.get(), PacedPacketInfo()));
2392 webrtc::RTPHeader rtp_header;
2393 transport_.last_sent_packet().GetHeader(&rtp_header);
2394 EXPECT_TRUE(rtp_header.extension.hasAbsoluteSendTime);
2395 EXPECT_TRUE(rtp_header.extension.hasTransmissionTimeOffset);
2396 EXPECT_TRUE(rtp_header.extension.hasTransportSequenceNumber);
Erik Språngf6468d22019-07-05 16:53:43 +02002397 }
2398
2399 EXPECT_EQ(padding_bytes_generated,
2400 kExpectedNumPaddingPackets * kMaxPaddingSize);
Erik Språng478cb462019-06-26 15:49:27 +02002401}
2402
Mirko Bonadei999a72a2019-07-12 17:33:46 +00002403TEST_P(RtpSenderTest, SupportsPadding) {
2404 bool kSendingMediaStats[] = {true, false};
2405 bool kEnableRedundantPayloads[] = {true, false};
2406 RTPExtensionType kBweExtensionTypes[] = {
2407 kRtpExtensionTransportSequenceNumber,
2408 kRtpExtensionTransportSequenceNumber02, kRtpExtensionAbsoluteSendTime,
2409 kRtpExtensionTransmissionTimeOffset};
2410 const int kExtensionsId = 7;
2411
2412 for (bool sending_media : kSendingMediaStats) {
2413 rtp_sender_->SetSendingMediaStatus(sending_media);
2414 for (bool redundant_payloads : kEnableRedundantPayloads) {
2415 int rtx_mode = kRtxRetransmitted;
2416 if (redundant_payloads) {
2417 rtx_mode |= kRtxRedundantPayloads;
2418 }
2419 rtp_sender_->SetRtxStatus(rtx_mode);
2420
2421 for (auto extension_type : kBweExtensionTypes) {
2422 EXPECT_FALSE(rtp_sender_->SupportsPadding());
2423 rtp_sender_->RegisterRtpHeaderExtension(extension_type, kExtensionsId);
2424 if (!sending_media) {
2425 EXPECT_FALSE(rtp_sender_->SupportsPadding());
2426 } else {
2427 EXPECT_TRUE(rtp_sender_->SupportsPadding());
2428 if (redundant_payloads) {
2429 EXPECT_TRUE(rtp_sender_->SupportsRtxPayloadPadding());
2430 } else {
2431 EXPECT_FALSE(rtp_sender_->SupportsRtxPayloadPadding());
2432 }
2433 }
2434 rtp_sender_->DeregisterRtpHeaderExtension(extension_type);
2435 EXPECT_FALSE(rtp_sender_->SupportsPadding());
2436 }
2437 }
2438 }
2439}
2440
Erik Språnga57711c2019-07-24 10:47:20 +02002441TEST_P(RtpSenderTest, SetsCaptureTimeAndPopulatesTransmissionOffset) {
2442 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
2443 kTransmissionTimeOffsetExtensionId);
2444
2445 rtp_sender_->SetSendingMediaStatus(true);
2446 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
2447 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
2448 rtp_sender_->SetStorePacketsStatus(true, 10);
2449
2450 const int64_t kMissingCaptureTimeMs = 0;
2451 const uint32_t kTimestampTicksPerMs = 90;
2452 const int64_t kOffsetMs = 10;
2453
Erik Språnga57711c2019-07-24 10:47:20 +02002454 auto packet =
2455 BuildRtpPacket(kPayload, kMarkerBit, fake_clock_.TimeInMilliseconds(),
2456 kMissingCaptureTimeMs);
2457 packet->set_packet_type(RtpPacketToSend::Type::kVideo);
2458 packet->ReserveExtension<TransmissionOffset>();
2459 packet->AllocatePayload(sizeof(kPayloadData));
2460
2461 std::unique_ptr<RtpPacketToSend> packet_to_pace;
2462 EXPECT_CALL(mock_paced_sender_, EnqueuePacket)
2463 .WillOnce([&](std::unique_ptr<RtpPacketToSend> packet) {
2464 EXPECT_GT(packet->capture_time_ms(), 0);
2465 packet_to_pace = std::move(packet);
2466 });
2467
2468 EXPECT_TRUE(
2469 rtp_sender_->SendToNetwork(std::move(packet), kAllowRetransmission));
2470
2471 fake_clock_.AdvanceTimeMilliseconds(kOffsetMs);
2472
2473 rtp_sender_->TrySendPacket(packet_to_pace.get(), PacedPacketInfo());
Erik Språnga57711c2019-07-24 10:47:20 +02002474
2475 EXPECT_EQ(1, transport_.packets_sent());
2476 absl::optional<int32_t> transmission_time_extension =
2477 transport_.sent_packets_.back().GetExtension<TransmissionOffset>();
2478 ASSERT_TRUE(transmission_time_extension.has_value());
2479 EXPECT_EQ(*transmission_time_extension, kOffsetMs * kTimestampTicksPerMs);
2480
2481 // Retransmit packet. The RTX packet should get the same capture time as the
2482 // original packet, so offset is delta from original packet to now.
2483 fake_clock_.AdvanceTimeMilliseconds(kOffsetMs);
2484
Erik Språnga57711c2019-07-24 10:47:20 +02002485 std::unique_ptr<RtpPacketToSend> rtx_packet_to_pace;
2486 EXPECT_CALL(mock_paced_sender_, EnqueuePacket)
2487 .WillOnce([&](std::unique_ptr<RtpPacketToSend> packet) {
2488 EXPECT_GT(packet->capture_time_ms(), 0);
2489 rtx_packet_to_pace = std::move(packet);
2490 });
2491
2492 EXPECT_GT(rtp_sender_->ReSendPacket(kSeqNum), 0);
2493 rtp_sender_->TrySendPacket(rtx_packet_to_pace.get(), PacedPacketInfo());
Erik Språnga57711c2019-07-24 10:47:20 +02002494
2495 EXPECT_EQ(2, transport_.packets_sent());
2496 transmission_time_extension =
2497 transport_.sent_packets_.back().GetExtension<TransmissionOffset>();
2498 ASSERT_TRUE(transmission_time_extension.has_value());
2499 EXPECT_EQ(*transmission_time_extension, 2 * kOffsetMs * kTimestampTicksPerMs);
2500}
2501
Erik Språng6cacef22019-07-24 14:15:51 +02002502TEST_P(RtpSenderTestWithoutPacer, ClearHistoryOnSsrcChange) {
2503 const int64_t kRtt = 10;
2504
2505 rtp_sender_->SetSendingMediaStatus(true);
2506 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
2507 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
2508 rtp_sender_->SetStorePacketsStatus(true, 10);
2509 rtp_sender_->SetRtt(kRtt);
Erik Språng6cacef22019-07-24 14:15:51 +02002510
2511 // Send a packet and record its sequence numbers.
2512 SendGenericPacket();
2513 ASSERT_EQ(1u, transport_.sent_packets_.size());
2514 const uint16_t packet_seqence_number =
2515 transport_.sent_packets_.back().SequenceNumber();
2516
2517 // Advance time and make sure it can be retransmitted, even if we try to set
2518 // the ssrc the what it already is.
2519 rtp_sender_->SetSSRC(kSsrc);
2520 fake_clock_.AdvanceTimeMilliseconds(kRtt);
2521 EXPECT_GT(rtp_sender_->ReSendPacket(packet_seqence_number), 0);
2522
2523 // Change the SSRC, then move the time and try to retransmit again. The old
2524 // packet should now be gone.
2525 rtp_sender_->SetSSRC(kSsrc + 1);
2526 fake_clock_.AdvanceTimeMilliseconds(kRtt);
2527 EXPECT_EQ(rtp_sender_->ReSendPacket(packet_seqence_number), 0);
2528}
2529
2530TEST_P(RtpSenderTestWithoutPacer, ClearHistoryOnSequenceNumberCange) {
2531 const int64_t kRtt = 10;
2532
2533 rtp_sender_->SetSendingMediaStatus(true);
2534 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
2535 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
2536 rtp_sender_->SetStorePacketsStatus(true, 10);
2537 rtp_sender_->SetRtt(kRtt);
2538
2539 // Send a packet and record its sequence numbers.
2540 SendGenericPacket();
2541 ASSERT_EQ(1u, transport_.sent_packets_.size());
2542 const uint16_t packet_seqence_number =
2543 transport_.sent_packets_.back().SequenceNumber();
2544
2545 // Advance time and make sure it can be retransmitted, even if we try to set
2546 // the ssrc the what it already is.
2547 rtp_sender_->SetSequenceNumber(rtp_sender_->SequenceNumber());
2548 fake_clock_.AdvanceTimeMilliseconds(kRtt);
2549 EXPECT_GT(rtp_sender_->ReSendPacket(packet_seqence_number), 0);
2550
2551 // Change the sequence number, then move the time and try to retransmit again.
2552 // The old packet should now be gone.
2553 rtp_sender_->SetSequenceNumber(rtp_sender_->SequenceNumber() - 1);
2554 fake_clock_.AdvanceTimeMilliseconds(kRtt);
2555 EXPECT_EQ(rtp_sender_->ReSendPacket(packet_seqence_number), 0);
2556}
2557
Erik Språng60ffc312019-07-30 22:03:49 +02002558TEST_P(RtpSenderTest, IgnoresNackAfterDisablingMedia) {
2559 const int64_t kRtt = 10;
2560
2561 rtp_sender_->SetSendingMediaStatus(true);
2562 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
2563 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
2564 rtp_sender_->SetStorePacketsStatus(true, 10);
2565 rtp_sender_->SetRtt(kRtt);
2566
2567 // Send a packet so it is in the packet history.
Erik Språng60ffc312019-07-30 22:03:49 +02002568 std::unique_ptr<RtpPacketToSend> packet_to_pace;
2569 EXPECT_CALL(mock_paced_sender_, EnqueuePacket)
2570 .WillOnce([&](std::unique_ptr<RtpPacketToSend> packet) {
2571 packet_to_pace = std::move(packet);
2572 });
2573
2574 SendGenericPacket();
2575 rtp_sender_->TrySendPacket(packet_to_pace.get(), PacedPacketInfo());
2576
2577 ASSERT_EQ(1u, transport_.sent_packets_.size());
2578
2579 // Disable media sending and try to retransmit the packet, it should fail.
2580 rtp_sender_->SetSendingMediaStatus(false);
2581 fake_clock_.AdvanceTimeMilliseconds(kRtt);
2582 EXPECT_LT(rtp_sender_->ReSendPacket(kSeqNum), 0);
Erik Språng60ffc312019-07-30 22:03:49 +02002583}
2584
Mirko Bonadeic84f6612019-01-31 12:20:57 +01002585INSTANTIATE_TEST_SUITE_P(WithAndWithoutOverhead,
2586 RtpSenderTest,
Erik Språngf5815fa2019-08-21 14:27:31 +02002587 ::testing::Values(TestConfig{false},
2588 TestConfig{true}));
Erik Språngf6468d22019-07-05 16:53:43 +02002589
Mirko Bonadeic84f6612019-01-31 12:20:57 +01002590INSTANTIATE_TEST_SUITE_P(WithAndWithoutOverhead,
2591 RtpSenderTestWithoutPacer,
Erik Språngf5815fa2019-08-21 14:27:31 +02002592 ::testing::Values(TestConfig{false},
2593 TestConfig{true}));
Niels Möllera34d7762019-02-01 14:13:29 +01002594
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00002595} // namespace webrtc