blob: 2302f8473a60a7963b0488bb9aeb130bf2c24e7b [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +000011#include <algorithm>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000012#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080013#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070014#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000015#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000016
Seth Hampson24722b32017-12-22 09:36:42 -080017#include "api/rtpparameters.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070018#include "api/test/mock_video_decoder_factory.h"
19#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020020#include "api/units/time_delta.h"
Åsa Persson23eba222018-10-02 14:47:06 +020021#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020022#include "api/video_codecs/builtin_video_decoder_factory.h"
23#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020024#include "api/video_codecs/sdp_video_format.h"
25#include "api/video_codecs/video_decoder_factory.h"
26#include "api/video_codecs/video_encoder.h"
27#include "api/video_codecs/video_encoder_factory.h"
28#include "call/flexfec_receive_stream.h"
29#include "common_video/h264/profile_level_id.h"
30#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller6557d0c2018-04-11 15:18:34 +020031#include "media/base/fakenetworkinterface.h"
32#include "media/base/fakevideocapturer.h"
33#include "media/base/fakevideorenderer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020034#include "media/base/mediaconstants.h"
35#include "media/base/rtputils.h"
36#include "media/base/testutils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020037#include "media/engine/constants.h"
38#include "media/engine/fakewebrtccall.h"
39#include "media/engine/fakewebrtcvideoengine.h"
40#include "media/engine/simulcast.h"
41#include "media/engine/webrtcvideoengine.h"
42#include "media/engine/webrtcvoiceengine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020043#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020044#include "rtc_base/arraysize.h"
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +020045#include "rtc_base/fakeclock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020046#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020047#include "rtc_base/numerics/safe_conversions.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020048#include "rtc_base/stringutils.h"
49#include "test/field_trial.h"
50#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000051
Tommi85959932018-02-07 19:26:06 +010052using cricket::FakeVideoCapturerWithTaskQueue;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010053using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070054using webrtc::RtpExtension;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010055using testing::Field;
isheriff6f8d6862016-05-26 11:24:55 -070056
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000057namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000058static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000059
noahricd10a68e2015-07-10 11:27:55 -070060static const uint8_t kRedRtxPayloadType = 125;
61
Niels Möller6557d0c2018-04-11 15:18:34 +020062static const uint32_t kTimeout = 5000U;
63static const uint32_t kDefaultReceiveSsrc = 0;
64static const uint32_t kSsrc = 1234u;
65static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
66static const int kVideoWidth = 640;
67static const int kVideoHeight = 360;
68static const int kFramerate = 30;
69
Peter Boström0c4e06b2015-10-07 12:23:21 +020070static const uint32_t kSsrcs1[] = {1};
71static const uint32_t kSsrcs3[] = {1, 2, 3};
72static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080073static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020074static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080075static const uint32_t kDefaultRecvSsrc = 0;
76
pbos@webrtc.org3c107582014-07-20 15:27:35 +000077static const char kUnsupportedExtensionName[] =
78 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000079
magjed509e4fe2016-11-18 01:34:11 -080080cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
81 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020082 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080083}
84
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000085void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
86 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
87 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
88 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
89 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
90 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
91 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
92 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -080093 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
94 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000095 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
96}
97
magjed725e4842016-11-16 00:48:13 -080098// Return true if any codec in |codecs| is an RTX codec with associated payload
99// type |payload_type|.
100bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
101 int payload_type) {
102 for (const cricket::VideoCodec& codec : codecs) {
103 int associated_payload_type;
104 if (cricket::CodecNamesEq(codec.name.c_str(), "rtx") &&
105 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
106 &associated_payload_type) &&
107 associated_payload_type == payload_type) {
108 return true;
109 }
110 }
111 return false;
112}
113
nisseca5706d2017-09-11 02:32:16 -0700114// TODO(nisse): Duplicated in call.cc.
115const int* FindKeyByValue(const std::map<int, int>& m, int v) {
116 for (const auto& kv : m) {
117 if (kv.second == v)
118 return &kv.first;
119 }
120 return nullptr;
121}
122
Yves Gerey665174f2018-06-19 15:03:05 +0200123bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
124 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700125 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
126 payload_type) != nullptr;
127}
128
129// Check that there's an Rtx payload type for each decoder.
130bool VerifyRtxReceiveAssociations(
131 const webrtc::VideoReceiveStream::Config& config) {
132 for (const auto& decoder : config.decoders) {
133 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
134 return false;
135 }
136 return true;
137}
138
brandtrffc61182016-11-28 06:02:22 -0800139rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700140 int width,
141 int height) {
142 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
143 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800144 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700145 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000146}
147
Shao Changbine62202f2015-04-21 20:24:50 +0800148void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
149 const std::map<int, int>& rtx_types) {
150 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200151 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800152 EXPECT_TRUE(it != rtx_types.end() &&
153 it->second == config.rtp.rtx.payload_type);
154
brandtrb5f2c3f2016-10-04 23:28:39 -0700155 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
156 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800157 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700158 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800159 }
160}
kthelgason2bc68642017-02-07 07:02:22 -0800161
162cricket::MediaConfig GetMediaConfig() {
163 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100164 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800165 return media_config;
166}
nisse26e3abb2017-08-25 04:44:25 -0700167
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200168// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
169int GetMaxDefaultBitrateBps(size_t width, size_t height) {
170 if (width * height <= 320 * 240) {
171 return 600000;
172 } else if (width * height <= 640 * 480) {
173 return 1700000;
174 } else if (width * height <= 960 * 540) {
175 return 2000000;
176 } else {
177 return 2500000;
178 }
179}
180
Niels Möller731a2c22018-07-30 15:08:07 +0200181class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
182 public:
183 MOCK_METHOD2(AddOrUpdateSink,
184 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
185 const rtc::VideoSinkWants& wants));
186 MOCK_METHOD1(RemoveSink,
187 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
188};
189
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000190} // namespace
191
Yves Gerey665174f2018-06-19 15:03:05 +0200192#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200193 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200194 EXPECT_EQ((w), renderer_.width()); \
195 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200196 EXPECT_EQ(0, renderer_.errors());
197
Yves Gerey665174f2018-06-19 15:03:05 +0200198#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200199 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200200 EXPECT_EQ((w), (r).width()); \
201 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200202 EXPECT_EQ(0, (r).errors());
203
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000204namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700205class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000206 public:
eladalonf1841382017-06-12 01:16:46 -0700207 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
208 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700209 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700210 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200211 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
212 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +0200213 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200214 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200215 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200216 decoder_factory_)) {
217 // Ensure fake clock doesn't return 0, which will cause some initializations
218 // fail inside RTP senders.
219 fake_clock_.AdvanceTimeMicros(1);
220 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000221
222 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200223 void AssignDefaultAptRtxTypes();
224 void AssignDefaultCodec();
225
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100226 // Find the index of the codec in the engine with the given name. The codec
227 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100228 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100229
magjed509e4fe2016-11-18 01:34:11 -0800230 // Find the codec in the engine with the given name. The codec must be
231 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100232 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800233
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200234 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000235
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200236 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000237 const std::vector<VideoCodec>& codecs);
238
Peter Boströme4499152016-02-05 11:13:28 +0100239 void TestExtendedEncoderOveruse(bool use_external_encoder);
240
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200241 // Has to be the first one, so it is initialized before the call or there is a
242 // race condition in the clock access.
243 rtc::ScopedFakeClock fake_clock_;
stefanc1aeaf02015-10-15 07:26:07 -0700244 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700245 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700246 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000247 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800248 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200249 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
250 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -0700251 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000252 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800253 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000254};
255
eladalonf1841382017-06-12 01:16:46 -0700256TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200257 encoder_factory_->AddSupportedVideoCodecType("VP8");
258 AssignDefaultCodec();
259
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000260 std::vector<VideoCodec> engine_codecs = engine_.codecs();
261 for (size_t i = 0; i < engine_codecs.size(); ++i) {
262 if (engine_codecs[i].name != kRtxCodecName)
263 continue;
264 int associated_payload_type;
265 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000266 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000267 EXPECT_EQ(default_codec_.id, associated_payload_type);
268 return;
269 }
270 FAIL() << "No RTX codec found among default codecs.";
271}
272
eladalonf1841382017-06-12 01:16:46 -0700273TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100274 RtpCapabilities capabilities = engine_.GetCapabilities();
275 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700276 for (const RtpExtension& extension : capabilities.header_extensions) {
277 if (extension.uri == RtpExtension::kTimestampOffsetUri) {
278 EXPECT_EQ(RtpExtension::kTimestampOffsetDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000279 return;
280 }
281 }
282 FAIL() << "Timestamp offset extension not in header-extension list.";
283}
284
eladalonf1841382017-06-12 01:16:46 -0700285TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100286 RtpCapabilities capabilities = engine_.GetCapabilities();
287 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700288 for (const RtpExtension& extension : capabilities.header_extensions) {
289 if (extension.uri == RtpExtension::kAbsSendTimeUri) {
290 EXPECT_EQ(RtpExtension::kAbsSendTimeDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000291 return;
292 }
293 }
294 FAIL() << "Absolute Sender Time extension not in header-extension list.";
295}
296
eladalonf1841382017-06-12 01:16:46 -0700297TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100298 RtpCapabilities capabilities = engine_.GetCapabilities();
299 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700300 for (const RtpExtension& extension : capabilities.header_extensions) {
301 if (extension.uri == RtpExtension::kTransportSequenceNumberUri) {
302 EXPECT_EQ(RtpExtension::kTransportSequenceNumberDefaultId, extension.id);
stefanc1aeaf02015-10-15 07:26:07 -0700303 return;
304 }
305 }
306 FAIL() << "Transport sequence number extension not in header-extension list.";
307}
308
eladalonf1841382017-06-12 01:16:46 -0700309TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100310 RtpCapabilities capabilities = engine_.GetCapabilities();
311 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700312 for (const RtpExtension& extension : capabilities.header_extensions) {
313 if (extension.uri == RtpExtension::kVideoRotationUri) {
314 EXPECT_EQ(RtpExtension::kVideoRotationDefaultId, extension.id);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700315 return;
316 }
317 }
318 FAIL() << "Video Rotation extension not in header-extension list.";
319}
320
philipel1e054862018-10-08 16:13:53 +0200321class WebRtcVideoEngineTestWithGenericDescriptor
322 : public WebRtcVideoEngineTest {
323 public:
324 WebRtcVideoEngineTestWithGenericDescriptor()
325 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
326};
327
328TEST_F(WebRtcVideoEngineTestWithGenericDescriptor, AdvertiseGenericDescriptor) {
329 RtpCapabilities capabilities = engine_.GetCapabilities();
330 ASSERT_FALSE(capabilities.header_extensions.empty());
331 for (const RtpExtension& extension : capabilities.header_extensions) {
332 if (extension.uri == RtpExtension::kGenericFrameDescriptorUri) {
333 EXPECT_EQ(RtpExtension::kGenericFrameDescriptorDefaultId, extension.id);
334 return;
335 }
336 }
337 FAIL() << "Generic descriptor extension not in header-extension list.";
338}
339
eladalonf1841382017-06-12 01:16:46 -0700340TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200341 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700342 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200343 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700344
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200345 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700346
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200347 std::unique_ptr<VideoMediaChannel> channel(
348 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700349 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
350
351 // Add CVO extension.
352 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800353 cricket::VideoSendParameters parameters;
354 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200355 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700356 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200357 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700358
Niels Möller731a2c22018-07-30 15:08:07 +0200359 EXPECT_CALL(
360 video_source,
361 AddOrUpdateSink(testing::_,
362 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700363 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200364 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700365
366 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200367 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700368
369 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200370 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200371 EXPECT_CALL(
372 video_source,
373 AddOrUpdateSink(testing::_,
374 Field(&rtc::VideoSinkWants::rotation_applied, true)));
375
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200376 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700377}
378
eladalonf1841382017-06-12 01:16:46 -0700379TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200380 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800381 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200382 testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800383
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200384 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800385
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200386 std::unique_ptr<VideoMediaChannel> channel(
387 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800388 // Add CVO extension.
389 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800390 cricket::VideoSendParameters parameters;
391 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800392 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700393 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800394 EXPECT_TRUE(channel->SetSendParameters(parameters));
395 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
396
Niels Möller731a2c22018-07-30 15:08:07 +0200397 // Set source.
398 EXPECT_CALL(
399 video_source,
400 AddOrUpdateSink(testing::_,
401 Field(&rtc::VideoSinkWants::rotation_applied, false)));
402 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800403}
404
eladalonf1841382017-06-12 01:16:46 -0700405TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200406 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700407
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200408 encoder_factory_->AddSupportedVideoCodecType("VP8");
409 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700410
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200411 std::unique_ptr<VideoMediaChannel> channel(
412 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700413 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
414
415 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200416 EXPECT_CALL(
417 video_source,
418 AddOrUpdateSink(testing::_,
419 Field(&rtc::VideoSinkWants::rotation_applied, true)));
420 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700421
perkjcaafdba2016-03-20 07:34:29 -0700422 // Verify capturer has turned on applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200423 testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700424
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700425 // Add CVO extension.
426 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800427 cricket::VideoSendParameters parameters;
428 parameters.codecs.push_back(GetEngineCodec("VP8"));
429 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200430 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700431 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700432 // Also remove the first codec to trigger a codec change as well.
433 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200434 EXPECT_CALL(
435 video_source,
436 AddOrUpdateSink(testing::_,
437 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200438 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700439
440 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200441 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700442
443 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200444 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200445 EXPECT_CALL(
446 video_source,
447 AddOrUpdateSink(testing::_,
448 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200449 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700450}
451
eladalonf1841382017-06-12 01:16:46 -0700452TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200453 encoder_factory_->AddSupportedVideoCodecType("VP8");
454
kwiberg686a8ef2016-02-26 03:00:35 -0800455 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800456 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000457
458 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
459
460 EXPECT_FALSE(channel->SetSend(true))
461 << "Channel should not start without codecs.";
462 EXPECT_TRUE(channel->SetSend(false))
463 << "Channel should be stoppable even without set codecs.";
464}
465
eladalonf1841382017-06-12 01:16:46 -0700466TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200467 encoder_factory_->AddSupportedVideoCodecType("VP8");
468
kwiberg686a8ef2016-02-26 03:00:35 -0800469 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800470 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000471 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
472 VideoMediaInfo info;
473 channel->GetStats(&info);
474}
475
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200476TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200477 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000478
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200479 std::unique_ptr<VideoMediaChannel> channel(
480 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800481 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000482
483 EXPECT_TRUE(
484 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200485 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000486 EXPECT_TRUE(channel->SetSend(true));
Tommi85959932018-02-07 19:26:06 +0100487 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200488 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000489 EXPECT_EQ(cricket::CS_RUNNING,
490 capturer.Start(capturer.GetSupportedFormats()->front()));
491 EXPECT_TRUE(capturer.CaptureFrame());
Per21d45d22016-10-30 21:37:57 +0100492 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200493 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
494 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000495 kTimeout);
496
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200497 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100498 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000499
500 // Setting codecs of the same type should not reallocate any encoders
501 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800502 cricket::VideoSendParameters parameters;
503 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200504 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200505 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000506
507 // Remove stream previously added to free the external encoder instance.
508 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200509 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000510}
511
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200512// Test that when an encoder factory supports H264, we add an RTX
513// codec for it.
514// TODO(deadbeef): This test should be updated if/when we start
515// adding RTX codecs for unrecognized codec names.
516TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800517 using webrtc::H264::ProfileLevelIdToString;
518 using webrtc::H264::ProfileLevelId;
519 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200520 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
521 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800522 *ProfileLevelIdToString(
523 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200524 webrtc::SdpVideoFormat h264_constrained_high("H264");
525 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800526 *ProfileLevelIdToString(
527 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200528 webrtc::SdpVideoFormat h264_high("H264");
529 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800530 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
531
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200532 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
533 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
534 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700535
magjed725e4842016-11-16 00:48:13 -0800536 // First figure out what payload types the test codecs got assigned.
537 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800538 // Now search for RTX codecs for them. Expect that they all have associated
539 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800540 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200541 codecs,
542 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
543 ->id));
magjed725e4842016-11-16 00:48:13 -0800544 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200545 codecs,
546 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
547 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800548 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200549 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700550}
551
Peter Boström12996152016-05-14 02:03:18 +0200552#if !defined(RTC_DISABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700553TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200554 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100555
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200556 std::unique_ptr<VideoMediaChannel> channel(
557 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100558
559 EXPECT_TRUE(
560 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
561}
Peter Boström12996152016-05-14 02:03:18 +0200562#endif // !defined(RTC_DISABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100563
eladalonf1841382017-06-12 01:16:46 -0700564TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200565 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100566 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200567 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200568 std::unique_ptr<VideoMediaChannel> channel(
569 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700570
571 EXPECT_TRUE(
572 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
573
Tommi85959932018-02-07 19:26:06 +0100574 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200575 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
qiangchenc27d89f2015-07-16 10:27:16 -0700576 capturer.Start(cricket::VideoFormat(1280, 720,
577 cricket::VideoFormat::FpsToInterval(60),
578 cricket::FOURCC_I420));
579 channel->SetSend(true);
580
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200581 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700582
583 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700584 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700585 for (int i = 0; i < 10; i++) {
586 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700587 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700588 int64_t interval = timestamp - last_timestamp;
589
590 // Precision changes from nanosecond to millisecond.
591 // Allow error to be no more than 1.
592 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
593
594 last_timestamp = timestamp;
595 }
596
597 capturer.Start(cricket::VideoFormat(1280, 720,
598 cricket::VideoFormat::FpsToInterval(30),
599 cricket::FOURCC_I420));
600
601 EXPECT_TRUE(capturer.CaptureFrame());
602 last_timestamp = stream->GetLastTimestamp();
603 for (int i = 0; i < 10; i++) {
604 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700605 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700606 int64_t interval = timestamp - last_timestamp;
607
608 // Precision changes from nanosecond to millisecond.
609 // Allow error to be no more than 1.
610 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
611
612 last_timestamp = timestamp;
613 }
614
615 // Remove stream previously added to free the external encoder instance.
616 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
617}
618
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200619void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
620 std::vector<VideoCodec> engine_codecs = engine_.codecs();
621 RTC_DCHECK(!engine_codecs.empty());
622 for (const cricket::VideoCodec& codec : engine_codecs) {
623 if (codec.name == "rtx") {
624 int associated_payload_type;
625 if (codec.GetParam(kCodecParamAssociatedPayloadType,
626 &associated_payload_type)) {
627 default_apt_rtx_types_[associated_payload_type] = codec.id;
628 }
629 }
630 }
631}
632
633void WebRtcVideoEngineTest::AssignDefaultCodec() {
634 std::vector<VideoCodec> engine_codecs = engine_.codecs();
635 RTC_DCHECK(!engine_codecs.empty());
636 bool codec_set = false;
637 for (const cricket::VideoCodec& codec : engine_codecs) {
638 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
639 codec.name != "ulpfec") {
640 default_codec_ = codec;
641 codec_set = true;
642 }
643 }
644
645 RTC_DCHECK(codec_set);
646}
647
Oleh Prypina40f8242017-12-21 13:32:23 +0100648size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
649 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100650 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
651 for (size_t i = 0; i < codecs.size(); ++i) {
652 const cricket::VideoCodec engine_codec = codecs[i];
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200653 if (!CodecNamesEq(name, engine_codec.name))
654 continue;
655 // The tests only use H264 Constrained Baseline. Make sure we don't return
656 // an internal H264 codec from the engine with a different H264 profile.
657 if (CodecNamesEq(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200658 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200659 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
660 if (profile_level_id->profile !=
661 webrtc::H264::kProfileConstrainedBaseline) {
662 continue;
663 }
664 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100665 return i;
magjed509e4fe2016-11-18 01:34:11 -0800666 }
667 // This point should never be reached.
668 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100669 return -1;
670}
671
672cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
673 const std::string& name) const {
674 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800675}
676
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200677VideoMediaChannel*
678WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
buildbot@webrtc.org1ecbe452014-10-14 20:29:28 +0000679 VideoMediaChannel* channel =
kthelgason2bc68642017-02-07 07:02:22 -0800680 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200681 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800682 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200683 for (const webrtc::SdpVideoFormat& format :
684 encoder_factory_->GetSupportedFormats()) {
685 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
686 if (std::find(parameters.codecs.begin(), parameters.codecs.end(),
687 engine_codec) == parameters.codecs.end()) {
688 parameters.codecs.push_back(engine_codec);
689 }
690 }
magjed509e4fe2016-11-18 01:34:11 -0800691
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200692 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000693
694 return channel;
695}
696
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200697VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000698 const std::vector<VideoCodec>& codecs) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000699 VideoMediaChannel* channel =
kthelgason2bc68642017-02-07 07:02:22 -0800700 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200701 cricket::VideoRecvParameters parameters;
702 parameters.codecs = codecs;
703 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000704
705 return channel;
706}
707
eladalonf1841382017-06-12 01:16:46 -0700708TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200709 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000710
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200711 std::unique_ptr<VideoMediaChannel> channel(
712 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000713
Peter Boström0c4e06b2015-10-07 12:23:21 +0200714 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000715
Yves Gerey665174f2018-06-19 15:03:05 +0200716 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000717 EXPECT_TRUE(channel->SetSend(true));
718
Tommi85959932018-02-07 19:26:06 +0100719 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200720 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000721 EXPECT_EQ(cricket::CS_RUNNING,
722 capturer.Start(capturer.GetSupportedFormats()->front()));
723 EXPECT_TRUE(capturer.CaptureFrame());
724
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200725 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000726
727 // Verify that encoders are configured for simulcast through adapter
728 // (increasing resolution and only configured to send one stream each).
729 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200730 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
731 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000732 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200733 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000734 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
735 EXPECT_GT(codec_settings.width, prev_width);
736 prev_width = codec_settings.width;
737 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000738
Niels Möllerff40b142018-04-09 08:49:14 +0200739 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000740
741 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200742 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000743}
744
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200745TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
746 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200747 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000748
Niels Möller4db138e2018-04-19 09:04:13 +0200749 // Set capturer.
750 FakeVideoCapturerWithTaskQueue capturer;
751 EXPECT_EQ(cricket::CS_RUNNING,
752 capturer.Start(capturer.GetSupportedFormats()->front()));
753
Anders Carlsson67537952018-05-03 11:28:29 +0200754 std::unique_ptr<VideoMediaChannel> channel(
755 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
756 cricket::VideoSendParameters parameters;
757 parameters.codecs.push_back(GetEngineCodec("H264"));
758 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000759
760 EXPECT_TRUE(
761 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller4db138e2018-04-19 09:04:13 +0200762 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
763 // Sending one frame will have allocate the encoder.
764 EXPECT_TRUE(capturer.CaptureFrame());
765
766 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000767
Anders Carlsson67537952018-05-03 11:28:29 +0200768 cricket::VideoSendParameters new_parameters;
769 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
770 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200771
772 // Sending one frame will switch encoder.
773 EXPECT_TRUE(capturer.CaptureFrame());
774
Anders Carlsson8a150d92018-05-14 12:40:04 +0200775 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000776}
777
eladalonf1841382017-06-12 01:16:46 -0700778TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000779 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200780 encoder_factory_->AddSupportedVideoCodecType("VP8");
781 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000782
kwiberg686a8ef2016-02-26 03:00:35 -0800783 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800784 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800785 cricket::VideoSendParameters parameters;
786 parameters.codecs.push_back(GetEngineCodec("VP8"));
787 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000788
Peter Boström0c4e06b2015-10-07 12:23:21 +0200789 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000790
Yves Gerey665174f2018-06-19 15:03:05 +0200791 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000792 EXPECT_TRUE(channel->SetSend(true));
793
794 // Send a fake frame, or else the media engine will configure the simulcast
795 // encoder adapter at a low-enough size that it'll only create a single
796 // encoder layer.
Tommi85959932018-02-07 19:26:06 +0100797 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200798 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000799 EXPECT_EQ(cricket::CS_RUNNING,
800 capturer.Start(capturer.GetSupportedFormats()->front()));
801 EXPECT_TRUE(capturer.CaptureFrame());
802
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200803 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
804 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000805 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200806 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000807
808 channel.reset();
809 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200810 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000811}
812
eladalonf1841382017-06-12 01:16:46 -0700813TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000814 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200815 encoder_factory_->AddSupportedVideoCodecType("VP8");
816 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000817
kwiberg686a8ef2016-02-26 03:00:35 -0800818 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800819 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800820 cricket::VideoSendParameters parameters;
821 parameters.codecs.push_back(GetEngineCodec("H264"));
822 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000823
824 EXPECT_TRUE(
825 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100826
827 // Send a frame of 720p. This should trigger a "real" encoder initialization.
828 cricket::VideoFormat format(
829 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100830 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200831 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Per21d45d22016-10-30 21:37:57 +0100832 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
833 EXPECT_TRUE(capturer.CaptureFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200834 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
835 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200836 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000837 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200838 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000839
840 channel.reset();
841 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200842 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000843}
844
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200845TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
846 webrtc::test::ScopedFieldTrials override_field_trials_(
847 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200848 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700849
Anders Carlsson67537952018-05-03 11:28:29 +0200850 std::unique_ptr<VideoMediaChannel> channel(
851 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
852 cricket::VideoSendParameters parameters;
853 parameters.codecs.push_back(GetEngineCodec("H264"));
854 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700855
Peter Boström0c4e06b2015-10-07 12:23:21 +0200856 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700857 EXPECT_TRUE(
858 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100859
860 // Send a frame of 720p. This should trigger a "real" encoder initialization.
noahricfdac5162015-08-27 01:59:29 -0700861 cricket::VideoFormat format(
862 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100863 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200864 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &capturer));
Peter Boströmce23bee2016-02-02 14:14:30 +0100865 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
866 EXPECT_TRUE(capturer.CaptureFrame());
867
Niels Möller4db138e2018-04-19 09:04:13 +0200868 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200869 ASSERT_EQ(1u, encoder_factory_->encoders().size());
870 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
871 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700872 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200873 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200874 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700875}
876
brandtrffc61182016-11-28 06:02:22 -0800877// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700878// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800879//
880// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700881TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800882 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200883 encoder_factory_->AddSupportedVideoCodecType("VP8");
884
brandtrffc61182016-11-28 06:02:22 -0800885 auto is_flexfec = [](const VideoCodec& codec) {
886 if (codec.name == "flexfec-03")
887 return true;
888 return false;
889 };
890
891 // FlexFEC is not active without field trial.
brandtrffc61182016-11-28 06:02:22 -0800892 const std::vector<VideoCodec> codecs_before = engine_.codecs();
893 EXPECT_EQ(codecs_before.end(), std::find_if(codecs_before.begin(),
894 codecs_before.end(), is_flexfec));
895
896 // FlexFEC is active with field trial.
897 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800898 "WebRTC-FlexFEC-03-Advertised/Enabled/");
brandtrffc61182016-11-28 06:02:22 -0800899 const std::vector<VideoCodec> codecs_after = engine_.codecs();
900 EXPECT_NE(codecs_after.end(),
901 std::find_if(codecs_after.begin(), codecs_after.end(), is_flexfec));
902}
903
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200904// Test that codecs are added in the order they are reported from the factory.
905TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
906 encoder_factory_->AddSupportedVideoCodecType("VP8");
907 const char* kFakeCodecName = "FakeCodec";
908 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000909
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200910 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100911 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200912 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
913 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000914}
915
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200916// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800917// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200918TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100919 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
920 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100921
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100922 // Set up external encoder factory with first codec, and initialize engine.
923 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
924
brandtrffc61182016-11-28 06:02:22 -0800925 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800926
927 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100928 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800929 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200930 // The codec itself and RTX should have been added.
931 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100932
933 // Check that both fake codecs are present and that the second fake codec
934 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100935 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
936 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100937 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800938}
939
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200940TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
941 const char* kFakeCodecName = "FakeCodec";
942 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
943
944 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
945 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
946}
947
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200948TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
949 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200950 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200951 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800952 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000953
kwiberg686a8ef2016-02-26 03:00:35 -0800954 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200955 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000956
957 EXPECT_TRUE(
958 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200959 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000960
961 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200962 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200963 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000964
965 // Remove stream previously added to free the external decoder instance.
966 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200967 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000968}
969
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200970// Verifies that we can set up decoders.
971TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000972 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
973 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
974 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
975 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200976 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +0200977 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000978 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800979 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000980
kwiberg686a8ef2016-02-26 03:00:35 -0800981 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200982 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000983
984 EXPECT_TRUE(
985 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200986 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000987}
988
Jonas Oreland49ac5952018-09-26 16:04:32 +0200989// Tests when GetSources is called with non-existing ssrc, it will return an
990// empty list of RtpSource without crashing.
991TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
992 // Setup an recv stream with |kSsrc|.
993 encoder_factory_->AddSupportedVideoCodecType("VP8");
994 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
995 cricket::VideoRecvParameters parameters;
996 parameters.codecs.push_back(GetEngineCodec("VP8"));
997 std::unique_ptr<VideoMediaChannel> channel(
998 SetRecvParamsWithSupportedCodecs(parameters.codecs));
999
1000 EXPECT_TRUE(
1001 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1002
1003 // Call GetSources with |kSsrc + 1| which doesn't exist.
1004 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1005 EXPECT_EQ(0u, sources.size());
1006}
1007
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001008TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1009 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1010 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
1011 WebRtcVideoEngine engine(std::move(encoder_factory),
1012 std::move(decoder_factory));
1013 EXPECT_EQ(0u, engine.codecs().size());
1014}
1015
1016TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1017 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001018 webrtc::MockVideoEncoderFactory* encoder_factory =
1019 new webrtc::MockVideoEncoderFactory();
1020 webrtc::MockVideoDecoderFactory* decoder_factory =
1021 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001022 WebRtcVideoEngine engine(
1023 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1024 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1025 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1026 EXPECT_EQ(0u, engine.codecs().size());
1027 EXPECT_CALL(*encoder_factory, Die());
1028 EXPECT_CALL(*decoder_factory, Die());
1029}
1030
1031// Test full behavior in the video engine when video codec factories of the new
1032// type are injected supporting the single codec Vp8. Check the returned codecs
1033// from the engine and that we will create a Vp8 encoder and decoder using the
1034// new factories.
1035TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1036 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001037 webrtc::MockVideoEncoderFactory* encoder_factory =
1038 new webrtc::MockVideoEncoderFactory();
1039 webrtc::MockVideoDecoderFactory* decoder_factory =
1040 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001041 WebRtcVideoEngine engine(
1042 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1043 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1044 const webrtc::SdpVideoFormat vp8_format("VP8");
1045 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1046 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1047 .WillRepeatedly(testing::Return(supported_formats));
1048
1049 // Verify the codecs from the engine.
1050 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001051 // Verify default codecs has been added correctly.
1052 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001053 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001054
1055 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001056 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001057 int vp8_associated_payload;
1058 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1059 &vp8_associated_payload));
1060 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1061
1062 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1063
1064 // RTX codec for RED.
1065 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1066 int red_associated_payload;
1067 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1068 &red_associated_payload));
1069 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1070
1071 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1072
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001073 int associated_payload_type;
1074 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1075 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1076 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1077 // Verify default parameters has been added to the VP8 codec.
1078 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
1079
1080 // Mock encoder creation. |engine| take ownership of the encoder.
1081 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1082 codec_info.is_hardware_accelerated = false;
1083 codec_info.has_internal_source = false;
1084 const webrtc::SdpVideoFormat format("VP8");
1085 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
1086 .WillRepeatedly(testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001087 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möller4db138e2018-04-19 09:04:13 +02001088 rtc::Event encoder_created(false, false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001089 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001090 .WillOnce(
1091 ::testing::DoAll(::testing::InvokeWithoutArgs(
1092 [&encoder_created]() { encoder_created.Set(); }),
1093 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001094
1095 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001096 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001097 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
1098 .WillOnce(testing::Return(decoder));
1099
1100 // Create a call.
1101 webrtc::RtcEventLogNullImpl event_log;
1102 std::unique_ptr<webrtc::Call> call(
1103 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1104
1105 // Create send channel.
1106 const int send_ssrc = 123;
1107 std::unique_ptr<VideoMediaChannel> send_channel(
1108 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
1109 cricket::VideoSendParameters send_parameters;
1110 send_parameters.codecs.push_back(engine_codecs.at(0));
1111 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1112 send_channel->OnReadyToSend(true);
1113 EXPECT_TRUE(
1114 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1115 EXPECT_TRUE(send_channel->SetSend(true));
1116
Niels Möller4db138e2018-04-19 09:04:13 +02001117 // Set capturer.
1118 FakeVideoCapturerWithTaskQueue capturer;
1119 EXPECT_EQ(cricket::CS_RUNNING,
1120 capturer.Start(capturer.GetSupportedFormats()->front()));
1121 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &capturer));
1122 // Sending one frame will allocate the encoder.
1123 EXPECT_TRUE(capturer.CaptureFrame());
1124 encoder_created.Wait(kTimeout);
1125
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001126 // Create recv channel.
1127 const int recv_ssrc = 321;
1128 std::unique_ptr<VideoMediaChannel> recv_channel(
1129 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
1130 cricket::VideoRecvParameters recv_parameters;
1131 recv_parameters.codecs.push_back(engine_codecs.at(0));
1132 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1133 EXPECT_TRUE(recv_channel->AddRecvStream(
1134 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1135
1136 // Remove streams previously added to free the encoder and decoder instance.
1137 EXPECT_CALL(*encoder_factory, Die());
1138 EXPECT_CALL(*decoder_factory, Die());
1139 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1140 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1141}
1142
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001143// Test behavior when decoder factory fails to create a decoder (returns null).
1144TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1145 // |engine| take ownership of the factories.
1146 webrtc::MockVideoEncoderFactory* encoder_factory =
1147 new testing::StrictMock<webrtc::MockVideoEncoderFactory>();
1148 webrtc::MockVideoDecoderFactory* decoder_factory =
1149 new testing::StrictMock<webrtc::MockVideoDecoderFactory>();
1150 WebRtcVideoEngine engine(
1151 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1152 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1153 const webrtc::SdpVideoFormat vp8_format("VP8");
1154 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1155 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1156 .WillRepeatedly(testing::Return(supported_formats));
1157
1158 // Decoder creation fails.
1159 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(testing::_))
1160 .WillOnce(testing::Return(nullptr));
1161
1162 // Create a call.
1163 webrtc::RtcEventLogNullImpl event_log;
1164 std::unique_ptr<webrtc::Call> call(
1165 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1166
1167 // Create recv channel.
1168 const int recv_ssrc = 321;
1169 std::unique_ptr<VideoMediaChannel> recv_channel(
1170 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
1171 cricket::VideoRecvParameters recv_parameters;
1172 recv_parameters.codecs.push_back(engine.codecs().front());
1173 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1174 EXPECT_TRUE(recv_channel->AddRecvStream(
1175 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1176
1177 // Remove streams previously added to free the encoder and decoder instance.
1178 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1179}
1180
eladalonf1841382017-06-12 01:16:46 -07001181TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001182 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001183 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001184 std::unique_ptr<VideoMediaChannel> channel(
1185 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001186 ASSERT_TRUE(
1187 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1188 cricket::VideoCodec codec = GetEngineCodec("VP8");
1189 cricket::VideoSendParameters parameters;
1190 parameters.codecs.push_back(codec);
1191 channel->OnReadyToSend(true);
1192 channel->SetSend(true);
1193 ASSERT_TRUE(channel->SetSendParameters(parameters));
1194
Tommi85959932018-02-07 19:26:06 +01001195 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08001196 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02001197 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001198
1199 EXPECT_EQ(cricket::CS_RUNNING,
1200 capturer.Start(capturer.GetSupportedFormats()->front()));
1201 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001202 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001203 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001204 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001205
Niels Möllerff40b142018-04-09 08:49:14 +02001206 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001207 EXPECT_TRUE(capturer.CaptureFrame());
1208 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001209 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001210
1211 options.is_screencast.emplace(true);
Niels Möllerff40b142018-04-09 08:49:14 +02001212 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001213 EXPECT_TRUE(capturer.CaptureFrame());
1214 // Change to screen content, recreate encoder. For the simulcast encoder
1215 // adapter case, this will result in two calls since InitEncode triggers a
1216 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001217 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001218 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001219 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001220
Niels Möllerff40b142018-04-09 08:49:14 +02001221 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001222 EXPECT_TRUE(capturer.CaptureFrame());
1223 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001224 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001225
1226 options.is_screencast.emplace(false);
1227 options.video_noise_reduction.emplace(false);
Niels Möllerff40b142018-04-09 08:49:14 +02001228 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001229 // Change back to regular video content, update encoder. Also change
1230 // a non |is_screencast| option just to verify it doesn't affect recreation.
1231 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001232 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001233 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001234 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001235
1236 // Remove stream previously added to free the external encoder instance.
1237 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001238 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001239}
1240
Niels Möller6557d0c2018-04-11 15:18:34 +02001241class WebRtcVideoChannelBaseTest : public testing::Test {
1242 protected:
1243 WebRtcVideoChannelBaseTest()
Jonas Oreland49ac5952018-09-26 16:04:32 +02001244 : engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001245 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001246
1247 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001248 // One testcase calls SetUp in a loop, only create call_ once.
1249 if (!call_) {
1250 call_.reset(webrtc::Call::Create(webrtc::Call::Config(&event_log_)));
1251 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001252 cricket::MediaConfig media_config;
1253 // Disabling cpu overuse detection actually disables quality scaling too; it
1254 // implies DegradationPreference kMaintainResolution. Automatic scaling
1255 // needs to be disabled, otherwise, tests which check the size of received
1256 // frames become flaky.
1257 media_config.video.enable_cpu_adaptation = false;
1258 channel_.reset(engine_.CreateChannel(call_.get(), media_config,
1259 cricket::VideoOptions()));
1260 channel_->OnReadyToSend(true);
1261 EXPECT_TRUE(channel_.get() != NULL);
1262 network_interface_.SetDestination(channel_.get());
Oleh Prypin37cf2452018-10-14 19:44:29 +00001263 channel_->SetInterface(&network_interface_);
Niels Möller6557d0c2018-04-11 15:18:34 +02001264 cricket::VideoRecvParameters parameters;
1265 parameters.codecs = engine_.codecs();
1266 channel_->SetRecvParameters(parameters);
1267 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
1268 video_capturer_.reset(CreateFakeVideoCapturer());
1269 cricket::VideoFormat format(640, 480,
1270 cricket::VideoFormat::FpsToInterval(kFramerate),
1271 cricket::FOURCC_I420);
1272 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001273 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001274 }
1275
1276 virtual cricket::FakeVideoCapturerWithTaskQueue* CreateFakeVideoCapturer() {
1277 return new cricket::FakeVideoCapturerWithTaskQueue();
1278 }
1279
1280 // Utility method to setup an additional stream to send and receive video.
1281 // Used to test send and recv between two streams.
1282 void SetUpSecondStream() {
1283 SetUpSecondStreamWithNoRecv();
1284 // Setup recv for second stream.
1285 EXPECT_TRUE(channel_->AddRecvStream(
1286 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1287 // Make the second renderer available for use by a new stream.
1288 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1289 }
1290 // Setup an additional stream just to send video. Defer add recv stream.
1291 // This is required if you want to test unsignalled recv of video rtp packets.
1292 void SetUpSecondStreamWithNoRecv() {
1293 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001294 EXPECT_TRUE(
1295 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001296 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001297 EXPECT_FALSE(
1298 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001299 EXPECT_TRUE(channel_->AddSendStream(
1300 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1301 // We dont add recv for the second stream.
1302
1303 // Setup the receive and renderer for second stream after send.
1304 video_capturer_2_.reset(CreateFakeVideoCapturer());
1305 cricket::VideoFormat format(640, 480,
1306 cricket::VideoFormat::FpsToInterval(kFramerate),
1307 cricket::FOURCC_I420);
1308 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(format));
1309
Yves Gerey665174f2018-06-19 15:03:05 +02001310 EXPECT_TRUE(
1311 channel_->SetVideoSend(kSsrc + 2, nullptr, video_capturer_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001312 }
Yves Gerey665174f2018-06-19 15:03:05 +02001313 virtual void TearDown() { channel_.reset(); }
1314 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001315
1316 bool SetOneCodec(const cricket::VideoCodec& codec) {
1317 cricket::VideoFormat capture_format(
1318 kVideoWidth, kVideoHeight,
1319 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1320
1321 if (video_capturer_) {
1322 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(capture_format));
1323 }
1324 if (video_capturer_2_) {
1325 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(capture_format));
1326 }
1327
1328 bool sending = channel_->sending();
1329 bool success = SetSend(false);
1330 if (success) {
1331 cricket::VideoSendParameters parameters;
1332 parameters.codecs.push_back(codec);
1333 success = channel_->SetSendParameters(parameters);
1334 }
1335 if (success) {
1336 success = SetSend(sending);
1337 }
1338 return success;
1339 }
Yves Gerey665174f2018-06-19 15:03:05 +02001340 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001341 bool SendFrame() {
1342 if (video_capturer_2_) {
1343 video_capturer_2_->CaptureFrame();
1344 }
1345 return video_capturer_.get() && video_capturer_->CaptureFrame();
1346 }
1347 bool WaitAndSendFrame(int wait_ms) {
1348 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
1349 ret &= SendFrame();
1350 return ret;
1351 }
Yves Gerey665174f2018-06-19 15:03:05 +02001352 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001353 int NumRtpBytes(uint32_t ssrc) {
1354 return network_interface_.NumRtpBytes(ssrc);
1355 }
Yves Gerey665174f2018-06-19 15:03:05 +02001356 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001357 int NumRtpPackets(uint32_t ssrc) {
1358 return network_interface_.NumRtpPackets(ssrc);
1359 }
Yves Gerey665174f2018-06-19 15:03:05 +02001360 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001361 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1362 return network_interface_.GetRtpPacket(index);
1363 }
1364 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001365 webrtc::RTPHeader header;
1366 EXPECT_TRUE(ParseRtpPacket(p, &header));
1367 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001368 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001369
Niels Möller6557d0c2018-04-11 15:18:34 +02001370 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001371 webrtc::RTPHeader* header) {
1372 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1373 webrtc::RtpHeaderParser::Create());
1374 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001375 }
1376
1377 // Tests that we can send and receive frames.
1378 void SendAndReceive(const cricket::VideoCodec& codec) {
1379 EXPECT_TRUE(SetOneCodec(codec));
1380 EXPECT_TRUE(SetSend(true));
1381 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1382 EXPECT_EQ(0, renderer_.num_rendered_frames());
1383 EXPECT_TRUE(SendFrame());
1384 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1385 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1386 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1387 }
1388
1389 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001390 int duration_sec,
1391 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001392 EXPECT_TRUE(SetOneCodec(codec));
1393 EXPECT_TRUE(SetSend(true));
1394 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1395 EXPECT_EQ(0, renderer_.num_rendered_frames());
1396 for (int i = 0; i < duration_sec; ++i) {
1397 for (int frame = 1; frame <= fps; ++frame) {
1398 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1399 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1400 }
1401 }
1402 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1403 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1404 }
1405
Niels Möller6557d0c2018-04-11 15:18:34 +02001406 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1407 cricket::VideoMediaInfo info;
1408 EXPECT_TRUE(channel_->GetStats(&info));
1409 return info.senders[i];
1410 }
1411
1412 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1413 cricket::VideoMediaInfo info;
1414 EXPECT_TRUE(channel_->GetStats(&info));
1415 return info.receivers[i];
1416 }
1417
1418 // Two streams one channel tests.
1419
1420 // Tests that we can send and receive frames.
1421 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1422 SetUpSecondStream();
1423 // Test sending and receiving on first stream.
1424 SendAndReceive(codec);
1425 // Test sending and receiving on second stream.
1426 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1427 EXPECT_GT(NumRtpPackets(), 0);
1428 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1429 }
1430
1431 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1432 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
1433 if (CodecNamesEq(name, engine_codec.name))
1434 return engine_codec;
1435 }
1436 // This point should never be reached.
1437 ADD_FAILURE() << "Unrecognized codec name: " << name;
1438 return cricket::VideoCodec();
1439 }
1440
1441 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1442
1443 cricket::StreamParams DefaultSendStreamParams() {
1444 return cricket::StreamParams::CreateLegacy(kSsrc);
1445 }
1446
1447 webrtc::RtcEventLogNullImpl event_log_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001448 std::unique_ptr<webrtc::Call> call_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001449 WebRtcVideoEngine engine_;
1450 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_;
1451 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_2_;
1452 std::unique_ptr<WebRtcVideoChannel> channel_;
1453 cricket::FakeNetworkInterface network_interface_;
1454 cricket::FakeVideoRenderer renderer_;
1455
1456 // Used by test cases where 2 streams are run on the same channel.
1457 cricket::FakeVideoRenderer renderer2_;
1458};
1459
1460// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001461TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001462 EXPECT_FALSE(channel_->sending());
Yves Gerey665174f2018-06-19 15:03:05 +02001463 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001464 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1465 EXPECT_FALSE(channel_->sending());
1466 EXPECT_TRUE(SetSend(true));
1467 EXPECT_TRUE(channel_->sending());
1468 EXPECT_TRUE(SendFrame());
1469 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1470 EXPECT_TRUE(SetSend(false));
1471 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001472}
Niels Möller6557d0c2018-04-11 15:18:34 +02001473
1474// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001475TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001476 EXPECT_FALSE(channel_->sending());
1477 EXPECT_FALSE(SetSend(true));
1478 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001479}
Niels Möller6557d0c2018-04-11 15:18:34 +02001480
1481// Test that we properly set the send and recv buffer sizes by the time
1482// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001483TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001484 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1485 EXPECT_TRUE(SetSend(true));
1486 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1487 EXPECT_EQ(64 * 1024, network_interface_.recvbuf_size());
srtee0c2eea2017-12-15 17:44:33 +01001488}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001489
Erik Språng820ebd02018-08-20 17:14:25 +02001490// Test that we properly set the send and recv buffer sizes when overriding
1491// via field trials.
1492TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSize) {
1493 // Set field trial to override the default recv buffer size, and then re-run
1494 // setup where the interface is created and configured.
1495 const int kCustomRecvBufferSize = 123456;
1496 webrtc::test::ScopedFieldTrials field_trial(
1497 "WebRTC-IncreasedReceivebuffers/123456/");
1498 SetUp();
1499
1500 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1501 EXPECT_TRUE(SetSend(true));
1502 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1503 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1504}
1505
1506// Test that we properly set the send and recv buffer sizes when overriding
1507// via field trials with suffix.
1508TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSizeWithSuffix) {
1509 // Set field trial to override the default recv buffer size, and then re-run
1510 // setup where the interface is created and configured.
1511 const int kCustomRecvBufferSize = 123456;
1512 webrtc::test::ScopedFieldTrials field_trial(
1513 "WebRTC-IncreasedReceivebuffers/123456_Dogfood/");
1514 SetUp();
1515
1516 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1517 EXPECT_TRUE(SetSend(true));
1518 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1519 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1520}
1521
1522// Test that we properly set the send and recv buffer sizes when overriding
1523// via field trials that don't make any sense.
1524TEST_F(WebRtcVideoChannelBaseTest, InvalidRecvBufferSize) {
1525 // Set bogus field trial values to override the default recv buffer size, and
1526 // then re-run setup where the interface is created and configured. The
1527 // default value should still be used.
1528
1529 for (std::string group : {" ", "NotANumber", "-1", "0"}) {
1530 std::string field_trial_string = "WebRTC-IncreasedReceivebuffers/";
1531 field_trial_string += group;
1532 field_trial_string += "/";
1533 webrtc::test::ScopedFieldTrials field_trial(field_trial_string);
1534 SetUp();
1535
1536 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1537 EXPECT_TRUE(SetSend(true));
1538 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1539 EXPECT_EQ(64 * 1024, network_interface_.recvbuf_size());
1540 }
1541}
1542
Niels Möller6557d0c2018-04-11 15:18:34 +02001543// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001544TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001545 const int kDurationSec = 3;
1546 const int kFps = 10;
1547 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1548
1549 cricket::VideoMediaInfo info;
1550 EXPECT_TRUE(channel_->GetStats(&info));
1551
1552 ASSERT_EQ(1U, info.senders.size());
1553 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1554 // For webrtc, bytes_sent does not include the RTP header length.
1555 EXPECT_GT(info.senders[0].bytes_sent, 0);
1556 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1557 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1558 ASSERT_TRUE(info.senders[0].codec_payload_type);
1559 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1560 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1561 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1562 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1563 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1564 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1565 EXPECT_GT(info.senders[0].framerate_input, 0);
1566 EXPECT_GT(info.senders[0].framerate_sent, 0);
1567
1568 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1569 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1570 info.send_codecs[DefaultCodec().id]);
1571
1572 ASSERT_EQ(1U, info.receivers.size());
1573 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1574 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1575 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1576 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1577 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1578 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1579 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1580 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1581 EXPECT_EQ(0, info.receivers[0].packets_lost);
1582 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1583 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1584 EXPECT_EQ(0, info.receivers[0].firs_sent);
1585 EXPECT_EQ(0, info.receivers[0].plis_sent);
1586 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1587 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1588 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1589 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1590 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1591 EXPECT_GT(info.receivers[0].framerate_output, 0);
1592
1593 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1594 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1595 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001596}
Niels Möller6557d0c2018-04-11 15:18:34 +02001597
1598// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001599TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001600 cricket::FakeVideoRenderer renderer1, renderer2;
1601 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1602 cricket::VideoSendParameters parameters;
1603 parameters.codecs.push_back(DefaultCodec());
1604 parameters.conference_mode = true;
1605 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1606 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001607 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1608 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001609 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1610 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1611 EXPECT_EQ(0, renderer1.num_rendered_frames());
1612 EXPECT_EQ(0, renderer2.num_rendered_frames());
1613 std::vector<uint32_t> ssrcs;
1614 ssrcs.push_back(1);
1615 ssrcs.push_back(2);
1616 network_interface_.SetConferenceMode(true, ssrcs);
1617 EXPECT_TRUE(SendFrame());
1618 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1619 kTimeout);
1620 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1621 kTimeout);
1622
1623 EXPECT_TRUE(channel_->SetSend(false));
1624
1625 cricket::VideoMediaInfo info;
1626 EXPECT_TRUE(channel_->GetStats(&info));
1627 ASSERT_EQ(1U, info.senders.size());
1628 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1629 // For webrtc, bytes_sent does not include the RTP header length.
1630 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1631 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1632 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1633 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1634
1635 ASSERT_EQ(2U, info.receivers.size());
1636 for (size_t i = 0; i < info.receivers.size(); ++i) {
1637 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1638 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1639 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001640 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001641 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1642 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1643 }
srtee0c2eea2017-12-15 17:44:33 +01001644}
Niels Möller6557d0c2018-04-11 15:18:34 +02001645
1646// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001647TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001648 // Normal setup; note that we set the SSRC explicitly to ensure that
1649 // it will come first in the senders map.
1650 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1651 cricket::VideoSendParameters parameters;
1652 parameters.codecs.push_back(DefaultCodec());
1653 parameters.conference_mode = true;
1654 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001655 EXPECT_TRUE(
1656 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001657 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1658 EXPECT_TRUE(SetSend(true));
1659 EXPECT_TRUE(SendFrame());
1660 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1661 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1662
1663 // Add an additional capturer, and hook up a renderer to receive it.
1664 cricket::FakeVideoRenderer renderer2;
1665 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1666 CreateFakeVideoCapturer());
1667 const int kTestWidth = 160;
1668 const int kTestHeight = 120;
1669 cricket::VideoFormat format(kTestWidth, kTestHeight,
1670 cricket::VideoFormat::FpsToInterval(5),
1671 cricket::FOURCC_I420);
1672 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001673 EXPECT_TRUE(
1674 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001675 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, capturer.get()));
Yves Gerey665174f2018-06-19 15:03:05 +02001676 EXPECT_TRUE(
1677 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001678 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
1679 EXPECT_TRUE(capturer->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001680 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1681 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001682
1683 // Get stats, and make sure they are correct for two senders. We wait until
1684 // the number of expected packets have been sent to avoid races where we
1685 // check stats before it has been updated.
1686 cricket::VideoMediaInfo info;
1687 for (uint32_t i = 0; i < kTimeout; ++i) {
1688 rtc::Thread::Current()->ProcessMessages(1);
1689 EXPECT_TRUE(channel_->GetStats(&info));
1690 ASSERT_EQ(2U, info.senders.size());
1691 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1692 NumRtpPackets()) {
1693 // Stats have been updated for both sent frames, expectations can be
1694 // checked now.
1695 break;
1696 }
1697 }
1698 EXPECT_EQ(NumRtpPackets(),
1699 info.senders[0].packets_sent + info.senders[1].packets_sent)
1700 << "Timed out while waiting for packet counts for all sent packets.";
1701 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1702 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1703 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1704 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1705 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1706 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1707 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1708 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1709 // The capturer must be unregistered here as it runs out of it's scope next.
1710 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001711}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001712
Niels Möller6557d0c2018-04-11 15:18:34 +02001713// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001714TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001715 cricket::VideoSendParameters parameters;
1716 parameters.codecs.push_back(DefaultCodec());
1717 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1718 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1719 parameters.max_bandwidth_bps = 128 * 1024;
1720 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001721}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001722
Niels Möller6557d0c2018-04-11 15:18:34 +02001723// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001724TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001725 EXPECT_TRUE(SetDefaultCodec());
1726 EXPECT_TRUE(SetSend(true));
1727 EXPECT_TRUE(SendFrame());
1728 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001729 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001730 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001731 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1732 EXPECT_EQ(kSsrc, header.ssrc);
1733
Niels Möller6557d0c2018-04-11 15:18:34 +02001734 // Packets are being paced out, so these can mismatch between the first and
1735 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001736 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1737 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001738 EXPECT_EQ(1, NumSentSsrcs());
1739 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1740 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001741}
Niels Möller6557d0c2018-04-11 15:18:34 +02001742
1743// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001744TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001745 // Remove stream added in Setup.
1746 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1747 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001748 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001749 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
1750 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001751 EXPECT_TRUE(SetSend(true));
1752 EXPECT_TRUE(WaitAndSendFrame(0));
1753 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001754 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001755 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001756 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1757 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001758 // Packets are being paced out, so these can mismatch between the first and
1759 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001760 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1761 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001762 EXPECT_EQ(1, NumSentSsrcs());
1763 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1764 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001765}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001766
Niels Möller6557d0c2018-04-11 15:18:34 +02001767// Test that we can set the default video renderer before and after
1768// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001769TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001770 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1771 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001772
1773 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1774 rtc::SetBE32(packet1.data() + 8, kSsrc);
1775 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1776 EXPECT_TRUE(SetDefaultCodec());
1777 EXPECT_TRUE(SetSend(true));
1778 EXPECT_EQ(0, renderer_.num_rendered_frames());
1779 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
1780 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1781 EXPECT_TRUE(SendFrame());
1782 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001783}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001784
Niels Möller6557d0c2018-04-11 15:18:34 +02001785// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001786TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001787 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1788 EXPECT_TRUE(SetSend(true));
1789 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1790 EXPECT_TRUE(SendFrame());
1791 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1792 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001793 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001794 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001795 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1796 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001797 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1798 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001799
1800 // Remove the send stream that was added during Setup.
1801 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1802 int rtp_packets = NumRtpPackets();
1803
Niels Möller6557d0c2018-04-11 15:18:34 +02001804 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001805 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
1806 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001807 EXPECT_EQ(rtp_packets, NumRtpPackets());
1808 // Wait 30ms to guarantee the engine does not drop the frame.
1809 EXPECT_TRUE(WaitAndSendFrame(30));
1810 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1811
1812 last_packet = NumRtpPackets() - 1;
1813 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001814 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1815 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001816}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001817
Niels Möller6557d0c2018-04-11 15:18:34 +02001818// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001819TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001820 cricket::FakeVideoRenderer renderer1, renderer2;
1821 EXPECT_TRUE(SetDefaultCodec());
1822 cricket::VideoSendParameters parameters;
1823 parameters.codecs.push_back(DefaultCodec());
1824 parameters.conference_mode = true;
1825 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1826 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001827 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1828 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001829 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1830 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1831 EXPECT_EQ(0, renderer1.num_rendered_frames());
1832 EXPECT_EQ(0, renderer2.num_rendered_frames());
1833 std::vector<uint32_t> ssrcs;
1834 ssrcs.push_back(1);
1835 ssrcs.push_back(2);
1836 network_interface_.SetConferenceMode(true, ssrcs);
1837 EXPECT_TRUE(SendFrame());
1838 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1839 kTimeout);
1840 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1841 kTimeout);
1842
1843 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1844 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1845 EXPECT_EQ(kVideoWidth, renderer1.width());
1846 EXPECT_EQ(kVideoHeight, renderer1.height());
1847 EXPECT_EQ(kVideoWidth, renderer2.width());
1848 EXPECT_EQ(kVideoHeight, renderer2.height());
1849 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1850 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001851}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001852
Niels Möller6557d0c2018-04-11 15:18:34 +02001853// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001854TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001855 using cricket::VideoCodec;
1856 using cricket::VideoOptions;
1857 using cricket::VideoFormat;
1858 using cricket::FOURCC_I420;
1859
1860 VideoCodec codec = DefaultCodec();
1861 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1862 EXPECT_TRUE(SetOneCodec(codec));
1863 EXPECT_TRUE(SetSend(true));
1864 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1865 EXPECT_EQ(0, renderer_.num_rendered_frames());
1866 EXPECT_TRUE(SendFrame());
1867 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1868 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1869 CreateFakeVideoCapturer());
1870
1871 // TODO(nisse): This testcase fails if we don't configure
1872 // screencast. It's unclear why, I see nothing obvious in this
1873 // test which is related to screencast logic.
1874 VideoOptions video_options;
1875 video_options.is_screencast = true;
1876 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1877
1878 VideoFormat format(480, 360, VideoFormat::FpsToInterval(30), FOURCC_I420);
1879 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
1880 // All capturers start generating frames with the same timestamp. ViE does
1881 // not allow the same timestamp to be used. Capture one frame before
1882 // associating the capturer with the channel.
1883 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1884
1885 int captured_frames = 1;
1886 for (int iterations = 0; iterations < 2; ++iterations) {
1887 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, capturer.get()));
1888 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
1889 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1890 ++captured_frames;
1891 // Wait until frame of right size is captured.
1892 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001893 format.width == renderer_.width() &&
1894 format.height == renderer_.height() &&
1895 !renderer_.black_frame(),
1896 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001897 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1898 EXPECT_EQ(format.width, renderer_.width());
1899 EXPECT_EQ(format.height, renderer_.height());
1900 captured_frames = renderer_.num_rendered_frames() + 1;
1901 EXPECT_FALSE(renderer_.black_frame());
1902 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1903 // Make sure a black frame is generated within the specified timeout.
1904 // The black frame should be the resolution of the previous frame to
1905 // prevent expensive encoder reconfigurations.
1906 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001907 format.width == renderer_.width() &&
1908 format.height == renderer_.height() &&
1909 renderer_.black_frame(),
1910 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001911 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1912 EXPECT_EQ(format.width, renderer_.width());
1913 EXPECT_EQ(format.height, renderer_.height());
1914 EXPECT_TRUE(renderer_.black_frame());
1915
1916 // The black frame has the same timestamp as the next frame since it's
1917 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1918 // not render a frame with the same timestamp so capture another frame
1919 // with the frame capturer to increment the next frame's timestamp.
1920 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1921 }
srtee0c2eea2017-12-15 17:44:33 +01001922}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001923
Niels Möller6557d0c2018-04-11 15:18:34 +02001924// Tests that if SetVideoSend is called with a NULL capturer after the
1925// capturer was already removed, the application doesn't crash (and no black
1926// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001927TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001928 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1929 EXPECT_TRUE(SetSend(true));
1930 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1931 EXPECT_EQ(0, renderer_.num_rendered_frames());
1932 EXPECT_TRUE(SendFrame());
1933 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1934 // Wait for one frame so they don't get dropped because we send frames too
1935 // tightly.
1936 rtc::Thread::Current()->ProcessMessages(30);
1937 // Remove the capturer.
1938 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1939
1940 // No capturer was added, so this SetVideoSend shouldn't do anything.
1941 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1942 rtc::Thread::Current()->ProcessMessages(300);
1943 // Verify no more frames were sent.
1944 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001945}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001946
Niels Möller6557d0c2018-04-11 15:18:34 +02001947// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001948TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001949 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1950 // interval time to avoid that.
1951 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1952 // interval time to avoid that.
1953 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001954 EXPECT_TRUE(
1955 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001956 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1957 cricket::VideoFormat capture_format(
1958 kVideoWidth, kVideoHeight,
1959 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1960 // Set up additional stream 1.
1961 cricket::FakeVideoRenderer renderer1;
1962 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001963 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001964 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001965 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001966 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer1(
1967 CreateFakeVideoCapturer());
1968 EXPECT_EQ(cricket::CS_RUNNING, capturer1->Start(capture_format));
1969 // Set up additional stream 2.
1970 cricket::FakeVideoRenderer renderer2;
1971 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001972 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001973 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001974 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001975 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer2(
1976 CreateFakeVideoCapturer());
1977 EXPECT_EQ(cricket::CS_RUNNING, capturer2->Start(capture_format));
1978 // State for all the streams.
1979 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1980 // A limitation in the lmi implementation requires that SetVideoSend() is
1981 // called after SetOneCodec().
1982 // TODO(hellner): this seems like an unnecessary constraint, fix it.
1983 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, capturer1.get()));
1984 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, capturer2.get()));
1985 EXPECT_TRUE(SetSend(true));
1986 // Test capturer associated with engine.
1987 const int kTestWidth = 160;
1988 const int kTestHeight = 120;
1989 EXPECT_TRUE(capturer1->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001990 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
1991 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001992 // Capture a frame with additional capturer2, frames should be received
1993 EXPECT_TRUE(capturer2->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001994 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1995 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001996 // Successfully remove the capturer.
1997 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1998 // The capturers must be unregistered here as it runs out of it's scope
1999 // next.
2000 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
2001 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01002002}
Niels Möller6557d0c2018-04-11 15:18:34 +02002003
2004// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01002005TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002006 // Remove the send stream that was added during Setup.
2007 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
2008
2009 cricket::StreamParams empty;
2010 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02002011 EXPECT_TRUE(
2012 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01002013}
Niels Möller6557d0c2018-04-11 15:18:34 +02002014
2015// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01002016TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002017 // Remove stream added in Setup. I.e. remove stream corresponding to default
2018 // channel.
2019 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02002020 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02002021 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
2022 EXPECT_TRUE(channel_->AddSendStream(
2023 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
2024 }
2025 // Delete one of the non default channel streams, let the destructor delete
2026 // the remaining ones.
2027 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
2028 // Stream should already be deleted.
2029 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01002030}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00002031
eladalonf1841382017-06-12 01:16:46 -07002032TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08002033 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002034}
2035
eladalonf1841382017-06-12 01:16:46 -07002036TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08002037 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002038}
2039
eladalonf1841382017-06-12 01:16:46 -07002040TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002041 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002042}
2043
eladalonf1841382017-06-12 01:16:46 -07002044TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002045 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2046 // bitrates. This currently happens at <250k, and two streams sharing 300k
2047 // initially will use QVGA instead of VGA.
2048 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2049 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002050 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002051 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002052 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002053}
2054
eladalonf1841382017-06-12 01:16:46 -07002055class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002056 public:
eladalonf1841382017-06-12 01:16:46 -07002057 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2058 explicit WebRtcVideoChannelTest(const char* field_trials)
2059 : WebRtcVideoEngineTest(field_trials), last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002060 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002061 encoder_factory_->AddSupportedVideoCodecType("VP8");
2062 encoder_factory_->AddSupportedVideoCodecType("VP9");
2063#if defined(WEBRTC_USE_H264)
2064 encoder_factory_->AddSupportedVideoCodecType("H264");
2065#endif
2066
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002067 fake_call_.reset(new FakeCall());
kthelgason2bc68642017-02-07 07:02:22 -08002068 channel_.reset(engine_.CreateChannel(fake_call_.get(), GetMediaConfig(),
2069 VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002070 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002071 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002072 send_parameters_.codecs = engine_.codecs();
2073 recv_parameters_.codecs = engine_.codecs();
2074 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002075 }
2076
2077 protected:
2078 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002079 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002080 }
2081
2082 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002083 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002084 EXPECT_TRUE(channel_->AddSendStream(sp));
2085 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002086 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002087 EXPECT_EQ(num_streams + 1, streams.size());
2088 return streams[streams.size() - 1];
2089 }
2090
2091 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002092 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002093 }
2094
2095 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002096 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002097 }
2098
2099 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002100 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002101 EXPECT_TRUE(channel_->AddRecvStream(sp));
2102 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002103 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002104 EXPECT_EQ(num_streams + 1, streams.size());
2105 return streams[streams.size() - 1];
2106 }
2107
pbos@webrtc.org00873182014-11-25 14:03:34 +00002108 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2109 int expected_min_bitrate_bps,
2110 const char* start_bitrate_kbps,
2111 int expected_start_bitrate_bps,
2112 const char* max_bitrate_kbps,
2113 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002114 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2115 expected_start_bitrate_bps,
2116 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002117 auto& codecs = send_parameters_.codecs;
2118 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002119 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002120 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2121 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2122 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002123 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002124 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002125
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002126 void ExpectSetBitrateParameters(int min_bitrate_bps,
2127 int start_bitrate_bps,
2128 int max_bitrate_bps) {
2129 EXPECT_CALL(
2130 *fake_call_->GetMockTransportControllerSend(),
2131 SetSdpBitrateParameters(AllOf(
2132 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2133 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2134 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2135 }
2136
2137 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2138 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2139 SetSdpBitrateParameters(Field(
2140 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002141 }
2142
isheriff6f8d6862016-05-26 11:24:55 -07002143 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002144 // Enable extension.
2145 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002146 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002147 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002148 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002149 FakeVideoSendStream* send_stream =
2150 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2151
2152 // Verify the send extension id.
2153 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2154 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002155 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002156 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002157 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002158 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2159 // receivers.
2160 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2161 ->GetConfig()
2162 .rtp.extensions.empty());
2163
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002164 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002165 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002166 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2167 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002168 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2169
2170 // Verify that adding receive RTP header extensions adds them for existing
2171 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002172 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002173 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002174 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2175 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002176 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002177 }
2178
isheriff6f8d6862016-05-26 11:24:55 -07002179 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002180 // Enable extension.
2181 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002182 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002183 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002184 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002185
2186 FakeVideoReceiveStream* recv_stream =
2187 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2188
2189 // Verify the recv extension id.
2190 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2191 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002192 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002193 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002194 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002195
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002196 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2197 // senders.
2198 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2199 ->GetConfig()
2200 .rtp.extensions.empty());
2201
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002202 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002203 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002204 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2205 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002206 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2207
2208 // Verify that adding receive RTP header extensions adds them for existing
2209 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002210 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002211 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002212 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2213 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002214 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002215 }
2216
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002217 void TestExtensionFilter(const std::vector<std::string>& extensions,
2218 const std::string& expected_extension) {
2219 cricket::VideoSendParameters parameters = send_parameters_;
2220 int expected_id = -1;
2221 int id = 1;
2222 for (const std::string& extension : extensions) {
2223 if (extension == expected_extension)
2224 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002225 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002226 }
2227 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2228 FakeVideoSendStream* send_stream =
2229 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2230
2231 // Verify that only one of them has been set, and that it is the one with
2232 // highest priority (transport sequence number).
2233 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2234 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2235 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002236 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002237 }
2238
asapersson3c81a1a2017-06-14 05:52:21 -07002239 void TestDegradationPreference(bool resolution_scaling_enabled,
2240 bool fps_scaling_enabled);
2241
Erik Språngefbde372015-04-29 16:21:28 +02002242 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002243 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002244 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2245 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002246
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002247 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002248 uint32_t ssrc,
Tommi85959932018-02-07 19:26:06 +01002249 FakeVideoCapturerWithTaskQueue* capturer,
nisse0db023a2016-03-01 04:29:59 -08002250 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002251 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002252 options.video_noise_reduction = enabled;
Niels Möllerff40b142018-04-09 08:49:14 +02002253 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, capturer));
nisse0db023a2016-03-01 04:29:59 -08002254 // Options only take effect on the next frame.
2255 EXPECT_TRUE(capturer->CaptureFrame());
2256
Erik Språng143cec12015-04-28 10:01:41 +02002257 return fake_call_->GetVideoSendStreams().back();
2258 }
2259
Peter Boström2feafdb2015-09-09 14:32:14 +02002260 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2261 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002262 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002263 std::vector<uint32_t> ssrcs;
2264 std::vector<uint32_t> rtx_ssrcs;
2265 uint32_t num_streams = enabled ? 3 : 1;
2266 for (uint32_t i = 0; i < num_streams; ++i) {
2267 uint32_t ssrc = last_ssrc_ + i;
2268 ssrcs.push_back(ssrc);
2269 if (with_rtx) {
2270 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2271 }
Erik Språng143cec12015-04-28 10:01:41 +02002272 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002273 if (with_rtx) {
2274 return AddSendStream(
2275 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2276 }
2277 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002278 }
2279
perkjfa10b552016-10-02 23:45:26 -07002280 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002281 std::vector<FakeVideoSendStream*> streams =
2282 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002283 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002284 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002285 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002286 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002287 }
2288
perkjfa10b552016-10-02 23:45:26 -07002289 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002290 int stream_max,
2291 int expected_encoder_bitrate) {
2292 VideoSendParameters limited_send_params = send_parameters_;
2293 limited_send_params.max_bandwidth_bps = global_max;
2294 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002295 webrtc::RtpParameters parameters =
2296 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002297 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002298 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002299 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002300 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002301 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002302 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002303 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002304 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002305 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002306 }
2307
Åsa Persson55659812018-06-18 17:51:32 +02002308 // Values from kSimulcastConfigs in simulcast.cc.
2309 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2310 std::vector<webrtc::VideoStream> layers(3);
2311 layers[0].min_bitrate_bps = 30000;
2312 layers[0].target_bitrate_bps = 150000;
2313 layers[0].max_bitrate_bps = 200000;
2314 layers[1].min_bitrate_bps = 150000;
2315 layers[1].target_bitrate_bps = 500000;
2316 layers[1].max_bitrate_bps = 700000;
2317 layers[2].min_bitrate_bps = 600000;
2318 layers[2].target_bitrate_bps = 2500000;
2319 layers[2].max_bitrate_bps = 2500000;
2320 return layers;
2321 }
2322
kwiberg686a8ef2016-02-26 03:00:35 -08002323 std::unique_ptr<FakeCall> fake_call_;
2324 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002325 cricket::VideoSendParameters send_parameters_;
2326 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002327 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002328};
2329
eladalonf1841382017-06-12 01:16:46 -07002330TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002331 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002332 const std::string kSyncLabel = "AvSyncLabel";
2333
2334 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002335 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002336 EXPECT_TRUE(channel_->AddRecvStream(sp));
2337
Mirko Bonadeif859e552018-05-30 15:31:29 +02002338 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002339 EXPECT_EQ(kSyncLabel,
2340 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2341 << "SyncGroup should be set based on sync_label";
2342}
2343
eladalonf1841382017-06-12 01:16:46 -07002344TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002345 cricket::VideoSendParameters parameters;
2346 parameters.codecs = engine_.codecs();
2347 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002348 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002349 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002350 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002351
2352 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002353 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2354 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002355 FakeVideoSendStream* send_stream = AddSendStream(
2356 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2357
2358 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2359 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2360 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2361
2362 // Receiver side.
2363 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2364 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002365 EXPECT_FALSE(
2366 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002367 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002368 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002369 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002370 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002371 << "RTX should be mapped for the RED payload type";
2372
brandtr14742122017-01-27 04:53:07 -08002373 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002374}
2375
eladalonf1841382017-06-12 01:16:46 -07002376TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002377 // Setup one channel with an associated RTX stream.
2378 cricket::StreamParams params =
2379 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2380 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2381 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002382 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002383
2384 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2385 << "RTX should be mapped for all decoders/payload types.";
2386 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002387 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002388 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002389}
2390
eladalonf1841382017-06-12 01:16:46 -07002391TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002392 // Setup one channel without an associated RTX stream.
2393 cricket::StreamParams params =
2394 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2395 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002396 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002397}
2398
eladalonf1841382017-06-12 01:16:46 -07002399TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002400 FakeVideoSendStream* send_stream =
2401 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2402 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2403
2404 FakeVideoReceiveStream* recv_stream =
2405 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2406 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002407}
2408
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002409// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002410TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002411 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002412}
isheriff6f8d6862016-05-26 11:24:55 -07002413
eladalonf1841382017-06-12 01:16:46 -07002414TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002415 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002416}
2417
2418// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002419TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002420 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002421}
isheriff6f8d6862016-05-26 11:24:55 -07002422
eladalonf1841382017-06-12 01:16:46 -07002423TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002424 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002425}
2426
eladalonf1841382017-06-12 01:16:46 -07002427TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002428 // Enable three redundant extensions.
2429 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002430 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2431 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2432 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2433 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002434}
2435
eladalonf1841382017-06-12 01:16:46 -07002436TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002437 // Enable two redundant extensions.
2438 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002439 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2440 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2441 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002442}
2443
stefanc1aeaf02015-10-15 07:26:07 -07002444// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002445TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002446 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002447}
eladalonf1841382017-06-12 01:16:46 -07002448TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002449 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002450}
2451
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002452// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002453TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002454 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002455}
eladalonf1841382017-06-12 01:16:46 -07002456TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002457 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002458}
2459
eladalonf1841382017-06-12 01:16:46 -07002460TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002461 const int kAbsSendTimeId = 1;
2462 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002463 send_parameters_.extensions.push_back(
2464 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2465 send_parameters_.extensions.push_back(
2466 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002467
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002468 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002469 FakeVideoSendStream* send_stream =
2470 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2471
2472 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002473 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002474
2475 // Setting the same extensions (even if in different order) shouldn't
2476 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002477 std::reverse(send_parameters_.extensions.begin(),
2478 send_parameters_.extensions.end());
2479 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002480
2481 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2482
2483 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002484 send_parameters_.extensions.resize(1);
2485 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002486
2487 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2488}
2489
eladalonf1841382017-06-12 01:16:46 -07002490TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002491 const int kTOffsetId = 1;
2492 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002493 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002494 recv_parameters_.extensions.push_back(
2495 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2496 recv_parameters_.extensions.push_back(
2497 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2498 recv_parameters_.extensions.push_back(
2499 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002500
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002501 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002502 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002503 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2504
2505 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002506 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002507
2508 // Setting the same extensions (even if in different order) shouldn't
2509 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002510 std::reverse(recv_parameters_.extensions.begin(),
2511 recv_parameters_.extensions.end());
2512 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002513
2514 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2515
2516 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002517 recv_parameters_.extensions.resize(1);
2518 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002519
2520 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2521}
2522
eladalonf1841382017-06-12 01:16:46 -07002523TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002524 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002525 const int kUnsupportedId = 1;
2526 const int kTOffsetId = 2;
2527
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002528 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002529 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002530 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002531 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002532 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002533 FakeVideoSendStream* send_stream =
2534 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2535
2536 // Only timestamp offset extension is set to send stream,
2537 // unsupported rtp extension is ignored.
2538 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002539 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2540 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002541}
2542
eladalonf1841382017-06-12 01:16:46 -07002543TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002544 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002545 const int kUnsupportedId = 1;
2546 const int kTOffsetId = 2;
2547
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002548 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002549 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002550 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002551 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002552 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002553 FakeVideoReceiveStream* recv_stream =
2554 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2555
2556 // Only timestamp offset extension is set to receive stream,
2557 // unsupported rtp extension is ignored.
2558 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002559 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2560 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002561}
2562
eladalonf1841382017-06-12 01:16:46 -07002563TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002564 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002565 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002566 send_parameters_.extensions.push_back(
2567 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002568 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002569 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2570 }
2571}
2572
eladalonf1841382017-06-12 01:16:46 -07002573TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002574 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002575 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002576 recv_parameters_.extensions.push_back(
2577 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002578 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002579 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2580 }
2581}
2582
eladalonf1841382017-06-12 01:16:46 -07002583TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002584 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002585 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002586 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002587 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002588 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002589 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002590
2591 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002592 send_parameters_.extensions.clear();
2593 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002594 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002595 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2596 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002597}
2598
eladalonf1841382017-06-12 01:16:46 -07002599TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002600 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002601 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002602 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002603 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002604 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002605 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002606
2607 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002608 recv_parameters_.extensions.clear();
2609 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002610 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002611 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2612 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002613}
2614
eladalonf1841382017-06-12 01:16:46 -07002615TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002616 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002617 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002618}
2619
eladalonf1841382017-06-12 01:16:46 -07002620TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002621 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002622 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002623}
2624
eladalonf1841382017-06-12 01:16:46 -07002625TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002626 FakeVideoReceiveStream* stream = AddRecvStream();
2627 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002628}
2629
eladalonf1841382017-06-12 01:16:46 -07002630TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002631 FakeVideoReceiveStream* stream = AddRecvStream();
2632 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2633}
2634
eladalonf1841382017-06-12 01:16:46 -07002635TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002636 FakeVideoReceiveStream* stream = AddRecvStream();
2637 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2638
Peter Boström126c03e2015-05-11 12:48:12 +02002639 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002640 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002641 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002642 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2643 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002644 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002645 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2646
2647 // Verify that REMB is turned on when setting default codecs since the
2648 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002649 parameters.codecs = engine_.codecs();
2650 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002651 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002652 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002653}
2654
eladalonf1841382017-06-12 01:16:46 -07002655TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002656 FakeVideoReceiveStream* stream = AddRecvStream();
2657 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2658
2659 // Verify that transport cc feedback is turned off when send(!) codecs without
2660 // transport cc feedback are set.
2661 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002662 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002663 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2664 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2665 stream = fake_call_->GetVideoReceiveStreams()[0];
2666 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2667
2668 // Verify that transport cc feedback is turned on when setting default codecs
2669 // since the default codecs have transport cc feedback enabled.
2670 parameters.codecs = engine_.codecs();
2671 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2672 stream = fake_call_->GetVideoReceiveStreams()[0];
2673 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2674}
2675
eladalonf1841382017-06-12 01:16:46 -07002676TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002677 AssignDefaultCodec();
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002678 VerifyCodecHasDefaultFeedbackParams(default_codec_);
2679
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002680 cricket::VideoSendParameters parameters;
2681 parameters.codecs = engine_.codecs();
2682 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002683 EXPECT_TRUE(channel_->SetSend(true));
2684
2685 // Send side.
2686 FakeVideoSendStream* send_stream =
2687 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2688 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2689
2690 // Receiver side.
2691 FakeVideoReceiveStream* recv_stream =
2692 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2693 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2694
2695 // Nack history size should match between sender and receiver.
2696 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2697 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002698}
2699
eladalonf1841382017-06-12 01:16:46 -07002700TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002701 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002702 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002703
2704 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2705 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2706
2707 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002708 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002709 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002710 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2711 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002712 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2713 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2714 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002715 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2716
Peter Boström67c9df72015-05-11 14:34:58 +02002717 // Verify that NACK is turned on when setting default codecs since the
2718 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002719 parameters.codecs = engine_.codecs();
2720 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002721 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2722 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2723 send_stream = fake_call_->GetVideoSendStreams()[0];
2724 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002725}
2726
Peter Boströme7ba0862016-03-12 00:02:28 +01002727// This test verifies that new frame sizes reconfigures encoders even though not
2728// (yet) sending. The purpose of this is to permit encoding as quickly as
2729// possible once we start sending. Likely the frames being input are from the
2730// same source that will be sent later, which just means that we're ready
2731// earlier.
eladalonf1841382017-06-12 01:16:46 -07002732TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002733 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002734 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002735 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2736 channel_->SetSend(false);
2737
2738 FakeVideoSendStream* stream = AddSendStream();
2739
perkjfa10b552016-10-02 23:45:26 -07002740 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002741 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002742 EXPECT_EQ(0u, streams[0].width);
2743 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002744
Tommi85959932018-02-07 19:26:06 +01002745 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002746 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj26752742016-10-24 01:21:16 -07002747 VideoFormat capture_format = capturer.GetSupportedFormats()->front();
2748 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
Peter Boströme7ba0862016-03-12 00:02:28 +01002749 EXPECT_TRUE(capturer.CaptureFrame());
2750
2751 // Frame entered, should be reconfigured to new dimensions.
2752 streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002753 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.width), streams[0].width);
2754 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.height),
2755 streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002756
Niels Möllerff40b142018-04-09 08:49:14 +02002757 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002758}
2759
eladalonf1841382017-06-12 01:16:46 -07002760TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002761 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002762 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002763 cricket::VideoSendParameters parameters;
2764 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002765 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002766 AddSendStream();
2767
Tommi85959932018-02-07 19:26:06 +01002768 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07002769 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002770 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Yves Gerey665174f2018-06-19 15:03:05 +02002771 EXPECT_TRUE(
2772 channel_->SetVideoSend(last_ssrc_, &min_bitrate_options, &capturer));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002773 cricket::VideoFormat capture_format_hd =
2774 capturer.GetSupportedFormats()->front();
2775 EXPECT_EQ(1280, capture_format_hd.width);
2776 EXPECT_EQ(720, capture_format_hd.height);
2777 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2778
2779 EXPECT_TRUE(channel_->SetSend(true));
2780
2781 EXPECT_TRUE(capturer.CaptureFrame());
2782 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2783 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2784
2785 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2786
2787 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002788 webrtc::VideoEncoderConfig encoder_config =
2789 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002790 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002791 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002792 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002793 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2794 streams.front().width);
2795 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2796 streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002797 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2798 << "Non-screenshare shouldn't use min-transmit bitrate.";
2799
Niels Möllerff40b142018-04-09 08:49:14 +02002800 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002801 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002802 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002803 screencast_options.is_screencast = true;
deadbeef5a4a75a2016-06-02 16:23:38 -07002804 EXPECT_TRUE(
Niels Möllerff40b142018-04-09 08:49:14 +02002805 channel_->SetVideoSend(last_ssrc_, &screencast_options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08002806 EXPECT_TRUE(capturer.CaptureFrame());
sprangf24a0642017-02-28 13:23:26 -08002807 // Send stream recreated after option change.
2808 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2809 send_stream = fake_call_->GetVideoSendStreams().front();
2810 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002811
2812 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002813 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002814 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002815 encoder_config.content_type);
2816 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2817 encoder_config.min_transmit_bitrate_bps);
2818
perkjfa10b552016-10-02 23:45:26 -07002819 streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002820 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2821 streams.front().width);
2822 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2823 streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002824 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002825 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002826}
2827
eladalonf1841382017-06-12 01:16:46 -07002828TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002829 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002830 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002831 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002832 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002833
2834 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002835 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002836 options.is_screencast = true;
Tommi85959932018-02-07 19:26:06 +01002837 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002838 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002839 cricket::VideoFormat capture_format_hd =
2840 capturer.GetSupportedFormats()->front();
2841 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2842
2843 EXPECT_TRUE(channel_->SetSend(true));
2844
2845 EXPECT_TRUE(capturer.CaptureFrame());
2846 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2847 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2848
perkj26091b12016-09-01 01:17:40 -07002849 webrtc::VideoEncoderConfig encoder_config =
2850 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002851
2852 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002853 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002854 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002855 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002856
2857 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2858 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002859 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002860 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002861 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002862
Niels Möllerff40b142018-04-09 08:49:14 +02002863 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002864}
2865
eladalonf1841382017-06-12 01:16:46 -07002866TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002867 FakeVideoSendStream* stream = AddSendStream();
2868 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2869}
2870
eladalonf1841382017-06-12 01:16:46 -07002871TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002872 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002873 media_config.video.suspend_below_min_bitrate = true;
2874
2875 channel_.reset(
2876 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002877 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002878
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002879 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002880
2881 FakeVideoSendStream* stream = AddSendStream();
2882 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2883
nisse0db023a2016-03-01 04:29:59 -08002884 media_config.video.suspend_below_min_bitrate = false;
2885 channel_.reset(
2886 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002887 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002888
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002889 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002890
nisse0db023a2016-03-01 04:29:59 -08002891 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002892 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2893}
2894
eladalonf1841382017-06-12 01:16:46 -07002895TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002896 FakeVideoSendStream* stream = AddSendStream();
2897 webrtc::VideoCodecVP8 vp8_settings;
2898 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2899 EXPECT_TRUE(vp8_settings.denoisingOn);
2900}
2901
eladalonf1841382017-06-12 01:16:46 -07002902TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002903 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002904 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002905 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002906
Peter Boström2feafdb2015-09-09 14:32:14 +02002907 // Single-stream settings should apply with RTX as well (verifies that we
2908 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2909 // both RTX and regular SSRCs).
2910 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002911
Tommi85959932018-02-07 19:26:06 +01002912 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002913 EXPECT_EQ(cricket::CS_RUNNING,
2914 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002915 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002916 channel_->SetSend(true);
2917
2918 EXPECT_TRUE(capturer.CaptureFrame());
2919
pbos4cba4eb2015-10-26 11:18:18 -07002920 webrtc::VideoCodecVP8 vp8_settings;
2921 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2922 EXPECT_TRUE(vp8_settings.denoisingOn)
2923 << "VP8 denoising should be on by default.";
2924
nisse05103312016-03-16 02:22:50 -07002925 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002926
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002927 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2928 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002929 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2930 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002931
nisse05103312016-03-16 02:22:50 -07002932 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002933
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002934 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2935 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002936 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2937 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2938
Niels Möllerff40b142018-04-09 08:49:14 +02002939 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002940 stream = SetUpSimulcast(true, false);
Niels Möllerff40b142018-04-09 08:49:14 +02002941 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002942 channel_->SetSend(true);
2943 EXPECT_TRUE(capturer.CaptureFrame());
2944
Mirko Bonadeif859e552018-05-30 15:31:29 +02002945 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002946 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2947 // Autmatic resize off when using simulcast.
2948 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2949 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2950
2951 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002952 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002953 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002954 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
Niels Möller60653ba2016-03-02 11:41:36 +01002955
nisse05103312016-03-16 02:22:50 -07002956 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002957
Mirko Bonadeif859e552018-05-30 15:31:29 +02002958 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002959 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2960 EXPECT_FALSE(vp8_settings.denoisingOn);
2961 // Resizing and frame dropping always off for screen sharing.
2962 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2963 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2964
nisse05103312016-03-16 02:22:50 -07002965 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02002966
2967 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2968 EXPECT_FALSE(vp8_settings.denoisingOn);
2969 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2970 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2971
Niels Möllerff40b142018-04-09 08:49:14 +02002972 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02002973}
2974
deadbeef119760a2016-04-04 11:43:27 -07002975// Test that setting the same options doesn't result in the encoder being
2976// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07002977TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07002978 VideoOptions options;
Tommi85959932018-02-07 19:26:06 +01002979 FakeVideoCapturerWithTaskQueue capturer;
deadbeef119760a2016-04-04 11:43:27 -07002980
perkjfa10b552016-10-02 23:45:26 -07002981 AddSendStream();
deadbeef119760a2016-04-04 11:43:27 -07002982 EXPECT_EQ(cricket::CS_RUNNING,
2983 capturer.Start(capturer.GetSupportedFormats()->front()));
perkjfa10b552016-10-02 23:45:26 -07002984 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002985 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07002986 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2987 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2988
Niels Möllerff40b142018-04-09 08:49:14 +02002989 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
2990 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002991 EXPECT_TRUE(capturer.CaptureFrame());
perkjfa10b552016-10-02 23:45:26 -07002992 // Expect 1 reconfigurations at this point from the initial configuration.
2993 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07002994
2995 // Set the options one more time and expect no additional reconfigurations.
Niels Möllerff40b142018-04-09 08:49:14 +02002996 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkjfa10b552016-10-02 23:45:26 -07002997 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
2998
2999 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01003000 options.video_noise_reduction = true;
Niels Möllerff40b142018-04-09 08:49:14 +02003001 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07003002 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
3003
Niels Möllerff40b142018-04-09 08:49:14 +02003004 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07003005}
3006
eladalonf1841382017-06-12 01:16:46 -07003007class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02003008 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07003009 Vp9SettingsTest() : Vp9SettingsTest("") {}
3010 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07003011 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02003012 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003013 }
3014 virtual ~Vp9SettingsTest() {}
3015
3016 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003017 void TearDown() override {
3018 // Remove references to encoder_factory_ since this will be destroyed
3019 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003020 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003021 }
Erik Språng143cec12015-04-28 10:01:41 +02003022};
3023
3024TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003025 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003026 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003027 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003028
Peter Boström2feafdb2015-09-09 14:32:14 +02003029 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003030
Tommi85959932018-02-07 19:26:06 +01003031 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02003032 EXPECT_EQ(cricket::CS_RUNNING,
3033 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003034 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02003035 channel_->SetSend(true);
3036
3037 EXPECT_TRUE(capturer.CaptureFrame());
3038
pbos4cba4eb2015-10-26 11:18:18 -07003039 webrtc::VideoCodecVP9 vp9_settings;
3040 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003041 EXPECT_TRUE(vp9_settings.denoisingOn)
3042 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003043
nisse05103312016-03-16 02:22:50 -07003044 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003045
Erik Språng143cec12015-04-28 10:01:41 +02003046 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3047 EXPECT_FALSE(vp9_settings.denoisingOn);
3048 // Frame dropping always on for real time video.
3049 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3050
nisse05103312016-03-16 02:22:50 -07003051 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02003052
3053 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3054 EXPECT_TRUE(vp9_settings.denoisingOn);
3055 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3056
3057 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003058 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003059 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02003060 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003061
nisse05103312016-03-16 02:22:50 -07003062 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003063
3064 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3065 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003066 // Frame dropping always on for screen sharing.
3067 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003068
nisse05103312016-03-16 02:22:50 -07003069 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003070
3071 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3072 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003073 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003074
Niels Möllerff40b142018-04-09 08:49:14 +02003075 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003076}
3077
Sergey Silkinf18072e2018-03-14 10:35:35 +01003078TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3079 cricket::VideoSendParameters parameters;
3080 parameters.codecs.push_back(GetEngineCodec("VP9"));
3081 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3082
3083 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3084
3085 FakeVideoSendStream* stream =
3086 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3087
3088 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3089 EXPECT_EQ(ssrcs.size(), config.rtp.ssrcs.size());
3090
3091 FakeVideoCapturerWithTaskQueue capturer;
3092 EXPECT_EQ(cricket::CS_RUNNING,
3093 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003094 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &capturer));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003095 channel_->SetSend(true);
3096
3097 EXPECT_TRUE(capturer.CaptureFrame());
3098
3099 webrtc::VideoCodecVP9 vp9_settings;
3100 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3101
3102 const size_t kNumSpatialLayers = ssrcs.size();
3103 const size_t kNumTemporalLayers = 3;
3104 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3105 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3106
Niels Möllerff40b142018-04-09 08:49:14 +02003107 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003108}
3109
asaperssonc5dabdd2016-03-21 04:15:50 -07003110class Vp9SettingsTestWithFieldTrial : public Vp9SettingsTest {
3111 public:
brandtr468da7c2016-11-22 02:16:47 -08003112 explicit Vp9SettingsTestWithFieldTrial(const char* field_trials)
asaperssonc5dabdd2016-03-21 04:15:50 -07003113 : Vp9SettingsTest(field_trials) {}
3114
3115 protected:
3116 void VerifySettings(int num_spatial_layers, int num_temporal_layers) {
3117 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003118 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003119 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3120
3121 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3122
Tommi85959932018-02-07 19:26:06 +01003123 FakeVideoCapturerWithTaskQueue capturer;
asaperssonc5dabdd2016-03-21 04:15:50 -07003124 EXPECT_EQ(cricket::CS_RUNNING,
3125 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003126 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
asaperssonc5dabdd2016-03-21 04:15:50 -07003127 channel_->SetSend(true);
3128
3129 EXPECT_TRUE(capturer.CaptureFrame());
3130
3131 webrtc::VideoCodecVP9 vp9_settings;
3132 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3133 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3134 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
3135
Niels Möllerff40b142018-04-09 08:49:14 +02003136 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003137 }
3138};
3139
3140class Vp9SettingsTestWithNoFlag : public Vp9SettingsTestWithFieldTrial {
3141 public:
3142 Vp9SettingsTestWithNoFlag() : Vp9SettingsTestWithFieldTrial("") {}
3143};
3144
3145TEST_F(Vp9SettingsTestWithNoFlag, VerifySettings) {
3146 const int kNumSpatialLayers = 1;
3147 const int kNumTemporalLayers = 1;
3148 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3149}
3150
3151class Vp9SettingsTestWithInvalidFlag : public Vp9SettingsTestWithFieldTrial {
3152 public:
3153 Vp9SettingsTestWithInvalidFlag()
3154 : Vp9SettingsTestWithFieldTrial("WebRTC-SupportVP9SVC/Default/") {}
3155};
3156
3157TEST_F(Vp9SettingsTestWithInvalidFlag, VerifySettings) {
3158 const int kNumSpatialLayers = 1;
3159 const int kNumTemporalLayers = 1;
3160 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3161}
3162
3163class Vp9SettingsTestWith2SL3TLFlag : public Vp9SettingsTestWithFieldTrial {
3164 public:
3165 Vp9SettingsTestWith2SL3TLFlag()
3166 : Vp9SettingsTestWithFieldTrial(
3167 "WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/") {}
3168};
3169
3170TEST_F(Vp9SettingsTestWith2SL3TLFlag, VerifySettings) {
3171 const int kNumSpatialLayers = 2;
3172 const int kNumTemporalLayers = 3;
3173 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3174}
3175
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003176TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3177 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3178 ASSERT_EQ(1u, streams.size());
3179 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3180}
3181
3182TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
3183 webrtc::test::ScopedFieldTrials override_field_trials_(
3184 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3185 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3186 ASSERT_EQ(1u, streams.size());
3187 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3188}
3189
asapersson3c81a1a2017-06-14 05:52:21 -07003190TEST_F(WebRtcVideoChannelTest,
3191 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
3192 webrtc::test::ScopedFieldTrials override_field_trials_(
3193 "WebRTC-Video-BalancedDegradation/Disabled/");
3194 const bool kResolutionScalingEnabled = true;
3195 const bool kFpsScalingEnabled = false;
3196 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3197}
3198
3199TEST_F(WebRtcVideoChannelTest,
3200 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
3201 webrtc::test::ScopedFieldTrials override_field_trials_(
3202 "WebRTC-Video-BalancedDegradation/Enabled/");
3203 const bool kResolutionScalingEnabled = true;
3204 const bool kFpsScalingEnabled = true;
3205 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3206}
3207
eladalonf1841382017-06-12 01:16:46 -07003208TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003209 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003210}
3211
eladalonf1841382017-06-12 01:16:46 -07003212TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003213 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003214}
3215
eladalonf1841382017-06-12 01:16:46 -07003216TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003217 TestCpuAdaptation(true, true);
3218}
3219
eladalonf1841382017-06-12 01:16:46 -07003220TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruseAndChangeResolution) {
magjed509e4fe2016-11-18 01:34:11 -08003221 cricket::VideoCodec codec = GetEngineCodec("VP8");
perkj2d5f0912016-02-29 00:04:41 -08003222 cricket::VideoSendParameters parameters;
3223 parameters.codecs.push_back(codec);
3224
kthelgason2bc68642017-02-07 07:02:22 -08003225 MediaConfig media_config = GetMediaConfig();
perkj2d5f0912016-02-29 00:04:41 -08003226 channel_.reset(
3227 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003228 channel_->OnReadyToSend(true);
perkj2d5f0912016-02-29 00:04:41 -08003229 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3230
3231 AddSendStream();
3232
Tommi85959932018-02-07 19:26:06 +01003233 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003234 ASSERT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003235 ASSERT_EQ(cricket::CS_RUNNING,
3236 capturer.Start(capturer.GetSupportedFormats()->front()));
3237 ASSERT_TRUE(channel_->SetSend(true));
3238
3239 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3240 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003241
Niels Möllera6cc0f92018-02-12 17:14:55 +01003242 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003243 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3244 EXPECT_EQ(1280, send_stream->GetLastWidth());
3245 EXPECT_EQ(720, send_stream->GetLastHeight());
3246
3247 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003248 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003249 wants.max_pixel_count =
3250 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003251 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003252 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003253 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3254 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3255 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3256
3257 // Trigger overuse again.
sprangc5d62e22017-04-02 23:53:04 -07003258 wants.max_pixel_count =
3259 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003260 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003261 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003262 EXPECT_EQ(3, send_stream->GetNumberOfSwappedFrames());
3263 EXPECT_EQ(1280 * 2 / 4, send_stream->GetLastWidth());
3264 EXPECT_EQ(720 * 2 / 4, send_stream->GetLastHeight());
3265
3266 // Change input resolution.
Niels Möllera6cc0f92018-02-12 17:14:55 +01003267 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003268 EXPECT_EQ(4, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003269 EXPECT_EQ(1284 / 2, send_stream->GetLastWidth());
3270 EXPECT_EQ(724 / 2, send_stream->GetLastHeight());
3271
3272 // Trigger underuse which should go back up in resolution.
sprang84a37592017-02-10 07:04:27 -08003273 int current_pixel_count =
3274 send_stream->GetLastWidth() * send_stream->GetLastHeight();
3275 // Cap the max to 4x the pixel count (assuming max 1/2 x 1/2 scale downs)
3276 // of the current stream, so we don't take too large steps.
sprangc5d62e22017-04-02 23:53:04 -07003277 wants.max_pixel_count = current_pixel_count * 4;
sprang84a37592017-02-10 07:04:27 -08003278 // Default step down is 3/5 pixel count, so go up by 5/3.
Oskar Sundbom78807582017-11-16 11:09:55 +01003279 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003280 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003281 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003282 EXPECT_EQ(5, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003283 EXPECT_EQ(1284 * 3 / 4, send_stream->GetLastWidth());
3284 EXPECT_EQ(724 * 3 / 4, send_stream->GetLastHeight());
3285
sprang84a37592017-02-10 07:04:27 -08003286 // Trigger underuse again, should go back up to full resolution.
3287 current_pixel_count =
3288 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003289 wants.max_pixel_count = current_pixel_count * 4;
Oskar Sundbom78807582017-11-16 11:09:55 +01003290 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003291 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003292 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003293 EXPECT_EQ(6, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003294 EXPECT_EQ(1284, send_stream->GetLastWidth());
3295 EXPECT_EQ(724, send_stream->GetLastHeight());
3296
Niels Möllerff40b142018-04-09 08:49:14 +02003297 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003298}
3299
eladalonf1841382017-06-12 01:16:46 -07003300TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003301 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003302 cricket::VideoSendParameters parameters;
3303 parameters.codecs.push_back(codec);
3304
kthelgason2bc68642017-02-07 07:02:22 -08003305 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003306 media_config.video.enable_cpu_adaptation = true;
Per766ad3b2016-04-05 15:23:49 +02003307 channel_.reset(
3308 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003309 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003310 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3311
3312 AddSendStream();
3313
Tommi85959932018-02-07 19:26:06 +01003314 FakeVideoCapturerWithTaskQueue capturer;
Per766ad3b2016-04-05 15:23:49 +02003315 ASSERT_EQ(cricket::CS_RUNNING,
3316 capturer.Start(capturer.GetSupportedFormats()->front()));
3317 ASSERT_TRUE(channel_->SetSend(true));
3318 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003319 camera_options.is_screencast = false;
Yves Gerey665174f2018-06-19 15:03:05 +02003320 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
Per766ad3b2016-04-05 15:23:49 +02003321
3322 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3323 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003324
Niels Möllera6cc0f92018-02-12 17:14:55 +01003325 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003326 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3327 EXPECT_EQ(1280, send_stream->GetLastWidth());
3328 EXPECT_EQ(720, send_stream->GetLastHeight());
3329
3330 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003331 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003332 wants.max_pixel_count =
3333 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003334 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003335 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003336 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3337 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3338 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3339
3340 // Switch to screen share. Expect no CPU adaptation.
Tommi85959932018-02-07 19:26:06 +01003341 FakeVideoCapturerWithTaskQueue screen_share(true);
Per766ad3b2016-04-05 15:23:49 +02003342 ASSERT_EQ(cricket::CS_RUNNING,
3343 screen_share.Start(screen_share.GetSupportedFormats()->front()));
Per766ad3b2016-04-05 15:23:49 +02003344 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003345 screenshare_options.is_screencast = true;
Yves Gerey665174f2018-06-19 15:03:05 +02003346 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &screen_share);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003347 EXPECT_TRUE(screen_share.CaptureCustomFrame(1284, 724));
sprangf24a0642017-02-28 13:23:26 -08003348 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3349 send_stream = fake_call_->GetVideoSendStreams().front();
3350 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003351 EXPECT_EQ(1284, send_stream->GetLastWidth());
3352 EXPECT_EQ(724, send_stream->GetLastHeight());
3353
3354 // Switch back to the normal capturer. Expect the frame to be CPU adapted.
Yves Gerey665174f2018-06-19 15:03:05 +02003355 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
sprangf24a0642017-02-28 13:23:26 -08003356 send_stream = fake_call_->GetVideoSendStreams().front();
3357 // We have a new fake send stream, so it doesn't remember the old sink wants.
3358 // In practice, it will be populated from
mflodmancc3d4422017-08-03 08:27:51 -07003359 // VideoStreamEncoder::VideoSourceProxy::SetSource(), so simulate that here.
sprangf24a0642017-02-28 13:23:26 -08003360 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003361 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
sprangf24a0642017-02-28 13:23:26 -08003362 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3363 send_stream = fake_call_->GetVideoSendStreams().front();
3364 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003365 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3366 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3367
Niels Möllerff40b142018-04-09 08:49:14 +02003368 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003369}
3370
asapersson3c81a1a2017-06-14 05:52:21 -07003371// TODO(asapersson): Remove this test when the balanced field trial is removed.
3372void WebRtcVideoChannelTest::TestDegradationPreference(
3373 bool resolution_scaling_enabled,
3374 bool fps_scaling_enabled) {
3375 cricket::VideoCodec codec = GetEngineCodec("VP8");
3376 cricket::VideoSendParameters parameters;
3377 parameters.codecs.push_back(codec);
3378
3379 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003380 media_config.video.enable_cpu_adaptation = true;
asapersson3c81a1a2017-06-14 05:52:21 -07003381 channel_.reset(
3382 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
3383 channel_->OnReadyToSend(true);
3384
3385 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3386
3387 AddSendStream();
3388
Tommi85959932018-02-07 19:26:06 +01003389 FakeVideoCapturerWithTaskQueue capturer;
asapersson3c81a1a2017-06-14 05:52:21 -07003390 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02003391 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
asapersson3c81a1a2017-06-14 05:52:21 -07003392 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
3393 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
3394
3395 EXPECT_TRUE(channel_->SetSend(true));
3396
3397 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3398 EXPECT_EQ(resolution_scaling_enabled,
3399 send_stream->resolution_scaling_enabled());
3400 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3401
Niels Möllerff40b142018-04-09 08:49:14 +02003402 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003403}
3404
eladalonf1841382017-06-12 01:16:46 -07003405void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3406 bool is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003407 const int kDefaultFps = 30;
magjed509e4fe2016-11-18 01:34:11 -08003408 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003409 cricket::VideoSendParameters parameters;
3410 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003411
kthelgason2bc68642017-02-07 07:02:22 -08003412 MediaConfig media_config = GetMediaConfig();
3413 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003414 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003415 }
nisse51542be2016-02-12 02:27:06 -08003416 channel_.reset(
3417 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003418 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003419
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003420 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003421
3422 AddSendStream();
3423
Tommi85959932018-02-07 19:26:06 +01003424 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07003425 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003426 options.is_screencast = is_screenshare;
Niels Möllerff40b142018-04-09 08:49:14 +02003427 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj26752742016-10-24 01:21:16 -07003428 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
sprangc5d62e22017-04-02 23:53:04 -07003429 capture_format.interval = rtc::kNumNanosecsPerSec / kDefaultFps;
perkj26752742016-10-24 01:21:16 -07003430 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003431
3432 EXPECT_TRUE(channel_->SetSend(true));
3433
solenberge5269742015-09-08 05:13:22 -07003434 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003435
sprangc5d62e22017-04-02 23:53:04 -07003436 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003437 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003438 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3439 EXPECT_EQ(is_screenshare, send_stream->framerate_scaling_enabled());
perkj2d5f0912016-02-29 00:04:41 -08003440
3441 EXPECT_TRUE(capturer.CaptureFrame());
3442 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3443
perkj26752742016-10-24 01:21:16 -07003444 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3445 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
perkj2d5f0912016-02-29 00:04:41 -08003446
Niels Möllerff40b142018-04-09 08:49:14 +02003447 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003448 return;
3449 }
3450
sprangc5d62e22017-04-02 23:53:04 -07003451 if (is_screenshare) {
3452 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3453 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3454 } else {
3455 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3456 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3457 }
3458
perkj803d97f2016-11-01 11:45:46 -07003459 // Trigger overuse.
3460 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3461
3462 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003463 if (is_screenshare) {
3464 wants.max_framerate_fps = (kDefaultFps * 2) / 3;
3465 } else {
3466 wants.max_pixel_count = capture_format.width * capture_format.height - 1;
3467 }
perkj803d97f2016-11-01 11:45:46 -07003468 send_stream->InjectVideoSinkWants(wants);
3469
sprangc5d62e22017-04-02 23:53:04 -07003470 for (int i = 0; i < kDefaultFps; ++i)
3471 EXPECT_TRUE(capturer.CaptureFrame());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003472
sprangc5d62e22017-04-02 23:53:04 -07003473 if (is_screenshare) {
3474 // Drops every third frame.
3475 EXPECT_EQ(kDefaultFps * 2 / 3, send_stream->GetNumberOfSwappedFrames());
3476 EXPECT_EQ(send_stream->GetLastWidth(), capture_format.width);
3477 EXPECT_EQ(send_stream->GetLastHeight(), capture_format.height);
3478 } else {
3479 EXPECT_EQ(kDefaultFps, send_stream->GetNumberOfSwappedFrames());
3480 EXPECT_LT(send_stream->GetLastWidth(), capture_format.width);
3481 EXPECT_LT(send_stream->GetLastHeight(), capture_format.height);
3482 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003483
3484 // Trigger underuse which should go back to normal resolution.
sprang84a37592017-02-10 07:04:27 -08003485 int last_pixel_count =
3486 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003487 if (is_screenshare) {
3488 wants.max_framerate_fps = kDefaultFps;
3489 } else {
3490 wants.max_pixel_count = last_pixel_count * 4;
3491 wants.target_pixel_count.emplace((last_pixel_count * 5) / 3);
3492 }
perkj803d97f2016-11-01 11:45:46 -07003493 send_stream->InjectVideoSinkWants(wants);
3494
sprangc5d62e22017-04-02 23:53:04 -07003495 for (int i = 0; i < kDefaultFps; ++i)
3496 EXPECT_TRUE(capturer.CaptureFrame());
3497
3498 if (is_screenshare) {
3499 EXPECT_EQ(kDefaultFps + (kDefaultFps * 2 / 3),
3500 send_stream->GetNumberOfSwappedFrames());
3501 } else {
3502 EXPECT_EQ(kDefaultFps * 2, send_stream->GetNumberOfSwappedFrames());
3503 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003504
perkj26752742016-10-24 01:21:16 -07003505 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3506 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003507
Niels Möllerff40b142018-04-09 08:49:14 +02003508 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003509}
3510
eladalonf1841382017-06-12 01:16:46 -07003511TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003512 // Start at last timestamp to verify that wraparounds are estimated correctly.
3513 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3514 static const int64_t kInitialNtpTimeMs = 1247891230;
3515 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003516 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003517
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003518 FakeVideoReceiveStream* stream = AddRecvStream();
3519 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003520 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003521
nisse64ec8f82016-09-27 00:17:25 -07003522 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4),
3523 kInitialTimestamp, 0,
3524 webrtc::kVideoRotation_0);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003525 // Initial NTP time is not available on the first frame, but should still be
3526 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003527 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003528
3529 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003530
3531 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3532 // triggers a constant-overflow warning, hence we're calculating it explicitly
3533 // here.
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +02003534 fake_clock_.AdvanceTimeMicros(kFrameOffsetMs * rtc::kNumMicrosecsPerMillisec);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003535 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3536 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003537 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003538
3539 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003540
3541 // Verify that NTP time has been correctly deduced.
3542 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003543 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003544 ASSERT_EQ(1u, info.receivers.size());
3545 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003546}
3547
eladalonf1841382017-06-12 01:16:46 -07003548TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003549 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003550 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003551
3552 VideoCodec codec;
3553 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003554 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003555
3556 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003557 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3558 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003559 FakeVideoSendStream* stream = AddSendStream(
3560 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003561 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003562
3563 // Make sure NACK and FEC are enabled on the correct payload types.
3564 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003565 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3566 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003567
3568 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3569 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003570 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003571 // TODO(juberti): Check RTCP, PLI, TMMBR.
3572}
3573
brandtr31bd2242017-05-19 05:47:46 -07003574// The following four tests ensures that FlexFEC is not activated by default
3575// when the field trials are not enabled.
3576// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3577// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003578TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003579 FakeVideoSendStream* stream = AddSendStream();
3580 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3581
brandtr3d200bd2017-01-16 06:59:19 -08003582 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003583 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3584 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003585}
3586
eladalonf1841382017-06-12 01:16:46 -07003587TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003588 FakeVideoSendStream* stream = AddSendStream(
3589 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3590 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3591
brandtr3d200bd2017-01-16 06:59:19 -08003592 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003593 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3594 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3595}
3596
Yves Gerey665174f2018-06-19 15:03:05 +02003597TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003598 AddRecvStream();
3599
3600 const std::vector<FakeFlexfecReceiveStream*>& streams =
3601 fake_call_->GetFlexfecReceiveStreams();
3602 EXPECT_TRUE(streams.empty());
3603}
3604
eladalonf1841382017-06-12 01:16:46 -07003605TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003606 AddRecvStream(
3607 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3608
3609 const std::vector<FakeFlexfecReceiveStream*>& streams =
3610 fake_call_->GetFlexfecReceiveStreams();
3611 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003612}
3613
3614// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3615// tests that use this test fixture into the corresponding "non-field trial"
3616// tests.
eladalonf1841382017-06-12 01:16:46 -07003617class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003618 public:
eladalonf1841382017-06-12 01:16:46 -07003619 WebRtcVideoChannelFlexfecRecvTest()
3620 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003621};
3622
eladalonf1841382017-06-12 01:16:46 -07003623TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003624 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3625 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3626 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3627}
3628
eladalonf1841382017-06-12 01:16:46 -07003629TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003630 AddRecvStream();
3631
3632 const std::vector<FakeFlexfecReceiveStream*>& streams =
3633 fake_call_->GetFlexfecReceiveStreams();
3634 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003635
3636 const std::vector<FakeVideoReceiveStream*>& video_streams =
3637 fake_call_->GetVideoReceiveStreams();
3638 ASSERT_EQ(1U, video_streams.size());
3639 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3640 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3641 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003642}
3643
eladalonf1841382017-06-12 01:16:46 -07003644TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003645 AddRecvStream(
3646 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3647
3648 const std::vector<FakeFlexfecReceiveStream*>& streams =
3649 fake_call_->GetFlexfecReceiveStreams();
3650 ASSERT_EQ(1U, streams.size());
3651 const FakeFlexfecReceiveStream* stream = streams.front();
3652 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3653 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3654 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3655 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3656 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003657
3658 const std::vector<FakeVideoReceiveStream*>& video_streams =
3659 fake_call_->GetVideoReceiveStreams();
3660 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003661 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3662 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003663 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003664 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003665 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003666}
3667
eladalonf1841382017-06-12 01:16:46 -07003668TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003669 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3670 cricket::VideoRecvParameters recv_parameters;
3671 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3672 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3673
3674 AddRecvStream(
3675 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3676 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003677 const std::vector<FakeVideoReceiveStream*>& video_streams =
3678 fake_call_->GetVideoReceiveStreams();
3679 ASSERT_EQ(1U, video_streams.size());
3680 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3681 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3682 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003683
3684 // Enable FlexFEC.
3685 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3686 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3687 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3688 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3689 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3690 << "Enabling FlexFEC should not create VideoReceiveStream.";
3691 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3692 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003693 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3694 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003695}
3696
eladalonf1841382017-06-12 01:16:46 -07003697TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003698 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3699 cricket::VideoRecvParameters recv_parameters;
3700 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3701 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3702 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3703
3704 AddRecvStream(
3705 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3706 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003707 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003708 const std::vector<FakeVideoReceiveStream*>& video_streams =
3709 fake_call_->GetVideoReceiveStreams();
3710 ASSERT_EQ(1U, video_streams.size());
3711 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3712 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3713 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003714
3715 // Disable FlexFEC.
3716 recv_parameters.codecs.clear();
3717 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3718 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3719 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3720 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3721 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3722 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3723 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3724 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003725 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3726 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003727}
3728
brandtr31bd2242017-05-19 05:47:46 -07003729// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3730// tests that use this test fixture into the corresponding "non-field trial"
3731// tests.
eladalonf1841382017-06-12 01:16:46 -07003732class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003733 public:
eladalonf1841382017-06-12 01:16:46 -07003734 WebRtcVideoChannelFlexfecSendRecvTest()
3735 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003736 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3737 }
3738};
3739
Yves Gerey665174f2018-06-19 15:03:05 +02003740TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003741 FakeVideoSendStream* stream = AddSendStream();
3742 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3743
brandtr3d200bd2017-01-16 06:59:19 -08003744 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3745 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3746 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003747}
3748
eladalonf1841382017-06-12 01:16:46 -07003749TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003750 FakeVideoSendStream* stream = AddSendStream(
3751 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3752 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3753
brandtr3d200bd2017-01-16 06:59:19 -08003754 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3755 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3756 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3757 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003758}
3759
eladalonf1841382017-06-12 01:16:46 -07003760TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003761 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003762 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003763 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003764
3765 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003766 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003767
brandtrb5f2c3f2016-10-04 23:28:39 -07003768 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3769 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003770}
3771
eladalonf1841382017-06-12 01:16:46 -07003772TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003773 cricket::VideoSendParameters parameters;
3774 parameters.codecs.push_back(GetEngineCodec("VP8"));
3775 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3776
3777 FakeVideoSendStream* stream = AddSendStream();
3778 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3779
brandtr3d200bd2017-01-16 06:59:19 -08003780 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003781}
3782
eladalonf1841382017-06-12 01:16:46 -07003783TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003784 AddRecvStream(
3785 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003786
3787 cricket::VideoRecvParameters recv_parameters;
3788 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3789 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3790 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003791
3792 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3793 fake_call_->GetFlexfecReceiveStreams();
3794 ASSERT_EQ(1U, flexfec_streams.size());
3795 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3796 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3797 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003798 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003799 flexfec_stream_config.payload_type);
3800 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3801 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3802 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3803 const std::vector<FakeVideoReceiveStream*>& video_streams =
3804 fake_call_->GetVideoReceiveStreams();
3805 const FakeVideoReceiveStream* video_stream = video_streams.front();
3806 const webrtc::VideoReceiveStream::Config& video_stream_config =
3807 video_stream->GetConfig();
3808 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3809 flexfec_stream_config.local_ssrc);
3810 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3811 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3812 flexfec_stream_config.rtcp_send_transport);
3813 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3814 // spec-compliant way.
3815 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3816 flexfec_stream_config.transport_cc);
3817 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3818 EXPECT_EQ(video_stream_config.rtp.extensions,
3819 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003820}
3821
brandtr31bd2242017-05-19 05:47:46 -07003822// We should not send FlexFEC, even if we advertise it, unless the right
3823// field trial is set.
3824// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003825TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003826 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3827 cricket::VideoSendParameters parameters;
3828 parameters.codecs.push_back(GetEngineCodec("VP8"));
3829 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3830 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3831
3832 FakeVideoSendStream* stream = AddSendStream();
3833 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3834
3835 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003836 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003837 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3838}
3839
eladalonf1841382017-06-12 01:16:46 -07003840TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003841 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3842 cricket::VideoSendParameters parameters;
3843 parameters.codecs.push_back(GetEngineCodec("VP8"));
3844 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3845 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3846
3847 FakeVideoSendStream* stream = AddSendStream(
3848 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3849 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3850
3851 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003852 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003853 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3854}
3855
eladalonf1841382017-06-12 01:16:46 -07003856TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003857 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003858 const int kUnusedPayloadType = 127;
3859 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3860
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003861 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003862 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003863 parameters.codecs.push_back(rtx_codec);
3864 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003865 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003866}
3867
eladalonf1841382017-06-12 01:16:46 -07003868TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003869 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003870 const int kUnusedPayloadType1 = 126;
3871 const int kUnusedPayloadType2 = 127;
3872 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3873 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3874 {
3875 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3876 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3877 cricket::VideoSendParameters parameters;
3878 parameters.codecs.push_back(GetEngineCodec("VP8"));
3879 parameters.codecs.push_back(rtx_codec);
3880 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3881 }
3882 {
3883 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3884 kUnusedPayloadType1, kUnusedPayloadType2);
3885 cricket::VideoSendParameters parameters;
3886 parameters.codecs.push_back(GetEngineCodec("VP8"));
3887 parameters.codecs.push_back(rtx_codec);
3888 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3889 << "RTX without matching video codec should be rejected.";
3890 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003891}
3892
eladalonf1841382017-06-12 01:16:46 -07003893TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003894 const int kUnusedPayloadType1 = 126;
3895 const int kUnusedPayloadType2 = 127;
3896 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3897 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3898
3899 // SSRCs for RTX.
3900 cricket::StreamParams params =
3901 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3902 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3903 AddSendStream(params);
3904
3905 // Original payload type for RTX.
3906 cricket::VideoSendParameters parameters;
3907 parameters.codecs.push_back(GetEngineCodec("VP8"));
3908 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3909 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3910 parameters.codecs.push_back(rtx_codec);
3911 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3912 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3913 const webrtc::VideoSendStream::Config& config_before =
3914 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3915 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3916 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3917 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3918
3919 // Change payload type for RTX.
3920 parameters.codecs[1].id = kUnusedPayloadType2;
3921 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3922 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3923 const webrtc::VideoSendStream::Config& config_after =
3924 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3925 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3926 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3927 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3928}
3929
eladalonf1841382017-06-12 01:16:46 -07003930TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003931 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003932 parameters.codecs.push_back(GetEngineCodec("VP8"));
3933 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003934 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003935
3936 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003937 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003938
magjed509e4fe2016-11-18 01:34:11 -08003939 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003940
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003941 parameters.codecs.pop_back();
3942 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003943 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003944 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003945 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003946 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003947 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3948}
3949
eladalonf1841382017-06-12 01:16:46 -07003950TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003951 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003952 cricket::VideoSendParameters parameters;
3953 parameters.codecs.push_back(GetEngineCodec("VP8"));
3954 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3955 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3956
3957 FakeVideoSendStream* stream = AddSendStream(
3958 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3959 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3960
brandtr3d200bd2017-01-16 06:59:19 -08003961 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3962 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003963 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3964 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
3965
3966 parameters.codecs.pop_back();
3967 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3968 stream = fake_call_->GetVideoSendStreams()[0];
3969 ASSERT_TRUE(stream != nullptr);
3970 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08003971 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003972 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003973}
3974
eladalonf1841382017-06-12 01:16:46 -07003975TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003976 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07003977 cricket::VideoCodec codec(100, "VP8");
3978 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
3979 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07003980
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003981 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003982 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003983
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003984 FakeVideoSendStream* stream = AddSendStream();
Tommi85959932018-02-07 19:26:06 +01003985 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003986 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003987
3988 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003989 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003990
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003991 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07003992 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
3993 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003994 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003995 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003996 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02003997 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003998}
3999
eladalonf1841382017-06-12 01:16:46 -07004000TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004001 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4002 200000);
4003}
4004
eladalonf1841382017-06-12 01:16:46 -07004005TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00004006 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
4007 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
4008 ASSERT_EQ(1u, streams.size());
4009 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
4010}
4011
eladalonf1841382017-06-12 01:16:46 -07004012TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00004013 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004014 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00004015}
4016
eladalonf1841382017-06-12 01:16:46 -07004017TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004018 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004019}
4020
eladalonf1841382017-06-12 01:16:46 -07004021TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004022 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
4023 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
4024 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004025}
4026
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004027// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4028// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07004029TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004030 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4031 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4032 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4033 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004034 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004035 ExpectSetBitrateParameters(100000, 200000, 400000);
4036 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4037 // Since the codec isn't changing, start_bitrate_bps should be -1.
4038 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004039
4040 // Decrease max_bandwidth_bps.
4041 send_parameters_.max_bandwidth_bps = 350000;
4042 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004043
4044 // Now try again with the values flipped around.
4045 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4046 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004047 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004048 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004049
4050 // If we change the codec max, max_bandwidth_bps should still apply.
4051 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004052 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004053 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004054}
4055
Yves Gerey665174f2018-06-19 15:03:05 +02004056TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004057 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4058 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004059 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004060 // Setting max bitrate should keep previous min bitrate.
4061 // Setting max bitrate should not reset start bitrate.
4062 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004063 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004064}
4065
eladalonf1841382017-06-12 01:16:46 -07004066TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004067 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004068 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004069 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004070 // -1 means to disable max bitrate (set infinite).
4071 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004072 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004073 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004074}
4075
eladalonf1841382017-06-12 01:16:46 -07004076TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004077 send_parameters_.max_bandwidth_bps = 99999;
4078 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004079 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004080 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004081 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4082 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4083 stream->GetVideoStreams()[0].max_bitrate_bps);
4084
4085 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004086 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004087 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4088 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004089 stream->GetVideoStreams()[0].max_bitrate_bps);
4090}
4091
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004092// Tests that when the codec specific max bitrate and VideoSendParameters
4093// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4094// appropriately.
4095TEST_F(WebRtcVideoChannelTest,
4096 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4097 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4098 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4099 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4100 send_parameters_.max_bandwidth_bps = -1;
4101 AddSendStream();
4102 ExpectSetMaxBitrate(300000);
4103 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4104
4105 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4106 ASSERT_EQ(1u, video_send_streams.size());
4107 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4108 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4109 // First the max bitrate is set based upon the codec param.
4110 EXPECT_EQ(300000,
4111 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4112
4113 // The VideoSendParameters max bitrate overrides the codec's.
4114 send_parameters_.max_bandwidth_bps = 500000;
4115 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4116 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4117 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4118 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4119}
4120
4121// Tests that when the codec specific max bitrate and RtpParameters
4122// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4123// appropriately.
4124TEST_F(WebRtcVideoChannelTest,
4125 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4126 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4127 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4128 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4129 send_parameters_.max_bandwidth_bps = -1;
4130 AddSendStream();
4131 ExpectSetMaxBitrate(300000);
4132 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4133
4134 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4135 ASSERT_EQ(1u, video_send_streams.size());
4136 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4137 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4138 // First the max bitrate is set based upon the codec param.
4139 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4140
4141 // The RtpParameter max bitrate overrides the codec's.
4142 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4143 ASSERT_EQ(1u, parameters.encodings.size());
4144 parameters.encodings[0].max_bitrate_bps = 500000;
4145 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4146 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4147 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4148 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4149}
4150
Åsa Persson55659812018-06-18 17:51:32 +02004151TEST_F(WebRtcVideoChannelTest,
4152 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4153 send_parameters_.max_bandwidth_bps = 99999;
4154 FakeVideoSendStream* stream = AddSendStream();
4155 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4156 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4157 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4158 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4159 stream->GetVideoStreams()[0].max_bitrate_bps);
4160
4161 // Get and set the rtp encoding parameters.
4162 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4163 EXPECT_EQ(1u, parameters.encodings.size());
4164
4165 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4166 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4167 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4168 stream->GetVideoStreams()[0].max_bitrate_bps);
4169
4170 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4171 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4172 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4173 stream->GetVideoStreams()[0].max_bitrate_bps);
4174}
4175
eladalonf1841382017-06-12 01:16:46 -07004176TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004177 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004178 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004179 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004180 channel_->SetSend(true);
4181
4182 FakeVideoSendStream* stream = AddSendStream();
4183
Tommi85959932018-02-07 19:26:06 +01004184 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004185 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Peter Boström3afc8c42016-01-27 16:45:21 +01004186 EXPECT_EQ(cricket::CS_RUNNING,
4187 capturer.Start(capturer.GetSupportedFormats()->front()));
4188
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004189 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4190 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4191 EXPECT_GT(initial_max_bitrate_bps, 0);
4192
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004193 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4194 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004195 // Insert a frame to update the encoder config.
4196 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004197 streams = stream->GetVideoStreams();
4198 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004199 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004200}
4201
eladalonf1841382017-06-12 01:16:46 -07004202TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004203 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004204 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004205 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004206 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004207 channel_->SetSend(true);
4208
4209 FakeVideoSendStream* stream = AddSendStream(
4210 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4211
4212 // Send a frame to make sure this scales up to >1 stream (simulcast).
Tommi85959932018-02-07 19:26:06 +01004213 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004214 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &capturer));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004215 EXPECT_EQ(cricket::CS_RUNNING,
4216 capturer.Start(capturer.GetSupportedFormats()->front()));
4217 EXPECT_TRUE(capturer.CaptureFrame());
4218
4219 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4220 ASSERT_GT(streams.size(), 1u)
4221 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004222 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004223 EXPECT_GT(initial_max_bitrate_bps, 0);
4224
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004225 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4226 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004227 // Insert a frame to update the encoder config.
4228 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004229 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004230 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004231 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4232
Niels Möllerff40b142018-04-09 08:49:14 +02004233 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004234}
4235
eladalonf1841382017-06-12 01:16:46 -07004236TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004237 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004238 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004239 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004240 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4241 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004242 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004243 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004244
4245 VideoCodec codec;
4246 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4247 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4248}
4249
eladalonf1841382017-06-12 01:16:46 -07004250TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004251 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004252 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004253 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004254 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004255 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004256 parameters.codecs[0].id = kIncorrectPayloads[i];
4257 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004258 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004259 }
4260}
4261
eladalonf1841382017-06-12 01:16:46 -07004262TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004263 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004264 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004265 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004266 parameters.codecs[0].id = payload_type;
4267 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004268 << "Payload type '" << payload_type << "' rejected.";
4269 }
4270}
4271
deadbeef67cf2c12016-04-13 10:07:16 -07004272// Test that setting the a different set of codecs but with an identical front
4273// codec doesn't result in the stream being recreated.
4274// This may happen when a subsequent negotiation includes fewer codecs, as a
4275// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004276TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004277 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4278 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004279 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4280 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004281 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4282
4283 AddSendStream();
4284 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4285
4286 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004287 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004288 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4289 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4290}
4291
eladalonf1841382017-06-12 01:16:46 -07004292TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004293 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004294 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004295 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004296}
4297
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004298// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004299TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004300 const int kUnusedPayloadType1 = 126;
4301 const int kUnusedPayloadType2 = 127;
4302 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4303 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4304
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004305 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004306 parameters.codecs.push_back(GetEngineCodec("VP8"));
4307 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004308 parameters.codecs.push_back(rtx_codec);
4309 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004310 << "RTX codec without associated payload should be rejected.";
4311
magjed509e4fe2016-11-18 01:34:11 -08004312 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004313 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004314 << "RTX codec with invalid associated payload type should be rejected.";
4315
magjed509e4fe2016-11-18 01:34:11 -08004316 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004317 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004318
magjed509e4fe2016-11-18 01:34:11 -08004319 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004320 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004321 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004322
Yves Gerey665174f2018-06-19 15:03:05 +02004323 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4324 << "RTX codec with another RTX as associated payload type should be "
4325 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004326}
4327
eladalonf1841382017-06-12 01:16:46 -07004328TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004329 const int kUnusedPayloadType1 = 126;
4330 const int kUnusedPayloadType2 = 127;
4331 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4332 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4333
4334 // SSRCs for RTX.
4335 cricket::StreamParams params =
4336 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4337 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4338 AddRecvStream(params);
4339
4340 // Original payload type for RTX.
4341 cricket::VideoRecvParameters parameters;
4342 parameters.codecs.push_back(GetEngineCodec("VP8"));
4343 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4344 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4345 parameters.codecs.push_back(rtx_codec);
4346 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4347 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4348 const webrtc::VideoReceiveStream::Config& config_before =
4349 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004350 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4351 const int* payload_type_before = FindKeyByValue(
4352 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4353 ASSERT_NE(payload_type_before, nullptr);
4354 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004355 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4356
4357 // Change payload type for RTX.
4358 parameters.codecs[1].id = kUnusedPayloadType2;
4359 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4360 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4361 const webrtc::VideoReceiveStream::Config& config_after =
4362 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004363 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4364 const int* payload_type_after = FindKeyByValue(
4365 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4366 ASSERT_NE(payload_type_after, nullptr);
4367 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004368 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4369}
4370
eladalonf1841382017-06-12 01:16:46 -07004371TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004372 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004373 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004374 parameters.codecs[0].id = 99;
4375 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004376}
4377
eladalonf1841382017-06-12 01:16:46 -07004378TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004379 cricket::VideoRecvParameters parameters;
4380 parameters.codecs = engine_.codecs();
4381 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004382
4383 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004384 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004385 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004386 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004387}
4388
eladalonf1841382017-06-12 01:16:46 -07004389TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004390 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004391 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004392 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004393 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004394}
4395
eladalonf1841382017-06-12 01:16:46 -07004396TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004397 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004398 parameters.codecs.push_back(GetEngineCodec("VP8"));
4399 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004400 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004401}
4402
eladalonf1841382017-06-12 01:16:46 -07004403TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004404 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004405 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4406 send_parameters.codecs.push_back(GetEngineCodec("red"));
4407 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004408 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004409
4410 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004411
magjed509e4fe2016-11-18 01:34:11 -08004412 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004413 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004414
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004415 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004416 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004417 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004418 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004419 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004420 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004421 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4422}
4423
eladalonf1841382017-06-12 01:16:46 -07004424TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004425 AddRecvStream(
4426 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004427 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004428 fake_call_->GetFlexfecReceiveStreams();
4429
4430 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004431 const FakeFlexfecReceiveStream* stream = streams.front();
4432 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4433 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4434 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4435 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004436
4437 cricket::VideoRecvParameters recv_parameters;
4438 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4439 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4440 EXPECT_TRUE(streams.empty())
4441 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004442}
4443
eladalonf1841382017-06-12 01:16:46 -07004444TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004445 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004446 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004447 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004448
4449 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004450 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4451 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4452 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004453 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4454 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004455 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004456 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004457 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004458 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004459
4460 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004461 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4462 send_parameters.codecs.push_back(GetEngineCodec("red"));
4463 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004464 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4465 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004466 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004467 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004468 << "ULPFEC should be enabled on the receive stream.";
4469}
4470
eladalonf1841382017-06-12 01:16:46 -07004471TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004472 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004473 AddRecvStream(
4474 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004475 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004476 fake_call_->GetFlexfecReceiveStreams();
4477
4478 cricket::VideoRecvParameters recv_parameters;
4479 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4480 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4481 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4482 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004483 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004484 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004485 stream_with_recv_params->GetConfig().payload_type);
4486 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004487 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004488 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004489 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004490 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004491
4492 cricket::VideoSendParameters send_parameters;
4493 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4494 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4495 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4496 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004497 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004498 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004499 stream_with_send_params->GetConfig().payload_type);
4500 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004501 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004502 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004503 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004504 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004505}
4506
eladalonf1841382017-06-12 01:16:46 -07004507TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004508 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004509 parameters.codecs.push_back(GetEngineCodec("VP8"));
4510 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004511 parameters.codecs[1].id = parameters.codecs[0].id;
4512 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004513}
4514
eladalonf1841382017-06-12 01:16:46 -07004515TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004516 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004517 cricket::VideoRecvParameters parameters;
4518 parameters.codecs.push_back(GetEngineCodec("VP8"));
4519 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4520 parameters.codecs[1].id = parameters.codecs[0].id;
4521 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4522}
4523
eladalonf1841382017-06-12 01:16:46 -07004524TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004525 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004526 parameters.codecs.push_back(GetEngineCodec("VP8"));
4527 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004528 parameters.codecs[1].id = parameters.codecs[0].id;
4529 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004530}
4531
eladalonf1841382017-06-12 01:16:46 -07004532TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004533 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004534 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004535 parameters.codecs.push_back(GetEngineCodec("VP8"));
4536 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004537 parameters.codecs[1].id += 1;
4538 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004539}
4540
deadbeef67cf2c12016-04-13 10:07:16 -07004541// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004542// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004543TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004544 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004545 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004546 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4547 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004548 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004549
4550 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4551 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4552
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004553 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004554 parameters2.codecs.push_back(GetEngineCodec("red"));
4555 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004556 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004557 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4558}
4559
eladalonf1841382017-06-12 01:16:46 -07004560TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004561 EXPECT_FALSE(AddSendStream()->IsSending());
4562}
4563
eladalonf1841382017-06-12 01:16:46 -07004564TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004565 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004566}
4567
eladalonf1841382017-06-12 01:16:46 -07004568TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004569 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004570 EXPECT_FALSE(stream->IsSending());
4571
4572 // false->true
4573 EXPECT_TRUE(channel_->SetSend(true));
4574 EXPECT_TRUE(stream->IsSending());
4575 // true->true
4576 EXPECT_TRUE(channel_->SetSend(true));
4577 EXPECT_TRUE(stream->IsSending());
4578 // true->false
4579 EXPECT_TRUE(channel_->SetSend(false));
4580 EXPECT_FALSE(stream->IsSending());
4581 // false->false
4582 EXPECT_TRUE(channel_->SetSend(false));
4583 EXPECT_FALSE(stream->IsSending());
4584
4585 EXPECT_TRUE(channel_->SetSend(true));
4586 FakeVideoSendStream* new_stream = AddSendStream();
4587 EXPECT_TRUE(new_stream->IsSending())
4588 << "Send stream created after SetSend(true) not sending initially.";
4589}
4590
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004591// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004592TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004593 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004594 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004595 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004596 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
nisse51542be2016-02-12 02:27:06 -08004597
Tim Haloun6ca98362018-09-17 17:06:08 -07004598 channel.reset(static_cast<cricket::WebRtcVideoChannel*>(
4599 engine_.CreateChannel(call_.get(), config, VideoOptions())));
Oleh Prypin37cf2452018-10-14 19:44:29 +00004600 channel->SetInterface(network_interface.get());
nisse51542be2016-02-12 02:27:06 -08004601 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004602 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004603
4604 config.enable_dscp = true;
Tim Haloun6ca98362018-09-17 17:06:08 -07004605 channel.reset(static_cast<cricket::WebRtcVideoChannel*>(
4606 engine_.CreateChannel(call_.get(), config, VideoOptions())));
Oleh Prypin37cf2452018-10-14 19:44:29 +00004607 channel->SetInterface(network_interface.get());
nisse51542be2016-02-12 02:27:06 -08004608 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
4609
Tim Haloun6ca98362018-09-17 17:06:08 -07004610 // Packets should also self-identify their dscp in PacketOptions.
4611 const uint8_t kData[10] = {0};
4612 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4613 ->SendRtcp(kData, sizeof(kData)));
4614 EXPECT_EQ(rtc::DSCP_AF41, network_interface->options().dscp);
4615
nisse51542be2016-02-12 02:27:06 -08004616 // Verify that setting the option to false resets the
4617 // DiffServCodePoint.
4618 config.enable_dscp = false;
Tim Haloun6ca98362018-09-17 17:06:08 -07004619 channel.reset(static_cast<cricket::WebRtcVideoChannel*>(
4620 engine_.CreateChannel(call_.get(), config, VideoOptions())));
Oleh Prypin37cf2452018-10-14 19:44:29 +00004621 channel->SetInterface(network_interface.get());
nisse51542be2016-02-12 02:27:06 -08004622 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004623}
4624
deadbeef13871492015-12-09 12:37:51 -08004625// This test verifies that the RTCP reduced size mode is properly applied to
4626// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004627TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004628 // Create stream, expecting that default mode is "compound".
4629 FakeVideoSendStream* stream1 = AddSendStream();
4630 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004631 webrtc::RtpParameters rtp_parameters =
4632 channel_->GetRtpSendParameters(last_ssrc_);
4633 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004634
4635 // Now enable reduced size mode.
4636 send_parameters_.rtcp.reduced_size = true;
4637 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4638 stream1 = fake_call_->GetVideoSendStreams()[0];
4639 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004640 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4641 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004642
4643 // Create a new stream and ensure it picks up the reduced size mode.
4644 FakeVideoSendStream* stream2 = AddSendStream();
4645 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4646}
4647
4648// This test verifies that the RTCP reduced size mode is properly applied to
4649// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004650TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004651 // Create stream, expecting that default mode is "compound".
4652 FakeVideoReceiveStream* stream1 = AddRecvStream();
4653 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4654
4655 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004656 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4657 // the reduced_size flag should come from that.
4658 send_parameters_.rtcp.reduced_size = true;
4659 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004660 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4661 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4662
4663 // Create a new stream and ensure it picks up the reduced size mode.
4664 FakeVideoReceiveStream* stream2 = AddRecvStream();
4665 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4666}
4667
eladalonf1841382017-06-12 01:16:46 -07004668TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004669 EXPECT_EQ(webrtc::kNetworkUp,
4670 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4671 EXPECT_EQ(webrtc::kNetworkUp,
4672 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004673
4674 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004675 EXPECT_EQ(webrtc::kNetworkDown,
4676 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4677 EXPECT_EQ(webrtc::kNetworkUp,
4678 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004679
4680 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004681 EXPECT_EQ(webrtc::kNetworkUp,
4682 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4683 EXPECT_EQ(webrtc::kNetworkUp,
4684 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004685}
4686
eladalonf1841382017-06-12 01:16:46 -07004687TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004688 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004689 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004690 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004691
4692 AddSendStream();
4693
4694 cricket::VideoMediaInfo info;
4695 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004696 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004697}
4698
eladalonf1841382017-06-12 01:16:46 -07004699TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004700 FakeVideoSendStream* stream = AddSendStream();
4701 webrtc::VideoSendStream::Stats stats;
4702 stats.encoder_implementation_name = "encoder_implementation_name";
4703 stream->SetStats(stats);
4704
4705 cricket::VideoMediaInfo info;
4706 ASSERT_TRUE(channel_->GetStats(&info));
4707 EXPECT_EQ(stats.encoder_implementation_name,
4708 info.senders[0].encoder_implementation_name);
4709}
4710
eladalonf1841382017-06-12 01:16:46 -07004711TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004712 FakeVideoSendStream* stream = AddSendStream();
4713 webrtc::VideoSendStream::Stats stats;
4714 stats.avg_encode_time_ms = 13;
4715 stats.encode_usage_percent = 42;
4716 stream->SetStats(stats);
4717
4718 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004719 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004720 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4721 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4722}
4723
eladalonf1841382017-06-12 01:16:46 -07004724TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004725 FakeVideoSendStream* stream = AddSendStream();
4726 webrtc::VideoSendStream::Stats stats;
4727 stats.frames_encoded = 13;
4728 stream->SetStats(stats);
4729
4730 cricket::VideoMediaInfo info;
4731 ASSERT_TRUE(channel_->GetStats(&info));
4732 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4733}
4734
eladalonf1841382017-06-12 01:16:46 -07004735TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004736 FakeVideoSendStream* stream = AddSendStream();
4737 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004738 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004739 stream->SetStats(stats);
4740
4741 cricket::VideoMediaInfo info;
4742 ASSERT_TRUE(channel_->GetStats(&info));
4743 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4744}
4745
eladalonf1841382017-06-12 01:16:46 -07004746TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004747 FakeVideoSendStream* stream = AddSendStream();
4748 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004749 stats.substreams[17].width = 123;
4750 stats.substreams[17].height = 40;
4751 stats.substreams[42].width = 80;
4752 stats.substreams[42].height = 31;
4753 stats.substreams[11].width = 20;
4754 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004755 stream->SetStats(stats);
4756
4757 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004758 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004759 ASSERT_EQ(1u, info.senders.size());
4760 EXPECT_EQ(123, info.senders[0].send_frame_width);
4761 EXPECT_EQ(90, info.senders[0].send_frame_height);
4762}
4763
eladalonf1841382017-06-12 01:16:46 -07004764TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004765 FakeVideoSendStream* stream = AddSendStream();
4766 webrtc::VideoSendStream::Stats stats;
4767 stats.number_of_cpu_adapt_changes = 2;
4768 stats.cpu_limited_resolution = true;
4769 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004770
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004771 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004772 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004773 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004774 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004775 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004776}
4777
eladalonf1841382017-06-12 01:16:46 -07004778TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004779 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004780 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004781 stats.number_of_cpu_adapt_changes = 2;
4782 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004783 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004784 stream->SetStats(stats);
4785
4786 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004787 EXPECT_TRUE(channel_->GetStats(&info));
4788 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004789 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4790 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004791 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004792 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004793}
4794
eladalonf1841382017-06-12 01:16:46 -07004795TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004796 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4797 FakeVideoSendStream* stream = AddSendStream();
4798 webrtc::VideoSendStream::Stats stats;
4799 stats.bw_limited_resolution = true;
4800 stream->SetStats(stats);
4801
4802 cricket::VideoMediaInfo info;
4803 EXPECT_TRUE(channel_->GetStats(&info));
4804 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004805 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004806 info.senders[0].adapt_reason);
4807}
4808
Yves Gerey665174f2018-06-19 15:03:05 +02004809TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004810 FakeVideoSendStream* stream = AddSendStream();
4811 webrtc::VideoSendStream::Stats stats;
4812 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4813 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4814 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4815
4816 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4817 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4818 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4819
4820 stream->SetStats(stats);
4821
4822 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004823 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004824 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4825 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4826 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4827}
4828
eladalonf1841382017-06-12 01:16:46 -07004829TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004830 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4831 FakeVideoReceiveStream* stream = AddRecvStream();
4832 webrtc::VideoReceiveStream::Stats stats;
4833 stats.rtcp_packet_type_counts.fir_packets = 2;
4834 stats.rtcp_packet_type_counts.nack_packets = 3;
4835 stats.rtcp_packet_type_counts.pli_packets = 4;
4836 stream->SetStats(stats);
4837
4838 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004839 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004840 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004841 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004842 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004843 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004844 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004845 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004846}
4847
eladalonf1841382017-06-12 01:16:46 -07004848TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004849 FakeVideoReceiveStream* stream = AddRecvStream();
4850 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004851 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004852 stats.decode_ms = 2;
4853 stats.max_decode_ms = 3;
4854 stats.current_delay_ms = 4;
4855 stats.target_delay_ms = 5;
4856 stats.jitter_buffer_ms = 6;
4857 stats.min_playout_delay_ms = 7;
4858 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07004859 stats.width = 9;
4860 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08004861 stats.frame_counts.key_frames = 11;
4862 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08004863 stats.frames_rendered = 13;
4864 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01004865 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004866 stream->SetStats(stats);
4867
4868 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004869 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01004870 EXPECT_EQ(stats.decoder_implementation_name,
4871 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004872 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
4873 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
4874 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
4875 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
4876 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
4877 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
4878 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07004879 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
4880 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004881 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
4882 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08004883 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08004884 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07004885 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08004886 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004887}
4888
eladalonf1841382017-06-12 01:16:46 -07004889TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02004890 FakeVideoReceiveStream* stream = AddRecvStream();
4891 webrtc::VideoReceiveStream::Stats stats;
4892 stats.rtp_stats.transmitted.payload_bytes = 2;
4893 stats.rtp_stats.transmitted.header_bytes = 3;
4894 stats.rtp_stats.transmitted.padding_bytes = 4;
4895 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07004896 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02004897 stats.rtcp_stats.fraction_lost = 7;
4898 stream->SetStats(stats);
4899
4900 cricket::VideoMediaInfo info;
4901 ASSERT_TRUE(channel_->GetStats(&info));
4902 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
4903 stats.rtp_stats.transmitted.header_bytes +
4904 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004905 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02004906 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004907 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07004908 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004909 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02004910 info.receivers[0].fraction_lost);
4911}
4912
eladalonf1841382017-06-12 01:16:46 -07004913TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004914 AddSendStream();
4915 AddSendStream();
4916 webrtc::Call::Stats stats;
4917 stats.rtt_ms = 123;
4918 fake_call_->SetStats(stats);
4919
4920 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004921 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004922 ASSERT_EQ(2u, info.senders.size());
4923 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
4924 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
4925}
4926
eladalonf1841382017-06-12 01:16:46 -07004927TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004928 FakeVideoSendStream* stream = AddSendStream();
4929 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004930 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004931 stats.media_bitrate_bps = 123;
4932 stats.substreams[17].total_bitrate_bps = 1;
4933 stats.substreams[17].retransmit_bitrate_bps = 2;
4934 stats.substreams[42].total_bitrate_bps = 3;
4935 stats.substreams[42].retransmit_bitrate_bps = 4;
4936 stream->SetStats(stats);
4937
4938 FakeVideoSendStream* stream2 = AddSendStream();
4939 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004940 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004941 stats2.media_bitrate_bps = 321;
4942 stats2.substreams[13].total_bitrate_bps = 5;
4943 stats2.substreams[13].retransmit_bitrate_bps = 6;
4944 stats2.substreams[21].total_bitrate_bps = 7;
4945 stats2.substreams[21].retransmit_bitrate_bps = 8;
4946 stream2->SetStats(stats2);
4947
4948 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004949 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004950 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07004951 BandwidthEstimationInfo bwe_info;
4952 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004953 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
4954 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
4955 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
4956 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004957 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004958 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004959 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004960 bwe_info.actual_enc_bitrate);
4961 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004962 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07004963 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004964 << "Bandwidth stats should take all streams into account.";
4965}
4966
eladalonf1841382017-06-12 01:16:46 -07004967TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004968 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004969
Peter Boström0c4e06b2015-10-07 12:23:21 +02004970 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4971 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004972
4973 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4974 const size_t kDataLength = 12;
4975 uint8_t data[kDataLength];
4976 memset(data, 0, sizeof(data));
4977 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07004978 rtc::CopyOnWriteBuffer packet(data, kDataLength);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004979 rtc::PacketTime packet_time;
4980 channel_->OnPacketReceived(&packet, packet_time);
4981
4982 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
4983 << "No default receive stream created.";
4984 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08004985 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004986 << "Default receive stream should not have configured RTX";
4987
4988 EXPECT_TRUE(channel_->AddRecvStream(
4989 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
4990 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08004991 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004992 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07004993 EXPECT_FALSE(
4994 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07004995 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02004996 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07004997 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02004998 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07004999 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08005000 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005001}
5002
eladalonf1841382017-06-12 01:16:46 -07005003TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005004 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01005005
Peter Boström0c4e06b2015-10-07 12:23:21 +02005006 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5007 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01005008
5009 StreamParams sp =
5010 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5011 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
5012
5013 EXPECT_FALSE(channel_->AddSendStream(sp));
5014 EXPECT_FALSE(channel_->AddRecvStream(sp));
5015}
5016
eladalonf1841382017-06-12 01:16:46 -07005017TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005018 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005019
Peter Boström0c4e06b2015-10-07 12:23:21 +02005020 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5021 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005022
5023 StreamParams sp =
5024 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5025
5026 EXPECT_TRUE(channel_->AddSendStream(sp));
5027 EXPECT_TRUE(channel_->AddRecvStream(sp));
5028
5029 // The RTX SSRC is already used in previous streams, using it should fail.
5030 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5031 EXPECT_FALSE(channel_->AddSendStream(sp));
5032 EXPECT_FALSE(channel_->AddRecvStream(sp));
5033
5034 // After removing the original stream this should be fine to add (makes sure
5035 // that RTX ssrcs are not forever taken).
5036 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5037 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5038 EXPECT_TRUE(channel_->AddSendStream(sp));
5039 EXPECT_TRUE(channel_->AddRecvStream(sp));
5040}
5041
eladalonf1841382017-06-12 01:16:46 -07005042TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005043 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005044 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5045 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005046 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005047
Peter Boströmd6f4c252015-03-26 16:23:04 +01005048 StreamParams sp =
5049 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5050
5051 EXPECT_TRUE(channel_->AddSendStream(sp));
5052 EXPECT_TRUE(channel_->AddRecvStream(sp));
5053
5054 // One of the SSRCs is already used in previous streams, using it should fail.
5055 sp = cricket::CreateSimStreamParams("cname",
5056 MAKE_VECTOR(kOverlappingStreamSsrcs));
5057 EXPECT_FALSE(channel_->AddSendStream(sp));
5058 EXPECT_FALSE(channel_->AddRecvStream(sp));
5059
5060 // After removing the original stream this should be fine to add (makes sure
5061 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005062 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5063 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005064 EXPECT_TRUE(channel_->AddSendStream(sp));
5065 EXPECT_TRUE(channel_->AddRecvStream(sp));
5066}
5067
eladalonf1841382017-06-12 01:16:46 -07005068TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005069 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005070
5071 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5072 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5073
5074 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5075 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5076
5077 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5078
5079 static const uint32_t kReceiverSsrcs[] = {3};
5080 static const uint32_t kReceiverRtxSsrcs[] = {2};
5081
5082 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5083 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5084 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5085
5086 cricket::VideoMediaInfo info;
5087 ASSERT_TRUE(channel_->GetStats(&info));
5088
5089 ASSERT_EQ(1u, info.senders.size());
5090 ASSERT_EQ(1u, info.receivers.size());
5091
5092 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5093 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5094 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5095}
5096
eladalonf1841382017-06-12 01:16:46 -07005097TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005098 FakeVideoReceiveStream* stream = AddRecvStream();
5099 webrtc::VideoReceiveStream::Stats stats;
5100 cricket::VideoMediaInfo info;
5101
5102 // Report no codec name before receiving.
5103 stream->SetStats(stats);
5104 ASSERT_TRUE(channel_->GetStats(&info));
5105 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5106
5107 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005108 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005109 stream->SetStats(stats);
5110 ASSERT_TRUE(channel_->GetStats(&info));
5111 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5112
5113 // Report no codec name for unknown playload types.
5114 stats.current_payload_type = 3;
5115 stream->SetStats(stats);
5116 ASSERT_TRUE(channel_->GetStats(&info));
5117 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5118}
5119
Seth Hampson5897a6e2018-04-03 11:16:33 -07005120// Tests that when we add a stream without SSRCs, but contains a stream_id
5121// that it is stored and its stream id is later used when the first packet
5122// arrives to properly create a receive stream with a sync label.
5123TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5124 const char kSyncLabel[] = "sync_label";
5125 cricket::StreamParams unsignaled_stream;
5126 unsignaled_stream.set_stream_ids({kSyncLabel});
5127 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5128 // The stream shouldn't have been created at this point because it doesn't
5129 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005130 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005131
5132 // Create and deliver packet.
5133 const size_t kDataLength = 12;
5134 uint8_t data[kDataLength];
5135 memset(data, 0, sizeof(data));
5136 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5137 rtc::CopyOnWriteBuffer packet(data, kDataLength);
5138 rtc::PacketTime packet_time;
5139 channel_->OnPacketReceived(&packet, packet_time);
5140
5141 // The stream should now be created with the appropriate sync label.
5142 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5143 EXPECT_EQ(kSyncLabel,
5144 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5145
5146 // Removing the unsignaled stream should clear the cache. This time when
5147 // a default video receive stream is created it won't have a sync_group.
5148 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5149 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5150 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5151
5152 channel_->OnPacketReceived(&packet, packet_time);
5153 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5154 EXPECT_TRUE(
5155 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5156}
5157
eladalonf1841382017-06-12 01:16:46 -07005158void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005159 uint8_t payload_type,
5160 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005161 // kRedRtxPayloadType must currently be unused.
5162 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5163
noahricd10a68e2015-07-10 11:27:55 -07005164 // Add a RED RTX codec.
5165 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005166 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005167 recv_parameters_.codecs.push_back(red_rtx_codec);
5168 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005169
5170 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5171 const size_t kDataLength = 12;
5172 uint8_t data[kDataLength];
5173 memset(data, 0, sizeof(data));
5174
5175 rtc::Set8(data, 1, payload_type);
5176 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005177 rtc::CopyOnWriteBuffer packet(data, kDataLength);
noahricd10a68e2015-07-10 11:27:55 -07005178 rtc::PacketTime packet_time;
5179 channel_->OnPacketReceived(&packet, packet_time);
5180
5181 if (expect_created_receive_stream) {
5182 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5183 << "Should have created a receive stream for payload type: "
5184 << payload_type;
5185 } else {
5186 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5187 << "Shouldn't have created a receive stream for payload type: "
5188 << payload_type;
5189 }
5190}
5191
eladalonf1841382017-06-12 01:16:46 -07005192TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005193 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5194 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005195}
5196
eladalonf1841382017-06-12 01:16:46 -07005197TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005198 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5199 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005200}
5201
eladalonf1841382017-06-12 01:16:46 -07005202TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005203 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005204 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5205 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5206 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5207 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005208}
5209
eladalonf1841382017-06-12 01:16:46 -07005210TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005211 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5212 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005213}
5214
eladalonf1841382017-06-12 01:16:46 -07005215TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005216 FlexfecPacketDoesntCreateUnsignalledStream) {
5217 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5218 false /* expect_created_receive_stream */);
5219}
5220
eladalonf1841382017-06-12 01:16:46 -07005221TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005222 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5223 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005224}
5225
mzanaty8a855d62017-02-17 15:46:43 -08005226// Test that receiving any unsignalled SSRC works even if it changes.
5227// The first unsignalled SSRC received will create a default receive stream.
5228// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005229TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005230 // Allow receiving VP8, VP9, H264 (if enabled).
5231 cricket::VideoRecvParameters parameters;
5232 parameters.codecs.push_back(GetEngineCodec("VP8"));
5233 parameters.codecs.push_back(GetEngineCodec("VP9"));
5234
5235#if defined(WEBRTC_USE_H264)
5236 cricket::VideoCodec H264codec(126, "H264");
5237 parameters.codecs.push_back(H264codec);
5238#endif
5239
5240 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5241 // No receive streams yet.
5242 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5243 cricket::FakeVideoRenderer renderer;
5244 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5245
5246 // Receive VP8 packet on first SSRC.
5247 uint8_t data[kMinRtpPacketLen];
5248 cricket::RtpHeader rtpHeader;
5249 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5250 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005251 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005252 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5253 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5254 rtc::PacketTime packet_time;
5255 channel_->OnPacketReceived(&packet, packet_time);
5256 // VP8 packet should create default receive stream.
5257 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005258 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005259 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5260 // Verify that the receive stream sinks to a renderer.
5261 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4), 100, 0,
5262 webrtc::kVideoRotation_0);
5263 recv_stream->InjectFrame(video_frame);
5264 EXPECT_EQ(1, renderer.num_rendered_frames());
5265
5266 // Receive VP9 packet on second SSRC.
5267 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005268 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005269 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5270 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
5271 channel_->OnPacketReceived(&packet2, packet_time);
5272 // VP9 packet should replace the default receive SSRC.
5273 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5274 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5275 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5276 // Verify that the receive stream sinks to a renderer.
5277 webrtc::VideoFrame video_frame2(CreateBlackFrameBuffer(4, 4), 200, 0,
ilnik00d802b2017-04-11 10:34:31 -07005278 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005279 recv_stream->InjectFrame(video_frame2);
5280 EXPECT_EQ(2, renderer.num_rendered_frames());
5281
5282#if defined(WEBRTC_USE_H264)
5283 // Receive H264 packet on third SSRC.
5284 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005285 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005286 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5287 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
5288 channel_->OnPacketReceived(&packet3, packet_time);
5289 // H264 packet should replace the default receive SSRC.
5290 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5291 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5292 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5293 // Verify that the receive stream sinks to a renderer.
5294 webrtc::VideoFrame video_frame3(CreateBlackFrameBuffer(4, 4), 300, 0,
ilnik00d802b2017-04-11 10:34:31 -07005295 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005296 recv_stream->InjectFrame(video_frame3);
5297 EXPECT_EQ(3, renderer.num_rendered_frames());
5298#endif
5299}
5300
brandtr0dc57ea2017-05-29 23:33:31 -07005301// This test verifies that when a new default stream is created for a new
5302// unsignaled SSRC, the new stream does not overwrite any old stream that had
5303// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005304TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005305 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5306 cricket::VideoRecvParameters parameters;
5307 parameters.codecs.push_back(GetEngineCodec("VP8"));
5308 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5309
5310 // No streams signaled and no packets received, so we should not have any
5311 // stream objects created yet.
5312 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5313
5314 // Receive packet on an unsignaled SSRC.
5315 uint8_t data[kMinRtpPacketLen];
5316 cricket::RtpHeader rtp_header;
5317 rtp_header.payload_type = GetEngineCodec("VP8").id;
5318 rtp_header.seq_num = rtp_header.timestamp = 0;
5319 rtp_header.ssrc = kSsrcs3[0];
5320 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5321 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5322 rtc::PacketTime packet_time;
5323 channel_->OnPacketReceived(&packet, packet_time);
5324 // Default receive stream should be created.
5325 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5326 FakeVideoReceiveStream* recv_stream0 =
5327 fake_call_->GetVideoReceiveStreams()[0];
5328 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5329
5330 // Signal the SSRC.
5331 EXPECT_TRUE(
5332 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5333 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5334 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5335 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5336
5337 // Receive packet on a different unsignaled SSRC.
5338 rtp_header.ssrc = kSsrcs3[1];
5339 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5340 packet.SetData(data, sizeof(data));
5341 channel_->OnPacketReceived(&packet, packet_time);
5342 // New default receive stream should be created, but old stream should remain.
5343 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5344 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5345 FakeVideoReceiveStream* recv_stream1 =
5346 fake_call_->GetVideoReceiveStreams()[1];
5347 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5348}
5349
Seth Hampson7c682e02018-05-04 16:28:15 -07005350TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005351 AddSendStream();
5352
Tommi85959932018-02-07 19:26:06 +01005353 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02005354 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
skvladdc1c62c2016-03-16 19:07:43 -07005355 cricket::VideoFormat capture_format_hd =
5356 capturer.GetSupportedFormats()->front();
5357 EXPECT_EQ(1280, capture_format_hd.width);
5358 EXPECT_EQ(720, capture_format_hd.height);
5359 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
5360 EXPECT_TRUE(channel_->SetSend(true));
perkjfa10b552016-10-02 23:45:26 -07005361 capturer.CaptureFrame();
skvladdc1c62c2016-03-16 19:07:43 -07005362
perkjfa10b552016-10-02 23:45:26 -07005363 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005364 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005365
5366 // TODO(skvlad): Resolve the inconsistency between the interpretation
5367 // of the global bitrate limit for audio and video:
5368 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5369 // max_bandwidth_bps = -1 - remove the bandwidth limit
5370 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005371 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005372
perkjfa10b552016-10-02 23:45:26 -07005373 SetAndExpectMaxBitrate(1000, 0, 1000);
5374 SetAndExpectMaxBitrate(1000, 800, 800);
5375 SetAndExpectMaxBitrate(600, 800, 600);
5376 SetAndExpectMaxBitrate(0, 800, 800);
5377 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005378
Niels Möllerff40b142018-04-09 08:49:14 +02005379 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005380}
5381
eladalonf1841382017-06-12 01:16:46 -07005382TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005383 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005384 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005385 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005386
5387 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005388 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005389 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005390}
5391
eladalonf1841382017-06-12 01:16:46 -07005392TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005393 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005394 FakeVideoSendStream* stream = AddSendStream();
5395
Seth Hampson7c682e02018-05-04 16:28:15 -07005396 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5397 EXPECT_EQ(1UL, parameters.encodings.size());
5398 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5399 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5400
5401 // Note that this is testing the behavior of the FakeVideoSendStream, which
5402 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5403 // we are just testing the behavior of
5404 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005405 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5406 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005407
5408 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5409 // by this amount.
5410 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5411 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5412 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5413 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5414
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005415 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5416 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5417 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5418}
5419
5420TEST_F(WebRtcVideoChannelTest,
5421 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5422 FakeVideoSendStream* stream = AddSendStream();
5423
5424 // Note that this is testing the behavior of the FakeVideoSendStream, which
5425 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5426 // we are just testing the behavior of
5427 // EncoderStreamFactory::CreateEncoderStreams.
5428 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5429 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5430
5431 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5432 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5433 EXPECT_EQ(1UL, parameters.encodings.size());
5434 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5435 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5436
5437 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5438 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5439 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5440}
5441
5442TEST_F(WebRtcVideoChannelTest,
5443 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5444 send_parameters_.max_bandwidth_bps = 99999;
5445 FakeVideoSendStream* stream = AddSendStream();
5446 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5447 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5448 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5449 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5450 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5451 stream->GetVideoStreams()[0].max_bitrate_bps);
5452
5453 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5454 // adjusted down.
5455 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5456 EXPECT_EQ(1UL, parameters.encodings.size());
5457 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5458 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5459 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5460 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5461 stream->GetVideoStreams()[0].min_bitrate_bps);
5462 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5463 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005464}
5465
Åsa Persson8c1bf952018-09-13 10:42:19 +02005466TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5467 FakeVideoSendStream* stream = AddSendStream();
5468
5469 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5470 EXPECT_EQ(1UL, parameters.encodings.size());
5471 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5472 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5473
5474 // Note that this is testing the behavior of the FakeVideoSendStream, which
5475 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5476 // we are just testing the behavior of
5477 // EncoderStreamFactory::CreateEncoderStreams.
5478 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5479 EXPECT_EQ(kDefaultVideoMaxFramerate,
5480 stream->GetVideoStreams()[0].max_framerate);
5481
5482 // Set max framerate and check that VideoStream.max_framerate is set.
5483 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5484 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5485 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5486 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5487
5488 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5489 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5490}
5491
Åsa Persson23eba222018-10-02 14:47:06 +02005492TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5493 FakeVideoSendStream* stream = AddSendStream();
5494
5495 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5496 EXPECT_EQ(1UL, parameters.encodings.size());
5497 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5498 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5499
5500 // Note that this is testing the behavior of the FakeVideoSendStream, which
5501 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5502 // we are just testing the behavior of
5503 // EncoderStreamFactory::CreateEncoderStreams.
5504 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5505 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5506
5507 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5508 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5509 parameters.encodings[0].num_temporal_layers = 2;
5510 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5511
5512 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5513 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5514}
5515
Seth Hampson7c682e02018-05-04 16:28:15 -07005516TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005517 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005518 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005519 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005520 // Two or more encodings should result in failure.
5521 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005522 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005523 // Zero encodings should also fail.
5524 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005525 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005526}
5527
Zach Stein3ca452b2018-01-18 10:01:24 -08005528TEST_F(WebRtcVideoChannelTest,
5529 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5530 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5531 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5532 AddSendStream(sp);
5533
5534 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5535
5536 // Additional encodings should result in failure.
5537 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005538 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005539 // Zero encodings should also fail.
5540 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005541 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005542}
5543
deadbeeffb2aced2017-01-06 23:05:37 -08005544// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005545TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005546 AddSendStream();
5547 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005548 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005549 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005550}
5551
Seth Hampson24722b32017-12-22 09:36:42 -08005552// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5553// a value <= 0, setting the parameters returns false.
5554TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5555 AddSendStream();
5556 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5557 EXPECT_EQ(1UL, parameters.encodings.size());
5558 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5559 parameters.encodings[0].bitrate_priority);
5560
5561 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005562 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005563 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005564 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005565}
5566
5567// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5568// properly on the VideoChannel and propogates down to the video encoder.
5569TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5570 AddSendStream();
5571 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5572 EXPECT_EQ(1UL, parameters.encodings.size());
5573 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5574 parameters.encodings[0].bitrate_priority);
5575
5576 // Change the value and set it on the VideoChannel.
5577 double new_bitrate_priority = 2.0;
5578 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005579 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005580
5581 // Verify that the encoding parameters bitrate_priority is set for the
5582 // VideoChannel.
5583 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5584 EXPECT_EQ(1UL, parameters.encodings.size());
5585 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5586
5587 // Verify that the new value propagated down to the encoder.
5588 std::vector<FakeVideoSendStream*> video_send_streams =
5589 fake_call_->GetVideoSendStreams();
5590 EXPECT_EQ(1UL, video_send_streams.size());
5591 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5592 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5593 // appropriately.
5594 EXPECT_EQ(new_bitrate_priority,
5595 video_send_stream->GetEncoderConfig().bitrate_priority);
5596 // Check that the vector of VideoStreams also was propagated correctly. Note
5597 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5598 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005599 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005600 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5601}
5602
5603// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5604// VideoChannel and the value propogates to the video encoder with all simulcast
5605// streams.
5606TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5607 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005608 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005609 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5610 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5611 AddSendStream(stream_params);
5612 uint32_t primary_ssrc = stream_params.first_ssrc();
5613
Tommi85959932018-02-07 19:26:06 +01005614 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
5615 // frame. This creates multiple VideoStreams for all simulcast layers when
5616 // reconfiguring, and allows us to test this behavior.
5617 FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson24722b32017-12-22 09:36:42 -08005618 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02005619 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson24722b32017-12-22 09:36:42 -08005620 EXPECT_EQ(cricket::CS_RUNNING,
5621 capturer.Start(cricket::VideoFormat(
5622 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
5623 cricket::FOURCC_I420)));
5624 channel_->SetSend(true);
5625 EXPECT_TRUE(capturer.CaptureFrame());
5626 // Get and set the rtp encoding parameters.
5627 webrtc::RtpParameters parameters =
5628 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005629 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005630 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5631 parameters.encodings[0].bitrate_priority);
5632 // Change the value and set it on the VideoChannel.
5633 double new_bitrate_priority = 2.0;
5634 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005635 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005636
5637 // Verify that the encoding parameters priority is set on the VideoChannel.
5638 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005639 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005640 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5641
5642 // Verify that the new value propagated down to the encoder.
5643 std::vector<FakeVideoSendStream*> video_send_streams =
5644 fake_call_->GetVideoSendStreams();
5645 EXPECT_EQ(1UL, video_send_streams.size());
5646 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5647 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5648 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005649 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005650 video_send_stream->GetEncoderConfig().number_of_streams);
5651 EXPECT_EQ(new_bitrate_priority,
5652 video_send_stream->GetEncoderConfig().bitrate_priority);
5653 // Check that the vector of VideoStreams also propagated correctly. The
5654 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5655 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005656 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005657 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005658 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5659 // Since we are only setting bitrate priority per-sender, the other
5660 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005661 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005662 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005663 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005664 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005665 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005666}
5667
Åsa Persson8c1bf952018-09-13 10:42:19 +02005668TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
5669 const size_t kNumSimulcastStreams = 3;
5670 SetUpSimulcast(true, false);
5671
5672 // Get and set the rtp encoding parameters.
5673 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5674 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5675 for (const auto& encoding : parameters.encodings) {
5676 EXPECT_FALSE(encoding.max_framerate);
5677 }
5678
5679 // Change the value and set it on the VideoChannel.
5680 parameters.encodings[0].max_framerate = 10;
5681 parameters.encodings[1].max_framerate = 20;
5682 parameters.encodings[2].max_framerate = 25;
5683 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5684
5685 // Verify that the bitrates are set on the VideoChannel.
5686 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5687 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5688 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
5689 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
5690 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
5691}
5692
Åsa Persson23eba222018-10-02 14:47:06 +02005693TEST_F(WebRtcVideoChannelTest,
5694 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
5695 const size_t kNumSimulcastStreams = 3;
5696 SetUpSimulcast(true, false);
5697
5698 // Get and set the rtp encoding parameters.
5699 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5700 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5701
5702 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
5703 parameters.encodings[0].num_temporal_layers = 0;
5704 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5705 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5706 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
5707 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5708 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5709}
5710
5711TEST_F(WebRtcVideoChannelTest,
5712 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
5713 const size_t kNumSimulcastStreams = 3;
5714 SetUpSimulcast(true, false);
5715
5716 // Get and set the rtp encoding parameters.
5717 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5718 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5719
5720 // No/all layers should be set.
5721 parameters.encodings[0].num_temporal_layers = 1;
5722 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5723 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5724
5725 // Different values not supported.
5726 parameters.encodings[0].num_temporal_layers = 1;
5727 parameters.encodings[1].num_temporal_layers = 2;
5728 parameters.encodings[2].num_temporal_layers = 2;
5729 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5730 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5731}
5732
5733TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
5734 const size_t kNumSimulcastStreams = 3;
5735 SetUpSimulcast(true, false);
5736
5737 // Get and set the rtp encoding parameters.
5738 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5739 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5740 for (const auto& encoding : parameters.encodings)
5741 EXPECT_FALSE(encoding.num_temporal_layers);
5742
5743 // Change the value and set it on the VideoChannel.
5744 parameters.encodings[0].num_temporal_layers = 3;
5745 parameters.encodings[1].num_temporal_layers = 3;
5746 parameters.encodings[2].num_temporal_layers = 3;
5747 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5748
5749 // Verify that the number of temporal layers are set on the VideoChannel.
5750 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5751 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5752 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
5753 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
5754 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
5755}
5756
5757TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
5758 const size_t kNumSimulcastStreams = 3;
5759 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5760
5761 // Send a full size frame so all simulcast layers are used when reconfiguring.
5762 FakeVideoCapturerWithTaskQueue capturer;
5763 VideoOptions options;
5764 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5765 EXPECT_EQ(cricket::CS_RUNNING,
5766 capturer.Start(capturer.GetSupportedFormats()->front()));
5767 channel_->SetSend(true);
5768 EXPECT_TRUE(capturer.CaptureFrame());
5769
5770 // Get and set the rtp encoding parameters.
5771 // Change the value and set it on the VideoChannel.
5772 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5773 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5774 parameters.encodings[0].num_temporal_layers = 2;
5775 parameters.encodings[1].num_temporal_layers = 2;
5776 parameters.encodings[2].num_temporal_layers = 2;
5777 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5778
5779 // Verify that the new value is propagated down to the encoder.
5780 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5781 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5782 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5783 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5784 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5785 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
5786 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
5787 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
5788
5789 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5790 // VideoStreams are created appropriately for the simulcast case.
5791 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5792 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5793 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
5794 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
5795
5796 // No parameter changed, encoder should not be reconfigured.
5797 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5798 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5799
5800 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5801}
5802
5803TEST_F(WebRtcVideoChannelTest,
5804 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
5805 const size_t kDefaultNumTemporalLayers = 3;
5806 const size_t kNumSimulcastStreams = 3;
5807 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5808
5809 // Send a full size frame so all simulcast layers are used when reconfiguring.
5810 FakeVideoCapturerWithTaskQueue capturer;
5811 VideoOptions options;
5812 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5813 EXPECT_EQ(cricket::CS_RUNNING,
5814 capturer.Start(capturer.GetSupportedFormats()->front()));
5815 channel_->SetSend(true);
5816 EXPECT_TRUE(capturer.CaptureFrame());
5817
5818 // Change rtp encoding parameters, num_temporal_layers not changed.
5819 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5820 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5821 parameters.encodings[0].min_bitrate_bps = 33000;
5822 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5823
5824 // Verify that no value is propagated down to the encoder.
5825 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5826 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5827 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5828 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
5829 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
5830 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
5831
5832 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5833 // VideoStreams are created appropriately for the simulcast case.
5834 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5835 EXPECT_EQ(kDefaultNumTemporalLayers,
5836 stream->GetVideoStreams()[0].num_temporal_layers);
5837 EXPECT_EQ(kDefaultNumTemporalLayers,
5838 stream->GetVideoStreams()[1].num_temporal_layers);
5839 EXPECT_EQ(kDefaultNumTemporalLayers,
5840 stream->GetVideoStreams()[2].num_temporal_layers);
5841
5842 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5843}
5844
Åsa Persson8c1bf952018-09-13 10:42:19 +02005845TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
5846 const size_t kNumSimulcastStreams = 3;
5847 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5848
5849 // Send a full size frame so all simulcast layers are used when reconfiguring.
5850 FakeVideoCapturerWithTaskQueue capturer;
5851 VideoOptions options;
5852 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5853 EXPECT_EQ(cricket::CS_RUNNING,
5854 capturer.Start(capturer.GetSupportedFormats()->front()));
5855 channel_->SetSend(true);
5856 EXPECT_TRUE(capturer.CaptureFrame());
5857
5858 // Get and set the rtp encoding parameters.
5859 // Change the value and set it on the VideoChannel.
5860 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5861 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5862 parameters.encodings[0].max_framerate = 15;
5863 parameters.encodings[1].max_framerate = 25;
5864 parameters.encodings[2].max_framerate = 20;
5865 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5866
5867 // Verify that the new value propagated down to the encoder.
5868 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5869 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5870 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5871 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5872 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5873 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5874 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
5875 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5876
5877 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5878 // VideoStreams are created appropriately for the simulcast case.
5879 // Currently the maximum |max_framerate| is used.
5880 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5881 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
5882 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
5883 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
5884
5885 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5886}
5887
5888TEST_F(WebRtcVideoChannelTest,
5889 DefaultValuePropagatedToEncoderForUnsetFramerate) {
5890 const size_t kNumSimulcastStreams = 3;
5891 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5892 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5893
5894 // Send a full size frame so all simulcast layers are used when reconfiguring.
5895 FakeVideoCapturerWithTaskQueue capturer;
5896 VideoOptions options;
5897 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5898 EXPECT_EQ(cricket::CS_RUNNING,
5899 capturer.Start(capturer.GetSupportedFormats()->front()));
5900 channel_->SetSend(true);
5901 EXPECT_TRUE(capturer.CaptureFrame());
5902
5903 // Get and set the rtp encoding parameters.
5904 // Change the value and set it on the VideoChannel.
5905 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5906 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5907 parameters.encodings[0].max_framerate = 15;
5908 parameters.encodings[2].max_framerate = 20;
5909 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5910
5911 // Verify that the new value propagated down to the encoder.
5912 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5913 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5914 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5915 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5916 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5917 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
5918 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5919
5920 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5921 // VideoStreams are created appropriately for the simulcast case.
5922 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
5923 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5924 EXPECT_EQ(kDefaultVideoMaxFramerate,
5925 stream->GetVideoStreams()[0].max_framerate);
5926 EXPECT_EQ(kDefaultVideoMaxFramerate,
5927 stream->GetVideoStreams()[1].max_framerate);
5928 EXPECT_EQ(kDefaultVideoMaxFramerate,
5929 stream->GetVideoStreams()[2].max_framerate);
5930
5931 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5932}
5933
Åsa Persson55659812018-06-18 17:51:32 +02005934TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
5935 const size_t kNumSimulcastStreams = 3;
5936 SetUpSimulcast(true, false);
5937
5938 // Get and set the rtp encoding parameters.
5939 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5940 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5941 for (const auto& encoding : parameters.encodings) {
5942 EXPECT_FALSE(encoding.min_bitrate_bps);
5943 EXPECT_FALSE(encoding.max_bitrate_bps);
5944 }
5945
5946 // Change the value and set it on the VideoChannel.
5947 parameters.encodings[0].min_bitrate_bps = 100000;
5948 parameters.encodings[0].max_bitrate_bps = 200000;
5949 parameters.encodings[1].min_bitrate_bps = 300000;
5950 parameters.encodings[1].max_bitrate_bps = 400000;
5951 parameters.encodings[2].min_bitrate_bps = 500000;
5952 parameters.encodings[2].max_bitrate_bps = 600000;
5953 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5954
5955 // Verify that the bitrates are set on the VideoChannel.
5956 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5957 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5958 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
5959 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
5960 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
5961 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
5962 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
5963 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
5964}
5965
5966TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
5967 const size_t kNumSimulcastStreams = 3;
5968 SetUpSimulcast(true, false);
5969
5970 // Get and set the rtp encoding parameters.
5971 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5972 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5973
5974 // Max bitrate lower than min bitrate should fail.
5975 parameters.encodings[2].min_bitrate_bps = 100000;
5976 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
5977 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5978 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5979}
5980
5981// Test that min and max bitrate values set via RtpParameters are correctly
5982// propagated to the underlying encoder, and that the target is set to 3/4 of
5983// the maximum (3/4 was chosen because it's similar to the simulcast defaults
5984// that are used if no min/max are specified).
5985TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
5986 const size_t kNumSimulcastStreams = 3;
5987 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5988
5989 // Send a full size frame so all simulcast layers are used when reconfiguring.
5990 FakeVideoCapturerWithTaskQueue capturer;
5991 VideoOptions options;
5992 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5993 EXPECT_EQ(cricket::CS_RUNNING,
5994 capturer.Start(capturer.GetSupportedFormats()->front()));
5995 channel_->SetSend(true);
5996 EXPECT_TRUE(capturer.CaptureFrame());
5997
5998 // Get and set the rtp encoding parameters.
5999 // Change the value and set it on the VideoChannel.
6000 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6001 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6002 parameters.encodings[0].min_bitrate_bps = 100000;
6003 parameters.encodings[0].max_bitrate_bps = 200000;
6004 parameters.encodings[1].min_bitrate_bps = 300000;
6005 parameters.encodings[1].max_bitrate_bps = 400000;
6006 parameters.encodings[2].min_bitrate_bps = 500000;
6007 parameters.encodings[2].max_bitrate_bps = 600000;
6008 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6009
6010 // Verify that the new value propagated down to the encoder.
6011 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6012 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6013 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6014 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6015 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6016 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6017 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6018 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6019 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6020 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6021 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6022
6023 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6024 // VideoStreams are created appropriately for the simulcast case.
6025 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6026 // Target bitrate: 200000 * 3 / 4 = 150000.
6027 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6028 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6029 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6030 // Target bitrate: 400000 * 3 / 4 = 300000.
6031 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6032 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6033 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6034 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6035 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6036 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6037 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6038
6039 // No parameter changed, encoder should not be reconfigured.
6040 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6041 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6042
6043 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6044}
6045
6046// Test to only specify the min or max bitrate value for a layer via
6047// RtpParameters. The unspecified min/max and target value should be set to the
6048// simulcast default that is used if no min/max are specified.
6049TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6050 const size_t kNumSimulcastStreams = 3;
6051 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6052 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6053
6054 // Send a full size frame so all simulcast layers are used when reconfiguring.
6055 FakeVideoCapturerWithTaskQueue capturer;
6056 VideoOptions options;
6057 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6058 EXPECT_EQ(cricket::CS_RUNNING,
6059 capturer.Start(capturer.GetSupportedFormats()->front()));
6060 channel_->SetSend(true);
6061 EXPECT_TRUE(capturer.CaptureFrame());
6062
6063 // Get and set the rtp encoding parameters.
6064 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6065 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6066
6067 // Change the value and set it on the VideoChannel.
6068 // Layer 0: only configure min bitrate.
6069 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6070 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6071 // Layer 1: only configure max bitrate.
6072 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6073 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6074 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6075
6076 // Verify that the new value propagated down to the encoder.
6077 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6078 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6079 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6080 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6081 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6082 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6083 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6084 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6085 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6086 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6087
6088 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6089 // VideoStreams are created appropriately for the simulcast case.
6090 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6091 // Layer 0: min configured bitrate should overwrite min default.
6092 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6093 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6094 stream->GetVideoStreams()[0].target_bitrate_bps);
6095 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6096 stream->GetVideoStreams()[0].max_bitrate_bps);
6097 // Layer 1: max configured bitrate should overwrite max default.
6098 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6099 stream->GetVideoStreams()[1].min_bitrate_bps);
6100 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6101 stream->GetVideoStreams()[1].target_bitrate_bps);
6102 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6103 // Layer 2: min and max bitrate not configured, default expected.
6104 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6105 stream->GetVideoStreams()[2].min_bitrate_bps);
6106 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6107 stream->GetVideoStreams()[2].target_bitrate_bps);
6108 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6109 stream->GetVideoStreams()[2].max_bitrate_bps);
6110
6111 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6112}
6113
6114// Test that specifying the min (or max) bitrate value for a layer via
6115// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6116// unspecified values accordingly.
6117TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6118 const size_t kNumSimulcastStreams = 3;
6119 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6120 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6121
6122 // Send a full size frame so all simulcast layers are used when reconfiguring.
6123 FakeVideoCapturerWithTaskQueue capturer;
6124 VideoOptions options;
6125 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6126 EXPECT_EQ(cricket::CS_RUNNING,
6127 capturer.Start(capturer.GetSupportedFormats()->front()));
6128 channel_->SetSend(true);
6129 EXPECT_TRUE(capturer.CaptureFrame());
6130
6131 // Get and set the rtp encoding parameters.
6132 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6133 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6134
6135 // Change the value and set it on the VideoChannel.
6136 // For layer 0, set the min bitrate above the default max.
6137 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6138 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6139 // For layer 1, set the max bitrate below the default min.
6140 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6141 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6142 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6143
6144 // Verify that the new value propagated down to the encoder.
6145 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6146 // VideoStreams are created appropriately for the simulcast case.
6147 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6148 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6149 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6150 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6151 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6152 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6153 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6154 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6155 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6156 // Layer 2: min and max bitrate not configured, default expected.
6157 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6158 stream->GetVideoStreams()[2].min_bitrate_bps);
6159 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6160 stream->GetVideoStreams()[2].target_bitrate_bps);
6161 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6162 stream->GetVideoStreams()[2].max_bitrate_bps);
6163
6164 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6165}
6166
6167TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6168 const size_t kNumSimulcastStreams = 3;
6169 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6170 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6171
6172 // Send a full size frame so all simulcast layers are used when reconfiguring.
6173 FakeVideoCapturerWithTaskQueue capturer;
6174 VideoOptions options;
6175 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6176 EXPECT_EQ(cricket::CS_RUNNING,
6177 capturer.Start(capturer.GetSupportedFormats()->front()));
6178 channel_->SetSend(true);
6179 EXPECT_TRUE(capturer.CaptureFrame());
6180
6181 // Set max bitrate for all but the highest layer.
6182 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6183 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6184 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6185 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6186 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6187
6188 // Set max bandwidth equal to total max bitrate.
6189 send_parameters_.max_bandwidth_bps =
6190 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6191 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6192 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6193
6194 // No bitrate above the total max to give to the highest layer.
6195 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6196 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6197 stream->GetVideoStreams()[2].max_bitrate_bps);
6198
6199 // Set max bandwidth above the total max bitrate.
6200 send_parameters_.max_bandwidth_bps =
6201 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6202 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6203 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6204
6205 // The highest layer has no max bitrate set -> the bitrate above the total
6206 // max should be given to the highest layer.
6207 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6208 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6209 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6210 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6211 stream->GetVideoStreams()[2].max_bitrate_bps);
6212
6213 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6214}
6215
6216TEST_F(WebRtcVideoChannelTest,
6217 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6218 const size_t kNumSimulcastStreams = 3;
6219 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6220 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6221 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6222
6223 // Send a full size frame so all simulcast layers are used when reconfiguring.
6224 FakeVideoCapturerWithTaskQueue capturer;
6225 VideoOptions options;
6226 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6227 EXPECT_EQ(cricket::CS_RUNNING,
6228 capturer.Start(capturer.GetSupportedFormats()->front()));
6229 channel_->SetSend(true);
6230 EXPECT_TRUE(capturer.CaptureFrame());
6231
6232 // Set max bitrate for the highest layer.
6233 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6234 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6235 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6236 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6237
6238 // Set max bandwidth above the total max bitrate.
6239 send_parameters_.max_bandwidth_bps =
6240 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6241 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6242 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6243
6244 // The highest layer has the max bitrate set -> the bitrate above the total
6245 // max should not be given to the highest layer.
6246 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6247 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6248 stream->GetVideoStreams()[2].max_bitrate_bps);
6249
6250 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6251}
6252
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006253// Test that min and max bitrate values set via RtpParameters are correctly
6254// propagated to the underlying encoder for a single stream.
6255TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6256 FakeVideoSendStream* stream = AddSendStream();
6257 EXPECT_TRUE(channel_->SetSend(true));
6258 EXPECT_TRUE(stream->IsSending());
6259
6260 // Set min and max bitrate.
6261 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6262 EXPECT_EQ(1u, parameters.encodings.size());
6263 parameters.encodings[0].min_bitrate_bps = 80000;
6264 parameters.encodings[0].max_bitrate_bps = 150000;
6265 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6266
6267 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6268 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6269 EXPECT_EQ(1u, encoder_config.number_of_streams);
6270 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6271 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6272 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6273
6274 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6275 // VideoStreams are created appropriately.
6276 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6277 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6278 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6279 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6280}
6281
6282// Test the default min and max bitrate value are correctly propagated to the
6283// underlying encoder for a single stream (when the values are not set via
6284// RtpParameters).
6285TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6286 FakeVideoSendStream* stream = AddSendStream();
6287 EXPECT_TRUE(channel_->SetSend(true));
6288 EXPECT_TRUE(stream->IsSending());
6289
6290 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6291 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6292 EXPECT_EQ(1u, encoder_config.number_of_streams);
6293 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6294 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6295 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6296
6297 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6298 // VideoStreams are created appropriately.
6299 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6300 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6301 stream->GetVideoStreams()[0].min_bitrate_bps);
6302 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6303 stream->GetVideoStreams()[0].min_bitrate_bps);
6304 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6305 stream->GetVideoStreams()[0].target_bitrate_bps);
6306}
6307
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006308// Test that a stream will not be sending if its encoding is made inactive
6309// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006310TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006311 FakeVideoSendStream* stream = AddSendStream();
6312 EXPECT_TRUE(channel_->SetSend(true));
6313 EXPECT_TRUE(stream->IsSending());
6314
6315 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006316 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006317 ASSERT_EQ(1u, parameters.encodings.size());
6318 ASSERT_TRUE(parameters.encodings[0].active);
6319 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006320 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006321 EXPECT_FALSE(stream->IsSending());
6322
6323 // Now change it back to active and verify we resume sending.
6324 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006325 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006326 EXPECT_TRUE(stream->IsSending());
6327}
6328
Seth Hampson8234ead2018-02-02 15:16:24 -08006329// Tests that when active is updated for any simulcast layer then the send
6330// stream's sending state will be updated and it will be reconfigured with the
6331// new appropriate active simulcast streams.
6332TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6333 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006334 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006335 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6336 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6337 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6338 uint32_t primary_ssrc = stream_params.first_ssrc();
6339
Tommi85959932018-02-07 19:26:06 +01006340 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
6341 // frame. This allows us to test that ReconfigureEncoder is called
6342 // appropriately.
6343 cricket::FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson8234ead2018-02-02 15:16:24 -08006344 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02006345 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson8234ead2018-02-02 15:16:24 -08006346 EXPECT_EQ(cricket::CS_RUNNING,
6347 capturer.Start(cricket::VideoFormat(
6348 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
6349 cricket::FOURCC_I420)));
6350 channel_->SetSend(true);
6351 EXPECT_TRUE(capturer.CaptureFrame());
6352
6353 // Check that all encodings are initially active.
6354 webrtc::RtpParameters parameters =
6355 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006356 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006357 EXPECT_TRUE(parameters.encodings[0].active);
6358 EXPECT_TRUE(parameters.encodings[1].active);
6359 EXPECT_TRUE(parameters.encodings[2].active);
6360 EXPECT_TRUE(fake_video_send_stream->IsSending());
6361
6362 // Only turn on only the middle stream.
6363 parameters.encodings[0].active = false;
6364 parameters.encodings[1].active = true;
6365 parameters.encodings[2].active = false;
6366 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6367 // Verify that the active fields are set on the VideoChannel.
6368 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006369 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006370 EXPECT_FALSE(parameters.encodings[0].active);
6371 EXPECT_TRUE(parameters.encodings[1].active);
6372 EXPECT_FALSE(parameters.encodings[2].active);
6373 // Check that the VideoSendStream is updated appropriately. This means its
6374 // send state was updated and it was reconfigured.
6375 EXPECT_TRUE(fake_video_send_stream->IsSending());
6376 std::vector<webrtc::VideoStream> simulcast_streams =
6377 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006378 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006379 EXPECT_FALSE(simulcast_streams[0].active);
6380 EXPECT_TRUE(simulcast_streams[1].active);
6381 EXPECT_FALSE(simulcast_streams[2].active);
6382
6383 // Turn off all streams.
6384 parameters.encodings[0].active = false;
6385 parameters.encodings[1].active = false;
6386 parameters.encodings[2].active = false;
6387 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6388 // Verify that the active fields are set on the VideoChannel.
6389 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006390 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006391 EXPECT_FALSE(parameters.encodings[0].active);
6392 EXPECT_FALSE(parameters.encodings[1].active);
6393 EXPECT_FALSE(parameters.encodings[2].active);
6394 // Check that the VideoSendStream is off.
6395 EXPECT_FALSE(fake_video_send_stream->IsSending());
6396 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006397 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006398 EXPECT_FALSE(simulcast_streams[0].active);
6399 EXPECT_FALSE(simulcast_streams[1].active);
6400 EXPECT_FALSE(simulcast_streams[2].active);
6401
Niels Möllerff40b142018-04-09 08:49:14 +02006402 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08006403}
6404
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006405// Test that if a stream is reconfigured (due to a codec change or other
6406// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07006407TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006408 InactiveStreamDoesntStartSendingWhenReconfigured) {
6409 // Set an initial codec list, which will be modified later.
6410 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08006411 parameters1.codecs.push_back(GetEngineCodec("VP8"));
6412 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006413 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
6414
6415 FakeVideoSendStream* stream = AddSendStream();
6416 EXPECT_TRUE(channel_->SetSend(true));
6417 EXPECT_TRUE(stream->IsSending());
6418
6419 // Get current parameters and change "active" to false.
6420 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6421 ASSERT_EQ(1u, parameters.encodings.size());
6422 ASSERT_TRUE(parameters.encodings[0].active);
6423 parameters.encodings[0].active = false;
6424 EXPECT_EQ(1u, GetFakeSendStreams().size());
6425 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08006426 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006427 EXPECT_FALSE(stream->IsSending());
6428
6429 // Reorder the codec list, causing the stream to be reconfigured.
6430 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08006431 parameters2.codecs.push_back(GetEngineCodec("VP9"));
6432 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006433 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
6434 auto new_streams = GetFakeSendStreams();
6435 // Assert that a new underlying stream was created due to the codec change.
6436 // Otherwise, this test isn't testing what it set out to test.
6437 EXPECT_EQ(1u, GetFakeSendStreams().size());
6438 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
6439
6440 // Verify that we still are not sending anything, due to the inactive
6441 // encoding.
6442 EXPECT_FALSE(new_streams[0]->IsSending());
6443}
6444
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006445// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006446TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006447 AddSendStream();
6448 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006449 parameters.codecs.push_back(GetEngineCodec("VP8"));
6450 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006451 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6452
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006453 webrtc::RtpParameters rtp_parameters =
6454 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006455 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006456 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6457 rtp_parameters.codecs[0]);
6458 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6459 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006460}
6461
Florent Castellidacec712018-05-24 16:24:21 +02006462// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
6463TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
6464 StreamParams params = StreamParams::CreateLegacy(kSsrc);
6465 params.cname = "rtcpcname";
6466 AddSendStream(params);
6467
6468 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
6469 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
6470}
6471
deadbeeffb2aced2017-01-06 23:05:37 -08006472// Test that RtpParameters for send stream has one encoding and it has
6473// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006474TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08006475 AddSendStream();
6476
6477 webrtc::RtpParameters rtp_parameters =
6478 channel_->GetRtpSendParameters(last_ssrc_);
6479 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006480 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08006481}
6482
Florent Castelliabe301f2018-06-12 18:33:49 +02006483TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
6484 AddSendStream();
6485
6486 webrtc::RtpParameters rtp_parameters =
6487 channel_->GetRtpSendParameters(last_ssrc_);
6488 rtp_parameters.header_extensions.emplace_back();
6489
6490 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
6491
6492 webrtc::RTCError result =
6493 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6494 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
6495}
6496
Florent Castelli87b3c512018-07-18 16:00:28 +02006497TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
6498 AddSendStream();
6499
6500 FakeVideoCapturerWithTaskQueue capturer;
6501 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
6502
6503 webrtc::RtpParameters rtp_parameters =
6504 channel_->GetRtpSendParameters(last_ssrc_);
6505 EXPECT_EQ(rtp_parameters.degradation_preference,
6506 webrtc::DegradationPreference::BALANCED);
6507 rtp_parameters.degradation_preference =
6508 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
6509
6510 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
6511
6512 webrtc::RtpParameters updated_rtp_parameters =
6513 channel_->GetRtpSendParameters(last_ssrc_);
6514 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
6515 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
6516
6517 // Remove the source since it will be destroyed before the channel
6518 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6519}
6520
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006521// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006522TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006523 AddSendStream();
6524 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006525 parameters.codecs.push_back(GetEngineCodec("VP8"));
6526 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006527 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6528
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006529 webrtc::RtpParameters initial_params =
6530 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006531
6532 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08006533 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006534
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006535 // ... And this shouldn't change the params returned by GetRtpSendParameters.
6536 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
6537}
6538
6539// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006540TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006541 AddRecvStream();
6542 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006543 parameters.codecs.push_back(GetEngineCodec("VP8"));
6544 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006545 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6546
6547 webrtc::RtpParameters rtp_parameters =
6548 channel_->GetRtpReceiveParameters(last_ssrc_);
6549 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006550 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6551 rtp_parameters.codecs[0]);
6552 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6553 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006554}
6555
johan073ece42016-08-26 02:59:47 -07006556#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07006557TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006558#else
eladalonf1841382017-06-12 01:16:46 -07006559TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006560#endif
johan3859c892016-08-05 09:19:25 -07006561 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07006562 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08006563 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07006564 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07006565 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08006566 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07006567 parameters.codecs.push_back(kH264sprop2);
6568 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6569
6570 FakeVideoReceiveStream* recv_stream = AddRecvStream();
6571 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
6572 webrtc::RtpParameters rtp_parameters =
6573 channel_->GetRtpReceiveParameters(last_ssrc_);
6574 ASSERT_EQ(2u, rtp_parameters.codecs.size());
6575 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
6576 ASSERT_EQ(2u, cfg.decoders.size());
6577 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006578 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006579 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006580 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
6581 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006582 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07006583
6584 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006585 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006586 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006587 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
6588 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006589 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07006590}
6591
sakal1fd95952016-06-22 00:46:15 -07006592// Test that RtpParameters for receive stream has one encoding and it has
6593// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006594TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07006595 AddRecvStream();
6596
6597 webrtc::RtpParameters rtp_parameters =
6598 channel_->GetRtpReceiveParameters(last_ssrc_);
6599 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006600 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07006601}
6602
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006603// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006604TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006605 AddRecvStream();
6606 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006607 parameters.codecs.push_back(GetEngineCodec("VP8"));
6608 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006609 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6610
6611 webrtc::RtpParameters initial_params =
6612 channel_->GetRtpReceiveParameters(last_ssrc_);
6613
6614 // We should be able to set the params we just got.
6615 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
6616
6617 // ... And this shouldn't change the params returned by
6618 // GetRtpReceiveParameters.
6619 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006620}
6621
deadbeef3bc15102017-04-20 19:25:07 -07006622// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
6623// aren't signaled. It should always return an empty "RtpEncodingParameters",
6624// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07006625TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07006626 // Call necessary methods to configure receiving a default stream as
6627 // soon as it arrives.
6628 cricket::VideoRecvParameters parameters;
6629 parameters.codecs.push_back(GetEngineCodec("VP8"));
6630 parameters.codecs.push_back(GetEngineCodec("VP9"));
6631 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6632
6633 // Call GetRtpReceiveParameters before configured to receive an unsignaled
6634 // stream. Should return nothing.
6635 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
6636
6637 // Set a sink for an unsignaled stream.
6638 cricket::FakeVideoRenderer renderer;
6639 // Value of "0" means "unsignaled stream".
6640 EXPECT_TRUE(channel_->SetSink(0, &renderer));
6641
6642 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
6643 // in this method means "unsignaled stream".
6644 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
6645 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6646 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6647
6648 // Receive VP8 packet.
6649 uint8_t data[kMinRtpPacketLen];
6650 cricket::RtpHeader rtpHeader;
6651 rtpHeader.payload_type = GetEngineCodec("VP8").id;
6652 rtpHeader.seq_num = rtpHeader.timestamp = 0;
6653 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
6654 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
6655 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
6656 rtc::PacketTime packet_time;
6657 channel_->OnPacketReceived(&packet, packet_time);
6658
6659 // The |ssrc| member should still be unset.
6660 rtp_parameters = channel_->GetRtpReceiveParameters(0);
6661 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6662 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6663}
6664
eladalonf1841382017-06-12 01:16:46 -07006665void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02006666 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006667 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02006668
6669 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02006670 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02006671 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02006672 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02006673
6674 if (receiver_first) {
6675 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6676 std::vector<FakeVideoReceiveStream*> receive_streams =
6677 fake_call_->GetVideoReceiveStreams();
6678 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02006679 // Default local SSRC when we have no sender.
6680 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6681 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006682 }
6683 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
6684 if (!receiver_first)
6685 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6686 std::vector<FakeVideoReceiveStream*> receive_streams =
6687 fake_call_->GetVideoReceiveStreams();
6688 ASSERT_EQ(1u, receive_streams.size());
6689 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02006690
6691 // Removing first sender should fall back to another (in this case the second)
6692 // local send stream's SSRC.
6693 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
6694 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006695 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006696 ASSERT_EQ(1u, receive_streams.size());
6697 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
6698
6699 // Removing the last sender should fall back to default local SSRC.
6700 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006701 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006702 ASSERT_EQ(1u, receive_streams.size());
6703 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6704 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006705}
6706
eladalonf1841382017-06-12 01:16:46 -07006707TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02006708 TestReceiverLocalSsrcConfiguration(false);
6709}
6710
eladalonf1841382017-06-12 01:16:46 -07006711TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02006712 TestReceiverLocalSsrcConfiguration(true);
6713}
6714
eladalonf1841382017-06-12 01:16:46 -07006715class WebRtcVideoChannelSimulcastTest : public testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006716 public:
eladalonf1841382017-06-12 01:16:46 -07006717 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01006718 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006719 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
6720 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +02006721 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006722 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02006723 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006724 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07006725 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006726
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00006727 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02006728 encoder_factory_->AddSupportedVideoCodecType("VP8");
nisse51542be2016-02-12 02:27:06 -08006729 channel_.reset(
kthelgason2bc68642017-02-07 07:02:22 -08006730 engine_.CreateChannel(&fake_call_, GetMediaConfig(), VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08006731 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006732 last_ssrc_ = 123;
6733 }
6734
6735 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006736 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07006737 int capture_width,
6738 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006739 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08006740 size_t expected_num_streams,
6741 bool screenshare,
6742 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006743 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006744 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08006745 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006746 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006747
Peter Boström0c4e06b2015-10-07 12:23:21 +02006748 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07006749 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006750 ssrcs.resize(num_configured_streams);
6751
sprangf24a0642017-02-28 13:23:26 -08006752 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006753 // Send a full-size frame to trigger a stream reconfiguration to use all
6754 // expected simulcast layers.
Tommi85959932018-02-07 19:26:06 +01006755 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08006756 VideoOptions options;
6757 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01006758 options.is_screencast = screenshare;
Yves Gerey665174f2018-06-19 15:03:05 +02006759 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08006760 // Fetch the latest stream since SetVideoSend() may recreate it if the
6761 // screen content setting is changed.
6762 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006763 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(cricket::VideoFormat(
perkj26752742016-10-24 01:21:16 -07006764 capture_width, capture_height,
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006765 cricket::VideoFormat::FpsToInterval(30),
6766 cricket::FOURCC_I420)));
6767 channel_->SetSend(true);
6768 EXPECT_TRUE(capturer.CaptureFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006769
Zach Stein3ca452b2018-01-18 10:01:24 -08006770 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
6771 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
6772
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006773 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6774 ASSERT_EQ(expected_num_streams, video_streams.size());
6775
sprang429600d2017-01-26 06:12:26 -08006776 std::vector<webrtc::VideoStream> expected_streams;
6777 if (conference_mode) {
6778 expected_streams = GetSimulcastConfig(
6779 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08006780 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02006781 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08006782 if (screenshare) {
6783 for (const webrtc::VideoStream& stream : expected_streams) {
6784 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00006785 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
6786 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08006787 }
6788 }
sprang429600d2017-01-26 06:12:26 -08006789 } else {
6790 webrtc::VideoStream stream;
6791 stream.width = capture_width;
6792 stream.height = capture_height;
6793 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01006794 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08006795 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006796 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08006797 stream.max_qp = kDefaultQpMax;
6798 expected_streams.push_back(stream);
6799 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006800
6801 ASSERT_EQ(expected_streams.size(), video_streams.size());
6802
6803 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006804 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006805 for (size_t i = 0; i < num_streams; ++i) {
6806 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
6807 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
6808
6809 EXPECT_GT(video_streams[i].max_framerate, 0);
6810 EXPECT_EQ(expected_streams[i].max_framerate,
6811 video_streams[i].max_framerate);
6812
6813 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
6814 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
6815 video_streams[i].min_bitrate_bps);
6816
6817 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
6818 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
6819 video_streams[i].target_bitrate_bps);
6820
6821 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
6822 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
6823 video_streams[i].max_bitrate_bps);
6824
6825 EXPECT_GT(video_streams[i].max_qp, 0);
6826 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
6827
Sergey Silkina796a7e2018-03-01 15:11:29 +01006828 EXPECT_EQ(conference_mode,
6829 expected_streams[i].num_temporal_layers.has_value());
6830
6831 if (conference_mode) {
6832 EXPECT_EQ(expected_streams[i].num_temporal_layers,
6833 video_streams[i].num_temporal_layers);
6834 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006835
6836 if (i == num_streams - 1) {
6837 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
6838 } else {
6839 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
6840 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006841 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006842
Niels Möllerff40b142018-04-09 08:49:14 +02006843 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006844 }
6845
6846 FakeVideoSendStream* AddSendStream() {
6847 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
6848 }
6849
6850 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006851 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006852 EXPECT_TRUE(channel_->AddSendStream(sp));
6853 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006854 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006855 EXPECT_EQ(num_streams + 1, streams.size());
6856 return streams[streams.size() - 1];
6857 }
6858
6859 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006860 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006861 }
6862
6863 FakeVideoReceiveStream* AddRecvStream() {
6864 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
6865 }
6866
6867 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006868 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006869 EXPECT_TRUE(channel_->AddRecvStream(sp));
6870 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006871 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006872 EXPECT_EQ(num_streams + 1, streams.size());
6873 return streams[streams.size() - 1];
6874 }
6875
skvlad11a9cbf2016-10-07 11:53:05 -07006876 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006877 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006878 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
6879 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -07006880 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08006881 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02006882 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006883};
6884
eladalonf1841382017-06-12 01:16:46 -07006885TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006886 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
6887 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006888}
6889
eladalonf1841382017-06-12 01:16:46 -07006890TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006891 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
6892 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006893}
6894
6895// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07006896TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08006897 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
6898 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006899}
sprang429600d2017-01-26 06:12:26 -08006900
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006901TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006902 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6903 false);
6904}
6905
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006906TEST_F(WebRtcVideoChannelSimulcastTest,
6907 SetSendCodecsForConferenceModeScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006908 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6909 true);
6910}
6911
eladalonf1841382017-06-12 01:16:46 -07006912TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
Erik Språngb65aa012018-09-24 11:35:19 +02006913 webrtc::test::ScopedFieldTrials override_field_trials_(
6914 "WebRTC-SimulcastScreenshare/Enabled/");
sprang429600d2017-01-26 06:12:26 -08006915 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
6916 true);
6917}
6918
eladalonf1841382017-06-12 01:16:46 -07006919TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07006920 NoSimulcastScreenshareWithoutConference) {
Erik Språngb65aa012018-09-24 11:35:19 +02006921 webrtc::test::ScopedFieldTrials override_field_trials_(
6922 "WebRTC-SimulcastScreenshare/Enabled/");
sprangfe627f32017-03-29 08:24:59 -07006923 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6924 false);
6925}
6926
Yves Gereyb6a89422018-10-08 10:08:32 +02006927class WebRtcVideoFakeClock {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006928 public:
Yves Gereyb6a89422018-10-08 10:08:32 +02006929 WebRtcVideoFakeClock() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006930 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1)); // avoid time=0
6931 }
6932 rtc::ScopedFakeClock fake_clock_;
6933};
6934
Yves Gereyb6a89422018-10-08 10:08:32 +02006935// The fake clock needs to be initialized before the call, and not
6936// destroyed until after all threads spawned by the test have been stopped.
6937// This mixin ensures that.
6938class WebRtcVideoChannelTestWithClock : public WebRtcVideoFakeClock,
6939 public WebRtcVideoChannelBaseTest {};
6940
Jonas Oreland49ac5952018-09-26 16:04:32 +02006941TEST_F(WebRtcVideoChannelTestWithClock, GetSources) {
6942 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
6943 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
6944
6945 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
6946
6947 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
6948 rtc::SetBE32(packet1.data() + 8, kSsrc);
6949 channel_->SetSink(kDefaultReceiveSsrc, NULL);
6950 EXPECT_TRUE(SetDefaultCodec());
6951 EXPECT_TRUE(SetSend(true));
6952 EXPECT_EQ(0, renderer_.num_rendered_frames());
6953 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
6954
6955 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
6956 EXPECT_EQ(1u, sources.size());
6957 EXPECT_EQ(webrtc::RtpSourceType::SSRC, sources[0].source_type());
6958 int64_t timestamp1 = sources[0].timestamp_ms();
6959
6960 // a new packet.
6961 int64_t timeDeltaMs = 1;
6962 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
6963 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
6964 int64_t timestamp2 = channel_->GetSources(kSsrc)[0].timestamp_ms();
6965 EXPECT_EQ(timestamp2, timestamp1 + timeDeltaMs);
6966
6967 // It only keeps 10s of history.
6968 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
6969 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
6970 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
6971}
6972
6973TEST_F(WebRtcVideoChannelTestWithClock, GetContributingSources) {
6974 uint8_t data1[] = {0x81, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
6975 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
6976
6977 uint32_t kCsrc = 4321u;
6978 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
6979 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
6980
6981 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
6982 rtc::SetBE32(packet1.data() + 8, kSsrc);
6983 rtc::SetBE32(packet1.data() + 12, kCsrc);
6984 channel_->SetSink(kDefaultReceiveSsrc, NULL);
6985 EXPECT_TRUE(SetDefaultCodec());
6986 EXPECT_TRUE(SetSend(true));
6987 EXPECT_EQ(0, renderer_.num_rendered_frames());
6988 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
6989
6990 {
6991 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
6992 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
6993 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
6994 EXPECT_EQ(sources[0].timestamp_ms(), sources[1].timestamp_ms());
6995 // 1 SSRC and 1 CSRC.
6996 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
6997 [](const webrtc::RtpSource& source) {
6998 return source.source_type() ==
6999 webrtc::RtpSourceType::SSRC;
7000 }));
7001 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7002 [](const webrtc::RtpSource& source) {
7003 return source.source_type() ==
7004 webrtc::RtpSourceType::CSRC;
7005 }));
7006 }
7007 int64_t timestamp1 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7008
7009 // a new packet with only ssrc (i.e no csrc).
7010 uint8_t data2[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7011 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7012 rtc::CopyOnWriteBuffer packet2(data2, sizeof(data2));
7013 rtc::SetBE32(packet2.data() + 8, kSsrc);
7014
7015 int64_t timeDeltaMs = 1;
7016 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
7017 channel_->OnPacketReceived(&packet2, rtc::PacketTime());
7018
7019 {
7020 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7021 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7022 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7023 EXPECT_NE(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7024 // 1 SSRC and 1 CSRC.
7025 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7026 [](const webrtc::RtpSource& source) {
7027 return source.source_type() ==
7028 webrtc::RtpSourceType::SSRC;
7029 }));
7030 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7031 [](const webrtc::RtpSource& source) {
7032 return source.source_type() ==
7033 webrtc::RtpSourceType::CSRC;
7034 }));
7035 auto ssrcSource = std::find_if(
7036 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7037 return source.source_type() == webrtc::RtpSourceType::SSRC;
7038 });
7039 auto csrcSource = std::find_if(
7040 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7041 return source.source_type() == webrtc::RtpSourceType::CSRC;
7042 });
7043
7044 EXPECT_EQ(ssrcSource->timestamp_ms(), timestamp1 + timeDeltaMs);
7045 EXPECT_EQ(csrcSource->timestamp_ms(), timestamp1);
7046 }
7047
7048 // It only keeps 10s of history.
7049 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7050
7051 {
7052 ASSERT_EQ(1u, channel_->GetSources(kSsrc).size());
7053 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7054 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7055 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7056 [](const webrtc::RtpSource& source) {
7057 return source.source_type() ==
7058 webrtc::RtpSourceType::SSRC;
7059 }));
7060 EXPECT_EQ(0, std::count_if(sources.begin(), sources.end(),
7061 [](const webrtc::RtpSource& source) {
7062 return source.source_type() ==
7063 webrtc::RtpSourceType::CSRC;
7064 }));
7065 }
7066
7067 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7068 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7069 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7070}
7071
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007072} // namespace cricket