blob: 869a41d7837846231ef5c5c74b56cc37b4a01215 [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +000011#include <algorithm>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000012#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080013#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070014#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000015#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000016
Seth Hampson24722b32017-12-22 09:36:42 -080017#include "api/rtpparameters.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070018#include "api/test/mock_video_decoder_factory.h"
19#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020020#include "api/units/time_delta.h"
Åsa Persson23eba222018-10-02 14:47:06 +020021#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020022#include "api/video_codecs/builtin_video_decoder_factory.h"
23#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020024#include "api/video_codecs/sdp_video_format.h"
25#include "api/video_codecs/video_decoder_factory.h"
26#include "api/video_codecs/video_encoder.h"
27#include "api/video_codecs/video_encoder_factory.h"
28#include "call/flexfec_receive_stream.h"
29#include "common_video/h264/profile_level_id.h"
30#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller6557d0c2018-04-11 15:18:34 +020031#include "media/base/fakenetworkinterface.h"
32#include "media/base/fakevideocapturer.h"
33#include "media/base/fakevideorenderer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020034#include "media/base/mediaconstants.h"
35#include "media/base/rtputils.h"
36#include "media/base/testutils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020037#include "media/engine/constants.h"
38#include "media/engine/fakewebrtccall.h"
39#include "media/engine/fakewebrtcvideoengine.h"
40#include "media/engine/simulcast.h"
41#include "media/engine/webrtcvideoengine.h"
42#include "media/engine/webrtcvoiceengine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020043#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020044#include "rtc_base/arraysize.h"
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +020045#include "rtc_base/fakeclock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020046#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020047#include "rtc_base/numerics/safe_conversions.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020048#include "rtc_base/stringutils.h"
49#include "test/field_trial.h"
50#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000051
Tommi85959932018-02-07 19:26:06 +010052using cricket::FakeVideoCapturerWithTaskQueue;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010053using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070054using webrtc::RtpExtension;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010055using testing::Field;
isheriff6f8d6862016-05-26 11:24:55 -070056
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000057namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000058static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000059
noahricd10a68e2015-07-10 11:27:55 -070060static const uint8_t kRedRtxPayloadType = 125;
61
Niels Möller6557d0c2018-04-11 15:18:34 +020062static const uint32_t kTimeout = 5000U;
63static const uint32_t kDefaultReceiveSsrc = 0;
64static const uint32_t kSsrc = 1234u;
65static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
66static const int kVideoWidth = 640;
67static const int kVideoHeight = 360;
68static const int kFramerate = 30;
69
Peter Boström0c4e06b2015-10-07 12:23:21 +020070static const uint32_t kSsrcs1[] = {1};
71static const uint32_t kSsrcs3[] = {1, 2, 3};
72static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080073static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020074static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080075static const uint32_t kDefaultRecvSsrc = 0;
76
pbos@webrtc.org3c107582014-07-20 15:27:35 +000077static const char kUnsupportedExtensionName[] =
78 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000079
magjed509e4fe2016-11-18 01:34:11 -080080cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
81 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020082 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080083}
84
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000085void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
86 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
87 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
88 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
89 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
90 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
91 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
92 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -080093 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
94 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000095 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
96}
97
magjed725e4842016-11-16 00:48:13 -080098// Return true if any codec in |codecs| is an RTX codec with associated payload
99// type |payload_type|.
100bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
101 int payload_type) {
102 for (const cricket::VideoCodec& codec : codecs) {
103 int associated_payload_type;
Oleh Prypin6e8e2992018-10-23 15:18:23 +0200104 if (cricket::CodecNamesEq(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800105 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
106 &associated_payload_type) &&
107 associated_payload_type == payload_type) {
108 return true;
109 }
110 }
111 return false;
112}
113
nisseca5706d2017-09-11 02:32:16 -0700114// TODO(nisse): Duplicated in call.cc.
115const int* FindKeyByValue(const std::map<int, int>& m, int v) {
116 for (const auto& kv : m) {
117 if (kv.second == v)
118 return &kv.first;
119 }
120 return nullptr;
121}
122
Yves Gerey665174f2018-06-19 15:03:05 +0200123bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
124 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700125 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
126 payload_type) != nullptr;
127}
128
129// Check that there's an Rtx payload type for each decoder.
130bool VerifyRtxReceiveAssociations(
131 const webrtc::VideoReceiveStream::Config& config) {
132 for (const auto& decoder : config.decoders) {
133 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
134 return false;
135 }
136 return true;
137}
138
brandtrffc61182016-11-28 06:02:22 -0800139rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700140 int width,
141 int height) {
142 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
143 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800144 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700145 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000146}
147
Shao Changbine62202f2015-04-21 20:24:50 +0800148void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
149 const std::map<int, int>& rtx_types) {
150 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200151 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800152 EXPECT_TRUE(it != rtx_types.end() &&
153 it->second == config.rtp.rtx.payload_type);
154
brandtrb5f2c3f2016-10-04 23:28:39 -0700155 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
156 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800157 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700158 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800159 }
160}
kthelgason2bc68642017-02-07 07:02:22 -0800161
162cricket::MediaConfig GetMediaConfig() {
163 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100164 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800165 return media_config;
166}
nisse26e3abb2017-08-25 04:44:25 -0700167
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200168// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
169int GetMaxDefaultBitrateBps(size_t width, size_t height) {
170 if (width * height <= 320 * 240) {
171 return 600000;
172 } else if (width * height <= 640 * 480) {
173 return 1700000;
174 } else if (width * height <= 960 * 540) {
175 return 2000000;
176 } else {
177 return 2500000;
178 }
179}
180
Niels Möller731a2c22018-07-30 15:08:07 +0200181class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
182 public:
183 MOCK_METHOD2(AddOrUpdateSink,
184 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
185 const rtc::VideoSinkWants& wants));
186 MOCK_METHOD1(RemoveSink,
187 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
188};
189
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000190} // namespace
191
Yves Gerey665174f2018-06-19 15:03:05 +0200192#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200193 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200194 EXPECT_EQ((w), renderer_.width()); \
195 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200196 EXPECT_EQ(0, renderer_.errors());
197
Yves Gerey665174f2018-06-19 15:03:05 +0200198#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200199 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200200 EXPECT_EQ((w), (r).width()); \
201 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200202 EXPECT_EQ(0, (r).errors());
203
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000204namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700205class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000206 public:
eladalonf1841382017-06-12 01:16:46 -0700207 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
208 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700209 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700210 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200211 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
212 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +0200213 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200214 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200215 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200216 decoder_factory_)) {
217 // Ensure fake clock doesn't return 0, which will cause some initializations
218 // fail inside RTP senders.
219 fake_clock_.AdvanceTimeMicros(1);
220 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000221
222 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200223 void AssignDefaultAptRtxTypes();
224 void AssignDefaultCodec();
225
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100226 // Find the index of the codec in the engine with the given name. The codec
227 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100228 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100229
magjed509e4fe2016-11-18 01:34:11 -0800230 // Find the codec in the engine with the given name. The codec must be
231 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100232 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800233
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200234 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000235
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200236 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000237 const std::vector<VideoCodec>& codecs);
238
Peter Boströme4499152016-02-05 11:13:28 +0100239 void TestExtendedEncoderOveruse(bool use_external_encoder);
240
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200241 // Has to be the first one, so it is initialized before the call or there is a
242 // race condition in the clock access.
243 rtc::ScopedFakeClock fake_clock_;
stefanc1aeaf02015-10-15 07:26:07 -0700244 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700245 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700246 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000247 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800248 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200249 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
250 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -0700251 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000252 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800253 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000254};
255
eladalonf1841382017-06-12 01:16:46 -0700256TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200257 encoder_factory_->AddSupportedVideoCodecType("VP8");
258 AssignDefaultCodec();
259
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000260 std::vector<VideoCodec> engine_codecs = engine_.codecs();
261 for (size_t i = 0; i < engine_codecs.size(); ++i) {
262 if (engine_codecs[i].name != kRtxCodecName)
263 continue;
264 int associated_payload_type;
265 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000266 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000267 EXPECT_EQ(default_codec_.id, associated_payload_type);
268 return;
269 }
270 FAIL() << "No RTX codec found among default codecs.";
271}
272
eladalonf1841382017-06-12 01:16:46 -0700273TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100274 RtpCapabilities capabilities = engine_.GetCapabilities();
275 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700276 for (const RtpExtension& extension : capabilities.header_extensions) {
277 if (extension.uri == RtpExtension::kTimestampOffsetUri) {
278 EXPECT_EQ(RtpExtension::kTimestampOffsetDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000279 return;
280 }
281 }
282 FAIL() << "Timestamp offset extension not in header-extension list.";
283}
284
eladalonf1841382017-06-12 01:16:46 -0700285TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100286 RtpCapabilities capabilities = engine_.GetCapabilities();
287 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700288 for (const RtpExtension& extension : capabilities.header_extensions) {
289 if (extension.uri == RtpExtension::kAbsSendTimeUri) {
290 EXPECT_EQ(RtpExtension::kAbsSendTimeDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000291 return;
292 }
293 }
294 FAIL() << "Absolute Sender Time extension not in header-extension list.";
295}
296
eladalonf1841382017-06-12 01:16:46 -0700297TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100298 RtpCapabilities capabilities = engine_.GetCapabilities();
299 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700300 for (const RtpExtension& extension : capabilities.header_extensions) {
301 if (extension.uri == RtpExtension::kTransportSequenceNumberUri) {
302 EXPECT_EQ(RtpExtension::kTransportSequenceNumberDefaultId, extension.id);
stefanc1aeaf02015-10-15 07:26:07 -0700303 return;
304 }
305 }
306 FAIL() << "Transport sequence number extension not in header-extension list.";
307}
308
eladalonf1841382017-06-12 01:16:46 -0700309TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100310 RtpCapabilities capabilities = engine_.GetCapabilities();
311 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700312 for (const RtpExtension& extension : capabilities.header_extensions) {
313 if (extension.uri == RtpExtension::kVideoRotationUri) {
314 EXPECT_EQ(RtpExtension::kVideoRotationDefaultId, extension.id);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700315 return;
316 }
317 }
318 FAIL() << "Video Rotation extension not in header-extension list.";
319}
320
philipel1e054862018-10-08 16:13:53 +0200321class WebRtcVideoEngineTestWithGenericDescriptor
322 : public WebRtcVideoEngineTest {
323 public:
324 WebRtcVideoEngineTestWithGenericDescriptor()
325 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
326};
327
328TEST_F(WebRtcVideoEngineTestWithGenericDescriptor, AdvertiseGenericDescriptor) {
329 RtpCapabilities capabilities = engine_.GetCapabilities();
330 ASSERT_FALSE(capabilities.header_extensions.empty());
331 for (const RtpExtension& extension : capabilities.header_extensions) {
332 if (extension.uri == RtpExtension::kGenericFrameDescriptorUri) {
333 EXPECT_EQ(RtpExtension::kGenericFrameDescriptorDefaultId, extension.id);
334 return;
335 }
336 }
337 FAIL() << "Generic descriptor extension not in header-extension list.";
338}
339
eladalonf1841382017-06-12 01:16:46 -0700340TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200341 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700342 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200343 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700344
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200345 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700346
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200347 std::unique_ptr<VideoMediaChannel> channel(
348 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700349 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
350
351 // Add CVO extension.
352 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800353 cricket::VideoSendParameters parameters;
354 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200355 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700356 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200357 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700358
Niels Möller731a2c22018-07-30 15:08:07 +0200359 EXPECT_CALL(
360 video_source,
361 AddOrUpdateSink(testing::_,
362 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700363 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200364 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700365
366 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200367 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700368
369 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200370 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200371 EXPECT_CALL(
372 video_source,
373 AddOrUpdateSink(testing::_,
374 Field(&rtc::VideoSinkWants::rotation_applied, true)));
375
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200376 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700377}
378
eladalonf1841382017-06-12 01:16:46 -0700379TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200380 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800381 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200382 testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800383
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200384 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800385
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200386 std::unique_ptr<VideoMediaChannel> channel(
387 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800388 // Add CVO extension.
389 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800390 cricket::VideoSendParameters parameters;
391 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800392 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700393 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800394 EXPECT_TRUE(channel->SetSendParameters(parameters));
395 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
396
Niels Möller731a2c22018-07-30 15:08:07 +0200397 // Set source.
398 EXPECT_CALL(
399 video_source,
400 AddOrUpdateSink(testing::_,
401 Field(&rtc::VideoSinkWants::rotation_applied, false)));
402 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800403}
404
eladalonf1841382017-06-12 01:16:46 -0700405TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200406 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700407
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200408 encoder_factory_->AddSupportedVideoCodecType("VP8");
409 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700410
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200411 std::unique_ptr<VideoMediaChannel> channel(
412 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700413 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
414
415 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200416 EXPECT_CALL(
417 video_source,
418 AddOrUpdateSink(testing::_,
419 Field(&rtc::VideoSinkWants::rotation_applied, true)));
420 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700421
perkjcaafdba2016-03-20 07:34:29 -0700422 // Verify capturer has turned on applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200423 testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700424
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700425 // Add CVO extension.
426 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800427 cricket::VideoSendParameters parameters;
428 parameters.codecs.push_back(GetEngineCodec("VP8"));
429 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200430 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700431 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700432 // Also remove the first codec to trigger a codec change as well.
433 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200434 EXPECT_CALL(
435 video_source,
436 AddOrUpdateSink(testing::_,
437 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200438 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700439
440 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200441 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700442
443 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200444 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200445 EXPECT_CALL(
446 video_source,
447 AddOrUpdateSink(testing::_,
448 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200449 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700450}
451
eladalonf1841382017-06-12 01:16:46 -0700452TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200453 encoder_factory_->AddSupportedVideoCodecType("VP8");
454
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700455 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
456 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000457
458 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
459
460 EXPECT_FALSE(channel->SetSend(true))
461 << "Channel should not start without codecs.";
462 EXPECT_TRUE(channel->SetSend(false))
463 << "Channel should be stoppable even without set codecs.";
464}
465
eladalonf1841382017-06-12 01:16:46 -0700466TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200467 encoder_factory_->AddSupportedVideoCodecType("VP8");
468
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700469 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
470 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000471 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
472 VideoMediaInfo info;
473 channel->GetStats(&info);
474}
475
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200476TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200477 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000478
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200479 std::unique_ptr<VideoMediaChannel> channel(
480 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800481 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000482
483 EXPECT_TRUE(
484 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200485 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000486 EXPECT_TRUE(channel->SetSend(true));
Tommi85959932018-02-07 19:26:06 +0100487 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200488 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000489 EXPECT_EQ(cricket::CS_RUNNING,
490 capturer.Start(capturer.GetSupportedFormats()->front()));
491 EXPECT_TRUE(capturer.CaptureFrame());
Per21d45d22016-10-30 21:37:57 +0100492 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200493 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
494 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000495 kTimeout);
496
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200497 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100498 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000499
500 // Setting codecs of the same type should not reallocate any encoders
501 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800502 cricket::VideoSendParameters parameters;
503 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200504 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200505 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000506
507 // Remove stream previously added to free the external encoder instance.
508 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200509 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000510}
511
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200512// Test that when an encoder factory supports H264, we add an RTX
513// codec for it.
514// TODO(deadbeef): This test should be updated if/when we start
515// adding RTX codecs for unrecognized codec names.
516TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800517 using webrtc::H264::ProfileLevelIdToString;
518 using webrtc::H264::ProfileLevelId;
519 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200520 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
521 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800522 *ProfileLevelIdToString(
523 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200524 webrtc::SdpVideoFormat h264_constrained_high("H264");
525 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800526 *ProfileLevelIdToString(
527 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200528 webrtc::SdpVideoFormat h264_high("H264");
529 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800530 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
531
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200532 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
533 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
534 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700535
magjed725e4842016-11-16 00:48:13 -0800536 // First figure out what payload types the test codecs got assigned.
537 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800538 // Now search for RTX codecs for them. Expect that they all have associated
539 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800540 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200541 codecs,
542 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
543 ->id));
magjed725e4842016-11-16 00:48:13 -0800544 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200545 codecs,
546 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
547 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800548 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200549 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700550}
551
Peter Boström12996152016-05-14 02:03:18 +0200552#if !defined(RTC_DISABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700553TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200554 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100555
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200556 std::unique_ptr<VideoMediaChannel> channel(
557 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100558
559 EXPECT_TRUE(
560 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
561}
Peter Boström12996152016-05-14 02:03:18 +0200562#endif // !defined(RTC_DISABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100563
eladalonf1841382017-06-12 01:16:46 -0700564TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200565 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100566 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200567 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200568 std::unique_ptr<VideoMediaChannel> channel(
569 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700570
571 EXPECT_TRUE(
572 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
573
Tommi85959932018-02-07 19:26:06 +0100574 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200575 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
qiangchenc27d89f2015-07-16 10:27:16 -0700576 capturer.Start(cricket::VideoFormat(1280, 720,
577 cricket::VideoFormat::FpsToInterval(60),
578 cricket::FOURCC_I420));
579 channel->SetSend(true);
580
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200581 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700582
583 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700584 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700585 for (int i = 0; i < 10; i++) {
586 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700587 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700588 int64_t interval = timestamp - last_timestamp;
589
590 // Precision changes from nanosecond to millisecond.
591 // Allow error to be no more than 1.
592 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
593
594 last_timestamp = timestamp;
595 }
596
597 capturer.Start(cricket::VideoFormat(1280, 720,
598 cricket::VideoFormat::FpsToInterval(30),
599 cricket::FOURCC_I420));
600
601 EXPECT_TRUE(capturer.CaptureFrame());
602 last_timestamp = stream->GetLastTimestamp();
603 for (int i = 0; i < 10; i++) {
604 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700605 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700606 int64_t interval = timestamp - last_timestamp;
607
608 // Precision changes from nanosecond to millisecond.
609 // Allow error to be no more than 1.
610 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
611
612 last_timestamp = timestamp;
613 }
614
615 // Remove stream previously added to free the external encoder instance.
616 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
617}
618
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200619void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
620 std::vector<VideoCodec> engine_codecs = engine_.codecs();
621 RTC_DCHECK(!engine_codecs.empty());
622 for (const cricket::VideoCodec& codec : engine_codecs) {
623 if (codec.name == "rtx") {
624 int associated_payload_type;
625 if (codec.GetParam(kCodecParamAssociatedPayloadType,
626 &associated_payload_type)) {
627 default_apt_rtx_types_[associated_payload_type] = codec.id;
628 }
629 }
630 }
631}
632
633void WebRtcVideoEngineTest::AssignDefaultCodec() {
634 std::vector<VideoCodec> engine_codecs = engine_.codecs();
635 RTC_DCHECK(!engine_codecs.empty());
636 bool codec_set = false;
637 for (const cricket::VideoCodec& codec : engine_codecs) {
638 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
639 codec.name != "ulpfec") {
640 default_codec_ = codec;
641 codec_set = true;
642 }
643 }
644
645 RTC_DCHECK(codec_set);
646}
647
Oleh Prypina40f8242017-12-21 13:32:23 +0100648size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
649 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100650 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
651 for (size_t i = 0; i < codecs.size(); ++i) {
652 const cricket::VideoCodec engine_codec = codecs[i];
Oleh Prypin6e8e2992018-10-23 15:18:23 +0200653 if (!CodecNamesEq(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200654 continue;
655 // The tests only use H264 Constrained Baseline. Make sure we don't return
656 // an internal H264 codec from the engine with a different H264 profile.
Oleh Prypin6e8e2992018-10-23 15:18:23 +0200657 if (CodecNamesEq(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200658 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200659 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
660 if (profile_level_id->profile !=
661 webrtc::H264::kProfileConstrainedBaseline) {
662 continue;
663 }
664 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100665 return i;
magjed509e4fe2016-11-18 01:34:11 -0800666 }
667 // This point should never be reached.
668 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100669 return -1;
670}
671
672cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
673 const std::string& name) const {
674 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800675}
676
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200677VideoMediaChannel*
678WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700679 VideoMediaChannel* channel = engine_.CreateChannel(
680 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200681 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800682 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200683 for (const webrtc::SdpVideoFormat& format :
684 encoder_factory_->GetSupportedFormats()) {
685 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
686 if (std::find(parameters.codecs.begin(), parameters.codecs.end(),
687 engine_codec) == parameters.codecs.end()) {
688 parameters.codecs.push_back(engine_codec);
689 }
690 }
magjed509e4fe2016-11-18 01:34:11 -0800691
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200692 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000693
694 return channel;
695}
696
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200697VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000698 const std::vector<VideoCodec>& codecs) {
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700699 VideoMediaChannel* channel = engine_.CreateChannel(
700 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200701 cricket::VideoRecvParameters parameters;
702 parameters.codecs = codecs;
703 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000704
705 return channel;
706}
707
eladalonf1841382017-06-12 01:16:46 -0700708TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200709 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000710
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200711 std::unique_ptr<VideoMediaChannel> channel(
712 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000713
Peter Boström0c4e06b2015-10-07 12:23:21 +0200714 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000715
Yves Gerey665174f2018-06-19 15:03:05 +0200716 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000717 EXPECT_TRUE(channel->SetSend(true));
718
Tommi85959932018-02-07 19:26:06 +0100719 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200720 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000721 EXPECT_EQ(cricket::CS_RUNNING,
722 capturer.Start(capturer.GetSupportedFormats()->front()));
723 EXPECT_TRUE(capturer.CaptureFrame());
724
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200725 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000726
727 // Verify that encoders are configured for simulcast through adapter
728 // (increasing resolution and only configured to send one stream each).
729 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200730 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
731 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000732 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200733 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000734 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
735 EXPECT_GT(codec_settings.width, prev_width);
736 prev_width = codec_settings.width;
737 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000738
Niels Möllerff40b142018-04-09 08:49:14 +0200739 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000740
741 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200742 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000743}
744
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200745TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
746 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200747 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000748
Niels Möller4db138e2018-04-19 09:04:13 +0200749 // Set capturer.
750 FakeVideoCapturerWithTaskQueue capturer;
751 EXPECT_EQ(cricket::CS_RUNNING,
752 capturer.Start(capturer.GetSupportedFormats()->front()));
753
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700754 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
755 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200756 cricket::VideoSendParameters parameters;
757 parameters.codecs.push_back(GetEngineCodec("H264"));
758 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000759
760 EXPECT_TRUE(
761 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller4db138e2018-04-19 09:04:13 +0200762 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
763 // Sending one frame will have allocate the encoder.
764 EXPECT_TRUE(capturer.CaptureFrame());
765
766 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000767
Anders Carlsson67537952018-05-03 11:28:29 +0200768 cricket::VideoSendParameters new_parameters;
769 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
770 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200771
772 // Sending one frame will switch encoder.
773 EXPECT_TRUE(capturer.CaptureFrame());
774
Anders Carlsson8a150d92018-05-14 12:40:04 +0200775 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000776}
777
eladalonf1841382017-06-12 01:16:46 -0700778TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000779 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200780 encoder_factory_->AddSupportedVideoCodecType("VP8");
781 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000782
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700783 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
784 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800785 cricket::VideoSendParameters parameters;
786 parameters.codecs.push_back(GetEngineCodec("VP8"));
787 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000788
Peter Boström0c4e06b2015-10-07 12:23:21 +0200789 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000790
Yves Gerey665174f2018-06-19 15:03:05 +0200791 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000792 EXPECT_TRUE(channel->SetSend(true));
793
794 // Send a fake frame, or else the media engine will configure the simulcast
795 // encoder adapter at a low-enough size that it'll only create a single
796 // encoder layer.
Tommi85959932018-02-07 19:26:06 +0100797 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200798 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000799 EXPECT_EQ(cricket::CS_RUNNING,
800 capturer.Start(capturer.GetSupportedFormats()->front()));
801 EXPECT_TRUE(capturer.CaptureFrame());
802
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200803 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
804 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000805 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200806 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000807
808 channel.reset();
809 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200810 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000811}
812
eladalonf1841382017-06-12 01:16:46 -0700813TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000814 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200815 encoder_factory_->AddSupportedVideoCodecType("VP8");
816 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000817
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700818 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
819 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800820 cricket::VideoSendParameters parameters;
821 parameters.codecs.push_back(GetEngineCodec("H264"));
822 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000823
824 EXPECT_TRUE(
825 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100826
827 // Send a frame of 720p. This should trigger a "real" encoder initialization.
828 cricket::VideoFormat format(
829 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100830 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200831 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Per21d45d22016-10-30 21:37:57 +0100832 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
833 EXPECT_TRUE(capturer.CaptureFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200834 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
835 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200836 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000837 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200838 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000839
840 channel.reset();
841 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200842 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000843}
844
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200845TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
846 webrtc::test::ScopedFieldTrials override_field_trials_(
847 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200848 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700849
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700850 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
851 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200852 cricket::VideoSendParameters parameters;
853 parameters.codecs.push_back(GetEngineCodec("H264"));
854 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700855
Peter Boström0c4e06b2015-10-07 12:23:21 +0200856 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700857 EXPECT_TRUE(
858 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100859
860 // Send a frame of 720p. This should trigger a "real" encoder initialization.
noahricfdac5162015-08-27 01:59:29 -0700861 cricket::VideoFormat format(
862 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100863 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200864 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &capturer));
Peter Boströmce23bee2016-02-02 14:14:30 +0100865 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
866 EXPECT_TRUE(capturer.CaptureFrame());
867
Niels Möller4db138e2018-04-19 09:04:13 +0200868 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200869 ASSERT_EQ(1u, encoder_factory_->encoders().size());
870 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
871 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700872 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200873 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200874 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700875}
876
brandtrffc61182016-11-28 06:02:22 -0800877// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700878// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800879//
880// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700881TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800882 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200883 encoder_factory_->AddSupportedVideoCodecType("VP8");
884
brandtrffc61182016-11-28 06:02:22 -0800885 auto is_flexfec = [](const VideoCodec& codec) {
886 if (codec.name == "flexfec-03")
887 return true;
888 return false;
889 };
890
891 // FlexFEC is not active without field trial.
brandtrffc61182016-11-28 06:02:22 -0800892 const std::vector<VideoCodec> codecs_before = engine_.codecs();
893 EXPECT_EQ(codecs_before.end(), std::find_if(codecs_before.begin(),
894 codecs_before.end(), is_flexfec));
895
896 // FlexFEC is active with field trial.
897 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800898 "WebRTC-FlexFEC-03-Advertised/Enabled/");
brandtrffc61182016-11-28 06:02:22 -0800899 const std::vector<VideoCodec> codecs_after = engine_.codecs();
900 EXPECT_NE(codecs_after.end(),
901 std::find_if(codecs_after.begin(), codecs_after.end(), is_flexfec));
902}
903
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200904// Test that codecs are added in the order they are reported from the factory.
905TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
906 encoder_factory_->AddSupportedVideoCodecType("VP8");
907 const char* kFakeCodecName = "FakeCodec";
908 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000909
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200910 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100911 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200912 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
913 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000914}
915
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200916// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800917// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200918TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100919 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
920 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100921
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100922 // Set up external encoder factory with first codec, and initialize engine.
923 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
924
brandtrffc61182016-11-28 06:02:22 -0800925 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800926
927 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100928 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800929 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200930 // The codec itself and RTX should have been added.
931 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100932
933 // Check that both fake codecs are present and that the second fake codec
934 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100935 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
936 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100937 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800938}
939
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200940TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
941 const char* kFakeCodecName = "FakeCodec";
942 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
943
944 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
945 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
946}
947
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200948TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
949 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200950 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200951 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800952 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000953
kwiberg686a8ef2016-02-26 03:00:35 -0800954 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200955 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000956
957 EXPECT_TRUE(
958 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200959 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000960
961 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200962 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200963 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000964
965 // Remove stream previously added to free the external decoder instance.
966 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200967 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000968}
969
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200970// Verifies that we can set up decoders.
971TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000972 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
973 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
974 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
975 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200976 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +0200977 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000978 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800979 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000980
kwiberg686a8ef2016-02-26 03:00:35 -0800981 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200982 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000983
984 EXPECT_TRUE(
985 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200986 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000987}
988
Jonas Oreland49ac5952018-09-26 16:04:32 +0200989// Tests when GetSources is called with non-existing ssrc, it will return an
990// empty list of RtpSource without crashing.
991TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
992 // Setup an recv stream with |kSsrc|.
993 encoder_factory_->AddSupportedVideoCodecType("VP8");
994 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
995 cricket::VideoRecvParameters parameters;
996 parameters.codecs.push_back(GetEngineCodec("VP8"));
997 std::unique_ptr<VideoMediaChannel> channel(
998 SetRecvParamsWithSupportedCodecs(parameters.codecs));
999
1000 EXPECT_TRUE(
1001 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1002
1003 // Call GetSources with |kSsrc + 1| which doesn't exist.
1004 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1005 EXPECT_EQ(0u, sources.size());
1006}
1007
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001008TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1009 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1010 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
1011 WebRtcVideoEngine engine(std::move(encoder_factory),
1012 std::move(decoder_factory));
1013 EXPECT_EQ(0u, engine.codecs().size());
1014}
1015
1016TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1017 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001018 webrtc::MockVideoEncoderFactory* encoder_factory =
1019 new webrtc::MockVideoEncoderFactory();
1020 webrtc::MockVideoDecoderFactory* decoder_factory =
1021 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001022 WebRtcVideoEngine engine(
1023 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1024 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1025 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1026 EXPECT_EQ(0u, engine.codecs().size());
1027 EXPECT_CALL(*encoder_factory, Die());
1028 EXPECT_CALL(*decoder_factory, Die());
1029}
1030
1031// Test full behavior in the video engine when video codec factories of the new
1032// type are injected supporting the single codec Vp8. Check the returned codecs
1033// from the engine and that we will create a Vp8 encoder and decoder using the
1034// new factories.
1035TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1036 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001037 webrtc::MockVideoEncoderFactory* encoder_factory =
1038 new webrtc::MockVideoEncoderFactory();
1039 webrtc::MockVideoDecoderFactory* decoder_factory =
1040 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001041 WebRtcVideoEngine engine(
1042 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1043 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1044 const webrtc::SdpVideoFormat vp8_format("VP8");
1045 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1046 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1047 .WillRepeatedly(testing::Return(supported_formats));
1048
1049 // Verify the codecs from the engine.
1050 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001051 // Verify default codecs has been added correctly.
1052 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001053 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001054
1055 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001056 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001057 int vp8_associated_payload;
1058 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1059 &vp8_associated_payload));
1060 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1061
1062 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1063
1064 // RTX codec for RED.
1065 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1066 int red_associated_payload;
1067 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1068 &red_associated_payload));
1069 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1070
1071 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1072
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001073 int associated_payload_type;
1074 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1075 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1076 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1077 // Verify default parameters has been added to the VP8 codec.
1078 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
1079
1080 // Mock encoder creation. |engine| take ownership of the encoder.
1081 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1082 codec_info.is_hardware_accelerated = false;
1083 codec_info.has_internal_source = false;
1084 const webrtc::SdpVideoFormat format("VP8");
1085 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
1086 .WillRepeatedly(testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001087 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möller4db138e2018-04-19 09:04:13 +02001088 rtc::Event encoder_created(false, false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001089 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001090 .WillOnce(
1091 ::testing::DoAll(::testing::InvokeWithoutArgs(
1092 [&encoder_created]() { encoder_created.Set(); }),
1093 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001094
1095 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001096 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001097 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
1098 .WillOnce(testing::Return(decoder));
1099
1100 // Create a call.
1101 webrtc::RtcEventLogNullImpl event_log;
1102 std::unique_ptr<webrtc::Call> call(
1103 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1104
1105 // Create send channel.
1106 const int send_ssrc = 123;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001107 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateChannel(
1108 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001109 cricket::VideoSendParameters send_parameters;
1110 send_parameters.codecs.push_back(engine_codecs.at(0));
1111 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1112 send_channel->OnReadyToSend(true);
1113 EXPECT_TRUE(
1114 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1115 EXPECT_TRUE(send_channel->SetSend(true));
1116
Niels Möller4db138e2018-04-19 09:04:13 +02001117 // Set capturer.
1118 FakeVideoCapturerWithTaskQueue capturer;
1119 EXPECT_EQ(cricket::CS_RUNNING,
1120 capturer.Start(capturer.GetSupportedFormats()->front()));
1121 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &capturer));
1122 // Sending one frame will allocate the encoder.
1123 EXPECT_TRUE(capturer.CaptureFrame());
1124 encoder_created.Wait(kTimeout);
1125
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001126 // Create recv channel.
1127 const int recv_ssrc = 321;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001128 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateChannel(
1129 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001130 cricket::VideoRecvParameters recv_parameters;
1131 recv_parameters.codecs.push_back(engine_codecs.at(0));
1132 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1133 EXPECT_TRUE(recv_channel->AddRecvStream(
1134 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1135
1136 // Remove streams previously added to free the encoder and decoder instance.
1137 EXPECT_CALL(*encoder_factory, Die());
1138 EXPECT_CALL(*decoder_factory, Die());
1139 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1140 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1141}
1142
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001143// Test behavior when decoder factory fails to create a decoder (returns null).
1144TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1145 // |engine| take ownership of the factories.
1146 webrtc::MockVideoEncoderFactory* encoder_factory =
1147 new testing::StrictMock<webrtc::MockVideoEncoderFactory>();
1148 webrtc::MockVideoDecoderFactory* decoder_factory =
1149 new testing::StrictMock<webrtc::MockVideoDecoderFactory>();
1150 WebRtcVideoEngine engine(
1151 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1152 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1153 const webrtc::SdpVideoFormat vp8_format("VP8");
1154 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1155 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1156 .WillRepeatedly(testing::Return(supported_formats));
1157
1158 // Decoder creation fails.
1159 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(testing::_))
1160 .WillOnce(testing::Return(nullptr));
1161
1162 // Create a call.
1163 webrtc::RtcEventLogNullImpl event_log;
1164 std::unique_ptr<webrtc::Call> call(
1165 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1166
1167 // Create recv channel.
1168 const int recv_ssrc = 321;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001169 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateChannel(
1170 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001171 cricket::VideoRecvParameters recv_parameters;
1172 recv_parameters.codecs.push_back(engine.codecs().front());
1173 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1174 EXPECT_TRUE(recv_channel->AddRecvStream(
1175 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1176
1177 // Remove streams previously added to free the encoder and decoder instance.
1178 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1179}
1180
eladalonf1841382017-06-12 01:16:46 -07001181TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001182 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001183 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001184 std::unique_ptr<VideoMediaChannel> channel(
1185 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001186 ASSERT_TRUE(
1187 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1188 cricket::VideoCodec codec = GetEngineCodec("VP8");
1189 cricket::VideoSendParameters parameters;
1190 parameters.codecs.push_back(codec);
1191 channel->OnReadyToSend(true);
1192 channel->SetSend(true);
1193 ASSERT_TRUE(channel->SetSendParameters(parameters));
1194
Tommi85959932018-02-07 19:26:06 +01001195 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08001196 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02001197 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001198
1199 EXPECT_EQ(cricket::CS_RUNNING,
1200 capturer.Start(capturer.GetSupportedFormats()->front()));
1201 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001202 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001203 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001204 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001205
Niels Möllerff40b142018-04-09 08:49:14 +02001206 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001207 EXPECT_TRUE(capturer.CaptureFrame());
1208 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001209 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001210
1211 options.is_screencast.emplace(true);
Niels Möllerff40b142018-04-09 08:49:14 +02001212 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001213 EXPECT_TRUE(capturer.CaptureFrame());
1214 // Change to screen content, recreate encoder. For the simulcast encoder
1215 // adapter case, this will result in two calls since InitEncode triggers a
1216 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001217 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001218 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001219 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001220
Niels Möllerff40b142018-04-09 08:49:14 +02001221 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001222 EXPECT_TRUE(capturer.CaptureFrame());
1223 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001224 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001225
1226 options.is_screencast.emplace(false);
1227 options.video_noise_reduction.emplace(false);
Niels Möllerff40b142018-04-09 08:49:14 +02001228 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001229 // Change back to regular video content, update encoder. Also change
1230 // a non |is_screencast| option just to verify it doesn't affect recreation.
1231 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001232 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001233 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001234 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001235
1236 // Remove stream previously added to free the external encoder instance.
1237 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001238 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001239}
1240
Niels Möller6557d0c2018-04-11 15:18:34 +02001241class WebRtcVideoChannelBaseTest : public testing::Test {
1242 protected:
1243 WebRtcVideoChannelBaseTest()
Jonas Oreland49ac5952018-09-26 16:04:32 +02001244 : engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001245 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001246
1247 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001248 // One testcase calls SetUp in a loop, only create call_ once.
1249 if (!call_) {
1250 call_.reset(webrtc::Call::Create(webrtc::Call::Config(&event_log_)));
1251 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001252 cricket::MediaConfig media_config;
1253 // Disabling cpu overuse detection actually disables quality scaling too; it
1254 // implies DegradationPreference kMaintainResolution. Automatic scaling
1255 // needs to be disabled, otherwise, tests which check the size of received
1256 // frames become flaky.
1257 media_config.video.enable_cpu_adaptation = false;
1258 channel_.reset(engine_.CreateChannel(call_.get(), media_config,
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001259 cricket::VideoOptions(),
1260 webrtc::CryptoOptions()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001261 channel_->OnReadyToSend(true);
1262 EXPECT_TRUE(channel_.get() != NULL);
1263 network_interface_.SetDestination(channel_.get());
Anton Sukhanov98a462c2018-10-17 13:15:42 -07001264 channel_->SetInterface(&network_interface_, /*media_transport=*/nullptr);
Niels Möller6557d0c2018-04-11 15:18:34 +02001265 cricket::VideoRecvParameters parameters;
1266 parameters.codecs = engine_.codecs();
1267 channel_->SetRecvParameters(parameters);
1268 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
1269 video_capturer_.reset(CreateFakeVideoCapturer());
1270 cricket::VideoFormat format(640, 480,
1271 cricket::VideoFormat::FpsToInterval(kFramerate),
1272 cricket::FOURCC_I420);
1273 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001274 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001275 }
1276
1277 virtual cricket::FakeVideoCapturerWithTaskQueue* CreateFakeVideoCapturer() {
1278 return new cricket::FakeVideoCapturerWithTaskQueue();
1279 }
1280
1281 // Utility method to setup an additional stream to send and receive video.
1282 // Used to test send and recv between two streams.
1283 void SetUpSecondStream() {
1284 SetUpSecondStreamWithNoRecv();
1285 // Setup recv for second stream.
1286 EXPECT_TRUE(channel_->AddRecvStream(
1287 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1288 // Make the second renderer available for use by a new stream.
1289 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1290 }
1291 // Setup an additional stream just to send video. Defer add recv stream.
1292 // This is required if you want to test unsignalled recv of video rtp packets.
1293 void SetUpSecondStreamWithNoRecv() {
1294 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001295 EXPECT_TRUE(
1296 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001297 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001298 EXPECT_FALSE(
1299 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001300 EXPECT_TRUE(channel_->AddSendStream(
1301 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1302 // We dont add recv for the second stream.
1303
1304 // Setup the receive and renderer for second stream after send.
1305 video_capturer_2_.reset(CreateFakeVideoCapturer());
1306 cricket::VideoFormat format(640, 480,
1307 cricket::VideoFormat::FpsToInterval(kFramerate),
1308 cricket::FOURCC_I420);
1309 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(format));
1310
Yves Gerey665174f2018-06-19 15:03:05 +02001311 EXPECT_TRUE(
1312 channel_->SetVideoSend(kSsrc + 2, nullptr, video_capturer_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001313 }
Yves Gerey665174f2018-06-19 15:03:05 +02001314 virtual void TearDown() { channel_.reset(); }
1315 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001316
1317 bool SetOneCodec(const cricket::VideoCodec& codec) {
1318 cricket::VideoFormat capture_format(
1319 kVideoWidth, kVideoHeight,
1320 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1321
1322 if (video_capturer_) {
1323 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(capture_format));
1324 }
1325 if (video_capturer_2_) {
1326 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(capture_format));
1327 }
1328
1329 bool sending = channel_->sending();
1330 bool success = SetSend(false);
1331 if (success) {
1332 cricket::VideoSendParameters parameters;
1333 parameters.codecs.push_back(codec);
1334 success = channel_->SetSendParameters(parameters);
1335 }
1336 if (success) {
1337 success = SetSend(sending);
1338 }
1339 return success;
1340 }
Yves Gerey665174f2018-06-19 15:03:05 +02001341 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001342 bool SendFrame() {
1343 if (video_capturer_2_) {
1344 video_capturer_2_->CaptureFrame();
1345 }
1346 return video_capturer_.get() && video_capturer_->CaptureFrame();
1347 }
1348 bool WaitAndSendFrame(int wait_ms) {
1349 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
1350 ret &= SendFrame();
1351 return ret;
1352 }
Yves Gerey665174f2018-06-19 15:03:05 +02001353 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001354 int NumRtpBytes(uint32_t ssrc) {
1355 return network_interface_.NumRtpBytes(ssrc);
1356 }
Yves Gerey665174f2018-06-19 15:03:05 +02001357 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001358 int NumRtpPackets(uint32_t ssrc) {
1359 return network_interface_.NumRtpPackets(ssrc);
1360 }
Yves Gerey665174f2018-06-19 15:03:05 +02001361 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001362 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1363 return network_interface_.GetRtpPacket(index);
1364 }
1365 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001366 webrtc::RTPHeader header;
1367 EXPECT_TRUE(ParseRtpPacket(p, &header));
1368 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001369 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001370
Niels Möller6557d0c2018-04-11 15:18:34 +02001371 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001372 webrtc::RTPHeader* header) {
1373 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1374 webrtc::RtpHeaderParser::Create());
1375 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001376 }
1377
1378 // Tests that we can send and receive frames.
1379 void SendAndReceive(const cricket::VideoCodec& codec) {
1380 EXPECT_TRUE(SetOneCodec(codec));
1381 EXPECT_TRUE(SetSend(true));
1382 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1383 EXPECT_EQ(0, renderer_.num_rendered_frames());
1384 EXPECT_TRUE(SendFrame());
1385 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1386 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1387 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1388 }
1389
1390 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001391 int duration_sec,
1392 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001393 EXPECT_TRUE(SetOneCodec(codec));
1394 EXPECT_TRUE(SetSend(true));
1395 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1396 EXPECT_EQ(0, renderer_.num_rendered_frames());
1397 for (int i = 0; i < duration_sec; ++i) {
1398 for (int frame = 1; frame <= fps; ++frame) {
1399 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1400 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1401 }
1402 }
1403 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1404 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1405 }
1406
Niels Möller6557d0c2018-04-11 15:18:34 +02001407 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1408 cricket::VideoMediaInfo info;
1409 EXPECT_TRUE(channel_->GetStats(&info));
1410 return info.senders[i];
1411 }
1412
1413 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1414 cricket::VideoMediaInfo info;
1415 EXPECT_TRUE(channel_->GetStats(&info));
1416 return info.receivers[i];
1417 }
1418
1419 // Two streams one channel tests.
1420
1421 // Tests that we can send and receive frames.
1422 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1423 SetUpSecondStream();
1424 // Test sending and receiving on first stream.
1425 SendAndReceive(codec);
1426 // Test sending and receiving on second stream.
1427 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1428 EXPECT_GT(NumRtpPackets(), 0);
1429 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1430 }
1431
1432 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1433 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Oleh Prypin6e8e2992018-10-23 15:18:23 +02001434 if (CodecNamesEq(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001435 return engine_codec;
1436 }
1437 // This point should never be reached.
1438 ADD_FAILURE() << "Unrecognized codec name: " << name;
1439 return cricket::VideoCodec();
1440 }
1441
1442 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1443
1444 cricket::StreamParams DefaultSendStreamParams() {
1445 return cricket::StreamParams::CreateLegacy(kSsrc);
1446 }
1447
1448 webrtc::RtcEventLogNullImpl event_log_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001449 std::unique_ptr<webrtc::Call> call_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001450 WebRtcVideoEngine engine_;
1451 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_;
1452 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_2_;
1453 std::unique_ptr<WebRtcVideoChannel> channel_;
1454 cricket::FakeNetworkInterface network_interface_;
1455 cricket::FakeVideoRenderer renderer_;
1456
1457 // Used by test cases where 2 streams are run on the same channel.
1458 cricket::FakeVideoRenderer renderer2_;
1459};
1460
1461// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001462TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001463 EXPECT_FALSE(channel_->sending());
Yves Gerey665174f2018-06-19 15:03:05 +02001464 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001465 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1466 EXPECT_FALSE(channel_->sending());
1467 EXPECT_TRUE(SetSend(true));
1468 EXPECT_TRUE(channel_->sending());
1469 EXPECT_TRUE(SendFrame());
1470 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1471 EXPECT_TRUE(SetSend(false));
1472 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001473}
Niels Möller6557d0c2018-04-11 15:18:34 +02001474
1475// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001476TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001477 EXPECT_FALSE(channel_->sending());
1478 EXPECT_FALSE(SetSend(true));
1479 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001480}
Niels Möller6557d0c2018-04-11 15:18:34 +02001481
1482// Test that we properly set the send and recv buffer sizes by the time
1483// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001484TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001485 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1486 EXPECT_TRUE(SetSend(true));
1487 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001488 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001489}
1490
Niels Möller6557d0c2018-04-11 15:18:34 +02001491// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001492TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001493 const int kDurationSec = 3;
1494 const int kFps = 10;
1495 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1496
1497 cricket::VideoMediaInfo info;
1498 EXPECT_TRUE(channel_->GetStats(&info));
1499
1500 ASSERT_EQ(1U, info.senders.size());
1501 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1502 // For webrtc, bytes_sent does not include the RTP header length.
1503 EXPECT_GT(info.senders[0].bytes_sent, 0);
1504 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1505 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1506 ASSERT_TRUE(info.senders[0].codec_payload_type);
1507 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1508 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1509 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1510 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1511 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1512 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1513 EXPECT_GT(info.senders[0].framerate_input, 0);
1514 EXPECT_GT(info.senders[0].framerate_sent, 0);
1515
1516 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1517 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1518 info.send_codecs[DefaultCodec().id]);
1519
1520 ASSERT_EQ(1U, info.receivers.size());
1521 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1522 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1523 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1524 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1525 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1526 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1527 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1528 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1529 EXPECT_EQ(0, info.receivers[0].packets_lost);
1530 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1531 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1532 EXPECT_EQ(0, info.receivers[0].firs_sent);
1533 EXPECT_EQ(0, info.receivers[0].plis_sent);
1534 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1535 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1536 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1537 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1538 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1539 EXPECT_GT(info.receivers[0].framerate_output, 0);
1540
1541 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1542 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1543 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001544}
Niels Möller6557d0c2018-04-11 15:18:34 +02001545
1546// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001547TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001548 cricket::FakeVideoRenderer renderer1, renderer2;
1549 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1550 cricket::VideoSendParameters parameters;
1551 parameters.codecs.push_back(DefaultCodec());
1552 parameters.conference_mode = true;
1553 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1554 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001555 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1556 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001557 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1558 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1559 EXPECT_EQ(0, renderer1.num_rendered_frames());
1560 EXPECT_EQ(0, renderer2.num_rendered_frames());
1561 std::vector<uint32_t> ssrcs;
1562 ssrcs.push_back(1);
1563 ssrcs.push_back(2);
1564 network_interface_.SetConferenceMode(true, ssrcs);
1565 EXPECT_TRUE(SendFrame());
1566 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1567 kTimeout);
1568 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1569 kTimeout);
1570
1571 EXPECT_TRUE(channel_->SetSend(false));
1572
1573 cricket::VideoMediaInfo info;
1574 EXPECT_TRUE(channel_->GetStats(&info));
1575 ASSERT_EQ(1U, info.senders.size());
1576 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1577 // For webrtc, bytes_sent does not include the RTP header length.
1578 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1579 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1580 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1581 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1582
1583 ASSERT_EQ(2U, info.receivers.size());
1584 for (size_t i = 0; i < info.receivers.size(); ++i) {
1585 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1586 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1587 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001588 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001589 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1590 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1591 }
srtee0c2eea2017-12-15 17:44:33 +01001592}
Niels Möller6557d0c2018-04-11 15:18:34 +02001593
1594// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001595TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001596 // Normal setup; note that we set the SSRC explicitly to ensure that
1597 // it will come first in the senders map.
1598 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1599 cricket::VideoSendParameters parameters;
1600 parameters.codecs.push_back(DefaultCodec());
1601 parameters.conference_mode = true;
1602 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001603 EXPECT_TRUE(
1604 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001605 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1606 EXPECT_TRUE(SetSend(true));
1607 EXPECT_TRUE(SendFrame());
1608 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1609 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1610
1611 // Add an additional capturer, and hook up a renderer to receive it.
1612 cricket::FakeVideoRenderer renderer2;
1613 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1614 CreateFakeVideoCapturer());
1615 const int kTestWidth = 160;
1616 const int kTestHeight = 120;
1617 cricket::VideoFormat format(kTestWidth, kTestHeight,
1618 cricket::VideoFormat::FpsToInterval(5),
1619 cricket::FOURCC_I420);
1620 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001621 EXPECT_TRUE(
1622 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001623 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, capturer.get()));
Yves Gerey665174f2018-06-19 15:03:05 +02001624 EXPECT_TRUE(
1625 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001626 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
1627 EXPECT_TRUE(capturer->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001628 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1629 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001630
1631 // Get stats, and make sure they are correct for two senders. We wait until
1632 // the number of expected packets have been sent to avoid races where we
1633 // check stats before it has been updated.
1634 cricket::VideoMediaInfo info;
1635 for (uint32_t i = 0; i < kTimeout; ++i) {
1636 rtc::Thread::Current()->ProcessMessages(1);
1637 EXPECT_TRUE(channel_->GetStats(&info));
1638 ASSERT_EQ(2U, info.senders.size());
1639 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1640 NumRtpPackets()) {
1641 // Stats have been updated for both sent frames, expectations can be
1642 // checked now.
1643 break;
1644 }
1645 }
1646 EXPECT_EQ(NumRtpPackets(),
1647 info.senders[0].packets_sent + info.senders[1].packets_sent)
1648 << "Timed out while waiting for packet counts for all sent packets.";
1649 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1650 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1651 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1652 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1653 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1654 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1655 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1656 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1657 // The capturer must be unregistered here as it runs out of it's scope next.
1658 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001659}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001660
Niels Möller6557d0c2018-04-11 15:18:34 +02001661// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001662TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001663 cricket::VideoSendParameters parameters;
1664 parameters.codecs.push_back(DefaultCodec());
1665 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1666 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1667 parameters.max_bandwidth_bps = 128 * 1024;
1668 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001669}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001670
Niels Möller6557d0c2018-04-11 15:18:34 +02001671// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001672TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001673 EXPECT_TRUE(SetDefaultCodec());
1674 EXPECT_TRUE(SetSend(true));
1675 EXPECT_TRUE(SendFrame());
1676 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001677 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001678 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001679 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1680 EXPECT_EQ(kSsrc, header.ssrc);
1681
Niels Möller6557d0c2018-04-11 15:18:34 +02001682 // Packets are being paced out, so these can mismatch between the first and
1683 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001684 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1685 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001686 EXPECT_EQ(1, NumSentSsrcs());
1687 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1688 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001689}
Niels Möller6557d0c2018-04-11 15:18:34 +02001690
1691// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001692TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001693 // Remove stream added in Setup.
1694 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1695 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001696 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001697 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
1698 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001699 EXPECT_TRUE(SetSend(true));
1700 EXPECT_TRUE(WaitAndSendFrame(0));
1701 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001702 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001703 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001704 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1705 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001706 // Packets are being paced out, so these can mismatch between the first and
1707 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001708 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1709 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001710 EXPECT_EQ(1, NumSentSsrcs());
1711 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1712 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001713}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001714
Niels Möller6557d0c2018-04-11 15:18:34 +02001715// Test that we can set the default video renderer before and after
1716// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001717TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001718 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1719 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001720
1721 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1722 rtc::SetBE32(packet1.data() + 8, kSsrc);
1723 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1724 EXPECT_TRUE(SetDefaultCodec());
1725 EXPECT_TRUE(SetSend(true));
1726 EXPECT_EQ(0, renderer_.num_rendered_frames());
1727 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
1728 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1729 EXPECT_TRUE(SendFrame());
1730 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001731}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001732
Niels Möller6557d0c2018-04-11 15:18:34 +02001733// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001734TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001735 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1736 EXPECT_TRUE(SetSend(true));
1737 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1738 EXPECT_TRUE(SendFrame());
1739 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1740 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001741 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001742 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001743 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1744 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001745 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1746 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001747
1748 // Remove the send stream that was added during Setup.
1749 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1750 int rtp_packets = NumRtpPackets();
1751
Niels Möller6557d0c2018-04-11 15:18:34 +02001752 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001753 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
1754 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001755 EXPECT_EQ(rtp_packets, NumRtpPackets());
1756 // Wait 30ms to guarantee the engine does not drop the frame.
1757 EXPECT_TRUE(WaitAndSendFrame(30));
1758 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1759
1760 last_packet = NumRtpPackets() - 1;
1761 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001762 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1763 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001764}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001765
Niels Möller6557d0c2018-04-11 15:18:34 +02001766// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001767TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001768 cricket::FakeVideoRenderer renderer1, renderer2;
1769 EXPECT_TRUE(SetDefaultCodec());
1770 cricket::VideoSendParameters parameters;
1771 parameters.codecs.push_back(DefaultCodec());
1772 parameters.conference_mode = true;
1773 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1774 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001775 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1776 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001777 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1778 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1779 EXPECT_EQ(0, renderer1.num_rendered_frames());
1780 EXPECT_EQ(0, renderer2.num_rendered_frames());
1781 std::vector<uint32_t> ssrcs;
1782 ssrcs.push_back(1);
1783 ssrcs.push_back(2);
1784 network_interface_.SetConferenceMode(true, ssrcs);
1785 EXPECT_TRUE(SendFrame());
1786 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1787 kTimeout);
1788 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1789 kTimeout);
1790
1791 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1792 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1793 EXPECT_EQ(kVideoWidth, renderer1.width());
1794 EXPECT_EQ(kVideoHeight, renderer1.height());
1795 EXPECT_EQ(kVideoWidth, renderer2.width());
1796 EXPECT_EQ(kVideoHeight, renderer2.height());
1797 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1798 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001799}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001800
Niels Möller6557d0c2018-04-11 15:18:34 +02001801// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001802TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001803 using cricket::VideoCodec;
1804 using cricket::VideoOptions;
1805 using cricket::VideoFormat;
1806 using cricket::FOURCC_I420;
1807
1808 VideoCodec codec = DefaultCodec();
1809 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1810 EXPECT_TRUE(SetOneCodec(codec));
1811 EXPECT_TRUE(SetSend(true));
1812 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1813 EXPECT_EQ(0, renderer_.num_rendered_frames());
1814 EXPECT_TRUE(SendFrame());
1815 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1816 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1817 CreateFakeVideoCapturer());
1818
1819 // TODO(nisse): This testcase fails if we don't configure
1820 // screencast. It's unclear why, I see nothing obvious in this
1821 // test which is related to screencast logic.
1822 VideoOptions video_options;
1823 video_options.is_screencast = true;
1824 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1825
1826 VideoFormat format(480, 360, VideoFormat::FpsToInterval(30), FOURCC_I420);
1827 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
1828 // All capturers start generating frames with the same timestamp. ViE does
1829 // not allow the same timestamp to be used. Capture one frame before
1830 // associating the capturer with the channel.
1831 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1832
1833 int captured_frames = 1;
1834 for (int iterations = 0; iterations < 2; ++iterations) {
1835 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, capturer.get()));
1836 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
1837 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1838 ++captured_frames;
1839 // Wait until frame of right size is captured.
1840 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001841 format.width == renderer_.width() &&
1842 format.height == renderer_.height() &&
1843 !renderer_.black_frame(),
1844 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001845 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1846 EXPECT_EQ(format.width, renderer_.width());
1847 EXPECT_EQ(format.height, renderer_.height());
1848 captured_frames = renderer_.num_rendered_frames() + 1;
1849 EXPECT_FALSE(renderer_.black_frame());
1850 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1851 // Make sure a black frame is generated within the specified timeout.
1852 // The black frame should be the resolution of the previous frame to
1853 // prevent expensive encoder reconfigurations.
1854 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001855 format.width == renderer_.width() &&
1856 format.height == renderer_.height() &&
1857 renderer_.black_frame(),
1858 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001859 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1860 EXPECT_EQ(format.width, renderer_.width());
1861 EXPECT_EQ(format.height, renderer_.height());
1862 EXPECT_TRUE(renderer_.black_frame());
1863
1864 // The black frame has the same timestamp as the next frame since it's
1865 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1866 // not render a frame with the same timestamp so capture another frame
1867 // with the frame capturer to increment the next frame's timestamp.
1868 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1869 }
srtee0c2eea2017-12-15 17:44:33 +01001870}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001871
Niels Möller6557d0c2018-04-11 15:18:34 +02001872// Tests that if SetVideoSend is called with a NULL capturer after the
1873// capturer was already removed, the application doesn't crash (and no black
1874// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001875TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001876 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1877 EXPECT_TRUE(SetSend(true));
1878 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1879 EXPECT_EQ(0, renderer_.num_rendered_frames());
1880 EXPECT_TRUE(SendFrame());
1881 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1882 // Wait for one frame so they don't get dropped because we send frames too
1883 // tightly.
1884 rtc::Thread::Current()->ProcessMessages(30);
1885 // Remove the capturer.
1886 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1887
1888 // No capturer was added, so this SetVideoSend shouldn't do anything.
1889 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1890 rtc::Thread::Current()->ProcessMessages(300);
1891 // Verify no more frames were sent.
1892 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001893}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001894
Niels Möller6557d0c2018-04-11 15:18:34 +02001895// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001896TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001897 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1898 // interval time to avoid that.
1899 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1900 // interval time to avoid that.
1901 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001902 EXPECT_TRUE(
1903 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001904 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1905 cricket::VideoFormat capture_format(
1906 kVideoWidth, kVideoHeight,
1907 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1908 // Set up additional stream 1.
1909 cricket::FakeVideoRenderer renderer1;
1910 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001911 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001912 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001913 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001914 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer1(
1915 CreateFakeVideoCapturer());
1916 EXPECT_EQ(cricket::CS_RUNNING, capturer1->Start(capture_format));
1917 // Set up additional stream 2.
1918 cricket::FakeVideoRenderer renderer2;
1919 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001920 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001921 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001922 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001923 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer2(
1924 CreateFakeVideoCapturer());
1925 EXPECT_EQ(cricket::CS_RUNNING, capturer2->Start(capture_format));
1926 // State for all the streams.
1927 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1928 // A limitation in the lmi implementation requires that SetVideoSend() is
1929 // called after SetOneCodec().
1930 // TODO(hellner): this seems like an unnecessary constraint, fix it.
1931 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, capturer1.get()));
1932 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, capturer2.get()));
1933 EXPECT_TRUE(SetSend(true));
1934 // Test capturer associated with engine.
1935 const int kTestWidth = 160;
1936 const int kTestHeight = 120;
1937 EXPECT_TRUE(capturer1->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001938 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
1939 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001940 // Capture a frame with additional capturer2, frames should be received
1941 EXPECT_TRUE(capturer2->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001942 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1943 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001944 // Successfully remove the capturer.
1945 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1946 // The capturers must be unregistered here as it runs out of it's scope
1947 // next.
1948 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
1949 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01001950}
Niels Möller6557d0c2018-04-11 15:18:34 +02001951
1952// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01001953TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001954 // Remove the send stream that was added during Setup.
1955 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1956
1957 cricket::StreamParams empty;
1958 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02001959 EXPECT_TRUE(
1960 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01001961}
Niels Möller6557d0c2018-04-11 15:18:34 +02001962
1963// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01001964TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001965 // Remove stream added in Setup. I.e. remove stream corresponding to default
1966 // channel.
1967 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02001968 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02001969 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
1970 EXPECT_TRUE(channel_->AddSendStream(
1971 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
1972 }
1973 // Delete one of the non default channel streams, let the destructor delete
1974 // the remaining ones.
1975 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
1976 // Stream should already be deleted.
1977 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01001978}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00001979
eladalonf1841382017-06-12 01:16:46 -07001980TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08001981 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001982}
1983
eladalonf1841382017-06-12 01:16:46 -07001984TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08001985 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001986}
1987
eladalonf1841382017-06-12 01:16:46 -07001988TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08001989 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001990}
1991
eladalonf1841382017-06-12 01:16:46 -07001992TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02001993 // Set a high bitrate to not be downscaled by VP8 due to low initial start
1994 // bitrates. This currently happens at <250k, and two streams sharing 300k
1995 // initially will use QVGA instead of VGA.
1996 // TODO(pbos): Set up the quality scaler so that both senders reliably start
1997 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08001998 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02001999 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002000 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002001}
2002
eladalonf1841382017-06-12 01:16:46 -07002003class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002004 public:
eladalonf1841382017-06-12 01:16:46 -07002005 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2006 explicit WebRtcVideoChannelTest(const char* field_trials)
2007 : WebRtcVideoEngineTest(field_trials), last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002008 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002009 encoder_factory_->AddSupportedVideoCodecType("VP8");
2010 encoder_factory_->AddSupportedVideoCodecType("VP9");
2011#if defined(WEBRTC_USE_H264)
2012 encoder_factory_->AddSupportedVideoCodecType("H264");
2013#endif
2014
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002015 fake_call_.reset(new FakeCall());
kthelgason2bc68642017-02-07 07:02:22 -08002016 channel_.reset(engine_.CreateChannel(fake_call_.get(), GetMediaConfig(),
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002017 VideoOptions(),
2018 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002019 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002020 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002021 send_parameters_.codecs = engine_.codecs();
2022 recv_parameters_.codecs = engine_.codecs();
2023 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002024 }
2025
2026 protected:
2027 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002028 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002029 }
2030
2031 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002032 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002033 EXPECT_TRUE(channel_->AddSendStream(sp));
2034 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002035 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002036 EXPECT_EQ(num_streams + 1, streams.size());
2037 return streams[streams.size() - 1];
2038 }
2039
2040 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002041 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002042 }
2043
2044 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002045 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002046 }
2047
2048 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002049 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002050 EXPECT_TRUE(channel_->AddRecvStream(sp));
2051 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002052 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002053 EXPECT_EQ(num_streams + 1, streams.size());
2054 return streams[streams.size() - 1];
2055 }
2056
pbos@webrtc.org00873182014-11-25 14:03:34 +00002057 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2058 int expected_min_bitrate_bps,
2059 const char* start_bitrate_kbps,
2060 int expected_start_bitrate_bps,
2061 const char* max_bitrate_kbps,
2062 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002063 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2064 expected_start_bitrate_bps,
2065 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002066 auto& codecs = send_parameters_.codecs;
2067 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002068 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002069 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2070 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2071 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002072 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002073 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002074
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002075 void ExpectSetBitrateParameters(int min_bitrate_bps,
2076 int start_bitrate_bps,
2077 int max_bitrate_bps) {
2078 EXPECT_CALL(
2079 *fake_call_->GetMockTransportControllerSend(),
2080 SetSdpBitrateParameters(AllOf(
2081 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2082 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2083 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2084 }
2085
2086 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2087 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2088 SetSdpBitrateParameters(Field(
2089 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002090 }
2091
isheriff6f8d6862016-05-26 11:24:55 -07002092 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002093 // Enable extension.
2094 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002095 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002096 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002097 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002098 FakeVideoSendStream* send_stream =
2099 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2100
2101 // Verify the send extension id.
2102 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2103 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002104 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002105 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002106 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002107 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2108 // receivers.
2109 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2110 ->GetConfig()
2111 .rtp.extensions.empty());
2112
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002113 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002114 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002115 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2116 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002117 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2118
2119 // Verify that adding receive RTP header extensions adds them for existing
2120 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002121 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002122 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002123 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2124 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002125 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002126 }
2127
isheriff6f8d6862016-05-26 11:24:55 -07002128 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002129 // Enable extension.
2130 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002131 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002132 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002133 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002134
2135 FakeVideoReceiveStream* recv_stream =
2136 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2137
2138 // Verify the recv extension id.
2139 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2140 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002141 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002142 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002143 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002144
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002145 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2146 // senders.
2147 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2148 ->GetConfig()
2149 .rtp.extensions.empty());
2150
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002151 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002152 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002153 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2154 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002155 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2156
2157 // Verify that adding receive RTP header extensions adds them for existing
2158 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002159 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002160 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002161 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2162 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002163 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002164 }
2165
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002166 void TestExtensionFilter(const std::vector<std::string>& extensions,
2167 const std::string& expected_extension) {
2168 cricket::VideoSendParameters parameters = send_parameters_;
2169 int expected_id = -1;
2170 int id = 1;
2171 for (const std::string& extension : extensions) {
2172 if (extension == expected_extension)
2173 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002174 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002175 }
2176 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2177 FakeVideoSendStream* send_stream =
2178 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2179
2180 // Verify that only one of them has been set, and that it is the one with
2181 // highest priority (transport sequence number).
2182 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2183 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2184 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002185 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002186 }
2187
asapersson3c81a1a2017-06-14 05:52:21 -07002188 void TestDegradationPreference(bool resolution_scaling_enabled,
2189 bool fps_scaling_enabled);
2190
Erik Språngefbde372015-04-29 16:21:28 +02002191 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002192 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002193 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2194 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002195
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002196 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002197 uint32_t ssrc,
Tommi85959932018-02-07 19:26:06 +01002198 FakeVideoCapturerWithTaskQueue* capturer,
nisse0db023a2016-03-01 04:29:59 -08002199 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002200 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002201 options.video_noise_reduction = enabled;
Niels Möllerff40b142018-04-09 08:49:14 +02002202 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, capturer));
nisse0db023a2016-03-01 04:29:59 -08002203 // Options only take effect on the next frame.
2204 EXPECT_TRUE(capturer->CaptureFrame());
2205
Erik Språng143cec12015-04-28 10:01:41 +02002206 return fake_call_->GetVideoSendStreams().back();
2207 }
2208
Peter Boström2feafdb2015-09-09 14:32:14 +02002209 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2210 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002211 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002212 std::vector<uint32_t> ssrcs;
2213 std::vector<uint32_t> rtx_ssrcs;
2214 uint32_t num_streams = enabled ? 3 : 1;
2215 for (uint32_t i = 0; i < num_streams; ++i) {
2216 uint32_t ssrc = last_ssrc_ + i;
2217 ssrcs.push_back(ssrc);
2218 if (with_rtx) {
2219 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2220 }
Erik Språng143cec12015-04-28 10:01:41 +02002221 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002222 if (with_rtx) {
2223 return AddSendStream(
2224 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2225 }
2226 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002227 }
2228
perkjfa10b552016-10-02 23:45:26 -07002229 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002230 std::vector<FakeVideoSendStream*> streams =
2231 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002232 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002233 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002234 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002235 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002236 }
2237
perkjfa10b552016-10-02 23:45:26 -07002238 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002239 int stream_max,
2240 int expected_encoder_bitrate) {
2241 VideoSendParameters limited_send_params = send_parameters_;
2242 limited_send_params.max_bandwidth_bps = global_max;
2243 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002244 webrtc::RtpParameters parameters =
2245 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002246 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002247 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002248 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002249 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002250 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002251 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002252 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002253 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002254 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002255 }
2256
Åsa Persson55659812018-06-18 17:51:32 +02002257 // Values from kSimulcastConfigs in simulcast.cc.
2258 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2259 std::vector<webrtc::VideoStream> layers(3);
2260 layers[0].min_bitrate_bps = 30000;
2261 layers[0].target_bitrate_bps = 150000;
2262 layers[0].max_bitrate_bps = 200000;
2263 layers[1].min_bitrate_bps = 150000;
2264 layers[1].target_bitrate_bps = 500000;
2265 layers[1].max_bitrate_bps = 700000;
2266 layers[2].min_bitrate_bps = 600000;
2267 layers[2].target_bitrate_bps = 2500000;
2268 layers[2].max_bitrate_bps = 2500000;
2269 return layers;
2270 }
2271
kwiberg686a8ef2016-02-26 03:00:35 -08002272 std::unique_ptr<FakeCall> fake_call_;
2273 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002274 cricket::VideoSendParameters send_parameters_;
2275 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002276 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002277};
2278
eladalonf1841382017-06-12 01:16:46 -07002279TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002280 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002281 const std::string kSyncLabel = "AvSyncLabel";
2282
2283 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002284 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002285 EXPECT_TRUE(channel_->AddRecvStream(sp));
2286
Mirko Bonadeif859e552018-05-30 15:31:29 +02002287 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002288 EXPECT_EQ(kSyncLabel,
2289 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2290 << "SyncGroup should be set based on sync_label";
2291}
2292
eladalonf1841382017-06-12 01:16:46 -07002293TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002294 cricket::VideoSendParameters parameters;
2295 parameters.codecs = engine_.codecs();
2296 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002297 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002298 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002299 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002300
2301 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002302 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2303 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002304 FakeVideoSendStream* send_stream = AddSendStream(
2305 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2306
2307 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2308 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2309 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2310
2311 // Receiver side.
2312 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2313 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002314 EXPECT_FALSE(
2315 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002316 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002317 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002318 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002319 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002320 << "RTX should be mapped for the RED payload type";
2321
brandtr14742122017-01-27 04:53:07 -08002322 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002323}
2324
eladalonf1841382017-06-12 01:16:46 -07002325TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002326 // Setup one channel with an associated RTX stream.
2327 cricket::StreamParams params =
2328 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2329 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2330 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002331 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002332
2333 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2334 << "RTX should be mapped for all decoders/payload types.";
2335 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002336 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002337 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002338}
2339
eladalonf1841382017-06-12 01:16:46 -07002340TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002341 // Setup one channel without an associated RTX stream.
2342 cricket::StreamParams params =
2343 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2344 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002345 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002346}
2347
eladalonf1841382017-06-12 01:16:46 -07002348TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002349 FakeVideoSendStream* send_stream =
2350 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2351 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2352
2353 FakeVideoReceiveStream* recv_stream =
2354 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2355 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002356}
2357
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002358// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002359TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002360 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002361}
isheriff6f8d6862016-05-26 11:24:55 -07002362
eladalonf1841382017-06-12 01:16:46 -07002363TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002364 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002365}
2366
2367// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002368TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002369 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002370}
isheriff6f8d6862016-05-26 11:24:55 -07002371
eladalonf1841382017-06-12 01:16:46 -07002372TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002373 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002374}
2375
eladalonf1841382017-06-12 01:16:46 -07002376TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002377 // Enable three redundant extensions.
2378 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002379 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2380 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2381 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2382 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002383}
2384
eladalonf1841382017-06-12 01:16:46 -07002385TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002386 // Enable two redundant extensions.
2387 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002388 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2389 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2390 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002391}
2392
stefanc1aeaf02015-10-15 07:26:07 -07002393// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002394TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002395 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002396}
eladalonf1841382017-06-12 01:16:46 -07002397TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002398 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002399}
2400
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002401// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002402TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002403 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002404}
eladalonf1841382017-06-12 01:16:46 -07002405TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002406 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002407}
2408
eladalonf1841382017-06-12 01:16:46 -07002409TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002410 const int kAbsSendTimeId = 1;
2411 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002412 send_parameters_.extensions.push_back(
2413 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2414 send_parameters_.extensions.push_back(
2415 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002416
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002417 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002418 FakeVideoSendStream* send_stream =
2419 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2420
2421 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002422 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002423
2424 // Setting the same extensions (even if in different order) shouldn't
2425 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002426 std::reverse(send_parameters_.extensions.begin(),
2427 send_parameters_.extensions.end());
2428 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002429
2430 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2431
2432 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002433 send_parameters_.extensions.resize(1);
2434 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002435
2436 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2437}
2438
eladalonf1841382017-06-12 01:16:46 -07002439TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002440 const int kTOffsetId = 1;
2441 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002442 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002443 recv_parameters_.extensions.push_back(
2444 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2445 recv_parameters_.extensions.push_back(
2446 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2447 recv_parameters_.extensions.push_back(
2448 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002449
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002450 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002451 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002452 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2453
2454 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002455 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002456
2457 // Setting the same extensions (even if in different order) shouldn't
2458 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002459 std::reverse(recv_parameters_.extensions.begin(),
2460 recv_parameters_.extensions.end());
2461 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002462
2463 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2464
2465 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002466 recv_parameters_.extensions.resize(1);
2467 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002468
2469 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2470}
2471
eladalonf1841382017-06-12 01:16:46 -07002472TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002473 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002474 const int kUnsupportedId = 1;
2475 const int kTOffsetId = 2;
2476
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002477 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002478 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002479 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002480 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002481 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002482 FakeVideoSendStream* send_stream =
2483 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2484
2485 // Only timestamp offset extension is set to send stream,
2486 // unsupported rtp extension is ignored.
2487 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002488 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2489 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002490}
2491
eladalonf1841382017-06-12 01:16:46 -07002492TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002493 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002494 const int kUnsupportedId = 1;
2495 const int kTOffsetId = 2;
2496
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002497 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002498 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002499 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002500 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002501 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002502 FakeVideoReceiveStream* recv_stream =
2503 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2504
2505 // Only timestamp offset extension is set to receive stream,
2506 // unsupported rtp extension is ignored.
2507 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002508 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2509 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002510}
2511
eladalonf1841382017-06-12 01:16:46 -07002512TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002513 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002514 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002515 send_parameters_.extensions.push_back(
2516 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002517 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002518 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2519 }
2520}
2521
eladalonf1841382017-06-12 01:16:46 -07002522TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002523 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002524 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002525 recv_parameters_.extensions.push_back(
2526 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002527 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002528 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2529 }
2530}
2531
eladalonf1841382017-06-12 01:16:46 -07002532TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002533 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002534 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002535 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002536 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002537 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002538 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002539
2540 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002541 send_parameters_.extensions.clear();
2542 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002543 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002544 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2545 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002546}
2547
eladalonf1841382017-06-12 01:16:46 -07002548TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002549 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002550 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002551 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002552 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002553 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002554 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002555
2556 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002557 recv_parameters_.extensions.clear();
2558 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002559 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002560 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2561 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002562}
2563
eladalonf1841382017-06-12 01:16:46 -07002564TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002565 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002566 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002567}
2568
eladalonf1841382017-06-12 01:16:46 -07002569TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002570 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002571 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002572}
2573
eladalonf1841382017-06-12 01:16:46 -07002574TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002575 FakeVideoReceiveStream* stream = AddRecvStream();
2576 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002577}
2578
eladalonf1841382017-06-12 01:16:46 -07002579TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002580 FakeVideoReceiveStream* stream = AddRecvStream();
2581 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2582}
2583
eladalonf1841382017-06-12 01:16:46 -07002584TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002585 FakeVideoReceiveStream* stream = AddRecvStream();
2586 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2587
Peter Boström126c03e2015-05-11 12:48:12 +02002588 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002589 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002590 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002591 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2592 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002593 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002594 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2595
2596 // Verify that REMB is turned on when setting default codecs since the
2597 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002598 parameters.codecs = engine_.codecs();
2599 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002600 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002601 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002602}
2603
eladalonf1841382017-06-12 01:16:46 -07002604TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002605 FakeVideoReceiveStream* stream = AddRecvStream();
2606 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2607
2608 // Verify that transport cc feedback is turned off when send(!) codecs without
2609 // transport cc feedback are set.
2610 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002611 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002612 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2613 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2614 stream = fake_call_->GetVideoReceiveStreams()[0];
2615 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2616
2617 // Verify that transport cc feedback is turned on when setting default codecs
2618 // since the default codecs have transport cc feedback enabled.
2619 parameters.codecs = engine_.codecs();
2620 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2621 stream = fake_call_->GetVideoReceiveStreams()[0];
2622 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2623}
2624
eladalonf1841382017-06-12 01:16:46 -07002625TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002626 AssignDefaultCodec();
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002627 VerifyCodecHasDefaultFeedbackParams(default_codec_);
2628
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002629 cricket::VideoSendParameters parameters;
2630 parameters.codecs = engine_.codecs();
2631 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002632 EXPECT_TRUE(channel_->SetSend(true));
2633
2634 // Send side.
2635 FakeVideoSendStream* send_stream =
2636 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2637 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2638
2639 // Receiver side.
2640 FakeVideoReceiveStream* recv_stream =
2641 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2642 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2643
2644 // Nack history size should match between sender and receiver.
2645 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2646 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002647}
2648
eladalonf1841382017-06-12 01:16:46 -07002649TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002650 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002651 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002652
2653 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2654 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2655
2656 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002657 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002658 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002659 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2660 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002661 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2662 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2663 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002664 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2665
Peter Boström67c9df72015-05-11 14:34:58 +02002666 // Verify that NACK is turned on when setting default codecs since the
2667 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002668 parameters.codecs = engine_.codecs();
2669 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002670 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2671 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2672 send_stream = fake_call_->GetVideoSendStreams()[0];
2673 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002674}
2675
Peter Boströme7ba0862016-03-12 00:02:28 +01002676// This test verifies that new frame sizes reconfigures encoders even though not
2677// (yet) sending. The purpose of this is to permit encoding as quickly as
2678// possible once we start sending. Likely the frames being input are from the
2679// same source that will be sent later, which just means that we're ready
2680// earlier.
eladalonf1841382017-06-12 01:16:46 -07002681TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002682 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002683 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002684 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2685 channel_->SetSend(false);
2686
2687 FakeVideoSendStream* stream = AddSendStream();
2688
perkjfa10b552016-10-02 23:45:26 -07002689 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002690 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002691 EXPECT_EQ(0u, streams[0].width);
2692 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002693
Tommi85959932018-02-07 19:26:06 +01002694 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002695 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj26752742016-10-24 01:21:16 -07002696 VideoFormat capture_format = capturer.GetSupportedFormats()->front();
2697 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
Peter Boströme7ba0862016-03-12 00:02:28 +01002698 EXPECT_TRUE(capturer.CaptureFrame());
2699
2700 // Frame entered, should be reconfigured to new dimensions.
2701 streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002702 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.width), streams[0].width);
2703 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.height),
2704 streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002705
Niels Möllerff40b142018-04-09 08:49:14 +02002706 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002707}
2708
eladalonf1841382017-06-12 01:16:46 -07002709TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002710 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002711 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002712 cricket::VideoSendParameters parameters;
2713 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002714 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002715 AddSendStream();
2716
Tommi85959932018-02-07 19:26:06 +01002717 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07002718 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002719 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Yves Gerey665174f2018-06-19 15:03:05 +02002720 EXPECT_TRUE(
2721 channel_->SetVideoSend(last_ssrc_, &min_bitrate_options, &capturer));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002722 cricket::VideoFormat capture_format_hd =
2723 capturer.GetSupportedFormats()->front();
2724 EXPECT_EQ(1280, capture_format_hd.width);
2725 EXPECT_EQ(720, capture_format_hd.height);
2726 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2727
2728 EXPECT_TRUE(channel_->SetSend(true));
2729
2730 EXPECT_TRUE(capturer.CaptureFrame());
2731 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2732 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2733
2734 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2735
2736 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002737 webrtc::VideoEncoderConfig encoder_config =
2738 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002739 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002740 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002741 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002742 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2743 streams.front().width);
2744 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2745 streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002746 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2747 << "Non-screenshare shouldn't use min-transmit bitrate.";
2748
Niels Möllerff40b142018-04-09 08:49:14 +02002749 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002750 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002751 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002752 screencast_options.is_screencast = true;
deadbeef5a4a75a2016-06-02 16:23:38 -07002753 EXPECT_TRUE(
Niels Möllerff40b142018-04-09 08:49:14 +02002754 channel_->SetVideoSend(last_ssrc_, &screencast_options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08002755 EXPECT_TRUE(capturer.CaptureFrame());
sprangf24a0642017-02-28 13:23:26 -08002756 // Send stream recreated after option change.
2757 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2758 send_stream = fake_call_->GetVideoSendStreams().front();
2759 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002760
2761 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002762 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002763 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002764 encoder_config.content_type);
2765 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2766 encoder_config.min_transmit_bitrate_bps);
2767
perkjfa10b552016-10-02 23:45:26 -07002768 streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002769 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2770 streams.front().width);
2771 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2772 streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002773 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002774 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002775}
2776
eladalonf1841382017-06-12 01:16:46 -07002777TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002778 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002779 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002780 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002781 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002782
2783 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002784 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002785 options.is_screencast = true;
Tommi85959932018-02-07 19:26:06 +01002786 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002787 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002788 cricket::VideoFormat capture_format_hd =
2789 capturer.GetSupportedFormats()->front();
2790 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2791
2792 EXPECT_TRUE(channel_->SetSend(true));
2793
2794 EXPECT_TRUE(capturer.CaptureFrame());
2795 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2796 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2797
perkj26091b12016-09-01 01:17:40 -07002798 webrtc::VideoEncoderConfig encoder_config =
2799 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002800
2801 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002802 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002803 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002804 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002805
2806 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2807 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002808 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002809 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002810 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002811
Niels Möllerff40b142018-04-09 08:49:14 +02002812 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002813}
2814
eladalonf1841382017-06-12 01:16:46 -07002815TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002816 FakeVideoSendStream* stream = AddSendStream();
2817 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2818}
2819
eladalonf1841382017-06-12 01:16:46 -07002820TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002821 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002822 media_config.video.suspend_below_min_bitrate = true;
2823
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002824 channel_.reset(engine_.CreateChannel(
2825 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002826 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002827
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002828 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002829
2830 FakeVideoSendStream* stream = AddSendStream();
2831 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2832
nisse0db023a2016-03-01 04:29:59 -08002833 media_config.video.suspend_below_min_bitrate = false;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002834 channel_.reset(engine_.CreateChannel(
2835 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002836 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002837
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002838 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002839
nisse0db023a2016-03-01 04:29:59 -08002840 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002841 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2842}
2843
eladalonf1841382017-06-12 01:16:46 -07002844TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002845 FakeVideoSendStream* stream = AddSendStream();
2846 webrtc::VideoCodecVP8 vp8_settings;
2847 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2848 EXPECT_TRUE(vp8_settings.denoisingOn);
2849}
2850
eladalonf1841382017-06-12 01:16:46 -07002851TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002852 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002853 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002854 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002855
Peter Boström2feafdb2015-09-09 14:32:14 +02002856 // Single-stream settings should apply with RTX as well (verifies that we
2857 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2858 // both RTX and regular SSRCs).
2859 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002860
Tommi85959932018-02-07 19:26:06 +01002861 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002862 EXPECT_EQ(cricket::CS_RUNNING,
2863 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002864 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002865 channel_->SetSend(true);
2866
2867 EXPECT_TRUE(capturer.CaptureFrame());
2868
pbos4cba4eb2015-10-26 11:18:18 -07002869 webrtc::VideoCodecVP8 vp8_settings;
2870 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2871 EXPECT_TRUE(vp8_settings.denoisingOn)
2872 << "VP8 denoising should be on by default.";
2873
nisse05103312016-03-16 02:22:50 -07002874 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002875
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002876 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2877 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002878 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2879 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002880
nisse05103312016-03-16 02:22:50 -07002881 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002882
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002883 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2884 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002885 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2886 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2887
Niels Möllerff40b142018-04-09 08:49:14 +02002888 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002889 stream = SetUpSimulcast(true, false);
Niels Möllerff40b142018-04-09 08:49:14 +02002890 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002891 channel_->SetSend(true);
2892 EXPECT_TRUE(capturer.CaptureFrame());
2893
Mirko Bonadeif859e552018-05-30 15:31:29 +02002894 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002895 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2896 // Autmatic resize off when using simulcast.
2897 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2898 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2899
2900 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002901 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002902 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002903 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
Niels Möller60653ba2016-03-02 11:41:36 +01002904
nisse05103312016-03-16 02:22:50 -07002905 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002906
Mirko Bonadeif859e552018-05-30 15:31:29 +02002907 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002908 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2909 EXPECT_FALSE(vp8_settings.denoisingOn);
2910 // Resizing and frame dropping always off for screen sharing.
2911 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2912 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2913
nisse05103312016-03-16 02:22:50 -07002914 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02002915
2916 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2917 EXPECT_FALSE(vp8_settings.denoisingOn);
2918 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2919 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2920
Niels Möllerff40b142018-04-09 08:49:14 +02002921 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02002922}
2923
deadbeef119760a2016-04-04 11:43:27 -07002924// Test that setting the same options doesn't result in the encoder being
2925// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07002926TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07002927 VideoOptions options;
Tommi85959932018-02-07 19:26:06 +01002928 FakeVideoCapturerWithTaskQueue capturer;
deadbeef119760a2016-04-04 11:43:27 -07002929
perkjfa10b552016-10-02 23:45:26 -07002930 AddSendStream();
deadbeef119760a2016-04-04 11:43:27 -07002931 EXPECT_EQ(cricket::CS_RUNNING,
2932 capturer.Start(capturer.GetSupportedFormats()->front()));
perkjfa10b552016-10-02 23:45:26 -07002933 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002934 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07002935 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2936 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2937
Niels Möllerff40b142018-04-09 08:49:14 +02002938 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
2939 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002940 EXPECT_TRUE(capturer.CaptureFrame());
perkjfa10b552016-10-02 23:45:26 -07002941 // Expect 1 reconfigurations at this point from the initial configuration.
2942 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07002943
2944 // Set the options one more time and expect no additional reconfigurations.
Niels Möllerff40b142018-04-09 08:49:14 +02002945 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkjfa10b552016-10-02 23:45:26 -07002946 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
2947
2948 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01002949 options.video_noise_reduction = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002950 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002951 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
2952
Niels Möllerff40b142018-04-09 08:49:14 +02002953 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07002954}
2955
eladalonf1841382017-06-12 01:16:46 -07002956class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02002957 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07002958 Vp9SettingsTest() : Vp9SettingsTest("") {}
2959 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07002960 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02002961 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02002962 }
2963 virtual ~Vp9SettingsTest() {}
2964
2965 protected:
Erik Språng143cec12015-04-28 10:01:41 +02002966 void TearDown() override {
2967 // Remove references to encoder_factory_ since this will be destroyed
2968 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002969 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02002970 }
Erik Språng143cec12015-04-28 10:01:41 +02002971};
2972
2973TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002974 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002975 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002976 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02002977
Peter Boström2feafdb2015-09-09 14:32:14 +02002978 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02002979
Tommi85959932018-02-07 19:26:06 +01002980 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002981 EXPECT_EQ(cricket::CS_RUNNING,
2982 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002983 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002984 channel_->SetSend(true);
2985
2986 EXPECT_TRUE(capturer.CaptureFrame());
2987
pbos4cba4eb2015-10-26 11:18:18 -07002988 webrtc::VideoCodecVP9 vp9_settings;
2989 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07002990 EXPECT_TRUE(vp9_settings.denoisingOn)
2991 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07002992
nisse05103312016-03-16 02:22:50 -07002993 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002994
Erik Språng143cec12015-04-28 10:01:41 +02002995 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2996 EXPECT_FALSE(vp9_settings.denoisingOn);
2997 // Frame dropping always on for real time video.
2998 EXPECT_TRUE(vp9_settings.frameDroppingOn);
2999
nisse05103312016-03-16 02:22:50 -07003000 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02003001
3002 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3003 EXPECT_TRUE(vp9_settings.denoisingOn);
3004 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3005
3006 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003007 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003008 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02003009 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003010
nisse05103312016-03-16 02:22:50 -07003011 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003012
3013 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3014 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003015 // Frame dropping always on for screen sharing.
3016 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003017
nisse05103312016-03-16 02:22:50 -07003018 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003019
3020 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3021 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003022 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003023
Niels Möllerff40b142018-04-09 08:49:14 +02003024 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003025}
3026
Sergey Silkinf18072e2018-03-14 10:35:35 +01003027TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3028 cricket::VideoSendParameters parameters;
3029 parameters.codecs.push_back(GetEngineCodec("VP9"));
3030 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3031
3032 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3033
3034 FakeVideoSendStream* stream =
3035 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3036
3037 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3038 EXPECT_EQ(ssrcs.size(), config.rtp.ssrcs.size());
3039
3040 FakeVideoCapturerWithTaskQueue capturer;
3041 EXPECT_EQ(cricket::CS_RUNNING,
3042 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003043 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &capturer));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003044 channel_->SetSend(true);
3045
3046 EXPECT_TRUE(capturer.CaptureFrame());
3047
3048 webrtc::VideoCodecVP9 vp9_settings;
3049 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3050
3051 const size_t kNumSpatialLayers = ssrcs.size();
3052 const size_t kNumTemporalLayers = 3;
3053 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3054 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3055
Niels Möllerff40b142018-04-09 08:49:14 +02003056 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003057}
3058
asaperssonc5dabdd2016-03-21 04:15:50 -07003059class Vp9SettingsTestWithFieldTrial : public Vp9SettingsTest {
3060 public:
brandtr468da7c2016-11-22 02:16:47 -08003061 explicit Vp9SettingsTestWithFieldTrial(const char* field_trials)
asaperssonc5dabdd2016-03-21 04:15:50 -07003062 : Vp9SettingsTest(field_trials) {}
3063
3064 protected:
3065 void VerifySettings(int num_spatial_layers, int num_temporal_layers) {
3066 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003067 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003068 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3069
3070 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3071
Tommi85959932018-02-07 19:26:06 +01003072 FakeVideoCapturerWithTaskQueue capturer;
asaperssonc5dabdd2016-03-21 04:15:50 -07003073 EXPECT_EQ(cricket::CS_RUNNING,
3074 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003075 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
asaperssonc5dabdd2016-03-21 04:15:50 -07003076 channel_->SetSend(true);
3077
3078 EXPECT_TRUE(capturer.CaptureFrame());
3079
3080 webrtc::VideoCodecVP9 vp9_settings;
3081 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3082 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3083 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
3084
Niels Möllerff40b142018-04-09 08:49:14 +02003085 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003086 }
3087};
3088
3089class Vp9SettingsTestWithNoFlag : public Vp9SettingsTestWithFieldTrial {
3090 public:
3091 Vp9SettingsTestWithNoFlag() : Vp9SettingsTestWithFieldTrial("") {}
3092};
3093
3094TEST_F(Vp9SettingsTestWithNoFlag, VerifySettings) {
3095 const int kNumSpatialLayers = 1;
3096 const int kNumTemporalLayers = 1;
3097 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3098}
3099
3100class Vp9SettingsTestWithInvalidFlag : public Vp9SettingsTestWithFieldTrial {
3101 public:
3102 Vp9SettingsTestWithInvalidFlag()
3103 : Vp9SettingsTestWithFieldTrial("WebRTC-SupportVP9SVC/Default/") {}
3104};
3105
3106TEST_F(Vp9SettingsTestWithInvalidFlag, VerifySettings) {
3107 const int kNumSpatialLayers = 1;
3108 const int kNumTemporalLayers = 1;
3109 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3110}
3111
3112class Vp9SettingsTestWith2SL3TLFlag : public Vp9SettingsTestWithFieldTrial {
3113 public:
3114 Vp9SettingsTestWith2SL3TLFlag()
3115 : Vp9SettingsTestWithFieldTrial(
3116 "WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/") {}
3117};
3118
3119TEST_F(Vp9SettingsTestWith2SL3TLFlag, VerifySettings) {
3120 const int kNumSpatialLayers = 2;
3121 const int kNumTemporalLayers = 3;
3122 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3123}
3124
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003125TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3126 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3127 ASSERT_EQ(1u, streams.size());
3128 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3129}
3130
3131TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
3132 webrtc::test::ScopedFieldTrials override_field_trials_(
3133 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3134 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3135 ASSERT_EQ(1u, streams.size());
3136 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3137}
3138
asapersson3c81a1a2017-06-14 05:52:21 -07003139TEST_F(WebRtcVideoChannelTest,
3140 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
3141 webrtc::test::ScopedFieldTrials override_field_trials_(
3142 "WebRTC-Video-BalancedDegradation/Disabled/");
3143 const bool kResolutionScalingEnabled = true;
3144 const bool kFpsScalingEnabled = false;
3145 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3146}
3147
3148TEST_F(WebRtcVideoChannelTest,
3149 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
3150 webrtc::test::ScopedFieldTrials override_field_trials_(
3151 "WebRTC-Video-BalancedDegradation/Enabled/");
3152 const bool kResolutionScalingEnabled = true;
3153 const bool kFpsScalingEnabled = true;
3154 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3155}
3156
eladalonf1841382017-06-12 01:16:46 -07003157TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003158 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003159}
3160
eladalonf1841382017-06-12 01:16:46 -07003161TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003162 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003163}
3164
eladalonf1841382017-06-12 01:16:46 -07003165TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003166 TestCpuAdaptation(true, true);
3167}
3168
eladalonf1841382017-06-12 01:16:46 -07003169TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruseAndChangeResolution) {
magjed509e4fe2016-11-18 01:34:11 -08003170 cricket::VideoCodec codec = GetEngineCodec("VP8");
perkj2d5f0912016-02-29 00:04:41 -08003171 cricket::VideoSendParameters parameters;
3172 parameters.codecs.push_back(codec);
3173
kthelgason2bc68642017-02-07 07:02:22 -08003174 MediaConfig media_config = GetMediaConfig();
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003175 channel_.reset(engine_.CreateChannel(
3176 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003177 channel_->OnReadyToSend(true);
perkj2d5f0912016-02-29 00:04:41 -08003178 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3179
3180 AddSendStream();
3181
Tommi85959932018-02-07 19:26:06 +01003182 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003183 ASSERT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003184 ASSERT_EQ(cricket::CS_RUNNING,
3185 capturer.Start(capturer.GetSupportedFormats()->front()));
3186 ASSERT_TRUE(channel_->SetSend(true));
3187
3188 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3189 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003190
Niels Möllera6cc0f92018-02-12 17:14:55 +01003191 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003192 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3193 EXPECT_EQ(1280, send_stream->GetLastWidth());
3194 EXPECT_EQ(720, send_stream->GetLastHeight());
3195
3196 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003197 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003198 wants.max_pixel_count =
3199 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003200 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003201 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003202 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3203 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3204 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3205
3206 // Trigger overuse again.
sprangc5d62e22017-04-02 23:53:04 -07003207 wants.max_pixel_count =
3208 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003209 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003210 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003211 EXPECT_EQ(3, send_stream->GetNumberOfSwappedFrames());
3212 EXPECT_EQ(1280 * 2 / 4, send_stream->GetLastWidth());
3213 EXPECT_EQ(720 * 2 / 4, send_stream->GetLastHeight());
3214
3215 // Change input resolution.
Niels Möllera6cc0f92018-02-12 17:14:55 +01003216 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003217 EXPECT_EQ(4, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003218 EXPECT_EQ(1284 / 2, send_stream->GetLastWidth());
3219 EXPECT_EQ(724 / 2, send_stream->GetLastHeight());
3220
3221 // Trigger underuse which should go back up in resolution.
sprang84a37592017-02-10 07:04:27 -08003222 int current_pixel_count =
3223 send_stream->GetLastWidth() * send_stream->GetLastHeight();
3224 // Cap the max to 4x the pixel count (assuming max 1/2 x 1/2 scale downs)
3225 // of the current stream, so we don't take too large steps.
sprangc5d62e22017-04-02 23:53:04 -07003226 wants.max_pixel_count = current_pixel_count * 4;
sprang84a37592017-02-10 07:04:27 -08003227 // Default step down is 3/5 pixel count, so go up by 5/3.
Oskar Sundbom78807582017-11-16 11:09:55 +01003228 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003229 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003230 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003231 EXPECT_EQ(5, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003232 EXPECT_EQ(1284 * 3 / 4, send_stream->GetLastWidth());
3233 EXPECT_EQ(724 * 3 / 4, send_stream->GetLastHeight());
3234
sprang84a37592017-02-10 07:04:27 -08003235 // Trigger underuse again, should go back up to full resolution.
3236 current_pixel_count =
3237 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003238 wants.max_pixel_count = current_pixel_count * 4;
Oskar Sundbom78807582017-11-16 11:09:55 +01003239 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003240 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003241 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003242 EXPECT_EQ(6, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003243 EXPECT_EQ(1284, send_stream->GetLastWidth());
3244 EXPECT_EQ(724, send_stream->GetLastHeight());
3245
Niels Möllerff40b142018-04-09 08:49:14 +02003246 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003247}
3248
eladalonf1841382017-06-12 01:16:46 -07003249TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003250 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003251 cricket::VideoSendParameters parameters;
3252 parameters.codecs.push_back(codec);
3253
kthelgason2bc68642017-02-07 07:02:22 -08003254 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003255 media_config.video.enable_cpu_adaptation = true;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003256 channel_.reset(engine_.CreateChannel(
3257 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003258 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003259 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3260
3261 AddSendStream();
3262
Tommi85959932018-02-07 19:26:06 +01003263 FakeVideoCapturerWithTaskQueue capturer;
Per766ad3b2016-04-05 15:23:49 +02003264 ASSERT_EQ(cricket::CS_RUNNING,
3265 capturer.Start(capturer.GetSupportedFormats()->front()));
3266 ASSERT_TRUE(channel_->SetSend(true));
3267 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003268 camera_options.is_screencast = false;
Yves Gerey665174f2018-06-19 15:03:05 +02003269 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
Per766ad3b2016-04-05 15:23:49 +02003270
3271 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3272 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003273
Niels Möllera6cc0f92018-02-12 17:14:55 +01003274 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003275 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3276 EXPECT_EQ(1280, send_stream->GetLastWidth());
3277 EXPECT_EQ(720, send_stream->GetLastHeight());
3278
3279 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003280 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003281 wants.max_pixel_count =
3282 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003283 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003284 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003285 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3286 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3287 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3288
3289 // Switch to screen share. Expect no CPU adaptation.
Tommi85959932018-02-07 19:26:06 +01003290 FakeVideoCapturerWithTaskQueue screen_share(true);
Per766ad3b2016-04-05 15:23:49 +02003291 ASSERT_EQ(cricket::CS_RUNNING,
3292 screen_share.Start(screen_share.GetSupportedFormats()->front()));
Per766ad3b2016-04-05 15:23:49 +02003293 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003294 screenshare_options.is_screencast = true;
Yves Gerey665174f2018-06-19 15:03:05 +02003295 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &screen_share);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003296 EXPECT_TRUE(screen_share.CaptureCustomFrame(1284, 724));
sprangf24a0642017-02-28 13:23:26 -08003297 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3298 send_stream = fake_call_->GetVideoSendStreams().front();
3299 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003300 EXPECT_EQ(1284, send_stream->GetLastWidth());
3301 EXPECT_EQ(724, send_stream->GetLastHeight());
3302
3303 // Switch back to the normal capturer. Expect the frame to be CPU adapted.
Yves Gerey665174f2018-06-19 15:03:05 +02003304 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
sprangf24a0642017-02-28 13:23:26 -08003305 send_stream = fake_call_->GetVideoSendStreams().front();
3306 // We have a new fake send stream, so it doesn't remember the old sink wants.
3307 // In practice, it will be populated from
mflodmancc3d4422017-08-03 08:27:51 -07003308 // VideoStreamEncoder::VideoSourceProxy::SetSource(), so simulate that here.
sprangf24a0642017-02-28 13:23:26 -08003309 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003310 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
sprangf24a0642017-02-28 13:23:26 -08003311 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3312 send_stream = fake_call_->GetVideoSendStreams().front();
3313 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003314 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3315 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3316
Niels Möllerff40b142018-04-09 08:49:14 +02003317 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003318}
3319
asapersson3c81a1a2017-06-14 05:52:21 -07003320// TODO(asapersson): Remove this test when the balanced field trial is removed.
3321void WebRtcVideoChannelTest::TestDegradationPreference(
3322 bool resolution_scaling_enabled,
3323 bool fps_scaling_enabled) {
3324 cricket::VideoCodec codec = GetEngineCodec("VP8");
3325 cricket::VideoSendParameters parameters;
3326 parameters.codecs.push_back(codec);
3327
3328 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003329 media_config.video.enable_cpu_adaptation = true;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003330 channel_.reset(engine_.CreateChannel(
3331 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
asapersson3c81a1a2017-06-14 05:52:21 -07003332 channel_->OnReadyToSend(true);
3333
3334 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3335
3336 AddSendStream();
3337
Tommi85959932018-02-07 19:26:06 +01003338 FakeVideoCapturerWithTaskQueue capturer;
asapersson3c81a1a2017-06-14 05:52:21 -07003339 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02003340 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
asapersson3c81a1a2017-06-14 05:52:21 -07003341 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
3342 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
3343
3344 EXPECT_TRUE(channel_->SetSend(true));
3345
3346 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3347 EXPECT_EQ(resolution_scaling_enabled,
3348 send_stream->resolution_scaling_enabled());
3349 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3350
Niels Möllerff40b142018-04-09 08:49:14 +02003351 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003352}
3353
eladalonf1841382017-06-12 01:16:46 -07003354void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3355 bool is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003356 const int kDefaultFps = 30;
magjed509e4fe2016-11-18 01:34:11 -08003357 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003358 cricket::VideoSendParameters parameters;
3359 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003360
kthelgason2bc68642017-02-07 07:02:22 -08003361 MediaConfig media_config = GetMediaConfig();
3362 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003363 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003364 }
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003365 channel_.reset(engine_.CreateChannel(
3366 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003367 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003368
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003369 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003370
3371 AddSendStream();
3372
Tommi85959932018-02-07 19:26:06 +01003373 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07003374 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003375 options.is_screencast = is_screenshare;
Niels Möllerff40b142018-04-09 08:49:14 +02003376 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj26752742016-10-24 01:21:16 -07003377 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
sprangc5d62e22017-04-02 23:53:04 -07003378 capture_format.interval = rtc::kNumNanosecsPerSec / kDefaultFps;
perkj26752742016-10-24 01:21:16 -07003379 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003380
3381 EXPECT_TRUE(channel_->SetSend(true));
3382
solenberge5269742015-09-08 05:13:22 -07003383 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003384
sprangc5d62e22017-04-02 23:53:04 -07003385 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003386 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003387 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3388 EXPECT_EQ(is_screenshare, send_stream->framerate_scaling_enabled());
perkj2d5f0912016-02-29 00:04:41 -08003389
3390 EXPECT_TRUE(capturer.CaptureFrame());
3391 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3392
perkj26752742016-10-24 01:21:16 -07003393 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3394 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
perkj2d5f0912016-02-29 00:04:41 -08003395
Niels Möllerff40b142018-04-09 08:49:14 +02003396 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003397 return;
3398 }
3399
sprangc5d62e22017-04-02 23:53:04 -07003400 if (is_screenshare) {
3401 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3402 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3403 } else {
3404 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3405 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3406 }
3407
perkj803d97f2016-11-01 11:45:46 -07003408 // Trigger overuse.
3409 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3410
3411 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003412 if (is_screenshare) {
3413 wants.max_framerate_fps = (kDefaultFps * 2) / 3;
3414 } else {
3415 wants.max_pixel_count = capture_format.width * capture_format.height - 1;
3416 }
perkj803d97f2016-11-01 11:45:46 -07003417 send_stream->InjectVideoSinkWants(wants);
3418
sprangc5d62e22017-04-02 23:53:04 -07003419 for (int i = 0; i < kDefaultFps; ++i)
3420 EXPECT_TRUE(capturer.CaptureFrame());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003421
sprangc5d62e22017-04-02 23:53:04 -07003422 if (is_screenshare) {
3423 // Drops every third frame.
3424 EXPECT_EQ(kDefaultFps * 2 / 3, send_stream->GetNumberOfSwappedFrames());
3425 EXPECT_EQ(send_stream->GetLastWidth(), capture_format.width);
3426 EXPECT_EQ(send_stream->GetLastHeight(), capture_format.height);
3427 } else {
3428 EXPECT_EQ(kDefaultFps, send_stream->GetNumberOfSwappedFrames());
3429 EXPECT_LT(send_stream->GetLastWidth(), capture_format.width);
3430 EXPECT_LT(send_stream->GetLastHeight(), capture_format.height);
3431 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003432
3433 // Trigger underuse which should go back to normal resolution.
sprang84a37592017-02-10 07:04:27 -08003434 int last_pixel_count =
3435 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003436 if (is_screenshare) {
3437 wants.max_framerate_fps = kDefaultFps;
3438 } else {
3439 wants.max_pixel_count = last_pixel_count * 4;
3440 wants.target_pixel_count.emplace((last_pixel_count * 5) / 3);
3441 }
perkj803d97f2016-11-01 11:45:46 -07003442 send_stream->InjectVideoSinkWants(wants);
3443
sprangc5d62e22017-04-02 23:53:04 -07003444 for (int i = 0; i < kDefaultFps; ++i)
3445 EXPECT_TRUE(capturer.CaptureFrame());
3446
3447 if (is_screenshare) {
3448 EXPECT_EQ(kDefaultFps + (kDefaultFps * 2 / 3),
3449 send_stream->GetNumberOfSwappedFrames());
3450 } else {
3451 EXPECT_EQ(kDefaultFps * 2, send_stream->GetNumberOfSwappedFrames());
3452 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003453
perkj26752742016-10-24 01:21:16 -07003454 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3455 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003456
Niels Möllerff40b142018-04-09 08:49:14 +02003457 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003458}
3459
eladalonf1841382017-06-12 01:16:46 -07003460TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003461 // Start at last timestamp to verify that wraparounds are estimated correctly.
3462 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3463 static const int64_t kInitialNtpTimeMs = 1247891230;
3464 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003465 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003466
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003467 FakeVideoReceiveStream* stream = AddRecvStream();
3468 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003469 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003470
nisse64ec8f82016-09-27 00:17:25 -07003471 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4),
3472 kInitialTimestamp, 0,
3473 webrtc::kVideoRotation_0);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003474 // Initial NTP time is not available on the first frame, but should still be
3475 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003476 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003477
3478 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003479
3480 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3481 // triggers a constant-overflow warning, hence we're calculating it explicitly
3482 // here.
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +02003483 fake_clock_.AdvanceTimeMicros(kFrameOffsetMs * rtc::kNumMicrosecsPerMillisec);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003484 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3485 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003486 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003487
3488 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003489
3490 // Verify that NTP time has been correctly deduced.
3491 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003492 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003493 ASSERT_EQ(1u, info.receivers.size());
3494 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003495}
3496
eladalonf1841382017-06-12 01:16:46 -07003497TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003498 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003499 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003500
3501 VideoCodec codec;
3502 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003503 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003504
3505 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003506 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3507 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003508 FakeVideoSendStream* stream = AddSendStream(
3509 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003510 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003511
3512 // Make sure NACK and FEC are enabled on the correct payload types.
3513 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003514 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3515 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003516
3517 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3518 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003519 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003520 // TODO(juberti): Check RTCP, PLI, TMMBR.
3521}
3522
brandtr31bd2242017-05-19 05:47:46 -07003523// The following four tests ensures that FlexFEC is not activated by default
3524// when the field trials are not enabled.
3525// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3526// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003527TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003528 FakeVideoSendStream* stream = AddSendStream();
3529 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3530
brandtr3d200bd2017-01-16 06:59:19 -08003531 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003532 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3533 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003534}
3535
eladalonf1841382017-06-12 01:16:46 -07003536TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003537 FakeVideoSendStream* stream = AddSendStream(
3538 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3539 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3540
brandtr3d200bd2017-01-16 06:59:19 -08003541 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003542 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3543 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3544}
3545
Yves Gerey665174f2018-06-19 15:03:05 +02003546TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003547 AddRecvStream();
3548
3549 const std::vector<FakeFlexfecReceiveStream*>& streams =
3550 fake_call_->GetFlexfecReceiveStreams();
3551 EXPECT_TRUE(streams.empty());
3552}
3553
eladalonf1841382017-06-12 01:16:46 -07003554TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003555 AddRecvStream(
3556 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3557
3558 const std::vector<FakeFlexfecReceiveStream*>& streams =
3559 fake_call_->GetFlexfecReceiveStreams();
3560 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003561}
3562
3563// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3564// tests that use this test fixture into the corresponding "non-field trial"
3565// tests.
eladalonf1841382017-06-12 01:16:46 -07003566class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003567 public:
eladalonf1841382017-06-12 01:16:46 -07003568 WebRtcVideoChannelFlexfecRecvTest()
3569 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003570};
3571
eladalonf1841382017-06-12 01:16:46 -07003572TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003573 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3574 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3575 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3576}
3577
eladalonf1841382017-06-12 01:16:46 -07003578TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003579 AddRecvStream();
3580
3581 const std::vector<FakeFlexfecReceiveStream*>& streams =
3582 fake_call_->GetFlexfecReceiveStreams();
3583 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003584
3585 const std::vector<FakeVideoReceiveStream*>& video_streams =
3586 fake_call_->GetVideoReceiveStreams();
3587 ASSERT_EQ(1U, video_streams.size());
3588 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3589 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3590 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003591}
3592
eladalonf1841382017-06-12 01:16:46 -07003593TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003594 AddRecvStream(
3595 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3596
3597 const std::vector<FakeFlexfecReceiveStream*>& streams =
3598 fake_call_->GetFlexfecReceiveStreams();
3599 ASSERT_EQ(1U, streams.size());
3600 const FakeFlexfecReceiveStream* stream = streams.front();
3601 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3602 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3603 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3604 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3605 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003606
3607 const std::vector<FakeVideoReceiveStream*>& video_streams =
3608 fake_call_->GetVideoReceiveStreams();
3609 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003610 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3611 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003612 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003613 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003614 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003615}
3616
eladalonf1841382017-06-12 01:16:46 -07003617TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003618 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3619 cricket::VideoRecvParameters recv_parameters;
3620 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3621 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3622
3623 AddRecvStream(
3624 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3625 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003626 const std::vector<FakeVideoReceiveStream*>& video_streams =
3627 fake_call_->GetVideoReceiveStreams();
3628 ASSERT_EQ(1U, video_streams.size());
3629 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3630 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3631 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003632
3633 // Enable FlexFEC.
3634 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3635 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3636 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3637 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3638 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3639 << "Enabling FlexFEC should not create VideoReceiveStream.";
3640 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3641 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003642 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3643 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003644}
3645
eladalonf1841382017-06-12 01:16:46 -07003646TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003647 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3648 cricket::VideoRecvParameters recv_parameters;
3649 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3650 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3651 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3652
3653 AddRecvStream(
3654 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3655 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003656 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003657 const std::vector<FakeVideoReceiveStream*>& video_streams =
3658 fake_call_->GetVideoReceiveStreams();
3659 ASSERT_EQ(1U, video_streams.size());
3660 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3661 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3662 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003663
3664 // Disable FlexFEC.
3665 recv_parameters.codecs.clear();
3666 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3667 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3668 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3669 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3670 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3671 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3672 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3673 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003674 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3675 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003676}
3677
brandtr31bd2242017-05-19 05:47:46 -07003678// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3679// tests that use this test fixture into the corresponding "non-field trial"
3680// tests.
eladalonf1841382017-06-12 01:16:46 -07003681class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003682 public:
eladalonf1841382017-06-12 01:16:46 -07003683 WebRtcVideoChannelFlexfecSendRecvTest()
3684 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003685 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3686 }
3687};
3688
Yves Gerey665174f2018-06-19 15:03:05 +02003689TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003690 FakeVideoSendStream* stream = AddSendStream();
3691 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3692
brandtr3d200bd2017-01-16 06:59:19 -08003693 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3694 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3695 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003696}
3697
eladalonf1841382017-06-12 01:16:46 -07003698TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003699 FakeVideoSendStream* stream = AddSendStream(
3700 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3701 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3702
brandtr3d200bd2017-01-16 06:59:19 -08003703 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3704 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3705 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3706 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003707}
3708
eladalonf1841382017-06-12 01:16:46 -07003709TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003710 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003711 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003712 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003713
3714 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003715 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003716
brandtrb5f2c3f2016-10-04 23:28:39 -07003717 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3718 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003719}
3720
eladalonf1841382017-06-12 01:16:46 -07003721TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003722 cricket::VideoSendParameters parameters;
3723 parameters.codecs.push_back(GetEngineCodec("VP8"));
3724 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3725
3726 FakeVideoSendStream* stream = AddSendStream();
3727 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3728
brandtr3d200bd2017-01-16 06:59:19 -08003729 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003730}
3731
eladalonf1841382017-06-12 01:16:46 -07003732TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003733 AddRecvStream(
3734 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003735
3736 cricket::VideoRecvParameters recv_parameters;
3737 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3738 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3739 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003740
3741 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3742 fake_call_->GetFlexfecReceiveStreams();
3743 ASSERT_EQ(1U, flexfec_streams.size());
3744 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3745 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3746 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003747 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003748 flexfec_stream_config.payload_type);
3749 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3750 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3751 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3752 const std::vector<FakeVideoReceiveStream*>& video_streams =
3753 fake_call_->GetVideoReceiveStreams();
3754 const FakeVideoReceiveStream* video_stream = video_streams.front();
3755 const webrtc::VideoReceiveStream::Config& video_stream_config =
3756 video_stream->GetConfig();
3757 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3758 flexfec_stream_config.local_ssrc);
3759 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3760 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3761 flexfec_stream_config.rtcp_send_transport);
3762 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3763 // spec-compliant way.
3764 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3765 flexfec_stream_config.transport_cc);
3766 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3767 EXPECT_EQ(video_stream_config.rtp.extensions,
3768 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003769}
3770
brandtr31bd2242017-05-19 05:47:46 -07003771// We should not send FlexFEC, even if we advertise it, unless the right
3772// field trial is set.
3773// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003774TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003775 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3776 cricket::VideoSendParameters parameters;
3777 parameters.codecs.push_back(GetEngineCodec("VP8"));
3778 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3779 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3780
3781 FakeVideoSendStream* stream = AddSendStream();
3782 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3783
3784 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003785 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003786 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3787}
3788
eladalonf1841382017-06-12 01:16:46 -07003789TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003790 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3791 cricket::VideoSendParameters parameters;
3792 parameters.codecs.push_back(GetEngineCodec("VP8"));
3793 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3794 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3795
3796 FakeVideoSendStream* stream = AddSendStream(
3797 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3798 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3799
3800 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003801 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003802 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3803}
3804
eladalonf1841382017-06-12 01:16:46 -07003805TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003806 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003807 const int kUnusedPayloadType = 127;
3808 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3809
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003810 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003811 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003812 parameters.codecs.push_back(rtx_codec);
3813 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003814 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003815}
3816
eladalonf1841382017-06-12 01:16:46 -07003817TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003818 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003819 const int kUnusedPayloadType1 = 126;
3820 const int kUnusedPayloadType2 = 127;
3821 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3822 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3823 {
3824 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3825 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3826 cricket::VideoSendParameters parameters;
3827 parameters.codecs.push_back(GetEngineCodec("VP8"));
3828 parameters.codecs.push_back(rtx_codec);
3829 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3830 }
3831 {
3832 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3833 kUnusedPayloadType1, kUnusedPayloadType2);
3834 cricket::VideoSendParameters parameters;
3835 parameters.codecs.push_back(GetEngineCodec("VP8"));
3836 parameters.codecs.push_back(rtx_codec);
3837 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3838 << "RTX without matching video codec should be rejected.";
3839 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003840}
3841
eladalonf1841382017-06-12 01:16:46 -07003842TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003843 const int kUnusedPayloadType1 = 126;
3844 const int kUnusedPayloadType2 = 127;
3845 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3846 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3847
3848 // SSRCs for RTX.
3849 cricket::StreamParams params =
3850 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3851 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3852 AddSendStream(params);
3853
3854 // Original payload type for RTX.
3855 cricket::VideoSendParameters parameters;
3856 parameters.codecs.push_back(GetEngineCodec("VP8"));
3857 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3858 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3859 parameters.codecs.push_back(rtx_codec);
3860 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3861 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3862 const webrtc::VideoSendStream::Config& config_before =
3863 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3864 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3865 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3866 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3867
3868 // Change payload type for RTX.
3869 parameters.codecs[1].id = kUnusedPayloadType2;
3870 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3871 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3872 const webrtc::VideoSendStream::Config& config_after =
3873 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3874 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3875 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3876 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3877}
3878
eladalonf1841382017-06-12 01:16:46 -07003879TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003880 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003881 parameters.codecs.push_back(GetEngineCodec("VP8"));
3882 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003883 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003884
3885 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003886 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003887
magjed509e4fe2016-11-18 01:34:11 -08003888 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003889
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003890 parameters.codecs.pop_back();
3891 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003892 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003893 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003894 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003895 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003896 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3897}
3898
eladalonf1841382017-06-12 01:16:46 -07003899TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003900 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003901 cricket::VideoSendParameters parameters;
3902 parameters.codecs.push_back(GetEngineCodec("VP8"));
3903 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3904 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3905
3906 FakeVideoSendStream* stream = AddSendStream(
3907 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3908 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3909
brandtr3d200bd2017-01-16 06:59:19 -08003910 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3911 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003912 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3913 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
3914
3915 parameters.codecs.pop_back();
3916 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3917 stream = fake_call_->GetVideoSendStreams()[0];
3918 ASSERT_TRUE(stream != nullptr);
3919 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08003920 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003921 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003922}
3923
eladalonf1841382017-06-12 01:16:46 -07003924TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003925 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07003926 cricket::VideoCodec codec(100, "VP8");
3927 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
3928 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07003929
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003930 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003931 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003932
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003933 FakeVideoSendStream* stream = AddSendStream();
Tommi85959932018-02-07 19:26:06 +01003934 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003935 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003936
3937 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003938 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003939
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003940 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07003941 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
3942 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003943 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003944 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003945 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02003946 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003947}
3948
eladalonf1841382017-06-12 01:16:46 -07003949TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003950 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3951 200000);
3952}
3953
eladalonf1841382017-06-12 01:16:46 -07003954TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00003955 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
3956 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3957 ASSERT_EQ(1u, streams.size());
3958 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
3959}
3960
eladalonf1841382017-06-12 01:16:46 -07003961TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00003962 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003963 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00003964}
3965
eladalonf1841382017-06-12 01:16:46 -07003966TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003967 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003968}
3969
eladalonf1841382017-06-12 01:16:46 -07003970TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003971 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
3972 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
3973 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003974}
3975
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003976// Test that when both the codec-specific bitrate params and max_bandwidth_bps
3977// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07003978TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003979 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
3980 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
3981 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
3982 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003983 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003984 ExpectSetBitrateParameters(100000, 200000, 400000);
3985 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
3986 // Since the codec isn't changing, start_bitrate_bps should be -1.
3987 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003988
3989 // Decrease max_bandwidth_bps.
3990 send_parameters_.max_bandwidth_bps = 350000;
3991 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003992
3993 // Now try again with the values flipped around.
3994 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
3995 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003996 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003997 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003998
3999 // If we change the codec max, max_bandwidth_bps should still apply.
4000 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004001 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004002 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004003}
4004
Yves Gerey665174f2018-06-19 15:03:05 +02004005TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004006 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4007 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004008 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004009 // Setting max bitrate should keep previous min bitrate.
4010 // Setting max bitrate should not reset start bitrate.
4011 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004012 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004013}
4014
eladalonf1841382017-06-12 01:16:46 -07004015TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004016 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004017 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004018 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004019 // -1 means to disable max bitrate (set infinite).
4020 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004021 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004022 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004023}
4024
eladalonf1841382017-06-12 01:16:46 -07004025TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004026 send_parameters_.max_bandwidth_bps = 99999;
4027 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004028 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004029 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004030 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4031 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4032 stream->GetVideoStreams()[0].max_bitrate_bps);
4033
4034 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004035 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004036 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4037 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004038 stream->GetVideoStreams()[0].max_bitrate_bps);
4039}
4040
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004041// Tests that when the codec specific max bitrate and VideoSendParameters
4042// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4043// appropriately.
4044TEST_F(WebRtcVideoChannelTest,
4045 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4046 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4047 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4048 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4049 send_parameters_.max_bandwidth_bps = -1;
4050 AddSendStream();
4051 ExpectSetMaxBitrate(300000);
4052 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4053
4054 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4055 ASSERT_EQ(1u, video_send_streams.size());
4056 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4057 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4058 // First the max bitrate is set based upon the codec param.
4059 EXPECT_EQ(300000,
4060 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4061
4062 // The VideoSendParameters max bitrate overrides the codec's.
4063 send_parameters_.max_bandwidth_bps = 500000;
4064 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4065 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4066 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4067 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4068}
4069
4070// Tests that when the codec specific max bitrate and RtpParameters
4071// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4072// appropriately.
4073TEST_F(WebRtcVideoChannelTest,
4074 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4075 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4076 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4077 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4078 send_parameters_.max_bandwidth_bps = -1;
4079 AddSendStream();
4080 ExpectSetMaxBitrate(300000);
4081 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4082
4083 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4084 ASSERT_EQ(1u, video_send_streams.size());
4085 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4086 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4087 // First the max bitrate is set based upon the codec param.
4088 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4089
4090 // The RtpParameter max bitrate overrides the codec's.
4091 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4092 ASSERT_EQ(1u, parameters.encodings.size());
4093 parameters.encodings[0].max_bitrate_bps = 500000;
4094 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4095 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4096 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4097 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4098}
4099
Åsa Persson55659812018-06-18 17:51:32 +02004100TEST_F(WebRtcVideoChannelTest,
4101 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4102 send_parameters_.max_bandwidth_bps = 99999;
4103 FakeVideoSendStream* stream = AddSendStream();
4104 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4105 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4106 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4107 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4108 stream->GetVideoStreams()[0].max_bitrate_bps);
4109
4110 // Get and set the rtp encoding parameters.
4111 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4112 EXPECT_EQ(1u, parameters.encodings.size());
4113
4114 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4115 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4116 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4117 stream->GetVideoStreams()[0].max_bitrate_bps);
4118
4119 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4120 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4121 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4122 stream->GetVideoStreams()[0].max_bitrate_bps);
4123}
4124
eladalonf1841382017-06-12 01:16:46 -07004125TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004126 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004127 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004128 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004129 channel_->SetSend(true);
4130
4131 FakeVideoSendStream* stream = AddSendStream();
4132
Tommi85959932018-02-07 19:26:06 +01004133 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004134 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Peter Boström3afc8c42016-01-27 16:45:21 +01004135 EXPECT_EQ(cricket::CS_RUNNING,
4136 capturer.Start(capturer.GetSupportedFormats()->front()));
4137
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004138 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4139 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4140 EXPECT_GT(initial_max_bitrate_bps, 0);
4141
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004142 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4143 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004144 // Insert a frame to update the encoder config.
4145 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004146 streams = stream->GetVideoStreams();
4147 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004148 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004149}
4150
eladalonf1841382017-06-12 01:16:46 -07004151TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004152 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004153 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004154 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004155 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004156 channel_->SetSend(true);
4157
4158 FakeVideoSendStream* stream = AddSendStream(
4159 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4160
4161 // Send a frame to make sure this scales up to >1 stream (simulcast).
Tommi85959932018-02-07 19:26:06 +01004162 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004163 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &capturer));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004164 EXPECT_EQ(cricket::CS_RUNNING,
4165 capturer.Start(capturer.GetSupportedFormats()->front()));
4166 EXPECT_TRUE(capturer.CaptureFrame());
4167
4168 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4169 ASSERT_GT(streams.size(), 1u)
4170 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004171 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004172 EXPECT_GT(initial_max_bitrate_bps, 0);
4173
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004174 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4175 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004176 // Insert a frame to update the encoder config.
4177 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004178 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004179 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004180 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4181
Niels Möllerff40b142018-04-09 08:49:14 +02004182 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004183}
4184
eladalonf1841382017-06-12 01:16:46 -07004185TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004186 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004187 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004188 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004189 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4190 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004191 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004192 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004193
4194 VideoCodec codec;
4195 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4196 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4197}
4198
eladalonf1841382017-06-12 01:16:46 -07004199TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004200 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004201 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004202 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004203 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004204 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004205 parameters.codecs[0].id = kIncorrectPayloads[i];
4206 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004207 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004208 }
4209}
4210
eladalonf1841382017-06-12 01:16:46 -07004211TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004212 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004213 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004214 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004215 parameters.codecs[0].id = payload_type;
4216 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004217 << "Payload type '" << payload_type << "' rejected.";
4218 }
4219}
4220
deadbeef67cf2c12016-04-13 10:07:16 -07004221// Test that setting the a different set of codecs but with an identical front
4222// codec doesn't result in the stream being recreated.
4223// This may happen when a subsequent negotiation includes fewer codecs, as a
4224// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004225TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004226 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4227 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004228 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4229 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004230 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4231
4232 AddSendStream();
4233 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4234
4235 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004236 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004237 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4238 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4239}
4240
eladalonf1841382017-06-12 01:16:46 -07004241TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004242 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004243 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004244 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004245}
4246
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004247// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004248TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004249 const int kUnusedPayloadType1 = 126;
4250 const int kUnusedPayloadType2 = 127;
4251 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4252 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4253
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004254 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004255 parameters.codecs.push_back(GetEngineCodec("VP8"));
4256 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004257 parameters.codecs.push_back(rtx_codec);
4258 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004259 << "RTX codec without associated payload should be rejected.";
4260
magjed509e4fe2016-11-18 01:34:11 -08004261 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004262 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004263 << "RTX codec with invalid associated payload type should be rejected.";
4264
magjed509e4fe2016-11-18 01:34:11 -08004265 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004266 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004267
magjed509e4fe2016-11-18 01:34:11 -08004268 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004269 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004270 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004271
Yves Gerey665174f2018-06-19 15:03:05 +02004272 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4273 << "RTX codec with another RTX as associated payload type should be "
4274 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004275}
4276
eladalonf1841382017-06-12 01:16:46 -07004277TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004278 const int kUnusedPayloadType1 = 126;
4279 const int kUnusedPayloadType2 = 127;
4280 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4281 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4282
4283 // SSRCs for RTX.
4284 cricket::StreamParams params =
4285 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4286 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4287 AddRecvStream(params);
4288
4289 // Original payload type for RTX.
4290 cricket::VideoRecvParameters parameters;
4291 parameters.codecs.push_back(GetEngineCodec("VP8"));
4292 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4293 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4294 parameters.codecs.push_back(rtx_codec);
4295 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4296 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4297 const webrtc::VideoReceiveStream::Config& config_before =
4298 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004299 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4300 const int* payload_type_before = FindKeyByValue(
4301 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4302 ASSERT_NE(payload_type_before, nullptr);
4303 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004304 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4305
4306 // Change payload type for RTX.
4307 parameters.codecs[1].id = kUnusedPayloadType2;
4308 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4309 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4310 const webrtc::VideoReceiveStream::Config& config_after =
4311 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004312 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4313 const int* payload_type_after = FindKeyByValue(
4314 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4315 ASSERT_NE(payload_type_after, nullptr);
4316 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004317 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4318}
4319
eladalonf1841382017-06-12 01:16:46 -07004320TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004321 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004322 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004323 parameters.codecs[0].id = 99;
4324 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004325}
4326
eladalonf1841382017-06-12 01:16:46 -07004327TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004328 cricket::VideoRecvParameters parameters;
4329 parameters.codecs = engine_.codecs();
4330 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004331
4332 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004333 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004334 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004335 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004336}
4337
eladalonf1841382017-06-12 01:16:46 -07004338TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004339 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004340 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004341 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004342 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004343}
4344
eladalonf1841382017-06-12 01:16:46 -07004345TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004346 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004347 parameters.codecs.push_back(GetEngineCodec("VP8"));
4348 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004349 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004350}
4351
eladalonf1841382017-06-12 01:16:46 -07004352TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004353 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004354 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4355 send_parameters.codecs.push_back(GetEngineCodec("red"));
4356 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004357 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004358
4359 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004360
magjed509e4fe2016-11-18 01:34:11 -08004361 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004362 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004363
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004364 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004365 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004366 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004367 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004368 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004369 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004370 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4371}
4372
eladalonf1841382017-06-12 01:16:46 -07004373TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004374 AddRecvStream(
4375 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004376 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004377 fake_call_->GetFlexfecReceiveStreams();
4378
4379 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004380 const FakeFlexfecReceiveStream* stream = streams.front();
4381 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4382 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4383 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4384 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004385
4386 cricket::VideoRecvParameters recv_parameters;
4387 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4388 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4389 EXPECT_TRUE(streams.empty())
4390 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004391}
4392
eladalonf1841382017-06-12 01:16:46 -07004393TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004394 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004395 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004396 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004397
4398 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004399 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4400 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4401 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004402 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4403 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004404 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004405 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004406 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004407 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004408
4409 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004410 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4411 send_parameters.codecs.push_back(GetEngineCodec("red"));
4412 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004413 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4414 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004415 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004416 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004417 << "ULPFEC should be enabled on the receive stream.";
4418}
4419
eladalonf1841382017-06-12 01:16:46 -07004420TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004421 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004422 AddRecvStream(
4423 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004424 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004425 fake_call_->GetFlexfecReceiveStreams();
4426
4427 cricket::VideoRecvParameters recv_parameters;
4428 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4429 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4430 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4431 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004432 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004433 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004434 stream_with_recv_params->GetConfig().payload_type);
4435 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004436 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004437 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004438 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004439 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004440
4441 cricket::VideoSendParameters send_parameters;
4442 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4443 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4444 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4445 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004446 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004447 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004448 stream_with_send_params->GetConfig().payload_type);
4449 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004450 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004451 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004452 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004453 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004454}
4455
eladalonf1841382017-06-12 01:16:46 -07004456TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004457 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004458 parameters.codecs.push_back(GetEngineCodec("VP8"));
4459 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004460 parameters.codecs[1].id = parameters.codecs[0].id;
4461 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004462}
4463
eladalonf1841382017-06-12 01:16:46 -07004464TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004465 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004466 cricket::VideoRecvParameters parameters;
4467 parameters.codecs.push_back(GetEngineCodec("VP8"));
4468 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4469 parameters.codecs[1].id = parameters.codecs[0].id;
4470 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4471}
4472
eladalonf1841382017-06-12 01:16:46 -07004473TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004474 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004475 parameters.codecs.push_back(GetEngineCodec("VP8"));
4476 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004477 parameters.codecs[1].id = parameters.codecs[0].id;
4478 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004479}
4480
eladalonf1841382017-06-12 01:16:46 -07004481TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004482 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004483 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004484 parameters.codecs.push_back(GetEngineCodec("VP8"));
4485 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004486 parameters.codecs[1].id += 1;
4487 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004488}
4489
deadbeef67cf2c12016-04-13 10:07:16 -07004490// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004491// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004492TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004493 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004494 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004495 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4496 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004497 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004498
4499 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4500 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4501
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004502 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004503 parameters2.codecs.push_back(GetEngineCodec("red"));
4504 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004505 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004506 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4507}
4508
eladalonf1841382017-06-12 01:16:46 -07004509TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004510 EXPECT_FALSE(AddSendStream()->IsSending());
4511}
4512
eladalonf1841382017-06-12 01:16:46 -07004513TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004514 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004515}
4516
eladalonf1841382017-06-12 01:16:46 -07004517TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004518 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004519 EXPECT_FALSE(stream->IsSending());
4520
4521 // false->true
4522 EXPECT_TRUE(channel_->SetSend(true));
4523 EXPECT_TRUE(stream->IsSending());
4524 // true->true
4525 EXPECT_TRUE(channel_->SetSend(true));
4526 EXPECT_TRUE(stream->IsSending());
4527 // true->false
4528 EXPECT_TRUE(channel_->SetSend(false));
4529 EXPECT_FALSE(stream->IsSending());
4530 // false->false
4531 EXPECT_TRUE(channel_->SetSend(false));
4532 EXPECT_FALSE(stream->IsSending());
4533
4534 EXPECT_TRUE(channel_->SetSend(true));
4535 FakeVideoSendStream* new_stream = AddSendStream();
4536 EXPECT_TRUE(new_stream->IsSending())
4537 << "Send stream created after SetSend(true) not sending initially.";
4538}
4539
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004540// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004541TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004542 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004543 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004544 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004545 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004546 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004547
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07004548 channel.reset(static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateChannel(
4549 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004550 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004551 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004552 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004553
Tim Haloun648d28a2018-10-18 16:52:22 -07004554 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4555 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004556 config.enable_dscp = true;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07004557 channel.reset(static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateChannel(
4558 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004559 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
Tim Haloun648d28a2018-10-18 16:52:22 -07004560 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4561
4562 // Create a send stream to configure
4563 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4564 parameters = channel->GetRtpSendParameters(kSsrc);
4565 ASSERT_FALSE(parameters.encodings.empty());
4566
4567 // Various priorities map to various dscp values.
4568 parameters.encodings[0].network_priority = 4.0;
4569 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004570 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004571 parameters.encodings[0].network_priority = 0.5;
4572 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4573 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4574
4575 // A bad priority does not change the dscp value.
4576 parameters.encodings[0].network_priority = 0.0;
4577 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4578 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004579
Tim Haloun6ca98362018-09-17 17:06:08 -07004580 // Packets should also self-identify their dscp in PacketOptions.
4581 const uint8_t kData[10] = {0};
4582 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4583 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004584 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004585
nisse51542be2016-02-12 02:27:06 -08004586 // Verify that setting the option to false resets the
4587 // DiffServCodePoint.
4588 config.enable_dscp = false;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07004589 channel.reset(static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateChannel(
4590 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004591 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004592 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004593}
4594
deadbeef13871492015-12-09 12:37:51 -08004595// This test verifies that the RTCP reduced size mode is properly applied to
4596// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004597TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004598 // Create stream, expecting that default mode is "compound".
4599 FakeVideoSendStream* stream1 = AddSendStream();
4600 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004601 webrtc::RtpParameters rtp_parameters =
4602 channel_->GetRtpSendParameters(last_ssrc_);
4603 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004604
4605 // Now enable reduced size mode.
4606 send_parameters_.rtcp.reduced_size = true;
4607 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4608 stream1 = fake_call_->GetVideoSendStreams()[0];
4609 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004610 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4611 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004612
4613 // Create a new stream and ensure it picks up the reduced size mode.
4614 FakeVideoSendStream* stream2 = AddSendStream();
4615 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4616}
4617
4618// This test verifies that the RTCP reduced size mode is properly applied to
4619// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004620TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004621 // Create stream, expecting that default mode is "compound".
4622 FakeVideoReceiveStream* stream1 = AddRecvStream();
4623 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4624
4625 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004626 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4627 // the reduced_size flag should come from that.
4628 send_parameters_.rtcp.reduced_size = true;
4629 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004630 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4631 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4632
4633 // Create a new stream and ensure it picks up the reduced size mode.
4634 FakeVideoReceiveStream* stream2 = AddRecvStream();
4635 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4636}
4637
eladalonf1841382017-06-12 01:16:46 -07004638TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004639 EXPECT_EQ(webrtc::kNetworkUp,
4640 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4641 EXPECT_EQ(webrtc::kNetworkUp,
4642 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004643
4644 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004645 EXPECT_EQ(webrtc::kNetworkDown,
4646 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4647 EXPECT_EQ(webrtc::kNetworkUp,
4648 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004649
4650 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004651 EXPECT_EQ(webrtc::kNetworkUp,
4652 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4653 EXPECT_EQ(webrtc::kNetworkUp,
4654 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004655}
4656
eladalonf1841382017-06-12 01:16:46 -07004657TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004658 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004659 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004660 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004661
4662 AddSendStream();
4663
4664 cricket::VideoMediaInfo info;
4665 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004666 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004667}
4668
eladalonf1841382017-06-12 01:16:46 -07004669TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004670 FakeVideoSendStream* stream = AddSendStream();
4671 webrtc::VideoSendStream::Stats stats;
4672 stats.encoder_implementation_name = "encoder_implementation_name";
4673 stream->SetStats(stats);
4674
4675 cricket::VideoMediaInfo info;
4676 ASSERT_TRUE(channel_->GetStats(&info));
4677 EXPECT_EQ(stats.encoder_implementation_name,
4678 info.senders[0].encoder_implementation_name);
4679}
4680
eladalonf1841382017-06-12 01:16:46 -07004681TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004682 FakeVideoSendStream* stream = AddSendStream();
4683 webrtc::VideoSendStream::Stats stats;
4684 stats.avg_encode_time_ms = 13;
4685 stats.encode_usage_percent = 42;
4686 stream->SetStats(stats);
4687
4688 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004689 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004690 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4691 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4692}
4693
eladalonf1841382017-06-12 01:16:46 -07004694TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004695 FakeVideoSendStream* stream = AddSendStream();
4696 webrtc::VideoSendStream::Stats stats;
4697 stats.frames_encoded = 13;
4698 stream->SetStats(stats);
4699
4700 cricket::VideoMediaInfo info;
4701 ASSERT_TRUE(channel_->GetStats(&info));
4702 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4703}
4704
eladalonf1841382017-06-12 01:16:46 -07004705TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004706 FakeVideoSendStream* stream = AddSendStream();
4707 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004708 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004709 stream->SetStats(stats);
4710
4711 cricket::VideoMediaInfo info;
4712 ASSERT_TRUE(channel_->GetStats(&info));
4713 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4714}
4715
eladalonf1841382017-06-12 01:16:46 -07004716TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004717 FakeVideoSendStream* stream = AddSendStream();
4718 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004719 stats.substreams[17].width = 123;
4720 stats.substreams[17].height = 40;
4721 stats.substreams[42].width = 80;
4722 stats.substreams[42].height = 31;
4723 stats.substreams[11].width = 20;
4724 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004725 stream->SetStats(stats);
4726
4727 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004728 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004729 ASSERT_EQ(1u, info.senders.size());
4730 EXPECT_EQ(123, info.senders[0].send_frame_width);
4731 EXPECT_EQ(90, info.senders[0].send_frame_height);
4732}
4733
eladalonf1841382017-06-12 01:16:46 -07004734TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004735 FakeVideoSendStream* stream = AddSendStream();
4736 webrtc::VideoSendStream::Stats stats;
4737 stats.number_of_cpu_adapt_changes = 2;
4738 stats.cpu_limited_resolution = true;
4739 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004740
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004741 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004742 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004743 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004744 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004745 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004746}
4747
eladalonf1841382017-06-12 01:16:46 -07004748TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004749 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004750 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004751 stats.number_of_cpu_adapt_changes = 2;
4752 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004753 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004754 stream->SetStats(stats);
4755
4756 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004757 EXPECT_TRUE(channel_->GetStats(&info));
4758 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004759 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4760 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004761 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004762 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004763}
4764
eladalonf1841382017-06-12 01:16:46 -07004765TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004766 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4767 FakeVideoSendStream* stream = AddSendStream();
4768 webrtc::VideoSendStream::Stats stats;
4769 stats.bw_limited_resolution = true;
4770 stream->SetStats(stats);
4771
4772 cricket::VideoMediaInfo info;
4773 EXPECT_TRUE(channel_->GetStats(&info));
4774 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004775 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004776 info.senders[0].adapt_reason);
4777}
4778
Yves Gerey665174f2018-06-19 15:03:05 +02004779TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004780 FakeVideoSendStream* stream = AddSendStream();
4781 webrtc::VideoSendStream::Stats stats;
4782 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4783 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4784 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4785
4786 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4787 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4788 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4789
4790 stream->SetStats(stats);
4791
4792 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004793 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004794 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4795 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4796 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4797}
4798
eladalonf1841382017-06-12 01:16:46 -07004799TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004800 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4801 FakeVideoReceiveStream* stream = AddRecvStream();
4802 webrtc::VideoReceiveStream::Stats stats;
4803 stats.rtcp_packet_type_counts.fir_packets = 2;
4804 stats.rtcp_packet_type_counts.nack_packets = 3;
4805 stats.rtcp_packet_type_counts.pli_packets = 4;
4806 stream->SetStats(stats);
4807
4808 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004809 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004810 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004811 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004812 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004813 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004814 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004815 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004816}
4817
eladalonf1841382017-06-12 01:16:46 -07004818TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004819 FakeVideoReceiveStream* stream = AddRecvStream();
4820 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004821 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004822 stats.decode_ms = 2;
4823 stats.max_decode_ms = 3;
4824 stats.current_delay_ms = 4;
4825 stats.target_delay_ms = 5;
4826 stats.jitter_buffer_ms = 6;
4827 stats.min_playout_delay_ms = 7;
4828 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07004829 stats.width = 9;
4830 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08004831 stats.frame_counts.key_frames = 11;
4832 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08004833 stats.frames_rendered = 13;
4834 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01004835 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004836 stream->SetStats(stats);
4837
4838 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004839 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01004840 EXPECT_EQ(stats.decoder_implementation_name,
4841 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004842 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
4843 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
4844 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
4845 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
4846 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
4847 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
4848 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07004849 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
4850 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004851 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
4852 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08004853 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08004854 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07004855 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08004856 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004857}
4858
eladalonf1841382017-06-12 01:16:46 -07004859TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02004860 FakeVideoReceiveStream* stream = AddRecvStream();
4861 webrtc::VideoReceiveStream::Stats stats;
4862 stats.rtp_stats.transmitted.payload_bytes = 2;
4863 stats.rtp_stats.transmitted.header_bytes = 3;
4864 stats.rtp_stats.transmitted.padding_bytes = 4;
4865 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07004866 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02004867 stats.rtcp_stats.fraction_lost = 7;
4868 stream->SetStats(stats);
4869
4870 cricket::VideoMediaInfo info;
4871 ASSERT_TRUE(channel_->GetStats(&info));
4872 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
4873 stats.rtp_stats.transmitted.header_bytes +
4874 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004875 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02004876 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004877 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07004878 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004879 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02004880 info.receivers[0].fraction_lost);
4881}
4882
eladalonf1841382017-06-12 01:16:46 -07004883TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004884 AddSendStream();
4885 AddSendStream();
4886 webrtc::Call::Stats stats;
4887 stats.rtt_ms = 123;
4888 fake_call_->SetStats(stats);
4889
4890 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004891 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004892 ASSERT_EQ(2u, info.senders.size());
4893 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
4894 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
4895}
4896
eladalonf1841382017-06-12 01:16:46 -07004897TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004898 FakeVideoSendStream* stream = AddSendStream();
4899 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004900 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004901 stats.media_bitrate_bps = 123;
4902 stats.substreams[17].total_bitrate_bps = 1;
4903 stats.substreams[17].retransmit_bitrate_bps = 2;
4904 stats.substreams[42].total_bitrate_bps = 3;
4905 stats.substreams[42].retransmit_bitrate_bps = 4;
4906 stream->SetStats(stats);
4907
4908 FakeVideoSendStream* stream2 = AddSendStream();
4909 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004910 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004911 stats2.media_bitrate_bps = 321;
4912 stats2.substreams[13].total_bitrate_bps = 5;
4913 stats2.substreams[13].retransmit_bitrate_bps = 6;
4914 stats2.substreams[21].total_bitrate_bps = 7;
4915 stats2.substreams[21].retransmit_bitrate_bps = 8;
4916 stream2->SetStats(stats2);
4917
4918 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004919 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004920 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07004921 BandwidthEstimationInfo bwe_info;
4922 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004923 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
4924 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
4925 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
4926 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004927 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004928 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004929 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004930 bwe_info.actual_enc_bitrate);
4931 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004932 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07004933 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004934 << "Bandwidth stats should take all streams into account.";
4935}
4936
eladalonf1841382017-06-12 01:16:46 -07004937TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004938 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004939
Peter Boström0c4e06b2015-10-07 12:23:21 +02004940 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4941 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004942
4943 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4944 const size_t kDataLength = 12;
4945 uint8_t data[kDataLength];
4946 memset(data, 0, sizeof(data));
4947 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07004948 rtc::CopyOnWriteBuffer packet(data, kDataLength);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004949 rtc::PacketTime packet_time;
4950 channel_->OnPacketReceived(&packet, packet_time);
4951
4952 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
4953 << "No default receive stream created.";
4954 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08004955 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004956 << "Default receive stream should not have configured RTX";
4957
4958 EXPECT_TRUE(channel_->AddRecvStream(
4959 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
4960 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08004961 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004962 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07004963 EXPECT_FALSE(
4964 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07004965 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02004966 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07004967 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02004968 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07004969 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08004970 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004971}
4972
eladalonf1841382017-06-12 01:16:46 -07004973TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004974 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01004975
Peter Boström0c4e06b2015-10-07 12:23:21 +02004976 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4977 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01004978
4979 StreamParams sp =
4980 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4981 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
4982
4983 EXPECT_FALSE(channel_->AddSendStream(sp));
4984 EXPECT_FALSE(channel_->AddRecvStream(sp));
4985}
4986
eladalonf1841382017-06-12 01:16:46 -07004987TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004988 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004989
Peter Boström0c4e06b2015-10-07 12:23:21 +02004990 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4991 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01004992
4993 StreamParams sp =
4994 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4995
4996 EXPECT_TRUE(channel_->AddSendStream(sp));
4997 EXPECT_TRUE(channel_->AddRecvStream(sp));
4998
4999 // The RTX SSRC is already used in previous streams, using it should fail.
5000 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5001 EXPECT_FALSE(channel_->AddSendStream(sp));
5002 EXPECT_FALSE(channel_->AddRecvStream(sp));
5003
5004 // After removing the original stream this should be fine to add (makes sure
5005 // that RTX ssrcs are not forever taken).
5006 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5007 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5008 EXPECT_TRUE(channel_->AddSendStream(sp));
5009 EXPECT_TRUE(channel_->AddRecvStream(sp));
5010}
5011
eladalonf1841382017-06-12 01:16:46 -07005012TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005013 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005014 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5015 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005016 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005017
Peter Boströmd6f4c252015-03-26 16:23:04 +01005018 StreamParams sp =
5019 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5020
5021 EXPECT_TRUE(channel_->AddSendStream(sp));
5022 EXPECT_TRUE(channel_->AddRecvStream(sp));
5023
5024 // One of the SSRCs is already used in previous streams, using it should fail.
5025 sp = cricket::CreateSimStreamParams("cname",
5026 MAKE_VECTOR(kOverlappingStreamSsrcs));
5027 EXPECT_FALSE(channel_->AddSendStream(sp));
5028 EXPECT_FALSE(channel_->AddRecvStream(sp));
5029
5030 // After removing the original stream this should be fine to add (makes sure
5031 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005032 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5033 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005034 EXPECT_TRUE(channel_->AddSendStream(sp));
5035 EXPECT_TRUE(channel_->AddRecvStream(sp));
5036}
5037
eladalonf1841382017-06-12 01:16:46 -07005038TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005039 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005040
5041 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5042 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5043
5044 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5045 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5046
5047 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5048
5049 static const uint32_t kReceiverSsrcs[] = {3};
5050 static const uint32_t kReceiverRtxSsrcs[] = {2};
5051
5052 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5053 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5054 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5055
5056 cricket::VideoMediaInfo info;
5057 ASSERT_TRUE(channel_->GetStats(&info));
5058
5059 ASSERT_EQ(1u, info.senders.size());
5060 ASSERT_EQ(1u, info.receivers.size());
5061
5062 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5063 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5064 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5065}
5066
eladalonf1841382017-06-12 01:16:46 -07005067TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005068 FakeVideoReceiveStream* stream = AddRecvStream();
5069 webrtc::VideoReceiveStream::Stats stats;
5070 cricket::VideoMediaInfo info;
5071
5072 // Report no codec name before receiving.
5073 stream->SetStats(stats);
5074 ASSERT_TRUE(channel_->GetStats(&info));
5075 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5076
5077 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005078 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005079 stream->SetStats(stats);
5080 ASSERT_TRUE(channel_->GetStats(&info));
5081 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5082
5083 // Report no codec name for unknown playload types.
5084 stats.current_payload_type = 3;
5085 stream->SetStats(stats);
5086 ASSERT_TRUE(channel_->GetStats(&info));
5087 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5088}
5089
Seth Hampson5897a6e2018-04-03 11:16:33 -07005090// Tests that when we add a stream without SSRCs, but contains a stream_id
5091// that it is stored and its stream id is later used when the first packet
5092// arrives to properly create a receive stream with a sync label.
5093TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5094 const char kSyncLabel[] = "sync_label";
5095 cricket::StreamParams unsignaled_stream;
5096 unsignaled_stream.set_stream_ids({kSyncLabel});
5097 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5098 // The stream shouldn't have been created at this point because it doesn't
5099 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005100 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005101
5102 // Create and deliver packet.
5103 const size_t kDataLength = 12;
5104 uint8_t data[kDataLength];
5105 memset(data, 0, sizeof(data));
5106 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5107 rtc::CopyOnWriteBuffer packet(data, kDataLength);
5108 rtc::PacketTime packet_time;
5109 channel_->OnPacketReceived(&packet, packet_time);
5110
5111 // The stream should now be created with the appropriate sync label.
5112 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5113 EXPECT_EQ(kSyncLabel,
5114 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5115
5116 // Removing the unsignaled stream should clear the cache. This time when
5117 // a default video receive stream is created it won't have a sync_group.
5118 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5119 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5120 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5121
5122 channel_->OnPacketReceived(&packet, packet_time);
5123 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5124 EXPECT_TRUE(
5125 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5126}
5127
eladalonf1841382017-06-12 01:16:46 -07005128void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005129 uint8_t payload_type,
5130 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005131 // kRedRtxPayloadType must currently be unused.
5132 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5133
noahricd10a68e2015-07-10 11:27:55 -07005134 // Add a RED RTX codec.
5135 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005136 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005137 recv_parameters_.codecs.push_back(red_rtx_codec);
5138 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005139
5140 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5141 const size_t kDataLength = 12;
5142 uint8_t data[kDataLength];
5143 memset(data, 0, sizeof(data));
5144
5145 rtc::Set8(data, 1, payload_type);
5146 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005147 rtc::CopyOnWriteBuffer packet(data, kDataLength);
noahricd10a68e2015-07-10 11:27:55 -07005148 rtc::PacketTime packet_time;
5149 channel_->OnPacketReceived(&packet, packet_time);
5150
5151 if (expect_created_receive_stream) {
5152 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5153 << "Should have created a receive stream for payload type: "
5154 << payload_type;
5155 } else {
5156 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5157 << "Shouldn't have created a receive stream for payload type: "
5158 << payload_type;
5159 }
5160}
5161
Åsa Persson2c7149b2018-10-15 09:36:10 +02005162class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5163 public:
5164 WebRtcVideoChannelDiscardUnknownSsrcTest()
5165 : WebRtcVideoChannelTest(
5166 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5167};
5168
5169TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5170 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5171 false /* expect_created_receive_stream */);
5172}
5173
eladalonf1841382017-06-12 01:16:46 -07005174TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005175 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5176 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005177}
5178
eladalonf1841382017-06-12 01:16:46 -07005179TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005180 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5181 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005182}
5183
eladalonf1841382017-06-12 01:16:46 -07005184TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005185 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005186 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5187 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5188 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5189 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005190}
5191
eladalonf1841382017-06-12 01:16:46 -07005192TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005193 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5194 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005195}
5196
eladalonf1841382017-06-12 01:16:46 -07005197TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005198 FlexfecPacketDoesntCreateUnsignalledStream) {
5199 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5200 false /* expect_created_receive_stream */);
5201}
5202
eladalonf1841382017-06-12 01:16:46 -07005203TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005204 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5205 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005206}
5207
mzanaty8a855d62017-02-17 15:46:43 -08005208// Test that receiving any unsignalled SSRC works even if it changes.
5209// The first unsignalled SSRC received will create a default receive stream.
5210// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005211TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005212 // Allow receiving VP8, VP9, H264 (if enabled).
5213 cricket::VideoRecvParameters parameters;
5214 parameters.codecs.push_back(GetEngineCodec("VP8"));
5215 parameters.codecs.push_back(GetEngineCodec("VP9"));
5216
5217#if defined(WEBRTC_USE_H264)
5218 cricket::VideoCodec H264codec(126, "H264");
5219 parameters.codecs.push_back(H264codec);
5220#endif
5221
5222 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5223 // No receive streams yet.
5224 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5225 cricket::FakeVideoRenderer renderer;
5226 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5227
5228 // Receive VP8 packet on first SSRC.
5229 uint8_t data[kMinRtpPacketLen];
5230 cricket::RtpHeader rtpHeader;
5231 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5232 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005233 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005234 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5235 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5236 rtc::PacketTime packet_time;
5237 channel_->OnPacketReceived(&packet, packet_time);
5238 // VP8 packet should create default receive stream.
5239 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005240 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005241 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5242 // Verify that the receive stream sinks to a renderer.
5243 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4), 100, 0,
5244 webrtc::kVideoRotation_0);
5245 recv_stream->InjectFrame(video_frame);
5246 EXPECT_EQ(1, renderer.num_rendered_frames());
5247
5248 // Receive VP9 packet on second SSRC.
5249 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005250 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005251 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5252 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
5253 channel_->OnPacketReceived(&packet2, packet_time);
5254 // VP9 packet should replace the default receive SSRC.
5255 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5256 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5257 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5258 // Verify that the receive stream sinks to a renderer.
5259 webrtc::VideoFrame video_frame2(CreateBlackFrameBuffer(4, 4), 200, 0,
ilnik00d802b2017-04-11 10:34:31 -07005260 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005261 recv_stream->InjectFrame(video_frame2);
5262 EXPECT_EQ(2, renderer.num_rendered_frames());
5263
5264#if defined(WEBRTC_USE_H264)
5265 // Receive H264 packet on third SSRC.
5266 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005267 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005268 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5269 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
5270 channel_->OnPacketReceived(&packet3, packet_time);
5271 // H264 packet should replace the default receive SSRC.
5272 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5273 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5274 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5275 // Verify that the receive stream sinks to a renderer.
5276 webrtc::VideoFrame video_frame3(CreateBlackFrameBuffer(4, 4), 300, 0,
ilnik00d802b2017-04-11 10:34:31 -07005277 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005278 recv_stream->InjectFrame(video_frame3);
5279 EXPECT_EQ(3, renderer.num_rendered_frames());
5280#endif
5281}
5282
brandtr0dc57ea2017-05-29 23:33:31 -07005283// This test verifies that when a new default stream is created for a new
5284// unsignaled SSRC, the new stream does not overwrite any old stream that had
5285// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005286TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005287 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5288 cricket::VideoRecvParameters parameters;
5289 parameters.codecs.push_back(GetEngineCodec("VP8"));
5290 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5291
5292 // No streams signaled and no packets received, so we should not have any
5293 // stream objects created yet.
5294 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5295
5296 // Receive packet on an unsignaled SSRC.
5297 uint8_t data[kMinRtpPacketLen];
5298 cricket::RtpHeader rtp_header;
5299 rtp_header.payload_type = GetEngineCodec("VP8").id;
5300 rtp_header.seq_num = rtp_header.timestamp = 0;
5301 rtp_header.ssrc = kSsrcs3[0];
5302 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5303 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5304 rtc::PacketTime packet_time;
5305 channel_->OnPacketReceived(&packet, packet_time);
5306 // Default receive stream should be created.
5307 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5308 FakeVideoReceiveStream* recv_stream0 =
5309 fake_call_->GetVideoReceiveStreams()[0];
5310 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5311
5312 // Signal the SSRC.
5313 EXPECT_TRUE(
5314 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5315 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5316 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5317 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5318
5319 // Receive packet on a different unsignaled SSRC.
5320 rtp_header.ssrc = kSsrcs3[1];
5321 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5322 packet.SetData(data, sizeof(data));
5323 channel_->OnPacketReceived(&packet, packet_time);
5324 // New default receive stream should be created, but old stream should remain.
5325 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5326 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5327 FakeVideoReceiveStream* recv_stream1 =
5328 fake_call_->GetVideoReceiveStreams()[1];
5329 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5330}
5331
Seth Hampson7c682e02018-05-04 16:28:15 -07005332TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005333 AddSendStream();
5334
Tommi85959932018-02-07 19:26:06 +01005335 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02005336 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
skvladdc1c62c2016-03-16 19:07:43 -07005337 cricket::VideoFormat capture_format_hd =
5338 capturer.GetSupportedFormats()->front();
5339 EXPECT_EQ(1280, capture_format_hd.width);
5340 EXPECT_EQ(720, capture_format_hd.height);
5341 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
5342 EXPECT_TRUE(channel_->SetSend(true));
perkjfa10b552016-10-02 23:45:26 -07005343 capturer.CaptureFrame();
skvladdc1c62c2016-03-16 19:07:43 -07005344
perkjfa10b552016-10-02 23:45:26 -07005345 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005346 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005347
5348 // TODO(skvlad): Resolve the inconsistency between the interpretation
5349 // of the global bitrate limit for audio and video:
5350 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5351 // max_bandwidth_bps = -1 - remove the bandwidth limit
5352 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005353 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005354
perkjfa10b552016-10-02 23:45:26 -07005355 SetAndExpectMaxBitrate(1000, 0, 1000);
5356 SetAndExpectMaxBitrate(1000, 800, 800);
5357 SetAndExpectMaxBitrate(600, 800, 600);
5358 SetAndExpectMaxBitrate(0, 800, 800);
5359 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005360
Niels Möllerff40b142018-04-09 08:49:14 +02005361 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005362}
5363
eladalonf1841382017-06-12 01:16:46 -07005364TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005365 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005366 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005367 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005368
5369 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005370 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005371 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005372}
5373
eladalonf1841382017-06-12 01:16:46 -07005374TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005375 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005376 FakeVideoSendStream* stream = AddSendStream();
5377
Seth Hampson7c682e02018-05-04 16:28:15 -07005378 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5379 EXPECT_EQ(1UL, parameters.encodings.size());
5380 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5381 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5382
5383 // Note that this is testing the behavior of the FakeVideoSendStream, which
5384 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5385 // we are just testing the behavior of
5386 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005387 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5388 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005389
5390 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5391 // by this amount.
5392 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5393 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5394 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5395 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5396
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005397 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5398 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5399 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5400}
5401
5402TEST_F(WebRtcVideoChannelTest,
5403 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5404 FakeVideoSendStream* stream = AddSendStream();
5405
5406 // Note that this is testing the behavior of the FakeVideoSendStream, which
5407 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5408 // we are just testing the behavior of
5409 // EncoderStreamFactory::CreateEncoderStreams.
5410 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5411 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5412
5413 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5414 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5415 EXPECT_EQ(1UL, parameters.encodings.size());
5416 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5417 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5418
5419 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5420 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5421 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5422}
5423
5424TEST_F(WebRtcVideoChannelTest,
5425 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5426 send_parameters_.max_bandwidth_bps = 99999;
5427 FakeVideoSendStream* stream = AddSendStream();
5428 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5429 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5430 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5431 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5432 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5433 stream->GetVideoStreams()[0].max_bitrate_bps);
5434
5435 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5436 // adjusted down.
5437 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5438 EXPECT_EQ(1UL, parameters.encodings.size());
5439 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5440 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5441 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5442 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5443 stream->GetVideoStreams()[0].min_bitrate_bps);
5444 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5445 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005446}
5447
Åsa Persson8c1bf952018-09-13 10:42:19 +02005448TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5449 FakeVideoSendStream* stream = AddSendStream();
5450
5451 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5452 EXPECT_EQ(1UL, parameters.encodings.size());
5453 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5454 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5455
5456 // Note that this is testing the behavior of the FakeVideoSendStream, which
5457 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5458 // we are just testing the behavior of
5459 // EncoderStreamFactory::CreateEncoderStreams.
5460 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5461 EXPECT_EQ(kDefaultVideoMaxFramerate,
5462 stream->GetVideoStreams()[0].max_framerate);
5463
5464 // Set max framerate and check that VideoStream.max_framerate is set.
5465 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5466 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5467 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5468 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5469
5470 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5471 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5472}
5473
Åsa Persson23eba222018-10-02 14:47:06 +02005474TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5475 FakeVideoSendStream* stream = AddSendStream();
5476
5477 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5478 EXPECT_EQ(1UL, parameters.encodings.size());
5479 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5480 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5481
5482 // Note that this is testing the behavior of the FakeVideoSendStream, which
5483 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5484 // we are just testing the behavior of
5485 // EncoderStreamFactory::CreateEncoderStreams.
5486 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5487 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5488
5489 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5490 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5491 parameters.encodings[0].num_temporal_layers = 2;
5492 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5493
5494 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5495 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5496}
5497
Seth Hampson7c682e02018-05-04 16:28:15 -07005498TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005499 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005500 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005501 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005502 // Two or more encodings should result in failure.
5503 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005504 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005505 // Zero encodings should also fail.
5506 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005507 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005508}
5509
Zach Stein3ca452b2018-01-18 10:01:24 -08005510TEST_F(WebRtcVideoChannelTest,
5511 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5512 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5513 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5514 AddSendStream(sp);
5515
5516 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5517
5518 // Additional encodings should result in failure.
5519 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005520 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005521 // Zero encodings should also fail.
5522 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005523 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005524}
5525
deadbeeffb2aced2017-01-06 23:05:37 -08005526// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005527TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005528 AddSendStream();
5529 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005530 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005531 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005532}
5533
Seth Hampson24722b32017-12-22 09:36:42 -08005534// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5535// a value <= 0, setting the parameters returns false.
5536TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5537 AddSendStream();
5538 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5539 EXPECT_EQ(1UL, parameters.encodings.size());
5540 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5541 parameters.encodings[0].bitrate_priority);
5542
5543 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005544 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005545 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005546 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005547}
5548
5549// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5550// properly on the VideoChannel and propogates down to the video encoder.
5551TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5552 AddSendStream();
5553 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5554 EXPECT_EQ(1UL, parameters.encodings.size());
5555 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5556 parameters.encodings[0].bitrate_priority);
5557
5558 // Change the value and set it on the VideoChannel.
5559 double new_bitrate_priority = 2.0;
5560 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005561 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005562
5563 // Verify that the encoding parameters bitrate_priority is set for the
5564 // VideoChannel.
5565 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5566 EXPECT_EQ(1UL, parameters.encodings.size());
5567 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5568
5569 // Verify that the new value propagated down to the encoder.
5570 std::vector<FakeVideoSendStream*> video_send_streams =
5571 fake_call_->GetVideoSendStreams();
5572 EXPECT_EQ(1UL, video_send_streams.size());
5573 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5574 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5575 // appropriately.
5576 EXPECT_EQ(new_bitrate_priority,
5577 video_send_stream->GetEncoderConfig().bitrate_priority);
5578 // Check that the vector of VideoStreams also was propagated correctly. Note
5579 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5580 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005581 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005582 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5583}
5584
5585// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5586// VideoChannel and the value propogates to the video encoder with all simulcast
5587// streams.
5588TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5589 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005590 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005591 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5592 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5593 AddSendStream(stream_params);
5594 uint32_t primary_ssrc = stream_params.first_ssrc();
5595
Tommi85959932018-02-07 19:26:06 +01005596 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
5597 // frame. This creates multiple VideoStreams for all simulcast layers when
5598 // reconfiguring, and allows us to test this behavior.
5599 FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson24722b32017-12-22 09:36:42 -08005600 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02005601 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson24722b32017-12-22 09:36:42 -08005602 EXPECT_EQ(cricket::CS_RUNNING,
5603 capturer.Start(cricket::VideoFormat(
5604 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
5605 cricket::FOURCC_I420)));
5606 channel_->SetSend(true);
5607 EXPECT_TRUE(capturer.CaptureFrame());
5608 // Get and set the rtp encoding parameters.
5609 webrtc::RtpParameters parameters =
5610 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005611 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005612 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5613 parameters.encodings[0].bitrate_priority);
5614 // Change the value and set it on the VideoChannel.
5615 double new_bitrate_priority = 2.0;
5616 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005617 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005618
5619 // Verify that the encoding parameters priority is set on the VideoChannel.
5620 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005621 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005622 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5623
5624 // Verify that the new value propagated down to the encoder.
5625 std::vector<FakeVideoSendStream*> video_send_streams =
5626 fake_call_->GetVideoSendStreams();
5627 EXPECT_EQ(1UL, video_send_streams.size());
5628 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5629 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5630 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005631 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005632 video_send_stream->GetEncoderConfig().number_of_streams);
5633 EXPECT_EQ(new_bitrate_priority,
5634 video_send_stream->GetEncoderConfig().bitrate_priority);
5635 // Check that the vector of VideoStreams also propagated correctly. The
5636 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5637 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005638 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005639 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005640 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5641 // Since we are only setting bitrate priority per-sender, the other
5642 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005643 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005644 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005645 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005646 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005647 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005648}
5649
Tim Haloun648d28a2018-10-18 16:52:22 -07005650// RTCRtpEncodingParameters.network_priority must be one of a few values
5651// derived from the default priority, corresponding to very-low, low, medium,
5652// or high.
5653TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
5654 AddSendStream();
5655 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5656 EXPECT_EQ(1UL, parameters.encodings.size());
5657 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5658 parameters.encodings[0].network_priority);
5659
5660 double good_values[] = {0.5, 1.0, 2.0, 4.0};
5661 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
5662 for (auto it : good_values) {
5663 parameters.encodings[0].network_priority = it;
5664 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5665 }
5666 for (auto it : bad_values) {
5667 parameters.encodings[0].network_priority = it;
5668 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5669 }
5670}
5671
Åsa Persson8c1bf952018-09-13 10:42:19 +02005672TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
5673 const size_t kNumSimulcastStreams = 3;
5674 SetUpSimulcast(true, false);
5675
5676 // Get and set the rtp encoding parameters.
5677 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5678 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5679 for (const auto& encoding : parameters.encodings) {
5680 EXPECT_FALSE(encoding.max_framerate);
5681 }
5682
5683 // Change the value and set it on the VideoChannel.
5684 parameters.encodings[0].max_framerate = 10;
5685 parameters.encodings[1].max_framerate = 20;
5686 parameters.encodings[2].max_framerate = 25;
5687 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5688
5689 // Verify that the bitrates are set on the VideoChannel.
5690 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5691 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5692 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
5693 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
5694 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
5695}
5696
Åsa Persson23eba222018-10-02 14:47:06 +02005697TEST_F(WebRtcVideoChannelTest,
5698 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
5699 const size_t kNumSimulcastStreams = 3;
5700 SetUpSimulcast(true, false);
5701
5702 // Get and set the rtp encoding parameters.
5703 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5704 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5705
5706 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
5707 parameters.encodings[0].num_temporal_layers = 0;
5708 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5709 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5710 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
5711 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5712 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5713}
5714
5715TEST_F(WebRtcVideoChannelTest,
5716 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
5717 const size_t kNumSimulcastStreams = 3;
5718 SetUpSimulcast(true, false);
5719
5720 // Get and set the rtp encoding parameters.
5721 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5722 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5723
5724 // No/all layers should be set.
5725 parameters.encodings[0].num_temporal_layers = 1;
5726 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5727 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5728
5729 // Different values not supported.
5730 parameters.encodings[0].num_temporal_layers = 1;
5731 parameters.encodings[1].num_temporal_layers = 2;
5732 parameters.encodings[2].num_temporal_layers = 2;
5733 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5734 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5735}
5736
5737TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
5738 const size_t kNumSimulcastStreams = 3;
5739 SetUpSimulcast(true, false);
5740
5741 // Get and set the rtp encoding parameters.
5742 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5743 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5744 for (const auto& encoding : parameters.encodings)
5745 EXPECT_FALSE(encoding.num_temporal_layers);
5746
5747 // Change the value and set it on the VideoChannel.
5748 parameters.encodings[0].num_temporal_layers = 3;
5749 parameters.encodings[1].num_temporal_layers = 3;
5750 parameters.encodings[2].num_temporal_layers = 3;
5751 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5752
5753 // Verify that the number of temporal layers are set on the VideoChannel.
5754 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5755 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5756 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
5757 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
5758 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
5759}
5760
5761TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
5762 const size_t kNumSimulcastStreams = 3;
5763 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5764
5765 // Send a full size frame so all simulcast layers are used when reconfiguring.
5766 FakeVideoCapturerWithTaskQueue capturer;
5767 VideoOptions options;
5768 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5769 EXPECT_EQ(cricket::CS_RUNNING,
5770 capturer.Start(capturer.GetSupportedFormats()->front()));
5771 channel_->SetSend(true);
5772 EXPECT_TRUE(capturer.CaptureFrame());
5773
5774 // Get and set the rtp encoding parameters.
5775 // Change the value and set it on the VideoChannel.
5776 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5777 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5778 parameters.encodings[0].num_temporal_layers = 2;
5779 parameters.encodings[1].num_temporal_layers = 2;
5780 parameters.encodings[2].num_temporal_layers = 2;
5781 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5782
5783 // Verify that the new value is propagated down to the encoder.
5784 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5785 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5786 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5787 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5788 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5789 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
5790 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
5791 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
5792
5793 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5794 // VideoStreams are created appropriately for the simulcast case.
5795 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5796 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5797 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
5798 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
5799
5800 // No parameter changed, encoder should not be reconfigured.
5801 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5802 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5803
5804 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5805}
5806
5807TEST_F(WebRtcVideoChannelTest,
5808 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
5809 const size_t kDefaultNumTemporalLayers = 3;
5810 const size_t kNumSimulcastStreams = 3;
5811 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5812
5813 // Send a full size frame so all simulcast layers are used when reconfiguring.
5814 FakeVideoCapturerWithTaskQueue capturer;
5815 VideoOptions options;
5816 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5817 EXPECT_EQ(cricket::CS_RUNNING,
5818 capturer.Start(capturer.GetSupportedFormats()->front()));
5819 channel_->SetSend(true);
5820 EXPECT_TRUE(capturer.CaptureFrame());
5821
5822 // Change rtp encoding parameters, num_temporal_layers not changed.
5823 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5824 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5825 parameters.encodings[0].min_bitrate_bps = 33000;
5826 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5827
5828 // Verify that no value is propagated down to the encoder.
5829 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5830 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5831 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5832 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
5833 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
5834 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
5835
5836 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5837 // VideoStreams are created appropriately for the simulcast case.
5838 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5839 EXPECT_EQ(kDefaultNumTemporalLayers,
5840 stream->GetVideoStreams()[0].num_temporal_layers);
5841 EXPECT_EQ(kDefaultNumTemporalLayers,
5842 stream->GetVideoStreams()[1].num_temporal_layers);
5843 EXPECT_EQ(kDefaultNumTemporalLayers,
5844 stream->GetVideoStreams()[2].num_temporal_layers);
5845
5846 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5847}
5848
Åsa Persson8c1bf952018-09-13 10:42:19 +02005849TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
5850 const size_t kNumSimulcastStreams = 3;
5851 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5852
5853 // Send a full size frame so all simulcast layers are used when reconfiguring.
5854 FakeVideoCapturerWithTaskQueue capturer;
5855 VideoOptions options;
5856 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5857 EXPECT_EQ(cricket::CS_RUNNING,
5858 capturer.Start(capturer.GetSupportedFormats()->front()));
5859 channel_->SetSend(true);
5860 EXPECT_TRUE(capturer.CaptureFrame());
5861
5862 // Get and set the rtp encoding parameters.
5863 // Change the value and set it on the VideoChannel.
5864 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5865 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5866 parameters.encodings[0].max_framerate = 15;
5867 parameters.encodings[1].max_framerate = 25;
5868 parameters.encodings[2].max_framerate = 20;
5869 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5870
5871 // Verify that the new value propagated down to the encoder.
5872 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5873 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5874 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5875 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5876 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5877 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5878 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
5879 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5880
5881 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5882 // VideoStreams are created appropriately for the simulcast case.
5883 // Currently the maximum |max_framerate| is used.
5884 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5885 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
5886 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
5887 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
5888
5889 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5890}
5891
5892TEST_F(WebRtcVideoChannelTest,
5893 DefaultValuePropagatedToEncoderForUnsetFramerate) {
5894 const size_t kNumSimulcastStreams = 3;
5895 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5896 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5897
5898 // Send a full size frame so all simulcast layers are used when reconfiguring.
5899 FakeVideoCapturerWithTaskQueue capturer;
5900 VideoOptions options;
5901 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5902 EXPECT_EQ(cricket::CS_RUNNING,
5903 capturer.Start(capturer.GetSupportedFormats()->front()));
5904 channel_->SetSend(true);
5905 EXPECT_TRUE(capturer.CaptureFrame());
5906
5907 // Get and set the rtp encoding parameters.
5908 // Change the value and set it on the VideoChannel.
5909 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5910 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5911 parameters.encodings[0].max_framerate = 15;
5912 parameters.encodings[2].max_framerate = 20;
5913 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5914
5915 // Verify that the new value propagated down to the encoder.
5916 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5917 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5918 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5919 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5920 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5921 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
5922 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5923
5924 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5925 // VideoStreams are created appropriately for the simulcast case.
5926 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
5927 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5928 EXPECT_EQ(kDefaultVideoMaxFramerate,
5929 stream->GetVideoStreams()[0].max_framerate);
5930 EXPECT_EQ(kDefaultVideoMaxFramerate,
5931 stream->GetVideoStreams()[1].max_framerate);
5932 EXPECT_EQ(kDefaultVideoMaxFramerate,
5933 stream->GetVideoStreams()[2].max_framerate);
5934
5935 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5936}
5937
Åsa Persson55659812018-06-18 17:51:32 +02005938TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
5939 const size_t kNumSimulcastStreams = 3;
5940 SetUpSimulcast(true, false);
5941
5942 // Get and set the rtp encoding parameters.
5943 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5944 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5945 for (const auto& encoding : parameters.encodings) {
5946 EXPECT_FALSE(encoding.min_bitrate_bps);
5947 EXPECT_FALSE(encoding.max_bitrate_bps);
5948 }
5949
5950 // Change the value and set it on the VideoChannel.
5951 parameters.encodings[0].min_bitrate_bps = 100000;
5952 parameters.encodings[0].max_bitrate_bps = 200000;
5953 parameters.encodings[1].min_bitrate_bps = 300000;
5954 parameters.encodings[1].max_bitrate_bps = 400000;
5955 parameters.encodings[2].min_bitrate_bps = 500000;
5956 parameters.encodings[2].max_bitrate_bps = 600000;
5957 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5958
5959 // Verify that the bitrates are set on the VideoChannel.
5960 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5961 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5962 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
5963 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
5964 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
5965 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
5966 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
5967 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
5968}
5969
5970TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
5971 const size_t kNumSimulcastStreams = 3;
5972 SetUpSimulcast(true, false);
5973
5974 // Get and set the rtp encoding parameters.
5975 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5976 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5977
5978 // Max bitrate lower than min bitrate should fail.
5979 parameters.encodings[2].min_bitrate_bps = 100000;
5980 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
5981 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5982 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5983}
5984
5985// Test that min and max bitrate values set via RtpParameters are correctly
5986// propagated to the underlying encoder, and that the target is set to 3/4 of
5987// the maximum (3/4 was chosen because it's similar to the simulcast defaults
5988// that are used if no min/max are specified).
5989TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
5990 const size_t kNumSimulcastStreams = 3;
5991 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5992
5993 // Send a full size frame so all simulcast layers are used when reconfiguring.
5994 FakeVideoCapturerWithTaskQueue capturer;
5995 VideoOptions options;
5996 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5997 EXPECT_EQ(cricket::CS_RUNNING,
5998 capturer.Start(capturer.GetSupportedFormats()->front()));
5999 channel_->SetSend(true);
6000 EXPECT_TRUE(capturer.CaptureFrame());
6001
6002 // Get and set the rtp encoding parameters.
6003 // Change the value and set it on the VideoChannel.
6004 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6005 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6006 parameters.encodings[0].min_bitrate_bps = 100000;
6007 parameters.encodings[0].max_bitrate_bps = 200000;
6008 parameters.encodings[1].min_bitrate_bps = 300000;
6009 parameters.encodings[1].max_bitrate_bps = 400000;
6010 parameters.encodings[2].min_bitrate_bps = 500000;
6011 parameters.encodings[2].max_bitrate_bps = 600000;
6012 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6013
6014 // Verify that the new value propagated down to the encoder.
6015 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6016 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6017 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6018 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6019 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6020 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6021 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6022 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6023 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6024 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6025 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6026
6027 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6028 // VideoStreams are created appropriately for the simulcast case.
6029 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6030 // Target bitrate: 200000 * 3 / 4 = 150000.
6031 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6032 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6033 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6034 // Target bitrate: 400000 * 3 / 4 = 300000.
6035 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6036 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6037 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6038 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6039 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6040 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6041 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6042
6043 // No parameter changed, encoder should not be reconfigured.
6044 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6045 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6046
6047 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6048}
6049
6050// Test to only specify the min or max bitrate value for a layer via
6051// RtpParameters. The unspecified min/max and target value should be set to the
6052// simulcast default that is used if no min/max are specified.
6053TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6054 const size_t kNumSimulcastStreams = 3;
6055 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6056 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6057
6058 // Send a full size frame so all simulcast layers are used when reconfiguring.
6059 FakeVideoCapturerWithTaskQueue capturer;
6060 VideoOptions options;
6061 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6062 EXPECT_EQ(cricket::CS_RUNNING,
6063 capturer.Start(capturer.GetSupportedFormats()->front()));
6064 channel_->SetSend(true);
6065 EXPECT_TRUE(capturer.CaptureFrame());
6066
6067 // Get and set the rtp encoding parameters.
6068 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6069 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6070
6071 // Change the value and set it on the VideoChannel.
6072 // Layer 0: only configure min bitrate.
6073 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6074 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6075 // Layer 1: only configure max bitrate.
6076 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6077 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6078 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6079
6080 // Verify that the new value propagated down to the encoder.
6081 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6082 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6083 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6084 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6085 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6086 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6087 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6088 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6089 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6090 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6091
6092 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6093 // VideoStreams are created appropriately for the simulcast case.
6094 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6095 // Layer 0: min configured bitrate should overwrite min default.
6096 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6097 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6098 stream->GetVideoStreams()[0].target_bitrate_bps);
6099 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6100 stream->GetVideoStreams()[0].max_bitrate_bps);
6101 // Layer 1: max configured bitrate should overwrite max default.
6102 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6103 stream->GetVideoStreams()[1].min_bitrate_bps);
6104 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6105 stream->GetVideoStreams()[1].target_bitrate_bps);
6106 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6107 // Layer 2: min and max bitrate not configured, default expected.
6108 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6109 stream->GetVideoStreams()[2].min_bitrate_bps);
6110 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6111 stream->GetVideoStreams()[2].target_bitrate_bps);
6112 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6113 stream->GetVideoStreams()[2].max_bitrate_bps);
6114
6115 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6116}
6117
6118// Test that specifying the min (or max) bitrate value for a layer via
6119// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6120// unspecified values accordingly.
6121TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6122 const size_t kNumSimulcastStreams = 3;
6123 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6124 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6125
6126 // Send a full size frame so all simulcast layers are used when reconfiguring.
6127 FakeVideoCapturerWithTaskQueue capturer;
6128 VideoOptions options;
6129 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6130 EXPECT_EQ(cricket::CS_RUNNING,
6131 capturer.Start(capturer.GetSupportedFormats()->front()));
6132 channel_->SetSend(true);
6133 EXPECT_TRUE(capturer.CaptureFrame());
6134
6135 // Get and set the rtp encoding parameters.
6136 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6137 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6138
6139 // Change the value and set it on the VideoChannel.
6140 // For layer 0, set the min bitrate above the default max.
6141 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6142 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6143 // For layer 1, set the max bitrate below the default min.
6144 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6145 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6146 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6147
6148 // Verify that the new value propagated down to the encoder.
6149 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6150 // VideoStreams are created appropriately for the simulcast case.
6151 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6152 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6153 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6154 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6155 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6156 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6157 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6158 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6159 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6160 // Layer 2: min and max bitrate not configured, default expected.
6161 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6162 stream->GetVideoStreams()[2].min_bitrate_bps);
6163 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6164 stream->GetVideoStreams()[2].target_bitrate_bps);
6165 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6166 stream->GetVideoStreams()[2].max_bitrate_bps);
6167
6168 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6169}
6170
6171TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6172 const size_t kNumSimulcastStreams = 3;
6173 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6174 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6175
6176 // Send a full size frame so all simulcast layers are used when reconfiguring.
6177 FakeVideoCapturerWithTaskQueue capturer;
6178 VideoOptions options;
6179 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6180 EXPECT_EQ(cricket::CS_RUNNING,
6181 capturer.Start(capturer.GetSupportedFormats()->front()));
6182 channel_->SetSend(true);
6183 EXPECT_TRUE(capturer.CaptureFrame());
6184
6185 // Set max bitrate for all but the highest layer.
6186 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6187 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6188 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6189 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6190 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6191
6192 // Set max bandwidth equal to total max bitrate.
6193 send_parameters_.max_bandwidth_bps =
6194 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6195 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6196 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6197
6198 // No bitrate above the total max to give to the highest layer.
6199 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6200 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6201 stream->GetVideoStreams()[2].max_bitrate_bps);
6202
6203 // Set max bandwidth above the total max bitrate.
6204 send_parameters_.max_bandwidth_bps =
6205 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6206 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6207 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6208
6209 // The highest layer has no max bitrate set -> the bitrate above the total
6210 // max should be given to the highest layer.
6211 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6212 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6213 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6214 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6215 stream->GetVideoStreams()[2].max_bitrate_bps);
6216
6217 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6218}
6219
6220TEST_F(WebRtcVideoChannelTest,
6221 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6222 const size_t kNumSimulcastStreams = 3;
6223 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6224 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6225 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6226
6227 // Send a full size frame so all simulcast layers are used when reconfiguring.
6228 FakeVideoCapturerWithTaskQueue capturer;
6229 VideoOptions options;
6230 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6231 EXPECT_EQ(cricket::CS_RUNNING,
6232 capturer.Start(capturer.GetSupportedFormats()->front()));
6233 channel_->SetSend(true);
6234 EXPECT_TRUE(capturer.CaptureFrame());
6235
6236 // Set max bitrate for the highest layer.
6237 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6238 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6239 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6240 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6241
6242 // Set max bandwidth above the total max bitrate.
6243 send_parameters_.max_bandwidth_bps =
6244 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6245 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6246 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6247
6248 // The highest layer has the max bitrate set -> the bitrate above the total
6249 // max should not be given to the highest layer.
6250 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6251 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6252 stream->GetVideoStreams()[2].max_bitrate_bps);
6253
6254 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6255}
6256
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006257// Test that min and max bitrate values set via RtpParameters are correctly
6258// propagated to the underlying encoder for a single stream.
6259TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6260 FakeVideoSendStream* stream = AddSendStream();
6261 EXPECT_TRUE(channel_->SetSend(true));
6262 EXPECT_TRUE(stream->IsSending());
6263
6264 // Set min and max bitrate.
6265 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6266 EXPECT_EQ(1u, parameters.encodings.size());
6267 parameters.encodings[0].min_bitrate_bps = 80000;
6268 parameters.encodings[0].max_bitrate_bps = 150000;
6269 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6270
6271 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6272 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6273 EXPECT_EQ(1u, encoder_config.number_of_streams);
6274 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6275 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6276 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6277
6278 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6279 // VideoStreams are created appropriately.
6280 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6281 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6282 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6283 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6284}
6285
6286// Test the default min and max bitrate value are correctly propagated to the
6287// underlying encoder for a single stream (when the values are not set via
6288// RtpParameters).
6289TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6290 FakeVideoSendStream* stream = AddSendStream();
6291 EXPECT_TRUE(channel_->SetSend(true));
6292 EXPECT_TRUE(stream->IsSending());
6293
6294 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6295 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6296 EXPECT_EQ(1u, encoder_config.number_of_streams);
6297 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6298 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6299 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6300
6301 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6302 // VideoStreams are created appropriately.
6303 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6304 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6305 stream->GetVideoStreams()[0].min_bitrate_bps);
6306 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6307 stream->GetVideoStreams()[0].min_bitrate_bps);
6308 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6309 stream->GetVideoStreams()[0].target_bitrate_bps);
6310}
6311
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006312// Test that a stream will not be sending if its encoding is made inactive
6313// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006314TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006315 FakeVideoSendStream* stream = AddSendStream();
6316 EXPECT_TRUE(channel_->SetSend(true));
6317 EXPECT_TRUE(stream->IsSending());
6318
6319 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006320 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006321 ASSERT_EQ(1u, parameters.encodings.size());
6322 ASSERT_TRUE(parameters.encodings[0].active);
6323 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006324 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006325 EXPECT_FALSE(stream->IsSending());
6326
6327 // Now change it back to active and verify we resume sending.
6328 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006329 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006330 EXPECT_TRUE(stream->IsSending());
6331}
6332
Seth Hampson8234ead2018-02-02 15:16:24 -08006333// Tests that when active is updated for any simulcast layer then the send
6334// stream's sending state will be updated and it will be reconfigured with the
6335// new appropriate active simulcast streams.
6336TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6337 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006338 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006339 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6340 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6341 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6342 uint32_t primary_ssrc = stream_params.first_ssrc();
6343
Tommi85959932018-02-07 19:26:06 +01006344 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
6345 // frame. This allows us to test that ReconfigureEncoder is called
6346 // appropriately.
6347 cricket::FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson8234ead2018-02-02 15:16:24 -08006348 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02006349 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson8234ead2018-02-02 15:16:24 -08006350 EXPECT_EQ(cricket::CS_RUNNING,
6351 capturer.Start(cricket::VideoFormat(
6352 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
6353 cricket::FOURCC_I420)));
6354 channel_->SetSend(true);
6355 EXPECT_TRUE(capturer.CaptureFrame());
6356
6357 // Check that all encodings are initially active.
6358 webrtc::RtpParameters parameters =
6359 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006360 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006361 EXPECT_TRUE(parameters.encodings[0].active);
6362 EXPECT_TRUE(parameters.encodings[1].active);
6363 EXPECT_TRUE(parameters.encodings[2].active);
6364 EXPECT_TRUE(fake_video_send_stream->IsSending());
6365
6366 // Only turn on only the middle stream.
6367 parameters.encodings[0].active = false;
6368 parameters.encodings[1].active = true;
6369 parameters.encodings[2].active = false;
6370 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6371 // Verify that the active fields are set on the VideoChannel.
6372 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006373 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006374 EXPECT_FALSE(parameters.encodings[0].active);
6375 EXPECT_TRUE(parameters.encodings[1].active);
6376 EXPECT_FALSE(parameters.encodings[2].active);
6377 // Check that the VideoSendStream is updated appropriately. This means its
6378 // send state was updated and it was reconfigured.
6379 EXPECT_TRUE(fake_video_send_stream->IsSending());
6380 std::vector<webrtc::VideoStream> simulcast_streams =
6381 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006382 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006383 EXPECT_FALSE(simulcast_streams[0].active);
6384 EXPECT_TRUE(simulcast_streams[1].active);
6385 EXPECT_FALSE(simulcast_streams[2].active);
6386
6387 // Turn off all streams.
6388 parameters.encodings[0].active = false;
6389 parameters.encodings[1].active = false;
6390 parameters.encodings[2].active = false;
6391 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6392 // Verify that the active fields are set on the VideoChannel.
6393 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006394 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006395 EXPECT_FALSE(parameters.encodings[0].active);
6396 EXPECT_FALSE(parameters.encodings[1].active);
6397 EXPECT_FALSE(parameters.encodings[2].active);
6398 // Check that the VideoSendStream is off.
6399 EXPECT_FALSE(fake_video_send_stream->IsSending());
6400 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006401 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006402 EXPECT_FALSE(simulcast_streams[0].active);
6403 EXPECT_FALSE(simulcast_streams[1].active);
6404 EXPECT_FALSE(simulcast_streams[2].active);
6405
Niels Möllerff40b142018-04-09 08:49:14 +02006406 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08006407}
6408
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006409// Test that if a stream is reconfigured (due to a codec change or other
6410// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07006411TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006412 InactiveStreamDoesntStartSendingWhenReconfigured) {
6413 // Set an initial codec list, which will be modified later.
6414 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08006415 parameters1.codecs.push_back(GetEngineCodec("VP8"));
6416 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006417 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
6418
6419 FakeVideoSendStream* stream = AddSendStream();
6420 EXPECT_TRUE(channel_->SetSend(true));
6421 EXPECT_TRUE(stream->IsSending());
6422
6423 // Get current parameters and change "active" to false.
6424 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6425 ASSERT_EQ(1u, parameters.encodings.size());
6426 ASSERT_TRUE(parameters.encodings[0].active);
6427 parameters.encodings[0].active = false;
6428 EXPECT_EQ(1u, GetFakeSendStreams().size());
6429 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08006430 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006431 EXPECT_FALSE(stream->IsSending());
6432
6433 // Reorder the codec list, causing the stream to be reconfigured.
6434 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08006435 parameters2.codecs.push_back(GetEngineCodec("VP9"));
6436 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006437 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
6438 auto new_streams = GetFakeSendStreams();
6439 // Assert that a new underlying stream was created due to the codec change.
6440 // Otherwise, this test isn't testing what it set out to test.
6441 EXPECT_EQ(1u, GetFakeSendStreams().size());
6442 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
6443
6444 // Verify that we still are not sending anything, due to the inactive
6445 // encoding.
6446 EXPECT_FALSE(new_streams[0]->IsSending());
6447}
6448
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006449// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006450TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006451 AddSendStream();
6452 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006453 parameters.codecs.push_back(GetEngineCodec("VP8"));
6454 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006455 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6456
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006457 webrtc::RtpParameters rtp_parameters =
6458 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006459 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006460 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6461 rtp_parameters.codecs[0]);
6462 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6463 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006464}
6465
Florent Castellidacec712018-05-24 16:24:21 +02006466// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
6467TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
6468 StreamParams params = StreamParams::CreateLegacy(kSsrc);
6469 params.cname = "rtcpcname";
6470 AddSendStream(params);
6471
6472 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
6473 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
6474}
6475
deadbeeffb2aced2017-01-06 23:05:37 -08006476// Test that RtpParameters for send stream has one encoding and it has
6477// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006478TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08006479 AddSendStream();
6480
6481 webrtc::RtpParameters rtp_parameters =
6482 channel_->GetRtpSendParameters(last_ssrc_);
6483 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006484 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08006485}
6486
Florent Castelliabe301f2018-06-12 18:33:49 +02006487TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
6488 AddSendStream();
6489
6490 webrtc::RtpParameters rtp_parameters =
6491 channel_->GetRtpSendParameters(last_ssrc_);
6492 rtp_parameters.header_extensions.emplace_back();
6493
6494 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
6495
6496 webrtc::RTCError result =
6497 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6498 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
6499}
6500
Florent Castelli87b3c512018-07-18 16:00:28 +02006501TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
6502 AddSendStream();
6503
6504 FakeVideoCapturerWithTaskQueue capturer;
6505 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
6506
6507 webrtc::RtpParameters rtp_parameters =
6508 channel_->GetRtpSendParameters(last_ssrc_);
6509 EXPECT_EQ(rtp_parameters.degradation_preference,
6510 webrtc::DegradationPreference::BALANCED);
6511 rtp_parameters.degradation_preference =
6512 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
6513
6514 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
6515
6516 webrtc::RtpParameters updated_rtp_parameters =
6517 channel_->GetRtpSendParameters(last_ssrc_);
6518 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
6519 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
6520
6521 // Remove the source since it will be destroyed before the channel
6522 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6523}
6524
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006525// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006526TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006527 AddSendStream();
6528 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006529 parameters.codecs.push_back(GetEngineCodec("VP8"));
6530 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006531 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6532
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006533 webrtc::RtpParameters initial_params =
6534 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006535
6536 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08006537 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006538
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006539 // ... And this shouldn't change the params returned by GetRtpSendParameters.
6540 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
6541}
6542
6543// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006544TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006545 AddRecvStream();
6546 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006547 parameters.codecs.push_back(GetEngineCodec("VP8"));
6548 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006549 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6550
6551 webrtc::RtpParameters rtp_parameters =
6552 channel_->GetRtpReceiveParameters(last_ssrc_);
6553 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006554 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6555 rtp_parameters.codecs[0]);
6556 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6557 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006558}
6559
johan073ece42016-08-26 02:59:47 -07006560#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07006561TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006562#else
eladalonf1841382017-06-12 01:16:46 -07006563TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006564#endif
johan3859c892016-08-05 09:19:25 -07006565 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07006566 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08006567 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07006568 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07006569 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08006570 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07006571 parameters.codecs.push_back(kH264sprop2);
6572 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6573
6574 FakeVideoReceiveStream* recv_stream = AddRecvStream();
6575 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
6576 webrtc::RtpParameters rtp_parameters =
6577 channel_->GetRtpReceiveParameters(last_ssrc_);
6578 ASSERT_EQ(2u, rtp_parameters.codecs.size());
6579 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
6580 ASSERT_EQ(2u, cfg.decoders.size());
6581 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006582 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006583 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006584 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
6585 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006586 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07006587
6588 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006589 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006590 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006591 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
6592 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006593 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07006594}
6595
sakal1fd95952016-06-22 00:46:15 -07006596// Test that RtpParameters for receive stream has one encoding and it has
6597// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006598TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07006599 AddRecvStream();
6600
6601 webrtc::RtpParameters rtp_parameters =
6602 channel_->GetRtpReceiveParameters(last_ssrc_);
6603 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006604 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07006605}
6606
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006607// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006608TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006609 AddRecvStream();
6610 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006611 parameters.codecs.push_back(GetEngineCodec("VP8"));
6612 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006613 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6614
6615 webrtc::RtpParameters initial_params =
6616 channel_->GetRtpReceiveParameters(last_ssrc_);
6617
6618 // We should be able to set the params we just got.
6619 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
6620
6621 // ... And this shouldn't change the params returned by
6622 // GetRtpReceiveParameters.
6623 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006624}
6625
deadbeef3bc15102017-04-20 19:25:07 -07006626// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
6627// aren't signaled. It should always return an empty "RtpEncodingParameters",
6628// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07006629TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07006630 // Call necessary methods to configure receiving a default stream as
6631 // soon as it arrives.
6632 cricket::VideoRecvParameters parameters;
6633 parameters.codecs.push_back(GetEngineCodec("VP8"));
6634 parameters.codecs.push_back(GetEngineCodec("VP9"));
6635 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6636
6637 // Call GetRtpReceiveParameters before configured to receive an unsignaled
6638 // stream. Should return nothing.
6639 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
6640
6641 // Set a sink for an unsignaled stream.
6642 cricket::FakeVideoRenderer renderer;
6643 // Value of "0" means "unsignaled stream".
6644 EXPECT_TRUE(channel_->SetSink(0, &renderer));
6645
6646 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
6647 // in this method means "unsignaled stream".
6648 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
6649 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6650 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6651
6652 // Receive VP8 packet.
6653 uint8_t data[kMinRtpPacketLen];
6654 cricket::RtpHeader rtpHeader;
6655 rtpHeader.payload_type = GetEngineCodec("VP8").id;
6656 rtpHeader.seq_num = rtpHeader.timestamp = 0;
6657 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
6658 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
6659 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
6660 rtc::PacketTime packet_time;
6661 channel_->OnPacketReceived(&packet, packet_time);
6662
6663 // The |ssrc| member should still be unset.
6664 rtp_parameters = channel_->GetRtpReceiveParameters(0);
6665 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6666 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6667}
6668
eladalonf1841382017-06-12 01:16:46 -07006669void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02006670 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006671 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02006672
6673 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02006674 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02006675 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02006676 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02006677
6678 if (receiver_first) {
6679 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6680 std::vector<FakeVideoReceiveStream*> receive_streams =
6681 fake_call_->GetVideoReceiveStreams();
6682 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02006683 // Default local SSRC when we have no sender.
6684 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6685 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006686 }
6687 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
6688 if (!receiver_first)
6689 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6690 std::vector<FakeVideoReceiveStream*> receive_streams =
6691 fake_call_->GetVideoReceiveStreams();
6692 ASSERT_EQ(1u, receive_streams.size());
6693 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02006694
6695 // Removing first sender should fall back to another (in this case the second)
6696 // local send stream's SSRC.
6697 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
6698 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006699 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006700 ASSERT_EQ(1u, receive_streams.size());
6701 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
6702
6703 // Removing the last sender should fall back to default local SSRC.
6704 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006705 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006706 ASSERT_EQ(1u, receive_streams.size());
6707 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6708 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006709}
6710
eladalonf1841382017-06-12 01:16:46 -07006711TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02006712 TestReceiverLocalSsrcConfiguration(false);
6713}
6714
eladalonf1841382017-06-12 01:16:46 -07006715TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02006716 TestReceiverLocalSsrcConfiguration(true);
6717}
6718
eladalonf1841382017-06-12 01:16:46 -07006719class WebRtcVideoChannelSimulcastTest : public testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006720 public:
eladalonf1841382017-06-12 01:16:46 -07006721 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01006722 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006723 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
6724 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +02006725 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006726 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02006727 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006728 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07006729 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006730
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00006731 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02006732 encoder_factory_->AddSupportedVideoCodecType("VP8");
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07006733 channel_.reset(engine_.CreateChannel(&fake_call_, GetMediaConfig(),
6734 VideoOptions(),
6735 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08006736 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006737 last_ssrc_ = 123;
6738 }
6739
6740 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006741 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07006742 int capture_width,
6743 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006744 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08006745 size_t expected_num_streams,
6746 bool screenshare,
6747 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006748 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006749 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08006750 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006751 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006752
Peter Boström0c4e06b2015-10-07 12:23:21 +02006753 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07006754 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006755 ssrcs.resize(num_configured_streams);
6756
sprangf24a0642017-02-28 13:23:26 -08006757 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006758 // Send a full-size frame to trigger a stream reconfiguration to use all
6759 // expected simulcast layers.
Tommi85959932018-02-07 19:26:06 +01006760 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08006761 VideoOptions options;
6762 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01006763 options.is_screencast = screenshare;
Yves Gerey665174f2018-06-19 15:03:05 +02006764 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08006765 // Fetch the latest stream since SetVideoSend() may recreate it if the
6766 // screen content setting is changed.
6767 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006768 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(cricket::VideoFormat(
perkj26752742016-10-24 01:21:16 -07006769 capture_width, capture_height,
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006770 cricket::VideoFormat::FpsToInterval(30),
6771 cricket::FOURCC_I420)));
6772 channel_->SetSend(true);
6773 EXPECT_TRUE(capturer.CaptureFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006774
Zach Stein3ca452b2018-01-18 10:01:24 -08006775 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
6776 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
6777
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006778 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6779 ASSERT_EQ(expected_num_streams, video_streams.size());
6780
sprang429600d2017-01-26 06:12:26 -08006781 std::vector<webrtc::VideoStream> expected_streams;
6782 if (conference_mode) {
6783 expected_streams = GetSimulcastConfig(
6784 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08006785 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02006786 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08006787 if (screenshare) {
6788 for (const webrtc::VideoStream& stream : expected_streams) {
6789 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00006790 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
6791 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08006792 }
6793 }
sprang429600d2017-01-26 06:12:26 -08006794 } else {
6795 webrtc::VideoStream stream;
6796 stream.width = capture_width;
6797 stream.height = capture_height;
6798 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01006799 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08006800 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006801 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08006802 stream.max_qp = kDefaultQpMax;
6803 expected_streams.push_back(stream);
6804 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006805
6806 ASSERT_EQ(expected_streams.size(), video_streams.size());
6807
6808 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006809 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006810 for (size_t i = 0; i < num_streams; ++i) {
6811 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
6812 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
6813
6814 EXPECT_GT(video_streams[i].max_framerate, 0);
6815 EXPECT_EQ(expected_streams[i].max_framerate,
6816 video_streams[i].max_framerate);
6817
6818 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
6819 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
6820 video_streams[i].min_bitrate_bps);
6821
6822 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
6823 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
6824 video_streams[i].target_bitrate_bps);
6825
6826 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
6827 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
6828 video_streams[i].max_bitrate_bps);
6829
6830 EXPECT_GT(video_streams[i].max_qp, 0);
6831 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
6832
Sergey Silkina796a7e2018-03-01 15:11:29 +01006833 EXPECT_EQ(conference_mode,
6834 expected_streams[i].num_temporal_layers.has_value());
6835
6836 if (conference_mode) {
6837 EXPECT_EQ(expected_streams[i].num_temporal_layers,
6838 video_streams[i].num_temporal_layers);
6839 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006840
6841 if (i == num_streams - 1) {
6842 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
6843 } else {
6844 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
6845 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006846 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006847
Niels Möllerff40b142018-04-09 08:49:14 +02006848 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006849 }
6850
6851 FakeVideoSendStream* AddSendStream() {
6852 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
6853 }
6854
6855 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006856 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006857 EXPECT_TRUE(channel_->AddSendStream(sp));
6858 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006859 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006860 EXPECT_EQ(num_streams + 1, streams.size());
6861 return streams[streams.size() - 1];
6862 }
6863
6864 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006865 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006866 }
6867
6868 FakeVideoReceiveStream* AddRecvStream() {
6869 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
6870 }
6871
6872 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006873 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006874 EXPECT_TRUE(channel_->AddRecvStream(sp));
6875 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006876 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006877 EXPECT_EQ(num_streams + 1, streams.size());
6878 return streams[streams.size() - 1];
6879 }
6880
skvlad11a9cbf2016-10-07 11:53:05 -07006881 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006882 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006883 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
6884 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -07006885 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08006886 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02006887 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006888};
6889
eladalonf1841382017-06-12 01:16:46 -07006890TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006891 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
6892 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006893}
6894
eladalonf1841382017-06-12 01:16:46 -07006895TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006896 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
6897 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006898}
6899
6900// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07006901TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08006902 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
6903 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006904}
sprang429600d2017-01-26 06:12:26 -08006905
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006906TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006907 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6908 false);
6909}
6910
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006911TEST_F(WebRtcVideoChannelSimulcastTest,
6912 SetSendCodecsForConferenceModeScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006913 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6914 true);
6915}
6916
eladalonf1841382017-06-12 01:16:46 -07006917TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
Erik Språngb65aa012018-09-24 11:35:19 +02006918 webrtc::test::ScopedFieldTrials override_field_trials_(
6919 "WebRTC-SimulcastScreenshare/Enabled/");
sprang429600d2017-01-26 06:12:26 -08006920 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
6921 true);
6922}
6923
eladalonf1841382017-06-12 01:16:46 -07006924TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07006925 NoSimulcastScreenshareWithoutConference) {
Erik Språngb65aa012018-09-24 11:35:19 +02006926 webrtc::test::ScopedFieldTrials override_field_trials_(
6927 "WebRTC-SimulcastScreenshare/Enabled/");
sprangfe627f32017-03-29 08:24:59 -07006928 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6929 false);
6930}
6931
Yves Gereyb6a89422018-10-08 10:08:32 +02006932class WebRtcVideoFakeClock {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006933 public:
Yves Gereyb6a89422018-10-08 10:08:32 +02006934 WebRtcVideoFakeClock() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006935 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1)); // avoid time=0
6936 }
6937 rtc::ScopedFakeClock fake_clock_;
6938};
6939
Yves Gereyb6a89422018-10-08 10:08:32 +02006940// The fake clock needs to be initialized before the call, and not
6941// destroyed until after all threads spawned by the test have been stopped.
6942// This mixin ensures that.
6943class WebRtcVideoChannelTestWithClock : public WebRtcVideoFakeClock,
6944 public WebRtcVideoChannelBaseTest {};
6945
Jonas Oreland49ac5952018-09-26 16:04:32 +02006946TEST_F(WebRtcVideoChannelTestWithClock, GetSources) {
6947 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
6948 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
6949
6950 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
6951
6952 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
6953 rtc::SetBE32(packet1.data() + 8, kSsrc);
6954 channel_->SetSink(kDefaultReceiveSsrc, NULL);
6955 EXPECT_TRUE(SetDefaultCodec());
6956 EXPECT_TRUE(SetSend(true));
6957 EXPECT_EQ(0, renderer_.num_rendered_frames());
6958 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
6959
6960 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
6961 EXPECT_EQ(1u, sources.size());
6962 EXPECT_EQ(webrtc::RtpSourceType::SSRC, sources[0].source_type());
6963 int64_t timestamp1 = sources[0].timestamp_ms();
6964
6965 // a new packet.
6966 int64_t timeDeltaMs = 1;
6967 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
6968 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
6969 int64_t timestamp2 = channel_->GetSources(kSsrc)[0].timestamp_ms();
6970 EXPECT_EQ(timestamp2, timestamp1 + timeDeltaMs);
6971
6972 // It only keeps 10s of history.
6973 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
6974 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
6975 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
6976}
6977
6978TEST_F(WebRtcVideoChannelTestWithClock, GetContributingSources) {
6979 uint8_t data1[] = {0x81, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
6980 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
6981
6982 uint32_t kCsrc = 4321u;
6983 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
6984 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
6985
6986 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
6987 rtc::SetBE32(packet1.data() + 8, kSsrc);
6988 rtc::SetBE32(packet1.data() + 12, kCsrc);
6989 channel_->SetSink(kDefaultReceiveSsrc, NULL);
6990 EXPECT_TRUE(SetDefaultCodec());
6991 EXPECT_TRUE(SetSend(true));
6992 EXPECT_EQ(0, renderer_.num_rendered_frames());
6993 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
6994
6995 {
6996 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
6997 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
6998 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
6999 EXPECT_EQ(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7000 // 1 SSRC and 1 CSRC.
7001 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7002 [](const webrtc::RtpSource& source) {
7003 return source.source_type() ==
7004 webrtc::RtpSourceType::SSRC;
7005 }));
7006 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7007 [](const webrtc::RtpSource& source) {
7008 return source.source_type() ==
7009 webrtc::RtpSourceType::CSRC;
7010 }));
7011 }
7012 int64_t timestamp1 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7013
7014 // a new packet with only ssrc (i.e no csrc).
7015 uint8_t data2[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7016 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7017 rtc::CopyOnWriteBuffer packet2(data2, sizeof(data2));
7018 rtc::SetBE32(packet2.data() + 8, kSsrc);
7019
7020 int64_t timeDeltaMs = 1;
7021 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
7022 channel_->OnPacketReceived(&packet2, rtc::PacketTime());
7023
7024 {
7025 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7026 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7027 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7028 EXPECT_NE(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7029 // 1 SSRC and 1 CSRC.
7030 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7031 [](const webrtc::RtpSource& source) {
7032 return source.source_type() ==
7033 webrtc::RtpSourceType::SSRC;
7034 }));
7035 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7036 [](const webrtc::RtpSource& source) {
7037 return source.source_type() ==
7038 webrtc::RtpSourceType::CSRC;
7039 }));
7040 auto ssrcSource = std::find_if(
7041 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7042 return source.source_type() == webrtc::RtpSourceType::SSRC;
7043 });
7044 auto csrcSource = std::find_if(
7045 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7046 return source.source_type() == webrtc::RtpSourceType::CSRC;
7047 });
7048
7049 EXPECT_EQ(ssrcSource->timestamp_ms(), timestamp1 + timeDeltaMs);
7050 EXPECT_EQ(csrcSource->timestamp_ms(), timestamp1);
7051 }
7052
7053 // It only keeps 10s of history.
7054 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7055
7056 {
7057 ASSERT_EQ(1u, channel_->GetSources(kSsrc).size());
7058 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7059 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7060 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7061 [](const webrtc::RtpSource& source) {
7062 return source.source_type() ==
7063 webrtc::RtpSourceType::SSRC;
7064 }));
7065 EXPECT_EQ(0, std::count_if(sources.begin(), sources.end(),
7066 [](const webrtc::RtpSource& source) {
7067 return source.source_type() ==
7068 webrtc::RtpSourceType::CSRC;
7069 }));
7070 }
7071
7072 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7073 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7074 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7075}
7076
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007077} // namespace cricket