Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 1 | # -*- coding: utf-8 -*- |
| 2 | # Copyright 2019 The Chromium OS Authors. All rights reserved. |
| 3 | # Use of this source code is governed by a BSD-style license that can be |
| 4 | # found in the LICENSE file. |
| 5 | |
| 6 | """packages controller unit tests.""" |
| 7 | |
| 8 | from __future__ import print_function |
| 9 | |
| 10 | import mock |
| 11 | |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 12 | from chromite.api.api_config import ApiConfigMixin |
David Burger | 0f9dd4e | 2019-10-08 12:33:42 -0600 | [diff] [blame] | 13 | from chromite.api.controller import controller_util |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 14 | from chromite.api.controller import packages as packages_controller |
David Burger | 0f9dd4e | 2019-10-08 12:33:42 -0600 | [diff] [blame] | 15 | from chromite.api.gen.chromiumos import common_pb2 |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 16 | from chromite.api.gen.chromite.api import binhost_pb2 |
| 17 | from chromite.api.gen.chromite.api import packages_pb2 |
Chris McDonald | 3840911 | 2020-09-24 11:24:51 -0600 | [diff] [blame] | 18 | from chromite.lib import build_target_lib |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 19 | from chromite.lib import constants |
| 20 | from chromite.lib import cros_build_lib |
| 21 | from chromite.lib import cros_test_lib |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 22 | from chromite.lib import portage_util |
Chris McDonald | 3840911 | 2020-09-24 11:24:51 -0600 | [diff] [blame] | 23 | from chromite.lib import uprev_lib |
Alex Klein | 75df179 | 2020-06-11 14:42:49 -0600 | [diff] [blame] | 24 | from chromite.lib.parser import package_info |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 25 | from chromite.service import packages as packages_service |
| 26 | |
| 27 | |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 28 | class UprevTest(cros_test_lib.MockTestCase, ApiConfigMixin): |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 29 | """Uprev tests.""" |
| 30 | |
| 31 | _PUBLIC = binhost_pb2.OVERLAYTYPE_PUBLIC |
| 32 | _PRIVATE = binhost_pb2.OVERLAYTYPE_PRIVATE |
| 33 | _BOTH = binhost_pb2.OVERLAYTYPE_BOTH |
| 34 | _NONE = binhost_pb2.OVERLAYTYPE_NONE |
| 35 | |
| 36 | def setUp(self): |
| 37 | self.uprev_patch = self.PatchObject(packages_service, 'uprev_build_targets') |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 38 | self.response = packages_pb2.UprevPackagesResponse() |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 39 | |
| 40 | def _GetRequest(self, targets=None, overlay_type=None, output_dir=None): |
| 41 | return packages_pb2.UprevPackagesRequest( |
| 42 | build_targets=[{'name': name} for name in targets or []], |
| 43 | overlay_type=overlay_type, |
| 44 | output_dir=output_dir, |
| 45 | ) |
| 46 | |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 47 | def testValidateOnly(self): |
| 48 | """Sanity check that a validate only call does not execute any logic.""" |
| 49 | patch = self.PatchObject(packages_service, 'uprev_build_targets') |
| 50 | |
| 51 | targets = ['foo', 'bar'] |
| 52 | request = self._GetRequest(targets=targets, overlay_type=self._BOTH) |
| 53 | packages_controller.Uprev(request, self.response, self.validate_only_config) |
| 54 | patch.assert_not_called() |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 55 | |
Michael Mortensen | 2677bf6 | 2019-10-29 08:31:25 -0600 | [diff] [blame] | 56 | def testMockCall(self): |
| 57 | """Test that a mock call does not execute logic, returns mocked value.""" |
| 58 | patch = self.PatchObject(packages_service, 'uprev_build_targets') |
| 59 | targets = ['foo', 'bar'] |
| 60 | request = self._GetRequest(targets=targets, overlay_type=self._BOTH) |
| 61 | packages_controller.Uprev(request, self.response, self.mock_call_config) |
| 62 | patch.assert_not_called() |
| 63 | self.assertTrue(self.response.modified_ebuilds) |
| 64 | |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 65 | def testNoOverlayTypeFails(self): |
| 66 | """No overlay type provided should fail.""" |
| 67 | request = self._GetRequest(targets=['foo']) |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 68 | |
| 69 | with self.assertRaises(cros_build_lib.DieSystemExit): |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 70 | packages_controller.Uprev(request, self.response, self.api_config) |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 71 | |
| 72 | def testOverlayTypeNoneFails(self): |
| 73 | """Overlay type none means nothing here and should fail.""" |
| 74 | request = self._GetRequest(targets=['foo'], overlay_type=self._NONE) |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 75 | |
| 76 | with self.assertRaises(cros_build_lib.DieSystemExit): |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 77 | packages_controller.Uprev(request, self.response, self.api_config) |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 78 | |
| 79 | def testSuccess(self): |
| 80 | """Test overall successful argument handling.""" |
| 81 | targets = ['foo', 'bar'] |
| 82 | output_dir = '/tmp/uprev_output_dir' |
Alex Klein | 5dd6b1e | 2019-07-31 15:45:24 -0600 | [diff] [blame] | 83 | changed = ['/ebuild-1.0-r1.ebuild', '/ebuild-1.0-r2.ebuild'] |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 84 | expected_type = constants.BOTH_OVERLAYS |
| 85 | request = self._GetRequest(targets=targets, overlay_type=self._BOTH, |
| 86 | output_dir=output_dir) |
Alex Klein | 5dd6b1e | 2019-07-31 15:45:24 -0600 | [diff] [blame] | 87 | uprev_patch = self.PatchObject(packages_service, 'uprev_build_targets', |
| 88 | return_value=changed) |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 89 | |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 90 | packages_controller.Uprev(request, self.response, self.api_config) |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 91 | |
| 92 | # Make sure the type is right, verify build targets after. |
| 93 | uprev_patch.assert_called_once_with(mock.ANY, expected_type, mock.ANY, |
| 94 | output_dir) |
| 95 | # First argument (build targets) of the first (only) call. |
| 96 | call_targets = uprev_patch.call_args[0][0] |
Mike Frysinger | 678735c | 2019-09-28 18:23:28 -0400 | [diff] [blame] | 97 | self.assertCountEqual(targets, [t.name for t in call_targets]) |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 98 | |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 99 | for ebuild in self.response.modified_ebuilds: |
Alex Klein | 5dd6b1e | 2019-07-31 15:45:24 -0600 | [diff] [blame] | 100 | self.assertIn(ebuild.path, changed) |
| 101 | changed.remove(ebuild.path) |
| 102 | self.assertFalse(changed) |
| 103 | |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 104 | |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 105 | class UprevVersionedPackageTest(cros_test_lib.MockTestCase, ApiConfigMixin): |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 106 | """UprevVersionedPackage tests.""" |
| 107 | |
| 108 | def setUp(self): |
Yaakov Shaul | 730814a | 2019-09-10 13:58:25 -0600 | [diff] [blame] | 109 | self.response = packages_pb2.UprevVersionedPackageResponse() |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 110 | |
| 111 | def _addVersion(self, request, version): |
| 112 | """Helper method to add a full version message to the request.""" |
| 113 | ref = request.versions.add() |
| 114 | ref.repository = '/some/path' |
Alex Klein | 34afcbc | 2019-08-22 16:14:31 -0600 | [diff] [blame] | 115 | ref.ref = 'refs/tags/%s' % version |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 116 | ref.revision = 'abc123' |
| 117 | |
| 118 | def testValidateOnly(self): |
| 119 | """Sanity check validate only calls are working properly.""" |
| 120 | service = self.PatchObject(packages_service, 'uprev_versioned_package') |
| 121 | |
| 122 | request = packages_pb2.UprevVersionedPackageRequest() |
| 123 | self._addVersion(request, '1.2.3.4') |
| 124 | request.package_info.category = 'chromeos-base' |
| 125 | request.package_info.package_name = 'chromeos-chrome' |
| 126 | |
| 127 | packages_controller.UprevVersionedPackage(request, self.response, |
| 128 | self.validate_only_config) |
| 129 | |
| 130 | service.assert_not_called() |
| 131 | |
Michael Mortensen | 2677bf6 | 2019-10-29 08:31:25 -0600 | [diff] [blame] | 132 | def testMockCall(self): |
| 133 | """Test that a mock call does not execute logic, returns mocked value.""" |
| 134 | patch = self.PatchObject(packages_service, 'uprev_versioned_package') |
| 135 | request = packages_pb2.UprevVersionedPackageRequest() |
| 136 | packages_controller.UprevVersionedPackage(request, self.response, |
| 137 | self.mock_call_config) |
| 138 | patch.assert_not_called() |
| 139 | self.assertTrue(self.response.responses) |
| 140 | self.assertTrue(self.response.responses[0].modified_ebuilds) |
| 141 | |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 142 | def testNoVersions(self): |
| 143 | """Test no versions provided.""" |
| 144 | request = packages_pb2.UprevVersionedPackageRequest() |
| 145 | request.package_info.category = 'chromeos-base' |
| 146 | request.package_info.package_name = 'chromeos-chrome' |
| 147 | |
| 148 | with self.assertRaises(cros_build_lib.DieSystemExit): |
| 149 | packages_controller.UprevVersionedPackage(request, self.response, |
| 150 | self.api_config) |
| 151 | |
| 152 | def testNoPackageName(self): |
| 153 | """Test no package name provided.""" |
| 154 | request = packages_pb2.UprevVersionedPackageRequest() |
| 155 | self._addVersion(request, '1.2.3.4') |
| 156 | request.package_info.category = 'chromeos-base' |
| 157 | |
| 158 | with self.assertRaises(cros_build_lib.DieSystemExit): |
| 159 | packages_controller.UprevVersionedPackage(request, self.response, |
| 160 | self.api_config) |
| 161 | |
| 162 | def testNoCategory(self): |
| 163 | """Test no package category provided.""" |
| 164 | request = packages_pb2.UprevVersionedPackageRequest() |
| 165 | self._addVersion(request, '1.2.3.4') |
| 166 | request.package_info.package_name = 'chromeos-chrome' |
| 167 | |
| 168 | with self.assertRaises(cros_build_lib.DieSystemExit): |
| 169 | packages_controller.UprevVersionedPackage(request, self.response, |
| 170 | self.api_config) |
| 171 | |
| 172 | def testOutputHandling(self): |
| 173 | """Test the modified files are getting correctly added to the output.""" |
Alex Klein | 34afcbc | 2019-08-22 16:14:31 -0600 | [diff] [blame] | 174 | version = '1.2.3.4' |
Chris McDonald | 3840911 | 2020-09-24 11:24:51 -0600 | [diff] [blame] | 175 | result = uprev_lib.UprevVersionedPackageResult().add_result( |
Alex Klein | 34afcbc | 2019-08-22 16:14:31 -0600 | [diff] [blame] | 176 | version, ['/file/one', '/file/two']) |
Yaakov Shaul | 730814a | 2019-09-10 13:58:25 -0600 | [diff] [blame] | 177 | |
Alex Klein | 34afcbc | 2019-08-22 16:14:31 -0600 | [diff] [blame] | 178 | self.PatchObject( |
| 179 | packages_service, 'uprev_versioned_package', return_value=result) |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 180 | |
| 181 | request = packages_pb2.UprevVersionedPackageRequest() |
Alex Klein | 34afcbc | 2019-08-22 16:14:31 -0600 | [diff] [blame] | 182 | self._addVersion(request, version) |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 183 | request.package_info.category = 'chromeos-base' |
| 184 | request.package_info.package_name = 'chromeos-chrome' |
| 185 | |
| 186 | packages_controller.UprevVersionedPackage(request, self.response, |
| 187 | self.api_config) |
| 188 | |
Yaakov Shaul | 730814a | 2019-09-10 13:58:25 -0600 | [diff] [blame] | 189 | for idx, uprev_response in enumerate(self.response.responses): |
| 190 | self.assertEqual(result.modified[idx].new_version, uprev_response.version) |
Mike Frysinger | 678735c | 2019-09-28 18:23:28 -0400 | [diff] [blame] | 191 | self.assertCountEqual( |
Yaakov Shaul | 730814a | 2019-09-10 13:58:25 -0600 | [diff] [blame] | 192 | result.modified[idx].files, |
| 193 | [ebuild.path for ebuild in uprev_response.modified_ebuilds]) |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 194 | |
| 195 | |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 196 | class GetBestVisibleTest(cros_test_lib.MockTestCase, ApiConfigMixin): |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 197 | """GetBestVisible tests.""" |
| 198 | |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 199 | def setUp(self): |
| 200 | self.response = packages_pb2.GetBestVisibleResponse() |
| 201 | |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 202 | def _GetRequest(self, atom=None): |
| 203 | return packages_pb2.GetBestVisibleRequest( |
| 204 | atom=atom, |
| 205 | ) |
| 206 | |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 207 | def _MakeCpv(self, category, package, version): |
| 208 | unused = { |
| 209 | 'cp': None, |
| 210 | 'cpv': None, |
| 211 | 'cpf': None, |
| 212 | 'pv': None, |
| 213 | 'version_no_rev': None, |
| 214 | 'rev': None, |
| 215 | } |
Alex Klein | 75df179 | 2020-06-11 14:42:49 -0600 | [diff] [blame] | 216 | return package_info.CPV( |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 217 | category=category, |
| 218 | package=package, |
| 219 | version=version, |
| 220 | **unused |
| 221 | ) |
| 222 | |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 223 | def testValidateOnly(self): |
| 224 | """Sanity check that a validate only call does not execute any logic.""" |
| 225 | patch = self.PatchObject(packages_service, 'get_best_visible') |
| 226 | |
| 227 | request = self._GetRequest(atom='chromeos-chrome') |
| 228 | packages_controller.GetBestVisible(request, self.response, |
| 229 | self.validate_only_config) |
| 230 | patch.assert_not_called() |
| 231 | |
Michael Mortensen | 2677bf6 | 2019-10-29 08:31:25 -0600 | [diff] [blame] | 232 | def testMockCall(self): |
| 233 | """Test that a mock call does not execute logic, returns mocked value.""" |
| 234 | patch = self.PatchObject(packages_service, 'get_best_visible') |
| 235 | request = self._GetRequest(atom='chromeos-chrome') |
| 236 | packages_controller.GetBestVisible(request, self.response, |
| 237 | self.mock_call_config) |
| 238 | patch.assert_not_called() |
| 239 | self.assertTrue(self.response.package_info) |
| 240 | self.assertTrue(self.response.package_info.category) |
| 241 | self.assertTrue(self.response.package_info.package_name) |
| 242 | self.assertTrue(self.response.package_info.version) |
| 243 | |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 244 | def testNoAtomFails(self): |
| 245 | """No atom provided should fail.""" |
| 246 | request = self._GetRequest() |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 247 | with self.assertRaises(cros_build_lib.DieSystemExit): |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 248 | packages_controller.GetBestVisible(request, self.response, |
| 249 | self.api_config) |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 250 | |
| 251 | def testSuccess(self): |
| 252 | """Test overall success, argument handling, result forwarding.""" |
| 253 | cpv = self._MakeCpv('category', 'package', 'version') |
| 254 | self.PatchObject(packages_service, 'get_best_visible', return_value=cpv) |
| 255 | |
| 256 | request = self._GetRequest(atom='chromeos-chrome') |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 257 | |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 258 | packages_controller.GetBestVisible(request, self.response, self.api_config) |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 259 | |
Alex Klein | 75df179 | 2020-06-11 14:42:49 -0600 | [diff] [blame] | 260 | package_info_msg = self.response.package_info |
| 261 | self.assertEqual(package_info_msg.category, cpv.category) |
| 262 | self.assertEqual(package_info_msg.package_name, cpv.package) |
| 263 | self.assertEqual(package_info_msg.version, cpv.version) |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 264 | |
| 265 | |
Michael Mortensen | 68abdb7 | 2019-10-28 09:43:52 -0600 | [diff] [blame] | 266 | class GetChromeVersion(cros_test_lib.MockTestCase, ApiConfigMixin): |
| 267 | """GetChromeVersion tests.""" |
| 268 | |
| 269 | def setUp(self): |
| 270 | self.response = packages_pb2.GetChromeVersionResponse() |
| 271 | |
| 272 | def _GetRequest(self, board=None): |
| 273 | """Helper to build out a request.""" |
| 274 | request = packages_pb2.GetChromeVersionRequest() |
| 275 | |
| 276 | if board: |
| 277 | request.build_target.name = board |
| 278 | |
| 279 | return request |
| 280 | |
| 281 | def testValidateOnly(self): |
| 282 | """Sanity check that a validate only call does not execute any logic.""" |
| 283 | chrome_version = self.PatchObject(packages_service, |
| 284 | 'determine_chrome_version') |
| 285 | request = self._GetRequest(board='betty') |
| 286 | packages_controller.GetChromeVersion(request, self.response, |
| 287 | self.validate_only_config) |
| 288 | chrome_version.assert_not_called() |
| 289 | |
| 290 | def testMockCall(self): |
| 291 | """Test that a mock call does not execute logic, returns mocked value.""" |
| 292 | chrome_version = self.PatchObject(packages_service, |
| 293 | 'determine_chrome_version') |
| 294 | request = self._GetRequest(board='betty') |
| 295 | packages_controller.GetChromeVersion(request, self.response, |
| 296 | self.mock_call_config) |
| 297 | chrome_version.assert_not_called() |
| 298 | self.assertTrue(self.response.version) |
| 299 | |
| 300 | def testGetChromeVersion(self): |
| 301 | """Verify basic return values.""" |
| 302 | chrome_version = '76.0.1.2' |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 303 | chrome_version_mock = self.PatchObject(packages_service, |
| 304 | 'determine_chrome_version', |
| 305 | return_value=chrome_version) |
Michael Mortensen | 68abdb7 | 2019-10-28 09:43:52 -0600 | [diff] [blame] | 306 | request = self._GetRequest(board='betty') |
| 307 | packages_controller.GetChromeVersion(request, self.response, |
| 308 | self.api_config) |
| 309 | self.assertEqual(self.response.version, chrome_version) |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 310 | # Verify call to determine_chrome_version passes a build_target object. |
| 311 | build_target = build_target_lib.BuildTarget('betty') |
| 312 | chrome_version_mock.assert_called_with(build_target) |
Michael Mortensen | 68abdb7 | 2019-10-28 09:43:52 -0600 | [diff] [blame] | 313 | |
Michael Mortensen | 9fe740c | 2019-10-29 14:42:48 -0600 | [diff] [blame] | 314 | def testGetChromeVersionHandleNone(self): |
| 315 | """Verify basic return values.""" |
| 316 | self.PatchObject(packages_service, 'determine_chrome_version', |
| 317 | return_value=None) |
| 318 | request = self._GetRequest(board='betty') |
| 319 | packages_controller.GetChromeVersion(request, self.response, |
| 320 | self.api_config) |
| 321 | self.assertFalse(self.response.version) |
| 322 | |
Michael Mortensen | 68abdb7 | 2019-10-28 09:43:52 -0600 | [diff] [blame] | 323 | |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 324 | class GetTargetVersionsTest(cros_test_lib.MockTestCase, ApiConfigMixin): |
| 325 | """GetTargetVersions tests.""" |
| 326 | |
| 327 | def setUp(self): |
| 328 | self.response = packages_pb2.GetTargetVersionsResponse() |
| 329 | |
| 330 | def _GetRequest(self, board=None): |
| 331 | """Helper to build out a request.""" |
| 332 | request = packages_pb2.GetTargetVersionsRequest() |
| 333 | |
| 334 | if board: |
| 335 | request.build_target.name = board |
| 336 | |
| 337 | return request |
| 338 | |
| 339 | def testValidateOnly(self): |
| 340 | """Sanity check that a validate only call does not execute any logic.""" |
Michael Mortensen | 1d2ab0d | 2019-10-17 13:19:25 -0600 | [diff] [blame] | 341 | builds_chrome = self.PatchObject( |
| 342 | packages_service, 'builds', return_value=True) |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 343 | patch_version = self.PatchObject(packages_service, |
| 344 | 'determine_android_version') |
| 345 | patch_branch_version = self.PatchObject(packages_service, |
| 346 | 'determine_android_branch') |
| 347 | patch_target_version = self.PatchObject(packages_service, |
| 348 | 'determine_android_target') |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 349 | chrome_version = self.PatchObject(packages_service, |
| 350 | 'determine_chrome_version') |
Michael Mortensen | 009cb66 | 2019-10-21 11:38:43 -0600 | [diff] [blame] | 351 | platform_version = self.PatchObject(packages_service, |
| 352 | 'determine_platform_version') |
| 353 | milestone_version = self.PatchObject(packages_service, |
| 354 | 'determine_milestone_version') |
| 355 | full_version = self.PatchObject(packages_service, |
| 356 | 'determine_full_version') |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 357 | |
| 358 | request = self._GetRequest(board='betty') |
| 359 | packages_controller.GetTargetVersions(request, self.response, |
| 360 | self.validate_only_config) |
| 361 | patch_version.assert_not_called() |
| 362 | patch_branch_version.assert_not_called() |
| 363 | patch_target_version.assert_not_called() |
Michael Mortensen | 1d2ab0d | 2019-10-17 13:19:25 -0600 | [diff] [blame] | 364 | builds_chrome.assert_not_called() |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 365 | chrome_version.assert_not_called() |
Michael Mortensen | 009cb66 | 2019-10-21 11:38:43 -0600 | [diff] [blame] | 366 | platform_version.assert_not_called() |
| 367 | milestone_version.assert_not_called() |
| 368 | full_version.assert_not_called() |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 369 | |
Michael Mortensen | 2677bf6 | 2019-10-29 08:31:25 -0600 | [diff] [blame] | 370 | def testMockCall(self): |
| 371 | """Test that a mock call does not execute logic, returns mocked value.""" |
| 372 | builds_chrome = self.PatchObject( |
| 373 | packages_service, 'builds', return_value=True) |
| 374 | patch_version = self.PatchObject(packages_service, |
| 375 | 'determine_android_version') |
| 376 | patch_branch_version = self.PatchObject(packages_service, |
| 377 | 'determine_android_branch') |
| 378 | patch_target_version = self.PatchObject(packages_service, |
| 379 | 'determine_android_target') |
| 380 | chrome_version = self.PatchObject(packages_service, |
| 381 | 'determine_chrome_version') |
| 382 | platform_version = self.PatchObject(packages_service, |
| 383 | 'determine_platform_version') |
| 384 | milestone_version = self.PatchObject(packages_service, |
| 385 | 'determine_milestone_version') |
| 386 | full_version = self.PatchObject(packages_service, |
| 387 | 'determine_full_version') |
| 388 | |
| 389 | request = self._GetRequest(board='betty') |
| 390 | packages_controller.GetTargetVersions(request, self.response, |
| 391 | self.mock_call_config) |
| 392 | |
| 393 | patch_version.assert_not_called() |
| 394 | patch_branch_version.assert_not_called() |
| 395 | patch_target_version.assert_not_called() |
| 396 | builds_chrome.assert_not_called() |
| 397 | chrome_version.assert_not_called() |
| 398 | platform_version.assert_not_called() |
| 399 | milestone_version.assert_not_called() |
| 400 | full_version.assert_not_called() |
| 401 | |
| 402 | self.assertTrue(self.response.android_version) |
| 403 | self.assertTrue(self.response.android_branch_version) |
| 404 | self.assertTrue(self.response.android_target_version) |
| 405 | self.assertTrue(self.response.chrome_version) |
| 406 | self.assertTrue(self.response.platform_version) |
| 407 | self.assertTrue(self.response.milestone_version) |
| 408 | self.assertTrue(self.response.full_version) |
| 409 | |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 410 | def testNoBuildTargetFails(self): |
| 411 | """No build target argument should fail.""" |
| 412 | request = self._GetRequest() |
| 413 | |
| 414 | with self.assertRaises(cros_build_lib.DieSystemExit): |
| 415 | packages_controller.GetTargetVersions(request, self.response, |
| 416 | self.api_config) |
| 417 | |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 418 | def testGetTargetVersions(self): |
| 419 | """Verify basic return values.""" |
Michael Mortensen | 1d2ab0d | 2019-10-17 13:19:25 -0600 | [diff] [blame] | 420 | # Mock that chrome is built and set the chrome_version. |
| 421 | self.PatchObject(packages_service, 'builds', return_value=True) |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 422 | chrome_version = '76.0.1.2' |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 423 | chrome_version_mock = self.PatchObject(packages_service, |
| 424 | 'determine_chrome_version', |
| 425 | return_value=chrome_version) |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 426 | android_version = 'android_test_version' |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 427 | android_version_mock = self.PatchObject(packages_service, |
| 428 | 'determine_android_version', |
| 429 | return_value=android_version) |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 430 | android_branch = 'android_test_branch' |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 431 | android_branch_mock = self.PatchObject(packages_service, |
| 432 | 'determine_android_branch', |
| 433 | return_value=android_branch) |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 434 | android_target = 'android_test_target' |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 435 | android_target_mock = self.PatchObject(packages_service, |
| 436 | 'determine_android_target', |
| 437 | return_value=android_target) |
Michael Mortensen | 9fdb14b | 2019-10-17 11:17:30 -0600 | [diff] [blame] | 438 | platform_version = '12345.1.2' |
| 439 | self.PatchObject(packages_service, 'determine_platform_version', |
| 440 | return_value=platform_version) |
Michael Mortensen | 009cb66 | 2019-10-21 11:38:43 -0600 | [diff] [blame] | 441 | milestone_version = '79' |
| 442 | self.PatchObject(packages_service, 'determine_milestone_version', |
| 443 | return_value=milestone_version) |
| 444 | full_version = 'R79-12345.1.2' |
| 445 | self.PatchObject(packages_service, 'determine_full_version', |
| 446 | return_value=full_version) |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 447 | request = self._GetRequest(board='betty') |
| 448 | packages_controller.GetTargetVersions(request, self.response, |
| 449 | self.api_config) |
| 450 | self.assertEqual(self.response.android_version, android_version) |
| 451 | self.assertEqual(self.response.android_branch_version, android_branch) |
| 452 | self.assertEqual(self.response.android_target_version, android_target) |
| 453 | self.assertEqual(self.response.chrome_version, chrome_version) |
Michael Mortensen | 9fdb14b | 2019-10-17 11:17:30 -0600 | [diff] [blame] | 454 | self.assertEqual(self.response.platform_version, platform_version) |
Michael Mortensen | 009cb66 | 2019-10-21 11:38:43 -0600 | [diff] [blame] | 455 | self.assertEqual(self.response.milestone_version, milestone_version) |
| 456 | self.assertEqual(self.response.full_version, full_version) |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 457 | # Verify call to determine_chrome_version passes a build_target object. |
| 458 | build_target = build_target_lib.BuildTarget('betty') |
| 459 | chrome_version_mock.assert_called_with(build_target) |
| 460 | # Verify call to determine_android_version passes a list of the board name. |
| 461 | android_version_mock.assert_called_with(['betty']) |
| 462 | # Verify call to determine_android_branch passes a board name. |
| 463 | android_branch_mock.assert_called_with('betty') |
| 464 | # Verify call to determine_android_target passes a board name. |
| 465 | android_target_mock.assert_called_with('betty') |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 466 | |
Michael Mortensen | 42c330e3 | 2020-09-02 09:59:16 -0600 | [diff] [blame] | 467 | def testGetTargetVersionsWithPackagesSet(self): |
| 468 | """Verify packages pass through and basic return values.""" |
| 469 | # TODO(crbug.com/1124393): Migrate this test to use portage_testables |
| 470 | # rather than mocking the boundary to portage calls such as |
| 471 | # packages_service.builds). |
| 472 | builds_mock = self.PatchObject(packages_service, 'builds', |
| 473 | return_value=True) |
| 474 | # Mock that chrome is built and set the chrome_version. |
| 475 | chrome_version = '76.0.1.2' |
| 476 | self.PatchObject(packages_service, 'determine_chrome_version', |
| 477 | return_value=chrome_version) |
| 478 | android_version = 'android_test_version' |
| 479 | self.PatchObject(packages_service, 'determine_android_version', |
| 480 | return_value=android_version) |
| 481 | android_branch = 'android_test_branch' |
| 482 | self.PatchObject(packages_service, 'determine_android_branch', |
| 483 | return_value=android_branch) |
| 484 | android_target = 'android_test_target' |
| 485 | self.PatchObject(packages_service, 'determine_android_target', |
| 486 | return_value=android_target) |
| 487 | platform_version = '12345.1.2' |
| 488 | self.PatchObject(packages_service, 'determine_platform_version', |
| 489 | return_value=platform_version) |
| 490 | milestone_version = '79' |
| 491 | self.PatchObject(packages_service, 'determine_milestone_version', |
| 492 | return_value=milestone_version) |
| 493 | full_version = 'R79-12345.1.2' |
| 494 | self.PatchObject(packages_service, 'determine_full_version', |
| 495 | return_value=full_version) |
| 496 | request = self._GetRequest(board='betty') |
| 497 | # Add optional packages to the request. |
| 498 | cpv_package_list = [] |
| 499 | package = request.packages.add() |
| 500 | package.package_name = 'test' |
| 501 | package.category = 'chromeos-base' |
| 502 | package.version = '0.0.1-r1' |
| 503 | cpv_package_list.append(controller_util.PackageInfoToCPV(package)) |
| 504 | package = request.packages.add() |
| 505 | package.package_name = 'target-fuzzers' |
| 506 | package.category = 'virtual' |
| 507 | cpv_package_list.append(controller_util.PackageInfoToCPV(package)) |
| 508 | |
| 509 | packages_controller.GetTargetVersions(request, self.response, |
| 510 | self.api_config) |
| 511 | self.assertEqual(self.response.android_version, android_version) |
| 512 | self.assertEqual(self.response.android_branch_version, android_branch) |
| 513 | self.assertEqual(self.response.android_target_version, android_target) |
| 514 | self.assertEqual(self.response.chrome_version, chrome_version) |
| 515 | self.assertEqual(self.response.platform_version, platform_version) |
| 516 | self.assertEqual(self.response.milestone_version, milestone_version) |
| 517 | # Verify call to packages.builds passes the package list. |
| 518 | builds_mock.assert_called_with(constants.CHROME_CP, |
| 519 | mock.ANY, # Match the build target object |
| 520 | packages=cpv_package_list) |
| 521 | |
Michael Mortensen | 1d2ab0d | 2019-10-17 13:19:25 -0600 | [diff] [blame] | 522 | def testGetTargetVersionNoAndroidNoChrome(self): |
Michael Mortensen | edf7653 | 2019-10-16 14:22:37 -0600 | [diff] [blame] | 523 | """Verify return values on a board that does not have android.""" |
Michael Mortensen | 9fdb14b | 2019-10-17 11:17:30 -0600 | [diff] [blame] | 524 | platform_version = '12345.1.2' |
| 525 | self.PatchObject(packages_service, 'determine_platform_version', |
| 526 | return_value=platform_version) |
Michael Mortensen | 1d2ab0d | 2019-10-17 13:19:25 -0600 | [diff] [blame] | 527 | self.PatchObject(packages_service, 'builds', return_value=False) |
Michael Mortensen | edf7653 | 2019-10-16 14:22:37 -0600 | [diff] [blame] | 528 | self.PatchObject(packages_service, 'determine_android_version', |
| 529 | return_value=None) |
| 530 | self.PatchObject(packages_service, 'determine_android_branch', |
| 531 | return_value=None) |
| 532 | self.PatchObject(packages_service, 'determine_android_target', |
| 533 | return_value=None) |
| 534 | request = self._GetRequest(board='betty') |
| 535 | packages_controller.GetTargetVersions(request, self.response, |
| 536 | self.api_config) |
Michael Mortensen | 1d2ab0d | 2019-10-17 13:19:25 -0600 | [diff] [blame] | 537 | self.assertFalse(self.response.chrome_version) |
Michael Mortensen | edf7653 | 2019-10-16 14:22:37 -0600 | [diff] [blame] | 538 | self.assertFalse(self.response.android_version) |
| 539 | self.assertFalse(self.response.android_branch_version) |
| 540 | self.assertFalse(self.response.android_target_version) |
Michael Mortensen | 9fdb14b | 2019-10-17 11:17:30 -0600 | [diff] [blame] | 541 | self.assertEqual(self.response.platform_version, platform_version) |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 542 | |
Michael Mortensen | bfc5639 | 2020-04-30 15:23:47 -0600 | [diff] [blame] | 543 | |
| 544 | class GetBuilderMetadataTest(cros_test_lib.MockTestCase, ApiConfigMixin): |
| 545 | """GetBuilderMetadata tests.""" |
| 546 | |
| 547 | def setUp(self): |
| 548 | self.response = packages_pb2.GetBuilderMetadataResponse() |
| 549 | |
| 550 | def _GetRequest(self, board=None): |
| 551 | """Helper to build out a request.""" |
| 552 | request = packages_pb2.GetBuilderMetadataRequest() |
| 553 | |
| 554 | if board: |
| 555 | request.build_target.name = board |
| 556 | |
| 557 | return request |
| 558 | |
| 559 | def testValidateOnly(self): |
| 560 | """Sanity check that a validate only call does not execute any logic.""" |
| 561 | request = self._GetRequest(board='betty') |
Michael Mortensen | 76e1512 | 2020-06-03 11:07:28 -0600 | [diff] [blame] | 562 | patch_version = self.PatchObject(packages_service, |
| 563 | 'determine_android_version') |
| 564 | patch_branch_version = self.PatchObject(packages_service, |
| 565 | 'determine_android_branch') |
| 566 | patch_fw_versions = self.PatchObject(packages_service, |
| 567 | 'determine_firmware_versions') |
| 568 | patch_fingerprints = self.PatchObject(packages_service, |
| 569 | 'find_fingerprints') |
| 570 | patch_get_models = self.PatchObject(packages_service, |
| 571 | 'get_models') |
Michael Mortensen | bfc5639 | 2020-04-30 15:23:47 -0600 | [diff] [blame] | 572 | packages_controller.GetBuilderMetadata(request, self.response, |
| 573 | self.validate_only_config) |
Michael Mortensen | 76e1512 | 2020-06-03 11:07:28 -0600 | [diff] [blame] | 574 | patch_version.assert_not_called() |
| 575 | patch_branch_version.assert_not_called() |
| 576 | patch_fw_versions.assert_not_called() |
| 577 | patch_fingerprints.assert_not_called() |
| 578 | patch_get_models.assert_not_called() |
Michael Mortensen | bfc5639 | 2020-04-30 15:23:47 -0600 | [diff] [blame] | 579 | |
| 580 | def testMockCall(self): |
| 581 | """Test that a mock call does not execute logic, returns mocked value.""" |
| 582 | request = self._GetRequest(board='betty') |
Michael Mortensen | 76e1512 | 2020-06-03 11:07:28 -0600 | [diff] [blame] | 583 | patch_version = self.PatchObject(packages_service, |
| 584 | 'determine_android_version') |
| 585 | patch_branch_version = self.PatchObject(packages_service, |
| 586 | 'determine_android_branch') |
| 587 | patch_fw_versions = self.PatchObject(packages_service, |
| 588 | 'determine_firmware_versions') |
| 589 | patch_fingerprints = self.PatchObject(packages_service, |
| 590 | 'find_fingerprints') |
| 591 | patch_get_models = self.PatchObject(packages_service, |
| 592 | 'get_models') |
Michael Mortensen | bfc5639 | 2020-04-30 15:23:47 -0600 | [diff] [blame] | 593 | packages_controller.GetBuilderMetadata(request, self.response, |
| 594 | self.mock_call_config) |
Michael Mortensen | 76e1512 | 2020-06-03 11:07:28 -0600 | [diff] [blame] | 595 | patch_version.assert_not_called() |
| 596 | patch_branch_version.assert_not_called() |
| 597 | patch_fw_versions.assert_not_called() |
| 598 | patch_fingerprints.assert_not_called() |
| 599 | patch_get_models.assert_not_called() |
Michael Mortensen | bfc5639 | 2020-04-30 15:23:47 -0600 | [diff] [blame] | 600 | |
| 601 | self.assertEqual(len(self.response.build_target_metadata), 1) |
| 602 | self.assertEqual(self.response.build_target_metadata[0].build_target, |
| 603 | request.build_target.name) |
| 604 | self.assertEqual(len(self.response.model_metadata), 1) |
| 605 | self.assertTrue(self.response.model_metadata[0].model_name) |
| 606 | self.assertTrue(self.response.model_metadata[0].ec_firmware_version) |
| 607 | |
| 608 | def testNoBuildTargetFails(self): |
| 609 | """No build target argument should fail.""" |
| 610 | request = self._GetRequest() |
| 611 | |
| 612 | with self.assertRaises(cros_build_lib.DieSystemExit): |
| 613 | packages_controller.GetBuilderMetadata(request, self.response, |
| 614 | self.api_config) |
| 615 | |
Michael Mortensen | bbce7e4 | 2020-05-01 15:03:49 -0600 | [diff] [blame] | 616 | def testGetBuilderMetadata(self): |
| 617 | """Verify basic return values.""" |
| 618 | android_version = 'android_test_version' |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 619 | android_version_mock = self.PatchObject(packages_service, |
| 620 | 'determine_android_version', |
| 621 | return_value=android_version) |
Michael Mortensen | bbce7e4 | 2020-05-01 15:03:49 -0600 | [diff] [blame] | 622 | android_branch = 'android_test_branch' |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 623 | android_branch_mock = self.PatchObject(packages_service, |
| 624 | 'determine_android_branch', |
| 625 | return_value=android_branch) |
Michael Mortensen | bbce7e4 | 2020-05-01 15:03:49 -0600 | [diff] [blame] | 626 | android_target = 'android_test_target' |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 627 | android_target_mock = self.PatchObject(packages_service, |
| 628 | 'determine_android_target', |
| 629 | return_value=android_target) |
Michael Mortensen | bbce7e4 | 2020-05-01 15:03:49 -0600 | [diff] [blame] | 630 | self.PatchObject(portage_util, 'GetBoardUseFlags', |
| 631 | return_value=['arc', 'arcvm', 'big_little', 'cheets']) |
Michael Mortensen | fbf2b2d | 2020-05-14 16:33:06 -0600 | [diff] [blame] | 632 | package_result = ['sys-kernel/linux-headers-4.14-r24', |
| 633 | 'sys-devel/flex-2.6.4-r1', |
| 634 | 'sys-kernel/chromeos-kernel-4_4-4.4.223-r2209'] |
| 635 | self.PatchObject(portage_util, 'GetPackageDependencies', |
| 636 | return_value=package_result) |
| 637 | |
Michael Mortensen | a4af79e | 2020-05-06 16:18:48 -0600 | [diff] [blame] | 638 | fw_versions = packages_service.FirmwareVersions( |
| 639 | None, |
| 640 | 'Google_Caroline.7820.263.0', |
| 641 | 'Google_Caroline.7820.286.0', |
| 642 | 'caroline_v1.9.357-ac5c7b4', |
| 643 | 'caroline_v1.9.370-e8b9bd2') |
| 644 | self.PatchObject(packages_service, 'get_firmware_versions', |
| 645 | return_value=fw_versions) |
Michael Mortensen | de716a1 | 2020-05-15 11:27:00 -0600 | [diff] [blame] | 646 | fingerprints = ['fingerprint1', 'fingerprint2'] |
| 647 | self.PatchObject(packages_service, 'find_fingerprints', |
| 648 | return_value=fingerprints) |
Michael Mortensen | 770bc12 | 2020-05-27 17:53:30 -0600 | [diff] [blame] | 649 | # Patch packages.get_models, packages.get_all_firmware_versions, |
| 650 | # and packages.get_key_id for calls needed by model_metadata. |
| 651 | model_list = ['pyro', 'reef'] |
| 652 | all_fw_versions = { |
| 653 | 'pyro': packages_service.FirmwareVersions( |
| 654 | 'pyro', |
| 655 | 'Google_Pyro.9042.87.1', |
| 656 | 'Google_Pyro.9042.110.0', |
| 657 | 'pyro_v1.1.5900-ab1ee51', |
| 658 | 'pyro_v1.1.5909-bd1f0c9'), |
| 659 | 'reef': packages_service.FirmwareVersions( |
| 660 | 'reef', |
| 661 | 'Google_Reef.9042.87.1', |
| 662 | 'Google_Reef.9042.110.0', |
| 663 | 'reef_v1.1.5900-ab1ee51', |
| 664 | 'reef_v1.1.5909-bd1f0c9') |
| 665 | } |
| 666 | self.PatchObject(packages_service, 'get_all_firmware_versions', |
| 667 | return_value=all_fw_versions) |
| 668 | self.PatchObject(packages_service, 'get_models', |
| 669 | return_value=model_list) |
| 670 | self.PatchObject(packages_service, 'get_key_id', |
| 671 | return_value='key') |
| 672 | |
Michael Mortensen | bbce7e4 | 2020-05-01 15:03:49 -0600 | [diff] [blame] | 673 | request = self._GetRequest(board='betty') |
| 674 | packages_controller.GetBuilderMetadata(request, self.response, |
| 675 | self.api_config) |
| 676 | self.assertEqual( |
| 677 | self.response.build_target_metadata[0].build_target, |
| 678 | 'betty') |
| 679 | self.assertEqual( |
| 680 | self.response.build_target_metadata[0].android_container_version, |
| 681 | android_version) |
| 682 | self.assertEqual( |
| 683 | self.response.build_target_metadata[0].android_container_branch, |
| 684 | android_branch) |
| 685 | self.assertEqual( |
| 686 | self.response.build_target_metadata[0].android_container_target, |
| 687 | android_target) |
| 688 | self.assertEqual( |
| 689 | self.response.build_target_metadata[0].arc_use_set, |
| 690 | True) |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 691 | # Verify call to determine_android_version passes list of the board name. |
| 692 | android_version_mock.assert_called_with(['betty']) |
| 693 | # Verify call to determine_android_branch passes board name. |
| 694 | android_branch_mock.assert_called_with('betty') |
| 695 | # Verify call to determine_android_target passes board name. |
| 696 | android_target_mock.assert_called_with('betty') |
Michael Mortensen | a4af79e | 2020-05-06 16:18:48 -0600 | [diff] [blame] | 697 | self.assertEqual( |
| 698 | self.response.build_target_metadata[0].main_firmware_version, |
| 699 | 'Google_Caroline.7820.286.0') |
| 700 | self.assertEqual( |
| 701 | self.response.build_target_metadata[0].ec_firmware_version, |
| 702 | 'caroline_v1.9.370-e8b9bd2') |
Michael Mortensen | fbf2b2d | 2020-05-14 16:33:06 -0600 | [diff] [blame] | 703 | self.assertEqual( |
| 704 | self.response.build_target_metadata[0].kernel_version, |
| 705 | '4.4.223-r2209') |
Michael Mortensen | de716a1 | 2020-05-15 11:27:00 -0600 | [diff] [blame] | 706 | self.assertEqual( |
| 707 | len(self.response.build_target_metadata[0].fingerprints), |
| 708 | 2) |
| 709 | self.assertEqual( |
| 710 | self.response.build_target_metadata[0].fingerprints, |
| 711 | fingerprints) |
Michael Mortensen | 770bc12 | 2020-05-27 17:53:30 -0600 | [diff] [blame] | 712 | self.assertEqual( |
| 713 | len(self.response.model_metadata), 2) |
| 714 | self.assertEqual( |
| 715 | self.response.model_metadata[0].model_name, 'pyro') |
| 716 | self.assertEqual( |
| 717 | self.response.model_metadata[0].ec_firmware_version, |
| 718 | 'pyro_v1.1.5909-bd1f0c9') |
| 719 | self.assertEqual( |
| 720 | self.response.model_metadata[0].firmware_key_id, 'key') |
| 721 | self.assertEqual( |
| 722 | self.response.model_metadata[0].main_readonly_firmware_version, |
| 723 | 'Google_Pyro.9042.87.1') |
| 724 | self.assertEqual( |
| 725 | self.response.model_metadata[0].main_readwrite_firmware_version, |
| 726 | 'Google_Pyro.9042.110.0') |
| 727 | self.assertEqual( |
| 728 | self.response.model_metadata[1].model_name, 'reef') |
| 729 | self.assertEqual( |
| 730 | self.response.model_metadata[1].ec_firmware_version, |
| 731 | 'reef_v1.1.5909-bd1f0c9') |
| 732 | self.assertEqual( |
| 733 | self.response.model_metadata[1].firmware_key_id, 'key') |
| 734 | self.assertEqual( |
| 735 | self.response.model_metadata[1].main_readonly_firmware_version, |
| 736 | 'Google_Reef.9042.87.1') |
| 737 | self.assertEqual( |
| 738 | self.response.model_metadata[1].main_readwrite_firmware_version, |
| 739 | 'Google_Reef.9042.110.0') |
Michael Mortensen | bbce7e4 | 2020-05-01 15:03:49 -0600 | [diff] [blame] | 740 | |
Michael Mortensen | d81d81e | 2020-06-09 14:20:59 -0600 | [diff] [blame] | 741 | # Test corner case where find_fingerprints returns None. |
| 742 | # Re-patch find_fingerprints to now return None and re-execute |
| 743 | # GetBuilderMetadata to verify behavior. |
| 744 | response = packages_pb2.GetBuilderMetadataResponse() |
| 745 | self.PatchObject(packages_service, 'find_fingerprints', |
| 746 | return_value=[]) |
| 747 | request = self._GetRequest(board='betty') |
| 748 | packages_controller.GetBuilderMetadata(request, response, |
| 749 | self.api_config) |
| 750 | # Verify a non-fingerprint build_target_metdata field was still set. |
| 751 | self.assertEqual( |
| 752 | response.build_target_metadata[0].kernel_version, |
| 753 | '4.4.223-r2209') |
| 754 | # And then verify that fingerprints was empty. |
| 755 | self.assertEqual(response.build_target_metadata[0].fingerprints, []) |
| 756 | |
Michael Mortensen | bbce7e4 | 2020-05-01 15:03:49 -0600 | [diff] [blame] | 757 | |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 758 | class HasChromePrebuiltTest(cros_test_lib.MockTestCase, ApiConfigMixin): |
| 759 | """HasChromePrebuilt tests.""" |
| 760 | |
| 761 | def setUp(self): |
| 762 | self.response = packages_pb2.HasChromePrebuiltResponse() |
| 763 | |
| 764 | def _GetRequest(self, board=None): |
| 765 | """Helper to build out a request.""" |
| 766 | request = packages_pb2.HasChromePrebuiltRequest() |
| 767 | |
| 768 | if board: |
| 769 | request.build_target.name = board |
| 770 | |
| 771 | return request |
| 772 | |
| 773 | def testValidateOnly(self): |
| 774 | """Sanity check that a validate only call does not execute any logic.""" |
| 775 | patch = self.PatchObject(packages_service, 'has_prebuilt') |
| 776 | |
| 777 | request = self._GetRequest(board='betty') |
| 778 | packages_controller.HasChromePrebuilt(request, self.response, |
| 779 | self.validate_only_config) |
| 780 | patch.assert_not_called() |
| 781 | |
Michael Mortensen | 3232ab3 | 2020-01-05 19:14:36 -0700 | [diff] [blame] | 782 | def testMockCall(self): |
| 783 | """Test that a mock call does not execute logic, returns mocked value.""" |
| 784 | patch = self.PatchObject(packages_service, 'has_prebuilt') |
| 785 | |
| 786 | request = self._GetRequest(board='betty') |
| 787 | packages_controller.HasChromePrebuilt(request, self.response, |
| 788 | self.mock_call_config) |
| 789 | patch.assert_not_called() |
| 790 | self.assertTrue(self.response.has_prebuilt) |
| 791 | |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 792 | def testNoBuildTargetFails(self): |
| 793 | """No build target argument should fail.""" |
| 794 | request = self._GetRequest() |
| 795 | |
| 796 | with self.assertRaises(cros_build_lib.DieSystemExit): |
| 797 | packages_controller.HasChromePrebuilt(request, self.response, |
| 798 | self.api_config) |
Alex Klein | 73fb657 | 2019-09-30 16:55:23 -0600 | [diff] [blame] | 799 | |
| 800 | |
| 801 | class BuildsChromeTest(cros_test_lib.MockTestCase, ApiConfigMixin): |
| 802 | """BuildsChrome tests.""" |
| 803 | |
| 804 | def setUp(self): |
| 805 | self.response = packages_pb2.BuildsChromeResponse() |
| 806 | |
David Burger | 0f9dd4e | 2019-10-08 12:33:42 -0600 | [diff] [blame] | 807 | def _GetRequest(self, board=None, packages=None): |
Alex Klein | 73fb657 | 2019-09-30 16:55:23 -0600 | [diff] [blame] | 808 | """Helper to build out a request.""" |
| 809 | request = packages_pb2.BuildsChromeRequest() |
| 810 | |
| 811 | if board: |
| 812 | request.build_target.name = board |
| 813 | |
David Burger | 0f9dd4e | 2019-10-08 12:33:42 -0600 | [diff] [blame] | 814 | if packages: |
| 815 | request.packages.extend(packages) |
| 816 | |
Alex Klein | 73fb657 | 2019-09-30 16:55:23 -0600 | [diff] [blame] | 817 | return request |
| 818 | |
| 819 | def testValidateOnly(self): |
| 820 | """Sanity check that a validate only call does not execute any logic.""" |
Alex Klein | e65131f | 2019-10-03 10:34:01 -0600 | [diff] [blame] | 821 | patch = self.PatchObject(packages_service, 'builds') |
Alex Klein | 73fb657 | 2019-09-30 16:55:23 -0600 | [diff] [blame] | 822 | |
| 823 | request = self._GetRequest(board='betty') |
| 824 | packages_controller.BuildsChrome(request, self.response, |
| 825 | self.validate_only_config) |
| 826 | patch.assert_not_called() |
| 827 | |
| 828 | def testNoBuildTargetFails(self): |
| 829 | """No build target argument should fail.""" |
| 830 | request = self._GetRequest() |
| 831 | |
| 832 | with self.assertRaises(cros_build_lib.DieSystemExit): |
| 833 | packages_controller.BuildsChrome(request, self.response, self.api_config) |
Alex Klein | e65131f | 2019-10-03 10:34:01 -0600 | [diff] [blame] | 834 | |
| 835 | def testBuilds(self): |
| 836 | """Test successful call handling.""" |
| 837 | patch = self.PatchObject(packages_service, 'builds', return_value=True) |
| 838 | |
| 839 | request = self._GetRequest(board='foo') |
| 840 | packages_controller.BuildsChrome(request, self.response, self.api_config) |
| 841 | self.assertTrue(self.response.builds_chrome) |
Alex Klein | 26e472b | 2020-03-10 14:35:01 -0600 | [diff] [blame] | 842 | patch.assert_called_once_with(constants.CHROME_CP, |
| 843 | build_target_lib.BuildTarget('foo'), []) |
David Burger | 0f9dd4e | 2019-10-08 12:33:42 -0600 | [diff] [blame] | 844 | |
| 845 | def testBuildsChromeWithPackages(self): |
| 846 | """Test successful call with packages handling.""" |
| 847 | patch = self.PatchObject(packages_service, 'builds', return_value=True) |
| 848 | |
| 849 | package = common_pb2.PackageInfo( |
| 850 | category='category', |
| 851 | package_name='name', |
| 852 | version='1.01', |
| 853 | ) |
| 854 | request = self._GetRequest(board='foo', packages=[package]) |
| 855 | packages_controller.BuildsChrome(request, self.response, self.api_config) |
| 856 | self.assertTrue(self.response.builds_chrome) |
Alex Klein | 26e472b | 2020-03-10 14:35:01 -0600 | [diff] [blame] | 857 | patch.assert_called_once_with(constants.CHROME_CP, |
| 858 | build_target_lib.BuildTarget('foo'), |
David Burger | 0f9dd4e | 2019-10-08 12:33:42 -0600 | [diff] [blame] | 859 | [controller_util.PackageInfoToCPV(package)]) |