Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 1 | # Copyright 2019 The Chromium OS Authors. All rights reserved. |
| 2 | # Use of this source code is governed by a BSD-style license that can be |
| 3 | # found in the LICENSE file. |
| 4 | |
| 5 | """packages controller unit tests.""" |
| 6 | |
Mike Frysinger | 166fea0 | 2021-02-12 05:30:33 -0500 | [diff] [blame] | 7 | from unittest import mock |
| 8 | |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 9 | from chromite.api.api_config import ApiConfigMixin |
David Burger | 0f9dd4e | 2019-10-08 12:33:42 -0600 | [diff] [blame] | 10 | from chromite.api.controller import controller_util |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 11 | from chromite.api.controller import packages as packages_controller |
David Burger | 0f9dd4e | 2019-10-08 12:33:42 -0600 | [diff] [blame] | 12 | from chromite.api.gen.chromiumos import common_pb2 |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 13 | from chromite.api.gen.chromite.api import binhost_pb2 |
| 14 | from chromite.api.gen.chromite.api import packages_pb2 |
Chris McDonald | 3840911 | 2020-09-24 11:24:51 -0600 | [diff] [blame] | 15 | from chromite.lib import build_target_lib |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 16 | from chromite.lib import constants |
| 17 | from chromite.lib import cros_build_lib |
| 18 | from chromite.lib import cros_test_lib |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 19 | from chromite.lib import portage_util |
Chris McDonald | 3840911 | 2020-09-24 11:24:51 -0600 | [diff] [blame] | 20 | from chromite.lib import uprev_lib |
Alex Klein | 75df179 | 2020-06-11 14:42:49 -0600 | [diff] [blame] | 21 | from chromite.lib.parser import package_info |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 22 | from chromite.service import packages as packages_service |
| 23 | |
| 24 | |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 25 | class UprevTest(cros_test_lib.MockTestCase, ApiConfigMixin): |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 26 | """Uprev tests.""" |
| 27 | |
| 28 | _PUBLIC = binhost_pb2.OVERLAYTYPE_PUBLIC |
| 29 | _PRIVATE = binhost_pb2.OVERLAYTYPE_PRIVATE |
| 30 | _BOTH = binhost_pb2.OVERLAYTYPE_BOTH |
| 31 | _NONE = binhost_pb2.OVERLAYTYPE_NONE |
| 32 | |
| 33 | def setUp(self): |
| 34 | self.uprev_patch = self.PatchObject(packages_service, 'uprev_build_targets') |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 35 | self.response = packages_pb2.UprevPackagesResponse() |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 36 | |
| 37 | def _GetRequest(self, targets=None, overlay_type=None, output_dir=None): |
| 38 | return packages_pb2.UprevPackagesRequest( |
| 39 | build_targets=[{'name': name} for name in targets or []], |
| 40 | overlay_type=overlay_type, |
| 41 | output_dir=output_dir, |
| 42 | ) |
| 43 | |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 44 | def testValidateOnly(self): |
| 45 | """Sanity check that a validate only call does not execute any logic.""" |
| 46 | patch = self.PatchObject(packages_service, 'uprev_build_targets') |
| 47 | |
| 48 | targets = ['foo', 'bar'] |
| 49 | request = self._GetRequest(targets=targets, overlay_type=self._BOTH) |
| 50 | packages_controller.Uprev(request, self.response, self.validate_only_config) |
| 51 | patch.assert_not_called() |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 52 | |
Michael Mortensen | 2677bf6 | 2019-10-29 08:31:25 -0600 | [diff] [blame] | 53 | def testMockCall(self): |
| 54 | """Test that a mock call does not execute logic, returns mocked value.""" |
| 55 | patch = self.PatchObject(packages_service, 'uprev_build_targets') |
| 56 | targets = ['foo', 'bar'] |
| 57 | request = self._GetRequest(targets=targets, overlay_type=self._BOTH) |
| 58 | packages_controller.Uprev(request, self.response, self.mock_call_config) |
| 59 | patch.assert_not_called() |
| 60 | self.assertTrue(self.response.modified_ebuilds) |
| 61 | |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 62 | def testNoOverlayTypeFails(self): |
| 63 | """No overlay type provided should fail.""" |
| 64 | request = self._GetRequest(targets=['foo']) |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 65 | |
| 66 | with self.assertRaises(cros_build_lib.DieSystemExit): |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 67 | packages_controller.Uprev(request, self.response, self.api_config) |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 68 | |
| 69 | def testOverlayTypeNoneFails(self): |
| 70 | """Overlay type none means nothing here and should fail.""" |
| 71 | request = self._GetRequest(targets=['foo'], overlay_type=self._NONE) |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 72 | |
| 73 | with self.assertRaises(cros_build_lib.DieSystemExit): |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 74 | packages_controller.Uprev(request, self.response, self.api_config) |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 75 | |
| 76 | def testSuccess(self): |
| 77 | """Test overall successful argument handling.""" |
| 78 | targets = ['foo', 'bar'] |
| 79 | output_dir = '/tmp/uprev_output_dir' |
Alex Klein | 5dd6b1e | 2019-07-31 15:45:24 -0600 | [diff] [blame] | 80 | changed = ['/ebuild-1.0-r1.ebuild', '/ebuild-1.0-r2.ebuild'] |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 81 | expected_type = constants.BOTH_OVERLAYS |
| 82 | request = self._GetRequest(targets=targets, overlay_type=self._BOTH, |
| 83 | output_dir=output_dir) |
Alex Klein | 5dd6b1e | 2019-07-31 15:45:24 -0600 | [diff] [blame] | 84 | uprev_patch = self.PatchObject(packages_service, 'uprev_build_targets', |
| 85 | return_value=changed) |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 86 | |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 87 | packages_controller.Uprev(request, self.response, self.api_config) |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 88 | |
| 89 | # Make sure the type is right, verify build targets after. |
| 90 | uprev_patch.assert_called_once_with(mock.ANY, expected_type, mock.ANY, |
| 91 | output_dir) |
| 92 | # First argument (build targets) of the first (only) call. |
| 93 | call_targets = uprev_patch.call_args[0][0] |
Mike Frysinger | 678735c | 2019-09-28 18:23:28 -0400 | [diff] [blame] | 94 | self.assertCountEqual(targets, [t.name for t in call_targets]) |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 95 | |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 96 | for ebuild in self.response.modified_ebuilds: |
Alex Klein | 5dd6b1e | 2019-07-31 15:45:24 -0600 | [diff] [blame] | 97 | self.assertIn(ebuild.path, changed) |
| 98 | changed.remove(ebuild.path) |
| 99 | self.assertFalse(changed) |
| 100 | |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 101 | |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 102 | class UprevVersionedPackageTest(cros_test_lib.MockTestCase, ApiConfigMixin): |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 103 | """UprevVersionedPackage tests.""" |
| 104 | |
| 105 | def setUp(self): |
Yaakov Shaul | 730814a | 2019-09-10 13:58:25 -0600 | [diff] [blame] | 106 | self.response = packages_pb2.UprevVersionedPackageResponse() |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 107 | |
| 108 | def _addVersion(self, request, version): |
| 109 | """Helper method to add a full version message to the request.""" |
| 110 | ref = request.versions.add() |
| 111 | ref.repository = '/some/path' |
Alex Klein | 34afcbc | 2019-08-22 16:14:31 -0600 | [diff] [blame] | 112 | ref.ref = 'refs/tags/%s' % version |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 113 | ref.revision = 'abc123' |
| 114 | |
| 115 | def testValidateOnly(self): |
| 116 | """Sanity check validate only calls are working properly.""" |
| 117 | service = self.PatchObject(packages_service, 'uprev_versioned_package') |
| 118 | |
| 119 | request = packages_pb2.UprevVersionedPackageRequest() |
| 120 | self._addVersion(request, '1.2.3.4') |
| 121 | request.package_info.category = 'chromeos-base' |
| 122 | request.package_info.package_name = 'chromeos-chrome' |
| 123 | |
| 124 | packages_controller.UprevVersionedPackage(request, self.response, |
| 125 | self.validate_only_config) |
| 126 | |
| 127 | service.assert_not_called() |
| 128 | |
Michael Mortensen | 2677bf6 | 2019-10-29 08:31:25 -0600 | [diff] [blame] | 129 | def testMockCall(self): |
| 130 | """Test that a mock call does not execute logic, returns mocked value.""" |
| 131 | patch = self.PatchObject(packages_service, 'uprev_versioned_package') |
| 132 | request = packages_pb2.UprevVersionedPackageRequest() |
| 133 | packages_controller.UprevVersionedPackage(request, self.response, |
| 134 | self.mock_call_config) |
| 135 | patch.assert_not_called() |
| 136 | self.assertTrue(self.response.responses) |
| 137 | self.assertTrue(self.response.responses[0].modified_ebuilds) |
| 138 | |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 139 | def testNoVersions(self): |
| 140 | """Test no versions provided.""" |
| 141 | request = packages_pb2.UprevVersionedPackageRequest() |
| 142 | request.package_info.category = 'chromeos-base' |
| 143 | request.package_info.package_name = 'chromeos-chrome' |
| 144 | |
| 145 | with self.assertRaises(cros_build_lib.DieSystemExit): |
| 146 | packages_controller.UprevVersionedPackage(request, self.response, |
| 147 | self.api_config) |
| 148 | |
| 149 | def testNoPackageName(self): |
| 150 | """Test no package name provided.""" |
| 151 | request = packages_pb2.UprevVersionedPackageRequest() |
| 152 | self._addVersion(request, '1.2.3.4') |
| 153 | request.package_info.category = 'chromeos-base' |
| 154 | |
| 155 | with self.assertRaises(cros_build_lib.DieSystemExit): |
| 156 | packages_controller.UprevVersionedPackage(request, self.response, |
| 157 | self.api_config) |
| 158 | |
| 159 | def testNoCategory(self): |
| 160 | """Test no package category provided.""" |
| 161 | request = packages_pb2.UprevVersionedPackageRequest() |
| 162 | self._addVersion(request, '1.2.3.4') |
| 163 | request.package_info.package_name = 'chromeos-chrome' |
| 164 | |
| 165 | with self.assertRaises(cros_build_lib.DieSystemExit): |
| 166 | packages_controller.UprevVersionedPackage(request, self.response, |
| 167 | self.api_config) |
| 168 | |
| 169 | def testOutputHandling(self): |
| 170 | """Test the modified files are getting correctly added to the output.""" |
Alex Klein | 34afcbc | 2019-08-22 16:14:31 -0600 | [diff] [blame] | 171 | version = '1.2.3.4' |
Chris McDonald | 3840911 | 2020-09-24 11:24:51 -0600 | [diff] [blame] | 172 | result = uprev_lib.UprevVersionedPackageResult().add_result( |
Alex Klein | 34afcbc | 2019-08-22 16:14:31 -0600 | [diff] [blame] | 173 | version, ['/file/one', '/file/two']) |
Yaakov Shaul | 730814a | 2019-09-10 13:58:25 -0600 | [diff] [blame] | 174 | |
Alex Klein | 34afcbc | 2019-08-22 16:14:31 -0600 | [diff] [blame] | 175 | self.PatchObject( |
| 176 | packages_service, 'uprev_versioned_package', return_value=result) |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 177 | |
| 178 | request = packages_pb2.UprevVersionedPackageRequest() |
Alex Klein | 34afcbc | 2019-08-22 16:14:31 -0600 | [diff] [blame] | 179 | self._addVersion(request, version) |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 180 | request.package_info.category = 'chromeos-base' |
| 181 | request.package_info.package_name = 'chromeos-chrome' |
| 182 | |
| 183 | packages_controller.UprevVersionedPackage(request, self.response, |
| 184 | self.api_config) |
| 185 | |
Yaakov Shaul | 730814a | 2019-09-10 13:58:25 -0600 | [diff] [blame] | 186 | for idx, uprev_response in enumerate(self.response.responses): |
| 187 | self.assertEqual(result.modified[idx].new_version, uprev_response.version) |
Mike Frysinger | 678735c | 2019-09-28 18:23:28 -0400 | [diff] [blame] | 188 | self.assertCountEqual( |
Yaakov Shaul | 730814a | 2019-09-10 13:58:25 -0600 | [diff] [blame] | 189 | result.modified[idx].files, |
| 190 | [ebuild.path for ebuild in uprev_response.modified_ebuilds]) |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 191 | |
| 192 | |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 193 | class GetBestVisibleTest(cros_test_lib.MockTestCase, ApiConfigMixin): |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 194 | """GetBestVisible tests.""" |
| 195 | |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 196 | def setUp(self): |
| 197 | self.response = packages_pb2.GetBestVisibleResponse() |
| 198 | |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 199 | def _GetRequest(self, atom=None): |
| 200 | return packages_pb2.GetBestVisibleRequest( |
| 201 | atom=atom, |
| 202 | ) |
| 203 | |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 204 | def _MakeCpv(self, category, package, version): |
| 205 | unused = { |
| 206 | 'cp': None, |
| 207 | 'cpv': None, |
| 208 | 'cpf': None, |
| 209 | 'pv': None, |
| 210 | 'version_no_rev': None, |
| 211 | 'rev': None, |
| 212 | } |
Alex Klein | 75df179 | 2020-06-11 14:42:49 -0600 | [diff] [blame] | 213 | return package_info.CPV( |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 214 | category=category, |
| 215 | package=package, |
| 216 | version=version, |
| 217 | **unused |
| 218 | ) |
| 219 | |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 220 | def testValidateOnly(self): |
| 221 | """Sanity check that a validate only call does not execute any logic.""" |
| 222 | patch = self.PatchObject(packages_service, 'get_best_visible') |
| 223 | |
| 224 | request = self._GetRequest(atom='chromeos-chrome') |
| 225 | packages_controller.GetBestVisible(request, self.response, |
| 226 | self.validate_only_config) |
| 227 | patch.assert_not_called() |
| 228 | |
Michael Mortensen | 2677bf6 | 2019-10-29 08:31:25 -0600 | [diff] [blame] | 229 | def testMockCall(self): |
| 230 | """Test that a mock call does not execute logic, returns mocked value.""" |
| 231 | patch = self.PatchObject(packages_service, 'get_best_visible') |
| 232 | request = self._GetRequest(atom='chromeos-chrome') |
| 233 | packages_controller.GetBestVisible(request, self.response, |
| 234 | self.mock_call_config) |
| 235 | patch.assert_not_called() |
| 236 | self.assertTrue(self.response.package_info) |
| 237 | self.assertTrue(self.response.package_info.category) |
| 238 | self.assertTrue(self.response.package_info.package_name) |
| 239 | self.assertTrue(self.response.package_info.version) |
| 240 | |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 241 | def testNoAtomFails(self): |
| 242 | """No atom provided should fail.""" |
| 243 | request = self._GetRequest() |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 244 | with self.assertRaises(cros_build_lib.DieSystemExit): |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 245 | packages_controller.GetBestVisible(request, self.response, |
| 246 | self.api_config) |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 247 | |
| 248 | def testSuccess(self): |
| 249 | """Test overall success, argument handling, result forwarding.""" |
| 250 | cpv = self._MakeCpv('category', 'package', 'version') |
| 251 | self.PatchObject(packages_service, 'get_best_visible', return_value=cpv) |
| 252 | |
| 253 | request = self._GetRequest(atom='chromeos-chrome') |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 254 | |
Alex Klein | 231d2da | 2019-07-22 16:44:45 -0600 | [diff] [blame] | 255 | packages_controller.GetBestVisible(request, self.response, self.api_config) |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 256 | |
Alex Klein | 75df179 | 2020-06-11 14:42:49 -0600 | [diff] [blame] | 257 | package_info_msg = self.response.package_info |
| 258 | self.assertEqual(package_info_msg.category, cpv.category) |
| 259 | self.assertEqual(package_info_msg.package_name, cpv.package) |
| 260 | self.assertEqual(package_info_msg.version, cpv.version) |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 261 | |
| 262 | |
Michael Mortensen | 68abdb7 | 2019-10-28 09:43:52 -0600 | [diff] [blame] | 263 | class GetChromeVersion(cros_test_lib.MockTestCase, ApiConfigMixin): |
| 264 | """GetChromeVersion tests.""" |
| 265 | |
| 266 | def setUp(self): |
| 267 | self.response = packages_pb2.GetChromeVersionResponse() |
| 268 | |
| 269 | def _GetRequest(self, board=None): |
| 270 | """Helper to build out a request.""" |
| 271 | request = packages_pb2.GetChromeVersionRequest() |
| 272 | |
| 273 | if board: |
| 274 | request.build_target.name = board |
| 275 | |
| 276 | return request |
| 277 | |
| 278 | def testValidateOnly(self): |
| 279 | """Sanity check that a validate only call does not execute any logic.""" |
| 280 | chrome_version = self.PatchObject(packages_service, |
| 281 | 'determine_chrome_version') |
| 282 | request = self._GetRequest(board='betty') |
| 283 | packages_controller.GetChromeVersion(request, self.response, |
| 284 | self.validate_only_config) |
| 285 | chrome_version.assert_not_called() |
| 286 | |
| 287 | def testMockCall(self): |
| 288 | """Test that a mock call does not execute logic, returns mocked value.""" |
| 289 | chrome_version = self.PatchObject(packages_service, |
| 290 | 'determine_chrome_version') |
| 291 | request = self._GetRequest(board='betty') |
| 292 | packages_controller.GetChromeVersion(request, self.response, |
| 293 | self.mock_call_config) |
| 294 | chrome_version.assert_not_called() |
| 295 | self.assertTrue(self.response.version) |
| 296 | |
| 297 | def testGetChromeVersion(self): |
| 298 | """Verify basic return values.""" |
| 299 | chrome_version = '76.0.1.2' |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 300 | chrome_version_mock = self.PatchObject(packages_service, |
| 301 | 'determine_chrome_version', |
| 302 | return_value=chrome_version) |
Michael Mortensen | 68abdb7 | 2019-10-28 09:43:52 -0600 | [diff] [blame] | 303 | request = self._GetRequest(board='betty') |
| 304 | packages_controller.GetChromeVersion(request, self.response, |
| 305 | self.api_config) |
| 306 | self.assertEqual(self.response.version, chrome_version) |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 307 | # Verify call to determine_chrome_version passes a build_target object. |
| 308 | build_target = build_target_lib.BuildTarget('betty') |
| 309 | chrome_version_mock.assert_called_with(build_target) |
Michael Mortensen | 68abdb7 | 2019-10-28 09:43:52 -0600 | [diff] [blame] | 310 | |
Michael Mortensen | 9fe740c | 2019-10-29 14:42:48 -0600 | [diff] [blame] | 311 | def testGetChromeVersionHandleNone(self): |
| 312 | """Verify basic return values.""" |
| 313 | self.PatchObject(packages_service, 'determine_chrome_version', |
| 314 | return_value=None) |
| 315 | request = self._GetRequest(board='betty') |
| 316 | packages_controller.GetChromeVersion(request, self.response, |
| 317 | self.api_config) |
| 318 | self.assertFalse(self.response.version) |
| 319 | |
Michael Mortensen | 68abdb7 | 2019-10-28 09:43:52 -0600 | [diff] [blame] | 320 | |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 321 | class GetTargetVersionsTest(cros_test_lib.MockTestCase, ApiConfigMixin): |
| 322 | """GetTargetVersions tests.""" |
| 323 | |
| 324 | def setUp(self): |
| 325 | self.response = packages_pb2.GetTargetVersionsResponse() |
| 326 | |
| 327 | def _GetRequest(self, board=None): |
| 328 | """Helper to build out a request.""" |
| 329 | request = packages_pb2.GetTargetVersionsRequest() |
| 330 | |
| 331 | if board: |
| 332 | request.build_target.name = board |
| 333 | |
| 334 | return request |
| 335 | |
| 336 | def testValidateOnly(self): |
| 337 | """Sanity check that a validate only call does not execute any logic.""" |
Michael Mortensen | 1d2ab0d | 2019-10-17 13:19:25 -0600 | [diff] [blame] | 338 | builds_chrome = self.PatchObject( |
| 339 | packages_service, 'builds', return_value=True) |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 340 | patch_version = self.PatchObject(packages_service, |
| 341 | 'determine_android_version') |
| 342 | patch_branch_version = self.PatchObject(packages_service, |
| 343 | 'determine_android_branch') |
| 344 | patch_target_version = self.PatchObject(packages_service, |
| 345 | 'determine_android_target') |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 346 | chrome_version = self.PatchObject(packages_service, |
| 347 | 'determine_chrome_version') |
Michael Mortensen | 009cb66 | 2019-10-21 11:38:43 -0600 | [diff] [blame] | 348 | platform_version = self.PatchObject(packages_service, |
| 349 | 'determine_platform_version') |
| 350 | milestone_version = self.PatchObject(packages_service, |
| 351 | 'determine_milestone_version') |
| 352 | full_version = self.PatchObject(packages_service, |
| 353 | 'determine_full_version') |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 354 | |
| 355 | request = self._GetRequest(board='betty') |
| 356 | packages_controller.GetTargetVersions(request, self.response, |
| 357 | self.validate_only_config) |
| 358 | patch_version.assert_not_called() |
| 359 | patch_branch_version.assert_not_called() |
| 360 | patch_target_version.assert_not_called() |
Michael Mortensen | 1d2ab0d | 2019-10-17 13:19:25 -0600 | [diff] [blame] | 361 | builds_chrome.assert_not_called() |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 362 | chrome_version.assert_not_called() |
Michael Mortensen | 009cb66 | 2019-10-21 11:38:43 -0600 | [diff] [blame] | 363 | platform_version.assert_not_called() |
| 364 | milestone_version.assert_not_called() |
| 365 | full_version.assert_not_called() |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 366 | |
Michael Mortensen | 2677bf6 | 2019-10-29 08:31:25 -0600 | [diff] [blame] | 367 | def testMockCall(self): |
| 368 | """Test that a mock call does not execute logic, returns mocked value.""" |
| 369 | builds_chrome = self.PatchObject( |
| 370 | packages_service, 'builds', return_value=True) |
| 371 | patch_version = self.PatchObject(packages_service, |
| 372 | 'determine_android_version') |
| 373 | patch_branch_version = self.PatchObject(packages_service, |
| 374 | 'determine_android_branch') |
| 375 | patch_target_version = self.PatchObject(packages_service, |
| 376 | 'determine_android_target') |
| 377 | chrome_version = self.PatchObject(packages_service, |
| 378 | 'determine_chrome_version') |
| 379 | platform_version = self.PatchObject(packages_service, |
| 380 | 'determine_platform_version') |
| 381 | milestone_version = self.PatchObject(packages_service, |
| 382 | 'determine_milestone_version') |
| 383 | full_version = self.PatchObject(packages_service, |
| 384 | 'determine_full_version') |
| 385 | |
| 386 | request = self._GetRequest(board='betty') |
| 387 | packages_controller.GetTargetVersions(request, self.response, |
| 388 | self.mock_call_config) |
| 389 | |
| 390 | patch_version.assert_not_called() |
| 391 | patch_branch_version.assert_not_called() |
| 392 | patch_target_version.assert_not_called() |
| 393 | builds_chrome.assert_not_called() |
| 394 | chrome_version.assert_not_called() |
| 395 | platform_version.assert_not_called() |
| 396 | milestone_version.assert_not_called() |
| 397 | full_version.assert_not_called() |
| 398 | |
| 399 | self.assertTrue(self.response.android_version) |
| 400 | self.assertTrue(self.response.android_branch_version) |
| 401 | self.assertTrue(self.response.android_target_version) |
| 402 | self.assertTrue(self.response.chrome_version) |
| 403 | self.assertTrue(self.response.platform_version) |
| 404 | self.assertTrue(self.response.milestone_version) |
| 405 | self.assertTrue(self.response.full_version) |
| 406 | |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 407 | def testNoBuildTargetFails(self): |
| 408 | """No build target argument should fail.""" |
| 409 | request = self._GetRequest() |
| 410 | |
| 411 | with self.assertRaises(cros_build_lib.DieSystemExit): |
| 412 | packages_controller.GetTargetVersions(request, self.response, |
| 413 | self.api_config) |
| 414 | |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 415 | def testGetTargetVersions(self): |
| 416 | """Verify basic return values.""" |
Michael Mortensen | 1d2ab0d | 2019-10-17 13:19:25 -0600 | [diff] [blame] | 417 | # Mock that chrome is built and set the chrome_version. |
| 418 | self.PatchObject(packages_service, 'builds', return_value=True) |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 419 | chrome_version = '76.0.1.2' |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 420 | chrome_version_mock = self.PatchObject(packages_service, |
| 421 | 'determine_chrome_version', |
| 422 | return_value=chrome_version) |
Mike Frysinger | 8e1c99a | 2021-03-05 00:58:11 -0500 | [diff] [blame] | 423 | android_package = 'chromeos-base/android-container-pi-10.3' |
| 424 | self.PatchObject(packages_service, 'determine_android_package', |
| 425 | return_value=android_package) |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 426 | android_branch = 'android_test_branch' |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 427 | android_branch_mock = self.PatchObject(packages_service, |
| 428 | 'determine_android_branch', |
| 429 | return_value=android_branch) |
Michael Mortensen | 9fdb14b | 2019-10-17 11:17:30 -0600 | [diff] [blame] | 430 | platform_version = '12345.1.2' |
| 431 | self.PatchObject(packages_service, 'determine_platform_version', |
| 432 | return_value=platform_version) |
Michael Mortensen | 009cb66 | 2019-10-21 11:38:43 -0600 | [diff] [blame] | 433 | milestone_version = '79' |
| 434 | self.PatchObject(packages_service, 'determine_milestone_version', |
| 435 | return_value=milestone_version) |
| 436 | full_version = 'R79-12345.1.2' |
| 437 | self.PatchObject(packages_service, 'determine_full_version', |
| 438 | return_value=full_version) |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 439 | request = self._GetRequest(board='betty') |
| 440 | packages_controller.GetTargetVersions(request, self.response, |
| 441 | self.api_config) |
Mike Frysinger | 8e1c99a | 2021-03-05 00:58:11 -0500 | [diff] [blame] | 442 | self.assertEqual(self.response.android_version, '10.3') |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 443 | self.assertEqual(self.response.android_branch_version, android_branch) |
Mike Frysinger | 8e1c99a | 2021-03-05 00:58:11 -0500 | [diff] [blame] | 444 | self.assertEqual(self.response.android_target_version, 'cheets') |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 445 | self.assertEqual(self.response.chrome_version, chrome_version) |
Michael Mortensen | 9fdb14b | 2019-10-17 11:17:30 -0600 | [diff] [blame] | 446 | self.assertEqual(self.response.platform_version, platform_version) |
Michael Mortensen | 009cb66 | 2019-10-21 11:38:43 -0600 | [diff] [blame] | 447 | self.assertEqual(self.response.milestone_version, milestone_version) |
| 448 | self.assertEqual(self.response.full_version, full_version) |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 449 | # Verify call to determine_chrome_version passes a build_target object. |
| 450 | build_target = build_target_lib.BuildTarget('betty') |
| 451 | chrome_version_mock.assert_called_with(build_target) |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 452 | # Verify call to determine_android_branch passes a board name. |
Mike Frysinger | 8e1c99a | 2021-03-05 00:58:11 -0500 | [diff] [blame] | 453 | android_branch_mock.assert_called_with('betty', package=android_package) |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 454 | |
Michael Mortensen | 42c330e3 | 2020-09-02 09:59:16 -0600 | [diff] [blame] | 455 | def testGetTargetVersionsWithPackagesSet(self): |
| 456 | """Verify packages pass through and basic return values.""" |
| 457 | # TODO(crbug.com/1124393): Migrate this test to use portage_testables |
| 458 | # rather than mocking the boundary to portage calls such as |
| 459 | # packages_service.builds). |
| 460 | builds_mock = self.PatchObject(packages_service, 'builds', |
| 461 | return_value=True) |
| 462 | # Mock that chrome is built and set the chrome_version. |
| 463 | chrome_version = '76.0.1.2' |
| 464 | self.PatchObject(packages_service, 'determine_chrome_version', |
| 465 | return_value=chrome_version) |
Mike Frysinger | 8e1c99a | 2021-03-05 00:58:11 -0500 | [diff] [blame] | 466 | android_package = 'chromeos-base/android-container-pi-10.3' |
| 467 | self.PatchObject(packages_service, 'determine_android_package', |
| 468 | return_value=android_package) |
Michael Mortensen | 42c330e3 | 2020-09-02 09:59:16 -0600 | [diff] [blame] | 469 | android_branch = 'android_test_branch' |
| 470 | self.PatchObject(packages_service, 'determine_android_branch', |
| 471 | return_value=android_branch) |
Michael Mortensen | 42c330e3 | 2020-09-02 09:59:16 -0600 | [diff] [blame] | 472 | platform_version = '12345.1.2' |
| 473 | self.PatchObject(packages_service, 'determine_platform_version', |
| 474 | return_value=platform_version) |
| 475 | milestone_version = '79' |
| 476 | self.PatchObject(packages_service, 'determine_milestone_version', |
| 477 | return_value=milestone_version) |
| 478 | full_version = 'R79-12345.1.2' |
| 479 | self.PatchObject(packages_service, 'determine_full_version', |
| 480 | return_value=full_version) |
| 481 | request = self._GetRequest(board='betty') |
| 482 | # Add optional packages to the request. |
| 483 | cpv_package_list = [] |
| 484 | package = request.packages.add() |
| 485 | package.package_name = 'test' |
| 486 | package.category = 'chromeos-base' |
| 487 | package.version = '0.0.1-r1' |
| 488 | cpv_package_list.append(controller_util.PackageInfoToCPV(package)) |
| 489 | package = request.packages.add() |
| 490 | package.package_name = 'target-fuzzers' |
| 491 | package.category = 'virtual' |
| 492 | cpv_package_list.append(controller_util.PackageInfoToCPV(package)) |
| 493 | |
| 494 | packages_controller.GetTargetVersions(request, self.response, |
| 495 | self.api_config) |
Mike Frysinger | 8e1c99a | 2021-03-05 00:58:11 -0500 | [diff] [blame] | 496 | self.assertEqual(self.response.android_version, '10.3') |
Michael Mortensen | 42c330e3 | 2020-09-02 09:59:16 -0600 | [diff] [blame] | 497 | self.assertEqual(self.response.android_branch_version, android_branch) |
Mike Frysinger | 8e1c99a | 2021-03-05 00:58:11 -0500 | [diff] [blame] | 498 | self.assertEqual(self.response.android_target_version, 'cheets') |
Michael Mortensen | 42c330e3 | 2020-09-02 09:59:16 -0600 | [diff] [blame] | 499 | self.assertEqual(self.response.chrome_version, chrome_version) |
| 500 | self.assertEqual(self.response.platform_version, platform_version) |
| 501 | self.assertEqual(self.response.milestone_version, milestone_version) |
| 502 | # Verify call to packages.builds passes the package list. |
| 503 | builds_mock.assert_called_with(constants.CHROME_CP, |
| 504 | mock.ANY, # Match the build target object |
| 505 | packages=cpv_package_list) |
| 506 | |
Michael Mortensen | 1d2ab0d | 2019-10-17 13:19:25 -0600 | [diff] [blame] | 507 | def testGetTargetVersionNoAndroidNoChrome(self): |
Michael Mortensen | edf7653 | 2019-10-16 14:22:37 -0600 | [diff] [blame] | 508 | """Verify return values on a board that does not have android.""" |
Michael Mortensen | 9fdb14b | 2019-10-17 11:17:30 -0600 | [diff] [blame] | 509 | platform_version = '12345.1.2' |
| 510 | self.PatchObject(packages_service, 'determine_platform_version', |
| 511 | return_value=platform_version) |
Michael Mortensen | 1d2ab0d | 2019-10-17 13:19:25 -0600 | [diff] [blame] | 512 | self.PatchObject(packages_service, 'builds', return_value=False) |
Mike Frysinger | 8e1c99a | 2021-03-05 00:58:11 -0500 | [diff] [blame] | 513 | self.PatchObject(packages_service, 'determine_android_package', |
Michael Mortensen | edf7653 | 2019-10-16 14:22:37 -0600 | [diff] [blame] | 514 | return_value=None) |
| 515 | request = self._GetRequest(board='betty') |
| 516 | packages_controller.GetTargetVersions(request, self.response, |
| 517 | self.api_config) |
Michael Mortensen | 1d2ab0d | 2019-10-17 13:19:25 -0600 | [diff] [blame] | 518 | self.assertFalse(self.response.chrome_version) |
Michael Mortensen | edf7653 | 2019-10-16 14:22:37 -0600 | [diff] [blame] | 519 | self.assertFalse(self.response.android_version) |
| 520 | self.assertFalse(self.response.android_branch_version) |
| 521 | self.assertFalse(self.response.android_target_version) |
Michael Mortensen | 9fdb14b | 2019-10-17 11:17:30 -0600 | [diff] [blame] | 522 | self.assertEqual(self.response.platform_version, platform_version) |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 523 | |
Michael Mortensen | bfc5639 | 2020-04-30 15:23:47 -0600 | [diff] [blame] | 524 | |
| 525 | class GetBuilderMetadataTest(cros_test_lib.MockTestCase, ApiConfigMixin): |
| 526 | """GetBuilderMetadata tests.""" |
| 527 | |
| 528 | def setUp(self): |
| 529 | self.response = packages_pb2.GetBuilderMetadataResponse() |
| 530 | |
| 531 | def _GetRequest(self, board=None): |
| 532 | """Helper to build out a request.""" |
| 533 | request = packages_pb2.GetBuilderMetadataRequest() |
| 534 | |
| 535 | if board: |
| 536 | request.build_target.name = board |
| 537 | |
| 538 | return request |
| 539 | |
| 540 | def testValidateOnly(self): |
| 541 | """Sanity check that a validate only call does not execute any logic.""" |
| 542 | request = self._GetRequest(board='betty') |
Michael Mortensen | 76e1512 | 2020-06-03 11:07:28 -0600 | [diff] [blame] | 543 | patch_version = self.PatchObject(packages_service, |
| 544 | 'determine_android_version') |
| 545 | patch_branch_version = self.PatchObject(packages_service, |
| 546 | 'determine_android_branch') |
| 547 | patch_fw_versions = self.PatchObject(packages_service, |
| 548 | 'determine_firmware_versions') |
| 549 | patch_fingerprints = self.PatchObject(packages_service, |
| 550 | 'find_fingerprints') |
| 551 | patch_get_models = self.PatchObject(packages_service, |
| 552 | 'get_models') |
Michael Mortensen | bfc5639 | 2020-04-30 15:23:47 -0600 | [diff] [blame] | 553 | packages_controller.GetBuilderMetadata(request, self.response, |
| 554 | self.validate_only_config) |
Michael Mortensen | 76e1512 | 2020-06-03 11:07:28 -0600 | [diff] [blame] | 555 | patch_version.assert_not_called() |
| 556 | patch_branch_version.assert_not_called() |
| 557 | patch_fw_versions.assert_not_called() |
| 558 | patch_fingerprints.assert_not_called() |
| 559 | patch_get_models.assert_not_called() |
Michael Mortensen | bfc5639 | 2020-04-30 15:23:47 -0600 | [diff] [blame] | 560 | |
| 561 | def testMockCall(self): |
| 562 | """Test that a mock call does not execute logic, returns mocked value.""" |
| 563 | request = self._GetRequest(board='betty') |
Michael Mortensen | 76e1512 | 2020-06-03 11:07:28 -0600 | [diff] [blame] | 564 | patch_version = self.PatchObject(packages_service, |
| 565 | 'determine_android_version') |
| 566 | patch_branch_version = self.PatchObject(packages_service, |
| 567 | 'determine_android_branch') |
| 568 | patch_fw_versions = self.PatchObject(packages_service, |
| 569 | 'determine_firmware_versions') |
| 570 | patch_fingerprints = self.PatchObject(packages_service, |
| 571 | 'find_fingerprints') |
| 572 | patch_get_models = self.PatchObject(packages_service, |
| 573 | 'get_models') |
Michael Mortensen | bfc5639 | 2020-04-30 15:23:47 -0600 | [diff] [blame] | 574 | packages_controller.GetBuilderMetadata(request, self.response, |
| 575 | self.mock_call_config) |
Michael Mortensen | 76e1512 | 2020-06-03 11:07:28 -0600 | [diff] [blame] | 576 | patch_version.assert_not_called() |
| 577 | patch_branch_version.assert_not_called() |
| 578 | patch_fw_versions.assert_not_called() |
| 579 | patch_fingerprints.assert_not_called() |
| 580 | patch_get_models.assert_not_called() |
Michael Mortensen | bfc5639 | 2020-04-30 15:23:47 -0600 | [diff] [blame] | 581 | |
| 582 | self.assertEqual(len(self.response.build_target_metadata), 1) |
| 583 | self.assertEqual(self.response.build_target_metadata[0].build_target, |
| 584 | request.build_target.name) |
| 585 | self.assertEqual(len(self.response.model_metadata), 1) |
| 586 | self.assertTrue(self.response.model_metadata[0].model_name) |
| 587 | self.assertTrue(self.response.model_metadata[0].ec_firmware_version) |
| 588 | |
| 589 | def testNoBuildTargetFails(self): |
| 590 | """No build target argument should fail.""" |
| 591 | request = self._GetRequest() |
| 592 | |
| 593 | with self.assertRaises(cros_build_lib.DieSystemExit): |
| 594 | packages_controller.GetBuilderMetadata(request, self.response, |
| 595 | self.api_config) |
| 596 | |
Michael Mortensen | bbce7e4 | 2020-05-01 15:03:49 -0600 | [diff] [blame] | 597 | def testGetBuilderMetadata(self): |
| 598 | """Verify basic return values.""" |
| 599 | android_version = 'android_test_version' |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 600 | android_version_mock = self.PatchObject(packages_service, |
| 601 | 'determine_android_version', |
| 602 | return_value=android_version) |
Michael Mortensen | bbce7e4 | 2020-05-01 15:03:49 -0600 | [diff] [blame] | 603 | android_branch = 'android_test_branch' |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 604 | android_branch_mock = self.PatchObject(packages_service, |
| 605 | 'determine_android_branch', |
| 606 | return_value=android_branch) |
Michael Mortensen | bbce7e4 | 2020-05-01 15:03:49 -0600 | [diff] [blame] | 607 | android_target = 'android_test_target' |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 608 | android_target_mock = self.PatchObject(packages_service, |
| 609 | 'determine_android_target', |
| 610 | return_value=android_target) |
Michael Mortensen | bbce7e4 | 2020-05-01 15:03:49 -0600 | [diff] [blame] | 611 | self.PatchObject(portage_util, 'GetBoardUseFlags', |
| 612 | return_value=['arc', 'arcvm', 'big_little', 'cheets']) |
Michael Mortensen | fbf2b2d | 2020-05-14 16:33:06 -0600 | [diff] [blame] | 613 | package_result = ['sys-kernel/linux-headers-4.14-r24', |
| 614 | 'sys-devel/flex-2.6.4-r1', |
| 615 | 'sys-kernel/chromeos-kernel-4_4-4.4.223-r2209'] |
| 616 | self.PatchObject(portage_util, 'GetPackageDependencies', |
| 617 | return_value=package_result) |
| 618 | |
Michael Mortensen | a4af79e | 2020-05-06 16:18:48 -0600 | [diff] [blame] | 619 | fw_versions = packages_service.FirmwareVersions( |
| 620 | None, |
| 621 | 'Google_Caroline.7820.263.0', |
| 622 | 'Google_Caroline.7820.286.0', |
| 623 | 'caroline_v1.9.357-ac5c7b4', |
| 624 | 'caroline_v1.9.370-e8b9bd2') |
| 625 | self.PatchObject(packages_service, 'get_firmware_versions', |
| 626 | return_value=fw_versions) |
Michael Mortensen | de716a1 | 2020-05-15 11:27:00 -0600 | [diff] [blame] | 627 | fingerprints = ['fingerprint1', 'fingerprint2'] |
| 628 | self.PatchObject(packages_service, 'find_fingerprints', |
| 629 | return_value=fingerprints) |
Michael Mortensen | 770bc12 | 2020-05-27 17:53:30 -0600 | [diff] [blame] | 630 | # Patch packages.get_models, packages.get_all_firmware_versions, |
| 631 | # and packages.get_key_id for calls needed by model_metadata. |
| 632 | model_list = ['pyro', 'reef'] |
| 633 | all_fw_versions = { |
| 634 | 'pyro': packages_service.FirmwareVersions( |
| 635 | 'pyro', |
| 636 | 'Google_Pyro.9042.87.1', |
| 637 | 'Google_Pyro.9042.110.0', |
| 638 | 'pyro_v1.1.5900-ab1ee51', |
| 639 | 'pyro_v1.1.5909-bd1f0c9'), |
| 640 | 'reef': packages_service.FirmwareVersions( |
| 641 | 'reef', |
| 642 | 'Google_Reef.9042.87.1', |
| 643 | 'Google_Reef.9042.110.0', |
| 644 | 'reef_v1.1.5900-ab1ee51', |
| 645 | 'reef_v1.1.5909-bd1f0c9') |
| 646 | } |
| 647 | self.PatchObject(packages_service, 'get_all_firmware_versions', |
| 648 | return_value=all_fw_versions) |
| 649 | self.PatchObject(packages_service, 'get_models', |
| 650 | return_value=model_list) |
| 651 | self.PatchObject(packages_service, 'get_key_id', |
| 652 | return_value='key') |
| 653 | |
Michael Mortensen | bbce7e4 | 2020-05-01 15:03:49 -0600 | [diff] [blame] | 654 | request = self._GetRequest(board='betty') |
| 655 | packages_controller.GetBuilderMetadata(request, self.response, |
| 656 | self.api_config) |
| 657 | self.assertEqual( |
| 658 | self.response.build_target_metadata[0].build_target, |
| 659 | 'betty') |
| 660 | self.assertEqual( |
| 661 | self.response.build_target_metadata[0].android_container_version, |
| 662 | android_version) |
| 663 | self.assertEqual( |
| 664 | self.response.build_target_metadata[0].android_container_branch, |
| 665 | android_branch) |
| 666 | self.assertEqual( |
| 667 | self.response.build_target_metadata[0].android_container_target, |
| 668 | android_target) |
| 669 | self.assertEqual( |
| 670 | self.response.build_target_metadata[0].arc_use_set, |
| 671 | True) |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 672 | # Verify call to determine_android_version passes list of the board name. |
Mike Frysinger | b53f182 | 2021-03-05 00:44:50 -0500 | [diff] [blame] | 673 | android_version_mock.assert_called_with('betty') |
Michael Mortensen | 027ecd8 | 2020-05-05 13:13:40 -0600 | [diff] [blame] | 674 | # Verify call to determine_android_branch passes board name. |
| 675 | android_branch_mock.assert_called_with('betty') |
| 676 | # Verify call to determine_android_target passes board name. |
| 677 | android_target_mock.assert_called_with('betty') |
Michael Mortensen | a4af79e | 2020-05-06 16:18:48 -0600 | [diff] [blame] | 678 | self.assertEqual( |
| 679 | self.response.build_target_metadata[0].main_firmware_version, |
| 680 | 'Google_Caroline.7820.286.0') |
| 681 | self.assertEqual( |
| 682 | self.response.build_target_metadata[0].ec_firmware_version, |
| 683 | 'caroline_v1.9.370-e8b9bd2') |
Michael Mortensen | fbf2b2d | 2020-05-14 16:33:06 -0600 | [diff] [blame] | 684 | self.assertEqual( |
| 685 | self.response.build_target_metadata[0].kernel_version, |
| 686 | '4.4.223-r2209') |
Michael Mortensen | de716a1 | 2020-05-15 11:27:00 -0600 | [diff] [blame] | 687 | self.assertEqual( |
| 688 | len(self.response.build_target_metadata[0].fingerprints), |
| 689 | 2) |
| 690 | self.assertEqual( |
| 691 | self.response.build_target_metadata[0].fingerprints, |
| 692 | fingerprints) |
Michael Mortensen | 770bc12 | 2020-05-27 17:53:30 -0600 | [diff] [blame] | 693 | self.assertEqual( |
| 694 | len(self.response.model_metadata), 2) |
| 695 | self.assertEqual( |
| 696 | self.response.model_metadata[0].model_name, 'pyro') |
| 697 | self.assertEqual( |
| 698 | self.response.model_metadata[0].ec_firmware_version, |
| 699 | 'pyro_v1.1.5909-bd1f0c9') |
| 700 | self.assertEqual( |
| 701 | self.response.model_metadata[0].firmware_key_id, 'key') |
| 702 | self.assertEqual( |
| 703 | self.response.model_metadata[0].main_readonly_firmware_version, |
| 704 | 'Google_Pyro.9042.87.1') |
| 705 | self.assertEqual( |
| 706 | self.response.model_metadata[0].main_readwrite_firmware_version, |
| 707 | 'Google_Pyro.9042.110.0') |
| 708 | self.assertEqual( |
| 709 | self.response.model_metadata[1].model_name, 'reef') |
| 710 | self.assertEqual( |
| 711 | self.response.model_metadata[1].ec_firmware_version, |
| 712 | 'reef_v1.1.5909-bd1f0c9') |
| 713 | self.assertEqual( |
| 714 | self.response.model_metadata[1].firmware_key_id, 'key') |
| 715 | self.assertEqual( |
| 716 | self.response.model_metadata[1].main_readonly_firmware_version, |
| 717 | 'Google_Reef.9042.87.1') |
| 718 | self.assertEqual( |
| 719 | self.response.model_metadata[1].main_readwrite_firmware_version, |
| 720 | 'Google_Reef.9042.110.0') |
Michael Mortensen | bbce7e4 | 2020-05-01 15:03:49 -0600 | [diff] [blame] | 721 | |
Michael Mortensen | d81d81e | 2020-06-09 14:20:59 -0600 | [diff] [blame] | 722 | # Test corner case where find_fingerprints returns None. |
| 723 | # Re-patch find_fingerprints to now return None and re-execute |
| 724 | # GetBuilderMetadata to verify behavior. |
| 725 | response = packages_pb2.GetBuilderMetadataResponse() |
| 726 | self.PatchObject(packages_service, 'find_fingerprints', |
| 727 | return_value=[]) |
| 728 | request = self._GetRequest(board='betty') |
| 729 | packages_controller.GetBuilderMetadata(request, response, |
| 730 | self.api_config) |
| 731 | # Verify a non-fingerprint build_target_metdata field was still set. |
| 732 | self.assertEqual( |
| 733 | response.build_target_metadata[0].kernel_version, |
| 734 | '4.4.223-r2209') |
| 735 | # And then verify that fingerprints was empty. |
| 736 | self.assertEqual(response.build_target_metadata[0].fingerprints, []) |
| 737 | |
Michael Mortensen | bbce7e4 | 2020-05-01 15:03:49 -0600 | [diff] [blame] | 738 | |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 739 | class HasChromePrebuiltTest(cros_test_lib.MockTestCase, ApiConfigMixin): |
| 740 | """HasChromePrebuilt tests.""" |
| 741 | |
| 742 | def setUp(self): |
| 743 | self.response = packages_pb2.HasChromePrebuiltResponse() |
| 744 | |
| 745 | def _GetRequest(self, board=None): |
| 746 | """Helper to build out a request.""" |
| 747 | request = packages_pb2.HasChromePrebuiltRequest() |
| 748 | |
| 749 | if board: |
| 750 | request.build_target.name = board |
| 751 | |
| 752 | return request |
| 753 | |
| 754 | def testValidateOnly(self): |
| 755 | """Sanity check that a validate only call does not execute any logic.""" |
| 756 | patch = self.PatchObject(packages_service, 'has_prebuilt') |
| 757 | |
| 758 | request = self._GetRequest(board='betty') |
| 759 | packages_controller.HasChromePrebuilt(request, self.response, |
| 760 | self.validate_only_config) |
| 761 | patch.assert_not_called() |
| 762 | |
Michael Mortensen | 3232ab3 | 2020-01-05 19:14:36 -0700 | [diff] [blame] | 763 | def testMockCall(self): |
| 764 | """Test that a mock call does not execute logic, returns mocked value.""" |
| 765 | patch = self.PatchObject(packages_service, 'has_prebuilt') |
| 766 | |
| 767 | request = self._GetRequest(board='betty') |
| 768 | packages_controller.HasChromePrebuilt(request, self.response, |
| 769 | self.mock_call_config) |
| 770 | patch.assert_not_called() |
| 771 | self.assertTrue(self.response.has_prebuilt) |
| 772 | |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 773 | def testNoBuildTargetFails(self): |
| 774 | """No build target argument should fail.""" |
| 775 | request = self._GetRequest() |
| 776 | |
| 777 | with self.assertRaises(cros_build_lib.DieSystemExit): |
| 778 | packages_controller.HasChromePrebuilt(request, self.response, |
| 779 | self.api_config) |
Alex Klein | 73fb657 | 2019-09-30 16:55:23 -0600 | [diff] [blame] | 780 | |
| 781 | |
| 782 | class BuildsChromeTest(cros_test_lib.MockTestCase, ApiConfigMixin): |
| 783 | """BuildsChrome tests.""" |
| 784 | |
| 785 | def setUp(self): |
| 786 | self.response = packages_pb2.BuildsChromeResponse() |
| 787 | |
David Burger | 0f9dd4e | 2019-10-08 12:33:42 -0600 | [diff] [blame] | 788 | def _GetRequest(self, board=None, packages=None): |
Alex Klein | 73fb657 | 2019-09-30 16:55:23 -0600 | [diff] [blame] | 789 | """Helper to build out a request.""" |
| 790 | request = packages_pb2.BuildsChromeRequest() |
| 791 | |
| 792 | if board: |
| 793 | request.build_target.name = board |
| 794 | |
David Burger | 0f9dd4e | 2019-10-08 12:33:42 -0600 | [diff] [blame] | 795 | if packages: |
| 796 | request.packages.extend(packages) |
| 797 | |
Alex Klein | 73fb657 | 2019-09-30 16:55:23 -0600 | [diff] [blame] | 798 | return request |
| 799 | |
| 800 | def testValidateOnly(self): |
| 801 | """Sanity check that a validate only call does not execute any logic.""" |
Alex Klein | e65131f | 2019-10-03 10:34:01 -0600 | [diff] [blame] | 802 | patch = self.PatchObject(packages_service, 'builds') |
Alex Klein | 73fb657 | 2019-09-30 16:55:23 -0600 | [diff] [blame] | 803 | |
| 804 | request = self._GetRequest(board='betty') |
| 805 | packages_controller.BuildsChrome(request, self.response, |
| 806 | self.validate_only_config) |
| 807 | patch.assert_not_called() |
| 808 | |
| 809 | def testNoBuildTargetFails(self): |
| 810 | """No build target argument should fail.""" |
| 811 | request = self._GetRequest() |
| 812 | |
| 813 | with self.assertRaises(cros_build_lib.DieSystemExit): |
| 814 | packages_controller.BuildsChrome(request, self.response, self.api_config) |
Alex Klein | e65131f | 2019-10-03 10:34:01 -0600 | [diff] [blame] | 815 | |
| 816 | def testBuilds(self): |
| 817 | """Test successful call handling.""" |
| 818 | patch = self.PatchObject(packages_service, 'builds', return_value=True) |
| 819 | |
| 820 | request = self._GetRequest(board='foo') |
| 821 | packages_controller.BuildsChrome(request, self.response, self.api_config) |
| 822 | self.assertTrue(self.response.builds_chrome) |
Alex Klein | 26e472b | 2020-03-10 14:35:01 -0600 | [diff] [blame] | 823 | patch.assert_called_once_with(constants.CHROME_CP, |
| 824 | build_target_lib.BuildTarget('foo'), []) |
David Burger | 0f9dd4e | 2019-10-08 12:33:42 -0600 | [diff] [blame] | 825 | |
| 826 | def testBuildsChromeWithPackages(self): |
| 827 | """Test successful call with packages handling.""" |
| 828 | patch = self.PatchObject(packages_service, 'builds', return_value=True) |
| 829 | |
| 830 | package = common_pb2.PackageInfo( |
| 831 | category='category', |
| 832 | package_name='name', |
| 833 | version='1.01', |
| 834 | ) |
| 835 | request = self._GetRequest(board='foo', packages=[package]) |
| 836 | packages_controller.BuildsChrome(request, self.response, self.api_config) |
| 837 | self.assertTrue(self.response.builds_chrome) |
Alex Klein | 26e472b | 2020-03-10 14:35:01 -0600 | [diff] [blame] | 838 | patch.assert_called_once_with(constants.CHROME_CP, |
| 839 | build_target_lib.BuildTarget('foo'), |
David Burger | 0f9dd4e | 2019-10-08 12:33:42 -0600 | [diff] [blame] | 840 | [controller_util.PackageInfoToCPV(package)]) |
Shao-Chuan Lee | eb834a3 | 2021-05-12 17:10:55 +0900 | [diff] [blame] | 841 | |
| 842 | |
| 843 | class GetAndroidMetadataTest(cros_test_lib.MockTestCase, ApiConfigMixin): |
| 844 | """GetAndroidMetadata tests.""" |
| 845 | |
| 846 | def setUp(self): |
| 847 | self.response = packages_pb2.GetAndroidMetadataResponse() |
| 848 | |
| 849 | def _GetRequest(self, board=None): |
| 850 | """Helper to build out a request.""" |
| 851 | request = packages_pb2.GetAndroidMetadataRequest() |
| 852 | |
| 853 | if board: |
| 854 | request.build_target.name = board |
| 855 | |
| 856 | return request |
| 857 | |
| 858 | def testValidateOnly(self): |
| 859 | """Check that a validate only call does not execute any logic.""" |
| 860 | package_mock = self.PatchObject(packages_service, |
| 861 | 'determine_android_package') |
| 862 | branch_mock = self.PatchObject(packages_service, |
| 863 | 'determine_android_branch') |
| 864 | version_mock = self.PatchObject(packages_service, |
| 865 | 'determine_android_version') |
| 866 | |
| 867 | request = self._GetRequest(board='betty') |
| 868 | packages_controller.GetAndroidMetadata(request, self.response, |
| 869 | self.validate_only_config) |
| 870 | |
| 871 | package_mock.assert_not_called() |
| 872 | branch_mock.assert_not_called() |
| 873 | version_mock.assert_not_called() |
| 874 | |
| 875 | def testMockCall(self): |
| 876 | """Test that a mock call does not execute logic, returns mocked value.""" |
| 877 | package_mock = self.PatchObject(packages_service, |
| 878 | 'determine_android_package') |
| 879 | branch_mock = self.PatchObject(packages_service, |
| 880 | 'determine_android_branch') |
| 881 | version_mock = self.PatchObject(packages_service, |
| 882 | 'determine_android_version') |
| 883 | |
| 884 | request = self._GetRequest(board='betty') |
| 885 | packages_controller.GetAndroidMetadata(request, self.response, |
| 886 | self.mock_call_config) |
| 887 | |
| 888 | package_mock.assert_not_called() |
| 889 | branch_mock.assert_not_called() |
| 890 | version_mock.assert_not_called() |
| 891 | |
| 892 | self.assertTrue(self.response.android_package) |
| 893 | self.assertTrue(self.response.android_branch) |
| 894 | self.assertTrue(self.response.android_version) |
| 895 | |
| 896 | def testNoBuildTargetFails(self): |
| 897 | """No build target argument should fail.""" |
| 898 | request = self._GetRequest() |
| 899 | with self.assertRaises(cros_build_lib.DieSystemExit): |
| 900 | packages_controller.GetAndroidMetadata(request, self.response, |
| 901 | self.api_config) |
| 902 | |
| 903 | def testSuccess(self): |
| 904 | """Test a successful call.""" |
| 905 | board = 'betty' |
| 906 | package = 'android-package' |
| 907 | branch = 'android-branch' |
| 908 | version = '7123456' |
| 909 | full_package = f'chromeos-base/{package}-{version}-r1' |
| 910 | |
| 911 | package_mock = self.PatchObject(packages_service, |
| 912 | 'determine_android_package', |
| 913 | return_value=full_package) |
| 914 | branch_mock = self.PatchObject(packages_service, |
| 915 | 'determine_android_branch', |
| 916 | return_value=branch) |
| 917 | version_mock = self.PatchObject(packages_service, |
| 918 | 'determine_android_version', |
| 919 | return_value=version) |
| 920 | |
| 921 | request = self._GetRequest(board=board) |
| 922 | packages_controller.GetAndroidMetadata(request, self.response, |
| 923 | self.api_config) |
| 924 | |
| 925 | package_mock.assert_called_once_with(board) |
| 926 | branch_mock.assert_called_once_with(board, package=full_package) |
| 927 | version_mock.assert_called_once_with(board, package=full_package) |
| 928 | |
| 929 | self.assertEqual(self.response.android_package, package) |
| 930 | self.assertEqual(self.response.android_branch, branch) |
| 931 | self.assertEqual(self.response.android_version, version) |
| 932 | |
| 933 | def testNoAndroid(self): |
| 934 | """Test returns an empty response if given board has no Android.""" |
| 935 | board = 'betty' |
| 936 | |
| 937 | package_mock = self.PatchObject(packages_service, |
| 938 | 'determine_android_package', |
| 939 | return_value=None) |
| 940 | branch_mock = self.PatchObject(packages_service, |
| 941 | 'determine_android_branch') |
| 942 | version_mock = self.PatchObject(packages_service, |
| 943 | 'determine_android_version') |
| 944 | |
| 945 | request = self._GetRequest(board=board) |
| 946 | packages_controller.GetAndroidMetadata(request, self.response, |
| 947 | self.api_config) |
| 948 | |
| 949 | package_mock.assert_called_once_with(board) |
| 950 | branch_mock.assert_not_called() |
| 951 | version_mock.assert_not_called() |
| 952 | |
| 953 | self.assertFalse(self.response.android_package) |
| 954 | self.assertFalse(self.response.android_branch) |
| 955 | self.assertFalse(self.response.android_version) |