blob: 08bf5ac1a711c10915261296193e22182f601e01 [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
stip@chromium.orgf7d31f52014-01-03 20:14:46 +00009__version__ = '1.8.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000010
11# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
12# caching (between all different invocations of presubmit scripts for a given
13# change). We should add it as our presubmit scripts start feeling slow.
14
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090015import ast # Exposed through the API.
enne@chromium.orge72c5f52013-04-16 00:36:40 +000016import cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000017import cPickle # Exposed through the API.
18import cStringIO # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
dcheng091b7db2016-06-16 01:27:51 -070020import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000021import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000022import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000023import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000024import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000025import logging
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000026import marshal # Exposed through the API.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import optparse
29import os # Somewhat exposed through the API.
30import pickle # Exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000031import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import re # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000033import sys # Parts exposed through API.
34import tempfile # Exposed through the API.
jam@chromium.org2a891dc2009-08-20 20:33:37 +000035import time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +000036import traceback # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000037import types
maruel@chromium.org1487d532009-06-06 00:22:57 +000038import unittest # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000039import urllib2 # Exposed through the API.
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000040import urlparse
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000041from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000042
43# Local imports.
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000044import auth
maruel@chromium.org35625c72011-03-23 17:34:02 +000045import fix_encoding
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000046import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070047import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000048import gerrit_util
dpranke@chromium.org2a009622011-03-01 02:43:31 +000049import owners
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020050import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000051import presubmit_canned_checks
maruel@chromium.org239f4112011-06-03 20:08:23 +000052import rietveld
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000053import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000054import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000055
56
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000057# Ask for feedback only once in program lifetime.
58_ASKED_FOR_FEEDBACK = False
59
60
maruel@chromium.org899e1c12011-04-07 17:03:18 +000061class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000062 pass
63
64
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000065class CommandData(object):
66 def __init__(self, name, cmd, kwargs, message):
67 self.name = name
68 self.cmd = cmd
69 self.kwargs = kwargs
70 self.message = message
71 self.info = None
72
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000073
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000074def normpath(path):
75 '''Version of os.path.normpath that also changes backward slashes to
76 forward slashes when not running on Windows.
77 '''
78 # This is safe to always do because the Windows version of os.path.normpath
79 # will replace forward slashes with backward slashes.
80 path = path.replace(os.sep, '/')
81 return os.path.normpath(path)
82
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000083
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000084def _RightHandSideLinesImpl(affected_files):
85 """Implements RightHandSideLines for InputApi and GclChange."""
86 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +000087 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000088 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +000089 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000090
91
dpranke@chromium.org5ac21012011-03-16 02:58:25 +000092class PresubmitOutput(object):
93 def __init__(self, input_stream=None, output_stream=None):
94 self.input_stream = input_stream
95 self.output_stream = output_stream
96 self.reviewers = []
97 self.written_output = []
98 self.error_count = 0
99
100 def prompt_yes_no(self, prompt_string):
101 self.write(prompt_string)
102 if self.input_stream:
103 response = self.input_stream.readline().strip().lower()
104 if response not in ('y', 'yes'):
105 self.fail()
106 else:
107 self.fail()
108
109 def fail(self):
110 self.error_count += 1
111
112 def should_continue(self):
113 return not self.error_count
114
115 def write(self, s):
116 self.written_output.append(s)
117 if self.output_stream:
118 self.output_stream.write(s)
119
120 def getvalue(self):
121 return ''.join(self.written_output)
122
123
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000124# Top level object so multiprocessing can pickle
125# Public access through OutputApi object.
126class _PresubmitResult(object):
127 """Base class for result objects."""
128 fatal = False
129 should_prompt = False
130
131 def __init__(self, message, items=None, long_text=''):
132 """
133 message: A short one-line message to indicate errors.
134 items: A list of short strings to indicate where errors occurred.
135 long_text: multi-line text output, e.g. from another tool
136 """
137 self._message = message
138 self._items = items or []
139 if items:
140 self._items = items
141 self._long_text = long_text.rstrip()
142
143 def handle(self, output):
144 output.write(self._message)
145 output.write('\n')
146 for index, item in enumerate(self._items):
147 output.write(' ')
148 # Write separately in case it's unicode.
149 output.write(str(item))
150 if index < len(self._items) - 1:
151 output.write(' \\')
152 output.write('\n')
153 if self._long_text:
154 output.write('\n***************\n')
155 # Write separately in case it's unicode.
156 output.write(self._long_text)
157 output.write('\n***************\n')
158 if self.fatal:
159 output.fail()
160
161
162# Top level object so multiprocessing can pickle
163# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000164class _PresubmitError(_PresubmitResult):
165 """A hard presubmit error."""
166 fatal = True
167
168
169# Top level object so multiprocessing can pickle
170# Public access through OutputApi object.
171class _PresubmitPromptWarning(_PresubmitResult):
172 """An warning that prompts the user if they want to continue."""
173 should_prompt = True
174
175
176# Top level object so multiprocessing can pickle
177# Public access through OutputApi object.
178class _PresubmitNotifyResult(_PresubmitResult):
179 """Just print something to the screen -- but it's not even a warning."""
180 pass
181
182
183# Top level object so multiprocessing can pickle
184# Public access through OutputApi object.
185class _MailTextResult(_PresubmitResult):
186 """A warning that should be included in the review request email."""
187 def __init__(self, *args, **kwargs):
188 super(_MailTextResult, self).__init__()
189 raise NotImplementedError()
190
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000191class GerritAccessor(object):
192 """Limited Gerrit functionality for canned presubmit checks to work.
193
194 To avoid excessive Gerrit calls, caches the results.
195 """
196
197 def __init__(self, host):
198 self.host = host
199 self.cache = {}
200
201 def _FetchChangeDetail(self, issue):
202 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100203 try:
204 return gerrit_util.GetChangeDetail(
205 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700206 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100207 except gerrit_util.GerritError as e:
208 if e.http_status == 404:
209 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
210 'no credentials to fetch issue details' % issue)
211 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000212
213 def GetChangeInfo(self, issue):
214 """Returns labels and all revisions (patchsets) for this issue.
215
216 The result is a dictionary according to Gerrit REST Api.
217 https://gerrit-review.googlesource.com/Documentation/rest-api.html
218
219 However, API isn't very clear what's inside, so see tests for example.
220 """
221 assert issue
222 cache_key = int(issue)
223 if cache_key not in self.cache:
224 self.cache[cache_key] = self._FetchChangeDetail(issue)
225 return self.cache[cache_key]
226
227 def GetChangeDescription(self, issue, patchset=None):
228 """If patchset is none, fetches current patchset."""
229 info = self.GetChangeInfo(issue)
230 # info is a reference to cache. We'll modify it here adding description to
231 # it to the right patchset, if it is not yet there.
232
233 # Find revision info for the patchset we want.
234 if patchset is not None:
235 for rev, rev_info in info['revisions'].iteritems():
236 if str(rev_info['_number']) == str(patchset):
237 break
238 else:
239 raise Exception('patchset %s doesn\'t exist in issue %s' % (
240 patchset, issue))
241 else:
242 rev = info['current_revision']
243 rev_info = info['revisions'][rev]
244
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100245 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000246
247 def GetChangeOwner(self, issue):
248 return self.GetChangeInfo(issue)['owner']['email']
249
250 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700251 changeinfo = self.GetChangeInfo(issue)
252 if approving_only:
253 labelinfo = changeinfo.get('labels', {}).get('Code-Review', {})
254 values = labelinfo.get('values', {}).keys()
255 try:
256 max_value = max(int(v) for v in values)
257 reviewers = [r for r in labelinfo.get('all', [])
258 if r.get('value', 0) == max_value]
259 except ValueError: # values is the empty list
260 reviewers = []
261 else:
262 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
263 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000264
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000265
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000266class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000267 """An instance of OutputApi gets passed to presubmit scripts so that they
268 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000269 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000270 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000271 PresubmitError = _PresubmitError
272 PresubmitPromptWarning = _PresubmitPromptWarning
273 PresubmitNotifyResult = _PresubmitNotifyResult
274 MailTextResult = _MailTextResult
275
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000276 def __init__(self, is_committing):
277 self.is_committing = is_committing
278
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000279 def PresubmitPromptOrNotify(self, *args, **kwargs):
280 """Warn the user when uploading, but only notify if committing."""
281 if self.is_committing:
282 return self.PresubmitNotifyResult(*args, **kwargs)
283 return self.PresubmitPromptWarning(*args, **kwargs)
284
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800285 def EnsureCQIncludeTrybotsAreAdded(self, cl, bots_to_include, message):
286 """Helper for any PostUploadHook wishing to add CQ_INCLUDE_TRYBOTS.
287
288 Merges the bots_to_include into the current CQ_INCLUDE_TRYBOTS list,
289 keeping it alphabetically sorted. Returns the results that should be
290 returned from the PostUploadHook.
291
292 Args:
293 cl: The git_cl.Changelist object.
294 bots_to_include: A list of strings of bots to include, in the form
295 "master:slave".
296 message: A message to be printed in the case that
297 CQ_INCLUDE_TRYBOTS was updated.
298 """
299 description = cl.GetDescription(force=True)
Aaron Gableb584c4f2017-04-26 16:28:08 -0700300 include_re = re.compile(r'^CQ_INCLUDE_TRYBOTS=(.*)$', re.M | re.I)
301
302 prior_bots = []
303 if cl.IsGerrit():
304 trybot_footers = git_footers.parse_footers(description).get(
305 git_footers.normalize_name('Cq-Include-Trybots'), [])
306 for f in trybot_footers:
307 prior_bots += [b.strip() for b in f.split(';') if b.strip()]
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800308 else:
Aaron Gableb584c4f2017-04-26 16:28:08 -0700309 trybot_tags = include_re.finditer(description)
310 for t in trybot_tags:
311 prior_bots += [b.strip() for b in t.group(1).split(';') if b.strip()]
312
313 if set(prior_bots) >= set(bots_to_include):
314 return []
315 all_bots = ';'.join(sorted(set(prior_bots) | set(bots_to_include)))
316
317 if cl.IsGerrit():
318 description = git_footers.remove_footer(
319 description, 'Cq-Include-Trybots')
320 description = git_footers.add_footer(
321 description, 'Cq-Include-Trybots', all_bots,
322 before_keys=['Change-Id'])
323 else:
324 new_include_trybots = 'CQ_INCLUDE_TRYBOTS=%s' % all_bots
325 m = include_re.search(description)
326 if m:
327 description = include_re.sub(new_include_trybots, description)
Kenneth Russelldf6e7342017-04-24 17:07:41 -0700328 else:
Aaron Gableb584c4f2017-04-26 16:28:08 -0700329 description = '%s\n%s\n' % (description, new_include_trybots)
330
331 cl.UpdateDescription(description, force=True)
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800332 return [self.PresubmitNotifyResult(message)]
333
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000334
335class InputApi(object):
336 """An instance of this object is passed to presubmit scripts so they can
337 know stuff about the change they're looking at.
338 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000339 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800340 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000341
maruel@chromium.org3410d912009-06-09 20:56:16 +0000342 # File extensions that are considered source files from a style guide
343 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000344 #
345 # Files without an extension aren't included in the list. If you want to
346 # filter them as source files, add r"(^|.*?[\\\/])[^.]+$" to the white list.
347 # Note that ALL CAPS files are black listed in DEFAULT_BLACK_LIST below.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000348 DEFAULT_WHITE_LIST = (
349 # C++ and friends
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000350 r".+\.c$", r".+\.cc$", r".+\.cpp$", r".+\.h$", r".+\.m$", r".+\.mm$",
351 r".+\.inl$", r".+\.asm$", r".+\.hxx$", r".+\.hpp$", r".+\.s$", r".+\.S$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000352 # Scripts
maruel@chromium.orgfe1211a2011-05-28 18:54:17 +0000353 r".+\.js$", r".+\.py$", r".+\.sh$", r".+\.rb$", r".+\.pl$", r".+\.pm$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000354 # Other
estade@chromium.orgae7af922012-01-27 14:51:13 +0000355 r".+\.java$", r".+\.mk$", r".+\.am$", r".+\.css$"
maruel@chromium.org3410d912009-06-09 20:56:16 +0000356 )
357
358 # Path regexp that should be excluded from being considered containing source
359 # files. Don't modify this list from a presubmit script!
360 DEFAULT_BLACK_LIST = (
gavinp@chromium.org656326d2012-08-13 00:43:57 +0000361 r"testing_support[\\\/]google_appengine[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000362 r".*\bexperimental[\\\/].*",
primiano@chromium.orgb9658c32015-10-06 10:50:13 +0000363 # Exclude third_party/.* but NOT third_party/WebKit (crbug.com/539768).
364 r".*\bthird_party[\\\/](?!WebKit[\\\/]).*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000365 # Output directories (just in case)
366 r".*\bDebug[\\\/].*",
367 r".*\bRelease[\\\/].*",
368 r".*\bxcodebuild[\\\/].*",
thakis@chromium.orgc1c96352013-10-09 19:50:27 +0000369 r".*\bout[\\\/].*",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000370 # All caps files like README and LICENCE.
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000371 r".*\b[A-Z0-9_]{2,}$",
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000372 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
maruel@chromium.org5d0dc432011-01-03 02:40:37 +0000373 r"(|.*[\\\/])\.git[\\\/].*",
374 r"(|.*[\\\/])\.svn[\\\/].*",
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000375 # There is no point in processing a patch file.
376 r".+\.diff$",
377 r".+\.patch$",
maruel@chromium.org3410d912009-06-09 20:56:16 +0000378 )
379
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000380 def __init__(self, change, presubmit_path, is_committing,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000381 rietveld_obj, verbose, gerrit_obj=None, dry_run=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000382 """Builds an InputApi object.
383
384 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000385 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000386 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000387 is_committing: True if the change is about to be committed.
maruel@chromium.org239f4112011-06-03 20:08:23 +0000388 rietveld_obj: rietveld.Rietveld client object
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000389 gerrit_obj: provides basic Gerrit codereview functionality.
390 dry_run: if true, some Checks will be skipped.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000391 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000392 # Version number of the presubmit_support script.
393 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000394 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000395 self.is_committing = is_committing
maruel@chromium.org239f4112011-06-03 20:08:23 +0000396 self.rietveld = rietveld_obj
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000397 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000398 self.dry_run = dry_run
maruel@chromium.orgcab38e92011-04-09 00:30:51 +0000399 # TBD
400 self.host_url = 'http://codereview.chromium.org'
401 if self.rietveld:
maruel@chromium.org239f4112011-06-03 20:08:23 +0000402 self.host_url = self.rietveld.url
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000403
404 # We expose various modules and functions as attributes of the input_api
405 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900406 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000407 self.basename = os.path.basename
408 self.cPickle = cPickle
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000409 self.cpplint = cpplint
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000410 self.cStringIO = cStringIO
dcheng091b7db2016-06-16 01:27:51 -0700411 self.fnmatch = fnmatch
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000412 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000413 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000414 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000415 self.os_listdir = os.listdir
416 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000417 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000418 self.os_stat = os.stat
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000419 self.pickle = pickle
420 self.marshal = marshal
421 self.re = re
422 self.subprocess = subprocess
423 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000424 self.time = time
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000425 self.traceback = traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +0000426 self.unittest = unittest
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000427 self.urllib2 = urllib2
428
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000429 # To easily fork python.
430 self.python_executable = sys.executable
431 self.environ = os.environ
432
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000433 # InputApi.platform is the platform you're currently running on.
434 self.platform = sys.platform
435
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000436 self.cpu_count = multiprocessing.cpu_count()
437
Aaron Gable5254da12017-09-06 21:05:39 +0000438 # this is done here because in RunTests, the current working directory has
iannucci@chromium.orgd61a4952015-07-01 23:21:26 +0000439 # changed, which causes Pool() to explode fantastically when run on windows
440 # (because it tries to load the __main__ module, which imports lots of
441 # things relative to the current working directory).
Aaron Gable5254da12017-09-06 21:05:39 +0000442 self._run_tests_pool = multiprocessing.Pool(self.cpu_count)
iannucci@chromium.orgd61a4952015-07-01 23:21:26 +0000443
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000444 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000445 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000446
447 # We carry the canned checks so presubmit scripts can easily use them.
448 self.canned_checks = presubmit_canned_checks
449
Jochen Eisinger72606f82017-04-04 10:44:18 +0200450
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000451 # TODO(dpranke): figure out a list of all approved owners for a repo
452 # in order to be able to handle wildcard OWNERS files?
453 self.owners_db = owners.Database(change.RepositoryRoot(),
Jochen Eisinger72606f82017-04-04 10:44:18 +0200454 fopen=file, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200455 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000456 self.verbose = verbose
Dan Jacques94652a32017-10-09 23:18:46 -0400457 self.is_windows = sys.platform == 'win32'
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000458 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000459
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000460 # Replace <hash_map> and <hash_set> as headers that need to be included
danakj@chromium.org18278522013-06-11 22:42:32 +0000461 # with "base/containers/hash_tables.h" instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000462 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800463 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000464 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000465 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000466 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
467 for (a, b, header) in cpplint._re_pattern_templates
468 ]
469
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000470 def PresubmitLocalPath(self):
471 """Returns the local path of the presubmit script currently being run.
472
473 This is useful if you don't want to hard-code absolute paths in the
474 presubmit script. For example, It can be used to find another file
475 relative to the PRESUBMIT.py script, so the whole tree can be branched and
476 the presubmit script still works, without editing its content.
477 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000478 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000479
agable0b65e732016-11-22 09:25:46 -0800480 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000481 """Same as input_api.change.AffectedFiles() except only lists files
482 (and optionally directories) in the same directory as the current presubmit
483 script, or subdirectories thereof.
484 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000485 dir_with_slash = normpath("%s/" % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000486 if len(dir_with_slash) == 1:
487 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000488
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000489 return filter(
490 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
agable0b65e732016-11-22 09:25:46 -0800491 self.change.AffectedFiles(include_deletes, file_filter))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000492
agable0b65e732016-11-22 09:25:46 -0800493 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000494 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800495 paths = [af.LocalPath() for af in self.AffectedFiles()]
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000496 logging.debug("LocalPaths: %s", paths)
497 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000498
agable0b65e732016-11-22 09:25:46 -0800499 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000500 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800501 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000502
agable0b65e732016-11-22 09:25:46 -0800503 def AffectedTestableFiles(self, include_deletes=None):
504 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000505 in the same directory as the current presubmit script, or subdirectories
506 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000507 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000508 if include_deletes is not None:
agable0b65e732016-11-22 09:25:46 -0800509 warn("AffectedTestableFiles(include_deletes=%s)"
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000510 " is deprecated and ignored" % str(include_deletes),
511 category=DeprecationWarning,
512 stacklevel=2)
agable0b65e732016-11-22 09:25:46 -0800513 return filter(lambda x: x.IsTestableFile(),
514 self.AffectedFiles(include_deletes=False))
515
516 def AffectedTextFiles(self, include_deletes=None):
517 """An alias to AffectedTestableFiles for backwards compatibility."""
518 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000519
maruel@chromium.org3410d912009-06-09 20:56:16 +0000520 def FilterSourceFile(self, affected_file, white_list=None, black_list=None):
521 """Filters out files that aren't considered "source file".
522
523 If white_list or black_list is None, InputApi.DEFAULT_WHITE_LIST
524 and InputApi.DEFAULT_BLACK_LIST is used respectively.
525
526 The lists will be compiled as regular expression and
527 AffectedFile.LocalPath() needs to pass both list.
528
529 Note: Copy-paste this function to suit your needs or use a lambda function.
530 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000531 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000532 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000533 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000534 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000535 return True
536 return False
537 return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and
538 not Find(affected_file, black_list or self.DEFAULT_BLACK_LIST))
539
540 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800541 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000542
543 If source_file is None, InputApi.FilterSourceFile() is used.
544 """
545 if not source_file:
546 source_file = self.FilterSourceFile
agable0b65e732016-11-22 09:25:46 -0800547 return filter(source_file, self.AffectedTestableFiles())
maruel@chromium.org3410d912009-06-09 20:56:16 +0000548
549 def RightHandSideLines(self, source_file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000550 """An iterator over all text lines in "new" version of changed files.
551
552 Only lists lines from new or modified text files in the change that are
553 contained by the directory of the currently executing presubmit script.
554
555 This is useful for doing line-by-line regex checks, like checking for
556 trailing whitespace.
557
558 Yields:
559 a 3 tuple:
560 the AffectedFile instance of the current file;
561 integer line number (1-based); and
562 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000563
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000564 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000565 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000566 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000567 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000568
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000569 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000570 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000571
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000572 Deny reading anything outside the repository.
573 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000574 if isinstance(file_item, AffectedFile):
575 file_item = file_item.AbsoluteLocalPath()
576 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000577 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000578 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000579
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000580 @property
581 def tbr(self):
582 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400583 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000584
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000585 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000586 tests = []
587 msgs = []
588 for t in tests_mix:
589 if isinstance(t, OutputApi.PresubmitResult):
590 msgs.append(t)
591 else:
592 assert issubclass(t.message, _PresubmitResult)
593 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000594 if self.verbose:
595 t.info = _PresubmitNotifyResult
ilevy@chromium.org5678d332013-05-18 01:34:14 +0000596 if len(tests) > 1 and parallel:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000597 # async recipe works around multiprocessing bug handling Ctrl-C
iannucci@chromium.orgd61a4952015-07-01 23:21:26 +0000598 msgs.extend(self._run_tests_pool.map_async(CallCommand, tests).get(99999))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000599 else:
600 msgs.extend(map(CallCommand, tests))
601 return [m for m in msgs if m]
602
scottmg86099d72016-09-01 09:16:51 -0700603 def ShutdownPool(self):
604 self._run_tests_pool.close()
605 self._run_tests_pool.join()
606 self._run_tests_pool = None
607
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000608
nick@chromium.orgff526192013-06-10 19:30:26 +0000609class _DiffCache(object):
610 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000611 def __init__(self, upstream=None):
612 """Stores the upstream revision against which all diffs will be computed."""
613 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000614
615 def GetDiff(self, path, local_root):
616 """Get the diff for a particular path."""
617 raise NotImplementedError()
618
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700619 def GetOldContents(self, path, local_root):
620 """Get the old version for a particular path."""
621 raise NotImplementedError()
622
nick@chromium.orgff526192013-06-10 19:30:26 +0000623
nick@chromium.orgff526192013-06-10 19:30:26 +0000624class _GitDiffCache(_DiffCache):
625 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000626 def __init__(self, upstream):
627 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000628 self._diffs_by_file = None
629
630 def GetDiff(self, path, local_root):
631 if not self._diffs_by_file:
632 # Compute a single diff for all files and parse the output; should
633 # with git this is much faster than computing one diff for each file.
634 diffs = {}
635
636 # Don't specify any filenames below, because there are command line length
637 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000638 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
639 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000640
641 # This regex matches the path twice, separated by a space. Note that
642 # filename itself may contain spaces.
643 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
644 current_diff = []
645 keep_line_endings = True
646 for x in unified_diff.splitlines(keep_line_endings):
647 match = file_marker.match(x)
648 if match:
649 # Marks the start of a new per-file section.
650 diffs[match.group('filename')] = current_diff = [x]
651 elif x.startswith('diff --git'):
652 raise PresubmitFailure('Unexpected diff line: %s' % x)
653 else:
654 current_diff.append(x)
655
656 self._diffs_by_file = dict(
657 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
658
659 if path not in self._diffs_by_file:
660 raise PresubmitFailure(
661 'Unified diff did not contain entry for file %s' % path)
662
663 return self._diffs_by_file[path]
664
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700665 def GetOldContents(self, path, local_root):
666 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
667
nick@chromium.orgff526192013-06-10 19:30:26 +0000668
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000669class AffectedFile(object):
670 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000671
672 DIFF_CACHE = _DiffCache
673
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000674 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800675 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000676 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000677 self._path = path
678 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000679 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000680 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000681 self._cached_changed_contents = None
682 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000683 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700684 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000685
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000686 def LocalPath(self):
687 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400688
689 This should be used for error messages but not for accessing files,
690 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
691 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000692 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000693 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000694
695 def AbsoluteLocalPath(self):
696 """Returns the absolute path of this file on the local disk.
697 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000698 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000699
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000700 def Action(self):
701 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000702 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000703
agable0b65e732016-11-22 09:25:46 -0800704 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000705 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000706
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000707 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000708 raise NotImplementedError() # Implement when needed
709
agable0b65e732016-11-22 09:25:46 -0800710 def IsTextFile(self):
711 """An alias to IsTestableFile for backwards compatibility."""
712 return self.IsTestableFile()
713
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700714 def OldContents(self):
715 """Returns an iterator over the lines in the old version of file.
716
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700717 The old version is the file before any modifications in the user's
718 workspace, i.e. the "left hand side".
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700719
720 Contents will be empty if the file is a directory or does not exist.
721 Note: The carriage returns (LF or CR) are stripped off.
722 """
723 return self._diff_cache.GetOldContents(self.LocalPath(),
724 self._local_root).splitlines()
725
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000726 def NewContents(self):
727 """Returns an iterator over the lines in the new version of file.
728
729 The new version is the file in the user's workspace, i.e. the "right hand
730 side".
731
732 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000733 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000734 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000735 if self._cached_new_contents is None:
736 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -0800737 try:
738 self._cached_new_contents = gclient_utils.FileRead(
739 self.AbsoluteLocalPath(), 'rU').splitlines()
740 except IOError:
741 pass # File not found? That's fine; maybe it was deleted.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000742 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000743
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000744 def ChangedContents(self):
745 """Returns a list of tuples (line number, line text) of all new lines.
746
747 This relies on the scm diff output describing each changed code section
748 with a line of the form
749
750 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
751 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000752 if self._cached_changed_contents is not None:
753 return self._cached_changed_contents[:]
754 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000755 line_num = 0
756
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000757 for line in self.GenerateScmDiff().splitlines():
758 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
759 if m:
760 line_num = int(m.groups(1)[0])
761 continue
762 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000763 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000764 if not line.startswith('-'):
765 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000766 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000767
maruel@chromium.org5de13972009-06-10 18:16:06 +0000768 def __str__(self):
769 return self.LocalPath()
770
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000771 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +0000772 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000773
maruel@chromium.org58407af2011-04-12 23:15:57 +0000774
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000775class GitAffectedFile(AffectedFile):
776 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000777 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800778 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000779
nick@chromium.orgff526192013-06-10 19:30:26 +0000780 DIFF_CACHE = _GitDiffCache
781
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000782 def __init__(self, *args, **kwargs):
783 AffectedFile.__init__(self, *args, **kwargs)
784 self._server_path = None
agable0b65e732016-11-22 09:25:46 -0800785 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000786
agable0b65e732016-11-22 09:25:46 -0800787 def IsTestableFile(self):
788 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000789 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -0800790 # A deleted file is not testable.
791 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000792 else:
agable0b65e732016-11-22 09:25:46 -0800793 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
794 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000795
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000796
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000797class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000798 """Describe a change.
799
800 Used directly by the presubmit scripts to query the current change being
801 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000802
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000803 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +0000804 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000805 self.KEY: equivalent to tags['KEY']
806 """
807
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000808 _AFFECTED_FILES = AffectedFile
809
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000810 # Matches key/value (or "tag") lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +0000811 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +0000812 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000813 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000814
maruel@chromium.org58407af2011-04-12 23:15:57 +0000815 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000816 self, name, description, local_root, files, issue, patchset, author,
817 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000818 if files is None:
819 files = []
820 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +0000821 # Convert root into an absolute path.
822 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000823 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000824 self.issue = issue
825 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +0000826 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000827
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000828 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000829 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000830 self._description_without_tags = ''
831 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000832
maruel@chromium.orge085d812011-10-10 19:49:15 +0000833 assert all(
834 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
835
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000836 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000837 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +0000838 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
839 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +0000840 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000841
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000842 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000843 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000844 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000845
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000846 def DescriptionText(self):
847 """Returns the user-entered changelist description, minus tags.
848
849 Any line in the user-provided description starting with e.g. "FOO="
850 (whitespace permitted before and around) is considered a tag line. Such
851 lines are stripped out of the description this function returns.
852 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000853 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000854
855 def FullDescriptionText(self):
856 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +0000857 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000858
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000859 def SetDescriptionText(self, description):
860 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +0000861
isherman@chromium.orgb5cded62014-03-25 17:47:57 +0000862 Also updates the list of tags."""
863 self._full_description = description
864
865 # From the description text, build up a dictionary of key/value pairs
866 # plus the description minus all key/value or "tag" lines.
867 description_without_tags = []
868 self.tags = {}
869 for line in self._full_description.splitlines():
870 m = self.TAG_LINE_RE.match(line)
871 if m:
872 self.tags[m.group('key')] = m.group('value')
873 else:
874 description_without_tags.append(line)
875
876 # Change back to text and remove whitespace at end.
877 self._description_without_tags = (
878 '\n'.join(description_without_tags).rstrip())
879
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000880 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000881 """Returns the repository (checkout) root directory for this change,
882 as an absolute path.
883 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000884 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000885
886 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +0000887 """Return tags directly as attributes on the object."""
888 if not re.match(r"^[A-Z_]*$", attr):
889 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +0000890 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000891
Aaron Gablefc03e672017-05-15 14:09:42 -0700892 def BugsFromDescription(self):
893 """Returns all bugs referenced in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -0700894 tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()]
895 footers = git_footers.parse_footers(self._full_description).get('Bug', [])
896 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -0700897
898 def ReviewersFromDescription(self):
899 """Returns all reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -0700900 # We don't support a "R:" git-footer for reviewers; that is in metadata.
901 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
902 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -0700903
904 def TBRsFromDescription(self):
905 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -0700906 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
907 # TODO(agable): Remove support for 'Tbr:' when TBRs are programmatically
908 # determined by self-CR+1s.
909 footers = git_footers.parse_footers(self._full_description).get('Tbr', [])
910 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -0700911
912 # TODO(agable): Delete these once we're sure they're unused.
913 @property
914 def BUG(self):
915 return ','.join(self.BugsFromDescription())
916 @property
917 def R(self):
918 return ','.join(self.ReviewersFromDescription())
919 @property
920 def TBR(self):
921 return ','.join(self.TBRsFromDescription())
922
agable@chromium.org40a3d0b2014-05-15 01:59:16 +0000923 def AllFiles(self, root=None):
924 """List all files under source control in the repo."""
925 raise NotImplementedError()
926
agable0b65e732016-11-22 09:25:46 -0800927 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000928 """Returns a list of AffectedFile instances for all files in the change.
929
930 Args:
931 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +0000932 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000933
934 Returns:
935 [AffectedFile(path, action), AffectedFile(path, action)]
936 """
agable0b65e732016-11-22 09:25:46 -0800937 affected = filter(file_filter, self._affected_files)
sail@chromium.org5538e022011-05-12 17:53:16 +0000938
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000939 if include_deletes:
940 return affected
Lei Zhang9611c4c2017-04-04 01:41:56 -0700941 return filter(lambda x: x.Action() != 'D', affected)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000942
agable0b65e732016-11-22 09:25:46 -0800943 def AffectedTestableFiles(self, include_deletes=None):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000944 """Return a list of the existing text files in a change."""
945 if include_deletes is not None:
agable0b65e732016-11-22 09:25:46 -0800946 warn("AffectedTeestableFiles(include_deletes=%s)"
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000947 " is deprecated and ignored" % str(include_deletes),
948 category=DeprecationWarning,
949 stacklevel=2)
agable0b65e732016-11-22 09:25:46 -0800950 return filter(lambda x: x.IsTestableFile(),
951 self.AffectedFiles(include_deletes=False))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000952
agable0b65e732016-11-22 09:25:46 -0800953 def AffectedTextFiles(self, include_deletes=None):
954 """An alias to AffectedTestableFiles for backwards compatibility."""
955 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000956
agable0b65e732016-11-22 09:25:46 -0800957 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000958 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -0800959 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000960
agable0b65e732016-11-22 09:25:46 -0800961 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000962 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -0800963 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000964
965 def RightHandSideLines(self):
966 """An iterator over all text lines in "new" version of changed files.
967
968 Lists lines from new or modified text files in the change.
969
970 This is useful for doing line-by-line regex checks, like checking for
971 trailing whitespace.
972
973 Yields:
974 a 3 tuple:
975 the AffectedFile instance of the current file;
976 integer line number (1-based); and
977 the contents of the line as a string.
978 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000979 return _RightHandSideLinesImpl(
980 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -0800981 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +0000982
Jochen Eisingerd0573ec2017-04-13 10:55:06 +0200983 def OriginalOwnersFiles(self):
984 """A map from path names of affected OWNERS files to their old content."""
985 def owners_file_filter(f):
986 return 'OWNERS' in os.path.split(f.LocalPath())[1]
987 files = self.AffectedFiles(file_filter=owners_file_filter)
988 return dict([(f.LocalPath(), f.OldContents()) for f in files])
989
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000990
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000991class GitChange(Change):
992 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +0000993 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000994
agable@chromium.org40a3d0b2014-05-15 01:59:16 +0000995 def AllFiles(self, root=None):
996 """List all files under source control in the repo."""
997 root = root or self.RepositoryRoot()
998 return subprocess.check_output(
999 ['git', 'ls-files', '--', '.'], cwd=root).splitlines()
1000
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001001
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001002def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001003 """Finds all presubmit files that apply to a given set of source files.
1004
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001005 If inherit-review-settings-ok is present right under root, looks for
1006 PRESUBMIT.py in directories enclosing root.
1007
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001008 Args:
1009 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001010 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001011
1012 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001013 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001014 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001015 files = [normpath(os.path.join(root, f)) for f in files]
1016
1017 # List all the individual directories containing files.
1018 directories = set([os.path.dirname(f) for f in files])
1019
1020 # Ignore root if inherit-review-settings-ok is present.
1021 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1022 root = None
1023
1024 # Collect all unique directories that may contain PRESUBMIT.py.
1025 candidates = set()
1026 for directory in directories:
1027 while True:
1028 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001029 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001030 candidates.add(directory)
1031 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001032 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001033 parent_dir = os.path.dirname(directory)
1034 if parent_dir == directory:
1035 # We hit the system root directory.
1036 break
1037 directory = parent_dir
1038
1039 # Look for PRESUBMIT.py in all candidate directories.
1040 results = []
1041 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001042 try:
1043 for f in os.listdir(directory):
1044 p = os.path.join(directory, f)
1045 if os.path.isfile(p) and re.match(
1046 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1047 results.append(p)
1048 except OSError:
1049 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001050
tobiasjs2836bcf2016-08-16 04:08:16 -07001051 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001052 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001053
1054
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001055class GetTryMastersExecuter(object):
1056 @staticmethod
1057 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1058 """Executes GetPreferredTryMasters() from a single presubmit script.
1059
1060 Args:
1061 script_text: The text of the presubmit script.
1062 presubmit_path: Project script to run.
1063 project: Project name to pass to presubmit script for bot selection.
1064
1065 Return:
1066 A map of try masters to map of builders to set of tests.
1067 """
1068 context = {}
1069 try:
1070 exec script_text in context
1071 except Exception, e:
1072 raise PresubmitFailure('"%s" had an exception.\n%s'
1073 % (presubmit_path, e))
1074
1075 function_name = 'GetPreferredTryMasters'
1076 if function_name not in context:
1077 return {}
1078 get_preferred_try_masters = context[function_name]
1079 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1080 raise PresubmitFailure(
1081 'Expected function "GetPreferredTryMasters" to take two arguments.')
1082 return get_preferred_try_masters(project, change)
1083
1084
rmistry@google.com5626a922015-02-26 14:03:30 +00001085class GetPostUploadExecuter(object):
1086 @staticmethod
1087 def ExecPresubmitScript(script_text, presubmit_path, cl, change):
1088 """Executes PostUploadHook() from a single presubmit script.
1089
1090 Args:
1091 script_text: The text of the presubmit script.
1092 presubmit_path: Project script to run.
1093 cl: The Changelist object.
1094 change: The Change object.
1095
1096 Return:
1097 A list of results objects.
1098 """
1099 context = {}
1100 try:
1101 exec script_text in context
1102 except Exception, e:
1103 raise PresubmitFailure('"%s" had an exception.\n%s'
1104 % (presubmit_path, e))
1105
1106 function_name = 'PostUploadHook'
1107 if function_name not in context:
1108 return {}
1109 post_upload_hook = context[function_name]
1110 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1111 raise PresubmitFailure(
1112 'Expected function "PostUploadHook" to take three arguments.')
1113 return post_upload_hook(cl, change, OutputApi(False))
1114
1115
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001116def _MergeMasters(masters1, masters2):
1117 """Merges two master maps. Merges also the tests of each builder."""
1118 result = {}
1119 for (master, builders) in itertools.chain(masters1.iteritems(),
1120 masters2.iteritems()):
1121 new_builders = result.setdefault(master, {})
1122 for (builder, tests) in builders.iteritems():
1123 new_builders.setdefault(builder, set([])).update(tests)
1124 return result
1125
1126
1127def DoGetTryMasters(change,
1128 changed_files,
1129 repository_root,
1130 default_presubmit,
1131 project,
1132 verbose,
1133 output_stream):
1134 """Get the list of try masters from the presubmit scripts.
1135
1136 Args:
1137 changed_files: List of modified files.
1138 repository_root: The repository root.
1139 default_presubmit: A default presubmit script to execute in any case.
1140 project: Optional name of a project used in selecting trybots.
1141 verbose: Prints debug info.
1142 output_stream: A stream to write debug output to.
1143
1144 Return:
1145 Map of try masters to map of builders to set of tests.
1146 """
1147 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1148 if not presubmit_files and verbose:
1149 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1150 results = {}
1151 executer = GetTryMastersExecuter()
1152
1153 if default_presubmit:
1154 if verbose:
1155 output_stream.write("Running default presubmit script.\n")
1156 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1157 results = _MergeMasters(results, executer.ExecPresubmitScript(
1158 default_presubmit, fake_path, project, change))
1159 for filename in presubmit_files:
1160 filename = os.path.abspath(filename)
1161 if verbose:
1162 output_stream.write("Running %s\n" % filename)
1163 # Accept CRLF presubmit script.
1164 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1165 results = _MergeMasters(results, executer.ExecPresubmitScript(
1166 presubmit_script, filename, project, change))
1167
1168 # Make sets to lists again for later JSON serialization.
1169 for builders in results.itervalues():
1170 for builder in builders:
1171 builders[builder] = list(builders[builder])
1172
1173 if results and verbose:
1174 output_stream.write('%s\n' % str(results))
1175 return results
1176
1177
rmistry@google.com5626a922015-02-26 14:03:30 +00001178def DoPostUploadExecuter(change,
1179 cl,
1180 repository_root,
1181 verbose,
1182 output_stream):
1183 """Execute the post upload hook.
1184
1185 Args:
1186 change: The Change object.
1187 cl: The Changelist object.
1188 repository_root: The repository root.
1189 verbose: Prints debug info.
1190 output_stream: A stream to write debug output to.
1191 """
1192 presubmit_files = ListRelevantPresubmitFiles(
1193 change.LocalPaths(), repository_root)
1194 if not presubmit_files and verbose:
1195 output_stream.write("Warning, no PRESUBMIT.py found.\n")
1196 results = []
1197 executer = GetPostUploadExecuter()
1198 # The root presubmit file should be executed after the ones in subdirectories.
1199 # i.e. the specific post upload hooks should run before the general ones.
1200 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1201 presubmit_files.reverse()
1202
1203 for filename in presubmit_files:
1204 filename = os.path.abspath(filename)
1205 if verbose:
1206 output_stream.write("Running %s\n" % filename)
1207 # Accept CRLF presubmit script.
1208 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1209 results.extend(executer.ExecPresubmitScript(
1210 presubmit_script, filename, cl, change))
1211 output_stream.write('\n')
1212 if results:
1213 output_stream.write('** Post Upload Hook Messages **\n')
1214 for result in results:
1215 result.handle(output_stream)
1216 output_stream.write('\n')
1217
1218 return results
1219
1220
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001221class PresubmitExecuter(object):
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001222 def __init__(self, change, committing, rietveld_obj, verbose,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001223 gerrit_obj=None, dry_run=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001224 """
1225 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001226 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001227 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@chromium.org239f4112011-06-03 20:08:23 +00001228 rietveld_obj: rietveld.Rietveld client object.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001229 gerrit_obj: provides basic Gerrit codereview functionality.
1230 dry_run: if true, some Checks will be skipped.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001231 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001232 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001233 self.committing = committing
maruel@chromium.org239f4112011-06-03 20:08:23 +00001234 self.rietveld = rietveld_obj
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001235 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001236 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001237 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001238
1239 def ExecPresubmitScript(self, script_text, presubmit_path):
1240 """Executes a single presubmit script.
1241
1242 Args:
1243 script_text: The text of the presubmit script.
1244 presubmit_path: The path to the presubmit file (this will be reported via
1245 input_api.PresubmitLocalPath()).
1246
1247 Return:
1248 A list of result objects, empty if no problems.
1249 """
thakis@chromium.orgc6ef53a2014-11-04 00:13:54 +00001250
chase@chromium.org8e416c82009-10-06 04:30:44 +00001251 # Change to the presubmit file's directory to support local imports.
1252 main_path = os.getcwd()
1253 os.chdir(os.path.dirname(presubmit_path))
1254
1255 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001256 input_api = InputApi(self.change, presubmit_path, self.committing,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001257 self.rietveld, self.verbose,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001258 gerrit_obj=self.gerrit, dry_run=self.dry_run)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001259 context = {}
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001260 try:
1261 exec script_text in context
1262 except Exception, e:
1263 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001264
1265 # These function names must change if we make substantial changes to
1266 # the presubmit API that are not backwards compatible.
1267 if self.committing:
1268 function_name = 'CheckChangeOnCommit'
1269 else:
1270 function_name = 'CheckChangeOnUpload'
1271 if function_name in context:
wez@chromium.orga6d011e2013-03-26 17:31:49 +00001272 context['__args'] = (input_api, OutputApi(self.committing))
tobiasjs2836bcf2016-08-16 04:08:16 -07001273 logging.debug('Running %s in %s', function_name, presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001274 result = eval(function_name + '(*__args)', context)
tobiasjs2836bcf2016-08-16 04:08:16 -07001275 logging.debug('Running %s done.', function_name)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001276 if not (isinstance(result, types.TupleType) or
1277 isinstance(result, types.ListType)):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001278 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001279 'Presubmit functions must return a tuple or list')
1280 for item in result:
1281 if not isinstance(item, OutputApi.PresubmitResult):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001282 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001283 'All presubmit results must be of types derived from '
1284 'output_api.PresubmitResult')
1285 else:
1286 result = () # no error since the script doesn't care about current event.
1287
scottmg86099d72016-09-01 09:16:51 -07001288 input_api.ShutdownPool()
1289
chase@chromium.org8e416c82009-10-06 04:30:44 +00001290 # Return the process to the original working directory.
1291 os.chdir(main_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001292 return result
1293
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001294def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001295 committing,
1296 verbose,
1297 output_stream,
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001298 input_stream,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001299 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001300 may_prompt,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001301 rietveld_obj,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001302 gerrit_obj=None,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001303 dry_run=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001304 """Runs all presubmit checks that apply to the files in the change.
1305
1306 This finds all PRESUBMIT.py files in directories enclosing the files in the
1307 change (up to the repository root) and calls the relevant entrypoint function
1308 depending on whether the change is being committed or uploaded.
1309
1310 Prints errors, warnings and notifications. Prompts the user for warnings
1311 when needed.
1312
1313 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001314 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001315 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001316 verbose: Prints debug info.
1317 output_stream: A stream to write output from presubmit tests to.
1318 input_stream: A stream to read input from the user.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001319 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001320 may_prompt: Enable (y/n) questions on warning or error. If False,
1321 any questions are answered with yes by default.
maruel@chromium.org239f4112011-06-03 20:08:23 +00001322 rietveld_obj: rietveld.Rietveld object.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001323 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001324 dry_run: if true, some Checks will be skipped.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001325
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001326 Warning:
1327 If may_prompt is true, output_stream SHOULD be sys.stdout and input_stream
1328 SHOULD be sys.stdin.
1329
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001330 Return:
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001331 A PresubmitOutput object. Use output.should_continue() to figure out
1332 if there were errors or warnings and the caller should abort.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001333 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001334 old_environ = os.environ
1335 try:
1336 # Make sure python subprocesses won't generate .pyc files.
1337 os.environ = os.environ.copy()
1338 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001339
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001340 output = PresubmitOutput(input_stream, output_stream)
1341 if committing:
1342 output.write("Running presubmit commit checks ...\n")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001343 else:
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001344 output.write("Running presubmit upload checks ...\n")
1345 start_time = time.time()
1346 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001347 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001348 if not presubmit_files and verbose:
maruel@chromium.orgfae707b2011-09-15 18:57:58 +00001349 output.write("Warning, no PRESUBMIT.py found.\n")
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001350 results = []
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001351 executer = PresubmitExecuter(change, committing, rietveld_obj, verbose,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001352 gerrit_obj, dry_run)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001353 if default_presubmit:
1354 if verbose:
1355 output.write("Running default presubmit script.\n")
1356 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1357 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1358 for filename in presubmit_files:
1359 filename = os.path.abspath(filename)
1360 if verbose:
1361 output.write("Running %s\n" % filename)
1362 # Accept CRLF presubmit script.
1363 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1364 results += executer.ExecPresubmitScript(presubmit_script, filename)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001365
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001366 errors = []
1367 notifications = []
1368 warnings = []
1369 for result in results:
1370 if result.fatal:
1371 errors.append(result)
1372 elif result.should_prompt:
1373 warnings.append(result)
1374 else:
1375 notifications.append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001376
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001377 output.write('\n')
1378 for name, items in (('Messages', notifications),
1379 ('Warnings', warnings),
1380 ('ERRORS', errors)):
1381 if items:
1382 output.write('** Presubmit %s **\n' % name)
1383 for item in items:
1384 item.handle(output)
1385 output.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001386
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001387 total_time = time.time() - start_time
1388 if total_time > 1.0:
1389 output.write("Presubmit checks took %.1fs to calculate.\n\n" % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001390
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001391 if errors:
1392 output.fail()
1393 elif warnings:
1394 output.write('There were presubmit warnings. ')
1395 if may_prompt:
1396 output.prompt_yes_no('Are you sure you wish to continue? (y/N): ')
1397 else:
1398 output.write('Presubmit checks passed.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001399
1400 global _ASKED_FOR_FEEDBACK
1401 # Ask for feedback one time out of 5.
1402 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001403 output.write(
1404 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1405 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1406 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001407 _ASKED_FOR_FEEDBACK = True
1408 return output
1409 finally:
1410 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001411
1412
1413def ScanSubDirs(mask, recursive):
1414 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001415 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001416
1417 results = []
1418 for root, dirs, files in os.walk('.'):
1419 if '.svn' in dirs:
1420 dirs.remove('.svn')
1421 if '.git' in dirs:
1422 dirs.remove('.git')
1423 for name in files:
1424 if fnmatch.fnmatch(name, mask):
1425 results.append(os.path.join(root, name))
1426 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001427
1428
1429def ParseFiles(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001430 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001431 files = []
1432 for arg in args:
maruel@chromium.orge3608df2009-11-10 20:22:57 +00001433 files.extend([('M', f) for f in ScanSubDirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001434 return files
1435
1436
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001437def load_files(options, args):
1438 """Tries to determine the SCM."""
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001439 files = []
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001440 if args:
1441 files = ParseFiles(args, options.recursive)
agable0b65e732016-11-22 09:25:46 -08001442 change_scm = scm.determine_scm(options.root)
1443 if change_scm == 'git':
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001444 change_class = GitChange
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001445 upstream = options.upstream or None
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001446 if not files:
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001447 files = scm.GIT.CaptureStatus([], options.root, upstream)
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001448 else:
tobiasjs2836bcf2016-08-16 04:08:16 -07001449 logging.info('Doesn\'t seem under source control. Got %d files', len(args))
maruel@chromium.org9b31f162012-01-26 19:02:31 +00001450 if not files:
1451 return None, None
1452 change_class = Change
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001453 return change_class, files
1454
1455
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001456class NonexistantCannedCheckFilter(Exception):
1457 pass
1458
1459
1460@contextlib.contextmanager
1461def canned_check_filter(method_names):
1462 filtered = {}
1463 try:
1464 for method_name in method_names:
1465 if not hasattr(presubmit_canned_checks, method_name):
1466 raise NonexistantCannedCheckFilter(method_name)
1467 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1468 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1469 yield
1470 finally:
1471 for name, method in filtered.iteritems():
1472 setattr(presubmit_canned_checks, name, method)
1473
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001474
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001475def CallCommand(cmd_data):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001476 """Runs an external program, potentially from a child process created by the
1477 multiprocessing module.
1478
1479 multiprocessing needs a top level function with a single argument.
1480 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001481 cmd_data.kwargs['stdout'] = subprocess.PIPE
1482 cmd_data.kwargs['stderr'] = subprocess.STDOUT
1483 try:
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001484 start = time.time()
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001485 (out, _), code = subprocess.communicate(cmd_data.cmd, **cmd_data.kwargs)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001486 duration = time.time() - start
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001487 except OSError as e:
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001488 duration = time.time() - start
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001489 return cmd_data.message(
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001490 '%s exec failure (%4.2fs)\n %s' % (cmd_data.name, duration, e))
1491 if code != 0:
1492 return cmd_data.message(
1493 '%s (%4.2fs) failed\n%s' % (cmd_data.name, duration, out))
1494 if cmd_data.info:
1495 return cmd_data.info('%s (%4.2fs)' % (cmd_data.name, duration))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +00001496
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001497
sbc@chromium.org013731e2015-02-26 18:28:43 +00001498def main(argv=None):
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001499 parser = optparse.OptionParser(usage="%prog [options] <files...>",
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001500 version="%prog " + str(__version__))
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001501 parser.add_option("-c", "--commit", action="store_true", default=False,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001502 help="Use commit instead of upload checks")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001503 parser.add_option("-u", "--upload", action="store_false", dest='commit',
1504 help="Use upload instead of commit checks")
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001505 parser.add_option("-r", "--recursive", action="store_true",
1506 help="Act recursively")
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001507 parser.add_option("-v", "--verbose", action="count", default=0,
1508 help="Use 2 times for more debug info")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001509 parser.add_option("--name", default='no name')
maruel@chromium.org58407af2011-04-12 23:15:57 +00001510 parser.add_option("--author")
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001511 parser.add_option("--description", default='')
1512 parser.add_option("--issue", type='int', default=0)
1513 parser.add_option("--patchset", type='int', default=0)
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001514 parser.add_option("--root", default=os.getcwd(),
1515 help="Search for PRESUBMIT.py up to this directory. "
1516 "If inherit-review-settings-ok is present in this "
1517 "directory, parent directories up to the root file "
1518 "system directories will also be searched.")
agable@chromium.org2da1ade2014-04-30 17:40:45 +00001519 parser.add_option("--upstream",
1520 help="Git only: the base ref or upstream branch against "
1521 "which the diff should be computed.")
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001522 parser.add_option("--default_presubmit")
1523 parser.add_option("--may_prompt", action='store_true', default=False)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001524 parser.add_option("--skip_canned", action='append', default=[],
1525 help="A list of checks to skip which appear in "
1526 "presubmit_canned_checks. Can be provided multiple times "
1527 "to skip multiple canned checks.")
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001528 parser.add_option("--dry_run", action='store_true',
1529 help=optparse.SUPPRESS_HELP)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001530 parser.add_option("--gerrit_url", help=optparse.SUPPRESS_HELP)
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001531 parser.add_option("--gerrit_fetch", action='store_true',
1532 help=optparse.SUPPRESS_HELP)
maruel@chromium.org239f4112011-06-03 20:08:23 +00001533 parser.add_option("--rietveld_url", help=optparse.SUPPRESS_HELP)
1534 parser.add_option("--rietveld_email", help=optparse.SUPPRESS_HELP)
iannucci@chromium.org720fd7a2013-04-24 04:13:50 +00001535 parser.add_option("--rietveld_fetch", action='store_true', default=False,
1536 help=optparse.SUPPRESS_HELP)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001537 # These are for OAuth2 authentication for bots. See also apply_issue.py
1538 parser.add_option("--rietveld_email_file", help=optparse.SUPPRESS_HELP)
1539 parser.add_option("--rietveld_private_key_file", help=optparse.SUPPRESS_HELP)
1540
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001541 auth.add_auth_options(parser)
maruel@chromium.org82e5f282011-03-17 14:08:55 +00001542 options, args = parser.parse_args(argv)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001543 auth_config = auth.extract_auth_config_from_options(options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001544
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001545 if options.verbose >= 2:
maruel@chromium.org7444c502011-02-09 14:02:11 +00001546 logging.basicConfig(level=logging.DEBUG)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001547 elif options.verbose:
1548 logging.basicConfig(level=logging.INFO)
1549 else:
1550 logging.basicConfig(level=logging.ERROR)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001551
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001552 if (any((options.rietveld_url, options.rietveld_email_file,
1553 options.rietveld_fetch, options.rietveld_private_key_file))
1554 and any((options.gerrit_url, options.gerrit_fetch))):
1555 parser.error('Options for only codereview --rietveld_* or --gerrit_* '
1556 'allowed')
1557
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001558 if options.rietveld_email and options.rietveld_email_file:
1559 parser.error("Only one of --rietveld_email or --rietveld_email_file "
1560 "can be passed to this program.")
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001561 if options.rietveld_email_file:
1562 with open(options.rietveld_email_file, "rb") as f:
1563 options.rietveld_email = f.read().strip()
1564
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001565 change_class, files = load_files(options, args)
1566 if not change_class:
1567 parser.error('For unversioned directory, <files> is not optional.')
tobiasjs2836bcf2016-08-16 04:08:16 -07001568 logging.info('Found %d file(s).', len(files))
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001569
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001570 rietveld_obj, gerrit_obj = None, None
1571
maruel@chromium.org239f4112011-06-03 20:08:23 +00001572 if options.rietveld_url:
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001573 # The empty password is permitted: '' is not None.
djacques@chromium.org7b654f52014-04-15 04:02:32 +00001574 if options.rietveld_private_key_file:
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001575 rietveld_obj = rietveld.JwtOAuth2Rietveld(
1576 options.rietveld_url,
1577 options.rietveld_email,
1578 options.rietveld_private_key_file)
1579 else:
djacques@chromium.org7b654f52014-04-15 04:02:32 +00001580 rietveld_obj = rietveld.CachingRietveld(
1581 options.rietveld_url,
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001582 auth_config,
1583 options.rietveld_email)
iannucci@chromium.org720fd7a2013-04-24 04:13:50 +00001584 if options.rietveld_fetch:
1585 assert options.issue
1586 props = rietveld_obj.get_issue_properties(options.issue, False)
1587 options.author = props['owner_email']
1588 options.description = props['description']
1589 logging.info('Got author: "%s"', options.author)
1590 logging.info('Got description: """\n%s\n"""', options.description)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001591
1592 if options.gerrit_url and options.gerrit_fetch:
tandrii@chromium.org83b1b232016-04-29 16:33:19 +00001593 assert options.issue and options.patchset
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001594 rietveld_obj = None
1595 gerrit_obj = GerritAccessor(urlparse.urlparse(options.gerrit_url).netloc)
1596 options.author = gerrit_obj.GetChangeOwner(options.issue)
1597 options.description = gerrit_obj.GetChangeDescription(options.issue,
1598 options.patchset)
tandrii@chromium.org015ebae2016-04-25 19:37:22 +00001599 logging.info('Got author: "%s"', options.author)
1600 logging.info('Got description: """\n%s\n"""', options.description)
1601
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001602 try:
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001603 with canned_check_filter(options.skip_canned):
1604 results = DoPresubmitChecks(
1605 change_class(options.name,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001606 options.description,
1607 options.root,
1608 files,
1609 options.issue,
1610 options.patchset,
1611 options.author,
1612 upstream=options.upstream),
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001613 options.commit,
1614 options.verbose,
1615 sys.stdout,
1616 sys.stdin,
1617 options.default_presubmit,
1618 options.may_prompt,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001619 rietveld_obj,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001620 gerrit_obj,
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001621 options.dry_run)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001622 return not results.should_continue()
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001623 except NonexistantCannedCheckFilter, e:
1624 print >> sys.stderr, (
1625 'Attempted to skip nonexistent canned presubmit check: %s' % e.message)
1626 return 2
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001627 except PresubmitFailure, e:
1628 print >> sys.stderr, e
1629 print >> sys.stderr, 'Maybe your depot_tools is out of date?'
1630 print >> sys.stderr, 'If all fails, contact maruel@'
1631 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001632
1633
1634if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001635 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00001636 try:
1637 sys.exit(main())
1638 except KeyboardInterrupt:
1639 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07001640 sys.exit(2)